Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2
3         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
4         https://bugs.webkit.org/show_bug.cgi?id=196630
5
6         Reviewed by Wenson Hsieh.
7
8         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
9
10 2019-04-04  Youenn Fablet  <youenn@apple.com>
11
12         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
13         https://bugs.webkit.org/show_bug.cgi?id=196543
14
15         Reviewed by Alex Christensen.
16
17         * WebKitTestRunner/TestController.cpp:
18         (WTR::TestController::generatePageConfiguration):
19
20 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
21
22         [ews-app] Status bubble should not display skipped buildbot steps
23         https://bugs.webkit.org/show_bug.cgi?id=196584
24
25         Reviewed by Lucas Forschler.
26
27         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
28
29 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
30
31         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
32         https://bugs.webkit.org/show_bug.cgi?id=196620
33
34         Reviewed by Lucas Forschler.
35
36         * BuildSlaveSupport/ews-app/ews/config.py:
37
38 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
39
40         [Win] DumpRenderTreeWatchDog.py is not checked into source
41         https://bugs.webkit.org/show_bug.cgi?id=196567
42         <rdar://problem/49525901>
43
44         Reviewed by Lucas Forschler.
45
46         This script is used on Win EWS bots to terminate hanging DRT processes.
47
48         * EWSTools/dumprendertreewatchdog.py: Added.
49
50 2019-04-04  Chris Dumez  <cdumez@apple.com>
51
52         Unreviewed, roll out r243858 which made tests time out.
53
54         Disable new API tests on Windows instead.
55
56         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
57         (TestWebKitAPI::TEST):
58
59 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
60
61         [ATK] Cleanup WebPageAccessibilityObjectAtk
62         https://bugs.webkit.org/show_bug.cgi?id=196537
63
64         Reviewed by Michael Catanzaro.
65
66         Also consider files under atk directories as exceptions for GObject conventions.
67
68         * Scripts/webkitpy/style/checkers/cpp.py:
69         (check_identifier_name_in_declaration):
70
71 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
72
73         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
74         https://bugs.webkit.org/show_bug.cgi?id=196588
75         <rdar://problem/49365787>
76
77         Unreviewed build fix for Windows port.
78
79         error C3861: 'kill': identifier not found
80
81         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
82         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
83
84 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
85
86         [ews-build] Cancel build and similar operations should have authentication
87         https://bugs.webkit.org/show_bug.cgi?id=196520
88
89         Reviewed by Dewei Zhu.
90
91         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
92         environment variables.
93
94 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
95
96         [ews-build] Do not trigger queues which are not in production yet
97         https://bugs.webkit.org/show_bug.cgi?id=196581
98
99         Reviewed by Dewei Zhu.
100
101         * BuildSlaveSupport/ews-build/config.json:
102
103 2019-04-03  Chris Dumez  <cdumez@apple.com>
104
105         Unreviewed, fix typo in the name of API test added in r243848.
106
107         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
108         (TestWebKitAPI::TEST):
109
110 2019-04-03  Chris Dumez  <cdumez@apple.com>
111
112         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
113         https://bugs.webkit.org/show_bug.cgi?id=196588
114         <rdar://problem/49365787>
115
116         Reviewed by Ryosuke Niwa.
117
118         Add API test coverage.
119
120         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
121         (TestWebKitAPI::nullJavaScriptCallback):
122         (TestWebKitAPI::didCrashCheckFrames):
123         (TestWebKitAPI::TEST):
124
125 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
126
127         run-webkit-tests: Upload test results (new results database)
128         https://bugs.webkit.org/show_bug.cgi?id=196577
129         <rdar://problem/34841155>
130
131         Reviewed by Lucas Forschler.
132
133         * Scripts/webkitpy/layout_tests/controllers/manager.py:
134         (Manager.run): Upload results after each device shard, since the configuration will be
135         different for each device.
136         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
137         uploaded to a results database.
138         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
139         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
140
141 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
142
143         -apple-trailing-word is needed for browser detection
144         https://bugs.webkit.org/show_bug.cgi?id=196575
145
146         Unreviewed.
147
148         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
149
150 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
151
152         [CMake][WTF] Mirror XCode header directories
153         https://bugs.webkit.org/show_bug.cgi?id=191662
154
155         Reviewed by Konstantin Tokarev.
156
157         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
158         builds.
159
160         * CMakeLists.txt:
161         * DumpRenderTree/CMakeLists.txt:
162         * DumpRenderTree/PlatformWin.cmake:
163         * MiniBrowser/win/CMakeLists.txt:
164         * TestWebKitAPI/CMakeLists.txt:
165         * TestWebKitAPI/PlatformWin.cmake:
166         * WebKitTestRunner/PlatformGTK.cmake:
167         * WebKitTestRunner/PlatformWin.cmake:
168
169 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
170
171         [ews-app] Status bubble should not display certain infrastructure status messages
172         https://bugs.webkit.org/show_bug.cgi?id=196550
173
174         Reviewed by Lucas Forschler.
175
176         Do not display the steps which are un-needed for end-user. This information is still avaiable
177         if the user click on the bubble and look at the Buildbot build.
178         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
179         (StatusBubble._steps_messages):
180         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
181
182 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
183
184         [ews-build] Use https for sending data to ews-app
185         https://bugs.webkit.org/show_bug.cgi?id=196492
186
187         Reviewed by Lucas Forschler.
188
189         * BuildSlaveSupport/ews-build/events.py:
190
191 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
192
193         Remove support for -apple-trailing-word
194         https://bugs.webkit.org/show_bug.cgi?id=196525
195
196         Reviewed by Zalan Bujtas.
197
198         This CSS property is nonstandard and not used.
199
200         * Scripts/webkitperl/FeatureList.pm:
201         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
202
203 2019-04-03  Youenn Fablet  <youenn@apple.com>
204
205         Add a test for DOMCache on multiple browsing in case of private browsing
206         https://bugs.webkit.org/show_bug.cgi?id=196524
207
208         Reviewed by Alex Christensen.
209
210         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
211         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
212
213 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
214
215         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
216         https://bugs.webkit.org/show_bug.cgi?id=196540
217
218         Reviewed by Aakash Jain.
219
220         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
221
222 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
223
224         Add plumbing for a compatibility mode preference in WebKit
225         https://bugs.webkit.org/show_bug.cgi?id=196005
226
227         Reviewed by Tim Horton.
228
229         Add new API tests.
230
231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
232         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
233
234 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
235
236         [WPE][GTK] Update libsrtp dependency package for Debian
237         https://bugs.webkit.org/show_bug.cgi?id=196528
238
239         Reviewed by Frédéric Wang.
240
241         * gtk/install-dependencies:
242         * wpe/install-dependencies:
243
244 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
245
246         [WK2] Add support for Window's beforeprint / afterprint events
247         https://bugs.webkit.org/show_bug.cgi?id=196478
248         <rdar://problem/49535124>
249
250         Unreviewed build fix for MSVC.
251
252         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
253
254         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
255
256         * WebKitTestRunner/TestController.cpp:
257         (WTR::printFrame): Use int and float literals.
258
259 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
260
261         [ews-build] Reassign bots to queues
262
263         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
264
265 2019-04-02  Chris Dumez  <cdumez@apple.com>
266
267         [WK2] Add support for Window's beforeprint / afterprint events
268         https://bugs.webkit.org/show_bug.cgi?id=196478
269
270         Reviewed by Alex Christensen.
271
272         Add minimal implementation for printFrame in WebKitTestRunner.
273
274         * WebKitTestRunner/TestController.cpp:
275         (WTR::printFrame):
276         (WTR::TestController::createOtherPage):
277         (WTR::TestController::createWebViewWithOptions):
278
279 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
280
281         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
282         https://bugs.webkit.org/show_bug.cgi?id=196491
283
284         Reviewed by Lucas Forschler.
285
286         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
287
288 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
289
290         [ews-build] Configure buildbot try credentials in environment variables
291         https://bugs.webkit.org/show_bug.cgi?id=196501
292
293         Reviewed by Lucas Forschler.
294
295         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
296         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
297         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
298
299 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
300
301         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
302         https://bugs.webkit.org/show_bug.cgi?id=196496
303         <rdar://problem/49521634>
304
305         Reviewed by Chris Dumez.
306
307         Add new API tests (see WebKit ChangeLog for more detail).
308
309         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
310         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
311         (TEST):
312
313 2019-04-02  David Kilzer  <ddkilzer@apple.com>
314
315         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
316         <https://webkit.org/b/196499>
317
318         Reviewed by Alexey Proskuryakov.
319
320         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
321         ENABLE_ADDRESS_SANITIZER.
322
323 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
324
325         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
326         https://bugs.webkit.org/show_bug.cgi?id=182757
327
328         Reviewed by Don Olmstead.
329
330         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
331         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
332
333 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
334
335         run-api-tests: Upload test results
336         https://bugs.webkit.org/show_bug.cgi?id=196323
337         <rdar://problem/49356714>
338
339         Reviewed by Lucas Forschler.
340
341         * Scripts/webkitpy/api_tests/manager.py:
342         (Manager):
343         (Manager.run): Upload results to a results database.
344         * Scripts/webkitpy/api_tests/run_api_tests.py:
345         (parse_args): Add upload arguments.
346         * Scripts/webkitpy/port/base.py:
347         (Port):
348         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
349         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
350         with commits from any other associated repositories.
351         * Scripts/webkitpy/port/device.py:
352         (Device):
353         (Device.build_version): Access build_versoin of underlying platform device.
354         * Scripts/webkitpy/port/ios_simulator_unittest.py:
355         (IOSSimulatorTest):
356         (IOSSimulatorTest.test_configuration_for_upload):
357         * Scripts/webkitpy/port/device_port.py:
358         (DevicePort):
359         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
360         the same as the machine uploading results.
361         * Scripts/webkitpy/port/mac.py:
362         (MacPort):
363         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
364         * Scripts/webkitpy/port/mac_unittest.py:
365         (MacTest):
366         (MacTest.test_configuration_for_upload):
367         * Scripts/webkitpy/xcode/simulated_device.py:
368         (SimulatedDeviceManager._create_device_with_runtime):
369         (SimulatedDevice.__init__): Create simulated device with a build_version.
370         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
371         (test_existing_simulator):
372
373 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
374
375         Remove extra newline characters (Follow-up fix to r243707)
376
377         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
378
379 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
380
381         [ews-app] Use API_KEY to accept results data
382         https://bugs.webkit.org/show_bug.cgi?id=196461
383
384         Reviewed by Dewei Zhu.
385
386         * BuildSlaveSupport/ews-app/ews/views/results.py:
387         (Results.post): Validate EWS_API_KEY before accepting any data.
388         * BuildSlaveSupport/ews-build/events.py:
389         (Events.sendData): Send EWS_API_KEY if available along with event data.
390
391 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
392
393         Unable to copy and paste a PDF from Notes into Mail compose body
394         https://bugs.webkit.org/show_bug.cgi?id=196442
395         <rdar://problem/48573098>
396
397         Reviewed by Tim Horton.
398
399         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
400         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
401         to be specified on the item providers.
402
403         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
404         (TestWebKitAPI::mapItemForTesting):
405         (TestWebKitAPI::contactItemForTesting):
406
407 2019-04-01  Tim Horton  <timothy_horton@apple.com>
408
409         Make UIWKDocumentContext rects per-character instead of per-word
410         https://bugs.webkit.org/show_bug.cgi?id=196459
411
412         Reviewed by Wenson Hsieh.
413
414         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
415         (TEST):
416         Adjust test results due to switching to per-character rects.
417
418 2019-04-01  Chris Dumez  <cdumez@apple.com>
419
420         UIProcess crash when a prewarmed process is terminated
421         https://bugs.webkit.org/show_bug.cgi?id=196451
422         <rdar://problem/49245471>
423
424         Reviewed by Geoffrey Garen.
425
426         Add API test coverage.
427
428         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
429         (TEST):
430
431 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
432
433         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
434         https://bugs.webkit.org/show_bug.cgi?id=196449
435
436         Reviewed by Lucas Forschler.
437
438         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
439         (StatusBubble.get_os_details): Method to get OS and Xcode details.
440         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
441         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
442
443 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
444
445         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
446         https://bugs.webkit.org/show_bug.cgi?id=196444
447
448         Reviewed by Lucas Forschler.
449
450         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
451
452 2019-04-01  Alex Christensen  <achristensen@webkit.org>
453
454         Add SPI to canonicalize NSURLs with WTF::URL
455         https://bugs.webkit.org/show_bug.cgi?id=196415
456         <rdar://problem/44980271>
457
458         Reviewed by Darin Adler.
459
460         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
461         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
462         (TestWebKitAPI::TEST):
463
464 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
465
466         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
467         https://bugs.webkit.org/show_bug.cgi?id=196441
468
469         Reviewed by Carlos Garcia Campos.
470
471         Don't cache the wpe_view_backend object that might not exist yet at the
472         time of EventSenderProxy constructor invocation, but instead retrieve
473         that object whenever it's required for event dispatching. This should
474         avoid crashes in this constructor now that it's invoked before any
475         PlatformWindow has been set up (as changed in r243496).
476
477         * WebKitTestRunner/EventSenderProxy.h:
478         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
479         (WTR::viewBackend):
480         (WTR::EventSenderProxy::EventSenderProxy):
481         (WTR::EventSenderProxy::mouseDown):
482         (WTR::EventSenderProxy::mouseUp):
483         (WTR::EventSenderProxy::mouseMoveTo):
484         (WTR::EventSenderProxy::mouseScrollBy):
485         (WTR::EventSenderProxy::keyDown):
486         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
487
488 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
489
490         [Win][WebKit] MiniBrowser should support high DPI display
491         https://bugs.webkit.org/show_bug.cgi?id=196391
492
493         Reviewed by Alex Christensen.
494
495         * MiniBrowser/win/WebKitBrowserWindow.cpp:
496         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
497         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
498         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
499
500 2019-03-31  Sam Weinig  <weinig@apple.com>
501
502         Remove more i386 specific configurations
503         https://bugs.webkit.org/show_bug.cgi?id=196430
504
505         Reviewed by Alexey Proskuryakov.
506
507         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
508         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
509
510 2019-03-31  Andy Estes  <aestes@apple.com>
511
512         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
513         https://bugs.webkit.org/show_bug.cgi?id=196433
514         <rdar://problem/49293305>
515
516         Reviewed by Tim Horton.
517
518         Enhanced API test coverage to include all navigation response policy decisions in both
519         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
520
521         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
522         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
523         (TestWebKitAPI::TEST):
524         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
525         (readFile):
526         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
527         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
528         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
529         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
530         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
531         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
532         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
533         (-[QuickLookDelegate _downloadDidStart:]):
534         (-[QuickLookDelegate _download:didReceiveResponse:]):
535         (-[QuickLookDelegate _download:didReceiveData:]):
536         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
537         (-[QuickLookDelegate _downloadDidFinish:]):
538         (-[QuickLookDelegate _download:didFailWithError:]):
539         (-[QuickLookDelegate _downloadDidCancel:]):
540         (-[QuickLookDelegate verifyDownload]):
541         (runTest):
542         (runTestDecideBeforeLoading):
543         (runTestDecideAfterLoading):
544         (TEST):
545         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
546         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
547         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
548         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
549         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
550         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
551         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
552         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
553         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
554         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
555         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
556         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
557         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
558         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
559
560 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
561
562         [CMake] add testdfg as target with build-jsc
563         https://bugs.webkit.org/show_bug.cgi?id=196393
564
565         Reviewed by Saam Barati.
566
567         Added testdfg as one of the targets to build when
568         using CMake.
569
570         * Scripts/build-jsc:
571
572 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
573
574         Delete WebMetal implementation in favor of WebGPU
575         https://bugs.webkit.org/show_bug.cgi?id=195418
576
577         Reviewed by Dean Jackson.
578
579         * DumpRenderTree/mac/DumpRenderTree.mm:
580         (enableExperimentalFeatures):
581         (resetWebPreferencesToConsistentValues):
582         * Scripts/webkitperl/FeatureList.pm:
583         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
584         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
585         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
586         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
587         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
588         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
589         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
590         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
591         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
592         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
593         (WTR::InjectedBundle::beginTesting):
594         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
595         (WTR::TestRunner::setWebMetalEnabled): Deleted.
596         * WebKitTestRunner/InjectedBundle/TestRunner.h:
597
598 2019-03-29  Chris Dumez  <cdumez@apple.com>
599
600         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
601         https://bugs.webkit.org/show_bug.cgi?id=196405
602         <rdar://problem/49428130>
603
604         Reviewed by Wenson Hsieh.
605
606         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
607         the popover presentation methods to be no-ops. Use this in the new test added in
608         r243523 so that we do not swizzle those methods for all tests. This is needed because
609         those WatchOS tests rely on the popover getting presented and interactive.
610
611         * WebKitTestRunner/TestController.cpp:
612         (WTR::updateTestOptionsFromTestHeader):
613         * WebKitTestRunner/TestController.h:
614         * WebKitTestRunner/TestOptions.h:
615         (WTR::TestOptions::hasSameInitializationOptions const):
616         * WebKitTestRunner/ios/TestControllerIOS.mm:
617         (WTR::TestController::platformInitialize):
618         (WTR::TestController::platformResetStateToConsistentValues):
619
620 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
621
622         [Curl] Add Server Trust Evaluation Support.
623         https://bugs.webkit.org/show_bug.cgi?id=191646
624
625         Reviewed by Fujii Hironori.
626
627         Implemented MiniBrowser UI for asking if user trusts the server.
628
629         * MiniBrowser/win/Common.cpp:
630         (askServerTrustEvaluation):
631         (replaceString):
632         * MiniBrowser/win/Common.h:
633         * MiniBrowser/win/MiniBrowserLib.rc:
634         * MiniBrowser/win/MiniBrowserLibResource.h:
635         * MiniBrowser/win/WebKitBrowserWindow.cpp:
636         (createPEMString):
637         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
638         (WebKitBrowserWindow::canTrustServerCertificate):
639         * MiniBrowser/win/WebKitBrowserWindow.h:
640
641 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
642
643         Implement ResizeObserver.
644         https://bugs.webkit.org/show_bug.cgi?id=157743
645
646         Reviewed by Simon Fraser.
647
648         Support resizeObserverEnabled webPreferences.
649
650         * DumpRenderTree/TestOptions.cpp:
651         (TestOptions::TestOptions):
652         * DumpRenderTree/TestOptions.h:
653         * DumpRenderTree/mac/DumpRenderTree.mm:
654         (setWebPreferencesForTestOptions):
655         * DumpRenderTree/win/DumpRenderTree.cpp:
656         (enableExperimentalFeatures):
657         * Scripts/webkitperl/FeatureList.pm:
658         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
659
660 2019-03-28  John Wilander  <wilander@apple.com>
661
662         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
663         https://bugs.webkit.org/show_bug.cgi?id=196281
664         <rdar://problem/48938748>
665
666         Reviewed by Alex Christensen.
667
668         This patch adds the function isStatisticsHasLocalStorage() to the
669         TestRunner. With it, the page can query the WebsiteDataStore in the
670         UI process to make sure that it sees LocalStorage.
671
672         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
673         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
674         (WTR::TestRunner::isStatisticsHasLocalStorage):
675         * WebKitTestRunner/InjectedBundle/TestRunner.h:
676         * WebKitTestRunner/TestController.cpp:
677         (WTR::TestController::isStatisticsHasLocalStorage):
678         * WebKitTestRunner/TestController.h:
679         * WebKitTestRunner/TestInvocation.cpp:
680         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
681
682 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
683
684         API::Data::createWithoutCopying should do a null check before calling CFRelease
685         https://bugs.webkit.org/show_bug.cgi?id=196276
686         <rdar://problem/48059859>
687
688         Reviewed by Alex Christensen.
689
690         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
691
692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
693         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
694         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
695         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
696         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
697         (TestWebKitAPI::TEST):
698
699 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
700
701         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
702         https://bugs.webkit.org/show_bug.cgi?id=186276
703
704         Reviewed by Carlos Garcia Campos.
705
706         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
707         (webViewLoadChanged):
708         (testWebResourceGetDataError):
709         (testWebResourceGetDataEmpty):
710         (beforeAll):
711         (webViewloadChanged): Deleted.
712
713 2019-03-27  Andy Estes  <aestes@apple.com>
714
715         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
716         https://bugs.webkit.org/show_bug.cgi?id=196317
717
718         Reviewed by Dan Bernstein.
719
720         package-root copies built products into a staging directory using ditto(1), which does not
721         follow symbolic links as it traverses a directory. Now that the files in
722         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
723         itself, these become broken links when ditto'd into the staging directory.
724
725         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
726
727         * Scripts/package-root:
728
729 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
730
731         [ews-app] Update display text of Submit for ews analysis
732         https://bugs.webkit.org/show_bug.cgi?id=196309
733
734         Reviewed by Dewei Zhu.
735
736         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
737
738 2019-03-27  David Kilzer  <ddkilzer@apple.com>
739
740         run-webkit-tests should check for leaks in WebKit processes
741         <https://webkit.org/b/193772>
742         <rdar://problem/46526680>
743
744         Reviewed by Ryosuke Niwa.
745
746         This works by doing the following:
747         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
748           The list of child processes are returned one per line:
749           process.name: pid
750         - Run the "#LIST CHILD PROCESSES" command just before the
751           "#CHECK FOR WORLD LEAKS" command, and store the list of child
752           processes on the ServerProcess object.
753         - When the `--leaks` switch is handled, run check_for_leaks() on
754           each child process after the main test harness.
755
756         * DumpRenderTree/mac/DumpRenderTree.mm:
757         (handleControlCommand):
758         - Use strncmp() instead of strcmp().
759         - Add support for handling "#LIST CHILD PROCESSES" command.
760
761         * Scripts/webkitpy/port/base.py:
762         (Port.check_for_leaks):
763         * Scripts/webkitpy/port/darwin.py:
764         (DarwinPort.check_for_leaks):
765         - Rename redundant 'process_pid' argument to 'process_id'.
766
767         * Scripts/webkitpy/port/driver.py:
768         (Driver.do_post_tests_work):
769         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
770           longer the only command this sends to WebKitTestRunner.
771         - If the `--leaks` switch is present, send the
772           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
773           result using Port.set_webkit_processes().
774         (Driver._parse_child_processes_output):
775         - Add helper method to parse list of child process names and
776           process IDs returned from WebKitTestRunner.
777
778         * Scripts/webkitpy/port/ios_device.py:
779         (IOSDevicePort.check_for_leaks):
780         - Rename redundant 'process_pid' argument to 'process_id'.
781
782         * Scripts/webkitpy/port/leakdetector.py:
783         (LeakDetector._parse_leaks_output):
784         - Return early if there is no leaks_output.
785         (LeakDetector.check_for_leaks):
786         - Rename redundant 'process_pid' argument to 'process_id'.
787
788         * Scripts/webkitpy/port/server_process.py:
789         (ServerProcess.__init__):
790         (ServerProcess.child_processes):
791         (ServerProcess.set_child_processes):
792         - Add instance variable to Port to store list of child process
793           names and process IDs returned from WebKitTestRunner.
794         (ServerProcess._start):
795         - Clear self._child_processes.
796         (ServerProcess.stop):
797         - If self._child_processes is set, call
798           self._port.check_for_leaks() for each child process.
799
800         * Scripts/webkitpy/port/server_process_unittest.py:
801         (TrivialMockPort.check_for_leaks):
802         - Rename redundant 'process_pid' argument to 'process_id'.
803
804         * Scripts/webkitpy/port/simulator_process.py:
805         (SimulatorProcess.stop):
806         - If self._child_processes is set, call
807           self._port.check_for_leaks() for each child process.
808
809         * Scripts/webkitpy/port/watch_device.py:
810         (WatchDevicePort.check_for_leaks):
811         - Rename redundant 'process_pid' argument to 'process_id'.
812
813         * WebKitTestRunner/TestController.cpp:
814         (WTR::TestController::dumpResponse):
815         - Extract method from findAndDumpWorldLeaks() so that it may be
816           reused by findAndDumpWebKitProcessIdentifiers().
817         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
818         - Add method to output process name and process ID of both the
819           WebContent and Networking processes.
820         (WTR::TestController::findAndDumpWorldLeaks):
821         - Fix missing newline in output when there were no abandoned
822           documents.
823         - Call dumpResponse() for extracted code.
824         (WTR::TestController::handleControlCommand):
825         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
826         - Use strncmp() instead of strcmp().
827         - Call findAndDumpWebKitProcessIdentifiers() when
828           "#LIST CHILD PROCESSES" command is sent.
829         * WebKitTestRunner/TestController.h:
830         (WTR::TestController::dumpResponse):
831         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
832         - Declare methods.
833
834 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
835
836         Unreviewed. Add GLib API test cases after r243434.
837
838         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
839         (testWebViewActiveURI):
840         (serverCallback):
841         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
842         (sendRequestCallback):
843
844 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
845
846         Geolocation request not complete when watch request was started in a different web process
847         https://bugs.webkit.org/show_bug.cgi?id=195996
848
849         Reviewed by Alex Christensen.
850
851         Add a test case.
852
853         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
854         (TestWebKitAPI::runJavaScriptAlert):
855         (TestWebKitAPI::TEST):
856
857 2019-03-26  Keith Rollin  <krollin@apple.com>
858
859         Update the way generate-xcfilelists returns strings from functions
860         https://bugs.webkit.org/show_bug.cgi?id=195975
861         <rdar://problem/49040807>
862
863         Reviewed by Dean Jackson.
864
865         There are places where generate-xcfilelists executes assignments with
866         statements like:
867
868             FOO=$(some_function)
869
870         where "some_function" return a string by echoing it. E.g.
871
872             some_function()
873             {
874                 echo "Hello, World"
875             }
876
877         This is a common idiom, but it has a problem if "some_function" needs
878         to call "exit" in an attempt to halt the entire script right then and
879         there. Since "some_function" is called inside of $(), it's being
880         executed in a sub-shell. Calling exit in that sub-shell simply exits
881         that shell; it doesn't not exit the outer shell in which the main part
882         of the script is still running. As such, the main script keeps
883         executing when the intent was for the script to halt.
884
885         The solution to this is to use a different idiom for returning
886         strings. The one we now is to pass in the name of the variable to
887         receive the string result:
888
889             some_function()
890             {
891                 variable_name=$1
892                 eval $variable_name ="Hello, World"
893             }
894
895         The call site now looks like
896
897             some_function FOO
898
899         Because there's no invocation of a sub-shell, some_function can now
900         call "exit" if it wants to, and the entire script will exit at that
901         point.
902
903         * Scripts/generate-xcfilelists:
904
905 2019-03-26  Chris Dumez  <cdumez@apple.com>
906
907         Add basic layout test coverage for File Picker on iOS
908         https://bugs.webkit.org/show_bug.cgi?id=196265
909
910         Reviewed by Wenson Hsieh.
911
912         Add layout test infrastructure to test the file picker on iOS.
913
914         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
915         (WTR::UIScriptController::dismissFilePicker):
916         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
917         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
918         (WTR::UIScriptController::dismissFilePicker):
919         * TestRunnerShared/UIScriptContext/UIScriptController.h:
920         * WebKitTestRunner/TestController.cpp:
921         (WTR::TestController::createWebViewWithOptions):
922         (WTR::updateTestOptionsFromTestHeader):
923         * WebKitTestRunner/TestOptions.h:
924         (WTR::TestOptions::hasSameInitializationOptions const):
925         * WebKitTestRunner/ios/TestControllerIOS.mm:
926         (overridePresentViewController):
927         (WTR::TestController::platformInitialize):
928         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
929         (WTR::UIScriptController::dismissFilePicker):
930
931 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
932
933         Implement async paste method on UIWKInteractionViewProtocol
934         https://bugs.webkit.org/show_bug.cgi?id=196267
935         <rdar://problem/49236346>
936
937         Reviewed by Tim Horton.
938
939         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
940         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
941         are now a part of all iOS 12 internal SDKs.
942
943         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
944
945         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
946         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
947
948         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
949         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
950         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
951         * TestWebKitAPI/ios/UIKitSPI.h:
952
953 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
954
955         [ews-build] Use PostgreSQL for ews.webkit.org database
956         https://bugs.webkit.org/show_bug.cgi?id=196270
957
958         Reviewed by Lucas Forschler.
959
960         * BuildSlaveSupport/ews-app/ews-app/settings.py:
961
962 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
963
964         [ews] Reset simctl states on reboot
965         https://bugs.webkit.org/show_bug.cgi?id=196260
966
967         Rubber-stamped by Aakash Jain.
968
969         * EWSTools/start-queue-mac.sh:
970
971 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
972
973         [ews-build] Use PostgreSQL for ews-build database
974         https://bugs.webkit.org/show_bug.cgi?id=196229
975
976         Reviewed by Lucas Forschler.
977
978         * BuildSlaveSupport/ews-build/master.cfg:
979
980 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
981
982         [ews-build] Get master_hostname dynamically in master.cfg
983         https://bugs.webkit.org/show_bug.cgi?id=196255
984
985         Reviewed by Lucas Forschler.
986
987         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
988         send events data in test mode.
989
990 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
991
992         [ews-app] Set db_constraint to False for Foreign Keys
993         https://bugs.webkit.org/show_bug.cgi?id=196252
994
995         Reviewed by Lucas Forschler.
996
997         * BuildSlaveSupport/ews-app/ews/models/build.py:
998         * BuildSlaveSupport/ews-app/ews/models/step.py:
999
1000 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1001
1002         [ews-build] is_test_mode_enabled should default to True
1003         https://bugs.webkit.org/show_bug.cgi?id=196248
1004
1005         Reviewed by Lucas Forschler.
1006
1007         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1008
1009 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1010
1011         [ews-app] Add webkitperl to ENABLED_QUEUES
1012         https://bugs.webkit.org/show_bug.cgi?id=196253
1013
1014         Reviewed by Lucas Forschler.
1015
1016         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1017
1018 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1019
1020         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1021         https://bugs.webkit.org/show_bug.cgi?id=196211
1022         rdar://problem/49110552
1023
1024         Reviewed by Tim Horton.
1025
1026         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1027         Make sure that EventSenderProxy always exists when running tests. We used to create
1028         it when resetting before the first test, which is a bit too late.
1029
1030         * WebKitTestRunner/TestController.h:
1031         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1032         (WTR::TestController::platformCreateWebView):
1033         (WTR::TestController::platformCreateOtherPage):
1034         (WTR::TestController::finishCreatingPlatformWebView):
1035         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1036         (WTR::PlatformWebView::PlatformWebView):
1037         Moved some code that made NSWindow use NSEvent during web view creation. We may
1038         need to move more if some other case us found, but this is enough for now.
1039
1040 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1041
1042         Unreviewed. Fix typo in GLib geolocation API after r243285.
1043
1044         gelocation -> geolocation.
1045
1046         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1047         (testGeolocationManagerWatchPosition):
1048
1049 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1050
1051         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1052         https://bugs.webkit.org/show_bug.cgi?id=196213
1053
1054         Reviewed by Geoff Garen.
1055
1056         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1057         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1058         (credentialWithIdentityAndKeychainPath):
1059         (-[ChallengeDelegate webView:didFinishNavigation:]):
1060         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1061         (TestWebKitAPI::TEST):
1062
1063 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1064
1065         Expected shouldn't assume its contained types are copyable
1066         https://bugs.webkit.org/show_bug.cgi?id=195986
1067
1068         Reviewed by JF Bastien.
1069
1070         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1071         (TestWebKitAPI::NonCopyable::operator== const):
1072         (TestWebKitAPI::NonCopyable::operator!= const):
1073         (TestWebKitAPI::TEST):
1074
1075 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1076
1077         Remove some now-unnecessary dynamic class lookup
1078         https://bugs.webkit.org/show_bug.cgi?id=196237
1079
1080         Reviewed by Simon Fraser.
1081
1082         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1083         (makeRequest):
1084         (TEST):
1085
1086 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1087
1088         Unreviewed, rolling out r243450.
1089
1090         AppleWin and WinCairo port builds get broken.
1091
1092         Reverted changeset:
1093
1094         "Add test for fix of #196095"
1095         https://bugs.webkit.org/show_bug.cgi?id=196097
1096         https://trac.webkit.org/changeset/243450
1097
1098 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1099
1100         Unreviewed, rolling out r243465.
1101         https://bugs.webkit.org/show_bug.cgi?id=196226
1102
1103         the test doesn't build (Requested by thorton on #webkit).
1104
1105         Reverted changeset:
1106
1107         "Do not terminate the NetworkProcess if a third party
1108         application sends a NSCredential with a SecIdentityRef"
1109         https://bugs.webkit.org/show_bug.cgi?id=196213
1110         https://trac.webkit.org/changeset/243465
1111
1112 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1113
1114         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1115         https://bugs.webkit.org/show_bug.cgi?id=196213
1116
1117         Reviewed by Geoff Garen.
1118
1119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1120         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1121         (credentialWithIdentityAndKeychainPath):
1122         (-[ChallengeDelegate webView:didFinishNavigation:]):
1123         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1124         (TestWebKitAPI::TEST):
1125
1126 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1127
1128         [ews-build] Gracefully handle missing patch_id in events
1129         https://bugs.webkit.org/show_bug.cgi?id=196216
1130
1131         Reviewed by Lucas Forschler.
1132
1133         * BuildSlaveSupport/ews-build/events.py:
1134
1135 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1136
1137         [ews-build] use lz4 compression for improving buildbot performance
1138         https://bugs.webkit.org/show_bug.cgi?id=196155
1139
1140         Reviewed by Lucas Forschler.
1141
1142         * BuildSlaveSupport/ews-build/master.cfg:
1143
1144 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1145
1146         Pull some API testing helper methods out of TestWKWebView
1147         https://bugs.webkit.org/show_bug.cgi?id=196212
1148
1149         Reviewed by Tim Horton.
1150
1151         Refactor some more API testing utility methods, so that they can be used in
1152         tests that do not use TestWKWebView.
1153
1154         * TestWebKitAPI/cocoa/TestWKWebView.h:
1155         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1156         (-[WKWebView loadTestPageNamed:]):
1157         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1158         (-[WKWebView synchronouslyLoadHTMLString:]):
1159         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1160         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1161         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1162         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1163         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1164
1165 2019-03-25  Jer Noble  <jer.noble@apple.com>
1166
1167         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1168         https://bugs.webkit.org/show_bug.cgi?id=196097
1169
1170         Reviewed by Eric Carlson.
1171
1172         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1173
1174         * DumpRenderTree/mac/DumpRenderTree.mm:
1175         (resetWebPreferencesToConsistentValues):
1176         * WebKitTestRunner/TestController.cpp:
1177         (WTR::TestController::resetPreferencesToConsistentValues):
1178
1179 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1180
1181         Pull IPadUserInterfaceSwizzler out into a separate header file
1182         https://bugs.webkit.org/show_bug.cgi?id=196193
1183
1184         Reviewed by Anders Carlsson.
1185
1186         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1187         be used in other API tests.
1188
1189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1190         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1191         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1192         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1193         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1194         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1195         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1196
1197 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1198
1199         Remove NavigatorContentUtils in WebCore/Modules
1200         https://bugs.webkit.org/show_bug.cgi?id=196070
1201
1202         Reviewed by Alex Christensen.
1203
1204         NavigatorContentUtils was to support the custom scheme spec [1].
1205         However, in WebKit side, no port has supported the feature in
1206         WebKit layer after EFL port was removed. So there has been the
1207         only IDL implementation of the NavigatorContentUtils in WebCore.
1208         So we don't need to keep the implementation in WebCore anymore.
1209
1210         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1211
1212         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1213
1214 2019-03-24  Andy Estes  <aestes@apple.com>
1215
1216         [watchOS] Remove unused Proximity Networking code
1217         https://bugs.webkit.org/show_bug.cgi?id=196188
1218
1219         Reviewed by Tim Horton.
1220
1221         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1222         (TEST):
1223
1224 2019-03-23  Keith Miller  <keith_miller@apple.com>
1225
1226         Refactor clz/ctz and fix getLSBSet.
1227         https://bugs.webkit.org/show_bug.cgi?id=196162
1228
1229         Reviewed by Saam Barati.
1230
1231         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1232
1233         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1234         (TestWebKitAPI::TEST):
1235
1236 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1237
1238         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1239         https://bugs.webkit.org/show_bug.cgi?id=196143
1240
1241         Reviewed by Michael Catanzaro.
1242
1243         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1244         directories.
1245
1246         * Scripts/webkitpy/style/checkers/cpp.py:
1247         (check_identifier_name_in_declaration):
1248         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1249         (WebKitStyleTest.test_names):
1250
1251 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1252
1253         [Flatpak] Manifest expanding fails for qt WPE extension
1254         https://bugs.webkit.org/show_bug.cgi?id=196148
1255
1256         Reviewed by Alex Christensen.
1257
1258         * flatpak/flatpakutils.py:
1259         (expand_submodules_recurse): The last recurse manifest expand
1260         iteration might lead to a single module so take it into account
1261         and don't try to recurse further.
1262
1263 2019-03-22  Chris Dumez  <cdumez@apple.com>
1264
1265         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1266         https://bugs.webkit.org/show_bug.cgi?id=195348
1267         <rdar://problem/48622090>
1268
1269         Reviewed by Alex Christensen.
1270
1271         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1272         to NO when test.options().shouldIgnoreMetaViewport is false.
1273
1274         * WebKitTestRunner/ios/TestControllerIOS.mm:
1275         (WTR::TestController::platformConfigureViewForTest):
1276
1277 2019-03-22  Chris Dumez  <cdumez@apple.com>
1278
1279         Prewarmed processes should be usable with any website data store
1280         https://bugs.webkit.org/show_bug.cgi?id=196104
1281
1282         Reviewed by Alex Christensen.
1283
1284         Add API test coverage.
1285
1286         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1287         (runInitialWarmedProcessUsedTest):
1288         (TEST):
1289
1290 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1291
1292         Back out local changes to Alex's Subversion working directory
1293
1294         They were accidentally committed.
1295
1296         * Scripts/webkitpy/common/system/abstractexecutive.py:
1297         (AbstractExecutive.wait_newest):
1298         * Scripts/webkitpy/common/system/executive.py:
1299         (Executive.running_pids):
1300         * Scripts/webkitpy/common/system/executive_mock.py:
1301         (MockExecutive.running_pids):
1302         * Scripts/webkitpy/common/system/executive_unittest.py:
1303         (ExecutiveTest.serial_test_running_pids):
1304         * Scripts/webkitpy/port/darwin.py:
1305         (DarwinPort.check_for_leaks):
1306         * Scripts/webkitpy/port/leakdetector.py:
1307         (LeakDetector.check_for_leaks):
1308         - This was the hack attached to Bug 193772.
1309
1310         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1311         (+[WebKitTestRunnerEvent mouseLocation]):
1312         - This works around a crash on an internal build.
1313
1314 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1315
1316         Fix the build after r243354
1317         https://bugs.webkit.org/show_bug.cgi?id=196138
1318         <rdar://problem/49145951>
1319
1320         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1321         (TEST):
1322         * TestWebKitAPI/ios/UIKitSPI.h:
1323
1324 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1325
1326         Adopt UIWKDocumentContext
1327         https://bugs.webkit.org/show_bug.cgi?id=196040
1328         <rdar://problem/48642440>
1329
1330         Reviewed by Ryosuke Niwa.
1331
1332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1333         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1334         (makeRequest):
1335         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1336         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1337         (applyStyle):
1338         (TEST):
1339         Add tests for UIWKDocumentContext.
1340
1341         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1342         (TEST):
1343         (recursiveFindWKContentView): Deleted.
1344         * TestWebKitAPI/cocoa/TestWKWebView.h:
1345         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1346         (recursiveFindWKContentView):
1347         (-[TestWKWebView wkContentView]):
1348         * TestWebKitAPI/ios/UIKitSPI.h:
1349         Share the WKContentView finding code between tests.
1350
1351 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1352
1353         [iOS WK2] Turn on async overflow scrolling by default
1354         https://bugs.webkit.org/show_bug.cgi?id=196011
1355         rdar://problem/48453859
1356
1357         Reviewed by Antti Koivisto.
1358         
1359         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1360         since so many basic layout tests have different results when compositing is triggered for
1361         overflow.
1362         
1363         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1364
1365         * WebKitTestRunner/TestController.cpp:
1366         (WTR::TestController::resetPreferencesToConsistentValues):
1367
1368 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1369
1370         [ews-build] Retry API test in case of failures
1371         https://bugs.webkit.org/show_bug.cgi?id=196004
1372
1373         Reviewed by Lucas Forschler.
1374
1375         * BuildSlaveSupport/ews-build/steps.py:
1376         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1377         (CompileWebKitToT.doStepIf): Ditto.
1378         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1379         (ReRunAPITests): Re-run API tests.
1380         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1381         (RunAPITestsWithoutPatch): Run API tests without patch.
1382         (RunAPITestsWithoutPatch.doStepIf):
1383         (RunAPITestsWithoutPatch.hideStepIf):
1384         (RunAPITestsWithoutPatch.evaluateCommand):
1385         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1386         (AnalyzeAPITestsResults.start):
1387         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1388         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1389         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1390         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1391
1392 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1393
1394         [ews-build] Update queues configurations
1395         https://bugs.webkit.org/show_bug.cgi?id=196074
1396
1397         Reviewed by Dewei Zhu.
1398
1399         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1400         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1401
1402 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1403
1404         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1405         https://bugs.webkit.org/show_bug.cgi?id=195680
1406         <rdar://problem/48903534>
1407
1408         Unreviewed infrastructure fix.
1409
1410         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1411         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1412
1413 2019-03-21  Andy Estes  <aestes@apple.com>
1414
1415         [iOS] Apple Pay should be available in documents with no user agent scripts
1416         https://bugs.webkit.org/show_bug.cgi?id=196061
1417         <rdar://problem/48649391>
1418
1419         Reviewed by Brady Eidson.
1420
1421         Added API tests and related infrastructure.
1422
1423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1424         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1425         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1426         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1427         (TestWebKitAPI::TEST):
1428         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1429         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1430         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1431         * TestWebKitAPI/cocoa/TestProtocol.mm:
1432         (-[TestProtocol startLoading]):
1433         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1434         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1435         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1436         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1437
1438 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1439
1440         REGRESSSION (r243297): webkitpy tests broken
1441         https://bugs.webkit.org/show_bug.cgi?id=196108
1442
1443         Reviewed by Aakash Jain.
1444
1445         r243297 updated contributors.json, which broke a few unit tests.
1446
1447         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1448         (IRCCommandTest.test_whois):
1449         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1450
1451 2019-03-21  Chris Dumez  <cdumez@apple.com>
1452
1453         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1454         https://bugs.webkit.org/show_bug.cgi?id=196041
1455         <rdar://problem/49083230>
1456
1457         Reviewed by Alex Christensen.
1458
1459         Add API test coverage.
1460
1461         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1462         (TEST):
1463
1464 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1465
1466         Add SPI to inform applications of WKContentRuleList actions
1467         https://bugs.webkit.org/show_bug.cgi?id=195965
1468         <rdar://problem/42664365>
1469
1470         Reviewed by Geoff Garen.
1471
1472         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1473         (TestWebKitAPI::allActionsForResourceLoad):
1474         (TestWebKitAPI::testRequest):
1475         (TestWebKitAPI::TEST_F):
1476         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1477         (Notification::description):
1478         (Notification::operator== const):
1479         (toVector):
1480         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1481         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1482         (makeContentRuleList):
1483         (TEST):
1484         (makeWarnContentRuleList): Deleted.
1485
1486 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1487
1488         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1489         https://bugs.webkit.org/show_bug.cgi?id=196088
1490
1491         Reviewed by Brian Burg.
1492
1493         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1494         Support checks when only one platform is specified. Also deprecate macosx() and
1495         force the use of macos() instead.
1496
1497         * Scripts/webkitpy/style/checkers/cpp.py:
1498         (check_min_versions_of_wk_api_available):
1499         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1500         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1501
1502 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1503
1504         Update status inactive committers' status to 'contributor'.
1505
1506         * Scripts/webkitpy/common/config/contributors.json:
1507
1508 2019-03-21  Xan Lopez  <xan@igalia.com>
1509
1510         [JSC][x86] Drop support for x87 floating point
1511         https://bugs.webkit.org/show_bug.cgi?id=194853
1512
1513         Reviewed by Don Olmstead.
1514
1515         Force SSE2 on x86/32bit builds.
1516
1517         * Scripts/webkitdirs.pm:
1518         (generateBuildSystemFromCMakeProject):
1519
1520 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1521
1522         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1523         https://bugs.webkit.org/show_bug.cgi?id=196073
1524
1525         Reviewed by Michael Catanzaro.
1526
1527         Add test cases to check functions and constructors with no arguments but receiving user data.
1528
1529         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1530         (checkUserData):
1531         (testJSCFunction):
1532         (fooCreateWithUserData):
1533         (testJSCClass):
1534
1535 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1536
1537         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1538
1539         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1540
1541         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1542
1543 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1544
1545         [GTK][WPE] Add API to provide geolocation information
1546         https://bugs.webkit.org/show_bug.cgi?id=195940
1547
1548         Reviewed by Michael Catanzaro.
1549
1550         Add a new test to check the new API.
1551
1552         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1553         (testGeolocationManagerCurrentPosition):
1554         (testGeolocationManagerWatchPosition):
1555         (beforeAll):
1556         (afterAll):
1557         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1558         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1559         (beforeAll): Ditto.
1560         * TestWebKitAPI/glib/CMakeLists.txt:
1561
1562 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1563
1564         [GLib] Returning G_TYPE_OBJECT from a method does not work
1565         https://bugs.webkit.org/show_bug.cgi?id=195574
1566
1567         Reviewed by Michael Catanzaro.
1568
1569         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1570
1571         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1572         (getGFile):
1573         (getParent):
1574         (createGString):
1575         (getGString):
1576         (getGStringCopyWillRaise):
1577         (getGStringCopy):
1578         (getGStringStr):
1579         (getGStringLen):
1580         (freeGString):
1581         (testJSCClass):
1582
1583 2019-03-20  Saam Barati  <sbarati@apple.com>
1584
1585         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1586         https://bugs.webkit.org/show_bug.cgi?id=195721
1587
1588         Reviewed by Filip Pizlo.
1589
1590         * Scripts/run-javascriptcore-tests:
1591
1592 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1593
1594         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1595         https://bugs.webkit.org/show_bug.cgi?id=196049
1596
1597         Reviewed by Tim Horton.
1598
1599         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1600         overflow scrolling in general, so rename it.
1601
1602         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1603
1604 2019-03-20  Daniel Bates  <dabates@apple.com>
1605
1606         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1607         https://bugs.webkit.org/show_bug.cgi?id=196031
1608         <rdar://problem/49078172>
1609
1610         Reviewed by Tim Horton.
1611
1612         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1613         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1614         same code path used when the Done button is pressed to dismiss the <select> picker.
1615
1616         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1617         (TestWebKitAPI::TEST):
1618
1619 2019-03-20  Chris Dumez  <cdumez@apple.com>
1620
1621         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1622         https://bugs.webkit.org/show_bug.cgi?id=196029
1623         <rdar://problem/48954651>
1624
1625         Reviewed by Tim Horton.
1626
1627         Add API test coverage.
1628
1629         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1630
1631 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1632
1633         [ews-build] Improve failure summary string for ApplyPatch step
1634         https://bugs.webkit.org/show_bug.cgi?id=195995
1635
1636         Reviewed by Alexey Proskuryakov.
1637
1638         * BuildSlaveSupport/ews-build/steps.py:
1639         (ApplyPatch.getResultSummary): Override getResultSummary.
1640
1641 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1642
1643         AX: Implement support for new meter ARIA role
1644         https://bugs.webkit.org/show_bug.cgi?id=195966
1645
1646         Reviewed by Chris Fleizach.
1647
1648         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1649         to AXLevelIndicator.
1650
1651         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1652
1653 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1654
1655         [WebAuthN] Implement FIDO AppID extension
1656         https://bugs.webkit.org/show_bug.cgi?id=143491
1657         <rdar://problem/48298273>
1658
1659         Reviewed by Brent Fulgham.
1660
1661         Add a test that covers the new flag of convertToU2fSignCommand.
1662
1663         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1664         (TestWebKitAPI::TEST):
1665         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1666         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1667         (TestWebKitAPI::TEST):
1668
1669 2019-03-19  Keith Rollin  <krollin@apple.com>
1670
1671         Add support for more platforms to generate-xcfilelists
1672         https://bugs.webkit.org/show_bug.cgi?id=195977
1673
1674         Reviewed by Alexey Proskuryakov.
1675
1676         generate-xcfilelists incorrectly complains when involved with building
1677         WebKit for iphonesimulator:
1678
1679             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1680             …
1681             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1682
1683         Address this by teaching generate-xcfilelists about more platforms.
1684
1685         * Scripts/generate-xcfilelists:
1686
1687 2019-03-19  John Wilander  <wilander@apple.com>
1688
1689         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1690         https://bugs.webkit.org/show_bug.cgi?id=195923
1691         <rdar://problem/49001272>
1692
1693         Reviewed by Alex Christensen.
1694
1695         This patch does the following to the TestRunner:
1696         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1697         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1698         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1699
1700         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1701         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1702         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1703         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1704         * WebKitTestRunner/TestController.cpp:
1705         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1706         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1707         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1708         * WebKitTestRunner/TestController.h:
1709         * WebKitTestRunner/TestInvocation.cpp:
1710         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1711
1712 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1713
1714         [CMake] Support more clang and gcc sanitizers
1715         https://bugs.webkit.org/show_bug.cgi?id=195956
1716
1717         Reviewed by Michael Catanzaro.
1718
1719         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1720
1721 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1722
1723         [ews-build] Improve summary for PrintConfiguration step
1724         https://bugs.webkit.org/show_bug.cgi?id=195945
1725
1726         Reviewed by Lucas Forschler.
1727
1728         * BuildSlaveSupport/ews-build/steps.py:
1729         (PrintConfiguration.getResultSummary): Override getResultSummary.
1730
1731 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1732
1733         [ews-build] Improve summary for CheckOutSource step
1734         https://bugs.webkit.org/show_bug.cgi?id=195963
1735
1736         Reviewed by Lucas Forschler.
1737
1738         * BuildSlaveSupport/ews-build/steps.py:
1739         (CheckOutSource.getResultSummary):
1740
1741 2019-03-19  Daniel Bates  <dabates@apple.com>
1742
1743         [iOS] Focus not preserved when switching between tabs
1744         https://bugs.webkit.org/show_bug.cgi?id=195820
1745         <rdar://problem/43614450>
1746
1747         Reviewed by Brent Fulgham.
1748
1749         Add tests to ensure that we restore focus when resigning and becoming first responder.
1750
1751         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1752         (TestWebKitAPI::TEST):
1753
1754 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1755
1756         Make WTFLogChannelState and WTFLogLevel enum classes
1757         https://bugs.webkit.org/show_bug.cgi?id=195904
1758
1759         Reviewed by Eric Carlson.
1760
1761         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1762         (TestWebKitAPI::TEST_F):
1763
1764 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1765
1766         [GStreamer][EME] Backported mssdemux protection data crash fix
1767         https://bugs.webkit.org/show_bug.cgi?id=195918
1768
1769         Reviewed by Philippe Normand.
1770
1771         * gstreamer/jhbuild.modules:
1772         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1773
1774 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1775
1776         Unreviewed, rolling out r243132.
1777
1778         Broke GTK build
1779
1780         Reverted changeset:
1781
1782         "Make WTFLogChannelState and WTFLogLevel enum classes"
1783         https://bugs.webkit.org/show_bug.cgi?id=195904
1784         https://trac.webkit.org/changeset/243132
1785
1786 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1787
1788         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1789
1790         * Scripts/webkitdirs.pm:
1791         (builtDylibPathForName): Adjust the shared library name that's changed
1792         with the API version bump in r243073.
1793
1794 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1795
1796         Make WTFLogChannelState and WTFLogLevel enum classes
1797         https://bugs.webkit.org/show_bug.cgi?id=195904
1798
1799         Reviewed by Eric Carlson.
1800
1801         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1802         (TestWebKitAPI::TEST_F):
1803
1804 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1805
1806         Disable flaky test added in r2431100
1807         https://webkit.org/b/195785
1808
1809         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1810         (TestWebKitAPI::TEST):
1811         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1812
1813 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1814
1815         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1816         https://bugs.webkit.org/show_bug.cgi?id=195916
1817
1818         Reviewed by Tim Horton.
1819
1820         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1821         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1822
1823 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1824
1825         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1826
1827         * Scripts/webkitpy/common/config/contributors.json:
1828
1829 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1830
1831         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1832         https://bugs.webkit.org/show_bug.cgi?id=195785
1833
1834         Reviewed by Geoffrey Garen.
1835
1836         * TestWebKitAPI/TCPServer.cpp: Added.
1837         (TestWebKitAPI::TCPServer::TCPServer):
1838         (TestWebKitAPI::TCPServer::~TCPServer):
1839         (TestWebKitAPI::TCPServer::socketBindListen):
1840         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1841         * TestWebKitAPI/TCPServer.h: Added.
1842         (TestWebKitAPI::TCPServer::port const):
1843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1844         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1845         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1846         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1847         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1848         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1849         (TestWebKitAPI::respondSlowly):
1850         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1851         (TestWebKitAPI::downloadAtRate):
1852         (TestWebKitAPI::TEST):
1853
1854 2019-03-18  Saam Barati  <sbarati@apple.com>
1855
1856         Add a plan file for JetStream 2
1857         https://bugs.webkit.org/show_bug.cgi?id=190734
1858
1859         Reviewed by Mark Lam.
1860
1861         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1862
1863 2019-03-18  Chris Dumez  <cdumez@apple.com>
1864
1865         Delay WebProcess launch until a load is triggered in a Web view
1866         https://bugs.webkit.org/show_bug.cgi?id=195758
1867         <rdar://problem/48126013>
1868
1869         Reviewed by Geoff Garen.
1870
1871         Add API test coverage. Also update some existing API tests to not expect
1872         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1873
1874         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1875         (TestWebKitAPI::TEST):
1876         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1877         (TestWebKitAPI::TEST):
1878         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1879         (TEST):
1880         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1881         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1882         (TEST):
1883         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1884         (TEST):
1885         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1886
1887 2019-03-18  Xan Lopez  <xan@igalia.com>
1888
1889         [CMake] Prevent potential warning when determining $architecture
1890         https://bugs.webkit.org/show_bug.cgi?id=195891
1891
1892         Reviewed by Michael Catanzaro.
1893
1894         It's possible for generateBuildSystemForCMakeProject to be called
1895         before determineArchitecture() is ever called. This will make the
1896         first eq check with $architecture to be bogus (and print a
1897         warning). Change that to an eq check with architecture(), which
1898         implicitly calls determineArchitecture() if needed, and change all
1899         the other similar cases in the method in the same way to prevent
1900         future bugs like this one.
1901
1902         * Scripts/webkitdirs.pm:
1903         (generateBuildSystemFromCMakeProject):
1904
1905 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1906
1907         [WPE] Tarballs generated with “make dist” cannot build documentation
1908         https://bugs.webkit.org/show_bug.cgi?id=195885
1909
1910         Reviewed by Carlos Garcia Campos.
1911
1912         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1913
1914 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1915
1916         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1917         https://bugs.webkit.org/show_bug.cgi?id=195883
1918
1919         Reviewed by Carlos Garcia Campos.
1920
1921         * gtkdoc/gtkdoc.py:
1922         (GTKDoc._run_command): When commands fail to run, include the full command line for
1923         the program invocation and the output it has generated on the standard error stream.
1924
1925 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1926
1927         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1928         https://bugs.webkit.org/show_bug.cgi?id=195786
1929
1930         Reviewed by Philippe Normand.
1931
1932         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1933         * wpe/jhbuild.modules: Ditto.
1934
1935 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1936
1937         [ews-build] Don't run clean builds on EWS builders
1938         https://bugs.webkit.org/show_bug.cgi?id=195851
1939
1940         Reviewed by Geoffrey Garen.
1941
1942         * BuildSlaveSupport/ews-build/factories.py:
1943
1944 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1945
1946         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1947         https://bugs.webkit.org/show_bug.cgi?id=195849
1948
1949         Reviewed by Chris Dumez.
1950
1951         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1952
1953         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1954         (runWebsiteDataStoreCustomPaths):
1955
1956 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1957
1958         webkitpy: Upload test results
1959         https://bugs.webkit.org/show_bug.cgi?id=195755
1960         <rdar://problem/48896182>
1961
1962         Reviewed by Aakash Jain.
1963
1964         Establish a new format for uploading results that is not tied to layout tests, apply
1965         that format to webkitpy tests.
1966
1967         * Scripts/webkitpy/common/checkout/scm/git.py:
1968         (Git.native_branch): Return what branch the current checkout is on.
1969         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1970         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1971         * Scripts/webkitpy/common/checkout/scm/svn.py:
1972         (SVN.native_branch): Ditto.
1973         * Scripts/webkitpy/common/system/platforminfo.py:
1974         (PlatformInfo.build_version): Return a build version for Mac.
1975         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1976         (MockPlatformInfo.__init__):
1977         (MockPlatformInfo.build_version):
1978         * Scripts/webkitpy/results: Added.
1979         * Scripts/webkitpy/results/__init__.py: Added.
1980         * Scripts/webkitpy/results/options.py: Added.
1981         (upload_options): OptParse list for upload options.
1982         * Scripts/webkitpy/results/upload.py: Added.
1983         (Upload): Class which enforces the upload format expected by the results server.
1984         (Upload.Expectations):
1985         (Upload.create_configuration):
1986         (Upload.create_commit):
1987         (Upload.create_details):
1988         (Upload.create_run_stats):
1989         (Upload.create_test_result):
1990         (Upload.__init__):
1991         (Upload.Encoder): Encode Upload object as json.
1992         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1993         * Scripts/webkitpy/results/upload_unittest.py: Added.
1994         * Scripts/webkitpy/test/main.py:
1995         (Tester._parse_args): Add upload arguments.
1996         (Tester._run_tests): Allow results to be uploaded.
1997         * Scripts/webkitpy/test/runner.py:
1998         (Runner.__init__): Record which tests were run, rather than just counting them.
1999         (Runner.handle):
2000         * Scripts/webkitpy/test/runner_unittest.py:
2001         (RunnerTest.test_run):
2002         * Scripts/webkitpy/thirdparty/__init__.py:
2003         (AutoinstallImportHook.find_module): Add requests auto-install.
2004         (AutoinstallImportHook._install_requests):
2005         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2006         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2007
2008 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2009
2010         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2011         https://bugs.webkit.org/show_bug.cgi?id=195810
2012
2013         Reviewed by Tim Horton.
2014
2015         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2016         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2017         ending certain layout tests.
2018
2019         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2020         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2021         (-[TestRunnerWKWebView dealloc]):
2022         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2023
2024         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2025         helper method when destroying the web view, and when resetting state between tests.
2026
2027         * WebKitTestRunner/ios/TestControllerIOS.mm:
2028         (WTR::TestController::platformResetStateToConsistentValues):
2029
2030         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2031
2032 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2033
2034         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2035         https://bugs.webkit.org/show_bug.cgi?id=190350
2036         <rdar://problem/45089503>
2037
2038         Reviewed by Geoffrey Garen.
2039
2040         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2041         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2042         (TEST):
2043         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2044         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2045         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2046         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2047         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2048         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2049         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2050         (runTest):
2051         (createDirectories):
2052         (TEST):
2053         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2054         (TEST):
2055         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2056         (TEST):
2057
2058 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2059
2060         Add support to WebPage for getting the contents as an attributed string.
2061         https://bugs.webkit.org/show_bug.cgi?id=195636
2062         rdar://problem/45055697
2063
2064         Reviewed by Tim Horton.
2065
2066         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2067         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2068
2069 2019-03-15  Chris Dumez  <cdumez@apple.com>
2070
2071         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2072         https://bugs.webkit.org/show_bug.cgi?id=195747
2073
2074         Reviewed by Geoff Garen.
2075
2076         Add API test coverage.
2077
2078         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2079
2080 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2081
2082         Unreviewed, rolling out r242952.
2083
2084         Causing API failures on iOS Simulator
2085
2086         Reverted changeset:
2087
2088         "[PSON] Make sure the WebProcessCache is leverage when
2089         relaunching a process after termination"
2090         https://bugs.webkit.org/show_bug.cgi?id=195747
2091         https://trac.webkit.org/changeset/242952
2092
2093 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2094
2095         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2096         https://bugs.webkit.org/show_bug.cgi?id=195740
2097
2098         Reviewed by Ross Kirsling.
2099
2100         window.open doesn't work for WebKitBrowserWindow because it is not
2101         implemented yet.
2102
2103         1. Implemented createNewPage callback of WKPageUIClient.
2104         2. Changed MainWindow to take a BrowserWindow factory function
2105           instead of BrowserWindowType to be flexible to create
2106           BrowserWindow with extra settings.
2107         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2108           because it is not relevant with MainWindow anymore.
2109
2110         * MiniBrowser/win/Common.cpp:
2111         (parseCommandLine):
2112         * MiniBrowser/win/Common.h:
2113         (CommandLineOptions::CommandLineOptions):
2114         * MiniBrowser/win/MainWindow.cpp:
2115         (MainWindow::MainWindow):
2116         (MainWindow::create):
2117         (MainWindow::init):
2118         (MainWindow::WndProc):
2119         * MiniBrowser/win/MainWindow.h:
2120         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2121         (PrintWebUIDelegate::createWebViewWithRequest):
2122         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2123         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2124         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2125         (WebKitBrowserWindow::updateProxySettings):
2126         (WebKitBrowserWindow::createNewPage):
2127         * MiniBrowser/win/WebKitBrowserWindow.h:
2128         * MiniBrowser/win/WinMain.cpp:
2129         (wWinMain):
2130
2131 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2132
2133         Make it possible to test scrolling tree layer manipulation more easily
2134         https://bugs.webkit.org/show_bug.cgi?id=195780
2135
2136         Reviewed by Tim Horton.
2137         
2138         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2139         cuts off communication of scrolling tree scrolls back to the web process
2140         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2141         allows tests to trigger scrolls which run the scrolling tree layer positioning
2142         logic, but never get another commit from the web process that might mask
2143         scrolling tree bugs.
2144         
2145         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2146         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2147         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2148
2149         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2150         (WTR::UIScriptController::scrollUpdatesDisabled const):
2151         (WTR::UIScriptController::setScrollUpdatesDisabled):
2152         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2153         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2154         (WTR::UIScriptController::scrollUpdatesDisabled const):
2155         (WTR::UIScriptController::setScrollUpdatesDisabled):
2156         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2157         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2158         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2159         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2160         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2161         * WebKitTestRunner/ios/TestControllerIOS.mm:
2162         (WTR::TestController::platformResetStateToConsistentValues):
2163         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2164         (WTR::UIScriptController::scrollUpdatesDisabled const):
2165         (WTR::UIScriptController::setScrollUpdatesDisabled):
2166
2167 2019-03-14  Youenn Fablet  <youenn@apple.com>
2168
2169         Move IDB storage in private browsing mode to NetworkProcess
2170         https://bugs.webkit.org/show_bug.cgi?id=195602
2171
2172         Reviewed by Brady Eidson.
2173
2174         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2175         (TEST):
2176
2177 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2178
2179         [ews-build] Make descriptionDone messages more readable
2180         https://bugs.webkit.org/show_bug.cgi?id=195760
2181
2182         Reviewed by Lucas Forschler.
2183
2184         * BuildSlaveSupport/ews-build/steps.py:
2185         * BuildSlaveSupport/ews-build/steps_unittest.py:
2186
2187 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2188
2189         [ews-build] Generate status-bubble hover-over messages
2190         https://bugs.webkit.org/show_bug.cgi?id=195680
2191
2192         Reviewed by Lucas Forschler.
2193
2194         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2195         (StatusBubble):
2196         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2197         on hover-over.
2198         (StatusBubble._iso_time):
2199         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2200         hover-over message.
2201         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2202
2203 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2204
2205         [ews-app] Gracefully handle the case when state_string is None
2206         https://bugs.webkit.org/show_bug.cgi?id=195753
2207
2208         Reviewed by Lucas Forschler.
2209
2210         * BuildSlaveSupport/ews-app/ews/models/build.py:
2211         * BuildSlaveSupport/ews-app/ews/models/step.py:
2212
2213 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2214
2215         [ews-app] Status bubble display pending for currently running build step
2216         https://bugs.webkit.org/show_bug.cgi?id=195744
2217
2218         Reviewed by Lucas Forschler.
2219
2220         * BuildSlaveSupport/ews-build/events.py:
2221         (Events.stepStarted): If state_string is pending, replace it with step name.
2222
2223 2019-03-14  Chris Dumez  <cdumez@apple.com>
2224
2225         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2226         https://bugs.webkit.org/show_bug.cgi?id=195750
2227
2228         Reviewed by Geoffrey Garen.
2229
2230         Add API test coverage.
2231
2232         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2233         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2234         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2235         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2236
2237 2019-03-14  Chris Dumez  <cdumez@apple.com>
2238
2239         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2240         https://bugs.webkit.org/show_bug.cgi?id=195747
2241
2242         Reviewed by Geoff Garen.
2243
2244         Add API test coverage.
2245
2246         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2247
2248 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2249
2250         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2251         https://bugs.webkit.org/show_bug.cgi?id=195725
2252         <rdar://problem/48545062>
2253
2254         Reviewed by Tim Horton.
2255
2256         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2257         handler is nil.
2258
2259         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2260         (TestWebKitAPI::TEST):
2261
2262 2019-03-13  Sam Weinig  <sam@webkit.org>
2263
2264         Add utility function to allow easy reverse range-based iteration of a container
2265         https://bugs.webkit.org/show_bug.cgi?id=195542
2266
2267         Reviewed by Antti Koivisto.
2268
2269         * TestWebKitAPI/CMakeLists.txt:
2270         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2271         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2272         (TestWebKitAPI::TEST):
2273         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2274
2275 2019-03-13  Chris Dumez  <cdumez@apple.com>
2276
2277         Use a ServiceWorker process per registrable domain
2278         https://bugs.webkit.org/show_bug.cgi?id=195649
2279
2280         Reviewed by Youenn Fablet.
2281
2282         Update API test coverage.
2283
2284         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2285
2286 2019-03-13  Chris Dumez  <cdumez@apple.com>
2287
2288         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2289         https://bugs.webkit.org/show_bug.cgi?id=195684
2290         <rdar://problem/48294714>
2291
2292         Reviewed by Antti Koivisto.
2293
2294         Add API test coverage.
2295
2296         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2297
2298 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2299
2300         [ews-app] Remove unused patch view
2301         https://bugs.webkit.org/show_bug.cgi?id=195669
2302
2303         Reviewed by Lucas Forschler.
2304
2305         * BuildSlaveSupport/ews-app/ews/urls.py:
2306         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2307
2308 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2309
2310         [ews-app] Use Buildbot result code variables
2311         https://bugs.webkit.org/show_bug.cgi?id=195668
2312
2313         Reviewed by Alexey Proskuryakov.
2314
2315         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2316         (Buildbot): Added Buildbot result code variables.
2317         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2318         (StatusBubble._build_bubble): Used Buildbot result code variables.
2319
2320 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2321
2322         [Flatpak] Expand submodule recursively
2323         https://bugs.webkit.org/show_bug.cgi?id=195672
2324
2325         Building WPE with flatpak was impossible without that as it was raising an exception.
2326         Also update wpebackend-fdo to match what is built in jhbuild
2327
2328         Reviewed by Philippe Normand.
2329
2330         * flatpak/flatpakutils.py:
2331         (expand_submodules_recurse):
2332         (expand_manifest):
2333         * flatpak/org.webkit.WPEModules.yaml:
2334
2335 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2336
2337         [ews-app] status bubble should be hidden for certain builds
2338         https://bugs.webkit.org/show_bug.cgi?id=194597
2339
2340         Reviewed by Dewei Zhu.
2341
2342         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2343         (StatusBubble._build_bubble):
2344         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2345         because the patch didn't have relevant changes.
2346         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2347         in production yet.
2348
2349 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2350
2351         [Win] Fix a slew of simple clang-cl warnings.
2352         https://bugs.webkit.org/show_bug.cgi?id=195652
2353
2354         Reviewed by Don Olmstead.
2355
2356         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2357         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2358
2359 2019-03-12  Justin Fan  <justin_fan@apple.com>
2360
2361         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2362         https://bugs.webkit.org/show_bug.cgi?id=195518
2363         <rdar://problem/46322356>
2364
2365         Reviewed by Myles C. Maxfield.
2366
2367         * DumpRenderTree/DerivedSources-input.xcfilelist:
2368         * DumpRenderTree/DerivedSources-output.xcfilelist:
2369
2370 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2371
2372         Unreviewed, rolling out r242825.
2373         https://bugs.webkit.org/show_bug.cgi?id=195648
2374
2375         "Broke webkitpy tests with my change to
2376         lldb_dump_class_layout.py" (Requested by rmorisset on
2377         #webkit).
2378
2379         Reverted changeset:
2380
2381         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2382         classes with suspicious padding"
2383         https://bugs.webkit.org/show_bug.cgi?id=195573
2384         https://trac.webkit.org/changeset/242825
2385
2386 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2387
2388         [ews-build] Show status bubbles while the patch is waiting in queue
2389         https://bugs.webkit.org/show_bug.cgi?id=195618
2390
2391         Reviewed by Lucas Forschler.
2392
2393         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2394         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2395         enabled in initial deployment.
2396         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2397         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2398         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2399         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2400         (StatusBubble._build_bubbles_for_patch):
2401
2402 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2403
2404         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2405         https://bugs.webkit.org/show_bug.cgi?id=195573
2406
2407         Reviewed by Simon Fraser.
2408
2409         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2410
2411         * Scripts/dump-class-layout:
2412         (main):
2413         * lldb/lldb_dump_class_layout.py:
2414         (ClassLayout.__init__):
2415         (ClassLayout._compute_padding_recursive):
2416         (LLDBDebuggerInstance.dump_layout_for_classname):
2417         (LLDBDebuggerInstance):
2418         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2419         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2420
2421 2019-03-12  Chris Dumez  <cdumez@apple.com>
2422
2423         Device Orientation access permission should be denied unless explicitly granted by the client
2424         https://bugs.webkit.org/show_bug.cgi?id=195625
2425
2426         Reviewed by Youenn Fablet.
2427
2428         add API test coverage.
2429
2430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2431         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2432         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2433         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2434         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2435         (runDeviceOrientationTest):
2436         (TEST):
2437         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2438         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2439
2440 2019-03-12  Jer Noble  <jer.noble@apple.com>
2441
2442         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2443         https://bugs.webkit.org/show_bug.cgi?id=195137
2444         <rdar://problem/48810307>
2445
2446         Reviewed by Eric Carlson.
2447
2448         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2449         (TestWebKitAPI::TEST):
2450
2451 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2452
2453         [ews-build] Change urls from uat to production
2454         https://bugs.webkit.org/show_bug.cgi?id=195566
2455
2456         Reviewed by Lucas Forschler.
2457
2458         * BuildSlaveSupport/ews-app/ews/config.py:
2459         * BuildSlaveSupport/ews-build/events.py:
2460         * BuildSlaveSupport/ews-build/steps.py:
2461
2462 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2463
2464         [ews-build] change max_builds for local-worker to 1
2465         https://bugs.webkit.org/show_bug.cgi?id=195568
2466
2467         Reviewed by Lucas Forschler.
2468
2469         * BuildSlaveSupport/ews-build/loadConfig.py:
2470
2471 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2472
2473         Fix the build
2474
2475         * TestRunnerShared/spi/PencilKitTestSPI.h:
2476         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2477
2478 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2479
2480         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2481         https://bugs.webkit.org/show_bug.cgi?id=194131
2482
2483         Reviewed by Michael Catanzaro.
2484
2485         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2486         (uriChanged):
2487         (testUnfinishedSubresourceLoad):
2488         (serverCallback):
2489         (beforeAll):
2490
2491 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2492
2493         WTF::Expected should use std::addressof instead of operator&
2494         https://bugs.webkit.org/show_bug.cgi?id=195604
2495
2496         Reviewed by Myles Maxfield.
2497
2498         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2499         (TestWebKitAPI::Unique::Unique):
2500         (TestWebKitAPI::Unique::operator&):
2501         (TestWebKitAPI::TEST):
2502
2503 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2504
2505         Add Optional to Forward.h.
2506         https://bugs.webkit.org/show_bug.cgi?id=195586
2507
2508         Reviewed by Darin Adler.
2509
2510         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2511         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2512         Remove unnecessary includes from headers.
2513
2514 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2515
2516         Add testing API to hit-test and scroll overflow scrollers
2517         https://bugs.webkit.org/show_bug.cgi?id=195278
2518
2519         Reviewed by Antti Koivisto.
2520         
2521         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2522         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2523         
2524         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2525
2526         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2527         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2528         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2529         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2530         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2531         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2532         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2533         (WTR::enclosingScrollViewIncludingSelf):
2534         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2535
2536 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2537
2538         API test WebKit.RequestTextInputContext fails on iOS
2539         https://bugs.webkit.org/show_bug.cgi?id=195585
2540
2541         Reviewed by Wenson Hsieh and Simon Fraser.
2542
2543         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2544         (applyStyle):
2545         (TEST):
2546         Add a viewport, so that the coordinates match up on iOS.
2547         Scroll by moving the UIScrollView's contentOffset.
2548
2549 2019-03-11  Chris Dumez  <cdumez@apple.com>
2550
2551         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2552         https://bugs.webkit.org/show_bug.cgi?id=195506
2553         <rdar://problem/48733477>
2554
2555         Reviewed by Alex Christensen.
2556
2557         Add API test coverage.
2558
2559         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2560
2561 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2562
2563         Adding myself to contributors.json
2564
2565         Unreviewed, addming myself to contributors.json .
2566
2567         * Scripts/webkitpy/common/config/contributors.json:
2568
2569 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2570
2571         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2572         https://bugs.webkit.org/show_bug.cgi?id=195511
2573         <rdar://problem/44873269>
2574
2575         Reviewed by Darin Adler.
2576
2577         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2578         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2579         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2580         (TEST_F):
2581
2582 2019-03-11  Chris Dumez  <cdumez@apple.com>
2583
2584         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2585         https://bugs.webkit.org/show_bug.cgi?id=195561
2586
2587         Reviewed by Youenn Fablet.
2588
2589         Make sure the JS in the test requests for permission to receive device orientation events.
2590
2591         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2592
2593 2019-03-11  Youenn Fablet  <youenn@apple.com>
2594
2595         Allow storage quota increase by default in WTR
2596         https://bugs.webkit.org/show_bug.cgi?id=195541
2597
2598         Reviewed by Geoffrey Garen.
2599
2600         Allow storage quota increase by default in WTR.
2601         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2602         Use this for tests that explicitly need cache increase.
2603
2604         Instead of increasing quota by 2, make sure the next request is
2605         granted by adding all given parameters.
2606
2607         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2608         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2609         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2610         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2611         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2612         * WebKitTestRunner/TestController.cpp:
2613         (WTR::TestController::setAllowStorageQuotaIncrease):
2614         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2615         * WebKitTestRunner/TestController.h:
2616         * WebKitTestRunner/TestInvocation.cpp:
2617         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2618         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2619         (WTR::TestController::cocoaResetStateToConsistentValues):
2620         (WTR::TestController::setAllowStorageQuotaIncrease):
2621         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2622         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2623         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2624
2625 2019-03-11  Xan Lopez  <xan@igalia.com>
2626
2627         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2628         https://bugs.webkit.org/show_bug.cgi?id=194147
2629
2630         Reviewed by Michael Saboff.
2631
2632         To make --32-bit work correctly on Linux/64bit we need to:
2633
2634         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2635         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2636         unfortunately CMake only allows us to do this during
2637         crosscompilation, which is overkill here.
2638         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2639         pkg-config detection module uses the x86 .pc files instead of the
2640         x86_64 ones.
2641         - Set the -m32 flags for the compiler.
2642
2643         * Scripts/webkitdirs.pm:
2644         (generateBuildSystemFromCMakeProject):
2645
2646 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2647
2648         Add MotionMark-1.1 plan file for run-benchmark script.
2649         https://bugs.webkit.org/show_bug.cgi?id=195481
2650
2651         Rubber-stamped by Darin Adler.
2652
2653         Run-benchmark script should support MontionMark-1.1.
2654
2655         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2656
2657 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2658
2659         [ews-app] Add support for submit-to-ews url
2660         https://bugs.webkit.org/show_bug.cgi?id=195477
2661
2662         Reviewed by Lucas Forschler.
2663
2664         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2665         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2666         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2667         * BuildSlaveSupport/ews-app/ews/urls.py:
2668         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2669
2670 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2671
2672         Unreviewed, rolling out r242688, r242643, r242624.
2673
2674         Caused multiple layout test failures and crashes on iOS and macOS.
2675
2676         Reverted changeset:
2677
2678         "requestAnimationFrame should execute before the next frame"
2679         https://bugs.webkit.org/show_bug.cgi?id=177484
2680         https://trac.webkit.org/changeset/242624/webkit
2681
2682         * Tracing/SystemTracePoints.plist:
2683
2684 2019-03-11  John Wilander  <wilander@apple.com>
2685
2686         Resource Load Statistics: Make it possible exclude localhost from classification
2687         https://bugs.webkit.org/show_bug.cgi?id=195474
2688         <rdar://problem/47520577>
2689
2690         Reviewed by Brent Fulgham.
2691
2692         This patch allows for localhost to be excluded from classification and
2693         treatment as a prevalent resource.
2694
2695         The WebKit Tools change adds a new function called
2696         testRunner.setStatisticsIsRunningTest() which can be used to control this
2697         behavior.
2698
2699         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2700         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2701         (WTR::TestRunner::setStatisticsIsRunningTest):
2702         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2703         * WebKitTestRunner/TestController.cpp:
2704         (WTR::TestController::setStatisticsIsRunningTest):
2705         * WebKitTestRunner/TestController.h:
2706         * WebKitTestRunner/TestInvocation.cpp:
2707         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2708
2709 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2710
2711         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2712         https://bugs.webkit.org/show_bug.cgi?id=195560
2713
2714         Reviewed by Lucas Forschler.
2715
2716         * BuildSlaveSupport/ews-build/master.cfg:
2717
2718 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2719
2720         Unreviewed, rolling out r242698.
2721
2722         API test crashes on bots.
2723
2724         Reverted changeset:
2725
2726         "Add a WKContentRuleList variant that uses copied memory
2727         instead of mmap'd shared memory for class A containerized
2728         apps"
2729         https://bugs.webkit.org/show_bug.cgi?id=195511
2730         https://trac.webkit.org/changeset/242698
2731
2732 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2733
2734         [WPE] Enable web process sandbox
2735         https://bugs.webkit.org/show_bug.cgi?id=195169
2736
2737         Reviewed by Daniel Bates.
2738
2739         * wpe/install-dependencies:
2740         * wpe/jhbuild.modules:
2741
2742 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2743
2744         [ews-app] Use port 17000 for worker communication
2745         https://bugs.webkit.org/show_bug.cgi?id=195558
2746
2747         Reviewed by Lucas Forschler.
2748
2749         * BuildSlaveSupport/ews-build/master.cfg:
2750
2751 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2752
2753         [ews-build] unit-tests fail when passwords.json is missing
2754         https://bugs.webkit.org/show_bug.cgi?id=195557
2755
2756         Reviewed by Lucas Forschler.
2757
2758         * BuildSlaveSupport/ews-build/loadConfig.py:
2759         (loadBuilderConfig):
2760         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2761         (ConfigDotJSONTest.test_configuration):
2762         * BuildSlaveSupport/ews-build/master.cfg:
2763
2764 2019-03-11  Truitt Savell  <tsavell@apple.com>
2765
2766         Unreviewed, rolling out r242702.
2767
2768         Broke High Sierra builders.
2769
2770         Reverted changeset:
2771
2772         "Add utility function to allow easy reverse range-based
2773         iteration of a container"
2774         https://bugs.webkit.org/show_bug.cgi?id=195542
2775         https://trac.webkit.org/changeset/242702
2776
2777 2019-03-11  Sam Weinig  <sam@webkit.org>
2778
2779         Add utility function to allow easy reverse range-based iteration of a container
2780         https://bugs.webkit.org/show_bug.cgi?id=195542
2781
2782         Reviewed by Antti Koivisto.
2783
2784         * TestWebKitAPI/CMakeLists.txt:
2785         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2786         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2787         (TestWebKitAPI::TEST):
2788         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2789
2790 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2791
2792         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2793         https://bugs.webkit.org/show_bug.cgi?id=195511
2794         <rdar://problem/44873269>
2795
2796         Reviewed by Darin Adler.
2797
2798         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2799         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2800         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2801         (TEST_F):
2802
2803 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2804
2805         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2806         https://bugs.webkit.org/show_bug.cgi?id=195499
2807
2808         Reviewed by Darin Adler.
2809
2810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2811         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2812         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2813         (-[WKWebView synchronouslyFocusTextInputContext:]):
2814         (applyStyle):
2815         (applyIframe):
2816         (TEST):
2817         Add some tests for this SPI.
2818
2819 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2820
2821         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2822         https://bugs.webkit.org/show_bug.cgi?id=181151
2823
2824         Reviewed by Don Olmstead.
2825
2826         * TestWebKitAPI/CMakeLists.txt:
2827         * TestWebKitAPI/PlatformWin.cmake:
2828         Enable TestWTF RunLoop tests in all platforms.
2829
2830         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2831         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2832         (TestWebKitAPI::DerivedOneShotTimer::fired):
2833         (TestWebKitAPI::TEST):
2834         Only a few platforms support nested RunLoop.
2835
2836         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2837         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2838
2839 2019-03-10  David Quesada  <david_quesada@apple.com>
2840
2841         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2842         https://bugs.webkit.org/show_bug.cgi?id=152480
2843
2844         Reviewed by Chris Dumez.
2845
2846         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2847         there are no additional references to the process pool besides the one held by
2848         the download, waits for the download to finish (in the sense that the
2849         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2850         measure, also check that the process pool has been deallocated at the end of the
2851         test. The test wouldn't be meaningful if the process pool were still alive.
2852
2853         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2854         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2855         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2856             The download will be canceled because the delegate does not implement the
2857             method to decide the download's destination, so this is where we know the
2858             DownloadProxyMap is done with the DownloadProxy.
2859         (TEST):
2860
2861 2019-03-08  Chris Dumez  <cdumez@apple.com>
2862
2863         Add support for Device Orientation / Motion permission API
2864         https://bugs.webkit.org/show_bug.cgi?id=195329
2865         <rdar://problem/47645367>
2866
2867         Reviewed by Geoffrey Garen.
2868
2869         Add test infrastructure to help test the Device Orientation / Motion permission API.
2870
2871         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2872         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2873         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2874         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2875         * WebKitTestRunner/TestController.cpp:
2876         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2877         (WTR::TestController::createWebViewWithOptions):
2878         (WTR::TestController::resetStateToConsistentValues):
2879         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2880         * WebKitTestRunner/TestController.h:
2881         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2882         * WebKitTestRunner/TestInvocation.cpp:
2883         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2884
2885 2019-03-08  Saam barati  <sbarati@apple.com>
2886
2887         Add a compare-results script to compare benchmark results
2888         https://bugs.webkit.org/show_bug.cgi?id=195486
2889         <rdar://problem/48723397>
2890
2891         Reviewed by Geoffrey Garen.
2892
2893         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2894         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2895         to extend it to learn about our other benchmarks.
2896
2897         * Scripts/compare-results: Added.
2898         (readJSONFile):
2899         (detectJetStream2):
2900         (JetStream2Results):
2901         (detectSpeedometer2):
2902         (Speedometer2Results):
2903         (detectPLT5):
2904         (PLT5Results):
2905         (detectBenchmark):
2906         (biggerIsBetter):
2907         (ttest):
2908         (getOptions):
2909         (main):
2910
2911 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2912
2913         Ensure old tab state is cleared between iterations of run-benchmark
2914         https://bugs.webkit.org/show_bug.cgi?id=195393
2915         <rdar://problem/46885583>
2916
2917         Reviewed by Dewei Zhu.
2918
2919         a) ensure the default to restore state is not set
2920         b) terminate Safari correctly
2921         c) Set the system default to ignore Persistent State in Safari
2922
2923         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2924         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2925         (OSXBrowserDriver.prepare_env): 
2926         (OSXBrowserDriver.restore_env):
2927         (OSXBrowserDriver.close_browsers):
2928         (OSXBrowserDriver._terminate_processes):
2929         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2930         (OSXChromeDriver):
2931         (OSXChromeCanaryDriver):
2932         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2933         (OSXFirefoxDriver):
2934         (OSXFirefoxNightlyDriver):
2935         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2936         (OSXSafariDriver):
2937         (OSXSafariDriver.prepare_env):
2938
2939 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2940
2941         [GTK] Several InputMethodFilter tests are failing
2942         https://bugs.webkit.org/show_bug.cgi?id=195408
2943
2944         Reviewed by Carlos Garcia Campos.
2945
2946         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2947         Regressed in r241751.
2948         Hexadecimal values of keycodes are expressed now in upper letters.
2949         Composited characters should be cast to UTF8 strings.
2950
2951         (TestWebKitAPI::TEST):
2952
2953 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2954
2955         [GTK] Make Tools/gtkdoc python3 compatible
2956         https://bugs.webkit.org/show_bug.cgi?id=195359
2957
2958         Reviewed by Carlos Garcia Campos.
2959
2960         * gtkdoc/generate-gtkdoc:
2961         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2962         work with Python 2 and 3.
2963         (get_gtkdoc_module_paths):
2964         The iteritems() was removed in Python 3, so let's use items() that's
2965         available in Python 2 and 3.
2966         (get_generator_for_config):
2967         * gtkdoc/gtkdoc.py:
2968         (GTKDoc._run_command):
2969         The sys.stdout.write() is expecting str in Python 3 and not bytes
2970         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2971         for passing the bytes there.
2972
2973 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2974
2975         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2976         https://bugs.webkit.org/show_bug.cgi?id=195346
2977         <rdar://problem/48667048>
2978
2979         Unreviewed build fix for clang-cl.
2980
2981         * DumpRenderTree/win/DumpRenderTree.cpp:
2982         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2983
2984 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2985
2986         requestAnimationFrame should execute before the next frame
2987         https://bugs.webkit.org/show_bug.cgi?id=177484
2988
2989         Reviewed by Simon Fraser.
2990
2991         Add trace points for the page RenderingUpdate.
2992
2993         * Tracing/SystemTracePoints.plist:
2994
2995 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2996
2997         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2998         https://bugs.webkit.org/show_bug.cgi?id=195353
2999         <rdar://problem/48626394>
3000
3001         Reviewed by Simon Fraser.
3002
3003         * WebKitTestRunner/ios/TestControllerIOS.mm:
3004         (WTR::TestController::platformResetPreferencesToConsistentValues):
3005
3006 2019-03-07  John Wilander  <wilander@apple.com>
3007
3008         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3009         https://bugs.webkit.org/show_bug.cgi?id=195383
3010         <rdar://problem/48570136>
3011
3012         Reviewed by Brent Fulgham.
3013
3014         This patch adds test infrastructure to purge only script-accessible cookies,
3015         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3016
3017         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3018         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3019         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3020         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3021         * WebKitTestRunner/TestController.cpp:
3022         (WTR::TestController::statisticsDeleteCookiesForHost):
3023         * WebKitTestRunner/TestController.h:
3024         * WebKitTestRunner/TestInvocation.cpp:
3025         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3026
3027 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3028
3029         Unreviewed, rolling out r242354.
3030         https://bugs.webkit.org/show_bug.cgi?id=195402
3031
3032         breaks layout tests in all configurations (Requested by
3033         zdobersek on #webkit).
3034
3035         Reverted changeset:
3036
3037         "[WPE] Enable web process sandbox"
3038         https://bugs.webkit.org/show_bug.cgi?id=195169
3039         https://trac.webkit.org/changeset/242354
3040
3041 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3042
3043         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3044         https://bugs.webkit.org/show_bug.cgi?id=195346
3045
3046         Reviewed by Fujii Hironori.
3047
3048         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3049         (TestWebKitAPI::TEST):
3050         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3051
3052         * DumpRenderTree/win/DumpRenderTree.cpp:
3053         (findFontFallback):
3054         (addFontFallbackIfPresent):
3055         (removeFontFallbackIfPresent):
3056         (main):
3057         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3058         (TestWebKitAPI::Util::moduleDirectory):
3059         (TestWebKitAPI::Util::createInjectedBundlePath):
3060         Use wchar helpers as needed.
3061
3062 2019-03-06  Rob Buis  <rbuis@igalia.com>
3063
3064         Consider supporting the `referrerpolicy` attribute.
3065         https://bugs.webkit.org/show_bug.cgi?id=179053
3066
3067         Reviewed by Darin Adler.
3068
3069         Add a runtime flag for referrerpolicy attribute.
3070
3071         * DumpRenderTree/mac/DumpRenderTree.mm:
3072         (enableExperimentalFeatures):
3073
3074 2019-03-05  Daniel Bates  <dabates@apple.com>
3075
3076         Update expected API test result following r242379
3077         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3078
3079         Update expected x-coordinate of selection rect now that the left padding of
3080         a textarea is sized in ems (so dependent on the font size) just like the left
3081         padding of a text field.
3082
3083         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3084         (TestWebKitAPI::TEST):
3085
3086 2019-03-05  David Quesada  <david_quesada@apple.com>
3087
3088         [WK2] It should be possible to follow links with 'download' attributes
3089         https://bugs.webkit.org/show_bug.cgi?id=195145
3090         rdar://problem/48462642
3091
3092         Reviewed by Alex Christensen.
3093
3094         Add a unit test to verify that activating links with 'download' attributes now
3095         navigates to the linked resource, rather than starts downloading it. Add another
3096         to verify that it is still possible to explicitly download the link via the
3097         'Download' navigation action policy.
3098
3099         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3100         (-[DownloadAttributeTestDelegate init]):
3101         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3102         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3103         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3104         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3105         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3106         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3107         (TEST):
3108         * WebKitTestRunner/TestController.cpp:
3109         (WTR::TestController::decidePolicyForNavigationAction):
3110         * WebKitTestRunner/TestController.h:
3111
3112 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3113
3114         [Curl] Implement Cookie Accept Policy.
3115         https://bugs.webkit.org/show_bug.cgi?id=191645
3116
3117         Reviewed by Fujii Hironori.
3118
3119         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3120         (TestWebKitAPI::Curl::TEST_F):
3121
3122 2019-03-05  Youenn Fablet  <youenn@apple.com>
3123
3124         Rename requestCacheStorageSpace to requestStorageSpace
3125         https://bugs.webkit.org/show_bug.cgi?id=195282
3126
3127         Reviewed by Chris Dumez.
3128
3129         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3130         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3131         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3132
3133 2019-03-05  Brady Eidson  <beidson@apple.com>
3134
3135         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3136         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3137
3138         Reviewed by Tim Horton.
3139
3140         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3141         different directory into that same WKWebView should work.
3142
3143         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3144         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3145
3146 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3147
3148         Add WeakHashSet
3149         https://bugs.webkit.org/show_bug.cgi?id=195152
3150
3151         Reviewed by Antti Koivisto.
3152
3153         Added tests for WeakHashSet.
3154
3155         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3156         (TestWebKitAPI::Base::Base): Moved.
3157         (TestWebKitAPI::Derived::foo): Moved.
3158         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3159         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3160         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3161         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3162
3163 2019-03-04  Chris Dumez  <cdumez@apple.com>
3164
3165         Do not share WebProcesses between private and regular sessions
3166         https://bugs.webkit.org/show_bug.cgi?id=195189
3167         <rdar://problem/48421064>
3168
3169         Reviewed by Alex Christensen.
3170
3171         Add API test coverage.
3172
3173         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3174         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3175
3176 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3177
3178         [WPE] Enable web process sandbox
3179         https://bugs.webkit.org/show_bug.cgi?id=195169
3180
3181         Reviewed by Daniel Bates.
3182
3183         * wpe/install-dependencies:
3184         * wpe/jhbuild.modules:
3185
3186 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3187
3188         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3189         https://bugs.webkit.org/show_bug.cgi?id=195206
3190
3191         Reviewed by Žan Doberšek.
3192
3193         Add a new test case.
3194
3195         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3196         (testJSCClass):
3197
3198 2019-03-04  Charlie Turner  <cturner@igalia.com>
3199
3200         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3201         https://bugs.webkit.org/show_bug.cgi?id=194898
3202
3203         Reviewed by Žan Doberšek.
3204
3205         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3206         a GCC extension that permits arithmetic on void* pointer. Inline
3207         the macro until this issue is fixed upstream.
3208
3209 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3210
3211         Rid the world of WK_API_ENABLED
3212         https://bugs.webkit.org/show_bug.cgi?id=195263
3213
3214         Reviewed by Dan Bernstein.
3215
3216         List of changed files elided because it's useless.
3217
3218 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3219
3220         Unreviewed follow-up to r242292.
3221
3222         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3223
3224         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3225         (TestWebKitAPI::testStrip): Renamed from strip.
3226         (TestWebKitAPI::TEST):
3227
3228 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3229
3230         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3231
3232         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3233         and bug #194272 for details.
3234
3235         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3236
3237 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3238
3239         Remove some more unused 32-bit code
3240         https://bugs.webkit.org/show_bug.cgi?id=195255
3241
3242         Reviewed by Darin Adler.
3243
3244         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3245         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3246         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3247         (NPP_New):
3248         (NPP_HandleEvent):
3249         (handleEventCarbon): Deleted.
3250
3251 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3252
3253         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3254
3255         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3256         (TestWebKitAPI::TEST):
3257
3258 2019-03-01  Darin Adler  <darin@apple.com>
3259
3260         Finish removing String::format
3261         https://bugs.webkit.org/show_bug.cgi?id=194893
3262
3263         Reviewed by Daniel Bates.
3264 '
3265         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3266
3267 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3268
3269         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3270         https://bugs.webkit.org/show_bug.cgi?id=195229
3271         <rdar://problem/48520362>
3272
3273         Reviewed by Chris Dumez.
3274
3275         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3276         (TEST):
3277
3278 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3279
3280         Add a system trace scope for event region building
3281         https://bugs.webkit.org/show_bug.cgi?id=195226
3282
3283         Reviewed by Jon Lee.
3284
3285         This trace scope measures the time spend converting element rects into Region objects,
3286         which can be large on some pages.
3287
3288         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3289
3290         * Tracing/SystemTracePoints.plist:
3291
3292 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3293
3294         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3295         https://bugs.webkit.org/show_bug.cgi?id=194612
3296
3297         Reviewed by Alex Christensen.
3298
3299         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3300         Just test the new string-processing function and don't touch the actual environment.
3301         (Test cases are all as before, but based on operator== instead of strcmp.)
3302
3303 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3304
3305         [ews-app] Update primary keys for handling multiple Buildbot instances
3306         https://bugs.webkit.org/show_bug.cgi?id=195120
3307
3308         Reviewed by Stephanie Lewis.
3309
3310         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3311         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3312         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3313
3314         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3315         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3316         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3317         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3318         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3319         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3320
3321 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3322
3323         [WinCairo] Enable service worker
3324         https://bugs.webkit.org/show_bug.cgi?id=188318
3325
3326         Reviewed by Youenn Fablet.
3327
3328         * DumpRenderTree/DumpRenderTreePrefix.h:
3329         * TestWebKitAPI/PlatformWin.cmake:
3330         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3331         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3332         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3333
3334 2019-03-01  Justin Fan  <justin_fan@apple.com>
3335
3336         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3337         https://bugs.webkit.org/show_bug.cgi?id=195191
3338
3339         Rubber-stamped by Dean Jackson.
3340
3341         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3342
3343         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3344
3345 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3346
3347         Unreviewed, fix lldb webkitpy tests
3348         https://bugs.webkit.org/show_bug.cgi?id=194375
3349
3350         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3351
3352         * lldb/lldb_webkit.py:
3353         (WTFStringImplProvider.is_8bit):
3354
3355 2019-02-28  David Quesada  <david_quesada@apple.com>
3356
3357         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3358         https://bugs.webkit.org/show_bug.cgi?id=195121
3359         rdar://problem/48450302
3360
3361         Reviewed by Alex Christensen.
3362
3363         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3364         configurations where the 'download' attribute is absent, blank, or populated
3365         with a filename, and where the anchor element is same-origin or cross-origin
3366         (meaning the 'download' attribute shouldn't be honored).
3367
3368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3369         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3370         (-[NavigationActionTestDelegate init]):
3371         (-[NavigationActionTestDelegate navigationAction]):
3372         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3373         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3374         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3375         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3376         (TEST):
3377
3378 2019-02-28  Antoine Quint  <graouts@apple.com>
3379
3380         Enable the Pointer Events runtime flag by default
3381         https://bugs.webkit.org/show_bug.cgi?id=195156
3382
3383         Reviewed by Dean Jackson.
3384
3385         * DumpRenderTree/mac/DumpRenderTree.mm:
3386         (enableExperimentalFeatures):
3387
3388 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3389
3390         Several PasteImage API tests are flaky
3391         https://bugs.webkit.org/show_bug.cgi?id=195160
3392
3393         Reviewed by Tim Horton.
3394
3395         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3396         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3397         listening for a "load" event after image load is already complete.
3398
3399         To address this, make these tests first register a "load" event handler, then run script to insert an image
3400         element into the document, and finally wait until the load event is observed before checking image size.
3401
3402         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3403
3404 2019-02-28  Chris Dumez  <cdumez@apple.com>
3405
3406         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3407         https://bugs.webkit.org/show_bug.cgi?id=195107
3408
3409         Reviewed by Alex Christensen.
3410
3411         Give some time for the zoom level to get restored.
3412
3413         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3414
3415 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3416
3417         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3418         https://bugs.webkit.org/show_bug.cgi?id=194958
3419
3420         Reviewed by Geoffrey Garen.
3421
3422         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3423         (TEST):
3424
3425 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3426
3427         [ews-app] Update method to save build to handle builder_display_name
3428         https://bugs.webkit.org/show_bug.cgi?id=195047
3429
3430         Reviewed by Dewei Zhu.
3431
3432         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3433         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3434
3435 2019-02-28  Justin Fan  <justin_fan@apple.com>
3436
3437         [Web GPU] Enable Web GPU only on 64-bit
3438         https://bugs.webkit.org/show_bug.cgi?id=195139
3439
3440         Because Metal is only supported on 64 bit apps.
3441
3442         Unreviewed build fix.
3443
3444         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3445
3446 2019-02-27  Youenn Fablet  <youenn@apple.com>
3447
3448         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3449         https://bugs.webkit.org/show_bug.cgi?id=194959
3450
3451         Reviewed by Chris Dumez.
3452
3453         Spin loop until getting the condition to remove flakiness.
3454
3455         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3456
3457 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3458
3459         [ews-build] Buildbot should include builder_display_name in the build events
3460         https://bugs.webkit.org/show_bug.cgi?id=195045
3461
3462         Reviewed by Dewei Zhu.
3463
3464         * BuildSlaveSupport/ews-build/events.py:
3465         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3466         buildername to builder_name to be consistent in naming style.
3467         (Events.buildFinished): Ditto.
3468
3469 2019-02-27  Chris Dumez  <cdumez@apple.com>
3470
3471         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3472         https://bugs.webkit.org/show_bug.cgi?id=194480
3473
3474         Reviewed by Brady Eidson.
3475
3476         Update existing API test to make it more likely to reproduce the issue.
3477
3478         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3479
3480 2019-02-27  Brady Eidson  <beidson@apple.com>
3481
3482         Universal links from Google search results pages don't open the app.
3483         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3484
3485         Reviewed by Geoffrey Garen.
3486
3487         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3488         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3489         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3490         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3491
3492 2019-02-27  Chris Dumez  <cdumez@apple.com>
3493
3494         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3495         https://bugs.webkit.org/show_bug.cgi?id=195102
3496
3497         Reviewed by Geoffrey Garen.
3498
3499         If the number of processes is not yet what we expect, wait a bit and check again to give
3500         processes some time to exit.
3501
3502         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3503
3504 2019-02-27  Chris Dumez  <cdumez@apple.com>
3505
3506         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3507         https://bugs.webkit.org/show_bug.cgi?id=194545
3508
3509         Reviewed by Brady Eidson.
3510
3511         Make sure the test navigates forward and then back only once. Previously, navigating
3512         back would trigger a navigation again in a timer.
3513
3514         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3515
3516 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3517
3518         High Sierra Debug JSC test queue should use faster hardware
3519         https://bugs.webkit.org/show_bug.cgi?id=194603
3520
3521         Rubber-stamped by Alexey Proskuryakov.
3522
3523         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3524
3525         * BuildSlaveSupport/build.webkit.org-config/config.json:
3526         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3527         (BubbleQueueServer):
3528         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3529         (WebKitBuildbot):
3530         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3531         * QueueStatusServer/config/queues.py:
3532         * Scripts/webkitpy/common/config/ews.json:
3533         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3534         (test_ews_name):
3535
3536 2019-02-27  John Wilander  <wilander@apple.com>
3537
3538         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3539         https://bugs.webkit.org/show_bug.cgi?id=195071
3540         <rdar://problem/48417690>
3541
3542         Reviewed by Alex Christensen and Brent Fulgham.
3543
3544         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3545         (TestWebKitAPI::createURL):
3546             Convenience function.
3547         (TestWebKitAPI::TEST):
3548             WebCore::AdClickAttribution now takes a URL when creating Source and
3549             Destination.
3550         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3551         (TestWebKitAPI::TEST):
3552             WebCore::AdClickAttribution now takes a URL when creating Source and
3553             Destination.
3554
3555 2019-02-27  Antoine Quint  <graouts@apple.com>
3556
3557         Support Pointer Events on macOS
3558         https://bugs.webkit.org/show_bug.cgi?id=195008
3559         <rdar://problem/47454419>
3560
3561         Reviewed by Dean Jackson.
3562
3563         * DumpRenderTree/mac/DumpRenderTree.mm:
3564         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3565         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3566
3567 2019-02-26  Mark Lam  <mark.lam@apple.com>
3568
3569         Remove remaining poisoning code.
3570         https://bugs.webkit.org/show_bug.cgi?id=194138
3571
3572         Reviewed by Saam Barati.
3573
3574         * TestWebKitAPI/CMakeLists.txt:
3575         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3576         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3577         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3578         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3579         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3580         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3581         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3582
3583 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3584
3585         Move ephemeral local storage from WebProcess to UIProcess
3586         https://bugs.webkit.org/show_bug.cgi?id=195074
3587         <rdar://problem/47937975>
3588
3589         Reviewed by Geoff Garen.
3590
3591         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3592
3593 2019-02-20  Jer Noble  <jer.noble@apple.com>
3594
3595         [Cocoa] Media elements will restart network buffering just before suspending
3596         https://bugs.webkit.org/show_bug.cgi?id=193691
3597
3598         Reviewed by Eric Carlson.
3599
3600         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3601         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3602         (TEST):
3603
3604 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3605
3606         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3607         https://bugs.webkit.org/show_bug.cgi?id=191652
3608
3609         Reviewed by Alex Christensen.
3610
3611         Fix WinCairo MiniBrowser behavior of authentication dialog.
3612
3613         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3614         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3615
3616 2019-02-26  Youenn Fablet  <youenn@apple.com>
3617
3618         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3619         https://bugs.webkit.org/show_bug.cgi?id=195028
3620         <rdar://problem/48243733>
3621
3622         Reviewed by Eric Carlson.
3623
3624         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3625
3626 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3627
3628         [WPE] Add API for webview background color configuration
3629         https://bugs.webkit.org/show_bug.cgi?id=192305
3630
3631         Reviewed by Michael Catanzaro.
3632
3633         * MiniBrowser/wpe/main.cpp:
3634         (main): Add a new option to configure the webview background
3635         color. Example: --bg-color=transparent.
3636         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3637         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3638         (beforeAll): Ditto.
3639
3640 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3641
3642         scalableNativeWebpageParameters() is not preserved on new page navigation.
3643         https://bugs.webkit.org/show_bug.cgi?id=194892
3644         <rdar://problem/47538280>
3645
3646         Reviewed by Wenson Hsieh.
3647         
3648         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3649
3650         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3651         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3652         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3653         (WTR::UIScriptController::allowsViewportShrinkToFit):
3654         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3655         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3656         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3657         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3658         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3659         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3660
3661 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3662
3663         [ews-app] Add model for handling multiple Buildbot instances
3664         https://bugs.webkit.org/show_bug.cgi?id=194863
3665
3666         Reviewed by Stephanie Lewis.
3667
3668         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3669
3670 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3671
3672         [ews-app] Remove BuilderMapping table
3673         https://bugs.webkit.org/show_bug.cgi?id=194961
3674
3675         Reviewed by Stephanie Lewis.
3676
3677         Store builder name directly in build table, instead of having a separate
3678         table for it.
3679
3680         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3681         * BuildSlaveSupport/ews-app/ews/models/build.py:
3682         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3683         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3684
3685 2019-02-25  John Wilander  <wilander@apple.com>
3686
3687         Introduce and adopt new class RegistrableDomain for eTLD+1
3688         https://bugs.webkit.org/show_bug.cgi?id=194791
3689         <rdar://problem/48179240>
3690
3691         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3692
3693         This patch adds an API test and replaces two instances of
3694         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3695
3696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3697         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3698         (TestWebKitAPI::TEST):
3699             Changed two strings to make sure the registrable domains are still considered
3700             invalid and pass the test.
3701         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3702         (TestWebKitAPI::TEST):
3703         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3704         (WTR::InjectedBundle::didReceiveMessageToPage):
3705
3706 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3707
3708         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3709         https://bugs.webkit.org/show_bug.cgi?id=195001
3710
3711         Reviewed by Carlos Garcia Campos.
3712
3713         API version 1.0 always includes the functionality previously guarded with
3714         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3715         unconditionally.
3716
3717         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3718         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3719         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3720         (WebViewTest::showInWindow): Ditto.
3721         (WebViewTest::hideView): Ditto.
3722         * wpe/backends/HeadlessViewBackend.cpp:
3723         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3724         * wpe/backends/ViewBackend.cpp:
3725         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3726         * wpe/backends/WindowViewBackend.cpp:
3727         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3728         WPE_BACKEND_CHECK_VERSION().
3729         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3730
3731 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3732
3733         [Flatpak] Add support for flatpak > 1.1.2
3734         https://bugs.webkit.org/show_bug.cgi?id=194088
3735
3736         Flatpak 1.2 is now out so we need to support that
3737         version now.
3738
3739         Reviewed by Michael Catanzaro.
3740
3741         * flatpak/flatpakutils.py:
3742         (check_flatpak):
3743         (FlatpakPackages.__init__):
3744         (FlatpakPackages.__detect_packages):
3745         (FlatpakPackages.__detect_packages.in):
3746         (FlatpakRepos.update):
3747
3748 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3749
3750         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3751         https://bugs.webkit.org/show_bug.cgi?id=194998
3752
3753         Reviewed by Carlos Garcia Campos.
3754
3755         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3756         to a Git checkout and using the latest commit containing various fixes
3757         and improvements.
3758
3759 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3760
3761         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3762         https://bugs.webkit.org/show_bug.cgi?id=194981
3763
3764         Reviewed by Žan Doberšek.
3765
3766         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3767         (TestWebKitAPI::TEST):
3768
3769 2019-02-23  Keith Miller  <keith_miller@apple.com>
3770
3771         Add new mac target numbers
3772         https://bugs.webkit.org/show_bug.cgi?id=194955
3773
3774         Reviewed by Tim Horton.
3775
3776         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3777         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3778         * MiniBrowser/Configurations/Base.xcconfig:
3779         * TestWebKitAPI/Configurations/Base.xcconfig:
3780         * WebKitTestRunner/Configurations/Base.xcconfig:
3781
3782 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3783
3784         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3785         https://bugs.webkit.org/show_bug.cgi?id=194846
3786
3787         Reviewed by Don Olmstead.
3788
3789         Added _search_paths() and _port_specific_expectations_files() for
3790         WinCairoPort.
3791
3792         * Scripts/webkitpy/port/win.py:
3793         (WinCairoPort.default_baseline_search_path):
3794         (WinCairoPort):
3795         (WinCairoPort._port_specific_expectations_files):
3796         (WinCairoPort._search_paths):
3797
3798 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3799
3800         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3801         https://bugs.webkit.org/show_bug.cgi?id=194963
3802
3803         Reviewed by Dean Jackson.
3804
3805         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3806         Do a `contains` check instead of `equals`, because in debug builds we
3807         put the GraphicsLayer pointer in a prefix.
3808
3809 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3810
3811         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3812         https://bugs.webkit.org/show_bug.cgi?id=194873
3813         <rdar://problem/46701974>
3814
3815         Reviewed by Tim Horton.
3816
3817         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3818
3819         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3820         (WTR::UIScriptController::menuRect const):
3821         (WTR::UIScriptController::isShowingMenu const):
3822         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3823         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3824         (WTR::UIScriptController::menuRect const):
3825
3826         Add a function to query the bounds of the callout menu in content coordinates.
3827
3828         (WTR::UIScriptController::isShowingMenu const):
3829
3830         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3831
3832         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3833         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3834         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3835         (WTR::UIScriptController::rectForMenuAction const):
3836         (WTR::UIScriptController::menuRect const):
3837         (WTR::UIScriptController::isShowingMenu const):
3838         (WTR::findViewInHierarchyOfType): Deleted.
3839
3840 2019-02-22  Chris Dumez  <cdumez@apple.com>
3841
3842         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3843         https://bugs.webkit.org/show_bug.cgi?id=194954
3844         <rdar://problem/48127957>
3845
3846         Reviewed by Alex Christensen.
3847
3848         Add API test coverage.
3849
3850         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3851         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3852         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3853         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3854
3855 2019-02-22  Chris Dumez  <cdumez@apple.com>
3856
3857         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3858         https://bugs.webkit.org/show_bug.cgi?id=194924
3859         <rdar://problem/48216125>
3860
3861         Reviewed by Geoffrey Garen.
3862
3863         Add API test coverage.
3864
3865         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3866
3867 2019-02-22  Chris Dumez  <cdumez@apple.com>
3868
3869         Unreviewed, disable API test added in r241928 on iOS.
3870
3871         The cache is not enabled on devices with less than 3GB of RAM.
3872
3873         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3874
3875 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3876
3877         Hardcode Visual Viewports on everywhere except iOS WK1
3878         https://bugs.webkit.org/show_bug.cgi?id=194928
3879
3880         Reviewed by Zalan Bujtas.
3881
3882         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3883         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3884         set it to false. The setting has shipped for several years and there's no need to turn
3885         it off now.
3886
3887         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3888         Visual Viewports are not enabled.
3889         
3890         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3891         that only runs in WK2
3892
3893         * MiniBrowser/mac/SettingsController.h:
3894         * MiniBrowser/mac/SettingsController.m:
3895         (-[SettingsController init]):
3896         (-[SettingsController _populateMenu]):
3897         (-[SettingsController validateMenuItem:]):
3898         (-[SettingsController visualViewportEnabled]): Deleted.
3899         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3900         * MiniBrowser/mac/WK1BrowserWindowController.m:
3901         (-[WK1BrowserWindowController didChangeSettings]):
3902         * MiniBrowser/mac/WK2BrowserWindowController.m:
3903         (-[WK2BrowserWindowController didChangeSettings]):
3904
3905 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3906
3907         Discard cached processes when clearing website data store
3908         https://bugs.webkit.org/show_bug.cgi?id=194894
3909
3910         Reviewed by Chris Dumez.
3911
3912         Added a test case.
3913
3914         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3915         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3916
3917 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3918
3919         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3920         https://bugs.webkit.org/show_bug.cgi?id=194914
3921         <rdar://problem/47586889>
3922
3923         Reviewed by Geoffrey Garen.
3924
3925         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3926         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3927         (TEST):
3928         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3929
3930 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3931
3932         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3933         <https://webkit.org/b/194761>
3934
3935         Reviewed by Myles Maxfield.
3936
3937         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3938         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3939         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3940         to use ARC-compliant cast.
3941         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3942         ARC-compliant cast.
3943         (WTR::installFakeHelvetica): Log `error` to console if
3944         CTFontManagerRegisterFontsForURL() fails, but only on supported
3945         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3946         Call CFRelease() on `error` to fix the leak.  Update to use
3947         ARC-compliant cast.
3948         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3949         cast.
3950
3951 2019-02-21  Chris Dumez  <cdumez@apple.com>
3952
3953         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3954         https://bugs.webkit.org/show_bug.cgi?id=194481
3955
3956         Reviewed by Alex Christensen.
3957
3958         Give the processes a chance to shutdown and wait until we reached the expected number
3959         of processes.
3960
3961         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3962
3963 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3964
3965         Fix the macOS build
3966
3967         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3968
3969 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3970
3971         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3972
3973         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3974         I am a backwards.
3975
3976 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3977
3978         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3979
3980         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3981         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3982         We could force on UI-side compositing, but I feel like the test might be more
3983         valuable exercising the normal path on each platform (though the original
3984         bug was also UI-side specific). Though we can't validate that the overlay
3985         layer was installed successfully, there are layout tests that do that.
3986
3987 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3988
3989         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3990         https://bugs.webkit.org/show_bug.cgi?id=194845
3991         <rdar://problem/47944579>
3992
3993         Reviewed by Antti Koivisto.
3994
3995         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3996         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3997
3998 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3999
4000         [LFC][Floats] Add support for placing formatting roots in-between floats.
4001         https://bugs.webkit.org/show_bug.cgi?id=194902
4002
4003         Reviewed by Antti Koivisto.
4004
4005         * LayoutReloaded/misc/LFC-passing-tests.txt:
4006
4007 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4008
4009         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4010         https://bugs.webkit.org/show_bug.cgi?id=194901
4011
4012         Unreviewed build fix.
4013
4014         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4015         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4016         WPEBackend-fdo-0.1 as library name.
4017
4018 2019-02-21  Rob Buis  <rbuis@igalia.com>
4019
4020         Update MIME type parser
4021         https://bugs.webkit.org/show_bug.cgi?id=180526
4022
4023         Reviewed by Darin Adler.
4024
4025         Add tests involving leading and trailing whitespace, non-token
4026         characters and quoted strings.
4027
4028         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4029         (TestWebKitAPI::TEST):
4030
4031 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4032
4033         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4034         https://bugs.webkit.org/show_bug.cgi?id=194884
4035
4036         Reviewed by Michael Catanzaro.
4037
4038         * PlatformWin.cmake:
4039
4040 2019-02-20  Chris Dumez  <cdumez@apple.com>
4041
4042         Add API test for <rdar://problem/47471222>
4043         https://bugs.webkit.org/show_bug.cgi?id=194847
4044
4045         Reviewed by Alex Christensen.
4046
4047         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4048
4049 2019-02-20  Chris Dumez  <cdumez@apple.com>
4050
4051         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4052         https://bugs.webkit.org/show_bug.cgi?id=194872
4053         <rdar://problem/47924500>
4054
4055         Reviewed by Alex Christensen.
4056
4057         Add API test coverage.
4058
4059         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4060
4061 2019-02-20  Jer Noble  <jer.noble@apple.com>
4062
4063         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4064         https://bugs.webkit.org/show_bug.cgi?id=191332
4065
4066         Reviewed by Dean Jackson.
4067
4068         * Scripts/git-is-in-range: Added.
4069
4070 2019-02-20  Andy Estes  <aestes@apple.com>
4071
4072         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4073         https://bugs.webkit.org/show_bug.cgi?id=194869
4074
4075         Rubber-stamped by Jer Noble.
4076
4077         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4078         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4079         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4080         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4082         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4083
4084 2019-02-20  Chris Dumez  <cdumez@apple.com>
4085
4086         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4087         https://bugs.webkit.org/show_bug.cgi?id=194857
4088         <rdar://problem/47759323>
4089
4090         Reviewed by Alex Christensen.
4091
4092         Add API test coverage.
4093
4094         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4095
4096 2019-02-20  Chris Dumez  <cdumez@apple.com>
4097
4098         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4099         https://bugs.webkit.org/show_bug.cgi?id=194829
4100         <rdar://problem/47889906>
4101
4102         Reviewed by Alexey Proskuryakov.
4103
4104         Every time the TestOptions were changing we were creating both a new Web view and
4105         a new WKContext, which would start a new Network process. In most cases, we only
4106         need to contruct a new Web view and we do can keep reusing the same WKContext.
4107         This patch implements this optimization and thus avoids spinning a lot of new
4108         Network processes while running the layout tests.
4109
4110         * WebKitTestRunner/TestController.cpp:
4111         (WTR::TestController::generateContextConfiguration const):
4112         (WTR::TestController::generatePageConfiguration):
4113         (WTR::TestController::createWebViewWithOptions):
4114         (WTR::TestController::resetPreferencesToConsistentValues):
4115         (WTR::updateTestOptionsFromTestHeader):
4116         * WebKitTestRunner/TestController.h:
4117         * WebKitTestRunner/TestOptions.h:
4118         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4119         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4120         (WTR::TestOptions::hasSameInitializationOptions const):
4121         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4122         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4123         (WTR::TestController::platformAddTestOptions const):
4124
4125 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4126
4127         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4128         https://bugs.webkit.org/show_bug.cgi?id=167941
4129
4130         Reviewed by Carlos Garcia Campos.
4131
4132         * MiniBrowser/gtk/main.c:
4133         (filterSavedCallback): Added.
4134         (main): Support loading a JSON rule set file for content filtering.
4135         * MiniBrowser/wpe/main.cpp:
4136         (filterSavedCallback): Added.
4137         (main): Support loading a JSON rule set file for content filtering.
4138         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4139         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4140         (WTF::derefGPtr): Ditto.
4141         (testEmptyStore):
4142         (testSaveInvalidFilter):
4143         (testSaveLoadFilter):
4144         (testSavedFilterIdentifierMatch):
4145         (testRemoveFilter):
4146         (testSaveMultipleFilters):
4147         (testSaveFilterFromFile):
4148         (testFilterPersistence):
4149         (beforeAll):
4150         (afterAll):
4151         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4152         (removeOldInjectedContentAndResetLists): Also reset content filters.
4153         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4154         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4155         the element affected by the style sheet.
4156         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4157         and returns it to be used by tests.
4158         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4159         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4160         (serverCallback): Add support for serving a CSS style sheet for testing.
4161         (beforeAll): Add call to testUserContentManagerContentFilter().
4162         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4163
4164 2019-02-19  Keith Rollin  <krollin@apple.com>
4165
4166         Add timing information to build output
4167         https://bugs.webkit.org/show_bug.cgi?id=194839
4168         <rdar://problem/48219609>
4169
4170         Reviewed by Alexey Proskuryakov.
4171
4172         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4173         emit each project's build time to its output. E.g.,
4174
4175             ** BUILD SUCCEEDED ** [0.132 sec]
4176
4177         * Scripts/webkitdirs.pm:
4178         (XcodeOptions):
4179
4180 2019-02-19  Truitt Savell  <tsavell@apple.com>
4181
4182         Unreviewed, rolling out r241784.
4183
4184         Broke all OpenSource builds.
4185
4186         Reverted changeset:
4187
4188         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4189         instances view"
4190         https://bugs.webkit.org/show_bug.cgi?id=172848
4191         https://trac.webkit.org/changeset/241784
4192
4193 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4194
4195         [LFC][Floats] Remove redundant intersecting logic
4196         https://bugs.webkit.org/show_bug.cgi?id=194804
4197
4198         Reviewed by Antti Koivisto.
4199
4200         * LayoutReloaded/misc/LFC-passing-tests.txt:
4201
4202 2019-02-19  Dean Jackson  <dino@apple.com>
4203
4204         Clean-up output from generate-xcfilelists so it can be filtered
4205         https://bugs.webkit.org/show_bug.cgi?id=194795
4206
4207         Reviewed by Joseph Pecoraro (and Keith Rollin).
4208
4209         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4210         make a slight tweak to filter-build-webkit so such lines are marked
4211         as plain.
4212
4213         * Scripts/filter-build-webkit:
4214         * Scripts/generate-xcfilelists:
4215
4216 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4217
4218         pytest is not correctly auto-installed
4219         https://bugs.webkit.org/show_bug.cgi?id=194707
4220
4221         Reviewed by Carlos Garcia Campos.
4222
4223         * Scripts/webkitpy/thirdparty/__init__.py:
4224         (AutoinstallImportHook._install_pytest):
4225
4226 2019-02-18  Chris Dumez  <cdumez@apple.com>
4227
4228         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4229         https://bugs.webkit.org/show_bug.cgi?id=194797
4230         <rdar://problem/48055151>
4231
4232         Reviewed by Geoffrey Garen.
4233
4234         Add API test coverage.
4235
4236         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4237
4238 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4239
4240         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4241         https://bugs.webkit.org/show_bug.cgi?id=194670
4242         <rdar://problem/39066529>
4243
4244         Reviewed by Tim Horton.
4245
4246         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4247         pasted in an editable area as attachment elements.
4248
4249         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4250         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4251         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4252         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4253         (TestWebKitAPI::TEST):
4254         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4255         (WTR::InjectedBundlePage::InjectedBundlePage):
4256
4257 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4258
4259         Fix API test after r241728
4260        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4261
4262         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4263         (TEST):
4264         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4265
4266 2019-02-18  Daniel Bates  <dabates@apple.com>
4267
4268         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4269         https://bugs.webkit.org/show_bug.cgi?id=192824
4270         <rdar://problem/47100332>
4271
4272         Reviewed by Wenson Hsieh.
4273
4274         Fix a bug where the wrong usage code was used for F13 thru F24.
4275
4276         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4277         (keyCodeForDOMFunctionKey):
4278
4279 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4280
4281         Bytecode cache should a have a boot-specific validation
4282         https://bugs.webkit.org/show_bug.cgi?id=194769
4283         <rdar://problem/48149509>
4284
4285         Reviewed by Keith Miller.
4286
4287         Add test for WTF::bootSessionUUIDString()
4288
4289         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4290         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4291         (TEST):
4292
4293 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4294
4295         Disable safe browsing in WKWebView and remove its WKPreferences API
4296         https://bugs.webkit.org/show_bug.cgi?id=194723
4297         <rdar://problem/48122993>
4298
4299         Reviewed by Geoffrey Garen.
4300
4301         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4302         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4303         (TEST):
4304         (safeBrowsingView):
4305         Make tests use SPI instead of API.
4306
4307 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4308
4309         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4310         https://bugs.webkit.org/show_bug.cgi?id=194586
4311
4312         Reviewed by Ross Kirsling.
4313
4314         * DumpRenderTree/win/DumpRenderTree.cpp:
4315         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4316         * Scripts/webkitpy/port/driver.py:
4317         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4318
4319 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4320
4321         Unreviewed, rolling out r241620.
4322
4323         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
4324         (Requested by ddkilzer on #webkit.)
4325
4326         Reverted changeset:
4327
4328         "[WTF] Add environment variable helpers"
4329         https://bugs.webkit.org/show_bug.cgi?id=192405
4330         https://trac.webkit.org/changeset/241620
4331
4332 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4333
4334         [LFC] RenderImage's default intrinsic size is 0.
4335         https://bugs.webkit.org/show_bug.cgi?id=194745
4336
4337         Reviewed by Antti Koivisto.
4338
4339         * LayoutReloaded/misc/LFC-passing-tests.txt:
4340
4341 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4342
4343         [LFC][BFC] Add support for block replaced intrinsic width.
4344         https://bugs.webkit.org/show_bug.cgi?id=194705
4345
4346         Reviewed by Simon Fraser.
4347
4348         * LayoutReloaded/misc/LFC-passing-tests.txt:
4349
4350 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4351
4352         [LFC] Apply min/max width constraints to preferred width computation
4353         https://bugs.webkit.org/show_bug.cgi?id=194739
4354
4355         Reviewed by Simon Fraser.
4356
4357         * LayoutReloaded/misc/LFC-passing-tests.txt:
4358
4359 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
4360
4361         [WTF] Add environment variable helpers
4362         https://bugs.webkit.org/show_bug.cgi?id=192405
4363
4364         Reviewed by Michael Catanzaro.
4365
4366         * DumpRenderTree/mac/DumpRenderTree.mm:
4367         (libraryPathForDumpRenderTree):