WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2
3         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
4         <https://webkit.org/b/194286>
5         <rdar://problem/47815558>
6
7         Reviewed by Alexey Proskuryakov.
8
9         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
10         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
11         WKRetainPtr<> to avoid leaking the WKDataRef.
12
13 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
14
15         Unreviewed, fix a typo
16
17         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
18
19 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
20
21         [GTK][WPE] force libpsl build to use ICU in jhbuild
22         https://bugs.webkit.org/show_bug.cgi?id=194288
23
24         Reviewed by Carlos Garcia Campos.
25
26         * gtk/jhbuild.modules:
27         Require ICU for libpsl build in jhbuild, like done in WPE.
28
29 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
30
31         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
32         https://bugs.webkit.org/show_bug.cgi?id=194209
33
34         Reviewed by Carlos Garcia Campos.
35
36         Enhance TestCookieManager to ensure this doesn't happen again.
37
38         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
39         (testCookieManagerPersistentStorage):
40         (beforeAll):
41
42 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
43
44         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
45         https://bugs.webkit.org/show_bug.cgi?id=194324
46
47         Reviewed by Andy Estes.
48
49         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
50         part of the name is already implicit, since this is in testing code in TestOptions.
51
52         * WebKitTestRunner/TestController.cpp:
53         (WTR::TestController::generateContextConfiguration const):
54         (WTR::updateTestOptionsFromTestHeader):
55         * WebKitTestRunner/TestOptions.h:
56         (WTR::TestOptions::hasSameInitializationOptions const):
57
58 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
59
60         [ews-build] Allow * as platform for builders and workers
61         https://bugs.webkit.org/show_bug.cgi?id=188533
62
63         Reviewed by Lucas Forschler.
64
65         * BuildSlaveSupport/ews-build/loadConfig.py:
66         (checkWorkersAndBuildersForConsistency):
67
68 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
69
70         [ews-build] Add few bots to config.json
71         https://bugs.webkit.org/show_bug.cgi?id=194304
72
73         Reviewed by Lucas Forschler.
74
75         * BuildSlaveSupport/ews-build/config.json:
76
77 2019-02-05  Keith Rollin  <krollin@apple.com>
78
79         Enable the automatic checking and regenerations of .xcfilelists during builds
80         https://bugs.webkit.org/show_bug.cgi?id=194124
81         <rdar://problem/47721277>
82
83         Reviewed by Tim Horton.
84
85         Bug 193790 add a facility for checking -- during build time -- that
86         any needed .xcfilelist files are up-to-date and for updating them if
87         they are not. This facility was initially opt-in by setting
88         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
89         the process seemed robust. Its now time to enable this facility and
90         make it opt-out. If there is a need to disable this facility, set and
91         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
92         running `make` or `build-webkit`, or before running Xcode from the
93         command line.
94
95         Additionally, remove the step that generates a list of source files
96         going into the UnifiedSources build step. It's only necessarily to
97         specify Sources.txt and SourcesCocoa.txt as inputs.
98
99         * Scripts/generate-xcfilelists:
100
101 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
102
103         [GTK][WPE] force libpsl build to use ICU in jhbuild
104         https://bugs.webkit.org/show_bug.cgi?id=194288
105
106         Reviewed by Philippe Normand.
107
108         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
109         This can cause build failures if libidn is detected but libunistring is not available.
110
111         Make sure that ICU is used for runtime and builtin PSL data.
112
113         * gtk/jhbuild.modules:
114         * wpe/jhbuild.modules:
115
116 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
117
118         [ews-app] Modified timestamp should be updated on updating data
119         https://bugs.webkit.org/show_bug.cgi?id=194295
120
121         Reviewed by Lucas Forschler.
122
123         * BuildSlaveSupport/ews-app/ews/models/build.py:
124         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
125         * BuildSlaveSupport/ews-app/ews/models/step.py:
126
127 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
128
129         Unreviewed, rolling out r240742.
130
131         Causes crashes on iOS simulator.
132
133         Reverted changeset:
134
135         "[iOS] Keyups for non-modifier keys identified as "Dead" when
136         not focused in a content-editable element"
137         https://bugs.webkit.org/show_bug.cgi?id=192824
138         https://trac.webkit.org/changeset/240742
139
140 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
141
142         run-webkit-tests emits message "...running None" when running tests
143         https://bugs.webkit.org/show_bug.cgi?id=194133
144         <rdar://problem/47724738>
145
146         Reviewed by Lucas Forschler.
147
148         * Scripts/webkitpy/xcode/device_type.py:
149         (DeviceType.__str__): Use both version mapping tables and use just the variant
150         name if no version name is available.
151         * Scripts/webkitpy/xcode/device_type_unittest.py:
152         (DeviceTypeTest):
153         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
154         an associated named.
155
156 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
157
158         [WPE] require python3-setuptools for meson build in jhbuild
159         https://bugs.webkit.org/show_bug.cgi?id=194287
160
161         Reviewed by Philippe Normand.
162
163         python3-setuptools is needed to build meson in jhbuild.
164         It is already required by the GTK port.
165
166         * wpe/install-dependencies:
167
168 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
169
170         [ews-app] Add method to save BuilderMapping to database
171         https://bugs.webkit.org/show_bug.cgi?id=194264
172
173         Reviewed by Lucas Forschler.
174
175         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
176         (BuilderMapping.__str__):
177         (BuilderMapping):
178         (BuilderMapping.save_mapping):
179         (BuilderMapping.update_mapping):
180         (BuilderMapping.get_existing_mapping):
181         (BuilderMapping.is_valid_mapping):
182
183 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
184
185         [ews-app] Add timestamp fields for BuilderMappings
186         https://bugs.webkit.org/show_bug.cgi?id=194266
187
188         Reviewed by Lucas Forschler.
189
190         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
191         (BuilderMapping):
192
193 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
194
195         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
196         https://bugs.webkit.org/show_bug.cgi?id=174816
197
198         Reviewed by Michael Catanzaro.
199
200         Add tests for webkit_uri_for_display().
201
202         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
203         (testURIForDisplayUnaffected):
204         (testURIForDisplayAffected):
205         (beforeAll):
206         (afterAll):
207         * TestWebKitAPI/glib/CMakeLists.txt:
208
209 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
210
211         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
212         https://bugs.webkit.org/show_bug.cgi?id=194158
213         <rdar://problem/47737268>
214
215         Rubber-stamped by Aakash Jain.
216
217         * Scripts/webkitpy/port/device_port.py:
218         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
219
220 2019-02-04  Said Abou-Hallawa  <said@apple.com>
221
222         [CG] Enable setAdditionalSupportedImageTypes for WK1
223         https://bugs.webkit.org/show_bug.cgi?id=194190
224
225         Reviewed by Tim Horton.
226
227         Add a test similar to the one under WebKit Cocoa but make it create a
228         WebView instead of a WKWebView.
229
230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
231         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
232         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
233         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
234         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
235         (TestWebKitAPI::runTest):
236         (TestWebKitAPI::TEST):
237
238 2019-02-04  Zalan Bujtas  <zalan@apple.com>
239
240         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
241         https://bugs.webkit.org/show_bug.cgi?id=194168
242
243         Reviewed by Simon Fraser.
244
245         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
246
247         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
248         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
249         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
250         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
251         (TEST):
252         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
253         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
254
255 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
256
257         REGRESSION (r237269): webkit-patch what-broke is broken 
258         https://bugs.webkit.org/show_bug.cgi?id=193025
259
260         Reviewed by Aakash Jain.
261
262         * Scripts/webkitpy/common/host.py:
263         (Host.buildbot):
264         (Host.bugzilla): Renamed to 'buildbot'.
265
266 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
267
268         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
269         https://bugs.webkit.org/show_bug.cgi?id=194207
270
271         Reviewed by Tim Horton.
272
273         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
274         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
275         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
276         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
277         start and delete forwards to remove the original attachment.
278
279         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
280         (TestWebKitAPI::TEST):
281
282 2019-02-04  Youenn Fablet  <youenn@apple.com>
283
284         Capture state should be managed consistently when doing process swapping
285         https://bugs.webkit.org/show_bug.cgi?id=194122
286         <rdar://problem/47609293>
287
288         Reviewed by Eric Carlson.
289
290         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
291         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
292         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
293         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
294         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
295         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
296         (WTR::TestRunner::isDoingMediaCapture const):
297         * WebKitTestRunner/InjectedBundle/TestRunner.h:
298         * WebKitTestRunner/TestController.cpp:
299         (WTR::TestController::isDoingMediaCapture const):
300         * WebKitTestRunner/TestController.h:
301         * WebKitTestRunner/TestInvocation.cpp:
302         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
303         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
304         (WTR::TestController::isDoingMediaCapture const):
305
306 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
307
308         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
309         https://bugs.webkit.org/show_bug.cgi?id=194142
310
311         Reviewed by Ross Kirsling.
312
313         There three 'separator' variables in TestController.cpp. Renamed
314         it 'pathSeparator', and unified them.
315
316         * WebKitTestRunner/TestController.cpp:
317         (WTR::TestController::generateContextConfiguration const):
318         (WTR::createTestURL):
319         (WTR::TestController::platformAdjustContext):
320
321 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
322
323         Make setNeedsLayout on the root more explicitly about triggering its side-effects
324         https://bugs.webkit.org/show_bug.cgi?id=194198
325
326         Reviewed by Antti Koivisto.
327
328         No need to set the banner heights on navigation now, since Page stores them.
329
330         * MiniBrowser/mac/WK2BrowserWindowController.m:
331         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
332
333 2019-02-03  John Wilander  <wilander@apple.com>
334
335         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
336         https://bugs.webkit.org/show_bug.cgi?id=194104
337         <rdar://problem/47649991>
338
339         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
340
341         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
342         (TestWebKitAPI::TEST):
343             Changed numeric types from unsigned short to uint32_t.
344
345 2019-02-02  David Kilzer  <ddkilzer@apple.com>
346
347         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
348         <https://webkit.org/b/194178>
349         <rdar://problem/47753473>
350
351         Reviewed by Alexey Proskuryakov.
352
353         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
354         (WTR::uninstallFakeHelvetica): Pass nullptr into
355         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
356
357 2019-02-02  Zalan Bujtas  <zalan@apple.com>
358
359         [LFC] Initialize ICB's style with fixed width/height.
360         https://bugs.webkit.org/show_bug.cgi?id=194188
361
362         Reviewed by Antti Koivisto.
363
364         * LayoutReloaded/misc/LFC-passing-tests.txt:
365
366 2019-02-02  Zalan Bujtas  <zalan@apple.com>
367
368         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
369         https://bugs.webkit.org/show_bug.cgi?id=194185
370
371         Reviewed by Antti Koivisto.
372
373         * LayoutReloaded/misc/LFC-passing-tests.txt:
374
375 2018-12-16  Darin Adler  <darin@apple.com>
376
377         Convert additional String::format clients to alternative approaches
378         https://bugs.webkit.org/show_bug.cgi?id=192746
379
380         Reviewed by Alexey Proskuryakov.
381
382         * WebKitTestRunner/TestController.cpp:
383         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
384         as an intermediate in code that ultimately constructs a WTF::String.
385         (WTR::userMediaOriginHash): Use makeString.
386         (WTR::TestController::didNavigateWithNavigationData): More of the same.
387         (WTR::TestController::didPerformClientRedirect): Ditto.
388         (WTR::TestController::didPerformServerRedirect): Ditto.
389         (WTR::TestController::didUpdateHistoryTitle): Ditto.
390
391 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
392
393         [ews-build] Add unit test to verify builder keys
394         https://bugs.webkit.org/show_bug.cgi?id=194152
395
396         Reviewed by Lucas Forschler.
397
398         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
399         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
400
401 2019-02-01  Zalan Bujtas  <zalan@apple.com>
402
403         [LFC] Expand tests coverage (12 new tests -> 787)
404
405         Unreviewed test gardening.
406
407         * LayoutReloaded/misc/LFC-passing-tests.txt:
408
409 2019-02-01  Zalan Bujtas  <zalan@apple.com>
410
411         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
412         https://bugs.webkit.org/show_bug.cgi?id=194163
413
414         Reviewed by Simon Fraser.
415
416         775
417
418         * LayoutReloaded/misc/LFC-passing-tests.txt:
419
420 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
421
422         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
423         https://bugs.webkit.org/show_bug.cgi?id=194140
424         <rdar://problem/47728098>
425
426         Reviewed by Tim Horton.
427
428         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
429         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
430         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
431
432         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
433         test to induce an IPC deadlock when presenting a modal alert during touch start.
434
435         * WebKitTestRunner/InjectedBundle/TestRunner.h:
436         * WebKitTestRunner/TestController.cpp:
437         (WTR::runJavaScriptAlert):
438
439         Add a client callback function for running JavaScript alerts.
440
441         (WTR::TestController::createOtherPage):
442         (WTR::TestController::generateContextConfiguration const):
443
444         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
445         the fix in this patch.
446
447         (WTR::TestController::createWebViewWithOptions):
448
449         Plumb TestOptions to generateContextConfiguration.
450
451         (WTR::TestController::resetPreferencesToConsistentValues):
452         (WTR::TestController::resetStateToConsistentValues):
453         (WTR::updateTestOptionsFromTestHeader):
454         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
455         (WTR::TestController::handleJavaScriptAlert):
456         * WebKitTestRunner/TestController.h:
457         * WebKitTestRunner/TestInvocation.cpp:
458         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
459         * WebKitTestRunner/TestOptions.h:
460         (WTR::TestOptions::hasSameInitializationOptions const):
461
462 2019-02-01  Chris Dumez  <cdumez@apple.com>
463
464         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
465         https://bugs.webkit.org/show_bug.cgi?id=193740
466         <rdar://problem/47527267>
467
468         Reviewed by Alex Christensen.
469
470         Add API test coverage.
471
472         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
473
474 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
475
476         [ews-app] Add display name field to BuilderMapping model
477         https://bugs.webkit.org/show_bug.cgi?id=194153
478
479         Reviewed by Lucas Forschler.
480
481         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
482         (BuilderMapping):
483
484 2019-02-01  Youenn Fablet  <youenn@apple.com>
485
486         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
487         https://bugs.webkit.org/show_bug.cgi?id=194155
488
489         Reviewed by Eric Carlson.
490
491         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
492         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
493         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
494
495 2019-02-01  Zalan Bujtas  <zalan@apple.com>
496
497         [LFC] Adjust replaced element's intrinsic ratio
498         https://bugs.webkit.org/show_bug.cgi?id=194154
499
500         Reviewed by Antti Koivisto.
501
502         761
503
504         * LayoutReloaded/misc/LFC-passing-tests.txt:
505
506 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
507
508         [WPE] Show test results in minibrowser
509         https://bugs.webkit.org/show_bug.cgi?id=194150
510
511         Reviewed by Žan Doberšek.
512
513         * Scripts/webkitpy/port/wpe.py:
514         (WPEPort.show_results_html_file):
515
516 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
517
518         [WPE] MiniBrowser: add ky bindings for back/forward navigation
519         https://bugs.webkit.org/show_bug.cgi?id=194151
520
521         Reviewed by Žan Doberšek.
522
523         ALT + <- go back
524         ALT + -> go forward
525
526         * MiniBrowser/wpe/main.cpp:
527         (main):
528
529 2019-02-01  Zalan Bujtas  <zalan@apple.com>
530
531         [LFC] Set intrinsic size on Layout::Replaced
532         https://bugs.webkit.org/show_bug.cgi?id=194139
533
534         Reviewed by Antti Koivisto.
535
536         744
537
538         * LayoutReloaded/misc/LFC-passing-tests.txt:
539
540 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
541
542         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
543         https://bugs.webkit.org/show_bug.cgi?id=194146
544
545         Reviewed by Xabier Rodriguez-Calvar.
546
547         It allows to open relative paths.
548
549         * MiniBrowser/wpe/main.cpp:
550         (main):
551
552 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
553
554         Update flakiness dashboard configuration after recent queue changes
555         https://bugs.webkit.org/show_bug.cgi?id=194127
556
557         Rubber-stamped by Aakash Jain.
558
559         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
560
561         * TestResultServer/static-dashboards/builders.jsonp:
562
563 2019-01-31  Youenn Fablet  <youenn@apple.com>
564
565         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
566         https://bugs.webkit.org/show_bug.cgi?id=194106
567         <rdar://problem/47676333>
568
569         Reviewed by Ryosuke Niwa.
570
571         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
572         (TestWebKitAPI::didFinishNavigation):
573         (TestWebKitAPI::TEST):
574         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
575
576 2019-01-31  Chris Dumez  <cdumez@apple.com>
577
578         Page zoom level is lost after a process swap or a crash
579         https://bugs.webkit.org/show_bug.cgi?id=194105
580         <rdar://problem/47610781>
581
582         Reviewed by Alex Christensen.
583
584         Add API test coverage.
585
586         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
587         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
588
589 2019-01-31  Alex Christensen  <achristensen@webkit.org>
590
591         Revert r238819 which is unneeded and caused a performance regression.
592         https://bugs.webkit.org/show_bug.cgi?id=192272
593         <rdar://problem/46664625>
594
595         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
596         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
597         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
598
599 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
600
601         Formalize WebKitAdditions mechanism of LoadOptimizer
602         https://bugs.webkit.org/show_bug.cgi?id=193886
603         <rdar://problem/47696809>
604
605         Reviewed by Brent Fulgham.
606
607         * MiniBrowser/MiniBrowser.entitlements:
608         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
609
610 2019-01-31  Zalan Bujtas  <zalan@apple.com>
611
612         [LFC] Margin before/after/start/end initial value is 0 and not auto.
613         https://bugs.webkit.org/show_bug.cgi?id=194090
614
615         Reviewed by Antti Koivisto.
616
617         * LayoutReloaded/misc/LFC-passing-tests.txt:
618
619 2019-01-31  Zalan Bujtas  <zalan@apple.com>
620
621         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
622         https://bugs.webkit.org/show_bug.cgi?id=194074
623
624         Reviewed by Antti Koivisto.
625
626         * LayoutReloaded/misc/LFC-passing-tests.txt:
627
628 2019-01-31  Zalan Bujtas  <zalan@apple.com>
629
630         [LFC][BFC] Add support for block level replaced box.
631         https://bugs.webkit.org/show_bug.cgi?id=194071
632
633         Reviewed by Antti Koivisto.
634
635         * LayoutReloaded/misc/LFC-passing-tests.txt:
636
637 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
638
639         Fix WebKitTestRunner's testPath with Windows full paths
640         https://bugs.webkit.org/show_bug.cgi?id=194012
641
642         Reviewed by Alex Christensen.
643
644         updateTestOptionsFromTestHeader failed to open test files because
645         testPath returned wrong file paths. It returned a path "/C:/..."
646         if a URL "file:///C:/..." was given.
647
648         * WebKitTestRunner/TestController.cpp:
649         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
650
651 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
652
653         [WPE] Bump font related dependencies to match the GTK+ port
654         https://bugs.webkit.org/show_bug.cgi?id=194017
655
656         Reviewed by Žan Doberšek.
657
658         * wpe/jhbuild.modules:
659         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
660         * wpe/patches/icudata-stdlibs.patch: Added.
661
662 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
663
664         Enable swipe tests on iOS
665         https://bugs.webkit.org/show_bug.cgi?id=194076
666
667         Reviewed by Geoffrey Garen.
668
669         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
670         it causes a debug assertion failure in runUIScript.
671
672         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
673         (WTR::UIScriptController::beginBackSwipe):
674         (WTR::UIScriptController::completeBackSwipe):
675
676 2019-01-30  Keith Rollin  <krollin@apple.com>
677
678         Use correct printf format specifier
679         https://bugs.webkit.org/show_bug.cgi?id=194062
680         <rdar://problem/47686167>
681
682         Reviewed by Alexey Proskuryakov.
683
684         LayoutTestSpellChecker.mm is trying to format a variable of type
685         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
686         actually an unsigned long long. Fix this by formatting with %llu.
687
688         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
689         (-[LayoutTestTextCheckingResult description]):
690
691 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
692
693         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
694         https://bugs.webkit.org/show_bug.cgi?id=193979
695
696         Reviewed by Wenson Hsieh.
697
698         Fix the test for iOS. Make the test work with iOS UA string.
699
700         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
701
702 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
703
704         Replace High Sierra LLINT CLoop bot due to hardware failure
705         https://bugs.webkit.org/show_bug.cgi?id=194066
706
707         Reviewed by Aakash Jain.
708
709         * BuildSlaveSupport/build.webkit.org-config/config.json:
710
711 2019-01-30  Keith Rollin  <krollin@apple.com>
712
713         [NSDragItem init] is unavailable
714         https://bugs.webkit.org/show_bug.cgi?id=194059
715         <rdar://problem/47685715>
716
717         Reviewed by Wenson Hsieh.
718
719         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
720         DumpRenderTree and TestWebKitAPI, which both try to create an
721         NSDragItem in a manner that invokes this method. Address this by using
722         -initWithPasteboardWriter instead.
723
724         Note that the parameter passed to initWithPasteboardWriter is likely
725         incorrect. In both cases, the object passed does not conform to
726         NSPasteboardWriting. However, with this fix, we're no worse off than
727         before, and can now perform builds with newer compilers and SDKs until
728         a real fix can be crafted. That work is tracked in
729         https://bugs.webkit.org/show_bug.cgi?id=194060
730
731         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
732         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
733         * TestWebKitAPI/mac/TestDraggingInfo.mm:
734         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
735
736 2019-01-30  Daniel Bates  <dabates@apple.com>
737
738         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
739         https://bugs.webkit.org/show_bug.cgi?id=192824
740         <rdar://problem/47100332>
741
742         Reviewed by Wenson Hsieh.
743
744         Fix a bug where the wrong usage code was used for F13 thru F24.
745
746         * WebKitTestRunner/ios/HIDEventGenerator.mm:
747         (keyCodeForDOMFunctionKey):
748
749 2019-01-30  Chris Dumez  <cdumez@apple.com>
750
751         Regression(PSON) Load hang can occur on history navigation
752         https://bugs.webkit.org/show_bug.cgi?id=194030
753         <rdar://problem/47656939>
754
755         Reviewed by Antti Koivisto.
756
757         Add API test coverage.
758
759         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
760
761 2019-01-30  Zalan Bujtas  <zalan@apple.com>
762
763         [LFC] Expand tests coverage.
764
765         Unreviewed test gardening.
766
767         * LayoutReloaded/misc/LFC-passing-tests.txt:
768
769 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
770
771         [Flatpak] Add openjpeg support
772         https://bugs.webkit.org/show_bug.cgi?id=194019
773
774         Reviewed by Michael Catanzaro.
775
776         * flatpak/org.webkit.CommonModules.yaml:
777
778 2019-01-30  Commit Queue  <commit-queue@webkit.org>
779
780         Unreviewed, rolling out r240708.
781         https://bugs.webkit.org/show_bug.cgi?id=194022
782
783         It broke WPE build (Requested by KaL on #webkit).
784
785         Reverted changeset:
786
787         "[WPE] Bump font related dependencies to match the GTK+ port"
788         https://bugs.webkit.org/show_bug.cgi?id=194017
789         https://trac.webkit.org/changeset/240708
790
791 2019-01-30  Zalan Bujtas  <zalan@apple.com>
792
793         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
794         https://bugs.webkit.org/show_bug.cgi?id=194001
795
796         Reviewed by Antti Koivisto.
797
798         * LayoutReloaded/misc/LFC-passing-tests.txt:
799
800 2019-01-30  Zalan Bujtas  <zalan@apple.com>
801
802         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
803         https://bugs.webkit.org/show_bug.cgi?id=194020
804
805         Reviewed by Antti Koivisto.
806
807         * LayoutReloaded/misc/LFC-passing-tests.txt:
808
809 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
810
811         AX: Support color well on iOS
812         https://bugs.webkit.org/show_bug.cgi?id=194010
813
814         Reviewed by Joanmarie Diggs.
815
816         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
817         (WTR::AccessibilityUIElement::stringAttributeValue):
818
819 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
820
821         [WPE] Bump font related dependencies to match the GTK+ port
822         https://bugs.webkit.org/show_bug.cgi?id=194017
823
824         Reviewed by Žan Doberšek.
825
826         * wpe/jhbuild.modules:
827         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
828         * wpe/patches/icudata-stdlibs.patch: Added.
829
830 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
831
832         [Mac] Update window scale API usage
833         https://bugs.webkit.org/show_bug.cgi?id=193991
834         rdar://problem/47614795
835
836         Reviewed by Tim Horton.
837
838         * DumpRenderTree/mac/DumpRenderTree.mm:
839         (changeWindowScaleIfNeeded):
840         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
841         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
842         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
843
844 2019-01-29  Chris Dumez  <cdumez@apple.com>
845
846         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
847         https://bugs.webkit.org/show_bug.cgi?id=193977
848         <rdar://problem/47643716>
849
850         Reviewed by Geoff Garen.
851
852         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
853         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
854         to the previous provisional committing *before* we make the last load. 
855
856         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
857
858 2019-01-29  Youenn Fablet  <youenn@apple.com>
859
860         Adopt new SPI to evaluate server certificate trust
861         https://bugs.webkit.org/show_bug.cgi?id=193355
862
863         Reviewed by Alex Christensen.
864
865         Add infrastructure to handle HTTPS server trust evaluation testing.
866
867         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
868         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
869         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
870         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
871         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
872         * WebKitTestRunner/InjectedBundle/TestRunner.h:
873         * WebKitTestRunner/TestController.cpp:
874         (WTR::TestController::resetPreferencesToConsistentValues):
875         (WTR::TestController::didReceiveAuthenticationChallenge):
876         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
877         * WebKitTestRunner/TestController.h:
878         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
879         * WebKitTestRunner/TestInvocation.cpp:
880         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
881         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
882         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
883
884 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
885
886         [ews-build] Add build step to print bot Configuration
887         https://bugs.webkit.org/show_bug.cgi?id=193887
888
889         Reviewed by Lucas Forschler.
890
891         * BuildSlaveSupport/ews-build/steps.py:
892         (PrintConfiguration): Build step to print configuration.
893         * BuildSlaveSupport/ews-build/factories.py:
894
895 2019-01-29  Chris Dumez  <cdumez@apple.com>
896
897         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
898         https://bugs.webkit.org/show_bug.cgi?id=193967
899         <rdar://problem/47635348>
900
901         Reviewed by Alex Christensen.
902
903         Add API test coverage.
904
905         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
906         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
907
908 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
909
910         [ews-app] Handle incoming results data
911         https://bugs.webkit.org/show_bug.cgi?id=193973
912
913         Reviewed by Lucas Forschler.
914
915         * BuildSlaveSupport/ews-app/ews/views/results.py:
916
917 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
918
919         [ews-app] Make the results url generic
920         https://bugs.webkit.org/show_bug.cgi?id=193928
921
922         Reviewed by Lucas Forschler.
923
924         * BuildSlaveSupport/ews-app/ews/urls.py:
925
926 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
927
928         [ews-build] Configure buildbot to send events to ews-app
929         https://bugs.webkit.org/show_bug.cgi?id=193968
930
931         Reviewed by Lucas Forschler.
932
933         * BuildSlaveSupport/ews-build/events.py: Added.
934         * BuildSlaveSupport/ews-build/master.cfg:
935
936 2019-01-29  Keith Rollin  <krollin@apple.com>
937
938         Add .xcfilelists to Run Script build phases
939         https://bugs.webkit.org/show_bug.cgi?id=193792
940         <rdar://problem/47201785>
941
942         Reviewed by Alex Christensen.
943
944         As part of supporting XCBuild, update the necessary Run Script build
945         phases in their Xcode projects to refer to their associated
946         .xcfilelist files.
947
948         Note that the addition of these files bumps the Xcode project version
949         number to something that's Xcode 10 compatible. This change means that
950         older versions of the Xcode IDE can't read these projects. Nor can it
951         fully load workspaces that refer to these projects (the updated
952         projects are shown as non-expandable placeholders). `xcodebuild` can
953         still build these projects; it's just that the IDE can't open them.
954
955         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
956         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
957
958 2019-01-29  John Wilander  <wilander@apple.com>
959
960         Add data abstraction and validation for Ad Click Attribution
961         https://bugs.webkit.org/show_bug.cgi?id=193916
962         <rdar://problem/47603481>
963
964         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
965
966         Ad click attribution has two steps. First, the storage of an ad
967         campaign ID for a click that takes the user to a destination
968         site. Second, a conversion on the destination site that can be
969         attributed to the ad click.
970
971         This patch adds a class that represents a request for ad click
972         attribution. Validation makes sure that the bits of entropy
973         reported through this mechanism is limited.
974
975         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
976         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
977         (TestWebKitAPI::TEST):
978
979 2019-01-29  Chris Dumez  <cdumez@apple.com>
980
981         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
982         https://bugs.webkit.org/show_bug.cgi?id=193932
983         <rdar://problem/47598947>
984
985         Reviewed by Brady Eidson.
986
987         Add API test coverage.
988
989         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
990
991 2019-01-29  Zalan Bujtas  <zalan@apple.com>
992
993         Adding new passing LFC tests.
994
995         Unreviewed test gardening.
996
997         * LayoutReloaded/misc/LFC-passing-tests.txt:
998
999 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1000
1001         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1002         https://bugs.webkit.org/show_bug.cgi?id=193964
1003
1004         Reviewed by Antti Koivisto.
1005
1006         * LayoutReloaded/misc/LFC-passing-tests.txt:
1007
1008 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1009
1010         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1011         https://bugs.webkit.org/show_bug.cgi?id=193954
1012
1013         Reviewed by Antti Koivisto.
1014
1015         * LayoutReloaded/misc/LFC-passing-tests.txt:
1016
1017 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1018
1019         WebDriver: add support for running subtests
1020         https://bugs.webkit.org/show_bug.cgi?id=193904
1021
1022         Reviewed by Michael Catanzaro.
1023
1024         pytest already supports it by passing test.py::subtest, so we can do the same.
1025
1026         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1027         (get_item_name): Made this global.
1028         (CollectRecorder.__init__): Receive the parameter to ignore.
1029         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1030         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1031         (collect): Add parameter to ignore.
1032         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1033         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1034         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1035         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1036         (WebDriverTestRunnerSelenium.run): Ditto.
1037         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1038         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1039         (WebDriverTestRunnerW3C.run): Ditto.
1040
1041 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1042
1043         User agent string override for navigator.userAgent should be site specific quirks
1044         https://bugs.webkit.org/show_bug.cgi?id=193950
1045
1046         Reviewed by Brent Fulgham.
1047
1048         Updated per the _WKWebsitePolicies rename.
1049
1050         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1051         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1052
1053 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1054
1055         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1056         https://bugs.webkit.org/show_bug.cgi?id=193941
1057
1058         Reviewed by Alex Christensen.
1059
1060         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1061         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1062         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1063         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1064         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1065         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1066         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1067         * TestWebKitAPI/Tests/WTF/Time.cpp:
1068         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1069         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1070         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1071         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1072
1073 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1074
1075         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1076
1077         * Scripts/webkitpy/common/config/contributors.json:
1078
1079 2019-01-28  Andy Estes  <aestes@apple.com>
1080
1081         [watchOS] Enable Parental Controls content filtering
1082         https://bugs.webkit.org/show_bug.cgi?id=193939
1083         <rdar://problem/46641912>
1084
1085         Reviewed by Ryosuke Niwa.
1086
1087         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1088
1089 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1090
1091         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1092         <https://webkit.org/b/193884>
1093
1094         Reviewed by Jiewen Tan.
1095
1096         * Scripts/webkitpy/style/checkers/cpp.py:
1097         (check_language): Add LocalAuthentication to
1098         `frameworks_with_soft_links`.
1099
1100 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1101
1102         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1103         https://bugs.webkit.org/show_bug.cgi?id=193891
1104
1105         Reviewed by Ross Kirsling.
1106
1107         There were three problems in window sizes of WebView and the host window.
1108         1. The sizes of pixel image output were incorrect.
1109         2. The host window is going to appear after window.resize was invoked.
1110         3. window.resize resized only the host window, not WebView.
1111
1112         This change solves them with a following approach.
1113         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1114         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1115            as well as DumpRenderTree in order to match the client area and the window area.
1116         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1117         d. PlatformWebView::setWindowFrame changes both window sizes.
1118         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1119
1120         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1121         (WTR::PlatformWebView::PlatformWebView): Create the host window
1122         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1123         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1124         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1125
1126 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1127
1128         [ews-app] Add method to save Step data to database
1129         https://bugs.webkit.org/show_bug.cgi?id=193890
1130
1131         Reviewed by Lucas Forschler.
1132
1133         * BuildSlaveSupport/ews-app/ews/models/step.py:
1134         (Step.save_step): Method to save step data.
1135         (Step.update_step): Method to update step data.
1136         (Step.get_existing_step): Method to fetch existing step from database.
1137         (Step.is_valid_result): Method to validate valid step result.
1138
1139 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1140
1141         [ews-app] Add method to save Build data to database
1142         https://bugs.webkit.org/show_bug.cgi?id=193735
1143
1144         Reviewed by Lucas Forschler.
1145
1146         * BuildSlaveSupport/ews-app/ews/models/build.py:
1147         (Build.save_build): Method to save build information to database.
1148         (Build.get_existing_build): Method to fetch existing build from database.
1149         (Build.is_valid_result): Method to validate build result.
1150         * BuildSlaveSupport/ews-app/ews/common/util.py:
1151         (is_valid_int_id): Method to validate valid id.
1152
1153 2019-01-28  Chris Dumez  <cdumez@apple.com>
1154
1155         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1156         https://bugs.webkit.org/show_bug.cgi?id=193915
1157         <rdar://problem/47560907>
1158
1159         Reviewed by Alex Christensen.
1160
1161         Add API test coverage.
1162
1163         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1164
1165 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1166
1167         [ews-app] Rename id variables
1168         https://bugs.webkit.org/show_bug.cgi?id=193883
1169
1170         Reviewed by Lucas Forschler.
1171
1172         * BuildSlaveSupport/ews-app/ews/models/build.py:
1173         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1174         * BuildSlaveSupport/ews-app/ews/models/step.py:
1175         * BuildSlaveSupport/ews-app/ews/urls.py:
1176         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1177         * BuildSlaveSupport/ews-app/ews/views/results.py:
1178         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1179
1180 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1181
1182         [ews-app] Allow certain fields to be empty
1183         https://bugs.webkit.org/show_bug.cgi?id=193892
1184
1185         Reviewed by Lucas Forschler.
1186
1187         * BuildSlaveSupport/ews-app/ews/models/build.py:
1188         * BuildSlaveSupport/ews-app/ews/models/step.py:
1189
1190 2019-01-28  Rob Buis  <rbuis@igalia.com>
1191
1192         Update MIME type parser
1193         https://bugs.webkit.org/show_bug.cgi?id=180526
1194
1195         Reviewed by Frédéric Wang.
1196
1197         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1198         (TestWebKitAPI::TEST):
1199
1200 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1201
1202         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1203         https://bugs.webkit.org/show_bug.cgi?id=193896
1204
1205         Reviewed by Antti Koivisto.
1206
1207         * LayoutReloaded/misc/LFC-passing-tests.txt:
1208
1209 2018-12-15  Darin Adler  <darin@apple.com>
1210
1211         Replace many uses of String::format with more type-safe alternatives
1212         https://bugs.webkit.org/show_bug.cgi?id=192742
1213
1214         Reviewed by Mark Lam.
1215
1216         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1217         (WTR::cacheTestRunnerCallback): Use makeString.
1218         * WebKitTestRunner/TestController.cpp:
1219         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1220         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1221
1222 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1223
1224         Use a load optimizer for some sites
1225         https://bugs.webkit.org/show_bug.cgi?id=193881
1226         <rdar://problem/46325455>
1227
1228         Reviewed by Brent Fulgham.
1229
1230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1231         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1232
1233 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1234
1235         AX: Introduce a static accessibility tree
1236         https://bugs.webkit.org/show_bug.cgi?id=193348
1237         <rdar://problem/47203295>
1238
1239         Reviewed by Ryosuke Niwa.
1240
1241         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1242
1243 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1244
1245         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1246         https://bugs.webkit.org/show_bug.cgi?id=193867
1247
1248         Reviewed by Antti Koivisto.
1249
1250         * LayoutReloaded/misc/LFC-passing-tests.txt:
1251
1252 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1253
1254         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1255         https://bugs.webkit.org/show_bug.cgi?id=193865
1256
1257         Reviewed by Antti Koivisto.
1258
1259         * LayoutReloaded/misc/LFC-passing-tests.txt:
1260
1261 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1262
1263         Need a mechanism to override navigator.userAgent
1264         https://bugs.webkit.org/show_bug.cgi?id=193762
1265         <rdar://problem/47504939>
1266
1267         Reviewed by Brent Fulgham.
1268
1269         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1270
1271         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1272         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1273         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1274
1275 2019-01-25  Dean Jackson  <dino@apple.com>
1276
1277         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1278         https://bugs.webkit.org/show_bug.cgi?id=193831
1279         <rdar://problem/47399263>
1280
1281         Reviewed by Chris Dumez.
1282
1283         Two new tests that exercise cross-origin and same-origin System
1284         Previews.
1285
1286         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1287
1288 2019-01-25  Keith Rollin  <krollin@apple.com>
1289
1290         Update Xcode projects with "Check .xcfilelists" build phase
1291         https://bugs.webkit.org/show_bug.cgi?id=193790
1292         <rdar://problem/47201374>
1293
1294         Reviewed by Alex Christensen.
1295
1296         Support for XCBuild includes specifying inputs and outputs to various
1297         Run Script build phases. These inputs and outputs are specified as
1298         .xcfilelist files. Once created, these .xcfilelist files need to be
1299         kept up-to-date. In order to check that they are up-to-date or not,
1300         add an Xcode build step that invokes an external script that performs
1301         the checking. If the .xcfilelists are found to be out-of-date, update
1302         them, halt the build, and instruct the developer to restart the build
1303         with up-to-date files.
1304
1305         At this time, the checking and regenerating is performed only if the
1306         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1307         who want to use this facility can set this variable and test out the
1308         checking/regenerating. Once it seems like there are no egregious
1309         issues that upset a developer's workflow, we'll unconditionally enable
1310         this facility.
1311
1312         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1313         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1314         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1315         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1316
1317 2019-01-25  Keith Rollin  <krollin@apple.com>
1318
1319         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1320         https://bugs.webkit.org/show_bug.cgi?id=193781
1321         <rdar://problem/47201153>
1322
1323         Reviewed by Alex Christensen.
1324
1325         Part of generating the .xcfilelists used as part of adopting XCBuild
1326         includes running `make DerivedSources.make` from a standalone script.
1327         It’s important for this invocation to have the same environment as
1328         when the actual build invokes `make DerivedSources.make`. If the
1329         environments are different, then the two invocations will provide
1330         different results. In order to get the same environment in the
1331         standalone script, have the script launch xcodebuild targeting the
1332         "Apply Configuration to XCFileLists" build target, which will then
1333         re-invoke our standalone script. The script is now running again, this
1334         time in an environment with all workspace, project, target, xcconfig
1335         and other environment variables established.
1336
1337         The "Apply Configuration to XCFileLists" build target accomplishes
1338         this task via a small embedded shell script that consists only of:
1339
1340             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1341
1342         The process that invokes "Apply Configuration to XCFileLists" first
1343         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1344         evaluated and exports it into the shell environment. When xcodebuild
1345         is invoked, it inherits the value of this variable and can `eval` the
1346         contents of that variable. Our external standalone script can then set
1347         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1348         of command-line parameters needed to restart itself in the appropriate
1349         state.
1350
1351         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1352         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1353
1354 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1355
1356         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1357         https://bugs.webkit.org/show_bug.cgi?id=193802
1358         <rdar://problem/46010580>
1359
1360         Reviewed by Andy Estes.
1361
1362         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1363         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1364         (TEST):
1365
1366 2019-01-25  Daniel Bates  <dabates@apple.com>
1367
1368         [iOS] uiController.keyDown() does not translate Control modified key
1369         https://bugs.webkit.org/show_bug.cgi?id=192898
1370
1371         Reviewed by Wenson Hsieh.
1372
1373         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1374         key translation, as applicable. Among other cases, key translation occurs when performing
1375         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1376         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1377         human pressing down and releasing key(s) using a hardware keyboard.
1378
1379         * WebKitTestRunner/ios/HIDEventGenerator.h:
1380         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1381         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1382
1383         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1384         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1385         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1386         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1387         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1388         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1389         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1390         (-[HIDEventGenerator longPress:completionBlock:]):
1391         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1392         Update code for above renaming.
1393
1394         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1395         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1396
1397         (-[HIDEventGenerator keyDown:]): Added.
1398         (-[HIDEventGenerator keyUp:]): Added.
1399         (-[HIDEventGenerator keyPress:completionBlock:]):
1400         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1401         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1402         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1403         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1404         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1405         (WTR::parseModifier): Deleted.
1406
1407 2019-01-25  Keith Rollin  <krollin@apple.com>
1408
1409         Complete the implementation of generate-xcfilelists
1410         https://bugs.webkit.org/show_bug.cgi?id=193782
1411
1412         Reviewed by Alex Christensen.
1413
1414         A preliminary version of generate-xcfilelists was added in r238008.
1415         This patch updates that script in order to:
1416
1417         - Support checking of .xcfilelists
1418         - Perform better execution of `make DerivedSources.make` by
1419           relaunching generate-xcfilelists under xcodebuild
1420         - Support incremental generation and checking of .xcfilelists
1421         - Support supplementary .xcfilelists files from WebKitAdditions
1422         - Support being wrapped by parallel version of generate-xcfilelists in
1423           Internal that adds support for (re)generating WebKit projects in
1424           that repo.
1425         - Support builds that have been performed in WebKitBuild as well as
1426           ~/Library/Developer/code/DerivedData
1427         - Increase robustness and debugging facilities.
1428
1429         * Scripts/generate-xcfilelists:
1430
1431 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1432
1433         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1434         https://bugs.webkit.org/show_bug.cgi?id=193297
1435         <rdar://problem/47158841>
1436
1437         Unreviewed test case fix.
1438
1439         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1440         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1441
1442         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1443         (TEST):
1444
1445 2019-01-25  Keith Rollin  <krollin@apple.com>
1446
1447         Update existing .xcfilelists
1448         https://bugs.webkit.org/show_bug.cgi?id=193791
1449         <rdar://problem/47201706>
1450
1451         Reviewed by Alex Christensen.
1452
1453         Many .xcfilelist files were added in r238824 in order to support
1454         XCBuild. Update these with recent changes to the set of build files
1455         and with the current generate-xcfilelist script.
1456
1457         * DumpRenderTree/DerivedSources-input.xcfilelist:
1458         * DumpRenderTree/DerivedSources-output.xcfilelist:
1459         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1460         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1461
1462 2019-01-25  Keith Rollin  <krollin@apple.com>
1463
1464         Fix missing dependencies in extract-dependencies-from-makefile
1465         https://bugs.webkit.org/show_bug.cgi?id=193783
1466         <rdar://problem/47201571>
1467
1468         Reviewed by Alex Christensen.
1469
1470         The extract-dependencies-from-makefile script generates .xcfilelists
1471         for XCBuild by invoking a makefile in --debug mode, parsing the
1472         dependency information in the output, and extracting information
1473         regarding targets and dependents. However, the way `make` emits this
1474         dependency information is not rigorous, and so we need to determine
1475         what lines to look for and parse by trial and error. This approach
1476         didn't coriginally atch all the information we needed to collect, so
1477         update the script to look for the additional lines we now know to look
1478         for.
1479
1480         * Scripts/extract-dependencies-from-makefile:
1481         (Parser):
1482         (Parser.addTarget):
1483         (Parser.addPrereq):
1484         (Parser.doParse):
1485
1486 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1487
1488         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1489         https://bugs.webkit.org/show_bug.cgi?id=193297
1490         <rdar://problem/47158841>
1491
1492         Reviewed by Alex Christensen.
1493
1494         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1495             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1496         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1497         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1498         activating the message used to trigger the callback when it is set.
1499
1500 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1501
1502         WKWebView.goBack should reload if there is a safe browsing warning
1503         https://bugs.webkit.org/show_bug.cgi?id=193805
1504         <rdar://problem/46908216>
1505
1506         Reviewed by Geoff Garen.
1507
1508         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1509         (+[Simple3LookupContext sharedLookupContext]):
1510         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1511         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1512         (TEST):
1513
1514 2019-01-25  Chris Dumez  <cdumez@apple.com>
1515
1516         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1517         https://bugs.webkit.org/show_bug.cgi?id=193788
1518         <rdar://problem/47531231>
1519
1520         Reviewed by Alex Christensen.
1521
1522         Add API test coverage.
1523
1524         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1525         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1526
1527 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1528
1529         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1530         https://bugs.webkit.org/show_bug.cgi?id=193771
1531
1532         Unreviewed infrastructure fix.
1533
1534         * Scripts/webkitpy/port/darwin.py:
1535         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1536
1537 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1538
1539         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1540
1541 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1542
1543         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1544
1545         * Scripts/webkitpy/common/config/contributors.json:
1546
1547 2019-01-25  Chris Dumez  <cdumez@apple.com>
1548
1549         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1550         https://bugs.webkit.org/show_bug.cgi?id=193779
1551         <rdar://problem/46170903>
1552
1553         Reviewed by Antti Koivisto.
1554
1555         Add API test that quickly navigates forward to a previous process without waiting for it to
1556         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1557         the process' previous page when reconnecting the it for the forward navigation.
1558
1559         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1560
1561 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1562
1563         Need a way for JavaScript (or bundle) code to participate in undo
1564         https://bugs.webkit.org/show_bug.cgi?id=190009
1565         <rdar://problem/44807048>
1566
1567         Reviewed by Ryosuke Niwa.
1568
1569         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1570         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1571
1572         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1573         (WTR::UIScriptController::lastUndoLabel const):
1574         (WTR::UIScriptController::firstRedoLabel const):
1575         (WTR::UIScriptController::platformUndoManager const):
1576         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1577         (WTR::UIScriptController::lastUndoLabel const):
1578         (WTR::UIScriptController::firstRedoLabel const):
1579         (WTR::UIScriptController::platformUndoManager const):
1580         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1581         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1582         (WTR::UIScriptController::lastUndoLabel const):
1583         (WTR::UIScriptController::firstRedoLabel const):
1584         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1585         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1586         (WTR::UIScriptController::lastUndoLabel const):
1587         (WTR::UIScriptController::firstRedoLabel const):
1588         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1589         (WTR::UIScriptController::platformUndoManager const):
1590         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1591         (WTR::UIScriptController::platformUndoManager const):
1592
1593 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1594
1595         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1596         https://bugs.webkit.org/show_bug.cgi?id=193824
1597
1598         Reviewed by Antti Koivisto.
1599
1600         * LayoutReloaded/misc/LFC-passing-tests.txt:
1601
1602 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1603
1604         Update macOS JSC bot configurations
1605         https://bugs.webkit.org/show_bug.cgi?id=193739
1606
1607         Reviewed by Alexey Proskuryakov.
1608
1609         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1610         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1611         (BubbleQueueServer): Move JSC EWS to Mojave section.
1612         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1613         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1614         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1615
1616 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1617
1618         [Win][WebKitTestRunner] Implement EventSenderProxy
1619         https://bugs.webkit.org/show_bug.cgi?id=193755
1620
1621         Reviewed by Don Olmstead.
1622
1623         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1624         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1625         (WTR::EventSenderProxy::dispatchMessage):
1626         (WTR::EventSenderProxy::EventSenderProxy):
1627         (WTR::EventSenderProxy::mouseDown):
1628         (WTR::EventSenderProxy::mouseUp):
1629         (WTR::EventSenderProxy::mouseMoveTo):
1630         (WTR::EventSenderProxy::mouseScrollBy):
1631         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1632
1633 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1634
1635         Unreviewed fix for API test failure after r240437.
1636
1637         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1638
1639         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1640
1641 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1642
1643         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1644         https://bugs.webkit.org/show_bug.cgi?id=193787
1645         <rdar://problem/47497634>
1646
1647         Reviewed by Alexey Proskuryakov.
1648
1649         * Scripts/webkitdirs.pm:
1650         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1651
1652 2019-01-24  Truitt Savell  <tsavell@apple.com>
1653
1654         Unreviewed, rolling out r240446.
1655
1656         Casued 5 API failures
1657
1658         Reverted changeset:
1659
1660         "Activate the WebResourceLoadStatisticsStore in the
1661         NetworkProcess and deactivate it in the UIProcess."
1662         https://bugs.webkit.org/show_bug.cgi?id=193297
1663         https://trac.webkit.org/changeset/240446
1664
1665 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1666
1667         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1668         https://bugs.webkit.org/show_bug.cgi?id=193741
1669         <rdar://problem/47135030>
1670
1671         Reviewed by Antti Koivisto and Simon Fraser.
1672
1673         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1674         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1675         (TestWebKitAPI::TEST):
1676
1677 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1678
1679         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1680         https://bugs.webkit.org/show_bug.cgi?id=193297
1681         <rdar://problem/47158841>
1682
1683         Reviewed by Alex Christensen.
1684
1685         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1686         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1687         activating the message used to trigger the callback when it is set.
1688
1689 2019-01-24  John Wilander  <wilander@apple.com>
1690
1691         Add Ad Click Attribution as an internal/experimental feature
1692         https://bugs.webkit.org/show_bug.cgi?id=193685
1693         <rdar://problem/47450399>
1694
1695         Reviewed by Brent Fulgham.
1696
1697         Added test option adClickAttributionEnabled.
1698
1699         * DumpRenderTree/TestOptions.cpp:
1700         (TestOptions::TestOptions):
1701         * DumpRenderTree/TestOptions.h:
1702         * DumpRenderTree/mac/DumpRenderTree.mm:
1703         (setWebPreferencesForTestOptions):
1704
1705 2019-01-24  Antti Koivisto  <antti@apple.com>
1706
1707         [PSON] Flash on back navigation on Mac
1708         https://bugs.webkit.org/show_bug.cgi?id=193716
1709         <rdar://problem/47148458>
1710
1711         Reviewed by Chris Dumez.
1712
1713         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1714
1715         Closing of the previous page is delayed so waiting for didFinishNavigation is
1716         not sufficient to guarantee we have received all the messages. Wait for them.
1717
1718 2019-01-24  Chris Dumez  <cdumez@apple.com>
1719
1720         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1721         https://bugs.webkit.org/show_bug.cgi?id=193761
1722         <rdar://problem/47456405>
1723
1724         Reviewed by Alex Christensen.
1725
1726         Add API test coverage.
1727
1728         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1729
1730 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1731
1732         webkitpy: Missing PID in crashlog name should not be fatal
1733         https://bugs.webkit.org/show_bug.cgi?id=193771
1734
1735         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1736         of raising an exception.
1737
1738         Reviewed by Lucas Forschler.
1739
1740         * Scripts/webkitpy/port/darwin.py:
1741         (DarwinPort._merge_crash_logs):
1742
1743 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1744
1745         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1746         https://bugs.webkit.org/show_bug.cgi?id=193746
1747
1748         Reviewed by Youenn Fablet.
1749
1750         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1751         so we'd best just not call it.
1752
1753         * Scripts/webkitpy/w3c/test_exporter.py:
1754         (WebPlatformTestExporter.create_branch_with_patch):
1755
1756 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1757
1758         Move FileSystem to WTF
1759         https://bugs.webkit.org/show_bug.cgi?id=193602
1760
1761         Reviewed by Yusuke Suzuki.
1762
1763         * DumpRenderTree/win/DumpRenderTree.cpp:
1764         * TestWebKitAPI/CMakeLists.txt:
1765         * TestWebKitAPI/PlatformGTK.cmake:
1766         * TestWebKitAPI/PlatformJSCOnly.cmake:
1767         * TestWebKitAPI/PlatformPlayStation.cmake:
1768         * TestWebKitAPI/PlatformWPE.cmake:
1769         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1770         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1771         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1772         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1773         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1774         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1775         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1776         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1777         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1778         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1779
1780 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1781
1782         [WPE] Remove hard dependency on subprocess32 for the API tests
1783
1784         Rubber-stamped by Carlos Garcia Campos.
1785
1786         * glib/api_test_runner.py:
1787         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1788         its presence only when running WPEQt tests.
1789
1790 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1791
1792         [GLIB] Expose JavaScriptCore options in GLib public API
1793         https://bugs.webkit.org/show_bug.cgi?id=188742
1794
1795         Reviewed by Michael Catanzaro.
1796
1797         Add a test for the new API.
1798
1799         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1800         (testsJSCOptions):
1801         (main):
1802
1803 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1804
1805         [GTK][WPE] Support JPEG 2000 images
1806         https://bugs.webkit.org/show_bug.cgi?id=186272
1807
1808         Reviewed by Žan Doberšek.
1809
1810         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
1811
1812         * gtk/jhbuild.modules:
1813         * wpe/jhbuild.modules:
1814
1815 2019-01-23  David Kilzer  <ddkilzer@apple.com>
1816
1817         check-webkit-style should warn when using soft-linking macros in a header
1818         <https://webkit.org/b/193750>
1819
1820         Reviewed by Darin Adler.
1821
1822         * Scripts/webkitpy/style/checkers/cpp.py:
1823         (check_language): Add softlink/header check by refactoring the
1824         softlink/framework check.
1825         (CppChecker): Enable softlink/header check by default.
1826         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1827         (CppStyleTest.test_softlink_framework): Rename from
1828         CppStyleTest.test_softlink() and change test framework name in
1829         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
1830         files. Set file_name for macros that only appear in headers.
1831         (CppStyleTest.test_softlink_header): Add tests for using
1832         soft-link macros in headers.
1833
1834 2019-01-23  Chris Dumez  <cdumez@apple.com>
1835
1836         Deprecate API to limit the maximum number of WebProcesses
1837         https://bugs.webkit.org/show_bug.cgi?id=193725
1838         <rdar://problem/47464879>
1839
1840         Reviewed by Geoff Garen.
1841
1842         Update existing API tests to stop using deprecated API.
1843
1844         * MiniBrowser/mac/AppDelegate.m:
1845         (defaultConfiguration):
1846         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1847         (TestWebKitAPI::TEST):
1848         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
1849         (TestWebKitAPI::TEST):
1850         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1851         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1852         (TEST):
1853         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1854         (TEST):
1855
1856 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1857
1858         [ews-app] Rename ews model buildermappings to buildermapping
1859         https://bugs.webkit.org/show_bug.cgi?id=193729
1860
1861         Reviewed by Lucas Forschler.
1862
1863         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
1864         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
1865         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
1866
1867 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1868
1869         [ews-app] Rename ews model steps to step
1870         https://bugs.webkit.org/show_bug.cgi?id=193697
1871
1872         Reviewed by Lucas Forschler.
1873
1874         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
1875         (Step): Renamed Steps to Step.
1876
1877 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
1878
1879         Clean up IndexedDB files between tests
1880         https://bugs.webkit.org/show_bug.cgi?id=192796
1881         <rdar://problem/46824999>
1882
1883         Reviewed by Geoffrey Garen.
1884
1885         * DumpRenderTree/mac/DumpRenderTree.mm:
1886         (runTest):
1887         * WebKitTestRunner/TestController.cpp:
1888         (WTR::TestController::resetStateToConsistentValues):
1889         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
1890         (WTR::RemoveAllIndexedDatabasesCallback):
1891         (WTR::TestController::ClearIndexedDatabases):
1892         * WebKitTestRunner/TestController.h:
1893         * WebKitTestRunner/TestInvocation.cpp:
1894         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1895
1896 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1897
1898         [ews-app] Rename ews model Builds to Build
1899         https://bugs.webkit.org/show_bug.cgi?id=193695
1900
1901         Reviewed by Lucas Forschler.
1902
1903         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
1904         (Build): Renamed Builds to Build.
1905
1906 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1907
1908         webkitpy: Wait longer when launching WebKitTestRunner
1909         https://bugs.webkit.org/show_bug.cgi?id=193734
1910
1911         Reviewed by Aakash Jain.
1912
1913         * Scripts/webkitpy/port/simulator_process.py:
1914         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
1915
1916 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1917
1918         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
1919         https://bugs.webkit.org/show_bug.cgi?id=193182
1920         <rdar://problem/47452154>
1921
1922         Reviewed by Tim Horton.
1923
1924         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
1925         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
1926         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
1927
1928         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
1929         preventing later tests from recognizing gestures.
1930
1931         * WebKitTestRunner/ios/TestControllerIOS.mm:
1932         (WTR::TestController::platformResetStateToConsistentValues):
1933
1934         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
1935
1936 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1937
1938         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
1939         https://bugs.webkit.org/show_bug.cgi?id=193722
1940         <rdar://problem/47481475>
1941
1942         Reviewed by Lucas Forschler.
1943
1944         iPhone and iPad ports should both use the iOS config.
1945
1946         * Scripts/webkitpy/port/ios_simulator.py:
1947         (IPhoneSimulatorPort.__init__):
1948         (IPadSimulatorPort.__init__):
1949
1950 2019-01-23  Rob Buis  <rbuis@igalia.com>
1951
1952         Update MIME type parser
1953         https://bugs.webkit.org/show_bug.cgi?id=180526
1954
1955         Reviewed by Frédéric Wang.
1956
1957         Add unit tests for both parse modes of ParsedContentType.
1958
1959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1960         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
1961         (TestWebKitAPI::TEST):
1962
1963 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1964
1965         [ews-app] fetch loop should not stop on network issues
1966         https://bugs.webkit.org/show_bug.cgi?id=193666
1967
1968         Reviewed by Lucas Forschler.
1969
1970         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1971         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
1972
1973 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1974
1975         [iOS] Multiple WKWebViewAutofillTests are flaky failures
1976         https://bugs.webkit.org/show_bug.cgi?id=189165
1977         <rdar://problem/47433765>
1978
1979         Reviewed by Tim Horton.
1980
1981         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
1982         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
1983         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
1984         process in sufficient to ensure that any previous action that blurred the focused element in the web process
1985         would make its way to the UI process by the time the layer tree commit is finished.
1986
1987         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
1988         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
1989         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
1990         will fail because it asks for -_autofillContext too early.
1991
1992         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
1993         is handled in the UI process.
1994
1995         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1996
1997         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
1998         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
1999         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2000         input session.
2001
2002         (-[AutofillTestView textInputHasAutofillContext]):
2003
2004         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2005
2006         * TestWebKitAPI/cocoa/TestWKWebView.h:
2007         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2008         (nextInputSessionChangeCount):
2009
2010         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2011         This includes changing the focused element from one to another.
2012
2013         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2014         (-[TestWKWebView didStartFormControlInteraction]):
2015         (-[TestWKWebView didEndFormControlInteraction]):
2016         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2017
2018         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2019         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2020         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2021         that doesn't require an input session to one that doesn't.
2022
2023 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2024
2025         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2026         <https://webkit.org/b/193676>
2027
2028         Reviewed by Alexey Proskuryakov.
2029
2030         * Scripts/webkitpy/style/checkers/cpp.py:
2031         (check_member_initialization_list):
2032         - Don't report missing whitespace around colon if the colon at
2033           the start of the line is formatted correctly.
2034         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2035         (WebKitStyleTest.test_member_initialization_list):
2036         - Add a test for a missing permutation of existing tests.
2037         - Add a test this false-positive.
2038         - Add blank lines between subtests to make them easier to read.
2039
2040 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2041
2042         [build.webkit.org] Unit-test failure after r237113
2043         https://bugs.webkit.org/show_bug.cgi?id=193669
2044
2045         Reviewed by Michael Catanzaro.
2046
2047         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2048         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2049         multiple or zero flags.
2050
2051 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2052
2053         Cache bytecode to disk
2054         https://bugs.webkit.org/show_bug.cgi?id=192782
2055         <rdar://problem/46084932>
2056
2057         Reviewed by Keith Miller.
2058
2059         Add test helper to execute bytecode-cache tests: it executes each test
2060         twice, the first with JSC_diskCachePath set to a temporary directory
2061         and second with JSC_forceDiskCache=true (in addition to the cache path)
2062         to guarantee that only the disk cache is being used and no new
2063         UnlinkedCodeBlocks are being created.
2064
2065         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2066         * Scripts/run-jsc-stress-tests:
2067
2068 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2069
2070         [css-logical] Implement flow-relative margin, padding and border shorthands
2071         https://bugs.webkit.org/show_bug.cgi?id=188697
2072
2073         Reviewed by Simon Fraser and Antti Koivisto.
2074
2075         * DumpRenderTree/TestOptions.cpp:
2076         (TestOptions::TestOptions):
2077         * DumpRenderTree/TestOptions.h:
2078         * DumpRenderTree/mac/DumpRenderTree.mm:
2079         (setWebPreferencesForTestOptions):
2080         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2081
2082         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2083         (JSONCSSPropertiesChecker.check_codegen_properties):
2084         Allow CSS property definitions to have a 'runtime-flag' parameter which
2085         disables the property when the specified runtime flag is disabled.
2086
2087 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2088
2089         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2090         https://bugs.webkit.org/show_bug.cgi?id=193643
2091
2092         Reviewed by Michael Catanzaro.
2093
2094         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2095         * wpe/jhbuild.modules: Ditto.
2096
2097 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2098
2099         [LFC][Floats] Take float top position into account when computing containing block height.
2100         https://bugs.webkit.org/show_bug.cgi?id=193655
2101
2102         Reviewed by Antti Koivisto.
2103
2104         * LayoutReloaded/misc/LFC-passing-tests.txt:
2105
2106 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2107
2108         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2109         <https://webkit.org/b/193645>
2110         <rdar://problem/47421574>
2111
2112         Reviewed by Alex Christensen.
2113
2114         - Now checks for local soft-linking of all frameworks that have
2115           their own *SoftLinking.{cpp,h,mm} files.
2116         - Changes softlink/uikit warning to softlink/framework.
2117
2118         * Scripts/webkitpy/style/checkers/cpp.py:
2119         (check_language):
2120         (CppChecker):
2121         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2122         (CppStyleTest):
2123
2124 2019-01-20  Saam Barati  <sbarati@apple.com>
2125
2126         Rollout r240210: It broke tests on iOS
2127         https://bugs.webkit.org/show_bug.cgi?id=193640
2128
2129         Unreviewed.
2130
2131         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2132         * Scripts/run-jsc-stress-tests:
2133
2134 2019-01-20  chris fleizach  <cfleizach@apple.com>
2135
2136         AX: Support returning relative frames for accessibility
2137         https://bugs.webkit.org/show_bug.cgi?id=193414
2138         <rdar://problem/47268501>
2139
2140         Reviewed by Zalan Bujtas.
2141
2142         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2143         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2144         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2145         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2146         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2147         (WTR::attributesOfElement):
2148         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2149
2150 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2151
2152         Unreviewed, add my new email address
2153
2154         * Scripts/webkitpy/common/config/contributors.json:
2155
2156 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2157
2158         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2159         https://bugs.webkit.org/show_bug.cgi?id=193617
2160
2161         Reviewed by Antti Koivisto.
2162
2163         * LayoutReloaded/misc/LFC-passing-tests.txt:
2164
2165 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2166
2167         Unreviewed, rolling out r240209.
2168
2169         Broke GTK/WPE injected bundle
2170
2171         Reverted changeset:
2172
2173         "AX: Support returning relative frames for accessibility"
2174         https://bugs.webkit.org/show_bug.cgi?id=193414
2175         https://trac.webkit.org/changeset/240209
2176
2177 2019-01-12  Dan Bernstein  <mitz@apple.com>
2178
2179         [Cocoa] Avoid importing directly from subumbrella frameworks
2180         https://bugs.webkit.org/show_bug.cgi?id=186016
2181         <rdar://problem/40591038>
2182
2183         Reviewed by Sam Weinig.
2184
2185         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2186           LaunchServices header.
2187         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2188           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2189         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2190           when using SDKs earlier than 10.13.
2191         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2192           and OTHER_CPLUSPLUSFLAGS.
2193         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2194           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2195         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2196           LaunchServices header.
2197
2198 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2199
2200         Cache bytecode to disk
2201         https://bugs.webkit.org/show_bug.cgi?id=192782
2202         <rdar://problem/46084932>
2203
2204         Reviewed by Keith Miller.
2205
2206         Add test helper to execute bytecode-cache tests: it executes each test
2207         twice, the first with JSC_diskCachePath set to a temporary directory
2208         and second with JSC_forceDiskCache=true (in addition to the cache path)
2209         to guarantee that only the disk cache is being used and no new
2210         UnlinkedCodeBlocks are being created.
2211
2212         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2213         * Scripts/run-jsc-stress-tests:
2214
2215 2019-01-20  chris fleizach  <cfleizach@apple.com>
2216
2217         AX: Support returning relative frames for accessibility
2218         https://bugs.webkit.org/show_bug.cgi?id=193414
2219         <rdar://problem/47268501>
2220
2221         Reviewed by Zalan Bujtas.
2222
2223         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2224         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2225         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2226         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2227         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2228         (WTR::attributesOfElement):
2229         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2230
2231 2019-01-20  Antoine Quint  <graouts@apple.com>
2232
2233         Add a POINTER_EVENTS feature flag
2234         https://bugs.webkit.org/show_bug.cgi?id=193577
2235         <rdar://problem/47408511>
2236
2237         Unreviewed. Also enable Pointer Events for iosmac.
2238
2239         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2240
2241 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2242
2243         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2244         https://bugs.webkit.org/show_bug.cgi?id=193613
2245
2246         Reviewed by Antti Koivisto.
2247
2248         * LayoutReloaded/misc/LFC-passing-tests.txt:
2249
2250 2019-01-19  Antoine Quint  <graouts@apple.com>
2251
2252         Add a POINTER_EVENTS feature flag
2253         https://bugs.webkit.org/show_bug.cgi?id=193577
2254
2255         Reviewed by Dean Jackson.
2256
2257         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2258
2259 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2260
2261         Disable the run-jsc-stress-test remote host key check [second round].
2262         https://bugs.webkit.org/show_bug.cgi?id=192988
2263
2264         Reviewed by Dewei Zhu.
2265
2266         * Scripts/run-jsc-stress-tests:
2267
2268 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2269
2270         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2271         https://bugs.webkit.org/show_bug.cgi?id=193597
2272
2273         Reviewed by Lucas Forschler.
2274
2275         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2276
2277 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2278
2279         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2280         https://bugs.webkit.org/show_bug.cgi?id=193595
2281
2282         Reviewed by Lucas Forschler.
2283
2284         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2285         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2286         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2287
2288 2019-01-18  Chris Dumez  <cdumez@apple.com>
2289
2290         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2291         https://bugs.webkit.org/show_bug.cgi?id=193588
2292         <rdar://problem/47131566>
2293
2294         Reviewed by Alex Christensen.
2295
2296         Add layout test coverage.
2297
2298         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2299
2300 2019-01-18  Jer Noble  <jer.noble@apple.com>
2301
2302         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2303         https://bugs.webkit.org/show_bug.cgi?id=189553
2304
2305         Reviewed by Tim Horton.
2306
2307         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2308
2309         * ContentExtensionTester/Configurations/Base.xcconfig:
2310         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2311         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2312         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2313         * ImageDiff/cg/Configurations/Base.xcconfig:
2314         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2315         * MiniBrowser/Configurations/Base.xcconfig:
2316         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2317         * MobileMiniBrowser/Configurations/Base.xcconfig:
2318         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2319         * Scripts/webkitpy/style/checker.py:
2320         (_all_categories):
2321         (FileType):
2322         (CheckerDispatcher._file_type):
2323         (CheckerDispatcher._create_checker):
2324         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2325         (SDKVariantChecker):
2326         (SDKVariantChecker.__init__):
2327         (SDKVariantChecker.check):
2328         * TestWebKitAPI/Configurations/Base.xcconfig:
2329         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2330         * WebEditingTester/Configurations/Base.xcconfig:
2331         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2332         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2333         * WebKitTestRunner/Configurations/Base.xcconfig:
2334         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2335         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2336         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2337
2338 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2339
2340         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2341         <https://webkit.org/b/193568>
2342         <rdar://problem/47381130>
2343
2344         Reviewed by Alex Christensen.
2345
2346         Make sure no one re-introduces UIKit soft-linking by adding a
2347         style rule.
2348
2349         * Scripts/webkitpy/style/checkers/cpp.py:
2350         (check_language): Add softlink/uikit check.
2351         (CppChecker): Enable softlink/uikit check.
2352         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2353         (CppStyleTest): Add test for softlink/uikit.
2354
2355 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2356
2357         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2358         https://bugs.webkit.org/show_bug.cgi?id=193584
2359
2360         Change "-dev" to "-devel".
2361
2362         Reviewed by Michael Catanzaro.
2363
2364         * gtk/install-dependencies:
2365
2366 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2367
2368         webkitpy: Add iPhone and iPad ports
2369         https://bugs.webkit.org/show_bug.cgi?id=193537
2370         <rdar://problem/47353390>
2371
2372         Reviewed by Lucas Forschler.
2373
2374         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2375         ports. Note that this separation is optional, the --ios-simulator command remains.
2376
2377         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2378         (RunTest.test_device_type_test_division): Drive-by fix.
2379         (RunTest.test_device_type_specific_listing): Ditto.
2380         (RunTest.test_ipad_test_division):
2381         (RunTest):
2382         (RunTest.test_ipad_listing):
2383         * Scripts/webkitpy/port/factory.py:
2384         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2385         (PortFactory):
2386         * Scripts/webkitpy/port/ios_simulator.py:
2387         (IPhoneSimulatorPort):
2388         (IPadSimulatorPort):
2389
2390 2019-01-18  Chris Dumez  <cdumez@apple.com>
2391
2392         Regression(PSON) Scroll position is not always restored properly when navigating back
2393         https://bugs.webkit.org/show_bug.cgi?id=193578
2394         <rdar://problem/47386331>
2395
2396         Reviewed by Tim Horton.
2397
2398         Add API test coverage.
2399
2400         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2401
2402 2019-01-18  Youenn Fablet  <youenn@apple.com>
2403
2404         Add a new SPI to request for cache storage quota increase
2405         https://bugs.webkit.org/show_bug.cgi?id=193323
2406
2407         Reviewed by Alex Christensen.
2408
2409         Implement WebsiteDataStore quota delegate to handle quota requests.
2410         By default, do not update quota.
2411         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2412
2413         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2414         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2415         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2416         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2417         * WebKitTestRunner/TestController.cpp:
2418         (WTR::TestController::allowCacheStorageQuotaIncrease):
2419         * WebKitTestRunner/TestController.h:
2420         * WebKitTestRunner/TestInvocation.cpp:
2421         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2422         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2423         (-[CacheStorageQuotaManager init]):
2424         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2425         (WTR::initializeWebViewConfiguration):
2426         (WTR::TestController::cocoaResetStateToConsistentValues):
2427         (WTR::TestController::allowCacheStorageQuotaIncrease):
2428
2429 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2430
2431         [ews-build] Pass owner to the triggered builds
2432         https://bugs.webkit.org/show_bug.cgi?id=193574
2433
2434         Reviewed by Lucas Forschler.
2435
2436         * BuildSlaveSupport/ews-build/factories.py:
2437         (BuildFactory.propertiesToPassToTriggers):
2438
2439 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2440
2441         [ews-app] Send patch author as a build property
2442         https://bugs.webkit.org/show_bug.cgi?id=193560
2443
2444         Reviewed by Lucas Forschler.
2445
2446         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2447         (BugzillaPatchFetcher.fetch):
2448
2449 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2450
2451         webkitpy: Implement device type specific expected results (Follow-up fix)
2452         https://bugs.webkit.org/show_bug.cgi?id=192162
2453         <rdar://problem/46345449>
2454
2455         Unreviewed infrastructure fix.
2456
2457         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2458         (Manager.run): Don't boot a device if no tests are available to run on it.
2459
2460 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2461
2462         webkitpy: Implement device type specific expected results (Follow-up fix)
2463         https://bugs.webkit.org/show_bug.cgi?id=192162
2464         <rdar://problem/46345449>
2465
2466         Unreviewed infrastructure fix.
2467
2468         * Scripts/webkitpy/api_tests/manager.py:
2469         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2470
2471 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2472
2473         webkitpy: Implement device type specific expected results (Part 2)
2474         https://bugs.webkit.org/show_bug.cgi?id=192162
2475         <rdar://problem/46345449>
2476
2477         Rubber-stamped by Aakash Jain.
2478
2479         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2480         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2481         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2482
2483         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2484         (LayoutTestFinder.find_tests): Pass device_type through.
2485         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2486         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2487         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2488         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2489         (Manager._collect_tests): Pass device type to test finder.
2490         (Manager._needs_web_platform_test):
2491         (Manager._prepare_lists): Index _expectations by device type.
2492         (Manager._test_input_for_file):
2493         (Manager._test_is_slow): Ditto.
2494         (Manager._test_should_dump_jsconsolelog_in_stderr):
2495         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2496         (Manager._get_test_inputs):
2497         (Manager._update_worker_count):
2498         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2499         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2500         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2501         the one which runs the test.
2502         (Manager._run_test_subset):
2503         (Manager._run_tests): Index _expectations by current_device_type.
2504         (Manager._print_expectation_line_for_test): Ditto.
2505         (Manager._print_expectations_for_subset): Ditto.
2506         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2507         Unlike run, this function will behave the same regardless of what devices are available.
2508         (Manager._custom_device_for_test): Deleted.
2509         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2510         (ManagerTest.test_uses_custom_device): Deleted.
2511         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2512         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2513         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2514         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2515         all of the expectations.
2516         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2517         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2518         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2519         (TestExpectations.__init__): Allow device_type to be passed through.
2520         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2521         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2522         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2523         (summarize_results):
2524         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2525         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2526         a test ran with, one must check all expectations to find the first non-skip expectation.
2527         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2528         (RunTest.test_device_type_test_division):
2529         (RunTest):
2530         (RunTest.test_device_type_specific_listing):
2531         * Scripts/webkitpy/port/base.py:
2532         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2533         (Port.supported_device_types): The result of this function will change based on what devices are available.
2534         * Scripts/webkitpy/port/device_port.py:
2535         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2536         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2537         can be used.
2538         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2539         any, or the DEFAULT_DEVICE_TYPES of the port.
2540         * Scripts/webkitpy/port/ios.py:
2541         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2542         * Scripts/webkitpy/port/ios_simulator.py:
2543         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2544         * Scripts/webkitpy/port/watch.py:
2545         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2546         * Scripts/webkitpy/port/watch_simulator.py:
2547         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2548         * Scripts/webkitpy/xcode/device_type.py:
2549         (DeviceType):
2550         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2551
2552 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2553
2554         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2555         https://bugs.webkit.org/show_bug.cgi?id=193575
2556
2557         Reviewed by Michael Catanzaro.
2558
2559         Allow the script to run without explicit port argument because
2560         it's specific to the WPE port anyway.
2561
2562         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2563         and simplify the rest of the code accordingly.
2564
2565 2019-01-18  Charlie Turner  <cturner@igalia.com>
2566
2567         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2568         https://bugs.webkit.org/show_bug.cgi?id=192229
2569
2570         Reviewed by Xabier Rodriguez-Calvar.
2571
2572         * MiniBrowser/wpe/main.cpp:
2573         (main): Enable encrypted-media by default.
2574
2575 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2576
2577         [Flatpak] Missing KeyboardInterrupt exception handler
2578         https://bugs.webkit.org/show_bug.cgi?id=193570
2579
2580         Reviewed by Michael Catanzaro.
2581
2582         * flatpak/flatpakutils.py:
2583         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2584
2585 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2586
2587         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2588         https://bugs.webkit.org/show_bug.cgi?id=193564
2589
2590         Reviewed by Antti Koivisto.
2591
2592         * LayoutReloaded/misc/LFC-passing-tests.txt:
2593
2594 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2595
2596         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2597         https://bugs.webkit.org/show_bug.cgi?id=193562
2598
2599         Reviewed by Antti Koivisto.
2600
2601         * LayoutReloaded/misc/LFC-passing-tests.txt:
2602
2603 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2604
2605         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2606         https://bugs.webkit.org/show_bug.cgi?id=193555
2607
2608         Reviewed by Antti Koivisto.
2609
2610         * LayoutReloaded/misc/LFC-passing-tests.txt:
2611
2612 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2613
2614         [WPE] Add Qt extension
2615         https://bugs.webkit.org/show_bug.cgi?id=191464
2616
2617         Reviewed by Carlos Garcia Campos.
2618
2619         MiniBrowser and API tests for the WPE Qt API. To run the
2620         MiniBrowser a new script is introduced. Example invocation:
2621
2622         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2623
2624         Also note-worthy is the introduction of the python2-subprocess32
2625         dependency to run the GLib API tests.
2626
2627         * MiniBrowser/wpe/CMakeLists.txt:
2628         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2629         * MiniBrowser/wpe/qt/main.cpp: Added.
2630         (main):
2631         * MiniBrowser/wpe/qt/main.qml: Added.
2632         * MiniBrowser/wpe/qt/qml.qrc: Added.
2633         * Scripts/run-gtk-tests:
2634         (GtkTestRunner.is_google_test):
2635         (GtkTestRunner):
2636         (GtkTestRunner.is_qt_test):
2637         * Scripts/run-qt-wpe-minibrowser: Added.
2638         * Scripts/run-wpe-tests:
2639         (WPETestRunner):
2640         (WPETestRunner.is_google_test):
2641         (WPETestRunner.is_qt_test):
2642         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2643         (TestLoad::main):
2644         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2645         (TestLoadHtml::main):
2646         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2647         (TestLoadRequest::main):
2648         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2649         (TestRunJavaScript::main):
2650         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2651         (waitForSignal):
2652         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2653         (LoadSpy::LoadSpy):
2654         (LoadSpy::~LoadSpy):
2655         (LoadSpy::onLoadingChanged):
2656         (LoadStartedCatcher::LoadStartedCatcher):
2657         (LoadStartedCatcher::~LoadStartedCatcher):
2658         (LoadStartedCatcher::onLoadingChanged):
2659         (waitForLoadSucceeded):
2660         (waitForLoadFailed):
2661         * TestWebKitAPI/glib/CMakeLists.txt:
2662         * flatpak/flatpakutils.py:
2663         (WebkitFlatpak.load_from_args):
2664         (WebkitFlatpak.__init__):
2665         (WebkitFlatpak.clean_args):
2666         (WebkitFlatpak.run_in_sandbox):
2667         * flatpak/org.webkit.CommonModules.yaml:
2668         * flatpak/org.webkit.WPE.yaml:
2669         * flatpak/org.webkit.WPEModules.yaml:
2670         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2671         * flatpak/org.webkit.WebKit.yaml:
2672         * glib/api_test_runner.py:
2673         (TestRunner._run_test_qt):
2674         (TestRunner.is_qt_test):
2675         (TestRunner._run_test):
2676
2677 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2678
2679         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2680         https://bugs.webkit.org/show_bug.cgi?id=193494
2681         <rdar://problem/46859627>
2682
2683         Reviewed by Simon Fraser and Tim Horton.
2684
2685         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2686         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2687
2688         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2689         (WTR::UIScriptController::contentOffsetX const):
2690         (WTR::UIScriptController::contentOffsetY const):
2691         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2692         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2693         (WTR::UIScriptController::contentOffsetX const):
2694         (WTR::UIScriptController::contentOffsetY const):
2695         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2696
2697         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2698
2699         * WebKitTestRunner/TestController.cpp:
2700         (WTR::updateTestOptionsFromTestHeader):
2701         * WebKitTestRunner/TestOptions.h:
2702         (WTR::TestOptions::hasSameInitializationOptions const):
2703         * WebKitTestRunner/ios/TestControllerIOS.mm:
2704         (WTR::TestController::platformResetStateToConsistentValues):
2705         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2706         (WTR::UIScriptController::contentOffsetX const):
2707         (WTR::UIScriptController::contentOffsetY const):
2708
2709 2019-01-17  Truitt Savell  <tsavell@apple.com>
2710
2711         Unreviewed, rolling out r240124.
2712
2713         This commit broke an internal build.
2714
2715         Reverted changeset:
2716
2717         "SDK_VARIANT build destinations should be separate from non-
2718         SDK_VARIANT builds"
2719         https://bugs.webkit.org/show_bug.cgi?id=189553
2720         https://trac.webkit.org/changeset/240124
2721
2722 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2723
2724         Fix string concatenation API test after r239920
2725         https://bugs.webkit.org/show_bug.cgi?id=193551
2726         <rdar://problem/47359304>
2727
2728         Reviewed by Youenn Fablet.
2729
2730         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2731         (TestWebKitAPI::TEST):
2732         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2733         in WebKit's build configuration like it apparently is on Linux.
2734
2735 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2736
2737         [ews-build] validate-patch should handle the case when bug_id is None
2738         https://bugs.webkit.org/show_bug.cgi?id=193547
2739
2740         Reviewed by Lucas Forschler.
2741
2742         * BuildSlaveSupport/ews-build/steps.py:
2743         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2744         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2745
2746 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2747
2748         [ews-build] Add patch author information in build
2749         https://bugs.webkit.org/show_bug.cgi?id=193465
2750
2751         Reviewed by Lucas Forschler.
2752
2753         * BuildSlaveSupport/ews-build/steps.py:
2754         (ValidatePatch._is_patch_obsolete):
2755
2756 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2757
2758         [ews-build] Pass bug_id to the triggered builds
2759         https://bugs.webkit.org/show_bug.cgi?id=193548
2760
2761         Reviewed by Lucas Forschler.
2762
2763         * BuildSlaveSupport/ews-build/factories.py:
2764         (BuildFactory.propertiesToPassToTriggers):
2765
2766 2019-01-17  Jer Noble  <jer.noble@apple.com>
2767
2768         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2769         https://bugs.webkit.org/show_bug.cgi?id=189553
2770
2771         Reviewed by Tim Horton.
2772
2773         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2774
2775         * ContentExtensionTester/Configurations/Base.xcconfig:
2776         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2777         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2778         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2779         * ImageDiff/cg/Configurations/Base.xcconfig:
2780         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2781         * MiniBrowser/Configurations/Base.xcconfig:
2782         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2783         * MobileMiniBrowser/Configurations/Base.xcconfig:
2784         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2785         * Scripts/webkitpy/style/checker.py:
2786         (_all_categories):
2787         (FileType):
2788         (CheckerDispatcher._file_type):
2789         (CheckerDispatcher._create_checker):
2790         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2791         (SDKVariantChecker):
2792         (SDKVariantChecker.__init__):
2793         (SDKVariantChecker.check):
2794         * TestWebKitAPI/Configurations/Base.xcconfig:
2795         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2796         * WebEditingTester/Configurations/Base.xcconfig:
2797         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2798         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2799         * WebKitTestRunner/Configurations/Base.xcconfig:
2800         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2801         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2802         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2803
2804 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2805
2806         [LFC][BFC] An element with transform is a containing block for positioned descendants.
2807         https://bugs.webkit.org/show_bug.cgi?id=193534
2808
2809         Reviewed by Antti Koivisto.
2810
2811         * LayoutReloaded/misc/LFC-passing-tests.txt:
2812
2813 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2814
2815         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
2816         https://bugs.webkit.org/show_bug.cgi?id=193528
2817
2818         Reviewed by Antti Koivisto.
2819
2820         * LayoutReloaded/misc/LFC-passing-tests.txt:
2821
2822 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2823
2824         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
2825         https://bugs.webkit.org/show_bug.cgi?id=193520
2826
2827         Reviewed by Antti Koivisto.
2828
2829         * LayoutReloaded/misc/LFC-passing-tests.txt:
2830
2831 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2832
2833         [ews-build] unapply-patch step should not update source
2834         https://bugs.webkit.org/show_bug.cgi?id=193234
2835
2836         Reviewed by Lucas Forschler.
2837
2838         * BuildSlaveSupport/ews-build/steps.py:
2839         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
2840         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
2841
2842 2019-01-16  Youenn Fablet  <youenn@apple.com>
2843
2844         Add a new SPI for controlling getUserMedia
2845         https://bugs.webkit.org/show_bug.cgi?id=192793
2846
2847         Reviewed by Eric Carlson.
2848
2849         * MiniBrowser/mac/WK2BrowserWindowController.m:
2850         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
2851         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2852         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2853         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2854         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2855         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2856         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
2857         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2858         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2859         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2860         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2861         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2862         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2863         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2864
2865 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2866
2867         [LFC][BFC] Inflow non-replaced used width should not be negative.
2868         https://bugs.webkit.org/show_bug.cgi?id=193495
2869
2870         Reviewed by Antti Koivisto.
2871
2872         * LayoutReloaded/misc/LFC-passing-tests.txt:
2873
2874 2019-01-16  Chris Dumez  <cdumez@apple.com>
2875
2876         Regression(PSON) View becomes blank after click a cross-site download link
2877         https://bugs.webkit.org/show_bug.cgi?id=193361
2878         <rdar://problem/47099573>
2879
2880         Reviewed by Geoffrey Garen.
2881
2882         Add API test coverage.
2883
2884         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2885         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2886
2887 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2888
2889         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
2890         https://bugs.webkit.org/show_bug.cgi?id=193470
2891
2892         Reviewed by Antti Koivisto.
2893
2894         * LayoutReloaded/misc/LFC-passing-tests.txt:
2895
2896 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2897
2898         [LFC] Adjust margin box verification.
2899         https://bugs.webkit.org/show_bug.cgi?id=193482
2900
2901         Reviewed by Antti Koivisto.
2902
2903         * LayoutReloaded/misc/LFC-passing-tests.txt:
2904
2905 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
2906
2907         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
2908         https://bugs.webkit.org/show_bug.cgi?id=193451
2909
2910         Reviewed by Geoffrey Garen.
2911
2912         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
2913         (TEST):
2914         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2915         (runWebsiteDataStoreCustomPaths):
2916
2917 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2918
2919         webkitpy: Support boolean simctl isAvailable
2920         https://bugs.webkit.org/show_bug.cgi?id=193472
2921         <rdar://problem/47296150>
2922
2923         Reviewed by Ryosuke Niwa.
2924
2925         * Scripts/webkitpy/xcode/simulated_device.py:
2926         (SimulatedDeviceManager._create_runtimes):
2927         (SimulatedDeviceManager._create_device_with_runtime):
2928
2929 2019-01-15  Chris Dumez  <cdumez@apple.com>
2930
2931         Unreviewed, rolling out r239993, r239995, r239997, and
2932         r239999.
2933
2934         Caused assertions under
2935         ViewGestureController::disconnectFromProcess()
2936
2937         Reverted changesets:
2938
2939         "Regression(PSON) View becomes blank after click a cross-site
2940         download link"
2941         https://bugs.webkit.org/show_bug.cgi?id=193361
2942         https://trac.webkit.org/changeset/239993
2943
2944         "Unreviewed iOS build fix after r239993."
2945         https://trac.webkit.org/changeset/239995
2946
2947         "Fix iOS build after r239993"
2948         https://bugs.webkit.org/show_bug.cgi?id=193361
2949         https://trac.webkit.org/changeset/239997
2950
2951         "Unreviewed, revert part of r239997 as it is not needed to fix
2952         the build."
2953         https://trac.webkit.org/changeset/239999
2954
2955 2019-01-15  Tim Horton  <timothy_horton@apple.com>
2956
2957         Cannot tab out of WKWebView on macOS
2958         https://bugs.webkit.org/show_bug.cgi?id=161448
2959         <rdar://problem/28100085>
2960
2961         Reviewed by Dean Jackson.
2962
2963         Add a test that tabbing into and out of WKWebView works correctly.
2964
2965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2966         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2967         (WebKit2_CommandBackForwardTest::SetUp):
2968         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
2969         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
2970         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
2971         (-[FocusableView canBecomeKeyView]):
2972         (TEST):
2973         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
2974         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
2975         (-[OffscreenWindow initWithSize:]):
2976         (-[OffscreenWindow isKeyWindow]):
2977         (-[OffscreenWindow isVisible]):
2978         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2979         (TestWebKitAPI::PlatformWebView::initialize):
2980         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
2981         (-[ActiveOffscreenWindow isVisible]): Deleted.
2982         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
2983
2984 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
2985
2986         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
2987         https://bugs.webkit.org/show_bug.cgi?id=193459
2988
2989         Reviewed by Mark Lam.
2990
2991         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2992         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
2993
2994 2019-01-15  Chris Dumez  <cdumez@apple.com>
2995
2996         Regression(PSON) View becomes blank after click a cross-site download link
2997         https://bugs.webkit.org/show_bug.cgi?id=193361
2998         <rdar://problem/47099573>
2999
3000         Reviewed by Geoff Garen.
3001
3002         Add API test coverage.
3003
3004         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3005         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3006
3007 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3008
3009         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3010         https://bugs.webkit.org/show_bug.cgi?id=193448
3011
3012         Reviewed by Antti Koivisto.
3013
3014         * LayoutReloaded/misc/LFC-passing-tests.txt:
3015
3016 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3017
3018         webkitpy: Implement device type specific expected results (Part 1)
3019         https://bugs.webkit.org/show_bug.cgi?id=192162
3020
3021         Reviewed by Lucas Forschler.
3022
3023         Device type specific expected results covers two related ideas. The first (covered by this change)
3024         is where to search for -expected.* files. The second is which tests to run based on the
3025         TestExpectations.txt file.
3026
3027         After this change, the baseline search path will be determined by the type of device running a
3028         test. Device type will be passed into any function which picks a file based on the baseline search
3029         path.
3030
3031         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3032         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3033         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3034         (Manager.run): Print baseline search path for each round of devices.
3035         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3036         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3037         (SingleTestRunner._expected_driver_output): Ditto.
3038         (SingleTestRunner._driver_input): Ditto.
3039         * Scripts/webkitpy/layout_tests/views/printing.py:
3040         (Printer.print_config): Move printing of baseline search path to a separate function.
3041         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3042         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3043         (Testprinter.test_print_config):
3044         (Testprinter.test_print_baseline_search_path):
3045         * Scripts/webkitpy/port/base.py:
3046         (Port.baseline_search_path): Pass device_type through.
3047         (Port._expected_baselines_for_suffixes): Ditto.
3048         (Port.expected_baselines): Ditto.
3049         (Port.expected_filename): Ditto.
3050         (Port.expected_checksum): Ditto.
3051         (Port.expected_image): Ditto.
3052         (Port.expected_audio): Ditto.
3053         (Port.expected_text): Ditto.
3054         (Port.reference_files): Ditto.
3055         (Port.tests): Ditto.
3056         (Port._expanded_paths): Ditto.
3057         (Port.skipped_layout_tests): Ditto.
3058         (Port.expectations_dict): Ditto.
3059         (Port._port_specific_expectations_files): Ditto.
3060         (Port.expectations_files): Ditto.
3061         (Port.test_search_path): Ditto.
3062         (Port._tests_for_other_platforms): Ditto.
3063         * Scripts/webkitpy/port/base_unittest.py:
3064         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3065         (PortTest.test_nonexistant_expectations): Ditto.
3066         (test_ref_tests_platform_directory): Ditto.
3067         * Scripts/webkitpy/port/darwin.py:
3068         (DarwinPort._port_specific_expectations_files): Accept device_type.
3069         * Scripts/webkitpy/port/driver.py:
3070         (DriverProxy):
3071         (DriverProxy.host): Expose _target_host for device_type information.
3072         * Scripts/webkitpy/port/gtk.py:
3073         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3074         * Scripts/webkitpy/port/ios.py:
3075         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3076         * Scripts/webkitpy/port/mac.py:
3077         (MacPort. default_baseline_search_path): Ditto.
3078         * Scripts/webkitpy/port/port_testcase.py:
3079         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3080         * Scripts/webkitpy/port/test.py:
3081         * Scripts/webkitpy/port/watch.py:
3082         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3083         * Scripts/webkitpy/port/win.py:
3084         (WinPort.test_search_path): Accept, but do not use, device_type.
3085         * Scripts/webkitpy/port/wpe.py:
3086         (WPEPort._port_specific_expectations_files): Ditto.
3087         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3088         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3089
3090 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3091
3092         [LFC] Use the containing block's padding box to position out-of-flow elements.
3093         https://bugs.webkit.org/show_bug.cgi?id=193431
3094
3095         Reviewed by Antti Koivisto.
3096
3097         * LayoutReloaded/misc/LFC-passing-tests.txt:
3098
3099 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3100
3101         Move a test implementation file that got misplaced in the Xcode project
3102
3103         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3104
3105 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3106
3107         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3108         r239913, and r239914.
3109         https://bugs.webkit.org/show_bug.cgi?id=193407
3110
3111         These revisions caused an internal failure (Requested by
3112         Truitt on #webkit).
3113
3114         Reverted changesets:
3115
3116         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3117         https://bugs.webkit.org/show_bug.cgi?id=186016
3118         https://trac.webkit.org/changeset/239901
3119
3120         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3121         https://trac.webkit.org/changeset/239909
3122
3123         "Tried to fix the build."
3124         https://trac.webkit.org/changeset/239910
3125
3126         "Fixed iOS builds after r239910."
3127         https://trac.webkit.org/changeset/239912
3128
3129         "More build fixing."
3130         https://trac.webkit.org/changeset/239913
3131
3132         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3133         https://trac.webkit.org/changeset/239914
3134
3135 2019-01-14  Mark Lam  <mark.lam@apple.com>
3136
3137         Re-enable ability to build --cloop builds.
3138         https://bugs.webkit.org/show_bug.cgi?id=192955
3139         <rdar://problem/46882363>
3140
3141         Reviewed by Saam barati and Keith Miller.
3142
3143         The --cloop build option was being ignored this whole time since r236381.
3144         This patch makes it possible to build CLoop builds again.
3145
3146         * Scripts/build-jsc:
3147         * Scripts/webkitperl/FeatureList.pm:
3148         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3149
3150 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3151
3152         webkitpy: Expose device_type from host-like objects
3153         https://bugs.webkit.org/show_bug.cgi?id=193406
3154         <rdar://problem/47262305>
3155
3156         Reviewed by Lucas Forschler.
3157
3158         Devices should expose device_type. As a result, all host objects should
3159         provide a device_type property, even if they do not yet define a device_type.
3160
3161         * Scripts/webkitpy/common/system/systemhost.py:
3162         (SystemHost):
3163         (SystemHost.device_type):
3164         * Scripts/webkitpy/common/system/systemhost_mock.py:
3165         (MockSystemHost):
3166         (MockSystemHost.device_type):
3167         * Scripts/webkitpy/port/device.py:
3168         (Device):
3169         (Device.device_type):
3170         * Scripts/webkitpy/xcode/simulated_device.py:
3171         (SimulatedDeviceManager._find_exisiting_device_for_request):
3172         (SimulatedDeviceManager._disambiguate_device_type):
3173         (SimulatedDeviceManager._does_fulfill_request):
3174         (SimulatedDeviceManager.device_count_for_type):
3175         (SimulatedDeviceManager.initialize_devices):
3176         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3177         (test_available_devices):
3178         (test_swapping_devices):
3179
3180 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3181
3182         webkitpy: Support alternate simctl device list output (Follow-up fix)
3183         https://bugs.webkit.org/show_bug.cgi?id=193362
3184         <rdar://problem/47122965>
3185
3186         Rubber-stamped by Lucas Forschler.
3187
3188         * Scripts/webkitpy/xcode/simulated_device.py:
3189         (SimulatedDeviceManager.populate_available_devices):
3190
3191 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3192
3193         [iOS] Expose SPI to access the current sentence boundary and selection state
3194         https://bugs.webkit.org/show_bug.cgi?id=193398
3195         <rdar://problem/45893108>
3196
3197         Reviewed by Dean Jackson.
3198
3199         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3200         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3201         expected.
3202
3203         * TestWebKitAPI/EditingTestHarness.h:
3204         * TestWebKitAPI/EditingTestHarness.mm:
3205         (-[EditingTestHarness moveBackward]):
3206         (-[EditingTestHarness moveForward]):
3207         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3208
3209         Add a couple of new helper methods on EditingTestHarness.
3210
3211         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3212         (-[SelectionChangeObserver initWithWebView:]):
3213         (-[SelectionChangeObserver webView]):
3214         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3215         (-[SelectionChangeObserver currentSelectionAttributes]):
3216
3217 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3218
3219         [LFC][BFC] Add basic box-sizing support.
3220         https://bugs.webkit.org/show_bug.cgi?id=193392
3221
3222         Reviewed by Antti Koivisto.
3223
3224         * LayoutReloaded/misc/LFC-passing-tests.txt:
3225
3226 2019-01-14  Charlie Turner  <cturner@igalia.com>
3227
3228         [WPE] API test gardening
3229         https://bugs.webkit.org/show_bug.cgi?id=193319
3230
3231         Reviewed by Michael Catanzaro.
3232
3233         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3234         passing tests.
3235
3236 2019-01-14  Charlie Turner  <cturner@igalia.com>
3237
3238         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3239         https://bugs.webkit.org/show_bug.cgi?id=192977
3240
3241         Reviewed by Carlos Garcia Campos.
3242
3243         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3244         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3245         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3246         (TestWebKitAPI::GStreamerTest::SetUp):
3247         (TestWebKitAPI::GStreamerTest::TearDown):
3248         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3249         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3250         (TestWebKitAPI::TEST_F):
3251
3252 2019-01-14  Charlie Turner  <cturner@igalia.com>
3253
3254         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3255         https://bugs.webkit.org/show_bug.cgi?id=193332
3256
3257         Reviewed by Michael Catanzaro.
3258
3259         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3260         defined as a char16_t, which changed in ICU 59, the
3261         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3262         unsigned short. This test is relying on the behaviour that
3263         UChar=unsigned short, which doesn't hold across platforms and ICU
3264         library versions. The full fix would be a special syntax for
3265         literal characters so that these ambiguities do not arise. That
3266         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3267         (TestWebKitAPI::TEST):
3268
3269 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3270
3271         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3272
3273         * Scripts/make-dist:
3274         (Distcheck.configure):
3275
3276 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3277
3278         [ews-build] Update macOS queue configurations
3279         https://bugs.webkit.org/show_bug.cgi?id=193365
3280         <rdar://problem/47221073>
3281
3282         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3283
3284         * BuildSlaveSupport/ews-build/config.json:
3285
3286 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3287
3288         [LFC] Adjust assert for statically positioned fixed elements
3289         https://bugs.webkit.org/show_bug.cgi?id=193385
3290
3291         Reviewed by Antti Koivisto.
3292
3293         * LayoutReloaded/misc/LFC-passing-tests.txt:
3294
3295 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3296
3297         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3298         https://bugs.webkit.org/show_bug.cgi?id=193387
3299
3300         Reviewed by Carlos Garcia Campos.
3301
3302         * MiniBrowser/wpe/main.cpp:
3303         (main):
3304
3305 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3306
3307         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3308         https://bugs.webkit.org/show_bug.cgi?id=191655
3309         rdar://problem/46074680
3310
3311         Reviewed by Megan Gardner.
3312
3313         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3314         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3315
3316 2019-01-12  Dan Bernstein  <mitz@apple.com>
3317
3318         [Cocoa] Avoid importing directly from subumbrella frameworks
3319         https://bugs.webkit.org/show_bug.cgi?id=186016
3320         <rdar://problem/40591038>
3321
3322         Reviewed by Sam Weinig.
3323
3324         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3325           LaunchServices header.
3326         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3327           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3328         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3329           when using SDKs earlier than 10.13.
3330         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3331           and OTHER_CPLUSPLUSFLAGS.
3332         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3333           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3334         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3335           LaunchServices header.
3336
3337 2019-01-11  John Wilander  <wilander@apple.com>
3338
3339         Compile out Web API Statistics Collection
3340         https://bugs.webkit.org/show_bug.cgi?id=193370
3341         <rdar://problem/45388584>
3342
3343         Reviewed by Brent Fulgham.
3344
3345         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3346             Defined ENABLE_WEB_API_STATISTICS, off by default.
3347
3348 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3349
3350         [WPE] Add gtk-doc
3351         https://bugs.webkit.org/show_bug.cgi?id=178900
3352
3353         Reviewed by Michael Catanzaro.
3354
3355         Add Tools/gtkdoc to manifest.txt.in files.
3356         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3357
3358         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3359         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3360
3361 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3362
3363         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3364         https://bugs.webkit.org/show_bug.cgi?id=193364
3365         <rdar://problem/47214117>
3366
3367         Reviewed by Tim Horton.
3368
3369         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3370         precise, whereas dragging near the middle of the textarea does.
3371
3372         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3373         (TestWebKitAPI::TEST):
3374
3375 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3376
3377         webkitpy: Support alternate simctl device list output
3378         https://bugs.webkit.org/show_bug.cgi?id=193362
3379         <rdar://problem/47122965>
3380
3381         Reviewed by Lucas Forschler.
3382
3383         * Scripts/webkitpy/xcode/simulated_device.py:
3384         (SimulatedDeviceManager.populate_available_devices):
3385
3386 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3387
3388         [ews-build] Update macOS queue configurations
3389         https://bugs.webkit.org/show_bug.cgi?id=193365
3390
3391         Reviewed by Lucas Forschler.
3392
3393         * BuildSlaveSupport/ews-build/config.json:
3394
3395 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3396
3397         webkitpy: Incorporate device type into baseline search path
3398         https://bugs.webkit.org/show_bug.cgi?id=193356
3399         <rdar://problem/47215515>
3400
3401         Reviewed by Lucas Forschler.
3402
3403         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3404
3405         * Scripts/webkitpy/port/base.py:
3406         (Port.default_baseline_search_path): Allow device type to be passed in.
3407         * Scripts/webkitpy/port/gtk.py:
3408         (GtkPort.default_baseline_search_path): Ignore device type.
3409         * Scripts/webkitpy/port/ios.py:
3410         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3411         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3412         * Scripts/webkitpy/port/ios_device_unittest.py:
3413         (IOSDeviceTest):
3414         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3415         (IOSSimulatorTest):
3416         * Scripts/webkitpy/port/mac.py:
3417         (MacPort.default_baseline_search_path): Ignore device type.
3418         * Scripts/webkitpy/port/watch.py:
3419         (WatchPort.default_baseline_search_path): Ditto.
3420         * Scripts/webkitpy/port/win.py:
3421         (WinPort.default_baseline_search_path): Ditto.
3422         (WinCairoPort.default_baseline_search_path): Ditto.
3423         * Scripts/webkitpy/port/wpe.py:
3424         (WPEPort.default_baseline_search_path): Ditto.
3425
3426 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3427
3428         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3429         https://bugs.webkit.org/show_bug.cgi?id=193352
3430         <rdar://problem/47210736>
3431
3432         Reviewed by Lucas Forschler.
3433
3434         * Scripts/webkitpy/layout_tests/views/printing.py:
3435         (Printer.print_config): Print list on only baseline search paths which exist. 
3436         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3437         (Testprinter.test_print_config):
3438
3439 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3440
3441         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3442         https://bugs.webkit.org/show_bug.cgi?id=193340
3443
3444         Reviewed by David Kilzer.
3445
3446         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3447         (WTR::InjectedBundle::didReceiveMessageToPage):
3448         Pull the strings out into a WKRetainPtr.
3449
3450         * WebKitTestRunner/WebNotificationProvider.cpp:
3451         (WTR::WebNotificationProvider::closeWebNotification):
3452         Adopt the created value into the WKRetainPtr.
3453
3454         * WebKitTestRunner/mac/TestControllerMac.mm:
3455         (WTR::generateWhitelist):
3456         Immediately adopt a created value to avoid potential mistakes.
3457
3458 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3459
3460         Enable DFG on ARM/Linux again
3461         https://bugs.webkit.org/show_bug.cgi?id=192496
3462
3463         Reviewed by Yusuke Suzuki.
3464
3465         After changing the bytecode format DFG was disabled on all 32-bit
3466         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3467         on ARM by default.
3468
3469         * Scripts/run-jsc-stress-tests:
3470
3471 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3472
3473         Unreviewed, fix #ifdef in API test added in r239851.
3474         https://bugs.webkit.org/show_bug.cgi?id=193327
3475         rdar://problem/47093222
3476
3477         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3478
3479 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3480
3481         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3482         https://bugs.webkit.org/show_bug.cgi?id=193109
3483         <rdar://problem/44807048>
3484
3485         Reviewed by Ryosuke Niwa.
3486
3487         Introduce and respect a test option to enable the UndoManager API.
3488
3489         * WebKitTestRunner/TestController.cpp:
3490         (WTR::updateTestOptionsFromTestHeader):
3491         * WebKitTestRunner/TestOptions.h:
3492         (WTR::TestOptions::hasSameInitializationOptions const):
3493         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3494         (WTR::TestController::platformCreateWebView):
3495
3496 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3497
3498         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3499         https://bugs.webkit.org/show_bug.cgi?id=193346
3500
3501         Reviewed by Antti Koivisto.
3502
3503         * LayoutReloaded/misc/LFC-passing-tests.txt:
3504
3505 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3506
3507         Unreviewed, fix typo that breaks dashboard link.
3508
3509         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3510         (WebKitBuildbot):
3511
3512 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3513
3514         Update macOS queue configurations
3515         https://bugs.webkit.org/show_bug.cgi?id=193329
3516
3517         Reviewed by Alexey Proskuryakov.
3518
3519         * BuildSlaveSupport/build.webkit.org-config/config.json:
3520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3521         (BubbleQueueServer):
3522         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3523         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3524         (WebKitBuildbot):
3525         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3526         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3527         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3528
3529 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3530
3531         MiniBrowser should be able to navigate to about:blank
3532         https://bugs.webkit.org/show_bug.cgi?id=193345
3533
3534         Reviewed by Simon Fraser.
3535
3536         * MiniBrowser/mac/BrowserWindowController.m:
3537         (-[BrowserWindowController addProtocolIfNecessary:]):
3538         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3539
3540         * MiniBrowser/mac/WK1BrowserWindowController.m:
3541         (-[WK1BrowserWindowController fetch:]):
3542         * MiniBrowser/mac/WK2BrowserWindowController.m:
3543         (-[WK2BrowserWindowController fetch:]):
3544         Clean up the code that uses this to match style.
3545
3546 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3547
3548         Remove MiniBrowser custom "Process Swap" menu item which does not work
3549         https://bugs.webkit.org/show_bug.cgi?id=193344
3550
3551         Reviewed by Simon Fraser.
3552
3553         There is a menu item under the Experimental menu that does work.
3554
3555         * MiniBrowser/mac/AppDelegate.m:
3556         (defaultConfiguration):
3557         * MiniBrowser/mac/SettingsController.h:
3558         * MiniBrowser/mac/SettingsController.m:
3559         (-[SettingsController _populateMenu]):
3560         (-[SettingsController validateMenuItem:]):
3561         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3562         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3563
3564 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3565
3566         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3567         https://bugs.webkit.org/show_bug.cgi?id=193327
3568         rdar://problem/47093222
3569
3570         Reviewed by Tim Horton.
3571
3572         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3573         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3574         (TestWebKitAPI::didFinishNavigation):
3575         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3576         (TestWebKitAPI::TEST):
3577         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3578         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3579         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3580         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3581         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3582
3583 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3584
3585         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3586         https://bugs.webkit.org/show_bug.cgi?id=193338
3587         <rdar://problem/46664774>
3588
3589         Reviewed by David Kilzer.
3590
3591         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3592         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3593
3594 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3595
3596         Unreviewed, rolling out r239825.
3597         https://bugs.webkit.org/show_bug.cgi?id=193330
3598
3599         Broke tests on armv7/linux bots (Requested by guijemont on
3600         #webkit).
3601
3602         Reverted changeset:
3603
3604         "Enable DFG on ARM/Linux again"
3605         https://bugs.webkit.org/show_bug.cgi?id=192496
3606         https://trac.webkit.org/changeset/239825
3607
3608 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3609
3610         Disable the run-jsc-stress-test remote host key check.
3611         https://bugs.webkit.org/show_bug.cgi?id=192988
3612
3613         Reviewed by Alexey Proskuryakov.
3614
3615         * Scripts/run-jsc-stress-tests:
3616
3617 2019-01-10  John Wilander  <wilander@apple.com>
3618
3619         Override the session configuration for cookieAcceptPolicy
3620         https://bugs.webkit.org/show_bug.cgi?id=190925
3621         <rdar://problem/45497382>
3622
3623         Reviewed by Alexey Proskuryakov and Alex Christensen.
3624
3625         Test infrastructure for setting a first-party-only cookie policy.
3626
3627         * DumpRenderTree/TestRunner.cpp:
3628         (setOnlyAcceptFirstPartyCookiesCallback):
3629         (TestRunner::staticFunctions):
3630         * DumpRenderTree/TestRunner.h:
3631         * DumpRenderTree/mac/TestRunnerMac.mm:
3632         (TestRunner::setOnlyAcceptFirstPartyCookies):
3633         * DumpRenderTree/win/TestRunnerWin.cpp:
3634         (TestRunner::setOnlyAcceptFirstPartyCookies):
3635         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3636         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3637         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3638         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3639         * WebKitTestRunner/TestInvocation.cpp:
3640         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3641
3642 2019-01-09  Matt Rajca  <mrajca@apple.com>
3643
3644         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
3645         https://bugs.webkit.org/show_bug.cgi?id=193301
3646
3647         Reviewed by Jer Noble.
3648         
3649         Added API tests.
3650
3651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3652         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3653         (TEST):
3654         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
3655
3656 2019-01-10  Zalan Bujtas  <zalan@apple.com>
3657
3658         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
3659         https://bugs.webkit.org/show_bug.cgi?id=193310
3660
3661         Reviewed by Antti Koivisto.
3662
3663         * LayoutReloaded/misc/LFC-passing-tests.txt:
3664
3665 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
3666
3667         Enable DFG on ARM/Linux again
3668         https://bugs.webkit.org/show_bug.cgi?id=192496
3669
3670         Reviewed by Yusuke Suzuki.
3671
3672         After changing the bytecode format DFG was disabled on all 32-bit
3673         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3674         on ARM by default.
3675
3676         * Scripts/run-jsc-stress-tests:
3677
3678 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3679
3680         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
3681         https://bugs.webkit.org/show_bug.cgi?id=193271
3682
3683         Reviewed by Brent Fulgham.
3684
3685         BSTR is a special data structure created by SysAllocString, not a
3686         wchar_t null-terminated string.
3687
3688         * DumpRenderTree/win/TestRunnerWin.cpp:
3689         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
3690         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3691         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
3692         BSTR from wide string literals.
3693
3694 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
3695
3696         Tweak wording for build/version_check style checker error
3697         https://bugs.webkit.org/show_bug.cgi?id=193256
3698
3699         Reviewed by Tim Horton.
3700
3701         * Scripts/webkitpy/style/checkers/cpp.py:
3702         (check_os_version_checks):
3703         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3704         (WebKitStyleTest.test_os_version_checks):
3705
3706 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3707
3708         [ews-build] Add link to bug along with bug title
3709         https://bugs.webkit.org/show_bug.cgi?id=193293
3710
3711         Reviewed by Lucas Forschler.
3712
3713         * BuildSlaveSupport/ews-build/steps.py:
3714         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
3715         (ConfigureBuild.add_bug_id_url): Deleted.
3716         (ConfigureBuild.getBugURL): Deleted.
3717
3718 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3719
3720         [ews-build] Use https for ews-build server
3721         https://bugs.webkit.org/show_bug.cgi?id=193193
3722
3723         Reviewed by Lucas Forschler.
3724
3725         * BuildSlaveSupport/ews-build/steps.py:
3726
3727 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3728
3729         [ews-build] Parse and display number of style failures
3730         https://bugs.webkit.org/show_bug.cgi?id=193280
3731
3732         Reviewed by Lucas Forschler.
3733
3734         * BuildSlaveSupport/ews-build/steps.py:
3735         (CheckStyle): Use TestWithFailureCount as base class.
3736         (CheckStyle.countFailures): Count the number of style failures.
3737
3738 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3739
3740         [ews-build] use patch_id instead of ewspatchid
3741         https://bugs.webkit.org/show_bug.cgi?id=193235
3742
3743         Reviewed by Lucas Forschler.
3744
3745         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
3746         * BuildSlaveSupport/ews-build/steps.py: Ditto.
3747         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
3748
3749 2019-01-09  Zalan Bujtas  <zalan@apple.com>
3750
3751         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
3752         https://bugs.webkit.org/show_bug.cgi?id=192625
3753
3754         Reviewed by Antti Koivisto.
3755
3756         * LayoutReloaded/misc/LFC-passing-tests.txt:
3757
3758 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3759
3760         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
3761         https://bugs.webkit.org/show_bug.cgi?id=192841
3762
3763         Reviewed by Carlos Garcia Campos.
3764
3765         There are separate g_assert_*() macros for use in tests, which we use inconsistently
3766         currently. Use them always. We'll get nicer error messages now when tests fail, and the
3767         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
3768
3769         Note that the documentation of g_assert() says that it is not to be used when writing tests.
3770
3771         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3772         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3773         (WebKitWebEditorTest::testSelectionChanged):
3774         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3775         (WebKitFrameTest::testMainFrame):
3776         (WebKitFrameTest::testURI):
3777         (WebKitFrameTest::testJavaScriptContext):
3778         (WebKitFrameTest::testJavaScriptValues):
3779         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3780         (testWebViewAuthenticationRequest):
3781         (testWebViewAuthenticationLoadCancelled):
3782         (testWebViewAuthenticationFailure):
3783         (testWebViewAuthenticationStorage):
3784         (ProxyAuthenticationTest::ProxyAuthenticationTest):
3785         (testWebViewAuthenticationProxy):
3786         (testWebViewAuthenticationProxyHTTPS):
3787         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3788         (testAutomationSessionRequestSession):
3789         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3790         (testBackForwardListNavigation):
3791         (testWebKitWebViewSessionState):
3792         (testWebKitWebViewSessionStateWithFormData):
3793         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3794         (ConsoleMessageTest::consoleMessageReceivedCallback):
3795         (testWebKitConsoleMessageConsoleAPI):
3796         (testWebKitConsoleMessageJavaScriptException):
3797         (testWebKitConsoleMessageNetworkError):
3798         (testWebKitConsoleMessageSecurityError):
3799         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3800         (testCookieManagerAcceptPolicy):
3801         (testCookieManagerCookiesChanged):
3802         (testCookieManagerPersistentStorage):
3803         (testCookieManagerPersistentStorageDeleteAll):
3804         (testCookieManagerEphemeral):
3805         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
3806         (testWebKitDOMElementAutoFill):
3807         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3808         (downloadLocalFileSuccessfully):
3809         (createFileAtDestination):
3810         (testDownloadOverwriteDestinationDisallowed):
3811         (testDownloadLocalFileError):
3812         (testDownloadRemoteFile):
3813         (testDownloadRemoteFileError):
3814         (testWebViewDownloadURI):
3815         (testPolicyResponseDownload):
3816         (testPolicyResponseDownloadCancel):
3817         (testDownloadMIMEType):
3818         (contextMenuCallback):
3819         (testContextMenuDownloadActions):
3820         (testBlobDownload):
3821         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
3822         (testWebKitWebEditorSelectionChanged):
3823         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3824         (testWebKitFrameMainFrame):
3825         (testWebKitFrameURI):
3826         (testWebKitFrameJavaScriptContext):
3827         (testWebKitFrameJavaScriptValues):
3828         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3829         (LoadStopTrackingTest::loadFailed):
3830         (testWebViewTitle):
3831         (testURIRequestHTTPHeaders):
3832         (testURIRequestHTTPMethod):
3833         (testURIResponseHTTPHeaders):
3834         (testRedirectToDataURI):
3835         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3836         (testProcessPerWebView):
3837         (testWebProcessLimit):
3838         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3839         (testWebViewResources):
3840         (testWebResourceLoading):
3841         (testWebResourceSuggestedFilename):
3842         (testWebResourceGetData):
3843         (testWebResourceGetDataError):
3844         (testWebViewResourcesHistoryCache):
3845         (testWebResourceSendRequest):
3846         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3847         (testSSL):
3848         (testInsecureContent):
3849         (testTLSErrorsPolicy):
3850         (testTLSErrorsRedirect):
3851         (testTLSErrorsHTTPAuth):
3852         (testLoadFailedWithTLSErrors):
3853         (testSubresourceLoadFailedWithTLSErrors):
3854         (httpsServerCallback):
3855         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3856         (testWebViewCreateNavigationData):
3857         (testWebViewJavaScriptDialogs):
3858         (testWebViewWindowProperties):
3859         (testWebViewMouseTarget):
3860         (testWebViewFileChooserRequest):
3861         (testWebViewColorChooserRequest):
3862         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3863         (testWebExtensionGetTitle):
3864         (testDocumentLoadedSignal):
3865         (testWebKitWebViewProcessCrashed):
3866         (testWebExtensionWindowObjectCleared):
3867         (testWebExtensionIsolatedWorld):
3868         (permissionRequestCallback):
3869         (didAssociateFormControlsCallback):
3870         (testWebExtensionFormControlsAssociated):
3871         (FormSubmissionTest::FormSubmissionTest):
3872         (FormSubmissionTest::testFormSubmissionResult):
3873         (testWebExtensionFormSubmissionSteps):
3874         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3875         (testNotInitialized):
3876         (testClearDatabase):
3877         (testPrivateBrowsing):
3878         (testGetFavicon):
3879         (testWebViewFavicon):
3880         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3881         (testFindControllerTextFound):
3882         (testFindControllerTextNotFound):
3883         (testFindControllerMatchCount):
3884         (testFindControllerMaxMatchCount):
3885         (testFindControllerNext):
3886         (testFindControllerPrevious):
3887         (testFindControllerCountedMatches):
3888         (testFindControllerOptions):
3889         (testFindControllerHide):
3890         (testFindControllerInstance):
3891         (testFindControllerGetters):
3892         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
3893         (testNavigationPolicy):
3894         (testResponsePolicy):
3895         (testNewWindowPolicy):
3896         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3897         (testSecurityOriginBasicConstructor):
3898         (testSecurityOriginURIConstructor):
3899         (testSecurityOriginDefaultPort):
3900         (testSecurityOriginFileURI):
3901         (testOpaqueSecurityOrigin):
3902         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3903         (testWebKitSettings):
3904         (testWebKitSettingsNewWithSettings):
3905         (testWebKitSettingsUserAgent):
3906         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3907         (testWebViewNewWithUserContentManager):
3908         (isStyleSheetInjectedForURLAtPath):
3909         (isScriptInjectedForURLAtPath):
3910         (testUserContentManagerInjectedStyleSheet):
3911         (testUserContentManagerInjectedScript):
3912         (UserScriptMessageTest::scriptMessageReceived):
3913         (UserScriptMessageTest::waitUntilMessageReceived):
3914         (UserScriptMessageTest::runJavaScriptFinished):
3915         (testUserContentManagerScriptMessageReceived):
3916         (testUserContentManagerScriptMessageInWorldReceived):
3917         (testUserContentManagerScriptMessageFromDOMBindings):
3918         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3919         (testWebContextDefault):
3920         (testWebContextEphemeral):
3921         (testWebContextGetPlugins):
3922         (testWebContextURIScheme):
3923         (testWebContextSpellChecker):
3924         (testWebContextLanguages):
3925         (consoleMessageReceivedCallback):
3926         (testWebContextSecurityFileXHR):
3927         (ProxyTest::ProxyTest):
3928         (testWebContextProxySettings):
3929         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3930         (testWebViewWebContext):
3931         (testWebViewWebBackend):
3932         (testWebViewEphemeral):
3933         (testWebViewCustomCharset):
3934         (testWebViewSettings):
3935         (testWebViewRunJavaScript):
3936         (testWebViewCanShowMIMEType):
3937         (testWebViewSubmitForm):
3938         (testWebViewSave):
3939         (testWebViewPageVisibility):
3940         (testWebViewSnapshot):
3941         (testWebViewNotification):
3942         (testWebViewNotificationInitialPermissionAllowed):
3943         (testWebViewNotificationInitialPermissionDisallowed):
3944         (testWebViewIsPlayingAudio):
3945         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3946         (WebsiteDataTest::WebsiteDataTest):
3947         (WebsiteDataTest::remove):
3948         (WebsiteDataTest::clear):
3949         (testWebsiteDataConfiguration):
3950         (testWebsiteDataEphemeral):
3951         (testWebsiteDataCache):
3952         (testWebsiteDataStorage):
3953         (testWebsiteDataDatabases):
3954         (testWebsiteDataAppcache):
3955         (testWebsiteDataCookies):
3956         (testWebsiteDataDeviceIdHashSalt):
3957         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3958         (emitDocumentLoaded):
3959         (emitURIChanged):
3960         (sendRequestCallback):
3961         (contextMenuCallback):
3962         (consoleMessageSentCallback):
3963         (emitFormControlsAssociated):
3964         (formControlsAssociatedCallback):
3965         (emitFormSubmissionEvent):
3966         (willSubmitFormCallback):
3967         (windowObjectCleared):
3968         (methodCallCallback):
3969         (registerGResource):
3970         (webkit_web_extension_initialize_with_user_data):
3971         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
3972         (checkLeaks):
3973         (WebProcessTest::create):
3974         (runTest):
3975         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
3976         (AutocleanupsTest::testWebProcessAutocleanups):
3977         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
3978         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
3979         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
3980         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
3981         (WebKitDOMDOMWindowTest::testSignals):
3982         (WebKitDOMDOMWindowTest::testDispatchEvent):
3983         (WebKitDOMDOMWindowTest::testGetComputedStyle):
3984         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
3985         (WebKitDOMNodeFilterTest::testTreeWalker):
3986         (WebKitDOMNodeFilterTest::testNodeIterator):
3987         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
3988         (WebKitDOMNodeTest::testHierarchyNavigation):
3989         (WebKitDOMNodeTest::testInsertion):
3990         (WebKitDOMNodeTest::testTagNamesNodeList):
3991         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
3992         (WebKitDOMNodeTest::testDOMCache):
3993         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
3994         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3995         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3996         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3997         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
3998         (testUIProcessAutocleanups):
3999         (testWebProcessAutocleanups):
4000         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
4001         (testContextMenuPopulateMenu):
4002         (testContextMenuDismissed):
4003         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
4004         (testWebKitDOMClientRectDivBoundingClientRectPosition):
4005         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
4006         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
4007         (testWebKitDOMDOMWindowSignals):
4008         (testWebKitDOMDOMWindowDispatchEvent):
4009         (testWebKitDOMDOMWindowGetComputedStyle):
4010         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
4011         (testWebKitDOMNodeHierarchyNavigation):
4012         (testWebKitDOMNodeInsertion):
4013         (testWebKitDOMNodeTagNamesNodeList):
4014         (testWebKitDOMNodeTagNamesHTMLCollection):
4015         (testWebKitDOMObjectCache):
4016         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
4017         (testWebKitDOMNodeFilterTreeWalker):
4018         (testWebKitDOMNodeFilterNodeIterator):
4019         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
4020         (testWebKitDOMXPathNSResolverNative):
4021         (testWebKitDOMXPathNSResolverCustom):
4022         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
4023         (testInspectorDefault):
4024         (testInspectorManualAttachDetach):
4025         (testInspectorCustomContainerDestroyed):
4026         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
4027         (startTestServer):
4028         (testInspectorServerPageList):
4029         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
4030         (OptionMenuTest::showOptionMenuCallback):
4031         (OptionMenuTest::menuCloseCallback):
4032         (OptionMenuTest::close):
4033         (OptionMenuTest::activateItem):
4034         (OptionMenuTest::selectItem):
4035         (testOptionMenuSimple):
4036         (testOptionMenuGroups):
4037         (testOptionMenuActivate):
4038         (testOptionMenuSelect):
4039         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
4040         (testPrintOperationPrintSettings):
4041         (webViewPrintCallback):
4042         (testPrintOperationPrint):
4043         (testPrintCustomWidget):
4044         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
4045         (checkAtspiAccessible):
4046         (testAtspiBasicHierarchy):
4047         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
4048         (testWebKitCheckVersion):
4049         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
4050         (testWebViewEditorCutCopyPasteNonEditable):
4051         (testWebViewEditorCutCopyPasteEditable):
4052         (testWebViewEditorSelectAllNonEditable):
4053         (testWebViewEditorSelectAllEditable):
4054         (loadContentsAndTryToCutSelection):
4055         (testWebViewEditorNonEditable):
4056         (testWebViewEditorEditable):
4057         (testWebViewEditorEditorStateTypingAttributes):
4058         (testWebViewEditorInsertImage):
4059         (testWebViewEditorCreateLink):
4060         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
4061         (loadChangedCallback):
4062         (loadFailedCallback):
4063         (loadFailedWithTLSErrorsCallback):
4064         (LoadTrackingTest::LoadTrackingTest):
4065         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4066         (registerGResource):
4067         (removeNonEmptyDirectory):
4068         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4069         (Test::adoptView):
4070         (Test::~Test):
4071         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4072         (WebKitTestBus::getOrCreateConnection):
4073         (WebKitTestBus::createProxy):
4074         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
4075         (WebKitTestServer::getWebSocketURIForPath const):
4076         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
4077         (WebViewTest::initializeWebView):
4078         (WebViewTest::loadURI):
4079         (WebViewTest::loadHtml):
4080         (WebViewTest::loadPlainText):
4081         (WebViewTest::loadBytes):
4082         (WebViewTest::loadRequest):
4083         (WebViewTest::loadAlternateHTML):
4084         (WebViewTest::goBack):
4085         (WebViewTest::goForward):
4086         (WebViewTest::goToBackForwardListItem):
4087         (resourceGetDataCallback):
4088         (WebViewTest::mainResourceData):
4089         (WebViewTest::javascriptResultToCString):
4090         (WebViewTest::javascriptResultToNumber):
4091         (WebViewTest::javascriptResultToBoolean):
4092         (WebViewTest::javascriptResultIsNull):
4093         (WebViewTest::javascriptResultIsUndefined):
4094         (onSnapshotReady):
4095         (WebViewTest::runWebProcessTest):
4096         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
4097         (WebViewTest::platformInitializeWebView):
4098         (WebViewTest::showInWindow):
4099         (WebViewTest::showInWindowAndWaitUntilMapped):
4100         (WebViewTest::mouseMoveTo):
4101         (WebViewTest::emitPopupMenuSignal):
4102         (WebViewTest::keyStroke):
4103         (WebViewTest::doMouseButtonEvent):
4104
4105 2019-01-09  Philippe Normand  <pnormand@igalia.com>
4106
4107         [WPE] API tests can't run in flatpak environment
4108         https://bugs.webkit.org/show_bug.cgi?id=193242
4109
4110         Reviewed by Michael Catanzaro.
4111
4112         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
4113         flatpakutils so that it knows which port it's dealing with.
4114         * glib/common.py: Remove build_dir globals so that subsequent
4115         calls actually take args into account.
4116         (library_build_path):
4117         (binary_build_path):
4118
4119 2019-01-08  Dean Jackson  <dino@apple.com>
4120
4121         Blob references for System Previews don't get a correct file extension
4122         https://bugs.webkit.org/show_bug.cgi?id=193268
4123         <rdar://problem/47133037>
4124
4125         Reviewed by Tim Horton.
4126
4127         New test that a Blob download of a USDZ file gets named correctly.
4128
4129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4130         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4131         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4132         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
4133         (TEST):
4134         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
4135
4136 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
4137
4138         [WebAuthN] Support U2F HID Authenticators on macOS
4139         https://bugs.webkit.org/show_bug.cgi?id=191535
4140         <rdar://problem/47102027>
4141
4142         Reviewed by Brent Fulgham.
4143
4144         This patch:
4145         1) adds support for U2F mocking mechanism;
4146         2) updates tests to reflect U2fCommandConstructor changes.
4147
4148         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
4149         (TestWebKitAPI::TEST):
4150         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
4151         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4152         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
4153
4154 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
4155
4156         [iOS] Dispatch a synthetic mousedown event prior to starting drags
4157         https://bugs.webkit.org/show_bug.cgi?id=193229
4158         <rdar://problem/46717097>
4159
4160         Reviewed by Tim Horton.
4161
4162         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
4163         prevents a drag from starting.
4164
4165         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
4166         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
4167
4168         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
4169
4170 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
4171   
4172         Layout test will generate a perf metric file to results dir.
4173         https://bugs.webkit.org/show_bug.cgi?id=192030
4174         <rdar://problem/32779516>
4175
4176         Reviewed by Aakash Jain.
4177
4178         Layout test running time will be collected to a perf metric file.
4179         For now, instead of outputing running time of all tests (which is huge),
4180         we aggregate them by test directories which are at most two level deep. 
4181
4182         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4183         (Manager._end_test_run):
4184         (Manager._output_perf_metrics):
4185         (Manager._print_expectation_line_for_test):
4186         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4187         (add_test_perf_metric):
4188         (test_perf_metrics):
4189         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4190         (JSONGeneratorTest.test_test_timings_trie):
4191         (JSONGeneratorTest):
4192         (JSONGeneratorTest.test_test_perf_metrics):
4193         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4194         (RebaselineTest.test_reset_results):
4195         (RebaselineTest.test_missing_results):
4196         (RebaselineTest.test_new_baseline):
4197
4198 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
4199
4200         [WPE][GTK] Add php-json to install-dependencies
4201         https://bugs.webkit.org/show_bug.cgi?id=193233
4202
4203         Reviewed by Michael Catanzaro.
4204
4205         * gtk/install-dependencies:
4206         * wpe/install-dependencies:
4207
4208 2019-01-08  Chris Dumez  <cdumez@apple.com>
4209
4210         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
4211         https://bugs.webkit.org/show_bug.cgi?id=193224
4212         <rdar://problem/47097726>
4213
4214         Reviewed by Alex Christensen.
4215
4216         Add API test coverage.
4217
4218         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4219
4220 2019-01-07  David Kilzer  <ddkilzer@apple.com>
4221
4222         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
4223         <https://webkit.org/b/193222>
4224         <rdar://problem/46862309>
4225
4226         Reviewed by Joseph Pecoraro.
4227
4228         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4229         (WTR::executeCallback): Fix camel case of variable name.
4230         (WTR::EventSendingController::callAfterScrollingCompletes): If
4231         WKBundlePageRegisterScrollOperationCompletionCallback() returns
4232         false, make sure to release the ScrollCompletionCallbackData
4233         object.  This fixes the leak.
4234
4235 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
4236
4237         [Win] EWS: wincairo-ews cannot apply a patch with *.png
4238         https://bugs.webkit.org/show_bug.cgi?id=193044
4239
4240         Reviewed by Daniel Bates.
4241
4242         WinCairo EWS bots are using Windows Perl. Binary files should be
4243         opened as binary mode.
4244
4245         * Scripts/svn-apply:
4246         (handleGitBinaryChange): Use 'binmode' for binary file handles.
4247
4248 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
4249
4250         [CMake] Add ENABLE_CSS_TYPED_OM option
4251         https://bugs.webkit.org/show_bug.cgi?id=193216
4252
4253         Reviewed by Michael Catanzaro.
4254
4255         * Scripts/webkitperl/FeatureList.pm:
4256
4257 2019-01-07  David Kilzer  <ddkilzer@apple.com>
4258
4259         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
4260         <https://webkit.org/b/193056>
4261
4262         Reviewed by Alex Christensen.
4263
4264         * Scripts/webkitpy/style/checker.py:
4265         - Ignore use of new runtime/retainptr check in
4266           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
4267           contains tests to ensure RetainPtr<NSObject *> is compatible
4268           with RetainPtr<NSObject>.
4269
4270         * Scripts/webkitpy/style/checkers/cpp.py:
4271         (check_language):
4272         (CppChecker):
4273         - Add checker for use of '*' in RetainPtr<> type.  A for loop
4274           was used instead of a single regex so that angle brackets
4275           could be matched up when checking the type contained within
4276           the RetainPtr<> type.
4277
4278         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4279         (CppStyleTest):
4280         - Add unit test for new runtime/retainptr check.
4281
4282         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
4283         * TestWebKitAPI/EditingTestHarness.h:
4284         - Remove '*' from RetainPtr<> type.
4285
4286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4287         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
4288           regressed in r201938.
4289
4290         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
4291         (TestWebKitAPI::TEST):
4292         - Update tests to match RetainPtr.mm tests (except for the
4293           `*SimilarNSType` tests since there is no CF equivalent of
4294           RetainPtr<NSString> and RetainPtr<NSString *>).
4295
4296         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
4297         (TestWebKitAPI::TEST):
4298         - Update tests to:
4299           - Not conflict by name with equivalent CF tests in
4300             RetainPtr.cpp.
4301           - Add test cases for RetainPtr<NSObject>,
4302             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
4303           - Add `*SimilarNSType` tests for converting between
4304             RetainPtr<NSObject> and RetainPtr<NSObject *>.
4305           - Change `0` to `nil` as appropriate.
4306           - Re-alphabetize the tests by name.
4307           - Add Optional<RetainPtr<>> tests.
4308           - Add retainPtr() tests.
4309
4310         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4311         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4312         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
4313         (TEST):
4314         - Remove '*' from RetainPtr<> type.
4315
4316         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
4317         (TEST(WebKit, JITEnabled)):
4318         - Add missing WTFMove().  Apparently a temporary was being
4319           created before in the argument list due to mismatched
4320           RetainPtr<> types.
4321
4322         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4323         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm: