Unreviewed. Fix WPE accessibility tests after r244059.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2
3         Unreviewed. Fix WPE accessibility tests after r244059.
4
5         We are failing to load the injected bundle due to undefined symbol
6         AccessibilityUIElement::replaceTextInRange().
7
8         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
9         (WTR::AccessibilityUIElement::replaceTextInRange):
10
11 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
12
13         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
14         https://bugs.webkit.org/show_bug.cgi?id=196727
15
16         Reviewed by Fujii Hironori.
17
18         * MiniBrowser/win/WebKitBrowserWindow.cpp:
19         (WebKitBrowserWindow::create):
20
21 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
22
23         [ews-build] Add unit tests for PrintConfiguration
24         https://bugs.webkit.org/show_bug.cgi?id=196752
25
26         Reviewed by Dewei Zhu.
27
28         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
29
30 2019-04-09  Keith Rollin  <krollin@apple.com>
31
32         Unreviewed build maintenance -- update .xcfilelists.
33
34         * DumpRenderTree/DerivedSources-input.xcfilelist:
35         * DumpRenderTree/DerivedSources-output.xcfilelist:
36
37 2019-04-09  Zalan Bujtas  <zalan@apple.com>
38
39         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
40         https://bugs.webkit.org/show_bug.cgi?id=196743
41         <rdar://problem/43897551>
42
43         Reviewed by Tim Horton.
44
45         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
46         (TEST):
47
48 2019-04-09  Youenn Fablet  <youenn@apple.com>
49
50         Close service worker database on network process suspension
51         https://bugs.webkit.org/show_bug.cgi?id=196623
52         <rdar://problem/48930869>
53
54         Reviewed by Alex Christensen.
55
56         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
57
58 2019-04-09  Daniel Bates  <dabates@apple.com>
59
60         [iPad] Should open popover when the spacebar is pressed
61         https://bugs.webkit.org/show_bug.cgi?id=196360
62         <rdar://problem/49389129>
63
64         Reviewed by Brent Fulgham.
65
66         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
67
68         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
69         (WTR::UIScriptController::isShowingPopover const): Added.
70         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
71         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
72         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
73         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
74         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
75         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
76         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
77         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
78         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
79         (WTR::UIScriptController::isShowingPopover const): Added.
80         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
81         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
82         * TestRunnerShared/UIScriptContext/UIScriptController.h:
83         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
84         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
85         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
86         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
87         (-[TestRunnerWKWebView _willPresentPopover]): Added.
88         (-[TestRunnerWKWebView _didDismissPopover]): Added.
89         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
90         (WTR::UIScriptController::isShowingPopover const): Added.
91         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
92         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
93
94 2019-04-09  Alex Christensen  <achristensen@webkit.org>
95
96         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
97         https://bugs.webkit.org/show_bug.cgi?id=196665
98         <rdar://45115669>
99
100         Reviewed by Geoff Garen.
101
102         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
103         (goBack):
104         (+[SimpleLookupContext sharedLookupContext]):
105         (-[SimpleLookupContext lookUpURL:completionHandler:]):
106         (TEST):
107         (+[Simple3LookupContext sharedLookupContext]): Deleted.
108         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
109
110 2019-04-09  John Wilander  <wilander@apple.com>
111
112         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
113         https://bugs.webkit.org/show_bug.cgi?id=196558
114         <rdar://problem/47650245>
115
116         Reviewed by Youenn Fablet.
117
118         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
119         (TestWebKitAPI::TEST):
120             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
121
122 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
123
124         [CMake] Apple builds should use ICU_INCLUDE_DIRS
125         https://bugs.webkit.org/show_bug.cgi?id=196720
126
127         Reviewed by Konstantin Tokarev.
128
129         * TestWebKitAPI/PlatformMac.cmake:
130
131 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
132
133         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
134         https://bugs.webkit.org/show_bug.cgi?id=196694
135         <rdar://problem/48388734>
136
137         Rubber-stamped by Aakash Jain.
138
139         * Scripts/webkitpy/port/image_diff.py:
140         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
141         * Scripts/webkitpy/port/server_process.py:
142         (ServerProcess.has_available_stdout): Check if stdout has data in it.
143         (ServerProcess._wait_for_data_and_update_buffers_using_select):
144         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
145         * Scripts/webkitpy/port/server_process_mock.py:
146         (MockServerProcess.has_available_stdout):
147         * Scripts/webkitpy/port/server_process_unittest.py:
148         (TestServerProcess.serial_test_basic):
149
150 2019-04-09  Jer Noble  <jer.noble@apple.com>
151
152         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
153         https://bugs.webkit.org/show_bug.cgi?id=196097
154
155         Reviewed by Eric Carlson.
156
157         Drive-by bug fix: allow tests to play audio without a user gesture by default.
158
159         * DumpRenderTree/mac/DumpRenderTree.mm:
160         (resetWebPreferencesToConsistentValues):
161         * WebKitTestRunner/TestController.cpp:
162         (WTR::TestController::resetPreferencesToConsistentValues):
163
164 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
165
166         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
167         https://bugs.webkit.org/show_bug.cgi?id=196690
168
169         Reviewed by Michael Catanzaro.
170
171         * QueueStatusServer/config/queues.py:
172         * Scripts/webkitpy/common/config/ews.json:
173         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
174         (test_ews_name):
175
176 2019-04-09  Chris Dumez  <cdumez@apple.com>
177
178         Loads using loadHTMLString() cause flashing when process-swapping
179         https://bugs.webkit.org/show_bug.cgi?id=196714
180         <rdar://problem/49637354>
181
182         Reviewed by Antti Koivisto.
183
184         Add API test coverage.
185
186         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
187
188 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
189
190         Unreviewed. Fix ATK accessibility tests after r244059.
191
192         We are failing to load the injected bundle due to undefined symbol
193         AccessibilityUIElement::replaceTextInRange().
194
195         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
196         (WTR::AccessibilityUIElement::replaceTextInRange):
197
198 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
199
200         AX: Support API: accessibilityReplaceRange:withText
201         https://bugs.webkit.org/show_bug.cgi?id=196636
202
203         Unreviewed build fix for Windows port.
204
205         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
206         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
207
208 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
209
210         [CMake][WinCairo] Separate copied headers into different directories
211         https://bugs.webkit.org/show_bug.cgi?id=196655
212
213         Reviewed by Michael Catanzaro.
214
215         * DumpRenderTree/CMakeLists.txt:
216         * MiniBrowser/win/CMakeLists.txt:
217         * TestWebKitAPI/CMakeLists.txt:
218         * TestWebKitAPI/PlatformWin.cmake:
219
220 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
221
222         Log stack-trace for run-webkit-tests when interrupted
223         https://bugs.webkit.org/show_bug.cgi?id=176393
224         <rdar://problem/34262310>
225
226         Reviewed by Lucas Forschler.
227
228         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
229         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
230         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
231         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
232         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
233         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
234         (main): Set handlers to log stack trace on interruption.
235
236 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
237
238         AX: Support API: accessibilityReplaceRange:withText
239         https://bugs.webkit.org/show_bug.cgi?id=196636
240
241         Unreviewed build fix for Windows port.
242
243         * DumpRenderTree/AccessibilityUIElement.cpp:
244         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
245
246 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
247
248         [ews-build] Scripts using Buildbot API have CORS error
249         https://bugs.webkit.org/show_bug.cgi?id=196709
250
251         Reviewed by Alexey Proskuryakov.
252
253         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
254
255 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
256
257         AX: Support API: accessibilityReplaceRange:withText
258         https://bugs.webkit.org/show_bug.cgi?id=196636
259
260         Reviewed by Daniel Bates.
261
262         * DumpRenderTree/AccessibilityUIElement.cpp:
263         (replaceTextInRangeCallback):
264         (AccessibilityUIElement::replaceTextInRange):
265         (AccessibilityUIElement::getJSClass):
266         * DumpRenderTree/AccessibilityUIElement.h:
267         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
268         (AccessibilityUIElement::replaceTextInRange):
269         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
270         (AccessibilityUIElement::replaceTextInRange):
271         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
272         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
273         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
274         (WTR::AccessibilityUIElement::replaceTextInRange):
275         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
276         (WTR::AccessibilityUIElement::replaceTextInRange):
277
278 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
279
280         [iOS] Do not allow starting selection drags when selection views are not visible
281         https://bugs.webkit.org/show_bug.cgi?id=196686
282         <rdar://problem/49399192>
283
284         Reviewed by Tim Horton.
285
286         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
287         also add some new API tests to cover scenarios where the web view is not first responder.
288
289         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
290         (TestWebKitAPI::TEST):
291         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
292
293         Add a switch to optionally make the web view first responder when starting the simulated drag.
294
295         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
296         (-[DragAndDropSimulator initWithWebView:]):
297         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
298
299 2019-04-08  Justin Fan  <justin_fan@apple.com>
300
301         [Web GPU] Fix Web GPU experimental feature on iOS
302         https://bugs.webkit.org/show_bug.cgi?id=196632
303
304         Reviewed by Myles C. Maxfield.
305
306         Properly make Web GPU available on iOS 11+.
307
308         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
309
310 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
311
312         [ews-build] Do not upload archive when Compile Fails
313         https://bugs.webkit.org/show_bug.cgi?id=196674
314
315         Reviewed by Alexey Proskuryakov.
316
317         * BuildSlaveSupport/ews-build/factories.py:
318         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
319         * BuildSlaveSupport/ews-build/steps.py:
320         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
321         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
322         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
323
324 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
325
326         Enable DFG on MIPS
327         https://bugs.webkit.org/show_bug.cgi?id=196689
328
329         Reviewed by Žan Doberšek.
330
331         Since the bytecode change, we enabled the baseline JIT on mips in
332         r240432, but DFG is still missing. With this change, all tests are
333         passing on a ci20 board.
334
335         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
336
337 2019-04-08  Philippe Normand  <pnormand@igalia.com>
338
339         [Flatpak] Second run update-webkitwpe-flatpak fails
340         https://bugs.webkit.org/show_bug.cgi?id=192702
341
342         Reviewed by Carlos Garcia Campos.
343
344         * flatpak/flatpakutils.py:
345         (FlatpakObject.flatpak): Fix typo.
346         (FlatpakPackage.install): When installing, also update to the configured remote commit.
347         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
348
349 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
350
351         [GTK][WPE] outlook.live.com displays old-fashioned UI
352         https://bugs.webkit.org/show_bug.cgi?id=196642
353
354         Reviewed by Carlos Garcia Campos.
355
356         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
357         (TestWebKitAPI::TEST): New Mac platform quirk test.
358
359 2019-04-07  Commit Queue  <commit-queue@webkit.org>
360
361         Unreviewed, rolling out r243956.
362         https://bugs.webkit.org/show_bug.cgi?id=196688
363
364         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
365         by aakashjain on #webkit).
366
367         Reverted changeset:
368
369         "Clicking "Go Back" from a safe browsing warning from an
370         iframe should navigate the WKWebView back to the previous
371         page"
372         https://bugs.webkit.org/show_bug.cgi?id=196665
373         https://trac.webkit.org/changeset/243956
374
375 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
376
377         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
378         https://bugs.webkit.org/show_bug.cgi?id=196669
379
380         Reviewed by Geoffrey Garen.
381
382         Added three new unit tests for WeakHashSet.
383
384         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
385         (WTF_WeakPtr.WeakHashSetConstObjects):
386         (WTF_WeakPtr.WeakHashSetComputesEmpty):
387         (WTF_WeakPtr.WeakHashSetComputeSize):
388
389 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
390
391         Hide next and previous form control buttons when WKWebView is editable
392         https://bugs.webkit.org/show_bug.cgi?id=196672
393         <rdar://problem/35625321>
394
395         Reviewed by Tim Horton.
396
397         Add a new API test.
398
399         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
400         (-[TestWKWebView lastTrailingBarButtonGroup]):
401         (TestWebKitAPI::TEST):
402         * TestWebKitAPI/ios/UIKitSPI.h:
403
404 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
405
406         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
407         https://bugs.webkit.org/show_bug.cgi?id=196077
408         <rdar://problem/49108202>
409
410         Reviewed by Chris Dumez.
411
412         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
413         on new web view.
414
415         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
416
417 2019-04-05  Saam Barati  <sbarati@apple.com>
418
419         Make compare-results understand MotionMark
420         https://bugs.webkit.org/show_bug.cgi?id=196666
421
422         Reviewed by Yusuke Suzuki.
423
424         * Scripts/compare-results:
425         (PLT5Results):
426         (detectMotionMark):
427         (detectMotionMark1_1):
428         (motionMarkResults):
429         (motionMark1_1Results):
430         (detectBenchmark):
431         (biggerIsBetter):
432         (main):
433
434 2019-04-05  Alex Christensen  <achristensen@webkit.org>
435
436         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
437         https://bugs.webkit.org/show_bug.cgi?id=196665
438         <rdar://45115669>
439
440         Reviewed by Geoff Garen.
441
442         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
443         (goBack):
444         (+[SimpleLookupContext sharedLookupContext]):
445         (-[SimpleLookupContext lookUpURL:completionHandler:]):
446         (TEST):
447         (+[Simple3LookupContext sharedLookupContext]): Deleted.
448         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
449
450 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
451
452         [ews-build] Add configuration and architecture for windows builders
453         https://bugs.webkit.org/show_bug.cgi?id=196660
454
455         Reviewed by Lucas Forschler.
456
457         * BuildSlaveSupport/ews-build/config.json:
458
459 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
460
461         webkitpy: Don't run subsequent rounds if interrupted
462         https://bugs.webkit.org/show_bug.cgi?id=196646
463
464         Reviewed by Aakash Jain.
465
466         * Scripts/webkitpy/layout_tests/controllers/manager.py:
467         (Manager.run): Bail out if interrupted.
468
469 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
470
471         Test sessionStorage in PSON private browsing mode
472         https://bugs.webkit.org/show_bug.cgi?id=196561
473
474         Reviewed by Alex Christensen.
475
476         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
477
478 2019-04-05  Commit Queue  <commit-queue@webkit.org>
479
480         Unreviewed, rolling out r243833.
481         https://bugs.webkit.org/show_bug.cgi?id=196645
482
483         This change breaks build of WPE and GTK ports (Requested by
484         annulen on #webkit).
485
486         Reverted changeset:
487
488         "[CMake][WTF] Mirror XCode header directories"
489         https://bugs.webkit.org/show_bug.cgi?id=191662
490         https://trac.webkit.org/changeset/243833
491
492 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
493
494         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
495         https://bugs.webkit.org/show_bug.cgi?id=196635
496
497         Reviewed by Antti Koivisto.
498         
499         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
500         for a test to enable async frame scrolling via:
501             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
502         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
503         
504         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
505
506         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
507         (WTR::InjectedBundle::beginTesting):
508         * WebKitTestRunner/TestController.cpp:
509         (WTR::TestController::resetPreferencesToConsistentValues):
510
511 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
512
513         Use a correct LC_RPATH when building with ASan
514         https://bugs.webkit.org/show_bug.cgi?id=196576
515
516         Reviewed by David Kilzer.
517
518         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
519         so that ../Frameworks is checked. This is simpler and more reliable than updating
520         each SPC service xcconfig.
521
522 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
523
524         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
525         https://bugs.webkit.org/show_bug.cgi?id=196629
526
527         Reviewed by Lucas Forschler.
528
529         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
530
531 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
532
533         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
534         https://bugs.webkit.org/show_bug.cgi?id=196618
535
536         Reviewed by Lucas Forschler.
537
538         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
539         (StatusBubble): Added QUEUE_TRIGGERS.
540         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
541         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
542         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
543         its parent(builder).
544
545 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
546
547         [ews-app] Status-bubble steps are sometimes displayed in reverse order
548         https://bugs.webkit.org/show_bug.cgi?id=196625
549
550         Reviewed by Lucas Forschler.
551
552         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
553         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
554
555 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
556
557         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
558         https://bugs.webkit.org/show_bug.cgi?id=196630
559
560         Reviewed by Wenson Hsieh.
561
562         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
563
564 2019-04-04  Youenn Fablet  <youenn@apple.com>
565
566         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
567         https://bugs.webkit.org/show_bug.cgi?id=196543
568
569         Reviewed by Alex Christensen.
570
571         * WebKitTestRunner/TestController.cpp:
572         (WTR::TestController::generatePageConfiguration):
573
574 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
575
576         [ews-app] Status bubble should not display skipped buildbot steps
577         https://bugs.webkit.org/show_bug.cgi?id=196584
578
579         Reviewed by Lucas Forschler.
580
581         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
582
583 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
584
585         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
586         https://bugs.webkit.org/show_bug.cgi?id=196620
587
588         Reviewed by Lucas Forschler.
589
590         * BuildSlaveSupport/ews-app/ews/config.py:
591
592 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
593
594         [Win] DumpRenderTreeWatchDog.py is not checked into source
595         https://bugs.webkit.org/show_bug.cgi?id=196567
596         <rdar://problem/49525901>
597
598         Reviewed by Lucas Forschler.
599
600         This script is used on Win EWS bots to terminate hanging DRT processes.
601
602         * EWSTools/dumprendertreewatchdog.py: Added.
603
604 2019-04-04  Chris Dumez  <cdumez@apple.com>
605
606         Unreviewed, roll out r243858 which made tests time out.
607
608         Disable new API tests on Windows instead.
609
610         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
611         (TestWebKitAPI::TEST):
612
613 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
614
615         [ATK] Cleanup WebPageAccessibilityObjectAtk
616         https://bugs.webkit.org/show_bug.cgi?id=196537
617
618         Reviewed by Michael Catanzaro.
619
620         Also consider files under atk directories as exceptions for GObject conventions.
621
622         * Scripts/webkitpy/style/checkers/cpp.py:
623         (check_identifier_name_in_declaration):
624
625 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
626
627         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
628         https://bugs.webkit.org/show_bug.cgi?id=196588
629         <rdar://problem/49365787>
630
631         Unreviewed build fix for Windows port.
632
633         error C3861: 'kill': identifier not found
634
635         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
636         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
637
638 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
639
640         [ews-build] Cancel build and similar operations should have authentication
641         https://bugs.webkit.org/show_bug.cgi?id=196520
642
643         Reviewed by Dewei Zhu.
644
645         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
646         environment variables.
647
648 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
649
650         [ews-build] Do not trigger queues which are not in production yet
651         https://bugs.webkit.org/show_bug.cgi?id=196581
652
653         Reviewed by Dewei Zhu.
654
655         * BuildSlaveSupport/ews-build/config.json:
656
657 2019-04-03  Chris Dumez  <cdumez@apple.com>
658
659         Unreviewed, fix typo in the name of API test added in r243848.
660
661         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
662         (TestWebKitAPI::TEST):
663
664 2019-04-03  Chris Dumez  <cdumez@apple.com>
665
666         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
667         https://bugs.webkit.org/show_bug.cgi?id=196588
668         <rdar://problem/49365787>
669
670         Reviewed by Ryosuke Niwa.
671
672         Add API test coverage.
673
674         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
675         (TestWebKitAPI::nullJavaScriptCallback):
676         (TestWebKitAPI::didCrashCheckFrames):
677         (TestWebKitAPI::TEST):
678
679 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
680
681         run-webkit-tests: Upload test results (new results database)
682         https://bugs.webkit.org/show_bug.cgi?id=196577
683         <rdar://problem/34841155>
684
685         Reviewed by Lucas Forschler.
686
687         * Scripts/webkitpy/layout_tests/controllers/manager.py:
688         (Manager.run): Upload results after each device shard, since the configuration will be
689         different for each device.
690         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
691         uploaded to a results database.
692         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
693         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
694
695 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
696
697         -apple-trailing-word is needed for browser detection
698         https://bugs.webkit.org/show_bug.cgi?id=196575
699
700         Unreviewed.
701
702         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
703
704 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
705
706         [CMake][WTF] Mirror XCode header directories
707         https://bugs.webkit.org/show_bug.cgi?id=191662
708
709         Reviewed by Konstantin Tokarev.
710
711         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
712         builds.
713
714         * CMakeLists.txt:
715         * DumpRenderTree/CMakeLists.txt:
716         * DumpRenderTree/PlatformWin.cmake:
717         * MiniBrowser/win/CMakeLists.txt:
718         * TestWebKitAPI/CMakeLists.txt:
719         * TestWebKitAPI/PlatformWin.cmake:
720         * WebKitTestRunner/PlatformGTK.cmake:
721         * WebKitTestRunner/PlatformWin.cmake:
722
723 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
724
725         [ews-app] Status bubble should not display certain infrastructure status messages
726         https://bugs.webkit.org/show_bug.cgi?id=196550
727
728         Reviewed by Lucas Forschler.
729
730         Do not display the steps which are un-needed for end-user. This information is still avaiable
731         if the user click on the bubble and look at the Buildbot build.
732         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
733         (StatusBubble._steps_messages):
734         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
735
736 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
737
738         [ews-build] Use https for sending data to ews-app
739         https://bugs.webkit.org/show_bug.cgi?id=196492
740
741         Reviewed by Lucas Forschler.
742
743         * BuildSlaveSupport/ews-build/events.py:
744
745 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
746
747         Remove support for -apple-trailing-word
748         https://bugs.webkit.org/show_bug.cgi?id=196525
749
750         Reviewed by Zalan Bujtas.
751
752         This CSS property is nonstandard and not used.
753
754         * Scripts/webkitperl/FeatureList.pm:
755         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
756
757 2019-04-03  Youenn Fablet  <youenn@apple.com>
758
759         Add a test for DOMCache on multiple browsing in case of private browsing
760         https://bugs.webkit.org/show_bug.cgi?id=196524
761
762         Reviewed by Alex Christensen.
763
764         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
765         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
766
767 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
768
769         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
770         https://bugs.webkit.org/show_bug.cgi?id=196540
771
772         Reviewed by Aakash Jain.
773
774         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
775
776 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
777
778         Add plumbing for a compatibility mode preference in WebKit
779         https://bugs.webkit.org/show_bug.cgi?id=196005
780
781         Reviewed by Tim Horton.
782
783         Add new API tests.
784
785         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
786         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
787
788 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
789
790         [WPE][GTK] Update libsrtp dependency package for Debian
791         https://bugs.webkit.org/show_bug.cgi?id=196528
792
793         Reviewed by Frédéric Wang.
794
795         * gtk/install-dependencies:
796         * wpe/install-dependencies:
797
798 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
799
800         [WK2] Add support for Window's beforeprint / afterprint events
801         https://bugs.webkit.org/show_bug.cgi?id=196478
802         <rdar://problem/49535124>
803
804         Unreviewed build fix for MSVC.
805
806         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
807
808         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
809
810         * WebKitTestRunner/TestController.cpp:
811         (WTR::printFrame): Use int and float literals.
812
813 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
814
815         [ews-build] Reassign bots to queues
816
817         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
818
819 2019-04-02  Chris Dumez  <cdumez@apple.com>
820
821         [WK2] Add support for Window's beforeprint / afterprint events
822         https://bugs.webkit.org/show_bug.cgi?id=196478
823
824         Reviewed by Alex Christensen.
825
826         Add minimal implementation for printFrame in WebKitTestRunner.
827
828         * WebKitTestRunner/TestController.cpp:
829         (WTR::printFrame):
830         (WTR::TestController::createOtherPage):
831         (WTR::TestController::createWebViewWithOptions):
832
833 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
834
835         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
836         https://bugs.webkit.org/show_bug.cgi?id=196491
837
838         Reviewed by Lucas Forschler.
839
840         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
841
842 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
843
844         [ews-build] Configure buildbot try credentials in environment variables
845         https://bugs.webkit.org/show_bug.cgi?id=196501
846
847         Reviewed by Lucas Forschler.
848
849         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
850         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
851         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
852
853 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
854
855         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
856         https://bugs.webkit.org/show_bug.cgi?id=196496
857         <rdar://problem/49521634>
858
859         Reviewed by Chris Dumez.
860
861         Add new API tests (see WebKit ChangeLog for more detail).
862
863         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
864         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
865         (TEST):
866
867 2019-04-02  David Kilzer  <ddkilzer@apple.com>
868
869         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
870         <https://webkit.org/b/196499>
871
872         Reviewed by Alexey Proskuryakov.
873
874         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
875         ENABLE_ADDRESS_SANITIZER.
876
877 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
878
879         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
880         https://bugs.webkit.org/show_bug.cgi?id=182757
881
882         Reviewed by Don Olmstead.
883
884         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
885         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
886
887 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
888
889         run-api-tests: Upload test results
890         https://bugs.webkit.org/show_bug.cgi?id=196323
891         <rdar://problem/49356714>
892
893         Reviewed by Lucas Forschler.
894
895         * Scripts/webkitpy/api_tests/manager.py:
896         (Manager):
897         (Manager.run): Upload results to a results database.
898         * Scripts/webkitpy/api_tests/run_api_tests.py:
899         (parse_args): Add upload arguments.
900         * Scripts/webkitpy/port/base.py:
901         (Port):
902         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
903         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
904         with commits from any other associated repositories.
905         * Scripts/webkitpy/port/device.py:
906         (Device):
907         (Device.build_version): Access build_versoin of underlying platform device.
908         * Scripts/webkitpy/port/ios_simulator_unittest.py:
909         (IOSSimulatorTest):
910         (IOSSimulatorTest.test_configuration_for_upload):
911         * Scripts/webkitpy/port/device_port.py:
912         (DevicePort):
913         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
914         the same as the machine uploading results.
915         * Scripts/webkitpy/port/mac.py:
916         (MacPort):
917         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
918         * Scripts/webkitpy/port/mac_unittest.py:
919         (MacTest):
920         (MacTest.test_configuration_for_upload):
921         * Scripts/webkitpy/xcode/simulated_device.py:
922         (SimulatedDeviceManager._create_device_with_runtime):
923         (SimulatedDevice.__init__): Create simulated device with a build_version.
924         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
925         (test_existing_simulator):
926
927 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
928
929         Remove extra newline characters (Follow-up fix to r243707)
930
931         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
932
933 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
934
935         [ews-app] Use API_KEY to accept results data
936         https://bugs.webkit.org/show_bug.cgi?id=196461
937
938         Reviewed by Dewei Zhu.
939
940         * BuildSlaveSupport/ews-app/ews/views/results.py:
941         (Results.post): Validate EWS_API_KEY before accepting any data.
942         * BuildSlaveSupport/ews-build/events.py:
943         (Events.sendData): Send EWS_API_KEY if available along with event data.
944
945 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
946
947         Unable to copy and paste a PDF from Notes into Mail compose body
948         https://bugs.webkit.org/show_bug.cgi?id=196442
949         <rdar://problem/48573098>
950
951         Reviewed by Tim Horton.
952
953         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
954         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
955         to be specified on the item providers.
956
957         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
958         (TestWebKitAPI::mapItemForTesting):
959         (TestWebKitAPI::contactItemForTesting):
960
961 2019-04-01  Tim Horton  <timothy_horton@apple.com>
962
963         Make UIWKDocumentContext rects per-character instead of per-word
964         https://bugs.webkit.org/show_bug.cgi?id=196459
965
966         Reviewed by Wenson Hsieh.
967
968         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
969         (TEST):
970         Adjust test results due to switching to per-character rects.
971
972 2019-04-01  Chris Dumez  <cdumez@apple.com>
973
974         UIProcess crash when a prewarmed process is terminated
975         https://bugs.webkit.org/show_bug.cgi?id=196451
976         <rdar://problem/49245471>
977
978         Reviewed by Geoffrey Garen.
979
980         Add API test coverage.
981
982         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
983         (TEST):
984
985 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
986
987         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
988         https://bugs.webkit.org/show_bug.cgi?id=196449
989
990         Reviewed by Lucas Forschler.
991
992         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
993         (StatusBubble.get_os_details): Method to get OS and Xcode details.
994         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
995         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
996
997 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
998
999         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1000         https://bugs.webkit.org/show_bug.cgi?id=196444
1001
1002         Reviewed by Lucas Forschler.
1003
1004         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1005
1006 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1007
1008         Add SPI to canonicalize NSURLs with WTF::URL
1009         https://bugs.webkit.org/show_bug.cgi?id=196415
1010         <rdar://problem/44980271>
1011
1012         Reviewed by Darin Adler.
1013
1014         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1015         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1016         (TestWebKitAPI::TEST):
1017
1018 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1019
1020         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1021         https://bugs.webkit.org/show_bug.cgi?id=196441
1022
1023         Reviewed by Carlos Garcia Campos.
1024
1025         Don't cache the wpe_view_backend object that might not exist yet at the
1026         time of EventSenderProxy constructor invocation, but instead retrieve
1027         that object whenever it's required for event dispatching. This should
1028         avoid crashes in this constructor now that it's invoked before any
1029         PlatformWindow has been set up (as changed in r243496).
1030
1031         * WebKitTestRunner/EventSenderProxy.h:
1032         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1033         (WTR::viewBackend):
1034         (WTR::EventSenderProxy::EventSenderProxy):
1035         (WTR::EventSenderProxy::mouseDown):
1036         (WTR::EventSenderProxy::mouseUp):
1037         (WTR::EventSenderProxy::mouseMoveTo):
1038         (WTR::EventSenderProxy::mouseScrollBy):
1039         (WTR::EventSenderProxy::keyDown):
1040         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1041
1042 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1043
1044         [Win][WebKit] MiniBrowser should support high DPI display
1045         https://bugs.webkit.org/show_bug.cgi?id=196391
1046
1047         Reviewed by Alex Christensen.
1048
1049         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1050         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1051         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1052         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1053
1054 2019-03-31  Sam Weinig  <weinig@apple.com>
1055
1056         Remove more i386 specific configurations
1057         https://bugs.webkit.org/show_bug.cgi?id=196430
1058
1059         Reviewed by Alexey Proskuryakov.
1060
1061         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1062         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1063
1064 2019-03-31  Andy Estes  <aestes@apple.com>
1065
1066         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1067         https://bugs.webkit.org/show_bug.cgi?id=196433
1068         <rdar://problem/49293305>
1069
1070         Reviewed by Tim Horton.
1071
1072         Enhanced API test coverage to include all navigation response policy decisions in both
1073         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1074
1075         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1076         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1077         (TestWebKitAPI::TEST):
1078         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1079         (readFile):
1080         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1081         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1082         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1083         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1084         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1085         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1086         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1087         (-[QuickLookDelegate _downloadDidStart:]):
1088         (-[QuickLookDelegate _download:didReceiveResponse:]):
1089         (-[QuickLookDelegate _download:didReceiveData:]):
1090         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1091         (-[QuickLookDelegate _downloadDidFinish:]):
1092         (-[QuickLookDelegate _download:didFailWithError:]):
1093         (-[QuickLookDelegate _downloadDidCancel:]):
1094         (-[QuickLookDelegate verifyDownload]):
1095         (runTest):
1096         (runTestDecideBeforeLoading):
1097         (runTestDecideAfterLoading):
1098         (TEST):
1099         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1100         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1101         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1102         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1103         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1104         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1105         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1106         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1107         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1108         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1109         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1110         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1111         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1112         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1113
1114 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1115
1116         [CMake] add testdfg as target with build-jsc
1117         https://bugs.webkit.org/show_bug.cgi?id=196393
1118
1119         Reviewed by Saam Barati.
1120
1121         Added testdfg as one of the targets to build when
1122         using CMake.
1123
1124         * Scripts/build-jsc:
1125
1126 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1127
1128         Delete WebMetal implementation in favor of WebGPU
1129         https://bugs.webkit.org/show_bug.cgi?id=195418
1130
1131         Reviewed by Dean Jackson.
1132
1133         * DumpRenderTree/mac/DumpRenderTree.mm:
1134         (enableExperimentalFeatures):
1135         (resetWebPreferencesToConsistentValues):
1136         * Scripts/webkitperl/FeatureList.pm:
1137         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1139         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1140         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1141         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1142         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1143         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1144         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1145         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1146         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1147         (WTR::InjectedBundle::beginTesting):
1148         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1149         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1150         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1151
1152 2019-03-29  Chris Dumez  <cdumez@apple.com>
1153
1154         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1155         https://bugs.webkit.org/show_bug.cgi?id=196405
1156         <rdar://problem/49428130>
1157
1158         Reviewed by Wenson Hsieh.
1159
1160         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1161         the popover presentation methods to be no-ops. Use this in the new test added in
1162         r243523 so that we do not swizzle those methods for all tests. This is needed because
1163         those WatchOS tests rely on the popover getting presented and interactive.
1164
1165         * WebKitTestRunner/TestController.cpp:
1166         (WTR::updateTestOptionsFromTestHeader):
1167         * WebKitTestRunner/TestController.h:
1168         * WebKitTestRunner/TestOptions.h:
1169         (WTR::TestOptions::hasSameInitializationOptions const):
1170         * WebKitTestRunner/ios/TestControllerIOS.mm:
1171         (WTR::TestController::platformInitialize):
1172         (WTR::TestController::platformResetStateToConsistentValues):
1173
1174 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1175
1176         [Curl] Add Server Trust Evaluation Support.
1177         https://bugs.webkit.org/show_bug.cgi?id=191646
1178
1179         Reviewed by Fujii Hironori.
1180
1181         Implemented MiniBrowser UI for asking if user trusts the server.
1182
1183         * MiniBrowser/win/Common.cpp:
1184         (askServerTrustEvaluation):
1185         (replaceString):
1186         * MiniBrowser/win/Common.h:
1187         * MiniBrowser/win/MiniBrowserLib.rc:
1188         * MiniBrowser/win/MiniBrowserLibResource.h:
1189         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1190         (createPEMString):
1191         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1192         (WebKitBrowserWindow::canTrustServerCertificate):
1193         * MiniBrowser/win/WebKitBrowserWindow.h:
1194
1195 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1196
1197         Implement ResizeObserver.
1198         https://bugs.webkit.org/show_bug.cgi?id=157743
1199
1200         Reviewed by Simon Fraser.
1201
1202         Support resizeObserverEnabled webPreferences.
1203
1204         * DumpRenderTree/TestOptions.cpp:
1205         (TestOptions::TestOptions):
1206         * DumpRenderTree/TestOptions.h:
1207         * DumpRenderTree/mac/DumpRenderTree.mm:
1208         (setWebPreferencesForTestOptions):
1209         * DumpRenderTree/win/DumpRenderTree.cpp:
1210         (enableExperimentalFeatures):
1211         * Scripts/webkitperl/FeatureList.pm:
1212         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1213
1214 2019-03-28  John Wilander  <wilander@apple.com>
1215
1216         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1217         https://bugs.webkit.org/show_bug.cgi?id=196281
1218         <rdar://problem/48938748>
1219
1220         Reviewed by Alex Christensen.
1221
1222         This patch adds the function isStatisticsHasLocalStorage() to the
1223         TestRunner. With it, the page can query the WebsiteDataStore in the
1224         UI process to make sure that it sees LocalStorage.
1225
1226         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1227         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1228         (WTR::TestRunner::isStatisticsHasLocalStorage):
1229         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1230         * WebKitTestRunner/TestController.cpp:
1231         (WTR::TestController::isStatisticsHasLocalStorage):
1232         * WebKitTestRunner/TestController.h:
1233         * WebKitTestRunner/TestInvocation.cpp:
1234         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1235
1236 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1237
1238         API::Data::createWithoutCopying should do a null check before calling CFRelease
1239         https://bugs.webkit.org/show_bug.cgi?id=196276
1240         <rdar://problem/48059859>
1241
1242         Reviewed by Alex Christensen.
1243
1244         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1245
1246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1247         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1248         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1249         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1250         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1251         (TestWebKitAPI::TEST):
1252
1253 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1254
1255         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1256         https://bugs.webkit.org/show_bug.cgi?id=186276
1257
1258         Reviewed by Carlos Garcia Campos.
1259
1260         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1261         (webViewLoadChanged):
1262         (testWebResourceGetDataError):
1263         (testWebResourceGetDataEmpty):
1264         (beforeAll):
1265         (webViewloadChanged): Deleted.
1266
1267 2019-03-27  Andy Estes  <aestes@apple.com>
1268
1269         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1270         https://bugs.webkit.org/show_bug.cgi?id=196317
1271
1272         Reviewed by Dan Bernstein.
1273
1274         package-root copies built products into a staging directory using ditto(1), which does not
1275         follow symbolic links as it traverses a directory. Now that the files in
1276         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1277         itself, these become broken links when ditto'd into the staging directory.
1278
1279         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1280
1281         * Scripts/package-root:
1282
1283 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1284
1285         [ews-app] Update display text of Submit for ews analysis
1286         https://bugs.webkit.org/show_bug.cgi?id=196309
1287
1288         Reviewed by Dewei Zhu.
1289
1290         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1291
1292 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1293
1294         run-webkit-tests should check for leaks in WebKit processes
1295         <https://webkit.org/b/193772>
1296         <rdar://problem/46526680>
1297
1298         Reviewed by Ryosuke Niwa.
1299
1300         This works by doing the following:
1301         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1302           The list of child processes are returned one per line:
1303           process.name: pid
1304         - Run the "#LIST CHILD PROCESSES" command just before the
1305           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1306           processes on the ServerProcess object.
1307         - When the `--leaks` switch is handled, run check_for_leaks() on
1308           each child process after the main test harness.
1309
1310         * DumpRenderTree/mac/DumpRenderTree.mm:
1311         (handleControlCommand):
1312         - Use strncmp() instead of strcmp().
1313         - Add support for handling "#LIST CHILD PROCESSES" command.
1314
1315         * Scripts/webkitpy/port/base.py:
1316         (Port.check_for_leaks):
1317         * Scripts/webkitpy/port/darwin.py:
1318         (DarwinPort.check_for_leaks):
1319         - Rename redundant 'process_pid' argument to 'process_id'.
1320
1321         * Scripts/webkitpy/port/driver.py:
1322         (Driver.do_post_tests_work):
1323         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1324           longer the only command this sends to WebKitTestRunner.
1325         - If the `--leaks` switch is present, send the
1326           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1327           result using Port.set_webkit_processes().
1328         (Driver._parse_child_processes_output):
1329         - Add helper method to parse list of child process names and
1330           process IDs returned from WebKitTestRunner.
1331
1332         * Scripts/webkitpy/port/ios_device.py:
1333         (IOSDevicePort.check_for_leaks):
1334         - Rename redundant 'process_pid' argument to 'process_id'.
1335
1336         * Scripts/webkitpy/port/leakdetector.py:
1337         (LeakDetector._parse_leaks_output):
1338         - Return early if there is no leaks_output.
1339         (LeakDetector.check_for_leaks):
1340         - Rename redundant 'process_pid' argument to 'process_id'.
1341
1342         * Scripts/webkitpy/port/server_process.py:
1343         (ServerProcess.__init__):
1344         (ServerProcess.child_processes):
1345         (ServerProcess.set_child_processes):
1346         - Add instance variable to Port to store list of child process
1347           names and process IDs returned from WebKitTestRunner.
1348         (ServerProcess._start):
1349         - Clear self._child_processes.
1350         (ServerProcess.stop):
1351         - If self._child_processes is set, call
1352           self._port.check_for_leaks() for each child process.
1353
1354         * Scripts/webkitpy/port/server_process_unittest.py:
1355         (TrivialMockPort.check_for_leaks):
1356         - Rename redundant 'process_pid' argument to 'process_id'.
1357
1358         * Scripts/webkitpy/port/simulator_process.py:
1359         (SimulatorProcess.stop):
1360         - If self._child_processes is set, call
1361           self._port.check_for_leaks() for each child process.
1362
1363         * Scripts/webkitpy/port/watch_device.py:
1364         (WatchDevicePort.check_for_leaks):
1365         - Rename redundant 'process_pid' argument to 'process_id'.
1366
1367         * WebKitTestRunner/TestController.cpp:
1368         (WTR::TestController::dumpResponse):
1369         - Extract method from findAndDumpWorldLeaks() so that it may be
1370           reused by findAndDumpWebKitProcessIdentifiers().
1371         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1372         - Add method to output process name and process ID of both the
1373           WebContent and Networking processes.
1374         (WTR::TestController::findAndDumpWorldLeaks):
1375         - Fix missing newline in output when there were no abandoned
1376           documents.
1377         - Call dumpResponse() for extracted code.
1378         (WTR::TestController::handleControlCommand):
1379         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1380         - Use strncmp() instead of strcmp().
1381         - Call findAndDumpWebKitProcessIdentifiers() when
1382           "#LIST CHILD PROCESSES" command is sent.
1383         * WebKitTestRunner/TestController.h:
1384         (WTR::TestController::dumpResponse):
1385         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1386         - Declare methods.
1387
1388 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1389
1390         Unreviewed. Add GLib API test cases after r243434.
1391
1392         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1393         (testWebViewActiveURI):
1394         (serverCallback):
1395         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1396         (sendRequestCallback):
1397
1398 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1399
1400         Geolocation request not complete when watch request was started in a different web process
1401         https://bugs.webkit.org/show_bug.cgi?id=195996
1402
1403         Reviewed by Alex Christensen.
1404
1405         Add a test case.
1406
1407         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1408         (TestWebKitAPI::runJavaScriptAlert):
1409         (TestWebKitAPI::TEST):
1410
1411 2019-03-26  Keith Rollin  <krollin@apple.com>
1412
1413         Update the way generate-xcfilelists returns strings from functions
1414         https://bugs.webkit.org/show_bug.cgi?id=195975
1415         <rdar://problem/49040807>
1416
1417         Reviewed by Dean Jackson.
1418
1419         There are places where generate-xcfilelists executes assignments with
1420         statements like:
1421
1422             FOO=$(some_function)
1423
1424         where "some_function" return a string by echoing it. E.g.
1425
1426             some_function()
1427             {
1428                 echo "Hello, World"
1429             }
1430
1431         This is a common idiom, but it has a problem if "some_function" needs
1432         to call "exit" in an attempt to halt the entire script right then and
1433         there. Since "some_function" is called inside of $(), it's being
1434         executed in a sub-shell. Calling exit in that sub-shell simply exits
1435         that shell; it doesn't not exit the outer shell in which the main part
1436         of the script is still running. As such, the main script keeps
1437         executing when the intent was for the script to halt.
1438
1439         The solution to this is to use a different idiom for returning
1440         strings. The one we now is to pass in the name of the variable to
1441         receive the string result:
1442
1443             some_function()
1444             {
1445                 variable_name=$1
1446                 eval $variable_name ="Hello, World"
1447             }
1448
1449         The call site now looks like
1450
1451             some_function FOO
1452
1453         Because there's no invocation of a sub-shell, some_function can now
1454         call "exit" if it wants to, and the entire script will exit at that
1455         point.
1456
1457         * Scripts/generate-xcfilelists:
1458
1459 2019-03-26  Chris Dumez  <cdumez@apple.com>
1460
1461         Add basic layout test coverage for File Picker on iOS
1462         https://bugs.webkit.org/show_bug.cgi?id=196265
1463
1464         Reviewed by Wenson Hsieh.
1465
1466         Add layout test infrastructure to test the file picker on iOS.
1467
1468         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1469         (WTR::UIScriptController::dismissFilePicker):
1470         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1471         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1472         (WTR::UIScriptController::dismissFilePicker):
1473         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1474         * WebKitTestRunner/TestController.cpp:
1475         (WTR::TestController::createWebViewWithOptions):
1476         (WTR::updateTestOptionsFromTestHeader):
1477         * WebKitTestRunner/TestOptions.h:
1478         (WTR::TestOptions::hasSameInitializationOptions const):
1479         * WebKitTestRunner/ios/TestControllerIOS.mm:
1480         (overridePresentViewController):
1481         (WTR::TestController::platformInitialize):
1482         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1483         (WTR::UIScriptController::dismissFilePicker):
1484
1485 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1486
1487         Implement async paste method on UIWKInteractionViewProtocol
1488         https://bugs.webkit.org/show_bug.cgi?id=196267
1489         <rdar://problem/49236346>
1490
1491         Reviewed by Tim Horton.
1492
1493         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1494         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1495         are now a part of all iOS 12 internal SDKs.
1496
1497         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1498
1499         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1500         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1501
1502         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1503         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1504         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1505         * TestWebKitAPI/ios/UIKitSPI.h:
1506
1507 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1508
1509         [ews-build] Use PostgreSQL for ews.webkit.org database
1510         https://bugs.webkit.org/show_bug.cgi?id=196270
1511
1512         Reviewed by Lucas Forschler.
1513
1514         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1515
1516 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1517
1518         [ews] Reset simctl states on reboot
1519         https://bugs.webkit.org/show_bug.cgi?id=196260
1520
1521         Rubber-stamped by Aakash Jain.
1522
1523         * EWSTools/start-queue-mac.sh:
1524
1525 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1526
1527         [ews-build] Use PostgreSQL for ews-build database
1528         https://bugs.webkit.org/show_bug.cgi?id=196229
1529
1530         Reviewed by Lucas Forschler.
1531
1532         * BuildSlaveSupport/ews-build/master.cfg:
1533
1534 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1535
1536         [ews-build] Get master_hostname dynamically in master.cfg
1537         https://bugs.webkit.org/show_bug.cgi?id=196255
1538
1539         Reviewed by Lucas Forschler.
1540
1541         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1542         send events data in test mode.
1543
1544 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1545
1546         [ews-app] Set db_constraint to False for Foreign Keys
1547         https://bugs.webkit.org/show_bug.cgi?id=196252
1548
1549         Reviewed by Lucas Forschler.
1550
1551         * BuildSlaveSupport/ews-app/ews/models/build.py:
1552         * BuildSlaveSupport/ews-app/ews/models/step.py:
1553
1554 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1555
1556         [ews-build] is_test_mode_enabled should default to True
1557         https://bugs.webkit.org/show_bug.cgi?id=196248
1558
1559         Reviewed by Lucas Forschler.
1560
1561         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1562
1563 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1564
1565         [ews-app] Add webkitperl to ENABLED_QUEUES
1566         https://bugs.webkit.org/show_bug.cgi?id=196253
1567
1568         Reviewed by Lucas Forschler.
1569
1570         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1571
1572 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1573
1574         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1575         https://bugs.webkit.org/show_bug.cgi?id=196211
1576         rdar://problem/49110552
1577
1578         Reviewed by Tim Horton.
1579
1580         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1581         Make sure that EventSenderProxy always exists when running tests. We used to create
1582         it when resetting before the first test, which is a bit too late.
1583
1584         * WebKitTestRunner/TestController.h:
1585         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1586         (WTR::TestController::platformCreateWebView):
1587         (WTR::TestController::platformCreateOtherPage):
1588         (WTR::TestController::finishCreatingPlatformWebView):
1589         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1590         (WTR::PlatformWebView::PlatformWebView):
1591         Moved some code that made NSWindow use NSEvent during web view creation. We may
1592         need to move more if some other case us found, but this is enough for now.
1593
1594 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1595
1596         Unreviewed. Fix typo in GLib geolocation API after r243285.
1597
1598         gelocation -> geolocation.
1599
1600         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1601         (testGeolocationManagerWatchPosition):
1602
1603 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1604
1605         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1606         https://bugs.webkit.org/show_bug.cgi?id=196213
1607
1608         Reviewed by Geoff Garen.
1609
1610         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1611         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1612         (credentialWithIdentityAndKeychainPath):
1613         (-[ChallengeDelegate webView:didFinishNavigation:]):
1614         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1615         (TestWebKitAPI::TEST):
1616
1617 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1618
1619         Expected shouldn't assume its contained types are copyable
1620         https://bugs.webkit.org/show_bug.cgi?id=195986
1621
1622         Reviewed by JF Bastien.
1623
1624         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1625         (TestWebKitAPI::NonCopyable::operator== const):
1626         (TestWebKitAPI::NonCopyable::operator!= const):
1627         (TestWebKitAPI::TEST):
1628
1629 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1630
1631         Remove some now-unnecessary dynamic class lookup
1632         https://bugs.webkit.org/show_bug.cgi?id=196237
1633
1634         Reviewed by Simon Fraser.
1635
1636         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1637         (makeRequest):
1638         (TEST):
1639
1640 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1641
1642         Unreviewed, rolling out r243450.
1643
1644         AppleWin and WinCairo port builds get broken.
1645
1646         Reverted changeset:
1647
1648         "Add test for fix of #196095"
1649         https://bugs.webkit.org/show_bug.cgi?id=196097
1650         https://trac.webkit.org/changeset/243450
1651
1652 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1653
1654         Unreviewed, rolling out r243465.
1655         https://bugs.webkit.org/show_bug.cgi?id=196226
1656
1657         the test doesn't build (Requested by thorton on #webkit).
1658
1659         Reverted changeset:
1660
1661         "Do not terminate the NetworkProcess if a third party
1662         application sends a NSCredential with a SecIdentityRef"
1663         https://bugs.webkit.org/show_bug.cgi?id=196213
1664         https://trac.webkit.org/changeset/243465
1665
1666 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1667
1668         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1669         https://bugs.webkit.org/show_bug.cgi?id=196213
1670
1671         Reviewed by Geoff Garen.
1672
1673         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1674         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1675         (credentialWithIdentityAndKeychainPath):
1676         (-[ChallengeDelegate webView:didFinishNavigation:]):
1677         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1678         (TestWebKitAPI::TEST):
1679
1680 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1681
1682         [ews-build] Gracefully handle missing patch_id in events
1683         https://bugs.webkit.org/show_bug.cgi?id=196216
1684
1685         Reviewed by Lucas Forschler.
1686
1687         * BuildSlaveSupport/ews-build/events.py:
1688
1689 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1690
1691         [ews-build] use lz4 compression for improving buildbot performance
1692         https://bugs.webkit.org/show_bug.cgi?id=196155
1693
1694         Reviewed by Lucas Forschler.
1695
1696         * BuildSlaveSupport/ews-build/master.cfg:
1697
1698 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1699
1700         Pull some API testing helper methods out of TestWKWebView
1701         https://bugs.webkit.org/show_bug.cgi?id=196212
1702
1703         Reviewed by Tim Horton.
1704
1705         Refactor some more API testing utility methods, so that they can be used in
1706         tests that do not use TestWKWebView.
1707
1708         * TestWebKitAPI/cocoa/TestWKWebView.h:
1709         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1710         (-[WKWebView loadTestPageNamed:]):
1711         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1712         (-[WKWebView synchronouslyLoadHTMLString:]):
1713         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1714         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1715         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1716         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1717         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1718
1719 2019-03-25  Jer Noble  <jer.noble@apple.com>
1720
1721         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1722         https://bugs.webkit.org/show_bug.cgi?id=196097
1723
1724         Reviewed by Eric Carlson.
1725
1726         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1727
1728         * DumpRenderTree/mac/DumpRenderTree.mm:
1729         (resetWebPreferencesToConsistentValues):
1730         * WebKitTestRunner/TestController.cpp:
1731         (WTR::TestController::resetPreferencesToConsistentValues):
1732
1733 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1734
1735         Pull IPadUserInterfaceSwizzler out into a separate header file
1736         https://bugs.webkit.org/show_bug.cgi?id=196193
1737
1738         Reviewed by Anders Carlsson.
1739
1740         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1741         be used in other API tests.
1742
1743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1744         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1745         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1746         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1747         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1748         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1749         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1750
1751 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1752
1753         Remove NavigatorContentUtils in WebCore/Modules
1754         https://bugs.webkit.org/show_bug.cgi?id=196070
1755
1756         Reviewed by Alex Christensen.
1757
1758         NavigatorContentUtils was to support the custom scheme spec [1].
1759         However, in WebKit side, no port has supported the feature in
1760         WebKit layer after EFL port was removed. So there has been the
1761         only IDL implementation of the NavigatorContentUtils in WebCore.
1762         So we don't need to keep the implementation in WebCore anymore.
1763
1764         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1765
1766         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1767
1768 2019-03-24  Andy Estes  <aestes@apple.com>
1769
1770         [watchOS] Remove unused Proximity Networking code
1771         https://bugs.webkit.org/show_bug.cgi?id=196188
1772
1773         Reviewed by Tim Horton.
1774
1775         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1776         (TEST):
1777
1778 2019-03-23  Keith Miller  <keith_miller@apple.com>
1779
1780         Refactor clz/ctz and fix getLSBSet.
1781         https://bugs.webkit.org/show_bug.cgi?id=196162
1782
1783         Reviewed by Saam Barati.
1784
1785         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1786
1787         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1788         (TestWebKitAPI::TEST):
1789
1790 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1791
1792         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1793         https://bugs.webkit.org/show_bug.cgi?id=196143
1794
1795         Reviewed by Michael Catanzaro.
1796
1797         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1798         directories.
1799
1800         * Scripts/webkitpy/style/checkers/cpp.py:
1801         (check_identifier_name_in_declaration):
1802         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1803         (WebKitStyleTest.test_names):
1804
1805 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1806
1807         [Flatpak] Manifest expanding fails for qt WPE extension
1808         https://bugs.webkit.org/show_bug.cgi?id=196148
1809
1810         Reviewed by Alex Christensen.
1811
1812         * flatpak/flatpakutils.py:
1813         (expand_submodules_recurse): The last recurse manifest expand
1814         iteration might lead to a single module so take it into account
1815         and don't try to recurse further.
1816
1817 2019-03-22  Chris Dumez  <cdumez@apple.com>
1818
1819         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1820         https://bugs.webkit.org/show_bug.cgi?id=195348
1821         <rdar://problem/48622090>
1822
1823         Reviewed by Alex Christensen.
1824
1825         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1826         to NO when test.options().shouldIgnoreMetaViewport is false.
1827
1828         * WebKitTestRunner/ios/TestControllerIOS.mm:
1829         (WTR::TestController::platformConfigureViewForTest):
1830
1831 2019-03-22  Chris Dumez  <cdumez@apple.com>
1832
1833         Prewarmed processes should be usable with any website data store
1834         https://bugs.webkit.org/show_bug.cgi?id=196104
1835
1836         Reviewed by Alex Christensen.
1837
1838         Add API test coverage.
1839
1840         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1841         (runInitialWarmedProcessUsedTest):
1842         (TEST):
1843
1844 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1845
1846         Back out local changes to Alex's Subversion working directory
1847
1848         They were accidentally committed.
1849
1850         * Scripts/webkitpy/common/system/abstractexecutive.py:
1851         (AbstractExecutive.wait_newest):
1852         * Scripts/webkitpy/common/system/executive.py:
1853         (Executive.running_pids):
1854         * Scripts/webkitpy/common/system/executive_mock.py:
1855         (MockExecutive.running_pids):
1856         * Scripts/webkitpy/common/system/executive_unittest.py:
1857         (ExecutiveTest.serial_test_running_pids):
1858         * Scripts/webkitpy/port/darwin.py:
1859         (DarwinPort.check_for_leaks):
1860         * Scripts/webkitpy/port/leakdetector.py:
1861         (LeakDetector.check_for_leaks):
1862         - This was the hack attached to Bug 193772.
1863
1864         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1865         (+[WebKitTestRunnerEvent mouseLocation]):
1866         - This works around a crash on an internal build.
1867
1868 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1869
1870         Fix the build after r243354
1871         https://bugs.webkit.org/show_bug.cgi?id=196138
1872         <rdar://problem/49145951>
1873
1874         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1875         (TEST):
1876         * TestWebKitAPI/ios/UIKitSPI.h:
1877
1878 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1879
1880         Adopt UIWKDocumentContext
1881         https://bugs.webkit.org/show_bug.cgi?id=196040
1882         <rdar://problem/48642440>
1883
1884         Reviewed by Ryosuke Niwa.
1885
1886         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1887         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1888         (makeRequest):
1889         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1890         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1891         (applyStyle):
1892         (TEST):
1893         Add tests for UIWKDocumentContext.
1894
1895         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1896         (TEST):
1897         (recursiveFindWKContentView): Deleted.
1898         * TestWebKitAPI/cocoa/TestWKWebView.h:
1899         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1900         (recursiveFindWKContentView):
1901         (-[TestWKWebView wkContentView]):
1902         * TestWebKitAPI/ios/UIKitSPI.h:
1903         Share the WKContentView finding code between tests.
1904
1905 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1906
1907         [iOS WK2] Turn on async overflow scrolling by default
1908         https://bugs.webkit.org/show_bug.cgi?id=196011
1909         rdar://problem/48453859
1910
1911         Reviewed by Antti Koivisto.
1912         
1913         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1914         since so many basic layout tests have different results when compositing is triggered for
1915         overflow.
1916         
1917         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1918
1919         * WebKitTestRunner/TestController.cpp:
1920         (WTR::TestController::resetPreferencesToConsistentValues):
1921
1922 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1923
1924         [ews-build] Retry API test in case of failures
1925         https://bugs.webkit.org/show_bug.cgi?id=196004
1926
1927         Reviewed by Lucas Forschler.
1928
1929         * BuildSlaveSupport/ews-build/steps.py:
1930         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1931         (CompileWebKitToT.doStepIf): Ditto.
1932         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1933         (ReRunAPITests): Re-run API tests.
1934         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1935         (RunAPITestsWithoutPatch): Run API tests without patch.
1936         (RunAPITestsWithoutPatch.doStepIf):
1937         (RunAPITestsWithoutPatch.hideStepIf):
1938         (RunAPITestsWithoutPatch.evaluateCommand):
1939         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1940         (AnalyzeAPITestsResults.start):
1941         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1942         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1943         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1944         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1945
1946 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1947
1948         [ews-build] Update queues configurations
1949         https://bugs.webkit.org/show_bug.cgi?id=196074
1950
1951         Reviewed by Dewei Zhu.
1952
1953         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1954         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1955
1956 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1957
1958         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1959         https://bugs.webkit.org/show_bug.cgi?id=195680
1960         <rdar://problem/48903534>
1961
1962         Unreviewed infrastructure fix.
1963
1964         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1965         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1966
1967 2019-03-21  Andy Estes  <aestes@apple.com>
1968
1969         [iOS] Apple Pay should be available in documents with no user agent scripts
1970         https://bugs.webkit.org/show_bug.cgi?id=196061
1971         <rdar://problem/48649391>
1972
1973         Reviewed by Brady Eidson.
1974
1975         Added API tests and related infrastructure.
1976
1977         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1978         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1979         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1980         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1981         (TestWebKitAPI::TEST):
1982         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1983         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1984         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1985         * TestWebKitAPI/cocoa/TestProtocol.mm:
1986         (-[TestProtocol startLoading]):
1987         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1988         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1989         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1990         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1991
1992 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1993
1994         REGRESSSION (r243297): webkitpy tests broken
1995         https://bugs.webkit.org/show_bug.cgi?id=196108
1996
1997         Reviewed by Aakash Jain.
1998
1999         r243297 updated contributors.json, which broke a few unit tests.
2000
2001         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2002         (IRCCommandTest.test_whois):
2003         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2004
2005 2019-03-21  Chris Dumez  <cdumez@apple.com>
2006
2007         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2008         https://bugs.webkit.org/show_bug.cgi?id=196041
2009         <rdar://problem/49083230>
2010
2011         Reviewed by Alex Christensen.
2012
2013         Add API test coverage.
2014
2015         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2016         (TEST):
2017
2018 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2019
2020         Add SPI to inform applications of WKContentRuleList actions
2021         https://bugs.webkit.org/show_bug.cgi?id=195965
2022         <rdar://problem/42664365>
2023
2024         Reviewed by Geoff Garen.
2025
2026         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2027         (TestWebKitAPI::allActionsForResourceLoad):
2028         (TestWebKitAPI::testRequest):
2029         (TestWebKitAPI::TEST_F):
2030         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2031         (Notification::description):
2032         (Notification::operator== const):
2033         (toVector):
2034         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2035         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2036         (makeContentRuleList):
2037         (TEST):
2038         (makeWarnContentRuleList): Deleted.
2039
2040 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2041
2042         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2043         https://bugs.webkit.org/show_bug.cgi?id=196088
2044
2045         Reviewed by Brian Burg.
2046
2047         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2048         Support checks when only one platform is specified. Also deprecate macosx() and
2049         force the use of macos() instead.
2050
2051         * Scripts/webkitpy/style/checkers/cpp.py:
2052         (check_min_versions_of_wk_api_available):
2053         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2054         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2055
2056 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2057
2058         Update status inactive committers' status to 'contributor'.
2059
2060         * Scripts/webkitpy/common/config/contributors.json:
2061
2062 2019-03-21  Xan Lopez  <xan@igalia.com>
2063
2064         [JSC][x86] Drop support for x87 floating point
2065         https://bugs.webkit.org/show_bug.cgi?id=194853
2066
2067         Reviewed by Don Olmstead.
2068
2069         Force SSE2 on x86/32bit builds.
2070
2071         * Scripts/webkitdirs.pm:
2072         (generateBuildSystemFromCMakeProject):
2073
2074 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2075
2076         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2077         https://bugs.webkit.org/show_bug.cgi?id=196073
2078
2079         Reviewed by Michael Catanzaro.
2080
2081         Add test cases to check functions and constructors with no arguments but receiving user data.
2082
2083         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2084         (checkUserData):
2085         (testJSCFunction):
2086         (fooCreateWithUserData):
2087         (testJSCClass):
2088
2089 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2090
2091         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2092
2093         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2094
2095         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2096
2097 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2098
2099         [GTK][WPE] Add API to provide geolocation information
2100         https://bugs.webkit.org/show_bug.cgi?id=195940
2101
2102         Reviewed by Michael Catanzaro.
2103
2104         Add a new test to check the new API.
2105
2106         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2107         (testGeolocationManagerCurrentPosition):
2108         (testGeolocationManagerWatchPosition):
2109         (beforeAll):
2110         (afterAll):
2111         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2112         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2113         (beforeAll): Ditto.
2114         * TestWebKitAPI/glib/CMakeLists.txt:
2115
2116 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2117
2118         [GLib] Returning G_TYPE_OBJECT from a method does not work
2119         https://bugs.webkit.org/show_bug.cgi?id=195574
2120
2121         Reviewed by Michael Catanzaro.
2122
2123         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2124
2125         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2126         (getGFile):
2127         (getParent):
2128         (createGString):
2129         (getGString):
2130         (getGStringCopyWillRaise):
2131         (getGStringCopy):
2132         (getGStringStr):
2133         (getGStringLen):
2134         (freeGString):
2135         (testJSCClass):
2136
2137 2019-03-20  Saam Barati  <sbarati@apple.com>
2138
2139         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2140         https://bugs.webkit.org/show_bug.cgi?id=195721
2141
2142         Reviewed by Filip Pizlo.
2143
2144         * Scripts/run-javascriptcore-tests:
2145
2146 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2147
2148         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2149         https://bugs.webkit.org/show_bug.cgi?id=196049
2150
2151         Reviewed by Tim Horton.
2152
2153         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2154         overflow scrolling in general, so rename it.
2155
2156         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2157
2158 2019-03-20  Daniel Bates  <dabates@apple.com>
2159
2160         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2161         https://bugs.webkit.org/show_bug.cgi?id=196031
2162         <rdar://problem/49078172>
2163
2164         Reviewed by Tim Horton.
2165
2166         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2167         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2168         same code path used when the Done button is pressed to dismiss the <select> picker.
2169
2170         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2171         (TestWebKitAPI::TEST):
2172
2173 2019-03-20  Chris Dumez  <cdumez@apple.com>
2174
2175         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2176         https://bugs.webkit.org/show_bug.cgi?id=196029
2177         <rdar://problem/48954651>
2178
2179         Reviewed by Tim Horton.
2180
2181         Add API test coverage.
2182
2183         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2184
2185 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2186
2187         [ews-build] Improve failure summary string for ApplyPatch step
2188         https://bugs.webkit.org/show_bug.cgi?id=195995
2189
2190         Reviewed by Alexey Proskuryakov.
2191
2192         * BuildSlaveSupport/ews-build/steps.py:
2193         (ApplyPatch.getResultSummary): Override getResultSummary.
2194
2195 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2196
2197         AX: Implement support for new meter ARIA role
2198         https://bugs.webkit.org/show_bug.cgi?id=195966
2199
2200         Reviewed by Chris Fleizach.
2201
2202         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2203         to AXLevelIndicator.
2204
2205         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2206
2207 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2208
2209         [WebAuthN] Implement FIDO AppID extension
2210         https://bugs.webkit.org/show_bug.cgi?id=143491
2211         <rdar://problem/48298273>
2212
2213         Reviewed by Brent Fulgham.
2214
2215         Add a test that covers the new flag of convertToU2fSignCommand.
2216
2217         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2218         (TestWebKitAPI::TEST):
2219         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2220         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2221         (TestWebKitAPI::TEST):
2222
2223 2019-03-19  Keith Rollin  <krollin@apple.com>
2224
2225         Add support for more platforms to generate-xcfilelists
2226         https://bugs.webkit.org/show_bug.cgi?id=195977
2227
2228         Reviewed by Alexey Proskuryakov.
2229
2230         generate-xcfilelists incorrectly complains when involved with building
2231         WebKit for iphonesimulator:
2232
2233             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2234             …
2235             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2236
2237         Address this by teaching generate-xcfilelists about more platforms.
2238
2239         * Scripts/generate-xcfilelists:
2240
2241 2019-03-19  John Wilander  <wilander@apple.com>
2242
2243         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2244         https://bugs.webkit.org/show_bug.cgi?id=195923
2245         <rdar://problem/49001272>
2246
2247         Reviewed by Alex Christensen.
2248
2249         This patch does the following to the TestRunner:
2250         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2251         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2252         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2253
2254         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2255         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2256         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2257         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2258         * WebKitTestRunner/TestController.cpp:
2259         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2260         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2261         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2262         * WebKitTestRunner/TestController.h:
2263         * WebKitTestRunner/TestInvocation.cpp:
2264         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2265
2266 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2267
2268         [CMake] Support more clang and gcc sanitizers
2269         https://bugs.webkit.org/show_bug.cgi?id=195956
2270
2271         Reviewed by Michael Catanzaro.
2272
2273         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2274
2275 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2276
2277         [ews-build] Improve summary for PrintConfiguration step
2278         https://bugs.webkit.org/show_bug.cgi?id=195945
2279
2280         Reviewed by Lucas Forschler.
2281
2282         * BuildSlaveSupport/ews-build/steps.py:
2283         (PrintConfiguration.getResultSummary): Override getResultSummary.
2284
2285 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2286
2287         [ews-build] Improve summary for CheckOutSource step
2288         https://bugs.webkit.org/show_bug.cgi?id=195963
2289
2290         Reviewed by Lucas Forschler.
2291
2292         * BuildSlaveSupport/ews-build/steps.py:
2293         (CheckOutSource.getResultSummary):
2294
2295 2019-03-19  Daniel Bates  <dabates@apple.com>
2296
2297         [iOS] Focus not preserved when switching between tabs
2298         https://bugs.webkit.org/show_bug.cgi?id=195820
2299         <rdar://problem/43614450>
2300
2301         Reviewed by Brent Fulgham.
2302
2303         Add tests to ensure that we restore focus when resigning and becoming first responder.
2304
2305         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2306         (TestWebKitAPI::TEST):
2307
2308 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2309
2310         Make WTFLogChannelState and WTFLogLevel enum classes
2311         https://bugs.webkit.org/show_bug.cgi?id=195904
2312
2313         Reviewed by Eric Carlson.
2314
2315         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2316         (TestWebKitAPI::TEST_F):
2317
2318 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2319
2320         [GStreamer][EME] Backported mssdemux protection data crash fix
2321         https://bugs.webkit.org/show_bug.cgi?id=195918
2322
2323         Reviewed by Philippe Normand.
2324
2325         * gstreamer/jhbuild.modules:
2326         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2327
2328 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2329
2330         Unreviewed, rolling out r243132.
2331
2332         Broke GTK build
2333
2334         Reverted changeset:
2335
2336         "Make WTFLogChannelState and WTFLogLevel enum classes"
2337         https://bugs.webkit.org/show_bug.cgi?id=195904
2338         https://trac.webkit.org/changeset/243132
2339
2340 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2341
2342         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2343
2344         * Scripts/webkitdirs.pm:
2345         (builtDylibPathForName): Adjust the shared library name that's changed
2346         with the API version bump in r243073.
2347
2348 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2349
2350         Make WTFLogChannelState and WTFLogLevel enum classes
2351         https://bugs.webkit.org/show_bug.cgi?id=195904
2352
2353         Reviewed by Eric Carlson.
2354
2355         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2356         (TestWebKitAPI::TEST_F):
2357
2358 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2359
2360         Disable flaky test added in r2431100
2361         https://webkit.org/b/195785
2362
2363         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2364         (TestWebKitAPI::TEST):
2365         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2366
2367 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2368
2369         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2370         https://bugs.webkit.org/show_bug.cgi?id=195916
2371
2372         Reviewed by Tim Horton.
2373
2374         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2375         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2376
2377 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2378
2379         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2380
2381         * Scripts/webkitpy/common/config/contributors.json:
2382
2383 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2384
2385         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2386         https://bugs.webkit.org/show_bug.cgi?id=195785
2387
2388         Reviewed by Geoffrey Garen.
2389
2390         * TestWebKitAPI/TCPServer.cpp: Added.
2391         (TestWebKitAPI::TCPServer::TCPServer):
2392         (TestWebKitAPI::TCPServer::~TCPServer):
2393         (TestWebKitAPI::TCPServer::socketBindListen):
2394         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2395         * TestWebKitAPI/TCPServer.h: Added.
2396         (TestWebKitAPI::TCPServer::port const):
2397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2398         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2399         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2400         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2401         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2402         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2403         (TestWebKitAPI::respondSlowly):
2404         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2405         (TestWebKitAPI::downloadAtRate):
2406         (TestWebKitAPI::TEST):
2407
2408 2019-03-18  Saam Barati  <sbarati@apple.com>
2409
2410         Add a plan file for JetStream 2
2411         https://bugs.webkit.org/show_bug.cgi?id=190734
2412
2413         Reviewed by Mark Lam.
2414
2415         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2416
2417 2019-03-18  Chris Dumez  <cdumez@apple.com>
2418
2419         Delay WebProcess launch until a load is triggered in a Web view
2420         https://bugs.webkit.org/show_bug.cgi?id=195758
2421         <rdar://problem/48126013>
2422
2423         Reviewed by Geoff Garen.
2424
2425         Add API test coverage. Also update some existing API tests to not expect
2426         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2427
2428         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2429         (TestWebKitAPI::TEST):
2430         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2431         (TestWebKitAPI::TEST):
2432         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2433         (TEST):
2434         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2435         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2436         (TEST):
2437         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2438         (TEST):
2439         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2440
2441 2019-03-18  Xan Lopez  <xan@igalia.com>
2442
2443         [CMake] Prevent potential warning when determining $architecture
2444         https://bugs.webkit.org/show_bug.cgi?id=195891
2445
2446         Reviewed by Michael Catanzaro.
2447
2448         It's possible for generateBuildSystemForCMakeProject to be called
2449         before determineArchitecture() is ever called. This will make the
2450         first eq check with $architecture to be bogus (and print a
2451         warning). Change that to an eq check with architecture(), which
2452         implicitly calls determineArchitecture() if needed, and change all
2453         the other similar cases in the method in the same way to prevent
2454         future bugs like this one.
2455
2456         * Scripts/webkitdirs.pm:
2457         (generateBuildSystemFromCMakeProject):
2458
2459 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2460
2461         [WPE] Tarballs generated with “make dist” cannot build documentation
2462         https://bugs.webkit.org/show_bug.cgi?id=195885
2463
2464         Reviewed by Carlos Garcia Campos.
2465
2466         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2467
2468 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2469
2470         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2471         https://bugs.webkit.org/show_bug.cgi?id=195883
2472
2473         Reviewed by Carlos Garcia Campos.
2474
2475         * gtkdoc/gtkdoc.py:
2476         (GTKDoc._run_command): When commands fail to run, include the full command line for
2477         the program invocation and the output it has generated on the standard error stream.
2478
2479 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2480
2481         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2482         https://bugs.webkit.org/show_bug.cgi?id=195786
2483
2484         Reviewed by Philippe Normand.
2485
2486         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2487         * wpe/jhbuild.modules: Ditto.
2488
2489 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2490
2491         [ews-build] Don't run clean builds on EWS builders
2492         https://bugs.webkit.org/show_bug.cgi?id=195851
2493
2494         Reviewed by Geoffrey Garen.
2495
2496         * BuildSlaveSupport/ews-build/factories.py:
2497
2498 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2499
2500         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2501         https://bugs.webkit.org/show_bug.cgi?id=195849
2502
2503         Reviewed by Chris Dumez.
2504
2505         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2506
2507         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2508         (runWebsiteDataStoreCustomPaths):
2509
2510 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2511
2512         webkitpy: Upload test results
2513         https://bugs.webkit.org/show_bug.cgi?id=195755
2514         <rdar://problem/48896182>
2515
2516         Reviewed by Aakash Jain.
2517
2518         Establish a new format for uploading results that is not tied to layout tests, apply
2519         that format to webkitpy tests.
2520
2521         * Scripts/webkitpy/common/checkout/scm/git.py:
2522         (Git.native_branch): Return what branch the current checkout is on.
2523         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2524         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2525         * Scripts/webkitpy/common/checkout/scm/svn.py:
2526         (SVN.native_branch): Ditto.
2527         * Scripts/webkitpy/common/system/platforminfo.py:
2528         (PlatformInfo.build_version): Return a build version for Mac.
2529         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2530         (MockPlatformInfo.__init__):
2531         (MockPlatformInfo.build_version):
2532         * Scripts/webkitpy/results: Added.
2533         * Scripts/webkitpy/results/__init__.py: Added.
2534         * Scripts/webkitpy/results/options.py: Added.
2535         (upload_options): OptParse list for upload options.
2536         * Scripts/webkitpy/results/upload.py: Added.
2537         (Upload): Class which enforces the upload format expected by the results server.
2538         (Upload.Expectations):
2539         (Upload.create_configuration):
2540         (Upload.create_commit):
2541         (Upload.create_details):
2542         (Upload.create_run_stats):
2543         (Upload.create_test_result):
2544         (Upload.__init__):
2545         (Upload.Encoder): Encode Upload object as json.
2546         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2547         * Scripts/webkitpy/results/upload_unittest.py: Added.
2548         * Scripts/webkitpy/test/main.py:
2549         (Tester._parse_args): Add upload arguments.
2550         (Tester._run_tests): Allow results to be uploaded.
2551         * Scripts/webkitpy/test/runner.py:
2552         (Runner.__init__): Record which tests were run, rather than just counting them.
2553         (Runner.handle):
2554         * Scripts/webkitpy/test/runner_unittest.py:
2555         (RunnerTest.test_run):
2556         * Scripts/webkitpy/thirdparty/__init__.py:
2557         (AutoinstallImportHook.find_module): Add requests auto-install.
2558         (AutoinstallImportHook._install_requests):
2559         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2560         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2561
2562 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2563
2564         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2565         https://bugs.webkit.org/show_bug.cgi?id=195810
2566
2567         Reviewed by Tim Horton.
2568
2569         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2570         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2571         ending certain layout tests.
2572
2573         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2574         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2575         (-[TestRunnerWKWebView dealloc]):
2576         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2577
2578         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2579         helper method when destroying the web view, and when resetting state between tests.
2580
2581         * WebKitTestRunner/ios/TestControllerIOS.mm:
2582         (WTR::TestController::platformResetStateToConsistentValues):
2583
2584         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2585
2586 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2587
2588         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2589         https://bugs.webkit.org/show_bug.cgi?id=190350
2590         <rdar://problem/45089503>
2591
2592         Reviewed by Geoffrey Garen.
2593
2594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2595         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2596         (TEST):
2597         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2598         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2599         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2600         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2601         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2602         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2603         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2604         (runTest):
2605         (createDirectories):
2606         (TEST):
2607         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2608         (TEST):
2609         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2610         (TEST):
2611
2612 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2613
2614         Add support to WebPage for getting the contents as an attributed string.
2615         https://bugs.webkit.org/show_bug.cgi?id=195636
2616         rdar://problem/45055697
2617
2618         Reviewed by Tim Horton.
2619
2620         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2621         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2622
2623 2019-03-15  Chris Dumez  <cdumez@apple.com>
2624
2625         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2626         https://bugs.webkit.org/show_bug.cgi?id=195747
2627
2628         Reviewed by Geoff Garen.
2629
2630         Add API test coverage.
2631
2632         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2633
2634 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2635
2636         Unreviewed, rolling out r242952.
2637
2638         Causing API failures on iOS Simulator
2639
2640         Reverted changeset:
2641
2642         "[PSON] Make sure the WebProcessCache is leverage when
2643         relaunching a process after termination"
2644         https://bugs.webkit.org/show_bug.cgi?id=195747
2645         https://trac.webkit.org/changeset/242952
2646
2647 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2648
2649         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2650         https://bugs.webkit.org/show_bug.cgi?id=195740
2651
2652         Reviewed by Ross Kirsling.
2653
2654         window.open doesn't work for WebKitBrowserWindow because it is not
2655         implemented yet.
2656
2657         1. Implemented createNewPage callback of WKPageUIClient.
2658         2. Changed MainWindow to take a BrowserWindow factory function
2659           instead of BrowserWindowType to be flexible to create
2660           BrowserWindow with extra settings.
2661         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2662           because it is not relevant with MainWindow anymore.
2663
2664         * MiniBrowser/win/Common.cpp:
2665         (parseCommandLine):
2666         * MiniBrowser/win/Common.h:
2667         (CommandLineOptions::CommandLineOptions):
2668         * MiniBrowser/win/MainWindow.cpp:
2669         (MainWindow::MainWindow):
2670         (MainWindow::create):
2671         (MainWindow::init):
2672         (MainWindow::WndProc):
2673         * MiniBrowser/win/MainWindow.h:
2674         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2675         (PrintWebUIDelegate::createWebViewWithRequest):
2676         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2677         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2678         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2679         (WebKitBrowserWindow::updateProxySettings):
2680         (WebKitBrowserWindow::createNewPage):
2681         * MiniBrowser/win/WebKitBrowserWindow.h:
2682         * MiniBrowser/win/WinMain.cpp:
2683         (wWinMain):
2684
2685 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2686
2687         Make it possible to test scrolling tree layer manipulation more easily
2688         https://bugs.webkit.org/show_bug.cgi?id=195780
2689
2690         Reviewed by Tim Horton.
2691         
2692         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2693         cuts off communication of scrolling tree scrolls back to the web process
2694         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2695         allows tests to trigger scrolls which run the scrolling tree layer positioning
2696         logic, but never get another commit from the web process that might mask
2697         scrolling tree bugs.
2698         
2699         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2700         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2701         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2702
2703         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2704         (WTR::UIScriptController::scrollUpdatesDisabled const):
2705         (WTR::UIScriptController::setScrollUpdatesDisabled):
2706         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2707         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2708         (WTR::UIScriptController::scrollUpdatesDisabled const):
2709         (WTR::UIScriptController::setScrollUpdatesDisabled):
2710         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2711         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2712         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2713         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2714         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2715         * WebKitTestRunner/ios/TestControllerIOS.mm:
2716         (WTR::TestController::platformResetStateToConsistentValues):
2717         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2718         (WTR::UIScriptController::scrollUpdatesDisabled const):
2719         (WTR::UIScriptController::setScrollUpdatesDisabled):
2720
2721 2019-03-14  Youenn Fablet  <youenn@apple.com>
2722
2723         Move IDB storage in private browsing mode to NetworkProcess
2724         https://bugs.webkit.org/show_bug.cgi?id=195602
2725
2726         Reviewed by Brady Eidson.
2727
2728         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2729         (TEST):
2730
2731 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2732
2733         [ews-build] Make descriptionDone messages more readable
2734         https://bugs.webkit.org/show_bug.cgi?id=195760
2735
2736         Reviewed by Lucas Forschler.
2737
2738         * BuildSlaveSupport/ews-build/steps.py:
2739         * BuildSlaveSupport/ews-build/steps_unittest.py:
2740
2741 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2742
2743         [ews-build] Generate status-bubble hover-over messages
2744         https://bugs.webkit.org/show_bug.cgi?id=195680
2745
2746         Reviewed by Lucas Forschler.
2747
2748         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2749         (StatusBubble):
2750         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2751         on hover-over.
2752         (StatusBubble._iso_time):
2753         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2754         hover-over message.
2755         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2756
2757 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2758
2759         [ews-app] Gracefully handle the case when state_string is None
2760         https://bugs.webkit.org/show_bug.cgi?id=195753
2761
2762         Reviewed by Lucas Forschler.
2763
2764         * BuildSlaveSupport/ews-app/ews/models/build.py:
2765         * BuildSlaveSupport/ews-app/ews/models/step.py:
2766
2767 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2768
2769         [ews-app] Status bubble display pending for currently running build step
2770         https://bugs.webkit.org/show_bug.cgi?id=195744
2771
2772         Reviewed by Lucas Forschler.
2773
2774         * BuildSlaveSupport/ews-build/events.py:
2775         (Events.stepStarted): If state_string is pending, replace it with step name.
2776
2777 2019-03-14  Chris Dumez  <cdumez@apple.com>
2778
2779         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2780         https://bugs.webkit.org/show_bug.cgi?id=195750
2781
2782         Reviewed by Geoffrey Garen.
2783
2784         Add API test coverage.
2785
2786         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2787         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2788         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2789         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2790
2791 2019-03-14  Chris Dumez  <cdumez@apple.com>
2792
2793         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2794         https://bugs.webkit.org/show_bug.cgi?id=195747
2795
2796         Reviewed by Geoff Garen.
2797
2798         Add API test coverage.
2799
2800         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2801
2802 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2803
2804         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2805         https://bugs.webkit.org/show_bug.cgi?id=195725
2806         <rdar://problem/48545062>
2807
2808         Reviewed by Tim Horton.
2809
2810         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2811         handler is nil.
2812
2813         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2814         (TestWebKitAPI::TEST):
2815
2816 2019-03-13  Sam Weinig  <sam@webkit.org>
2817
2818         Add utility function to allow easy reverse range-based iteration of a container
2819         https://bugs.webkit.org/show_bug.cgi?id=195542
2820
2821         Reviewed by Antti Koivisto.
2822
2823         * TestWebKitAPI/CMakeLists.txt:
2824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2825         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2826         (TestWebKitAPI::TEST):
2827         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2828
2829 2019-03-13  Chris Dumez  <cdumez@apple.com>
2830
2831         Use a ServiceWorker process per registrable domain
2832         https://bugs.webkit.org/show_bug.cgi?id=195649
2833
2834         Reviewed by Youenn Fablet.
2835
2836         Update API test coverage.
2837
2838         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2839
2840 2019-03-13  Chris Dumez  <cdumez@apple.com>
2841
2842         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2843         https://bugs.webkit.org/show_bug.cgi?id=195684
2844         <rdar://problem/48294714>
2845
2846         Reviewed by Antti Koivisto.
2847
2848         Add API test coverage.
2849
2850         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2851
2852 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2853
2854         [ews-app] Remove unused patch view
2855         https://bugs.webkit.org/show_bug.cgi?id=195669
2856
2857         Reviewed by Lucas Forschler.
2858
2859         * BuildSlaveSupport/ews-app/ews/urls.py:
2860         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2861
2862 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2863
2864         [ews-app] Use Buildbot result code variables
2865         https://bugs.webkit.org/show_bug.cgi?id=195668
2866
2867         Reviewed by Alexey Proskuryakov.
2868
2869         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2870         (Buildbot): Added Buildbot result code variables.
2871         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2872         (StatusBubble._build_bubble): Used Buildbot result code variables.
2873
2874 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2875
2876         [Flatpak] Expand submodule recursively
2877         https://bugs.webkit.org/show_bug.cgi?id=195672
2878
2879         Building WPE with flatpak was impossible without that as it was raising an exception.
2880         Also update wpebackend-fdo to match what is built in jhbuild
2881
2882         Reviewed by Philippe Normand.
2883
2884         * flatpak/flatpakutils.py:
2885         (expand_submodules_recurse):
2886         (expand_manifest):
2887         * flatpak/org.webkit.WPEModules.yaml:
2888
2889 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2890
2891         [ews-app] status bubble should be hidden for certain builds
2892         https://bugs.webkit.org/show_bug.cgi?id=194597
2893
2894         Reviewed by Dewei Zhu.
2895
2896         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2897         (StatusBubble._build_bubble):
2898         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2899         because the patch didn't have relevant changes.
2900         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2901         in production yet.
2902
2903 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2904
2905         [Win] Fix a slew of simple clang-cl warnings.
2906         https://bugs.webkit.org/show_bug.cgi?id=195652
2907
2908         Reviewed by Don Olmstead.
2909
2910         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2911         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2912
2913 2019-03-12  Justin Fan  <justin_fan@apple.com>
2914
2915         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2916         https://bugs.webkit.org/show_bug.cgi?id=195518
2917         <rdar://problem/46322356>
2918
2919         Reviewed by Myles C. Maxfield.
2920
2921         * DumpRenderTree/DerivedSources-input.xcfilelist:
2922         * DumpRenderTree/DerivedSources-output.xcfilelist:
2923
2924 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2925
2926         Unreviewed, rolling out r242825.
2927         https://bugs.webkit.org/show_bug.cgi?id=195648
2928
2929         "Broke webkitpy tests with my change to
2930         lldb_dump_class_layout.py" (Requested by rmorisset on
2931         #webkit).
2932
2933         Reverted changeset:
2934
2935         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2936         classes with suspicious padding"
2937         https://bugs.webkit.org/show_bug.cgi?id=195573
2938         https://trac.webkit.org/changeset/242825
2939
2940 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2941
2942         [ews-build] Show status bubbles while the patch is waiting in queue
2943         https://bugs.webkit.org/show_bug.cgi?id=195618
2944
2945         Reviewed by Lucas Forschler.
2946
2947         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2948         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2949         enabled in initial deployment.
2950         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2951         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2952         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2953         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2954         (StatusBubble._build_bubbles_for_patch):
2955
2956 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2957
2958         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2959         https://bugs.webkit.org/show_bug.cgi?id=195573
2960
2961         Reviewed by Simon Fraser.
2962
2963         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2964
2965         * Scripts/dump-class-layout:
2966         (main):
2967         * lldb/lldb_dump_class_layout.py:
2968         (ClassLayout.__init__):
2969         (ClassLayout._compute_padding_recursive):
2970         (LLDBDebuggerInstance.dump_layout_for_classname):
2971         (LLDBDebuggerInstance):
2972         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2973         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2974
2975 2019-03-12  Chris Dumez  <cdumez@apple.com>
2976
2977         Device Orientation access permission should be denied unless explicitly granted by the client
2978         https://bugs.webkit.org/show_bug.cgi?id=195625
2979
2980         Reviewed by Youenn Fablet.
2981
2982         add API test coverage.
2983
2984         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2985         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2986         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2987         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2988         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2989         (runDeviceOrientationTest):
2990         (TEST):
2991         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2992         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2993
2994 2019-03-12  Jer Noble  <jer.noble@apple.com>
2995
2996         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2997         https://bugs.webkit.org/show_bug.cgi?id=195137
2998         <rdar://problem/48810307>
2999
3000         Reviewed by Eric Carlson.
3001
3002         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3003         (TestWebKitAPI::TEST):
3004
3005 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3006
3007         [ews-build] Change urls from uat to production
3008         https://bugs.webkit.org/show_bug.cgi?id=195566
3009
3010         Reviewed by Lucas Forschler.
3011
3012         * BuildSlaveSupport/ews-app/ews/config.py:
3013         * BuildSlaveSupport/ews-build/events.py:
3014         * BuildSlaveSupport/ews-build/steps.py:
3015
3016 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3017
3018         [ews-build] change max_builds for local-worker to 1
3019         https://bugs.webkit.org/show_bug.cgi?id=195568
3020
3021         Reviewed by Lucas Forschler.
3022
3023         * BuildSlaveSupport/ews-build/loadConfig.py:
3024
3025 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3026
3027         Fix the build
3028
3029         * TestRunnerShared/spi/PencilKitTestSPI.h:
3030         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3031
3032 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3033
3034         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3035         https://bugs.webkit.org/show_bug.cgi?id=194131
3036
3037         Reviewed by Michael Catanzaro.
3038
3039         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3040         (uriChanged):
3041         (testUnfinishedSubresourceLoad):
3042         (serverCallback):
3043         (beforeAll):
3044
3045 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3046
3047         WTF::Expected should use std::addressof instead of operator&
3048         https://bugs.webkit.org/show_bug.cgi?id=195604
3049
3050         Reviewed by Myles Maxfield.
3051
3052         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3053         (TestWebKitAPI::Unique::Unique):
3054         (TestWebKitAPI::Unique::operator&):
3055         (TestWebKitAPI::TEST):
3056
3057 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3058
3059         Add Optional to Forward.h.
3060         https://bugs.webkit.org/show_bug.cgi?id=195586
3061
3062         Reviewed by Darin Adler.
3063
3064         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3065         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3066         Remove unnecessary includes from headers.
3067
3068 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3069
3070         Add testing API to hit-test and scroll overflow scrollers
3071         https://bugs.webkit.org/show_bug.cgi?id=195278
3072
3073         Reviewed by Antti Koivisto.
3074         
3075         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3076         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3077         
3078         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3079
3080         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3081         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3082         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3083         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3084         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3085         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3086         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3087         (WTR::enclosingScrollViewIncludingSelf):
3088         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3089
3090 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3091
3092         API test WebKit.RequestTextInputContext fails on iOS
3093         https://bugs.webkit.org/show_bug.cgi?id=195585
3094
3095         Reviewed by Wenson Hsieh and Simon Fraser.
3096
3097         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3098         (applyStyle):
3099         (TEST):
3100         Add a viewport, so that the coordinates match up on iOS.
3101         Scroll by moving the UIScrollView's contentOffset.
3102
3103 2019-03-11  Chris Dumez  <cdumez@apple.com>
3104
3105         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3106         https://bugs.webkit.org/show_bug.cgi?id=195506
3107         <rdar://problem/48733477>
3108
3109         Reviewed by Alex Christensen.
3110
3111         Add API test coverage.
3112
3113         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3114
3115 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3116
3117         Adding myself to contributors.json
3118
3119         Unreviewed, addming myself to contributors.json .
3120
3121         * Scripts/webkitpy/common/config/contributors.json:
3122
3123 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3124
3125         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3126         https://bugs.webkit.org/show_bug.cgi?id=195511
3127         <rdar://problem/44873269>
3128
3129         Reviewed by Darin Adler.
3130
3131         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3132         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3133         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3134         (TEST_F):
3135
3136 2019-03-11  Chris Dumez  <cdumez@apple.com>
3137
3138         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3139         https://bugs.webkit.org/show_bug.cgi?id=195561
3140
3141         Reviewed by Youenn Fablet.
3142
3143         Make sure the JS in the test requests for permission to receive device orientation events.
3144
3145         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3146
3147 2019-03-11  Youenn Fablet  <youenn@apple.com>
3148
3149         Allow storage quota increase by default in WTR
3150         https://bugs.webkit.org/show_bug.cgi?id=195541
3151
3152         Reviewed by Geoffrey Garen.
3153
3154         Allow storage quota increase by default in WTR.
3155         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3156         Use this for tests that explicitly need cache increase.
3157
3158         Instead of increasing quota by 2, make sure the next request is
3159         granted by adding all given parameters.
3160
3161         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3162         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3163         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3164         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3165         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3166         * WebKitTestRunner/TestController.cpp:
3167         (WTR::TestController::setAllowStorageQuotaIncrease):
3168         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3169         * WebKitTestRunner/TestController.h:
3170         * WebKitTestRunner/TestInvocation.cpp:
3171         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3172         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3173         (WTR::TestController::cocoaResetStateToConsistentValues):
3174         (WTR::TestController::setAllowStorageQuotaIncrease):
3175         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3176         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3177         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3178
3179 2019-03-11  Xan Lopez  <xan@igalia.com>
3180
3181         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3182         https://bugs.webkit.org/show_bug.cgi?id=194147
3183
3184         Reviewed by Michael Saboff.
3185
3186         To make --32-bit work correctly on Linux/64bit we need to:
3187
3188         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3189         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3190         unfortunately CMake only allows us to do this during
3191         crosscompilation, which is overkill here.
3192         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3193         pkg-config detection module uses the x86 .pc files instead of the
3194         x86_64 ones.
3195         - Set the -m32 flags for the compiler.
3196
3197         * Scripts/webkitdirs.pm:
3198         (generateBuildSystemFromCMakeProject):
3199
3200 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3201
3202         Add MotionMark-1.1 plan file for run-benchmark script.
3203         https://bugs.webkit.org/show_bug.cgi?id=195481
3204
3205         Rubber-stamped by Darin Adler.
3206
3207         Run-benchmark script should support MontionMark-1.1.
3208
3209         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3210
3211 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3212
3213         [ews-app] Add support for submit-to-ews url
3214         https://bugs.webkit.org/show_bug.cgi?id=195477
3215
3216         Reviewed by Lucas Forschler.
3217
3218         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3219         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3220         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3221         * BuildSlaveSupport/ews-app/ews/urls.py:
3222         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3223
3224 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3225
3226         Unreviewed, rolling out r242688, r242643, r242624.
3227
3228         Caused multiple layout test failures and crashes on iOS and macOS.
3229
3230         Reverted changeset:
3231
3232         "requestAnimationFrame should execute before the next frame"
3233         https://bugs.webkit.org/show_bug.cgi?id=177484
3234         https://trac.webkit.org/changeset/242624/webkit
3235
3236         * Tracing/SystemTracePoints.plist:
3237
3238 2019-03-11  John Wilander  <wilander@apple.com>
3239
3240         Resource Load Statistics: Make it possible exclude localhost from classification
3241         https://bugs.webkit.org/show_bug.cgi?id=195474
3242         <rdar://problem/47520577>
3243
3244         Reviewed by Brent Fulgham.
3245
3246         This patch allows for localhost to be excluded from classification and
3247         treatment as a prevalent resource.
3248
3249         The WebKit Tools change adds a new function called
3250         testRunner.setStatisticsIsRunningTest() which can be used to control this
3251         behavior.
3252
3253         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3254         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3255         (WTR::TestRunner::setStatisticsIsRunningTest):
3256         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3257         * WebKitTestRunner/TestController.cpp:
3258         (WTR::TestController::setStatisticsIsRunningTest):
3259         * WebKitTestRunner/TestController.h:
3260         * WebKitTestRunner/TestInvocation.cpp:
3261         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3262
3263 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3264
3265         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3266         https://bugs.webkit.org/show_bug.cgi?id=195560
3267
3268         Reviewed by Lucas Forschler.
3269
3270         * BuildSlaveSupport/ews-build/master.cfg:
3271
3272 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3273
3274         Unreviewed, rolling out r242698.
3275
3276         API test crashes on bots.
3277
3278         Reverted changeset:
3279
3280         "Add a WKContentRuleList variant that uses copied memory
3281         instead of mmap'd shared memory for class A containerized
3282         apps"
3283         https://bugs.webkit.org/show_bug.cgi?id=195511
3284         https://trac.webkit.org/changeset/242698
3285
3286 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3287
3288         [WPE] Enable web process sandbox
3289         https://bugs.webkit.org/show_bug.cgi?id=195169
3290
3291         Reviewed by Daniel Bates.
3292
3293         * wpe/install-dependencies:
3294         * wpe/jhbuild.modules:
3295
3296 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3297
3298         [ews-app] Use port 17000 for worker communication
3299         https://bugs.webkit.org/show_bug.cgi?id=195558
3300
3301         Reviewed by Lucas Forschler.
3302
3303         * BuildSlaveSupport/ews-build/master.cfg:
3304
3305 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3306
3307         [ews-build] unit-tests fail when passwords.json is missing
3308         https://bugs.webkit.org/show_bug.cgi?id=195557
3309
3310         Reviewed by Lucas Forschler.
3311
3312         * BuildSlaveSupport/ews-build/loadConfig.py:
3313         (loadBuilderConfig):
3314         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3315         (ConfigDotJSONTest.test_configuration):
3316         * BuildSlaveSupport/ews-build/master.cfg:
3317
3318 2019-03-11  Truitt Savell  <tsavell@apple.com>
3319
3320         Unreviewed, rolling out r242702.
3321
3322         Broke High Sierra builders.
3323
3324         Reverted changeset:
3325
3326         "Add utility function to allow easy reverse range-based
3327         iteration of a container"
3328         https://bugs.webkit.org/show_bug.cgi?id=195542
3329         https://trac.webkit.org/changeset/242702
3330
3331 2019-03-11  Sam Weinig  <sam@webkit.org>
3332
3333         Add utility function to allow easy reverse range-based iteration of a container
3334         https://bugs.webkit.org/show_bug.cgi?id=195542
3335
3336         Reviewed by Antti Koivisto.
3337
3338         * TestWebKitAPI/CMakeLists.txt:
3339         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3340         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3341         (TestWebKitAPI::TEST):
3342         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3343
3344 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3345
3346         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3347         https://bugs.webkit.org/show_bug.cgi?id=195511
3348         <rdar://problem/44873269>
3349
3350         Reviewed by Darin Adler.
3351
3352         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3353         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3354         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3355         (TEST_F):
3356
3357 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3358
3359         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3360         https://bugs.webkit.org/show_bug.cgi?id=195499
3361
3362         Reviewed by Darin Adler.
3363
3364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3365         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3366         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3367         (-[WKWebView synchronouslyFocusTextInputContext:]):
3368         (applyStyle):
3369         (applyIframe):
3370         (TEST):
3371         Add some tests for this SPI.
3372
3373 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3374
3375         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3376         https://bugs.webkit.org/show_bug.cgi?id=181151
3377
3378         Reviewed by Don Olmstead.
3379
3380         * TestWebKitAPI/CMakeLists.txt:
3381         * TestWebKitAPI/PlatformWin.cmake:
3382         Enable TestWTF RunLoop tests in all platforms.
3383
3384         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3385         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3386         (TestWebKitAPI::DerivedOneShotTimer::fired):
3387         (TestWebKitAPI::TEST):
3388         Only a few platforms support nested RunLoop.
3389
3390         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3391         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3392
3393 2019-03-10  David Quesada  <david_quesada@apple.com>
3394
3395         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3396         https://bugs.webkit.org/show_bug.cgi?id=152480
3397
3398         Reviewed by Chris Dumez.
3399
3400         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3401         there are no additional references to the process pool besides the one held by
3402         the download, waits for the download to finish (in the sense that the
3403         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3404         measure, also check that the process pool has been deallocated at the end of the
3405         test. The test wouldn't be meaningful if the process pool were still alive.
3406
3407         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3408         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3409         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3410             The download will be canceled because the delegate does not implement the
3411             method to decide the download's destination, so this is where we know the
3412             DownloadProxyMap is done with the DownloadProxy.
3413         (TEST):
3414
3415 2019-03-08  Chris Dumez  <cdumez@apple.com>
3416
3417         Add support for Device Orientation / Motion permission API
3418         https://bugs.webkit.org/show_bug.cgi?id=195329
3419         <rdar://problem/47645367>
3420
3421         Reviewed by Geoffrey Garen.
3422
3423         Add test infrastructure to help test the Device Orientation / Motion permission API.
3424
3425         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3426         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3427         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3428         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3429         * WebKitTestRunner/TestController.cpp:
3430         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3431         (WTR::TestController::createWebViewWithOptions):
3432         (WTR::TestController::resetStateToConsistentValues):
3433         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3434         * WebKitTestRunner/TestController.h:
3435         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3436         * WebKitTestRunner/TestInvocation.cpp:
3437         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3438
3439 2019-03-08  Saam barati  <sbarati@apple.com>
3440
3441         Add a compare-results script to compare benchmark results
3442         https://bugs.webkit.org/show_bug.cgi?id=195486
3443         <rdar://problem/48723397>
3444
3445         Reviewed by Geoffrey Garen.
3446
3447         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3448         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3449         to extend it to learn about our other benchmarks.
3450
3451         * Scripts/compare-results: Added.
3452         (readJSONFile):
3453         (detectJetStream2):
3454         (JetStream2Results):
3455         (detectSpeedometer2):
3456         (Speedometer2Results):
3457         (detectPLT5):
3458         (PLT5Results):
3459         (detectBenchmark):
3460         (biggerIsBetter):
3461         (ttest):
3462         (getOptions):
3463         (main):
3464
3465 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3466
3467         Ensure old tab state is cleared between iterations of run-benchmark
3468         https://bugs.webkit.org/show_bug.cgi?id=195393
3469         <rdar://problem/46885583>
3470
3471         Reviewed by Dewei Zhu.
3472
3473         a) ensure the default to restore state is not set
3474         b) terminate Safari correctly
3475         c) Set the system default to ignore Persistent State in Safari
3476
3477         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3478         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3479         (OSXBrowserDriver.prepare_env): 
3480         (OSXBrowserDriver.restore_env):
3481         (OSXBrowserDriver.close_browsers):
3482         (OSXBrowserDriver._terminate_processes):
3483         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3484         (OSXChromeDriver):
3485         (OSXChromeCanaryDriver):
3486         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3487         (OSXFirefoxDriver):
3488         (OSXFirefoxNightlyDriver):
3489         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3490         (OSXSafariDriver):
3491         (OSXSafariDriver.prepare_env):
3492
3493 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3494
3495         [GTK] Several InputMethodFilter tests are failing
3496         https://bugs.webkit.org/show_bug.cgi?id=195408
3497
3498         Reviewed by Carlos Garcia Campos.
3499
3500         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3501         Regressed in r241751.
3502         Hexadecimal values of keycodes are expressed now in upper letters.
3503         Composited characters should be cast to UTF8 strings.
3504
3505         (TestWebKitAPI::TEST):
3506
3507 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3508
3509         [GTK] Make Tools/gtkdoc python3 compatible
3510         https://bugs.webkit.org/show_bug.cgi?id=195359
3511
3512         Reviewed by Carlos Garcia Campos.
3513
3514         * gtkdoc/generate-gtkdoc:
3515         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3516         work with Python 2 and 3.
3517         (get_gtkdoc_module_paths):
3518         The iteritems() was removed in Python 3, so let's use items() that's
3519         available in Python 2 and 3.
3520         (get_generator_for_config):
3521         * gtkdoc/gtkdoc.py:
3522         (GTKDoc._run_command):
3523         The sys.stdout.write() is expecting str in Python 3 and not bytes
3524         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3525         for passing the bytes there.
3526
3527 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3528
3529         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3530         https://bugs.webkit.org/show_bug.cgi?id=195346
3531         <rdar://problem/48667048>
3532
3533         Unreviewed build fix for clang-cl.
3534
3535         * DumpRenderTree/win/DumpRenderTree.cpp:
3536         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3537
3538 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3539
3540         requestAnimationFrame should execute before the next frame
3541         https://bugs.webkit.org/show_bug.cgi?id=177484
3542
3543         Reviewed by Simon Fraser.
3544
3545         Add trace points for the page RenderingUpdate.
3546
3547         * Tracing/SystemTracePoints.plist:
3548
3549 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3550
3551         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3552         https://bugs.webkit.org/show_bug.cgi?id=195353
3553         <rdar://problem/48626394>
3554
3555         Reviewed by Simon Fraser.
3556
3557         * WebKitTestRunner/ios/TestControllerIOS.mm:
3558         (WTR::TestController::platformResetPreferencesToConsistentValues):
3559
3560 2019-03-07  John Wilander  <wilander@apple.com>
3561
3562         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3563         https://bugs.webkit.org/show_bug.cgi?id=195383
3564         <rdar://problem/48570136>
3565
3566         Reviewed by Brent Fulgham.
3567
3568         This patch adds test infrastructure to purge only script-accessible cookies,
3569         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3570
3571         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3572         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3573         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3574         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3575         * WebKitTestRunner/TestController.cpp:
3576         (WTR::TestController::statisticsDeleteCookiesForHost):
3577         * WebKitTestRunner/TestController.h:
3578         * WebKitTestRunner/TestInvocation.cpp:
3579         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3580
3581 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3582
3583         Unreviewed, rolling out r242354.
3584         https://bugs.webkit.org/show_bug.cgi?id=195402
3585
3586         breaks layout tests in all configurations (Requested by
3587         zdobersek on #webkit).
3588
3589         Reverted changeset:
3590
3591         "[WPE] Enable web process sandbox"
3592         https://bugs.webkit.org/show_bug.cgi?id=195169
3593         https://trac.webkit.org/changeset/242354
3594
3595 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3596
3597         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3598         https://bugs.webkit.org/show_bug.cgi?id=195346
3599
3600         Reviewed by Fujii Hironori.
3601
3602         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3603         (TestWebKitAPI::TEST):
3604         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3605
3606         * DumpRenderTree/win/DumpRenderTree.cpp:
3607         (findFontFallback):
3608         (addFontFallbackIfPresent):
3609         (removeFontFallbackIfPresent):
3610         (main):
3611         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3612         (TestWebKitAPI::Util::moduleDirectory):
3613         (TestWebKitAPI::Util::createInjectedBundlePath):
3614         Use wchar helpers as needed.
3615
3616 2019-03-06  Rob Buis  <rbuis@igalia.com>
3617
3618         Consider supporting the `referrerpolicy` attribute.
3619         https://bugs.webkit.org/show_bug.cgi?id=179053
3620
3621         Reviewed by Darin Adler.
3622
3623         Add a runtime flag for referrerpolicy attribute.
3624
3625         * DumpRenderTree/mac/DumpRenderTree.mm:
3626         (enableExperimentalFeatures):
3627
3628 2019-03-05  Daniel Bates  <dabates@apple.com>
3629
3630         Update expected API test result following r242379
3631         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3632
3633         Update expected x-coordinate of selection rect now that the left padding of
3634         a textarea is sized in ems (so dependent on the font size) just like the left
3635         padding of a text field.
3636
3637         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3638         (TestWebKitAPI::TEST):
3639
3640 2019-03-05  David Quesada  <david_quesada@apple.com>
3641
3642         [WK2] It should be possible to follow links with 'download' attributes
3643         https://bugs.webkit.org/show_bug.cgi?id=195145
3644         rdar://problem/48462642
3645
3646         Reviewed by Alex Christensen.
3647
3648         Add a unit test to verify that activating links with 'download' attributes now
3649         navigates to the linked resource, rather than starts downloading it. Add another
3650         to verify that it is still possible to explicitly download the link via the
3651         'Download' navigation action policy.
3652
3653         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3654         (-[DownloadAttributeTestDelegate init]):
3655         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3656         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3657         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3658         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3659         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3660         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3661         (TEST):
3662         * WebKitTestRunner/TestController.cpp:
3663         (WTR::TestController::decidePolicyForNavigationAction):
3664         * WebKitTestRunner/TestController.h:
3665
3666 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3667
3668         [Curl] Implement Cookie Accept Policy.
3669         https://bugs.webkit.org/show_bug.cgi?id=191645
3670
3671         Reviewed by Fujii Hironori.
3672
3673         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3674         (TestWebKitAPI::Curl::TEST_F):
3675
3676 2019-03-05  Youenn Fablet  <youenn@apple.com>
3677
3678         Rename requestCacheStorageSpace to requestStorageSpace
3679         https://bugs.webkit.org/show_bug.cgi?id=195282
3680
3681         Reviewed by Chris Dumez.
3682
3683         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3684         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3685         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3686
3687 2019-03-05  Brady Eidson  <beidson@apple.com>
3688
3689         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3690         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3691
3692         Reviewed by Tim Horton.
3693
3694         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3695         different directory into that same WKWebView should work.
3696
3697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3698         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3699
3700 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3701
3702         Add WeakHashSet
3703         https://bugs.webkit.org/show_bug.cgi?id=195152
3704
3705         Reviewed by Antti Koivisto.
3706
3707         Added tests for WeakHashSet.
3708
3709         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3710         (TestWebKitAPI::Base::Base): Moved.
3711         (TestWebKitAPI::Derived::foo): Moved.
3712         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3713         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3714         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3715         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3716
3717 2019-03-04  Chris Dumez  <cdumez@apple.com>
3718
3719         Do not share WebProcesses between private and regular sessions
3720         https://bugs.webkit.org/show_bug.cgi?id=195189
3721         <rdar://problem/48421064>
3722
3723         Reviewed by Alex Christensen.
3724
3725         Add API test coverage.
3726
3727         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3728         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3729
3730 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3731
3732         [WPE] Enable web process sandbox
3733         https://bugs.webkit.org/show_bug.cgi?id=195169
3734
3735         Reviewed by Daniel Bates.
3736
3737         * wpe/install-dependencies:
3738         * wpe/jhbuild.modules:
3739
3740 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3741
3742         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3743         https://bugs.webkit.org/show_bug.cgi?id=195206
3744
3745         Reviewed by Žan Doberšek.
3746
3747         Add a new test case.
3748
3749         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3750         (testJSCClass):
3751
3752 2019-03-04  Charlie Turner  <cturner@igalia.com>
3753
3754         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3755         https://bugs.webkit.org/show_bug.cgi?id=194898
3756
3757         Reviewed by Žan Doberšek.
3758
3759         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3760         a GCC extension that permits arithmetic on void* pointer. Inline
3761         the macro until this issue is fixed upstream.
3762
3763 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3764
3765         Rid the world of WK_API_ENABLED
3766         https://bugs.webkit.org/show_bug.cgi?id=195263
3767
3768         Reviewed by Dan Bernstein.
3769
3770         List of changed files elided because it's useless.
3771
3772 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3773
3774         Unreviewed follow-up to r242292.
3775
3776         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3777
3778         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3779         (TestWebKitAPI::testStrip): Renamed from strip.
3780         (TestWebKitAPI::TEST):
3781
3782 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3783
3784         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3785
3786         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3787         and bug #194272 for details.
3788
3789         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3790
3791 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3792
3793         Remove some more unused 32-bit code
3794         https://bugs.webkit.org/show_bug.cgi?id=195255
3795
3796         Reviewed by Darin Adler.
3797
3798         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3799         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3800         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3801         (NPP_New):
3802         (NPP_HandleEvent):
3803         (handleEventCarbon): Deleted.
3804
3805 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3806
3807         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3808
3809         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3810         (TestWebKitAPI::TEST):
3811
3812 2019-03-01  Darin Adler  <darin@apple.com>
3813
3814         Finish removing String::format
3815         https://bugs.webkit.org/show_bug.cgi?id=194893
3816
3817         Reviewed by Daniel Bates.
3818 '
3819         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3820
3821 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3822
3823         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3824         https://bugs.webkit.org/show_bug.cgi?id=195229
3825         <rdar://problem/48520362>
3826
3827         Reviewed by Chris Dumez.
3828
3829         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3830         (TEST):
3831
3832 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3833
3834         Add a system trace scope for event region building
3835         https://bugs.webkit.org/show_bug.cgi?id=195226
3836
3837         Reviewed by Jon Lee.
3838
3839         This trace scope measures the time spend converting element rects into Region objects,
3840         which can be large on some pages.
3841
3842         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3843
3844         * Tracing/SystemTracePoints.plist:
3845
3846 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3847
3848         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3849         https://bugs.webkit.org/show_bug.cgi?id=194612
3850
3851         Reviewed by Alex Christensen.
3852
3853         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3854         Just test the new string-processing function and don't touch the actual environment.
3855         (Test cases are all as before, but based on operator== instead of strcmp.)
3856
3857 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3858
3859         [ews-app] Update primary keys for handling multiple Buildbot instances
3860         https://bugs.webkit.org/show_bug.cgi?id=195120
3861
3862         Reviewed by Stephanie Lewis.
3863
3864         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3865         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3866         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3867
3868         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3869         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3870         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3871         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3872         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3873         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3874
3875 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3876
3877         [WinCairo] Enable service worker
3878         https://bugs.webkit.org/show_bug.cgi?id=188318
3879
3880         Reviewed by Youenn Fablet.
3881
3882         * DumpRenderTree/DumpRenderTreePrefix.h:
3883         * TestWebKitAPI/PlatformWin.cmake:
3884         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3885         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3886         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3887
3888 2019-03-01  Justin Fan  <justin_fan@apple.com>
3889
3890         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3891         https://bugs.webkit.org/show_bug.cgi?id=195191
3892
3893         Rubber-stamped by Dean Jackson.
3894
3895         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3896
3897         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3898
3899 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3900
3901         Unreviewed, fix lldb webkitpy tests
3902         https://bugs.webkit.org/show_bug.cgi?id=194375
3903
3904         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3905
3906         * lldb/lldb_webkit.py:
3907         (WTFStringImplProvider.is_8bit):
3908
3909 2019-02-28  David Quesada  <david_quesada@apple.com>
3910
3911         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3912         https://bugs.webkit.org/show_bug.cgi?id=195121
3913         rdar://problem/48450302
3914
3915         Reviewed by Alex Christensen.
3916
3917         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3918         configurations where the 'download' attribute is absent, blank, or populated
3919         with a filename, and where the anchor element is same-origin or cross-origin
3920         (meaning the 'download' attribute shouldn't be honored).
3921
3922         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3923         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3924         (-[NavigationActionTestDelegate init]):
3925         (-[NavigationActionTestDelegate navigationAction]):
3926         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3927         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3928         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3929         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3930         (TEST):
3931
3932 2019-02-28  Antoine Quint  <graouts@apple.com>
3933
3934         Enable the Pointer Events runtime flag by default
3935         https://bugs.webkit.org/show_bug.cgi?id=195156
3936
3937         Reviewed by Dean Jackson.
3938
3939         * DumpRenderTree/mac/DumpRenderTree.mm:
3940         (enableExperimentalFeatures):
3941
3942 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3943
3944         Several PasteImage API tests are flaky
3945         https://bugs.webkit.org/show_bug.cgi?id=195160
3946
3947         Reviewed by Tim Horton.
3948
3949         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3950         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3951         listening for a "load" event after image load is already complete.
3952
3953         To address this, make these tests first register a "load" event handler, then run script to insert an image
3954         element into the document, and finally wait until the load event is observed before checking image size.
3955
3956         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3957
3958 2019-02-28  Chris Dumez  <cdumez@apple.com>
3959
3960         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3961         https://bugs.webkit.org/show_bug.cgi?id=195107
3962
3963         Reviewed by Alex Christensen.
3964
3965         Give some time for the zoom level to get restored.
3966
3967         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3968
3969 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3970
3971         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3972         https://bugs.webkit.org/show_bug.cgi?id=194958
3973
3974         Reviewed by Geoffrey Garen.
3975
3976         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3977         (TEST):
3978
3979 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3980
3981         [ews-app] Update method to save build to handle builder_display_name
3982         https://bugs.webkit.org/show_bug.cgi?id=195047
3983
3984         Reviewed by Dewei Zhu.
3985
3986         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3987         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3988
3989 2019-02-28  Justin Fan  <justin_fan@apple.com>
3990
3991         [Web GPU] Enable Web GPU only on 64-bit
3992         https://bugs.webkit.org/show_bug.cgi?id=195139
3993
3994         Because Metal is only supported on 64 bit apps.
3995
3996         Unreviewed build fix.
3997
3998         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3999
4000 2019-02-27  Youenn Fablet  <youenn@apple.com>
4001
4002         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4003         https://bugs.webkit.org/show_bug.cgi?id=194959
4004
4005         Reviewed by Chris Dumez.
4006
4007         Spin loop until getting the condition to remove flakiness.
4008
4009         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4010
4011 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4012
4013         [ews-build] Buildbot should include builder_display_name in the build events
4014         https://bugs.webkit.org/show_bug.cgi?id=195045
4015
4016         Reviewed by Dewei Zhu.
4017
4018         * BuildSlaveSupport/ews-build/events.py:
4019         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4020         buildername to builder_name to be consistent in naming style.
4021         (Events.buildFinished): Ditto.
4022
4023 2019-02-27  Chris Dumez  <cdumez@apple.com>
4024
4025         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4026         https://bugs.webkit.org/show_bug.cgi?id=194480
4027
4028         Reviewed by Brady Eidson.
4029
4030         Update existing API test to make it more likely to reproduce the issue.
4031
4032         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4033
4034 2019-02-27  Brady Eidson  <beidson@apple.com>
4035
4036         Universal links from Google search results pages don't open the app.
4037         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4038
4039         Reviewed by Geoffrey Garen.
4040
4041         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4042         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4043         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4044         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4045
4046 2019-02-27  Chris Dumez  <cdumez@apple.com>
4047
4048         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4049         https://bugs.webkit.org/show_bug.cgi?id=195102
4050
4051         Reviewed by Geoffrey Garen.
4052
4053         If the number of processes is not yet what we expect, wait a bit and check again to give
4054         processes some time to exit.
4055
4056         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4057
4058 2019-02-27  Chris Dumez  <cdumez@apple.com>
4059
4060         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4061         https://bugs.webkit.org/show_bug.cgi?id=194545
4062
4063         Reviewed by Brady Eidson.
4064
4065         Make sure the test navigates forward and then back only once. Previously, navigating
4066         back would trigger a navigation again in a timer.
4067
4068         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4069
4070 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4071
4072         High Sierra Debug JSC test queue should use faster hardware
4073         https://bugs.webkit.org/show_bug.cgi?id=194603
4074
4075         Rubber-stamped by Alexey Proskuryakov.
4076
4077         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4078
4079         * BuildSlaveSupport/build.webkit.org-config/config.json:
4080         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4081         (BubbleQueueServer):
4082         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4083         (WebKitBuildbot):
4084         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4085         * QueueStatusServer/config/queues.py:
4086         * Scripts/webkitpy/common/config/ews.json:
4087         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4088         (test_ews_name):
4089
4090 2019-02-27  John Wilander  <wilander@apple.com>
4091
4092         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4093         https://bugs.webkit.org/show_bug.cgi?id=195071
4094         <rdar://problem/48417690>
4095
4096         Reviewed by Alex Christensen and Brent Fulgham.
4097
4098         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4099         (TestWebKitAPI::createURL):
4100             Convenience function.
4101         (TestWebKitAPI::TEST):
4102             WebCore::AdClickAttribution now takes a URL when creating Source and
4103             Destination.
4104         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4105         (TestWebKitAPI::TEST):
4106             WebCore::AdClickAttribution now takes a URL when creating Source and
4107             Destination.
4108
4109 2019-02-27  Antoine Quint  <graouts@apple.com>
4110
4111         Support Pointer Events on macOS
4112         https://bugs.webkit.org/show_bug.cgi?id=195008
4113         <rdar://problem/47454419>
4114
4115         Reviewed by Dean Jackson.
4116
4117         * DumpRenderTree/mac/DumpRenderTree.mm:
4118         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4119         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4120
4121 2019-02-26  Mark Lam  <mark.lam@apple.com>
4122
4123         Remove remaining poisoning code.
4124         https://bugs.webkit.org/show_bug.cgi?id=194138
4125
4126         Reviewed by Saam Barati.
4127
4128         * TestWebKitAPI/CMakeLists.txt:
4129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4130         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4131         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4132         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4133         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4134         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4135         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4136
4137 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4138
4139         Move ephemeral local storage from WebProcess to UIProcess
4140         https://bugs.webkit.org/show_bug.cgi?id=195074
4141         <rdar://problem/47937975>
4142
4143         Reviewed by Geoff Garen.
4144
4145         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4146
4147 2019-02-20  Jer Noble  <jer.noble@apple.com>
4148
4149         [Cocoa] Media elements will restart network buffering just before suspending
4150         https://bugs.webkit.org/show_bug.cgi?id=193691
4151
4152         Reviewed by Eric Carlson.
4153
4154         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4155         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4156         (TEST):
4157
4158 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4159
4160         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4161         https://bugs.webkit.org/show_bug.cgi?id=191652
4162
4163         Reviewed by Alex Christensen.
4164
4165         Fix WinCairo MiniBrowser behavior of authentication dialog.
4166
4167         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4168         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4169
4170 2019-02-26  Youenn Fablet  <youenn@apple.com>
4171
4172         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4173         https://bugs.webkit.org/show_bug.cgi?id=195028
4174         <rdar://problem/48243733>
4175
4176         Reviewed by Eric Carlson.
4177
4178         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4179
4180 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4181
4182         [WPE] Add API for webview background color configuration
4183         https://bugs.webkit.org/show_bug.cgi?id=192305
4184
4185         Reviewed by Michael Catanzaro.
4186
4187         * MiniBrowser/wpe/main.cpp:
4188         (main): Add a new option to configure the webview background
4189         color. Example: --bg-color=transparent.
4190         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4191         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4192         (beforeAll): Ditto.
4193
4194 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4195
4196         scalableNativeWebpageParameters() is not preserved on new page navigation.
4197         https://bugs.webkit.org/show_bug.cgi?id=194892
4198         <rdar://problem/47538280>
4199
4200         Reviewed by Wenson Hsieh.
4201         
4202         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4203
4204         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4205         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4206         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4207         (WTR::UIScriptController::allowsViewportShrinkToFit):
4208         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4209         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4210         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4211         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4212         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4213         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4214
4215 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4216
4217         [ews-app] Add model for handling multiple Buildbot instances
4218         https://bugs.webkit.org/show_bug.cgi?id=194863
4219
4220         Reviewed by Stephanie Lewis.
4221
4222         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4223
4224 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4225
4226         [ews-app] Remove BuilderMapping table
4227         https://bugs.webkit.org/show_bug.cgi?id=194961
4228
4229         Reviewed by Stephanie Lewis.
4230
4231         Store builder name directly in build table, instead of having a separate
4232         table for it.
4233
4234         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4235         * BuildSlaveSupport/ews-app/ews/models/build.py:
4236         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4237         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4238
4239 2019-02-25  John Wilander  <wilander@apple.com>
4240
4241         Introduce and adopt new class RegistrableDomain for eTLD+1
4242         https://bugs.webkit.org/show_bug.cgi?id=194791
4243         <rdar://problem/48179240>
4244
4245         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4246
4247         This patch adds an API test and replaces two instances of
4248         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4249
4250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4251         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4252         (TestWebKitAPI::TEST):
4253             Changed two strings to make sure the registrable domains are still considered
4254             invalid and pass the test.
4255         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4256         (TestWebKitAPI::TEST):
4257         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4258         (WTR::InjectedBundle::didReceiveMessageToPage):
4259
4260 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4261
4262         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4263         https://bugs.webkit.org/show_bug.cgi?id=195001
4264
4265         Reviewed by Carlos Garcia Campos.
4266
4267         API version 1.0 always includes the functionality previously guarded with
4268         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4269         unconditionally.
4270
4271         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4272         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4273         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4274         (WebViewTest::showInWindow): Ditto.
4275         (WebViewTest::hideView): Ditto.
4276         * wpe/backends/HeadlessViewBackend.cpp:
4277         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4278         * wpe/backends/ViewBackend.cpp:
4279         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4280         * wpe/backends/WindowViewBackend.cpp:
4281         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4282         WPE_BACKEND_CHECK_VERSION().
4283         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4284
4285 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4286
4287         [Flatpak] Add support for flatpak > 1.1.2
4288         https://bugs.webkit.org/show_bug.cgi?id=194088
4289
4290         Flatpak 1.2 is now out so we need to support that
4291         version now.
4292
4293         Reviewed by Michael Catanzaro.
4294
4295         * flatpak/flatpakutils.py:
4296         (check_flatpak):
4297         (FlatpakPackages.__init__):
4298         (FlatpakPackages.__detect_packages):
4299         (FlatpakPackages.__detect_packages.in):
4300         (FlatpakRepos.update):
4301
4302 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4303
4304         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4305         https://bugs.webkit.org/show_bug.cgi?id=194998
4306
4307         Reviewed by Carlos Garcia Campos.
4308
4309         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4310         to a Git checkout and using the latest commit containing various fixes
4311         and improvements.
4312
4313 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4314
4315         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4316         https://bugs.webkit.org/show_bug.cgi?id=194981
4317
4318         Reviewed by Žan Doberšek.
4319
4320         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4321         (TestWebKitAPI::TEST):
4322
4323 2019-02-23  Keith Miller  <keith_miller@apple.com>
4324
4325         Add new mac target numbers
4326         https://bugs.webkit.org/show_bug.cgi?id=194955
4327
4328         Reviewed by Tim Horton.
4329
4330         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4331         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4332         * MiniBrowser/Configurations/Base.xcconfig:
4333         * TestWebKitAPI/Configurations/Base.xcconfig:
4334         * WebKitTestRunner/Configurations/Base.xcconfig:
4335
4336 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4337
4338         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4339         https://bugs.webkit.org/show_bug.cgi?id=194846
4340
4341         Reviewed by Don Olmstead.
4342
4343         Added _search_paths() and _port_specific_expectations_files() for
4344         WinCairoPort.
4345
4346         * Scripts/webkitpy/port/win.py:
4347         (WinCairoPort.default_baseline_search_path):
4348         (WinCairoPort):
4349         (WinCairoPort._port_specific_expectations_files):
4350         (WinCairoPort._search_paths):
4351
4352 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4353
4354         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4355         https://bugs.webkit.org/show_bug.cgi?id=194963
4356
4357         Reviewed by Dean Jackson.
4358
4359         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4360         Do a `contains` check instead of `equals`, because in debug builds we
4361         put the GraphicsLayer pointer in a prefix.
4362
4363 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4364
4365         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4366         https://bugs.webkit.org/show_bug.cgi?id=194873
4367         <rdar://problem/46701974>
4368
4369         Reviewed by Tim Horton.