[GTK] REGRESSION(r243860): Many tests failing
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] REGRESSION(r243860): Many tests failing
4         https://bugs.webkit.org/show_bug.cgi?id=196791
5
6         Reviewed by Joanmarie Diggs.
7
8         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
9         multiple documents and check that accessibility hierarchy is updated after a navigation.
10
11         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
12         (loadChangedCallback):
13         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
14         (AccessibilityTest::AccessibilityTest):
15         (AccessibilityTest::~AccessibilityTest):
16         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
17         (AccessibilityTest::findTestServerApplication):
18         (AccessibilityTest::findDocumentWeb):
19         (AccessibilityTest::findRootObject):
20         (AccessibilityTest::waitUntilChildrenRemoved):
21         (AccessibilityTest::ensureProxy):
22         (testAtspiBasicHierarchy):
23         (beforeAll):
24         (afterAll):
25
26 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
27
28         [ews-build] Handle bug titles with unicode characters
29         https://bugs.webkit.org/show_bug.cgi?id=196802
30
31         Reviewed by Dewei Zhu.
32
33         * BuildSlaveSupport/ews-build/steps.py:
34         (ValidatePatch._is_bug_closed):
35
36 2019-04-11  Michael Saboff  <msaboff@apple.com>
37
38         Improve the Inline Cache Stats code
39         https://bugs.webkit.org/show_bug.cgi?id=196836
40
41         Reviewed by Saam Barati.
42
43         Added a new script to consolidate and arrange the output of --useICStats option.
44
45         This script merges the output from every group into one large table and sorts it from most common to
46         least common.  It also counts the slow path GetById and PutById variants and then calculates the
47         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
48         Put together, this is useful to see what property accesses are not getting cached.
49
50         * Scripts/ic-stats.py: Added.
51         (ICStats):
52         (ICStats.__init__):
53         (ICStats.parse):
54         (ICStats.dumpStats):
55         (usage):
56
57 2019-04-10  Alex Christensen  <achristensen@webkit.org>
58
59         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
60         https://bugs.webkit.org/show_bug.cgi?id=196809
61         <rdar://49800762>
62
63         Reviewed by Brady Eidson.
64
65         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
66         (TEST):
67
68 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
69
70         requestAnimationFrame should execute before the next frame
71         https://bugs.webkit.org/show_bug.cgi?id=177484
72
73         Reviewed by Simon Fraser.
74
75         Add trace points for the page RenderingUpdate.
76
77         * Tracing/SystemTracePoints.plist:
78
79 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
80
81         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
82         https://bugs.webkit.org/show_bug.cgi?id=196760
83
84         Reviewed by Don Olmstead.
85
86         vswhere.exe has been bundled since Visual Studio 2017 version
87         15.2. We shouldn't download vswhere.exe.
88
89         * Scripts/build-jsc: Do not call update-vswhere.py.
90         * Scripts/build-webkit: Ditto.
91         * Scripts/update-vswhere.py: Removed.
92         * Scripts/webkitdirs.pm:
93         (requireModulesForVSWhere): Deleted.
94         (pickCurrentVisualStudioInstallation): Deleted.
95         (visualStudioInstallDirVSWhere): Return the latest installed VS
96         installation path by using the bundled vswhere.exe.
97         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
98         (visualStudioInstallDirFallback): Removed.
99
100 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
101
102         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
103         https://bugs.webkit.org/show_bug.cgi?id=196780
104
105         Reviewed by Alexey Proskuryakov.
106
107         * BuildSlaveSupport/ews-build/steps.py:
108         * BuildSlaveSupport/ews-build/steps_unittest.py:
109
110 2019-04-10  Alex Christensen  <achristensen@webkit.org>
111
112         Add SPI WKNavigationResponse._downloadAttribute
113         https://bugs.webkit.org/show_bug.cgi?id=196755
114         <rdar://49587365>
115
116         Reviewed by Brady Eidson.
117
118         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
119         (-[NavigationResponseTestDelegate navigationResponse]):
120         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
121         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
122         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
123         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
124         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
125         (readRequest):
126         (writeResponse):
127         (TEST):
128
129 2019-04-10  Tim Horton  <timothy_horton@apple.com>
130
131         Add modern API for overriding the page's specified viewport configuration
132         https://bugs.webkit.org/show_bug.cgi?id=167734
133         <rdar://problem/30331795>
134
135         Reviewed by Simon Fraser.
136
137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
138         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
139
140 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
141
142         Add support for incremental bytecode cache updates
143         https://bugs.webkit.org/show_bug.cgi?id=195000
144
145         Reviewed by Filip Pizlo.
146
147         Exit when the initial run to generate bytecode fails.
148
149         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
150
151 2019-04-10  Alex Christensen  <achristensen@webkit.org>
152
153         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
154         https://bugs.webkit.org/show_bug.cgi?id=196744
155         <rdar://49415309>
156
157         Reviewed by Chris Dumez.
158
159         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
160         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
161
162 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
163
164         Add a way to opt into modern compatibility mode in layout tests
165         https://bugs.webkit.org/show_bug.cgi?id=196770
166         <rdar://problem/49777550>
167
168         Reviewed by Antoine Quint.
169
170         Add a new test option to enable modern compatibility mode in layout tests.
171
172         * WebKitTestRunner/TestController.cpp:
173         (WTR::updateTestOptionsFromTestHeader):
174         * WebKitTestRunner/TestController.h:
175         * WebKitTestRunner/TestOptions.h:
176         (WTR::TestOptions::hasSameInitializationOptions const):
177         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
178         (WTR::TestController::platformCreateWebView):
179         (WTR::TestController::enableModernCompatibilityMode):
180
181 2019-04-10  Andy Estes  <aestes@apple.com>
182
183         Try to fix the 32-bit watchOS build.
184
185         * TestWebKitAPI/cocoa/TestWKWebView.mm:
186         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
187
188 2019-04-10  Antoine Quint  <graouts@apple.com>
189
190         Enable Pointer Events on watchOS
191         https://bugs.webkit.org/show_bug.cgi?id=196771
192         <rdar://problem/49040909>
193
194         Reviewed by Dean Jackson.
195
196         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
197
198 2019-04-10  Philippe Normand  <pnormand@igalia.com>
199
200         Unreviewed. Fix WPE accessibility tests after r244059.
201
202         We are failing to load the injected bundle due to undefined symbol
203         AccessibilityUIElement::replaceTextInRange().
204
205         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
206         (WTR::AccessibilityUIElement::replaceTextInRange):
207
208 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
209
210         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
211         https://bugs.webkit.org/show_bug.cgi?id=196727
212
213         Reviewed by Fujii Hironori.
214
215         * MiniBrowser/win/WebKitBrowserWindow.cpp:
216         (WebKitBrowserWindow::create):
217
218 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
219
220         [ews-build] Add unit tests for PrintConfiguration
221         https://bugs.webkit.org/show_bug.cgi?id=196752
222
223         Reviewed by Dewei Zhu.
224
225         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
226
227 2019-04-09  Keith Rollin  <krollin@apple.com>
228
229         Unreviewed build maintenance -- update .xcfilelists.
230
231         * DumpRenderTree/DerivedSources-input.xcfilelist:
232         * DumpRenderTree/DerivedSources-output.xcfilelist:
233
234 2019-04-09  Zalan Bujtas  <zalan@apple.com>
235
236         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
237         https://bugs.webkit.org/show_bug.cgi?id=196743
238         <rdar://problem/43897551>
239
240         Reviewed by Tim Horton.
241
242         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
243         (TEST):
244
245 2019-04-09  Youenn Fablet  <youenn@apple.com>
246
247         Close service worker database on network process suspension
248         https://bugs.webkit.org/show_bug.cgi?id=196623
249         <rdar://problem/48930869>
250
251         Reviewed by Alex Christensen.
252
253         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
254
255 2019-04-09  Daniel Bates  <dabates@apple.com>
256
257         [iPad] Should open popover when the spacebar is pressed
258         https://bugs.webkit.org/show_bug.cgi?id=196360
259         <rdar://problem/49389129>
260
261         Reviewed by Brent Fulgham.
262
263         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
264
265         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
266         (WTR::UIScriptController::isShowingPopover const): Added.
267         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
268         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
269         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
270         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
271         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
272         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
273         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
274         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
275         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
276         (WTR::UIScriptController::isShowingPopover const): Added.
277         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
278         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
279         * TestRunnerShared/UIScriptContext/UIScriptController.h:
280         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
281         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
282         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
283         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
284         (-[TestRunnerWKWebView _willPresentPopover]): Added.
285         (-[TestRunnerWKWebView _didDismissPopover]): Added.
286         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
287         (WTR::UIScriptController::isShowingPopover const): Added.
288         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
289         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
290
291 2019-04-09  Alex Christensen  <achristensen@webkit.org>
292
293         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
294         https://bugs.webkit.org/show_bug.cgi?id=196665
295         <rdar://45115669>
296
297         Reviewed by Geoff Garen.
298
299         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
300         (goBack):
301         (+[SimpleLookupContext sharedLookupContext]):
302         (-[SimpleLookupContext lookUpURL:completionHandler:]):
303         (TEST):
304         (+[Simple3LookupContext sharedLookupContext]): Deleted.
305         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
306
307 2019-04-09  John Wilander  <wilander@apple.com>
308
309         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
310         https://bugs.webkit.org/show_bug.cgi?id=196558
311         <rdar://problem/47650245>
312
313         Reviewed by Youenn Fablet.
314
315         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
316         (TestWebKitAPI::TEST):
317             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
318
319 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
320
321         [CMake] Apple builds should use ICU_INCLUDE_DIRS
322         https://bugs.webkit.org/show_bug.cgi?id=196720
323
324         Reviewed by Konstantin Tokarev.
325
326         * TestWebKitAPI/PlatformMac.cmake:
327
328 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
329
330         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
331         https://bugs.webkit.org/show_bug.cgi?id=196694
332         <rdar://problem/48388734>
333
334         Rubber-stamped by Aakash Jain.
335
336         * Scripts/webkitpy/port/image_diff.py:
337         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
338         * Scripts/webkitpy/port/server_process.py:
339         (ServerProcess.has_available_stdout): Check if stdout has data in it.
340         (ServerProcess._wait_for_data_and_update_buffers_using_select):
341         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
342         * Scripts/webkitpy/port/server_process_mock.py:
343         (MockServerProcess.has_available_stdout):
344         * Scripts/webkitpy/port/server_process_unittest.py:
345         (TestServerProcess.serial_test_basic):
346
347 2019-04-09  Jer Noble  <jer.noble@apple.com>
348
349         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
350         https://bugs.webkit.org/show_bug.cgi?id=196097
351
352         Reviewed by Eric Carlson.
353
354         Drive-by bug fix: allow tests to play audio without a user gesture by default.
355
356         * DumpRenderTree/mac/DumpRenderTree.mm:
357         (resetWebPreferencesToConsistentValues):
358         * WebKitTestRunner/TestController.cpp:
359         (WTR::TestController::resetPreferencesToConsistentValues):
360
361 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
362
363         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
364         https://bugs.webkit.org/show_bug.cgi?id=196690
365
366         Reviewed by Michael Catanzaro.
367
368         * QueueStatusServer/config/queues.py:
369         * Scripts/webkitpy/common/config/ews.json:
370         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
371         (test_ews_name):
372
373 2019-04-09  Chris Dumez  <cdumez@apple.com>
374
375         Loads using loadHTMLString() cause flashing when process-swapping
376         https://bugs.webkit.org/show_bug.cgi?id=196714
377         <rdar://problem/49637354>
378
379         Reviewed by Antti Koivisto.
380
381         Add API test coverage.
382
383         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
384
385 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
386
387         Unreviewed. Fix ATK accessibility tests after r244059.
388
389         We are failing to load the injected bundle due to undefined symbol
390         AccessibilityUIElement::replaceTextInRange().
391
392         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
393         (WTR::AccessibilityUIElement::replaceTextInRange):
394
395 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
396
397         AX: Support API: accessibilityReplaceRange:withText
398         https://bugs.webkit.org/show_bug.cgi?id=196636
399
400         Unreviewed build fix for Windows port.
401
402         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
403         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
404
405 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
406
407         [CMake][WinCairo] Separate copied headers into different directories
408         https://bugs.webkit.org/show_bug.cgi?id=196655
409
410         Reviewed by Michael Catanzaro.
411
412         * DumpRenderTree/CMakeLists.txt:
413         * MiniBrowser/win/CMakeLists.txt:
414         * TestWebKitAPI/CMakeLists.txt:
415         * TestWebKitAPI/PlatformWin.cmake:
416
417 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
418
419         Log stack-trace for run-webkit-tests when interrupted
420         https://bugs.webkit.org/show_bug.cgi?id=176393
421         <rdar://problem/34262310>
422
423         Reviewed by Lucas Forschler.
424
425         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
426         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
427         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
428         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
429         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
430         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
431         (main): Set handlers to log stack trace on interruption.
432
433 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
434
435         AX: Support API: accessibilityReplaceRange:withText
436         https://bugs.webkit.org/show_bug.cgi?id=196636
437
438         Unreviewed build fix for Windows port.
439
440         * DumpRenderTree/AccessibilityUIElement.cpp:
441         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
442
443 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
444
445         [ews-build] Scripts using Buildbot API have CORS error
446         https://bugs.webkit.org/show_bug.cgi?id=196709
447
448         Reviewed by Alexey Proskuryakov.
449
450         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
451
452 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
453
454         AX: Support API: accessibilityReplaceRange:withText
455         https://bugs.webkit.org/show_bug.cgi?id=196636
456
457         Reviewed by Daniel Bates.
458
459         * DumpRenderTree/AccessibilityUIElement.cpp:
460         (replaceTextInRangeCallback):
461         (AccessibilityUIElement::replaceTextInRange):
462         (AccessibilityUIElement::getJSClass):
463         * DumpRenderTree/AccessibilityUIElement.h:
464         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
465         (AccessibilityUIElement::replaceTextInRange):
466         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
467         (AccessibilityUIElement::replaceTextInRange):
468         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
469         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
470         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
471         (WTR::AccessibilityUIElement::replaceTextInRange):
472         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
473         (WTR::AccessibilityUIElement::replaceTextInRange):
474
475 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
476
477         [iOS] Do not allow starting selection drags when selection views are not visible
478         https://bugs.webkit.org/show_bug.cgi?id=196686
479         <rdar://problem/49399192>
480
481         Reviewed by Tim Horton.
482
483         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
484         also add some new API tests to cover scenarios where the web view is not first responder.
485
486         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
487         (TestWebKitAPI::TEST):
488         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
489
490         Add a switch to optionally make the web view first responder when starting the simulated drag.
491
492         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
493         (-[DragAndDropSimulator initWithWebView:]):
494         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
495
496 2019-04-08  Justin Fan  <justin_fan@apple.com>
497
498         [Web GPU] Fix Web GPU experimental feature on iOS
499         https://bugs.webkit.org/show_bug.cgi?id=196632
500
501         Reviewed by Myles C. Maxfield.
502
503         Properly make Web GPU available on iOS 11+.
504
505         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
506
507 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
508
509         [ews-build] Do not upload archive when Compile Fails
510         https://bugs.webkit.org/show_bug.cgi?id=196674
511
512         Reviewed by Alexey Proskuryakov.
513
514         * BuildSlaveSupport/ews-build/factories.py:
515         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
516         * BuildSlaveSupport/ews-build/steps.py:
517         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
518         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
519         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
520
521 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
522
523         Enable DFG on MIPS
524         https://bugs.webkit.org/show_bug.cgi?id=196689
525
526         Reviewed by Žan Doberšek.
527
528         Since the bytecode change, we enabled the baseline JIT on mips in
529         r240432, but DFG is still missing. With this change, all tests are
530         passing on a ci20 board.
531
532         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
533
534 2019-04-08  Philippe Normand  <pnormand@igalia.com>
535
536         [Flatpak] Second run update-webkitwpe-flatpak fails
537         https://bugs.webkit.org/show_bug.cgi?id=192702
538
539         Reviewed by Carlos Garcia Campos.
540
541         * flatpak/flatpakutils.py:
542         (FlatpakObject.flatpak): Fix typo.
543         (FlatpakPackage.install): When installing, also update to the configured remote commit.
544         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
545
546 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
547
548         [GTK][WPE] outlook.live.com displays old-fashioned UI
549         https://bugs.webkit.org/show_bug.cgi?id=196642
550
551         Reviewed by Carlos Garcia Campos.
552
553         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
554         (TestWebKitAPI::TEST): New Mac platform quirk test.
555
556 2019-04-07  Commit Queue  <commit-queue@webkit.org>
557
558         Unreviewed, rolling out r243956.
559         https://bugs.webkit.org/show_bug.cgi?id=196688
560
561         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
562         by aakashjain on #webkit).
563
564         Reverted changeset:
565
566         "Clicking "Go Back" from a safe browsing warning from an
567         iframe should navigate the WKWebView back to the previous
568         page"
569         https://bugs.webkit.org/show_bug.cgi?id=196665
570         https://trac.webkit.org/changeset/243956
571
572 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
573
574         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
575         https://bugs.webkit.org/show_bug.cgi?id=196669
576
577         Reviewed by Geoffrey Garen.
578
579         Added three new unit tests for WeakHashSet.
580
581         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
582         (WTF_WeakPtr.WeakHashSetConstObjects):
583         (WTF_WeakPtr.WeakHashSetComputesEmpty):
584         (WTF_WeakPtr.WeakHashSetComputeSize):
585
586 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
587
588         Hide next and previous form control buttons when WKWebView is editable
589         https://bugs.webkit.org/show_bug.cgi?id=196672
590         <rdar://problem/35625321>
591
592         Reviewed by Tim Horton.
593
594         Add a new API test.
595
596         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
597         (-[TestWKWebView lastTrailingBarButtonGroup]):
598         (TestWebKitAPI::TEST):
599         * TestWebKitAPI/ios/UIKitSPI.h:
600
601 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
602
603         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
604         https://bugs.webkit.org/show_bug.cgi?id=196077
605         <rdar://problem/49108202>
606
607         Reviewed by Chris Dumez.
608
609         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
610         on new web view.
611
612         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
613
614 2019-04-05  Saam Barati  <sbarati@apple.com>
615
616         Make compare-results understand MotionMark
617         https://bugs.webkit.org/show_bug.cgi?id=196666
618
619         Reviewed by Yusuke Suzuki.
620
621         * Scripts/compare-results:
622         (PLT5Results):
623         (detectMotionMark):
624         (detectMotionMark1_1):
625         (motionMarkResults):
626         (motionMark1_1Results):
627         (detectBenchmark):
628         (biggerIsBetter):
629         (main):
630
631 2019-04-05  Alex Christensen  <achristensen@webkit.org>
632
633         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
634         https://bugs.webkit.org/show_bug.cgi?id=196665
635         <rdar://45115669>
636
637         Reviewed by Geoff Garen.
638
639         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
640         (goBack):
641         (+[SimpleLookupContext sharedLookupContext]):
642         (-[SimpleLookupContext lookUpURL:completionHandler:]):
643         (TEST):
644         (+[Simple3LookupContext sharedLookupContext]): Deleted.
645         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
646
647 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
648
649         [ews-build] Add configuration and architecture for windows builders
650         https://bugs.webkit.org/show_bug.cgi?id=196660
651
652         Reviewed by Lucas Forschler.
653
654         * BuildSlaveSupport/ews-build/config.json:
655
656 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
657
658         webkitpy: Don't run subsequent rounds if interrupted
659         https://bugs.webkit.org/show_bug.cgi?id=196646
660
661         Reviewed by Aakash Jain.
662
663         * Scripts/webkitpy/layout_tests/controllers/manager.py:
664         (Manager.run): Bail out if interrupted.
665
666 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
667
668         Test sessionStorage in PSON private browsing mode
669         https://bugs.webkit.org/show_bug.cgi?id=196561
670
671         Reviewed by Alex Christensen.
672
673         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
674
675 2019-04-05  Commit Queue  <commit-queue@webkit.org>
676
677         Unreviewed, rolling out r243833.
678         https://bugs.webkit.org/show_bug.cgi?id=196645
679
680         This change breaks build of WPE and GTK ports (Requested by
681         annulen on #webkit).
682
683         Reverted changeset:
684
685         "[CMake][WTF] Mirror XCode header directories"
686         https://bugs.webkit.org/show_bug.cgi?id=191662
687         https://trac.webkit.org/changeset/243833
688
689 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
690
691         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
692         https://bugs.webkit.org/show_bug.cgi?id=196635
693
694         Reviewed by Antti Koivisto.
695         
696         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
697         for a test to enable async frame scrolling via:
698             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
699         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
700         
701         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
702
703         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
704         (WTR::InjectedBundle::beginTesting):
705         * WebKitTestRunner/TestController.cpp:
706         (WTR::TestController::resetPreferencesToConsistentValues):
707
708 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
709
710         Use a correct LC_RPATH when building with ASan
711         https://bugs.webkit.org/show_bug.cgi?id=196576
712
713         Reviewed by David Kilzer.
714
715         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
716         so that ../Frameworks is checked. This is simpler and more reliable than updating
717         each SPC service xcconfig.
718
719 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
720
721         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
722         https://bugs.webkit.org/show_bug.cgi?id=196629
723
724         Reviewed by Lucas Forschler.
725
726         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
727
728 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
729
730         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
731         https://bugs.webkit.org/show_bug.cgi?id=196618
732
733         Reviewed by Lucas Forschler.
734
735         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
736         (StatusBubble): Added QUEUE_TRIGGERS.
737         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
738         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
739         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
740         its parent(builder).
741
742 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
743
744         [ews-app] Status-bubble steps are sometimes displayed in reverse order
745         https://bugs.webkit.org/show_bug.cgi?id=196625
746
747         Reviewed by Lucas Forschler.
748
749         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
750         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
751
752 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
753
754         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
755         https://bugs.webkit.org/show_bug.cgi?id=196630
756
757         Reviewed by Wenson Hsieh.
758
759         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
760
761 2019-04-04  Youenn Fablet  <youenn@apple.com>
762
763         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
764         https://bugs.webkit.org/show_bug.cgi?id=196543
765
766         Reviewed by Alex Christensen.
767
768         * WebKitTestRunner/TestController.cpp:
769         (WTR::TestController::generatePageConfiguration):
770
771 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
772
773         [ews-app] Status bubble should not display skipped buildbot steps
774         https://bugs.webkit.org/show_bug.cgi?id=196584
775
776         Reviewed by Lucas Forschler.
777
778         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
779
780 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
781
782         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
783         https://bugs.webkit.org/show_bug.cgi?id=196620
784
785         Reviewed by Lucas Forschler.
786
787         * BuildSlaveSupport/ews-app/ews/config.py:
788
789 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
790
791         [Win] DumpRenderTreeWatchDog.py is not checked into source
792         https://bugs.webkit.org/show_bug.cgi?id=196567
793         <rdar://problem/49525901>
794
795         Reviewed by Lucas Forschler.
796
797         This script is used on Win EWS bots to terminate hanging DRT processes.
798
799         * EWSTools/dumprendertreewatchdog.py: Added.
800
801 2019-04-04  Chris Dumez  <cdumez@apple.com>
802
803         Unreviewed, roll out r243858 which made tests time out.
804
805         Disable new API tests on Windows instead.
806
807         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
808         (TestWebKitAPI::TEST):
809
810 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
811
812         [ATK] Cleanup WebPageAccessibilityObjectAtk
813         https://bugs.webkit.org/show_bug.cgi?id=196537
814
815         Reviewed by Michael Catanzaro.
816
817         Also consider files under atk directories as exceptions for GObject conventions.
818
819         * Scripts/webkitpy/style/checkers/cpp.py:
820         (check_identifier_name_in_declaration):
821
822 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
823
824         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
825         https://bugs.webkit.org/show_bug.cgi?id=196588
826         <rdar://problem/49365787>
827
828         Unreviewed build fix for Windows port.
829
830         error C3861: 'kill': identifier not found
831
832         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
833         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
834
835 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
836
837         [ews-build] Cancel build and similar operations should have authentication
838         https://bugs.webkit.org/show_bug.cgi?id=196520
839
840         Reviewed by Dewei Zhu.
841
842         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
843         environment variables.
844
845 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
846
847         [ews-build] Do not trigger queues which are not in production yet
848         https://bugs.webkit.org/show_bug.cgi?id=196581
849
850         Reviewed by Dewei Zhu.
851
852         * BuildSlaveSupport/ews-build/config.json:
853
854 2019-04-03  Chris Dumez  <cdumez@apple.com>
855
856         Unreviewed, fix typo in the name of API test added in r243848.
857
858         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
859         (TestWebKitAPI::TEST):
860
861 2019-04-03  Chris Dumez  <cdumez@apple.com>
862
863         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
864         https://bugs.webkit.org/show_bug.cgi?id=196588
865         <rdar://problem/49365787>
866
867         Reviewed by Ryosuke Niwa.
868
869         Add API test coverage.
870
871         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
872         (TestWebKitAPI::nullJavaScriptCallback):
873         (TestWebKitAPI::didCrashCheckFrames):
874         (TestWebKitAPI::TEST):
875
876 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
877
878         run-webkit-tests: Upload test results (new results database)
879         https://bugs.webkit.org/show_bug.cgi?id=196577
880         <rdar://problem/34841155>
881
882         Reviewed by Lucas Forschler.
883
884         * Scripts/webkitpy/layout_tests/controllers/manager.py:
885         (Manager.run): Upload results after each device shard, since the configuration will be
886         different for each device.
887         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
888         uploaded to a results database.
889         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
890         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
891
892 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
893
894         -apple-trailing-word is needed for browser detection
895         https://bugs.webkit.org/show_bug.cgi?id=196575
896
897         Unreviewed.
898
899         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
900
901 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
902
903         [CMake][WTF] Mirror XCode header directories
904         https://bugs.webkit.org/show_bug.cgi?id=191662
905
906         Reviewed by Konstantin Tokarev.
907
908         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
909         builds.
910
911         * CMakeLists.txt:
912         * DumpRenderTree/CMakeLists.txt:
913         * DumpRenderTree/PlatformWin.cmake:
914         * MiniBrowser/win/CMakeLists.txt:
915         * TestWebKitAPI/CMakeLists.txt:
916         * TestWebKitAPI/PlatformWin.cmake:
917         * WebKitTestRunner/PlatformGTK.cmake:
918         * WebKitTestRunner/PlatformWin.cmake:
919
920 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
921
922         [ews-app] Status bubble should not display certain infrastructure status messages
923         https://bugs.webkit.org/show_bug.cgi?id=196550
924
925         Reviewed by Lucas Forschler.
926
927         Do not display the steps which are un-needed for end-user. This information is still avaiable
928         if the user click on the bubble and look at the Buildbot build.
929         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
930         (StatusBubble._steps_messages):
931         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
932
933 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
934
935         [ews-build] Use https for sending data to ews-app
936         https://bugs.webkit.org/show_bug.cgi?id=196492
937
938         Reviewed by Lucas Forschler.
939
940         * BuildSlaveSupport/ews-build/events.py:
941
942 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
943
944         Remove support for -apple-trailing-word
945         https://bugs.webkit.org/show_bug.cgi?id=196525
946
947         Reviewed by Zalan Bujtas.
948
949         This CSS property is nonstandard and not used.
950
951         * Scripts/webkitperl/FeatureList.pm:
952         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
953
954 2019-04-03  Youenn Fablet  <youenn@apple.com>
955
956         Add a test for DOMCache on multiple browsing in case of private browsing
957         https://bugs.webkit.org/show_bug.cgi?id=196524
958
959         Reviewed by Alex Christensen.
960
961         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
962         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
963
964 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
965
966         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
967         https://bugs.webkit.org/show_bug.cgi?id=196540
968
969         Reviewed by Aakash Jain.
970
971         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
972
973 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
974
975         Add plumbing for a compatibility mode preference in WebKit
976         https://bugs.webkit.org/show_bug.cgi?id=196005
977
978         Reviewed by Tim Horton.
979
980         Add new API tests.
981
982         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
983         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
984
985 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
986
987         [WPE][GTK] Update libsrtp dependency package for Debian
988         https://bugs.webkit.org/show_bug.cgi?id=196528
989
990         Reviewed by Frédéric Wang.
991
992         * gtk/install-dependencies:
993         * wpe/install-dependencies:
994
995 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
996
997         [WK2] Add support for Window's beforeprint / afterprint events
998         https://bugs.webkit.org/show_bug.cgi?id=196478
999         <rdar://problem/49535124>
1000
1001         Unreviewed build fix for MSVC.
1002
1003         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1004
1005         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1006
1007         * WebKitTestRunner/TestController.cpp:
1008         (WTR::printFrame): Use int and float literals.
1009
1010 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1011
1012         [ews-build] Reassign bots to queues
1013
1014         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1015
1016 2019-04-02  Chris Dumez  <cdumez@apple.com>
1017
1018         [WK2] Add support for Window's beforeprint / afterprint events
1019         https://bugs.webkit.org/show_bug.cgi?id=196478
1020
1021         Reviewed by Alex Christensen.
1022
1023         Add minimal implementation for printFrame in WebKitTestRunner.
1024
1025         * WebKitTestRunner/TestController.cpp:
1026         (WTR::printFrame):
1027         (WTR::TestController::createOtherPage):
1028         (WTR::TestController::createWebViewWithOptions):
1029
1030 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1031
1032         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1033         https://bugs.webkit.org/show_bug.cgi?id=196491
1034
1035         Reviewed by Lucas Forschler.
1036
1037         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1038
1039 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1040
1041         [ews-build] Configure buildbot try credentials in environment variables
1042         https://bugs.webkit.org/show_bug.cgi?id=196501
1043
1044         Reviewed by Lucas Forschler.
1045
1046         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1047         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1048         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1049
1050 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1051
1052         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1053         https://bugs.webkit.org/show_bug.cgi?id=196496
1054         <rdar://problem/49521634>
1055
1056         Reviewed by Chris Dumez.
1057
1058         Add new API tests (see WebKit ChangeLog for more detail).
1059
1060         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1061         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1062         (TEST):
1063
1064 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1065
1066         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1067         <https://webkit.org/b/196499>
1068
1069         Reviewed by Alexey Proskuryakov.
1070
1071         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1072         ENABLE_ADDRESS_SANITIZER.
1073
1074 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1075
1076         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1077         https://bugs.webkit.org/show_bug.cgi?id=182757
1078
1079         Reviewed by Don Olmstead.
1080
1081         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1082         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1083
1084 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1085
1086         run-api-tests: Upload test results
1087         https://bugs.webkit.org/show_bug.cgi?id=196323
1088         <rdar://problem/49356714>
1089
1090         Reviewed by Lucas Forschler.
1091
1092         * Scripts/webkitpy/api_tests/manager.py:
1093         (Manager):
1094         (Manager.run): Upload results to a results database.
1095         * Scripts/webkitpy/api_tests/run_api_tests.py:
1096         (parse_args): Add upload arguments.
1097         * Scripts/webkitpy/port/base.py:
1098         (Port):
1099         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1100         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1101         with commits from any other associated repositories.
1102         * Scripts/webkitpy/port/device.py:
1103         (Device):
1104         (Device.build_version): Access build_versoin of underlying platform device.
1105         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1106         (IOSSimulatorTest):
1107         (IOSSimulatorTest.test_configuration_for_upload):
1108         * Scripts/webkitpy/port/device_port.py:
1109         (DevicePort):
1110         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1111         the same as the machine uploading results.
1112         * Scripts/webkitpy/port/mac.py:
1113         (MacPort):
1114         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1115         * Scripts/webkitpy/port/mac_unittest.py:
1116         (MacTest):
1117         (MacTest.test_configuration_for_upload):
1118         * Scripts/webkitpy/xcode/simulated_device.py:
1119         (SimulatedDeviceManager._create_device_with_runtime):
1120         (SimulatedDevice.__init__): Create simulated device with a build_version.
1121         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1122         (test_existing_simulator):
1123
1124 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1125
1126         Remove extra newline characters (Follow-up fix to r243707)
1127
1128         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1129
1130 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1131
1132         [ews-app] Use API_KEY to accept results data
1133         https://bugs.webkit.org/show_bug.cgi?id=196461
1134
1135         Reviewed by Dewei Zhu.
1136
1137         * BuildSlaveSupport/ews-app/ews/views/results.py:
1138         (Results.post): Validate EWS_API_KEY before accepting any data.
1139         * BuildSlaveSupport/ews-build/events.py:
1140         (Events.sendData): Send EWS_API_KEY if available along with event data.
1141
1142 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1143
1144         Unable to copy and paste a PDF from Notes into Mail compose body
1145         https://bugs.webkit.org/show_bug.cgi?id=196442
1146         <rdar://problem/48573098>
1147
1148         Reviewed by Tim Horton.
1149
1150         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1151         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1152         to be specified on the item providers.
1153
1154         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1155         (TestWebKitAPI::mapItemForTesting):
1156         (TestWebKitAPI::contactItemForTesting):
1157
1158 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1159
1160         Make UIWKDocumentContext rects per-character instead of per-word
1161         https://bugs.webkit.org/show_bug.cgi?id=196459
1162
1163         Reviewed by Wenson Hsieh.
1164
1165         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1166         (TEST):
1167         Adjust test results due to switching to per-character rects.
1168
1169 2019-04-01  Chris Dumez  <cdumez@apple.com>
1170
1171         UIProcess crash when a prewarmed process is terminated
1172         https://bugs.webkit.org/show_bug.cgi?id=196451
1173         <rdar://problem/49245471>
1174
1175         Reviewed by Geoffrey Garen.
1176
1177         Add API test coverage.
1178
1179         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1180         (TEST):
1181
1182 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1183
1184         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1185         https://bugs.webkit.org/show_bug.cgi?id=196449
1186
1187         Reviewed by Lucas Forschler.
1188
1189         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1190         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1191         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1192         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1193
1194 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1195
1196         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1197         https://bugs.webkit.org/show_bug.cgi?id=196444
1198
1199         Reviewed by Lucas Forschler.
1200
1201         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1202
1203 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1204
1205         Add SPI to canonicalize NSURLs with WTF::URL
1206         https://bugs.webkit.org/show_bug.cgi?id=196415
1207         <rdar://problem/44980271>
1208
1209         Reviewed by Darin Adler.
1210
1211         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1212         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1213         (TestWebKitAPI::TEST):
1214
1215 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1216
1217         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1218         https://bugs.webkit.org/show_bug.cgi?id=196441
1219
1220         Reviewed by Carlos Garcia Campos.
1221
1222         Don't cache the wpe_view_backend object that might not exist yet at the
1223         time of EventSenderProxy constructor invocation, but instead retrieve
1224         that object whenever it's required for event dispatching. This should
1225         avoid crashes in this constructor now that it's invoked before any
1226         PlatformWindow has been set up (as changed in r243496).
1227
1228         * WebKitTestRunner/EventSenderProxy.h:
1229         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1230         (WTR::viewBackend):
1231         (WTR::EventSenderProxy::EventSenderProxy):
1232         (WTR::EventSenderProxy::mouseDown):
1233         (WTR::EventSenderProxy::mouseUp):
1234         (WTR::EventSenderProxy::mouseMoveTo):
1235         (WTR::EventSenderProxy::mouseScrollBy):
1236         (WTR::EventSenderProxy::keyDown):
1237         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1238
1239 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1240
1241         [Win][WebKit] MiniBrowser should support high DPI display
1242         https://bugs.webkit.org/show_bug.cgi?id=196391
1243
1244         Reviewed by Alex Christensen.
1245
1246         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1247         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1248         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1249         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1250
1251 2019-03-31  Sam Weinig  <weinig@apple.com>
1252
1253         Remove more i386 specific configurations
1254         https://bugs.webkit.org/show_bug.cgi?id=196430
1255
1256         Reviewed by Alexey Proskuryakov.
1257
1258         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1259         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1260
1261 2019-03-31  Andy Estes  <aestes@apple.com>
1262
1263         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1264         https://bugs.webkit.org/show_bug.cgi?id=196433
1265         <rdar://problem/49293305>
1266
1267         Reviewed by Tim Horton.
1268
1269         Enhanced API test coverage to include all navigation response policy decisions in both
1270         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1271
1272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1273         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1274         (TestWebKitAPI::TEST):
1275         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1276         (readFile):
1277         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1278         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1279         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1280         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1281         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1282         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1283         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1284         (-[QuickLookDelegate _downloadDidStart:]):
1285         (-[QuickLookDelegate _download:didReceiveResponse:]):
1286         (-[QuickLookDelegate _download:didReceiveData:]):
1287         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1288         (-[QuickLookDelegate _downloadDidFinish:]):
1289         (-[QuickLookDelegate _download:didFailWithError:]):
1290         (-[QuickLookDelegate _downloadDidCancel:]):
1291         (-[QuickLookDelegate verifyDownload]):
1292         (runTest):
1293         (runTestDecideBeforeLoading):
1294         (runTestDecideAfterLoading):
1295         (TEST):
1296         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1297         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1298         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1299         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1300         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1301         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1302         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1303         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1304         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1305         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1306         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1307         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1308         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1309         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1310
1311 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1312
1313         [CMake] add testdfg as target with build-jsc
1314         https://bugs.webkit.org/show_bug.cgi?id=196393
1315
1316         Reviewed by Saam Barati.
1317
1318         Added testdfg as one of the targets to build when
1319         using CMake.
1320
1321         * Scripts/build-jsc:
1322
1323 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1324
1325         Delete WebMetal implementation in favor of WebGPU
1326         https://bugs.webkit.org/show_bug.cgi?id=195418
1327
1328         Reviewed by Dean Jackson.
1329
1330         * DumpRenderTree/mac/DumpRenderTree.mm:
1331         (enableExperimentalFeatures):
1332         (resetWebPreferencesToConsistentValues):
1333         * Scripts/webkitperl/FeatureList.pm:
1334         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1335         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1336         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1337         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1338         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1339         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1340         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1341         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1342         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1343         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1344         (WTR::InjectedBundle::beginTesting):
1345         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1346         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1347         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1348
1349 2019-03-29  Chris Dumez  <cdumez@apple.com>
1350
1351         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1352         https://bugs.webkit.org/show_bug.cgi?id=196405
1353         <rdar://problem/49428130>
1354
1355         Reviewed by Wenson Hsieh.
1356
1357         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1358         the popover presentation methods to be no-ops. Use this in the new test added in
1359         r243523 so that we do not swizzle those methods for all tests. This is needed because
1360         those WatchOS tests rely on the popover getting presented and interactive.
1361
1362         * WebKitTestRunner/TestController.cpp:
1363         (WTR::updateTestOptionsFromTestHeader):
1364         * WebKitTestRunner/TestController.h:
1365         * WebKitTestRunner/TestOptions.h:
1366         (WTR::TestOptions::hasSameInitializationOptions const):
1367         * WebKitTestRunner/ios/TestControllerIOS.mm:
1368         (WTR::TestController::platformInitialize):
1369         (WTR::TestController::platformResetStateToConsistentValues):
1370
1371 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1372
1373         [Curl] Add Server Trust Evaluation Support.
1374         https://bugs.webkit.org/show_bug.cgi?id=191646
1375
1376         Reviewed by Fujii Hironori.
1377
1378         Implemented MiniBrowser UI for asking if user trusts the server.
1379
1380         * MiniBrowser/win/Common.cpp:
1381         (askServerTrustEvaluation):
1382         (replaceString):
1383         * MiniBrowser/win/Common.h:
1384         * MiniBrowser/win/MiniBrowserLib.rc:
1385         * MiniBrowser/win/MiniBrowserLibResource.h:
1386         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1387         (createPEMString):
1388         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1389         (WebKitBrowserWindow::canTrustServerCertificate):
1390         * MiniBrowser/win/WebKitBrowserWindow.h:
1391
1392 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1393
1394         Implement ResizeObserver.
1395         https://bugs.webkit.org/show_bug.cgi?id=157743
1396
1397         Reviewed by Simon Fraser.
1398
1399         Support resizeObserverEnabled webPreferences.
1400
1401         * DumpRenderTree/TestOptions.cpp:
1402         (TestOptions::TestOptions):
1403         * DumpRenderTree/TestOptions.h:
1404         * DumpRenderTree/mac/DumpRenderTree.mm:
1405         (setWebPreferencesForTestOptions):
1406         * DumpRenderTree/win/DumpRenderTree.cpp:
1407         (enableExperimentalFeatures):
1408         * Scripts/webkitperl/FeatureList.pm:
1409         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1410
1411 2019-03-28  John Wilander  <wilander@apple.com>
1412
1413         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1414         https://bugs.webkit.org/show_bug.cgi?id=196281
1415         <rdar://problem/48938748>
1416
1417         Reviewed by Alex Christensen.
1418
1419         This patch adds the function isStatisticsHasLocalStorage() to the
1420         TestRunner. With it, the page can query the WebsiteDataStore in the
1421         UI process to make sure that it sees LocalStorage.
1422
1423         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1424         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1425         (WTR::TestRunner::isStatisticsHasLocalStorage):
1426         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1427         * WebKitTestRunner/TestController.cpp:
1428         (WTR::TestController::isStatisticsHasLocalStorage):
1429         * WebKitTestRunner/TestController.h:
1430         * WebKitTestRunner/TestInvocation.cpp:
1431         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1432
1433 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1434
1435         API::Data::createWithoutCopying should do a null check before calling CFRelease
1436         https://bugs.webkit.org/show_bug.cgi?id=196276
1437         <rdar://problem/48059859>
1438
1439         Reviewed by Alex Christensen.
1440
1441         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1442
1443         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1444         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1445         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1446         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1447         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1448         (TestWebKitAPI::TEST):
1449
1450 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1451
1452         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1453         https://bugs.webkit.org/show_bug.cgi?id=186276
1454
1455         Reviewed by Carlos Garcia Campos.
1456
1457         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1458         (webViewLoadChanged):
1459         (testWebResourceGetDataError):
1460         (testWebResourceGetDataEmpty):
1461         (beforeAll):
1462         (webViewloadChanged): Deleted.
1463
1464 2019-03-27  Andy Estes  <aestes@apple.com>
1465
1466         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1467         https://bugs.webkit.org/show_bug.cgi?id=196317
1468
1469         Reviewed by Dan Bernstein.
1470
1471         package-root copies built products into a staging directory using ditto(1), which does not
1472         follow symbolic links as it traverses a directory. Now that the files in
1473         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1474         itself, these become broken links when ditto'd into the staging directory.
1475
1476         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1477
1478         * Scripts/package-root:
1479
1480 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1481
1482         [ews-app] Update display text of Submit for ews analysis
1483         https://bugs.webkit.org/show_bug.cgi?id=196309
1484
1485         Reviewed by Dewei Zhu.
1486
1487         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1488
1489 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1490
1491         run-webkit-tests should check for leaks in WebKit processes
1492         <https://webkit.org/b/193772>
1493         <rdar://problem/46526680>
1494
1495         Reviewed by Ryosuke Niwa.
1496
1497         This works by doing the following:
1498         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1499           The list of child processes are returned one per line:
1500           process.name: pid
1501         - Run the "#LIST CHILD PROCESSES" command just before the
1502           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1503           processes on the ServerProcess object.
1504         - When the `--leaks` switch is handled, run check_for_leaks() on
1505           each child process after the main test harness.
1506
1507         * DumpRenderTree/mac/DumpRenderTree.mm:
1508         (handleControlCommand):
1509         - Use strncmp() instead of strcmp().
1510         - Add support for handling "#LIST CHILD PROCESSES" command.
1511
1512         * Scripts/webkitpy/port/base.py:
1513         (Port.check_for_leaks):
1514         * Scripts/webkitpy/port/darwin.py:
1515         (DarwinPort.check_for_leaks):
1516         - Rename redundant 'process_pid' argument to 'process_id'.
1517
1518         * Scripts/webkitpy/port/driver.py:
1519         (Driver.do_post_tests_work):
1520         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1521           longer the only command this sends to WebKitTestRunner.
1522         - If the `--leaks` switch is present, send the
1523           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1524           result using Port.set_webkit_processes().
1525         (Driver._parse_child_processes_output):
1526         - Add helper method to parse list of child process names and
1527           process IDs returned from WebKitTestRunner.
1528
1529         * Scripts/webkitpy/port/ios_device.py:
1530         (IOSDevicePort.check_for_leaks):
1531         - Rename redundant 'process_pid' argument to 'process_id'.
1532
1533         * Scripts/webkitpy/port/leakdetector.py:
1534         (LeakDetector._parse_leaks_output):
1535         - Return early if there is no leaks_output.
1536         (LeakDetector.check_for_leaks):
1537         - Rename redundant 'process_pid' argument to 'process_id'.
1538
1539         * Scripts/webkitpy/port/server_process.py:
1540         (ServerProcess.__init__):
1541         (ServerProcess.child_processes):
1542         (ServerProcess.set_child_processes):
1543         - Add instance variable to Port to store list of child process
1544           names and process IDs returned from WebKitTestRunner.
1545         (ServerProcess._start):
1546         - Clear self._child_processes.
1547         (ServerProcess.stop):
1548         - If self._child_processes is set, call
1549           self._port.check_for_leaks() for each child process.
1550
1551         * Scripts/webkitpy/port/server_process_unittest.py:
1552         (TrivialMockPort.check_for_leaks):
1553         - Rename redundant 'process_pid' argument to 'process_id'.
1554
1555         * Scripts/webkitpy/port/simulator_process.py:
1556         (SimulatorProcess.stop):
1557         - If self._child_processes is set, call
1558           self._port.check_for_leaks() for each child process.
1559
1560         * Scripts/webkitpy/port/watch_device.py:
1561         (WatchDevicePort.check_for_leaks):
1562         - Rename redundant 'process_pid' argument to 'process_id'.
1563
1564         * WebKitTestRunner/TestController.cpp:
1565         (WTR::TestController::dumpResponse):
1566         - Extract method from findAndDumpWorldLeaks() so that it may be
1567           reused by findAndDumpWebKitProcessIdentifiers().
1568         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1569         - Add method to output process name and process ID of both the
1570           WebContent and Networking processes.
1571         (WTR::TestController::findAndDumpWorldLeaks):
1572         - Fix missing newline in output when there were no abandoned
1573           documents.
1574         - Call dumpResponse() for extracted code.
1575         (WTR::TestController::handleControlCommand):
1576         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1577         - Use strncmp() instead of strcmp().
1578         - Call findAndDumpWebKitProcessIdentifiers() when
1579           "#LIST CHILD PROCESSES" command is sent.
1580         * WebKitTestRunner/TestController.h:
1581         (WTR::TestController::dumpResponse):
1582         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1583         - Declare methods.
1584
1585 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1586
1587         Unreviewed. Add GLib API test cases after r243434.
1588
1589         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1590         (testWebViewActiveURI):
1591         (serverCallback):
1592         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1593         (sendRequestCallback):
1594
1595 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1596
1597         Geolocation request not complete when watch request was started in a different web process
1598         https://bugs.webkit.org/show_bug.cgi?id=195996
1599
1600         Reviewed by Alex Christensen.
1601
1602         Add a test case.
1603
1604         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1605         (TestWebKitAPI::runJavaScriptAlert):
1606         (TestWebKitAPI::TEST):
1607
1608 2019-03-26  Keith Rollin  <krollin@apple.com>
1609
1610         Update the way generate-xcfilelists returns strings from functions
1611         https://bugs.webkit.org/show_bug.cgi?id=195975
1612         <rdar://problem/49040807>
1613
1614         Reviewed by Dean Jackson.
1615
1616         There are places where generate-xcfilelists executes assignments with
1617         statements like:
1618
1619             FOO=$(some_function)
1620
1621         where "some_function" return a string by echoing it. E.g.
1622
1623             some_function()
1624             {
1625                 echo "Hello, World"
1626             }
1627
1628         This is a common idiom, but it has a problem if "some_function" needs
1629         to call "exit" in an attempt to halt the entire script right then and
1630         there. Since "some_function" is called inside of $(), it's being
1631         executed in a sub-shell. Calling exit in that sub-shell simply exits
1632         that shell; it doesn't not exit the outer shell in which the main part
1633         of the script is still running. As such, the main script keeps
1634         executing when the intent was for the script to halt.
1635
1636         The solution to this is to use a different idiom for returning
1637         strings. The one we now is to pass in the name of the variable to
1638         receive the string result:
1639
1640             some_function()
1641             {
1642                 variable_name=$1
1643                 eval $variable_name ="Hello, World"
1644             }
1645
1646         The call site now looks like
1647
1648             some_function FOO
1649
1650         Because there's no invocation of a sub-shell, some_function can now
1651         call "exit" if it wants to, and the entire script will exit at that
1652         point.
1653
1654         * Scripts/generate-xcfilelists:
1655
1656 2019-03-26  Chris Dumez  <cdumez@apple.com>
1657
1658         Add basic layout test coverage for File Picker on iOS
1659         https://bugs.webkit.org/show_bug.cgi?id=196265
1660
1661         Reviewed by Wenson Hsieh.
1662
1663         Add layout test infrastructure to test the file picker on iOS.
1664
1665         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1666         (WTR::UIScriptController::dismissFilePicker):
1667         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1668         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1669         (WTR::UIScriptController::dismissFilePicker):
1670         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1671         * WebKitTestRunner/TestController.cpp:
1672         (WTR::TestController::createWebViewWithOptions):
1673         (WTR::updateTestOptionsFromTestHeader):
1674         * WebKitTestRunner/TestOptions.h:
1675         (WTR::TestOptions::hasSameInitializationOptions const):
1676         * WebKitTestRunner/ios/TestControllerIOS.mm:
1677         (overridePresentViewController):
1678         (WTR::TestController::platformInitialize):
1679         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1680         (WTR::UIScriptController::dismissFilePicker):
1681
1682 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1683
1684         Implement async paste method on UIWKInteractionViewProtocol
1685         https://bugs.webkit.org/show_bug.cgi?id=196267
1686         <rdar://problem/49236346>
1687
1688         Reviewed by Tim Horton.
1689
1690         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1691         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1692         are now a part of all iOS 12 internal SDKs.
1693
1694         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1695
1696         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1697         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1698
1699         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1700         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1701         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1702         * TestWebKitAPI/ios/UIKitSPI.h:
1703
1704 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1705
1706         [ews-build] Use PostgreSQL for ews.webkit.org database
1707         https://bugs.webkit.org/show_bug.cgi?id=196270
1708
1709         Reviewed by Lucas Forschler.
1710
1711         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1712
1713 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1714
1715         [ews] Reset simctl states on reboot
1716         https://bugs.webkit.org/show_bug.cgi?id=196260
1717
1718         Rubber-stamped by Aakash Jain.
1719
1720         * EWSTools/start-queue-mac.sh:
1721
1722 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1723
1724         [ews-build] Use PostgreSQL for ews-build database
1725         https://bugs.webkit.org/show_bug.cgi?id=196229
1726
1727         Reviewed by Lucas Forschler.
1728
1729         * BuildSlaveSupport/ews-build/master.cfg:
1730
1731 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1732
1733         [ews-build] Get master_hostname dynamically in master.cfg
1734         https://bugs.webkit.org/show_bug.cgi?id=196255
1735
1736         Reviewed by Lucas Forschler.
1737
1738         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1739         send events data in test mode.
1740
1741 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1742
1743         [ews-app] Set db_constraint to False for Foreign Keys
1744         https://bugs.webkit.org/show_bug.cgi?id=196252
1745
1746         Reviewed by Lucas Forschler.
1747
1748         * BuildSlaveSupport/ews-app/ews/models/build.py:
1749         * BuildSlaveSupport/ews-app/ews/models/step.py:
1750
1751 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1752
1753         [ews-build] is_test_mode_enabled should default to True
1754         https://bugs.webkit.org/show_bug.cgi?id=196248
1755
1756         Reviewed by Lucas Forschler.
1757
1758         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1759
1760 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1761
1762         [ews-app] Add webkitperl to ENABLED_QUEUES
1763         https://bugs.webkit.org/show_bug.cgi?id=196253
1764
1765         Reviewed by Lucas Forschler.
1766
1767         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1768
1769 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1770
1771         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1772         https://bugs.webkit.org/show_bug.cgi?id=196211
1773         rdar://problem/49110552
1774
1775         Reviewed by Tim Horton.
1776
1777         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1778         Make sure that EventSenderProxy always exists when running tests. We used to create
1779         it when resetting before the first test, which is a bit too late.
1780
1781         * WebKitTestRunner/TestController.h:
1782         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1783         (WTR::TestController::platformCreateWebView):
1784         (WTR::TestController::platformCreateOtherPage):
1785         (WTR::TestController::finishCreatingPlatformWebView):
1786         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1787         (WTR::PlatformWebView::PlatformWebView):
1788         Moved some code that made NSWindow use NSEvent during web view creation. We may
1789         need to move more if some other case us found, but this is enough for now.
1790
1791 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1792
1793         Unreviewed. Fix typo in GLib geolocation API after r243285.
1794
1795         gelocation -> geolocation.
1796
1797         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1798         (testGeolocationManagerWatchPosition):
1799
1800 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1801
1802         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1803         https://bugs.webkit.org/show_bug.cgi?id=196213
1804
1805         Reviewed by Geoff Garen.
1806
1807         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1808         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1809         (credentialWithIdentityAndKeychainPath):
1810         (-[ChallengeDelegate webView:didFinishNavigation:]):
1811         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1812         (TestWebKitAPI::TEST):
1813
1814 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1815
1816         Expected shouldn't assume its contained types are copyable
1817         https://bugs.webkit.org/show_bug.cgi?id=195986
1818
1819         Reviewed by JF Bastien.
1820
1821         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1822         (TestWebKitAPI::NonCopyable::operator== const):
1823         (TestWebKitAPI::NonCopyable::operator!= const):
1824         (TestWebKitAPI::TEST):
1825
1826 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1827
1828         Remove some now-unnecessary dynamic class lookup
1829         https://bugs.webkit.org/show_bug.cgi?id=196237
1830
1831         Reviewed by Simon Fraser.
1832
1833         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1834         (makeRequest):
1835         (TEST):
1836
1837 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1838
1839         Unreviewed, rolling out r243450.
1840
1841         AppleWin and WinCairo port builds get broken.
1842
1843         Reverted changeset:
1844
1845         "Add test for fix of #196095"
1846         https://bugs.webkit.org/show_bug.cgi?id=196097
1847         https://trac.webkit.org/changeset/243450
1848
1849 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1850
1851         Unreviewed, rolling out r243465.
1852         https://bugs.webkit.org/show_bug.cgi?id=196226
1853
1854         the test doesn't build (Requested by thorton on #webkit).
1855
1856         Reverted changeset:
1857
1858         "Do not terminate the NetworkProcess if a third party
1859         application sends a NSCredential with a SecIdentityRef"
1860         https://bugs.webkit.org/show_bug.cgi?id=196213
1861         https://trac.webkit.org/changeset/243465
1862
1863 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1864
1865         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1866         https://bugs.webkit.org/show_bug.cgi?id=196213
1867
1868         Reviewed by Geoff Garen.
1869
1870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1871         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1872         (credentialWithIdentityAndKeychainPath):
1873         (-[ChallengeDelegate webView:didFinishNavigation:]):
1874         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1875         (TestWebKitAPI::TEST):
1876
1877 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1878
1879         [ews-build] Gracefully handle missing patch_id in events
1880         https://bugs.webkit.org/show_bug.cgi?id=196216
1881
1882         Reviewed by Lucas Forschler.
1883
1884         * BuildSlaveSupport/ews-build/events.py:
1885
1886 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1887
1888         [ews-build] use lz4 compression for improving buildbot performance
1889         https://bugs.webkit.org/show_bug.cgi?id=196155
1890
1891         Reviewed by Lucas Forschler.
1892
1893         * BuildSlaveSupport/ews-build/master.cfg:
1894
1895 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1896
1897         Pull some API testing helper methods out of TestWKWebView
1898         https://bugs.webkit.org/show_bug.cgi?id=196212
1899
1900         Reviewed by Tim Horton.
1901
1902         Refactor some more API testing utility methods, so that they can be used in
1903         tests that do not use TestWKWebView.
1904
1905         * TestWebKitAPI/cocoa/TestWKWebView.h:
1906         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1907         (-[WKWebView loadTestPageNamed:]):
1908         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1909         (-[WKWebView synchronouslyLoadHTMLString:]):
1910         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1911         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1912         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1913         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1914         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1915
1916 2019-03-25  Jer Noble  <jer.noble@apple.com>
1917
1918         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1919         https://bugs.webkit.org/show_bug.cgi?id=196097
1920
1921         Reviewed by Eric Carlson.
1922
1923         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1924
1925         * DumpRenderTree/mac/DumpRenderTree.mm:
1926         (resetWebPreferencesToConsistentValues):
1927         * WebKitTestRunner/TestController.cpp:
1928         (WTR::TestController::resetPreferencesToConsistentValues):
1929
1930 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1931
1932         Pull IPadUserInterfaceSwizzler out into a separate header file
1933         https://bugs.webkit.org/show_bug.cgi?id=196193
1934
1935         Reviewed by Anders Carlsson.
1936
1937         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1938         be used in other API tests.
1939
1940         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1941         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1942         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1943         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1944         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1945         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1946         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1947
1948 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1949
1950         Remove NavigatorContentUtils in WebCore/Modules
1951         https://bugs.webkit.org/show_bug.cgi?id=196070
1952
1953         Reviewed by Alex Christensen.
1954
1955         NavigatorContentUtils was to support the custom scheme spec [1].
1956         However, in WebKit side, no port has supported the feature in
1957         WebKit layer after EFL port was removed. So there has been the
1958         only IDL implementation of the NavigatorContentUtils in WebCore.
1959         So we don't need to keep the implementation in WebCore anymore.
1960
1961         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1962
1963         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1964
1965 2019-03-24  Andy Estes  <aestes@apple.com>
1966
1967         [watchOS] Remove unused Proximity Networking code
1968         https://bugs.webkit.org/show_bug.cgi?id=196188
1969
1970         Reviewed by Tim Horton.
1971
1972         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1973         (TEST):
1974
1975 2019-03-23  Keith Miller  <keith_miller@apple.com>
1976
1977         Refactor clz/ctz and fix getLSBSet.
1978         https://bugs.webkit.org/show_bug.cgi?id=196162
1979
1980         Reviewed by Saam Barati.
1981
1982         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1983
1984         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1985         (TestWebKitAPI::TEST):
1986
1987 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1988
1989         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1990         https://bugs.webkit.org/show_bug.cgi?id=196143
1991
1992         Reviewed by Michael Catanzaro.
1993
1994         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1995         directories.
1996
1997         * Scripts/webkitpy/style/checkers/cpp.py:
1998         (check_identifier_name_in_declaration):
1999         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2000         (WebKitStyleTest.test_names):
2001
2002 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2003
2004         [Flatpak] Manifest expanding fails for qt WPE extension
2005         https://bugs.webkit.org/show_bug.cgi?id=196148
2006
2007         Reviewed by Alex Christensen.
2008
2009         * flatpak/flatpakutils.py:
2010         (expand_submodules_recurse): The last recurse manifest expand
2011         iteration might lead to a single module so take it into account
2012         and don't try to recurse further.
2013
2014 2019-03-22  Chris Dumez  <cdumez@apple.com>
2015
2016         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2017         https://bugs.webkit.org/show_bug.cgi?id=195348
2018         <rdar://problem/48622090>
2019
2020         Reviewed by Alex Christensen.
2021
2022         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2023         to NO when test.options().shouldIgnoreMetaViewport is false.
2024
2025         * WebKitTestRunner/ios/TestControllerIOS.mm:
2026         (WTR::TestController::platformConfigureViewForTest):
2027
2028 2019-03-22  Chris Dumez  <cdumez@apple.com>
2029
2030         Prewarmed processes should be usable with any website data store
2031         https://bugs.webkit.org/show_bug.cgi?id=196104
2032
2033         Reviewed by Alex Christensen.
2034
2035         Add API test coverage.
2036
2037         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2038         (runInitialWarmedProcessUsedTest):
2039         (TEST):
2040
2041 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2042
2043         Back out local changes to Alex's Subversion working directory
2044
2045         They were accidentally committed.
2046
2047         * Scripts/webkitpy/common/system/abstractexecutive.py:
2048         (AbstractExecutive.wait_newest):
2049         * Scripts/webkitpy/common/system/executive.py:
2050         (Executive.running_pids):
2051         * Scripts/webkitpy/common/system/executive_mock.py:
2052         (MockExecutive.running_pids):
2053         * Scripts/webkitpy/common/system/executive_unittest.py:
2054         (ExecutiveTest.serial_test_running_pids):
2055         * Scripts/webkitpy/port/darwin.py:
2056         (DarwinPort.check_for_leaks):
2057         * Scripts/webkitpy/port/leakdetector.py:
2058         (LeakDetector.check_for_leaks):
2059         - This was the hack attached to Bug 193772.
2060
2061         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2062         (+[WebKitTestRunnerEvent mouseLocation]):
2063         - This works around a crash on an internal build.
2064
2065 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2066
2067         Fix the build after r243354
2068         https://bugs.webkit.org/show_bug.cgi?id=196138
2069         <rdar://problem/49145951>
2070
2071         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2072         (TEST):
2073         * TestWebKitAPI/ios/UIKitSPI.h:
2074
2075 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2076
2077         Adopt UIWKDocumentContext
2078         https://bugs.webkit.org/show_bug.cgi?id=196040
2079         <rdar://problem/48642440>
2080
2081         Reviewed by Ryosuke Niwa.
2082
2083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2084         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2085         (makeRequest):
2086         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2087         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2088         (applyStyle):
2089         (TEST):
2090         Add tests for UIWKDocumentContext.
2091
2092         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2093         (TEST):
2094         (recursiveFindWKContentView): Deleted.
2095         * TestWebKitAPI/cocoa/TestWKWebView.h:
2096         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2097         (recursiveFindWKContentView):
2098         (-[TestWKWebView wkContentView]):
2099         * TestWebKitAPI/ios/UIKitSPI.h:
2100         Share the WKContentView finding code between tests.
2101
2102 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2103
2104         [iOS WK2] Turn on async overflow scrolling by default
2105         https://bugs.webkit.org/show_bug.cgi?id=196011
2106         rdar://problem/48453859
2107
2108         Reviewed by Antti Koivisto.
2109         
2110         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2111         since so many basic layout tests have different results when compositing is triggered for
2112         overflow.
2113         
2114         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2115
2116         * WebKitTestRunner/TestController.cpp:
2117         (WTR::TestController::resetPreferencesToConsistentValues):
2118
2119 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2120
2121         [ews-build] Retry API test in case of failures
2122         https://bugs.webkit.org/show_bug.cgi?id=196004
2123
2124         Reviewed by Lucas Forschler.
2125
2126         * BuildSlaveSupport/ews-build/steps.py:
2127         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2128         (CompileWebKitToT.doStepIf): Ditto.
2129         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2130         (ReRunAPITests): Re-run API tests.
2131         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2132         (RunAPITestsWithoutPatch): Run API tests without patch.
2133         (RunAPITestsWithoutPatch.doStepIf):
2134         (RunAPITestsWithoutPatch.hideStepIf):
2135         (RunAPITestsWithoutPatch.evaluateCommand):
2136         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2137         (AnalyzeAPITestsResults.start):
2138         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2139         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2140         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2141         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2142
2143 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2144
2145         [ews-build] Update queues configurations
2146         https://bugs.webkit.org/show_bug.cgi?id=196074
2147
2148         Reviewed by Dewei Zhu.
2149
2150         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2151         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2152
2153 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2154
2155         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2156         https://bugs.webkit.org/show_bug.cgi?id=195680
2157         <rdar://problem/48903534>
2158
2159         Unreviewed infrastructure fix.
2160
2161         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2162         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2163
2164 2019-03-21  Andy Estes  <aestes@apple.com>
2165
2166         [iOS] Apple Pay should be available in documents with no user agent scripts
2167         https://bugs.webkit.org/show_bug.cgi?id=196061
2168         <rdar://problem/48649391>
2169
2170         Reviewed by Brady Eidson.
2171
2172         Added API tests and related infrastructure.
2173
2174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2175         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2176         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2177         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2178         (TestWebKitAPI::TEST):
2179         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2180         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2181         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2182         * TestWebKitAPI/cocoa/TestProtocol.mm:
2183         (-[TestProtocol startLoading]):
2184         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2185         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2186         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2187         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2188
2189 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2190
2191         REGRESSSION (r243297): webkitpy tests broken
2192         https://bugs.webkit.org/show_bug.cgi?id=196108
2193
2194         Reviewed by Aakash Jain.
2195
2196         r243297 updated contributors.json, which broke a few unit tests.
2197
2198         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2199         (IRCCommandTest.test_whois):
2200         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2201
2202 2019-03-21  Chris Dumez  <cdumez@apple.com>
2203
2204         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2205         https://bugs.webkit.org/show_bug.cgi?id=196041
2206         <rdar://problem/49083230>
2207
2208         Reviewed by Alex Christensen.
2209
2210         Add API test coverage.
2211
2212         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2213         (TEST):
2214
2215 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2216
2217         Add SPI to inform applications of WKContentRuleList actions
2218         https://bugs.webkit.org/show_bug.cgi?id=195965
2219         <rdar://problem/42664365>
2220
2221         Reviewed by Geoff Garen.
2222
2223         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2224         (TestWebKitAPI::allActionsForResourceLoad):
2225         (TestWebKitAPI::testRequest):
2226         (TestWebKitAPI::TEST_F):
2227         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2228         (Notification::description):
2229         (Notification::operator== const):
2230         (toVector):
2231         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2232         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2233         (makeContentRuleList):
2234         (TEST):
2235         (makeWarnContentRuleList): Deleted.
2236
2237 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2238
2239         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2240         https://bugs.webkit.org/show_bug.cgi?id=196088
2241
2242         Reviewed by Brian Burg.
2243
2244         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2245         Support checks when only one platform is specified. Also deprecate macosx() and
2246         force the use of macos() instead.
2247
2248         * Scripts/webkitpy/style/checkers/cpp.py:
2249         (check_min_versions_of_wk_api_available):
2250         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2251         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2252
2253 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2254
2255         Update status inactive committers' status to 'contributor'.
2256
2257         * Scripts/webkitpy/common/config/contributors.json:
2258
2259 2019-03-21  Xan Lopez  <xan@igalia.com>
2260
2261         [JSC][x86] Drop support for x87 floating point
2262         https://bugs.webkit.org/show_bug.cgi?id=194853
2263
2264         Reviewed by Don Olmstead.
2265
2266         Force SSE2 on x86/32bit builds.
2267
2268         * Scripts/webkitdirs.pm:
2269         (generateBuildSystemFromCMakeProject):
2270
2271 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2272
2273         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2274         https://bugs.webkit.org/show_bug.cgi?id=196073
2275
2276         Reviewed by Michael Catanzaro.
2277
2278         Add test cases to check functions and constructors with no arguments but receiving user data.
2279
2280         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2281         (checkUserData):
2282         (testJSCFunction):
2283         (fooCreateWithUserData):
2284         (testJSCClass):
2285
2286 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2287
2288         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2289
2290         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2291
2292         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2293
2294 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2295
2296         [GTK][WPE] Add API to provide geolocation information
2297         https://bugs.webkit.org/show_bug.cgi?id=195940
2298
2299         Reviewed by Michael Catanzaro.
2300
2301         Add a new test to check the new API.
2302
2303         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2304         (testGeolocationManagerCurrentPosition):
2305         (testGeolocationManagerWatchPosition):
2306         (beforeAll):
2307         (afterAll):
2308         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2309         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2310         (beforeAll): Ditto.
2311         * TestWebKitAPI/glib/CMakeLists.txt:
2312
2313 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2314
2315         [GLib] Returning G_TYPE_OBJECT from a method does not work
2316         https://bugs.webkit.org/show_bug.cgi?id=195574
2317
2318         Reviewed by Michael Catanzaro.
2319
2320         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2321
2322         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2323         (getGFile):
2324         (getParent):
2325         (createGString):
2326         (getGString):
2327         (getGStringCopyWillRaise):
2328         (getGStringCopy):
2329         (getGStringStr):
2330         (getGStringLen):
2331         (freeGString):
2332         (testJSCClass):
2333
2334 2019-03-20  Saam Barati  <sbarati@apple.com>
2335
2336         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2337         https://bugs.webkit.org/show_bug.cgi?id=195721
2338
2339         Reviewed by Filip Pizlo.
2340
2341         * Scripts/run-javascriptcore-tests:
2342
2343 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2344
2345         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2346         https://bugs.webkit.org/show_bug.cgi?id=196049
2347
2348         Reviewed by Tim Horton.
2349
2350         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2351         overflow scrolling in general, so rename it.
2352
2353         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2354
2355 2019-03-20  Daniel Bates  <dabates@apple.com>
2356
2357         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2358         https://bugs.webkit.org/show_bug.cgi?id=196031
2359         <rdar://problem/49078172>
2360
2361         Reviewed by Tim Horton.
2362
2363         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2364         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2365         same code path used when the Done button is pressed to dismiss the <select> picker.
2366
2367         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2368         (TestWebKitAPI::TEST):
2369
2370 2019-03-20  Chris Dumez  <cdumez@apple.com>
2371
2372         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2373         https://bugs.webkit.org/show_bug.cgi?id=196029
2374         <rdar://problem/48954651>
2375
2376         Reviewed by Tim Horton.
2377
2378         Add API test coverage.
2379
2380         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2381
2382 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2383
2384         [ews-build] Improve failure summary string for ApplyPatch step
2385         https://bugs.webkit.org/show_bug.cgi?id=195995
2386
2387         Reviewed by Alexey Proskuryakov.
2388
2389         * BuildSlaveSupport/ews-build/steps.py:
2390         (ApplyPatch.getResultSummary): Override getResultSummary.
2391
2392 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2393
2394         AX: Implement support for new meter ARIA role
2395         https://bugs.webkit.org/show_bug.cgi?id=195966
2396
2397         Reviewed by Chris Fleizach.
2398
2399         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2400         to AXLevelIndicator.
2401
2402         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2403
2404 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2405
2406         [WebAuthN] Implement FIDO AppID extension
2407         https://bugs.webkit.org/show_bug.cgi?id=143491
2408         <rdar://problem/48298273>
2409
2410         Reviewed by Brent Fulgham.
2411
2412         Add a test that covers the new flag of convertToU2fSignCommand.
2413
2414         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2415         (TestWebKitAPI::TEST):
2416         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2417         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2418         (TestWebKitAPI::TEST):
2419
2420 2019-03-19  Keith Rollin  <krollin@apple.com>
2421
2422         Add support for more platforms to generate-xcfilelists
2423         https://bugs.webkit.org/show_bug.cgi?id=195977
2424
2425         Reviewed by Alexey Proskuryakov.
2426
2427         generate-xcfilelists incorrectly complains when involved with building
2428         WebKit for iphonesimulator:
2429
2430             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2431             …
2432             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2433
2434         Address this by teaching generate-xcfilelists about more platforms.
2435
2436         * Scripts/generate-xcfilelists:
2437
2438 2019-03-19  John Wilander  <wilander@apple.com>
2439
2440         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2441         https://bugs.webkit.org/show_bug.cgi?id=195923
2442         <rdar://problem/49001272>
2443
2444         Reviewed by Alex Christensen.
2445
2446         This patch does the following to the TestRunner:
2447         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2448         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2449         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2450
2451         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2452         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2453         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2454         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2455         * WebKitTestRunner/TestController.cpp:
2456         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2457         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2458         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2459         * WebKitTestRunner/TestController.h:
2460         * WebKitTestRunner/TestInvocation.cpp:
2461         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2462
2463 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2464
2465         [CMake] Support more clang and gcc sanitizers
2466         https://bugs.webkit.org/show_bug.cgi?id=195956
2467
2468         Reviewed by Michael Catanzaro.
2469
2470         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2471
2472 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2473
2474         [ews-build] Improve summary for PrintConfiguration step
2475         https://bugs.webkit.org/show_bug.cgi?id=195945
2476
2477         Reviewed by Lucas Forschler.
2478
2479         * BuildSlaveSupport/ews-build/steps.py:
2480         (PrintConfiguration.getResultSummary): Override getResultSummary.
2481
2482 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2483
2484         [ews-build] Improve summary for CheckOutSource step
2485         https://bugs.webkit.org/show_bug.cgi?id=195963
2486
2487         Reviewed by Lucas Forschler.
2488
2489         * BuildSlaveSupport/ews-build/steps.py:
2490         (CheckOutSource.getResultSummary):
2491
2492 2019-03-19  Daniel Bates  <dabates@apple.com>
2493
2494         [iOS] Focus not preserved when switching between tabs
2495         https://bugs.webkit.org/show_bug.cgi?id=195820
2496         <rdar://problem/43614450>
2497
2498         Reviewed by Brent Fulgham.
2499
2500         Add tests to ensure that we restore focus when resigning and becoming first responder.
2501
2502         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2503         (TestWebKitAPI::TEST):
2504
2505 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2506
2507         Make WTFLogChannelState and WTFLogLevel enum classes
2508         https://bugs.webkit.org/show_bug.cgi?id=195904
2509
2510         Reviewed by Eric Carlson.
2511
2512         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2513         (TestWebKitAPI::TEST_F):
2514
2515 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2516
2517         [GStreamer][EME] Backported mssdemux protection data crash fix
2518         https://bugs.webkit.org/show_bug.cgi?id=195918
2519
2520         Reviewed by Philippe Normand.
2521
2522         * gstreamer/jhbuild.modules:
2523         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2524
2525 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2526
2527         Unreviewed, rolling out r243132.
2528
2529         Broke GTK build
2530
2531         Reverted changeset:
2532
2533         "Make WTFLogChannelState and WTFLogLevel enum classes"
2534         https://bugs.webkit.org/show_bug.cgi?id=195904
2535         https://trac.webkit.org/changeset/243132
2536
2537 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2538
2539         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2540
2541         * Scripts/webkitdirs.pm:
2542         (builtDylibPathForName): Adjust the shared library name that's changed
2543         with the API version bump in r243073.
2544
2545 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2546
2547         Make WTFLogChannelState and WTFLogLevel enum classes
2548         https://bugs.webkit.org/show_bug.cgi?id=195904
2549
2550         Reviewed by Eric Carlson.
2551
2552         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2553         (TestWebKitAPI::TEST_F):
2554
2555 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2556
2557         Disable flaky test added in r2431100
2558         https://webkit.org/b/195785
2559
2560         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2561         (TestWebKitAPI::TEST):
2562         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2563
2564 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2565
2566         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2567         https://bugs.webkit.org/show_bug.cgi?id=195916
2568
2569         Reviewed by Tim Horton.
2570
2571         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2572         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2573
2574 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2575
2576         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2577
2578         * Scripts/webkitpy/common/config/contributors.json:
2579
2580 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2581
2582         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2583         https://bugs.webkit.org/show_bug.cgi?id=195785
2584
2585         Reviewed by Geoffrey Garen.
2586
2587         * TestWebKitAPI/TCPServer.cpp: Added.
2588         (TestWebKitAPI::TCPServer::TCPServer):
2589         (TestWebKitAPI::TCPServer::~TCPServer):
2590         (TestWebKitAPI::TCPServer::socketBindListen):
2591         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2592         * TestWebKitAPI/TCPServer.h: Added.
2593         (TestWebKitAPI::TCPServer::port const):
2594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2595         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2596         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2597         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2598         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2599         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2600         (TestWebKitAPI::respondSlowly):
2601         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2602         (TestWebKitAPI::downloadAtRate):
2603         (TestWebKitAPI::TEST):
2604
2605 2019-03-18  Saam Barati  <sbarati@apple.com>
2606
2607         Add a plan file for JetStream 2
2608         https://bugs.webkit.org/show_bug.cgi?id=190734
2609
2610         Reviewed by Mark Lam.
2611
2612         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2613
2614 2019-03-18  Chris Dumez  <cdumez@apple.com>
2615
2616         Delay WebProcess launch until a load is triggered in a Web view
2617         https://bugs.webkit.org/show_bug.cgi?id=195758
2618         <rdar://problem/48126013>
2619
2620         Reviewed by Geoff Garen.
2621
2622         Add API test coverage. Also update some existing API tests to not expect
2623         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2624
2625         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2626         (TestWebKitAPI::TEST):
2627         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2628         (TestWebKitAPI::TEST):
2629         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2630         (TEST):
2631         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2632         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2633         (TEST):
2634         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2635         (TEST):
2636         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2637
2638 2019-03-18  Xan Lopez  <xan@igalia.com>
2639
2640         [CMake] Prevent potential warning when determining $architecture
2641         https://bugs.webkit.org/show_bug.cgi?id=195891
2642
2643         Reviewed by Michael Catanzaro.
2644
2645         It's possible for generateBuildSystemForCMakeProject to be called
2646         before determineArchitecture() is ever called. This will make the
2647         first eq check with $architecture to be bogus (and print a
2648         warning). Change that to an eq check with architecture(), which
2649         implicitly calls determineArchitecture() if needed, and change all
2650         the other similar cases in the method in the same way to prevent
2651         future bugs like this one.
2652
2653         * Scripts/webkitdirs.pm:
2654         (generateBuildSystemFromCMakeProject):
2655
2656 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2657
2658         [WPE] Tarballs generated with “make dist” cannot build documentation
2659         https://bugs.webkit.org/show_bug.cgi?id=195885
2660
2661         Reviewed by Carlos Garcia Campos.
2662
2663         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2664
2665 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2666
2667         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2668         https://bugs.webkit.org/show_bug.cgi?id=195883
2669
2670         Reviewed by Carlos Garcia Campos.
2671
2672         * gtkdoc/gtkdoc.py:
2673         (GTKDoc._run_command): When commands fail to run, include the full command line for
2674         the program invocation and the output it has generated on the standard error stream.
2675
2676 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2677
2678         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2679         https://bugs.webkit.org/show_bug.cgi?id=195786
2680
2681         Reviewed by Philippe Normand.
2682
2683         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2684         * wpe/jhbuild.modules: Ditto.
2685
2686 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2687
2688         [ews-build] Don't run clean builds on EWS builders
2689         https://bugs.webkit.org/show_bug.cgi?id=195851
2690
2691         Reviewed by Geoffrey Garen.
2692
2693         * BuildSlaveSupport/ews-build/factories.py:
2694
2695 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2696
2697         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2698         https://bugs.webkit.org/show_bug.cgi?id=195849
2699
2700         Reviewed by Chris Dumez.
2701
2702         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2703
2704         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2705         (runWebsiteDataStoreCustomPaths):
2706
2707 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2708
2709         webkitpy: Upload test results
2710         https://bugs.webkit.org/show_bug.cgi?id=195755
2711         <rdar://problem/48896182>
2712
2713         Reviewed by Aakash Jain.
2714
2715         Establish a new format for uploading results that is not tied to layout tests, apply
2716         that format to webkitpy tests.
2717
2718         * Scripts/webkitpy/common/checkout/scm/git.py:
2719         (Git.native_branch): Return what branch the current checkout is on.
2720         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2721         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2722         * Scripts/webkitpy/common/checkout/scm/svn.py:
2723         (SVN.native_branch): Ditto.
2724         * Scripts/webkitpy/common/system/platforminfo.py:
2725         (PlatformInfo.build_version): Return a build version for Mac.
2726         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2727         (MockPlatformInfo.__init__):
2728         (MockPlatformInfo.build_version):
2729         * Scripts/webkitpy/results: Added.
2730         * Scripts/webkitpy/results/__init__.py: Added.
2731         * Scripts/webkitpy/results/options.py: Added.
2732         (upload_options): OptParse list for upload options.
2733         * Scripts/webkitpy/results/upload.py: Added.
2734         (Upload): Class which enforces the upload format expected by the results server.
2735         (Upload.Expectations):
2736         (Upload.create_configuration):
2737         (Upload.create_commit):
2738         (Upload.create_details):
2739         (Upload.create_run_stats):
2740         (Upload.create_test_result):
2741         (Upload.__init__):
2742         (Upload.Encoder): Encode Upload object as json.
2743         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2744         * Scripts/webkitpy/results/upload_unittest.py: Added.
2745         * Scripts/webkitpy/test/main.py:
2746         (Tester._parse_args): Add upload arguments.
2747         (Tester._run_tests): Allow results to be uploaded.
2748         * Scripts/webkitpy/test/runner.py:
2749         (Runner.__init__): Record which tests were run, rather than just counting them.
2750         (Runner.handle):
2751         * Scripts/webkitpy/test/runner_unittest.py:
2752         (RunnerTest.test_run):
2753         * Scripts/webkitpy/thirdparty/__init__.py:
2754         (AutoinstallImportHook.find_module): Add requests auto-install.
2755         (AutoinstallImportHook._install_requests):
2756         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2757         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2758
2759 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2760
2761         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2762         https://bugs.webkit.org/show_bug.cgi?id=195810
2763
2764         Reviewed by Tim Horton.
2765
2766         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2767         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2768         ending certain layout tests.
2769
2770         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2771         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2772         (-[TestRunnerWKWebView dealloc]):
2773         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2774
2775         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2776         helper method when destroying the web view, and when resetting state between tests.
2777
2778         * WebKitTestRunner/ios/TestControllerIOS.mm:
2779         (WTR::TestController::platformResetStateToConsistentValues):
2780
2781         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2782
2783 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2784
2785         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2786         https://bugs.webkit.org/show_bug.cgi?id=190350
2787         <rdar://problem/45089503>
2788
2789         Reviewed by Geoffrey Garen.
2790
2791         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2792         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2793         (TEST):
2794         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2795         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2796         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2797         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2798         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2799         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2800         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2801         (runTest):
2802         (createDirectories):
2803         (TEST):
2804         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2805         (TEST):
2806         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2807         (TEST):
2808
2809 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2810
2811         Add support to WebPage for getting the contents as an attributed string.
2812         https://bugs.webkit.org/show_bug.cgi?id=195636
2813         rdar://problem/45055697
2814
2815         Reviewed by Tim Horton.
2816
2817         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2818         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2819
2820 2019-03-15  Chris Dumez  <cdumez@apple.com>
2821
2822         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2823         https://bugs.webkit.org/show_bug.cgi?id=195747
2824
2825         Reviewed by Geoff Garen.
2826
2827         Add API test coverage.
2828
2829         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2830
2831 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2832
2833         Unreviewed, rolling out r242952.
2834
2835         Causing API failures on iOS Simulator
2836
2837         Reverted changeset:
2838
2839         "[PSON] Make sure the WebProcessCache is leverage when
2840         relaunching a process after termination"
2841         https://bugs.webkit.org/show_bug.cgi?id=195747
2842         https://trac.webkit.org/changeset/242952
2843
2844 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2845
2846         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2847         https://bugs.webkit.org/show_bug.cgi?id=195740
2848
2849         Reviewed by Ross Kirsling.
2850
2851         window.open doesn't work for WebKitBrowserWindow because it is not
2852         implemented yet.
2853
2854         1. Implemented createNewPage callback of WKPageUIClient.
2855         2. Changed MainWindow to take a BrowserWindow factory function
2856           instead of BrowserWindowType to be flexible to create
2857           BrowserWindow with extra settings.
2858         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2859           because it is not relevant with MainWindow anymore.
2860
2861         * MiniBrowser/win/Common.cpp:
2862         (parseCommandLine):
2863         * MiniBrowser/win/Common.h:
2864         (CommandLineOptions::CommandLineOptions):
2865         * MiniBrowser/win/MainWindow.cpp:
2866         (MainWindow::MainWindow):
2867         (MainWindow::create):
2868         (MainWindow::init):
2869         (MainWindow::WndProc):
2870         * MiniBrowser/win/MainWindow.h:
2871         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2872         (PrintWebUIDelegate::createWebViewWithRequest):
2873         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2874         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2875         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2876         (WebKitBrowserWindow::updateProxySettings):
2877         (WebKitBrowserWindow::createNewPage):
2878         * MiniBrowser/win/WebKitBrowserWindow.h:
2879         * MiniBrowser/win/WinMain.cpp:
2880         (wWinMain):
2881
2882 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2883
2884         Make it possible to test scrolling tree layer manipulation more easily
2885         https://bugs.webkit.org/show_bug.cgi?id=195780
2886
2887         Reviewed by Tim Horton.
2888         
2889         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2890         cuts off communication of scrolling tree scrolls back to the web process
2891         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2892         allows tests to trigger scrolls which run the scrolling tree layer positioning
2893         logic, but never get another commit from the web process that might mask
2894         scrolling tree bugs.
2895         
2896         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2897         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2898         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2899
2900         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2901         (WTR::UIScriptController::scrollUpdatesDisabled const):
2902         (WTR::UIScriptController::setScrollUpdatesDisabled):
2903         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2904         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2905         (WTR::UIScriptController::scrollUpdatesDisabled const):
2906         (WTR::UIScriptController::setScrollUpdatesDisabled):
2907         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2908         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2909         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2910         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2911         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2912         * WebKitTestRunner/ios/TestControllerIOS.mm:
2913         (WTR::TestController::platformResetStateToConsistentValues):
2914         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2915         (WTR::UIScriptController::scrollUpdatesDisabled const):
2916         (WTR::UIScriptController::setScrollUpdatesDisabled):
2917
2918 2019-03-14  Youenn Fablet  <youenn@apple.com>
2919
2920         Move IDB storage in private browsing mode to NetworkProcess
2921         https://bugs.webkit.org/show_bug.cgi?id=195602
2922
2923         Reviewed by Brady Eidson.
2924
2925         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2926         (TEST):
2927
2928 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2929
2930         [ews-build] Make descriptionDone messages more readable
2931         https://bugs.webkit.org/show_bug.cgi?id=195760
2932
2933         Reviewed by Lucas Forschler.
2934
2935         * BuildSlaveSupport/ews-build/steps.py:
2936         * BuildSlaveSupport/ews-build/steps_unittest.py:
2937
2938 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2939
2940         [ews-build] Generate status-bubble hover-over messages
2941         https://bugs.webkit.org/show_bug.cgi?id=195680
2942
2943         Reviewed by Lucas Forschler.
2944
2945         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2946         (StatusBubble):
2947         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2948         on hover-over.
2949         (StatusBubble._iso_time):
2950         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2951         hover-over message.
2952         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2953
2954 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2955
2956         [ews-app] Gracefully handle the case when state_string is None
2957         https://bugs.webkit.org/show_bug.cgi?id=195753
2958
2959         Reviewed by Lucas Forschler.
2960
2961         * BuildSlaveSupport/ews-app/ews/models/build.py:
2962         * BuildSlaveSupport/ews-app/ews/models/step.py:
2963
2964 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2965
2966         [ews-app] Status bubble display pending for currently running build step
2967         https://bugs.webkit.org/show_bug.cgi?id=195744
2968
2969         Reviewed by Lucas Forschler.
2970
2971         * BuildSlaveSupport/ews-build/events.py:
2972         (Events.stepStarted): If state_string is pending, replace it with step name.
2973
2974 2019-03-14  Chris Dumez  <cdumez@apple.com>
2975
2976         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2977         https://bugs.webkit.org/show_bug.cgi?id=195750
2978
2979         Reviewed by Geoffrey Garen.
2980
2981         Add API test coverage.
2982
2983         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2984         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2985         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2986         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2987
2988 2019-03-14  Chris Dumez  <cdumez@apple.com>
2989
2990         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2991         https://bugs.webkit.org/show_bug.cgi?id=195747
2992
2993         Reviewed by Geoff Garen.
2994
2995         Add API test coverage.
2996
2997         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2998
2999 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3000
3001         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3002         https://bugs.webkit.org/show_bug.cgi?id=195725
3003         <rdar://problem/48545062>
3004
3005         Reviewed by Tim Horton.
3006
3007         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3008         handler is nil.
3009
3010         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3011         (TestWebKitAPI::TEST):
3012
3013 2019-03-13  Sam Weinig  <sam@webkit.org>
3014
3015         Add utility function to allow easy reverse range-based iteration of a container
3016         https://bugs.webkit.org/show_bug.cgi?id=195542
3017
3018         Reviewed by Antti Koivisto.
3019
3020         * TestWebKitAPI/CMakeLists.txt:
3021         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3022         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3023         (TestWebKitAPI::TEST):
3024         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3025
3026 2019-03-13  Chris Dumez  <cdumez@apple.com>
3027
3028         Use a ServiceWorker process per registrable domain
3029         https://bugs.webkit.org/show_bug.cgi?id=195649
3030
3031         Reviewed by Youenn Fablet.
3032
3033         Update API test coverage.
3034
3035         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3036
3037 2019-03-13  Chris Dumez  <cdumez@apple.com>
3038
3039         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3040         https://bugs.webkit.org/show_bug.cgi?id=195684
3041         <rdar://problem/48294714>
3042
3043         Reviewed by Antti Koivisto.
3044
3045         Add API test coverage.
3046
3047         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3048
3049 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3050
3051         [ews-app] Remove unused patch view
3052         https://bugs.webkit.org/show_bug.cgi?id=195669
3053
3054         Reviewed by Lucas Forschler.
3055
3056         * BuildSlaveSupport/ews-app/ews/urls.py:
3057         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3058
3059 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3060
3061         [ews-app] Use Buildbot result code variables
3062         https://bugs.webkit.org/show_bug.cgi?id=195668
3063
3064         Reviewed by Alexey Proskuryakov.
3065
3066         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3067         (Buildbot): Added Buildbot result code variables.
3068         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3069         (StatusBubble._build_bubble): Used Buildbot result code variables.
3070
3071 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3072
3073         [Flatpak] Expand submodule recursively
3074         https://bugs.webkit.org/show_bug.cgi?id=195672
3075
3076         Building WPE with flatpak was impossible without that as it was raising an exception.
3077         Also update wpebackend-fdo to match what is built in jhbuild
3078
3079         Reviewed by Philippe Normand.
3080
3081         * flatpak/flatpakutils.py:
3082         (expand_submodules_recurse):
3083         (expand_manifest):
3084         * flatpak/org.webkit.WPEModules.yaml:
3085
3086 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3087
3088         [ews-app] status bubble should be hidden for certain builds
3089         https://bugs.webkit.org/show_bug.cgi?id=194597
3090
3091         Reviewed by Dewei Zhu.
3092
3093         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3094         (StatusBubble._build_bubble):
3095         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3096         because the patch didn't have relevant changes.
3097         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3098         in production yet.
3099
3100 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3101
3102         [Win] Fix a slew of simple clang-cl warnings.
3103         https://bugs.webkit.org/show_bug.cgi?id=195652
3104
3105         Reviewed by Don Olmstead.
3106
3107         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3108         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3109
3110 2019-03-12  Justin Fan  <justin_fan@apple.com>
3111
3112         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3113         https://bugs.webkit.org/show_bug.cgi?id=195518
3114         <rdar://problem/46322356>
3115
3116         Reviewed by Myles C. Maxfield.
3117
3118         * DumpRenderTree/DerivedSources-input.xcfilelist:
3119         * DumpRenderTree/DerivedSources-output.xcfilelist:
3120
3121 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3122
3123         Unreviewed, rolling out r242825.
3124         https://bugs.webkit.org/show_bug.cgi?id=195648
3125
3126         "Broke webkitpy tests with my change to
3127         lldb_dump_class_layout.py" (Requested by rmorisset on
3128         #webkit).
3129
3130         Reverted changeset:
3131
3132         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3133         classes with suspicious padding"
3134         https://bugs.webkit.org/show_bug.cgi?id=195573
3135         https://trac.webkit.org/changeset/242825
3136
3137 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3138
3139         [ews-build] Show status bubbles while the patch is waiting in queue
3140         https://bugs.webkit.org/show_bug.cgi?id=195618
3141
3142         Reviewed by Lucas Forschler.
3143
3144         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3145         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3146         enabled in initial deployment.
3147         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3148         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3149         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3150         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3151         (StatusBubble._build_bubbles_for_patch):
3152
3153 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3154
3155         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3156         https://bugs.webkit.org/show_bug.cgi?id=195573
3157
3158         Reviewed by Simon Fraser.
3159
3160         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3161
3162         * Scripts/dump-class-layout:
3163         (main):
3164         * lldb/lldb_dump_class_layout.py:
3165         (ClassLayout.__init__):
3166         (ClassLayout._compute_padding_recursive):
3167         (LLDBDebuggerInstance.dump_layout_for_classname):
3168         (LLDBDebuggerInstance):
3169         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3170         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3171
3172 2019-03-12  Chris Dumez  <cdumez@apple.com>
3173
3174         Device Orientation access permission should be denied unless explicitly granted by the client
3175         https://bugs.webkit.org/show_bug.cgi?id=195625
3176
3177         Reviewed by Youenn Fablet.
3178
3179         add API test coverage.
3180
3181         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3182         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3183         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3184         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3185         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3186         (runDeviceOrientationTest):
3187         (TEST):
3188         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3189         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3190
3191 2019-03-12  Jer Noble  <jer.noble@apple.com>
3192
3193         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3194         https://bugs.webkit.org/show_bug.cgi?id=195137
3195         <rdar://problem/48810307>
3196
3197         Reviewed by Eric Carlson.
3198
3199         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3200         (TestWebKitAPI::TEST):
3201
3202 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3203
3204         [ews-build] Change urls from uat to production
3205         https://bugs.webkit.org/show_bug.cgi?id=195566
3206
3207         Reviewed by Lucas Forschler.
3208
3209         * BuildSlaveSupport/ews-app/ews/config.py:
3210         * BuildSlaveSupport/ews-build/events.py:
3211         * BuildSlaveSupport/ews-build/steps.py:
3212
3213 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3214
3215         [ews-build] change max_builds for local-worker to 1
3216         https://bugs.webkit.org/show_bug.cgi?id=195568
3217
3218         Reviewed by Lucas Forschler.
3219
3220         * BuildSlaveSupport/ews-build/loadConfig.py:
3221
3222 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3223
3224         Fix the build
3225
3226         * TestRunnerShared/spi/PencilKitTestSPI.h:
3227         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3228
3229 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3230
3231         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3232         https://bugs.webkit.org/show_bug.cgi?id=194131
3233
3234         Reviewed by Michael Catanzaro.
3235
3236         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3237         (uriChanged):
3238         (testUnfinishedSubresourceLoad):
3239         (serverCallback):
3240         (beforeAll):
3241
3242 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3243
3244         WTF::Expected should use std::addressof instead of operator&
3245         https://bugs.webkit.org/show_bug.cgi?id=195604
3246
3247         Reviewed by Myles Maxfield.
3248
3249         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3250         (TestWebKitAPI::Unique::Unique):
3251         (TestWebKitAPI::Unique::operator&):
3252         (TestWebKitAPI::TEST):
3253
3254 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3255
3256         Add Optional to Forward.h.
3257         https://bugs.webkit.org/show_bug.cgi?id=195586
3258
3259         Reviewed by Darin Adler.
3260
3261         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3262         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3263         Remove unnecessary includes from headers.
3264
3265 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3266
3267         Add testing API to hit-test and scroll overflow scrollers
3268         https://bugs.webkit.org/show_bug.cgi?id=195278
3269
3270         Reviewed by Antti Koivisto.
3271         
3272         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3273         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3274         
3275         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3276
3277         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3278         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3279         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3280         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3281         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3282         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3283         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3284         (WTR::enclosingScrollViewIncludingSelf):
3285         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3286
3287 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3288
3289         API test WebKit.RequestTextInputContext fails on iOS
3290         https://bugs.webkit.org/show_bug.cgi?id=195585
3291
3292         Reviewed by Wenson Hsieh and Simon Fraser.
3293
3294         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3295         (applyStyle):
3296         (TEST):
3297         Add a viewport, so that the coordinates match up on iOS.
3298         Scroll by moving the UIScrollView's contentOffset.
3299
3300 2019-03-11  Chris Dumez  <cdumez@apple.com>
3301
3302         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3303         https://bugs.webkit.org/show_bug.cgi?id=195506
3304         <rdar://problem/48733477>
3305
3306         Reviewed by Alex Christensen.
3307
3308         Add API test coverage.
3309
3310         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3311
3312 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3313
3314         Adding myself to contributors.json
3315
3316         Unreviewed, addming myself to contributors.json .
3317
3318         * Scripts/webkitpy/common/config/contributors.json:
3319
3320 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3321
3322         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3323         https://bugs.webkit.org/show_bug.cgi?id=195511
3324         <rdar://problem/44873269>
3325
3326         Reviewed by Darin Adler.
3327
3328         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3329         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3330         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3331         (TEST_F):
3332
3333 2019-03-11  Chris Dumez  <cdumez@apple.com>
3334
3335         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3336         https://bugs.webkit.org/show_bug.cgi?id=195561
3337
3338         Reviewed by Youenn Fablet.
3339
3340         Make sure the JS in the test requests for permission to receive device orientation events.
3341
3342         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3343
3344 2019-03-11  Youenn Fablet  <youenn@apple.com>
3345
3346         Allow storage quota increase by default in WTR
3347         https://bugs.webkit.org/show_bug.cgi?id=195541
3348
3349         Reviewed by Geoffrey Garen.
3350
3351         Allow storage quota increase by default in WTR.
3352         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3353         Use this for tests that explicitly need cache increase.
3354
3355         Instead of increasing quota by 2, make sure the next request is
3356         granted by adding all given parameters.
3357
3358         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3359         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3360         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3361         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3362         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3363         * WebKitTestRunner/TestController.cpp:
3364         (WTR::TestController::setAllowStorageQuotaIncrease):
3365         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3366         * WebKitTestRunner/TestController.h:
3367         * WebKitTestRunner/TestInvocation.cpp:
3368         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3369         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3370         (WTR::TestController::cocoaResetStateToConsistentValues):
3371         (WTR::TestController::setAllowStorageQuotaIncrease):
3372         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3373         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3374         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3375
3376 2019-03-11  Xan Lopez  <xan@igalia.com>
3377
3378         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3379         https://bugs.webkit.org/show_bug.cgi?id=194147
3380
3381         Reviewed by Michael Saboff.
3382
3383         To make --32-bit work correctly on Linux/64bit we need to:
3384
3385         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3386         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3387         unfortunately CMake only allows us to do this during
3388         crosscompilation, which is overkill here.
3389         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3390         pkg-config detection module uses the x86 .pc files instead of the
3391         x86_64 ones.
3392         - Set the -m32 flags for the compiler.
3393
3394         * Scripts/webkitdirs.pm:
3395         (generateBuildSystemFromCMakeProject):
3396
3397 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3398
3399         Add MotionMark-1.1 plan file for run-benchmark script.
3400         https://bugs.webkit.org/show_bug.cgi?id=195481
3401
3402         Rubber-stamped by Darin Adler.
3403
3404         Run-benchmark script should support MontionMark-1.1.
3405
3406         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3407
3408 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3409
3410         [ews-app] Add support for submit-to-ews url
3411         https://bugs.webkit.org/show_bug.cgi?id=195477
3412
3413         Reviewed by Lucas Forschler.
3414
3415         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3416         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3417         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3418         * BuildSlaveSupport/ews-app/ews/urls.py:
3419         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3420
3421 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3422
3423         Unreviewed, rolling out r242688, r242643, r242624.
3424
3425         Caused multiple layout test failures and crashes on iOS and macOS.
3426
3427         Reverted changeset:
3428
3429         "requestAnimationFrame should execute before the next frame"
3430         https://bugs.webkit.org/show_bug.cgi?id=177484
3431         https://trac.webkit.org/changeset/242624/webkit
3432
3433         * Tracing/SystemTracePoints.plist:
3434
3435 2019-03-11  John Wilander  <wilander@apple.com>
3436
3437         Resource Load Statistics: Make it possible exclude localhost from classification
3438         https://bugs.webkit.org/show_bug.cgi?id=195474
3439         <rdar://problem/47520577>
3440
3441         Reviewed by Brent Fulgham.
3442
3443         This patch allows for localhost to be excluded from classification and
3444         treatment as a prevalent resource.
3445
3446         The WebKit Tools change adds a new function called
3447         testRunner.setStatisticsIsRunningTest() which can be used to control this
3448         behavior.
3449
3450         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3451         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3452         (WTR::TestRunner::setStatisticsIsRunningTest):
3453         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3454         * WebKitTestRunner/TestController.cpp:
3455         (WTR::TestController::setStatisticsIsRunningTest):
3456         * WebKitTestRunner/TestController.h:
3457         * WebKitTestRunner/TestInvocation.cpp:
3458         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3459
3460 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3461
3462         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3463         https://bugs.webkit.org/show_bug.cgi?id=195560
3464
3465         Reviewed by Lucas Forschler.
3466
3467         * BuildSlaveSupport/ews-build/master.cfg:
3468
3469 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3470
3471         Unreviewed, rolling out r242698.
3472
3473         API test crashes on bots.
3474
3475         Reverted changeset:
3476
3477         "Add a WKContentRuleList variant that uses copied memory
3478         instead of mmap'd shared memory for class A containerized
3479         apps"
3480         https://bugs.webkit.org/show_bug.cgi?id=195511
3481         https://trac.webkit.org/changeset/242698
3482
3483 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3484
3485         [WPE] Enable web process sandbox
3486         https://bugs.webkit.org/show_bug.cgi?id=195169
3487
3488         Reviewed by Daniel Bates.
3489
3490         * wpe/install-dependencies:
3491         * wpe/jhbuild.modules:
3492
3493 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3494
3495         [ews-app] Use port 17000 for worker communication
3496         https://bugs.webkit.org/show_bug.cgi?id=195558
3497
3498         Reviewed by Lucas Forschler.
3499
3500         * BuildSlaveSupport/ews-build/master.cfg:
3501
3502 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3503
3504         [ews-build] unit-tests fail when passwords.json is missing
3505         https://bugs.webkit.org/show_bug.cgi?id=195557
3506
3507         Reviewed by Lucas Forschler.
3508
3509         * BuildSlaveSupport/ews-build/loadConfig.py:
3510         (loadBuilderConfig):
3511         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3512         (ConfigDotJSONTest.test_configuration):
3513         * BuildSlaveSupport/ews-build/master.cfg:
3514
3515 2019-03-11  Truitt Savell  <tsavell@apple.com>
3516
3517         Unreviewed, rolling out r242702.
3518
3519         Broke High Sierra builders.
3520
3521         Reverted changeset:
3522
3523         "Add utility function to allow easy reverse range-based
3524         iteration of a container"
3525         https://bugs.webkit.org/show_bug.cgi?id=195542
3526         https://trac.webkit.org/changeset/242702
3527
3528 2019-03-11  Sam Weinig  <sam@webkit.org>
3529
3530         Add utility function to allow easy reverse range-based iteration of a container
3531         https://bugs.webkit.org/show_bug.cgi?id=195542
3532
3533         Reviewed by Antti Koivisto.
3534
3535         * TestWebKitAPI/CMakeLists.txt:
3536         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3537         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3538         (TestWebKitAPI::TEST):
3539         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3540
3541 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3542
3543         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3544         https://bugs.webkit.org/show_bug.cgi?id=195511
3545         <rdar://problem/44873269>
3546
3547         Reviewed by Darin Adler.
3548
3549         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3550         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3551         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3552         (TEST_F):
3553
3554 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3555
3556         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3557         https://bugs.webkit.org/show_bug.cgi?id=195499
3558
3559         Reviewed by Darin Adler.
3560
3561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3562         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3563         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3564         (-[WKWebView synchronouslyFocusTextInputContext:]):
3565         (applyStyle):
3566         (applyIframe):
3567         (TEST):
3568         Add some tests for this SPI.
3569
3570 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3571
3572         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3573         https://bugs.webkit.org/show_bug.cgi?id=181151
3574
3575         Reviewed by Don Olmstead.
3576
3577         * TestWebKitAPI/CMakeLists.txt:
3578         * TestWebKitAPI/PlatformWin.cmake:
3579         Enable TestWTF RunLoop tests in all platforms.
3580
3581         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3582         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3583         (TestWebKitAPI::DerivedOneShotTimer::fired):
3584         (TestWebKitAPI::TEST):
3585         Only a few platforms support nested RunLoop.
3586
3587         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3588         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3589
3590 2019-03-10  David Quesada  <david_quesada@apple.com>
3591
3592         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3593         https://bugs.webkit.org/show_bug.cgi?id=152480
3594
3595         Reviewed by Chris Dumez.
3596
3597         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3598         there are no additional references to the process pool besides the one held by
3599         the download, waits for the download to finish (in the sense that the
3600         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3601         measure, also check that the process pool has been deallocated at the end of the
3602         test. The test wouldn't be meaningful if the process pool were still alive.
3603
3604         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3605         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3606         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3607             The download will be canceled because the delegate does not implement the
3608             method to decide the download's destination, so this is where we know the
3609             DownloadProxyMap is done with the DownloadProxy.
3610         (TEST):
3611
3612 2019-03-08  Chris Dumez  <cdumez@apple.com>
3613
3614         Add support for Device Orientation / Motion permission API
3615         https://bugs.webkit.org/show_bug.cgi?id=195329
3616         <rdar://problem/47645367>
3617
3618         Reviewed by Geoffrey Garen.
3619
3620         Add test infrastructure to help test the Device Orientation / Motion permission API.
3621
3622         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3623         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3624         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3625         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3626         * WebKitTestRunner/TestController.cpp:
3627         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3628         (WTR::TestController::createWebViewWithOptions):
3629         (WTR::TestController::resetStateToConsistentValues):
3630         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3631         * WebKitTestRunner/TestController.h:
3632         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3633         * WebKitTestRunner/TestInvocation.cpp:
3634         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3635
3636 2019-03-08  Saam barati  <sbarati@apple.com>
3637
3638         Add a compare-results script to compare benchmark results
3639         https://bugs.webkit.org/show_bug.cgi?id=195486
3640         <rdar://problem/48723397>
3641
3642         Reviewed by Geoffrey Garen.
3643
3644         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3645         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3646         to extend it to learn about our other benchmarks.
3647
3648         * Scripts/compare-results: Added.
3649         (readJSONFile):
3650         (detectJetStream2):
3651         (JetStream2Results):
3652         (detectSpeedometer2):
3653         (Speedometer2Results):
3654         (detectPLT5):
3655         (PLT5Results):
3656         (detectBenchmark):
3657         (biggerIsBetter):
3658         (ttest):
3659         (getOptions):
3660         (main):
3661
3662 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3663
3664         Ensure old tab state is cleared between iterations of run-benchmark
3665         https://bugs.webkit.org/show_bug.cgi?id=195393
3666         <rdar://problem/46885583>
3667
3668         Reviewed by Dewei Zhu.
3669
3670         a) ensure the default to restore state is not set
3671         b) terminate Safari correctly
3672         c) Set the system default to ignore Persistent State in Safari
3673
3674         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3675         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3676         (OSXBrowserDriver.prepare_env): 
3677         (OSXBrowserDriver.restore_env):
3678         (OSXBrowserDriver.close_browsers):
3679         (OSXBrowserDriver._terminate_processes):
3680         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3681         (OSXChromeDriver):
3682         (OSXChromeCanaryDriver):
3683         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3684         (OSXFirefoxDriver):
3685         (OSXFirefoxNightlyDriver):
3686         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3687         (OSXSafariDriver):
3688         (OSXSafariDriver.prepare_env):
3689
3690 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3691
3692         [GTK] Several InputMethodFilter tests are failing
3693         https://bugs.webkit.org/show_bug.cgi?id=195408
3694
3695         Reviewed by Carlos Garcia Campos.
3696
3697         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3698         Regressed in r241751.
3699         Hexadecimal values of keycodes are expressed now in upper letters.
3700         Composited characters should be cast to UTF8 strings.
3701
3702         (TestWebKitAPI::TEST):
3703
3704 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3705
3706         [GTK] Make Tools/gtkdoc python3 compatible
3707         https://bugs.webkit.org/show_bug.cgi?id=195359
3708
3709         Reviewed by Carlos Garcia Campos.
3710
3711         * gtkdoc/generate-gtkdoc:
3712         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3713         work with Python 2 and 3.
3714         (get_gtkdoc_module_paths):
3715         The iteritems() was removed in Python 3, so let's use items() that's
3716         available in Python 2 and 3.
3717         (get_generator_for_config):
3718         * gtkdoc/gtkdoc.py:
3719         (GTKDoc._run_command):
3720         The sys.stdout.write() is expecting str in Python 3 and not bytes
3721         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3722         for passing the bytes there.
3723
3724 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3725
3726         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3727         https://bugs.webkit.org/show_bug.cgi?id=195346
3728         <rdar://problem/48667048>
3729
3730         Unreviewed build fix for clang-cl.
3731
3732         * DumpRenderTree/win/DumpRenderTree.cpp:
3733         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3734
3735 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3736
3737         requestAnimationFrame should execute before the next frame
3738         https://bugs.webkit.org/show_bug.cgi?id=177484
3739
3740         Reviewed by Simon Fraser.
3741
3742         Add trace points for the page RenderingUpdate.
3743
3744         * Tracing/SystemTracePoints.plist:
3745
3746 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3747
3748         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3749         https://bugs.webkit.org/show_bug.cgi?id=195353
3750         <rdar://problem/48626394>
3751
3752         Reviewed by Simon Fraser.
3753
3754         * WebKitTestRunner/ios/TestControllerIOS.mm:
3755         (WTR::TestController::platformResetPreferencesToConsistentValues):
3756
3757 2019-03-07  John Wilander  <wilander@apple.com>
3758
3759         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3760         https://bugs.webkit.org/show_bug.cgi?id=195383
3761         <rdar://problem/48570136>
3762
3763         Reviewed by Brent Fulgham.
3764
3765         This patch adds test infrastructure to purge only script-accessible cookies,
3766         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3767
3768         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3769         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3770         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3771         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3772         * WebKitTestRunner/TestController.cpp:
3773         (WTR::TestController::statisticsDeleteCookiesForHost):
3774         * WebKitTestRunner/TestController.h:
3775         * WebKitTestRunner/TestInvocation.cpp:
3776         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3777
3778 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3779
3780         Unreviewed, rolling out r242354.
3781         https://bugs.webkit.org/show_bug.cgi?id=195402
3782
3783         breaks layout tests in all configurations (Requested by
3784         zdobersek on #webkit).
3785
3786         Reverted changeset:
3787
3788         "[WPE] Enable web process sandbox"
3789         https://bugs.webkit.org/show_bug.cgi?id=195169
3790         https://trac.webkit.org/changeset/242354
3791
3792 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3793
3794         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3795         https://bugs.webkit.org/show_bug.cgi?id=195346
3796
3797         Reviewed by Fujii Hironori.
3798
3799         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3800         (TestWebKitAPI::TEST):
3801         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3802
3803         * DumpRenderTree/win/DumpRenderTree.cpp:
3804         (findFontFallback):
3805         (addFontFallbackIfPresent):
3806         (removeFontFallbackIfPresent):
3807         (main):
3808         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3809         (TestWebKitAPI::Util::moduleDirectory):
3810         (TestWebKitAPI::Util::createInjectedBundlePath):
3811         Use wchar helpers as needed.
3812
3813 2019-03-06  Rob Buis  <rbuis@igalia.com>
3814
3815         Consider supporting the `referrerpolicy` attribute.
3816         https://bugs.webkit.org/show_bug.cgi?id=179053
3817
3818         Reviewed by Darin Adler.
3819
3820         Add a runtime flag for referrerpolicy attribute.
3821
3822         * DumpRenderTree/mac/DumpRenderTree.mm:
3823         (enableExperimentalFeatures):
3824
3825 2019-03-05  Daniel Bates  <dabates@apple.com>
3826
3827         Update expected API test result following r242379
3828         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3829
3830         Update expected x-coordinate of selection rect now that the left padding of
3831         a textarea is sized in ems (so dependent on the font size) just like the left
3832         padding of a text field.
3833
3834         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3835         (TestWebKitAPI::TEST):
3836
3837 2019-03-05  David Quesada  <david_quesada@apple.com>
3838
3839         [WK2] It should be possible to follow links with 'download' attributes
3840         https://bugs.webkit.org/show_bug.cgi?id=195145
3841         rdar://problem/48462642
3842
3843         Reviewed by Alex Christensen.
3844
3845         Add a unit test to verify that activating links with 'download' attributes now
3846         navigates to the linked resource, rather than starts downloading it. Add another
3847         to verify that it is still possible to explicitly download the link via the
3848         'Download' navigation action policy.
3849
3850         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3851         (-[DownloadAttributeTestDelegate init]):
3852         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3853         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3854         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3855         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3856         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3857         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3858         (TEST):
3859         * WebKitTestRunner/TestController.cpp:
3860         (WTR::TestController::decidePolicyForNavigationAction):
3861         * WebKitTestRunner/TestController.h:
3862
3863 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3864
3865         [Curl] Implement Cookie Accept Policy.
3866         https://bugs.webkit.org/show_bug.cgi?id=191645
3867
3868         Reviewed by Fujii Hironori.
3869
3870         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3871         (TestWebKitAPI::Curl::TEST_F):
3872
3873 2019-03-05  Youenn Fablet  <youenn@apple.com>
3874
3875         Rename requestCacheStorageSpace to requestStorageSpace
3876         https://bugs.webkit.org/show_bug.cgi?id=195282
3877
3878         Reviewed by Chris Dumez.
3879
3880         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3881         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3882         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3883
3884 2019-03-05  Brady Eidson  <beidson@apple.com>
3885
3886         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3887         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3888
3889         Reviewed by Tim Horton.
3890
3891         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3892         different directory into that same WKWebView should work.
3893
3894         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3895         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3896
3897 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3898
3899         Add WeakHashSet
3900         https://bugs.webkit.org/show_bug.cgi?id=195152
3901
3902         Reviewed by Antti Koivisto.
3903
3904         Added tests for WeakHashSet.
3905
3906         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3907         (TestWebKitAPI::Base::Base): Moved.
3908         (TestWebKitAPI::Derived::foo): Moved.
3909         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3910         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3911         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3912         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3913
3914 2019-03-04  Chris Dumez  <cdumez@apple.com>
3915
3916         Do not share WebProcesses between private and regular sessions
3917         https://bugs.webkit.org/show_bug.cgi?id=195189
3918         <rdar://problem/48421064>
3919
3920         Reviewed by Alex Christensen.
3921
3922         Add API test coverage.
3923
3924         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3925         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3926
3927 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3928
3929         [WPE] Enable web process sandbox
3930         https://bugs.webkit.org/show_bug.cgi?id=195169
3931
3932         Reviewed by Daniel Bates.
3933
3934         * wpe/install-dependencies:
3935         * wpe/jhbuild.modules:
3936
3937 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3938
3939         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3940         https://bugs.webkit.org/show_bug.cgi?id=195206
3941
3942         Reviewed by Žan Doberšek.
3943
3944         Add a new test case.
3945
3946         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3947         (testJSCClass):
3948
3949 2019-03-04  Charlie Turner  <cturner@igalia.com>
3950
3951         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3952         https://bugs.webkit.org/show_bug.cgi?id=194898
3953
3954         Reviewed by Žan Doberšek.
3955
3956         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3957         a GCC extension that permits arithmetic on void* pointer. Inline
3958         the macro until this issue is fixed upstream.
3959
3960 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3961
3962         Rid the world of WK_API_ENABLED
3963         https://bugs.webkit.org/show_bug.cgi?id=195263
3964
3965         Reviewed by Dan Bernstein.
3966
3967         List of changed files elided because it's useless.
3968
3969 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3970
3971         Unreviewed follow-up to r242292.
3972
3973         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3974
3975         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3976         (TestWebKitAPI::testStrip): Renamed from strip.
3977         (TestWebKitAPI::TEST):
3978
3979 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3980
3981         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3982
3983         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3984         and bug #194272 for details.
3985
3986         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3987
3988 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3989
3990         Remove some more unused 32-bit code
3991         https://bugs.webkit.org/show_bug.cgi?id=195255
3992
3993         Reviewed by Darin Adler.
3994
3995         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3996         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3997         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3998         (NPP_New):
3999         (NPP_HandleEvent):
4000         (handleEventCarbon): Deleted.
4001
4002 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4003
4004         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4005
4006         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4007         (TestWebKitAPI::TEST):
4008
4009 2019-03-01  Darin Adler  <darin@apple.com>
4010
4011         Finish removing String::format
4012         https://bugs.webkit.org/show_bug.cgi?id=194893
4013
4014         Reviewed by Daniel Bates.
4015 '
4016         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4017
4018 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4019
4020         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4021         https://bugs.webkit.org/show_bug.cgi?id=195229
4022         <rdar://problem/48520362>
4023
4024         Reviewed by Chris Dumez.
4025
4026         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4027         (TEST):
4028
4029 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4030
4031         Add a system trace scope for event region building
4032         https://bugs.webkit.org/show_bug.cgi?id=195226
4033
4034         Reviewed by Jon Lee.
4035
4036         This trace scope measures the time spend converting element rects into Region objects,
4037         which can be large on some pages.
4038
4039         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4040
4041         * Tracing/SystemTracePoints.plist:
4042
4043 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4044
4045         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4046         https://bugs.webkit.org/show_bug.cgi?id=194612
4047
4048         Reviewed by Alex Christensen.
4049
4050         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4051         Just test the new string-processing function and don't touch the actual environment.
4052         (Test cases are all as before, but based on operator== instead of strcmp.)
4053
4054 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4055
4056         [ews-app] Update primary keys for handling multiple Buildbot instances
4057         https://bugs.webkit.org/show_bug.cgi?id=195120
4058
4059         Reviewed by Stephanie Lewis.
4060
4061         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4062         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4063         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4064
4065         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4066         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4067         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4068         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4069         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4070         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4071
4072 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4073
4074         [WinCairo] Enable service worker
4075         https://bugs.webkit.org/show_bug.cgi?id=188318
4076
4077         Reviewed by Youenn Fablet.
4078
4079         * DumpRenderTree/DumpRenderTreePrefix.h:
4080         * TestWebKitAPI/PlatformWin.cmake:
4081         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4082         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4083         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4084
4085 2019-03-01  Justin Fan  <justin_fan@apple.com>
4086
4087         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4088         https://bugs.webkit.org/show_bug.cgi?id=195191
4089
4090         Rubber-stamped by Dean Jackson.
4091
4092         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4093
4094         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4095
4096 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4097
4098         Unreviewed, fix lldb webkitpy tests
4099         https://bugs.webkit.org/show_bug.cgi?id=194375
4100
4101         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4102
4103         * lldb/lldb_webkit.py:
4104         (WTFStringImplProvider.is_8bit):
4105
4106 2019-02-28  David Quesada  <david_quesada@apple.com>
4107
4108         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4109         https://bugs.webkit.org/show_bug.cgi?id=195121
4110         rdar://problem/48450302
4111
4112         Reviewed by Alex Christensen.
4113
4114         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4115         configurations where the 'download' attribute is absent, blank, or populated
4116         with a filename, and where the anchor element is same-origin or cross-origin
4117         (meaning the 'download' attribute shouldn't be honored).
4118
4119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4120         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4121         (-[NavigationActionTestDelegate init]):
4122         (-[NavigationActionTestDelegate navigationAction]):
4123         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4124         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4125         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4126         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4127         (TEST):
4128
4129 2019-02-28  Antoine Quint  <graouts@apple.com>
4130
4131         Enable the Pointer Events runtime flag by default
4132         https://bugs.webkit.org/show_bug.cgi?id=195156
4133
4134         Reviewed by Dean Jackson.
4135
4136         * DumpRenderTree/mac/DumpRenderTree.mm:
4137         (enableExperimentalFeatures):
4138
4139 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4140
4141         Several PasteImage API tests are flaky
4142         https://bugs.webkit.org/show_bug.cgi?id=195160
4143
4144         Reviewed by Tim Horton.
4145
4146         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4147         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4148         listening for a "load" event after image load is already complete.
4149
4150         To address this, make these tests first register a "load" event handler, then run script to insert an image
4151         element into the document, and finally wait until the load event is observed before checking image size.
4152
4153         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4154
4155 2019-02-28  Chris Dumez  <cdumez@apple.com>
4156
4157         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4158         https://bugs.webkit.org/show_bug.cgi?id=195107
4159
4160         Reviewed by Alex Christensen.
4161
4162         Give some time for the zoom level to get restored.
4163
4164         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4165
4166 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4167
4168         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4169         https://bugs.webkit.org/show_bug.cgi?id=194958
4170
4171         Reviewed by Geoffrey Garen.
4172
4173         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4174         (TEST):
4175
4176 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4177
4178         [ews-app] Update method to save build to handle builder_display_name
4179         https://bugs.webkit.org/show_bug.cgi?id=195047
4180
4181         Reviewed by Dewei Zhu.
4182
4183         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4184         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4185
4186 2019-02-28  Justin Fan  <justin_fan@apple.com>
4187
4188         [Web GPU] Enable Web GPU only on 64-bit
4189         https://bugs.webkit.org/show_bug.cgi?id=195139
4190
4191         Because Metal is only supported on 64 bit apps.
4192
4193         Unreviewed build fix.
4194
4195         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4196
4197 2019-02-27  Youenn Fablet  <youenn@apple.com>
4198
4199         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4200         https://bugs.webkit.org/show_bug.cgi?id=194959
4201
4202         Reviewed by Chris Dumez.
4203
4204         Spin loop until getting the condition to remove flakiness.
4205
4206         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4207
4208 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4209
4210         [ews-build] Buildbot should include builder_display_name in the build events
4211         https://bugs.webkit.org/show_bug.cgi?id=195045
4212
4213         Reviewed by Dewei Zhu.
4214
4215         * BuildSlaveSupport/ews-build/events.py:
4216         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4217         buildername to builder_name to be consistent in naming style.
4218         (Events.buildFinished): Ditto.
4219
4220 2019-02-27  Chris Dumez  <cdumez@apple.com>
4221
4222         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4223         https://bugs.webkit.org/show_bug.cgi?id=194480
4224
4225         Reviewed by Brady Eidson.
4226
4227         Update existing API test to make it more likely to reproduce the issue.
4228
4229         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4230
4231 2019-02-27  Brady Eidson  <beidson@apple.com>
4232
4233         Universal links from Google search results pages don't open the app.
4234         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4235
4236         Reviewed by Geoffrey Garen.
4237
4238         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4239         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4240         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4241         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4242
4243 2019-02-27  Chris Dumez  <cdumez@apple.com>
4244
4245         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4246         https://bugs.webkit.org/show_bug.cgi?id=195102
4247
4248         Reviewed by Geoffrey Garen.
4249
4250         If the number of processes is not yet what we expect, wait a bit and check again to give
4251         processes some time to exit.
4252
4253         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4254
4255 2019-02-27  Chris Dumez  <cdumez@apple.com>
4256
4257         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4258         https://bugs.webkit.org/show_bug.cgi?id=194545
4259
4260         Reviewed by Brady Eidson.
4261
4262         Make sure the test navigates forward and then back only once. Previously, navigating
4263         back would trigger a navigation again in a timer.
4264
4265         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4266
4267 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4268
4269         High Sierra Debug JSC test queue should use faster hardware
4270         https://bugs.webkit.org/show_bug.cgi?id=194603
4271
4272         Rubber-stamped by Alexey Proskuryakov.
4273
4274         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4275
4276         * BuildSlaveSupport/build.webkit.org-config/config.json:
4277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4278         (BubbleQueueServer):
4279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4280         (WebKitBuildbot):
4281         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4282         * QueueStatusServer/config/queues.py:
4283         * Scripts/webkitpy/common/config/ews.json:
4284         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4285         (test_ews_name):
4286
4287 2019-02-27  John Wilander  <wilander@apple.com>
4288
4289         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4290         https://bugs.webkit.org/show_bug.cgi?id=195071
4291         <rdar://problem/48417690>
4292
4293         Reviewed by Alex Christensen and Brent Fulgham.
4294
4295         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4296         (TestWebKitAPI::createURL):
4297             Convenience function.
4298         (TestWebKitAPI::TEST):
4299             WebCore::AdClickAttribution now takes a URL when creating Source and
4300             Destination.
4301         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4302         (TestWebKitAPI::TEST):
4303             WebCore::AdClickAttribution now takes a URL when creating Source and
4304             Destination.
4305
4306 2019-02-27  Antoine Quint  <graouts@apple.com>
4307
4308         Support Pointer Events on macOS
4309         https://bugs.webkit.org/show_bug.cgi?id=195008
4310         <rdar://problem/47454419>
4311
4312         Reviewed by Dean Jackson.
4313
4314         * DumpRenderTree/mac/DumpRenderTree.mm:
4315         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4316         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4317
4318 2019-02-26  Mark Lam  <mark.lam@apple.com>
4319
4320         Remove remaining poisoning code.
4321         https://bugs.webkit.org/show_bug.cgi?id=194138
4322
4323         Reviewed by Saam Barati.
4324
4325         * TestWebKitAPI/CMakeLists.txt:
4326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4327         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4328         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4329         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4330         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4331         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4332         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4333
4334 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4335
4336         Move ephemeral local storage from WebProcess to UIProcess
4337         https://bugs.webkit.org/show_bug.cgi?id=195074
4338         <rdar://problem/47937975>
4339
4340         Reviewed by Geoff Garen.
4341
4342         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4343
4344 2019-02-20  Jer Noble  <jer.noble@apple.com>
4345
4346         [Cocoa] Media elements will restart network buffering just before suspending
4347         https://bugs.webkit.org/show_bug.cgi?id=193691
4348
4349         Reviewed by Eric Carlson.
4350
4351         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4352         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4353         (TEST):
4354
4355 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4356
4357         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4358         https://bugs.webkit.org/show_bug.cgi?id=191652
4359
4360         Reviewed by Alex Christensen.
4361
4362         Fix WinCairo MiniBrowser behavior of authentication dialog.
4363
4364         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4365         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4366
4367 2019-02-26  Youenn Fablet  <youenn@apple.com>
4368
4369         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4370         https://bugs.webkit.org/show_bug.cgi?id=195028
4371         <rdar://problem/48243733>