Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
4         https://bugs.webkit.org/show_bug.cgi?id=114397
5
6         Reviewed by Benjamin Poulain.
7
8         Reland the patch since Alan appears to have finished the migration.
9
10         * Scripts/webkitpy/common/net/statusserver.py:
11         (StatusServer):
12
13 2013-04-11  Brian Holt  <brian.holt@samsung.com>
14
15         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
16         https://bugs.webkit.org/show_bug.cgi?id=76796
17
18         Reviewed by Chris Fleizach.
19
20         Make the Gtk window for the DRT a toplevel so that it gets the
21         focus from the window manager when the test starts.
22
23         * DumpRenderTree/gtk/DumpRenderTree.cpp:
24         (main):
25
26 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
27
28         Use CSS4 image-rendering to determing image scaling quality
29         https://bugs.webkit.org/show_bug.cgi?id=113405
30
31         Reviewed by Simon Fraser.
32
33         Introduce new flag to enable experimental support for CSS4 Images.
34
35         * Scripts/webkitperl/FeatureList.pm:
36
37 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
38
39         Remove code for Chromium from wkbuild.py
40         https://bugs.webkit.org/show_bug.cgi?id=114423
41
42         Reviewed by Benjamin Poulain.
43
44         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
45         (_should_file_trigger_build):
46         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
47         (ShouldBuildTest):
48
49 2013-04-11  Philippe Normand  <pnormand@igalia.com>
50
51         Unreviewed, update my IRC nickname.
52
53         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
54
55 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
56
57         Remove the rest of Chromium code from webkitpy
58         https://bugs.webkit.org/show_bug.cgi?id=114420
59
60         Reviewed by Benjamin Poulain.
61
62         * Scripts/webkitpy/common/config/urls.py:
63         (view_revision_url):
64         * Scripts/webkitpy/common/host.py:
65         (Host._engage_awesome_locale_hacks):
66         (Host.initialize_scm):
67         (Host):
68         * Scripts/webkitpy/common/host_mock.py:
69         (MockHost.__init__):
70         (MockHost.checkout):
71         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
72         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
73         (JSONResultsGeneratorBase._insert_generic_metadata):
74         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
75         (TestExpectationParser._tokenize_line):
76         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
77         (ExpectationSyntaxTests.test_bare_name_and_bugs):
78         (ExpectationSyntaxTests.test_warnings):
79         * Scripts/webkitpy/layout_tests/port/base.py:
80         (Port.skips_perf_test):
81         (Port.path_to_test_expectations_file):
82         (Port._port_flag_for_scripts):
83         * Scripts/webkitpy/style/checkers/cpp.py:
84         (check_function_definition):
85         (check_include_line):
86         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
87         (OrderOfIncludesTest.test_check_wtf_includes):
88         (WebKitStyleTest.test_webkit_export_check):
89         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
90         (TestExpectationsTestCase.test_valid_expectations):
91         * Scripts/webkitpy/tool/bot/irc_command.py:
92         (Rollout.execute):
93         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
94         (IRCCommandTest.test_whois):
95         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
96         (IRCBotTest.test_help):
97         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
98         (SheriffBotTest.test_command_aliases):
99
100 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
101
102         roll-chromium-deps doesn't roll DEPS
103         https://bugs.webkit.org/show_bug.cgi?id=114421
104
105         Reviewed by Antti Koivisto.
106
107         Roll DEPS. Rolling DEPS. Rolled DEPS.
108
109         * Scripts/webkitpy/tool/bot/irc_command.py:
110         (RollChromiumDEPS.execute):
111
112 2013-04-11  Glenn Adams  <glenn@skynav.com>
113
114         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
115         https://bugs.webkit.org/show_bug.cgi?id=114418
116
117         Reviewed by Ryosuke Niwa.
118
119         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
120         (MockSCM.add): Remove optional remove_exit_code argument.
121         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
122         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
123         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
124         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
125
126 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
127
128         Fix roll-chromium-deps and hi.
129
130         * Scripts/webkitpy/tool/bot/irc_command.py:
131         (Hi.execute):
132         (RollChromiumDEPS.execute):
133
134 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
135
136         Remove webkitpy code to roll Chromium DEPS
137         https://bugs.webkit.org/show_bug.cgi?id=114415
138
139         Reviewed by Benjamin Poulain.
140
141         Removed the code to roll Chromium DEPS in WebKit.
142
143         * Scripts/webkitpy/common/checkout/checkout.py:
144         (Checkout.bug_id_for_this_commit):
145         * Scripts/webkitpy/common/checkout/checkout_mock.py:
146         (MockCheckout.commit_message_for_this_commit):
147         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
148         (CheckoutTest.test_suggested_reviewers):
149         * Scripts/webkitpy/common/checkout/deps.py: Removed.
150         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
151         * Scripts/webkitpy/tool/bot/irc_command.py:
152         (RollChromiumDEPS): Teach webkitbot a sense of humor.
153         (RollChromiumDEPS.execute):
154         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
155         (IRCCommandTest.test_create_bug):
156         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
157         (IRCBotTest.test_revert):
158         * Scripts/webkitpy/tool/bot/sheriff.py:
159         (Sheriff.post_rollout_patch):
160         * Scripts/webkitpy/tool/commands/__init__.py:
161         * Scripts/webkitpy/tool/commands/roll.py: Removed.
162         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
163         * Scripts/webkitpy/tool/steps/__init__.py:
164         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
165         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
166         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
167
168 2013-04-11  Glenn Adams  <glenn@skynav.com>
169
170         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
171         https://bugs.webkit.org/show_bug.cgi?id=114386
172
173         Reviewed by Benjamin Poulain.
174
175         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
176         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
177         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
178         by default and to return exit code 1 if a file/dir had already been added.
179
180         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
181         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
182         * Scripts/webkitpy/common/checkout/scm/svn.py:
183         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
184
185 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
186
187         Unreviewed.
188
189         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
190
191 2013-04-10  Glenn Adams  <glenn@skynav.com>
192
193         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
194         https://bugs.webkit.org/show_bug.cgi?id=114410
195
196         Reviewed by Ryosuke Niwa.
197
198         * Scripts/webkitpy/common/checkout/scm/git.py:
199         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
200         * Scripts/webkitpy/common/checkout/scm/scm.py:
201         (SCM.add): Remove optional return_exit_code argument.
202         (SCM.add_list): Remove optional return_exit_code argument.
203         * Scripts/webkitpy/common/checkout/scm/svn.py:
204         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
205
206 2013-04-10  Eric Seidel  <eric@webkit.org>
207
208         Remove myself from the watchlists, I'm getting too much bug mail. :)
209
210         * Scripts/webkitpy/common/config/watchlist:
211
212 2013-04-10  Commit Queue  <rniwa@webkit.org>
213
214         Unreviewed, rolling out r148158.
215         http://trac.webkit.org/changeset/148158
216         https://bugs.webkit.org/show_bug.cgi?id=114405
217
218         We need to migrate status data (Requested by rniwa on
219         #webkit).
220
221         * Scripts/webkitpy/common/net/statusserver.py:
222         (StatusServer):
223
224 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
225
226         Mass remove all the empty directories
227
228         Rubberstamped by Ryosuke Niwa.
229
230         * BuildSlaveSupport/gtk/crashmon/log: Removed.
231         * BuildSlaveSupport/gtk/xvfb/log: Removed.
232         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
233         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
234         * MiniBrowser/gtk/WebBundle: Removed.
235         * MiniBrowser/win: Removed.
236         * QtTestPlatformPlugin/mac: Removed.
237         * Scripts/webkitpy/tool/bot/testdata: Removed.
238         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
239         * efl/ImageDiff: Removed.
240         * iExploder/htdocs: Removed.
241         * iExploder/iexploder-1.7.2/output: Removed.
242         * iExploder/tools: Removed.
243         * qmake/config.tests/libexecdir: Removed.
244         * qmake/config.tests/libjpeg: Removed.
245         * qmake/config.tests/libpng: Removed.
246
247 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
248
249         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
250         https://bugs.webkit.org/show_bug.cgi?id=114397
251
252         Reviewed by Benjamin Poulain.
253
254         * Scripts/webkitpy/common/net/statusserver.py:
255         (StatusServer):
256
257 2013-04-10  Adam Barth  <abarth@webkit.org>
258
259         Remove abarth from watchlists
260         https://bugs.webkit.org/show_bug.cgi?id=114390
261
262         Reviewed by Ryosuke Niwa.
263
264         I'm trying to cut down on the amount of bugmail I get so that I'll have
265         more of a chance to notice a piece of bugmail directed at me.
266
267         * Scripts/webkitpy/common/config/watchlist:
268
269 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
270
271         webkit-test-results.appspot.com loads the dashboard for Chromium by default
272         https://bugs.webkit.org/show_bug.cgi?id=114381
273
274         Reviewed by Benjamin Poulain.
275
276         Changed the defaults.
277
278         * TestResultServer/static-dashboards/builders.js:
279         * TestResultServer/static-dashboards/dashboard_base.js:
280         (currentBuilderGroupCategory):
281
282 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
283
284         Remove Chromium EWS bots from the queue status server
285         https://bugs.webkit.org/show_bug.cgi?id=113988
286
287         Reviewed by Benjamin Poulain.
288
289         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
290
291         * QueueStatusServer/app.yaml:
292         * QueueStatusServer/config/queues.py:
293         * QueueStatusServer/model/queues.py:
294         (Queue.short_name):
295         (Queue.display_name):
296         * QueueStatusServer/model/queues_unittest.py:
297         (QueueTest.test_short_name):
298         (QueueTest.test_display_name):
299         (QueueTest.test_name_with_underscores):
300         * QueueStatusServer/templates/activebots.html:
301
302 2013-04-10  Ojan Vafai  <ojan@chromium.org>
303
304         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
305         https://bugs.webkit.org/show_bug.cgi?id=114370
306
307         Reviewed by Ryosuke Niwa.
308
309         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
310         Unfortunately, there's no way to test this until this is committed and there is
311         a master restart.
312
313         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
314         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
315         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
316         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
317         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
318         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
319         * TestResultServer/generate_builders_json.py:
320         * TestResultServer/static-dashboards/dashboard_base.js:
321         * TestResultServer/static-dashboards/loader.js:
322
323 2013-04-10  Glenn Adams  <glenn@skynav.com>
324
325         [Qt] Fix regression to test-webkitpy.
326         https://bugs.webkit.org/show_bug.cgi?id=114368
327
328         Reviewed by Ryosuke Niwa.
329
330         * Scripts/webkitpy/layout_tests/port/factory.py:
331         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
332         (PortFactory.get): Remove obsolete chromium port related code.
333         * Scripts/webkitpy/layout_tests/port/mac.py:
334         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
335
336 2013-04-10  Anders Carlsson  <andersca@apple.com>
337
338         Remove unneeded headers from FrameLoader.h
339         https://bugs.webkit.org/show_bug.cgi?id=114223
340
341         Reviewed by Geoffrey Garen.
342
343         Add back headers implicitly included by other headers.
344
345         * WebKitTestRunner/WorkQueueManager.cpp:
346
347 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
348
349         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
350         https://bugs.webkit.org/show_bug.cgi?id=114365
351
352         Reviewed by Martin Robinson.
353
354         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
355         The patch addresses crashes in the tally_event_reply method. It is already committed into the
356         at-spi2-atk source tree and will be available with the next stable release, after which the
357         patch should be removed and the dependency version bumped.
358
359         * gtk/jhbuild.modules:
360         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
361
362 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
363
364         [WinCairo] Unreviewed build fix. Correct DropBox download link.
365
366         * Scripts/update-webkit-wincairo-libs: Revise download URL to
367         match change in DropBox server behavior.
368
369 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
370
371         Removed an annoying message from svn-create-patch
372         https://bugs.webkit.org/show_bug.cgi?id=114332
373
374         Reviewed by Alexey Proskuryakov.
375
376         I see this message basically every time I write a patch, so it must not
377         be true.
378
379         * Scripts/svn-create-patch:
380         (generateDiff):
381
382 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
383
384         [GTK] Add support for Page Visibility
385         https://bugs.webkit.org/show_bug.cgi?id=97324
386
387         Reviewed by Sam Weinig.
388
389         Implemented test runner API for page visibility layout tests.
390
391         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
392         (TestRunner::resetPageVisibility):
393         (TestRunner::setPageVisibility):
394         * Scripts/webkitperl/FeatureList.pm:
395
396 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
397
398         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
399         https://bugs.webkit.org/show_bug.cgi?id=114342
400
401         Reviewed by Gyuyoung Kim.
402
403         Commit 148033 only added an implementation for the Mac port, which made
404         other ports fail most tests since loading the injected bundle failed
405         with a missing symbol.
406
407         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
408         (WTR::AccessibilityUIElement::pathDescription):
409
410 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
411
412         [EFL] Add spell checking option to MiniBrowser
413         https://bugs.webkit.org/show_bug.cgi?id=114282
414
415         Reviewed by Ryosuke Niwa.
416
417         Spell checking is enabled by adding a flag (t/text-checking)
418         with launching MiniBrowser.
419
420         * MiniBrowser/efl/main.c:
421         (window_create):
422         (elm_main):
423
424 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
425
426         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
427         https://bugs.webkit.org/show_bug.cgi?id=113281
428
429         Reviewed by Darin Adler.
430
431         * Scripts/run-gtk-tests:
432         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
433
434 2013-04-09  Glenn Adams  <glenn@skynav.com>
435
436         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
437
438         Unreviewed.
439
440         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
441         (RunTest.test_build_check):
442
443 2013-04-09  Glenn Adams  <glenn@skynav.com>
444
445         [webkitpy] Remove chromium ports.
446         https://bugs.webkit.org/show_bug.cgi?id=114326
447
448         Reviewed by Dirk Pranke.
449
450         As a side effect, also:
451
452         - remove chromium builders from webkitpy.layout_tests.port.builders
453         - remove chromium builders from rebaseline
454         - rewrite chromium dependent tests in rebaseline_unittest
455         - remove chromium platform from garden-o-matic
456         - select apple platform as default platform in garden-o-matic
457         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
458
459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
461         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
462         (BaselineOptimizerTest.test_move_baselines):
463         (BaselineOptimizerTest.test_efl):
464         (BaselineOptimizerTest.test_no_add_mac_future):
465         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
466         (BaselineOptimizerTest.test_common_directory_includes_root):
467         (BaselineOptimizerTest.test_complex_shadowing):
468         (BaselineOptimizerTest.test_virtual_ports_filtered):
469         * Scripts/webkitpy/layout_tests/port/builders.py:
470         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
471         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
472         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
473         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
474         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
475         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
476         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
477         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
478         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
479         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
480         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
481         * Scripts/webkitpy/layout_tests/port/factory.py:
482         (platform_options):
483         (PortFactory):
484         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
485         (FactoryTest.test_qt):
486         (FactoryTest.test_get_from_builder_name):
487         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
488         (RunTest.test_build_check):
489         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
490         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
491         * Scripts/webkitpy/tool/commands/rebaseline.py:
492         (Rebaseline._builders_to_pull_from):
493         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
494         (_BaseTestCase):
495         (_BaseTestCase.setUp):
496         (TestRebaselineTest.setUp):
497         (TestRebaselineTest.test_baseline_directory):
498         (test_rebaseline_updates_expectations_file):
499         (test_rebaseline_does_not_include_overrides):
500         (test_rebaseline_test):
501         (test_rebaseline_test_and_print_scm_changes):
502         (test_rebaseline_and_copy_test):
503         (test_rebaseline_and_copy_test_no_existing_result):
504         (test_rebaseline_and_copy_test_with_lion_result):
505         (test_rebaseline_and_copy_no_overwrite_test):
506         (TestRebaselineExpectations.test_rebaseline_expectations):
507
508 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
509
510         newcommitbot (WKR) requires a subversion checkout
511         https://bugs.webkit.org/show_bug.cgi?id=114309
512
513         Reviewed by Benjamin Poulain.
514
515         Directly talk to the subversion server instead of relying on a local checkout.
516         This allows us to run WKR off of a git clone.
517
518         * Scripts/webkitpy/tool/commands/newcommitbot.py:
519         (NewCommitBot.next_work_item):
520         (NewCommitBot.process_work_item):
521
522 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
523
524         webkitbot refers to sheriffbot in help
525         https://bugs.webkit.org/show_bug.cgi?id=114307
526
527         Reviewed by Benjamin Poulain.
528
529         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
530
531         * Scripts/webkitpy/tool/bot/irc_command.py:
532         (Help):
533         (Help.execute):
534         (RollChromiumDEPS.execute):
535         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
536         (IRCBotTest.test_help):
537         * Scripts/webkitpy/tool/bot/sheriff.py:
538         (Sheriff.name):
539
540 2013-04-06  Roger Fong  <roger_fong@apple.com>
541
542         Kill old processes between runs on WinEWS bots.
543         Temporarily disable tests to let bots catch up again.
544
545         * EWSTools/start-queue-win.sh:
546         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
547         (WinEWS):
548
549 2013-04-09  Glenn Adams  <glenn@skynav.com>
550
551         [webkitpy] Remove chromium deprecated port support.
552         https://bugs.webkit.org/show_bug.cgi?id=114228
553
554         Reviewed by Ryosuke Niwa.
555
556         * Scripts/webkitpy/common/config/ports.py:
557         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
558         (ChromiumPort): Removed.
559         (ChromiumAndroidPort): Removed.
560         (ChromiumXVFBPort): Removed.
561         * Scripts/webkitpy/common/config/ports_unittest.py:
562         (DeprecatedPortTest.test_chromium_port): Removed.
563         (DeprecatedPortTest.test_chromium_android_port): Removed.
564         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
565         * Scripts/webkitpy/tool/steps/update_unittest.py:
566         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
567         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
568
569 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
570
571         AX: The bounding paths should be made available through accessibility
572         https://bugs.webkit.org/show_bug.cgi?id=113817
573
574         Reviewed by David Kilzer.
575
576         Add a pathDescription property for testing so that it's possible
577         to verify that a path is being returned correctly.
578
579         * DumpRenderTree/AccessibilityUIElement.cpp:
580         (getPathDescriptionCallback):
581         (AccessibilityUIElement::pathDescription):
582         (AccessibilityUIElement::getJSClass):
583         * DumpRenderTree/AccessibilityUIElement.h:
584         (AccessibilityUIElement):
585         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
586         (_CGPathEnumerationIteration):
587         (AccessibilityUIElement::pathDescription):
588         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
589         (AccessibilityUIElement::pathDescription):
590         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
591         (WTR::AccessibilityUIElement::pathDescription):
592         (WTR):
593         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
594         (AccessibilityUIElement):
595         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
596         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
597         (WTR::AccessibilityUIElement::pathDescription):
598         (WTR):
599
600 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
601
602         [EFL] Declare TEST_THEME_DIR in a single place.
603         https://bugs.webkit.org/show_bug.cgi?id=114285
604
605         Reviewed by Anders Carlsson.
606
607         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
608
609         * DumpRenderTree/efl/CMakeLists.txt:
610         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
611         (DumpRenderTreeChrome::createView):
612         (DumpRenderTreeChrome::createInspectorView):
613         (DumpRenderTreeChrome::initialize):
614         (DumpRenderTreeChrome::onDownloadRequest):
615         * EWebLauncher/CMakeLists.txt:
616         * EWebLauncher/main.c:
617         (findThemePath):
618         * EWebLauncher/url_bar.c:
619         (url_bar_add):
620         * MiniBrowser/efl/CMakeLists.txt:
621         * MiniBrowser/efl/main.c:
622         (window_create):
623         * TestWebKitAPI/PlatformEfl.cmake:
624         * TestWebKitAPI/efl/PlatformWebView.cpp:
625         (TestWebKitAPI::PlatformWebView::PlatformWebView):
626         * WebKitTestRunner/PlatformEfl.cmake:
627         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
628         (WTR::PlatformWebView::PlatformWebView):
629
630 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
631
632         [GTK][AC] upversion of clutter and its dependecy
633         https://bugs.webkit.org/show_bug.cgi?id=114016
634
635         Reviewed by Gustavo Noronha Silva.
636
637         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
638
639         * gtk/jhbuild-optional.modules:
640
641 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
642
643         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
644         https://bugs.webkit.org/show_bug.cgi?id=89875
645
646         Reviewed by Maciej Stachowiak.
647
648         Add unit tests to verify if the handling of the open, openat, creat syscall
649         is being done right. We check if the Read/Write/ReadAndWrite permissions
650         are respected, if the canonical path is being resolved and if
651         the permissions are falling back to the topmost parent directory with a
652         policy set when the directory being opened has no policy.
653
654         We also test if any attempt of blocking SIGSYS is silently ignored.
655         SIGSYS cannot be blocked because in it's handler is where we hook
656         syscalls to the broker process.
657
658         Also added libseccomp to EFL's jhbuild to make the life of developers
659         willing to help easier.
660
661         * Scripts/webkitperl/FeatureList.pm:
662         * TestWebKitAPI/PlatformEfl.cmake:
663         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
664         (TestWebKitAPI):
665         (SeccompEnvironment):
666         (TestWebKitAPI::SeccompEnvironment::SetUp):
667         (TestWebKitAPI::SeccompEnvironment::TearDown):
668         (TestWebKitAPI::dummyHandler):
669         (TestWebKitAPI::TEST):
670         (TestWebKitAPI::stressTest):
671         * efl/jhbuild.modules:
672         * qmake/mkspecs/features/features.pri:
673
674 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
675
676         REGRESSION: Autocorrection doesn't work in DumpRenderTree
677         https://bugs.webkit.org/show_bug.cgi?id=113846
678
679         Reviewed by Alexey Proskuryakov.
680
681         The problem was that we were replacing NSSpellCheck's dictionary with our own
682         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
683
684         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
685         and "would" respectively in DumpRenderTree.
686
687         * DumpRenderTree/mac/DumpRenderTree.mm:
688         (resetDefaultsToConsistentValues):
689
690 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
691
692         Remove the gyp files for Tools
693         https://bugs.webkit.org/show_bug.cgi?id=114248
694
695         Reviewed by Ryosuke Niwa.
696
697         * DumpRenderTree/DumpRenderTree.gyp: Removed.
698         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
699         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
700         * DumpRenderTree/DumpRenderTree.gypi: Removed.
701         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
702         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
703         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
704         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
705
706 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
707
708         WKR (new-commit-bot) is too slow
709         https://bugs.webkit.org/show_bug.cgi?id=110087
710
711         Reviewed by Geoffrey Garen.
712
713         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
714         Just run "svn log -r <revision>" instead to cut down the delay.
715
716         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
717
718         * Scripts/webkitpy/tool/commands/newcommitbot.py:
719         (NewCommitBot):
720         (NewCommitBot.next_work_item):
721         (NewCommitBot._is_empty_log):
722         (NewCommitBot._update_checkout):
723
724 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
725
726         Build fix. Can't remove appendCustomBuildFlags.
727
728         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
729         (appendCustomBuildFlags):
730
731 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
732
733         Remove Chromium builders from build.webkit.org
734         https://bugs.webkit.org/show_bug.cgi?id=113990
735
736         Reviewed by Benjamin Poulain.
737
738         Removed.
739
740         * BuildSlaveSupport/build.webkit.org-config/config.json:
741         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
742         (InstallGtkDependencies):
743         (RunUnitTests.start):
744         (RunWebKit2Tests.start):
745         (Factory.__init__):
746         (unitTestsSupported):
747         (TestFactory.__init__):
748         (BuildAndTestFactory.__init__):
749         (BuildAndPerfTestFactory.__init__):
750         (BuildAndPerfTestWebKit2Factory.__init__):
751         (DownloadAndPerfTestFactory.__init__):
752         (loadBuilderConfig):
753         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
754
755 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
756
757         Remove HTML Notification
758         https://bugs.webkit.org/show_bug.cgi?id=114231
759
760         Reviewed by Ryosuke Niwa.
761
762         * qmake/mkspecs/features/features.pri:
763
764 2013-04-08  Glenn Adams  <glenn@skynav.com>
765
766         Remove chromium EWS support, and fix broken test.
767         https://bugs.webkit.org/show_bug.cgi?id=114221
768
769         Reviewed by Ryosuke Niwa.
770
771         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
772         (AbstractChromiumEWS): Removed.
773         (ChromiumLinuxEWS): Removed.
774         (ChromiumLinuxDebugEWS): Removed.
775         (ChromiumWindowsEWS): Removed.
776         (ChromiumAndroidEWS): Removed.
777         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
778         (EarlyWarningSystemTest): Fix misspelled class name.
779         (test_ewses): Fix entry point name to ensure test is run.
780
781 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
782
783         [WIN] Remove WebKit2 source code
784         https://bugs.webkit.org/show_bug.cgi?id=114096
785
786         Reviewed by Anders Carlsson.
787
788         Remove the windows specific parts of the MiniBrowser.
789
790         * MiniBrowser/MiniBrowser.vcproj: Removed.
791         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
792         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
793         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
794         * MiniBrowser/win/BrowserView.cpp: Removed.
795         * MiniBrowser/win/BrowserView.h: Removed.
796         * MiniBrowser/win/BrowserWindow.cpp: Removed.
797         * MiniBrowser/win/BrowserWindow.h: Removed.
798         * MiniBrowser/win/MiniBrowser.cpp: Removed.
799         * MiniBrowser/win/MiniBrowser.h: Removed.
800         * MiniBrowser/win/MiniBrowser.rc: Removed.
801         * MiniBrowser/win/main.cpp: Removed.
802         * MiniBrowser/win/resource.h: Removed.
803         * MiniBrowser/win/stdafx.cpp: Removed.
804         * MiniBrowser/win/stdafx.h: Removed.
805
806 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
807
808         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
809
810         * Scripts/webkitpy/common/config/irc.py:
811
812 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
813
814         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
815         https://bugs.webkit.org/show_bug.cgi?id=113139
816
817         Reviewed by Anders Carlsson.
818
819         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
820         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
821         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
822         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
823         (ToStringAndValueOfObject):
824         (ToStringAndValueOfObject::ToStringAndValueOfObject):
825         (ScriptableObject):
826         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
827         (ToStringAndValueOfObject::ScriptableObject::invoke):
828         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
829         (ToStringAndValueOfObject::NPP_GetValue):
830         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
831         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
832         * GNUmakefile.am:
833
834 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
835
836         [GTK] Bump gnome-themes-standard to 3.6.0
837         https://bugs.webkit.org/show_bug.cgi?id=114155
838
839         Reviewed by Martin Robinson.
840
841         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
842         dependency of gnome-themes-standard accordingly.
843
844 2013-04-08  David Levin  <levin@chromium.org>
845
846         Remove my watchlist entries.
847         https://bugs.webkit.org/show_bug.cgi?id=114180
848
849         Reviewed by Adam Barth.
850
851         * Scripts/webkitpy/common/config/committers.py:
852         * Scripts/webkitpy/common/config/watchlist:
853
854 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
855
856         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
857         https://bugs.webkit.org/show_bug.cgi?id=114161
858
859         Reviewed by Gyuyoung Kim.
860
861         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
862         as it is crashing due to Bug 111074.
863
864         * TestWebKitAPI/PlatformEfl.cmake:
865
866 2013-04-07  David Kilzer  <ddkilzer@apple.com>
867
868         Remove the rest of SVG_DOM_OBJC_BINDINGS
869         <http://webkit.org/b/114112>
870
871         Reviewed by Geoffrey Garen.
872
873         * Scripts/webkitperl/FeatureList.pm:
874         - Remove --svg-dom-objc-bindings switch.
875         * qmake/mkspecs/features/features.pri:
876         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
877
878 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
879
880         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
881         https://bugs.webkit.org/show_bug.cgi?id=114089
882
883         Reviewed by Chris Fleizach.
884
885         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
886         * DumpRenderTree/AccessibilityController.cpp:
887         * DumpRenderTree/AccessibilityUIElement.cpp:
888         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
889         (DumpRenderTreeChrome::DumpRenderTreeChrome):
890         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
891         (DumpRenderTreeChrome):
892
893 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
894
895         Build fix after r147857, remove remaining USE(JSC) guards.
896
897         Unreviewed.
898
899         * DumpRenderTree/config.h:
900         * TestWebKitAPI/config.h:
901         * WebKitTestRunner/config.h:
902
903 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
904
905         Rename sheriffbot to webkitbot
906         https://bugs.webkit.org/show_bug.cgi?id=114109
907
908         Reviewed by Benjamin Poulain.
909
910         Renamed since sheriffbot will be used in Blink.
911
912         * Scripts/webkitpy/tool/commands/sheriffbot.py:
913         (SheriffBot):
914         (SheriffBot.begin_work_queue):
915
916 2013-04-06  Oliver Hunt  <oliver@apple.com>
917
918         Unify the many and varied stack trace mechanisms, and make the result sane.
919         https://bugs.webkit.org/show_bug.cgi?id=114072
920
921         Reviewed by Filip Pizlo.
922
923         The commandline jsc executable no longer requires arguments, so
924         I've made run-jsc work without them.
925
926         * Scripts/run-jsc:
927
928 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
929
930         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
931         https://bugs.webkit.org/show_bug.cgi?id=114086
932
933         Reviewed by Tim Horton.
934
935         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
936
937 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
938
939         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
940         https://bugs.webkit.org/show_bug.cgi?id=114083
941
942         Reviewed by Ryosuke Niwa.
943
944         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
945         in TestWebKitAPI and WebKitTestRunner.
946
947         * TestWebKitAPI/config.h:
948         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
949         (TestWebKitAPI::InjectedBundleController::platformInitialize):
950         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
951         (WTR::InjectedBundle::platformInitialize):
952
953 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
954
955         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
956         https://bugs.webkit.org/show_bug.cgi?id=114094
957
958         Reviewed by Anders Carlsson.
959
960         * Scripts/run-jsc:
961
962 2013-04-05  Ojan Vafai  <ojan@chromium.org>
963
964         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
965         https://bugs.webkit.org/show_bug.cgi?id=114080
966
967         Reviewed by Ryosuke Niwa.
968
969         This way, the WebKit and Blink dashboard code can change as appropriate without
970         needing to consider the other project's needs. This still doesn't update the
971         buildbots to upload to the new location, or the dashboard code to pull the
972         results.json files from the new location, but it at least allows for changing the
973         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
974
975         * TestResultServer/app.yaml:
976
977 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
978
979         Re-enable testing on the commit queue
980         https://bugs.webkit.org/show_bug.cgi?id=114078
981
982         Reviewed by Darin Adler.
983
984         Re-enabled the feature and the associated tests.
985
986         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
987         (CommitQueueTask.run):
988         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
989         (CommitQueueTaskTest._run_through_task):
990         * Scripts/webkitpy/tool/commands/queues_unittest.py:
991         (CommitQueueTest._mock_test_result):
992
993 2013-04-05  Oliver Hunt  <oliver@apple.com>
994
995         Unify the many and varied stack trace mechanisms, and make the result sane.
996         https://bugs.webkit.org/show_bug.cgi?id=114072
997
998         Reviewed by Filip Pizlo.
999
1000         The commandline jsc executable no longer requires arguments, so
1001         I've made run-jsc work without them.
1002
1003         * Scripts/run-jsc:
1004
1005 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1006
1007         AX: Make SVG Group containers accessible elements
1008         https://bugs.webkit.org/show_bug.cgi?id=113939
1009
1010         Reviewed by Simon Fraser.
1011
1012         Implement axController.elementAtPoint for iOS.
1013         Implement a correct version of clickPoint for iOS.
1014
1015         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1016         (AccessibilityController::elementAtPoint):
1017         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1018         (AccessibilityUIElement::clickPointX):
1019         (AccessibilityUIElement::clickPointY):
1020
1021 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1022
1023         Unreviewed, rolling out r147773 and r147774.
1024         http://trac.webkit.org/changeset/147773
1025         http://trac.webkit.org/changeset/147774
1026         https://bugs.webkit.org/show_bug.cgi?id=114056
1027
1028         Causing some exceptions on AppEngine I don't understand
1029         (Requested by rniwa on #webkit).
1030
1031         * QueueStatusServer/config/queues.py:
1032         * QueueStatusServer/model/queues.py:
1033         (Queue.short_name):
1034         (Queue.display_name):
1035         * QueueStatusServer/model/queues_unittest.py:
1036         (QueueTest.test_short_name):
1037         (QueueTest.test_display_name):
1038         (QueueTest.test_name_with_underscores):
1039
1040 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
1041
1042         Fixed run-bindings-tests by removing V8
1043         https://bugs.webkit.org/show_bug.cgi?id=114053
1044
1045         Reviewed by Benjamin Poulain.
1046
1047         * Scripts/run-bindings-tests:
1048         (main):
1049
1050 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1051
1052         Build fix.
1053
1054         * QueueStatusServer/model/queues.py:
1055         (Queue.short_name):
1056         (Queue.display_name):
1057
1058 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1059
1060         Remove Chromium EWS bots from the queue status server
1061         https://bugs.webkit.org/show_bug.cgi?id=113988
1062
1063         Reviewed by Benjamin Poulain.
1064
1065         Removed Chromium EWS bots.
1066
1067         * QueueStatusServer/config/queues.py:
1068         * QueueStatusServer/model/queues.py:
1069         (Queue.short_name):
1070         (Queue.display_name):
1071         * QueueStatusServer/model/queues_unittest.py:
1072         (QueueTest.test_short_name):
1073         (QueueTest.test_display_name):
1074         (QueueTest.test_name_with_underscores):
1075
1076 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1077
1078         [EFL] Enable indexed database
1079         https://bugs.webkit.org/show_bug.cgi?id=107248
1080
1081         Reviewed by Alexis Menard.
1082
1083         * Scripts/webkitperl/FeatureList.pm:
1084
1085 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
1086
1087         Remove vestiges of Chromium bits from watchlists.
1088         https://bugs.webkit.org/show_bug.cgi?id=114047
1089
1090         Reviewed by Ryosuke Niwa.
1091
1092         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
1093
1094 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1095
1096         Add James Craig to the contributors list.
1097
1098         * Scripts/webkitpy/common/config/committers.py:
1099
1100 2013-04-04  Kent Tamura  <tkent@chromium.org>
1101
1102         Remove ChromiumPublicApi pattern, and cc/message rules for it.
1103
1104         * Scripts/webkitpy/common/config/watchlist:
1105
1106 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1107
1108         Temporarily disable the Python unittests broken by the commit queue not running layout tests
1109         https://bugs.webkit.org/show_bug.cgi?id=113997
1110
1111         Reviewed by Ryosuke Niwa.
1112
1113         Disable the tests until Ryosuke gets the time and hardware to have
1114         a testing commit-queue.
1115
1116         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1117         (CommitQueueTaskTest):
1118         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1119         (CommitQueueTest):
1120
1121 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1122
1123         Remove Chromium builders from build.webkit.org
1124         https://bugs.webkit.org/show_bug.cgi?id=113990
1125
1126         Reviewed by Benjamin Poulain.
1127
1128         Land the part to disable triggering of Chromium builders first so that we may start
1129         deleting more Chromium code that breaks the update step.
1130
1131         * BuildSlaveSupport/build.webkit.org-config/config.json:
1132
1133 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1134
1135         Remove Chromium's DumpRenderTree
1136         https://bugs.webkit.org/show_bug.cgi?id=113989
1137
1138         Reviewed by Kent Tamura.
1139
1140         On second thought, let's not go to Camelot. It is a silly place.
1141
1142         * DumpRenderTree/mac/DumpRenderTree.mm:
1143         (resetDefaultsToConsistentValues):
1144
1145 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1146
1147         Nixed the defunct chromium folder from DumpRenderTree
1148         https://bugs.webkit.org/show_bug.cgi?id=113993
1149
1150         Reviewed by Ryosuke Niwa.
1151
1152         * DumpRenderTree/chromium: Removed.
1153         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1154         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1155         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1156         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1157         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1158         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1159         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1160         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1161         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1162         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1163         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1164         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1165         * DumpRenderTree/chromium/Task.cpp: Removed.
1166         * DumpRenderTree/chromium/Task.h: Removed.
1167         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1168         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1169         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1170         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1171         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1172         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1173         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1174         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1175         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1176         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1177         * DumpRenderTree/chromium/TestRunner: Removed.
1178         * DumpRenderTree/chromium/TestRunner/public: Removed.
1179         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1180         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1181         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1182         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1183         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1184         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1185         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1186         * DumpRenderTree/chromium/TestRunner/src: Removed.
1187         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1188         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1189         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1190         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1191         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1192         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1193         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1194         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1195         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1196         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1197         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1198         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1199         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1200         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1201         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1202         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1203         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1204         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
1205         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
1206         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
1207         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
1208         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
1209         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
1210         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1211         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1212         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1213         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1214         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1215         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1216         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1217         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1218         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1219         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1220         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1221         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1222         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1223         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1224         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1225         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1226         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1227         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1228         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1229         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1230         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1231         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1232         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1233         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1234         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1235         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1236         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1237         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1238         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1239         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1240         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1241         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1242         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1243         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1244         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1245         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1246         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1247         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1248         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1249         * DumpRenderTree/chromium/TestShell.h: Removed.
1250         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1251         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1252         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1253         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1254         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1255         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1256         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1257         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1258         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1259         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1260         * DumpRenderTree/chromium/config.h: Removed.
1261         * DumpRenderTree/chromium/fonts.conf: Removed.
1262
1263 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1264
1265         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1266
1267         Rubber stamped by Benjamin Poulain.
1268
1269         * RebaselineQueueServer: Removed.
1270         * RebaselineQueueServer/app.yaml: Removed.
1271         * RebaselineQueueServer/handlers: Removed.
1272         * RebaselineQueueServer/handlers/__init__.py: Removed.
1273         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1274         * RebaselineQueueServer/handlers/pages.py: Removed.
1275         * RebaselineQueueServer/index.yaml: Removed.
1276         * RebaselineQueueServer/main.py: Removed.
1277         * RebaselineQueueServer/model: Removed.
1278         * RebaselineQueueServer/model/__init__.py: Removed.
1279         * RebaselineQueueServer/model/queueentry.py: Removed.
1280         * RebaselineQueueServer/static: Removed.
1281         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1282         * RebaselineQueueServer/static/styles.css: Removed.
1283         * RebaselineQueueServer/templates: Removed.
1284         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1285         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1286         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1287         * RebaselineQueueServer/templates/home.html: Removed.
1288
1289 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1290
1291         Fix setup-commit-queue and temporarily disable testing on commit-queue
1292         https://bugs.webkit.org/show_bug.cgi?id=113979
1293
1294         Reviewed by Benjamin Poulain.
1295
1296         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1297         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1298
1299         * EWSTools/setup-commit-queue.sh:
1300         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1301         (CommitQueueTask.run):
1302
1303 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1304
1305         temporarily make flakiness dashboard work again webkit.org bots
1306         https://bugs.webkit.org/show_bug.cgi?id=113972
1307
1308         Reviewed by Ojan Vafai.
1309
1310         This patch disables the chromium.org layout test bots TestExpectations
1311         parsing temporarily until we can work out the right way to split into
1312         two instances for webkit.org and chromium.org and figure out which
1313         code to delete where :).
1314
1315         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1316
1317 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1318
1319         Fix webkitpy tests after r147678.
1320
1321         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1322         (CommitQueueTest.test_commit_queue):
1323         (test_manual_reject_during_processing):
1324
1325 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1326
1327         The commit queue should use Mac MountainLion port
1328         https://bugs.webkit.org/show_bug.cgi?id=113971
1329
1330         Reviewed by Lucas Forschler.
1331
1332         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1333         * Scripts/webkitpy/tool/commands/queues.py:
1334         (CommitQueue):
1335
1336 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1337
1338         turn off running tests on chromium linux EWS bots
1339         https://bugs.webkit.org/show_bug.cgi?id=113959
1340
1341         Reviewed by Geoffrey Garen.
1342
1343         Now that the Chromium port is no longer being maintained
1344         there's little point in running the tests. Soon we should
1345         just shut this bot off altogether.
1346
1347         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1348         (ChromiumLinuxEWS):
1349
1350 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1351
1352         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1353
1354         * Scripts/webkitpy/common/config/watchlist:
1355
1356 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1357
1358         Indentation fix to get webkit-patch working again after r147625
1359
1360         Unreviewed.
1361
1362         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1363         (MacEWS):
1364         (MacWK2EWS):
1365
1366 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1367
1368         Turn tests back on for Mac WK1/WK2 EWS.
1369         
1370         Unreviewed.
1371         
1372         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1373         (MacEWS):
1374         (MacWK2EWS):
1375
1376 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1377
1378         [GTK][WK2] MiniBrowser custom URI scheme support
1379         https://bugs.webkit.org/show_bug.cgi?id=112419
1380
1381         Reviewed by Carlos Garcia Campos.
1382
1383         Add support for about URIs in MiniBrowser. An example about page is show
1384         with URI "about:minibrowser", the rest of the cases it will show a
1385         proper message explaining that the about page didn't exist.
1386
1387         Internally it uses "minibrowser-about" prefix instead of "about", but
1388         from the user point of view it works with "about" prefix.
1389
1390         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1391         (getInternalURI): Method to convert URIs from "about" prefix to
1392         "minibrowser-about".
1393         (getExternalURI): Opposite method.
1394         (webViewURIChanged): Use "about" prefix to show the URI to users.
1395         (webViewEnterFullScreen): Ditto.
1396         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1397         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1398         (aboutURISchemeRequestCallback): Callback to manage about calls.
1399         (main): Register the URI scheme to manage about URIs.
1400
1401 2013-04-03  Roger Fong  <roger_fong@apple.com>
1402
1403         Re-enable WinEWS tests.
1404
1405         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1406         (WinEWS):
1407
1408 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1409
1410         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1411         https://bugs.webkit.org/show_bug.cgi?id=113883
1412
1413         Reviewed by Martin Robinson.
1414
1415         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1416         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1417         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1418
1419 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1420
1421         [GTK] Include Pango in jhbuild-optional.modules
1422         https://bugs.webkit.org/show_bug.cgi?id=113878
1423
1424         Reviewed by Martin Robinson.
1425
1426         Since r147547 Pango 1.32.0 is required. Including the module in the
1427         JHBuild optional moduleset.
1428
1429         * gtk/jhbuild-optional.modules: Add Pango module.
1430
1431 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1432
1433         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1434         https://bugs.webkit.org/show_bug.cgi?id=113864
1435
1436         Moving setDefersLoading from TestRunnerQt to TestRunner
1437         requires access to the non-Qt TestRunner.
1438         As long as we instantiate both TestRunner and TestRunnerQt,
1439         we need a separate getter for the non-Qt TestRunner instance.
1440
1441         Reviewed by Simon Hausmann.
1442
1443         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1444         (WebPage::resetSettings):
1445         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1446         (DumpRenderTree::jscTestRunner):
1447         * DumpRenderTree/qt/TestRunnerQt.cpp:
1448         (TestRunner::setDefersLoading):
1449             Moving setDefersLoading from TestRunnerQt
1450             to TestRunner.
1451         * DumpRenderTree/qt/TestRunnerQt.h:
1452         (TestRunnerQt):
1453
1454 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1455
1456         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1457         https://bugs.webkit.org/show_bug.cgi?id=104779
1458
1459         Reviewed by Carlos Garcia Campos.
1460
1461         * Scripts/run-gtk-tests:
1462         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1463         passing in current trunk.
1464
1465 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1466
1467         Fix HAVE(QTTESTSUPPORT) logic
1468
1469         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1470         resulting in HAVE(QTTESTSUPPORT) never being true.
1471         Move that logic down in sanitizeFeatures.
1472
1473         Rubber-stamped by Tor Arne Vestbø.
1474
1475         * qmake/mkspecs/features/features.prf:
1476
1477 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1478
1479         [GTK] Bump required versions of some dependencies
1480         https://bugs.webkit.org/show_bug.cgi?id=113282
1481
1482         Reviewed by Martin Robinson.
1483
1484         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1485
1486 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1487
1488         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1489         https://bugs.webkit.org/show_bug.cgi?id=113809
1490
1491         Reviewed by Philippe Normand.
1492
1493         Newer Linux kernels have removed some deprecated macros from v4l2
1494         headers, causing gst-plugins-good's build to break. We don't need it
1495         right now, so just disable it.
1496
1497         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1498
1499 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1500
1501         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1502         https://bugs.webkit.org/show_bug.cgi?id=113535
1503
1504         Reviewed by Simon Hausmann.
1505
1506         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1507
1508         * qmake/mkspecs/features/features.prf:
1509
1510 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1511
1512         [Qt] Move logic of simple forwarding functions to TestRunner.
1513         https://bugs.webkit.org/show_bug.cgi?id=113863
1514
1515         Reviewed by Simon Hausmann.
1516
1517         * DumpRenderTree/qt/TestRunnerQt.cpp:
1518         (TestRunner::setTextDirection):
1519         (TestRunner::goBack):
1520         (TestRunner::evaluateScriptInIsolatedWorld):
1521         (TestRunner::addUserStyleSheet):
1522         * DumpRenderTree/qt/TestRunnerQt.h:
1523         (TestRunnerQt):
1524
1525 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1526
1527         [Qt] Disable media support using QuickTime if deployment target != SDK
1528
1529         We link to a single libWebKitSystemInterface static lib, so unless the
1530         deployment target matches the SDK let's not pretend like we'll be able
1531         to run on anything lower than the SDK version.
1532
1533         Reviewed by Simon Hausmann.
1534
1535         * qmake/mkspecs/features/features.prf:
1536
1537 2013-04-02  James Craig  <james@cookiecrook.com>
1538
1539         AXRoleDescripton for DL is "list"; should be "description list"
1540         https://bugs.webkit.org/show_bug.cgi?id=111665
1541
1542         Reviewed by Chris Fleizach.
1543
1544         Defining the role and description strings.
1545
1546         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1547
1548 2013-04-02  Roger Fong  <roger_fong@apple.com>
1549
1550         Unreviewed. Disable running tests on Win EWS queue.
1551
1552         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1553         (WinEWS):
1554
1555 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1556
1557         Disable running tests on the MAC WK2 EWS queue.
1558         
1559         Unreviewed.
1560         
1561         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1562         (MacWK2EWS):
1563
1564 2013-04-02  Julie Parent  <jparent@chromium.org>
1565
1566         Dashboard refactor: Move dashboard specific history related features to History.
1567         https://bugs.webkit.org/show_bug.cgi?id=113717
1568
1569         Reviewed by Ojan Vafai.
1570         
1571         Each dashboard now creates its own History object, with a custom
1572         configuration. This changes from just overriding global functions
1573         to passing in callbacks for generatePage, handleValidHashParameter,
1574         and handleQueryParameterChange. Same with passing in defaultStateValues
1575         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1576         variables.
1577         
1578         All functions related to these features are now (mostly) private
1579         function on History. 
1580         
1581         Loader no longer needs a loadingComplete callback, since it can just
1582         initialize the history object itself.
1583
1584         * TestResultServer/static-dashboards/aggregate_results.js:
1585         (handleValidHashParameter):
1586         * TestResultServer/static-dashboards/dashboard_base.js:
1587         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1588         (generatePage):
1589         (.switch.return):
1590         (handleQueryParameterChange):
1591         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1592         (resetGlobals):
1593         * TestResultServer/static-dashboards/history.js:
1594         (.):
1595         * TestResultServer/static-dashboards/loader.js:
1596         (.):
1597         * TestResultServer/static-dashboards/loader_unittests.js:
1598         * TestResultServer/static-dashboards/timeline_explorer.js:
1599         (generatePage):
1600         (initCurrentBuilderTestResults):
1601         * TestResultServer/static-dashboards/treemap.js:
1602         (generatePage):
1603         (.switch.return):
1604         (handleQueryParameterChange):
1605
1606 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1607
1608         Unreviewed, rolling out r147401.
1609         http://trac.webkit.org/changeset/147401
1610         https://bugs.webkit.org/show_bug.cgi?id=113767
1611
1612         The patch makes it extremely hard to set up the dependencies
1613         properly on the GTK builders (Requested by zdobersek on
1614         #webkit).
1615
1616         * gtk/jhbuild.modules:
1617
1618 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1619
1620         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1621         https://bugs.webkit.org/show_bug.cgi?id=113382
1622
1623         Reviewed by Gyuyoung Kim.
1624
1625         Do not show the empty tooltip box if the text is null.
1626
1627         * MiniBrowser/efl/main.c:
1628         (popup_menu_populate):
1629
1630 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1631
1632         [GTK] Bump required versions of some dependencies
1633         https://bugs.webkit.org/show_bug.cgi?id=113282
1634
1635         Reviewed by Martin Robinson.
1636
1637         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1638
1639 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1640
1641         Unreviewed, rolling out r147319.
1642         http://trac.webkit.org/changeset/147319
1643         https://bugs.webkit.org/show_bug.cgi?id=113707
1644
1645         The unit test is still failing on the buildbot (Requested by
1646         zdobersek on #webkit).
1647
1648         * Scripts/run-gtk-tests:
1649         (TestRunner):
1650
1651 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1652
1653         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1654         https://bugs.webkit.org/show_bug.cgi?id=104779
1655
1656         Reviewed by Carlos Garcia Campos.
1657
1658         * Scripts/run-gtk-tests:
1659         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1660         passing in current trunk.
1661
1662 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1663
1664         Unreviewed, rolling out r147289.
1665         http://trac.webkit.org/changeset/147289
1666         https://bugs.webkit.org/show_bug.cgi?id=113678
1667
1668         broke Win7 (dbg) build (Requested by shinyak|gardener on
1669         #webkit).
1670
1671         * DumpRenderTree/DumpRenderTree.gypi:
1672         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1673         (WebTestRunner):
1674         (WebUserMediaClientMock):
1675         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1676         (WebTestRunner::WebUserMediaClientMock::taskList):
1677         * Scripts/webkitpy/style/checkers/cpp.py:
1678         (check_function_definition):
1679
1680 2013-03-31  Adam Barth  <abarth@webkit.org>
1681
1682         configure-svn-config.sh fails
1683         https://codereview.chromium.org/13392007/
1684
1685         Reviewed by Eric Seidel.
1686
1687         This script was trying to use "svn checkout" to dowload a file from
1688         svn.webkit.org, but "svn checkout" only works with directories.
1689         Instead, we should use "svn export".
1690
1691         * EWSTools/configure-svn-config.sh:
1692
1693 2013-03-31  Wei Jia  <wjia@chromium.org>
1694
1695         Allow WebUserMediaClientMock to be used by client
1696         https://bugs.webkit.org/show_bug.cgi?id=113633
1697
1698         Reviewed by Adam Barth.
1699
1700         Export WebUserMediaClientMock.
1701         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1702
1703         * DumpRenderTree/DumpRenderTree.gypi:
1704         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1705         (WebUserMediaClientMock):
1706         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1707         * Scripts/webkitpy/style/checkers/cpp.py:
1708         (check_function_definition):
1709
1710 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1711
1712         Expose FeatureObserver data to WebKit clients
1713         https://bugs.webkit.org/show_bug.cgi?id=113613
1714
1715         Reviewed by Sam Weinig.
1716
1717         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1718         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1719
1720 2013-03-29  Greg Hughes  <ghughes@apple.com>
1721
1722         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1723         https://bugs.webkit.org/show_bug.cgi?id=112276
1724
1725         Reviewed by Chris Fleizach.
1726
1727         Added support to test accessibility search predicates with multiple keys.  
1728
1729         * DumpRenderTree/AccessibilityUIElement.cpp:
1730         (uiElementForSearchPredicateCallback):
1731         * DumpRenderTree/AccessibilityUIElement.h:
1732         (AccessibilityUIElement):
1733         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1734         (AccessibilityUIElement::uiElementForSearchPredicate):
1735         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1736         (AccessibilityUIElement::uiElementForSearchPredicate):
1737         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1738         (AccessibilityUIElement::uiElementForSearchPredicate):
1739         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1740         (AccessibilityUIElement::uiElementForSearchPredicate):
1741         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1742         (AccessibilityUIElement::uiElementForSearchPredicate):
1743         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1744         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1745         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1746         (AccessibilityUIElement):
1747         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1748         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1749         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1750         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1751         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1752
1753 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1754
1755         Fix a typo in r147147 to fix Mac EWS.
1756
1757         * Scripts/webkitpy/tool/commands/queues.py:
1758         (PatchProcessingQueue._new_port_name_from_old):
1759
1760 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1761
1762         [EFL] Build break with latest EFL libraries after r146265
1763         https://bugs.webkit.org/show_bug.cgi?id=113558
1764
1765         Unreviewed build fix.
1766
1767         * TestWebKitAPI/PlatformWebView.h:
1768         * WebKitTestRunner/PlatformWebView.h:
1769
1770 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1771
1772         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1773
1774         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1775         in libgcrypt build.
1776
1777 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1778
1779         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1780
1781         Unreviewed.
1782
1783         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1784         (MacEWS):
1785
1786 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1787
1788         Use the right OS name on Mac EWS instead of mac-future.
1789
1790         Rubber-stamped by Dirk Pranke.
1791
1792         * Scripts/webkitpy/tool/commands/queues.py:
1793         (PatchProcessingQueue._new_port_name_from_old):
1794         (PatchProcessingQueue.begin_work_queue):
1795         (PatchProcessingQueue._upload_results_archive_for_patch):
1796
1797 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1798
1799         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1800         https://bugs.webkit.org/show_bug.cgi?id=112546
1801
1802         Reviewed by Martin Robinson.
1803
1804         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1805         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1806
1807 2013-03-28  Ming Xie  <mxie@blackberry.com>
1808
1809         [BlackBerry] Committer Email Updates
1810         https://bugs.webkit.org/show_bug.cgi?id=113435
1811
1812         Reviewed by Rob Buis.
1813
1814         Add the @blackberry.com email address for all our BlackBerry
1815         WebKit committers. This is the first step for our email address
1816         migration.
1817
1818         * Scripts/webkitpy/common/config/committers.py:
1819
1820 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1821
1822         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1823         https://bugs.webkit.org/show_bug.cgi?id=113508
1824
1825         Reviewed by Martin Robinson.
1826
1827         Prevent the GStreamer plugin scanner to load system-wide
1828         plugins. Only the ones built in JHBuild should be loaded and used
1829         at runtime.
1830
1831         * efl/jhbuildrc:
1832         * gtk/jhbuildrc:
1833
1834 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1835
1836         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1837         https://bugs.webkit.org/show_bug.cgi?id=113386
1838
1839         Reviewed by Carlos Garcia Campos.
1840
1841         * Scripts/webkitdirs.pm:
1842         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1843         version to 3.0. Reflect this change so the builtDylibPathForName
1844         function doesn't fail to report the library as found.
1845
1846 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1847
1848         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1849         https://bugs.webkit.org/show_bug.cgi?id=113484
1850
1851         Unreviewed build fix.
1852
1853         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1854
1855         * TestWebKitAPI/CMakeLists.txt:
1856         * WebKitTestRunner/CMakeLists.txt:
1857
1858 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1859
1860         Revision for the internal jhbuild is too old
1861         https://bugs.webkit.org/show_bug.cgi?id=113324
1862
1863         Reviewed by Martin Robinson.
1864
1865         Update the minimum required version to a point where jhbuild won't
1866         fail installing packages when trying to remove a symlink to a directory.
1867
1868         * jhbuild/jhbuild-wrapper: Updated revision.
1869
1870 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1871
1872         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1873         https://bugs.webkit.org/show_bug.cgi?id=113203
1874
1875         Reviewed by Philippe Normand.
1876
1877         We build our libsoup without GNOME support. gst-plugins-good does separate
1878         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1879         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1880         build failures as the headers of those diverge. We do not use souphttpsrc, so
1881         disable it when building gst-plugins-good.
1882
1883         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1884
1885 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1886
1887         Build fix after r146852. Please another reference to the Lion leaks builder.
1888
1889         * BuildSlaveSupport/build.webkit.org-config/config.json:
1890
1891 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1892
1893         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1894         https://bugs.webkit.org/show_bug.cgi?id=113421
1895
1896         Reviewed by Dirk Pranke.
1897
1898         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1899         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1900         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1901         in the GTK-specific TestExpectations files.
1902
1903         To avoid this only enable the warnings only when not using WKTR.
1904
1905         * Scripts/webkitpy/layout_tests/port/gtk.py:
1906         (GtkPort.warn_if_bug_missing_in_test_expectations):
1907
1908 2013-03-27  Antti Koivisto  <antti@apple.com>
1909
1910         Fix Zalan's email.
1911
1912         * Scripts/webkitpy/common/config/committers.py:
1913
1914 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1915
1916         master.cfg cleanup
1917         https://bugs.webkit.org/show_bug.cgi?id=113195
1918
1919         Reviewed by Ryosuke Niwa.
1920
1921         * BuildSlaveSupport/build.webkit.org-config/config.json:
1922         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1923
1924 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1925
1926         master.cfg fine-tuning for Qt Mountain Lion Release bot
1927         https://bugs.webkit.org/show_bug.cgi?id=113191
1928
1929         Reviewed by Ryosuke Niwa.
1930
1931         * BuildSlaveSupport/build.webkit.org-config/config.json:
1932           - Rename the slave due to its location change.
1933           - Update the platform of the slave.
1934         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1935         (RunQtAPITests): Enable running WK2 API tests on Qt.
1936         (RunQtAPITests.start):
1937         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1938         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1939
1940 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1941
1942         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1943         https://bugs.webkit.org/show_bug.cgi?id=113403
1944
1945         Reviewed by Kenneth Rohde Christiansen.
1946
1947         As of Evas 1.7.5, when Wayland is detected on the system, support for
1948         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1949         The code, however, seems to depend on a few other flags which must be
1950         explicitly enabled.
1951
1952         If those additional GL-related options are passed, we end up
1953         having issues on the WebKit side, so disable Wayland support for
1954         now.
1955
1956         * efl/jhbuild.modules:
1957
1958 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1959
1960         Unreviewed, rolling out r146864.
1961         http://trac.webkit.org/changeset/146864
1962         https://bugs.webkit.org/show_bug.cgi?id=113391
1963
1964         causes crashes on Wk2 EFL release bot (Requested by drott on
1965         #webkit).
1966
1967         * Scripts/webkitperl/FeatureList.pm:
1968
1969 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1970
1971         [jhbuild] Correctly specify an alternate number of make jobs.
1972         https://bugs.webkit.org/show_bug.cgi?id=113396
1973
1974         Reviewed by Philippe Normand.
1975
1976         So far, we were using the `MAKEFLAGS' environment variable to pass the
1977         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1978         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1979
1980         We now behave more closely to the rest of the WebKit tools by first
1981         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1982         not set, just letting jhbuild itself figure out how many jobs to use.
1983
1984         * efl/jhbuildrc:
1985         * gtk/jhbuildrc:
1986
1987 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1988
1989         [Qt] Remove Qt specific WorkQueueItem definitions.
1990         https://bugs.webkit.org/show_bug.cgi?id=112891
1991
1992         This patch is preparation work for removing
1993         WorkQueue related code from TestRunnerQt and
1994         replacing it with generic TestRunner code.
1995
1996         Reviewed by Benjamin Poulain.
1997
1998         * DumpRenderTree/qt/TestRunnerQt.cpp:
1999         (TestRunnerQt::queueBackNavigation):
2000         (TestRunnerQt::queueForwardNavigation):
2001         (TestRunnerQt::queueLoadHTMLString):
2002         (TestRunnerQt::queueReload):
2003         (TestRunnerQt::queueLoadingScript):
2004         (TestRunnerQt::queueNonLoadingScript):
2005         (TestRunner::queueLoad):
2006         * DumpRenderTree/qt/TestRunnerQt.h:
2007         (TestRunnerQt):
2008         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2009         (LoadItem::invoke):
2010         (LoadHTMLStringItem::invoke):
2011         (LoadAlternateHTMLStringItem::invoke):
2012         (ReloadItem::invoke):
2013         (ScriptItem::invoke):
2014         (BackForwardItem::invoke):
2015         * DumpRenderTree/qt/WorkQueueItemQt.h:
2016         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2017         (LoadAlternateHTMLStringItem):
2018
2019 2013-03-26  Julie Parent  <jparent@chromium.org>
2020
2021         Flakiness dashboard: simplify logic around which tests to show.
2022         https://bugs.webkit.org/show_bug.cgi?id=113250
2023
2024         Reviewed by Ojan Vafai.
2025         
2026         The different filters for showing results are only used for layout
2027         tests, otherwise, we show everything.
2028         
2029         Change the defaults to false (what layout tests used), and only
2030         look at the values when viewing layout tests.
2031
2032         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2033         (htmlForTestsWithExpectationsButNoFailures):
2034         (shouldHideTest):
2035
2036 2013-03-26  Isaac Levy  <ilevy@google.com>
2037
2038         Update bots on test-results.appspot
2039         https://bugs.webkit.org/show_bug.cgi?id=113333
2040
2041         Reviewed by Ojan Vafai.
2042
2043         * TestResultServer/static-dashboards/builders.jsonp:
2044
2045 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2046
2047         Unreviewed GTK gardening.
2048
2049         * Scripts/run-gtk-tests:
2050         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
2051
2052 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2053
2054         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
2055         https://bugs.webkit.org/show_bug.cgi?id=113287
2056
2057         Reviewed by Jocelyn Turcotte.
2058
2059         * Scripts/run-qtwebkit-tests:
2060         (Options.__init__):
2061
2062 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2063
2064         [EFL] Enable IndexedDB by default
2065         https://bugs.webkit.org/show_bug.cgi?id=107248
2066
2067         Reviewed by Laszlo Gombos.
2068
2069         * Scripts/webkitperl/FeatureList.pm:
2070         Enable IndexedDB by default on EFL.
2071
2072 2013-03-26  Alan Cutter  <alancutter@chromium.org>
2073
2074         Sheriffbot should explain rollout failures in a human readable form.
2075         https://bugs.webkit.org/show_bug.cgi?id=107092
2076
2077         Reviewed by Ryosuke Niwa.
2078
2079         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
2080
2081         * Scripts/webkitpy/tool/bot/irc_command.py:
2082         (Rollout._check_diff_failure):
2083         (Rollout.execute):
2084         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2085         (IRCCommandTest.test_rollout):
2086
2087 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2088
2089         Unreviewed GTK gardening.
2090
2091         * Scripts/run-gtk-tests:
2092         (TestRunner): Skipping a failing unit test after r146518.
2093
2094 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2095
2096         Remove Lion leaks builder
2097         https://bugs.webkit.org/show_bug.cgi?id=113252
2098
2099         Reviewed by Andreas Kling.
2100
2101         Removed.
2102
2103         * BuildSlaveSupport/build.webkit.org-config/config.json:
2104
2105 2013-03-25  Kent Tamura  <tkent@chromium.org>
2106
2107         Rename ENABLE_INPUT_TYPE_DATETIME
2108         https://bugs.webkit.org/show_bug.cgi?id=113254
2109
2110         Reviewed by Kentaro Hara.
2111
2112         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
2113         Actually I'd like to remove the code, but we shouldn't remove it yet
2114         because we shipped products with it on some platforms.
2115
2116         * Scripts/webkitperl/FeatureList.pm:
2117         * qmake/mkspecs/features/features.pri:
2118
2119 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2120
2121         Remove one more line that was intended to be removed in r146657.
2122
2123         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2124         (summarize_results):
2125
2126 2013-03-25  Roger Fong  <roger_fong@apple.com>
2127
2128         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2129         Re-enable WinEWS tests.
2130
2131         * Scripts/webkitpy/common/config/ports.py:
2132         (WinPort.run_bindings_tests_command):
2133         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2134         (WinEWS):
2135
2136 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2137
2138         Unreviewed, rolling out r146793.
2139         http://trac.webkit.org/changeset/146793
2140         https://bugs.webkit.org/show_bug.cgi?id=113248
2141
2142         Fix did not work (Requested by rfong on #webkit).
2143
2144         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2145         (WinEWS):
2146
2147 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2148
2149         REGRESSION(r146657): Test failures reported incorrectly
2150         https://bugs.webkit.org/show_bug.cgi?id=113223
2151
2152         Reviewed by Dirk Pranke.
2153
2154         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2155
2156         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2157         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2158
2159         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2160         (Manager.run):
2161
2162         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2163         (RunDetails.__init__):
2164         (summarize_results): Remove the line I intended to remove in r146657.
2165
2166         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2167         (logging_run): Return details instead of the exit code.
2168         (run_and_capture): Ditto.
2169
2170         (RunTest.test_full_results_html):
2171         (RunTest.test_hung_thread):
2172         (RunTest.test_no_tests_found):
2173         (RunTest.test_no_tests_found_2):
2174         (RunTest.test_repeat_each_iterations_num_tests):
2175         (RunTest.test_run_singly_actually_runs_tests):
2176         (RunTest.test_test_list):
2177         (RunTest.test_missing_and_unexpected_results):
2178         (RunTest.test_pixel_test_directories):
2179         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2180         (RunTest.test_crash_with_stderr):
2181         (RunTest.test_no_image_failure_with_image_diff):
2182         (RunTest.test_crash_log):
2183         (RunTest.test_exit_after_n_failures_upload):
2184         (RunTest.test_results_directory_absolute):
2185         (RunTest.test_results_directory_relative):
2186         (RunTest.test_retrying_and_flaky_tests):
2187         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2188         (RunTest.test_retrying_uses_retries_directory):
2189         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2190         (RunTest.test_output_diffs):
2191         (EndToEndTest.test_reftest_with_two_notrefs):
2192         (RebaselineTest.test_reset_results):
2193         (RebaselineTest.test_missing_results):
2194         (RebaselineTest.test_new_baseline):
2195
2196         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2197         (BuildBotPrinter.print_results):
2198         (BuildBotPrinter.print_unexpected_results):
2199         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2200         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2201
2202 2013-03-25  Julie Parent  <jparent@chromium.org>
2203
2204         Dashboard refactor: Move cross dashboard history related code into history.js.
2205         https://bugs.webkit.org/show_bug.cgi?id=113104
2206
2207         Reviewed by Ojan Vafai.
2208
2209         All functions relating to cross dashboard behavior move from being
2210         globals to methods on the history.History object. Names stay the same,
2211         except many are made private, ones that should have been constants now
2212         are, and the long standing TODO to change "currentState" to 
2213         dashboardSpecificState is done.
2214         
2215         We now create a global history object in dashboard_base, as an 
2216         intermediate measure.  Once the dashboard specific code is
2217         added to history, each DB will need to create its own, and this
2218         global will be eliminated.
2219         
2220         * TestResultServer/static-dashboards/aggregate_results.js:
2221         (handleValidHashParameter):
2222         (htmlForBuilder):
2223         (rawValuesHTML):
2224         * TestResultServer/static-dashboards/dashboard_base.js:
2225         (parseDashboardSpecificParameters):
2226         (defaultValue):
2227         (currentBuilderGroupCategory):
2228         (currentBuilderGroupName):
2229         (handleLocationChange):
2230         (expectationsMap):
2231         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2232         (generatePage):
2233         (.switch.return):
2234         (platformAndBuildType):
2235         (individualTests):
2236         (substringList):
2237         (processMissingAndExtraExpectations):
2238         (pathToFailureLog):
2239         (showPopupForBuild):
2240         (htmlForTestsWithExpectationsButNoFailures):
2241         (shouldHideTest):
2242         (isCrossBuilderView):
2243         (tableHeaders):
2244         (htmlForSingleTestRow):
2245         (htmlForTableColumnHeader):
2246         (generatePageForExpectationsUpdate):
2247         (handleUpdate):
2248         (nextUpdate):
2249         (setUpdateIndex):
2250         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2251         (.appendExpectationsItem):
2252         (loadExpectations):
2253         (.dummyNode.onload):
2254         (loadExpectationsLayoutTests):
2255         (appendExpectations):
2256         (htmlForNavBar):
2257         (checkBoxToToggleState):
2258         (linkHTMLToToggleState):
2259         (generatePageForBuilder):
2260         (isInvalidKeyForCrossBuilderView):
2261         (handleQueryParameterChange):
2262         (showLegend):
2263         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2264         (resetGlobals):
2265         (test):
2266         * TestResultServer/static-dashboards/history.js:
2267         (.):
2268         * TestResultServer/static-dashboards/history_unittests.js:
2269         * TestResultServer/static-dashboards/loader.js:
2270         (.):
2271         * TestResultServer/static-dashboards/loader_unittests.js:
2272         * TestResultServer/static-dashboards/timeline_explorer.js:
2273         (generatePage):
2274         (initCurrentBuilderTestResults):
2275         (selectBuild):
2276         (showResultsDelta):
2277         * TestResultServer/static-dashboards/treemap.js:
2278         (generatePage):
2279         (.switch.return):
2280         (handleFocus):
2281         * TestResultServer/static-dashboards/ui.js:
2282
2283 2013-03-25  Roger Fong  <roger_fong@apple.com>
2284
2285         Unreviewed. Enable WinEWS tests again.
2286
2287         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2288         (WinEWS):
2289
2290 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2291
2292         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2293         https://bugs.webkit.org/show_bug.cgi?id=112166
2294
2295         HarfBuzz 0.9.14 merged my patch for icu detection without
2296         pkg-config files, as needed by for example Ubuntu 12.04.
2297         This obsoletes our local workaround. Removed it for GTK and EFL.
2298
2299         Reviewed by Martin Robinson.
2300
2301         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2302         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2303         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2304         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2305
2306 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2307
2308         Unreviewed.  Move self from contributor to committer list.
2309
2310         * Scripts/webkitpy/common/config/committers.py:
2311
2312 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2313
2314         EWS should use a human readable port name when uploading layout test archives
2315         https://bugs.webkit.org/show_bug.cgi?id=113099
2316
2317         Reviewed by Dirk Pranke.
2318
2319         Use new port's object's name() method to report human readable port names.
2320         This will also help us resolving the bug to apply layout test results posted by EWS.
2321
2322         * Scripts/webkitpy/tool/bot/botinfo.py:
2323         (BotInfo.__init__): Take port's name.
2324         (BotInfo.summary_text):
2325
2326         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2327         (BotInfoTest.test_summary_text):
2328
2329         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2330         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2331
2332         * Scripts/webkitpy/tool/commands/queues.py:
2333         (PatchProcessingQueue.__init__): Initialize self._port.
2334         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2335         and use that for the attachment filename and the comment posted.
2336
2337         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2338         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2339         "mac-snowleopard" as expected for TestPort.
2340
2341 2013-03-22  Roger Fong  <roger_fong@apple.com>
2342
2343         Unreviewed. Turn off EWS test on Win again.
2344         The battle continues.
2345
2346         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2347         (WinEWS):
2348
2349 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2350
2351         NRWT: Enable pixel tests when retrying tests
2352         https://bugs.webkit.org/show_bug.cgi?id=112898
2353
2354         Reviewed by Dirk Pranke.
2355
2356         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2357         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2358         if we've forced pixel tests in the retry.
2359         (Manager._run_tests):
2360         (Manager._clean_up_run): Fixed the capitalizations.
2361         (Manager._force_pixel_tests_if_needed): Added.
2362
2363         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2364         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2365         'image_diff_percent' if it doesn't already exist.
2366
2367         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2368         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2369         treat this as a regular regression instead of a flakiness.
2370
2371         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2372         run had image diffs.
2373
2374         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2375         (summarized_results):
2376
2377         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2378         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2379         Also removed some dead code.
2380
2381         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2382         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2383         is set and pixel_tests_enabled is set to false.
2384         (EndToEndTest.test_reftest_with_two_notrefs):
2385
2386 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2387
2388         Make it possible to run layout tests on Retina MBP
2389         https://bugs.webkit.org/show_bug.cgi?id=93673
2390
2391         Reviewed by Ryosuke Niwa.
2392
2393         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2394         windows on 2x machines still run at 1x.
2395
2396         * DumpRenderTree/mac/DumpRenderTree.mm:
2397         (createWebViewAndOffscreenWindow):
2398         Reset the window resolution to 1x on creation.
2399         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2400         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2401         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2402         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2403         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2404         (WTR::PlatformWebView::PlatformWebView):
2405         Add NSWindow details, reset the window resolution to 1x on creation.
2406
2407 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2408
2409         Leak bots shouldn't build
2410         https://bugs.webkit.org/show_bug.cgi?id=112774
2411
2412         Reviewed by Simon Fraser.
2413
2414         Since leak bots use regular debug builds, there is no need to build on these bots.
2415         Simply downloading builds will dramatically improve the cycle time of these bots.
2416
2417         * BuildSlaveSupport/build.webkit.org-config/config.json:
2418         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2419         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2420         TestFactory instead of BuildAndTestFactory.
2421
2422 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2423
2424         [Qt] Fix the TestWebKitAPI build
2425         https://bugs.webkit.org/show_bug.cgi?id=113044
2426
2427         Reviewed by Tor Arne Vestbø.
2428
2429         The generate-forwarding-headers script would only be run
2430         after the targets in InjectedBundle.pri since the second
2431         addStrictSubdirOrderBetween call in
2432         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2433         the derived_sources -> injected_bundle order in SUBDIRS.
2434
2435         Fix it by only moving the dependent target at the end of
2436         SUBDIRS, don't touch its dependency.
2437
2438         * qmake/mkspecs/features/functions.prf:
2439
2440 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2441
2442         [EFL][WK2] View is not focused when fullscreen mode toggled
2443         https://bugs.webkit.org/show_bug.cgi?id=113009
2444
2445         Reviewed by Laszlo Gombos.
2446
2447         Set focus on view when fullscreen mode enabled/disabled
2448         by FullScreen API.
2449
2450         * MiniBrowser/efl/main.c:
2451         (on_fullscreen_accept):
2452         (on_fullscreen_deny):
2453
2454 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2455
2456         nrwt is no longer saving retry results in the retries/ subdirectory
2457         https://bugs.webkit.org/show_bug.cgi?id=112995
2458
2459         Reviewed by Ojan Vafai.
2460
2461         I think this has been broken a long time, unfortunately. This
2462         patch should fix that.
2463
2464         In order to do so, I had to pass the directory to use from
2465         the Worker object through the SingleTestWriter to the
2466         TestResultWriter. While I was plumbing that through, I rationalized
2467         the order of the parameter arguments a bit ...
2468
2469         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2470         (Worker._run_single_test):
2471         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2472         (run_single_test):
2473         (SingleTestRunner.__init__):
2474         (SingleTestRunner._run_compare_test):
2475         (SingleTestRunner._run_rebaseline):
2476         (SingleTestRunner._run_reftest):
2477         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2478         (write_test_result):
2479         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2480         (TestResultWriterTest.test_reftest_diff_image):
2481         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2482         (RunTest.test_retrying_uses_retries_directory):
2483
2484 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2485
2486         JSC profiler should have an at-a-glance report of the success of DFG optimization
2487         https://bugs.webkit.org/show_bug.cgi?id=112988
2488
2489         Reviewed by Geoffrey Garen.
2490
2491         * Scripts/display-profiler-output:
2492
2493 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2494
2495         [chromium] Linux ASAN WebKit canary is running out of memory
2496         https://bugs.webkit.org/show_bug.cgi?id=112978
2497
2498         Reviewed by Tony Chang.
2499
2500         Running the AddressSanitizer on a crash takes a lot of
2501         memory, so we should serialize access to it to avoid running
2502         out of memory on a machine.
2503
2504         * Scripts/webkitpy/layout_tests/port/chromium.py:
2505         (ChromiumPort._get_crash_log):
2506         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2507         (HttpLock.__init__):
2508         (HttpLock.wait_for_httpd_lock):
2509
2510 2013-03-21  Min Qin  <qinmin@chromium.org>
2511
2512         Cleanup android media layout test code
2513         https://bugs.webkit.org/show_bug.cgi?id=112944
2514
2515         Reviewed by Adam Barth.
2516
2517         Chromium change: https://codereview.chromium.org/12892010/
2518         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2519         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2520         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2521         Instead, we should switch to use content shell for layout tests.
2522
2523         * DumpRenderTree/chromium/TestShell.cpp:
2524         (TestShell::resetTestController):
2525
2526 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2527
2528         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2529         https://bugs.webkit.org/show_bug.cgi?id=112953
2530
2531         Reviewed by Tony Chang.
2532
2533         When I created the DumpRenderTree_resources target in r144863 I
2534         forgot to declare the needed dependencies on the other resource
2535         targets. Due to a quirk of ordering, this appears to have been fine
2536         w/ ninja but not w/ Xcode (which is still being used on the chromium
2537         mac valgrind bots). Declaring the dependencies fixes the build
2538         failures.
2539
2540         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2541
2542 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2543
2544         [WinCairo] Correct assert in Empty BitmapImage Test.
2545         https://bugs.webkit.org/show_bug.cgi?id=112934
2546
2547         Reviewed by Tim Horton.
2548
2549         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2550         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2551         to avoid ref counting assertion when leaving test scope.
2552
2553 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2554
2555         [GTK] generate-feature-defines-files is incompatible with Python3
2556         https://bugs.webkit.org/show_bug.cgi?id=112956
2557
2558         Reviewed by Martin Robinson.
2559
2560         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2561         method on the dictionary objects when iterating through said dictionaries.
2562
2563         * gtk/generate-feature-defines-files:
2564         (write_feature_defines_header):
2565         (write_flattened_feature_defines_file):
2566
2567 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2568
2569         kill-old-processes spits out error messages on Mac
2570         https://bugs.webkit.org/show_bug.cgi?id=112878
2571
2572         Reviewed by Jessie Berlin.
2573
2574         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2575         included in the list of options grep --help shows.
2576
2577         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2578
2579         * BuildSlaveSupport/kill-old-processes:
2580         (main):
2581
2582 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2583
2584         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2585         https://bugs.webkit.org/show_bug.cgi?id=112597
2586
2587         Reviewed by Xan Lopez.
2588
2589         These were introduced for the Chromium port in r105295. We need
2590         dummy implementations in order to compile the BlackBerry port.
2591
2592         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2593         (AccessibilityUIElement::scrollToMakeVisible):
2594         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2595         (AccessibilityUIElement::scrollToGlobalPoint):
2596
2597 2013-03-21  Roger Fong  <roger_fong@apple.com>
2598
2599         Re-enable WinEWS tests following r146376.
2600
2601         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2602         (WinEWS):
2603
2604 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2605
2606         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2607
2608         * Scripts/webkitpy/common/config/committers.py:
2609
2610 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2611
2612         [GTK] Missing atk in install-dependencies script
2613         https://bugs.webkit.org/show_bug.cgi?id=112272
2614
2615         Reviewed by Gustavo Noronha Silva.
2616
2617         * gtk/install-dependencies: Add missing atk dependency.
2618
2619 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2620
2621         [GTK] Missing backslash in install-dependencies script
2622         https://bugs.webkit.org/show_bug.cgi?id=112907
2623
2624         Reviewed by Philippe Normand.
2625
2626         * gtk/install-dependencies: Add missing backslash to dependencies
2627         list.
2628
2629 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2630
2631         EWS bots have stopped uploading results to bugzilla
2632         https://bugs.webkit.org/show_bug.cgi?id=101091
2633
2634         Reviewed by Adam Barth.
2635
2636         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2637         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2638         this relative file path resoled to a file inside a non-existent directory for "zip".
2639
2640         Fixed the bug by resolving both test results directory and zip archive paths in
2641         LayoutTestResultsReader.archive.
2642
2643         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2644         in the future.
2645
2646         * Scripts/webkitpy/common/system/filesystem_mock.py:
2647         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2648
2649         * Scripts/webkitpy/common/system/workspace.py:
2650         (Workspace.create_zip): Log the source path when "zip" failed.
2651
2652         * Scripts/webkitpy/common/system/workspace_mock.py:
2653         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2654
2655         * Scripts/webkitpy/common/system/workspace_unittest.py:
2656         (WorkspaceTest.test_create_zip_exception): Test that.
2657
2658         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2659         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2660         This is the actual bug fix.
2661
2662         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2663         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2664
2665 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2666
2667         [chromium] move WebThemeEngine implementations to TestRunner library
2668         https://bugs.webkit.org/show_bug.cgi?id=112751
2669
2670         Reviewed by Adam Barth.
2671
2672         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2673         * DumpRenderTree/DumpRenderTree.gypi:
2674         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2675         (WebKit):
2676         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2677         (WebTestRunner::TestInterfaces::themeEngine):
2678         (WebTestRunner):
2679         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2680         (WebKit):
2681         (TestInterfaces):
2682         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2683         (WebTestRunner::WebTestInterfaces::themeEngine):
2684         (WebTestRunner):
2685         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2686         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2687         (WebTestRunner):
2688         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2689         (WebTestRunner::WebTestThemeControlWin::box):
2690         (WebTestRunner::WebTestThemeControlWin::line):
2691         (WebTestRunner::WebTestThemeControlWin::triangle):
2692         (WebTestRunner::WebTestThemeControlWin::roundRect):
2693         (WebTestRunner::WebTestThemeControlWin::oval):
2694         (WebTestRunner::WebTestThemeControlWin::circle):
2695         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2696         (WebTestRunner::WebTestThemeControlWin::markState):
2697         (WebTestRunner::WebTestThemeControlWin::draw):
2698         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2699         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2700         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2701         (WebTestRunner):
2702         (WebTestThemeControlWin):
2703         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2704         (WebTestRunner):
2705         (WebTestThemeEngineMac):
2706         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2707         (+[FakeActiveWindow alwaysActiveWindow]):
2708         (+[FakeActiveWindow alwaysInactiveWindow]):
2709         (-[FakeActiveWindow initWithActiveControls:]):
2710         (-[FakeActiveWindow _hasActiveControls]):
2711         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2712         (WebTestRunner):
2713         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2714         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2715         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2716         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2717         (WebTestRunner):
2718         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2719         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2720         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2721         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2722         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2723         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2724         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2725         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2726         (WebTestRunner::WebTestThemeEngineWin::getSize):
2727         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2728         (WebTestRunner):
2729         (WebTestThemeEngineWin):
2730         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2731         * DumpRenderTree/chromium/TestShell.cpp:
2732         (TestShell::initialize):
2733         * DumpRenderTree/chromium/TestShell.h:
2734         (WebKit):
2735         * DumpRenderTree/chromium/TestShellMac.mm:
2736         (platformInit):
2737         * DumpRenderTree/chromium/TestShellWin.cpp:
2738         (platformInit):
2739         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2740
2741 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2742
2743         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2744
2745         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2746         New property sheet that does not link against CoreFoundation and
2747         CFNetwork.
2748         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2749         Use new TestWebKitAPICommonWinCairo property sheet.
2750         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2751         Ditto.
2752
2753 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2754
2755         [WinCairo] Unreviewed build fix for VS2010.
2756
2757         Had to add WinCairo-specific property sheets to deal with some
2758         library and path differences with the main Apple port.
2759
2760         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2761         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2762         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2763         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2764         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2765         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2766
2767 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2768
2769         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2770         https://bugs.webkit.org/show_bug.cgi?id=112849
2771
2772         Reviewed by Sam Weinig.
2773
2774         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2775         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2776         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2777
2778 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2779
2780         [WinCairo] Build WebKit Tools under VS2010
2781         https://bugs.webkit.org/show_bug.cgi?id=112821
2782
2783         Reviewed by Tim Horton.
2784
2785         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2786         Add WinCairo-specific build target.
2787         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2788         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2789         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2790         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2791         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2792         Add WinCairo-specific build target.
2793         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2794         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2795         Add WinCairo-specific build target.
2796         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2797         WinCairo-specific build target.
2798         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2799         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2800         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2801         specific build target.
2802         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2803         WinCairo-specific build target.
2804         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2805         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2806         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2807
2808 2013-03-20  Roger Fong  <roger_fong@apple.com>
2809
2810         API test gardening AppleWin port.
2811
2812         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2813
2814         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2815         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2816
2817 2013-03-20  Roger Fong  <roger_fong@apple.com>
2818
2819         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2820
2821         * EWSTools/start-queue-win.sh:
2822
2823 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2824
2825         Unreviewed, add myself to committers.py.
2826
2827 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2828
2829         Unreviewed. Adding another email for me.
2830
2831         * Scripts/webkitpy/common/config/committers.py:
2832
2833 2013-03-20  Justin Novosad  <junov@google.com>
2834
2835         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2836         https://bugs.webkit.org/show_bug.cgi?id=112605
2837
2838         Reviewed by James Robinson.
2839
2840         Deleting all the code that was used for propagating and supporting
2841         the Chromium setting for disabling deferred 2d canvas rendering.
2842
2843         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2844         (main):
2845         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2846         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2847         (WebTestRunner::WebPreferences::reset):
2848         (WebTestRunner::WebPreferences::applyTo):
2849         * DumpRenderTree/chromium/TestShell.cpp:
2850         (TestShell::TestShell):
2851         (TestShell::resetWebSettings):
2852         (TestShell::runFileTest):
2853         * DumpRenderTree/chromium/TestShell.h:
2854         (TestShell):
2855
2856 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2857
2858         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2859         https://bugs.webkit.org/show_bug.cgi?id=112699.
2860
2861         Reviewed by Adam Barth.
2862
2863         * Scripts/webkitpy/layout_tests/port/qt.py:
2864         (QtPort._search_paths):
2865         (QtPort._port_specific_expectations_files):
2866         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2867         (QtPortTest):
2868         (QtPortTest._assert_search_path):
2869         (QtPortTest._assert_expectations_files):
2870
2871 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2872
2873         [Qt] Enable kerning by default
2874         https://bugs.webkit.org/show_bug.cgi?id=112704
2875
2876         Reviewed by Jocelyn Turcotte.
2877
2878         Disable kerning by default, since some reference test expectations
2879         expect kerning to be default off.
2880
2881         * DumpRenderTree/qt/TestRunnerQt.cpp:
2882         (TestRunnerQt::reset):
2883         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2884         (WTR::activateFonts):
2885
2886 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2887
2888         [Qt] Remove empty function stubs from TestRunnerQt.
2889         https://bugs.webkit.org/show_bug.cgi?id=112799
2890
2891         We are reducing the code in TestRunnerQt step by step,
2892         in order to finally replace all of it with the generic
2893         TestRunner implementation.
2894         This patch removes several simple function stubs that
2895         currently do not implement any actual functionality.
2896
2897         Reviewed by Kenneth Rohde Christiansen.
2898
2899         * DumpRenderTree/qt/TestRunnerQt.cpp:
2900         * DumpRenderTree/qt/TestRunnerQt.h:
2901         (TestRunnerQt):
2902
2903 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2904
2905         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2906         https://bugs.webkit.org/show_bug.cgi?id=112687
2907
2908         Reviewed by Kenneth Rohde Christiansen.
2909
2910         Hide the SearchBar by default on window creation.
2911
2912         * MiniBrowser/efl/main.c:
2913         (window_create):
2914
2915 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2916
2917         Unreviewed, rolling out r146304.
2918         http://trac.webkit.org/changeset/146304
2919         https://bugs.webkit.org/show_bug.cgi?id=112788
2920
2921         to many expectations to update (Requested by antonm on
2922         #webkit).
2923
2924         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2925         * DumpRenderTree/DumpRenderTree.gypi:
2926         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2927         (WebKit):
2928         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2929         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2930         (TestInterfaces):
2931         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2932         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2933         * DumpRenderTree/chromium/TestShell.cpp:
2934         (TestShell::initialize):
2935         * DumpRenderTree/chromium/TestShell.h:
2936         (WebKit):
2937         * DumpRenderTree/chromium/TestShellMac.mm:
2938         (platformInit):
2939         * DumpRenderTree/chromium/TestShellWin.cpp:
2940         (platformInit):
2941         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2942         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2943         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2944         (WebThemeControlDRTWin::box):
2945         (WebThemeControlDRTWin::line):
2946         (WebThemeControlDRTWin::triangle):
2947         (WebThemeControlDRTWin::roundRect):
2948         (WebThemeControlDRTWin::oval):
2949         (WebThemeControlDRTWin::circle):
2950         (WebThemeControlDRTWin::nestedBoxes):
2951         (WebThemeControlDRTWin::markState):
2952         (WebThemeControlDRTWin::draw):
2953         (WebThemeControlDRTWin::drawTextField):
2954         (WebThemeControlDRTWin::drawProgressBar):
2955         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2956         (WebThemeControlDRTWin):
2957         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2958         (WebThemeEngineDRTMac):
2959         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2960         (+[FakeActiveWindow alwaysActiveWindow]):
2961         (+[FakeActiveWindow alwaysInactiveWindow]):
2962         (-[FakeActiveWindow initWithActiveControls:]):
2963         (-[FakeActiveWindow _hasActiveControls]):
2964         (WebThemeEngineDRTMac::paintScrollbarThumb):
2965         (stateToHIEnableState):
2966         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2967         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2968         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2969         (webRectToSkIRect):
2970         (drawControl):
2971         (drawTextField):
2972         (drawProgressBar):
2973         (WebThemeEngineDRTWin::paintButton):
2974         (WebThemeEngineDRTWin::paintMenuList):
2975         (WebThemeEngineDRTWin::paintScrollbarArrow):
2976         (WebThemeEngineDRTWin::paintScrollbarThumb):
2977         (WebThemeEngineDRTWin::paintScrollbarTrack):
2978         (WebThemeEngineDRTWin::paintSpinButton):
2979         (WebThemeEngineDRTWin::paintTextField):
2980         (WebThemeEngineDRTWin::paintTrackbar):
2981         (WebThemeEngineDRTWin::paintProgressBar):
2982         (WebThemeEngineDRTWin::getSize):
2983         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2984         (WebThemeEngineDRTWin):
2985         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2986
2987 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2988
2989         [Qt] Support -webkit-font-smoothing
2990         https://bugs.webkit.org/show_bug.cgi?id=106009
2991
2992         Reviewed by Jocelyn Turcotte.
2993
2994         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2995
2996         * DumpRenderTree/qt/TestRunnerQt.cpp:
2997         (TestRunnerQt::reset):
2998
2999 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
3000
3001         [GTK] accessibility/aria-scrollbar-role.html is failing
3002         https://bugs.webkit.org/show_bug.cgi?id=98358
3003
3004         Reviewed by Martin Robinson.
3005
3006         Adds support for checking accessibility object's orientation.
3007         Orientation is checked by retrieving proper state of accessibility object.
3008
3009         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3010         (checkElementState):
3011         (AccessibilityUIElement::orientation):
3012         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3013         (WTR::AccessibilityUIElement::orientation):
3014
3015 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3016
3017         [chromium] move WebThemeEngine implementations to TestRunner library
3018         https://bugs.webkit.org/show_bug.cgi?id=112751
3019
3020         Reviewed by Adam Barth.
3021
3022         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3023         * DumpRenderTree/DumpRenderTree.gypi:
3024         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3025         (WebKit):
3026         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3027         (WebTestRunner::TestInterfaces::themeEngine):
3028         (WebTestRunner):
3029         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3030         (WebKit):
3031         (TestInterfaces):
3032         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3033         (WebTestRunner::WebTestInterfaces::themeEngine):
3034         (WebTestRunner):
3035         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3036         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3037         (WebTestRunner):
3038         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3039         (WebTestRunner::WebTestThemeControlWin::box):
3040         (WebTestRunner::WebTestThemeControlWin::line):
3041         (WebTestRunner::WebTestThemeControlWin::triangle):
3042         (WebTestRunner::WebTestThemeControlWin::roundRect):
3043         (WebTestRunner::WebTestThemeControlWin::oval):
3044         (WebTestRunner::WebTestThemeControlWin::circle):
3045         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3046         (WebTestRunner::WebTestThemeControlWin::markState):
3047         (WebTestRunner::WebTestThemeControlWin::draw):
3048         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3049         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3050         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3051         (WebTestRunner):
3052         (WebTestThemeControlWin):
3053         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3054         (WebTestRunner):
3055         (WebTestThemeEngineMac):
3056         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3057         (+[FakeActiveWindow alwaysActiveWindow]):
3058         (+[FakeActiveWindow alwaysInactiveWindow]):
3059         (-[FakeActiveWindow initWithActiveControls:]):
3060         (-[FakeActiveWindow _hasActiveControls]):
3061         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3062         (WebTestRunner):
3063         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3064         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3065         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3066         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3067         (WebTestRunner):
3068         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3069         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3070         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3071         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3072         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3073         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3074         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3075         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3076         (WebTestRunner::WebTestThemeEngineWin::getSize):
3077         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3078         (WebTestRunner):
3079         (WebTestThemeEngineWin):
3080         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3081         * DumpRenderTree/chromium/TestShell.cpp:
3082         (TestShell::initialize):
3083         * DumpRenderTree/chromium/TestShell.h:
3084         (WebKit):
3085         * DumpRenderTree/chromium/TestShellMac.mm:
3086         (platformInit):
3087         * DumpRenderTree/chromium/TestShellWin.cpp:
3088         (platformInit):
3089         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3090
3091 2013-03-19  Tony Chang  <tony@chromium.org>
3092
3093         Move testRunner.setTouchDragDropEnabled to internals.settings
3094         https://bugs.webkit.org/show_bug.cgi?id=112739
3095
3096         Reviewed by Adam Barth.
3097
3098         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3099         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
3100         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3101         (TestRunner): Remove unnecessary code.
3102         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3103         (WebTestRunner::WebPreferences::reset):
3104         (WebTestRunner::WebPreferences::applyTo): Always set to false.
3105
3106 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
3107
3108         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3109         https://bugs.webkit.org/show_bug.cgi?id=112754
3110
3111         Reviewed by Darin Fisher.
3112
3113         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3114         now that it's always defined.
3115
3116         * DumpRenderTree/chromium/WebViewHost.cpp:
3117         * DumpRenderTree/chromium/WebViewHost.h:
3118         (WebViewHost):
3119
3120 2013-03-19  Kenneth Russell  <kbr@google.com>
3121
3122         Unreviewed, rolling out r146290.
3123         http://trac.webkit.org/changeset/146290
3124         https://bugs.webkit.org/show_bug.cgi?id=112751
3125
3126         Broke Chromium Mac build.
3127
3128         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3129         * DumpRenderTree/DumpRenderTree.gypi:
3130         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3131         (WebKit):
3132         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3133         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3134         (TestInterfaces):
3135         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3136         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3137         * DumpRenderTree/chromium/TestShell.cpp:
3138         (TestShell::initialize):
3139         * DumpRenderTree/chromium/TestShell.h:
3140         (WebKit):
3141         * DumpRenderTree/chromium/TestShellMac.mm:
3142         (platformInit):
3143         * DumpRenderTree/chromium/TestShellWin.cpp:
3144         (platformInit):
3145         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3146         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3147         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3148         (WebThemeControlDRTWin::box):
3149         (WebThemeControlDRTWin::line):
3150         (WebThemeControlDRTWin::triangle):
3151         (WebThemeControlDRTWin::roundRect):
3152         (WebThemeControlDRTWin::oval):
3153         (WebThemeControlDRTWin::circle):
3154         (WebThemeControlDRTWin::nestedBoxes):
3155         (WebThemeControlDRTWin::markState):
3156         (WebThemeControlDRTWin::draw):
3157         (WebThemeControlDRTWin::drawTextField):
3158         (WebThemeControlDRTWin::drawProgressBar):
3159         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3160         (WebThemeControlDRTWin):
3161         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3162         (WebThemeEngineDRTMac):
3163         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3164         (+[FakeActiveWindow alwaysActiveWindow]):
3165         (+[FakeActiveWindow alwaysInactiveWindow]):
3166         (-[FakeActiveWindow initWithActiveControls:]):
3167         (-[FakeActiveWindow _hasActiveControls]):
3168         (WebThemeEngineDRTMac::paintScrollbarThumb):
3169         (stateToHIEnableState):
3170         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3171         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3172         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3173         (webRectToSkIRect):
3174         (drawControl):
3175         (drawTextField):
3176         (drawProgressBar):
3177         (WebThemeEngineDRTWin::paintButton):
3178         (WebThemeEngineDRTWin::paintMenuList):
3179         (WebThemeEngineDRTWin::paintScrollbarArrow):
3180         (WebThemeEngineDRTWin::paintScrollbarThumb):
3181         (WebThemeEngineDRTWin::paintScrollbarTrack):
3182         (WebThemeEngineDRTWin::paintSpinButton):
3183         (WebThemeEngineDRTWin::paintTextField):
3184         (WebThemeEngineDRTWin::paintTrackbar):
3185         (WebThemeEngineDRTWin::paintProgressBar):
3186         (WebThemeEngineDRTWin::getSize):
3187         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3188         (WebThemeEngineDRTWin):
3189         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3190
3191 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
3192
3193         [EFL] canvas-fallback-content.html is failing
3194         https://bugs.webkit.org/show_bug.cgi?id=111998
3195
3196         Reviewed by Chris Fleizach.
3197
3198         Adds support for getting platform name.
3199
3200         * DumpRenderTree/TestRunner.cpp:
3201         (TestRunner::staticValues):
3202         * DumpRenderTree/TestRunner.h:
3203         (TestRunner):
3204         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3205         (TestRunner::platformName):
3206
3207 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3208
3209         [chromium] move WebThemeEngine implementations to TestRunner library
3210         https://bugs.webkit.org/show_bug.cgi?id=112751
3211
3212         Reviewed by Adam Barth.
3213
3214         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3215         * DumpRenderTree/DumpRenderTree.gypi:
3216         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3217         (WebKit):
3218         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3219         (WebTestRunner::TestInterfaces::themeEngine):
3220         (WebTestRunner):
3221         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3222         (WebKit):
3223         (TestInterfaces):
3224         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3225         (WebTestRunner::WebTestInterfaces::themeEngine):
3226         (WebTestRunner):
3227         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3228         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3229         (WebTestRunner):
3230         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3231         (WebTestRunner::WebTestThemeControlWin::box):
3232         (WebTestRunner::WebTestThemeControlWin::line):
3233         (WebTestRunner::WebTestThemeControlWin::triangle):
3234         (WebTestRunner::WebTestThemeControlWin::roundRect):
3235         (WebTestRunner::WebTestThemeControlWin::oval):
3236         (WebTestRunner::WebTestThemeControlWin::circle):
3237         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3238         (WebTestRunner::WebTestThemeControlWin::markState):
3239         (WebTestRunner::WebTestThemeControlWin::draw):
3240         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3241         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3242         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3243         (WebTestRunner):
3244         (WebTestThemeControlWin):
3245         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3246         (WebTestRunner):
3247         (WebTestThemeEngineMac):
3248         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3249         (+[FakeActiveWindow alwaysActiveWindow]):
3250         (+[FakeActiveWindow alwaysInactiveWindow]):
3251         (-[FakeActiveWindow initWithActiveControls:]):
3252         (-[FakeActiveWindow _hasActiveControls]):
3253         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3254         (WebTestRunner):
3255         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3256         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3257         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3258         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3259         (WebTestRunner):
3260         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3261         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3262         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3263         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3264         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3265         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3266         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3267         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3268         (WebTestRunner::WebTestThemeEngineWin::getSize):
3269         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3270         (WebTestRunner):
3271         (WebTestThemeEngineWin):
3272         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3273         * DumpRenderTree/chromium/TestShell.cpp:
3274         (TestShell::initialize):
3275         * DumpRenderTree/chromium/TestShell.h:
3276         (WebKit):
3277         * DumpRenderTree/chromium/TestShellMac.mm:
3278         (platformInit):
3279         * DumpRenderTree/chromium/TestShellWin.cpp:
3280         (platformInit):
3281         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3282
3283 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3284
3285         [EFL][WK2] Separate WebView further from EwkView
3286         https://bugs.webkit.org/show_bug.cgi?id=111591
3287
3288         Reviewed by Caio Marcelo de Oliveira Filho.
3289
3290         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3291         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3292         since we can afford it having EWKViewGetWKView() private API to access WKView.
3293
3294         * TestWebKitAPI/PlatformWebView.h:
3295         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3296         (TestWebKitAPI::TEST):
3297         * TestWebKitAPI/efl/PlatformWebView.cpp:
3298         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3299         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3300         (TestWebKitAPI::PlatformWebView::resizeTo):
3301         (TestWebKitAPI::PlatformWebView::page):
3302         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3303         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3304         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3305         * WebKitTestRunner/PlatformWebView.h:
3306         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3307         (WTR::EventSenderProxy::dispatchEvent):
3308         (WTR::EventSenderProxy::keyDown):
3309         (WTR::EventSenderProxy::sendTouchEvent):
3310         (WTR::EventSenderProxy::setTouchModifier):
3311         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3312         (WTR::PlatformWebView::PlatformWebView):
3313         (WTR::PlatformWebView::~PlatformWebView):
3314         (WTR::PlatformWebView::resizeTo):
3315         (WTR::PlatformWebView::page):
3316         (WTR::PlatformWebView::focus):
3317         (WTR::PlatformWebView::windowSnapshotImage):
3318
3319 2013-03-19  Roger Fong  <roger_fong@apple.com>
3320
3321         Changes to VS2010 project files should only trigger builds on Windows bots.
3322         https://bugs.webkit.org/show_bug.cgi?id=112731
3323
3324         Reviewed by Timothy Horton.
3325
3326         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3327         (_should_file_trigger_build):
3328
3329 2013-03-19  Roger Fong  <roger_fong@apple.com>
3330
3331         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3332
3333         * Scripts/webkitpy/tool/steps/runtests.py:
3334         (RunTests.run):
3335         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3336         (RunTestsTest.test_webkit_run_unit_tests):
3337
3338 2013-03-19  Julie Parent  <jparent@chromium.org>
3339
3340         Dashboards: Introduce history namespace and unit tests.
3341         https://bugs.webkit.org/show_bug.cgi?id=112645
3342
3343         Reviewed by Ojan Vafai.
3344         
3345         Laying the framework for introducing the new history object and
3346         namespace.  This moves only static functions into the history
3347         namespace, and moves corresponding unit tests into seperate
3348         unit test file.
3349
3350         * TestResultServer/static-dashboards/aggregate_results.html:
3351         * TestResultServer/static-dashboards/dashboard_base.js:
3352         (parseCrossDashboardParameters):
3353         (parseDashboardSpecificParameters):
3354         (parseParameters):
3355         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3356         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3357         (.switch.return):
3358         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3359         * TestResultServer/static-dashboards/history.js: Added.
3360         * TestResultServer/static-dashboards/history_unittests.js: Added.
3361         * TestResultServer/static-dashboards/loader.js:
3362         (.):
3363         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3364         * TestResultServer/static-dashboards/run-unittests.html:
3365         * TestResultServer/static-dashboards/timeline_explorer.html:
3366         * TestResultServer/static-dashboards/timeline_explorer.js:
3367         * TestResultServer/static-dashboards/treemap.html:
3368         * TestResultServer/static-dashboards/treemap.js:
3369         (.switch.return):
3370         * TestResultServer/static-dashboards/ui.js:
3371
3372 2013-03-19  Daniel Bates  <dbates@webkit.org>
3373
3374         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3375         https://bugs.webkit.org/show_bug.cgi?id=112732
3376
3377         Reviewed by Eric Seidel.
3378
3379         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3380         of an existing file cannot be applied.
3381
3382         In particular, svn-{apply, unapply} compensate for differences in line endings
3383         by converting the line endings in a diff to match the line endings in the target
3384         file. The diff(1) command precedes the last line of a diff that adds a newline
3385         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3386         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3387         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3388         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3389         the newline characters in this special character sequence to match the line endings
3390         in the target file.
3391
3392         * Scripts/VCSUtils.pm:
3393         (parseDiff):
3394         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3395         Added tests:
3396             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3397             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3398             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3399             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3400         (escapeNewLineCharacters): Added.
3401         (toMacLineEndings): Added.
3402
3403 2013-03-19  James Robinson  <jamesr@chromium.org>
3404
3405         [chromium] Remove compositor settings that don't go through WebKit
3406         https://bugs.webkit.org/show_bug.cgi?id=112718
3407
3408         Reviewed by Adam Barth.
3409
3410         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3411         (main):
3412         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3413         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3414         (WebTestRunner::WebPreferences::reset):
3415         (WebTestRunner::WebPreferences::applyTo):
3416         * DumpRenderTree/chromium/TestShell.cpp:
3417         (TestShell::TestShell):
3418         (TestShell::resetWebSettings):
3419         * DumpRenderTree/chromium/TestShell.h:
3420         (TestShell):
3421
3422 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3423
3424         Unreviewed, rolling out r146101.
3425         https://bugs.webkit.org/show_bug.cgi?id=111884
3426
3427         re-enable custom freetype on asan; this needs to be on
3428         now that the bot is running lucid.
3429
3430         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3431
3432 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3433
3434         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3435         https://bugs.webkit.org/show_bug.cgi?id=112365
3436
3437         Reviewed by Benjamin Poulain.
3438
3439         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3440         harcoding it in wtf/Platform.h
3441
3442         * Scripts/webkitperl/FeatureList.pm:
3443
3444 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3445
3446         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3447         https://bugs.webkit.org/show_bug.cgi?id=94782
3448
3449         Based on patch by Csaba Osztrogonác.
3450         Reviewed by Jocelyn Turcotte.
3451
3452         The diff image is generated with bright red indicating errors, but letting the base image
3453         shine through so the context of the error-pixel can be identified.
3454
3455         * DumpRenderTree/qt/ImageDiff.cpp:
3456         (main):
3457
3458 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3459
3460         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3461
3462         Rubber-stamped by Csaba Osztrogonác.
3463
3464         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3465         since the latter might not cover the former.
3466
3467         * QtTestBrowser/launcherwindow.cpp:
3468         (LauncherWindow::print):
3469
3470 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3471
3472         Style tweeks to default.css.
3473         
3474         Rubber-stamped by David Kilzer.
3475         
3476         Give visited links a different color to other links, so you can
3477         see which builds you've viewed.
3478         
3479         Make the <small> text less tiny.
3480
3481         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3482         (small):
3483         (a:link,a:visited,a:active):
3484         (a:visited):
3485
3486 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3487
3488         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3489         https://bugs.webkit.org/show_bug.cgi?id=112494
3490
3491         Reviewed by Dirk Pranke.
3492
3493         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3494         Also merged two pairs of methods to cleanup the code.
3495
3496         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3497         (PerfTestsRunner.run): Merged _upload_and_show_results.
3498         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3499
3500 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3501
3502         [chromium] build xdisplaycheck when building DRT
3503         https://bugs.webkit.org/show_bug.cgi?id=112636
3504
3505         Reviewed by Tony Chang.
3506
3507         It appears that we need xdisplaycheck to be built in order for
3508         Xvfb to be started correctly on the bots, and DRT was missing
3509         a dependency on it. This may be the cause of the ASAN bot not
3510         starting up properly (it only builds DRT).
3511
3512         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3513
3514 2013-03-18  David Levin  <levin@chromium.org>
3515
3516         Implement icon change notification dump for Chromium's test shell.
3517         https://bugs.webkit.org/show_bug.cgi?id=112614
3518
3519         This was previously implemented for some other platforms in r58111
3520         and r116547.
3521
3522         In r122806, fast/dom/icon-url-property.html stopped using it, but
3523         it is useful for tests, so I plan to re-add it to that test again.
3524
3525         Reviewed by Jochen Eisinger.
3526
3527         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3528         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3529          icon change notifications from WebKit may be logged in test output.
3530         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3531         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3532         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3533         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3534         (WebTestRunner):
3535         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3536         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3537         (TestRunner):
3538         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3539         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3540         (WebTestRunner):
3541         * DumpRenderTree/chromium/WebViewHost.cpp:
3542         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3543         * DumpRenderTree/chromium/WebViewHost.h:
3544         (WebViewHost):
3545
3546 2013-03-18  Julie Parent  <jparent@chromium.org>
3547
3548         Cleanup: Move js for treemap and aggregate_results into own js files.
3549         https://bugs.webkit.org/show_bug.cgi?id=112618
3550
3551         Reviewed by Dirk Pranke.
3552         
3553         No functional changes, just moving the code into separate js file
3554         rather than inlined in the html, so we can test it, make it more
3555         modular, etc.  Other dashboard types are already done this way.
3556
3557         * TestResultServer/static-dashboards/aggregate_results.html:
3558         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3559         (generatePage):
3560         (handleValidHashParameter):
3561         (htmlForBuilder):
3562         (rawValuesHTML):
3563         (chartHTML):
3564         (filteredValues):
3565         (chart):
3566         (htmlForRevisionRows):
3567         (wrapHTMLInTable):
3568         (htmlForSummaryTable):
3569         (valuesPerExpectation):
3570         (htmlForTestType):
3571         (htmlForTableRow):
3572         (extendedEncode):
3573         * TestResultServer/static-dashboards/treemap.html:
3574         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3575         (humanReadableTime):
3576         (convertToWebTreemapFormat):
3577         (reverseSortByAverage):
3578         (generatePage):
3579         (focusPath):
3580         (.switch.return):
3581         (handleQueryParameterChange):
3582         (extractName):
3583         (fullName):
3584         (handleFocus.):
3585         (handleFocus):
3586
3587 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3588
3589         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3590         https://bugs.webkit.org/show_bug.cgi?id=112622
3591
3592         Reviewed by Dirk Pranke.
3593
3594         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3595         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3596
3597 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3598
3599         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3600         https://bugs.webkit.org/show_bug.cgi?id=112619
3601
3602         Reviewed by Dirk Pranke.
3603
3604         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3605         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3606
3607         * Scripts/webkitpy/layout_tests/port/gtk.py:
3608         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3609         Port._webkit_baseline_path method.
3610         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3611         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3612         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3613         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3614         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3615         that are expected based on the builder name.
3616
3617 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3618
3619         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3620         https://bugs.webkit.org/show_bug.cgi?id=112571
3621
3622         Reviewed by Adam Barth.
3623
3624         Update function declarations for new WebFileSystemType enum. (All
3625         changes are behind an #ifdef so we can sync required changes in embedders.)
3626
3627         * DumpRenderTree/chromium/WebViewHost.cpp:
3628         (WebViewHost::openFileSystem):
3629         (WebViewHost::deleteFileSystem):
3630         * DumpRenderTree/chromium/WebViewHost.h:
3631         (WebViewHost):
3632
3633 2013-03-18  Julie Parent  <jparent@chromium.org>
3634
3635         Cleanup: Move timeline_exporer js out of html file into js.
3636         https://bugs.webkit.org/show_bug.cgi?id=112188
3637
3638         Reviewed by Dirk Pranke.
3639         
3640         Moves the javascript out of the html file and into a new js file.
3641         This follows the format of flakiness_dashboard.{html|js}.
3642         
3643         Also moves code from dashboard_base that is used only by this one
3644         dashboard, and makes it private to the dashboard.
3645
3646         * TestResultServer/static-dashboards/dashboard_base.js:
3647         * TestResultServer/static-dashboards/timeline_explorer.html:
3648         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3649         (generatePage):
3650         (initCurrentBuilderTestResults):
3651         (shouldShowWebKitRevisionsOnly):
3652         (updateTimelineForBuilder.):
3653         (updateTimelineForBuilder):
3654         (selectBuild):
3655         (updateBuildIndicator):
3656         (.addRow):
3657         (.addNumberRow):
3658         (.inspectorNode.getElementsByTagName.0.onclick):
3659         (.inspectorNode.getElementsByTagName.1.onclick):
3660         (.inspectorNode.getElementsByTagName.2.onclick):
3661         (updateBuildInspector):
3662         (showResultsDelta):
3663         (decompressResults.addFlakyDelta):
3664         (decompressResults):
3665
3666 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3667
3668         Unreviewed, rolling out r145272.
3669         http://trac.webkit.org/changeset/145272
3670         https://bugs.webkit.org/show_bug.cgi?id=111884
3671
3672         Turns out the ASAN build is still broken; possibly there's
3673         something still setting LD_LIBRARY_PATH, or possibly there's
3674         something else wrong. In the meantime, we need it to work again.
3675
3676         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3677
3678 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3679
3680         delete-stale-build-files is too aggressive
3681         https://bugs.webkit.org/show_bug.cgi?id=112595
3682
3683         Reviewed by Tim Horton.
3684
3685         It appears that whitelisting file extensions to keep is not a good idea.
3686         Blacklist files to delete instead, and only delete .o files for now.
3687         We can add more file extensions as needed.
3688
3689         * BuildSlaveSupport/delete-stale-build-files:
3690
3691 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3692
3693         Disable accessibility notifications after each test
3694         https://bugs.webkit.org/show_bug.cgi?id=112579
3695
3696         Reviewed by Tim Horton.
3697         
3698         In WebKitTestRunner, if any tests triggered accessibility notifications,
3699         the global notification handler would thereafter be active, and fire
3700         notifications for all subsequent tests.
3701         
3702         Fix by implementing AccessibilityController::resetToConsistentState() for
3703         Mac, and using it to clear the global notification handler.
3704
3705         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3706         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3707         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3708         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3709         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3710         (e.g. because of -autorelease).
3711         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3712         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3713         if there is one.
3714         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3715         Add -stopObserving
3716         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3717         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3718         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3719         center.
3720
3721 2013-03-18  Dana Jansens  <danakj@chromium.org>
3722
3723         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3724         https://bugs.webkit.org/show_bug.cgi?id=112392
3725
3726         Reviewed by James Robinson.
3727
3728         Removes the command line flag option from DRT.
3729
3730         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3731         (main):
3732
3733 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3734
3735         [GTK] plugins/plugin-clip-subframe.html is failing
3736         https://bugs.webkit.org/show_bug.cgi?id=112570
3737
3738         Reviewed by Martin Robinson.
3739
3740         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3741
3742 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3743
3744         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3745         https://bugs.webkit.org/show_bug.cgi?id=112442
3746
3747         Reviewed by Gustavo Noronha Silva.
3748
3749         * GtkLauncher/main.c:
3750         (reloadCb):
3751         (createToolbar):
3752         (createWindow):
3753
3754 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3755
3756         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3757         https://bugs.webkit.org/show_bug.cgi?id=112205
3758
3759         Disable this API test until Geoff can fix it.
3760
3761         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3762         (TestWebKitAPI::TEST):
3763
3764 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3765
3766         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3767         https://bugs.webkit.org/show_bug.cgi?id=112478
3768
3769         Reviewed by Tony Chang.
3770
3771         There is nothing that ensures that the log messages from the plugin
3772         come in before the layout test finished loading.
3773
3774         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3775         (PassDifferentNPPStruct::NPP_SetWindow):
3776         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3777         (NPP_SetWindow):
3778
3779 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3780
3781         Have the mac port support per_test_timeout in webkitpy
3782         https://bugs.webkit.org/show_bug.cgi?id=112466
3783
3784         Reviewed by Dirk Pranke.
3785         
3786         Both WTR and DRT handle --timeout arguments, so we can
3787         have the scripts pass the timeout values down to the tools.
3788
3789         * Scripts/webkitpy/layout_tests/port/mac.py:
3790         (MacPort.supports_per_test_timeout):
3791
3792 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3793
3794         Remove setAsynchronousSpellCheckingEnabled from test runners
3795         https://bugs.webkit.org/show_bug.cgi?id=112362
3796
3797         Reviewed by Tony Chang.
3798
3799         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3800         in internals.settings, so all ports can share it.
3801
3802         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3803         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3804         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3805         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3806         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3807         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3808         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3809         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3810         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3811         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3812         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3813         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3814
3815 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3816
3817         Fix the stupid unit tests.
3818
3819         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3820         (test_sample_process):
3821
3822 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3823
3824         Collect samples for unresponsive web processes
3825         https://bugs.webkit.org/show_bug.cgi?id=112409
3826
3827         Reviewed by Tim Horton.
3828         
3829         When we detect that a subprocess was unresponsive, run the 'sample'
3830         tool on that process, for the Mac port.
3831         
3832         The sample will be linked to from the results.html page, next
3833         to the crash log link.
3834
3835         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3836         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3837         look for samples on disk.
3838         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3839         (TestResultWriter):
3840         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3841         -sample.txt files, and have it copy their contents to a new file
3842         next to the test that spawned them (as we do for crash logs).
3843         * Scripts/webkitpy/layout_tests/port/base.py:
3844         (Port.look_for_new_samples): Base class does nothing for sampling.
3845         * Scripts/webkitpy/layout_tests/port/driver.py:
3846         (Driver._check_for_driver_crash): Kick off a sample if we detected
3847         that the subprocess was unresponsive.
3848         * Scripts/webkitpy/layout_tests/port/mac.py:
3849         (MacPort.sample_file_path): Utility to generate the file path
3850         to the generated sample files at the top level of layout-test-results.
3851         (MacPort.look_for_new_crash_logs): Fix typo
3852         (MacPort.look_for_new_samples): New function to find sample files.
3853         (MacPort.sample_process): Use the utility function to get the file path.
3854
3855 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3856
3857         [Qt] Remove simple getters and setters from TestRunnerQt
3858         https://bugs.webkit.org/show_bug.cgi?id=112343
3859
3860         Reviewed by Benjamin Poulain.
3861
3862         The removed functions and boolean members
3863         are being replaced by the implementations in the
3864         generic TestRunner.h.
3865
3866         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3867         (DumpRenderTree::dumpFrameScrollPosition):
3868         (DumpRenderTree::dumpFramesAsText):
3869         (DumpRenderTree::dump):
3870         (DumpRenderTree::titleChanged):
3871         (DumpRenderTree::dumpDatabaseQuota):
3872         (DumpRenderTree::dumpApplicationCacheQuota):
3873         (DumpRenderTree::statusBarMessage):
3874         (DumpRenderTree::createWindow):
3875         * DumpRenderTree/qt/TestRunnerQt.cpp:
3876         (TestRunnerQt::reset):
3877         * DumpRenderTree/qt/TestRunnerQt.h:
3878         (TestRunnerQt):
3879
3880 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3881
3882         Update the link on build.webkit.org to refer to perf.webkit.org
3883         https://bugs.webkit.org/show_bug.cgi?id=112416
3884
3885         Reviewed by Philip Rogers.
3886
3887         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3888
3889         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3890
3891 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3892
3893         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3894         https://bugs.webkit.org/show_bug.cgi?id=112394
3895
3896         Reviewed by Philippe Normand.
3897
3898         * GtkLauncher/main.c:
3899         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3900
3901 2013-03-14  Andreas Kling  <akling@apple.com>
3902
3903         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3904         <http://webkit.org/b/111815>
3905         <rdar://problem/13380145>
3906
3907         Reviewed by Anders Carlsson.
3908
3909         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3910         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3911         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3912
3913         * WebKitTestRunner/PlatformWebView.h:
3914         (PlatformWebView):
3915         * WebKitTestRunner/TestController.cpp:
3916         (WTR::TestController::createOtherPage):
3917         (WTR::TestController::createWebViewWithOptions):
3918         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3919         (WTR::PlatformWebView::didInitializeClients):
3920
3921 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3922
3923         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3924         https://bugs.webkit.org/show_bug.cgi?id=112122
3925
3926         Reviewed by Kenneth Rohde Christiansen.
3927
3928         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3929
3930         * MiniBrowser/efl/main.c:
3931         (_Browser_Window):
3932         (search_box_show):
3933         (search_box_hide):
3934         (on_key_down):
3935         (on_url_changed):
3936         (on_search_field_aborted):
3937         (on_search_field_activated):
3938         (on_search_field_clicked):
3939         (on_search_backward_button_clicked):
3940         (on_search_forward_button_clicked):
3941         (window_create):
3942
3943 2013-03-14  Julie Parent  <jparent@chromium.org>
3944
3945         Cleanup: Remove g_resourceLoader.
3946         https://bugs.webkit.org/show_bug.cgi?id=112305
3947
3948         Reviewed by Dirk Pranke.
3949         
3950         Removing another global.
3951         
3952         Now, each dashboard creates its own loader, rather than having
3953         a general global one.
3954         
3955         Remove usage of g_resourceLoader.isLoadingComplete from 
3956         handleLocationChange by ensuring that handleLocationChange is
3957         never called before the loader is done.  It was called in two
3958         places before: 1 was from the callback when the loader is done,
3959         so that was obviously true, and the other was from onhashchange,
3960         where it would just return rather than running.  Instead, lets
3961         only register the onhashchange handler once the loader is
3962         setup, so the check is no longer necessary.
3963         
3964         Remove isLoadingComplete since it is now unused.
3965         
3966         Callback for loader is now initializeHistory, rather than just
3967         handleLocationChange which will set up the hashchange handler now.
3968         This will all eventually be moving to a new History object.
3969
3970         * TestResultServer/static-dashboards/aggregate_results.html:
3971         * TestResultServer/static-dashboards/dashboard_base.js:
3972         (handleLocationChange):
3973         (intializeHistory):
3974         (decompressResults):
3975         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3976         (generatePage):
3977         * TestResultServer/static-dashboards/loader.js:
3978         (.):
3979         * TestResultServer/static-dashboards/loader_unittests.js:
3980         * TestResultServer/static-dashboards/timeline_explorer.html:
3981         * TestResultServer/static-dashboards/treemap.html:
3982
3983 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3984
3985         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3986         https://bugs.webkit.org/show_bug.cgi?id=109404
3987
3988         Reviewed by Tony Chang.
3989
3990         Removes all the code related to smartInsertDeleteEnabled and
3991         selectTrailingWhitespaceEnabled settings as they will be managed from
3992         internals from now on.
3993
3994         * DumpRenderTree/TestRunner.cpp:
3995         (TestRunner::staticFunctions):
3996         * DumpRenderTree/TestRunner.h:
3997         (TestRunner):
3998         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3999         (WebKit):
4000         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
4001         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
4002         (DumpRenderTree):
4003         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4004         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4005         (WebTestRunner::WebTestProxy::didStopLoading):
4006         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4007         (WebTestRunner::TestRunner::TestRunner):
4008         (WebTestRunner::TestRunner::reset):
4009         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4010         (TestRunner):
4011         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
4012         (WebTestRunner::WebPreferences::applyTo): Set default values for
4013         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
4014         Chromium DRT default values are different from Chromium browser.
4015         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4016         * DumpRenderTree/chromium/WebViewHost.cpp:
4017         * DumpRenderTree/chromium/WebViewHost.h:
4018         (WebViewHost):
4019         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4020         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4021         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4022         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4023         (resetDefaultsToConsistentValues):
4024         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4025         * DumpRenderTree/mac/DumpRenderTree.mm:
4026         (resetWebViewToConsistentStateBeforeTesting):
4027         * DumpRenderTree/mac/TestRunnerMac.mm:
4028         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4029         (WebCore::WebPage::resetSettings):
4030         * DumpRenderTree/qt/TestRunnerQt.cpp:
4031         * DumpRenderTree/qt/TestRunnerQt.h:
4032         (TestRunnerQt):
4033         * DumpRenderTree/win/DumpRenderTree.cpp:
4034         (resetWebViewToConsistentStateBeforeTesting):
4035         * DumpRenderTree/win/TestRunnerWin.cpp:
4036         * DumpRenderTree/wx/TestRunnerWx.cpp:
4037
4038 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
4039
4040         [Qt] Disable DRT on Windows
4041
4042         Reviewed by Jocelyn Turcotte.
4043
4044         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
4045
4046         * qmake/mkspecs/features/configure.prf:
4047
4048 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
4049
4050         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
4051         https://bugs.webkit.org/show_bug.cgi?id=110728
4052
4053         Reviewed by Gyuyoung Kim.
4054
4055         Use the page group to create the view object.
4056
4057         * MiniBrowser/efl/main.c:
4058         (window_create):
4059
4060 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
4061
4062         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
4063
4064         Reviewed by Tor Arne Vestbø.
4065
4066         The mock versions of these web facing features should be instantiated when
4067         running in DumpRenderTree only. In order for them to work, no extra Qt modules
4068         such as QtLocation are actually needed.
4069
4070         This patch decouples enabling device orientation/motion and geolocation from
4071         the underlying Qt modules and makes them available in developer builds
4072         (!production_build) and backed by mock backends when running in drt.
4073
4074         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
4075         developers the web facing features are always enabled (although requests will
4076         time out) and the mock backends are enabled inside DRT, allowing for the layout
4077         tests to run with less dependencies.
4078
4079         In addition this also enables the mock device motion client, which was
4080         previously never instantiated.
4081
4082         * qmake/mkspecs/features/features.prf:
4083
4084 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4085
4086         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
4087         https://bugs.webkit.org/show_bug.cgi?id=112340
4088
4089         Reviewed by Simon Hausmann.
4090
4091         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4092         (DumpRenderTree::dump):
4093             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
4094         (DumpRenderTree::dumpApplicationCacheQuota):
4095         * DumpRenderTree/qt/TestRunnerQt.cpp:
4096         (TestRunnerQt::reset):
4097         * DumpRenderTree/qt/TestRunnerQt.h:
4098         (TestRunnerQt):
4099
4100 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4101
4102         [Qt] Port DRT to use TestRunner::dumpAsText()
4103         https://bugs.webkit.org/show_bug.cgi?id=112260
4104
4105         Reviewed by Benjamin Poulain.
4106
4107         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4108         (WebCore::DumpRenderTree::open):
4109         (WebCore::methodNameStringForFailedTest):
4110             Change parameter from type TestRunnerQt* to TestRunner*.
4111         (WebCore::DumpRenderTree::dump):
4112             TestRunnerQt::shouldDumpPixels() always returned true in our case.
4113             Instead we should rely on TestRunner::generatePixelResults().
4114         * DumpRenderTree/qt/TestRunnerQt.cpp:
4115         (TestRunnerQt::reset):
4116         * DumpRenderTree/qt/TestRunnerQt.h:
4117         (TestRunnerQt):
4118
4119 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
4120
4121         Implement FontLoader interface
4122         https://bugs.webkit.org/show_bug.cgi?id=98395
4123
4124         Reviewed by Eric Seidel.
4125
4126         Enable FontLoadEvents runtime flag for TestShell.
4127
4128         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4129         (WebTestRunner::TestInterfaces::TestInterfaces):
4130
4131 2013-03-13  Julie Parent  <jparent@chromium.org>
4132
4133         CLeanup: remove unnecessary call to parseParameters.
4134         https://bugs.webkit.org/show_bug.cgi?id=112309
4135
4136         Reviewed by Ojan Vafai.
4137         
4138         We call parseCrossDashboardParameters when the dashboard initially
4139         loads to set the state required for loadBuildersList, and then we
4140         call it again once we are fully done with loading, so there is no
4141         reason to call it in the middle of the loading process here.
4142
4143         * TestResultServer/static-dashboards/loader.js:
4144         (.):
4145
4146 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
4147
4148         Unreviewed. Now I'm a reviewer :)
4149
4150         * Scripts/webkitpy/common/config/committers.py:
4151
4152 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
4153
4154         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
4155         https://bugs.webkit.org/show_bug.cgi?id=112277
4156
4157         Reviewed by Adam Barth.
4158
4159         * Scripts/webkitperl/FeatureList.pm:
4160         * qmake/mkspecs/features/features.pri:
4161
4162 2013-03-13  Adam Barth  <abarth@webkit.org>
4163
4164         run-perf-tests should support content_shell
4165         https://bugs.webkit.org/show_bug.cgi?id=112291
4166
4167         Reviewed by Eric Seidel.
4168
4169         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4170         (PerfTestsRunner._parse_args):
4171
4172 2013-03-13  Oliver Hunt  <oliver@apple.com>
4173
4174         Simplify Checked<> multiplication
4175         https://bugs.webkit.org/show_bug.cgi?id=112286
4176
4177         Reviewed by James Robinson.
4178
4179         Add tests for multiplication by zero and max to ensure we don't
4180         mess them up should we ever make changes to Checked<> in future.
4181
4182         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4183         (TestWebKitAPI):
4184
4185 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4186
4187         [Qt] Unreviewed prospective Windows build fix
4188
4189         Do the usual thing, include the moc generated code in the .cpp file instead
4190         of compiling it standalone, to ensure that config.h is included, too, and
4191         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
4192
4193         * DumpRenderTree/qt/EventSenderQt.cpp:
4194
4195 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4196
4197         [Qt] Port TestRunner::findString to shared interface
4198         https://bugs.webkit.org/show_bug.cgi?id=112147
4199
4200         Reviewed by Jocelyn Turcotte.
4201
4202         This patch also removes DumpRenderTree and some other helper classes from
4203         the WebCore namespace, to which they do not really belong.
4204
4205         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4206         (main):
4207         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4208         (DumpRenderTree::DumpRenderTree):
4209         (DumpRenderTree::~DumpRenderTree):
4210         (DumpRenderTree::instance):
4211         (DumpRenderTree::setShouldTimeout):
4212         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4213         (DumpRenderTree):
4214         * DumpRenderTree/qt/EventSenderQt.cpp:
4215         (EventSender::contextClick):
4216         (EventSender::sendEvent):
4217         (EventSender::postEvent):
4218         * DumpRenderTree/qt/EventSenderQt.h:
4219         (EventSender::isGraphicsBased):
4220         * DumpRenderTree/qt/TestRunnerQt.cpp:
4221         (TestRunnerQt::TestRunnerQt):
4222         (TestRunner::findString):
4223         (TestRunnerQt::setMockDeviceOrientation):
4224         (TestRunnerQt::setGeolocationPermission):
4225         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
4226         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
4227         (TestRunnerQt::setMockGeolocationPosition):
4228         * DumpRenderTree/qt/TestRunnerQt.h:
4229         (TestRunnerQt):
4230
4231 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
4232
4233         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
4234         https://bugs.webkit.org/show_bug.cgi?id=112129
4235
4236         Reviewed by Adam Barth.
4237
4238         Following Chromium
4239         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
4240         this is being renamed to better explain what it does.
4241
4242         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4243
4244 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4245
4246         [Qt] Unreviewed trivial typo fix
4247
4248         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
4249         TextRunner.h. Thanks Zeno :)
4250
4251 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
4252
4253         [Qt] Prepare DRT for transition to shared TestRunner interface
4254         https://bugs.webkit.org/show_bug.cgi?id=112144
4255
4256         Reviewed by Benjamin Poulain.
4257
4258         Prepare Qt's DRT for a transition from the QObject based TestRunner to
4259         the JSC C API based one.
4260
4261         This is impplemented by instantiating the QObject based testRunner in
4262         the global object, then instantiating the JSC C based TestRunner
4263         separately and placing it "behind" the QObject based testRunner through
4264         injection of the individual functions through proxies. (prototype
4265         chaining doesn't work due to the this object and Function.prototype.bind
4266         doesn't work due to the native function)
4267
4268         This allows for porting over method by method by removing the method
4269         from the QObject TestRunnerQt and implementing it in the JSC C based
4270         TestRunner.
4271
4272         In order for this to link and run dummy implementations of all the
4273         necessary TestRunner functions are provided.
4274
4275         * DumpRenderTree/qt/DumpRenderTree.pro:
4276         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4277         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4278         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4279         (WebCore::DumpRenderTree::initJSObjects):
4280         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4281         (DumpRenderTree):
4282         * DumpRenderTree/qt/TestRunnerQt.cpp:
4283         (TestRunner::~TestRunner):
4284         (TestRunner::addDisallowedURL):
4285         (TestRunner::queueLoad):
4286         (TestRunner::removeAllVisitedLinks):
4287         (TestRunner::setAcceptsEditing):
4288         (TestRunner::simulateLegacyWebNotificationClick):
4289         (TestRunner::setWindowIsKey):
4290         (TestRunner::setAlwaysAcceptCookies):
4291         (TestRunner::addOriginAccessWhitelistEntry):
4292         (Test