TestRunner::notifyDone() should be safely reentrant
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2
3         TestRunner::notifyDone() should be safely reentrant
4         https://bugs.webkit.org/show_bug.cgi?id=196898
5
6         Reviewed by Darin Adler.
7
8         It is currently possible that TestRunner::notifyDone() will call itself, since
9         notifyDone() will force a repaint, which can start executing JavaScript, which
10         may call notifyDone() again. This can lead to test failures and flakiness.
11         Fix this by setting the m_waitToDump flag before calling the dump() method.
12
13         * DumpRenderTree/mac/TestRunnerMac.mm:
14         (TestRunner::notifyDone):
15         (TestRunner::forceImmediateCompletion):
16         * DumpRenderTree/win/TestRunnerWin.cpp:
17         (TestRunner::notifyDone):
18         (TestRunner::forceImmediateCompletion):
19
20 2019-04-15  Philippe Normand  <pnormand@igalia.com>
21
22         [GTK][WPE] Add enable-media websetting
23         https://bugs.webkit.org/show_bug.cgi?id=196863
24
25         Reviewed by Michael Catanzaro.
26
27         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
28         (testWebKitSettings): Add test for the enable-media web-setting.
29
30 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
31
32         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
33         https://bugs.webkit.org/show_bug.cgi?id=196905
34         <rdar://problem/49886096>
35
36         Reviewed by Tim Horton.
37
38         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
39         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
40         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
41         delay timer, we end up with this sequence of events in the problematic (failure) case:
42
43         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
44             ...IPC from UI to web process...
45         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
46             ...IPC from web to UI process...
47         (c) [UI]    Invoke completion handler for script #1
48         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
49             ...IPC from UI to web process...
50         (e) [Web]   Evaluate script #2 in the web process
51         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
52
53         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
54         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
55         #2 is run in step (e).
56
57         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
58         the UI process by waiting on a script message posted by the web process, after attachment updates are
59         dispatched.
60
61         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
62         (TestWebKitAPI::TEST):
63
64 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
65
66         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
67         https://bugs.webkit.org/show_bug.cgi?id=196909
68
69         Reviewed by Wenson Hsieh.
70
71         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
72         (TestWebKitAPI::TEST):
73
74 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
75
76         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
77         https://bugs.webkit.org/show_bug.cgi?id=196880
78
79         Reviewed by Yusuke Suzuki.
80
81         Add a new function for bytecode cache tests that does not forceDiskCache
82         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
83         test added in this patch, since the code is invalid and therefore won't be
84         cached. It should also be useful for tests that evaluate dynamically
85         generated code.
86
87         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
88         * Scripts/run-jsc-stress-tests:
89
90 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
91
92         Update AudioSession route sharing policy
93         https://bugs.webkit.org/show_bug.cgi?id=196776
94         <rdar://problem/46501611>
95
96         Reviewed by Jer Noble.
97
98         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
99         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
100         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
101         (TestWebKitAPI::TEST):
102
103 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
104
105         [iOS] Software keyboard is shown too frequently on some websites
106         https://bugs.webkit.org/show_bug.cgi?id=195856
107         <rdar://problem/49191395>
108
109         Reviewed by Darin Adler.
110
111         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
112
113         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
114         (WTR::UIScriptController::setHardwareKeyboardAttached):
115         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
116         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
117         (WTR::UIScriptController::setHardwareKeyboardAttached):
118         * TestRunnerShared/UIScriptContext/UIScriptController.h:
119         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
120
121         Additionally link against GraphicsServices in WebKitTestRunner.
122
123         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
124         (WTR::TestController::platformResetStateToConsistentValues):
125         (WTR::UIScriptController::setHardwareKeyboardAttached):
126
127 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
128
129         [GTK][WPE] Fix pacman install-dependencies packages
130         https://bugs.webkit.org/show_bug.cgi?id=196817
131
132         Reviewed by Žan Doberšek.
133         
134         python3-setuptools is called python-setuptools
135         ruby-highline is only available on AUR
136         libv4l-devel is incorporated in v4l-utils
137
138         * gtk/install-dependencies:
139         * wpe/install-dependencies:
140
141 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
142
143         [GTK] REGRESSION(r243860): Many tests failing
144         https://bugs.webkit.org/show_bug.cgi?id=196791
145
146         Reviewed by Joanmarie Diggs.
147
148         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
149         multiple documents and check that accessibility hierarchy is updated after a navigation.
150
151         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
152         (loadChangedCallback):
153         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
154         (AccessibilityTest::AccessibilityTest):
155         (AccessibilityTest::~AccessibilityTest):
156         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
157         (AccessibilityTest::findTestServerApplication):
158         (AccessibilityTest::findDocumentWeb):
159         (AccessibilityTest::findRootObject):
160         (AccessibilityTest::waitUntilChildrenRemoved):
161         (AccessibilityTest::ensureProxy):
162         (testAtspiBasicHierarchy):
163         (beforeAll):
164         (afterAll):
165
166 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
167
168         [ews-build] Handle bug titles with unicode characters
169         https://bugs.webkit.org/show_bug.cgi?id=196802
170
171         Reviewed by Dewei Zhu.
172
173         * BuildSlaveSupport/ews-build/steps.py:
174         (ValidatePatch._is_bug_closed):
175
176 2019-04-11  Michael Saboff  <msaboff@apple.com>
177
178         Improve the Inline Cache Stats code
179         https://bugs.webkit.org/show_bug.cgi?id=196836
180
181         Reviewed by Saam Barati.
182
183         Added a new script to consolidate and arrange the output of --useICStats option.
184
185         This script merges the output from every group into one large table and sorts it from most common to
186         least common.  It also counts the slow path GetById and PutById variants and then calculates the
187         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
188         Put together, this is useful to see what property accesses are not getting cached.
189
190         * Scripts/ic-stats.py: Added.
191         (ICStats):
192         (ICStats.__init__):
193         (ICStats.parse):
194         (ICStats.dumpStats):
195         (usage):
196
197 2019-04-10  Alex Christensen  <achristensen@webkit.org>
198
199         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
200         https://bugs.webkit.org/show_bug.cgi?id=196809
201         <rdar://49800762>
202
203         Reviewed by Brady Eidson.
204
205         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
206         (TEST):
207
208 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
209
210         requestAnimationFrame should execute before the next frame
211         https://bugs.webkit.org/show_bug.cgi?id=177484
212
213         Reviewed by Simon Fraser.
214
215         Add trace points for the page RenderingUpdate.
216
217         * Tracing/SystemTracePoints.plist:
218
219 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
220
221         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
222         https://bugs.webkit.org/show_bug.cgi?id=196760
223
224         Reviewed by Don Olmstead.
225
226         vswhere.exe has been bundled since Visual Studio 2017 version
227         15.2. We shouldn't download vswhere.exe.
228
229         * Scripts/build-jsc: Do not call update-vswhere.py.
230         * Scripts/build-webkit: Ditto.
231         * Scripts/update-vswhere.py: Removed.
232         * Scripts/webkitdirs.pm:
233         (requireModulesForVSWhere): Deleted.
234         (pickCurrentVisualStudioInstallation): Deleted.
235         (visualStudioInstallDirVSWhere): Return the latest installed VS
236         installation path by using the bundled vswhere.exe.
237         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
238         (visualStudioInstallDirFallback): Removed.
239
240 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
241
242         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
243         https://bugs.webkit.org/show_bug.cgi?id=196780
244
245         Reviewed by Alexey Proskuryakov.
246
247         * BuildSlaveSupport/ews-build/steps.py:
248         * BuildSlaveSupport/ews-build/steps_unittest.py:
249
250 2019-04-10  Alex Christensen  <achristensen@webkit.org>
251
252         Add SPI WKNavigationResponse._downloadAttribute
253         https://bugs.webkit.org/show_bug.cgi?id=196755
254         <rdar://49587365>
255
256         Reviewed by Brady Eidson.
257
258         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
259         (-[NavigationResponseTestDelegate navigationResponse]):
260         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
261         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
262         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
263         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
264         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
265         (readRequest):
266         (writeResponse):
267         (TEST):
268
269 2019-04-10  Tim Horton  <timothy_horton@apple.com>
270
271         Add modern API for overriding the page's specified viewport configuration
272         https://bugs.webkit.org/show_bug.cgi?id=167734
273         <rdar://problem/30331795>
274
275         Reviewed by Simon Fraser.
276
277         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
278         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
279
280 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
281
282         Add support for incremental bytecode cache updates
283         https://bugs.webkit.org/show_bug.cgi?id=195000
284
285         Reviewed by Filip Pizlo.
286
287         Exit when the initial run to generate bytecode fails.
288
289         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
290
291 2019-04-10  Alex Christensen  <achristensen@webkit.org>
292
293         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
294         https://bugs.webkit.org/show_bug.cgi?id=196744
295         <rdar://49415309>
296
297         Reviewed by Chris Dumez.
298
299         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
300         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
301
302 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
303
304         Add a way to opt into modern compatibility mode in layout tests
305         https://bugs.webkit.org/show_bug.cgi?id=196770
306         <rdar://problem/49777550>
307
308         Reviewed by Antoine Quint.
309
310         Add a new test option to enable modern compatibility mode in layout tests.
311
312         * WebKitTestRunner/TestController.cpp:
313         (WTR::updateTestOptionsFromTestHeader):
314         * WebKitTestRunner/TestController.h:
315         * WebKitTestRunner/TestOptions.h:
316         (WTR::TestOptions::hasSameInitializationOptions const):
317         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
318         (WTR::TestController::platformCreateWebView):
319         (WTR::TestController::enableModernCompatibilityMode):
320
321 2019-04-10  Andy Estes  <aestes@apple.com>
322
323         Try to fix the 32-bit watchOS build.
324
325         * TestWebKitAPI/cocoa/TestWKWebView.mm:
326         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
327
328 2019-04-10  Antoine Quint  <graouts@apple.com>
329
330         Enable Pointer Events on watchOS
331         https://bugs.webkit.org/show_bug.cgi?id=196771
332         <rdar://problem/49040909>
333
334         Reviewed by Dean Jackson.
335
336         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
337
338 2019-04-10  Philippe Normand  <pnormand@igalia.com>
339
340         Unreviewed. Fix WPE accessibility tests after r244059.
341
342         We are failing to load the injected bundle due to undefined symbol
343         AccessibilityUIElement::replaceTextInRange().
344
345         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
346         (WTR::AccessibilityUIElement::replaceTextInRange):
347
348 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
349
350         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
351         https://bugs.webkit.org/show_bug.cgi?id=196727
352
353         Reviewed by Fujii Hironori.
354
355         * MiniBrowser/win/WebKitBrowserWindow.cpp:
356         (WebKitBrowserWindow::create):
357
358 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
359
360         [ews-build] Add unit tests for PrintConfiguration
361         https://bugs.webkit.org/show_bug.cgi?id=196752
362
363         Reviewed by Dewei Zhu.
364
365         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
366
367 2019-04-09  Keith Rollin  <krollin@apple.com>
368
369         Unreviewed build maintenance -- update .xcfilelists.
370
371         * DumpRenderTree/DerivedSources-input.xcfilelist:
372         * DumpRenderTree/DerivedSources-output.xcfilelist:
373
374 2019-04-09  Zalan Bujtas  <zalan@apple.com>
375
376         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
377         https://bugs.webkit.org/show_bug.cgi?id=196743
378         <rdar://problem/43897551>
379
380         Reviewed by Tim Horton.
381
382         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
383         (TEST):
384
385 2019-04-09  Youenn Fablet  <youenn@apple.com>
386
387         Close service worker database on network process suspension
388         https://bugs.webkit.org/show_bug.cgi?id=196623
389         <rdar://problem/48930869>
390
391         Reviewed by Alex Christensen.
392
393         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
394
395 2019-04-09  Daniel Bates  <dabates@apple.com>
396
397         [iPad] Should open popover when the spacebar is pressed
398         https://bugs.webkit.org/show_bug.cgi?id=196360
399         <rdar://problem/49389129>
400
401         Reviewed by Brent Fulgham.
402
403         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
404
405         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
406         (WTR::UIScriptController::isShowingPopover const): Added.
407         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
408         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
409         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
410         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
411         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
412         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
413         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
414         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
415         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
416         (WTR::UIScriptController::isShowingPopover const): Added.
417         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
418         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
419         * TestRunnerShared/UIScriptContext/UIScriptController.h:
420         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
421         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
422         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
423         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
424         (-[TestRunnerWKWebView _willPresentPopover]): Added.
425         (-[TestRunnerWKWebView _didDismissPopover]): Added.
426         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
427         (WTR::UIScriptController::isShowingPopover const): Added.
428         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
429         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
430
431 2019-04-09  Alex Christensen  <achristensen@webkit.org>
432
433         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
434         https://bugs.webkit.org/show_bug.cgi?id=196665
435         <rdar://45115669>
436
437         Reviewed by Geoff Garen.
438
439         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
440         (goBack):
441         (+[SimpleLookupContext sharedLookupContext]):
442         (-[SimpleLookupContext lookUpURL:completionHandler:]):
443         (TEST):
444         (+[Simple3LookupContext sharedLookupContext]): Deleted.
445         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
446
447 2019-04-09  John Wilander  <wilander@apple.com>
448
449         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
450         https://bugs.webkit.org/show_bug.cgi?id=196558
451         <rdar://problem/47650245>
452
453         Reviewed by Youenn Fablet.
454
455         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
456         (TestWebKitAPI::TEST):
457             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
458
459 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
460
461         [CMake] Apple builds should use ICU_INCLUDE_DIRS
462         https://bugs.webkit.org/show_bug.cgi?id=196720
463
464         Reviewed by Konstantin Tokarev.
465
466         * TestWebKitAPI/PlatformMac.cmake:
467
468 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
469
470         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
471         https://bugs.webkit.org/show_bug.cgi?id=196694
472         <rdar://problem/48388734>
473
474         Rubber-stamped by Aakash Jain.
475
476         * Scripts/webkitpy/port/image_diff.py:
477         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
478         * Scripts/webkitpy/port/server_process.py:
479         (ServerProcess.has_available_stdout): Check if stdout has data in it.
480         (ServerProcess._wait_for_data_and_update_buffers_using_select):
481         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
482         * Scripts/webkitpy/port/server_process_mock.py:
483         (MockServerProcess.has_available_stdout):
484         * Scripts/webkitpy/port/server_process_unittest.py:
485         (TestServerProcess.serial_test_basic):
486
487 2019-04-09  Jer Noble  <jer.noble@apple.com>
488
489         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
490         https://bugs.webkit.org/show_bug.cgi?id=196097
491
492         Reviewed by Eric Carlson.
493
494         Drive-by bug fix: allow tests to play audio without a user gesture by default.
495
496         * DumpRenderTree/mac/DumpRenderTree.mm:
497         (resetWebPreferencesToConsistentValues):
498         * WebKitTestRunner/TestController.cpp:
499         (WTR::TestController::resetPreferencesToConsistentValues):
500
501 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
502
503         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
504         https://bugs.webkit.org/show_bug.cgi?id=196690
505
506         Reviewed by Michael Catanzaro.
507
508         * QueueStatusServer/config/queues.py:
509         * Scripts/webkitpy/common/config/ews.json:
510         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
511         (test_ews_name):
512
513 2019-04-09  Chris Dumez  <cdumez@apple.com>
514
515         Loads using loadHTMLString() cause flashing when process-swapping
516         https://bugs.webkit.org/show_bug.cgi?id=196714
517         <rdar://problem/49637354>
518
519         Reviewed by Antti Koivisto.
520
521         Add API test coverage.
522
523         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
524
525 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
526
527         Unreviewed. Fix ATK accessibility tests after r244059.
528
529         We are failing to load the injected bundle due to undefined symbol
530         AccessibilityUIElement::replaceTextInRange().
531
532         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
533         (WTR::AccessibilityUIElement::replaceTextInRange):
534
535 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
536
537         AX: Support API: accessibilityReplaceRange:withText
538         https://bugs.webkit.org/show_bug.cgi?id=196636
539
540         Unreviewed build fix for Windows port.
541
542         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
543         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
544
545 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
546
547         [CMake][WinCairo] Separate copied headers into different directories
548         https://bugs.webkit.org/show_bug.cgi?id=196655
549
550         Reviewed by Michael Catanzaro.
551
552         * DumpRenderTree/CMakeLists.txt:
553         * MiniBrowser/win/CMakeLists.txt:
554         * TestWebKitAPI/CMakeLists.txt:
555         * TestWebKitAPI/PlatformWin.cmake:
556
557 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
558
559         Log stack-trace for run-webkit-tests when interrupted
560         https://bugs.webkit.org/show_bug.cgi?id=176393
561         <rdar://problem/34262310>
562
563         Reviewed by Lucas Forschler.
564
565         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
566         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
567         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
568         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
569         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
570         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
571         (main): Set handlers to log stack trace on interruption.
572
573 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
574
575         AX: Support API: accessibilityReplaceRange:withText
576         https://bugs.webkit.org/show_bug.cgi?id=196636
577
578         Unreviewed build fix for Windows port.
579
580         * DumpRenderTree/AccessibilityUIElement.cpp:
581         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
582
583 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
584
585         [ews-build] Scripts using Buildbot API have CORS error
586         https://bugs.webkit.org/show_bug.cgi?id=196709
587
588         Reviewed by Alexey Proskuryakov.
589
590         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
591
592 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
593
594         AX: Support API: accessibilityReplaceRange:withText
595         https://bugs.webkit.org/show_bug.cgi?id=196636
596
597         Reviewed by Daniel Bates.
598
599         * DumpRenderTree/AccessibilityUIElement.cpp:
600         (replaceTextInRangeCallback):
601         (AccessibilityUIElement::replaceTextInRange):
602         (AccessibilityUIElement::getJSClass):
603         * DumpRenderTree/AccessibilityUIElement.h:
604         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
605         (AccessibilityUIElement::replaceTextInRange):
606         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
607         (AccessibilityUIElement::replaceTextInRange):
608         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
609         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
610         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
611         (WTR::AccessibilityUIElement::replaceTextInRange):
612         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
613         (WTR::AccessibilityUIElement::replaceTextInRange):
614
615 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
616
617         [iOS] Do not allow starting selection drags when selection views are not visible
618         https://bugs.webkit.org/show_bug.cgi?id=196686
619         <rdar://problem/49399192>
620
621         Reviewed by Tim Horton.
622
623         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
624         also add some new API tests to cover scenarios where the web view is not first responder.
625
626         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
627         (TestWebKitAPI::TEST):
628         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
629
630         Add a switch to optionally make the web view first responder when starting the simulated drag.
631
632         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
633         (-[DragAndDropSimulator initWithWebView:]):
634         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
635
636 2019-04-08  Justin Fan  <justin_fan@apple.com>
637
638         [Web GPU] Fix Web GPU experimental feature on iOS
639         https://bugs.webkit.org/show_bug.cgi?id=196632
640
641         Reviewed by Myles C. Maxfield.
642
643         Properly make Web GPU available on iOS 11+.
644
645         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
646
647 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
648
649         [ews-build] Do not upload archive when Compile Fails
650         https://bugs.webkit.org/show_bug.cgi?id=196674
651
652         Reviewed by Alexey Proskuryakov.
653
654         * BuildSlaveSupport/ews-build/factories.py:
655         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
656         * BuildSlaveSupport/ews-build/steps.py:
657         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
658         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
659         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
660
661 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
662
663         Enable DFG on MIPS
664         https://bugs.webkit.org/show_bug.cgi?id=196689
665
666         Reviewed by Žan Doberšek.
667
668         Since the bytecode change, we enabled the baseline JIT on mips in
669         r240432, but DFG is still missing. With this change, all tests are
670         passing on a ci20 board.
671
672         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
673
674 2019-04-08  Philippe Normand  <pnormand@igalia.com>
675
676         [Flatpak] Second run update-webkitwpe-flatpak fails
677         https://bugs.webkit.org/show_bug.cgi?id=192702
678
679         Reviewed by Carlos Garcia Campos.
680
681         * flatpak/flatpakutils.py:
682         (FlatpakObject.flatpak): Fix typo.
683         (FlatpakPackage.install): When installing, also update to the configured remote commit.
684         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
685
686 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
687
688         [GTK][WPE] outlook.live.com displays old-fashioned UI
689         https://bugs.webkit.org/show_bug.cgi?id=196642
690
691         Reviewed by Carlos Garcia Campos.
692
693         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
694         (TestWebKitAPI::TEST): New Mac platform quirk test.
695
696 2019-04-07  Commit Queue  <commit-queue@webkit.org>
697
698         Unreviewed, rolling out r243956.
699         https://bugs.webkit.org/show_bug.cgi?id=196688
700
701         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
702         by aakashjain on #webkit).
703
704         Reverted changeset:
705
706         "Clicking "Go Back" from a safe browsing warning from an
707         iframe should navigate the WKWebView back to the previous
708         page"
709         https://bugs.webkit.org/show_bug.cgi?id=196665
710         https://trac.webkit.org/changeset/243956
711
712 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
713
714         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
715         https://bugs.webkit.org/show_bug.cgi?id=196669
716
717         Reviewed by Geoffrey Garen.
718
719         Added three new unit tests for WeakHashSet.
720
721         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
722         (WTF_WeakPtr.WeakHashSetConstObjects):
723         (WTF_WeakPtr.WeakHashSetComputesEmpty):
724         (WTF_WeakPtr.WeakHashSetComputeSize):
725
726 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
727
728         Hide next and previous form control buttons when WKWebView is editable
729         https://bugs.webkit.org/show_bug.cgi?id=196672
730         <rdar://problem/35625321>
731
732         Reviewed by Tim Horton.
733
734         Add a new API test.
735
736         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
737         (-[TestWKWebView lastTrailingBarButtonGroup]):
738         (TestWebKitAPI::TEST):
739         * TestWebKitAPI/ios/UIKitSPI.h:
740
741 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
742
743         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
744         https://bugs.webkit.org/show_bug.cgi?id=196077
745         <rdar://problem/49108202>
746
747         Reviewed by Chris Dumez.
748
749         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
750         on new web view.
751
752         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
753
754 2019-04-05  Saam Barati  <sbarati@apple.com>
755
756         Make compare-results understand MotionMark
757         https://bugs.webkit.org/show_bug.cgi?id=196666
758
759         Reviewed by Yusuke Suzuki.
760
761         * Scripts/compare-results:
762         (PLT5Results):
763         (detectMotionMark):
764         (detectMotionMark1_1):
765         (motionMarkResults):
766         (motionMark1_1Results):
767         (detectBenchmark):
768         (biggerIsBetter):
769         (main):
770
771 2019-04-05  Alex Christensen  <achristensen@webkit.org>
772
773         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
774         https://bugs.webkit.org/show_bug.cgi?id=196665
775         <rdar://45115669>
776
777         Reviewed by Geoff Garen.
778
779         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
780         (goBack):
781         (+[SimpleLookupContext sharedLookupContext]):
782         (-[SimpleLookupContext lookUpURL:completionHandler:]):
783         (TEST):
784         (+[Simple3LookupContext sharedLookupContext]): Deleted.
785         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
786
787 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
788
789         [ews-build] Add configuration and architecture for windows builders
790         https://bugs.webkit.org/show_bug.cgi?id=196660
791
792         Reviewed by Lucas Forschler.
793
794         * BuildSlaveSupport/ews-build/config.json:
795
796 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
797
798         webkitpy: Don't run subsequent rounds if interrupted
799         https://bugs.webkit.org/show_bug.cgi?id=196646
800
801         Reviewed by Aakash Jain.
802
803         * Scripts/webkitpy/layout_tests/controllers/manager.py:
804         (Manager.run): Bail out if interrupted.
805
806 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
807
808         Test sessionStorage in PSON private browsing mode
809         https://bugs.webkit.org/show_bug.cgi?id=196561
810
811         Reviewed by Alex Christensen.
812
813         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
814
815 2019-04-05  Commit Queue  <commit-queue@webkit.org>
816
817         Unreviewed, rolling out r243833.
818         https://bugs.webkit.org/show_bug.cgi?id=196645
819
820         This change breaks build of WPE and GTK ports (Requested by
821         annulen on #webkit).
822
823         Reverted changeset:
824
825         "[CMake][WTF] Mirror XCode header directories"
826         https://bugs.webkit.org/show_bug.cgi?id=191662
827         https://trac.webkit.org/changeset/243833
828
829 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
830
831         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
832         https://bugs.webkit.org/show_bug.cgi?id=196635
833
834         Reviewed by Antti Koivisto.
835         
836         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
837         for a test to enable async frame scrolling via:
838             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
839         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
840         
841         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
842
843         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
844         (WTR::InjectedBundle::beginTesting):
845         * WebKitTestRunner/TestController.cpp:
846         (WTR::TestController::resetPreferencesToConsistentValues):
847
848 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
849
850         Use a correct LC_RPATH when building with ASan
851         https://bugs.webkit.org/show_bug.cgi?id=196576
852
853         Reviewed by David Kilzer.
854
855         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
856         so that ../Frameworks is checked. This is simpler and more reliable than updating
857         each SPC service xcconfig.
858
859 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
860
861         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
862         https://bugs.webkit.org/show_bug.cgi?id=196629
863
864         Reviewed by Lucas Forschler.
865
866         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
867
868 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
869
870         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
871         https://bugs.webkit.org/show_bug.cgi?id=196618
872
873         Reviewed by Lucas Forschler.
874
875         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
876         (StatusBubble): Added QUEUE_TRIGGERS.
877         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
878         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
879         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
880         its parent(builder).
881
882 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
883
884         [ews-app] Status-bubble steps are sometimes displayed in reverse order
885         https://bugs.webkit.org/show_bug.cgi?id=196625
886
887         Reviewed by Lucas Forschler.
888
889         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
890         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
891
892 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
893
894         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
895         https://bugs.webkit.org/show_bug.cgi?id=196630
896
897         Reviewed by Wenson Hsieh.
898
899         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
900
901 2019-04-04  Youenn Fablet  <youenn@apple.com>
902
903         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
904         https://bugs.webkit.org/show_bug.cgi?id=196543
905
906         Reviewed by Alex Christensen.
907
908         * WebKitTestRunner/TestController.cpp:
909         (WTR::TestController::generatePageConfiguration):
910
911 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
912
913         [ews-app] Status bubble should not display skipped buildbot steps
914         https://bugs.webkit.org/show_bug.cgi?id=196584
915
916         Reviewed by Lucas Forschler.
917
918         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
919
920 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
921
922         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
923         https://bugs.webkit.org/show_bug.cgi?id=196620
924
925         Reviewed by Lucas Forschler.
926
927         * BuildSlaveSupport/ews-app/ews/config.py:
928
929 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
930
931         [Win] DumpRenderTreeWatchDog.py is not checked into source
932         https://bugs.webkit.org/show_bug.cgi?id=196567
933         <rdar://problem/49525901>
934
935         Reviewed by Lucas Forschler.
936
937         This script is used on Win EWS bots to terminate hanging DRT processes.
938
939         * EWSTools/dumprendertreewatchdog.py: Added.
940
941 2019-04-04  Chris Dumez  <cdumez@apple.com>
942
943         Unreviewed, roll out r243858 which made tests time out.
944
945         Disable new API tests on Windows instead.
946
947         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
948         (TestWebKitAPI::TEST):
949
950 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
951
952         [ATK] Cleanup WebPageAccessibilityObjectAtk
953         https://bugs.webkit.org/show_bug.cgi?id=196537
954
955         Reviewed by Michael Catanzaro.
956
957         Also consider files under atk directories as exceptions for GObject conventions.
958
959         * Scripts/webkitpy/style/checkers/cpp.py:
960         (check_identifier_name_in_declaration):
961
962 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
963
964         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
965         https://bugs.webkit.org/show_bug.cgi?id=196588
966         <rdar://problem/49365787>
967
968         Unreviewed build fix for Windows port.
969
970         error C3861: 'kill': identifier not found
971
972         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
973         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
974
975 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
976
977         [ews-build] Cancel build and similar operations should have authentication
978         https://bugs.webkit.org/show_bug.cgi?id=196520
979
980         Reviewed by Dewei Zhu.
981
982         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
983         environment variables.
984
985 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
986
987         [ews-build] Do not trigger queues which are not in production yet
988         https://bugs.webkit.org/show_bug.cgi?id=196581
989
990         Reviewed by Dewei Zhu.
991
992         * BuildSlaveSupport/ews-build/config.json:
993
994 2019-04-03  Chris Dumez  <cdumez@apple.com>
995
996         Unreviewed, fix typo in the name of API test added in r243848.
997
998         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
999         (TestWebKitAPI::TEST):
1000
1001 2019-04-03  Chris Dumez  <cdumez@apple.com>
1002
1003         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1004         https://bugs.webkit.org/show_bug.cgi?id=196588
1005         <rdar://problem/49365787>
1006
1007         Reviewed by Ryosuke Niwa.
1008
1009         Add API test coverage.
1010
1011         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1012         (TestWebKitAPI::nullJavaScriptCallback):
1013         (TestWebKitAPI::didCrashCheckFrames):
1014         (TestWebKitAPI::TEST):
1015
1016 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1017
1018         run-webkit-tests: Upload test results (new results database)
1019         https://bugs.webkit.org/show_bug.cgi?id=196577
1020         <rdar://problem/34841155>
1021
1022         Reviewed by Lucas Forschler.
1023
1024         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1025         (Manager.run): Upload results after each device shard, since the configuration will be
1026         different for each device.
1027         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1028         uploaded to a results database.
1029         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1030         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1031
1032 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1033
1034         -apple-trailing-word is needed for browser detection
1035         https://bugs.webkit.org/show_bug.cgi?id=196575
1036
1037         Unreviewed.
1038
1039         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1040
1041 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1042
1043         [CMake][WTF] Mirror XCode header directories
1044         https://bugs.webkit.org/show_bug.cgi?id=191662
1045
1046         Reviewed by Konstantin Tokarev.
1047
1048         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1049         builds.
1050
1051         * CMakeLists.txt:
1052         * DumpRenderTree/CMakeLists.txt:
1053         * DumpRenderTree/PlatformWin.cmake:
1054         * MiniBrowser/win/CMakeLists.txt:
1055         * TestWebKitAPI/CMakeLists.txt:
1056         * TestWebKitAPI/PlatformWin.cmake:
1057         * WebKitTestRunner/PlatformGTK.cmake:
1058         * WebKitTestRunner/PlatformWin.cmake:
1059
1060 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1061
1062         [ews-app] Status bubble should not display certain infrastructure status messages
1063         https://bugs.webkit.org/show_bug.cgi?id=196550
1064
1065         Reviewed by Lucas Forschler.
1066
1067         Do not display the steps which are un-needed for end-user. This information is still avaiable
1068         if the user click on the bubble and look at the Buildbot build.
1069         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1070         (StatusBubble._steps_messages):
1071         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1072
1073 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1074
1075         [ews-build] Use https for sending data to ews-app
1076         https://bugs.webkit.org/show_bug.cgi?id=196492
1077
1078         Reviewed by Lucas Forschler.
1079
1080         * BuildSlaveSupport/ews-build/events.py:
1081
1082 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1083
1084         Remove support for -apple-trailing-word
1085         https://bugs.webkit.org/show_bug.cgi?id=196525
1086
1087         Reviewed by Zalan Bujtas.
1088
1089         This CSS property is nonstandard and not used.
1090
1091         * Scripts/webkitperl/FeatureList.pm:
1092         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1093
1094 2019-04-03  Youenn Fablet  <youenn@apple.com>
1095
1096         Add a test for DOMCache on multiple browsing in case of private browsing
1097         https://bugs.webkit.org/show_bug.cgi?id=196524
1098
1099         Reviewed by Alex Christensen.
1100
1101         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1102         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1103
1104 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1105
1106         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1107         https://bugs.webkit.org/show_bug.cgi?id=196540
1108
1109         Reviewed by Aakash Jain.
1110
1111         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1112
1113 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1114
1115         Add plumbing for a compatibility mode preference in WebKit
1116         https://bugs.webkit.org/show_bug.cgi?id=196005
1117
1118         Reviewed by Tim Horton.
1119
1120         Add new API tests.
1121
1122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1123         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1124
1125 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1126
1127         [WPE][GTK] Update libsrtp dependency package for Debian
1128         https://bugs.webkit.org/show_bug.cgi?id=196528
1129
1130         Reviewed by Frédéric Wang.
1131
1132         * gtk/install-dependencies:
1133         * wpe/install-dependencies:
1134
1135 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1136
1137         [WK2] Add support for Window's beforeprint / afterprint events
1138         https://bugs.webkit.org/show_bug.cgi?id=196478
1139         <rdar://problem/49535124>
1140
1141         Unreviewed build fix for MSVC.
1142
1143         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1144
1145         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1146
1147         * WebKitTestRunner/TestController.cpp:
1148         (WTR::printFrame): Use int and float literals.
1149
1150 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1151
1152         [ews-build] Reassign bots to queues
1153
1154         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1155
1156 2019-04-02  Chris Dumez  <cdumez@apple.com>
1157
1158         [WK2] Add support for Window's beforeprint / afterprint events
1159         https://bugs.webkit.org/show_bug.cgi?id=196478
1160
1161         Reviewed by Alex Christensen.
1162
1163         Add minimal implementation for printFrame in WebKitTestRunner.
1164
1165         * WebKitTestRunner/TestController.cpp:
1166         (WTR::printFrame):
1167         (WTR::TestController::createOtherPage):
1168         (WTR::TestController::createWebViewWithOptions):
1169
1170 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1171
1172         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1173         https://bugs.webkit.org/show_bug.cgi?id=196491
1174
1175         Reviewed by Lucas Forschler.
1176
1177         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1178
1179 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1180
1181         [ews-build] Configure buildbot try credentials in environment variables
1182         https://bugs.webkit.org/show_bug.cgi?id=196501
1183
1184         Reviewed by Lucas Forschler.
1185
1186         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1187         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1188         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1189
1190 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1191
1192         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1193         https://bugs.webkit.org/show_bug.cgi?id=196496
1194         <rdar://problem/49521634>
1195
1196         Reviewed by Chris Dumez.
1197
1198         Add new API tests (see WebKit ChangeLog for more detail).
1199
1200         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1201         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1202         (TEST):
1203
1204 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1205
1206         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1207         <https://webkit.org/b/196499>
1208
1209         Reviewed by Alexey Proskuryakov.
1210
1211         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1212         ENABLE_ADDRESS_SANITIZER.
1213
1214 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1215
1216         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1217         https://bugs.webkit.org/show_bug.cgi?id=182757
1218
1219         Reviewed by Don Olmstead.
1220
1221         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1222         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1223
1224 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1225
1226         run-api-tests: Upload test results
1227         https://bugs.webkit.org/show_bug.cgi?id=196323
1228         <rdar://problem/49356714>
1229
1230         Reviewed by Lucas Forschler.
1231
1232         * Scripts/webkitpy/api_tests/manager.py:
1233         (Manager):
1234         (Manager.run): Upload results to a results database.
1235         * Scripts/webkitpy/api_tests/run_api_tests.py:
1236         (parse_args): Add upload arguments.
1237         * Scripts/webkitpy/port/base.py:
1238         (Port):
1239         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1240         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1241         with commits from any other associated repositories.
1242         * Scripts/webkitpy/port/device.py:
1243         (Device):
1244         (Device.build_version): Access build_versoin of underlying platform device.
1245         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1246         (IOSSimulatorTest):
1247         (IOSSimulatorTest.test_configuration_for_upload):
1248         * Scripts/webkitpy/port/device_port.py:
1249         (DevicePort):
1250         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1251         the same as the machine uploading results.
1252         * Scripts/webkitpy/port/mac.py:
1253         (MacPort):
1254         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1255         * Scripts/webkitpy/port/mac_unittest.py:
1256         (MacTest):
1257         (MacTest.test_configuration_for_upload):
1258         * Scripts/webkitpy/xcode/simulated_device.py:
1259         (SimulatedDeviceManager._create_device_with_runtime):
1260         (SimulatedDevice.__init__): Create simulated device with a build_version.
1261         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1262         (test_existing_simulator):
1263
1264 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1265
1266         Remove extra newline characters (Follow-up fix to r243707)
1267
1268         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1269
1270 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1271
1272         [ews-app] Use API_KEY to accept results data
1273         https://bugs.webkit.org/show_bug.cgi?id=196461
1274
1275         Reviewed by Dewei Zhu.
1276
1277         * BuildSlaveSupport/ews-app/ews/views/results.py:
1278         (Results.post): Validate EWS_API_KEY before accepting any data.
1279         * BuildSlaveSupport/ews-build/events.py:
1280         (Events.sendData): Send EWS_API_KEY if available along with event data.
1281
1282 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1283
1284         Unable to copy and paste a PDF from Notes into Mail compose body
1285         https://bugs.webkit.org/show_bug.cgi?id=196442
1286         <rdar://problem/48573098>
1287
1288         Reviewed by Tim Horton.
1289
1290         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1291         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1292         to be specified on the item providers.
1293
1294         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1295         (TestWebKitAPI::mapItemForTesting):
1296         (TestWebKitAPI::contactItemForTesting):
1297
1298 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1299
1300         Make UIWKDocumentContext rects per-character instead of per-word
1301         https://bugs.webkit.org/show_bug.cgi?id=196459
1302
1303         Reviewed by Wenson Hsieh.
1304
1305         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1306         (TEST):
1307         Adjust test results due to switching to per-character rects.
1308
1309 2019-04-01  Chris Dumez  <cdumez@apple.com>
1310
1311         UIProcess crash when a prewarmed process is terminated
1312         https://bugs.webkit.org/show_bug.cgi?id=196451
1313         <rdar://problem/49245471>
1314
1315         Reviewed by Geoffrey Garen.
1316
1317         Add API test coverage.
1318
1319         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1320         (TEST):
1321
1322 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1323
1324         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1325         https://bugs.webkit.org/show_bug.cgi?id=196449
1326
1327         Reviewed by Lucas Forschler.
1328
1329         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1330         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1331         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1332         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1333
1334 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1335
1336         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1337         https://bugs.webkit.org/show_bug.cgi?id=196444
1338
1339         Reviewed by Lucas Forschler.
1340
1341         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1342
1343 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1344
1345         Add SPI to canonicalize NSURLs with WTF::URL
1346         https://bugs.webkit.org/show_bug.cgi?id=196415
1347         <rdar://problem/44980271>
1348
1349         Reviewed by Darin Adler.
1350
1351         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1352         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1353         (TestWebKitAPI::TEST):
1354
1355 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1356
1357         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1358         https://bugs.webkit.org/show_bug.cgi?id=196441
1359
1360         Reviewed by Carlos Garcia Campos.
1361
1362         Don't cache the wpe_view_backend object that might not exist yet at the
1363         time of EventSenderProxy constructor invocation, but instead retrieve
1364         that object whenever it's required for event dispatching. This should
1365         avoid crashes in this constructor now that it's invoked before any
1366         PlatformWindow has been set up (as changed in r243496).
1367
1368         * WebKitTestRunner/EventSenderProxy.h:
1369         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1370         (WTR::viewBackend):
1371         (WTR::EventSenderProxy::EventSenderProxy):
1372         (WTR::EventSenderProxy::mouseDown):
1373         (WTR::EventSenderProxy::mouseUp):
1374         (WTR::EventSenderProxy::mouseMoveTo):
1375         (WTR::EventSenderProxy::mouseScrollBy):
1376         (WTR::EventSenderProxy::keyDown):
1377         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1378
1379 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1380
1381         [Win][WebKit] MiniBrowser should support high DPI display
1382         https://bugs.webkit.org/show_bug.cgi?id=196391
1383
1384         Reviewed by Alex Christensen.
1385
1386         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1387         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1388         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1389         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1390
1391 2019-03-31  Sam Weinig  <weinig@apple.com>
1392
1393         Remove more i386 specific configurations
1394         https://bugs.webkit.org/show_bug.cgi?id=196430
1395
1396         Reviewed by Alexey Proskuryakov.
1397
1398         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1399         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1400
1401 2019-03-31  Andy Estes  <aestes@apple.com>
1402
1403         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1404         https://bugs.webkit.org/show_bug.cgi?id=196433
1405         <rdar://problem/49293305>
1406
1407         Reviewed by Tim Horton.
1408
1409         Enhanced API test coverage to include all navigation response policy decisions in both
1410         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1411
1412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1413         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1414         (TestWebKitAPI::TEST):
1415         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1416         (readFile):
1417         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1418         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1419         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1420         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1421         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1422         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1423         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1424         (-[QuickLookDelegate _downloadDidStart:]):
1425         (-[QuickLookDelegate _download:didReceiveResponse:]):
1426         (-[QuickLookDelegate _download:didReceiveData:]):
1427         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1428         (-[QuickLookDelegate _downloadDidFinish:]):
1429         (-[QuickLookDelegate _download:didFailWithError:]):
1430         (-[QuickLookDelegate _downloadDidCancel:]):
1431         (-[QuickLookDelegate verifyDownload]):
1432         (runTest):
1433         (runTestDecideBeforeLoading):
1434         (runTestDecideAfterLoading):
1435         (TEST):
1436         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1437         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1438         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1439         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1440         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1441         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1442         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1443         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1444         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1445         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1446         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1447         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1448         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1449         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1450
1451 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1452
1453         [CMake] add testdfg as target with build-jsc
1454         https://bugs.webkit.org/show_bug.cgi?id=196393
1455
1456         Reviewed by Saam Barati.
1457
1458         Added testdfg as one of the targets to build when
1459         using CMake.
1460
1461         * Scripts/build-jsc:
1462
1463 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1464
1465         Delete WebMetal implementation in favor of WebGPU
1466         https://bugs.webkit.org/show_bug.cgi?id=195418
1467
1468         Reviewed by Dean Jackson.
1469
1470         * DumpRenderTree/mac/DumpRenderTree.mm:
1471         (enableExperimentalFeatures):
1472         (resetWebPreferencesToConsistentValues):
1473         * Scripts/webkitperl/FeatureList.pm:
1474         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1476         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1477         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1478         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1479         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1480         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1481         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1482         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1483         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1484         (WTR::InjectedBundle::beginTesting):
1485         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1486         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1487         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1488
1489 2019-03-29  Chris Dumez  <cdumez@apple.com>
1490
1491         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1492         https://bugs.webkit.org/show_bug.cgi?id=196405
1493         <rdar://problem/49428130>
1494
1495         Reviewed by Wenson Hsieh.
1496
1497         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1498         the popover presentation methods to be no-ops. Use this in the new test added in
1499         r243523 so that we do not swizzle those methods for all tests. This is needed because
1500         those WatchOS tests rely on the popover getting presented and interactive.
1501
1502         * WebKitTestRunner/TestController.cpp:
1503         (WTR::updateTestOptionsFromTestHeader):
1504         * WebKitTestRunner/TestController.h:
1505         * WebKitTestRunner/TestOptions.h:
1506         (WTR::TestOptions::hasSameInitializationOptions const):
1507         * WebKitTestRunner/ios/TestControllerIOS.mm:
1508         (WTR::TestController::platformInitialize):
1509         (WTR::TestController::platformResetStateToConsistentValues):
1510
1511 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1512
1513         [Curl] Add Server Trust Evaluation Support.
1514         https://bugs.webkit.org/show_bug.cgi?id=191646
1515
1516         Reviewed by Fujii Hironori.
1517
1518         Implemented MiniBrowser UI for asking if user trusts the server.
1519
1520         * MiniBrowser/win/Common.cpp:
1521         (askServerTrustEvaluation):
1522         (replaceString):
1523         * MiniBrowser/win/Common.h:
1524         * MiniBrowser/win/MiniBrowserLib.rc:
1525         * MiniBrowser/win/MiniBrowserLibResource.h:
1526         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1527         (createPEMString):
1528         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1529         (WebKitBrowserWindow::canTrustServerCertificate):
1530         * MiniBrowser/win/WebKitBrowserWindow.h:
1531
1532 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1533
1534         Implement ResizeObserver.
1535         https://bugs.webkit.org/show_bug.cgi?id=157743
1536
1537         Reviewed by Simon Fraser.
1538
1539         Support resizeObserverEnabled webPreferences.
1540
1541         * DumpRenderTree/TestOptions.cpp:
1542         (TestOptions::TestOptions):
1543         * DumpRenderTree/TestOptions.h:
1544         * DumpRenderTree/mac/DumpRenderTree.mm:
1545         (setWebPreferencesForTestOptions):
1546         * DumpRenderTree/win/DumpRenderTree.cpp:
1547         (enableExperimentalFeatures):
1548         * Scripts/webkitperl/FeatureList.pm:
1549         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1550
1551 2019-03-28  John Wilander  <wilander@apple.com>
1552
1553         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1554         https://bugs.webkit.org/show_bug.cgi?id=196281
1555         <rdar://problem/48938748>
1556
1557         Reviewed by Alex Christensen.
1558
1559         This patch adds the function isStatisticsHasLocalStorage() to the
1560         TestRunner. With it, the page can query the WebsiteDataStore in the
1561         UI process to make sure that it sees LocalStorage.
1562
1563         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1564         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1565         (WTR::TestRunner::isStatisticsHasLocalStorage):
1566         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1567         * WebKitTestRunner/TestController.cpp:
1568         (WTR::TestController::isStatisticsHasLocalStorage):
1569         * WebKitTestRunner/TestController.h:
1570         * WebKitTestRunner/TestInvocation.cpp:
1571         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1572
1573 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1574
1575         API::Data::createWithoutCopying should do a null check before calling CFRelease
1576         https://bugs.webkit.org/show_bug.cgi?id=196276
1577         <rdar://problem/48059859>
1578
1579         Reviewed by Alex Christensen.
1580
1581         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1582
1583         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1584         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1585         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1586         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1587         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1588         (TestWebKitAPI::TEST):
1589
1590 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1591
1592         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1593         https://bugs.webkit.org/show_bug.cgi?id=186276
1594
1595         Reviewed by Carlos Garcia Campos.
1596
1597         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1598         (webViewLoadChanged):
1599         (testWebResourceGetDataError):
1600         (testWebResourceGetDataEmpty):
1601         (beforeAll):
1602         (webViewloadChanged): Deleted.
1603
1604 2019-03-27  Andy Estes  <aestes@apple.com>
1605
1606         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1607         https://bugs.webkit.org/show_bug.cgi?id=196317
1608
1609         Reviewed by Dan Bernstein.
1610
1611         package-root copies built products into a staging directory using ditto(1), which does not
1612         follow symbolic links as it traverses a directory. Now that the files in
1613         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1614         itself, these become broken links when ditto'd into the staging directory.
1615
1616         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1617
1618         * Scripts/package-root:
1619
1620 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1621
1622         [ews-app] Update display text of Submit for ews analysis
1623         https://bugs.webkit.org/show_bug.cgi?id=196309
1624
1625         Reviewed by Dewei Zhu.
1626
1627         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1628
1629 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1630
1631         run-webkit-tests should check for leaks in WebKit processes
1632         <https://webkit.org/b/193772>
1633         <rdar://problem/46526680>
1634
1635         Reviewed by Ryosuke Niwa.
1636
1637         This works by doing the following:
1638         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1639           The list of child processes are returned one per line:
1640           process.name: pid
1641         - Run the "#LIST CHILD PROCESSES" command just before the
1642           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1643           processes on the ServerProcess object.
1644         - When the `--leaks` switch is handled, run check_for_leaks() on
1645           each child process after the main test harness.
1646
1647         * DumpRenderTree/mac/DumpRenderTree.mm:
1648         (handleControlCommand):
1649         - Use strncmp() instead of strcmp().
1650         - Add support for handling "#LIST CHILD PROCESSES" command.
1651
1652         * Scripts/webkitpy/port/base.py:
1653         (Port.check_for_leaks):
1654         * Scripts/webkitpy/port/darwin.py:
1655         (DarwinPort.check_for_leaks):
1656         - Rename redundant 'process_pid' argument to 'process_id'.
1657
1658         * Scripts/webkitpy/port/driver.py:
1659         (Driver.do_post_tests_work):
1660         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1661           longer the only command this sends to WebKitTestRunner.
1662         - If the `--leaks` switch is present, send the
1663           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1664           result using Port.set_webkit_processes().
1665         (Driver._parse_child_processes_output):
1666         - Add helper method to parse list of child process names and
1667           process IDs returned from WebKitTestRunner.
1668
1669         * Scripts/webkitpy/port/ios_device.py:
1670         (IOSDevicePort.check_for_leaks):
1671         - Rename redundant 'process_pid' argument to 'process_id'.
1672
1673         * Scripts/webkitpy/port/leakdetector.py:
1674         (LeakDetector._parse_leaks_output):
1675         - Return early if there is no leaks_output.
1676         (LeakDetector.check_for_leaks):
1677         - Rename redundant 'process_pid' argument to 'process_id'.
1678
1679         * Scripts/webkitpy/port/server_process.py:
1680         (ServerProcess.__init__):
1681         (ServerProcess.child_processes):
1682         (ServerProcess.set_child_processes):
1683         - Add instance variable to Port to store list of child process
1684           names and process IDs returned from WebKitTestRunner.
1685         (ServerProcess._start):
1686         - Clear self._child_processes.
1687         (ServerProcess.stop):
1688         - If self._child_processes is set, call
1689           self._port.check_for_leaks() for each child process.
1690
1691         * Scripts/webkitpy/port/server_process_unittest.py:
1692         (TrivialMockPort.check_for_leaks):
1693         - Rename redundant 'process_pid' argument to 'process_id'.
1694
1695         * Scripts/webkitpy/port/simulator_process.py:
1696         (SimulatorProcess.stop):
1697         - If self._child_processes is set, call
1698           self._port.check_for_leaks() for each child process.
1699
1700         * Scripts/webkitpy/port/watch_device.py:
1701         (WatchDevicePort.check_for_leaks):
1702         - Rename redundant 'process_pid' argument to 'process_id'.
1703
1704         * WebKitTestRunner/TestController.cpp:
1705         (WTR::TestController::dumpResponse):
1706         - Extract method from findAndDumpWorldLeaks() so that it may be
1707           reused by findAndDumpWebKitProcessIdentifiers().
1708         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1709         - Add method to output process name and process ID of both the
1710           WebContent and Networking processes.
1711         (WTR::TestController::findAndDumpWorldLeaks):
1712         - Fix missing newline in output when there were no abandoned
1713           documents.
1714         - Call dumpResponse() for extracted code.
1715         (WTR::TestController::handleControlCommand):
1716         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1717         - Use strncmp() instead of strcmp().
1718         - Call findAndDumpWebKitProcessIdentifiers() when
1719           "#LIST CHILD PROCESSES" command is sent.
1720         * WebKitTestRunner/TestController.h:
1721         (WTR::TestController::dumpResponse):
1722         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1723         - Declare methods.
1724
1725 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1726
1727         Unreviewed. Add GLib API test cases after r243434.
1728
1729         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1730         (testWebViewActiveURI):
1731         (serverCallback):
1732         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1733         (sendRequestCallback):
1734
1735 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1736
1737         Geolocation request not complete when watch request was started in a different web process
1738         https://bugs.webkit.org/show_bug.cgi?id=195996
1739
1740         Reviewed by Alex Christensen.
1741
1742         Add a test case.
1743
1744         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1745         (TestWebKitAPI::runJavaScriptAlert):
1746         (TestWebKitAPI::TEST):
1747
1748 2019-03-26  Keith Rollin  <krollin@apple.com>
1749
1750         Update the way generate-xcfilelists returns strings from functions
1751         https://bugs.webkit.org/show_bug.cgi?id=195975
1752         <rdar://problem/49040807>
1753
1754         Reviewed by Dean Jackson.
1755
1756         There are places where generate-xcfilelists executes assignments with
1757         statements like:
1758
1759             FOO=$(some_function)
1760
1761         where "some_function" return a string by echoing it. E.g.
1762
1763             some_function()
1764             {
1765                 echo "Hello, World"
1766             }
1767
1768         This is a common idiom, but it has a problem if "some_function" needs
1769         to call "exit" in an attempt to halt the entire script right then and
1770         there. Since "some_function" is called inside of $(), it's being
1771         executed in a sub-shell. Calling exit in that sub-shell simply exits
1772         that shell; it doesn't not exit the outer shell in which the main part
1773         of the script is still running. As such, the main script keeps
1774         executing when the intent was for the script to halt.
1775
1776         The solution to this is to use a different idiom for returning
1777         strings. The one we now is to pass in the name of the variable to
1778         receive the string result:
1779
1780             some_function()
1781             {
1782                 variable_name=$1
1783                 eval $variable_name ="Hello, World"
1784             }
1785
1786         The call site now looks like
1787
1788             some_function FOO
1789
1790         Because there's no invocation of a sub-shell, some_function can now
1791         call "exit" if it wants to, and the entire script will exit at that
1792         point.
1793
1794         * Scripts/generate-xcfilelists:
1795
1796 2019-03-26  Chris Dumez  <cdumez@apple.com>
1797
1798         Add basic layout test coverage for File Picker on iOS
1799         https://bugs.webkit.org/show_bug.cgi?id=196265
1800
1801         Reviewed by Wenson Hsieh.
1802
1803         Add layout test infrastructure to test the file picker on iOS.
1804
1805         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1806         (WTR::UIScriptController::dismissFilePicker):
1807         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1808         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1809         (WTR::UIScriptController::dismissFilePicker):
1810         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1811         * WebKitTestRunner/TestController.cpp:
1812         (WTR::TestController::createWebViewWithOptions):
1813         (WTR::updateTestOptionsFromTestHeader):
1814         * WebKitTestRunner/TestOptions.h:
1815         (WTR::TestOptions::hasSameInitializationOptions const):
1816         * WebKitTestRunner/ios/TestControllerIOS.mm:
1817         (overridePresentViewController):
1818         (WTR::TestController::platformInitialize):
1819         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1820         (WTR::UIScriptController::dismissFilePicker):
1821
1822 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1823
1824         Implement async paste method on UIWKInteractionViewProtocol
1825         https://bugs.webkit.org/show_bug.cgi?id=196267
1826         <rdar://problem/49236346>
1827
1828         Reviewed by Tim Horton.
1829
1830         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1831         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1832         are now a part of all iOS 12 internal SDKs.
1833
1834         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1835
1836         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1837         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1838
1839         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1840         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1841         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1842         * TestWebKitAPI/ios/UIKitSPI.h:
1843
1844 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1845
1846         [ews-build] Use PostgreSQL for ews.webkit.org database
1847         https://bugs.webkit.org/show_bug.cgi?id=196270
1848
1849         Reviewed by Lucas Forschler.
1850
1851         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1852
1853 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1854
1855         [ews] Reset simctl states on reboot
1856         https://bugs.webkit.org/show_bug.cgi?id=196260
1857
1858         Rubber-stamped by Aakash Jain.
1859
1860         * EWSTools/start-queue-mac.sh:
1861
1862 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1863
1864         [ews-build] Use PostgreSQL for ews-build database
1865         https://bugs.webkit.org/show_bug.cgi?id=196229
1866
1867         Reviewed by Lucas Forschler.
1868
1869         * BuildSlaveSupport/ews-build/master.cfg:
1870
1871 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1872
1873         [ews-build] Get master_hostname dynamically in master.cfg
1874         https://bugs.webkit.org/show_bug.cgi?id=196255
1875
1876         Reviewed by Lucas Forschler.
1877
1878         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1879         send events data in test mode.
1880
1881 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1882
1883         [ews-app] Set db_constraint to False for Foreign Keys
1884         https://bugs.webkit.org/show_bug.cgi?id=196252
1885
1886         Reviewed by Lucas Forschler.
1887
1888         * BuildSlaveSupport/ews-app/ews/models/build.py:
1889         * BuildSlaveSupport/ews-app/ews/models/step.py:
1890
1891 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1892
1893         [ews-build] is_test_mode_enabled should default to True
1894         https://bugs.webkit.org/show_bug.cgi?id=196248
1895
1896         Reviewed by Lucas Forschler.
1897
1898         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1899
1900 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1901
1902         [ews-app] Add webkitperl to ENABLED_QUEUES
1903         https://bugs.webkit.org/show_bug.cgi?id=196253
1904
1905         Reviewed by Lucas Forschler.
1906
1907         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1908
1909 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1910
1911         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1912         https://bugs.webkit.org/show_bug.cgi?id=196211
1913         rdar://problem/49110552
1914
1915         Reviewed by Tim Horton.
1916
1917         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1918         Make sure that EventSenderProxy always exists when running tests. We used to create
1919         it when resetting before the first test, which is a bit too late.
1920
1921         * WebKitTestRunner/TestController.h:
1922         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1923         (WTR::TestController::platformCreateWebView):
1924         (WTR::TestController::platformCreateOtherPage):
1925         (WTR::TestController::finishCreatingPlatformWebView):
1926         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1927         (WTR::PlatformWebView::PlatformWebView):
1928         Moved some code that made NSWindow use NSEvent during web view creation. We may
1929         need to move more if some other case us found, but this is enough for now.
1930
1931 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1932
1933         Unreviewed. Fix typo in GLib geolocation API after r243285.
1934
1935         gelocation -> geolocation.
1936
1937         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1938         (testGeolocationManagerWatchPosition):
1939
1940 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1941
1942         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1943         https://bugs.webkit.org/show_bug.cgi?id=196213
1944
1945         Reviewed by Geoff Garen.
1946
1947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1948         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1949         (credentialWithIdentityAndKeychainPath):
1950         (-[ChallengeDelegate webView:didFinishNavigation:]):
1951         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1952         (TestWebKitAPI::TEST):
1953
1954 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1955
1956         Expected shouldn't assume its contained types are copyable
1957         https://bugs.webkit.org/show_bug.cgi?id=195986
1958
1959         Reviewed by JF Bastien.
1960
1961         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1962         (TestWebKitAPI::NonCopyable::operator== const):
1963         (TestWebKitAPI::NonCopyable::operator!= const):
1964         (TestWebKitAPI::TEST):
1965
1966 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1967
1968         Remove some now-unnecessary dynamic class lookup
1969         https://bugs.webkit.org/show_bug.cgi?id=196237
1970
1971         Reviewed by Simon Fraser.
1972
1973         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1974         (makeRequest):
1975         (TEST):
1976
1977 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1978
1979         Unreviewed, rolling out r243450.
1980
1981         AppleWin and WinCairo port builds get broken.
1982
1983         Reverted changeset:
1984
1985         "Add test for fix of #196095"
1986         https://bugs.webkit.org/show_bug.cgi?id=196097
1987         https://trac.webkit.org/changeset/243450
1988
1989 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1990
1991         Unreviewed, rolling out r243465.
1992         https://bugs.webkit.org/show_bug.cgi?id=196226
1993
1994         the test doesn't build (Requested by thorton on #webkit).
1995
1996         Reverted changeset:
1997
1998         "Do not terminate the NetworkProcess if a third party
1999         application sends a NSCredential with a SecIdentityRef"
2000         https://bugs.webkit.org/show_bug.cgi?id=196213
2001         https://trac.webkit.org/changeset/243465
2002
2003 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2004
2005         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2006         https://bugs.webkit.org/show_bug.cgi?id=196213
2007
2008         Reviewed by Geoff Garen.
2009
2010         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2011         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2012         (credentialWithIdentityAndKeychainPath):
2013         (-[ChallengeDelegate webView:didFinishNavigation:]):
2014         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2015         (TestWebKitAPI::TEST):
2016
2017 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2018
2019         [ews-build] Gracefully handle missing patch_id in events
2020         https://bugs.webkit.org/show_bug.cgi?id=196216
2021
2022         Reviewed by Lucas Forschler.
2023
2024         * BuildSlaveSupport/ews-build/events.py:
2025
2026 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2027
2028         [ews-build] use lz4 compression for improving buildbot performance
2029         https://bugs.webkit.org/show_bug.cgi?id=196155
2030
2031         Reviewed by Lucas Forschler.
2032
2033         * BuildSlaveSupport/ews-build/master.cfg:
2034
2035 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2036
2037         Pull some API testing helper methods out of TestWKWebView
2038         https://bugs.webkit.org/show_bug.cgi?id=196212
2039
2040         Reviewed by Tim Horton.
2041
2042         Refactor some more API testing utility methods, so that they can be used in
2043         tests that do not use TestWKWebView.
2044
2045         * TestWebKitAPI/cocoa/TestWKWebView.h:
2046         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2047         (-[WKWebView loadTestPageNamed:]):
2048         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2049         (-[WKWebView synchronouslyLoadHTMLString:]):
2050         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2051         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2052         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2053         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2054         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2055
2056 2019-03-25  Jer Noble  <jer.noble@apple.com>
2057
2058         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2059         https://bugs.webkit.org/show_bug.cgi?id=196097
2060
2061         Reviewed by Eric Carlson.
2062
2063         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2064
2065         * DumpRenderTree/mac/DumpRenderTree.mm:
2066         (resetWebPreferencesToConsistentValues):
2067         * WebKitTestRunner/TestController.cpp:
2068         (WTR::TestController::resetPreferencesToConsistentValues):
2069
2070 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2071
2072         Pull IPadUserInterfaceSwizzler out into a separate header file
2073         https://bugs.webkit.org/show_bug.cgi?id=196193
2074
2075         Reviewed by Anders Carlsson.
2076
2077         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2078         be used in other API tests.
2079
2080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2081         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2082         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2083         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2084         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2085         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2086         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2087
2088 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2089
2090         Remove NavigatorContentUtils in WebCore/Modules
2091         https://bugs.webkit.org/show_bug.cgi?id=196070
2092
2093         Reviewed by Alex Christensen.
2094
2095         NavigatorContentUtils was to support the custom scheme spec [1].
2096         However, in WebKit side, no port has supported the feature in
2097         WebKit layer after EFL port was removed. So there has been the
2098         only IDL implementation of the NavigatorContentUtils in WebCore.
2099         So we don't need to keep the implementation in WebCore anymore.
2100
2101         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2102
2103         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2104
2105 2019-03-24  Andy Estes  <aestes@apple.com>
2106
2107         [watchOS] Remove unused Proximity Networking code
2108         https://bugs.webkit.org/show_bug.cgi?id=196188
2109
2110         Reviewed by Tim Horton.
2111
2112         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2113         (TEST):
2114
2115 2019-03-23  Keith Miller  <keith_miller@apple.com>
2116
2117         Refactor clz/ctz and fix getLSBSet.
2118         https://bugs.webkit.org/show_bug.cgi?id=196162
2119
2120         Reviewed by Saam Barati.
2121
2122         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2123
2124         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2125         (TestWebKitAPI::TEST):
2126
2127 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2128
2129         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2130         https://bugs.webkit.org/show_bug.cgi?id=196143
2131
2132         Reviewed by Michael Catanzaro.
2133
2134         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2135         directories.
2136
2137         * Scripts/webkitpy/style/checkers/cpp.py:
2138         (check_identifier_name_in_declaration):
2139         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2140         (WebKitStyleTest.test_names):
2141
2142 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2143
2144         [Flatpak] Manifest expanding fails for qt WPE extension
2145         https://bugs.webkit.org/show_bug.cgi?id=196148
2146
2147         Reviewed by Alex Christensen.
2148
2149         * flatpak/flatpakutils.py:
2150         (expand_submodules_recurse): The last recurse manifest expand
2151         iteration might lead to a single module so take it into account
2152         and don't try to recurse further.
2153
2154 2019-03-22  Chris Dumez  <cdumez@apple.com>
2155
2156         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2157         https://bugs.webkit.org/show_bug.cgi?id=195348
2158         <rdar://problem/48622090>
2159
2160         Reviewed by Alex Christensen.
2161
2162         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2163         to NO when test.options().shouldIgnoreMetaViewport is false.
2164
2165         * WebKitTestRunner/ios/TestControllerIOS.mm:
2166         (WTR::TestController::platformConfigureViewForTest):
2167
2168 2019-03-22  Chris Dumez  <cdumez@apple.com>
2169
2170         Prewarmed processes should be usable with any website data store
2171         https://bugs.webkit.org/show_bug.cgi?id=196104
2172
2173         Reviewed by Alex Christensen.
2174
2175         Add API test coverage.
2176
2177         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2178         (runInitialWarmedProcessUsedTest):
2179         (TEST):
2180
2181 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2182
2183         Back out local changes to Alex's Subversion working directory
2184
2185         They were accidentally committed.
2186
2187         * Scripts/webkitpy/common/system/abstractexecutive.py:
2188         (AbstractExecutive.wait_newest):
2189         * Scripts/webkitpy/common/system/executive.py:
2190         (Executive.running_pids):
2191         * Scripts/webkitpy/common/system/executive_mock.py:
2192         (MockExecutive.running_pids):
2193         * Scripts/webkitpy/common/system/executive_unittest.py:
2194         (ExecutiveTest.serial_test_running_pids):
2195         * Scripts/webkitpy/port/darwin.py:
2196         (DarwinPort.check_for_leaks):
2197         * Scripts/webkitpy/port/leakdetector.py:
2198         (LeakDetector.check_for_leaks):
2199         - This was the hack attached to Bug 193772.
2200
2201         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2202         (+[WebKitTestRunnerEvent mouseLocation]):
2203         - This works around a crash on an internal build.
2204
2205 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2206
2207         Fix the build after r243354
2208         https://bugs.webkit.org/show_bug.cgi?id=196138
2209         <rdar://problem/49145951>
2210
2211         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2212         (TEST):
2213         * TestWebKitAPI/ios/UIKitSPI.h:
2214
2215 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2216
2217         Adopt UIWKDocumentContext
2218         https://bugs.webkit.org/show_bug.cgi?id=196040
2219         <rdar://problem/48642440>
2220
2221         Reviewed by Ryosuke Niwa.
2222
2223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2224         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2225         (makeRequest):
2226         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2227         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2228         (applyStyle):
2229         (TEST):
2230         Add tests for UIWKDocumentContext.
2231
2232         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2233         (TEST):
2234         (recursiveFindWKContentView): Deleted.
2235         * TestWebKitAPI/cocoa/TestWKWebView.h:
2236         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2237         (recursiveFindWKContentView):
2238         (-[TestWKWebView wkContentView]):
2239         * TestWebKitAPI/ios/UIKitSPI.h:
2240         Share the WKContentView finding code between tests.
2241
2242 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2243
2244         [iOS WK2] Turn on async overflow scrolling by default
2245         https://bugs.webkit.org/show_bug.cgi?id=196011
2246         rdar://problem/48453859
2247
2248         Reviewed by Antti Koivisto.
2249         
2250         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2251         since so many basic layout tests have different results when compositing is triggered for
2252         overflow.
2253         
2254         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2255
2256         * WebKitTestRunner/TestController.cpp:
2257         (WTR::TestController::resetPreferencesToConsistentValues):
2258
2259 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2260
2261         [ews-build] Retry API test in case of failures
2262         https://bugs.webkit.org/show_bug.cgi?id=196004
2263
2264         Reviewed by Lucas Forschler.
2265
2266         * BuildSlaveSupport/ews-build/steps.py:
2267         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2268         (CompileWebKitToT.doStepIf): Ditto.
2269         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2270         (ReRunAPITests): Re-run API tests.
2271         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2272         (RunAPITestsWithoutPatch): Run API tests without patch.
2273         (RunAPITestsWithoutPatch.doStepIf):
2274         (RunAPITestsWithoutPatch.hideStepIf):
2275         (RunAPITestsWithoutPatch.evaluateCommand):
2276         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2277         (AnalyzeAPITestsResults.start):
2278         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2279         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2280         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2281         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2282
2283 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2284
2285         [ews-build] Update queues configurations
2286         https://bugs.webkit.org/show_bug.cgi?id=196074
2287
2288         Reviewed by Dewei Zhu.
2289
2290         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2291         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2292
2293 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2294
2295         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2296         https://bugs.webkit.org/show_bug.cgi?id=195680
2297         <rdar://problem/48903534>
2298
2299         Unreviewed infrastructure fix.
2300
2301         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2302         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2303
2304 2019-03-21  Andy Estes  <aestes@apple.com>
2305
2306         [iOS] Apple Pay should be available in documents with no user agent scripts
2307         https://bugs.webkit.org/show_bug.cgi?id=196061
2308         <rdar://problem/48649391>
2309
2310         Reviewed by Brady Eidson.
2311
2312         Added API tests and related infrastructure.
2313
2314         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2315         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2316         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2317         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2318         (TestWebKitAPI::TEST):
2319         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2320         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2321         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2322         * TestWebKitAPI/cocoa/TestProtocol.mm:
2323         (-[TestProtocol startLoading]):
2324         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2325         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2326         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2327         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2328
2329 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2330
2331         REGRESSSION (r243297): webkitpy tests broken
2332         https://bugs.webkit.org/show_bug.cgi?id=196108
2333
2334         Reviewed by Aakash Jain.
2335
2336         r243297 updated contributors.json, which broke a few unit tests.
2337
2338         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2339         (IRCCommandTest.test_whois):
2340         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2341
2342 2019-03-21  Chris Dumez  <cdumez@apple.com>
2343
2344         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2345         https://bugs.webkit.org/show_bug.cgi?id=196041
2346         <rdar://problem/49083230>
2347
2348         Reviewed by Alex Christensen.
2349
2350         Add API test coverage.
2351
2352         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2353         (TEST):
2354
2355 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2356
2357         Add SPI to inform applications of WKContentRuleList actions
2358         https://bugs.webkit.org/show_bug.cgi?id=195965
2359         <rdar://problem/42664365>
2360
2361         Reviewed by Geoff Garen.
2362
2363         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2364         (TestWebKitAPI::allActionsForResourceLoad):
2365         (TestWebKitAPI::testRequest):
2366         (TestWebKitAPI::TEST_F):
2367         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2368         (Notification::description):
2369         (Notification::operator== const):
2370         (toVector):
2371         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2372         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2373         (makeContentRuleList):
2374         (TEST):
2375         (makeWarnContentRuleList): Deleted.
2376
2377 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2378
2379         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2380         https://bugs.webkit.org/show_bug.cgi?id=196088
2381
2382         Reviewed by Brian Burg.
2383
2384         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2385         Support checks when only one platform is specified. Also deprecate macosx() and
2386         force the use of macos() instead.
2387
2388         * Scripts/webkitpy/style/checkers/cpp.py:
2389         (check_min_versions_of_wk_api_available):
2390         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2391         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2392
2393 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2394
2395         Update status inactive committers' status to 'contributor'.
2396
2397         * Scripts/webkitpy/common/config/contributors.json:
2398
2399 2019-03-21  Xan Lopez  <xan@igalia.com>
2400
2401         [JSC][x86] Drop support for x87 floating point
2402         https://bugs.webkit.org/show_bug.cgi?id=194853
2403
2404         Reviewed by Don Olmstead.
2405
2406         Force SSE2 on x86/32bit builds.
2407
2408         * Scripts/webkitdirs.pm:
2409         (generateBuildSystemFromCMakeProject):
2410
2411 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2412
2413         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2414         https://bugs.webkit.org/show_bug.cgi?id=196073
2415
2416         Reviewed by Michael Catanzaro.
2417
2418         Add test cases to check functions and constructors with no arguments but receiving user data.
2419
2420         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2421         (checkUserData):
2422         (testJSCFunction):
2423         (fooCreateWithUserData):
2424         (testJSCClass):
2425
2426 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2427
2428         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2429
2430         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2431
2432         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2433
2434 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2435
2436         [GTK][WPE] Add API to provide geolocation information
2437         https://bugs.webkit.org/show_bug.cgi?id=195940
2438
2439         Reviewed by Michael Catanzaro.
2440
2441         Add a new test to check the new API.
2442
2443         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2444         (testGeolocationManagerCurrentPosition):
2445         (testGeolocationManagerWatchPosition):
2446         (beforeAll):
2447         (afterAll):
2448         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2449         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2450         (beforeAll): Ditto.
2451         * TestWebKitAPI/glib/CMakeLists.txt:
2452
2453 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2454
2455         [GLib] Returning G_TYPE_OBJECT from a method does not work
2456         https://bugs.webkit.org/show_bug.cgi?id=195574
2457
2458         Reviewed by Michael Catanzaro.
2459
2460         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2461
2462         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2463         (getGFile):
2464         (getParent):
2465         (createGString):
2466         (getGString):
2467         (getGStringCopyWillRaise):
2468         (getGStringCopy):
2469         (getGStringStr):
2470         (getGStringLen):
2471         (freeGString):
2472         (testJSCClass):
2473
2474 2019-03-20  Saam Barati  <sbarati@apple.com>
2475
2476         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2477         https://bugs.webkit.org/show_bug.cgi?id=195721
2478
2479         Reviewed by Filip Pizlo.
2480
2481         * Scripts/run-javascriptcore-tests:
2482
2483 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2484
2485         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2486         https://bugs.webkit.org/show_bug.cgi?id=196049
2487
2488         Reviewed by Tim Horton.
2489
2490         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2491         overflow scrolling in general, so rename it.
2492
2493         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2494
2495 2019-03-20  Daniel Bates  <dabates@apple.com>
2496
2497         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2498         https://bugs.webkit.org/show_bug.cgi?id=196031
2499         <rdar://problem/49078172>
2500
2501         Reviewed by Tim Horton.
2502
2503         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2504         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2505         same code path used when the Done button is pressed to dismiss the <select> picker.
2506
2507         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2508         (TestWebKitAPI::TEST):
2509
2510 2019-03-20  Chris Dumez  <cdumez@apple.com>
2511
2512         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2513         https://bugs.webkit.org/show_bug.cgi?id=196029
2514         <rdar://problem/48954651>
2515
2516         Reviewed by Tim Horton.
2517
2518         Add API test coverage.
2519
2520         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2521
2522 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2523
2524         [ews-build] Improve failure summary string for ApplyPatch step
2525         https://bugs.webkit.org/show_bug.cgi?id=195995
2526
2527         Reviewed by Alexey Proskuryakov.
2528
2529         * BuildSlaveSupport/ews-build/steps.py:
2530         (ApplyPatch.getResultSummary): Override getResultSummary.
2531
2532 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2533
2534         AX: Implement support for new meter ARIA role
2535         https://bugs.webkit.org/show_bug.cgi?id=195966
2536
2537         Reviewed by Chris Fleizach.
2538
2539         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2540         to AXLevelIndicator.
2541
2542         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2543
2544 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2545
2546         [WebAuthN] Implement FIDO AppID extension
2547         https://bugs.webkit.org/show_bug.cgi?id=143491
2548         <rdar://problem/48298273>
2549
2550         Reviewed by Brent Fulgham.
2551
2552         Add a test that covers the new flag of convertToU2fSignCommand.
2553
2554         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2555         (TestWebKitAPI::TEST):
2556         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2557         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2558         (TestWebKitAPI::TEST):
2559
2560 2019-03-19  Keith Rollin  <krollin@apple.com>
2561
2562         Add support for more platforms to generate-xcfilelists
2563         https://bugs.webkit.org/show_bug.cgi?id=195977
2564
2565         Reviewed by Alexey Proskuryakov.
2566
2567         generate-xcfilelists incorrectly complains when involved with building
2568         WebKit for iphonesimulator:
2569
2570             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2571             …
2572             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2573
2574         Address this by teaching generate-xcfilelists about more platforms.
2575
2576         * Scripts/generate-xcfilelists:
2577
2578 2019-03-19  John Wilander  <wilander@apple.com>
2579
2580         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2581         https://bugs.webkit.org/show_bug.cgi?id=195923
2582         <rdar://problem/49001272>
2583
2584         Reviewed by Alex Christensen.
2585
2586         This patch does the following to the TestRunner:
2587         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2588         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2589         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2590
2591         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2592         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2593         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2594         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2595         * WebKitTestRunner/TestController.cpp:
2596         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2597         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2598         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2599         * WebKitTestRunner/TestController.h:
2600         * WebKitTestRunner/TestInvocation.cpp:
2601         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2602
2603 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2604
2605         [CMake] Support more clang and gcc sanitizers
2606         https://bugs.webkit.org/show_bug.cgi?id=195956
2607
2608         Reviewed by Michael Catanzaro.
2609
2610         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2611
2612 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2613
2614         [ews-build] Improve summary for PrintConfiguration step
2615         https://bugs.webkit.org/show_bug.cgi?id=195945
2616
2617         Reviewed by Lucas Forschler.
2618
2619         * BuildSlaveSupport/ews-build/steps.py:
2620         (PrintConfiguration.getResultSummary): Override getResultSummary.
2621
2622 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2623
2624         [ews-build] Improve summary for CheckOutSource step
2625         https://bugs.webkit.org/show_bug.cgi?id=195963
2626
2627         Reviewed by Lucas Forschler.
2628
2629         * BuildSlaveSupport/ews-build/steps.py:
2630         (CheckOutSource.getResultSummary):
2631
2632 2019-03-19  Daniel Bates  <dabates@apple.com>
2633
2634         [iOS] Focus not preserved when switching between tabs
2635         https://bugs.webkit.org/show_bug.cgi?id=195820
2636         <rdar://problem/43614450>
2637
2638         Reviewed by Brent Fulgham.
2639
2640         Add tests to ensure that we restore focus when resigning and becoming first responder.
2641
2642         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2643         (TestWebKitAPI::TEST):
2644
2645 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2646
2647         Make WTFLogChannelState and WTFLogLevel enum classes
2648         https://bugs.webkit.org/show_bug.cgi?id=195904
2649
2650         Reviewed by Eric Carlson.
2651
2652         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2653         (TestWebKitAPI::TEST_F):
2654
2655 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2656
2657         [GStreamer][EME] Backported mssdemux protection data crash fix
2658         https://bugs.webkit.org/show_bug.cgi?id=195918
2659
2660         Reviewed by Philippe Normand.
2661
2662         * gstreamer/jhbuild.modules:
2663         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2664
2665 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2666
2667         Unreviewed, rolling out r243132.
2668
2669         Broke GTK build
2670
2671         Reverted changeset:
2672
2673         "Make WTFLogChannelState and WTFLogLevel enum classes"
2674         https://bugs.webkit.org/show_bug.cgi?id=195904
2675         https://trac.webkit.org/changeset/243132
2676
2677 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2678
2679         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2680
2681         * Scripts/webkitdirs.pm:
2682         (builtDylibPathForName): Adjust the shared library name that's changed
2683         with the API version bump in r243073.
2684
2685 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2686
2687         Make WTFLogChannelState and WTFLogLevel enum classes
2688         https://bugs.webkit.org/show_bug.cgi?id=195904
2689
2690         Reviewed by Eric Carlson.
2691
2692         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2693         (TestWebKitAPI::TEST_F):
2694
2695 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2696
2697         Disable flaky test added in r2431100
2698         https://webkit.org/b/195785
2699
2700         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2701         (TestWebKitAPI::TEST):
2702         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2703
2704 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2705
2706         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2707         https://bugs.webkit.org/show_bug.cgi?id=195916
2708
2709         Reviewed by Tim Horton.
2710
2711         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2712         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2713
2714 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2715
2716         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2717
2718         * Scripts/webkitpy/common/config/contributors.json:
2719
2720 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2721
2722         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2723         https://bugs.webkit.org/show_bug.cgi?id=195785
2724
2725         Reviewed by Geoffrey Garen.
2726
2727         * TestWebKitAPI/TCPServer.cpp: Added.
2728         (TestWebKitAPI::TCPServer::TCPServer):
2729         (TestWebKitAPI::TCPServer::~TCPServer):
2730         (TestWebKitAPI::TCPServer::socketBindListen):
2731         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2732         * TestWebKitAPI/TCPServer.h: Added.
2733         (TestWebKitAPI::TCPServer::port const):
2734         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2735         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2736         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2737         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2738         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2739         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2740         (TestWebKitAPI::respondSlowly):
2741         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2742         (TestWebKitAPI::downloadAtRate):
2743         (TestWebKitAPI::TEST):
2744
2745 2019-03-18  Saam Barati  <sbarati@apple.com>
2746
2747         Add a plan file for JetStream 2
2748         https://bugs.webkit.org/show_bug.cgi?id=190734
2749
2750         Reviewed by Mark Lam.
2751
2752         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2753
2754 2019-03-18  Chris Dumez  <cdumez@apple.com>
2755
2756         Delay WebProcess launch until a load is triggered in a Web view
2757         https://bugs.webkit.org/show_bug.cgi?id=195758
2758         <rdar://problem/48126013>
2759
2760         Reviewed by Geoff Garen.
2761
2762         Add API test coverage. Also update some existing API tests to not expect
2763         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2764
2765         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2766         (TestWebKitAPI::TEST):
2767         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2768         (TestWebKitAPI::TEST):
2769         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2770         (TEST):
2771         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2772         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2773         (TEST):
2774         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2775         (TEST):
2776         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2777
2778 2019-03-18  Xan Lopez  <xan@igalia.com>
2779
2780         [CMake] Prevent potential warning when determining $architecture
2781         https://bugs.webkit.org/show_bug.cgi?id=195891
2782
2783         Reviewed by Michael Catanzaro.
2784
2785         It's possible for generateBuildSystemForCMakeProject to be called
2786         before determineArchitecture() is ever called. This will make the
2787         first eq check with $architecture to be bogus (and print a
2788         warning). Change that to an eq check with architecture(), which
2789         implicitly calls determineArchitecture() if needed, and change all
2790         the other similar cases in the method in the same way to prevent
2791         future bugs like this one.
2792
2793         * Scripts/webkitdirs.pm:
2794         (generateBuildSystemFromCMakeProject):
2795
2796 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2797
2798         [WPE] Tarballs generated with “make dist” cannot build documentation
2799         https://bugs.webkit.org/show_bug.cgi?id=195885
2800
2801         Reviewed by Carlos Garcia Campos.
2802
2803         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2804
2805 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2806
2807         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2808         https://bugs.webkit.org/show_bug.cgi?id=195883
2809
2810         Reviewed by Carlos Garcia Campos.
2811
2812         * gtkdoc/gtkdoc.py:
2813         (GTKDoc._run_command): When commands fail to run, include the full command line for
2814         the program invocation and the output it has generated on the standard error stream.
2815
2816 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2817
2818         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2819         https://bugs.webkit.org/show_bug.cgi?id=195786
2820
2821         Reviewed by Philippe Normand.
2822
2823         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2824         * wpe/jhbuild.modules: Ditto.
2825
2826 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2827
2828         [ews-build] Don't run clean builds on EWS builders
2829         https://bugs.webkit.org/show_bug.cgi?id=195851
2830
2831         Reviewed by Geoffrey Garen.
2832
2833         * BuildSlaveSupport/ews-build/factories.py:
2834
2835 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2836
2837         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2838         https://bugs.webkit.org/show_bug.cgi?id=195849
2839
2840         Reviewed by Chris Dumez.
2841
2842         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2843
2844         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2845         (runWebsiteDataStoreCustomPaths):
2846
2847 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2848
2849         webkitpy: Upload test results
2850         https://bugs.webkit.org/show_bug.cgi?id=195755
2851         <rdar://problem/48896182>
2852
2853         Reviewed by Aakash Jain.
2854
2855         Establish a new format for uploading results that is not tied to layout tests, apply
2856         that format to webkitpy tests.
2857
2858         * Scripts/webkitpy/common/checkout/scm/git.py:
2859         (Git.native_branch): Return what branch the current checkout is on.
2860         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2861         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2862         * Scripts/webkitpy/common/checkout/scm/svn.py:
2863         (SVN.native_branch): Ditto.
2864         * Scripts/webkitpy/common/system/platforminfo.py:
2865         (PlatformInfo.build_version): Return a build version for Mac.
2866         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2867         (MockPlatformInfo.__init__):
2868         (MockPlatformInfo.build_version):
2869         * Scripts/webkitpy/results: Added.
2870         * Scripts/webkitpy/results/__init__.py: Added.
2871         * Scripts/webkitpy/results/options.py: Added.
2872         (upload_options): OptParse list for upload options.
2873         * Scripts/webkitpy/results/upload.py: Added.
2874         (Upload): Class which enforces the upload format expected by the results server.
2875         (Upload.Expectations):
2876         (Upload.create_configuration):
2877         (Upload.create_commit):
2878         (Upload.create_details):
2879         (Upload.create_run_stats):
2880         (Upload.create_test_result):
2881         (Upload.__init__):
2882         (Upload.Encoder): Encode Upload object as json.
2883         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2884         * Scripts/webkitpy/results/upload_unittest.py: Added.
2885         * Scripts/webkitpy/test/main.py:
2886         (Tester._parse_args): Add upload arguments.
2887         (Tester._run_tests): Allow results to be uploaded.
2888         * Scripts/webkitpy/test/runner.py:
2889         (Runner.__init__): Record which tests were run, rather than just counting them.
2890         (Runner.handle):
2891         * Scripts/webkitpy/test/runner_unittest.py:
2892         (RunnerTest.test_run):
2893         * Scripts/webkitpy/thirdparty/__init__.py:
2894         (AutoinstallImportHook.find_module): Add requests auto-install.
2895         (AutoinstallImportHook._install_requests):
2896         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2897         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2898
2899 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2900
2901         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2902         https://bugs.webkit.org/show_bug.cgi?id=195810
2903
2904         Reviewed by Tim Horton.
2905
2906         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2907         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2908         ending certain layout tests.
2909
2910         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2911         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2912         (-[TestRunnerWKWebView dealloc]):
2913         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2914
2915         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2916         helper method when destroying the web view, and when resetting state between tests.
2917
2918         * WebKitTestRunner/ios/TestControllerIOS.mm:
2919         (WTR::TestController::platformResetStateToConsistentValues):
2920
2921         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2922
2923 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2924
2925         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2926         https://bugs.webkit.org/show_bug.cgi?id=190350
2927         <rdar://problem/45089503>
2928
2929         Reviewed by Geoffrey Garen.
2930
2931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2932         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2933         (TEST):
2934         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2935         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2936         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2937         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2938         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2939         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2940         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2941         (runTest):
2942         (createDirectories):
2943         (TEST):
2944         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2945         (TEST):
2946         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2947         (TEST):
2948
2949 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2950
2951         Add support to WebPage for getting the contents as an attributed string.
2952         https://bugs.webkit.org/show_bug.cgi?id=195636
2953         rdar://problem/45055697
2954
2955         Reviewed by Tim Horton.
2956
2957         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2958         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2959
2960 2019-03-15  Chris Dumez  <cdumez@apple.com>
2961
2962         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2963         https://bugs.webkit.org/show_bug.cgi?id=195747
2964
2965         Reviewed by Geoff Garen.
2966
2967         Add API test coverage.
2968
2969         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2970
2971 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2972
2973         Unreviewed, rolling out r242952.
2974
2975         Causing API failures on iOS Simulator
2976
2977         Reverted changeset:
2978
2979         "[PSON] Make sure the WebProcessCache is leverage when
2980         relaunching a process after termination"
2981         https://bugs.webkit.org/show_bug.cgi?id=195747
2982         https://trac.webkit.org/changeset/242952
2983
2984 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2985
2986         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2987         https://bugs.webkit.org/show_bug.cgi?id=195740
2988
2989         Reviewed by Ross Kirsling.
2990
2991         window.open doesn't work for WebKitBrowserWindow because it is not
2992         implemented yet.
2993
2994         1. Implemented createNewPage callback of WKPageUIClient.
2995         2. Changed MainWindow to take a BrowserWindow factory function
2996           instead of BrowserWindowType to be flexible to create
2997           BrowserWindow with extra settings.
2998         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2999           because it is not relevant with MainWindow anymore.
3000
3001         * MiniBrowser/win/Common.cpp:
3002         (parseCommandLine):
3003         * MiniBrowser/win/Common.h:
3004         (CommandLineOptions::CommandLineOptions):
3005         * MiniBrowser/win/MainWindow.cpp:
3006         (MainWindow::MainWindow):
3007         (MainWindow::create):
3008         (MainWindow::init):
3009         (MainWindow::WndProc):
3010         * MiniBrowser/win/MainWindow.h:
3011         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3012         (PrintWebUIDelegate::createWebViewWithRequest):
3013         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3014         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3015         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3016         (WebKitBrowserWindow::updateProxySettings):
3017         (WebKitBrowserWindow::createNewPage):
3018         * MiniBrowser/win/WebKitBrowserWindow.h:
3019         * MiniBrowser/win/WinMain.cpp:
3020         (wWinMain):
3021
3022 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3023
3024         Make it possible to test scrolling tree layer manipulation more easily
3025         https://bugs.webkit.org/show_bug.cgi?id=195780
3026
3027         Reviewed by Tim Horton.
3028         
3029         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3030         cuts off communication of scrolling tree scrolls back to the web process
3031         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3032         allows tests to trigger scrolls which run the scrolling tree layer positioning
3033         logic, but never get another commit from the web process that might mask
3034         scrolling tree bugs.
3035         
3036         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3037         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3038         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3039
3040         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3041         (WTR::UIScriptController::scrollUpdatesDisabled const):
3042         (WTR::UIScriptController::setScrollUpdatesDisabled):
3043         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3044         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3045         (WTR::UIScriptController::scrollUpdatesDisabled const):
3046         (WTR::UIScriptController::setScrollUpdatesDisabled):
3047         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3048         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3049         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3050         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3051         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3052         * WebKitTestRunner/ios/TestControllerIOS.mm:
3053         (WTR::TestController::platformResetStateToConsistentValues):
3054         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3055         (WTR::UIScriptController::scrollUpdatesDisabled const):
3056         (WTR::UIScriptController::setScrollUpdatesDisabled):
3057
3058 2019-03-14  Youenn Fablet  <youenn@apple.com>
3059
3060         Move IDB storage in private browsing mode to NetworkProcess
3061         https://bugs.webkit.org/show_bug.cgi?id=195602
3062
3063         Reviewed by Brady Eidson.
3064
3065         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3066         (TEST):
3067
3068 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3069
3070         [ews-build] Make descriptionDone messages more readable
3071         https://bugs.webkit.org/show_bug.cgi?id=195760
3072
3073         Reviewed by Lucas Forschler.
3074
3075         * BuildSlaveSupport/ews-build/steps.py:
3076         * BuildSlaveSupport/ews-build/steps_unittest.py:
3077
3078 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3079
3080         [ews-build] Generate status-bubble hover-over messages
3081         https://bugs.webkit.org/show_bug.cgi?id=195680
3082
3083         Reviewed by Lucas Forschler.
3084
3085         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3086         (StatusBubble):
3087         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3088         on hover-over.
3089         (StatusBubble._iso_time):
3090         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3091         hover-over message.
3092         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3093
3094 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3095
3096         [ews-app] Gracefully handle the case when state_string is None
3097         https://bugs.webkit.org/show_bug.cgi?id=195753
3098
3099         Reviewed by Lucas Forschler.
3100
3101         * BuildSlaveSupport/ews-app/ews/models/build.py:
3102         * BuildSlaveSupport/ews-app/ews/models/step.py:
3103
3104 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3105
3106         [ews-app] Status bubble display pending for currently running build step
3107         https://bugs.webkit.org/show_bug.cgi?id=195744
3108
3109         Reviewed by Lucas Forschler.
3110
3111         * BuildSlaveSupport/ews-build/events.py:
3112         (Events.stepStarted): If state_string is pending, replace it with step name.
3113
3114 2019-03-14  Chris Dumez  <cdumez@apple.com>
3115
3116         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3117         https://bugs.webkit.org/show_bug.cgi?id=195750
3118
3119         Reviewed by Geoffrey Garen.
3120
3121         Add API test coverage.
3122
3123         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3124         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3125         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3126         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3127
3128 2019-03-14  Chris Dumez  <cdumez@apple.com>
3129
3130         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3131         https://bugs.webkit.org/show_bug.cgi?id=195747
3132
3133         Reviewed by Geoff Garen.
3134
3135         Add API test coverage.
3136
3137         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3138
3139 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3140
3141         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3142         https://bugs.webkit.org/show_bug.cgi?id=195725
3143         <rdar://problem/48545062>
3144
3145         Reviewed by Tim Horton.
3146
3147         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3148         handler is nil.
3149
3150         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3151         (TestWebKitAPI::TEST):
3152
3153 2019-03-13  Sam Weinig  <sam@webkit.org>
3154
3155         Add utility function to allow easy reverse range-based iteration of a container
3156         https://bugs.webkit.org/show_bug.cgi?id=195542
3157
3158         Reviewed by Antti Koivisto.
3159
3160         * TestWebKitAPI/CMakeLists.txt:
3161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3162         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3163         (TestWebKitAPI::TEST):
3164         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3165
3166 2019-03-13  Chris Dumez  <cdumez@apple.com>
3167
3168         Use a ServiceWorker process per registrable domain
3169         https://bugs.webkit.org/show_bug.cgi?id=195649
3170
3171         Reviewed by Youenn Fablet.
3172
3173         Update API test coverage.
3174
3175         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3176
3177 2019-03-13  Chris Dumez  <cdumez@apple.com>
3178
3179         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3180         https://bugs.webkit.org/show_bug.cgi?id=195684
3181         <rdar://problem/48294714>
3182
3183         Reviewed by Antti Koivisto.
3184
3185         Add API test coverage.
3186
3187         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3188
3189 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3190
3191         [ews-app] Remove unused patch view
3192         https://bugs.webkit.org/show_bug.cgi?id=195669
3193
3194         Reviewed by Lucas Forschler.
3195
3196         * BuildSlaveSupport/ews-app/ews/urls.py:
3197         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3198
3199 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3200
3201         [ews-app] Use Buildbot result code variables
3202         https://bugs.webkit.org/show_bug.cgi?id=195668
3203
3204         Reviewed by Alexey Proskuryakov.
3205
3206         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3207         (Buildbot): Added Buildbot result code variables.
3208         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3209         (StatusBubble._build_bubble): Used Buildbot result code variables.
3210
3211 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3212
3213         [Flatpak] Expand submodule recursively
3214         https://bugs.webkit.org/show_bug.cgi?id=195672
3215
3216         Building WPE with flatpak was impossible without that as it was raising an exception.
3217         Also update wpebackend-fdo to match what is built in jhbuild
3218
3219         Reviewed by Philippe Normand.
3220
3221         * flatpak/flatpakutils.py:
3222         (expand_submodules_recurse):
3223         (expand_manifest):
3224         * flatpak/org.webkit.WPEModules.yaml:
3225
3226 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3227
3228         [ews-app] status bubble should be hidden for certain builds
3229         https://bugs.webkit.org/show_bug.cgi?id=194597
3230
3231         Reviewed by Dewei Zhu.
3232
3233         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3234         (StatusBubble._build_bubble):
3235         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3236         because the patch didn't have relevant changes.
3237         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3238         in production yet.
3239
3240 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3241
3242         [Win] Fix a slew of simple clang-cl warnings.
3243         https://bugs.webkit.org/show_bug.cgi?id=195652
3244
3245         Reviewed by Don Olmstead.
3246
3247         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3248         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3249
3250 2019-03-12  Justin Fan  <justin_fan@apple.com>
3251
3252         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3253         https://bugs.webkit.org/show_bug.cgi?id=195518
3254         <rdar://problem/46322356>
3255
3256         Reviewed by Myles C. Maxfield.
3257
3258         * DumpRenderTree/DerivedSources-input.xcfilelist:
3259         * DumpRenderTree/DerivedSources-output.xcfilelist:
3260
3261 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3262
3263         Unreviewed, rolling out r242825.
3264         https://bugs.webkit.org/show_bug.cgi?id=195648
3265
3266         "Broke webkitpy tests with my change to
3267         lldb_dump_class_layout.py" (Requested by rmorisset on
3268         #webkit).
3269
3270         Reverted changeset:
3271
3272         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3273         classes with suspicious padding"
3274         https://bugs.webkit.org/show_bug.cgi?id=195573
3275         https://trac.webkit.org/changeset/242825
3276
3277 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3278
3279         [ews-build] Show status bubbles while the patch is waiting in queue
3280         https://bugs.webkit.org/show_bug.cgi?id=195618
3281
3282         Reviewed by Lucas Forschler.
3283
3284         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3285         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3286         enabled in initial deployment.
3287         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3288         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3289         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3290         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3291         (StatusBubble._build_bubbles_for_patch):
3292
3293 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3294
3295         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3296         https://bugs.webkit.org/show_bug.cgi?id=195573
3297
3298         Reviewed by Simon Fraser.
3299
3300         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3301
3302         * Scripts/dump-class-layout:
3303         (main):
3304         * lldb/lldb_dump_class_layout.py:
3305         (ClassLayout.__init__):
3306         (ClassLayout._compute_padding_recursive):
3307         (LLDBDebuggerInstance.dump_layout_for_classname):
3308         (LLDBDebuggerInstance):
3309         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3310         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3311
3312 2019-03-12  Chris Dumez  <cdumez@apple.com>
3313
3314         Device Orientation access permission should be denied unless explicitly granted by the client
3315         https://bugs.webkit.org/show_bug.cgi?id=195625
3316
3317         Reviewed by Youenn Fablet.
3318
3319         add API test coverage.
3320
3321         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3322         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3323         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3324         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3325         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3326         (runDeviceOrientationTest):
3327         (TEST):
3328         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3329         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3330
3331 2019-03-12  Jer Noble  <jer.noble@apple.com>
3332
3333         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3334         https://bugs.webkit.org/show_bug.cgi?id=195137
3335         <rdar://problem/48810307>
3336
3337         Reviewed by Eric Carlson.
3338
3339         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3340         (TestWebKitAPI::TEST):
3341
3342 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3343
3344         [ews-build] Change urls from uat to production
3345         https://bugs.webkit.org/show_bug.cgi?id=195566
3346
3347         Reviewed by Lucas Forschler.
3348
3349         * BuildSlaveSupport/ews-app/ews/config.py:
3350         * BuildSlaveSupport/ews-build/events.py:
3351         * BuildSlaveSupport/ews-build/steps.py:
3352
3353 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3354
3355         [ews-build] change max_builds for local-worker to 1
3356         https://bugs.webkit.org/show_bug.cgi?id=195568
3357
3358         Reviewed by Lucas Forschler.
3359
3360         * BuildSlaveSupport/ews-build/loadConfig.py:
3361
3362 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3363
3364         Fix the build
3365
3366         * TestRunnerShared/spi/PencilKitTestSPI.h:
3367         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3368
3369 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3370
3371         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3372         https://bugs.webkit.org/show_bug.cgi?id=194131
3373
3374         Reviewed by Michael Catanzaro.
3375
3376         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3377         (uriChanged):
3378         (testUnfinishedSubresourceLoad):
3379         (serverCallback):
3380         (beforeAll):
3381
3382 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3383
3384         WTF::Expected should use std::addressof instead of operator&
3385         https://bugs.webkit.org/show_bug.cgi?id=195604
3386
3387         Reviewed by Myles Maxfield.
3388
3389         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3390         (TestWebKitAPI::Unique::Unique):
3391         (TestWebKitAPI::Unique::operator&):
3392         (TestWebKitAPI::TEST):
3393
3394 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3395
3396         Add Optional to Forward.h.
3397         https://bugs.webkit.org/show_bug.cgi?id=195586
3398
3399         Reviewed by Darin Adler.
3400
3401         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3402         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3403         Remove unnecessary includes from headers.
3404
3405 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3406
3407         Add testing API to hit-test and scroll overflow scrollers
3408         https://bugs.webkit.org/show_bug.cgi?id=195278
3409
3410         Reviewed by Antti Koivisto.
3411         
3412         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3413         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3414         
3415         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3416
3417         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3418         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3419         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3420         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3421         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3422         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3423         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3424         (WTR::enclosingScrollViewIncludingSelf):
3425         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3426
3427 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3428
3429         API test WebKit.RequestTextInputContext fails on iOS
3430         https://bugs.webkit.org/show_bug.cgi?id=195585
3431
3432         Reviewed by Wenson Hsieh and Simon Fraser.
3433
3434         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3435         (applyStyle):
3436         (TEST):
3437         Add a viewport, so that the coordinates match up on iOS.
3438         Scroll by moving the UIScrollView's contentOffset.
3439
3440 2019-03-11  Chris Dumez  <cdumez@apple.com>
3441
3442         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3443         https://bugs.webkit.org/show_bug.cgi?id=195506
3444         <rdar://problem/48733477>
3445
3446         Reviewed by Alex Christensen.
3447
3448         Add API test coverage.
3449
3450         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3451
3452 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3453
3454         Adding myself to contributors.json
3455
3456         Unreviewed, addming myself to contributors.json .
3457
3458         * Scripts/webkitpy/common/config/contributors.json:
3459
3460 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3461
3462         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3463         https://bugs.webkit.org/show_bug.cgi?id=195511
3464         <rdar://problem/44873269>
3465
3466         Reviewed by Darin Adler.
3467
3468         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3469         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3470         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3471         (TEST_F):
3472
3473 2019-03-11  Chris Dumez  <cdumez@apple.com>
3474
3475         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3476         https://bugs.webkit.org/show_bug.cgi?id=195561
3477
3478         Reviewed by Youenn Fablet.
3479
3480         Make sure the JS in the test requests for permission to receive device orientation events.
3481
3482         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3483
3484 2019-03-11  Youenn Fablet  <youenn@apple.com>
3485
3486         Allow storage quota increase by default in WTR
3487         https://bugs.webkit.org/show_bug.cgi?id=195541
3488
3489         Reviewed by Geoffrey Garen.
3490
3491         Allow storage quota increase by default in WTR.
3492         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3493         Use this for tests that explicitly need cache increase.
3494
3495         Instead of increasing quota by 2, make sure the next request is
3496         granted by adding all given parameters.
3497
3498         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3499         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3500         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3501         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3502         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3503         * WebKitTestRunner/TestController.cpp:
3504         (WTR::TestController::setAllowStorageQuotaIncrease):
3505         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3506         * WebKitTestRunner/TestController.h:
3507         * WebKitTestRunner/TestInvocation.cpp:
3508         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3509         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3510         (WTR::TestController::cocoaResetStateToConsistentValues):
3511         (WTR::TestController::setAllowStorageQuotaIncrease):
3512         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3513         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3514         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3515
3516 2019-03-11  Xan Lopez  <xan@igalia.com>
3517
3518         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3519         https://bugs.webkit.org/show_bug.cgi?id=194147
3520
3521         Reviewed by Michael Saboff.
3522
3523         To make --32-bit work correctly on Linux/64bit we need to:
3524
3525         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3526         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3527         unfortunately CMake only allows us to do this during
3528         crosscompilation, which is overkill here.
3529         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3530         pkg-config detection module uses the x86 .pc files instead of the
3531         x86_64 ones.
3532         - Set the -m32 flags for the compiler.
3533
3534         * Scripts/webkitdirs.pm:
3535         (generateBuildSystemFromCMakeProject):
3536
3537 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3538
3539         Add MotionMark-1.1 plan file for run-benchmark script.
3540         https://bugs.webkit.org/show_bug.cgi?id=195481
3541
3542         Rubber-stamped by Darin Adler.
3543
3544         Run-benchmark script should support MontionMark-1.1.
3545
3546         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3547
3548 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3549
3550         [ews-app] Add support for submit-to-ews url
3551         https://bugs.webkit.org/show_bug.cgi?id=195477
3552
3553         Reviewed by Lucas Forschler.
3554
3555         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3556         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3557         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3558         * BuildSlaveSupport/ews-app/ews/urls.py:
3559         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3560
3561 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3562
3563         Unreviewed, rolling out r242688, r242643, r242624.
3564
3565         Caused multiple layout test failures and crashes on iOS and macOS.
3566
3567         Reverted changeset:
3568
3569         "requestAnimationFrame should execute before the next frame"
3570         https://bugs.webkit.org/show_bug.cgi?id=177484
3571         https://trac.webkit.org/changeset/242624/webkit
3572
3573         * Tracing/SystemTracePoints.plist:
3574
3575 2019-03-11  John Wilander  <wilander@apple.com>
3576
3577         Resource Load Statistics: Make it possible exclude localhost from classification
3578         https://bugs.webkit.org/show_bug.cgi?id=195474
3579         <rdar://problem/47520577>
3580
3581         Reviewed by Brent Fulgham.
3582
3583         This patch allows for localhost to be excluded from classification and
3584         treatment as a prevalent resource.
3585
3586         The WebKit Tools change adds a new function called
3587         testRunner.setStatisticsIsRunningTest() which can be used to control this
3588         behavior.
3589
3590         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3591         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3592         (WTR::TestRunner::setStatisticsIsRunningTest):
3593         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3594         * WebKitTestRunner/TestController.cpp:
3595         (WTR::TestController::setStatisticsIsRunningTest):
3596         * WebKitTestRunner/TestController.h:
3597         * WebKitTestRunner/TestInvocation.cpp:
3598         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3599
3600 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3601
3602         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3603         https://bugs.webkit.org/show_bug.cgi?id=195560
3604
3605         Reviewed by Lucas Forschler.
3606
3607         * BuildSlaveSupport/ews-build/master.cfg:
3608
3609 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3610
3611         Unreviewed, rolling out r242698.
3612
3613         API test crashes on bots.
3614
3615         Reverted changeset:
3616
3617         "Add a WKContentRuleList variant that uses copied memory
3618         instead of mmap'd shared memory for class A containerized
3619         apps"
3620         https://bugs.webkit.org/show_bug.cgi?id=195511
3621         https://trac.webkit.org/changeset/242698
3622
3623 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3624
3625         [WPE] Enable web process sandbox
3626         https://bugs.webkit.org/show_bug.cgi?id=195169
3627
3628         Reviewed by Daniel Bates.
3629
3630         * wpe/install-dependencies:
3631         * wpe/jhbuild.modules:
3632
3633 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3634
3635         [ews-app] Use port 17000 for worker communication
3636         https://bugs.webkit.org/show_bug.cgi?id=195558
3637
3638         Reviewed by Lucas Forschler.
3639
3640         * BuildSlaveSupport/ews-build/master.cfg:
3641
3642 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3643
3644         [ews-build] unit-tests fail when passwords.json is missing
3645         https://bugs.webkit.org/show_bug.cgi?id=195557
3646
3647         Reviewed by Lucas Forschler.
3648
3649         * BuildSlaveSupport/ews-build/loadConfig.py:
3650         (loadBuilderConfig):
3651         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3652         (ConfigDotJSONTest.test_configuration):
3653         * BuildSlaveSupport/ews-build/master.cfg:
3654
3655 2019-03-11  Truitt Savell  <tsavell@apple.com>
3656
3657         Unreviewed, rolling out r242702.
3658
3659         Broke High Sierra builders.
3660
3661         Reverted changeset:
3662
3663         "Add utility function to allow easy reverse range-based
3664         iteration of a container"
3665         https://bugs.webkit.org/show_bug.cgi?id=195542
3666         https://trac.webkit.org/changeset/242702
3667
3668 2019-03-11  Sam Weinig  <sam@webkit.org>
3669
3670         Add utility function to allow easy reverse range-based iteration of a container
3671         https://bugs.webkit.org/show_bug.cgi?id=195542
3672
3673         Reviewed by Antti Koivisto.
3674
3675         * TestWebKitAPI/CMakeLists.txt:
3676         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3677         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3678         (TestWebKitAPI::TEST):
3679         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3680
3681 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3682
3683         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3684         https://bugs.webkit.org/show_bug.cgi?id=195511
3685         <rdar://problem/44873269>
3686
3687         Reviewed by Darin Adler.
3688
3689         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3690         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3691         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3692         (TEST_F):
3693
3694 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3695
3696         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3697         https://bugs.webkit.org/show_bug.cgi?id=195499
3698
3699         Reviewed by Darin Adler.
3700
3701         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3702         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3703         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3704         (-[WKWebView synchronouslyFocusTextInputContext:]):
3705         (applyStyle):
3706         (applyIframe):
3707         (TEST):
3708         Add some tests for this SPI.
3709
3710 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3711
3712         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3713         https://bugs.webkit.org/show_bug.cgi?id=181151
3714
3715         Reviewed by Don Olmstead.
3716
3717         * TestWebKitAPI/CMakeLists.txt:
3718         * TestWebKitAPI/PlatformWin.cmake:
3719         Enable TestWTF RunLoop tests in all platforms.
3720
3721         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3722         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3723         (TestWebKitAPI::DerivedOneShotTimer::fired):
3724         (TestWebKitAPI::TEST):
3725         Only a few platforms support nested RunLoop.
3726
3727         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3728         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3729
3730 2019-03-10  David Quesada  <david_quesada@apple.com>
3731
3732         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3733         https://bugs.webkit.org/show_bug.cgi?id=152480
3734
3735         Reviewed by Chris Dumez.
3736
3737         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3738         there are no additional references to the process pool besides the one held by
3739         the download, waits for the download to finish (in the sense that the
3740         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3741         measure, also check that the process pool has been deallocated at the end of the
3742         test. The test wouldn't be meaningful if the process pool were still alive.
3743
3744         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3745         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3746         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3747             The download will be canceled because the delegate does not implement the
3748             method to decide the download's destination, so this is where we know the
3749             DownloadProxyMap is done with the DownloadProxy.
3750         (TEST):
3751
3752 2019-03-08  Chris Dumez  <cdumez@apple.com>
3753
3754         Add support for Device Orientation / Motion permission API
3755         https://bugs.webkit.org/show_bug.cgi?id=195329
3756         <rdar://problem/47645367>
3757
3758         Reviewed by Geoffrey Garen.
3759
3760         Add test infrastructure to help test the Device Orientation / Motion permission API.
3761
3762         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3763         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3764         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3765         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3766         * WebKitTestRunner/TestController.cpp:
3767         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3768         (WTR::TestController::createWebViewWithOptions):
3769         (WTR::TestController::resetStateToConsistentValues):
3770         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3771         * WebKitTestRunner/TestController.h:
3772         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3773         * WebKitTestRunner/TestInvocation.cpp:
3774         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3775
3776 2019-03-08  Saam barati  <sbarati@apple.com>
3777
3778         Add a compare-results script to compare benchmark results
3779         https://bugs.webkit.org/show_bug.cgi?id=195486
3780         <rdar://problem/48723397>
3781
3782         Reviewed by Geoffrey Garen.
3783
3784         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3785         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3786         to extend it to learn about our other benchmarks.
3787
3788         * Scripts/compare-results: Added.
3789         (readJSONFile):
3790         (detectJetStream2):
3791         (JetStream2Results):
3792         (detectSpeedometer2):
3793         (Speedometer2Results):
3794         (detectPLT5):
3795         (PLT5Results):
3796         (detectBenchmark):
3797         (biggerIsBetter):
3798         (ttest):
3799         (getOptions):
3800         (main):
3801
3802 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3803
3804         Ensure old tab state is cleared between iterations of run-benchmark
3805         https://bugs.webkit.org/show_bug.cgi?id=195393
3806         <rdar://problem/46885583>
3807
3808         Reviewed by Dewei Zhu.
3809
3810         a) ensure the default to restore state is not set
3811         b) terminate Safari correctly
3812         c) Set the system default to ignore Persistent State in Safari
3813
3814         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3815         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3816         (OSXBrowserDriver.prepare_env): 
3817         (OSXBrowserDriver.restore_env):
3818         (OSXBrowserDriver.close_browsers):
3819         (OSXBrowserDriver._terminate_processes):
3820         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3821         (OSXChromeDriver):
3822         (OSXChromeCanaryDriver):
3823         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3824         (OSXFirefoxDriver):
3825         (OSXFirefoxNightlyDriver):
3826         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3827         (OSXSafariDriver):
3828         (OSXSafariDriver.prepare_env):
3829
3830 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3831
3832         [GTK] Several InputMethodFilter tests are failing
3833         https://bugs.webkit.org/show_bug.cgi?id=195408
3834
3835         Reviewed by Carlos Garcia Campos.
3836
3837         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3838         Regressed in r241751.
3839         Hexadecimal values of keycodes are expressed now in upper letters.
3840         Composited characters should be cast to UTF8 strings.
3841
3842         (TestWebKitAPI::TEST):
3843
3844 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3845
3846         [GTK] Make Tools/gtkdoc python3 compatible
3847         https://bugs.webkit.org/show_bug.cgi?id=195359
3848
3849         Reviewed by Carlos Garcia Campos.
3850
3851         * gtkdoc/generate-gtkdoc:
3852         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3853         work with Python 2 and 3.
3854         (get_gtkdoc_module_paths):
3855         The iteritems() was removed in Python 3, so let's use items() that's
3856         available in Python 2 and 3.
3857         (get_generator_for_config):
3858         * gtkdoc/gtkdoc.py:
3859         (GTKDoc._run_command):
3860         The sys.stdout.write() is expecting str in Python 3 and not bytes
3861         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3862         for passing the bytes there.
3863
3864 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3865
3866         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3867         https://bugs.webkit.org/show_bug.cgi?id=195346
3868         <rdar://problem/48667048>
3869
3870         Unreviewed build fix for clang-cl.
3871
3872         * DumpRenderTree/win/DumpRenderTree.cpp:
3873         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3874
3875 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3876
3877         requestAnimationFrame should execute before the next frame
3878         https://bugs.webkit.org/show_bug.cgi?id=177484
3879
3880         Reviewed by Simon Fraser.
3881
3882         Add trace points for the page RenderingUpdate.
3883
3884         * Tracing/SystemTracePoints.plist:
3885
3886 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3887
3888         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3889         https://bugs.webkit.org/show_bug.cgi?id=195353
3890         <rdar://problem/48626394>
3891
3892         Reviewed by Simon Fraser.
3893
3894         * WebKitTestRunner/ios/TestControllerIOS.mm:
3895         (WTR::TestController::platformResetPreferencesToConsistentValues):
3896
3897 2019-03-07  John Wilander  <wilander@apple.com>
3898
3899         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3900         https://bugs.webkit.org/show_bug.cgi?id=195383
3901         <rdar://problem/48570136>
3902
3903         Reviewed by Brent Fulgham.
3904
3905         This patch adds test infrastructure to purge only script-accessible cookies,
3906         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3907
3908         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3909         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3910         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3911         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3912         * WebKitTestRunner/TestController.cpp:
3913         (WTR::TestController::statisticsDeleteCookiesForHost):
3914         * WebKitTestRunner/TestController.h:
3915         * WebKitTestRunner/TestInvocation.cpp:
3916         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3917
3918 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3919
3920         Unreviewed, rolling out r242354.
3921         https://bugs.webkit.org/show_bug.cgi?id=195402
3922
3923         breaks layout tests in all configurations (Requested by
3924         zdobersek on #webkit).
3925
3926         Reverted changeset:
3927
3928         "[WPE] Enable web process sandbox"
3929         https://bugs.webkit.org/show_bug.cgi?id=195169
3930         https://trac.webkit.org/changeset/242354
3931
3932 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3933
3934         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3935         https://bugs.webkit.org/show_bug.cgi?id=195346
3936
3937         Reviewed by Fujii Hironori.
3938
3939         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3940         (TestWebKitAPI::TEST):
3941         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3942
3943         * DumpRenderTree/win/DumpRenderTree.cpp:
3944         (findFontFallback):
3945         (addFontFallbackIfPresent):
3946         (removeFontFallbackIfPresent):
3947         (main):
3948         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3949         (TestWebKitAPI::Util::moduleDirectory):
3950         (TestWebKitAPI::Util::createInjectedBundlePath):
3951         Use wchar helpers as needed.
3952
3953 2019-03-06  Rob Buis  <rbuis@igalia.com>
3954
3955         Consider supporting the `referrerpolicy` attribute.
3956         https://bugs.webkit.org/show_bug.cgi?id=179053
3957
3958         Reviewed by Darin Adler.
3959
3960         Add a runtime flag for referrerpolicy attribute.
3961
3962         * DumpRenderTree/mac/DumpRenderTree.mm:
3963         (enableExperimentalFeatures):
3964
3965 2019-03-05  Daniel Bates  <dabates@apple.com>
3966
3967         Update expected API test result following r242379
3968         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3969
3970         Update expected x-coordinate of selection rect now that the left padding of
3971         a textarea is sized in ems (so dependent on the font size) just like the left
3972         padding of a text field.
3973
3974         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3975         (TestWebKitAPI::TEST):
3976
3977 2019-03-05  David Quesada  <david_quesada@apple.com>
3978
3979         [WK2] It should be possible to follow links with 'download' attributes
3980         https://bugs.webkit.org/show_bug.cgi?id=195145
3981         rdar://problem/48462642
3982
3983         Reviewed by Alex Christensen.
3984
3985         Add a unit test to verify that activating links with 'download' attributes now
3986         navigates to the linked resource, rather than starts downloading it. Add another
3987         to verify that it is still possible to explicitly download the link via the
3988         'Download' navigation action policy.
3989
3990         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3991         (-[DownloadAttributeTestDelegate init]):
3992         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3993         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3994         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3995         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3996         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3997         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3998         (TEST):
3999         * WebKitTestRunner/TestController.cpp:
4000         (WTR::TestController::decidePolicyForNavigationAction):
4001         * WebKitTestRunner/TestController.h:
4002
4003 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
4004
4005         [Curl] Implement Cookie Accept Policy.
4006         https://bugs.webkit.org/show_bug.cgi?id=191645
4007
4008         Reviewed by Fujii Hironori.
4009
4010         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4011         (TestWebKitAPI::Curl::TEST_F):
4012
4013 2019-03-05  Youenn Fablet  <youenn@apple.com>
4014
4015         Rename requestCacheStorageSpace to requestStorageSpace
4016         https://bugs.webkit.org/show_bug.cgi?id=195282
4017
4018         Reviewed by Chris Dumez.
4019
4020         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4021         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4022         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
4023
4024 2019-03-05  Brady Eidson  <beidson@apple.com>
4025
4026         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
4027         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
4028
4029         Reviewed by Tim Horton.
4030
4031         Loading a file: URL into a WKWebView and then loading another file: url from a completely
4032         different directory into that same WKWebView should work.
4033
4034         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4035         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
4036
4037 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
4038
4039         Add WeakHashSet
4040         https://bugs.webkit.org/show_bug.cgi?id=195152
4041
4042         Reviewed by Antti Koivisto.
4043
4044         Added tests for WeakHashSet.
4045
4046         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4047         (TestWebKitAPI::Base::Base): Moved.
4048         (TestWebKitAPI::Derived::foo): Moved.
4049         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
4050         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
4051         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
4052         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
4053
4054 2019-03-04  Chris Dumez  <cdumez@apple.com>
4055
4056         Do not share WebProcesses between private and regular sessions
4057         https://bugs.webkit.org/show_bug.cgi?id=195189
4058         <rdar://problem/48421064>
4059
4060         Reviewed by Alex Christensen.
4061
4062         Add API test coverage.
4063
4064         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4065         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4066
4067 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
4068
4069         [WPE] Enable web process sandbox
4070         https://bugs.webkit.org/show_bug.cgi?id=195169
4071
4072         Reviewed by Daniel Bates.
4073
4074         * wpe/install-dependencies:
4075         * wpe/jhbuild.modules:
4076
4077 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4078
4079         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
4080         https://bugs.webkit.org/show_bug.cgi?id=195206
4081
4082         Reviewed by Žan Doberšek.
4083
4084         Add a new test case.
4085
4086         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4087         (testJSCClass):
4088
4089 2019-03-04  Charlie Turner  <cturner@igalia.com>
4090
4091         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
4092         https://bugs.webkit.org/show_bug.cgi?id=194898
4093
4094         Reviewed by Žan Doberšek.
4095
4096         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
4097         a GCC extension that permits arithmetic on void* pointer. Inline
4098         the macro until this issue is fixed upstream.
4099
4100 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4101
4102         Rid the world of WK_API_ENABLED
4103         https://bugs.webkit.org/show_bug.cgi?id=195263
4104
4105         Reviewed by Dan Bernstein.
4106
4107         List of changed files elided because it's useless.
4108
4109 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4110
4111         Unreviewed follow-up to r242292.
4112
4113         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4114
4115         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4116         (TestWebKitAPI::testStrip): Renamed from strip.
4117         (TestWebKitAPI::TEST):
4118
4119 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4120
4121         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4122
4123         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4124         and bug #194272 for details.
4125
4126         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4127
4128 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4129
4130         Remove some more unused 32-bit code
4131         https://bugs.webkit.org/show_bug.cgi?id=195255
4132
4133         Reviewed by Darin Adler.
4134
4135         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4136         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4137         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4138         (NPP_New):
4139         (NPP_HandleEvent):
4140         (handleEventCarbon): Deleted.
4141
4142 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4143
4144         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4145
4146         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4147         (TestWebKitAPI::TEST):
4148
4149 2019-03-01  Darin Adler  <darin@apple.com>
4150
4151         Finish removing String::format
4152         https://bugs.webkit.org/show_bug.cgi?id=194893
4153
4154         Reviewed by Daniel Bates.
4155 '
4156         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4157
4158 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4159
4160         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4161         https://bugs.webkit.org/show_bug.cgi?id=195229
4162         <rdar://problem/48520362>
4163
4164         Reviewed by Chris Dumez.
4165
4166         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4167         (TEST):
4168
4169 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4170
4171         Add a system trace scope for event region building
4172         https://bugs.webkit.org/show_bug.cgi?id=195226
4173
4174         Reviewed by Jon Lee.
4175
4176         This trace scope measures the time spend converting element rects into Region objects,
4177         which can be large on some pages.
4178
4179         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4180
4181         * Tracing/SystemTracePoints.plist:
4182
4183 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4184
4185         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4186         https://bugs.webkit.org/show_bug.cgi?id=194612
4187
4188         Reviewed by Alex Christensen.
4189
4190         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4191         Just test the new string-processing function and don't touch the actual environment.
4192         (Test cases are all as before, but based on operator== instead of strcmp.)
4193
4194 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4195
4196         [ews-app] Update primary keys for handling multiple Buildbot instances
4197         https://bugs.webkit.org/show_bug.cgi?id=195120
4198
4199         Reviewed by Stephanie Lewis.
4200
4201         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4202         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4203         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4204
4205         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4206         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4207         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4208         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4209         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4210         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4211
4212 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4213
4214         [WinCairo] Enable service worker
4215         https://bugs.webkit.org/show_bug.cgi?id=188318
4216
4217         Reviewed by Youenn Fablet.
4218
4219         * DumpRenderTree/DumpRenderTreePrefix.h:
4220         * TestWebKitAPI/PlatformWin.cmake:
4221         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4222         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4223         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4224
4225 2019-03-01  Justin Fan  <justin_fan@apple.com>
4226
4227         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4228         https://bugs.webkit.org/show_bug.cgi?id=195191
4229
4230         Rubber-stamped by Dean Jackson.
4231
4232         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4233
4234         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4235
4236 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4237
4238         Unreviewed, fix lldb webkitpy tests
4239         https://bugs.webkit.org/show_bug.cgi?id=194375
4240
4241         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4242
4243         * lldb/lldb_webkit.py:
4244         (WTFStringImplProvider.is_8bit):
4245
4246 2019-02-28  David Quesada  <david_quesada@apple.com>
4247
4248         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4249         https://bugs.webkit.org/show_bug.cgi?id=195121
4250         rdar://problem/48450302
4251
4252         Reviewed by Alex Christensen.
4253
4254         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4255         configurations where the 'download' attribute is absent, blank, or populated
4256         with a filename, and where the anchor element is same-origin or cross-origin
4257         (meaning the 'download' attribute shouldn't be honored).
4258
4259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4260         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4261         (-[NavigationActionTestDelegate init]):
4262         (-[NavigationActionTestDelegate navigationAction]):
4263         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4264         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4265         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4266         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4267         (TEST):
4268
4269 2019-02-28  Antoine Quint  <graouts@apple.com>
4270
4271         Enable the Pointer Events runtime flag by default
4272         https://bugs.webkit.org/show_bug.cgi?id=195156
4273
4274         Reviewed by Dean Jackson.
4275
4276         * DumpRenderTree/mac/DumpRenderTree.mm:
4277         (enableExperimentalFeatures):
4278
4279 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4280
4281         Several PasteImage API tests are flaky
4282         https://bugs.webkit.org/show_bug.cgi?id=195160
4283
4284         Reviewed by Tim Horton.
4285
4286         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4287         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4288         listening for a "load" event after image load is already complete.
4289
4290         To address this, make these tests first register a "load" event handler, then run script to insert an image
4291         element into the document, and finally wait until the load event is observed before checking image size.
4292
4293         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4294
4295 2019-02-28  Chris Dumez  <cdumez@apple.com>
4296
4297         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4298         https://bugs.webkit.org/show_bug.cgi?id=195107
4299
4300         Reviewed by Alex Christensen.
4301
4302         Give some time for the zoom level to get restored.
4303
4304         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4305
4306 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4307
4308         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4309         https://bugs.webkit.org/show_bug.cgi?id=194958
4310
4311         Reviewed by Geoffrey Garen.
4312
4313         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4314         (TEST):
4315
4316 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4317
4318         [ews-app] Update method to save build to handle builder_display_name
4319         https://bugs.webkit.org/show_bug.cgi?id=195047
4320
4321         Reviewed by Dewei Zhu.
4322
4323         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4324         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4325
4326 2019-02-28  Justin Fan  <justin_fan@apple.com>
4327
4328         [Web GPU] Enable Web GPU only on 64-bit
4329         https://bugs.webkit.org/show_bug.cgi?id=195139
4330
4331         Because Metal is only supported on 64 bit apps.
4332
4333         Unreviewed build fix.
4334
4335         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4336
4337 2019-02-27  Youenn Fablet  <youenn@apple.com>
4338
4339         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4340         https://bugs.webkit.org/show_bug.cgi?id=194959
4341
4342         Reviewed by Chris Dumez.
4343
4344         Spin loop until getting the condition to remove flakiness.
4345
4346         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4347
4348 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4349
4350         [ews-build] Buildbot should include builder_display_name in the build events
4351         https://bugs.webkit.org/show_bug.cgi?id=195045
4352
4353         Reviewed by Dewei Zhu.
4354
4355         * BuildSlaveSupport/ews-build/events.py:
4356         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4357         buildername to builder_name to be consistent in naming style.
4358         (Events.buildFinished): Ditto.
4359
4360 2019-02-27  Chris Dumez  <cdumez@apple.com>
4361
4362         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4363         https://bugs.webkit.org/show_bug.cgi?id=194480
4364