2013-04-06 Laszlo Gombos <l.gombos@samsung.com>
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
2
3         Build fix after r147857, remove remaining USE(JSC) guards.
4
5         Unreviewed.
6
7         * DumpRenderTree/config.h:
8         * TestWebKitAPI/config.h:
9         * WebKitTestRunner/config.h:
10
11 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
12
13         Rename sheriffbot to webkitbot
14         https://bugs.webkit.org/show_bug.cgi?id=114109
15
16         Reviewed by Benjamin Poulain.
17
18         Renamed since sheriffbot will be used in Blink.
19
20         * Scripts/webkitpy/tool/commands/sheriffbot.py:
21         (SheriffBot):
22         (SheriffBot.begin_work_queue):
23
24 2013-04-06  Oliver Hunt  <oliver@apple.com>
25
26         Unify the many and varied stack trace mechanisms, and make the result sane.
27         https://bugs.webkit.org/show_bug.cgi?id=114072
28
29         Reviewed by Filip Pizlo.
30
31         The commandline jsc executable no longer requires arguments, so
32         I've made run-jsc work without them.
33
34         * Scripts/run-jsc:
35
36 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
37
38         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
39         https://bugs.webkit.org/show_bug.cgi?id=114086
40
41         Reviewed by Tim Horton.
42
43         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
44
45 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
46
47         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
48         https://bugs.webkit.org/show_bug.cgi?id=114083
49
50         Reviewed by Ryosuke Niwa.
51
52         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
53         in TestWebKitAPI and WebKitTestRunner.
54
55         * TestWebKitAPI/config.h:
56         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
57         (TestWebKitAPI::InjectedBundleController::platformInitialize):
58         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
59         (WTR::InjectedBundle::platformInitialize):
60
61 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
62
63         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
64         https://bugs.webkit.org/show_bug.cgi?id=114094
65
66         Reviewed by Anders Carlsson.
67
68         * Scripts/run-jsc:
69
70 2013-04-05  Ojan Vafai  <ojan@chromium.org>
71
72         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
73         https://bugs.webkit.org/show_bug.cgi?id=114080
74
75         Reviewed by Ryosuke Niwa.
76
77         This way, the WebKit and Blink dashboard code can change as appropriate without
78         needing to consider the other project's needs. This still doesn't update the
79         buildbots to upload to the new location, or the dashboard code to pull the
80         results.json files from the new location, but it at least allows for changing the
81         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
82
83         * TestResultServer/app.yaml:
84
85 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
86
87         Re-enable testing on the commit queue
88         https://bugs.webkit.org/show_bug.cgi?id=114078
89
90         Reviewed by Darin Adler.
91
92         Re-enabled the feature and the associated tests.
93
94         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
95         (CommitQueueTask.run):
96         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
97         (CommitQueueTaskTest._run_through_task):
98         * Scripts/webkitpy/tool/commands/queues_unittest.py:
99         (CommitQueueTest._mock_test_result):
100
101 2013-04-05  Oliver Hunt  <oliver@apple.com>
102
103         Unify the many and varied stack trace mechanisms, and make the result sane.
104         https://bugs.webkit.org/show_bug.cgi?id=114072
105
106         Reviewed by Filip Pizlo.
107
108         The commandline jsc executable no longer requires arguments, so
109         I've made run-jsc work without them.
110
111         * Scripts/run-jsc:
112
113 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
114
115         AX: Make SVG Group containers accessible elements
116         https://bugs.webkit.org/show_bug.cgi?id=113939
117
118         Reviewed by Simon Fraser.
119
120         Implement axController.elementAtPoint for iOS.
121         Implement a correct version of clickPoint for iOS.
122
123         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
124         (AccessibilityController::elementAtPoint):
125         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
126         (AccessibilityUIElement::clickPointX):
127         (AccessibilityUIElement::clickPointY):
128
129 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
130
131         Unreviewed, rolling out r147773 and r147774.
132         http://trac.webkit.org/changeset/147773
133         http://trac.webkit.org/changeset/147774
134         https://bugs.webkit.org/show_bug.cgi?id=114056
135
136         Causing some exceptions on AppEngine I don't understand
137         (Requested by rniwa on #webkit).
138
139         * QueueStatusServer/config/queues.py:
140         * QueueStatusServer/model/queues.py:
141         (Queue.short_name):
142         (Queue.display_name):
143         * QueueStatusServer/model/queues_unittest.py:
144         (QueueTest.test_short_name):
145         (QueueTest.test_display_name):
146         (QueueTest.test_name_with_underscores):
147
148 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
149
150         Fixed run-bindings-tests by removing V8
151         https://bugs.webkit.org/show_bug.cgi?id=114053
152
153         Reviewed by Benjamin Poulain.
154
155         * Scripts/run-bindings-tests:
156         (main):
157
158 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
159
160         Build fix.
161
162         * QueueStatusServer/model/queues.py:
163         (Queue.short_name):
164         (Queue.display_name):
165
166 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
167
168         Remove Chromium EWS bots from the queue status server
169         https://bugs.webkit.org/show_bug.cgi?id=113988
170
171         Reviewed by Benjamin Poulain.
172
173         Removed Chromium EWS bots.
174
175         * QueueStatusServer/config/queues.py:
176         * QueueStatusServer/model/queues.py:
177         (Queue.short_name):
178         (Queue.display_name):
179         * QueueStatusServer/model/queues_unittest.py:
180         (QueueTest.test_short_name):
181         (QueueTest.test_display_name):
182         (QueueTest.test_name_with_underscores):
183
184 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
185
186         [EFL] Enable indexed database
187         https://bugs.webkit.org/show_bug.cgi?id=107248
188
189         Reviewed by Alexis Menard.
190
191         * Scripts/webkitperl/FeatureList.pm:
192
193 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
194
195         Remove vestiges of Chromium bits from watchlists.
196         https://bugs.webkit.org/show_bug.cgi?id=114047
197
198         Reviewed by Ryosuke Niwa.
199
200         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
201
202 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
203
204         Add James Craig to the contributors list.
205
206         * Scripts/webkitpy/common/config/committers.py:
207
208 2013-04-04  Kent Tamura  <tkent@chromium.org>
209
210         Remove ChromiumPublicApi pattern, and cc/message rules for it.
211
212         * Scripts/webkitpy/common/config/watchlist:
213
214 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
215
216         Temporarily disable the Python unittests broken by the commit queue not running layout tests
217         https://bugs.webkit.org/show_bug.cgi?id=113997
218
219         Reviewed by Ryosuke Niwa.
220
221         Disable the tests until Ryosuke gets the time and hardware to have
222         a testing commit-queue.
223
224         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
225         (CommitQueueTaskTest):
226         * Scripts/webkitpy/tool/commands/queues_unittest.py:
227         (CommitQueueTest):
228
229 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
230
231         Remove Chromium builders from build.webkit.org
232         https://bugs.webkit.org/show_bug.cgi?id=113990
233
234         Reviewed by Benjamin Poulain.
235
236         Land the part to disable triggering of Chromium builders first so that we may start
237         deleting more Chromium code that breaks the update step.
238
239         * BuildSlaveSupport/build.webkit.org-config/config.json:
240
241 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
242
243         Remove Chromium's DumpRenderTree
244         https://bugs.webkit.org/show_bug.cgi?id=113989
245
246         Reviewed by Kent Tamura.
247
248         On second thought, let's not go to Camelot. It is a silly place.
249
250         * DumpRenderTree/mac/DumpRenderTree.mm:
251         (resetDefaultsToConsistentValues):
252
253 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
254
255         Nixed the defunct chromium folder from DumpRenderTree
256         https://bugs.webkit.org/show_bug.cgi?id=113993
257
258         Reviewed by Ryosuke Niwa.
259
260         * DumpRenderTree/chromium: Removed.
261         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
262         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
263         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
264         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
265         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
266         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
267         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
268         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
269         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
270         * DumpRenderTree/chromium/MockPlatform.h: Removed.
271         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
272         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
273         * DumpRenderTree/chromium/Task.cpp: Removed.
274         * DumpRenderTree/chromium/Task.h: Removed.
275         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
276         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
277         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
278         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
279         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
280         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
281         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
282         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
283         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
284         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
285         * DumpRenderTree/chromium/TestRunner: Removed.
286         * DumpRenderTree/chromium/TestRunner/public: Removed.
287         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
288         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
289         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
290         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
291         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
292         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
293         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
294         * DumpRenderTree/chromium/TestRunner/src: Removed.
295         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
296         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
297         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
298         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
299         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
300         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
301         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
302         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
303         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
304         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
305         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
306         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
307         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
308         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
309         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
310         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
311         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
312         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
313         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
314         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
315         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
316         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
317         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
318         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
319         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
320         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
321         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
322         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
323         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
324         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
325         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
326         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
327         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
328         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
329         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
330         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
331         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
332         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
333         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
334         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
335         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
336         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
337         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
338         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
339         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
340         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
341         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
342         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
343         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
344         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
345         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
346         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
347         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
348         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
349         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
350         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
351         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
352         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
353         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
354         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
355         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
356         * DumpRenderTree/chromium/TestShell.cpp: Removed.
357         * DumpRenderTree/chromium/TestShell.h: Removed.
358         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
359         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
360         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
361         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
362         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
363         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
364         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
365         * DumpRenderTree/chromium/WebViewHost.h: Removed.
366         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
367         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
368         * DumpRenderTree/chromium/config.h: Removed.
369         * DumpRenderTree/chromium/fonts.conf: Removed.
370
371 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
372
373         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
374
375         Rubber stamped by Benjamin Poulain.
376
377         * RebaselineQueueServer: Removed.
378         * RebaselineQueueServer/app.yaml: Removed.
379         * RebaselineQueueServer/handlers: Removed.
380         * RebaselineQueueServer/handlers/__init__.py: Removed.
381         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
382         * RebaselineQueueServer/handlers/pages.py: Removed.
383         * RebaselineQueueServer/index.yaml: Removed.
384         * RebaselineQueueServer/main.py: Removed.
385         * RebaselineQueueServer/model: Removed.
386         * RebaselineQueueServer/model/__init__.py: Removed.
387         * RebaselineQueueServer/model/queueentry.py: Removed.
388         * RebaselineQueueServer/static: Removed.
389         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
390         * RebaselineQueueServer/static/styles.css: Removed.
391         * RebaselineQueueServer/templates: Removed.
392         * RebaselineQueueServer/templates/builder-picker.html: Removed.
393         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
394         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
395         * RebaselineQueueServer/templates/home.html: Removed.
396
397 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
398
399         Fix setup-commit-queue and temporarily disable testing on commit-queue
400         https://bugs.webkit.org/show_bug.cgi?id=113979
401
402         Reviewed by Benjamin Poulain.
403
404         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
405         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
406
407         * EWSTools/setup-commit-queue.sh:
408         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
409         (CommitQueueTask.run):
410
411 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
412
413         temporarily make flakiness dashboard work again webkit.org bots
414         https://bugs.webkit.org/show_bug.cgi?id=113972
415
416         Reviewed by Ojan Vafai.
417
418         This patch disables the chromium.org layout test bots TestExpectations
419         parsing temporarily until we can work out the right way to split into
420         two instances for webkit.org and chromium.org and figure out which
421         code to delete where :).
422
423         * TestResultServer/static-dashboards/flakiness_dashboard.js:
424
425 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
426
427         Fix webkitpy tests after r147678.
428
429         * Scripts/webkitpy/tool/commands/queues_unittest.py:
430         (CommitQueueTest.test_commit_queue):
431         (test_manual_reject_during_processing):
432
433 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
434
435         The commit queue should use Mac MountainLion port
436         https://bugs.webkit.org/show_bug.cgi?id=113971
437
438         Reviewed by Lucas Forschler.
439
440         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
441         * Scripts/webkitpy/tool/commands/queues.py:
442         (CommitQueue):
443
444 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
445
446         turn off running tests on chromium linux EWS bots
447         https://bugs.webkit.org/show_bug.cgi?id=113959
448
449         Reviewed by Geoffrey Garen.
450
451         Now that the Chromium port is no longer being maintained
452         there's little point in running the tests. Soon we should
453         just shut this bot off altogether.
454
455         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
456         (ChromiumLinuxEWS):
457
458 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
459
460         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
461
462         * Scripts/webkitpy/common/config/watchlist:
463
464 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
465
466         Indentation fix to get webkit-patch working again after r147625
467
468         Unreviewed.
469
470         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
471         (MacEWS):
472         (MacWK2EWS):
473
474 2013-04-04  Lucas Forschler  <lforschler@apple.com>
475
476         Turn tests back on for Mac WK1/WK2 EWS.
477         
478         Unreviewed.
479         
480         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
481         (MacEWS):
482         (MacWK2EWS):
483
484 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
485
486         [GTK][WK2] MiniBrowser custom URI scheme support
487         https://bugs.webkit.org/show_bug.cgi?id=112419
488
489         Reviewed by Carlos Garcia Campos.
490
491         Add support for about URIs in MiniBrowser. An example about page is show
492         with URI "about:minibrowser", the rest of the cases it will show a
493         proper message explaining that the about page didn't exist.
494
495         Internally it uses "minibrowser-about" prefix instead of "about", but
496         from the user point of view it works with "about" prefix.
497
498         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
499         (getInternalURI): Method to convert URIs from "about" prefix to
500         "minibrowser-about".
501         (getExternalURI): Opposite method.
502         (webViewURIChanged): Use "about" prefix to show the URI to users.
503         (webViewEnterFullScreen): Ditto.
504         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
505         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
506         (aboutURISchemeRequestCallback): Callback to manage about calls.
507         (main): Register the URI scheme to manage about URIs.
508
509 2013-04-03  Roger Fong  <roger_fong@apple.com>
510
511         Re-enable WinEWS tests.
512
513         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
514         (WinEWS):
515
516 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
517
518         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
519         https://bugs.webkit.org/show_bug.cgi?id=113883
520
521         Reviewed by Martin Robinson.
522
523         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
524         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
525         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
526
527 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
528
529         [GTK] Include Pango in jhbuild-optional.modules
530         https://bugs.webkit.org/show_bug.cgi?id=113878
531
532         Reviewed by Martin Robinson.
533
534         Since r147547 Pango 1.32.0 is required. Including the module in the
535         JHBuild optional moduleset.
536
537         * gtk/jhbuild-optional.modules: Add Pango module.
538
539 2013-04-03  Zeno Albisser  <zeno@webkit.org>
540
541         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
542         https://bugs.webkit.org/show_bug.cgi?id=113864
543
544         Moving setDefersLoading from TestRunnerQt to TestRunner
545         requires access to the non-Qt TestRunner.
546         As long as we instantiate both TestRunner and TestRunnerQt,
547         we need a separate getter for the non-Qt TestRunner instance.
548
549         Reviewed by Simon Hausmann.
550
551         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
552         (WebPage::resetSettings):
553         * DumpRenderTree/qt/DumpRenderTreeQt.h:
554         (DumpRenderTree::jscTestRunner):
555         * DumpRenderTree/qt/TestRunnerQt.cpp:
556         (TestRunner::setDefersLoading):
557             Moving setDefersLoading from TestRunnerQt
558             to TestRunner.
559         * DumpRenderTree/qt/TestRunnerQt.h:
560         (TestRunnerQt):
561
562 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
563
564         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
565         https://bugs.webkit.org/show_bug.cgi?id=104779
566
567         Reviewed by Carlos Garcia Campos.
568
569         * Scripts/run-gtk-tests:
570         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
571         passing in current trunk.
572
573 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
574
575         Fix HAVE(QTTESTSUPPORT) logic
576
577         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
578         resulting in HAVE(QTTESTSUPPORT) never being true.
579         Move that logic down in sanitizeFeatures.
580
581         Rubber-stamped by Tor Arne Vestbø.
582
583         * qmake/mkspecs/features/features.prf:
584
585 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
586
587         [GTK] Bump required versions of some dependencies
588         https://bugs.webkit.org/show_bug.cgi?id=113282
589
590         Reviewed by Martin Robinson.
591
592         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
593
594 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
595
596         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
597         https://bugs.webkit.org/show_bug.cgi?id=113809
598
599         Reviewed by Philippe Normand.
600
601         Newer Linux kernels have removed some deprecated macros from v4l2
602         headers, causing gst-plugins-good's build to break. We don't need it
603         right now, so just disable it.
604
605         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
606
607 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
608
609         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
610         https://bugs.webkit.org/show_bug.cgi?id=113535
611
612         Reviewed by Simon Hausmann.
613
614         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
615
616         * qmake/mkspecs/features/features.prf:
617
618 2013-04-03  Zeno Albisser  <zeno@webkit.org>
619
620         [Qt] Move logic of simple forwarding functions to TestRunner.
621         https://bugs.webkit.org/show_bug.cgi?id=113863
622
623         Reviewed by Simon Hausmann.
624
625         * DumpRenderTree/qt/TestRunnerQt.cpp:
626         (TestRunner::setTextDirection):
627         (TestRunner::goBack):
628         (TestRunner::evaluateScriptInIsolatedWorld):
629         (TestRunner::addUserStyleSheet):
630         * DumpRenderTree/qt/TestRunnerQt.h:
631         (TestRunnerQt):
632
633 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
634
635         [Qt] Disable media support using QuickTime if deployment target != SDK
636
637         We link to a single libWebKitSystemInterface static lib, so unless the
638         deployment target matches the SDK let's not pretend like we'll be able
639         to run on anything lower than the SDK version.
640
641         Reviewed by Simon Hausmann.
642
643         * qmake/mkspecs/features/features.prf:
644
645 2013-04-02  James Craig  <james@cookiecrook.com>
646
647         AXRoleDescripton for DL is "list"; should be "description list"
648         https://bugs.webkit.org/show_bug.cgi?id=111665
649
650         Reviewed by Chris Fleizach.
651
652         Defining the role and description strings.
653
654         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
655
656 2013-04-02  Roger Fong  <roger_fong@apple.com>
657
658         Unreviewed. Disable running tests on Win EWS queue.
659
660         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
661         (WinEWS):
662
663 2013-04-02  Lucas Forschler  <lforschler@apple.com>
664
665         Disable running tests on the MAC WK2 EWS queue.
666         
667         Unreviewed.
668         
669         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
670         (MacWK2EWS):
671
672 2013-04-02  Julie Parent  <jparent@chromium.org>
673
674         Dashboard refactor: Move dashboard specific history related features to History.
675         https://bugs.webkit.org/show_bug.cgi?id=113717
676
677         Reviewed by Ojan Vafai.
678         
679         Each dashboard now creates its own History object, with a custom
680         configuration. This changes from just overriding global functions
681         to passing in callbacks for generatePage, handleValidHashParameter,
682         and handleQueryParameterChange. Same with passing in defaultStateValues
683         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
684         variables.
685         
686         All functions related to these features are now (mostly) private
687         function on History. 
688         
689         Loader no longer needs a loadingComplete callback, since it can just
690         initialize the history object itself.
691
692         * TestResultServer/static-dashboards/aggregate_results.js:
693         (handleValidHashParameter):
694         * TestResultServer/static-dashboards/dashboard_base.js:
695         * TestResultServer/static-dashboards/flakiness_dashboard.js:
696         (generatePage):
697         (.switch.return):
698         (handleQueryParameterChange):
699         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
700         (resetGlobals):
701         * TestResultServer/static-dashboards/history.js:
702         (.):
703         * TestResultServer/static-dashboards/loader.js:
704         (.):
705         * TestResultServer/static-dashboards/loader_unittests.js:
706         * TestResultServer/static-dashboards/timeline_explorer.js:
707         (generatePage):
708         (initCurrentBuilderTestResults):
709         * TestResultServer/static-dashboards/treemap.js:
710         (generatePage):
711         (.switch.return):
712         (handleQueryParameterChange):
713
714 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
715
716         Unreviewed, rolling out r147401.
717         http://trac.webkit.org/changeset/147401
718         https://bugs.webkit.org/show_bug.cgi?id=113767
719
720         The patch makes it extremely hard to set up the dependencies
721         properly on the GTK builders (Requested by zdobersek on
722         #webkit).
723
724         * gtk/jhbuild.modules:
725
726 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
727
728         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
729         https://bugs.webkit.org/show_bug.cgi?id=113382
730
731         Reviewed by Gyuyoung Kim.
732
733         Do not show the empty tooltip box if the text is null.
734
735         * MiniBrowser/efl/main.c:
736         (popup_menu_populate):
737
738 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
739
740         [GTK] Bump required versions of some dependencies
741         https://bugs.webkit.org/show_bug.cgi?id=113282
742
743         Reviewed by Martin Robinson.
744
745         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
746
747 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
748
749         Unreviewed, rolling out r147319.
750         http://trac.webkit.org/changeset/147319
751         https://bugs.webkit.org/show_bug.cgi?id=113707
752
753         The unit test is still failing on the buildbot (Requested by
754         zdobersek on #webkit).
755
756         * Scripts/run-gtk-tests:
757         (TestRunner):
758
759 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
760
761         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
762         https://bugs.webkit.org/show_bug.cgi?id=104779
763
764         Reviewed by Carlos Garcia Campos.
765
766         * Scripts/run-gtk-tests:
767         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
768         passing in current trunk.
769
770 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
771
772         Unreviewed, rolling out r147289.
773         http://trac.webkit.org/changeset/147289
774         https://bugs.webkit.org/show_bug.cgi?id=113678
775
776         broke Win7 (dbg) build (Requested by shinyak|gardener on
777         #webkit).
778
779         * DumpRenderTree/DumpRenderTree.gypi:
780         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
781         (WebTestRunner):
782         (WebUserMediaClientMock):
783         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
784         (WebTestRunner::WebUserMediaClientMock::taskList):
785         * Scripts/webkitpy/style/checkers/cpp.py:
786         (check_function_definition):
787
788 2013-03-31  Adam Barth  <abarth@webkit.org>
789
790         configure-svn-config.sh fails
791         https://codereview.chromium.org/13392007/
792
793         Reviewed by Eric Seidel.
794
795         This script was trying to use "svn checkout" to dowload a file from
796         svn.webkit.org, but "svn checkout" only works with directories.
797         Instead, we should use "svn export".
798
799         * EWSTools/configure-svn-config.sh:
800
801 2013-03-31  Wei Jia  <wjia@chromium.org>
802
803         Allow WebUserMediaClientMock to be used by client
804         https://bugs.webkit.org/show_bug.cgi?id=113633
805
806         Reviewed by Adam Barth.
807
808         Export WebUserMediaClientMock.
809         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
810
811         * DumpRenderTree/DumpRenderTree.gypi:
812         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
813         (WebUserMediaClientMock):
814         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
815         * Scripts/webkitpy/style/checkers/cpp.py:
816         (check_function_definition):
817
818 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
819
820         Expose FeatureObserver data to WebKit clients
821         https://bugs.webkit.org/show_bug.cgi?id=113613
822
823         Reviewed by Sam Weinig.
824
825         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
826         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
827
828 2013-03-29  Greg Hughes  <ghughes@apple.com>
829
830         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
831         https://bugs.webkit.org/show_bug.cgi?id=112276
832
833         Reviewed by Chris Fleizach.
834
835         Added support to test accessibility search predicates with multiple keys.  
836
837         * DumpRenderTree/AccessibilityUIElement.cpp:
838         (uiElementForSearchPredicateCallback):
839         * DumpRenderTree/AccessibilityUIElement.h:
840         (AccessibilityUIElement):
841         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
842         (AccessibilityUIElement::uiElementForSearchPredicate):
843         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
844         (AccessibilityUIElement::uiElementForSearchPredicate):
845         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
846         (AccessibilityUIElement::uiElementForSearchPredicate):
847         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
848         (AccessibilityUIElement::uiElementForSearchPredicate):
849         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
850         (AccessibilityUIElement::uiElementForSearchPredicate):
851         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
852         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
853         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
854         (AccessibilityUIElement):
855         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
856         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
857         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
858         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
859         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
860
861 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
862
863         Fix a typo in r147147 to fix Mac EWS.
864
865         * Scripts/webkitpy/tool/commands/queues.py:
866         (PatchProcessingQueue._new_port_name_from_old):
867
868 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
869
870         [EFL] Build break with latest EFL libraries after r146265
871         https://bugs.webkit.org/show_bug.cgi?id=113558
872
873         Unreviewed build fix.
874
875         * TestWebKitAPI/PlatformWebView.h:
876         * WebKitTestRunner/PlatformWebView.h:
877
878 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
879
880         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
881
882         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
883         in libgcrypt build.
884
885 2013-03-28  Lucas Forschler  <lforschler@apple.com>
886
887         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
888
889         Unreviewed.
890
891         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
892         (MacEWS):
893
894 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
895
896         Use the right OS name on Mac EWS instead of mac-future.
897
898         Rubber-stamped by Dirk Pranke.
899
900         * Scripts/webkitpy/tool/commands/queues.py:
901         (PatchProcessingQueue._new_port_name_from_old):
902         (PatchProcessingQueue.begin_work_queue):
903         (PatchProcessingQueue._upload_results_archive_for_patch):
904
905 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
906
907         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
908         https://bugs.webkit.org/show_bug.cgi?id=112546
909
910         Reviewed by Martin Robinson.
911
912         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
913         moved back to Source/WebCore/platform. Fix an indentation issue as well.
914
915 2013-03-28  Ming Xie  <mxie@blackberry.com>
916
917         [BlackBerry] Committer Email Updates
918         https://bugs.webkit.org/show_bug.cgi?id=113435
919
920         Reviewed by Rob Buis.
921
922         Add the @blackberry.com email address for all our BlackBerry
923         WebKit committers. This is the first step for our email address
924         migration.
925
926         * Scripts/webkitpy/common/config/committers.py:
927
928 2013-03-28  Philippe Normand  <pnormand@igalia.com>
929
930         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
931         https://bugs.webkit.org/show_bug.cgi?id=113508
932
933         Reviewed by Martin Robinson.
934
935         Prevent the GStreamer plugin scanner to load system-wide
936         plugins. Only the ones built in JHBuild should be loaded and used
937         at runtime.
938
939         * efl/jhbuildrc:
940         * gtk/jhbuildrc:
941
942 2013-03-27  Philippe Normand  <pnormand@igalia.com>
943
944         [GTK] run-launcher --gtk -2 fails on a WK2-only build
945         https://bugs.webkit.org/show_bug.cgi?id=113386
946
947         Reviewed by Carlos Garcia Campos.
948
949         * Scripts/webkitdirs.pm:
950         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
951         version to 3.0. Reflect this change so the builtDylibPathForName
952         function doesn't fail to report the library as found.
953
954 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
955
956         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
957         https://bugs.webkit.org/show_bug.cgi?id=113484
958
959         Unreviewed build fix.
960
961         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
962
963         * TestWebKitAPI/CMakeLists.txt:
964         * WebKitTestRunner/CMakeLists.txt:
965
966 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
967
968         Revision for the internal jhbuild is too old
969         https://bugs.webkit.org/show_bug.cgi?id=113324
970
971         Reviewed by Martin Robinson.
972
973         Update the minimum required version to a point where jhbuild won't
974         fail installing packages when trying to remove a symlink to a directory.
975
976         * jhbuild/jhbuild-wrapper: Updated revision.
977
978 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
979
980         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
981         https://bugs.webkit.org/show_bug.cgi?id=113203
982
983         Reviewed by Philippe Normand.
984
985         We build our libsoup without GNOME support. gst-plugins-good does separate
986         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
987         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
988         build failures as the headers of those diverge. We do not use souphttpsrc, so
989         disable it when building gst-plugins-good.
990
991         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
992
993 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
994
995         Build fix after r146852. Please another reference to the Lion leaks builder.
996
997         * BuildSlaveSupport/build.webkit.org-config/config.json:
998
999 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1000
1001         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1002         https://bugs.webkit.org/show_bug.cgi?id=113421
1003
1004         Reviewed by Dirk Pranke.
1005
1006         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1007         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1008         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1009         in the GTK-specific TestExpectations files.
1010
1011         To avoid this only enable the warnings only when not using WKTR.
1012
1013         * Scripts/webkitpy/layout_tests/port/gtk.py:
1014         (GtkPort.warn_if_bug_missing_in_test_expectations):
1015
1016 2013-03-27  Antti Koivisto  <antti@apple.com>
1017
1018         Fix Zalan's email.
1019
1020         * Scripts/webkitpy/common/config/committers.py:
1021
1022 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1023
1024         master.cfg cleanup
1025         https://bugs.webkit.org/show_bug.cgi?id=113195
1026
1027         Reviewed by Ryosuke Niwa.
1028
1029         * BuildSlaveSupport/build.webkit.org-config/config.json:
1030         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1031
1032 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1033
1034         master.cfg fine-tuning for Qt Mountain Lion Release bot
1035         https://bugs.webkit.org/show_bug.cgi?id=113191
1036
1037         Reviewed by Ryosuke Niwa.
1038
1039         * BuildSlaveSupport/build.webkit.org-config/config.json:
1040           - Rename the slave due to its location change.
1041           - Update the platform of the slave.
1042         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1043         (RunQtAPITests): Enable running WK2 API tests on Qt.
1044         (RunQtAPITests.start):
1045         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1046         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1047
1048 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1049
1050         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1051         https://bugs.webkit.org/show_bug.cgi?id=113403
1052
1053         Reviewed by Kenneth Rohde Christiansen.
1054
1055         As of Evas 1.7.5, when Wayland is detected on the system, support for
1056         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1057         The code, however, seems to depend on a few other flags which must be
1058         explicitly enabled.
1059
1060         If those additional GL-related options are passed, we end up
1061         having issues on the WebKit side, so disable Wayland support for
1062         now.
1063
1064         * efl/jhbuild.modules:
1065
1066 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1067
1068         Unreviewed, rolling out r146864.
1069         http://trac.webkit.org/changeset/146864
1070         https://bugs.webkit.org/show_bug.cgi?id=113391
1071
1072         causes crashes on Wk2 EFL release bot (Requested by drott on
1073         #webkit).
1074
1075         * Scripts/webkitperl/FeatureList.pm:
1076
1077 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1078
1079         [jhbuild] Correctly specify an alternate number of make jobs.
1080         https://bugs.webkit.org/show_bug.cgi?id=113396
1081
1082         Reviewed by Philippe Normand.
1083
1084         So far, we were using the `MAKEFLAGS' environment variable to pass the
1085         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1086         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1087
1088         We now behave more closely to the rest of the WebKit tools by first
1089         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1090         not set, just letting jhbuild itself figure out how many jobs to use.
1091
1092         * efl/jhbuildrc:
1093         * gtk/jhbuildrc:
1094
1095 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1096
1097         [Qt] Remove Qt specific WorkQueueItem definitions.
1098         https://bugs.webkit.org/show_bug.cgi?id=112891
1099
1100         This patch is preparation work for removing
1101         WorkQueue related code from TestRunnerQt and
1102         replacing it with generic TestRunner code.
1103
1104         Reviewed by Benjamin Poulain.
1105
1106         * DumpRenderTree/qt/TestRunnerQt.cpp:
1107         (TestRunnerQt::queueBackNavigation):
1108         (TestRunnerQt::queueForwardNavigation):
1109         (TestRunnerQt::queueLoadHTMLString):
1110         (TestRunnerQt::queueReload):
1111         (TestRunnerQt::queueLoadingScript):
1112         (TestRunnerQt::queueNonLoadingScript):
1113         (TestRunner::queueLoad):
1114         * DumpRenderTree/qt/TestRunnerQt.h:
1115         (TestRunnerQt):
1116         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1117         (LoadItem::invoke):
1118         (LoadHTMLStringItem::invoke):
1119         (LoadAlternateHTMLStringItem::invoke):
1120         (ReloadItem::invoke):
1121         (ScriptItem::invoke):
1122         (BackForwardItem::invoke):
1123         * DumpRenderTree/qt/WorkQueueItemQt.h:
1124         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1125         (LoadAlternateHTMLStringItem):
1126
1127 2013-03-26  Julie Parent  <jparent@chromium.org>
1128
1129         Flakiness dashboard: simplify logic around which tests to show.
1130         https://bugs.webkit.org/show_bug.cgi?id=113250
1131
1132         Reviewed by Ojan Vafai.
1133         
1134         The different filters for showing results are only used for layout
1135         tests, otherwise, we show everything.
1136         
1137         Change the defaults to false (what layout tests used), and only
1138         look at the values when viewing layout tests.
1139
1140         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1141         (htmlForTestsWithExpectationsButNoFailures):
1142         (shouldHideTest):
1143
1144 2013-03-26  Isaac Levy  <ilevy@google.com>
1145
1146         Update bots on test-results.appspot
1147         https://bugs.webkit.org/show_bug.cgi?id=113333
1148
1149         Reviewed by Ojan Vafai.
1150
1151         * TestResultServer/static-dashboards/builders.jsonp:
1152
1153 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1154
1155         Unreviewed GTK gardening.
1156
1157         * Scripts/run-gtk-tests:
1158         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1159
1160 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1161
1162         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1163         https://bugs.webkit.org/show_bug.cgi?id=113287
1164
1165         Reviewed by Jocelyn Turcotte.
1166
1167         * Scripts/run-qtwebkit-tests:
1168         (Options.__init__):
1169
1170 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1171
1172         [EFL] Enable IndexedDB by default
1173         https://bugs.webkit.org/show_bug.cgi?id=107248
1174
1175         Reviewed by Laszlo Gombos.
1176
1177         * Scripts/webkitperl/FeatureList.pm:
1178         Enable IndexedDB by default on EFL.
1179
1180 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1181
1182         Sheriffbot should explain rollout failures in a human readable form.
1183         https://bugs.webkit.org/show_bug.cgi?id=107092
1184
1185         Reviewed by Ryosuke Niwa.
1186
1187         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1188
1189         * Scripts/webkitpy/tool/bot/irc_command.py:
1190         (Rollout._check_diff_failure):
1191         (Rollout.execute):
1192         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1193         (IRCCommandTest.test_rollout):
1194
1195 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1196
1197         Unreviewed GTK gardening.
1198
1199         * Scripts/run-gtk-tests:
1200         (TestRunner): Skipping a failing unit test after r146518.
1201
1202 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1203
1204         Remove Lion leaks builder
1205         https://bugs.webkit.org/show_bug.cgi?id=113252
1206
1207         Reviewed by Andreas Kling.
1208
1209         Removed.
1210
1211         * BuildSlaveSupport/build.webkit.org-config/config.json:
1212
1213 2013-03-25  Kent Tamura  <tkent@chromium.org>
1214
1215         Rename ENABLE_INPUT_TYPE_DATETIME
1216         https://bugs.webkit.org/show_bug.cgi?id=113254
1217
1218         Reviewed by Kentaro Hara.
1219
1220         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1221         Actually I'd like to remove the code, but we shouldn't remove it yet
1222         because we shipped products with it on some platforms.
1223
1224         * Scripts/webkitperl/FeatureList.pm:
1225         * qmake/mkspecs/features/features.pri:
1226
1227 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1228
1229         Remove one more line that was intended to be removed in r146657.
1230
1231         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1232         (summarize_results):
1233
1234 2013-03-25  Roger Fong  <roger_fong@apple.com>
1235
1236         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1237         Re-enable WinEWS tests.
1238
1239         * Scripts/webkitpy/common/config/ports.py:
1240         (WinPort.run_bindings_tests_command):
1241         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1242         (WinEWS):
1243
1244 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1245
1246         Unreviewed, rolling out r146793.
1247         http://trac.webkit.org/changeset/146793
1248         https://bugs.webkit.org/show_bug.cgi?id=113248
1249
1250         Fix did not work (Requested by rfong on #webkit).
1251
1252         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1253         (WinEWS):
1254
1255 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1256
1257         REGRESSION(r146657): Test failures reported incorrectly
1258         https://bugs.webkit.org/show_bug.cgi?id=113223
1259
1260         Reviewed by Dirk Pranke.
1261
1262         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1263
1264         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1265         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1266
1267         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1268         (Manager.run):
1269
1270         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1271         (RunDetails.__init__):
1272         (summarize_results): Remove the line I intended to remove in r146657.
1273
1274         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1275         (logging_run): Return details instead of the exit code.
1276         (run_and_capture): Ditto.
1277
1278         (RunTest.test_full_results_html):
1279         (RunTest.test_hung_thread):
1280         (RunTest.test_no_tests_found):
1281         (RunTest.test_no_tests_found_2):
1282         (RunTest.test_repeat_each_iterations_num_tests):
1283         (RunTest.test_run_singly_actually_runs_tests):
1284         (RunTest.test_test_list):
1285         (RunTest.test_missing_and_unexpected_results):
1286         (RunTest.test_pixel_test_directories):
1287         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1288         (RunTest.test_crash_with_stderr):
1289         (RunTest.test_no_image_failure_with_image_diff):
1290         (RunTest.test_crash_log):
1291         (RunTest.test_exit_after_n_failures_upload):
1292         (RunTest.test_results_directory_absolute):
1293         (RunTest.test_results_directory_relative):
1294         (RunTest.test_retrying_and_flaky_tests):
1295         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1296         (RunTest.test_retrying_uses_retries_directory):
1297         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1298         (RunTest.test_output_diffs):
1299         (EndToEndTest.test_reftest_with_two_notrefs):
1300         (RebaselineTest.test_reset_results):
1301         (RebaselineTest.test_missing_results):
1302         (RebaselineTest.test_new_baseline):
1303
1304         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1305         (BuildBotPrinter.print_results):
1306         (BuildBotPrinter.print_unexpected_results):
1307         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1308         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1309
1310 2013-03-25  Julie Parent  <jparent@chromium.org>
1311
1312         Dashboard refactor: Move cross dashboard history related code into history.js.
1313         https://bugs.webkit.org/show_bug.cgi?id=113104
1314
1315         Reviewed by Ojan Vafai.
1316
1317         All functions relating to cross dashboard behavior move from being
1318         globals to methods on the history.History object. Names stay the same,
1319         except many are made private, ones that should have been constants now
1320         are, and the long standing TODO to change "currentState" to 
1321         dashboardSpecificState is done.
1322         
1323         We now create a global history object in dashboard_base, as an 
1324         intermediate measure.  Once the dashboard specific code is
1325         added to history, each DB will need to create its own, and this
1326         global will be eliminated.
1327         
1328         * TestResultServer/static-dashboards/aggregate_results.js:
1329         (handleValidHashParameter):
1330         (htmlForBuilder):
1331         (rawValuesHTML):
1332         * TestResultServer/static-dashboards/dashboard_base.js:
1333         (parseDashboardSpecificParameters):
1334         (defaultValue):
1335         (currentBuilderGroupCategory):
1336         (currentBuilderGroupName):
1337         (handleLocationChange):
1338         (expectationsMap):
1339         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1340         (generatePage):
1341         (.switch.return):
1342         (platformAndBuildType):
1343         (individualTests):
1344         (substringList):
1345         (processMissingAndExtraExpectations):
1346         (pathToFailureLog):
1347         (showPopupForBuild):
1348         (htmlForTestsWithExpectationsButNoFailures):
1349         (shouldHideTest):
1350         (isCrossBuilderView):
1351         (tableHeaders):
1352         (htmlForSingleTestRow):
1353         (htmlForTableColumnHeader):
1354         (generatePageForExpectationsUpdate):
1355         (handleUpdate):
1356         (nextUpdate):
1357         (setUpdateIndex):
1358         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1359         (.appendExpectationsItem):
1360         (loadExpectations):
1361         (.dummyNode.onload):
1362         (loadExpectationsLayoutTests):
1363         (appendExpectations):
1364         (htmlForNavBar):
1365         (checkBoxToToggleState):
1366         (linkHTMLToToggleState):
1367         (generatePageForBuilder):
1368         (isInvalidKeyForCrossBuilderView):
1369         (handleQueryParameterChange):
1370         (showLegend):
1371         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1372         (resetGlobals):
1373         (test):
1374         * TestResultServer/static-dashboards/history.js:
1375         (.):
1376         * TestResultServer/static-dashboards/history_unittests.js:
1377         * TestResultServer/static-dashboards/loader.js:
1378         (.):
1379         * TestResultServer/static-dashboards/loader_unittests.js:
1380         * TestResultServer/static-dashboards/timeline_explorer.js:
1381         (generatePage):
1382         (initCurrentBuilderTestResults):
1383         (selectBuild):
1384         (showResultsDelta):
1385         * TestResultServer/static-dashboards/treemap.js:
1386         (generatePage):
1387         (.switch.return):
1388         (handleFocus):
1389         * TestResultServer/static-dashboards/ui.js:
1390
1391 2013-03-25  Roger Fong  <roger_fong@apple.com>
1392
1393         Unreviewed. Enable WinEWS tests again.
1394
1395         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1396         (WinEWS):
1397
1398 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1399
1400         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1401         https://bugs.webkit.org/show_bug.cgi?id=112166
1402
1403         HarfBuzz 0.9.14 merged my patch for icu detection without
1404         pkg-config files, as needed by for example Ubuntu 12.04.
1405         This obsoletes our local workaround. Removed it for GTK and EFL.
1406
1407         Reviewed by Martin Robinson.
1408
1409         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1410         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1411         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1412         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1413
1414 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1415
1416         Unreviewed.  Move self from contributor to committer list.
1417
1418         * Scripts/webkitpy/common/config/committers.py:
1419
1420 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1421
1422         EWS should use a human readable port name when uploading layout test archives
1423         https://bugs.webkit.org/show_bug.cgi?id=113099
1424
1425         Reviewed by Dirk Pranke.
1426
1427         Use new port's object's name() method to report human readable port names.
1428         This will also help us resolving the bug to apply layout test results posted by EWS.
1429
1430         * Scripts/webkitpy/tool/bot/botinfo.py:
1431         (BotInfo.__init__): Take port's name.
1432         (BotInfo.summary_text):
1433
1434         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1435         (BotInfoTest.test_summary_text):
1436
1437         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1438         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1439
1440         * Scripts/webkitpy/tool/commands/queues.py:
1441         (PatchProcessingQueue.__init__): Initialize self._port.
1442         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1443         and use that for the attachment filename and the comment posted.
1444
1445         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1446         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1447         "mac-snowleopard" as expected for TestPort.
1448
1449 2013-03-22  Roger Fong  <roger_fong@apple.com>
1450
1451         Unreviewed. Turn off EWS test on Win again.
1452         The battle continues.
1453
1454         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1455         (WinEWS):
1456
1457 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1458
1459         NRWT: Enable pixel tests when retrying tests
1460         https://bugs.webkit.org/show_bug.cgi?id=112898
1461
1462         Reviewed by Dirk Pranke.
1463
1464         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1465         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1466         if we've forced pixel tests in the retry.
1467         (Manager._run_tests):
1468         (Manager._clean_up_run): Fixed the capitalizations.
1469         (Manager._force_pixel_tests_if_needed): Added.
1470
1471         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1472         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1473         'image_diff_percent' if it doesn't already exist.
1474
1475         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1476         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1477         treat this as a regular regression instead of a flakiness.
1478
1479         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1480         run had image diffs.
1481
1482         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1483         (summarized_results):
1484
1485         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1486         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1487         Also removed some dead code.
1488
1489         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1490         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1491         is set and pixel_tests_enabled is set to false.
1492         (EndToEndTest.test_reftest_with_two_notrefs):
1493
1494 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1495
1496         Make it possible to run layout tests on Retina MBP
1497         https://bugs.webkit.org/show_bug.cgi?id=93673
1498
1499         Reviewed by Ryosuke Niwa.
1500
1501         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1502         windows on 2x machines still run at 1x.
1503
1504         * DumpRenderTree/mac/DumpRenderTree.mm:
1505         (createWebViewAndOffscreenWindow):
1506         Reset the window resolution to 1x on creation.
1507         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
1508         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1509         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
1510         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1511         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
1512         (WTR::PlatformWebView::PlatformWebView):
1513         Add NSWindow details, reset the window resolution to 1x on creation.
1514
1515 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1516
1517         Leak bots shouldn't build
1518         https://bugs.webkit.org/show_bug.cgi?id=112774
1519
1520         Reviewed by Simon Fraser.
1521
1522         Since leak bots use regular debug builds, there is no need to build on these bots.
1523         Simply downloading builds will dramatically improve the cycle time of these bots.
1524
1525         * BuildSlaveSupport/build.webkit.org-config/config.json:
1526         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1527         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
1528         TestFactory instead of BuildAndTestFactory.
1529
1530 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1531
1532         [Qt] Fix the TestWebKitAPI build
1533         https://bugs.webkit.org/show_bug.cgi?id=113044
1534
1535         Reviewed by Tor Arne Vestbø.
1536
1537         The generate-forwarding-headers script would only be run
1538         after the targets in InjectedBundle.pri since the second
1539         addStrictSubdirOrderBetween call in
1540         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
1541         the derived_sources -> injected_bundle order in SUBDIRS.
1542
1543         Fix it by only moving the dependent target at the end of
1544         SUBDIRS, don't touch its dependency.
1545
1546         * qmake/mkspecs/features/functions.prf:
1547
1548 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1549
1550         [EFL][WK2] View is not focused when fullscreen mode toggled
1551         https://bugs.webkit.org/show_bug.cgi?id=113009
1552
1553         Reviewed by Laszlo Gombos.
1554
1555         Set focus on view when fullscreen mode enabled/disabled
1556         by FullScreen API.
1557
1558         * MiniBrowser/efl/main.c:
1559         (on_fullscreen_accept):
1560         (on_fullscreen_deny):
1561
1562 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1563
1564         nrwt is no longer saving retry results in the retries/ subdirectory
1565         https://bugs.webkit.org/show_bug.cgi?id=112995
1566
1567         Reviewed by Ojan Vafai.
1568
1569         I think this has been broken a long time, unfortunately. This
1570         patch should fix that.
1571
1572         In order to do so, I had to pass the directory to use from
1573         the Worker object through the SingleTestWriter to the
1574         TestResultWriter. While I was plumbing that through, I rationalized
1575         the order of the parameter arguments a bit ...
1576
1577         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1578         (Worker._run_single_test):
1579         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1580         (run_single_test):
1581         (SingleTestRunner.__init__):
1582         (SingleTestRunner._run_compare_test):
1583         (SingleTestRunner._run_rebaseline):
1584         (SingleTestRunner._run_reftest):
1585         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1586         (write_test_result):
1587         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1588         (TestResultWriterTest.test_reftest_diff_image):
1589         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1590         (RunTest.test_retrying_uses_retries_directory):
1591
1592 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
1593
1594         JSC profiler should have an at-a-glance report of the success of DFG optimization
1595         https://bugs.webkit.org/show_bug.cgi?id=112988
1596
1597         Reviewed by Geoffrey Garen.
1598
1599         * Scripts/display-profiler-output:
1600
1601 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1602
1603         [chromium] Linux ASAN WebKit canary is running out of memory
1604         https://bugs.webkit.org/show_bug.cgi?id=112978
1605
1606         Reviewed by Tony Chang.
1607
1608         Running the AddressSanitizer on a crash takes a lot of
1609         memory, so we should serialize access to it to avoid running
1610         out of memory on a machine.
1611
1612         * Scripts/webkitpy/layout_tests/port/chromium.py:
1613         (ChromiumPort._get_crash_log):
1614         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1615         (HttpLock.__init__):
1616         (HttpLock.wait_for_httpd_lock):
1617
1618 2013-03-21  Min Qin  <qinmin@chromium.org>
1619
1620         Cleanup android media layout test code
1621         https://bugs.webkit.org/show_bug.cgi?id=112944
1622
1623         Reviewed by Adam Barth.
1624
1625         Chromium change: https://codereview.chromium.org/12892010/
1626         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
1627         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
1628         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
1629         Instead, we should switch to use content shell for layout tests.
1630
1631         * DumpRenderTree/chromium/TestShell.cpp:
1632         (TestShell::resetTestController):
1633
1634 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1635
1636         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
1637         https://bugs.webkit.org/show_bug.cgi?id=112953
1638
1639         Reviewed by Tony Chang.
1640
1641         When I created the DumpRenderTree_resources target in r144863 I
1642         forgot to declare the needed dependencies on the other resource
1643         targets. Due to a quirk of ordering, this appears to have been fine
1644         w/ ninja but not w/ Xcode (which is still being used on the chromium
1645         mac valgrind bots). Declaring the dependencies fixes the build
1646         failures.
1647
1648         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1649
1650 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
1651
1652         [WinCairo] Correct assert in Empty BitmapImage Test.
1653         https://bugs.webkit.org/show_bug.cgi?id=112934
1654
1655         Reviewed by Tim Horton.
1656
1657         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1658         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
1659         to avoid ref counting assertion when leaving test scope.
1660
1661 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
1662
1663         [GTK] generate-feature-defines-files is incompatible with Python3
1664         https://bugs.webkit.org/show_bug.cgi?id=112956
1665
1666         Reviewed by Martin Robinson.
1667
1668         Make the generate-feature-defines-files compatible with Python3 by calling the items()
1669         method on the dictionary objects when iterating through said dictionaries.
1670
1671         * gtk/generate-feature-defines-files:
1672         (write_feature_defines_header):
1673         (write_flattened_feature_defines_file):
1674
1675 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1676
1677         kill-old-processes spits out error messages on Mac
1678         https://bugs.webkit.org/show_bug.cgi?id=112878
1679
1680         Reviewed by Jessie Berlin.
1681
1682         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
1683         included in the list of options grep --help shows.
1684
1685         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
1686
1687         * BuildSlaveSupport/kill-old-processes:
1688         (main):
1689
1690 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
1691
1692         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
1693         https://bugs.webkit.org/show_bug.cgi?id=112597
1694
1695         Reviewed by Xan Lopez.
1696
1697         These were introduced for the Chromium port in r105295. We need
1698         dummy implementations in order to compile the BlackBerry port.
1699
1700         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1701         (AccessibilityUIElement::scrollToMakeVisible):
1702         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1703         (AccessibilityUIElement::scrollToGlobalPoint):
1704
1705 2013-03-21  Roger Fong  <roger_fong@apple.com>
1706
1707         Re-enable WinEWS tests following r146376.
1708
1709         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1710         (WinEWS):
1711
1712 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
1713
1714         Unreviewed. Add Bem Jones-Bey to the list of contributors.
1715
1716         * Scripts/webkitpy/common/config/committers.py:
1717
1718 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1719
1720         [GTK] Missing atk in install-dependencies script
1721         https://bugs.webkit.org/show_bug.cgi?id=112272
1722
1723         Reviewed by Gustavo Noronha Silva.
1724
1725         * gtk/install-dependencies: Add missing atk dependency.
1726
1727 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1728
1729         [GTK] Missing backslash in install-dependencies script
1730         https://bugs.webkit.org/show_bug.cgi?id=112907
1731
1732         Reviewed by Philippe Normand.
1733
1734         * gtk/install-dependencies: Add missing backslash to dependencies
1735         list.
1736
1737 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1738
1739         EWS bots have stopped uploading results to bugzilla
1740         https://bugs.webkit.org/show_bug.cgi?id=101091
1741
1742         Reviewed by Adam Barth.
1743
1744         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
1745         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
1746         this relative file path resoled to a file inside a non-existent directory for "zip".
1747
1748         Fixed the bug by resolving both test results directory and zip archive paths in
1749         LayoutTestResultsReader.archive.
1750
1751         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
1752         in the future.
1753
1754         * Scripts/webkitpy/common/system/filesystem_mock.py:
1755         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
1756
1757         * Scripts/webkitpy/common/system/workspace.py:
1758         (Workspace.create_zip): Log the source path when "zip" failed.
1759
1760         * Scripts/webkitpy/common/system/workspace_mock.py:
1761         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
1762
1763         * Scripts/webkitpy/common/system/workspace_unittest.py:
1764         (WorkspaceTest.test_create_zip_exception): Test that.
1765
1766         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1767         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
1768         This is the actual bug fix.
1769
1770         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1771         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
1772
1773 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
1774
1775         [chromium] move WebThemeEngine implementations to TestRunner library
1776         https://bugs.webkit.org/show_bug.cgi?id=112751
1777
1778         Reviewed by Adam Barth.
1779
1780         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1781         * DumpRenderTree/DumpRenderTree.gypi:
1782         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1783         (WebKit):
1784         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1785         (WebTestRunner::TestInterfaces::themeEngine):
1786         (WebTestRunner):
1787         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1788         (WebKit):
1789         (TestInterfaces):
1790         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1791         (WebTestRunner::WebTestInterfaces::themeEngine):
1792         (WebTestRunner):
1793         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1794         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1795         (WebTestRunner):
1796         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1797         (WebTestRunner::WebTestThemeControlWin::box):
1798         (WebTestRunner::WebTestThemeControlWin::line):
1799         (WebTestRunner::WebTestThemeControlWin::triangle):
1800         (WebTestRunner::WebTestThemeControlWin::roundRect):
1801         (WebTestRunner::WebTestThemeControlWin::oval):
1802         (WebTestRunner::WebTestThemeControlWin::circle):
1803         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1804         (WebTestRunner::WebTestThemeControlWin::markState):
1805         (WebTestRunner::WebTestThemeControlWin::draw):
1806         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1807         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1808         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1809         (WebTestRunner):
1810         (WebTestThemeControlWin):
1811         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1812         (WebTestRunner):
1813         (WebTestThemeEngineMac):
1814         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1815         (+[FakeActiveWindow alwaysActiveWindow]):
1816         (+[FakeActiveWindow alwaysInactiveWindow]):
1817         (-[FakeActiveWindow initWithActiveControls:]):
1818         (-[FakeActiveWindow _hasActiveControls]):
1819         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1820         (WebTestRunner):
1821         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1822         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1823         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1824         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1825         (WebTestRunner):
1826         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1827         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1828         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1829         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1830         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1831         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1832         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1833         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1834         (WebTestRunner::WebTestThemeEngineWin::getSize):
1835         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1836         (WebTestRunner):
1837         (WebTestThemeEngineWin):
1838         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1839         * DumpRenderTree/chromium/TestShell.cpp:
1840         (TestShell::initialize):
1841         * DumpRenderTree/chromium/TestShell.h:
1842         (WebKit):
1843         * DumpRenderTree/chromium/TestShellMac.mm:
1844         (platformInit):
1845         * DumpRenderTree/chromium/TestShellWin.cpp:
1846         (platformInit):
1847         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1848
1849 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1850
1851         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
1852
1853         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
1854         New property sheet that does not link against CoreFoundation and
1855         CFNetwork.
1856         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1857         Use new TestWebKitAPICommonWinCairo property sheet.
1858         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1859         Ditto.
1860
1861 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1862
1863         [WinCairo] Unreviewed build fix for VS2010.
1864
1865         Had to add WinCairo-specific property sheets to deal with some
1866         library and path differences with the main Apple port.
1867
1868         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1869         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1870         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1871         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
1872         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
1873         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
1874
1875 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
1876
1877         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
1878         https://bugs.webkit.org/show_bug.cgi?id=112849
1879
1880         Reviewed by Sam Weinig.
1881
1882         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1883         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1884         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1885
1886 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1887
1888         [WinCairo] Build WebKit Tools under VS2010
1889         https://bugs.webkit.org/show_bug.cgi?id=112821
1890
1891         Reviewed by Tim Horton.
1892
1893         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1894         Add WinCairo-specific build target.
1895         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
1896         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
1897         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
1898         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
1899         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1900         Add WinCairo-specific build target.
1901         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1902         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1903         Add WinCairo-specific build target.
1904         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
1905         WinCairo-specific build target.
1906         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
1907         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
1908         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
1909         specific build target.
1910         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
1911         WinCairo-specific build target.
1912         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
1913         * win/record-memory/record-memoryDebugWinCairo.props: Added.
1914         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
1915
1916 2013-03-20  Roger Fong  <roger_fong@apple.com>
1917
1918         API test gardening AppleWin port.
1919
1920         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
1921
1922         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1923         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1924
1925 2013-03-20  Roger Fong  <roger_fong@apple.com>
1926
1927         Test fix for Win EWS bots, catch various errors and restart script if necessary.
1928
1929         * EWSTools/start-queue-win.sh:
1930
1931 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
1932
1933         Unreviewed, add myself to committers.py.
1934
1935 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1936
1937         Unreviewed. Adding another email for me.
1938
1939         * Scripts/webkitpy/common/config/committers.py:
1940
1941 2013-03-20  Justin Novosad  <junov@google.com>
1942
1943         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
1944         https://bugs.webkit.org/show_bug.cgi?id=112605
1945
1946         Reviewed by James Robinson.
1947
1948         Deleting all the code that was used for propagating and supporting
1949         the Chromium setting for disabling deferred 2d canvas rendering.
1950
1951         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1952         (main):
1953         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1954         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1955         (WebTestRunner::WebPreferences::reset):
1956         (WebTestRunner::WebPreferences::applyTo):
1957         * DumpRenderTree/chromium/TestShell.cpp:
1958         (TestShell::TestShell):
1959         (TestShell::resetWebSettings):
1960         (TestShell::runFileTest):
1961         * DumpRenderTree/chromium/TestShell.h:
1962         (TestShell):
1963
1964 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
1965
1966         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
1967         https://bugs.webkit.org/show_bug.cgi?id=112699.
1968
1969         Reviewed by Adam Barth.
1970
1971         * Scripts/webkitpy/layout_tests/port/qt.py:
1972         (QtPort._search_paths):
1973         (QtPort._port_specific_expectations_files):
1974         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1975         (QtPortTest):
1976         (QtPortTest._assert_search_path):
1977         (QtPortTest._assert_expectations_files):
1978
1979 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1980
1981         [Qt] Enable kerning by default
1982         https://bugs.webkit.org/show_bug.cgi?id=112704
1983
1984         Reviewed by Jocelyn Turcotte.
1985
1986         Disable kerning by default, since some reference test expectations
1987         expect kerning to be default off.
1988
1989         * DumpRenderTree/qt/TestRunnerQt.cpp:
1990         (TestRunnerQt::reset):
1991         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1992         (WTR::activateFonts):
1993
1994 2013-03-20  Zeno Albisser  <zeno@webkit.org>
1995
1996         [Qt] Remove empty function stubs from TestRunnerQt.
1997         https://bugs.webkit.org/show_bug.cgi?id=112799
1998
1999         We are reducing the code in TestRunnerQt step by step,
2000         in order to finally replace all of it with the generic
2001         TestRunner implementation.
2002         This patch removes several simple function stubs that
2003         currently do not implement any actual functionality.
2004
2005         Reviewed by Kenneth Rohde Christiansen.
2006
2007         * DumpRenderTree/qt/TestRunnerQt.cpp:
2008         * DumpRenderTree/qt/TestRunnerQt.h:
2009         (TestRunnerQt):
2010
2011 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2012
2013         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2014         https://bugs.webkit.org/show_bug.cgi?id=112687
2015
2016         Reviewed by Kenneth Rohde Christiansen.
2017
2018         Hide the SearchBar by default on window creation.
2019
2020         * MiniBrowser/efl/main.c:
2021         (window_create):
2022
2023 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2024
2025         Unreviewed, rolling out r146304.
2026         http://trac.webkit.org/changeset/146304
2027         https://bugs.webkit.org/show_bug.cgi?id=112788
2028
2029         to many expectations to update (Requested by antonm on
2030         #webkit).
2031
2032         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2033         * DumpRenderTree/DumpRenderTree.gypi:
2034         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2035         (WebKit):
2036         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2037         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2038         (TestInterfaces):
2039         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2040         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2041         * DumpRenderTree/chromium/TestShell.cpp:
2042         (TestShell::initialize):
2043         * DumpRenderTree/chromium/TestShell.h:
2044         (WebKit):
2045         * DumpRenderTree/chromium/TestShellMac.mm:
2046         (platformInit):
2047         * DumpRenderTree/chromium/TestShellWin.cpp:
2048         (platformInit):
2049         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2050         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2051         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2052         (WebThemeControlDRTWin::box):
2053         (WebThemeControlDRTWin::line):
2054         (WebThemeControlDRTWin::triangle):
2055         (WebThemeControlDRTWin::roundRect):
2056         (WebThemeControlDRTWin::oval):
2057         (WebThemeControlDRTWin::circle):
2058         (WebThemeControlDRTWin::nestedBoxes):
2059         (WebThemeControlDRTWin::markState):
2060         (WebThemeControlDRTWin::draw):
2061         (WebThemeControlDRTWin::drawTextField):
2062         (WebThemeControlDRTWin::drawProgressBar):
2063         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2064         (WebThemeControlDRTWin):
2065         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2066         (WebThemeEngineDRTMac):
2067         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2068         (+[FakeActiveWindow alwaysActiveWindow]):
2069         (+[FakeActiveWindow alwaysInactiveWindow]):
2070         (-[FakeActiveWindow initWithActiveControls:]):
2071         (-[FakeActiveWindow _hasActiveControls]):
2072         (WebThemeEngineDRTMac::paintScrollbarThumb):
2073         (stateToHIEnableState):
2074         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2075         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2076         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2077         (webRectToSkIRect):
2078         (drawControl):
2079         (drawTextField):
2080         (drawProgressBar):
2081         (WebThemeEngineDRTWin::paintButton):
2082         (WebThemeEngineDRTWin::paintMenuList):
2083         (WebThemeEngineDRTWin::paintScrollbarArrow):
2084         (WebThemeEngineDRTWin::paintScrollbarThumb):
2085         (WebThemeEngineDRTWin::paintScrollbarTrack):
2086         (WebThemeEngineDRTWin::paintSpinButton):
2087         (WebThemeEngineDRTWin::paintTextField):
2088         (WebThemeEngineDRTWin::paintTrackbar):
2089         (WebThemeEngineDRTWin::paintProgressBar):
2090         (WebThemeEngineDRTWin::getSize):
2091         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2092         (WebThemeEngineDRTWin):
2093         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2094
2095 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2096
2097         [Qt] Support -webkit-font-smoothing
2098         https://bugs.webkit.org/show_bug.cgi?id=106009
2099
2100         Reviewed by Jocelyn Turcotte.
2101
2102         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2103
2104         * DumpRenderTree/qt/TestRunnerQt.cpp:
2105         (TestRunnerQt::reset):
2106
2107 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2108
2109         [GTK] accessibility/aria-scrollbar-role.html is failing
2110         https://bugs.webkit.org/show_bug.cgi?id=98358
2111
2112         Reviewed by Martin Robinson.
2113
2114         Adds support for checking accessibility object's orientation.
2115         Orientation is checked by retrieving proper state of accessibility object.
2116
2117         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2118         (checkElementState):
2119         (AccessibilityUIElement::orientation):
2120         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2121         (WTR::AccessibilityUIElement::orientation):
2122
2123 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2124
2125         [chromium] move WebThemeEngine implementations to TestRunner library
2126         https://bugs.webkit.org/show_bug.cgi?id=112751
2127
2128         Reviewed by Adam Barth.
2129
2130         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2131         * DumpRenderTree/DumpRenderTree.gypi:
2132         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2133         (WebKit):
2134         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2135         (WebTestRunner::TestInterfaces::themeEngine):
2136         (WebTestRunner):
2137         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2138         (WebKit):
2139         (TestInterfaces):
2140         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2141         (WebTestRunner::WebTestInterfaces::themeEngine):
2142         (WebTestRunner):
2143         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2144         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2145         (WebTestRunner):
2146         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2147         (WebTestRunner::WebTestThemeControlWin::box):
2148         (WebTestRunner::WebTestThemeControlWin::line):
2149         (WebTestRunner::WebTestThemeControlWin::triangle):
2150         (WebTestRunner::WebTestThemeControlWin::roundRect):
2151         (WebTestRunner::WebTestThemeControlWin::oval):
2152         (WebTestRunner::WebTestThemeControlWin::circle):
2153         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2154         (WebTestRunner::WebTestThemeControlWin::markState):
2155         (WebTestRunner::WebTestThemeControlWin::draw):
2156         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2157         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2158         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2159         (WebTestRunner):
2160         (WebTestThemeControlWin):
2161         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2162         (WebTestRunner):
2163         (WebTestThemeEngineMac):
2164         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2165         (+[FakeActiveWindow alwaysActiveWindow]):
2166         (+[FakeActiveWindow alwaysInactiveWindow]):
2167         (-[FakeActiveWindow initWithActiveControls:]):
2168         (-[FakeActiveWindow _hasActiveControls]):
2169         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2170         (WebTestRunner):
2171         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2172         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2173         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2174         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2175         (WebTestRunner):
2176         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2177         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2178         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2179         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2180         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2181         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2182         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2183         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2184         (WebTestRunner::WebTestThemeEngineWin::getSize):
2185         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2186         (WebTestRunner):
2187         (WebTestThemeEngineWin):
2188         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2189         * DumpRenderTree/chromium/TestShell.cpp:
2190         (TestShell::initialize):
2191         * DumpRenderTree/chromium/TestShell.h:
2192         (WebKit):
2193         * DumpRenderTree/chromium/TestShellMac.mm:
2194         (platformInit):
2195         * DumpRenderTree/chromium/TestShellWin.cpp:
2196         (platformInit):
2197         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2198
2199 2013-03-19  Tony Chang  <tony@chromium.org>
2200
2201         Move testRunner.setTouchDragDropEnabled to internals.settings
2202         https://bugs.webkit.org/show_bug.cgi?id=112739
2203
2204         Reviewed by Adam Barth.
2205
2206         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2207         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2208         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2209         (TestRunner): Remove unnecessary code.
2210         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2211         (WebTestRunner::WebPreferences::reset):
2212         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2213
2214 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2215
2216         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2217         https://bugs.webkit.org/show_bug.cgi?id=112754
2218
2219         Reviewed by Darin Fisher.
2220
2221         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2222         now that it's always defined.
2223
2224         * DumpRenderTree/chromium/WebViewHost.cpp:
2225         * DumpRenderTree/chromium/WebViewHost.h:
2226         (WebViewHost):
2227
2228 2013-03-19  Kenneth Russell  <kbr@google.com>
2229
2230         Unreviewed, rolling out r146290.
2231         http://trac.webkit.org/changeset/146290
2232         https://bugs.webkit.org/show_bug.cgi?id=112751
2233
2234         Broke Chromium Mac build.
2235
2236         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2237         * DumpRenderTree/DumpRenderTree.gypi:
2238         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2239         (WebKit):
2240         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2241         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2242         (TestInterfaces):
2243         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2244         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2245         * DumpRenderTree/chromium/TestShell.cpp:
2246         (TestShell::initialize):
2247         * DumpRenderTree/chromium/TestShell.h:
2248         (WebKit):
2249         * DumpRenderTree/chromium/TestShellMac.mm:
2250         (platformInit):
2251         * DumpRenderTree/chromium/TestShellWin.cpp:
2252         (platformInit):
2253         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2254         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2255         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2256         (WebThemeControlDRTWin::box):
2257         (WebThemeControlDRTWin::line):
2258         (WebThemeControlDRTWin::triangle):
2259         (WebThemeControlDRTWin::roundRect):
2260         (WebThemeControlDRTWin::oval):
2261         (WebThemeControlDRTWin::circle):
2262         (WebThemeControlDRTWin::nestedBoxes):
2263         (WebThemeControlDRTWin::markState):
2264         (WebThemeControlDRTWin::draw):
2265         (WebThemeControlDRTWin::drawTextField):
2266         (WebThemeControlDRTWin::drawProgressBar):
2267         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2268         (WebThemeControlDRTWin):
2269         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2270         (WebThemeEngineDRTMac):
2271         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2272         (+[FakeActiveWindow alwaysActiveWindow]):
2273         (+[FakeActiveWindow alwaysInactiveWindow]):
2274         (-[FakeActiveWindow initWithActiveControls:]):
2275         (-[FakeActiveWindow _hasActiveControls]):
2276         (WebThemeEngineDRTMac::paintScrollbarThumb):
2277         (stateToHIEnableState):
2278         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2279         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2280         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2281         (webRectToSkIRect):
2282         (drawControl):
2283         (drawTextField):
2284         (drawProgressBar):
2285         (WebThemeEngineDRTWin::paintButton):
2286         (WebThemeEngineDRTWin::paintMenuList):
2287         (WebThemeEngineDRTWin::paintScrollbarArrow):
2288         (WebThemeEngineDRTWin::paintScrollbarThumb):
2289         (WebThemeEngineDRTWin::paintScrollbarTrack):
2290         (WebThemeEngineDRTWin::paintSpinButton):
2291         (WebThemeEngineDRTWin::paintTextField):
2292         (WebThemeEngineDRTWin::paintTrackbar):
2293         (WebThemeEngineDRTWin::paintProgressBar):
2294         (WebThemeEngineDRTWin::getSize):
2295         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2296         (WebThemeEngineDRTWin):
2297         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2298
2299 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2300
2301         [EFL] canvas-fallback-content.html is failing
2302         https://bugs.webkit.org/show_bug.cgi?id=111998
2303
2304         Reviewed by Chris Fleizach.
2305
2306         Adds support for getting platform name.
2307
2308         * DumpRenderTree/TestRunner.cpp:
2309         (TestRunner::staticValues):
2310         * DumpRenderTree/TestRunner.h:
2311         (TestRunner):
2312         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2313         (TestRunner::platformName):
2314
2315 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2316
2317         [chromium] move WebThemeEngine implementations to TestRunner library
2318         https://bugs.webkit.org/show_bug.cgi?id=112751
2319
2320         Reviewed by Adam Barth.
2321
2322         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2323         * DumpRenderTree/DumpRenderTree.gypi:
2324         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2325         (WebKit):
2326         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2327         (WebTestRunner::TestInterfaces::themeEngine):
2328         (WebTestRunner):
2329         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2330         (WebKit):
2331         (TestInterfaces):
2332         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2333         (WebTestRunner::WebTestInterfaces::themeEngine):
2334         (WebTestRunner):
2335         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2336         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2337         (WebTestRunner):
2338         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2339         (WebTestRunner::WebTestThemeControlWin::box):
2340         (WebTestRunner::WebTestThemeControlWin::line):
2341         (WebTestRunner::WebTestThemeControlWin::triangle):
2342         (WebTestRunner::WebTestThemeControlWin::roundRect):
2343         (WebTestRunner::WebTestThemeControlWin::oval):
2344         (WebTestRunner::WebTestThemeControlWin::circle):
2345         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2346         (WebTestRunner::WebTestThemeControlWin::markState):
2347         (WebTestRunner::WebTestThemeControlWin::draw):
2348         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2349         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2350         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2351         (WebTestRunner):
2352         (WebTestThemeControlWin):
2353         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2354         (WebTestRunner):
2355         (WebTestThemeEngineMac):
2356         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2357         (+[FakeActiveWindow alwaysActiveWindow]):
2358         (+[FakeActiveWindow alwaysInactiveWindow]):
2359         (-[FakeActiveWindow initWithActiveControls:]):
2360         (-[FakeActiveWindow _hasActiveControls]):
2361         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2362         (WebTestRunner):
2363         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2364         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2365         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2366         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2367         (WebTestRunner):
2368         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2369         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2370         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2371         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2372         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2373         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2374         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2375         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2376         (WebTestRunner::WebTestThemeEngineWin::getSize):
2377         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2378         (WebTestRunner):
2379         (WebTestThemeEngineWin):
2380         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2381         * DumpRenderTree/chromium/TestShell.cpp:
2382         (TestShell::initialize):
2383         * DumpRenderTree/chromium/TestShell.h:
2384         (WebKit):
2385         * DumpRenderTree/chromium/TestShellMac.mm:
2386         (platformInit):
2387         * DumpRenderTree/chromium/TestShellWin.cpp:
2388         (platformInit):
2389         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2390
2391 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2392
2393         [EFL][WK2] Separate WebView further from EwkView
2394         https://bugs.webkit.org/show_bug.cgi?id=111591
2395
2396         Reviewed by Caio Marcelo de Oliveira Filho.
2397
2398         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2399         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2400         since we can afford it having EWKViewGetWKView() private API to access WKView.
2401
2402         * TestWebKitAPI/PlatformWebView.h:
2403         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2404         (TestWebKitAPI::TEST):
2405         * TestWebKitAPI/efl/PlatformWebView.cpp:
2406         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2407         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2408         (TestWebKitAPI::PlatformWebView::resizeTo):
2409         (TestWebKitAPI::PlatformWebView::page):
2410         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2411         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2412         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2413         * WebKitTestRunner/PlatformWebView.h:
2414         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2415         (WTR::EventSenderProxy::dispatchEvent):
2416         (WTR::EventSenderProxy::keyDown):
2417         (WTR::EventSenderProxy::sendTouchEvent):
2418         (WTR::EventSenderProxy::setTouchModifier):
2419         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2420         (WTR::PlatformWebView::PlatformWebView):
2421         (WTR::PlatformWebView::~PlatformWebView):
2422         (WTR::PlatformWebView::resizeTo):
2423         (WTR::PlatformWebView::page):
2424         (WTR::PlatformWebView::focus):
2425         (WTR::PlatformWebView::windowSnapshotImage):
2426
2427 2013-03-19  Roger Fong  <roger_fong@apple.com>
2428
2429         Changes to VS2010 project files should only trigger builds on Windows bots.
2430         https://bugs.webkit.org/show_bug.cgi?id=112731
2431
2432         Reviewed by Timothy Horton.
2433
2434         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2435         (_should_file_trigger_build):
2436
2437 2013-03-19  Roger Fong  <roger_fong@apple.com>
2438
2439         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2440
2441         * Scripts/webkitpy/tool/steps/runtests.py:
2442         (RunTests.run):
2443         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2444         (RunTestsTest.test_webkit_run_unit_tests):
2445
2446 2013-03-19  Julie Parent  <jparent@chromium.org>
2447
2448         Dashboards: Introduce history namespace and unit tests.
2449         https://bugs.webkit.org/show_bug.cgi?id=112645
2450
2451         Reviewed by Ojan Vafai.
2452         
2453         Laying the framework for introducing the new history object and
2454         namespace.  This moves only static functions into the history
2455         namespace, and moves corresponding unit tests into seperate
2456         unit test file.
2457
2458         * TestResultServer/static-dashboards/aggregate_results.html:
2459         * TestResultServer/static-dashboards/dashboard_base.js:
2460         (parseCrossDashboardParameters):
2461         (parseDashboardSpecificParameters):
2462         (parseParameters):
2463         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2464         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2465         (.switch.return):
2466         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2467         * TestResultServer/static-dashboards/history.js: Added.
2468         * TestResultServer/static-dashboards/history_unittests.js: Added.
2469         * TestResultServer/static-dashboards/loader.js:
2470         (.):
2471         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2472         * TestResultServer/static-dashboards/run-unittests.html:
2473         * TestResultServer/static-dashboards/timeline_explorer.html:
2474         * TestResultServer/static-dashboards/timeline_explorer.js:
2475         * TestResultServer/static-dashboards/treemap.html:
2476         * TestResultServer/static-dashboards/treemap.js:
2477         (.switch.return):
2478         * TestResultServer/static-dashboards/ui.js:
2479
2480 2013-03-19  Daniel Bates  <dbates@webkit.org>
2481
2482         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2483         https://bugs.webkit.org/show_bug.cgi?id=112732
2484
2485         Reviewed by Eric Seidel.
2486
2487         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2488         of an existing file cannot be applied.
2489
2490         In particular, svn-{apply, unapply} compensate for differences in line endings
2491         by converting the line endings in a diff to match the line endings in the target
2492         file. The diff(1) command precedes the last line of a diff that adds a newline
2493         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2494         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2495         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2496         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2497         the newline characters in this special character sequence to match the line endings
2498         in the target file.
2499
2500         * Scripts/VCSUtils.pm:
2501         (parseDiff):
2502         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2503         Added tests:
2504             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2505             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2506             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2507             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2508         (escapeNewLineCharacters): Added.
2509         (toMacLineEndings): Added.
2510
2511 2013-03-19  James Robinson  <jamesr@chromium.org>
2512
2513         [chromium] Remove compositor settings that don't go through WebKit
2514         https://bugs.webkit.org/show_bug.cgi?id=112718
2515
2516         Reviewed by Adam Barth.
2517
2518         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2519         (main):
2520         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2521         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2522         (WebTestRunner::WebPreferences::reset):
2523         (WebTestRunner::WebPreferences::applyTo):
2524         * DumpRenderTree/chromium/TestShell.cpp:
2525         (TestShell::TestShell):
2526         (TestShell::resetWebSettings):
2527         * DumpRenderTree/chromium/TestShell.h:
2528         (TestShell):
2529
2530 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
2531
2532         Unreviewed, rolling out r146101.
2533         https://bugs.webkit.org/show_bug.cgi?id=111884
2534
2535         re-enable custom freetype on asan; this needs to be on
2536         now that the bot is running lucid.
2537
2538         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2539
2540 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
2541
2542         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
2543         https://bugs.webkit.org/show_bug.cgi?id=112365
2544
2545         Reviewed by Benjamin Poulain.
2546
2547         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
2548         harcoding it in wtf/Platform.h
2549
2550         * Scripts/webkitperl/FeatureList.pm:
2551
2552 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2553
2554         [Qt] Make ImageDiff similar to Chromium's ImageDiff
2555         https://bugs.webkit.org/show_bug.cgi?id=94782
2556
2557         Based on patch by Csaba Osztrogonác.
2558         Reviewed by Jocelyn Turcotte.
2559
2560         The diff image is generated with bright red indicating errors, but letting the base image
2561         shine through so the context of the error-pixel can be identified.
2562
2563         * DumpRenderTree/qt/ImageDiff.cpp:
2564         (main):
2565
2566 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
2567
2568         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
2569
2570         Rubber-stamped by Csaba Osztrogonác.
2571
2572         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
2573         since the latter might not cover the former.
2574
2575         * QtTestBrowser/launcherwindow.cpp:
2576         (LauncherWindow::print):
2577
2578 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2579
2580         Style tweeks to default.css.
2581         
2582         Rubber-stamped by David Kilzer.
2583         
2584         Give visited links a different color to other links, so you can
2585         see which builds you've viewed.
2586         
2587         Make the <small> text less tiny.
2588
2589         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2590         (small):
2591         (a:link,a:visited,a:active):
2592         (a:visited):
2593
2594 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2595
2596         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
2597         https://bugs.webkit.org/show_bug.cgi?id=112494
2598
2599         Reviewed by Dirk Pranke.
2600
2601         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
2602         Also merged two pairs of methods to cleanup the code.
2603
2604         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2605         (PerfTestsRunner.run): Merged _upload_and_show_results.
2606         (PerfTestsRunner._generate_results): Merged _generate_output_files.
2607
2608 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2609
2610         [chromium] build xdisplaycheck when building DRT
2611         https://bugs.webkit.org/show_bug.cgi?id=112636
2612
2613         Reviewed by Tony Chang.
2614
2615         It appears that we need xdisplaycheck to be built in order for
2616         Xvfb to be started correctly on the bots, and DRT was missing
2617         a dependency on it. This may be the cause of the ASAN bot not
2618         starting up properly (it only builds DRT).
2619
2620         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2621
2622 2013-03-18  David Levin  <levin@chromium.org>
2623
2624         Implement icon change notification dump for Chromium's test shell.
2625         https://bugs.webkit.org/show_bug.cgi?id=112614
2626
2627         This was previously implemented for some other platforms in r58111
2628         and r116547.
2629
2630         In r122806, fast/dom/icon-url-property.html stopped using it, but
2631         it is useful for tests, so I plan to re-add it to that test again.
2632
2633         Reviewed by Jochen Eisinger.
2634
2635         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2636         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
2637          icon change notifications from WebKit may be logged in test output.
2638         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2639         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
2640         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
2641         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
2642         (WebTestRunner):
2643         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
2644         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2645         (TestRunner):
2646         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2647         (WebTestRunner::WebTestProxyBase::didChangeIcon):
2648         (WebTestRunner):
2649         * DumpRenderTree/chromium/WebViewHost.cpp:
2650         (WebViewHost::didChangeIcon): Add the output about changing the icon.
2651         * DumpRenderTree/chromium/WebViewHost.h:
2652         (WebViewHost):
2653
2654 2013-03-18  Julie Parent  <jparent@chromium.org>
2655
2656         Cleanup: Move js for treemap and aggregate_results into own js files.
2657         https://bugs.webkit.org/show_bug.cgi?id=112618
2658
2659         Reviewed by Dirk Pranke.
2660         
2661         No functional changes, just moving the code into separate js file
2662         rather than inlined in the html, so we can test it, make it more
2663         modular, etc.  Other dashboard types are already done this way.
2664
2665         * TestResultServer/static-dashboards/aggregate_results.html:
2666         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
2667         (generatePage):
2668         (handleValidHashParameter):
2669         (htmlForBuilder):
2670         (rawValuesHTML):
2671         (chartHTML):
2672         (filteredValues):
2673         (chart):
2674         (htmlForRevisionRows):
2675         (wrapHTMLInTable):
2676         (htmlForSummaryTable):
2677         (valuesPerExpectation):
2678         (htmlForTestType):
2679         (htmlForTableRow):
2680         (extendedEncode):
2681         * TestResultServer/static-dashboards/treemap.html:
2682         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
2683         (humanReadableTime):
2684         (convertToWebTreemapFormat):
2685         (reverseSortByAverage):
2686         (generatePage):
2687         (focusPath):
2688         (.switch.return):
2689         (handleQueryParameterChange):
2690         (extractName):
2691         (fullName):
2692         (handleFocus.):
2693         (handleFocus):
2694
2695 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2696
2697         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
2698         https://bugs.webkit.org/show_bug.cgi?id=112622
2699
2700         Reviewed by Dirk Pranke.
2701
2702         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2703         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
2704
2705 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2706
2707         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
2708         https://bugs.webkit.org/show_bug.cgi?id=112619
2709
2710         Reviewed by Dirk Pranke.
2711
2712         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
2713         directory and then fall back to the generic LayoutTests/platform/gtk directory.
2714
2715         * Scripts/webkitpy/layout_tests/port/gtk.py:
2716         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
2717         Port._webkit_baseline_path method.
2718         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2719         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
2720         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
2721         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2722         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
2723         that are expected based on the builder name.
2724
2725 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
2726
2727         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
2728         https://bugs.webkit.org/show_bug.cgi?id=112571
2729
2730         Reviewed by Adam Barth.
2731
2732         Update function declarations for new WebFileSystemType enum. (All
2733         changes are behind an #ifdef so we can sync required changes in embedders.)
2734
2735         * DumpRenderTree/chromium/WebViewHost.cpp:
2736         (WebViewHost::openFileSystem):
2737         (WebViewHost::deleteFileSystem):
2738         * DumpRenderTree/chromium/WebViewHost.h:
2739         (WebViewHost):
2740
2741 2013-03-18  Julie Parent  <jparent@chromium.org>
2742
2743         Cleanup: Move timeline_exporer js out of html file into js.
2744         https://bugs.webkit.org/show_bug.cgi?id=112188
2745
2746         Reviewed by Dirk Pranke.
2747         
2748         Moves the javascript out of the html file and into a new js file.
2749         This follows the format of flakiness_dashboard.{html|js}.
2750         
2751         Also moves code from dashboard_base that is used only by this one
2752         dashboard, and makes it private to the dashboard.
2753
2754         * TestResultServer/static-dashboards/dashboard_base.js:
2755         * TestResultServer/static-dashboards/timeline_explorer.html:
2756         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
2757         (generatePage):
2758         (initCurrentBuilderTestResults):
2759         (shouldShowWebKitRevisionsOnly):
2760         (updateTimelineForBuilder.):
2761         (updateTimelineForBuilder):
2762         (selectBuild):
2763         (updateBuildIndicator):
2764         (.addRow):
2765         (.addNumberRow):
2766         (.inspectorNode.getElementsByTagName.0.onclick):
2767         (.inspectorNode.getElementsByTagName.1.onclick):
2768         (.inspectorNode.getElementsByTagName.2.onclick):
2769         (updateBuildInspector):
2770         (showResultsDelta):
2771         (decompressResults.addFlakyDelta):
2772         (decompressResults):
2773
2774 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2775
2776         Unreviewed, rolling out r145272.
2777         http://trac.webkit.org/changeset/145272
2778         https://bugs.webkit.org/show_bug.cgi?id=111884
2779
2780         Turns out the ASAN build is still broken; possibly there's
2781         something still setting LD_LIBRARY_PATH, or possibly there's
2782         something else wrong. In the meantime, we need it to work again.
2783
2784         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2785
2786 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2787
2788         delete-stale-build-files is too aggressive
2789         https://bugs.webkit.org/show_bug.cgi?id=112595
2790
2791         Reviewed by Tim Horton.
2792
2793         It appears that whitelisting file extensions to keep is not a good idea.
2794         Blacklist files to delete instead, and only delete .o files for now.
2795         We can add more file extensions as needed.
2796
2797         * BuildSlaveSupport/delete-stale-build-files:
2798
2799 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2800
2801         Disable accessibility notifications after each test
2802         https://bugs.webkit.org/show_bug.cgi?id=112579
2803
2804         Reviewed by Tim Horton.
2805         
2806         In WebKitTestRunner, if any tests triggered accessibility notifications,
2807         the global notification handler would thereafter be active, and fire
2808         notifications for all subsequent tests.
2809         
2810         Fix by implementing AccessibilityController::resetToConsistentState() for
2811         Mac, and using it to clear the global notification handler.
2812
2813         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2814         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2815         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
2816         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
2817         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
2818         (e.g. because of -autorelease).
2819         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
2820         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
2821         if there is one.
2822         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
2823         Add -stopObserving
2824         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2825         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
2826         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
2827         center.
2828
2829 2013-03-18  Dana Jansens  <danakj@chromium.org>
2830
2831         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
2832         https://bugs.webkit.org/show_bug.cgi?id=112392
2833
2834         Reviewed by James Robinson.
2835
2836         Removes the command line flag option from DRT.
2837
2838         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2839         (main):
2840
2841 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2842
2843         [GTK] plugins/plugin-clip-subframe.html is failing
2844         https://bugs.webkit.org/show_bug.cgi?id=112570
2845
2846         Reviewed by Martin Robinson.
2847
2848         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
2849
2850 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
2851
2852         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
2853         https://bugs.webkit.org/show_bug.cgi?id=112442
2854
2855         Reviewed by Gustavo Noronha Silva.
2856
2857         * GtkLauncher/main.c:
2858         (reloadCb):
2859         (createToolbar):
2860         (createWindow):
2861
2862 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2863
2864         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
2865         https://bugs.webkit.org/show_bug.cgi?id=112205
2866
2867         Disable this API test until Geoff can fix it.
2868
2869         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2870         (TestWebKitAPI::TEST):
2871
2872 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
2873
2874         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2875         https://bugs.webkit.org/show_bug.cgi?id=112478
2876
2877         Reviewed by Tony Chang.
2878
2879         There is nothing that ensures that the log messages from the plugin
2880         come in before the layout test finished loading.
2881
2882         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2883         (PassDifferentNPPStruct::NPP_SetWindow):
2884         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2885         (NPP_SetWindow):
2886
2887 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2888
2889         Have the mac port support per_test_timeout in webkitpy
2890         https://bugs.webkit.org/show_bug.cgi?id=112466
2891
2892         Reviewed by Dirk Pranke.
2893         
2894         Both WTR and DRT handle --timeout arguments, so we can
2895         have the scripts pass the timeout values down to the tools.
2896
2897         * Scripts/webkitpy/layout_tests/port/mac.py:
2898         (MacPort.supports_per_test_timeout):
2899
2900 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
2901
2902         Remove setAsynchronousSpellCheckingEnabled from test runners
2903         https://bugs.webkit.org/show_bug.cgi?id=112362
2904
2905         Reviewed by Tony Chang.
2906
2907         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
2908         in internals.settings, so all ports can share it.
2909
2910         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2911         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2912         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2913         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2914         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2915         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2916         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2917         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
2918         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2919         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
2920         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2921         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2922
2923 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2924
2925         Fix the stupid unit tests.
2926
2927         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2928         (test_sample_process):
2929
2930 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
2931
2932         Collect samples for unresponsive web processes
2933         https://bugs.webkit.org/show_bug.cgi?id=112409
2934
2935         Reviewed by Tim Horton.
2936         
2937         When we detect that a subprocess was unresponsive, run the 'sample'
2938         tool on that process, for the Mac port.
2939         
2940         The sample will be linked to from the results.html page, next
2941         to the crash log link.
2942
2943         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2944         (Manager._look_for_new_crash_logs): Before looking for crash logs,
2945         look for samples on disk.
2946         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2947         (TestResultWriter):
2948         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
2949         -sample.txt files, and have it copy their contents to a new file
2950         next to the test that spawned them (as we do for crash logs).
2951         * Scripts/webkitpy/layout_tests/port/base.py:
2952         (Port.look_for_new_samples): Base class does nothing for sampling.
2953         * Scripts/webkitpy/layout_tests/port/driver.py:
2954         (Driver._check_for_driver_crash): Kick off a sample if we detected
2955         that the subprocess was unresponsive.
2956         * Scripts/webkitpy/layout_tests/port/mac.py:
2957         (MacPort.sample_file_path): Utility to generate the file path
2958         to the generated sample files at the top level of layout-test-results.
2959         (MacPort.look_for_new_crash_logs): Fix typo
2960         (MacPort.look_for_new_samples): New function to find sample files.
2961         (MacPort.sample_process): Use the utility function to get the file path.
2962
2963 2013-03-15  Zeno Albisser  <zeno@webkit.org>
2964
2965         [Qt] Remove simple getters and setters from TestRunnerQt
2966         https://bugs.webkit.org/show_bug.cgi?id=112343
2967
2968         Reviewed by Benjamin Poulain.
2969
2970         The removed functions and boolean members
2971         are being replaced by the implementations in the
2972         generic TestRunner.h.
2973
2974         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2975         (DumpRenderTree::dumpFrameScrollPosition):
2976         (DumpRenderTree::dumpFramesAsText):
2977         (DumpRenderTree::dump):
2978         (DumpRenderTree::titleChanged):
2979         (DumpRenderTree::dumpDatabaseQuota):
2980         (DumpRenderTree::dumpApplicationCacheQuota):
2981         (DumpRenderTree::statusBarMessage):
2982         (DumpRenderTree::createWindow):
2983         * DumpRenderTree/qt/TestRunnerQt.cpp:
2984         (TestRunnerQt::reset):
2985         * DumpRenderTree/qt/TestRunnerQt.h:
2986         (TestRunnerQt):
2987
2988 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
2989
2990         Update the link on build.webkit.org to refer to perf.webkit.org
2991         https://bugs.webkit.org/show_bug.cgi?id=112416
2992
2993         Reviewed by Philip Rogers.
2994
2995         Updated the link. Also updated the template to use HTML5 DOCTYPE.
2996
2997         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2998
2999 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3000
3001         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3002         https://bugs.webkit.org/show_bug.cgi?id=112394
3003
3004         Reviewed by Philippe Normand.
3005
3006         * GtkLauncher/main.c:
3007         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3008
3009 2013-03-14  Andreas Kling  <akling@apple.com>
3010
3011         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3012         <http://webkit.org/b/111815>
3013         <rdar://problem/13380145>
3014
3015         Reviewed by Anders Carlsson.
3016
3017         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3018         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3019         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3020
3021         * WebKitTestRunner/PlatformWebView.h:
3022         (PlatformWebView):
3023         * WebKitTestRunner/TestController.cpp:
3024         (WTR::TestController::createOtherPage):
3025         (WTR::TestController::createWebViewWithOptions):
3026         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3027         (WTR::PlatformWebView::didInitializeClients):
3028
3029 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3030
3031         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3032         https://bugs.webkit.org/show_bug.cgi?id=112122
3033
3034         Reviewed by Kenneth Rohde Christiansen.
3035
3036         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3037
3038         * MiniBrowser/efl/main.c:
3039         (_Browser_Window):
3040         (search_box_show):
3041         (search_box_hide):
3042         (on_key_down):
3043         (on_url_changed):
3044         (on_search_field_aborted):
3045         (on_search_field_activated):
3046         (on_search_field_clicked):
3047         (on_search_backward_button_clicked):
3048         (on_search_forward_button_clicked):
3049         (window_create):
3050
3051 2013-03-14  Julie Parent  <jparent@chromium.org>
3052
3053         Cleanup: Remove g_resourceLoader.
3054         https://bugs.webkit.org/show_bug.cgi?id=112305
3055
3056         Reviewed by Dirk Pranke.
3057         
3058         Removing another global.
3059         
3060         Now, each dashboard creates its own loader, rather than having
3061         a general global one.
3062         
3063         Remove usage of g_resourceLoader.isLoadingComplete from 
3064         handleLocationChange by ensuring that handleLocationChange is
3065         never called before the loader is done.  It was called in two
3066         places before: 1 was from the callback when the loader is done,
3067         so that was obviously true, and the other was from onhashchange,
3068         where it would just return rather than running.  Instead, lets
3069         only register the onhashchange handler once the loader is
3070         setup, so the check is no longer necessary.
3071         
3072         Remove isLoadingComplete since it is now unused.
3073         
3074         Callback for loader is now initializeHistory, rather than just
3075         handleLocationChange which will set up the hashchange handler now.
3076         This will all eventually be moving to a new History object.
3077
3078         * TestResultServer/static-dashboards/aggregate_results.html:
3079         * TestResultServer/static-dashboards/dashboard_base.js:
3080         (handleLocationChange):
3081         (intializeHistory):
3082         (decompressResults):
3083         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3084         (generatePage):
3085         * TestResultServer/static-dashboards/loader.js:
3086         (.):
3087         * TestResultServer/static-dashboards/loader_unittests.js:
3088         * TestResultServer/static-dashboards/timeline_explorer.html:
3089         * TestResultServer/static-dashboards/treemap.html:
3090
3091 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3092
3093         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3094         https://bugs.webkit.org/show_bug.cgi?id=109404
3095
3096         Reviewed by Tony Chang.
3097
3098         Removes all the code related to smartInsertDeleteEnabled and
3099         selectTrailingWhitespaceEnabled settings as they will be managed from
3100         internals from now on.
3101
3102         * DumpRenderTree/TestRunner.cpp:
3103         (TestRunner::staticFunctions):
3104         * DumpRenderTree/TestRunner.h:
3105         (TestRunner):
3106         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3107         (WebKit):
3108         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3109         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3110         (DumpRenderTree):
3111         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3112         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3113         (WebTestRunner::WebTestProxy::didStopLoading):
3114         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3115         (WebTestRunner::TestRunner::TestRunner):
3116         (WebTestRunner::TestRunner::reset):
3117         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3118         (TestRunner):
3119         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3120         (WebTestRunner::WebPreferences::applyTo): Set default values for
3121         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3122         Chromium DRT default values are different from Chromium browser.
3123         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3124         * DumpRenderTree/chromium/WebViewHost.cpp:
3125         * DumpRenderTree/chromium/WebViewHost.h:
3126         (WebViewHost):
3127         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3128         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3129         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3130         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3131         (resetDefaultsToConsistentValues):
3132         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3133         * DumpRenderTree/mac/DumpRenderTree.mm:
3134         (resetWebViewToConsistentStateBeforeTesting):
3135         * DumpRenderTree/mac/TestRunnerMac.mm:
3136         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3137         (WebCore::WebPage::resetSettings):
3138         * DumpRenderTree/qt/TestRunnerQt.cpp:
3139         * DumpRenderTree/qt/TestRunnerQt.h:
3140         (TestRunnerQt):
3141         * DumpRenderTree/win/DumpRenderTree.cpp:
3142         (resetWebViewToConsistentStateBeforeTesting):
3143         * DumpRenderTree/win/TestRunnerWin.cpp:
3144         * DumpRenderTree/wx/TestRunnerWx.cpp:
3145
3146 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3147
3148         [Qt] Disable DRT on Windows
3149
3150         Reviewed by Jocelyn Turcotte.
3151
3152         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3153
3154         * qmake/mkspecs/features/configure.prf:
3155
3156 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3157
3158         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
3159         https://bugs.webkit.org/show_bug.cgi?id=110728
3160
3161         Reviewed by Gyuyoung Kim.
3162
3163         Use the page group to create the view object.
3164
3165         * MiniBrowser/efl/main.c:
3166         (window_create):
3167
3168 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3169
3170         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
3171
3172         Reviewed by Tor Arne Vestbø.
3173
3174         The mock versions of these web facing features should be instantiated when
3175         running in DumpRenderTree only. In order for them to work, no extra Qt modules
3176         such as QtLocation are actually needed.
3177
3178         This patch decouples enabling device orientation/motion and geolocation from
3179         the underlying Qt modules and makes them available in developer builds
3180         (!production_build) and backed by mock backends when running in drt.
3181
3182         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
3183         developers the web facing features are always enabled (although requests will
3184         time out) and the mock backends are enabled inside DRT, allowing for the layout
3185         tests to run with less dependencies.
3186
3187         In addition this also enables the mock device motion client, which was
3188         previously never instantiated.
3189
3190         * qmake/mkspecs/features/features.prf:
3191
3192 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3193
3194         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
3195         https://bugs.webkit.org/show_bug.cgi?id=112340
3196
3197         Reviewed by Simon Hausmann.
3198
3199         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3200         (DumpRenderTree::dump):
3201             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
3202         (DumpRenderTree::dumpApplicationCacheQuota):
3203         * DumpRenderTree/qt/TestRunnerQt.cpp:
3204         (TestRunnerQt::reset):
3205         * DumpRenderTree/qt/TestRunnerQt.h:
3206         (TestRunnerQt):
3207
3208 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3209
3210         [Qt] Port DRT to use TestRunner::dumpAsText()
3211         https://bugs.webkit.org/show_bug.cgi?id=112260
3212
3213         Reviewed by Benjamin Poulain.
3214
3215         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3216         (WebCore::DumpRenderTree::open):
3217         (WebCore::methodNameStringForFailedTest):
3218             Change parameter from type TestRunnerQt* to TestRunner*.
3219         (WebCore::DumpRenderTree::dump):
3220             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3221             Instead we should rely on TestRunner::generatePixelResults().
3222         * DumpRenderTree/qt/TestRunnerQt.cpp:
3223         (TestRunnerQt::reset):
3224         * DumpRenderTree/qt/TestRunnerQt.h:
3225         (TestRunnerQt):
3226
3227 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3228
3229         Implement FontLoader interface
3230         https://bugs.webkit.org/show_bug.cgi?id=98395
3231
3232         Reviewed by Eric Seidel.
3233
3234         Enable FontLoadEvents runtime flag for TestShell.
3235
3236         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3237         (WebTestRunner::TestInterfaces::TestInterfaces):
3238
3239 2013-03-13  Julie Parent  <jparent@chromium.org>
3240
3241         CLeanup: remove unnecessary call to parseParameters.
3242         https://bugs.webkit.org/show_bug.cgi?id=112309
3243
3244         Reviewed by Ojan Vafai.
3245         
3246         We call parseCrossDashboardParameters when the dashboard initially
3247         loads to set the state required for loadBuildersList, and then we
3248         call it again once we are fully done with loading, so there is no
3249         reason to call it in the middle of the loading process here.
3250
3251         * TestResultServer/static-dashboards/loader.js:
3252         (.):
3253
3254 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3255
3256         Unreviewed. Now I'm a reviewer :)
3257
3258         * Scripts/webkitpy/common/config/committers.py:
3259
3260 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3261
3262         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3263         https://bugs.webkit.org/show_bug.cgi?id=112277
3264
3265         Reviewed by Adam Barth.
3266
3267         * Scripts/webkitperl/FeatureList.pm:
3268         * qmake/mkspecs/features/features.pri:
3269
3270 2013-03-13  Adam Barth  <abarth@webkit.org>
3271
3272         run-perf-tests should support content_shell
3273         https://bugs.webkit.org/show_bug.cgi?id=112291
3274
3275         Reviewed by Eric Seidel.
3276
3277         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3278         (PerfTestsRunner._parse_args):
3279
3280 2013-03-13  Oliver Hunt  <oliver@apple.com>
3281
3282         Simplify Checked<> multiplication
3283         https://bugs.webkit.org/show_bug.cgi?id=112286
3284
3285         Reviewed by James Robinson.
3286
3287         Add tests for multiplication by zero and max to ensure we don't
3288         mess them up should we ever make changes to Checked<> in future.
3289
3290         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3291         (TestWebKitAPI):
3292
3293 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3294
3295         [Qt] Unreviewed prospective Windows build fix
3296
3297         Do the usual thing, include the moc generated code in the .cpp file instead
3298         of compiling it standalone, to ensure that config.h is included, too, and
3299         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3300
3301         * DumpRenderTree/qt/EventSenderQt.cpp:
3302
3303 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3304
3305         [Qt] Port TestRunner::findString to shared interface
3306         https://bugs.webkit.org/show_bug.cgi?id=112147
3307
3308         Reviewed by Jocelyn Turcotte.
3309
3310         This patch also removes DumpRenderTree and some other helper classes from
3311         the WebCore namespace, to which they do not really belong.
3312
3313         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3314         (main):
3315         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3316         (DumpRenderTree::DumpRenderTree):
3317         (DumpRenderTree::~DumpRenderTree):
3318         (DumpRenderTree::instance):
3319         (DumpRenderTree::setShouldTimeout):
3320         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3321         (DumpRenderTree):
3322         * DumpRenderTree/qt/EventSenderQt.cpp:
3323         (EventSender::contextClick):
3324         (EventSender::sendEvent):
3325         (EventSender::postEvent):
3326         * DumpRenderTree/qt/EventSenderQt.h:
3327         (EventSender::isGraphicsBased):
3328         * DumpRenderTree/qt/TestRunnerQt.cpp:
3329         (TestRunnerQt::TestRunnerQt):
3330         (TestRunner::findString):
3331         (TestRunnerQt::setMockDeviceOrientation):
3332         (TestRunnerQt::setGeolocationPermission):
3333         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3334         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3335         (TestRunnerQt::setMockGeolocationPosition):
3336         * DumpRenderTree/qt/TestRunnerQt.h:
3337         (TestRunnerQt):
3338
3339 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3340
3341         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3342         https://bugs.webkit.org/show_bug.cgi?id=112129
3343
3344         Reviewed by Adam Barth.
3345
3346         Following Chromium
3347         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3348         this is being renamed to better explain what it does.
3349
3350         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3351
3352 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3353
3354         [Qt] Unreviewed trivial typo fix
3355
3356         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3357         TextRunner.h. Thanks Zeno :)
3358
3359 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3360
3361         [Qt] Prepare DRT for transition to shared TestRunner interface
3362         https://bugs.webkit.org/show_bug.cgi?id=112144
3363
3364         Reviewed by Benjamin Poulain.
3365
3366         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3367         the JSC C API based one.
3368
3369         This is impplemented by instantiating the QObject based testRunner in
3370         the global object, then instantiating the JSC C based TestRunner
3371         separately and placing it "behind" the QObject based testRunner through
3372         injection of the individual functions through proxies. (prototype
3373         chaining doesn't work due to the this object and Function.prototype.bind
3374         doesn't work due to the native function)
3375
3376         This allows for porting over method by method by removing the method
3377         from the QObject TestRunnerQt and implementing it in the JSC C based
3378         TestRunner.
3379
3380         In order for this to link and run dummy implementations of all the
3381         necessary TestRunner functions are provided.
3382
3383         * DumpRenderTree/qt/DumpRenderTree.pro:
3384         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3385         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3386         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3387         (WebCore::DumpRenderTree::initJSObjects):
3388         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3389         (DumpRenderTree):
3390         * DumpRenderTree/qt/TestRunnerQt.cpp:
3391         (TestRunner::~TestRunner):
3392         (TestRunner::addDisallowedURL):
3393         (TestRunner::queueLoad):
3394         (TestRunner::removeAllVisitedLinks):
3395         (TestRunner::setAcceptsEditing):
3396         (TestRunner::simulateLegacyWebNotificationClick):
3397         (TestRunner::setWindowIsKey):
3398         (TestRunner::setAlwaysAcceptCookies):
3399         (TestRunner::addOriginAccessWhitelistEntry):
3400         (TestRunner::setWebViewEditable):
3401         (TestRunner::clearAllApplicationCaches):
3402         (TestRunner::setTextDirection):
3403         (TestRunner::notifyDone):
3404         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3405         (TestRunner::overridePreference):
3406         (TestRunner::pathToLocalResource):
3407         (TestRunner::removeAllWebNotificationPermissions):
3408         (TestRunner::simulateWebNotificationClick):
3409         (TestRunner::closeIdleLocalStorageDatabases):
3410         (TestRunner::focusWebView):
3411         (TestRunner::setBackingScaleFactor):
3412         (TestRunner::removeChromeInputField):
3413         (TestRunner::addChromeInputField):
3414         (TestRunner::originsWithLocalStorage):
3415         (TestRunner::deleteAllLocalStorage):
3416         (TestRunner::deleteLocalStorageForOrigin):
3417         (TestRunner::observeStorageTrackerNotifications):
3418         (TestRunner::syncLocalStorage):
3419         (TestRunner::windowCount):
3420         (TestRunner::setWaitToDump):
3421         (TestRunner::waitForPolicyDelegate):
3422         (TestRunner::webHistoryItemCount):
3423         (TestRunner::showWebInspector):
3424         (TestRunner::closeWebInspector):
3425         (TestRunner::evaluateInWebInspector):
3426         (TestRunner::setSerializeHTTPLoads):
3427         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3428         (TestRunner::setCustomPolicyDelegate):
3429         (TestRunner::setDatabaseQuota):
3430         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3431         (TestRunner::resetPageVisibility):
3432         (TestRunner::keepWebHistory):
3433         (TestRunner::goBack):
3434         (TestRunner::originsWithApplicationCache):
3435         (TestRunner::applicationCacheDiskUsageForOrigin):
3436         (TestRunner::display):
3437         (TestRunner::dispatchPendingLoadRequests):
3438         (TestRunner::clearPersistentUserStyleSheet):
3439         (TestRunner::callShouldCloseOnWebView):
3440         (TestRunner::copyDecodedHostName):
3441         (TestRunner::clearBackForwardList):
3442         (TestRunner::clearAllDatabases):
3443         (TestRunner::clearApplicationCacheForOrigin):
3444         (TestRunner::apiTestGoToCurrentBackForwardItem):
3445         (TestRunner::authenticateSession):
3446         (TestRunner::abortModal):
3447         (TestRunner::setStorageDatabaseIdleInterval):
3448         (TestRunner::setAsynchronousSpellCheckingEnabled):
3449         (TestRunner::setXSSAuditorEnabled):
3450         (TestRunner::setSpatialNavigationEnabled):
3451         (TestRunner::setScrollbarPolicy):
3452         (TestRunner::setJavaScriptCanAccessClipboard):
3453         (TestRunner::setAutomaticLinkDetectionEnabled):
3454         (TestRunner::setUserStyleSheetEnabled):
3455         (TestRunner::setUserStyleSheetLocation):
3456         (TestRunner::setUseDashboardCompatibilityMode):
3457         (TestRunner::setTabKeyCyclesThroughElements):
3458         (TestRunner::setSmartInsertDeleteEnabled):
3459         (TestRunner::setSelectTrailingWhitespaceEnabled):
3460         (TestRunner::setPrivateBrowsingEnabled):
3461         (TestRunner::setPluginsEnabled):
3462         (TestRunner::setPopupBlockingEnabled):
3463         (TestRunner::setMockSpeechInputDumpRect):
3464         (TestRunner::setPersistentUserStyleSheetLocation):
3465         (TestRunner::setMockGeolocationPosition):
3466         (TestRunner::setMockGeolocationPositionUnavailableError):
3467         (TestRunner::setMockDeviceOrientation):
3468         (TestRunner::setMainFrameIsFirstResponder):
3469         (TestRunner::setIconDatabaseEnabled):
3470         (TestRunner::setGeolocationPermission):
3471         (TestRunner::setDefersLoading):
3472         (TestRunner::setCacheModel):
3473         (TestRunner::setAuthorAndUserStylesEnabled):
3474         (TestRunner::setAllowFileAccessFromFileURLs):
3475         (TestRunner::setAppCacheMaximumSize):
3476         (TestRunner::setAllowUniversalAccessFromFileURLs):
3477         (TestRunner::setApplicationCacheOriginQuota):
3478         (TestRunner::denyWebNotificationPermission):
3479         (TestRunner::grantWebNotificationPermission):
3480         (TestRunner::setValueForUser):
3481         (TestRunner::setViewModeMediaFeature):
3482         (TestRunner::setPageVisibility):
3483         (TestRunner::addMockSpeechInputResult):
3484         (TestRunner::removeOriginAccessWhitelistEntry):
3485         (TestRunner::addUserScript):
3486         (TestRunner::isCommandEnabled):
3487         (TestRunner::evaluateScriptInIsolatedWorld):
3488         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3489         (TestRunner::copyEncodedHostName):
3490         (TestRunner::addUserStyleSheet):
3491         (TestRunner::findString):
3492         (TestRunner::execCommand):
3493         (TestRunner::localStorageDiskUsageForOrigin):
3494
3495 2013-03-12  Julie Parent  <jparent@chromium.org>
3496
3497         Cleanup: Move flatten-trie to loader.
3498         https://bugs.webkit.org/show_bug.cgi?id=112196
3499
3500         Reviewed by Dirk Pranke.
3501
3502         flatten-trie is used only by the loader, so move it there and make it
3503         private, rather than global in dashbaord_base. Moved the corresponding
3504         unit test from flakiness_dashboard_unittests to loader_unittests.
3505         
3506         * TestResultServer/static-dashboards/dashboard_base.js:
3507         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3508         * TestResultServer/static-dashboards/loader.js:
3509         (.):
3510         * TestResultServer/static-dashboards/loader_unittests.js:
3511
3512 2013-03-12  Oliver Hunt  <oliver@apple.com>
3513
3514         Unbreak api tests
3515
3516         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3517         (TestWebKitAPI):
3518
3519 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3520
3521         Unreviewed, disabling tests for Win EWS.
3522
3523         win-ews obviously cannot keep up with running tests, it's >300 behind.
3524         Probably doesn't help that its (likely) running tests serially.
3525
3526         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3527         (WinEWS):
3528
3529 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3530
3531         Add a --build-directory argument to delete-stale-build-files
3532         https://bugs.webkit.org/show_bug.cgi?id=112198
3533
3534         Reviewed by Ryosuke Niwa.
3535
3536         * BuildSlaveSupport/delete-stale-build-files:
3537         (main): Add --build-directory argument.
3538
3539 2013-03-12  Oliver Hunt  <oliver@apple.com>
3540
3541         Appease MSVC
3542
3543         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3544         (TestWebKitAPI):
3545
3546 2013-03-12  Oliver Hunt  <oliver@apple.com>
3547
3548         Add more Checked<> tests
3549         https://bugs.webkit.org/show_bug.cgi?id=112190
3550
3551         Reviewed by Geoffrey Garen.
3552
3553         Tests!
3554
3555         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3556         (TestWebKitAPI):
3557
3558 2013-03-12  Julie Parent  <jparent@chromium.org>
3559
3560         Cleanup: Move loading complete function into callback, rather than global.
3561         https://bugs.webkit.org/show_bug.cgi?id=112167
3562
3563         Reviewed by Dirk Pranke.
3564         
3565         Stop calling global functions, pass in proper handler to Loader
3566         constructor. Note that the callback is optional, as tests, and
3567         some potential dashboards, do not need one.
3568
3569         * TestResultServer/static-dashboards/dashboard_base.js:
3570         * TestResultServer/static-dashboards/loader.js:
3571         (.):
3572         * TestResultServer/static-dashboards/loader_unittests.js:
3573
3574 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3575
3576         [EFL][WK2] Add popup menu support to MiniBrowser
3577         https://bugs.webkit.org/show_bug.cgi?id=108934
3578
3579         Reviewed by Kenneth Rohde Christiansen.
3580
3581         Implement popup menu support in MiniBrowser by handling popup_menu_show
3582         and popup_menu_hide smart functions on the view and using the Ewk popup
3583         menu API.
3584
3585         * MiniBrowser/efl/main.c:
3586         (_Browser_Window):
3587         (on_popup_menu_discarded):
3588         (on_popup_menu_item_clicked):
3589         (popup_menu_populate):
3590         (on_popup_menu_show):
3591         (on_popup_menu_hide):
3592         (window_create): Use calloc() instead of malloc() to allocate memory for
3593         Browser_Window. This makes sure all the structs members are initialized
3594         to 0 (such as the new elm_popup_menu pointer).
3595
3596 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3597
3598         [GTK] Set up the libPlatformGtk.la library
3599         https://bugs.webkit.org/show_bug.cgi?id=111738
3600
3601         Reviewed by Martin Robinson.
3602
3603         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3604         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
3605         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3606
3607 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3608
3609         [GTK] Enable Web Audio in development builds
3610         https://bugs.webkit.org/show_bug.cgi?id=111831
3611
3612         Reviewed by Philippe Normand.
3613
3614         Web Audio is already quite well supported on the GTK port but still has a few issues
3615         that must be addressed before it is enabled by default. Despite that it should be enabled
3616         in development builds just so we are up-to-date with future feature infrastructure changes.
3617         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3618         that's an obvious goal before enabling the feature in release builds.
3619
3620         * Scripts/webkitperl/FeatureList.pm:
3621
3622 2013-03-11  Andreas Kling  <akling@apple.com>
3623
3624         [Mac][WK1] Add support for alert() in MiniBrowser.
3625         <http://webkit.org/b/112090>
3626
3627         Reviewed by Anders Carlsson.
3628
3629         * MiniBrowser/mac/WK1BrowserWindowController.m:
3630         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3631
3632 2013-03-11  Julie Parent  <jparent@chromium.org>
3633
3634         Dashboard cleanup: Create ui.Errors
3635         https://bugs.webkit.org/show_bug.cgi?id=111785
3636
3637         Reviewed by Ojan Vafai.
3638         
3639         Create ui.Errors for handling errors the dashboards
3640         encounter. Loader now has a Error object that it can add to,
3641         and individual dashboards can show errors when desired.
3642         Currently, only flakiness_db shows errors, but this is 
3643         generic and there is no reason why other dbs wouldn't want to
3644         show errors.
3645
3646         * TestResultServer/static-dashboards/dashboard_base.js:
3647         (resourceLoadingComplete):
3648         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3649         (generatePage):
3650         * TestResultServer/static-dashboards/loader.js:
3651         (.):
3652         * TestResultServer/static-dashboards/ui.js:
3653         (.):
3654
3655 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
3656
3657         Some StringHasher tests are broken because of missing null termination
3658         https://bugs.webkit.org/show_bug.cgi?id=111284
3659
3660         Reviewed by Darin Adler.
3661
3662         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3663         (TestWebKitAPI): Added null termination since C strings are null-terminated.
3664         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
3665         the bug caught by it is now fixed.
3666
3667 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3668
3669         Unreviewed, rolling out r145200.
3670         http://trac.webkit.org/changeset/145200
3671         https://bugs.webkit.org/show_bug.cgi?id=112063
3672
3673         Broke a couple of unit tests (Requested by zdobersek on
3674         #webkit).
3675
3676         * Scripts/webkitperl/FeatureList.pm:
3677
3678 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
3679
3680         [GTK] WebKit2-only build fails
3681         https://bugs.webkit.org/show_bug.cgi?id=112033
3682
3683         Reviewed by Gustavo Noronha Silva.
3684
3685         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
3686         generic part, WebKit1-specific part and WebKit2-specific part.
3687         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
3688         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
3689         directly.
3690
3691 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
3692
3693         Adding myself to the committers list.
3694
3695         Unreviewed.
3696
3697         * Scripts/webkitpy/common/config/committers.py:
3698
3699 2013-03-11  Jeff Rogers  <jrogers@rim.com>
3700
3701         [BlackBerry] Disable MathML support
3702         https://bugs.webkit.org/show_bug.cgi?id=111929
3703
3704         Reviewed by Rob Buis.
3705
3706         * Scripts/webkitperl/FeatureList.pm:
3707
3708 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3709
3710         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
3711         https://bugs.webkit.org/show_bug.cgi?id=111970
3712
3713         Reviewed by Chris Fleizach.
3714
3715         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
3716         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
3717         undefined symbol.
3718
3719         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3720         (WTR::AccessibilityUIElement::supportedActions):
3721         (WTR):
3722
3723 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
3724
3725         [chromium] Android apk targets should depend directly on Java library targets
3726         https://bugs.webkit.org/show_bug.cgi?id=111746
3727
3728         Reviewed by Eric Seidel.
3729
3730         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3731         Make DumpRenderTree_apk depend directly on base_java and net_java.
3732         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3733         Make TestWebKitAPI_apk depend directly on base_java.
3734
3735 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
3736
3737         [chromium] remove obsolete user gesture methods from WebFrame
3738         https://bugs.webkit.org/show_bug.cgi?id=111696
3739
3740         Reviewed by Adam Barth.
3741
3742         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3743         (WebTestRunner::TestPlugin::handleInputEvent):
3744         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3745
3746 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
3747
3748         Unreviewed, add myself to commiters.py.
3749
3750         * Scripts/webkitpy/common/config/committers.py:
3751
3752 2013-03-08  Julie Parent  <jparent@chromium.org>
3753
3754         Cleanup: Remove dead code.
3755         https://bugs.webkit.org/show_bug.cgi?id=111900
3756
3757         Reviewed by Dirk Pranke.
3758         
3759         Treemap overrides a global function that used to be in 
3760         dashboard_base, but was removed months ago in
3761         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
3762         no caller. 
3763
3764         * TestResultServer/static-dashboards/treemap.html:
3765
3766 2013-03-08  Harald Alvestrand  <hta@chromium.org>
3767
3768         Implemented new API for RTCStatsReport object.
3769         https://bugs.webkit.org/show_bug.cgi?id=110333
3770
3771         Reviewed by Adam Barth.
3772
3773         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3774         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
3775
3776 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
3777
3778         [chromium] use custom freetype on linux asan builds again
3779         https://bugs.webkit.org/show_bug.cgi?id=111884
3780
3781         Reviewed by Tony Chang.
3782
3783         We no longer need the workaround after chromium r186540.
3784
3785         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3786
3787 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
3788
3789         Warning about the user not having edit rights on Bugzilla is confusing new contributors
3790         https://bugs.webkit.org/show_bug.cgi?id=111798
3791
3792         Reviewed by Dirk Pranke.
3793
3794         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
3795
3796         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3797
3798 2013-03-08  James Robinson  <jamesr@chromium.org>
3799
3800         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
3801         https://bugs.webkit.org/show_bug.cgi?id=111632
3802
3803         Reviewed by Adrienne Walker.
3804
3805         * DumpRenderTree/chromium/WebViewHost.cpp:
3806         (WebViewHost::initializeLayerTreeView):
3807         * DumpRenderTree/chromium/WebViewHost.h:
3808         (WebViewHost):
3809
3810 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
3811
3812         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
3813         https://bugs.webkit.org/show_bug.cgi?id=111297
3814
3815         Reviewed by Kenneth Rohde Christiansen.
3816
3817         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3818         (WTR::TestRunner::setViewModeMediaFeature):
3819
3820 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
3821
3822         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
3823         https://bugs.webkit.org/show_bug.cgi?id=111814
3824
3825         Reviewed by Ryosuke Niwa.
3826
3827         Add the needed supportedActions() attribute to WKTestRunner.
3828
3829         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3830         (WTR::AccessibilityUIElement::supportedActions):
3831         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3832         (AccessibilityUIElement):
3833         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3834         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3835         (WTR::AccessibilityUIElement::supportedActions):
3836
3837 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3838
3839         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
3840         https://bugs.webkit.org/show_bug.cgi?id=111851
3841
3842         Reviewed by Kenneth Rohde Christiansen.
3843
3844         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3845         (TestWebKitAPI::TEST):
3846
3847             Fixed WKURLRef instance leaking.
3848
3849 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3850
3851         [EFL] [WK2] Some authentication tests fail in WebKit2
3852         https://bugs.webkit.org/show_bug.cgi?id=106407
3853
3854         Reviewed by Kenneth Rohde Christiansen.
3855
3856         Add patch from upstream for libsoup 2.40 to fix several authentication
3857         test cases.
3858
3859         * efl/jhbuild.modules:
3860         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
3861
3862 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
3863
3864         [GTK] Enable Web Audio in development builds
3865         https://bugs.webkit.org/show_bug.cgi?id=111831
3866
3867         Reviewed by Philippe Normand.
3868
3869         Web Audio is already quite well supported on the GTK port but still has a few issues
3870         that must be addressed before it is enabled by default. Despite that it should be enabled
3871         in development builds just so we are up-to-date with future feature infrastructure changes.
3872         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3873         that's an obvious goal before enabling the feature in release builds.
3874
3875         * Scripts/webkitperl/FeatureList.pm:
3876
3877 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3878
3879         [chromium] delay clearing the TestRunners until the main view was deleted
3880         https://bugs.webkit.org/show_bug.cgi?id=111823
3881
3882         Reviewed by Eric Seidel.
3883
3884         During WebViewHost::shutdown, we navigate the WebView to about:blank.
3885         This may call into the test runners which assume that the delegate is
3886         always non-NULL.
3887
3888         * DumpRenderTree/chromium/TestShell.cpp:
3889         (TestShell::~TestShell):
3890
3891 2013-03-07  Alan Cutter  <alancutter@chromium.org>
3892
3893         Sheriffbot whois command can't search by full name
3894         https://bugs.webkit.org/show_bug.cgi?id=111825
3895
3896         Reviewed by Eric Seidel.
3897
3898         Allowed multiple arguments to Sheriffbot's whois command.
3899         Updated test expectations.
3900
3901         * Scripts/webkitpy/tool/bot/irc_command.py:
3902         (Whois.execute):
3903         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3904         (IRCCommandTest.test_whois):
3905
3906 2013-03-07  Nils Barth  <nbarth@chromium.org>
3907
3908         Add Nils Barth and Koji Hara to committers.py
3909         https://bugs.webkit.org/show_bug.cgi?id=111806
3910
3911         Reviewed by Eric Seidel.
3912
3913         * Scripts/webkitpy/common/config/committers.py:
3914
3915 2013-03-07  Glenn Adams  <glenn@skynav.com>
3916
3917         run-pert-tests should have a --test-runner-count option
3918         https://bugs.webkit.org/show_bug.cgi?id=111726
3919
3920         Reviewed by Ryosuke Niwa.
3921
3922         Add --test-runner-count option to run-perf-tests, with default value of 4.
3923         This option allows command line configuration of the number of times to invoke
3924         the test runner (serially, not in parallel) when running a specific test in
3925         a test set.
3926
3927         * Scripts/webkitpy/performance_tests/perftest.py:
3928         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
3929         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
3930         (PerfTest.run): Rename process_run_count to test_runner_count.
3931         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
3932         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
3933         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
3934         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
3935         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3936         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
3937         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
3938         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3939         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
3940         (MainTest.test_run_with_repeat):
3941         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
3942         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3943         (MainTest.test_default_args): Add test for default option argument values.
3944         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
3945
3946 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
3947
3948         Add myself to reviewers.py
3949         https://bugs.webkit.org/show_bug.cgi?id=111757
3950
3951         Reviewed by Eric Seidel.
3952
3953         * Scripts/webkitpy/common/config/committers.py:
3954
3955 2013-03-07  Glenn Adams  <glenn@skynav.com>
3956
3957         run-perf-tests should have a --repeat option
3958         https://bugs.webkit.org/show_bug.cgi?id=100030
3959
3960         Reviewed by Ryosuke Niwa.
3961
3962         Add --repeat option to run-perf-tests, with default value of 1. When greater
3963         than 1, runs test set specified number of times. Note that multiple runs are
3964         not aggregated for statistical purposes.
3965
3966         Incidentally fixed typo: s/suceeds/succeeds/.
3967
3968         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3969         (PerfTestsRunner._parse_args): Add repeat option.
3970         (PerfTestsRunner.run): Add outer repeat loop.
3971         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
3972         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
3973         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3974         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
3975         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
3976         (MainTest.test_run_with_json_output): Fix typo.
3977         (MainTest.test_run_with_description): Fix typo.
3978         (MainTest.test_run_respects_no_results): Fix typo.
3979         (MainTest.test_run_with_slave_config_json): Fix typo.
3980         (MainTest.test_run_with_multiple_repositories): Fix typo.
3981         (MainTest.test_run_with_upload_json): Fix typo.
3982         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
3983         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
3984         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3985         (MainTest.test_parse_args): Add test for repeat option parsing.
3986
3987 2013-03-07  Julie Parent  <jparent@chromium.org>
3988
3989         showAllRuns checkbox no longer works on the stats dashboard
3990         https://bugs.webkit.org/show_bug.cgi?id=111673
3991
3992         Reviewed by Ojan Vafai.
3993
3994         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
3995         so we were trying to index into an undefined object.
3996         
3997         * TestResultServer/static-dashboards/dashboard_base.js:
3998         (invalidateQueryParameters):
3999
4000 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
4001
4002         [Chromium] Update #include for WebStorageNamespace.h
4003         https://bugs.webkit.org/show_bug.cgi?id=111748
4004
4005         Reviewed by Adam Barth.
4006
4007         In anticipation of removing
4008         WK/chromium/public/WebStorageNamespace.h (once downstream
4009         references have been updated)
4010
4011         * DumpRenderTree/chromium/WebViewHost.cpp:
4012
4013 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
4014
4015         run-perf-tests fails due to svn_revision not working on a pure git clone
4016         https://bugs.webkit.org/show_bug.cgi?id=110839
4017
4018         Reviewed by Ryosuke Niwa.
4019
4020         Previously we would call git svn find-rev to look up the commit for
4021         a given revision, and that'll hang in a pure git checkout.
4022
4023         This patch changes the way we look up svn revisions in a git
4024         repository to use git log --grep 'git-svn-id', which is much faster
4025         than grepping ourselves. It also renames timestamp_of_latest_commit()
4026         to timestamp_of_revision() in order to accurately reflect what
4027         the method is doing. Note that this patch only changes the logic
4028         inside latest_revision() and svn_revision(). I'll file a separate
4029         bug to change git_commit_from_svn_revision().
4030
4031         This patch also contains some fixes to unit tests that had bit-rotted
4032         or were otherwise fragile, so that test-webkitpy --all would pass
4033         cleanly, and a fix to outputcapture so that
4034         test-webkitpy -p would work correctly again.
4035
4036         * Scripts/webkitpy/common/checkout/scm/git.py:
4037         (Git.svn_revision):
4038         (Git.timestamp_of_revision):
4039         * Scripts/webkitpy/common/checkout/scm/scm.py:
4040         (SCM.svn_revision):
4041         (SCM.timestamp_of_revision):
4042         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
4043         (MockSCM.timestamp_of_revision):
4044         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4045         (_shared_test_commit_with_message):
4046         (test_commit_without_authorization):
4047         (test_timestamp_of_revision):
4048         * Scripts/webkitpy/common/checkout/scm/svn.py:
4049         (SVN.timestamp_of_revision):
4050         * Scripts/webkitpy/common/system/outputcapture.py:
4051           Importing unittest2 directly may not be safe if this module is
4052           imported before the autoinstaller gets a chance to set things up
4053           properly. We don't actually need unittest2 here.
4054         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4055         (PerfTestsRunner._generate_results_dict):
4056
4057 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4058
4059         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
4060         https://bugs.webkit.org/show_bug.cgi?id=111756
4061
4062         Reviewed by Kenneth Rohde Christiansen.
4063
4064         Bump libsoup to v2.40.3 to fix the regressions introduced by
4065         previous v2.40.0 bump.
4066
4067         * efl/jhbuild.modules:
4068
4069 2013-03-07  Roger Fong  <roger_fong@apple.com>
4070
4071         Re-enable Win EWS tests.
4072
4073         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4074         (WinEWS):
4075
4076 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
4077
4078         [nrwt] handle corrupt http server pid files cleanly
4079         https://bugs.webkit.org/show_bug.cgi?id=111628
4080
4081         Reviewed by Eric Seidel.
4082
4083         If the pid file from a previous http server is corrupt for some
4084         reason, NRWT will just raise errors and not clean it up or recover.
4085         This patch fixes that to at least delete the pid file and
4086         not throw; not that we may still have stale http servers left on
4087         the system, since there's no way to know which pid to kill if
4088         the file was corrupted.
4089
4090         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
4091         (HttpServerBase.start):
4092         (HttpServerBase.stop):
4093         (HttpServerBase._remove_pid_file):
4094         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
4095         (TestHttpServerBase):
4096         (TestHttpServerBase.test_corrupt_pid_file):
4097
4098 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
4099
4100         AX: Can't activate links with VoiceOver in Safari
4101         https://bugs.webkit.org/show_bug.cgi?id=111755
4102
4103         Reviewed by Tim Horton.
4104
4105         * DumpRenderTree/AccessibilityUIElement.cpp:
4106         (supportedActionsCallback):
4107         (AccessibilityUIElement::getJSClass):
4108         * DumpRenderTree/AccessibilityUIElement.h:
4109         (AccessibilityUIElement):
4110         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4111         (AccessibilityUIElement::supportedActions):
4112
4113 2013-03-07  Roger Fong  <roger_fong@apple.com>
4114
4115         Windows debug layout tests are crashing like crazy again.
4116         Disable tests on Win EWS bots temporarily.
4117
4118         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4119         (WinEWS):
4120
4121 2013-03-07  Roger Fong  <roger_fong@apple.com>
4122
4123         Make EWS bots build and test in release.
4124
4125         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4126         (WinEWS):
4127         * Scripts/webkitpy/tool/steps/runtests.py:
4128         (RunTests.run):
4129
4130 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
4131
4132         [chromium] don't track the top loading frame if no layout test is currently running
4133         https://bugs.webkit.org/show_bug.cgi?id=111716
4134
4135         Reviewed by Kentaro Hara.
4136
4137         In DRT, we synchronously stop the test and start loading the next test
4138         URL. However, in content_shell, this happens asynchronously. It's
4139         important that the top loading frame is not changed due to stray
4140         navigation events before the next test starts.
4141
4142         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4143         (WebTestRunner::TestRunner::setTopLoadingFrame):
4144
4145 2013-03-06  Julie Parent  <jparent@chromium.org>
4146
4147         Dashboard cleanup: Move all dashboard ui related code into ui.js.
4148         https://bugs.webkit.org/show_bug.cgi?id=111621
4149
4150         Reviewed by Ojan Vafai.
4151         
4152         Creates ui.js, a package for the common UI code the various
4153         dashboards use. HTML generation is now in the ui.html namespace
4154         and popup handling is in ui.popup.
4155         Also moves the event listening for popups to ui.popup.show and
4156         removes it on ui.popup.hid rather than having listener always
4157         around.
4158
4159         * TestResultServer/static-dashboards/aggregate_results.html:
4160         * TestResultServer/static-dashboards/dashboard_base.js:
4161         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4162         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4163         (showPopupForBuild):
4164         (htmlForNavBar):
4165         (generatePageForIndividualTests.if):
4166         (generatePageForIndividualTests):
4167         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
4168         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4169         * TestResultServer/static-dashboards/run-embedded-unittests.html:
4170         * TestResultServer/static-dashboards/run-unittests.html:
4171         * TestResultServer/static-dashboards/timeline_explorer.html:
4172         * TestResultServer/static-dashboards/treemap.html:
4173         * TestResultServer/static-dashboards/ui.js: Added.
4174         (.):
4175
4176 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
4177
4178         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
4179         https://bugs.webkit.org/show_bug.cgi?id=110584
4180
4181         Reviewed by Gyuyoung Kim.
4182
4183         Adds missing implementation of AccessibilityControllerEfl
4184         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
4185         so that it can make accessibilityController as a js object.
4186
4187         * DumpRenderTree/AccessibilityController.h:
4188         (AccessibilityController):
4189         * DumpRenderTree/AccessibilityUIElement.h:
4190         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
4191         (AccessibilityController::childElementById): Moved declaration to base class.
4192         Implementation can be shared among other ports.
4193         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
4194         (AccessibilityController::focusedElement):
4195         (AccessibilityController::rootElement):
4196         (AccessibilityController::accessibleElementById):
4197         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
4198         (AccessibilityUIElement::helpText):
4199         * DumpRenderTree/efl/CMakeLists.txt:
4200         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4201         (DumpRenderTreeChrome::DumpRenderTreeChrome):
4202         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4203         (DumpRenderTreeChrome::onWindowObjectCleared):
4204         (DumpRenderTreeChrome::accessibilityController):
4205         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
4206         (DumpRenderTreeChrome):
4207         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
4208
4209 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
4210
4211         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
4212         https://bugs.webkit.org/show_bug.cgi?id=42696
4213
4214         Reviewed by Andreas Kling.
4215
4216         * DumpRenderTree/TestRunner.cpp:
4217         (TestRunner::staticFunctions):
4218         * DumpRenderTree/TestRunner.h:
4219         (TestRunner):
4220         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4221         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4222         (WebTestRunner::TestRunner::TestRunner):
4223         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4224         (TestRunner):
4225         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4226         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4227         * DumpRenderTree/mac/TestRunnerMac.mm:
4228         * DumpRenderTree/qt/TestRunnerQt.cpp:
4229         * DumpRenderTree/qt/TestRunnerQt.h:
4230         (TestRunnerQt):
4231         * DumpRenderTree/win/TestRunnerWin.cpp:
4232         * DumpRenderTree/wx/TestRunnerWx.cpp:
4233
4234 2013-03-06  Roger Fong  <roger_fong@apple.com>
4235
4236         Re-enable WinEWS test and decrease iterations before clean build back to 10.
4237
4238         * EWSTools/start-queue-win.sh:
4239         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4240         (WinEWS):
4241
4242 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
4243
4244         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
4245         https://bugs.webkit.org/show_bug.cgi?id=82866
4246
4247         Reviewed by Martin Robinson.
4248
4249         * Scripts/run-gtk-tests:
4250         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
4251         it is passing now.
4252
4253 2013-03-06  Julie Parent  <jparent@chromium.org>
4254
4255         Dashboard cleanup: remove dashboard time logging.
4256         https://bugs.webkit.org/show_bug.cgi?id=111608
4257
4258         Reviewed by Dirk Pranke.
4259
4260         Remove logTime.  It was never accurate, and the dev tools
4261         have better ways to measure this if anyone cares to look
4262         into dashboard perf.
4263         
4264         * TestResultServer/static-dashboards/dashboard_base.js:
4265         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4266         (processTestRunsForBuilder):
4267         (appendHTML):
4268
4269 2013-03-06  Tony Chang  <tony@chromium.org>
4270
4271         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
4272         https://bugs.webkit.org/show_bug.cgi?id=111509
4273
4274         Reviewed by Dirk Pranke.
4275
4276         Add DumpRenderTree.pak to DumpRenderTree.app again.
4277
4278         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4279
4280 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
4281
4282         [chromium] introduce WebUserGestureIndicator
4283         https://bugs.webkit.org/show_bug.cgi?id=111531
4284
4285         Reviewed by Adam Barth.
4286