Removed an annoying message from svn-create-patch
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
2
3         Removed an annoying message from svn-create-patch
4         https://bugs.webkit.org/show_bug.cgi?id=114332
5
6         Reviewed by Alexey Proskuryakov.
7
8         I see this message basically every time I write a patch, so it must not
9         be true.
10
11         * Scripts/svn-create-patch:
12         (generateDiff):
13
14 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
15
16         [GTK] Add support for Page Visibility
17         https://bugs.webkit.org/show_bug.cgi?id=97324
18
19         Reviewed by Sam Weinig.
20
21         Implemented test runner API for page visibility layout tests.
22
23         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
24         (TestRunner::resetPageVisibility):
25         (TestRunner::setPageVisibility):
26         * Scripts/webkitperl/FeatureList.pm:
27
28 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
29
30         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
31         https://bugs.webkit.org/show_bug.cgi?id=114342
32
33         Reviewed by Gyuyoung Kim.
34
35         Commit 148033 only added an implementation for the Mac port, which made
36         other ports fail most tests since loading the injected bundle failed
37         with a missing symbol.
38
39         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
40         (WTR::AccessibilityUIElement::pathDescription):
41
42 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
43
44         [EFL] Add spell checking option to MiniBrowser
45         https://bugs.webkit.org/show_bug.cgi?id=114282
46
47         Reviewed by Ryosuke Niwa.
48
49         Spell checking is enabled by adding a flag (t/text-checking)
50         with launching MiniBrowser.
51
52         * MiniBrowser/efl/main.c:
53         (window_create):
54         (elm_main):
55
56 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
57
58         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
59         https://bugs.webkit.org/show_bug.cgi?id=113281
60
61         Reviewed by Darin Adler.
62
63         * Scripts/run-gtk-tests:
64         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
65
66 2013-04-09  Glenn Adams  <glenn@skynav.com>
67
68         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
69
70         Unreviewed.
71
72         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
73         (RunTest.test_build_check):
74
75 2013-04-09  Glenn Adams  <glenn@skynav.com>
76
77         [webkitpy] Remove chromium ports.
78         https://bugs.webkit.org/show_bug.cgi?id=114326
79
80         Reviewed by Dirk Pranke.
81
82         As a side effect, also:
83
84         - remove chromium builders from webkitpy.layout_tests.port.builders
85         - remove chromium builders from rebaseline
86         - rewrite chromium dependent tests in rebaseline_unittest
87         - remove chromium platform from garden-o-matic
88         - select apple platform as default platform in garden-o-matic
89         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
90
91         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
92         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
93         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
94         (BaselineOptimizerTest.test_move_baselines):
95         (BaselineOptimizerTest.test_efl):
96         (BaselineOptimizerTest.test_no_add_mac_future):
97         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
98         (BaselineOptimizerTest.test_common_directory_includes_root):
99         (BaselineOptimizerTest.test_complex_shadowing):
100         (BaselineOptimizerTest.test_virtual_ports_filtered):
101         * Scripts/webkitpy/layout_tests/port/builders.py:
102         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
103         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
104         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
105         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
106         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
107         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
108         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
109         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
110         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
111         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
112         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
113         * Scripts/webkitpy/layout_tests/port/factory.py:
114         (platform_options):
115         (PortFactory):
116         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
117         (FactoryTest.test_qt):
118         (FactoryTest.test_get_from_builder_name):
119         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
120         (RunTest.test_build_check):
121         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
122         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
123         * Scripts/webkitpy/tool/commands/rebaseline.py:
124         (Rebaseline._builders_to_pull_from):
125         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
126         (_BaseTestCase):
127         (_BaseTestCase.setUp):
128         (TestRebaselineTest.setUp):
129         (TestRebaselineTest.test_baseline_directory):
130         (test_rebaseline_updates_expectations_file):
131         (test_rebaseline_does_not_include_overrides):
132         (test_rebaseline_test):
133         (test_rebaseline_test_and_print_scm_changes):
134         (test_rebaseline_and_copy_test):
135         (test_rebaseline_and_copy_test_no_existing_result):
136         (test_rebaseline_and_copy_test_with_lion_result):
137         (test_rebaseline_and_copy_no_overwrite_test):
138         (TestRebaselineExpectations.test_rebaseline_expectations):
139
140 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
141
142         newcommitbot (WKR) requires a subversion checkout
143         https://bugs.webkit.org/show_bug.cgi?id=114309
144
145         Reviewed by Benjamin Poulain.
146
147         Directly talk to the subversion server instead of relying on a local checkout.
148         This allows us to run WKR off of a git clone.
149
150         * Scripts/webkitpy/tool/commands/newcommitbot.py:
151         (NewCommitBot.next_work_item):
152         (NewCommitBot.process_work_item):
153
154 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
155
156         webkitbot refers to sheriffbot in help
157         https://bugs.webkit.org/show_bug.cgi?id=114307
158
159         Reviewed by Benjamin Poulain.
160
161         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
162
163         * Scripts/webkitpy/tool/bot/irc_command.py:
164         (Help):
165         (Help.execute):
166         (RollChromiumDEPS.execute):
167         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
168         (IRCBotTest.test_help):
169         * Scripts/webkitpy/tool/bot/sheriff.py:
170         (Sheriff.name):
171
172 2013-04-06  Roger Fong  <roger_fong@apple.com>
173
174         Kill old processes between runs on WinEWS bots.
175         Temporarily disable tests to let bots catch up again.
176
177         * EWSTools/start-queue-win.sh:
178         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
179         (WinEWS):
180
181 2013-04-09  Glenn Adams  <glenn@skynav.com>
182
183         [webkitpy] Remove chromium deprecated port support.
184         https://bugs.webkit.org/show_bug.cgi?id=114228
185
186         Reviewed by Ryosuke Niwa.
187
188         * Scripts/webkitpy/common/config/ports.py:
189         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
190         (ChromiumPort): Removed.
191         (ChromiumAndroidPort): Removed.
192         (ChromiumXVFBPort): Removed.
193         * Scripts/webkitpy/common/config/ports_unittest.py:
194         (DeprecatedPortTest.test_chromium_port): Removed.
195         (DeprecatedPortTest.test_chromium_android_port): Removed.
196         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
197         * Scripts/webkitpy/tool/steps/update_unittest.py:
198         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
199         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
200
201 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
202
203         AX: The bounding paths should be made available through accessibility
204         https://bugs.webkit.org/show_bug.cgi?id=113817
205
206         Reviewed by David Kilzer.
207
208         Add a pathDescription property for testing so that it's possible
209         to verify that a path is being returned correctly.
210
211         * DumpRenderTree/AccessibilityUIElement.cpp:
212         (getPathDescriptionCallback):
213         (AccessibilityUIElement::pathDescription):
214         (AccessibilityUIElement::getJSClass):
215         * DumpRenderTree/AccessibilityUIElement.h:
216         (AccessibilityUIElement):
217         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
218         (_CGPathEnumerationIteration):
219         (AccessibilityUIElement::pathDescription):
220         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
221         (AccessibilityUIElement::pathDescription):
222         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
223         (WTR::AccessibilityUIElement::pathDescription):
224         (WTR):
225         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
226         (AccessibilityUIElement):
227         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
228         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
229         (WTR::AccessibilityUIElement::pathDescription):
230         (WTR):
231
232 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
233
234         [EFL] Declare TEST_THEME_DIR in a single place.
235         https://bugs.webkit.org/show_bug.cgi?id=114285
236
237         Reviewed by Anders Carlsson.
238
239         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
240
241         * DumpRenderTree/efl/CMakeLists.txt:
242         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
243         (DumpRenderTreeChrome::createView):
244         (DumpRenderTreeChrome::createInspectorView):
245         (DumpRenderTreeChrome::initialize):
246         (DumpRenderTreeChrome::onDownloadRequest):
247         * EWebLauncher/CMakeLists.txt:
248         * EWebLauncher/main.c:
249         (findThemePath):
250         * EWebLauncher/url_bar.c:
251         (url_bar_add):
252         * MiniBrowser/efl/CMakeLists.txt:
253         * MiniBrowser/efl/main.c:
254         (window_create):
255         * TestWebKitAPI/PlatformEfl.cmake:
256         * TestWebKitAPI/efl/PlatformWebView.cpp:
257         (TestWebKitAPI::PlatformWebView::PlatformWebView):
258         * WebKitTestRunner/PlatformEfl.cmake:
259         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
260         (WTR::PlatformWebView::PlatformWebView):
261
262 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
263
264         [GTK][AC] upversion of clutter and its dependecy
265         https://bugs.webkit.org/show_bug.cgi?id=114016
266
267         Reviewed by Gustavo Noronha Silva.
268
269         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
270
271         * gtk/jhbuild-optional.modules:
272
273 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
274
275         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
276         https://bugs.webkit.org/show_bug.cgi?id=89875
277
278         Reviewed by Maciej Stachowiak.
279
280         Add unit tests to verify if the handling of the open, openat, creat syscall
281         is being done right. We check if the Read/Write/ReadAndWrite permissions
282         are respected, if the canonical path is being resolved and if
283         the permissions are falling back to the topmost parent directory with a
284         policy set when the directory being opened has no policy.
285
286         We also test if any attempt of blocking SIGSYS is silently ignored.
287         SIGSYS cannot be blocked because in it's handler is where we hook
288         syscalls to the broker process.
289
290         Also added libseccomp to EFL's jhbuild to make the life of developers
291         willing to help easier.
292
293         * Scripts/webkitperl/FeatureList.pm:
294         * TestWebKitAPI/PlatformEfl.cmake:
295         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
296         (TestWebKitAPI):
297         (SeccompEnvironment):
298         (TestWebKitAPI::SeccompEnvironment::SetUp):
299         (TestWebKitAPI::SeccompEnvironment::TearDown):
300         (TestWebKitAPI::dummyHandler):
301         (TestWebKitAPI::TEST):
302         (TestWebKitAPI::stressTest):
303         * efl/jhbuild.modules:
304         * qmake/mkspecs/features/features.pri:
305
306 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
307
308         REGRESSION: Autocorrection doesn't work in DumpRenderTree
309         https://bugs.webkit.org/show_bug.cgi?id=113846
310
311         Reviewed by Alexey Proskuryakov.
312
313         The problem was that we were replacing NSSpellCheck's dictionary with our own
314         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
315
316         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
317         and "would" respectively in DumpRenderTree.
318
319         * DumpRenderTree/mac/DumpRenderTree.mm:
320         (resetDefaultsToConsistentValues):
321
322 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
323
324         Remove the gyp files for Tools
325         https://bugs.webkit.org/show_bug.cgi?id=114248
326
327         Reviewed by Ryosuke Niwa.
328
329         * DumpRenderTree/DumpRenderTree.gyp: Removed.
330         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
331         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
332         * DumpRenderTree/DumpRenderTree.gypi: Removed.
333         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
334         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
335         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
336         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
337
338 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
339
340         WKR (new-commit-bot) is too slow
341         https://bugs.webkit.org/show_bug.cgi?id=110087
342
343         Reviewed by Geoffrey Garen.
344
345         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
346         Just run "svn log -r <revision>" instead to cut down the delay.
347
348         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
349
350         * Scripts/webkitpy/tool/commands/newcommitbot.py:
351         (NewCommitBot):
352         (NewCommitBot.next_work_item):
353         (NewCommitBot._is_empty_log):
354         (NewCommitBot._update_checkout):
355
356 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
357
358         Build fix. Can't remove appendCustomBuildFlags.
359
360         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
361         (appendCustomBuildFlags):
362
363 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
364
365         Remove Chromium builders from build.webkit.org
366         https://bugs.webkit.org/show_bug.cgi?id=113990
367
368         Reviewed by Benjamin Poulain.
369
370         Removed.
371
372         * BuildSlaveSupport/build.webkit.org-config/config.json:
373         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
374         (InstallGtkDependencies):
375         (RunUnitTests.start):
376         (RunWebKit2Tests.start):
377         (Factory.__init__):
378         (unitTestsSupported):
379         (TestFactory.__init__):
380         (BuildAndTestFactory.__init__):
381         (BuildAndPerfTestFactory.__init__):
382         (BuildAndPerfTestWebKit2Factory.__init__):
383         (DownloadAndPerfTestFactory.__init__):
384         (loadBuilderConfig):
385         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
386
387 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
388
389         Remove HTML Notification
390         https://bugs.webkit.org/show_bug.cgi?id=114231
391
392         Reviewed by Ryosuke Niwa.
393
394         * qmake/mkspecs/features/features.pri:
395
396 2013-04-08  Glenn Adams  <glenn@skynav.com>
397
398         Remove chromium EWS support, and fix broken test.
399         https://bugs.webkit.org/show_bug.cgi?id=114221
400
401         Reviewed by Ryosuke Niwa.
402
403         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
404         (AbstractChromiumEWS): Removed.
405         (ChromiumLinuxEWS): Removed.
406         (ChromiumLinuxDebugEWS): Removed.
407         (ChromiumWindowsEWS): Removed.
408         (ChromiumAndroidEWS): Removed.
409         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
410         (EarlyWarningSystemTest): Fix misspelled class name.
411         (test_ewses): Fix entry point name to ensure test is run.
412
413 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
414
415         [WIN] Remove WebKit2 source code
416         https://bugs.webkit.org/show_bug.cgi?id=114096
417
418         Reviewed by Anders Carlsson.
419
420         Remove the windows specific parts of the MiniBrowser.
421
422         * MiniBrowser/MiniBrowser.vcproj: Removed.
423         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
424         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
425         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
426         * MiniBrowser/win/BrowserView.cpp: Removed.
427         * MiniBrowser/win/BrowserView.h: Removed.
428         * MiniBrowser/win/BrowserWindow.cpp: Removed.
429         * MiniBrowser/win/BrowserWindow.h: Removed.
430         * MiniBrowser/win/MiniBrowser.cpp: Removed.
431         * MiniBrowser/win/MiniBrowser.h: Removed.
432         * MiniBrowser/win/MiniBrowser.rc: Removed.
433         * MiniBrowser/win/main.cpp: Removed.
434         * MiniBrowser/win/resource.h: Removed.
435         * MiniBrowser/win/stdafx.cpp: Removed.
436         * MiniBrowser/win/stdafx.h: Removed.
437
438 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
439
440         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
441
442         * Scripts/webkitpy/common/config/irc.py:
443
444 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
445
446         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
447         https://bugs.webkit.org/show_bug.cgi?id=113139
448
449         Reviewed by Anders Carlsson.
450
451         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
452         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
453         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
454         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
455         (ToStringAndValueOfObject):
456         (ToStringAndValueOfObject::ToStringAndValueOfObject):
457         (ScriptableObject):
458         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
459         (ToStringAndValueOfObject::ScriptableObject::invoke):
460         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
461         (ToStringAndValueOfObject::NPP_GetValue):
462         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
463         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
464         * GNUmakefile.am:
465
466 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
467
468         [GTK] Bump gnome-themes-standard to 3.6.0
469         https://bugs.webkit.org/show_bug.cgi?id=114155
470
471         Reviewed by Martin Robinson.
472
473         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
474         dependency of gnome-themes-standard accordingly.
475
476 2013-04-08  David Levin  <levin@chromium.org>
477
478         Remove my watchlist entries.
479         https://bugs.webkit.org/show_bug.cgi?id=114180
480
481         Reviewed by Adam Barth.
482
483         * Scripts/webkitpy/common/config/committers.py:
484         * Scripts/webkitpy/common/config/watchlist:
485
486 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
487
488         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
489         https://bugs.webkit.org/show_bug.cgi?id=114161
490
491         Reviewed by Gyuyoung Kim.
492
493         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
494         as it is crashing due to Bug 111074.
495
496         * TestWebKitAPI/PlatformEfl.cmake:
497
498 2013-04-07  David Kilzer  <ddkilzer@apple.com>
499
500         Remove the rest of SVG_DOM_OBJC_BINDINGS
501         <http://webkit.org/b/114112>
502
503         Reviewed by Geoffrey Garen.
504
505         * Scripts/webkitperl/FeatureList.pm:
506         - Remove --svg-dom-objc-bindings switch.
507         * qmake/mkspecs/features/features.pri:
508         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
509
510 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
511
512         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
513         https://bugs.webkit.org/show_bug.cgi?id=114089
514
515         Reviewed by Chris Fleizach.
516
517         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
518         * DumpRenderTree/AccessibilityController.cpp:
519         * DumpRenderTree/AccessibilityUIElement.cpp:
520         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
521         (DumpRenderTreeChrome::DumpRenderTreeChrome):
522         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
523         (DumpRenderTreeChrome):
524
525 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
526
527         Build fix after r147857, remove remaining USE(JSC) guards.
528
529         Unreviewed.
530
531         * DumpRenderTree/config.h:
532         * TestWebKitAPI/config.h:
533         * WebKitTestRunner/config.h:
534
535 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
536
537         Rename sheriffbot to webkitbot
538         https://bugs.webkit.org/show_bug.cgi?id=114109
539
540         Reviewed by Benjamin Poulain.
541
542         Renamed since sheriffbot will be used in Blink.
543
544         * Scripts/webkitpy/tool/commands/sheriffbot.py:
545         (SheriffBot):
546         (SheriffBot.begin_work_queue):
547
548 2013-04-06  Oliver Hunt  <oliver@apple.com>
549
550         Unify the many and varied stack trace mechanisms, and make the result sane.
551         https://bugs.webkit.org/show_bug.cgi?id=114072
552
553         Reviewed by Filip Pizlo.
554
555         The commandline jsc executable no longer requires arguments, so
556         I've made run-jsc work without them.
557
558         * Scripts/run-jsc:
559
560 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
561
562         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
563         https://bugs.webkit.org/show_bug.cgi?id=114086
564
565         Reviewed by Tim Horton.
566
567         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
568
569 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
570
571         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
572         https://bugs.webkit.org/show_bug.cgi?id=114083
573
574         Reviewed by Ryosuke Niwa.
575
576         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
577         in TestWebKitAPI and WebKitTestRunner.
578
579         * TestWebKitAPI/config.h:
580         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
581         (TestWebKitAPI::InjectedBundleController::platformInitialize):
582         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
583         (WTR::InjectedBundle::platformInitialize):
584
585 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
586
587         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
588         https://bugs.webkit.org/show_bug.cgi?id=114094
589
590         Reviewed by Anders Carlsson.
591
592         * Scripts/run-jsc:
593
594 2013-04-05  Ojan Vafai  <ojan@chromium.org>
595
596         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
597         https://bugs.webkit.org/show_bug.cgi?id=114080
598
599         Reviewed by Ryosuke Niwa.
600
601         This way, the WebKit and Blink dashboard code can change as appropriate without
602         needing to consider the other project's needs. This still doesn't update the
603         buildbots to upload to the new location, or the dashboard code to pull the
604         results.json files from the new location, but it at least allows for changing the
605         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
606
607         * TestResultServer/app.yaml:
608
609 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
610
611         Re-enable testing on the commit queue
612         https://bugs.webkit.org/show_bug.cgi?id=114078
613
614         Reviewed by Darin Adler.
615
616         Re-enabled the feature and the associated tests.
617
618         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
619         (CommitQueueTask.run):
620         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
621         (CommitQueueTaskTest._run_through_task):
622         * Scripts/webkitpy/tool/commands/queues_unittest.py:
623         (CommitQueueTest._mock_test_result):
624
625 2013-04-05  Oliver Hunt  <oliver@apple.com>
626
627         Unify the many and varied stack trace mechanisms, and make the result sane.
628         https://bugs.webkit.org/show_bug.cgi?id=114072
629
630         Reviewed by Filip Pizlo.
631
632         The commandline jsc executable no longer requires arguments, so
633         I've made run-jsc work without them.
634
635         * Scripts/run-jsc:
636
637 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
638
639         AX: Make SVG Group containers accessible elements
640         https://bugs.webkit.org/show_bug.cgi?id=113939
641
642         Reviewed by Simon Fraser.
643
644         Implement axController.elementAtPoint for iOS.
645         Implement a correct version of clickPoint for iOS.
646
647         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
648         (AccessibilityController::elementAtPoint):
649         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
650         (AccessibilityUIElement::clickPointX):
651         (AccessibilityUIElement::clickPointY):
652
653 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
654
655         Unreviewed, rolling out r147773 and r147774.
656         http://trac.webkit.org/changeset/147773
657         http://trac.webkit.org/changeset/147774
658         https://bugs.webkit.org/show_bug.cgi?id=114056
659
660         Causing some exceptions on AppEngine I don't understand
661         (Requested by rniwa on #webkit).
662
663         * QueueStatusServer/config/queues.py:
664         * QueueStatusServer/model/queues.py:
665         (Queue.short_name):
666         (Queue.display_name):
667         * QueueStatusServer/model/queues_unittest.py:
668         (QueueTest.test_short_name):
669         (QueueTest.test_display_name):
670         (QueueTest.test_name_with_underscores):
671
672 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
673
674         Fixed run-bindings-tests by removing V8
675         https://bugs.webkit.org/show_bug.cgi?id=114053
676
677         Reviewed by Benjamin Poulain.
678
679         * Scripts/run-bindings-tests:
680         (main):
681
682 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
683
684         Build fix.
685
686         * QueueStatusServer/model/queues.py:
687         (Queue.short_name):
688         (Queue.display_name):
689
690 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
691
692         Remove Chromium EWS bots from the queue status server
693         https://bugs.webkit.org/show_bug.cgi?id=113988
694
695         Reviewed by Benjamin Poulain.
696
697         Removed Chromium EWS bots.
698
699         * QueueStatusServer/config/queues.py:
700         * QueueStatusServer/model/queues.py:
701         (Queue.short_name):
702         (Queue.display_name):
703         * QueueStatusServer/model/queues_unittest.py:
704         (QueueTest.test_short_name):
705         (QueueTest.test_display_name):
706         (QueueTest.test_name_with_underscores):
707
708 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
709
710         [EFL] Enable indexed database
711         https://bugs.webkit.org/show_bug.cgi?id=107248
712
713         Reviewed by Alexis Menard.
714
715         * Scripts/webkitperl/FeatureList.pm:
716
717 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
718
719         Remove vestiges of Chromium bits from watchlists.
720         https://bugs.webkit.org/show_bug.cgi?id=114047
721
722         Reviewed by Ryosuke Niwa.
723
724         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
725
726 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
727
728         Add James Craig to the contributors list.
729
730         * Scripts/webkitpy/common/config/committers.py:
731
732 2013-04-04  Kent Tamura  <tkent@chromium.org>
733
734         Remove ChromiumPublicApi pattern, and cc/message rules for it.
735
736         * Scripts/webkitpy/common/config/watchlist:
737
738 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
739
740         Temporarily disable the Python unittests broken by the commit queue not running layout tests
741         https://bugs.webkit.org/show_bug.cgi?id=113997
742
743         Reviewed by Ryosuke Niwa.
744
745         Disable the tests until Ryosuke gets the time and hardware to have
746         a testing commit-queue.
747
748         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
749         (CommitQueueTaskTest):
750         * Scripts/webkitpy/tool/commands/queues_unittest.py:
751         (CommitQueueTest):
752
753 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
754
755         Remove Chromium builders from build.webkit.org
756         https://bugs.webkit.org/show_bug.cgi?id=113990
757
758         Reviewed by Benjamin Poulain.
759
760         Land the part to disable triggering of Chromium builders first so that we may start
761         deleting more Chromium code that breaks the update step.
762
763         * BuildSlaveSupport/build.webkit.org-config/config.json:
764
765 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
766
767         Remove Chromium's DumpRenderTree
768         https://bugs.webkit.org/show_bug.cgi?id=113989
769
770         Reviewed by Kent Tamura.
771
772         On second thought, let's not go to Camelot. It is a silly place.
773
774         * DumpRenderTree/mac/DumpRenderTree.mm:
775         (resetDefaultsToConsistentValues):
776
777 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
778
779         Nixed the defunct chromium folder from DumpRenderTree
780         https://bugs.webkit.org/show_bug.cgi?id=113993
781
782         Reviewed by Ryosuke Niwa.
783
784         * DumpRenderTree/chromium: Removed.
785         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
786         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
787         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
788         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
789         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
790         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
791         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
792         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
793         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
794         * DumpRenderTree/chromium/MockPlatform.h: Removed.
795         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
796         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
797         * DumpRenderTree/chromium/Task.cpp: Removed.
798         * DumpRenderTree/chromium/Task.h: Removed.
799         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
800         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
801         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
802         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
803         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
804         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
805         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
806         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
807         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
808         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
809         * DumpRenderTree/chromium/TestRunner: Removed.
810         * DumpRenderTree/chromium/TestRunner/public: Removed.
811         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
812         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
813         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
814         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
815         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
816         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
817         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
818         * DumpRenderTree/chromium/TestRunner/src: Removed.
819         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
820         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
821         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
822         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
823         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
824         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
825         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
826         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
827         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
828         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
829         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
830         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
831         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
832         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
833         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
834         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
835         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
836         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
837         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
838         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
839         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
840         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
841         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
842         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
843         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
844         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
845         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
846         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
847         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
848         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
849         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
850         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
851         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
852         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
853         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
854         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
855         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
856         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
857         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
858         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
859         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
860         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
861         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
862         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
863         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
864         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
865         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
866         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
867         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
868         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
869         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
870         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
871         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
872         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
873         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
874         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
875         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
876         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
877         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
878         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
879         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
880         * DumpRenderTree/chromium/TestShell.cpp: Removed.
881         * DumpRenderTree/chromium/TestShell.h: Removed.
882         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
883         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
884         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
885         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
886         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
887         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
888         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
889         * DumpRenderTree/chromium/WebViewHost.h: Removed.
890         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
891         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
892         * DumpRenderTree/chromium/config.h: Removed.
893         * DumpRenderTree/chromium/fonts.conf: Removed.
894
895 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
896
897         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
898
899         Rubber stamped by Benjamin Poulain.
900
901         * RebaselineQueueServer: Removed.
902         * RebaselineQueueServer/app.yaml: Removed.
903         * RebaselineQueueServer/handlers: Removed.
904         * RebaselineQueueServer/handlers/__init__.py: Removed.
905         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
906         * RebaselineQueueServer/handlers/pages.py: Removed.
907         * RebaselineQueueServer/index.yaml: Removed.
908         * RebaselineQueueServer/main.py: Removed.
909         * RebaselineQueueServer/model: Removed.
910         * RebaselineQueueServer/model/__init__.py: Removed.
911         * RebaselineQueueServer/model/queueentry.py: Removed.
912         * RebaselineQueueServer/static: Removed.
913         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
914         * RebaselineQueueServer/static/styles.css: Removed.
915         * RebaselineQueueServer/templates: Removed.
916         * RebaselineQueueServer/templates/builder-picker.html: Removed.
917         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
918         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
919         * RebaselineQueueServer/templates/home.html: Removed.
920
921 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
922
923         Fix setup-commit-queue and temporarily disable testing on commit-queue
924         https://bugs.webkit.org/show_bug.cgi?id=113979
925
926         Reviewed by Benjamin Poulain.
927
928         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
929         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
930
931         * EWSTools/setup-commit-queue.sh:
932         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
933         (CommitQueueTask.run):
934
935 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
936
937         temporarily make flakiness dashboard work again webkit.org bots
938         https://bugs.webkit.org/show_bug.cgi?id=113972
939
940         Reviewed by Ojan Vafai.
941
942         This patch disables the chromium.org layout test bots TestExpectations
943         parsing temporarily until we can work out the right way to split into
944         two instances for webkit.org and chromium.org and figure out which
945         code to delete where :).
946
947         * TestResultServer/static-dashboards/flakiness_dashboard.js:
948
949 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
950
951         Fix webkitpy tests after r147678.
952
953         * Scripts/webkitpy/tool/commands/queues_unittest.py:
954         (CommitQueueTest.test_commit_queue):
955         (test_manual_reject_during_processing):
956
957 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
958
959         The commit queue should use Mac MountainLion port
960         https://bugs.webkit.org/show_bug.cgi?id=113971
961
962         Reviewed by Lucas Forschler.
963
964         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
965         * Scripts/webkitpy/tool/commands/queues.py:
966         (CommitQueue):
967
968 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
969
970         turn off running tests on chromium linux EWS bots
971         https://bugs.webkit.org/show_bug.cgi?id=113959
972
973         Reviewed by Geoffrey Garen.
974
975         Now that the Chromium port is no longer being maintained
976         there's little point in running the tests. Soon we should
977         just shut this bot off altogether.
978
979         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
980         (ChromiumLinuxEWS):
981
982 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
983
984         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
985
986         * Scripts/webkitpy/common/config/watchlist:
987
988 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
989
990         Indentation fix to get webkit-patch working again after r147625
991
992         Unreviewed.
993
994         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
995         (MacEWS):
996         (MacWK2EWS):
997
998 2013-04-04  Lucas Forschler  <lforschler@apple.com>
999
1000         Turn tests back on for Mac WK1/WK2 EWS.
1001         
1002         Unreviewed.
1003         
1004         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1005         (MacEWS):
1006         (MacWK2EWS):
1007
1008 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1009
1010         [GTK][WK2] MiniBrowser custom URI scheme support
1011         https://bugs.webkit.org/show_bug.cgi?id=112419
1012
1013         Reviewed by Carlos Garcia Campos.
1014
1015         Add support for about URIs in MiniBrowser. An example about page is show
1016         with URI "about:minibrowser", the rest of the cases it will show a
1017         proper message explaining that the about page didn't exist.
1018
1019         Internally it uses "minibrowser-about" prefix instead of "about", but
1020         from the user point of view it works with "about" prefix.
1021
1022         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1023         (getInternalURI): Method to convert URIs from "about" prefix to
1024         "minibrowser-about".
1025         (getExternalURI): Opposite method.
1026         (webViewURIChanged): Use "about" prefix to show the URI to users.
1027         (webViewEnterFullScreen): Ditto.
1028         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1029         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1030         (aboutURISchemeRequestCallback): Callback to manage about calls.
1031         (main): Register the URI scheme to manage about URIs.
1032
1033 2013-04-03  Roger Fong  <roger_fong@apple.com>
1034
1035         Re-enable WinEWS tests.
1036
1037         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1038         (WinEWS):
1039
1040 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1041
1042         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1043         https://bugs.webkit.org/show_bug.cgi?id=113883
1044
1045         Reviewed by Martin Robinson.
1046
1047         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1048         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1049         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1050
1051 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1052
1053         [GTK] Include Pango in jhbuild-optional.modules
1054         https://bugs.webkit.org/show_bug.cgi?id=113878
1055
1056         Reviewed by Martin Robinson.
1057
1058         Since r147547 Pango 1.32.0 is required. Including the module in the
1059         JHBuild optional moduleset.
1060
1061         * gtk/jhbuild-optional.modules: Add Pango module.
1062
1063 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1064
1065         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1066         https://bugs.webkit.org/show_bug.cgi?id=113864
1067
1068         Moving setDefersLoading from TestRunnerQt to TestRunner
1069         requires access to the non-Qt TestRunner.
1070         As long as we instantiate both TestRunner and TestRunnerQt,
1071         we need a separate getter for the non-Qt TestRunner instance.
1072
1073         Reviewed by Simon Hausmann.
1074
1075         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1076         (WebPage::resetSettings):
1077         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1078         (DumpRenderTree::jscTestRunner):
1079         * DumpRenderTree/qt/TestRunnerQt.cpp:
1080         (TestRunner::setDefersLoading):
1081             Moving setDefersLoading from TestRunnerQt
1082             to TestRunner.
1083         * DumpRenderTree/qt/TestRunnerQt.h:
1084         (TestRunnerQt):
1085
1086 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1087
1088         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1089         https://bugs.webkit.org/show_bug.cgi?id=104779
1090
1091         Reviewed by Carlos Garcia Campos.
1092
1093         * Scripts/run-gtk-tests:
1094         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1095         passing in current trunk.
1096
1097 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1098
1099         Fix HAVE(QTTESTSUPPORT) logic
1100
1101         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1102         resulting in HAVE(QTTESTSUPPORT) never being true.
1103         Move that logic down in sanitizeFeatures.
1104
1105         Rubber-stamped by Tor Arne Vestbø.
1106
1107         * qmake/mkspecs/features/features.prf:
1108
1109 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1110
1111         [GTK] Bump required versions of some dependencies
1112         https://bugs.webkit.org/show_bug.cgi?id=113282
1113
1114         Reviewed by Martin Robinson.
1115
1116         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1117
1118 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1119
1120         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1121         https://bugs.webkit.org/show_bug.cgi?id=113809
1122
1123         Reviewed by Philippe Normand.
1124
1125         Newer Linux kernels have removed some deprecated macros from v4l2
1126         headers, causing gst-plugins-good's build to break. We don't need it
1127         right now, so just disable it.
1128
1129         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1130
1131 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1132
1133         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1134         https://bugs.webkit.org/show_bug.cgi?id=113535
1135
1136         Reviewed by Simon Hausmann.
1137
1138         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1139
1140         * qmake/mkspecs/features/features.prf:
1141
1142 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1143
1144         [Qt] Move logic of simple forwarding functions to TestRunner.
1145         https://bugs.webkit.org/show_bug.cgi?id=113863
1146
1147         Reviewed by Simon Hausmann.
1148
1149         * DumpRenderTree/qt/TestRunnerQt.cpp:
1150         (TestRunner::setTextDirection):
1151         (TestRunner::goBack):
1152         (TestRunner::evaluateScriptInIsolatedWorld):
1153         (TestRunner::addUserStyleSheet):
1154         * DumpRenderTree/qt/TestRunnerQt.h:
1155         (TestRunnerQt):
1156
1157 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1158
1159         [Qt] Disable media support using QuickTime if deployment target != SDK
1160
1161         We link to a single libWebKitSystemInterface static lib, so unless the
1162         deployment target matches the SDK let's not pretend like we'll be able
1163         to run on anything lower than the SDK version.
1164
1165         Reviewed by Simon Hausmann.
1166
1167         * qmake/mkspecs/features/features.prf:
1168
1169 2013-04-02  James Craig  <james@cookiecrook.com>
1170
1171         AXRoleDescripton for DL is "list"; should be "description list"
1172         https://bugs.webkit.org/show_bug.cgi?id=111665
1173
1174         Reviewed by Chris Fleizach.
1175
1176         Defining the role and description strings.
1177
1178         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1179
1180 2013-04-02  Roger Fong  <roger_fong@apple.com>
1181
1182         Unreviewed. Disable running tests on Win EWS queue.
1183
1184         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1185         (WinEWS):
1186
1187 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1188
1189         Disable running tests on the MAC WK2 EWS queue.
1190         
1191         Unreviewed.
1192         
1193         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1194         (MacWK2EWS):
1195
1196 2013-04-02  Julie Parent  <jparent@chromium.org>
1197
1198         Dashboard refactor: Move dashboard specific history related features to History.
1199         https://bugs.webkit.org/show_bug.cgi?id=113717
1200
1201         Reviewed by Ojan Vafai.
1202         
1203         Each dashboard now creates its own History object, with a custom
1204         configuration. This changes from just overriding global functions
1205         to passing in callbacks for generatePage, handleValidHashParameter,
1206         and handleQueryParameterChange. Same with passing in defaultStateValues
1207         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1208         variables.
1209         
1210         All functions related to these features are now (mostly) private
1211         function on History. 
1212         
1213         Loader no longer needs a loadingComplete callback, since it can just
1214         initialize the history object itself.
1215
1216         * TestResultServer/static-dashboards/aggregate_results.js:
1217         (handleValidHashParameter):
1218         * TestResultServer/static-dashboards/dashboard_base.js:
1219         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1220         (generatePage):
1221         (.switch.return):
1222         (handleQueryParameterChange):
1223         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1224         (resetGlobals):
1225         * TestResultServer/static-dashboards/history.js:
1226         (.):
1227         * TestResultServer/static-dashboards/loader.js:
1228         (.):
1229         * TestResultServer/static-dashboards/loader_unittests.js:
1230         * TestResultServer/static-dashboards/timeline_explorer.js:
1231         (generatePage):
1232         (initCurrentBuilderTestResults):
1233         * TestResultServer/static-dashboards/treemap.js:
1234         (generatePage):
1235         (.switch.return):
1236         (handleQueryParameterChange):
1237
1238 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1239
1240         Unreviewed, rolling out r147401.
1241         http://trac.webkit.org/changeset/147401
1242         https://bugs.webkit.org/show_bug.cgi?id=113767
1243
1244         The patch makes it extremely hard to set up the dependencies
1245         properly on the GTK builders (Requested by zdobersek on
1246         #webkit).
1247
1248         * gtk/jhbuild.modules:
1249
1250 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1251
1252         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1253         https://bugs.webkit.org/show_bug.cgi?id=113382
1254
1255         Reviewed by Gyuyoung Kim.
1256
1257         Do not show the empty tooltip box if the text is null.
1258
1259         * MiniBrowser/efl/main.c:
1260         (popup_menu_populate):
1261
1262 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1263
1264         [GTK] Bump required versions of some dependencies
1265         https://bugs.webkit.org/show_bug.cgi?id=113282
1266
1267         Reviewed by Martin Robinson.
1268
1269         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1270
1271 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1272
1273         Unreviewed, rolling out r147319.
1274         http://trac.webkit.org/changeset/147319
1275         https://bugs.webkit.org/show_bug.cgi?id=113707
1276
1277         The unit test is still failing on the buildbot (Requested by
1278         zdobersek on #webkit).
1279
1280         * Scripts/run-gtk-tests:
1281         (TestRunner):
1282
1283 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1284
1285         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1286         https://bugs.webkit.org/show_bug.cgi?id=104779
1287
1288         Reviewed by Carlos Garcia Campos.
1289
1290         * Scripts/run-gtk-tests:
1291         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1292         passing in current trunk.
1293
1294 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1295
1296         Unreviewed, rolling out r147289.
1297         http://trac.webkit.org/changeset/147289
1298         https://bugs.webkit.org/show_bug.cgi?id=113678
1299
1300         broke Win7 (dbg) build (Requested by shinyak|gardener on
1301         #webkit).
1302
1303         * DumpRenderTree/DumpRenderTree.gypi:
1304         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1305         (WebTestRunner):
1306         (WebUserMediaClientMock):
1307         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1308         (WebTestRunner::WebUserMediaClientMock::taskList):
1309         * Scripts/webkitpy/style/checkers/cpp.py:
1310         (check_function_definition):
1311
1312 2013-03-31  Adam Barth  <abarth@webkit.org>
1313
1314         configure-svn-config.sh fails
1315         https://codereview.chromium.org/13392007/
1316
1317         Reviewed by Eric Seidel.
1318
1319         This script was trying to use "svn checkout" to dowload a file from
1320         svn.webkit.org, but "svn checkout" only works with directories.
1321         Instead, we should use "svn export".
1322
1323         * EWSTools/configure-svn-config.sh:
1324
1325 2013-03-31  Wei Jia  <wjia@chromium.org>
1326
1327         Allow WebUserMediaClientMock to be used by client
1328         https://bugs.webkit.org/show_bug.cgi?id=113633
1329
1330         Reviewed by Adam Barth.
1331
1332         Export WebUserMediaClientMock.
1333         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1334
1335         * DumpRenderTree/DumpRenderTree.gypi:
1336         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1337         (WebUserMediaClientMock):
1338         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1339         * Scripts/webkitpy/style/checkers/cpp.py:
1340         (check_function_definition):
1341
1342 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1343
1344         Expose FeatureObserver data to WebKit clients
1345         https://bugs.webkit.org/show_bug.cgi?id=113613
1346
1347         Reviewed by Sam Weinig.
1348
1349         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1350         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1351
1352 2013-03-29  Greg Hughes  <ghughes@apple.com>
1353
1354         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1355         https://bugs.webkit.org/show_bug.cgi?id=112276
1356
1357         Reviewed by Chris Fleizach.
1358
1359         Added support to test accessibility search predicates with multiple keys.  
1360
1361         * DumpRenderTree/AccessibilityUIElement.cpp:
1362         (uiElementForSearchPredicateCallback):
1363         * DumpRenderTree/AccessibilityUIElement.h:
1364         (AccessibilityUIElement):
1365         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1366         (AccessibilityUIElement::uiElementForSearchPredicate):
1367         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1368         (AccessibilityUIElement::uiElementForSearchPredicate):
1369         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1370         (AccessibilityUIElement::uiElementForSearchPredicate):
1371         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1372         (AccessibilityUIElement::uiElementForSearchPredicate):
1373         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1374         (AccessibilityUIElement::uiElementForSearchPredicate):
1375         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1376         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1377         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1378         (AccessibilityUIElement):
1379         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1380         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1381         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1382         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1383         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1384
1385 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1386
1387         Fix a typo in r147147 to fix Mac EWS.
1388
1389         * Scripts/webkitpy/tool/commands/queues.py:
1390         (PatchProcessingQueue._new_port_name_from_old):
1391
1392 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1393
1394         [EFL] Build break with latest EFL libraries after r146265
1395         https://bugs.webkit.org/show_bug.cgi?id=113558
1396
1397         Unreviewed build fix.
1398
1399         * TestWebKitAPI/PlatformWebView.h:
1400         * WebKitTestRunner/PlatformWebView.h:
1401
1402 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1403
1404         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1405
1406         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1407         in libgcrypt build.
1408
1409 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1410
1411         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1412
1413         Unreviewed.
1414
1415         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1416         (MacEWS):
1417
1418 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1419
1420         Use the right OS name on Mac EWS instead of mac-future.
1421
1422         Rubber-stamped by Dirk Pranke.
1423
1424         * Scripts/webkitpy/tool/commands/queues.py:
1425         (PatchProcessingQueue._new_port_name_from_old):
1426         (PatchProcessingQueue.begin_work_queue):
1427         (PatchProcessingQueue._upload_results_archive_for_patch):
1428
1429 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1430
1431         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1432         https://bugs.webkit.org/show_bug.cgi?id=112546
1433
1434         Reviewed by Martin Robinson.
1435
1436         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1437         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1438
1439 2013-03-28  Ming Xie  <mxie@blackberry.com>
1440
1441         [BlackBerry] Committer Email Updates
1442         https://bugs.webkit.org/show_bug.cgi?id=113435
1443
1444         Reviewed by Rob Buis.
1445
1446         Add the @blackberry.com email address for all our BlackBerry
1447         WebKit committers. This is the first step for our email address
1448         migration.
1449
1450         * Scripts/webkitpy/common/config/committers.py:
1451
1452 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1453
1454         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1455         https://bugs.webkit.org/show_bug.cgi?id=113508
1456
1457         Reviewed by Martin Robinson.
1458
1459         Prevent the GStreamer plugin scanner to load system-wide
1460         plugins. Only the ones built in JHBuild should be loaded and used
1461         at runtime.
1462
1463         * efl/jhbuildrc:
1464         * gtk/jhbuildrc:
1465
1466 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1467
1468         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1469         https://bugs.webkit.org/show_bug.cgi?id=113386
1470
1471         Reviewed by Carlos Garcia Campos.
1472
1473         * Scripts/webkitdirs.pm:
1474         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1475         version to 3.0. Reflect this change so the builtDylibPathForName
1476         function doesn't fail to report the library as found.
1477
1478 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1479
1480         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1481         https://bugs.webkit.org/show_bug.cgi?id=113484
1482
1483         Unreviewed build fix.
1484
1485         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1486
1487         * TestWebKitAPI/CMakeLists.txt:
1488         * WebKitTestRunner/CMakeLists.txt:
1489
1490 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1491
1492         Revision for the internal jhbuild is too old
1493         https://bugs.webkit.org/show_bug.cgi?id=113324
1494
1495         Reviewed by Martin Robinson.
1496
1497         Update the minimum required version to a point where jhbuild won't
1498         fail installing packages when trying to remove a symlink to a directory.
1499
1500         * jhbuild/jhbuild-wrapper: Updated revision.
1501
1502 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1503
1504         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1505         https://bugs.webkit.org/show_bug.cgi?id=113203
1506
1507         Reviewed by Philippe Normand.
1508
1509         We build our libsoup without GNOME support. gst-plugins-good does separate
1510         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1511         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1512         build failures as the headers of those diverge. We do not use souphttpsrc, so
1513         disable it when building gst-plugins-good.
1514
1515         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1516
1517 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1518
1519         Build fix after r146852. Please another reference to the Lion leaks builder.
1520
1521         * BuildSlaveSupport/build.webkit.org-config/config.json:
1522
1523 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1524
1525         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1526         https://bugs.webkit.org/show_bug.cgi?id=113421
1527
1528         Reviewed by Dirk Pranke.
1529
1530         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1531         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1532         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1533         in the GTK-specific TestExpectations files.
1534
1535         To avoid this only enable the warnings only when not using WKTR.
1536
1537         * Scripts/webkitpy/layout_tests/port/gtk.py:
1538         (GtkPort.warn_if_bug_missing_in_test_expectations):
1539
1540 2013-03-27  Antti Koivisto  <antti@apple.com>
1541
1542         Fix Zalan's email.
1543
1544         * Scripts/webkitpy/common/config/committers.py:
1545
1546 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1547
1548         master.cfg cleanup
1549         https://bugs.webkit.org/show_bug.cgi?id=113195
1550
1551         Reviewed by Ryosuke Niwa.
1552
1553         * BuildSlaveSupport/build.webkit.org-config/config.json:
1554         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1555
1556 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1557
1558         master.cfg fine-tuning for Qt Mountain Lion Release bot
1559         https://bugs.webkit.org/show_bug.cgi?id=113191
1560
1561         Reviewed by Ryosuke Niwa.
1562
1563         * BuildSlaveSupport/build.webkit.org-config/config.json:
1564           - Rename the slave due to its location change.
1565           - Update the platform of the slave.
1566         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1567         (RunQtAPITests): Enable running WK2 API tests on Qt.
1568         (RunQtAPITests.start):
1569         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1570         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1571
1572 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1573
1574         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1575         https://bugs.webkit.org/show_bug.cgi?id=113403
1576
1577         Reviewed by Kenneth Rohde Christiansen.
1578
1579         As of Evas 1.7.5, when Wayland is detected on the system, support for
1580         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1581         The code, however, seems to depend on a few other flags which must be
1582         explicitly enabled.
1583
1584         If those additional GL-related options are passed, we end up
1585         having issues on the WebKit side, so disable Wayland support for
1586         now.
1587
1588         * efl/jhbuild.modules:
1589
1590 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1591
1592         Unreviewed, rolling out r146864.
1593         http://trac.webkit.org/changeset/146864
1594         https://bugs.webkit.org/show_bug.cgi?id=113391
1595
1596         causes crashes on Wk2 EFL release bot (Requested by drott on
1597         #webkit).
1598
1599         * Scripts/webkitperl/FeatureList.pm:
1600
1601 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1602
1603         [jhbuild] Correctly specify an alternate number of make jobs.
1604         https://bugs.webkit.org/show_bug.cgi?id=113396
1605
1606         Reviewed by Philippe Normand.
1607
1608         So far, we were using the `MAKEFLAGS' environment variable to pass the
1609         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1610         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1611
1612         We now behave more closely to the rest of the WebKit tools by first
1613         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1614         not set, just letting jhbuild itself figure out how many jobs to use.
1615
1616         * efl/jhbuildrc:
1617         * gtk/jhbuildrc:
1618
1619 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1620
1621         [Qt] Remove Qt specific WorkQueueItem definitions.
1622         https://bugs.webkit.org/show_bug.cgi?id=112891
1623
1624         This patch is preparation work for removing
1625         WorkQueue related code from TestRunnerQt and
1626         replacing it with generic TestRunner code.
1627
1628         Reviewed by Benjamin Poulain.
1629
1630         * DumpRenderTree/qt/TestRunnerQt.cpp:
1631         (TestRunnerQt::queueBackNavigation):
1632         (TestRunnerQt::queueForwardNavigation):
1633         (TestRunnerQt::queueLoadHTMLString):
1634         (TestRunnerQt::queueReload):
1635         (TestRunnerQt::queueLoadingScript):
1636         (TestRunnerQt::queueNonLoadingScript):
1637         (TestRunner::queueLoad):
1638         * DumpRenderTree/qt/TestRunnerQt.h:
1639         (TestRunnerQt):
1640         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1641         (LoadItem::invoke):
1642         (LoadHTMLStringItem::invoke):
1643         (LoadAlternateHTMLStringItem::invoke):
1644         (ReloadItem::invoke):
1645         (ScriptItem::invoke):
1646         (BackForwardItem::invoke):
1647         * DumpRenderTree/qt/WorkQueueItemQt.h:
1648         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1649         (LoadAlternateHTMLStringItem):
1650
1651 2013-03-26  Julie Parent  <jparent@chromium.org>
1652
1653         Flakiness dashboard: simplify logic around which tests to show.
1654         https://bugs.webkit.org/show_bug.cgi?id=113250
1655
1656         Reviewed by Ojan Vafai.
1657         
1658         The different filters for showing results are only used for layout
1659         tests, otherwise, we show everything.
1660         
1661         Change the defaults to false (what layout tests used), and only
1662         look at the values when viewing layout tests.
1663
1664         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1665         (htmlForTestsWithExpectationsButNoFailures):
1666         (shouldHideTest):
1667
1668 2013-03-26  Isaac Levy  <ilevy@google.com>
1669
1670         Update bots on test-results.appspot
1671         https://bugs.webkit.org/show_bug.cgi?id=113333
1672
1673         Reviewed by Ojan Vafai.
1674
1675         * TestResultServer/static-dashboards/builders.jsonp:
1676
1677 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1678
1679         Unreviewed GTK gardening.
1680
1681         * Scripts/run-gtk-tests:
1682         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1683
1684 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1685
1686         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1687         https://bugs.webkit.org/show_bug.cgi?id=113287
1688
1689         Reviewed by Jocelyn Turcotte.
1690
1691         * Scripts/run-qtwebkit-tests:
1692         (Options.__init__):
1693
1694 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1695
1696         [EFL] Enable IndexedDB by default
1697         https://bugs.webkit.org/show_bug.cgi?id=107248
1698
1699         Reviewed by Laszlo Gombos.
1700
1701         * Scripts/webkitperl/FeatureList.pm:
1702         Enable IndexedDB by default on EFL.
1703
1704 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1705
1706         Sheriffbot should explain rollout failures in a human readable form.
1707         https://bugs.webkit.org/show_bug.cgi?id=107092
1708
1709         Reviewed by Ryosuke Niwa.
1710
1711         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1712
1713         * Scripts/webkitpy/tool/bot/irc_command.py:
1714         (Rollout._check_diff_failure):
1715         (Rollout.execute):
1716         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1717         (IRCCommandTest.test_rollout):
1718
1719 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1720
1721         Unreviewed GTK gardening.
1722
1723         * Scripts/run-gtk-tests:
1724         (TestRunner): Skipping a failing unit test after r146518.
1725
1726 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1727
1728         Remove Lion leaks builder
1729         https://bugs.webkit.org/show_bug.cgi?id=113252
1730
1731         Reviewed by Andreas Kling.
1732
1733         Removed.
1734
1735         * BuildSlaveSupport/build.webkit.org-config/config.json:
1736
1737 2013-03-25  Kent Tamura  <tkent@chromium.org>
1738
1739         Rename ENABLE_INPUT_TYPE_DATETIME
1740         https://bugs.webkit.org/show_bug.cgi?id=113254
1741
1742         Reviewed by Kentaro Hara.
1743
1744         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1745         Actually I'd like to remove the code, but we shouldn't remove it yet
1746         because we shipped products with it on some platforms.
1747
1748         * Scripts/webkitperl/FeatureList.pm:
1749         * qmake/mkspecs/features/features.pri:
1750
1751 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1752
1753         Remove one more line that was intended to be removed in r146657.
1754
1755         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1756         (summarize_results):
1757
1758 2013-03-25  Roger Fong  <roger_fong@apple.com>
1759
1760         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1761         Re-enable WinEWS tests.
1762
1763         * Scripts/webkitpy/common/config/ports.py:
1764         (WinPort.run_bindings_tests_command):
1765         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1766         (WinEWS):
1767
1768 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1769
1770         Unreviewed, rolling out r146793.
1771         http://trac.webkit.org/changeset/146793
1772         https://bugs.webkit.org/show_bug.cgi?id=113248
1773
1774         Fix did not work (Requested by rfong on #webkit).
1775
1776         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1777         (WinEWS):
1778
1779 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1780
1781         REGRESSION(r146657): Test failures reported incorrectly
1782         https://bugs.webkit.org/show_bug.cgi?id=113223
1783
1784         Reviewed by Dirk Pranke.
1785
1786         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1787
1788         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1789         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1790
1791         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1792         (Manager.run):
1793
1794         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1795         (RunDetails.__init__):
1796         (summarize_results): Remove the line I intended to remove in r146657.
1797
1798         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1799         (logging_run): Return details instead of the exit code.
1800         (run_and_capture): Ditto.
1801
1802         (RunTest.test_full_results_html):
1803         (RunTest.test_hung_thread):
1804         (RunTest.test_no_tests_found):
1805         (RunTest.test_no_tests_found_2):
1806         (RunTest.test_repeat_each_iterations_num_tests):
1807         (RunTest.test_run_singly_actually_runs_tests):
1808         (RunTest.test_test_list):
1809         (RunTest.test_missing_and_unexpected_results):
1810         (RunTest.test_pixel_test_directories):
1811         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1812         (RunTest.test_crash_with_stderr):
1813         (RunTest.test_no_image_failure_with_image_diff):
1814         (RunTest.test_crash_log):
1815         (RunTest.test_exit_after_n_failures_upload):
1816         (RunTest.test_results_directory_absolute):
1817         (RunTest.test_results_directory_relative):
1818         (RunTest.test_retrying_and_flaky_tests):
1819         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1820         (RunTest.test_retrying_uses_retries_directory):
1821         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1822         (RunTest.test_output_diffs):
1823         (EndToEndTest.test_reftest_with_two_notrefs):
1824         (RebaselineTest.test_reset_results):
1825         (RebaselineTest.test_missing_results):
1826         (RebaselineTest.test_new_baseline):
1827
1828         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1829         (BuildBotPrinter.print_results):
1830         (BuildBotPrinter.print_unexpected_results):
1831         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1832         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1833
1834 2013-03-25  Julie Parent  <jparent@chromium.org>
1835
1836         Dashboard refactor: Move cross dashboard history related code into history.js.
1837         https://bugs.webkit.org/show_bug.cgi?id=113104
1838
1839         Reviewed by Ojan Vafai.
1840
1841         All functions relating to cross dashboard behavior move from being
1842         globals to methods on the history.History object. Names stay the same,
1843         except many are made private, ones that should have been constants now
1844         are, and the long standing TODO to change "currentState" to 
1845         dashboardSpecificState is done.
1846         
1847         We now create a global history object in dashboard_base, as an 
1848         intermediate measure.  Once the dashboard specific code is
1849         added to history, each DB will need to create its own, and this
1850         global will be eliminated.
1851         
1852         * TestResultServer/static-dashboards/aggregate_results.js:
1853         (handleValidHashParameter):
1854         (htmlForBuilder):
1855         (rawValuesHTML):
1856         * TestResultServer/static-dashboards/dashboard_base.js:
1857         (parseDashboardSpecificParameters):
1858         (defaultValue):
1859         (currentBuilderGroupCategory):
1860         (currentBuilderGroupName):
1861         (handleLocationChange):
1862         (expectationsMap):
1863         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1864         (generatePage):
1865         (.switch.return):
1866         (platformAndBuildType):
1867         (individualTests):
1868         (substringList):
1869         (processMissingAndExtraExpectations):
1870         (pathToFailureLog):
1871         (showPopupForBuild):
1872         (htmlForTestsWithExpectationsButNoFailures):
1873         (shouldHideTest):
1874         (isCrossBuilderView):
1875         (tableHeaders):
1876         (htmlForSingleTestRow):
1877         (htmlForTableColumnHeader):
1878         (generatePageForExpectationsUpdate):
1879         (handleUpdate):
1880         (nextUpdate):
1881         (setUpdateIndex):
1882         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1883         (.appendExpectationsItem):
1884         (loadExpectations):
1885         (.dummyNode.onload):
1886         (loadExpectationsLayoutTests):
1887         (appendExpectations):
1888         (htmlForNavBar):
1889         (checkBoxToToggleState):
1890         (linkHTMLToToggleState):
1891         (generatePageForBuilder):
1892         (isInvalidKeyForCrossBuilderView):
1893         (handleQueryParameterChange):
1894         (showLegend):
1895         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1896         (resetGlobals):
1897         (test):
1898         * TestResultServer/static-dashboards/history.js:
1899         (.):
1900         * TestResultServer/static-dashboards/history_unittests.js:
1901         * TestResultServer/static-dashboards/loader.js:
1902         (.):
1903         * TestResultServer/static-dashboards/loader_unittests.js:
1904         * TestResultServer/static-dashboards/timeline_explorer.js:
1905         (generatePage):
1906         (initCurrentBuilderTestResults):
1907         (selectBuild):
1908         (showResultsDelta):
1909         * TestResultServer/static-dashboards/treemap.js:
1910         (generatePage):
1911         (.switch.return):
1912         (handleFocus):
1913         * TestResultServer/static-dashboards/ui.js:
1914
1915 2013-03-25  Roger Fong  <roger_fong@apple.com>
1916
1917         Unreviewed. Enable WinEWS tests again.
1918
1919         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1920         (WinEWS):
1921
1922 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1923
1924         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1925         https://bugs.webkit.org/show_bug.cgi?id=112166
1926
1927         HarfBuzz 0.9.14 merged my patch for icu detection without
1928         pkg-config files, as needed by for example Ubuntu 12.04.
1929         This obsoletes our local workaround. Removed it for GTK and EFL.
1930
1931         Reviewed by Martin Robinson.
1932
1933         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1934         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1935         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1936         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1937
1938 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1939
1940         Unreviewed.  Move self from contributor to committer list.
1941
1942         * Scripts/webkitpy/common/config/committers.py:
1943
1944 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1945
1946         EWS should use a human readable port name when uploading layout test archives
1947         https://bugs.webkit.org/show_bug.cgi?id=113099
1948
1949         Reviewed by Dirk Pranke.
1950
1951         Use new port's object's name() method to report human readable port names.
1952         This will also help us resolving the bug to apply layout test results posted by EWS.
1953
1954         * Scripts/webkitpy/tool/bot/botinfo.py:
1955         (BotInfo.__init__): Take port's name.
1956         (BotInfo.summary_text):
1957
1958         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1959         (BotInfoTest.test_summary_text):
1960
1961         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1962         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1963
1964         * Scripts/webkitpy/tool/commands/queues.py:
1965         (PatchProcessingQueue.__init__): Initialize self._port.
1966         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1967         and use that for the attachment filename and the comment posted.
1968
1969         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1970         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1971         "mac-snowleopard" as expected for TestPort.
1972
1973 2013-03-22  Roger Fong  <roger_fong@apple.com>
1974
1975         Unreviewed. Turn off EWS test on Win again.
1976         The battle continues.
1977
1978         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1979         (WinEWS):
1980
1981 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1982
1983         NRWT: Enable pixel tests when retrying tests
1984         https://bugs.webkit.org/show_bug.cgi?id=112898
1985
1986         Reviewed by Dirk Pranke.
1987
1988         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1989         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1990         if we've forced pixel tests in the retry.
1991         (Manager._run_tests):
1992         (Manager._clean_up_run): Fixed the capitalizations.
1993         (Manager._force_pixel_tests_if_needed): Added.
1994
1995         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1996         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1997         'image_diff_percent' if it doesn't already exist.
1998
1999         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2000         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2001         treat this as a regular regression instead of a flakiness.
2002
2003         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2004         run had image diffs.
2005
2006         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2007         (summarized_results):
2008
2009         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2010         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2011         Also removed some dead code.
2012
2013         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2014         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2015         is set and pixel_tests_enabled is set to false.
2016         (EndToEndTest.test_reftest_with_two_notrefs):
2017
2018 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2019
2020         Make it possible to run layout tests on Retina MBP
2021         https://bugs.webkit.org/show_bug.cgi?id=93673
2022
2023         Reviewed by Ryosuke Niwa.
2024
2025         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2026         windows on 2x machines still run at 1x.
2027
2028         * DumpRenderTree/mac/DumpRenderTree.mm:
2029         (createWebViewAndOffscreenWindow):
2030         Reset the window resolution to 1x on creation.
2031         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2032         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2033         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2034         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2035         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2036         (WTR::PlatformWebView::PlatformWebView):
2037         Add NSWindow details, reset the window resolution to 1x on creation.
2038
2039 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2040
2041         Leak bots shouldn't build
2042         https://bugs.webkit.org/show_bug.cgi?id=112774
2043
2044         Reviewed by Simon Fraser.
2045
2046         Since leak bots use regular debug builds, there is no need to build on these bots.
2047         Simply downloading builds will dramatically improve the cycle time of these bots.
2048
2049         * BuildSlaveSupport/build.webkit.org-config/config.json:
2050         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2051         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2052         TestFactory instead of BuildAndTestFactory.
2053
2054 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2055
2056         [Qt] Fix the TestWebKitAPI build
2057         https://bugs.webkit.org/show_bug.cgi?id=113044
2058
2059         Reviewed by Tor Arne Vestbø.
2060
2061         The generate-forwarding-headers script would only be run
2062         after the targets in InjectedBundle.pri since the second
2063         addStrictSubdirOrderBetween call in
2064         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2065         the derived_sources -> injected_bundle order in SUBDIRS.
2066
2067         Fix it by only moving the dependent target at the end of
2068         SUBDIRS, don't touch its dependency.
2069
2070         * qmake/mkspecs/features/functions.prf:
2071
2072 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2073
2074         [EFL][WK2] View is not focused when fullscreen mode toggled
2075         https://bugs.webkit.org/show_bug.cgi?id=113009
2076
2077         Reviewed by Laszlo Gombos.
2078
2079         Set focus on view when fullscreen mode enabled/disabled
2080         by FullScreen API.
2081
2082         * MiniBrowser/efl/main.c:
2083         (on_fullscreen_accept):
2084         (on_fullscreen_deny):
2085
2086 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2087
2088         nrwt is no longer saving retry results in the retries/ subdirectory
2089         https://bugs.webkit.org/show_bug.cgi?id=112995
2090
2091         Reviewed by Ojan Vafai.
2092
2093         I think this has been broken a long time, unfortunately. This
2094         patch should fix that.
2095
2096         In order to do so, I had to pass the directory to use from
2097         the Worker object through the SingleTestWriter to the
2098         TestResultWriter. While I was plumbing that through, I rationalized
2099         the order of the parameter arguments a bit ...
2100
2101         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2102         (Worker._run_single_test):
2103         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2104         (run_single_test):
2105         (SingleTestRunner.__init__):
2106         (SingleTestRunner._run_compare_test):
2107         (SingleTestRunner._run_rebaseline):
2108         (SingleTestRunner._run_reftest):
2109         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2110         (write_test_result):
2111         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2112         (TestResultWriterTest.test_reftest_diff_image):
2113         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2114         (RunTest.test_retrying_uses_retries_directory):
2115
2116 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2117
2118         JSC profiler should have an at-a-glance report of the success of DFG optimization
2119         https://bugs.webkit.org/show_bug.cgi?id=112988
2120
2121         Reviewed by Geoffrey Garen.
2122
2123         * Scripts/display-profiler-output:
2124
2125 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2126
2127         [chromium] Linux ASAN WebKit canary is running out of memory
2128         https://bugs.webkit.org/show_bug.cgi?id=112978
2129
2130         Reviewed by Tony Chang.
2131
2132         Running the AddressSanitizer on a crash takes a lot of
2133         memory, so we should serialize access to it to avoid running
2134         out of memory on a machine.
2135
2136         * Scripts/webkitpy/layout_tests/port/chromium.py:
2137         (ChromiumPort._get_crash_log):
2138         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2139         (HttpLock.__init__):
2140         (HttpLock.wait_for_httpd_lock):
2141
2142 2013-03-21  Min Qin  <qinmin@chromium.org>
2143
2144         Cleanup android media layout test code
2145         https://bugs.webkit.org/show_bug.cgi?id=112944
2146
2147         Reviewed by Adam Barth.
2148
2149         Chromium change: https://codereview.chromium.org/12892010/
2150         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2151         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2152         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2153         Instead, we should switch to use content shell for layout tests.
2154
2155         * DumpRenderTree/chromium/TestShell.cpp:
2156         (TestShell::resetTestController):
2157
2158 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2159
2160         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2161         https://bugs.webkit.org/show_bug.cgi?id=112953
2162
2163         Reviewed by Tony Chang.
2164
2165         When I created the DumpRenderTree_resources target in r144863 I
2166         forgot to declare the needed dependencies on the other resource
2167         targets. Due to a quirk of ordering, this appears to have been fine
2168         w/ ninja but not w/ Xcode (which is still being used on the chromium
2169         mac valgrind bots). Declaring the dependencies fixes the build
2170         failures.
2171
2172         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2173
2174 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2175
2176         [WinCairo] Correct assert in Empty BitmapImage Test.
2177         https://bugs.webkit.org/show_bug.cgi?id=112934
2178
2179         Reviewed by Tim Horton.
2180
2181         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2182         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2183         to avoid ref counting assertion when leaving test scope.
2184
2185 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2186
2187         [GTK] generate-feature-defines-files is incompatible with Python3
2188         https://bugs.webkit.org/show_bug.cgi?id=112956
2189
2190         Reviewed by Martin Robinson.
2191
2192         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2193         method on the dictionary objects when iterating through said dictionaries.
2194
2195         * gtk/generate-feature-defines-files:
2196         (write_feature_defines_header):
2197         (write_flattened_feature_defines_file):
2198
2199 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2200
2201         kill-old-processes spits out error messages on Mac
2202         https://bugs.webkit.org/show_bug.cgi?id=112878
2203
2204         Reviewed by Jessie Berlin.
2205
2206         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2207         included in the list of options grep --help shows.
2208
2209         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2210
2211         * BuildSlaveSupport/kill-old-processes:
2212         (main):
2213
2214 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2215
2216         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2217         https://bugs.webkit.org/show_bug.cgi?id=112597
2218
2219         Reviewed by Xan Lopez.
2220
2221         These were introduced for the Chromium port in r105295. We need
2222         dummy implementations in order to compile the BlackBerry port.
2223
2224         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2225         (AccessibilityUIElement::scrollToMakeVisible):
2226         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2227         (AccessibilityUIElement::scrollToGlobalPoint):
2228
2229 2013-03-21  Roger Fong  <roger_fong@apple.com>
2230
2231         Re-enable WinEWS tests following r146376.
2232
2233         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2234         (WinEWS):
2235
2236 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2237
2238         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2239
2240         * Scripts/webkitpy/common/config/committers.py:
2241
2242 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2243
2244         [GTK] Missing atk in install-dependencies script
2245         https://bugs.webkit.org/show_bug.cgi?id=112272
2246
2247         Reviewed by Gustavo Noronha Silva.
2248
2249         * gtk/install-dependencies: Add missing atk dependency.
2250
2251 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2252
2253         [GTK] Missing backslash in install-dependencies script
2254         https://bugs.webkit.org/show_bug.cgi?id=112907
2255
2256         Reviewed by Philippe Normand.
2257
2258         * gtk/install-dependencies: Add missing backslash to dependencies
2259         list.
2260
2261 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2262
2263         EWS bots have stopped uploading results to bugzilla
2264         https://bugs.webkit.org/show_bug.cgi?id=101091
2265
2266         Reviewed by Adam Barth.
2267
2268         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2269         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2270         this relative file path resoled to a file inside a non-existent directory for "zip".
2271
2272         Fixed the bug by resolving both test results directory and zip archive paths in
2273         LayoutTestResultsReader.archive.
2274
2275         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2276         in the future.
2277
2278         * Scripts/webkitpy/common/system/filesystem_mock.py:
2279         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2280
2281         * Scripts/webkitpy/common/system/workspace.py:
2282         (Workspace.create_zip): Log the source path when "zip" failed.
2283
2284         * Scripts/webkitpy/common/system/workspace_mock.py:
2285         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2286
2287         * Scripts/webkitpy/common/system/workspace_unittest.py:
2288         (WorkspaceTest.test_create_zip_exception): Test that.
2289
2290         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2291         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2292         This is the actual bug fix.
2293
2294         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2295         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2296
2297 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2298
2299         [chromium] move WebThemeEngine implementations to TestRunner library
2300         https://bugs.webkit.org/show_bug.cgi?id=112751
2301
2302         Reviewed by Adam Barth.
2303
2304         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2305         * DumpRenderTree/DumpRenderTree.gypi:
2306         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2307         (WebKit):
2308         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2309         (WebTestRunner::TestInterfaces::themeEngine):
2310         (WebTestRunner):
2311         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2312         (WebKit):
2313         (TestInterfaces):
2314         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2315         (WebTestRunner::WebTestInterfaces::themeEngine):
2316         (WebTestRunner):
2317         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2318         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2319         (WebTestRunner):
2320         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2321         (WebTestRunner::WebTestThemeControlWin::box):
2322         (WebTestRunner::WebTestThemeControlWin::line):
2323         (WebTestRunner::WebTestThemeControlWin::triangle):
2324         (WebTestRunner::WebTestThemeControlWin::roundRect):
2325         (WebTestRunner::WebTestThemeControlWin::oval):
2326         (WebTestRunner::WebTestThemeControlWin::circle):
2327         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2328         (WebTestRunner::WebTestThemeControlWin::markState):
2329         (WebTestRunner::WebTestThemeControlWin::draw):
2330         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2331         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2332         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2333         (WebTestRunner):
2334         (WebTestThemeControlWin):
2335         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2336         (WebTestRunner):
2337         (WebTestThemeEngineMac):
2338         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2339         (+[FakeActiveWindow alwaysActiveWindow]):
2340         (+[FakeActiveWindow alwaysInactiveWindow]):
2341         (-[FakeActiveWindow initWithActiveControls:]):
2342         (-[FakeActiveWindow _hasActiveControls]):
2343         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2344         (WebTestRunner):
2345         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2346         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2347         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2348         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2349         (WebTestRunner):
2350         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2351         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2352         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2353         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2354         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2355         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2356         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2357         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2358         (WebTestRunner::WebTestThemeEngineWin::getSize):
2359         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2360         (WebTestRunner):
2361         (WebTestThemeEngineWin):
2362         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2363         * DumpRenderTree/chromium/TestShell.cpp:
2364         (TestShell::initialize):
2365         * DumpRenderTree/chromium/TestShell.h:
2366         (WebKit):
2367         * DumpRenderTree/chromium/TestShellMac.mm:
2368         (platformInit):
2369         * DumpRenderTree/chromium/TestShellWin.cpp:
2370         (platformInit):
2371         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2372
2373 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2374
2375         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2376
2377         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2378         New property sheet that does not link against CoreFoundation and
2379         CFNetwork.
2380         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2381         Use new TestWebKitAPICommonWinCairo property sheet.
2382         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2383         Ditto.
2384
2385 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2386
2387         [WinCairo] Unreviewed build fix for VS2010.
2388
2389         Had to add WinCairo-specific property sheets to deal with some
2390         library and path differences with the main Apple port.
2391
2392         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2393         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2394         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2395         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2396         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2397         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2398
2399 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2400
2401         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2402         https://bugs.webkit.org/show_bug.cgi?id=112849
2403
2404         Reviewed by Sam Weinig.
2405
2406         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2407         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2408         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2409
2410 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2411
2412         [WinCairo] Build WebKit Tools under VS2010
2413         https://bugs.webkit.org/show_bug.cgi?id=112821
2414
2415         Reviewed by Tim Horton.
2416
2417         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2418         Add WinCairo-specific build target.
2419         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2420         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2421         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2422         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2423         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2424         Add WinCairo-specific build target.
2425         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2426         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2427         Add WinCairo-specific build target.
2428         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2429         WinCairo-specific build target.
2430         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2431         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2432         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2433         specific build target.
2434         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2435         WinCairo-specific build target.
2436         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2437         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2438         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2439
2440 2013-03-20  Roger Fong  <roger_fong@apple.com>
2441
2442         API test gardening AppleWin port.
2443
2444         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2445
2446         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2447         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2448
2449 2013-03-20  Roger Fong  <roger_fong@apple.com>
2450
2451         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2452
2453         * EWSTools/start-queue-win.sh:
2454
2455 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2456
2457         Unreviewed, add myself to committers.py.
2458
2459 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2460
2461         Unreviewed. Adding another email for me.
2462
2463         * Scripts/webkitpy/common/config/committers.py:
2464
2465 2013-03-20  Justin Novosad  <junov@google.com>
2466
2467         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2468         https://bugs.webkit.org/show_bug.cgi?id=112605
2469
2470         Reviewed by James Robinson.
2471
2472         Deleting all the code that was used for propagating and supporting
2473         the Chromium setting for disabling deferred 2d canvas rendering.
2474
2475         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2476         (main):
2477         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2478         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2479         (WebTestRunner::WebPreferences::reset):
2480         (WebTestRunner::WebPreferences::applyTo):
2481         * DumpRenderTree/chromium/TestShell.cpp:
2482         (TestShell::TestShell):
2483         (TestShell::resetWebSettings):
2484         (TestShell::runFileTest):
2485         * DumpRenderTree/chromium/TestShell.h:
2486         (TestShell):
2487
2488 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2489
2490         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2491         https://bugs.webkit.org/show_bug.cgi?id=112699.
2492
2493         Reviewed by Adam Barth.
2494
2495         * Scripts/webkitpy/layout_tests/port/qt.py:
2496         (QtPort._search_paths):
2497         (QtPort._port_specific_expectations_files):
2498         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2499         (QtPortTest):
2500         (QtPortTest._assert_search_path):
2501         (QtPortTest._assert_expectations_files):
2502
2503 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2504
2505         [Qt] Enable kerning by default
2506         https://bugs.webkit.org/show_bug.cgi?id=112704
2507
2508         Reviewed by Jocelyn Turcotte.
2509
2510         Disable kerning by default, since some reference test expectations
2511         expect kerning to be default off.
2512
2513         * DumpRenderTree/qt/TestRunnerQt.cpp:
2514         (TestRunnerQt::reset):
2515         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2516         (WTR::activateFonts):
2517
2518 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2519
2520         [Qt] Remove empty function stubs from TestRunnerQt.
2521         https://bugs.webkit.org/show_bug.cgi?id=112799
2522
2523         We are reducing the code in TestRunnerQt step by step,
2524         in order to finally replace all of it with the generic
2525         TestRunner implementation.
2526         This patch removes several simple function stubs that
2527         currently do not implement any actual functionality.
2528
2529         Reviewed by Kenneth Rohde Christiansen.
2530
2531         * DumpRenderTree/qt/TestRunnerQt.cpp:
2532         * DumpRenderTree/qt/TestRunnerQt.h:
2533         (TestRunnerQt):
2534
2535 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2536
2537         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2538         https://bugs.webkit.org/show_bug.cgi?id=112687
2539
2540         Reviewed by Kenneth Rohde Christiansen.
2541
2542         Hide the SearchBar by default on window creation.
2543
2544         * MiniBrowser/efl/main.c:
2545         (window_create):
2546
2547 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2548
2549         Unreviewed, rolling out r146304.
2550         http://trac.webkit.org/changeset/146304
2551         https://bugs.webkit.org/show_bug.cgi?id=112788
2552
2553         to many expectations to update (Requested by antonm on
2554         #webkit).
2555
2556         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2557         * DumpRenderTree/DumpRenderTree.gypi:
2558         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2559         (WebKit):
2560         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2561         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2562         (TestInterfaces):
2563         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2564         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2565         * DumpRenderTree/chromium/TestShell.cpp:
2566         (TestShell::initialize):
2567         * DumpRenderTree/chromium/TestShell.h:
2568         (WebKit):
2569         * DumpRenderTree/chromium/TestShellMac.mm:
2570         (platformInit):
2571         * DumpRenderTree/chromium/TestShellWin.cpp:
2572         (platformInit):
2573         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2574         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2575         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2576         (WebThemeControlDRTWin::box):
2577         (WebThemeControlDRTWin::line):
2578         (WebThemeControlDRTWin::triangle):
2579         (WebThemeControlDRTWin::roundRect):
2580         (WebThemeControlDRTWin::oval):
2581         (WebThemeControlDRTWin::circle):
2582         (WebThemeControlDRTWin::nestedBoxes):
2583         (WebThemeControlDRTWin::markState):
2584         (WebThemeControlDRTWin::draw):
2585         (WebThemeControlDRTWin::drawTextField):
2586         (WebThemeControlDRTWin::drawProgressBar):
2587         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2588         (WebThemeControlDRTWin):
2589         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2590         (WebThemeEngineDRTMac):
2591         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2592         (+[FakeActiveWindow alwaysActiveWindow]):
2593         (+[FakeActiveWindow alwaysInactiveWindow]):
2594         (-[FakeActiveWindow initWithActiveControls:]):
2595         (-[FakeActiveWindow _hasActiveControls]):
2596         (WebThemeEngineDRTMac::paintScrollbarThumb):
2597         (stateToHIEnableState):
2598         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2599         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2600         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2601         (webRectToSkIRect):
2602         (drawControl):
2603         (drawTextField):
2604         (drawProgressBar):
2605         (WebThemeEngineDRTWin::paintButton):
2606         (WebThemeEngineDRTWin::paintMenuList):
2607         (WebThemeEngineDRTWin::paintScrollbarArrow):
2608         (WebThemeEngineDRTWin::paintScrollbarThumb):
2609         (WebThemeEngineDRTWin::paintScrollbarTrack):
2610         (WebThemeEngineDRTWin::paintSpinButton):
2611         (WebThemeEngineDRTWin::paintTextField):
2612         (WebThemeEngineDRTWin::paintTrackbar):
2613         (WebThemeEngineDRTWin::paintProgressBar):
2614         (WebThemeEngineDRTWin::getSize):
2615         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2616         (WebThemeEngineDRTWin):
2617         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2618
2619 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2620
2621         [Qt] Support -webkit-font-smoothing
2622         https://bugs.webkit.org/show_bug.cgi?id=106009
2623
2624         Reviewed by Jocelyn Turcotte.
2625
2626         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2627
2628         * DumpRenderTree/qt/TestRunnerQt.cpp:
2629         (TestRunnerQt::reset):
2630
2631 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2632
2633         [GTK] accessibility/aria-scrollbar-role.html is failing
2634         https://bugs.webkit.org/show_bug.cgi?id=98358
2635
2636         Reviewed by Martin Robinson.
2637
2638         Adds support for checking accessibility object's orientation.
2639         Orientation is checked by retrieving proper state of accessibility object.
2640
2641         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2642         (checkElementState):
2643         (AccessibilityUIElement::orientation):
2644         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2645         (WTR::AccessibilityUIElement::orientation):
2646
2647 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2648
2649         [chromium] move WebThemeEngine implementations to TestRunner library
2650         https://bugs.webkit.org/show_bug.cgi?id=112751
2651
2652         Reviewed by Adam Barth.
2653
2654         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2655         * DumpRenderTree/DumpRenderTree.gypi:
2656         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2657         (WebKit):
2658         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2659         (WebTestRunner::TestInterfaces::themeEngine):
2660         (WebTestRunner):
2661         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2662         (WebKit):
2663         (TestInterfaces):
2664         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2665         (WebTestRunner::WebTestInterfaces::themeEngine):
2666         (WebTestRunner):
2667         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2668         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2669         (WebTestRunner):
2670         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2671         (WebTestRunner::WebTestThemeControlWin::box):
2672         (WebTestRunner::WebTestThemeControlWin::line):
2673         (WebTestRunner::WebTestThemeControlWin::triangle):
2674         (WebTestRunner::WebTestThemeControlWin::roundRect):
2675         (WebTestRunner::WebTestThemeControlWin::oval):
2676         (WebTestRunner::WebTestThemeControlWin::circle):
2677         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2678         (WebTestRunner::WebTestThemeControlWin::markState):
2679         (WebTestRunner::WebTestThemeControlWin::draw):
2680         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2681         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2682         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2683         (WebTestRunner):
2684         (WebTestThemeControlWin):
2685         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2686         (WebTestRunner):
2687         (WebTestThemeEngineMac):
2688         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2689         (+[FakeActiveWindow alwaysActiveWindow]):
2690         (+[FakeActiveWindow alwaysInactiveWindow]):
2691         (-[FakeActiveWindow initWithActiveControls:]):
2692         (-[FakeActiveWindow _hasActiveControls]):
2693         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2694         (WebTestRunner):
2695         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2696         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2697         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2698         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2699         (WebTestRunner):
2700         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2701         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2702         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2703         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2704         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2705         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2706         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2707         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2708         (WebTestRunner::WebTestThemeEngineWin::getSize):
2709         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2710         (WebTestRunner):
2711         (WebTestThemeEngineWin):
2712         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2713         * DumpRenderTree/chromium/TestShell.cpp:
2714         (TestShell::initialize):
2715         * DumpRenderTree/chromium/TestShell.h:
2716         (WebKit):
2717         * DumpRenderTree/chromium/TestShellMac.mm:
2718         (platformInit):
2719         * DumpRenderTree/chromium/TestShellWin.cpp:
2720         (platformInit):
2721         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2722
2723 2013-03-19  Tony Chang  <tony@chromium.org>
2724
2725         Move testRunner.setTouchDragDropEnabled to internals.settings
2726         https://bugs.webkit.org/show_bug.cgi?id=112739
2727
2728         Reviewed by Adam Barth.
2729
2730         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2731         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2732         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2733         (TestRunner): Remove unnecessary code.
2734         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2735         (WebTestRunner::WebPreferences::reset):
2736         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2737
2738 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2739
2740         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2741         https://bugs.webkit.org/show_bug.cgi?id=112754
2742
2743         Reviewed by Darin Fisher.
2744
2745         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2746         now that it's always defined.
2747
2748         * DumpRenderTree/chromium/WebViewHost.cpp:
2749         * DumpRenderTree/chromium/WebViewHost.h:
2750         (WebViewHost):
2751
2752 2013-03-19  Kenneth Russell  <kbr@google.com>
2753
2754         Unreviewed, rolling out r146290.
2755         http://trac.webkit.org/changeset/146290
2756         https://bugs.webkit.org/show_bug.cgi?id=112751
2757
2758         Broke Chromium Mac build.
2759
2760         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2761         * DumpRenderTree/DumpRenderTree.gypi:
2762         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2763         (WebKit):
2764         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2765         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2766         (TestInterfaces):
2767         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2768         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2769         * DumpRenderTree/chromium/TestShell.cpp:
2770         (TestShell::initialize):
2771         * DumpRenderTree/chromium/TestShell.h:
2772         (WebKit):
2773         * DumpRenderTree/chromium/TestShellMac.mm:
2774         (platformInit):
2775         * DumpRenderTree/chromium/TestShellWin.cpp:
2776         (platformInit):
2777         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2778         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2779         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2780         (WebThemeControlDRTWin::box):
2781         (WebThemeControlDRTWin::line):
2782         (WebThemeControlDRTWin::triangle):
2783         (WebThemeControlDRTWin::roundRect):
2784         (WebThemeControlDRTWin::oval):
2785         (WebThemeControlDRTWin::circle):
2786         (WebThemeControlDRTWin::nestedBoxes):
2787         (WebThemeControlDRTWin::markState):
2788         (WebThemeControlDRTWin::draw):
2789         (WebThemeControlDRTWin::drawTextField):
2790         (WebThemeControlDRTWin::drawProgressBar):
2791         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2792         (WebThemeControlDRTWin):
2793         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2794         (WebThemeEngineDRTMac):
2795         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2796         (+[FakeActiveWindow alwaysActiveWindow]):
2797         (+[FakeActiveWindow alwaysInactiveWindow]):
2798         (-[FakeActiveWindow initWithActiveControls:]):
2799         (-[FakeActiveWindow _hasActiveControls]):
2800         (WebThemeEngineDRTMac::paintScrollbarThumb):
2801         (stateToHIEnableState):
2802         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2803         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2804         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2805         (webRectToSkIRect):
2806         (drawControl):
2807         (drawTextField):
2808         (drawProgressBar):
2809         (WebThemeEngineDRTWin::paintButton):
2810         (WebThemeEngineDRTWin::paintMenuList):
2811         (WebThemeEngineDRTWin::paintScrollbarArrow):
2812         (WebThemeEngineDRTWin::paintScrollbarThumb):
2813         (WebThemeEngineDRTWin::paintScrollbarTrack):
2814         (WebThemeEngineDRTWin::paintSpinButton):
2815         (WebThemeEngineDRTWin::paintTextField):
2816         (WebThemeEngineDRTWin::paintTrackbar):
2817         (WebThemeEngineDRTWin::paintProgressBar):
2818         (WebThemeEngineDRTWin::getSize):
2819         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2820         (WebThemeEngineDRTWin):
2821         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2822
2823 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2824
2825         [EFL] canvas-fallback-content.html is failing
2826         https://bugs.webkit.org/show_bug.cgi?id=111998
2827
2828         Reviewed by Chris Fleizach.
2829
2830         Adds support for getting platform name.
2831
2832         * DumpRenderTree/TestRunner.cpp:
2833         (TestRunner::staticValues):
2834         * DumpRenderTree/TestRunner.h:
2835         (TestRunner):
2836         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2837         (TestRunner::platformName):
2838
2839 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2840
2841         [chromium] move WebThemeEngine implementations to TestRunner library
2842         https://bugs.webkit.org/show_bug.cgi?id=112751
2843
2844         Reviewed by Adam Barth.
2845
2846         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2847         * DumpRenderTree/DumpRenderTree.gypi:
2848         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2849         (WebKit):
2850         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2851         (WebTestRunner::TestInterfaces::themeEngine):
2852         (WebTestRunner):
2853         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2854         (WebKit):
2855         (TestInterfaces):
2856         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2857         (WebTestRunner::WebTestInterfaces::themeEngine):
2858         (WebTestRunner):
2859         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2860         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2861         (WebTestRunner):
2862         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2863         (WebTestRunner::WebTestThemeControlWin::box):
2864         (WebTestRunner::WebTestThemeControlWin::line):
2865         (WebTestRunner::WebTestThemeControlWin::triangle):
2866         (WebTestRunner::WebTestThemeControlWin::roundRect):
2867         (WebTestRunner::WebTestThemeControlWin::oval):
2868         (WebTestRunner::WebTestThemeControlWin::circle):
2869         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2870         (WebTestRunner::WebTestThemeControlWin::markState):
2871         (WebTestRunner::WebTestThemeControlWin::draw):
2872         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2873         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2874         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2875         (WebTestRunner):
2876         (WebTestThemeControlWin):
2877         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2878         (WebTestRunner):
2879         (WebTestThemeEngineMac):
2880         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2881         (+[FakeActiveWindow alwaysActiveWindow]):
2882         (+[FakeActiveWindow alwaysInactiveWindow]):
2883         (-[FakeActiveWindow initWithActiveControls:]):
2884         (-[FakeActiveWindow _hasActiveControls]):
2885         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2886         (WebTestRunner):
2887         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2888         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2889         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2890         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2891         (WebTestRunner):
2892         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2893         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2894         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2895         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2896         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2897         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2898         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2899         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2900         (WebTestRunner::WebTestThemeEngineWin::getSize):
2901         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2902         (WebTestRunner):
2903         (WebTestThemeEngineWin):
2904         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2905         * DumpRenderTree/chromium/TestShell.cpp:
2906         (TestShell::initialize):
2907         * DumpRenderTree/chromium/TestShell.h:
2908         (WebKit):
2909         * DumpRenderTree/chromium/TestShellMac.mm:
2910         (platformInit):
2911         * DumpRenderTree/chromium/TestShellWin.cpp:
2912         (platformInit):
2913         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2914
2915 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2916
2917         [EFL][WK2] Separate WebView further from EwkView
2918         https://bugs.webkit.org/show_bug.cgi?id=111591
2919
2920         Reviewed by Caio Marcelo de Oliveira Filho.
2921
2922         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2923         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2924         since we can afford it having EWKViewGetWKView() private API to access WKView.
2925
2926         * TestWebKitAPI/PlatformWebView.h:
2927         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2928         (TestWebKitAPI::TEST):
2929         * TestWebKitAPI/efl/PlatformWebView.cpp:
2930         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2931         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2932         (TestWebKitAPI::PlatformWebView::resizeTo):
2933         (TestWebKitAPI::PlatformWebView::page):
2934         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2935         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2936         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2937         * WebKitTestRunner/PlatformWebView.h:
2938         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2939         (WTR::EventSenderProxy::dispatchEvent):
2940         (WTR::EventSenderProxy::keyDown):
2941         (WTR::EventSenderProxy::sendTouchEvent):
2942         (WTR::EventSenderProxy::setTouchModifier):
2943         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2944         (WTR::PlatformWebView::PlatformWebView):
2945         (WTR::PlatformWebView::~PlatformWebView):
2946         (WTR::PlatformWebView::resizeTo):
2947         (WTR::PlatformWebView::page):
2948         (WTR::PlatformWebView::focus):
2949         (WTR::PlatformWebView::windowSnapshotImage):
2950
2951 2013-03-19  Roger Fong  <roger_fong@apple.com>
2952
2953         Changes to VS2010 project files should only trigger builds on Windows bots.
2954         https://bugs.webkit.org/show_bug.cgi?id=112731
2955
2956         Reviewed by Timothy Horton.
2957
2958         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2959         (_should_file_trigger_build):
2960
2961 2013-03-19  Roger Fong  <roger_fong@apple.com>
2962
2963         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2964
2965         * Scripts/webkitpy/tool/steps/runtests.py:
2966         (RunTests.run):
2967         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2968         (RunTestsTest.test_webkit_run_unit_tests):
2969
2970 2013-03-19  Julie Parent  <jparent@chromium.org>
2971
2972         Dashboards: Introduce history namespace and unit tests.
2973         https://bugs.webkit.org/show_bug.cgi?id=112645
2974
2975         Reviewed by Ojan Vafai.
2976         
2977         Laying the framework for introducing the new history object and
2978         namespace.  This moves only static functions into the history
2979         namespace, and moves corresponding unit tests into seperate
2980         unit test file.
2981
2982         * TestResultServer/static-dashboards/aggregate_results.html:
2983         * TestResultServer/static-dashboards/dashboard_base.js:
2984         (parseCrossDashboardParameters):
2985         (parseDashboardSpecificParameters):
2986         (parseParameters):
2987         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2988         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2989         (.switch.return):
2990         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2991         * TestResultServer/static-dashboards/history.js: Added.
2992         * TestResultServer/static-dashboards/history_unittests.js: Added.
2993         * TestResultServer/static-dashboards/loader.js:
2994         (.):
2995         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2996         * TestResultServer/static-dashboards/run-unittests.html:
2997         * TestResultServer/static-dashboards/timeline_explorer.html:
2998         * TestResultServer/static-dashboards/timeline_explorer.js:
2999         * TestResultServer/static-dashboards/treemap.html:
3000         * TestResultServer/static-dashboards/treemap.js:
3001         (.switch.return):
3002         * TestResultServer/static-dashboards/ui.js:
3003
3004 2013-03-19  Daniel Bates  <dbates@webkit.org>
3005
3006         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3007         https://bugs.webkit.org/show_bug.cgi?id=112732
3008
3009         Reviewed by Eric Seidel.
3010
3011         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3012         of an existing file cannot be applied.
3013
3014         In particular, svn-{apply, unapply} compensate for differences in line endings
3015         by converting the line endings in a diff to match the line endings in the target
3016         file. The diff(1) command precedes the last line of a diff that adds a newline
3017         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3018         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3019         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3020         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3021         the newline characters in this special character sequence to match the line endings
3022         in the target file.
3023
3024         * Scripts/VCSUtils.pm:
3025         (parseDiff):
3026         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3027         Added tests:
3028             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3029             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3030             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3031             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3032         (escapeNewLineCharacters): Added.
3033         (toMacLineEndings): Added.
3034
3035 2013-03-19  James Robinson  <jamesr@chromium.org>
3036
3037         [chromium] Remove compositor settings that don't go through WebKit
3038         https://bugs.webkit.org/show_bug.cgi?id=112718
3039
3040         Reviewed by Adam Barth.
3041
3042         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3043         (main):
3044         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3045         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3046         (WebTestRunner::WebPreferences::reset):
3047         (WebTestRunner::WebPreferences::applyTo):
3048         * DumpRenderTree/chromium/TestShell.cpp:
3049         (TestShell::TestShell):
3050         (TestShell::resetWebSettings):
3051         * DumpRenderTree/chromium/TestShell.h:
3052         (TestShell):
3053
3054 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3055
3056         Unreviewed, rolling out r146101.
3057         https://bugs.webkit.org/show_bug.cgi?id=111884
3058
3059         re-enable custom freetype on asan; this needs to be on
3060         now that the bot is running lucid.
3061
3062         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3063
3064 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3065
3066         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3067         https://bugs.webkit.org/show_bug.cgi?id=112365
3068
3069         Reviewed by Benjamin Poulain.
3070
3071         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3072         harcoding it in wtf/Platform.h
3073
3074         * Scripts/webkitperl/FeatureList.pm:
3075
3076 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3077
3078         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3079         https://bugs.webkit.org/show_bug.cgi?id=94782
3080
3081         Based on patch by Csaba Osztrogonác.
3082         Reviewed by Jocelyn Turcotte.
3083
3084         The diff image is generated with bright red indicating errors, but letting the base image
3085         shine through so the context of the error-pixel can be identified.
3086
3087         * DumpRenderTree/qt/ImageDiff.cpp:
3088         (main):
3089
3090 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3091
3092         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3093
3094         Rubber-stamped by Csaba Osztrogonác.
3095
3096         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3097         since the latter might not cover the former.
3098
3099         * QtTestBrowser/launcherwindow.cpp:
3100         (LauncherWindow::print):
3101
3102 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3103
3104         Style tweeks to default.css.
3105         
3106         Rubber-stamped by David Kilzer.
3107         
3108         Give visited links a different color to other links, so you can
3109         see which builds you've viewed.
3110         
3111         Make the <small> text less tiny.
3112
3113         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3114         (small):
3115         (a:link,a:visited,a:active):
3116         (a:visited):
3117
3118 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3119
3120         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3121         https://bugs.webkit.org/show_bug.cgi?id=112494
3122
3123         Reviewed by Dirk Pranke.
3124
3125         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3126         Also merged two pairs of methods to cleanup the code.
3127
3128         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3129         (PerfTestsRunner.run): Merged _upload_and_show_results.
3130         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3131
3132 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3133
3134         [chromium] build xdisplaycheck when building DRT
3135         https://bugs.webkit.org/show_bug.cgi?id=112636
3136
3137         Reviewed by Tony Chang.
3138
3139         It appears that we need xdisplaycheck to be built in order for
3140         Xvfb to be started correctly on the bots, and DRT was missing
3141         a dependency on it. This may be the cause of the ASAN bot not
3142         starting up properly (it only builds DRT).
3143
3144         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3145
3146 2013-03-18  David Levin  <levin@chromium.org>
3147
3148         Implement icon change notification dump for Chromium's test shell.
3149         https://bugs.webkit.org/show_bug.cgi?id=112614
3150
3151         This was previously implemented for some other platforms in r58111
3152         and r116547.
3153
3154         In r122806, fast/dom/icon-url-property.html stopped using it, but
3155         it is useful for tests, so I plan to re-add it to that test again.
3156
3157         Reviewed by Jochen Eisinger.
3158
3159         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3160         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3161          icon change notifications from WebKit may be logged in test output.
3162         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3163         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3164         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3165         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3166         (WebTestRunner):
3167         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3168         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3169         (TestRunner):
3170         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3171         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3172         (WebTestRunner):
3173         * DumpRenderTree/chromium/WebViewHost.cpp:
3174         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3175         * DumpRenderTree/chromium/WebViewHost.h:
3176         (WebViewHost):
3177
3178 2013-03-18  Julie Parent  <jparent@chromium.org>
3179
3180         Cleanup: Move js for treemap and aggregate_results into own js files.
3181         https://bugs.webkit.org/show_bug.cgi?id=112618
3182
3183         Reviewed by Dirk Pranke.
3184         
3185         No functional changes, just moving the code into separate js file
3186         rather than inlined in the html, so we can test it, make it more
3187         modular, etc.  Other dashboard types are already done this way.
3188
3189         * TestResultServer/static-dashboards/aggregate_results.html:
3190         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3191         (generatePage):
3192         (handleValidHashParameter):
3193         (htmlForBuilder):
3194         (rawValuesHTML):
3195         (chartHTML):
3196         (filteredValues):
3197         (chart):
3198         (htmlForRevisionRows):
3199         (wrapHTMLInTable):
3200         (htmlForSummaryTable):
3201         (valuesPerExpectation):
3202         (htmlForTestType):
3203         (htmlForTableRow):
3204         (extendedEncode):
3205         * TestResultServer/static-dashboards/treemap.html:
3206         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3207         (humanReadableTime):
3208         (convertToWebTreemapFormat):
3209         (reverseSortByAverage):
3210         (generatePage):
3211         (focusPath):
3212         (.switch.return):
3213         (handleQueryParameterChange):
3214         (extractName):
3215         (fullName):
3216         (handleFocus.):
3217         (handleFocus):
3218
3219 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3220
3221         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3222         https://bugs.webkit.org/show_bug.cgi?id=112622
3223
3224         Reviewed by Dirk Pranke.
3225
3226         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3227         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3228
3229 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3230
3231         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3232         https://bugs.webkit.org/show_bug.cgi?id=112619
3233
3234         Reviewed by Dirk Pranke.
3235
3236         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3237         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3238
3239         * Scripts/webkitpy/layout_tests/port/gtk.py:
3240         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3241         Port._webkit_baseline_path method.
3242         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3243         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3244         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3245         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3246         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3247         that are expected based on the builder name.
3248
3249 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3250
3251         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3252         https://bugs.webkit.org/show_bug.cgi?id=112571
3253
3254         Reviewed by Adam Barth.
3255
3256         Update function declarations for new WebFileSystemType enum. (All
3257         changes are behind an #ifdef so we can sync required changes in embedders.)
3258
3259         * DumpRenderTree/chromium/WebViewHost.cpp:
3260         (WebViewHost::openFileSystem):
3261         (WebViewHost::deleteFileSystem):
3262         * DumpRenderTree/chromium/WebViewHost.h:
3263         (WebViewHost):
3264
3265 2013-03-18  Julie Parent  <jparent@chromium.org>
3266
3267         Cleanup: Move timeline_exporer js out of html file into js.
3268         https://bugs.webkit.org/show_bug.cgi?id=112188
3269
3270         Reviewed by Dirk Pranke.
3271         
3272         Moves the javascript out of the html file and into a new js file.
3273         This follows the format of flakiness_dashboard.{html|js}.
3274         
3275         Also moves code from dashboard_base that is used only by this one
3276         dashboard, and makes it private to the dashboard.
3277
3278         * TestResultServer/static-dashboards/dashboard_base.js:
3279         * TestResultServer/static-dashboards/timeline_explorer.html:
3280         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3281         (generatePage):
3282         (initCurrentBuilderTestResults):
3283         (shouldShowWebKitRevisionsOnly):
3284         (updateTimelineForBuilder.):
3285         (updateTimelineForBuilder):
3286         (selectBuild):
3287         (updateBuildIndicator):
3288         (.addRow):
3289         (.addNumberRow):
3290         (.inspectorNode.getElementsByTagName.0.onclick):
3291         (.inspectorNode.getElementsByTagName.1.onclick):
3292         (.inspectorNode.getElementsByTagName.2.onclick):
3293         (updateBuildInspector):
3294         (showResultsDelta):
3295         (decompressResults.addFlakyDelta):
3296         (decompressResults):
3297
3298 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3299
3300         Unreviewed, rolling out r145272.
3301         http://trac.webkit.org/changeset/145272
3302         https://bugs.webkit.org/show_bug.cgi?id=111884
3303
3304         Turns out the ASAN build is still broken; possibly there's
3305         something still setting LD_LIBRARY_PATH, or possibly there's
3306         something else wrong. In the meantime, we need it to work again.
3307
3308         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3309
3310 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3311
3312         delete-stale-build-files is too aggressive
3313         https://bugs.webkit.org/show_bug.cgi?id=112595
3314
3315         Reviewed by Tim Horton.
3316
3317         It appears that whitelisting file extensions to keep is not a good idea.
3318         Blacklist files to delete instead, and only delete .o files for now.
3319         We can add more file extensions as needed.
3320
3321         * BuildSlaveSupport/delete-stale-build-files:
3322
3323 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3324
3325         Disable accessibility notifications after each test
3326         https://bugs.webkit.org/show_bug.cgi?id=112579
3327
3328         Reviewed by Tim Horton.
3329         
3330         In WebKitTestRunner, if any tests triggered accessibility notifications,
3331         the global notification handler would thereafter be active, and fire
3332         notifications for all subsequent tests.
3333         
3334         Fix by implementing AccessibilityController::resetToConsistentState() for
3335         Mac, and using it to clear the global notification handler.
3336
3337         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3338         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3339         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3340         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3341         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3342         (e.g. because of -autorelease).
3343         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3344         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3345         if there is one.
3346         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3347         Add -stopObserving
3348         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3349         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3350         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3351         center.
3352
3353 2013-03-18  Dana Jansens  <danakj@chromium.org>
3354
3355         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3356         https://bugs.webkit.org/show_bug.cgi?id=112392
3357
3358         Reviewed by James Robinson.
3359
3360         Removes the command line flag option from DRT.
3361
3362         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3363         (main):
3364
3365 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3366
3367         [GTK] plugins/plugin-clip-subframe.html is failing
3368         https://bugs.webkit.org/show_bug.cgi?id=112570
3369
3370         Reviewed by Martin Robinson.
3371
3372         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3373
3374 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3375
3376         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3377         https://bugs.webkit.org/show_bug.cgi?id=112442
3378
3379         Reviewed by Gustavo Noronha Silva.
3380
3381         * GtkLauncher/main.c:
3382         (reloadCb):
3383         (createToolbar):
3384         (createWindow):
3385
3386 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3387
3388         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3389         https://bugs.webkit.org/show_bug.cgi?id=112205
3390
3391         Disable this API test until Geoff can fix it.
3392
3393         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3394         (TestWebKitAPI::TEST):
3395
3396 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3397
3398         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3399         https://bugs.webkit.org/show_bug.cgi?id=112478
3400
3401         Reviewed by Tony Chang.
3402
3403         There is nothing that ensures that the log messages from the plugin
3404         come in before the layout test finished loading.
3405
3406         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3407         (PassDifferentNPPStruct::NPP_SetWindow):
3408         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3409         (NPP_SetWindow):
3410
3411 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3412
3413         Have the mac port support per_test_timeout in webkitpy
3414         https://bugs.webkit.org/show_bug.cgi?id=112466
3415
3416         Reviewed by Dirk Pranke.
3417         
3418         Both WTR and DRT handle --timeout arguments, so we can
3419         have the scripts pass the timeout values down to the tools.
3420
3421         * Scripts/webkitpy/layout_tests/port/mac.py:
3422         (MacPort.supports_per_test_timeout):
3423
3424 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3425
3426         Remove setAsynchronousSpellCheckingEnabled from test runners
3427         https://bugs.webkit.org/show_bug.cgi?id=112362
3428
3429         Reviewed by Tony Chang.
3430
3431         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3432         in internals.settings, so all ports can share it.
3433
3434         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3435         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3436         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3437         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3438         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3439         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3440         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3441         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3442         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3443         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3444         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3445         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3446
3447 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3448
3449         Fix the stupid unit tests.
3450
3451         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3452         (test_sample_process):
3453
3454 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3455
3456         Collect samples for unresponsive web processes
3457         https://bugs.webkit.org/show_bug.cgi?id=112409
3458
3459         Reviewed by Tim Horton.
3460         
3461         When we detect that a subprocess was unresponsive, run the 'sample'
3462         tool on that process, for the Mac port.
3463         
3464         The sample will be linked to from the results.html page, next
3465         to the crash log link.
3466
3467         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3468         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3469         look for samples on disk.
3470         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3471         (TestResultWriter):
3472         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3473         -sample.txt files, and have it copy their contents to a new file
3474         next to the test that spawned them (as we do for crash logs).
3475         * Scripts/webkitpy/layout_tests/port/base.py:
3476         (Port.look_for_new_samples): Base class does nothing for sampling.
3477         * Scripts/webkitpy/layout_tests/port/driver.py:
3478         (Driver._check_for_driver_crash): Kick off a sample if we detected
3479         that the subprocess was unresponsive.
3480         * Scripts/webkitpy/layout_tests/port/mac.py:
3481         (MacPort.sample_file_path): Utility to generate the file path
3482         to the generated sample files at the top level of layout-test-results.
3483         (MacPort.look_for_new_crash_logs): Fix typo
3484         (MacPort.look_for_new_samples): New function to find sample files.
3485         (MacPort.sample_process): Use the utility function to get the file path.
3486
3487 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3488
3489         [Qt] Remove simple getters and setters from TestRunnerQt
3490         https://bugs.webkit.org/show_bug.cgi?id=112343
3491
3492         Reviewed by Benjamin Poulain.
3493
3494         The removed functions and boolean members
3495         are being replaced by the implementations in the
3496         generic TestRunner.h.
3497
3498         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3499         (DumpRenderTree::dumpFrameScrollPosition):
3500         (DumpRenderTree::dumpFramesAsText):
3501         (DumpRenderTree::dump):
3502         (DumpRenderTree::titleChanged):
3503         (DumpRenderTree::dumpDatabaseQuota):
3504         (DumpRenderTree::dumpApplicationCacheQuota):
3505         (DumpRenderTree::statusBarMessage):
3506         (DumpRenderTree::createWindow):
3507         * DumpRenderTree/qt/TestRunnerQt.cpp:
3508         (TestRunnerQt::reset):
3509         * DumpRenderTree/qt/TestRunnerQt.h:
3510         (TestRunnerQt):
3511
3512 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3513
3514         Update the link on build.webkit.org to refer to perf.webkit.org
3515         https://bugs.webkit.org/show_bug.cgi?id=112416
3516
3517         Reviewed by Philip Rogers.
3518
3519         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3520
3521         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3522
3523 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3524
3525         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3526         https://bugs.webkit.org/show_bug.cgi?id=112394
3527
3528         Reviewed by Philippe Normand.
3529
3530         * GtkLauncher/main.c:
3531         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3532
3533 2013-03-14  Andreas Kling  <akling@apple.com>
3534
3535         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3536         <http://webkit.org/b/111815>
3537         <rdar://problem/13380145>
3538
3539         Reviewed by Anders Carlsson.
3540
3541         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3542         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3543         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3544
3545         * WebKitTestRunner/PlatformWebView.h:
3546         (PlatformWebView):
3547         * WebKitTestRunner/TestController.cpp:
3548         (WTR::TestController::createOtherPage):
3549         (WTR::TestController::createWebViewWithOptions):
3550         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3551         (WTR::PlatformWebView::didInitializeClients):
3552
3553 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3554
3555         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3556         https://bugs.webkit.org/show_bug.cgi?id=112122
3557
3558         Reviewed by Kenneth Rohde Christiansen.
3559
3560         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3561
3562         * MiniBrowser/efl/main.c:
3563         (_Browser_Window):
3564         (search_box_show):
3565         (search_box_hide):
3566         (on_key_down):
3567         (on_url_changed):
3568         (on_search_field_aborted):
3569         (on_search_field_activated):
3570         (on_search_field_clicked):
3571         (on_search_backward_button_clicked):
3572         (on_search_forward_button_clicked):
3573         (window_create):
3574
3575 2013-03-14  Julie Parent  <jparent@chromium.org>
3576
3577         Cleanup: Remove g_resourceLoader.
3578         https://bugs.webkit.org/show_bug.cgi?id=112305
3579
3580         Reviewed by Dirk Pranke.
3581         
3582         Removing another global.
3583         
3584         Now, each dashboard creates its own loader, rather than having
3585         a general global one.
3586         
3587         Remove usage of g_resourceLoader.isLoadingComplete from 
3588         handleLocationChange by ensuring that handleLocationChange is
3589         never called before the loader is done.  It was called in two
3590         places before: 1 was from the callback when the loader is done,
3591         so that was obviously true, and the other was from onhashchange,
3592         where it would just return rather than running.  Instead, lets
3593         only register the onhashchange handler once the loader is
3594         setup, so the check is no longer necessary.
3595         
3596         Remove isLoadingComplete since it is now unused.
3597         
3598         Callback for loader is now initializeHistory, rather than just
3599         handleLocationChange which will set up the hashchange handler now.
3600         This will all eventually be moving to a new History object.
3601
3602         * TestResultServer/static-dashboards/aggregate_results.html:
3603         * TestResultServer/static-dashboards/dashboard_base.js:
3604         (handleLocationChange):
3605         (intializeHistory):
3606         (decompressResults):
3607         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3608         (generatePage):
3609         * TestResultServer/static-dashboards/loader.js:
3610         (.):
3611         * TestResultServer/static-dashboards/loader_unittests.js:
3612         * TestResultServer/static-dashboards/timeline_explorer.html:
3613         * TestResultServer/static-dashboards/treemap.html:
3614
3615 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3616
3617         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3618         https://bugs.webkit.org/show_bug.cgi?id=109404
3619
3620         Reviewed by Tony Chang.
3621
3622         Removes all the code related to smartInsertDeleteEnabled and
3623         selectTrailingWhitespaceEnabled settings as they will be managed from
3624         internals from now on.
3625
3626         * DumpRenderTree/TestRunner.cpp:
3627         (TestRunner::staticFunctions):
3628         * DumpRenderTree/TestRunner.h:
3629         (TestRunner):
3630         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3631         (WebKit):
3632         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3633         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3634         (DumpRenderTree):
3635         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3636         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3637         (WebTestRunner::WebTestProxy::didStopLoading):
3638         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3639         (WebTestRunner::TestRunner::TestRunner):
3640         (WebTestRunner::TestRunner::reset):
3641         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3642         (TestRunner):
3643         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3644         (WebTestRunner::WebPreferences::applyTo): Set default values for
3645         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3646         Chromium DRT default values are different from Chromium browser.
3647         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3648         * DumpRenderTree/chromium/WebViewHost.cpp:
3649         * DumpRenderTree/chromium/WebViewHost.h:
3650         (WebViewHost):
3651         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3652         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3653         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3654         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3655         (resetDefaultsToConsistentValues):
3656         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3657         * DumpRenderTree/mac/DumpRenderTree.mm:
3658         (resetWebViewToConsistentStateBeforeTesting):
3659         * DumpRenderTree/mac/TestRunnerMac.mm:
3660         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3661         (WebCore::WebPage::resetSettings):
3662         * DumpRenderTree/qt/TestRunnerQt.cpp:
3663         * DumpRenderTree/qt/TestRunnerQt.h:
3664         (TestRunnerQt):
3665         * DumpRenderTree/win/DumpRenderTree.cpp:
3666         (resetWebViewToConsistentStateBeforeTesting):
3667         * DumpRenderTree/win/TestRunnerWin.cpp:
3668         * DumpRenderTree/wx/TestRunnerWx.cpp:
3669
3670 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3671
3672         [Qt] Disable DRT on Windows
3673
3674         Reviewed by Jocelyn Turcotte.
3675
3676         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3677
3678         * qmake/mkspecs/features/configure.prf:
3679
3680 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3681
3682         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
3683         https://bugs.webkit.org/show_bug.cgi?id=110728
3684
3685         Reviewed by Gyuyoung Kim.
3686
3687         Use the page group to create the view object.
3688
3689         * MiniBrowser/efl/main.c:
3690         (window_create):
3691
3692 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3693
3694         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
3695
3696         Reviewed by Tor Arne Vestbø.
3697
3698         The mock versions of these web facing features should be instantiated when
3699         running in DumpRenderTree only. In order for them to work, no extra Qt modules
3700         such as QtLocation are actually needed.
3701
3702         This patch decouples enabling device orientation/motion and geolocation from
3703         the underlying Qt modules and makes them available in developer builds
3704         (!production_build) and backed by mock backends when running in drt.
3705
3706         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
3707         developers the web facing features are always enabled (although requests will
3708         time out) and the mock backends are enabled inside DRT, allowing for the layout
3709         tests to run with less dependencies.
3710
3711         In addition this also enables the mock device motion client, which was
3712         previously never instantiated.
3713
3714         * qmake/mkspecs/features/features.prf:
3715
3716 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3717
3718         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
3719         https://bugs.webkit.org/show_bug.cgi?id=112340
3720
3721         Reviewed by Simon Hausmann.
3722
3723         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3724         (DumpRenderTree::dump):
3725             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
3726         (DumpRenderTree::dumpApplicationCacheQuota):
3727         * DumpRenderTree/qt/TestRunnerQt.cpp:
3728         (TestRunnerQt::reset):
3729         * DumpRenderTree/qt/TestRunnerQt.h:
3730         (TestRunnerQt):
3731
3732 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3733
3734         [Qt] Port DRT to use TestRunner::dumpAsText()
3735         https://bugs.webkit.org/show_bug.cgi?id=112260
3736
3737         Reviewed by Benjamin Poulain.
3738
3739         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3740         (WebCore::DumpRenderTree::open):
3741         (WebCore::methodNameStringForFailedTest):
3742             Change parameter from type TestRunnerQt* to TestRunner*.
3743         (WebCore::DumpRenderTree::dump):
3744             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3745             Instead we should rely on TestRunner::generatePixelResults().
3746         * DumpRenderTree/qt/TestRunnerQt.cpp:
3747         (TestRunnerQt::reset):
3748         * DumpRenderTree/qt/TestRunnerQt.h:
3749         (TestRunnerQt):
3750
3751 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3752
3753         Implement FontLoader interface
3754         https://bugs.webkit.org/show_bug.cgi?id=98395
3755
3756         Reviewed by Eric Seidel.
3757
3758         Enable FontLoadEvents runtime flag for TestShell.
3759
3760         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3761         (WebTestRunner::TestInterfaces::TestInterfaces):
3762
3763 2013-03-13  Julie Parent  <jparent@chromium.org>
3764
3765         CLeanup: remove unnecessary call to parseParameters.
3766         https://bugs.webkit.org/show_bug.cgi?id=112309
3767
3768         Reviewed by Ojan Vafai.
3769         
3770         We call parseCrossDashboardParameters when the dashboard initially
3771         loads to set the state required for loadBuildersList, and then we
3772         call it again once we are fully done with loading, so there is no
3773         reason to call it in the middle of the loading process here.
3774
3775         * TestResultServer/static-dashboards/loader.js:
3776         (.):
3777
3778 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3779
3780         Unreviewed. Now I'm a reviewer :)
3781
3782         * Scripts/webkitpy/common/config/committers.py:
3783
3784 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3785
3786         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3787         https://bugs.webkit.org/show_bug.cgi?id=112277
3788
3789         Reviewed by Adam Barth.
3790
3791         * Scripts/webkitperl/FeatureList.pm:
3792         * qmake/mkspecs/features/features.pri:
3793
3794 2013-03-13  Adam Barth  <abarth@webkit.org>
3795
3796         run-perf-tests should support content_shell
3797         https://bugs.webkit.org/show_bug.cgi?id=112291
3798
3799         Reviewed by Eric Seidel.
3800
3801         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3802         (PerfTestsRunner._parse_args):
3803
3804 2013-03-13  Oliver Hunt  <oliver@apple.com>
3805
3806         Simplify Checked<> multiplication
3807         https://bugs.webkit.org/show_bug.cgi?id=112286
3808
3809         Reviewed by James Robinson.
3810
3811         Add tests for multiplication by zero and max to ensure we don't
3812         mess them up should we ever make changes to Checked<> in future.
3813
3814         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3815         (TestWebKitAPI):
3816
3817 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3818
3819         [Qt] Unreviewed prospective Windows build fix
3820
3821         Do the usual thing, include the moc generated code in the .cpp file instead
3822         of compiling it standalone, to ensure that config.h is included, too, and
3823         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3824
3825         * DumpRenderTree/qt/EventSenderQt.cpp:
3826
3827 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3828
3829         [Qt] Port TestRunner::findString to shared interface
3830         https://bugs.webkit.org/show_bug.cgi?id=112147
3831
3832         Reviewed by Jocelyn Turcotte.
3833
3834         This patch also removes DumpRenderTree and some other helper classes from
3835         the WebCore namespace, to which they do not really belong.
3836
3837         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3838         (main):
3839         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3840         (DumpRenderTree::DumpRenderTree):
3841         (DumpRenderTree::~DumpRenderTree):
3842         (DumpRenderTree::instance):
3843         (DumpRenderTree::setShouldTimeout):
3844         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3845         (DumpRenderTree):
3846         * DumpRenderTree/qt/EventSenderQt.cpp:
3847         (EventSender::contextClick):
3848         (EventSender::sendEvent):
3849         (EventSender::postEvent):
3850         * DumpRenderTree/qt/EventSenderQt.h:
3851         (EventSender::isGraphicsBased):
3852         * DumpRenderTree/qt/TestRunnerQt.cpp:
3853         (TestRunnerQt::TestRunnerQt):
3854         (TestRunner::findString):
3855         (TestRunnerQt::setMockDeviceOrientation):
3856         (TestRunnerQt::setGeolocationPermission):
3857         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3858         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3859         (TestRunnerQt::setMockGeolocationPosition):
3860         * DumpRenderTree/qt/TestRunnerQt.h:
3861         (TestRunnerQt):
3862
3863 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3864
3865         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3866         https://bugs.webkit.org/show_bug.cgi?id=112129
3867
3868         Reviewed by Adam Barth.
3869
3870         Following Chromium
3871         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3872         this is being renamed to better explain what it does.
3873
3874         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3875
3876 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3877
3878         [Qt] Unreviewed trivial typo fix
3879
3880         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3881         TextRunner.h. Thanks Zeno :)
3882
3883 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3884
3885         [Qt] Prepare DRT for transition to shared TestRunner interface
3886         https://bugs.webkit.org/show_bug.cgi?id=112144
3887
3888         Reviewed by Benjamin Poulain.
3889
3890         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3891         the JSC C API based one.
3892
3893         This is impplemented by instantiating the QObject based testRunner in
3894         the global object, then instantiating the JSC C based TestRunner
3895         separately and placing it "behind" the QObject based testRunner through
3896         injection of the individual functions through proxies. (prototype
3897         chaining doesn't work due to the this object and Function.prototype.bind
3898         doesn't work due to the native function)
3899
3900         This allows for porting over method by method by removing the method
3901         from the QObject TestRunnerQt and implementing it in the JSC C based
3902         TestRunner.
3903
3904         In order for this to link and run dummy implementations of all the
3905         necessary TestRunner functions are provided.
3906
3907         * DumpRenderTree/qt/DumpRenderTree.pro:
3908         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3909         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3910         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3911         (WebCore::DumpRenderTree::initJSObjects):
3912         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3913         (DumpRenderTree):
3914         * DumpRenderTree/qt/TestRunnerQt.cpp:
3915         (TestRunner::~TestRunner):
3916         (TestRunner::addDisallowedURL):
3917         (TestRunner::queueLoad):
3918         (TestRunner::removeAllVisitedLinks):
3919         (TestRunner::setAcceptsEditing):
3920         (TestRunner::simulateLegacyWebNotificationClick):
3921         (TestRunner::setWindowIsKey):
3922         (TestRunner::setAlwaysAcceptCookies):
3923         (TestRunner::addOriginAccessWhitelistEntry):
3924         (TestRunner::setWebViewEditable):
3925         (TestRunner::clearAllApplicationCaches):
3926         (TestRunner::setTextDirection):
3927         (TestRunner::notifyDone):
3928         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3929         (TestRunner::overridePreference):
3930         (TestRunner::pathToLocalResource):
3931         (TestRunner::removeAllWebNotificationPermissions):
3932         (TestRunner::simulateWebNotificationClick):
3933         (TestRunner::closeIdleLocalStorageDatabases):
3934         (TestRunner::focusWebView):
3935         (TestRunner::setBackingScaleFactor):
3936         (TestRunner::removeChromeInputField):
3937         (TestRunner::addChromeInputField):
3938         (TestRunner::originsWithLocalStorage):
3939         (TestRunner::deleteAllLocalStorage):
3940         (TestRunner::deleteLocalStorageForOrigin):
3941         (TestRunner::observeStorageTrackerNotifications):
3942         (TestRunner::syncLocalStorage):
3943         (TestRunner::windowCount):
3944         (TestRunner::setWaitToDump):
3945         (TestRunner::waitForPolicyDelegate):
3946         (TestRunner::webHistoryItemCount):
3947         (TestRunner::showWebInspector):
3948         (TestRunner::closeWebInspector):
3949         (TestRunner::evaluateInWebInspector):
3950         (TestRunner::setSerializeHTTPLoads):
3951         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3952         (TestRunner::setCustomPolicyDelegate):
3953         (TestRunner::setDatabaseQuota):
3954         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3955         (TestRunner::resetPageVisibility):
3956         (TestRunner::keepWebHistory):
3957         (TestRunner::goBack):
3958         (TestRunner::originsWithApplicationCache):
3959         (TestRunner::applicationCacheDiskUsageForOrigin):
3960         (TestRunner::display):
3961         (TestRunner::dispatchPendingLoadRequests):
3962         (TestRunner::clearPersistentUserStyleSheet):
3963         (TestRunner::callShouldCloseOnWebView):
3964         (TestRunner::copyDecodedHostName):
3965         (TestRunner::clearBackForwardList):
3966         (TestRunner::clearAllDatabases):
3967         (TestRunner::clearApplicationCacheForOrigin):
3968         (TestRunner::apiTestGoToCurrentBackForwardItem):
3969         (TestRunner::authenticateSession):
3970         (TestRunner::abortModal):
3971         (TestRunner::setStorageDatabaseIdleInterval):
3972         (TestRunner::setAsynchronousSpellCheckingEnabled):
3973         (TestRunner::setXSSAuditorEnabled):
3974         (TestRunner::setSpatialNavigationEnabled):
3975         (TestRunner::setScrollbarPolicy):
3976         (TestRunner::setJavaScriptCanAccessClipboard):
3977         (TestRunner::setAutomaticLinkDetectionEnabled):
3978         (TestRunner::setUserStyleSheetEnabled):
3979         (TestRunner::setUserStyleSheetLocation):
3980         (TestRunner::setUseDashboardCompatibilityMode):
3981         (TestRunner::setTabKeyCyclesThroughElements):
3982         (TestRunner::setSmartInsertDeleteEnabled):
3983         (TestRunner::setSelectTrailingWhitespaceEnabled):
3984         (TestRunner::setPrivateBrowsingEnabled):
3985         (TestRunner::setPluginsEnabled):
3986         (TestRunner::setPopupBlockingEnabled):
3987         (TestRunner::setMockSpeechInputDumpRect):
3988         (TestRunner::setPersistentUserStyleSheetLocation):
3989         (TestRunner::setMockGeolocationPosition):
3990         (TestRunner::setMockGeolocationPositionUnavailableError):
3991         (TestRunner::setMockDeviceOrientation):
3992         (TestRunner::setMainFrameIsFirstResponder):
3993         (TestRunner::setIconDatabaseEnabled):
3994         (TestRunner::setGeolocationPermission):
3995         (TestRunner::setDefersLoading):
3996         (TestRunner::setCacheModel):
3997         (TestRunner::setAuthorAndUserStylesEnabled):
3998         (TestRunner::setAllowFileAccessFromFileURLs):
3999         (TestRunner::setAppCacheMaximumSize):
4000         (TestRunner::setAllowUniversalAccessFromFileURLs):
4001         (TestRunner::setApplicationCacheOriginQuota):
4002         (TestRunner::denyWebNotificationPermission):
4003         (TestRunner::grantWebNotificationPermission):
4004         (TestRunner::setValueForUser):
4005         (TestRunner::setViewModeMediaFeature):
4006         (TestRunner::setPageVisibility):
4007         (TestRunner::addMockSpeechInputResult):
4008         (TestRunner::removeOriginAccessWhitelistEntry):
4009         (TestRunner::addUserScript):
4010         (TestRunner::isCommandEnabled):
4011         (TestRunner::evaluateScriptInIsolatedWorld):
4012         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
4013         (TestRunner::copyEncodedHostName):
4014         (TestRunner::addUserStyleSheet):
4015         (TestRunner::findString):
4016         (TestRunner::execCommand):
4017         (TestRunner::localStorageDiskUsageForOrigin):
4018
4019 2013-03-12  Julie Parent  <jparent@chromium.org>
4020
4021         Cleanup: Move flatten-trie to loader.
4022         https://bugs.webkit.org/show_bug.cgi?id=112196
4023
4024         Reviewed by Dirk Pranke.
4025
4026         flatten-trie is used only by the loader, so move it there and make it
4027         private, rather than global in dashbaord_base. Moved the corresponding
4028         unit test from flakiness_dashboard_unittests to loader_unittests.
4029         
4030         * TestResultServer/static-dashboards/dashboard_base.js:
4031         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4032         * TestResultServer/static-dashboards/loader.js:
4033         (.):
4034         * TestResultServer/static-dashboards/loader_unittests.js:
4035
4036 2013-03-12  Oliver Hunt  <oliver@apple.com>
4037
4038         Unbreak api tests
4039
4040         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4041         (TestWebKitAPI):
4042
4043 2013-03-12  Tim Horton  <timothy_horton@apple.com>
4044
4045         Unreviewed, disabling tests for Win EWS.
4046
4047         win-ews obviously cannot keep up with running tests, it's >300 behind.
4048         Probably doesn't help that its (likely) running tests serially.
4049
4050         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4051         (WinEWS):
4052
4053 2013-03-12  Tim Horton  <timothy_horton@apple.com>
4054
4055         Add a --build-directory argument to delete-stale-build-files
4056         https://bugs.webkit.org/show_bug.cgi?id=112198
4057
4058         Reviewed by Ryosuke Niwa.
4059
4060         * BuildSlaveSupport/delete-stale-build-files:
4061         (main): Add --build-directory argument.
4062
4063 2013-03-12  Oliver Hunt  <oliver@apple.com>
4064
4065         Appease MSVC
4066
4067         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4068         (TestWebKitAPI):
4069
4070 2013-03-12  Oliver Hunt  <oliver@apple.com>
4071
4072         Add more Checked<> tests
4073         https://bugs.webkit.org/show_bug.cgi?id=112190
4074
4075         Reviewed by Geoffrey Garen.
4076
4077         Tests!
4078
4079         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4080         (TestWebKitAPI):
4081
4082 2013-03-12  Julie Parent  <jparent@chromium.org>
4083
4084         Cleanup: Move loading complete function into callback, rather than global.
4085         https://bugs.webkit.org/show_bug.cgi?id=112167
4086
4087         Reviewed by Dirk Pranke.
4088         
4089         Stop calling global functions, pass in proper handler to Loader
4090         constructor. Note that the callback is optional, as tests, and
4091         some potential dashboards, do not need one.
4092
4093         * TestResultServer/static-dashboards/dashboard_base.js:
4094         * TestResultServer/static-dashboards/loader.js:
4095         (.):
4096         * TestResultServer/static-dashboards/loader_unittests.js:
4097
4098 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4099
4100         [EFL][WK2] Add popup menu support to MiniBrowser
4101         https://bugs.webkit.org/show_bug.cgi?id=108934
4102
4103         Reviewed by Kenneth Rohde Christiansen.
4104
4105         Implement popup menu support in MiniBrowser by handling popup_menu_show
4106         and popup_menu_hide smart functions on the view and using the Ewk popup
4107         menu API.
4108
4109         * MiniBrowser/efl/main.c:
4110         (_Browser_Window):
4111         (on_popup_menu_discarded):
4112         (on_popup_menu_item_clicked):
4113         (popup_menu_populate):
4114         (on_popup_menu_show):
4115         (on_popup_menu_hide):
4116         (window_create): Use calloc() instead of malloc() to allocate memory for
4117         Browser_Window. This makes sure all the structs members are initialized
4118         to 0 (such as the new elm_popup_menu pointer).
4119
4120 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
4121
4122         [GTK] Set up the libPlatformGtk.la library
4123         https://bugs.webkit.org/show_bug.cgi?id=111738
4124
4125         Reviewed by Martin Robinson.
4126
4127         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
4128         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
4129         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
4130
4131 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
4132
4133         [GTK] Enable Web Audio in development builds
4134         https://bugs.webkit.org/show_bug.cgi?id=111831
4135
4136         Reviewed by Philippe Normand.
4137
4138         Web Audio is already quite well supported on the GTK port but still has a few issues
4139         that must be addressed before it is enabled by default. Despite that it should be enabled
4140         in development builds just so we are up-to-date with future feature infrastructure changes.
4141         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
4142         that's an obvious goal before enabling the feature in release builds.
4143
4144         * Scripts/webkitperl/FeatureList.pm:
4145
4146 2013-03-11  Andreas Kling  <akling@apple.com>
4147
4148         [Mac][WK1] Add support for alert() in MiniBrowser.
4149         <http://webkit.org/b/112090>
4150
4151         Reviewed by Anders Carlsson.
4152
4153         * MiniBrowser/mac/WK1BrowserWindowController.m:
4154         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
4155
4156 2013-03-11  Julie Parent  <jparent@chromium.org>
4157
4158         Dashboard cleanup: Create ui.Errors
4159         https://bugs.webkit.org/show_bug.cgi?id=111785
4160
4161         Reviewed by Ojan Vafai.
4162         
4163         Create ui.Errors for handling errors the dashboards
4164         encounter. Loader now has a Error object that it can add to,
4165         and individual dashboards can show errors when desired.
4166         Currently, only flakiness_db shows errors, but this is 
4167         generic and there is no reason why other dbs wouldn't want to
4168         show errors.
4169
4170         * TestResultServer/static-dashboards/dashboard_base.js:
4171         (resourceLoadingComplete):
4172         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4173         (generatePage):
4174         * TestResultServer/static-dashboards/loader.js:
4175         (.):
4176         * TestResultServer/static-dashboards/ui.js:
4177         (.):
4178
4179 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
4180
4181         Some StringHasher tests are broken because of missing null termination
4182         https://bugs.webkit.org/show_bug.cgi?id=111284
4183
4184         Reviewed by Darin Adler.
4185
4186         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
4187         (TestWebKitAPI): Added null termination since C strings are null-terminated.
4188         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
4189         the bug caught by it is now fixed.
4190
4191 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
4192
4193         Unreviewed, rolling out r145200.
4194         http://trac.webkit.org/changeset/145200
4195         https://bugs.webkit.org/show_bug.cgi?id=112063
4196
4197         Broke a couple of unit tests (Requested by zdobersek on
4198         #webkit).
4199
4200         * Scripts/webkitperl/FeatureList.pm:
4201
4202 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
4203
4204         [GTK] WebKit2-only build fails
4205         https://bugs.webkit.org/show_bug.cgi?id=112033
4206
4207         Reviewed by Gustavo Noronha Silva.
4208
4209         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
4210         generic part, WebKit1-specific part and WebKit2-specific part.
4211         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
4212         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
4213         directly.
4214
4215 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
4216
4217         Adding myself to the committers list.
4218
4219         Unreviewed.
4220
4221         * Scripts/webkitpy/common/config/committers.py:
4222
4223 2013-03-11  Jeff Rogers  <jrogers@rim.com>
4224
4225         [BlackBerry] Disable MathML support
4226         https://bugs.webkit.org/show_bug.cgi?id=111929
4227
4228         Reviewed by Rob Buis.
4229
4230         * Scripts/webkitperl/FeatureList.pm:
4231
4232 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4233
4234         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
4235         https://bugs.webkit.org/show_bug.cgi?id=111970
4236
4237         Reviewed by Chris Fleizach.
4238
4239         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
4240         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
4241         undefined symbol.
4242
4243         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4244         (WTR::AccessibilityUIElement::supportedActions):
4245         (WTR):
4246
4247 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
4248
4249         [chromium] Android apk targets should depend directly on Java library targets
4250         https://bugs.webkit.org/show_bug.cgi?id=111746
4251
4252         Reviewed by Eric Seidel.
4253
4254         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4255         Make DumpRenderTree_apk depend directly on base_java and net_java.
4256         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
4257         Make TestWebKitAPI_apk depend directly on base_java.
4258
4259 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
4260
4261         [chromium] remove obsolete user gesture methods from WebFrame
4262         https://bugs.webkit.org/show_bug.cgi?id=111696
4263
4264         Reviewed by Adam Barth.
4265
4266         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
4267         (WebTestRunner::TestPlugin::handleInputEvent):
4268         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4269
4270 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
4271
4272         Unreviewed, add myself to commiters.py.
4273
4274         * Scripts/webkitpy/common/config/committers.py:
4275
4276 2013-03-08  Julie Parent  <jparent@chromium.org>
4277
4278         Cleanup: Remove dead code.
4279         https://bugs.webkit.org/show_bug.cgi?id=111900
4280
4281         Reviewed by Dirk Pranke.
4282         
4283         Treemap overrides a global function that used to be in 
4284         dashboard_base, but was removed months ago in
4285         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
4286         no caller. 
4287
4288         * TestResultServer/static-dashboards/treemap.html:
4289
4290 2013-03-08  Harald Alvestrand  <hta@chromium.org>
4291
4292         Implemented new API for RTCStatsReport object.
4293