Make navigator.mediaDevices SecureContext
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-15  Youenn Fablet  <youenn@apple.com>
2
3         Make navigator.mediaDevices SecureContext
4         https://bugs.webkit.org/show_bug.cgi?id=194666
5
6         Reviewed by Eric Carlson.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
9         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
10         (TEST_F):
11
12 2019-02-15  Brian Burg  <bburg@apple.com>
13
14         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
15         https://bugs.webkit.org/show_bug.cgi?id=194411
16         <rdar://problem/47787614>
17
18         Reviewed by Joseph Pecoraro.
19
20         Remove unnecessary soft linking macro usage.
21
22         * DumpRenderTree/mac/TestRunnerMac.mm:
23         (TestRunner::inspectorTestStubURL):
24         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
25         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
26         (WTR::TestRunner::inspectorTestStubURL):
27
28 2019-02-15  Commit Queue  <commit-queue@webkit.org>
29
30         Unreviewed, rolling out r241559 and r241566.
31         https://bugs.webkit.org/show_bug.cgi?id=194710
32
33         Causes layout test crashes under GuardMalloc (Requested by
34         ryanhaddad on #webkit).
35
36         Reverted changesets:
37
38         "[WTF] Add environment variable helpers"
39         https://bugs.webkit.org/show_bug.cgi?id=192405
40         https://trac.webkit.org/changeset/241559
41
42         "Unreviewed build fix for WinCairo Debug after r241559."
43         https://trac.webkit.org/changeset/241566
44
45 2019-02-15  Zalan Bujtas  <zalan@apple.com>
46
47         [LFC] Out-of-flow box is never a float box
48         https://bugs.webkit.org/show_bug.cgi?id=194704
49
50         Reviewed by Antti Koivisto.
51
52         * LayoutReloaded/misc/LFC-passing-tests.txt:
53
54 2019-02-10  Darin Adler  <darin@apple.com>
55
56         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
57         https://bugs.webkit.org/show_bug.cgi?id=194487
58
59         Reviewed by Daniel Bates.
60
61         * DumpRenderTree/win/DumpRenderTree.cpp:
62         (applicationId): Use makeString instead of String::format.
63         (main): Ditto.
64         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
65         (TestWebKitAPI::Util::createURLForResource): Ditto.
66         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
67         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
68
69         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
70         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
71         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
72         (WTR::createStringWithAttributes): Use appendLiteral.
73         (WTR::AccessibilityUIElement::helpText const): Ditto.
74         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
75         directly instead of using String::format.
76         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
77         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
78
79 2019-02-15  Truitt Savell  <tsavell@apple.com>
80
81         Unreviewed, rolling out r241564.
82
83         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
84
85         Reverted changeset:
86
87         "[Mac] WebInspectorUI.framework does not need to be soft-
88         linked anymore"
89         https://bugs.webkit.org/show_bug.cgi?id=194411
90         https://trac.webkit.org/changeset/241564
91
92 2019-02-15  Saam barati  <sbarati@apple.com>
93
94         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
95         https://bugs.webkit.org/show_bug.cgi?id=194036
96
97         Reviewed by Yusuke Suzuki.
98
99         * Scripts/run-jsc-stress-tests:
100
101 2019-02-14  Tim Horton  <timothy_horton@apple.com>
102
103         Fix the build.
104
105         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
106         (WTR::UIScriptController::drawSquareInEditableImage):
107         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
108         (TestWebKitAPI::drawSquareInEditableImage):
109
110 2019-02-14  Tim Horton  <timothy_horton@apple.com>
111
112         Fix the build.
113
114         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
115         (WTR::UIScriptController::drawSquareInEditableImage):
116         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
117         (TestWebKitAPI::drawSquareInEditableImage):
118
119 2019-02-14  Brian Burg  <bburg@apple.com>
120
121         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
122         https://bugs.webkit.org/show_bug.cgi?id=194411
123         <rdar://problem/47787614>
124
125         Reviewed by Joseph Pecoraro.
126
127         Remove unnecessary soft linking macro usage.
128
129         * DumpRenderTree/mac/TestRunnerMac.mm:
130         (TestRunner::inspectorTestStubURL):
131         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
132         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
133         (WTR::TestRunner::inspectorTestStubURL):
134
135 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
136
137         [ews-app] status bubble should fetch builder name info from BuilderMapping table
138         https://bugs.webkit.org/show_bug.cgi?id=194599
139
140         Reviewed by Lucas Forschler.
141
142         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
143         (StatusBubble._build_bubble):
144
145 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
146
147         [ews-app] Set Foreign Key in Django build model
148         https://bugs.webkit.org/show_bug.cgi?id=194667
149
150         Reviewed by Lucas Forschler.
151
152         * BuildSlaveSupport/ews-app/ews/models/build.py:
153         (Build):
154
155 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
156
157         [WTF] Add environment variable helpers
158         https://bugs.webkit.org/show_bug.cgi?id=192405
159
160         Reviewed by Michael Catanzaro.
161
162         * DumpRenderTree/mac/DumpRenderTree.mm:
163         (libraryPathForDumpRenderTree):
164         * DumpRenderTree/win/DumpRenderTree.cpp:
165         (libraryPathForDumpRenderTree):
166         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
167         (setUpIOSLayoutTestCommunication):
168         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
169         (TestWebKitAPI::strip):
170         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
171         (beforeAll):
172         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
173         (main):
174         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
175         (WebKitTestBus::run):
176         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
177         (WTR::getOutputDir):
178         (WTR::initializeFontConfigSetting):
179         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
180         (WTR::InjectedBundle::platformInitialize):
181         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
182         (WTR::topLevelPath):
183         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
184         (WTR::topLevelPath):
185         (WTR::getOutputDir):
186         (WTR::activateFonts):
187         * WebKitTestRunner/TestController.cpp:
188         (WTR::TestController::libraryPathForTesting):
189         (WTR::TestController::generateContextConfiguration const):
190         (WTR::TestController::generatePageConfiguration):
191         (WTR::TestController::decideDestinationWithSuggestedFilename):
192         (WTR::TestController::platformAdjustContext):
193         * WebKitTestRunner/TestController.h:
194         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
195         (WTR::TestController::cocoaPlatformInitialize):
196         (WTR::TestController::platformAdjustContext):
197         * WebKitTestRunner/gtk/main.cpp:
198         (main):
199         * WebKitTestRunner/mac/TestControllerMac.mm:
200         (WTR::TestController::configureContentExtensionForTest):
201         * WebKitTestRunner/wpe/main.cpp:
202         (main):
203         Utilize WTF::Environment where possible.
204
205 2019-02-14  Chris Dumez  <cdumez@apple.com>
206
207         [PSON] Introduce a WebContent Process cache
208         https://bugs.webkit.org/show_bug.cgi?id=194594
209         <rdar://problem/46793397>
210
211         Reviewed by Geoff Garen.
212
213         Update API tests to turn on the WebContent Process cache.
214
215         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
216
217 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
218
219         Unreviewed, build fix after r241480
220
221         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
222         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
223         (-[DragAndDropSimulator initWithWebView:]):
224
225 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
226
227         AX: ARIA Reflection was disabled in error
228         https://bugs.webkit.org/show_bug.cgi?id=194647
229         <rdar://problem/48068336>
230
231         Reviewed by Ryosuke Niwa.
232
233         Remove test override now that this feature should be enabled by default.
234
235         * WebKitTestRunner/TestController.cpp:
236         (WTR::TestController::resetPreferencesToConsistentValues):
237
238 2019-02-14  Commit Queue  <commit-queue@webkit.org>
239
240         Unreviewed, rolling out r241486.
241         https://bugs.webkit.org/show_bug.cgi?id=194655
242
243         causing API failures in builds (Requested by ShawnRoberts on
244         #webkit).
245
246         Reverted changeset:
247
248         "[Cocoa] Media elements will restart network buffering just
249         before suspending"
250         https://bugs.webkit.org/show_bug.cgi?id=193691
251         https://trac.webkit.org/changeset/241486
252
253 2019-02-14  Zalan Bujtas  <zalan@apple.com>
254
255         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
256         https://bugs.webkit.org/show_bug.cgi?id=194622
257
258         Reviewed by Antti Koivisto.
259
260         * LayoutReloaded/misc/LFC-passing-tests.txt:
261
262 2019-02-14  Zalan Bujtas  <zalan@apple.com>
263
264         [LFC] Shrink-to-fit-width should be constrained by min/max width
265         https://bugs.webkit.org/show_bug.cgi?id=194653
266
267         Reviewed by Antti Koivisto.
268
269         * LayoutReloaded/misc/LFC-passing-tests.txt:
270
271 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
272
273         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
274         https://bugs.webkit.org/show_bug.cgi?id=194641
275
276         Reviewed by Geoffrey Garen.
277
278         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
279         so that the test would fail without this fix.
280
281         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
282         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
283
284 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
285
286         [ews-app] Change log level for a log statement
287
288         Unreviewed minor fix.
289
290         * BuildSlaveSupport/ews-app/ews/models/patch.py:
291         (Patch.save_patch):
292
293 2019-02-13  Jer Noble  <jer.noble@apple.com>
294
295         [Cocoa] Media elements will restart network buffering just before suspending
296         https://bugs.webkit.org/show_bug.cgi?id=193691
297
298         Reviewed by Eric Carlson.
299
300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
301         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
302         (TEST):
303
304 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
305
306         [ews-app] Fetch builder id to name mapping
307         https://bugs.webkit.org/show_bug.cgi?id=194355
308
309         Reviewed by Lucas Forschler.
310
311         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
312         (Buildbot.get_builder_id_to_name_mapping):
313         (Buildbot._get_display_name_from_builder_name):
314
315 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
316
317         Further restricting webarchive loads
318         https://bugs.webkit.org/show_bug.cgi?id=194567
319         <rdar://problem/47610130>
320
321         Reviewed by Youenn Fablet.
322
323         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
324         navigations on drop.
325
326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
327         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
328         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
329         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
330         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
331         (TestWebKitAPI::TEST):
332         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
333         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
334         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
335         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
336         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
337         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
338         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
339
340 2019-02-13  John Wilander  <wilander@apple.com>
341
342         Store Ad Click Attribution requests in the network process
343         https://bugs.webkit.org/show_bug.cgi?id=194510
344         <rdar://problem/47650118>
345
346         Reviewed by Alex Christensen and Daniel Bates.
347
348         This patch adds two TestRunner functions:
349         - dumpAdClickAttribution()
350         - clearAdClickAttribution()
351
352         They call into the network process to dump and clear Ad Click
353         Attribution state, respectively.
354
355         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
356         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
357         (WTR::TestRunner::dumpAdClickAttribution):
358         (WTR::TestRunner::clearAdClickAttribution):
359         * WebKitTestRunner/InjectedBundle/TestRunner.h:
360         * WebKitTestRunner/TestController.cpp:
361         (WTR::TestController::resetStateToConsistentValues):
362         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
363         (WTR::adClickAttributionStringResultCallback):
364         (WTR::TestController::dumpAdClickAttribution):
365         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
366         (WTR::adClickAttributionVoidCallback):
367         (WTR::TestController::clearAdClickAttribution):
368         * WebKitTestRunner/TestController.h:
369         * WebKitTestRunner/TestInvocation.cpp:
370         (WTR::TestInvocation::dumpResults):
371         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
372         (WTR::TestInvocation::dumpAdClickAttribution):
373         * WebKitTestRunner/TestInvocation.h:
374
375 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
376
377         [ews-app] Generate status-bubble
378         https://bugs.webkit.org/show_bug.cgi?id=194572
379
380         Reviewed by Lucas Forschler.
381
382         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
383         (StatusBubble._build_bubble):
384         (StatusBubble._should_show_bubble_for):
385         (StatusBubble._build_bubbles_for_patch):
386
387 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
388
389         [ews-app] Add status bubble html template
390         https://bugs.webkit.org/show_bug.cgi?id=194571
391
392         Reviewed by Lucas Forschler.
393
394         * BuildSlaveSupport/ews-app/ews/templates: Added.
395         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
396
397 2019-02-12  Chris Dumez  <cdumez@apple.com>
398
399         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
400         https://bugs.webkit.org/show_bug.cgi?id=194568
401         <rdar://problem/47944490>
402
403         Reviewed by Ryosuke Niwa.
404
405         Add API test coverage.
406
407         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
408         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
409
410 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
411
412         webkitpy: Remove bug_dummy from parsed test expectations
413         https://bugs.webkit.org/show_bug.cgi?id=194562
414         <rdar://problem/47853999>
415
416         Reviewed by Lucas Forschler.
417
418         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
419         (TestExpectationParser):
420         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
421         skipped tests.
422         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
423
424 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
425
426         [ews-app] Add method to fetch patch
427         https://bugs.webkit.org/show_bug.cgi?id=194518
428
429         Reviewed by Lucas Forschler.
430
431         * BuildSlaveSupport/ews-app/ews/models/patch.py:
432         (Patch.get_patch):
433
434 2019-02-12  Zalan Bujtas  <zalan@apple.com>
435
436         [LFC] Expand tests coverage (60 new tests -> 860)
437
438         Unreviewed test gardening (run-singly, --child-processes=1).
439
440         * LayoutReloaded/misc/LFC-passing-tests.txt:
441
442 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
443
444         Allow pages to trigger programmatic paste from script on iOS
445         https://bugs.webkit.org/show_bug.cgi?id=194271
446         <rdar://problem/47808810>
447
448         Reviewed by Tim Horton.
449
450         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
451
452         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
453         (WTR::UIScriptController::platformSetDidShowMenuCallback):
454         (WTR::UIScriptController::platformSetDidHideMenuCallback):
455         (WTR::UIScriptController::rectForMenuAction const):
456
457         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
458         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
459         for when the menu is shown or hidden.
460
461         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
462         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
463         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
464         (WTR::UIScriptController::setDidShowMenuCallback):
465         (WTR::UIScriptController::didShowMenuCallback const):
466         (WTR::UIScriptController::setDidHideMenuCallback):
467         (WTR::UIScriptController::didHideMenuCallback const):
468         (WTR::UIScriptController::platformSetDidShowMenuCallback):
469         (WTR::UIScriptController::platformSetDidHideMenuCallback):
470         (WTR::UIScriptController::rectForMenuAction const):
471         * TestRunnerShared/UIScriptContext/UIScriptController.h:
472         * WebKitTestRunner/TestController.cpp:
473         (WTR::TestController::resetPreferencesToConsistentValues):
474         (WTR::updateTestOptionsFromTestHeader):
475         * WebKitTestRunner/TestOptions.h:
476
477         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
478         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
479
480         (WTR::TestOptions::hasSameInitializationOptions const):
481         * WebKitTestRunner/UIScriptControllerCocoa.mm:
482         (WTR::UIScriptController::calendarType const):
483         (WTR::UIScriptController::platformUndoManager const):
484         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
485         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
486         (-[TestRunnerWKWebView initWithFrame:configuration:]):
487         (-[TestRunnerWKWebView dealloc]):
488         (-[TestRunnerWKWebView _didShowMenu]):
489         (-[TestRunnerWKWebView _didHideMenu]):
490
491         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
492
493         * WebKitTestRunner/ios/TestControllerIOS.mm:
494         (WTR::handleMenuWillHideNotification):
495         (WTR::handleMenuDidHideNotification):
496         (WTR::TestController::platformInitialize):
497         (WTR::TestController::platformDestroy):
498         (WTR::TestController::platformResetStateToConsistentValues):
499
500         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
501         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
502
503         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
504         (WTR::forEachViewInHierarchy):
505         (WTR::findViewInHierarchyOfType):
506
507         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
508         functions that dig through a given view's hierarchy in search of a view of a given class.
509
510         (WTR::UIScriptController::selectionStartGrabberViewRect const):
511         (WTR::UIScriptController::selectionEndGrabberViewRect const):
512         (WTR::UIScriptController::selectionCaretViewRect const):
513         (WTR::UIScriptController::selectionRangeViewRects const):
514         (WTR::UIScriptController::platformSetDidShowMenuCallback):
515         (WTR::UIScriptController::platformSetDidHideMenuCallback):
516
517         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
518
519         (WTR::UIScriptController::rectForMenuAction const):
520
521         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
522         callout bar) whose label matches the given string.
523
524         (WTR::UIScriptController::platformContentView const):
525
526         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
527         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
528         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
529
530         (WTR::UIScriptController::platformUndoManager const): Deleted.
531         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
532         (WTR::UIScriptController::platformContentView const):
533         (WTR::UIScriptController::platformUndoManager const): Deleted.
534
535 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
536
537         webkitpy: No option to only show unexpected failures in results.html for iPad
538         https://bugs.webkit.org/show_bug.cgi?id=194554
539         <rdar://problem/47922442>
540
541         Rubber-stamped by Aakash Jain.
542
543         Just because a TestExpecations file does not exist for a specific platform does not mean that
544         TestExpecations are not being used, given that platforms inherit test expectations.
545
546         * Scripts/webkitpy/port/base.py:
547         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
548         * Scripts/webkitpy/port/base_unittest.py:
549         (PortTest.test_uses_test_expectations_file):
550
551 2019-02-12  Alex Christensen  <achristensen@webkit.org>
552
553         Remove setDefersLoading infrastructure from WebKit2
554         https://bugs.webkit.org/show_bug.cgi?id=194506
555
556         Reviewed by Brady Eidson.
557
558         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
559         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
560         (WTR::TestRunner::setDefersLoading): Deleted.
561         * WebKitTestRunner/InjectedBundle/TestRunner.h:
562
563 2019-02-12  Alex Christensen  <achristensen@webkit.org>
564
565         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
566         https://bugs.webkit.org/show_bug.cgi?id=194522
567         <rdar://problem/47789393>
568
569         Reviewed by Chris Dumez.
570
571         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
572         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
573         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
574         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
575
576 2019-02-12  Andy Estes  <aestes@apple.com>
577
578         [iOSMac] Enable Parental Controls Content Filtering
579         https://bugs.webkit.org/show_bug.cgi?id=194521
580         <rdar://39732376>
581
582         Reviewed by Tim Horton.
583
584         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
585
586 2019-02-12  Zalan Bujtas  <zalan@apple.com>
587
588         [LFC][IFC] Add intrinsic width support for float boxes.
589         https://bugs.webkit.org/show_bug.cgi?id=194528
590
591         Reviewed by Antti Koivisto.
592
593         Expand tests coverage (2 new tests -> 800).
594         (This is the correct test ordering --runs-singly --child-processes=1)
595
596         * LayoutReloaded/misc/LFC-passing-tests.txt:
597
598 2019-02-12  Rob Buis  <rbuis@igalia.com>
599
600         Implement serializing in MIME type parser
601         https://bugs.webkit.org/show_bug.cgi?id=193909
602
603         Reviewed by Darin Adler.
604
605         Add various tests involving upper case, non-ASCII, control/null characters,
606         various HTTP whitespace, single quotes and an unpaired surrogate.
607
608         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
609         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
610         (TestWebKitAPI::serializeIfValid):
611         (TestWebKitAPI::TEST):
612
613 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
614
615         [Cocoa] Ask platform for generic font family mappings
616         https://bugs.webkit.org/show_bug.cgi?id=187723
617         <rdar://problem/41892438>
618
619         Reviewed by Brent Fulgham.
620
621         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
622
623         * DumpRenderTree/mac/DumpRenderTree.mm:
624         (allowedFontFamilySet):
625         * WebKitTestRunner/mac/TestControllerMac.mm:
626         (WTR::allowedFontFamilySet):
627
628 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
629
630         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
631         https://bugs.webkit.org/show_bug.cgi?id=193622
632
633         Reviewed by Michael Catanzaro.
634
635         This adds support for loading content extension rule sets from the JSON files which
636         accompany the corresponding layout test, using the C API. The Cocoa specific parts
637         of WKTR for this could be removed, but that is left for a follow-up patch with
638         cleanups.
639
640         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
641         * WebKitTestRunner/TestController.cpp:
642         (WTR::testPath): Subtract one from the length when constructing the result std::string to
643         avoid having the null-terminator copied into the result.
644         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
645         part of the preparations to run a test.
646         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
647         (WTR::contentExtensionStoreCallback): Added.
648         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
649         used for content extensions test.
650         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
651         extensions and compiling the JSON rule set for tests involving content extensions.
652         (WTR::TestController::resetContentExtensions): Removes the content extension built for
653         testing and disables content extensions.
654         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
655         resetContentExtensions().
656         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
657         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
658         configureContentExtensionForTest(), and userContentController().
659
660 2019-02-11  Daniel Bates  <dabates@apple.com>
661
662         [iOS] Mouse/Touch/Pointer events are missing modifier keys
663         https://bugs.webkit.org/show_bug.cgi?id=191446
664         <rdar://problem/45929460>
665
666         Reviewed by Tim Horton.
667
668         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
669
670         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
671         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
672         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
673         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
674         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
675         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
676         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
677         * TestRunnerShared/UIScriptContext/UIScriptController.h:
678         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
679         (WTR::arrayLength):
680         (WTR::parseModifierArray):
681         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
682         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
683         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
684         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
685
686 2019-02-11  Commit Queue  <commit-queue@webkit.org>
687
688         Unreviewed, rolling out r241272 and r241276.
689         https://bugs.webkit.org/show_bug.cgi?id=194514
690
691         Broke the Apple Internal build and the fix requires human
692         intervention :( (Requested by dydz on #webkit).
693
694         Reverted changesets:
695
696         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
697         https://bugs.webkit.org/show_bug.cgi?id=191446
698         https://trac.webkit.org/changeset/241272
699
700         "Fix internal iOS build after r241272"
701         https://bugs.webkit.org/show_bug.cgi?id=191446
702         https://trac.webkit.org/changeset/241276
703
704 2019-02-11  Truitt Savell  <tsavell@apple.com>
705
706         Unreviewed, rolling out r241269.
707
708         Caused 5 layout tests crashes on Mac WK1
709
710         Reverted changeset:
711
712         "DumpRenderTree should report unknown options"
713         https://bugs.webkit.org/show_bug.cgi?id=191303
714         https://trac.webkit.org/changeset/241269
715
716 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
717
718         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
719         https://bugs.webkit.org/show_bug.cgi?id=194313
720
721         Reviewed by Tim Horton.
722
723         Add a helper to determine whether the web view is presenting modal UI.
724
725         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
726         (WTR::UIScriptController::isPresentingModally const):
727         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
728         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
729         (WTR::UIScriptController::isPresentingModally const):
730         * TestRunnerShared/UIScriptContext/UIScriptController.h:
731         * WebKitTestRunner/UIScriptControllerCocoa.mm:
732         (WTR::UIScriptController::calendarType const): Deleted.
733         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
734         (WTR::UIScriptController::isPresentingModally const):
735         (WTR::UIScriptController::calendarType const):
736         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
737         (WTR::UIScriptController::calendarType const):
738
739 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
740
741         GCHeapInspector: Show the retained sizes in more places
742         https://bugs.webkit.org/show_bug.cgi?id=194464
743
744         Reviewed by Simon Fraser.
745
746         * GCHeapInspector/gc-heap-inspector.html:
747         * GCHeapInspector/script/interface.js:
748         (HeapInspectorUtils.humanReadableSize):
749         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
750         (HeapInspectorUtils.spanForNode.span.span):
751         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
752         (HeapSnapshotInspector.prototype.buildRoots):
753
754 2019-02-11  Daniel Bates  <dabates@apple.com>
755
756         [iOS] Mouse/Touch/Pointer events are missing modifier keys
757         https://bugs.webkit.org/show_bug.cgi?id=191446
758         <rdar://problem/45929460>
759
760         Reviewed by Tim Horton.
761
762         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
763
764         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
765         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
766         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
767         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
768         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
769         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
770         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
771         * TestRunnerShared/UIScriptContext/UIScriptController.h:
772         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
773         (WTR::arrayLength):
774         (WTR::parseModifierArray):
775         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
776         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
777         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
778         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
779
780 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
781
782         DumpRenderTree should report unknown options
783         https://bugs.webkit.org/show_bug.cgi?id=191303
784
785         Reviewed by Frédéric Wang.
786
787         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
788         to report unknown options.
789         Added and assigned test options which are currently used in tests.
790
791         * DumpRenderTree/TestOptions.cpp:
792         (TestOptions::TestOptions):
793
794 2019-02-11  Truitt Savell  <tsavell@apple.com>
795
796         Unreviewed, rolling out r241229.
797
798         Revision broke internal builds for watchOS.
799
800         Reverted changeset:
801
802         "[Cocoa] Ask platform for generic font family mappings"
803         https://bugs.webkit.org/show_bug.cgi?id=187723
804         https://trac.webkit.org/changeset/241229
805
806 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
807
808         [WinCairo][MiniBrowser] Basic authentication always fails.
809         https://bugs.webkit.org/show_bug.cgi?id=194496
810
811         Reviewed by Don Olmstead.
812
813         * MiniBrowser/win/DialogHelper.h:
814         (Dialog::getText):
815
816 2019-02-11  Philippe Normand  <pnormand@igalia.com>
817
818         [GStreamer] GstMappedBuffer testsuite build fails
819         https://bugs.webkit.org/show_bug.cgi?id=194495
820
821         Reviewed by Carlos Garcia Campos.
822
823         Fix the build by explicitely adding the gstreamer1.0-audio include
824         directories to the include path.
825
826         * TestWebKitAPI/PlatformGTK.cmake:
827         * TestWebKitAPI/PlatformWPE.cmake:
828
829 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
830
831         [GTK][WPE] Add enable-javascript-markup setting
832         https://bugs.webkit.org/show_bug.cgi?id=193439
833
834         Reviewed by Michael Catanzaro.
835
836         Add test cases to check the new setting.
837
838         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
839         (testWebKitSettings):
840         (testWebKitSettingsJavaScriptMarkup):
841         (beforeAll):
842
843 2019-02-10  Darin Adler  <darin@apple.com>
844
845         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
846         https://bugs.webkit.org/show_bug.cgi?id=194485
847
848         Reviewed by Daniel Bates.
849
850         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
851
852 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
853
854         Add more tests for clampTo<>()
855         https://bugs.webkit.org/show_bug.cgi?id=194462
856
857         Reviewed by Geoffrey Garen.
858
859         Darin suggested to test the very last floating point number
860         at the boundaries when truncating to integer.
861         I added test for max/min and max-1/min-1.
862
863         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
864         (TestWebKitAPI::TEST):
865
866 2019-02-09  Darin Adler  <darin@apple.com>
867
868         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
869         https://bugs.webkit.org/show_bug.cgi?id=194021
870
871         Reviewed by Geoffrey Garen.
872
873         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
874         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
875         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
876
877 2019-02-09  Zalan Bujtas  <zalan@apple.com>
878
879         [LFC][IFC] Add intrinsic width support for basic inline containers
880         https://bugs.webkit.org/show_bug.cgi?id=194473
881
882         Reviewed by Antti Koivisto.
883
884         Expand tests coverage (11 new tests -> 798)
885
886         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
887
888 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
889
890         Fix MiniBrowser's entitlements
891         https://bugs.webkit.org/show_bug.cgi?id=192431
892
893         Reviewed by Joseph Pecoraro.
894
895         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
896         files, making it impossible to load any extension.
897
898         * MiniBrowser/MiniBrowser.entitlements:
899
900 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
901
902         [Cocoa] Ask platform for generic font family mappings
903         https://bugs.webkit.org/show_bug.cgi?id=187723
904         <rdar://problem/41892438>
905
906         Reviewed by Brent Fulgham.
907
908         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
909
910         * DumpRenderTree/mac/DumpRenderTree.mm:
911         (allowedFontFamilySet):
912         * WebKitTestRunner/mac/TestControllerMac.mm:
913         (WTR::allowedFontFamilySet):
914
915 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
916
917         [GTK] Implement back/forward touchpad gesture
918         https://bugs.webkit.org/show_bug.cgi?id=193919
919
920         Reviewed by Michael Catanzaro.
921
922         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
923         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
924
925 2019-02-08  Alex Christensen  <achristensen@webkit.org>
926
927         Add SPI to use networking daemon instead of XPC service
928         https://bugs.webkit.org/show_bug.cgi?id=194427
929
930         Reviewed by Geoffrey Garen
931
932         * MiniBrowser/MiniBrowser.entitlements:
933
934 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
935
936         [ews-build] Ensure that every builder in config.json has short name
937         https://bugs.webkit.org/show_bug.cgi?id=194461
938
939         Reviewed by Lucas Forschler.
940
941         * BuildSlaveSupport/ews-build/loadConfig.py:
942         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
943
944 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
945
946         [ews-build] Add short name to config.json
947         https://bugs.webkit.org/show_bug.cgi?id=194456
948
949         Reviewed by Lucas Forschler.
950
951         * BuildSlaveSupport/ews-build/config.json: Added short name.
952         * BuildSlaveSupport/ews-build/loadConfig.py:
953         (loadBuilderConfig): Set the short name as the builder description.
954
955 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
956
957         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
958         https://bugs.webkit.org/show_bug.cgi?id=194418
959
960         Reviewed by Lucas Forschler.
961
962         Do not include errors trying when finding crashlogs at the end of
963         a run-webkit-tests run since we don't process those errors.
964
965         * Scripts/webkitpy/port/darwin.py:
966         (DarwinPort._look_for_all_crash_logs_in_log_dir):
967         * Scripts/webkitpy/port/ios_device.py:
968         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
969         * Scripts/webkitpy/port/watch_device.py:
970         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
971
972 2019-02-08  Beth Dakin  <bdakin@apple.com>
973
974         Add afterScreenUpdates to WKSnapshotConfiguration
975         https://bugs.webkit.org/show_bug.cgi?id=194362
976         -and corresponding-
977         <rdar://problem/40655528> Please add an "after screen updates" property to 
978         WKSnapshotConfiguration (to solve blank snapshots)
979
980         Reviewed by Tim Horton.
981
982         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
983         (TEST):
984
985 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
986
987         clampTo(): do not convert the input to double when dealing with integers
988         https://bugs.webkit.org/show_bug.cgi?id=194263
989         <rdar://problem/47692312>
990
991         Reviewed by Darin Adler.
992
993         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
994         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
995         (TestWebKitAPI::testClampFloatingPointToInteger):
996         (TestWebKitAPI::testClampSameSignIntegers):
997         (TestWebKitAPI::testClampUnsignedToSigned):
998         (TestWebKitAPI::testClampSignedToUnsigned):
999
1000 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1001
1002         webkitpy: Respect --dedicated-simulators flag
1003         https://bugs.webkit.org/show_bug.cgi?id=194416
1004         <rdar://problem/47894722>
1005
1006         Reviewed by Lucas Forschler.
1007
1008         * Scripts/webkitpy/port/device_port.py:
1009         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1010         available devices can be safely ignored.
1011
1012 2019-02-07  Keith Rollin  <krollin@apple.com>
1013
1014         Remove extra copy of 100x100-red.tga
1015         https://bugs.webkit.org/show_bug.cgi?id=194371
1016         <rdar://problem/47873465>
1017
1018         Reviewed by Said Abou-Hallawa.
1019
1020         In order to help it pass its tests, Bug 194190 added a second copy of
1021         the file 100x100-red.tga. However, it turns out that this additional
1022         file wasn't actually needed, and that that sole previous copy was
1023         sufficient. At the same time, this second copy -- which was copied to
1024         the same location in the build output as the first copy -- now caused
1025         XCBuild to complain because there were two production rules for the
1026         same output file. Address this by removing the newly-added extra copy.
1027
1028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1029         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1030
1031 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1032
1033         Deprecate WKBundlePageSetDefersLoading
1034         https://bugs.webkit.org/show_bug.cgi?id=191394
1035
1036         Reviewed by Dean Jackson.
1037
1038         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1039         (WTR::TestRunner::setDefersLoading):
1040
1041 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1042
1043         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1044         https://bugs.webkit.org/show_bug.cgi?id=194391
1045
1046         Reviewed by Antti Koivisto.
1047
1048         * LayoutReloaded/misc/LFC-passing-tests.txt:
1049
1050 2019-02-06  Keith Rollin  <krollin@apple.com>
1051
1052         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1053         https://bugs.webkit.org/show_bug.cgi?id=193975
1054         <rdar://problem/47643306>
1055
1056         Reviewed by Tim Horton.
1057
1058         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1059         the Info.plist file into the bundle. This step is not necessary as the
1060         implicit "bundle up all the build products into a framework" build
1061         phase does this already. Having the Copy Bundle Resources phase do
1062         this causes a conflict under XCBuild, which objects to two build
1063         phases producing the same file (Info.plist). Address this by removing
1064         Info.plist from the Copy Bundle Resources phase.
1065
1066         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1067
1068 2019-02-06  Keith Rollin  <krollin@apple.com>
1069
1070         Really enable the automatic checking and regenerations of .xcfilelists during builds
1071         https://bugs.webkit.org/show_bug.cgi?id=194357
1072         <rdar://problem/47861231>
1073
1074         Reviewed by Chris Dumez.
1075
1076         Bug 194124 was supposed to enable the automatic checking and
1077         regenerating of .xcfilelist files during the build. While related
1078         changes were included in that patch, the change to actually enable the
1079         operation somehow was omitted. This patch actually enables the
1080         operation. The check-xcfilelist.sh scripts now check
1081         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1082         from the checking.
1083
1084         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1085         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1086
1087 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1088
1089         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1090         <https://webkit.org/b/194286>
1091         <rdar://problem/47815558>
1092
1093         Reviewed by Alexey Proskuryakov.
1094
1095         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1096         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1097         WKRetainPtr<> to avoid leaking the WKDataRef.
1098
1099 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1100
1101         Unreviewed, fix a typo
1102
1103         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1104
1105 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1106
1107         [GTK][WPE] force libpsl build to use ICU in jhbuild
1108         https://bugs.webkit.org/show_bug.cgi?id=194288
1109
1110         Reviewed by Carlos Garcia Campos.
1111
1112         * gtk/jhbuild.modules:
1113         Require ICU for libpsl build in jhbuild, like done in WPE.
1114
1115 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1116
1117         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1118         https://bugs.webkit.org/show_bug.cgi?id=194209
1119
1120         Reviewed by Carlos Garcia Campos.
1121
1122         Enhance TestCookieManager to ensure this doesn't happen again.
1123
1124         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1125         (testCookieManagerPersistentStorage):
1126         (beforeAll):
1127
1128 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1129
1130         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1131         https://bugs.webkit.org/show_bug.cgi?id=194324
1132
1133         Reviewed by Andy Estes.
1134
1135         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1136         part of the name is already implicit, since this is in testing code in TestOptions.
1137
1138         * WebKitTestRunner/TestController.cpp:
1139         (WTR::TestController::generateContextConfiguration const):
1140         (WTR::updateTestOptionsFromTestHeader):
1141         * WebKitTestRunner/TestOptions.h:
1142         (WTR::TestOptions::hasSameInitializationOptions const):
1143
1144 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1145
1146         [ews-build] Allow * as platform for builders and workers
1147         https://bugs.webkit.org/show_bug.cgi?id=188533
1148
1149         Reviewed by Lucas Forschler.
1150
1151         * BuildSlaveSupport/ews-build/loadConfig.py:
1152         (checkWorkersAndBuildersForConsistency):
1153
1154 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1155
1156         [ews-build] Add few bots to config.json
1157         https://bugs.webkit.org/show_bug.cgi?id=194304
1158
1159         Reviewed by Lucas Forschler.
1160
1161         * BuildSlaveSupport/ews-build/config.json:
1162
1163 2019-02-05  Keith Rollin  <krollin@apple.com>
1164
1165         Enable the automatic checking and regenerations of .xcfilelists during builds
1166         https://bugs.webkit.org/show_bug.cgi?id=194124
1167         <rdar://problem/47721277>
1168
1169         Reviewed by Tim Horton.
1170
1171         Bug 193790 add a facility for checking -- during build time -- that
1172         any needed .xcfilelist files are up-to-date and for updating them if
1173         they are not. This facility was initially opt-in by setting
1174         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1175         the process seemed robust. Its now time to enable this facility and
1176         make it opt-out. If there is a need to disable this facility, set and
1177         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1178         running `make` or `build-webkit`, or before running Xcode from the
1179         command line.
1180
1181         Additionally, remove the step that generates a list of source files
1182         going into the UnifiedSources build step. It's only necessarily to
1183         specify Sources.txt and SourcesCocoa.txt as inputs.
1184
1185         * Scripts/generate-xcfilelists:
1186
1187 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1188
1189         [GTK][WPE] force libpsl build to use ICU in jhbuild
1190         https://bugs.webkit.org/show_bug.cgi?id=194288
1191
1192         Reviewed by Philippe Normand.
1193
1194         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1195         This can cause build failures if libidn is detected but libunistring is not available.
1196
1197         Make sure that ICU is used for runtime and builtin PSL data.
1198
1199         * gtk/jhbuild.modules:
1200         * wpe/jhbuild.modules:
1201
1202 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1203
1204         [ews-app] Modified timestamp should be updated on updating data
1205         https://bugs.webkit.org/show_bug.cgi?id=194295
1206
1207         Reviewed by Lucas Forschler.
1208
1209         * BuildSlaveSupport/ews-app/ews/models/build.py:
1210         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1211         * BuildSlaveSupport/ews-app/ews/models/step.py:
1212
1213 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1214
1215         Unreviewed, rolling out r240742.
1216
1217         Causes crashes on iOS simulator.
1218
1219         Reverted changeset:
1220
1221         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1222         not focused in a content-editable element"
1223         https://bugs.webkit.org/show_bug.cgi?id=192824
1224         https://trac.webkit.org/changeset/240742
1225
1226 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1227
1228         run-webkit-tests emits message "...running None" when running tests
1229         https://bugs.webkit.org/show_bug.cgi?id=194133
1230         <rdar://problem/47724738>
1231
1232         Reviewed by Lucas Forschler.
1233
1234         * Scripts/webkitpy/xcode/device_type.py:
1235         (DeviceType.__str__): Use both version mapping tables and use just the variant
1236         name if no version name is available.
1237         * Scripts/webkitpy/xcode/device_type_unittest.py:
1238         (DeviceTypeTest):
1239         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1240         an associated named.
1241
1242 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1243
1244         [WPE] require python3-setuptools for meson build in jhbuild
1245         https://bugs.webkit.org/show_bug.cgi?id=194287
1246
1247         Reviewed by Philippe Normand.
1248
1249         python3-setuptools is needed to build meson in jhbuild.
1250         It is already required by the GTK port.
1251
1252         * wpe/install-dependencies:
1253
1254 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1255
1256         [ews-app] Add method to save BuilderMapping to database
1257         https://bugs.webkit.org/show_bug.cgi?id=194264
1258
1259         Reviewed by Lucas Forschler.
1260
1261         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1262         (BuilderMapping.__str__):
1263         (BuilderMapping):
1264         (BuilderMapping.save_mapping):
1265         (BuilderMapping.update_mapping):
1266         (BuilderMapping.get_existing_mapping):
1267         (BuilderMapping.is_valid_mapping):
1268
1269 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1270
1271         [ews-app] Add timestamp fields for BuilderMappings
1272         https://bugs.webkit.org/show_bug.cgi?id=194266
1273
1274         Reviewed by Lucas Forschler.
1275
1276         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1277         (BuilderMapping):
1278
1279 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1280
1281         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1282         https://bugs.webkit.org/show_bug.cgi?id=174816
1283
1284         Reviewed by Michael Catanzaro.
1285
1286         Add tests for webkit_uri_for_display().
1287
1288         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1289         (testURIForDisplayUnaffected):
1290         (testURIForDisplayAffected):
1291         (beforeAll):
1292         (afterAll):
1293         * TestWebKitAPI/glib/CMakeLists.txt:
1294
1295 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1296
1297         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1298         https://bugs.webkit.org/show_bug.cgi?id=194158
1299         <rdar://problem/47737268>
1300
1301         Rubber-stamped by Aakash Jain.
1302
1303         * Scripts/webkitpy/port/device_port.py:
1304         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1305
1306 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1307
1308         [CG] Enable setAdditionalSupportedImageTypes for WK1
1309         https://bugs.webkit.org/show_bug.cgi?id=194190
1310
1311         Reviewed by Tim Horton.
1312
1313         Add a test similar to the one under WebKit Cocoa but make it create a
1314         WebView instead of a WKWebView.
1315
1316         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1317         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1318         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1319         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1320         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1321         (TestWebKitAPI::runTest):
1322         (TestWebKitAPI::TEST):
1323
1324 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1325
1326         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1327         https://bugs.webkit.org/show_bug.cgi?id=194168
1328
1329         Reviewed by Simon Fraser.
1330
1331         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1332
1333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1334         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1335         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1336         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1337         (TEST):
1338         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1339         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1340
1341 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1342
1343         REGRESSION (r237269): webkit-patch what-broke is broken 
1344         https://bugs.webkit.org/show_bug.cgi?id=193025
1345
1346         Reviewed by Aakash Jain.
1347
1348         * Scripts/webkitpy/common/host.py:
1349         (Host.buildbot):
1350         (Host.bugzilla): Renamed to 'buildbot'.
1351
1352 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1353
1354         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1355         https://bugs.webkit.org/show_bug.cgi?id=194207
1356
1357         Reviewed by Tim Horton.
1358
1359         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1360         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1361         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1362         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1363         start and delete forwards to remove the original attachment.
1364
1365         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1366         (TestWebKitAPI::TEST):
1367
1368 2019-02-04  Youenn Fablet  <youenn@apple.com>
1369
1370         Capture state should be managed consistently when doing process swapping
1371         https://bugs.webkit.org/show_bug.cgi?id=194122
1372         <rdar://problem/47609293>
1373
1374         Reviewed by Eric Carlson.
1375
1376         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1377         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1378         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1379         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1380         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1381         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1382         (WTR::TestRunner::isDoingMediaCapture const):
1383         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1384         * WebKitTestRunner/TestController.cpp:
1385         (WTR::TestController::isDoingMediaCapture const):
1386         * WebKitTestRunner/TestController.h:
1387         * WebKitTestRunner/TestInvocation.cpp:
1388         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1389         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1390         (WTR::TestController::isDoingMediaCapture const):
1391
1392 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1393
1394         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1395         https://bugs.webkit.org/show_bug.cgi?id=194142
1396
1397         Reviewed by Ross Kirsling.
1398
1399         There three 'separator' variables in TestController.cpp. Renamed
1400         it 'pathSeparator', and unified them.
1401
1402         * WebKitTestRunner/TestController.cpp:
1403         (WTR::TestController::generateContextConfiguration const):
1404         (WTR::createTestURL):
1405         (WTR::TestController::platformAdjustContext):
1406
1407 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1408
1409         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1410         https://bugs.webkit.org/show_bug.cgi?id=194198
1411
1412         Reviewed by Antti Koivisto.
1413
1414         No need to set the banner heights on navigation now, since Page stores them.
1415
1416         * MiniBrowser/mac/WK2BrowserWindowController.m:
1417         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1418
1419 2019-02-03  John Wilander  <wilander@apple.com>
1420
1421         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1422         https://bugs.webkit.org/show_bug.cgi?id=194104
1423         <rdar://problem/47649991>
1424
1425         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1426
1427         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1428         (TestWebKitAPI::TEST):
1429             Changed numeric types from unsigned short to uint32_t.
1430
1431 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1432
1433         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1434         <https://webkit.org/b/194178>
1435         <rdar://problem/47753473>
1436
1437         Reviewed by Alexey Proskuryakov.
1438
1439         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1440         (WTR::uninstallFakeHelvetica): Pass nullptr into
1441         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1442
1443 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1444
1445         [LFC] Initialize ICB's style with fixed width/height.
1446         https://bugs.webkit.org/show_bug.cgi?id=194188
1447
1448         Reviewed by Antti Koivisto.
1449
1450         * LayoutReloaded/misc/LFC-passing-tests.txt:
1451
1452 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1453
1454         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1455         https://bugs.webkit.org/show_bug.cgi?id=194185
1456
1457         Reviewed by Antti Koivisto.
1458
1459         * LayoutReloaded/misc/LFC-passing-tests.txt:
1460
1461 2018-12-16  Darin Adler  <darin@apple.com>
1462
1463         Convert additional String::format clients to alternative approaches
1464         https://bugs.webkit.org/show_bug.cgi?id=192746
1465
1466         Reviewed by Alexey Proskuryakov.
1467
1468         * WebKitTestRunner/TestController.cpp:
1469         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1470         as an intermediate in code that ultimately constructs a WTF::String.
1471         (WTR::userMediaOriginHash): Use makeString.
1472         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1473         (WTR::TestController::didPerformClientRedirect): Ditto.
1474         (WTR::TestController::didPerformServerRedirect): Ditto.
1475         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1476
1477 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1478
1479         [ews-build] Add unit test to verify builder keys
1480         https://bugs.webkit.org/show_bug.cgi?id=194152
1481
1482         Reviewed by Lucas Forschler.
1483
1484         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1485         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1486
1487 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1488
1489         [LFC] Expand tests coverage (12 new tests -> 787)
1490
1491         Unreviewed test gardening.
1492
1493         * LayoutReloaded/misc/LFC-passing-tests.txt:
1494
1495 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1496
1497         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1498         https://bugs.webkit.org/show_bug.cgi?id=194163
1499
1500         Reviewed by Simon Fraser.
1501
1502         775
1503
1504         * LayoutReloaded/misc/LFC-passing-tests.txt:
1505
1506 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1507
1508         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1509         https://bugs.webkit.org/show_bug.cgi?id=194140
1510         <rdar://problem/47728098>
1511
1512         Reviewed by Tim Horton.
1513
1514         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1515         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1516         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1517
1518         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1519         test to induce an IPC deadlock when presenting a modal alert during touch start.
1520
1521         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1522         * WebKitTestRunner/TestController.cpp:
1523         (WTR::runJavaScriptAlert):
1524
1525         Add a client callback function for running JavaScript alerts.
1526
1527         (WTR::TestController::createOtherPage):
1528         (WTR::TestController::generateContextConfiguration const):
1529
1530         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1531         the fix in this patch.
1532
1533         (WTR::TestController::createWebViewWithOptions):
1534
1535         Plumb TestOptions to generateContextConfiguration.
1536
1537         (WTR::TestController::resetPreferencesToConsistentValues):
1538         (WTR::TestController::resetStateToConsistentValues):
1539         (WTR::updateTestOptionsFromTestHeader):
1540         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1541         (WTR::TestController::handleJavaScriptAlert):
1542         * WebKitTestRunner/TestController.h:
1543         * WebKitTestRunner/TestInvocation.cpp:
1544         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1545         * WebKitTestRunner/TestOptions.h:
1546         (WTR::TestOptions::hasSameInitializationOptions const):
1547
1548 2019-02-01  Chris Dumez  <cdumez@apple.com>
1549
1550         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1551         https://bugs.webkit.org/show_bug.cgi?id=193740
1552         <rdar://problem/47527267>
1553
1554         Reviewed by Alex Christensen.
1555
1556         Add API test coverage.
1557
1558         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1559
1560 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1561
1562         [ews-app] Add display name field to BuilderMapping model
1563         https://bugs.webkit.org/show_bug.cgi?id=194153
1564
1565         Reviewed by Lucas Forschler.
1566
1567         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1568         (BuilderMapping):
1569
1570 2019-02-01  Youenn Fablet  <youenn@apple.com>
1571
1572         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1573         https://bugs.webkit.org/show_bug.cgi?id=194155
1574
1575         Reviewed by Eric Carlson.
1576
1577         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1578         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1579         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1580
1581 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1582
1583         [LFC] Adjust replaced element's intrinsic ratio
1584         https://bugs.webkit.org/show_bug.cgi?id=194154
1585
1586         Reviewed by Antti Koivisto.
1587
1588         761
1589
1590         * LayoutReloaded/misc/LFC-passing-tests.txt:
1591
1592 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1593
1594         [WPE] Show test results in minibrowser
1595         https://bugs.webkit.org/show_bug.cgi?id=194150
1596
1597         Reviewed by Žan Doberšek.
1598
1599         * Scripts/webkitpy/port/wpe.py:
1600         (WPEPort.show_results_html_file):
1601
1602 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1603
1604         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1605         https://bugs.webkit.org/show_bug.cgi?id=194151
1606
1607         Reviewed by Žan Doberšek.
1608
1609         ALT + <- go back
1610         ALT + -> go forward
1611
1612         * MiniBrowser/wpe/main.cpp:
1613         (main):
1614
1615 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1616
1617         [LFC] Set intrinsic size on Layout::Replaced
1618         https://bugs.webkit.org/show_bug.cgi?id=194139
1619
1620         Reviewed by Antti Koivisto.
1621
1622         744
1623
1624         * LayoutReloaded/misc/LFC-passing-tests.txt:
1625
1626 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1627
1628         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1629         https://bugs.webkit.org/show_bug.cgi?id=194146
1630
1631         Reviewed by Xabier Rodriguez-Calvar.
1632
1633         It allows to open relative paths.
1634
1635         * MiniBrowser/wpe/main.cpp:
1636         (main):
1637
1638 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1639
1640         Update flakiness dashboard configuration after recent queue changes
1641         https://bugs.webkit.org/show_bug.cgi?id=194127
1642
1643         Rubber-stamped by Aakash Jain.
1644
1645         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1646
1647         * TestResultServer/static-dashboards/builders.jsonp:
1648
1649 2019-01-31  Youenn Fablet  <youenn@apple.com>
1650
1651         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1652         https://bugs.webkit.org/show_bug.cgi?id=194106
1653         <rdar://problem/47676333>
1654
1655         Reviewed by Ryosuke Niwa.
1656
1657         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1658         (TestWebKitAPI::didFinishNavigation):
1659         (TestWebKitAPI::TEST):
1660         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1661
1662 2019-01-31  Chris Dumez  <cdumez@apple.com>
1663
1664         Page zoom level is lost after a process swap or a crash
1665         https://bugs.webkit.org/show_bug.cgi?id=194105
1666         <rdar://problem/47610781>
1667
1668         Reviewed by Alex Christensen.
1669
1670         Add API test coverage.
1671
1672         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1673         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1674
1675 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1676
1677         Revert r238819 which is unneeded and caused a performance regression.
1678         https://bugs.webkit.org/show_bug.cgi?id=192272
1679         <rdar://problem/46664625>
1680
1681         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1682         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1683         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1684
1685 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1686
1687         Formalize WebKitAdditions mechanism of LoadOptimizer
1688         https://bugs.webkit.org/show_bug.cgi?id=193886
1689         <rdar://problem/47696809>
1690
1691         Reviewed by Brent Fulgham.
1692
1693         * MiniBrowser/MiniBrowser.entitlements:
1694         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1695
1696 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1697
1698         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1699         https://bugs.webkit.org/show_bug.cgi?id=194090
1700
1701         Reviewed by Antti Koivisto.
1702
1703         * LayoutReloaded/misc/LFC-passing-tests.txt:
1704
1705 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1706
1707         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1708         https://bugs.webkit.org/show_bug.cgi?id=194074
1709
1710         Reviewed by Antti Koivisto.
1711
1712         * LayoutReloaded/misc/LFC-passing-tests.txt:
1713
1714 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1715
1716         [LFC][BFC] Add support for block level replaced box.
1717         https://bugs.webkit.org/show_bug.cgi?id=194071
1718
1719         Reviewed by Antti Koivisto.
1720
1721         * LayoutReloaded/misc/LFC-passing-tests.txt:
1722
1723 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1724
1725         Fix WebKitTestRunner's testPath with Windows full paths
1726         https://bugs.webkit.org/show_bug.cgi?id=194012
1727
1728         Reviewed by Alex Christensen.
1729
1730         updateTestOptionsFromTestHeader failed to open test files because
1731         testPath returned wrong file paths. It returned a path "/C:/..."
1732         if a URL "file:///C:/..." was given.
1733
1734         * WebKitTestRunner/TestController.cpp:
1735         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1736
1737 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1738
1739         [WPE] Bump font related dependencies to match the GTK+ port
1740         https://bugs.webkit.org/show_bug.cgi?id=194017
1741
1742         Reviewed by Žan Doberšek.
1743
1744         * wpe/jhbuild.modules:
1745         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1746         * wpe/patches/icudata-stdlibs.patch: Added.
1747
1748 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1749
1750         Enable swipe tests on iOS
1751         https://bugs.webkit.org/show_bug.cgi?id=194076
1752
1753         Reviewed by Geoffrey Garen.
1754
1755         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1756         it causes a debug assertion failure in runUIScript.
1757
1758         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1759         (WTR::UIScriptController::beginBackSwipe):
1760         (WTR::UIScriptController::completeBackSwipe):
1761
1762 2019-01-30  Keith Rollin  <krollin@apple.com>
1763
1764         Use correct printf format specifier
1765         https://bugs.webkit.org/show_bug.cgi?id=194062
1766         <rdar://problem/47686167>
1767
1768         Reviewed by Alexey Proskuryakov.
1769
1770         LayoutTestSpellChecker.mm is trying to format a variable of type
1771         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1772         actually an unsigned long long. Fix this by formatting with %llu.
1773
1774         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1775         (-[LayoutTestTextCheckingResult description]):
1776
1777 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1778
1779         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1780         https://bugs.webkit.org/show_bug.cgi?id=193979
1781
1782         Reviewed by Wenson Hsieh.
1783
1784         Fix the test for iOS. Make the test work with iOS UA string.
1785
1786         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1787
1788 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1789
1790         Replace High Sierra LLINT CLoop bot due to hardware failure
1791         https://bugs.webkit.org/show_bug.cgi?id=194066
1792
1793         Reviewed by Aakash Jain.
1794
1795         * BuildSlaveSupport/build.webkit.org-config/config.json:
1796
1797 2019-01-30  Keith Rollin  <krollin@apple.com>
1798
1799         [NSDragItem init] is unavailable
1800         https://bugs.webkit.org/show_bug.cgi?id=194059
1801         <rdar://problem/47685715>
1802
1803         Reviewed by Wenson Hsieh.
1804
1805         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1806         DumpRenderTree and TestWebKitAPI, which both try to create an
1807         NSDragItem in a manner that invokes this method. Address this by using
1808         -initWithPasteboardWriter instead.
1809
1810         Note that the parameter passed to initWithPasteboardWriter is likely
1811         incorrect. In both cases, the object passed does not conform to
1812         NSPasteboardWriting. However, with this fix, we're no worse off than
1813         before, and can now perform builds with newer compilers and SDKs until
1814         a real fix can be crafted. That work is tracked in
1815         https://bugs.webkit.org/show_bug.cgi?id=194060
1816
1817         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1818         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1819         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1820         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1821
1822 2019-01-30  Daniel Bates  <dabates@apple.com>
1823
1824         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1825         https://bugs.webkit.org/show_bug.cgi?id=192824
1826         <rdar://problem/47100332>
1827
1828         Reviewed by Wenson Hsieh.
1829
1830         Fix a bug where the wrong usage code was used for F13 thru F24.
1831
1832         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1833         (keyCodeForDOMFunctionKey):
1834
1835 2019-01-30  Chris Dumez  <cdumez@apple.com>
1836
1837         Regression(PSON) Load hang can occur on history navigation
1838         https://bugs.webkit.org/show_bug.cgi?id=194030
1839         <rdar://problem/47656939>
1840
1841         Reviewed by Antti Koivisto.
1842
1843         Add API test coverage.
1844
1845         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1846
1847 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1848
1849         [LFC] Expand tests coverage.
1850
1851         Unreviewed test gardening.
1852
1853         * LayoutReloaded/misc/LFC-passing-tests.txt:
1854
1855 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1856
1857         [Flatpak] Add openjpeg support
1858         https://bugs.webkit.org/show_bug.cgi?id=194019
1859
1860         Reviewed by Michael Catanzaro.
1861
1862         * flatpak/org.webkit.CommonModules.yaml:
1863
1864 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1865
1866         Unreviewed, rolling out r240708.
1867         https://bugs.webkit.org/show_bug.cgi?id=194022
1868
1869         It broke WPE build (Requested by KaL on #webkit).
1870
1871         Reverted changeset:
1872
1873         "[WPE] Bump font related dependencies to match the GTK+ port"
1874         https://bugs.webkit.org/show_bug.cgi?id=194017
1875         https://trac.webkit.org/changeset/240708
1876
1877 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1878
1879         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1880         https://bugs.webkit.org/show_bug.cgi?id=194001
1881
1882         Reviewed by Antti Koivisto.
1883
1884         * LayoutReloaded/misc/LFC-passing-tests.txt:
1885
1886 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1887
1888         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1889         https://bugs.webkit.org/show_bug.cgi?id=194020
1890
1891         Reviewed by Antti Koivisto.
1892
1893         * LayoutReloaded/misc/LFC-passing-tests.txt:
1894
1895 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1896
1897         AX: Support color well on iOS
1898         https://bugs.webkit.org/show_bug.cgi?id=194010
1899
1900         Reviewed by Joanmarie Diggs.
1901
1902         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1903         (WTR::AccessibilityUIElement::stringAttributeValue):
1904
1905 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1906
1907         [WPE] Bump font related dependencies to match the GTK+ port
1908         https://bugs.webkit.org/show_bug.cgi?id=194017
1909
1910         Reviewed by Žan Doberšek.
1911
1912         * wpe/jhbuild.modules:
1913         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1914         * wpe/patches/icudata-stdlibs.patch: Added.
1915
1916 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1917
1918         [Mac] Update window scale API usage
1919         https://bugs.webkit.org/show_bug.cgi?id=193991
1920         rdar://problem/47614795
1921
1922         Reviewed by Tim Horton.
1923
1924         * DumpRenderTree/mac/DumpRenderTree.mm:
1925         (changeWindowScaleIfNeeded):
1926         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1927         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1928         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1929
1930 2019-01-29  Chris Dumez  <cdumez@apple.com>
1931
1932         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1933         https://bugs.webkit.org/show_bug.cgi?id=193977
1934         <rdar://problem/47643716>
1935
1936         Reviewed by Geoff Garen.
1937
1938         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1939         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1940         to the previous provisional committing *before* we make the last load. 
1941
1942         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1943
1944 2019-01-29  Youenn Fablet  <youenn@apple.com>
1945
1946         Adopt new SPI to evaluate server certificate trust
1947         https://bugs.webkit.org/show_bug.cgi?id=193355
1948
1949         Reviewed by Alex Christensen.
1950
1951         Add infrastructure to handle HTTPS server trust evaluation testing.
1952
1953         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1954         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1955         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1956         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1957         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1958         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1959         * WebKitTestRunner/TestController.cpp:
1960         (WTR::TestController::resetPreferencesToConsistentValues):
1961         (WTR::TestController::didReceiveAuthenticationChallenge):
1962         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1963         * WebKitTestRunner/TestController.h:
1964         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1965         * WebKitTestRunner/TestInvocation.cpp:
1966         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1967         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1968         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1969
1970 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1971
1972         [ews-build] Add build step to print bot Configuration
1973         https://bugs.webkit.org/show_bug.cgi?id=193887
1974
1975         Reviewed by Lucas Forschler.
1976
1977         * BuildSlaveSupport/ews-build/steps.py:
1978         (PrintConfiguration): Build step to print configuration.
1979         * BuildSlaveSupport/ews-build/factories.py:
1980
1981 2019-01-29  Chris Dumez  <cdumez@apple.com>
1982
1983         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1984         https://bugs.webkit.org/show_bug.cgi?id=193967
1985         <rdar://problem/47635348>
1986
1987         Reviewed by Alex Christensen.
1988
1989         Add API test coverage.
1990
1991         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1992         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1993
1994 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1995
1996         [ews-app] Handle incoming results data
1997         https://bugs.webkit.org/show_bug.cgi?id=193973
1998
1999         Reviewed by Lucas Forschler.
2000
2001         * BuildSlaveSupport/ews-app/ews/views/results.py:
2002
2003 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2004
2005         [ews-app] Make the results url generic
2006         https://bugs.webkit.org/show_bug.cgi?id=193928
2007
2008         Reviewed by Lucas Forschler.
2009
2010         * BuildSlaveSupport/ews-app/ews/urls.py:
2011
2012 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2013
2014         [ews-build] Configure buildbot to send events to ews-app
2015         https://bugs.webkit.org/show_bug.cgi?id=193968
2016
2017         Reviewed by Lucas Forschler.
2018
2019         * BuildSlaveSupport/ews-build/events.py: Added.
2020         * BuildSlaveSupport/ews-build/master.cfg:
2021
2022 2019-01-29  Keith Rollin  <krollin@apple.com>
2023
2024         Add .xcfilelists to Run Script build phases
2025         https://bugs.webkit.org/show_bug.cgi?id=193792
2026         <rdar://problem/47201785>
2027
2028         Reviewed by Alex Christensen.
2029
2030         As part of supporting XCBuild, update the necessary Run Script build
2031         phases in their Xcode projects to refer to their associated
2032         .xcfilelist files.
2033
2034         Note that the addition of these files bumps the Xcode project version
2035         number to something that's Xcode 10 compatible. This change means that
2036         older versions of the Xcode IDE can't read these projects. Nor can it
2037         fully load workspaces that refer to these projects (the updated
2038         projects are shown as non-expandable placeholders). `xcodebuild` can
2039         still build these projects; it's just that the IDE can't open them.
2040
2041         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2042         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2043
2044 2019-01-29  John Wilander  <wilander@apple.com>
2045
2046         Add data abstraction and validation for Ad Click Attribution
2047         https://bugs.webkit.org/show_bug.cgi?id=193916
2048         <rdar://problem/47603481>
2049
2050         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2051
2052         Ad click attribution has two steps. First, the storage of an ad
2053         campaign ID for a click that takes the user to a destination
2054         site. Second, a conversion on the destination site that can be
2055         attributed to the ad click.
2056
2057         This patch adds a class that represents a request for ad click
2058         attribution. Validation makes sure that the bits of entropy
2059         reported through this mechanism is limited.
2060
2061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2062         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2063         (TestWebKitAPI::TEST):
2064
2065 2019-01-29  Chris Dumez  <cdumez@apple.com>
2066
2067         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2068         https://bugs.webkit.org/show_bug.cgi?id=193932
2069         <rdar://problem/47598947>
2070
2071         Reviewed by Brady Eidson.
2072
2073         Add API test coverage.
2074
2075         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2076
2077 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2078
2079         Adding new passing LFC tests.
2080
2081         Unreviewed test gardening.
2082
2083         * LayoutReloaded/misc/LFC-passing-tests.txt:
2084
2085 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2086
2087         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2088         https://bugs.webkit.org/show_bug.cgi?id=193964
2089
2090         Reviewed by Antti Koivisto.
2091
2092         * LayoutReloaded/misc/LFC-passing-tests.txt:
2093
2094 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2095
2096         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2097         https://bugs.webkit.org/show_bug.cgi?id=193954
2098
2099         Reviewed by Antti Koivisto.
2100
2101         * LayoutReloaded/misc/LFC-passing-tests.txt:
2102
2103 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2104
2105         WebDriver: add support for running subtests
2106         https://bugs.webkit.org/show_bug.cgi?id=193904
2107
2108         Reviewed by Michael Catanzaro.
2109
2110         pytest already supports it by passing test.py::subtest, so we can do the same.
2111
2112         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2113         (get_item_name): Made this global.
2114         (CollectRecorder.__init__): Receive the parameter to ignore.
2115         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2116         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2117         (collect): Add parameter to ignore.
2118         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2119         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2120         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2121         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2122         (WebDriverTestRunnerSelenium.run): Ditto.
2123         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2124         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2125         (WebDriverTestRunnerW3C.run): Ditto.
2126
2127 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2128
2129         User agent string override for navigator.userAgent should be site specific quirks
2130         https://bugs.webkit.org/show_bug.cgi?id=193950
2131
2132         Reviewed by Brent Fulgham.
2133
2134         Updated per the _WKWebsitePolicies rename.
2135
2136         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2137         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2138
2139 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2140
2141         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2142         https://bugs.webkit.org/show_bug.cgi?id=193941
2143
2144         Reviewed by Alex Christensen.
2145
2146         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2147         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2148         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2149         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2150         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2151         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2152         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2153         * TestWebKitAPI/Tests/WTF/Time.cpp:
2154         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2155         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2156         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2157         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2158
2159 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2160
2161         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2162
2163         * Scripts/webkitpy/common/config/contributors.json:
2164
2165 2019-01-28  Andy Estes  <aestes@apple.com>
2166
2167         [watchOS] Enable Parental Controls content filtering
2168         https://bugs.webkit.org/show_bug.cgi?id=193939
2169         <rdar://problem/46641912>
2170
2171         Reviewed by Ryosuke Niwa.
2172
2173         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2174
2175 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2176
2177         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2178         <https://webkit.org/b/193884>
2179
2180         Reviewed by Jiewen Tan.
2181
2182         * Scripts/webkitpy/style/checkers/cpp.py:
2183         (check_language): Add LocalAuthentication to
2184         `frameworks_with_soft_links`.
2185
2186 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2187
2188         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2189         https://bugs.webkit.org/show_bug.cgi?id=193891
2190
2191         Reviewed by Ross Kirsling.
2192
2193         There were three problems in window sizes of WebView and the host window.
2194         1. The sizes of pixel image output were incorrect.
2195         2. The host window is going to appear after window.resize was invoked.
2196         3. window.resize resized only the host window, not WebView.
2197
2198         This change solves them with a following approach.
2199         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2200         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2201            as well as DumpRenderTree in order to match the client area and the window area.
2202         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2203         d. PlatformWebView::setWindowFrame changes both window sizes.
2204         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2205
2206         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2207         (WTR::PlatformWebView::PlatformWebView): Create the host window
2208         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2209         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2210         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2211
2212 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2213
2214         [ews-app] Add method to save Step data to database
2215         https://bugs.webkit.org/show_bug.cgi?id=193890
2216
2217         Reviewed by Lucas Forschler.
2218
2219         * BuildSlaveSupport/ews-app/ews/models/step.py:
2220         (Step.save_step): Method to save step data.
2221         (Step.update_step): Method to update step data.
2222         (Step.get_existing_step): Method to fetch existing step from database.
2223         (Step.is_valid_result): Method to validate valid step result.
2224
2225 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2226
2227         [ews-app] Add method to save Build data to database
2228         https://bugs.webkit.org/show_bug.cgi?id=193735
2229
2230         Reviewed by Lucas Forschler.
2231
2232         * BuildSlaveSupport/ews-app/ews/models/build.py:
2233         (Build.save_build): Method to save build information to database.
2234         (Build.get_existing_build): Method to fetch existing build from database.
2235         (Build.is_valid_result): Method to validate build result.
2236         * BuildSlaveSupport/ews-app/ews/common/util.py:
2237         (is_valid_int_id): Method to validate valid id.
2238
2239 2019-01-28  Chris Dumez  <cdumez@apple.com>
2240
2241         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2242         https://bugs.webkit.org/show_bug.cgi?id=193915
2243         <rdar://problem/47560907>
2244
2245         Reviewed by Alex Christensen.
2246
2247         Add API test coverage.
2248
2249         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2250
2251 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2252
2253         [ews-app] Rename id variables
2254         https://bugs.webkit.org/show_bug.cgi?id=193883
2255
2256         Reviewed by Lucas Forschler.
2257
2258         * BuildSlaveSupport/ews-app/ews/models/build.py:
2259         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2260         * BuildSlaveSupport/ews-app/ews/models/step.py:
2261         * BuildSlaveSupport/ews-app/ews/urls.py:
2262         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2263         * BuildSlaveSupport/ews-app/ews/views/results.py:
2264         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2265
2266 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2267
2268         [ews-app] Allow certain fields to be empty
2269         https://bugs.webkit.org/show_bug.cgi?id=193892
2270
2271         Reviewed by Lucas Forschler.
2272
2273         * BuildSlaveSupport/ews-app/ews/models/build.py:
2274         * BuildSlaveSupport/ews-app/ews/models/step.py:
2275
2276 2019-01-28  Rob Buis  <rbuis@igalia.com>
2277
2278         Update MIME type parser
2279         https://bugs.webkit.org/show_bug.cgi?id=180526
2280
2281         Reviewed by Frédéric Wang.
2282
2283         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2284         (TestWebKitAPI::TEST):
2285
2286 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2287
2288         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2289         https://bugs.webkit.org/show_bug.cgi?id=193896
2290
2291         Reviewed by Antti Koivisto.
2292
2293         * LayoutReloaded/misc/LFC-passing-tests.txt:
2294
2295 2018-12-15  Darin Adler  <darin@apple.com>
2296
2297         Replace many uses of String::format with more type-safe alternatives
2298         https://bugs.webkit.org/show_bug.cgi?id=192742
2299
2300         Reviewed by Mark Lam.
2301
2302         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2303         (WTR::cacheTestRunnerCallback): Use makeString.
2304         * WebKitTestRunner/TestController.cpp:
2305         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2306         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2307
2308 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2309
2310         Use a load optimizer for some sites
2311         https://bugs.webkit.org/show_bug.cgi?id=193881
2312         <rdar://problem/46325455>
2313
2314         Reviewed by Brent Fulgham.
2315
2316         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2317         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2318
2319 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2320
2321         AX: Introduce a static accessibility tree
2322         https://bugs.webkit.org/show_bug.cgi?id=193348
2323         <rdar://problem/47203295>
2324
2325         Reviewed by Ryosuke Niwa.
2326
2327         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2328
2329 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2330
2331         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2332         https://bugs.webkit.org/show_bug.cgi?id=193867
2333
2334         Reviewed by Antti Koivisto.
2335
2336         * LayoutReloaded/misc/LFC-passing-tests.txt:
2337
2338 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2339
2340         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2341         https://bugs.webkit.org/show_bug.cgi?id=193865
2342
2343         Reviewed by Antti Koivisto.
2344
2345         * LayoutReloaded/misc/LFC-passing-tests.txt:
2346
2347 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2348
2349         Need a mechanism to override navigator.userAgent
2350         https://bugs.webkit.org/show_bug.cgi?id=193762
2351         <rdar://problem/47504939>
2352
2353         Reviewed by Brent Fulgham.
2354
2355         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2356
2357         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2358         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2359         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2360
2361 2019-01-25  Dean Jackson  <dino@apple.com>
2362
2363         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2364         https://bugs.webkit.org/show_bug.cgi?id=193831
2365         <rdar://problem/47399263>
2366
2367         Reviewed by Chris Dumez.
2368
2369         Two new tests that exercise cross-origin and same-origin System
2370         Previews.
2371
2372         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2373
2374 2019-01-25  Keith Rollin  <krollin@apple.com>
2375
2376         Update Xcode projects with "Check .xcfilelists" build phase
2377         https://bugs.webkit.org/show_bug.cgi?id=193790
2378         <rdar://problem/47201374>
2379
2380         Reviewed by Alex Christensen.
2381
2382         Support for XCBuild includes specifying inputs and outputs to various
2383         Run Script build phases. These inputs and outputs are specified as
2384         .xcfilelist files. Once created, these .xcfilelist files need to be
2385         kept up-to-date. In order to check that they are up-to-date or not,
2386         add an Xcode build step that invokes an external script that performs
2387         the checking. If the .xcfilelists are found to be out-of-date, update
2388         them, halt the build, and instruct the developer to restart the build
2389         with up-to-date files.
2390
2391         At this time, the checking and regenerating is performed only if the
2392         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2393         who want to use this facility can set this variable and test out the
2394         checking/regenerating. Once it seems like there are no egregious
2395         issues that upset a developer's workflow, we'll unconditionally enable
2396         this facility.
2397
2398         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2399         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2400         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2401         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2402
2403 2019-01-25  Keith Rollin  <krollin@apple.com>
2404
2405         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2406         https://bugs.webkit.org/show_bug.cgi?id=193781
2407         <rdar://problem/47201153>
2408
2409         Reviewed by Alex Christensen.
2410
2411         Part of generating the .xcfilelists used as part of adopting XCBuild
2412         includes running `make DerivedSources.make` from a standalone script.
2413         It’s important for this invocation to have the same environment as
2414         when the actual build invokes `make DerivedSources.make`. If the
2415         environments are different, then the two invocations will provide
2416         different results. In order to get the same environment in the
2417         standalone script, have the script launch xcodebuild targeting the
2418         "Apply Configuration to XCFileLists" build target, which will then
2419         re-invoke our standalone script. The script is now running again, this
2420         time in an environment with all workspace, project, target, xcconfig
2421         and other environment variables established.
2422
2423         The "Apply Configuration to XCFileLists" build target accomplishes
2424         this task via a small embedded shell script that consists only of:
2425
2426             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2427
2428         The process that invokes "Apply Configuration to XCFileLists" first
2429         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2430         evaluated and exports it into the shell environment. When xcodebuild
2431         is invoked, it inherits the value of this variable and can `eval` the
2432         contents of that variable. Our external standalone script can then set
2433         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2434         of command-line parameters needed to restart itself in the appropriate
2435         state.
2436
2437         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2438         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2439
2440 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2441
2442         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2443         https://bugs.webkit.org/show_bug.cgi?id=193802
2444         <rdar://problem/46010580>
2445
2446         Reviewed by Andy Estes.
2447
2448         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2449         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2450         (TEST):
2451
2452 2019-01-25  Daniel Bates  <dabates@apple.com>
2453
2454         [iOS] uiController.keyDown() does not translate Control modified key
2455         https://bugs.webkit.org/show_bug.cgi?id=192898
2456
2457         Reviewed by Wenson Hsieh.
2458
2459         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2460         key translation, as applicable. Among other cases, key translation occurs when performing
2461         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2462         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2463         human pressing down and releasing key(s) using a hardware keyboard.
2464
2465         * WebKitTestRunner/ios/HIDEventGenerator.h:
2466         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2467         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2468
2469         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2470         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2471         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2472         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2473         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2474         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2475         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2476         (-[HIDEventGenerator longPress:completionBlock:]):
2477         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2478         Update code for above renaming.
2479
2480         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2481         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2482
2483         (-[HIDEventGenerator keyDown:]): Added.
2484         (-[HIDEventGenerator keyUp:]): Added.
2485         (-[HIDEventGenerator keyPress:completionBlock:]):
2486         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2487         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2488         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2489         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2490         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2491         (WTR::parseModifier): Deleted.
2492
2493 2019-01-25  Keith Rollin  <krollin@apple.com>
2494
2495         Complete the implementation of generate-xcfilelists
2496         https://bugs.webkit.org/show_bug.cgi?id=193782
2497
2498         Reviewed by Alex Christensen.
2499
2500         A preliminary version of generate-xcfilelists was added in r238008.
2501         This patch updates that script in order to:
2502
2503         - Support checking of .xcfilelists
2504         - Perform better execution of `make DerivedSources.make` by
2505           relaunching generate-xcfilelists under xcodebuild
2506         - Support incremental generation and checking of .xcfilelists
2507         - Support supplementary .xcfilelists files from WebKitAdditions
2508         - Support being wrapped by parallel version of generate-xcfilelists in
2509           Internal that adds support for (re)generating WebKit projects in
2510           that repo.
2511         - Support builds that have been performed in WebKitBuild as well as
2512           ~/Library/Developer/code/DerivedData
2513         - Increase robustness and debugging facilities.
2514
2515         * Scripts/generate-xcfilelists:
2516
2517 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2518
2519         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2520         https://bugs.webkit.org/show_bug.cgi?id=193297
2521         <rdar://problem/47158841>
2522
2523         Unreviewed test case fix.
2524
2525         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2526         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2527
2528         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2529         (TEST):
2530
2531 2019-01-25  Keith Rollin  <krollin@apple.com>
2532
2533         Update existing .xcfilelists
2534         https://bugs.webkit.org/show_bug.cgi?id=193791
2535         <rdar://problem/47201706>
2536
2537         Reviewed by Alex Christensen.
2538
2539         Many .xcfilelist files were added in r238824 in order to support
2540         XCBuild. Update these with recent changes to the set of build files
2541         and with the current generate-xcfilelist script.
2542
2543         * DumpRenderTree/DerivedSources-input.xcfilelist:
2544         * DumpRenderTree/DerivedSources-output.xcfilelist:
2545         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2546         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2547
2548 2019-01-25  Keith Rollin  <krollin@apple.com>
2549
2550         Fix missing dependencies in extract-dependencies-from-makefile
2551         https://bugs.webkit.org/show_bug.cgi?id=193783
2552         <rdar://problem/47201571>
2553
2554         Reviewed by Alex Christensen.
2555
2556         The extract-dependencies-from-makefile script generates .xcfilelists
2557         for XCBuild by invoking a makefile in --debug mode, parsing the
2558         dependency information in the output, and extracting information
2559         regarding targets and dependents. However, the way `make` emits this
2560         dependency information is not rigorous, and so we need to determine
2561         what lines to look for and parse by trial and error. This approach
2562         didn't coriginally atch all the information we needed to collect, so
2563         update the script to look for the additional lines we now know to look
2564         for.
2565
2566         * Scripts/extract-dependencies-from-makefile:
2567         (Parser):
2568         (Parser.addTarget):
2569         (Parser.addPrereq):
2570         (Parser.doParse):
2571
2572 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2573
2574         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2575         https://bugs.webkit.org/show_bug.cgi?id=193297
2576         <rdar://problem/47158841>
2577
2578         Reviewed by Alex Christensen.
2579
2580         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2581             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2582         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2583         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2584         activating the message used to trigger the callback when it is set.
2585
2586 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2587
2588         WKWebView.goBack should reload if there is a safe browsing warning
2589         https://bugs.webkit.org/show_bug.cgi?id=193805
2590         <rdar://problem/46908216>
2591
2592         Reviewed by Geoff Garen.
2593
2594         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2595         (+[Simple3LookupContext sharedLookupContext]):
2596         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2597         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2598         (TEST):
2599
2600 2019-01-25  Chris Dumez  <cdumez@apple.com>
2601
2602         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2603         https://bugs.webkit.org/show_bug.cgi?id=193788
2604         <rdar://problem/47531231>
2605
2606         Reviewed by Alex Christensen.
2607
2608         Add API test coverage.
2609
2610         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2611         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2612
2613 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2614
2615         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2616         https://bugs.webkit.org/show_bug.cgi?id=193771
2617
2618         Unreviewed infrastructure fix.
2619
2620         * Scripts/webkitpy/port/darwin.py:
2621         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2622
2623 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2624
2625         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2626
2627 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2628
2629         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2630
2631         * Scripts/webkitpy/common/config/contributors.json:
2632
2633 2019-01-25  Chris Dumez  <cdumez@apple.com>
2634
2635         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2636         https://bugs.webkit.org/show_bug.cgi?id=193779
2637         <rdar://problem/46170903>
2638
2639         Reviewed by Antti Koivisto.
2640
2641         Add API test that quickly navigates forward to a previous process without waiting for it to
2642         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2643         the process' previous page when reconnecting the it for the forward navigation.
2644
2645         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2646
2647 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2648
2649         Need a way for JavaScript (or bundle) code to participate in undo
2650         https://bugs.webkit.org/show_bug.cgi?id=190009
2651         <rdar://problem/44807048>
2652
2653         Reviewed by Ryosuke Niwa.
2654
2655         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2656         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2657
2658         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2659         (WTR::UIScriptController::lastUndoLabel const):
2660         (WTR::UIScriptController::firstRedoLabel const):
2661         (WTR::UIScriptController::platformUndoManager const):
2662         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2663         (WTR::UIScriptController::lastUndoLabel const):
2664         (WTR::UIScriptController::firstRedoLabel const):
2665         (WTR::UIScriptController::platformUndoManager const):
2666         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2667         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2668         (WTR::UIScriptController::lastUndoLabel const):
2669         (WTR::UIScriptController::firstRedoLabel const):
2670         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2671         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2672         (WTR::UIScriptController::lastUndoLabel const):
2673         (WTR::UIScriptController::firstRedoLabel const):
2674         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2675         (WTR::UIScriptController::platformUndoManager const):
2676         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2677         (WTR::UIScriptController::platformUndoManager const):
2678
2679 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2680
2681         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2682         https://bugs.webkit.org/show_bug.cgi?id=193824
2683
2684         Reviewed by Antti Koivisto.
2685
2686         * LayoutReloaded/misc/LFC-passing-tests.txt:
2687
2688 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2689
2690         Update macOS JSC bot configurations
2691         https://bugs.webkit.org/show_bug.cgi?id=193739
2692
2693         Reviewed by Alexey Proskuryakov.
2694
2695         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2696         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2697         (BubbleQueueServer): Move JSC EWS to Mojave section.
2698         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2699         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2700         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2701
2702 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2703
2704         [Win][WebKitTestRunner] Implement EventSenderProxy
2705         https://bugs.webkit.org/show_bug.cgi?id=193755
2706
2707         Reviewed by Don Olmstead.
2708
2709         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2710         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2711         (WTR::EventSenderProxy::dispatchMessage):
2712         (WTR::EventSenderProxy::EventSenderProxy):
2713         (WTR::EventSenderProxy::mouseDown):
2714         (WTR::EventSenderProxy::mouseUp):
2715         (WTR::EventSenderProxy::mouseMoveTo):
2716         (WTR::EventSenderProxy::mouseScrollBy):
2717         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2718
2719 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2720
2721         Unreviewed fix for API test failure after r240437.
2722
2723         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2724
2725         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2726
2727 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2728
2729         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2730         https://bugs.webkit.org/show_bug.cgi?id=193787
2731         <rdar://problem/47497634>
2732
2733         Reviewed by Alexey Proskuryakov.
2734
2735         * Scripts/webkitdirs.pm:
2736         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2737
2738 2019-01-24  Truitt Savell  <tsavell@apple.com>
2739
2740         Unreviewed, rolling out r240446.
2741
2742         Casued 5 API failures
2743
2744         Reverted changeset:
2745
2746         "Activate the WebResourceLoadStatisticsStore in the
2747         NetworkProcess and deactivate it in the UIProcess."
2748         https://bugs.webkit.org/show_bug.cgi?id=193297
2749         https://trac.webkit.org/changeset/240446
2750
2751 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2752
2753         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2754         https://bugs.webkit.org/show_bug.cgi?id=193741
2755         <rdar://problem/47135030>
2756
2757         Reviewed by Antti Koivisto and Simon Fraser.
2758
2759         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2760         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2761         (TestWebKitAPI::TEST):
2762
2763 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2764
2765         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2766         https://bugs.webkit.org/show_bug.cgi?id=193297
2767         <rdar://problem/47158841>
2768
2769         Reviewed by Alex Christensen.
2770
2771         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2772         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2773         activating the message used to trigger the callback when it is set.
2774
2775 2019-01-24  John Wilander  <wilander@apple.com>
2776
2777         Add Ad Click Attribution as an internal/experimental feature
2778         https://bugs.webkit.org/show_bug.cgi?id=193685
2779         <rdar://problem/47450399>
2780
2781         Reviewed by Brent Fulgham.
2782
2783         Added test option adClickAttributionEnabled.
2784
2785         * DumpRenderTree/TestOptions.cpp:
2786         (TestOptions::TestOptions):
2787         * DumpRenderTree/TestOptions.h:
2788         * DumpRenderTree/mac/DumpRenderTree.mm:
2789         (setWebPreferencesForTestOptions):
2790
2791 2019-01-24  Antti Koivisto  <antti@apple.com>
2792
2793         [PSON] Flash on back navigation on Mac
2794         https://bugs.webkit.org/show_bug.cgi?id=193716
2795         <rdar://problem/47148458>
2796
2797         Reviewed by Chris Dumez.
2798
2799         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2800
2801         Closing of the previous page is delayed so waiting for didFinishNavigation is
2802         not sufficient to guarantee we have received all the messages. Wait for them.
2803
2804 2019-01-24  Chris Dumez  <cdumez@apple.com>
2805
2806         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2807         https://bugs.webkit.org/show_bug.cgi?id=193761
2808         <rdar://problem/47456405>
2809
2810         Reviewed by Alex Christensen.
2811
2812         Add API test coverage.
2813
2814         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2815
2816 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2817
2818         webkitpy: Missing PID in crashlog name should not be fatal
2819         https://bugs.webkit.org/show_bug.cgi?id=193771
2820
2821         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2822         of raising an exception.
2823
2824         Reviewed by Lucas Forschler.
2825
2826         * Scripts/webkitpy/port/darwin.py:
2827         (DarwinPort._merge_crash_logs):
2828
2829 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2830
2831         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2832         https://bugs.webkit.org/show_bug.cgi?id=193746
2833
2834         Reviewed by Youenn Fablet.
2835
2836         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2837         so we'd best just not call it.
2838
2839         * Scripts/webkitpy/w3c/test_exporter.py:
2840         (WebPlatformTestExporter.create_branch_with_patch):
2841
2842 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2843
2844         Move FileSystem to WTF
2845         https://bugs.webkit.org/show_bug.cgi?id=193602
2846
2847         Reviewed by Yusuke Suzuki.
2848
2849         * DumpRenderTree/win/DumpRenderTree.cpp:
2850         * TestWebKitAPI/CMakeLists.txt:
2851         * TestWebKitAPI/PlatformGTK.cmake:
2852         * TestWebKitAPI/PlatformJSCOnly.cmake:
2853         * TestWebKitAPI/PlatformPlayStation.cmake:
2854         * TestWebKitAPI/PlatformWPE.cmake:
2855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2856         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2857         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2858         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2859         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2860         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2861         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2862         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2863         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2864         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2865
2866 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2867
2868         [WPE] Remove hard dependency on subprocess32 for the API tests
2869
2870         Rubber-stamped by Carlos Garcia Campos.
2871
2872         * glib/api_test_runner.py:
2873         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2874         its presence only when running WPEQt tests.
2875
2876 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2877
2878         [GLIB] Expose JavaScriptCore options in GLib public API
2879         https://bugs.webkit.org/show_bug.cgi?id=188742
2880
2881         Reviewed by Michael Catanzaro.
2882
2883         Add a test for the new API.
2884
2885         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2886         (testsJSCOptions):
2887         (main):
2888
2889 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2890
2891         [GTK][WPE] Support JPEG 2000 images
2892         https://bugs.webkit.org/show_bug.cgi?id=186272
2893
2894         Reviewed by Žan Doberšek.
2895
2896         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2897
2898         * gtk/jhbuild.modules:
2899         * wpe/jhbuild.modules:
2900
2901 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2902
2903         check-webkit-style should warn when using soft-linking macros in a header
2904         <https://webkit.org/b/193750>
2905
2906         Reviewed by Darin Adler.
2907
2908         * Scripts/webkitpy/style/checkers/cpp.py:
2909         (check_language): Add softlink/header check by refactoring the
2910         softlink/framework check.
2911         (CppChecker): Enable softlink/header check by default.
2912         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2913         (CppStyleTest.test_softlink_framework): Rename from
2914         CppStyleTest.test_softlink() and change test framework name in
2915         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2916         files. Set file_name for macros that only appear in headers.
2917         (CppStyleTest.test_softlink_header): Add tests for using
2918         soft-link macros in headers.
2919
2920 2019-01-23  Chris Dumez  <cdumez@apple.com>
2921
2922         Deprecate API to limit the maximum number of WebProcesses
2923         https://bugs.webkit.org/show_bug.cgi?id=193725
2924         <rdar://problem/47464879>
2925
2926         Reviewed by Geoff Garen.
2927
2928         Update existing API tests to stop using deprecated API.
2929
2930         * MiniBrowser/mac/AppDelegate.m:
2931         (defaultConfiguration):
2932         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2933         (TestWebKitAPI::TEST):
2934         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2935         (TestWebKitAPI::TEST):
2936         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2937         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2938         (TEST):
2939         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2940         (TEST):
2941
2942 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2943
2944         [ews-app] Rename ews model buildermappings to buildermapping
2945         https://bugs.webkit.org/show_bug.cgi?id=193729
2946
2947         Reviewed by Lucas Forschler.
2948
2949         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2950         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2951         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2952
2953 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2954
2955         [ews-app] Rename ews model steps to step
2956         https://bugs.webkit.org/show_bug.cgi?id=193697
2957
2958         Reviewed by Lucas Forschler.
2959
2960         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2961         (Step): Renamed Steps to Step.
2962
2963 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2964
2965         Clean up IndexedDB files between tests
2966         https://bugs.webkit.org/show_bug.cgi?id=192796
2967         <rdar://problem/46824999>
2968
2969         Reviewed by Geoffrey Garen.
2970
2971         * DumpRenderTree/mac/DumpRenderTree.mm:
2972         (runTest):
2973         * WebKitTestRunner/TestController.cpp:
2974         (WTR::TestController::resetStateToConsistentValues):
2975         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2976         (WTR::RemoveAllIndexedDatabasesCallback):
2977         (WTR::TestController::ClearIndexedDatabases):
2978         * WebKitTestRunner/TestController.h:
2979         * WebKitTestRunner/TestInvocation.cpp:
2980         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2981
2982 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2983
2984         [ews-app] Rename ews model Builds to Build
2985         https://bugs.webkit.org/show_bug.cgi?id=193695
2986
2987         Reviewed by Lucas Forschler.
2988
2989         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2990         (Build): Renamed Builds to Build.
2991
2992 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2993
2994         webkitpy: Wait longer when launching WebKitTestRunner
2995         https://bugs.webkit.org/show_bug.cgi?id=193734
2996
2997         Reviewed by Aakash Jain.
2998
2999         * Scripts/webkitpy/port/simulator_process.py:
3000         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3001
3002 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3003
3004         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3005         https://bugs.webkit.org/show_bug.cgi?id=193182
3006         <rdar://problem/47452154>
3007
3008         Reviewed by Tim Horton.
3009
3010         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3011         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3012         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3013
3014         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3015         preventing later tests from recognizing gestures.
3016
3017         * WebKitTestRunner/ios/TestControllerIOS.mm:
3018         (WTR::TestController::platformResetStateToConsistentValues):
3019
3020         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3021
3022 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3023
3024         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3025         https://bugs.webkit.org/show_bug.cgi?id=193722
3026         <rdar://problem/47481475>
3027
3028         Reviewed by Lucas Forschler.
3029
3030         iPhone and iPad ports should both use the iOS config.
3031
3032         * Scripts/webkitpy/port/ios_simulator.py:
3033         (IPhoneSimulatorPort.__init__):
3034         (IPadSimulatorPort.__init__):
3035
3036 2019-01-23  Rob Buis  <rbuis@igalia.com>
3037
3038         Update MIME type parser
3039         https://bugs.webkit.org/show_bug.cgi?id=180526
3040
3041         Reviewed by Frédéric Wang.
3042
3043         Add unit tests for both parse modes of ParsedContentType.
3044
3045         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3046         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3047         (TestWebKitAPI::TEST):
3048
3049 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3050
3051         [ews-app] fetch loop should not stop on network issues
3052         https://bugs.webkit.org/show_bug.cgi?id=193666
3053
3054         Reviewed by Lucas Forschler.
3055
3056         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3057         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3058
3059 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3060
3061         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3062         https://bugs.webkit.org/show_bug.cgi?id=189165
3063         <rdar://problem/47433765>
3064
3065         Reviewed by Tim Horton.
3066
3067         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3068         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3069         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3070         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3071         would make its way to the UI process by the time the layer tree commit is finished.
3072
3073         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3074         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3075         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3076         will fail because it asks for -_autofillContext too early.
3077
3078         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3079         is handled in the UI process.
3080
3081         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3082
3083         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3084         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3085         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3086         input session.
3087
3088         (-[AutofillTestView textInputHasAutofillContext]):
3089
3090         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3091
3092         * TestWebKitAPI/cocoa/TestWKWebView.h:
3093         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3094         (nextInputSessionChangeCount):
3095
3096         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3097         This includes changing the focused element from one to another.
3098
3099         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3100         (-[TestWKWebView didStartFormControlInteraction]):
3101         (-[TestWKWebView didEndFormControlInteraction]):
3102         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3103
3104         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3105         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3106         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3107         that doesn't require an input session to one that doesn't.
3108
3109 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3110
3111         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3112         <https://webkit.org/b/193676>
3113
3114         Reviewed by Alexey Proskuryakov.
3115
3116         * Scripts/webkitpy/style/checkers/cpp.py:
3117         (check_member_initialization_list):
3118         - Don't report missing whitespace around colon if the colon at
3119           the start of the line is formatted correctly.
3120         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3121         (WebKitStyleTest.test_member_initialization_list):
3122         - Add a test for a missing permutation of existing tests.
3123         - Add a test this false-positive.
3124         - Add blank lines between subtests to make them easier to read.
3125
3126 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3127
3128         [build.webkit.org] Unit-test failure after r237113
3129         https://bugs.webkit.org/show_bug.cgi?id=193669
3130
3131         Reviewed by Michael Catanzaro.
3132
3133         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3134         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3135         multiple or zero flags.
3136
3137 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3138
3139         Cache bytecode to disk
3140         https://bugs.webkit.org/show_bug.cgi?id=192782
3141         <rdar://problem/46084932>
3142
3143         Reviewed by Keith Miller.
3144
3145         Add test helper to execute bytecode-cache tests: it executes each test
3146         twice, the first with JSC_diskCachePath set to a temporary directory
3147         and second with JSC_forceDiskCache=true (in addition to the cache path)
3148         to guarantee that only the disk cache is being used and no new
3149         UnlinkedCodeBlocks are being created.
3150
3151         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3152         * Scripts/run-jsc-stress-tests:
3153
3154 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3155
3156         [css-logical] Implement flow-relative margin, padding and border shorthands
3157         https://bugs.webkit.org/show_bug.cgi?id=188697
3158
3159         Reviewed by Simon Fraser and Antti Koivisto.
3160
3161         * DumpRenderTree/TestOptions.cpp:
3162         (TestOptions::TestOptions):
3163         * DumpRenderTree/TestOptions.h:
3164         * DumpRenderTree/mac/DumpRenderTree.mm:
3165         (setWebPreferencesForTestOptions):
3166         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3167
3168         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3169         (JSONCSSPropertiesChecker.check_codegen_properties):
3170         Allow CSS property definitions to have a 'runtime-flag' parameter which
3171         disables the property when the specified runtime flag is disabled.
3172
3173 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3174
3175         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3176         https://bugs.webkit.org/show_bug.cgi?id=193643
3177
3178         Reviewed by Michael Catanzaro.
3179
3180         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3181         * wpe/jhbuild.modules: Ditto.
3182
3183 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3184
3185         [LFC][Floats] Take float top position into account when computing containing block height.
3186         https://bugs.webkit.org/show_bug.cgi?id=193655
3187
3188         Reviewed by Antti Koivisto.
3189
3190         * LayoutReloaded/misc/LFC-passing-tests.txt:
3191
3192 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3193
3194         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3195         <https://webkit.org/b/193645>
3196         <rdar://problem/47421574>
3197
3198         Reviewed by Alex Christensen.
3199
3200         - Now checks for local soft-linking of all frameworks that have
3201           their own *SoftLinking.{cpp,h,mm} files.
3202         - Changes softlink/uikit warning to softlink/framework.
3203
3204         * Scripts/webkitpy/style/checkers/cpp.py:
3205         (check_language):
3206         (CppChecker):
3207         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3208         (CppStyleTest):
3209
3210 2019-01-20  Saam Barati  <sbarati@apple.com>
3211
3212         Rollout r240210: It broke tests on iOS
3213         https://bugs.webkit.org/show_bug.cgi?id=193640
3214
3215         Unreviewed.
3216
3217         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3218         * Scripts/run-jsc-stress-tests:
3219
3220 2019-01-20  chris fleizach  <cfleizach@apple.com>
3221
3222         AX: Support returning relative frames for accessibility
3223         https://bugs.webkit.org/show_bug.cgi?id=193414
3224         <rdar://problem/47268501>
3225
3226         Reviewed by Zalan Bujtas.
3227
3228         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3229         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3230         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3231         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3232         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3233         (WTR::attributesOfElement):
3234         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3235
3236 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3237
3238         Unreviewed, add my new email address
3239
3240         * Scripts/webkitpy/common/config/contributors.json:
3241
3242 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3243
3244         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3245         https://bugs.webkit.org/show_bug.cgi?id=193617
3246
3247         Reviewed by Antti Koivisto.
3248
3249         * LayoutReloaded/misc/LFC-passing-tests.txt:
3250
3251 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3252
3253         Unreviewed, rolling out r240209.
3254
3255         Broke GTK/WPE injected bundle
3256
3257         Reverted changeset:
3258
3259         "AX: Support returning relative frames for accessibility"
3260         https://bugs.webkit.org/show_bug.cgi?id=193414
3261         https://trac.webkit.org/changeset/240209
3262
3263 2019-01-12  Dan Bernstein  <mitz@apple.com>
3264
3265         [Cocoa] Avoid importing directly from subumbrella frameworks
3266         https://bugs.webkit.org/show_bug.cgi?id=186016
3267         <rdar://problem/40591038>
3268
3269         Reviewed by Sam Weinig.
3270
3271         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3272           LaunchServices header.
3273         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3274           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3275         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3276           when using SDKs earlier than 10.13.
3277         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3278           and OTHER_CPLUSPLUSFLAGS.
3279         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3280           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3281         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3282           LaunchServices header.
3283
3284 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3285
3286         Cache bytecode to disk
3287         https://bugs.webkit.org/show_bug.cgi?id=192782
3288         <rdar://problem/46084932>
3289
3290         Reviewed by Keith Miller.
3291
3292         Add test helper to execute bytecode-cache tests: it executes each test
3293         twice, the first with JSC_diskCachePath set to a temporary directory
3294         and second with JSC_forceDiskCache=true (in addition to the cache path)
3295         to guarantee that only the disk cache is being used and no new
3296         UnlinkedCodeBlocks are being created.
3297
3298         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3299         * Scripts/run-jsc-stress-tests:
3300
3301 2019-01-20  chris fleizach  <cfleizach@apple.com>
3302
3303         AX: Support returning relative frames for accessibility
3304         https://bugs.webkit.org/show_bug.cgi?id=193414
3305         <rdar://problem/47268501>
3306
3307         Reviewed by Zalan Bujtas.
3308
3309         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3310         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3311         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3312         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3313         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3314         (WTR::attributesOfElement):
3315         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3316
3317 2019-01-20  Antoine Quint  <graouts@apple.com>
3318
3319         Add a POINTER_EVENTS feature flag
3320         https://bugs.webkit.org/show_bug.cgi?id=193577
3321         <rdar://problem/47408511>
3322
3323         Unreviewed. Also enable Pointer Events for iosmac.
3324
3325         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3326
3327 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3328
3329         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3330         https://bugs.webkit.org/show_bug.cgi?id=193613
3331
3332         Reviewed by Antti Koivisto.
3333
3334         * LayoutReloaded/misc/LFC-passing-tests.txt:
3335
3336 2019-01-19  Antoine Quint  <graouts@apple.com>
3337
3338         Add a POINTER_EVENTS feature flag
3339         https://bugs.webkit.org/show_bug.cgi?id=193577
3340
3341         Reviewed by Dean Jackson.
3342
3343         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3344
3345 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3346
3347         Disable the run-jsc-stress-test remote host key check [second round].
3348         https://bugs.webkit.org/show_bug.cgi?id=192988
3349
3350         Reviewed by Dewei Zhu.
3351
3352         * Scripts/run-jsc-stress-tests:
3353
3354 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3355
3356         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3357         https://bugs.webkit.org/show_bug.cgi?id=193597
3358
3359         Reviewed by Lucas Forschler.
3360
3361         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3362
3363 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3364
3365         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3366         https://bugs.webkit.org/show_bug.cgi?id=193595
3367
3368         Reviewed by Lucas Forschler.
3369
3370         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3371         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3372         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3373
3374 2019-01-18  Chris Dumez  <cdumez@apple.com>
3375
3376         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3377         https://bugs.webkit.org/show_bug.cgi?id=193588
3378         <rdar://problem/47131566>
3379
3380         Reviewed by Alex Christensen.
3381
3382         Add layout test coverage.
3383
3384         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3385
3386 2019-01-18  Jer Noble  <jer.noble@apple.com>
3387
3388         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3389         https://bugs.webkit.org/show_bug.cgi?id=189553
3390
3391         Reviewed by Tim Horton.
3392
3393         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3394
3395         * ContentExtensionTester/Configurations/Base.xcconfig:
3396         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3397         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3398         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3399         * ImageDiff/cg/Configurations/Base.xcconfig:
3400         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3401         * MiniBrowser/Configurations/Base.xcconfig:
3402         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3403         * MobileMiniBrowser/Configurations/Base.xcconfig:
3404         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3405         * Scripts/webkitpy/style/checker.py:
3406         (_all_categories):
3407         (FileType):
3408         (CheckerDispatcher._file_type):
3409         (CheckerDispatcher._create_checker):
3410         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3411         (SDKVariantChecker):
3412         (SDKVariantChecker.__init__):
3413         (SDKVariantChecker.check):
3414         * TestWebKitAPI/Configurations/Base.xcconfig:
3415         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3416         * WebEditingTester/Configurations/Base.xcconfig:
3417         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3418         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3419         * WebKitTestRunner/Configurations/Base.xcconfig:
3420         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3421         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3422         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3423
3424 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3425
3426         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3427         <https://webkit.org/b/193568>
3428         <rdar://problem/47381130>
3429
3430         Reviewed by Alex Christensen.
3431
3432         Make sure no one re-introduces UIKit soft-linking by adding a
3433         style rule.
3434
3435         * Scripts/webkitpy/style/checkers/cpp.py:
3436         (check_language): Add softlink/uikit check.
3437         (CppChecker): Enable softlink/uikit check.
3438         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3439         (CppStyleTest): Add test for softlink/uikit.
3440
3441 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3442
3443         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3444         https://bugs.webkit.org/show_bug.cgi?id=193584
3445
3446         Change "-dev" to "-devel".
3447
3448         Reviewed by Michael Catanzaro.
3449
3450         * gtk/install-dependencies:
3451
3452 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3453
3454         webkitpy: Add iPhone and iPad ports
3455         https://bugs.webkit.org/show_bug.cgi?id=193537
3456         <rdar://problem/47353390>
3457
3458         Reviewed by Lucas Forschler.
3459
3460         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3461         ports. Note that this separation is optional, the --ios-simulator command remains.
3462
3463         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3464         (RunTest.test_device_type_test_division): Drive-by fix.
3465         (RunTest.test_device_type_specific_listing): Ditto.
3466         (RunTest.test_ipad_test_division):
3467         (RunTest):
3468         (RunTest.test_ipad_listing):
3469         * Scripts/webkitpy/port/factory.py:
3470         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3471         (PortFactory):
3472         * Scripts/webkitpy/port/ios_simulator.py:
3473         (IPhoneSimulatorPort):
3474         (IPadSimulatorPort):
3475
3476 2019-01-18  Chris Dumez  <cdumez@apple.com>
3477
3478         Regression(PSON) Scroll position is not always restored properly when navigating back
3479         https://bugs.webkit.org/show_bug.cgi?id=193578
3480         <rdar://problem/47386331>
3481
3482         Reviewed by Tim Horton.
3483
3484         Add API test coverage.
3485
3486         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3487
3488 2019-01-18  Youenn Fablet  <youenn@apple.com>
3489
3490         Add a new SPI to request for cache storage quota increase
3491         https://bugs.webkit.org/show_bug.cgi?id=193323
3492
3493         Reviewed by Alex Christensen.
3494
3495         Implement WebsiteDataStore quota delegate to handle quota requests.
3496         By default, do not update quota.
3497         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3498
3499         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3500         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3501         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3502         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3503         * WebKitTestRunner/TestController.cpp:
3504         (WTR::TestController::allowCacheStorageQuotaIncrease):
3505         * WebKitTestRunner/TestController.h:
3506         * WebKitTestRunner/TestInvocation.cpp:
3507         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3508         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3509         (-[CacheStorageQuotaManager init]):
3510         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3511         (WTR::initializeWebViewConfiguration):
3512         (WTR::TestController::cocoaResetStateToConsistentValues):
3513         (WTR::TestController::allowCacheStorageQuotaIncrease):
3514
3515 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3516
3517         [ews-build] Pass owner to the triggered builds
3518         https://bugs.webkit.org/show_bug.cgi?id=193574
3519
3520         Reviewed by Lucas Forschler.
3521
3522         * BuildSlaveSupport/ews-build/factories.py:
3523         (BuildFactory.propertiesToPassToTriggers):
3524
3525 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3526
3527         [ews-app] Send patch author as a build property
3528         https://bugs.webkit.org/show_bug.cgi?id=193560
3529
3530         Reviewed by Lucas Forschler.
3531
3532         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3533         (BugzillaPatchFetcher.fetch):
3534
3535 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3536
3537         webkitpy: Implement device type specific expected results (Follow-up fix)
3538         https://bugs.webkit.org/show_bug.cgi?id=192162
3539         <rdar://problem/46345449>
3540
3541         Unreviewed infrastructure fix.
3542
3543         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3544         (Manager.run): Don't boot a device if no tests are available to run on it.
3545
3546 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3547
3548         webkitpy: Implement device type specific expected results (Follow-up fix)
3549         https://bugs.webkit.org/show_bug.cgi?id=192162
3550         <rdar://problem/46345449>
3551
3552         Unreviewed infrastructure fix.
3553
3554         * Scripts/webkitpy/api_tests/manager.py:
3555         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3556
3557 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3558
3559         webkitpy: Implement device type specific expected results (Part 2)
3560         https://bugs.webkit.org/show_bug.cgi?id=192162
3561         <rdar://problem/46345449>
3562
3563         Rubber-stamped by Aakash Jain.
3564
3565         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3566         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3567         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3568
3569         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3570         (LayoutTestFinder.find_tests): Pass device_type through.
3571         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3572         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3573         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3574         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3575         (Manager._collect_tests): Pass device type to test finder.
3576         (Manager._needs_web_platform_test):
3577         (Manager._prepare_lists): Index _expectations by device type.
3578         (Manager._test_input_for_file):
3579         (Manager._test_is_slow): Ditto.
3580         (Manager._test_should_dump_jsconsolelog_in_stderr):
3581         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3582         (Manager._get_test_inputs):
3583         (Manager._update_worker_count):
3584         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3585         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3586         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3587         the one which runs the test.
3588         (Manager._run_test_subset):
3589         (Manager._run_tests): Index _expectations by current_device_type.
3590         (Manager._print_expectation_line_for_test): Ditto.
3591         (Manager._print_expectations_for_subset): Ditto.
3592         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3593         Unlike run, this function will behave the same regardless of what devices are available.
3594         (Manager._custom_device_for_test): Deleted.
3595         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3596         (ManagerTest.test_uses_custom_device): Deleted.
3597         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3598         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3599         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3600         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3601         all of the expectations.
3602         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3603         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3604         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3605         (TestExpectations.__init__): Allow device_type to be passed through.
3606         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3607         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3608         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3609         (summarize_results):
3610         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3611         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3612         a test ran with, one must check all expectations to find the first non-skip expectation.
3613         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3614         (RunTest.test_device_type_test_division):
3615         (RunTest):
3616         (RunTest.test_device_type_specific_listing):
3617         * Scripts/webkitpy/port/base.py:
3618         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3619         (Port.supported_device_types): The result of this function will change based on what devices are available.
3620         * Scripts/webkitpy/port/device_port.py:
3621         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3622         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3623         can be used.
3624         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3625         any, or the DEFAULT_DEVICE_TYPES of the port.
3626         * Scripts/webkitpy/port/ios.py:
3627         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3628         * Scripts/webkitpy/port/ios_simulator.py:
3629         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3630         * Scripts/webkitpy/port/watch.py:
3631         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3632         * Scripts/webkitpy/port/watch_simulator.py:
3633         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3634         * Scripts/webkitpy/xcode/device_type.py:
3635         (DeviceType):
3636         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3637
3638 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3639
3640         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3641         https://bugs.webkit.org/show_bug.cgi?id=193575
3642
3643         Reviewed by Michael Catanzaro.
3644
3645         Allow the script to run without explicit port argument because
3646         it's specific to the WPE port anyway.
3647
3648         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3649         and simplify the rest of the code accordingly.
3650
3651 2019-01-18  Charlie Turner  <cturner@igalia.com>
3652
3653         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3654         https://bugs.webkit.org/show_bug.cgi?id=192229
3655
3656         Reviewed by Xabier Rodriguez-Calvar.
3657
3658         * MiniBrowser/wpe/main.cpp:
3659         (main): Enable encrypted-media by default.
3660
3661 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3662
3663         [Flatpak] Missing KeyboardInterrupt exception handler
3664         https://bugs.webkit.org/show_bug.cgi?id=193570
3665
3666         Reviewed by Michael Catanzaro.
3667
3668         * flatpak/flatpakutils.py:
3669         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3670
3671 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3672
3673         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3674         https://bugs.webkit.org/show_bug.cgi?id=193564
3675
3676         Reviewed by Antti Koivisto.
3677
3678         * LayoutReloaded/misc/LFC-passing-tests.txt:
3679
3680 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3681
3682         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3683         https://bugs.webkit.org/show_bug.cgi?id=193562
3684
3685         Reviewed by Antti Koivisto.
3686
3687         * LayoutReloaded/misc/LFC-passing-tests.txt:
3688
3689 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3690
3691         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3692         https://bugs.webkit.org/show_bug.cgi?id=193555
3693
3694         Reviewed by Antti Koivisto.
3695
3696         * LayoutReloaded/misc/LFC-passing-tests.txt:
3697
3698 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3699
3700         [WPE] Add Qt extension
3701         https://bugs.webkit.org/show_bug.cgi?id=191464
3702
3703         Reviewed by Carlos Garcia Campos.
3704
3705         MiniBrowser and API tests for the WPE Qt API. To run the
3706         MiniBrowser a new script is introduced. Example invocation:
3707
3708         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3709
3710         Also note-worthy is the introduction of the python2-subprocess32
3711         dependency to run the GLib API tests.
3712
3713         * MiniBrowser/wpe/CMakeLists.txt:
3714         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3715         * MiniBrowser/wpe/qt/main.cpp: Added.
3716         (main):
3717         * MiniBrowser/wpe/qt/main.qml: Added.
3718         * MiniBrowser/wpe/qt/qml.qrc: Added.
3719         * Scripts/run-gtk-tests:
3720         (GtkTestRunner.is_google_test):
3721         (GtkTestRunner):
3722         (GtkTestRunner.is_qt_test):
3723         * Scripts/run-qt-wpe-minibrowser: Added.
3724         * Scripts/run-wpe-tests:
3725         (WPETestRunner):
3726         (WPETestRunner.is_google_test):
3727         (WPETestRunner.is_qt_test):
3728         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3729         (TestLoad::main):
3730         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3731         (TestLoadHtml::main):
3732         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3733         (TestLoadRequest::main):
3734         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3735         (TestRunJavaScript::main):
3736         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3737         (waitForSignal):
3738         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3739         (LoadSpy::LoadSpy):
3740         (LoadSpy::~LoadSpy):
3741         (LoadSpy::onLoadingChanged):
3742         (LoadStartedCatcher::LoadStartedCatcher):
3743         (LoadStartedCatcher::~LoadStartedCatcher):
3744         (LoadStartedCatcher::onLoadingChanged):
3745         (waitForLoadSucceeded):
3746         (waitForLoadFailed):
3747         * TestWebKitAPI/glib/CMakeLists.txt:
3748         * flatpak/flatpakutils.py:
3749         (WebkitFlatpak.load_from_args):
3750         (WebkitFlatpak.__init__):
3751         (WebkitFlatpak.clean_args):
3752         (WebkitFlatpak.run_in_sandbox):
3753         * flatpak/org.webkit.CommonModules.yaml:
3754         * flatpak/org.webkit.WPE.yaml:
3755         * flatpak/org.webkit.WPEModules.yaml:
3756         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3757         * flatpak/org.webkit.WebKit.yaml:
3758         * glib/api_test_runner.py:
3759         (TestRunner._run_test_qt):
3760         (TestRunner.is_qt_test):
3761         (TestRunner._run_test):
3762
3763 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3764
3765         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3766         https://bugs.webkit.org/show_bug.cgi?id=193494
3767         <rdar://problem/46859627>
3768
3769         Reviewed by Simon Fraser and Tim Horton.
3770
3771         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3772         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3773
3774         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3775         (WTR::UIScriptController::contentOffsetX const):
3776         (WTR::UIScriptController::contentOffsetY const):
3777         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3778         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3779         (WTR::UIScriptController::contentOffsetX const):
3780         (WTR::UIScriptController::contentOffsetY const):
3781         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3782
3783         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3784
3785         * WebKitTestRunner/TestController.cpp:
3786         (WTR::updateTestOptionsFromTestHeader):
3787         * WebKitTestRunner/TestOptions.h:
3788         (WTR::TestOptions::hasSameInitializationOptions const):
3789         * WebKitTestRunner/ios/TestControllerIOS.mm:
3790         (WTR::TestController::platformResetStateToConsistentValues):
3791         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3792         (WTR::UIScriptController::contentOffsetX const):
3793         (WTR::UIScriptController::contentOffsetY const):
3794
3795 2019-01-17  Truitt Savell  <tsavell@apple.com>
3796
3797         Unreviewed, rolling out r240124.
3798
3799         This commit broke an internal build.
3800
3801         Reverted changeset:
3802
3803         "SDK_VARIANT build destinations should be separate from non-
3804         SDK_VARIANT builds"
3805         https://bugs.webkit.org/show_bug.cgi?id=189553
3806         https://trac.webkit.org/changeset/240124
3807
3808 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3809
3810         Fix string concatenation API test after r239920
3811         https://bugs.webkit.org/show_bug.cgi?id=193551
3812         <rdar://problem/47359304>
3813
3814         Reviewed by Youenn Fablet.
3815
3816         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3817         (TestWebKitAPI::TEST):
3818         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3819         in WebKit's build configuration like it apparently is on Linux.
3820
3821 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3822
3823         [ews-build] validate-patch should handle the case when bug_id is None
3824         https://bugs.webkit.org/show_bug.cgi?id=193547
3825
3826         Reviewed by Lucas Forschler.
3827
3828         * BuildSlaveSupport/ews-build/steps.py:
3829         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3830         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3831
3832 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3833
3834         [ews-build] Add patch author information in build
3835         https://bugs.webkit.org/show_bug.cgi?id=193465
3836
3837         Reviewed by Lucas Forschler.
3838
3839         * BuildSlaveSupport/ews-build/steps.py:
3840         (ValidatePatch._is_patch_obsolete):
3841
3842 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3843
3844         [ews-build] Pass bug_id to the triggered builds
3845         https://bugs.webkit.org/show_bug.cgi?id=193548
3846
3847         Reviewed by Lucas Forschler.
3848
3849         * BuildSlaveSupport/ews-build/factories.py:
3850         (BuildFactory.propertiesToPassToTriggers):
3851
3852 2019-01-17  Jer Noble  <jer.noble@apple.com>
3853
3854         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3855         https://bugs.webkit.org/show_bug.cgi?id=189553
3856
3857         Reviewed by Tim Horton.
3858
3859         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3860
3861         * ContentExtensionTester/Configurations/Base.xcconfig:
3862         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3863         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3864         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3865         * ImageDiff/cg/Configurations/Base.xcconfig:
3866         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3867         * MiniBrowser/Configurations/Base.xcconfig:
3868         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3869         * MobileMiniBrowser/Configurations/Base.xcconfig:
3870         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3871         * Scripts/webkitpy/style/checker.py:
3872         (_all_categories):
3873         (FileType):
3874         (CheckerDispatcher._file_type):
3875         (CheckerDispatcher._create_checker):
3876         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3877         (SDKVariantChecker):
3878         (SDKVariantChecker.__init__):
3879         (SDKVariantChecker.check):
3880         * TestWebKitAPI/Configurations/Base.xcconfig:
3881         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3882         * WebEditingTester/Configurations/Base.xcconfig:
3883         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3884         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3885         * WebKitTestRunner/Configurations/Base.xcconfig:
3886         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3887         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3888         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3889
3890 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3891
3892         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3893         https://bugs.webkit.org/show_bug.cgi?id=193534
3894
3895         Reviewed by Antti Koivisto.
3896
3897         * LayoutReloaded/misc/LFC-passing-tests.txt:
3898
3899 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3900
3901         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3902         https://bugs.webkit.org/show_bug.cgi?id=193528
3903
3904         Reviewed by Antti Koivisto.
3905
3906         * LayoutReloaded/misc/LFC-passing-tests.txt:
3907
3908 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3909
3910         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3911         https://bugs.webkit.org/show_bug.cgi?id=193520
3912
3913         Reviewed by Antti Koivisto.
3914
3915         * LayoutReloaded/misc/LFC-passing-tests.txt:
3916
3917 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3918
3919         [ews-build] unapply-patch step should not update source
3920         https://bugs.webkit.org/show_bug.cgi?id=193234
3921
3922         Reviewed by Lucas Forschler.
3923
3924         * BuildSlaveSupport/ews-build/steps.py:
3925         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3926         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3927
3928 2019-01-16  Youenn Fablet  <youenn@apple.com>
3929
3930         Add a new SPI for controlling getUserMedia
3931         https://bugs.webkit.org/show_bug.cgi?id=192793
3932
3933         Reviewed by Eric Carlson.
3934
3935         * MiniBrowser/mac/WK2BrowserWindowController.m:
3936         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3937         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3938         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3939         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3940         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3941         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3942         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3943         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3944         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3945         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3946         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3947         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3948         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3949         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3950
3951 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3952
3953         [LFC][BFC] Inflow non-replaced used width should not be negative.
3954         https://bugs.webkit.org/show_bug.cgi?id=193495
3955
3956         Reviewed by Antti Koivisto.
3957
3958         * LayoutReloaded/misc/LFC-passing-tests.txt:
3959
3960 2019-01-16  Chris Dumez  <cdumez@apple.com>
3961
3962         Regression(PSON) View becomes blank after click a cross-site download link
3963         https://bugs.webkit.org/show_bug.cgi?id=193361
3964         <rdar://problem/47099573>
3965
3966         Reviewed by Geoffrey Garen.
3967
3968         Add API test coverage.
3969
3970         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3971         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3972
3973 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3974
3975         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3976         https://bugs.webkit.org/show_bug.cgi?id=193470
3977
3978         Reviewed by Antti Koivisto.
3979
3980         * LayoutReloaded/misc/LFC-passing-tests.txt:
3981
3982 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3983
3984         [LFC] Adjust margin box verification.
3985         https://bugs.webkit.org/show_bug.cgi?id=193482
3986
3987         Reviewed by Antti Koivisto.
3988
3989         * LayoutReloaded/misc/LFC-passing-tests.txt:
3990
3991 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3992
3993         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3994         https://bugs.webkit.org/show_bug.cgi?id=193451
3995
3996         Reviewed by Geoffrey Garen.
3997
3998         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3999         (TEST):
4000         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4001         (runWebsiteDataStoreCustomPaths):
4002
4003 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4004
4005         webkitpy: Support boolean simctl isAvailable
4006         https://bugs.webkit.org/show_bug.cgi?id=193472
4007         <rdar://problem/47296150>
4008
4009         Reviewed by Ryosuke Niwa.
4010
4011         * Scripts/webkitpy/xcode/simulated_device.py:
4012         (SimulatedDeviceManager._create_runtimes):
4013         (SimulatedDeviceManager._create_device_with_runtime):
4014
4015 2019-01-15  Chris Dumez  <cdumez@apple.com>
4016
4017         Unreviewed, rolling out r239993, r239995, r239997, and
4018         r239999.
4019
4020         Caused assertions under
4021         ViewGestureController::disconnectFromProcess()
4022
4023         Reverted changesets:
4024
4025         "Regression(PSON) View becomes blank after click a cross-site
4026         download link"
4027         https://bugs.webkit.org/show_bug.cgi?id=193361
4028         https://trac.webkit.org/changeset/239993
4029
4030         "Unreviewed iOS build fix after r239993."
4031         https://trac.webkit.org/changeset/239995
4032
4033         "Fix iOS build after r239993"
4034         https://bugs.webkit.org/show_bug.cgi?id=193361
4035         https://trac.webkit.org/changeset/239997
4036
4037         "Unreviewed, revert part of r239997 as it is not needed to fix
4038         the build."
4039         https://trac.webkit.org/changeset/239999
4040
4041 2019-01-15  Tim Horton  <timothy_horton@apple.com>
4042
4043         Cannot tab out of WKWebView on macOS
4044         https://bugs.webkit.org/show_bug.cgi?id=161448
4045         <rdar://problem/28100085>
4046
4047         Reviewed by Dean Jackson.
4048
4049         Add a test that tabbing into and out of WKWebView works correctly.
4050
4051         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4052         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
4053         (WebKit2_CommandBackForwardTest::SetUp):
4054         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
4055         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
4056         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
4057         (-[FocusableView canBecomeKeyView]):
4058         (TEST):
4059         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
4060         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
4061         (-[OffscreenWindow initWithSize:]):
4062         (-[OffscreenWindow isKeyWindow]):
4063         (-[OffscreenWindow isVisible]):
4064         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4065         (TestWebKitAPI::PlatformWebView::initialize):
4066         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
4067         (-[ActiveOffscreenWindow isVisible]): Deleted.
4068         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
4069
4070 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
4071
4072         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
4073         https://bugs.webkit.org/show_bug.cgi?id=193459
4074
4075         Reviewed by Mark Lam.
4076
4077         * BuildSlaveSupport/build.webkit.org-config/steps.py:
4078         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
4079
4080 2019-01-15  Chris Dumez  <cdumez@apple.com>
4081
4082         Regression(PSON) View becomes blank after click a cross-site download link
4083         https://bugs.webkit.org/show_bug.cgi?id=193361
4084         <rdar://problem/47099573>
4085
4086         Reviewed by Geoff Garen.
4087
4088         Add API test coverage.
4089
4090         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4091         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4092
4093 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4094
4095         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
4096         https://bugs.webkit.org/show_bug.cgi?id=193448
4097
4098         Reviewed by Antti Koivisto.
4099
4100         * LayoutReloaded/misc/LFC-passing-tests.txt:
4101
4102 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4103
4104         webkitpy: Implement device type specific expected results (Part 1)
4105         https://bugs.webkit.org/show_bug.cgi?id=192162
4106
4107         Reviewed by Lucas Forschler.
4108
4109         Device type specific expected results covers two related ideas. The first (covered by this change)
4110         is where to search for -expected.* files. The second is which tests to run based on the
4111         TestExpectations.txt file.
4112
4113         After this change, the baseline search path will be determined by the type of device running a
4114         test. Device type will be passed into any function which picks a file based on the baseline search
4115         path.
4116
4117         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4118         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
4119         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4120         (Manager.run): Print baseline search path for each round of devices.
4121         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
4122         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
4123         (SingleTestRunner._expected_driver_output): Ditto.
4124         (SingleTestRunner._driver_input): Ditto.
4125         * Scripts/webkitpy/layout_tests/views/printing.py:
4126         (Printer.print_config): Move printing of baseline search path to a separate function.
4127         (Printer.print_baseline_search_path): Moved from Printer.print_config.
4128         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4129         (Testprinter.test_print_config):
4130         (Testprinter.test_print_baseline_search_path):
4131         * Scripts/webkitpy/port/base.py:
4132         (Port.baseline_search_path): Pass device_type through.
4133         (Port._expected_baselines_for_suffixes): Ditto.
4134         (Port.expected_baselines): Ditto.
4135         (Port.expected_filename): Ditto.
4136         (Port.expected_checksum): Ditto.
4137         (Port.expected_image): Ditto.
4138         (Port.expected_audio): Ditto.
4139         (Port.expected_text): Ditto.
4140         (Port.reference_files): Ditto.
4141         (Port.tests): Ditto.
4142         (Port._expanded_paths): Ditto.
4143         (Port.skipped_layout_tests): Ditto.
4144         (Port.expectations_dict): Ditto.
4145         (Port._port_specific_expectations_files): Ditto.
4146         (Port.expectations_files): Ditto.
4147         (Port.test_search_path): Ditto.
4148         (Port._tests_for_other_platforms): Ditto.
4149         * Scripts/webkitpy/port/base_unittest.py:
4150         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
4151         (PortTest.test_nonexistant_expectations): Ditto.
4152         (test_ref_tests_platform_directory): Ditto.
4153         * Scripts/webkitpy/port/darwin.py:
4154         (DarwinPort._port_specific_expectations_files): Accept device_type.
4155         * Scripts/webkitpy/port/driver.py:
4156         (DriverProxy):
4157         (DriverProxy.host): Expose _target_host for device_type information.
4158         * Scripts/webkitpy/port/gtk.py:
4159         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
4160         * Scripts/webkitpy/port/ios.py:
4161         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4162         * Scripts/webkitpy/port/mac.py:
4163         (MacPort. default_baseline_search_path): Ditto.
4164         * Scripts/webkitpy/port/port_testcase.py:
4165         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
4166         * Scripts/webkitpy/port/test.py:
4167         * Scripts/webkitpy/port/watch.py:
4168         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4169         * Scripts/webkitpy/port/win.py:
4170         (WinPort.test_search_path): Accept, but do not use, device_type.
4171         * Scripts/webkitpy/port/wpe.py:
4172         (WPEPort._port_specific_expectations_files): Ditto.
4173         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
4174         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
4175
4176 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4177
4178         [LFC] Use the containing block's padding box to position out-of-flow elements.
4179         https://bugs.webkit.org/show_bug.cgi?id=193431
4180
4181         Reviewed by Antti Koivisto.
4182
4183         * LayoutReloaded/misc/LFC-passing-tests.txt:
4184
4185 2019-01-14  Tim Horton  <timothy_horton@apple.com>
4186
4187         Move a test implementation file that got misplaced in the Xcode project
4188
4189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4190
4191 2019-01-14  Commit Queue  <commit-queue@webkit.org>
4192
4193         Unreviewed, rolling out r239901, r239909, r239910, r239912,
4194         r239913, and r239914.
4195         https://bugs.webkit.org/show_bug.cgi?id=193407
4196
4197         These revisions caused an internal failure (Requested by
4198         Truitt on #webkit).
4199
4200         Reverted changesets:
4201
4202         "[Cocoa] Avoid importing directly from subumbrella frameworks"
4203         https://bugs.webkit.org/show_bug.cgi?id=186016
4204         https://trac.webkit.org/changeset/239901
4205
4206         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
4207         https://trac.webkit.org/changeset/239909
4208
4209         "Tried to fix the build."
4210         https://trac.webkit.org/changeset/239910
4211
4212         "Fixed iOS builds after r239910."
4213         https://trac.webkit.org/changeset/239912
4214
4215         "More build fixing."
4216         https://trac.webkit.org/changeset/239913
4217
4218         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
4219         https://trac.webkit.org/changeset/239914
4220
4221 2019-01-14  Mark Lam  <mark.lam@apple.com>
4222
4223         Re-enable ability to build --cloop builds.
4224         https://bugs.webkit.org/show_bug.cgi?id=192955
4225         <rdar://problem/46882363>
4226
4227         Reviewed by Saam barati and Keith Miller.
4228
4229         The --cloop build option was being ignored this whole time since r236381.
4230         This patch makes it possible to build CLoop builds again.
4231
4232         * Scripts/build-jsc:
4233         * Scripts/webkitperl/FeatureList.pm:
4234         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4235
4236 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4237
4238         webkitpy: Expose device_type from host-like objects
4239         https://bugs.webkit.org/show_bug.cgi?id=193406
4240         <rdar://problem/47262305>
4241
4242         Reviewed by Lucas Forschler.
4243
4244         Devices should expose device_type. As a result, all host objects should
4245         provide a device_type property, even if they do not yet define a device_type.
4246
4247         * Scripts/webkitpy/common/system/systemhost.py:
4248         (SystemHost):
4249         (SystemHost.device_type):
4250         * Scripts/webkitpy/common/system/systemhost_mock.py:
4251         (MockSystemHost):
4252         (MockSystemHost.device_type):
4253         * Scripts/webkitpy/port/device.py:
4254         (Device):
4255         (Device.device_type):
4256         * Scripts/webkitpy/xcode/simulated_device.py:
4257         (SimulatedDeviceManager._find_exisiting_device_for_request):
4258         (SimulatedDeviceManager._disambiguate_device_type):
4259         (SimulatedDeviceManager._does_fulfill_request):
4260         (SimulatedDeviceManager.device_count_for_type):
4261         (SimulatedDeviceManager.initialize_devices):
4262         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
4263         (test_available_devices):
4264         (test_swapping_devices):
4265
4266 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4267
4268         webkitpy: Support alternate simctl device list output (Follow-up fix)
4269         https://bugs.webkit.org/show_bug.cgi?id=193362
4270         <rdar://problem/47122965>
4271
4272         Rubber-stamped by Lucas Forschler.
4273
4274         * Scripts/webkitpy/xcode/simulated_device.py:
4275         (SimulatedDeviceManager.populate_available_devices):
4276
4277 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
4278
4279         [iOS] Expose SPI to access the current sentence boundary and selection state
4280         https://bugs.webkit.org/show_bug.cgi?id=193398
4281         <rdar://problem/45893108>
4282
4283         Reviewed by Dean Jackson.
4284
4285         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
4286         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
4287         expected.
4288
4289         * TestWebKitAPI/EditingTestHarness.h:
4290         * TestWebKitAPI/EditingTestHarness.mm:
4291         (-[EditingTestHarness moveBackward]):
4292         (-[EditingTestHarness moveForward]):
4293         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
4294
4295         Add a couple of new helper methods on EditingTestHarness.
4296
4297         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
4298         (-[SelectionChangeObserver initWithWebView:]):
4299         (-[SelectionChangeObserver webView]):
4300         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
4301         (-[SelectionChangeObserver currentSelectionAttributes]):
4302
4303 2019-01-14  Zalan Bujtas  <zalan@apple.com>
4304
4305         [LFC][BFC] Add basic box-sizing support.
4306         https://bugs.webkit.org/show_bug.cgi?id=193392
4307
4308         Reviewed by Antti Koivisto.
4309
4310         * LayoutReloaded/misc/LFC-passing-tests.txt:
4311
4312 2019-01-14  Charlie Turner  <cturner@igalia.com>
4313
4314         [WPE] API test gardening
4315         https://bugs.webkit.org/show_bug.cgi?id=193319
4316
4317         Reviewed by Michael Catanzaro.
4318
4319         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
4320         passing tests.
4321
4322 2019-01-14  Charlie Turner  <cturner@igalia.com>
4323
4324         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
4325         https://bugs.webkit.org/show_bug.cgi?id=192977
4326
4327         Reviewed by Carlos Garcia Campos.
4328
4329         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
4330         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
4331         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
4332         (TestWebKitAPI::GStreamerTest::SetUp):
4333         (TestWebKitAPI::GStreamerTest::TearDown):
4334         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
4335         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.