[ews-app] Fetch builder id to name mapping
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] Fetch builder id to name mapping
4         https://bugs.webkit.org/show_bug.cgi?id=194355
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
9         (Buildbot.get_builder_id_to_name_mapping):
10         (Buildbot._get_display_name_from_builder_name):
11
12 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
13
14         Further restricting webarchive loads
15         https://bugs.webkit.org/show_bug.cgi?id=194567
16         <rdar://problem/47610130>
17
18         Reviewed by Youenn Fablet.
19
20         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
21         navigations on drop.
22
23         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
25         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
26         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
27         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
28         (TestWebKitAPI::TEST):
29         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
30         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
31         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
32         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
33         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
34         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
35         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
36
37 2019-02-13  John Wilander  <wilander@apple.com>
38
39         Store Ad Click Attribution requests in the network process
40         https://bugs.webkit.org/show_bug.cgi?id=194510
41         <rdar://problem/47650118>
42
43         Reviewed by Alex Christensen and Daniel Bates.
44
45         This patch adds two TestRunner functions:
46         - dumpAdClickAttribution()
47         - clearAdClickAttribution()
48
49         They call into the network process to dump and clear Ad Click
50         Attribution state, respectively.
51
52         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
53         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
54         (WTR::TestRunner::dumpAdClickAttribution):
55         (WTR::TestRunner::clearAdClickAttribution):
56         * WebKitTestRunner/InjectedBundle/TestRunner.h:
57         * WebKitTestRunner/TestController.cpp:
58         (WTR::TestController::resetStateToConsistentValues):
59         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
60         (WTR::adClickAttributionStringResultCallback):
61         (WTR::TestController::dumpAdClickAttribution):
62         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
63         (WTR::adClickAttributionVoidCallback):
64         (WTR::TestController::clearAdClickAttribution):
65         * WebKitTestRunner/TestController.h:
66         * WebKitTestRunner/TestInvocation.cpp:
67         (WTR::TestInvocation::dumpResults):
68         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
69         (WTR::TestInvocation::dumpAdClickAttribution):
70         * WebKitTestRunner/TestInvocation.h:
71
72 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
73
74         [ews-app] Generate status-bubble
75         https://bugs.webkit.org/show_bug.cgi?id=194572
76
77         Reviewed by Lucas Forschler.
78
79         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
80         (StatusBubble._build_bubble):
81         (StatusBubble._should_show_bubble_for):
82         (StatusBubble._build_bubbles_for_patch):
83
84 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
85
86         [ews-app] Add status bubble html template
87         https://bugs.webkit.org/show_bug.cgi?id=194571
88
89         Reviewed by Lucas Forschler.
90
91         * BuildSlaveSupport/ews-app/ews/templates: Added.
92         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
93
94 2019-02-12  Chris Dumez  <cdumez@apple.com>
95
96         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
97         https://bugs.webkit.org/show_bug.cgi?id=194568
98         <rdar://problem/47944490>
99
100         Reviewed by Ryosuke Niwa.
101
102         Add API test coverage.
103
104         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
105         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
106
107 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
108
109         webkitpy: Remove bug_dummy from parsed test expectations
110         https://bugs.webkit.org/show_bug.cgi?id=194562
111         <rdar://problem/47853999>
112
113         Reviewed by Lucas Forschler.
114
115         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
116         (TestExpectationParser):
117         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
118         skipped tests.
119         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
120
121 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
122
123         [ews-app] Add method to fetch patch
124         https://bugs.webkit.org/show_bug.cgi?id=194518
125
126         Reviewed by Lucas Forschler.
127
128         * BuildSlaveSupport/ews-app/ews/models/patch.py:
129         (Patch.get_patch):
130
131 2019-02-12  Zalan Bujtas  <zalan@apple.com>
132
133         [LFC] Expand tests coverage (60 new tests -> 860)
134
135         Unreviewed test gardening (run-singly, --child-processes=1).
136
137         * LayoutReloaded/misc/LFC-passing-tests.txt:
138
139 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
140
141         Allow pages to trigger programmatic paste from script on iOS
142         https://bugs.webkit.org/show_bug.cgi?id=194271
143         <rdar://problem/47808810>
144
145         Reviewed by Tim Horton.
146
147         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
148
149         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
150         (WTR::UIScriptController::platformSetDidShowMenuCallback):
151         (WTR::UIScriptController::platformSetDidHideMenuCallback):
152         (WTR::UIScriptController::rectForMenuAction const):
153
154         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
155         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
156         for when the menu is shown or hidden.
157
158         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
159         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
160         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
161         (WTR::UIScriptController::setDidShowMenuCallback):
162         (WTR::UIScriptController::didShowMenuCallback const):
163         (WTR::UIScriptController::setDidHideMenuCallback):
164         (WTR::UIScriptController::didHideMenuCallback const):
165         (WTR::UIScriptController::platformSetDidShowMenuCallback):
166         (WTR::UIScriptController::platformSetDidHideMenuCallback):
167         (WTR::UIScriptController::rectForMenuAction const):
168         * TestRunnerShared/UIScriptContext/UIScriptController.h:
169         * WebKitTestRunner/TestController.cpp:
170         (WTR::TestController::resetPreferencesToConsistentValues):
171         (WTR::updateTestOptionsFromTestHeader):
172         * WebKitTestRunner/TestOptions.h:
173
174         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
175         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
176
177         (WTR::TestOptions::hasSameInitializationOptions const):
178         * WebKitTestRunner/UIScriptControllerCocoa.mm:
179         (WTR::UIScriptController::calendarType const):
180         (WTR::UIScriptController::platformUndoManager const):
181         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
182         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
183         (-[TestRunnerWKWebView initWithFrame:configuration:]):
184         (-[TestRunnerWKWebView dealloc]):
185         (-[TestRunnerWKWebView _didShowMenu]):
186         (-[TestRunnerWKWebView _didHideMenu]):
187
188         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
189
190         * WebKitTestRunner/ios/TestControllerIOS.mm:
191         (WTR::handleMenuWillHideNotification):
192         (WTR::handleMenuDidHideNotification):
193         (WTR::TestController::platformInitialize):
194         (WTR::TestController::platformDestroy):
195         (WTR::TestController::platformResetStateToConsistentValues):
196
197         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
198         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
199
200         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
201         (WTR::forEachViewInHierarchy):
202         (WTR::findViewInHierarchyOfType):
203
204         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
205         functions that dig through a given view's hierarchy in search of a view of a given class.
206
207         (WTR::UIScriptController::selectionStartGrabberViewRect const):
208         (WTR::UIScriptController::selectionEndGrabberViewRect const):
209         (WTR::UIScriptController::selectionCaretViewRect const):
210         (WTR::UIScriptController::selectionRangeViewRects const):
211         (WTR::UIScriptController::platformSetDidShowMenuCallback):
212         (WTR::UIScriptController::platformSetDidHideMenuCallback):
213
214         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
215
216         (WTR::UIScriptController::rectForMenuAction const):
217
218         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
219         callout bar) whose label matches the given string.
220
221         (WTR::UIScriptController::platformContentView const):
222
223         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
224         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
225         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
226
227         (WTR::UIScriptController::platformUndoManager const): Deleted.
228         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
229         (WTR::UIScriptController::platformContentView const):
230         (WTR::UIScriptController::platformUndoManager const): Deleted.
231
232 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
233
234         webkitpy: No option to only show unexpected failures in results.html for iPad
235         https://bugs.webkit.org/show_bug.cgi?id=194554
236         <rdar://problem/47922442>
237
238         Rubber-stamped by Aakash Jain.
239
240         Just because a TestExpecations file does not exist for a specific platform does not mean that
241         TestExpecations are not being used, given that platforms inherit test expectations.
242
243         * Scripts/webkitpy/port/base.py:
244         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
245         * Scripts/webkitpy/port/base_unittest.py:
246         (PortTest.test_uses_test_expectations_file):
247
248 2019-02-12  Alex Christensen  <achristensen@webkit.org>
249
250         Remove setDefersLoading infrastructure from WebKit2
251         https://bugs.webkit.org/show_bug.cgi?id=194506
252
253         Reviewed by Brady Eidson.
254
255         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
256         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
257         (WTR::TestRunner::setDefersLoading): Deleted.
258         * WebKitTestRunner/InjectedBundle/TestRunner.h:
259
260 2019-02-12  Alex Christensen  <achristensen@webkit.org>
261
262         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
263         https://bugs.webkit.org/show_bug.cgi?id=194522
264         <rdar://problem/47789393>
265
266         Reviewed by Chris Dumez.
267
268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
269         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
270         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
271         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
272
273 2019-02-12  Andy Estes  <aestes@apple.com>
274
275         [iOSMac] Enable Parental Controls Content Filtering
276         https://bugs.webkit.org/show_bug.cgi?id=194521
277         <rdar://39732376>
278
279         Reviewed by Tim Horton.
280
281         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
282
283 2019-02-12  Zalan Bujtas  <zalan@apple.com>
284
285         [LFC][IFC] Add intrinsic width support for float boxes.
286         https://bugs.webkit.org/show_bug.cgi?id=194528
287
288         Reviewed by Antti Koivisto.
289
290         Expand tests coverage (2 new tests -> 800).
291         (This is the correct test ordering --runs-singly --child-processes=1)
292
293         * LayoutReloaded/misc/LFC-passing-tests.txt:
294
295 2019-02-12  Rob Buis  <rbuis@igalia.com>
296
297         Implement serializing in MIME type parser
298         https://bugs.webkit.org/show_bug.cgi?id=193909
299
300         Reviewed by Darin Adler.
301
302         Add various tests involving upper case, non-ASCII, control/null characters,
303         various HTTP whitespace, single quotes and an unpaired surrogate.
304
305         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
306         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
307         (TestWebKitAPI::serializeIfValid):
308         (TestWebKitAPI::TEST):
309
310 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
311
312         [Cocoa] Ask platform for generic font family mappings
313         https://bugs.webkit.org/show_bug.cgi?id=187723
314         <rdar://problem/41892438>
315
316         Reviewed by Brent Fulgham.
317
318         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
319
320         * DumpRenderTree/mac/DumpRenderTree.mm:
321         (allowedFontFamilySet):
322         * WebKitTestRunner/mac/TestControllerMac.mm:
323         (WTR::allowedFontFamilySet):
324
325 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
326
327         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
328         https://bugs.webkit.org/show_bug.cgi?id=193622
329
330         Reviewed by Michael Catanzaro.
331
332         This adds support for loading content extension rule sets from the JSON files which
333         accompany the corresponding layout test, using the C API. The Cocoa specific parts
334         of WKTR for this could be removed, but that is left for a follow-up patch with
335         cleanups.
336
337         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
338         * WebKitTestRunner/TestController.cpp:
339         (WTR::testPath): Subtract one from the length when constructing the result std::string to
340         avoid having the null-terminator copied into the result.
341         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
342         part of the preparations to run a test.
343         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
344         (WTR::contentExtensionStoreCallback): Added.
345         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
346         used for content extensions test.
347         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
348         extensions and compiling the JSON rule set for tests involving content extensions.
349         (WTR::TestController::resetContentExtensions): Removes the content extension built for
350         testing and disables content extensions.
351         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
352         resetContentExtensions().
353         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
354         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
355         configureContentExtensionForTest(), and userContentController().
356
357 2019-02-11  Daniel Bates  <dabates@apple.com>
358
359         [iOS] Mouse/Touch/Pointer events are missing modifier keys
360         https://bugs.webkit.org/show_bug.cgi?id=191446
361         <rdar://problem/45929460>
362
363         Reviewed by Tim Horton.
364
365         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
366
367         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
368         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
369         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
370         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
371         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
372         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
373         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
374         * TestRunnerShared/UIScriptContext/UIScriptController.h:
375         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
376         (WTR::arrayLength):
377         (WTR::parseModifierArray):
378         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
379         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
380         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
381         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
382
383 2019-02-11  Commit Queue  <commit-queue@webkit.org>
384
385         Unreviewed, rolling out r241272 and r241276.
386         https://bugs.webkit.org/show_bug.cgi?id=194514
387
388         Broke the Apple Internal build and the fix requires human
389         intervention :( (Requested by dydz on #webkit).
390
391         Reverted changesets:
392
393         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
394         https://bugs.webkit.org/show_bug.cgi?id=191446
395         https://trac.webkit.org/changeset/241272
396
397         "Fix internal iOS build after r241272"
398         https://bugs.webkit.org/show_bug.cgi?id=191446
399         https://trac.webkit.org/changeset/241276
400
401 2019-02-11  Truitt Savell  <tsavell@apple.com>
402
403         Unreviewed, rolling out r241269.
404
405         Caused 5 layout tests crashes on Mac WK1
406
407         Reverted changeset:
408
409         "DumpRenderTree should report unknown options"
410         https://bugs.webkit.org/show_bug.cgi?id=191303
411         https://trac.webkit.org/changeset/241269
412
413 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
414
415         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
416         https://bugs.webkit.org/show_bug.cgi?id=194313
417
418         Reviewed by Tim Horton.
419
420         Add a helper to determine whether the web view is presenting modal UI.
421
422         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
423         (WTR::UIScriptController::isPresentingModally const):
424         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
425         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
426         (WTR::UIScriptController::isPresentingModally const):
427         * TestRunnerShared/UIScriptContext/UIScriptController.h:
428         * WebKitTestRunner/UIScriptControllerCocoa.mm:
429         (WTR::UIScriptController::calendarType const): Deleted.
430         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
431         (WTR::UIScriptController::isPresentingModally const):
432         (WTR::UIScriptController::calendarType const):
433         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
434         (WTR::UIScriptController::calendarType const):
435
436 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
437
438         GCHeapInspector: Show the retained sizes in more places
439         https://bugs.webkit.org/show_bug.cgi?id=194464
440
441         Reviewed by Simon Fraser.
442
443         * GCHeapInspector/gc-heap-inspector.html:
444         * GCHeapInspector/script/interface.js:
445         (HeapInspectorUtils.humanReadableSize):
446         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
447         (HeapInspectorUtils.spanForNode.span.span):
448         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
449         (HeapSnapshotInspector.prototype.buildRoots):
450
451 2019-02-11  Daniel Bates  <dabates@apple.com>
452
453         [iOS] Mouse/Touch/Pointer events are missing modifier keys
454         https://bugs.webkit.org/show_bug.cgi?id=191446
455         <rdar://problem/45929460>
456
457         Reviewed by Tim Horton.
458
459         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
460
461         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
462         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
463         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
464         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
465         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
466         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
467         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
468         * TestRunnerShared/UIScriptContext/UIScriptController.h:
469         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
470         (WTR::arrayLength):
471         (WTR::parseModifierArray):
472         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
473         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
474         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
475         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
476
477 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
478
479         DumpRenderTree should report unknown options
480         https://bugs.webkit.org/show_bug.cgi?id=191303
481
482         Reviewed by Frédéric Wang.
483
484         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
485         to report unknown options.
486         Added and assigned test options which are currently used in tests.
487
488         * DumpRenderTree/TestOptions.cpp:
489         (TestOptions::TestOptions):
490
491 2019-02-11  Truitt Savell  <tsavell@apple.com>
492
493         Unreviewed, rolling out r241229.
494
495         Revision broke internal builds for watchOS.
496
497         Reverted changeset:
498
499         "[Cocoa] Ask platform for generic font family mappings"
500         https://bugs.webkit.org/show_bug.cgi?id=187723
501         https://trac.webkit.org/changeset/241229
502
503 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
504
505         [WinCairo][MiniBrowser] Basic authentication always fails.
506         https://bugs.webkit.org/show_bug.cgi?id=194496
507
508         Reviewed by Don Olmstead.
509
510         * MiniBrowser/win/DialogHelper.h:
511         (Dialog::getText):
512
513 2019-02-11  Philippe Normand  <pnormand@igalia.com>
514
515         [GStreamer] GstMappedBuffer testsuite build fails
516         https://bugs.webkit.org/show_bug.cgi?id=194495
517
518         Reviewed by Carlos Garcia Campos.
519
520         Fix the build by explicitely adding the gstreamer1.0-audio include
521         directories to the include path.
522
523         * TestWebKitAPI/PlatformGTK.cmake:
524         * TestWebKitAPI/PlatformWPE.cmake:
525
526 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
527
528         [GTK][WPE] Add enable-javascript-markup setting
529         https://bugs.webkit.org/show_bug.cgi?id=193439
530
531         Reviewed by Michael Catanzaro.
532
533         Add test cases to check the new setting.
534
535         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
536         (testWebKitSettings):
537         (testWebKitSettingsJavaScriptMarkup):
538         (beforeAll):
539
540 2019-02-10  Darin Adler  <darin@apple.com>
541
542         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
543         https://bugs.webkit.org/show_bug.cgi?id=194485
544
545         Reviewed by Daniel Bates.
546
547         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
548
549 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
550
551         Add more tests for clampTo<>()
552         https://bugs.webkit.org/show_bug.cgi?id=194462
553
554         Reviewed by Geoffrey Garen.
555
556         Darin suggested to test the very last floating point number
557         at the boundaries when truncating to integer.
558         I added test for max/min and max-1/min-1.
559
560         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
561         (TestWebKitAPI::TEST):
562
563 2019-02-09  Darin Adler  <darin@apple.com>
564
565         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
566         https://bugs.webkit.org/show_bug.cgi?id=194021
567
568         Reviewed by Geoffrey Garen.
569
570         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
571         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
572         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
573
574 2019-02-09  Zalan Bujtas  <zalan@apple.com>
575
576         [LFC][IFC] Add intrinsic width support for basic inline containers
577         https://bugs.webkit.org/show_bug.cgi?id=194473
578
579         Reviewed by Antti Koivisto.
580
581         Expand tests coverage (11 new tests -> 798)
582
583         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
584
585 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
586
587         Fix MiniBrowser's entitlements
588         https://bugs.webkit.org/show_bug.cgi?id=192431
589
590         Reviewed by Joseph Pecoraro.
591
592         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
593         files, making it impossible to load any extension.
594
595         * MiniBrowser/MiniBrowser.entitlements:
596
597 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
598
599         [Cocoa] Ask platform for generic font family mappings
600         https://bugs.webkit.org/show_bug.cgi?id=187723
601         <rdar://problem/41892438>
602
603         Reviewed by Brent Fulgham.
604
605         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
606
607         * DumpRenderTree/mac/DumpRenderTree.mm:
608         (allowedFontFamilySet):
609         * WebKitTestRunner/mac/TestControllerMac.mm:
610         (WTR::allowedFontFamilySet):
611
612 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
613
614         [GTK] Implement back/forward touchpad gesture
615         https://bugs.webkit.org/show_bug.cgi?id=193919
616
617         Reviewed by Michael Catanzaro.
618
619         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
620         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
621
622 2019-02-08  Alex Christensen  <achristensen@webkit.org>
623
624         Add SPI to use networking daemon instead of XPC service
625         https://bugs.webkit.org/show_bug.cgi?id=194427
626
627         Reviewed by Geoffrey Garen
628
629         * MiniBrowser/MiniBrowser.entitlements:
630
631 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
632
633         [ews-build] Ensure that every builder in config.json has short name
634         https://bugs.webkit.org/show_bug.cgi?id=194461
635
636         Reviewed by Lucas Forschler.
637
638         * BuildSlaveSupport/ews-build/loadConfig.py:
639         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
640
641 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
642
643         [ews-build] Add short name to config.json
644         https://bugs.webkit.org/show_bug.cgi?id=194456
645
646         Reviewed by Lucas Forschler.
647
648         * BuildSlaveSupport/ews-build/config.json: Added short name.
649         * BuildSlaveSupport/ews-build/loadConfig.py:
650         (loadBuilderConfig): Set the short name as the builder description.
651
652 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
653
654         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
655         https://bugs.webkit.org/show_bug.cgi?id=194418
656
657         Reviewed by Lucas Forschler.
658
659         Do not include errors trying when finding crashlogs at the end of
660         a run-webkit-tests run since we don't process those errors.
661
662         * Scripts/webkitpy/port/darwin.py:
663         (DarwinPort._look_for_all_crash_logs_in_log_dir):
664         * Scripts/webkitpy/port/ios_device.py:
665         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
666         * Scripts/webkitpy/port/watch_device.py:
667         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
668
669 2019-02-08  Beth Dakin  <bdakin@apple.com>
670
671         Add afterScreenUpdates to WKSnapshotConfiguration
672         https://bugs.webkit.org/show_bug.cgi?id=194362
673         -and corresponding-
674         <rdar://problem/40655528> Please add an "after screen updates" property to 
675         WKSnapshotConfiguration (to solve blank snapshots)
676
677         Reviewed by Tim Horton.
678
679         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
680         (TEST):
681
682 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
683
684         clampTo(): do not convert the input to double when dealing with integers
685         https://bugs.webkit.org/show_bug.cgi?id=194263
686         <rdar://problem/47692312>
687
688         Reviewed by Darin Adler.
689
690         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
691         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
692         (TestWebKitAPI::testClampFloatingPointToInteger):
693         (TestWebKitAPI::testClampSameSignIntegers):
694         (TestWebKitAPI::testClampUnsignedToSigned):
695         (TestWebKitAPI::testClampSignedToUnsigned):
696
697 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
698
699         webkitpy: Respect --dedicated-simulators flag
700         https://bugs.webkit.org/show_bug.cgi?id=194416
701         <rdar://problem/47894722>
702
703         Reviewed by Lucas Forschler.
704
705         * Scripts/webkitpy/port/device_port.py:
706         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
707         available devices can be safely ignored.
708
709 2019-02-07  Keith Rollin  <krollin@apple.com>
710
711         Remove extra copy of 100x100-red.tga
712         https://bugs.webkit.org/show_bug.cgi?id=194371
713         <rdar://problem/47873465>
714
715         Reviewed by Said Abou-Hallawa.
716
717         In order to help it pass its tests, Bug 194190 added a second copy of
718         the file 100x100-red.tga. However, it turns out that this additional
719         file wasn't actually needed, and that that sole previous copy was
720         sufficient. At the same time, this second copy -- which was copied to
721         the same location in the build output as the first copy -- now caused
722         XCBuild to complain because there were two production rules for the
723         same output file. Address this by removing the newly-added extra copy.
724
725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
726         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
727
728 2019-02-07  Alex Christensen  <achristensen@webkit.org>
729
730         Deprecate WKBundlePageSetDefersLoading
731         https://bugs.webkit.org/show_bug.cgi?id=191394
732
733         Reviewed by Dean Jackson.
734
735         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
736         (WTR::TestRunner::setDefersLoading):
737
738 2019-02-07  Zalan Bujtas  <zalan@apple.com>
739
740         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
741         https://bugs.webkit.org/show_bug.cgi?id=194391
742
743         Reviewed by Antti Koivisto.
744
745         * LayoutReloaded/misc/LFC-passing-tests.txt:
746
747 2019-02-06  Keith Rollin  <krollin@apple.com>
748
749         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
750         https://bugs.webkit.org/show_bug.cgi?id=193975
751         <rdar://problem/47643306>
752
753         Reviewed by Tim Horton.
754
755         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
756         the Info.plist file into the bundle. This step is not necessary as the
757         implicit "bundle up all the build products into a framework" build
758         phase does this already. Having the Copy Bundle Resources phase do
759         this causes a conflict under XCBuild, which objects to two build
760         phases producing the same file (Info.plist). Address this by removing
761         Info.plist from the Copy Bundle Resources phase.
762
763         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
764
765 2019-02-06  Keith Rollin  <krollin@apple.com>
766
767         Really enable the automatic checking and regenerations of .xcfilelists during builds
768         https://bugs.webkit.org/show_bug.cgi?id=194357
769         <rdar://problem/47861231>
770
771         Reviewed by Chris Dumez.
772
773         Bug 194124 was supposed to enable the automatic checking and
774         regenerating of .xcfilelist files during the build. While related
775         changes were included in that patch, the change to actually enable the
776         operation somehow was omitted. This patch actually enables the
777         operation. The check-xcfilelist.sh scripts now check
778         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
779         from the checking.
780
781         * DumpRenderTree/Scripts/check-xcfilelists.sh:
782         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
783
784 2019-02-06  David Kilzer  <ddkilzer@apple.com>
785
786         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
787         <https://webkit.org/b/194286>
788         <rdar://problem/47815558>
789
790         Reviewed by Alexey Proskuryakov.
791
792         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
793         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
794         WKRetainPtr<> to avoid leaking the WKDataRef.
795
796 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
797
798         Unreviewed, fix a typo
799
800         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
801
802 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
803
804         [GTK][WPE] force libpsl build to use ICU in jhbuild
805         https://bugs.webkit.org/show_bug.cgi?id=194288
806
807         Reviewed by Carlos Garcia Campos.
808
809         * gtk/jhbuild.modules:
810         Require ICU for libpsl build in jhbuild, like done in WPE.
811
812 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
813
814         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
815         https://bugs.webkit.org/show_bug.cgi?id=194209
816
817         Reviewed by Carlos Garcia Campos.
818
819         Enhance TestCookieManager to ensure this doesn't happen again.
820
821         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
822         (testCookieManagerPersistentStorage):
823         (beforeAll):
824
825 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
826
827         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
828         https://bugs.webkit.org/show_bug.cgi?id=194324
829
830         Reviewed by Andy Estes.
831
832         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
833         part of the name is already implicit, since this is in testing code in TestOptions.
834
835         * WebKitTestRunner/TestController.cpp:
836         (WTR::TestController::generateContextConfiguration const):
837         (WTR::updateTestOptionsFromTestHeader):
838         * WebKitTestRunner/TestOptions.h:
839         (WTR::TestOptions::hasSameInitializationOptions const):
840
841 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
842
843         [ews-build] Allow * as platform for builders and workers
844         https://bugs.webkit.org/show_bug.cgi?id=188533
845
846         Reviewed by Lucas Forschler.
847
848         * BuildSlaveSupport/ews-build/loadConfig.py:
849         (checkWorkersAndBuildersForConsistency):
850
851 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
852
853         [ews-build] Add few bots to config.json
854         https://bugs.webkit.org/show_bug.cgi?id=194304
855
856         Reviewed by Lucas Forschler.
857
858         * BuildSlaveSupport/ews-build/config.json:
859
860 2019-02-05  Keith Rollin  <krollin@apple.com>
861
862         Enable the automatic checking and regenerations of .xcfilelists during builds
863         https://bugs.webkit.org/show_bug.cgi?id=194124
864         <rdar://problem/47721277>
865
866         Reviewed by Tim Horton.
867
868         Bug 193790 add a facility for checking -- during build time -- that
869         any needed .xcfilelist files are up-to-date and for updating them if
870         they are not. This facility was initially opt-in by setting
871         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
872         the process seemed robust. Its now time to enable this facility and
873         make it opt-out. If there is a need to disable this facility, set and
874         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
875         running `make` or `build-webkit`, or before running Xcode from the
876         command line.
877
878         Additionally, remove the step that generates a list of source files
879         going into the UnifiedSources build step. It's only necessarily to
880         specify Sources.txt and SourcesCocoa.txt as inputs.
881
882         * Scripts/generate-xcfilelists:
883
884 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
885
886         [GTK][WPE] force libpsl build to use ICU in jhbuild
887         https://bugs.webkit.org/show_bug.cgi?id=194288
888
889         Reviewed by Philippe Normand.
890
891         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
892         This can cause build failures if libidn is detected but libunistring is not available.
893
894         Make sure that ICU is used for runtime and builtin PSL data.
895
896         * gtk/jhbuild.modules:
897         * wpe/jhbuild.modules:
898
899 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
900
901         [ews-app] Modified timestamp should be updated on updating data
902         https://bugs.webkit.org/show_bug.cgi?id=194295
903
904         Reviewed by Lucas Forschler.
905
906         * BuildSlaveSupport/ews-app/ews/models/build.py:
907         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
908         * BuildSlaveSupport/ews-app/ews/models/step.py:
909
910 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
911
912         Unreviewed, rolling out r240742.
913
914         Causes crashes on iOS simulator.
915
916         Reverted changeset:
917
918         "[iOS] Keyups for non-modifier keys identified as "Dead" when
919         not focused in a content-editable element"
920         https://bugs.webkit.org/show_bug.cgi?id=192824
921         https://trac.webkit.org/changeset/240742
922
923 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
924
925         run-webkit-tests emits message "...running None" when running tests
926         https://bugs.webkit.org/show_bug.cgi?id=194133
927         <rdar://problem/47724738>
928
929         Reviewed by Lucas Forschler.
930
931         * Scripts/webkitpy/xcode/device_type.py:
932         (DeviceType.__str__): Use both version mapping tables and use just the variant
933         name if no version name is available.
934         * Scripts/webkitpy/xcode/device_type_unittest.py:
935         (DeviceTypeTest):
936         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
937         an associated named.
938
939 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
940
941         [WPE] require python3-setuptools for meson build in jhbuild
942         https://bugs.webkit.org/show_bug.cgi?id=194287
943
944         Reviewed by Philippe Normand.
945
946         python3-setuptools is needed to build meson in jhbuild.
947         It is already required by the GTK port.
948
949         * wpe/install-dependencies:
950
951 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
952
953         [ews-app] Add method to save BuilderMapping to database
954         https://bugs.webkit.org/show_bug.cgi?id=194264
955
956         Reviewed by Lucas Forschler.
957
958         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
959         (BuilderMapping.__str__):
960         (BuilderMapping):
961         (BuilderMapping.save_mapping):
962         (BuilderMapping.update_mapping):
963         (BuilderMapping.get_existing_mapping):
964         (BuilderMapping.is_valid_mapping):
965
966 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
967
968         [ews-app] Add timestamp fields for BuilderMappings
969         https://bugs.webkit.org/show_bug.cgi?id=194266
970
971         Reviewed by Lucas Forschler.
972
973         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
974         (BuilderMapping):
975
976 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
977
978         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
979         https://bugs.webkit.org/show_bug.cgi?id=174816
980
981         Reviewed by Michael Catanzaro.
982
983         Add tests for webkit_uri_for_display().
984
985         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
986         (testURIForDisplayUnaffected):
987         (testURIForDisplayAffected):
988         (beforeAll):
989         (afterAll):
990         * TestWebKitAPI/glib/CMakeLists.txt:
991
992 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
993
994         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
995         https://bugs.webkit.org/show_bug.cgi?id=194158
996         <rdar://problem/47737268>
997
998         Rubber-stamped by Aakash Jain.
999
1000         * Scripts/webkitpy/port/device_port.py:
1001         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1002
1003 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1004
1005         [CG] Enable setAdditionalSupportedImageTypes for WK1
1006         https://bugs.webkit.org/show_bug.cgi?id=194190
1007
1008         Reviewed by Tim Horton.
1009
1010         Add a test similar to the one under WebKit Cocoa but make it create a
1011         WebView instead of a WKWebView.
1012
1013         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1014         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1015         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1016         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1017         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1018         (TestWebKitAPI::runTest):
1019         (TestWebKitAPI::TEST):
1020
1021 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1022
1023         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1024         https://bugs.webkit.org/show_bug.cgi?id=194168
1025
1026         Reviewed by Simon Fraser.
1027
1028         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1029
1030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1031         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1032         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1033         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1034         (TEST):
1035         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1036         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1037
1038 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1039
1040         REGRESSION (r237269): webkit-patch what-broke is broken 
1041         https://bugs.webkit.org/show_bug.cgi?id=193025
1042
1043         Reviewed by Aakash Jain.
1044
1045         * Scripts/webkitpy/common/host.py:
1046         (Host.buildbot):
1047         (Host.bugzilla): Renamed to 'buildbot'.
1048
1049 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1050
1051         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1052         https://bugs.webkit.org/show_bug.cgi?id=194207
1053
1054         Reviewed by Tim Horton.
1055
1056         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1057         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1058         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1059         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1060         start and delete forwards to remove the original attachment.
1061
1062         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1063         (TestWebKitAPI::TEST):
1064
1065 2019-02-04  Youenn Fablet  <youenn@apple.com>
1066
1067         Capture state should be managed consistently when doing process swapping
1068         https://bugs.webkit.org/show_bug.cgi?id=194122
1069         <rdar://problem/47609293>
1070
1071         Reviewed by Eric Carlson.
1072
1073         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1074         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1075         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1076         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1077         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1078         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1079         (WTR::TestRunner::isDoingMediaCapture const):
1080         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1081         * WebKitTestRunner/TestController.cpp:
1082         (WTR::TestController::isDoingMediaCapture const):
1083         * WebKitTestRunner/TestController.h:
1084         * WebKitTestRunner/TestInvocation.cpp:
1085         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1086         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1087         (WTR::TestController::isDoingMediaCapture const):
1088
1089 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1090
1091         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1092         https://bugs.webkit.org/show_bug.cgi?id=194142
1093
1094         Reviewed by Ross Kirsling.
1095
1096         There three 'separator' variables in TestController.cpp. Renamed
1097         it 'pathSeparator', and unified them.
1098
1099         * WebKitTestRunner/TestController.cpp:
1100         (WTR::TestController::generateContextConfiguration const):
1101         (WTR::createTestURL):
1102         (WTR::TestController::platformAdjustContext):
1103
1104 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1105
1106         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1107         https://bugs.webkit.org/show_bug.cgi?id=194198
1108
1109         Reviewed by Antti Koivisto.
1110
1111         No need to set the banner heights on navigation now, since Page stores them.
1112
1113         * MiniBrowser/mac/WK2BrowserWindowController.m:
1114         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1115
1116 2019-02-03  John Wilander  <wilander@apple.com>
1117
1118         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1119         https://bugs.webkit.org/show_bug.cgi?id=194104
1120         <rdar://problem/47649991>
1121
1122         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1123
1124         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1125         (TestWebKitAPI::TEST):
1126             Changed numeric types from unsigned short to uint32_t.
1127
1128 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1129
1130         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1131         <https://webkit.org/b/194178>
1132         <rdar://problem/47753473>
1133
1134         Reviewed by Alexey Proskuryakov.
1135
1136         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1137         (WTR::uninstallFakeHelvetica): Pass nullptr into
1138         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1139
1140 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1141
1142         [LFC] Initialize ICB's style with fixed width/height.
1143         https://bugs.webkit.org/show_bug.cgi?id=194188
1144
1145         Reviewed by Antti Koivisto.
1146
1147         * LayoutReloaded/misc/LFC-passing-tests.txt:
1148
1149 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1150
1151         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1152         https://bugs.webkit.org/show_bug.cgi?id=194185
1153
1154         Reviewed by Antti Koivisto.
1155
1156         * LayoutReloaded/misc/LFC-passing-tests.txt:
1157
1158 2018-12-16  Darin Adler  <darin@apple.com>
1159
1160         Convert additional String::format clients to alternative approaches
1161         https://bugs.webkit.org/show_bug.cgi?id=192746
1162
1163         Reviewed by Alexey Proskuryakov.
1164
1165         * WebKitTestRunner/TestController.cpp:
1166         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1167         as an intermediate in code that ultimately constructs a WTF::String.
1168         (WTR::userMediaOriginHash): Use makeString.
1169         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1170         (WTR::TestController::didPerformClientRedirect): Ditto.
1171         (WTR::TestController::didPerformServerRedirect): Ditto.
1172         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1173
1174 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1175
1176         [ews-build] Add unit test to verify builder keys
1177         https://bugs.webkit.org/show_bug.cgi?id=194152
1178
1179         Reviewed by Lucas Forschler.
1180
1181         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1182         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1183
1184 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1185
1186         [LFC] Expand tests coverage (12 new tests -> 787)
1187
1188         Unreviewed test gardening.
1189
1190         * LayoutReloaded/misc/LFC-passing-tests.txt:
1191
1192 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1193
1194         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1195         https://bugs.webkit.org/show_bug.cgi?id=194163
1196
1197         Reviewed by Simon Fraser.
1198
1199         775
1200
1201         * LayoutReloaded/misc/LFC-passing-tests.txt:
1202
1203 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1204
1205         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1206         https://bugs.webkit.org/show_bug.cgi?id=194140
1207         <rdar://problem/47728098>
1208
1209         Reviewed by Tim Horton.
1210
1211         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1212         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1213         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1214
1215         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1216         test to induce an IPC deadlock when presenting a modal alert during touch start.
1217
1218         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1219         * WebKitTestRunner/TestController.cpp:
1220         (WTR::runJavaScriptAlert):
1221
1222         Add a client callback function for running JavaScript alerts.
1223
1224         (WTR::TestController::createOtherPage):
1225         (WTR::TestController::generateContextConfiguration const):
1226
1227         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1228         the fix in this patch.
1229
1230         (WTR::TestController::createWebViewWithOptions):
1231
1232         Plumb TestOptions to generateContextConfiguration.
1233
1234         (WTR::TestController::resetPreferencesToConsistentValues):
1235         (WTR::TestController::resetStateToConsistentValues):
1236         (WTR::updateTestOptionsFromTestHeader):
1237         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1238         (WTR::TestController::handleJavaScriptAlert):
1239         * WebKitTestRunner/TestController.h:
1240         * WebKitTestRunner/TestInvocation.cpp:
1241         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1242         * WebKitTestRunner/TestOptions.h:
1243         (WTR::TestOptions::hasSameInitializationOptions const):
1244
1245 2019-02-01  Chris Dumez  <cdumez@apple.com>
1246
1247         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1248         https://bugs.webkit.org/show_bug.cgi?id=193740
1249         <rdar://problem/47527267>
1250
1251         Reviewed by Alex Christensen.
1252
1253         Add API test coverage.
1254
1255         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1256
1257 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1258
1259         [ews-app] Add display name field to BuilderMapping model
1260         https://bugs.webkit.org/show_bug.cgi?id=194153
1261
1262         Reviewed by Lucas Forschler.
1263
1264         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1265         (BuilderMapping):
1266
1267 2019-02-01  Youenn Fablet  <youenn@apple.com>
1268
1269         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1270         https://bugs.webkit.org/show_bug.cgi?id=194155
1271
1272         Reviewed by Eric Carlson.
1273
1274         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1275         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1276         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1277
1278 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1279
1280         [LFC] Adjust replaced element's intrinsic ratio
1281         https://bugs.webkit.org/show_bug.cgi?id=194154
1282
1283         Reviewed by Antti Koivisto.
1284
1285         761
1286
1287         * LayoutReloaded/misc/LFC-passing-tests.txt:
1288
1289 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1290
1291         [WPE] Show test results in minibrowser
1292         https://bugs.webkit.org/show_bug.cgi?id=194150
1293
1294         Reviewed by Žan Doberšek.
1295
1296         * Scripts/webkitpy/port/wpe.py:
1297         (WPEPort.show_results_html_file):
1298
1299 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1300
1301         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1302         https://bugs.webkit.org/show_bug.cgi?id=194151
1303
1304         Reviewed by Žan Doberšek.
1305
1306         ALT + <- go back
1307         ALT + -> go forward
1308
1309         * MiniBrowser/wpe/main.cpp:
1310         (main):
1311
1312 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1313
1314         [LFC] Set intrinsic size on Layout::Replaced
1315         https://bugs.webkit.org/show_bug.cgi?id=194139
1316
1317         Reviewed by Antti Koivisto.
1318
1319         744
1320
1321         * LayoutReloaded/misc/LFC-passing-tests.txt:
1322
1323 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1324
1325         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1326         https://bugs.webkit.org/show_bug.cgi?id=194146
1327
1328         Reviewed by Xabier Rodriguez-Calvar.
1329
1330         It allows to open relative paths.
1331
1332         * MiniBrowser/wpe/main.cpp:
1333         (main):
1334
1335 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1336
1337         Update flakiness dashboard configuration after recent queue changes
1338         https://bugs.webkit.org/show_bug.cgi?id=194127
1339
1340         Rubber-stamped by Aakash Jain.
1341
1342         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1343
1344         * TestResultServer/static-dashboards/builders.jsonp:
1345
1346 2019-01-31  Youenn Fablet  <youenn@apple.com>
1347
1348         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1349         https://bugs.webkit.org/show_bug.cgi?id=194106
1350         <rdar://problem/47676333>
1351
1352         Reviewed by Ryosuke Niwa.
1353
1354         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1355         (TestWebKitAPI::didFinishNavigation):
1356         (TestWebKitAPI::TEST):
1357         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1358
1359 2019-01-31  Chris Dumez  <cdumez@apple.com>
1360
1361         Page zoom level is lost after a process swap or a crash
1362         https://bugs.webkit.org/show_bug.cgi?id=194105
1363         <rdar://problem/47610781>
1364
1365         Reviewed by Alex Christensen.
1366
1367         Add API test coverage.
1368
1369         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1370         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1371
1372 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1373
1374         Revert r238819 which is unneeded and caused a performance regression.
1375         https://bugs.webkit.org/show_bug.cgi?id=192272
1376         <rdar://problem/46664625>
1377
1378         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1379         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1380         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1381
1382 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1383
1384         Formalize WebKitAdditions mechanism of LoadOptimizer
1385         https://bugs.webkit.org/show_bug.cgi?id=193886
1386         <rdar://problem/47696809>
1387
1388         Reviewed by Brent Fulgham.
1389
1390         * MiniBrowser/MiniBrowser.entitlements:
1391         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1392
1393 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1394
1395         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1396         https://bugs.webkit.org/show_bug.cgi?id=194090
1397
1398         Reviewed by Antti Koivisto.
1399
1400         * LayoutReloaded/misc/LFC-passing-tests.txt:
1401
1402 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1403
1404         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1405         https://bugs.webkit.org/show_bug.cgi?id=194074
1406
1407         Reviewed by Antti Koivisto.
1408
1409         * LayoutReloaded/misc/LFC-passing-tests.txt:
1410
1411 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1412
1413         [LFC][BFC] Add support for block level replaced box.
1414         https://bugs.webkit.org/show_bug.cgi?id=194071
1415
1416         Reviewed by Antti Koivisto.
1417
1418         * LayoutReloaded/misc/LFC-passing-tests.txt:
1419
1420 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1421
1422         Fix WebKitTestRunner's testPath with Windows full paths
1423         https://bugs.webkit.org/show_bug.cgi?id=194012
1424
1425         Reviewed by Alex Christensen.
1426
1427         updateTestOptionsFromTestHeader failed to open test files because
1428         testPath returned wrong file paths. It returned a path "/C:/..."
1429         if a URL "file:///C:/..." was given.
1430
1431         * WebKitTestRunner/TestController.cpp:
1432         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1433
1434 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1435
1436         [WPE] Bump font related dependencies to match the GTK+ port
1437         https://bugs.webkit.org/show_bug.cgi?id=194017
1438
1439         Reviewed by Žan Doberšek.
1440
1441         * wpe/jhbuild.modules:
1442         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1443         * wpe/patches/icudata-stdlibs.patch: Added.
1444
1445 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1446
1447         Enable swipe tests on iOS
1448         https://bugs.webkit.org/show_bug.cgi?id=194076
1449
1450         Reviewed by Geoffrey Garen.
1451
1452         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1453         it causes a debug assertion failure in runUIScript.
1454
1455         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1456         (WTR::UIScriptController::beginBackSwipe):
1457         (WTR::UIScriptController::completeBackSwipe):
1458
1459 2019-01-30  Keith Rollin  <krollin@apple.com>
1460
1461         Use correct printf format specifier
1462         https://bugs.webkit.org/show_bug.cgi?id=194062
1463         <rdar://problem/47686167>
1464
1465         Reviewed by Alexey Proskuryakov.
1466
1467         LayoutTestSpellChecker.mm is trying to format a variable of type
1468         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1469         actually an unsigned long long. Fix this by formatting with %llu.
1470
1471         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1472         (-[LayoutTestTextCheckingResult description]):
1473
1474 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1475
1476         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1477         https://bugs.webkit.org/show_bug.cgi?id=193979
1478
1479         Reviewed by Wenson Hsieh.
1480
1481         Fix the test for iOS. Make the test work with iOS UA string.
1482
1483         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1484
1485 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1486
1487         Replace High Sierra LLINT CLoop bot due to hardware failure
1488         https://bugs.webkit.org/show_bug.cgi?id=194066
1489
1490         Reviewed by Aakash Jain.
1491
1492         * BuildSlaveSupport/build.webkit.org-config/config.json:
1493
1494 2019-01-30  Keith Rollin  <krollin@apple.com>
1495
1496         [NSDragItem init] is unavailable
1497         https://bugs.webkit.org/show_bug.cgi?id=194059
1498         <rdar://problem/47685715>
1499
1500         Reviewed by Wenson Hsieh.
1501
1502         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1503         DumpRenderTree and TestWebKitAPI, which both try to create an
1504         NSDragItem in a manner that invokes this method. Address this by using
1505         -initWithPasteboardWriter instead.
1506
1507         Note that the parameter passed to initWithPasteboardWriter is likely
1508         incorrect. In both cases, the object passed does not conform to
1509         NSPasteboardWriting. However, with this fix, we're no worse off than
1510         before, and can now perform builds with newer compilers and SDKs until
1511         a real fix can be crafted. That work is tracked in
1512         https://bugs.webkit.org/show_bug.cgi?id=194060
1513
1514         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1515         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1516         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1517         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1518
1519 2019-01-30  Daniel Bates  <dabates@apple.com>
1520
1521         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1522         https://bugs.webkit.org/show_bug.cgi?id=192824
1523         <rdar://problem/47100332>
1524
1525         Reviewed by Wenson Hsieh.
1526
1527         Fix a bug where the wrong usage code was used for F13 thru F24.
1528
1529         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1530         (keyCodeForDOMFunctionKey):
1531
1532 2019-01-30  Chris Dumez  <cdumez@apple.com>
1533
1534         Regression(PSON) Load hang can occur on history navigation
1535         https://bugs.webkit.org/show_bug.cgi?id=194030
1536         <rdar://problem/47656939>
1537
1538         Reviewed by Antti Koivisto.
1539
1540         Add API test coverage.
1541
1542         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1543
1544 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1545
1546         [LFC] Expand tests coverage.
1547
1548         Unreviewed test gardening.
1549
1550         * LayoutReloaded/misc/LFC-passing-tests.txt:
1551
1552 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1553
1554         [Flatpak] Add openjpeg support
1555         https://bugs.webkit.org/show_bug.cgi?id=194019
1556
1557         Reviewed by Michael Catanzaro.
1558
1559         * flatpak/org.webkit.CommonModules.yaml:
1560
1561 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1562
1563         Unreviewed, rolling out r240708.
1564         https://bugs.webkit.org/show_bug.cgi?id=194022
1565
1566         It broke WPE build (Requested by KaL on #webkit).
1567
1568         Reverted changeset:
1569
1570         "[WPE] Bump font related dependencies to match the GTK+ port"
1571         https://bugs.webkit.org/show_bug.cgi?id=194017
1572         https://trac.webkit.org/changeset/240708
1573
1574 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1575
1576         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1577         https://bugs.webkit.org/show_bug.cgi?id=194001
1578
1579         Reviewed by Antti Koivisto.
1580
1581         * LayoutReloaded/misc/LFC-passing-tests.txt:
1582
1583 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1584
1585         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1586         https://bugs.webkit.org/show_bug.cgi?id=194020
1587
1588         Reviewed by Antti Koivisto.
1589
1590         * LayoutReloaded/misc/LFC-passing-tests.txt:
1591
1592 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1593
1594         AX: Support color well on iOS
1595         https://bugs.webkit.org/show_bug.cgi?id=194010
1596
1597         Reviewed by Joanmarie Diggs.
1598
1599         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1600         (WTR::AccessibilityUIElement::stringAttributeValue):
1601
1602 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1603
1604         [WPE] Bump font related dependencies to match the GTK+ port
1605         https://bugs.webkit.org/show_bug.cgi?id=194017
1606
1607         Reviewed by Žan Doberšek.
1608
1609         * wpe/jhbuild.modules:
1610         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1611         * wpe/patches/icudata-stdlibs.patch: Added.
1612
1613 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1614
1615         [Mac] Update window scale API usage
1616         https://bugs.webkit.org/show_bug.cgi?id=193991
1617         rdar://problem/47614795
1618
1619         Reviewed by Tim Horton.
1620
1621         * DumpRenderTree/mac/DumpRenderTree.mm:
1622         (changeWindowScaleIfNeeded):
1623         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1624         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1625         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1626
1627 2019-01-29  Chris Dumez  <cdumez@apple.com>
1628
1629         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1630         https://bugs.webkit.org/show_bug.cgi?id=193977
1631         <rdar://problem/47643716>
1632
1633         Reviewed by Geoff Garen.
1634
1635         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1636         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1637         to the previous provisional committing *before* we make the last load. 
1638
1639         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1640
1641 2019-01-29  Youenn Fablet  <youenn@apple.com>
1642
1643         Adopt new SPI to evaluate server certificate trust
1644         https://bugs.webkit.org/show_bug.cgi?id=193355
1645
1646         Reviewed by Alex Christensen.
1647
1648         Add infrastructure to handle HTTPS server trust evaluation testing.
1649
1650         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1651         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1652         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1653         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1654         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1655         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1656         * WebKitTestRunner/TestController.cpp:
1657         (WTR::TestController::resetPreferencesToConsistentValues):
1658         (WTR::TestController::didReceiveAuthenticationChallenge):
1659         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1660         * WebKitTestRunner/TestController.h:
1661         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1662         * WebKitTestRunner/TestInvocation.cpp:
1663         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1664         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1665         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1666
1667 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1668
1669         [ews-build] Add build step to print bot Configuration
1670         https://bugs.webkit.org/show_bug.cgi?id=193887
1671
1672         Reviewed by Lucas Forschler.
1673
1674         * BuildSlaveSupport/ews-build/steps.py:
1675         (PrintConfiguration): Build step to print configuration.
1676         * BuildSlaveSupport/ews-build/factories.py:
1677
1678 2019-01-29  Chris Dumez  <cdumez@apple.com>
1679
1680         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1681         https://bugs.webkit.org/show_bug.cgi?id=193967
1682         <rdar://problem/47635348>
1683
1684         Reviewed by Alex Christensen.
1685
1686         Add API test coverage.
1687
1688         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1689         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1690
1691 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1692
1693         [ews-app] Handle incoming results data
1694         https://bugs.webkit.org/show_bug.cgi?id=193973
1695
1696         Reviewed by Lucas Forschler.
1697
1698         * BuildSlaveSupport/ews-app/ews/views/results.py:
1699
1700 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1701
1702         [ews-app] Make the results url generic
1703         https://bugs.webkit.org/show_bug.cgi?id=193928
1704
1705         Reviewed by Lucas Forschler.
1706
1707         * BuildSlaveSupport/ews-app/ews/urls.py:
1708
1709 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1710
1711         [ews-build] Configure buildbot to send events to ews-app
1712         https://bugs.webkit.org/show_bug.cgi?id=193968
1713
1714         Reviewed by Lucas Forschler.
1715
1716         * BuildSlaveSupport/ews-build/events.py: Added.
1717         * BuildSlaveSupport/ews-build/master.cfg:
1718
1719 2019-01-29  Keith Rollin  <krollin@apple.com>
1720
1721         Add .xcfilelists to Run Script build phases
1722         https://bugs.webkit.org/show_bug.cgi?id=193792
1723         <rdar://problem/47201785>
1724
1725         Reviewed by Alex Christensen.
1726
1727         As part of supporting XCBuild, update the necessary Run Script build
1728         phases in their Xcode projects to refer to their associated
1729         .xcfilelist files.
1730
1731         Note that the addition of these files bumps the Xcode project version
1732         number to something that's Xcode 10 compatible. This change means that
1733         older versions of the Xcode IDE can't read these projects. Nor can it
1734         fully load workspaces that refer to these projects (the updated
1735         projects are shown as non-expandable placeholders). `xcodebuild` can
1736         still build these projects; it's just that the IDE can't open them.
1737
1738         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1739         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1740
1741 2019-01-29  John Wilander  <wilander@apple.com>
1742
1743         Add data abstraction and validation for Ad Click Attribution
1744         https://bugs.webkit.org/show_bug.cgi?id=193916
1745         <rdar://problem/47603481>
1746
1747         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1748
1749         Ad click attribution has two steps. First, the storage of an ad
1750         campaign ID for a click that takes the user to a destination
1751         site. Second, a conversion on the destination site that can be
1752         attributed to the ad click.
1753
1754         This patch adds a class that represents a request for ad click
1755         attribution. Validation makes sure that the bits of entropy
1756         reported through this mechanism is limited.
1757
1758         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1759         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1760         (TestWebKitAPI::TEST):
1761
1762 2019-01-29  Chris Dumez  <cdumez@apple.com>
1763
1764         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1765         https://bugs.webkit.org/show_bug.cgi?id=193932
1766         <rdar://problem/47598947>
1767
1768         Reviewed by Brady Eidson.
1769
1770         Add API test coverage.
1771
1772         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1773
1774 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1775
1776         Adding new passing LFC tests.
1777
1778         Unreviewed test gardening.
1779
1780         * LayoutReloaded/misc/LFC-passing-tests.txt:
1781
1782 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1783
1784         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1785         https://bugs.webkit.org/show_bug.cgi?id=193964
1786
1787         Reviewed by Antti Koivisto.
1788
1789         * LayoutReloaded/misc/LFC-passing-tests.txt:
1790
1791 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1792
1793         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1794         https://bugs.webkit.org/show_bug.cgi?id=193954
1795
1796         Reviewed by Antti Koivisto.
1797
1798         * LayoutReloaded/misc/LFC-passing-tests.txt:
1799
1800 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1801
1802         WebDriver: add support for running subtests
1803         https://bugs.webkit.org/show_bug.cgi?id=193904
1804
1805         Reviewed by Michael Catanzaro.
1806
1807         pytest already supports it by passing test.py::subtest, so we can do the same.
1808
1809         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1810         (get_item_name): Made this global.
1811         (CollectRecorder.__init__): Receive the parameter to ignore.
1812         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1813         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1814         (collect): Add parameter to ignore.
1815         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1816         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1817         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1818         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1819         (WebDriverTestRunnerSelenium.run): Ditto.
1820         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1821         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1822         (WebDriverTestRunnerW3C.run): Ditto.
1823
1824 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1825
1826         User agent string override for navigator.userAgent should be site specific quirks
1827         https://bugs.webkit.org/show_bug.cgi?id=193950
1828
1829         Reviewed by Brent Fulgham.
1830
1831         Updated per the _WKWebsitePolicies rename.
1832
1833         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1834         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1835
1836 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1837
1838         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1839         https://bugs.webkit.org/show_bug.cgi?id=193941
1840
1841         Reviewed by Alex Christensen.
1842
1843         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1844         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1845         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1846         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1847         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1848         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1849         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1850         * TestWebKitAPI/Tests/WTF/Time.cpp:
1851         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1852         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1853         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1854         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1855
1856 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1857
1858         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1859
1860         * Scripts/webkitpy/common/config/contributors.json:
1861
1862 2019-01-28  Andy Estes  <aestes@apple.com>
1863
1864         [watchOS] Enable Parental Controls content filtering
1865         https://bugs.webkit.org/show_bug.cgi?id=193939
1866         <rdar://problem/46641912>
1867
1868         Reviewed by Ryosuke Niwa.
1869
1870         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1871
1872 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1873
1874         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1875         <https://webkit.org/b/193884>
1876
1877         Reviewed by Jiewen Tan.
1878
1879         * Scripts/webkitpy/style/checkers/cpp.py:
1880         (check_language): Add LocalAuthentication to
1881         `frameworks_with_soft_links`.
1882
1883 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1884
1885         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1886         https://bugs.webkit.org/show_bug.cgi?id=193891
1887
1888         Reviewed by Ross Kirsling.
1889
1890         There were three problems in window sizes of WebView and the host window.
1891         1. The sizes of pixel image output were incorrect.
1892         2. The host window is going to appear after window.resize was invoked.
1893         3. window.resize resized only the host window, not WebView.
1894
1895         This change solves them with a following approach.
1896         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1897         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1898            as well as DumpRenderTree in order to match the client area and the window area.
1899         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1900         d. PlatformWebView::setWindowFrame changes both window sizes.
1901         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1902
1903         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1904         (WTR::PlatformWebView::PlatformWebView): Create the host window
1905         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1906         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1907         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1908
1909 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1910
1911         [ews-app] Add method to save Step data to database
1912         https://bugs.webkit.org/show_bug.cgi?id=193890
1913
1914         Reviewed by Lucas Forschler.
1915
1916         * BuildSlaveSupport/ews-app/ews/models/step.py:
1917         (Step.save_step): Method to save step data.
1918         (Step.update_step): Method to update step data.
1919         (Step.get_existing_step): Method to fetch existing step from database.
1920         (Step.is_valid_result): Method to validate valid step result.
1921
1922 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1923
1924         [ews-app] Add method to save Build data to database
1925         https://bugs.webkit.org/show_bug.cgi?id=193735
1926
1927         Reviewed by Lucas Forschler.
1928
1929         * BuildSlaveSupport/ews-app/ews/models/build.py:
1930         (Build.save_build): Method to save build information to database.
1931         (Build.get_existing_build): Method to fetch existing build from database.
1932         (Build.is_valid_result): Method to validate build result.
1933         * BuildSlaveSupport/ews-app/ews/common/util.py:
1934         (is_valid_int_id): Method to validate valid id.
1935
1936 2019-01-28  Chris Dumez  <cdumez@apple.com>
1937
1938         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1939         https://bugs.webkit.org/show_bug.cgi?id=193915
1940         <rdar://problem/47560907>
1941
1942         Reviewed by Alex Christensen.
1943
1944         Add API test coverage.
1945
1946         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1947
1948 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1949
1950         [ews-app] Rename id variables
1951         https://bugs.webkit.org/show_bug.cgi?id=193883
1952
1953         Reviewed by Lucas Forschler.
1954
1955         * BuildSlaveSupport/ews-app/ews/models/build.py:
1956         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1957         * BuildSlaveSupport/ews-app/ews/models/step.py:
1958         * BuildSlaveSupport/ews-app/ews/urls.py:
1959         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1960         * BuildSlaveSupport/ews-app/ews/views/results.py:
1961         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1962
1963 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1964
1965         [ews-app] Allow certain fields to be empty
1966         https://bugs.webkit.org/show_bug.cgi?id=193892
1967
1968         Reviewed by Lucas Forschler.
1969
1970         * BuildSlaveSupport/ews-app/ews/models/build.py:
1971         * BuildSlaveSupport/ews-app/ews/models/step.py:
1972
1973 2019-01-28  Rob Buis  <rbuis@igalia.com>
1974
1975         Update MIME type parser
1976         https://bugs.webkit.org/show_bug.cgi?id=180526
1977
1978         Reviewed by Frédéric Wang.
1979
1980         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1981         (TestWebKitAPI::TEST):
1982
1983 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1984
1985         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1986         https://bugs.webkit.org/show_bug.cgi?id=193896
1987
1988         Reviewed by Antti Koivisto.
1989
1990         * LayoutReloaded/misc/LFC-passing-tests.txt:
1991
1992 2018-12-15  Darin Adler  <darin@apple.com>
1993
1994         Replace many uses of String::format with more type-safe alternatives
1995         https://bugs.webkit.org/show_bug.cgi?id=192742
1996
1997         Reviewed by Mark Lam.
1998
1999         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2000         (WTR::cacheTestRunnerCallback): Use makeString.
2001         * WebKitTestRunner/TestController.cpp:
2002         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2003         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2004
2005 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2006
2007         Use a load optimizer for some sites
2008         https://bugs.webkit.org/show_bug.cgi?id=193881
2009         <rdar://problem/46325455>
2010
2011         Reviewed by Brent Fulgham.
2012
2013         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2014         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2015
2016 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2017
2018         AX: Introduce a static accessibility tree
2019         https://bugs.webkit.org/show_bug.cgi?id=193348
2020         <rdar://problem/47203295>
2021
2022         Reviewed by Ryosuke Niwa.
2023
2024         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2025
2026 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2027
2028         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2029         https://bugs.webkit.org/show_bug.cgi?id=193867
2030
2031         Reviewed by Antti Koivisto.
2032
2033         * LayoutReloaded/misc/LFC-passing-tests.txt:
2034
2035 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2036
2037         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2038         https://bugs.webkit.org/show_bug.cgi?id=193865
2039
2040         Reviewed by Antti Koivisto.
2041
2042         * LayoutReloaded/misc/LFC-passing-tests.txt:
2043
2044 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2045
2046         Need a mechanism to override navigator.userAgent
2047         https://bugs.webkit.org/show_bug.cgi?id=193762
2048         <rdar://problem/47504939>
2049
2050         Reviewed by Brent Fulgham.
2051
2052         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2053
2054         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2055         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2056         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2057
2058 2019-01-25  Dean Jackson  <dino@apple.com>
2059
2060         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2061         https://bugs.webkit.org/show_bug.cgi?id=193831
2062         <rdar://problem/47399263>
2063
2064         Reviewed by Chris Dumez.
2065
2066         Two new tests that exercise cross-origin and same-origin System
2067         Previews.
2068
2069         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2070
2071 2019-01-25  Keith Rollin  <krollin@apple.com>
2072
2073         Update Xcode projects with "Check .xcfilelists" build phase
2074         https://bugs.webkit.org/show_bug.cgi?id=193790
2075         <rdar://problem/47201374>
2076
2077         Reviewed by Alex Christensen.
2078
2079         Support for XCBuild includes specifying inputs and outputs to various
2080         Run Script build phases. These inputs and outputs are specified as
2081         .xcfilelist files. Once created, these .xcfilelist files need to be
2082         kept up-to-date. In order to check that they are up-to-date or not,
2083         add an Xcode build step that invokes an external script that performs
2084         the checking. If the .xcfilelists are found to be out-of-date, update
2085         them, halt the build, and instruct the developer to restart the build
2086         with up-to-date files.
2087
2088         At this time, the checking and regenerating is performed only if the
2089         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2090         who want to use this facility can set this variable and test out the
2091         checking/regenerating. Once it seems like there are no egregious
2092         issues that upset a developer's workflow, we'll unconditionally enable
2093         this facility.
2094
2095         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2096         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2097         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2098         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2099
2100 2019-01-25  Keith Rollin  <krollin@apple.com>
2101
2102         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2103         https://bugs.webkit.org/show_bug.cgi?id=193781
2104         <rdar://problem/47201153>
2105
2106         Reviewed by Alex Christensen.
2107
2108         Part of generating the .xcfilelists used as part of adopting XCBuild
2109         includes running `make DerivedSources.make` from a standalone script.
2110         It’s important for this invocation to have the same environment as
2111         when the actual build invokes `make DerivedSources.make`. If the
2112         environments are different, then the two invocations will provide
2113         different results. In order to get the same environment in the
2114         standalone script, have the script launch xcodebuild targeting the
2115         "Apply Configuration to XCFileLists" build target, which will then
2116         re-invoke our standalone script. The script is now running again, this
2117         time in an environment with all workspace, project, target, xcconfig
2118         and other environment variables established.
2119
2120         The "Apply Configuration to XCFileLists" build target accomplishes
2121         this task via a small embedded shell script that consists only of:
2122
2123             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2124
2125         The process that invokes "Apply Configuration to XCFileLists" first
2126         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2127         evaluated and exports it into the shell environment. When xcodebuild
2128         is invoked, it inherits the value of this variable and can `eval` the
2129         contents of that variable. Our external standalone script can then set
2130         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2131         of command-line parameters needed to restart itself in the appropriate
2132         state.
2133
2134         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2135         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2136
2137 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2138
2139         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2140         https://bugs.webkit.org/show_bug.cgi?id=193802
2141         <rdar://problem/46010580>
2142
2143         Reviewed by Andy Estes.
2144
2145         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2146         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2147         (TEST):
2148
2149 2019-01-25  Daniel Bates  <dabates@apple.com>
2150
2151         [iOS] uiController.keyDown() does not translate Control modified key
2152         https://bugs.webkit.org/show_bug.cgi?id=192898
2153
2154         Reviewed by Wenson Hsieh.
2155
2156         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2157         key translation, as applicable. Among other cases, key translation occurs when performing
2158         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2159         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2160         human pressing down and releasing key(s) using a hardware keyboard.
2161
2162         * WebKitTestRunner/ios/HIDEventGenerator.h:
2163         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2164         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2165
2166         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2167         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2168         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2169         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2170         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2171         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2172         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2173         (-[HIDEventGenerator longPress:completionBlock:]):
2174         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2175         Update code for above renaming.
2176
2177         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2178         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2179
2180         (-[HIDEventGenerator keyDown:]): Added.
2181         (-[HIDEventGenerator keyUp:]): Added.
2182         (-[HIDEventGenerator keyPress:completionBlock:]):
2183         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2184         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2185         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2186         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2187         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2188         (WTR::parseModifier): Deleted.
2189
2190 2019-01-25  Keith Rollin  <krollin@apple.com>
2191
2192         Complete the implementation of generate-xcfilelists
2193         https://bugs.webkit.org/show_bug.cgi?id=193782
2194
2195         Reviewed by Alex Christensen.
2196
2197         A preliminary version of generate-xcfilelists was added in r238008.
2198         This patch updates that script in order to:
2199
2200         - Support checking of .xcfilelists
2201         - Perform better execution of `make DerivedSources.make` by
2202           relaunching generate-xcfilelists under xcodebuild
2203         - Support incremental generation and checking of .xcfilelists
2204         - Support supplementary .xcfilelists files from WebKitAdditions
2205         - Support being wrapped by parallel version of generate-xcfilelists in
2206           Internal that adds support for (re)generating WebKit projects in
2207           that repo.
2208         - Support builds that have been performed in WebKitBuild as well as
2209           ~/Library/Developer/code/DerivedData
2210         - Increase robustness and debugging facilities.
2211
2212         * Scripts/generate-xcfilelists:
2213
2214 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2215
2216         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2217         https://bugs.webkit.org/show_bug.cgi?id=193297
2218         <rdar://problem/47158841>
2219
2220         Unreviewed test case fix.
2221
2222         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2223         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2224
2225         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2226         (TEST):
2227
2228 2019-01-25  Keith Rollin  <krollin@apple.com>
2229
2230         Update existing .xcfilelists
2231         https://bugs.webkit.org/show_bug.cgi?id=193791
2232         <rdar://problem/47201706>
2233
2234         Reviewed by Alex Christensen.
2235
2236         Many .xcfilelist files were added in r238824 in order to support
2237         XCBuild. Update these with recent changes to the set of build files
2238         and with the current generate-xcfilelist script.
2239
2240         * DumpRenderTree/DerivedSources-input.xcfilelist:
2241         * DumpRenderTree/DerivedSources-output.xcfilelist:
2242         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2243         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2244
2245 2019-01-25  Keith Rollin  <krollin@apple.com>
2246
2247         Fix missing dependencies in extract-dependencies-from-makefile
2248         https://bugs.webkit.org/show_bug.cgi?id=193783
2249         <rdar://problem/47201571>
2250
2251         Reviewed by Alex Christensen.
2252
2253         The extract-dependencies-from-makefile script generates .xcfilelists
2254         for XCBuild by invoking a makefile in --debug mode, parsing the
2255         dependency information in the output, and extracting information
2256         regarding targets and dependents. However, the way `make` emits this
2257         dependency information is not rigorous, and so we need to determine
2258         what lines to look for and parse by trial and error. This approach
2259         didn't coriginally atch all the information we needed to collect, so
2260         update the script to look for the additional lines we now know to look
2261         for.
2262
2263         * Scripts/extract-dependencies-from-makefile:
2264         (Parser):
2265         (Parser.addTarget):
2266         (Parser.addPrereq):
2267         (Parser.doParse):
2268
2269 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2270
2271         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2272         https://bugs.webkit.org/show_bug.cgi?id=193297
2273         <rdar://problem/47158841>
2274
2275         Reviewed by Alex Christensen.
2276
2277         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2278             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2279         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2280         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2281         activating the message used to trigger the callback when it is set.
2282
2283 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2284
2285         WKWebView.goBack should reload if there is a safe browsing warning
2286         https://bugs.webkit.org/show_bug.cgi?id=193805
2287         <rdar://problem/46908216>
2288
2289         Reviewed by Geoff Garen.
2290
2291         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2292         (+[Simple3LookupContext sharedLookupContext]):
2293         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2294         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2295         (TEST):
2296
2297 2019-01-25  Chris Dumez  <cdumez@apple.com>
2298
2299         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2300         https://bugs.webkit.org/show_bug.cgi?id=193788
2301         <rdar://problem/47531231>
2302
2303         Reviewed by Alex Christensen.
2304
2305         Add API test coverage.
2306
2307         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2308         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2309
2310 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2311
2312         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2313         https://bugs.webkit.org/show_bug.cgi?id=193771
2314
2315         Unreviewed infrastructure fix.
2316
2317         * Scripts/webkitpy/port/darwin.py:
2318         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2319
2320 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2321
2322         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2323
2324 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2325
2326         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2327
2328         * Scripts/webkitpy/common/config/contributors.json:
2329
2330 2019-01-25  Chris Dumez  <cdumez@apple.com>
2331
2332         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2333         https://bugs.webkit.org/show_bug.cgi?id=193779
2334         <rdar://problem/46170903>
2335
2336         Reviewed by Antti Koivisto.
2337
2338         Add API test that quickly navigates forward to a previous process without waiting for it to
2339         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2340         the process' previous page when reconnecting the it for the forward navigation.
2341
2342         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2343
2344 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2345
2346         Need a way for JavaScript (or bundle) code to participate in undo
2347         https://bugs.webkit.org/show_bug.cgi?id=190009
2348         <rdar://problem/44807048>
2349
2350         Reviewed by Ryosuke Niwa.
2351
2352         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2353         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2354
2355         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2356         (WTR::UIScriptController::lastUndoLabel const):
2357         (WTR::UIScriptController::firstRedoLabel const):
2358         (WTR::UIScriptController::platformUndoManager const):
2359         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2360         (WTR::UIScriptController::lastUndoLabel const):
2361         (WTR::UIScriptController::firstRedoLabel const):
2362         (WTR::UIScriptController::platformUndoManager const):
2363         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2364         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2365         (WTR::UIScriptController::lastUndoLabel const):
2366         (WTR::UIScriptController::firstRedoLabel const):
2367         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2368         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2369         (WTR::UIScriptController::lastUndoLabel const):
2370         (WTR::UIScriptController::firstRedoLabel const):
2371         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2372         (WTR::UIScriptController::platformUndoManager const):
2373         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2374         (WTR::UIScriptController::platformUndoManager const):
2375
2376 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2377
2378         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2379         https://bugs.webkit.org/show_bug.cgi?id=193824
2380
2381         Reviewed by Antti Koivisto.
2382
2383         * LayoutReloaded/misc/LFC-passing-tests.txt:
2384
2385 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2386
2387         Update macOS JSC bot configurations
2388         https://bugs.webkit.org/show_bug.cgi?id=193739
2389
2390         Reviewed by Alexey Proskuryakov.
2391
2392         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2393         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2394         (BubbleQueueServer): Move JSC EWS to Mojave section.
2395         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2396         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2397         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2398
2399 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2400
2401         [Win][WebKitTestRunner] Implement EventSenderProxy
2402         https://bugs.webkit.org/show_bug.cgi?id=193755
2403
2404         Reviewed by Don Olmstead.
2405
2406         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2407         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2408         (WTR::EventSenderProxy::dispatchMessage):
2409         (WTR::EventSenderProxy::EventSenderProxy):
2410         (WTR::EventSenderProxy::mouseDown):
2411         (WTR::EventSenderProxy::mouseUp):
2412         (WTR::EventSenderProxy::mouseMoveTo):
2413         (WTR::EventSenderProxy::mouseScrollBy):
2414         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2415
2416 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2417
2418         Unreviewed fix for API test failure after r240437.
2419
2420         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2421
2422         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2423
2424 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2425
2426         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2427         https://bugs.webkit.org/show_bug.cgi?id=193787
2428         <rdar://problem/47497634>
2429
2430         Reviewed by Alexey Proskuryakov.
2431
2432         * Scripts/webkitdirs.pm:
2433         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2434
2435 2019-01-24  Truitt Savell  <tsavell@apple.com>
2436
2437         Unreviewed, rolling out r240446.
2438
2439         Casued 5 API failures
2440
2441         Reverted changeset:
2442
2443         "Activate the WebResourceLoadStatisticsStore in the
2444         NetworkProcess and deactivate it in the UIProcess."
2445         https://bugs.webkit.org/show_bug.cgi?id=193297
2446         https://trac.webkit.org/changeset/240446
2447
2448 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2449
2450         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2451         https://bugs.webkit.org/show_bug.cgi?id=193741
2452         <rdar://problem/47135030>
2453
2454         Reviewed by Antti Koivisto and Simon Fraser.
2455
2456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2457         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2458         (TestWebKitAPI::TEST):
2459
2460 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2461
2462         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2463         https://bugs.webkit.org/show_bug.cgi?id=193297
2464         <rdar://problem/47158841>
2465
2466         Reviewed by Alex Christensen.
2467
2468         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2469         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2470         activating the message used to trigger the callback when it is set.
2471
2472 2019-01-24  John Wilander  <wilander@apple.com>
2473
2474         Add Ad Click Attribution as an internal/experimental feature
2475         https://bugs.webkit.org/show_bug.cgi?id=193685
2476         <rdar://problem/47450399>
2477
2478         Reviewed by Brent Fulgham.
2479
2480         Added test option adClickAttributionEnabled.
2481
2482         * DumpRenderTree/TestOptions.cpp:
2483         (TestOptions::TestOptions):
2484         * DumpRenderTree/TestOptions.h:
2485         * DumpRenderTree/mac/DumpRenderTree.mm:
2486         (setWebPreferencesForTestOptions):
2487
2488 2019-01-24  Antti Koivisto  <antti@apple.com>
2489
2490         [PSON] Flash on back navigation on Mac
2491         https://bugs.webkit.org/show_bug.cgi?id=193716
2492         <rdar://problem/47148458>
2493
2494         Reviewed by Chris Dumez.
2495
2496         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2497
2498         Closing of the previous page is delayed so waiting for didFinishNavigation is
2499         not sufficient to guarantee we have received all the messages. Wait for them.
2500
2501 2019-01-24  Chris Dumez  <cdumez@apple.com>
2502
2503         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2504         https://bugs.webkit.org/show_bug.cgi?id=193761
2505         <rdar://problem/47456405>
2506
2507         Reviewed by Alex Christensen.
2508
2509         Add API test coverage.
2510
2511         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2512
2513 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2514
2515         webkitpy: Missing PID in crashlog name should not be fatal
2516         https://bugs.webkit.org/show_bug.cgi?id=193771
2517
2518         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2519         of raising an exception.
2520
2521         Reviewed by Lucas Forschler.
2522
2523         * Scripts/webkitpy/port/darwin.py:
2524         (DarwinPort._merge_crash_logs):
2525
2526 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2527
2528         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2529         https://bugs.webkit.org/show_bug.cgi?id=193746
2530
2531         Reviewed by Youenn Fablet.
2532
2533         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2534         so we'd best just not call it.
2535
2536         * Scripts/webkitpy/w3c/test_exporter.py:
2537         (WebPlatformTestExporter.create_branch_with_patch):
2538
2539 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2540
2541         Move FileSystem to WTF
2542         https://bugs.webkit.org/show_bug.cgi?id=193602
2543
2544         Reviewed by Yusuke Suzuki.
2545
2546         * DumpRenderTree/win/DumpRenderTree.cpp:
2547         * TestWebKitAPI/CMakeLists.txt:
2548         * TestWebKitAPI/PlatformGTK.cmake:
2549         * TestWebKitAPI/PlatformJSCOnly.cmake:
2550         * TestWebKitAPI/PlatformPlayStation.cmake:
2551         * TestWebKitAPI/PlatformWPE.cmake:
2552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2553         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2554         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2555         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2556         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2557         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2558         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2559         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2560         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2561         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2562
2563 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2564
2565         [WPE] Remove hard dependency on subprocess32 for the API tests
2566
2567         Rubber-stamped by Carlos Garcia Campos.
2568
2569         * glib/api_test_runner.py:
2570         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2571         its presence only when running WPEQt tests.
2572
2573 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2574
2575         [GLIB] Expose JavaScriptCore options in GLib public API
2576         https://bugs.webkit.org/show_bug.cgi?id=188742
2577
2578         Reviewed by Michael Catanzaro.
2579
2580         Add a test for the new API.
2581
2582         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2583         (testsJSCOptions):
2584         (main):
2585
2586 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2587
2588         [GTK][WPE] Support JPEG 2000 images
2589         https://bugs.webkit.org/show_bug.cgi?id=186272
2590
2591         Reviewed by Žan Doberšek.
2592
2593         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2594
2595         * gtk/jhbuild.modules:
2596         * wpe/jhbuild.modules:
2597
2598 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2599
2600         check-webkit-style should warn when using soft-linking macros in a header
2601         <https://webkit.org/b/193750>
2602
2603         Reviewed by Darin Adler.
2604
2605         * Scripts/webkitpy/style/checkers/cpp.py:
2606         (check_language): Add softlink/header check by refactoring the
2607         softlink/framework check.
2608         (CppChecker): Enable softlink/header check by default.
2609         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2610         (CppStyleTest.test_softlink_framework): Rename from
2611         CppStyleTest.test_softlink() and change test framework name in
2612         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2613         files. Set file_name for macros that only appear in headers.
2614         (CppStyleTest.test_softlink_header): Add tests for using
2615         soft-link macros in headers.
2616
2617 2019-01-23  Chris Dumez  <cdumez@apple.com>
2618
2619         Deprecate API to limit the maximum number of WebProcesses
2620         https://bugs.webkit.org/show_bug.cgi?id=193725
2621         <rdar://problem/47464879>
2622
2623         Reviewed by Geoff Garen.
2624
2625         Update existing API tests to stop using deprecated API.
2626
2627         * MiniBrowser/mac/AppDelegate.m:
2628         (defaultConfiguration):
2629         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2630         (TestWebKitAPI::TEST):
2631         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2632         (TestWebKitAPI::TEST):
2633         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2634         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2635         (TEST):
2636         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2637         (TEST):
2638
2639 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2640
2641         [ews-app] Rename ews model buildermappings to buildermapping
2642         https://bugs.webkit.org/show_bug.cgi?id=193729
2643
2644         Reviewed by Lucas Forschler.
2645
2646         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2647         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2648         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2649
2650 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2651
2652         [ews-app] Rename ews model steps to step
2653         https://bugs.webkit.org/show_bug.cgi?id=193697
2654
2655         Reviewed by Lucas Forschler.
2656
2657         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2658         (Step): Renamed Steps to Step.
2659
2660 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2661
2662         Clean up IndexedDB files between tests
2663         https://bugs.webkit.org/show_bug.cgi?id=192796
2664         <rdar://problem/46824999>
2665
2666         Reviewed by Geoffrey Garen.
2667
2668         * DumpRenderTree/mac/DumpRenderTree.mm:
2669         (runTest):
2670         * WebKitTestRunner/TestController.cpp:
2671         (WTR::TestController::resetStateToConsistentValues):
2672         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2673         (WTR::RemoveAllIndexedDatabasesCallback):
2674         (WTR::TestController::ClearIndexedDatabases):
2675         * WebKitTestRunner/TestController.h:
2676         * WebKitTestRunner/TestInvocation.cpp:
2677         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2678
2679 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2680
2681         [ews-app] Rename ews model Builds to Build
2682         https://bugs.webkit.org/show_bug.cgi?id=193695
2683
2684         Reviewed by Lucas Forschler.
2685
2686         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2687         (Build): Renamed Builds to Build.
2688
2689 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2690
2691         webkitpy: Wait longer when launching WebKitTestRunner
2692         https://bugs.webkit.org/show_bug.cgi?id=193734
2693
2694         Reviewed by Aakash Jain.
2695
2696         * Scripts/webkitpy/port/simulator_process.py:
2697         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2698
2699 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2700
2701         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2702         https://bugs.webkit.org/show_bug.cgi?id=193182
2703         <rdar://problem/47452154>
2704
2705         Reviewed by Tim Horton.
2706
2707         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2708         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2709         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2710
2711         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2712         preventing later tests from recognizing gestures.
2713
2714         * WebKitTestRunner/ios/TestControllerIOS.mm:
2715         (WTR::TestController::platformResetStateToConsistentValues):
2716
2717         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2718
2719 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2720
2721         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2722         https://bugs.webkit.org/show_bug.cgi?id=193722
2723         <rdar://problem/47481475>
2724
2725         Reviewed by Lucas Forschler.
2726
2727         iPhone and iPad ports should both use the iOS config.
2728
2729         * Scripts/webkitpy/port/ios_simulator.py:
2730         (IPhoneSimulatorPort.__init__):
2731         (IPadSimulatorPort.__init__):
2732
2733 2019-01-23  Rob Buis  <rbuis@igalia.com>
2734
2735         Update MIME type parser
2736         https://bugs.webkit.org/show_bug.cgi?id=180526
2737
2738         Reviewed by Frédéric Wang.
2739
2740         Add unit tests for both parse modes of ParsedContentType.
2741
2742         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2743         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2744         (TestWebKitAPI::TEST):
2745
2746 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2747
2748         [ews-app] fetch loop should not stop on network issues
2749         https://bugs.webkit.org/show_bug.cgi?id=193666
2750
2751         Reviewed by Lucas Forschler.
2752
2753         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2754         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2755
2756 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2757
2758         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2759         https://bugs.webkit.org/show_bug.cgi?id=189165
2760         <rdar://problem/47433765>
2761
2762         Reviewed by Tim Horton.
2763
2764         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2765         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2766         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2767         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2768         would make its way to the UI process by the time the layer tree commit is finished.
2769
2770         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2771         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2772         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2773         will fail because it asks for -_autofillContext too early.
2774
2775         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2776         is handled in the UI process.
2777
2778         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2779
2780         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2781         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2782         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2783         input session.
2784
2785         (-[AutofillTestView textInputHasAutofillContext]):
2786
2787         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2788
2789         * TestWebKitAPI/cocoa/TestWKWebView.h:
2790         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2791         (nextInputSessionChangeCount):
2792
2793         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2794         This includes changing the focused element from one to another.
2795
2796         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2797         (-[TestWKWebView didStartFormControlInteraction]):
2798         (-[TestWKWebView didEndFormControlInteraction]):
2799         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2800
2801         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2802         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2803         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2804         that doesn't require an input session to one that doesn't.
2805
2806 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2807
2808         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2809         <https://webkit.org/b/193676>
2810
2811         Reviewed by Alexey Proskuryakov.
2812
2813         * Scripts/webkitpy/style/checkers/cpp.py:
2814         (check_member_initialization_list):
2815         - Don't report missing whitespace around colon if the colon at
2816           the start of the line is formatted correctly.
2817         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2818         (WebKitStyleTest.test_member_initialization_list):
2819         - Add a test for a missing permutation of existing tests.
2820         - Add a test this false-positive.
2821         - Add blank lines between subtests to make them easier to read.
2822
2823 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2824
2825         [build.webkit.org] Unit-test failure after r237113
2826         https://bugs.webkit.org/show_bug.cgi?id=193669
2827
2828         Reviewed by Michael Catanzaro.
2829
2830         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2831         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2832         multiple or zero flags.
2833
2834 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2835
2836         Cache bytecode to disk
2837         https://bugs.webkit.org/show_bug.cgi?id=192782
2838         <rdar://problem/46084932>
2839
2840         Reviewed by Keith Miller.
2841
2842         Add test helper to execute bytecode-cache tests: it executes each test
2843         twice, the first with JSC_diskCachePath set to a temporary directory
2844         and second with JSC_forceDiskCache=true (in addition to the cache path)
2845         to guarantee that only the disk cache is being used and no new
2846         UnlinkedCodeBlocks are being created.
2847
2848         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2849         * Scripts/run-jsc-stress-tests:
2850
2851 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2852
2853         [css-logical] Implement flow-relative margin, padding and border shorthands
2854         https://bugs.webkit.org/show_bug.cgi?id=188697
2855
2856         Reviewed by Simon Fraser and Antti Koivisto.
2857
2858         * DumpRenderTree/TestOptions.cpp:
2859         (TestOptions::TestOptions):
2860         * DumpRenderTree/TestOptions.h:
2861         * DumpRenderTree/mac/DumpRenderTree.mm:
2862         (setWebPreferencesForTestOptions):
2863         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2864
2865         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2866         (JSONCSSPropertiesChecker.check_codegen_properties):
2867         Allow CSS property definitions to have a 'runtime-flag' parameter which
2868         disables the property when the specified runtime flag is disabled.
2869
2870 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2871
2872         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2873         https://bugs.webkit.org/show_bug.cgi?id=193643
2874
2875         Reviewed by Michael Catanzaro.
2876
2877         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2878         * wpe/jhbuild.modules: Ditto.
2879
2880 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2881
2882         [LFC][Floats] Take float top position into account when computing containing block height.
2883         https://bugs.webkit.org/show_bug.cgi?id=193655
2884
2885         Reviewed by Antti Koivisto.
2886
2887         * LayoutReloaded/misc/LFC-passing-tests.txt:
2888
2889 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2890
2891         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2892         <https://webkit.org/b/193645>
2893         <rdar://problem/47421574>
2894
2895         Reviewed by Alex Christensen.
2896
2897         - Now checks for local soft-linking of all frameworks that have
2898           their own *SoftLinking.{cpp,h,mm} files.
2899         - Changes softlink/uikit warning to softlink/framework.
2900
2901         * Scripts/webkitpy/style/checkers/cpp.py:
2902         (check_language):
2903         (CppChecker):
2904         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2905         (CppStyleTest):
2906
2907 2019-01-20  Saam Barati  <sbarati@apple.com>
2908
2909         Rollout r240210: It broke tests on iOS
2910         https://bugs.webkit.org/show_bug.cgi?id=193640
2911
2912         Unreviewed.
2913
2914         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2915         * Scripts/run-jsc-stress-tests:
2916
2917 2019-01-20  chris fleizach  <cfleizach@apple.com>
2918
2919         AX: Support returning relative frames for accessibility
2920         https://bugs.webkit.org/show_bug.cgi?id=193414
2921         <rdar://problem/47268501>
2922
2923         Reviewed by Zalan Bujtas.
2924
2925         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2926         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2927         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2928         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2929         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2930         (WTR::attributesOfElement):
2931         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2932
2933 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2934
2935         Unreviewed, add my new email address
2936
2937         * Scripts/webkitpy/common/config/contributors.json:
2938
2939 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2940
2941         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2942         https://bugs.webkit.org/show_bug.cgi?id=193617
2943
2944         Reviewed by Antti Koivisto.
2945
2946         * LayoutReloaded/misc/LFC-passing-tests.txt:
2947
2948 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2949
2950         Unreviewed, rolling out r240209.
2951
2952         Broke GTK/WPE injected bundle
2953
2954         Reverted changeset:
2955
2956         "AX: Support returning relative frames for accessibility"
2957         https://bugs.webkit.org/show_bug.cgi?id=193414
2958         https://trac.webkit.org/changeset/240209
2959
2960 2019-01-12  Dan Bernstein  <mitz@apple.com>
2961
2962         [Cocoa] Avoid importing directly from subumbrella frameworks
2963         https://bugs.webkit.org/show_bug.cgi?id=186016
2964         <rdar://problem/40591038>
2965
2966         Reviewed by Sam Weinig.
2967
2968         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2969           LaunchServices header.
2970         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2971           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2972         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2973           when using SDKs earlier than 10.13.
2974         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2975           and OTHER_CPLUSPLUSFLAGS.
2976         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2977           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2978         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2979           LaunchServices header.
2980
2981 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2982
2983         Cache bytecode to disk
2984         https://bugs.webkit.org/show_bug.cgi?id=192782
2985         <rdar://problem/46084932>
2986
2987         Reviewed by Keith Miller.
2988
2989         Add test helper to execute bytecode-cache tests: it executes each test
2990         twice, the first with JSC_diskCachePath set to a temporary directory
2991         and second with JSC_forceDiskCache=true (in addition to the cache path)
2992         to guarantee that only the disk cache is being used and no new
2993         UnlinkedCodeBlocks are being created.
2994
2995         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2996         * Scripts/run-jsc-stress-tests:
2997
2998 2019-01-20  chris fleizach  <cfleizach@apple.com>
2999
3000         AX: Support returning relative frames for accessibility
3001         https://bugs.webkit.org/show_bug.cgi?id=193414
3002         <rdar://problem/47268501>
3003
3004         Reviewed by Zalan Bujtas.
3005
3006         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3007         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3008         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3009         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3010         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3011         (WTR::attributesOfElement):
3012         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3013
3014 2019-01-20  Antoine Quint  <graouts@apple.com>
3015
3016         Add a POINTER_EVENTS feature flag
3017         https://bugs.webkit.org/show_bug.cgi?id=193577
3018         <rdar://problem/47408511>
3019
3020         Unreviewed. Also enable Pointer Events for iosmac.
3021
3022         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3023
3024 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3025
3026         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3027         https://bugs.webkit.org/show_bug.cgi?id=193613
3028
3029         Reviewed by Antti Koivisto.
3030
3031         * LayoutReloaded/misc/LFC-passing-tests.txt:
3032
3033 2019-01-19  Antoine Quint  <graouts@apple.com>
3034
3035         Add a POINTER_EVENTS feature flag
3036         https://bugs.webkit.org/show_bug.cgi?id=193577
3037
3038         Reviewed by Dean Jackson.
3039
3040         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3041
3042 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3043
3044         Disable the run-jsc-stress-test remote host key check [second round].
3045         https://bugs.webkit.org/show_bug.cgi?id=192988
3046
3047         Reviewed by Dewei Zhu.
3048
3049         * Scripts/run-jsc-stress-tests:
3050
3051 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3052
3053         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3054         https://bugs.webkit.org/show_bug.cgi?id=193597
3055
3056         Reviewed by Lucas Forschler.
3057
3058         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3059
3060 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3061
3062         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3063         https://bugs.webkit.org/show_bug.cgi?id=193595
3064
3065         Reviewed by Lucas Forschler.
3066
3067         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3068         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3069         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3070
3071 2019-01-18  Chris Dumez  <cdumez@apple.com>
3072
3073         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3074         https://bugs.webkit.org/show_bug.cgi?id=193588
3075         <rdar://problem/47131566>
3076
3077         Reviewed by Alex Christensen.
3078
3079         Add layout test coverage.
3080
3081         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3082
3083 2019-01-18  Jer Noble  <jer.noble@apple.com>
3084
3085         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3086         https://bugs.webkit.org/show_bug.cgi?id=189553
3087
3088         Reviewed by Tim Horton.
3089
3090         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3091
3092         * ContentExtensionTester/Configurations/Base.xcconfig:
3093         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3094         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3095         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3096         * ImageDiff/cg/Configurations/Base.xcconfig:
3097         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3098         * MiniBrowser/Configurations/Base.xcconfig:
3099         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3100         * MobileMiniBrowser/Configurations/Base.xcconfig:
3101         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3102         * Scripts/webkitpy/style/checker.py:
3103         (_all_categories):
3104         (FileType):
3105         (CheckerDispatcher._file_type):
3106         (CheckerDispatcher._create_checker):
3107         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3108         (SDKVariantChecker):
3109         (SDKVariantChecker.__init__):
3110         (SDKVariantChecker.check):
3111         * TestWebKitAPI/Configurations/Base.xcconfig:
3112         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3113         * WebEditingTester/Configurations/Base.xcconfig:
3114         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3115         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3116         * WebKitTestRunner/Configurations/Base.xcconfig:
3117         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3118         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3119         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3120
3121 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3122
3123         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3124         <https://webkit.org/b/193568>
3125         <rdar://problem/47381130>
3126
3127         Reviewed by Alex Christensen.
3128
3129         Make sure no one re-introduces UIKit soft-linking by adding a
3130         style rule.
3131
3132         * Scripts/webkitpy/style/checkers/cpp.py:
3133         (check_language): Add softlink/uikit check.
3134         (CppChecker): Enable softlink/uikit check.
3135         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3136         (CppStyleTest): Add test for softlink/uikit.
3137
3138 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3139
3140         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3141         https://bugs.webkit.org/show_bug.cgi?id=193584
3142
3143         Change "-dev" to "-devel".
3144
3145         Reviewed by Michael Catanzaro.
3146
3147         * gtk/install-dependencies:
3148
3149 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3150
3151         webkitpy: Add iPhone and iPad ports
3152         https://bugs.webkit.org/show_bug.cgi?id=193537
3153         <rdar://problem/47353390>
3154
3155         Reviewed by Lucas Forschler.
3156
3157         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3158         ports. Note that this separation is optional, the --ios-simulator command remains.
3159
3160         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3161         (RunTest.test_device_type_test_division): Drive-by fix.
3162         (RunTest.test_device_type_specific_listing): Ditto.
3163         (RunTest.test_ipad_test_division):
3164         (RunTest):
3165         (RunTest.test_ipad_listing):
3166         * Scripts/webkitpy/port/factory.py:
3167         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3168         (PortFactory):
3169         * Scripts/webkitpy/port/ios_simulator.py:
3170         (IPhoneSimulatorPort):
3171         (IPadSimulatorPort):
3172
3173 2019-01-18  Chris Dumez  <cdumez@apple.com>
3174
3175         Regression(PSON) Scroll position is not always restored properly when navigating back
3176         https://bugs.webkit.org/show_bug.cgi?id=193578
3177         <rdar://problem/47386331>
3178
3179         Reviewed by Tim Horton.
3180
3181         Add API test coverage.
3182
3183         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3184
3185 2019-01-18  Youenn Fablet  <youenn@apple.com>
3186
3187         Add a new SPI to request for cache storage quota increase
3188         https://bugs.webkit.org/show_bug.cgi?id=193323
3189
3190         Reviewed by Alex Christensen.
3191
3192         Implement WebsiteDataStore quota delegate to handle quota requests.
3193         By default, do not update quota.
3194         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3195
3196         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3197         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3198         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3199         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3200         * WebKitTestRunner/TestController.cpp:
3201         (WTR::TestController::allowCacheStorageQuotaIncrease):
3202         * WebKitTestRunner/TestController.h:
3203         * WebKitTestRunner/TestInvocation.cpp:
3204         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3205         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3206         (-[CacheStorageQuotaManager init]):
3207         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3208         (WTR::initializeWebViewConfiguration):
3209         (WTR::TestController::cocoaResetStateToConsistentValues):
3210         (WTR::TestController::allowCacheStorageQuotaIncrease):
3211
3212 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3213
3214         [ews-build] Pass owner to the triggered builds
3215         https://bugs.webkit.org/show_bug.cgi?id=193574
3216
3217         Reviewed by Lucas Forschler.
3218
3219         * BuildSlaveSupport/ews-build/factories.py:
3220         (BuildFactory.propertiesToPassToTriggers):
3221
3222 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3223
3224         [ews-app] Send patch author as a build property
3225         https://bugs.webkit.org/show_bug.cgi?id=193560
3226
3227         Reviewed by Lucas Forschler.
3228
3229         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3230         (BugzillaPatchFetcher.fetch):
3231
3232 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3233
3234         webkitpy: Implement device type specific expected results (Follow-up fix)
3235         https://bugs.webkit.org/show_bug.cgi?id=192162
3236         <rdar://problem/46345449>
3237
3238         Unreviewed infrastructure fix.
3239
3240         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3241         (Manager.run): Don't boot a device if no tests are available to run on it.
3242
3243 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3244
3245         webkitpy: Implement device type specific expected results (Follow-up fix)
3246         https://bugs.webkit.org/show_bug.cgi?id=192162
3247         <rdar://problem/46345449>
3248
3249         Unreviewed infrastructure fix.
3250
3251         * Scripts/webkitpy/api_tests/manager.py:
3252         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3253
3254 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3255
3256         webkitpy: Implement device type specific expected results (Part 2)
3257         https://bugs.webkit.org/show_bug.cgi?id=192162
3258         <rdar://problem/46345449>
3259
3260         Rubber-stamped by Aakash Jain.
3261
3262         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3263         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3264         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3265
3266         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3267         (LayoutTestFinder.find_tests): Pass device_type through.
3268         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3269         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3270         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3271         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3272         (Manager._collect_tests): Pass device type to test finder.
3273         (Manager._needs_web_platform_test):
3274         (Manager._prepare_lists): Index _expectations by device type.
3275         (Manager._test_input_for_file):
3276         (Manager._test_is_slow): Ditto.
3277         (Manager._test_should_dump_jsconsolelog_in_stderr):
3278         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3279         (Manager._get_test_inputs):
3280         (Manager._update_worker_count):
3281         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3282         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3283         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3284         the one which runs the test.
3285         (Manager._run_test_subset):
3286         (Manager._run_tests): Index _expectations by current_device_type.
3287         (Manager._print_expectation_line_for_test): Ditto.
3288         (Manager._print_expectations_for_subset): Ditto.
3289         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3290         Unlike run, this function will behave the same regardless of what devices are available.
3291         (Manager._custom_device_for_test): Deleted.
3292         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3293         (ManagerTest.test_uses_custom_device): Deleted.
3294         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3295         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3296         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3297         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3298         all of the expectations.
3299         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3300         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3301         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3302         (TestExpectations.__init__): Allow device_type to be passed through.
3303         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3304         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3305         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3306         (summarize_results):
3307         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3308         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3309         a test ran with, one must check all expectations to find the first non-skip expectation.
3310         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3311         (RunTest.test_device_type_test_division):
3312         (RunTest):
3313         (RunTest.test_device_type_specific_listing):
3314         * Scripts/webkitpy/port/base.py:
3315         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3316         (Port.supported_device_types): The result of this function will change based on what devices are available.
3317         * Scripts/webkitpy/port/device_port.py:
3318         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3319         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3320         can be used.
3321         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3322         any, or the DEFAULT_DEVICE_TYPES of the port.
3323         * Scripts/webkitpy/port/ios.py:
3324         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3325         * Scripts/webkitpy/port/ios_simulator.py:
3326         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3327         * Scripts/webkitpy/port/watch.py:
3328         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3329         * Scripts/webkitpy/port/watch_simulator.py:
3330         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3331         * Scripts/webkitpy/xcode/device_type.py:
3332         (DeviceType):
3333         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3334
3335 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3336
3337         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3338         https://bugs.webkit.org/show_bug.cgi?id=193575
3339
3340         Reviewed by Michael Catanzaro.
3341
3342         Allow the script to run without explicit port argument because
3343         it's specific to the WPE port anyway.
3344
3345         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3346         and simplify the rest of the code accordingly.
3347
3348 2019-01-18  Charlie Turner  <cturner@igalia.com>
3349
3350         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3351         https://bugs.webkit.org/show_bug.cgi?id=192229
3352
3353         Reviewed by Xabier Rodriguez-Calvar.
3354
3355         * MiniBrowser/wpe/main.cpp:
3356         (main): Enable encrypted-media by default.
3357
3358 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3359
3360         [Flatpak] Missing KeyboardInterrupt exception handler
3361         https://bugs.webkit.org/show_bug.cgi?id=193570
3362
3363         Reviewed by Michael Catanzaro.
3364
3365         * flatpak/flatpakutils.py:
3366         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3367
3368 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3369
3370         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3371         https://bugs.webkit.org/show_bug.cgi?id=193564
3372
3373         Reviewed by Antti Koivisto.
3374
3375         * LayoutReloaded/misc/LFC-passing-tests.txt:
3376
3377 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3378
3379         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3380         https://bugs.webkit.org/show_bug.cgi?id=193562
3381
3382         Reviewed by Antti Koivisto.
3383
3384         * LayoutReloaded/misc/LFC-passing-tests.txt:
3385
3386 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3387
3388         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3389         https://bugs.webkit.org/show_bug.cgi?id=193555
3390
3391         Reviewed by Antti Koivisto.
3392
3393         * LayoutReloaded/misc/LFC-passing-tests.txt:
3394
3395 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3396
3397         [WPE] Add Qt extension
3398         https://bugs.webkit.org/show_bug.cgi?id=191464
3399
3400         Reviewed by Carlos Garcia Campos.
3401
3402         MiniBrowser and API tests for the WPE Qt API. To run the
3403         MiniBrowser a new script is introduced. Example invocation:
3404
3405         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3406
3407         Also note-worthy is the introduction of the python2-subprocess32
3408         dependency to run the GLib API tests.
3409
3410         * MiniBrowser/wpe/CMakeLists.txt:
3411         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3412         * MiniBrowser/wpe/qt/main.cpp: Added.
3413         (main):
3414         * MiniBrowser/wpe/qt/main.qml: Added.
3415         * MiniBrowser/wpe/qt/qml.qrc: Added.
3416         * Scripts/run-gtk-tests:
3417         (GtkTestRunner.is_google_test):
3418         (GtkTestRunner):
3419         (GtkTestRunner.is_qt_test):
3420         * Scripts/run-qt-wpe-minibrowser: Added.
3421         * Scripts/run-wpe-tests:
3422         (WPETestRunner):
3423         (WPETestRunner.is_google_test):
3424         (WPETestRunner.is_qt_test):
3425         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3426         (TestLoad::main):
3427         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3428         (TestLoadHtml::main):
3429         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3430         (TestLoadRequest::main):
3431         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3432         (TestRunJavaScript::main):
3433         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3434         (waitForSignal):
3435         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3436         (LoadSpy::LoadSpy):
3437         (LoadSpy::~LoadSpy):
3438         (LoadSpy::onLoadingChanged):
3439         (LoadStartedCatcher::LoadStartedCatcher):
3440         (LoadStartedCatcher::~LoadStartedCatcher):
3441         (LoadStartedCatcher::onLoadingChanged):
3442         (waitForLoadSucceeded):
3443         (waitForLoadFailed):
3444         * TestWebKitAPI/glib/CMakeLists.txt:
3445         * flatpak/flatpakutils.py:
3446         (WebkitFlatpak.load_from_args):
3447         (WebkitFlatpak.__init__):
3448         (WebkitFlatpak.clean_args):
3449         (WebkitFlatpak.run_in_sandbox):
3450         * flatpak/org.webkit.CommonModules.yaml:
3451         * flatpak/org.webkit.WPE.yaml:
3452         * flatpak/org.webkit.WPEModules.yaml:
3453         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3454         * flatpak/org.webkit.WebKit.yaml:
3455         * glib/api_test_runner.py:
3456         (TestRunner._run_test_qt):
3457         (TestRunner.is_qt_test):
3458         (TestRunner._run_test):
3459
3460 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3461
3462         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3463         https://bugs.webkit.org/show_bug.cgi?id=193494
3464         <rdar://problem/46859627>
3465
3466         Reviewed by Simon Fraser and Tim Horton.
3467
3468         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3469         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3470
3471         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3472         (WTR::UIScriptController::contentOffsetX const):
3473         (WTR::UIScriptController::contentOffsetY const):
3474         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3475         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3476         (WTR::UIScriptController::contentOffsetX const):
3477         (WTR::UIScriptController::contentOffsetY const):
3478         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3479
3480         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3481
3482         * WebKitTestRunner/TestController.cpp:
3483         (WTR::updateTestOptionsFromTestHeader):
3484         * WebKitTestRunner/TestOptions.h:
3485         (WTR::TestOptions::hasSameInitializationOptions const):
3486         * WebKitTestRunner/ios/TestControllerIOS.mm:
3487         (WTR::TestController::platformResetStateToConsistentValues):
3488         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3489         (WTR::UIScriptController::contentOffsetX const):
3490         (WTR::UIScriptController::contentOffsetY const):
3491
3492 2019-01-17  Truitt Savell  <tsavell@apple.com>
3493
3494         Unreviewed, rolling out r240124.
3495
3496         This commit broke an internal build.
3497
3498         Reverted changeset:
3499
3500         "SDK_VARIANT build destinations should be separate from non-
3501         SDK_VARIANT builds"
3502         https://bugs.webkit.org/show_bug.cgi?id=189553
3503         https://trac.webkit.org/changeset/240124
3504
3505 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3506
3507         Fix string concatenation API test after r239920
3508         https://bugs.webkit.org/show_bug.cgi?id=193551
3509         <rdar://problem/47359304>
3510
3511         Reviewed by Youenn Fablet.
3512
3513         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3514         (TestWebKitAPI::TEST):
3515         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3516         in WebKit's build configuration like it apparently is on Linux.
3517
3518 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3519
3520         [ews-build] validate-patch should handle the case when bug_id is None
3521         https://bugs.webkit.org/show_bug.cgi?id=193547
3522
3523         Reviewed by Lucas Forschler.
3524
3525         * BuildSlaveSupport/ews-build/steps.py:
3526         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3527         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3528
3529 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3530
3531         [ews-build] Add patch author information in build
3532         https://bugs.webkit.org/show_bug.cgi?id=193465
3533
3534         Reviewed by Lucas Forschler.
3535
3536         * BuildSlaveSupport/ews-build/steps.py:
3537         (ValidatePatch._is_patch_obsolete):
3538
3539 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3540
3541         [ews-build] Pass bug_id to the triggered builds
3542         https://bugs.webkit.org/show_bug.cgi?id=193548
3543
3544         Reviewed by Lucas Forschler.
3545
3546         * BuildSlaveSupport/ews-build/factories.py:
3547         (BuildFactory.propertiesToPassToTriggers):
3548
3549 2019-01-17  Jer Noble  <jer.noble@apple.com>
3550
3551         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3552         https://bugs.webkit.org/show_bug.cgi?id=189553
3553
3554         Reviewed by Tim Horton.
3555
3556         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3557
3558         * ContentExtensionTester/Configurations/Base.xcconfig:
3559         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3560         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3561         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3562         * ImageDiff/cg/Configurations/Base.xcconfig:
3563         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3564         * MiniBrowser/Configurations/Base.xcconfig:
3565         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3566         * MobileMiniBrowser/Configurations/Base.xcconfig:
3567         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3568         * Scripts/webkitpy/style/checker.py:
3569         (_all_categories):
3570         (FileType):
3571         (CheckerDispatcher._file_type):
3572         (CheckerDispatcher._create_checker):
3573         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3574         (SDKVariantChecker):
3575         (SDKVariantChecker.__init__):
3576         (SDKVariantChecker.check):
3577         * TestWebKitAPI/Configurations/Base.xcconfig:
3578         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3579         * WebEditingTester/Configurations/Base.xcconfig:
3580         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3581         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3582         * WebKitTestRunner/Configurations/Base.xcconfig:
3583         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3584         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3585         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3586
3587 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3588
3589         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3590         https://bugs.webkit.org/show_bug.cgi?id=193534
3591
3592         Reviewed by Antti Koivisto.
3593
3594         * LayoutReloaded/misc/LFC-passing-tests.txt:
3595
3596 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3597
3598         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3599         https://bugs.webkit.org/show_bug.cgi?id=193528
3600
3601         Reviewed by Antti Koivisto.
3602
3603         * LayoutReloaded/misc/LFC-passing-tests.txt:
3604
3605 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3606
3607         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3608         https://bugs.webkit.org/show_bug.cgi?id=193520
3609
3610         Reviewed by Antti Koivisto.
3611
3612         * LayoutReloaded/misc/LFC-passing-tests.txt:
3613
3614 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3615
3616         [ews-build] unapply-patch step should not update source
3617         https://bugs.webkit.org/show_bug.cgi?id=193234
3618
3619         Reviewed by Lucas Forschler.
3620
3621         * BuildSlaveSupport/ews-build/steps.py:
3622         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3623         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3624
3625 2019-01-16  Youenn Fablet  <youenn@apple.com>
3626
3627         Add a new SPI for controlling getUserMedia
3628         https://bugs.webkit.org/show_bug.cgi?id=192793
3629
3630         Reviewed by Eric Carlson.
3631
3632         * MiniBrowser/mac/WK2BrowserWindowController.m:
3633         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3634         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3635         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3636         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3637         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3638         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3639         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3640         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3641         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3642         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3643         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3644         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3645         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3646         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3647
3648 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3649
3650         [LFC][BFC] Inflow non-replaced used width should not be negative.
3651         https://bugs.webkit.org/show_bug.cgi?id=193495
3652
3653         Reviewed by Antti Koivisto.
3654
3655         * LayoutReloaded/misc/LFC-passing-tests.txt:
3656
3657 2019-01-16  Chris Dumez  <cdumez@apple.com>
3658
3659         Regression(PSON) View becomes blank after click a cross-site download link
3660         https://bugs.webkit.org/show_bug.cgi?id=193361
3661         <rdar://problem/47099573>
3662
3663         Reviewed by Geoffrey Garen.
3664
3665         Add API test coverage.
3666
3667         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3668         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3669
3670 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3671
3672         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3673         https://bugs.webkit.org/show_bug.cgi?id=193470
3674
3675         Reviewed by Antti Koivisto.
3676
3677         * LayoutReloaded/misc/LFC-passing-tests.txt:
3678
3679 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3680
3681         [LFC] Adjust margin box verification.
3682         https://bugs.webkit.org/show_bug.cgi?id=193482
3683
3684         Reviewed by Antti Koivisto.
3685
3686         * LayoutReloaded/misc/LFC-passing-tests.txt:
3687
3688 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3689
3690         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3691         https://bugs.webkit.org/show_bug.cgi?id=193451
3692
3693         Reviewed by Geoffrey Garen.
3694
3695         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3696         (TEST):
3697         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3698         (runWebsiteDataStoreCustomPaths):
3699
3700 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3701
3702         webkitpy: Support boolean simctl isAvailable
3703         https://bugs.webkit.org/show_bug.cgi?id=193472
3704         <rdar://problem/47296150>
3705
3706         Reviewed by Ryosuke Niwa.
3707
3708         * Scripts/webkitpy/xcode/simulated_device.py:
3709         (SimulatedDeviceManager._create_runtimes):
3710         (SimulatedDeviceManager._create_device_with_runtime):
3711
3712 2019-01-15  Chris Dumez  <cdumez@apple.com>
3713
3714         Unreviewed, rolling out r239993, r239995, r239997, and
3715         r239999.
3716
3717         Caused assertions under
3718         ViewGestureController::disconnectFromProcess()
3719
3720         Reverted changesets:
3721
3722         "Regression(PSON) View becomes blank after click a cross-site
3723         download link"
3724         https://bugs.webkit.org/show_bug.cgi?id=193361
3725         https://trac.webkit.org/changeset/239993
3726
3727         "Unreviewed iOS build fix after r239993."
3728         https://trac.webkit.org/changeset/239995
3729
3730         "Fix iOS build after r239993"
3731         https://bugs.webkit.org/show_bug.cgi?id=193361
3732         https://trac.webkit.org/changeset/239997
3733
3734         "Unreviewed, revert part of r239997 as it is not needed to fix
3735         the build."
3736         https://trac.webkit.org/changeset/239999
3737
3738 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3739
3740         Cannot tab out of WKWebView on macOS
3741         https://bugs.webkit.org/show_bug.cgi?id=161448
3742         <rdar://problem/28100085>
3743
3744         Reviewed by Dean Jackson.
3745
3746         Add a test that tabbing into and out of WKWebView works correctly.
3747
3748         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3749         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3750         (WebKit2_CommandBackForwardTest::SetUp):
3751         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3752         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3753         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3754         (-[FocusableView canBecomeKeyView]):
3755         (TEST):
3756         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3757         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3758         (-[OffscreenWindow initWithSize:]):
3759         (-[OffscreenWindow isKeyWindow]):
3760         (-[OffscreenWindow isVisible]):
3761         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3762         (TestWebKitAPI::PlatformWebView::initialize):
3763         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3764         (-[ActiveOffscreenWindow isVisible]): Deleted.
3765         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3766
3767 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3768
3769         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3770         https://bugs.webkit.org/show_bug.cgi?id=193459
3771
3772         Reviewed by Mark Lam.
3773
3774         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3775         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3776
3777 2019-01-15  Chris Dumez  <cdumez@apple.com>
3778
3779         Regression(PSON) View becomes blank after click a cross-site download link
3780         https://bugs.webkit.org/show_bug.cgi?id=193361
3781         <rdar://problem/47099573>
3782
3783         Reviewed by Geoff Garen.
3784
3785         Add API test coverage.
3786
3787         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3788         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3789
3790 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3791
3792         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3793         https://bugs.webkit.org/show_bug.cgi?id=193448
3794
3795         Reviewed by Antti Koivisto.
3796
3797         * LayoutReloaded/misc/LFC-passing-tests.txt:
3798
3799 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3800
3801         webkitpy: Implement device type specific expected results (Part 1)
3802         https://bugs.webkit.org/show_bug.cgi?id=192162
3803
3804         Reviewed by Lucas Forschler.
3805
3806         Device type specific expected results covers two related ideas. The first (covered by this change)
3807         is where to search for -expected.* files. The second is which tests to run based on the
3808         TestExpectations.txt file.
3809
3810         After this change, the baseline search path will be determined by the type of device running a
3811         test. Device type will be passed into any function which picks a file based on the baseline search
3812         path.
3813
3814         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3815         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3816         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3817         (Manager.run): Print baseline search path for each round of devices.
3818         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3819         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3820         (SingleTestRunner._expected_driver_output): Ditto.
3821         (SingleTestRunner._driver_input): Ditto.
3822         * Scripts/webkitpy/layout_tests/views/printing.py:
3823         (Printer.print_config): Move printing of baseline search path to a separate function.
3824         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3825         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3826         (Testprinter.test_print_config):
3827         (Testprinter.test_print_baseline_search_path):
3828         * Scripts/webkitpy/port/base.py:
3829         (Port.baseline_search_path): Pass device_type through.
3830         (Port._expected_baselines_for_suffixes): Ditto.
3831         (Port.expected_baselines): Ditto.
3832         (Port.expected_filename): Ditto.
3833         (Port.expected_checksum): Ditto.
3834         (Port.expected_image): Ditto.
3835         (Port.expected_audio): Ditto.
3836         (Port.expected_text): Ditto.
3837         (Port.reference_files): Ditto.
3838         (Port.tests): Ditto.
3839         (Port._expanded_paths): Ditto.
3840         (Port.skipped_layout_tests): Ditto.
3841         (Port.expectations_dict): Ditto.
3842         (Port._port_specific_expectations_files): Ditto.
3843         (Port.expectations_files): Ditto.
3844         (Port.test_search_path): Ditto.
3845         (Port._tests_for_other_platforms): Ditto.
3846         * Scripts/webkitpy/port/base_unittest.py:
3847         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3848         (PortTest.test_nonexistant_expectations): Ditto.
3849         (test_ref_tests_platform_directory): Ditto.
3850         * Scripts/webkitpy/port/darwin.py:
3851         (DarwinPort._port_specific_expectations_files): Accept device_type.
3852         * Scripts/webkitpy/port/driver.py:
3853         (DriverProxy):
3854         (DriverProxy.host): Expose _target_host for device_type information.
3855         * Scripts/webkitpy/port/gtk.py:
3856         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3857         * Scripts/webkitpy/port/ios.py:
3858         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3859         * Scripts/webkitpy/port/mac.py:
3860         (MacPort. default_baseline_search_path): Ditto.
3861         * Scripts/webkitpy/port/port_testcase.py:
3862         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3863         * Scripts/webkitpy/port/test.py:
3864         * Scripts/webkitpy/port/watch.py:
3865         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3866         * Scripts/webkitpy/port/win.py:
3867         (WinPort.test_search_path): Accept, but do not use, device_type.
3868         * Scripts/webkitpy/port/wpe.py:
3869         (WPEPort._port_specific_expectations_files): Ditto.
3870         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3871         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3872
3873 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3874
3875         [LFC] Use the containing block's padding box to position out-of-flow elements.
3876         https://bugs.webkit.org/show_bug.cgi?id=193431
3877
3878         Reviewed by Antti Koivisto.
3879
3880         * LayoutReloaded/misc/LFC-passing-tests.txt:
3881
3882 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3883
3884         Move a test implementation file that got misplaced in the Xcode project
3885
3886         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3887
3888 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3889
3890         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3891         r239913, and r239914.
3892         https://bugs.webkit.org/show_bug.cgi?id=193407
3893
3894         These revisions caused an internal failure (Requested by
3895         Truitt on #webkit).
3896
3897         Reverted changesets:
3898
3899         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3900         https://bugs.webkit.org/show_bug.cgi?id=186016
3901         https://trac.webkit.org/changeset/239901
3902
3903         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3904         https://trac.webkit.org/changeset/239909
3905
3906         "Tried to fix the build."
3907         https://trac.webkit.org/changeset/239910
3908
3909         "Fixed iOS builds after r239910."
3910         https://trac.webkit.org/changeset/239912
3911
3912         "More build fixing."
3913         https://trac.webkit.org/changeset/239913
3914
3915         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3916         https://trac.webkit.org/changeset/239914
3917
3918 2019-01-14  Mark Lam  <mark.lam@apple.com>
3919
3920         Re-enable ability to build --cloop builds.
3921         https://bugs.webkit.org/show_bug.cgi?id=192955
3922         <rdar://problem/46882363>
3923
3924         Reviewed by Saam barati and Keith Miller.
3925
3926         The --cloop build option was being ignored this whole time since r236381.
3927         This patch makes it possible to build CLoop builds again.
3928
3929         * Scripts/build-jsc:
3930         * Scripts/webkitperl/FeatureList.pm:
3931         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3932
3933 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3934
3935         webkitpy: Expose device_type from host-like objects
3936         https://bugs.webkit.org/show_bug.cgi?id=193406
3937         <rdar://problem/47262305>
3938
3939         Reviewed by Lucas Forschler.
3940
3941         Devices should expose device_type. As a result, all host objects should
3942         provide a device_type property, even if they do not yet define a device_type.
3943
3944         * Scripts/webkitpy/common/system/systemhost.py:
3945         (SystemHost):
3946         (SystemHost.device_type):
3947         * Scripts/webkitpy/common/system/systemhost_mock.py:
3948         (MockSystemHost):
3949         (MockSystemHost.device_type):
3950         * Scripts/webkitpy/port/device.py:
3951         (Device):
3952         (Device.device_type):
3953         * Scripts/webkitpy/xcode/simulated_device.py:
3954         (SimulatedDeviceManager._find_exisiting_device_for_request):
3955         (SimulatedDeviceManager._disambiguate_device_type):
3956         (SimulatedDeviceManager._does_fulfill_request):
3957         (SimulatedDeviceManager.device_count_for_type):
3958         (SimulatedDeviceManager.initialize_devices):
3959         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3960         (test_available_devices):
3961         (test_swapping_devices):
3962
3963 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3964
3965         webkitpy: Support alternate simctl device list output (Follow-up fix)
3966         https://bugs.webkit.org/show_bug.cgi?id=193362
3967         <rdar://problem/47122965>
3968
3969         Rubber-stamped by Lucas Forschler.
3970
3971         * Scripts/webkitpy/xcode/simulated_device.py:
3972         (SimulatedDeviceManager.populate_available_devices):
3973
3974 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3975
3976         [iOS] Expose SPI to access the current sentence boundary and selection state
3977         https://bugs.webkit.org/show_bug.cgi?id=193398
3978         <rdar://problem/45893108>
3979
3980         Reviewed by Dean Jackson.
3981
3982         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3983         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3984         expected.
3985
3986         * TestWebKitAPI/EditingTestHarness.h:
3987         * TestWebKitAPI/EditingTestHarness.mm:
3988         (-[EditingTestHarness moveBackward]):
3989         (-[EditingTestHarness moveForward]):
3990         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3991
3992         Add a couple of new helper methods on EditingTestHarness.
3993
3994         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3995         (-[SelectionChangeObserver initWithWebView:]):
3996         (-[SelectionChangeObserver webView]):
3997         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3998         (-[SelectionChangeObserver currentSelectionAttributes]):
3999
4000 2019-01-14  Zalan Bujtas  <zalan@apple.com>
4001
4002         [LFC][BFC] Add basic box-sizing support.
4003         https://bugs.webkit.org/show_bug.cgi?id=193392
4004
4005         Reviewed by Antti Koivisto.
4006
4007         * LayoutReloaded/misc/LFC-passing-tests.txt:
4008
4009 2019-01-14  Charlie Turner  <cturner@igalia.com>
4010
4011         [WPE] API test gardening
4012         https://bugs.webkit.org/show_bug.cgi?id=193319
4013
4014         Reviewed by Michael Catanzaro.
4015
4016         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
4017         passing tests.
4018
4019 2019-01-14  Charlie Turner  <cturner@igalia.com>
4020
4021         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
4022         https://bugs.webkit.org/show_bug.cgi?id=192977
4023
4024         Reviewed by Carlos Garcia Campos.
4025
4026         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
4027         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
4028         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
4029         (TestWebKitAPI::GStreamerTest::SetUp):
4030         (TestWebKitAPI::GStreamerTest::TearDown):
4031         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
4032         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
4033         (TestWebKitAPI::TEST_F):
4034
4035 2019-01-14  Charlie Turner  <cturner@igalia.com>
4036
4037         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
4038         https://bugs.webkit.org/show_bug.cgi?id=193332
4039
4040         Reviewed by Michael Catanzaro.
4041
4042         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
4043         defined as a char16_t, which changed in ICU 59, the
4044         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
4045         unsigned short. This test is relying on the behaviour that
4046         UChar=unsigned short, which doesn't hold across platforms and ICU
4047         library versions. The full fix would be a special syntax for
4048         literal characters so that these ambiguities do not arise. That
4049         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
4050         (TestWebKitAPI::TEST):
4051
4052 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4053
4054         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
4055
4056         * Scripts/make-dist:
4057         (Distcheck.configure):
4058
4059 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
4060
4061         [ews-build] Update macOS queue configurations
4062         https://bugs.webkit.org/show_bug.cgi?id=193365
4063         <rdar://problem/47221073>
4064
4065         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
4066
4067         * BuildSlaveSupport/ews-build/config.json:
4068
4069 2019-01-13  Zalan Bujtas  <zalan@apple.com>
4070
4071         [LFC] Adjust assert for statically positioned fixed elements
4072         https://bugs.webkit.org/show_bug.cgi?id=193385
4073
4074         Reviewed by Antti Koivisto.
4075
4076         * LayoutReloaded/misc/LFC-passing-tests.txt:
4077
4078 2019-01-13  Philippe Normand  <pnormand@igalia.com>
4079
4080         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
4081         https://bugs.webkit.org/show_bug.cgi?id=193387
4082
4083         Reviewed by Carlos Garcia Campos.
4084
4085         * MiniBrowser/wpe/main.cpp:
4086         (main):
4087
4088 2019-01-12  Timothy Hatcher  <timothy@apple.com>
4089
4090         Have prefers-color-scheme: light always match on macOS versions before Mojave.
4091         https://bugs.webkit.org/show_bug.cgi?id=191655
4092         rdar://problem/46074680
4093
4094         Reviewed by Megan Gardner.
4095
4096         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
4097         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
4098
4099 2019-01-12  Dan Bernstein  <mitz@apple.com>
4100
4101         [Cocoa] Avoid importing directly from subumbrella frameworks
4102         https://bugs.webkit.org/show_bug.cgi?id=186016
4103         <rdar://problem/40591038>
4104
4105         Reviewed by Sam Weinig.
4106
4107         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4108           LaunchServices header.
4109         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4110           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4111         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4112           when using SDKs earlier than 10.13.
4113         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4114           and OTHER_CPLUSPLUSFLAGS.
4115         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4116           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4117         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4118           LaunchServices header.
4119
4120 2019-01-11  John Wilander  <wilander@apple.com>
4121
4122         Compile out Web API Statistics Collection
4123         https://bugs.webkit.org/show_bug.cgi?id=193370
4124         <rdar://problem/45388584>
4125
4126         Reviewed by Brent Fulgham.
4127
4128         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4129             Defined ENABLE_WEB_API_STATISTICS, off by default.
4130
4131 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4132
4133         [WPE] Add gtk-doc
4134         https://bugs.webkit.org/show_bug.cgi?id=178900
4135
4136         Reviewed by Michael Catanzaro.
4137
4138         Add Tools/gtkdoc to manifest.txt.in files.
4139         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
4140
4141         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
4142         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
4143
4144 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4145
4146         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
4147         https://bugs.webkit.org/show_bug.cgi?id=193364
4148         <rdar://problem/47214117>
4149
4150         Reviewed by Tim Horton.
4151
4152         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
4153         precise, whereas dragging near the middle of the textarea does.
4154
4155         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4156         (TestWebKitAPI::TEST):
4157
4158 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4159
4160         webkitpy: Support alternate simctl device list output
4161         https://bugs.webkit.org/show_bug.cgi?id=193362
4162         <rdar://problem/47122965>
4163
4164         Reviewed by Lucas Forschler.
4165
4166         * Scripts/webkitpy/xcode/simulated_device.py:
4167         (SimulatedDeviceManager.populate_available_devices):
4168
4169 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
4170
4171         [ews-build] Update macOS queue configurations
4172         https://bugs.webkit.org/show_bug.cgi?id=193365
4173
4174         Reviewed by Lucas Forschler.
4175
4176         * BuildSlaveSupport/ews-build/config.json:
4177
4178 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4179
4180         webkitpy: Incorporate device type into baseline search path
4181         https://bugs.webkit.org/show_bug.cgi?id=193356
4182         <rdar://problem/47215515>
4183
4184         Reviewed by Lucas Forschler.
4185
4186         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
4187
4188         * Scripts/webkitpy/port/base.py:
4189         (Port.default_baseline_search_path): Allow device type to be passed in.
4190         * Scripts/webkitpy/port/gtk.py:
4191         (GtkPort.default_baseline_search_path): Ignore device type.
4192         * Scripts/webkitpy/port/ios.py:
4193         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
4194         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
4195         * Scripts/webkitpy/port/ios_device_unittest.py:
4196         (IOSDeviceTest):
4197         * Scripts/webkitpy/port/ios_simulator_unittest.py:
4198         (IOSSimulatorTest):
4199         * Scripts/webkitpy/port/mac.py:
4200         (MacPort.default_baseline_search_path): Ignore device type.
4201         * Scripts/webkitpy/port/watch.py:
4202         (WatchPort.default_baseline_search_path): Ditto.
4203         * Scripts/webkitpy/port/win.py:
4204         (WinPort.default_baseline_search_path): Ditto.
4205         (WinCairoPort.default_baseline_search_path): Ditto.
4206         * Scripts/webkitpy/port/wpe.py:
4207         (WPEPort.default_baseline_search_path): Ditto.
4208
4209 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4210
4211         webkitpy: Print abbreviated baseline search path that includes only folders that exist
4212         https://bugs.webkit.org/show_bug.cgi?id=193352
4213         <rdar://problem/47210736>
4214
4215         Reviewed by Lucas Forschler.
4216
4217         * Scripts/webkitpy/layout_tests/views/printing.py:
4218         (Printer.print_config): Print list on only baseline search paths which exist. 
4219         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4220         (Testprinter.test_print_config):
4221
4222 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
4223
4224         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
4225         https://bugs.webkit.org/show_bug.cgi?id=193340
4226
4227         Reviewed by David Kilzer.
4228
4229         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4230         (WTR::InjectedBundle::didReceiveMessageToPage):
4231         Pull the strings out into a WKRetainPtr.
4232
4233         * WebKitTestRunner/WebNotificationProvider.cpp:
4234         (WTR::WebNotificationProvider::closeWebNotification):
4235         Adopt the created value into the WKRetainPtr.
4236
4237         * WebKitTestRunner/mac/TestControllerMac.mm:
4238         (WTR::generateWhitelist):
4239         Immediately adopt a created value to avoid potential mistakes.
4240
4241 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
4242
4243         Enable DFG on ARM/Linux again
4244         https://bugs.webkit.org/show_bug.cgi?id=192496
4245
4246         Reviewed by Yusuke Suzuki.
4247
4248         After changing the bytecode format DFG was disabled on all 32-bit
4249         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
4250         on ARM by default.
4251
4252         * Scripts/run-jsc-stress-tests:
4253
4254 2019-01-11  Timothy Hatcher  <timothy@apple.com>
4255
4256         Unreviewed, fix #ifdef in API test added in r239851.
4257         https://bugs.webkit.org/show_bug.cgi?id=193327
4258         rdar://problem/47093222
4259
4260         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
4261
4262 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4263
4264         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
4265         https://bugs.webkit.org/show_bug.cgi?id=193109
4266         <rdar://problem/44807048>
4267
4268         Reviewed by Ryosuke Niwa.
4269
4270         Introduce and respect a test option to enable the UndoManager API.
4271
4272         * WebKitTestRunner/TestController.cpp:
4273         (WTR::updateTestOptionsFromTestHeader):
4274         * WebKitTestRunner/TestOptions.h:
4275         (WTR::TestOptions::hasSameInitializationOptions const):
4276         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4277         (WTR::TestController::platformCreateWebView):
4278
4279 2019-01-11  Zalan Bujtas  <zalan@apple.com>
4280
4281         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
4282         https://bugs.webkit.org/show_bug.cgi?id=193346
4283
4284         Reviewed by Antti Koivisto.
4285
4286         * LayoutReloaded/misc/LFC-passing-tests.txt:
4287
4288 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
4289
4290         Unreviewed, fix typo that breaks dashboard link.
4291
4292         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4293         (WebKitBuildbot):
4294
4295 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
4296
4297         Update macOS queue configurations
4298         https://bugs.webkit.org/show_bug.cgi?id=193329
4299
4300         Reviewed by Alexey Proskuryakov.
4301
4302         * BuildSlaveSupport/build.webkit.org-config/config.json:
4303         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4304         (BubbleQueueServer):
4305         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4307         (WebKitBuildbot):
4308         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4309         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
4310         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4311
4312 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
4313
4314         MiniBrowser should be able to navigate to about:blank
4315         https://bugs.webkit.org/show_bug.cgi?id=193345
4316
4317         Reviewed by Simon Fraser.
4318
4319         * MiniBrowser/mac/BrowserWindowController.m:
4320         (-[BrowserWindowController addProtocolIfNecessary:]):
4321         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
4322
4323         * MiniBrowser/mac/WK1BrowserWindowController.m:
4324         (-[WK1BrowserWindowController fetch:]):
4325         * MiniBrowser/mac/WK2BrowserWindowController.m:
4326         (-[WK2BrowserWindowController fetch:]):