WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-21  Brian Burg  <bburg@apple.com>
2
3         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
4         https://bugs.webkit.org/show_bug.cgi?id=197125
5         <rdar://problem/50061468>
6
7         Reviewed by Darin Adler.
8
9         Sometimes I want to run wptserve independently of tests. Make it easier to script that
10         using this class rather than making our own ./wpt serve invocation.
11
12         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
13         (WebDriverW3CWebServer):
14         (WebDriverW3CWebServer.document_root): Expose this to clients.
15         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
16
17         (WebDriverW3CWebServer.__enter__):
18         (WebDriverW3CWebServer.__exit__):
19         Make it possible to use the web server with a 'with' statement.
20
21 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
22
23         [CMake][Win] Use target oriented design for WebKitLegacy
24         https://bugs.webkit.org/show_bug.cgi?id=197112
25
26         Reviewed by Konstantin Tokarev.
27
28         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
29
30         * DumpRenderTree/CMakeLists.txt:
31         * DumpRenderTree/PlatformWin.cmake:
32         * DumpRenderTree/win/EventSender.cpp:
33
34 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
35
36         Update text for old EWS submit button
37         https://bugs.webkit.org/show_bug.cgi?id=197140
38
39         Reviewed by Alexey Proskuryakov.
40
41         * QueueStatusServer/templates/statusbubble.html:
42
43 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
44
45         [ews-app] New EWS should poll bugzilla more frequently
46         https://bugs.webkit.org/show_bug.cgi?id=197138
47
48         Reviewed by Alexey Proskuryakov.
49
50         * BuildSlaveSupport/ews-app/ews/fetcher.py:
51         (FetchLoop.__init__):
52
53 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
54
55         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
56         https://bugs.webkit.org/show_bug.cgi?id=197139
57
58         Reviewed by Alexey Proskuryakov.
59
60         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
61         * QueueStatusServer/templates/statusbubble.html:
62
63 2019-04-20  Chris Dumez  <cdumez@apple.com>
64
65         Unreviewed, fix iOS build with recent SDKs.
66
67         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
68
69 2019-04-19  Keith Miller  <keith_miller@apple.com>
70
71         Add script to merge run_benchmark jsons
72         https://bugs.webkit.org/show_bug.cgi?id=197107
73
74         Reviewed by Michael Saboff.
75
76         The script basically recursively decends through all json objects until it gets
77         to an array or JSON primitive and concats or takes the first value, respectively.
78
79         This patch also adds +x bits to the compare-results script so it
80         can be run directly from the command line. I had to add a new line so that svn
81         will accept the change... yay svn!
82
83         * Scripts/compare-results:
84         * Scripts/merge-result-jsons: Added.
85         (readJSONFile):
86         (deepAppend):
87         (mergeJSONs):
88         (main):
89
90 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
91
92         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
93         https://bugs.webkit.org/show_bug.cgi?id=197079
94
95         Reviewed by Darin Adler.
96
97         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
98
99         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
100         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
101
102 2019-04-18  Commit Queue  <commit-queue@webkit.org>
103
104         Unreviewed, rolling out r244434.
105         https://bugs.webkit.org/show_bug.cgi?id=197089
106
107         caused 1 API test failure (Requested by zalan on #webkit).
108
109         Reverted changeset:
110
111         "Regression (r244291): Broken API Test
112         AutoLayoutRenderingProgressRelativeOrdering"
113         https://bugs.webkit.org/show_bug.cgi?id=196948
114         https://trac.webkit.org/changeset/244434
115
116 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
117
118         Add new compatibility mode API on WKNavigation
119         https://bugs.webkit.org/show_bug.cgi?id=197069
120         <rdar://problem/50025800>
121
122         Reviewed by Tim Horton.
123
124         Add a block property for -didCommitNavigation to TestNavigationDelegate.
125
126         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
127         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
128         (-[TestNavigationDelegate webView:didCommitNavigation:]):
129
130 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
131
132         [CMake] Make WebCore headers copies
133         https://bugs.webkit.org/show_bug.cgi?id=182512
134         <rdar://problem/37510435>
135
136         Reviewed by Alex Christensen.
137
138         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
139         ports.
140
141         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
142         of WebCore headers using "*.h" were modified to <WebCore/*.h>
143
144         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
145         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
146         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
147         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
148         * TestWebKitAPI/CMakeLists.txt:
149         * TestWebKitAPI/PlatformWin.cmake:
150         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
151         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
152         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
153
154 2019-04-18  Jer Noble  <jer.noble@apple.com>
155
156         Add support for parsing FairPlayStreaming PSSH boxes.
157         https://bugs.webkit.org/show_bug.cgi?id=197064
158
159         Reviewed by Eric Carlson.
160
161         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
162         (TestWebKitAPI::TEST):
163
164 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
165
166         InjectedBundle parameters often need initialization function called before unarchiving
167         https://bugs.webkit.org/show_bug.cgi?id=189709
168         <rdar://problem/44573653>
169
170         Reviewed by Ryosuke Niwa.
171
172         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
173         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
174
175 2019-04-18  Zalan Bujtas  <zalan@apple.com>
176
177         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
178         https://bugs.webkit.org/show_bug.cgi?id=196948
179         <rdar://problem/49927131>
180
181         Reviewed by Tim Horton.
182
183         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
184         (TEST): 
185         The expected order of incoming events is
186         1. didInvalidateIntrinsicContentSize
187         2. didFirstLayout
188         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
189         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
190         (and remember, all we care about is ordering).
191
192 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
193
194         Unreviewed, rolling out r244299.
195
196         Breaks internal tests.
197
198         Reverted changeset:
199
200         "InjectedBundle parameters often need initialization function
201         called before unarchiving"
202         https://bugs.webkit.org/show_bug.cgi?id=189709
203         https://trac.webkit.org/changeset/244299
204
205 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
206
207         [WTF] StringBuilder should set correct m_is8Bit flag when merging
208         https://bugs.webkit.org/show_bug.cgi?id=197053
209
210         Reviewed by Saam Barati.
211
212         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
213         (TestWebKitAPI::TEST):
214
215 2019-04-17  Tim Horton  <timothy_horton@apple.com>
216
217         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
218         https://bugs.webkit.org/show_bug.cgi?id=197028
219         <rdar://problem/49985290>
220
221         Reviewed by Wenson Hsieh.
222
223         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
224         (TEST):
225         Liberal application of waitForNextPresentationUpdate works around a race
226         where if the page rapidly changes its viewport arguments (or an API client
227         rapidly changes its viewport arguments), we'd get stuck thinking that the
228         user had intentionally zoomed the page, and stop resetting the initial scale.
229         This deserves a separate bug, but no need to keep the test failing while
230         we think about it.
231
232 2019-04-17  Tim Horton  <timothy_horton@apple.com>
233
234         REGRESSION (r241988): Switching tabs is slow
235         https://bugs.webkit.org/show_bug.cgi?id=197037
236         <rdar://problem/49951473>
237
238         Reviewed by Simon Fraser.
239
240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
241         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
242         (TEST):
243         * TestWebKitAPI/cocoa/TestWKWebView.h:
244         * TestWebKitAPI/cocoa/TestWKWebView.mm:
245         (-[TestWKWebView addToTestWindow]):
246         Add a test that hangs without this fix.
247
248 2019-04-17  Truitt Savell  <tsavell@apple.com>
249
250         Unreviewed, rolling out r244400.
251
252         Caused testing to exit early with assertionon Debug WK2
253
254         Reverted changeset:
255
256         "UI↔Web deadlock when printing with a JavaScript alert
257         visible"
258         https://bugs.webkit.org/show_bug.cgi?id=196839
259         https://trac.webkit.org/changeset/244400
260
261 2019-04-17  Brady Eidson  <beidson@apple.com>
262
263         Link clicks in PDFs shouldn't send referrer headers.
264         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
265
266         Reviewed by Tim Horton.
267
268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
269         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
270         (putPDFBytesCallback):
271         (emptyReleaseInfoCallback):
272         (createPDFWithLinkToURL):
273         (TEST):
274
275 2019-04-17  Tim Horton  <timothy_horton@apple.com>
276
277         UI↔Web deadlock when printing with a JavaScript alert visible
278         https://bugs.webkit.org/show_bug.cgi?id=196839
279         <rdar://problem/49157642>
280
281         Reviewed by Andy Estes.
282
283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
284         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
285         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
286         (TEST):
287
288 2019-04-17  Alex Christensen  <achristensen@webkit.org>
289
290         WKRetainPtr's adoption constructor should be private
291         https://bugs.webkit.org/show_bug.cgi?id=197019
292
293         Reviewed by Tim Horton.
294
295         * DumpRenderTree/mac/DumpRenderTree.mm:
296         (dumpFramesAsText):
297         * TestWebKitAPI/InjectedBundleController.cpp:
298         (TestWebKitAPI::InjectedBundleController::initialize):
299         * TestWebKitAPI/PlatformUtilities.cpp:
300         (TestWebKitAPI::Util::createContextWithInjectedBundle):
301         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
302         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
303         (TestWebKitAPI::Util::toWK):
304         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
305         (TestWebKitAPI::TEST):
306         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
307         (TestWebKitAPI::TEST):
308         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
309         (TestWebKitAPI::TEST):
310         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
311         (TestWebKitAPI::TEST):
312         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
313         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
314         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
315         (TestWebKitAPI::TEST):
316         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
317         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
318         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
319         (TestWebKitAPI::TEST):
320         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
321         (TestWebKitAPI::TEST):
322         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
323         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
324         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
325         (TestWebKitAPI::TEST):
326         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
327         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
328         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
329         (TestWebKitAPI::TEST):
330         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
331         (TestWebKitAPI::TEST):
332         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
333         (TestWebKitAPI::TEST):
334         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
335         (TestWebKitAPI::TEST):
336         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
337         (TestWebKitAPI::TEST):
338         * TestWebKitAPI/Tests/WebKit/Find.cpp:
339         (TestWebKitAPI::TEST):
340         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
341         (TestWebKitAPI::TEST):
342         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
343         (TestWebKitAPI::TEST):
344         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
345         (TestWebKitAPI::TEST):
346         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
347         (TestWebKitAPI::TEST):
348         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
349         (TestWebKitAPI::TEST):
350         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
351         (TestWebKitAPI::TEST):
352         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
353         (TestWebKitAPI::TEST):
354         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
355         (TestWebKitAPI::TEST):
356         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
357         (TestWebKitAPI::TEST):
358         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
359         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
360         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
361         (TestWebKitAPI::TEST):
362         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
363         (TestWebKitAPI::TEST):
364         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
365         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
366         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
367         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
368         (TestWebKitAPI::TEST):
369         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
370         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
371         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
372         (TestWebKitAPI::TEST):
373         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
374         (TestWebKitAPI::TEST):
375         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
376         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
377         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
378         (TestWebKitAPI::TEST):
379         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
380         (TestWebKitAPI::loadAlternateHTMLString):
381         (TestWebKitAPI::TEST):
382         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
383         (TestWebKitAPI::TEST):
384         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
385         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
386         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
387         (TestWebKitAPI::buildAndPerformTest):
388         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
389         (TestWebKitAPI::TEST):
390         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
391         (TestWebKitAPI::TEST):
392         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
393         (TestWebKitAPI::TEST):
394         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
395         (TestWebKitAPI::TEST):
396         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
397         (TestWebKitAPI::TEST):
398         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
399         (TestWebKitAPI::TEST):
400         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
401         (TestWebKitAPI::TEST):
402         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
403         (TestWebKitAPI::TEST):
404         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
405         (TestWebKitAPI::TEST):
406         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
407         (TestWebKitAPI::TEST):
408         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
409         (TestWebKitAPI::TEST):
410         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
411         (TestWebKitAPI::TEST):
412         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
413         (TestWebKitAPI::TEST):
414         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
415         (TestWebKitAPI::TEST):
416         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
417         (TestWebKitAPI::TEST):
418         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
419         (TestWebKitAPI::TEST):
420         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
421         (TestWebKitAPI::TEST):
422         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
423         (TestWebKitAPI::TEST):
424         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
425         (TestWebKitAPI::TEST):
426         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
427         (TestWebKitAPI::TEST):
428         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
429         (TestWebKitAPI::TEST):
430         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
431         (TestWebKitAPI::TEST):
432         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
433         (TestWebKitAPI::TEST):
434         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
435         (TestWebKitAPI::TEST):
436         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
437         (TestWebKitAPI::TEST):
438         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
439         (TestWebKitAPI::TEST):
440         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
441         (TestWebKitAPI::TEST):
442         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
443         (TestWebKitAPI::TEST):
444         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
445         (TestWebKitAPI::TEST):
446         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
447         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
448         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
449         (TestWebKitAPI::TEST):
450         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
451         (TestWebKitAPI::TEST):
452         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
453         (TestWebKitAPI::TEST):
454         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
455         (TestWebKitAPI::TEST):
456         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
457         (TestWebKitAPI::TEST):
458         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
459         (TestWebKitAPI::TEST):
460         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
461         (TestWebKitAPI::TEST):
462         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
463         (TestWebKitAPI::TEST):
464         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
465         (TestWebKitAPI::TEST):
466         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
467         (TestWebKitAPI::TEST):
468         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
469         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
470         (TEST):
471         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
472         (TEST):
473         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
474         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
475         (TEST):
476         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
477         (TestWebKitAPI::TEST):
478         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
479         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
480         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
481         (WTR::getMenuItemTitleCallback):
482         (WTR::createMouseMessageBody):
483         (WTR::EventSendingController::mouseDown):
484         (WTR::EventSendingController::mouseUp):
485         (WTR::EventSendingController::mouseMoveTo):
486         (WTR::EventSendingController::mouseForceClick):
487         (WTR::EventSendingController::startAndCancelMouseForceClick):
488         (WTR::EventSendingController::mouseForceDown):
489         (WTR::EventSendingController::mouseForceUp):
490         (WTR::EventSendingController::mouseForceChanged):
491         (WTR::EventSendingController::leapForward):
492         (WTR::EventSendingController::scheduleAsynchronousClick):
493         (WTR::createKeyDownMessageBody):
494         (WTR::EventSendingController::keyDown):
495         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
496         (WTR::EventSendingController::mouseScrollBy):
497         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
498         (WTR::EventSendingController::continuousMouseScrollBy):
499         (WTR::EventSendingController::addTouchPoint):
500         (WTR::EventSendingController::updateTouchPoint):
501         (WTR::EventSendingController::setTouchModifier):
502         (WTR::EventSendingController::setTouchPointRadius):
503         (WTR::EventSendingController::touchStart):
504         (WTR::EventSendingController::touchMove):
505         (WTR::EventSendingController::touchEnd):
506         (WTR::EventSendingController::touchCancel):
507         (WTR::EventSendingController::clearTouchPoints):
508         (WTR::EventSendingController::releaseTouchPoint):
509         (WTR::EventSendingController::cancelTouchPoint):
510         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
511         (WTR::InjectedBundle::didCreatePage):
512         (WTR::InjectedBundle::didReceiveMessage):
513         (WTR::InjectedBundle::didReceiveMessageToPage):
514         (WTR::InjectedBundle::booleanForKey):
515         (WTR::InjectedBundle::done):
516         (WTR::InjectedBundle::dumpToStdErr):
517         (WTR::InjectedBundle::outputText):
518         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
519         (WTR::InjectedBundle::postAddChromeInputField):
520         (WTR::InjectedBundle::postRemoveChromeInputField):
521         (WTR::InjectedBundle::postFocusWebView):
522         (WTR::InjectedBundle::postSetBackingScaleFactor):
523         (WTR::InjectedBundle::postSetWindowIsKey):
524         (WTR::InjectedBundle::postSetViewSize):
525         (WTR::InjectedBundle::postSimulateWebNotificationClick):
526         (WTR::InjectedBundle::postSetAddsVisitedLinks):
527         (WTR::InjectedBundle::setGeolocationPermission):
528         (WTR::InjectedBundle::setMockGeolocationPosition):
529         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
530         (WTR::InjectedBundle::isGeolocationProviderActive const):
531         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
532         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
533         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
534         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
535         (WTR::InjectedBundle::setCustomPolicyDelegate):
536         (WTR::InjectedBundle::setHidden):
537         (WTR::InjectedBundle::setCacheModel):
538         (WTR::InjectedBundle::shouldProcessWorkQueue const):
539         (WTR::InjectedBundle::processWorkQueue):
540         (WTR::InjectedBundle::queueBackNavigation):
541         (WTR::InjectedBundle::queueForwardNavigation):
542         (WTR::InjectedBundle::queueLoad):
543         (WTR::InjectedBundle::queueLoadHTMLString):
544         (WTR::InjectedBundle::queueReload):
545         (WTR::InjectedBundle::queueLoadingScript):
546         (WTR::InjectedBundle::queueNonLoadingScript):
547         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
548         (WTR::frameToStr):
549         (WTR::InjectedBundlePage::InjectedBundlePage):
550         (WTR::dumpFrameDescriptionSuitableForTestResult):
551         (WTR::dumpFrameScrollPosition):
552         (WTR::dumpDescendantFrameScrollPositions):
553         (WTR::dumpFrameText):
554         (WTR::dumpDescendantFramesText):
555         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
556         (WTR::TestRunner::shouldDumpPixels const):
557         (WTR::TestRunner::setDumpPixels):
558         (WTR::TestRunner::whatToDump const):
559         (WTR::TestRunner::setWhatToDump):
560         (WTR::TestRunner::setWaitUntilDone):
561         (WTR::TestRunner::shouldWaitUntilDone const):
562         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
563         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
564         (WTR::TestRunner::clearAllDatabases):
565         (WTR::TestRunner::setIDBPerOriginQuota):
566         (WTR::TestRunner::originsWithApplicationCache):
567         (WTR::TestRunner::setCanOpenWindows):
568         (WTR::TestRunner::setXSSAuditorEnabled):
569         (WTR::TestRunner::setMediaDevicesEnabled):
570         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
571         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
572         (WTR::TestRunner::setCustomUserAgent):
573         (WTR::TestRunner::setWebAPIStatisticsEnabled):
574         (WTR::TestRunner::setModernMediaControlsEnabled):
575         (WTR::TestRunner::setWebGL2Enabled):
576         (WTR::TestRunner::setWritableStreamAPIEnabled):
577         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
578         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
579         (WTR::TestRunner::setAllowsAnySSLCertificate):
580         (WTR::TestRunner::setPluginsEnabled):
581         (WTR::TestRunner::setValueForUser):
582         (WTR::TestRunner::setAudioResult):
583         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
584         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
585         (WTR::TestRunner::setAlwaysAcceptCookies):
586         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
587         (WTR::TestRunner::isDoingMediaCapture const):
588         (WTR::TestRunner::queueLoad):
589         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
590         (WTR::TestRunner::setHandlesAuthenticationChallenges):
591         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
592         (WTR::TestRunner::setShouldLogDownloadCallbacks):
593         (WTR::TestRunner::setAuthenticationUsername):
594         (WTR::TestRunner::setAuthenticationPassword):
595         (WTR::TestRunner::secureEventInputIsEnabled const):
596         (WTR::TestRunner::setBlockAllPlugins):
597         (WTR::TestRunner::setPluginSupportedMode):
598         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
599         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
600         (WTR::TestRunner::setNavigationGesturesEnabled):
601         (WTR::TestRunner::setIgnoresViewportScaleLimits):
602         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
603         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
604         (WTR::TestRunner::terminateNetworkProcess):
605         (WTR::TestRunner::terminateServiceWorkerProcess):
606         (WTR::TestRunner::runUIScript):
607         (WTR::TestRunner::setStatisticsDebugMode):
608         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
609         (WTR::TestRunner::setStatisticsLastSeen):
610         (WTR::TestRunner::setStatisticsPrevalentResource):
611         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
612         (WTR::TestRunner::dumpResourceLoadStatistics):
613         (WTR::TestRunner::isStatisticsPrevalentResource):
614         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
615         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
616         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
617         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
618         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
619         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
620         (WTR::TestRunner::setStatisticsGrandfathered):
621         (WTR::TestRunner::isStatisticsGrandfathered):
622         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
623         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
624         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
625         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
626         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
627         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
628         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
629         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
630         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
631         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
632         (WTR::TestRunner::statisticsUpdateCookieBlocking):
633         (WTR::TestRunner::statisticsSubmitTelemetry):
634         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
635         (WTR::TestRunner::setStatisticsIsRunningTest):
636         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
637         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
638         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
639         (WTR::TestRunner::setStatisticsGrandfatheringTime):
640         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
641         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
642         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
643         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
644         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
645         (WTR::TestRunner::statisticsDeleteCookiesForHost):
646         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
647         (WTR::TestRunner::statisticsResetToConsistentState):
648         (WTR::TestRunner::setStorageAccessAPIEnabled):
649         (WTR::TestRunner::getAllStorageAccessEntries):
650         (WTR::TestRunner::addMockMediaDevice):
651         (WTR::TestRunner::clearMockMediaDevices):
652         (WTR::TestRunner::removeMockMediaDevice):
653         (WTR::TestRunner::resetMockMediaDevices):
654         (WTR::TestRunner::connectMockGamepad):
655         (WTR::TestRunner::disconnectMockGamepad):
656         (WTR::TestRunner::setMockGamepadDetails):
657         (WTR::TestRunner::setMockGamepadAxisValue):
658         (WTR::TestRunner::setMockGamepadButtonValue):
659         (WTR::TestRunner::removeAllSessionCredentials):
660         (WTR::TestRunner::clearDOMCache):
661         (WTR::TestRunner::clearDOMCaches):
662         (WTR::TestRunner::hasDOMCache):
663         (WTR::TestRunner::domCacheSize):
664         (WTR::TestRunner::setAllowStorageQuotaIncrease):
665         (WTR::TestRunner::getApplicationManifestThen):
666         (WTR::TestRunner::injectUserScript):
667         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
668         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
669         (WTR::TestRunner::addTestKeyToKeychain):
670         (WTR::TestRunner::cleanUpKeychain):
671         (WTR::TestRunner::keyExistsInKeychain):
672         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
673         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
674         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
675         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
676         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
677         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
678         * WebKitTestRunner/TestController.cpp:
679         (WTR::TestController::initialize):
680         (WTR::parseStringTestHeaderValueAsRelativePath):
681         (WTR::updateTestOptionsFromTestHeader):
682         (WTR::TestController::runTest):
683         (WTR::TestController::didReceiveLiveDocumentsList):
684         (WTR::TestController::didReceiveMessageFromInjectedBundle):
685         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
686         (WTR::TestController::didFinishNavigation):
687         (WTR::TestController::didReceiveAuthenticationChallenge):
688         * WebKitTestRunner/TestInvocation.cpp:
689         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
690         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
691         (WTR::TestInvocation::uiScriptDidComplete):
692         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
693         * WebKitTestRunner/WebNotificationProvider.cpp:
694         (WTR::WebNotificationProvider::closeWebNotification):
695         * WebKitTestRunner/WorkQueueManager.cpp:
696         (WTR::ScriptItem::ScriptItem):
697         (WTR::WorkQueueManager::queueLoad):
698         (WTR::WorkQueueManager::queueLoadHTMLString):
699
700 2019-04-17  Alex Christensen  <achristensen@webkit.org>
701
702         Add a comment to make my test from r244139 less mysterious.
703         https://bugs.webkit.org/show_bug.cgi?id=196744
704
705         As suggested by Darin Adler.
706
707         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
708         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
709
710 2019-04-17  Chris Dumez  <cdumez@apple.com>
711
712         Remember device orientation permission for the duration of the browsing session
713         https://bugs.webkit.org/show_bug.cgi?id=196992
714         <rdar://problem/49946067>
715
716         Reviewed by Alex Christensen.
717
718         Add API test coverage.
719
720         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
721         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
722         (TEST):
723
724 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
725
726         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
727         https://bugs.webkit.org/show_bug.cgi?id=196675
728
729         Reviewed by Lucas Forschler.
730
731         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
732         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
733
734 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
735
736         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
737         https://bugs.webkit.org/show_bug.cgi?id=196919
738         <rdar://problem/41630459>
739
740         Reviewed by Tim Horton.
741
742         Add iOS support for several new testing hooks. See below for more detail.
743
744         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
745         (WTR::UIScriptController::isDismissingMenu const):
746
747         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
748         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
749         by UIKit when dismissing the callout bar (i.e. UIMenuController).
750
751         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
752         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
753         (WTR::UIScriptController::isDismissingMenu const):
754         * TestRunnerShared/UIScriptContext/UIScriptController.h:
755         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
756         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
757         (WTR::InjectedBundle::didReceiveMessageToPage):
758         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
759         (WTR::TestRunner::setAllowedMenuActions):
760
761         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
762         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
763         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
764         against the name of the custom action.
765
766         (WTR::TestRunner::installCustomMenuAction):
767
768         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
769         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
770         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
771         triggered.
772
773         (WTR::TestRunner::performCustomMenuAction):
774
775         Invoked when the custom menu action is triggered.
776
777         * WebKitTestRunner/InjectedBundle/TestRunner.h:
778         * WebKitTestRunner/TestController.cpp:
779         (WTR::TestController::installCustomMenuAction):
780         (WTR::TestController::setAllowedMenuActions):
781         * WebKitTestRunner/TestController.h:
782         * WebKitTestRunner/TestInvocation.cpp:
783         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
784         (WTR::TestInvocation::performCustomMenuAction):
785
786         Add plumbing to call back into the injected bundle when performing the custom action.
787
788         * WebKitTestRunner/TestInvocation.h:
789         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
790         (WTR::TestController::installCustomMenuAction):
791         (WTR::TestController::setAllowedMenuActions):
792         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
793         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
794         (-[TestRunnerWKWebView initWithFrame:configuration:]):
795         (-[TestRunnerWKWebView becomeFirstResponder]):
796         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
797
798         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
799         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
800         in the Mail app on iOS.
801
802         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
803         (-[TestRunnerWKWebView setAllowedMenuActions:]):
804         (-[TestRunnerWKWebView resetCustomMenuAction]):
805         (-[TestRunnerWKWebView performCustomAction:]):
806         (-[TestRunnerWKWebView canPerformAction:withSender:]):
807         (-[TestRunnerWKWebView _willHideMenu]):
808         (-[TestRunnerWKWebView _didHideMenu]):
809         * WebKitTestRunner/ios/TestControllerIOS.mm:
810         (WTR::TestController::platformResetStateToConsistentValues):
811
812         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
813         if specified.
814
815         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
816         (WTR::UIScriptController::isDismissingMenu const):
817
818 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
819
820         Allow sharing from imageSheet on an image document
821         https://bugs.webkit.org/show_bug.cgi?id=196891
822         <rdar://problem/25377386>
823
824         Reviewed by Tim Horton.
825
826         Test to make sure that the correct imageURL is extracted from an image element.
827
828         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
829         (TestWebKitAPI::TEST):
830
831 2019-04-16  Alex Christensen  <achristensen@webkit.org>
832
833         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
834         https://bugs.webkit.org/show_bug.cgi?id=196995
835
836         Reviewed by Brady Eidson.
837
838         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
839         (TEST):
840
841 2019-04-16  Chris Dumez  <cdumez@apple.com>
842
843         URL set by document.open() is not communicated to the UIProcess
844         https://bugs.webkit.org/show_bug.cgi?id=196941
845         <rdar://problem/49237544>
846
847         Reviewed by Geoff Garen.
848
849         Add API test coverage.
850
851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
852         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
853         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
854         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
855         (TEST):
856
857 2019-04-16  Commit Queue  <commit-queue@webkit.org>
858
859         Unreviewed, rolling out r244321.
860         https://bugs.webkit.org/show_bug.cgi?id=196968
861
862         Causing all WK2 Debug builds to exit early after Assertion
863         failures. (Requested by ShawnRoberts on #webkit).
864
865         Reverted changeset:
866
867         "URL set by document.open() is not communicated to the
868         UIProcess"
869         https://bugs.webkit.org/show_bug.cgi?id=196941
870         https://trac.webkit.org/changeset/244321
871
872 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
873
874         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
875         https://bugs.webkit.org/show_bug.cgi?id=196948
876
877         Reviewed by Zalan Bujtas.
878
879         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
880         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
881
882 2019-04-15  Chris Dumez  <cdumez@apple.com>
883
884         URL set by document.open() is not communicated to the UIProcess
885         https://bugs.webkit.org/show_bug.cgi?id=196941
886         <rdar://problem/49237544>
887
888         Reviewed by Geoffrey Garen.
889
890         Add API test coverage.
891
892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
893         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
894         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
895         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
896         (TEST):
897
898 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
899
900         Using Tools/Scripts/clean-webkit should not install requests
901         https://bugs.webkit.org/show_bug.cgi?id=196940
902
903         Reviewed by Lucas Forschler.
904
905         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
906         existing, depending on the path autoinstalled is run through.
907         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
908         needed.
909         (Port.configuration_for_upload):
910         (Port.commits_for_upload):
911
912 2019-04-15  Alex Christensen  <achristensen@webkit.org>
913
914         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
915         https://bugs.webkit.org/show_bug.cgi?id=196773
916
917         Reviewed by Jer Noble.
918
919         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
920         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
921         (TEST):
922
923 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
924
925         ews-build should clearly indicate flaky test failures
926         https://bugs.webkit.org/show_bug.cgi?id=196947
927
928         Reviewed by Lucas Forschler.
929
930         * BuildSlaveSupport/ews-build/steps.py:
931         (AnalyzeAPITestsResults.analyzeResults):
932
933 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
934
935         InjectedBundle parameters often need initialization function called before unarchiving
936         https://bugs.webkit.org/show_bug.cgi?id=189709
937         <rdar://problem/44573653>
938
939         Reviewed by Ryosuke Niwa.
940
941         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
942         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
943
944 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
945
946         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
947         https://bugs.webkit.org/show_bug.cgi?id=196681
948
949         Reviewed by Darin Adler.
950
951         Added tests.
952
953         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
954         (WTF_HashSet.RemoveIf):
955         (WTF_HashSet.RemoveIfShrinkToBestSize):
956
957 2019-04-15  John Wilander  <wilander@apple.com>
958
959         Send delayed Ad Click Attribution conversion requests to the click source
960         https://bugs.webkit.org/show_bug.cgi?id=196838
961         <rdar://problem/47650157>
962
963         Reviewed by Chris Dumez and Youenn Fablet.
964
965         This patch adds test infrastructure to override the default behavior in
966         WebKit::NetworkAdClickAttribution.
967
968         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
969         (TestWebKitAPI::TEST):
970         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
971         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
972         (WTR::TestRunner::dumpAdClickAttribution):
973         (WTR::TestRunner::clearAdClickAttribution):
974         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
975         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
976         * WebKitTestRunner/InjectedBundle/TestRunner.h:
977         * WebKitTestRunner/TestController.cpp:
978         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
979         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
980         * WebKitTestRunner/TestController.h:
981         * WebKitTestRunner/TestInvocation.cpp:
982         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
983
984 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
985
986         [ews-app] status-bubble should display position in queue
987         https://bugs.webkit.org/show_bug.cgi?id=196607
988
989         Reviewed by Lucas Forschler.
990
991         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
992         (StatusBubble._build_bubble):
993         (StatusBubble._queue_position): Method to calculate patch's position in queue.
994
995 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
996
997         [ews-build] Do not run clean build by default on EWS builders
998         https://bugs.webkit.org/show_bug.cgi?id=196897
999
1000         Reviewed by Lucas Forschler.
1001
1002         * BuildSlaveSupport/ews-build/steps.py:
1003         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1004         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1005         untracked directories like WebKitBuild).
1006         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1007         untracked files/directories (like WebKitBuild).
1008
1009 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1010
1011         TestRunner::notifyDone() should be safely reentrant
1012         https://bugs.webkit.org/show_bug.cgi?id=196898
1013
1014         Reviewed by Darin Adler.
1015
1016         It is currently possible that TestRunner::notifyDone() will call itself, since
1017         notifyDone() will force a repaint, which can start executing JavaScript, which
1018         may call notifyDone() again. This can lead to test failures and flakiness.
1019         Fix this by setting the m_waitToDump flag before calling the dump() method.
1020
1021         * DumpRenderTree/mac/TestRunnerMac.mm:
1022         (TestRunner::notifyDone):
1023         (TestRunner::forceImmediateCompletion):
1024         * DumpRenderTree/win/TestRunnerWin.cpp:
1025         (TestRunner::notifyDone):
1026         (TestRunner::forceImmediateCompletion):
1027
1028 2019-04-15  Philippe Normand  <pnormand@igalia.com>
1029
1030         [GTK][WPE] Add enable-media websetting
1031         https://bugs.webkit.org/show_bug.cgi?id=196863
1032
1033         Reviewed by Michael Catanzaro.
1034
1035         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1036         (testWebKitSettings): Add test for the enable-media web-setting.
1037
1038 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1039
1040         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1041         https://bugs.webkit.org/show_bug.cgi?id=196905
1042         <rdar://problem/49886096>
1043
1044         Reviewed by Tim Horton.
1045
1046         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1047         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1048         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1049         delay timer, we end up with this sequence of events in the problematic (failure) case:
1050
1051         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1052             ...IPC from UI to web process...
1053         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1054             ...IPC from web to UI process...
1055         (c) [UI]    Invoke completion handler for script #1
1056         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1057             ...IPC from UI to web process...
1058         (e) [Web]   Evaluate script #2 in the web process
1059         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1060
1061         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1062         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1063         #2 is run in step (e).
1064
1065         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1066         the UI process by waiting on a script message posted by the web process, after attachment updates are
1067         dispatched.
1068
1069         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1070         (TestWebKitAPI::TEST):
1071
1072 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1073
1074         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1075         https://bugs.webkit.org/show_bug.cgi?id=196909
1076
1077         Reviewed by Wenson Hsieh.
1078
1079         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1080         (TestWebKitAPI::TEST):
1081
1082 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1083
1084         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1085         https://bugs.webkit.org/show_bug.cgi?id=196880
1086
1087         Reviewed by Yusuke Suzuki.
1088
1089         Add a new function for bytecode cache tests that does not forceDiskCache
1090         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1091         test added in this patch, since the code is invalid and therefore won't be
1092         cached. It should also be useful for tests that evaluate dynamically
1093         generated code.
1094
1095         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1096         * Scripts/run-jsc-stress-tests:
1097
1098 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1099
1100         Update AudioSession route sharing policy
1101         https://bugs.webkit.org/show_bug.cgi?id=196776
1102         <rdar://problem/46501611>
1103
1104         Reviewed by Jer Noble.
1105
1106         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1107         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1108         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1109         (TestWebKitAPI::TEST):
1110
1111 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1112
1113         [iOS] Software keyboard is shown too frequently on some websites
1114         https://bugs.webkit.org/show_bug.cgi?id=195856
1115         <rdar://problem/49191395>
1116
1117         Reviewed by Darin Adler.
1118
1119         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1120
1121         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1122         (WTR::UIScriptController::setHardwareKeyboardAttached):
1123         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1124         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1125         (WTR::UIScriptController::setHardwareKeyboardAttached):
1126         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1127         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1128
1129         Additionally link against GraphicsServices in WebKitTestRunner.
1130
1131         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1132         (WTR::TestController::platformResetStateToConsistentValues):
1133         (WTR::UIScriptController::setHardwareKeyboardAttached):
1134
1135 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1136
1137         [GTK][WPE] Fix pacman install-dependencies packages
1138         https://bugs.webkit.org/show_bug.cgi?id=196817
1139
1140         Reviewed by Žan Doberšek.
1141         
1142         python3-setuptools is called python-setuptools
1143         ruby-highline is only available on AUR
1144         libv4l-devel is incorporated in v4l-utils
1145
1146         * gtk/install-dependencies:
1147         * wpe/install-dependencies:
1148
1149 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1150
1151         [GTK] REGRESSION(r243860): Many tests failing
1152         https://bugs.webkit.org/show_bug.cgi?id=196791
1153
1154         Reviewed by Joanmarie Diggs.
1155
1156         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1157         multiple documents and check that accessibility hierarchy is updated after a navigation.
1158
1159         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1160         (loadChangedCallback):
1161         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1162         (AccessibilityTest::AccessibilityTest):
1163         (AccessibilityTest::~AccessibilityTest):
1164         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1165         (AccessibilityTest::findTestServerApplication):
1166         (AccessibilityTest::findDocumentWeb):
1167         (AccessibilityTest::findRootObject):
1168         (AccessibilityTest::waitUntilChildrenRemoved):
1169         (AccessibilityTest::ensureProxy):
1170         (testAtspiBasicHierarchy):
1171         (beforeAll):
1172         (afterAll):
1173
1174 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1175
1176         [ews-build] Handle bug titles with unicode characters
1177         https://bugs.webkit.org/show_bug.cgi?id=196802
1178
1179         Reviewed by Dewei Zhu.
1180
1181         * BuildSlaveSupport/ews-build/steps.py:
1182         (ValidatePatch._is_bug_closed):
1183
1184 2019-04-11  Michael Saboff  <msaboff@apple.com>
1185
1186         Improve the Inline Cache Stats code
1187         https://bugs.webkit.org/show_bug.cgi?id=196836
1188
1189         Reviewed by Saam Barati.
1190
1191         Added a new script to consolidate and arrange the output of --useICStats option.
1192
1193         This script merges the output from every group into one large table and sorts it from most common to
1194         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1195         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1196         Put together, this is useful to see what property accesses are not getting cached.
1197
1198         * Scripts/ic-stats.py: Added.
1199         (ICStats):
1200         (ICStats.__init__):
1201         (ICStats.parse):
1202         (ICStats.dumpStats):
1203         (usage):
1204
1205 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1206
1207         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1208         https://bugs.webkit.org/show_bug.cgi?id=196809
1209         <rdar://49800762>
1210
1211         Reviewed by Brady Eidson.
1212
1213         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1214         (TEST):
1215
1216 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1217
1218         requestAnimationFrame should execute before the next frame
1219         https://bugs.webkit.org/show_bug.cgi?id=177484
1220
1221         Reviewed by Simon Fraser.
1222
1223         Add trace points for the page RenderingUpdate.
1224
1225         * Tracing/SystemTracePoints.plist:
1226
1227 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1228
1229         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1230         https://bugs.webkit.org/show_bug.cgi?id=196760
1231
1232         Reviewed by Don Olmstead.
1233
1234         vswhere.exe has been bundled since Visual Studio 2017 version
1235         15.2. We shouldn't download vswhere.exe.
1236
1237         * Scripts/build-jsc: Do not call update-vswhere.py.
1238         * Scripts/build-webkit: Ditto.
1239         * Scripts/update-vswhere.py: Removed.
1240         * Scripts/webkitdirs.pm:
1241         (requireModulesForVSWhere): Deleted.
1242         (pickCurrentVisualStudioInstallation): Deleted.
1243         (visualStudioInstallDirVSWhere): Return the latest installed VS
1244         installation path by using the bundled vswhere.exe.
1245         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1246         (visualStudioInstallDirFallback): Removed.
1247
1248 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1249
1250         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1251         https://bugs.webkit.org/show_bug.cgi?id=196780
1252
1253         Reviewed by Alexey Proskuryakov.
1254
1255         * BuildSlaveSupport/ews-build/steps.py:
1256         * BuildSlaveSupport/ews-build/steps_unittest.py:
1257
1258 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1259
1260         Add SPI WKNavigationResponse._downloadAttribute
1261         https://bugs.webkit.org/show_bug.cgi?id=196755
1262         <rdar://49587365>
1263
1264         Reviewed by Brady Eidson.
1265
1266         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1267         (-[NavigationResponseTestDelegate navigationResponse]):
1268         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1269         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1270         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1271         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1272         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1273         (readRequest):
1274         (writeResponse):
1275         (TEST):
1276
1277 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1278
1279         Add modern API for overriding the page's specified viewport configuration
1280         https://bugs.webkit.org/show_bug.cgi?id=167734
1281         <rdar://problem/30331795>
1282
1283         Reviewed by Simon Fraser.
1284
1285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1286         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1287
1288 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1289
1290         Add support for incremental bytecode cache updates
1291         https://bugs.webkit.org/show_bug.cgi?id=195000
1292
1293         Reviewed by Filip Pizlo.
1294
1295         Exit when the initial run to generate bytecode fails.
1296
1297         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1298
1299 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1300
1301         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1302         https://bugs.webkit.org/show_bug.cgi?id=196744
1303         <rdar://49415309>
1304
1305         Reviewed by Chris Dumez.
1306
1307         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1308         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1309
1310 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1311
1312         Add a way to opt into modern compatibility mode in layout tests
1313         https://bugs.webkit.org/show_bug.cgi?id=196770
1314         <rdar://problem/49777550>
1315
1316         Reviewed by Antoine Quint.
1317
1318         Add a new test option to enable modern compatibility mode in layout tests.
1319
1320         * WebKitTestRunner/TestController.cpp:
1321         (WTR::updateTestOptionsFromTestHeader):
1322         * WebKitTestRunner/TestController.h:
1323         * WebKitTestRunner/TestOptions.h:
1324         (WTR::TestOptions::hasSameInitializationOptions const):
1325         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1326         (WTR::TestController::platformCreateWebView):
1327         (WTR::TestController::enableModernCompatibilityMode):
1328
1329 2019-04-10  Andy Estes  <aestes@apple.com>
1330
1331         Try to fix the 32-bit watchOS build.
1332
1333         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1334         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1335
1336 2019-04-10  Antoine Quint  <graouts@apple.com>
1337
1338         Enable Pointer Events on watchOS
1339         https://bugs.webkit.org/show_bug.cgi?id=196771
1340         <rdar://problem/49040909>
1341
1342         Reviewed by Dean Jackson.
1343
1344         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1345
1346 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1347
1348         Unreviewed. Fix WPE accessibility tests after r244059.
1349
1350         We are failing to load the injected bundle due to undefined symbol
1351         AccessibilityUIElement::replaceTextInRange().
1352
1353         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1354         (WTR::AccessibilityUIElement::replaceTextInRange):
1355
1356 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1357
1358         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1359         https://bugs.webkit.org/show_bug.cgi?id=196727
1360
1361         Reviewed by Fujii Hironori.
1362
1363         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1364         (WebKitBrowserWindow::create):
1365
1366 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1367
1368         [ews-build] Add unit tests for PrintConfiguration
1369         https://bugs.webkit.org/show_bug.cgi?id=196752
1370
1371         Reviewed by Dewei Zhu.
1372
1373         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1374
1375 2019-04-09  Keith Rollin  <krollin@apple.com>
1376
1377         Unreviewed build maintenance -- update .xcfilelists.
1378
1379         * DumpRenderTree/DerivedSources-input.xcfilelist:
1380         * DumpRenderTree/DerivedSources-output.xcfilelist:
1381
1382 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1383
1384         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1385         https://bugs.webkit.org/show_bug.cgi?id=196743
1386         <rdar://problem/43897551>
1387
1388         Reviewed by Tim Horton.
1389
1390         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1391         (TEST):
1392
1393 2019-04-09  Youenn Fablet  <youenn@apple.com>
1394
1395         Close service worker database on network process suspension
1396         https://bugs.webkit.org/show_bug.cgi?id=196623
1397         <rdar://problem/48930869>
1398
1399         Reviewed by Alex Christensen.
1400
1401         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1402
1403 2019-04-09  Daniel Bates  <dabates@apple.com>
1404
1405         [iPad] Should open popover when the spacebar is pressed
1406         https://bugs.webkit.org/show_bug.cgi?id=196360
1407         <rdar://problem/49389129>
1408
1409         Reviewed by Brent Fulgham.
1410
1411         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1412
1413         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1414         (WTR::UIScriptController::isShowingPopover const): Added.
1415         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1416         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1417         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1418         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1419         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1420         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1421         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1422         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1423         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1424         (WTR::UIScriptController::isShowingPopover const): Added.
1425         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1426         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1427         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1428         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1429         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1430         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1431         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1432         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1433         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1434         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1435         (WTR::UIScriptController::isShowingPopover const): Added.
1436         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1437         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1438
1439 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1440
1441         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1442         https://bugs.webkit.org/show_bug.cgi?id=196665
1443         <rdar://45115669>
1444
1445         Reviewed by Geoff Garen.
1446
1447         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1448         (goBack):
1449         (+[SimpleLookupContext sharedLookupContext]):
1450         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1451         (TEST):
1452         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1453         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1454
1455 2019-04-09  John Wilander  <wilander@apple.com>
1456
1457         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1458         https://bugs.webkit.org/show_bug.cgi?id=196558
1459         <rdar://problem/47650245>
1460
1461         Reviewed by Youenn Fablet.
1462
1463         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1464         (TestWebKitAPI::TEST):
1465             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1466
1467 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1468
1469         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1470         https://bugs.webkit.org/show_bug.cgi?id=196720
1471
1472         Reviewed by Konstantin Tokarev.
1473
1474         * TestWebKitAPI/PlatformMac.cmake:
1475
1476 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1477
1478         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1479         https://bugs.webkit.org/show_bug.cgi?id=196694
1480         <rdar://problem/48388734>
1481
1482         Rubber-stamped by Aakash Jain.
1483
1484         * Scripts/webkitpy/port/image_diff.py:
1485         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1486         * Scripts/webkitpy/port/server_process.py:
1487         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1488         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1489         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1490         * Scripts/webkitpy/port/server_process_mock.py:
1491         (MockServerProcess.has_available_stdout):
1492         * Scripts/webkitpy/port/server_process_unittest.py:
1493         (TestServerProcess.serial_test_basic):
1494
1495 2019-04-09  Jer Noble  <jer.noble@apple.com>
1496
1497         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1498         https://bugs.webkit.org/show_bug.cgi?id=196097
1499
1500         Reviewed by Eric Carlson.
1501
1502         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1503
1504         * DumpRenderTree/mac/DumpRenderTree.mm:
1505         (resetWebPreferencesToConsistentValues):
1506         * WebKitTestRunner/TestController.cpp:
1507         (WTR::TestController::resetPreferencesToConsistentValues):
1508
1509 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1510
1511         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1512         https://bugs.webkit.org/show_bug.cgi?id=196690
1513
1514         Reviewed by Michael Catanzaro.
1515
1516         * QueueStatusServer/config/queues.py:
1517         * Scripts/webkitpy/common/config/ews.json:
1518         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1519         (test_ews_name):
1520
1521 2019-04-09  Chris Dumez  <cdumez@apple.com>
1522
1523         Loads using loadHTMLString() cause flashing when process-swapping
1524         https://bugs.webkit.org/show_bug.cgi?id=196714
1525         <rdar://problem/49637354>
1526
1527         Reviewed by Antti Koivisto.
1528
1529         Add API test coverage.
1530
1531         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1532
1533 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1534
1535         Unreviewed. Fix ATK accessibility tests after r244059.
1536
1537         We are failing to load the injected bundle due to undefined symbol
1538         AccessibilityUIElement::replaceTextInRange().
1539
1540         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1541         (WTR::AccessibilityUIElement::replaceTextInRange):
1542
1543 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1544
1545         AX: Support API: accessibilityReplaceRange:withText
1546         https://bugs.webkit.org/show_bug.cgi?id=196636
1547
1548         Unreviewed build fix for Windows port.
1549
1550         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1551         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1552
1553 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1554
1555         [CMake][WinCairo] Separate copied headers into different directories
1556         https://bugs.webkit.org/show_bug.cgi?id=196655
1557
1558         Reviewed by Michael Catanzaro.
1559
1560         * DumpRenderTree/CMakeLists.txt:
1561         * MiniBrowser/win/CMakeLists.txt:
1562         * TestWebKitAPI/CMakeLists.txt:
1563         * TestWebKitAPI/PlatformWin.cmake:
1564
1565 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1566
1567         Log stack-trace for run-webkit-tests when interrupted
1568         https://bugs.webkit.org/show_bug.cgi?id=176393
1569         <rdar://problem/34262310>
1570
1571         Reviewed by Lucas Forschler.
1572
1573         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1574         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1575         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1576         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1577         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1578         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1579         (main): Set handlers to log stack trace on interruption.
1580
1581 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1582
1583         AX: Support API: accessibilityReplaceRange:withText
1584         https://bugs.webkit.org/show_bug.cgi?id=196636
1585
1586         Unreviewed build fix for Windows port.
1587
1588         * DumpRenderTree/AccessibilityUIElement.cpp:
1589         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1590
1591 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1592
1593         [ews-build] Scripts using Buildbot API have CORS error
1594         https://bugs.webkit.org/show_bug.cgi?id=196709
1595
1596         Reviewed by Alexey Proskuryakov.
1597
1598         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1599
1600 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1601
1602         AX: Support API: accessibilityReplaceRange:withText
1603         https://bugs.webkit.org/show_bug.cgi?id=196636
1604
1605         Reviewed by Daniel Bates.
1606
1607         * DumpRenderTree/AccessibilityUIElement.cpp:
1608         (replaceTextInRangeCallback):
1609         (AccessibilityUIElement::replaceTextInRange):
1610         (AccessibilityUIElement::getJSClass):
1611         * DumpRenderTree/AccessibilityUIElement.h:
1612         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1613         (AccessibilityUIElement::replaceTextInRange):
1614         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1615         (AccessibilityUIElement::replaceTextInRange):
1616         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1617         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1618         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1619         (WTR::AccessibilityUIElement::replaceTextInRange):
1620         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1621         (WTR::AccessibilityUIElement::replaceTextInRange):
1622
1623 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1624
1625         [iOS] Do not allow starting selection drags when selection views are not visible
1626         https://bugs.webkit.org/show_bug.cgi?id=196686
1627         <rdar://problem/49399192>
1628
1629         Reviewed by Tim Horton.
1630
1631         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1632         also add some new API tests to cover scenarios where the web view is not first responder.
1633
1634         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1635         (TestWebKitAPI::TEST):
1636         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1637
1638         Add a switch to optionally make the web view first responder when starting the simulated drag.
1639
1640         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1641         (-[DragAndDropSimulator initWithWebView:]):
1642         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1643
1644 2019-04-08  Justin Fan  <justin_fan@apple.com>
1645
1646         [Web GPU] Fix Web GPU experimental feature on iOS
1647         https://bugs.webkit.org/show_bug.cgi?id=196632
1648
1649         Reviewed by Myles C. Maxfield.
1650
1651         Properly make Web GPU available on iOS 11+.
1652
1653         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1654
1655 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1656
1657         [ews-build] Do not upload archive when Compile Fails
1658         https://bugs.webkit.org/show_bug.cgi?id=196674
1659
1660         Reviewed by Alexey Proskuryakov.
1661
1662         * BuildSlaveSupport/ews-build/factories.py:
1663         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1664         * BuildSlaveSupport/ews-build/steps.py:
1665         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1666         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1667         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1668
1669 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1670
1671         Enable DFG on MIPS
1672         https://bugs.webkit.org/show_bug.cgi?id=196689
1673
1674         Reviewed by Žan Doberšek.
1675
1676         Since the bytecode change, we enabled the baseline JIT on mips in
1677         r240432, but DFG is still missing. With this change, all tests are
1678         passing on a ci20 board.
1679
1680         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1681
1682 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1683
1684         [Flatpak] Second run update-webkitwpe-flatpak fails
1685         https://bugs.webkit.org/show_bug.cgi?id=192702
1686
1687         Reviewed by Carlos Garcia Campos.
1688
1689         * flatpak/flatpakutils.py:
1690         (FlatpakObject.flatpak): Fix typo.
1691         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1692         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1693
1694 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1695
1696         [GTK][WPE] outlook.live.com displays old-fashioned UI
1697         https://bugs.webkit.org/show_bug.cgi?id=196642
1698
1699         Reviewed by Carlos Garcia Campos.
1700
1701         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1702         (TestWebKitAPI::TEST): New Mac platform quirk test.
1703
1704 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1705
1706         Unreviewed, rolling out r243956.
1707         https://bugs.webkit.org/show_bug.cgi?id=196688
1708
1709         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1710         by aakashjain on #webkit).
1711
1712         Reverted changeset:
1713
1714         "Clicking "Go Back" from a safe browsing warning from an
1715         iframe should navigate the WKWebView back to the previous
1716         page"
1717         https://bugs.webkit.org/show_bug.cgi?id=196665
1718         https://trac.webkit.org/changeset/243956
1719
1720 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1721
1722         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1723         https://bugs.webkit.org/show_bug.cgi?id=196669
1724
1725         Reviewed by Geoffrey Garen.
1726
1727         Added three new unit tests for WeakHashSet.
1728
1729         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1730         (WTF_WeakPtr.WeakHashSetConstObjects):
1731         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1732         (WTF_WeakPtr.WeakHashSetComputeSize):
1733
1734 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1735
1736         Hide next and previous form control buttons when WKWebView is editable
1737         https://bugs.webkit.org/show_bug.cgi?id=196672
1738         <rdar://problem/35625321>
1739
1740         Reviewed by Tim Horton.
1741
1742         Add a new API test.
1743
1744         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1745         (-[TestWKWebView lastTrailingBarButtonGroup]):
1746         (TestWebKitAPI::TEST):
1747         * TestWebKitAPI/ios/UIKitSPI.h:
1748
1749 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1750
1751         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1752         https://bugs.webkit.org/show_bug.cgi?id=196077
1753         <rdar://problem/49108202>
1754
1755         Reviewed by Chris Dumez.
1756
1757         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1758         on new web view.
1759
1760         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1761
1762 2019-04-05  Saam Barati  <sbarati@apple.com>
1763
1764         Make compare-results understand MotionMark
1765         https://bugs.webkit.org/show_bug.cgi?id=196666
1766
1767         Reviewed by Yusuke Suzuki.
1768
1769         * Scripts/compare-results:
1770         (PLT5Results):
1771         (detectMotionMark):
1772         (detectMotionMark1_1):
1773         (motionMarkResults):
1774         (motionMark1_1Results):
1775         (detectBenchmark):
1776         (biggerIsBetter):
1777         (main):
1778
1779 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1780
1781         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1782         https://bugs.webkit.org/show_bug.cgi?id=196665
1783         <rdar://45115669>
1784
1785         Reviewed by Geoff Garen.
1786
1787         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1788         (goBack):
1789         (+[SimpleLookupContext sharedLookupContext]):
1790         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1791         (TEST):
1792         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1793         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1794
1795 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1796
1797         [ews-build] Add configuration and architecture for windows builders
1798         https://bugs.webkit.org/show_bug.cgi?id=196660
1799
1800         Reviewed by Lucas Forschler.
1801
1802         * BuildSlaveSupport/ews-build/config.json:
1803
1804 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1805
1806         webkitpy: Don't run subsequent rounds if interrupted
1807         https://bugs.webkit.org/show_bug.cgi?id=196646
1808
1809         Reviewed by Aakash Jain.
1810
1811         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1812         (Manager.run): Bail out if interrupted.
1813
1814 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1815
1816         Test sessionStorage in PSON private browsing mode
1817         https://bugs.webkit.org/show_bug.cgi?id=196561
1818
1819         Reviewed by Alex Christensen.
1820
1821         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1822
1823 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1824
1825         Unreviewed, rolling out r243833.
1826         https://bugs.webkit.org/show_bug.cgi?id=196645
1827
1828         This change breaks build of WPE and GTK ports (Requested by
1829         annulen on #webkit).
1830
1831         Reverted changeset:
1832
1833         "[CMake][WTF] Mirror XCode header directories"
1834         https://bugs.webkit.org/show_bug.cgi?id=191662
1835         https://trac.webkit.org/changeset/243833
1836
1837 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1838
1839         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1840         https://bugs.webkit.org/show_bug.cgi?id=196635
1841
1842         Reviewed by Antti Koivisto.
1843         
1844         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1845         for a test to enable async frame scrolling via:
1846             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1847         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1848         
1849         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1850
1851         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1852         (WTR::InjectedBundle::beginTesting):
1853         * WebKitTestRunner/TestController.cpp:
1854         (WTR::TestController::resetPreferencesToConsistentValues):
1855
1856 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1857
1858         Use a correct LC_RPATH when building with ASan
1859         https://bugs.webkit.org/show_bug.cgi?id=196576
1860
1861         Reviewed by David Kilzer.
1862
1863         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1864         so that ../Frameworks is checked. This is simpler and more reliable than updating
1865         each SPC service xcconfig.
1866
1867 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1868
1869         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1870         https://bugs.webkit.org/show_bug.cgi?id=196629
1871
1872         Reviewed by Lucas Forschler.
1873
1874         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1875
1876 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1877
1878         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1879         https://bugs.webkit.org/show_bug.cgi?id=196618
1880
1881         Reviewed by Lucas Forschler.
1882
1883         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1884         (StatusBubble): Added QUEUE_TRIGGERS.
1885         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1886         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1887         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1888         its parent(builder).
1889
1890 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1891
1892         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1893         https://bugs.webkit.org/show_bug.cgi?id=196625
1894
1895         Reviewed by Lucas Forschler.
1896
1897         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1898         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1899
1900 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1901
1902         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1903         https://bugs.webkit.org/show_bug.cgi?id=196630
1904
1905         Reviewed by Wenson Hsieh.
1906
1907         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1908
1909 2019-04-04  Youenn Fablet  <youenn@apple.com>
1910
1911         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1912         https://bugs.webkit.org/show_bug.cgi?id=196543
1913
1914         Reviewed by Alex Christensen.
1915
1916         * WebKitTestRunner/TestController.cpp:
1917         (WTR::TestController::generatePageConfiguration):
1918
1919 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1920
1921         [ews-app] Status bubble should not display skipped buildbot steps
1922         https://bugs.webkit.org/show_bug.cgi?id=196584
1923
1924         Reviewed by Lucas Forschler.
1925
1926         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1927
1928 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1929
1930         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1931         https://bugs.webkit.org/show_bug.cgi?id=196620
1932
1933         Reviewed by Lucas Forschler.
1934
1935         * BuildSlaveSupport/ews-app/ews/config.py:
1936
1937 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1938
1939         [Win] DumpRenderTreeWatchDog.py is not checked into source
1940         https://bugs.webkit.org/show_bug.cgi?id=196567
1941         <rdar://problem/49525901>
1942
1943         Reviewed by Lucas Forschler.
1944
1945         This script is used on Win EWS bots to terminate hanging DRT processes.
1946
1947         * EWSTools/dumprendertreewatchdog.py: Added.
1948
1949 2019-04-04  Chris Dumez  <cdumez@apple.com>
1950
1951         Unreviewed, roll out r243858 which made tests time out.
1952
1953         Disable new API tests on Windows instead.
1954
1955         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1956         (TestWebKitAPI::TEST):
1957
1958 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1959
1960         [ATK] Cleanup WebPageAccessibilityObjectAtk
1961         https://bugs.webkit.org/show_bug.cgi?id=196537
1962
1963         Reviewed by Michael Catanzaro.
1964
1965         Also consider files under atk directories as exceptions for GObject conventions.
1966
1967         * Scripts/webkitpy/style/checkers/cpp.py:
1968         (check_identifier_name_in_declaration):
1969
1970 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1971
1972         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1973         https://bugs.webkit.org/show_bug.cgi?id=196588
1974         <rdar://problem/49365787>
1975
1976         Unreviewed build fix for Windows port.
1977
1978         error C3861: 'kill': identifier not found
1979
1980         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1981         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1982
1983 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1984
1985         [ews-build] Cancel build and similar operations should have authentication
1986         https://bugs.webkit.org/show_bug.cgi?id=196520
1987
1988         Reviewed by Dewei Zhu.
1989
1990         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1991         environment variables.
1992
1993 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1994
1995         [ews-build] Do not trigger queues which are not in production yet
1996         https://bugs.webkit.org/show_bug.cgi?id=196581
1997
1998         Reviewed by Dewei Zhu.
1999
2000         * BuildSlaveSupport/ews-build/config.json:
2001
2002 2019-04-03  Chris Dumez  <cdumez@apple.com>
2003
2004         Unreviewed, fix typo in the name of API test added in r243848.
2005
2006         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2007         (TestWebKitAPI::TEST):
2008
2009 2019-04-03  Chris Dumez  <cdumez@apple.com>
2010
2011         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2012         https://bugs.webkit.org/show_bug.cgi?id=196588
2013         <rdar://problem/49365787>
2014
2015         Reviewed by Ryosuke Niwa.
2016
2017         Add API test coverage.
2018
2019         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2020         (TestWebKitAPI::nullJavaScriptCallback):
2021         (TestWebKitAPI::didCrashCheckFrames):
2022         (TestWebKitAPI::TEST):
2023
2024 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2025
2026         run-webkit-tests: Upload test results (new results database)
2027         https://bugs.webkit.org/show_bug.cgi?id=196577
2028         <rdar://problem/34841155>
2029
2030         Reviewed by Lucas Forschler.
2031
2032         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2033         (Manager.run): Upload results after each device shard, since the configuration will be
2034         different for each device.
2035         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2036         uploaded to a results database.
2037         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2038         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2039
2040 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2041
2042         -apple-trailing-word is needed for browser detection
2043         https://bugs.webkit.org/show_bug.cgi?id=196575
2044
2045         Unreviewed.
2046
2047         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2048
2049 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2050
2051         [CMake][WTF] Mirror XCode header directories
2052         https://bugs.webkit.org/show_bug.cgi?id=191662
2053
2054         Reviewed by Konstantin Tokarev.
2055
2056         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2057         builds.
2058
2059         * CMakeLists.txt:
2060         * DumpRenderTree/CMakeLists.txt:
2061         * DumpRenderTree/PlatformWin.cmake:
2062         * MiniBrowser/win/CMakeLists.txt:
2063         * TestWebKitAPI/CMakeLists.txt:
2064         * TestWebKitAPI/PlatformWin.cmake:
2065         * WebKitTestRunner/PlatformGTK.cmake:
2066         * WebKitTestRunner/PlatformWin.cmake:
2067
2068 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2069
2070         [ews-app] Status bubble should not display certain infrastructure status messages
2071         https://bugs.webkit.org/show_bug.cgi?id=196550
2072
2073         Reviewed by Lucas Forschler.
2074
2075         Do not display the steps which are un-needed for end-user. This information is still avaiable
2076         if the user click on the bubble and look at the Buildbot build.
2077         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2078         (StatusBubble._steps_messages):
2079         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2080
2081 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2082
2083         [ews-build] Use https for sending data to ews-app
2084         https://bugs.webkit.org/show_bug.cgi?id=196492
2085
2086         Reviewed by Lucas Forschler.
2087
2088         * BuildSlaveSupport/ews-build/events.py:
2089
2090 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2091
2092         Remove support for -apple-trailing-word
2093         https://bugs.webkit.org/show_bug.cgi?id=196525
2094
2095         Reviewed by Zalan Bujtas.
2096
2097         This CSS property is nonstandard and not used.
2098
2099         * Scripts/webkitperl/FeatureList.pm:
2100         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2101
2102 2019-04-03  Youenn Fablet  <youenn@apple.com>
2103
2104         Add a test for DOMCache on multiple browsing in case of private browsing
2105         https://bugs.webkit.org/show_bug.cgi?id=196524
2106
2107         Reviewed by Alex Christensen.
2108
2109         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2110         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2111
2112 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2113
2114         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2115         https://bugs.webkit.org/show_bug.cgi?id=196540
2116
2117         Reviewed by Aakash Jain.
2118
2119         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2120
2121 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2122
2123         Add plumbing for a compatibility mode preference in WebKit
2124         https://bugs.webkit.org/show_bug.cgi?id=196005
2125
2126         Reviewed by Tim Horton.
2127
2128         Add new API tests.
2129
2130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2131         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2132
2133 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2134
2135         [WPE][GTK] Update libsrtp dependency package for Debian
2136         https://bugs.webkit.org/show_bug.cgi?id=196528
2137
2138         Reviewed by Frédéric Wang.
2139
2140         * gtk/install-dependencies:
2141         * wpe/install-dependencies:
2142
2143 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2144
2145         [WK2] Add support for Window's beforeprint / afterprint events
2146         https://bugs.webkit.org/show_bug.cgi?id=196478
2147         <rdar://problem/49535124>
2148
2149         Unreviewed build fix for MSVC.
2150
2151         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2152
2153         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2154
2155         * WebKitTestRunner/TestController.cpp:
2156         (WTR::printFrame): Use int and float literals.
2157
2158 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2159
2160         [ews-build] Reassign bots to queues
2161
2162         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2163
2164 2019-04-02  Chris Dumez  <cdumez@apple.com>
2165
2166         [WK2] Add support for Window's beforeprint / afterprint events
2167         https://bugs.webkit.org/show_bug.cgi?id=196478
2168
2169         Reviewed by Alex Christensen.
2170
2171         Add minimal implementation for printFrame in WebKitTestRunner.
2172
2173         * WebKitTestRunner/TestController.cpp:
2174         (WTR::printFrame):
2175         (WTR::TestController::createOtherPage):
2176         (WTR::TestController::createWebViewWithOptions):
2177
2178 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2179
2180         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2181         https://bugs.webkit.org/show_bug.cgi?id=196491
2182
2183         Reviewed by Lucas Forschler.
2184
2185         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2186
2187 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2188
2189         [ews-build] Configure buildbot try credentials in environment variables
2190         https://bugs.webkit.org/show_bug.cgi?id=196501
2191
2192         Reviewed by Lucas Forschler.
2193
2194         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2195         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2196         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2197
2198 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2199
2200         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2201         https://bugs.webkit.org/show_bug.cgi?id=196496
2202         <rdar://problem/49521634>
2203
2204         Reviewed by Chris Dumez.
2205
2206         Add new API tests (see WebKit ChangeLog for more detail).
2207
2208         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2209         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2210         (TEST):
2211
2212 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2213
2214         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2215         <https://webkit.org/b/196499>
2216
2217         Reviewed by Alexey Proskuryakov.
2218
2219         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2220         ENABLE_ADDRESS_SANITIZER.
2221
2222 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2223
2224         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2225         https://bugs.webkit.org/show_bug.cgi?id=182757
2226
2227         Reviewed by Don Olmstead.
2228
2229         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2230         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2231
2232 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2233
2234         run-api-tests: Upload test results
2235         https://bugs.webkit.org/show_bug.cgi?id=196323
2236         <rdar://problem/49356714>
2237
2238         Reviewed by Lucas Forschler.
2239
2240         * Scripts/webkitpy/api_tests/manager.py:
2241         (Manager):
2242         (Manager.run): Upload results to a results database.
2243         * Scripts/webkitpy/api_tests/run_api_tests.py:
2244         (parse_args): Add upload arguments.
2245         * Scripts/webkitpy/port/base.py:
2246         (Port):
2247         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2248         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2249         with commits from any other associated repositories.
2250         * Scripts/webkitpy/port/device.py:
2251         (Device):
2252         (Device.build_version): Access build_versoin of underlying platform device.
2253         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2254         (IOSSimulatorTest):
2255         (IOSSimulatorTest.test_configuration_for_upload):
2256         * Scripts/webkitpy/port/device_port.py:
2257         (DevicePort):
2258         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2259         the same as the machine uploading results.
2260         * Scripts/webkitpy/port/mac.py:
2261         (MacPort):
2262         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2263         * Scripts/webkitpy/port/mac_unittest.py:
2264         (MacTest):
2265         (MacTest.test_configuration_for_upload):
2266         * Scripts/webkitpy/xcode/simulated_device.py:
2267         (SimulatedDeviceManager._create_device_with_runtime):
2268         (SimulatedDevice.__init__): Create simulated device with a build_version.
2269         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2270         (test_existing_simulator):
2271
2272 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2273
2274         Remove extra newline characters (Follow-up fix to r243707)
2275
2276         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2277
2278 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2279
2280         [ews-app] Use API_KEY to accept results data
2281         https://bugs.webkit.org/show_bug.cgi?id=196461
2282
2283         Reviewed by Dewei Zhu.
2284
2285         * BuildSlaveSupport/ews-app/ews/views/results.py:
2286         (Results.post): Validate EWS_API_KEY before accepting any data.
2287         * BuildSlaveSupport/ews-build/events.py:
2288         (Events.sendData): Send EWS_API_KEY if available along with event data.
2289
2290 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2291
2292         Unable to copy and paste a PDF from Notes into Mail compose body
2293         https://bugs.webkit.org/show_bug.cgi?id=196442
2294         <rdar://problem/48573098>
2295
2296         Reviewed by Tim Horton.
2297
2298         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2299         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2300         to be specified on the item providers.
2301
2302         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2303         (TestWebKitAPI::mapItemForTesting):
2304         (TestWebKitAPI::contactItemForTesting):
2305
2306 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2307
2308         Make UIWKDocumentContext rects per-character instead of per-word
2309         https://bugs.webkit.org/show_bug.cgi?id=196459
2310
2311         Reviewed by Wenson Hsieh.
2312
2313         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2314         (TEST):
2315         Adjust test results due to switching to per-character rects.
2316
2317 2019-04-01  Chris Dumez  <cdumez@apple.com>
2318
2319         UIProcess crash when a prewarmed process is terminated
2320         https://bugs.webkit.org/show_bug.cgi?id=196451
2321         <rdar://problem/49245471>
2322
2323         Reviewed by Geoffrey Garen.
2324
2325         Add API test coverage.
2326
2327         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2328         (TEST):
2329
2330 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2331
2332         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2333         https://bugs.webkit.org/show_bug.cgi?id=196449
2334
2335         Reviewed by Lucas Forschler.
2336
2337         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2338         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2339         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2340         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2341
2342 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2343
2344         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2345         https://bugs.webkit.org/show_bug.cgi?id=196444
2346
2347         Reviewed by Lucas Forschler.
2348
2349         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2350
2351 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2352
2353         Add SPI to canonicalize NSURLs with WTF::URL
2354         https://bugs.webkit.org/show_bug.cgi?id=196415
2355         <rdar://problem/44980271>
2356
2357         Reviewed by Darin Adler.
2358
2359         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2360         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2361         (TestWebKitAPI::TEST):
2362
2363 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2364
2365         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2366         https://bugs.webkit.org/show_bug.cgi?id=196441
2367
2368         Reviewed by Carlos Garcia Campos.
2369
2370         Don't cache the wpe_view_backend object that might not exist yet at the
2371         time of EventSenderProxy constructor invocation, but instead retrieve
2372         that object whenever it's required for event dispatching. This should
2373         avoid crashes in this constructor now that it's invoked before any
2374         PlatformWindow has been set up (as changed in r243496).
2375
2376         * WebKitTestRunner/EventSenderProxy.h:
2377         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2378         (WTR::viewBackend):
2379         (WTR::EventSenderProxy::EventSenderProxy):
2380         (WTR::EventSenderProxy::mouseDown):
2381         (WTR::EventSenderProxy::mouseUp):
2382         (WTR::EventSenderProxy::mouseMoveTo):
2383         (WTR::EventSenderProxy::mouseScrollBy):
2384         (WTR::EventSenderProxy::keyDown):
2385         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2386
2387 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2388
2389         [Win][WebKit] MiniBrowser should support high DPI display
2390         https://bugs.webkit.org/show_bug.cgi?id=196391
2391
2392         Reviewed by Alex Christensen.
2393
2394         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2395         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2396         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2397         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2398
2399 2019-03-31  Sam Weinig  <weinig@apple.com>
2400
2401         Remove more i386 specific configurations
2402         https://bugs.webkit.org/show_bug.cgi?id=196430
2403
2404         Reviewed by Alexey Proskuryakov.
2405
2406         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2407         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2408
2409 2019-03-31  Andy Estes  <aestes@apple.com>
2410
2411         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2412         https://bugs.webkit.org/show_bug.cgi?id=196433
2413         <rdar://problem/49293305>
2414
2415         Reviewed by Tim Horton.
2416
2417         Enhanced API test coverage to include all navigation response policy decisions in both
2418         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2419
2420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2421         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2422         (TestWebKitAPI::TEST):
2423         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2424         (readFile):
2425         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2426         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2427         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2428         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2429         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2430         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2431         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2432         (-[QuickLookDelegate _downloadDidStart:]):
2433         (-[QuickLookDelegate _download:didReceiveResponse:]):
2434         (-[QuickLookDelegate _download:didReceiveData:]):
2435         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2436         (-[QuickLookDelegate _downloadDidFinish:]):
2437         (-[QuickLookDelegate _download:didFailWithError:]):
2438         (-[QuickLookDelegate _downloadDidCancel:]):
2439         (-[QuickLookDelegate verifyDownload]):
2440         (runTest):
2441         (runTestDecideBeforeLoading):
2442         (runTestDecideAfterLoading):
2443         (TEST):
2444         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2445         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2446         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2447         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2448         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2449         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2450         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2451         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2452         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2453         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2454         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2455         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2456         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2457         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2458
2459 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2460
2461         [CMake] add testdfg as target with build-jsc
2462         https://bugs.webkit.org/show_bug.cgi?id=196393
2463
2464         Reviewed by Saam Barati.
2465
2466         Added testdfg as one of the targets to build when
2467         using CMake.
2468
2469         * Scripts/build-jsc:
2470
2471 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2472
2473         Delete WebMetal implementation in favor of WebGPU
2474         https://bugs.webkit.org/show_bug.cgi?id=195418
2475
2476         Reviewed by Dean Jackson.
2477
2478         * DumpRenderTree/mac/DumpRenderTree.mm:
2479         (enableExperimentalFeatures):
2480         (resetWebPreferencesToConsistentValues):
2481         * Scripts/webkitperl/FeatureList.pm:
2482         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2484         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2485         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2486         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2487         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2488         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2489         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2490         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2491         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2492         (WTR::InjectedBundle::beginTesting):
2493         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2494         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2495         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2496
2497 2019-03-29  Chris Dumez  <cdumez@apple.com>
2498
2499         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2500         https://bugs.webkit.org/show_bug.cgi?id=196405
2501         <rdar://problem/49428130>
2502
2503         Reviewed by Wenson Hsieh.
2504
2505         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2506         the popover presentation methods to be no-ops. Use this in the new test added in
2507         r243523 so that we do not swizzle those methods for all tests. This is needed because
2508         those WatchOS tests rely on the popover getting presented and interactive.
2509
2510         * WebKitTestRunner/TestController.cpp:
2511         (WTR::updateTestOptionsFromTestHeader):
2512         * WebKitTestRunner/TestController.h:
2513         * WebKitTestRunner/TestOptions.h:
2514         (WTR::TestOptions::hasSameInitializationOptions const):
2515         * WebKitTestRunner/ios/TestControllerIOS.mm:
2516         (WTR::TestController::platformInitialize):
2517         (WTR::TestController::platformResetStateToConsistentValues):
2518
2519 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2520
2521         [Curl] Add Server Trust Evaluation Support.
2522         https://bugs.webkit.org/show_bug.cgi?id=191646
2523
2524         Reviewed by Fujii Hironori.
2525
2526         Implemented MiniBrowser UI for asking if user trusts the server.
2527
2528         * MiniBrowser/win/Common.cpp:
2529         (askServerTrustEvaluation):
2530         (replaceString):
2531         * MiniBrowser/win/Common.h:
2532         * MiniBrowser/win/MiniBrowserLib.rc:
2533         * MiniBrowser/win/MiniBrowserLibResource.h:
2534         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2535         (createPEMString):
2536         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2537         (WebKitBrowserWindow::canTrustServerCertificate):
2538         * MiniBrowser/win/WebKitBrowserWindow.h:
2539
2540 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2541
2542         Implement ResizeObserver.
2543         https://bugs.webkit.org/show_bug.cgi?id=157743
2544
2545         Reviewed by Simon Fraser.
2546
2547         Support resizeObserverEnabled webPreferences.
2548
2549         * DumpRenderTree/TestOptions.cpp:
2550         (TestOptions::TestOptions):
2551         * DumpRenderTree/TestOptions.h:
2552         * DumpRenderTree/mac/DumpRenderTree.mm:
2553         (setWebPreferencesForTestOptions):
2554         * DumpRenderTree/win/DumpRenderTree.cpp:
2555         (enableExperimentalFeatures):
2556         * Scripts/webkitperl/FeatureList.pm:
2557         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2558
2559 2019-03-28  John Wilander  <wilander@apple.com>
2560
2561         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2562         https://bugs.webkit.org/show_bug.cgi?id=196281
2563         <rdar://problem/48938748>
2564
2565         Reviewed by Alex Christensen.
2566
2567         This patch adds the function isStatisticsHasLocalStorage() to the
2568         TestRunner. With it, the page can query the WebsiteDataStore in the
2569         UI process to make sure that it sees LocalStorage.
2570
2571         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2572         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2573         (WTR::TestRunner::isStatisticsHasLocalStorage):
2574         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2575         * WebKitTestRunner/TestController.cpp:
2576         (WTR::TestController::isStatisticsHasLocalStorage):
2577         * WebKitTestRunner/TestController.h:
2578         * WebKitTestRunner/TestInvocation.cpp:
2579         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2580
2581 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2582
2583         API::Data::createWithoutCopying should do a null check before calling CFRelease
2584         https://bugs.webkit.org/show_bug.cgi?id=196276
2585         <rdar://problem/48059859>
2586
2587         Reviewed by Alex Christensen.
2588
2589         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2590
2591         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2592         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2593         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2594         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2595         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2596         (TestWebKitAPI::TEST):
2597
2598 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2599
2600         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2601         https://bugs.webkit.org/show_bug.cgi?id=186276
2602
2603         Reviewed by Carlos Garcia Campos.
2604
2605         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2606         (webViewLoadChanged):
2607         (testWebResourceGetDataError):
2608         (testWebResourceGetDataEmpty):
2609         (beforeAll):
2610         (webViewloadChanged): Deleted.
2611
2612 2019-03-27  Andy Estes  <aestes@apple.com>
2613
2614         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2615         https://bugs.webkit.org/show_bug.cgi?id=196317
2616
2617         Reviewed by Dan Bernstein.
2618
2619         package-root copies built products into a staging directory using ditto(1), which does not
2620         follow symbolic links as it traverses a directory. Now that the files in
2621         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2622         itself, these become broken links when ditto'd into the staging directory.
2623
2624         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2625
2626         * Scripts/package-root:
2627
2628 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2629
2630         [ews-app] Update display text of Submit for ews analysis
2631         https://bugs.webkit.org/show_bug.cgi?id=196309
2632
2633         Reviewed by Dewei Zhu.
2634
2635         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2636
2637 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2638
2639         run-webkit-tests should check for leaks in WebKit processes
2640         <https://webkit.org/b/193772>
2641         <rdar://problem/46526680>
2642
2643         Reviewed by Ryosuke Niwa.
2644
2645         This works by doing the following:
2646         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2647           The list of child processes are returned one per line:
2648           process.name: pid
2649         - Run the "#LIST CHILD PROCESSES" command just before the
2650           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2651           processes on the ServerProcess object.
2652         - When the `--leaks` switch is handled, run check_for_leaks() on
2653           each child process after the main test harness.
2654
2655         * DumpRenderTree/mac/DumpRenderTree.mm:
2656         (handleControlCommand):
2657         - Use strncmp() instead of strcmp().
2658         - Add support for handling "#LIST CHILD PROCESSES" command.
2659
2660         * Scripts/webkitpy/port/base.py:
2661         (Port.check_for_leaks):
2662         * Scripts/webkitpy/port/darwin.py:
2663         (DarwinPort.check_for_leaks):
2664         - Rename redundant 'process_pid' argument to 'process_id'.
2665
2666         * Scripts/webkitpy/port/driver.py:
2667         (Driver.do_post_tests_work):
2668         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2669           longer the only command this sends to WebKitTestRunner.
2670         - If the `--leaks` switch is present, send the
2671           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2672           result using Port.set_webkit_processes().
2673         (Driver._parse_child_processes_output):
2674         - Add helper method to parse list of child process names and
2675           process IDs returned from WebKitTestRunner.
2676
2677         * Scripts/webkitpy/port/ios_device.py:
2678         (IOSDevicePort.check_for_leaks):
2679         - Rename redundant 'process_pid' argument to 'process_id'.
2680
2681         * Scripts/webkitpy/port/leakdetector.py:
2682         (LeakDetector._parse_leaks_output):
2683         - Return early if there is no leaks_output.
2684         (LeakDetector.check_for_leaks):
2685         - Rename redundant 'process_pid' argument to 'process_id'.
2686
2687         * Scripts/webkitpy/port/server_process.py:
2688         (ServerProcess.__init__):
2689         (ServerProcess.child_processes):
2690         (ServerProcess.set_child_processes):
2691         - Add instance variable to Port to store list of child process
2692           names and process IDs returned from WebKitTestRunner.
2693         (ServerProcess._start):
2694         - Clear self._child_processes.
2695         (ServerProcess.stop):
2696         - If self._child_processes is set, call
2697           self._port.check_for_leaks() for each child process.
2698
2699         * Scripts/webkitpy/port/server_process_unittest.py:
2700         (TrivialMockPort.check_for_leaks):
2701         - Rename redundant 'process_pid' argument to 'process_id'.
2702
2703         * Scripts/webkitpy/port/simulator_process.py:
2704         (SimulatorProcess.stop):
2705         - If self._child_processes is set, call
2706           self._port.check_for_leaks() for each child process.
2707
2708         * Scripts/webkitpy/port/watch_device.py:
2709         (WatchDevicePort.check_for_leaks):
2710         - Rename redundant 'process_pid' argument to 'process_id'.
2711
2712         * WebKitTestRunner/TestController.cpp:
2713         (WTR::TestController::dumpResponse):
2714         - Extract method from findAndDumpWorldLeaks() so that it may be
2715           reused by findAndDumpWebKitProcessIdentifiers().
2716         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2717         - Add method to output process name and process ID of both the
2718           WebContent and Networking processes.
2719         (WTR::TestController::findAndDumpWorldLeaks):
2720         - Fix missing newline in output when there were no abandoned
2721           documents.
2722         - Call dumpResponse() for extracted code.
2723         (WTR::TestController::handleControlCommand):
2724         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2725         - Use strncmp() instead of strcmp().
2726         - Call findAndDumpWebKitProcessIdentifiers() when
2727           "#LIST CHILD PROCESSES" command is sent.
2728         * WebKitTestRunner/TestController.h:
2729         (WTR::TestController::dumpResponse):
2730         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2731         - Declare methods.
2732
2733 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2734
2735         Unreviewed. Add GLib API test cases after r243434.
2736
2737         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2738         (testWebViewActiveURI):
2739         (serverCallback):
2740         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2741         (sendRequestCallback):
2742
2743 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2744
2745         Geolocation request not complete when watch request was started in a different web process
2746         https://bugs.webkit.org/show_bug.cgi?id=195996
2747
2748         Reviewed by Alex Christensen.
2749
2750         Add a test case.
2751
2752         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2753         (TestWebKitAPI::runJavaScriptAlert):
2754         (TestWebKitAPI::TEST):
2755
2756 2019-03-26  Keith Rollin  <krollin@apple.com>
2757
2758         Update the way generate-xcfilelists returns strings from functions
2759         https://bugs.webkit.org/show_bug.cgi?id=195975
2760         <rdar://problem/49040807>
2761
2762         Reviewed by Dean Jackson.
2763
2764         There are places where generate-xcfilelists executes assignments with
2765         statements like:
2766
2767             FOO=$(some_function)
2768
2769         where "some_function" return a string by echoing it. E.g.
2770
2771             some_function()
2772             {
2773                 echo "Hello, World"
2774             }
2775
2776         This is a common idiom, but it has a problem if "some_function" needs
2777         to call "exit" in an attempt to halt the entire script right then and
2778         there. Since "some_function" is called inside of $(), it's being
2779         executed in a sub-shell. Calling exit in that sub-shell simply exits
2780         that shell; it doesn't not exit the outer shell in which the main part
2781         of the script is still running. As such, the main script keeps
2782         executing when the intent was for the script to halt.
2783
2784         The solution to this is to use a different idiom for returning
2785         strings. The one we now is to pass in the name of the variable to
2786         receive the string result:
2787
2788             some_function()
2789             {
2790                 variable_name=$1
2791                 eval $variable_name ="Hello, World"
2792             }
2793
2794         The call site now looks like
2795
2796             some_function FOO
2797
2798         Because there's no invocation of a sub-shell, some_function can now
2799         call "exit" if it wants to, and the entire script will exit at that
2800         point.
2801
2802         * Scripts/generate-xcfilelists:
2803
2804 2019-03-26  Chris Dumez  <cdumez@apple.com>
2805
2806         Add basic layout test coverage for File Picker on iOS
2807         https://bugs.webkit.org/show_bug.cgi?id=196265
2808
2809         Reviewed by Wenson Hsieh.
2810
2811         Add layout test infrastructure to test the file picker on iOS.
2812
2813         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2814         (WTR::UIScriptController::dismissFilePicker):
2815         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2816         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2817         (WTR::UIScriptController::dismissFilePicker):
2818         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2819         * WebKitTestRunner/TestController.cpp:
2820         (WTR::TestController::createWebViewWithOptions):
2821         (WTR::updateTestOptionsFromTestHeader):
2822         * WebKitTestRunner/TestOptions.h:
2823         (WTR::TestOptions::hasSameInitializationOptions const):
2824         * WebKitTestRunner/ios/TestControllerIOS.mm:
2825         (overridePresentViewController):
2826         (WTR::TestController::platformInitialize):
2827         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2828         (WTR::UIScriptController::dismissFilePicker):
2829
2830 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2831
2832         Implement async paste method on UIWKInteractionViewProtocol
2833         https://bugs.webkit.org/show_bug.cgi?id=196267
2834         <rdar://problem/49236346>
2835
2836         Reviewed by Tim Horton.
2837
2838         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2839         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2840         are now a part of all iOS 12 internal SDKs.
2841
2842         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2843
2844         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2845         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2846
2847         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2848         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2849         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2850         * TestWebKitAPI/ios/UIKitSPI.h:
2851
2852 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2853
2854         [ews-build] Use PostgreSQL for ews.webkit.org database
2855         https://bugs.webkit.org/show_bug.cgi?id=196270
2856
2857         Reviewed by Lucas Forschler.
2858
2859         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2860
2861 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2862
2863         [ews] Reset simctl states on reboot
2864         https://bugs.webkit.org/show_bug.cgi?id=196260
2865
2866         Rubber-stamped by Aakash Jain.
2867
2868         * EWSTools/start-queue-mac.sh:
2869
2870 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2871
2872         [ews-build] Use PostgreSQL for ews-build database
2873         https://bugs.webkit.org/show_bug.cgi?id=196229
2874
2875         Reviewed by Lucas Forschler.
2876
2877         * BuildSlaveSupport/ews-build/master.cfg:
2878
2879 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2880
2881         [ews-build] Get master_hostname dynamically in master.cfg
2882         https://bugs.webkit.org/show_bug.cgi?id=196255
2883
2884         Reviewed by Lucas Forschler.
2885
2886         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2887         send events data in test mode.
2888
2889 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2890
2891         [ews-app] Set db_constraint to False for Foreign Keys
2892         https://bugs.webkit.org/show_bug.cgi?id=196252
2893
2894         Reviewed by Lucas Forschler.
2895
2896         * BuildSlaveSupport/ews-app/ews/models/build.py:
2897         * BuildSlaveSupport/ews-app/ews/models/step.py:
2898
2899 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2900
2901         [ews-build] is_test_mode_enabled should default to True
2902         https://bugs.webkit.org/show_bug.cgi?id=196248
2903
2904         Reviewed by Lucas Forschler.
2905
2906         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2907
2908 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2909
2910         [ews-app] Add webkitperl to ENABLED_QUEUES
2911         https://bugs.webkit.org/show_bug.cgi?id=196253
2912
2913         Reviewed by Lucas Forschler.
2914
2915         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2916
2917 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2918
2919         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2920         https://bugs.webkit.org/show_bug.cgi?id=196211
2921         rdar://problem/49110552
2922
2923         Reviewed by Tim Horton.
2924
2925         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2926         Make sure that EventSenderProxy always exists when running tests. We used to create
2927         it when resetting before the first test, which is a bit too late.
2928
2929         * WebKitTestRunner/TestController.h:
2930         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2931         (WTR::TestController::platformCreateWebView):
2932         (WTR::TestController::platformCreateOtherPage):
2933         (WTR::TestController::finishCreatingPlatformWebView):
2934         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2935         (WTR::PlatformWebView::PlatformWebView):
2936         Moved some code that made NSWindow use NSEvent during web view creation. We may
2937         need to move more if some other case us found, but this is enough for now.
2938
2939 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2940
2941         Unreviewed. Fix typo in GLib geolocation API after r243285.
2942
2943         gelocation -> geolocation.
2944
2945         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2946         (testGeolocationManagerWatchPosition):
2947
2948 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2949
2950         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2951         https://bugs.webkit.org/show_bug.cgi?id=196213
2952
2953         Reviewed by Geoff Garen.
2954
2955         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2956         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2957         (credentialWithIdentityAndKeychainPath):
2958         (-[ChallengeDelegate webView:didFinishNavigation:]):
2959         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2960         (TestWebKitAPI::TEST):
2961
2962 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2963
2964         Expected shouldn't assume its contained types are copyable
2965         https://bugs.webkit.org/show_bug.cgi?id=195986
2966
2967         Reviewed by JF Bastien.
2968
2969         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2970         (TestWebKitAPI::NonCopyable::operator== const):
2971         (TestWebKitAPI::NonCopyable::operator!= const):
2972         (TestWebKitAPI::TEST):
2973
2974 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2975
2976         Remove some now-unnecessary dynamic class lookup
2977         https://bugs.webkit.org/show_bug.cgi?id=196237
2978
2979         Reviewed by Simon Fraser.
2980
2981         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2982         (makeRequest):
2983         (TEST):
2984
2985 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2986
2987         Unreviewed, rolling out r243450.
2988
2989         AppleWin and WinCairo port builds get broken.
2990
2991         Reverted changeset:
2992
2993         "Add test for fix of #196095"
2994         https://bugs.webkit.org/show_bug.cgi?id=196097
2995         https://trac.webkit.org/changeset/243450
2996
2997 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2998
2999         Unreviewed, rolling out r243465.
3000         https://bugs.webkit.org/show_bug.cgi?id=196226
3001
3002         the test doesn't build (Requested by thorton on #webkit).
3003
3004         Reverted changeset:
3005
3006         "Do not terminate the NetworkProcess if a third party
3007         application sends a NSCredential with a SecIdentityRef"
3008         https://bugs.webkit.org/show_bug.cgi?id=196213
3009         https://trac.webkit.org/changeset/243465
3010
3011 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3012
3013         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3014         https://bugs.webkit.org/show_bug.cgi?id=196213
3015
3016         Reviewed by Geoff Garen.
3017
3018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3019         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3020         (credentialWithIdentityAndKeychainPath):
3021         (-[ChallengeDelegate webView:didFinishNavigation:]):
3022         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3023         (TestWebKitAPI::TEST):
3024
3025 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3026
3027         [ews-build] Gracefully handle missing patch_id in events
3028         https://bugs.webkit.org/show_bug.cgi?id=196216
3029
3030         Reviewed by Lucas Forschler.
3031
3032         * BuildSlaveSupport/ews-build/events.py:
3033
3034 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3035
3036         [ews-build] use lz4 compression for improving buildbot performance
3037         https://bugs.webkit.org/show_bug.cgi?id=196155
3038
3039         Reviewed by Lucas Forschler.
3040
3041         * BuildSlaveSupport/ews-build/master.cfg:
3042
3043 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3044
3045         Pull some API testing helper methods out of TestWKWebView
3046         https://bugs.webkit.org/show_bug.cgi?id=196212
3047
3048         Reviewed by Tim Horton.
3049
3050         Refactor some more API testing utility methods, so that they can be used in
3051         tests that do not use TestWKWebView.
3052
3053         * TestWebKitAPI/cocoa/TestWKWebView.h:
3054         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3055         (-[WKWebView loadTestPageNamed:]):
3056         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
3057         (-[WKWebView synchronouslyLoadHTMLString:]):
3058         (-[WKWebView synchronouslyLoadTestPageNamed:]):
3059         (-[TestWKWebView loadTestPageNamed:]): Deleted.
3060         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
3061         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
3062         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
3063
3064 2019-03-25  Jer Noble  <jer.noble@apple.com>
3065
3066         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3067         https://bugs.webkit.org/show_bug.cgi?id=196097
3068
3069         Reviewed by Eric Carlson.
3070
3071         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3072
3073         * DumpRenderTree/mac/DumpRenderTree.mm:
3074         (resetWebPreferencesToConsistentValues):
3075         * WebKitTestRunner/TestController.cpp:
3076         (WTR::TestController::resetPreferencesToConsistentValues):
3077
3078 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3079
3080         Pull IPadUserInterfaceSwizzler out into a separate header file
3081         https://bugs.webkit.org/show_bug.cgi?id=196193
3082
3083         Reviewed by Anders Carlsson.
3084
3085         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
3086         be used in other API tests.
3087
3088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3089         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3090         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
3091         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
3092         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
3093         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3094         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3095
3096 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3097
3098         Remove NavigatorContentUtils in WebCore/Modules
3099         https://bugs.webkit.org/show_bug.cgi?id=196070
3100
3101         Reviewed by Alex Christensen.
3102
3103         NavigatorContentUtils was to support the custom scheme spec [1].
3104         However, in WebKit side, no port has supported the feature in
3105         WebKit layer after EFL port was removed. So there has been the
3106         only IDL implementation of the NavigatorContentUtils in WebCore.
3107         So we don't need to keep the implementation in WebCore anymore.
3108
3109         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
3110
3111         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3112
3113 2019-03-24  Andy Estes  <aestes@apple.com>
3114
3115         [watchOS] Remove unused Proximity Networking code
3116         https://bugs.webkit.org/show_bug.cgi?id=196188
3117
3118         Reviewed by Tim Horton.
3119
3120         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3121         (TEST):
3122
3123 2019-03-23  Keith Miller  <keith_miller@apple.com>
3124
3125         Refactor clz/ctz and fix getLSBSet.
3126         https://bugs.webkit.org/show_bug.cgi?id=196162
3127
3128         Reviewed by Saam Barati.
3129
3130         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3131
3132         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3133         (TestWebKitAPI::TEST):
3134
3135 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3136
3137         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3138         https://bugs.webkit.org/show_bug.cgi?id=196143
3139
3140         Reviewed by Michael Catanzaro.
3141
3142         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3143         directories.
3144
3145         * Scripts/webkitpy/style/checkers/cpp.py:
3146         (check_identifier_name_in_declaration):
3147         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3148         (WebKitStyleTest.test_names):
3149
3150 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3151
3152         [Flatpak] Manifest expanding fails for qt WPE extension
3153         https://bugs.webkit.org/show_bug.cgi?id=196148
3154
3155         Reviewed by Alex Christensen.
3156
3157         * flatpak/flatpakutils.py:
3158         (expand_submodules_recurse): The last recurse manifest expand
3159         iteration might lead to a single module so take it into account
3160         and don't try to recurse further.
3161
3162 2019-03-22  Chris Dumez  <cdumez@apple.com>
3163
3164         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3165         https://bugs.webkit.org/show_bug.cgi?id=195348
3166         <rdar://problem/48622090>
3167
3168         Reviewed by Alex Christensen.
3169
3170         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3171         to NO when test.options().shouldIgnoreMetaViewport is false.
3172
3173         * WebKitTestRunner/ios/TestControllerIOS.mm:
3174         (WTR::TestController::platformConfigureViewForTest):
3175
3176 2019-03-22  Chris Dumez  <cdumez@apple.com>
3177
3178         Prewarmed processes should be usable with any website data store
3179         https://bugs.webkit.org/show_bug.cgi?id=196104
3180
3181         Reviewed by Alex Christensen.
3182
3183         Add API test coverage.
3184
3185         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3186         (runInitialWarmedProcessUsedTest):
3187         (TEST):
3188
3189 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3190
3191         Back out local changes to Alex's Subversion working directory
3192
3193         They were accidentally committed.
3194
3195         * Scripts/webkitpy/common/system/abstractexecutive.py:
3196         (AbstractExecutive.wait_newest):
3197         * Scripts/webkitpy/common/system/executive.py:
3198         (Executive.running_pids):
3199         * Scripts/webkitpy/common/system/executive_mock.py:
3200         (MockExecutive.running_pids):
3201         * Scripts/webkitpy/common/system/executive_unittest.py:
3202         (ExecutiveTest.serial_test_running_pids):
3203         * Scripts/webkitpy/port/darwin.py:
3204         (DarwinPort.check_for_leaks):
3205         * Scripts/webkitpy/port/leakdetector.py:
3206         (LeakDetector.check_for_leaks):
3207         - This was the hack attached to Bug 193772.
3208
3209         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3210         (+[WebKitTestRunnerEvent mouseLocation]):
3211         - This works around a crash on an internal build.
3212
3213 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3214
3215         Fix the build after r243354
3216         https://bugs.webkit.org/show_bug.cgi?id=196138
3217         <rdar://problem/49145951>
3218
3219         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3220         (TEST):
3221         * TestWebKitAPI/ios/UIKitSPI.h:
3222
3223 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3224
3225         Adopt UIWKDocumentContext
3226         https://bugs.webkit.org/show_bug.cgi?id=196040
3227         <rdar://problem/48642440>
3228
3229         Reviewed by Ryosuke Niwa.
3230
3231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3232         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3233         (makeRequest):
3234         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3235         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3236         (applyStyle):
3237         (TEST):
3238         Add tests for UIWKDocumentContext.
3239
3240         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3241         (TEST):
3242         (recursiveFindWKContentView): Deleted.
3243         * TestWebKitAPI/cocoa/TestWKWebView.h:
3244         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3245         (recursiveFindWKContentView):
3246         (-[TestWKWebView wkContentView]):
3247         * TestWebKitAPI/ios/UIKitSPI.h:
3248         Share the WKContentView finding code between tests.
3249
3250 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3251
3252         [iOS WK2] Turn on async overflow scrolling by default
3253         https://bugs.webkit.org/show_bug.cgi?id=196011
3254         rdar://problem/48453859
3255
3256         Reviewed by Antti Koivisto.
3257         
3258         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3259         since so many basic layout tests have different results when compositing is triggered for
3260         overflow.
3261         
3262         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3263
3264         * WebKitTestRunner/TestController.cpp:
3265         (WTR::TestController::resetPreferencesToConsistentValues):
3266
3267 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3268
3269         [ews-build] Retry API test in case of failures
3270         https://bugs.webkit.org/show_bug.cgi?id=196004
3271
3272         Reviewed by Lucas Forschler.
3273
3274         * BuildSlaveSupport/ews-build/steps.py:
3275         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3276         (CompileWebKitToT.doStepIf): Ditto.
3277         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3278         (ReRunAPITests): Re-run API tests.
3279         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3280         (RunAPITestsWithoutPatch): Run API tests without patch.
3281         (RunAPITestsWithoutPatch.doStepIf):
3282         (RunAPITestsWithoutPatch.hideStepIf):
3283         (RunAPITestsWithoutPatch.evaluateCommand):
3284         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3285         (AnalyzeAPITestsResults.start):
3286         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3287         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3288         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3289         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3290
3291 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3292
3293         [ews-build] Update queues configurations
3294         https://bugs.webkit.org/show_bug.cgi?id=196074
3295
3296         Reviewed by Dewei Zhu.
3297
3298         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3299         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3300
3301 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3302
3303         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3304         https://bugs.webkit.org/show_bug.cgi?id=195680
3305         <rdar://problem/48903534>
3306
3307         Unreviewed infrastructure fix.
3308
3309         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3310         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3311
3312 2019-03-21  Andy Estes  <aestes@apple.com>
3313
3314         [iOS] Apple Pay should be available in documents with no user agent scripts
3315         https://bugs.webkit.org/show_bug.cgi?id=196061
3316         <rdar://problem/48649391>
3317
3318         Reviewed by Brady Eidson.
3319
3320         Added API tests and related infrastructure.
3321
3322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3323         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3324         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3325         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3326         (TestWebKitAPI::TEST):
3327         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3328         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3329         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3330         * TestWebKitAPI/cocoa/TestProtocol.mm:
3331         (-[TestProtocol startLoading]):
3332         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3333         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3334         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3335         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3336
3337 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3338
3339         REGRESSSION (r243297): webkitpy tests broken
3340         https://bugs.webkit.org/show_bug.cgi?id=196108
3341
3342         Reviewed by Aakash Jain.
3343
3344         r243297 updated contributors.json, which broke a few unit tests.
3345
3346         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3347         (IRCCommandTest.test_whois):
3348         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3349
3350 2019-03-21  Chris Dumez  <cdumez@apple.com>
3351
3352         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3353         https://bugs.webkit.org/show_bug.cgi?id=196041
3354         <rdar://problem/49083230>
3355
3356         Reviewed by Alex Christensen.
3357
3358         Add API test coverage.
3359
3360         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3361         (TEST):
3362
3363 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3364
3365         Add SPI to inform applications of WKContentRuleList actions
3366         https://bugs.webkit.org/show_bug.cgi?id=195965
3367         <rdar://problem/42664365>
3368
3369         Reviewed by Geoff Garen.
3370
3371         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3372         (TestWebKitAPI::allActionsForResourceLoad):
3373         (TestWebKitAPI::testRequest):
3374         (TestWebKitAPI::TEST_F):
3375         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3376         (Notification::description):
3377         (Notification::operator== const):
3378         (toVector):
3379         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3380         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3381         (makeContentRuleList):
3382         (TEST):
3383         (makeWarnContentRuleList): Deleted.
3384
3385 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3386
3387         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3388         https://bugs.webkit.org/show_bug.cgi?id=196088
3389
3390         Reviewed by Brian Burg.
3391
3392         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3393         Support checks when only one platform is specified. Also deprecate macosx() and
3394         force the use of macos() instead.
3395
3396         * Scripts/webkitpy/style/checkers/cpp.py:
3397         (check_min_versions_of_wk_api_available):
3398         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3399         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3400
3401 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3402
3403         Update status inactive committers' status to 'contributor'.
3404
3405         * Scripts/webkitpy/common/config/contributors.json:
3406
3407 2019-03-21  Xan Lopez  <xan@igalia.com>
3408
3409         [JSC][x86] Drop support for x87 floating point
3410         https://bugs.webkit.org/show_bug.cgi?id=194853
3411
3412         Reviewed by Don Olmstead.
3413
3414         Force SSE2 on x86/32bit builds.
3415
3416         * Scripts/webkitdirs.pm:
3417         (generateBuildSystemFromCMakeProject):
3418
3419 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3420
3421         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3422         https://bugs.webkit.org/show_bug.cgi?id=196073
3423
3424         Reviewed by Michael Catanzaro.
3425
3426         Add test cases to check functions and constructors with no arguments but receiving user data.
3427
3428         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3429         (checkUserData):
3430         (testJSCFunction):
3431         (fooCreateWithUserData):
3432         (testJSCClass):
3433
3434 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3435
3436         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3437
3438         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3439
3440         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3441
3442 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3443
3444         [GTK][WPE] Add API to provide geolocation information
3445         https://bugs.webkit.org/show_bug.cgi?id=195940
3446
3447         Reviewed by Michael Catanzaro.
3448
3449         Add a new test to check the new API.
3450
3451         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3452         (testGeolocationManagerCurrentPosition):
3453         (testGeolocationManagerWatchPosition):
3454         (beforeAll):
3455         (afterAll):
3456         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3457         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3458         (beforeAll): Ditto.
3459         * TestWebKitAPI/glib/CMakeLists.txt:
3460
3461 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3462
3463         [GLib] Returning G_TYPE_OBJECT from a method does not work
3464         https://bugs.webkit.org/show_bug.cgi?id=195574
3465
3466         Reviewed by Michael Catanzaro.
3467
3468         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3469
3470         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3471         (getGFile):
3472         (getParent):
3473         (createGString):
3474         (getGString):
3475         (getGStringCopyWillRaise):
3476         (getGStringCopy):
3477         (getGStringStr):
3478         (getGStringLen):
3479         (freeGString):
3480         (testJSCClass):
3481
3482 2019-03-20  Saam Barati  <sbarati@apple.com>
3483
3484         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3485         https://bugs.webkit.org/show_bug.cgi?id=195721
3486
3487         Reviewed by Filip Pizlo.
3488
3489         * Scripts/run-javascriptcore-tests:
3490
3491 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3492
3493         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3494         https://bugs.webkit.org/show_bug.cgi?id=196049
3495
3496         Reviewed by Tim Horton.
3497
3498         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3499         overflow scrolling in general, so rename it.
3500
3501         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3502
3503 2019-03-20  Daniel Bates  <dabates@apple.com>
3504
3505         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3506         https://bugs.webkit.org/show_bug.cgi?id=196031
3507         <rdar://problem/49078172>
3508
3509         Reviewed by Tim Horton.
3510
3511         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3512         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3513         same code path used when the Done button is pressed to dismiss the <select> picker.
3514
3515         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3516         (TestWebKitAPI::TEST):
3517
3518 2019-03-20  Chris Dumez  <cdumez@apple.com>
3519
3520         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3521         https://bugs.webkit.org/show_bug.cgi?id=196029
3522         <rdar://problem/48954651>
3523
3524         Reviewed by Tim Horton.
3525
3526         Add API test coverage.
3527
3528         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3529
3530 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3531
3532         [ews-build] Improve failure summary string for ApplyPatch step
3533         https://bugs.webkit.org/show_bug.cgi?id=195995
3534
3535         Reviewed by Alexey Proskuryakov.
3536
3537         * BuildSlaveSupport/ews-build/steps.py:
3538         (ApplyPatch.getResultSummary): Override getResultSummary.
3539
3540 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3541
3542         AX: Implement support for new meter ARIA role
3543         https://bugs.webkit.org/show_bug.cgi?id=195966
3544
3545         Reviewed by Chris Fleizach.
3546
3547         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3548         to AXLevelIndicator.
3549
3550         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3551
3552 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3553
3554         [WebAuthN] Implement FIDO AppID extension
3555         https://bugs.webkit.org/show_bug.cgi?id=143491
3556         <rdar://problem/48298273>
3557
3558         Reviewed by Brent Fulgham.
3559
3560         Add a test that covers the new flag of convertToU2fSignCommand.
3561
3562         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3563         (TestWebKitAPI::TEST):
3564         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3565         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3566         (TestWebKitAPI::TEST):
3567
3568 2019-03-19  Keith Rollin  <krollin@apple.com>
3569
3570         Add support for more platforms to generate-xcfilelists
3571         https://bugs.webkit.org/show_bug.cgi?id=195977
3572
3573         Reviewed by Alexey Proskuryakov.
3574
3575         generate-xcfilelists incorrectly complains when involved with building
3576         WebKit for iphonesimulator:
3577
3578             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3579             …
3580             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3581
3582         Address this by teaching generate-xcfilelists about more platforms.
3583
3584         * Scripts/generate-xcfilelists:
3585
3586 2019-03-19  John Wilander  <wilander@apple.com>
3587
3588         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3589         https://bugs.webkit.org/show_bug.cgi?id=195923
3590         <rdar://problem/49001272>
3591
3592         Reviewed by Alex Christensen.
3593
3594         This patch does the following to the TestRunner:
3595         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3596         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3597         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3598
3599         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3600         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3601         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3602         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3603         * WebKitTestRunner/TestController.cpp:
3604         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3605         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3606         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3607         * WebKitTestRunner/TestController.h:
3608         * WebKitTestRunner/TestInvocation.cpp:
3609         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3610
3611 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3612
3613         [CMake] Support more clang and gcc sanitizers
3614         https://bugs.webkit.org/show_bug.cgi?id=195956
3615
3616         Reviewed by Michael Catanzaro.
3617
3618         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3619
3620 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3621
3622         [ews-build] Improve summary for PrintConfiguration step
3623         https://bugs.webkit.org/show_bug.cgi?id=195945
3624
3625         Reviewed by Lucas Forschler.
3626
3627         * BuildSlaveSupport/ews-build/steps.py:
3628         (PrintConfiguration.getResultSummary): Override getResultSummary.
3629
3630 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3631
3632         [ews-build] Improve summary for CheckOutSource step
3633         https://bugs.webkit.org/show_bug.cgi?id=195963
3634
3635         Reviewed by Lucas Forschler.
3636
3637         * BuildSlaveSupport/ews-build/steps.py:
3638         (CheckOutSource.getResultSummary):
3639
3640 2019-03-19  Daniel Bates  <dabates@apple.com>
3641
3642         [iOS] Focus not preserved when switching between tabs
3643         https://bugs.webkit.org/show_bug.cgi?id=195820
3644         <rdar://problem/43614450>
3645
3646         Reviewed by Brent Fulgham.
3647
3648         Add tests to ensure that we restore focus when resigning and becoming first responder.
3649
3650         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3651         (TestWebKitAPI::TEST):
3652
3653 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3654
3655         Make WTFLogChannelState and WTFLogLevel enum classes
3656         https://bugs.webkit.org/show_bug.cgi?id=195904
3657
3658         Reviewed by Eric Carlson.
3659
3660         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3661         (TestWebKitAPI::TEST_F):
3662
3663 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3664
3665         [GStreamer][EME] Backported mssdemux protection data crash fix
3666         https://bugs.webkit.org/show_bug.cgi?id=195918
3667
3668         Reviewed by Philippe Normand.
3669
3670         * gstreamer/jhbuild.modules:
3671         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3672
3673 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3674
3675         Unreviewed, rolling out r243132.
3676
3677         Broke GTK build
3678
3679         Reverted changeset:
3680
3681         "Make WTFLogChannelState and WTFLogLevel enum classes"
3682         https://bugs.webkit.org/show_bug.cgi?id=195904
3683         https://trac.webkit.org/changeset/243132
3684
3685 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3686
3687         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3688
3689         * Scripts/webkitdirs.pm:
3690         (builtDylibPathForName): Adjust the shared library name that's changed
3691         with the API version bump in r243073.
3692
3693 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3694
3695         Make WTFLogChannelState and WTFLogLevel enum classes
3696         https://bugs.webkit.org/show_bug.cgi?id=195904
3697
3698         Reviewed by Eric Carlson.
3699
3700         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3701         (TestWebKitAPI::TEST_F):
3702
3703 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3704
3705         Disable flaky test added in r2431100
3706         https://webkit.org/b/195785
3707
3708         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3709         (TestWebKitAPI::TEST):
3710         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3711
3712 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3713
3714         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3715         https://bugs.webkit.org/show_bug.cgi?id=195916
3716
3717         Reviewed by Tim Horton.
3718
3719         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3720         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3721
3722 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3723
3724         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3725
3726         * Scripts/webkitpy/common/config/contributors.json:
3727
3728 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3729
3730         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3731         https://bugs.webkit.org/show_bug.cgi?id=195785
3732
3733         Reviewed by Geoffrey Garen.
3734
3735         * TestWebKitAPI/TCPServer.cpp: Added.
3736         (TestWebKitAPI::TCPServer::TCPServer):
3737         (TestWebKitAPI::TCPServer::~TCPServer):
3738         (TestWebKitAPI::TCPServer::socketBindListen):
3739         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3740         * TestWebKitAPI/TCPServer.h: Added.
3741         (TestWebKitAPI::TCPServer::port const):
3742         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3743         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3744         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3745         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3746         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3747         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3748         (TestWebKitAPI::respondSlowly):
3749         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3750         (TestWebKitAPI::downloadAtRate):
3751         (TestWebKitAPI::TEST):
3752
3753 2019-03-18  Saam Barati  <sbarati@apple.com>
3754
3755         Add a plan file for JetStream 2
3756         https://bugs.webkit.org/show_bug.cgi?id=190734
3757
3758         Reviewed by Mark Lam.
3759
3760         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3761
3762 2019-03-18  Chris Dumez  <cdumez@apple.com>
3763
3764         Delay WebProcess launch until a load is triggered in a Web view
3765         https://bugs.webkit.org/show_bug.cgi?id=195758
3766         <rdar://problem/48126013>
3767
3768         Reviewed by Geoff Garen.
3769
3770         Add API test coverage. Also update some existing API tests to not expect
3771         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3772
3773         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3774         (TestWebKitAPI::TEST):
3775         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3776         (TestWebKitAPI::TEST):
3777         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3778         (TEST):
3779         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3780         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3781         (TEST):
3782         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3783         (TEST):
3784         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3785
3786 2019-03-18  Xan Lopez  <xan@igalia.com>
3787
3788         [CMake] Prevent potential warning when determining $architecture
3789         https://bugs.webkit.org/show_bug.cgi?id=195891
3790
3791         Reviewed by Michael Catanzaro.
3792
3793         It's possible for generateBuildSystemForCMakeProject to be called
3794         before determineArchitecture() is ever called. This will make the
3795         first eq check with $architecture to be bogus (and print a
3796         warning). Change that to an eq check with architecture(), which
3797         implicitly calls determineArchitecture() if needed, and change all
3798         the other similar cases in the method in the same way to prevent
3799         future bugs like this one.
3800
3801         * Scripts/webkitdirs.pm:
3802         (generateBuildSystemFromCMakeProject):
3803
3804 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3805
3806         [WPE] Tarballs generated with “make dist” cannot build documentation
3807         https://bugs.webkit.org/show_bug.cgi?id=195885
3808
3809         Reviewed by Carlos Garcia Campos.
3810
3811         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3812
3813 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3814
3815         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3816         https://bugs.webkit.org/show_bug.cgi?id=195883
3817
3818         Reviewed by Carlos Garcia Campos.
3819
3820         * gtkdoc/gtkdoc.py:
3821         (GTKDoc._run_command): When commands fail to run, include the full command line for
3822         the program invocation and the output it has generated on the standard error stream.
3823
3824 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3825
3826         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3827         https://bugs.webkit.org/show_bug.cgi?id=195786
3828
3829         Reviewed by Philippe Normand.
3830
3831         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3832         * wpe/jhbuild.modules: Ditto.
3833
3834 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3835
3836         [ews-build] Don't run clean builds on EWS builders
3837         https://bugs.webkit.org/show_bug.cgi?id=195851
3838
3839         Reviewed by Geoffrey Garen.
3840
3841         * BuildSlaveSupport/ews-build/factories.py:
3842
3843 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3844
3845         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3846         https://bugs.webkit.org/show_bug.cgi?id=195849
3847
3848         Reviewed by Chris Dumez.
3849
3850         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3851
3852         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3853         (runWebsiteDataStoreCustomPaths):
3854
3855 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3856
3857         webkitpy: Upload test results
3858         https://bugs.webkit.org/show_bug.cgi?id=195755
3859         <rdar://problem/48896182>
3860
3861         Reviewed by Aakash Jain.
3862
3863         Establish a new format for uploading results that is not tied to layout tests, apply
3864         that format to webkitpy tests.
3865
3866         * Scripts/webkitpy/common/checkout/scm/git.py:
3867         (Git.native_branch): Return what branch the current checkout is on.
3868         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3869         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3870         * Scripts/webkitpy/common/checkout/scm/svn.py:
3871         (SVN.native_branch): Ditto.
3872         * Scripts/webkitpy/common/system/platforminfo.py:
3873         (PlatformInfo.build_version): Return a build version for Mac.
3874         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3875         (MockPlatformInfo.__init__):
3876         (MockPlatformInfo.build_version):
3877         * Scripts/webkitpy/results: Added.
3878         * Scripts/webkitpy/results/__init__.py: Added.
3879         * Scripts/webkitpy/results/options.py: Added.
3880         (upload_options): OptParse list for upload options.
3881         * Scripts/webkitpy/results/upload.py: Added.
3882         (Upload): Class which enforces the upload format expected by the results server.
3883         (Upload.Expectations):
3884         (Upload.create_configuration):
3885         (Upload.create_commit):
3886         (Upload.create_details):
3887         (Upload.create_run_stats):
3888         (Upload.create_test_result):
3889         (Upload.__init__):
3890         (Upload.Encoder): Encode Upload object as json.
3891         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3892         * Scripts/webkitpy/results/upload_unittest.py: Added.
3893         * Scripts/webkitpy/test/main.py:
3894         (Tester._parse_args): Add upload arguments.
3895         (Tester._run_tests): Allow results to be uploaded.
3896         * Scripts/webkitpy/test/runner.py:
3897         (Runner.__init__): Record which tests were run, rather than just counting them.
3898         (Runner.handle):
3899         * Scripts/webkitpy/test/runner_unittest.py:
3900         (RunnerTest.test_run):
3901         * Scripts/webkitpy/thirdparty/__init__.py:
3902         (AutoinstallImportHook.find_module): Add requests auto-install.
3903         (AutoinstallImportHook._install_requests):
3904         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3905         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3906
3907 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3908
3909         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3910         https://bugs.webkit.org/show_bug.cgi?id=195810
3911
3912         Reviewed by Tim Horton.
3913
3914         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3915         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3916         ending certain layout tests.
3917
3918         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3919         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3920         (-[TestRunnerWKWebView dealloc]):
3921         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3922
3923         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3924         helper method when destroying the web view, and when resetting state between tests.
3925
3926         * WebKitTestRunner/ios/TestControllerIOS.mm:
3927         (WTR::TestController::platformResetStateToConsistentValues):
3928
3929         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3930
3931 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3932
3933         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3934         https://bugs.webkit.org/show_bug.cgi?id=190350
3935         <rdar://problem/45089503>
3936
3937         Reviewed by Geoffrey Garen.
3938
3939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3940         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3941         (TEST):
3942         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3943         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3944         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3945         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3946         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3947         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3948         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3949         (runTest):
3950         (createDirectories):
3951         (TEST):
3952         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3953         (TEST):
3954         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3955         (TEST):
3956
3957 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3958
3959         Add support to WebPage for getting the contents as an attributed string.
3960         https://bugs.webkit.org/show_bug.cgi?id=195636
3961         rdar://problem/45055697
3962
3963         Reviewed by Tim Horton.
3964
3965         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3966         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3967
3968 2019-03-15  Chris Dumez  <cdumez@apple.com>
3969
3970         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3971         https://bugs.webkit.org/show_bug.cgi?id=195747
3972
3973         Reviewed by Geoff Garen.
3974
3975         Add API test coverage.
3976
3977         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3978
3979 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3980
3981         Unreviewed, rolling out r242952.
3982
3983         Causing API failures on iOS Simulator
3984
3985         Reverted changeset:
3986
3987         "[PSON] Make sure the WebProcessCache is leverage when
3988         relaunching a process after termination"
3989         https://bugs.webkit.org/show_bug.cgi?id=195747
3990         https://trac.webkit.org/changeset/242952
3991
3992 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3993
3994         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3995         https://bugs.webkit.org/show_bug.cgi?id=195740
3996
3997         Reviewed by Ross Kirsling.
3998
3999         window.open doesn't work for WebKitBrowserWindow because it is not
4000         implemented yet.
4001
4002         1. Implemented createNewPage callback of WKPageUIClient.
4003         2. Changed MainWindow to take a BrowserWindow factory function
4004           instead of BrowserWindowType to be flexible to create
4005           BrowserWindow with extra settings.
4006         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
4007           because it is not relevant with MainWindow anymore.
4008
4009         * MiniBrowser/win/Common.cpp:
4010         (parseCommandLine):
4011         * MiniBrowser/win/Common.h:
4012         (CommandLineOptions::CommandLineOptions):
4013         * MiniBrowser/win/MainWindow.cpp:
4014         (MainWindow::MainWindow):
4015         (MainWindow::create):
4016         (MainWindow::init):
4017         (MainWindow::WndProc):
4018         * MiniBrowser/win/MainWindow.h:
4019         * MiniBrowser/win/PrintWebUIDelegate.cpp:
4020         (PrintWebUIDelegate::createWebViewWithRequest):
4021         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4022         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
4023         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
4024         (WebKitBrowserWindow::updateProxySettings):
4025         (WebKitBrowserWindow::createNewPage):
4026         * MiniBrowser/win/WebKitBrowserWindow.h:
4027         * MiniBrowser/win/WinMain.cpp:
4028         (wWinMain):
4029
4030 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
4031
4032         Make it possible to test scrolling tree layer manipulation more easily
4033         https://bugs.webkit.org/show_bug.cgi?id=195780
4034
4035         Reviewed by Tim Horton.
4036         
4037         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
4038         cuts off communication of scrolling tree scrolls back to the web process
4039         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
4040         allows tests to trigger scrolls which run the scrolling tree layer positioning
4041         logic, but never get another commit from the web process that might mask
4042         scrolling tree bugs.
4043         
4044         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
4045         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
4046         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
4047
4048         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4049         (WTR::UIScriptController::scrollUpdatesDisabled const):
4050         (WTR::UIScriptController::setScrollUpdatesDisabled):
4051         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4052         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4053         (WTR::UIScriptController::scrollUpdatesDisabled const):
4054         (WTR::UIScriptController::setScrollUpdatesDisabled):
4055         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4056         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4057         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4058         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
4059         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
4060         * WebKitTestRunner/ios/TestControllerIOS.mm:
4061         (WTR::TestController::platformResetStateToConsistentValues):
4062         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4063         (WTR::UIScriptController::scrollUpdatesDisabled const):
4064         (WTR::UIScriptController::setScrollUpdatesDisabled):
4065
4066 2019-03-14  Youenn Fablet  <youenn@apple.com>
4067
4068         Move IDB storage in private browsing mode to NetworkProcess
4069         https://bugs.webkit.org/show_bug.cgi?id=195602
4070
4071         Reviewed by Brady Eidson.
4072
4073         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
4074         (TEST):
4075
4076 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4077
4078         [ews-build] Make descriptionDone messages more readable
4079         https://bugs.webkit.org/show_bug.cgi?id=195760
4080
4081         Reviewed by Lucas Forschler.
4082
4083         * BuildSlaveSupport/ews-build/steps.py:
4084         * BuildSlaveSupport/ews-build/steps_unittest.py:
4085
4086 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4087
4088         [ews-build] Generate status-bubble hover-over messages
4089         https://bugs.webkit.org/show_bug.cgi?id=195680
4090
4091         Reviewed by Lucas Forschler.
4092
4093         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4094         (StatusBubble):
4095         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
4096         on hover-over.
4097         (StatusBubble._iso_time):
4098         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
4099         hover-over message.
4100         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
4101
4102 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4103
4104         [ews-app] Gracefully handle the case when state_string is None
4105         https://bugs.webkit.org/show_bug.cgi?id=195753
4106
4107         Reviewed by Lucas Forschler.
4108
4109         * BuildSlaveSupport/ews-app/ews/models/build.py:
4110         * BuildSlaveSupport/ews-app/ews/models/step.py:
4111
4112 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4113
4114         [ews-app] Status bubble display pending for currently running build step
4115         https://bugs.webkit.org/show_bug.cgi?id=195744
4116
4117         Reviewed by Lucas Forschler.
4118
4119         * BuildSlaveSupport/ews-build/events.py:
4120         (Events.stepStarted): If state_string is pending, replace it with step name.
4121
4122 2019-03-14  Chris Dumez  <cdumez@apple.com>
4123
4124         Add WebsitePolicy for the client to specify the device orientation & motion access policy
4125         https://bugs.webkit.org/show_bug.cgi?id=195750
4126
4127         Reviewed by Geoffrey Garen.
4128
4129         Add API test coverage.
4130
4131         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4132         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
4133         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4134         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4135
4136 2019-03-14  Chris Dumez  <cdumez@apple.com>
4137
4138         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
4139         https://bugs.webkit.org/show_bug.cgi?id=195747
4140
4141         Reviewed by Geoff Garen.
4142
4143         Add API test coverage.
4144
4145         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4146
4147 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4148
4149         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
4150         https://bugs.webkit.org/show_bug.cgi?id=195725
4151         <rdar://problem/48545062>
4152
4153         Reviewed by Tim Horton.
4154
4155         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
4156         handler is nil.
4157
4158         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4159         (TestWebKitAPI::TEST):
4160
4161 2019-03-13  Sam Weinig  <sam@webkit.org>
4162
4163         Add utility function to allow easy reverse range-based iteration of a container
4164         https://bugs.webkit.org/show_bug.cgi?id=195542
4165
4166         Reviewed by Antti Koivisto.
4167
4168         * TestWebKitAPI/CMakeLists.txt:
4169         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4170         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
4171         (TestWebKitAPI::TEST):
4172         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
4173
4174 2019-03-13  Chris Dumez  <cdumez@apple.com>
4175
4176         Use a ServiceWorker process per registrable domain
4177         https://bugs.webkit.org/show_bug.cgi?id=195649
4178
4179         Reviewed by Youenn Fablet.
4180
4181         Update API test coverage.
4182
4183         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4184
4185 2019-03-13  Chris Dumez  <cdumez@apple.com>
4186
4187         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
4188         https://bugs.webkit.org/show_bug.cgi?id=195684
4189         <rdar://problem/48294714>
4190
4191         Reviewed by Antti Koivisto.
4192
4193         Add API test coverage.
4194
4195         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4196
4197 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4198
4199         [ews-app] Remove unused patch view
4200         https://bugs.webkit.org/show_bug.cgi?id=195669
4201
4202         Reviewed by Lucas Forschler.
4203
4204         * BuildSlaveSupport/ews-app/ews/urls.py:
4205         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
4206
4207 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4208
4209         [ews-app] Use Buildbot result code variables
4210         https://bugs.webkit.org/show_bug.cgi?id=195668
4211
4212         Reviewed by Alexey Proskuryakov.
4213
4214         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
4215         (Buildbot): Added Buildbot result code variables.
4216         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4217         (StatusBubble._build_bubble): Used Buildbot result code variables.
4218
4219 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
4220
4221         [Flatpak] Expand submodule recursively
4222         https://bugs.webkit.org/show_bug.cgi?id=195672
4223
4224         Building WPE with flatpak was impossible without that as it was raising an exception.
4225         Also update wpebackend-fdo to match what is built in jhbuild
4226
4227         Reviewed by Philippe Normand.
4228
4229         * flatpak/flatpakutils.py:
4230         (expand_submodules_recurse):
4231         (expand_manifest):
4232         * flatpak/org.webkit.WPEModules.yaml:
4233
4234 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4235
4236         [ews-app] status bubble should be hidden for certain builds
4237         https://bugs.webkit.org/show_bug.cgi?id=194597
4238
4239         Reviewed by Dewei Zhu.
4240
4241         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4242         (StatusBubble._build_bubble):
4243         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
4244         because the patch didn't have relevant changes.
4245         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
4246         in production yet.
4247
4248 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
4249
4250         [Win] Fix a slew of simple clang-cl warnings.
4251         https://bugs.webkit.org/show_bug.cgi?id=195652
4252
4253         Reviewed by Don Olmstead.
4254
4255         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4256         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
4257
4258 2019-03-12  Justin Fan  <justin_fan@apple.com>
4259
4260         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
4261         https://bugs.webkit.org/show_bug.cgi?id=195518
4262         <rdar://problem/46322356>
4263
4264         Reviewed by Myles C. Maxfield.
4265
4266         * DumpRenderTree/DerivedSources-input.xcfilelist:
4267         * DumpRenderTree/DerivedSources-output.xcfilelist:
4268
4269 2019-03-12  Commit Queue  <commit-queue@webkit.org>
4270
4271         Unreviewed, rolling out r242825.
4272         https://bugs.webkit.org/show_bug.cgi?id=195648
4273
4274         "Broke webkitpy tests with my change to
4275         lldb_dump_class_layout.py" (Requested by rmorisset on
4276         #webkit).
4277
4278         Reverted changeset:
4279
4280         "Alter Tools/Scripts/dump-class-layout to be able to dump all
4281         classes with suspicious padding"
4282         https://bugs.webkit.org/show_bug.cgi?id=195573
4283         https://trac.webkit.org/changeset/242825
4284
4285 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4286
4287         [ews-build] Show status bubbles while the patch is waiting in queue
4288         https://bugs.webkit.org/show_bug.cgi?id=195618
4289
4290         Reviewed by Lucas Forschler.
4291
4292         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4293         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
4294         enabled in initial deployment.
4295         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
4296         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
4297         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
4298         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
4299         (StatusBubble._build_bubbles_for_patch):
4300
4301 2019-03-12  Robin Morisset  <rmorisset@apple.com>
4302
4303         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
4304         https://bugs.webkit.org/show_bug.cgi?id=195573
4305
4306         Reviewed by Simon Fraser.
4307
4308         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
4309
4310         * Scripts/dump-class-layout:
4311         (main):
4312         * lldb/lldb_dump_class_layout.py:
4313         (ClassLayout.__init__):
4314         (ClassLayout._compute_padding_recursive):
4315         (LLDBDebuggerInstance.dump_layout_for_classname):
4316         (LLDBDebuggerInstance):
4317         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
4318         (LLDBDebuggerInstance.layout_for_classname): Deleted.
4319
4320 2019-03-12  Chris Dumez  <cdumez@apple.com>
4321