Enable Pointer Events on watchOS
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-10  Antoine Quint  <graouts@apple.com>
2
3         Enable Pointer Events on watchOS
4         https://bugs.webkit.org/show_bug.cgi?id=196771
5         <rdar://problem/49040909>
6
7         Reviewed by Dean Jackson.
8
9         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
10
11 2019-04-10  Philippe Normand  <pnormand@igalia.com>
12
13         Unreviewed. Fix WPE accessibility tests after r244059.
14
15         We are failing to load the injected bundle due to undefined symbol
16         AccessibilityUIElement::replaceTextInRange().
17
18         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
19         (WTR::AccessibilityUIElement::replaceTextInRange):
20
21 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
22
23         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
24         https://bugs.webkit.org/show_bug.cgi?id=196727
25
26         Reviewed by Fujii Hironori.
27
28         * MiniBrowser/win/WebKitBrowserWindow.cpp:
29         (WebKitBrowserWindow::create):
30
31 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
32
33         [ews-build] Add unit tests for PrintConfiguration
34         https://bugs.webkit.org/show_bug.cgi?id=196752
35
36         Reviewed by Dewei Zhu.
37
38         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
39
40 2019-04-09  Keith Rollin  <krollin@apple.com>
41
42         Unreviewed build maintenance -- update .xcfilelists.
43
44         * DumpRenderTree/DerivedSources-input.xcfilelist:
45         * DumpRenderTree/DerivedSources-output.xcfilelist:
46
47 2019-04-09  Zalan Bujtas  <zalan@apple.com>
48
49         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
50         https://bugs.webkit.org/show_bug.cgi?id=196743
51         <rdar://problem/43897551>
52
53         Reviewed by Tim Horton.
54
55         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
56         (TEST):
57
58 2019-04-09  Youenn Fablet  <youenn@apple.com>
59
60         Close service worker database on network process suspension
61         https://bugs.webkit.org/show_bug.cgi?id=196623
62         <rdar://problem/48930869>
63
64         Reviewed by Alex Christensen.
65
66         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
67
68 2019-04-09  Daniel Bates  <dabates@apple.com>
69
70         [iPad] Should open popover when the spacebar is pressed
71         https://bugs.webkit.org/show_bug.cgi?id=196360
72         <rdar://problem/49389129>
73
74         Reviewed by Brent Fulgham.
75
76         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
77
78         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
79         (WTR::UIScriptController::isShowingPopover const): Added.
80         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
81         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
82         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
83         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
84         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
85         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
86         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
87         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
88         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
89         (WTR::UIScriptController::isShowingPopover const): Added.
90         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
91         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
92         * TestRunnerShared/UIScriptContext/UIScriptController.h:
93         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
94         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
95         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
96         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
97         (-[TestRunnerWKWebView _willPresentPopover]): Added.
98         (-[TestRunnerWKWebView _didDismissPopover]): Added.
99         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
100         (WTR::UIScriptController::isShowingPopover const): Added.
101         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
102         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
103
104 2019-04-09  Alex Christensen  <achristensen@webkit.org>
105
106         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
107         https://bugs.webkit.org/show_bug.cgi?id=196665
108         <rdar://45115669>
109
110         Reviewed by Geoff Garen.
111
112         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
113         (goBack):
114         (+[SimpleLookupContext sharedLookupContext]):
115         (-[SimpleLookupContext lookUpURL:completionHandler:]):
116         (TEST):
117         (+[Simple3LookupContext sharedLookupContext]): Deleted.
118         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
119
120 2019-04-09  John Wilander  <wilander@apple.com>
121
122         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
123         https://bugs.webkit.org/show_bug.cgi?id=196558
124         <rdar://problem/47650245>
125
126         Reviewed by Youenn Fablet.
127
128         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
129         (TestWebKitAPI::TEST):
130             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
131
132 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
133
134         [CMake] Apple builds should use ICU_INCLUDE_DIRS
135         https://bugs.webkit.org/show_bug.cgi?id=196720
136
137         Reviewed by Konstantin Tokarev.
138
139         * TestWebKitAPI/PlatformMac.cmake:
140
141 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
142
143         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
144         https://bugs.webkit.org/show_bug.cgi?id=196694
145         <rdar://problem/48388734>
146
147         Rubber-stamped by Aakash Jain.
148
149         * Scripts/webkitpy/port/image_diff.py:
150         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
151         * Scripts/webkitpy/port/server_process.py:
152         (ServerProcess.has_available_stdout): Check if stdout has data in it.
153         (ServerProcess._wait_for_data_and_update_buffers_using_select):
154         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
155         * Scripts/webkitpy/port/server_process_mock.py:
156         (MockServerProcess.has_available_stdout):
157         * Scripts/webkitpy/port/server_process_unittest.py:
158         (TestServerProcess.serial_test_basic):
159
160 2019-04-09  Jer Noble  <jer.noble@apple.com>
161
162         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
163         https://bugs.webkit.org/show_bug.cgi?id=196097
164
165         Reviewed by Eric Carlson.
166
167         Drive-by bug fix: allow tests to play audio without a user gesture by default.
168
169         * DumpRenderTree/mac/DumpRenderTree.mm:
170         (resetWebPreferencesToConsistentValues):
171         * WebKitTestRunner/TestController.cpp:
172         (WTR::TestController::resetPreferencesToConsistentValues):
173
174 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
175
176         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
177         https://bugs.webkit.org/show_bug.cgi?id=196690
178
179         Reviewed by Michael Catanzaro.
180
181         * QueueStatusServer/config/queues.py:
182         * Scripts/webkitpy/common/config/ews.json:
183         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
184         (test_ews_name):
185
186 2019-04-09  Chris Dumez  <cdumez@apple.com>
187
188         Loads using loadHTMLString() cause flashing when process-swapping
189         https://bugs.webkit.org/show_bug.cgi?id=196714
190         <rdar://problem/49637354>
191
192         Reviewed by Antti Koivisto.
193
194         Add API test coverage.
195
196         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
197
198 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
199
200         Unreviewed. Fix ATK accessibility tests after r244059.
201
202         We are failing to load the injected bundle due to undefined symbol
203         AccessibilityUIElement::replaceTextInRange().
204
205         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
206         (WTR::AccessibilityUIElement::replaceTextInRange):
207
208 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
209
210         AX: Support API: accessibilityReplaceRange:withText
211         https://bugs.webkit.org/show_bug.cgi?id=196636
212
213         Unreviewed build fix for Windows port.
214
215         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
216         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
217
218 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
219
220         [CMake][WinCairo] Separate copied headers into different directories
221         https://bugs.webkit.org/show_bug.cgi?id=196655
222
223         Reviewed by Michael Catanzaro.
224
225         * DumpRenderTree/CMakeLists.txt:
226         * MiniBrowser/win/CMakeLists.txt:
227         * TestWebKitAPI/CMakeLists.txt:
228         * TestWebKitAPI/PlatformWin.cmake:
229
230 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
231
232         Log stack-trace for run-webkit-tests when interrupted
233         https://bugs.webkit.org/show_bug.cgi?id=176393
234         <rdar://problem/34262310>
235
236         Reviewed by Lucas Forschler.
237
238         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
239         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
240         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
241         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
242         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
243         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
244         (main): Set handlers to log stack trace on interruption.
245
246 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
247
248         AX: Support API: accessibilityReplaceRange:withText
249         https://bugs.webkit.org/show_bug.cgi?id=196636
250
251         Unreviewed build fix for Windows port.
252
253         * DumpRenderTree/AccessibilityUIElement.cpp:
254         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
255
256 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
257
258         [ews-build] Scripts using Buildbot API have CORS error
259         https://bugs.webkit.org/show_bug.cgi?id=196709
260
261         Reviewed by Alexey Proskuryakov.
262
263         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
264
265 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
266
267         AX: Support API: accessibilityReplaceRange:withText
268         https://bugs.webkit.org/show_bug.cgi?id=196636
269
270         Reviewed by Daniel Bates.
271
272         * DumpRenderTree/AccessibilityUIElement.cpp:
273         (replaceTextInRangeCallback):
274         (AccessibilityUIElement::replaceTextInRange):
275         (AccessibilityUIElement::getJSClass):
276         * DumpRenderTree/AccessibilityUIElement.h:
277         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
278         (AccessibilityUIElement::replaceTextInRange):
279         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
280         (AccessibilityUIElement::replaceTextInRange):
281         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
282         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
283         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
284         (WTR::AccessibilityUIElement::replaceTextInRange):
285         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
286         (WTR::AccessibilityUIElement::replaceTextInRange):
287
288 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
289
290         [iOS] Do not allow starting selection drags when selection views are not visible
291         https://bugs.webkit.org/show_bug.cgi?id=196686
292         <rdar://problem/49399192>
293
294         Reviewed by Tim Horton.
295
296         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
297         also add some new API tests to cover scenarios where the web view is not first responder.
298
299         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
300         (TestWebKitAPI::TEST):
301         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
302
303         Add a switch to optionally make the web view first responder when starting the simulated drag.
304
305         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
306         (-[DragAndDropSimulator initWithWebView:]):
307         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
308
309 2019-04-08  Justin Fan  <justin_fan@apple.com>
310
311         [Web GPU] Fix Web GPU experimental feature on iOS
312         https://bugs.webkit.org/show_bug.cgi?id=196632
313
314         Reviewed by Myles C. Maxfield.
315
316         Properly make Web GPU available on iOS 11+.
317
318         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
319
320 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
321
322         [ews-build] Do not upload archive when Compile Fails
323         https://bugs.webkit.org/show_bug.cgi?id=196674
324
325         Reviewed by Alexey Proskuryakov.
326
327         * BuildSlaveSupport/ews-build/factories.py:
328         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
329         * BuildSlaveSupport/ews-build/steps.py:
330         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
331         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
332         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
333
334 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
335
336         Enable DFG on MIPS
337         https://bugs.webkit.org/show_bug.cgi?id=196689
338
339         Reviewed by Žan Doberšek.
340
341         Since the bytecode change, we enabled the baseline JIT on mips in
342         r240432, but DFG is still missing. With this change, all tests are
343         passing on a ci20 board.
344
345         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
346
347 2019-04-08  Philippe Normand  <pnormand@igalia.com>
348
349         [Flatpak] Second run update-webkitwpe-flatpak fails
350         https://bugs.webkit.org/show_bug.cgi?id=192702
351
352         Reviewed by Carlos Garcia Campos.
353
354         * flatpak/flatpakutils.py:
355         (FlatpakObject.flatpak): Fix typo.
356         (FlatpakPackage.install): When installing, also update to the configured remote commit.
357         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
358
359 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
360
361         [GTK][WPE] outlook.live.com displays old-fashioned UI
362         https://bugs.webkit.org/show_bug.cgi?id=196642
363
364         Reviewed by Carlos Garcia Campos.
365
366         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
367         (TestWebKitAPI::TEST): New Mac platform quirk test.
368
369 2019-04-07  Commit Queue  <commit-queue@webkit.org>
370
371         Unreviewed, rolling out r243956.
372         https://bugs.webkit.org/show_bug.cgi?id=196688
373
374         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
375         by aakashjain on #webkit).
376
377         Reverted changeset:
378
379         "Clicking "Go Back" from a safe browsing warning from an
380         iframe should navigate the WKWebView back to the previous
381         page"
382         https://bugs.webkit.org/show_bug.cgi?id=196665
383         https://trac.webkit.org/changeset/243956
384
385 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
386
387         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
388         https://bugs.webkit.org/show_bug.cgi?id=196669
389
390         Reviewed by Geoffrey Garen.
391
392         Added three new unit tests for WeakHashSet.
393
394         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
395         (WTF_WeakPtr.WeakHashSetConstObjects):
396         (WTF_WeakPtr.WeakHashSetComputesEmpty):
397         (WTF_WeakPtr.WeakHashSetComputeSize):
398
399 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
400
401         Hide next and previous form control buttons when WKWebView is editable
402         https://bugs.webkit.org/show_bug.cgi?id=196672
403         <rdar://problem/35625321>
404
405         Reviewed by Tim Horton.
406
407         Add a new API test.
408
409         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
410         (-[TestWKWebView lastTrailingBarButtonGroup]):
411         (TestWebKitAPI::TEST):
412         * TestWebKitAPI/ios/UIKitSPI.h:
413
414 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
415
416         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
417         https://bugs.webkit.org/show_bug.cgi?id=196077
418         <rdar://problem/49108202>
419
420         Reviewed by Chris Dumez.
421
422         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
423         on new web view.
424
425         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
426
427 2019-04-05  Saam Barati  <sbarati@apple.com>
428
429         Make compare-results understand MotionMark
430         https://bugs.webkit.org/show_bug.cgi?id=196666
431
432         Reviewed by Yusuke Suzuki.
433
434         * Scripts/compare-results:
435         (PLT5Results):
436         (detectMotionMark):
437         (detectMotionMark1_1):
438         (motionMarkResults):
439         (motionMark1_1Results):
440         (detectBenchmark):
441         (biggerIsBetter):
442         (main):
443
444 2019-04-05  Alex Christensen  <achristensen@webkit.org>
445
446         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
447         https://bugs.webkit.org/show_bug.cgi?id=196665
448         <rdar://45115669>
449
450         Reviewed by Geoff Garen.
451
452         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
453         (goBack):
454         (+[SimpleLookupContext sharedLookupContext]):
455         (-[SimpleLookupContext lookUpURL:completionHandler:]):
456         (TEST):
457         (+[Simple3LookupContext sharedLookupContext]): Deleted.
458         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
459
460 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
461
462         [ews-build] Add configuration and architecture for windows builders
463         https://bugs.webkit.org/show_bug.cgi?id=196660
464
465         Reviewed by Lucas Forschler.
466
467         * BuildSlaveSupport/ews-build/config.json:
468
469 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
470
471         webkitpy: Don't run subsequent rounds if interrupted
472         https://bugs.webkit.org/show_bug.cgi?id=196646
473
474         Reviewed by Aakash Jain.
475
476         * Scripts/webkitpy/layout_tests/controllers/manager.py:
477         (Manager.run): Bail out if interrupted.
478
479 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
480
481         Test sessionStorage in PSON private browsing mode
482         https://bugs.webkit.org/show_bug.cgi?id=196561
483
484         Reviewed by Alex Christensen.
485
486         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
487
488 2019-04-05  Commit Queue  <commit-queue@webkit.org>
489
490         Unreviewed, rolling out r243833.
491         https://bugs.webkit.org/show_bug.cgi?id=196645
492
493         This change breaks build of WPE and GTK ports (Requested by
494         annulen on #webkit).
495
496         Reverted changeset:
497
498         "[CMake][WTF] Mirror XCode header directories"
499         https://bugs.webkit.org/show_bug.cgi?id=191662
500         https://trac.webkit.org/changeset/243833
501
502 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
503
504         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
505         https://bugs.webkit.org/show_bug.cgi?id=196635
506
507         Reviewed by Antti Koivisto.
508         
509         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
510         for a test to enable async frame scrolling via:
511             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
512         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
513         
514         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
515
516         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
517         (WTR::InjectedBundle::beginTesting):
518         * WebKitTestRunner/TestController.cpp:
519         (WTR::TestController::resetPreferencesToConsistentValues):
520
521 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
522
523         Use a correct LC_RPATH when building with ASan
524         https://bugs.webkit.org/show_bug.cgi?id=196576
525
526         Reviewed by David Kilzer.
527
528         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
529         so that ../Frameworks is checked. This is simpler and more reliable than updating
530         each SPC service xcconfig.
531
532 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
533
534         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
535         https://bugs.webkit.org/show_bug.cgi?id=196629
536
537         Reviewed by Lucas Forschler.
538
539         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
540
541 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
542
543         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
544         https://bugs.webkit.org/show_bug.cgi?id=196618
545
546         Reviewed by Lucas Forschler.
547
548         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
549         (StatusBubble): Added QUEUE_TRIGGERS.
550         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
551         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
552         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
553         its parent(builder).
554
555 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
556
557         [ews-app] Status-bubble steps are sometimes displayed in reverse order
558         https://bugs.webkit.org/show_bug.cgi?id=196625
559
560         Reviewed by Lucas Forschler.
561
562         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
563         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
564
565 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
566
567         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
568         https://bugs.webkit.org/show_bug.cgi?id=196630
569
570         Reviewed by Wenson Hsieh.
571
572         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
573
574 2019-04-04  Youenn Fablet  <youenn@apple.com>
575
576         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
577         https://bugs.webkit.org/show_bug.cgi?id=196543
578
579         Reviewed by Alex Christensen.
580
581         * WebKitTestRunner/TestController.cpp:
582         (WTR::TestController::generatePageConfiguration):
583
584 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
585
586         [ews-app] Status bubble should not display skipped buildbot steps
587         https://bugs.webkit.org/show_bug.cgi?id=196584
588
589         Reviewed by Lucas Forschler.
590
591         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
592
593 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
594
595         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
596         https://bugs.webkit.org/show_bug.cgi?id=196620
597
598         Reviewed by Lucas Forschler.
599
600         * BuildSlaveSupport/ews-app/ews/config.py:
601
602 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
603
604         [Win] DumpRenderTreeWatchDog.py is not checked into source
605         https://bugs.webkit.org/show_bug.cgi?id=196567
606         <rdar://problem/49525901>
607
608         Reviewed by Lucas Forschler.
609
610         This script is used on Win EWS bots to terminate hanging DRT processes.
611
612         * EWSTools/dumprendertreewatchdog.py: Added.
613
614 2019-04-04  Chris Dumez  <cdumez@apple.com>
615
616         Unreviewed, roll out r243858 which made tests time out.
617
618         Disable new API tests on Windows instead.
619
620         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
621         (TestWebKitAPI::TEST):
622
623 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
624
625         [ATK] Cleanup WebPageAccessibilityObjectAtk
626         https://bugs.webkit.org/show_bug.cgi?id=196537
627
628         Reviewed by Michael Catanzaro.
629
630         Also consider files under atk directories as exceptions for GObject conventions.
631
632         * Scripts/webkitpy/style/checkers/cpp.py:
633         (check_identifier_name_in_declaration):
634
635 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
636
637         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
638         https://bugs.webkit.org/show_bug.cgi?id=196588
639         <rdar://problem/49365787>
640
641         Unreviewed build fix for Windows port.
642
643         error C3861: 'kill': identifier not found
644
645         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
646         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
647
648 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
649
650         [ews-build] Cancel build and similar operations should have authentication
651         https://bugs.webkit.org/show_bug.cgi?id=196520
652
653         Reviewed by Dewei Zhu.
654
655         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
656         environment variables.
657
658 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
659
660         [ews-build] Do not trigger queues which are not in production yet
661         https://bugs.webkit.org/show_bug.cgi?id=196581
662
663         Reviewed by Dewei Zhu.
664
665         * BuildSlaveSupport/ews-build/config.json:
666
667 2019-04-03  Chris Dumez  <cdumez@apple.com>
668
669         Unreviewed, fix typo in the name of API test added in r243848.
670
671         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
672         (TestWebKitAPI::TEST):
673
674 2019-04-03  Chris Dumez  <cdumez@apple.com>
675
676         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
677         https://bugs.webkit.org/show_bug.cgi?id=196588
678         <rdar://problem/49365787>
679
680         Reviewed by Ryosuke Niwa.
681
682         Add API test coverage.
683
684         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
685         (TestWebKitAPI::nullJavaScriptCallback):
686         (TestWebKitAPI::didCrashCheckFrames):
687         (TestWebKitAPI::TEST):
688
689 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
690
691         run-webkit-tests: Upload test results (new results database)
692         https://bugs.webkit.org/show_bug.cgi?id=196577
693         <rdar://problem/34841155>
694
695         Reviewed by Lucas Forschler.
696
697         * Scripts/webkitpy/layout_tests/controllers/manager.py:
698         (Manager.run): Upload results after each device shard, since the configuration will be
699         different for each device.
700         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
701         uploaded to a results database.
702         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
703         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
704
705 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
706
707         -apple-trailing-word is needed for browser detection
708         https://bugs.webkit.org/show_bug.cgi?id=196575
709
710         Unreviewed.
711
712         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
713
714 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
715
716         [CMake][WTF] Mirror XCode header directories
717         https://bugs.webkit.org/show_bug.cgi?id=191662
718
719         Reviewed by Konstantin Tokarev.
720
721         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
722         builds.
723
724         * CMakeLists.txt:
725         * DumpRenderTree/CMakeLists.txt:
726         * DumpRenderTree/PlatformWin.cmake:
727         * MiniBrowser/win/CMakeLists.txt:
728         * TestWebKitAPI/CMakeLists.txt:
729         * TestWebKitAPI/PlatformWin.cmake:
730         * WebKitTestRunner/PlatformGTK.cmake:
731         * WebKitTestRunner/PlatformWin.cmake:
732
733 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
734
735         [ews-app] Status bubble should not display certain infrastructure status messages
736         https://bugs.webkit.org/show_bug.cgi?id=196550
737
738         Reviewed by Lucas Forschler.
739
740         Do not display the steps which are un-needed for end-user. This information is still avaiable
741         if the user click on the bubble and look at the Buildbot build.
742         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
743         (StatusBubble._steps_messages):
744         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
745
746 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
747
748         [ews-build] Use https for sending data to ews-app
749         https://bugs.webkit.org/show_bug.cgi?id=196492
750
751         Reviewed by Lucas Forschler.
752
753         * BuildSlaveSupport/ews-build/events.py:
754
755 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
756
757         Remove support for -apple-trailing-word
758         https://bugs.webkit.org/show_bug.cgi?id=196525
759
760         Reviewed by Zalan Bujtas.
761
762         This CSS property is nonstandard and not used.
763
764         * Scripts/webkitperl/FeatureList.pm:
765         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
766
767 2019-04-03  Youenn Fablet  <youenn@apple.com>
768
769         Add a test for DOMCache on multiple browsing in case of private browsing
770         https://bugs.webkit.org/show_bug.cgi?id=196524
771
772         Reviewed by Alex Christensen.
773
774         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
775         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
776
777 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
778
779         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
780         https://bugs.webkit.org/show_bug.cgi?id=196540
781
782         Reviewed by Aakash Jain.
783
784         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
785
786 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
787
788         Add plumbing for a compatibility mode preference in WebKit
789         https://bugs.webkit.org/show_bug.cgi?id=196005
790
791         Reviewed by Tim Horton.
792
793         Add new API tests.
794
795         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
796         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
797
798 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
799
800         [WPE][GTK] Update libsrtp dependency package for Debian
801         https://bugs.webkit.org/show_bug.cgi?id=196528
802
803         Reviewed by Frédéric Wang.
804
805         * gtk/install-dependencies:
806         * wpe/install-dependencies:
807
808 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
809
810         [WK2] Add support for Window's beforeprint / afterprint events
811         https://bugs.webkit.org/show_bug.cgi?id=196478
812         <rdar://problem/49535124>
813
814         Unreviewed build fix for MSVC.
815
816         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
817
818         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
819
820         * WebKitTestRunner/TestController.cpp:
821         (WTR::printFrame): Use int and float literals.
822
823 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
824
825         [ews-build] Reassign bots to queues
826
827         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
828
829 2019-04-02  Chris Dumez  <cdumez@apple.com>
830
831         [WK2] Add support for Window's beforeprint / afterprint events
832         https://bugs.webkit.org/show_bug.cgi?id=196478
833
834         Reviewed by Alex Christensen.
835
836         Add minimal implementation for printFrame in WebKitTestRunner.
837
838         * WebKitTestRunner/TestController.cpp:
839         (WTR::printFrame):
840         (WTR::TestController::createOtherPage):
841         (WTR::TestController::createWebViewWithOptions):
842
843 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
844
845         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
846         https://bugs.webkit.org/show_bug.cgi?id=196491
847
848         Reviewed by Lucas Forschler.
849
850         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
851
852 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
853
854         [ews-build] Configure buildbot try credentials in environment variables
855         https://bugs.webkit.org/show_bug.cgi?id=196501
856
857         Reviewed by Lucas Forschler.
858
859         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
860         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
861         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
862
863 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
864
865         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
866         https://bugs.webkit.org/show_bug.cgi?id=196496
867         <rdar://problem/49521634>
868
869         Reviewed by Chris Dumez.
870
871         Add new API tests (see WebKit ChangeLog for more detail).
872
873         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
874         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
875         (TEST):
876
877 2019-04-02  David Kilzer  <ddkilzer@apple.com>
878
879         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
880         <https://webkit.org/b/196499>
881
882         Reviewed by Alexey Proskuryakov.
883
884         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
885         ENABLE_ADDRESS_SANITIZER.
886
887 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
888
889         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
890         https://bugs.webkit.org/show_bug.cgi?id=182757
891
892         Reviewed by Don Olmstead.
893
894         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
895         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
896
897 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
898
899         run-api-tests: Upload test results
900         https://bugs.webkit.org/show_bug.cgi?id=196323
901         <rdar://problem/49356714>
902
903         Reviewed by Lucas Forschler.
904
905         * Scripts/webkitpy/api_tests/manager.py:
906         (Manager):
907         (Manager.run): Upload results to a results database.
908         * Scripts/webkitpy/api_tests/run_api_tests.py:
909         (parse_args): Add upload arguments.
910         * Scripts/webkitpy/port/base.py:
911         (Port):
912         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
913         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
914         with commits from any other associated repositories.
915         * Scripts/webkitpy/port/device.py:
916         (Device):
917         (Device.build_version): Access build_versoin of underlying platform device.
918         * Scripts/webkitpy/port/ios_simulator_unittest.py:
919         (IOSSimulatorTest):
920         (IOSSimulatorTest.test_configuration_for_upload):
921         * Scripts/webkitpy/port/device_port.py:
922         (DevicePort):
923         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
924         the same as the machine uploading results.
925         * Scripts/webkitpy/port/mac.py:
926         (MacPort):
927         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
928         * Scripts/webkitpy/port/mac_unittest.py:
929         (MacTest):
930         (MacTest.test_configuration_for_upload):
931         * Scripts/webkitpy/xcode/simulated_device.py:
932         (SimulatedDeviceManager._create_device_with_runtime):
933         (SimulatedDevice.__init__): Create simulated device with a build_version.
934         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
935         (test_existing_simulator):
936
937 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
938
939         Remove extra newline characters (Follow-up fix to r243707)
940
941         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
942
943 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
944
945         [ews-app] Use API_KEY to accept results data
946         https://bugs.webkit.org/show_bug.cgi?id=196461
947
948         Reviewed by Dewei Zhu.
949
950         * BuildSlaveSupport/ews-app/ews/views/results.py:
951         (Results.post): Validate EWS_API_KEY before accepting any data.
952         * BuildSlaveSupport/ews-build/events.py:
953         (Events.sendData): Send EWS_API_KEY if available along with event data.
954
955 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
956
957         Unable to copy and paste a PDF from Notes into Mail compose body
958         https://bugs.webkit.org/show_bug.cgi?id=196442
959         <rdar://problem/48573098>
960
961         Reviewed by Tim Horton.
962
963         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
964         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
965         to be specified on the item providers.
966
967         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
968         (TestWebKitAPI::mapItemForTesting):
969         (TestWebKitAPI::contactItemForTesting):
970
971 2019-04-01  Tim Horton  <timothy_horton@apple.com>
972
973         Make UIWKDocumentContext rects per-character instead of per-word
974         https://bugs.webkit.org/show_bug.cgi?id=196459
975
976         Reviewed by Wenson Hsieh.
977
978         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
979         (TEST):
980         Adjust test results due to switching to per-character rects.
981
982 2019-04-01  Chris Dumez  <cdumez@apple.com>
983
984         UIProcess crash when a prewarmed process is terminated
985         https://bugs.webkit.org/show_bug.cgi?id=196451
986         <rdar://problem/49245471>
987
988         Reviewed by Geoffrey Garen.
989
990         Add API test coverage.
991
992         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
993         (TEST):
994
995 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
996
997         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
998         https://bugs.webkit.org/show_bug.cgi?id=196449
999
1000         Reviewed by Lucas Forschler.
1001
1002         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1003         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1004         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1005         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1006
1007 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1008
1009         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1010         https://bugs.webkit.org/show_bug.cgi?id=196444
1011
1012         Reviewed by Lucas Forschler.
1013
1014         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1015
1016 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1017
1018         Add SPI to canonicalize NSURLs with WTF::URL
1019         https://bugs.webkit.org/show_bug.cgi?id=196415
1020         <rdar://problem/44980271>
1021
1022         Reviewed by Darin Adler.
1023
1024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1025         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1026         (TestWebKitAPI::TEST):
1027
1028 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1029
1030         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1031         https://bugs.webkit.org/show_bug.cgi?id=196441
1032
1033         Reviewed by Carlos Garcia Campos.
1034
1035         Don't cache the wpe_view_backend object that might not exist yet at the
1036         time of EventSenderProxy constructor invocation, but instead retrieve
1037         that object whenever it's required for event dispatching. This should
1038         avoid crashes in this constructor now that it's invoked before any
1039         PlatformWindow has been set up (as changed in r243496).
1040
1041         * WebKitTestRunner/EventSenderProxy.h:
1042         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1043         (WTR::viewBackend):
1044         (WTR::EventSenderProxy::EventSenderProxy):
1045         (WTR::EventSenderProxy::mouseDown):
1046         (WTR::EventSenderProxy::mouseUp):
1047         (WTR::EventSenderProxy::mouseMoveTo):
1048         (WTR::EventSenderProxy::mouseScrollBy):
1049         (WTR::EventSenderProxy::keyDown):
1050         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1051
1052 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1053
1054         [Win][WebKit] MiniBrowser should support high DPI display
1055         https://bugs.webkit.org/show_bug.cgi?id=196391
1056
1057         Reviewed by Alex Christensen.
1058
1059         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1060         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1061         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1062         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1063
1064 2019-03-31  Sam Weinig  <weinig@apple.com>
1065
1066         Remove more i386 specific configurations
1067         https://bugs.webkit.org/show_bug.cgi?id=196430
1068
1069         Reviewed by Alexey Proskuryakov.
1070
1071         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1072         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1073
1074 2019-03-31  Andy Estes  <aestes@apple.com>
1075
1076         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1077         https://bugs.webkit.org/show_bug.cgi?id=196433
1078         <rdar://problem/49293305>
1079
1080         Reviewed by Tim Horton.
1081
1082         Enhanced API test coverage to include all navigation response policy decisions in both
1083         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1084
1085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1086         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1087         (TestWebKitAPI::TEST):
1088         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1089         (readFile):
1090         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1091         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1092         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1093         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1094         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1095         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1096         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1097         (-[QuickLookDelegate _downloadDidStart:]):
1098         (-[QuickLookDelegate _download:didReceiveResponse:]):
1099         (-[QuickLookDelegate _download:didReceiveData:]):
1100         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1101         (-[QuickLookDelegate _downloadDidFinish:]):
1102         (-[QuickLookDelegate _download:didFailWithError:]):
1103         (-[QuickLookDelegate _downloadDidCancel:]):
1104         (-[QuickLookDelegate verifyDownload]):
1105         (runTest):
1106         (runTestDecideBeforeLoading):
1107         (runTestDecideAfterLoading):
1108         (TEST):
1109         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1110         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1111         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1112         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1113         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1114         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1115         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1116         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1117         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1118         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1119         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1120         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1121         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1122         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1123
1124 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1125
1126         [CMake] add testdfg as target with build-jsc
1127         https://bugs.webkit.org/show_bug.cgi?id=196393
1128
1129         Reviewed by Saam Barati.
1130
1131         Added testdfg as one of the targets to build when
1132         using CMake.
1133
1134         * Scripts/build-jsc:
1135
1136 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1137
1138         Delete WebMetal implementation in favor of WebGPU
1139         https://bugs.webkit.org/show_bug.cgi?id=195418
1140
1141         Reviewed by Dean Jackson.
1142
1143         * DumpRenderTree/mac/DumpRenderTree.mm:
1144         (enableExperimentalFeatures):
1145         (resetWebPreferencesToConsistentValues):
1146         * Scripts/webkitperl/FeatureList.pm:
1147         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1149         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1150         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1151         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1152         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1153         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1154         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1155         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1156         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1157         (WTR::InjectedBundle::beginTesting):
1158         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1159         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1160         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1161
1162 2019-03-29  Chris Dumez  <cdumez@apple.com>
1163
1164         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1165         https://bugs.webkit.org/show_bug.cgi?id=196405
1166         <rdar://problem/49428130>
1167
1168         Reviewed by Wenson Hsieh.
1169
1170         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1171         the popover presentation methods to be no-ops. Use this in the new test added in
1172         r243523 so that we do not swizzle those methods for all tests. This is needed because
1173         those WatchOS tests rely on the popover getting presented and interactive.
1174
1175         * WebKitTestRunner/TestController.cpp:
1176         (WTR::updateTestOptionsFromTestHeader):
1177         * WebKitTestRunner/TestController.h:
1178         * WebKitTestRunner/TestOptions.h:
1179         (WTR::TestOptions::hasSameInitializationOptions const):
1180         * WebKitTestRunner/ios/TestControllerIOS.mm:
1181         (WTR::TestController::platformInitialize):
1182         (WTR::TestController::platformResetStateToConsistentValues):
1183
1184 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1185
1186         [Curl] Add Server Trust Evaluation Support.
1187         https://bugs.webkit.org/show_bug.cgi?id=191646
1188
1189         Reviewed by Fujii Hironori.
1190
1191         Implemented MiniBrowser UI for asking if user trusts the server.
1192
1193         * MiniBrowser/win/Common.cpp:
1194         (askServerTrustEvaluation):
1195         (replaceString):
1196         * MiniBrowser/win/Common.h:
1197         * MiniBrowser/win/MiniBrowserLib.rc:
1198         * MiniBrowser/win/MiniBrowserLibResource.h:
1199         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1200         (createPEMString):
1201         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1202         (WebKitBrowserWindow::canTrustServerCertificate):
1203         * MiniBrowser/win/WebKitBrowserWindow.h:
1204
1205 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1206
1207         Implement ResizeObserver.
1208         https://bugs.webkit.org/show_bug.cgi?id=157743
1209
1210         Reviewed by Simon Fraser.
1211
1212         Support resizeObserverEnabled webPreferences.
1213
1214         * DumpRenderTree/TestOptions.cpp:
1215         (TestOptions::TestOptions):
1216         * DumpRenderTree/TestOptions.h:
1217         * DumpRenderTree/mac/DumpRenderTree.mm:
1218         (setWebPreferencesForTestOptions):
1219         * DumpRenderTree/win/DumpRenderTree.cpp:
1220         (enableExperimentalFeatures):
1221         * Scripts/webkitperl/FeatureList.pm:
1222         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1223
1224 2019-03-28  John Wilander  <wilander@apple.com>
1225
1226         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1227         https://bugs.webkit.org/show_bug.cgi?id=196281
1228         <rdar://problem/48938748>
1229
1230         Reviewed by Alex Christensen.
1231
1232         This patch adds the function isStatisticsHasLocalStorage() to the
1233         TestRunner. With it, the page can query the WebsiteDataStore in the
1234         UI process to make sure that it sees LocalStorage.
1235
1236         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1237         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1238         (WTR::TestRunner::isStatisticsHasLocalStorage):
1239         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1240         * WebKitTestRunner/TestController.cpp:
1241         (WTR::TestController::isStatisticsHasLocalStorage):
1242         * WebKitTestRunner/TestController.h:
1243         * WebKitTestRunner/TestInvocation.cpp:
1244         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1245
1246 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1247
1248         API::Data::createWithoutCopying should do a null check before calling CFRelease
1249         https://bugs.webkit.org/show_bug.cgi?id=196276
1250         <rdar://problem/48059859>
1251
1252         Reviewed by Alex Christensen.
1253
1254         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1255
1256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1257         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1258         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1259         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1260         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1261         (TestWebKitAPI::TEST):
1262
1263 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1264
1265         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1266         https://bugs.webkit.org/show_bug.cgi?id=186276
1267
1268         Reviewed by Carlos Garcia Campos.
1269
1270         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1271         (webViewLoadChanged):
1272         (testWebResourceGetDataError):
1273         (testWebResourceGetDataEmpty):
1274         (beforeAll):
1275         (webViewloadChanged): Deleted.
1276
1277 2019-03-27  Andy Estes  <aestes@apple.com>
1278
1279         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1280         https://bugs.webkit.org/show_bug.cgi?id=196317
1281
1282         Reviewed by Dan Bernstein.
1283
1284         package-root copies built products into a staging directory using ditto(1), which does not
1285         follow symbolic links as it traverses a directory. Now that the files in
1286         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1287         itself, these become broken links when ditto'd into the staging directory.
1288
1289         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1290
1291         * Scripts/package-root:
1292
1293 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1294
1295         [ews-app] Update display text of Submit for ews analysis
1296         https://bugs.webkit.org/show_bug.cgi?id=196309
1297
1298         Reviewed by Dewei Zhu.
1299
1300         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1301
1302 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1303
1304         run-webkit-tests should check for leaks in WebKit processes
1305         <https://webkit.org/b/193772>
1306         <rdar://problem/46526680>
1307
1308         Reviewed by Ryosuke Niwa.
1309
1310         This works by doing the following:
1311         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1312           The list of child processes are returned one per line:
1313           process.name: pid
1314         - Run the "#LIST CHILD PROCESSES" command just before the
1315           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1316           processes on the ServerProcess object.
1317         - When the `--leaks` switch is handled, run check_for_leaks() on
1318           each child process after the main test harness.
1319
1320         * DumpRenderTree/mac/DumpRenderTree.mm:
1321         (handleControlCommand):
1322         - Use strncmp() instead of strcmp().
1323         - Add support for handling "#LIST CHILD PROCESSES" command.
1324
1325         * Scripts/webkitpy/port/base.py:
1326         (Port.check_for_leaks):
1327         * Scripts/webkitpy/port/darwin.py:
1328         (DarwinPort.check_for_leaks):
1329         - Rename redundant 'process_pid' argument to 'process_id'.
1330
1331         * Scripts/webkitpy/port/driver.py:
1332         (Driver.do_post_tests_work):
1333         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1334           longer the only command this sends to WebKitTestRunner.
1335         - If the `--leaks` switch is present, send the
1336           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1337           result using Port.set_webkit_processes().
1338         (Driver._parse_child_processes_output):
1339         - Add helper method to parse list of child process names and
1340           process IDs returned from WebKitTestRunner.
1341
1342         * Scripts/webkitpy/port/ios_device.py:
1343         (IOSDevicePort.check_for_leaks):
1344         - Rename redundant 'process_pid' argument to 'process_id'.
1345
1346         * Scripts/webkitpy/port/leakdetector.py:
1347         (LeakDetector._parse_leaks_output):
1348         - Return early if there is no leaks_output.
1349         (LeakDetector.check_for_leaks):
1350         - Rename redundant 'process_pid' argument to 'process_id'.
1351
1352         * Scripts/webkitpy/port/server_process.py:
1353         (ServerProcess.__init__):
1354         (ServerProcess.child_processes):
1355         (ServerProcess.set_child_processes):
1356         - Add instance variable to Port to store list of child process
1357           names and process IDs returned from WebKitTestRunner.
1358         (ServerProcess._start):
1359         - Clear self._child_processes.
1360         (ServerProcess.stop):
1361         - If self._child_processes is set, call
1362           self._port.check_for_leaks() for each child process.
1363
1364         * Scripts/webkitpy/port/server_process_unittest.py:
1365         (TrivialMockPort.check_for_leaks):
1366         - Rename redundant 'process_pid' argument to 'process_id'.
1367
1368         * Scripts/webkitpy/port/simulator_process.py:
1369         (SimulatorProcess.stop):
1370         - If self._child_processes is set, call
1371           self._port.check_for_leaks() for each child process.
1372
1373         * Scripts/webkitpy/port/watch_device.py:
1374         (WatchDevicePort.check_for_leaks):
1375         - Rename redundant 'process_pid' argument to 'process_id'.
1376
1377         * WebKitTestRunner/TestController.cpp:
1378         (WTR::TestController::dumpResponse):
1379         - Extract method from findAndDumpWorldLeaks() so that it may be
1380           reused by findAndDumpWebKitProcessIdentifiers().
1381         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1382         - Add method to output process name and process ID of both the
1383           WebContent and Networking processes.
1384         (WTR::TestController::findAndDumpWorldLeaks):
1385         - Fix missing newline in output when there were no abandoned
1386           documents.
1387         - Call dumpResponse() for extracted code.
1388         (WTR::TestController::handleControlCommand):
1389         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1390         - Use strncmp() instead of strcmp().
1391         - Call findAndDumpWebKitProcessIdentifiers() when
1392           "#LIST CHILD PROCESSES" command is sent.
1393         * WebKitTestRunner/TestController.h:
1394         (WTR::TestController::dumpResponse):
1395         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1396         - Declare methods.
1397
1398 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1399
1400         Unreviewed. Add GLib API test cases after r243434.
1401
1402         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1403         (testWebViewActiveURI):
1404         (serverCallback):
1405         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1406         (sendRequestCallback):
1407
1408 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1409
1410         Geolocation request not complete when watch request was started in a different web process
1411         https://bugs.webkit.org/show_bug.cgi?id=195996
1412
1413         Reviewed by Alex Christensen.
1414
1415         Add a test case.
1416
1417         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1418         (TestWebKitAPI::runJavaScriptAlert):
1419         (TestWebKitAPI::TEST):
1420
1421 2019-03-26  Keith Rollin  <krollin@apple.com>
1422
1423         Update the way generate-xcfilelists returns strings from functions
1424         https://bugs.webkit.org/show_bug.cgi?id=195975
1425         <rdar://problem/49040807>
1426
1427         Reviewed by Dean Jackson.
1428
1429         There are places where generate-xcfilelists executes assignments with
1430         statements like:
1431
1432             FOO=$(some_function)
1433
1434         where "some_function" return a string by echoing it. E.g.
1435
1436             some_function()
1437             {
1438                 echo "Hello, World"
1439             }
1440
1441         This is a common idiom, but it has a problem if "some_function" needs
1442         to call "exit" in an attempt to halt the entire script right then and
1443         there. Since "some_function" is called inside of $(), it's being
1444         executed in a sub-shell. Calling exit in that sub-shell simply exits
1445         that shell; it doesn't not exit the outer shell in which the main part
1446         of the script is still running. As such, the main script keeps
1447         executing when the intent was for the script to halt.
1448
1449         The solution to this is to use a different idiom for returning
1450         strings. The one we now is to pass in the name of the variable to
1451         receive the string result:
1452
1453             some_function()
1454             {
1455                 variable_name=$1
1456                 eval $variable_name ="Hello, World"
1457             }
1458
1459         The call site now looks like
1460
1461             some_function FOO
1462
1463         Because there's no invocation of a sub-shell, some_function can now
1464         call "exit" if it wants to, and the entire script will exit at that
1465         point.
1466
1467         * Scripts/generate-xcfilelists:
1468
1469 2019-03-26  Chris Dumez  <cdumez@apple.com>
1470
1471         Add basic layout test coverage for File Picker on iOS
1472         https://bugs.webkit.org/show_bug.cgi?id=196265
1473
1474         Reviewed by Wenson Hsieh.
1475
1476         Add layout test infrastructure to test the file picker on iOS.
1477
1478         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1479         (WTR::UIScriptController::dismissFilePicker):
1480         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1481         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1482         (WTR::UIScriptController::dismissFilePicker):
1483         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1484         * WebKitTestRunner/TestController.cpp:
1485         (WTR::TestController::createWebViewWithOptions):
1486         (WTR::updateTestOptionsFromTestHeader):
1487         * WebKitTestRunner/TestOptions.h:
1488         (WTR::TestOptions::hasSameInitializationOptions const):
1489         * WebKitTestRunner/ios/TestControllerIOS.mm:
1490         (overridePresentViewController):
1491         (WTR::TestController::platformInitialize):
1492         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1493         (WTR::UIScriptController::dismissFilePicker):
1494
1495 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1496
1497         Implement async paste method on UIWKInteractionViewProtocol
1498         https://bugs.webkit.org/show_bug.cgi?id=196267
1499         <rdar://problem/49236346>
1500
1501         Reviewed by Tim Horton.
1502
1503         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1504         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1505         are now a part of all iOS 12 internal SDKs.
1506
1507         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1508
1509         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1510         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1511
1512         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1513         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1514         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1515         * TestWebKitAPI/ios/UIKitSPI.h:
1516
1517 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1518
1519         [ews-build] Use PostgreSQL for ews.webkit.org database
1520         https://bugs.webkit.org/show_bug.cgi?id=196270
1521
1522         Reviewed by Lucas Forschler.
1523
1524         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1525
1526 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1527
1528         [ews] Reset simctl states on reboot
1529         https://bugs.webkit.org/show_bug.cgi?id=196260
1530
1531         Rubber-stamped by Aakash Jain.
1532
1533         * EWSTools/start-queue-mac.sh:
1534
1535 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1536
1537         [ews-build] Use PostgreSQL for ews-build database
1538         https://bugs.webkit.org/show_bug.cgi?id=196229
1539
1540         Reviewed by Lucas Forschler.
1541
1542         * BuildSlaveSupport/ews-build/master.cfg:
1543
1544 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1545
1546         [ews-build] Get master_hostname dynamically in master.cfg
1547         https://bugs.webkit.org/show_bug.cgi?id=196255
1548
1549         Reviewed by Lucas Forschler.
1550
1551         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1552         send events data in test mode.
1553
1554 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1555
1556         [ews-app] Set db_constraint to False for Foreign Keys
1557         https://bugs.webkit.org/show_bug.cgi?id=196252
1558
1559         Reviewed by Lucas Forschler.
1560
1561         * BuildSlaveSupport/ews-app/ews/models/build.py:
1562         * BuildSlaveSupport/ews-app/ews/models/step.py:
1563
1564 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1565
1566         [ews-build] is_test_mode_enabled should default to True
1567         https://bugs.webkit.org/show_bug.cgi?id=196248
1568
1569         Reviewed by Lucas Forschler.
1570
1571         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1572
1573 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1574
1575         [ews-app] Add webkitperl to ENABLED_QUEUES
1576         https://bugs.webkit.org/show_bug.cgi?id=196253
1577
1578         Reviewed by Lucas Forschler.
1579
1580         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1581
1582 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1583
1584         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1585         https://bugs.webkit.org/show_bug.cgi?id=196211
1586         rdar://problem/49110552
1587
1588         Reviewed by Tim Horton.
1589
1590         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1591         Make sure that EventSenderProxy always exists when running tests. We used to create
1592         it when resetting before the first test, which is a bit too late.
1593
1594         * WebKitTestRunner/TestController.h:
1595         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1596         (WTR::TestController::platformCreateWebView):
1597         (WTR::TestController::platformCreateOtherPage):
1598         (WTR::TestController::finishCreatingPlatformWebView):
1599         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1600         (WTR::PlatformWebView::PlatformWebView):
1601         Moved some code that made NSWindow use NSEvent during web view creation. We may
1602         need to move more if some other case us found, but this is enough for now.
1603
1604 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1605
1606         Unreviewed. Fix typo in GLib geolocation API after r243285.
1607
1608         gelocation -> geolocation.
1609
1610         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1611         (testGeolocationManagerWatchPosition):
1612
1613 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1614
1615         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1616         https://bugs.webkit.org/show_bug.cgi?id=196213
1617
1618         Reviewed by Geoff Garen.
1619
1620         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1621         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1622         (credentialWithIdentityAndKeychainPath):
1623         (-[ChallengeDelegate webView:didFinishNavigation:]):
1624         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1625         (TestWebKitAPI::TEST):
1626
1627 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1628
1629         Expected shouldn't assume its contained types are copyable
1630         https://bugs.webkit.org/show_bug.cgi?id=195986
1631
1632         Reviewed by JF Bastien.
1633
1634         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1635         (TestWebKitAPI::NonCopyable::operator== const):
1636         (TestWebKitAPI::NonCopyable::operator!= const):
1637         (TestWebKitAPI::TEST):
1638
1639 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1640
1641         Remove some now-unnecessary dynamic class lookup
1642         https://bugs.webkit.org/show_bug.cgi?id=196237
1643
1644         Reviewed by Simon Fraser.
1645
1646         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1647         (makeRequest):
1648         (TEST):
1649
1650 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1651
1652         Unreviewed, rolling out r243450.
1653
1654         AppleWin and WinCairo port builds get broken.
1655
1656         Reverted changeset:
1657
1658         "Add test for fix of #196095"
1659         https://bugs.webkit.org/show_bug.cgi?id=196097
1660         https://trac.webkit.org/changeset/243450
1661
1662 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1663
1664         Unreviewed, rolling out r243465.
1665         https://bugs.webkit.org/show_bug.cgi?id=196226
1666
1667         the test doesn't build (Requested by thorton on #webkit).
1668
1669         Reverted changeset:
1670
1671         "Do not terminate the NetworkProcess if a third party
1672         application sends a NSCredential with a SecIdentityRef"
1673         https://bugs.webkit.org/show_bug.cgi?id=196213
1674         https://trac.webkit.org/changeset/243465
1675
1676 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1677
1678         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1679         https://bugs.webkit.org/show_bug.cgi?id=196213
1680
1681         Reviewed by Geoff Garen.
1682
1683         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1684         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1685         (credentialWithIdentityAndKeychainPath):
1686         (-[ChallengeDelegate webView:didFinishNavigation:]):
1687         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1688         (TestWebKitAPI::TEST):
1689
1690 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1691
1692         [ews-build] Gracefully handle missing patch_id in events
1693         https://bugs.webkit.org/show_bug.cgi?id=196216
1694
1695         Reviewed by Lucas Forschler.
1696
1697         * BuildSlaveSupport/ews-build/events.py:
1698
1699 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1700
1701         [ews-build] use lz4 compression for improving buildbot performance
1702         https://bugs.webkit.org/show_bug.cgi?id=196155
1703
1704         Reviewed by Lucas Forschler.
1705
1706         * BuildSlaveSupport/ews-build/master.cfg:
1707
1708 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1709
1710         Pull some API testing helper methods out of TestWKWebView
1711         https://bugs.webkit.org/show_bug.cgi?id=196212
1712
1713         Reviewed by Tim Horton.
1714
1715         Refactor some more API testing utility methods, so that they can be used in
1716         tests that do not use TestWKWebView.
1717
1718         * TestWebKitAPI/cocoa/TestWKWebView.h:
1719         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1720         (-[WKWebView loadTestPageNamed:]):
1721         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1722         (-[WKWebView synchronouslyLoadHTMLString:]):
1723         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1724         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1725         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1726         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1727         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1728
1729 2019-03-25  Jer Noble  <jer.noble@apple.com>
1730
1731         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1732         https://bugs.webkit.org/show_bug.cgi?id=196097
1733
1734         Reviewed by Eric Carlson.
1735
1736         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1737
1738         * DumpRenderTree/mac/DumpRenderTree.mm:
1739         (resetWebPreferencesToConsistentValues):
1740         * WebKitTestRunner/TestController.cpp:
1741         (WTR::TestController::resetPreferencesToConsistentValues):
1742
1743 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1744
1745         Pull IPadUserInterfaceSwizzler out into a separate header file
1746         https://bugs.webkit.org/show_bug.cgi?id=196193
1747
1748         Reviewed by Anders Carlsson.
1749
1750         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1751         be used in other API tests.
1752
1753         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1754         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1755         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1756         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1757         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1758         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1759         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1760
1761 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1762
1763         Remove NavigatorContentUtils in WebCore/Modules
1764         https://bugs.webkit.org/show_bug.cgi?id=196070
1765
1766         Reviewed by Alex Christensen.
1767
1768         NavigatorContentUtils was to support the custom scheme spec [1].
1769         However, in WebKit side, no port has supported the feature in
1770         WebKit layer after EFL port was removed. So there has been the
1771         only IDL implementation of the NavigatorContentUtils in WebCore.
1772         So we don't need to keep the implementation in WebCore anymore.
1773
1774         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1775
1776         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1777
1778 2019-03-24  Andy Estes  <aestes@apple.com>
1779
1780         [watchOS] Remove unused Proximity Networking code
1781         https://bugs.webkit.org/show_bug.cgi?id=196188
1782
1783         Reviewed by Tim Horton.
1784
1785         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1786         (TEST):
1787
1788 2019-03-23  Keith Miller  <keith_miller@apple.com>
1789
1790         Refactor clz/ctz and fix getLSBSet.
1791         https://bugs.webkit.org/show_bug.cgi?id=196162
1792
1793         Reviewed by Saam Barati.
1794
1795         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1796
1797         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1798         (TestWebKitAPI::TEST):
1799
1800 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1801
1802         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1803         https://bugs.webkit.org/show_bug.cgi?id=196143
1804
1805         Reviewed by Michael Catanzaro.
1806
1807         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1808         directories.
1809
1810         * Scripts/webkitpy/style/checkers/cpp.py:
1811         (check_identifier_name_in_declaration):
1812         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1813         (WebKitStyleTest.test_names):
1814
1815 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1816
1817         [Flatpak] Manifest expanding fails for qt WPE extension
1818         https://bugs.webkit.org/show_bug.cgi?id=196148
1819
1820         Reviewed by Alex Christensen.
1821
1822         * flatpak/flatpakutils.py:
1823         (expand_submodules_recurse): The last recurse manifest expand
1824         iteration might lead to a single module so take it into account
1825         and don't try to recurse further.
1826
1827 2019-03-22  Chris Dumez  <cdumez@apple.com>
1828
1829         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1830         https://bugs.webkit.org/show_bug.cgi?id=195348
1831         <rdar://problem/48622090>
1832
1833         Reviewed by Alex Christensen.
1834
1835         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1836         to NO when test.options().shouldIgnoreMetaViewport is false.
1837
1838         * WebKitTestRunner/ios/TestControllerIOS.mm:
1839         (WTR::TestController::platformConfigureViewForTest):
1840
1841 2019-03-22  Chris Dumez  <cdumez@apple.com>
1842
1843         Prewarmed processes should be usable with any website data store
1844         https://bugs.webkit.org/show_bug.cgi?id=196104
1845
1846         Reviewed by Alex Christensen.
1847
1848         Add API test coverage.
1849
1850         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1851         (runInitialWarmedProcessUsedTest):
1852         (TEST):
1853
1854 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1855
1856         Back out local changes to Alex's Subversion working directory
1857
1858         They were accidentally committed.
1859
1860         * Scripts/webkitpy/common/system/abstractexecutive.py:
1861         (AbstractExecutive.wait_newest):
1862         * Scripts/webkitpy/common/system/executive.py:
1863         (Executive.running_pids):
1864         * Scripts/webkitpy/common/system/executive_mock.py:
1865         (MockExecutive.running_pids):
1866         * Scripts/webkitpy/common/system/executive_unittest.py:
1867         (ExecutiveTest.serial_test_running_pids):
1868         * Scripts/webkitpy/port/darwin.py:
1869         (DarwinPort.check_for_leaks):
1870         * Scripts/webkitpy/port/leakdetector.py:
1871         (LeakDetector.check_for_leaks):
1872         - This was the hack attached to Bug 193772.
1873
1874         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1875         (+[WebKitTestRunnerEvent mouseLocation]):
1876         - This works around a crash on an internal build.
1877
1878 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1879
1880         Fix the build after r243354
1881         https://bugs.webkit.org/show_bug.cgi?id=196138
1882         <rdar://problem/49145951>
1883
1884         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1885         (TEST):
1886         * TestWebKitAPI/ios/UIKitSPI.h:
1887
1888 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1889
1890         Adopt UIWKDocumentContext
1891         https://bugs.webkit.org/show_bug.cgi?id=196040
1892         <rdar://problem/48642440>
1893
1894         Reviewed by Ryosuke Niwa.
1895
1896         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1897         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1898         (makeRequest):
1899         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1900         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1901         (applyStyle):
1902         (TEST):
1903         Add tests for UIWKDocumentContext.
1904
1905         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1906         (TEST):
1907         (recursiveFindWKContentView): Deleted.
1908         * TestWebKitAPI/cocoa/TestWKWebView.h:
1909         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1910         (recursiveFindWKContentView):
1911         (-[TestWKWebView wkContentView]):
1912         * TestWebKitAPI/ios/UIKitSPI.h:
1913         Share the WKContentView finding code between tests.
1914
1915 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1916
1917         [iOS WK2] Turn on async overflow scrolling by default
1918         https://bugs.webkit.org/show_bug.cgi?id=196011
1919         rdar://problem/48453859
1920
1921         Reviewed by Antti Koivisto.
1922         
1923         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1924         since so many basic layout tests have different results when compositing is triggered for
1925         overflow.
1926         
1927         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1928
1929         * WebKitTestRunner/TestController.cpp:
1930         (WTR::TestController::resetPreferencesToConsistentValues):
1931
1932 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1933
1934         [ews-build] Retry API test in case of failures
1935         https://bugs.webkit.org/show_bug.cgi?id=196004
1936
1937         Reviewed by Lucas Forschler.
1938
1939         * BuildSlaveSupport/ews-build/steps.py:
1940         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1941         (CompileWebKitToT.doStepIf): Ditto.
1942         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1943         (ReRunAPITests): Re-run API tests.
1944         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1945         (RunAPITestsWithoutPatch): Run API tests without patch.
1946         (RunAPITestsWithoutPatch.doStepIf):
1947         (RunAPITestsWithoutPatch.hideStepIf):
1948         (RunAPITestsWithoutPatch.evaluateCommand):
1949         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1950         (AnalyzeAPITestsResults.start):
1951         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1952         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1953         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1954         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1955
1956 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1957
1958         [ews-build] Update queues configurations
1959         https://bugs.webkit.org/show_bug.cgi?id=196074
1960
1961         Reviewed by Dewei Zhu.
1962
1963         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1964         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1965
1966 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1967
1968         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1969         https://bugs.webkit.org/show_bug.cgi?id=195680
1970         <rdar://problem/48903534>
1971
1972         Unreviewed infrastructure fix.
1973
1974         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1975         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1976
1977 2019-03-21  Andy Estes  <aestes@apple.com>
1978
1979         [iOS] Apple Pay should be available in documents with no user agent scripts
1980         https://bugs.webkit.org/show_bug.cgi?id=196061
1981         <rdar://problem/48649391>
1982
1983         Reviewed by Brady Eidson.
1984
1985         Added API tests and related infrastructure.
1986
1987         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1988         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1989         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1990         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1991         (TestWebKitAPI::TEST):
1992         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1993         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1994         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1995         * TestWebKitAPI/cocoa/TestProtocol.mm:
1996         (-[TestProtocol startLoading]):
1997         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1998         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1999         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2000         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2001
2002 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2003
2004         REGRESSSION (r243297): webkitpy tests broken
2005         https://bugs.webkit.org/show_bug.cgi?id=196108
2006
2007         Reviewed by Aakash Jain.
2008
2009         r243297 updated contributors.json, which broke a few unit tests.
2010
2011         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2012         (IRCCommandTest.test_whois):
2013         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2014
2015 2019-03-21  Chris Dumez  <cdumez@apple.com>
2016
2017         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2018         https://bugs.webkit.org/show_bug.cgi?id=196041
2019         <rdar://problem/49083230>
2020
2021         Reviewed by Alex Christensen.
2022
2023         Add API test coverage.
2024
2025         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2026         (TEST):
2027
2028 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2029
2030         Add SPI to inform applications of WKContentRuleList actions
2031         https://bugs.webkit.org/show_bug.cgi?id=195965
2032         <rdar://problem/42664365>
2033
2034         Reviewed by Geoff Garen.
2035
2036         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2037         (TestWebKitAPI::allActionsForResourceLoad):
2038         (TestWebKitAPI::testRequest):
2039         (TestWebKitAPI::TEST_F):
2040         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2041         (Notification::description):
2042         (Notification::operator== const):
2043         (toVector):
2044         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2045         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2046         (makeContentRuleList):
2047         (TEST):
2048         (makeWarnContentRuleList): Deleted.
2049
2050 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2051
2052         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2053         https://bugs.webkit.org/show_bug.cgi?id=196088
2054
2055         Reviewed by Brian Burg.
2056
2057         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2058         Support checks when only one platform is specified. Also deprecate macosx() and
2059         force the use of macos() instead.
2060
2061         * Scripts/webkitpy/style/checkers/cpp.py:
2062         (check_min_versions_of_wk_api_available):
2063         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2064         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2065
2066 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2067
2068         Update status inactive committers' status to 'contributor'.
2069
2070         * Scripts/webkitpy/common/config/contributors.json:
2071
2072 2019-03-21  Xan Lopez  <xan@igalia.com>
2073
2074         [JSC][x86] Drop support for x87 floating point
2075         https://bugs.webkit.org/show_bug.cgi?id=194853
2076
2077         Reviewed by Don Olmstead.
2078
2079         Force SSE2 on x86/32bit builds.
2080
2081         * Scripts/webkitdirs.pm:
2082         (generateBuildSystemFromCMakeProject):
2083
2084 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2085
2086         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2087         https://bugs.webkit.org/show_bug.cgi?id=196073
2088
2089         Reviewed by Michael Catanzaro.
2090
2091         Add test cases to check functions and constructors with no arguments but receiving user data.
2092
2093         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2094         (checkUserData):
2095         (testJSCFunction):
2096         (fooCreateWithUserData):
2097         (testJSCClass):
2098
2099 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2100
2101         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2102
2103         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2104
2105         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2106
2107 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2108
2109         [GTK][WPE] Add API to provide geolocation information
2110         https://bugs.webkit.org/show_bug.cgi?id=195940
2111
2112         Reviewed by Michael Catanzaro.
2113
2114         Add a new test to check the new API.
2115
2116         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2117         (testGeolocationManagerCurrentPosition):
2118         (testGeolocationManagerWatchPosition):
2119         (beforeAll):
2120         (afterAll):
2121         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2122         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2123         (beforeAll): Ditto.
2124         * TestWebKitAPI/glib/CMakeLists.txt:
2125
2126 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2127
2128         [GLib] Returning G_TYPE_OBJECT from a method does not work
2129         https://bugs.webkit.org/show_bug.cgi?id=195574
2130
2131         Reviewed by Michael Catanzaro.
2132
2133         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2134
2135         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2136         (getGFile):
2137         (getParent):
2138         (createGString):
2139         (getGString):
2140         (getGStringCopyWillRaise):
2141         (getGStringCopy):
2142         (getGStringStr):
2143         (getGStringLen):
2144         (freeGString):
2145         (testJSCClass):
2146
2147 2019-03-20  Saam Barati  <sbarati@apple.com>
2148
2149         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2150         https://bugs.webkit.org/show_bug.cgi?id=195721
2151
2152         Reviewed by Filip Pizlo.
2153
2154         * Scripts/run-javascriptcore-tests:
2155
2156 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2157
2158         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2159         https://bugs.webkit.org/show_bug.cgi?id=196049
2160
2161         Reviewed by Tim Horton.
2162
2163         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2164         overflow scrolling in general, so rename it.
2165
2166         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2167
2168 2019-03-20  Daniel Bates  <dabates@apple.com>
2169
2170         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2171         https://bugs.webkit.org/show_bug.cgi?id=196031
2172         <rdar://problem/49078172>
2173
2174         Reviewed by Tim Horton.
2175
2176         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2177         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2178         same code path used when the Done button is pressed to dismiss the <select> picker.
2179
2180         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2181         (TestWebKitAPI::TEST):
2182
2183 2019-03-20  Chris Dumez  <cdumez@apple.com>
2184
2185         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2186         https://bugs.webkit.org/show_bug.cgi?id=196029
2187         <rdar://problem/48954651>
2188
2189         Reviewed by Tim Horton.
2190
2191         Add API test coverage.
2192
2193         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2194
2195 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2196
2197         [ews-build] Improve failure summary string for ApplyPatch step
2198         https://bugs.webkit.org/show_bug.cgi?id=195995
2199
2200         Reviewed by Alexey Proskuryakov.
2201
2202         * BuildSlaveSupport/ews-build/steps.py:
2203         (ApplyPatch.getResultSummary): Override getResultSummary.
2204
2205 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2206
2207         AX: Implement support for new meter ARIA role
2208         https://bugs.webkit.org/show_bug.cgi?id=195966
2209
2210         Reviewed by Chris Fleizach.
2211
2212         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2213         to AXLevelIndicator.
2214
2215         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2216
2217 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2218
2219         [WebAuthN] Implement FIDO AppID extension
2220         https://bugs.webkit.org/show_bug.cgi?id=143491
2221         <rdar://problem/48298273>
2222
2223         Reviewed by Brent Fulgham.
2224
2225         Add a test that covers the new flag of convertToU2fSignCommand.
2226
2227         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2228         (TestWebKitAPI::TEST):
2229         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2230         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2231         (TestWebKitAPI::TEST):
2232
2233 2019-03-19  Keith Rollin  <krollin@apple.com>
2234
2235         Add support for more platforms to generate-xcfilelists
2236         https://bugs.webkit.org/show_bug.cgi?id=195977
2237
2238         Reviewed by Alexey Proskuryakov.
2239
2240         generate-xcfilelists incorrectly complains when involved with building
2241         WebKit for iphonesimulator:
2242
2243             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2244             …
2245             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2246
2247         Address this by teaching generate-xcfilelists about more platforms.
2248
2249         * Scripts/generate-xcfilelists:
2250
2251 2019-03-19  John Wilander  <wilander@apple.com>
2252
2253         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2254         https://bugs.webkit.org/show_bug.cgi?id=195923
2255         <rdar://problem/49001272>
2256
2257         Reviewed by Alex Christensen.
2258
2259         This patch does the following to the TestRunner:
2260         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2261         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2262         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2263
2264         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2265         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2266         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2267         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2268         * WebKitTestRunner/TestController.cpp:
2269         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2270         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2271         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2272         * WebKitTestRunner/TestController.h:
2273         * WebKitTestRunner/TestInvocation.cpp:
2274         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2275
2276 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2277
2278         [CMake] Support more clang and gcc sanitizers
2279         https://bugs.webkit.org/show_bug.cgi?id=195956
2280
2281         Reviewed by Michael Catanzaro.
2282
2283         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2284
2285 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2286
2287         [ews-build] Improve summary for PrintConfiguration step
2288         https://bugs.webkit.org/show_bug.cgi?id=195945
2289
2290         Reviewed by Lucas Forschler.
2291
2292         * BuildSlaveSupport/ews-build/steps.py:
2293         (PrintConfiguration.getResultSummary): Override getResultSummary.
2294
2295 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2296
2297         [ews-build] Improve summary for CheckOutSource step
2298         https://bugs.webkit.org/show_bug.cgi?id=195963
2299
2300         Reviewed by Lucas Forschler.
2301
2302         * BuildSlaveSupport/ews-build/steps.py:
2303         (CheckOutSource.getResultSummary):
2304
2305 2019-03-19  Daniel Bates  <dabates@apple.com>
2306
2307         [iOS] Focus not preserved when switching between tabs
2308         https://bugs.webkit.org/show_bug.cgi?id=195820
2309         <rdar://problem/43614450>
2310
2311         Reviewed by Brent Fulgham.
2312
2313         Add tests to ensure that we restore focus when resigning and becoming first responder.
2314
2315         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2316         (TestWebKitAPI::TEST):
2317
2318 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2319
2320         Make WTFLogChannelState and WTFLogLevel enum classes
2321         https://bugs.webkit.org/show_bug.cgi?id=195904
2322
2323         Reviewed by Eric Carlson.
2324
2325         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2326         (TestWebKitAPI::TEST_F):
2327
2328 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2329
2330         [GStreamer][EME] Backported mssdemux protection data crash fix
2331         https://bugs.webkit.org/show_bug.cgi?id=195918
2332
2333         Reviewed by Philippe Normand.
2334
2335         * gstreamer/jhbuild.modules:
2336         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2337
2338 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2339
2340         Unreviewed, rolling out r243132.
2341
2342         Broke GTK build
2343
2344         Reverted changeset:
2345
2346         "Make WTFLogChannelState and WTFLogLevel enum classes"
2347         https://bugs.webkit.org/show_bug.cgi?id=195904
2348         https://trac.webkit.org/changeset/243132
2349
2350 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2351
2352         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2353
2354         * Scripts/webkitdirs.pm:
2355         (builtDylibPathForName): Adjust the shared library name that's changed
2356         with the API version bump in r243073.
2357
2358 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2359
2360         Make WTFLogChannelState and WTFLogLevel enum classes
2361         https://bugs.webkit.org/show_bug.cgi?id=195904
2362
2363         Reviewed by Eric Carlson.
2364
2365         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2366         (TestWebKitAPI::TEST_F):
2367
2368 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2369
2370         Disable flaky test added in r2431100
2371         https://webkit.org/b/195785
2372
2373         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2374         (TestWebKitAPI::TEST):
2375         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2376
2377 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2378
2379         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2380         https://bugs.webkit.org/show_bug.cgi?id=195916
2381
2382         Reviewed by Tim Horton.
2383
2384         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2385         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2386
2387 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2388
2389         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2390
2391         * Scripts/webkitpy/common/config/contributors.json:
2392
2393 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2394
2395         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2396         https://bugs.webkit.org/show_bug.cgi?id=195785
2397
2398         Reviewed by Geoffrey Garen.
2399
2400         * TestWebKitAPI/TCPServer.cpp: Added.
2401         (TestWebKitAPI::TCPServer::TCPServer):
2402         (TestWebKitAPI::TCPServer::~TCPServer):
2403         (TestWebKitAPI::TCPServer::socketBindListen):
2404         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2405         * TestWebKitAPI/TCPServer.h: Added.
2406         (TestWebKitAPI::TCPServer::port const):
2407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2408         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2409         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2410         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2411         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2412         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2413         (TestWebKitAPI::respondSlowly):
2414         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2415         (TestWebKitAPI::downloadAtRate):
2416         (TestWebKitAPI::TEST):
2417
2418 2019-03-18  Saam Barati  <sbarati@apple.com>
2419
2420         Add a plan file for JetStream 2
2421         https://bugs.webkit.org/show_bug.cgi?id=190734
2422
2423         Reviewed by Mark Lam.
2424
2425         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2426
2427 2019-03-18  Chris Dumez  <cdumez@apple.com>
2428
2429         Delay WebProcess launch until a load is triggered in a Web view
2430         https://bugs.webkit.org/show_bug.cgi?id=195758
2431         <rdar://problem/48126013>
2432
2433         Reviewed by Geoff Garen.
2434
2435         Add API test coverage. Also update some existing API tests to not expect
2436         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2437
2438         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2439         (TestWebKitAPI::TEST):
2440         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2441         (TestWebKitAPI::TEST):
2442         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2443         (TEST):
2444         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2445         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2446         (TEST):
2447         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2448         (TEST):
2449         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2450
2451 2019-03-18  Xan Lopez  <xan@igalia.com>
2452
2453         [CMake] Prevent potential warning when determining $architecture
2454         https://bugs.webkit.org/show_bug.cgi?id=195891
2455
2456         Reviewed by Michael Catanzaro.
2457
2458         It's possible for generateBuildSystemForCMakeProject to be called
2459         before determineArchitecture() is ever called. This will make the
2460         first eq check with $architecture to be bogus (and print a
2461         warning). Change that to an eq check with architecture(), which
2462         implicitly calls determineArchitecture() if needed, and change all
2463         the other similar cases in the method in the same way to prevent
2464         future bugs like this one.
2465
2466         * Scripts/webkitdirs.pm:
2467         (generateBuildSystemFromCMakeProject):
2468
2469 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2470
2471         [WPE] Tarballs generated with “make dist” cannot build documentation
2472         https://bugs.webkit.org/show_bug.cgi?id=195885
2473
2474         Reviewed by Carlos Garcia Campos.
2475
2476         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2477
2478 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2479
2480         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2481         https://bugs.webkit.org/show_bug.cgi?id=195883
2482
2483         Reviewed by Carlos Garcia Campos.
2484
2485         * gtkdoc/gtkdoc.py:
2486         (GTKDoc._run_command): When commands fail to run, include the full command line for
2487         the program invocation and the output it has generated on the standard error stream.
2488
2489 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2490
2491         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2492         https://bugs.webkit.org/show_bug.cgi?id=195786
2493
2494         Reviewed by Philippe Normand.
2495
2496         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2497         * wpe/jhbuild.modules: Ditto.
2498
2499 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2500
2501         [ews-build] Don't run clean builds on EWS builders
2502         https://bugs.webkit.org/show_bug.cgi?id=195851
2503
2504         Reviewed by Geoffrey Garen.
2505
2506         * BuildSlaveSupport/ews-build/factories.py:
2507
2508 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2509
2510         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2511         https://bugs.webkit.org/show_bug.cgi?id=195849
2512
2513         Reviewed by Chris Dumez.
2514
2515         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2516
2517         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2518         (runWebsiteDataStoreCustomPaths):
2519
2520 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2521
2522         webkitpy: Upload test results
2523         https://bugs.webkit.org/show_bug.cgi?id=195755
2524         <rdar://problem/48896182>
2525
2526         Reviewed by Aakash Jain.
2527
2528         Establish a new format for uploading results that is not tied to layout tests, apply
2529         that format to webkitpy tests.
2530
2531         * Scripts/webkitpy/common/checkout/scm/git.py:
2532         (Git.native_branch): Return what branch the current checkout is on.
2533         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2534         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2535         * Scripts/webkitpy/common/checkout/scm/svn.py:
2536         (SVN.native_branch): Ditto.
2537         * Scripts/webkitpy/common/system/platforminfo.py:
2538         (PlatformInfo.build_version): Return a build version for Mac.
2539         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2540         (MockPlatformInfo.__init__):
2541         (MockPlatformInfo.build_version):
2542         * Scripts/webkitpy/results: Added.
2543         * Scripts/webkitpy/results/__init__.py: Added.
2544         * Scripts/webkitpy/results/options.py: Added.
2545         (upload_options): OptParse list for upload options.
2546         * Scripts/webkitpy/results/upload.py: Added.
2547         (Upload): Class which enforces the upload format expected by the results server.
2548         (Upload.Expectations):
2549         (Upload.create_configuration):
2550         (Upload.create_commit):
2551         (Upload.create_details):
2552         (Upload.create_run_stats):
2553         (Upload.create_test_result):
2554         (Upload.__init__):
2555         (Upload.Encoder): Encode Upload object as json.
2556         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2557         * Scripts/webkitpy/results/upload_unittest.py: Added.
2558         * Scripts/webkitpy/test/main.py:
2559         (Tester._parse_args): Add upload arguments.
2560         (Tester._run_tests): Allow results to be uploaded.
2561         * Scripts/webkitpy/test/runner.py:
2562         (Runner.__init__): Record which tests were run, rather than just counting them.
2563         (Runner.handle):
2564         * Scripts/webkitpy/test/runner_unittest.py:
2565         (RunnerTest.test_run):
2566         * Scripts/webkitpy/thirdparty/__init__.py:
2567         (AutoinstallImportHook.find_module): Add requests auto-install.
2568         (AutoinstallImportHook._install_requests):
2569         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2570         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2571
2572 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2573
2574         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2575         https://bugs.webkit.org/show_bug.cgi?id=195810
2576
2577         Reviewed by Tim Horton.
2578
2579         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2580         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2581         ending certain layout tests.
2582
2583         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2584         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2585         (-[TestRunnerWKWebView dealloc]):
2586         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2587
2588         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2589         helper method when destroying the web view, and when resetting state between tests.
2590
2591         * WebKitTestRunner/ios/TestControllerIOS.mm:
2592         (WTR::TestController::platformResetStateToConsistentValues):
2593
2594         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2595
2596 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2597
2598         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2599         https://bugs.webkit.org/show_bug.cgi?id=190350
2600         <rdar://problem/45089503>
2601
2602         Reviewed by Geoffrey Garen.
2603
2604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2605         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2606         (TEST):
2607         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2608         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2609         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2610         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2611         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2612         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2613         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2614         (runTest):
2615         (createDirectories):
2616         (TEST):
2617         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2618         (TEST):
2619         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2620         (TEST):
2621
2622 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2623
2624         Add support to WebPage for getting the contents as an attributed string.
2625         https://bugs.webkit.org/show_bug.cgi?id=195636
2626         rdar://problem/45055697
2627
2628         Reviewed by Tim Horton.
2629
2630         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2631         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2632
2633 2019-03-15  Chris Dumez  <cdumez@apple.com>
2634
2635         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2636         https://bugs.webkit.org/show_bug.cgi?id=195747
2637
2638         Reviewed by Geoff Garen.
2639
2640         Add API test coverage.
2641
2642         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2643
2644 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2645
2646         Unreviewed, rolling out r242952.
2647
2648         Causing API failures on iOS Simulator
2649
2650         Reverted changeset:
2651
2652         "[PSON] Make sure the WebProcessCache is leverage when
2653         relaunching a process after termination"
2654         https://bugs.webkit.org/show_bug.cgi?id=195747
2655         https://trac.webkit.org/changeset/242952
2656
2657 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2658
2659         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2660         https://bugs.webkit.org/show_bug.cgi?id=195740
2661
2662         Reviewed by Ross Kirsling.
2663
2664         window.open doesn't work for WebKitBrowserWindow because it is not
2665         implemented yet.
2666
2667         1. Implemented createNewPage callback of WKPageUIClient.
2668         2. Changed MainWindow to take a BrowserWindow factory function
2669           instead of BrowserWindowType to be flexible to create
2670           BrowserWindow with extra settings.
2671         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2672           because it is not relevant with MainWindow anymore.
2673
2674         * MiniBrowser/win/Common.cpp:
2675         (parseCommandLine):
2676         * MiniBrowser/win/Common.h:
2677         (CommandLineOptions::CommandLineOptions):
2678         * MiniBrowser/win/MainWindow.cpp:
2679         (MainWindow::MainWindow):
2680         (MainWindow::create):
2681         (MainWindow::init):
2682         (MainWindow::WndProc):
2683         * MiniBrowser/win/MainWindow.h:
2684         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2685         (PrintWebUIDelegate::createWebViewWithRequest):
2686         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2687         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2688         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2689         (WebKitBrowserWindow::updateProxySettings):
2690         (WebKitBrowserWindow::createNewPage):
2691         * MiniBrowser/win/WebKitBrowserWindow.h:
2692         * MiniBrowser/win/WinMain.cpp:
2693         (wWinMain):
2694
2695 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2696
2697         Make it possible to test scrolling tree layer manipulation more easily
2698         https://bugs.webkit.org/show_bug.cgi?id=195780
2699
2700         Reviewed by Tim Horton.
2701         
2702         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2703         cuts off communication of scrolling tree scrolls back to the web process
2704         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2705         allows tests to trigger scrolls which run the scrolling tree layer positioning
2706         logic, but never get another commit from the web process that might mask
2707         scrolling tree bugs.
2708         
2709         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2710         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2711         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2712
2713         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2714         (WTR::UIScriptController::scrollUpdatesDisabled const):
2715         (WTR::UIScriptController::setScrollUpdatesDisabled):
2716         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2717         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2718         (WTR::UIScriptController::scrollUpdatesDisabled const):
2719         (WTR::UIScriptController::setScrollUpdatesDisabled):
2720         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2721         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2722         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2723         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2724         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2725         * WebKitTestRunner/ios/TestControllerIOS.mm:
2726         (WTR::TestController::platformResetStateToConsistentValues):
2727         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2728         (WTR::UIScriptController::scrollUpdatesDisabled const):
2729         (WTR::UIScriptController::setScrollUpdatesDisabled):
2730
2731 2019-03-14  Youenn Fablet  <youenn@apple.com>
2732
2733         Move IDB storage in private browsing mode to NetworkProcess
2734         https://bugs.webkit.org/show_bug.cgi?id=195602
2735
2736         Reviewed by Brady Eidson.
2737
2738         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2739         (TEST):
2740
2741 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2742
2743         [ews-build] Make descriptionDone messages more readable
2744         https://bugs.webkit.org/show_bug.cgi?id=195760
2745
2746         Reviewed by Lucas Forschler.
2747
2748         * BuildSlaveSupport/ews-build/steps.py:
2749         * BuildSlaveSupport/ews-build/steps_unittest.py:
2750
2751 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2752
2753         [ews-build] Generate status-bubble hover-over messages
2754         https://bugs.webkit.org/show_bug.cgi?id=195680
2755
2756         Reviewed by Lucas Forschler.
2757
2758         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2759         (StatusBubble):
2760         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2761         on hover-over.
2762         (StatusBubble._iso_time):
2763         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2764         hover-over message.
2765         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2766
2767 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2768
2769         [ews-app] Gracefully handle the case when state_string is None
2770         https://bugs.webkit.org/show_bug.cgi?id=195753
2771
2772         Reviewed by Lucas Forschler.
2773
2774         * BuildSlaveSupport/ews-app/ews/models/build.py:
2775         * BuildSlaveSupport/ews-app/ews/models/step.py:
2776
2777 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2778
2779         [ews-app] Status bubble display pending for currently running build step
2780         https://bugs.webkit.org/show_bug.cgi?id=195744
2781
2782         Reviewed by Lucas Forschler.
2783
2784         * BuildSlaveSupport/ews-build/events.py:
2785         (Events.stepStarted): If state_string is pending, replace it with step name.
2786
2787 2019-03-14  Chris Dumez  <cdumez@apple.com>
2788
2789         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2790         https://bugs.webkit.org/show_bug.cgi?id=195750
2791
2792         Reviewed by Geoffrey Garen.
2793
2794         Add API test coverage.
2795
2796         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2797         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2798         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2799         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2800
2801 2019-03-14  Chris Dumez  <cdumez@apple.com>
2802
2803         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2804         https://bugs.webkit.org/show_bug.cgi?id=195747
2805
2806         Reviewed by Geoff Garen.
2807
2808         Add API test coverage.
2809
2810         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2811
2812 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2813
2814         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2815         https://bugs.webkit.org/show_bug.cgi?id=195725
2816         <rdar://problem/48545062>
2817
2818         Reviewed by Tim Horton.
2819
2820         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2821         handler is nil.
2822
2823         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2824         (TestWebKitAPI::TEST):
2825
2826 2019-03-13  Sam Weinig  <sam@webkit.org>
2827
2828         Add utility function to allow easy reverse range-based iteration of a container
2829         https://bugs.webkit.org/show_bug.cgi?id=195542
2830
2831         Reviewed by Antti Koivisto.
2832
2833         * TestWebKitAPI/CMakeLists.txt:
2834         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2835         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2836         (TestWebKitAPI::TEST):
2837         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2838
2839 2019-03-13  Chris Dumez  <cdumez@apple.com>
2840
2841         Use a ServiceWorker process per registrable domain
2842         https://bugs.webkit.org/show_bug.cgi?id=195649
2843
2844         Reviewed by Youenn Fablet.
2845
2846         Update API test coverage.
2847
2848         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2849
2850 2019-03-13  Chris Dumez  <cdumez@apple.com>
2851
2852         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2853         https://bugs.webkit.org/show_bug.cgi?id=195684
2854         <rdar://problem/48294714>
2855
2856         Reviewed by Antti Koivisto.
2857
2858         Add API test coverage.
2859
2860         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2861
2862 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2863
2864         [ews-app] Remove unused patch view
2865         https://bugs.webkit.org/show_bug.cgi?id=195669
2866
2867         Reviewed by Lucas Forschler.
2868
2869         * BuildSlaveSupport/ews-app/ews/urls.py:
2870         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2871
2872 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2873
2874         [ews-app] Use Buildbot result code variables
2875         https://bugs.webkit.org/show_bug.cgi?id=195668
2876
2877         Reviewed by Alexey Proskuryakov.
2878
2879         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2880         (Buildbot): Added Buildbot result code variables.
2881         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2882         (StatusBubble._build_bubble): Used Buildbot result code variables.
2883
2884 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2885
2886         [Flatpak] Expand submodule recursively
2887         https://bugs.webkit.org/show_bug.cgi?id=195672
2888
2889         Building WPE with flatpak was impossible without that as it was raising an exception.
2890         Also update wpebackend-fdo to match what is built in jhbuild
2891
2892         Reviewed by Philippe Normand.
2893
2894         * flatpak/flatpakutils.py:
2895         (expand_submodules_recurse):
2896         (expand_manifest):
2897         * flatpak/org.webkit.WPEModules.yaml:
2898
2899 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2900
2901         [ews-app] status bubble should be hidden for certain builds
2902         https://bugs.webkit.org/show_bug.cgi?id=194597
2903
2904         Reviewed by Dewei Zhu.
2905
2906         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2907         (StatusBubble._build_bubble):
2908         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2909         because the patch didn't have relevant changes.
2910         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2911         in production yet.
2912
2913 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2914
2915         [Win] Fix a slew of simple clang-cl warnings.
2916         https://bugs.webkit.org/show_bug.cgi?id=195652
2917
2918         Reviewed by Don Olmstead.
2919
2920         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2921         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2922
2923 2019-03-12  Justin Fan  <justin_fan@apple.com>
2924
2925         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2926         https://bugs.webkit.org/show_bug.cgi?id=195518
2927         <rdar://problem/46322356>
2928
2929         Reviewed by Myles C. Maxfield.
2930
2931         * DumpRenderTree/DerivedSources-input.xcfilelist:
2932         * DumpRenderTree/DerivedSources-output.xcfilelist:
2933
2934 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2935
2936         Unreviewed, rolling out r242825.
2937         https://bugs.webkit.org/show_bug.cgi?id=195648
2938
2939         "Broke webkitpy tests with my change to
2940         lldb_dump_class_layout.py" (Requested by rmorisset on
2941         #webkit).
2942
2943         Reverted changeset:
2944
2945         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2946         classes with suspicious padding"
2947         https://bugs.webkit.org/show_bug.cgi?id=195573
2948         https://trac.webkit.org/changeset/242825
2949
2950 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2951
2952         [ews-build] Show status bubbles while the patch is waiting in queue
2953         https://bugs.webkit.org/show_bug.cgi?id=195618
2954
2955         Reviewed by Lucas Forschler.
2956
2957         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2958         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2959         enabled in initial deployment.
2960         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2961         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2962         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2963         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2964         (StatusBubble._build_bubbles_for_patch):
2965
2966 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2967
2968         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2969         https://bugs.webkit.org/show_bug.cgi?id=195573
2970
2971         Reviewed by Simon Fraser.
2972
2973         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2974
2975         * Scripts/dump-class-layout:
2976         (main):
2977         * lldb/lldb_dump_class_layout.py:
2978         (ClassLayout.__init__):
2979         (ClassLayout._compute_padding_recursive):
2980         (LLDBDebuggerInstance.dump_layout_for_classname):
2981         (LLDBDebuggerInstance):
2982         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2983         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2984
2985 2019-03-12  Chris Dumez  <cdumez@apple.com>
2986
2987         Device Orientation access permission should be denied unless explicitly granted by the client
2988         https://bugs.webkit.org/show_bug.cgi?id=195625
2989
2990         Reviewed by Youenn Fablet.
2991
2992         add API test coverage.
2993
2994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2995         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2996         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2997         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2998         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2999         (runDeviceOrientationTest):
3000         (TEST):
3001         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3002         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3003
3004 2019-03-12  Jer Noble  <jer.noble@apple.com>
3005
3006         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3007         https://bugs.webkit.org/show_bug.cgi?id=195137
3008         <rdar://problem/48810307>
3009
3010         Reviewed by Eric Carlson.
3011
3012         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3013         (TestWebKitAPI::TEST):
3014
3015 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3016
3017         [ews-build] Change urls from uat to production
3018         https://bugs.webkit.org/show_bug.cgi?id=195566
3019
3020         Reviewed by Lucas Forschler.
3021
3022         * BuildSlaveSupport/ews-app/ews/config.py:
3023         * BuildSlaveSupport/ews-build/events.py:
3024         * BuildSlaveSupport/ews-build/steps.py:
3025
3026 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3027
3028         [ews-build] change max_builds for local-worker to 1
3029         https://bugs.webkit.org/show_bug.cgi?id=195568
3030
3031         Reviewed by Lucas Forschler.
3032
3033         * BuildSlaveSupport/ews-build/loadConfig.py:
3034
3035 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3036
3037         Fix the build
3038
3039         * TestRunnerShared/spi/PencilKitTestSPI.h:
3040         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3041
3042 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3043
3044         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3045         https://bugs.webkit.org/show_bug.cgi?id=194131
3046
3047         Reviewed by Michael Catanzaro.
3048
3049         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3050         (uriChanged):
3051         (testUnfinishedSubresourceLoad):
3052         (serverCallback):
3053         (beforeAll):
3054
3055 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3056
3057         WTF::Expected should use std::addressof instead of operator&
3058         https://bugs.webkit.org/show_bug.cgi?id=195604
3059
3060         Reviewed by Myles Maxfield.
3061
3062         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3063         (TestWebKitAPI::Unique::Unique):
3064         (TestWebKitAPI::Unique::operator&):
3065         (TestWebKitAPI::TEST):
3066
3067 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3068
3069         Add Optional to Forward.h.
3070         https://bugs.webkit.org/show_bug.cgi?id=195586
3071
3072         Reviewed by Darin Adler.
3073
3074         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3075         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3076         Remove unnecessary includes from headers.
3077
3078 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3079
3080         Add testing API to hit-test and scroll overflow scrollers
3081         https://bugs.webkit.org/show_bug.cgi?id=195278
3082
3083         Reviewed by Antti Koivisto.
3084         
3085         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3086         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3087         
3088         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3089
3090         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3091         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3092         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3093         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3094         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3095         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3096         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3097         (WTR::enclosingScrollViewIncludingSelf):
3098         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3099
3100 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3101
3102         API test WebKit.RequestTextInputContext fails on iOS
3103         https://bugs.webkit.org/show_bug.cgi?id=195585
3104
3105         Reviewed by Wenson Hsieh and Simon Fraser.
3106
3107         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3108         (applyStyle):
3109         (TEST):
3110         Add a viewport, so that the coordinates match up on iOS.
3111         Scroll by moving the UIScrollView's contentOffset.
3112
3113 2019-03-11  Chris Dumez  <cdumez@apple.com>
3114
3115         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3116         https://bugs.webkit.org/show_bug.cgi?id=195506
3117         <rdar://problem/48733477>
3118
3119         Reviewed by Alex Christensen.
3120
3121         Add API test coverage.
3122
3123         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3124
3125 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3126
3127         Adding myself to contributors.json
3128
3129         Unreviewed, addming myself to contributors.json .
3130
3131         * Scripts/webkitpy/common/config/contributors.json:
3132
3133 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3134
3135         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3136         https://bugs.webkit.org/show_bug.cgi?id=195511
3137         <rdar://problem/44873269>
3138
3139         Reviewed by Darin Adler.
3140
3141         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3142         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3143         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3144         (TEST_F):
3145
3146 2019-03-11  Chris Dumez  <cdumez@apple.com>
3147
3148         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3149         https://bugs.webkit.org/show_bug.cgi?id=195561
3150
3151         Reviewed by Youenn Fablet.
3152
3153         Make sure the JS in the test requests for permission to receive device orientation events.
3154
3155         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3156
3157 2019-03-11  Youenn Fablet  <youenn@apple.com>
3158
3159         Allow storage quota increase by default in WTR
3160         https://bugs.webkit.org/show_bug.cgi?id=195541
3161
3162         Reviewed by Geoffrey Garen.
3163
3164         Allow storage quota increase by default in WTR.
3165         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3166         Use this for tests that explicitly need cache increase.
3167
3168         Instead of increasing quota by 2, make sure the next request is
3169         granted by adding all given parameters.
3170
3171         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3172         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3173         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3174         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3175         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3176         * WebKitTestRunner/TestController.cpp:
3177         (WTR::TestController::setAllowStorageQuotaIncrease):
3178         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3179         * WebKitTestRunner/TestController.h:
3180         * WebKitTestRunner/TestInvocation.cpp:
3181         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3182         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3183         (WTR::TestController::cocoaResetStateToConsistentValues):
3184         (WTR::TestController::setAllowStorageQuotaIncrease):
3185         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3186         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3187         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3188
3189 2019-03-11  Xan Lopez  <xan@igalia.com>
3190
3191         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3192         https://bugs.webkit.org/show_bug.cgi?id=194147
3193
3194         Reviewed by Michael Saboff.
3195
3196         To make --32-bit work correctly on Linux/64bit we need to:
3197
3198         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3199         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3200         unfortunately CMake only allows us to do this during
3201         crosscompilation, which is overkill here.
3202         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3203         pkg-config detection module uses the x86 .pc files instead of the
3204         x86_64 ones.
3205         - Set the -m32 flags for the compiler.
3206
3207         * Scripts/webkitdirs.pm:
3208         (generateBuildSystemFromCMakeProject):
3209
3210 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3211
3212         Add MotionMark-1.1 plan file for run-benchmark script.
3213         https://bugs.webkit.org/show_bug.cgi?id=195481
3214
3215         Rubber-stamped by Darin Adler.
3216
3217         Run-benchmark script should support MontionMark-1.1.
3218
3219         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3220
3221 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3222
3223         [ews-app] Add support for submit-to-ews url
3224         https://bugs.webkit.org/show_bug.cgi?id=195477
3225
3226         Reviewed by Lucas Forschler.
3227
3228         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3229         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3230         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3231         * BuildSlaveSupport/ews-app/ews/urls.py:
3232         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3233
3234 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3235
3236         Unreviewed, rolling out r242688, r242643, r242624.
3237
3238         Caused multiple layout test failures and crashes on iOS and macOS.
3239
3240         Reverted changeset:
3241
3242         "requestAnimationFrame should execute before the next frame"
3243         https://bugs.webkit.org/show_bug.cgi?id=177484
3244         https://trac.webkit.org/changeset/242624/webkit
3245
3246         * Tracing/SystemTracePoints.plist:
3247
3248 2019-03-11  John Wilander  <wilander@apple.com>
3249
3250         Resource Load Statistics: Make it possible exclude localhost from classification
3251         https://bugs.webkit.org/show_bug.cgi?id=195474
3252         <rdar://problem/47520577>
3253
3254         Reviewed by Brent Fulgham.
3255
3256         This patch allows for localhost to be excluded from classification and
3257         treatment as a prevalent resource.
3258
3259         The WebKit Tools change adds a new function called
3260         testRunner.setStatisticsIsRunningTest() which can be used to control this
3261         behavior.
3262
3263         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3264         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3265         (WTR::TestRunner::setStatisticsIsRunningTest):
3266         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3267         * WebKitTestRunner/TestController.cpp:
3268         (WTR::TestController::setStatisticsIsRunningTest):
3269         * WebKitTestRunner/TestController.h:
3270         * WebKitTestRunner/TestInvocation.cpp:
3271         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3272
3273 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3274
3275         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3276         https://bugs.webkit.org/show_bug.cgi?id=195560
3277
3278         Reviewed by Lucas Forschler.
3279
3280         * BuildSlaveSupport/ews-build/master.cfg:
3281
3282 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3283
3284         Unreviewed, rolling out r242698.
3285
3286         API test crashes on bots.
3287
3288         Reverted changeset:
3289
3290         "Add a WKContentRuleList variant that uses copied memory
3291         instead of mmap'd shared memory for class A containerized
3292         apps"
3293         https://bugs.webkit.org/show_bug.cgi?id=195511
3294         https://trac.webkit.org/changeset/242698
3295
3296 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3297
3298         [WPE] Enable web process sandbox
3299         https://bugs.webkit.org/show_bug.cgi?id=195169
3300
3301         Reviewed by Daniel Bates.
3302
3303         * wpe/install-dependencies:
3304         * wpe/jhbuild.modules:
3305
3306 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3307
3308         [ews-app] Use port 17000 for worker communication
3309         https://bugs.webkit.org/show_bug.cgi?id=195558
3310
3311         Reviewed by Lucas Forschler.
3312
3313         * BuildSlaveSupport/ews-build/master.cfg:
3314
3315 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3316
3317         [ews-build] unit-tests fail when passwords.json is missing
3318         https://bugs.webkit.org/show_bug.cgi?id=195557
3319
3320         Reviewed by Lucas Forschler.
3321
3322         * BuildSlaveSupport/ews-build/loadConfig.py:
3323         (loadBuilderConfig):
3324         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3325         (ConfigDotJSONTest.test_configuration):
3326         * BuildSlaveSupport/ews-build/master.cfg:
3327
3328 2019-03-11  Truitt Savell  <tsavell@apple.com>
3329
3330         Unreviewed, rolling out r242702.
3331
3332         Broke High Sierra builders.
3333
3334         Reverted changeset:
3335
3336         "Add utility function to allow easy reverse range-based
3337         iteration of a container"
3338         https://bugs.webkit.org/show_bug.cgi?id=195542
3339         https://trac.webkit.org/changeset/242702
3340
3341 2019-03-11  Sam Weinig  <sam@webkit.org>
3342
3343         Add utility function to allow easy reverse range-based iteration of a container
3344         https://bugs.webkit.org/show_bug.cgi?id=195542
3345
3346         Reviewed by Antti Koivisto.
3347
3348         * TestWebKitAPI/CMakeLists.txt:
3349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3350         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3351         (TestWebKitAPI::TEST):
3352         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3353
3354 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3355
3356         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3357         https://bugs.webkit.org/show_bug.cgi?id=195511
3358         <rdar://problem/44873269>
3359
3360         Reviewed by Darin Adler.
3361
3362         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3363         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3364         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3365         (TEST_F):
3366
3367 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3368
3369         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3370         https://bugs.webkit.org/show_bug.cgi?id=195499
3371
3372         Reviewed by Darin Adler.
3373
3374         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3375         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3376         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3377         (-[WKWebView synchronouslyFocusTextInputContext:]):
3378         (applyStyle):
3379         (applyIframe):
3380         (TEST):
3381         Add some tests for this SPI.
3382
3383 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3384
3385         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3386         https://bugs.webkit.org/show_bug.cgi?id=181151
3387
3388         Reviewed by Don Olmstead.
3389
3390         * TestWebKitAPI/CMakeLists.txt:
3391         * TestWebKitAPI/PlatformWin.cmake:
3392         Enable TestWTF RunLoop tests in all platforms.
3393
3394         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3395         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3396         (TestWebKitAPI::DerivedOneShotTimer::fired):
3397         (TestWebKitAPI::TEST):
3398         Only a few platforms support nested RunLoop.
3399
3400         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3401         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3402
3403 2019-03-10  David Quesada  <david_quesada@apple.com>
3404
3405         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3406         https://bugs.webkit.org/show_bug.cgi?id=152480
3407
3408         Reviewed by Chris Dumez.
3409
3410         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3411         there are no additional references to the process pool besides the one held by
3412         the download, waits for the download to finish (in the sense that the
3413         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3414         measure, also check that the process pool has been deallocated at the end of the
3415         test. The test wouldn't be meaningful if the process pool were still alive.
3416
3417         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3418         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3419         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3420             The download will be canceled because the delegate does not implement the
3421             method to decide the download's destination, so this is where we know the
3422             DownloadProxyMap is done with the DownloadProxy.
3423         (TEST):
3424
3425 2019-03-08  Chris Dumez  <cdumez@apple.com>
3426
3427         Add support for Device Orientation / Motion permission API
3428         https://bugs.webkit.org/show_bug.cgi?id=195329
3429         <rdar://problem/47645367>
3430
3431         Reviewed by Geoffrey Garen.
3432
3433         Add test infrastructure to help test the Device Orientation / Motion permission API.
3434
3435         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3436         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3437         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3438         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3439         * WebKitTestRunner/TestController.cpp:
3440         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3441         (WTR::TestController::createWebViewWithOptions):
3442         (WTR::TestController::resetStateToConsistentValues):
3443         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3444         * WebKitTestRunner/TestController.h:
3445         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3446         * WebKitTestRunner/TestInvocation.cpp:
3447         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3448
3449 2019-03-08  Saam barati  <sbarati@apple.com>
3450
3451         Add a compare-results script to compare benchmark results
3452         https://bugs.webkit.org/show_bug.cgi?id=195486
3453         <rdar://problem/48723397>
3454
3455         Reviewed by Geoffrey Garen.
3456
3457         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3458         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3459         to extend it to learn about our other benchmarks.
3460
3461         * Scripts/compare-results: Added.
3462         (readJSONFile):
3463         (detectJetStream2):
3464         (JetStream2Results):
3465         (detectSpeedometer2):
3466         (Speedometer2Results):
3467         (detectPLT5):
3468         (PLT5Results):
3469         (detectBenchmark):
3470         (biggerIsBetter):
3471         (ttest):
3472         (getOptions):
3473         (main):
3474
3475 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3476
3477         Ensure old tab state is cleared between iterations of run-benchmark
3478         https://bugs.webkit.org/show_bug.cgi?id=195393
3479         <rdar://problem/46885583>
3480
3481         Reviewed by Dewei Zhu.
3482
3483         a) ensure the default to restore state is not set
3484         b) terminate Safari correctly
3485         c) Set the system default to ignore Persistent State in Safari
3486
3487         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3488         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3489         (OSXBrowserDriver.prepare_env): 
3490         (OSXBrowserDriver.restore_env):
3491         (OSXBrowserDriver.close_browsers):
3492         (OSXBrowserDriver._terminate_processes):
3493         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3494         (OSXChromeDriver):
3495         (OSXChromeCanaryDriver):
3496         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3497         (OSXFirefoxDriver):
3498         (OSXFirefoxNightlyDriver):
3499         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3500         (OSXSafariDriver):
3501         (OSXSafariDriver.prepare_env):
3502
3503 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3504
3505         [GTK] Several InputMethodFilter tests are failing
3506         https://bugs.webkit.org/show_bug.cgi?id=195408
3507
3508         Reviewed by Carlos Garcia Campos.
3509
3510         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3511         Regressed in r241751.
3512         Hexadecimal values of keycodes are expressed now in upper letters.
3513         Composited characters should be cast to UTF8 strings.
3514
3515         (TestWebKitAPI::TEST):
3516
3517 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3518
3519         [GTK] Make Tools/gtkdoc python3 compatible
3520         https://bugs.webkit.org/show_bug.cgi?id=195359
3521
3522         Reviewed by Carlos Garcia Campos.
3523
3524         * gtkdoc/generate-gtkdoc:
3525         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3526         work with Python 2 and 3.
3527         (get_gtkdoc_module_paths):
3528         The iteritems() was removed in Python 3, so let's use items() that's
3529         available in Python 2 and 3.
3530         (get_generator_for_config):
3531         * gtkdoc/gtkdoc.py:
3532         (GTKDoc._run_command):
3533         The sys.stdout.write() is expecting str in Python 3 and not bytes
3534         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3535         for passing the bytes there.
3536
3537 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3538
3539         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3540         https://bugs.webkit.org/show_bug.cgi?id=195346
3541         <rdar://problem/48667048>
3542
3543         Unreviewed build fix for clang-cl.
3544
3545         * DumpRenderTree/win/DumpRenderTree.cpp:
3546         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3547
3548 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3549
3550         requestAnimationFrame should execute before the next frame
3551         https://bugs.webkit.org/show_bug.cgi?id=177484
3552
3553         Reviewed by Simon Fraser.
3554
3555         Add trace points for the page RenderingUpdate.
3556
3557         * Tracing/SystemTracePoints.plist:
3558
3559 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3560
3561         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3562         https://bugs.webkit.org/show_bug.cgi?id=195353
3563         <rdar://problem/48626394>
3564
3565         Reviewed by Simon Fraser.
3566
3567         * WebKitTestRunner/ios/TestControllerIOS.mm:
3568         (WTR::TestController::platformResetPreferencesToConsistentValues):
3569
3570 2019-03-07  John Wilander  <wilander@apple.com>
3571
3572         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3573         https://bugs.webkit.org/show_bug.cgi?id=195383
3574         <rdar://problem/48570136>
3575
3576         Reviewed by Brent Fulgham.
3577
3578         This patch adds test infrastructure to purge only script-accessible cookies,
3579         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3580
3581         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3582         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3583         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3584         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3585         * WebKitTestRunner/TestController.cpp:
3586         (WTR::TestController::statisticsDeleteCookiesForHost):
3587         * WebKitTestRunner/TestController.h:
3588         * WebKitTestRunner/TestInvocation.cpp:
3589         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3590
3591 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3592
3593         Unreviewed, rolling out r242354.
3594         https://bugs.webkit.org/show_bug.cgi?id=195402
3595
3596         breaks layout tests in all configurations (Requested by
3597         zdobersek on #webkit).
3598
3599         Reverted changeset:
3600
3601         "[WPE] Enable web process sandbox"
3602         https://bugs.webkit.org/show_bug.cgi?id=195169
3603         https://trac.webkit.org/changeset/242354
3604
3605 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3606
3607         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3608         https://bugs.webkit.org/show_bug.cgi?id=195346
3609
3610         Reviewed by Fujii Hironori.
3611
3612         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3613         (TestWebKitAPI::TEST):
3614         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3615
3616         * DumpRenderTree/win/DumpRenderTree.cpp:
3617         (findFontFallback):
3618         (addFontFallbackIfPresent):
3619         (removeFontFallbackIfPresent):
3620         (main):
3621         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3622         (TestWebKitAPI::Util::moduleDirectory):
3623         (TestWebKitAPI::Util::createInjectedBundlePath):
3624         Use wchar helpers as needed.
3625
3626 2019-03-06  Rob Buis  <rbuis@igalia.com>
3627
3628         Consider supporting the `referrerpolicy` attribute.
3629         https://bugs.webkit.org/show_bug.cgi?id=179053
3630
3631         Reviewed by Darin Adler.
3632
3633         Add a runtime flag for referrerpolicy attribute.
3634
3635         * DumpRenderTree/mac/DumpRenderTree.mm:
3636         (enableExperimentalFeatures):
3637
3638 2019-03-05  Daniel Bates  <dabates@apple.com>
3639
3640         Update expected API test result following r242379
3641         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3642
3643         Update expected x-coordinate of selection rect now that the left padding of
3644         a textarea is sized in ems (so dependent on the font size) just like the left
3645         padding of a text field.
3646
3647         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3648         (TestWebKitAPI::TEST):
3649
3650 2019-03-05  David Quesada  <david_quesada@apple.com>
3651
3652         [WK2] It should be possible to follow links with 'download' attributes
3653         https://bugs.webkit.org/show_bug.cgi?id=195145
3654         rdar://problem/48462642
3655
3656         Reviewed by Alex Christensen.
3657
3658         Add a unit test to verify that activating links with 'download' attributes now
3659         navigates to the linked resource, rather than starts downloading it. Add another
3660         to verify that it is still possible to explicitly download the link via the
3661         'Download' navigation action policy.
3662
3663         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3664         (-[DownloadAttributeTestDelegate init]):
3665         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3666         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3667         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3668         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3669         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3670         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3671         (TEST):
3672         * WebKitTestRunner/TestController.cpp:
3673         (WTR::TestController::decidePolicyForNavigationAction):
3674         * WebKitTestRunner/TestController.h:
3675
3676 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3677
3678         [Curl] Implement Cookie Accept Policy.
3679         https://bugs.webkit.org/show_bug.cgi?id=191645
3680
3681         Reviewed by Fujii Hironori.
3682
3683         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3684         (TestWebKitAPI::Curl::TEST_F):
3685
3686 2019-03-05  Youenn Fablet  <youenn@apple.com>
3687
3688         Rename requestCacheStorageSpace to requestStorageSpace
3689         https://bugs.webkit.org/show_bug.cgi?id=195282
3690
3691         Reviewed by Chris Dumez.
3692
3693         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3694         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3695         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3696
3697 2019-03-05  Brady Eidson  <beidson@apple.com>
3698
3699         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3700         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3701
3702         Reviewed by Tim Horton.
3703
3704         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3705         different directory into that same WKWebView should work.
3706
3707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3708         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3709
3710 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3711
3712         Add WeakHashSet
3713         https://bugs.webkit.org/show_bug.cgi?id=195152
3714
3715         Reviewed by Antti Koivisto.
3716
3717         Added tests for WeakHashSet.
3718
3719         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3720         (TestWebKitAPI::Base::Base): Moved.
3721         (TestWebKitAPI::Derived::foo): Moved.
3722         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3723         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3724         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3725         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3726
3727 2019-03-04  Chris Dumez  <cdumez@apple.com>
3728
3729         Do not share WebProcesses between private and regular sessions
3730         https://bugs.webkit.org/show_bug.cgi?id=195189
3731         <rdar://problem/48421064>
3732
3733         Reviewed by Alex Christensen.
3734
3735         Add API test coverage.
3736
3737         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3738         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3739
3740 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3741
3742         [WPE] Enable web process sandbox
3743         https://bugs.webkit.org/show_bug.cgi?id=195169
3744
3745         Reviewed by Daniel Bates.
3746
3747         * wpe/install-dependencies:
3748         * wpe/jhbuild.modules:
3749
3750 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3751
3752         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3753         https://bugs.webkit.org/show_bug.cgi?id=195206
3754
3755         Reviewed by Žan Doberšek.
3756
3757         Add a new test case.
3758
3759         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3760         (testJSCClass):
3761
3762 2019-03-04  Charlie Turner  <cturner@igalia.com>
3763
3764         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3765         https://bugs.webkit.org/show_bug.cgi?id=194898
3766
3767         Reviewed by Žan Doberšek.
3768
3769         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3770         a GCC extension that permits arithmetic on void* pointer. Inline
3771         the macro until this issue is fixed upstream.
3772
3773 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3774
3775         Rid the world of WK_API_ENABLED
3776         https://bugs.webkit.org/show_bug.cgi?id=195263
3777
3778         Reviewed by Dan Bernstein.
3779
3780         List of changed files elided because it's useless.
3781
3782 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3783
3784         Unreviewed follow-up to r242292.
3785
3786         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3787
3788         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3789         (TestWebKitAPI::testStrip): Renamed from strip.
3790         (TestWebKitAPI::TEST):
3791
3792 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3793
3794         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3795
3796         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3797         and bug #194272 for details.
3798
3799         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3800
3801 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3802
3803         Remove some more unused 32-bit code
3804         https://bugs.webkit.org/show_bug.cgi?id=195255
3805
3806         Reviewed by Darin Adler.
3807
3808         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3809         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3810         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3811         (NPP_New):
3812         (NPP_HandleEvent):
3813         (handleEventCarbon): Deleted.
3814
3815 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3816
3817         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3818
3819         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3820         (TestWebKitAPI::TEST):
3821
3822 2019-03-01  Darin Adler  <darin@apple.com>
3823
3824         Finish removing String::format
3825         https://bugs.webkit.org/show_bug.cgi?id=194893
3826
3827         Reviewed by Daniel Bates.
3828 '
3829         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3830
3831 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3832
3833         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3834         https://bugs.webkit.org/show_bug.cgi?id=195229
3835         <rdar://problem/48520362>
3836
3837         Reviewed by Chris Dumez.
3838
3839         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3840         (TEST):
3841
3842 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3843
3844         Add a system trace scope for event region building
3845         https://bugs.webkit.org/show_bug.cgi?id=195226
3846
3847         Reviewed by Jon Lee.
3848
3849         This trace scope measures the time spend converting element rects into Region objects,
3850         which can be large on some pages.
3851
3852         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3853
3854         * Tracing/SystemTracePoints.plist:
3855
3856 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3857
3858         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3859         https://bugs.webkit.org/show_bug.cgi?id=194612
3860
3861         Reviewed by Alex Christensen.
3862
3863         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3864         Just test the new string-processing function and don't touch the actual environment.
3865         (Test cases are all as before, but based on operator== instead of strcmp.)
3866
3867 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3868
3869         [ews-app] Update primary keys for handling multiple Buildbot instances
3870         https://bugs.webkit.org/show_bug.cgi?id=195120
3871
3872         Reviewed by Stephanie Lewis.
3873
3874         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3875         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3876         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3877
3878         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3879         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3880         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3881         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3882         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3883         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3884
3885 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3886
3887         [WinCairo] Enable service worker
3888         https://bugs.webkit.org/show_bug.cgi?id=188318
3889
3890         Reviewed by Youenn Fablet.
3891
3892         * DumpRenderTree/DumpRenderTreePrefix.h:
3893         * TestWebKitAPI/PlatformWin.cmake:
3894         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3895         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3896         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3897
3898 2019-03-01  Justin Fan  <justin_fan@apple.com>
3899
3900         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3901         https://bugs.webkit.org/show_bug.cgi?id=195191
3902
3903         Rubber-stamped by Dean Jackson.
3904
3905         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3906
3907         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3908
3909 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3910
3911         Unreviewed, fix lldb webkitpy tests
3912         https://bugs.webkit.org/show_bug.cgi?id=194375
3913
3914         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3915
3916         * lldb/lldb_webkit.py:
3917         (WTFStringImplProvider.is_8bit):
3918
3919 2019-02-28  David Quesada  <david_quesada@apple.com>
3920
3921         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3922         https://bugs.webkit.org/show_bug.cgi?id=195121
3923         rdar://problem/48450302
3924
3925         Reviewed by Alex Christensen.
3926
3927         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3928         configurations where the 'download' attribute is absent, blank, or populated
3929         with a filename, and where the anchor element is same-origin or cross-origin
3930         (meaning the 'download' attribute shouldn't be honored).
3931
3932         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3933         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3934         (-[NavigationActionTestDelegate init]):
3935         (-[NavigationActionTestDelegate navigationAction]):
3936         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3937         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3938         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3939         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3940         (TEST):
3941
3942 2019-02-28  Antoine Quint  <graouts@apple.com>
3943
3944         Enable the Pointer Events runtime flag by default
3945         https://bugs.webkit.org/show_bug.cgi?id=195156
3946
3947         Reviewed by Dean Jackson.
3948
3949         * DumpRenderTree/mac/DumpRenderTree.mm:
3950         (enableExperimentalFeatures):
3951
3952 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3953
3954         Several PasteImage API tests are flaky
3955         https://bugs.webkit.org/show_bug.cgi?id=195160
3956
3957         Reviewed by Tim Horton.
3958
3959         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3960         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3961         listening for a "load" event after image load is already complete.
3962
3963         To address this, make these tests first register a "load" event handler, then run script to insert an image
3964         element into the document, and finally wait until the load event is observed before checking image size.
3965
3966         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3967
3968 2019-02-28  Chris Dumez  <cdumez@apple.com>
3969
3970         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3971         https://bugs.webkit.org/show_bug.cgi?id=195107
3972
3973         Reviewed by Alex Christensen.
3974
3975         Give some time for the zoom level to get restored.
3976
3977         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3978
3979 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3980
3981         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3982         https://bugs.webkit.org/show_bug.cgi?id=194958
3983
3984         Reviewed by Geoffrey Garen.
3985
3986         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3987         (TEST):
3988
3989 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3990
3991         [ews-app] Update method to save build to handle builder_display_name
3992         https://bugs.webkit.org/show_bug.cgi?id=195047
3993
3994         Reviewed by Dewei Zhu.
3995
3996         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3997         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3998
3999 2019-02-28  Justin Fan  <justin_fan@apple.com>
4000
4001         [Web GPU] Enable Web GPU only on 64-bit
4002         https://bugs.webkit.org/show_bug.cgi?id=195139
4003
4004         Because Metal is only supported on 64 bit apps.
4005
4006         Unreviewed build fix.
4007
4008         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4009
4010 2019-02-27  Youenn Fablet  <youenn@apple.com>
4011
4012         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4013         https://bugs.webkit.org/show_bug.cgi?id=194959
4014
4015         Reviewed by Chris Dumez.
4016
4017         Spin loop until getting the condition to remove flakiness.
4018
4019         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4020
4021 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4022
4023         [ews-build] Buildbot should include builder_display_name in the build events
4024         https://bugs.webkit.org/show_bug.cgi?id=195045
4025
4026         Reviewed by Dewei Zhu.
4027
4028         * BuildSlaveSupport/ews-build/events.py:
4029         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4030         buildername to builder_name to be consistent in naming style.
4031         (Events.buildFinished): Ditto.
4032
4033 2019-02-27  Chris Dumez  <cdumez@apple.com>
4034
4035         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4036         https://bugs.webkit.org/show_bug.cgi?id=194480
4037
4038         Reviewed by Brady Eidson.
4039
4040         Update existing API test to make it more likely to reproduce the issue.
4041
4042         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4043
4044 2019-02-27  Brady Eidson  <beidson@apple.com>
4045
4046         Universal links from Google search results pages don't open the app.
4047         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4048
4049         Reviewed by Geoffrey Garen.
4050
4051         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4052         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4053         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4054         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4055
4056 2019-02-27  Chris Dumez  <cdumez@apple.com>
4057
4058         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4059         https://bugs.webkit.org/show_bug.cgi?id=195102
4060
4061         Reviewed by Geoffrey Garen.
4062
4063         If the number of processes is not yet what we expect, wait a bit and check again to give
4064         processes some time to exit.
4065
4066         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4067
4068 2019-02-27  Chris Dumez  <cdumez@apple.com>
4069
4070         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4071         https://bugs.webkit.org/show_bug.cgi?id=194545
4072
4073         Reviewed by Brady Eidson.
4074
4075         Make sure the test navigates forward and then back only once. Previously, navigating
4076         back would trigger a navigation again in a timer.
4077
4078         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4079
4080 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4081
4082         High Sierra Debug JSC test queue should use faster hardware
4083         https://bugs.webkit.org/show_bug.cgi?id=194603
4084
4085         Rubber-stamped by Alexey Proskuryakov.
4086
4087         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4088
4089         * BuildSlaveSupport/build.webkit.org-config/config.json:
4090         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4091         (BubbleQueueServer):
4092         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4093         (WebKitBuildbot):
4094         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4095         * QueueStatusServer/config/queues.py:
4096         * Scripts/webkitpy/common/config/ews.json:
4097         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4098         (test_ews_name):
4099
4100 2019-02-27  John Wilander  <wilander@apple.com>
4101
4102         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4103         https://bugs.webkit.org/show_bug.cgi?id=195071
4104         <rdar://problem/48417690>
4105
4106         Reviewed by Alex Christensen and Brent Fulgham.
4107
4108         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4109         (TestWebKitAPI::createURL):
4110             Convenience function.
4111         (TestWebKitAPI::TEST):
4112             WebCore::AdClickAttribution now takes a URL when creating Source and
4113             Destination.
4114         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4115         (TestWebKitAPI::TEST):
4116             WebCore::AdClickAttribution now takes a URL when creating Source and
4117             Destination.
4118
4119 2019-02-27  Antoine Quint  <graouts@apple.com>
4120
4121         Support Pointer Events on macOS
4122         https://bugs.webkit.org/show_bug.cgi?id=195008
4123         <rdar://problem/47454419>
4124
4125         Reviewed by Dean Jackson.
4126
4127         * DumpRenderTree/mac/DumpRenderTree.mm:
4128         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4129         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4130
4131 2019-02-26  Mark Lam  <mark.lam@apple.com>
4132
4133         Remove remaining poisoning code.
4134         https://bugs.webkit.org/show_bug.cgi?id=194138
4135
4136         Reviewed by Saam Barati.
4137
4138         * TestWebKitAPI/CMakeLists.txt:
4139         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4140         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4141         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4142         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4143         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4144         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4145         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4146
4147 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4148
4149         Move ephemeral local storage from WebProcess to UIProcess
4150         https://bugs.webkit.org/show_bug.cgi?id=195074
4151         <rdar://problem/47937975>
4152
4153         Reviewed by Geoff Garen.
4154
4155         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4156
4157 2019-02-20  Jer Noble  <jer.noble@apple.com>
4158
4159         [Cocoa] Media elements will restart network buffering just before suspending
4160         https://bugs.webkit.org/show_bug.cgi?id=193691
4161
4162         Reviewed by Eric Carlson.
4163
4164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4165         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4166         (TEST):
4167
4168 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4169
4170         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4171         https://bugs.webkit.org/show_bug.cgi?id=191652
4172
4173         Reviewed by Alex Christensen.
4174
4175         Fix WinCairo MiniBrowser behavior of authentication dialog.
4176
4177         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4178         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4179
4180 2019-02-26  Youenn Fablet  <youenn@apple.com>
4181
4182         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4183         https://bugs.webkit.org/show_bug.cgi?id=195028
4184         <rdar://problem/48243733>
4185
4186         Reviewed by Eric Carlson.
4187
4188         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4189
4190 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4191
4192         [WPE] Add API for webview background color configuration
4193         https://bugs.webkit.org/show_bug.cgi?id=192305
4194
4195         Reviewed by Michael Catanzaro.
4196
4197         * MiniBrowser/wpe/main.cpp:
4198         (main): Add a new option to configure the webview background
4199         color. Example: --bg-color=transparent.
4200         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4201         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4202         (beforeAll): Ditto.
4203
4204 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4205
4206         scalableNativeWebpageParameters() is not preserved on new page navigation.
4207         https://bugs.webkit.org/show_bug.cgi?id=194892
4208         <rdar://problem/47538280>
4209
4210         Reviewed by Wenson Hsieh.
4211         
4212         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4213
4214         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4215         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4216         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4217         (WTR::UIScriptController::allowsViewportShrinkToFit):
4218         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4219         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4220         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4221         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4222         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4223         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4224
4225 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4226
4227         [ews-app] Add model for handling multiple Buildbot instances
4228         https://bugs.webkit.org/show_bug.cgi?id=194863
4229
4230         Reviewed by Stephanie Lewis.
4231
4232         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4233
4234 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4235
4236         [ews-app] Remove BuilderMapping table
4237         https://bugs.webkit.org/show_bug.cgi?id=194961
4238
4239         Reviewed by Stephanie Lewis.
4240
4241         Store builder name directly in build table, instead of having a separate
4242         table for it.
4243
4244         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4245         * BuildSlaveSupport/ews-app/ews/models/build.py:
4246         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4247         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4248
4249 2019-02-25  John Wilander  <wilander@apple.com>
4250
4251         Introduce and adopt new class RegistrableDomain for eTLD+1
4252         https://bugs.webkit.org/show_bug.cgi?id=194791
4253         <rdar://problem/48179240>
4254
4255         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4256
4257         This patch adds an API test and replaces two instances of
4258         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4259
4260         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4261         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4262         (TestWebKitAPI::TEST):
4263             Changed two strings to make sure the registrable domains are still considered
4264             invalid and pass the test.
4265         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4266         (TestWebKitAPI::TEST):
4267         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4268         (WTR::InjectedBundle::didReceiveMessageToPage):
4269
4270 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4271
4272         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4273         https://bugs.webkit.org/show_bug.cgi?id=195001
4274
4275         Reviewed by Carlos Garcia Campos.
4276
4277         API version 1.0 always includes the functionality previously guarded with
4278         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4279         unconditionally.
4280
4281         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4282         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4283         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4284         (WebViewTest::showInWindow): Ditto.
4285         (WebViewTest::hideView): Ditto.
4286         * wpe/backends/HeadlessViewBackend.cpp:
4287         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4288         * wpe/backends/ViewBackend.cpp:
4289         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4290         * wpe/backends/WindowViewBackend.cpp:
4291         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4292         WPE_BACKEND_CHECK_VERSION().
4293         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4294
4295 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4296
4297         [Flatpak] Add support for flatpak > 1.1.2
4298         https://bugs.webkit.org/show_bug.cgi?id=194088
4299
4300         Flatpak 1.2 is now out so we need to support that
4301         version now.
4302
4303         Reviewed by Michael Catanzaro.
4304
4305         * flatpak/flatpakutils.py:
4306         (check_flatpak):
4307         (FlatpakPackages.__init__):
4308         (FlatpakPackages.__detect_packages):
4309         (FlatpakPackages.__detect_packages.in):
4310         (FlatpakRepos.update):
4311
4312 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4313
4314         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4315         https://bugs.webkit.org/show_bug.cgi?id=194998
4316
4317         Reviewed by Carlos Garcia Campos.
4318
4319         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4320         to a Git checkout and using the latest commit containing various fixes
4321         and improvements.
4322
4323 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4324
4325         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4326         https://bugs.webkit.org/show_bug.cgi?id=194981
4327
4328         Reviewed by Žan Doberšek.
4329
4330         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4331         (TestWebKitAPI::TEST):
4332
4333 2019-02-23  Keith Miller  <keith_miller@apple.com>
4334
4335         Add new mac target numbers
4336         https://bugs.webkit.org/show_bug.cgi?id=194955
4337
4338         Reviewed by Tim Horton.
4339
4340         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4341         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4342         * MiniBrowser/Configurations/Base.xcconfig:
4343         * TestWebKitAPI/Configurations/Base.xcconfig:
4344         * WebKitTestRunner/Configurations/Base.xcconfig:
4345
4346 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4347
4348         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4349         https://bugs.webkit.org/show_bug.cgi?id=194846
4350
4351         Reviewed by Don Olmstead.
4352
4353         Added _search_paths() and _port_specific_expectations_files() for
4354         WinCairoPort.
4355
4356         * Scripts/webkitpy/port/win.py:
4357         (WinCairoPort.default_baseline_search_path):
4358         (WinCairoPort):
4359         (WinCairoPort._port_specific_expectations_files):
4360         (WinCairoPort._search_paths):
4361
4362 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4363
4364         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4365         https://bugs.webkit.org/show_bug.cgi?id=194963
4366
4367         Reviewed by Dean Jackson.
4368
4369         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4370         Do a `contains` check instead of `equals`, because in debug builds we