Call Netscape Plugin's toString() and valueOf() instead of providing default implemen...
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
2
3         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
4         https://bugs.webkit.org/show_bug.cgi?id=113139
5
6         Reviewed by Anders Carlsson.
7
8         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
9         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
10         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
11         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
12         (ToStringAndValueOfObject):
13         (ToStringAndValueOfObject::ToStringAndValueOfObject):
14         (ScriptableObject):
15         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
16         (ToStringAndValueOfObject::ScriptableObject::invoke):
17         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
18         (ToStringAndValueOfObject::NPP_GetValue):
19         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
20         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
21         * GNUmakefile.am:
22
23 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
24
25         [GTK] Bump gnome-themes-standard to 3.6.0
26         https://bugs.webkit.org/show_bug.cgi?id=114155
27
28         Reviewed by Martin Robinson.
29
30         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
31         dependency of gnome-themes-standard accordingly.
32
33 2013-04-08  David Levin  <levin@chromium.org>
34
35         Remove my watchlist entries.
36         https://bugs.webkit.org/show_bug.cgi?id=114180
37
38         Reviewed by Adam Barth.
39
40         * Scripts/webkitpy/common/config/committers.py:
41         * Scripts/webkitpy/common/config/watchlist:
42
43 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
44
45         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
46         https://bugs.webkit.org/show_bug.cgi?id=114161
47
48         Reviewed by Gyuyoung Kim.
49
50         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
51         as it is crashing due to Bug 111074.
52
53         * TestWebKitAPI/PlatformEfl.cmake:
54
55 2013-04-07  David Kilzer  <ddkilzer@apple.com>
56
57         Remove the rest of SVG_DOM_OBJC_BINDINGS
58         <http://webkit.org/b/114112>
59
60         Reviewed by Geoffrey Garen.
61
62         * Scripts/webkitperl/FeatureList.pm:
63         - Remove --svg-dom-objc-bindings switch.
64         * qmake/mkspecs/features/features.pri:
65         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
66
67 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
68
69         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
70         https://bugs.webkit.org/show_bug.cgi?id=114089
71
72         Reviewed by Chris Fleizach.
73
74         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
75         * DumpRenderTree/AccessibilityController.cpp:
76         * DumpRenderTree/AccessibilityUIElement.cpp:
77         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
78         (DumpRenderTreeChrome::DumpRenderTreeChrome):
79         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
80         (DumpRenderTreeChrome):
81
82 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
83
84         Build fix after r147857, remove remaining USE(JSC) guards.
85
86         Unreviewed.
87
88         * DumpRenderTree/config.h:
89         * TestWebKitAPI/config.h:
90         * WebKitTestRunner/config.h:
91
92 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
93
94         Rename sheriffbot to webkitbot
95         https://bugs.webkit.org/show_bug.cgi?id=114109
96
97         Reviewed by Benjamin Poulain.
98
99         Renamed since sheriffbot will be used in Blink.
100
101         * Scripts/webkitpy/tool/commands/sheriffbot.py:
102         (SheriffBot):
103         (SheriffBot.begin_work_queue):
104
105 2013-04-06  Oliver Hunt  <oliver@apple.com>
106
107         Unify the many and varied stack trace mechanisms, and make the result sane.
108         https://bugs.webkit.org/show_bug.cgi?id=114072
109
110         Reviewed by Filip Pizlo.
111
112         The commandline jsc executable no longer requires arguments, so
113         I've made run-jsc work without them.
114
115         * Scripts/run-jsc:
116
117 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
118
119         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
120         https://bugs.webkit.org/show_bug.cgi?id=114086
121
122         Reviewed by Tim Horton.
123
124         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
125
126 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
127
128         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
129         https://bugs.webkit.org/show_bug.cgi?id=114083
130
131         Reviewed by Ryosuke Niwa.
132
133         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
134         in TestWebKitAPI and WebKitTestRunner.
135
136         * TestWebKitAPI/config.h:
137         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
138         (TestWebKitAPI::InjectedBundleController::platformInitialize):
139         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
140         (WTR::InjectedBundle::platformInitialize):
141
142 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
143
144         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
145         https://bugs.webkit.org/show_bug.cgi?id=114094
146
147         Reviewed by Anders Carlsson.
148
149         * Scripts/run-jsc:
150
151 2013-04-05  Ojan Vafai  <ojan@chromium.org>
152
153         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
154         https://bugs.webkit.org/show_bug.cgi?id=114080
155
156         Reviewed by Ryosuke Niwa.
157
158         This way, the WebKit and Blink dashboard code can change as appropriate without
159         needing to consider the other project's needs. This still doesn't update the
160         buildbots to upload to the new location, or the dashboard code to pull the
161         results.json files from the new location, but it at least allows for changing the
162         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
163
164         * TestResultServer/app.yaml:
165
166 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
167
168         Re-enable testing on the commit queue
169         https://bugs.webkit.org/show_bug.cgi?id=114078
170
171         Reviewed by Darin Adler.
172
173         Re-enabled the feature and the associated tests.
174
175         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
176         (CommitQueueTask.run):
177         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
178         (CommitQueueTaskTest._run_through_task):
179         * Scripts/webkitpy/tool/commands/queues_unittest.py:
180         (CommitQueueTest._mock_test_result):
181
182 2013-04-05  Oliver Hunt  <oliver@apple.com>
183
184         Unify the many and varied stack trace mechanisms, and make the result sane.
185         https://bugs.webkit.org/show_bug.cgi?id=114072
186
187         Reviewed by Filip Pizlo.
188
189         The commandline jsc executable no longer requires arguments, so
190         I've made run-jsc work without them.
191
192         * Scripts/run-jsc:
193
194 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
195
196         AX: Make SVG Group containers accessible elements
197         https://bugs.webkit.org/show_bug.cgi?id=113939
198
199         Reviewed by Simon Fraser.
200
201         Implement axController.elementAtPoint for iOS.
202         Implement a correct version of clickPoint for iOS.
203
204         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
205         (AccessibilityController::elementAtPoint):
206         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
207         (AccessibilityUIElement::clickPointX):
208         (AccessibilityUIElement::clickPointY):
209
210 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
211
212         Unreviewed, rolling out r147773 and r147774.
213         http://trac.webkit.org/changeset/147773
214         http://trac.webkit.org/changeset/147774
215         https://bugs.webkit.org/show_bug.cgi?id=114056
216
217         Causing some exceptions on AppEngine I don't understand
218         (Requested by rniwa on #webkit).
219
220         * QueueStatusServer/config/queues.py:
221         * QueueStatusServer/model/queues.py:
222         (Queue.short_name):
223         (Queue.display_name):
224         * QueueStatusServer/model/queues_unittest.py:
225         (QueueTest.test_short_name):
226         (QueueTest.test_display_name):
227         (QueueTest.test_name_with_underscores):
228
229 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
230
231         Fixed run-bindings-tests by removing V8
232         https://bugs.webkit.org/show_bug.cgi?id=114053
233
234         Reviewed by Benjamin Poulain.
235
236         * Scripts/run-bindings-tests:
237         (main):
238
239 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
240
241         Build fix.
242
243         * QueueStatusServer/model/queues.py:
244         (Queue.short_name):
245         (Queue.display_name):
246
247 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
248
249         Remove Chromium EWS bots from the queue status server
250         https://bugs.webkit.org/show_bug.cgi?id=113988
251
252         Reviewed by Benjamin Poulain.
253
254         Removed Chromium EWS bots.
255
256         * QueueStatusServer/config/queues.py:
257         * QueueStatusServer/model/queues.py:
258         (Queue.short_name):
259         (Queue.display_name):
260         * QueueStatusServer/model/queues_unittest.py:
261         (QueueTest.test_short_name):
262         (QueueTest.test_display_name):
263         (QueueTest.test_name_with_underscores):
264
265 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
266
267         [EFL] Enable indexed database
268         https://bugs.webkit.org/show_bug.cgi?id=107248
269
270         Reviewed by Alexis Menard.
271
272         * Scripts/webkitperl/FeatureList.pm:
273
274 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
275
276         Remove vestiges of Chromium bits from watchlists.
277         https://bugs.webkit.org/show_bug.cgi?id=114047
278
279         Reviewed by Ryosuke Niwa.
280
281         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
282
283 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
284
285         Add James Craig to the contributors list.
286
287         * Scripts/webkitpy/common/config/committers.py:
288
289 2013-04-04  Kent Tamura  <tkent@chromium.org>
290
291         Remove ChromiumPublicApi pattern, and cc/message rules for it.
292
293         * Scripts/webkitpy/common/config/watchlist:
294
295 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
296
297         Temporarily disable the Python unittests broken by the commit queue not running layout tests
298         https://bugs.webkit.org/show_bug.cgi?id=113997
299
300         Reviewed by Ryosuke Niwa.
301
302         Disable the tests until Ryosuke gets the time and hardware to have
303         a testing commit-queue.
304
305         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
306         (CommitQueueTaskTest):
307         * Scripts/webkitpy/tool/commands/queues_unittest.py:
308         (CommitQueueTest):
309
310 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
311
312         Remove Chromium builders from build.webkit.org
313         https://bugs.webkit.org/show_bug.cgi?id=113990
314
315         Reviewed by Benjamin Poulain.
316
317         Land the part to disable triggering of Chromium builders first so that we may start
318         deleting more Chromium code that breaks the update step.
319
320         * BuildSlaveSupport/build.webkit.org-config/config.json:
321
322 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
323
324         Remove Chromium's DumpRenderTree
325         https://bugs.webkit.org/show_bug.cgi?id=113989
326
327         Reviewed by Kent Tamura.
328
329         On second thought, let's not go to Camelot. It is a silly place.
330
331         * DumpRenderTree/mac/DumpRenderTree.mm:
332         (resetDefaultsToConsistentValues):
333
334 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
335
336         Nixed the defunct chromium folder from DumpRenderTree
337         https://bugs.webkit.org/show_bug.cgi?id=113993
338
339         Reviewed by Ryosuke Niwa.
340
341         * DumpRenderTree/chromium: Removed.
342         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
343         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
344         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
345         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
346         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
347         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
348         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
349         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
350         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
351         * DumpRenderTree/chromium/MockPlatform.h: Removed.
352         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
353         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
354         * DumpRenderTree/chromium/Task.cpp: Removed.
355         * DumpRenderTree/chromium/Task.h: Removed.
356         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
357         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
358         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
359         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
360         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
361         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
362         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
363         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
364         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
365         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
366         * DumpRenderTree/chromium/TestRunner: Removed.
367         * DumpRenderTree/chromium/TestRunner/public: Removed.
368         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
369         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
370         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
371         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
372         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
373         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
374         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
375         * DumpRenderTree/chromium/TestRunner/src: Removed.
376         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
377         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
378         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
379         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
380         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
381         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
382         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
383         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
384         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
385         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
386         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
387         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
388         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
389         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
390         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
391         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
392         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
393         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
394         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
395         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
396         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
397         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
398         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
399         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
400         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
401         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
402         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
403         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
404         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
405         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
406         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
407         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
408         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
409         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
410         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
411         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
412         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
413         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
414         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
415         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
416         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
417         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
418         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
419         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
420         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
421         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
422         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
423         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
424         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
425         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
426         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
427         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
428         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
429         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
430         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
431         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
432         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
433         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
434         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
435         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
436         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
437         * DumpRenderTree/chromium/TestShell.cpp: Removed.
438         * DumpRenderTree/chromium/TestShell.h: Removed.
439         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
440         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
441         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
442         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
443         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
444         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
445         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
446         * DumpRenderTree/chromium/WebViewHost.h: Removed.
447         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
448         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
449         * DumpRenderTree/chromium/config.h: Removed.
450         * DumpRenderTree/chromium/fonts.conf: Removed.
451
452 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
453
454         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
455
456         Rubber stamped by Benjamin Poulain.
457
458         * RebaselineQueueServer: Removed.
459         * RebaselineQueueServer/app.yaml: Removed.
460         * RebaselineQueueServer/handlers: Removed.
461         * RebaselineQueueServer/handlers/__init__.py: Removed.
462         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
463         * RebaselineQueueServer/handlers/pages.py: Removed.
464         * RebaselineQueueServer/index.yaml: Removed.
465         * RebaselineQueueServer/main.py: Removed.
466         * RebaselineQueueServer/model: Removed.
467         * RebaselineQueueServer/model/__init__.py: Removed.
468         * RebaselineQueueServer/model/queueentry.py: Removed.
469         * RebaselineQueueServer/static: Removed.
470         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
471         * RebaselineQueueServer/static/styles.css: Removed.
472         * RebaselineQueueServer/templates: Removed.
473         * RebaselineQueueServer/templates/builder-picker.html: Removed.
474         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
475         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
476         * RebaselineQueueServer/templates/home.html: Removed.
477
478 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
479
480         Fix setup-commit-queue and temporarily disable testing on commit-queue
481         https://bugs.webkit.org/show_bug.cgi?id=113979
482
483         Reviewed by Benjamin Poulain.
484
485         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
486         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
487
488         * EWSTools/setup-commit-queue.sh:
489         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
490         (CommitQueueTask.run):
491
492 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
493
494         temporarily make flakiness dashboard work again webkit.org bots
495         https://bugs.webkit.org/show_bug.cgi?id=113972
496
497         Reviewed by Ojan Vafai.
498
499         This patch disables the chromium.org layout test bots TestExpectations
500         parsing temporarily until we can work out the right way to split into
501         two instances for webkit.org and chromium.org and figure out which
502         code to delete where :).
503
504         * TestResultServer/static-dashboards/flakiness_dashboard.js:
505
506 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
507
508         Fix webkitpy tests after r147678.
509
510         * Scripts/webkitpy/tool/commands/queues_unittest.py:
511         (CommitQueueTest.test_commit_queue):
512         (test_manual_reject_during_processing):
513
514 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
515
516         The commit queue should use Mac MountainLion port
517         https://bugs.webkit.org/show_bug.cgi?id=113971
518
519         Reviewed by Lucas Forschler.
520
521         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
522         * Scripts/webkitpy/tool/commands/queues.py:
523         (CommitQueue):
524
525 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
526
527         turn off running tests on chromium linux EWS bots
528         https://bugs.webkit.org/show_bug.cgi?id=113959
529
530         Reviewed by Geoffrey Garen.
531
532         Now that the Chromium port is no longer being maintained
533         there's little point in running the tests. Soon we should
534         just shut this bot off altogether.
535
536         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
537         (ChromiumLinuxEWS):
538
539 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
540
541         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
542
543         * Scripts/webkitpy/common/config/watchlist:
544
545 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
546
547         Indentation fix to get webkit-patch working again after r147625
548
549         Unreviewed.
550
551         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
552         (MacEWS):
553         (MacWK2EWS):
554
555 2013-04-04  Lucas Forschler  <lforschler@apple.com>
556
557         Turn tests back on for Mac WK1/WK2 EWS.
558         
559         Unreviewed.
560         
561         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
562         (MacEWS):
563         (MacWK2EWS):
564
565 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
566
567         [GTK][WK2] MiniBrowser custom URI scheme support
568         https://bugs.webkit.org/show_bug.cgi?id=112419
569
570         Reviewed by Carlos Garcia Campos.
571
572         Add support for about URIs in MiniBrowser. An example about page is show
573         with URI "about:minibrowser", the rest of the cases it will show a
574         proper message explaining that the about page didn't exist.
575
576         Internally it uses "minibrowser-about" prefix instead of "about", but
577         from the user point of view it works with "about" prefix.
578
579         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
580         (getInternalURI): Method to convert URIs from "about" prefix to
581         "minibrowser-about".
582         (getExternalURI): Opposite method.
583         (webViewURIChanged): Use "about" prefix to show the URI to users.
584         (webViewEnterFullScreen): Ditto.
585         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
586         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
587         (aboutURISchemeRequestCallback): Callback to manage about calls.
588         (main): Register the URI scheme to manage about URIs.
589
590 2013-04-03  Roger Fong  <roger_fong@apple.com>
591
592         Re-enable WinEWS tests.
593
594         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
595         (WinEWS):
596
597 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
598
599         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
600         https://bugs.webkit.org/show_bug.cgi?id=113883
601
602         Reviewed by Martin Robinson.
603
604         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
605         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
606         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
607
608 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
609
610         [GTK] Include Pango in jhbuild-optional.modules
611         https://bugs.webkit.org/show_bug.cgi?id=113878
612
613         Reviewed by Martin Robinson.
614
615         Since r147547 Pango 1.32.0 is required. Including the module in the
616         JHBuild optional moduleset.
617
618         * gtk/jhbuild-optional.modules: Add Pango module.
619
620 2013-04-03  Zeno Albisser  <zeno@webkit.org>
621
622         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
623         https://bugs.webkit.org/show_bug.cgi?id=113864
624
625         Moving setDefersLoading from TestRunnerQt to TestRunner
626         requires access to the non-Qt TestRunner.
627         As long as we instantiate both TestRunner and TestRunnerQt,
628         we need a separate getter for the non-Qt TestRunner instance.
629
630         Reviewed by Simon Hausmann.
631
632         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
633         (WebPage::resetSettings):
634         * DumpRenderTree/qt/DumpRenderTreeQt.h:
635         (DumpRenderTree::jscTestRunner):
636         * DumpRenderTree/qt/TestRunnerQt.cpp:
637         (TestRunner::setDefersLoading):
638             Moving setDefersLoading from TestRunnerQt
639             to TestRunner.
640         * DumpRenderTree/qt/TestRunnerQt.h:
641         (TestRunnerQt):
642
643 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
644
645         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
646         https://bugs.webkit.org/show_bug.cgi?id=104779
647
648         Reviewed by Carlos Garcia Campos.
649
650         * Scripts/run-gtk-tests:
651         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
652         passing in current trunk.
653
654 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
655
656         Fix HAVE(QTTESTSUPPORT) logic
657
658         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
659         resulting in HAVE(QTTESTSUPPORT) never being true.
660         Move that logic down in sanitizeFeatures.
661
662         Rubber-stamped by Tor Arne Vestbø.
663
664         * qmake/mkspecs/features/features.prf:
665
666 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
667
668         [GTK] Bump required versions of some dependencies
669         https://bugs.webkit.org/show_bug.cgi?id=113282
670
671         Reviewed by Martin Robinson.
672
673         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
674
675 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
676
677         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
678         https://bugs.webkit.org/show_bug.cgi?id=113809
679
680         Reviewed by Philippe Normand.
681
682         Newer Linux kernels have removed some deprecated macros from v4l2
683         headers, causing gst-plugins-good's build to break. We don't need it
684         right now, so just disable it.
685
686         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
687
688 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
689
690         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
691         https://bugs.webkit.org/show_bug.cgi?id=113535
692
693         Reviewed by Simon Hausmann.
694
695         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
696
697         * qmake/mkspecs/features/features.prf:
698
699 2013-04-03  Zeno Albisser  <zeno@webkit.org>
700
701         [Qt] Move logic of simple forwarding functions to TestRunner.
702         https://bugs.webkit.org/show_bug.cgi?id=113863
703
704         Reviewed by Simon Hausmann.
705
706         * DumpRenderTree/qt/TestRunnerQt.cpp:
707         (TestRunner::setTextDirection):
708         (TestRunner::goBack):
709         (TestRunner::evaluateScriptInIsolatedWorld):
710         (TestRunner::addUserStyleSheet):
711         * DumpRenderTree/qt/TestRunnerQt.h:
712         (TestRunnerQt):
713
714 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
715
716         [Qt] Disable media support using QuickTime if deployment target != SDK
717
718         We link to a single libWebKitSystemInterface static lib, so unless the
719         deployment target matches the SDK let's not pretend like we'll be able
720         to run on anything lower than the SDK version.
721
722         Reviewed by Simon Hausmann.
723
724         * qmake/mkspecs/features/features.prf:
725
726 2013-04-02  James Craig  <james@cookiecrook.com>
727
728         AXRoleDescripton for DL is "list"; should be "description list"
729         https://bugs.webkit.org/show_bug.cgi?id=111665
730
731         Reviewed by Chris Fleizach.
732
733         Defining the role and description strings.
734
735         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
736
737 2013-04-02  Roger Fong  <roger_fong@apple.com>
738
739         Unreviewed. Disable running tests on Win EWS queue.
740
741         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
742         (WinEWS):
743
744 2013-04-02  Lucas Forschler  <lforschler@apple.com>
745
746         Disable running tests on the MAC WK2 EWS queue.
747         
748         Unreviewed.
749         
750         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
751         (MacWK2EWS):
752
753 2013-04-02  Julie Parent  <jparent@chromium.org>
754
755         Dashboard refactor: Move dashboard specific history related features to History.
756         https://bugs.webkit.org/show_bug.cgi?id=113717
757
758         Reviewed by Ojan Vafai.
759         
760         Each dashboard now creates its own History object, with a custom
761         configuration. This changes from just overriding global functions
762         to passing in callbacks for generatePage, handleValidHashParameter,
763         and handleQueryParameterChange. Same with passing in defaultStateValues
764         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
765         variables.
766         
767         All functions related to these features are now (mostly) private
768         function on History. 
769         
770         Loader no longer needs a loadingComplete callback, since it can just
771         initialize the history object itself.
772
773         * TestResultServer/static-dashboards/aggregate_results.js:
774         (handleValidHashParameter):
775         * TestResultServer/static-dashboards/dashboard_base.js:
776         * TestResultServer/static-dashboards/flakiness_dashboard.js:
777         (generatePage):
778         (.switch.return):
779         (handleQueryParameterChange):
780         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
781         (resetGlobals):
782         * TestResultServer/static-dashboards/history.js:
783         (.):
784         * TestResultServer/static-dashboards/loader.js:
785         (.):
786         * TestResultServer/static-dashboards/loader_unittests.js:
787         * TestResultServer/static-dashboards/timeline_explorer.js:
788         (generatePage):
789         (initCurrentBuilderTestResults):
790         * TestResultServer/static-dashboards/treemap.js:
791         (generatePage):
792         (.switch.return):
793         (handleQueryParameterChange):
794
795 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
796
797         Unreviewed, rolling out r147401.
798         http://trac.webkit.org/changeset/147401
799         https://bugs.webkit.org/show_bug.cgi?id=113767
800
801         The patch makes it extremely hard to set up the dependencies
802         properly on the GTK builders (Requested by zdobersek on
803         #webkit).
804
805         * gtk/jhbuild.modules:
806
807 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
808
809         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
810         https://bugs.webkit.org/show_bug.cgi?id=113382
811
812         Reviewed by Gyuyoung Kim.
813
814         Do not show the empty tooltip box if the text is null.
815
816         * MiniBrowser/efl/main.c:
817         (popup_menu_populate):
818
819 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
820
821         [GTK] Bump required versions of some dependencies
822         https://bugs.webkit.org/show_bug.cgi?id=113282
823
824         Reviewed by Martin Robinson.
825
826         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
827
828 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
829
830         Unreviewed, rolling out r147319.
831         http://trac.webkit.org/changeset/147319
832         https://bugs.webkit.org/show_bug.cgi?id=113707
833
834         The unit test is still failing on the buildbot (Requested by
835         zdobersek on #webkit).
836
837         * Scripts/run-gtk-tests:
838         (TestRunner):
839
840 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
841
842         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
843         https://bugs.webkit.org/show_bug.cgi?id=104779
844
845         Reviewed by Carlos Garcia Campos.
846
847         * Scripts/run-gtk-tests:
848         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
849         passing in current trunk.
850
851 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
852
853         Unreviewed, rolling out r147289.
854         http://trac.webkit.org/changeset/147289
855         https://bugs.webkit.org/show_bug.cgi?id=113678
856
857         broke Win7 (dbg) build (Requested by shinyak|gardener on
858         #webkit).
859
860         * DumpRenderTree/DumpRenderTree.gypi:
861         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
862         (WebTestRunner):
863         (WebUserMediaClientMock):
864         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
865         (WebTestRunner::WebUserMediaClientMock::taskList):
866         * Scripts/webkitpy/style/checkers/cpp.py:
867         (check_function_definition):
868
869 2013-03-31  Adam Barth  <abarth@webkit.org>
870
871         configure-svn-config.sh fails
872         https://codereview.chromium.org/13392007/
873
874         Reviewed by Eric Seidel.
875
876         This script was trying to use "svn checkout" to dowload a file from
877         svn.webkit.org, but "svn checkout" only works with directories.
878         Instead, we should use "svn export".
879
880         * EWSTools/configure-svn-config.sh:
881
882 2013-03-31  Wei Jia  <wjia@chromium.org>
883
884         Allow WebUserMediaClientMock to be used by client
885         https://bugs.webkit.org/show_bug.cgi?id=113633
886
887         Reviewed by Adam Barth.
888
889         Export WebUserMediaClientMock.
890         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
891
892         * DumpRenderTree/DumpRenderTree.gypi:
893         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
894         (WebUserMediaClientMock):
895         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
896         * Scripts/webkitpy/style/checkers/cpp.py:
897         (check_function_definition):
898
899 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
900
901         Expose FeatureObserver data to WebKit clients
902         https://bugs.webkit.org/show_bug.cgi?id=113613
903
904         Reviewed by Sam Weinig.
905
906         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
907         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
908
909 2013-03-29  Greg Hughes  <ghughes@apple.com>
910
911         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
912         https://bugs.webkit.org/show_bug.cgi?id=112276
913
914         Reviewed by Chris Fleizach.
915
916         Added support to test accessibility search predicates with multiple keys.  
917
918         * DumpRenderTree/AccessibilityUIElement.cpp:
919         (uiElementForSearchPredicateCallback):
920         * DumpRenderTree/AccessibilityUIElement.h:
921         (AccessibilityUIElement):
922         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
923         (AccessibilityUIElement::uiElementForSearchPredicate):
924         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
925         (AccessibilityUIElement::uiElementForSearchPredicate):
926         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
927         (AccessibilityUIElement::uiElementForSearchPredicate):
928         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
929         (AccessibilityUIElement::uiElementForSearchPredicate):
930         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
931         (AccessibilityUIElement::uiElementForSearchPredicate):
932         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
933         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
934         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
935         (AccessibilityUIElement):
936         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
937         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
938         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
939         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
940         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
941
942 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
943
944         Fix a typo in r147147 to fix Mac EWS.
945
946         * Scripts/webkitpy/tool/commands/queues.py:
947         (PatchProcessingQueue._new_port_name_from_old):
948
949 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
950
951         [EFL] Build break with latest EFL libraries after r146265
952         https://bugs.webkit.org/show_bug.cgi?id=113558
953
954         Unreviewed build fix.
955
956         * TestWebKitAPI/PlatformWebView.h:
957         * WebKitTestRunner/PlatformWebView.h:
958
959 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
960
961         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
962
963         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
964         in libgcrypt build.
965
966 2013-03-28  Lucas Forschler  <lforschler@apple.com>
967
968         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
969
970         Unreviewed.
971
972         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
973         (MacEWS):
974
975 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
976
977         Use the right OS name on Mac EWS instead of mac-future.
978
979         Rubber-stamped by Dirk Pranke.
980
981         * Scripts/webkitpy/tool/commands/queues.py:
982         (PatchProcessingQueue._new_port_name_from_old):
983         (PatchProcessingQueue.begin_work_queue):
984         (PatchProcessingQueue._upload_results_archive_for_patch):
985
986 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
987
988         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
989         https://bugs.webkit.org/show_bug.cgi?id=112546
990
991         Reviewed by Martin Robinson.
992
993         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
994         moved back to Source/WebCore/platform. Fix an indentation issue as well.
995
996 2013-03-28  Ming Xie  <mxie@blackberry.com>
997
998         [BlackBerry] Committer Email Updates
999         https://bugs.webkit.org/show_bug.cgi?id=113435
1000
1001         Reviewed by Rob Buis.
1002
1003         Add the @blackberry.com email address for all our BlackBerry
1004         WebKit committers. This is the first step for our email address
1005         migration.
1006
1007         * Scripts/webkitpy/common/config/committers.py:
1008
1009 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1010
1011         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1012         https://bugs.webkit.org/show_bug.cgi?id=113508
1013
1014         Reviewed by Martin Robinson.
1015
1016         Prevent the GStreamer plugin scanner to load system-wide
1017         plugins. Only the ones built in JHBuild should be loaded and used
1018         at runtime.
1019
1020         * efl/jhbuildrc:
1021         * gtk/jhbuildrc:
1022
1023 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1024
1025         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1026         https://bugs.webkit.org/show_bug.cgi?id=113386
1027
1028         Reviewed by Carlos Garcia Campos.
1029
1030         * Scripts/webkitdirs.pm:
1031         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1032         version to 3.0. Reflect this change so the builtDylibPathForName
1033         function doesn't fail to report the library as found.
1034
1035 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1036
1037         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1038         https://bugs.webkit.org/show_bug.cgi?id=113484
1039
1040         Unreviewed build fix.
1041
1042         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1043
1044         * TestWebKitAPI/CMakeLists.txt:
1045         * WebKitTestRunner/CMakeLists.txt:
1046
1047 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1048
1049         Revision for the internal jhbuild is too old
1050         https://bugs.webkit.org/show_bug.cgi?id=113324
1051
1052         Reviewed by Martin Robinson.
1053
1054         Update the minimum required version to a point where jhbuild won't
1055         fail installing packages when trying to remove a symlink to a directory.
1056
1057         * jhbuild/jhbuild-wrapper: Updated revision.
1058
1059 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1060
1061         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1062         https://bugs.webkit.org/show_bug.cgi?id=113203
1063
1064         Reviewed by Philippe Normand.
1065
1066         We build our libsoup without GNOME support. gst-plugins-good does separate
1067         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1068         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1069         build failures as the headers of those diverge. We do not use souphttpsrc, so
1070         disable it when building gst-plugins-good.
1071
1072         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1073
1074 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1075
1076         Build fix after r146852. Please another reference to the Lion leaks builder.
1077
1078         * BuildSlaveSupport/build.webkit.org-config/config.json:
1079
1080 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1081
1082         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1083         https://bugs.webkit.org/show_bug.cgi?id=113421
1084
1085         Reviewed by Dirk Pranke.
1086
1087         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1088         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1089         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1090         in the GTK-specific TestExpectations files.
1091
1092         To avoid this only enable the warnings only when not using WKTR.
1093
1094         * Scripts/webkitpy/layout_tests/port/gtk.py:
1095         (GtkPort.warn_if_bug_missing_in_test_expectations):
1096
1097 2013-03-27  Antti Koivisto  <antti@apple.com>
1098
1099         Fix Zalan's email.
1100
1101         * Scripts/webkitpy/common/config/committers.py:
1102
1103 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1104
1105         master.cfg cleanup
1106         https://bugs.webkit.org/show_bug.cgi?id=113195
1107
1108         Reviewed by Ryosuke Niwa.
1109
1110         * BuildSlaveSupport/build.webkit.org-config/config.json:
1111         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1112
1113 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1114
1115         master.cfg fine-tuning for Qt Mountain Lion Release bot
1116         https://bugs.webkit.org/show_bug.cgi?id=113191
1117
1118         Reviewed by Ryosuke Niwa.
1119
1120         * BuildSlaveSupport/build.webkit.org-config/config.json:
1121           - Rename the slave due to its location change.
1122           - Update the platform of the slave.
1123         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1124         (RunQtAPITests): Enable running WK2 API tests on Qt.
1125         (RunQtAPITests.start):
1126         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1127         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1128
1129 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1130
1131         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1132         https://bugs.webkit.org/show_bug.cgi?id=113403
1133
1134         Reviewed by Kenneth Rohde Christiansen.
1135
1136         As of Evas 1.7.5, when Wayland is detected on the system, support for
1137         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1138         The code, however, seems to depend on a few other flags which must be
1139         explicitly enabled.
1140
1141         If those additional GL-related options are passed, we end up
1142         having issues on the WebKit side, so disable Wayland support for
1143         now.
1144
1145         * efl/jhbuild.modules:
1146
1147 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1148
1149         Unreviewed, rolling out r146864.
1150         http://trac.webkit.org/changeset/146864
1151         https://bugs.webkit.org/show_bug.cgi?id=113391
1152
1153         causes crashes on Wk2 EFL release bot (Requested by drott on
1154         #webkit).
1155
1156         * Scripts/webkitperl/FeatureList.pm:
1157
1158 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1159
1160         [jhbuild] Correctly specify an alternate number of make jobs.
1161         https://bugs.webkit.org/show_bug.cgi?id=113396
1162
1163         Reviewed by Philippe Normand.
1164
1165         So far, we were using the `MAKEFLAGS' environment variable to pass the
1166         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1167         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1168
1169         We now behave more closely to the rest of the WebKit tools by first
1170         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1171         not set, just letting jhbuild itself figure out how many jobs to use.
1172
1173         * efl/jhbuildrc:
1174         * gtk/jhbuildrc:
1175
1176 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1177
1178         [Qt] Remove Qt specific WorkQueueItem definitions.
1179         https://bugs.webkit.org/show_bug.cgi?id=112891
1180
1181         This patch is preparation work for removing
1182         WorkQueue related code from TestRunnerQt and
1183         replacing it with generic TestRunner code.
1184
1185         Reviewed by Benjamin Poulain.
1186
1187         * DumpRenderTree/qt/TestRunnerQt.cpp:
1188         (TestRunnerQt::queueBackNavigation):
1189         (TestRunnerQt::queueForwardNavigation):
1190         (TestRunnerQt::queueLoadHTMLString):
1191         (TestRunnerQt::queueReload):
1192         (TestRunnerQt::queueLoadingScript):
1193         (TestRunnerQt::queueNonLoadingScript):
1194         (TestRunner::queueLoad):
1195         * DumpRenderTree/qt/TestRunnerQt.h:
1196         (TestRunnerQt):
1197         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1198         (LoadItem::invoke):
1199         (LoadHTMLStringItem::invoke):
1200         (LoadAlternateHTMLStringItem::invoke):
1201         (ReloadItem::invoke):
1202         (ScriptItem::invoke):
1203         (BackForwardItem::invoke):
1204         * DumpRenderTree/qt/WorkQueueItemQt.h:
1205         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1206         (LoadAlternateHTMLStringItem):
1207
1208 2013-03-26  Julie Parent  <jparent@chromium.org>
1209
1210         Flakiness dashboard: simplify logic around which tests to show.
1211         https://bugs.webkit.org/show_bug.cgi?id=113250
1212
1213         Reviewed by Ojan Vafai.
1214         
1215         The different filters for showing results are only used for layout
1216         tests, otherwise, we show everything.
1217         
1218         Change the defaults to false (what layout tests used), and only
1219         look at the values when viewing layout tests.
1220
1221         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1222         (htmlForTestsWithExpectationsButNoFailures):
1223         (shouldHideTest):
1224
1225 2013-03-26  Isaac Levy  <ilevy@google.com>
1226
1227         Update bots on test-results.appspot
1228         https://bugs.webkit.org/show_bug.cgi?id=113333
1229
1230         Reviewed by Ojan Vafai.
1231
1232         * TestResultServer/static-dashboards/builders.jsonp:
1233
1234 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1235
1236         Unreviewed GTK gardening.
1237
1238         * Scripts/run-gtk-tests:
1239         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1240
1241 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1242
1243         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1244         https://bugs.webkit.org/show_bug.cgi?id=113287
1245
1246         Reviewed by Jocelyn Turcotte.
1247
1248         * Scripts/run-qtwebkit-tests:
1249         (Options.__init__):
1250
1251 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1252
1253         [EFL] Enable IndexedDB by default
1254         https://bugs.webkit.org/show_bug.cgi?id=107248
1255
1256         Reviewed by Laszlo Gombos.
1257
1258         * Scripts/webkitperl/FeatureList.pm:
1259         Enable IndexedDB by default on EFL.
1260
1261 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1262
1263         Sheriffbot should explain rollout failures in a human readable form.
1264         https://bugs.webkit.org/show_bug.cgi?id=107092
1265
1266         Reviewed by Ryosuke Niwa.
1267
1268         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1269
1270         * Scripts/webkitpy/tool/bot/irc_command.py:
1271         (Rollout._check_diff_failure):
1272         (Rollout.execute):
1273         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1274         (IRCCommandTest.test_rollout):
1275
1276 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1277
1278         Unreviewed GTK gardening.
1279
1280         * Scripts/run-gtk-tests:
1281         (TestRunner): Skipping a failing unit test after r146518.
1282
1283 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1284
1285         Remove Lion leaks builder
1286         https://bugs.webkit.org/show_bug.cgi?id=113252
1287
1288         Reviewed by Andreas Kling.
1289
1290         Removed.
1291
1292         * BuildSlaveSupport/build.webkit.org-config/config.json:
1293
1294 2013-03-25  Kent Tamura  <tkent@chromium.org>
1295
1296         Rename ENABLE_INPUT_TYPE_DATETIME
1297         https://bugs.webkit.org/show_bug.cgi?id=113254
1298
1299         Reviewed by Kentaro Hara.
1300
1301         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1302         Actually I'd like to remove the code, but we shouldn't remove it yet
1303         because we shipped products with it on some platforms.
1304
1305         * Scripts/webkitperl/FeatureList.pm:
1306         * qmake/mkspecs/features/features.pri:
1307
1308 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1309
1310         Remove one more line that was intended to be removed in r146657.
1311
1312         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1313         (summarize_results):
1314
1315 2013-03-25  Roger Fong  <roger_fong@apple.com>
1316
1317         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1318         Re-enable WinEWS tests.
1319
1320         * Scripts/webkitpy/common/config/ports.py:
1321         (WinPort.run_bindings_tests_command):
1322         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1323         (WinEWS):
1324
1325 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1326
1327         Unreviewed, rolling out r146793.
1328         http://trac.webkit.org/changeset/146793
1329         https://bugs.webkit.org/show_bug.cgi?id=113248
1330
1331         Fix did not work (Requested by rfong on #webkit).
1332
1333         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1334         (WinEWS):
1335
1336 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1337
1338         REGRESSION(r146657): Test failures reported incorrectly
1339         https://bugs.webkit.org/show_bug.cgi?id=113223
1340
1341         Reviewed by Dirk Pranke.
1342
1343         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1344
1345         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1346         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1347
1348         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1349         (Manager.run):
1350
1351         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1352         (RunDetails.__init__):
1353         (summarize_results): Remove the line I intended to remove in r146657.
1354
1355         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1356         (logging_run): Return details instead of the exit code.
1357         (run_and_capture): Ditto.
1358
1359         (RunTest.test_full_results_html):
1360         (RunTest.test_hung_thread):
1361         (RunTest.test_no_tests_found):
1362         (RunTest.test_no_tests_found_2):
1363         (RunTest.test_repeat_each_iterations_num_tests):
1364         (RunTest.test_run_singly_actually_runs_tests):
1365         (RunTest.test_test_list):
1366         (RunTest.test_missing_and_unexpected_results):
1367         (RunTest.test_pixel_test_directories):
1368         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1369         (RunTest.test_crash_with_stderr):
1370         (RunTest.test_no_image_failure_with_image_diff):
1371         (RunTest.test_crash_log):
1372         (RunTest.test_exit_after_n_failures_upload):
1373         (RunTest.test_results_directory_absolute):
1374         (RunTest.test_results_directory_relative):
1375         (RunTest.test_retrying_and_flaky_tests):
1376         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1377         (RunTest.test_retrying_uses_retries_directory):
1378         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1379         (RunTest.test_output_diffs):
1380         (EndToEndTest.test_reftest_with_two_notrefs):
1381         (RebaselineTest.test_reset_results):
1382         (RebaselineTest.test_missing_results):
1383         (RebaselineTest.test_new_baseline):
1384
1385         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1386         (BuildBotPrinter.print_results):
1387         (BuildBotPrinter.print_unexpected_results):
1388         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1389         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1390
1391 2013-03-25  Julie Parent  <jparent@chromium.org>
1392
1393         Dashboard refactor: Move cross dashboard history related code into history.js.
1394         https://bugs.webkit.org/show_bug.cgi?id=113104
1395
1396         Reviewed by Ojan Vafai.
1397
1398         All functions relating to cross dashboard behavior move from being
1399         globals to methods on the history.History object. Names stay the same,
1400         except many are made private, ones that should have been constants now
1401         are, and the long standing TODO to change "currentState" to 
1402         dashboardSpecificState is done.
1403         
1404         We now create a global history object in dashboard_base, as an 
1405         intermediate measure.  Once the dashboard specific code is
1406         added to history, each DB will need to create its own, and this
1407         global will be eliminated.
1408         
1409         * TestResultServer/static-dashboards/aggregate_results.js:
1410         (handleValidHashParameter):
1411         (htmlForBuilder):
1412         (rawValuesHTML):
1413         * TestResultServer/static-dashboards/dashboard_base.js:
1414         (parseDashboardSpecificParameters):
1415         (defaultValue):
1416         (currentBuilderGroupCategory):
1417         (currentBuilderGroupName):
1418         (handleLocationChange):
1419         (expectationsMap):
1420         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1421         (generatePage):
1422         (.switch.return):
1423         (platformAndBuildType):
1424         (individualTests):
1425         (substringList):
1426         (processMissingAndExtraExpectations):
1427         (pathToFailureLog):
1428         (showPopupForBuild):
1429         (htmlForTestsWithExpectationsButNoFailures):
1430         (shouldHideTest):
1431         (isCrossBuilderView):
1432         (tableHeaders):
1433         (htmlForSingleTestRow):
1434         (htmlForTableColumnHeader):
1435         (generatePageForExpectationsUpdate):
1436         (handleUpdate):
1437         (nextUpdate):
1438         (setUpdateIndex):
1439         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1440         (.appendExpectationsItem):
1441         (loadExpectations):
1442         (.dummyNode.onload):
1443         (loadExpectationsLayoutTests):
1444         (appendExpectations):
1445         (htmlForNavBar):
1446         (checkBoxToToggleState):
1447         (linkHTMLToToggleState):
1448         (generatePageForBuilder):
1449         (isInvalidKeyForCrossBuilderView):
1450         (handleQueryParameterChange):
1451         (showLegend):
1452         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1453         (resetGlobals):
1454         (test):
1455         * TestResultServer/static-dashboards/history.js:
1456         (.):
1457         * TestResultServer/static-dashboards/history_unittests.js:
1458         * TestResultServer/static-dashboards/loader.js:
1459         (.):
1460         * TestResultServer/static-dashboards/loader_unittests.js:
1461         * TestResultServer/static-dashboards/timeline_explorer.js:
1462         (generatePage):
1463         (initCurrentBuilderTestResults):
1464         (selectBuild):
1465         (showResultsDelta):
1466         * TestResultServer/static-dashboards/treemap.js:
1467         (generatePage):
1468         (.switch.return):
1469         (handleFocus):
1470         * TestResultServer/static-dashboards/ui.js:
1471
1472 2013-03-25  Roger Fong  <roger_fong@apple.com>
1473
1474         Unreviewed. Enable WinEWS tests again.
1475
1476         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1477         (WinEWS):
1478
1479 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1480
1481         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1482         https://bugs.webkit.org/show_bug.cgi?id=112166
1483
1484         HarfBuzz 0.9.14 merged my patch for icu detection without
1485         pkg-config files, as needed by for example Ubuntu 12.04.
1486         This obsoletes our local workaround. Removed it for GTK and EFL.
1487
1488         Reviewed by Martin Robinson.
1489
1490         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1491         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1492         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1493         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1494
1495 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1496
1497         Unreviewed.  Move self from contributor to committer list.
1498
1499         * Scripts/webkitpy/common/config/committers.py:
1500
1501 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1502
1503         EWS should use a human readable port name when uploading layout test archives
1504         https://bugs.webkit.org/show_bug.cgi?id=113099
1505
1506         Reviewed by Dirk Pranke.
1507
1508         Use new port's object's name() method to report human readable port names.
1509         This will also help us resolving the bug to apply layout test results posted by EWS.
1510
1511         * Scripts/webkitpy/tool/bot/botinfo.py:
1512         (BotInfo.__init__): Take port's name.
1513         (BotInfo.summary_text):
1514
1515         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1516         (BotInfoTest.test_summary_text):
1517
1518         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1519         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1520
1521         * Scripts/webkitpy/tool/commands/queues.py:
1522         (PatchProcessingQueue.__init__): Initialize self._port.
1523         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1524         and use that for the attachment filename and the comment posted.
1525
1526         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1527         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1528         "mac-snowleopard" as expected for TestPort.
1529
1530 2013-03-22  Roger Fong  <roger_fong@apple.com>
1531
1532         Unreviewed. Turn off EWS test on Win again.
1533         The battle continues.
1534
1535         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1536         (WinEWS):
1537
1538 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1539
1540         NRWT: Enable pixel tests when retrying tests
1541         https://bugs.webkit.org/show_bug.cgi?id=112898
1542
1543         Reviewed by Dirk Pranke.
1544
1545         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1546         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1547         if we've forced pixel tests in the retry.
1548         (Manager._run_tests):
1549         (Manager._clean_up_run): Fixed the capitalizations.
1550         (Manager._force_pixel_tests_if_needed): Added.
1551
1552         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1553         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1554         'image_diff_percent' if it doesn't already exist.
1555
1556         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1557         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1558         treat this as a regular regression instead of a flakiness.
1559
1560         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1561         run had image diffs.
1562
1563         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1564         (summarized_results):
1565
1566         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1567         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1568         Also removed some dead code.
1569
1570         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1571         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1572         is set and pixel_tests_enabled is set to false.
1573         (EndToEndTest.test_reftest_with_two_notrefs):
1574
1575 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1576
1577         Make it possible to run layout tests on Retina MBP
1578         https://bugs.webkit.org/show_bug.cgi?id=93673
1579
1580         Reviewed by Ryosuke Niwa.
1581
1582         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1583         windows on 2x machines still run at 1x.
1584
1585         * DumpRenderTree/mac/DumpRenderTree.mm:
1586         (createWebViewAndOffscreenWindow):
1587         Reset the window resolution to 1x on creation.
1588         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
1589         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1590         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
1591         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1592         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
1593         (WTR::PlatformWebView::PlatformWebView):
1594         Add NSWindow details, reset the window resolution to 1x on creation.
1595
1596 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1597
1598         Leak bots shouldn't build
1599         https://bugs.webkit.org/show_bug.cgi?id=112774
1600
1601         Reviewed by Simon Fraser.
1602
1603         Since leak bots use regular debug builds, there is no need to build on these bots.
1604         Simply downloading builds will dramatically improve the cycle time of these bots.
1605
1606         * BuildSlaveSupport/build.webkit.org-config/config.json:
1607         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1608         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
1609         TestFactory instead of BuildAndTestFactory.
1610
1611 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1612
1613         [Qt] Fix the TestWebKitAPI build
1614         https://bugs.webkit.org/show_bug.cgi?id=113044
1615
1616         Reviewed by Tor Arne Vestbø.
1617
1618         The generate-forwarding-headers script would only be run
1619         after the targets in InjectedBundle.pri since the second
1620         addStrictSubdirOrderBetween call in
1621         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
1622         the derived_sources -> injected_bundle order in SUBDIRS.
1623
1624         Fix it by only moving the dependent target at the end of
1625         SUBDIRS, don't touch its dependency.
1626
1627         * qmake/mkspecs/features/functions.prf:
1628
1629 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1630
1631         [EFL][WK2] View is not focused when fullscreen mode toggled
1632         https://bugs.webkit.org/show_bug.cgi?id=113009
1633
1634         Reviewed by Laszlo Gombos.
1635
1636         Set focus on view when fullscreen mode enabled/disabled
1637         by FullScreen API.
1638
1639         * MiniBrowser/efl/main.c:
1640         (on_fullscreen_accept):
1641         (on_fullscreen_deny):
1642
1643 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1644
1645         nrwt is no longer saving retry results in the retries/ subdirectory
1646         https://bugs.webkit.org/show_bug.cgi?id=112995
1647
1648         Reviewed by Ojan Vafai.
1649
1650         I think this has been broken a long time, unfortunately. This
1651         patch should fix that.
1652
1653         In order to do so, I had to pass the directory to use from
1654         the Worker object through the SingleTestWriter to the
1655         TestResultWriter. While I was plumbing that through, I rationalized
1656         the order of the parameter arguments a bit ...
1657
1658         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1659         (Worker._run_single_test):
1660         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1661         (run_single_test):
1662         (SingleTestRunner.__init__):
1663         (SingleTestRunner._run_compare_test):
1664         (SingleTestRunner._run_rebaseline):
1665         (SingleTestRunner._run_reftest):
1666         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1667         (write_test_result):
1668         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1669         (TestResultWriterTest.test_reftest_diff_image):
1670         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1671         (RunTest.test_retrying_uses_retries_directory):
1672
1673 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
1674
1675         JSC profiler should have an at-a-glance report of the success of DFG optimization
1676         https://bugs.webkit.org/show_bug.cgi?id=112988
1677
1678         Reviewed by Geoffrey Garen.
1679
1680         * Scripts/display-profiler-output:
1681
1682 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1683
1684         [chromium] Linux ASAN WebKit canary is running out of memory
1685         https://bugs.webkit.org/show_bug.cgi?id=112978
1686
1687         Reviewed by Tony Chang.
1688
1689         Running the AddressSanitizer on a crash takes a lot of
1690         memory, so we should serialize access to it to avoid running
1691         out of memory on a machine.
1692
1693         * Scripts/webkitpy/layout_tests/port/chromium.py:
1694         (ChromiumPort._get_crash_log):
1695         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1696         (HttpLock.__init__):
1697         (HttpLock.wait_for_httpd_lock):
1698
1699 2013-03-21  Min Qin  <qinmin@chromium.org>
1700
1701         Cleanup android media layout test code
1702         https://bugs.webkit.org/show_bug.cgi?id=112944
1703
1704         Reviewed by Adam Barth.
1705
1706         Chromium change: https://codereview.chromium.org/12892010/
1707         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
1708         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
1709         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
1710         Instead, we should switch to use content shell for layout tests.
1711
1712         * DumpRenderTree/chromium/TestShell.cpp:
1713         (TestShell::resetTestController):
1714
1715 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1716
1717         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
1718         https://bugs.webkit.org/show_bug.cgi?id=112953
1719
1720         Reviewed by Tony Chang.
1721
1722         When I created the DumpRenderTree_resources target in r144863 I
1723         forgot to declare the needed dependencies on the other resource
1724         targets. Due to a quirk of ordering, this appears to have been fine
1725         w/ ninja but not w/ Xcode (which is still being used on the chromium
1726         mac valgrind bots). Declaring the dependencies fixes the build
1727         failures.
1728
1729         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1730
1731 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
1732
1733         [WinCairo] Correct assert in Empty BitmapImage Test.
1734         https://bugs.webkit.org/show_bug.cgi?id=112934
1735
1736         Reviewed by Tim Horton.
1737
1738         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1739         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
1740         to avoid ref counting assertion when leaving test scope.
1741
1742 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
1743
1744         [GTK] generate-feature-defines-files is incompatible with Python3
1745         https://bugs.webkit.org/show_bug.cgi?id=112956
1746
1747         Reviewed by Martin Robinson.
1748
1749         Make the generate-feature-defines-files compatible with Python3 by calling the items()
1750         method on the dictionary objects when iterating through said dictionaries.
1751
1752         * gtk/generate-feature-defines-files:
1753         (write_feature_defines_header):
1754         (write_flattened_feature_defines_file):
1755
1756 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1757
1758         kill-old-processes spits out error messages on Mac
1759         https://bugs.webkit.org/show_bug.cgi?id=112878
1760
1761         Reviewed by Jessie Berlin.
1762
1763         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
1764         included in the list of options grep --help shows.
1765
1766         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
1767
1768         * BuildSlaveSupport/kill-old-processes:
1769         (main):
1770
1771 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
1772
1773         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
1774         https://bugs.webkit.org/show_bug.cgi?id=112597
1775
1776         Reviewed by Xan Lopez.
1777
1778         These were introduced for the Chromium port in r105295. We need
1779         dummy implementations in order to compile the BlackBerry port.
1780
1781         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1782         (AccessibilityUIElement::scrollToMakeVisible):
1783         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1784         (AccessibilityUIElement::scrollToGlobalPoint):
1785
1786 2013-03-21  Roger Fong  <roger_fong@apple.com>
1787
1788         Re-enable WinEWS tests following r146376.
1789
1790         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1791         (WinEWS):
1792
1793 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
1794
1795         Unreviewed. Add Bem Jones-Bey to the list of contributors.
1796
1797         * Scripts/webkitpy/common/config/committers.py:
1798
1799 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1800
1801         [GTK] Missing atk in install-dependencies script
1802         https://bugs.webkit.org/show_bug.cgi?id=112272
1803
1804         Reviewed by Gustavo Noronha Silva.
1805
1806         * gtk/install-dependencies: Add missing atk dependency.
1807
1808 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1809
1810         [GTK] Missing backslash in install-dependencies script
1811         https://bugs.webkit.org/show_bug.cgi?id=112907
1812
1813         Reviewed by Philippe Normand.
1814
1815         * gtk/install-dependencies: Add missing backslash to dependencies
1816         list.
1817
1818 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1819
1820         EWS bots have stopped uploading results to bugzilla
1821         https://bugs.webkit.org/show_bug.cgi?id=101091
1822
1823         Reviewed by Adam Barth.
1824
1825         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
1826         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
1827         this relative file path resoled to a file inside a non-existent directory for "zip".
1828
1829         Fixed the bug by resolving both test results directory and zip archive paths in
1830         LayoutTestResultsReader.archive.
1831
1832         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
1833         in the future.
1834
1835         * Scripts/webkitpy/common/system/filesystem_mock.py:
1836         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
1837
1838         * Scripts/webkitpy/common/system/workspace.py:
1839         (Workspace.create_zip): Log the source path when "zip" failed.
1840
1841         * Scripts/webkitpy/common/system/workspace_mock.py:
1842         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
1843
1844         * Scripts/webkitpy/common/system/workspace_unittest.py:
1845         (WorkspaceTest.test_create_zip_exception): Test that.
1846
1847         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1848         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
1849         This is the actual bug fix.
1850
1851         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1852         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
1853
1854 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
1855
1856         [chromium] move WebThemeEngine implementations to TestRunner library
1857         https://bugs.webkit.org/show_bug.cgi?id=112751
1858
1859         Reviewed by Adam Barth.
1860
1861         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1862         * DumpRenderTree/DumpRenderTree.gypi:
1863         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1864         (WebKit):
1865         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1866         (WebTestRunner::TestInterfaces::themeEngine):
1867         (WebTestRunner):
1868         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1869         (WebKit):
1870         (TestInterfaces):
1871         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1872         (WebTestRunner::WebTestInterfaces::themeEngine):
1873         (WebTestRunner):
1874         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1875         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1876         (WebTestRunner):
1877         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1878         (WebTestRunner::WebTestThemeControlWin::box):
1879         (WebTestRunner::WebTestThemeControlWin::line):
1880         (WebTestRunner::WebTestThemeControlWin::triangle):
1881         (WebTestRunner::WebTestThemeControlWin::roundRect):
1882         (WebTestRunner::WebTestThemeControlWin::oval):
1883         (WebTestRunner::WebTestThemeControlWin::circle):
1884         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1885         (WebTestRunner::WebTestThemeControlWin::markState):
1886         (WebTestRunner::WebTestThemeControlWin::draw):
1887         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1888         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1889         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1890         (WebTestRunner):
1891         (WebTestThemeControlWin):
1892         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1893         (WebTestRunner):
1894         (WebTestThemeEngineMac):
1895         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1896         (+[FakeActiveWindow alwaysActiveWindow]):
1897         (+[FakeActiveWindow alwaysInactiveWindow]):
1898         (-[FakeActiveWindow initWithActiveControls:]):
1899         (-[FakeActiveWindow _hasActiveControls]):
1900         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1901         (WebTestRunner):
1902         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1903         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1904         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1905         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1906         (WebTestRunner):
1907         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1908         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1909         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1910         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1911         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1912         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1913         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1914         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1915         (WebTestRunner::WebTestThemeEngineWin::getSize):
1916         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1917         (WebTestRunner):
1918         (WebTestThemeEngineWin):
1919         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1920         * DumpRenderTree/chromium/TestShell.cpp:
1921         (TestShell::initialize):
1922         * DumpRenderTree/chromium/TestShell.h:
1923         (WebKit):
1924         * DumpRenderTree/chromium/TestShellMac.mm:
1925         (platformInit):
1926         * DumpRenderTree/chromium/TestShellWin.cpp:
1927         (platformInit):
1928         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1929
1930 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1931
1932         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
1933
1934         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
1935         New property sheet that does not link against CoreFoundation and
1936         CFNetwork.
1937         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1938         Use new TestWebKitAPICommonWinCairo property sheet.
1939         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1940         Ditto.
1941
1942 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1943
1944         [WinCairo] Unreviewed build fix for VS2010.
1945
1946         Had to add WinCairo-specific property sheets to deal with some
1947         library and path differences with the main Apple port.
1948
1949         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1950         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1951         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1952         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
1953         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
1954         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
1955
1956 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
1957
1958         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
1959         https://bugs.webkit.org/show_bug.cgi?id=112849
1960
1961         Reviewed by Sam Weinig.
1962
1963         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1964         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1965         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1966
1967 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1968
1969         [WinCairo] Build WebKit Tools under VS2010
1970         https://bugs.webkit.org/show_bug.cgi?id=112821
1971
1972         Reviewed by Tim Horton.
1973
1974         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1975         Add WinCairo-specific build target.
1976         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
1977         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
1978         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
1979         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
1980         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1981         Add WinCairo-specific build target.
1982         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1983         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1984         Add WinCairo-specific build target.
1985         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
1986         WinCairo-specific build target.
1987         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
1988         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
1989         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
1990         specific build target.
1991         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
1992         WinCairo-specific build target.
1993         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
1994         * win/record-memory/record-memoryDebugWinCairo.props: Added.
1995         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
1996
1997 2013-03-20  Roger Fong  <roger_fong@apple.com>
1998
1999         API test gardening AppleWin port.
2000
2001         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2002
2003         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2004         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2005
2006 2013-03-20  Roger Fong  <roger_fong@apple.com>
2007
2008         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2009
2010         * EWSTools/start-queue-win.sh:
2011
2012 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2013
2014         Unreviewed, add myself to committers.py.
2015
2016 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2017
2018         Unreviewed. Adding another email for me.
2019
2020         * Scripts/webkitpy/common/config/committers.py:
2021
2022 2013-03-20  Justin Novosad  <junov@google.com>
2023
2024         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2025         https://bugs.webkit.org/show_bug.cgi?id=112605
2026
2027         Reviewed by James Robinson.
2028
2029         Deleting all the code that was used for propagating and supporting
2030         the Chromium setting for disabling deferred 2d canvas rendering.
2031
2032         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2033         (main):
2034         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2035         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2036         (WebTestRunner::WebPreferences::reset):
2037         (WebTestRunner::WebPreferences::applyTo):
2038         * DumpRenderTree/chromium/TestShell.cpp:
2039         (TestShell::TestShell):
2040         (TestShell::resetWebSettings):
2041         (TestShell::runFileTest):
2042         * DumpRenderTree/chromium/TestShell.h:
2043         (TestShell):
2044
2045 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2046
2047         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2048         https://bugs.webkit.org/show_bug.cgi?id=112699.
2049
2050         Reviewed by Adam Barth.
2051
2052         * Scripts/webkitpy/layout_tests/port/qt.py:
2053         (QtPort._search_paths):
2054         (QtPort._port_specific_expectations_files):
2055         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2056         (QtPortTest):
2057         (QtPortTest._assert_search_path):
2058         (QtPortTest._assert_expectations_files):
2059
2060 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2061
2062         [Qt] Enable kerning by default
2063         https://bugs.webkit.org/show_bug.cgi?id=112704
2064
2065         Reviewed by Jocelyn Turcotte.
2066
2067         Disable kerning by default, since some reference test expectations
2068         expect kerning to be default off.
2069
2070         * DumpRenderTree/qt/TestRunnerQt.cpp:
2071         (TestRunnerQt::reset):
2072         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2073         (WTR::activateFonts):
2074
2075 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2076
2077         [Qt] Remove empty function stubs from TestRunnerQt.
2078         https://bugs.webkit.org/show_bug.cgi?id=112799
2079
2080         We are reducing the code in TestRunnerQt step by step,
2081         in order to finally replace all of it with the generic
2082         TestRunner implementation.
2083         This patch removes several simple function stubs that
2084         currently do not implement any actual functionality.
2085
2086         Reviewed by Kenneth Rohde Christiansen.
2087
2088         * DumpRenderTree/qt/TestRunnerQt.cpp:
2089         * DumpRenderTree/qt/TestRunnerQt.h:
2090         (TestRunnerQt):
2091
2092 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2093
2094         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2095         https://bugs.webkit.org/show_bug.cgi?id=112687
2096
2097         Reviewed by Kenneth Rohde Christiansen.
2098
2099         Hide the SearchBar by default on window creation.
2100
2101         * MiniBrowser/efl/main.c:
2102         (window_create):
2103
2104 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2105
2106         Unreviewed, rolling out r146304.
2107         http://trac.webkit.org/changeset/146304
2108         https://bugs.webkit.org/show_bug.cgi?id=112788
2109
2110         to many expectations to update (Requested by antonm on
2111         #webkit).
2112
2113         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2114         * DumpRenderTree/DumpRenderTree.gypi:
2115         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2116         (WebKit):
2117         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2118         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2119         (TestInterfaces):
2120         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2121         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2122         * DumpRenderTree/chromium/TestShell.cpp:
2123         (TestShell::initialize):
2124         * DumpRenderTree/chromium/TestShell.h:
2125         (WebKit):
2126         * DumpRenderTree/chromium/TestShellMac.mm:
2127         (platformInit):
2128         * DumpRenderTree/chromium/TestShellWin.cpp:
2129         (platformInit):
2130         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2131         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2132         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2133         (WebThemeControlDRTWin::box):
2134         (WebThemeControlDRTWin::line):
2135         (WebThemeControlDRTWin::triangle):
2136         (WebThemeControlDRTWin::roundRect):
2137         (WebThemeControlDRTWin::oval):
2138         (WebThemeControlDRTWin::circle):
2139         (WebThemeControlDRTWin::nestedBoxes):
2140         (WebThemeControlDRTWin::markState):
2141         (WebThemeControlDRTWin::draw):
2142         (WebThemeControlDRTWin::drawTextField):
2143         (WebThemeControlDRTWin::drawProgressBar):
2144         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2145         (WebThemeControlDRTWin):
2146         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2147         (WebThemeEngineDRTMac):
2148         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2149         (+[FakeActiveWindow alwaysActiveWindow]):
2150         (+[FakeActiveWindow alwaysInactiveWindow]):
2151         (-[FakeActiveWindow initWithActiveControls:]):
2152         (-[FakeActiveWindow _hasActiveControls]):
2153         (WebThemeEngineDRTMac::paintScrollbarThumb):
2154         (stateToHIEnableState):
2155         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2156         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2157         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2158         (webRectToSkIRect):
2159         (drawControl):
2160         (drawTextField):
2161         (drawProgressBar):
2162         (WebThemeEngineDRTWin::paintButton):
2163         (WebThemeEngineDRTWin::paintMenuList):
2164         (WebThemeEngineDRTWin::paintScrollbarArrow):
2165         (WebThemeEngineDRTWin::paintScrollbarThumb):
2166         (WebThemeEngineDRTWin::paintScrollbarTrack):
2167         (WebThemeEngineDRTWin::paintSpinButton):
2168         (WebThemeEngineDRTWin::paintTextField):
2169         (WebThemeEngineDRTWin::paintTrackbar):
2170         (WebThemeEngineDRTWin::paintProgressBar):
2171         (WebThemeEngineDRTWin::getSize):
2172         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2173         (WebThemeEngineDRTWin):
2174         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2175
2176 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2177
2178         [Qt] Support -webkit-font-smoothing
2179         https://bugs.webkit.org/show_bug.cgi?id=106009
2180
2181         Reviewed by Jocelyn Turcotte.
2182
2183         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2184
2185         * DumpRenderTree/qt/TestRunnerQt.cpp:
2186         (TestRunnerQt::reset):
2187
2188 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2189
2190         [GTK] accessibility/aria-scrollbar-role.html is failing
2191         https://bugs.webkit.org/show_bug.cgi?id=98358
2192
2193         Reviewed by Martin Robinson.
2194
2195         Adds support for checking accessibility object's orientation.
2196         Orientation is checked by retrieving proper state of accessibility object.
2197
2198         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2199         (checkElementState):
2200         (AccessibilityUIElement::orientation):
2201         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2202         (WTR::AccessibilityUIElement::orientation):
2203
2204 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2205
2206         [chromium] move WebThemeEngine implementations to TestRunner library
2207         https://bugs.webkit.org/show_bug.cgi?id=112751
2208
2209         Reviewed by Adam Barth.
2210
2211         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2212         * DumpRenderTree/DumpRenderTree.gypi:
2213         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2214         (WebKit):
2215         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2216         (WebTestRunner::TestInterfaces::themeEngine):
2217         (WebTestRunner):
2218         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2219         (WebKit):
2220         (TestInterfaces):
2221         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2222         (WebTestRunner::WebTestInterfaces::themeEngine):
2223         (WebTestRunner):
2224         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2225         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2226         (WebTestRunner):
2227         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2228         (WebTestRunner::WebTestThemeControlWin::box):
2229         (WebTestRunner::WebTestThemeControlWin::line):
2230         (WebTestRunner::WebTestThemeControlWin::triangle):
2231         (WebTestRunner::WebTestThemeControlWin::roundRect):
2232         (WebTestRunner::WebTestThemeControlWin::oval):
2233         (WebTestRunner::WebTestThemeControlWin::circle):
2234         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2235         (WebTestRunner::WebTestThemeControlWin::markState):
2236         (WebTestRunner::WebTestThemeControlWin::draw):
2237         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2238         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2239         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2240         (WebTestRunner):
2241         (WebTestThemeControlWin):
2242         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2243         (WebTestRunner):
2244         (WebTestThemeEngineMac):
2245         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2246         (+[FakeActiveWindow alwaysActiveWindow]):
2247         (+[FakeActiveWindow alwaysInactiveWindow]):
2248         (-[FakeActiveWindow initWithActiveControls:]):
2249         (-[FakeActiveWindow _hasActiveControls]):
2250         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2251         (WebTestRunner):
2252         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2253         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2254         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2255         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2256         (WebTestRunner):
2257         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2258         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2259         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2260         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2261         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2262         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2263         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2264         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2265         (WebTestRunner::WebTestThemeEngineWin::getSize):
2266         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2267         (WebTestRunner):
2268         (WebTestThemeEngineWin):
2269         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2270         * DumpRenderTree/chromium/TestShell.cpp:
2271         (TestShell::initialize):
2272         * DumpRenderTree/chromium/TestShell.h:
2273         (WebKit):
2274         * DumpRenderTree/chromium/TestShellMac.mm:
2275         (platformInit):
2276         * DumpRenderTree/chromium/TestShellWin.cpp:
2277         (platformInit):
2278         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2279
2280 2013-03-19  Tony Chang  <tony@chromium.org>
2281
2282         Move testRunner.setTouchDragDropEnabled to internals.settings
2283         https://bugs.webkit.org/show_bug.cgi?id=112739
2284
2285         Reviewed by Adam Barth.
2286
2287         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2288         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2289         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2290         (TestRunner): Remove unnecessary code.
2291         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2292         (WebTestRunner::WebPreferences::reset):
2293         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2294
2295 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2296
2297         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2298         https://bugs.webkit.org/show_bug.cgi?id=112754
2299
2300         Reviewed by Darin Fisher.
2301
2302         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2303         now that it's always defined.
2304
2305         * DumpRenderTree/chromium/WebViewHost.cpp:
2306         * DumpRenderTree/chromium/WebViewHost.h:
2307         (WebViewHost):
2308
2309 2013-03-19  Kenneth Russell  <kbr@google.com>
2310
2311         Unreviewed, rolling out r146290.
2312         http://trac.webkit.org/changeset/146290
2313         https://bugs.webkit.org/show_bug.cgi?id=112751
2314
2315         Broke Chromium Mac build.
2316
2317         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2318         * DumpRenderTree/DumpRenderTree.gypi:
2319         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2320         (WebKit):
2321         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2322         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2323         (TestInterfaces):
2324         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2325         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2326         * DumpRenderTree/chromium/TestShell.cpp:
2327         (TestShell::initialize):
2328         * DumpRenderTree/chromium/TestShell.h:
2329         (WebKit):
2330         * DumpRenderTree/chromium/TestShellMac.mm:
2331         (platformInit):
2332         * DumpRenderTree/chromium/TestShellWin.cpp:
2333         (platformInit):
2334         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2335         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2336         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2337         (WebThemeControlDRTWin::box):
2338         (WebThemeControlDRTWin::line):
2339         (WebThemeControlDRTWin::triangle):
2340         (WebThemeControlDRTWin::roundRect):
2341         (WebThemeControlDRTWin::oval):
2342         (WebThemeControlDRTWin::circle):
2343         (WebThemeControlDRTWin::nestedBoxes):
2344         (WebThemeControlDRTWin::markState):
2345         (WebThemeControlDRTWin::draw):
2346         (WebThemeControlDRTWin::drawTextField):
2347         (WebThemeControlDRTWin::drawProgressBar):
2348         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2349         (WebThemeControlDRTWin):
2350         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2351         (WebThemeEngineDRTMac):
2352         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2353         (+[FakeActiveWindow alwaysActiveWindow]):
2354         (+[FakeActiveWindow alwaysInactiveWindow]):
2355         (-[FakeActiveWindow initWithActiveControls:]):
2356         (-[FakeActiveWindow _hasActiveControls]):
2357         (WebThemeEngineDRTMac::paintScrollbarThumb):
2358         (stateToHIEnableState):
2359         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2360         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2361         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2362         (webRectToSkIRect):
2363         (drawControl):
2364         (drawTextField):
2365         (drawProgressBar):
2366         (WebThemeEngineDRTWin::paintButton):
2367         (WebThemeEngineDRTWin::paintMenuList):
2368         (WebThemeEngineDRTWin::paintScrollbarArrow):
2369         (WebThemeEngineDRTWin::paintScrollbarThumb):
2370         (WebThemeEngineDRTWin::paintScrollbarTrack):
2371         (WebThemeEngineDRTWin::paintSpinButton):
2372         (WebThemeEngineDRTWin::paintTextField):
2373         (WebThemeEngineDRTWin::paintTrackbar):
2374         (WebThemeEngineDRTWin::paintProgressBar):
2375         (WebThemeEngineDRTWin::getSize):
2376         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2377         (WebThemeEngineDRTWin):
2378         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2379
2380 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2381
2382         [EFL] canvas-fallback-content.html is failing
2383         https://bugs.webkit.org/show_bug.cgi?id=111998
2384
2385         Reviewed by Chris Fleizach.
2386
2387         Adds support for getting platform name.
2388
2389         * DumpRenderTree/TestRunner.cpp:
2390         (TestRunner::staticValues):
2391         * DumpRenderTree/TestRunner.h:
2392         (TestRunner):
2393         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2394         (TestRunner::platformName):
2395
2396 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2397
2398         [chromium] move WebThemeEngine implementations to TestRunner library
2399         https://bugs.webkit.org/show_bug.cgi?id=112751
2400
2401         Reviewed by Adam Barth.
2402
2403         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2404         * DumpRenderTree/DumpRenderTree.gypi:
2405         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2406         (WebKit):
2407         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2408         (WebTestRunner::TestInterfaces::themeEngine):
2409         (WebTestRunner):
2410         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2411         (WebKit):
2412         (TestInterfaces):
2413         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2414         (WebTestRunner::WebTestInterfaces::themeEngine):
2415         (WebTestRunner):
2416         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2417         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2418         (WebTestRunner):
2419         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2420         (WebTestRunner::WebTestThemeControlWin::box):
2421         (WebTestRunner::WebTestThemeControlWin::line):
2422         (WebTestRunner::WebTestThemeControlWin::triangle):
2423         (WebTestRunner::WebTestThemeControlWin::roundRect):
2424         (WebTestRunner::WebTestThemeControlWin::oval):
2425         (WebTestRunner::WebTestThemeControlWin::circle):
2426         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2427         (WebTestRunner::WebTestThemeControlWin::markState):
2428         (WebTestRunner::WebTestThemeControlWin::draw):
2429         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2430         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2431         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2432         (WebTestRunner):
2433         (WebTestThemeControlWin):
2434         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2435         (WebTestRunner):
2436         (WebTestThemeEngineMac):
2437         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2438         (+[FakeActiveWindow alwaysActiveWindow]):
2439         (+[FakeActiveWindow alwaysInactiveWindow]):
2440         (-[FakeActiveWindow initWithActiveControls:]):
2441         (-[FakeActiveWindow _hasActiveControls]):
2442         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2443         (WebTestRunner):
2444         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2445         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2446         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2447         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2448         (WebTestRunner):
2449         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2450         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2451         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2452         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2453         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2454         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2455         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2456         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2457         (WebTestRunner::WebTestThemeEngineWin::getSize):
2458         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2459         (WebTestRunner):
2460         (WebTestThemeEngineWin):
2461         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2462         * DumpRenderTree/chromium/TestShell.cpp:
2463         (TestShell::initialize):
2464         * DumpRenderTree/chromium/TestShell.h:
2465         (WebKit):
2466         * DumpRenderTree/chromium/TestShellMac.mm:
2467         (platformInit):
2468         * DumpRenderTree/chromium/TestShellWin.cpp:
2469         (platformInit):
2470         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2471
2472 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2473
2474         [EFL][WK2] Separate WebView further from EwkView
2475         https://bugs.webkit.org/show_bug.cgi?id=111591
2476
2477         Reviewed by Caio Marcelo de Oliveira Filho.
2478
2479         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2480         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2481         since we can afford it having EWKViewGetWKView() private API to access WKView.
2482
2483         * TestWebKitAPI/PlatformWebView.h:
2484         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2485         (TestWebKitAPI::TEST):
2486         * TestWebKitAPI/efl/PlatformWebView.cpp:
2487         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2488         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2489         (TestWebKitAPI::PlatformWebView::resizeTo):
2490         (TestWebKitAPI::PlatformWebView::page):
2491         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2492         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2493         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2494         * WebKitTestRunner/PlatformWebView.h:
2495         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2496         (WTR::EventSenderProxy::dispatchEvent):
2497         (WTR::EventSenderProxy::keyDown):
2498         (WTR::EventSenderProxy::sendTouchEvent):
2499         (WTR::EventSenderProxy::setTouchModifier):
2500         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2501         (WTR::PlatformWebView::PlatformWebView):
2502         (WTR::PlatformWebView::~PlatformWebView):
2503         (WTR::PlatformWebView::resizeTo):
2504         (WTR::PlatformWebView::page):
2505         (WTR::PlatformWebView::focus):
2506         (WTR::PlatformWebView::windowSnapshotImage):
2507
2508 2013-03-19  Roger Fong  <roger_fong@apple.com>
2509
2510         Changes to VS2010 project files should only trigger builds on Windows bots.
2511         https://bugs.webkit.org/show_bug.cgi?id=112731
2512
2513         Reviewed by Timothy Horton.
2514
2515         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2516         (_should_file_trigger_build):
2517
2518 2013-03-19  Roger Fong  <roger_fong@apple.com>
2519
2520         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2521
2522         * Scripts/webkitpy/tool/steps/runtests.py:
2523         (RunTests.run):
2524         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2525         (RunTestsTest.test_webkit_run_unit_tests):
2526
2527 2013-03-19  Julie Parent  <jparent@chromium.org>
2528
2529         Dashboards: Introduce history namespace and unit tests.
2530         https://bugs.webkit.org/show_bug.cgi?id=112645
2531
2532         Reviewed by Ojan Vafai.
2533         
2534         Laying the framework for introducing the new history object and
2535         namespace.  This moves only static functions into the history
2536         namespace, and moves corresponding unit tests into seperate
2537         unit test file.
2538
2539         * TestResultServer/static-dashboards/aggregate_results.html:
2540         * TestResultServer/static-dashboards/dashboard_base.js:
2541         (parseCrossDashboardParameters):
2542         (parseDashboardSpecificParameters):
2543         (parseParameters):
2544         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2545         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2546         (.switch.return):
2547         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2548         * TestResultServer/static-dashboards/history.js: Added.
2549         * TestResultServer/static-dashboards/history_unittests.js: Added.
2550         * TestResultServer/static-dashboards/loader.js:
2551         (.):
2552         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2553         * TestResultServer/static-dashboards/run-unittests.html:
2554         * TestResultServer/static-dashboards/timeline_explorer.html:
2555         * TestResultServer/static-dashboards/timeline_explorer.js:
2556         * TestResultServer/static-dashboards/treemap.html:
2557         * TestResultServer/static-dashboards/treemap.js:
2558         (.switch.return):
2559         * TestResultServer/static-dashboards/ui.js:
2560
2561 2013-03-19  Daniel Bates  <dbates@webkit.org>
2562
2563         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2564         https://bugs.webkit.org/show_bug.cgi?id=112732
2565
2566         Reviewed by Eric Seidel.
2567
2568         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2569         of an existing file cannot be applied.
2570
2571         In particular, svn-{apply, unapply} compensate for differences in line endings
2572         by converting the line endings in a diff to match the line endings in the target
2573         file. The diff(1) command precedes the last line of a diff that adds a newline
2574         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2575         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2576         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2577         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2578         the newline characters in this special character sequence to match the line endings
2579         in the target file.
2580
2581         * Scripts/VCSUtils.pm:
2582         (parseDiff):
2583         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2584         Added tests:
2585             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2586             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2587             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2588             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2589         (escapeNewLineCharacters): Added.
2590         (toMacLineEndings): Added.
2591
2592 2013-03-19  James Robinson  <jamesr@chromium.org>
2593
2594         [chromium] Remove compositor settings that don't go through WebKit
2595         https://bugs.webkit.org/show_bug.cgi?id=112718
2596
2597         Reviewed by Adam Barth.
2598
2599         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2600         (main):
2601         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2602         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2603         (WebTestRunner::WebPreferences::reset):
2604         (WebTestRunner::WebPreferences::applyTo):
2605         * DumpRenderTree/chromium/TestShell.cpp:
2606         (TestShell::TestShell):
2607         (TestShell::resetWebSettings):
2608         * DumpRenderTree/chromium/TestShell.h:
2609         (TestShell):
2610
2611 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
2612
2613         Unreviewed, rolling out r146101.
2614         https://bugs.webkit.org/show_bug.cgi?id=111884
2615
2616         re-enable custom freetype on asan; this needs to be on
2617         now that the bot is running lucid.
2618
2619         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2620
2621 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
2622
2623         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
2624         https://bugs.webkit.org/show_bug.cgi?id=112365
2625
2626         Reviewed by Benjamin Poulain.
2627
2628         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
2629         harcoding it in wtf/Platform.h
2630
2631         * Scripts/webkitperl/FeatureList.pm:
2632
2633 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2634
2635         [Qt] Make ImageDiff similar to Chromium's ImageDiff
2636         https://bugs.webkit.org/show_bug.cgi?id=94782
2637
2638         Based on patch by Csaba Osztrogonác.
2639         Reviewed by Jocelyn Turcotte.
2640
2641         The diff image is generated with bright red indicating errors, but letting the base image
2642         shine through so the context of the error-pixel can be identified.
2643
2644         * DumpRenderTree/qt/ImageDiff.cpp:
2645         (main):
2646
2647 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
2648
2649         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
2650
2651         Rubber-stamped by Csaba Osztrogonác.
2652
2653         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
2654         since the latter might not cover the former.
2655
2656         * QtTestBrowser/launcherwindow.cpp:
2657         (LauncherWindow::print):
2658
2659 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2660
2661         Style tweeks to default.css.
2662         
2663         Rubber-stamped by David Kilzer.
2664         
2665         Give visited links a different color to other links, so you can
2666         see which builds you've viewed.
2667         
2668         Make the <small> text less tiny.
2669
2670         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2671         (small):
2672         (a:link,a:visited,a:active):
2673         (a:visited):
2674
2675 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2676
2677         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
2678         https://bugs.webkit.org/show_bug.cgi?id=112494
2679
2680         Reviewed by Dirk Pranke.
2681
2682         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
2683         Also merged two pairs of methods to cleanup the code.
2684
2685         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2686         (PerfTestsRunner.run): Merged _upload_and_show_results.
2687         (PerfTestsRunner._generate_results): Merged _generate_output_files.
2688
2689 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2690
2691         [chromium] build xdisplaycheck when building DRT
2692         https://bugs.webkit.org/show_bug.cgi?id=112636
2693
2694         Reviewed by Tony Chang.
2695
2696         It appears that we need xdisplaycheck to be built in order for
2697         Xvfb to be started correctly on the bots, and DRT was missing
2698         a dependency on it. This may be the cause of the ASAN bot not
2699         starting up properly (it only builds DRT).
2700
2701         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2702
2703 2013-03-18  David Levin  <levin@chromium.org>
2704
2705         Implement icon change notification dump for Chromium's test shell.
2706         https://bugs.webkit.org/show_bug.cgi?id=112614
2707
2708         This was previously implemented for some other platforms in r58111
2709         and r116547.
2710
2711         In r122806, fast/dom/icon-url-property.html stopped using it, but
2712         it is useful for tests, so I plan to re-add it to that test again.
2713
2714         Reviewed by Jochen Eisinger.
2715
2716         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2717         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
2718          icon change notifications from WebKit may be logged in test output.
2719         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2720         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
2721         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
2722         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
2723         (WebTestRunner):
2724         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
2725         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2726         (TestRunner):
2727         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2728         (WebTestRunner::WebTestProxyBase::didChangeIcon):
2729         (WebTestRunner):
2730         * DumpRenderTree/chromium/WebViewHost.cpp:
2731         (WebViewHost::didChangeIcon): Add the output about changing the icon.
2732         * DumpRenderTree/chromium/WebViewHost.h:
2733         (WebViewHost):
2734
2735 2013-03-18  Julie Parent  <jparent@chromium.org>
2736
2737         Cleanup: Move js for treemap and aggregate_results into own js files.
2738         https://bugs.webkit.org/show_bug.cgi?id=112618
2739
2740         Reviewed by Dirk Pranke.
2741         
2742         No functional changes, just moving the code into separate js file
2743         rather than inlined in the html, so we can test it, make it more
2744         modular, etc.  Other dashboard types are already done this way.
2745
2746         * TestResultServer/static-dashboards/aggregate_results.html:
2747         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
2748         (generatePage):
2749         (handleValidHashParameter):
2750         (htmlForBuilder):
2751         (rawValuesHTML):
2752         (chartHTML):
2753         (filteredValues):
2754         (chart):
2755         (htmlForRevisionRows):
2756         (wrapHTMLInTable):
2757         (htmlForSummaryTable):
2758         (valuesPerExpectation):
2759         (htmlForTestType):
2760         (htmlForTableRow):
2761         (extendedEncode):
2762         * TestResultServer/static-dashboards/treemap.html:
2763         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
2764         (humanReadableTime):
2765         (convertToWebTreemapFormat):
2766         (reverseSortByAverage):
2767         (generatePage):
2768         (focusPath):
2769         (.switch.return):
2770         (handleQueryParameterChange):
2771         (extractName):
2772         (fullName):
2773         (handleFocus.):
2774         (handleFocus):
2775
2776 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2777
2778         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
2779         https://bugs.webkit.org/show_bug.cgi?id=112622
2780
2781         Reviewed by Dirk Pranke.
2782
2783         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2784         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
2785
2786 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2787
2788         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
2789         https://bugs.webkit.org/show_bug.cgi?id=112619
2790
2791         Reviewed by Dirk Pranke.
2792
2793         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
2794         directory and then fall back to the generic LayoutTests/platform/gtk directory.
2795
2796         * Scripts/webkitpy/layout_tests/port/gtk.py:
2797         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
2798         Port._webkit_baseline_path method.
2799         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2800         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
2801         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
2802         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2803         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
2804         that are expected based on the builder name.
2805
2806 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
2807
2808         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
2809         https://bugs.webkit.org/show_bug.cgi?id=112571
2810
2811         Reviewed by Adam Barth.
2812
2813         Update function declarations for new WebFileSystemType enum. (All
2814         changes are behind an #ifdef so we can sync required changes in embedders.)
2815
2816         * DumpRenderTree/chromium/WebViewHost.cpp:
2817         (WebViewHost::openFileSystem):
2818         (WebViewHost::deleteFileSystem):
2819         * DumpRenderTree/chromium/WebViewHost.h:
2820         (WebViewHost):
2821
2822 2013-03-18  Julie Parent  <jparent@chromium.org>
2823
2824         Cleanup: Move timeline_exporer js out of html file into js.
2825         https://bugs.webkit.org/show_bug.cgi?id=112188
2826
2827         Reviewed by Dirk Pranke.
2828         
2829         Moves the javascript out of the html file and into a new js file.
2830         This follows the format of flakiness_dashboard.{html|js}.
2831         
2832         Also moves code from dashboard_base that is used only by this one
2833         dashboard, and makes it private to the dashboard.
2834
2835         * TestResultServer/static-dashboards/dashboard_base.js:
2836         * TestResultServer/static-dashboards/timeline_explorer.html:
2837         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
2838         (generatePage):
2839         (initCurrentBuilderTestResults):
2840         (shouldShowWebKitRevisionsOnly):
2841         (updateTimelineForBuilder.):
2842         (updateTimelineForBuilder):
2843         (selectBuild):
2844         (updateBuildIndicator):
2845         (.addRow):
2846         (.addNumberRow):
2847         (.inspectorNode.getElementsByTagName.0.onclick):
2848         (.inspectorNode.getElementsByTagName.1.onclick):
2849         (.inspectorNode.getElementsByTagName.2.onclick):
2850         (updateBuildInspector):
2851         (showResultsDelta):
2852         (decompressResults.addFlakyDelta):
2853         (decompressResults):
2854
2855 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2856
2857         Unreviewed, rolling out r145272.
2858         http://trac.webkit.org/changeset/145272
2859         https://bugs.webkit.org/show_bug.cgi?id=111884
2860
2861         Turns out the ASAN build is still broken; possibly there's
2862         something still setting LD_LIBRARY_PATH, or possibly there's
2863         something else wrong. In the meantime, we need it to work again.
2864
2865         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2866
2867 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2868
2869         delete-stale-build-files is too aggressive
2870         https://bugs.webkit.org/show_bug.cgi?id=112595
2871
2872         Reviewed by Tim Horton.
2873
2874         It appears that whitelisting file extensions to keep is not a good idea.
2875         Blacklist files to delete instead, and only delete .o files for now.
2876         We can add more file extensions as needed.
2877
2878         * BuildSlaveSupport/delete-stale-build-files:
2879
2880 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2881
2882         Disable accessibility notifications after each test
2883         https://bugs.webkit.org/show_bug.cgi?id=112579
2884
2885         Reviewed by Tim Horton.
2886         
2887         In WebKitTestRunner, if any tests triggered accessibility notifications,
2888         the global notification handler would thereafter be active, and fire
2889         notifications for all subsequent tests.
2890         
2891         Fix by implementing AccessibilityController::resetToConsistentState() for
2892         Mac, and using it to clear the global notification handler.
2893
2894         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2895         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2896         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
2897         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
2898         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
2899         (e.g. because of -autorelease).
2900         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
2901         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
2902         if there is one.
2903         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
2904         Add -stopObserving
2905         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2906         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
2907         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
2908         center.
2909
2910 2013-03-18  Dana Jansens  <danakj@chromium.org>
2911
2912         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
2913         https://bugs.webkit.org/show_bug.cgi?id=112392
2914
2915         Reviewed by James Robinson.
2916
2917         Removes the command line flag option from DRT.
2918
2919         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2920         (main):
2921
2922 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2923
2924         [GTK] plugins/plugin-clip-subframe.html is failing
2925         https://bugs.webkit.org/show_bug.cgi?id=112570
2926
2927         Reviewed by Martin Robinson.
2928
2929         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
2930
2931 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
2932
2933         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
2934         https://bugs.webkit.org/show_bug.cgi?id=112442
2935
2936         Reviewed by Gustavo Noronha Silva.
2937
2938         * GtkLauncher/main.c:
2939         (reloadCb):
2940         (createToolbar):
2941         (createWindow):
2942
2943 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2944
2945         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
2946         https://bugs.webkit.org/show_bug.cgi?id=112205
2947
2948         Disable this API test until Geoff can fix it.
2949
2950         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2951         (TestWebKitAPI::TEST):
2952
2953 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
2954
2955         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2956         https://bugs.webkit.org/show_bug.cgi?id=112478
2957
2958         Reviewed by Tony Chang.
2959
2960         There is nothing that ensures that the log messages from the plugin
2961         come in before the layout test finished loading.
2962
2963         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2964         (PassDifferentNPPStruct::NPP_SetWindow):
2965         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2966         (NPP_SetWindow):
2967
2968 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2969
2970         Have the mac port support per_test_timeout in webkitpy
2971         https://bugs.webkit.org/show_bug.cgi?id=112466
2972
2973         Reviewed by Dirk Pranke.
2974         
2975         Both WTR and DRT handle --timeout arguments, so we can
2976         have the scripts pass the timeout values down to the tools.
2977
2978         * Scripts/webkitpy/layout_tests/port/mac.py:
2979         (MacPort.supports_per_test_timeout):
2980
2981 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
2982
2983         Remove setAsynchronousSpellCheckingEnabled from test runners
2984         https://bugs.webkit.org/show_bug.cgi?id=112362
2985
2986         Reviewed by Tony Chang.
2987
2988         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
2989         in internals.settings, so all ports can share it.
2990
2991         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2992         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2993         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2994         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2995         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2996         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2997         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2998         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
2999         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3000         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3001         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3002         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3003
3004 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3005
3006         Fix the stupid unit tests.
3007
3008         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3009         (test_sample_process):
3010
3011 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3012
3013         Collect samples for unresponsive web processes
3014         https://bugs.webkit.org/show_bug.cgi?id=112409
3015
3016         Reviewed by Tim Horton.
3017         
3018         When we detect that a subprocess was unresponsive, run the 'sample'
3019         tool on that process, for the Mac port.
3020         
3021         The sample will be linked to from the results.html page, next
3022         to the crash log link.
3023
3024         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3025         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3026         look for samples on disk.
3027         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3028         (TestResultWriter):
3029         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3030         -sample.txt files, and have it copy their contents to a new file
3031         next to the test that spawned them (as we do for crash logs).
3032         * Scripts/webkitpy/layout_tests/port/base.py:
3033         (Port.look_for_new_samples): Base class does nothing for sampling.
3034         * Scripts/webkitpy/layout_tests/port/driver.py:
3035         (Driver._check_for_driver_crash): Kick off a sample if we detected
3036         that the subprocess was unresponsive.
3037         * Scripts/webkitpy/layout_tests/port/mac.py:
3038         (MacPort.sample_file_path): Utility to generate the file path
3039         to the generated sample files at the top level of layout-test-results.
3040         (MacPort.look_for_new_crash_logs): Fix typo
3041         (MacPort.look_for_new_samples): New function to find sample files.
3042         (MacPort.sample_process): Use the utility function to get the file path.
3043
3044 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3045
3046         [Qt] Remove simple getters and setters from TestRunnerQt
3047         https://bugs.webkit.org/show_bug.cgi?id=112343
3048
3049         Reviewed by Benjamin Poulain.
3050
3051         The removed functions and boolean members
3052         are being replaced by the implementations in the
3053         generic TestRunner.h.
3054
3055         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3056         (DumpRenderTree::dumpFrameScrollPosition):
3057         (DumpRenderTree::dumpFramesAsText):
3058         (DumpRenderTree::dump):
3059         (DumpRenderTree::titleChanged):
3060         (DumpRenderTree::dumpDatabaseQuota):
3061         (DumpRenderTree::dumpApplicationCacheQuota):
3062         (DumpRenderTree::statusBarMessage):
3063         (DumpRenderTree::createWindow):
3064         * DumpRenderTree/qt/TestRunnerQt.cpp:
3065         (TestRunnerQt::reset):
3066         * DumpRenderTree/qt/TestRunnerQt.h:
3067         (TestRunnerQt):
3068
3069 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3070
3071         Update the link on build.webkit.org to refer to perf.webkit.org
3072         https://bugs.webkit.org/show_bug.cgi?id=112416
3073
3074         Reviewed by Philip Rogers.
3075
3076         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3077
3078         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3079
3080 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3081
3082         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3083         https://bugs.webkit.org/show_bug.cgi?id=112394
3084
3085         Reviewed by Philippe Normand.
3086
3087         * GtkLauncher/main.c:
3088         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3089
3090 2013-03-14  Andreas Kling  <akling@apple.com>
3091
3092         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3093         <http://webkit.org/b/111815>
3094         <rdar://problem/13380145>
3095
3096         Reviewed by Anders Carlsson.
3097
3098         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3099         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3100         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3101
3102         * WebKitTestRunner/PlatformWebView.h:
3103         (PlatformWebView):
3104         * WebKitTestRunner/TestController.cpp:
3105         (WTR::TestController::createOtherPage):
3106         (WTR::TestController::createWebViewWithOptions):
3107         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3108         (WTR::PlatformWebView::didInitializeClients):
3109
3110 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3111
3112         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3113         https://bugs.webkit.org/show_bug.cgi?id=112122
3114
3115         Reviewed by Kenneth Rohde Christiansen.
3116
3117         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3118
3119         * MiniBrowser/efl/main.c:
3120         (_Browser_Window):
3121         (search_box_show):
3122         (search_box_hide):
3123         (on_key_down):
3124         (on_url_changed):
3125         (on_search_field_aborted):
3126         (on_search_field_activated):
3127         (on_search_field_clicked):
3128         (on_search_backward_button_clicked):
3129         (on_search_forward_button_clicked):
3130         (window_create):
3131
3132 2013-03-14  Julie Parent  <jparent@chromium.org>
3133
3134         Cleanup: Remove g_resourceLoader.
3135         https://bugs.webkit.org/show_bug.cgi?id=112305
3136
3137         Reviewed by Dirk Pranke.
3138         
3139         Removing another global.
3140         
3141         Now, each dashboard creates its own loader, rather than having
3142         a general global one.
3143         
3144         Remove usage of g_resourceLoader.isLoadingComplete from 
3145         handleLocationChange by ensuring that handleLocationChange is
3146         never called before the loader is done.  It was called in two
3147         places before: 1 was from the callback when the loader is done,
3148         so that was obviously true, and the other was from onhashchange,
3149         where it would just return rather than running.  Instead, lets
3150         only register the onhashchange handler once the loader is
3151         setup, so the check is no longer necessary.
3152         
3153         Remove isLoadingComplete since it is now unused.
3154         
3155         Callback for loader is now initializeHistory, rather than just
3156         handleLocationChange which will set up the hashchange handler now.
3157         This will all eventually be moving to a new History object.
3158
3159         * TestResultServer/static-dashboards/aggregate_results.html:
3160         * TestResultServer/static-dashboards/dashboard_base.js:
3161         (handleLocationChange):
3162         (intializeHistory):
3163         (decompressResults):
3164         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3165         (generatePage):
3166         * TestResultServer/static-dashboards/loader.js:
3167         (.):
3168         * TestResultServer/static-dashboards/loader_unittests.js:
3169         * TestResultServer/static-dashboards/timeline_explorer.html:
3170         * TestResultServer/static-dashboards/treemap.html:
3171
3172 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3173
3174         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3175         https://bugs.webkit.org/show_bug.cgi?id=109404
3176
3177         Reviewed by Tony Chang.
3178
3179         Removes all the code related to smartInsertDeleteEnabled and
3180         selectTrailingWhitespaceEnabled settings as they will be managed from
3181         internals from now on.
3182
3183         * DumpRenderTree/TestRunner.cpp:
3184         (TestRunner::staticFunctions):
3185         * DumpRenderTree/TestRunner.h:
3186         (TestRunner):
3187         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3188         (WebKit):
3189         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3190         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3191         (DumpRenderTree):
3192         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3193         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3194         (WebTestRunner::WebTestProxy::didStopLoading):
3195         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3196         (WebTestRunner::TestRunner::TestRunner):
3197         (WebTestRunner::TestRunner::reset):
3198         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3199         (TestRunner):
3200         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3201         (WebTestRunner::WebPreferences::applyTo): Set default values for
3202         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3203         Chromium DRT default values are different from Chromium browser.
3204         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3205         * DumpRenderTree/chromium/WebViewHost.cpp:
3206         * DumpRenderTree/chromium/WebViewHost.h:
3207         (WebViewHost):
3208         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3209         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3210         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3211         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3212         (resetDefaultsToConsistentValues):
3213         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3214         * DumpRenderTree/mac/DumpRenderTree.mm:
3215         (resetWebViewToConsistentStateBeforeTesting):
3216         * DumpRenderTree/mac/TestRunnerMac.mm:
3217         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3218         (WebCore::WebPage::resetSettings):
3219         * DumpRenderTree/qt/TestRunnerQt.cpp:
3220         * DumpRenderTree/qt/TestRunnerQt.h:
3221         (TestRunnerQt):
3222         * DumpRenderTree/win/DumpRenderTree.cpp:
3223         (resetWebViewToConsistentStateBeforeTesting):
3224         * DumpRenderTree/win/TestRunnerWin.cpp:
3225         * DumpRenderTree/wx/TestRunnerWx.cpp:
3226
3227 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3228
3229         [Qt] Disable DRT on Windows
3230
3231         Reviewed by Jocelyn Turcotte.
3232
3233         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3234
3235         * qmake/mkspecs/features/configure.prf:
3236
3237 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3238
3239         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
3240         https://bugs.webkit.org/show_bug.cgi?id=110728
3241
3242         Reviewed by Gyuyoung Kim.
3243
3244         Use the page group to create the view object.
3245
3246         * MiniBrowser/efl/main.c:
3247         (window_create):
3248
3249 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3250
3251         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
3252
3253         Reviewed by Tor Arne Vestbø.
3254
3255         The mock versions of these web facing features should be instantiated when
3256         running in DumpRenderTree only. In order for them to work, no extra Qt modules
3257         such as QtLocation are actually needed.
3258
3259         This patch decouples enabling device orientation/motion and geolocation from
3260         the underlying Qt modules and makes them available in developer builds
3261         (!production_build) and backed by mock backends when running in drt.
3262
3263         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
3264         developers the web facing features are always enabled (although requests will
3265         time out) and the mock backends are enabled inside DRT, allowing for the layout
3266         tests to run with less dependencies.
3267
3268         In addition this also enables the mock device motion client, which was
3269         previously never instantiated.
3270
3271         * qmake/mkspecs/features/features.prf:
3272
3273 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3274
3275         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
3276         https://bugs.webkit.org/show_bug.cgi?id=112340
3277
3278         Reviewed by Simon Hausmann.
3279
3280         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3281         (DumpRenderTree::dump):
3282             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
3283         (DumpRenderTree::dumpApplicationCacheQuota):
3284         * DumpRenderTree/qt/TestRunnerQt.cpp:
3285         (TestRunnerQt::reset):
3286         * DumpRenderTree/qt/TestRunnerQt.h:
3287         (TestRunnerQt):
3288
3289 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3290
3291         [Qt] Port DRT to use TestRunner::dumpAsText()
3292         https://bugs.webkit.org/show_bug.cgi?id=112260
3293
3294         Reviewed by Benjamin Poulain.
3295
3296         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3297         (WebCore::DumpRenderTree::open):
3298         (WebCore::methodNameStringForFailedTest):
3299             Change parameter from type TestRunnerQt* to TestRunner*.
3300         (WebCore::DumpRenderTree::dump):
3301             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3302             Instead we should rely on TestRunner::generatePixelResults().
3303         * DumpRenderTree/qt/TestRunnerQt.cpp:
3304         (TestRunnerQt::reset):
3305         * DumpRenderTree/qt/TestRunnerQt.h:
3306         (TestRunnerQt):
3307
3308 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3309
3310         Implement FontLoader interface
3311         https://bugs.webkit.org/show_bug.cgi?id=98395
3312
3313         Reviewed by Eric Seidel.
3314
3315         Enable FontLoadEvents runtime flag for TestShell.
3316
3317         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3318         (WebTestRunner::TestInterfaces::TestInterfaces):
3319
3320 2013-03-13  Julie Parent  <jparent@chromium.org>
3321
3322         CLeanup: remove unnecessary call to parseParameters.
3323         https://bugs.webkit.org/show_bug.cgi?id=112309
3324
3325         Reviewed by Ojan Vafai.
3326         
3327         We call parseCrossDashboardParameters when the dashboard initially
3328         loads to set the state required for loadBuildersList, and then we
3329         call it again once we are fully done with loading, so there is no
3330         reason to call it in the middle of the loading process here.
3331
3332         * TestResultServer/static-dashboards/loader.js:
3333         (.):
3334
3335 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3336
3337         Unreviewed. Now I'm a reviewer :)
3338
3339         * Scripts/webkitpy/common/config/committers.py:
3340
3341 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3342
3343         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3344         https://bugs.webkit.org/show_bug.cgi?id=112277
3345
3346         Reviewed by Adam Barth.
3347
3348         * Scripts/webkitperl/FeatureList.pm:
3349         * qmake/mkspecs/features/features.pri:
3350
3351 2013-03-13  Adam Barth  <abarth@webkit.org>
3352
3353         run-perf-tests should support content_shell
3354         https://bugs.webkit.org/show_bug.cgi?id=112291
3355
3356         Reviewed by Eric Seidel.
3357
3358         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3359         (PerfTestsRunner._parse_args):
3360
3361 2013-03-13  Oliver Hunt  <oliver@apple.com>
3362
3363         Simplify Checked<> multiplication
3364         https://bugs.webkit.org/show_bug.cgi?id=112286
3365
3366         Reviewed by James Robinson.
3367
3368         Add tests for multiplication by zero and max to ensure we don't
3369         mess them up should we ever make changes to Checked<> in future.
3370
3371         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3372         (TestWebKitAPI):
3373
3374 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3375
3376         [Qt] Unreviewed prospective Windows build fix
3377
3378         Do the usual thing, include the moc generated code in the .cpp file instead
3379         of compiling it standalone, to ensure that config.h is included, too, and
3380         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3381
3382         * DumpRenderTree/qt/EventSenderQt.cpp:
3383
3384 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3385
3386         [Qt] Port TestRunner::findString to shared interface
3387         https://bugs.webkit.org/show_bug.cgi?id=112147
3388
3389         Reviewed by Jocelyn Turcotte.
3390
3391         This patch also removes DumpRenderTree and some other helper classes from
3392         the WebCore namespace, to which they do not really belong.
3393
3394         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3395         (main):
3396         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3397         (DumpRenderTree::DumpRenderTree):
3398         (DumpRenderTree::~DumpRenderTree):
3399         (DumpRenderTree::instance):
3400         (DumpRenderTree::setShouldTimeout):
3401         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3402         (DumpRenderTree):
3403         * DumpRenderTree/qt/EventSenderQt.cpp:
3404         (EventSender::contextClick):
3405         (EventSender::sendEvent):
3406         (EventSender::postEvent):
3407         * DumpRenderTree/qt/EventSenderQt.h:
3408         (EventSender::isGraphicsBased):
3409         * DumpRenderTree/qt/TestRunnerQt.cpp:
3410         (TestRunnerQt::TestRunnerQt):
3411         (TestRunner::findString):
3412         (TestRunnerQt::setMockDeviceOrientation):
3413         (TestRunnerQt::setGeolocationPermission):
3414         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3415         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3416         (TestRunnerQt::setMockGeolocationPosition):
3417         * DumpRenderTree/qt/TestRunnerQt.h:
3418         (TestRunnerQt):
3419
3420 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3421
3422         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3423         https://bugs.webkit.org/show_bug.cgi?id=112129
3424
3425         Reviewed by Adam Barth.
3426
3427         Following Chromium
3428         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3429         this is being renamed to better explain what it does.
3430
3431         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3432
3433 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3434
3435         [Qt] Unreviewed trivial typo fix
3436
3437         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3438         TextRunner.h. Thanks Zeno :)
3439
3440 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3441
3442         [Qt] Prepare DRT for transition to shared TestRunner interface
3443         https://bugs.webkit.org/show_bug.cgi?id=112144
3444
3445         Reviewed by Benjamin Poulain.
3446
3447         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3448         the JSC C API based one.
3449
3450         This is impplemented by instantiating the QObject based testRunner in
3451         the global object, then instantiating the JSC C based TestRunner
3452         separately and placing it "behind" the QObject based testRunner through
3453         injection of the individual functions through proxies. (prototype
3454         chaining doesn't work due to the this object and Function.prototype.bind
3455         doesn't work due to the native function)
3456
3457         This allows for porting over method by method by removing the method
3458         from the QObject TestRunnerQt and implementing it in the JSC C based
3459         TestRunner.
3460
3461         In order for this to link and run dummy implementations of all the
3462         necessary TestRunner functions are provided.
3463
3464         * DumpRenderTree/qt/DumpRenderTree.pro:
3465         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3466         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3467         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3468         (WebCore::DumpRenderTree::initJSObjects):
3469         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3470         (DumpRenderTree):
3471         * DumpRenderTree/qt/TestRunnerQt.cpp:
3472         (TestRunner::~TestRunner):
3473         (TestRunner::addDisallowedURL):
3474         (TestRunner::queueLoad):
3475         (TestRunner::removeAllVisitedLinks):
3476         (TestRunner::setAcceptsEditing):
3477         (TestRunner::simulateLegacyWebNotificationClick):
3478         (TestRunner::setWindowIsKey):
3479         (TestRunner::setAlwaysAcceptCookies):
3480         (TestRunner::addOriginAccessWhitelistEntry):
3481         (TestRunner::setWebViewEditable):
3482         (TestRunner::clearAllApplicationCaches):
3483         (TestRunner::setTextDirection):
3484         (TestRunner::notifyDone):
3485         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3486         (TestRunner::overridePreference):
3487         (TestRunner::pathToLocalResource):
3488         (TestRunner::removeAllWebNotificationPermissions):
3489         (TestRunner::simulateWebNotificationClick):
3490         (TestRunner::closeIdleLocalStorageDatabases):
3491         (TestRunner::focusWebView):
3492         (TestRunner::setBackingScaleFactor):
3493         (TestRunner::removeChromeInputField):
3494         (TestRunner::addChromeInputField):
3495         (TestRunner::originsWithLocalStorage):
3496         (TestRunner::deleteAllLocalStorage):
3497         (TestRunner::deleteLocalStorageForOrigin):
3498         (TestRunner::observeStorageTrackerNotifications):
3499         (TestRunner::syncLocalStorage):
3500         (TestRunner::windowCount):
3501         (TestRunner::setWaitToDump):
3502         (TestRunner::waitForPolicyDelegate):
3503         (TestRunner::webHistoryItemCount):
3504         (TestRunner::showWebInspector):
3505         (TestRunner::closeWebInspector):
3506         (TestRunner::evaluateInWebInspector):
3507         (TestRunner::setSerializeHTTPLoads):
3508         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3509         (TestRunner::setCustomPolicyDelegate):
3510         (TestRunner::setDatabaseQuota):
3511         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3512         (TestRunner::resetPageVisibility):
3513         (TestRunner::keepWebHistory):
3514         (TestRunner::goBack):
3515         (TestRunner::originsWithApplicationCache):
3516         (TestRunner::applicationCacheDiskUsageForOrigin):
3517         (TestRunner::display):
3518         (TestRunner::dispatchPendingLoadRequests):
3519         (TestRunner::clearPersistentUserStyleSheet):
3520         (TestRunner::callShouldCloseOnWebView):
3521         (TestRunner::copyDecodedHostName):
3522         (TestRunner::clearBackForwardList):
3523         (TestRunner::clearAllDatabases):
3524         (TestRunner::clearApplicationCacheForOrigin):
3525         (TestRunner::apiTestGoToCurrentBackForwardItem):
3526         (TestRunner::authenticateSession):
3527         (TestRunner::abortModal):
3528         (TestRunner::setStorageDatabaseIdleInterval):
3529         (TestRunner::setAsynchronousSpellCheckingEnabled):
3530         (TestRunner::setXSSAuditorEnabled):
3531         (TestRunner::setSpatialNavigationEnabled):
3532         (TestRunner::setScrollbarPolicy):
3533         (TestRunner::setJavaScriptCanAccessClipboard):
3534         (TestRunner::setAutomaticLinkDetectionEnabled):
3535         (TestRunner::setUserStyleSheetEnabled):
3536         (TestRunner::setUserStyleSheetLocation):
3537         (TestRunner::setUseDashboardCompatibilityMode):
3538         (TestRunner::setTabKeyCyclesThroughElements):
3539         (TestRunner::setSmartInsertDeleteEnabled):
3540         (TestRunner::setSelectTrailingWhitespaceEnabled):
3541         (TestRunner::setPrivateBrowsingEnabled):
3542         (TestRunner::setPluginsEnabled):
3543         (TestRunner::setPopupBlockingEnabled):
3544         (TestRunner::setMockSpeechInputDumpRect):
3545         (TestRunner::setPersistentUserStyleSheetLocation):
3546         (TestRunner::setMockGeolocationPosition):
3547         (TestRunner::setMockGeolocationPositionUnavailableError):
3548         (TestRunner::setMockDeviceOrientation):
3549         (TestRunner::setMainFrameIsFirstResponder):
3550         (TestRunner::setIconDatabaseEnabled):
3551         (TestRunner::setGeolocationPermission):
3552         (TestRunner::setDefersLoading):
3553         (TestRunner::setCacheModel):
3554         (TestRunner::setAuthorAndUserStylesEnabled):
3555         (TestRunner::setAllowFileAccessFromFileURLs):
3556         (TestRunner::setAppCacheMaximumSize):
3557         (TestRunner::setAllowUniversalAccessFromFileURLs):
3558         (TestRunner::setApplicationCacheOriginQuota):
3559         (TestRunner::denyWebNotificationPermission):
3560         (TestRunner::grantWebNotificationPermission):
3561         (TestRunner::setValueForUser):
3562         (TestRunner::setViewModeMediaFeature):
3563         (TestRunner::setPageVisibility):
3564         (TestRunner::addMockSpeechInputResult):
3565         (TestRunner::removeOriginAccessWhitelistEntry):
3566         (TestRunner::addUserScript):
3567         (TestRunner::isCommandEnabled):
3568         (TestRunner::evaluateScriptInIsolatedWorld):
3569         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3570         (TestRunner::copyEncodedHostName):
3571         (TestRunner::addUserStyleSheet):
3572         (TestRunner::findString):
3573         (TestRunner::execCommand):
3574         (TestRunner::localStorageDiskUsageForOrigin):
3575
3576 2013-03-12  Julie Parent  <jparent@chromium.org>
3577
3578         Cleanup: Move flatten-trie to loader.
3579         https://bugs.webkit.org/show_bug.cgi?id=112196
3580
3581         Reviewed by Dirk Pranke.
3582
3583         flatten-trie is used only by the loader, so move it there and make it
3584         private, rather than global in dashbaord_base. Moved the corresponding
3585         unit test from flakiness_dashboard_unittests to loader_unittests.
3586         
3587         * TestResultServer/static-dashboards/dashboard_base.js:
3588         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3589         * TestResultServer/static-dashboards/loader.js:
3590         (.):
3591         * TestResultServer/static-dashboards/loader_unittests.js:
3592
3593 2013-03-12  Oliver Hunt  <oliver@apple.com>
3594
3595         Unbreak api tests
3596
3597         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3598         (TestWebKitAPI):
3599
3600 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3601
3602         Unreviewed, disabling tests for Win EWS.
3603
3604         win-ews obviously cannot keep up with running tests, it's >300 behind.
3605         Probably doesn't help that its (likely) running tests serially.
3606
3607         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3608         (WinEWS):
3609
3610 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3611
3612         Add a --build-directory argument to delete-stale-build-files
3613         https://bugs.webkit.org/show_bug.cgi?id=112198
3614
3615         Reviewed by Ryosuke Niwa.
3616
3617         * BuildSlaveSupport/delete-stale-build-files:
3618         (main): Add --build-directory argument.
3619
3620 2013-03-12  Oliver Hunt  <oliver@apple.com>
3621
3622         Appease MSVC
3623
3624         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3625         (TestWebKitAPI):
3626
3627 2013-03-12  Oliver Hunt  <oliver@apple.com>
3628
3629         Add more Checked<> tests
3630         https://bugs.webkit.org/show_bug.cgi?id=112190
3631
3632         Reviewed by Geoffrey Garen.
3633
3634         Tests!
3635
3636         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3637         (TestWebKitAPI):
3638
3639 2013-03-12  Julie Parent  <jparent@chromium.org>
3640
3641         Cleanup: Move loading complete function into callback, rather than global.
3642         https://bugs.webkit.org/show_bug.cgi?id=112167
3643
3644         Reviewed by Dirk Pranke.
3645         
3646         Stop calling global functions, pass in proper handler to Loader
3647         constructor. Note that the callback is optional, as tests, and
3648         some potential dashboards, do not need one.
3649
3650         * TestResultServer/static-dashboards/dashboard_base.js:
3651         * TestResultServer/static-dashboards/loader.js:
3652         (.):
3653         * TestResultServer/static-dashboards/loader_unittests.js:
3654
3655 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3656
3657         [EFL][WK2] Add popup menu support to MiniBrowser
3658         https://bugs.webkit.org/show_bug.cgi?id=108934
3659
3660         Reviewed by Kenneth Rohde Christiansen.
3661
3662         Implement popup menu support in MiniBrowser by handling popup_menu_show
3663         and popup_menu_hide smart functions on the view and using the Ewk popup
3664         menu API.
3665
3666         * MiniBrowser/efl/main.c:
3667         (_Browser_Window):
3668         (on_popup_menu_discarded):
3669         (on_popup_menu_item_clicked):
3670         (popup_menu_populate):
3671         (on_popup_menu_show):
3672         (on_popup_menu_hide):
3673         (window_create): Use calloc() instead of malloc() to allocate memory for
3674         Browser_Window. This makes sure all the structs members are initialized
3675         to 0 (such as the new elm_popup_menu pointer).
3676
3677 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3678
3679         [GTK] Set up the libPlatformGtk.la library
3680         https://bugs.webkit.org/show_bug.cgi?id=111738
3681
3682         Reviewed by Martin Robinson.
3683
3684         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3685         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
3686         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3687
3688 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3689
3690         [GTK] Enable Web Audio in development builds
3691         https://bugs.webkit.org/show_bug.cgi?id=111831
3692
3693         Reviewed by Philippe Normand.
3694
3695         Web Audio is already quite well supported on the GTK port but still has a few issues
3696         that must be addressed before it is enabled by default. Despite that it should be enabled
3697         in development builds just so we are up-to-date with future feature infrastructure changes.
3698         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3699         that's an obvious goal before enabling the feature in release builds.
3700
3701         * Scripts/webkitperl/FeatureList.pm:
3702
3703 2013-03-11  Andreas Kling  <akling@apple.com>
3704
3705         [Mac][WK1] Add support for alert() in MiniBrowser.
3706         <http://webkit.org/b/112090>
3707
3708         Reviewed by Anders Carlsson.
3709
3710         * MiniBrowser/mac/WK1BrowserWindowController.m:
3711         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3712
3713 2013-03-11  Julie Parent  <jparent@chromium.org>
3714
3715         Dashboard cleanup: Create ui.Errors
3716         https://bugs.webkit.org/show_bug.cgi?id=111785
3717
3718         Reviewed by Ojan Vafai.
3719         
3720         Create ui.Errors for handling errors the dashboards
3721         encounter. Loader now has a Error object that it can add to,
3722         and individual dashboards can show errors when desired.
3723         Currently, only flakiness_db shows errors, but this is 
3724         generic and there is no reason why other dbs wouldn't want to
3725         show errors.
3726
3727         * TestResultServer/static-dashboards/dashboard_base.js:
3728         (resourceLoadingComplete):
3729         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3730         (generatePage):
3731         * TestResultServer/static-dashboards/loader.js:
3732         (.):
3733         * TestResultServer/static-dashboards/ui.js:
3734         (.):
3735
3736 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
3737
3738         Some StringHasher tests are broken because of missing null termination
3739         https://bugs.webkit.org/show_bug.cgi?id=111284
3740
3741         Reviewed by Darin Adler.
3742
3743         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3744         (TestWebKitAPI): Added null termination since C strings are null-terminated.
3745         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
3746         the bug caught by it is now fixed.
3747
3748 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3749
3750         Unreviewed, rolling out r145200.
3751         http://trac.webkit.org/changeset/145200
3752         https://bugs.webkit.org/show_bug.cgi?id=112063
3753
3754         Broke a couple of unit tests (Requested by zdobersek on
3755         #webkit).
3756
3757         * Scripts/webkitperl/FeatureList.pm:
3758
3759 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
3760
3761         [GTK] WebKit2-only build fails
3762         https://bugs.webkit.org/show_bug.cgi?id=112033
3763
3764         Reviewed by Gustavo Noronha Silva.
3765
3766         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
3767         generic part, WebKit1-specific part and WebKit2-specific part.
3768         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
3769         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
3770         directly.
3771
3772 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
3773
3774         Adding myself to the committers list.
3775
3776         Unreviewed.
3777
3778         * Scripts/webkitpy/common/config/committers.py:
3779
3780 2013-03-11  Jeff Rogers  <jrogers@rim.com>
3781
3782         [BlackBerry] Disable MathML support
3783         https://bugs.webkit.org/show_bug.cgi?id=111929
3784
3785         Reviewed by Rob Buis.
3786
3787         * Scripts/webkitperl/FeatureList.pm:
3788
3789 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3790
3791         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
3792         https://bugs.webkit.org/show_bug.cgi?id=111970
3793
3794         Reviewed by Chris Fleizach.
3795
3796         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
3797         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
3798         undefined symbol.
3799
3800         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3801         (WTR::AccessibilityUIElement::supportedActions):
3802         (WTR):
3803
3804 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
3805
3806         [chromium] Android apk targets should depend directly on Java library targets
3807         https://bugs.webkit.org/show_bug.cgi?id=111746
3808
3809         Reviewed by Eric Seidel.
3810
3811         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3812         Make DumpRenderTree_apk depend directly on base_java and net_java.
3813         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3814         Make TestWebKitAPI_apk depend directly on base_java.
3815
3816 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
3817
3818         [chromium] remove obsolete user gesture methods from WebFrame
3819         https://bugs.webkit.org/show_bug.cgi?id=111696
3820
3821         Reviewed by Adam Barth.
3822
3823         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3824         (WebTestRunner::TestPlugin::handleInputEvent):
3825         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3826
3827 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
3828
3829         Unreviewed, add myself to commiters.py.
3830
3831         * Scripts/webkitpy/common/config/committers.py:
3832
3833 2013-03-08  Julie Parent  <jparent@chromium.org>
3834
3835         Cleanup: Remove dead code.
3836         https://bugs.webkit.org/show_bug.cgi?id=111900
3837
3838         Reviewed by Dirk Pranke.
3839         
3840         Treemap overrides a global function that used to be in 
3841         dashboard_base, but was removed months ago in
3842         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
3843         no caller. 
3844
3845         * TestResultServer/static-dashboards/treemap.html:
3846
3847 2013-03-08  Harald Alvestrand  <hta@chromium.org>
3848
3849         Implemented new API for RTCStatsReport object.
3850         https://bugs.webkit.org/show_bug.cgi?id=110333
3851
3852         Reviewed by Adam Barth.
3853
3854         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3855         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
3856
3857 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
3858
3859         [chromium] use custom freetype on linux asan builds again
3860         https://bugs.webkit.org/show_bug.cgi?id=111884
3861
3862         Reviewed by Tony Chang.
3863
3864         We no longer need the workaround after chromium r186540.
3865
3866         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3867
3868 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
3869
3870         Warning about the user not having edit rights on Bugzilla is confusing new contributors
3871         https://bugs.webkit.org/show_bug.cgi?id=111798
3872
3873         Reviewed by Dirk Pranke.
3874
3875         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
3876
3877         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3878
3879 2013-03-08  James Robinson  <jamesr@chromium.org>
3880
3881         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
3882         https://bugs.webkit.org/show_bug.cgi?id=111632
3883
3884         Reviewed by Adrienne Walker.
3885
3886         * DumpRenderTree/chromium/WebViewHost.cpp:
3887         (WebViewHost::initializeLayerTreeView):
3888         * DumpRenderTree/chromium/WebViewHost.h:
3889         (WebViewHost):
3890
3891 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
3892
3893         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
3894         https://bugs.webkit.org/show_bug.cgi?id=111297
3895
3896         Reviewed by Kenneth Rohde Christiansen.
3897
3898         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3899         (WTR::TestRunner::setViewModeMediaFeature):
3900
3901 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
3902
3903         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
3904         https://bugs.webkit.org/show_bug.cgi?id=111814
3905
3906         Reviewed by Ryosuke Niwa.
3907
3908         Add the needed supportedActions() attribute to WKTestRunner.
3909
3910         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3911         (WTR::AccessibilityUIElement::supportedActions):
3912         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3913         (AccessibilityUIElement):
3914         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3915         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3916         (WTR::AccessibilityUIElement::supportedActions):
3917
3918 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3919
3920         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
3921         https://bugs.webkit.org/show_bug.cgi?id=111851
3922
3923         Reviewed by Kenneth Rohde Christiansen.
3924
3925         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3926         (TestWebKitAPI::TEST):
3927
3928             Fixed WKURLRef instance leaking.
3929
3930 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3931
3932         [EFL] [WK2] Some authentication tests fail in WebKit2
3933         https://bugs.webkit.org/show_bug.cgi?id=106407
3934
3935         Reviewed by Kenneth Rohde Christiansen.
3936
3937         Add patch from upstream for libsoup 2.40 to fix several authentication
3938         test cases.
3939
3940         * efl/jhbuild.modules:
3941         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
3942
3943 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
3944
3945         [GTK] Enable Web Audio in development builds
3946         https://bugs.webkit.org/show_bug.cgi?id=111831
3947
3948         Reviewed by Philippe Normand.
3949
3950         Web Audio is already quite well supported on the GTK port but still has a few issues
3951         that must be addressed before it is enabled by default. Despite that it should be enabled
3952         in development builds just so we are up-to-date with future feature infrastructure changes.
3953         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3954         that's an obvious goal before enabling the feature in release builds.
3955
3956         * Scripts/webkitperl/FeatureList.pm:
3957
3958 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3959
3960         [chromium] delay clearing the TestRunners until the main view was deleted
3961         https://bugs.webkit.org/show_bug.cgi?id=111823
3962
3963         Reviewed by Eric Seidel.
3964
3965         During WebViewHost::shutdown, we navigate the WebView to about:blank.
3966         This may call into the test runners which assume that the delegate is
3967         always non-NULL.
3968
3969         * DumpRenderTree/chromium/TestShell.cpp:
3970         (TestShell::~TestShell):
3971
3972 2013-03-07  Alan Cutter  <alancutter@chromium.org>
3973
3974         Sheriffbot whois command can't search by full name
3975         https://bugs.webkit.org/show_bug.cgi?id=111825
3976
3977         Reviewed by Eric Seidel.
3978
3979         Allowed multiple arguments to Sheriffbot's whois command.
3980         Updated test expectations.
3981
3982         * Scripts/webkitpy/tool/bot/irc_command.py:
3983         (Whois.execute):
3984         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3985         (IRCCommandTest.test_whois):
3986
3987 2013-03-07  Nils Barth  <nbarth@chromium.org>
3988
3989         Add Nils Barth and Koji Hara to committers.py
3990         https://bugs.webkit.org/show_bug.cgi?id=111806
3991
3992         Reviewed by Eric Seidel.
3993
3994         * Scripts/webkitpy/common/config/committers.py:
3995
3996 2013-03-07  Glenn Adams  <glenn@skynav.com>
3997
3998         run-pert-tests should have a --test-runner-count option
3999         https://bugs.webkit.org/show_bug.cgi?id=111726
4000
4001         Reviewed by Ryosuke Niwa.
4002
4003         Add --test-runner-count option to run-perf-tests, with default value of 4.
4004         This option allows command line configuration of the number of times to invoke
4005         the test runner (serially, not in parallel) when running a specific test in
4006         a test set.
4007
4008         * Scripts/webkitpy/performance_tests/perftest.py:
4009         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
4010         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
4011         (PerfTest.run): Rename process_run_count to test_runner_count.
4012         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
4013         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
4014         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
4015         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
4016         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4017         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
4018         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
4019         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
4020         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
4021         (MainTest.test_run_with_repeat):
4022         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
4023         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4024         (MainTest.test_default_args): Add test for default option argument values.
4025         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
4026
4027 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
4028
4029         Add myself to reviewers.py
4030         https://bugs.webkit.org/show_bug.cgi?id=111757
4031
4032         Reviewed by Eric Seidel.
4033
4034         * Scripts/webkitpy/common/config/committers.py:
4035
4036 2013-03-07  Glenn Adams  <glenn@skynav.com>
4037
4038         run-perf-tests should have a --repeat option
4039         https://bugs.webkit.org/show_bug.cgi?id=100030
4040
4041         Reviewed by Ryosuke Niwa.
4042
4043         Add --repeat option to run-perf-tests, with default value of 1. When greater
4044         than 1, runs test set specified number of times. Note that multiple runs are
4045         not aggregated for statistical purposes.
4046
4047         Incidentally fixed typo: s/suceeds/succeeds/.
4048
4049         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4050         (PerfTestsRunner._parse_args): Add repeat option.
4051         (PerfTestsRunner.run): Add outer repeat loop.
4052         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
4053         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
4054         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
4055         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
4056         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
4057         (MainTest.test_run_with_json_output): Fix typo.
4058         (MainTest.test_run_with_description): Fix typo.
4059         (MainTest.test_run_respects_no_results): Fix typo.
4060         (MainTest.test_run_with_slave_config_json): Fix typo.
4061         (MainTest.test_run_with_multiple_repositories): Fix typo.
4062         (MainTest.test_run_with_upload_json): Fix typo.
4063         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
4064         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
4065         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4066         (MainTest.test_parse_args): Add test for repeat option parsing.
4067
4068 2013-03-07  Julie Parent  <jparent@chromium.org>
4069
4070         showAllRuns checkbox no longer works on the stats dashboard
4071         https://bugs.webkit.org/show_bug.cgi?id=111673
4072
4073         Reviewed by Ojan Vafai.
4074
4075         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
4076         so we were trying to index into an undefined object.
4077         
4078         * TestResultServer/static-dashboards/dashboard_base.js:
4079         (invalidateQueryParameters):
4080
4081 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
4082
4083         [Chromium] Update #include for WebStorageNamespace.h
4084         https://bugs.webkit.org/show_bug.cgi?id=111748
4085
4086         Reviewed by Adam Barth.
4087
4088         In anticipation of removing
4089         WK/chromium/public/WebStorageNamespace.h (once downstream
4090         references have been updated)
4091
4092         * DumpRenderTree/chromium/WebViewHost.cpp:
4093
4094 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
4095
4096         run-perf-tests fails due to svn_revision not working on a pure git clone
4097         https://bugs.webkit.org/show_bug.cgi?id=110839
4098
4099         Reviewed by Ryosuke Niwa.
4100
4101         Previously we would call git svn find-rev to look up the commit for
4102         a given revision, and that'll hang in a pure git checkout.
4103
4104         This patch changes the way we look up svn revisions in a git
4105         repository to use git log --grep 'git-svn-id', which is much faster
4106         than grepping ourselves. It also renames timestamp_of_latest_commit()
4107         to timestamp_of_revision() in order to accurately reflect what
4108         the method is doing. Note that this patch only changes the logic
4109         inside latest_revision() and svn_revision(). I'll file a separate
4110         bug to change git_commit_from_svn_revision().
4111
4112         This patch also contains some fixes to unit tests that had bit-rotted
4113         or were otherwise fragile, so that test-webkitpy --all would pass
4114         cleanly, and a fix to outputcapture so that
4115         test-webkitpy -p would work correctly again.
4116
4117         * Scripts/webkitpy/common/checkout/scm/git.py:
4118         (Git.svn_revision):
4119         (Git.timestamp_of_revision):
4120         * Scripts/webkitpy/common/checkout/scm/scm.py:
4121         (SCM.svn_revision):
4122         (SCM.timestamp_of_revision):
4123         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
4124         (MockSCM.timestamp_of_revision):
4125         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4126         (_shared_test_commit_with_message):
4127         (test_commit_without_authorization):
4128         (test_timestamp_of_revision):
4129         * Scripts/webkitpy/common/checkout/scm/svn.py:
4130         (SVN.timestamp_of_revision):
4131         * Scripts/webkitpy/common/system/outputcapture.py:
4132           Importing unittest2 directly may not be safe if this module is
4133           imported before the autoinstaller gets a chance to set things up
4134           properly. We don't actually need unittest2 here.
4135         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4136         (PerfTestsRunner._generate_results_dict):
4137
4138 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4139
4140         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
4141         https://bugs.webkit.org/show_bug.cgi?id=111756
4142
4143         Reviewed by Kenneth Rohde Christiansen.
4144
4145         Bump libsoup to v2.40.3 to fix the regressions introduced by
4146         previous v2.40.0 bump.
4147
4148         * efl/jhbuild.modules:
4149
4150 2013-03-07  Roger Fong  <roger_fong@apple.com>
4151
4152         Re-enable Win EWS tests.
4153
4154         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4155         (WinEWS):
4156
4157 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
4158
4159         [nrwt] handle corrupt http server pid files cleanly
4160         https://bugs.webkit.org/show_bug.cgi?id=111628
4161
4162         Reviewed by Eric Seidel.
4163
4164         If the pid file from a previous http server is corrupt for some
4165         reason, NRWT will just raise errors and not clean it up or recover.
4166         This patch fixes that to at least delete the pid file and
4167         not throw; not that we may still have stale http servers left on
4168         the system, since there's no way to know which pid to kill if
4169         the file was corrupted.
4170
4171         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
4172         (HttpServerBase.start):
4173         (HttpServerBase.stop):
4174         (HttpServerBase._remove_pid_file):
4175         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
4176         (TestHttpServerBase):
4177         (TestHttpServerBase.test_corrupt_pid_file):
4178
4179 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
4180
4181         AX: Can't activate links with VoiceOver in Safari
4182         https://bugs.webkit.org/show_bug.cgi?id=111755
4183
4184         Reviewed by Tim Horton.
4185
4186         * DumpRenderTree/AccessibilityUIElement.cpp:
4187         (supportedActionsCallback):
4188         (AccessibilityUIElement::getJSClass):
4189         * DumpRenderTree/AccessibilityUIElement.h:
4190         (AccessibilityUIElement):
4191         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4192         (AccessibilityUIElement::supportedActions):
4193
4194 2013-03-07  Roger Fong  <roger_fong@apple.com>
4195
4196         Windows debug layout tests are crashing like crazy again.
4197         Disable tests on Win EWS bots temporarily.
4198
4199         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4200         (WinEWS):
4201
4202 2013-03-07  Roger Fong  <roger_fong@apple.com>
4203
4204         Make EWS bots build and test in release.
4205
4206         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4207         (WinEWS):
4208         * Scripts/webkitpy/tool/steps/runtests.py:
4209         (RunTests.run):
4210
4211 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
4212
4213         [chromium] don't track the top loading frame if no layout test is currently running
4214         https://bugs.webkit.org/show_bug.cgi?id=111716
4215
4216         Reviewed by Kentaro Hara.
4217
4218         In DRT, we synchronously stop the test and start loading the next test
4219         URL. However, in content_shell, this happens asynchronously. It's
4220         important that the top loading frame is not changed due to stray
4221         navigation events before the next test starts.
4222
4223         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4224         (WebTestRunner::TestRunner::setTopLoadingFrame):
4225
4226 2013-03-06  Julie Parent  <jparent@chromium.org>
4227
4228         Dashboard cleanup: Move all dashboard ui related code into ui.js.
4229         https://bugs.webkit.org/show_bug.cgi?id=111621
4230
4231         Reviewed by Ojan Vafai.
4232         
4233         Creates ui.js, a package for the common UI code the various
4234         dashboards use. HTML generation is now in the ui.html namespace
4235         and popup handling is in ui.popup.
4236         Also moves the event listening for popups to ui.popup.show and
4237         removes it on ui.popup.hid rather than having listener always
4238         around.
4239
4240         * TestResultServer/static-dashboards/aggregate_results.html:
4241         * TestResultServer/static-dashboards/dashboard_base.js:
4242         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4243         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4244         (showPopupForBuild):
4245         (htmlForNavBar):
4246         (generatePageForIndividualTests.if):
4247         (generatePageForIndividualTests):
4248         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
4249         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4250         * TestResultServer/static-dashboards/run-embedded-unittests.html:
4251         * TestResultServer/static-dashboards/run-unittests.html:
4252         * TestResultServer/static-dashboards/timeline_explorer.html:
4253         * TestResultServer/static-dashboards/treemap.html:
4254         * TestResultServer/static-dashboards/ui.js: Added.
4255         (.):
4256
4257 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
4258
4259         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
4260         https://bugs.webkit.org/show_bug.cgi?id=110584
4261
4262         Reviewed by Gyuyoung Kim.
4263
4264         Adds missing implementation of AccessibilityControllerEfl
4265         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
4266         so that it can make accessibilityController as a js object.
4267
4268         * DumpRenderTree/AccessibilityController.h:
4269         (AccessibilityController):
4270         * DumpRenderTree/AccessibilityUIElement.h:
4271         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
4272         (AccessibilityController::childElementById): Moved declaration to base class.
4273         Implementation can be shared among other ports.
4274         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
4275         (AccessibilityController::focusedElement):
4276         (AccessibilityController::rootElement):
4277         (AccessibilityController::accessibleElementById):
4278         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
4279         (AccessibilityUIElement::helpText):
4280         * DumpRenderTree/efl/CMakeLists.txt:
4281         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4282         (DumpRenderTreeChrome::DumpRenderTreeChrome):
4283         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4284         (DumpRenderTreeChrome::onWindowObjectCleared):
4285         (DumpRenderTreeChrome::accessibilityController