Appease MSVC
[WebKit-https.git] / Tools / ChangeLog
1 2013-03-12  Oliver Hunt  <oliver@apple.com>
2
3         Appease MSVC
4
5         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
6         (TestWebKitAPI):
7
8 2013-03-12  Oliver Hunt  <oliver@apple.com>
9
10         Add more Checked<> tests
11         https://bugs.webkit.org/show_bug.cgi?id=112190
12
13         Reviewed by Geoffrey Garen.
14
15         Tests!
16
17         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
18         (TestWebKitAPI):
19
20 2013-03-12  Julie Parent  <jparent@chromium.org>
21
22         Cleanup: Move loading complete function into callback, rather than global.
23         https://bugs.webkit.org/show_bug.cgi?id=112167
24
25         Reviewed by Dirk Pranke.
26         
27         Stop calling global functions, pass in proper handler to Loader
28         constructor. Note that the callback is optional, as tests, and
29         some potential dashboards, do not need one.
30
31         * TestResultServer/static-dashboards/dashboard_base.js:
32         * TestResultServer/static-dashboards/loader.js:
33         (.):
34         * TestResultServer/static-dashboards/loader_unittests.js:
35
36 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
37
38         [EFL][WK2] Add popup menu support to MiniBrowser
39         https://bugs.webkit.org/show_bug.cgi?id=108934
40
41         Reviewed by Kenneth Rohde Christiansen.
42
43         Implement popup menu support in MiniBrowser by handling popup_menu_show
44         and popup_menu_hide smart functions on the view and using the Ewk popup
45         menu API.
46
47         * MiniBrowser/efl/main.c:
48         (_Browser_Window):
49         (on_popup_menu_discarded):
50         (on_popup_menu_item_clicked):
51         (popup_menu_populate):
52         (on_popup_menu_show):
53         (on_popup_menu_hide):
54         (window_create): Use calloc() instead of malloc() to allocate memory for
55         Browser_Window. This makes sure all the structs members are initialized
56         to 0 (such as the new elm_popup_menu pointer).
57
58 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
59
60         [GTK] Set up the libPlatformGtk.la library
61         https://bugs.webkit.org/show_bug.cgi?id=111738
62
63         Reviewed by Martin Robinson.
64
65         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
66         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
67         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
68
69 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
70
71         [GTK] Enable Web Audio in development builds
72         https://bugs.webkit.org/show_bug.cgi?id=111831
73
74         Reviewed by Philippe Normand.
75
76         Web Audio is already quite well supported on the GTK port but still has a few issues
77         that must be addressed before it is enabled by default. Despite that it should be enabled
78         in development builds just so we are up-to-date with future feature infrastructure changes.
79         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
80         that's an obvious goal before enabling the feature in release builds.
81
82         * Scripts/webkitperl/FeatureList.pm:
83
84 2013-03-11  Andreas Kling  <akling@apple.com>
85
86         [Mac][WK1] Add support for alert() in MiniBrowser.
87         <http://webkit.org/b/112090>
88
89         Reviewed by Anders Carlsson.
90
91         * MiniBrowser/mac/WK1BrowserWindowController.m:
92         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
93
94 2013-03-11  Julie Parent  <jparent@chromium.org>
95
96         Dashboard cleanup: Create ui.Errors
97         https://bugs.webkit.org/show_bug.cgi?id=111785
98
99         Reviewed by Ojan Vafai.
100         
101         Create ui.Errors for handling errors the dashboards
102         encounter. Loader now has a Error object that it can add to,
103         and individual dashboards can show errors when desired.
104         Currently, only flakiness_db shows errors, but this is 
105         generic and there is no reason why other dbs wouldn't want to
106         show errors.
107
108         * TestResultServer/static-dashboards/dashboard_base.js:
109         (resourceLoadingComplete):
110         * TestResultServer/static-dashboards/flakiness_dashboard.js:
111         (generatePage):
112         * TestResultServer/static-dashboards/loader.js:
113         (.):
114         * TestResultServer/static-dashboards/ui.js:
115         (.):
116
117 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
118
119         Some StringHasher tests are broken because of missing null termination
120         https://bugs.webkit.org/show_bug.cgi?id=111284
121
122         Reviewed by Darin Adler.
123
124         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
125         (TestWebKitAPI): Added null termination since C strings are null-terminated.
126         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
127         the bug caught by it is now fixed.
128
129 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
130
131         Unreviewed, rolling out r145200.
132         http://trac.webkit.org/changeset/145200
133         https://bugs.webkit.org/show_bug.cgi?id=112063
134
135         Broke a couple of unit tests (Requested by zdobersek on
136         #webkit).
137
138         * Scripts/webkitperl/FeatureList.pm:
139
140 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
141
142         [GTK] WebKit2-only build fails
143         https://bugs.webkit.org/show_bug.cgi?id=112033
144
145         Reviewed by Gustavo Noronha Silva.
146
147         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
148         generic part, WebKit1-specific part and WebKit2-specific part.
149         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
150         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
151         directly.
152
153 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
154
155         Adding myself to the committers list.
156
157         Unreviewed.
158
159         * Scripts/webkitpy/common/config/committers.py:
160
161 2013-03-11  Jeff Rogers  <jrogers@rim.com>
162
163         [BlackBerry] Disable MathML support
164         https://bugs.webkit.org/show_bug.cgi?id=111929
165
166         Reviewed by Rob Buis.
167
168         * Scripts/webkitperl/FeatureList.pm:
169
170 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
171
172         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
173         https://bugs.webkit.org/show_bug.cgi?id=111970
174
175         Reviewed by Chris Fleizach.
176
177         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
178         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
179         undefined symbol.
180
181         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
182         (WTR::AccessibilityUIElement::supportedActions):
183         (WTR):
184
185 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
186
187         [chromium] Android apk targets should depend directly on Java library targets
188         https://bugs.webkit.org/show_bug.cgi?id=111746
189
190         Reviewed by Eric Seidel.
191
192         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
193         Make DumpRenderTree_apk depend directly on base_java and net_java.
194         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
195         Make TestWebKitAPI_apk depend directly on base_java.
196
197 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
198
199         [chromium] remove obsolete user gesture methods from WebFrame
200         https://bugs.webkit.org/show_bug.cgi?id=111696
201
202         Reviewed by Adam Barth.
203
204         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
205         (WebTestRunner::TestPlugin::handleInputEvent):
206         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
207
208 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
209
210         Unreviewed, add myself to commiters.py.
211
212         * Scripts/webkitpy/common/config/committers.py:
213
214 2013-03-08  Julie Parent  <jparent@chromium.org>
215
216         Cleanup: Remove dead code.
217         https://bugs.webkit.org/show_bug.cgi?id=111900
218
219         Reviewed by Dirk Pranke.
220         
221         Treemap overrides a global function that used to be in 
222         dashboard_base, but was removed months ago in
223         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
224         no caller. 
225
226         * TestResultServer/static-dashboards/treemap.html:
227
228 2013-03-08  Harald Alvestrand  <hta@chromium.org>
229
230         Implemented new API for RTCStatsReport object.
231         https://bugs.webkit.org/show_bug.cgi?id=110333
232
233         Reviewed by Adam Barth.
234
235         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
236         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
237
238 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
239
240         [chromium] use custom freetype on linux asan builds again
241         https://bugs.webkit.org/show_bug.cgi?id=111884
242
243         Reviewed by Tony Chang.
244
245         We no longer need the workaround after chromium r186540.
246
247         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
248
249 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
250
251         Warning about the user not having edit rights on Bugzilla is confusing new contributors
252         https://bugs.webkit.org/show_bug.cgi?id=111798
253
254         Reviewed by Dirk Pranke.
255
256         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
257
258         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
259
260 2013-03-08  James Robinson  <jamesr@chromium.org>
261
262         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
263         https://bugs.webkit.org/show_bug.cgi?id=111632
264
265         Reviewed by Adrienne Walker.
266
267         * DumpRenderTree/chromium/WebViewHost.cpp:
268         (WebViewHost::initializeLayerTreeView):
269         * DumpRenderTree/chromium/WebViewHost.h:
270         (WebViewHost):
271
272 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
273
274         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
275         https://bugs.webkit.org/show_bug.cgi?id=111297
276
277         Reviewed by Kenneth Rohde Christiansen.
278
279         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
280         (WTR::TestRunner::setViewModeMediaFeature):
281
282 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
283
284         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
285         https://bugs.webkit.org/show_bug.cgi?id=111814
286
287         Reviewed by Ryosuke Niwa.
288
289         Add the needed supportedActions() attribute to WKTestRunner.
290
291         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
292         (WTR::AccessibilityUIElement::supportedActions):
293         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
294         (AccessibilityUIElement):
295         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
296         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
297         (WTR::AccessibilityUIElement::supportedActions):
298
299 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
300
301         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
302         https://bugs.webkit.org/show_bug.cgi?id=111851
303
304         Reviewed by Kenneth Rohde Christiansen.
305
306         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
307         (TestWebKitAPI::TEST):
308
309             Fixed WKURLRef instance leaking.
310
311 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
312
313         [EFL] [WK2] Some authentication tests fail in WebKit2
314         https://bugs.webkit.org/show_bug.cgi?id=106407
315
316         Reviewed by Kenneth Rohde Christiansen.
317
318         Add patch from upstream for libsoup 2.40 to fix several authentication
319         test cases.
320
321         * efl/jhbuild.modules:
322         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
323
324 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
325
326         [GTK] Enable Web Audio in development builds
327         https://bugs.webkit.org/show_bug.cgi?id=111831
328
329         Reviewed by Philippe Normand.
330
331         Web Audio is already quite well supported on the GTK port but still has a few issues
332         that must be addressed before it is enabled by default. Despite that it should be enabled
333         in development builds just so we are up-to-date with future feature infrastructure changes.
334         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
335         that's an obvious goal before enabling the feature in release builds.
336
337         * Scripts/webkitperl/FeatureList.pm:
338
339 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
340
341         [chromium] delay clearing the TestRunners until the main view was deleted
342         https://bugs.webkit.org/show_bug.cgi?id=111823
343
344         Reviewed by Eric Seidel.
345
346         During WebViewHost::shutdown, we navigate the WebView to about:blank.
347         This may call into the test runners which assume that the delegate is
348         always non-NULL.
349
350         * DumpRenderTree/chromium/TestShell.cpp:
351         (TestShell::~TestShell):
352
353 2013-03-07  Alan Cutter  <alancutter@chromium.org>
354
355         Sheriffbot whois command can't search by full name
356         https://bugs.webkit.org/show_bug.cgi?id=111825
357
358         Reviewed by Eric Seidel.
359
360         Allowed multiple arguments to Sheriffbot's whois command.
361         Updated test expectations.
362
363         * Scripts/webkitpy/tool/bot/irc_command.py:
364         (Whois.execute):
365         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
366         (IRCCommandTest.test_whois):
367
368 2013-03-07  Nils Barth  <nbarth@chromium.org>
369
370         Add Nils Barth and Koji Hara to committers.py
371         https://bugs.webkit.org/show_bug.cgi?id=111806
372
373         Reviewed by Eric Seidel.
374
375         * Scripts/webkitpy/common/config/committers.py:
376
377 2013-03-07  Glenn Adams  <glenn@skynav.com>
378
379         run-pert-tests should have a --test-runner-count option
380         https://bugs.webkit.org/show_bug.cgi?id=111726
381
382         Reviewed by Ryosuke Niwa.
383
384         Add --test-runner-count option to run-perf-tests, with default value of 4.
385         This option allows command line configuration of the number of times to invoke
386         the test runner (serially, not in parallel) when running a specific test in
387         a test set.
388
389         * Scripts/webkitpy/performance_tests/perftest.py:
390         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
391         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
392         (PerfTest.run): Rename process_run_count to test_runner_count.
393         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
394         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
395         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
396         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
397         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
398         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
399         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
400         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
401         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
402         (MainTest.test_run_with_repeat):
403         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
404         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
405         (MainTest.test_default_args): Add test for default option argument values.
406         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
407
408 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
409
410         Add myself to reviewers.py
411         https://bugs.webkit.org/show_bug.cgi?id=111757
412
413         Reviewed by Eric Seidel.
414
415         * Scripts/webkitpy/common/config/committers.py:
416
417 2013-03-07  Glenn Adams  <glenn@skynav.com>
418
419         run-perf-tests should have a --repeat option
420         https://bugs.webkit.org/show_bug.cgi?id=100030
421
422         Reviewed by Ryosuke Niwa.
423
424         Add --repeat option to run-perf-tests, with default value of 1. When greater
425         than 1, runs test set specified number of times. Note that multiple runs are
426         not aggregated for statistical purposes.
427
428         Incidentally fixed typo: s/suceeds/succeeds/.
429
430         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
431         (PerfTestsRunner._parse_args): Add repeat option.
432         (PerfTestsRunner.run): Add outer repeat loop.
433         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
434         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
435         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
436         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
437         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
438         (MainTest.test_run_with_json_output): Fix typo.
439         (MainTest.test_run_with_description): Fix typo.
440         (MainTest.test_run_respects_no_results): Fix typo.
441         (MainTest.test_run_with_slave_config_json): Fix typo.
442         (MainTest.test_run_with_multiple_repositories): Fix typo.
443         (MainTest.test_run_with_upload_json): Fix typo.
444         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
445         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
446         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
447         (MainTest.test_parse_args): Add test for repeat option parsing.
448
449 2013-03-07  Julie Parent  <jparent@chromium.org>
450
451         showAllRuns checkbox no longer works on the stats dashboard
452         https://bugs.webkit.org/show_bug.cgi?id=111673
453
454         Reviewed by Ojan Vafai.
455
456         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
457         so we were trying to index into an undefined object.
458         
459         * TestResultServer/static-dashboards/dashboard_base.js:
460         (invalidateQueryParameters):
461
462 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
463
464         [Chromium] Update #include for WebStorageNamespace.h
465         https://bugs.webkit.org/show_bug.cgi?id=111748
466
467         Reviewed by Adam Barth.
468
469         In anticipation of removing
470         WK/chromium/public/WebStorageNamespace.h (once downstream
471         references have been updated)
472
473         * DumpRenderTree/chromium/WebViewHost.cpp:
474
475 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
476
477         run-perf-tests fails due to svn_revision not working on a pure git clone
478         https://bugs.webkit.org/show_bug.cgi?id=110839
479
480         Reviewed by Ryosuke Niwa.
481
482         Previously we would call git svn find-rev to look up the commit for
483         a given revision, and that'll hang in a pure git checkout.
484
485         This patch changes the way we look up svn revisions in a git
486         repository to use git log --grep 'git-svn-id', which is much faster
487         than grepping ourselves. It also renames timestamp_of_latest_commit()
488         to timestamp_of_revision() in order to accurately reflect what
489         the method is doing. Note that this patch only changes the logic
490         inside latest_revision() and svn_revision(). I'll file a separate
491         bug to change git_commit_from_svn_revision().
492
493         This patch also contains some fixes to unit tests that had bit-rotted
494         or were otherwise fragile, so that test-webkitpy --all would pass
495         cleanly, and a fix to outputcapture so that
496         test-webkitpy -p would work correctly again.
497
498         * Scripts/webkitpy/common/checkout/scm/git.py:
499         (Git.svn_revision):
500         (Git.timestamp_of_revision):
501         * Scripts/webkitpy/common/checkout/scm/scm.py:
502         (SCM.svn_revision):
503         (SCM.timestamp_of_revision):
504         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
505         (MockSCM.timestamp_of_revision):
506         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
507         (_shared_test_commit_with_message):
508         (test_commit_without_authorization):
509         (test_timestamp_of_revision):
510         * Scripts/webkitpy/common/checkout/scm/svn.py:
511         (SVN.timestamp_of_revision):
512         * Scripts/webkitpy/common/system/outputcapture.py:
513           Importing unittest2 directly may not be safe if this module is
514           imported before the autoinstaller gets a chance to set things up
515           properly. We don't actually need unittest2 here.
516         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
517         (PerfTestsRunner._generate_results_dict):
518
519 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
520
521         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
522         https://bugs.webkit.org/show_bug.cgi?id=111756
523
524         Reviewed by Kenneth Rohde Christiansen.
525
526         Bump libsoup to v2.40.3 to fix the regressions introduced by
527         previous v2.40.0 bump.
528
529         * efl/jhbuild.modules:
530
531 2013-03-07  Roger Fong  <roger_fong@apple.com>
532
533         Re-enable Win EWS tests.
534
535         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
536         (WinEWS):
537
538 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
539
540         [nrwt] handle corrupt http server pid files cleanly
541         https://bugs.webkit.org/show_bug.cgi?id=111628
542
543         Reviewed by Eric Seidel.
544
545         If the pid file from a previous http server is corrupt for some
546         reason, NRWT will just raise errors and not clean it up or recover.
547         This patch fixes that to at least delete the pid file and
548         not throw; not that we may still have stale http servers left on
549         the system, since there's no way to know which pid to kill if
550         the file was corrupted.
551
552         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
553         (HttpServerBase.start):
554         (HttpServerBase.stop):
555         (HttpServerBase._remove_pid_file):
556         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
557         (TestHttpServerBase):
558         (TestHttpServerBase.test_corrupt_pid_file):
559
560 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
561
562         AX: Can't activate links with VoiceOver in Safari
563         https://bugs.webkit.org/show_bug.cgi?id=111755
564
565         Reviewed by Tim Horton.
566
567         * DumpRenderTree/AccessibilityUIElement.cpp:
568         (supportedActionsCallback):
569         (AccessibilityUIElement::getJSClass):
570         * DumpRenderTree/AccessibilityUIElement.h:
571         (AccessibilityUIElement):
572         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
573         (AccessibilityUIElement::supportedActions):
574
575 2013-03-07  Roger Fong  <roger_fong@apple.com>
576
577         Windows debug layout tests are crashing like crazy again.
578         Disable tests on Win EWS bots temporarily.
579
580         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
581         (WinEWS):
582
583 2013-03-07  Roger Fong  <roger_fong@apple.com>
584
585         Make EWS bots build and test in release.
586
587         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
588         (WinEWS):
589         * Scripts/webkitpy/tool/steps/runtests.py:
590         (RunTests.run):
591
592 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
593
594         [chromium] don't track the top loading frame if no layout test is currently running
595         https://bugs.webkit.org/show_bug.cgi?id=111716
596
597         Reviewed by Kentaro Hara.
598
599         In DRT, we synchronously stop the test and start loading the next test
600         URL. However, in content_shell, this happens asynchronously. It's
601         important that the top loading frame is not changed due to stray
602         navigation events before the next test starts.
603
604         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
605         (WebTestRunner::TestRunner::setTopLoadingFrame):
606
607 2013-03-06  Julie Parent  <jparent@chromium.org>
608
609         Dashboard cleanup: Move all dashboard ui related code into ui.js.
610         https://bugs.webkit.org/show_bug.cgi?id=111621
611
612         Reviewed by Ojan Vafai.
613         
614         Creates ui.js, a package for the common UI code the various
615         dashboards use. HTML generation is now in the ui.html namespace
616         and popup handling is in ui.popup.
617         Also moves the event listening for popups to ui.popup.show and
618         removes it on ui.popup.hid rather than having listener always
619         around.
620
621         * TestResultServer/static-dashboards/aggregate_results.html:
622         * TestResultServer/static-dashboards/dashboard_base.js:
623         * TestResultServer/static-dashboards/flakiness_dashboard.html:
624         * TestResultServer/static-dashboards/flakiness_dashboard.js:
625         (showPopupForBuild):
626         (htmlForNavBar):
627         (generatePageForIndividualTests.if):
628         (generatePageForIndividualTests):
629         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
630         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
631         * TestResultServer/static-dashboards/run-embedded-unittests.html:
632         * TestResultServer/static-dashboards/run-unittests.html:
633         * TestResultServer/static-dashboards/timeline_explorer.html:
634         * TestResultServer/static-dashboards/treemap.html:
635         * TestResultServer/static-dashboards/ui.js: Added.
636         (.):
637
638 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
639
640         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
641         https://bugs.webkit.org/show_bug.cgi?id=110584
642
643         Reviewed by Gyuyoung Kim.
644
645         Adds missing implementation of AccessibilityControllerEfl
646         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
647         so that it can make accessibilityController as a js object.
648
649         * DumpRenderTree/AccessibilityController.h:
650         (AccessibilityController):
651         * DumpRenderTree/AccessibilityUIElement.h:
652         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
653         (AccessibilityController::childElementById): Moved declaration to base class.
654         Implementation can be shared among other ports.
655         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
656         (AccessibilityController::focusedElement):
657         (AccessibilityController::rootElement):
658         (AccessibilityController::accessibleElementById):
659         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
660         (AccessibilityUIElement::helpText):
661         * DumpRenderTree/efl/CMakeLists.txt:
662         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
663         (DumpRenderTreeChrome::DumpRenderTreeChrome):
664         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
665         (DumpRenderTreeChrome::onWindowObjectCleared):
666         (DumpRenderTreeChrome::accessibilityController):
667         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
668         (DumpRenderTreeChrome):
669         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
670
671 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
672
673         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
674         https://bugs.webkit.org/show_bug.cgi?id=42696
675
676         Reviewed by Andreas Kling.
677
678         * DumpRenderTree/TestRunner.cpp:
679         (TestRunner::staticFunctions):
680         * DumpRenderTree/TestRunner.h:
681         (TestRunner):
682         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
683         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
684         (WebTestRunner::TestRunner::TestRunner):
685         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
686         (TestRunner):
687         * DumpRenderTree/efl/TestRunnerEfl.cpp:
688         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
689         * DumpRenderTree/mac/TestRunnerMac.mm:
690         * DumpRenderTree/qt/TestRunnerQt.cpp:
691         * DumpRenderTree/qt/TestRunnerQt.h:
692         (TestRunnerQt):
693         * DumpRenderTree/win/TestRunnerWin.cpp:
694         * DumpRenderTree/wx/TestRunnerWx.cpp:
695
696 2013-03-06  Roger Fong  <roger_fong@apple.com>
697
698         Re-enable WinEWS test and decrease iterations before clean build back to 10.
699
700         * EWSTools/start-queue-win.sh:
701         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
702         (WinEWS):
703
704 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
705
706         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
707         https://bugs.webkit.org/show_bug.cgi?id=82866
708
709         Reviewed by Martin Robinson.
710
711         * Scripts/run-gtk-tests:
712         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
713         it is passing now.
714
715 2013-03-06  Julie Parent  <jparent@chromium.org>
716
717         Dashboard cleanup: remove dashboard time logging.
718         https://bugs.webkit.org/show_bug.cgi?id=111608
719
720         Reviewed by Dirk Pranke.
721
722         Remove logTime.  It was never accurate, and the dev tools
723         have better ways to measure this if anyone cares to look
724         into dashboard perf.
725         
726         * TestResultServer/static-dashboards/dashboard_base.js:
727         * TestResultServer/static-dashboards/flakiness_dashboard.js:
728         (processTestRunsForBuilder):
729         (appendHTML):
730
731 2013-03-06  Tony Chang  <tony@chromium.org>
732
733         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
734         https://bugs.webkit.org/show_bug.cgi?id=111509
735
736         Reviewed by Dirk Pranke.
737
738         Add DumpRenderTree.pak to DumpRenderTree.app again.
739
740         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
741
742 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
743
744         [chromium] introduce WebUserGestureIndicator
745         https://bugs.webkit.org/show_bug.cgi?id=111531
746
747         Reviewed by Adam Barth.
748
749         * DumpRenderTree/chromium/WebViewHost.cpp:
750         (WebViewHost::createView):
751
752 2013-03-06  Alan Cutter  <alancutter@chromium.org>
753
754         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
755         https://bugs.webkit.org/show_bug.cgi?id=73482
756
757         Reviewed by Ryosuke Niwa.
758
759         Added input checking to the UpdateChromiumDEPS step.
760         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
761
762         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
763         (RollChromiumDEPS):
764         (RollChromiumDEPS._parse_args):
765         (RollChromiumDEPS.execute):
766         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
767         (IRCCommandTest.test_roll_chromium_deps):
768         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
769         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
770         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
771         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
772         (UpdateChromiumDEPS._fetch_last_known_good_revision):
773         (UpdateChromiumDEPS):
774         (UpdateChromiumDEPS._parse_revision_number):
775         (UpdateChromiumDEPS._validate_revisions):
776         (UpdateChromiumDEPS.run):
777         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
778         (UpdateChromiumDEPSTest):
779         (UpdateChromiumDEPSTest.test_parse_revision_number):
780         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
781         (RollChromiumDEPS):
782         (PostChromiumDEPSRoll):
783
784 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
785
786         [Qt][MiniBrowser] Touch mocking broken for chained getures
787         https://bugs.webkit.org/show_bug.cgi?id=111430
788
789         Reviewed by Jocelyn Turcotte.
790
791         Make it possible again to use touch mocking to test gesture chains
792         like pan->pinch->pan->pinch without lifting the primary "finger".
793         For this to work we need to track the pressed mouse buttons and
794         only synthesize touch release events when the ctrl key is released
795         if no mouse button is pressed. Else the pressed mouse button(s)
796         should result in a stationary touch point in a touch update event.
797         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
798         to check for the state of the ctrl key modifier instead of getting
799         it from the mouse events.
800
801         * MiniBrowser/qt/MiniBrowserApplication.cpp:
802         (MiniBrowserApplication::MiniBrowserApplication):
803         (MiniBrowserApplication::notify):
804
805 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
806
807         [chromium] don't use custom freetype on linux asan for now
808         https://bugs.webkit.org/show_bug.cgi?id=111516
809
810         Unreviewed, build fix.
811
812         Turns out the custom lib is getting picked up by other binaries
813         on our bot, which is bad.
814
815         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
816
817 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
818
819         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
820         https://bugs.webkit.org/show_bug.cgi?id=111509
821
822         Unreviewed, build fix.
823
824         Actually comment out the flag :(.
825
826         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
827
828 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
829
830         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
831         https://bugs.webkit.org/show_bug.cgi?id=111509
832
833         Unreviewed, build fix.
834
835         r144863 appears to have broken the xcode build; I'm temporarily
836         trying this instead, and if this doesn't work, I'll revert the
837         other changes.
838
839         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
840
841 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
842
843         [chromium] build a DumpRenderTree.pak even on windows
844         https://bugs.webkit.org/show_bug.cgi?id=111504
845
846         Reviewed by Tony Chang.
847
848         The Chromium Aura build uses the default theme to draw
849         controls, and that theme requires the ui ResourceBundle
850         to be initialized. On every other platform, we build
851         a DumpRenderTree.pak that works for this, but on Windows we
852         still compile the resources directly into DRT. As a first step,
853         let's build the pak file. I will then need to land a patch
854         in Chromium to actually load it. Then I can go back and move
855         the resources over to just use the .pak file and no longer need
856         the .rc's.
857
858         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
859
860 2013-03-05  Julie Parent  <jparent@chromium.org>
861         Dashboard cleanup: move string utilities into their own namespace.
862         
863         https://bugs.webkit.org/show_bug.cgi?id=111485
864
865         Reviewed by Ojan Vafai.
866         
867         One of many pieces to clean up dashboard_base.
868         
869         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
870
871         * TestResultServer/static-dashboards/aggregate_results.html:
872         * TestResultServer/static-dashboards/dashboard_base.js:
873         (isTreeMap):
874         (isFlakinessDashboard):
875         * TestResultServer/static-dashboards/flakiness_dashboard.html:
876         * TestResultServer/static-dashboards/flakiness_dashboard.js:
877         (determineWKPlatform):
878         (chromiumPlatform):
879         (platformAndBuildType):
880         (substringList):
881         (individualTestsForSubstringList):
882         (filterBugs):
883         (populateExpectationsData):
884         (processMissingTestsWithExpectations):
885         (processMissingAndExtraExpectations):
886         (htmlForSingleTestRow):
887         (.dummyNode.onload):
888         (expectationsTitle):
889         * TestResultServer/static-dashboards/run-embedded-unittests.html:
890         * TestResultServer/static-dashboards/run-unittests.html:
891         * TestResultServer/static-dashboards/string.js: Added.
892         * TestResultServer/static-dashboards/timeline_explorer.html:
893         * TestResultServer/static-dashboards/treemap.html:
894
895 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
896
897         [EFL] Build break with latest EFL libraries
898         https://bugs.webkit.org/show_bug.cgi?id=111028
899
900         Reviewed by Dirk Pranke.
901
902         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
903         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
904         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
905
906 2013-03-05  Roger Fong  <roger_fong@apple.com>
907
908         Increase number of WinEWS iterations to 20.
909         Don't reboot after each iteration set.
910         Make EWS bots just build temporarily so that the queue catches up again.
911
912         * EWSTools/start-queue-win.sh:
913         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
914         (WinEWS):
915
916 2013-03-04  James Robinson  <jamesr@chromium.org>
917
918         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
919         https://bugs.webkit.org/show_bug.cgi?id=111386
920
921         Reviewed by Adrienne Walker.
922
923         * DumpRenderTree/chromium/TestShell.cpp:
924         (TestShell::initialize):
925
926 2013-03-05  Min Qin  <qinmin@chromium.org>
927
928         Copy dictionary to the external storage before running layout test on android
929         https://bugs.webkit.org/show_bug.cgi?id=111480
930
931         Reviewed by Adam Barth.
932
933         TestWebKitPlatformSupport now needs to read an external dictionary file.
934         This file does not exist on the device. We need to copy it before running layout tests.
935
936         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
937         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
938         (ChromiumAndroidDriver._push_platform_resources):
939
940 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
941
942         [chromium] DRT crashes in an Aura/Win build
943         https://bugs.webkit.org/show_bug.cgi?id=111394
944
945         Reviewed by Tony Chang.
946
947         When building (and running) with use_aura=1, we assume that
948         we're using the default theme engine, but DRT creates the
949         DRTWin theme engine and overwrites the default, leading to crashes
950         in basically every test from the mismatch.
951
952         This fix gets us down to at least "lots of crashes" :).
953
954         * DumpRenderTree/chromium/TestShellWin.cpp:
955         (platformInit):
956
957 2013-03-05  Eric Seidel  <eric@webkit.org>
958
959         Add html-parser-threaded perf test now that the threaded parser is enabled by default
960         https://bugs.webkit.org/show_bug.cgi?id=111200
961
962         Reviewed by Ryosuke Niwa.
963
964         Had to teach run-perf-tests to ignore one more warning.
965
966         * Scripts/webkitpy/performance_tests/perftest.py:
967         (PerfTest):
968
969 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
970
971         Update list of builders for test results server
972         https://bugs.webkit.org/show_bug.cgi?id=111166
973
974         Reviewed by Ojan Vafai.
975
976         * TestResultServer/static-dashboards/builders.jsonp:
977
978 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
979
980         [GTK] Move basic dependency installation to a script
981         https://bugs.webkit.org/show_bug.cgi?id=110692
982
983         Reviewed by Gustavo Noronha Silva.
984
985         * gtk/install-dependencies: Added. A Script which installs all dependencies
986         necessary for building for Debian-based distributions and Fedora.
987
988 2013-03-05  James Robinson  <jamesr@chromium.org>
989
990         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
991         https://bugs.webkit.org/show_bug.cgi?id=111440
992
993         Reviewed by Adrienne Walker.
994
995         Remove unnecessary WebCompositorSupport::shutdown call
996
997         * DumpRenderTree/chromium/DumpRenderTree.cpp:
998         (main):
999
1000 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
1001
1002         Unreviewed build fix.
1003
1004         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
1005
1006 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
1007
1008         [Qt][MiniBrowser] Improve the update of touch indicators
1009         https://bugs.webkit.org/show_bug.cgi?id=111429
1010
1011         Reviewed by Jocelyn Turcotte.
1012
1013         MiniBrowserApplication::sendTouchEvent sends an empty list
1014         to BrowserWindow::updateVisualMockTouchPoints if the control
1015         button is released, in which case the touch indicators should
1016         be hidden so that we never end up with a leftover indicator
1017         sticking on the screen.
1018         This patch also simplifies the lookup of the indicator items by
1019         replacing the findChild search in the item tree with a QHash
1020         that stores the touch ID's and the pointers to the corresponding
1021         indicator items.
1022
1023         * MiniBrowser/qt/BrowserWindow.cpp:
1024         (BrowserWindow::updateVisualMockTouchPoints):
1025         * MiniBrowser/qt/BrowserWindow.h:
1026         (BrowserWindow):
1027
1028 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1029
1030         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
1031         https://bugs.webkit.org/show_bug.cgi?id=81042
1032
1033         Reviewed by Enrica Casucci.
1034
1035         Add setAsynchronousSpellCheckingEnabled implementation for
1036         WebKitTestRunner to have the possibility to test asynchronous
1037         spell checking implementation from bug 109577.
1038
1039         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1040         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1041         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
1042         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1043         * WebKitTestRunner/TestController.cpp:
1044         (WTR::TestController::resetStateToConsistentValues):
1045
1046 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
1047
1048         MediaStream API: Add the getStreamById method on RTCPeerConnection
1049         https://bugs.webkit.org/show_bug.cgi?id=111311
1050
1051         Reviewed by Adam Barth.
1052
1053         Changing mocks to be more realistic.
1054
1055         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
1056         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
1057         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
1058         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
1059         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
1060
1061 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
1062
1063         Add content shell bots to garden-o-matic for general failurse
1064         https://bugs.webkit.org/show_bug.cgi?id=111168
1065
1066         Reviewed by Adam Barth.
1067
1068         All but the WebKit (Content Shell) Android bot is stable enough. While
1069         they're not green yet, there must not be any non-layout test failures on
1070         them.
1071
1072         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1073         (.):
1074
1075 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1076
1077         [chromium] remove deprecated WebTestRunner::setFocus API
1078         https://bugs.webkit.org/show_bug.cgi?id=111354
1079
1080         Reviewed by James Robinson.
1081
1082         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1083         (WebTestDelegate):
1084
1085 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1086
1087         Run the bindings generation tests on EWS and CQ bots
1088         https://bugs.webkit.org/show_bug.cgi?id=111358
1089
1090         Reviewed by Adam Barth.
1091
1092         The tests are super fast and not flaky.
1093
1094         * Scripts/webkitpy/common/config/ports.py:
1095         (DeprecatedPort.run_bindings_tests_command):
1096         * Scripts/webkitpy/common/config/ports_mock.py:
1097         (MockPort.run_webkit_tests_command):
1098         (MockPort):
1099         (MockPort.run_bindings_tests_command):
1100         * Scripts/webkitpy/tool/commands/download_unittest.py:
1101         * Scripts/webkitpy/tool/steps/runtests.py:
1102         (RunTests.run):
1103         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1104         (RunTestsTest.test_webkit_run_unit_tests):
1105         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1106
1107 2013-03-04  Eric Seidel  <eric@webkit.org>
1108
1109         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
1110         https://bugs.webkit.org/show_bug.cgi?id=111384
1111
1112         Reviewed by Ryosuke Niwa.
1113
1114         Sometimes I want to know why various LayoutTests are slow
1115         without having to convert them into PerformanceTests in order
1116         to use our fancy profiling.  The Driver already knows how to
1117         do the right thing, we just need to expose the options to the user.
1118
1119         Handling of these options is already unittested in the perftests_unittest.
1120
1121         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1122         (parse_args):
1123
1124 2013-03-04  Alan Cutter  <alancutter@chromium.org>
1125
1126         check-webkit-style says "Have to enable auto props in the subversion config file"
1127         https://bugs.webkit.org/show_bug.cgi?id=107724
1128
1129         Reviewed by Tony Chang.
1130
1131         Added a standard svn config file for WebKit developers to use.
1132         Updated the style and commit queue bot build scripts to load this file.
1133
1134         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1135         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1136         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1137         * svn-config: Added.
1138
1139 2013-03-04  James Robinson  <jamesr@chromium.org>
1140
1141         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
1142         https://bugs.webkit.org/show_bug.cgi?id=111285
1143
1144         Reviewed by Adrienne Walker.
1145
1146         This removes the need for WebCompositorSupport::initialize and exposes
1147         slightly fewer entry points across the repository boundary.
1148
1149         * DumpRenderTree/chromium/TestShell.cpp:
1150         (TestShell::initialize):
1151         * DumpRenderTree/chromium/TestShell.h:
1152         (TestShell::webCompositorThread):
1153         (TestShell):
1154         * DumpRenderTree/chromium/WebViewHost.cpp:
1155         (WebViewHost::initializeLayerTreeView):
1156
1157 2013-03-04  Roger Fong  <roger_fong@apple.com>
1158
1159         Unreviewed. Get rid of some AppleWin VS2010 build warnings.
1160
1161         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
1162
1163 2013-03-04  David Kilzer  <ddkilzer@apple.com>
1164
1165         BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
1166
1167             Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
1168                 NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
1169                                         ^         ~~~~~~~~~~~~~~~~~~~~~
1170             1 error generated.
1171
1172         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
1173         AccessibilityCommonMac.h.
1174
1175 2013-03-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1176
1177         [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
1178         https://bugs.webkit.org/show_bug.cgi?id=109828
1179
1180         Reviewed by Kenneth Rohde Christiansen.
1181
1182         Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
1183         callbacks.
1184
1185         * TestWebKitAPI/CMakeLists.txt:
1186
1187             Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
1188             considered.
1189
1190         * TestWebKitAPI/PlatformEfl.cmake:
1191         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
1192         (TestWebKitAPI):
1193         (TestWebKitAPI::didFinishLoadForFrame):
1194         (TestWebKitAPI::setPageLoaderClient):
1195         (TestWebKitAPI::webProcessCrashed):
1196         (TestWebKitAPI::webProcessDidRelaunch):
1197         (TestWebKitAPI::setViewClient):
1198         (TestWebKitAPI::TEST):
1199
1200 2013-03-04  Chris Fleizach  <cfleizach@apple.com>
1201
1202         AX: Upstream iOS Accessibility DumpRenderTree changes
1203         https://bugs.webkit.org/show_bug.cgi?id=111220
1204
1205         Reviewed by David Kilzer.
1206
1207         Upstream the iOS changes for accessibility in DumpRenderTree.
1208
1209         * DumpRenderTree/AccessibilityUIElement.cpp:
1210         (headerElementAtIndexCallback):
1211         (linkedElementCallback):
1212         (elementsForRangeCallback):
1213         (increaseTextSelectionCallback):
1214         (decreaseTextSelectionCallback):
1215         (assistiveTechnologySimulatedFocusCallback):
1216         (stringForSelectionCallback):
1217         (getIPhoneLabelCallback):
1218         (getIPhoneHintCallback):
1219         (getIPhoneValueCallback):
1220         (getIPhoneIdentifierCallback):
1221         (getIPhoneTraitsCallback):
1222         (getIPhoneIsElementCallback):
1223         (getIPhoneElementTextPositionCallback):
1224         (getIPhoneElementTextLengthCallback):
1225         (AccessibilityUIElement::getJSClass):
1226         * DumpRenderTree/AccessibilityUIElement.h:
1227         (AccessibilityUIElement):
1228         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1229         * DumpRenderTree/ios: Added.
1230         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
1231         (AccessibilityController::AccessibilityController):
1232         (AccessibilityController::~AccessibilityController):
1233         (AccessibilityController::elementAtPoint):
1234         (AccessibilityController::focusedElement):
1235         (AccessibilityController::rootElement):
1236         (findAccessibleObjectById):
1237         (AccessibilityController::accessibleElementById):
1238         (AccessibilityController::setLogFocusEvents):
1239         (AccessibilityController::setLogScrollingStartEvents):
1240         (AccessibilityController::setLogValueChangeEvents):
1241         (AccessibilityController::setLogAccessibilityEvents):
1242         (AccessibilityController::addNotificationListener):
1243         (AccessibilityController::removeNotificationListener):
1244         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
1245         (AccessibilityUIElement::AccessibilityUIElement):
1246         (AccessibilityUIElement::~AccessibilityUIElement):
1247         (concatenateAttributeAndValue):
1248         (AccessibilityUIElement::iphoneLabel):
1249         (AccessibilityUIElement::iphoneHint):
1250         (AccessibilityUIElement::iphoneValue):
1251         (AccessibilityUIElement::iphoneIdentifier):
1252         (AccessibilityUIElement::iphoneTraits):
1253         (AccessibilityUIElement::iphoneIsElement):
1254         (AccessibilityUIElement::iphoneElementTextPosition):
1255         (AccessibilityUIElement::iphoneElementTextLength):
1256         (AccessibilityUIElement::url):
1257         (AccessibilityUIElement::x):
1258         (AccessibilityUIElement::y):
1259         (AccessibilityUIElement::width):
1260         (AccessibilityUIElement::height):
1261         (AccessibilityUIElement::clickPointX):
1262         (AccessibilityUIElement::clickPointY):
1263         (AccessibilityUIElement::getChildren):
1264         (AccessibilityUIElement::getChildrenWithRange):
1265         (AccessibilityUIElement::childrenCount):
1266         (AccessibilityUIElement::elementAtPoint):
1267         (AccessibilityUIElement::indexOfChild):
1268         (AccessibilityUIElement::getChildAtIndex):
1269         (AccessibilityUIElement::headerElementAtIndex):
1270         (AccessibilityUIElement::linkedElement):
1271         (AccessibilityUIElement::linkedUIElementAtIndex):
1272         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1273         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1274         (AccessibilityUIElement::disclosedRowAtIndex):
1275         (AccessibilityUIElement::selectedRowAtIndex):
1276         (AccessibilityUIElement::rowAtIndex):
1277         (AccessibilityUIElement::titleUIElement):
1278         (AccessibilityUIElement::parentElement):
1279         (AccessibilityUIElement::disclosedByRow):
1280         (AccessibilityUIElement::increaseTextSelection):
1281         (AccessibilityUIElement::decreaseTextSelection):
1282         (AccessibilityUIElement::stringForSelection):
1283         (AccessibilityUIElement::stringForRange):
1284         (AccessibilityUIElement::attributedStringForRange):
1285         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1286         (AccessibilityUIElement::elementsForRange):
1287         (AccessibilityUIElement::getLinkedUIElements):
1288         (AccessibilityUIElement::getDocumentLinks):
1289         (AccessibilityUIElement::attributesOfLinkedUIElements):
1290         (AccessibilityUIElement::attributesOfDocumentLinks):
1291         (AccessibilityUIElement::attributesOfChildren):
1292         (AccessibilityUIElement::allAttributes):
1293         (AccessibilityUIElement::stringAttributeValue):
1294         (AccessibilityUIElement::isPressActionSupported):
1295         (AccessibilityUIElement::isIncrementActionSupported):
1296         (AccessibilityUIElement::isDecrementActionSupported):
1297         (AccessibilityUIElement::boolAttributeValue):
1298         (AccessibilityUIElement::isAttributeSettable):
1299         (AccessibilityUIElement::isAttributeSupported):
1300         (AccessibilityUIElement::parameterizedAttributeNames):
1301         (AccessibilityUIElement::role):
1302         (AccessibilityUIElement::subrole):
1303         (AccessibilityUIElement::roleDescription):
1304         (AccessibilityUIElement::title):
1305         (AccessibilityUIElement::description):
1306         (AccessibilityUIElement::orientation):
1307         (AccessibilityUIElement::stringValue):
1308         (AccessibilityUIElement::language):
1309         (AccessibilityUIElement::helpText):
1310         (AccessibilityUIElement::intValue):
1311         (AccessibilityUIElement::minValue):
1312         (AccessibilityUIElement::maxValue):
1313         (AccessibilityUIElement::valueDescription):
1314         (AccessibilityUIElement::insertionPointLineNumber):
1315         (AccessibilityUIElement::isEnabled):
1316         (AccessibilityUIElement::isRequired):
1317         (AccessibilityUIElement::isFocused):
1318         (AccessibilityUIElement::isSelected):
1319         (AccessibilityUIElement::isExpanded):
1320         (AccessibilityUIElement::isChecked):
1321         (AccessibilityUIElement::hierarchicalLevel):
1322         (AccessibilityUIElement::ariaIsGrabbed):
1323         (AccessibilityUIElement::ariaDropEffects):
1324         (AccessibilityUIElement::lineForIndex):
1325         (AccessibilityUIElement::boundsForRange):
1326         (AccessibilityUIElement::attributesOfColumnHeaders):
1327         (AccessibilityUIElement::attributesOfRowHeaders):
1328         (AccessibilityUIElement::attributesOfColumns):
1329         (AccessibilityUIElement::attributesOfRows):
1330         (AccessibilityUIElement::attributesOfVisibleCells):
1331         (AccessibilityUIElement::attributesOfHeader):
1332         (AccessibilityUIElement::rowCount):
1333         (AccessibilityUIElement::columnCount):
1334         (AccessibilityUIElement::indexInTable):
1335         (AccessibilityUIElement::rowIndexRange):
1336         (AccessibilityUIElement::columnIndexRange):
1337         (AccessibilityUIElement::cellForColumnAndRow):
1338         (AccessibilityUIElement::selectedTextRange):
1339         (AccessibilityUIElement::assistiveTechnologySimulatedFocus):
1340         (AccessibilityUIElement::setSelectedTextRange):
1341         (AccessibilityUIElement::increment):
1342         (AccessibilityUIElement::decrement):
1343         (AccessibilityUIElement::showMenu):
1344         (AccessibilityUIElement::press):
1345         (AccessibilityUIElement::accessibilityValue):
1346         (AccessibilityUIElement::documentEncoding):
1347         (AccessibilityUIElement::documentURI):
1348         (_accessibilityNotificationCallback):
1349         (AccessibilityUIElement::addNotificationListener):
1350         (AccessibilityUIElement::removeNotificationListener):
1351         (AccessibilityUIElement::isFocusable):
1352         (AccessibilityUIElement::isSelectable):
1353         (AccessibilityUIElement::isMultiSelectable):
1354         (AccessibilityUIElement::isSelectedOptionActive):
1355         (AccessibilityUIElement::isVisible):
1356         (AccessibilityUIElement::isOffScreen):
1357         (AccessibilityUIElement::isCollapsed):
1358         (AccessibilityUIElement::isIgnored):
1359         (AccessibilityUIElement::hasPopup):
1360         (AccessibilityUIElement::takeFocus):
1361         (AccessibilityUIElement::takeSelection):
1362         (AccessibilityUIElement::addSelection):
1363         (AccessibilityUIElement::removeSelection):
1364         (AccessibilityUIElement::uiElementForSearchPredicate):
1365         (AccessibilityUIElement::numberAttributeValue):
1366
1367 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1368
1369         [chromium] pass all focus handling methods through the WebTestDelegate
1370         https://bugs.webkit.org/show_bug.cgi?id=111328
1371
1372         Reviewed by Nico Weber.
1373
1374         In content_shell, the focus handling is asynchronous. To allow for
1375         switching the focus synchronously between WebViews, we need to intercept
1376         didFocus and didBlur and forward it to the WebTestDelegate.
1377
1378         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1379         (WebTestDelegate):
1380         (WebTestRunner::WebTestDelegate::setFocus):
1381         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1382         (WebTestRunner::WebTestProxy::didFocus):
1383         (WebTestRunner::WebTestProxy::didBlur):
1384         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1385         (WebTestRunner::TestRunner::setWindowIsKey):
1386         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1387         (WebTestRunner::WebTestProxyBase::didFocus):
1388         (WebTestRunner):
1389         (WebTestRunner::WebTestProxyBase::didBlur):
1390         * DumpRenderTree/chromium/WebViewHost.cpp:
1391         (WebViewHost::didFocus):
1392         (WebViewHost::didBlur):
1393         (WebViewHost::setFocus):
1394         * DumpRenderTree/chromium/WebViewHost.h:
1395         (WebViewHost):
1396
1397 2013-03-04  Claudio Saavedra  <csaavedra@igalia.com>
1398
1399         [GTK] No need to manually add system paths to jhbuildrc
1400         https://bugs.webkit.org/show_bug.cgi?id=110850
1401
1402         Reviewed by Gustavo Noronha Silva.
1403
1404         * gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
1405         already takes care of.
1406
1407 2013-03-04  Kinuko Yasuda  <kinuko@chromium.org>
1408
1409         [chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
1410         https://bugs.webkit.org/show_bug.cgi?id=111284
1411
1412         Disabling the failing two tests on Android.
1413
1414         Reviewed by Jochen Eisinger.
1415
1416         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1417         (TestWebKitAPI):
1418         (TestWebKitAPI::TEST):
1419
1420 2013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
1421
1422         Add build flag for FontLoader
1423         https://bugs.webkit.org/show_bug.cgi?id=111289
1424
1425         Reviewed by Benjamin Poulain.
1426
1427         Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
1428
1429         * Scripts/webkitperl/FeatureList.pm:
1430         * qmake/mkspecs/features/features.pri:
1431
1432 2013-03-03  Benjamin Poulain  <benjamin@webkit.org>
1433
1434         [Mac] Get rid of a useless method from DOMHTMLInputElement
1435         https://bugs.webkit.org/show_bug.cgi?id=111279
1436
1437         Reviewed by Sam Weinig.
1438
1439         * DumpRenderTree/mac/TestRunnerMac.mm:
1440         (TestRunner::setValueForUser):
1441         The method _setValueForUser: was added for testing. This feature is already
1442         exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
1443         in real use cases. Get rid of the method created for testing, use the real thing
1444         instead.
1445
1446 2013-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1447
1448         Some perf. tests have variances that differ greatly between runs
1449         https://bugs.webkit.org/show_bug.cgi?id=97510
1450
1451         Reviewed by Benjamin Poulain.
1452
1453         Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
1454         environment on test results (we run each instance after one another, not in parallel).
1455
1456         We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
1457         iterations as it was done previously in single process. These values are hard-coded in perftest.py
1458         and runner.js but they are to be configurable in the future.
1459
1460         Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
1461         metric now reports an array of the length 4 with each element containing an array of 5 iteration
1462         values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.
1463
1464         Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
1465         and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
1466         as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.
1467
1468         * Scripts/webkitpy/performance_tests/perftest.py:
1469         (PerfTestMetric.append_group): Renamed from append.
1470         (PerfTestMetric.grouped_iteration_values): Added.
1471         (PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.
1472
1473         (PerfTest.__init__): Takes the number of processes (drivers) to run tests with.
1474         This parameter is only used by SingleProcessPerfTest.
1475
1476         (PerfTest.run): Repeat tests using different driver processes.
1477         (PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
1478         since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
1479         We instead use _ensure_metrics to obtain the matched metrics and store the data there.
1480         (PerfTest._ensure_metrics): Added.
1481
1482         (SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
1483         instances of DumpRenderTree/WebKitTestRunner takes too long.
1484         (SingleProcessPerfTest.__init__):
1485
1486         (ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.
1487
1488         (PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.
1489
1490         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect
1491         _run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
1492         the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.
1493
1494         (TestPerfTestMetric.test_append): Updated per name and added some test cases for
1495         grouped_iteration_values.
1496
1497         (TestPerfTest._assert_results_are_correct):
1498
1499         (TestSingleProcessPerfTest): Added.
1500         (TestSingleProcessPerfTest.test_use_only_one_process):
1501         (TestSingleProcessPerfTest.test_use_only_one_process.run_single):
1502
1503         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1504         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1505
1506         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of
1507         sample standard deviations since we're now running tests 4 times.
1508         (MainTest._test_run_with_json_output.mock_upload_json):
1509         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
1510
1511 2013-03-03  Alexandre Elias  <aelias@chromium.org>
1512
1513         [chromium] Remove WebLayerTreeView::setViewportSize call
1514         https://bugs.webkit.org/show_bug.cgi?id=110727
1515
1516         Reviewed by James Robinson.
1517
1518         After https://codereview.chromium.org/12328080 lands,
1519         setViewportSize is called from the Chromium side. The multiplication
1520         by deviceScaleFactor here was prone to off-by-one errors.
1521         The layoutSize() function was only used here so delete it as well.
1522
1523         DumpRenderTree WebViewHost must now call this method as well.
1524
1525         * DumpRenderTree/chromium/WebViewHost.cpp:
1526         (WebViewHost::initializeLayerTreeView):
1527         (WebViewHost::setWindowRect):
1528         (WebViewHost::setDeviceScaleFactor):
1529         (WebViewHost::updateViewportSize):
1530         * DumpRenderTree/chromium/WebViewHost.h:
1531         (WebViewHost):
1532
1533 2013-02-27  Darin Adler  <darin@apple.com>
1534
1535         StringHasher functions require alignment that call sites do not all guarantee
1536         https://bugs.webkit.org/show_bug.cgi?id=110171
1537
1538         Reviewed by Benjamin Poulain.
1539
1540         * TestWebKitAPI/CMakeLists.txt:
1541         * TestWebKitAPI/GNUmakefile.am:
1542         * TestWebKitAPI/TestWebKitAPI.gypi:
1543         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1544         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1545         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1546         * TestWebKitAPI/Tests/WTF/WTF.pro:
1547         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1548         Added the StringHasher.cpp file.
1549
1550         * TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests
1551         for the functions in the StringHasher class.
1552
1553 2013-03-02  Benjamin Poulain  <bpoulain@apple.com>
1554
1555         Move computedStyleIncludingVisitedInfo from TestRunner to Internals
1556         https://bugs.webkit.org/show_bug.cgi?id=109772
1557
1558         Reviewed by Andreas Kling.
1559
1560         * DumpRenderTree/TestRunner.cpp:
1561         (TestRunner::staticFunctions):
1562         * DumpRenderTree/TestRunner.h:
1563         (TestRunner):
1564         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1565         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1566         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1567         * DumpRenderTree/mac/TestRunnerMac.mm:
1568         * DumpRenderTree/qt/TestRunnerQt.cpp:
1569         * DumpRenderTree/qt/TestRunnerQt.h:
1570         (TestRunner):
1571         * DumpRenderTree/win/TestRunnerWin.cpp:
1572         * DumpRenderTree/wx/TestRunnerWx.cpp:
1573         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1574         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1575         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1576         (TestRunner):
1577
1578 2013-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
1579
1580         Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
1581         https://bugs.webkit.org/show_bug.cgi?id=110943
1582
1583         Reviewed by Yury Semikhatsky.
1584
1585         Unfortunately in many cases raw pointer may point to an object that has been deleted.
1586         There is no working solution to solve this problem in general.
1587         It could be solved only on case by case basis.
1588
1589         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
1590         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
1591         (TestWebKitAPI::TEST):
1592
1593 2013-03-01  Jason Anderssen  <janderssen@gmail.com>
1594
1595         Move markerTextForListItem from TestRunner to Internals
1596         https://bugs.webkit.org/show_bug.cgi?id=110939
1597
1598         Reviewed by Benjamin Poulain.
1599
1600         * DumpRenderTree/TestRunner.cpp:
1601         (TestRunner::staticFunctions):
1602         * DumpRenderTree/TestRunner.h:
1603         (TestRunner):
1604         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1605         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1606         (WebTestRunner::TestRunner::TestRunner):
1607         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1608         (TestRunner):
1609         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1610         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1611         * DumpRenderTree/mac/TestRunnerMac.mm:
1612         * DumpRenderTree/qt/TestRunnerQt.cpp:
1613         * DumpRenderTree/qt/TestRunnerQt.h:
1614         (TestRunnerQt):
1615         * DumpRenderTree/win/TestRunnerWin.cpp:
1616         * DumpRenderTree/wx/TestRunnerWx.cpp:
1617         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1618         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1619         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1620         (TestRunner):
1621
1622 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1623
1624         Don't use legacy test names when returning results from PerfTest.run
1625         https://bugs.webkit.org/show_bug.cgi?id=111148
1626
1627         Reviewed by Dirk Pranke.
1628
1629         * Scripts/webkitpy/performance_tests/perftest.py:
1630         (PerfTestMetric.name): Renamed from metric.
1631         (PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
1632         (PerfTest.run): Use metric name instead of the legacy name to store iteration values.
1633         (ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.
1634
1635         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1636         (TestPerfTestMetric.test_init_set_time_metric):
1637         (TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
1638         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1639         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1640
1641         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1642         (PerfTestsRunner.__init__):
1643         (PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
1644         to obtain the trac URL instead of hard coding it.
1645         (PerfTestsRunner._run_tests_set):
1646
1647 2013-03-01  Roger Fong  <roger_fong@apple.com>
1648
1649         Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
1650         https://bugs.webkit.org/show_bug.cgi?id=111202
1651
1652         This is useful for running VCExpress builds from command line because there is
1653         no unified solution output, only per project build logs.
1654         The project will be run as the last project in the solution.
1655
1656         * win/AssembleBuildLogs: Added.
1657         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
1658         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
1659         * win/AssembleBuildLogs/AssembleLogs.cmd: Added.
1660         * win/AssembleBuildLogs/README: Added.
1661
1662 2013-03-01  Roger Fong  <roger_fong@apple.com>
1663
1664         Unreviewed. Increase number of patches processed before clean building on WinEWS bots.
1665
1666         * EWSTools/start-queue-win.sh:
1667
1668 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1669
1670         Don't return statistics in PerfTest.run
1671         https://bugs.webkit.org/show_bug.cgi?id=111145
1672
1673         Reviewed by Dirk Pranke.
1674
1675         Simply return a list of values obtained in each iteration from PerfTest.run.
1676         Also simplify various methods as needed.
1677
1678         * Scripts/webkitpy/performance_tests/perftest.py:
1679         (PerfTestMetric.__init__): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
1680         as needed from PerfTestsRunner._generate_results_dict.
1681
1682         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
1683         that we don't have to worry about the backward compatibility here.
1684
1685         (PerfTestMetric.iteration_values): Added.
1686         (PerfTestMetric.unit): Added.
1687         (PerfTestMetric.metric_to_unit):
1688         (PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.
1689
1690         (PerfTest.run):
1691         (PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.
1692
1693         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1694         (TestPerfTestMetric.test_init_set_missing_unit):
1695         (TestPerfTestMetric.test_init_set_time_metric): Added.
1696         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
1697         (TestPerfTestMetric.test_append):
1698         (TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
1699         test cases and it's not critical to keep math right as they're not used in output JSON anymore.
1700         (TestPerfTest._assert_results_are_correct):
1701         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1702         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1703
1704         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1705         (PerfTestsRunner._generate_results_dict):
1706
1707         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1708         (EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
1709         (SomeParserTestData): Ditto.
1710         (MemoryTestData): Ditto.
1711
1712 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1713
1714         [Qt] Enable LINK_PREFETCH
1715         https://bugs.webkit.org/show_bug.cgi?id=111158
1716
1717         Reviewed by Simon Hausmann.
1718
1719         * qmake/mkspecs/features/features.pri:
1720
1721 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1722
1723         [Qt] Update features.pri with new features
1724         https://bugs.webkit.org/show_bug.cgi?id=111157
1725
1726         Reviewed by Jocelyn Turcotte.
1727
1728         * qmake/mkspecs/features/features.pri:
1729
1730 2013-03-01  Jochen Eisinger  <jochen@chromium.org>
1731
1732         [chromium] put WebTestProxy::scheduleComposite back in place
1733         https://bugs.webkit.org/show_bug.cgi?id=111146
1734
1735         Reviewed by Nico Weber.
1736
1737         The call was removed in http://trac.webkit.org/changeset/144398 because
1738         DRT doesn't need it. However, content shell depends on this call.
1739
1740         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1741         (WebTestRunner::WebTestProxy::scheduleComposite):
1742
1743 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1744
1745         Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
1746         https://bugs.webkit.org/show_bug.cgi?id=111142
1747
1748         Reviewed by Adam Barth.
1749
1750         Merged _run_single_test into _run_tests_set. The code looks much cleaner now.
1751
1752         Also removed _print_status since it's never used anywhere.
1753
1754         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1755         (PerfTestsRunner.run):
1756         (PerfTestsRunner._run_tests_set):
1757         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1758         (MainTest.run_test):
1759         (MainTest.test_run_test_set):
1760         (MainTest.test_run_test_set_kills_drt_per_run):
1761         (MainTest.test_run_test_set_for_parser_tests):
1762
1763 2013-02-28  Kiran Muppala  <cmuppala@apple.com>
1764
1765         Disable window occlusion detection for WebKitTestRunner Web View on Mac
1766         https://bugs.webkit.org/show_bug.cgi?id=111116
1767
1768         Reviewed by Simon Fraser.
1769
1770         Window occlusion notifications were causing WebKitTestRunner's Web View
1771         to be detected as occluded and causing a few JavaScript timer layout
1772         tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
1773         by initializing the page visibility to "visible" after creating the view.
1774         But a better solution is to disable window occlusion detection, so that
1775         not only the page but also the view is treated as visible.
1776
1777         * WebKitTestRunner/TestController.cpp:
1778         (WTR::TestController::createWebViewWithOptions): Remove call to
1779         setVisibilityState, since it is no longer necessary.
1780         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1781         (WTR::PlatformWebView::PlatformWebView): Disable window occlusion
1782         detection for the created WKView.
1783
1784 2013-02-28  Li Yin  <li.yin@intel.com>
1785
1786         [chromium] Events can't be triggered on MediaStreamTrack
1787         https://bugs.webkit.org/show_bug.cgi?id=110930
1788
1789         Reviewed by Kentaro Hara.
1790
1791         Related code was moved to MediaStreamCenterChromium::didStopLocalMediaStream
1792
1793         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
1794         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
1795
1796 2013-02-27  James Robinson  <jamesr@chromium.org>
1797
1798         [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
1799         https://bugs.webkit.org/show_bug.cgi?id=111017
1800
1801         Reviewed by Adam Barth.
1802
1803         This decouples DumpRenderTree from WebLayerTreeViewClient.
1804
1805         * DumpRenderTree/chromium/WebViewHost.cpp:
1806         (WebViewHostDRTLayerTreeViewClient):
1807         (WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
1808         (WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
1809         (WebViewHostDRTLayerTreeViewClient::Layout):
1810         (WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
1811         (WebViewHost::initializeLayerTreeView):
1812         * DumpRenderTree/chromium/WebViewHost.h:
1813         (webkit_support):
1814         (WebViewHost):
1815
1816 2013-02-28  Ryuan Choi  <ryuan.choi@samsung.com>
1817
1818         Unreviewed, add my secondary email address to the list.
1819
1820         * Scripts/webkitpy/common/config/committers.py:
1821
1822 2013-02-28  Philip Rogers  <pdr@google.com>
1823
1824         Add Philip Rogers as a reviewer.
1825
1826         Unreviewed update of committers.py.
1827
1828         * Scripts/webkitpy/common/config/committers.py:
1829
1830 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1831
1832         Merge more methods on PerfTest
1833         https://bugs.webkit.org/show_bug.cgi?id=111030
1834
1835         Reviewed by Dirk Pranke.
1836
1837         Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
1838         and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.
1839
1840         This makes the control flow a lot more comprehensible.
1841
1842         * Scripts/webkitpy/performance_tests/perftest.py:
1843         (PerfTest._run_with_driver):
1844         (PerfTest._should_ignore_line):
1845         (PerfTest._filter_output):
1846
1847         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1848         (TestPerfTest._assert_results_are_correct):
1849         (test_ignored_stderr_lines):
1850
1851 2013-02-28  Robert Hogan  <robert@webkit.org>
1852
1853         Update my IRC nick
1854
1855         Unreviewed.
1856
1857         * Scripts/webkitpy/common/config/committers.py:
1858
1859 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
1860
1861         [Qt] Enable thin archives before parsing the project files
1862
1863         Rubber-stamped by Simon Hausmann.
1864
1865         The targetSubDir() function can be called before default_post.prf has been
1866         parsed therefore the gnu_thin_archives option has to be set in default_pre.prf
1867         which is parsed before the main project file.
1868         This issue was revealed by r144299 and fixes the clean build.
1869
1870         * qmake/mkspecs/features/default_post.prf:
1871         * qmake/mkspecs/features/default_pre.prf:
1872
1873 2013-02-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1874
1875         [Qt] Enable CANVAS_PATH flag
1876         https://bugs.webkit.org/show_bug.cgi?id=108508
1877
1878         Reviewed by Simon Hausmann.
1879
1880         Also enable CANVAS_PATH flag for Qt.
1881
1882         * qmake/mkspecs/features/features.pri:
1883
1884 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
1885
1886         [Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSubDir()
1887
1888         Rubber-stamped by Csaba Osztrogonác.
1889
1890         Besides suppressing a warning about the non-existing function this
1891         fixes the build if there is a subdirectory (eg. debug-and-release).
1892
1893         * TestWebKitAPI/InjectedBundle.pri:
1894         * TestWebKitAPI/TestWebKitAPI.pri:
1895
1896 2013-02-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1897
1898         [EFL][WTR] WTR cannot load injected bundle
1899         https://bugs.webkit.org/show_bug.cgi?id=111063
1900
1901         Reviewed by Csaba Osztrogonác.
1902
1903         WTR was not able to load injected bundle because of undefined 
1904         symbols for AccessibilityUIElement::scrollToMakeVisible(). 
1905         Adding empty implementation of this function to AccessibilityUIElementAtk.cpp
1906         solves the problem.
1907
1908         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1909         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1910
1911 2013-02-28  Alberto Garcia  <albgarcia@rim.com>
1912
1913         [BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
1914         https://bugs.webkit.org/show_bug.cgi?id=110464
1915
1916         Reviewed by Rob Buis.
1917
1918         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1919
1920 2013-02-28  Xan Lopez  <xlopez@rim.com>
1921
1922         [BlackBerry] DumpRenderTreeSupport: update the set position methods
1923         https://bugs.webkit.org/show_bug.cgi?id=110578
1924
1925         Reviewed by Rob Buis.
1926
1927         TestRunner::setMockGeolocationPosition() changed in r130416:
1928         http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
1929
1930         DumpRenderTreeSupport::setMockGeolocationError() was renamed to
1931         setMockGeolocationPositionUnavailableError() in r129444:
1932         http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h
1933
1934         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1935         (TestRunner::setMockGeolocationPosition):
1936         (TestRunner::setMockGeolocationPositionUnavailableError):
1937
1938 2013-02-28  Xan Lopez  <xlopez@rim.com>
1939
1940         [BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
1941         https://bugs.webkit.org/show_bug.cgi?id=110465
1942
1943         Reviewed by Rob Buis.
1944
1945         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1946         (LoadItem::invoke):
1947
1948 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1949
1950         PerfTestRunner doesn't need _needs_http and _has_http_lock
1951         https://bugs.webkit.org/show_bug.cgi?id=111037
1952
1953         Reviewed by Adam Barth.
1954
1955         Delete these variables in favor of using a local variable.
1956
1957         Member variables are like global variables. They introduce implicit dependencies
1958         between member functions.
1959
1960         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1961         (PerfTestsRunner.__init__):
1962         (PerfTestsRunner._start_http_servers):
1963         (PerfTestsRunner):
1964         (PerfTestsRunner._stop_http_servers):
1965         (PerfTestsRunner.run):
1966
1967 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1968
1969         Unreviewed, rolling out r144224.
1970         http://trac.webkit.org/changeset/144224
1971         https://bugs.webkit.org/show_bug.cgi?id=111045
1972
1973         Caused plugins/pass-different-npp-struct.html to time out
1974         (Requested by abarth on #webkit).
1975
1976         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1977         (PassDifferentNPPStruct::NPP_SetWindow):
1978         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1979         (NPP_SetWindow):
1980
1981 2013-02-27  Adam Barth  <abarth@webkit.org>
1982
1983         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
1984         https://bugs.webkit.org/show_bug.cgi?id=110907
1985
1986         Reviewed by Eric Seidel.
1987
1988         This patch changes --enable-threaded-html-parser into
1989         --disable-threaded-html-parser and thereby enables the threaded HTML
1990         parser by default for the Chromium port.
1991
1992         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1993         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1994         (WebTestRunner::WebPreferences::reset):
1995         * DumpRenderTree/chromium/TestShell.cpp:
1996         (TestShell::TestShell):
1997
1998 2013-02-27  Kiran Muppala  <cmuppala@apple.com>
1999
2000         Initialize page visibility after creating WebKitTestRunner WebView on Mac
2001         https://bugs.webkit.org/show_bug.cgi?id=111025
2002
2003         Reviewed by Simon Fraser.
2004
2005         Set page visibility to "visible" after creating WebView to override
2006         visibility state inferred from window occlusion notifications on Mac.
2007
2008         * WebKitTestRunner/TestController.cpp:
2009         (WTR::TestController::createWebViewWithOptions): Add call to
2010         setVisibilityState.
2011
2012 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2013
2014         Merge PageLoadingPerfTest into ReplayPerfTest
2015         https://bugs.webkit.org/show_bug.cgi?id=111027
2016
2017         Reviewed by Dirk Pranke.
2018
2019         Merged two classes.
2020
2021         We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
2022         part of ReplayPerfTest.
2023
2024         * Scripts/webkitpy/performance_tests/perftest.py:
2025         (ReplayPerfTest): Moved _FORCE_GC_FILE here.
2026         (ReplayPerfTest.__init__):
2027         (ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
2028         (ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.
2029         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2030         (TestReplayPerfTest):
2031         (TestReplayPerfTest.test_run_single.run_test):
2032         (TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
2033         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
2034         TestPageLoadingPerfTest.test_run.
2035         (TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
2036         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
2037         TestPageLoadingPerfTest.test_run_with_memory_output
2038         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
2039         (TestReplayPerfTest.test_prepare_calls_run_single):
2040
2041 2013-02-27  Eric Seidel  <eric@webkit.org>
2042
2043         Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
2044         https://bugs.webkit.org/show_bug.cgi?id=111021
2045
2046         Reviewed by Dirk Pranke.
2047
2048         The underlying code (which is shared with run-webkit-tests)
2049         already knew how to support this option, it just wasn't exposed
2050         via the run-perf-tests front-end.  This patch fixes that.
2051
2052         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2053         (PerfTestsRunner._parse_args):
2054
2055 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2056
2057         Stop uploading results to webkit-perf.appspot.com
2058         https://bugs.webkit.org/show_bug.cgi?id=110954
2059
2060         Reviewed by Benjamin Poulain.
2061
2062         Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.
2063
2064         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2065         (RunAndUploadPerfTests):
2066
2067 2013-02-27  James Simonsen  <simonjam@chromium.org>
2068
2069         [chromium] Lower priority of preloaded images
2070         https://bugs.webkit.org/show_bug.cgi?id=110527
2071
2072         Plumb the didChangePriority signal into DRT so it can be tested.
2073
2074         Reviewed by Nate Chapin.
2075
2076         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2077         (WebKit):
2078         (WebTestRunner::WebTestProxy::didChangeResourcePriority):
2079         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2080         (WebTestRunner::TestRunner::TestRunner):
2081         (WebTestRunner::TestRunner::reset):
2082         (WebTestRunner::TestRunner::shouldDumpResourcePriorities):
2083         (WebTestRunner):
2084         (WebTestRunner::TestRunner::dumpResourceRequestPriorities):
2085         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2086         (TestRunner):
2087         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2088         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
2089         (WebTestRunner::WebTestProxyBase::willSendRequest):
2090         (WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
2091         (WebTestRunner):
2092
2093 2013-02-27  Chris Fleizach  <cfleizach@apple.com>
2094
2095         AX: Mac platform should support ability to scroll an element into visible
2096         https://bugs.webkit.org/show_bug.cgi?id=109860
2097
2098         Reviewed by Beth Dakin.
2099
2100         * DumpRenderTree/AccessibilityUIElement.cpp:
2101         (scrollToMakeVisibleCallback):
2102         (AccessibilityUIElement::getJSClass):
2103         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2104         (AccessibilityUIElement::scrollToMakeVisible):
2105         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2106         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2107         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2108         (AccessibilityUIElement):
2109         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2110         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2111         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2112         (WTR):
2113
2114 2013-02-27  John Bauman  <jbauman@chromium.org>
2115
2116         Plugin in iframe may not display
2117         https://bugs.webkit.org/show_bug.cgi?id=109879
2118
2119         Reviewed by Simon Fraser.
2120
2121         LogNPPSetWindow will be used with other ports as well.
2122
2123         * DumpRenderTree/DumpRenderTree.gypi:
2124         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2125
2126 2013-02-27  Jochen Eisinger  <jochen@chromium.org>
2127
2128         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2129         https://bugs.webkit.org/show_bug.cgi?id=110973
2130
2131         Reviewed by Adam Barth.
2132
2133         There is nothing that ensures that the log messages from the plugin
2134         come in before the layout test finished loading.
2135
2136         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2137         (PassDifferentNPPStruct::NPP_SetWindow):
2138         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2139         (NPP_SetWindow):
2140
2141 2013-02-27  Glenn Adams  <glenn@skynav.com>
2142
2143         Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
2144         https://bugs.webkit.org/show_bug.cgi?id=110944
2145
2146         Reviewed by Dean Jackson.
2147
2148         * Scripts/webkitperl/FeatureList.pm:
2149         * qmake/mkspecs/features/features.pri:
2150
2151 2013-02-27  Yong Li  <yong.li.webkit@outlook.com>
2152
2153         Unreviewed. Remove myself from watchlist.
2154
2155         * Scripts/webkitpy/common/config/watchlist:
2156
2157 2013-02-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2158
2159         Switch QtWebKit to GStreamer 1.0.
2160         https://bugs.webkit.org/show_bug.cgi?id=106669.
2161
2162         Original patch by Sebastian Dröge.
2163         Reviewed by Csaba Osztrogonác.
2164
2165         Build with GStreamer 1.0 if available, but support GStreamer 0.10 
2166         temporarily to make upgrading easy and the patch suitable for Qt5.
2167
2168         * qmake/mkspecs/features/features.prf:
2169
2170 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
2171
2172         Unreviewed. Added myself to committers.py
2173
2174         * Scripts/webkitpy/common/config/committers.py:
2175
2176 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2177
2178         Unreviewed, rolling out r144192.
2179         http://trac.webkit.org/changeset/144192
2180         https://bugs.webkit.org/show_bug.cgi?id=110984
2181
2182         Stored svn password on wrong computer (Requested by kkristof
2183         on #webkit).
2184
2185         * Scripts/webkitpy/common/config/committers.py:
2186
2187 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
2188
2189         Unreviewed. Added myself to committers.py
2190
2191         * Scripts/webkitpy/common/config/committers.py:
2192
2193 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2194
2195         Build fix after r144155. The report page is located at /api/report, not /api/test/report.
2196
2197         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2198         (PerfTestsRunner._upload_json):
2199
2200 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2201
2202         Stop uploading results to webkit-perf.appspot.com
2203         https://bugs.webkit.org/show_bug.cgi?id=110954
2204
2205         Reviewed by Benjamin Poulain.
2206
2207         When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
2208         Also, always use the new JSON format. Removed the code to generate the old format.
2209
2210         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2211         (PerfTestsRunner._generate_and_show_results):
2212         (PerfTestsRunner._generate_results_dict):
2213         (PerfTestsRunner._merge_slave_config_json):
2214         (PerfTestsRunner._generate_output_files):
2215
2216 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2217
2218         Unreviewed, rolling out r144136, r144143, and r144147.
2219         http://trac.webkit.org/changeset/144136
2220         http://trac.webkit.org/changeset/144143
2221         http://trac.webkit.org/changeset/144147
2222         https://bugs.webkit.org/show_bug.cgi?id=110950
2223
2224         Caused some timeouts and flaky crashes (Requested by abarth on
2225         #webkit).
2226
2227         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2228         (main):
2229         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2230         (WebTestRunner::WebPreferences::reset):
2231         * DumpRenderTree/chromium/TestShell.cpp:
2232         (TestShell::TestShell):
2233
2234 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2235
2236         Use perf.webkit.org JSON format in results page
2237         https://bugs.webkit.org/show_bug.cgi?id=110842
2238
2239         Reviewed by Benjamin Poulain.
2240
2241         Change the default JSON format from that of webkit-perf.appspot.com to that of perf.webkit.org.
2242
2243         A whole bunch of integration tests have been updated to use the new JSON format.
2244
2245         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2246         (PerfTestsRunner._generate_and_show_results): Renamed output and output_path to legacy_output
2247         and legacy_output_json_path respectively.
2248         (PerfTestsRunner._generate_results_dict): Don't assume meta build information is always available.
2249         (PerfTestsRunner._generate_output_files): Make json_output, which is used to generate the default
2250         JSON file and the results page out of perf_webkit_output instead of legacy_output.
2251
2252         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2253         (MainTest.test_run_memory_test):
2254         (MainTest._test_run_with_json_output.mock_upload_json):
2255         (MainTest):
2256         (MainTest.test_run_with_json_output):
2257         (MainTest.test_run_with_description):
2258         (MainTest.test_run_generates_json_by_default):
2259         (MainTest.test_run_merges_output_by_default):
2260         (MainTest.test_run_respects_reset_results):
2261         (MainTest.test_run_generates_and_show_results_page):
2262         (MainTest.test_run_with_slave_config_json):
2263         (MainTest.test_run_with_multiple_repositories):
2264         (MainTest.test_run_with_upload_json):
2265         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
2266
2267 2013-02-26  Adam Barth  <abarth@webkit.org>
2268
2269         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
2270         https://bugs.webkit.org/show_bug.cgi?id=110907
2271
2272         Reviewed by Eric Seidel.
2273
2274         This patch changes --enable-threaded-html-parser into
2275         --disable-threaded-html-parser and thereby enables the threaded HTML
2276         parser by default for the Chromium port.
2277
2278         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2279         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2280         (WebTestRunner::WebPreferences::reset):
2281         * DumpRenderTree/chromium/TestShell.cpp:
2282         (TestShell::TestShell):
2283
2284 2013-02-26  Dirk Pranke  <dpranke@chromium.org>
2285
2286         [chromium] Re-enable the fixed version of freetype on linux
2287         https://bugs.webkit.org/show_bug.cgi?id=110542
2288
2289         Reviewed by Tony Chang.
2290
2291         Re-land the change in r143794 to switch to building with a fixed
2292         version of FreeType for just DumpRenderTree. This allows us to share
2293         one version of pixel baselines for both Lucid and Precise, and run the
2294         layout tests in a stock Precise install (instead of a Lucid chroot).
2295         Going forward, this approach isolates us from os-level changes to the
2296         version of FreeType. Note that Chromium itself still uses the system
2297         FreeType and is unaffected by this change.
2298         
2299         This setting can still be turned off (at compile/gyp-time) by
2300         manually setting use_custom_freetype=0.
2301
2302         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2303
2304 2013-02-26  Nico Weber  <thakis@chromium.org>
2305
2306         [chromium] content shell drt: Enable WebKit::setLayoutTestMode()
2307         https://bugs.webkit.org/show_bug.cgi?id=110890
2308
2309         Reviewed by Jochen Eisinger.
2310
2311         Several functions in webkit check that bit to change rendering
2312         in layout test mode. For example, platform/graphics/skia/FrontSkia.cpp
2313         disables font smoothing in this mode. TestShell and DRT both set
2314         this flag, so content shell drt should set it too.
2315
2316         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2317         (WebTestRunner::TestInterfaces::TestInterfaces):
2318
2319 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
2320
2321         new-commit-bot: Fix the unit test newcommitbot-unittest.py due to r144040
2322         https://bugs.webkit.org/show_bug.cgi?id=110884
2323
2324         Reviewed by Csaba Osztrogonác.
2325
2326         Adding the missing spaces before ':' in the unit test.
2327
2328         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2329
2330 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
2331
2332         new-commit-bot: Some IRC clients doesn't linkify rollout messages
2333         https://bugs.webkit.org/show_bug.cgi?id=110861
2334
2335         Reviewed by Ryosuke Niwa.
2336
2337         Adding the space before ':' in order to fix the links shown for the rollout message.
2338
2339         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2340         (NewCommitBot._summarize_commit_log):
2341
2342 2013-02-26  Joone Hur  <joone.hur@intel.com>
2343
2344         [GTK] Add Clutter to jhbuild
2345         https://bugs.webkit.org/show_bug.cgi?id=110245
2346
2347         Reviewed by Martin Robinson.
2348
2349         Add clutter, cogl, clutter-gtk, and atk to the optional moduleset.
2350         This allows to build WebKitGtk+ with clutter as an acceleration backend
2351         within the jhbuild environment. 
2352
2353         * gtk/jhbuild-optional.modules:
2354
2355 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2356
2357         Another fix attempt after r143991 since having \r? after a greedy match doesn't help.
2358
2359         * Scripts/webkitpy/common/checkout/scm/svn.py:
2360         (SVN.value_from_svn_info):
2361
2362 2013-02-25  Alan Cutter  <alancutter@chromium.org>
2363
2364         GCE EWS bots failing intermittently on HTTP 502 error while updating their status
2365         https://bugs.webkit.org/show_bug.cgi?id=110845
2366
2367         Unreviewed EWS bot fix.
2368
2369         Switch the Queue Status Server address the EWS bots use to a more direct URL that
2370         doesn't seem to be having problems from GCE like queues.webkit.org.
2371
2372         * Scripts/webkitpy/common/net/statusserver.py:
2373         (StatusServer):
2374
2375 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
2376
2377         Forgot to delete a no-longer-needed unit test after r143980.
2378
2379         Unreviewed, build fix.
2380
2381         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2382         (ChromiumWinTest.test_path_to_image_diff):
2383
2384 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2385
2386         Build fix. run-perf-tests was reporting with revision numbers ending with \r.
2387         Don't include \r at the end of svn info lines on Windows.
2388
2389         This is similar to r143839.
2390
2391         * Scripts/webkitpy/common/checkout/scm/svn.py:
2392         (SVN.value_from_svn_info):
2393
2394 2013-02-25  James Simonsen  <simonjam@chromium.org>
2395
2396         [Resource Timing] Update test suite so it can be exported to the W3C
2397         https://bugs.webkit.org/show_bug.cgi?id=107343
2398
2399         Reviewed by Tony Gentilcore.
2400
2401         * Scripts/export-w3c-performance-wg-tests: Clean up output.
2402         * Scripts/import-w3c-performance-wg-tests:
2403
2404 2013-02-25  Anders Carlsson  <andersca@apple.com>
2405
2406         Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
2407         https://bugs.webkit.org/show_bug.cgi?id=110821
2408         <rdar://problem/13265303>
2409
2410         Reviewed by Beth Dakin.
2411
2412         Update for WebKit2 changes.
2413
2414         * MiniBrowser/mac/WK2BrowserWindowController.m:
2415         (-[WK2BrowserWindowController awakeFromNib]):
2416         * WebKitTestRunner/TestController.cpp:
2417         (WTR::TestController::createOtherPage):
2418         (WTR::TestController::createWebViewWithOptions):
2419         (WTR::TestController::unavailablePluginButtonClicked):
2420         * WebKitTestRunner/TestController.h:
2421         (TestController):
2422
2423 2013-02-21  Jeffrey Pfau  <jpfau@apple.com>
2424
2425         Optionally partition cache to prevent using cache for tracking
2426         https://bugs.webkit.org/show_bug.cgi?id=110269
2427
2428         Reviewed by Maciej Stachowiak.
2429
2430         Add test suite for public suffix functions on Mac.
2431
2432         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2433         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.
2434         (TestWebKitAPI):
2435         (TestWebKitAPI::TEST_F):
2436
2437 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
2438
2439         nrwt: reenable multiple http shards on chromium win
2440         https://bugs.webkit.org/show_bug.cgi?id=110814
2441
2442         Reviewed by Tony Chang.
2443
2444         The underlying bug in DumpRenderTree that was causing us to look for a
2445         pac file and timeout under load was fixed a while ago.
2446
2447         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2448         (ChromiumWinPort.relative_test_filename):
2449
2450 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
2451
2452         Make ninja the default w/ build-webkit --chromium on windows.
2453         https://bugs.webkit.org/show_bug.cgi?id=110731
2454
2455         Unreviewed - TBR'ing thakis :).
2456
2457         * Scripts/update-webkit-chromium:
2458
2459 2013-02-25  Anders Carlsson  <andersca@apple.com>
2460
2461         Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
2462         https://bugs.webkit.org/show_bug.cgi?id=110793
2463         <rdar://problem/13265303>
2464
2465         Reviewed by Sam Weinig.
2466
2467         Update for WebKit2 API changes.
2468
2469         * MiniBrowser/mac/WK2BrowserWindowController.m:
2470         (-[WK2BrowserWindowController awakeFromNib]):
2471         * WebKitTestRunner/TestController.cpp:
2472         (WTR::TestController::createWebViewWithOptions):
2473
2474 2013-02-25  Nico Weber  <thakis@chromium.org>
2475
2476         Fix python unit tests after yoli's email address update in http://trac.webkit.org/changeset/143922
2477         https://bugs.webkit.org/show_bug.cgi?id=110775
2478
2479         Unreviewed, basically a rebaseline.
2480
2481         * Scripts/webkitpy/common/config/watchlist:
2482
2483 2013-02-25  Nico Weber  <thakis@chromium.org>
2484
2485         [chromium] Try to get the webkit builder to use msvs again
2486         https://bugs.webkit.org/show_bug.cgi?id=110771
2487
2488         Reviewed by Eric Seidel.
2489
2490         The msvs gyp generator apparently doesn't write the sln file on every
2491         run, so check the vcxproj file instead.
2492
2493         * Scripts/webkitdirs.pm:
2494         (determineIsChromiumNinja):
2495
2496 2013-02-25  Nico Weber  <thakis@chromium.org>
2497
2498         [chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
2499         https://bugs.webkit.org/show_bug.cgi?id=110767
2500
2501         Reviewed by Eric Seidel.
2502
2503         The tester runs gyp, which generates out/Release/build.ninja. The bot
2504         scripts use existence (and timestamp) of that file to decide if the
2505         current build is supposed to be ninja or xcodebuild. The file exists,
2506         so the snapshot is extracted to out/Release. The snapshot doesn't
2507         contain build.ninja however due to
2508         http://trac.webkit.org/changeset/140375 , so after extracting the
2509         snapshot the scripts think that this is an xcodebuild build. So remove
2510         the part of that revision that removed ninja files from the archive,
2511         and the bots should be happy again.
2512
2513         * BuildSlaveSupport/built-product-archive:
2514         (archiveBuiltProduct):
2515
2516 2013-02-25  Nico Weber  <thakis@chromium.org>
2517
2518         Fix tests after r143910
2519         https://bugs.webkit.org/show_bug.cgi?id=110757
2520
2521         Reviewed by Andreas Kling.
2522
2523         While here, also add a test for the bug r143910 fixed.
2524
2525         * Scripts/webkitpy/common/system/executive_unittest.py:
2526         (ScriptErrorTest.test_message_with_output):
2527         (ScriptErrorTest):
2528         (ScriptErrorTest.test_message_with_tuple):
2529
2530 2013-02-25  Nico Weber  <thakis@chromium.org>
2531
2532         [chromium] Apparently built-product-archive is written in Python, not Perl :-/
2533         https://bugs.webkit.org/show_bug.cgi?id=110755
2534
2535         Reviewed by Jochen Eisinger.
2536
2537         * BuildSlaveSupport/built-product-archive:
2538         (archiveBuiltProduct):
2539         (extractBuiltProduct):
2540
2541 2013-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2542
2543         Unreviewed, rolling out r143895.
2544         http://trac.webkit.org/changeset/143895
2545         https://bugs.webkit.org/show_bug.cgi?id=110758
2546
2547         broke a bunch of tests (Requested by thakis__ on #webkit).
2548
2549         * Scripts/update-webkit-chromium:
2550
2551 2013-02-25  Andreas Kling  <akling@apple.com>
2552
2553         Unreviewed, fix simple mistake in r143903.
2554         <http://webkit.org/b/110746>
2555
2556         Reviewed by Andreas Kling.
2557
2558         Pass git revision, not svn revision, to git shell command.
2559
2560         * Scripts/webkitpy/common/checkout/scm/git.py:
2561         (Git.timestamp_of_latest_commit):
2562
2563 2013-02-25  Nico Weber  <thakis@chromium.org>
2564
2565         [chromium] Let built-product-archive log which directory it's archiving from and extracting to
2566         https://bugs.webkit.org/show_bug.cgi?id=110748
2567
2568         Reviewed by Jochen Eisinger.
2569
2570         One of the mac testers runs DRT from out/ but WebKitUnitTests from
2571         xcodebuild. I'm trying to understand what's going on.
2572
2573         * BuildSlaveSupport/built-product-archive:
2574         (archiveBuiltProduct):
2575         (extractBuiltProduct):
2576
2577 2013-02-23  Ilya Tikhonovsky  <loislo@chromium.org>
2578
2579         Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
2580         https://bugs.webkit.org/show_bug.cgi?id=110599
2581
2582         Reviewed by Yury Semikhatsky.
2583
2584         Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
2585         that were given us via MemoryInstrumentation calls.
2586         So I extended client api with registerString method that pushes the strings
2587         down to the serializer.
2588
2589         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2590         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
2591         (TestWebKitAPI::Helper::Helper):
2592         (Helper):
2593         (TestWebKitAPI::Helper::addNode):
2594         (TestWebKitAPI::TEST):
2595
2596 2013-02-25  Nico Weber  <thakis@chromium.org>
2597
2598         Make ScriptError not crash when args is a tuple
2599         https://bugs.webkit.org/show_bug.cgi?id=110747
2600
2601         Reviewed by Jochen Eisinger.
2602
2603         I'm trying to understand the error on
2604         http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
2605         better. I'll likely have to revert the ninja switch on windows, but
2606         having error reporting code that doesn't itself crash sounds like a
2607         good thing to have anyways.
2608
2609         The problem is that '%s' % (1, 2) errors out, and args is sometimes a
2610         tuple not a list.
2611
2612         * Scripts/run-chromium-webkit-unit-tests:
2613         * Scripts/webkitpy/common/system/executive.py:
2614         (ScriptError.__init__):
2615
2616 2013-02-25  Laszlo Gombos  <l.gombos@samsung.com>
2617
2618         [EFL] Align feature defaults
2619         https://bugs.webkit.org/show_bug.cgi?id=110715
2620
2621         Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
2622         OptionsEfl.cmake.
2623
2624         Reviewed by Gyuyoung Kim.
2625
2626         * Scripts/webkitperl/FeatureList.pm:
2627
2628 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2629
2630         run-perf-tests reports wrong commit time
2631         https://bugs.webkit.org/show_bug.cgi?id=110746
2632
2633         Reviewed by Andreas Kling.
2634
2635         The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
2636         of when the subdirectory was last modified.
2637
2638         Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
2639         insufficient since running "svn log -r <revision>" on a partial checkout only returns
2640         an empty result if the revision didn't modify the subdirectory.
2641
2642         For git, there is no partial checkout, so we just need to pass in "-r" option to keep
2643         the interface compatible with svn.
2644
2645         * Scripts/webkitpy/common/checkout/scm/git.py:
2646         (Git.timestamp_of_latest_commit):
2647         * Scripts/webkitpy/common/checkout/scm/scm.py:
2648         (SCM.timestamp_of_latest_commit):
2649         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2650         (MockSCM.timestamp_of_latest_commit):
2651         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2652         (test_timestamp_of_latest_commit):
2653         * Scripts/webkitpy/common/checkout/scm/svn.py:
2654         (SVN.timestamp_of_latest_commit):
2655         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2656         (PerfTestsRunner._generate_results_dict):
2657
2658 2013-02-25  Jochen Eisinger  <jochen@chromium.org>
2659
2660         [chromium] move WebRuntimeFeatures configuration to TestRunner library
2661         https://bugs.webkit.org/show_bug.cgi?id=110712
2662
2663         Reviewed by Nico Weber.
2664
2665         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2666         (WebTestRunner::TestInterfaces::TestInterfaces):
2667         * DumpRenderTree/chromium/TestShell.cpp:
2668         (TestShell::TestShell):
2669
2670 2013-02-25  Nico Weber  <thakis@chromium.org>
2671
2672         Make ninja the default build system for build-webkit --chromium on windows
2673         https://bugs.webkit.org/show_bug.cgi?id=110731
2674
2675         Reviewed by Jochen Eisinger.
2676
2677         With http://crbug.com/169945 fixed, this should now work.
2678
2679         * Scripts/update-webkit-chromium:
2680
2681 2013-02-24  Gustavo Noronha Silva  <gns@gnome.org>
2682
2683         [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
2684         https://bugs.webkit.org/show_bug.cgi?id=110702
2685
2686         Reviewed by Martin Robinson.
2687
2688         * GtkLauncher/main.c: include autotoolsconfig.h.
2689         * Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
2690         the include ordering check, since it uses autotoolsconfig.h which needs to
2691         come first.
2692
2693 2013-02-24  Hajime Morrita  <morrita@google.com>
2694
2695         [Custom Elements] Implement bare-bone document.register()
2696         https://bugs.webkit.org/show_bug.cgi?id=100229
2697
2698         Reviewed by Adam Barth.
2699
2700         Added enableCustomDOMElements flag.
2701
2702         * DumpRenderTree/chromium/TestShell.cpp:
2703         (TestShell::TestShell):
2704
2705 2013-02-23  Mark Pilgrim  <pilgrim@chromium.org>
2706
2707         [Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
2708         https://bugs.webkit.org/show_bug.cgi?id=110606
2709
2710         Reviewed by Adam Barth.
2711
2712         Part of a larger refactoring series; see tracking bug 82948.
2713
2714         * DumpRenderTree/DumpRenderTree.gypi:
2715         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2716         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
2717         (WebKitSupportTestEnvironment::mockPlatform):
2718         (WebKitSupportTestEnvironment):
2719         * DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
2720         (MockPlatform::create):
2721         (MockPlatform::MockPlatform):
2722         (MockPlatform::~MockPlatform):
2723         (MockPlatform::setInterfaces):
2724         (MockPlatform::cryptographicallyRandomValues):
2725         (MockPlatform::createMediaStreamCenter):
2726         (MockPlatform::createRTCPeerConnectionHandler):
2727         * DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
2728         (MockPlatform):
2729         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
2730         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
2731         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2732         (WebTestDelegate):
2733         * DumpRenderTree/chromium/TestShell.cpp:
2734         (TestShell::initialize):
2735         * DumpRenderTree/chromium/TestShell.h:
2736         (TestShell):
2737
2738 2013-02-23  Ryosuke Niwa  <rniwa@webkit.org>
2739
2740         Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.
2741
2742         * Scripts/webkitpy/common/checkout/scm/svn.py:
2743         (SVN.timestamp_of_latest_commit):
2744
2745 2013-02-23  Jason Anderssen  <janderssen@gmail.com>
2746
2747         Move setAutofilled from TestRunner to WebCore
2748         https://bugs.webkit.org/show_bug.cgi?id=110521
2749
2750         Reviewed by Benjamin Poulain.
2751
2752         * DumpRenderTree/TestRunner.cpp:
2753         (TestRunner::staticFunctions):
2754         * DumpRenderTree/TestRunner.h:
2755         (TestRunner):
2756         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2757         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2758         (WebTestRunner::TestRunner::TestRunner):
2759         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2760         (TestRunner):
2761         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2762         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2763         * DumpRenderTree/mac/TestRunnerMac.mm:
2764         * DumpRenderTree/qt/TestRunnerQt.cpp:
2765         * DumpRenderTree/qt/TestRunnerQt.h:
2766         (TestRunnerQt):
2767         * DumpRenderTree/win/TestRunnerWin.cpp:
2768         * DumpRenderTree/wx/TestRunnerWx.cpp:
2769
2770 2013-02-22  Ryosuke Niwa  <rniwa@webkit.org>
2771
2772         Upload results to perf.webkit.org in addition to the one specified by --test-results-server
2773         https://bugs.webkit.org/show_bug.cgi?id=108577
2774
2775         Reviewed by Dirk Pranke.
2776
2777         Upload results to perf.webkit.org using new JSON format as well as the host specified by
2778         --test-results-server. The new format is needed to provide extra information perf.webkit.org
2779         need such as the subversion commit time and test URLs. This is a temporarily measure until
2780         we complete the transition and the old JSON format and the code to upload results to
2781         webkit-perf.appspot.com can be deleted.
2782
2783         This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
2784         in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
2785         so that the app can sort performance test results based on the timestamp of the last commit.
2786
2787         It also changes the repository names returned by port objects to be properly capitalized
2788         human readable names such as WebKit instead of lowercased names such as webkit since these names
2789         are displayed on perf.webkit.org for humans. Several users of this feature has been updated
2790         to explicitly lowercase the names.
2791
2792
2793         * Scripts/webkitpy/common/checkout/scm/git.py:
2794         (Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
2795         git's timestamp granularity is seconds so we're losing some information compared to using a regular
2796         subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
2797         UTC so we're going to manually fiddle with timezone.
2798
2799         * Scripts/webkitpy/common/checkout/scm/scm.py:
2800         (SCM.timestamp_of_latest_commit): Added.
2801
2802         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2803         (MockSCM.timestamp_of_latest_commit): Added.
2804
2805         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2806         (test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.
2807
2808         * Scripts/webkitpy/common/checkout/scm/svn.py:
2809         (SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
2810         the timestamp which is always in UTC.
2811
2812         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2813         (JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
2814         'chromium' needs to be substituted by 'chrome' for historical reasons.
2815
2816         * Scripts/webkitpy/layout_tests/port/base.py:
2817         (Port.repository_paths): Return WebKit instead of webkit as noted above.
2818
2819         * Scripts/webkitpy/layout_tests/port/chromium.py:
2820         (ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.
2821
2822         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2823         (PerfTestsRunner.__init__): Store the current time in UTC as well as in local time.
2824         (PerfTestsRunner._collect_tests):
2825
2826         (PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
2827         and upload them appropriately.
2828
2829         (PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
2830         in revisions_for_perf_webkit and construct an output for perf.webkit.org.
2831
2832         (PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.
2833
2834         (PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
2835         and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
2836         e.g. "processor" would be renamed to "builderProcessor".
2837
2838         (PerfTestsRunner._generate_output_files):
2839
2840         (PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
2841         on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
2842         to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
2843         webkit-perf.appspot.com which spits out a plaintext response.
2844
2845         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2846         (MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
2847         (MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
2848         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.
2849
2850         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2851         (MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
2852         cases to parse JSON responses.
2853         (MainTest.test_upload_json.MockFileUploader): Refactored.
2854         (MainTest.test_upload_json.MockFileUploader.reset): Added.
2855         (MainTest.test_upload_json.MockFileUploader.__init__):
2856         (MainTest.test_upload_json.MockFileUploader.upload_single_text_file):
2857
2858 2013-02-22  Roger Fong  <roger_fong@apple.com>
2859
2860         Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.
2861
2862         * BuildSlaveSupport/build.webkit.org-config/config.json:
2863
2864 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
2865
2866         Unreviewed, rolling out r143794.
2867         http://trac.webkit.org/changeset/143794
2868         https://bugs.webkit.org/show_bug.cgi?id=110542
2869
2870         debug linux builds broken?
2871
2872         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2873
2874 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
2875
2876         [chromium] enable the fixed version of freetype on linux
2877         https://bugs.webkit.org/show_bug.cgi?id=110542
2878
2879         Reviewed by Tony Chang.
2880
2881         Switch to building with a fixed version of FreeType for
2882         just DumpRenderTree. This allows us to share one version
2883         of pixel baselines for both Lucid and Precise, and run
2884         the layout tests in a stock Precise install (instead of a Lucid
2885         chroot). Going forward, this approach isolates us from os-level
2886         changes to the version of FreeType. Note that Chromium itself
2887         still uses the system FreeType and is unaffected by this change.
2888         
2889         This setting can still be turned off (at compile/gyp-time) by
2890         manually setting use_custom_freetype=0.
2891
2892         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2893
2894 2013-02-22  Anders Carlsson  <andersca@apple.com>
2895
2896         Move pluginLoadPolicy to the page loader client
2897         https://bugs.webkit.org/show_bug.cgi?id=110635
2898
2899         Reviewed by Sam Weinig.
2900
2901         * MiniBrowser/mac/WK2BrowserWindowController.m:
2902         (-[WK2BrowserWindowController awakeFromNib]):
2903         * WebKitTestRunner/TestController.cpp:
2904         (WTR::TestController::createOtherPage):
2905         (WTR::TestController::createWebViewWithOptions):
2906
2907 2013-02-22  Kenneth Russell  <kbr@google.com>
2908
2909         Unreviewed. Changed gman's primary address for auto-complete in Bugzilla.
2910
2911         * Scripts/webkitpy/common/config/committers.py:
2912
2913 2013-02-22  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2914
2915         [WTR] Do not dump information about empty subframes.
2916         https://bugs.webkit.org/show_bug.cgi?id=110585
2917
2918         Reviewed by Simon Fraser.
2919
2920         Follow DumpRenderTree more closely by skipping empty frames
2921         (frames which have no document). We are not really interested in
2922         showing anything about them.
2923
2924         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2925         (WTR::dumpDescendantFramesText): Do not print subframe names when they
2926         have no associated Document.
2927
2928 2013-02-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2929
2930         [EFL][DRT] Do not dump empty frames.
2931         https://bugs.webkit.org/show_bug.cgi?id=110474
2932
2933         Reviewed by Kenneth Rohde Christiansen.
2934
2935         Follow the original Mac implementation more closely by skipping
2936         empty frames (frames which have no document). We are not really
2937         interested in showing anything about them.
2938
2939         * DumpRenderTree/efl/DumpRenderTree.cpp:
2940         (dumpFramesAsText):
2941
2942 2013-02-21  Dirk Pranke  <dpranke@chromium.org>
2943
2944         [chromium] support the lucid version of freetype on precise in DRT
2945         https://bugs.webkit.org/show_bug.cgi?id=107338
2946
2947         Reviewed by Tony Chang.
2948
2949         Modify the DRT build so that we can optionally link against
2950         a fixed version of Freetype2. This allows us to share pixel test
2951         results across multiple versions of Ubuntu without having to
2952         worry about differences in font rendering.
2953
2954         At the moment this feature is off by default. Eventually it will
2955         be on by default on linux.
2956
2957         Note that this only affects DRT; the regular Chromium binary
2958         (and, for now, content_shell) will still use the system version
2959         of Freetype.
2960
2961         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2962
2963 2013-02-21  Rouslan Solomakhin  <rouslan@chromium.org>
2964
2965         [Chromium] Remove the word "cheher" from the list of misspelled words
2966         https://bugs.webkit.org/show_bug.cgi?id=110447
2967
2968         Reviewed by Tony Chang.
2969
2970         Other platforms do not mark "cheher" as a misspelled word in layout tests.
2971         This change is to bring Chromium platform in line with the rest of the
2972         platforms.
2973
2974         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
2975         (WebTestRunner::MockSpellCheck::hasInCache): Changed "cheher" to "wellcome".
2976         (WebTestRunner::MockSpellCheck::fillSuggestionList): Removed "cheher" misspelling and "checker" suggestion.
2977         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Removed "cheher" misspelling.
2978
2979 2013-02-21  Jochen Eisinger  <jochen@chromium.org>
2980
2981         [chromium] document WebTestDelegate and WebTestRunner interfaces
2982         https://bugs.webkit.org/show_bug.cgi?id=110472
2983
2984         Reviewed by Adam Barth.
2985
2986         Also remove the default implementation of the remaining WebTestDelegate
2987         methods now that all embedders provide this interface.
2988
2989         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2990         (WebTestDelegate):
2991         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2992         (WebTestRunner):
2993
2994 2013-02-19  Mark Hahnenberg  <mhahnenberg@apple.com>
2995
2996         Objective-C API: Need a way to use the Objective-C JavaScript API with WebKit
2997         https://bugs.webkit.org/show_bug.cgi?id=106059
2998
2999         Reviewed by Geoffrey Garen.
3000
3001         Added new tests for the WebKit API portion of the JSC Objective-C API.
3002
3003         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3004         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache1.html: Added.
3005         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache2.html: Added.
3006         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm: Added.
3007         (-[MyConsole log:]):
3008         (-[MyConsole printHelloWorld]):
3009         (-[MyConsole add:to:]):
3010         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didFinishLoadForFrame:]):
3011         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
3012         (TestWebKitAPI):
3013         (TestWebKitAPI::TEST):
3014
3015 2013-02-21  Stephen Chenney  <schenney@chromium.org>
3016
3017         Unreviewed, add myself as a reviewer
3018
3019         * Scripts/webkitpy/common/config/committers.py:
3020
3021 2013-02-21  Jer Noble  <jer.noble@apple.com>
3022
3023         Unreviewed; add myself to the Media watchlist and update my committers.py setting to Reviewer.
3024
3025         * Scripts/webkitpy/common/config/committers.py:
3026         * Scripts/webkitpy/common/config/watchlist:
3027
3028 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
3029
3030         gtk/DumpRenderTree.cpp is missing <locale.h> include
3031         https://bugs.webkit.org/show_bug.cgi?id=109386
3032
3033         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build
3034         by include locale.h when we use setlocale.
3035
3036 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
3037
3038         [GTK] Move feature overriding to the configure phase
3039         https://bugs.webkit.org/show_bug.cgi?id=110293
3040
3041         Reviewed by Gustavo Noronha Silva.
3042
3043         * Scripts/webkitdirs.pm:
3044         (runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
3045         WebKitFeatureOverrides.txt to better match the other filenames used in
3046         the new feature processing.
3047         * gtk/generate-feature-defines-files: Added. A script which takes as an argument
3048         the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
3049         and writes WebKitFeatures.txt and WebKitFeatures.h.
3050         * gtk/override-feature-defines: Removed.
3051
3052 2013-02-21  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3053
3054         [Qt] Remove obsolete DEPENDPATH assignment
3055
3056         Reviewed by Simon Hausmann
3057
3058         qmake now adds CONFIG+=depend_includepath by default, making manual
3059         DEPENDPATH setup unnecessary.
3060
3061         * qmake/mkspecs/features/default_post.prf:
3062
3063 2013-02-20  Vivek Galatage  <vivekg@webkit.org>
3064
3065         Unreviewed. Changing primary email id.
3066
3067         * Scripts/webkitpy/common/config/committers.py:
3068
3069 2013-02-14  James Robinson  <jamesr@chromium.org>
3070
3071         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
3072         https://bugs.webkit.org/show_bug.cgi?id=109634
3073
3074         Reviewed by Adrienne Walker.
3075
3076         * DumpRenderTree/chromium/WebViewHost.cpp:
3077         (WebViewHost::createOutputSurface):
3078         (WebViewHost::initializeLayerTreeView):
3079
3080 2013-02-20  Martin Robinson  <mrobinson@igalia.com>
3081
3082         [GTK] Re-enable 3D CSS transforms when using build-webkit
3083         https://bugs.webkit.org/show_bug.cgi?id=110402
3084
3085         Reviewed by Xan Lopez.
3086
3087         * Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default
3088         when building WebKitGTK+.
3089
3090 2013-02-20  Roger Fong  <roger_fong@apple.com>
3091
3092         Get VS2010 Solution B&I ready.
3093         <rdar://problem/1322988>
3094
3095         Rubberstamped by Timothy Horton.        
3096         
3097         Add Production configurations.
3098         
3099         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3100         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3101         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Added.
3102         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3103         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Added.
3104         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3105         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3106         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3107         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Added.
3108         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3109         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Added.
3110         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3111         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3112         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Added.
3113         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3114         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3115         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Added.
3116         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3117         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3118         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3119         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Added.
3120         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3121         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Added.
3122         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3123         * win/record-memory/record-memory.vcxproj:
3124         * win/record-memory/record-memoryProduction.props: Added.
3125         * win/record-memory/record-memoryRelease.props:
3126
3127 2013-02-20  Dirk Schulze  <krit@webkit.org>
3128
3129         Enable CANVAS_PATH flag
3130         https://bugs.webkit.org/show_bug.cgi?id=108508
3131
3132         Reviewed by Simon Fraser.
3133
3134         Enable CANVAS_PATH flag on trunk.
3135
3136         * Scripts/webkitperl/FeatureList.pm:
3137
3138 2013-02-20  Tony Chang  <tony@chromium.org>
3139
3140         Parse author names with commas in ChangeLogs
3141         https://bugs.webkit.org/show_bug.cgi?id=110356
3142
3143         Reviewed by Dirk Pranke.
3144
3145         Paweł's name has a comma in it, which was confusing the ChangeLog parser.
3146
3147         * Scripts/webkitpy/common/checkout/changelog.py:
3148         (ChangeLogEntry): Move name splitting regexp into a constant.
3149         (ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
3150         (ChangeLogEntry._split_reviewer_names): Rename to be more specific.
3151         (ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
3152         (ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.
3153         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3154         (test_parse_authors): Test case with Paweł's name.
3155
3156 2013-02-15  Dirk Schulze  <krit@webkit.org>
3157
3158         [Chromium] Add runtime flag for CanvasPath
3159         https://bugs.webkit.org/show_bug.cgi?id=109997
3160
3161         Reviewed by Adam Barth.
3162
3163         Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
3164         the constructor for Path on DOMWindow would never be activatable, since the script
3165         is running after creating the DOMWindow object.
3166
3167         * DumpRenderTree/chromium/TestShell.cpp:
3168         (TestShell::TestShell):
3169
3170 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
3171
3172         [chromium] use a WebTestProxyBase pointer to identify the window we need the history for
3173         https://bugs.webkit.org/show_bug.cgi?id=110346
3174
3175         Reviewed by Adam Barth.
3176
3177         Using an index is very brittle, as the TestRunner API does not define
3178         any ordering of windows.
3179
3180         Also, make TestRunner::shouldDumpBackForwardList() so content shell can
3181         trigger the capturing in the browser process before generating the
3182         text dump.
3183
3184         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3185         (WebTestRunner):
3186         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
3187         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3188         (WebTestRunner):
3189         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3190         (TestRunner):
3191         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3192         (WebTestRunner::WebTestProxyBase::captureTree):
3193         * DumpRenderTree/chromium/WebViewHost.cpp:
3194         (WebViewHost::captureHistoryForWindow):
3195         * DumpRenderTree/chromium/WebViewHost.h:
3196         (WebViewHost):
3197
3198 2013-02-19  Rouslan Solomakhin  <rouslan@chromium.org>
3199
3200         [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache
3201         https://bugs.webkit.org/show_bug.cgi?id=109220
3202
3203         Reviewed by Tony Chang.
3204
3205         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
3206         (WebTestRunner::MockSpellCheck::hasInCache): Added a method to detect whether spellcheck results can be served from cache.
3207         (WebTestRunner):
3208         (WebTestRunner::MockSpellCheck::fillSuggestionList): Modified to suggest "checker" for the word "cheher".
3209         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Modified to mark "cheher" as misspelling.
3210         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
3211         (MockSpellCheck):
3212         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
3213         (WebTestRunner::SpellCheckClient::requestCheckingOfText): Modified to serve spellcheck suggestions from cache when possible.
3214
3215 2013-02-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3216
3217         [Gtk] HTML5 Media controls require a design refresh
3218         https://bugs.webkit.org/show_bug.cgi?id=83869
3219
3220         Reviewed by Philippe Normand.
3221
3222         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3223         (initializeGtkFontSettings): Added gnome as default icon theme for
3224         the DRT.
3225         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3226         (WTR::initializeGtkSettings): Added gnome as default icon theme for
3227         the WTR.
3228         * gtk/jhbuild.modules: Added gnome-icon-theme-symbolic as external
3229         dependency.
3230
3231 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
3232
3233         [chromium] move most of the remaining mocks to TestRunner library
3234         https://bugs.webkit.org/show_bug.cgi?id=110217
3235
3236         Reviewed by Nico Weber.
3237
3238         While most of the functionality provided by these mocks is also
3239         available in the content module, there is no straight forward way to
3240         inject the mock results required for layout tests.
3241
3242         * DumpRenderTree/DumpRenderTree.gypi:
3243         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3244         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3245         (WebKit):
3246         (WebTestRunner):
3247         (WebTestRunner::WebTestProxy::geolocationClient):
3248         (WebTestRunner::WebTestProxy::speechInputController):
3249         (WebTestRunner::WebTestProxy::speechRecognizer):
3250         (WebTestRunner::WebTestProxy::deviceOrientationClient):
3251         (WebTestRunner::WebTestProxy::requestPointerLock):
3252         (WebTestRunner::WebTestProxy::requestPointerUnlock):
3253         (WebTestRunner::WebTestProxy::isPointerLocked):
3254         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.
3255         (WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
3256         (WebTestRunner):
3257         (WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
3258         (WebTestRunner::MockWebSpeechInputController::setDelegate):
3259         (WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
3260         (WebTestRunner::MockWebSpeechInputController::setDumpRect):
3261         (WebTestRunner::MockWebSpeechInputController::clearResults):
3262         (WebTestRunner::MockWebSpeechInputController::startRecognition):
3263         (WebTestRunner::MockWebSpeechInputController::cancelRecognition):
3264         (WebTestRunner::MockWebSpeechInputController::stopRecording):
3265         (WebTestRunner::MockWebSpeechInputController::speechTaskFired):
3266         (WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
3267         (WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
3268         (WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):
3269         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.
3270         (WebKit):
3271         (WebTestRunner):
3272         (MockWebSpeechInputController):
3273         (WebTestRunner::MockWebSpeechInputController::taskList):
3274         (SpeechTask):
3275         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.
3276         (WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
3277         (WebTestRunner):
3278         (WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
3279         (WebTestRunner::MockWebSpeechRecognizer::setDelegate):
3280         (WebTestRunner::MockWebSpeechRecognizer::start):
3281         (WebTestRunner::MockWebSpeechRecognizer::stop):
3282         (WebTestRunner::MockWebSpeechRecognizer::abort):
3283         (WebTestRunner::MockWebSpeechRecognizer::addMockResult):
3284         (WebTestRunner::MockWebSpeechRecognizer::setError):
3285         (WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
3286         (WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
3287         (WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):
3288         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.
3289         (WebKit):
3290         (WebTestRunner):
3291         (MockWebSpeechRecognizer):
3292         (WebTestRunner::MockWebSpeechRecognizer::wasAborted):
3293         (WebTestRunner::MockWebSpeechRecognizer::client):
3294         (WebTestRunner::MockWebSpeechRecognizer::handle):
3295         (WebTestRunner::MockWebSpeechRecognizer::taskList):
3296         (Task):
3297         (WebTestRunner::MockWebSpeechRecognizer::Task::Task):
3298         (WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
3299         (StepTask):
3300         (WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):
3301         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3302         (WebTestRunner::TestInterfaces::TestInterfaces):
3303         (WebTestRunner::TestInterfaces::windowOpened):
3304         (WebTestRunner):
3305         (WebTestRunner::TestInterfaces::windowClosed):
3306         (WebTestRunner::TestInterfaces::windowList):
3307         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3308         (TestInterfaces):
3309         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3310         (WebTestRunner::TestRunner::TestRunner):
3311         (WebTestRunner::TestRunner::reset):
3312         (WebTestRunner::TestRunner::requestPointerLock):
3313         (WebTestRunner):
3314         (WebTestRunner::TestRunner::requestPointerUnlock):
3315         (WebTestRunner::TestRunner::isPointerLocked):
3316         (WebTestRunner::TestRunner::didAcquirePointerLockInternal):
3317         (WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
3318         (WebTestRunner::TestRunner::didLosePointerLockInternal):
3319         (WebTestRunner::TestRunner::windowCount):
3320         (WebTestRunner::TestRunner::setMockDeviceOrientation):
3321         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
3322         (WebTestRunner::TestRunner::setGeolocationPermission):
3323         (WebTestRunner::TestRunner::setMockGeolocationPosition):
3324         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
3325         (WebTestRunner::TestRunner::addMockSpeechInputResult):
3326         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
3327         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
3328         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
3329         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
3330         (WebTestRunner::TestRunner::didAcquirePointerLock):
3331         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
3332         (WebTestRunner::TestRunner::didLosePointerLock):
3333         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
3334         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
3335         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3336         (WebTestRunner):
3337         (TestRunner):
3338         (HostMethodTask):
3339         (WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
3340         (WebTestRunner::TestRunner::HostMethodTask::runIfValid):
3341         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3342         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
3343         (WebTestRunner::WebTestProxyBase::setInterfaces):
3344         (WebTestRunner::WebTestProxyBase::setDelegate):
3345         (WebTestRunner::WebTestProxyBase::reset):
3346         (WebTestRunner::WebTestProxyBase::captureTree):
3347         (WebTestRunner::WebTestProxyBase::geolocationClientMock):
3348         (WebTestRunner):
3349         (WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
3350         (WebTestRunner::WebTestProxyBase::speechInputControllerMock):
3351         (WebTestRunner::WebTestProxyBase::speechRecognizerMock):
3352         (WebTestRunner::WebTestProxyBase::geolocationClient):
3353         (WebTestRunner::WebTestProxyBase::speechInputController):
3354         (WebTestRunner::WebTestProxyBase::speechRecognizer):
3355         (WebTestRunner::WebTestProxyBase::deviceOrientationClient):
3356         (WebTestRunner::WebTestProxyBase::requestPointerLock):
3357         (WebTestRunner::WebTestProxyBase::requestPointerUnlock):
3358         (WebTestRunner::WebTestProxyBase::isPointerLocked):
3359         * DumpRenderTree/chromium/WebViewHost.cpp:
3360         (WebViewHost::reset):
3361         * DumpRenderTree/chromium/WebViewHost.h:
3362         (WebKit):
3363         (WebViewHost):
3364
3365 2013-02-20  Andras Becsi  <andras.becsi@digia.com>
3366
3367         [Qt] Make debug builds possible on 32bit Linux
3368         https://bugs.webkit.org/show_bug.cgi?id=110231
3369
3370         Reviewed by Tor Arne Vestbø.
3371
3372         Use the stabs format for debug builds to make the object files
3373         a bit smaller so that they can be linked on a 32bit system.
3374
3375         * qmake/mkspecs/features/unix/default_post.prf:
3376
3377 2013-02-20  Takashi Toyoshima  <toyoshim@chromium.org>
3378
3379         Unreviewed. Add myself to watch lists.
3380
3381         * Scripts/webkitpy/common/config/committers.py:
3382         * Scripts/webkitpy/common/config/watchlist:
3383
3384 2013-02-19  Joshua Bell  <jsbell@chromium.org>
3385
3386         Remove warning from run-bindings-tests
3387         https://bugs.webkit.org/show_bug.cgi?id=110285
3388
3389         Reviewed by Kentaro Hara.
3390
3391         Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
3392         "Unknown option: idlattributesfile". That option was removed from
3393         bindings/scripts/preprocess-idls.pl but was still being passed by
3394         the test script. Remove it.
3395
3396         * Scripts/webkitpy/bindings/main.py:
3397         (BindingsTests.generate_supplemental_dependency): Remove unused arg.
3398
3399 2013-02-19  Elliott Sprehn  <esprehn@chromium.org>
3400
3401         Unreviewed. Add myself to watch lists.
3402
3403         * Scripts/webkitpy/common/config/committers.py:
3404         * Scripts/webkitpy/common/config/watchlist:
3405
3406 2013-02-19  Hans Muller  <hmuller@adobe.com>
3407
3408         Unreviewed, corrected primary email.
3409
3410         * Scripts/webkitpy/common/config/committers.py:
3411
3412 2013-02-19  Hans Muller  <hmuller@adobe.com>
3413
3414         Unreviewed. Adding myself as a committer.
3415
3416         * Scripts/webkitpy/common/config/committers.py:
3417
3418 2013-02-19  Pravin D  <pravind@webkit.org>
3419
3420         Unreviewed, changing primary email.
3421
3422         * Scripts/webkitpy/common/config/committers.py:
3423
3424 2013-02-19  Alan Cutter  <alancutter@chromium.org>
3425
3426         REGRESSION: Sheriffbot is failing to process rollout requests
3427         https://bugs.webkit.org/show_bug.cgi?id=106945
3428
3429         Reviewed by Adam Barth.
3430
3431         Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
3432         This resolves problems when Sheriffbot attempts to perform a rollout request.
3433
3434         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3435         * EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
3436         * EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.
3437
3438 2013-02-19  Claudio Saavedra  <csaavedra@igalia.com>
3439
3440         Unreviewed build fix.
3441
3442         * efl/jhbuild.modules:
3443         * gtk/jhbuild.modules:
3444
3445         Bump harfbuzz module to 0.9.7. See related bug 110145.
3446
3447 2013-02-19  Simon Hausmann  <simon.hausmann@digia.com>
3448
3449         [Qt] Skip the build with a warning if certain tools cannot be found in the PATH
3450         https://bugs.webkit.org/show_bug.cgi?id=110215
3451
3452         Reviewed by Tor Arne Vestbø.
3453
3454         Check that gperf, python, ruby, perl, bison and flex are in the PATH before
3455         continuing the build. Otherwise skip with an error message explaining which
3456         programs are missing from the build.
3457
3458         * qmake/mkspecs/features/configure.prf:
3459         * qmake/mkspecs/features/functions.prf:
3460
3461 2013-02-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3462
3463         Unreviewed, rolling out r143319.
3464         http://trac.webkit.org/changeset/143319
3465         https://bugs.webkit.org/show_bug.cgi?id=110214
3466
3467         Causes build issues on win32 (Requested by carewolf on
3468         #webkit).
3469
3470         * qmake/mkspecs/features/features.pri:
3471
3472 2013-02-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3473
3474         [Qt] Enable MathML
3475         https://bugs.webkit.org/show_bug.cgi?id=110205
3476
3477         Reviewed by Simon Hausmann.
3478
3479         * qmake/mkspecs/features/features.pri:
3480
3481 2013-02-17  Andrei Bucur  <abucur@adobe.com>
3482
3483         Unreviewed. Adding myself as a committer.
3484
3485         * Scripts/webkitpy/common/config/committers.py:
3486
3487 2013-02-19  Hajime Morrita  <morrita@google.com>
3488
3489         Unreviewed, updated spelling of my name.
3490
3491         * Scripts/webkitpy/common/config/committers.py:
3492
3493 2013-02-18  Ilya Tikhonovsky  <loislo@chromium.org>
3494
3495         Unreviewed. Adjust expectations.
3496
3497         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
3498         (TestWebKitAPI::TEST):
3499
3500 2013-02-18  Zan Dobersek  <zdobersek@igalia.com>
3501
3502         Unreviewed GTK gardening.
3503
3504         * Scripts/run-gtk-tests:
3505         (TestRunner): Skipped the ReloadPageAfterCrash unit test as it is flakily timing out.
3506
3507 2013-02-18  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3508
3509         [Qt][WK2] Remove duped test name and append new test in project file
3510         https://bugs.webkit.org/show_bug.cgi?id=110117
3511
3512         A new WK2 API test has landed recently (ResizeWindowAfterCrash), this patch will
3513         add this test into the runnable test suite and remove a duped test in project file.
3514
3515         Reviewed by Jocelyn Turcotte.
3516
3517         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
3518
3519 2013-02-18  Jochen Eisinger  <jochen@chromium.org>
3520
3521         [chromium] remove log spew from dumpAllBackForwardLists
3522         https://bugs.webkit.org/show_bug.cgi?id=110108
3523
3524         Reviewed by Nico Weber.
3525
3526         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3527
3528 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3529
3530         [EFL][WK2] Disable failing API tests
3531         https://bugs.webkit.org/show_bug.cgi?id=110081
3532
3533         Reviewed by Kenneth Rohde Christiansen.
3534
3535         Disable DOMWindowExtensionBasic WK2 test on EFL port as it times out.
3536
3537         * TestWebKitAPI/PlatformEfl.cmake:
3538
3539 2013-02-18  Simon Hausmann  <simon.hausmann@digia.com>
3540
3541         [Qt] Disable the build if certain configure checks fail
3542         https://bugs.webkit.org/show_bug.cgi?id=110094
3543
3544         Reviewed by Tor Arne Vestbø.
3545
3546         Allow for the build to be skipped (clear out SUBDIRS) if certain
3547         configure conditions aren't met.
3548
3549         * qmake/mkspecs/features/configure.prf:
3550
3551 2013-02-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3552
3553         [Qt][WK2] Support WK2 API tests
3554         https://bugs.webkit.org/show_bug.cgi?id=109843
3555
3556         Reviewed by Jocelyn Turcotte.
3557
3558         * TestWebKitAPI/DerivedSources.pri: Added.
3559         * TestWebKitAPI/InjectedBundle.pri: Added.
3560         * TestWebKitAPI/PlatformWebView.h:
3561         * TestWebKitAPI/TestWebKitAPI.pri:
3562         * TestWebKitAPI/TestWebKitAPI.pro:
3563         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Added.
3564         * TestWebKitAPI/Tests/WTF/WTF.pro:
3565         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Added.
3566         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp:
3567         (TestWebKitAPI::Util::sleep):
3568         (TestWebKitAPI::Util::createInjectedBundlePath):
3569         (TestWebKitAPI::Util::createURLForResource):
3570         (TestWebKitAPI::Util::isKeyDown):
3571         (Util):
3572         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Added.
3573         (TestWebKitAPI):
3574         (WrapperWindow):
3575         (TestWebKitAPI::WrapperWindow::WrapperWindow):
3576         (TestWebKitAPI::WrapperWindow::handleStatusChanged):
3577         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3578         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3579         (TestWebKitAPI::PlatformWebView::resizeTo):
3580         (TestWebKitAPI::PlatformWebView::page):
3581         (TestWebKitAPI::PlatformWebView::focus):
3582         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3583         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
3584         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3585         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3586         * TestWebKitAPI/qt/main.cpp:
3587         (addQtWebProcessToPath):
3588         (main):
3589
3590 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3591
3592         [EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal C++ API
3593         https://bugs.webkit.org/show_bug.cgi?id=108598
3594
3595         Reviewed by Kenneth Rohde Christiansen.
3596
3597         Update EFL's MiniBrowser to make use of new Ewk_Favicon API.
3598
3599         * MiniBrowser/efl/main.c:
3600         (update_view_favicon):
3601         (on_view_favicon_changed):
3602         (window_create):
3603
3604 2013-02-18  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
3605
3606         Unreviewed. Add myself as a committer.
3607
3608         * Scripts/webkitpy/common/config/committers.py:
3609
3610 2013-02-13  Ilya Tikhonovsky  <loislo@chromium.org>
3611
3612         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
3613         https://bugs.webkit.org/show_bug.cgi?id=109554
3614
3615         In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
3616         can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
3617
3618         Drive by fix: I introduced a client interface for the HeapGraphSerializer.
3619         It helps me to do the tests for the serializer.
3620
3621         Reviewed by Yury Semikhatsky.
3622
3623         It is covered by newly added tests in TestWebKitAPI.
3624
3625         * TestWebKitAPI/TestWebKitAPI.gypi:
3626         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
3627         (TestWebKitAPI):
3628         (HeapGraphReceiver):
3629         (TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
3630         (TestWebKitAPI::HeapGraphReceiver::printGraph):
3631         (TestWebKitAPI::HeapGraphReceiver::dumpNodes):
3632         (TestWebKitAPI::HeapGraphReceiver::dumpEdges):
3633         (TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
3634         (TestWebKitAPI::HeapGraphReceiver::dumpStrings):
3635         (TestWebKitAPI::HeapGraphReceiver::serializer):
3636         (TestWebKitAPI::HeapGraphReceiver::chunkPart):
3637         (TestWebKitAPI::HeapGraphReceiver::dumpPart):
3638         (TestWebKitAPI::HeapGraphReceiver::stringValue):
3639         (TestWebKitAPI::HeapGraphReceiver::intValue):
3640         (TestWebKitAPI::HeapGraphReceiver::nodeToString):
3641         (TestWebKitAPI::HeapGraphReceiver::edgeToString):
3642         (TestWebKitAPI::HeapGraphReceiver::printNode):
3643         (Helper):
3644         (TestWebKitAPI::Helper::Helper):
3645         (TestWebKitAPI::Helper::addNode):
3646         (TestWebKitAPI::Helper::addEdge):
3647         (TestWebKitAPI::Helper::done):
3648         (Object):
3649         (TestWebKitAPI::Helper::Object::Object):
3650         (TestWebKitAPI::TEST):
3651         (Owner):
3652         (TestWebKitAPI::Owner::Owner):
3653         (TestWebKitAPI::Owner::reportMemoryUsage):
3654
3655 2013-02-18  Ryosuke Niwa  <rniwa@webkit.org>
3656
3657         WKR build fix. Always use ascii since irclib/ircbot doesn't support unicode.
3658
3659         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3660         (NewCommitBot.next_work_item):
3661
3662 2013-02-17  Kangil Han  <kangil.han@samsung.com>
3663
3664         Unreviewed. Add myself as a committer.
3665
3666         * Scripts/webkitpy/common/config/committers.py:
3667
3668 2013-02-17  Alan Cutter  <alancutter@chromium.org>
3669
3670         GCE EWS bots are all offline
3671         https://bugs.webkit.org/show_bug.cgi?id=110069
3672
3673         Reviewed by Eric Seidel.
3674
3675         Updated GCE EWS build scripts to use the gcel-10-04-v20130104 image instead of the obsoleted ubuntu-10-04-v20120621.
3676         This changed the ephemeral disk path to /dev/sdb and required /etc/hosts to be chmodded to 644.
3677
3678         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3679         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3680         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
3681         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3682         * EWSTools/build-vm.sh:
3683         * EWSTools/start-queue.sh:
3684
3685 2013-02-18  Eugene Klyuchnikov  <eustas@chromium.org>
3686
3687         Unreviewed, add myself to commiters.py.
3688
3689         * Scripts/webkitpy/common/config/committers.py:
3690
3691 2013-02-17  Dongwoo Joshua Im  <dw.im@samsung.com>
3692
3693         Unreviewed. Add myself as a committer.
3694
3695         * Scripts/webkitpy/common/config/committers.py:
3696
3697 2013-02-17  Roger Fong  <roger_fong@apple.com>
3698
3699         Unreviewed. Fix typo in script.
3700
3701         * EWSTools/start-queue-win.sh:
3702
3703 2013-02-15  Roger Fong  <roger_fong@apple.com>
3704
3705         Pass in bot name as parameter to start-queue-win script.
3706         https://bugs.webkit.org/show_bug.cgi?id=109998.
3707
3708         Reviewed by Darin Adler.
3709
3710         * EWSTools/start-queue-win.sh:
3711
3712 2013-02-18  Byungwoo Lee  <bw80.lee@samsung.com>
3713
3714         Unreviewed. Add myself as a committer.
3715
3716         * Scripts/webkitpy/common/config/committers.py:
3717
3718 2013-02-17  Ryosuke Niwa  <rniwa@webkit.org>
3719
3720         Rename new-commit-bot to WKR to disambiguate it from commit-queue.
3721
3722         Rubber-stamped by Andreas Kling.
3723
3724         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3725         (NewCommitBot.begin_work_queue):
3726
3727 2013-02-16  Glenn Adams  <glenn@skynav.com>
3728
3729         Unreviewed. Add myself as a committer.
3730
3731         * Scripts/webkitpy/common/config/committers.py:
3732
3733 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
3734
3735         new-commit-bot should report the full name of committer and reviewer instead of just nicks
3736         https://bugs.webkit.org/show_bug.cgi?id=110040
3737
3738         Reviewed by Darin Adler.
3739
3740         Have it report names like "Ryosuke Niwa (rniwa)" instead of just "rniwa".
3741
3742         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3743         (NewCommitBot):
3744         (NewCommitBot._summarize_commit_log):
3745         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3746
3747 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
3748
3749         We need a CIA replacement
3750         https://bugs.webkit.org/show_bug.cgi?id=110008
3751
3752         Reviewed by Andreas Kling.
3753
3754         Added new-commit-bot.
3755
3756         * Scripts/webkitpy/tool/bot/queueengine.py:
3757         (QueueEngine.__init__):
3758         (QueueEngine): Made the sleep tiem configurable.
3759         (QueueEngine._sleep_message):
3760         (QueueEngine._sleep):
3761         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3762         (QueueEngineTest.test_sleep_message):
3763         * Scripts/webkitpy/tool/commands/__init__.py:
3764         * Scripts/webkitpy/tool/commands/newcommitbot.py: Added.
3765         (PingPong): Added. Implements the ping pong protocol.
3766         (NewCommitBot):
3767         (NewCommitBot.begin_work_queue):
3768         (NewCommitBot.work_item_log_path):
3769         (NewCommitBot.next_work_item): Update SVN revision and report any new commits made since
3770         the last time we checked the head SVN revision.
3771         (NewCommitBot.process_work_item):
3772         (NewCommitBot._update_checkout): svn up.
3773         (NewCommitBot._new_svn_revisions): Returns a range of new revisions.
3774         (NewCommitBot._summarize_commit_log): Summarize a commit log to be posted on IRC.
3775         (NewCommitBot.handle_unexpected_error):
3776         (NewCommitBot.handle_script_error):
3777         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Added.
3778         (NewCommitBotTest.test_summarize_commit_log_basic): Tests for summarizing non-rollout commits.
3779         (NewCommitBotTest.test_summarize_commit_log_rollout): Tests for summarizing rollouts.
3780         * Scripts/webkitpy/tool/commands/queues.py:
3781         (AbstractQueue.execute):
3782         * Scripts/webkitpy/tool/commands/queuestest.py:
3783         (MockQueueEngine.__init__):
3784         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3785         (SheriffBotTest.test_command_aliases):
3786         * Scripts/webkitpy/tool/main.py:
3787         (WebKitPatch):
3788
3789 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
3790
3791         [chromium] initialize all variables of TestRunner classes
3792         https://bugs.webkit.org/show_bug.cgi?id=110013
3793
3794         Reviewed by Adam Barth.
3795
3796         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3797         (WebTestRunner::TestInterfaces::TestInterfaces):
3798         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3799         (WebTestRunner::TestRunner::TestRunner):
3800
3801 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
3802
3803         [chromium] destroy the TestPlugin when the destroy() method is invoked.
3804         https://bugs.webkit.org/show_bug.cgi?id=110012
3805
3806         Reviewed by Adam Barth.
3807
3808         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3809         (WebTestRunner::TestPlugin::destroy):
3810
3811 2013-02-15  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3812
3813         [WK2] Write a test to simulate crashed WebProcess followed by Window resize
3814         https://bugs.webkit.org/show_bug.cgi?id=109842
3815
3816         Reviewed by Benjamin Poulain.
3817
3818         This new test will kill WebProcess, followed by next resizing the Window. It helps to
3819         identify if the port is testing for WebPageProxy data members state (e.g. DrawingArea, Frames)
3820         before making calls into them.
3821
3822         * TestWebKitAPI/GNUmakefile.am:
3823         * TestWebKitAPI/PlatformEfl.cmake:
3824         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3825         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Added.
3826         (TestWebKitAPI):
3827         (TestWebKitAPI::didFinishLoad):
3828         (TestWebKitAPI::didCrash):
3829         (TestWebKitAPI::TEST):
3830
3831 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3832
3833         Add CString operators for comparison with const char*
3834         https://bugs.webkit.org/show_bug.cgi?id=109947
3835
3836         Reviewed by Darin Adler.
3837
3838         Add tests for WTF::CString's comparison operators.
3839
3840         * TestWebKitAPI/Tests/WTF/CString.cpp:
3841         (TEST):
3842
3843 2013-02-15  Zan Dobersek  <zdobersek@igalia.com>
3844
3845         webkit-patch suggest-reviewers should limit itself to 5 reviewers
3846         https://bugs.webkit.org/show_bug.cgi?id=107528
3847
3848         Reviewed by Eric Seidel.
3849
3850         * Scripts/webkitpy/common/checkout/checkout.py:
3851         (Checkout.suggested_reviewers): Iterate through the sorted commit info list,
3852         scraping reviewers from the commit information and in the end producing a list
3853         of reviewers that's sorted from the most to least recent activity of any reviewer
3854         that has reviewed or authored patches for the changed files.
3855         * Scripts/webkitpy/tool/commands/queries.py:
3856         (SuggestReviewers): Use the SuggestReviewers step instead of reimplementing much of
3857         the same logic.
3858         (SuggestReviewers._prepare_state): Force the reviewer suggestion because the option
3859         defaults to False.
3860         * Scripts/webkitpy/tool/steps/suggestreviewers.py:
3861         (SuggestReviewers.run): Only list the first five suggested reviewers, now printed out
3862         on a single line.  Only ask for CC-ing the suggested reviewers to the bug if the
3863         bug ID is located in the command's state.
3864
3865 2013-02-15  Pablo Flouret  <pablof@motorola.com>
3866
3867         Unreviewed. Add myself as a committer.
3868
3869         * Scripts/webkitpy/common/config/committers.py:
3870
3871 2013-02-15  Roger Fong  <roger_fong@apple.com>
3872
3873         Get Win EWS startup script checked into tree so we can make changes to all the EWS bots more easily.
3874
3875         * EWSTools/start-queue-win.sh: Added.
3876
3877 2013-02-15  Andreas Kling  <akling@apple.com>
3878
3879         Unbreak webkit-patch -- can't have both Committer and Contributor entry with same e-mail address.
3880
3881         * Scripts/webkitpy/common/config/committers.py:
3882
3883 2013-02-15  Joanmarie Diggs  <jdiggs@igalia.com>
3884
3885         Unreviewed. Add myself as a committer.
3886
3887         * Scripts/webkitpy/common/config/committers.py:
3888
3889 2013-02-15  Ryosuke Niwa  <rniwa@webkit.org>
3890
3891         NRWT: ML Debug Test bot is timing out after cleaning up ports
3892         https://bugs.webkit.org/show_bug.cgi?id=109912
3893
3894         Reviewed by Simon Fraser.
3895
3896         Added more debug messgaes to diagnose the issue.
3897
3898         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3899         (Manager.run):
3900
3901 2013-02-15  Claudio Saavedra  <csaavedra@igalia.com>
3902
3903         Unreviewed. Add myself as a committer.
3904
3905         * Scripts/webkitpy/common/config/committers.py:
3906
3907 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3908
3909         Unreviewed. Update Yi Shen, Antonio Gomes and Laszlo Gombos'
3910         emails on their behalf.
3911
3912         * Scripts/webkitpy/common/config/committers.py:
3913
3914 2013-02-15  Andrey Lushnikov  <lushnikov@chromium.org>
3915
3916         Web Inspector: implement smart braces functionality
3917         https://bugs.webkit.org/show_bug.cgi?id=109200
3918
3919         Reviewed by Pavel Feldman.
3920
3921         Fix eventSender.keyDown implementation to correctly process opening
3922         round brace symbol.
3923
3924         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3925         (WebTestRunner):
3926         (WebTestRunner::EventSender::keyDown):
3927
3928 2013-02-15  Jochen Eisinger  <jochen@chromium.org>
3929
3930         Speculative build fix for chromium-win.
3931
3932         Unreviewed build fix.
3933
3934         Add declarations of the copy constructor and assignment operator to
3935         WebTestProxyBase, so VS doesn't try to generate them.
3936
3937         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3938
3939 2013-02-15  Simon Hausmann  <simon.hausmann@digia.com>
3940
3941         [Qt] Port GCController to JSC C API
3942         https://bugs.webkit.org/show_bug.cgi?id=109690
3943
3944         Reviewed by Benjamin Poulain.
3945
3946         Rename TestRunner to TestRunnerQt to avoid conflict when
3947         including TestRunner.h in the future.
3948
3949         Replaced QObject based GCController implementation with JSC C API
3950         based one.
3951
3952         * DumpRenderTree/qt/DumpRenderTree.pro:
3953         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3954         (WebCore::DumpRenderTree::DumpRenderTree):
3955         (WebCore::DumpRenderTree::open):
3956         (WebCore::DumpRenderTree::initJSObjects):
3957         (WebCore::methodNameStringForFailedTest):
3958         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3959         (WebCore::DumpRenderTree::testRunner):
3960         (DumpRenderTree):
3961         * DumpRenderTree/qt/GCControllerQt.cpp:
3962         (GCController::getJSObjectCount):
3963         * DumpRenderTree/qt/GCControllerQt.h: Removed.
3964         * DumpRenderTree/qt/TestRunnerQt.cpp:
3965         (TestRunnerQt::TestRunnerQt):
3966         (TestRunnerQt::reset):
3967         (TestRunnerQt::dumpNotifications):
3968         (TestRunnerQt::processWork):
3969         (TestRunnerQt::maybeDump):
3970         (TestRunnerQt::dumpAsText):
3971         (TestRunnerQt::waitUntilDone):
3972         (TestRunnerQt::setViewModeMediaFeature):
3973         (TestRunnerQt::webHistoryItemCount):
3974         (TestRunnerQt::keepWebHistory):
3975         (TestRunnerQt::notifyDone):
3976         (TestRunnerQt::windowCount):
3977         (TestRunnerQt::grantWebNotificationPermission):
3978         (TestRunnerQt::ignoreLegacyWebNotificationPermissionRequests):
3979         (TestRunnerQt::denyWebNotificationPermission):
3980         (TestRunnerQt::removeAllWebNotificationPermissions):
3981         (TestRunnerQt::simulateWebNotificationClick):
3982         (TestRunnerQt::simulateLegacyWebNotificationClick):
3983         (TestRunnerQt::display):
3984         (TestRunnerQt::displayInvalidatedRegion):
3985         (TestRunnerQt::clearBackForwardList):
3986         (TestRunnerQt::pathToLocalResource):
3987         (TestRunnerQt::dumpEditingCallbacks):
3988         (TestRunnerQt::dumpFrameLoadCallbacks):
3989         (TestRunnerQt::dumpProgressFinishedCallback):
3990         (TestRunnerQt::dumpUserGestureInFrameLoadCallbacks):
3991         (TestRunnerQt::dumpResourceLoadCallbacks):
3992         (TestRunnerQt::dumpResourceResponseMIMETypes):
3993         (TestRunnerQt::dumpWillCacheResponse):
3994         (TestRunnerQt::dumpHistoryCallbacks):
3995         (TestRunnerQt::setWillSendRequestReturnsNullOnRedirect):
3996         (TestRunnerQt::setWillSendRequestReturnsNull):
3997         (TestRunnerQt::setWillSendRequestClearHeader):
3998         (TestRunnerQt::setDeferMainResourceDataLoad):
3999         (TestRunnerQt::queueBackNavigation):
4000         (TestRunnerQt::queueForwardNavigation):
4001         (TestRunnerQt::queueLoad):
4002         (TestRunnerQt::queueLoadHTMLString):
4003         (TestRunnerQt::queueReload):
4004         (TestRunnerQt::queueLoadingScript):
4005         (TestRunnerQt::queueNonLoadingScript):
4006         (TestRunnerQt::provisionalLoad):
4007         (TestRunnerQt::timerEvent):
4008         (TestRunnerQt::encodeHostName):
4009         (TestRunnerQt::decodeHostName):
4010         (TestRunnerQt::closeWebInspector):
4011         (TestRunnerQt::setDeveloperExtrasEnabled):
4012         (TestRunnerQt::setAsynchronousSpellCheckingEnabled):
4013         (TestRunnerQt::showWebInspector):
4014         (TestRunnerQt::evaluateInWebInspector):
4015         (TestRunnerQt::goBack):
4016         (TestRunnerQt::setDefersLoading):
4017         (TestRunnerQt::setAllowUniversalAccessFromFileURLs):
4018         (TestRunnerQt::setAllowFileAccessFromFileURLs):
4019         (TestRunnerQt::setAppCacheMaximumSize):
4020         (TestRunnerQt::setAutofilled):
4021         (TestRunnerQt::setValueForUser):
4022         (TestRunnerQt::setFixedContentsSize):
4023         (TestRunnerQt::setPrivateBrowsingEnabled):
4024         (TestRunnerQt::setSpatialNavigationEnabled):
4025         (TestRunnerQt::setPopupBlockingEnabled):
4026         (TestRunnerQt::setPluginsEnabled):
4027         (TestRunnerQt::setPOSIXLocale):
4028         (TestRunnerQt::setWindowIsKey):
4029         (TestRunnerQt::setMainFrameIsFirstResponder):
4030         (TestRunnerQt::setJavaScriptCanAccessClipboard):
4031         (TestRunnerQt::setXSSAuditorEnabled):
4032         (TestRunnerQt::dispatchPendingLoadRequests):
4033         (TestRunnerQt::clearAllApplicationCaches):
4034         (TestRunnerQt::clearApplicationCacheForOrigin):
4035         (TestRunnerQt::localStorageDiskUsageForOrigin):
4036         (TestRunnerQt::setApplicationCacheOriginQuota):
4037         (TestRunnerQt::applicationCacheDiskUsageForOrigin):
4038         (TestRunnerQt::originsWithApplicationCache):
4039         (TestRunnerQt::setCacheModel):
4040         (TestRunnerQt::setDatabaseQuota):
4041         (TestRunnerQt::clearAllDatabases):
4042         (TestRunnerQt::addOriginAccessWhitelistEntry):
4043         (TestRunnerQt::removeOriginAccessWhitelistEntry):
4044         (TestRunnerQt::setCustomPolicyDelegate):
4045         (TestRunnerQt::waitForPolicyDelegate):
4046         (TestRunnerQt::overridePreference):
4047         (TestRunnerQt::setUserStyleSheetLocation):
4048         (TestRunnerQt::setCaretBrowsingEnabled):
4049         (TestRunnerQt::setAuthorAndUserStylesEnabled):
4050         (TestRunnerQt::setUserStyleSheetEnabled):
4051         (TestRunnerQt::setDomainRelaxationForbiddenForURLScheme):
4052         (TestRunnerQt::callShouldCloseOnWebView):
4053         (TestRunnerQt::setScrollbarPolicy):
4054         (TestRunnerQt::setSmartInsertDeleteEnabled):
4055         (TestRunnerQt::setSelectTrailingWhitespaceEnabled):
4056         (TestRunnerQt::execCommand):
4057         (TestRunnerQt::isCommandEnabled):
4058         (TestRunnerQt::findString):
4059         (TestRunnerQt::markerTextForListItem):
4060         (TestRunnerQt::computedStyleIncludingVisitedInfo):
4061         (TestRunnerQt::elementDoesAutoCompleteForElementWithId):
4062         (TestRunnerQt::authenticateSession):
4063         (TestRunnerQt::setIconDatabaseEnabled):
4064         (TestRunnerQt::setMockDeviceOrientation):
4065         (TestRunnerQt::setGeolocationPermission):
4066         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
4067         (TestRunnerQt::setGeolocationPermissionCommon):
4068         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
4069         (TestRunnerQt::setMockGeolocationPosition):
4070         (TestRunnerQt::addMockSpeechInputResult):
4071         (TestRunnerQt::setMockSpeechInputDumpRect):
4072         (TestRunnerQt::startSpeechInput):
4073         (TestRunnerQt::evaluateScriptInIsolatedWorldAndReturnValue):
4074         (TestRunnerQt::evaluateScriptInIsolatedWorld):
4075         (TestRunnerQt::addUserStyleSheet):
4076         (TestRunnerQt::removeAllVisitedLinks):
4077         (TestRunnerQt::addURLToRedirect):
4078         (TestRunnerQt::originsWithLocalStorage):
4079         (TestRunnerQt::deleteAllLocalStorage):
4080         (TestRunnerQt::deleteLocalStorageForOrigin):
4081         (TestRunnerQt::observeStorageTrackerNotifications):
4082         (TestRunnerQt::syncLocalStorage):
4083         (TestRunnerQt::resetPageVisibility):
4084         (TestRunnerQt::setPageVisibility):
4085         (TestRunnerQt::setAutomaticLinkDetectionEnabled):
4086         (TestRunnerQt::setTextDirection):
4087         (TestRunnerQt::setAlwaysAcceptCookies):
4088         (TestRunnerQt::setAlwaysBlockCookies):
4089         (TestRunnerQt::setAudioData):
4090         * DumpRenderTree/qt/TestRunnerQt.h:
4091         (TestRunnerQt):
4092
4093 2013-02-14  Karen Grunberg  <kareng@chromium.org>
4094
4095         adding myself as a committer
4096
4097         * Scripts/webkitpy/common/config/committers.py:
4098
4099 2013-02-14  Glenn Adams  <glenn@skynav.com>
4100
4101         new-run-webkit-tests needs a shared TestExpectations between all WebKit ports
4102         https://bugs.webkit.org/show_bug.cgi?id=37565
4103
4104         Introduce generic TestExpectations file that applies as a fallback for all ports, the location of which
4105         is LayoutTests/TestExpectations.
4106
4107         Reviewed by Dirk Pranke.
4108
4109         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
4110         (FakePort.path_to_generic_test_expectations_file):
4111         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4112         (TestExpectations.__init__):
4113         * Scripts/webkitpy/layout_tests/port/base.py:
4114         (Port.path_to_generic_test_expectations_file):
4115         (Port):
4116         (Port._port_specific_expectations_files):
4117         (Port.expectations_files):
4118         * Scripts/webkitpy/layout_tests/port/chromium.py:
4119         (ChromiumPort._port_specific_expectations_files):
4120         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4121         (ChromiumAndroidPort._port_specific_expectations_files):
4122         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
4123         (ChromiumPortTestCase.test_expectations_files):
4124         * Scripts/webkitpy/layout_tests/port/efl.py:
4125         (EflPort._port_specific_expectations_files):
4126         * Scripts/webkitpy/layout_tests/port/gtk.py:
4127         (GtkPort._port_specific_expectations_files):
4128         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
4129         (GtkPortTest.test_expectations_files):
4130         * Scripts/webkitpy/layout_tests/port/mac.py:
4131         (MacPort._port_specific_expectations_files):
4132         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4133         (PortTestCase.test_expectations_ordering):
4134         (test_expectations_files):
4135         * Scripts/webkitpy/layout_tests/port/qt.py:
4136         (QtPort._port_specific_expectations_files):
4137         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4138         (QtPortTest.test_expectations_files):
4139         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4140         (WinPortTest.test_expectations_files):
4141         * Scripts/webkitpy/tool/commands/queries_unittest.py:
4142         (PrintExpectationsTest.test_paths):
4143         * Scripts/webkitpy/tool/commands/rebaseline.py:
4144         (RebaselineTest._update_expectations_file):
4145
4146 2013-02-14  Jochen Eisinger  <jochen@chromium.org>
4147
4148         [chromium] move pixel generation logic to TestRunner library
4149         https://bugs.webkit.org/show_bug.cgi?id=109686
4150
4151         Reviewed by Stephen White.
4152
4153         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4154         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
4155         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
4156         (WebTestRunner):
4157         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4158         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
4159         (WebTestRunner):
4160         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4161         (WebTestRunner::TestInterfaces::~TestInterfaces):
4162         (WebTestRunner::TestInterfaces::setWebView):
4163         (WebTestRunner::TestInterfaces::proxy):
4164         (WebTestRunner):
4165         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
4166         (WebTestRunner):
4167         (TestInterfaces):
4168         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4169         (WebTestRunner::TestRunner::setWebView):
4170         (WebTestRunner):
4171         (WebTestRunner::TestRunner::setBackingScaleFactor):
4172         (WebTestRunner::TestRunner::display):
4173         (WebTestRunner::TestRunner::displayInvalidatedRegion):
4174         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4175         (WebTestRunner):
4176         (TestRunner):
4177         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
4178         (WebTestRunner::WebTestInterfaces::setWebView):
4179         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4180         (WebTestRunner::WebTestProxyBase::reset):
4181         (WebTestRunner::WebTestProxyBase::capturePixels):
4182         (WebTestRunner):
4183         (WebTestRunner::WebTestProxyBase::paintRect):
4184         (WebTestRunner::WebTestProxyBase::paintInvalidatedRegion):
4185         (WebTestRunner::WebTestProxyBase::paintPagesWithBoundaries):
4186         (WebTestRunner::WebTestProxyBase::canvas):
4187         (WebTestRunner::WebTestProxyBase::displayRepaintMask):
4188         (WebTestRunner::WebTestProxyBase::display):
4189         (WebTestRunner::WebTestProxyBase::displayInvalidatedRegion):
4190         (WebTestRunner::WebTestProxyBase::discardBackingStore):
4191         (WebTestRunner::WebTestProxyBase::setWindowRect):
4192         (WebTestRunner::WebTestProxyBase::userMediaClient):
4193         * DumpRenderTree/chromium/TestShell.cpp:
4194         (TestShell::createMainWindow):
4195         (TestShell::~TestShell):
4196         (TestShell::showDevTools):
4197         (TestShell::closeDevTools):
4198         (TestShell::dump):
4199         * DumpRenderTree/chromium/WebViewHost.cpp:
4200         (WebViewHost::setWindowRect):
4201         (WebViewHost::setDeviceScaleFactor):
4202         (WebViewHost::reset):
4203         * DumpRenderTree/chromium/WebViewHost.h:
4204         (WebViewHost):
4205
4206 2013-02-14  Tony Chang  <tony@chromium.org>
4207
4208         Unreviewed, set svn:eol-style native for .sln, .vcproj, and .vsprops files.
4209         https://bugs.webkit.org/show_bug.cgi?id=96934
4210
4211         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
4212         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
4213         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added property svn:eol-style.
4214         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added property svn:eol-style.
4215         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added property svn:eol-style.
4216         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
4217         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added property svn:eol-style.
4218         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added property svn:eol-style.
4219         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
4220         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added property svn:eol-style.
4221         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added property svn:eol-style.
4222         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added property svn:eol-style.
4223         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
4224         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added property svn:eol-style.
4225         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added property svn:eol-style.
4226         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
4227         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added property svn:eol-style.
4228         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
4229         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added property svn:eol-style.
4230         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added property svn:eol-style.
4231         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added property svn:eol-style.
4232         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
4233         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added property svn:eol-style.
4234         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added property svn:eol-style.
4235         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
4236         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added property svn:eol-style.
4237         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added property svn:eol-style.
4238         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added property svn:eol-style.
4239         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added property svn:eol-style.
4240         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added property svn:eol-style.
4241         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added property svn:eol-style.
4242         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added property svn:eol-style.
4243         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added property svn:eol-style.
4244         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
4245         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added property svn:eol-style.
4246         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added property svn:eol-style.
4247         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added property svn:eol-style.
4248         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
4249         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added property svn:eol-style.
4250         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added property svn:eol-style.
4251         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
4252         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added property svn:eol-style.
4253         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added property svn:eol-style.
4254         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added property svn:eol-style.
4255         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
4256         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added property svn:eol-style.
4257         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added property svn:eol-style.
4258         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
4259
4260 2013-02-14  Tony Chang  <tony@chromium.org>
4261
4262         Unreviewed, set svn:eol-style CRLF for .sln files.
4263
4264         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
4265         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
4266         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
4267         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
4268
4269 2013-02-14  Zan Dobersek  <zdobersek@igalia.com>
4270
4271         [GTK] Errors when building WebKit2 with Clang
4272         https://bugs.webkit.org/show_bug.cgi?id=109603
4273
4274         Reviewed by Alexey Proskuryakov.
4275
4276         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4277         (WTR::PlatformWebView::resizeTo): Cast the width and height parameters to the integer
4278         type when constructing the GtkAllocation.
4279
4280         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
4281         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
4282         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
4283         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
4284
4285 2013-02-14  Roger Fong  <roger_fong@apple.com>
4286
4287         Add eol-style=native to solution files. Add a new solution file.
4288
4289         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added property svn:eol-style.
4290         * TestWebKitAPI/TestWebKitAPI.vcxproj: Added property svn:eol-style. Modified property svn:ignore.