Unreviewed, rolling out r244802.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-30  Chris Dumez  <cdumez@apple.com>
2
3         Unreviewed, rolling out r244802.
4
5         Caused an API test failure
6
7         Reverted changeset:
8
9         "Regression(PSON) URL scheme handlers can no longer respond
10         asynchronously"
11         https://bugs.webkit.org/show_bug.cgi?id=197426
12         https://trac.webkit.org/changeset/244802
13
14 2019-04-30  Chris Dumez  <cdumez@apple.com>
15
16         Regression(PSON) URL scheme handlers can no longer respond asynchronously
17         https://bugs.webkit.org/show_bug.cgi?id=197426
18         <rdar://problem/50256169>
19
20         Reviewed by Brady Eidson.
21
22         Add API test coverage.
23
24         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
25         (-[PSONScheme setShouldRespondAsynchronously:]):
26         (-[PSONScheme webView:startURLSchemeTask:]):
27         (-[PSONScheme webView:stopURLSchemeTask:]):
28
29 2019-04-30  Chris Dumez  <cdumez@apple.com>
30
31         Only use a related page's process if that page has not been closed yet
32         https://bugs.webkit.org/show_bug.cgi?id=197393
33         <rdar://problem/50302423>
34
35         Reviewed by Tim Horton.
36
37         Add API test coverage.
38
39         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
40
41 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
42
43         [ews-build] Enable Bindings tests queue on new EWS
44         https://bugs.webkit.org/show_bug.cgi?id=197424
45
46         Reviewed by Lucas Forschler.
47
48         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
49         (StatusBubble):
50         * BuildSlaveSupport/ews-build/config.json:
51
52 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
53
54         [ews-build] Configure ews151 for running various tests
55         https://bugs.webkit.org/show_bug.cgi?id=197419
56
57         Reviewed by Lucas Forschler.
58
59         * BuildSlaveSupport/ews-build/config.json:
60
61 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
62
63         [ews-build] Parse and display bindings test failures
64         https://bugs.webkit.org/show_bug.cgi?id=197423
65
66         Reviewed by Lucas Forschler.
67
68         * BuildSlaveSupport/ews-build/steps.py:
69         (RunBindingsTests.__init__): Set timeout of 5 minutes.
70         (RunBindingsTests.start): Initialize log_observer for json output.
71         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
72         (RunBindingsTests._addToLog): Method to add message to log.
73         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
74
75 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
76
77         Unreviewed. Add myself as a committer.
78
79         * Scripts/webkitpy/common/config/contributors.json:
80
81 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
82
83         [ews-build] Enable webkitpy queue on new EWS
84         https://bugs.webkit.org/show_bug.cgi?id=197396
85
86         Reviewed by Lucas Forschler.
87
88         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
89         (StatusBubble):
90         * BuildSlaveSupport/ews-build/config.json:
91
92 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
93
94         [ews-build] Parse and display webkitpy failures
95         https://bugs.webkit.org/show_bug.cgi?id=197395
96
97         Reviewed by Lucas Forschler.
98
99         * BuildSlaveSupport/ews-build/steps.py:
100         (RunWebKitPyTests.start): Initialize log_observer for json output.
101         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
102         (RunWebKitPyTests._addToLog): Method to add message to log.
103         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
104
105 2019-04-29  Alex Christensen  <achristensen@webkit.org>
106
107         <rdar://problem/50299396> Fix internal High Sierra build
108         https://bugs.webkit.org/show_bug.cgi?id=197388
109
110         * DumpRenderTree/mac/Configurations/Base.xcconfig:
111         * MiniBrowser/Configurations/Base.xcconfig:
112         * MobileMiniBrowser/Configurations/Base.xcconfig:
113         * TestWebKitAPI/Configurations/Base.xcconfig:
114         * WebKitTestRunner/Configurations/Base.xcconfig:
115
116 2019-04-29  Youenn Fablet  <youenn@apple.com>
117
118         Remove spurious GVA printf logging
119         https://bugs.webkit.org/show_bug.cgi?id=197368
120         <rdar://problem/35975256>
121
122         Reviewed by Alexey Proskuryakov.
123
124         * Scripts/webkitpy/port/mac.py:
125         (MacPort.logging_patterns_to_strip):
126
127 2019-04-29  Youenn Fablet  <youenn@apple.com>
128
129         getDisplayMedia should be called on user gesture
130         https://bugs.webkit.org/show_bug.cgi?id=197356
131         <rdar://problem/50296074>
132
133         Reviewed by Eric Carlson.
134
135         Update test configuration to inject internals
136         so that we can use it to simulate a user click to call getDisplayMedia.
137
138         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
139         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
140         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
141
142 2019-04-26  Stephanie Lewis  <slewis@apple.com>
143
144         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
145         https://bugs.webkit.org/show_bug.cgi?id=197339
146
147         Reviewed by Dewei Zhu.
148
149         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
150         test run for setup steps that are too expensive to do every iteration.
151
152         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
153         (BenchmarkRunner._run_benchmark):
154         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
155         (BrowserDriver):
156         (BrowserDriver.prepare_initial_env):
157         (BrowserDriver.restore_env_after_all_testing):
158         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
159         (LinuxBrowserDriver.prepare_initial_env):
160         (LinuxBrowserDriver.restore_env_after_all_testing):
161         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
162         (OSXBrowserDriver.prepare_initial_env):
163         (OSXBrowserDriver.restore_env_after_all_testing):
164
165 2019-04-28  Andy Estes  <aestes@apple.com>
166
167         Fix the watchOS engineering build.
168
169         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
170         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
171
172 2019-04-27  Chris Dumez  <cdumez@apple.com>
173
174         [WKTR] Move test timeout handling to the UIProcess
175         https://bugs.webkit.org/show_bug.cgi?id=197333
176
177         Reviewed by Darin Adler.
178
179         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
180         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
181         every WebContent process in the case of swapping.
182
183         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
184         would lead to crashes when firing the timer.
185
186         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
187         (WTR::InjectedBundle::didReceiveMessageToPage):
188         (WTR::InjectedBundle::done):
189         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
190         (WTR::InjectedBundle::shouldDumpPixels const):
191         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
192         (WTR::TestRunner::TestRunner):
193         (WTR::TestRunner::waitUntilDone):
194         (WTR::TestRunner::setWaitUntilDone):
195         * WebKitTestRunner/InjectedBundle/TestRunner.h:
196         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
197         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
198         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
199         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
200         * WebKitTestRunner/TestInvocation.cpp:
201         (WTR::TestInvocation::TestInvocation):
202         (WTR::TestInvocation::createTestSettingsDictionary):
203         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
204         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
205         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
206         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
207         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
208         (WTR::TestInvocation::setWaitUntilDone):
209         (WTR::TestInvocation::done):
210         * WebKitTestRunner/TestInvocation.h:
211
212 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
213
214         [JSC] linkPolymorphicCall now does GC
215         https://bugs.webkit.org/show_bug.cgi?id=197306
216
217         Reviewed by Saam Barati.
218
219         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
220         To add this test, we add `runWithoutBaseOption`.
221
222         * Scripts/run-jsc-stress-tests:
223
224 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
225
226         Update inactive reviewers' status to 'contributor'.
227
228         Accidentally skipped one at first.
229
230         * Scripts/webkitpy/common/config/contributors.json:
231
232 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
233
234         Update inactive reviewers' status to 'contributor'.
235
236         * Scripts/webkitpy/common/config/contributors.json: The change.
237
238         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
239         * Scripts/webkitpy/common/checkout/checkout_mock.py:
240         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
241         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
242         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
243         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
244         * Scripts/webkitpy/tool/commands/queries_unittest.py:
245         * Scripts/webkitpy/tool/commands/upload_unittest.py:
246         Sadly, regression tests operate on a crazy mix of mock and live data for
247         contributors.json. It would be a substantial project to mock all code paths,
248         so changing the tests instead.
249
250 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
251
252         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
253         https://bugs.webkit.org/show_bug.cgi?id=197171
254         <rdar://problem/47454979>
255
256         Reviewed by Youenn Fablet.
257
258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
259         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
260         (TestWebKitAPI::TEST):
261
262 2019-04-26  David Kilzer  <ddkilzer@apple.com>
263
264         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
265         <https://webkit.org/b/197314>
266         <rdar://problem/50245252>
267
268         Reviewed by Simon Fraser.
269
270         * WebKitTestRunner/UIScriptControllerCocoa.mm:
271         (WTR::UIScriptController::lastUndoLabel const):
272         (WTR::UIScriptController::firstRedoLabel const):
273         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
274
275         * WebKitTestRunner/ios/HIDEventGenerator.mm:
276         (-[HIDEventGenerator sendEventStream:completionBlock:]):
277         - Call -autorelease to fix leak of NSDictionary.
278
279         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
280         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
281         (WTR::UIScriptController::selectFormPopoverTitle const):
282         (WTR::UIScriptController::textContentType const):
283         (WTR::UIScriptController::formInputLabel const):
284         (WTR::UIScriptController::scrollingTreeAsText const):
285         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
286
287 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
288
289         webkitpy: Running a single test will always use the default device
290         https://bugs.webkit.org/show_bug.cgi?id=195472
291         <rdar://problem/48724825>
292
293         Reviewed by Lucas Forschler.
294
295         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
296         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
297         requested will be run regardless of what shard they are in.
298
299         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
300         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
301         * Scripts/webkitpy/layout_tests/controllers/manager.py:
302         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
303         on the default device type.
304         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
305         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
306         (RunTest.test_run_part): Ditto.
307
308 2019-04-26  Alex Christensen  <achristensen@webkit.org>
309
310         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
311         https://bugs.webkit.org/show_bug.cgi?id=197165
312
313         Reviewed by Youenn Fablet.
314
315         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
316
317 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
318
319         Replace iOS build queue hardware
320         https://bugs.webkit.org/show_bug.cgi?id=197312
321
322         Reviewed by Aakash Jain.
323
324         * BuildSlaveSupport/build.webkit.org-config/config.json:
325         Use newer hardware that supports macOS Mojave.
326
327 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
328
329         check-webkit-style complains the first block in while loop.
330         https://bugs.webkit.org/show_bug.cgi?id=197307
331
332         The style checker shouldn't complain about an open brace on
333         its own line if the last non-whitespace character on the previous
334         non-blank line is another open brace, because it's likely to
335         indicate the begining of a nested code block.
336
337         Reviewed by Alex Christensen.
338
339         * Scripts/webkitpy/style/checkers/cpp.py:
340         (check_braces):
341         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
342         (WebKitStyleTest.test_braces):
343
344 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
345
346         Stop IDB transactions to release locked database files when network process is ready to suspend
347         https://bugs.webkit.org/show_bug.cgi?id=196372
348         <rdar://problem/48930116>
349
350         Reviewed by Brady Eidson.
351
352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
353         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
354         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
355         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
356         (runTestAndCheckResult):
357         (keepNetworkProcessActive):
358         (TEST):
359
360 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
361
362         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
363         https://bugs.webkit.org/show_bug.cgi?id=188357
364         <rdar://problem/42986633>
365
366         Reviewed by Dean Jackson.
367
368         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
369         tests would fall into low memory mode and have different behavior.
370         
371         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
372         to Internals, so it's shared by DRT and WTR.
373         
374         We no longer need the WK2 C SPI glue.
375
376         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
377         (WTR::InjectedBundlePage::prepare):
378
379 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
380
381         webkitpy: Including skipped tests in the final count
382         https://bugs.webkit.org/show_bug.cgi?id=197298
383         <rdar://problem/49705424>
384
385         Reviewed by Lucas Forschler.
386
387         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
388         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
389
390 2019-04-25  Timothy Hatcher  <timothy@apple.com>
391
392         Disable date and time inputs on iOSMac.
393         https://bugs.webkit.org/show_bug.cgi?id=197287
394         rdar://problem/46794376
395
396         Reviewed by Wenson Hsieh.
397
398         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
399
400 2019-04-25  Alex Christensen  <achristensen@webkit.org>
401
402         Fix test-webkitpy after r244653
403         https://bugs.webkit.org/show_bug.cgi?id=197131
404
405         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
406         Also use C++17.
407
408 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
409
410         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
411         https://bugs.webkit.org/show_bug.cgi?id=196991
412         <rdar://problem/45507423>
413
414         Reviewed by Alex Christensen.
415
416         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
417         (-[NavigationTestDelegate init]):
418         (-[NavigationTestDelegate waitForDidFinishNavigation]):
419         (-[NavigationTestDelegate webView:didFinishNavigation:]):
420         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
421         (TestWebKitAPI::TEST):
422         (TEST): Deleted.
423
424 2019-04-25  Alex Christensen  <achristensen@webkit.org>
425
426         Revert some code accidentally committed with r244653
427         https://bugs.webkit.org/show_bug.cgi?id=197131
428
429         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
430         (TestWebKitAPI::TEST):
431
432 2019-04-25  Alex Christensen  <achristensen@webkit.org>
433
434         Start using C++17
435         https://bugs.webkit.org/show_bug.cgi?id=197131
436
437         Reviewed by Darin Adler.
438
439         * DumpRenderTree/mac/Configurations/Base.xcconfig:
440         * MiniBrowser/Configurations/Base.xcconfig:
441         * MobileMiniBrowser/Configurations/Base.xcconfig:
442         * TestWebKitAPI/Configurations/Base.xcconfig:
443         * WebKitTestRunner/Configurations/Base.xcconfig:
444
445 2019-04-25  Commit Queue  <commit-queue@webkit.org>
446
447         Unreviewed, rolling out r244627.
448         https://bugs.webkit.org/show_bug.cgi?id=197282
449
450         Causing internal build failures (Requested by ShawnRoberts on
451         #webkit).
452
453         Reverted changeset:
454
455         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
456         https://bugs.webkit.org/show_bug.cgi?id=197171
457         https://trac.webkit.org/changeset/244627
458
459 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
460
461         [GTK] Hardcoded text color in input fields
462         https://bugs.webkit.org/show_bug.cgi?id=126907
463
464         Reviewed by Michael Catanzaro.
465
466         Add dark-mode command line option to MiniBrowser.
467
468         * MiniBrowser/gtk/main.c:
469         (main):
470
471 2019-04-24  Zalan Bujtas  <zalan@apple.com>
472
473         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
474         https://bugs.webkit.org/show_bug.cgi?id=196948
475         <rdar://problem/49927131>
476
477         Reviewed by Tim Horton.
478
479         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
480         (TEST):
481         The expected order of incoming events is
482         1. didInvalidateIntrinsicContentSize
483         2. didFirstLayout
484         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
485         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
486         (and remember, all we care about is ordering).
487
488 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
489
490         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
491         https://bugs.webkit.org/show_bug.cgi?id=197171
492         <rdar://problem/47454979>
493
494         Reviewed by Youenn Fablet.
495
496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
497         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
498         (TestWebKitAPI::TEST):
499
500 2019-04-24  Brady Eidson  <beidson@apple.com>
501
502         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
503         https://bugs.webkit.org/show_bug.cgi?id=191362
504
505         Reviewed by Alex Christensen.
506
507         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
508           from an XHR to a custom protocol.
509
510 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
511
512         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
513         https://bugs.webkit.org/show_bug.cgi?id=197273
514
515         Reviewed by Dean Jackson.
516
517         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
518         so that WebCoreTestSupport::resetInternalsObject() is always run.
519
520         * DumpRenderTree/mac/DumpRenderTree.mm:
521         (resetWebViewToConsistentStateBeforeTesting):
522         (runTest):
523
524 2019-04-24  John Wilander  <wilander@apple.com>
525
526         Age out unconverted Ad Click Attributions after one week.
527         https://bugs.webkit.org/show_bug.cgi?id=197238
528         <rdar://problem/50177349>
529
530         Reviewed by Chris Dumez.
531
532         This patch adds infrastructure to allow tests to expire all unconverted
533         attributions early.
534
535         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
536         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
537         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
538         * WebKitTestRunner/InjectedBundle/TestRunner.h:
539         * WebKitTestRunner/TestController.cpp:
540         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
541         * WebKitTestRunner/TestController.h:
542         * WebKitTestRunner/TestInvocation.cpp:
543         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
544
545 2019-04-24  Chris Dumez  <cdumez@apple.com>
546
547         Fix flaky crashes in a couple of PSON API tests
548         https://bugs.webkit.org/show_bug.cgi?id=197239
549
550         Reviewed by Tim Horton.
551
552         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
553
554         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
555
556 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
557
558         Make it possible to control the renderTreeAsText output by setting options on testRunner
559         https://bugs.webkit.org/show_bug.cgi?id=197133
560
561         Reviewed by Sam Weinig.
562
563         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
564         that make sense in testing (those that don't dump unstable data like addresses), and plumb
565         these flags through the various framework layers.
566
567         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
568
569         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
570         and hand-code DumpRenderTree bindings.
571
572         Some cleanup of the TestRunners, using member initializers.
573
574         * DumpRenderTree/TestRunner.cpp:
575         (TestRunner::TestRunner):
576         (setRenderTreeDumpOptionsCallback):
577         (TestRunner::staticFunctions):
578         (TestRunner::setRenderTreeDumpOptions):
579         * DumpRenderTree/TestRunner.h:
580         (TestRunner::renderTreeDumpOptions const):
581         * DumpRenderTree/mac/DumpRenderTree.mm:
582         (dump):
583         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
584         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
585         (WTR::InjectedBundlePage::dump):
586         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
587         (WTR::TestRunner::TestRunner):
588         (WTR::TestRunner::setRenderTreeDumpOptions):
589         * WebKitTestRunner/InjectedBundle/TestRunner.h:
590         (WTR::TestRunner::renderTreeDumpOptions const):
591
592 2019-04-24  Alex Christensen  <achristensen@webkit.org>
593
594         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
595         https://bugs.webkit.org/show_bug.cgi?id=197078
596         <rdar://problem/49564348>
597
598         Reviewed by Geoff Garen.
599
600         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
601         (TEST_F):
602         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
603         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
604         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
605
606 2019-04-24  Alex Christensen  <achristensen@webkit.org>
607
608         Add unit test for r239322
609         https://bugs.webkit.org/show_bug.cgi?id=197236
610
611         Reviewed by Chris Dumez.
612
613         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
614         May as well add the test infrastructure which was needed before and will be needed in the future.
615
616         * TestWebKitAPI/TCPServer.cpp:
617         (TestWebKitAPI::TCPServer::TCPServer):
618         * TestWebKitAPI/TCPServer.h:
619         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
620         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
621         (TestWebKitAPI::TEST):
622         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
623         (TestWebKitAPI::downloadAtRate):
624         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
625         (TEST):
626         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
627         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
628         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
629         (TestWebKitAPI::TEST):
630         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
631         (TEST):
632
633 2019-04-24  Chris Dumez  <cdumez@apple.com>
634
635         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
636         https://bugs.webkit.org/show_bug.cgi?id=197214
637         <rdar://problem/49237544>
638
639         Reviewed by Alex Christensen.
640
641         Extend API test coverage.
642
643         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
644         (TEST):
645
646 2019-04-24  Philippe Normand  <pnormand@igalia.com>
647
648         [Build][GStreamer] Update to 1.16.0
649         https://bugs.webkit.org/show_bug.cgi?id=197157
650
651         Reviewed by Xabier Rodriguez-Calvar.
652
653         The upstreamed patches were removed and a new one was added for a
654         regression detected in the scaletempo GStreamer element. The GNOME
655         Flatpak was migrated to 3.32 and I switched a few modules to Meson
656         on the way, as it is the preferred build system now in GStreamer
657         1.16.
658
659         * flatpak/files/httpd-autogen.sh:
660         * flatpak/flatpakutils.py:
661         (FlatpakPackage.install):
662         (WebkitFlatpak.run_in_sandbox):
663         * flatpak/org.webkit.CommonModules.yaml:
664         * flatpak/org.webkit.WebKit.yaml:
665         * gstreamer/jhbuild.modules:
666         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
667         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
668         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
669         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
670         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
671         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
672         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
673         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
674         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
675         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
676         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
677         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
678         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
679         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
680         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
681         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
682         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
683         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
684         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
685         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
686         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
687         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
688
689 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
690
691         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
692         https://bugs.webkit.org/show_bug.cgi?id=197156
693
694         Reviewed by Michael Catanzaro.
695
696         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
697         support was added.
698
699         * MiniBrowser/gtk/BrowserTab.c:
700         (browser_tab_set_background_color): Set the passed in color as web view background color.
701         * MiniBrowser/gtk/BrowserTab.h:
702         * MiniBrowser/gtk/BrowserWindow.c:
703         (browser_window_init): Initialize backgroundColor.
704         (browser_window_append_view): Call browser_tab_set_background_color().
705         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
706         are added.
707         * MiniBrowser/gtk/main.c:
708         (main): Call browser_window_set_background_color() before creating the tabs.
709
710 2019-04-23  John Wilander  <wilander@apple.com>
711
712         Move Ad Click Attribution from internal feature to experimental feature
713         https://bugs.webkit.org/show_bug.cgi?id=197218
714         <rdar://problem/47651691>
715
716         Reviewed by Brent Fulgham.
717
718         * DumpRenderTree/TestOptions.cpp:
719         (TestOptions::TestOptions):
720
721 2019-04-23  Andy Estes  <aestes@apple.com>
722
723         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
724         https://bugs.webkit.org/show_bug.cgi?id=196749
725         <rdar://problem/35773454>
726
727         Reviewed by Daniel Bates.
728
729         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
730
731         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
732         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
733         (-[QuickLookDelegate webView:didFinishNavigation:]):
734         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
735         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
736         (runTest):
737         (runTestDecideBeforeLoading):
738         (runTestDecideAfterLoading):
739         (TEST):
740
741 2019-04-23  John Wilander  <wilander@apple.com>
742
743         Remove Ad Click Attribution data when removing website data
744         https://bugs.webkit.org/show_bug.cgi?id=197215
745         <rdar://problem/47668988>
746
747         Reviewed by Chris Dumez.
748
749         This patch adds test infrastructure to delete Ad Click Attribution data
750         through WebsiteDataStore::removeData().
751
752         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
753         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
754         (WTR::TestRunner::clearAdClickAttribution):
755         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
756         * WebKitTestRunner/InjectedBundle/TestRunner.h:
757         * WebKitTestRunner/TestController.cpp:
758         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
759         * WebKitTestRunner/TestController.h:
760         * WebKitTestRunner/TestInvocation.cpp:
761         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
762
763 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
764
765         webkitpy: Kill unresponsive worker processes
766         https://bugs.webkit.org/show_bug.cgi?id=197205
767         <rdar://problem/50104388>
768
769         Reviewed by Lucas Forschler.
770
771         * Scripts/webkitpy/common/message_pool.py:
772         (_MessagePool.__init__): Add close timeout.
773         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
774
775 2019-04-23  Alex Christensen  <achristensen@webkit.org>
776
777         Add unit tests for WKWebView.serverTrust
778         https://bugs.webkit.org/show_bug.cgi?id=197202
779
780         Reviewed by Youenn Fablet
781
782         * TestWebKitAPI/TCPServer.cpp:
783         (TestWebKitAPI::deleter<BIO>::operator()):
784         (TestWebKitAPI::deleter<SSL>::operator()):
785         (TestWebKitAPI::deleter<X509>::operator()):
786         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
787         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
788         (TestWebKitAPI::TCPServer::TCPServer):
789         (TestWebKitAPI::TCPServer::listenForConnections):
790         * TestWebKitAPI/TCPServer.h:
791         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
792         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
793         (TestWebKitAPI::TEST):
794         (verifyCertificateAndPublicKey):
795         (-[ServerTrustDelegate webView:didFinishNavigation:]):
796         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
797         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
798         (TestWebKitAPI::downloadAtRate):
799         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
800         (TEST):
801         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
802         (TEST):
803
804 2019-04-23  Commit Queue  <commit-queue@webkit.org>
805
806         Unreviewed, rolling out r244556.
807         https://bugs.webkit.org/show_bug.cgi?id=197212
808
809         Causing build failures on multiple builders (Requested by
810         ShawnRoberts on #webkit).
811
812         Reverted changeset:
813
814         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
815         https://bugs.webkit.org/show_bug.cgi?id=197171
816         https://trac.webkit.org/changeset/244556
817
818 2019-04-23  Alex Christensen  <achristensen@webkit.org>
819
820         Fix iOS build.
821         https://bugs.webkit.org/show_bug.cgi?id=195537
822
823         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
824         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
825         AdoptWK constructor is private now.  Use adoptWK instead.
826
827 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
828
829         Accessibility text search and selection API enhancements.
830         https://bugs.webkit.org/show_bug.cgi?id=197095
831         <rdar://problem/48181791>
832
833         Reviewed by Chris Fleizach.
834
835         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
836
837         * DumpRenderTree/AccessibilityTextMarker.h:
838         * DumpRenderTree/AccessibilityUIElement.cpp:
839         (searchTextWithCriteriaCallback):
840         (AccessibilityUIElement::getJSClass):
841         * DumpRenderTree/AccessibilityUIElement.h:
842         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
843         (convertVectorToObjectArray):
844         (convertNSArrayToVector):
845         (searchTextParameterizedAttributeForCriteria):
846         (AccessibilityUIElement::getLinkedUIElements):
847         (AccessibilityUIElement::getDocumentLinks):
848         (AccessibilityUIElement::getChildren):
849         (AccessibilityUIElement::getChildrenWithRange):
850         (AccessibilityUIElement::rowHeaders const):
851         (AccessibilityUIElement::columnHeaders const):
852         (AccessibilityUIElement::uiElementArrayAttributeValue const):
853         (AccessibilityUIElement::searchTextWithCriteria):
854         (AccessibilityUIElement::attributesOfColumnHeaders):
855         (AccessibilityUIElement::attributesOfRowHeaders):
856         (AccessibilityUIElement::attributesOfColumns):
857         (AccessibilityUIElement::attributesOfRows):
858         (AccessibilityUIElement::attributesOfVisibleCells):
859         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
860         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
861         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
862         (WTR::convertVectorToObjectArray):
863         (WTR::convertNSArrayToVector):
864         (WTR::searchTextParameterizedAttributeForCriteria):
865         (WTR::AccessibilityUIElement::getLinkedUIElements):
866         (WTR::AccessibilityUIElement::getDocumentLinks):
867         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
868         (WTR::AccessibilityUIElement::getChildren):
869         (WTR::AccessibilityUIElement::getChildrenWithRange):
870         (WTR::AccessibilityUIElement::rowHeaders const):
871         (WTR::AccessibilityUIElement::columnHeaders const):
872         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
873         (WTR::AccessibilityUIElement::searchTextWithCriteria):
874         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
875         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
876         (WTR::AccessibilityUIElement::attributesOfColumns):
877         (WTR::AccessibilityUIElement::attributesOfRows):
878         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
879         (WTR::convertElementsToObjectArray): Deleted.
880
881 2019-04-23  Guy Lewin  <guy@lewin.co.il>
882
883         Multiple File Input Icon Set Regardless of File List
884         https://bugs.webkit.org/show_bug.cgi?id=195537
885
886         Reviewed by Alexey Proskuryakov.
887
888         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
889         display string in iOS file inputs
890
891         * DumpRenderTree/TestRunner.cpp:
892         (SetOpenPanelFilesMediaIconCallback):
893         (TestRunner::staticFunctions):
894         (TestRunner::setOpenPanelFilesMediaIcon):
895         * DumpRenderTree/TestRunner.h:
896         (TestRunner::openPanelFilesMediaIcon const):
897         * DumpRenderTree/mac/UIDelegate.mm:
898         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
899         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
900         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
901         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
902         * WebKitTestRunner/InjectedBundle/TestRunner.h:
903         * WebKitTestRunner/TestController.cpp:
904         (WTR::runOpenPanel):
905         (WTR::TestController::resetStateToConsistentValues):
906         * WebKitTestRunner/TestController.h:
907         (WTR::TestController::openPanelFileURLsMediaIcon const):
908         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
909         * WebKitTestRunner/TestInvocation.cpp:
910         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
911
912 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
913
914         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
915         https://bugs.webkit.org/show_bug.cgi?id=197171
916         <rdar://problem/47454979>
917
918         Reviewed by Youenn Fablet.
919
920         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
921         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
922         (TestWebKitAPI::TEST):
923
924 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
925
926         [ews-build] Add unit tests for UnApplyPatchIfRequired
927         https://bugs.webkit.org/show_bug.cgi?id=197197
928
929         Reviewed by Lucas Forschler.
930
931         * BuildSlaveSupport/ews-build/steps_unittest.py:
932         (TestUnApplyPatchIfRequired):
933         (TestUnApplyPatchIfRequired.test_success):
934         (TestUnApplyPatchIfRequired.test_failure):
935         (TestUnApplyPatchIfRequired.test_skip):
936
937 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
938
939         [ews-build] Add unit tests for CleanWorkingDirectory
940         https://bugs.webkit.org/show_bug.cgi?id=197195
941
942         Reviewed by Lucas Forschler.
943
944         * BuildSlaveSupport/ews-build/steps_unittest.py:
945         (TestCleanWorkingDirectory):
946         (TestCleanWorkingDirectory.test_success):
947         (TestCleanWorkingDirectory.test_failure):
948
949 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
950
951         [ews-build] Use explicit imports instead of wildcard imports
952         https://bugs.webkit.org/show_bug.cgi?id=197194
953
954         Reviewed by Lucas Forschler.
955
956         * BuildSlaveSupport/ews-build/factories.py:
957         * BuildSlaveSupport/ews-build/loadConfig.py:
958         * BuildSlaveSupport/ews-build/steps_unittest.py:
959
960 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
961
962         [ews-build] Add unit tests for DownloadBuiltProduct
963         https://bugs.webkit.org/show_bug.cgi?id=197193
964
965         Reviewed by Lucas Forschler.
966
967         * BuildSlaveSupport/ews-build/steps_unittest.py:
968         (TestDownloadBuiltProduct):
969         (TestDownloadBuiltProduct.setUp):
970         (TestDownloadBuiltProduct.tearDown):
971         (TestDownloadBuiltProduct.test_success):
972         (TestDownloadBuiltProduct.test_failure):
973
974 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
975
976         [ews-app] Exception while loading status-bubble when no build step has started
977         https://bugs.webkit.org/show_bug.cgi?id=196676
978
979         Reviewed by Lucas Forschler.
980
981         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
982         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
983
984 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
985
986         [PlayStation] Support running of JSC tests on remote playstation devices
987         https://bugs.webkit.org/show_bug.cgi?id=197170
988
989         Reviewed by Ross Kirsling.
990
991         Script changes
992
993         * Scripts/run-javascriptcore-tests:
994         (runJSCStressTests): Pass arguments for playstation to
995         run-jsc-stress-tests
996         * Scripts/run-jsc-stress-tests:
997         Handle $hostOS=="playstation" for determineArchitecture, turning
998         off $isFTLPlatform and runProfiler and defaulting test writer.
999         * Scripts/webkitdirs.pm:
1000         (jscPath): PlayStation WebKit executables have .elf extension
1001         (executableProductDir): PlayStation builds on Windows hosts but
1002         uses bin directory rather than bin64/bin32 for executable output
1003         location.
1004         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1005
1006 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1007
1008         [CMake][Win] Use target oriented design for WebKit
1009         https://bugs.webkit.org/show_bug.cgi?id=197173
1010
1011         Reviewed by Alex Christensen.
1012
1013         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1014         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1015
1016 2019-04-23  Chris Dumez  <cdumez@apple.com>
1017
1018         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1019         https://bugs.webkit.org/show_bug.cgi?id=197097
1020         <rdar://problem/50048318>
1021
1022         Reviewed by Alex Christensen.
1023
1024         Add API test coverage.
1025
1026         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1027         (-[PSONScheme webView:startURLSchemeTask:]):
1028
1029 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1030
1031         [ATK] Implement AtkComponentIface scroll_to methods
1032         https://bugs.webkit.org/show_bug.cgi?id=196856
1033
1034         Reviewed by Michael Catanzaro.
1035
1036         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1037         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1038         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1039         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1040
1041 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1042
1043         [ews-build] Improve summary for UploadBuiltProduct step
1044         https://bugs.webkit.org/show_bug.cgi?id=197182
1045
1046         Reviewed by Lucas Forschler.
1047
1048         * BuildSlaveSupport/ews-build/steps.py:
1049         (UploadBuiltProduct): Added descriptionDone.
1050         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1051         * BuildSlaveSupport/ews-build/steps_unittest.py:
1052         (TestUploadBuiltProduct.test_success): Updated unit-test.
1053         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1054
1055 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1056
1057         [ews-build] Trigger queues only after uploading the archive
1058         https://bugs.webkit.org/show_bug.cgi?id=197180
1059
1060         Reviewed by Lucas Forschler.
1061
1062         * BuildSlaveSupport/ews-build/factories.py:
1063         (Factory.__init__):
1064         (BuildFactory.__init__): Remove trigger step from factories.
1065         (BuildFactory.propertiesToPassToTriggers): Deleted.
1066         * BuildSlaveSupport/ews-build/steps.py:
1067         (ConfigureBuild.__init__): Confiure triggers property.
1068         (Trigger): Step to trigger other queues.
1069         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1070         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1071
1072 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1073
1074         Deprecate WKContextCreateWithInjectedBundlePath
1075         https://bugs.webkit.org/show_bug.cgi?id=197169
1076
1077         Reviewed by Youenn Fablet.
1078
1079         * TestWebKitAPI/PlatformUtilities.cpp:
1080         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1081         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1082
1083 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1084
1085         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1086         https://bugs.webkit.org/show_bug.cgi?id=197093
1087         <rdar://problem/49708268>
1088
1089         Reviewed by Chris Dumez.
1090
1091         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1092         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1093         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1094         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1095         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1096
1097         * TestWebKitAPI/TCPServer.cpp:
1098         (TestWebKitAPI::TCPServer::TCPServer):
1099         (TestWebKitAPI::TCPServer::~TCPServer):
1100         (TestWebKitAPI::TCPServer::socketBindListen):
1101         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1102         * TestWebKitAPI/TCPServer.h:
1103         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1104         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1105         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1106         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1107         (respondWithChallengeThenOK):
1108         (TestWebKitAPI::TEST):
1109         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1110         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1111         (TEST):
1112
1113 2019-04-22  Chris Dumez  <cdumez@apple.com>
1114
1115         Delayed WebProcessLaunch may break the _relatedWebView SPI
1116         https://bugs.webkit.org/show_bug.cgi?id=197160
1117
1118         Reviewed by Alex Christensen.
1119
1120         Add API test coverage.
1121
1122         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1123
1124 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1125
1126         Use curl to download packages for webkitpy autoinstaller
1127         https://bugs.webkit.org/show_bug.cgi?id=197164
1128
1129         Reviewed by Darin Adler.
1130
1131         * Scripts/webkitpy/common/system/autoinstall.py:
1132         (AutoInstaller._download): Use curl(1) to download packages necessary for
1133         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1134         errors which are not present when using curl(1).
1135
1136 2019-04-22  Chris Dumez  <cdumez@apple.com>
1137
1138         Unreviewed, rolling out r244502.
1139
1140         Caused crashes on the bots
1141
1142         Reverted changeset:
1143
1144         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1145         https://bugs.webkit.org/show_bug.cgi?id=197160
1146         https://trac.webkit.org/changeset/244502
1147
1148 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1149
1150         Unreviewed, rolling out r244437.
1151
1152         Still breaks internal tests.
1153
1154         Reverted changeset:
1155
1156         "InjectedBundle parameters often need initialization function
1157         called before unarchiving"
1158         https://bugs.webkit.org/show_bug.cgi?id=189709
1159         https://trac.webkit.org/changeset/244437
1160
1161 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1162
1163         [ews-build] Use singular verb in failure description in case of single api test failure
1164         https://bugs.webkit.org/show_bug.cgi?id=197013
1165
1166         Reviewed by Lucas Forschler.
1167
1168         * BuildSlaveSupport/ews-build/steps.py:
1169         (AnalyzeAPITestsResults.analyzeResults):
1170
1171 2019-04-22  Chris Dumez  <cdumez@apple.com>
1172
1173         Delayed WebProcessLaunch may break the _relatedWebView SPI
1174         https://bugs.webkit.org/show_bug.cgi?id=197160
1175
1176         Reviewed by Alex Christensen.
1177
1178         Add API test coverage.
1179
1180         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1181
1182 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1183
1184         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1185         https://bugs.webkit.org/show_bug.cgi?id=194630
1186
1187         Reviewed by Michael Catanzaro.
1188
1189         Return early from getAttributeSet() is passed in accessible is nullptr.
1190
1191         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1192
1193 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1194
1195         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1196         https://bugs.webkit.org/show_bug.cgi?id=197145
1197         <rdar://problem/50078170>
1198
1199         Reviewed by Darin Adler.
1200
1201         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1202         focus, or showing the font manager.
1203
1204         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1205         (TestWebKitAPI::TEST):
1206         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1207         (TEST):
1208         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1209         (TestWebKitAPI::TEST):
1210
1211 2019-04-21  Brian Burg  <bburg@apple.com>
1212
1213         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1214         https://bugs.webkit.org/show_bug.cgi?id=197125
1215         <rdar://problem/50061468>
1216
1217         Reviewed by Darin Adler.
1218
1219         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1220         using this class rather than making our own ./wpt serve invocation.
1221
1222         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1223         (WebDriverW3CWebServer):
1224         (WebDriverW3CWebServer.document_root): Expose this to clients.
1225         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1226
1227         (WebDriverW3CWebServer.__enter__):
1228         (WebDriverW3CWebServer.__exit__):
1229         Make it possible to use the web server with a 'with' statement.
1230
1231 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1232
1233         [CMake][Win] Use target oriented design for WebKitLegacy
1234         https://bugs.webkit.org/show_bug.cgi?id=197112
1235
1236         Reviewed by Konstantin Tokarev.
1237
1238         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1239
1240         * DumpRenderTree/CMakeLists.txt:
1241         * DumpRenderTree/PlatformWin.cmake:
1242         * DumpRenderTree/win/EventSender.cpp:
1243
1244 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1245
1246         Update text for old EWS submit button
1247         https://bugs.webkit.org/show_bug.cgi?id=197140
1248
1249         Reviewed by Alexey Proskuryakov.
1250
1251         * QueueStatusServer/templates/statusbubble.html:
1252
1253 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1254
1255         [ews-app] New EWS should poll bugzilla more frequently
1256         https://bugs.webkit.org/show_bug.cgi?id=197138
1257
1258         Reviewed by Alexey Proskuryakov.
1259
1260         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1261         (FetchLoop.__init__):
1262
1263 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1264
1265         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1266         https://bugs.webkit.org/show_bug.cgi?id=197139
1267
1268         Reviewed by Alexey Proskuryakov.
1269
1270         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1271         * QueueStatusServer/templates/statusbubble.html:
1272
1273 2019-04-20  Chris Dumez  <cdumez@apple.com>
1274
1275         Unreviewed, fix iOS build with recent SDKs.
1276
1277         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1278
1279 2019-04-19  Keith Miller  <keith_miller@apple.com>
1280
1281         Add script to merge run_benchmark jsons
1282         https://bugs.webkit.org/show_bug.cgi?id=197107
1283
1284         Reviewed by Michael Saboff.
1285
1286         The script basically recursively decends through all json objects until it gets
1287         to an array or JSON primitive and concats or takes the first value, respectively.
1288
1289         This patch also adds +x bits to the compare-results script so it
1290         can be run directly from the command line. I had to add a new line so that svn
1291         will accept the change... yay svn!
1292
1293         * Scripts/compare-results:
1294         * Scripts/merge-result-jsons: Added.
1295         (readJSONFile):
1296         (deepAppend):
1297         (mergeJSONs):
1298         (main):
1299
1300 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1301
1302         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1303         https://bugs.webkit.org/show_bug.cgi?id=197079
1304
1305         Reviewed by Darin Adler.
1306
1307         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1308
1309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1310         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1311
1312 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1313
1314         Unreviewed, rolling out r244434.
1315         https://bugs.webkit.org/show_bug.cgi?id=197089
1316
1317         caused 1 API test failure (Requested by zalan on #webkit).
1318
1319         Reverted changeset:
1320
1321         "Regression (r244291): Broken API Test
1322         AutoLayoutRenderingProgressRelativeOrdering"
1323         https://bugs.webkit.org/show_bug.cgi?id=196948
1324         https://trac.webkit.org/changeset/244434
1325
1326 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1327
1328         Add new compatibility mode API on WKNavigation
1329         https://bugs.webkit.org/show_bug.cgi?id=197069
1330         <rdar://problem/50025800>
1331
1332         Reviewed by Tim Horton.
1333
1334         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1335
1336         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1337         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1338         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1339
1340 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1341
1342         [CMake] Make WebCore headers copies
1343         https://bugs.webkit.org/show_bug.cgi?id=182512
1344         <rdar://problem/37510435>
1345
1346         Reviewed by Alex Christensen.
1347
1348         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1349         ports.
1350
1351         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1352         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1353
1354         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1355         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1356         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1357         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1358         * TestWebKitAPI/CMakeLists.txt:
1359         * TestWebKitAPI/PlatformWin.cmake:
1360         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1361         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1362         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1363
1364 2019-04-18  Jer Noble  <jer.noble@apple.com>
1365
1366         Add support for parsing FairPlayStreaming PSSH boxes.
1367         https://bugs.webkit.org/show_bug.cgi?id=197064
1368
1369         Reviewed by Eric Carlson.
1370
1371         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1372         (TestWebKitAPI::TEST):
1373
1374 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1375
1376         InjectedBundle parameters often need initialization function called before unarchiving
1377         https://bugs.webkit.org/show_bug.cgi?id=189709
1378         <rdar://problem/44573653>
1379
1380         Reviewed by Ryosuke Niwa.
1381
1382         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1383         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1384
1385 2019-04-18  Zalan Bujtas  <zalan@apple.com>
1386
1387         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1388         https://bugs.webkit.org/show_bug.cgi?id=196948
1389         <rdar://problem/49927131>
1390
1391         Reviewed by Tim Horton.
1392
1393         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1394         (TEST): 
1395         The expected order of incoming events is
1396         1. didInvalidateIntrinsicContentSize
1397         2. didFirstLayout
1398         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1399         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1400         (and remember, all we care about is ordering).
1401
1402 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
1403
1404         Unreviewed, rolling out r244299.
1405
1406         Breaks internal tests.
1407
1408         Reverted changeset:
1409
1410         "InjectedBundle parameters often need initialization function
1411         called before unarchiving"
1412         https://bugs.webkit.org/show_bug.cgi?id=189709
1413         https://trac.webkit.org/changeset/244299
1414
1415 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
1416
1417         [WTF] StringBuilder should set correct m_is8Bit flag when merging
1418         https://bugs.webkit.org/show_bug.cgi?id=197053
1419
1420         Reviewed by Saam Barati.
1421
1422         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1423         (TestWebKitAPI::TEST):
1424
1425 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1426
1427         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
1428         https://bugs.webkit.org/show_bug.cgi?id=197028
1429         <rdar://problem/49985290>
1430
1431         Reviewed by Wenson Hsieh.
1432
1433         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1434         (TEST):
1435         Liberal application of waitForNextPresentationUpdate works around a race
1436         where if the page rapidly changes its viewport arguments (or an API client
1437         rapidly changes its viewport arguments), we'd get stuck thinking that the
1438         user had intentionally zoomed the page, and stop resetting the initial scale.
1439         This deserves a separate bug, but no need to keep the test failing while
1440         we think about it.
1441
1442 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1443
1444         REGRESSION (r241988): Switching tabs is slow
1445         https://bugs.webkit.org/show_bug.cgi?id=197037
1446         <rdar://problem/49951473>
1447
1448         Reviewed by Simon Fraser.
1449
1450         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1451         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
1452         (TEST):
1453         * TestWebKitAPI/cocoa/TestWKWebView.h:
1454         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1455         (-[TestWKWebView addToTestWindow]):
1456         Add a test that hangs without this fix.
1457
1458 2019-04-17  Truitt Savell  <tsavell@apple.com>
1459
1460         Unreviewed, rolling out r244400.
1461
1462         Caused testing to exit early with assertionon Debug WK2
1463
1464         Reverted changeset:
1465
1466         "UI↔Web deadlock when printing with a JavaScript alert
1467         visible"
1468         https://bugs.webkit.org/show_bug.cgi?id=196839
1469         https://trac.webkit.org/changeset/244400
1470
1471 2019-04-17  Brady Eidson  <beidson@apple.com>
1472
1473         Link clicks in PDFs shouldn't send referrer headers.
1474         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1475
1476         Reviewed by Tim Horton.
1477
1478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1479         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1480         (putPDFBytesCallback):
1481         (emptyReleaseInfoCallback):
1482         (createPDFWithLinkToURL):
1483         (TEST):
1484
1485 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1486
1487         UI↔Web deadlock when printing with a JavaScript alert visible
1488         https://bugs.webkit.org/show_bug.cgi?id=196839
1489         <rdar://problem/49157642>
1490
1491         Reviewed by Andy Estes.
1492
1493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1494         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1495         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1496         (TEST):
1497
1498 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1499
1500         WKRetainPtr's adoption constructor should be private
1501         https://bugs.webkit.org/show_bug.cgi?id=197019
1502
1503         Reviewed by Tim Horton.
1504
1505         * DumpRenderTree/mac/DumpRenderTree.mm:
1506         (dumpFramesAsText):
1507         * TestWebKitAPI/InjectedBundleController.cpp:
1508         (TestWebKitAPI::InjectedBundleController::initialize):
1509         * TestWebKitAPI/PlatformUtilities.cpp:
1510         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1511         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1512         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1513         (TestWebKitAPI::Util::toWK):
1514         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1515         (TestWebKitAPI::TEST):
1516         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1517         (TestWebKitAPI::TEST):
1518         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1519         (TestWebKitAPI::TEST):
1520         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1521         (TestWebKitAPI::TEST):
1522         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1523         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1524         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1525         (TestWebKitAPI::TEST):
1526         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1527         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1528         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1529         (TestWebKitAPI::TEST):
1530         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1531         (TestWebKitAPI::TEST):
1532         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1533         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1534         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1535         (TestWebKitAPI::TEST):
1536         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1537         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1538         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1539         (TestWebKitAPI::TEST):
1540         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1541         (TestWebKitAPI::TEST):
1542         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1543         (TestWebKitAPI::TEST):
1544         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1545         (TestWebKitAPI::TEST):
1546         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1547         (TestWebKitAPI::TEST):
1548         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1549         (TestWebKitAPI::TEST):
1550         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1551         (TestWebKitAPI::TEST):
1552         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1553         (TestWebKitAPI::TEST):
1554         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1555         (TestWebKitAPI::TEST):
1556         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1557         (TestWebKitAPI::TEST):
1558         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1559         (TestWebKitAPI::TEST):
1560         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1561         (TestWebKitAPI::TEST):
1562         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1563         (TestWebKitAPI::TEST):
1564         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1565         (TestWebKitAPI::TEST):
1566         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1567         (TestWebKitAPI::TEST):
1568         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1569         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1570         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1571         (TestWebKitAPI::TEST):
1572         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1573         (TestWebKitAPI::TEST):
1574         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1575         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1576         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1577         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1578         (TestWebKitAPI::TEST):
1579         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1580         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1581         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1582         (TestWebKitAPI::TEST):
1583         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1584         (TestWebKitAPI::TEST):
1585         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1586         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1587         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1588         (TestWebKitAPI::TEST):
1589         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1590         (TestWebKitAPI::loadAlternateHTMLString):
1591         (TestWebKitAPI::TEST):
1592         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1593         (TestWebKitAPI::TEST):
1594         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1595         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1596         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1597         (TestWebKitAPI::buildAndPerformTest):
1598         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1599         (TestWebKitAPI::TEST):
1600         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1601         (TestWebKitAPI::TEST):
1602         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1603         (TestWebKitAPI::TEST):
1604         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1605         (TestWebKitAPI::TEST):
1606         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1607         (TestWebKitAPI::TEST):
1608         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1609         (TestWebKitAPI::TEST):
1610         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1611         (TestWebKitAPI::TEST):
1612         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1613         (TestWebKitAPI::TEST):
1614         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1615         (TestWebKitAPI::TEST):
1616         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1617         (TestWebKitAPI::TEST):
1618         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1619         (TestWebKitAPI::TEST):
1620         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1621         (TestWebKitAPI::TEST):
1622         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1623         (TestWebKitAPI::TEST):
1624         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1625         (TestWebKitAPI::TEST):
1626         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1627         (TestWebKitAPI::TEST):
1628         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1629         (TestWebKitAPI::TEST):
1630         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1631         (TestWebKitAPI::TEST):
1632         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1633         (TestWebKitAPI::TEST):
1634         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1635         (TestWebKitAPI::TEST):
1636         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1637         (TestWebKitAPI::TEST):
1638         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1639         (TestWebKitAPI::TEST):
1640         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1641         (TestWebKitAPI::TEST):
1642         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1643         (TestWebKitAPI::TEST):
1644         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1645         (TestWebKitAPI::TEST):
1646         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1647         (TestWebKitAPI::TEST):
1648         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1649         (TestWebKitAPI::TEST):
1650         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1651         (TestWebKitAPI::TEST):
1652         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1653         (TestWebKitAPI::TEST):
1654         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1655         (TestWebKitAPI::TEST):
1656         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1657         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1658         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1659         (TestWebKitAPI::TEST):
1660         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1661         (TestWebKitAPI::TEST):
1662         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1663         (TestWebKitAPI::TEST):
1664         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1665         (TestWebKitAPI::TEST):
1666         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1667         (TestWebKitAPI::TEST):
1668         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1669         (TestWebKitAPI::TEST):
1670         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1671         (TestWebKitAPI::TEST):
1672         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1673         (TestWebKitAPI::TEST):
1674         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1675         (TestWebKitAPI::TEST):
1676         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1677         (TestWebKitAPI::TEST):
1678         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1679         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1680         (TEST):
1681         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1682         (TEST):
1683         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1684         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1685         (TEST):
1686         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1687         (TestWebKitAPI::TEST):
1688         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1689         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1690         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1691         (WTR::getMenuItemTitleCallback):
1692         (WTR::createMouseMessageBody):
1693         (WTR::EventSendingController::mouseDown):
1694         (WTR::EventSendingController::mouseUp):
1695         (WTR::EventSendingController::mouseMoveTo):
1696         (WTR::EventSendingController::mouseForceClick):
1697         (WTR::EventSendingController::startAndCancelMouseForceClick):
1698         (WTR::EventSendingController::mouseForceDown):
1699         (WTR::EventSendingController::mouseForceUp):
1700         (WTR::EventSendingController::mouseForceChanged):
1701         (WTR::EventSendingController::leapForward):
1702         (WTR::EventSendingController::scheduleAsynchronousClick):
1703         (WTR::createKeyDownMessageBody):
1704         (WTR::EventSendingController::keyDown):
1705         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1706         (WTR::EventSendingController::mouseScrollBy):
1707         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1708         (WTR::EventSendingController::continuousMouseScrollBy):
1709         (WTR::EventSendingController::addTouchPoint):
1710         (WTR::EventSendingController::updateTouchPoint):
1711         (WTR::EventSendingController::setTouchModifier):
1712         (WTR::EventSendingController::setTouchPointRadius):
1713         (WTR::EventSendingController::touchStart):
1714         (WTR::EventSendingController::touchMove):
1715         (WTR::EventSendingController::touchEnd):
1716         (WTR::EventSendingController::touchCancel):
1717         (WTR::EventSendingController::clearTouchPoints):
1718         (WTR::EventSendingController::releaseTouchPoint):
1719         (WTR::EventSendingController::cancelTouchPoint):
1720         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1721         (WTR::InjectedBundle::didCreatePage):
1722         (WTR::InjectedBundle::didReceiveMessage):
1723         (WTR::InjectedBundle::didReceiveMessageToPage):
1724         (WTR::InjectedBundle::booleanForKey):
1725         (WTR::InjectedBundle::done):
1726         (WTR::InjectedBundle::dumpToStdErr):
1727         (WTR::InjectedBundle::outputText):
1728         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1729         (WTR::InjectedBundle::postAddChromeInputField):
1730         (WTR::InjectedBundle::postRemoveChromeInputField):
1731         (WTR::InjectedBundle::postFocusWebView):
1732         (WTR::InjectedBundle::postSetBackingScaleFactor):
1733         (WTR::InjectedBundle::postSetWindowIsKey):
1734         (WTR::InjectedBundle::postSetViewSize):
1735         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1736         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1737         (WTR::InjectedBundle::setGeolocationPermission):
1738         (WTR::InjectedBundle::setMockGeolocationPosition):
1739         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1740         (WTR::InjectedBundle::isGeolocationProviderActive const):
1741         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1742         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1743         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1744         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1745         (WTR::InjectedBundle::setCustomPolicyDelegate):
1746         (WTR::InjectedBundle::setHidden):
1747         (WTR::InjectedBundle::setCacheModel):
1748         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1749         (WTR::InjectedBundle::processWorkQueue):
1750         (WTR::InjectedBundle::queueBackNavigation):
1751         (WTR::InjectedBundle::queueForwardNavigation):
1752         (WTR::InjectedBundle::queueLoad):
1753         (WTR::InjectedBundle::queueLoadHTMLString):
1754         (WTR::InjectedBundle::queueReload):
1755         (WTR::InjectedBundle::queueLoadingScript):
1756         (WTR::InjectedBundle::queueNonLoadingScript):
1757         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1758         (WTR::frameToStr):
1759         (WTR::InjectedBundlePage::InjectedBundlePage):
1760         (WTR::dumpFrameDescriptionSuitableForTestResult):
1761         (WTR::dumpFrameScrollPosition):
1762         (WTR::dumpDescendantFrameScrollPositions):
1763         (WTR::dumpFrameText):
1764         (WTR::dumpDescendantFramesText):
1765         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1766         (WTR::TestRunner::shouldDumpPixels const):
1767         (WTR::TestRunner::setDumpPixels):
1768         (WTR::TestRunner::whatToDump const):
1769         (WTR::TestRunner::setWhatToDump):
1770         (WTR::TestRunner::setWaitUntilDone):
1771         (WTR::TestRunner::shouldWaitUntilDone const):
1772         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1773         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1774         (WTR::TestRunner::clearAllDatabases):
1775         (WTR::TestRunner::setIDBPerOriginQuota):
1776         (WTR::TestRunner::originsWithApplicationCache):
1777         (WTR::TestRunner::setCanOpenWindows):
1778         (WTR::TestRunner::setXSSAuditorEnabled):
1779         (WTR::TestRunner::setMediaDevicesEnabled):
1780         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1781         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1782         (WTR::TestRunner::setCustomUserAgent):
1783         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1784         (WTR::TestRunner::setModernMediaControlsEnabled):
1785         (WTR::TestRunner::setWebGL2Enabled):
1786         (WTR::TestRunner::setWritableStreamAPIEnabled):
1787         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1788         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1789         (WTR::TestRunner::setAllowsAnySSLCertificate):
1790         (WTR::TestRunner::setPluginsEnabled):
1791         (WTR::TestRunner::setValueForUser):
1792         (WTR::TestRunner::setAudioResult):
1793         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1794         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1795         (WTR::TestRunner::setAlwaysAcceptCookies):
1796         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1797         (WTR::TestRunner::isDoingMediaCapture const):
1798         (WTR::TestRunner::queueLoad):
1799         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1800         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1801         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1802         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1803         (WTR::TestRunner::setAuthenticationUsername):
1804         (WTR::TestRunner::setAuthenticationPassword):
1805         (WTR::TestRunner::secureEventInputIsEnabled const):
1806         (WTR::TestRunner::setBlockAllPlugins):
1807         (WTR::TestRunner::setPluginSupportedMode):
1808         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1809         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1810         (WTR::TestRunner::setNavigationGesturesEnabled):
1811         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1812         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1813         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1814         (WTR::TestRunner::terminateNetworkProcess):
1815         (WTR::TestRunner::terminateServiceWorkerProcess):
1816         (WTR::TestRunner::runUIScript):
1817         (WTR::TestRunner::setStatisticsDebugMode):
1818         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1819         (WTR::TestRunner::setStatisticsLastSeen):
1820         (WTR::TestRunner::setStatisticsPrevalentResource):
1821         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1822         (WTR::TestRunner::dumpResourceLoadStatistics):
1823         (WTR::TestRunner::isStatisticsPrevalentResource):
1824         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1825         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1826         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1827         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1828         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1829         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1830         (WTR::TestRunner::setStatisticsGrandfathered):
1831         (WTR::TestRunner::isStatisticsGrandfathered):
1832         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1833         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1834         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1835         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1836         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1837         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1838         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1839         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1840         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1841         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1842         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1843         (WTR::TestRunner::statisticsSubmitTelemetry):
1844         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1845         (WTR::TestRunner::setStatisticsIsRunningTest):
1846         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1847         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1848         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1849         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1850         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1851         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1852         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1853         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1854         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1855         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1856         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1857         (WTR::TestRunner::statisticsResetToConsistentState):
1858         (WTR::TestRunner::setStorageAccessAPIEnabled):
1859         (WTR::TestRunner::getAllStorageAccessEntries):
1860         (WTR::TestRunner::addMockMediaDevice):
1861         (WTR::TestRunner::clearMockMediaDevices):
1862         (WTR::TestRunner::removeMockMediaDevice):
1863         (WTR::TestRunner::resetMockMediaDevices):
1864         (WTR::TestRunner::connectMockGamepad):
1865         (WTR::TestRunner::disconnectMockGamepad):
1866         (WTR::TestRunner::setMockGamepadDetails):
1867         (WTR::TestRunner::setMockGamepadAxisValue):
1868         (WTR::TestRunner::setMockGamepadButtonValue):
1869         (WTR::TestRunner::removeAllSessionCredentials):
1870         (WTR::TestRunner::clearDOMCache):
1871         (WTR::TestRunner::clearDOMCaches):
1872         (WTR::TestRunner::hasDOMCache):
1873         (WTR::TestRunner::domCacheSize):
1874         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1875         (WTR::TestRunner::getApplicationManifestThen):
1876         (WTR::TestRunner::injectUserScript):
1877         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1878         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1879         (WTR::TestRunner::addTestKeyToKeychain):
1880         (WTR::TestRunner::cleanUpKeychain):
1881         (WTR::TestRunner::keyExistsInKeychain):
1882         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1883         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1884         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1885         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1886         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1887         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1888         * WebKitTestRunner/TestController.cpp:
1889         (WTR::TestController::initialize):
1890         (WTR::parseStringTestHeaderValueAsRelativePath):
1891         (WTR::updateTestOptionsFromTestHeader):
1892         (WTR::TestController::runTest):
1893         (WTR::TestController::didReceiveLiveDocumentsList):
1894         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1895         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1896         (WTR::TestController::didFinishNavigation):
1897         (WTR::TestController::didReceiveAuthenticationChallenge):
1898         * WebKitTestRunner/TestInvocation.cpp:
1899         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1900         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1901         (WTR::TestInvocation::uiScriptDidComplete):
1902         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1903         * WebKitTestRunner/WebNotificationProvider.cpp:
1904         (WTR::WebNotificationProvider::closeWebNotification):
1905         * WebKitTestRunner/WorkQueueManager.cpp:
1906         (WTR::ScriptItem::ScriptItem):
1907         (WTR::WorkQueueManager::queueLoad):
1908         (WTR::WorkQueueManager::queueLoadHTMLString):
1909
1910 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1911
1912         Add a comment to make my test from r244139 less mysterious.
1913         https://bugs.webkit.org/show_bug.cgi?id=196744
1914
1915         As suggested by Darin Adler.
1916
1917         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1918         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1919
1920 2019-04-17  Chris Dumez  <cdumez@apple.com>
1921
1922         Remember device orientation permission for the duration of the browsing session
1923         https://bugs.webkit.org/show_bug.cgi?id=196992
1924         <rdar://problem/49946067>
1925
1926         Reviewed by Alex Christensen.
1927
1928         Add API test coverage.
1929
1930         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1931         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1932         (TEST):
1933
1934 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1935
1936         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1937         https://bugs.webkit.org/show_bug.cgi?id=196675
1938
1939         Reviewed by Lucas Forschler.
1940
1941         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1942         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
1943
1944 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1945
1946         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
1947         https://bugs.webkit.org/show_bug.cgi?id=196919
1948         <rdar://problem/41630459>
1949
1950         Reviewed by Tim Horton.
1951
1952         Add iOS support for several new testing hooks. See below for more detail.
1953
1954         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1955         (WTR::UIScriptController::isDismissingMenu const):
1956
1957         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
1958         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
1959         by UIKit when dismissing the callout bar (i.e. UIMenuController).
1960
1961         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1962         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1963         (WTR::UIScriptController::isDismissingMenu const):
1964         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1965         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1966         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1967         (WTR::InjectedBundle::didReceiveMessageToPage):
1968         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1969         (WTR::TestRunner::setAllowedMenuActions):
1970
1971         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
1972         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
1973         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
1974         against the name of the custom action.
1975
1976         (WTR::TestRunner::installCustomMenuAction):
1977
1978         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
1979         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
1980         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
1981         triggered.
1982
1983         (WTR::TestRunner::performCustomMenuAction):
1984
1985         Invoked when the custom menu action is triggered.
1986
1987         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1988         * WebKitTestRunner/TestController.cpp:
1989         (WTR::TestController::installCustomMenuAction):
1990         (WTR::TestController::setAllowedMenuActions):
1991         * WebKitTestRunner/TestController.h:
1992         * WebKitTestRunner/TestInvocation.cpp:
1993         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1994         (WTR::TestInvocation::performCustomMenuAction):
1995
1996         Add plumbing to call back into the injected bundle when performing the custom action.
1997
1998         * WebKitTestRunner/TestInvocation.h:
1999         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2000         (WTR::TestController::installCustomMenuAction):
2001         (WTR::TestController::setAllowedMenuActions):
2002         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2003         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2004         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2005         (-[TestRunnerWKWebView becomeFirstResponder]):
2006         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2007
2008         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2009         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2010         in the Mail app on iOS.
2011
2012         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2013         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2014         (-[TestRunnerWKWebView resetCustomMenuAction]):
2015         (-[TestRunnerWKWebView performCustomAction:]):
2016         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2017         (-[TestRunnerWKWebView _willHideMenu]):
2018         (-[TestRunnerWKWebView _didHideMenu]):
2019         * WebKitTestRunner/ios/TestControllerIOS.mm:
2020         (WTR::TestController::platformResetStateToConsistentValues):
2021
2022         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2023         if specified.
2024
2025         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2026         (WTR::UIScriptController::isDismissingMenu const):
2027
2028 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2029
2030         Allow sharing from imageSheet on an image document
2031         https://bugs.webkit.org/show_bug.cgi?id=196891
2032         <rdar://problem/25377386>
2033
2034         Reviewed by Tim Horton.
2035
2036         Test to make sure that the correct imageURL is extracted from an image element.
2037
2038         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2039         (TestWebKitAPI::TEST):
2040
2041 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2042
2043         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2044         https://bugs.webkit.org/show_bug.cgi?id=196995
2045
2046         Reviewed by Brady Eidson.
2047
2048         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2049         (TEST):
2050
2051 2019-04-16  Chris Dumez  <cdumez@apple.com>
2052
2053         URL set by document.open() is not communicated to the UIProcess
2054         https://bugs.webkit.org/show_bug.cgi?id=196941
2055         <rdar://problem/49237544>
2056
2057         Reviewed by Geoff Garen.
2058
2059         Add API test coverage.
2060
2061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2062         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2063         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2064         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2065         (TEST):
2066
2067 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2068
2069         Unreviewed, rolling out r244321.
2070         https://bugs.webkit.org/show_bug.cgi?id=196968
2071
2072         Causing all WK2 Debug builds to exit early after Assertion
2073         failures. (Requested by ShawnRoberts on #webkit).
2074
2075         Reverted changeset:
2076
2077         "URL set by document.open() is not communicated to the
2078         UIProcess"
2079         https://bugs.webkit.org/show_bug.cgi?id=196941
2080         https://trac.webkit.org/changeset/244321
2081
2082 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2083
2084         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2085         https://bugs.webkit.org/show_bug.cgi?id=196948
2086
2087         Reviewed by Zalan Bujtas.
2088
2089         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2090         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2091
2092 2019-04-15  Chris Dumez  <cdumez@apple.com>
2093
2094         URL set by document.open() is not communicated to the UIProcess
2095         https://bugs.webkit.org/show_bug.cgi?id=196941
2096         <rdar://problem/49237544>
2097
2098         Reviewed by Geoffrey Garen.
2099
2100         Add API test coverage.
2101
2102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2103         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2104         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2105         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2106         (TEST):
2107
2108 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2109
2110         Using Tools/Scripts/clean-webkit should not install requests
2111         https://bugs.webkit.org/show_bug.cgi?id=196940
2112
2113         Reviewed by Lucas Forschler.
2114
2115         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2116         existing, depending on the path autoinstalled is run through.
2117         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2118         needed.
2119         (Port.configuration_for_upload):
2120         (Port.commits_for_upload):
2121
2122 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2123
2124         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2125         https://bugs.webkit.org/show_bug.cgi?id=196773
2126
2127         Reviewed by Jer Noble.
2128
2129         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2130         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2131         (TEST):
2132
2133 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2134
2135         ews-build should clearly indicate flaky test failures
2136         https://bugs.webkit.org/show_bug.cgi?id=196947
2137
2138         Reviewed by Lucas Forschler.
2139
2140         * BuildSlaveSupport/ews-build/steps.py:
2141         (AnalyzeAPITestsResults.analyzeResults):
2142
2143 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2144
2145         InjectedBundle parameters often need initialization function called before unarchiving
2146         https://bugs.webkit.org/show_bug.cgi?id=189709
2147         <rdar://problem/44573653>
2148
2149         Reviewed by Ryosuke Niwa.
2150
2151         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2152         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2153
2154 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2155
2156         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2157         https://bugs.webkit.org/show_bug.cgi?id=196681
2158
2159         Reviewed by Darin Adler.
2160
2161         Added tests.
2162
2163         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2164         (WTF_HashSet.RemoveIf):
2165         (WTF_HashSet.RemoveIfShrinkToBestSize):
2166
2167 2019-04-15  John Wilander  <wilander@apple.com>
2168
2169         Send delayed Ad Click Attribution conversion requests to the click source
2170         https://bugs.webkit.org/show_bug.cgi?id=196838
2171         <rdar://problem/47650157>
2172
2173         Reviewed by Chris Dumez and Youenn Fablet.
2174
2175         This patch adds test infrastructure to override the default behavior in
2176         WebKit::NetworkAdClickAttribution.
2177
2178         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2179         (TestWebKitAPI::TEST):
2180         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2181         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2182         (WTR::TestRunner::dumpAdClickAttribution):
2183         (WTR::TestRunner::clearAdClickAttribution):
2184         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2185         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2186         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2187         * WebKitTestRunner/TestController.cpp:
2188         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2189         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2190         * WebKitTestRunner/TestController.h:
2191         * WebKitTestRunner/TestInvocation.cpp:
2192         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2193
2194 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2195
2196         [ews-app] status-bubble should display position in queue
2197         https://bugs.webkit.org/show_bug.cgi?id=196607
2198
2199         Reviewed by Lucas Forschler.
2200
2201         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2202         (StatusBubble._build_bubble):
2203         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2204
2205 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2206
2207         [ews-build] Do not run clean build by default on EWS builders
2208         https://bugs.webkit.org/show_bug.cgi?id=196897
2209
2210         Reviewed by Lucas Forschler.
2211
2212         * BuildSlaveSupport/ews-build/steps.py:
2213         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2214         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2215         untracked directories like WebKitBuild).
2216         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2217         untracked files/directories (like WebKitBuild).
2218
2219 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2220
2221         TestRunner::notifyDone() should be safely reentrant
2222         https://bugs.webkit.org/show_bug.cgi?id=196898
2223
2224         Reviewed by Darin Adler.
2225
2226         It is currently possible that TestRunner::notifyDone() will call itself, since
2227         notifyDone() will force a repaint, which can start executing JavaScript, which
2228         may call notifyDone() again. This can lead to test failures and flakiness.
2229         Fix this by setting the m_waitToDump flag before calling the dump() method.
2230
2231         * DumpRenderTree/mac/TestRunnerMac.mm:
2232         (TestRunner::notifyDone):
2233         (TestRunner::forceImmediateCompletion):
2234         * DumpRenderTree/win/TestRunnerWin.cpp:
2235         (TestRunner::notifyDone):
2236         (TestRunner::forceImmediateCompletion):
2237
2238 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2239
2240         [GTK][WPE] Add enable-media websetting
2241         https://bugs.webkit.org/show_bug.cgi?id=196863
2242
2243         Reviewed by Michael Catanzaro.
2244
2245         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2246         (testWebKitSettings): Add test for the enable-media web-setting.
2247
2248 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2249
2250         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2251         https://bugs.webkit.org/show_bug.cgi?id=196905
2252         <rdar://problem/49886096>
2253
2254         Reviewed by Tim Horton.
2255
2256         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2257         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2258         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2259         delay timer, we end up with this sequence of events in the problematic (failure) case:
2260
2261         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2262             ...IPC from UI to web process...
2263         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2264             ...IPC from web to UI process...
2265         (c) [UI]    Invoke completion handler for script #1
2266         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2267             ...IPC from UI to web process...
2268         (e) [Web]   Evaluate script #2 in the web process
2269         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2270
2271         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2272         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2273         #2 is run in step (e).
2274
2275         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2276         the UI process by waiting on a script message posted by the web process, after attachment updates are
2277         dispatched.
2278
2279         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2280         (TestWebKitAPI::TEST):
2281
2282 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2283
2284         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2285         https://bugs.webkit.org/show_bug.cgi?id=196909
2286
2287         Reviewed by Wenson Hsieh.
2288
2289         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2290         (TestWebKitAPI::TEST):
2291
2292 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2293
2294         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2295         https://bugs.webkit.org/show_bug.cgi?id=196880
2296
2297         Reviewed by Yusuke Suzuki.
2298
2299         Add a new function for bytecode cache tests that does not forceDiskCache
2300         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2301         test added in this patch, since the code is invalid and therefore won't be
2302         cached. It should also be useful for tests that evaluate dynamically
2303         generated code.
2304
2305         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2306         * Scripts/run-jsc-stress-tests:
2307
2308 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2309
2310         Update AudioSession route sharing policy
2311         https://bugs.webkit.org/show_bug.cgi?id=196776
2312         <rdar://problem/46501611>
2313
2314         Reviewed by Jer Noble.
2315
2316         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2317         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2318         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2319         (TestWebKitAPI::TEST):
2320
2321 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2322
2323         [iOS] Software keyboard is shown too frequently on some websites
2324         https://bugs.webkit.org/show_bug.cgi?id=195856
2325         <rdar://problem/49191395>
2326
2327         Reviewed by Darin Adler.
2328
2329         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2330
2331         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2332         (WTR::UIScriptController::setHardwareKeyboardAttached):
2333         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2334         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2335         (WTR::UIScriptController::setHardwareKeyboardAttached):
2336         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2337         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2338
2339         Additionally link against GraphicsServices in WebKitTestRunner.
2340
2341         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2342         (WTR::TestController::platformResetStateToConsistentValues):
2343         (WTR::UIScriptController::setHardwareKeyboardAttached):
2344
2345 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2346
2347         [GTK][WPE] Fix pacman install-dependencies packages
2348         https://bugs.webkit.org/show_bug.cgi?id=196817
2349
2350         Reviewed by Žan Doberšek.
2351         
2352         python3-setuptools is called python-setuptools
2353         ruby-highline is only available on AUR
2354         libv4l-devel is incorporated in v4l-utils
2355
2356         * gtk/install-dependencies:
2357         * wpe/install-dependencies:
2358
2359 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2360
2361         [GTK] REGRESSION(r243860): Many tests failing
2362         https://bugs.webkit.org/show_bug.cgi?id=196791
2363
2364         Reviewed by Joanmarie Diggs.
2365
2366         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2367         multiple documents and check that accessibility hierarchy is updated after a navigation.
2368
2369         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2370         (loadChangedCallback):
2371         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2372         (AccessibilityTest::AccessibilityTest):
2373         (AccessibilityTest::~AccessibilityTest):
2374         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2375         (AccessibilityTest::findTestServerApplication):
2376         (AccessibilityTest::findDocumentWeb):
2377         (AccessibilityTest::findRootObject):
2378         (AccessibilityTest::waitUntilChildrenRemoved):
2379         (AccessibilityTest::ensureProxy):
2380         (testAtspiBasicHierarchy):
2381         (beforeAll):
2382         (afterAll):
2383
2384 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2385
2386         [ews-build] Handle bug titles with unicode characters
2387         https://bugs.webkit.org/show_bug.cgi?id=196802
2388
2389         Reviewed by Dewei Zhu.
2390
2391         * BuildSlaveSupport/ews-build/steps.py:
2392         (ValidatePatch._is_bug_closed):
2393
2394 2019-04-11  Michael Saboff  <msaboff@apple.com>
2395
2396         Improve the Inline Cache Stats code
2397         https://bugs.webkit.org/show_bug.cgi?id=196836
2398
2399         Reviewed by Saam Barati.
2400
2401         Added a new script to consolidate and arrange the output of --useICStats option.
2402
2403         This script merges the output from every group into one large table and sorts it from most common to
2404         least common.  It also counts the slow path GetById and PutById variants and then calculates the
2405         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
2406         Put together, this is useful to see what property accesses are not getting cached.
2407
2408         * Scripts/ic-stats.py: Added.
2409         (ICStats):
2410         (ICStats.__init__):
2411         (ICStats.parse):
2412         (ICStats.dumpStats):
2413         (usage):
2414
2415 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2416
2417         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
2418         https://bugs.webkit.org/show_bug.cgi?id=196809
2419         <rdar://49800762>
2420
2421         Reviewed by Brady Eidson.
2422
2423         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2424         (TEST):
2425
2426 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2427
2428         requestAnimationFrame should execute before the next frame
2429         https://bugs.webkit.org/show_bug.cgi?id=177484
2430
2431         Reviewed by Simon Fraser.
2432
2433         Add trace points for the page RenderingUpdate.
2434
2435         * Tracing/SystemTracePoints.plist:
2436
2437 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2438
2439         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
2440         https://bugs.webkit.org/show_bug.cgi?id=196760
2441
2442         Reviewed by Don Olmstead.
2443
2444         vswhere.exe has been bundled since Visual Studio 2017 version
2445         15.2. We shouldn't download vswhere.exe.
2446
2447         * Scripts/build-jsc: Do not call update-vswhere.py.
2448         * Scripts/build-webkit: Ditto.
2449         * Scripts/update-vswhere.py: Removed.
2450         * Scripts/webkitdirs.pm:
2451         (requireModulesForVSWhere): Deleted.
2452         (pickCurrentVisualStudioInstallation): Deleted.
2453         (visualStudioInstallDirVSWhere): Return the latest installed VS
2454         installation path by using the bundled vswhere.exe.
2455         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
2456         (visualStudioInstallDirFallback): Removed.
2457
2458 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2459
2460         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2461         https://bugs.webkit.org/show_bug.cgi?id=196780
2462
2463         Reviewed by Alexey Proskuryakov.
2464
2465         * BuildSlaveSupport/ews-build/steps.py:
2466         * BuildSlaveSupport/ews-build/steps_unittest.py:
2467
2468 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2469
2470         Add SPI WKNavigationResponse._downloadAttribute
2471         https://bugs.webkit.org/show_bug.cgi?id=196755
2472         <rdar://49587365>
2473
2474         Reviewed by Brady Eidson.
2475
2476         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2477         (-[NavigationResponseTestDelegate navigationResponse]):
2478         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2479         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2480         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2481         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2482         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2483         (readRequest):
2484         (writeResponse):
2485         (TEST):
2486
2487 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2488
2489         Add modern API for overriding the page's specified viewport configuration
2490         https://bugs.webkit.org/show_bug.cgi?id=167734
2491         <rdar://problem/30331795>
2492
2493         Reviewed by Simon Fraser.
2494
2495         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2496         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2497
2498 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2499
2500         Add support for incremental bytecode cache updates
2501         https://bugs.webkit.org/show_bug.cgi?id=195000
2502
2503         Reviewed by Filip Pizlo.
2504
2505         Exit when the initial run to generate bytecode fails.
2506
2507         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2508
2509 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2510
2511         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2512         https://bugs.webkit.org/show_bug.cgi?id=196744
2513         <rdar://49415309>
2514
2515         Reviewed by Chris Dumez.
2516
2517         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2518         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2519
2520 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2521
2522         Add a way to opt into modern compatibility mode in layout tests
2523         https://bugs.webkit.org/show_bug.cgi?id=196770
2524         <rdar://problem/49777550>
2525
2526         Reviewed by Antoine Quint.
2527
2528         Add a new test option to enable modern compatibility mode in layout tests.
2529
2530         * WebKitTestRunner/TestController.cpp:
2531         (WTR::updateTestOptionsFromTestHeader):
2532         * WebKitTestRunner/TestController.h:
2533         * WebKitTestRunner/TestOptions.h:
2534         (WTR::TestOptions::hasSameInitializationOptions const):
2535         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2536         (WTR::TestController::platformCreateWebView):
2537         (WTR::TestController::enableModernCompatibilityMode):
2538
2539 2019-04-10  Andy Estes  <aestes@apple.com>
2540
2541         Try to fix the 32-bit watchOS build.
2542
2543         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2544         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2545
2546 2019-04-10  Antoine Quint  <graouts@apple.com>
2547
2548         Enable Pointer Events on watchOS
2549         https://bugs.webkit.org/show_bug.cgi?id=196771
2550         <rdar://problem/49040909>
2551
2552         Reviewed by Dean Jackson.
2553
2554         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2555
2556 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2557
2558         Unreviewed. Fix WPE accessibility tests after r244059.
2559
2560         We are failing to load the injected bundle due to undefined symbol
2561         AccessibilityUIElement::replaceTextInRange().
2562
2563         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2564         (WTR::AccessibilityUIElement::replaceTextInRange):
2565
2566 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2567
2568         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2569         https://bugs.webkit.org/show_bug.cgi?id=196727
2570
2571         Reviewed by Fujii Hironori.
2572
2573         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2574         (WebKitBrowserWindow::create):
2575
2576 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2577
2578         [ews-build] Add unit tests for PrintConfiguration
2579         https://bugs.webkit.org/show_bug.cgi?id=196752
2580
2581         Reviewed by Dewei Zhu.
2582
2583         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2584
2585 2019-04-09  Keith Rollin  <krollin@apple.com>
2586
2587         Unreviewed build maintenance -- update .xcfilelists.
2588
2589         * DumpRenderTree/DerivedSources-input.xcfilelist:
2590         * DumpRenderTree/DerivedSources-output.xcfilelist:
2591
2592 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2593
2594         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2595         https://bugs.webkit.org/show_bug.cgi?id=196743
2596         <rdar://problem/43897551>
2597
2598         Reviewed by Tim Horton.
2599
2600         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2601         (TEST):
2602
2603 2019-04-09  Youenn Fablet  <youenn@apple.com>
2604
2605         Close service worker database on network process suspension
2606         https://bugs.webkit.org/show_bug.cgi?id=196623
2607         <rdar://problem/48930869>
2608
2609         Reviewed by Alex Christensen.
2610
2611         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2612
2613 2019-04-09  Daniel Bates  <dabates@apple.com>
2614
2615         [iPad] Should open popover when the spacebar is pressed
2616         https://bugs.webkit.org/show_bug.cgi?id=196360
2617         <rdar://problem/49389129>
2618
2619         Reviewed by Brent Fulgham.
2620
2621         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2622
2623         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2624         (WTR::UIScriptController::isShowingPopover const): Added.
2625         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2626         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2627         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2628         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2629         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2630         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2631         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2632         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2633         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2634         (WTR::UIScriptController::isShowingPopover const): Added.
2635         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2636         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2637         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2638         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2639         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2640         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2641         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2642         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2643         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2644         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2645         (WTR::UIScriptController::isShowingPopover const): Added.
2646         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2647         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2648
2649 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2650
2651         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2652         https://bugs.webkit.org/show_bug.cgi?id=196665
2653         <rdar://45115669>
2654
2655         Reviewed by Geoff Garen.
2656
2657         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2658         (goBack):
2659         (+[SimpleLookupContext sharedLookupContext]):
2660         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2661         (TEST):
2662         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2663         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2664
2665 2019-04-09  John Wilander  <wilander@apple.com>
2666
2667         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2668         https://bugs.webkit.org/show_bug.cgi?id=196558
2669         <rdar://problem/47650245>
2670
2671         Reviewed by Youenn Fablet.
2672
2673         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2674         (TestWebKitAPI::TEST):
2675             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2676
2677 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2678
2679         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2680         https://bugs.webkit.org/show_bug.cgi?id=196720
2681
2682         Reviewed by Konstantin Tokarev.
2683
2684         * TestWebKitAPI/PlatformMac.cmake:
2685
2686 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2687
2688         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2689         https://bugs.webkit.org/show_bug.cgi?id=196694
2690         <rdar://problem/48388734>
2691
2692         Rubber-stamped by Aakash Jain.
2693
2694         * Scripts/webkitpy/port/image_diff.py:
2695         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2696         * Scripts/webkitpy/port/server_process.py:
2697         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2698         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2699         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2700         * Scripts/webkitpy/port/server_process_mock.py:
2701         (MockServerProcess.has_available_stdout):
2702         * Scripts/webkitpy/port/server_process_unittest.py:
2703         (TestServerProcess.serial_test_basic):
2704
2705 2019-04-09  Jer Noble  <jer.noble@apple.com>
2706
2707         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2708         https://bugs.webkit.org/show_bug.cgi?id=196097
2709
2710         Reviewed by Eric Carlson.
2711
2712         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2713
2714         * DumpRenderTree/mac/DumpRenderTree.mm:
2715         (resetWebPreferencesToConsistentValues):
2716         * WebKitTestRunner/TestController.cpp:
2717         (WTR::TestController::resetPreferencesToConsistentValues):
2718
2719 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2720
2721         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2722         https://bugs.webkit.org/show_bug.cgi?id=196690
2723
2724         Reviewed by Michael Catanzaro.
2725
2726         * QueueStatusServer/config/queues.py:
2727         * Scripts/webkitpy/common/config/ews.json:
2728         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2729         (test_ews_name):
2730
2731 2019-04-09  Chris Dumez  <cdumez@apple.com>
2732
2733         Loads using loadHTMLString() cause flashing when process-swapping
2734         https://bugs.webkit.org/show_bug.cgi?id=196714
2735         <rdar://problem/49637354>
2736
2737         Reviewed by Antti Koivisto.
2738
2739         Add API test coverage.
2740
2741         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2742
2743 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2744
2745         Unreviewed. Fix ATK accessibility tests after r244059.
2746
2747         We are failing to load the injected bundle due to undefined symbol
2748         AccessibilityUIElement::replaceTextInRange().
2749
2750         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2751         (WTR::AccessibilityUIElement::replaceTextInRange):
2752
2753 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2754
2755         AX: Support API: accessibilityReplaceRange:withText
2756         https://bugs.webkit.org/show_bug.cgi?id=196636
2757
2758         Unreviewed build fix for Windows port.
2759
2760         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2761         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2762
2763 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2764
2765         [CMake][WinCairo] Separate copied headers into different directories
2766         https://bugs.webkit.org/show_bug.cgi?id=196655
2767
2768         Reviewed by Michael Catanzaro.
2769
2770         * DumpRenderTree/CMakeLists.txt:
2771         * MiniBrowser/win/CMakeLists.txt:
2772         * TestWebKitAPI/CMakeLists.txt:
2773         * TestWebKitAPI/PlatformWin.cmake:
2774
2775 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2776
2777         Log stack-trace for run-webkit-tests when interrupted
2778         https://bugs.webkit.org/show_bug.cgi?id=176393
2779         <rdar://problem/34262310>
2780
2781         Reviewed by Lucas Forschler.
2782
2783         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2784         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2785         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2786         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2787         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2788         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2789         (main): Set handlers to log stack trace on interruption.
2790
2791 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2792
2793         AX: Support API: accessibilityReplaceRange:withText
2794         https://bugs.webkit.org/show_bug.cgi?id=196636
2795
2796         Unreviewed build fix for Windows port.
2797
2798         * DumpRenderTree/AccessibilityUIElement.cpp:
2799         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2800
2801 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2802
2803         [ews-build] Scripts using Buildbot API have CORS error
2804         https://bugs.webkit.org/show_bug.cgi?id=196709
2805
2806         Reviewed by Alexey Proskuryakov.
2807
2808         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2809
2810 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2811
2812         AX: Support API: accessibilityReplaceRange:withText
2813         https://bugs.webkit.org/show_bug.cgi?id=196636
2814
2815         Reviewed by Daniel Bates.
2816
2817         * DumpRenderTree/AccessibilityUIElement.cpp:
2818         (replaceTextInRangeCallback):
2819         (AccessibilityUIElement::replaceTextInRange):
2820         (AccessibilityUIElement::getJSClass):
2821         * DumpRenderTree/AccessibilityUIElement.h:
2822         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2823         (AccessibilityUIElement::replaceTextInRange):
2824         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2825         (AccessibilityUIElement::replaceTextInRange):
2826         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2827         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2828         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2829         (WTR::AccessibilityUIElement::replaceTextInRange):
2830         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2831         (WTR::AccessibilityUIElement::replaceTextInRange):
2832
2833 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2834
2835         [iOS] Do not allow starting selection drags when selection views are not visible
2836         https://bugs.webkit.org/show_bug.cgi?id=196686
2837         <rdar://problem/49399192>
2838
2839         Reviewed by Tim Horton.
2840
2841         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2842         also add some new API tests to cover scenarios where the web view is not first responder.
2843
2844         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2845         (TestWebKitAPI::TEST):
2846         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2847
2848         Add a switch to optionally make the web view first responder when starting the simulated drag.
2849
2850         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2851         (-[DragAndDropSimulator initWithWebView:]):
2852         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2853
2854 2019-04-08  Justin Fan  <justin_fan@apple.com>
2855
2856         [Web GPU] Fix Web GPU experimental feature on iOS
2857         https://bugs.webkit.org/show_bug.cgi?id=196632
2858
2859         Reviewed by Myles C. Maxfield.
2860
2861         Properly make Web GPU available on iOS 11+.
2862
2863         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2864
2865 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2866
2867         [ews-build] Do not upload archive when Compile Fails
2868         https://bugs.webkit.org/show_bug.cgi?id=196674
2869
2870         Reviewed by Alexey Proskuryakov.
2871
2872         * BuildSlaveSupport/ews-build/factories.py:
2873         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2874         * BuildSlaveSupport/ews-build/steps.py:
2875         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2876         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2877         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2878
2879 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2880
2881         Enable DFG on MIPS
2882         https://bugs.webkit.org/show_bug.cgi?id=196689
2883
2884         Reviewed by Žan Doberšek.
2885
2886         Since the bytecode change, we enabled the baseline JIT on mips in
2887         r240432, but DFG is still missing. With this change, all tests are
2888         passing on a ci20 board.
2889
2890         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2891
2892 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2893
2894         [Flatpak] Second run update-webkitwpe-flatpak fails
2895         https://bugs.webkit.org/show_bug.cgi?id=192702
2896
2897         Reviewed by Carlos Garcia Campos.
2898
2899         * flatpak/flatpakutils.py:
2900         (FlatpakObject.flatpak): Fix typo.
2901         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2902         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2903
2904 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2905
2906         [GTK][WPE] outlook.live.com displays old-fashioned UI
2907         https://bugs.webkit.org/show_bug.cgi?id=196642
2908
2909         Reviewed by Carlos Garcia Campos.
2910
2911         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2912         (TestWebKitAPI::TEST): New Mac platform quirk test.
2913
2914 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2915
2916         Unreviewed, rolling out r243956.
2917         https://bugs.webkit.org/show_bug.cgi?id=196688
2918
2919         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2920         by aakashjain on #webkit).
2921
2922         Reverted changeset:
2923
2924         "Clicking "Go Back" from a safe browsing warning from an
2925         iframe should navigate the WKWebView back to the previous
2926         page"
2927         https://bugs.webkit.org/show_bug.cgi?id=196665
2928         https://trac.webkit.org/changeset/243956
2929
2930 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2931
2932         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2933         https://bugs.webkit.org/show_bug.cgi?id=196669
2934
2935         Reviewed by Geoffrey Garen.
2936
2937         Added three new unit tests for WeakHashSet.
2938
2939         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2940         (WTF_WeakPtr.WeakHashSetConstObjects):
2941         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2942         (WTF_WeakPtr.WeakHashSetComputeSize):
2943
2944 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2945
2946         Hide next and previous form control buttons when WKWebView is editable
2947         https://bugs.webkit.org/show_bug.cgi?id=196672
2948         <rdar://problem/35625321>
2949
2950         Reviewed by Tim Horton.
2951
2952         Add a new API test.
2953
2954         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2955         (-[TestWKWebView lastTrailingBarButtonGroup]):
2956         (TestWebKitAPI::TEST):
2957         * TestWebKitAPI/ios/UIKitSPI.h:
2958
2959 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2960
2961         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
2962         https://bugs.webkit.org/show_bug.cgi?id=196077
2963         <rdar://problem/49108202>
2964
2965         Reviewed by Chris Dumez.
2966
2967         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
2968         on new web view.
2969
2970         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2971
2972 2019-04-05  Saam Barati  <sbarati@apple.com>
2973
2974         Make compare-results understand MotionMark
2975         https://bugs.webkit.org/show_bug.cgi?id=196666
2976
2977         Reviewed by Yusuke Suzuki.
2978
2979         * Scripts/compare-results:
2980         (PLT5Results):
2981         (detectMotionMark):
2982         (detectMotionMark1_1):
2983         (motionMarkResults):
2984         (motionMark1_1Results):
2985         (detectBenchmark):
2986         (biggerIsBetter):
2987         (main):
2988
2989 2019-04-05  Alex Christensen  <achristensen@webkit.org>
2990
2991         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2992         https://bugs.webkit.org/show_bug.cgi?id=196665
2993         <rdar://45115669>
2994
2995         Reviewed by Geoff Garen.
2996
2997         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2998         (goBack):
2999         (+[SimpleLookupContext sharedLookupContext]):
3000         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3001         (TEST):
3002         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3003         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3004
3005 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3006
3007         [ews-build] Add configuration and architecture for windows builders
3008         https://bugs.webkit.org/show_bug.cgi?id=196660
3009
3010         Reviewed by Lucas Forschler.
3011
3012         * BuildSlaveSupport/ews-build/config.json:
3013
3014 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3015
3016         webkitpy: Don't run subsequent rounds if interrupted
3017         https://bugs.webkit.org/show_bug.cgi?id=196646
3018
3019         Reviewed by Aakash Jain.
3020
3021         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3022         (Manager.run): Bail out if interrupted.
3023
3024 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3025
3026         Test sessionStorage in PSON private browsing mode
3027         https://bugs.webkit.org/show_bug.cgi?id=196561
3028
3029         Reviewed by Alex Christensen.
3030
3031         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3032
3033 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3034
3035         Unreviewed, rolling out r243833.
3036         https://bugs.webkit.org/show_bug.cgi?id=196645
3037
3038         This change breaks build of WPE and GTK ports (Requested by
3039         annulen on #webkit).
3040
3041         Reverted changeset:
3042
3043         "[CMake][WTF] Mirror XCode header directories"
3044         https://bugs.webkit.org/show_bug.cgi?id=191662
3045         https://trac.webkit.org/changeset/243833
3046
3047 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3048
3049         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3050         https://bugs.webkit.org/show_bug.cgi?id=196635
3051
3052         Reviewed by Antti Koivisto.
3053         
3054         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3055         for a test to enable async frame scrolling via:
3056             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3057         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3058         
3059         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3060
3061         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3062         (WTR::InjectedBundle::beginTesting):
3063         * WebKitTestRunner/TestController.cpp:
3064         (WTR::TestController::resetPreferencesToConsistentValues):
3065
3066 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3067
3068         Use a correct LC_RPATH when building with ASan
3069         https://bugs.webkit.org/show_bug.cgi?id=196576
3070
3071         Reviewed by David Kilzer.
3072
3073         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3074         so that ../Frameworks is checked. This is simpler and more reliable than updating
3075         each SPC service xcconfig.
3076
3077 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3078
3079         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3080         https://bugs.webkit.org/show_bug.cgi?id=196629
3081
3082         Reviewed by Lucas Forschler.
3083
3084         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3085
3086 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3087
3088         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3089         https://bugs.webkit.org/show_bug.cgi?id=196618
3090
3091         Reviewed by Lucas Forschler.
3092
3093         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3094         (StatusBubble): Added QUEUE_TRIGGERS.
3095         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3096         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3097         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
3098         its parent(builder).
3099
3100 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3101
3102         [ews-app] Status-bubble steps are sometimes displayed in reverse order
3103         https://bugs.webkit.org/show_bug.cgi?id=196625
3104
3105         Reviewed by Lucas Forschler.
3106
3107         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3108         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
3109
3110 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3111
3112         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
3113         https://bugs.webkit.org/show_bug.cgi?id=196630
3114
3115         Reviewed by Wenson Hsieh.
3116
3117         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3118
3119 2019-04-04  Youenn Fablet  <youenn@apple.com>
3120
3121         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
3122         https://bugs.webkit.org/show_bug.cgi?id=196543
3123
3124         Reviewed by Alex Christensen.
3125
3126         * WebKitTestRunner/TestController.cpp:
3127         (WTR::TestController::generatePageConfiguration):
3128
3129 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3130
3131         [ews-app] Status bubble should not display skipped buildbot steps
3132         https://bugs.webkit.org/show_bug.cgi?id=196584
3133
3134         Reviewed by Lucas Forschler.
3135
3136         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3137
3138 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3139
3140         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
3141         https://bugs.webkit.org/show_bug.cgi?id=196620
3142
3143         Reviewed by Lucas Forschler.
3144
3145         * BuildSlaveSupport/ews-app/ews/config.py:
3146
3147 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
3148
3149         [Win] DumpRenderTreeWatchDog.py is not checked into source
3150         https://bugs.webkit.org/show_bug.cgi?id=196567
3151         <rdar://problem/49525901>
3152
3153         Reviewed by Lucas Forschler.
3154
3155         This script is used on Win EWS bots to terminate hanging DRT processes.
3156
3157         * EWSTools/dumprendertreewatchdog.py: Added.
3158
3159 2019-04-04  Chris Dumez  <cdumez@apple.com>
3160
3161         Unreviewed, roll out r243858 which made tests time out.
3162
3163         Disable new API tests on Windows instead.
3164
3165         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3166         (TestWebKitAPI::TEST):
3167
3168 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3169
3170         [ATK] Cleanup WebPageAccessibilityObjectAtk
3171         https://bugs.webkit.org/show_bug.cgi?id=196537
3172
3173         Reviewed by Michael Catanzaro.
3174
3175         Also consider files under atk directories as exceptions for GObject conventions.
3176
3177         * Scripts/webkitpy/style/checkers/cpp.py:
3178         (check_identifier_name_in_declaration):
3179
3180 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3181
3182         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3183         https://bugs.webkit.org/show_bug.cgi?id=196588
3184         <rdar://problem/49365787>
3185
3186         Unreviewed build fix for Windows port.
3187
3188         error C3861: 'kill': identifier not found
3189
3190         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3191         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
3192
3193 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3194
3195         [ews-build] Cancel build and similar operations should have authentication
3196         https://bugs.webkit.org/show_bug.cgi?id=196520
3197
3198         Reviewed by Dewei Zhu.
3199
3200         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
3201         environment variables.
3202
3203 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3204
3205         [ews-build] Do not trigger queues which are not in production yet
3206         https://bugs.webkit.org/show_bug.cgi?id=196581
3207
3208         Reviewed by Dewei Zhu.
3209
3210         * BuildSlaveSupport/ews-build/config.json:
3211
3212 2019-04-03  Chris Dumez  <cdumez@apple.com>
3213
3214         Unreviewed, fix typo in the name of API test added in r243848.
3215
3216         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3217         (TestWebKitAPI::TEST):
3218
3219 2019-04-03  Chris Dumez  <cdumez@apple.com>
3220
3221         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3222         https://bugs.webkit.org/show_bug.cgi?id=196588
3223         <rdar://problem/49365787>
3224
3225         Reviewed by Ryosuke Niwa.
3226
3227         Add API test coverage.
3228
3229         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3230         (TestWebKitAPI::nullJavaScriptCallback):
3231         (TestWebKitAPI::didCrashCheckFrames):
3232         (TestWebKitAPI::TEST):
3233
3234 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3235
3236         run-webkit-tests: Upload test results (new results database)
3237         https://bugs.webkit.org/show_bug.cgi?id=196577
3238         <rdar://problem/34841155>
3239
3240         Reviewed by Lucas Forschler.
3241
3242         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3243         (Manager.run): Upload results after each device shard, since the configuration will be
3244         different for each device.
3245         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3246         uploaded to a results database.
3247         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3248         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3249
3250 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3251
3252         -apple-trailing-word is needed for browser detection
3253         https://bugs.webkit.org/show_bug.cgi?id=196575
3254
3255         Unreviewed.
3256
3257         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3258
3259 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3260
3261         [CMake][WTF] Mirror XCode header directories
3262         https://bugs.webkit.org/show_bug.cgi?id=191662
3263
3264         Reviewed by Konstantin Tokarev.
3265
3266         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3267         builds.
3268
3269         * CMakeLists.txt:
3270         * DumpRenderTree/CMakeLists.txt:
3271         * DumpRenderTree/PlatformWin.cmake:
3272         * MiniBrowser/win/CMakeLists.txt:
3273         * TestWebKitAPI/CMakeLists.txt:
3274         * TestWebKitAPI/PlatformWin.cmake:
3275         * WebKitTestRunner/PlatformGTK.cmake:
3276         * WebKitTestRunner/PlatformWin.cmake:
3277
3278 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3279
3280         [ews-app] Status bubble should not display certain infrastructure status messages
3281         https://bugs.webkit.org/show_bug.cgi?id=196550
3282
3283         Reviewed by Lucas Forschler.
3284
3285         Do not display the steps which are un-needed for end-user. This information is still avaiable
3286         if the user click on the bubble and look at the Buildbot build.
3287         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3288         (StatusBubble._steps_messages):
3289         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
3290
3291 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3292
3293         [ews-build] Use https for sending data to ews-app
3294         https://bugs.webkit.org/show_bug.cgi?id=196492
3295
3296         Reviewed by Lucas Forschler.
3297
3298         * BuildSlaveSupport/ews-build/events.py:
3299
3300 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3301
3302         Remove support for -apple-trailing-word
3303         https://bugs.webkit.org/show_bug.cgi?id=196525
3304
3305         Reviewed by Zalan Bujtas.
3306
3307         This CSS property is nonstandard and not used.
3308
3309         * Scripts/webkitperl/FeatureList.pm:
3310         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3311
3312 2019-04-03  Youenn Fablet  <youenn@apple.com>
3313
3314         Add a test for DOMCache on multiple browsing in case of private browsing
3315         https://bugs.webkit.org/show_bug.cgi?id=196524
3316
3317         Reviewed by Alex Christensen.
3318
3319         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3320         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
3321
3322 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3323
3324         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
3325         https://bugs.webkit.org/show_bug.cgi?id=196540
3326
3327         Reviewed by Aakash Jain.
3328
3329         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
3330
3331 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3332
3333         Add plumbing for a compatibility mode preference in WebKit
3334         https://bugs.webkit.org/show_bug.cgi?id=196005
3335
3336         Reviewed by Tim Horton.
3337
3338         Add new API tests.
3339
3340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3341         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
3342
3343 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
3344
3345         [WPE][GTK] Update libsrtp dependency package for Debian
3346         https://bugs.webkit.org/show_bug.cgi?id=196528
3347
3348         Reviewed by Frédéric Wang.
3349
3350         * gtk/install-dependencies:
3351         * wpe/install-dependencies:
3352
3353 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3354
3355         [WK2] Add support for Window's beforeprint / afterprint events
3356         https://bugs.webkit.org/show_bug.cgi?id=196478
3357         <rdar://problem/49535124>
3358
3359         Unreviewed build fix for MSVC.
3360
3361         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
3362
3363         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
3364
3365         * WebKitTestRunner/TestController.cpp:
3366         (WTR::printFrame): Use int and float literals.
3367
3368 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3369
3370         [ews-build] Reassign bots to queues
3371
3372         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
3373
3374 2019-04-02  Chris Dumez  <cdumez@apple.com>
3375
3376         [WK2] Add support for Window's beforeprint / afterprint events
3377         https://bugs.webkit.org/show_bug.cgi?id=196478
3378
3379         Reviewed by Alex Christensen.
3380
3381         Add minimal implementation for printFrame in WebKitTestRunner.
3382
3383         * WebKitTestRunner/TestController.cpp:
3384         (WTR::printFrame):
3385         (WTR::TestController::createOtherPage):
3386         (WTR::TestController::createWebViewWithOptions):
3387
3388 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3389
3390         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
3391         https://bugs.webkit.org/show_bug.cgi?id=196491
3392
3393         Reviewed by Lucas Forschler.
3394
3395         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3396
3397 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3398
3399         [ews-build] Configure buildbot try credentials in environment variables
3400         https://bugs.webkit.org/show_bug.cgi?id=196501
3401
3402         Reviewed by Lucas Forschler.
3403
3404         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
3405         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
3406         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
3407
3408 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3409
3410         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
3411         https://bugs.webkit.org/show_bug.cgi?id=196496
3412         <rdar://problem/49521634>
3413
3414         Reviewed by Chris Dumez.
3415
3416         Add new API tests (see WebKit ChangeLog for more detail).
3417
3418         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3419         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3420         (TEST):
3421
3422 2019-04-02  David Kilzer  <ddkilzer@apple.com>
3423
3424         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
3425         <https://webkit.org/b/196499>
3426
3427         Reviewed by Alexey Proskuryakov.
3428
3429         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
3430         ENABLE_ADDRESS_SANITIZER.
3431
3432 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3433
3434         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
3435         https://bugs.webkit.org/show_bug.cgi?id=182757
3436
3437         Reviewed by Don Olmstead.
3438
3439         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
3440         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3441
3442 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
3443
3444         run-api-tests: Upload test results
3445         https://bugs.webkit.org/show_bug.cgi?id=196323
3446         <rdar://problem/49356714>
3447
3448         Reviewed by Lucas Forschler.
3449
3450         * Scripts/webkitpy/api_tests/manager.py:
3451         (Manager):
3452         (Manager.run): Upload results to a results database.
3453         * Scripts/webkitpy/api_tests/run_api_tests.py:
3454         (parse_args): Add upload arguments.
3455         * Scripts/webkitpy/port/base.py:
3456         (Port):
3457         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
3458         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
3459         with commits from any other associated repositories.
3460         * Scripts/webkitpy/port/device.py:
3461         (Device):
3462         (Device.build_version): Access build_versoin of underlying platform device.
3463         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3464         (IOSSimulatorTest):
3465         (IOSSimulatorTest.test_configuration_for_upload):
3466         * Scripts/webkitpy/port/device_port.py:
3467         (DevicePort):
3468         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
3469         the same as the machine uploading results.
3470         * Scripts/webkitpy/port/mac.py:
3471         (MacPort):
3472         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3473         * Scripts/webkitpy/port/mac_unittest.py:
3474         (MacTest):
3475         (MacTest.test_configuration_for_upload):
3476         * Scripts/webkitpy/xcode/simulated_device.py:
3477         (SimulatedDeviceManager._create_device_with_runtime):
3478         (SimulatedDevice.__init__): Create simulated device with a build_version.
3479         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3480         (test_existing_simulator):
3481
3482 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3483
3484         Remove extra newline characters (Follow-up fix to r243707)
3485
3486         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3487
3488 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3489
3490         [ews-app] Use API_KEY to accept results data
3491         https://bugs.webkit.org/show_bug.cgi?id=196461
3492
3493         Reviewed by Dewei Zhu.
3494
3495         * BuildSlaveSupport/ews-app/ews/views/results.py:
3496         (Results.post): Validate EWS_API_KEY before accepting any data.
3497         * BuildSlaveSupport/ews-build/events.py:
3498         (Events.sendData): Send EWS_API_KEY if available along with event data.
3499
3500 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3501
3502         Unable to copy and paste a PDF from Notes into Mail compose body
3503         https://bugs.webkit.org/show_bug.cgi?id=196442
3504         <rdar://problem/48573098>
3505
3506         Reviewed by Tim Horton.
3507
3508         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3509         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3510         to be specified on the item providers.
3511
3512         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3513         (TestWebKitAPI::mapItemForTesting):
3514         (TestWebKitAPI::contactItemForTesting):
3515
3516 2019-04-01  Tim Horton  <timothy_horton@apple.com>
3517
3518         Make UIWKDocumentContext rects per-character instead of per-word
3519         https://bugs.webkit.org/show_bug.cgi?id=196459
3520
3521         Reviewed by Wenson Hsieh.
3522
3523         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3524         (TEST):
3525         Adjust test results due to switching to per-character rects.
3526
3527 2019-04-01  Chris Dumez  <cdumez@apple.com>
3528
3529         UIProcess crash when a prewarmed process is terminated
3530         https://bugs.webkit.org/show_bug.cgi?id=196451
3531         <rdar://problem/49245471>
3532
3533         Reviewed by Geoffrey Garen.
3534
3535         Add API test coverage.
3536
3537         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3538         (TEST):
3539
3540 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3541
3542         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
3543         https://bugs.webkit.org/show_bug.cgi?id=196449
3544
3545         Reviewed by Lucas Forschler.
3546
3547         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3548         (StatusBubble.get_os_details): Method to get OS and Xcode details.
3549         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
3550         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
3551
3552 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3553
3554         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
3555         https://bugs.webkit.org/show_bug.cgi?id=196444
3556
3557         Reviewed by Lucas Forschler.
3558
3559         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
3560
3561 2019-04-01  Alex Christensen  <achristensen@webkit.org>
3562
3563         Add SPI to canonicalize NSURLs with WTF::URL
3564         https://bugs.webkit.org/show_bug.cgi?id=196415
3565         <rdar://problem/44980271>
3566
3567         Reviewed by Darin Adler.
3568
3569         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3570         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
3571         (TestWebKitAPI::TEST):
3572
3573 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
3574
3575         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
3576         https://bugs.webkit.org/show_bug.cgi?id=196441
3577
3578         Reviewed by Carlos Garcia Campos.
3579
3580         Don't cache the wpe_view_backend object that might not exist yet at the
3581         time of EventSenderProxy constructor invocation, but instead retrieve
3582         that object whenever it's required for event dispatching. This should
3583         avoid crashes in this constructor now that it's invoked before any
3584         PlatformWindow has been set up (as changed in r243496).
3585
3586         * WebKitTestRunner/EventSenderProxy.h:
3587         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3588         (WTR::viewBackend):
3589         (WTR::EventSenderProxy::EventSenderProxy):
3590         (WTR::EventSenderProxy::mouseDown):
3591         (WTR::EventSenderProxy::mouseUp):
3592         (WTR::EventSenderProxy::mouseMoveTo):
3593         (WTR::EventSenderProxy::mouseScrollBy):
3594         (WTR::EventSenderProxy::keyDown):
3595         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3596
3597 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3598
3599         [Win][WebKit] MiniBrowser should support high DPI display
3600         https://bugs.webkit.org/show_bug.cgi?id=196391
3601
3602         Reviewed by Alex Christensen.
3603
3604         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3605         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3606         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3607         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3608
3609 2019-03-31  Sam Weinig  <weinig@apple.com>
3610
3611         Remove more i386 specific configurations
3612         https://bugs.webkit.org/show_bug.cgi?id=196430
3613
3614         Reviewed by Alexey Proskuryakov.
3615
3616         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3617         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3618
3619 2019-03-31  Andy Estes  <aestes@apple.com>
3620
3621         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3622         https://bugs.webkit.org/show_bug.cgi?id=196433
3623         <rdar://problem/49293305>
3624
3625         Reviewed by Tim Horton.
3626
3627         Enhanced API test coverage to include all navigation response policy decisions in both
3628         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3629
3630         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3631         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3632         (TestWebKitAPI::TEST):
3633         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3634         (readFile):
3635         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3636         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3637         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3638         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3639         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3640         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3641         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3642         (-[QuickLookDelegate _downloadDidStart:]):
3643         (-[QuickLookDelegate _download:didReceiveResponse:]):
3644         (-[QuickLookDelegate _download:didReceiveData:]):
3645         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3646         (-[QuickLookDelegate _downloadDidFinish:]):
3647         (-[QuickLookDelegate _download:didFailWithError:]):
3648         (-[QuickLookDelegate _downloadDidCancel:]):
3649         (-[QuickLookDelegate verifyDownload]):
3650         (runTest):
3651         (runTestDecideBeforeLoading):
3652         (runTestDecideAfterLoading):
3653         (TEST):
3654         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3655         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3656         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3657         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3658         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3659         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3660         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3661         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3662         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3663         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3664         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3665         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3666         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3667         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3668
3669 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3670
3671         [CMake] add testdfg as target with build-jsc
3672         https://bugs.webkit.org/show_bug.cgi?id=196393
3673
3674         Reviewed by Saam Barati.
3675
3676         Added testdfg as one of the targets to build when
3677         using CMake.
3678
3679         * Scripts/build-jsc:
3680
3681 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3682
3683         Delete WebMetal implementation in favor of WebGPU
3684         https://bugs.webkit.org/show_bug.cgi?id=195418
3685
3686         Reviewed by Dean Jackson.
3687
3688         * DumpRenderTree/mac/DumpRenderTree.mm:
3689         (enableExperimentalFeatures):
3690         (resetWebPreferencesToConsistentValues):
3691         * Scripts/webkitperl/FeatureList.pm:
3692         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3694         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3695         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3696         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3697         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3698         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3699         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3700         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3701         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3702         (WTR::InjectedBundle::beginTesting):
3703         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3704         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3705         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3706
3707 2019-03-29  Chris Dumez  <cdumez@apple.com>
3708
3709         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3710         https://bugs.webkit.org/show_bug.cgi?id=196405
3711         <rdar://problem/49428130>
3712
3713         Reviewed by Wenson Hsieh.
3714
3715         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3716         the popover presentation methods to be no-ops. Use this in the new test added in
3717         r243523 so that we do not swizzle those methods for all tests. This is needed because
3718         those WatchOS tests rely on the popover getting presented and interactive.
3719
3720         * WebKitTestRunner/TestController.cpp:
3721         (WTR::updateTestOptionsFromTestHeader):
3722         * WebKitTestRunner/TestController.h:
3723         * WebKitTestRunner/TestOptions.h:
3724         (WTR::TestOptions::hasSameInitializationOptions const):
3725         * WebKitTestRunner/ios/TestControllerIOS.mm:
3726         (WTR::TestController::platformInitialize):
3727         (WTR::TestController::platformResetStateToConsistentValues):
3728
3729 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3730
3731         [Curl] Add Server Trust Evaluation Support.
3732         https://bugs.webkit.org/show_bug.cgi?id=191646
3733
3734         Reviewed by Fujii Hironori.
3735
3736         Implemented MiniBrowser UI for asking if user trusts the server.
3737
3738         * MiniBrowser/win/Common.cpp:
3739         (askServerTrustEvaluation):
3740         (replaceString):
3741         * MiniBrowser/win/Common.h:
3742         * MiniBrowser/win/MiniBrowserLib.rc:
3743         * MiniBrowser/win/MiniBrowserLibResource.h:
3744         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3745         (createPEMString):
3746         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3747         (WebKitBrowserWindow::canTrustServerCertificate):
3748         * MiniBrowser/win/WebKitBrowserWindow.h:
3749
3750 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3751
3752         Implement ResizeObserver.
3753         https://bugs.webkit.org/show_bug.cgi?id=157743
3754
3755         Reviewed by Simon Fraser.
3756
3757         Support resizeObserverEnabled webPreferences.
3758
3759         * DumpRenderTree/TestOptions.cpp:
3760         (TestOptions::TestOptions):
3761         * DumpRenderTree/TestOptions.h:
3762         * DumpRenderTree/mac/DumpRenderTree.mm:
3763         (setWebPreferencesForTestOptions):
3764         * DumpRenderTree/win/DumpRenderTree.cpp:
3765         (enableExperimentalFeatures):
3766         * Scripts/webkitperl/FeatureList.pm:
3767         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3768
3769 2019-03-28  John Wilander  <wilander@apple.com>
3770
3771         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3772         https://bugs.webkit.org/show_bug.cgi?id=196281
3773         <rdar://problem/48938748>
3774
3775         Reviewed by Alex Christensen.
3776
3777         This patch adds the function isStatisticsHasLocalStorage() to the
3778         TestRunner. With it, the page can query the WebsiteDataStore in the
3779         UI process to make sure that it sees LocalStorage.
3780
3781         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3782         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3783         (WTR::TestRunner::isStatisticsHasLocalStorage):
3784         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3785         * WebKitTestRunner/TestController.cpp:
3786         (WTR::TestController::isStatisticsHasLocalStorage):
3787         * WebKitTestRunner/TestController.h:
3788         * WebKitTestRunner/TestInvocation.cpp:
3789         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3790
3791 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3792
3793         API::Data::createWithoutCopying should do a null check before calling CFRelease
3794         https://bugs.webkit.org/show_bug.cgi?id=196276
3795         <rdar://problem/48059859>
3796
3797         Reviewed by Alex Christensen.
3798
3799         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3800
3801         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3802         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3803         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3804         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3805         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3806         (TestWebKitAPI::TEST):
3807
3808 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3809
3810         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3811         https://bugs.webkit.org/show_bug.cgi?id=186276
3812
3813         Reviewed by Carlos Garcia Campos.
3814
3815         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3816         (webViewLoadChanged):
3817         (testWebResourceGetDataError):
3818         (testWebResourceGetDataEmpty):
3819         (beforeAll):
3820         (webViewloadChanged): Deleted.
3821
3822 2019-03-27  Andy Estes  <aestes@apple.com>
3823
3824         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3825         https://bugs.webkit.org/show_bug.cgi?id=196317
3826
3827         Reviewed by Dan Bernstein.
3828
3829         package-root copies built products into a staging directory using ditto(1), which does not
3830         follow symbolic links as it traverses a directory. Now that the files in
3831         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3832         itself, these become broken links when ditto'd into the staging directory.
3833
3834         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3835
3836         * Scripts/package-root:
3837
3838 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3839
3840         [ews-app] Update display text of Submit for ews analysis
3841         https://bugs.webkit.org/show_bug.cgi?id=196309
3842
3843         Reviewed by Dewei Zhu.
3844
3845         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3846
3847 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3848
3849         run-webkit-tests should check for leaks in WebKit processes
3850         <https://webkit.org/b/193772>
3851         <rdar://problem/46526680>
3852
3853         Reviewed by Ryosuke Niwa.
3854
3855         This works by doing the following:
3856         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3857           The list of child processes are returned one per line:
3858           process.name: pid
3859         - Run the "#LIST CHILD PROCESSES" command just before the
3860           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3861           processes on the ServerProcess object.
3862         - When the `--leaks` switch is handled, run check_for_leaks() on
3863           each child process after the main test harness.
3864
3865         * DumpRenderTree/mac/DumpRenderTree.mm:
3866         (handleControlCommand):
3867         - Use strncmp() instead of strcmp().
3868         - Add support for handling "#LIST CHILD PROCESSES" command.
3869
3870         * Scripts/webkitpy/port/base.py:
3871         (Port.check_for_leaks):
3872         * Scripts/webkitpy/port/darwin.py:
3873         (DarwinPort.check_for_leaks):
3874         - Rename redundant 'process_pid' argument to 'process_id'.
3875
3876         * Scripts/webkitpy/port/driver.py:
3877         (Driver.do_post_tests_work):
3878         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3879           longer the only command this sends to WebKitTestRunner.
3880         - If the `--leaks` switch is present, send the
3881           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3882           result using Port.set_webkit_processes().
3883         (Driver._parse_child_processes_output):
3884         - Add helper method to parse list of child process names and
3885           process IDs returned from WebKitTestRunner.
3886
3887         * Scripts/webkitpy/port/ios_device.py:
3888         (IOSDevicePort.check_for_leaks):
3889         - Rename redundant 'process_pid' argument to 'process_id'.
3890
3891         * Scripts/webkitpy/port/leakdetector.py:
3892         (LeakDetector._parse_leaks_output):
3893         - Return early if there is no leaks_output.
3894         (LeakDetector.check_for_leaks):
3895         - Rename redundant 'process_pid' argument to 'process_id'.
3896
3897         * Scripts/webkitpy/port/server_process.py:
3898         (ServerProcess.__init__):
3899         (ServerProcess.child_processes):
3900         (ServerProcess.set_child_processes):
3901         - Add instance variable to Port to store list of child process
3902           names and process IDs returned from WebKitTestRunner.
3903         (ServerProcess._start):
3904         - Clear self._child_processes.
3905         (ServerProcess.stop):
3906         - If self._child_processes is set, call
3907           self._port.check_for_leaks() for each child process.
3908
3909         * Scripts/webkitpy/port/server_process_unittest.py:
3910         (TrivialMockPort.check_for_leaks):
3911         - Rename redundant 'process_pid' argument to 'process_id'.
3912
3913         * Scripts/webkitpy/port/simulator_process.py:
3914         (SimulatorProcess.stop):
3915         - If self._child_processes is set, call
3916           self._port.check_for_leaks() for each child process.
3917
3918         * Scripts/webkitpy/port/watch_device.py:
3919         (WatchDevicePort.check_for_leaks):
3920         - Rename redundant 'process_pid' argument to 'process_id'.
3921
3922         * WebKitTestRunner/TestController.cpp:
3923         (WTR::TestController::dumpResponse):
3924         - Extract method from findAndDumpWorldLeaks() so that it may be
3925           reused by findAndDumpWebKitProcessIdentifiers().
3926         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3927         - Add method to output process name and process ID of both the
3928           WebContent and Networking processes.
3929         (WTR::TestController::findAndDumpWorldLeaks):
3930         - Fix missing newline in output when there were no abandoned
3931           documents.
3932         - Call dumpResponse() for extracted code.
3933         (WTR::TestController::handleControlCommand):
3934         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3935         - Use strncmp() instead of strcmp().
3936         - Call findAndDumpWebKitProcessIdentifiers() when
3937           "#LIST CHILD PROCESSES" command is sent.
3938         * WebKitTestRunner/TestController.h:
3939         (WTR::TestController::dumpResponse):
3940         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3941         - Declare methods.
3942
3943 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3944
3945         Unreviewed. Add GLib API test cases after r243434.
3946
3947         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3948         (testWebViewActiveURI):
3949         (serverCallback):
3950         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3951         (sendRequestCallback):
3952
3953 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3954
3955         Geolocation request not complete when watch request was started in a different web process
3956         https://bugs.webkit.org/show_bug.cgi?id=195996
3957
3958         Reviewed by Alex Christensen.
3959
3960         Add a test case.
3961
3962         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3963         (TestWebKitAPI::runJavaScriptAlert):
3964         (TestWebKitAPI::TEST):
3965
3966 2019-03-26  Keith Rollin  <krollin@apple.com>
3967
3968         Update the way generate-xcfilelists returns strings from functions
3969         https://bugs.webkit.org/show_bug.cgi?id=195975
3970         <rdar://problem/49040807>
3971
3972         Reviewed by Dean Jackson.
3973
3974         There are places where generate-xcfilelists executes assignments with
3975         statements like:
3976
3977             FOO=$(some_function)
3978
3979         where "some_function" return a string by echoing it. E.g.
3980
3981             some_function()
3982             {
3983                 echo "Hello, World"
3984             }
3985
3986         This is a common idiom, but it has a problem if "some_function" needs
3987         to call "exit" in an attempt to halt the entire script right then and
3988         there. Since "some_function" is called inside of $(), it's being
3989         executed in a sub-shell. Calling exit in that sub-shell simply exits
3990         that shell; it doesn't not exit the outer shell in which the main part
3991         of the script is still running. As such, the main script keeps
3992         executing when the intent was for the script to halt.
3993
3994         The solution to this is to use a different idiom for returning
3995         strings. The one we now is to pass in the name of the variable to
3996         receive the string result:
3997
3998             some_function()
3999             {
4000                 variable_name=$1
4001                 eval $variable_name ="Hello, World"
4002             }
4003
4004         The call site now looks like
4005
4006             some_function FOO
4007
4008         Because there's no invocation of a sub-shell, some_function can now
4009         call "exit" if it wants to, and the entire script will exit at that
4010         point.
4011
4012         * Scripts/generate-xcfilelists:
4013
4014 2019-03-26  Chris Dumez  <cdumez@apple.com>
4015
4016         Add basic layout test coverage for File Picker on iOS
4017         https://bugs.webkit.org/show_bug.cgi?id=196265
4018
4019         Reviewed by Wenson Hsieh.
4020
4021         Add layout test infrastructure to test the file picker on iOS.
4022
4023         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4024         (WTR::UIScriptController::dismissFilePicker):
4025         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4026         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4027         (WTR::UIScriptController::dismissFilePicker):
4028         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4029         * WebKitTestRunner/TestController.cpp:
4030         (WTR::TestController::createWebViewWithOptions):
4031         (WTR::updateTestOptionsFromTestHeader):
4032         * WebKitTestRunner/TestOptions.h:
4033         (WTR::TestOptions::hasSameInitializationOptions const):
4034         * WebKitTestRunner/ios/TestControllerIOS.mm:
4035         (overridePresentViewController):
4036         (WTR::TestController::platformInitialize):
4037         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4038         (WTR::UIScriptController::dismissFilePicker):
4039
4040 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
4041
4042         Implement async paste method on UIWKInteractionViewProtocol
4043         https://bugs.webkit.org/show_bug.cgi?id=196267
4044         <rdar://problem/49236346>
4045
4046         Reviewed by Tim Horton.
4047
4048         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
4049         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
4050         are now a part of all iOS 12 internal SDKs.
4051
4052         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
4053
4054         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
4055         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
4056
4057         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
4058         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4059         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
4060         * TestWebKitAPI/ios/UIKitSPI.h:
4061
4062 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4063
4064         [ews-build] Use PostgreSQL for ews.webkit.org database
4065         https://bugs.webkit.org/show_bug.cgi?id=196270
4066
4067         Reviewed by Lucas Forschler.
4068
4069         * BuildSlaveSupport/ews-app/ews-app/settings.py:
4070
4071 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
4072
4073         [ews] Reset simctl states on reboot
4074         https://bugs.webkit.org/show_bug.cgi?id=196260
4075
4076         Rubber-stamped by Aakash Jain.
4077
4078         * EWSTools/start-queue-mac.sh:
4079
4080 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4081
4082         [ews-build] Use PostgreSQL for ews-build database
4083         https://bugs.webkit.org/show_bug.cgi?id=196229
4084
4085         Reviewed by Lucas Forschler.
4086
4087         * BuildSlaveSupport/ews-build/master.cfg:
4088
4089 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4090
4091         [ews-build] Get master_hostname dynamically in master.cfg
4092         https://bugs.webkit.org/show_bug.cgi?id=196255
4093
4094         Reviewed by Lucas Forschler.
4095
4096         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
4097         send events data in test mode.
4098
4099 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4100
4101         [ews-app] Set db_constraint to False for Foreign Keys
4102         https://bugs.webkit.org/show_bug.cgi?id=196252
4103
4104         Reviewed by Lucas Forschler.
4105
4106         * BuildSlaveSupport/ews-app/ews/models/build.py:
4107         * BuildSlaveSupport/ews-app/ews/models/step.py:
4108
4109 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4110
4111         [ews-build] is_test_mode_enabled should default to True
4112         https://bugs.webkit.org/show_bug.cgi?id=196248
4113
4114         Reviewed by Lucas Forschler.
4115
4116         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
4117
4118 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4119
4120         [ews-app] Add webkitperl to ENABLED_QUEUES
4121         https://bugs.webkit.org/show_bug.cgi?id=196253
4122
4123         Reviewed by Lucas Forschler.
4124
4125         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4126
4127 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
4128
4129         Address NSWindow sometimes using WebKitTestRunnerEvent too early
4130         https://bugs.webkit.org/show_bug.cgi?id=196211
4131         rdar://problem/49110552
4132
4133         Reviewed by Tim Horton.
4134
4135         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
4136         Make sure that EventSenderProxy always exists when running tests. We used to create
4137         it when resetting before the first test, which is a bit too late.
4138
4139         * WebKitTestRunner/TestController.h:
4140         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4141         (WTR::TestController::platformCreateWebView):
4142         (WTR::TestController::platformCreateOtherPage):
4143         (WTR::TestController::finishCreatingPlatformWebView):
4144         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4145         (WTR::PlatformWebView::PlatformWebView):
4146         Moved some code that made NSWindow use NSEvent during web view creation. We may
4147         need to move more if some other case us found, but this is enough for now.
4148
4149 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
4150
4151         Unreviewed. Fix typo in GLib geolocation API after r243285.
4152
4153         gelocation -> geolocation.
4154
4155         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
4156         (testGeolocationManagerWatchPosition):
4157
4158 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4159
4160         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
4161         https://bugs.webkit.org/show_bug.cgi?id=196213
4162
4163         Reviewed by Geoff Garen.
4164
4165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4166         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
4167         (credentialWithIdentityAndKeychainPath):
4168         (-[ChallengeDelegate webView:didFinishNavigation:]):
4169         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4170         (TestWebKitAPI::TEST):
4171
4172 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4173
4174         Expected shouldn't assume its contained types are copyable
4175         https://bugs.webkit.org/show_bug.cgi?id=195986
4176
4177         Reviewed by JF Bastien.
4178
4179         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4180         (TestWebKitAPI::NonCopyable::operator== const):
4181         (TestWebKitAPI::NonCopyable::operator!= const):
4182         (TestWebKitAPI::TEST):
4183
4184 2019-03-25  Tim Horton  <timothy_horton@apple.com>
4185
4186         Remove some now-unnecessary dynamic class lookup
4187         https://bugs.webkit.org/show_bug.cgi?id=196237
4188
4189         Reviewed by Simon Fraser.
4190
4191         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4192         (makeRequest):
4193         (TEST):
4194
4195 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
4196
4197         Unreviewed, rolling out r243450.
4198
4199         AppleWin and WinCairo port builds get broken.
4200
4201         Reverted changeset:
4202
4203         "Add test for fix of #196095"
4204         https://bugs.webkit.org/show_bug.cgi?id=196097
4205         https://trac.webkit.org/changeset/243450
4206
4207 2019-03-25  Commit Queue  <commit-queue@webkit.org>
4208
4209         Unreviewed, rolling out r243465.
4210         https://bugs.webkit.org/show_bug.cgi?id=196226
4211
4212         the test doesn't build (Requested by thorton on #webkit).
4213
4214         Reverted changeset:
4215
4216         "Do not terminate the NetworkProcess if a third party
4217         application sends a NSCredential with a SecIdentityRef"
4218         https://bugs.webkit.org/show_bug.cgi?id=196213
4219         https://trac.webkit.org/changeset/243465
4220
4221 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4222
4223         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
4224         https://bugs.webkit.org/show_bug.cgi?id=196213
4225
4226         Reviewed by Geoff Garen.
4227
4228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4229         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
4230         (credentialWithIdentityAndKeychainPath):
4231         (-[ChallengeDelegate webView:didFinishNavigation:]):
4232         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4233         (TestWebKitAPI::TEST):
4234
4235 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4236
4237         [ews-build] Gracefully handle missing patch_id in events
4238         https://bugs.webkit.org/show_bug.cgi?id=196216
4239
4240         Reviewed by Lucas Forschler.
4241
4242         * BuildSlaveSupport/ews-build/events.py:
4243
4244 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4245
4246         [ews-build] use lz4 compression for improving buildbot performance
4247         https://bugs.webkit.org/show_bug.cgi?id=196155
4248
4249         Reviewed by Lucas Forschler.
4250
4251         * BuildSlaveSupport/ews-build/master.cfg:
4252
4253 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4254
4255         Pull some API testing helper methods out of TestWKWebView
4256         https://bugs.webkit.org/show_bug.cgi?id=196212
4257
4258         Reviewed by Tim Horton.
4259
4260         Refactor some more API testing utility methods, so that they can be used in
4261         tests that do not use TestWKWebView.
4262
4263         * TestWebKitAPI/cocoa/TestWKWebView.h:
4264         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4265         (-[WKWebView loadTestPageNamed:]):
4266         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
4267         (-[WKWebView synchronouslyLoadHTMLString:]):
4268         (-[WKWebView synchronouslyLoadTestPageNamed:]):
4269         (-[TestWKWebView loadTestPageNamed:]): Deleted.
4270         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
4271         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
4272         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
4273
4274 2019-03-25  Jer Noble  <jer.noble@apple.com>
4275
4276         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
4277         https://bugs.webkit.org/show_bug.cgi?id=196097
4278
4279         Reviewed by Eric Carlson.
4280
4281         Drive-by bug fix: allow tests to play audio without a user gesture by default.
4282
4283         * DumpRenderTree/mac/DumpRenderTree.mm:
4284         (resetWebPreferencesToConsistentValues):
4285         * WebKitTestRunner/TestController.cpp:
4286         (WTR::TestController::resetPreferencesToConsistentValues):
4287
4288 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4289
4290         Pull IPadUserInterfaceSwizzler out into a separate header file
4291         https://bugs.webkit.org/show_bug.cgi?id=196193
4292
4293         Reviewed by Anders Carlsson.
4294
4295         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
4296         be used in other API tests.
4297
4298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4299         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
4300         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
4301         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
4302         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
4303         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
4304         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
4305
4306 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>