REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-22  Alex Christensen  <achristensen@webkit.org>
2
3         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
4         https://bugs.webkit.org/show_bug.cgi?id=197093
5         <rdar://problem/49708268>
6
7         Reviewed by Chris Dumez.
8
9         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
10         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
11         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
12         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
13         and one for loads without credentials, so there are two TCP connections to the same server in this test.
14
15         * TestWebKitAPI/TCPServer.cpp:
16         (TestWebKitAPI::TCPServer::TCPServer):
17         (TestWebKitAPI::TCPServer::~TCPServer):
18         (TestWebKitAPI::TCPServer::socketBindListen):
19         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
20         * TestWebKitAPI/TCPServer.h:
21         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
22         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
23         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
24         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
25         (respondWithChallengeThenOK):
26         (TestWebKitAPI::TEST):
27         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
28         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
29         (TEST):
30
31 2019-04-22  Chris Dumez  <cdumez@apple.com>
32
33         Delayed WebProcessLaunch may break the _relatedWebView SPI
34         https://bugs.webkit.org/show_bug.cgi?id=197160
35
36         Reviewed by Alex Christensen.
37
38         Add API test coverage.
39
40         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
41
42 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
43
44         Use curl to download packages for webkitpy autoinstaller
45         https://bugs.webkit.org/show_bug.cgi?id=197164
46
47         Reviewed by Darin Adler.
48
49         * Scripts/webkitpy/common/system/autoinstall.py:
50         (AutoInstaller._download): Use curl(1) to download packages necessary for
51         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
52         errors which are not present when using curl(1).
53
54 2019-04-22  Chris Dumez  <cdumez@apple.com>
55
56         Unreviewed, rolling out r244502.
57
58         Caused crashes on the bots
59
60         Reverted changeset:
61
62         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
63         https://bugs.webkit.org/show_bug.cgi?id=197160
64         https://trac.webkit.org/changeset/244502
65
66 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
67
68         Unreviewed, rolling out r244437.
69
70         Still breaks internal tests.
71
72         Reverted changeset:
73
74         "InjectedBundle parameters often need initialization function
75         called before unarchiving"
76         https://bugs.webkit.org/show_bug.cgi?id=189709
77         https://trac.webkit.org/changeset/244437
78
79 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
80
81         [ews-build] Use singular verb in failure description in case of single api test failure
82         https://bugs.webkit.org/show_bug.cgi?id=197013
83
84         Reviewed by Lucas Forschler.
85
86         * BuildSlaveSupport/ews-build/steps.py:
87         (AnalyzeAPITestsResults.analyzeResults):
88
89 2019-04-22  Chris Dumez  <cdumez@apple.com>
90
91         Delayed WebProcessLaunch may break the _relatedWebView SPI
92         https://bugs.webkit.org/show_bug.cgi?id=197160
93
94         Reviewed by Alex Christensen.
95
96         Add API test coverage.
97
98         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
99
100 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
101
102         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
103         https://bugs.webkit.org/show_bug.cgi?id=194630
104
105         Reviewed by Michael Catanzaro.
106
107         Return early from getAttributeSet() is passed in accessible is nullptr.
108
109         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
110
111 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
112
113         Defer EditorState updates until the next layer tree flush in a few additional circumstances
114         https://bugs.webkit.org/show_bug.cgi?id=197145
115         <rdar://problem/50078170>
116
117         Reviewed by Darin Adler.
118
119         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
120         focus, or showing the font manager.
121
122         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
123         (TestWebKitAPI::TEST):
124         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
125         (TEST):
126         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
127         (TestWebKitAPI::TEST):
128
129 2019-04-21  Brian Burg  <bburg@apple.com>
130
131         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
132         https://bugs.webkit.org/show_bug.cgi?id=197125
133         <rdar://problem/50061468>
134
135         Reviewed by Darin Adler.
136
137         Sometimes I want to run wptserve independently of tests. Make it easier to script that
138         using this class rather than making our own ./wpt serve invocation.
139
140         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
141         (WebDriverW3CWebServer):
142         (WebDriverW3CWebServer.document_root): Expose this to clients.
143         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
144
145         (WebDriverW3CWebServer.__enter__):
146         (WebDriverW3CWebServer.__exit__):
147         Make it possible to use the web server with a 'with' statement.
148
149 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
150
151         [CMake][Win] Use target oriented design for WebKitLegacy
152         https://bugs.webkit.org/show_bug.cgi?id=197112
153
154         Reviewed by Konstantin Tokarev.
155
156         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
157
158         * DumpRenderTree/CMakeLists.txt:
159         * DumpRenderTree/PlatformWin.cmake:
160         * DumpRenderTree/win/EventSender.cpp:
161
162 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
163
164         Update text for old EWS submit button
165         https://bugs.webkit.org/show_bug.cgi?id=197140
166
167         Reviewed by Alexey Proskuryakov.
168
169         * QueueStatusServer/templates/statusbubble.html:
170
171 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
172
173         [ews-app] New EWS should poll bugzilla more frequently
174         https://bugs.webkit.org/show_bug.cgi?id=197138
175
176         Reviewed by Alexey Proskuryakov.
177
178         * BuildSlaveSupport/ews-app/ews/fetcher.py:
179         (FetchLoop.__init__):
180
181 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
182
183         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
184         https://bugs.webkit.org/show_bug.cgi?id=197139
185
186         Reviewed by Alexey Proskuryakov.
187
188         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
189         * QueueStatusServer/templates/statusbubble.html:
190
191 2019-04-20  Chris Dumez  <cdumez@apple.com>
192
193         Unreviewed, fix iOS build with recent SDKs.
194
195         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
196
197 2019-04-19  Keith Miller  <keith_miller@apple.com>
198
199         Add script to merge run_benchmark jsons
200         https://bugs.webkit.org/show_bug.cgi?id=197107
201
202         Reviewed by Michael Saboff.
203
204         The script basically recursively decends through all json objects until it gets
205         to an array or JSON primitive and concats or takes the first value, respectively.
206
207         This patch also adds +x bits to the compare-results script so it
208         can be run directly from the command line. I had to add a new line so that svn
209         will accept the change... yay svn!
210
211         * Scripts/compare-results:
212         * Scripts/merge-result-jsons: Added.
213         (readJSONFile):
214         (deepAppend):
215         (mergeJSONs):
216         (main):
217
218 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
219
220         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
221         https://bugs.webkit.org/show_bug.cgi?id=197079
222
223         Reviewed by Darin Adler.
224
225         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
226
227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
228         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
229
230 2019-04-18  Commit Queue  <commit-queue@webkit.org>
231
232         Unreviewed, rolling out r244434.
233         https://bugs.webkit.org/show_bug.cgi?id=197089
234
235         caused 1 API test failure (Requested by zalan on #webkit).
236
237         Reverted changeset:
238
239         "Regression (r244291): Broken API Test
240         AutoLayoutRenderingProgressRelativeOrdering"
241         https://bugs.webkit.org/show_bug.cgi?id=196948
242         https://trac.webkit.org/changeset/244434
243
244 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
245
246         Add new compatibility mode API on WKNavigation
247         https://bugs.webkit.org/show_bug.cgi?id=197069
248         <rdar://problem/50025800>
249
250         Reviewed by Tim Horton.
251
252         Add a block property for -didCommitNavigation to TestNavigationDelegate.
253
254         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
255         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
256         (-[TestNavigationDelegate webView:didCommitNavigation:]):
257
258 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
259
260         [CMake] Make WebCore headers copies
261         https://bugs.webkit.org/show_bug.cgi?id=182512
262         <rdar://problem/37510435>
263
264         Reviewed by Alex Christensen.
265
266         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
267         ports.
268
269         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
270         of WebCore headers using "*.h" were modified to <WebCore/*.h>
271
272         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
273         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
274         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
275         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
276         * TestWebKitAPI/CMakeLists.txt:
277         * TestWebKitAPI/PlatformWin.cmake:
278         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
279         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
280         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
281
282 2019-04-18  Jer Noble  <jer.noble@apple.com>
283
284         Add support for parsing FairPlayStreaming PSSH boxes.
285         https://bugs.webkit.org/show_bug.cgi?id=197064
286
287         Reviewed by Eric Carlson.
288
289         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
290         (TestWebKitAPI::TEST):
291
292 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
293
294         InjectedBundle parameters often need initialization function called before unarchiving
295         https://bugs.webkit.org/show_bug.cgi?id=189709
296         <rdar://problem/44573653>
297
298         Reviewed by Ryosuke Niwa.
299
300         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
301         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
302
303 2019-04-18  Zalan Bujtas  <zalan@apple.com>
304
305         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
306         https://bugs.webkit.org/show_bug.cgi?id=196948
307         <rdar://problem/49927131>
308
309         Reviewed by Tim Horton.
310
311         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
312         (TEST): 
313         The expected order of incoming events is
314         1. didInvalidateIntrinsicContentSize
315         2. didFirstLayout
316         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
317         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
318         (and remember, all we care about is ordering).
319
320 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
321
322         Unreviewed, rolling out r244299.
323
324         Breaks internal tests.
325
326         Reverted changeset:
327
328         "InjectedBundle parameters often need initialization function
329         called before unarchiving"
330         https://bugs.webkit.org/show_bug.cgi?id=189709
331         https://trac.webkit.org/changeset/244299
332
333 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
334
335         [WTF] StringBuilder should set correct m_is8Bit flag when merging
336         https://bugs.webkit.org/show_bug.cgi?id=197053
337
338         Reviewed by Saam Barati.
339
340         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
341         (TestWebKitAPI::TEST):
342
343 2019-04-17  Tim Horton  <timothy_horton@apple.com>
344
345         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
346         https://bugs.webkit.org/show_bug.cgi?id=197028
347         <rdar://problem/49985290>
348
349         Reviewed by Wenson Hsieh.
350
351         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
352         (TEST):
353         Liberal application of waitForNextPresentationUpdate works around a race
354         where if the page rapidly changes its viewport arguments (or an API client
355         rapidly changes its viewport arguments), we'd get stuck thinking that the
356         user had intentionally zoomed the page, and stop resetting the initial scale.
357         This deserves a separate bug, but no need to keep the test failing while
358         we think about it.
359
360 2019-04-17  Tim Horton  <timothy_horton@apple.com>
361
362         REGRESSION (r241988): Switching tabs is slow
363         https://bugs.webkit.org/show_bug.cgi?id=197037
364         <rdar://problem/49951473>
365
366         Reviewed by Simon Fraser.
367
368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
369         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
370         (TEST):
371         * TestWebKitAPI/cocoa/TestWKWebView.h:
372         * TestWebKitAPI/cocoa/TestWKWebView.mm:
373         (-[TestWKWebView addToTestWindow]):
374         Add a test that hangs without this fix.
375
376 2019-04-17  Truitt Savell  <tsavell@apple.com>
377
378         Unreviewed, rolling out r244400.
379
380         Caused testing to exit early with assertionon Debug WK2
381
382         Reverted changeset:
383
384         "UI↔Web deadlock when printing with a JavaScript alert
385         visible"
386         https://bugs.webkit.org/show_bug.cgi?id=196839
387         https://trac.webkit.org/changeset/244400
388
389 2019-04-17  Brady Eidson  <beidson@apple.com>
390
391         Link clicks in PDFs shouldn't send referrer headers.
392         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
393
394         Reviewed by Tim Horton.
395
396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
397         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
398         (putPDFBytesCallback):
399         (emptyReleaseInfoCallback):
400         (createPDFWithLinkToURL):
401         (TEST):
402
403 2019-04-17  Tim Horton  <timothy_horton@apple.com>
404
405         UI↔Web deadlock when printing with a JavaScript alert visible
406         https://bugs.webkit.org/show_bug.cgi?id=196839
407         <rdar://problem/49157642>
408
409         Reviewed by Andy Estes.
410
411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
412         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
413         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
414         (TEST):
415
416 2019-04-17  Alex Christensen  <achristensen@webkit.org>
417
418         WKRetainPtr's adoption constructor should be private
419         https://bugs.webkit.org/show_bug.cgi?id=197019
420
421         Reviewed by Tim Horton.
422
423         * DumpRenderTree/mac/DumpRenderTree.mm:
424         (dumpFramesAsText):
425         * TestWebKitAPI/InjectedBundleController.cpp:
426         (TestWebKitAPI::InjectedBundleController::initialize):
427         * TestWebKitAPI/PlatformUtilities.cpp:
428         (TestWebKitAPI::Util::createContextWithInjectedBundle):
429         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
430         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
431         (TestWebKitAPI::Util::toWK):
432         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
433         (TestWebKitAPI::TEST):
434         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
435         (TestWebKitAPI::TEST):
436         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
437         (TestWebKitAPI::TEST):
438         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
439         (TestWebKitAPI::TEST):
440         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
441         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
442         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
443         (TestWebKitAPI::TEST):
444         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
445         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
446         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
447         (TestWebKitAPI::TEST):
448         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
449         (TestWebKitAPI::TEST):
450         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
451         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
452         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
453         (TestWebKitAPI::TEST):
454         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
455         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
456         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
457         (TestWebKitAPI::TEST):
458         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
459         (TestWebKitAPI::TEST):
460         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
461         (TestWebKitAPI::TEST):
462         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
463         (TestWebKitAPI::TEST):
464         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
465         (TestWebKitAPI::TEST):
466         * TestWebKitAPI/Tests/WebKit/Find.cpp:
467         (TestWebKitAPI::TEST):
468         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
469         (TestWebKitAPI::TEST):
470         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
471         (TestWebKitAPI::TEST):
472         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
473         (TestWebKitAPI::TEST):
474         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
475         (TestWebKitAPI::TEST):
476         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
477         (TestWebKitAPI::TEST):
478         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
479         (TestWebKitAPI::TEST):
480         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
481         (TestWebKitAPI::TEST):
482         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
483         (TestWebKitAPI::TEST):
484         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
485         (TestWebKitAPI::TEST):
486         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
487         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
488         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
489         (TestWebKitAPI::TEST):
490         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
491         (TestWebKitAPI::TEST):
492         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
493         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
494         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
495         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
496         (TestWebKitAPI::TEST):
497         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
498         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
499         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
500         (TestWebKitAPI::TEST):
501         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
502         (TestWebKitAPI::TEST):
503         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
504         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
505         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
506         (TestWebKitAPI::TEST):
507         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
508         (TestWebKitAPI::loadAlternateHTMLString):
509         (TestWebKitAPI::TEST):
510         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
511         (TestWebKitAPI::TEST):
512         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
513         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
514         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
515         (TestWebKitAPI::buildAndPerformTest):
516         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
517         (TestWebKitAPI::TEST):
518         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
519         (TestWebKitAPI::TEST):
520         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
521         (TestWebKitAPI::TEST):
522         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
523         (TestWebKitAPI::TEST):
524         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
525         (TestWebKitAPI::TEST):
526         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
527         (TestWebKitAPI::TEST):
528         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
529         (TestWebKitAPI::TEST):
530         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
531         (TestWebKitAPI::TEST):
532         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
533         (TestWebKitAPI::TEST):
534         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
535         (TestWebKitAPI::TEST):
536         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
537         (TestWebKitAPI::TEST):
538         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
539         (TestWebKitAPI::TEST):
540         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
541         (TestWebKitAPI::TEST):
542         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
543         (TestWebKitAPI::TEST):
544         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
545         (TestWebKitAPI::TEST):
546         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
547         (TestWebKitAPI::TEST):
548         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
549         (TestWebKitAPI::TEST):
550         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
551         (TestWebKitAPI::TEST):
552         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
553         (TestWebKitAPI::TEST):
554         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
555         (TestWebKitAPI::TEST):
556         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
557         (TestWebKitAPI::TEST):
558         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
559         (TestWebKitAPI::TEST):
560         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
561         (TestWebKitAPI::TEST):
562         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
563         (TestWebKitAPI::TEST):
564         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
565         (TestWebKitAPI::TEST):
566         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
567         (TestWebKitAPI::TEST):
568         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
569         (TestWebKitAPI::TEST):
570         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
571         (TestWebKitAPI::TEST):
572         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
573         (TestWebKitAPI::TEST):
574         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
575         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
576         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
577         (TestWebKitAPI::TEST):
578         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
579         (TestWebKitAPI::TEST):
580         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
581         (TestWebKitAPI::TEST):
582         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
583         (TestWebKitAPI::TEST):
584         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
585         (TestWebKitAPI::TEST):
586         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
587         (TestWebKitAPI::TEST):
588         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
589         (TestWebKitAPI::TEST):
590         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
591         (TestWebKitAPI::TEST):
592         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
593         (TestWebKitAPI::TEST):
594         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
595         (TestWebKitAPI::TEST):
596         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
597         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
598         (TEST):
599         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
600         (TEST):
601         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
602         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
603         (TEST):
604         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
605         (TestWebKitAPI::TEST):
606         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
607         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
608         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
609         (WTR::getMenuItemTitleCallback):
610         (WTR::createMouseMessageBody):
611         (WTR::EventSendingController::mouseDown):
612         (WTR::EventSendingController::mouseUp):
613         (WTR::EventSendingController::mouseMoveTo):
614         (WTR::EventSendingController::mouseForceClick):
615         (WTR::EventSendingController::startAndCancelMouseForceClick):
616         (WTR::EventSendingController::mouseForceDown):
617         (WTR::EventSendingController::mouseForceUp):
618         (WTR::EventSendingController::mouseForceChanged):
619         (WTR::EventSendingController::leapForward):
620         (WTR::EventSendingController::scheduleAsynchronousClick):
621         (WTR::createKeyDownMessageBody):
622         (WTR::EventSendingController::keyDown):
623         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
624         (WTR::EventSendingController::mouseScrollBy):
625         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
626         (WTR::EventSendingController::continuousMouseScrollBy):
627         (WTR::EventSendingController::addTouchPoint):
628         (WTR::EventSendingController::updateTouchPoint):
629         (WTR::EventSendingController::setTouchModifier):
630         (WTR::EventSendingController::setTouchPointRadius):
631         (WTR::EventSendingController::touchStart):
632         (WTR::EventSendingController::touchMove):
633         (WTR::EventSendingController::touchEnd):
634         (WTR::EventSendingController::touchCancel):
635         (WTR::EventSendingController::clearTouchPoints):
636         (WTR::EventSendingController::releaseTouchPoint):
637         (WTR::EventSendingController::cancelTouchPoint):
638         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
639         (WTR::InjectedBundle::didCreatePage):
640         (WTR::InjectedBundle::didReceiveMessage):
641         (WTR::InjectedBundle::didReceiveMessageToPage):
642         (WTR::InjectedBundle::booleanForKey):
643         (WTR::InjectedBundle::done):
644         (WTR::InjectedBundle::dumpToStdErr):
645         (WTR::InjectedBundle::outputText):
646         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
647         (WTR::InjectedBundle::postAddChromeInputField):
648         (WTR::InjectedBundle::postRemoveChromeInputField):
649         (WTR::InjectedBundle::postFocusWebView):
650         (WTR::InjectedBundle::postSetBackingScaleFactor):
651         (WTR::InjectedBundle::postSetWindowIsKey):
652         (WTR::InjectedBundle::postSetViewSize):
653         (WTR::InjectedBundle::postSimulateWebNotificationClick):
654         (WTR::InjectedBundle::postSetAddsVisitedLinks):
655         (WTR::InjectedBundle::setGeolocationPermission):
656         (WTR::InjectedBundle::setMockGeolocationPosition):
657         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
658         (WTR::InjectedBundle::isGeolocationProviderActive const):
659         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
660         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
661         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
662         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
663         (WTR::InjectedBundle::setCustomPolicyDelegate):
664         (WTR::InjectedBundle::setHidden):
665         (WTR::InjectedBundle::setCacheModel):
666         (WTR::InjectedBundle::shouldProcessWorkQueue const):
667         (WTR::InjectedBundle::processWorkQueue):
668         (WTR::InjectedBundle::queueBackNavigation):
669         (WTR::InjectedBundle::queueForwardNavigation):
670         (WTR::InjectedBundle::queueLoad):
671         (WTR::InjectedBundle::queueLoadHTMLString):
672         (WTR::InjectedBundle::queueReload):
673         (WTR::InjectedBundle::queueLoadingScript):
674         (WTR::InjectedBundle::queueNonLoadingScript):
675         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
676         (WTR::frameToStr):
677         (WTR::InjectedBundlePage::InjectedBundlePage):
678         (WTR::dumpFrameDescriptionSuitableForTestResult):
679         (WTR::dumpFrameScrollPosition):
680         (WTR::dumpDescendantFrameScrollPositions):
681         (WTR::dumpFrameText):
682         (WTR::dumpDescendantFramesText):
683         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
684         (WTR::TestRunner::shouldDumpPixels const):
685         (WTR::TestRunner::setDumpPixels):
686         (WTR::TestRunner::whatToDump const):
687         (WTR::TestRunner::setWhatToDump):
688         (WTR::TestRunner::setWaitUntilDone):
689         (WTR::TestRunner::shouldWaitUntilDone const):
690         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
691         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
692         (WTR::TestRunner::clearAllDatabases):
693         (WTR::TestRunner::setIDBPerOriginQuota):
694         (WTR::TestRunner::originsWithApplicationCache):
695         (WTR::TestRunner::setCanOpenWindows):
696         (WTR::TestRunner::setXSSAuditorEnabled):
697         (WTR::TestRunner::setMediaDevicesEnabled):
698         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
699         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
700         (WTR::TestRunner::setCustomUserAgent):
701         (WTR::TestRunner::setWebAPIStatisticsEnabled):
702         (WTR::TestRunner::setModernMediaControlsEnabled):
703         (WTR::TestRunner::setWebGL2Enabled):
704         (WTR::TestRunner::setWritableStreamAPIEnabled):
705         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
706         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
707         (WTR::TestRunner::setAllowsAnySSLCertificate):
708         (WTR::TestRunner::setPluginsEnabled):
709         (WTR::TestRunner::setValueForUser):
710         (WTR::TestRunner::setAudioResult):
711         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
712         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
713         (WTR::TestRunner::setAlwaysAcceptCookies):
714         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
715         (WTR::TestRunner::isDoingMediaCapture const):
716         (WTR::TestRunner::queueLoad):
717         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
718         (WTR::TestRunner::setHandlesAuthenticationChallenges):
719         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
720         (WTR::TestRunner::setShouldLogDownloadCallbacks):
721         (WTR::TestRunner::setAuthenticationUsername):
722         (WTR::TestRunner::setAuthenticationPassword):
723         (WTR::TestRunner::secureEventInputIsEnabled const):
724         (WTR::TestRunner::setBlockAllPlugins):
725         (WTR::TestRunner::setPluginSupportedMode):
726         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
727         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
728         (WTR::TestRunner::setNavigationGesturesEnabled):
729         (WTR::TestRunner::setIgnoresViewportScaleLimits):
730         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
731         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
732         (WTR::TestRunner::terminateNetworkProcess):
733         (WTR::TestRunner::terminateServiceWorkerProcess):
734         (WTR::TestRunner::runUIScript):
735         (WTR::TestRunner::setStatisticsDebugMode):
736         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
737         (WTR::TestRunner::setStatisticsLastSeen):
738         (WTR::TestRunner::setStatisticsPrevalentResource):
739         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
740         (WTR::TestRunner::dumpResourceLoadStatistics):
741         (WTR::TestRunner::isStatisticsPrevalentResource):
742         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
743         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
744         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
745         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
746         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
747         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
748         (WTR::TestRunner::setStatisticsGrandfathered):
749         (WTR::TestRunner::isStatisticsGrandfathered):
750         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
751         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
752         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
753         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
754         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
755         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
756         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
757         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
758         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
759         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
760         (WTR::TestRunner::statisticsUpdateCookieBlocking):
761         (WTR::TestRunner::statisticsSubmitTelemetry):
762         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
763         (WTR::TestRunner::setStatisticsIsRunningTest):
764         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
765         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
766         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
767         (WTR::TestRunner::setStatisticsGrandfatheringTime):
768         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
769         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
770         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
771         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
772         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
773         (WTR::TestRunner::statisticsDeleteCookiesForHost):
774         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
775         (WTR::TestRunner::statisticsResetToConsistentState):
776         (WTR::TestRunner::setStorageAccessAPIEnabled):
777         (WTR::TestRunner::getAllStorageAccessEntries):
778         (WTR::TestRunner::addMockMediaDevice):
779         (WTR::TestRunner::clearMockMediaDevices):
780         (WTR::TestRunner::removeMockMediaDevice):
781         (WTR::TestRunner::resetMockMediaDevices):
782         (WTR::TestRunner::connectMockGamepad):
783         (WTR::TestRunner::disconnectMockGamepad):
784         (WTR::TestRunner::setMockGamepadDetails):
785         (WTR::TestRunner::setMockGamepadAxisValue):
786         (WTR::TestRunner::setMockGamepadButtonValue):
787         (WTR::TestRunner::removeAllSessionCredentials):
788         (WTR::TestRunner::clearDOMCache):
789         (WTR::TestRunner::clearDOMCaches):
790         (WTR::TestRunner::hasDOMCache):
791         (WTR::TestRunner::domCacheSize):
792         (WTR::TestRunner::setAllowStorageQuotaIncrease):
793         (WTR::TestRunner::getApplicationManifestThen):
794         (WTR::TestRunner::injectUserScript):
795         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
796         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
797         (WTR::TestRunner::addTestKeyToKeychain):
798         (WTR::TestRunner::cleanUpKeychain):
799         (WTR::TestRunner::keyExistsInKeychain):
800         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
801         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
802         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
803         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
804         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
805         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
806         * WebKitTestRunner/TestController.cpp:
807         (WTR::TestController::initialize):
808         (WTR::parseStringTestHeaderValueAsRelativePath):
809         (WTR::updateTestOptionsFromTestHeader):
810         (WTR::TestController::runTest):
811         (WTR::TestController::didReceiveLiveDocumentsList):
812         (WTR::TestController::didReceiveMessageFromInjectedBundle):
813         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
814         (WTR::TestController::didFinishNavigation):
815         (WTR::TestController::didReceiveAuthenticationChallenge):
816         * WebKitTestRunner/TestInvocation.cpp:
817         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
818         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
819         (WTR::TestInvocation::uiScriptDidComplete):
820         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
821         * WebKitTestRunner/WebNotificationProvider.cpp:
822         (WTR::WebNotificationProvider::closeWebNotification):
823         * WebKitTestRunner/WorkQueueManager.cpp:
824         (WTR::ScriptItem::ScriptItem):
825         (WTR::WorkQueueManager::queueLoad):
826         (WTR::WorkQueueManager::queueLoadHTMLString):
827
828 2019-04-17  Alex Christensen  <achristensen@webkit.org>
829
830         Add a comment to make my test from r244139 less mysterious.
831         https://bugs.webkit.org/show_bug.cgi?id=196744
832
833         As suggested by Darin Adler.
834
835         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
836         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
837
838 2019-04-17  Chris Dumez  <cdumez@apple.com>
839
840         Remember device orientation permission for the duration of the browsing session
841         https://bugs.webkit.org/show_bug.cgi?id=196992
842         <rdar://problem/49946067>
843
844         Reviewed by Alex Christensen.
845
846         Add API test coverage.
847
848         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
849         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
850         (TEST):
851
852 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
853
854         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
855         https://bugs.webkit.org/show_bug.cgi?id=196675
856
857         Reviewed by Lucas Forschler.
858
859         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
860         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
861
862 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
863
864         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
865         https://bugs.webkit.org/show_bug.cgi?id=196919
866         <rdar://problem/41630459>
867
868         Reviewed by Tim Horton.
869
870         Add iOS support for several new testing hooks. See below for more detail.
871
872         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
873         (WTR::UIScriptController::isDismissingMenu const):
874
875         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
876         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
877         by UIKit when dismissing the callout bar (i.e. UIMenuController).
878
879         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
880         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
881         (WTR::UIScriptController::isDismissingMenu const):
882         * TestRunnerShared/UIScriptContext/UIScriptController.h:
883         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
884         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
885         (WTR::InjectedBundle::didReceiveMessageToPage):
886         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
887         (WTR::TestRunner::setAllowedMenuActions):
888
889         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
890         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
891         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
892         against the name of the custom action.
893
894         (WTR::TestRunner::installCustomMenuAction):
895
896         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
897         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
898         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
899         triggered.
900
901         (WTR::TestRunner::performCustomMenuAction):
902
903         Invoked when the custom menu action is triggered.
904
905         * WebKitTestRunner/InjectedBundle/TestRunner.h:
906         * WebKitTestRunner/TestController.cpp:
907         (WTR::TestController::installCustomMenuAction):
908         (WTR::TestController::setAllowedMenuActions):
909         * WebKitTestRunner/TestController.h:
910         * WebKitTestRunner/TestInvocation.cpp:
911         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
912         (WTR::TestInvocation::performCustomMenuAction):
913
914         Add plumbing to call back into the injected bundle when performing the custom action.
915
916         * WebKitTestRunner/TestInvocation.h:
917         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
918         (WTR::TestController::installCustomMenuAction):
919         (WTR::TestController::setAllowedMenuActions):
920         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
921         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
922         (-[TestRunnerWKWebView initWithFrame:configuration:]):
923         (-[TestRunnerWKWebView becomeFirstResponder]):
924         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
925
926         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
927         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
928         in the Mail app on iOS.
929
930         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
931         (-[TestRunnerWKWebView setAllowedMenuActions:]):
932         (-[TestRunnerWKWebView resetCustomMenuAction]):
933         (-[TestRunnerWKWebView performCustomAction:]):
934         (-[TestRunnerWKWebView canPerformAction:withSender:]):
935         (-[TestRunnerWKWebView _willHideMenu]):
936         (-[TestRunnerWKWebView _didHideMenu]):
937         * WebKitTestRunner/ios/TestControllerIOS.mm:
938         (WTR::TestController::platformResetStateToConsistentValues):
939
940         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
941         if specified.
942
943         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
944         (WTR::UIScriptController::isDismissingMenu const):
945
946 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
947
948         Allow sharing from imageSheet on an image document
949         https://bugs.webkit.org/show_bug.cgi?id=196891
950         <rdar://problem/25377386>
951
952         Reviewed by Tim Horton.
953
954         Test to make sure that the correct imageURL is extracted from an image element.
955
956         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
957         (TestWebKitAPI::TEST):
958
959 2019-04-16  Alex Christensen  <achristensen@webkit.org>
960
961         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
962         https://bugs.webkit.org/show_bug.cgi?id=196995
963
964         Reviewed by Brady Eidson.
965
966         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
967         (TEST):
968
969 2019-04-16  Chris Dumez  <cdumez@apple.com>
970
971         URL set by document.open() is not communicated to the UIProcess
972         https://bugs.webkit.org/show_bug.cgi?id=196941
973         <rdar://problem/49237544>
974
975         Reviewed by Geoff Garen.
976
977         Add API test coverage.
978
979         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
980         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
981         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
982         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
983         (TEST):
984
985 2019-04-16  Commit Queue  <commit-queue@webkit.org>
986
987         Unreviewed, rolling out r244321.
988         https://bugs.webkit.org/show_bug.cgi?id=196968
989
990         Causing all WK2 Debug builds to exit early after Assertion
991         failures. (Requested by ShawnRoberts on #webkit).
992
993         Reverted changeset:
994
995         "URL set by document.open() is not communicated to the
996         UIProcess"
997         https://bugs.webkit.org/show_bug.cgi?id=196941
998         https://trac.webkit.org/changeset/244321
999
1000 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1001
1002         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1003         https://bugs.webkit.org/show_bug.cgi?id=196948
1004
1005         Reviewed by Zalan Bujtas.
1006
1007         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1008         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
1009
1010 2019-04-15  Chris Dumez  <cdumez@apple.com>
1011
1012         URL set by document.open() is not communicated to the UIProcess
1013         https://bugs.webkit.org/show_bug.cgi?id=196941
1014         <rdar://problem/49237544>
1015
1016         Reviewed by Geoffrey Garen.
1017
1018         Add API test coverage.
1019
1020         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1021         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1022         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1023         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1024         (TEST):
1025
1026 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
1027
1028         Using Tools/Scripts/clean-webkit should not install requests
1029         https://bugs.webkit.org/show_bug.cgi?id=196940
1030
1031         Reviewed by Lucas Forschler.
1032
1033         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
1034         existing, depending on the path autoinstalled is run through.
1035         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
1036         needed.
1037         (Port.configuration_for_upload):
1038         (Port.commits_for_upload):
1039
1040 2019-04-15  Alex Christensen  <achristensen@webkit.org>
1041
1042         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
1043         https://bugs.webkit.org/show_bug.cgi?id=196773
1044
1045         Reviewed by Jer Noble.
1046
1047         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
1048         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
1049         (TEST):
1050
1051 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1052
1053         ews-build should clearly indicate flaky test failures
1054         https://bugs.webkit.org/show_bug.cgi?id=196947
1055
1056         Reviewed by Lucas Forschler.
1057
1058         * BuildSlaveSupport/ews-build/steps.py:
1059         (AnalyzeAPITestsResults.analyzeResults):
1060
1061 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
1062
1063         InjectedBundle parameters often need initialization function called before unarchiving
1064         https://bugs.webkit.org/show_bug.cgi?id=189709
1065         <rdar://problem/44573653>
1066
1067         Reviewed by Ryosuke Niwa.
1068
1069         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1070         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1071
1072 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1073
1074         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
1075         https://bugs.webkit.org/show_bug.cgi?id=196681
1076
1077         Reviewed by Darin Adler.
1078
1079         Added tests.
1080
1081         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1082         (WTF_HashSet.RemoveIf):
1083         (WTF_HashSet.RemoveIfShrinkToBestSize):
1084
1085 2019-04-15  John Wilander  <wilander@apple.com>
1086
1087         Send delayed Ad Click Attribution conversion requests to the click source
1088         https://bugs.webkit.org/show_bug.cgi?id=196838
1089         <rdar://problem/47650157>
1090
1091         Reviewed by Chris Dumez and Youenn Fablet.
1092
1093         This patch adds test infrastructure to override the default behavior in
1094         WebKit::NetworkAdClickAttribution.
1095
1096         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1097         (TestWebKitAPI::TEST):
1098         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1099         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1100         (WTR::TestRunner::dumpAdClickAttribution):
1101         (WTR::TestRunner::clearAdClickAttribution):
1102         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1103         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1104         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1105         * WebKitTestRunner/TestController.cpp:
1106         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
1107         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
1108         * WebKitTestRunner/TestController.h:
1109         * WebKitTestRunner/TestInvocation.cpp:
1110         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1111
1112 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1113
1114         [ews-app] status-bubble should display position in queue
1115         https://bugs.webkit.org/show_bug.cgi?id=196607
1116
1117         Reviewed by Lucas Forschler.
1118
1119         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1120         (StatusBubble._build_bubble):
1121         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1122
1123 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1124
1125         [ews-build] Do not run clean build by default on EWS builders
1126         https://bugs.webkit.org/show_bug.cgi?id=196897
1127
1128         Reviewed by Lucas Forschler.
1129
1130         * BuildSlaveSupport/ews-build/steps.py:
1131         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1132         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1133         untracked directories like WebKitBuild).
1134         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1135         untracked files/directories (like WebKitBuild).
1136
1137 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1138
1139         TestRunner::notifyDone() should be safely reentrant
1140         https://bugs.webkit.org/show_bug.cgi?id=196898
1141
1142         Reviewed by Darin Adler.
1143
1144         It is currently possible that TestRunner::notifyDone() will call itself, since
1145         notifyDone() will force a repaint, which can start executing JavaScript, which
1146         may call notifyDone() again. This can lead to test failures and flakiness.
1147         Fix this by setting the m_waitToDump flag before calling the dump() method.
1148
1149         * DumpRenderTree/mac/TestRunnerMac.mm:
1150         (TestRunner::notifyDone):
1151         (TestRunner::forceImmediateCompletion):
1152         * DumpRenderTree/win/TestRunnerWin.cpp:
1153         (TestRunner::notifyDone):
1154         (TestRunner::forceImmediateCompletion):
1155
1156 2019-04-15  Philippe Normand  <pnormand@igalia.com>
1157
1158         [GTK][WPE] Add enable-media websetting
1159         https://bugs.webkit.org/show_bug.cgi?id=196863
1160
1161         Reviewed by Michael Catanzaro.
1162
1163         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1164         (testWebKitSettings): Add test for the enable-media web-setting.
1165
1166 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1167
1168         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1169         https://bugs.webkit.org/show_bug.cgi?id=196905
1170         <rdar://problem/49886096>
1171
1172         Reviewed by Tim Horton.
1173
1174         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1175         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1176         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1177         delay timer, we end up with this sequence of events in the problematic (failure) case:
1178
1179         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1180             ...IPC from UI to web process...
1181         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1182             ...IPC from web to UI process...
1183         (c) [UI]    Invoke completion handler for script #1
1184         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1185             ...IPC from UI to web process...
1186         (e) [Web]   Evaluate script #2 in the web process
1187         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1188
1189         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1190         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1191         #2 is run in step (e).
1192
1193         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1194         the UI process by waiting on a script message posted by the web process, after attachment updates are
1195         dispatched.
1196
1197         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1198         (TestWebKitAPI::TEST):
1199
1200 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1201
1202         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1203         https://bugs.webkit.org/show_bug.cgi?id=196909
1204
1205         Reviewed by Wenson Hsieh.
1206
1207         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1208         (TestWebKitAPI::TEST):
1209
1210 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1211
1212         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1213         https://bugs.webkit.org/show_bug.cgi?id=196880
1214
1215         Reviewed by Yusuke Suzuki.
1216
1217         Add a new function for bytecode cache tests that does not forceDiskCache
1218         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1219         test added in this patch, since the code is invalid and therefore won't be
1220         cached. It should also be useful for tests that evaluate dynamically
1221         generated code.
1222
1223         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1224         * Scripts/run-jsc-stress-tests:
1225
1226 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1227
1228         Update AudioSession route sharing policy
1229         https://bugs.webkit.org/show_bug.cgi?id=196776
1230         <rdar://problem/46501611>
1231
1232         Reviewed by Jer Noble.
1233
1234         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1235         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1236         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1237         (TestWebKitAPI::TEST):
1238
1239 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1240
1241         [iOS] Software keyboard is shown too frequently on some websites
1242         https://bugs.webkit.org/show_bug.cgi?id=195856
1243         <rdar://problem/49191395>
1244
1245         Reviewed by Darin Adler.
1246
1247         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1248
1249         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1250         (WTR::UIScriptController::setHardwareKeyboardAttached):
1251         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1252         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1253         (WTR::UIScriptController::setHardwareKeyboardAttached):
1254         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1255         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1256
1257         Additionally link against GraphicsServices in WebKitTestRunner.
1258
1259         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1260         (WTR::TestController::platformResetStateToConsistentValues):
1261         (WTR::UIScriptController::setHardwareKeyboardAttached):
1262
1263 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1264
1265         [GTK][WPE] Fix pacman install-dependencies packages
1266         https://bugs.webkit.org/show_bug.cgi?id=196817
1267
1268         Reviewed by Žan Doberšek.
1269         
1270         python3-setuptools is called python-setuptools
1271         ruby-highline is only available on AUR
1272         libv4l-devel is incorporated in v4l-utils
1273
1274         * gtk/install-dependencies:
1275         * wpe/install-dependencies:
1276
1277 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1278
1279         [GTK] REGRESSION(r243860): Many tests failing
1280         https://bugs.webkit.org/show_bug.cgi?id=196791
1281
1282         Reviewed by Joanmarie Diggs.
1283
1284         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1285         multiple documents and check that accessibility hierarchy is updated after a navigation.
1286
1287         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1288         (loadChangedCallback):
1289         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1290         (AccessibilityTest::AccessibilityTest):
1291         (AccessibilityTest::~AccessibilityTest):
1292         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1293         (AccessibilityTest::findTestServerApplication):
1294         (AccessibilityTest::findDocumentWeb):
1295         (AccessibilityTest::findRootObject):
1296         (AccessibilityTest::waitUntilChildrenRemoved):
1297         (AccessibilityTest::ensureProxy):
1298         (testAtspiBasicHierarchy):
1299         (beforeAll):
1300         (afterAll):
1301
1302 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1303
1304         [ews-build] Handle bug titles with unicode characters
1305         https://bugs.webkit.org/show_bug.cgi?id=196802
1306
1307         Reviewed by Dewei Zhu.
1308
1309         * BuildSlaveSupport/ews-build/steps.py:
1310         (ValidatePatch._is_bug_closed):
1311
1312 2019-04-11  Michael Saboff  <msaboff@apple.com>
1313
1314         Improve the Inline Cache Stats code
1315         https://bugs.webkit.org/show_bug.cgi?id=196836
1316
1317         Reviewed by Saam Barati.
1318
1319         Added a new script to consolidate and arrange the output of --useICStats option.
1320
1321         This script merges the output from every group into one large table and sorts it from most common to
1322         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1323         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1324         Put together, this is useful to see what property accesses are not getting cached.
1325
1326         * Scripts/ic-stats.py: Added.
1327         (ICStats):
1328         (ICStats.__init__):
1329         (ICStats.parse):
1330         (ICStats.dumpStats):
1331         (usage):
1332
1333 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1334
1335         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1336         https://bugs.webkit.org/show_bug.cgi?id=196809
1337         <rdar://49800762>
1338
1339         Reviewed by Brady Eidson.
1340
1341         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1342         (TEST):
1343
1344 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1345
1346         requestAnimationFrame should execute before the next frame
1347         https://bugs.webkit.org/show_bug.cgi?id=177484
1348
1349         Reviewed by Simon Fraser.
1350
1351         Add trace points for the page RenderingUpdate.
1352
1353         * Tracing/SystemTracePoints.plist:
1354
1355 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1356
1357         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1358         https://bugs.webkit.org/show_bug.cgi?id=196760
1359
1360         Reviewed by Don Olmstead.
1361
1362         vswhere.exe has been bundled since Visual Studio 2017 version
1363         15.2. We shouldn't download vswhere.exe.
1364
1365         * Scripts/build-jsc: Do not call update-vswhere.py.
1366         * Scripts/build-webkit: Ditto.
1367         * Scripts/update-vswhere.py: Removed.
1368         * Scripts/webkitdirs.pm:
1369         (requireModulesForVSWhere): Deleted.
1370         (pickCurrentVisualStudioInstallation): Deleted.
1371         (visualStudioInstallDirVSWhere): Return the latest installed VS
1372         installation path by using the bundled vswhere.exe.
1373         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1374         (visualStudioInstallDirFallback): Removed.
1375
1376 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1377
1378         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1379         https://bugs.webkit.org/show_bug.cgi?id=196780
1380
1381         Reviewed by Alexey Proskuryakov.
1382
1383         * BuildSlaveSupport/ews-build/steps.py:
1384         * BuildSlaveSupport/ews-build/steps_unittest.py:
1385
1386 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1387
1388         Add SPI WKNavigationResponse._downloadAttribute
1389         https://bugs.webkit.org/show_bug.cgi?id=196755
1390         <rdar://49587365>
1391
1392         Reviewed by Brady Eidson.
1393
1394         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1395         (-[NavigationResponseTestDelegate navigationResponse]):
1396         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1397         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1398         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1399         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1400         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1401         (readRequest):
1402         (writeResponse):
1403         (TEST):
1404
1405 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1406
1407         Add modern API for overriding the page's specified viewport configuration
1408         https://bugs.webkit.org/show_bug.cgi?id=167734
1409         <rdar://problem/30331795>
1410
1411         Reviewed by Simon Fraser.
1412
1413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1414         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1415
1416 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1417
1418         Add support for incremental bytecode cache updates
1419         https://bugs.webkit.org/show_bug.cgi?id=195000
1420
1421         Reviewed by Filip Pizlo.
1422
1423         Exit when the initial run to generate bytecode fails.
1424
1425         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1426
1427 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1428
1429         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1430         https://bugs.webkit.org/show_bug.cgi?id=196744
1431         <rdar://49415309>
1432
1433         Reviewed by Chris Dumez.
1434
1435         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1436         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1437
1438 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1439
1440         Add a way to opt into modern compatibility mode in layout tests
1441         https://bugs.webkit.org/show_bug.cgi?id=196770
1442         <rdar://problem/49777550>
1443
1444         Reviewed by Antoine Quint.
1445
1446         Add a new test option to enable modern compatibility mode in layout tests.
1447
1448         * WebKitTestRunner/TestController.cpp:
1449         (WTR::updateTestOptionsFromTestHeader):
1450         * WebKitTestRunner/TestController.h:
1451         * WebKitTestRunner/TestOptions.h:
1452         (WTR::TestOptions::hasSameInitializationOptions const):
1453         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1454         (WTR::TestController::platformCreateWebView):
1455         (WTR::TestController::enableModernCompatibilityMode):
1456
1457 2019-04-10  Andy Estes  <aestes@apple.com>
1458
1459         Try to fix the 32-bit watchOS build.
1460
1461         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1462         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1463
1464 2019-04-10  Antoine Quint  <graouts@apple.com>
1465
1466         Enable Pointer Events on watchOS
1467         https://bugs.webkit.org/show_bug.cgi?id=196771
1468         <rdar://problem/49040909>
1469
1470         Reviewed by Dean Jackson.
1471
1472         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1473
1474 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1475
1476         Unreviewed. Fix WPE accessibility tests after r244059.
1477
1478         We are failing to load the injected bundle due to undefined symbol
1479         AccessibilityUIElement::replaceTextInRange().
1480
1481         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1482         (WTR::AccessibilityUIElement::replaceTextInRange):
1483
1484 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1485
1486         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1487         https://bugs.webkit.org/show_bug.cgi?id=196727
1488
1489         Reviewed by Fujii Hironori.
1490
1491         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1492         (WebKitBrowserWindow::create):
1493
1494 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1495
1496         [ews-build] Add unit tests for PrintConfiguration
1497         https://bugs.webkit.org/show_bug.cgi?id=196752
1498
1499         Reviewed by Dewei Zhu.
1500
1501         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1502
1503 2019-04-09  Keith Rollin  <krollin@apple.com>
1504
1505         Unreviewed build maintenance -- update .xcfilelists.
1506
1507         * DumpRenderTree/DerivedSources-input.xcfilelist:
1508         * DumpRenderTree/DerivedSources-output.xcfilelist:
1509
1510 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1511
1512         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1513         https://bugs.webkit.org/show_bug.cgi?id=196743
1514         <rdar://problem/43897551>
1515
1516         Reviewed by Tim Horton.
1517
1518         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1519         (TEST):
1520
1521 2019-04-09  Youenn Fablet  <youenn@apple.com>
1522
1523         Close service worker database on network process suspension
1524         https://bugs.webkit.org/show_bug.cgi?id=196623
1525         <rdar://problem/48930869>
1526
1527         Reviewed by Alex Christensen.
1528
1529         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1530
1531 2019-04-09  Daniel Bates  <dabates@apple.com>
1532
1533         [iPad] Should open popover when the spacebar is pressed
1534         https://bugs.webkit.org/show_bug.cgi?id=196360
1535         <rdar://problem/49389129>
1536
1537         Reviewed by Brent Fulgham.
1538
1539         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1540
1541         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1542         (WTR::UIScriptController::isShowingPopover const): Added.
1543         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1544         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1545         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1546         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1547         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1548         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1549         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1550         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1551         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1552         (WTR::UIScriptController::isShowingPopover const): Added.
1553         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1554         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1555         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1556         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1557         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1558         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1559         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1560         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1561         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1562         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1563         (WTR::UIScriptController::isShowingPopover const): Added.
1564         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1565         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1566
1567 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1568
1569         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1570         https://bugs.webkit.org/show_bug.cgi?id=196665
1571         <rdar://45115669>
1572
1573         Reviewed by Geoff Garen.
1574
1575         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1576         (goBack):
1577         (+[SimpleLookupContext sharedLookupContext]):
1578         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1579         (TEST):
1580         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1581         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1582
1583 2019-04-09  John Wilander  <wilander@apple.com>
1584
1585         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1586         https://bugs.webkit.org/show_bug.cgi?id=196558
1587         <rdar://problem/47650245>
1588
1589         Reviewed by Youenn Fablet.
1590
1591         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1592         (TestWebKitAPI::TEST):
1593             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1594
1595 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1596
1597         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1598         https://bugs.webkit.org/show_bug.cgi?id=196720
1599
1600         Reviewed by Konstantin Tokarev.
1601
1602         * TestWebKitAPI/PlatformMac.cmake:
1603
1604 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1605
1606         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1607         https://bugs.webkit.org/show_bug.cgi?id=196694
1608         <rdar://problem/48388734>
1609
1610         Rubber-stamped by Aakash Jain.
1611
1612         * Scripts/webkitpy/port/image_diff.py:
1613         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1614         * Scripts/webkitpy/port/server_process.py:
1615         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1616         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1617         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1618         * Scripts/webkitpy/port/server_process_mock.py:
1619         (MockServerProcess.has_available_stdout):
1620         * Scripts/webkitpy/port/server_process_unittest.py:
1621         (TestServerProcess.serial_test_basic):
1622
1623 2019-04-09  Jer Noble  <jer.noble@apple.com>
1624
1625         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1626         https://bugs.webkit.org/show_bug.cgi?id=196097
1627
1628         Reviewed by Eric Carlson.
1629
1630         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1631
1632         * DumpRenderTree/mac/DumpRenderTree.mm:
1633         (resetWebPreferencesToConsistentValues):
1634         * WebKitTestRunner/TestController.cpp:
1635         (WTR::TestController::resetPreferencesToConsistentValues):
1636
1637 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1638
1639         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1640         https://bugs.webkit.org/show_bug.cgi?id=196690
1641
1642         Reviewed by Michael Catanzaro.
1643
1644         * QueueStatusServer/config/queues.py:
1645         * Scripts/webkitpy/common/config/ews.json:
1646         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1647         (test_ews_name):
1648
1649 2019-04-09  Chris Dumez  <cdumez@apple.com>
1650
1651         Loads using loadHTMLString() cause flashing when process-swapping
1652         https://bugs.webkit.org/show_bug.cgi?id=196714
1653         <rdar://problem/49637354>
1654
1655         Reviewed by Antti Koivisto.
1656
1657         Add API test coverage.
1658
1659         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1660
1661 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1662
1663         Unreviewed. Fix ATK accessibility tests after r244059.
1664
1665         We are failing to load the injected bundle due to undefined symbol
1666         AccessibilityUIElement::replaceTextInRange().
1667
1668         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1669         (WTR::AccessibilityUIElement::replaceTextInRange):
1670
1671 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1672
1673         AX: Support API: accessibilityReplaceRange:withText
1674         https://bugs.webkit.org/show_bug.cgi?id=196636
1675
1676         Unreviewed build fix for Windows port.
1677
1678         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1679         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1680
1681 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1682
1683         [CMake][WinCairo] Separate copied headers into different directories
1684         https://bugs.webkit.org/show_bug.cgi?id=196655
1685
1686         Reviewed by Michael Catanzaro.
1687
1688         * DumpRenderTree/CMakeLists.txt:
1689         * MiniBrowser/win/CMakeLists.txt:
1690         * TestWebKitAPI/CMakeLists.txt:
1691         * TestWebKitAPI/PlatformWin.cmake:
1692
1693 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1694
1695         Log stack-trace for run-webkit-tests when interrupted
1696         https://bugs.webkit.org/show_bug.cgi?id=176393
1697         <rdar://problem/34262310>
1698
1699         Reviewed by Lucas Forschler.
1700
1701         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1702         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1703         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1704         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1705         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1706         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1707         (main): Set handlers to log stack trace on interruption.
1708
1709 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1710
1711         AX: Support API: accessibilityReplaceRange:withText
1712         https://bugs.webkit.org/show_bug.cgi?id=196636
1713
1714         Unreviewed build fix for Windows port.
1715
1716         * DumpRenderTree/AccessibilityUIElement.cpp:
1717         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1718
1719 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1720
1721         [ews-build] Scripts using Buildbot API have CORS error
1722         https://bugs.webkit.org/show_bug.cgi?id=196709
1723
1724         Reviewed by Alexey Proskuryakov.
1725
1726         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1727
1728 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1729
1730         AX: Support API: accessibilityReplaceRange:withText
1731         https://bugs.webkit.org/show_bug.cgi?id=196636
1732
1733         Reviewed by Daniel Bates.
1734
1735         * DumpRenderTree/AccessibilityUIElement.cpp:
1736         (replaceTextInRangeCallback):
1737         (AccessibilityUIElement::replaceTextInRange):
1738         (AccessibilityUIElement::getJSClass):
1739         * DumpRenderTree/AccessibilityUIElement.h:
1740         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1741         (AccessibilityUIElement::replaceTextInRange):
1742         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1743         (AccessibilityUIElement::replaceTextInRange):
1744         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1745         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1746         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1747         (WTR::AccessibilityUIElement::replaceTextInRange):
1748         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1749         (WTR::AccessibilityUIElement::replaceTextInRange):
1750
1751 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1752
1753         [iOS] Do not allow starting selection drags when selection views are not visible
1754         https://bugs.webkit.org/show_bug.cgi?id=196686
1755         <rdar://problem/49399192>
1756
1757         Reviewed by Tim Horton.
1758
1759         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1760         also add some new API tests to cover scenarios where the web view is not first responder.
1761
1762         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1763         (TestWebKitAPI::TEST):
1764         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1765
1766         Add a switch to optionally make the web view first responder when starting the simulated drag.
1767
1768         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1769         (-[DragAndDropSimulator initWithWebView:]):
1770         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1771
1772 2019-04-08  Justin Fan  <justin_fan@apple.com>
1773
1774         [Web GPU] Fix Web GPU experimental feature on iOS
1775         https://bugs.webkit.org/show_bug.cgi?id=196632
1776
1777         Reviewed by Myles C. Maxfield.
1778
1779         Properly make Web GPU available on iOS 11+.
1780
1781         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1782
1783 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1784
1785         [ews-build] Do not upload archive when Compile Fails
1786         https://bugs.webkit.org/show_bug.cgi?id=196674
1787
1788         Reviewed by Alexey Proskuryakov.
1789
1790         * BuildSlaveSupport/ews-build/factories.py:
1791         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1792         * BuildSlaveSupport/ews-build/steps.py:
1793         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1794         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1795         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1796
1797 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1798
1799         Enable DFG on MIPS
1800         https://bugs.webkit.org/show_bug.cgi?id=196689
1801
1802         Reviewed by Žan Doberšek.
1803
1804         Since the bytecode change, we enabled the baseline JIT on mips in
1805         r240432, but DFG is still missing. With this change, all tests are
1806         passing on a ci20 board.
1807
1808         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1809
1810 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1811
1812         [Flatpak] Second run update-webkitwpe-flatpak fails
1813         https://bugs.webkit.org/show_bug.cgi?id=192702
1814
1815         Reviewed by Carlos Garcia Campos.
1816
1817         * flatpak/flatpakutils.py:
1818         (FlatpakObject.flatpak): Fix typo.
1819         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1820         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1821
1822 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1823
1824         [GTK][WPE] outlook.live.com displays old-fashioned UI
1825         https://bugs.webkit.org/show_bug.cgi?id=196642
1826
1827         Reviewed by Carlos Garcia Campos.
1828
1829         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1830         (TestWebKitAPI::TEST): New Mac platform quirk test.
1831
1832 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1833
1834         Unreviewed, rolling out r243956.
1835         https://bugs.webkit.org/show_bug.cgi?id=196688
1836
1837         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1838         by aakashjain on #webkit).
1839
1840         Reverted changeset:
1841
1842         "Clicking "Go Back" from a safe browsing warning from an
1843         iframe should navigate the WKWebView back to the previous
1844         page"
1845         https://bugs.webkit.org/show_bug.cgi?id=196665
1846         https://trac.webkit.org/changeset/243956
1847
1848 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1849
1850         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1851         https://bugs.webkit.org/show_bug.cgi?id=196669
1852
1853         Reviewed by Geoffrey Garen.
1854
1855         Added three new unit tests for WeakHashSet.
1856
1857         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1858         (WTF_WeakPtr.WeakHashSetConstObjects):
1859         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1860         (WTF_WeakPtr.WeakHashSetComputeSize):
1861
1862 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1863
1864         Hide next and previous form control buttons when WKWebView is editable
1865         https://bugs.webkit.org/show_bug.cgi?id=196672
1866         <rdar://problem/35625321>
1867
1868         Reviewed by Tim Horton.
1869
1870         Add a new API test.
1871
1872         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1873         (-[TestWKWebView lastTrailingBarButtonGroup]):
1874         (TestWebKitAPI::TEST):
1875         * TestWebKitAPI/ios/UIKitSPI.h:
1876
1877 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1878
1879         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1880         https://bugs.webkit.org/show_bug.cgi?id=196077
1881         <rdar://problem/49108202>
1882
1883         Reviewed by Chris Dumez.
1884
1885         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1886         on new web view.
1887
1888         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1889
1890 2019-04-05  Saam Barati  <sbarati@apple.com>
1891
1892         Make compare-results understand MotionMark
1893         https://bugs.webkit.org/show_bug.cgi?id=196666
1894
1895         Reviewed by Yusuke Suzuki.
1896
1897         * Scripts/compare-results:
1898         (PLT5Results):
1899         (detectMotionMark):
1900         (detectMotionMark1_1):
1901         (motionMarkResults):
1902         (motionMark1_1Results):
1903         (detectBenchmark):
1904         (biggerIsBetter):
1905         (main):
1906
1907 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1908
1909         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1910         https://bugs.webkit.org/show_bug.cgi?id=196665
1911         <rdar://45115669>
1912
1913         Reviewed by Geoff Garen.
1914
1915         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1916         (goBack):
1917         (+[SimpleLookupContext sharedLookupContext]):
1918         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1919         (TEST):
1920         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1921         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1922
1923 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1924
1925         [ews-build] Add configuration and architecture for windows builders
1926         https://bugs.webkit.org/show_bug.cgi?id=196660
1927
1928         Reviewed by Lucas Forschler.
1929
1930         * BuildSlaveSupport/ews-build/config.json:
1931
1932 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1933
1934         webkitpy: Don't run subsequent rounds if interrupted
1935         https://bugs.webkit.org/show_bug.cgi?id=196646
1936
1937         Reviewed by Aakash Jain.
1938
1939         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1940         (Manager.run): Bail out if interrupted.
1941
1942 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1943
1944         Test sessionStorage in PSON private browsing mode
1945         https://bugs.webkit.org/show_bug.cgi?id=196561
1946
1947         Reviewed by Alex Christensen.
1948
1949         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1950
1951 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1952
1953         Unreviewed, rolling out r243833.
1954         https://bugs.webkit.org/show_bug.cgi?id=196645
1955
1956         This change breaks build of WPE and GTK ports (Requested by
1957         annulen on #webkit).
1958
1959         Reverted changeset:
1960
1961         "[CMake][WTF] Mirror XCode header directories"
1962         https://bugs.webkit.org/show_bug.cgi?id=191662
1963         https://trac.webkit.org/changeset/243833
1964
1965 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1966
1967         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1968         https://bugs.webkit.org/show_bug.cgi?id=196635
1969
1970         Reviewed by Antti Koivisto.
1971         
1972         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1973         for a test to enable async frame scrolling via:
1974             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1975         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1976         
1977         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1978
1979         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1980         (WTR::InjectedBundle::beginTesting):
1981         * WebKitTestRunner/TestController.cpp:
1982         (WTR::TestController::resetPreferencesToConsistentValues):
1983
1984 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1985
1986         Use a correct LC_RPATH when building with ASan
1987         https://bugs.webkit.org/show_bug.cgi?id=196576
1988
1989         Reviewed by David Kilzer.
1990
1991         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1992         so that ../Frameworks is checked. This is simpler and more reliable than updating
1993         each SPC service xcconfig.
1994
1995 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1996
1997         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1998         https://bugs.webkit.org/show_bug.cgi?id=196629
1999
2000         Reviewed by Lucas Forschler.
2001
2002         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2003
2004 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2005
2006         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
2007         https://bugs.webkit.org/show_bug.cgi?id=196618
2008
2009         Reviewed by Lucas Forschler.
2010
2011         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2012         (StatusBubble): Added QUEUE_TRIGGERS.
2013         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
2014         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
2015         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
2016         its parent(builder).
2017
2018 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2019
2020         [ews-app] Status-bubble steps are sometimes displayed in reverse order
2021         https://bugs.webkit.org/show_bug.cgi?id=196625
2022
2023         Reviewed by Lucas Forschler.
2024
2025         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2026         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
2027
2028 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2029
2030         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
2031         https://bugs.webkit.org/show_bug.cgi?id=196630
2032
2033         Reviewed by Wenson Hsieh.
2034
2035         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2036
2037 2019-04-04  Youenn Fablet  <youenn@apple.com>
2038
2039         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
2040         https://bugs.webkit.org/show_bug.cgi?id=196543
2041
2042         Reviewed by Alex Christensen.
2043
2044         * WebKitTestRunner/TestController.cpp:
2045         (WTR::TestController::generatePageConfiguration):
2046
2047 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2048
2049         [ews-app] Status bubble should not display skipped buildbot steps
2050         https://bugs.webkit.org/show_bug.cgi?id=196584
2051
2052         Reviewed by Lucas Forschler.
2053
2054         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2055
2056 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2057
2058         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
2059         https://bugs.webkit.org/show_bug.cgi?id=196620
2060
2061         Reviewed by Lucas Forschler.
2062
2063         * BuildSlaveSupport/ews-app/ews/config.py:
2064
2065 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
2066
2067         [Win] DumpRenderTreeWatchDog.py is not checked into source
2068         https://bugs.webkit.org/show_bug.cgi?id=196567
2069         <rdar://problem/49525901>
2070
2071         Reviewed by Lucas Forschler.
2072
2073         This script is used on Win EWS bots to terminate hanging DRT processes.
2074
2075         * EWSTools/dumprendertreewatchdog.py: Added.
2076
2077 2019-04-04  Chris Dumez  <cdumez@apple.com>
2078
2079         Unreviewed, roll out r243858 which made tests time out.
2080
2081         Disable new API tests on Windows instead.
2082
2083         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2084         (TestWebKitAPI::TEST):
2085
2086 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2087
2088         [ATK] Cleanup WebPageAccessibilityObjectAtk
2089         https://bugs.webkit.org/show_bug.cgi?id=196537
2090
2091         Reviewed by Michael Catanzaro.
2092
2093         Also consider files under atk directories as exceptions for GObject conventions.
2094
2095         * Scripts/webkitpy/style/checkers/cpp.py:
2096         (check_identifier_name_in_declaration):
2097
2098 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2099
2100         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2101         https://bugs.webkit.org/show_bug.cgi?id=196588
2102         <rdar://problem/49365787>
2103
2104         Unreviewed build fix for Windows port.
2105
2106         error C3861: 'kill': identifier not found
2107
2108         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2109         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2110
2111 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2112
2113         [ews-build] Cancel build and similar operations should have authentication
2114         https://bugs.webkit.org/show_bug.cgi?id=196520
2115
2116         Reviewed by Dewei Zhu.
2117
2118         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2119         environment variables.
2120
2121 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2122
2123         [ews-build] Do not trigger queues which are not in production yet
2124         https://bugs.webkit.org/show_bug.cgi?id=196581
2125
2126         Reviewed by Dewei Zhu.
2127
2128         * BuildSlaveSupport/ews-build/config.json:
2129
2130 2019-04-03  Chris Dumez  <cdumez@apple.com>
2131
2132         Unreviewed, fix typo in the name of API test added in r243848.
2133
2134         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2135         (TestWebKitAPI::TEST):
2136
2137 2019-04-03  Chris Dumez  <cdumez@apple.com>
2138
2139         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2140         https://bugs.webkit.org/show_bug.cgi?id=196588
2141         <rdar://problem/49365787>
2142
2143         Reviewed by Ryosuke Niwa.
2144
2145         Add API test coverage.
2146
2147         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2148         (TestWebKitAPI::nullJavaScriptCallback):
2149         (TestWebKitAPI::didCrashCheckFrames):
2150         (TestWebKitAPI::TEST):
2151
2152 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2153
2154         run-webkit-tests: Upload test results (new results database)
2155         https://bugs.webkit.org/show_bug.cgi?id=196577
2156         <rdar://problem/34841155>
2157
2158         Reviewed by Lucas Forschler.
2159
2160         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2161         (Manager.run): Upload results after each device shard, since the configuration will be
2162         different for each device.
2163         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2164         uploaded to a results database.
2165         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2166         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2167
2168 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2169
2170         -apple-trailing-word is needed for browser detection
2171         https://bugs.webkit.org/show_bug.cgi?id=196575
2172
2173         Unreviewed.
2174
2175         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2176
2177 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2178
2179         [CMake][WTF] Mirror XCode header directories
2180         https://bugs.webkit.org/show_bug.cgi?id=191662
2181
2182         Reviewed by Konstantin Tokarev.
2183
2184         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2185         builds.
2186
2187         * CMakeLists.txt:
2188         * DumpRenderTree/CMakeLists.txt:
2189         * DumpRenderTree/PlatformWin.cmake:
2190         * MiniBrowser/win/CMakeLists.txt:
2191         * TestWebKitAPI/CMakeLists.txt:
2192         * TestWebKitAPI/PlatformWin.cmake:
2193         * WebKitTestRunner/PlatformGTK.cmake:
2194         * WebKitTestRunner/PlatformWin.cmake:
2195
2196 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2197
2198         [ews-app] Status bubble should not display certain infrastructure status messages
2199         https://bugs.webkit.org/show_bug.cgi?id=196550
2200
2201         Reviewed by Lucas Forschler.
2202
2203         Do not display the steps which are un-needed for end-user. This information is still avaiable
2204         if the user click on the bubble and look at the Buildbot build.
2205         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2206         (StatusBubble._steps_messages):
2207         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2208
2209 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2210
2211         [ews-build] Use https for sending data to ews-app
2212         https://bugs.webkit.org/show_bug.cgi?id=196492
2213
2214         Reviewed by Lucas Forschler.
2215
2216         * BuildSlaveSupport/ews-build/events.py:
2217
2218 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2219
2220         Remove support for -apple-trailing-word
2221         https://bugs.webkit.org/show_bug.cgi?id=196525
2222
2223         Reviewed by Zalan Bujtas.
2224
2225         This CSS property is nonstandard and not used.
2226
2227         * Scripts/webkitperl/FeatureList.pm:
2228         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2229
2230 2019-04-03  Youenn Fablet  <youenn@apple.com>
2231
2232         Add a test for DOMCache on multiple browsing in case of private browsing
2233         https://bugs.webkit.org/show_bug.cgi?id=196524
2234
2235         Reviewed by Alex Christensen.
2236
2237         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2238         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2239
2240 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2241
2242         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2243         https://bugs.webkit.org/show_bug.cgi?id=196540
2244
2245         Reviewed by Aakash Jain.
2246
2247         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2248
2249 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2250
2251         Add plumbing for a compatibility mode preference in WebKit
2252         https://bugs.webkit.org/show_bug.cgi?id=196005
2253
2254         Reviewed by Tim Horton.
2255
2256         Add new API tests.
2257
2258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2259         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2260
2261 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2262
2263         [WPE][GTK] Update libsrtp dependency package for Debian
2264         https://bugs.webkit.org/show_bug.cgi?id=196528
2265
2266         Reviewed by Frédéric Wang.
2267
2268         * gtk/install-dependencies:
2269         * wpe/install-dependencies:
2270
2271 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2272
2273         [WK2] Add support for Window's beforeprint / afterprint events
2274         https://bugs.webkit.org/show_bug.cgi?id=196478
2275         <rdar://problem/49535124>
2276
2277         Unreviewed build fix for MSVC.
2278
2279         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2280
2281         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2282
2283         * WebKitTestRunner/TestController.cpp:
2284         (WTR::printFrame): Use int and float literals.
2285
2286 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2287
2288         [ews-build] Reassign bots to queues
2289
2290         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2291
2292 2019-04-02  Chris Dumez  <cdumez@apple.com>
2293
2294         [WK2] Add support for Window's beforeprint / afterprint events
2295         https://bugs.webkit.org/show_bug.cgi?id=196478
2296
2297         Reviewed by Alex Christensen.
2298
2299         Add minimal implementation for printFrame in WebKitTestRunner.
2300
2301         * WebKitTestRunner/TestController.cpp:
2302         (WTR::printFrame):
2303         (WTR::TestController::createOtherPage):
2304         (WTR::TestController::createWebViewWithOptions):
2305
2306 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2307
2308         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2309         https://bugs.webkit.org/show_bug.cgi?id=196491
2310
2311         Reviewed by Lucas Forschler.
2312
2313         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2314
2315 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2316
2317         [ews-build] Configure buildbot try credentials in environment variables
2318         https://bugs.webkit.org/show_bug.cgi?id=196501
2319
2320         Reviewed by Lucas Forschler.
2321
2322         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2323         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2324         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2325
2326 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2327
2328         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2329         https://bugs.webkit.org/show_bug.cgi?id=196496
2330         <rdar://problem/49521634>
2331
2332         Reviewed by Chris Dumez.
2333
2334         Add new API tests (see WebKit ChangeLog for more detail).
2335
2336         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2337         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2338         (TEST):
2339
2340 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2341
2342         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2343         <https://webkit.org/b/196499>
2344
2345         Reviewed by Alexey Proskuryakov.
2346
2347         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2348         ENABLE_ADDRESS_SANITIZER.
2349
2350 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2351
2352         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2353         https://bugs.webkit.org/show_bug.cgi?id=182757
2354
2355         Reviewed by Don Olmstead.
2356
2357         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2358         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2359
2360 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2361
2362         run-api-tests: Upload test results
2363         https://bugs.webkit.org/show_bug.cgi?id=196323
2364         <rdar://problem/49356714>
2365
2366         Reviewed by Lucas Forschler.
2367
2368         * Scripts/webkitpy/api_tests/manager.py:
2369         (Manager):
2370         (Manager.run): Upload results to a results database.
2371         * Scripts/webkitpy/api_tests/run_api_tests.py:
2372         (parse_args): Add upload arguments.
2373         * Scripts/webkitpy/port/base.py:
2374         (Port):
2375         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2376         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2377         with commits from any other associated repositories.
2378         * Scripts/webkitpy/port/device.py:
2379         (Device):
2380         (Device.build_version): Access build_versoin of underlying platform device.
2381         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2382         (IOSSimulatorTest):
2383         (IOSSimulatorTest.test_configuration_for_upload):
2384         * Scripts/webkitpy/port/device_port.py:
2385         (DevicePort):
2386         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2387         the same as the machine uploading results.
2388         * Scripts/webkitpy/port/mac.py:
2389         (MacPort):
2390         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2391         * Scripts/webkitpy/port/mac_unittest.py:
2392         (MacTest):
2393         (MacTest.test_configuration_for_upload):
2394         * Scripts/webkitpy/xcode/simulated_device.py:
2395         (SimulatedDeviceManager._create_device_with_runtime):
2396         (SimulatedDevice.__init__): Create simulated device with a build_version.
2397         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2398         (test_existing_simulator):
2399
2400 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2401
2402         Remove extra newline characters (Follow-up fix to r243707)
2403
2404         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2405
2406 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2407
2408         [ews-app] Use API_KEY to accept results data
2409         https://bugs.webkit.org/show_bug.cgi?id=196461
2410
2411         Reviewed by Dewei Zhu.
2412
2413         * BuildSlaveSupport/ews-app/ews/views/results.py:
2414         (Results.post): Validate EWS_API_KEY before accepting any data.
2415         * BuildSlaveSupport/ews-build/events.py:
2416         (Events.sendData): Send EWS_API_KEY if available along with event data.
2417
2418 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2419
2420         Unable to copy and paste a PDF from Notes into Mail compose body
2421         https://bugs.webkit.org/show_bug.cgi?id=196442
2422         <rdar://problem/48573098>
2423
2424         Reviewed by Tim Horton.
2425
2426         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2427         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2428         to be specified on the item providers.
2429
2430         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2431         (TestWebKitAPI::mapItemForTesting):
2432         (TestWebKitAPI::contactItemForTesting):
2433
2434 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2435
2436         Make UIWKDocumentContext rects per-character instead of per-word
2437         https://bugs.webkit.org/show_bug.cgi?id=196459
2438
2439         Reviewed by Wenson Hsieh.
2440
2441         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2442         (TEST):
2443         Adjust test results due to switching to per-character rects.
2444
2445 2019-04-01  Chris Dumez  <cdumez@apple.com>
2446
2447         UIProcess crash when a prewarmed process is terminated
2448         https://bugs.webkit.org/show_bug.cgi?id=196451
2449         <rdar://problem/49245471>
2450
2451         Reviewed by Geoffrey Garen.
2452
2453         Add API test coverage.
2454
2455         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2456         (TEST):
2457
2458 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2459
2460         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2461         https://bugs.webkit.org/show_bug.cgi?id=196449
2462
2463         Reviewed by Lucas Forschler.
2464
2465         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2466         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2467         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2468         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2469
2470 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2471
2472         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2473         https://bugs.webkit.org/show_bug.cgi?id=196444
2474
2475         Reviewed by Lucas Forschler.
2476
2477         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2478
2479 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2480
2481         Add SPI to canonicalize NSURLs with WTF::URL
2482         https://bugs.webkit.org/show_bug.cgi?id=196415
2483         <rdar://problem/44980271>
2484
2485         Reviewed by Darin Adler.
2486
2487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2488         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2489         (TestWebKitAPI::TEST):
2490
2491 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2492
2493         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2494         https://bugs.webkit.org/show_bug.cgi?id=196441
2495
2496         Reviewed by Carlos Garcia Campos.
2497
2498         Don't cache the wpe_view_backend object that might not exist yet at the
2499         time of EventSenderProxy constructor invocation, but instead retrieve
2500         that object whenever it's required for event dispatching. This should
2501         avoid crashes in this constructor now that it's invoked before any
2502         PlatformWindow has been set up (as changed in r243496).
2503
2504         * WebKitTestRunner/EventSenderProxy.h:
2505         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2506         (WTR::viewBackend):
2507         (WTR::EventSenderProxy::EventSenderProxy):
2508         (WTR::EventSenderProxy::mouseDown):
2509         (WTR::EventSenderProxy::mouseUp):
2510         (WTR::EventSenderProxy::mouseMoveTo):
2511         (WTR::EventSenderProxy::mouseScrollBy):
2512         (WTR::EventSenderProxy::keyDown):
2513         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2514
2515 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2516
2517         [Win][WebKit] MiniBrowser should support high DPI display
2518         https://bugs.webkit.org/show_bug.cgi?id=196391
2519
2520         Reviewed by Alex Christensen.
2521
2522         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2523         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2524         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2525         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2526
2527 2019-03-31  Sam Weinig  <weinig@apple.com>
2528
2529         Remove more i386 specific configurations
2530         https://bugs.webkit.org/show_bug.cgi?id=196430
2531
2532         Reviewed by Alexey Proskuryakov.
2533
2534         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2535         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2536
2537 2019-03-31  Andy Estes  <aestes@apple.com>
2538
2539         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2540         https://bugs.webkit.org/show_bug.cgi?id=196433
2541         <rdar://problem/49293305>
2542
2543         Reviewed by Tim Horton.
2544
2545         Enhanced API test coverage to include all navigation response policy decisions in both
2546         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2547
2548         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2549         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2550         (TestWebKitAPI::TEST):
2551         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2552         (readFile):
2553         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2554         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2555         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2556         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2557         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2558         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2559         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2560         (-[QuickLookDelegate _downloadDidStart:]):
2561         (-[QuickLookDelegate _download:didReceiveResponse:]):
2562         (-[QuickLookDelegate _download:didReceiveData:]):
2563         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2564         (-[QuickLookDelegate _downloadDidFinish:]):
2565         (-[QuickLookDelegate _download:didFailWithError:]):
2566         (-[QuickLookDelegate _downloadDidCancel:]):
2567         (-[QuickLookDelegate verifyDownload]):
2568         (runTest):
2569         (runTestDecideBeforeLoading):
2570         (runTestDecideAfterLoading):
2571         (TEST):
2572         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2573         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2574         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2575         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2576         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2577         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2578         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2579         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2580         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2581         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2582         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2583         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2584         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2585         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2586
2587 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2588
2589         [CMake] add testdfg as target with build-jsc
2590         https://bugs.webkit.org/show_bug.cgi?id=196393
2591
2592         Reviewed by Saam Barati.
2593
2594         Added testdfg as one of the targets to build when
2595         using CMake.
2596
2597         * Scripts/build-jsc:
2598
2599 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2600
2601         Delete WebMetal implementation in favor of WebGPU
2602         https://bugs.webkit.org/show_bug.cgi?id=195418
2603
2604         Reviewed by Dean Jackson.
2605
2606         * DumpRenderTree/mac/DumpRenderTree.mm:
2607         (enableExperimentalFeatures):
2608         (resetWebPreferencesToConsistentValues):
2609         * Scripts/webkitperl/FeatureList.pm:
2610         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2611         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2612         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2613         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2614         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2615         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2616         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2617         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2618         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2619         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2620         (WTR::InjectedBundle::beginTesting):
2621         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2622         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2623         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2624
2625 2019-03-29  Chris Dumez  <cdumez@apple.com>
2626
2627         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2628         https://bugs.webkit.org/show_bug.cgi?id=196405
2629         <rdar://problem/49428130>
2630
2631         Reviewed by Wenson Hsieh.
2632
2633         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2634         the popover presentation methods to be no-ops. Use this in the new test added in
2635         r243523 so that we do not swizzle those methods for all tests. This is needed because
2636         those WatchOS tests rely on the popover getting presented and interactive.
2637
2638         * WebKitTestRunner/TestController.cpp:
2639         (WTR::updateTestOptionsFromTestHeader):
2640         * WebKitTestRunner/TestController.h:
2641         * WebKitTestRunner/TestOptions.h:
2642         (WTR::TestOptions::hasSameInitializationOptions const):
2643         * WebKitTestRunner/ios/TestControllerIOS.mm:
2644         (WTR::TestController::platformInitialize):
2645         (WTR::TestController::platformResetStateToConsistentValues):
2646
2647 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2648
2649         [Curl] Add Server Trust Evaluation Support.
2650         https://bugs.webkit.org/show_bug.cgi?id=191646
2651
2652         Reviewed by Fujii Hironori.
2653
2654         Implemented MiniBrowser UI for asking if user trusts the server.
2655
2656         * MiniBrowser/win/Common.cpp:
2657         (askServerTrustEvaluation):
2658         (replaceString):
2659         * MiniBrowser/win/Common.h:
2660         * MiniBrowser/win/MiniBrowserLib.rc:
2661         * MiniBrowser/win/MiniBrowserLibResource.h:
2662         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2663         (createPEMString):
2664         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2665         (WebKitBrowserWindow::canTrustServerCertificate):
2666         * MiniBrowser/win/WebKitBrowserWindow.h:
2667
2668 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2669
2670         Implement ResizeObserver.
2671         https://bugs.webkit.org/show_bug.cgi?id=157743
2672
2673         Reviewed by Simon Fraser.
2674
2675         Support resizeObserverEnabled webPreferences.
2676
2677         * DumpRenderTree/TestOptions.cpp:
2678         (TestOptions::TestOptions):
2679         * DumpRenderTree/TestOptions.h:
2680         * DumpRenderTree/mac/DumpRenderTree.mm:
2681         (setWebPreferencesForTestOptions):
2682         * DumpRenderTree/win/DumpRenderTree.cpp:
2683         (enableExperimentalFeatures):
2684         * Scripts/webkitperl/FeatureList.pm:
2685         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2686
2687 2019-03-28  John Wilander  <wilander@apple.com>
2688
2689         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2690         https://bugs.webkit.org/show_bug.cgi?id=196281
2691         <rdar://problem/48938748>
2692
2693         Reviewed by Alex Christensen.
2694
2695         This patch adds the function isStatisticsHasLocalStorage() to the
2696         TestRunner. With it, the page can query the WebsiteDataStore in the
2697         UI process to make sure that it sees LocalStorage.
2698
2699         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2700         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2701         (WTR::TestRunner::isStatisticsHasLocalStorage):
2702         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2703         * WebKitTestRunner/TestController.cpp:
2704         (WTR::TestController::isStatisticsHasLocalStorage):
2705         * WebKitTestRunner/TestController.h:
2706         * WebKitTestRunner/TestInvocation.cpp:
2707         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2708
2709 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2710
2711         API::Data::createWithoutCopying should do a null check before calling CFRelease
2712         https://bugs.webkit.org/show_bug.cgi?id=196276
2713         <rdar://problem/48059859>
2714
2715         Reviewed by Alex Christensen.
2716
2717         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2718
2719         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2720         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2721         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2722         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2723         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2724         (TestWebKitAPI::TEST):
2725
2726 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2727
2728         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2729         https://bugs.webkit.org/show_bug.cgi?id=186276
2730
2731         Reviewed by Carlos Garcia Campos.
2732
2733         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2734         (webViewLoadChanged):
2735         (testWebResourceGetDataError):
2736         (testWebResourceGetDataEmpty):
2737         (beforeAll):
2738         (webViewloadChanged): Deleted.
2739
2740 2019-03-27  Andy Estes  <aestes@apple.com>
2741
2742         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2743         https://bugs.webkit.org/show_bug.cgi?id=196317
2744
2745         Reviewed by Dan Bernstein.
2746
2747         package-root copies built products into a staging directory using ditto(1), which does not
2748         follow symbolic links as it traverses a directory. Now that the files in
2749         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2750         itself, these become broken links when ditto'd into the staging directory.
2751
2752         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2753
2754         * Scripts/package-root:
2755
2756 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2757
2758         [ews-app] Update display text of Submit for ews analysis
2759         https://bugs.webkit.org/show_bug.cgi?id=196309
2760
2761         Reviewed by Dewei Zhu.
2762
2763         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2764
2765 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2766
2767         run-webkit-tests should check for leaks in WebKit processes
2768         <https://webkit.org/b/193772>
2769         <rdar://problem/46526680>
2770
2771         Reviewed by Ryosuke Niwa.
2772
2773         This works by doing the following:
2774         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2775           The list of child processes are returned one per line:
2776           process.name: pid
2777         - Run the "#LIST CHILD PROCESSES" command just before the
2778           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2779           processes on the ServerProcess object.
2780         - When the `--leaks` switch is handled, run check_for_leaks() on
2781           each child process after the main test harness.
2782
2783         * DumpRenderTree/mac/DumpRenderTree.mm:
2784         (handleControlCommand):
2785         - Use strncmp() instead of strcmp().
2786         - Add support for handling "#LIST CHILD PROCESSES" command.
2787
2788         * Scripts/webkitpy/port/base.py:
2789         (Port.check_for_leaks):
2790         * Scripts/webkitpy/port/darwin.py:
2791         (DarwinPort.check_for_leaks):
2792         - Rename redundant 'process_pid' argument to 'process_id'.
2793
2794         * Scripts/webkitpy/port/driver.py:
2795         (Driver.do_post_tests_work):
2796         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2797           longer the only command this sends to WebKitTestRunner.
2798         - If the `--leaks` switch is present, send the
2799           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2800           result using Port.set_webkit_processes().
2801         (Driver._parse_child_processes_output):
2802         - Add helper method to parse list of child process names and
2803           process IDs returned from WebKitTestRunner.
2804
2805         * Scripts/webkitpy/port/ios_device.py:
2806         (IOSDevicePort.check_for_leaks):
2807         - Rename redundant 'process_pid' argument to 'process_id'.
2808
2809         * Scripts/webkitpy/port/leakdetector.py:
2810         (LeakDetector._parse_leaks_output):
2811         - Return early if there is no leaks_output.
2812         (LeakDetector.check_for_leaks):
2813         - Rename redundant 'process_pid' argument to 'process_id'.
2814
2815         * Scripts/webkitpy/port/server_process.py:
2816         (ServerProcess.__init__):
2817         (ServerProcess.child_processes):
2818         (ServerProcess.set_child_processes):
2819         - Add instance variable to Port to store list of child process
2820           names and process IDs returned from WebKitTestRunner.
2821         (ServerProcess._start):
2822         - Clear self._child_processes.
2823         (ServerProcess.stop):
2824         - If self._child_processes is set, call
2825           self._port.check_for_leaks() for each child process.
2826
2827         * Scripts/webkitpy/port/server_process_unittest.py:
2828         (TrivialMockPort.check_for_leaks):
2829         - Rename redundant 'process_pid' argument to 'process_id'.
2830
2831         * Scripts/webkitpy/port/simulator_process.py:
2832         (SimulatorProcess.stop):
2833         - If self._child_processes is set, call
2834           self._port.check_for_leaks() for each child process.
2835
2836         * Scripts/webkitpy/port/watch_device.py:
2837         (WatchDevicePort.check_for_leaks):
2838         - Rename redundant 'process_pid' argument to 'process_id'.
2839
2840         * WebKitTestRunner/TestController.cpp:
2841         (WTR::TestController::dumpResponse):
2842         - Extract method from findAndDumpWorldLeaks() so that it may be
2843           reused by findAndDumpWebKitProcessIdentifiers().
2844         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2845         - Add method to output process name and process ID of both the
2846           WebContent and Networking processes.
2847         (WTR::TestController::findAndDumpWorldLeaks):
2848         - Fix missing newline in output when there were no abandoned
2849           documents.
2850         - Call dumpResponse() for extracted code.
2851         (WTR::TestController::handleControlCommand):
2852         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2853         - Use strncmp() instead of strcmp().
2854         - Call findAndDumpWebKitProcessIdentifiers() when
2855           "#LIST CHILD PROCESSES" command is sent.
2856         * WebKitTestRunner/TestController.h:
2857         (WTR::TestController::dumpResponse):
2858         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2859         - Declare methods.
2860
2861 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2862
2863         Unreviewed. Add GLib API test cases after r243434.
2864
2865         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2866         (testWebViewActiveURI):
2867         (serverCallback):
2868         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2869         (sendRequestCallback):
2870
2871 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2872
2873         Geolocation request not complete when watch request was started in a different web process
2874         https://bugs.webkit.org/show_bug.cgi?id=195996
2875
2876         Reviewed by Alex Christensen.
2877
2878         Add a test case.
2879
2880         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2881         (TestWebKitAPI::runJavaScriptAlert):
2882         (TestWebKitAPI::TEST):
2883
2884 2019-03-26  Keith Rollin  <krollin@apple.com>
2885
2886         Update the way generate-xcfilelists returns strings from functions
2887         https://bugs.webkit.org/show_bug.cgi?id=195975
2888         <rdar://problem/49040807>
2889
2890         Reviewed by Dean Jackson.
2891
2892         There are places where generate-xcfilelists executes assignments with
2893         statements like:
2894
2895             FOO=$(some_function)
2896
2897         where "some_function" return a string by echoing it. E.g.
2898
2899             some_function()
2900             {
2901                 echo "Hello, World"
2902             }
2903
2904         This is a common idiom, but it has a problem if "some_function" needs
2905         to call "exit" in an attempt to halt the entire script right then and
2906         there. Since "some_function" is called inside of $(), it's being
2907         executed in a sub-shell. Calling exit in that sub-shell simply exits
2908         that shell; it doesn't not exit the outer shell in which the main part
2909         of the script is still running. As such, the main script keeps
2910         executing when the intent was for the script to halt.
2911
2912         The solution to this is to use a different idiom for returning
2913         strings. The one we now is to pass in the name of the variable to
2914         receive the string result:
2915
2916             some_function()
2917             {
2918                 variable_name=$1
2919                 eval $variable_name ="Hello, World"
2920             }
2921
2922         The call site now looks like
2923
2924             some_function FOO
2925
2926         Because there's no invocation of a sub-shell, some_function can now
2927         call "exit" if it wants to, and the entire script will exit at that
2928         point.
2929
2930         * Scripts/generate-xcfilelists:
2931
2932 2019-03-26  Chris Dumez  <cdumez@apple.com>
2933
2934         Add basic layout test coverage for File Picker on iOS
2935         https://bugs.webkit.org/show_bug.cgi?id=196265
2936
2937         Reviewed by Wenson Hsieh.
2938
2939         Add layout test infrastructure to test the file picker on iOS.
2940
2941         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2942         (WTR::UIScriptController::dismissFilePicker):
2943         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2944         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2945         (WTR::UIScriptController::dismissFilePicker):
2946         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2947         * WebKitTestRunner/TestController.cpp:
2948         (WTR::TestController::createWebViewWithOptions):
2949         (WTR::updateTestOptionsFromTestHeader):
2950         * WebKitTestRunner/TestOptions.h:
2951         (WTR::TestOptions::hasSameInitializationOptions const):
2952         * WebKitTestRunner/ios/TestControllerIOS.mm:
2953         (overridePresentViewController):
2954         (WTR::TestController::platformInitialize):
2955         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2956         (WTR::UIScriptController::dismissFilePicker):
2957
2958 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2959
2960         Implement async paste method on UIWKInteractionViewProtocol
2961         https://bugs.webkit.org/show_bug.cgi?id=196267
2962         <rdar://problem/49236346>
2963
2964         Reviewed by Tim Horton.
2965
2966         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2967         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2968         are now a part of all iOS 12 internal SDKs.
2969
2970         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2971
2972         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2973         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2974
2975         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2976         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2977         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2978         * TestWebKitAPI/ios/UIKitSPI.h:
2979
2980 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2981
2982         [ews-build] Use PostgreSQL for ews.webkit.org database
2983         https://bugs.webkit.org/show_bug.cgi?id=196270
2984
2985         Reviewed by Lucas Forschler.
2986
2987         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2988
2989 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2990
2991         [ews] Reset simctl states on reboot
2992         https://bugs.webkit.org/show_bug.cgi?id=196260
2993
2994         Rubber-stamped by Aakash Jain.
2995
2996         * EWSTools/start-queue-mac.sh:
2997
2998 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2999
3000         [ews-build] Use PostgreSQL for ews-build database
3001         https://bugs.webkit.org/show_bug.cgi?id=196229
3002
3003         Reviewed by Lucas Forschler.
3004
3005         * BuildSlaveSupport/ews-build/master.cfg:
3006
3007 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3008
3009         [ews-build] Get master_hostname dynamically in master.cfg
3010         https://bugs.webkit.org/show_bug.cgi?id=196255
3011
3012         Reviewed by Lucas Forschler.
3013
3014         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
3015         send events data in test mode.
3016
3017 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3018
3019         [ews-app] Set db_constraint to False for Foreign Keys
3020         https://bugs.webkit.org/show_bug.cgi?id=196252
3021
3022         Reviewed by Lucas Forschler.
3023
3024         * BuildSlaveSupport/ews-app/ews/models/build.py:
3025         * BuildSlaveSupport/ews-app/ews/models/step.py:
3026
3027 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3028
3029         [ews-build] is_test_mode_enabled should default to True
3030         https://bugs.webkit.org/show_bug.cgi?id=196248
3031
3032         Reviewed by Lucas Forschler.
3033
3034         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
3035
3036 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3037
3038         [ews-app] Add webkitperl to ENABLED_QUEUES
3039         https://bugs.webkit.org/show_bug.cgi?id=196253
3040
3041         Reviewed by Lucas Forschler.
3042
3043         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3044
3045 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
3046
3047         Address NSWindow sometimes using WebKitTestRunnerEvent too early
3048         https://bugs.webkit.org/show_bug.cgi?id=196211
3049         rdar://problem/49110552
3050
3051         Reviewed by Tim Horton.
3052
3053         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
3054         Make sure that EventSenderProxy always exists when running tests. We used to create
3055         it when resetting before the first test, which is a bit too late.
3056
3057         * WebKitTestRunner/TestController.h:
3058         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3059         (WTR::TestController::platformCreateWebView):
3060         (WTR::TestController::platformCreateOtherPage):
3061         (WTR::TestController::finishCreatingPlatformWebView):
3062         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3063         (WTR::PlatformWebView::PlatformWebView):
3064         Moved some code that made NSWindow use NSEvent during web view creation. We may
3065         need to move more if some other case us found, but this is enough for now.
3066
3067 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3068
3069         Unreviewed. Fix typo in GLib geolocation API after r243285.
3070
3071         gelocation -> geolocation.
3072
3073         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
3074         (testGeolocationManagerWatchPosition):
3075
3076 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3077
3078         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3079         https://bugs.webkit.org/show_bug.cgi?id=196213
3080
3081         Reviewed by Geoff Garen.
3082
3083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3084         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3085         (credentialWithIdentityAndKeychainPath):
3086         (-[ChallengeDelegate webView:didFinishNavigation:]):
3087         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3088         (TestWebKitAPI::TEST):
3089
3090 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3091
3092         Expected shouldn't assume its contained types are copyable
3093         https://bugs.webkit.org/show_bug.cgi?id=195986
3094
3095         Reviewed by JF Bastien.
3096
3097         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3098         (TestWebKitAPI::NonCopyable::operator== const):
3099         (TestWebKitAPI::NonCopyable::operator!= const):
3100         (TestWebKitAPI::TEST):
3101
3102 2019-03-25  Tim Horton  <timothy_horton@apple.com>
3103
3104         Remove some now-unnecessary dynamic class lookup
3105         https://bugs.webkit.org/show_bug.cgi?id=196237
3106
3107         Reviewed by Simon Fraser.
3108
3109         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3110         (makeRequest):
3111         (TEST):
3112
3113 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
3114
3115         Unreviewed, rolling out r243450.
3116
3117         AppleWin and WinCairo port builds get broken.
3118
3119         Reverted changeset:
3120
3121         "Add test for fix of #196095"
3122         https://bugs.webkit.org/show_bug.cgi?id=196097
3123         https://trac.webkit.org/changeset/243450
3124
3125 2019-03-25  Commit Queue  <commit-queue@webkit.org>
3126
3127         Unreviewed, rolling out r243465.
3128         https://bugs.webkit.org/show_bug.cgi?id=196226
3129
3130         the test doesn't build (Requested by thorton on #webkit).
3131
3132         Reverted changeset:
3133
3134         "Do not terminate the NetworkProcess if a third party
3135         application sends a NSCredential with a SecIdentityRef"
3136         https://bugs.webkit.org/show_bug.cgi?id=196213
3137         https://trac.webkit.org/changeset/243465
3138
3139 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3140
3141         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3142         https://bugs.webkit.org/show_bug.cgi?id=196213
3143
3144         Reviewed by Geoff Garen.
3145
3146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3147         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3148         (credentialWithIdentityAndKeychainPath):
3149         (-[ChallengeDelegate webView:didFinishNavigation:]):
3150         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3151         (TestWebKitAPI::TEST):
3152
3153 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3154
3155         [ews-build] Gracefully handle missing patch_id in events
3156         https://bugs.webkit.org/show_bug.cgi?id=196216
3157
3158         Reviewed by Lucas Forschler.
3159
3160         * BuildSlaveSupport/ews-build/events.py:
3161
3162 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3163
3164         [ews-build] use lz4 compression for improving buildbot performance
3165         https://bugs.webkit.org/show_bug.cgi?id=196155
3166
3167         Reviewed by Lucas Forschler.
3168
3169         * BuildSlaveSupport/ews-build/master.cfg:
3170
3171 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3172
3173         Pull some API testing helper methods out of TestWKWebView
3174         https://bugs.webkit.org/show_bug.cgi?id=196212
3175
3176         Reviewed by Tim Horton.
3177
3178         Refactor some more API testing utility methods, so that they can be used in
3179         tests that do not use TestWKWebView.
3180
3181         * TestWebKitAPI/cocoa/TestWKWebView.h:
3182         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3183         (-[WKWebView loadTestPageNamed:]):
3184         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
3185         (-[WKWebView synchronouslyLoadHTMLString:]):
3186         (-[WKWebView synchronouslyLoadTestPageNamed:]):
3187         (-[TestWKWebView loadTestPageNamed:]): Deleted.
3188         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
3189         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
3190         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
3191
3192 2019-03-25  Jer Noble  <jer.noble@apple.com>
3193
3194         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3195         https://bugs.webkit.org/show_bug.cgi?id=196097
3196
3197         Reviewed by Eric Carlson.
3198
3199         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3200
3201         * DumpRenderTree/mac/DumpRenderTree.mm:
3202         (resetWebPreferencesToConsistentValues):
3203         * WebKitTestRunner/TestController.cpp:
3204         (WTR::TestController::resetPreferencesToConsistentValues):
3205
3206 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3207
3208         Pull IPadUserInterfaceSwizzler out into a separate header file
3209         https://bugs.webkit.org/show_bug.cgi?id=196193
3210
3211         Reviewed by Anders Carlsson.
3212
3213         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
3214         be used in other API tests.
3215
3216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3217         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3218         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
3219         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
3220         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
3221         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3222         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3223
3224 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3225
3226         Remove NavigatorContentUtils in WebCore/Modules
3227         https://bugs.webkit.org/show_bug.cgi?id=196070
3228
3229         Reviewed by Alex Christensen.
3230
3231         NavigatorContentUtils was to support the custom scheme spec [1].
3232         However, in WebKit side, no port has supported the feature in
3233         WebKit layer after EFL port was removed. So there has been the
3234         only IDL implementation of the NavigatorContentUtils in WebCore.
3235         So we don't need to keep the implementation in WebCore anymore.
3236
3237         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
3238
3239         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3240
3241 2019-03-24  Andy Estes  <aestes@apple.com>
3242
3243         [watchOS] Remove unused Proximity Networking code
3244         https://bugs.webkit.org/show_bug.cgi?id=196188
3245
3246         Reviewed by Tim Horton.
3247
3248         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3249         (TEST):
3250
3251 2019-03-23  Keith Miller  <keith_miller@apple.com>
3252
3253         Refactor clz/ctz and fix getLSBSet.
3254         https://bugs.webkit.org/show_bug.cgi?id=196162
3255
3256         Reviewed by Saam Barati.
3257
3258         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3259
3260         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3261         (TestWebKitAPI::TEST):
3262
3263 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3264
3265         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3266         https://bugs.webkit.org/show_bug.cgi?id=196143
3267
3268         Reviewed by Michael Catanzaro.
3269
3270         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3271         directories.
3272
3273         * Scripts/webkitpy/style/checkers/cpp.py:
3274         (check_identifier_name_in_declaration):
3275         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3276         (WebKitStyleTest.test_names):
3277
3278 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3279
3280         [Flatpak] Manifest expanding fails for qt WPE extension
3281         https://bugs.webkit.org/show_bug.cgi?id=196148
3282
3283         Reviewed by Alex Christensen.
3284
3285         * flatpak/flatpakutils.py:
3286         (expand_submodules_recurse): The last recurse manifest expand
3287         iteration might lead to a single module so take it into account
3288         and don't try to recurse further.
3289
3290 2019-03-22  Chris Dumez  <cdumez@apple.com>
3291
3292         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3293         https://bugs.webkit.org/show_bug.cgi?id=195348
3294         <rdar://problem/48622090>
3295
3296         Reviewed by Alex Christensen.
3297
3298         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3299         to NO when test.options().shouldIgnoreMetaViewport is false.
3300
3301         * WebKitTestRunner/ios/TestControllerIOS.mm:
3302         (WTR::TestController::platformConfigureViewForTest):
3303
3304 2019-03-22  Chris Dumez  <cdumez@apple.com>
3305
3306         Prewarmed processes should be usable with any website data store
3307         https://bugs.webkit.org/show_bug.cgi?id=196104
3308
3309         Reviewed by Alex Christensen.
3310
3311         Add API test coverage.
3312
3313         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3314         (runInitialWarmedProcessUsedTest):
3315         (TEST):
3316
3317 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3318
3319         Back out local changes to Alex's Subversion working directory
3320
3321         They were accidentally committed.
3322
3323         * Scripts/webkitpy/common/system/abstractexecutive.py:
3324         (AbstractExecutive.wait_newest):
3325         * Scripts/webkitpy/common/system/executive.py:
3326         (Executive.running_pids):
3327         * Scripts/webkitpy/common/system/executive_mock.py:
3328         (MockExecutive.running_pids):
3329         * Scripts/webkitpy/common/system/executive_unittest.py:
3330         (ExecutiveTest.serial_test_running_pids):
3331         * Scripts/webkitpy/port/darwin.py:
3332         (DarwinPort.check_for_leaks):
3333         * Scripts/webkitpy/port/leakdetector.py:
3334         (LeakDetector.check_for_leaks):
3335         - This was the hack attached to Bug 193772.
3336
3337         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3338         (+[WebKitTestRunnerEvent mouseLocation]):
3339         - This works around a crash on an internal build.
3340
3341 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3342
3343         Fix the build after r243354
3344         https://bugs.webkit.org/show_bug.cgi?id=196138
3345         <rdar://problem/49145951>
3346
3347         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3348         (TEST):
3349         * TestWebKitAPI/ios/UIKitSPI.h:
3350
3351 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3352
3353         Adopt UIWKDocumentContext
3354         https://bugs.webkit.org/show_bug.cgi?id=196040
3355         <rdar://problem/48642440>
3356
3357         Reviewed by Ryosuke Niwa.
3358
3359         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3360         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3361         (makeRequest):
3362         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3363         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3364         (applyStyle):
3365         (TEST):
3366         Add tests for UIWKDocumentContext.
3367
3368         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3369         (TEST):
3370         (recursiveFindWKContentView): Deleted.
3371         * TestWebKitAPI/cocoa/TestWKWebView.h:
3372         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3373         (recursiveFindWKContentView):
3374         (-[TestWKWebView wkContentView]):
3375         * TestWebKitAPI/ios/UIKitSPI.h:
3376         Share the WKContentView finding code between tests.
3377
3378 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3379
3380         [iOS WK2] Turn on async overflow scrolling by default
3381         https://bugs.webkit.org/show_bug.cgi?id=196011
3382         rdar://problem/48453859
3383
3384         Reviewed by Antti Koivisto.
3385         
3386         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3387         since so many basic layout tests have different results when compositing is triggered for
3388         overflow.
3389         
3390         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3391
3392         * WebKitTestRunner/TestController.cpp:
3393         (WTR::TestController::resetPreferencesToConsistentValues):
3394
3395 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3396
3397         [ews-build] Retry API test in case of failures
3398         https://bugs.webkit.org/show_bug.cgi?id=196004
3399
3400         Reviewed by Lucas Forschler.
3401
3402         * BuildSlaveSupport/ews-build/steps.py:
3403         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3404         (CompileWebKitToT.doStepIf): Ditto.
3405         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3406         (ReRunAPITests): Re-run API tests.
3407         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3408         (RunAPITestsWithoutPatch): Run API tests without patch.
3409         (RunAPITestsWithoutPatch.doStepIf):
3410         (RunAPITestsWithoutPatch.hideStepIf):
3411         (RunAPITestsWithoutPatch.evaluateCommand):
3412         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3413         (AnalyzeAPITestsResults.start):
3414         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3415         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3416         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3417         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3418
3419 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3420
3421         [ews-build] Update queues configurations
3422         https://bugs.webkit.org/show_bug.cgi?id=196074
3423
3424         Reviewed by Dewei Zhu.
3425
3426         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3427         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3428
3429 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3430
3431         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3432         https://bugs.webkit.org/show_bug.cgi?id=195680
3433         <rdar://problem/48903534>
3434
3435         Unreviewed infrastructure fix.
3436
3437         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3438         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3439
3440 2019-03-21  Andy Estes  <aestes@apple.com>
3441
3442         [iOS] Apple Pay should be available in documents with no user agent scripts
3443         https://bugs.webkit.org/show_bug.cgi?id=196061
3444         <rdar://problem/48649391>
3445
3446         Reviewed by Brady Eidson.
3447
3448         Added API tests and related infrastructure.
3449
3450         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3451         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3452         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3453         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3454         (TestWebKitAPI::TEST):
3455         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3456         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3457         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3458         * TestWebKitAPI/cocoa/TestProtocol.mm:
3459         (-[TestProtocol startLoading]):
3460         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3461         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3462         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3463         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3464
3465 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3466
3467         REGRESSSION (r243297): webkitpy tests broken
3468         https://bugs.webkit.org/show_bug.cgi?id=196108
3469
3470         Reviewed by Aakash Jain.
3471
3472         r243297 updated contributors.json, which broke a few unit tests.
3473
3474         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3475         (IRCCommandTest.test_whois):
3476         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3477
3478 2019-03-21  Chris Dumez  <cdumez@apple.com>
3479
3480         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3481         https://bugs.webkit.org/show_bug.cgi?id=196041
3482         <rdar://problem/49083230>
3483
3484         Reviewed by Alex Christensen.
3485
3486         Add API test coverage.
3487
3488         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3489         (TEST):
3490
3491 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3492
3493         Add SPI to inform applications of WKContentRuleList actions
3494         https://bugs.webkit.org/show_bug.cgi?id=195965
3495         <rdar://problem/42664365>
3496
3497         Reviewed by Geoff Garen.
3498
3499         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3500         (TestWebKitAPI::allActionsForResourceLoad):
3501         (TestWebKitAPI::testRequest):
3502         (TestWebKitAPI::TEST_F):
3503         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3504         (Notification::description):
3505         (Notification::operator== const):
3506         (toVector):
3507         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3508         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3509         (makeContentRuleList):
3510         (TEST):
3511         (makeWarnContentRuleList): Deleted.
3512
3513 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3514
3515         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3516         https://bugs.webkit.org/show_bug.cgi?id=196088
3517
3518         Reviewed by Brian Burg.
3519
3520         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3521         Support checks when only one platform is specified. Also deprecate macosx() and
3522         force the use of macos() instead.
3523
3524         * Scripts/webkitpy/style/checkers/cpp.py:
3525         (check_min_versions_of_wk_api_available):
3526         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3527         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3528
3529 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3530
3531         Update status inactive committers' status to 'contributor'.
3532
3533         * Scripts/webkitpy/common/config/contributors.json:
3534
3535 2019-03-21  Xan Lopez  <xan@igalia.com>
3536
3537         [JSC][x86] Drop support for x87 floating point
3538         https://bugs.webkit.org/show_bug.cgi?id=194853
3539
3540         Reviewed by Don Olmstead.
3541
3542         Force SSE2 on x86/32bit builds.
3543
3544         * Scripts/webkitdirs.pm:
3545         (generateBuildSystemFromCMakeProject):
3546
3547 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3548
3549         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3550         https://bugs.webkit.org/show_bug.cgi?id=196073
3551
3552         Reviewed by Michael Catanzaro.
3553
3554         Add test cases to check functions and constructors with no arguments but receiving user data.
3555
3556         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3557         (checkUserData):
3558         (testJSCFunction):
3559         (fooCreateWithUserData):
3560         (testJSCClass):
3561
3562 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3563
3564         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3565
3566         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3567
3568         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3569
3570 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3571
3572         [GTK][WPE] Add API to provide geolocation information
3573         https://bugs.webkit.org/show_bug.cgi?id=195940
3574
3575         Reviewed by Michael Catanzaro.
3576
3577         Add a new test to check the new API.
3578
3579         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3580         (testGeolocationManagerCurrentPosition):
3581         (testGeolocationManagerWatchPosition):
3582         (beforeAll):
3583         (afterAll):
3584         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3585         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3586         (beforeAll): Ditto.
3587         * TestWebKitAPI/glib/CMakeLists.txt:
3588
3589 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3590
3591         [GLib] Returning G_TYPE_OBJECT from a method does not work
3592         https://bugs.webkit.org/show_bug.cgi?id=195574
3593
3594         Reviewed by Michael Catanzaro.
3595
3596         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3597
3598         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3599         (getGFile):
3600         (getParent):
3601         (createGString):
3602         (getGString):
3603         (getGStringCopyWillRaise):
3604         (getGStringCopy):
3605         (getGStringStr):
3606         (getGStringLen):
3607         (freeGString):
3608         (testJSCClass):
3609
3610 2019-03-20  Saam Barati  <sbarati@apple.com>
3611
3612         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3613         https://bugs.webkit.org/show_bug.cgi?id=195721
3614
3615         Reviewed by Filip Pizlo.
3616
3617         * Scripts/run-javascriptcore-tests:
3618
3619 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3620
3621         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3622         https://bugs.webkit.org/show_bug.cgi?id=196049
3623
3624         Reviewed by Tim Horton.
3625
3626         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3627         overflow scrolling in general, so rename it.
3628
3629         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3630
3631 2019-03-20  Daniel Bates  <dabates@apple.com>
3632
3633         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3634         https://bugs.webkit.org/show_bug.cgi?id=196031
3635         <rdar://problem/49078172>
3636
3637         Reviewed by Tim Horton.
3638
3639         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3640         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3641         same code path used when the Done button is pressed to dismiss the <select> picker.
3642
3643         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3644         (TestWebKitAPI::TEST):
3645
3646 2019-03-20  Chris Dumez  <cdumez@apple.com>
3647
3648         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3649         https://bugs.webkit.org/show_bug.cgi?id=196029
3650         <rdar://problem/48954651>
3651
3652         Reviewed by Tim Horton.
3653
3654         Add API test coverage.
3655
3656         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3657
3658 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3659
3660         [ews-build] Improve failure summary string for ApplyPatch step
3661         https://bugs.webkit.org/show_bug.cgi?id=195995
3662
3663         Reviewed by Alexey Proskuryakov.
3664
3665         * BuildSlaveSupport/ews-build/steps.py:
3666         (ApplyPatch.getResultSummary): Override getResultSummary.
3667
3668 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3669
3670         AX: Implement support for new meter ARIA role
3671         https://bugs.webkit.org/show_bug.cgi?id=195966
3672
3673         Reviewed by Chris Fleizach.
3674
3675         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3676         to AXLevelIndicator.
3677
3678         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3679
3680 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3681
3682         [WebAuthN] Implement FIDO AppID extension
3683         https://bugs.webkit.org/show_bug.cgi?id=143491
3684         <rdar://problem/48298273>
3685
3686         Reviewed by Brent Fulgham.
3687
3688         Add a test that covers the new flag of convertToU2fSignCommand.
3689
3690         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3691         (TestWebKitAPI::TEST):
3692         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3693         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3694         (TestWebKitAPI::TEST):
3695
3696 2019-03-19  Keith Rollin  <krollin@apple.com>
3697
3698         Add support for more platforms to generate-xcfilelists
3699         https://bugs.webkit.org/show_bug.cgi?id=195977
3700
3701         Reviewed by Alexey Proskuryakov.
3702
3703         generate-xcfilelists incorrectly complains when involved with building
3704         WebKit for iphonesimulator:
3705
3706             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3707             …
3708             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3709
3710         Address this by teaching generate-xcfilelists about more platforms.
3711
3712         * Scripts/generate-xcfilelists:
3713
3714 2019-03-19  John Wilander  <wilander@apple.com>
3715
3716         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3717         https://bugs.webkit.org/show_bug.cgi?id=195923
3718         <rdar://problem/49001272>
3719
3720         Reviewed by Alex Christensen.
3721
3722         This patch does the following to the TestRunner:
3723         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3724         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3725         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3726
3727         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3728         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3729         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3730         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3731         * WebKitTestRunner/TestController.cpp:
3732         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3733         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3734         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3735         * WebKitTestRunner/TestController.h:
3736         * WebKitTestRunner/TestInvocation.cpp:
3737         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3738
3739 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3740
3741         [CMake] Support more clang and gcc sanitizers
3742         https://bugs.webkit.org/show_bug.cgi?id=195956
3743
3744         Reviewed by Michael Catanzaro.
3745
3746         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3747
3748 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3749
3750         [ews-build] Improve summary for PrintConfiguration step
3751         https://bugs.webkit.org/show_bug.cgi?id=195945
3752
3753         Reviewed by Lucas Forschler.
3754
3755         * BuildSlaveSupport/ews-build/steps.py:
3756         (PrintConfiguration.getResultSummary): Override getResultSummary.
3757
3758 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3759
3760         [ews-build] Improve summary for CheckOutSource step
3761         https://bugs.webkit.org/show_bug.cgi?id=195963
3762
3763         Reviewed by Lucas Forschler.
3764
3765         * BuildSlaveSupport/ews-build/steps.py:
3766         (CheckOutSource.getResultSummary):
3767
3768 2019-03-19  Daniel Bates  <dabates@apple.com>
3769
3770         [iOS] Focus not preserved when switching between tabs
3771         https://bugs.webkit.org/show_bug.cgi?id=195820
3772         <rdar://problem/43614450>
3773
3774         Reviewed by Brent Fulgham.
3775
3776         Add tests to ensure that we restore focus when resigning and becoming first responder.
3777
3778         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3779         (TestWebKitAPI::TEST):
3780
3781 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3782
3783         Make WTFLogChannelState and WTFLogLevel enum classes
3784         https://bugs.webkit.org/show_bug.cgi?id=195904
3785
3786         Reviewed by Eric Carlson.
3787
3788         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3789         (TestWebKitAPI::TEST_F):
3790
3791 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3792
3793         [GStreamer][EME] Backported mssdemux protection data crash fix
3794         https://bugs.webkit.org/show_bug.cgi?id=195918
3795
3796         Reviewed by Philippe Normand.
3797
3798         * gstreamer/jhbuild.modules:
3799         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3800
3801 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3802
3803         Unreviewed, rolling out r243132.
3804
3805         Broke GTK build
3806
3807         Reverted changeset:
3808
3809         "Make WTFLogChannelState and WTFLogLevel enum classes"
3810         https://bugs.webkit.org/show_bug.cgi?id=195904
3811         https://trac.webkit.org/changeset/243132
3812
3813 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3814
3815         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3816
3817         * Scripts/webkitdirs.pm:
3818         (builtDylibPathForName): Adjust the shared library name that's changed
3819         with the API version bump in r243073.
3820
3821 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3822
3823         Make WTFLogChannelState and WTFLogLevel enum classes
3824         https://bugs.webkit.org/show_bug.cgi?id=195904
3825
3826         Reviewed by Eric Carlson.
3827
3828         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3829         (TestWebKitAPI::TEST_F):
3830
3831 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3832
3833         Disable flaky test added in r2431100
3834         https://webkit.org/b/195785
3835
3836         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3837         (TestWebKitAPI::TEST):
3838         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3839
3840 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3841
3842         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3843         https://bugs.webkit.org/show_bug.cgi?id=195916
3844
3845         Reviewed by Tim Horton.
3846
3847         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3848         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3849
3850 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3851
3852         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3853
3854         * Scripts/webkitpy/common/config/contributors.json:
3855
3856 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3857
3858         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3859         https://bugs.webkit.org/show_bug.cgi?id=195785
3860
3861         Reviewed by Geoffrey Garen.
3862
3863         * TestWebKitAPI/TCPServer.cpp: Added.
3864         (TestWebKitAPI::TCPServer::TCPServer):
3865         (TestWebKitAPI::TCPServer::~TCPServer):
3866         (TestWebKitAPI::TCPServer::socketBindListen):
3867         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3868         * TestWebKitAPI/TCPServer.h: Added.
3869         (TestWebKitAPI::TCPServer::port const):
3870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3871         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3872         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3873         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3874         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3875         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3876         (TestWebKitAPI::respondSlowly):
3877         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3878         (TestWebKitAPI::downloadAtRate):
3879         (TestWebKitAPI::TEST):
3880
3881 2019-03-18  Saam Barati  <sbarati@apple.com>
3882
3883         Add a plan file for JetStream 2
3884         https://bugs.webkit.org/show_bug.cgi?id=190734
3885
3886         Reviewed by Mark Lam.
3887
3888         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3889
3890 2019-03-18  Chris Dumez  <cdumez@apple.com>
3891
3892         Delay WebProcess launch until a load is triggered in a Web view
3893         https://bugs.webkit.org/show_bug.cgi?id=195758
3894         <rdar://problem/48126013>
3895
3896         Reviewed by Geoff Garen.
3897
3898         Add API test coverage. Also update some existing API tests to not expect
3899         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3900
3901         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3902         (TestWebKitAPI::TEST):
3903         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3904         (TestWebKitAPI::TEST):
3905         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3906         (TEST):
3907         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3908         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3909         (TEST):
3910         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3911         (TEST):
3912         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3913
3914 2019-03-18  Xan Lopez  <xan@igalia.com>
3915
3916         [CMake] Prevent potential warning when determining $architecture
3917         https://bugs.webkit.org/show_bug.cgi?id=195891
3918
3919         Reviewed by Michael Catanzaro.
3920
3921         It's possible for generateBuildSystemForCMakeProject to be called
3922         before determineArchitecture() is ever called. This will make the
3923         first eq check with $architecture to be bogus (and print a
3924         warning). Change that to an eq check with architecture(), which
3925         implicitly calls determineArchitecture() if needed, and change all
3926         the other similar cases in the method in the same way to prevent
3927         future bugs like this one.
3928
3929         * Scripts/webkitdirs.pm:
3930         (generateBuildSystemFromCMakeProject):
3931
3932 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3933
3934         [WPE] Tarballs generated with “make dist” cannot build documentation
3935         https://bugs.webkit.org/show_bug.cgi?id=195885
3936
3937         Reviewed by Carlos Garcia Campos.
3938
3939         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3940
3941 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3942
3943         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3944         https://bugs.webkit.org/show_bug.cgi?id=195883
3945
3946         Reviewed by Carlos Garcia Campos.
3947
3948         * gtkdoc/gtkdoc.py:
3949         (GTKDoc._run_command): When commands fail to run, include the full command line for
3950         the program invocation and the output it has generated on the standard error stream.
3951
3952 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3953
3954         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3955         https://bugs.webkit.org/show_bug.cgi?id=195786
3956
3957         Reviewed by Philippe Normand.
3958
3959         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3960         * wpe/jhbuild.modules: Ditto.
3961
3962 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3963
3964         [ews-build] Don't run clean builds on EWS builders
3965         https://bugs.webkit.org/show_bug.cgi?id=195851
3966
3967         Reviewed by Geoffrey Garen.
3968
3969         * BuildSlaveSupport/ews-build/factories.py:
3970
3971 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3972
3973         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3974         https://bugs.webkit.org/show_bug.cgi?id=195849
3975
3976         Reviewed by Chris Dumez.
3977
3978         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3979
3980         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3981         (runWebsiteDataStoreCustomPaths):
3982
3983 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3984
3985         webkitpy: Upload test results
3986         https://bugs.webkit.org/show_bug.cgi?id=195755
3987         <rdar://problem/48896182>
3988
3989         Reviewed by Aakash Jain.
3990
3991         Establish a new format for uploading results that is not tied to layout tests, apply
3992         that format to webkitpy tests.
3993
3994         * Scripts/webkitpy/common/checkout/scm/git.py:
3995         (Git.native_branch): Return what branch the current checkout is on.
3996         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3997         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3998         * Scripts/webkitpy/common/checkout/scm/svn.py:
3999         (SVN.native_branch): Ditto.
4000         * Scripts/webkitpy/common/system/platforminfo.py:
4001         (PlatformInfo.build_version): Return a build version for Mac.
4002         * Scripts/webkitpy/common/system/platforminfo_mock.py:
4003         (MockPlatformInfo.__init__):
4004         (MockPlatformInfo.build_version):
4005         * Scripts/webkitpy/results: Added.
4006         * Scripts/webkitpy/results/__init__.py: Added.
4007         * Scripts/webkitpy/results/options.py: Added.
4008         (upload_options): OptParse list for upload options.
4009         * Scripts/webkitpy/results/upload.py: Added.
4010         (Upload): Class which enforces the upload format expected by the results server.
4011         (Upload.Expectations):
4012         (Upload.create_configuration):
4013         (Upload.create_commit):
4014         (Upload.create_details):
4015         (Upload.create_run_stats):
4016         (Upload.create_test_result):
4017         (Upload.__init__):
4018         (Upload.Encoder): Encode Upload object as json.
4019         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
4020         * Scripts/webkitpy/results/upload_unittest.py: Added.
4021         * Scripts/webkitpy/test/main.py:
4022         (Tester._parse_args): Add upload arguments.
4023         (Tester._run_tests): Allow results to be uploaded.
4024         * Scripts/webkitpy/test/runner.py:
4025         (Runner.__init__): Record which tests were run, rather than just counting them.
4026         (Runner.handle):
4027         * Scripts/webkitpy/test/runner_unittest.py:
4028         (RunnerTest.test_run):
4029         * Scripts/webkitpy/thirdparty/__init__.py:
4030         (AutoinstallImportHook.find_module): Add requests auto-install.
4031         (AutoinstallImportHook._install_requests):
4032         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4033         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
4034
4035 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4036
4037         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
4038         https://bugs.webkit.org/show_bug.cgi?id=195810
4039
4040         Reviewed by Tim Horton.
4041
4042         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
4043         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
4044         ending certain layout tests.
4045
4046         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4047         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4048         (-[TestRunnerWKWebView dealloc]):
4049         (-[TestRunnerWKWebView resetInteractionCallbacks]):
4050
4051         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
4052         helper method when destroying the web view, and when resetting state between tests.
4053
4054         * WebKitTestRunner/ios/TestControllerIOS.mm:
4055         (WTR::TestController::platformResetStateToConsistentValues):
4056
4057         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
4058
4059 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
4060
4061         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
4062         https://bugs.webkit.org/show_bug.cgi?id=190350
4063         <rdar://problem/45089503>
4064
4065         Reviewed by Geoffrey Garen.
4066
4067         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4068         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
4069         (TEST):
4070         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
4071         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
4072         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
4073         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
4074         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
4075         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
4076         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
4077         (runTest):
4078         (createDirectories):
4079         (TEST):
4080         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
4081         (TEST):
4082         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
4083         (TEST):
4084
4085 2019-03-15  Timothy Hatcher  <timothy@apple.com>
4086
4087         Add support to WebPage for getting the contents as an attributed string.
4088         https://bugs.webkit.org/show_bug.cgi?id=195636
4089         rdar://problem/45055697
4090
4091         Reviewed by Tim Horton.
4092
4093         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
4094         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
4095
4096 2019-03-15  Chris Dumez  <cdumez@apple.com>
4097
4098         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
4099         https://bugs.webkit.org/show_bug.cgi?id=195747
4100
4101         Reviewed by Geoff Garen.
4102
4103         Add API test coverage.
4104
4105         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4106
4107 2019-03-15  Shawn Roberts  <sroberts@apple.com>
4108
4109         Unreviewed, rolling out r242952.
4110
4111         Causing API failures on iOS Simulator
4112
4113         Reverted changeset:
4114
4115         "[PSON] Make sure the WebProcessCache is leverage when
4116         relaunching a process after termination"
4117         https://bugs.webkit.org/show_bug.cgi?id=195747
4118         https://trac.webkit.org/changeset/242952
4119
4120 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
4121
4122         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
4123         https://bugs.webkit.org/show_bug.cgi?id=195740
4124
4125         Reviewed by Ross Kirsling.
4126
4127         window.open doesn't work for WebKitBrowserWindow because it is not
4128         implemented yet.
4129
4130         1. Implemented createNewPage callback of WKPageUIClient.
4131         2. Changed MainWindow to take a BrowserWindow factory function
4132           instead of BrowserWindowType to be flexible to create
4133           BrowserWindow with extra settings.
4134         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
4135           because it is not relevant with MainWindow anymore.
4136
4137         * MiniBrowser/win/Common.cpp:
4138         (parseCommandLine):
4139         * MiniBrowser/win/Common.h:
4140         (CommandLineOptions::CommandLineOptions):
4141         * MiniBrowser/win/MainWindow.cpp:
4142         (MainWindow::MainWindow):
4143         (MainWindow::create):
4144         (MainWindow::init):
4145         (MainWindow::WndProc):
4146         * MiniBrowser/win/MainWindow.h:
4147         * MiniBrowser/win/PrintWebUIDelegate.cpp:
4148         (PrintWebUIDelegate::createWebViewWithRequest):
4149         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4150         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
4151         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
4152         (WebKitBrowserWindow::updateProxySettings):
4153         (WebKitBrowserWindow::createNewPage):
4154         * MiniBrowser/win/WebKitBrowserWindow.h:
4155         * MiniBrowser/win/WinMain.cpp:
4156         (wWinMain):
4157
4158 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
4159
4160         Make it possible to test scrolling tree layer manipulation more easily
4161         https://bugs.webkit.org/show_bug.cgi?id=195780
4162
4163         Reviewed by Tim Horton.
4164         
4165         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
4166         cuts off communication of scrolling tree scrolls back to the web process
4167         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
4168         allows tests to trigger scrolls which run the scrolling tree layer positioning
4169         logic, but never get another commit from the web process that might mask
4170         scrolling tree bugs.
4171         
4172         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
4173         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
4174         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
4175
4176         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4177         (WTR::UIScriptController::scrollUpdatesDisabled const):
4178         (WTR::UIScriptController::setScrollUpdatesDisabled):
4179         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4180         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4181         (WTR::UIScriptController::scrollUpdatesDisabled const):
4182         (WTR::UIScriptController::setScrollUpdatesDisabled):
4183         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4184         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4185         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4186         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
4187         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
4188         * WebKitTestRunner/ios/TestControllerIOS.mm:
4189         (WTR::TestController::platformResetStateToConsistentValues):
4190         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4191         (WTR::UIScriptController::scrollUpdatesDisabled const):
4192         (WTR::UIScriptController::setScrollUpdatesDisabled):
4193
4194 2019-03-14  Youenn Fablet  <youenn@apple.com>
4195
4196         Move IDB storage in private browsing mode to NetworkProcess
4197         https://bugs.webkit.org/show_bug.cgi?id=195602
4198
4199         Reviewed by Brady Eidson.
4200
4201         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
4202         (TEST):
4203
4204 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4205
4206         [ews-build] Make descriptionDone messages more readable
4207         https://bugs.webkit.org/show_bug.cgi?id=195760
4208
4209         Reviewed by Lucas Forschler.
4210
4211         * BuildSlaveSupport/ews-build/steps.py:
4212         * BuildSlaveSupport/ews-build/steps_unittest.py:
4213
4214 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4215
4216         [ews-build] Generate status-bubble hover-over messages
4217         https://bugs.webkit.org/show_bug.cgi?id=195680
4218
4219         Reviewed by Lucas Forschler.
4220
4221         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4222         (StatusBubble):
4223         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
4224         on hover-over.
4225         (StatusBubble._iso_time):
4226         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
4227         hover-over message.
4228         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
4229
4230 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4231
4232         [ews-app] Gracefully handle the case when state_string is None
4233         https://bugs.webkit.org/show_bug.cgi?id=195753
4234
4235         Reviewed by Lucas Forschler.
4236
4237         * BuildSlaveSupport/ews-app/ews/models/build.py:
4238         * BuildSlaveSupport/ews-app/ews/models/step.py:
4239
4240 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4241
4242         [ews-app] Status bubble display pending for currently running build step
4243         https://bugs.webkit.org/show_bug.cgi?id=195744
4244
4245         Reviewed by Lucas Forschler.
4246
4247         * BuildSlaveSupport/ews-build/events.py:
4248         (Events.stepStarted): If state_string is pending, replace it with step name.
4249
4250 2019-03-14  Chris Dumez  <cdumez@apple.com>
4251
4252         Add WebsitePolicy for the client to specify the device orientation & motion access policy
4253         https://bugs.webkit.org/show_bug.cgi?id=195750
4254
4255         Reviewed by Geoffrey Garen.
4256
4257         Add API test coverage.
4258
4259         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4260         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
4261         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4262         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4263
4264 2019-03-14  Chris Dumez  <cdumez@apple.com>
4265
4266         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
4267         https://bugs.webkit.org/show_bug.cgi?id=195747
4268
4269         Reviewed by Geoff Garen.
4270
4271         Add API test coverage.
4272
4273         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4274
4275 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4276
4277         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
4278         https://bugs.webkit.org/show_bug.cgi?id=195725
4279         <rdar://problem/48545062>
4280
4281         Reviewed by Tim Horton.
4282
4283         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
4284         handler is nil.
4285
4286         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4287         (TestWebKitAPI::TEST):
4288
4289 2019-03-13  Sam Weinig  <sam@webkit.org>
4290
4291         Add utility function to allow easy reverse range-based iteration of a container
4292         https://bugs.webkit.org/show_bug.cgi?id=195542
4293
4294         Reviewed by Antti Koivisto.
4295
4296         * TestWebKitAPI/CMakeLists.txt:
4297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4298         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
4299         (TestWebKitAPI::TEST):
4300         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
4301
4302 2019-03-13  Chris Dumez  <cdumez@apple.com>
4303
4304         Use a ServiceWorker process per registrable domain
4305         https://bugs.webkit.org/show_bug.cgi?id=195649
4306
4307         Reviewed by Youenn Fablet.
4308
4309         Update API test coverage.
4310
4311         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4312
4313 2019-03-13  Chris Dumez  <cdumez@apple.com>
4314
4315         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
4316         https://bugs.webkit.org/show_bug.cgi?id=195684
4317         <rdar://problem/48294714>
4318