[WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2
3         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
4         https://bugs.webkit.org/show_bug.cgi?id=196441
5
6         Reviewed by Carlos Garcia Campos.
7
8         Don't cache the wpe_view_backend object that might not exist yet at the
9         time of EventSenderProxy constructor invocation, but instead retrieve
10         that object whenever it's required for event dispatching. This should
11         avoid crashes in this constructor now that it's invoked before any
12         PlatformWindow has been set up (as changed in r243496).
13
14         * WebKitTestRunner/EventSenderProxy.h:
15         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
16         (WTR::viewBackend):
17         (WTR::EventSenderProxy::EventSenderProxy):
18         (WTR::EventSenderProxy::mouseDown):
19         (WTR::EventSenderProxy::mouseUp):
20         (WTR::EventSenderProxy::mouseMoveTo):
21         (WTR::EventSenderProxy::mouseScrollBy):
22         (WTR::EventSenderProxy::keyDown):
23         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
24
25 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
26
27         [Win][WebKit] MiniBrowser should support high DPI display
28         https://bugs.webkit.org/show_bug.cgi?id=196391
29
30         Reviewed by Alex Christensen.
31
32         * MiniBrowser/win/WebKitBrowserWindow.cpp:
33         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
34         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
35         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
36
37 2019-03-31  Sam Weinig  <weinig@apple.com>
38
39         Remove more i386 specific configurations
40         https://bugs.webkit.org/show_bug.cgi?id=196430
41
42         Reviewed by Alexey Proskuryakov.
43
44         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
45         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
46
47 2019-03-31  Andy Estes  <aestes@apple.com>
48
49         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
50         https://bugs.webkit.org/show_bug.cgi?id=196433
51         <rdar://problem/49293305>
52
53         Reviewed by Tim Horton.
54
55         Enhanced API test coverage to include all navigation response policy decisions in both
56         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
57
58         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
59         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
60         (TestWebKitAPI::TEST):
61         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
62         (readFile):
63         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
64         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
65         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
66         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
67         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
68         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
69         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
70         (-[QuickLookDelegate _downloadDidStart:]):
71         (-[QuickLookDelegate _download:didReceiveResponse:]):
72         (-[QuickLookDelegate _download:didReceiveData:]):
73         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
74         (-[QuickLookDelegate _downloadDidFinish:]):
75         (-[QuickLookDelegate _download:didFailWithError:]):
76         (-[QuickLookDelegate _downloadDidCancel:]):
77         (-[QuickLookDelegate verifyDownload]):
78         (runTest):
79         (runTestDecideBeforeLoading):
80         (runTestDecideAfterLoading):
81         (TEST):
82         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
83         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
84         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
85         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
86         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
87         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
88         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
89         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
90         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
91         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
92         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
93         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
94         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
95         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
96
97 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
98
99         [CMake] add testdfg as target with build-jsc
100         https://bugs.webkit.org/show_bug.cgi?id=196393
101
102         Reviewed by Saam Barati.
103
104         Added testdfg as one of the targets to build when
105         using CMake.
106
107         * Scripts/build-jsc:
108
109 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
110
111         Delete WebMetal implementation in favor of WebGPU
112         https://bugs.webkit.org/show_bug.cgi?id=195418
113
114         Reviewed by Dean Jackson.
115
116         * DumpRenderTree/mac/DumpRenderTree.mm:
117         (enableExperimentalFeatures):
118         (resetWebPreferencesToConsistentValues):
119         * Scripts/webkitperl/FeatureList.pm:
120         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
122         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
123         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
124         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
125         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
126         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
127         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
128         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
129         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
130         (WTR::InjectedBundle::beginTesting):
131         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
132         (WTR::TestRunner::setWebMetalEnabled): Deleted.
133         * WebKitTestRunner/InjectedBundle/TestRunner.h:
134
135 2019-03-29  Chris Dumez  <cdumez@apple.com>
136
137         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
138         https://bugs.webkit.org/show_bug.cgi?id=196405
139         <rdar://problem/49428130>
140
141         Reviewed by Wenson Hsieh.
142
143         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
144         the popover presentation methods to be no-ops. Use this in the new test added in
145         r243523 so that we do not swizzle those methods for all tests. This is needed because
146         those WatchOS tests rely on the popover getting presented and interactive.
147
148         * WebKitTestRunner/TestController.cpp:
149         (WTR::updateTestOptionsFromTestHeader):
150         * WebKitTestRunner/TestController.h:
151         * WebKitTestRunner/TestOptions.h:
152         (WTR::TestOptions::hasSameInitializationOptions const):
153         * WebKitTestRunner/ios/TestControllerIOS.mm:
154         (WTR::TestController::platformInitialize):
155         (WTR::TestController::platformResetStateToConsistentValues):
156
157 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
158
159         [Curl] Add Server Trust Evaluation Support.
160         https://bugs.webkit.org/show_bug.cgi?id=191646
161
162         Reviewed by Fujii Hironori.
163
164         Implemented MiniBrowser UI for asking if user trusts the server.
165
166         * MiniBrowser/win/Common.cpp:
167         (askServerTrustEvaluation):
168         (replaceString):
169         * MiniBrowser/win/Common.h:
170         * MiniBrowser/win/MiniBrowserLib.rc:
171         * MiniBrowser/win/MiniBrowserLibResource.h:
172         * MiniBrowser/win/WebKitBrowserWindow.cpp:
173         (createPEMString):
174         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
175         (WebKitBrowserWindow::canTrustServerCertificate):
176         * MiniBrowser/win/WebKitBrowserWindow.h:
177
178 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
179
180         Implement ResizeObserver.
181         https://bugs.webkit.org/show_bug.cgi?id=157743
182
183         Reviewed by Simon Fraser.
184
185         Support resizeObserverEnabled webPreferences.
186
187         * DumpRenderTree/TestOptions.cpp:
188         (TestOptions::TestOptions):
189         * DumpRenderTree/TestOptions.h:
190         * DumpRenderTree/mac/DumpRenderTree.mm:
191         (setWebPreferencesForTestOptions):
192         * DumpRenderTree/win/DumpRenderTree.cpp:
193         (enableExperimentalFeatures):
194         * Scripts/webkitperl/FeatureList.pm:
195         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
196
197 2019-03-28  John Wilander  <wilander@apple.com>
198
199         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
200         https://bugs.webkit.org/show_bug.cgi?id=196281
201         <rdar://problem/48938748>
202
203         Reviewed by Alex Christensen.
204
205         This patch adds the function isStatisticsHasLocalStorage() to the
206         TestRunner. With it, the page can query the WebsiteDataStore in the
207         UI process to make sure that it sees LocalStorage.
208
209         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
210         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
211         (WTR::TestRunner::isStatisticsHasLocalStorage):
212         * WebKitTestRunner/InjectedBundle/TestRunner.h:
213         * WebKitTestRunner/TestController.cpp:
214         (WTR::TestController::isStatisticsHasLocalStorage):
215         * WebKitTestRunner/TestController.h:
216         * WebKitTestRunner/TestInvocation.cpp:
217         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
218
219 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
220
221         API::Data::createWithoutCopying should do a null check before calling CFRelease
222         https://bugs.webkit.org/show_bug.cgi?id=196276
223         <rdar://problem/48059859>
224
225         Reviewed by Alex Christensen.
226
227         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
228
229         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
230         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
231         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
232         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
233         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
234         (TestWebKitAPI::TEST):
235
236 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
237
238         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
239         https://bugs.webkit.org/show_bug.cgi?id=186276
240
241         Reviewed by Carlos Garcia Campos.
242
243         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
244         (webViewLoadChanged):
245         (testWebResourceGetDataError):
246         (testWebResourceGetDataEmpty):
247         (beforeAll):
248         (webViewloadChanged): Deleted.
249
250 2019-03-27  Andy Estes  <aestes@apple.com>
251
252         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
253         https://bugs.webkit.org/show_bug.cgi?id=196317
254
255         Reviewed by Dan Bernstein.
256
257         package-root copies built products into a staging directory using ditto(1), which does not
258         follow symbolic links as it traverses a directory. Now that the files in
259         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
260         itself, these become broken links when ditto'd into the staging directory.
261
262         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
263
264         * Scripts/package-root:
265
266 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
267
268         [ews-app] Update display text of Submit for ews analysis
269         https://bugs.webkit.org/show_bug.cgi?id=196309
270
271         Reviewed by Dewei Zhu.
272
273         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
274
275 2019-03-27  David Kilzer  <ddkilzer@apple.com>
276
277         run-webkit-tests should check for leaks in WebKit processes
278         <https://webkit.org/b/193772>
279         <rdar://problem/46526680>
280
281         Reviewed by Ryosuke Niwa.
282
283         This works by doing the following:
284         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
285           The list of child processes are returned one per line:
286           process.name: pid
287         - Run the "#LIST CHILD PROCESSES" command just before the
288           "#CHECK FOR WORLD LEAKS" command, and store the list of child
289           processes on the ServerProcess object.
290         - When the `--leaks` switch is handled, run check_for_leaks() on
291           each child process after the main test harness.
292
293         * DumpRenderTree/mac/DumpRenderTree.mm:
294         (handleControlCommand):
295         - Use strncmp() instead of strcmp().
296         - Add support for handling "#LIST CHILD PROCESSES" command.
297
298         * Scripts/webkitpy/port/base.py:
299         (Port.check_for_leaks):
300         * Scripts/webkitpy/port/darwin.py:
301         (DarwinPort.check_for_leaks):
302         - Rename redundant 'process_pid' argument to 'process_id'.
303
304         * Scripts/webkitpy/port/driver.py:
305         (Driver.do_post_tests_work):
306         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
307           longer the only command this sends to WebKitTestRunner.
308         - If the `--leaks` switch is present, send the
309           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
310           result using Port.set_webkit_processes().
311         (Driver._parse_child_processes_output):
312         - Add helper method to parse list of child process names and
313           process IDs returned from WebKitTestRunner.
314
315         * Scripts/webkitpy/port/ios_device.py:
316         (IOSDevicePort.check_for_leaks):
317         - Rename redundant 'process_pid' argument to 'process_id'.
318
319         * Scripts/webkitpy/port/leakdetector.py:
320         (LeakDetector._parse_leaks_output):
321         - Return early if there is no leaks_output.
322         (LeakDetector.check_for_leaks):
323         - Rename redundant 'process_pid' argument to 'process_id'.
324
325         * Scripts/webkitpy/port/server_process.py:
326         (ServerProcess.__init__):
327         (ServerProcess.child_processes):
328         (ServerProcess.set_child_processes):
329         - Add instance variable to Port to store list of child process
330           names and process IDs returned from WebKitTestRunner.
331         (ServerProcess._start):
332         - Clear self._child_processes.
333         (ServerProcess.stop):
334         - If self._child_processes is set, call
335           self._port.check_for_leaks() for each child process.
336
337         * Scripts/webkitpy/port/server_process_unittest.py:
338         (TrivialMockPort.check_for_leaks):
339         - Rename redundant 'process_pid' argument to 'process_id'.
340
341         * Scripts/webkitpy/port/simulator_process.py:
342         (SimulatorProcess.stop):
343         - If self._child_processes is set, call
344           self._port.check_for_leaks() for each child process.
345
346         * Scripts/webkitpy/port/watch_device.py:
347         (WatchDevicePort.check_for_leaks):
348         - Rename redundant 'process_pid' argument to 'process_id'.
349
350         * WebKitTestRunner/TestController.cpp:
351         (WTR::TestController::dumpResponse):
352         - Extract method from findAndDumpWorldLeaks() so that it may be
353           reused by findAndDumpWebKitProcessIdentifiers().
354         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
355         - Add method to output process name and process ID of both the
356           WebContent and Networking processes.
357         (WTR::TestController::findAndDumpWorldLeaks):
358         - Fix missing newline in output when there were no abandoned
359           documents.
360         - Call dumpResponse() for extracted code.
361         (WTR::TestController::handleControlCommand):
362         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
363         - Use strncmp() instead of strcmp().
364         - Call findAndDumpWebKitProcessIdentifiers() when
365           "#LIST CHILD PROCESSES" command is sent.
366         * WebKitTestRunner/TestController.h:
367         (WTR::TestController::dumpResponse):
368         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
369         - Declare methods.
370
371 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
372
373         Unreviewed. Add GLib API test cases after r243434.
374
375         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
376         (testWebViewActiveURI):
377         (serverCallback):
378         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
379         (sendRequestCallback):
380
381 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
382
383         Geolocation request not complete when watch request was started in a different web process
384         https://bugs.webkit.org/show_bug.cgi?id=195996
385
386         Reviewed by Alex Christensen.
387
388         Add a test case.
389
390         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
391         (TestWebKitAPI::runJavaScriptAlert):
392         (TestWebKitAPI::TEST):
393
394 2019-03-26  Keith Rollin  <krollin@apple.com>
395
396         Update the way generate-xcfilelists returns strings from functions
397         https://bugs.webkit.org/show_bug.cgi?id=195975
398         <rdar://problem/49040807>
399
400         Reviewed by Dean Jackson.
401
402         There are places where generate-xcfilelists executes assignments with
403         statements like:
404
405             FOO=$(some_function)
406
407         where "some_function" return a string by echoing it. E.g.
408
409             some_function()
410             {
411                 echo "Hello, World"
412             }
413
414         This is a common idiom, but it has a problem if "some_function" needs
415         to call "exit" in an attempt to halt the entire script right then and
416         there. Since "some_function" is called inside of $(), it's being
417         executed in a sub-shell. Calling exit in that sub-shell simply exits
418         that shell; it doesn't not exit the outer shell in which the main part
419         of the script is still running. As such, the main script keeps
420         executing when the intent was for the script to halt.
421
422         The solution to this is to use a different idiom for returning
423         strings. The one we now is to pass in the name of the variable to
424         receive the string result:
425
426             some_function()
427             {
428                 variable_name=$1
429                 eval $variable_name ="Hello, World"
430             }
431
432         The call site now looks like
433
434             some_function FOO
435
436         Because there's no invocation of a sub-shell, some_function can now
437         call "exit" if it wants to, and the entire script will exit at that
438         point.
439
440         * Scripts/generate-xcfilelists:
441
442 2019-03-26  Chris Dumez  <cdumez@apple.com>
443
444         Add basic layout test coverage for File Picker on iOS
445         https://bugs.webkit.org/show_bug.cgi?id=196265
446
447         Reviewed by Wenson Hsieh.
448
449         Add layout test infrastructure to test the file picker on iOS.
450
451         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
452         (WTR::UIScriptController::dismissFilePicker):
453         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
454         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
455         (WTR::UIScriptController::dismissFilePicker):
456         * TestRunnerShared/UIScriptContext/UIScriptController.h:
457         * WebKitTestRunner/TestController.cpp:
458         (WTR::TestController::createWebViewWithOptions):
459         (WTR::updateTestOptionsFromTestHeader):
460         * WebKitTestRunner/TestOptions.h:
461         (WTR::TestOptions::hasSameInitializationOptions const):
462         * WebKitTestRunner/ios/TestControllerIOS.mm:
463         (overridePresentViewController):
464         (WTR::TestController::platformInitialize):
465         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
466         (WTR::UIScriptController::dismissFilePicker):
467
468 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
469
470         Implement async paste method on UIWKInteractionViewProtocol
471         https://bugs.webkit.org/show_bug.cgi?id=196267
472         <rdar://problem/49236346>
473
474         Reviewed by Tim Horton.
475
476         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
477         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
478         are now a part of all iOS 12 internal SDKs.
479
480         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
481
482         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
483         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
484
485         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
486         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
487         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
488         * TestWebKitAPI/ios/UIKitSPI.h:
489
490 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
491
492         [ews-build] Use PostgreSQL for ews.webkit.org database
493         https://bugs.webkit.org/show_bug.cgi?id=196270
494
495         Reviewed by Lucas Forschler.
496
497         * BuildSlaveSupport/ews-app/ews-app/settings.py:
498
499 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
500
501         [ews] Reset simctl states on reboot
502         https://bugs.webkit.org/show_bug.cgi?id=196260
503
504         Rubber-stamped by Aakash Jain.
505
506         * EWSTools/start-queue-mac.sh:
507
508 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
509
510         [ews-build] Use PostgreSQL for ews-build database
511         https://bugs.webkit.org/show_bug.cgi?id=196229
512
513         Reviewed by Lucas Forschler.
514
515         * BuildSlaveSupport/ews-build/master.cfg:
516
517 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
518
519         [ews-build] Get master_hostname dynamically in master.cfg
520         https://bugs.webkit.org/show_bug.cgi?id=196255
521
522         Reviewed by Lucas Forschler.
523
524         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
525         send events data in test mode.
526
527 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
528
529         [ews-app] Set db_constraint to False for Foreign Keys
530         https://bugs.webkit.org/show_bug.cgi?id=196252
531
532         Reviewed by Lucas Forschler.
533
534         * BuildSlaveSupport/ews-app/ews/models/build.py:
535         * BuildSlaveSupport/ews-app/ews/models/step.py:
536
537 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
538
539         [ews-build] is_test_mode_enabled should default to True
540         https://bugs.webkit.org/show_bug.cgi?id=196248
541
542         Reviewed by Lucas Forschler.
543
544         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
545
546 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
547
548         [ews-app] Add webkitperl to ENABLED_QUEUES
549         https://bugs.webkit.org/show_bug.cgi?id=196253
550
551         Reviewed by Lucas Forschler.
552
553         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
554
555 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
556
557         Address NSWindow sometimes using WebKitTestRunnerEvent too early
558         https://bugs.webkit.org/show_bug.cgi?id=196211
559         rdar://problem/49110552
560
561         Reviewed by Tim Horton.
562
563         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
564         Make sure that EventSenderProxy always exists when running tests. We used to create
565         it when resetting before the first test, which is a bit too late.
566
567         * WebKitTestRunner/TestController.h:
568         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
569         (WTR::TestController::platformCreateWebView):
570         (WTR::TestController::platformCreateOtherPage):
571         (WTR::TestController::finishCreatingPlatformWebView):
572         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
573         (WTR::PlatformWebView::PlatformWebView):
574         Moved some code that made NSWindow use NSEvent during web view creation. We may
575         need to move more if some other case us found, but this is enough for now.
576
577 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
578
579         Unreviewed. Fix typo in GLib geolocation API after r243285.
580
581         gelocation -> geolocation.
582
583         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
584         (testGeolocationManagerWatchPosition):
585
586 2019-03-25  Alex Christensen  <achristensen@webkit.org>
587
588         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
589         https://bugs.webkit.org/show_bug.cgi?id=196213
590
591         Reviewed by Geoff Garen.
592
593         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
594         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
595         (credentialWithIdentityAndKeychainPath):
596         (-[ChallengeDelegate webView:didFinishNavigation:]):
597         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
598         (TestWebKitAPI::TEST):
599
600 2019-03-25  Alex Christensen  <achristensen@webkit.org>
601
602         Expected shouldn't assume its contained types are copyable
603         https://bugs.webkit.org/show_bug.cgi?id=195986
604
605         Reviewed by JF Bastien.
606
607         * TestWebKitAPI/Tests/WTF/Expected.cpp:
608         (TestWebKitAPI::NonCopyable::operator== const):
609         (TestWebKitAPI::NonCopyable::operator!= const):
610         (TestWebKitAPI::TEST):
611
612 2019-03-25  Tim Horton  <timothy_horton@apple.com>
613
614         Remove some now-unnecessary dynamic class lookup
615         https://bugs.webkit.org/show_bug.cgi?id=196237
616
617         Reviewed by Simon Fraser.
618
619         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
620         (makeRequest):
621         (TEST):
622
623 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
624
625         Unreviewed, rolling out r243450.
626
627         AppleWin and WinCairo port builds get broken.
628
629         Reverted changeset:
630
631         "Add test for fix of #196095"
632         https://bugs.webkit.org/show_bug.cgi?id=196097
633         https://trac.webkit.org/changeset/243450
634
635 2019-03-25  Commit Queue  <commit-queue@webkit.org>
636
637         Unreviewed, rolling out r243465.
638         https://bugs.webkit.org/show_bug.cgi?id=196226
639
640         the test doesn't build (Requested by thorton on #webkit).
641
642         Reverted changeset:
643
644         "Do not terminate the NetworkProcess if a third party
645         application sends a NSCredential with a SecIdentityRef"
646         https://bugs.webkit.org/show_bug.cgi?id=196213
647         https://trac.webkit.org/changeset/243465
648
649 2019-03-25  Alex Christensen  <achristensen@webkit.org>
650
651         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
652         https://bugs.webkit.org/show_bug.cgi?id=196213
653
654         Reviewed by Geoff Garen.
655
656         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
657         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
658         (credentialWithIdentityAndKeychainPath):
659         (-[ChallengeDelegate webView:didFinishNavigation:]):
660         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
661         (TestWebKitAPI::TEST):
662
663 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
664
665         [ews-build] Gracefully handle missing patch_id in events
666         https://bugs.webkit.org/show_bug.cgi?id=196216
667
668         Reviewed by Lucas Forschler.
669
670         * BuildSlaveSupport/ews-build/events.py:
671
672 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
673
674         [ews-build] use lz4 compression for improving buildbot performance
675         https://bugs.webkit.org/show_bug.cgi?id=196155
676
677         Reviewed by Lucas Forschler.
678
679         * BuildSlaveSupport/ews-build/master.cfg:
680
681 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
682
683         Pull some API testing helper methods out of TestWKWebView
684         https://bugs.webkit.org/show_bug.cgi?id=196212
685
686         Reviewed by Tim Horton.
687
688         Refactor some more API testing utility methods, so that they can be used in
689         tests that do not use TestWKWebView.
690
691         * TestWebKitAPI/cocoa/TestWKWebView.h:
692         * TestWebKitAPI/cocoa/TestWKWebView.mm:
693         (-[WKWebView loadTestPageNamed:]):
694         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
695         (-[WKWebView synchronouslyLoadHTMLString:]):
696         (-[WKWebView synchronouslyLoadTestPageNamed:]):
697         (-[TestWKWebView loadTestPageNamed:]): Deleted.
698         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
699         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
700         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
701
702 2019-03-25  Jer Noble  <jer.noble@apple.com>
703
704         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
705         https://bugs.webkit.org/show_bug.cgi?id=196097
706
707         Reviewed by Eric Carlson.
708
709         Drive-by bug fix: allow tests to play audio without a user gesture by default.
710
711         * DumpRenderTree/mac/DumpRenderTree.mm:
712         (resetWebPreferencesToConsistentValues):
713         * WebKitTestRunner/TestController.cpp:
714         (WTR::TestController::resetPreferencesToConsistentValues):
715
716 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
717
718         Pull IPadUserInterfaceSwizzler out into a separate header file
719         https://bugs.webkit.org/show_bug.cgi?id=196193
720
721         Reviewed by Anders Carlsson.
722
723         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
724         be used in other API tests.
725
726         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
727         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
728         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
729         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
730         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
731         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
732         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
733
734 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
735
736         Remove NavigatorContentUtils in WebCore/Modules
737         https://bugs.webkit.org/show_bug.cgi?id=196070
738
739         Reviewed by Alex Christensen.
740
741         NavigatorContentUtils was to support the custom scheme spec [1].
742         However, in WebKit side, no port has supported the feature in
743         WebKit layer after EFL port was removed. So there has been the
744         only IDL implementation of the NavigatorContentUtils in WebCore.
745         So we don't need to keep the implementation in WebCore anymore.
746
747         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
748
749         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
750
751 2019-03-24  Andy Estes  <aestes@apple.com>
752
753         [watchOS] Remove unused Proximity Networking code
754         https://bugs.webkit.org/show_bug.cgi?id=196188
755
756         Reviewed by Tim Horton.
757
758         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
759         (TEST):
760
761 2019-03-23  Keith Miller  <keith_miller@apple.com>
762
763         Refactor clz/ctz and fix getLSBSet.
764         https://bugs.webkit.org/show_bug.cgi?id=196162
765
766         Reviewed by Saam Barati.
767
768         Add tests for clz, ctz, getLSBSet, and getMSBSet.
769
770         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
771         (TestWebKitAPI::TEST):
772
773 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
774
775         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
776         https://bugs.webkit.org/show_bug.cgi?id=196143
777
778         Reviewed by Michael Catanzaro.
779
780         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
781         directories.
782
783         * Scripts/webkitpy/style/checkers/cpp.py:
784         (check_identifier_name_in_declaration):
785         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
786         (WebKitStyleTest.test_names):
787
788 2019-03-22  Philippe Normand  <pnormand@igalia.com>
789
790         [Flatpak] Manifest expanding fails for qt WPE extension
791         https://bugs.webkit.org/show_bug.cgi?id=196148
792
793         Reviewed by Alex Christensen.
794
795         * flatpak/flatpakutils.py:
796         (expand_submodules_recurse): The last recurse manifest expand
797         iteration might lead to a single module so take it into account
798         and don't try to recurse further.
799
800 2019-03-22  Chris Dumez  <cdumez@apple.com>
801
802         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
803         https://bugs.webkit.org/show_bug.cgi?id=195348
804         <rdar://problem/48622090>
805
806         Reviewed by Alex Christensen.
807
808         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
809         to NO when test.options().shouldIgnoreMetaViewport is false.
810
811         * WebKitTestRunner/ios/TestControllerIOS.mm:
812         (WTR::TestController::platformConfigureViewForTest):
813
814 2019-03-22  Chris Dumez  <cdumez@apple.com>
815
816         Prewarmed processes should be usable with any website data store
817         https://bugs.webkit.org/show_bug.cgi?id=196104
818
819         Reviewed by Alex Christensen.
820
821         Add API test coverage.
822
823         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
824         (runInitialWarmedProcessUsedTest):
825         (TEST):
826
827 2019-03-22  David Kilzer  <ddkilzer@apple.com>
828
829         Back out local changes to Alex's Subversion working directory
830
831         They were accidentally committed.
832
833         * Scripts/webkitpy/common/system/abstractexecutive.py:
834         (AbstractExecutive.wait_newest):
835         * Scripts/webkitpy/common/system/executive.py:
836         (Executive.running_pids):
837         * Scripts/webkitpy/common/system/executive_mock.py:
838         (MockExecutive.running_pids):
839         * Scripts/webkitpy/common/system/executive_unittest.py:
840         (ExecutiveTest.serial_test_running_pids):
841         * Scripts/webkitpy/port/darwin.py:
842         (DarwinPort.check_for_leaks):
843         * Scripts/webkitpy/port/leakdetector.py:
844         (LeakDetector.check_for_leaks):
845         - This was the hack attached to Bug 193772.
846
847         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
848         (+[WebKitTestRunnerEvent mouseLocation]):
849         - This works around a crash on an internal build.
850
851 2019-03-22  Tim Horton  <timothy_horton@apple.com>
852
853         Fix the build after r243354
854         https://bugs.webkit.org/show_bug.cgi?id=196138
855         <rdar://problem/49145951>
856
857         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
858         (TEST):
859         * TestWebKitAPI/ios/UIKitSPI.h:
860
861 2019-03-21  Tim Horton  <timothy_horton@apple.com>
862
863         Adopt UIWKDocumentContext
864         https://bugs.webkit.org/show_bug.cgi?id=196040
865         <rdar://problem/48642440>
866
867         Reviewed by Ryosuke Niwa.
868
869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
870         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
871         (makeRequest):
872         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
873         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
874         (applyStyle):
875         (TEST):
876         Add tests for UIWKDocumentContext.
877
878         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
879         (TEST):
880         (recursiveFindWKContentView): Deleted.
881         * TestWebKitAPI/cocoa/TestWKWebView.h:
882         * TestWebKitAPI/cocoa/TestWKWebView.mm:
883         (recursiveFindWKContentView):
884         (-[TestWKWebView wkContentView]):
885         * TestWebKitAPI/ios/UIKitSPI.h:
886         Share the WKContentView finding code between tests.
887
888 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
889
890         [iOS WK2] Turn on async overflow scrolling by default
891         https://bugs.webkit.org/show_bug.cgi?id=196011
892         rdar://problem/48453859
893
894         Reviewed by Antti Koivisto.
895         
896         Explicitly turn off the async overflow scrolling internal feature for tests by default,
897         since so many basic layout tests have different results when compositing is triggered for
898         overflow.
899         
900         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
901
902         * WebKitTestRunner/TestController.cpp:
903         (WTR::TestController::resetPreferencesToConsistentValues):
904
905 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
906
907         [ews-build] Retry API test in case of failures
908         https://bugs.webkit.org/show_bug.cgi?id=196004
909
910         Reviewed by Lucas Forschler.
911
912         * BuildSlaveSupport/ews-build/steps.py:
913         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
914         (CompileWebKitToT.doStepIf): Ditto.
915         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
916         (ReRunAPITests): Re-run API tests.
917         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
918         (RunAPITestsWithoutPatch): Run API tests without patch.
919         (RunAPITestsWithoutPatch.doStepIf):
920         (RunAPITestsWithoutPatch.hideStepIf):
921         (RunAPITestsWithoutPatch.evaluateCommand):
922         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
923         (AnalyzeAPITestsResults.start):
924         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
925         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
926         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
927         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
928
929 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
930
931         [ews-build] Update queues configurations
932         https://bugs.webkit.org/show_bug.cgi?id=196074
933
934         Reviewed by Dewei Zhu.
935
936         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
937         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
938
939 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
940
941         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
942         https://bugs.webkit.org/show_bug.cgi?id=195680
943         <rdar://problem/48903534>
944
945         Unreviewed infrastructure fix.
946
947         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
948         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
949
950 2019-03-21  Andy Estes  <aestes@apple.com>
951
952         [iOS] Apple Pay should be available in documents with no user agent scripts
953         https://bugs.webkit.org/show_bug.cgi?id=196061
954         <rdar://problem/48649391>
955
956         Reviewed by Brady Eidson.
957
958         Added API tests and related infrastructure.
959
960         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
961         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
962         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
963         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
964         (TestWebKitAPI::TEST):
965         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
966         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
967         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
968         * TestWebKitAPI/cocoa/TestProtocol.mm:
969         (-[TestProtocol startLoading]):
970         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
971         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
972         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
973         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
974
975 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
976
977         REGRESSSION (r243297): webkitpy tests broken
978         https://bugs.webkit.org/show_bug.cgi?id=196108
979
980         Reviewed by Aakash Jain.
981
982         r243297 updated contributors.json, which broke a few unit tests.
983
984         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
985         (IRCCommandTest.test_whois):
986         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
987
988 2019-03-21  Chris Dumez  <cdumez@apple.com>
989
990         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
991         https://bugs.webkit.org/show_bug.cgi?id=196041
992         <rdar://problem/49083230>
993
994         Reviewed by Alex Christensen.
995
996         Add API test coverage.
997
998         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
999         (TEST):
1000
1001 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1002
1003         Add SPI to inform applications of WKContentRuleList actions
1004         https://bugs.webkit.org/show_bug.cgi?id=195965
1005         <rdar://problem/42664365>
1006
1007         Reviewed by Geoff Garen.
1008
1009         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1010         (TestWebKitAPI::allActionsForResourceLoad):
1011         (TestWebKitAPI::testRequest):
1012         (TestWebKitAPI::TEST_F):
1013         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1014         (Notification::description):
1015         (Notification::operator== const):
1016         (toVector):
1017         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1018         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1019         (makeContentRuleList):
1020         (TEST):
1021         (makeWarnContentRuleList): Deleted.
1022
1023 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1024
1025         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1026         https://bugs.webkit.org/show_bug.cgi?id=196088
1027
1028         Reviewed by Brian Burg.
1029
1030         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1031         Support checks when only one platform is specified. Also deprecate macosx() and
1032         force the use of macos() instead.
1033
1034         * Scripts/webkitpy/style/checkers/cpp.py:
1035         (check_min_versions_of_wk_api_available):
1036         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1037         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1038
1039 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1040
1041         Update status inactive committers' status to 'contributor'.
1042
1043         * Scripts/webkitpy/common/config/contributors.json:
1044
1045 2019-03-21  Xan Lopez  <xan@igalia.com>
1046
1047         [JSC][x86] Drop support for x87 floating point
1048         https://bugs.webkit.org/show_bug.cgi?id=194853
1049
1050         Reviewed by Don Olmstead.
1051
1052         Force SSE2 on x86/32bit builds.
1053
1054         * Scripts/webkitdirs.pm:
1055         (generateBuildSystemFromCMakeProject):
1056
1057 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1058
1059         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1060         https://bugs.webkit.org/show_bug.cgi?id=196073
1061
1062         Reviewed by Michael Catanzaro.
1063
1064         Add test cases to check functions and constructors with no arguments but receiving user data.
1065
1066         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1067         (checkUserData):
1068         (testJSCFunction):
1069         (fooCreateWithUserData):
1070         (testJSCClass):
1071
1072 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1073
1074         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1075
1076         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1077
1078         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1079
1080 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1081
1082         [GTK][WPE] Add API to provide geolocation information
1083         https://bugs.webkit.org/show_bug.cgi?id=195940
1084
1085         Reviewed by Michael Catanzaro.
1086
1087         Add a new test to check the new API.
1088
1089         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1090         (testGeolocationManagerCurrentPosition):
1091         (testGeolocationManagerWatchPosition):
1092         (beforeAll):
1093         (afterAll):
1094         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1095         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1096         (beforeAll): Ditto.
1097         * TestWebKitAPI/glib/CMakeLists.txt:
1098
1099 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1100
1101         [GLib] Returning G_TYPE_OBJECT from a method does not work
1102         https://bugs.webkit.org/show_bug.cgi?id=195574
1103
1104         Reviewed by Michael Catanzaro.
1105
1106         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1107
1108         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1109         (getGFile):
1110         (getParent):
1111         (createGString):
1112         (getGString):
1113         (getGStringCopyWillRaise):
1114         (getGStringCopy):
1115         (getGStringStr):
1116         (getGStringLen):
1117         (freeGString):
1118         (testJSCClass):
1119
1120 2019-03-20  Saam Barati  <sbarati@apple.com>
1121
1122         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1123         https://bugs.webkit.org/show_bug.cgi?id=195721
1124
1125         Reviewed by Filip Pizlo.
1126
1127         * Scripts/run-javascriptcore-tests:
1128
1129 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1130
1131         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1132         https://bugs.webkit.org/show_bug.cgi?id=196049
1133
1134         Reviewed by Tim Horton.
1135
1136         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1137         overflow scrolling in general, so rename it.
1138
1139         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1140
1141 2019-03-20  Daniel Bates  <dabates@apple.com>
1142
1143         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1144         https://bugs.webkit.org/show_bug.cgi?id=196031
1145         <rdar://problem/49078172>
1146
1147         Reviewed by Tim Horton.
1148
1149         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1150         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1151         same code path used when the Done button is pressed to dismiss the <select> picker.
1152
1153         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1154         (TestWebKitAPI::TEST):
1155
1156 2019-03-20  Chris Dumez  <cdumez@apple.com>
1157
1158         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1159         https://bugs.webkit.org/show_bug.cgi?id=196029
1160         <rdar://problem/48954651>
1161
1162         Reviewed by Tim Horton.
1163
1164         Add API test coverage.
1165
1166         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1167
1168 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1169
1170         [ews-build] Improve failure summary string for ApplyPatch step
1171         https://bugs.webkit.org/show_bug.cgi?id=195995
1172
1173         Reviewed by Alexey Proskuryakov.
1174
1175         * BuildSlaveSupport/ews-build/steps.py:
1176         (ApplyPatch.getResultSummary): Override getResultSummary.
1177
1178 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1179
1180         AX: Implement support for new meter ARIA role
1181         https://bugs.webkit.org/show_bug.cgi?id=195966
1182
1183         Reviewed by Chris Fleizach.
1184
1185         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1186         to AXLevelIndicator.
1187
1188         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1189
1190 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1191
1192         [WebAuthN] Implement FIDO AppID extension
1193         https://bugs.webkit.org/show_bug.cgi?id=143491
1194         <rdar://problem/48298273>
1195
1196         Reviewed by Brent Fulgham.
1197
1198         Add a test that covers the new flag of convertToU2fSignCommand.
1199
1200         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1201         (TestWebKitAPI::TEST):
1202         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1203         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1204         (TestWebKitAPI::TEST):
1205
1206 2019-03-19  Keith Rollin  <krollin@apple.com>
1207
1208         Add support for more platforms to generate-xcfilelists
1209         https://bugs.webkit.org/show_bug.cgi?id=195977
1210
1211         Reviewed by Alexey Proskuryakov.
1212
1213         generate-xcfilelists incorrectly complains when involved with building
1214         WebKit for iphonesimulator:
1215
1216             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1217             …
1218             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1219
1220         Address this by teaching generate-xcfilelists about more platforms.
1221
1222         * Scripts/generate-xcfilelists:
1223
1224 2019-03-19  John Wilander  <wilander@apple.com>
1225
1226         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1227         https://bugs.webkit.org/show_bug.cgi?id=195923
1228         <rdar://problem/49001272>
1229
1230         Reviewed by Alex Christensen.
1231
1232         This patch does the following to the TestRunner:
1233         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1234         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1235         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1236
1237         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1238         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1239         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1240         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1241         * WebKitTestRunner/TestController.cpp:
1242         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1243         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1244         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1245         * WebKitTestRunner/TestController.h:
1246         * WebKitTestRunner/TestInvocation.cpp:
1247         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1248
1249 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1250
1251         [CMake] Support more clang and gcc sanitizers
1252         https://bugs.webkit.org/show_bug.cgi?id=195956
1253
1254         Reviewed by Michael Catanzaro.
1255
1256         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1257
1258 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1259
1260         [ews-build] Improve summary for PrintConfiguration step
1261         https://bugs.webkit.org/show_bug.cgi?id=195945
1262
1263         Reviewed by Lucas Forschler.
1264
1265         * BuildSlaveSupport/ews-build/steps.py:
1266         (PrintConfiguration.getResultSummary): Override getResultSummary.
1267
1268 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1269
1270         [ews-build] Improve summary for CheckOutSource step
1271         https://bugs.webkit.org/show_bug.cgi?id=195963
1272
1273         Reviewed by Lucas Forschler.
1274
1275         * BuildSlaveSupport/ews-build/steps.py:
1276         (CheckOutSource.getResultSummary):
1277
1278 2019-03-19  Daniel Bates  <dabates@apple.com>
1279
1280         [iOS] Focus not preserved when switching between tabs
1281         https://bugs.webkit.org/show_bug.cgi?id=195820
1282         <rdar://problem/43614450>
1283
1284         Reviewed by Brent Fulgham.
1285
1286         Add tests to ensure that we restore focus when resigning and becoming first responder.
1287
1288         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1289         (TestWebKitAPI::TEST):
1290
1291 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1292
1293         Make WTFLogChannelState and WTFLogLevel enum classes
1294         https://bugs.webkit.org/show_bug.cgi?id=195904
1295
1296         Reviewed by Eric Carlson.
1297
1298         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1299         (TestWebKitAPI::TEST_F):
1300
1301 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1302
1303         [GStreamer][EME] Backported mssdemux protection data crash fix
1304         https://bugs.webkit.org/show_bug.cgi?id=195918
1305
1306         Reviewed by Philippe Normand.
1307
1308         * gstreamer/jhbuild.modules:
1309         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1310
1311 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1312
1313         Unreviewed, rolling out r243132.
1314
1315         Broke GTK build
1316
1317         Reverted changeset:
1318
1319         "Make WTFLogChannelState and WTFLogLevel enum classes"
1320         https://bugs.webkit.org/show_bug.cgi?id=195904
1321         https://trac.webkit.org/changeset/243132
1322
1323 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1324
1325         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1326
1327         * Scripts/webkitdirs.pm:
1328         (builtDylibPathForName): Adjust the shared library name that's changed
1329         with the API version bump in r243073.
1330
1331 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1332
1333         Make WTFLogChannelState and WTFLogLevel enum classes
1334         https://bugs.webkit.org/show_bug.cgi?id=195904
1335
1336         Reviewed by Eric Carlson.
1337
1338         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1339         (TestWebKitAPI::TEST_F):
1340
1341 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1342
1343         Disable flaky test added in r2431100
1344         https://webkit.org/b/195785
1345
1346         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1347         (TestWebKitAPI::TEST):
1348         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1349
1350 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1351
1352         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1353         https://bugs.webkit.org/show_bug.cgi?id=195916
1354
1355         Reviewed by Tim Horton.
1356
1357         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1358         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1359
1360 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1361
1362         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1363
1364         * Scripts/webkitpy/common/config/contributors.json:
1365
1366 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1367
1368         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1369         https://bugs.webkit.org/show_bug.cgi?id=195785
1370
1371         Reviewed by Geoffrey Garen.
1372
1373         * TestWebKitAPI/TCPServer.cpp: Added.
1374         (TestWebKitAPI::TCPServer::TCPServer):
1375         (TestWebKitAPI::TCPServer::~TCPServer):
1376         (TestWebKitAPI::TCPServer::socketBindListen):
1377         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1378         * TestWebKitAPI/TCPServer.h: Added.
1379         (TestWebKitAPI::TCPServer::port const):
1380         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1381         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1382         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1383         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1384         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1385         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1386         (TestWebKitAPI::respondSlowly):
1387         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1388         (TestWebKitAPI::downloadAtRate):
1389         (TestWebKitAPI::TEST):
1390
1391 2019-03-18  Saam Barati  <sbarati@apple.com>
1392
1393         Add a plan file for JetStream 2
1394         https://bugs.webkit.org/show_bug.cgi?id=190734
1395
1396         Reviewed by Mark Lam.
1397
1398         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1399
1400 2019-03-18  Chris Dumez  <cdumez@apple.com>
1401
1402         Delay WebProcess launch until a load is triggered in a Web view
1403         https://bugs.webkit.org/show_bug.cgi?id=195758
1404         <rdar://problem/48126013>
1405
1406         Reviewed by Geoff Garen.
1407
1408         Add API test coverage. Also update some existing API tests to not expect
1409         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1410
1411         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1412         (TestWebKitAPI::TEST):
1413         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1414         (TestWebKitAPI::TEST):
1415         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1416         (TEST):
1417         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1418         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1419         (TEST):
1420         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1421         (TEST):
1422         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1423
1424 2019-03-18  Xan Lopez  <xan@igalia.com>
1425
1426         [CMake] Prevent potential warning when determining $architecture
1427         https://bugs.webkit.org/show_bug.cgi?id=195891
1428
1429         Reviewed by Michael Catanzaro.
1430
1431         It's possible for generateBuildSystemForCMakeProject to be called
1432         before determineArchitecture() is ever called. This will make the
1433         first eq check with $architecture to be bogus (and print a
1434         warning). Change that to an eq check with architecture(), which
1435         implicitly calls determineArchitecture() if needed, and change all
1436         the other similar cases in the method in the same way to prevent
1437         future bugs like this one.
1438
1439         * Scripts/webkitdirs.pm:
1440         (generateBuildSystemFromCMakeProject):
1441
1442 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1443
1444         [WPE] Tarballs generated with “make dist” cannot build documentation
1445         https://bugs.webkit.org/show_bug.cgi?id=195885
1446
1447         Reviewed by Carlos Garcia Campos.
1448
1449         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1450
1451 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1452
1453         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1454         https://bugs.webkit.org/show_bug.cgi?id=195883
1455
1456         Reviewed by Carlos Garcia Campos.
1457
1458         * gtkdoc/gtkdoc.py:
1459         (GTKDoc._run_command): When commands fail to run, include the full command line for
1460         the program invocation and the output it has generated on the standard error stream.
1461
1462 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1463
1464         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1465         https://bugs.webkit.org/show_bug.cgi?id=195786
1466
1467         Reviewed by Philippe Normand.
1468
1469         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1470         * wpe/jhbuild.modules: Ditto.
1471
1472 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1473
1474         [ews-build] Don't run clean builds on EWS builders
1475         https://bugs.webkit.org/show_bug.cgi?id=195851
1476
1477         Reviewed by Geoffrey Garen.
1478
1479         * BuildSlaveSupport/ews-build/factories.py:
1480
1481 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1482
1483         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1484         https://bugs.webkit.org/show_bug.cgi?id=195849
1485
1486         Reviewed by Chris Dumez.
1487
1488         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1489
1490         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1491         (runWebsiteDataStoreCustomPaths):
1492
1493 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1494
1495         webkitpy: Upload test results
1496         https://bugs.webkit.org/show_bug.cgi?id=195755
1497         <rdar://problem/48896182>
1498
1499         Reviewed by Aakash Jain.
1500
1501         Establish a new format for uploading results that is not tied to layout tests, apply
1502         that format to webkitpy tests.
1503
1504         * Scripts/webkitpy/common/checkout/scm/git.py:
1505         (Git.native_branch): Return what branch the current checkout is on.
1506         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1507         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1508         * Scripts/webkitpy/common/checkout/scm/svn.py:
1509         (SVN.native_branch): Ditto.
1510         * Scripts/webkitpy/common/system/platforminfo.py:
1511         (PlatformInfo.build_version): Return a build version for Mac.
1512         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1513         (MockPlatformInfo.__init__):
1514         (MockPlatformInfo.build_version):
1515         * Scripts/webkitpy/results: Added.
1516         * Scripts/webkitpy/results/__init__.py: Added.
1517         * Scripts/webkitpy/results/options.py: Added.
1518         (upload_options): OptParse list for upload options.
1519         * Scripts/webkitpy/results/upload.py: Added.
1520         (Upload): Class which enforces the upload format expected by the results server.
1521         (Upload.Expectations):
1522         (Upload.create_configuration):
1523         (Upload.create_commit):
1524         (Upload.create_details):
1525         (Upload.create_run_stats):
1526         (Upload.create_test_result):
1527         (Upload.__init__):
1528         (Upload.Encoder): Encode Upload object as json.
1529         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1530         * Scripts/webkitpy/results/upload_unittest.py: Added.
1531         * Scripts/webkitpy/test/main.py:
1532         (Tester._parse_args): Add upload arguments.
1533         (Tester._run_tests): Allow results to be uploaded.
1534         * Scripts/webkitpy/test/runner.py:
1535         (Runner.__init__): Record which tests were run, rather than just counting them.
1536         (Runner.handle):
1537         * Scripts/webkitpy/test/runner_unittest.py:
1538         (RunnerTest.test_run):
1539         * Scripts/webkitpy/thirdparty/__init__.py:
1540         (AutoinstallImportHook.find_module): Add requests auto-install.
1541         (AutoinstallImportHook._install_requests):
1542         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1543         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1544
1545 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1546
1547         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1548         https://bugs.webkit.org/show_bug.cgi?id=195810
1549
1550         Reviewed by Tim Horton.
1551
1552         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1553         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1554         ending certain layout tests.
1555
1556         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1557         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1558         (-[TestRunnerWKWebView dealloc]):
1559         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1560
1561         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1562         helper method when destroying the web view, and when resetting state between tests.
1563
1564         * WebKitTestRunner/ios/TestControllerIOS.mm:
1565         (WTR::TestController::platformResetStateToConsistentValues):
1566
1567         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1568
1569 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1570
1571         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1572         https://bugs.webkit.org/show_bug.cgi?id=190350
1573         <rdar://problem/45089503>
1574
1575         Reviewed by Geoffrey Garen.
1576
1577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1578         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1579         (TEST):
1580         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1581         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1582         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1583         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1584         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1585         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1586         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1587         (runTest):
1588         (createDirectories):
1589         (TEST):
1590         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1591         (TEST):
1592         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1593         (TEST):
1594
1595 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1596
1597         Add support to WebPage for getting the contents as an attributed string.
1598         https://bugs.webkit.org/show_bug.cgi?id=195636
1599         rdar://problem/45055697
1600
1601         Reviewed by Tim Horton.
1602
1603         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1604         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1605
1606 2019-03-15  Chris Dumez  <cdumez@apple.com>
1607
1608         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1609         https://bugs.webkit.org/show_bug.cgi?id=195747
1610
1611         Reviewed by Geoff Garen.
1612
1613         Add API test coverage.
1614
1615         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1616
1617 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1618
1619         Unreviewed, rolling out r242952.
1620
1621         Causing API failures on iOS Simulator
1622
1623         Reverted changeset:
1624
1625         "[PSON] Make sure the WebProcessCache is leverage when
1626         relaunching a process after termination"
1627         https://bugs.webkit.org/show_bug.cgi?id=195747
1628         https://trac.webkit.org/changeset/242952
1629
1630 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1631
1632         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1633         https://bugs.webkit.org/show_bug.cgi?id=195740
1634
1635         Reviewed by Ross Kirsling.
1636
1637         window.open doesn't work for WebKitBrowserWindow because it is not
1638         implemented yet.
1639
1640         1. Implemented createNewPage callback of WKPageUIClient.
1641         2. Changed MainWindow to take a BrowserWindow factory function
1642           instead of BrowserWindowType to be flexible to create
1643           BrowserWindow with extra settings.
1644         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1645           because it is not relevant with MainWindow anymore.
1646
1647         * MiniBrowser/win/Common.cpp:
1648         (parseCommandLine):
1649         * MiniBrowser/win/Common.h:
1650         (CommandLineOptions::CommandLineOptions):
1651         * MiniBrowser/win/MainWindow.cpp:
1652         (MainWindow::MainWindow):
1653         (MainWindow::create):
1654         (MainWindow::init):
1655         (MainWindow::WndProc):
1656         * MiniBrowser/win/MainWindow.h:
1657         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1658         (PrintWebUIDelegate::createWebViewWithRequest):
1659         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1660         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1661         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1662         (WebKitBrowserWindow::updateProxySettings):
1663         (WebKitBrowserWindow::createNewPage):
1664         * MiniBrowser/win/WebKitBrowserWindow.h:
1665         * MiniBrowser/win/WinMain.cpp:
1666         (wWinMain):
1667
1668 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1669
1670         Make it possible to test scrolling tree layer manipulation more easily
1671         https://bugs.webkit.org/show_bug.cgi?id=195780
1672
1673         Reviewed by Tim Horton.
1674         
1675         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1676         cuts off communication of scrolling tree scrolls back to the web process
1677         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1678         allows tests to trigger scrolls which run the scrolling tree layer positioning
1679         logic, but never get another commit from the web process that might mask
1680         scrolling tree bugs.
1681         
1682         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1683         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1684         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1685
1686         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1687         (WTR::UIScriptController::scrollUpdatesDisabled const):
1688         (WTR::UIScriptController::setScrollUpdatesDisabled):
1689         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1690         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1691         (WTR::UIScriptController::scrollUpdatesDisabled const):
1692         (WTR::UIScriptController::setScrollUpdatesDisabled):
1693         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1694         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1695         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1696         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1697         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1698         * WebKitTestRunner/ios/TestControllerIOS.mm:
1699         (WTR::TestController::platformResetStateToConsistentValues):
1700         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1701         (WTR::UIScriptController::scrollUpdatesDisabled const):
1702         (WTR::UIScriptController::setScrollUpdatesDisabled):
1703
1704 2019-03-14  Youenn Fablet  <youenn@apple.com>
1705
1706         Move IDB storage in private browsing mode to NetworkProcess
1707         https://bugs.webkit.org/show_bug.cgi?id=195602
1708
1709         Reviewed by Brady Eidson.
1710
1711         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1712         (TEST):
1713
1714 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1715
1716         [ews-build] Make descriptionDone messages more readable
1717         https://bugs.webkit.org/show_bug.cgi?id=195760
1718
1719         Reviewed by Lucas Forschler.
1720
1721         * BuildSlaveSupport/ews-build/steps.py:
1722         * BuildSlaveSupport/ews-build/steps_unittest.py:
1723
1724 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1725
1726         [ews-build] Generate status-bubble hover-over messages
1727         https://bugs.webkit.org/show_bug.cgi?id=195680
1728
1729         Reviewed by Lucas Forschler.
1730
1731         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1732         (StatusBubble):
1733         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1734         on hover-over.
1735         (StatusBubble._iso_time):
1736         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1737         hover-over message.
1738         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1739
1740 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1741
1742         [ews-app] Gracefully handle the case when state_string is None
1743         https://bugs.webkit.org/show_bug.cgi?id=195753
1744
1745         Reviewed by Lucas Forschler.
1746
1747         * BuildSlaveSupport/ews-app/ews/models/build.py:
1748         * BuildSlaveSupport/ews-app/ews/models/step.py:
1749
1750 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1751
1752         [ews-app] Status bubble display pending for currently running build step
1753         https://bugs.webkit.org/show_bug.cgi?id=195744
1754
1755         Reviewed by Lucas Forschler.
1756
1757         * BuildSlaveSupport/ews-build/events.py:
1758         (Events.stepStarted): If state_string is pending, replace it with step name.
1759
1760 2019-03-14  Chris Dumez  <cdumez@apple.com>
1761
1762         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1763         https://bugs.webkit.org/show_bug.cgi?id=195750
1764
1765         Reviewed by Geoffrey Garen.
1766
1767         Add API test coverage.
1768
1769         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1770         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1771         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1772         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1773
1774 2019-03-14  Chris Dumez  <cdumez@apple.com>
1775
1776         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1777         https://bugs.webkit.org/show_bug.cgi?id=195747
1778
1779         Reviewed by Geoff Garen.
1780
1781         Add API test coverage.
1782
1783         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1784
1785 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1786
1787         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1788         https://bugs.webkit.org/show_bug.cgi?id=195725
1789         <rdar://problem/48545062>
1790
1791         Reviewed by Tim Horton.
1792
1793         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1794         handler is nil.
1795
1796         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1797         (TestWebKitAPI::TEST):
1798
1799 2019-03-13  Sam Weinig  <sam@webkit.org>
1800
1801         Add utility function to allow easy reverse range-based iteration of a container
1802         https://bugs.webkit.org/show_bug.cgi?id=195542
1803
1804         Reviewed by Antti Koivisto.
1805
1806         * TestWebKitAPI/CMakeLists.txt:
1807         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1808         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1809         (TestWebKitAPI::TEST):
1810         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1811
1812 2019-03-13  Chris Dumez  <cdumez@apple.com>
1813
1814         Use a ServiceWorker process per registrable domain
1815         https://bugs.webkit.org/show_bug.cgi?id=195649
1816
1817         Reviewed by Youenn Fablet.
1818
1819         Update API test coverage.
1820
1821         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1822
1823 2019-03-13  Chris Dumez  <cdumez@apple.com>
1824
1825         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1826         https://bugs.webkit.org/show_bug.cgi?id=195684
1827         <rdar://problem/48294714>
1828
1829         Reviewed by Antti Koivisto.
1830
1831         Add API test coverage.
1832
1833         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1834
1835 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1836
1837         [ews-app] Remove unused patch view
1838         https://bugs.webkit.org/show_bug.cgi?id=195669
1839
1840         Reviewed by Lucas Forschler.
1841
1842         * BuildSlaveSupport/ews-app/ews/urls.py:
1843         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1844
1845 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1846
1847         [ews-app] Use Buildbot result code variables
1848         https://bugs.webkit.org/show_bug.cgi?id=195668
1849
1850         Reviewed by Alexey Proskuryakov.
1851
1852         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1853         (Buildbot): Added Buildbot result code variables.
1854         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1855         (StatusBubble._build_bubble): Used Buildbot result code variables.
1856
1857 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
1858
1859         [Flatpak] Expand submodule recursively
1860         https://bugs.webkit.org/show_bug.cgi?id=195672
1861
1862         Building WPE with flatpak was impossible without that as it was raising an exception.
1863         Also update wpebackend-fdo to match what is built in jhbuild
1864
1865         Reviewed by Philippe Normand.
1866
1867         * flatpak/flatpakutils.py:
1868         (expand_submodules_recurse):
1869         (expand_manifest):
1870         * flatpak/org.webkit.WPEModules.yaml:
1871
1872 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1873
1874         [ews-app] status bubble should be hidden for certain builds
1875         https://bugs.webkit.org/show_bug.cgi?id=194597
1876
1877         Reviewed by Dewei Zhu.
1878
1879         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1880         (StatusBubble._build_bubble):
1881         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
1882         because the patch didn't have relevant changes.
1883         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
1884         in production yet.
1885
1886 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
1887
1888         [Win] Fix a slew of simple clang-cl warnings.
1889         https://bugs.webkit.org/show_bug.cgi?id=195652
1890
1891         Reviewed by Don Olmstead.
1892
1893         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1894         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
1895
1896 2019-03-12  Justin Fan  <justin_fan@apple.com>
1897
1898         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
1899         https://bugs.webkit.org/show_bug.cgi?id=195518
1900         <rdar://problem/46322356>
1901
1902         Reviewed by Myles C. Maxfield.
1903
1904         * DumpRenderTree/DerivedSources-input.xcfilelist:
1905         * DumpRenderTree/DerivedSources-output.xcfilelist:
1906
1907 2019-03-12  Commit Queue  <commit-queue@webkit.org>
1908
1909         Unreviewed, rolling out r242825.
1910         https://bugs.webkit.org/show_bug.cgi?id=195648
1911
1912         "Broke webkitpy tests with my change to
1913         lldb_dump_class_layout.py" (Requested by rmorisset on
1914         #webkit).
1915
1916         Reverted changeset:
1917
1918         "Alter Tools/Scripts/dump-class-layout to be able to dump all
1919         classes with suspicious padding"
1920         https://bugs.webkit.org/show_bug.cgi?id=195573
1921         https://trac.webkit.org/changeset/242825
1922
1923 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1924
1925         [ews-build] Show status bubbles while the patch is waiting in queue
1926         https://bugs.webkit.org/show_bug.cgi?id=195618
1927
1928         Reviewed by Lucas Forschler.
1929
1930         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1931         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
1932         enabled in initial deployment.
1933         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
1934         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
1935         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
1936         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
1937         (StatusBubble._build_bubbles_for_patch):
1938
1939 2019-03-12  Robin Morisset  <rmorisset@apple.com>
1940
1941         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
1942         https://bugs.webkit.org/show_bug.cgi?id=195573
1943
1944         Reviewed by Simon Fraser.
1945
1946         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
1947
1948         * Scripts/dump-class-layout:
1949         (main):
1950         * lldb/lldb_dump_class_layout.py:
1951         (ClassLayout.__init__):
1952         (ClassLayout._compute_padding_recursive):
1953         (LLDBDebuggerInstance.dump_layout_for_classname):
1954         (LLDBDebuggerInstance):
1955         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
1956         (LLDBDebuggerInstance.layout_for_classname): Deleted.
1957
1958 2019-03-12  Chris Dumez  <cdumez@apple.com>
1959
1960         Device Orientation access permission should be denied unless explicitly granted by the client
1961         https://bugs.webkit.org/show_bug.cgi?id=195625
1962
1963         Reviewed by Youenn Fablet.
1964
1965         add API test coverage.
1966
1967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1968         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
1969         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
1970         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
1971         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1972         (runDeviceOrientationTest):
1973         (TEST):
1974         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1975         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1976
1977 2019-03-12  Jer Noble  <jer.noble@apple.com>
1978
1979         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
1980         https://bugs.webkit.org/show_bug.cgi?id=195137
1981         <rdar://problem/48810307>
1982
1983         Reviewed by Eric Carlson.
1984
1985         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
1986         (TestWebKitAPI::TEST):
1987
1988 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1989
1990         [ews-build] Change urls from uat to production
1991         https://bugs.webkit.org/show_bug.cgi?id=195566
1992
1993         Reviewed by Lucas Forschler.
1994
1995         * BuildSlaveSupport/ews-app/ews/config.py:
1996         * BuildSlaveSupport/ews-build/events.py:
1997         * BuildSlaveSupport/ews-build/steps.py:
1998
1999 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2000
2001         [ews-build] change max_builds for local-worker to 1
2002         https://bugs.webkit.org/show_bug.cgi?id=195568
2003
2004         Reviewed by Lucas Forschler.
2005
2006         * BuildSlaveSupport/ews-build/loadConfig.py:
2007
2008 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2009
2010         Fix the build
2011
2012         * TestRunnerShared/spi/PencilKitTestSPI.h:
2013         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2014
2015 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2016
2017         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2018         https://bugs.webkit.org/show_bug.cgi?id=194131
2019
2020         Reviewed by Michael Catanzaro.
2021
2022         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2023         (uriChanged):
2024         (testUnfinishedSubresourceLoad):
2025         (serverCallback):
2026         (beforeAll):
2027
2028 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2029
2030         WTF::Expected should use std::addressof instead of operator&
2031         https://bugs.webkit.org/show_bug.cgi?id=195604
2032
2033         Reviewed by Myles Maxfield.
2034
2035         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2036         (TestWebKitAPI::Unique::Unique):
2037         (TestWebKitAPI::Unique::operator&):
2038         (TestWebKitAPI::TEST):
2039
2040 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2041
2042         Add Optional to Forward.h.
2043         https://bugs.webkit.org/show_bug.cgi?id=195586
2044
2045         Reviewed by Darin Adler.
2046
2047         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2048         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2049         Remove unnecessary includes from headers.
2050
2051 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2052
2053         Add testing API to hit-test and scroll overflow scrollers
2054         https://bugs.webkit.org/show_bug.cgi?id=195278
2055
2056         Reviewed by Antti Koivisto.
2057         
2058         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2059         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2060         
2061         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2062
2063         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2064         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2065         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2066         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2067         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2068         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2069         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2070         (WTR::enclosingScrollViewIncludingSelf):
2071         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2072
2073 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2074
2075         API test WebKit.RequestTextInputContext fails on iOS
2076         https://bugs.webkit.org/show_bug.cgi?id=195585
2077
2078         Reviewed by Wenson Hsieh and Simon Fraser.
2079
2080         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2081         (applyStyle):
2082         (TEST):
2083         Add a viewport, so that the coordinates match up on iOS.
2084         Scroll by moving the UIScrollView's contentOffset.
2085
2086 2019-03-11  Chris Dumez  <cdumez@apple.com>
2087
2088         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2089         https://bugs.webkit.org/show_bug.cgi?id=195506
2090         <rdar://problem/48733477>
2091
2092         Reviewed by Alex Christensen.
2093
2094         Add API test coverage.
2095
2096         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2097
2098 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2099
2100         Adding myself to contributors.json
2101
2102         Unreviewed, addming myself to contributors.json .
2103
2104         * Scripts/webkitpy/common/config/contributors.json:
2105
2106 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2107
2108         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2109         https://bugs.webkit.org/show_bug.cgi?id=195511
2110         <rdar://problem/44873269>
2111
2112         Reviewed by Darin Adler.
2113
2114         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2115         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2116         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2117         (TEST_F):
2118
2119 2019-03-11  Chris Dumez  <cdumez@apple.com>
2120
2121         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2122         https://bugs.webkit.org/show_bug.cgi?id=195561
2123
2124         Reviewed by Youenn Fablet.
2125
2126         Make sure the JS in the test requests for permission to receive device orientation events.
2127
2128         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2129
2130 2019-03-11  Youenn Fablet  <youenn@apple.com>
2131
2132         Allow storage quota increase by default in WTR
2133         https://bugs.webkit.org/show_bug.cgi?id=195541
2134
2135         Reviewed by Geoffrey Garen.
2136
2137         Allow storage quota increase by default in WTR.
2138         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2139         Use this for tests that explicitly need cache increase.
2140
2141         Instead of increasing quota by 2, make sure the next request is
2142         granted by adding all given parameters.
2143
2144         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2145         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2146         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2147         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2148         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2149         * WebKitTestRunner/TestController.cpp:
2150         (WTR::TestController::setAllowStorageQuotaIncrease):
2151         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2152         * WebKitTestRunner/TestController.h:
2153         * WebKitTestRunner/TestInvocation.cpp:
2154         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2155         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2156         (WTR::TestController::cocoaResetStateToConsistentValues):
2157         (WTR::TestController::setAllowStorageQuotaIncrease):
2158         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2159         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2160         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2161
2162 2019-03-11  Xan Lopez  <xan@igalia.com>
2163
2164         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2165         https://bugs.webkit.org/show_bug.cgi?id=194147
2166
2167         Reviewed by Michael Saboff.
2168
2169         To make --32-bit work correctly on Linux/64bit we need to:
2170
2171         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2172         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2173         unfortunately CMake only allows us to do this during
2174         crosscompilation, which is overkill here.
2175         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2176         pkg-config detection module uses the x86 .pc files instead of the
2177         x86_64 ones.
2178         - Set the -m32 flags for the compiler.
2179
2180         * Scripts/webkitdirs.pm:
2181         (generateBuildSystemFromCMakeProject):
2182
2183 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2184
2185         Add MotionMark-1.1 plan file for run-benchmark script.
2186         https://bugs.webkit.org/show_bug.cgi?id=195481
2187
2188         Rubber-stamped by Darin Adler.
2189
2190         Run-benchmark script should support MontionMark-1.1.
2191
2192         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2193
2194 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2195
2196         [ews-app] Add support for submit-to-ews url
2197         https://bugs.webkit.org/show_bug.cgi?id=195477
2198
2199         Reviewed by Lucas Forschler.
2200
2201         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2202         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2203         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2204         * BuildSlaveSupport/ews-app/ews/urls.py:
2205         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2206
2207 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2208
2209         Unreviewed, rolling out r242688, r242643, r242624.
2210
2211         Caused multiple layout test failures and crashes on iOS and macOS.
2212
2213         Reverted changeset:
2214
2215         "requestAnimationFrame should execute before the next frame"
2216         https://bugs.webkit.org/show_bug.cgi?id=177484
2217         https://trac.webkit.org/changeset/242624/webkit
2218
2219         * Tracing/SystemTracePoints.plist:
2220
2221 2019-03-11  John Wilander  <wilander@apple.com>
2222
2223         Resource Load Statistics: Make it possible exclude localhost from classification
2224         https://bugs.webkit.org/show_bug.cgi?id=195474
2225         <rdar://problem/47520577>
2226
2227         Reviewed by Brent Fulgham.
2228
2229         This patch allows for localhost to be excluded from classification and
2230         treatment as a prevalent resource.
2231
2232         The WebKit Tools change adds a new function called
2233         testRunner.setStatisticsIsRunningTest() which can be used to control this
2234         behavior.
2235
2236         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2237         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2238         (WTR::TestRunner::setStatisticsIsRunningTest):
2239         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2240         * WebKitTestRunner/TestController.cpp:
2241         (WTR::TestController::setStatisticsIsRunningTest):
2242         * WebKitTestRunner/TestController.h:
2243         * WebKitTestRunner/TestInvocation.cpp:
2244         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2245
2246 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2247
2248         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2249         https://bugs.webkit.org/show_bug.cgi?id=195560
2250
2251         Reviewed by Lucas Forschler.
2252
2253         * BuildSlaveSupport/ews-build/master.cfg:
2254
2255 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2256
2257         Unreviewed, rolling out r242698.
2258
2259         API test crashes on bots.
2260
2261         Reverted changeset:
2262
2263         "Add a WKContentRuleList variant that uses copied memory
2264         instead of mmap'd shared memory for class A containerized
2265         apps"
2266         https://bugs.webkit.org/show_bug.cgi?id=195511
2267         https://trac.webkit.org/changeset/242698
2268
2269 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2270
2271         [WPE] Enable web process sandbox
2272         https://bugs.webkit.org/show_bug.cgi?id=195169
2273
2274         Reviewed by Daniel Bates.
2275
2276         * wpe/install-dependencies:
2277         * wpe/jhbuild.modules:
2278
2279 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2280
2281         [ews-app] Use port 17000 for worker communication
2282         https://bugs.webkit.org/show_bug.cgi?id=195558
2283
2284         Reviewed by Lucas Forschler.
2285
2286         * BuildSlaveSupport/ews-build/master.cfg:
2287
2288 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2289
2290         [ews-build] unit-tests fail when passwords.json is missing
2291         https://bugs.webkit.org/show_bug.cgi?id=195557
2292
2293         Reviewed by Lucas Forschler.
2294
2295         * BuildSlaveSupport/ews-build/loadConfig.py:
2296         (loadBuilderConfig):
2297         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2298         (ConfigDotJSONTest.test_configuration):
2299         * BuildSlaveSupport/ews-build/master.cfg:
2300
2301 2019-03-11  Truitt Savell  <tsavell@apple.com>
2302
2303         Unreviewed, rolling out r242702.
2304
2305         Broke High Sierra builders.
2306
2307         Reverted changeset:
2308
2309         "Add utility function to allow easy reverse range-based
2310         iteration of a container"
2311         https://bugs.webkit.org/show_bug.cgi?id=195542
2312         https://trac.webkit.org/changeset/242702
2313
2314 2019-03-11  Sam Weinig  <sam@webkit.org>
2315
2316         Add utility function to allow easy reverse range-based iteration of a container
2317         https://bugs.webkit.org/show_bug.cgi?id=195542
2318
2319         Reviewed by Antti Koivisto.
2320
2321         * TestWebKitAPI/CMakeLists.txt:
2322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2323         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2324         (TestWebKitAPI::TEST):
2325         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2326
2327 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2328
2329         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2330         https://bugs.webkit.org/show_bug.cgi?id=195511
2331         <rdar://problem/44873269>
2332
2333         Reviewed by Darin Adler.
2334
2335         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2336         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2337         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2338         (TEST_F):
2339
2340 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2341
2342         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2343         https://bugs.webkit.org/show_bug.cgi?id=195499
2344
2345         Reviewed by Darin Adler.
2346
2347         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2348         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2349         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2350         (-[WKWebView synchronouslyFocusTextInputContext:]):
2351         (applyStyle):
2352         (applyIframe):
2353         (TEST):
2354         Add some tests for this SPI.
2355
2356 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2357
2358         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2359         https://bugs.webkit.org/show_bug.cgi?id=181151
2360
2361         Reviewed by Don Olmstead.
2362
2363         * TestWebKitAPI/CMakeLists.txt:
2364         * TestWebKitAPI/PlatformWin.cmake:
2365         Enable TestWTF RunLoop tests in all platforms.
2366
2367         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2368         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2369         (TestWebKitAPI::DerivedOneShotTimer::fired):
2370         (TestWebKitAPI::TEST):
2371         Only a few platforms support nested RunLoop.
2372
2373         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2374         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2375
2376 2019-03-10  David Quesada  <david_quesada@apple.com>
2377
2378         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2379         https://bugs.webkit.org/show_bug.cgi?id=152480
2380
2381         Reviewed by Chris Dumez.
2382
2383         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2384         there are no additional references to the process pool besides the one held by
2385         the download, waits for the download to finish (in the sense that the
2386         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2387         measure, also check that the process pool has been deallocated at the end of the
2388         test. The test wouldn't be meaningful if the process pool were still alive.
2389
2390         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2391         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2392         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2393             The download will be canceled because the delegate does not implement the
2394             method to decide the download's destination, so this is where we know the
2395             DownloadProxyMap is done with the DownloadProxy.
2396         (TEST):
2397
2398 2019-03-08  Chris Dumez  <cdumez@apple.com>
2399
2400         Add support for Device Orientation / Motion permission API
2401         https://bugs.webkit.org/show_bug.cgi?id=195329
2402         <rdar://problem/47645367>
2403
2404         Reviewed by Geoffrey Garen.
2405
2406         Add test infrastructure to help test the Device Orientation / Motion permission API.
2407
2408         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2409         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2410         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2411         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2412         * WebKitTestRunner/TestController.cpp:
2413         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2414         (WTR::TestController::createWebViewWithOptions):
2415         (WTR::TestController::resetStateToConsistentValues):
2416         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2417         * WebKitTestRunner/TestController.h:
2418         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2419         * WebKitTestRunner/TestInvocation.cpp:
2420         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2421
2422 2019-03-08  Saam barati  <sbarati@apple.com>
2423
2424         Add a compare-results script to compare benchmark results
2425         https://bugs.webkit.org/show_bug.cgi?id=195486
2426         <rdar://problem/48723397>
2427
2428         Reviewed by Geoffrey Garen.
2429
2430         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2431         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2432         to extend it to learn about our other benchmarks.
2433
2434         * Scripts/compare-results: Added.
2435         (readJSONFile):
2436         (detectJetStream2):
2437         (JetStream2Results):
2438         (detectSpeedometer2):
2439         (Speedometer2Results):
2440         (detectPLT5):
2441         (PLT5Results):
2442         (detectBenchmark):
2443         (biggerIsBetter):
2444         (ttest):
2445         (getOptions):
2446         (main):
2447
2448 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2449
2450         Ensure old tab state is cleared between iterations of run-benchmark
2451         https://bugs.webkit.org/show_bug.cgi?id=195393
2452         <rdar://problem/46885583>
2453
2454         Reviewed by Dewei Zhu.
2455
2456         a) ensure the default to restore state is not set
2457         b) terminate Safari correctly
2458         c) Set the system default to ignore Persistent State in Safari
2459
2460         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2461         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2462         (OSXBrowserDriver.prepare_env): 
2463         (OSXBrowserDriver.restore_env):
2464         (OSXBrowserDriver.close_browsers):
2465         (OSXBrowserDriver._terminate_processes):
2466         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2467         (OSXChromeDriver):
2468         (OSXChromeCanaryDriver):
2469         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2470         (OSXFirefoxDriver):
2471         (OSXFirefoxNightlyDriver):
2472         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2473         (OSXSafariDriver):
2474         (OSXSafariDriver.prepare_env):
2475
2476 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2477
2478         [GTK] Several InputMethodFilter tests are failing
2479         https://bugs.webkit.org/show_bug.cgi?id=195408
2480
2481         Reviewed by Carlos Garcia Campos.
2482
2483         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2484         Regressed in r241751.
2485         Hexadecimal values of keycodes are expressed now in upper letters.
2486         Composited characters should be cast to UTF8 strings.
2487
2488         (TestWebKitAPI::TEST):
2489
2490 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2491
2492         [GTK] Make Tools/gtkdoc python3 compatible
2493         https://bugs.webkit.org/show_bug.cgi?id=195359
2494
2495         Reviewed by Carlos Garcia Campos.
2496
2497         * gtkdoc/generate-gtkdoc:
2498         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2499         work with Python 2 and 3.
2500         (get_gtkdoc_module_paths):
2501         The iteritems() was removed in Python 3, so let's use items() that's
2502         available in Python 2 and 3.
2503         (get_generator_for_config):
2504         * gtkdoc/gtkdoc.py:
2505         (GTKDoc._run_command):
2506         The sys.stdout.write() is expecting str in Python 3 and not bytes
2507         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2508         for passing the bytes there.
2509
2510 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2511
2512         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2513         https://bugs.webkit.org/show_bug.cgi?id=195346
2514         <rdar://problem/48667048>
2515
2516         Unreviewed build fix for clang-cl.
2517
2518         * DumpRenderTree/win/DumpRenderTree.cpp:
2519         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2520
2521 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2522
2523         requestAnimationFrame should execute before the next frame
2524         https://bugs.webkit.org/show_bug.cgi?id=177484
2525
2526         Reviewed by Simon Fraser.
2527
2528         Add trace points for the page RenderingUpdate.
2529
2530         * Tracing/SystemTracePoints.plist:
2531
2532 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2533
2534         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2535         https://bugs.webkit.org/show_bug.cgi?id=195353
2536         <rdar://problem/48626394>
2537
2538         Reviewed by Simon Fraser.
2539
2540         * WebKitTestRunner/ios/TestControllerIOS.mm:
2541         (WTR::TestController::platformResetPreferencesToConsistentValues):
2542
2543 2019-03-07  John Wilander  <wilander@apple.com>
2544
2545         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2546         https://bugs.webkit.org/show_bug.cgi?id=195383
2547         <rdar://problem/48570136>
2548
2549         Reviewed by Brent Fulgham.
2550
2551         This patch adds test infrastructure to purge only script-accessible cookies,
2552         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2553
2554         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2555         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2556         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2557         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2558         * WebKitTestRunner/TestController.cpp:
2559         (WTR::TestController::statisticsDeleteCookiesForHost):
2560         * WebKitTestRunner/TestController.h:
2561         * WebKitTestRunner/TestInvocation.cpp:
2562         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2563
2564 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2565
2566         Unreviewed, rolling out r242354.
2567         https://bugs.webkit.org/show_bug.cgi?id=195402
2568
2569         breaks layout tests in all configurations (Requested by
2570         zdobersek on #webkit).
2571
2572         Reverted changeset:
2573
2574         "[WPE] Enable web process sandbox"
2575         https://bugs.webkit.org/show_bug.cgi?id=195169
2576         https://trac.webkit.org/changeset/242354
2577
2578 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2579
2580         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2581         https://bugs.webkit.org/show_bug.cgi?id=195346
2582
2583         Reviewed by Fujii Hironori.
2584
2585         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2586         (TestWebKitAPI::TEST):
2587         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2588
2589         * DumpRenderTree/win/DumpRenderTree.cpp:
2590         (findFontFallback):
2591         (addFontFallbackIfPresent):
2592         (removeFontFallbackIfPresent):
2593         (main):
2594         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2595         (TestWebKitAPI::Util::moduleDirectory):
2596         (TestWebKitAPI::Util::createInjectedBundlePath):
2597         Use wchar helpers as needed.
2598
2599 2019-03-06  Rob Buis  <rbuis@igalia.com>
2600
2601         Consider supporting the `referrerpolicy` attribute.
2602         https://bugs.webkit.org/show_bug.cgi?id=179053
2603
2604         Reviewed by Darin Adler.
2605
2606         Add a runtime flag for referrerpolicy attribute.
2607
2608         * DumpRenderTree/mac/DumpRenderTree.mm:
2609         (enableExperimentalFeatures):
2610
2611 2019-03-05  Daniel Bates  <dabates@apple.com>
2612
2613         Update expected API test result following r242379
2614         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2615
2616         Update expected x-coordinate of selection rect now that the left padding of
2617         a textarea is sized in ems (so dependent on the font size) just like the left
2618         padding of a text field.
2619
2620         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2621         (TestWebKitAPI::TEST):
2622
2623 2019-03-05  David Quesada  <david_quesada@apple.com>
2624
2625         [WK2] It should be possible to follow links with 'download' attributes
2626         https://bugs.webkit.org/show_bug.cgi?id=195145
2627         rdar://problem/48462642
2628
2629         Reviewed by Alex Christensen.
2630
2631         Add a unit test to verify that activating links with 'download' attributes now
2632         navigates to the linked resource, rather than starts downloading it. Add another
2633         to verify that it is still possible to explicitly download the link via the
2634         'Download' navigation action policy.
2635
2636         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2637         (-[DownloadAttributeTestDelegate init]):
2638         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2639         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2640         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2641         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2642         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2643         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2644         (TEST):
2645         * WebKitTestRunner/TestController.cpp:
2646         (WTR::TestController::decidePolicyForNavigationAction):
2647         * WebKitTestRunner/TestController.h:
2648
2649 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2650
2651         [Curl] Implement Cookie Accept Policy.
2652         https://bugs.webkit.org/show_bug.cgi?id=191645
2653
2654         Reviewed by Fujii Hironori.
2655
2656         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2657         (TestWebKitAPI::Curl::TEST_F):
2658
2659 2019-03-05  Youenn Fablet  <youenn@apple.com>
2660
2661         Rename requestCacheStorageSpace to requestStorageSpace
2662         https://bugs.webkit.org/show_bug.cgi?id=195282
2663
2664         Reviewed by Chris Dumez.
2665
2666         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2667         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2668         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2669
2670 2019-03-05  Brady Eidson  <beidson@apple.com>
2671
2672         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2673         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2674
2675         Reviewed by Tim Horton.
2676
2677         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2678         different directory into that same WKWebView should work.
2679
2680         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2681         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2682
2683 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2684
2685         Add WeakHashSet
2686         https://bugs.webkit.org/show_bug.cgi?id=195152
2687
2688         Reviewed by Antti Koivisto.
2689
2690         Added tests for WeakHashSet.
2691
2692         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2693         (TestWebKitAPI::Base::Base): Moved.
2694         (TestWebKitAPI::Derived::foo): Moved.
2695         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2696         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2697         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2698         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2699
2700 2019-03-04  Chris Dumez  <cdumez@apple.com>
2701
2702         Do not share WebProcesses between private and regular sessions
2703         https://bugs.webkit.org/show_bug.cgi?id=195189
2704         <rdar://problem/48421064>
2705
2706         Reviewed by Alex Christensen.
2707
2708         Add API test coverage.
2709
2710         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2711         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2712
2713 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2714
2715         [WPE] Enable web process sandbox
2716         https://bugs.webkit.org/show_bug.cgi?id=195169
2717
2718         Reviewed by Daniel Bates.
2719
2720         * wpe/install-dependencies:
2721         * wpe/jhbuild.modules:
2722
2723 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2724
2725         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2726         https://bugs.webkit.org/show_bug.cgi?id=195206
2727
2728         Reviewed by Žan Doberšek.
2729
2730         Add a new test case.
2731
2732         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2733         (testJSCClass):
2734
2735 2019-03-04  Charlie Turner  <cturner@igalia.com>
2736
2737         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2738         https://bugs.webkit.org/show_bug.cgi?id=194898
2739
2740         Reviewed by Žan Doberšek.
2741
2742         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2743         a GCC extension that permits arithmetic on void* pointer. Inline
2744         the macro until this issue is fixed upstream.
2745
2746 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2747
2748         Rid the world of WK_API_ENABLED
2749         https://bugs.webkit.org/show_bug.cgi?id=195263
2750
2751         Reviewed by Dan Bernstein.
2752
2753         List of changed files elided because it's useless.
2754
2755 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2756
2757         Unreviewed follow-up to r242292.
2758
2759         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2760
2761         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2762         (TestWebKitAPI::testStrip): Renamed from strip.
2763         (TestWebKitAPI::TEST):
2764
2765 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2766
2767         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2768
2769         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2770         and bug #194272 for details.
2771
2772         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2773
2774 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2775
2776         Remove some more unused 32-bit code
2777         https://bugs.webkit.org/show_bug.cgi?id=195255
2778
2779         Reviewed by Darin Adler.
2780
2781         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2782         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2783         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2784         (NPP_New):
2785         (NPP_HandleEvent):
2786         (handleEventCarbon): Deleted.
2787
2788 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2789
2790         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2791
2792         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2793         (TestWebKitAPI::TEST):
2794
2795 2019-03-01  Darin Adler  <darin@apple.com>
2796
2797         Finish removing String::format
2798         https://bugs.webkit.org/show_bug.cgi?id=194893
2799
2800         Reviewed by Daniel Bates.
2801 '
2802         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2803
2804 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2805
2806         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2807         https://bugs.webkit.org/show_bug.cgi?id=195229
2808         <rdar://problem/48520362>
2809
2810         Reviewed by Chris Dumez.
2811
2812         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2813         (TEST):
2814
2815 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2816
2817         Add a system trace scope for event region building
2818         https://bugs.webkit.org/show_bug.cgi?id=195226
2819
2820         Reviewed by Jon Lee.
2821
2822         This trace scope measures the time spend converting element rects into Region objects,
2823         which can be large on some pages.
2824
2825         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2826
2827         * Tracing/SystemTracePoints.plist:
2828
2829 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2830
2831         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2832         https://bugs.webkit.org/show_bug.cgi?id=194612
2833
2834         Reviewed by Alex Christensen.
2835
2836         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2837         Just test the new string-processing function and don't touch the actual environment.
2838         (Test cases are all as before, but based on operator== instead of strcmp.)
2839
2840 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2841
2842         [ews-app] Update primary keys for handling multiple Buildbot instances
2843         https://bugs.webkit.org/show_bug.cgi?id=195120
2844
2845         Reviewed by Stephanie Lewis.
2846
2847         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2848         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
2849         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
2850
2851         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
2852         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
2853         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
2854         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
2855         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
2856         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
2857
2858 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
2859
2860         [WinCairo] Enable service worker
2861         https://bugs.webkit.org/show_bug.cgi?id=188318
2862
2863         Reviewed by Youenn Fablet.
2864
2865         * DumpRenderTree/DumpRenderTreePrefix.h:
2866         * TestWebKitAPI/PlatformWin.cmake:
2867         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
2868         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
2869         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2870
2871 2019-03-01  Justin Fan  <justin_fan@apple.com>
2872
2873         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
2874         https://bugs.webkit.org/show_bug.cgi?id=195191
2875
2876         Rubber-stamped by Dean Jackson.
2877
2878         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
2879
2880         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2881
2882 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
2883
2884         Unreviewed, fix lldb webkitpy tests
2885         https://bugs.webkit.org/show_bug.cgi?id=194375
2886
2887         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
2888
2889         * lldb/lldb_webkit.py:
2890         (WTFStringImplProvider.is_8bit):
2891
2892 2019-02-28  David Quesada  <david_quesada@apple.com>
2893
2894         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
2895         https://bugs.webkit.org/show_bug.cgi?id=195121
2896         rdar://problem/48450302
2897
2898         Reviewed by Alex Christensen.
2899
2900         Add API tests for -WKNavigationAction._shouldPerformDownload in various
2901         configurations where the 'download' attribute is absent, blank, or populated
2902         with a filename, and where the anchor element is same-origin or cross-origin
2903         (meaning the 'download' attribute shouldn't be honored).
2904
2905         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2906         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
2907         (-[NavigationActionTestDelegate init]):
2908         (-[NavigationActionTestDelegate navigationAction]):
2909         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
2910         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
2911         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2912         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
2913         (TEST):
2914
2915 2019-02-28  Antoine Quint  <graouts@apple.com>
2916
2917         Enable the Pointer Events runtime flag by default
2918         https://bugs.webkit.org/show_bug.cgi?id=195156
2919
2920         Reviewed by Dean Jackson.
2921
2922         * DumpRenderTree/mac/DumpRenderTree.mm:
2923         (enableExperimentalFeatures):
2924
2925 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2926
2927         Several PasteImage API tests are flaky
2928         https://bugs.webkit.org/show_bug.cgi?id=195160
2929
2930         Reviewed by Tim Horton.
2931
2932         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
2933         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
2934         listening for a "load" event after image load is already complete.
2935
2936         To address this, make these tests first register a "load" event handler, then run script to insert an image
2937         element into the document, and finally wait until the load event is observed before checking image size.
2938
2939         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2940
2941 2019-02-28  Chris Dumez  <cdumez@apple.com>
2942
2943         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
2944         https://bugs.webkit.org/show_bug.cgi?id=195107
2945
2946         Reviewed by Alex Christensen.
2947
2948         Give some time for the zoom level to get restored.
2949
2950         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2951
2952 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
2953
2954         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
2955         https://bugs.webkit.org/show_bug.cgi?id=194958
2956
2957         Reviewed by Geoffrey Garen.
2958
2959         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
2960         (TEST):
2961
2962 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
2963
2964         [ews-app] Update method to save build to handle builder_display_name
2965         https://bugs.webkit.org/show_bug.cgi?id=195047
2966
2967         Reviewed by Dewei Zhu.
2968
2969         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
2970         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
2971
2972 2019-02-28  Justin Fan  <justin_fan@apple.com>
2973
2974         [Web GPU] Enable Web GPU only on 64-bit
2975         https://bugs.webkit.org/show_bug.cgi?id=195139
2976
2977         Because Metal is only supported on 64 bit apps.
2978
2979         Unreviewed build fix.
2980
2981         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2982
2983 2019-02-27  Youenn Fablet  <youenn@apple.com>
2984
2985         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
2986         https://bugs.webkit.org/show_bug.cgi?id=194959
2987
2988         Reviewed by Chris Dumez.
2989
2990         Spin loop until getting the condition to remove flakiness.
2991
2992         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2993
2994 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
2995
2996         [ews-build] Buildbot should include builder_display_name in the build events
2997         https://bugs.webkit.org/show_bug.cgi?id=195045
2998
2999         Reviewed by Dewei Zhu.
3000
3001         * BuildSlaveSupport/ews-build/events.py:
3002         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3003         buildername to builder_name to be consistent in naming style.
3004         (Events.buildFinished): Ditto.
3005
3006 2019-02-27  Chris Dumez  <cdumez@apple.com>
3007
3008         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3009         https://bugs.webkit.org/show_bug.cgi?id=194480
3010
3011         Reviewed by Brady Eidson.
3012
3013         Update existing API test to make it more likely to reproduce the issue.
3014
3015         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3016
3017 2019-02-27  Brady Eidson  <beidson@apple.com>
3018
3019         Universal links from Google search results pages don't open the app.
3020         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3021
3022         Reviewed by Geoffrey Garen.
3023
3024         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3025         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3026         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3027         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3028
3029 2019-02-27  Chris Dumez  <cdumez@apple.com>
3030
3031         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3032         https://bugs.webkit.org/show_bug.cgi?id=195102
3033
3034         Reviewed by Geoffrey Garen.
3035
3036         If the number of processes is not yet what we expect, wait a bit and check again to give
3037         processes some time to exit.
3038
3039         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3040
3041 2019-02-27  Chris Dumez  <cdumez@apple.com>
3042
3043         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3044         https://bugs.webkit.org/show_bug.cgi?id=194545
3045
3046         Reviewed by Brady Eidson.
3047
3048         Make sure the test navigates forward and then back only once. Previously, navigating
3049         back would trigger a navigation again in a timer.
3050
3051         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3052
3053 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3054
3055         High Sierra Debug JSC test queue should use faster hardware
3056         https://bugs.webkit.org/show_bug.cgi?id=194603
3057
3058         Rubber-stamped by Alexey Proskuryakov.
3059
3060         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3061
3062         * BuildSlaveSupport/build.webkit.org-config/config.json:
3063         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3064         (BubbleQueueServer):
3065         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3066         (WebKitBuildbot):
3067         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3068         * QueueStatusServer/config/queues.py:
3069         * Scripts/webkitpy/common/config/ews.json:
3070         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3071         (test_ews_name):
3072
3073 2019-02-27  John Wilander  <wilander@apple.com>
3074
3075         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3076         https://bugs.webkit.org/show_bug.cgi?id=195071
3077         <rdar://problem/48417690>
3078
3079         Reviewed by Alex Christensen and Brent Fulgham.
3080
3081         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3082         (TestWebKitAPI::createURL):
3083             Convenience function.
3084         (TestWebKitAPI::TEST):
3085             WebCore::AdClickAttribution now takes a URL when creating Source and
3086             Destination.
3087         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3088         (TestWebKitAPI::TEST):
3089             WebCore::AdClickAttribution now takes a URL when creating Source and
3090             Destination.
3091
3092 2019-02-27  Antoine Quint  <graouts@apple.com>
3093
3094         Support Pointer Events on macOS
3095         https://bugs.webkit.org/show_bug.cgi?id=195008
3096         <rdar://problem/47454419>
3097
3098         Reviewed by Dean Jackson.
3099
3100         * DumpRenderTree/mac/DumpRenderTree.mm:
3101         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3102         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3103
3104 2019-02-26  Mark Lam  <mark.lam@apple.com>
3105
3106         Remove remaining poisoning code.
3107         https://bugs.webkit.org/show_bug.cgi?id=194138
3108
3109         Reviewed by Saam Barati.
3110
3111         * TestWebKitAPI/CMakeLists.txt:
3112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3113         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3114         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3115         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3116         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3117         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3118         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3119
3120 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3121
3122         Move ephemeral local storage from WebProcess to UIProcess
3123         https://bugs.webkit.org/show_bug.cgi?id=195074
3124         <rdar://problem/47937975>
3125
3126         Reviewed by Geoff Garen.
3127
3128         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3129
3130 2019-02-20  Jer Noble  <jer.noble@apple.com>
3131
3132         [Cocoa] Media elements will restart network buffering just before suspending
3133         https://bugs.webkit.org/show_bug.cgi?id=193691
3134
3135         Reviewed by Eric Carlson.
3136
3137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3138         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3139         (TEST):
3140
3141 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3142
3143         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3144         https://bugs.webkit.org/show_bug.cgi?id=191652
3145
3146         Reviewed by Alex Christensen.
3147
3148         Fix WinCairo MiniBrowser behavior of authentication dialog.
3149
3150         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3151         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3152
3153 2019-02-26  Youenn Fablet  <youenn@apple.com>
3154
3155         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3156         https://bugs.webkit.org/show_bug.cgi?id=195028
3157         <rdar://problem/48243733>
3158
3159         Reviewed by Eric Carlson.
3160
3161         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3162
3163 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3164
3165         [WPE] Add API for webview background color configuration
3166         https://bugs.webkit.org/show_bug.cgi?id=192305
3167
3168         Reviewed by Michael Catanzaro.
3169
3170         * MiniBrowser/wpe/main.cpp:
3171         (main): Add a new option to configure the webview background
3172         color. Example: --bg-color=transparent.
3173         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3174         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3175         (beforeAll): Ditto.
3176
3177 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3178
3179         scalableNativeWebpageParameters() is not preserved on new page navigation.
3180         https://bugs.webkit.org/show_bug.cgi?id=194892
3181         <rdar://problem/47538280>
3182
3183         Reviewed by Wenson Hsieh.
3184         
3185         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3186
3187         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3188         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3189         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3190         (WTR::UIScriptController::allowsViewportShrinkToFit):
3191         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3192         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3193         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3194         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3195         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3196         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3197
3198 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3199
3200         [ews-app] Add model for handling multiple Buildbot instances
3201         https://bugs.webkit.org/show_bug.cgi?id=194863
3202
3203         Reviewed by Stephanie Lewis.
3204
3205         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3206
3207 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3208
3209         [ews-app] Remove BuilderMapping table
3210         https://bugs.webkit.org/show_bug.cgi?id=194961
3211
3212         Reviewed by Stephanie Lewis.
3213
3214         Store builder name directly in build table, instead of having a separate
3215         table for it.
3216
3217         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3218         * BuildSlaveSupport/ews-app/ews/models/build.py:
3219         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3220         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3221
3222 2019-02-25  John Wilander  <wilander@apple.com>
3223
3224         Introduce and adopt new class RegistrableDomain for eTLD+1
3225         https://bugs.webkit.org/show_bug.cgi?id=194791
3226         <rdar://problem/48179240>
3227
3228         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3229
3230         This patch adds an API test and replaces two instances of
3231         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3232
3233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3234         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3235         (TestWebKitAPI::TEST):
3236             Changed two strings to make sure the registrable domains are still considered
3237             invalid and pass the test.
3238         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3239         (TestWebKitAPI::TEST):
3240         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3241         (WTR::InjectedBundle::didReceiveMessageToPage):
3242
3243 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3244
3245         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3246         https://bugs.webkit.org/show_bug.cgi?id=195001
3247
3248         Reviewed by Carlos Garcia Campos.
3249
3250         API version 1.0 always includes the functionality previously guarded with
3251         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3252         unconditionally.
3253
3254         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3255         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3256         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3257         (WebViewTest::showInWindow): Ditto.
3258         (WebViewTest::hideView): Ditto.
3259         * wpe/backends/HeadlessViewBackend.cpp:
3260         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3261         * wpe/backends/ViewBackend.cpp:
3262         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3263         * wpe/backends/WindowViewBackend.cpp:
3264         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3265         WPE_BACKEND_CHECK_VERSION().
3266         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3267
3268 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3269
3270         [Flatpak] Add support for flatpak > 1.1.2
3271         https://bugs.webkit.org/show_bug.cgi?id=194088
3272
3273         Flatpak 1.2 is now out so we need to support that
3274         version now.
3275
3276         Reviewed by Michael Catanzaro.
3277
3278         * flatpak/flatpakutils.py:
3279         (check_flatpak):
3280         (FlatpakPackages.__init__):
3281         (FlatpakPackages.__detect_packages):
3282         (FlatpakPackages.__detect_packages.in):
3283         (FlatpakRepos.update):
3284
3285 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3286
3287         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3288         https://bugs.webkit.org/show_bug.cgi?id=194998
3289
3290         Reviewed by Carlos Garcia Campos.
3291
3292         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3293         to a Git checkout and using the latest commit containing various fixes
3294         and improvements.
3295
3296 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3297
3298         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3299         https://bugs.webkit.org/show_bug.cgi?id=194981
3300
3301         Reviewed by Žan Doberšek.
3302
3303         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3304         (TestWebKitAPI::TEST):
3305
3306 2019-02-23  Keith Miller  <keith_miller@apple.com>
3307
3308         Add new mac target numbers
3309         https://bugs.webkit.org/show_bug.cgi?id=194955
3310
3311         Reviewed by Tim Horton.
3312
3313         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3314         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3315         * MiniBrowser/Configurations/Base.xcconfig:
3316         * TestWebKitAPI/Configurations/Base.xcconfig:
3317         * WebKitTestRunner/Configurations/Base.xcconfig:
3318
3319 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3320
3321         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3322         https://bugs.webkit.org/show_bug.cgi?id=194846
3323
3324         Reviewed by Don Olmstead.
3325
3326         Added _search_paths() and _port_specific_expectations_files() for
3327         WinCairoPort.
3328
3329         * Scripts/webkitpy/port/win.py:
3330         (WinCairoPort.default_baseline_search_path):
3331         (WinCairoPort):
3332         (WinCairoPort._port_specific_expectations_files):
3333         (WinCairoPort._search_paths):
3334
3335 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3336
3337         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3338         https://bugs.webkit.org/show_bug.cgi?id=194963
3339
3340         Reviewed by Dean Jackson.
3341
3342         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3343         Do a `contains` check instead of `equals`, because in debug builds we
3344         put the GraphicsLayer pointer in a prefix.
3345
3346 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3347
3348         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3349         https://bugs.webkit.org/show_bug.cgi?id=194873
3350         <rdar://problem/46701974>
3351
3352         Reviewed by Tim Horton.
3353
3354         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3355
3356         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3357         (WTR::UIScriptController::menuRect const):
3358         (WTR::UIScriptController::isShowingMenu const):
3359         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3360         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3361         (WTR::UIScriptController::menuRect const):
3362
3363         Add a function to query the bounds of the callout menu in content coordinates.
3364
3365         (WTR::UIScriptController::isShowingMenu const):
3366
3367         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3368
3369         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3370         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3371         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3372         (WTR::UIScriptController::rectForMenuAction const):
3373         (WTR::UIScriptController::menuRect const):
3374         (WTR::UIScriptController::isShowingMenu const):
3375         (WTR::findViewInHierarchyOfType): Deleted.
3376
3377 2019-02-22  Chris Dumez  <cdumez@apple.com>
3378
3379         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3380         https://bugs.webkit.org/show_bug.cgi?id=194954
3381         <rdar://problem/48127957>
3382
3383         Reviewed by Alex Christensen.
3384
3385         Add API test coverage.
3386
3387         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3388         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3389         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3390         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3391
3392 2019-02-22  Chris Dumez  <cdumez@apple.com>
3393
3394         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3395         https://bugs.webkit.org/show_bug.cgi?id=194924
3396         <rdar://problem/48216125>
3397
3398         Reviewed by Geoffrey Garen.
3399
3400         Add API test coverage.
3401
3402         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3403
3404 2019-02-22  Chris Dumez  <cdumez@apple.com>
3405
3406         Unreviewed, disable API test added in r241928 on iOS.
3407
3408         The cache is not enabled on devices with less than 3GB of RAM.
3409
3410         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3411
3412 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3413
3414         Hardcode Visual Viewports on everywhere except iOS WK1
3415         https://bugs.webkit.org/show_bug.cgi?id=194928
3416
3417         Reviewed by Zalan Bujtas.
3418
3419         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3420         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3421         set it to false. The setting has shipped for several years and there's no need to turn
3422         it off now.
3423
3424         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3425         Visual Viewports are not enabled.
3426         
3427         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3428         that only runs in WK2
3429
3430         * MiniBrowser/mac/SettingsController.h:
3431         * MiniBrowser/mac/SettingsController.m:
3432         (-[SettingsController init]):
3433         (-[SettingsController _populateMenu]):
3434         (-[SettingsController validateMenuItem:]):
3435         (-[SettingsController visualViewportEnabled]): Deleted.
3436         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3437         * MiniBrowser/mac/WK1BrowserWindowController.m:
3438         (-[WK1BrowserWindowController didChangeSettings]):
3439         * MiniBrowser/mac/WK2BrowserWindowController.m:
3440         (-[WK2BrowserWindowController didChangeSettings]):
3441
3442 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3443
3444         Discard cached processes when clearing website data store
3445         https://bugs.webkit.org/show_bug.cgi?id=194894
3446
3447         Reviewed by Chris Dumez.
3448
3449         Added a test case.
3450
3451         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3452         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3453
3454 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3455
3456         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3457         https://bugs.webkit.org/show_bug.cgi?id=194914
3458         <rdar://problem/47586889>
3459
3460         Reviewed by Geoffrey Garen.
3461
3462         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3463         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3464         (TEST):
3465         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3466
3467 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3468
3469         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3470         <https://webkit.org/b/194761>
3471
3472         Reviewed by Myles Maxfield.
3473
3474         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3475         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3476         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3477         to use ARC-compliant cast.
3478         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3479         ARC-compliant cast.
3480         (WTR::installFakeHelvetica): Log `error` to console if
3481         CTFontManagerRegisterFontsForURL() fails, but only on supported
3482         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3483         Call CFRelease() on `error` to fix the leak.  Update to use
3484         ARC-compliant cast.
3485         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3486         cast.
3487
3488 2019-02-21  Chris Dumez  <cdumez@apple.com>
3489
3490         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3491         https://bugs.webkit.org/show_bug.cgi?id=194481
3492
3493         Reviewed by Alex Christensen.
3494
3495         Give the processes a chance to shutdown and wait until we reached the expected number
3496         of processes.
3497
3498         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3499
3500 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3501
3502         Fix the macOS build
3503
3504         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3505
3506 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3507
3508         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3509
3510         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3511         I am a backwards.
3512
3513 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3514
3515         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3516
3517         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3518         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3519         We could force on UI-side compositing, but I feel like the test might be more
3520         valuable exercising the normal path on each platform (though the original
3521         bug was also UI-side specific). Though we can't validate that the overlay
3522         layer was installed successfully, there are layout tests that do that.
3523
3524 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3525
3526         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3527         https://bugs.webkit.org/show_bug.cgi?id=194845
3528         <rdar://problem/47944579>
3529
3530         Reviewed by Antti Koivisto.
3531
3532         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3533         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3534
3535 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3536
3537         [LFC][Floats] Add support for placing formatting roots in-between floats.
3538         https://bugs.webkit.org/show_bug.cgi?id=194902
3539
3540         Reviewed by Antti Koivisto.
3541
3542         * LayoutReloaded/misc/LFC-passing-tests.txt:
3543
3544 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3545
3546         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3547         https://bugs.webkit.org/show_bug.cgi?id=194901
3548
3549         Unreviewed build fix.
3550
3551         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3552         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3553         WPEBackend-fdo-0.1 as library name.
3554
3555 2019-02-21  Rob Buis  <rbuis@igalia.com>
3556
3557         Update MIME type parser
3558         https://bugs.webkit.org/show_bug.cgi?id=180526
3559
3560         Reviewed by Darin Adler.
3561
3562         Add tests involving leading and trailing whitespace, non-token
3563         characters and quoted strings.
3564
3565         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3566         (TestWebKitAPI::TEST):
3567
3568 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3569
3570         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3571         https://bugs.webkit.org/show_bug.cgi?id=194884
3572
3573         Reviewed by Michael Catanzaro.
3574
3575         * PlatformWin.cmake:
3576
3577 2019-02-20  Chris Dumez  <cdumez@apple.com>
3578
3579         Add API test for <rdar://problem/47471222>
3580         https://bugs.webkit.org/show_bug.cgi?id=194847
3581
3582         Reviewed by Alex Christensen.
3583
3584         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3585
3586 2019-02-20  Chris Dumez  <cdumez@apple.com>
3587
3588         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3589         https://bugs.webkit.org/show_bug.cgi?id=194872
3590         <rdar://problem/47924500>
3591
3592         Reviewed by Alex Christensen.
3593
3594         Add API test coverage.
3595
3596         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3597
3598 2019-02-20  Jer Noble  <jer.noble@apple.com>
3599
3600         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3601         https://bugs.webkit.org/show_bug.cgi?id=191332
3602
3603         Reviewed by Dean Jackson.
3604
3605         * Scripts/git-is-in-range: Added.
3606
3607 2019-02-20  Andy Estes  <aestes@apple.com>
3608
3609         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3610         https://bugs.webkit.org/show_bug.cgi?id=194869
3611
3612         Rubber-stamped by Jer Noble.
3613
3614         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3615         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3616         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3617         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3618         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3619         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3620
3621 2019-02-20  Chris Dumez  <cdumez@apple.com>
3622
3623         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3624         https://bugs.webkit.org/show_bug.cgi?id=194857
3625         <rdar://problem/47759323>
3626
3627         Reviewed by Alex Christensen.
3628
3629         Add API test coverage.
3630
3631         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3632
3633 2019-02-20  Chris Dumez  <cdumez@apple.com>
3634
3635         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3636         https://bugs.webkit.org/show_bug.cgi?id=194829
3637         <rdar://problem/47889906>
3638
3639         Reviewed by Alexey Proskuryakov.
3640
3641         Every time the TestOptions were changing we were creating both a new Web view and
3642         a new WKContext, which would start a new Network process. In most cases, we only
3643         need to contruct a new Web view and we do can keep reusing the same WKContext.
3644         This patch implements this optimization and thus avoids spinning a lot of new
3645         Network processes while running the layout tests.
3646
3647         * WebKitTestRunner/TestController.cpp:
3648         (WTR::TestController::generateContextConfiguration const):
3649         (WTR::TestController::generatePageConfiguration):
3650         (WTR::TestController::createWebViewWithOptions):
3651         (WTR::TestController::resetPreferencesToConsistentValues):
3652         (WTR::updateTestOptionsFromTestHeader):
3653         * WebKitTestRunner/TestController.h:
3654         * WebKitTestRunner/TestOptions.h:
3655         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3656         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3657         (WTR::TestOptions::hasSameInitializationOptions const):
3658         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3659         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3660         (WTR::TestController::platformAddTestOptions const):
3661
3662 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3663
3664         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3665         https://bugs.webkit.org/show_bug.cgi?id=167941
3666
3667         Reviewed by Carlos Garcia Campos.
3668
3669         * MiniBrowser/gtk/main.c:
3670         (filterSavedCallback): Added.
3671         (main): Support loading a JSON rule set file for content filtering.
3672         * MiniBrowser/wpe/main.cpp:
3673         (filterSavedCallback): Added.
3674         (main): Support loading a JSON rule set file for content filtering.
3675         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3676         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3677         (WTF::derefGPtr): Ditto.
3678         (testEmptyStore):
3679         (testSaveInvalidFilter):
3680         (testSaveLoadFilter):
3681         (testSavedFilterIdentifierMatch):
3682         (testRemoveFilter):
3683         (testSaveMultipleFilters):
3684         (testSaveFilterFromFile):
3685         (testFilterPersistence):
3686         (beforeAll):
3687         (afterAll):
3688         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3689         (removeOldInjectedContentAndResetLists): Also reset content filters.
3690         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3691         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3692         the element affected by the style sheet.
3693         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3694         and returns it to be used by tests.
3695         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3696         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3697         (serverCallback): Add support for serving a CSS style sheet for testing.
3698         (beforeAll): Add call to testUserContentManagerContentFilter().
3699         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3700
3701 2019-02-19  Keith Rollin  <krollin@apple.com>
3702
3703         Add timing information to build output
3704         https://bugs.webkit.org/show_bug.cgi?id=194839
3705         <rdar://problem/48219609>
3706
3707         Reviewed by Alexey Proskuryakov.
3708
3709         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3710         emit each project's build time to its output. E.g.,
3711
3712             ** BUILD SUCCEEDED ** [0.132 sec]
3713
3714         * Scripts/webkitdirs.pm:
3715         (XcodeOptions):
3716
3717 2019-02-19  Truitt Savell  <tsavell@apple.com>
3718
3719         Unreviewed, rolling out r241784.
3720
3721         Broke all OpenSource builds.
3722
3723         Reverted changeset:
3724
3725         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3726         instances view"
3727         https://bugs.webkit.org/show_bug.cgi?id=172848
3728         https://trac.webkit.org/changeset/241784
3729
3730 2019-02-19  Zalan Bujtas  <zalan@apple.com>
3731
3732         [LFC][Floats] Remove redundant intersecting logic
3733         https://bugs.webkit.org/show_bug.cgi?id=194804
3734
3735         Reviewed by Antti Koivisto.
3736
3737         * LayoutReloaded/misc/LFC-passing-tests.txt:
3738
3739 2019-02-19  Dean Jackson  <dino@apple.com>
3740
3741         Clean-up output from generate-xcfilelists so it can be filtered
3742         https://bugs.webkit.org/show_bug.cgi?id=194795
3743
3744         Reviewed by Joseph Pecoraro (and Keith Rollin).
3745
3746         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
3747         make a slight tweak to filter-build-webkit so such lines are marked
3748         as plain.
3749
3750         * Scripts/filter-build-webkit:
3751         * Scripts/generate-xcfilelists:
3752
3753 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3754
3755         pytest is not correctly auto-installed
3756         https://bugs.webkit.org/show_bug.cgi?id=194707
3757
3758         Reviewed by Carlos Garcia Campos.
3759
3760         * Scripts/webkitpy/thirdparty/__init__.py:
3761         (AutoinstallImportHook._install_pytest):
3762
3763 2019-02-18  Chris Dumez  <cdumez@apple.com>
3764
3765         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
3766         https://bugs.webkit.org/show_bug.cgi?id=194797
3767         <rdar://problem/48055151>
3768
3769         Reviewed by Geoffrey Garen.
3770
3771         Add API test coverage.
3772
3773         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3774
3775 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3776
3777         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
3778         https://bugs.webkit.org/show_bug.cgi?id=194670
3779         <rdar://problem/39066529>
3780
3781         Reviewed by Tim Horton.
3782
3783         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
3784         pasted in an editable area as attachment elements.
3785
3786         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3787         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3788         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
3789         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3790         (TestWebKitAPI::TEST):
3791         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3792         (WTR::InjectedBundlePage::InjectedBundlePage):
3793
3794 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3795
3796         Fix API test after r241728
3797        ​https://bugs.webkit.org/show_bug.cgi?id=194723
3798
3799         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3800         (TEST):
3801         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
3802
3803 2019-02-18  Daniel Bates  <dabates@apple.com>
3804
3805         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3806         https://bugs.webkit.org/show_bug.cgi?id=192824
3807         <rdar://problem/47100332>
3808
3809         Reviewed by Wenson Hsieh.
3810
3811         Fix a bug where the wrong usage code was used for F13 thru F24.
3812
3813         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3814         (keyCodeForDOMFunctionKey):
3815
3816 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
3817
3818         Bytecode cache should a have a boot-specific validation
3819         https://bugs.webkit.org/show_bug.cgi?id=194769
3820         <rdar://problem/48149509>
3821
3822         Reviewed by Keith Miller.
3823
3824         Add test for WTF::bootSessionUUIDString()
3825
3826         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3827         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
3828         (TEST):
3829
3830 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3831
3832         Disable safe browsing in WKWebView and remove its WKPreferences API
3833         https://bugs.webkit.org/show_bug.cgi?id=194723
3834         <rdar://problem/48122993>
3835
3836         Reviewed by Geoffrey Garen.
3837
3838         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3839         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3840         (TEST):
3841         (safeBrowsingView):
3842         Make tests use SPI instead of API.
3843
3844 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3845
3846         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
3847         https://bugs.webkit.org/show_bug.cgi?id=194586
3848
3849         Reviewed by Ross Kirsling.
3850
3851         * DumpRenderTree/win/DumpRenderTree.cpp:
3852         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
3853         * Scripts/webkitpy/port/driver.py:
3854         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
3855
3856 2019-02-17  David Kilzer  <ddkilzer@apple.com>
3857
3858         Unreviewed, rolling out r241620.
3859
3860         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
3861         (Requested by ddkilzer on #webkit.)
3862
3863         Reverted changeset:
3864
3865         "[WTF] Add environment variable helpers"
3866         https://bugs.webkit.org/show_bug.cgi?id=192405
3867         https://trac.webkit.org/changeset/241620
3868
3869 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3870
3871         [LFC] RenderImage's default intrinsic size is 0.
3872         https://bugs.webkit.org/show_bug.cgi?id=194745
3873
3874         Reviewed by Antti Koivisto.
3875
3876         * LayoutReloaded/misc/LFC-passing-tests.txt:
3877
3878 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3879
3880         [LFC][BFC] Add support for block replaced intrinsic width.
3881         https://bugs.webkit.org/show_bug.cgi?id=194705
3882
3883         Reviewed by Simon Fraser.
3884
3885         * LayoutReloaded/misc/LFC-passing-tests.txt:
3886
3887 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3888
3889         [LFC] Apply min/max width constraints to preferred width computation
3890         https://bugs.webkit.org/show_bug.cgi?id=194739
3891
3892         Reviewed by Simon Fraser.
3893
3894         * LayoutReloaded/misc/LFC-passing-tests.txt:
3895
3896 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
3897
3898         [WTF] Add environment variable helpers
3899         https://bugs.webkit.org/show_bug.cgi?id=192405
3900
3901         Reviewed by Michael Catanzaro.
3902
3903         * DumpRenderTree/mac/DumpRenderTree.mm:
3904         (libraryPathForDumpRenderTree):
3905         * DumpRenderTree/win/DumpRenderTree.cpp:
3906         (libraryPathForDumpRenderTree):
3907         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3908         (setUpIOSLayoutTestCommunication):
3909         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3910         (beforeAll):
3911         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3912         (main):
3913         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3914         (WebKitTestBus::run):
3915         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3916         (WTR::getOutputDir):
3917         (WTR::initializeFontConfigSetting):
3918         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3919         (WTR::InjectedBundle::platformInitialize):
3920         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3921         (WTR::topLevelPath):
3922         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3923         (WTR::topLevelPath):
3924         (WTR::getOutputDir):
3925         (WTR::activateFonts):
3926         * WebKitTestRunner/TestController.cpp:
3927         (WTR::TestController::libraryPathForTesting):
3928         (WTR::TestController::generateContextConfiguration const):
3929         (WTR::TestController::generatePageConfiguration):
3930         (WTR::TestController::decideDestinationWithSuggestedFilename):
3931         (WTR::TestController::platformAdjustContext):
3932         * WebKitTestRunner/TestController.h:
3933         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3934         (WTR::TestController::cocoaPlatformInitialize):
3935         (WTR::TestController::platformAdjustContext):
3936         * WebKitTestRunner/gtk/main.cpp:
3937         (main):
3938         * WebKitTestRunner/mac/TestControllerMac.mm:
3939         (WTR::TestController::configureContentExtensionForTest):
3940         * WebKitTestRunner/wpe/main.cpp:
3941         (main):
3942         Utilize WTF::Environment where possible.
3943
3944 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3945
3946         [iOS] WKWebView callout bar is missing Change Writing Direction item
3947         https://bugs.webkit.org/show_bug.cgi?id=190015
3948         <rdar://problem/44810366>
3949
3950         Reviewed by Tim Horton.
3951
3952         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
3953         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
3954
3955         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
3956         (TestWebKitAPI::TEST):
3957
3958 2019-02-15  Chris Dumez  <cdumez@apple.com>
3959
3960         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
3961         https://bugs.webkit.org/show_bug.cgi?id=194717
3962         <rdar://problem/47884404>
3963
3964         Reviewed by Brady Eidson.
3965
3966         Add API test coverage.
3967
3968         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3969
3970 2019-02-15  Youenn Fablet  <youenn@apple.com>
3971
3972         Make navigator.mediaDevices SecureContext
3973         https://bugs.webkit.org/show_bug.cgi?id=194666
3974
3975         Reviewed by Eric Carlson.
3976
3977         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3978         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
3979         (TEST_F):
3980
3981 2019-02-15  Brian Burg  <bburg@apple.com>
3982
3983         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3984         https://bugs.webkit.org/show_bug.cgi?id=194411
3985         <rdar://problem/47787614>
3986
3987         Reviewed by Joseph Pecoraro.
3988
3989         Remove unnecessary soft linking macro usage.
3990
3991         * DumpRenderTree/mac/TestRunnerMac.mm:
3992         (TestRunner::inspectorTestStubURL):
3993         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3994         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3995         (WTR::TestRunner::inspectorTestStubURL):
3996
3997 2019-02-15  Commit Queue  <commit-queue@webkit.org>
3998
3999         Unreviewed, rolling out r241559 and r241566.
4000         https://bugs.webkit.org/show_bug.cgi?id=194710
4001
4002         Causes layout test crashes under GuardMalloc (Requested by
4003         ryanhaddad on #webkit).
4004
4005         Reverted changesets:
4006
4007         "[WTF] Add environment variable helpers"
4008         https://bugs.webkit.org/show_bug.cgi?id=192405
4009         https://trac.webkit.org/changeset/241559
4010
4011         "Unreviewed build fix for WinCairo Debug after r241559."
4012         https://trac.webkit.org/changeset/241566
4013
4014 2019-02-15  Zalan Bujtas  <zalan@apple.com>
4015
4016         [LFC] Out-of-flow box is never a float box
4017         https://bugs.webkit.org/show_bug.cgi?id=194704
4018
4019         Reviewed by Antti Koivisto.
4020
4021         * LayoutReloaded/misc/LFC-passing-tests.txt:
4022
4023 2019-02-10  Darin Adler  <darin@apple.com>
4024
4025         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
4026         https://bugs.webkit.org/show_bug.cgi?id=194487
4027
4028         Reviewed by Daniel Bates.
4029
4030         * DumpRenderTree/win/DumpRenderTree.cpp:
4031         (applicationId): Use makeString instead of String::format.
4032         (main): Ditto.
4033         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4034         (TestWebKitAPI::Util::createURLForResource): Ditto.
4035         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
4036         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
4037
4038         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4039         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
4040         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
4041         (WTR::createStringWithAttributes): Use appendLiteral.
4042         (WTR::AccessibilityUIElement::helpText const): Ditto.
4043         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
4044         directly instead of using String::format.
4045         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
4046         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
4047
4048 2019-02-15  Truitt Savell  <tsavell@apple.com>
4049
4050         Unreviewed, rolling out r241564.
4051
4052         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
4053
4054         Reverted changeset:
4055
4056         "[Mac] WebInspectorUI.framework does not need to be soft-
4057         linked anymore"
4058         https://bugs.webkit.org/show_bug.cgi?id=194411
4059         https://trac.webkit.org/changeset/241564
4060
4061 2019-02-15  Saam barati  <sbarati@apple.com>
4062
4063         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
4064         https://bugs.webkit.org/show_bug.cgi?id=194036
4065
4066         Reviewed by Yusuke Suzuki.
4067
4068         * Scripts/run-jsc-stress-tests:
4069
4070 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4071
4072         Fix the build.
4073
4074         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4075         (WTR::UIScriptController::drawSquareInEditableImage):
4076         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4077         (TestWebKitAPI::drawSquareInEditableImage):
4078
4079 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4080
4081         Fix the build.
4082
4083         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4084         (WTR::UIScriptController::drawSquareInEditableImage):
4085         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4086         (TestWebKitAPI::drawSquareInEditableImage):
4087
4088 2019-02-14  Brian Burg  <bburg@apple.com>
4089
4090         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4091         https://bugs.webkit.org/show_bug.cgi?id=194411
4092         <rdar://problem/47787614>
4093
4094         Reviewed by Joseph Pecoraro.
4095
4096         Remove unnecessary soft linking macro usage.
4097
4098         * DumpRenderTree/mac/TestRunnerMac.mm:
4099         (TestRunner::inspectorTestStubURL):
4100         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4101         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4102         (WTR::TestRunner::inspectorTestStubURL):
4103
4104 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
4105
4106         [ews-app] status bubble should fetch builder name info from BuilderMapping table
4107         https://bugs.webkit.org/show_bug.cgi?id=194599
4108
4109         Reviewed by Lucas Forschler.
4110
4111         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4112         (StatusBubble._build_bubble):
4113
4114 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
4115
4116         [ews-app] Set Foreign Key in Django build model
4117         https://bugs.webkit.org/show_bug.cgi?id=194667
4118
4119         Reviewed by Lucas Forschler.
4120
4121         * BuildSlaveSupport/ews-app/ews/models/build.py:
4122         (Build):
4123
4124 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
4125
4126         [WTF] Add environment variable helpers
4127         https://bugs.webkit.org/show_bug.cgi?id=192405
4128
4129         Reviewed by Michael Catanzaro.
4130
4131         * DumpRenderTree/mac/DumpRenderTree.mm:
4132         (libraryPathForDumpRenderTree):
4133         * DumpRenderTree/win/DumpRenderTree.cpp:
4134         (libraryPathForDumpRenderTree):
4135         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4136         (setUpIOSLayoutTestCommunication):
4137         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4138         (TestWebKitAPI::strip):
4139         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4140         (beforeAll):
4141         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4142         (main):
4143         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4144         (WebKitTestBus::run):
4145         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4146         (WTR::getOutputDir):
4147         (WTR::initializeFontConfigSetting):
4148         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4149         (WTR::InjectedBundle::platformInitialize):
4150         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4151         (WTR::topLevelPath):
4152         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4153         (WTR::topLevelPath):
4154         (WTR::getOutputDir):
4155         (WTR::activateFonts):
4156         * WebKitTestRunner/TestController.cpp:
4157         (WTR::TestController::libraryPathForTesting):
4158         (WTR::TestController::generateContextConfiguration const):
4159         (WTR::TestController::generatePageConfiguration):
4160         (WTR::TestController::decideDestinationWithSuggestedFilename):
4161         (WTR::TestController::platformAdjustContext):
4162         * WebKitTestRunner/TestController.h:
4163         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4164         (WTR::TestController::cocoaPlatformInitialize):
4165         (WTR::TestController::platformAdjustContext):
4166         * WebKitTestRunner/gtk/main.cpp:
4167         (main):
4168         * WebKitTestRunner/mac/TestControllerMac.mm:
4169         (WTR::TestController::configureContentExtensionForTest):
4170         * WebKitTestRunner/wpe/main.cpp:
4171         (main):
4172         Utilize WTF::Environment where possible.
4173
4174 2019-02-14  Chris Dumez  <cdumez@apple.com>
4175
4176         [PSON] Introduce a WebContent Process cache
4177         https://bugs.webkit.org/show_bug.cgi?id=194594
4178         <rdar://problem/46793397>
4179
4180         Reviewed by Geoff Garen.
4181
4182         Update API tests to turn on the WebContent Process cache.
4183
4184         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4185
4186 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
4187
4188         Unreviewed, build fix after r241480
4189
4190         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4191         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
4192         (-[DragAndDropSimulator initWithWebView:]):
4193
4194 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
4195
4196         AX: ARIA Reflection was disabled in error
4197         https://bugs.webkit.org/show_bug.cgi?id=194647
4198         <rdar://problem/48068336>
4199
4200         Reviewed by Ryosuke Niwa.
4201
4202         Remove test override now that this feature should be enabled by default.
4203
4204         * WebKitTestRunner/TestController.cpp:
4205         (WTR::TestController::resetPreferencesToConsistentValues):
4206
4207 2019-02-14  Commit Queue  <commit-queue@webkit.org>
4208
4209         Unreviewed, rolling out r241486.
4210         https://bugs.webkit.org/show_bug.cgi?id=194655
4211
4212         causing API failures in builds (Requested by ShawnRoberts on
4213         #webkit).
4214
4215         Reverted changeset:
4216
4217         "[Cocoa] Media elements will restart network buffering just
4218         before suspending"
4219         https://bugs.webkit.org/show_bug.cgi?id=193691
4220         https://trac.webkit.org/changeset/241486
4221
4222 2019-02-14  Zalan Bujtas  <zalan@apple.com>
4223
4224         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
4225         https://bugs.webkit.org/show_bug.cgi?id=194622
4226
4227         Reviewed by Antti Koivisto.
4228
4229         * LayoutReloaded/misc/LFC-passing-tests.txt:
4230
4231 2019-02-14  Zalan Bujtas  <zalan@apple.com>
4232
4233         [LFC] Shrink-to-fit-width should be constrained by min/max width
4234         https://bugs.webkit.org/show_bug.cgi?id=194653
4235
4236         Reviewed by Antti Koivisto.
4237
4238         * LayoutReloaded/misc/LFC-passing-tests.txt:
4239
4240 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
4241
4242         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
4243         https://bugs.webkit.org/show_bug.cgi?id=194641
4244
4245         Reviewed by Geoffrey Garen.
4246
4247         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
4248         so that the test would fail without this fix.
4249
4250         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
4251         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
4252
4253 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
4254
4255         [ews-app] Change log level for a log statement
4256
4257         Unreviewed minor fix.
4258
4259         * BuildSlaveSupport/ews-app/ews/models/patch.py:
4260         (Patch.save_patch):
4261
4262 2019-02-13  Jer Noble  <jer.noble@apple.com>
4263
4264         [Cocoa] Media elements will restart network buffering just before suspending
4265         https://bugs.webkit.org/show_bug.cgi?id=193691
4266
4267         Reviewed by Eric Carlson.
4268
4269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4270         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4271         (TEST):
4272
4273 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
4274
4275         [ews-app] Fetch builder id to name mapping
4276         https://bugs.webkit.org/show_bug.cgi?id=194355
4277
4278         Reviewed by Lucas Forschler.
4279
4280         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
4281         (Buildbot.get_builder_id_to_name_mapping):
4282         (Buildbot._get_display_name_from_builder_name):
4283
4284 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
4285
4286         Further restricting webarchive loads
4287         https://bugs.webkit.org/show_bug.cgi?id=194567
4288         <rdar://problem/47610130>
4289
4290         Reviewed by Youenn Fablet.
4291
4292         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
4293         navigations on drop.
4294
4295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4296         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
4297         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
4298         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
4299         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
4300         (TestWebKitAPI::TEST):
4301         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
4302         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
4303         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
4304         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
4305         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
4306         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
4307         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
4308
4309 2019-02-13  John Wilander  <wilander@apple.com>
4310
4311         Store Ad Click Attribution requests in the network process
4312         https://bugs.webkit.org/show_bug.cgi?id=194510
4313         <rdar://problem/47650118>
4314
4315         Reviewed by Alex Christensen and Daniel Bates.
4316
4317         This patch adds two TestRunner functions:
4318         - dumpAdClickAttribution()
4319         - clearAdClickAttribution()
4320
4321         They call into the network process to dump and clear Ad Click
4322         Attribution state, respectively.
4323
4324         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4325         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4326         (WTR::TestRunner::dumpAdClickAttribution):
4327         (WTR::TestRunner::clearAdClickAttribution):
4328         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4329         * WebKitTestRunner/TestController.cpp:
4330         (WTR::TestController::resetStateToConsistentValues):
4331         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
4332         (WTR::adClickAttributionStringResultCallback):
4333         (WTR::TestController::dumpAdClickAttribution):
4334         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
4335         (WTR::adClickAttributionVoidCallback):
4336         (WTR::TestController::clearAdClickAttribution):
4337         * WebKitTestRunner/TestController.h:
4338         * WebKitTestRunner/TestInvocation.cpp:
4339         (WTR::TestInvocation::dumpResults):
4340         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4341         (WTR::TestInvocation::dumpAdClickAttribution):
4342         * WebKitTestRunner/TestInvocation.h:
4343
4344 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
4345
4346         [ews-app] Generate status-bubble
4347         https://bugs.webkit.org/show_bug.cgi?id=194572
4348
4349         Reviewed by Lucas Forschler.
4350
4351         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4352         (StatusBubble._build_bubble):
4353         (StatusBubble._should_show_bubble_for):
4354         (StatusBubble._build_bubbles_for_patch):
4355
4356 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
4357
4358         [ews-app] Add status bubble html template
4359         https://bugs.webkit.org/show_bug.cgi?id=194571
4360
4361         Reviewed by Lucas Forschler.