[EFL] build fails with error: 'UINT_MAX' was not declared in this scope
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
2
3         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
4         https://bugs.webkit.org/show_bug.cgi?id=114086
5
6         Reviewed by Tim Horton.
7
8         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
9
10 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
11
12         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
13         https://bugs.webkit.org/show_bug.cgi?id=114083
14
15         Reviewed by Ryosuke Niwa.
16
17         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
18         in TestWebKitAPI and WebKitTestRunner.
19
20         * TestWebKitAPI/config.h:
21         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
22         (TestWebKitAPI::InjectedBundleController::platformInitialize):
23         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
24         (WTR::InjectedBundle::platformInitialize):
25
26 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
27
28         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
29         https://bugs.webkit.org/show_bug.cgi?id=114094
30
31         Reviewed by Anders Carlsson.
32
33         * Scripts/run-jsc:
34
35 2013-04-05  Ojan Vafai  <ojan@chromium.org>
36
37         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
38         https://bugs.webkit.org/show_bug.cgi?id=114080
39
40         Reviewed by Ryosuke Niwa.
41
42         This way, the WebKit and Blink dashboard code can change as appropriate without
43         needing to consider the other project's needs. This still doesn't update the
44         buildbots to upload to the new location, or the dashboard code to pull the
45         results.json files from the new location, but it at least allows for changing the
46         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
47
48         * TestResultServer/app.yaml:
49
50 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
51
52         Re-enable testing on the commit queue
53         https://bugs.webkit.org/show_bug.cgi?id=114078
54
55         Reviewed by Darin Adler.
56
57         Re-enabled the feature and the associated tests.
58
59         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
60         (CommitQueueTask.run):
61         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
62         (CommitQueueTaskTest._run_through_task):
63         * Scripts/webkitpy/tool/commands/queues_unittest.py:
64         (CommitQueueTest._mock_test_result):
65
66 2013-04-05  Oliver Hunt  <oliver@apple.com>
67
68         Unify the many and varied stack trace mechanisms, and make the result sane.
69         https://bugs.webkit.org/show_bug.cgi?id=114072
70
71         Reviewed by Filip Pizlo.
72
73         The commandline jsc executable no longer requires arguments, so
74         I've made run-jsc work without them.
75
76         * Scripts/run-jsc:
77
78 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
79
80         AX: Make SVG Group containers accessible elements
81         https://bugs.webkit.org/show_bug.cgi?id=113939
82
83         Reviewed by Simon Fraser.
84
85         Implement axController.elementAtPoint for iOS.
86         Implement a correct version of clickPoint for iOS.
87
88         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
89         (AccessibilityController::elementAtPoint):
90         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
91         (AccessibilityUIElement::clickPointX):
92         (AccessibilityUIElement::clickPointY):
93
94 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
95
96         Unreviewed, rolling out r147773 and r147774.
97         http://trac.webkit.org/changeset/147773
98         http://trac.webkit.org/changeset/147774
99         https://bugs.webkit.org/show_bug.cgi?id=114056
100
101         Causing some exceptions on AppEngine I don't understand
102         (Requested by rniwa on #webkit).
103
104         * QueueStatusServer/config/queues.py:
105         * QueueStatusServer/model/queues.py:
106         (Queue.short_name):
107         (Queue.display_name):
108         * QueueStatusServer/model/queues_unittest.py:
109         (QueueTest.test_short_name):
110         (QueueTest.test_display_name):
111         (QueueTest.test_name_with_underscores):
112
113 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
114
115         Fixed run-bindings-tests by removing V8
116         https://bugs.webkit.org/show_bug.cgi?id=114053
117
118         Reviewed by Benjamin Poulain.
119
120         * Scripts/run-bindings-tests:
121         (main):
122
123 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
124
125         Build fix.
126
127         * QueueStatusServer/model/queues.py:
128         (Queue.short_name):
129         (Queue.display_name):
130
131 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
132
133         Remove Chromium EWS bots from the queue status server
134         https://bugs.webkit.org/show_bug.cgi?id=113988
135
136         Reviewed by Benjamin Poulain.
137
138         Removed Chromium EWS bots.
139
140         * QueueStatusServer/config/queues.py:
141         * QueueStatusServer/model/queues.py:
142         (Queue.short_name):
143         (Queue.display_name):
144         * QueueStatusServer/model/queues_unittest.py:
145         (QueueTest.test_short_name):
146         (QueueTest.test_display_name):
147         (QueueTest.test_name_with_underscores):
148
149 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
150
151         [EFL] Enable indexed database
152         https://bugs.webkit.org/show_bug.cgi?id=107248
153
154         Reviewed by Alexis Menard.
155
156         * Scripts/webkitperl/FeatureList.pm:
157
158 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
159
160         Remove vestiges of Chromium bits from watchlists.
161         https://bugs.webkit.org/show_bug.cgi?id=114047
162
163         Reviewed by Ryosuke Niwa.
164
165         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
166
167 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
168
169         Add James Craig to the contributors list.
170
171         * Scripts/webkitpy/common/config/committers.py:
172
173 2013-04-04  Kent Tamura  <tkent@chromium.org>
174
175         Remove ChromiumPublicApi pattern, and cc/message rules for it.
176
177         * Scripts/webkitpy/common/config/watchlist:
178
179 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
180
181         Temporarily disable the Python unittests broken by the commit queue not running layout tests
182         https://bugs.webkit.org/show_bug.cgi?id=113997
183
184         Reviewed by Ryosuke Niwa.
185
186         Disable the tests until Ryosuke gets the time and hardware to have
187         a testing commit-queue.
188
189         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
190         (CommitQueueTaskTest):
191         * Scripts/webkitpy/tool/commands/queues_unittest.py:
192         (CommitQueueTest):
193
194 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
195
196         Remove Chromium builders from build.webkit.org
197         https://bugs.webkit.org/show_bug.cgi?id=113990
198
199         Reviewed by Benjamin Poulain.
200
201         Land the part to disable triggering of Chromium builders first so that we may start
202         deleting more Chromium code that breaks the update step.
203
204         * BuildSlaveSupport/build.webkit.org-config/config.json:
205
206 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
207
208         Remove Chromium's DumpRenderTree
209         https://bugs.webkit.org/show_bug.cgi?id=113989
210
211         Reviewed by Kent Tamura.
212
213         On second thought, let's not go to Camelot. It is a silly place.
214
215         * DumpRenderTree/mac/DumpRenderTree.mm:
216         (resetDefaultsToConsistentValues):
217
218 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
219
220         Nixed the defunct chromium folder from DumpRenderTree
221         https://bugs.webkit.org/show_bug.cgi?id=113993
222
223         Reviewed by Ryosuke Niwa.
224
225         * DumpRenderTree/chromium: Removed.
226         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
227         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
228         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
229         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
230         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
231         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
232         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
233         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
234         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
235         * DumpRenderTree/chromium/MockPlatform.h: Removed.
236         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
237         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
238         * DumpRenderTree/chromium/Task.cpp: Removed.
239         * DumpRenderTree/chromium/Task.h: Removed.
240         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
241         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
242         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
243         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
244         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
245         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
246         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
247         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
248         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
249         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
250         * DumpRenderTree/chromium/TestRunner: Removed.
251         * DumpRenderTree/chromium/TestRunner/public: Removed.
252         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
253         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
254         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
255         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
256         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
257         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
258         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
259         * DumpRenderTree/chromium/TestRunner/src: Removed.
260         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
261         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
262         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
263         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
264         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
265         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
266         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
267         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
268         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
269         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
270         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
271         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
272         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
273         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
274         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
275         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
276         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
277         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
278         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
279         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
280         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
281         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
282         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
283         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
284         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
285         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
286         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
287         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
288         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
289         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
290         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
291         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
292         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
293         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
294         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
295         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
296         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
297         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
298         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
299         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
300         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
301         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
302         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
303         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
304         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
305         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
306         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
307         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
308         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
309         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
310         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
311         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
312         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
313         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
314         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
315         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
316         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
317         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
318         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
319         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
320         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
321         * DumpRenderTree/chromium/TestShell.cpp: Removed.
322         * DumpRenderTree/chromium/TestShell.h: Removed.
323         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
324         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
325         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
326         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
327         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
328         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
329         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
330         * DumpRenderTree/chromium/WebViewHost.h: Removed.
331         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
332         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
333         * DumpRenderTree/chromium/config.h: Removed.
334         * DumpRenderTree/chromium/fonts.conf: Removed.
335
336 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
337
338         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
339
340         Rubber stamped by Benjamin Poulain.
341
342         * RebaselineQueueServer: Removed.
343         * RebaselineQueueServer/app.yaml: Removed.
344         * RebaselineQueueServer/handlers: Removed.
345         * RebaselineQueueServer/handlers/__init__.py: Removed.
346         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
347         * RebaselineQueueServer/handlers/pages.py: Removed.
348         * RebaselineQueueServer/index.yaml: Removed.
349         * RebaselineQueueServer/main.py: Removed.
350         * RebaselineQueueServer/model: Removed.
351         * RebaselineQueueServer/model/__init__.py: Removed.
352         * RebaselineQueueServer/model/queueentry.py: Removed.
353         * RebaselineQueueServer/static: Removed.
354         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
355         * RebaselineQueueServer/static/styles.css: Removed.
356         * RebaselineQueueServer/templates: Removed.
357         * RebaselineQueueServer/templates/builder-picker.html: Removed.
358         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
359         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
360         * RebaselineQueueServer/templates/home.html: Removed.
361
362 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
363
364         Fix setup-commit-queue and temporarily disable testing on commit-queue
365         https://bugs.webkit.org/show_bug.cgi?id=113979
366
367         Reviewed by Benjamin Poulain.
368
369         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
370         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
371
372         * EWSTools/setup-commit-queue.sh:
373         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
374         (CommitQueueTask.run):
375
376 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
377
378         temporarily make flakiness dashboard work again webkit.org bots
379         https://bugs.webkit.org/show_bug.cgi?id=113972
380
381         Reviewed by Ojan Vafai.
382
383         This patch disables the chromium.org layout test bots TestExpectations
384         parsing temporarily until we can work out the right way to split into
385         two instances for webkit.org and chromium.org and figure out which
386         code to delete where :).
387
388         * TestResultServer/static-dashboards/flakiness_dashboard.js:
389
390 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
391
392         Fix webkitpy tests after r147678.
393
394         * Scripts/webkitpy/tool/commands/queues_unittest.py:
395         (CommitQueueTest.test_commit_queue):
396         (test_manual_reject_during_processing):
397
398 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
399
400         The commit queue should use Mac MountainLion port
401         https://bugs.webkit.org/show_bug.cgi?id=113971
402
403         Reviewed by Lucas Forschler.
404
405         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
406         * Scripts/webkitpy/tool/commands/queues.py:
407         (CommitQueue):
408
409 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
410
411         turn off running tests on chromium linux EWS bots
412         https://bugs.webkit.org/show_bug.cgi?id=113959
413
414         Reviewed by Geoffrey Garen.
415
416         Now that the Chromium port is no longer being maintained
417         there's little point in running the tests. Soon we should
418         just shut this bot off altogether.
419
420         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
421         (ChromiumLinuxEWS):
422
423 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
424
425         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
426
427         * Scripts/webkitpy/common/config/watchlist:
428
429 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
430
431         Indentation fix to get webkit-patch working again after r147625
432
433         Unreviewed.
434
435         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
436         (MacEWS):
437         (MacWK2EWS):
438
439 2013-04-04  Lucas Forschler  <lforschler@apple.com>
440
441         Turn tests back on for Mac WK1/WK2 EWS.
442         
443         Unreviewed.
444         
445         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
446         (MacEWS):
447         (MacWK2EWS):
448
449 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
450
451         [GTK][WK2] MiniBrowser custom URI scheme support
452         https://bugs.webkit.org/show_bug.cgi?id=112419
453
454         Reviewed by Carlos Garcia Campos.
455
456         Add support for about URIs in MiniBrowser. An example about page is show
457         with URI "about:minibrowser", the rest of the cases it will show a
458         proper message explaining that the about page didn't exist.
459
460         Internally it uses "minibrowser-about" prefix instead of "about", but
461         from the user point of view it works with "about" prefix.
462
463         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
464         (getInternalURI): Method to convert URIs from "about" prefix to
465         "minibrowser-about".
466         (getExternalURI): Opposite method.
467         (webViewURIChanged): Use "about" prefix to show the URI to users.
468         (webViewEnterFullScreen): Ditto.
469         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
470         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
471         (aboutURISchemeRequestCallback): Callback to manage about calls.
472         (main): Register the URI scheme to manage about URIs.
473
474 2013-04-03  Roger Fong  <roger_fong@apple.com>
475
476         Re-enable WinEWS tests.
477
478         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
479         (WinEWS):
480
481 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
482
483         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
484         https://bugs.webkit.org/show_bug.cgi?id=113883
485
486         Reviewed by Martin Robinson.
487
488         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
489         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
490         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
491
492 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
493
494         [GTK] Include Pango in jhbuild-optional.modules
495         https://bugs.webkit.org/show_bug.cgi?id=113878
496
497         Reviewed by Martin Robinson.
498
499         Since r147547 Pango 1.32.0 is required. Including the module in the
500         JHBuild optional moduleset.
501
502         * gtk/jhbuild-optional.modules: Add Pango module.
503
504 2013-04-03  Zeno Albisser  <zeno@webkit.org>
505
506         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
507         https://bugs.webkit.org/show_bug.cgi?id=113864
508
509         Moving setDefersLoading from TestRunnerQt to TestRunner
510         requires access to the non-Qt TestRunner.
511         As long as we instantiate both TestRunner and TestRunnerQt,
512         we need a separate getter for the non-Qt TestRunner instance.
513
514         Reviewed by Simon Hausmann.
515
516         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
517         (WebPage::resetSettings):
518         * DumpRenderTree/qt/DumpRenderTreeQt.h:
519         (DumpRenderTree::jscTestRunner):
520         * DumpRenderTree/qt/TestRunnerQt.cpp:
521         (TestRunner::setDefersLoading):
522             Moving setDefersLoading from TestRunnerQt
523             to TestRunner.
524         * DumpRenderTree/qt/TestRunnerQt.h:
525         (TestRunnerQt):
526
527 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
528
529         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
530         https://bugs.webkit.org/show_bug.cgi?id=104779
531
532         Reviewed by Carlos Garcia Campos.
533
534         * Scripts/run-gtk-tests:
535         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
536         passing in current trunk.
537
538 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
539
540         Fix HAVE(QTTESTSUPPORT) logic
541
542         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
543         resulting in HAVE(QTTESTSUPPORT) never being true.
544         Move that logic down in sanitizeFeatures.
545
546         Rubber-stamped by Tor Arne Vestbø.
547
548         * qmake/mkspecs/features/features.prf:
549
550 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
551
552         [GTK] Bump required versions of some dependencies
553         https://bugs.webkit.org/show_bug.cgi?id=113282
554
555         Reviewed by Martin Robinson.
556
557         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
558
559 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
560
561         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
562         https://bugs.webkit.org/show_bug.cgi?id=113809
563
564         Reviewed by Philippe Normand.
565
566         Newer Linux kernels have removed some deprecated macros from v4l2
567         headers, causing gst-plugins-good's build to break. We don't need it
568         right now, so just disable it.
569
570         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
571
572 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
573
574         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
575         https://bugs.webkit.org/show_bug.cgi?id=113535
576
577         Reviewed by Simon Hausmann.
578
579         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
580
581         * qmake/mkspecs/features/features.prf:
582
583 2013-04-03  Zeno Albisser  <zeno@webkit.org>
584
585         [Qt] Move logic of simple forwarding functions to TestRunner.
586         https://bugs.webkit.org/show_bug.cgi?id=113863
587
588         Reviewed by Simon Hausmann.
589
590         * DumpRenderTree/qt/TestRunnerQt.cpp:
591         (TestRunner::setTextDirection):
592         (TestRunner::goBack):
593         (TestRunner::evaluateScriptInIsolatedWorld):
594         (TestRunner::addUserStyleSheet):
595         * DumpRenderTree/qt/TestRunnerQt.h:
596         (TestRunnerQt):
597
598 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
599
600         [Qt] Disable media support using QuickTime if deployment target != SDK
601
602         We link to a single libWebKitSystemInterface static lib, so unless the
603         deployment target matches the SDK let's not pretend like we'll be able
604         to run on anything lower than the SDK version.
605
606         Reviewed by Simon Hausmann.
607
608         * qmake/mkspecs/features/features.prf:
609
610 2013-04-02  James Craig  <james@cookiecrook.com>
611
612         AXRoleDescripton for DL is "list"; should be "description list"
613         https://bugs.webkit.org/show_bug.cgi?id=111665
614
615         Reviewed by Chris Fleizach.
616
617         Defining the role and description strings.
618
619         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
620
621 2013-04-02  Roger Fong  <roger_fong@apple.com>
622
623         Unreviewed. Disable running tests on Win EWS queue.
624
625         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
626         (WinEWS):
627
628 2013-04-02  Lucas Forschler  <lforschler@apple.com>
629
630         Disable running tests on the MAC WK2 EWS queue.
631         
632         Unreviewed.
633         
634         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
635         (MacWK2EWS):
636
637 2013-04-02  Julie Parent  <jparent@chromium.org>
638
639         Dashboard refactor: Move dashboard specific history related features to History.
640         https://bugs.webkit.org/show_bug.cgi?id=113717
641
642         Reviewed by Ojan Vafai.
643         
644         Each dashboard now creates its own History object, with a custom
645         configuration. This changes from just overriding global functions
646         to passing in callbacks for generatePage, handleValidHashParameter,
647         and handleQueryParameterChange. Same with passing in defaultStateValues
648         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
649         variables.
650         
651         All functions related to these features are now (mostly) private
652         function on History. 
653         
654         Loader no longer needs a loadingComplete callback, since it can just
655         initialize the history object itself.
656
657         * TestResultServer/static-dashboards/aggregate_results.js:
658         (handleValidHashParameter):
659         * TestResultServer/static-dashboards/dashboard_base.js:
660         * TestResultServer/static-dashboards/flakiness_dashboard.js:
661         (generatePage):
662         (.switch.return):
663         (handleQueryParameterChange):
664         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
665         (resetGlobals):
666         * TestResultServer/static-dashboards/history.js:
667         (.):
668         * TestResultServer/static-dashboards/loader.js:
669         (.):
670         * TestResultServer/static-dashboards/loader_unittests.js:
671         * TestResultServer/static-dashboards/timeline_explorer.js:
672         (generatePage):
673         (initCurrentBuilderTestResults):
674         * TestResultServer/static-dashboards/treemap.js:
675         (generatePage):
676         (.switch.return):
677         (handleQueryParameterChange):
678
679 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
680
681         Unreviewed, rolling out r147401.
682         http://trac.webkit.org/changeset/147401
683         https://bugs.webkit.org/show_bug.cgi?id=113767
684
685         The patch makes it extremely hard to set up the dependencies
686         properly on the GTK builders (Requested by zdobersek on
687         #webkit).
688
689         * gtk/jhbuild.modules:
690
691 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
692
693         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
694         https://bugs.webkit.org/show_bug.cgi?id=113382
695
696         Reviewed by Gyuyoung Kim.
697
698         Do not show the empty tooltip box if the text is null.
699
700         * MiniBrowser/efl/main.c:
701         (popup_menu_populate):
702
703 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
704
705         [GTK] Bump required versions of some dependencies
706         https://bugs.webkit.org/show_bug.cgi?id=113282
707
708         Reviewed by Martin Robinson.
709
710         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
711
712 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
713
714         Unreviewed, rolling out r147319.
715         http://trac.webkit.org/changeset/147319
716         https://bugs.webkit.org/show_bug.cgi?id=113707
717
718         The unit test is still failing on the buildbot (Requested by
719         zdobersek on #webkit).
720
721         * Scripts/run-gtk-tests:
722         (TestRunner):
723
724 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
725
726         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
727         https://bugs.webkit.org/show_bug.cgi?id=104779
728
729         Reviewed by Carlos Garcia Campos.
730
731         * Scripts/run-gtk-tests:
732         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
733         passing in current trunk.
734
735 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
736
737         Unreviewed, rolling out r147289.
738         http://trac.webkit.org/changeset/147289
739         https://bugs.webkit.org/show_bug.cgi?id=113678
740
741         broke Win7 (dbg) build (Requested by shinyak|gardener on
742         #webkit).
743
744         * DumpRenderTree/DumpRenderTree.gypi:
745         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
746         (WebTestRunner):
747         (WebUserMediaClientMock):
748         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
749         (WebTestRunner::WebUserMediaClientMock::taskList):
750         * Scripts/webkitpy/style/checkers/cpp.py:
751         (check_function_definition):
752
753 2013-03-31  Adam Barth  <abarth@webkit.org>
754
755         configure-svn-config.sh fails
756         https://codereview.chromium.org/13392007/
757
758         Reviewed by Eric Seidel.
759
760         This script was trying to use "svn checkout" to dowload a file from
761         svn.webkit.org, but "svn checkout" only works with directories.
762         Instead, we should use "svn export".
763
764         * EWSTools/configure-svn-config.sh:
765
766 2013-03-31  Wei Jia  <wjia@chromium.org>
767
768         Allow WebUserMediaClientMock to be used by client
769         https://bugs.webkit.org/show_bug.cgi?id=113633
770
771         Reviewed by Adam Barth.
772
773         Export WebUserMediaClientMock.
774         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
775
776         * DumpRenderTree/DumpRenderTree.gypi:
777         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
778         (WebUserMediaClientMock):
779         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
780         * Scripts/webkitpy/style/checkers/cpp.py:
781         (check_function_definition):
782
783 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
784
785         Expose FeatureObserver data to WebKit clients
786         https://bugs.webkit.org/show_bug.cgi?id=113613
787
788         Reviewed by Sam Weinig.
789
790         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
791         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
792
793 2013-03-29  Greg Hughes  <ghughes@apple.com>
794
795         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
796         https://bugs.webkit.org/show_bug.cgi?id=112276
797
798         Reviewed by Chris Fleizach.
799
800         Added support to test accessibility search predicates with multiple keys.  
801
802         * DumpRenderTree/AccessibilityUIElement.cpp:
803         (uiElementForSearchPredicateCallback):
804         * DumpRenderTree/AccessibilityUIElement.h:
805         (AccessibilityUIElement):
806         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
807         (AccessibilityUIElement::uiElementForSearchPredicate):
808         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
809         (AccessibilityUIElement::uiElementForSearchPredicate):
810         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
811         (AccessibilityUIElement::uiElementForSearchPredicate):
812         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
813         (AccessibilityUIElement::uiElementForSearchPredicate):
814         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
815         (AccessibilityUIElement::uiElementForSearchPredicate):
816         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
817         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
818         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
819         (AccessibilityUIElement):
820         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
821         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
822         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
823         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
824         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
825
826 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
827
828         Fix a typo in r147147 to fix Mac EWS.
829
830         * Scripts/webkitpy/tool/commands/queues.py:
831         (PatchProcessingQueue._new_port_name_from_old):
832
833 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
834
835         [EFL] Build break with latest EFL libraries after r146265
836         https://bugs.webkit.org/show_bug.cgi?id=113558
837
838         Unreviewed build fix.
839
840         * TestWebKitAPI/PlatformWebView.h:
841         * WebKitTestRunner/PlatformWebView.h:
842
843 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
844
845         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
846
847         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
848         in libgcrypt build.
849
850 2013-03-28  Lucas Forschler  <lforschler@apple.com>
851
852         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
853
854         Unreviewed.
855
856         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
857         (MacEWS):
858
859 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
860
861         Use the right OS name on Mac EWS instead of mac-future.
862
863         Rubber-stamped by Dirk Pranke.
864
865         * Scripts/webkitpy/tool/commands/queues.py:
866         (PatchProcessingQueue._new_port_name_from_old):
867         (PatchProcessingQueue.begin_work_queue):
868         (PatchProcessingQueue._upload_results_archive_for_patch):
869
870 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
871
872         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
873         https://bugs.webkit.org/show_bug.cgi?id=112546
874
875         Reviewed by Martin Robinson.
876
877         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
878         moved back to Source/WebCore/platform. Fix an indentation issue as well.
879
880 2013-03-28  Ming Xie  <mxie@blackberry.com>
881
882         [BlackBerry] Committer Email Updates
883         https://bugs.webkit.org/show_bug.cgi?id=113435
884
885         Reviewed by Rob Buis.
886
887         Add the @blackberry.com email address for all our BlackBerry
888         WebKit committers. This is the first step for our email address
889         migration.
890
891         * Scripts/webkitpy/common/config/committers.py:
892
893 2013-03-28  Philippe Normand  <pnormand@igalia.com>
894
895         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
896         https://bugs.webkit.org/show_bug.cgi?id=113508
897
898         Reviewed by Martin Robinson.
899
900         Prevent the GStreamer plugin scanner to load system-wide
901         plugins. Only the ones built in JHBuild should be loaded and used
902         at runtime.
903
904         * efl/jhbuildrc:
905         * gtk/jhbuildrc:
906
907 2013-03-27  Philippe Normand  <pnormand@igalia.com>
908
909         [GTK] run-launcher --gtk -2 fails on a WK2-only build
910         https://bugs.webkit.org/show_bug.cgi?id=113386
911
912         Reviewed by Carlos Garcia Campos.
913
914         * Scripts/webkitdirs.pm:
915         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
916         version to 3.0. Reflect this change so the builtDylibPathForName
917         function doesn't fail to report the library as found.
918
919 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
920
921         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
922         https://bugs.webkit.org/show_bug.cgi?id=113484
923
924         Unreviewed build fix.
925
926         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
927
928         * TestWebKitAPI/CMakeLists.txt:
929         * WebKitTestRunner/CMakeLists.txt:
930
931 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
932
933         Revision for the internal jhbuild is too old
934         https://bugs.webkit.org/show_bug.cgi?id=113324
935
936         Reviewed by Martin Robinson.
937
938         Update the minimum required version to a point where jhbuild won't
939         fail installing packages when trying to remove a symlink to a directory.
940
941         * jhbuild/jhbuild-wrapper: Updated revision.
942
943 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
944
945         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
946         https://bugs.webkit.org/show_bug.cgi?id=113203
947
948         Reviewed by Philippe Normand.
949
950         We build our libsoup without GNOME support. gst-plugins-good does separate
951         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
952         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
953         build failures as the headers of those diverge. We do not use souphttpsrc, so
954         disable it when building gst-plugins-good.
955
956         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
957
958 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
959
960         Build fix after r146852. Please another reference to the Lion leaks builder.
961
962         * BuildSlaveSupport/build.webkit.org-config/config.json:
963
964 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
965
966         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
967         https://bugs.webkit.org/show_bug.cgi?id=113421
968
969         Reviewed by Dirk Pranke.
970
971         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
972         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
973         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
974         in the GTK-specific TestExpectations files.
975
976         To avoid this only enable the warnings only when not using WKTR.
977
978         * Scripts/webkitpy/layout_tests/port/gtk.py:
979         (GtkPort.warn_if_bug_missing_in_test_expectations):
980
981 2013-03-27  Antti Koivisto  <antti@apple.com>
982
983         Fix Zalan's email.
984
985         * Scripts/webkitpy/common/config/committers.py:
986
987 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
988
989         master.cfg cleanup
990         https://bugs.webkit.org/show_bug.cgi?id=113195
991
992         Reviewed by Ryosuke Niwa.
993
994         * BuildSlaveSupport/build.webkit.org-config/config.json:
995         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
996
997 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
998
999         master.cfg fine-tuning for Qt Mountain Lion Release bot
1000         https://bugs.webkit.org/show_bug.cgi?id=113191
1001
1002         Reviewed by Ryosuke Niwa.
1003
1004         * BuildSlaveSupport/build.webkit.org-config/config.json:
1005           - Rename the slave due to its location change.
1006           - Update the platform of the slave.
1007         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1008         (RunQtAPITests): Enable running WK2 API tests on Qt.
1009         (RunQtAPITests.start):
1010         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1011         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1012
1013 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1014
1015         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1016         https://bugs.webkit.org/show_bug.cgi?id=113403
1017
1018         Reviewed by Kenneth Rohde Christiansen.
1019
1020         As of Evas 1.7.5, when Wayland is detected on the system, support for
1021         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1022         The code, however, seems to depend on a few other flags which must be
1023         explicitly enabled.
1024
1025         If those additional GL-related options are passed, we end up
1026         having issues on the WebKit side, so disable Wayland support for
1027         now.
1028
1029         * efl/jhbuild.modules:
1030
1031 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1032
1033         Unreviewed, rolling out r146864.
1034         http://trac.webkit.org/changeset/146864
1035         https://bugs.webkit.org/show_bug.cgi?id=113391
1036
1037         causes crashes on Wk2 EFL release bot (Requested by drott on
1038         #webkit).
1039
1040         * Scripts/webkitperl/FeatureList.pm:
1041
1042 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1043
1044         [jhbuild] Correctly specify an alternate number of make jobs.
1045         https://bugs.webkit.org/show_bug.cgi?id=113396
1046
1047         Reviewed by Philippe Normand.
1048
1049         So far, we were using the `MAKEFLAGS' environment variable to pass the
1050         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1051         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1052
1053         We now behave more closely to the rest of the WebKit tools by first
1054         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1055         not set, just letting jhbuild itself figure out how many jobs to use.
1056
1057         * efl/jhbuildrc:
1058         * gtk/jhbuildrc:
1059
1060 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1061
1062         [Qt] Remove Qt specific WorkQueueItem definitions.
1063         https://bugs.webkit.org/show_bug.cgi?id=112891
1064
1065         This patch is preparation work for removing
1066         WorkQueue related code from TestRunnerQt and
1067         replacing it with generic TestRunner code.
1068
1069         Reviewed by Benjamin Poulain.
1070
1071         * DumpRenderTree/qt/TestRunnerQt.cpp:
1072         (TestRunnerQt::queueBackNavigation):
1073         (TestRunnerQt::queueForwardNavigation):
1074         (TestRunnerQt::queueLoadHTMLString):
1075         (TestRunnerQt::queueReload):
1076         (TestRunnerQt::queueLoadingScript):
1077         (TestRunnerQt::queueNonLoadingScript):
1078         (TestRunner::queueLoad):
1079         * DumpRenderTree/qt/TestRunnerQt.h:
1080         (TestRunnerQt):
1081         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1082         (LoadItem::invoke):
1083         (LoadHTMLStringItem::invoke):
1084         (LoadAlternateHTMLStringItem::invoke):
1085         (ReloadItem::invoke):
1086         (ScriptItem::invoke):
1087         (BackForwardItem::invoke):
1088         * DumpRenderTree/qt/WorkQueueItemQt.h:
1089         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1090         (LoadAlternateHTMLStringItem):
1091
1092 2013-03-26  Julie Parent  <jparent@chromium.org>
1093
1094         Flakiness dashboard: simplify logic around which tests to show.
1095         https://bugs.webkit.org/show_bug.cgi?id=113250
1096
1097         Reviewed by Ojan Vafai.
1098         
1099         The different filters for showing results are only used for layout
1100         tests, otherwise, we show everything.
1101         
1102         Change the defaults to false (what layout tests used), and only
1103         look at the values when viewing layout tests.
1104
1105         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1106         (htmlForTestsWithExpectationsButNoFailures):
1107         (shouldHideTest):
1108
1109 2013-03-26  Isaac Levy  <ilevy@google.com>
1110
1111         Update bots on test-results.appspot
1112         https://bugs.webkit.org/show_bug.cgi?id=113333
1113
1114         Reviewed by Ojan Vafai.
1115
1116         * TestResultServer/static-dashboards/builders.jsonp:
1117
1118 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1119
1120         Unreviewed GTK gardening.
1121
1122         * Scripts/run-gtk-tests:
1123         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1124
1125 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1126
1127         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1128         https://bugs.webkit.org/show_bug.cgi?id=113287
1129
1130         Reviewed by Jocelyn Turcotte.
1131
1132         * Scripts/run-qtwebkit-tests:
1133         (Options.__init__):
1134
1135 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1136
1137         [EFL] Enable IndexedDB by default
1138         https://bugs.webkit.org/show_bug.cgi?id=107248
1139
1140         Reviewed by Laszlo Gombos.
1141
1142         * Scripts/webkitperl/FeatureList.pm:
1143         Enable IndexedDB by default on EFL.
1144
1145 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1146
1147         Sheriffbot should explain rollout failures in a human readable form.
1148         https://bugs.webkit.org/show_bug.cgi?id=107092
1149
1150         Reviewed by Ryosuke Niwa.
1151
1152         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1153
1154         * Scripts/webkitpy/tool/bot/irc_command.py:
1155         (Rollout._check_diff_failure):
1156         (Rollout.execute):
1157         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1158         (IRCCommandTest.test_rollout):
1159
1160 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1161
1162         Unreviewed GTK gardening.
1163
1164         * Scripts/run-gtk-tests:
1165         (TestRunner): Skipping a failing unit test after r146518.
1166
1167 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1168
1169         Remove Lion leaks builder
1170         https://bugs.webkit.org/show_bug.cgi?id=113252
1171
1172         Reviewed by Andreas Kling.
1173
1174         Removed.
1175
1176         * BuildSlaveSupport/build.webkit.org-config/config.json:
1177
1178 2013-03-25  Kent Tamura  <tkent@chromium.org>
1179
1180         Rename ENABLE_INPUT_TYPE_DATETIME
1181         https://bugs.webkit.org/show_bug.cgi?id=113254
1182
1183         Reviewed by Kentaro Hara.
1184
1185         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1186         Actually I'd like to remove the code, but we shouldn't remove it yet
1187         because we shipped products with it on some platforms.
1188
1189         * Scripts/webkitperl/FeatureList.pm:
1190         * qmake/mkspecs/features/features.pri:
1191
1192 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1193
1194         Remove one more line that was intended to be removed in r146657.
1195
1196         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1197         (summarize_results):
1198
1199 2013-03-25  Roger Fong  <roger_fong@apple.com>
1200
1201         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1202         Re-enable WinEWS tests.
1203
1204         * Scripts/webkitpy/common/config/ports.py:
1205         (WinPort.run_bindings_tests_command):
1206         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1207         (WinEWS):
1208
1209 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1210
1211         Unreviewed, rolling out r146793.
1212         http://trac.webkit.org/changeset/146793
1213         https://bugs.webkit.org/show_bug.cgi?id=113248
1214
1215         Fix did not work (Requested by rfong on #webkit).
1216
1217         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1218         (WinEWS):
1219
1220 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1221
1222         REGRESSION(r146657): Test failures reported incorrectly
1223         https://bugs.webkit.org/show_bug.cgi?id=113223
1224
1225         Reviewed by Dirk Pranke.
1226
1227         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1228
1229         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1230         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1231
1232         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1233         (Manager.run):
1234
1235         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1236         (RunDetails.__init__):
1237         (summarize_results): Remove the line I intended to remove in r146657.
1238
1239         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1240         (logging_run): Return details instead of the exit code.
1241         (run_and_capture): Ditto.
1242
1243         (RunTest.test_full_results_html):
1244         (RunTest.test_hung_thread):
1245         (RunTest.test_no_tests_found):
1246         (RunTest.test_no_tests_found_2):
1247         (RunTest.test_repeat_each_iterations_num_tests):
1248         (RunTest.test_run_singly_actually_runs_tests):
1249         (RunTest.test_test_list):
1250         (RunTest.test_missing_and_unexpected_results):
1251         (RunTest.test_pixel_test_directories):
1252         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1253         (RunTest.test_crash_with_stderr):
1254         (RunTest.test_no_image_failure_with_image_diff):
1255         (RunTest.test_crash_log):
1256         (RunTest.test_exit_after_n_failures_upload):
1257         (RunTest.test_results_directory_absolute):
1258         (RunTest.test_results_directory_relative):
1259         (RunTest.test_retrying_and_flaky_tests):
1260         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1261         (RunTest.test_retrying_uses_retries_directory):
1262         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1263         (RunTest.test_output_diffs):
1264         (EndToEndTest.test_reftest_with_two_notrefs):
1265         (RebaselineTest.test_reset_results):
1266         (RebaselineTest.test_missing_results):
1267         (RebaselineTest.test_new_baseline):
1268
1269         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1270         (BuildBotPrinter.print_results):
1271         (BuildBotPrinter.print_unexpected_results):
1272         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1273         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1274
1275 2013-03-25  Julie Parent  <jparent@chromium.org>
1276
1277         Dashboard refactor: Move cross dashboard history related code into history.js.
1278         https://bugs.webkit.org/show_bug.cgi?id=113104
1279
1280         Reviewed by Ojan Vafai.
1281
1282         All functions relating to cross dashboard behavior move from being
1283         globals to methods on the history.History object. Names stay the same,
1284         except many are made private, ones that should have been constants now
1285         are, and the long standing TODO to change "currentState" to 
1286         dashboardSpecificState is done.
1287         
1288         We now create a global history object in dashboard_base, as an 
1289         intermediate measure.  Once the dashboard specific code is
1290         added to history, each DB will need to create its own, and this
1291         global will be eliminated.
1292         
1293         * TestResultServer/static-dashboards/aggregate_results.js:
1294         (handleValidHashParameter):
1295         (htmlForBuilder):
1296         (rawValuesHTML):
1297         * TestResultServer/static-dashboards/dashboard_base.js:
1298         (parseDashboardSpecificParameters):
1299         (defaultValue):
1300         (currentBuilderGroupCategory):
1301         (currentBuilderGroupName):
1302         (handleLocationChange):
1303         (expectationsMap):
1304         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1305         (generatePage):
1306         (.switch.return):
1307         (platformAndBuildType):
1308         (individualTests):
1309         (substringList):
1310         (processMissingAndExtraExpectations):
1311         (pathToFailureLog):
1312         (showPopupForBuild):
1313         (htmlForTestsWithExpectationsButNoFailures):
1314         (shouldHideTest):
1315         (isCrossBuilderView):
1316         (tableHeaders):
1317         (htmlForSingleTestRow):
1318         (htmlForTableColumnHeader):
1319         (generatePageForExpectationsUpdate):
1320         (handleUpdate):
1321         (nextUpdate):
1322         (setUpdateIndex):
1323         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1324         (.appendExpectationsItem):
1325         (loadExpectations):
1326         (.dummyNode.onload):
1327         (loadExpectationsLayoutTests):
1328         (appendExpectations):
1329         (htmlForNavBar):
1330         (checkBoxToToggleState):
1331         (linkHTMLToToggleState):
1332         (generatePageForBuilder):
1333         (isInvalidKeyForCrossBuilderView):
1334         (handleQueryParameterChange):
1335         (showLegend):
1336         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1337         (resetGlobals):
1338         (test):
1339         * TestResultServer/static-dashboards/history.js:
1340         (.):
1341         * TestResultServer/static-dashboards/history_unittests.js:
1342         * TestResultServer/static-dashboards/loader.js:
1343         (.):
1344         * TestResultServer/static-dashboards/loader_unittests.js:
1345         * TestResultServer/static-dashboards/timeline_explorer.js:
1346         (generatePage):
1347         (initCurrentBuilderTestResults):
1348         (selectBuild):
1349         (showResultsDelta):
1350         * TestResultServer/static-dashboards/treemap.js:
1351         (generatePage):
1352         (.switch.return):
1353         (handleFocus):
1354         * TestResultServer/static-dashboards/ui.js:
1355
1356 2013-03-25  Roger Fong  <roger_fong@apple.com>
1357
1358         Unreviewed. Enable WinEWS tests again.
1359
1360         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1361         (WinEWS):
1362
1363 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1364
1365         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1366         https://bugs.webkit.org/show_bug.cgi?id=112166
1367
1368         HarfBuzz 0.9.14 merged my patch for icu detection without
1369         pkg-config files, as needed by for example Ubuntu 12.04.
1370         This obsoletes our local workaround. Removed it for GTK and EFL.
1371
1372         Reviewed by Martin Robinson.
1373
1374         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1375         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1376         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1377         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1378
1379 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1380
1381         Unreviewed.  Move self from contributor to committer list.
1382
1383         * Scripts/webkitpy/common/config/committers.py:
1384
1385 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1386
1387         EWS should use a human readable port name when uploading layout test archives
1388         https://bugs.webkit.org/show_bug.cgi?id=113099
1389
1390         Reviewed by Dirk Pranke.
1391
1392         Use new port's object's name() method to report human readable port names.
1393         This will also help us resolving the bug to apply layout test results posted by EWS.
1394
1395         * Scripts/webkitpy/tool/bot/botinfo.py:
1396         (BotInfo.__init__): Take port's name.
1397         (BotInfo.summary_text):
1398
1399         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1400         (BotInfoTest.test_summary_text):
1401
1402         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1403         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1404
1405         * Scripts/webkitpy/tool/commands/queues.py:
1406         (PatchProcessingQueue.__init__): Initialize self._port.
1407         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1408         and use that for the attachment filename and the comment posted.
1409
1410         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1411         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1412         "mac-snowleopard" as expected for TestPort.
1413
1414 2013-03-22  Roger Fong  <roger_fong@apple.com>
1415
1416         Unreviewed. Turn off EWS test on Win again.
1417         The battle continues.
1418
1419         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1420         (WinEWS):
1421
1422 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1423
1424         NRWT: Enable pixel tests when retrying tests
1425         https://bugs.webkit.org/show_bug.cgi?id=112898
1426
1427         Reviewed by Dirk Pranke.
1428
1429         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1430         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1431         if we've forced pixel tests in the retry.
1432         (Manager._run_tests):
1433         (Manager._clean_up_run): Fixed the capitalizations.
1434         (Manager._force_pixel_tests_if_needed): Added.
1435
1436         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1437         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1438         'image_diff_percent' if it doesn't already exist.
1439
1440         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1441         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1442         treat this as a regular regression instead of a flakiness.
1443
1444         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1445         run had image diffs.
1446
1447         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1448         (summarized_results):
1449
1450         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1451         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1452         Also removed some dead code.
1453
1454         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1455         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1456         is set and pixel_tests_enabled is set to false.
1457         (EndToEndTest.test_reftest_with_two_notrefs):
1458
1459 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1460
1461         Make it possible to run layout tests on Retina MBP
1462         https://bugs.webkit.org/show_bug.cgi?id=93673
1463
1464         Reviewed by Ryosuke Niwa.
1465
1466         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1467         windows on 2x machines still run at 1x.
1468
1469         * DumpRenderTree/mac/DumpRenderTree.mm:
1470         (createWebViewAndOffscreenWindow):
1471         Reset the window resolution to 1x on creation.
1472         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
1473         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1474         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
1475         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1476         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
1477         (WTR::PlatformWebView::PlatformWebView):
1478         Add NSWindow details, reset the window resolution to 1x on creation.
1479
1480 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1481
1482         Leak bots shouldn't build
1483         https://bugs.webkit.org/show_bug.cgi?id=112774
1484
1485         Reviewed by Simon Fraser.
1486
1487         Since leak bots use regular debug builds, there is no need to build on these bots.
1488         Simply downloading builds will dramatically improve the cycle time of these bots.
1489
1490         * BuildSlaveSupport/build.webkit.org-config/config.json:
1491         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1492         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
1493         TestFactory instead of BuildAndTestFactory.
1494
1495 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1496
1497         [Qt] Fix the TestWebKitAPI build
1498         https://bugs.webkit.org/show_bug.cgi?id=113044
1499
1500         Reviewed by Tor Arne Vestbø.
1501
1502         The generate-forwarding-headers script would only be run
1503         after the targets in InjectedBundle.pri since the second
1504         addStrictSubdirOrderBetween call in
1505         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
1506         the derived_sources -> injected_bundle order in SUBDIRS.
1507
1508         Fix it by only moving the dependent target at the end of
1509         SUBDIRS, don't touch its dependency.
1510
1511         * qmake/mkspecs/features/functions.prf:
1512
1513 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1514
1515         [EFL][WK2] View is not focused when fullscreen mode toggled
1516         https://bugs.webkit.org/show_bug.cgi?id=113009
1517
1518         Reviewed by Laszlo Gombos.
1519
1520         Set focus on view when fullscreen mode enabled/disabled
1521         by FullScreen API.
1522
1523         * MiniBrowser/efl/main.c:
1524         (on_fullscreen_accept):
1525         (on_fullscreen_deny):
1526
1527 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1528
1529         nrwt is no longer saving retry results in the retries/ subdirectory
1530         https://bugs.webkit.org/show_bug.cgi?id=112995
1531
1532         Reviewed by Ojan Vafai.
1533
1534         I think this has been broken a long time, unfortunately. This
1535         patch should fix that.
1536
1537         In order to do so, I had to pass the directory to use from
1538         the Worker object through the SingleTestWriter to the
1539         TestResultWriter. While I was plumbing that through, I rationalized
1540         the order of the parameter arguments a bit ...
1541
1542         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1543         (Worker._run_single_test):
1544         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1545         (run_single_test):
1546         (SingleTestRunner.__init__):
1547         (SingleTestRunner._run_compare_test):
1548         (SingleTestRunner._run_rebaseline):
1549         (SingleTestRunner._run_reftest):
1550         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1551         (write_test_result):
1552         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1553         (TestResultWriterTest.test_reftest_diff_image):
1554         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1555         (RunTest.test_retrying_uses_retries_directory):
1556
1557 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
1558
1559         JSC profiler should have an at-a-glance report of the success of DFG optimization
1560         https://bugs.webkit.org/show_bug.cgi?id=112988
1561
1562         Reviewed by Geoffrey Garen.
1563
1564         * Scripts/display-profiler-output:
1565
1566 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1567
1568         [chromium] Linux ASAN WebKit canary is running out of memory
1569         https://bugs.webkit.org/show_bug.cgi?id=112978
1570
1571         Reviewed by Tony Chang.
1572
1573         Running the AddressSanitizer on a crash takes a lot of
1574         memory, so we should serialize access to it to avoid running
1575         out of memory on a machine.
1576
1577         * Scripts/webkitpy/layout_tests/port/chromium.py:
1578         (ChromiumPort._get_crash_log):
1579         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1580         (HttpLock.__init__):
1581         (HttpLock.wait_for_httpd_lock):
1582
1583 2013-03-21  Min Qin  <qinmin@chromium.org>
1584
1585         Cleanup android media layout test code
1586         https://bugs.webkit.org/show_bug.cgi?id=112944
1587
1588         Reviewed by Adam Barth.
1589
1590         Chromium change: https://codereview.chromium.org/12892010/
1591         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
1592         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
1593         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
1594         Instead, we should switch to use content shell for layout tests.
1595
1596         * DumpRenderTree/chromium/TestShell.cpp:
1597         (TestShell::resetTestController):
1598
1599 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1600
1601         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
1602         https://bugs.webkit.org/show_bug.cgi?id=112953
1603
1604         Reviewed by Tony Chang.
1605
1606         When I created the DumpRenderTree_resources target in r144863 I
1607         forgot to declare the needed dependencies on the other resource
1608         targets. Due to a quirk of ordering, this appears to have been fine
1609         w/ ninja but not w/ Xcode (which is still being used on the chromium
1610         mac valgrind bots). Declaring the dependencies fixes the build
1611         failures.
1612
1613         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1614
1615 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
1616
1617         [WinCairo] Correct assert in Empty BitmapImage Test.
1618         https://bugs.webkit.org/show_bug.cgi?id=112934
1619
1620         Reviewed by Tim Horton.
1621
1622         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1623         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
1624         to avoid ref counting assertion when leaving test scope.
1625
1626 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
1627
1628         [GTK] generate-feature-defines-files is incompatible with Python3
1629         https://bugs.webkit.org/show_bug.cgi?id=112956
1630
1631         Reviewed by Martin Robinson.
1632
1633         Make the generate-feature-defines-files compatible with Python3 by calling the items()
1634         method on the dictionary objects when iterating through said dictionaries.
1635
1636         * gtk/generate-feature-defines-files:
1637         (write_feature_defines_header):
1638         (write_flattened_feature_defines_file):
1639
1640 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1641
1642         kill-old-processes spits out error messages on Mac
1643         https://bugs.webkit.org/show_bug.cgi?id=112878
1644
1645         Reviewed by Jessie Berlin.
1646
1647         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
1648         included in the list of options grep --help shows.
1649
1650         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
1651
1652         * BuildSlaveSupport/kill-old-processes:
1653         (main):
1654
1655 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
1656
1657         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
1658         https://bugs.webkit.org/show_bug.cgi?id=112597
1659
1660         Reviewed by Xan Lopez.
1661
1662         These were introduced for the Chromium port in r105295. We need
1663         dummy implementations in order to compile the BlackBerry port.
1664
1665         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1666         (AccessibilityUIElement::scrollToMakeVisible):
1667         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1668         (AccessibilityUIElement::scrollToGlobalPoint):
1669
1670 2013-03-21  Roger Fong  <roger_fong@apple.com>
1671
1672         Re-enable WinEWS tests following r146376.
1673
1674         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1675         (WinEWS):
1676
1677 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
1678
1679         Unreviewed. Add Bem Jones-Bey to the list of contributors.
1680
1681         * Scripts/webkitpy/common/config/committers.py:
1682
1683 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1684
1685         [GTK] Missing atk in install-dependencies script
1686         https://bugs.webkit.org/show_bug.cgi?id=112272
1687
1688         Reviewed by Gustavo Noronha Silva.
1689
1690         * gtk/install-dependencies: Add missing atk dependency.
1691
1692 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1693
1694         [GTK] Missing backslash in install-dependencies script
1695         https://bugs.webkit.org/show_bug.cgi?id=112907
1696
1697         Reviewed by Philippe Normand.
1698
1699         * gtk/install-dependencies: Add missing backslash to dependencies
1700         list.
1701
1702 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1703
1704         EWS bots have stopped uploading results to bugzilla
1705         https://bugs.webkit.org/show_bug.cgi?id=101091
1706
1707         Reviewed by Adam Barth.
1708
1709         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
1710         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
1711         this relative file path resoled to a file inside a non-existent directory for "zip".
1712
1713         Fixed the bug by resolving both test results directory and zip archive paths in
1714         LayoutTestResultsReader.archive.
1715
1716         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
1717         in the future.
1718
1719         * Scripts/webkitpy/common/system/filesystem_mock.py:
1720         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
1721
1722         * Scripts/webkitpy/common/system/workspace.py:
1723         (Workspace.create_zip): Log the source path when "zip" failed.
1724
1725         * Scripts/webkitpy/common/system/workspace_mock.py:
1726         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
1727
1728         * Scripts/webkitpy/common/system/workspace_unittest.py:
1729         (WorkspaceTest.test_create_zip_exception): Test that.
1730
1731         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1732         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
1733         This is the actual bug fix.
1734
1735         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1736         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
1737
1738 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
1739
1740         [chromium] move WebThemeEngine implementations to TestRunner library
1741         https://bugs.webkit.org/show_bug.cgi?id=112751
1742
1743         Reviewed by Adam Barth.
1744
1745         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1746         * DumpRenderTree/DumpRenderTree.gypi:
1747         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1748         (WebKit):
1749         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1750         (WebTestRunner::TestInterfaces::themeEngine):
1751         (WebTestRunner):
1752         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1753         (WebKit):
1754         (TestInterfaces):
1755         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1756         (WebTestRunner::WebTestInterfaces::themeEngine):
1757         (WebTestRunner):
1758         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1759         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1760         (WebTestRunner):
1761         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1762         (WebTestRunner::WebTestThemeControlWin::box):
1763         (WebTestRunner::WebTestThemeControlWin::line):
1764         (WebTestRunner::WebTestThemeControlWin::triangle):
1765         (WebTestRunner::WebTestThemeControlWin::roundRect):
1766         (WebTestRunner::WebTestThemeControlWin::oval):
1767         (WebTestRunner::WebTestThemeControlWin::circle):
1768         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1769         (WebTestRunner::WebTestThemeControlWin::markState):
1770         (WebTestRunner::WebTestThemeControlWin::draw):
1771         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1772         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1773         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1774         (WebTestRunner):
1775         (WebTestThemeControlWin):
1776         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1777         (WebTestRunner):
1778         (WebTestThemeEngineMac):
1779         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1780         (+[FakeActiveWindow alwaysActiveWindow]):
1781         (+[FakeActiveWindow alwaysInactiveWindow]):
1782         (-[FakeActiveWindow initWithActiveControls:]):
1783         (-[FakeActiveWindow _hasActiveControls]):
1784         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1785         (WebTestRunner):
1786         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1787         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1788         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1789         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1790         (WebTestRunner):
1791         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1792         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1793         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1794         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1795         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1796         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1797         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1798         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1799         (WebTestRunner::WebTestThemeEngineWin::getSize):
1800         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1801         (WebTestRunner):
1802         (WebTestThemeEngineWin):
1803         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1804         * DumpRenderTree/chromium/TestShell.cpp:
1805         (TestShell::initialize):
1806         * DumpRenderTree/chromium/TestShell.h:
1807         (WebKit):
1808         * DumpRenderTree/chromium/TestShellMac.mm:
1809         (platformInit):
1810         * DumpRenderTree/chromium/TestShellWin.cpp:
1811         (platformInit):
1812         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1813
1814 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1815
1816         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
1817
1818         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
1819         New property sheet that does not link against CoreFoundation and
1820         CFNetwork.
1821         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1822         Use new TestWebKitAPICommonWinCairo property sheet.
1823         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1824         Ditto.
1825
1826 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1827
1828         [WinCairo] Unreviewed build fix for VS2010.
1829
1830         Had to add WinCairo-specific property sheets to deal with some
1831         library and path differences with the main Apple port.
1832
1833         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1834         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1835         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1836         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
1837         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
1838         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
1839
1840 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
1841
1842         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
1843         https://bugs.webkit.org/show_bug.cgi?id=112849
1844
1845         Reviewed by Sam Weinig.
1846
1847         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1848         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1849         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1850
1851 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1852
1853         [WinCairo] Build WebKit Tools under VS2010
1854         https://bugs.webkit.org/show_bug.cgi?id=112821
1855
1856         Reviewed by Tim Horton.
1857
1858         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1859         Add WinCairo-specific build target.
1860         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
1861         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
1862         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
1863         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
1864         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1865         Add WinCairo-specific build target.
1866         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1867         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1868         Add WinCairo-specific build target.
1869         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
1870         WinCairo-specific build target.
1871         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
1872         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
1873         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
1874         specific build target.
1875         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
1876         WinCairo-specific build target.
1877         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
1878         * win/record-memory/record-memoryDebugWinCairo.props: Added.
1879         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
1880
1881 2013-03-20  Roger Fong  <roger_fong@apple.com>
1882
1883         API test gardening AppleWin port.
1884
1885         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
1886
1887         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1888         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1889
1890 2013-03-20  Roger Fong  <roger_fong@apple.com>
1891
1892         Test fix for Win EWS bots, catch various errors and restart script if necessary.
1893
1894         * EWSTools/start-queue-win.sh:
1895
1896 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
1897
1898         Unreviewed, add myself to committers.py.
1899
1900 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1901
1902         Unreviewed. Adding another email for me.
1903
1904         * Scripts/webkitpy/common/config/committers.py:
1905
1906 2013-03-20  Justin Novosad  <junov@google.com>
1907
1908         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
1909         https://bugs.webkit.org/show_bug.cgi?id=112605
1910
1911         Reviewed by James Robinson.
1912
1913         Deleting all the code that was used for propagating and supporting
1914         the Chromium setting for disabling deferred 2d canvas rendering.
1915
1916         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1917         (main):
1918         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1919         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1920         (WebTestRunner::WebPreferences::reset):
1921         (WebTestRunner::WebPreferences::applyTo):
1922         * DumpRenderTree/chromium/TestShell.cpp:
1923         (TestShell::TestShell):
1924         (TestShell::resetWebSettings):
1925         (TestShell::runFileTest):
1926         * DumpRenderTree/chromium/TestShell.h:
1927         (TestShell):
1928
1929 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
1930
1931         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
1932         https://bugs.webkit.org/show_bug.cgi?id=112699.
1933
1934         Reviewed by Adam Barth.
1935
1936         * Scripts/webkitpy/layout_tests/port/qt.py:
1937         (QtPort._search_paths):
1938         (QtPort._port_specific_expectations_files):
1939         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1940         (QtPortTest):
1941         (QtPortTest._assert_search_path):
1942         (QtPortTest._assert_expectations_files):
1943
1944 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1945
1946         [Qt] Enable kerning by default
1947         https://bugs.webkit.org/show_bug.cgi?id=112704
1948
1949         Reviewed by Jocelyn Turcotte.
1950
1951         Disable kerning by default, since some reference test expectations
1952         expect kerning to be default off.
1953
1954         * DumpRenderTree/qt/TestRunnerQt.cpp:
1955         (TestRunnerQt::reset):
1956         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1957         (WTR::activateFonts):
1958
1959 2013-03-20  Zeno Albisser  <zeno@webkit.org>
1960
1961         [Qt] Remove empty function stubs from TestRunnerQt.
1962         https://bugs.webkit.org/show_bug.cgi?id=112799
1963
1964         We are reducing the code in TestRunnerQt step by step,
1965         in order to finally replace all of it with the generic
1966         TestRunner implementation.
1967         This patch removes several simple function stubs that
1968         currently do not implement any actual functionality.
1969
1970         Reviewed by Kenneth Rohde Christiansen.
1971
1972         * DumpRenderTree/qt/TestRunnerQt.cpp:
1973         * DumpRenderTree/qt/TestRunnerQt.h:
1974         (TestRunnerQt):
1975
1976 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1977
1978         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
1979         https://bugs.webkit.org/show_bug.cgi?id=112687
1980
1981         Reviewed by Kenneth Rohde Christiansen.
1982
1983         Hide the SearchBar by default on window creation.
1984
1985         * MiniBrowser/efl/main.c:
1986         (window_create):
1987
1988 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1989
1990         Unreviewed, rolling out r146304.
1991         http://trac.webkit.org/changeset/146304
1992         https://bugs.webkit.org/show_bug.cgi?id=112788
1993
1994         to many expectations to update (Requested by antonm on
1995         #webkit).
1996
1997         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1998         * DumpRenderTree/DumpRenderTree.gypi:
1999         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2000         (WebKit):
2001         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2002         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2003         (TestInterfaces):
2004         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2005         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2006         * DumpRenderTree/chromium/TestShell.cpp:
2007         (TestShell::initialize):
2008         * DumpRenderTree/chromium/TestShell.h:
2009         (WebKit):
2010         * DumpRenderTree/chromium/TestShellMac.mm:
2011         (platformInit):
2012         * DumpRenderTree/chromium/TestShellWin.cpp:
2013         (platformInit):
2014         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2015         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2016         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2017         (WebThemeControlDRTWin::box):
2018         (WebThemeControlDRTWin::line):
2019         (WebThemeControlDRTWin::triangle):
2020         (WebThemeControlDRTWin::roundRect):
2021         (WebThemeControlDRTWin::oval):
2022         (WebThemeControlDRTWin::circle):
2023         (WebThemeControlDRTWin::nestedBoxes):
2024         (WebThemeControlDRTWin::markState):
2025         (WebThemeControlDRTWin::draw):
2026         (WebThemeControlDRTWin::drawTextField):
2027         (WebThemeControlDRTWin::drawProgressBar):
2028         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2029         (WebThemeControlDRTWin):
2030         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2031         (WebThemeEngineDRTMac):
2032         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2033         (+[FakeActiveWindow alwaysActiveWindow]):
2034         (+[FakeActiveWindow alwaysInactiveWindow]):
2035         (-[FakeActiveWindow initWithActiveControls:]):
2036         (-[FakeActiveWindow _hasActiveControls]):
2037         (WebThemeEngineDRTMac::paintScrollbarThumb):
2038         (stateToHIEnableState):
2039         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2040         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2041         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2042         (webRectToSkIRect):
2043         (drawControl):
2044         (drawTextField):
2045         (drawProgressBar):
2046         (WebThemeEngineDRTWin::paintButton):
2047         (WebThemeEngineDRTWin::paintMenuList):
2048         (WebThemeEngineDRTWin::paintScrollbarArrow):
2049         (WebThemeEngineDRTWin::paintScrollbarThumb):
2050         (WebThemeEngineDRTWin::paintScrollbarTrack):
2051         (WebThemeEngineDRTWin::paintSpinButton):
2052         (WebThemeEngineDRTWin::paintTextField):
2053         (WebThemeEngineDRTWin::paintTrackbar):
2054         (WebThemeEngineDRTWin::paintProgressBar):
2055         (WebThemeEngineDRTWin::getSize):
2056         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2057         (WebThemeEngineDRTWin):
2058         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2059
2060 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2061
2062         [Qt] Support -webkit-font-smoothing
2063         https://bugs.webkit.org/show_bug.cgi?id=106009
2064
2065         Reviewed by Jocelyn Turcotte.
2066
2067         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2068
2069         * DumpRenderTree/qt/TestRunnerQt.cpp:
2070         (TestRunnerQt::reset):
2071
2072 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2073
2074         [GTK] accessibility/aria-scrollbar-role.html is failing
2075         https://bugs.webkit.org/show_bug.cgi?id=98358
2076
2077         Reviewed by Martin Robinson.
2078
2079         Adds support for checking accessibility object's orientation.
2080         Orientation is checked by retrieving proper state of accessibility object.
2081
2082         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2083         (checkElementState):
2084         (AccessibilityUIElement::orientation):
2085         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2086         (WTR::AccessibilityUIElement::orientation):
2087
2088 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2089
2090         [chromium] move WebThemeEngine implementations to TestRunner library
2091         https://bugs.webkit.org/show_bug.cgi?id=112751
2092
2093         Reviewed by Adam Barth.
2094
2095         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2096         * DumpRenderTree/DumpRenderTree.gypi:
2097         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2098         (WebKit):
2099         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2100         (WebTestRunner::TestInterfaces::themeEngine):
2101         (WebTestRunner):
2102         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2103         (WebKit):
2104         (TestInterfaces):
2105         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2106         (WebTestRunner::WebTestInterfaces::themeEngine):
2107         (WebTestRunner):
2108         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2109         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2110         (WebTestRunner):
2111         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2112         (WebTestRunner::WebTestThemeControlWin::box):
2113         (WebTestRunner::WebTestThemeControlWin::line):
2114         (WebTestRunner::WebTestThemeControlWin::triangle):
2115         (WebTestRunner::WebTestThemeControlWin::roundRect):
2116         (WebTestRunner::WebTestThemeControlWin::oval):
2117         (WebTestRunner::WebTestThemeControlWin::circle):
2118         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2119         (WebTestRunner::WebTestThemeControlWin::markState):
2120         (WebTestRunner::WebTestThemeControlWin::draw):
2121         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2122         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2123         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2124         (WebTestRunner):
2125         (WebTestThemeControlWin):
2126         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2127         (WebTestRunner):
2128         (WebTestThemeEngineMac):
2129         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2130         (+[FakeActiveWindow alwaysActiveWindow]):
2131         (+[FakeActiveWindow alwaysInactiveWindow]):
2132         (-[FakeActiveWindow initWithActiveControls:]):
2133         (-[FakeActiveWindow _hasActiveControls]):
2134         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2135         (WebTestRunner):
2136         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2137         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2138         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2139         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2140         (WebTestRunner):
2141         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2142         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2143         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2144         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2145         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2146         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2147         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2148         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2149         (WebTestRunner::WebTestThemeEngineWin::getSize):
2150         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2151         (WebTestRunner):
2152         (WebTestThemeEngineWin):
2153         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2154         * DumpRenderTree/chromium/TestShell.cpp:
2155         (TestShell::initialize):
2156         * DumpRenderTree/chromium/TestShell.h:
2157         (WebKit):
2158         * DumpRenderTree/chromium/TestShellMac.mm:
2159         (platformInit):
2160         * DumpRenderTree/chromium/TestShellWin.cpp:
2161         (platformInit):
2162         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2163
2164 2013-03-19  Tony Chang  <tony@chromium.org>
2165
2166         Move testRunner.setTouchDragDropEnabled to internals.settings
2167         https://bugs.webkit.org/show_bug.cgi?id=112739
2168
2169         Reviewed by Adam Barth.
2170
2171         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2172         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2173         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2174         (TestRunner): Remove unnecessary code.
2175         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2176         (WebTestRunner::WebPreferences::reset):
2177         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2178
2179 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2180
2181         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2182         https://bugs.webkit.org/show_bug.cgi?id=112754
2183
2184         Reviewed by Darin Fisher.
2185
2186         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2187         now that it's always defined.
2188
2189         * DumpRenderTree/chromium/WebViewHost.cpp:
2190         * DumpRenderTree/chromium/WebViewHost.h:
2191         (WebViewHost):
2192
2193 2013-03-19  Kenneth Russell  <kbr@google.com>
2194
2195         Unreviewed, rolling out r146290.
2196         http://trac.webkit.org/changeset/146290
2197         https://bugs.webkit.org/show_bug.cgi?id=112751
2198
2199         Broke Chromium Mac build.
2200
2201         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2202         * DumpRenderTree/DumpRenderTree.gypi:
2203         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2204         (WebKit):
2205         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2206         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2207         (TestInterfaces):
2208         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2209         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2210         * DumpRenderTree/chromium/TestShell.cpp:
2211         (TestShell::initialize):
2212         * DumpRenderTree/chromium/TestShell.h:
2213         (WebKit):
2214         * DumpRenderTree/chromium/TestShellMac.mm:
2215         (platformInit):
2216         * DumpRenderTree/chromium/TestShellWin.cpp:
2217         (platformInit):
2218         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2219         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2220         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2221         (WebThemeControlDRTWin::box):
2222         (WebThemeControlDRTWin::line):
2223         (WebThemeControlDRTWin::triangle):
2224         (WebThemeControlDRTWin::roundRect):
2225         (WebThemeControlDRTWin::oval):
2226         (WebThemeControlDRTWin::circle):
2227         (WebThemeControlDRTWin::nestedBoxes):
2228         (WebThemeControlDRTWin::markState):
2229         (WebThemeControlDRTWin::draw):
2230         (WebThemeControlDRTWin::drawTextField):
2231         (WebThemeControlDRTWin::drawProgressBar):
2232         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2233         (WebThemeControlDRTWin):
2234         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2235         (WebThemeEngineDRTMac):
2236         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2237         (+[FakeActiveWindow alwaysActiveWindow]):
2238         (+[FakeActiveWindow alwaysInactiveWindow]):
2239         (-[FakeActiveWindow initWithActiveControls:]):
2240         (-[FakeActiveWindow _hasActiveControls]):
2241         (WebThemeEngineDRTMac::paintScrollbarThumb):
2242         (stateToHIEnableState):
2243         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2244         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2245         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2246         (webRectToSkIRect):
2247         (drawControl):
2248         (drawTextField):
2249         (drawProgressBar):
2250         (WebThemeEngineDRTWin::paintButton):
2251         (WebThemeEngineDRTWin::paintMenuList):
2252         (WebThemeEngineDRTWin::paintScrollbarArrow):
2253         (WebThemeEngineDRTWin::paintScrollbarThumb):
2254         (WebThemeEngineDRTWin::paintScrollbarTrack):
2255         (WebThemeEngineDRTWin::paintSpinButton):
2256         (WebThemeEngineDRTWin::paintTextField):
2257         (WebThemeEngineDRTWin::paintTrackbar):
2258         (WebThemeEngineDRTWin::paintProgressBar):
2259         (WebThemeEngineDRTWin::getSize):
2260         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2261         (WebThemeEngineDRTWin):
2262         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2263
2264 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2265
2266         [EFL] canvas-fallback-content.html is failing
2267         https://bugs.webkit.org/show_bug.cgi?id=111998
2268
2269         Reviewed by Chris Fleizach.
2270
2271         Adds support for getting platform name.
2272
2273         * DumpRenderTree/TestRunner.cpp:
2274         (TestRunner::staticValues):
2275         * DumpRenderTree/TestRunner.h:
2276         (TestRunner):
2277         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2278         (TestRunner::platformName):
2279
2280 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2281
2282         [chromium] move WebThemeEngine implementations to TestRunner library
2283         https://bugs.webkit.org/show_bug.cgi?id=112751
2284
2285         Reviewed by Adam Barth.
2286
2287         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2288         * DumpRenderTree/DumpRenderTree.gypi:
2289         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2290         (WebKit):
2291         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2292         (WebTestRunner::TestInterfaces::themeEngine):
2293         (WebTestRunner):
2294         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2295         (WebKit):
2296         (TestInterfaces):
2297         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2298         (WebTestRunner::WebTestInterfaces::themeEngine):
2299         (WebTestRunner):
2300         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2301         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2302         (WebTestRunner):
2303         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2304         (WebTestRunner::WebTestThemeControlWin::box):
2305         (WebTestRunner::WebTestThemeControlWin::line):
2306         (WebTestRunner::WebTestThemeControlWin::triangle):
2307         (WebTestRunner::WebTestThemeControlWin::roundRect):
2308         (WebTestRunner::WebTestThemeControlWin::oval):
2309         (WebTestRunner::WebTestThemeControlWin::circle):
2310         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2311         (WebTestRunner::WebTestThemeControlWin::markState):
2312         (WebTestRunner::WebTestThemeControlWin::draw):
2313         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2314         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2315         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2316         (WebTestRunner):
2317         (WebTestThemeControlWin):
2318         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2319         (WebTestRunner):
2320         (WebTestThemeEngineMac):
2321         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2322         (+[FakeActiveWindow alwaysActiveWindow]):
2323         (+[FakeActiveWindow alwaysInactiveWindow]):
2324         (-[FakeActiveWindow initWithActiveControls:]):
2325         (-[FakeActiveWindow _hasActiveControls]):
2326         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2327         (WebTestRunner):
2328         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2329         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2330         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2331         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2332         (WebTestRunner):
2333         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2334         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2335         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2336         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2337         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2338         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2339         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2340         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2341         (WebTestRunner::WebTestThemeEngineWin::getSize):
2342         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2343         (WebTestRunner):
2344         (WebTestThemeEngineWin):
2345         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2346         * DumpRenderTree/chromium/TestShell.cpp:
2347         (TestShell::initialize):
2348         * DumpRenderTree/chromium/TestShell.h:
2349         (WebKit):
2350         * DumpRenderTree/chromium/TestShellMac.mm:
2351         (platformInit):
2352         * DumpRenderTree/chromium/TestShellWin.cpp:
2353         (platformInit):
2354         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2355
2356 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2357
2358         [EFL][WK2] Separate WebView further from EwkView
2359         https://bugs.webkit.org/show_bug.cgi?id=111591
2360
2361         Reviewed by Caio Marcelo de Oliveira Filho.
2362
2363         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2364         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2365         since we can afford it having EWKViewGetWKView() private API to access WKView.
2366
2367         * TestWebKitAPI/PlatformWebView.h:
2368         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2369         (TestWebKitAPI::TEST):
2370         * TestWebKitAPI/efl/PlatformWebView.cpp:
2371         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2372         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2373         (TestWebKitAPI::PlatformWebView::resizeTo):
2374         (TestWebKitAPI::PlatformWebView::page):
2375         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2376         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2377         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2378         * WebKitTestRunner/PlatformWebView.h:
2379         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2380         (WTR::EventSenderProxy::dispatchEvent):
2381         (WTR::EventSenderProxy::keyDown):
2382         (WTR::EventSenderProxy::sendTouchEvent):
2383         (WTR::EventSenderProxy::setTouchModifier):
2384         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2385         (WTR::PlatformWebView::PlatformWebView):
2386         (WTR::PlatformWebView::~PlatformWebView):
2387         (WTR::PlatformWebView::resizeTo):
2388         (WTR::PlatformWebView::page):
2389         (WTR::PlatformWebView::focus):
2390         (WTR::PlatformWebView::windowSnapshotImage):
2391
2392 2013-03-19  Roger Fong  <roger_fong@apple.com>
2393
2394         Changes to VS2010 project files should only trigger builds on Windows bots.
2395         https://bugs.webkit.org/show_bug.cgi?id=112731
2396
2397         Reviewed by Timothy Horton.
2398
2399         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2400         (_should_file_trigger_build):
2401
2402 2013-03-19  Roger Fong  <roger_fong@apple.com>
2403
2404         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2405
2406         * Scripts/webkitpy/tool/steps/runtests.py:
2407         (RunTests.run):
2408         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2409         (RunTestsTest.test_webkit_run_unit_tests):
2410
2411 2013-03-19  Julie Parent  <jparent@chromium.org>
2412
2413         Dashboards: Introduce history namespace and unit tests.
2414         https://bugs.webkit.org/show_bug.cgi?id=112645
2415
2416         Reviewed by Ojan Vafai.
2417         
2418         Laying the framework for introducing the new history object and
2419         namespace.  This moves only static functions into the history
2420         namespace, and moves corresponding unit tests into seperate
2421         unit test file.
2422
2423         * TestResultServer/static-dashboards/aggregate_results.html:
2424         * TestResultServer/static-dashboards/dashboard_base.js:
2425         (parseCrossDashboardParameters):
2426         (parseDashboardSpecificParameters):
2427         (parseParameters):
2428         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2429         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2430         (.switch.return):
2431         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2432         * TestResultServer/static-dashboards/history.js: Added.
2433         * TestResultServer/static-dashboards/history_unittests.js: Added.
2434         * TestResultServer/static-dashboards/loader.js:
2435         (.):
2436         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2437         * TestResultServer/static-dashboards/run-unittests.html:
2438         * TestResultServer/static-dashboards/timeline_explorer.html:
2439         * TestResultServer/static-dashboards/timeline_explorer.js:
2440         * TestResultServer/static-dashboards/treemap.html:
2441         * TestResultServer/static-dashboards/treemap.js:
2442         (.switch.return):
2443         * TestResultServer/static-dashboards/ui.js:
2444
2445 2013-03-19  Daniel Bates  <dbates@webkit.org>
2446
2447         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2448         https://bugs.webkit.org/show_bug.cgi?id=112732
2449
2450         Reviewed by Eric Seidel.
2451
2452         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2453         of an existing file cannot be applied.
2454
2455         In particular, svn-{apply, unapply} compensate for differences in line endings
2456         by converting the line endings in a diff to match the line endings in the target
2457         file. The diff(1) command precedes the last line of a diff that adds a newline
2458         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2459         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2460         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2461         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2462         the newline characters in this special character sequence to match the line endings
2463         in the target file.
2464
2465         * Scripts/VCSUtils.pm:
2466         (parseDiff):
2467         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2468         Added tests:
2469             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2470             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2471             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2472             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2473         (escapeNewLineCharacters): Added.
2474         (toMacLineEndings): Added.
2475
2476 2013-03-19  James Robinson  <jamesr@chromium.org>
2477
2478         [chromium] Remove compositor settings that don't go through WebKit
2479         https://bugs.webkit.org/show_bug.cgi?id=112718
2480
2481         Reviewed by Adam Barth.
2482
2483         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2484         (main):
2485         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2486         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2487         (WebTestRunner::WebPreferences::reset):
2488         (WebTestRunner::WebPreferences::applyTo):
2489         * DumpRenderTree/chromium/TestShell.cpp:
2490         (TestShell::TestShell):
2491         (TestShell::resetWebSettings):
2492         * DumpRenderTree/chromium/TestShell.h:
2493         (TestShell):
2494
2495 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
2496
2497         Unreviewed, rolling out r146101.
2498         https://bugs.webkit.org/show_bug.cgi?id=111884
2499
2500         re-enable custom freetype on asan; this needs to be on
2501         now that the bot is running lucid.
2502
2503         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2504
2505 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
2506
2507         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
2508         https://bugs.webkit.org/show_bug.cgi?id=112365
2509
2510         Reviewed by Benjamin Poulain.
2511
2512         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
2513         harcoding it in wtf/Platform.h
2514
2515         * Scripts/webkitperl/FeatureList.pm:
2516
2517 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2518
2519         [Qt] Make ImageDiff similar to Chromium's ImageDiff
2520         https://bugs.webkit.org/show_bug.cgi?id=94782
2521
2522         Based on patch by Csaba Osztrogonác.
2523         Reviewed by Jocelyn Turcotte.
2524
2525         The diff image is generated with bright red indicating errors, but letting the base image
2526         shine through so the context of the error-pixel can be identified.
2527
2528         * DumpRenderTree/qt/ImageDiff.cpp:
2529         (main):
2530
2531 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
2532
2533         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
2534
2535         Rubber-stamped by Csaba Osztrogonác.
2536
2537         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
2538         since the latter might not cover the former.
2539
2540         * QtTestBrowser/launcherwindow.cpp:
2541         (LauncherWindow::print):
2542
2543 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2544
2545         Style tweeks to default.css.
2546         
2547         Rubber-stamped by David Kilzer.
2548         
2549         Give visited links a different color to other links, so you can
2550         see which builds you've viewed.
2551         
2552         Make the <small> text less tiny.
2553
2554         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2555         (small):
2556         (a:link,a:visited,a:active):
2557         (a:visited):
2558
2559 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2560
2561         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
2562         https://bugs.webkit.org/show_bug.cgi?id=112494
2563
2564         Reviewed by Dirk Pranke.
2565
2566         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
2567         Also merged two pairs of methods to cleanup the code.
2568
2569         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2570         (PerfTestsRunner.run): Merged _upload_and_show_results.
2571         (PerfTestsRunner._generate_results): Merged _generate_output_files.
2572
2573 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2574
2575         [chromium] build xdisplaycheck when building DRT
2576         https://bugs.webkit.org/show_bug.cgi?id=112636
2577
2578         Reviewed by Tony Chang.
2579
2580         It appears that we need xdisplaycheck to be built in order for
2581         Xvfb to be started correctly on the bots, and DRT was missing
2582         a dependency on it. This may be the cause of the ASAN bot not
2583         starting up properly (it only builds DRT).
2584
2585         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2586
2587 2013-03-18  David Levin  <levin@chromium.org>
2588
2589         Implement icon change notification dump for Chromium's test shell.
2590         https://bugs.webkit.org/show_bug.cgi?id=112614
2591
2592         This was previously implemented for some other platforms in r58111
2593         and r116547.
2594
2595         In r122806, fast/dom/icon-url-property.html stopped using it, but
2596         it is useful for tests, so I plan to re-add it to that test again.
2597
2598         Reviewed by Jochen Eisinger.
2599
2600         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2601         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
2602          icon change notifications from WebKit may be logged in test output.
2603         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2604         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
2605         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
2606         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
2607         (WebTestRunner):
2608         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
2609         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2610         (TestRunner):
2611         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2612         (WebTestRunner::WebTestProxyBase::didChangeIcon):
2613         (WebTestRunner):
2614         * DumpRenderTree/chromium/WebViewHost.cpp:
2615         (WebViewHost::didChangeIcon): Add the output about changing the icon.
2616         * DumpRenderTree/chromium/WebViewHost.h:
2617         (WebViewHost):
2618
2619 2013-03-18  Julie Parent  <jparent@chromium.org>
2620
2621         Cleanup: Move js for treemap and aggregate_results into own js files.
2622         https://bugs.webkit.org/show_bug.cgi?id=112618
2623
2624         Reviewed by Dirk Pranke.
2625         
2626         No functional changes, just moving the code into separate js file
2627         rather than inlined in the html, so we can test it, make it more
2628         modular, etc.  Other dashboard types are already done this way.
2629
2630         * TestResultServer/static-dashboards/aggregate_results.html:
2631         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
2632         (generatePage):
2633         (handleValidHashParameter):
2634         (htmlForBuilder):
2635         (rawValuesHTML):
2636         (chartHTML):
2637         (filteredValues):
2638         (chart):
2639         (htmlForRevisionRows):
2640         (wrapHTMLInTable):
2641         (htmlForSummaryTable):
2642         (valuesPerExpectation):
2643         (htmlForTestType):
2644         (htmlForTableRow):
2645         (extendedEncode):
2646         * TestResultServer/static-dashboards/treemap.html:
2647         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
2648         (humanReadableTime):
2649         (convertToWebTreemapFormat):
2650         (reverseSortByAverage):
2651         (generatePage):
2652         (focusPath):
2653         (.switch.return):
2654         (handleQueryParameterChange):
2655         (extractName):
2656         (fullName):
2657         (handleFocus.):
2658         (handleFocus):
2659
2660 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2661
2662         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
2663         https://bugs.webkit.org/show_bug.cgi?id=112622
2664
2665         Reviewed by Dirk Pranke.
2666
2667         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2668         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
2669
2670 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2671
2672         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
2673         https://bugs.webkit.org/show_bug.cgi?id=112619
2674
2675         Reviewed by Dirk Pranke.
2676
2677         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
2678         directory and then fall back to the generic LayoutTests/platform/gtk directory.
2679
2680         * Scripts/webkitpy/layout_tests/port/gtk.py:
2681         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
2682         Port._webkit_baseline_path method.
2683         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2684         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
2685         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
2686         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2687         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
2688         that are expected based on the builder name.
2689
2690 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
2691
2692         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
2693         https://bugs.webkit.org/show_bug.cgi?id=112571
2694
2695         Reviewed by Adam Barth.
2696
2697         Update function declarations for new WebFileSystemType enum. (All
2698         changes are behind an #ifdef so we can sync required changes in embedders.)
2699
2700         * DumpRenderTree/chromium/WebViewHost.cpp:
2701         (WebViewHost::openFileSystem):
2702         (WebViewHost::deleteFileSystem):
2703         * DumpRenderTree/chromium/WebViewHost.h:
2704         (WebViewHost):
2705
2706 2013-03-18  Julie Parent  <jparent@chromium.org>
2707
2708         Cleanup: Move timeline_exporer js out of html file into js.
2709         https://bugs.webkit.org/show_bug.cgi?id=112188
2710
2711         Reviewed by Dirk Pranke.
2712         
2713         Moves the javascript out of the html file and into a new js file.
2714         This follows the format of flakiness_dashboard.{html|js}.
2715         
2716         Also moves code from dashboard_base that is used only by this one
2717         dashboard, and makes it private to the dashboard.
2718
2719         * TestResultServer/static-dashboards/dashboard_base.js:
2720         * TestResultServer/static-dashboards/timeline_explorer.html:
2721         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
2722         (generatePage):
2723         (initCurrentBuilderTestResults):
2724         (shouldShowWebKitRevisionsOnly):
2725         (updateTimelineForBuilder.):
2726         (updateTimelineForBuilder):
2727         (selectBuild):
2728         (updateBuildIndicator):
2729         (.addRow):
2730         (.addNumberRow):
2731         (.inspectorNode.getElementsByTagName.0.onclick):
2732         (.inspectorNode.getElementsByTagName.1.onclick):
2733         (.inspectorNode.getElementsByTagName.2.onclick):
2734         (updateBuildInspector):
2735         (showResultsDelta):
2736         (decompressResults.addFlakyDelta):
2737         (decompressResults):
2738
2739 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2740
2741         Unreviewed, rolling out r145272.
2742         http://trac.webkit.org/changeset/145272
2743         https://bugs.webkit.org/show_bug.cgi?id=111884
2744
2745         Turns out the ASAN build is still broken; possibly there's
2746         something still setting LD_LIBRARY_PATH, or possibly there's
2747         something else wrong. In the meantime, we need it to work again.
2748
2749         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2750
2751 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2752
2753         delete-stale-build-files is too aggressive
2754         https://bugs.webkit.org/show_bug.cgi?id=112595
2755
2756         Reviewed by Tim Horton.
2757
2758         It appears that whitelisting file extensions to keep is not a good idea.
2759         Blacklist files to delete instead, and only delete .o files for now.
2760         We can add more file extensions as needed.
2761
2762         * BuildSlaveSupport/delete-stale-build-files:
2763
2764 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2765
2766         Disable accessibility notifications after each test
2767         https://bugs.webkit.org/show_bug.cgi?id=112579
2768
2769         Reviewed by Tim Horton.
2770         
2771         In WebKitTestRunner, if any tests triggered accessibility notifications,
2772         the global notification handler would thereafter be active, and fire
2773         notifications for all subsequent tests.
2774         
2775         Fix by implementing AccessibilityController::resetToConsistentState() for
2776         Mac, and using it to clear the global notification handler.
2777
2778         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2779         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2780         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
2781         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
2782         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
2783         (e.g. because of -autorelease).
2784         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
2785         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
2786         if there is one.
2787         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
2788         Add -stopObserving
2789         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2790         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
2791         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
2792         center.
2793
2794 2013-03-18  Dana Jansens  <danakj@chromium.org>
2795
2796         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
2797         https://bugs.webkit.org/show_bug.cgi?id=112392
2798
2799         Reviewed by James Robinson.
2800
2801         Removes the command line flag option from DRT.
2802
2803         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2804         (main):
2805
2806 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2807
2808         [GTK] plugins/plugin-clip-subframe.html is failing
2809         https://bugs.webkit.org/show_bug.cgi?id=112570
2810
2811         Reviewed by Martin Robinson.
2812
2813         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
2814
2815 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
2816
2817         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
2818         https://bugs.webkit.org/show_bug.cgi?id=112442
2819
2820         Reviewed by Gustavo Noronha Silva.
2821
2822         * GtkLauncher/main.c:
2823         (reloadCb):
2824         (createToolbar):
2825         (createWindow):
2826
2827 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2828
2829         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
2830         https://bugs.webkit.org/show_bug.cgi?id=112205
2831
2832         Disable this API test until Geoff can fix it.
2833
2834         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2835         (TestWebKitAPI::TEST):
2836
2837 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
2838
2839         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2840         https://bugs.webkit.org/show_bug.cgi?id=112478
2841
2842         Reviewed by Tony Chang.
2843
2844         There is nothing that ensures that the log messages from the plugin
2845         come in before the layout test finished loading.
2846
2847         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2848         (PassDifferentNPPStruct::NPP_SetWindow):
2849         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2850         (NPP_SetWindow):
2851
2852 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2853
2854         Have the mac port support per_test_timeout in webkitpy
2855         https://bugs.webkit.org/show_bug.cgi?id=112466
2856
2857         Reviewed by Dirk Pranke.
2858         
2859         Both WTR and DRT handle --timeout arguments, so we can
2860         have the scripts pass the timeout values down to the tools.
2861
2862         * Scripts/webkitpy/layout_tests/port/mac.py:
2863         (MacPort.supports_per_test_timeout):
2864
2865 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
2866
2867         Remove setAsynchronousSpellCheckingEnabled from test runners
2868         https://bugs.webkit.org/show_bug.cgi?id=112362
2869
2870         Reviewed by Tony Chang.
2871
2872         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
2873         in internals.settings, so all ports can share it.
2874
2875         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2876         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2877         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2878         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2879         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2880         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2881         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2882         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
2883         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2884         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
2885         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2886         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2887
2888 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2889
2890         Fix the stupid unit tests.
2891
2892         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2893         (test_sample_process):
2894
2895 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
2896
2897         Collect samples for unresponsive web processes
2898         https://bugs.webkit.org/show_bug.cgi?id=112409
2899
2900         Reviewed by Tim Horton.
2901         
2902         When we detect that a subprocess was unresponsive, run the 'sample'
2903         tool on that process, for the Mac port.
2904         
2905         The sample will be linked to from the results.html page, next
2906         to the crash log link.
2907
2908         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2909         (Manager._look_for_new_crash_logs): Before looking for crash logs,
2910         look for samples on disk.
2911         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2912         (TestResultWriter):
2913         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
2914         -sample.txt files, and have it copy their contents to a new file
2915         next to the test that spawned them (as we do for crash logs).
2916         * Scripts/webkitpy/layout_tests/port/base.py:
2917         (Port.look_for_new_samples): Base class does nothing for sampling.
2918         * Scripts/webkitpy/layout_tests/port/driver.py:
2919         (Driver._check_for_driver_crash): Kick off a sample if we detected
2920         that the subprocess was unresponsive.
2921         * Scripts/webkitpy/layout_tests/port/mac.py:
2922         (MacPort.sample_file_path): Utility to generate the file path
2923         to the generated sample files at the top level of layout-test-results.
2924         (MacPort.look_for_new_crash_logs): Fix typo
2925         (MacPort.look_for_new_samples): New function to find sample files.
2926         (MacPort.sample_process): Use the utility function to get the file path.
2927
2928 2013-03-15  Zeno Albisser  <zeno@webkit.org>
2929
2930         [Qt] Remove simple getters and setters from TestRunnerQt
2931         https://bugs.webkit.org/show_bug.cgi?id=112343
2932
2933         Reviewed by Benjamin Poulain.
2934
2935         The removed functions and boolean members
2936         are being replaced by the implementations in the
2937         generic TestRunner.h.
2938
2939         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2940         (DumpRenderTree::dumpFrameScrollPosition):
2941         (DumpRenderTree::dumpFramesAsText):
2942         (DumpRenderTree::dump):
2943         (DumpRenderTree::titleChanged):
2944         (DumpRenderTree::dumpDatabaseQuota):
2945         (DumpRenderTree::dumpApplicationCacheQuota):
2946         (DumpRenderTree::statusBarMessage):
2947         (DumpRenderTree::createWindow):
2948         * DumpRenderTree/qt/TestRunnerQt.cpp:
2949         (TestRunnerQt::reset):
2950         * DumpRenderTree/qt/TestRunnerQt.h:
2951         (TestRunnerQt):
2952
2953 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
2954
2955         Update the link on build.webkit.org to refer to perf.webkit.org
2956         https://bugs.webkit.org/show_bug.cgi?id=112416
2957
2958         Reviewed by Philip Rogers.
2959
2960         Updated the link. Also updated the template to use HTML5 DOCTYPE.
2961
2962         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2963
2964 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
2965
2966         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
2967         https://bugs.webkit.org/show_bug.cgi?id=112394
2968
2969         Reviewed by Philippe Normand.
2970
2971         * GtkLauncher/main.c:
2972         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
2973
2974 2013-03-14  Andreas Kling  <akling@apple.com>
2975
2976         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
2977         <http://webkit.org/b/111815>
2978         <rdar://problem/13380145>
2979
2980         Reviewed by Anders Carlsson.
2981
2982         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
2983         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
2984         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
2985
2986         * WebKitTestRunner/PlatformWebView.h:
2987         (PlatformWebView):
2988         * WebKitTestRunner/TestController.cpp:
2989         (WTR::TestController::createOtherPage):
2990         (WTR::TestController::createWebViewWithOptions):
2991         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2992         (WTR::PlatformWebView::didInitializeClients):
2993
2994 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2995
2996         [EFL][MiniBrowser] Add a search field to the MiniBrowser
2997         https://bugs.webkit.org/show_bug.cgi?id=112122
2998
2999         Reviewed by Kenneth Rohde Christiansen.
3000
3001         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3002
3003         * MiniBrowser/efl/main.c:
3004         (_Browser_Window):
3005         (search_box_show):
3006         (search_box_hide):
3007         (on_key_down):
3008         (on_url_changed):
3009         (on_search_field_aborted):
3010         (on_search_field_activated):
3011         (on_search_field_clicked):
3012         (on_search_backward_button_clicked):
3013         (on_search_forward_button_clicked):
3014         (window_create):
3015
3016 2013-03-14  Julie Parent  <jparent@chromium.org>
3017
3018         Cleanup: Remove g_resourceLoader.
3019         https://bugs.webkit.org/show_bug.cgi?id=112305
3020
3021         Reviewed by Dirk Pranke.
3022         
3023         Removing another global.
3024         
3025         Now, each dashboard creates its own loader, rather than having
3026         a general global one.
3027         
3028         Remove usage of g_resourceLoader.isLoadingComplete from 
3029         handleLocationChange by ensuring that handleLocationChange is
3030         never called before the loader is done.  It was called in two
3031         places before: 1 was from the callback when the loader is done,
3032         so that was obviously true, and the other was from onhashchange,
3033         where it would just return rather than running.  Instead, lets
3034         only register the onhashchange handler once the loader is
3035         setup, so the check is no longer necessary.
3036         
3037         Remove isLoadingComplete since it is now unused.
3038         
3039         Callback for loader is now initializeHistory, rather than just
3040         handleLocationChange which will set up the hashchange handler now.
3041         This will all eventually be moving to a new History object.
3042
3043         * TestResultServer/static-dashboards/aggregate_results.html:
3044         * TestResultServer/static-dashboards/dashboard_base.js:
3045         (handleLocationChange):
3046         (intializeHistory):
3047         (decompressResults):
3048         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3049         (generatePage):
3050         * TestResultServer/static-dashboards/loader.js:
3051         (.):
3052         * TestResultServer/static-dashboards/loader_unittests.js:
3053         * TestResultServer/static-dashboards/timeline_explorer.html:
3054         * TestResultServer/static-dashboards/treemap.html:
3055
3056 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3057
3058         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3059         https://bugs.webkit.org/show_bug.cgi?id=109404
3060
3061         Reviewed by Tony Chang.
3062
3063         Removes all the code related to smartInsertDeleteEnabled and
3064         selectTrailingWhitespaceEnabled settings as they will be managed from
3065         internals from now on.
3066
3067         * DumpRenderTree/TestRunner.cpp:
3068         (TestRunner::staticFunctions):
3069         * DumpRenderTree/TestRunner.h:
3070         (TestRunner):
3071         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3072         (WebKit):
3073         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3074         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3075         (DumpRenderTree):
3076         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3077         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3078         (WebTestRunner::WebTestProxy::didStopLoading):
3079         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3080         (WebTestRunner::TestRunner::TestRunner):
3081         (WebTestRunner::TestRunner::reset):
3082         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3083         (TestRunner):
3084         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3085         (WebTestRunner::WebPreferences::applyTo): Set default values for
3086         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3087         Chromium DRT default values are different from Chromium browser.
3088         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3089         * DumpRenderTree/chromium/WebViewHost.cpp:
3090         * DumpRenderTree/chromium/WebViewHost.h:
3091         (WebViewHost):
3092         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3093         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3094         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3095         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3096         (resetDefaultsToConsistentValues):
3097         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3098         * DumpRenderTree/mac/DumpRenderTree.mm:
3099         (resetWebViewToConsistentStateBeforeTesting):
3100         * DumpRenderTree/mac/TestRunnerMac.mm:
3101         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3102         (WebCore::WebPage::resetSettings):
3103         * DumpRenderTree/qt/TestRunnerQt.cpp:
3104         * DumpRenderTree/qt/TestRunnerQt.h:
3105         (TestRunnerQt):
3106         * DumpRenderTree/win/DumpRenderTree.cpp:
3107         (resetWebViewToConsistentStateBeforeTesting):
3108         * DumpRenderTree/win/TestRunnerWin.cpp:
3109         * DumpRenderTree/wx/TestRunnerWx.cpp:
3110
3111 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3112
3113         [Qt] Disable DRT on Windows
3114
3115         Reviewed by Jocelyn Turcotte.
3116
3117         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3118
3119         * qmake/mkspecs/features/configure.prf:
3120
3121 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3122
3123         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
3124         https://bugs.webkit.org/show_bug.cgi?id=110728
3125
3126         Reviewed by Gyuyoung Kim.
3127
3128         Use the page group to create the view object.
3129
3130         * MiniBrowser/efl/main.c:
3131         (window_create):
3132
3133 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3134
3135         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
3136
3137         Reviewed by Tor Arne Vestbø.
3138
3139         The mock versions of these web facing features should be instantiated when
3140         running in DumpRenderTree only. In order for them to work, no extra Qt modules
3141         such as QtLocation are actually needed.
3142
3143         This patch decouples enabling device orientation/motion and geolocation from
3144         the underlying Qt modules and makes them available in developer builds
3145         (!production_build) and backed by mock backends when running in drt.
3146
3147         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
3148         developers the web facing features are always enabled (although requests will
3149         time out) and the mock backends are enabled inside DRT, allowing for the layout
3150         tests to run with less dependencies.
3151
3152         In addition this also enables the mock device motion client, which was
3153         previously never instantiated.
3154
3155         * qmake/mkspecs/features/features.prf:
3156
3157 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3158
3159         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
3160         https://bugs.webkit.org/show_bug.cgi?id=112340
3161
3162         Reviewed by Simon Hausmann.
3163
3164         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3165         (DumpRenderTree::dump):
3166             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
3167         (DumpRenderTree::dumpApplicationCacheQuota):
3168         * DumpRenderTree/qt/TestRunnerQt.cpp:
3169         (TestRunnerQt::reset):
3170         * DumpRenderTree/qt/TestRunnerQt.h:
3171         (TestRunnerQt):
3172
3173 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3174
3175         [Qt] Port DRT to use TestRunner::dumpAsText()
3176         https://bugs.webkit.org/show_bug.cgi?id=112260
3177
3178         Reviewed by Benjamin Poulain.
3179
3180         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3181         (WebCore::DumpRenderTree::open):
3182         (WebCore::methodNameStringForFailedTest):
3183             Change parameter from type TestRunnerQt* to TestRunner*.
3184         (WebCore::DumpRenderTree::dump):
3185             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3186             Instead we should rely on TestRunner::generatePixelResults().
3187         * DumpRenderTree/qt/TestRunnerQt.cpp:
3188         (TestRunnerQt::reset):
3189         * DumpRenderTree/qt/TestRunnerQt.h:
3190         (TestRunnerQt):
3191
3192 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3193
3194         Implement FontLoader interface
3195         https://bugs.webkit.org/show_bug.cgi?id=98395
3196
3197         Reviewed by Eric Seidel.
3198
3199         Enable FontLoadEvents runtime flag for TestShell.
3200
3201         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3202         (WebTestRunner::TestInterfaces::TestInterfaces):
3203
3204 2013-03-13  Julie Parent  <jparent@chromium.org>
3205
3206         CLeanup: remove unnecessary call to parseParameters.
3207         https://bugs.webkit.org/show_bug.cgi?id=112309
3208
3209         Reviewed by Ojan Vafai.
3210         
3211         We call parseCrossDashboardParameters when the dashboard initially
3212         loads to set the state required for loadBuildersList, and then we
3213         call it again once we are fully done with loading, so there is no
3214         reason to call it in the middle of the loading process here.
3215
3216         * TestResultServer/static-dashboards/loader.js:
3217         (.):
3218
3219 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3220
3221         Unreviewed. Now I'm a reviewer :)
3222
3223         * Scripts/webkitpy/common/config/committers.py:
3224
3225 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3226
3227         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3228         https://bugs.webkit.org/show_bug.cgi?id=112277
3229
3230         Reviewed by Adam Barth.
3231
3232         * Scripts/webkitperl/FeatureList.pm:
3233         * qmake/mkspecs/features/features.pri:
3234
3235 2013-03-13  Adam Barth  <abarth@webkit.org>
3236
3237         run-perf-tests should support content_shell
3238         https://bugs.webkit.org/show_bug.cgi?id=112291
3239
3240         Reviewed by Eric Seidel.
3241
3242         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3243         (PerfTestsRunner._parse_args):
3244
3245 2013-03-13  Oliver Hunt  <oliver@apple.com>
3246
3247         Simplify Checked<> multiplication
3248         https://bugs.webkit.org/show_bug.cgi?id=112286
3249
3250         Reviewed by James Robinson.
3251
3252         Add tests for multiplication by zero and max to ensure we don't
3253         mess them up should we ever make changes to Checked<> in future.
3254
3255         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3256         (TestWebKitAPI):
3257
3258 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3259
3260         [Qt] Unreviewed prospective Windows build fix
3261
3262         Do the usual thing, include the moc generated code in the .cpp file instead
3263         of compiling it standalone, to ensure that config.h is included, too, and
3264         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3265
3266         * DumpRenderTree/qt/EventSenderQt.cpp:
3267
3268 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3269
3270         [Qt] Port TestRunner::findString to shared interface
3271         https://bugs.webkit.org/show_bug.cgi?id=112147
3272
3273         Reviewed by Jocelyn Turcotte.
3274
3275         This patch also removes DumpRenderTree and some other helper classes from
3276         the WebCore namespace, to which they do not really belong.
3277
3278         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3279         (main):
3280         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3281         (DumpRenderTree::DumpRenderTree):
3282         (DumpRenderTree::~DumpRenderTree):
3283         (DumpRenderTree::instance):
3284         (DumpRenderTree::setShouldTimeout):
3285         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3286         (DumpRenderTree):
3287         * DumpRenderTree/qt/EventSenderQt.cpp:
3288         (EventSender::contextClick):
3289         (EventSender::sendEvent):
3290         (EventSender::postEvent):
3291         * DumpRenderTree/qt/EventSenderQt.h:
3292         (EventSender::isGraphicsBased):
3293         * DumpRenderTree/qt/TestRunnerQt.cpp:
3294         (TestRunnerQt::TestRunnerQt):
3295         (TestRunner::findString):
3296         (TestRunnerQt::setMockDeviceOrientation):
3297         (TestRunnerQt::setGeolocationPermission):
3298         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3299         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3300         (TestRunnerQt::setMockGeolocationPosition):
3301         * DumpRenderTree/qt/TestRunnerQt.h:
3302         (TestRunnerQt):
3303
3304 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3305
3306         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3307         https://bugs.webkit.org/show_bug.cgi?id=112129
3308
3309         Reviewed by Adam Barth.
3310
3311         Following Chromium
3312         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3313         this is being renamed to better explain what it does.
3314
3315         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3316
3317 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3318
3319         [Qt] Unreviewed trivial typo fix
3320
3321         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3322         TextRunner.h. Thanks Zeno :)
3323
3324 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3325
3326         [Qt] Prepare DRT for transition to shared TestRunner interface
3327         https://bugs.webkit.org/show_bug.cgi?id=112144
3328
3329         Reviewed by Benjamin Poulain.
3330
3331         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3332         the JSC C API based one.
3333
3334         This is impplemented by instantiating the QObject based testRunner in
3335         the global object, then instantiating the JSC C based TestRunner
3336         separately and placing it "behind" the QObject based testRunner through
3337         injection of the individual functions through proxies. (prototype
3338         chaining doesn't work due to the this object and Function.prototype.bind
3339         doesn't work due to the native function)
3340
3341         This allows for porting over method by method by removing the method
3342         from the QObject TestRunnerQt and implementing it in the JSC C based
3343         TestRunner.
3344
3345         In order for this to link and run dummy implementations of all the
3346         necessary TestRunner functions are provided.
3347
3348         * DumpRenderTree/qt/DumpRenderTree.pro:
3349         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3350         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3351         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3352         (WebCore::DumpRenderTree::initJSObjects):
3353         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3354         (DumpRenderTree):
3355         * DumpRenderTree/qt/TestRunnerQt.cpp:
3356         (TestRunner::~TestRunner):
3357         (TestRunner::addDisallowedURL):
3358         (TestRunner::queueLoad):
3359         (TestRunner::removeAllVisitedLinks):
3360         (TestRunner::setAcceptsEditing):
3361         (TestRunner::simulateLegacyWebNotificationClick):
3362         (TestRunner::setWindowIsKey):
3363         (TestRunner::setAlwaysAcceptCookies):
3364         (TestRunner::addOriginAccessWhitelistEntry):
3365         (TestRunner::setWebViewEditable):
3366         (TestRunner::clearAllApplicationCaches):
3367         (TestRunner::setTextDirection):
3368         (TestRunner::notifyDone):
3369         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3370         (TestRunner::overridePreference):
3371         (TestRunner::pathToLocalResource):
3372         (TestRunner::removeAllWebNotificationPermissions):
3373         (TestRunner::simulateWebNotificationClick):
3374         (TestRunner::closeIdleLocalStorageDatabases):
3375         (TestRunner::focusWebView):
3376         (TestRunner::setBackingScaleFactor):
3377         (TestRunner::removeChromeInputField):
3378         (TestRunner::addChromeInputField):
3379         (TestRunner::originsWithLocalStorage):
3380         (TestRunner::deleteAllLocalStorage):
3381         (TestRunner::deleteLocalStorageForOrigin):
3382         (TestRunner::observeStorageTrackerNotifications):
3383         (TestRunner::syncLocalStorage):
3384         (TestRunner::windowCount):
3385         (TestRunner::setWaitToDump):
3386         (TestRunner::waitForPolicyDelegate):
3387         (TestRunner::webHistoryItemCount):
3388         (TestRunner::showWebInspector):
3389         (TestRunner::closeWebInspector):
3390         (TestRunner::evaluateInWebInspector):
3391         (TestRunner::setSerializeHTTPLoads):
3392         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3393         (TestRunner::setCustomPolicyDelegate):
3394         (TestRunner::setDatabaseQuota):
3395         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3396         (TestRunner::resetPageVisibility):
3397         (TestRunner::keepWebHistory):
3398         (TestRunner::goBack):
3399         (TestRunner::originsWithApplicationCache):
3400         (TestRunner::applicationCacheDiskUsageForOrigin):
3401         (TestRunner::display):
3402         (TestRunner::dispatchPendingLoadRequests):
3403         (TestRunner::clearPersistentUserStyleSheet):
3404         (TestRunner::callShouldCloseOnWebView):
3405         (TestRunner::copyDecodedHostName):
3406         (TestRunner::clearBackForwardList):
3407         (TestRunner::clearAllDatabases):
3408         (TestRunner::clearApplicationCacheForOrigin):
3409         (TestRunner::apiTestGoToCurrentBackForwardItem):
3410         (TestRunner::authenticateSession):
3411         (TestRunner::abortModal):
3412         (TestRunner::setStorageDatabaseIdleInterval):
3413         (TestRunner::setAsynchronousSpellCheckingEnabled):
3414         (TestRunner::setXSSAuditorEnabled):
3415         (TestRunner::setSpatialNavigationEnabled):
3416         (TestRunner::setScrollbarPolicy):
3417         (TestRunner::setJavaScriptCanAccessClipboard):
3418         (TestRunner::setAutomaticLinkDetectionEnabled):
3419         (TestRunner::setUserStyleSheetEnabled):
3420         (TestRunner::setUserStyleSheetLocation):
3421         (TestRunner::setUseDashboardCompatibilityMode):
3422         (TestRunner::setTabKeyCyclesThroughElements):
3423         (TestRunner::setSmartInsertDeleteEnabled):
3424         (TestRunner::setSelectTrailingWhitespaceEnabled):
3425         (TestRunner::setPrivateBrowsingEnabled):
3426         (TestRunner::setPluginsEnabled):
3427         (TestRunner::setPopupBlockingEnabled):
3428         (TestRunner::setMockSpeechInputDumpRect):
3429         (TestRunner::setPersistentUserStyleSheetLocation):
3430         (TestRunner::setMockGeolocationPosition):
3431         (TestRunner::setMockGeolocationPositionUnavailableError):
3432         (TestRunner::setMockDeviceOrientation):
3433         (TestRunner::setMainFrameIsFirstResponder):
3434         (TestRunner::setIconDatabaseEnabled):
3435         (TestRunner::setGeolocationPermission):
3436         (TestRunner::setDefersLoading):
3437         (TestRunner::setCacheModel):
3438         (TestRunner::setAuthorAndUserStylesEnabled):
3439         (TestRunner::setAllowFileAccessFromFileURLs):
3440         (TestRunner::setAppCacheMaximumSize):
3441         (TestRunner::setAllowUniversalAccessFromFileURLs):
3442         (TestRunner::setApplicationCacheOriginQuota):
3443         (TestRunner::denyWebNotificationPermission):
3444         (TestRunner::grantWebNotificationPermission):
3445         (TestRunner::setValueForUser):
3446         (TestRunner::setViewModeMediaFeature):
3447         (TestRunner::setPageVisibility):
3448         (TestRunner::addMockSpeechInputResult):
3449         (TestRunner::removeOriginAccessWhitelistEntry):
3450         (TestRunner::addUserScript):
3451         (TestRunner::isCommandEnabled):
3452         (TestRunner::evaluateScriptInIsolatedWorld):
3453         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3454         (TestRunner::copyEncodedHostName):
3455         (TestRunner::addUserStyleSheet):
3456         (TestRunner::findString):
3457         (TestRunner::execCommand):
3458         (TestRunner::localStorageDiskUsageForOrigin):
3459
3460 2013-03-12  Julie Parent  <jparent@chromium.org>
3461
3462         Cleanup: Move flatten-trie to loader.
3463         https://bugs.webkit.org/show_bug.cgi?id=112196
3464
3465         Reviewed by Dirk Pranke.
3466
3467         flatten-trie is used only by the loader, so move it there and make it
3468         private, rather than global in dashbaord_base. Moved the corresponding
3469         unit test from flakiness_dashboard_unittests to loader_unittests.
3470         
3471         * TestResultServer/static-dashboards/dashboard_base.js:
3472         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3473         * TestResultServer/static-dashboards/loader.js:
3474         (.):
3475         * TestResultServer/static-dashboards/loader_unittests.js:
3476
3477 2013-03-12  Oliver Hunt  <oliver@apple.com>
3478
3479         Unbreak api tests
3480
3481         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3482         (TestWebKitAPI):
3483
3484 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3485
3486         Unreviewed, disabling tests for Win EWS.
3487
3488         win-ews obviously cannot keep up with running tests, it's >300 behind.
3489         Probably doesn't help that its (likely) running tests serially.
3490
3491         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3492         (WinEWS):
3493
3494 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3495
3496         Add a --build-directory argument to delete-stale-build-files
3497         https://bugs.webkit.org/show_bug.cgi?id=112198
3498
3499         Reviewed by Ryosuke Niwa.
3500
3501         * BuildSlaveSupport/delete-stale-build-files:
3502         (main): Add --build-directory argument.
3503
3504 2013-03-12  Oliver Hunt  <oliver@apple.com>
3505
3506         Appease MSVC
3507
3508         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3509         (TestWebKitAPI):
3510
3511 2013-03-12  Oliver Hunt  <oliver@apple.com>
3512
3513         Add more Checked<> tests
3514         https://bugs.webkit.org/show_bug.cgi?id=112190
3515
3516         Reviewed by Geoffrey Garen.
3517
3518         Tests!
3519
3520         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3521         (TestWebKitAPI):
3522
3523 2013-03-12  Julie Parent  <jparent@chromium.org>
3524
3525         Cleanup: Move loading complete function into callback, rather than global.
3526         https://bugs.webkit.org/show_bug.cgi?id=112167
3527
3528         Reviewed by Dirk Pranke.
3529         
3530         Stop calling global functions, pass in proper handler to Loader
3531         constructor. Note that the callback is optional, as tests, and
3532         some potential dashboards, do not need one.
3533
3534         * TestResultServer/static-dashboards/dashboard_base.js:
3535         * TestResultServer/static-dashboards/loader.js:
3536         (.):
3537         * TestResultServer/static-dashboards/loader_unittests.js:
3538
3539 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3540
3541         [EFL][WK2] Add popup menu support to MiniBrowser
3542         https://bugs.webkit.org/show_bug.cgi?id=108934
3543
3544         Reviewed by Kenneth Rohde Christiansen.
3545
3546         Implement popup menu support in MiniBrowser by handling popup_menu_show
3547         and popup_menu_hide smart functions on the view and using the Ewk popup
3548         menu API.
3549
3550         * MiniBrowser/efl/main.c:
3551         (_Browser_Window):
3552         (on_popup_menu_discarded):
3553         (on_popup_menu_item_clicked):
3554         (popup_menu_populate):
3555         (on_popup_menu_show):
3556         (on_popup_menu_hide):
3557         (window_create): Use calloc() instead of malloc() to allocate memory for
3558         Browser_Window. This makes sure all the structs members are initialized
3559         to 0 (such as the new elm_popup_menu pointer).
3560
3561 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3562
3563         [GTK] Set up the libPlatformGtk.la library
3564         https://bugs.webkit.org/show_bug.cgi?id=111738
3565
3566         Reviewed by Martin Robinson.
3567
3568         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3569         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
3570         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3571
3572 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3573
3574         [GTK] Enable Web Audio in development builds
3575         https://bugs.webkit.org/show_bug.cgi?id=111831
3576
3577         Reviewed by Philippe Normand.
3578
3579         Web Audio is already quite well supported on the GTK port but still has a few issues
3580         that must be addressed before it is enabled by default. Despite that it should be enabled
3581         in development builds just so we are up-to-date with future feature infrastructure changes.
3582         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3583         that's an obvious goal before enabling the feature in release builds.
3584
3585         * Scripts/webkitperl/FeatureList.pm:
3586
3587 2013-03-11  Andreas Kling  <akling@apple.com>
3588
3589         [Mac][WK1] Add support for alert() in MiniBrowser.
3590         <http://webkit.org/b/112090>
3591
3592         Reviewed by Anders Carlsson.
3593
3594         * MiniBrowser/mac/WK1BrowserWindowController.m:
3595         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3596
3597 2013-03-11  Julie Parent  <jparent@chromium.org>
3598
3599         Dashboard cleanup: Create ui.Errors
3600         https://bugs.webkit.org/show_bug.cgi?id=111785
3601
3602         Reviewed by Ojan Vafai.
3603         
3604         Create ui.Errors for handling errors the dashboards
3605         encounter. Loader now has a Error object that it can add to,
3606         and individual dashboards can show errors when desired.
3607         Currently, only flakiness_db shows errors, but this is 
3608         generic and there is no reason why other dbs wouldn't want to
3609         show errors.
3610
3611         * TestResultServer/static-dashboards/dashboard_base.js:
3612         (resourceLoadingComplete):
3613         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3614         (generatePage):
3615         * TestResultServer/static-dashboards/loader.js:
3616         (.):
3617         * TestResultServer/static-dashboards/ui.js:
3618         (.):
3619
3620 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
3621
3622         Some StringHasher tests are broken because of missing null termination
3623         https://bugs.webkit.org/show_bug.cgi?id=111284
3624
3625         Reviewed by Darin Adler.
3626
3627         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3628         (TestWebKitAPI): Added null termination since C strings are null-terminated.
3629         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
3630         the bug caught by it is now fixed.
3631
3632 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3633
3634         Unreviewed, rolling out r145200.
3635         http://trac.webkit.org/changeset/145200
3636         https://bugs.webkit.org/show_bug.cgi?id=112063
3637
3638         Broke a couple of unit tests (Requested by zdobersek on
3639         #webkit).
3640
3641         * Scripts/webkitperl/FeatureList.pm:
3642
3643 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
3644
3645         [GTK] WebKit2-only build fails
3646         https://bugs.webkit.org/show_bug.cgi?id=112033
3647
3648         Reviewed by Gustavo Noronha Silva.
3649
3650         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
3651         generic part, WebKit1-specific part and WebKit2-specific part.
3652         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
3653         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
3654         directly.
3655
3656 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
3657
3658         Adding myself to the committers list.
3659
3660         Unreviewed.
3661
3662         * Scripts/webkitpy/common/config/committers.py:
3663
3664 2013-03-11  Jeff Rogers  <jrogers@rim.com>
3665
3666         [BlackBerry] Disable MathML support
3667         https://bugs.webkit.org/show_bug.cgi?id=111929
3668
3669         Reviewed by Rob Buis.
3670
3671         * Scripts/webkitperl/FeatureList.pm:
3672
3673 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3674
3675         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
3676         https://bugs.webkit.org/show_bug.cgi?id=111970
3677
3678         Reviewed by Chris Fleizach.
3679
3680         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
3681         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
3682         undefined symbol.
3683
3684         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3685         (WTR::AccessibilityUIElement::supportedActions):
3686         (WTR):
3687
3688 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
3689
3690         [chromium] Android apk targets should depend directly on Java library targets
3691         https://bugs.webkit.org/show_bug.cgi?id=111746
3692
3693         Reviewed by Eric Seidel.
3694
3695         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3696         Make DumpRenderTree_apk depend directly on base_java and net_java.
3697         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3698         Make TestWebKitAPI_apk depend directly on base_java.
3699
3700 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
3701
3702         [chromium] remove obsolete user gesture methods from WebFrame
3703         https://bugs.webkit.org/show_bug.cgi?id=111696
3704
3705         Reviewed by Adam Barth.
3706
3707         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3708         (WebTestRunner::TestPlugin::handleInputEvent):
3709         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3710
3711 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
3712
3713         Unreviewed, add myself to commiters.py.
3714
3715         * Scripts/webkitpy/common/config/committers.py:
3716
3717 2013-03-08  Julie Parent  <jparent@chromium.org>
3718
3719         Cleanup: Remove dead code.
3720         https://bugs.webkit.org/show_bug.cgi?id=111900
3721
3722         Reviewed by Dirk Pranke.
3723         
3724         Treemap overrides a global function that used to be in 
3725         dashboard_base, but was removed months ago in
3726         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
3727         no caller. 
3728
3729         * TestResultServer/static-dashboards/treemap.html:
3730
3731 2013-03-08  Harald Alvestrand  <hta@chromium.org>
3732
3733         Implemented new API for RTCStatsReport object.
3734         https://bugs.webkit.org/show_bug.cgi?id=110333
3735
3736         Reviewed by Adam Barth.
3737
3738         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3739         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
3740
3741 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
3742
3743         [chromium] use custom freetype on linux asan builds again
3744         https://bugs.webkit.org/show_bug.cgi?id=111884
3745
3746         Reviewed by Tony Chang.
3747
3748         We no longer need the workaround after chromium r186540.
3749
3750         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3751
3752 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
3753
3754         Warning about the user not having edit rights on Bugzilla is confusing new contributors
3755         https://bugs.webkit.org/show_bug.cgi?id=111798
3756
3757         Reviewed by Dirk Pranke.
3758
3759         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
3760
3761         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3762
3763 2013-03-08  James Robinson  <jamesr@chromium.org>
3764
3765         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
3766         https://bugs.webkit.org/show_bug.cgi?id=111632
3767
3768         Reviewed by Adrienne Walker.
3769
3770         * DumpRenderTree/chromium/WebViewHost.cpp:
3771         (WebViewHost::initializeLayerTreeView):
3772         * DumpRenderTree/chromium/WebViewHost.h:
3773         (WebViewHost):
3774
3775 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
3776
3777         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
3778         https://bugs.webkit.org/show_bug.cgi?id=111297
3779
3780         Reviewed by Kenneth Rohde Christiansen.
3781
3782         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3783         (WTR::TestRunner::setViewModeMediaFeature):
3784
3785 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
3786
3787         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
3788         https://bugs.webkit.org/show_bug.cgi?id=111814
3789
3790         Reviewed by Ryosuke Niwa.
3791
3792         Add the needed supportedActions() attribute to WKTestRunner.
3793
3794         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3795         (WTR::AccessibilityUIElement::supportedActions):
3796         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3797         (AccessibilityUIElement):
3798         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3799         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3800         (WTR::AccessibilityUIElement::supportedActions):
3801
3802 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3803
3804         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
3805         https://bugs.webkit.org/show_bug.cgi?id=111851
3806
3807         Reviewed by Kenneth Rohde Christiansen.
3808
3809         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3810         (TestWebKitAPI::TEST):
3811
3812             Fixed WKURLRef instance leaking.
3813
3814 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3815
3816         [EFL] [WK2] Some authentication tests fail in WebKit2
3817         https://bugs.webkit.org/show_bug.cgi?id=106407
3818
3819         Reviewed by Kenneth Rohde Christiansen.
3820
3821         Add patch from upstream for libsoup 2.40 to fix several authentication
3822         test cases.
3823
3824         * efl/jhbuild.modules:
3825         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
3826
3827 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
3828
3829         [GTK] Enable Web Audio in development builds
3830         https://bugs.webkit.org/show_bug.cgi?id=111831
3831
3832         Reviewed by Philippe Normand.
3833
3834         Web Audio is already quite well supported on the GTK port but still has a few issues
3835         that must be addressed before it is enabled by default. Despite that it should be enabled
3836         in development builds just so we are up-to-date with future feature infrastructure changes.
3837         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3838         that's an obvious goal before enabling the feature in release builds.
3839
3840         * Scripts/webkitperl/FeatureList.pm:
3841
3842 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3843
3844         [chromium] delay clearing the TestRunners until the main view was deleted
3845         https://bugs.webkit.org/show_bug.cgi?id=111823
3846
3847         Reviewed by Eric Seidel.
3848
3849         During WebViewHost::shutdown, we navigate the WebView to about:blank.
3850         This may call into the test runners which assume that the delegate is
3851         always non-NULL.
3852
3853         * DumpRenderTree/chromium/TestShell.cpp:
3854         (TestShell::~TestShell):
3855
3856 2013-03-07  Alan Cutter  <alancutter@chromium.org>
3857
3858         Sheriffbot whois command can't search by full name
3859         https://bugs.webkit.org/show_bug.cgi?id=111825
3860
3861         Reviewed by Eric Seidel.
3862
3863         Allowed multiple arguments to Sheriffbot's whois command.
3864         Updated test expectations.
3865
3866         * Scripts/webkitpy/tool/bot/irc_command.py:
3867         (Whois.execute):
3868         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3869         (IRCCommandTest.test_whois):
3870
3871 2013-03-07  Nils Barth  <nbarth@chromium.org>
3872
3873         Add Nils Barth and Koji Hara to committers.py
3874         https://bugs.webkit.org/show_bug.cgi?id=111806
3875
3876         Reviewed by Eric Seidel.
3877
3878         * Scripts/webkitpy/common/config/committers.py:
3879
3880 2013-03-07  Glenn Adams  <glenn@skynav.com>
3881
3882         run-pert-tests should have a --test-runner-count option
3883         https://bugs.webkit.org/show_bug.cgi?id=111726
3884
3885         Reviewed by Ryosuke Niwa.
3886
3887         Add --test-runner-count option to run-perf-tests, with default value of 4.
3888         This option allows command line configuration of the number of times to invoke
3889         the test runner (serially, not in parallel) when running a specific test in
3890         a test set.
3891
3892         * Scripts/webkitpy/performance_tests/perftest.py:
3893         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
3894         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
3895         (PerfTest.run): Rename process_run_count to test_runner_count.
3896         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
3897         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
3898         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
3899         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
3900         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3901         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
3902         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
3903         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3904         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
3905         (MainTest.test_run_with_repeat):
3906         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
3907         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3908         (MainTest.test_default_args): Add test for default option argument values.
3909         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
3910
3911 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
3912
3913         Add myself to reviewers.py
3914         https://bugs.webkit.org/show_bug.cgi?id=111757
3915
3916         Reviewed by Eric Seidel.
3917
3918         * Scripts/webkitpy/common/config/committers.py:
3919
3920 2013-03-07  Glenn Adams  <glenn@skynav.com>
3921
3922         run-perf-tests should have a --repeat option
3923         https://bugs.webkit.org/show_bug.cgi?id=100030
3924
3925         Reviewed by Ryosuke Niwa.
3926
3927         Add --repeat option to run-perf-tests, with default value of 1. When greater
3928         than 1, runs test set specified number of times. Note that multiple runs are
3929         not aggregated for statistical purposes.
3930
3931         Incidentally fixed typo: s/suceeds/succeeds/.
3932
3933         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3934         (PerfTestsRunner._parse_args): Add repeat option.
3935         (PerfTestsRunner.run): Add outer repeat loop.
3936         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
3937         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
3938         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3939         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
3940         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
3941         (MainTest.test_run_with_json_output): Fix typo.
3942         (MainTest.test_run_with_description): Fix typo.
3943         (MainTest.test_run_respects_no_results): Fix typo.
3944         (MainTest.test_run_with_slave_config_json): Fix typo.
3945         (MainTest.test_run_with_multiple_repositories): Fix typo.
3946         (MainTest.test_run_with_upload_json): Fix typo.
3947         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
3948         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
3949         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3950         (MainTest.test_parse_args): Add test for repeat option parsing.
3951
3952 2013-03-07  Julie Parent  <jparent@chromium.org>
3953
3954         showAllRuns checkbox no longer works on the stats dashboard
3955         https://bugs.webkit.org/show_bug.cgi?id=111673
3956
3957         Reviewed by Ojan Vafai.
3958
3959         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
3960         so we were trying to index into an undefined object.
3961         
3962         * TestResultServer/static-dashboards/dashboard_base.js:
3963         (invalidateQueryParameters):
3964
3965 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
3966
3967         [Chromium] Update #include for WebStorageNamespace.h
3968         https://bugs.webkit.org/show_bug.cgi?id=111748
3969
3970         Reviewed by Adam Barth.
3971
3972         In anticipation of removing
3973         WK/chromium/public/WebStorageNamespace.h (once downstream
3974         references have been updated)
3975
3976         * DumpRenderTree/chromium/WebViewHost.cpp:
3977
3978 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3979
3980         run-perf-tests fails due to svn_revision not working on a pure git clone
3981         https://bugs.webkit.org/show_bug.cgi?id=110839
3982
3983         Reviewed by Ryosuke Niwa.
3984
3985         Previously we would call git svn find-rev to look up the commit for
3986         a given revision, and that'll hang in a pure git checkout.
3987
3988         This patch changes the way we look up svn revisions in a git
3989         repository to use git log --grep 'git-svn-id', which is much faster
3990         than grepping ourselves. It also renames timestamp_of_latest_commit()
3991         to timestamp_of_revision() in order to accurately reflect what
3992         the method is doing. Note that this patch only changes the logic
3993         inside latest_revision() and svn_revision(). I'll file a separate
3994         bug to change git_commit_from_svn_revision().
3995
3996         This patch also contains some fixes to unit tests that had bit-rotted
3997         or were otherwise fragile, so that test-webkitpy --all would pass
3998         cleanly, and a fix to outputcapture so that
3999         test-webkitpy -p would work correctly again.
4000
4001         * Scripts/webkitpy/common/checkout/scm/git.py:
4002         (Git.svn_revision):
4003         (Git.timestamp_of_revision):
4004         * Scripts/webkitpy/common/checkout/scm/scm.py:
4005         (SCM.svn_revision):
4006         (SCM.timestamp_of_revision):
4007         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
4008         (MockSCM.timestamp_of_revision):
4009         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4010         (_shared_test_commit_with_message):
4011         (test_commit_without_authorization):
4012         (test_timestamp_of_revision):
4013         * Scripts/webkitpy/common/checkout/scm/svn.py:
4014         (SVN.timestamp_of_revision):
4015         * Scripts/webkitpy/common/system/outputcapture.py:
4016           Importing unittest2 directly may not be safe if this module is
4017           imported before the autoinstaller gets a chance to set things up
4018           properly. We don't actually need unittest2 here.
4019         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4020         (PerfTestsRunner._generate_results_dict):
4021
4022 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4023
4024         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
4025         https://bugs.webkit.org/show_bug.cgi?id=111756
4026
4027         Reviewed by Kenneth Rohde Christiansen.
4028
4029         Bump libsoup to v2.40.3 to fix the regressions introduced by
4030         previous v2.40.0 bump.
4031
4032         * efl/jhbuild.modules:
4033
4034 2013-03-07  Roger Fong  <roger_fong@apple.com>
4035
4036         Re-enable Win EWS tests.
4037
4038         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4039         (WinEWS):
4040
4041 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
4042
4043         [nrwt] handle corrupt http server pid files cleanly
4044         https://bugs.webkit.org/show_bug.cgi?id=111628
4045
4046         Reviewed by Eric Seidel.
4047
4048         If the pid file from a previous http server is corrupt for some
4049         reason, NRWT will just raise errors and not clean it up or recover.
4050         This patch fixes that to at least delete the pid file and
4051         not throw; not that we may still have stale http servers left on
4052         the system, since there's no way to know which pid to kill if
4053         the file was corrupted.
4054
4055         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
4056         (HttpServerBase.start):
4057         (HttpServerBase.stop):
4058         (HttpServerBase._remove_pid_file):
4059         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
4060         (TestHttpServerBase):
4061         (TestHttpServerBase.test_corrupt_pid_file):
4062
4063 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
4064
4065         AX: Can't activate links with VoiceOver in Safari
4066         https://bugs.webkit.org/show_bug.cgi?id=111755
4067
4068         Reviewed by Tim Horton.
4069
4070         * DumpRenderTree/AccessibilityUIElement.cpp:
4071         (supportedActionsCallback):
4072         (AccessibilityUIElement::getJSClass):
4073         * DumpRenderTree/AccessibilityUIElement.h:
4074         (AccessibilityUIElement):
4075         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4076         (AccessibilityUIElement::supportedActions):
4077
4078 2013-03-07  Roger Fong  <roger_fong@apple.com>
4079
4080         Windows debug layout tests are crashing like crazy again.
4081         Disable tests on Win EWS bots temporarily.
4082
4083         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4084         (WinEWS):
4085
4086 2013-03-07  Roger Fong  <roger_fong@apple.com>
4087
4088         Make EWS bots build and test in release.
4089
4090         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4091         (WinEWS):
4092         * Scripts/webkitpy/tool/steps/runtests.py:
4093         (RunTests.run):
4094
4095 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
4096
4097         [chromium] don't track the top loading frame if no layout test is currently running
4098         https://bugs.webkit.org/show_bug.cgi?id=111716
4099
4100         Reviewed by Kentaro Hara.
4101
4102         In DRT, we synchronously stop the test and start loading the next test
4103         URL. However, in content_shell, this happens asynchronously. It's
4104         important that the top loading frame is not changed due to stray
4105         navigation events before the next test starts.
4106
4107         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4108         (WebTestRunner::TestRunner::setTopLoadingFrame):
4109
4110 2013-03-06  Julie Parent  <jparent@chromium.org>
4111
4112         Dashboard cleanup: Move all dashboard ui related code into ui.js.
4113         https://bugs.webkit.org/show_bug.cgi?id=111621
4114
4115         Reviewed by Ojan Vafai.
4116         
4117         Creates ui.js, a package for the common UI code the various
4118         dashboards use. HTML generation is now in the ui.html namespace
4119         and popup handling is in ui.popup.
4120         Also moves the event listening for popups to ui.popup.show and
4121         removes it on ui.popup.hid rather than having listener always
4122         around.
4123
4124         * TestResultServer/static-dashboards/aggregate_results.html:
4125         * TestResultServer/static-dashboards/dashboard_base.js:
4126         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4127         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4128         (showPopupForBuild):
4129         (htmlForNavBar):
4130         (generatePageForIndividualTests.if):
4131         (generatePageForIndividualTests):
4132         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
4133         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4134         * TestResultServer/static-dashboards/run-embedded-unittests.html:
4135         * TestResultServer/static-dashboards/run-unittests.html:
4136         * TestResultServer/static-dashboards/timeline_explorer.html:
4137         * TestResultServer/static-dashboards/treemap.html:
4138         * TestResultServer/static-dashboards/ui.js: Added.
4139         (.):
4140
4141 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
4142
4143         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
4144         https://bugs.webkit.org/show_bug.cgi?id=110584
4145
4146         Reviewed by Gyuyoung Kim.
4147
4148         Adds missing implementation of AccessibilityControllerEfl
4149         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
4150         so that it can make accessibilityController as a js object.
4151
4152         * DumpRenderTree/AccessibilityController.h:
4153         (AccessibilityController):
4154         * DumpRenderTree/AccessibilityUIElement.h:
4155         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
4156         (AccessibilityController::childElementById): Moved declaration to base class.
4157         Implementation can be shared among other ports.
4158         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
4159         (AccessibilityController::focusedElement):
4160         (AccessibilityController::rootElement):
4161         (AccessibilityController::accessibleElementById):
4162         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
4163         (AccessibilityUIElement::helpText):
4164         * DumpRenderTree/efl/CMakeLists.txt:
4165         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4166         (DumpRenderTreeChrome::DumpRenderTreeChrome):
4167         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4168         (DumpRenderTreeChrome::onWindowObjectCleared):
4169         (DumpRenderTreeChrome::accessibilityController):
4170         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
4171         (DumpRenderTreeChrome):
4172         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
4173
4174 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
4175
4176         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
4177         https://bugs.webkit.org/show_bug.cgi?id=42696
4178
4179         Reviewed by Andreas Kling.
4180
4181         * DumpRenderTree/TestRunner.cpp:
4182         (TestRunner::staticFunctions):
4183         * DumpRenderTree/TestRunner.h:
4184         (TestRunner):
4185         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4186         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4187         (WebTestRunner::TestRunner::TestRunner):
4188         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4189         (TestRunner):
4190         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4191         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4192         * DumpRenderTree/mac/TestRunnerMac.mm:
4193         * DumpRenderTree/qt/TestRunnerQt.cpp:
4194         * DumpRenderTree/qt/TestRunnerQt.h:
4195         (TestRunnerQt):
4196         * DumpRenderTree/win/TestRunnerWin.cpp:
4197         * DumpRenderTree/wx/TestRunnerWx.cpp:
4198
4199 2013-03-06  Roger Fong  <roger_fong@apple.com>
4200
4201         Re-enable WinEWS test and decrease iterations before clean build back to 10.
4202
4203         * EWSTools/start-queue-win.sh:
4204         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4205         (WinEWS):
4206
4207 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
4208
4209         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
4210         https://bugs.webkit.org/show_bug.cgi?id=82866
4211
4212         Reviewed by Martin Robinson.
4213
4214         * Scripts/run-gtk-tests:
4215         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
4216         it is passing now.
4217
4218 2013-03-06  Julie Parent  <jparent@chromium.org>
4219
4220         Dashboard cleanup: remove dashboard time logging.
4221         https://bugs.webkit.org/show_bug.cgi?id=111608
4222
4223         Reviewed by Dirk Pranke.
4224
4225         Remove logTime.  It was never accurate, and the dev tools
4226         have better ways to measure this if anyone cares to look
4227         into dashboard perf.
4228         
4229         * TestResultServer/static-dashboards/dashboard_base.js:
4230         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4231         (processTestRunsForBuilder):
4232         (appendHTML):
4233
4234 2013-03-06  Tony Chang  <tony@chromium.org>
4235
4236         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
4237         https://bugs.webkit.org/show_bug.cgi?id=111509
4238
4239         Reviewed by Dirk Pranke.
4240
4241         Add DumpRenderTree.pak to DumpRenderTree.app again.
4242
4243         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4244
4245 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
4246
4247         [chromium] introduce WebUserGestureIndicator
4248         https://bugs.webkit.org/show_bug.cgi?id=111531
4249
4250         Reviewed by Adam Barth.
4251
4252         * DumpRenderTree/chromium/WebViewHost.cpp:
4253         (WebViewHost::createView):
4254
4255 2013-03-06  Alan Cutter  <alancutter@chromium.org>
4256
4257         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
4258         https://bugs.webkit.org/show_bug.cgi?id=73482
4259
4260         Reviewed by Ryosuke Niwa.
4261
4262         Added input checking to the UpdateChromiumDEPS step.
4263         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
4264
4265         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
4266         (RollChromiumDEPS):
4267         (RollChromiumDEPS._parse_args):
4268         (RollChromiumDEPS.execute):
4269         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
4270         (IRCCommandTest.test_roll_chromium_deps):
4271         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
4272         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
4273         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
4274         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
4275         (UpdateChromiumDEPS._fetch_last_known_good_revision):
4276         (UpdateChromiumDEPS):
4277         (UpdateChromiumDEPS._parse_revision_number):
4278         (UpdateChromiumDEPS._validate_revisions):
4279         (UpdateChromiumDEPS.run):
4280         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.