Send delayed Ad Click Attribution conversion requests to the click source
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-15  John Wilander  <wilander@apple.com>
2
3         Send delayed Ad Click Attribution conversion requests to the click source
4         https://bugs.webkit.org/show_bug.cgi?id=196838
5         <rdar://problem/47650157>
6
7         Reviewed by Chris Dumez and Youenn Fablet.
8
9         This patch adds test infrastructure to override the default behavior in
10         WebKit::NetworkAdClickAttribution.
11
12         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
13         (TestWebKitAPI::TEST):
14         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
15         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
16         (WTR::TestRunner::dumpAdClickAttribution):
17         (WTR::TestRunner::clearAdClickAttribution):
18         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
19         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
20         * WebKitTestRunner/InjectedBundle/TestRunner.h:
21         * WebKitTestRunner/TestController.cpp:
22         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
23         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
24         * WebKitTestRunner/TestController.h:
25         * WebKitTestRunner/TestInvocation.cpp:
26         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
27
28 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
29
30         [ews-app] status-bubble should display position in queue
31         https://bugs.webkit.org/show_bug.cgi?id=196607
32
33         Reviewed by Lucas Forschler.
34
35         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
36         (StatusBubble._build_bubble):
37         (StatusBubble._queue_position): Method to calculate patch's position in queue.
38
39 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
40
41         [ews-build] Do not run clean build by default on EWS builders
42         https://bugs.webkit.org/show_bug.cgi?id=196897
43
44         Reviewed by Lucas Forschler.
45
46         * BuildSlaveSupport/ews-build/steps.py:
47         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
48         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
49         untracked directories like WebKitBuild).
50         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
51         untracked files/directories (like WebKitBuild).
52
53 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
54
55         TestRunner::notifyDone() should be safely reentrant
56         https://bugs.webkit.org/show_bug.cgi?id=196898
57
58         Reviewed by Darin Adler.
59
60         It is currently possible that TestRunner::notifyDone() will call itself, since
61         notifyDone() will force a repaint, which can start executing JavaScript, which
62         may call notifyDone() again. This can lead to test failures and flakiness.
63         Fix this by setting the m_waitToDump flag before calling the dump() method.
64
65         * DumpRenderTree/mac/TestRunnerMac.mm:
66         (TestRunner::notifyDone):
67         (TestRunner::forceImmediateCompletion):
68         * DumpRenderTree/win/TestRunnerWin.cpp:
69         (TestRunner::notifyDone):
70         (TestRunner::forceImmediateCompletion):
71
72 2019-04-15  Philippe Normand  <pnormand@igalia.com>
73
74         [GTK][WPE] Add enable-media websetting
75         https://bugs.webkit.org/show_bug.cgi?id=196863
76
77         Reviewed by Michael Catanzaro.
78
79         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
80         (testWebKitSettings): Add test for the enable-media web-setting.
81
82 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
83
84         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
85         https://bugs.webkit.org/show_bug.cgi?id=196905
86         <rdar://problem/49886096>
87
88         Reviewed by Tim Horton.
89
90         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
91         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
92         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
93         delay timer, we end up with this sequence of events in the problematic (failure) case:
94
95         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
96             ...IPC from UI to web process...
97         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
98             ...IPC from web to UI process...
99         (c) [UI]    Invoke completion handler for script #1
100         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
101             ...IPC from UI to web process...
102         (e) [Web]   Evaluate script #2 in the web process
103         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
104
105         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
106         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
107         #2 is run in step (e).
108
109         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
110         the UI process by waiting on a script message posted by the web process, after attachment updates are
111         dispatched.
112
113         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
114         (TestWebKitAPI::TEST):
115
116 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
117
118         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
119         https://bugs.webkit.org/show_bug.cgi?id=196909
120
121         Reviewed by Wenson Hsieh.
122
123         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
124         (TestWebKitAPI::TEST):
125
126 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
127
128         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
129         https://bugs.webkit.org/show_bug.cgi?id=196880
130
131         Reviewed by Yusuke Suzuki.
132
133         Add a new function for bytecode cache tests that does not forceDiskCache
134         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
135         test added in this patch, since the code is invalid and therefore won't be
136         cached. It should also be useful for tests that evaluate dynamically
137         generated code.
138
139         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
140         * Scripts/run-jsc-stress-tests:
141
142 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
143
144         Update AudioSession route sharing policy
145         https://bugs.webkit.org/show_bug.cgi?id=196776
146         <rdar://problem/46501611>
147
148         Reviewed by Jer Noble.
149
150         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
151         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
152         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
153         (TestWebKitAPI::TEST):
154
155 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
156
157         [iOS] Software keyboard is shown too frequently on some websites
158         https://bugs.webkit.org/show_bug.cgi?id=195856
159         <rdar://problem/49191395>
160
161         Reviewed by Darin Adler.
162
163         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
164
165         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
166         (WTR::UIScriptController::setHardwareKeyboardAttached):
167         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
168         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
169         (WTR::UIScriptController::setHardwareKeyboardAttached):
170         * TestRunnerShared/UIScriptContext/UIScriptController.h:
171         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
172
173         Additionally link against GraphicsServices in WebKitTestRunner.
174
175         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
176         (WTR::TestController::platformResetStateToConsistentValues):
177         (WTR::UIScriptController::setHardwareKeyboardAttached):
178
179 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
180
181         [GTK][WPE] Fix pacman install-dependencies packages
182         https://bugs.webkit.org/show_bug.cgi?id=196817
183
184         Reviewed by Žan Doberšek.
185         
186         python3-setuptools is called python-setuptools
187         ruby-highline is only available on AUR
188         libv4l-devel is incorporated in v4l-utils
189
190         * gtk/install-dependencies:
191         * wpe/install-dependencies:
192
193 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
194
195         [GTK] REGRESSION(r243860): Many tests failing
196         https://bugs.webkit.org/show_bug.cgi?id=196791
197
198         Reviewed by Joanmarie Diggs.
199
200         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
201         multiple documents and check that accessibility hierarchy is updated after a navigation.
202
203         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
204         (loadChangedCallback):
205         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
206         (AccessibilityTest::AccessibilityTest):
207         (AccessibilityTest::~AccessibilityTest):
208         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
209         (AccessibilityTest::findTestServerApplication):
210         (AccessibilityTest::findDocumentWeb):
211         (AccessibilityTest::findRootObject):
212         (AccessibilityTest::waitUntilChildrenRemoved):
213         (AccessibilityTest::ensureProxy):
214         (testAtspiBasicHierarchy):
215         (beforeAll):
216         (afterAll):
217
218 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
219
220         [ews-build] Handle bug titles with unicode characters
221         https://bugs.webkit.org/show_bug.cgi?id=196802
222
223         Reviewed by Dewei Zhu.
224
225         * BuildSlaveSupport/ews-build/steps.py:
226         (ValidatePatch._is_bug_closed):
227
228 2019-04-11  Michael Saboff  <msaboff@apple.com>
229
230         Improve the Inline Cache Stats code
231         https://bugs.webkit.org/show_bug.cgi?id=196836
232
233         Reviewed by Saam Barati.
234
235         Added a new script to consolidate and arrange the output of --useICStats option.
236
237         This script merges the output from every group into one large table and sorts it from most common to
238         least common.  It also counts the slow path GetById and PutById variants and then calculates the
239         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
240         Put together, this is useful to see what property accesses are not getting cached.
241
242         * Scripts/ic-stats.py: Added.
243         (ICStats):
244         (ICStats.__init__):
245         (ICStats.parse):
246         (ICStats.dumpStats):
247         (usage):
248
249 2019-04-10  Alex Christensen  <achristensen@webkit.org>
250
251         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
252         https://bugs.webkit.org/show_bug.cgi?id=196809
253         <rdar://49800762>
254
255         Reviewed by Brady Eidson.
256
257         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
258         (TEST):
259
260 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
261
262         requestAnimationFrame should execute before the next frame
263         https://bugs.webkit.org/show_bug.cgi?id=177484
264
265         Reviewed by Simon Fraser.
266
267         Add trace points for the page RenderingUpdate.
268
269         * Tracing/SystemTracePoints.plist:
270
271 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
272
273         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
274         https://bugs.webkit.org/show_bug.cgi?id=196760
275
276         Reviewed by Don Olmstead.
277
278         vswhere.exe has been bundled since Visual Studio 2017 version
279         15.2. We shouldn't download vswhere.exe.
280
281         * Scripts/build-jsc: Do not call update-vswhere.py.
282         * Scripts/build-webkit: Ditto.
283         * Scripts/update-vswhere.py: Removed.
284         * Scripts/webkitdirs.pm:
285         (requireModulesForVSWhere): Deleted.
286         (pickCurrentVisualStudioInstallation): Deleted.
287         (visualStudioInstallDirVSWhere): Return the latest installed VS
288         installation path by using the bundled vswhere.exe.
289         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
290         (visualStudioInstallDirFallback): Removed.
291
292 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
293
294         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
295         https://bugs.webkit.org/show_bug.cgi?id=196780
296
297         Reviewed by Alexey Proskuryakov.
298
299         * BuildSlaveSupport/ews-build/steps.py:
300         * BuildSlaveSupport/ews-build/steps_unittest.py:
301
302 2019-04-10  Alex Christensen  <achristensen@webkit.org>
303
304         Add SPI WKNavigationResponse._downloadAttribute
305         https://bugs.webkit.org/show_bug.cgi?id=196755
306         <rdar://49587365>
307
308         Reviewed by Brady Eidson.
309
310         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
311         (-[NavigationResponseTestDelegate navigationResponse]):
312         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
313         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
314         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
315         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
316         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
317         (readRequest):
318         (writeResponse):
319         (TEST):
320
321 2019-04-10  Tim Horton  <timothy_horton@apple.com>
322
323         Add modern API for overriding the page's specified viewport configuration
324         https://bugs.webkit.org/show_bug.cgi?id=167734
325         <rdar://problem/30331795>
326
327         Reviewed by Simon Fraser.
328
329         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
330         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
331
332 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
333
334         Add support for incremental bytecode cache updates
335         https://bugs.webkit.org/show_bug.cgi?id=195000
336
337         Reviewed by Filip Pizlo.
338
339         Exit when the initial run to generate bytecode fails.
340
341         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
342
343 2019-04-10  Alex Christensen  <achristensen@webkit.org>
344
345         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
346         https://bugs.webkit.org/show_bug.cgi?id=196744
347         <rdar://49415309>
348
349         Reviewed by Chris Dumez.
350
351         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
352         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
353
354 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
355
356         Add a way to opt into modern compatibility mode in layout tests
357         https://bugs.webkit.org/show_bug.cgi?id=196770
358         <rdar://problem/49777550>
359
360         Reviewed by Antoine Quint.
361
362         Add a new test option to enable modern compatibility mode in layout tests.
363
364         * WebKitTestRunner/TestController.cpp:
365         (WTR::updateTestOptionsFromTestHeader):
366         * WebKitTestRunner/TestController.h:
367         * WebKitTestRunner/TestOptions.h:
368         (WTR::TestOptions::hasSameInitializationOptions const):
369         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
370         (WTR::TestController::platformCreateWebView):
371         (WTR::TestController::enableModernCompatibilityMode):
372
373 2019-04-10  Andy Estes  <aestes@apple.com>
374
375         Try to fix the 32-bit watchOS build.
376
377         * TestWebKitAPI/cocoa/TestWKWebView.mm:
378         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
379
380 2019-04-10  Antoine Quint  <graouts@apple.com>
381
382         Enable Pointer Events on watchOS
383         https://bugs.webkit.org/show_bug.cgi?id=196771
384         <rdar://problem/49040909>
385
386         Reviewed by Dean Jackson.
387
388         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
389
390 2019-04-10  Philippe Normand  <pnormand@igalia.com>
391
392         Unreviewed. Fix WPE accessibility tests after r244059.
393
394         We are failing to load the injected bundle due to undefined symbol
395         AccessibilityUIElement::replaceTextInRange().
396
397         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
398         (WTR::AccessibilityUIElement::replaceTextInRange):
399
400 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
401
402         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
403         https://bugs.webkit.org/show_bug.cgi?id=196727
404
405         Reviewed by Fujii Hironori.
406
407         * MiniBrowser/win/WebKitBrowserWindow.cpp:
408         (WebKitBrowserWindow::create):
409
410 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
411
412         [ews-build] Add unit tests for PrintConfiguration
413         https://bugs.webkit.org/show_bug.cgi?id=196752
414
415         Reviewed by Dewei Zhu.
416
417         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
418
419 2019-04-09  Keith Rollin  <krollin@apple.com>
420
421         Unreviewed build maintenance -- update .xcfilelists.
422
423         * DumpRenderTree/DerivedSources-input.xcfilelist:
424         * DumpRenderTree/DerivedSources-output.xcfilelist:
425
426 2019-04-09  Zalan Bujtas  <zalan@apple.com>
427
428         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
429         https://bugs.webkit.org/show_bug.cgi?id=196743
430         <rdar://problem/43897551>
431
432         Reviewed by Tim Horton.
433
434         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
435         (TEST):
436
437 2019-04-09  Youenn Fablet  <youenn@apple.com>
438
439         Close service worker database on network process suspension
440         https://bugs.webkit.org/show_bug.cgi?id=196623
441         <rdar://problem/48930869>
442
443         Reviewed by Alex Christensen.
444
445         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
446
447 2019-04-09  Daniel Bates  <dabates@apple.com>
448
449         [iPad] Should open popover when the spacebar is pressed
450         https://bugs.webkit.org/show_bug.cgi?id=196360
451         <rdar://problem/49389129>
452
453         Reviewed by Brent Fulgham.
454
455         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
456
457         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
458         (WTR::UIScriptController::isShowingPopover const): Added.
459         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
460         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
461         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
462         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
463         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
464         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
465         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
466         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
467         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
468         (WTR::UIScriptController::isShowingPopover const): Added.
469         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
470         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
471         * TestRunnerShared/UIScriptContext/UIScriptController.h:
472         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
473         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
474         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
475         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
476         (-[TestRunnerWKWebView _willPresentPopover]): Added.
477         (-[TestRunnerWKWebView _didDismissPopover]): Added.
478         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
479         (WTR::UIScriptController::isShowingPopover const): Added.
480         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
481         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
482
483 2019-04-09  Alex Christensen  <achristensen@webkit.org>
484
485         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
486         https://bugs.webkit.org/show_bug.cgi?id=196665
487         <rdar://45115669>
488
489         Reviewed by Geoff Garen.
490
491         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
492         (goBack):
493         (+[SimpleLookupContext sharedLookupContext]):
494         (-[SimpleLookupContext lookUpURL:completionHandler:]):
495         (TEST):
496         (+[Simple3LookupContext sharedLookupContext]): Deleted.
497         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
498
499 2019-04-09  John Wilander  <wilander@apple.com>
500
501         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
502         https://bugs.webkit.org/show_bug.cgi?id=196558
503         <rdar://problem/47650245>
504
505         Reviewed by Youenn Fablet.
506
507         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
508         (TestWebKitAPI::TEST):
509             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
510
511 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
512
513         [CMake] Apple builds should use ICU_INCLUDE_DIRS
514         https://bugs.webkit.org/show_bug.cgi?id=196720
515
516         Reviewed by Konstantin Tokarev.
517
518         * TestWebKitAPI/PlatformMac.cmake:
519
520 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
521
522         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
523         https://bugs.webkit.org/show_bug.cgi?id=196694
524         <rdar://problem/48388734>
525
526         Rubber-stamped by Aakash Jain.
527
528         * Scripts/webkitpy/port/image_diff.py:
529         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
530         * Scripts/webkitpy/port/server_process.py:
531         (ServerProcess.has_available_stdout): Check if stdout has data in it.
532         (ServerProcess._wait_for_data_and_update_buffers_using_select):
533         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
534         * Scripts/webkitpy/port/server_process_mock.py:
535         (MockServerProcess.has_available_stdout):
536         * Scripts/webkitpy/port/server_process_unittest.py:
537         (TestServerProcess.serial_test_basic):
538
539 2019-04-09  Jer Noble  <jer.noble@apple.com>
540
541         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
542         https://bugs.webkit.org/show_bug.cgi?id=196097
543
544         Reviewed by Eric Carlson.
545
546         Drive-by bug fix: allow tests to play audio without a user gesture by default.
547
548         * DumpRenderTree/mac/DumpRenderTree.mm:
549         (resetWebPreferencesToConsistentValues):
550         * WebKitTestRunner/TestController.cpp:
551         (WTR::TestController::resetPreferencesToConsistentValues):
552
553 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
554
555         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
556         https://bugs.webkit.org/show_bug.cgi?id=196690
557
558         Reviewed by Michael Catanzaro.
559
560         * QueueStatusServer/config/queues.py:
561         * Scripts/webkitpy/common/config/ews.json:
562         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
563         (test_ews_name):
564
565 2019-04-09  Chris Dumez  <cdumez@apple.com>
566
567         Loads using loadHTMLString() cause flashing when process-swapping
568         https://bugs.webkit.org/show_bug.cgi?id=196714
569         <rdar://problem/49637354>
570
571         Reviewed by Antti Koivisto.
572
573         Add API test coverage.
574
575         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
576
577 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
578
579         Unreviewed. Fix ATK accessibility tests after r244059.
580
581         We are failing to load the injected bundle due to undefined symbol
582         AccessibilityUIElement::replaceTextInRange().
583
584         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
585         (WTR::AccessibilityUIElement::replaceTextInRange):
586
587 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
588
589         AX: Support API: accessibilityReplaceRange:withText
590         https://bugs.webkit.org/show_bug.cgi?id=196636
591
592         Unreviewed build fix for Windows port.
593
594         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
595         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
596
597 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
598
599         [CMake][WinCairo] Separate copied headers into different directories
600         https://bugs.webkit.org/show_bug.cgi?id=196655
601
602         Reviewed by Michael Catanzaro.
603
604         * DumpRenderTree/CMakeLists.txt:
605         * MiniBrowser/win/CMakeLists.txt:
606         * TestWebKitAPI/CMakeLists.txt:
607         * TestWebKitAPI/PlatformWin.cmake:
608
609 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
610
611         Log stack-trace for run-webkit-tests when interrupted
612         https://bugs.webkit.org/show_bug.cgi?id=176393
613         <rdar://problem/34262310>
614
615         Reviewed by Lucas Forschler.
616
617         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
618         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
619         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
620         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
621         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
622         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
623         (main): Set handlers to log stack trace on interruption.
624
625 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
626
627         AX: Support API: accessibilityReplaceRange:withText
628         https://bugs.webkit.org/show_bug.cgi?id=196636
629
630         Unreviewed build fix for Windows port.
631
632         * DumpRenderTree/AccessibilityUIElement.cpp:
633         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
634
635 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
636
637         [ews-build] Scripts using Buildbot API have CORS error
638         https://bugs.webkit.org/show_bug.cgi?id=196709
639
640         Reviewed by Alexey Proskuryakov.
641
642         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
643
644 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
645
646         AX: Support API: accessibilityReplaceRange:withText
647         https://bugs.webkit.org/show_bug.cgi?id=196636
648
649         Reviewed by Daniel Bates.
650
651         * DumpRenderTree/AccessibilityUIElement.cpp:
652         (replaceTextInRangeCallback):
653         (AccessibilityUIElement::replaceTextInRange):
654         (AccessibilityUIElement::getJSClass):
655         * DumpRenderTree/AccessibilityUIElement.h:
656         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
657         (AccessibilityUIElement::replaceTextInRange):
658         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
659         (AccessibilityUIElement::replaceTextInRange):
660         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
661         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
662         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
663         (WTR::AccessibilityUIElement::replaceTextInRange):
664         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
665         (WTR::AccessibilityUIElement::replaceTextInRange):
666
667 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
668
669         [iOS] Do not allow starting selection drags when selection views are not visible
670         https://bugs.webkit.org/show_bug.cgi?id=196686
671         <rdar://problem/49399192>
672
673         Reviewed by Tim Horton.
674
675         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
676         also add some new API tests to cover scenarios where the web view is not first responder.
677
678         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
679         (TestWebKitAPI::TEST):
680         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
681
682         Add a switch to optionally make the web view first responder when starting the simulated drag.
683
684         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
685         (-[DragAndDropSimulator initWithWebView:]):
686         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
687
688 2019-04-08  Justin Fan  <justin_fan@apple.com>
689
690         [Web GPU] Fix Web GPU experimental feature on iOS
691         https://bugs.webkit.org/show_bug.cgi?id=196632
692
693         Reviewed by Myles C. Maxfield.
694
695         Properly make Web GPU available on iOS 11+.
696
697         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
698
699 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
700
701         [ews-build] Do not upload archive when Compile Fails
702         https://bugs.webkit.org/show_bug.cgi?id=196674
703
704         Reviewed by Alexey Proskuryakov.
705
706         * BuildSlaveSupport/ews-build/factories.py:
707         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
708         * BuildSlaveSupport/ews-build/steps.py:
709         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
710         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
711         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
712
713 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
714
715         Enable DFG on MIPS
716         https://bugs.webkit.org/show_bug.cgi?id=196689
717
718         Reviewed by Žan Doberšek.
719
720         Since the bytecode change, we enabled the baseline JIT on mips in
721         r240432, but DFG is still missing. With this change, all tests are
722         passing on a ci20 board.
723
724         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
725
726 2019-04-08  Philippe Normand  <pnormand@igalia.com>
727
728         [Flatpak] Second run update-webkitwpe-flatpak fails
729         https://bugs.webkit.org/show_bug.cgi?id=192702
730
731         Reviewed by Carlos Garcia Campos.
732
733         * flatpak/flatpakutils.py:
734         (FlatpakObject.flatpak): Fix typo.
735         (FlatpakPackage.install): When installing, also update to the configured remote commit.
736         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
737
738 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
739
740         [GTK][WPE] outlook.live.com displays old-fashioned UI
741         https://bugs.webkit.org/show_bug.cgi?id=196642
742
743         Reviewed by Carlos Garcia Campos.
744
745         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
746         (TestWebKitAPI::TEST): New Mac platform quirk test.
747
748 2019-04-07  Commit Queue  <commit-queue@webkit.org>
749
750         Unreviewed, rolling out r243956.
751         https://bugs.webkit.org/show_bug.cgi?id=196688
752
753         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
754         by aakashjain on #webkit).
755
756         Reverted changeset:
757
758         "Clicking "Go Back" from a safe browsing warning from an
759         iframe should navigate the WKWebView back to the previous
760         page"
761         https://bugs.webkit.org/show_bug.cgi?id=196665
762         https://trac.webkit.org/changeset/243956
763
764 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
765
766         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
767         https://bugs.webkit.org/show_bug.cgi?id=196669
768
769         Reviewed by Geoffrey Garen.
770
771         Added three new unit tests for WeakHashSet.
772
773         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
774         (WTF_WeakPtr.WeakHashSetConstObjects):
775         (WTF_WeakPtr.WeakHashSetComputesEmpty):
776         (WTF_WeakPtr.WeakHashSetComputeSize):
777
778 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
779
780         Hide next and previous form control buttons when WKWebView is editable
781         https://bugs.webkit.org/show_bug.cgi?id=196672
782         <rdar://problem/35625321>
783
784         Reviewed by Tim Horton.
785
786         Add a new API test.
787
788         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
789         (-[TestWKWebView lastTrailingBarButtonGroup]):
790         (TestWebKitAPI::TEST):
791         * TestWebKitAPI/ios/UIKitSPI.h:
792
793 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
794
795         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
796         https://bugs.webkit.org/show_bug.cgi?id=196077
797         <rdar://problem/49108202>
798
799         Reviewed by Chris Dumez.
800
801         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
802         on new web view.
803
804         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
805
806 2019-04-05  Saam Barati  <sbarati@apple.com>
807
808         Make compare-results understand MotionMark
809         https://bugs.webkit.org/show_bug.cgi?id=196666
810
811         Reviewed by Yusuke Suzuki.
812
813         * Scripts/compare-results:
814         (PLT5Results):
815         (detectMotionMark):
816         (detectMotionMark1_1):
817         (motionMarkResults):
818         (motionMark1_1Results):
819         (detectBenchmark):
820         (biggerIsBetter):
821         (main):
822
823 2019-04-05  Alex Christensen  <achristensen@webkit.org>
824
825         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
826         https://bugs.webkit.org/show_bug.cgi?id=196665
827         <rdar://45115669>
828
829         Reviewed by Geoff Garen.
830
831         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
832         (goBack):
833         (+[SimpleLookupContext sharedLookupContext]):
834         (-[SimpleLookupContext lookUpURL:completionHandler:]):
835         (TEST):
836         (+[Simple3LookupContext sharedLookupContext]): Deleted.
837         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
838
839 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
840
841         [ews-build] Add configuration and architecture for windows builders
842         https://bugs.webkit.org/show_bug.cgi?id=196660
843
844         Reviewed by Lucas Forschler.
845
846         * BuildSlaveSupport/ews-build/config.json:
847
848 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
849
850         webkitpy: Don't run subsequent rounds if interrupted
851         https://bugs.webkit.org/show_bug.cgi?id=196646
852
853         Reviewed by Aakash Jain.
854
855         * Scripts/webkitpy/layout_tests/controllers/manager.py:
856         (Manager.run): Bail out if interrupted.
857
858 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
859
860         Test sessionStorage in PSON private browsing mode
861         https://bugs.webkit.org/show_bug.cgi?id=196561
862
863         Reviewed by Alex Christensen.
864
865         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
866
867 2019-04-05  Commit Queue  <commit-queue@webkit.org>
868
869         Unreviewed, rolling out r243833.
870         https://bugs.webkit.org/show_bug.cgi?id=196645
871
872         This change breaks build of WPE and GTK ports (Requested by
873         annulen on #webkit).
874
875         Reverted changeset:
876
877         "[CMake][WTF] Mirror XCode header directories"
878         https://bugs.webkit.org/show_bug.cgi?id=191662
879         https://trac.webkit.org/changeset/243833
880
881 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
882
883         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
884         https://bugs.webkit.org/show_bug.cgi?id=196635
885
886         Reviewed by Antti Koivisto.
887         
888         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
889         for a test to enable async frame scrolling via:
890             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
891         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
892         
893         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
894
895         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
896         (WTR::InjectedBundle::beginTesting):
897         * WebKitTestRunner/TestController.cpp:
898         (WTR::TestController::resetPreferencesToConsistentValues):
899
900 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
901
902         Use a correct LC_RPATH when building with ASan
903         https://bugs.webkit.org/show_bug.cgi?id=196576
904
905         Reviewed by David Kilzer.
906
907         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
908         so that ../Frameworks is checked. This is simpler and more reliable than updating
909         each SPC service xcconfig.
910
911 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
912
913         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
914         https://bugs.webkit.org/show_bug.cgi?id=196629
915
916         Reviewed by Lucas Forschler.
917
918         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
919
920 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
921
922         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
923         https://bugs.webkit.org/show_bug.cgi?id=196618
924
925         Reviewed by Lucas Forschler.
926
927         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
928         (StatusBubble): Added QUEUE_TRIGGERS.
929         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
930         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
931         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
932         its parent(builder).
933
934 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
935
936         [ews-app] Status-bubble steps are sometimes displayed in reverse order
937         https://bugs.webkit.org/show_bug.cgi?id=196625
938
939         Reviewed by Lucas Forschler.
940
941         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
942         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
943
944 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
945
946         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
947         https://bugs.webkit.org/show_bug.cgi?id=196630
948
949         Reviewed by Wenson Hsieh.
950
951         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
952
953 2019-04-04  Youenn Fablet  <youenn@apple.com>
954
955         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
956         https://bugs.webkit.org/show_bug.cgi?id=196543
957
958         Reviewed by Alex Christensen.
959
960         * WebKitTestRunner/TestController.cpp:
961         (WTR::TestController::generatePageConfiguration):
962
963 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
964
965         [ews-app] Status bubble should not display skipped buildbot steps
966         https://bugs.webkit.org/show_bug.cgi?id=196584
967
968         Reviewed by Lucas Forschler.
969
970         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
971
972 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
973
974         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
975         https://bugs.webkit.org/show_bug.cgi?id=196620
976
977         Reviewed by Lucas Forschler.
978
979         * BuildSlaveSupport/ews-app/ews/config.py:
980
981 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
982
983         [Win] DumpRenderTreeWatchDog.py is not checked into source
984         https://bugs.webkit.org/show_bug.cgi?id=196567
985         <rdar://problem/49525901>
986
987         Reviewed by Lucas Forschler.
988
989         This script is used on Win EWS bots to terminate hanging DRT processes.
990
991         * EWSTools/dumprendertreewatchdog.py: Added.
992
993 2019-04-04  Chris Dumez  <cdumez@apple.com>
994
995         Unreviewed, roll out r243858 which made tests time out.
996
997         Disable new API tests on Windows instead.
998
999         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1000         (TestWebKitAPI::TEST):
1001
1002 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1003
1004         [ATK] Cleanup WebPageAccessibilityObjectAtk
1005         https://bugs.webkit.org/show_bug.cgi?id=196537
1006
1007         Reviewed by Michael Catanzaro.
1008
1009         Also consider files under atk directories as exceptions for GObject conventions.
1010
1011         * Scripts/webkitpy/style/checkers/cpp.py:
1012         (check_identifier_name_in_declaration):
1013
1014 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1015
1016         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1017         https://bugs.webkit.org/show_bug.cgi?id=196588
1018         <rdar://problem/49365787>
1019
1020         Unreviewed build fix for Windows port.
1021
1022         error C3861: 'kill': identifier not found
1023
1024         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1025         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1026
1027 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1028
1029         [ews-build] Cancel build and similar operations should have authentication
1030         https://bugs.webkit.org/show_bug.cgi?id=196520
1031
1032         Reviewed by Dewei Zhu.
1033
1034         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1035         environment variables.
1036
1037 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1038
1039         [ews-build] Do not trigger queues which are not in production yet
1040         https://bugs.webkit.org/show_bug.cgi?id=196581
1041
1042         Reviewed by Dewei Zhu.
1043
1044         * BuildSlaveSupport/ews-build/config.json:
1045
1046 2019-04-03  Chris Dumez  <cdumez@apple.com>
1047
1048         Unreviewed, fix typo in the name of API test added in r243848.
1049
1050         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1051         (TestWebKitAPI::TEST):
1052
1053 2019-04-03  Chris Dumez  <cdumez@apple.com>
1054
1055         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1056         https://bugs.webkit.org/show_bug.cgi?id=196588
1057         <rdar://problem/49365787>
1058
1059         Reviewed by Ryosuke Niwa.
1060
1061         Add API test coverage.
1062
1063         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1064         (TestWebKitAPI::nullJavaScriptCallback):
1065         (TestWebKitAPI::didCrashCheckFrames):
1066         (TestWebKitAPI::TEST):
1067
1068 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1069
1070         run-webkit-tests: Upload test results (new results database)
1071         https://bugs.webkit.org/show_bug.cgi?id=196577
1072         <rdar://problem/34841155>
1073
1074         Reviewed by Lucas Forschler.
1075
1076         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1077         (Manager.run): Upload results after each device shard, since the configuration will be
1078         different for each device.
1079         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1080         uploaded to a results database.
1081         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1082         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1083
1084 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1085
1086         -apple-trailing-word is needed for browser detection
1087         https://bugs.webkit.org/show_bug.cgi?id=196575
1088
1089         Unreviewed.
1090
1091         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1092
1093 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1094
1095         [CMake][WTF] Mirror XCode header directories
1096         https://bugs.webkit.org/show_bug.cgi?id=191662
1097
1098         Reviewed by Konstantin Tokarev.
1099
1100         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1101         builds.
1102
1103         * CMakeLists.txt:
1104         * DumpRenderTree/CMakeLists.txt:
1105         * DumpRenderTree/PlatformWin.cmake:
1106         * MiniBrowser/win/CMakeLists.txt:
1107         * TestWebKitAPI/CMakeLists.txt:
1108         * TestWebKitAPI/PlatformWin.cmake:
1109         * WebKitTestRunner/PlatformGTK.cmake:
1110         * WebKitTestRunner/PlatformWin.cmake:
1111
1112 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1113
1114         [ews-app] Status bubble should not display certain infrastructure status messages
1115         https://bugs.webkit.org/show_bug.cgi?id=196550
1116
1117         Reviewed by Lucas Forschler.
1118
1119         Do not display the steps which are un-needed for end-user. This information is still avaiable
1120         if the user click on the bubble and look at the Buildbot build.
1121         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1122         (StatusBubble._steps_messages):
1123         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1124
1125 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1126
1127         [ews-build] Use https for sending data to ews-app
1128         https://bugs.webkit.org/show_bug.cgi?id=196492
1129
1130         Reviewed by Lucas Forschler.
1131
1132         * BuildSlaveSupport/ews-build/events.py:
1133
1134 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1135
1136         Remove support for -apple-trailing-word
1137         https://bugs.webkit.org/show_bug.cgi?id=196525
1138
1139         Reviewed by Zalan Bujtas.
1140
1141         This CSS property is nonstandard and not used.
1142
1143         * Scripts/webkitperl/FeatureList.pm:
1144         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1145
1146 2019-04-03  Youenn Fablet  <youenn@apple.com>
1147
1148         Add a test for DOMCache on multiple browsing in case of private browsing
1149         https://bugs.webkit.org/show_bug.cgi?id=196524
1150
1151         Reviewed by Alex Christensen.
1152
1153         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1154         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1155
1156 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1157
1158         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1159         https://bugs.webkit.org/show_bug.cgi?id=196540
1160
1161         Reviewed by Aakash Jain.
1162
1163         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1164
1165 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1166
1167         Add plumbing for a compatibility mode preference in WebKit
1168         https://bugs.webkit.org/show_bug.cgi?id=196005
1169
1170         Reviewed by Tim Horton.
1171
1172         Add new API tests.
1173
1174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1175         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1176
1177 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1178
1179         [WPE][GTK] Update libsrtp dependency package for Debian
1180         https://bugs.webkit.org/show_bug.cgi?id=196528
1181
1182         Reviewed by Frédéric Wang.
1183
1184         * gtk/install-dependencies:
1185         * wpe/install-dependencies:
1186
1187 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1188
1189         [WK2] Add support for Window's beforeprint / afterprint events
1190         https://bugs.webkit.org/show_bug.cgi?id=196478
1191         <rdar://problem/49535124>
1192
1193         Unreviewed build fix for MSVC.
1194
1195         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1196
1197         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1198
1199         * WebKitTestRunner/TestController.cpp:
1200         (WTR::printFrame): Use int and float literals.
1201
1202 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1203
1204         [ews-build] Reassign bots to queues
1205
1206         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1207
1208 2019-04-02  Chris Dumez  <cdumez@apple.com>
1209
1210         [WK2] Add support for Window's beforeprint / afterprint events
1211         https://bugs.webkit.org/show_bug.cgi?id=196478
1212
1213         Reviewed by Alex Christensen.
1214
1215         Add minimal implementation for printFrame in WebKitTestRunner.
1216
1217         * WebKitTestRunner/TestController.cpp:
1218         (WTR::printFrame):
1219         (WTR::TestController::createOtherPage):
1220         (WTR::TestController::createWebViewWithOptions):
1221
1222 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1223
1224         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1225         https://bugs.webkit.org/show_bug.cgi?id=196491
1226
1227         Reviewed by Lucas Forschler.
1228
1229         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1230
1231 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1232
1233         [ews-build] Configure buildbot try credentials in environment variables
1234         https://bugs.webkit.org/show_bug.cgi?id=196501
1235
1236         Reviewed by Lucas Forschler.
1237
1238         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1239         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1240         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1241
1242 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1243
1244         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1245         https://bugs.webkit.org/show_bug.cgi?id=196496
1246         <rdar://problem/49521634>
1247
1248         Reviewed by Chris Dumez.
1249
1250         Add new API tests (see WebKit ChangeLog for more detail).
1251
1252         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1253         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1254         (TEST):
1255
1256 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1257
1258         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1259         <https://webkit.org/b/196499>
1260
1261         Reviewed by Alexey Proskuryakov.
1262
1263         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1264         ENABLE_ADDRESS_SANITIZER.
1265
1266 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1267
1268         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1269         https://bugs.webkit.org/show_bug.cgi?id=182757
1270
1271         Reviewed by Don Olmstead.
1272
1273         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1274         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1275
1276 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1277
1278         run-api-tests: Upload test results
1279         https://bugs.webkit.org/show_bug.cgi?id=196323
1280         <rdar://problem/49356714>
1281
1282         Reviewed by Lucas Forschler.
1283
1284         * Scripts/webkitpy/api_tests/manager.py:
1285         (Manager):
1286         (Manager.run): Upload results to a results database.
1287         * Scripts/webkitpy/api_tests/run_api_tests.py:
1288         (parse_args): Add upload arguments.
1289         * Scripts/webkitpy/port/base.py:
1290         (Port):
1291         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1292         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1293         with commits from any other associated repositories.
1294         * Scripts/webkitpy/port/device.py:
1295         (Device):
1296         (Device.build_version): Access build_versoin of underlying platform device.
1297         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1298         (IOSSimulatorTest):
1299         (IOSSimulatorTest.test_configuration_for_upload):
1300         * Scripts/webkitpy/port/device_port.py:
1301         (DevicePort):
1302         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1303         the same as the machine uploading results.
1304         * Scripts/webkitpy/port/mac.py:
1305         (MacPort):
1306         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1307         * Scripts/webkitpy/port/mac_unittest.py:
1308         (MacTest):
1309         (MacTest.test_configuration_for_upload):
1310         * Scripts/webkitpy/xcode/simulated_device.py:
1311         (SimulatedDeviceManager._create_device_with_runtime):
1312         (SimulatedDevice.__init__): Create simulated device with a build_version.
1313         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1314         (test_existing_simulator):
1315
1316 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1317
1318         Remove extra newline characters (Follow-up fix to r243707)
1319
1320         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1321
1322 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1323
1324         [ews-app] Use API_KEY to accept results data
1325         https://bugs.webkit.org/show_bug.cgi?id=196461
1326
1327         Reviewed by Dewei Zhu.
1328
1329         * BuildSlaveSupport/ews-app/ews/views/results.py:
1330         (Results.post): Validate EWS_API_KEY before accepting any data.
1331         * BuildSlaveSupport/ews-build/events.py:
1332         (Events.sendData): Send EWS_API_KEY if available along with event data.
1333
1334 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1335
1336         Unable to copy and paste a PDF from Notes into Mail compose body
1337         https://bugs.webkit.org/show_bug.cgi?id=196442
1338         <rdar://problem/48573098>
1339
1340         Reviewed by Tim Horton.
1341
1342         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1343         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1344         to be specified on the item providers.
1345
1346         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1347         (TestWebKitAPI::mapItemForTesting):
1348         (TestWebKitAPI::contactItemForTesting):
1349
1350 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1351
1352         Make UIWKDocumentContext rects per-character instead of per-word
1353         https://bugs.webkit.org/show_bug.cgi?id=196459
1354
1355         Reviewed by Wenson Hsieh.
1356
1357         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1358         (TEST):
1359         Adjust test results due to switching to per-character rects.
1360
1361 2019-04-01  Chris Dumez  <cdumez@apple.com>
1362
1363         UIProcess crash when a prewarmed process is terminated
1364         https://bugs.webkit.org/show_bug.cgi?id=196451
1365         <rdar://problem/49245471>
1366
1367         Reviewed by Geoffrey Garen.
1368
1369         Add API test coverage.
1370
1371         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1372         (TEST):
1373
1374 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1375
1376         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1377         https://bugs.webkit.org/show_bug.cgi?id=196449
1378
1379         Reviewed by Lucas Forschler.
1380
1381         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1382         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1383         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1384         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1385
1386 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1387
1388         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1389         https://bugs.webkit.org/show_bug.cgi?id=196444
1390
1391         Reviewed by Lucas Forschler.
1392
1393         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1394
1395 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1396
1397         Add SPI to canonicalize NSURLs with WTF::URL
1398         https://bugs.webkit.org/show_bug.cgi?id=196415
1399         <rdar://problem/44980271>
1400
1401         Reviewed by Darin Adler.
1402
1403         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1404         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1405         (TestWebKitAPI::TEST):
1406
1407 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1408
1409         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1410         https://bugs.webkit.org/show_bug.cgi?id=196441
1411
1412         Reviewed by Carlos Garcia Campos.
1413
1414         Don't cache the wpe_view_backend object that might not exist yet at the
1415         time of EventSenderProxy constructor invocation, but instead retrieve
1416         that object whenever it's required for event dispatching. This should
1417         avoid crashes in this constructor now that it's invoked before any
1418         PlatformWindow has been set up (as changed in r243496).
1419
1420         * WebKitTestRunner/EventSenderProxy.h:
1421         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1422         (WTR::viewBackend):
1423         (WTR::EventSenderProxy::EventSenderProxy):
1424         (WTR::EventSenderProxy::mouseDown):
1425         (WTR::EventSenderProxy::mouseUp):
1426         (WTR::EventSenderProxy::mouseMoveTo):
1427         (WTR::EventSenderProxy::mouseScrollBy):
1428         (WTR::EventSenderProxy::keyDown):
1429         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1430
1431 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1432
1433         [Win][WebKit] MiniBrowser should support high DPI display
1434         https://bugs.webkit.org/show_bug.cgi?id=196391
1435
1436         Reviewed by Alex Christensen.
1437
1438         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1439         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1440         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1441         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1442
1443 2019-03-31  Sam Weinig  <weinig@apple.com>
1444
1445         Remove more i386 specific configurations
1446         https://bugs.webkit.org/show_bug.cgi?id=196430
1447
1448         Reviewed by Alexey Proskuryakov.
1449
1450         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1451         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1452
1453 2019-03-31  Andy Estes  <aestes@apple.com>
1454
1455         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1456         https://bugs.webkit.org/show_bug.cgi?id=196433
1457         <rdar://problem/49293305>
1458
1459         Reviewed by Tim Horton.
1460
1461         Enhanced API test coverage to include all navigation response policy decisions in both
1462         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1463
1464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1465         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1466         (TestWebKitAPI::TEST):
1467         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1468         (readFile):
1469         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1470         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1471         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1472         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1473         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1474         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1475         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1476         (-[QuickLookDelegate _downloadDidStart:]):
1477         (-[QuickLookDelegate _download:didReceiveResponse:]):
1478         (-[QuickLookDelegate _download:didReceiveData:]):
1479         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1480         (-[QuickLookDelegate _downloadDidFinish:]):
1481         (-[QuickLookDelegate _download:didFailWithError:]):
1482         (-[QuickLookDelegate _downloadDidCancel:]):
1483         (-[QuickLookDelegate verifyDownload]):
1484         (runTest):
1485         (runTestDecideBeforeLoading):
1486         (runTestDecideAfterLoading):
1487         (TEST):
1488         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1489         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1490         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1491         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1492         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1493         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1494         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1495         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1496         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1497         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1498         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1499         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1500         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1501         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1502
1503 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1504
1505         [CMake] add testdfg as target with build-jsc
1506         https://bugs.webkit.org/show_bug.cgi?id=196393
1507
1508         Reviewed by Saam Barati.
1509
1510         Added testdfg as one of the targets to build when
1511         using CMake.
1512
1513         * Scripts/build-jsc:
1514
1515 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1516
1517         Delete WebMetal implementation in favor of WebGPU
1518         https://bugs.webkit.org/show_bug.cgi?id=195418
1519
1520         Reviewed by Dean Jackson.
1521
1522         * DumpRenderTree/mac/DumpRenderTree.mm:
1523         (enableExperimentalFeatures):
1524         (resetWebPreferencesToConsistentValues):
1525         * Scripts/webkitperl/FeatureList.pm:
1526         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1527         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1528         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1529         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1530         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1531         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1532         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1533         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1534         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1535         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1536         (WTR::InjectedBundle::beginTesting):
1537         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1538         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1539         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1540
1541 2019-03-29  Chris Dumez  <cdumez@apple.com>
1542
1543         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1544         https://bugs.webkit.org/show_bug.cgi?id=196405
1545         <rdar://problem/49428130>
1546
1547         Reviewed by Wenson Hsieh.
1548
1549         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1550         the popover presentation methods to be no-ops. Use this in the new test added in
1551         r243523 so that we do not swizzle those methods for all tests. This is needed because
1552         those WatchOS tests rely on the popover getting presented and interactive.
1553
1554         * WebKitTestRunner/TestController.cpp:
1555         (WTR::updateTestOptionsFromTestHeader):
1556         * WebKitTestRunner/TestController.h:
1557         * WebKitTestRunner/TestOptions.h:
1558         (WTR::TestOptions::hasSameInitializationOptions const):
1559         * WebKitTestRunner/ios/TestControllerIOS.mm:
1560         (WTR::TestController::platformInitialize):
1561         (WTR::TestController::platformResetStateToConsistentValues):
1562
1563 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1564
1565         [Curl] Add Server Trust Evaluation Support.
1566         https://bugs.webkit.org/show_bug.cgi?id=191646
1567
1568         Reviewed by Fujii Hironori.
1569
1570         Implemented MiniBrowser UI for asking if user trusts the server.
1571
1572         * MiniBrowser/win/Common.cpp:
1573         (askServerTrustEvaluation):
1574         (replaceString):
1575         * MiniBrowser/win/Common.h:
1576         * MiniBrowser/win/MiniBrowserLib.rc:
1577         * MiniBrowser/win/MiniBrowserLibResource.h:
1578         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1579         (createPEMString):
1580         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1581         (WebKitBrowserWindow::canTrustServerCertificate):
1582         * MiniBrowser/win/WebKitBrowserWindow.h:
1583
1584 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1585
1586         Implement ResizeObserver.
1587         https://bugs.webkit.org/show_bug.cgi?id=157743
1588
1589         Reviewed by Simon Fraser.
1590
1591         Support resizeObserverEnabled webPreferences.
1592
1593         * DumpRenderTree/TestOptions.cpp:
1594         (TestOptions::TestOptions):
1595         * DumpRenderTree/TestOptions.h:
1596         * DumpRenderTree/mac/DumpRenderTree.mm:
1597         (setWebPreferencesForTestOptions):
1598         * DumpRenderTree/win/DumpRenderTree.cpp:
1599         (enableExperimentalFeatures):
1600         * Scripts/webkitperl/FeatureList.pm:
1601         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1602
1603 2019-03-28  John Wilander  <wilander@apple.com>
1604
1605         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1606         https://bugs.webkit.org/show_bug.cgi?id=196281
1607         <rdar://problem/48938748>
1608
1609         Reviewed by Alex Christensen.
1610
1611         This patch adds the function isStatisticsHasLocalStorage() to the
1612         TestRunner. With it, the page can query the WebsiteDataStore in the
1613         UI process to make sure that it sees LocalStorage.
1614
1615         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1616         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1617         (WTR::TestRunner::isStatisticsHasLocalStorage):
1618         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1619         * WebKitTestRunner/TestController.cpp:
1620         (WTR::TestController::isStatisticsHasLocalStorage):
1621         * WebKitTestRunner/TestController.h:
1622         * WebKitTestRunner/TestInvocation.cpp:
1623         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1624
1625 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1626
1627         API::Data::createWithoutCopying should do a null check before calling CFRelease
1628         https://bugs.webkit.org/show_bug.cgi?id=196276
1629         <rdar://problem/48059859>
1630
1631         Reviewed by Alex Christensen.
1632
1633         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1634
1635         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1636         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1637         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1638         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1639         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1640         (TestWebKitAPI::TEST):
1641
1642 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1643
1644         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1645         https://bugs.webkit.org/show_bug.cgi?id=186276
1646
1647         Reviewed by Carlos Garcia Campos.
1648
1649         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1650         (webViewLoadChanged):
1651         (testWebResourceGetDataError):
1652         (testWebResourceGetDataEmpty):
1653         (beforeAll):
1654         (webViewloadChanged): Deleted.
1655
1656 2019-03-27  Andy Estes  <aestes@apple.com>
1657
1658         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1659         https://bugs.webkit.org/show_bug.cgi?id=196317
1660
1661         Reviewed by Dan Bernstein.
1662
1663         package-root copies built products into a staging directory using ditto(1), which does not
1664         follow symbolic links as it traverses a directory. Now that the files in
1665         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1666         itself, these become broken links when ditto'd into the staging directory.
1667
1668         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1669
1670         * Scripts/package-root:
1671
1672 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1673
1674         [ews-app] Update display text of Submit for ews analysis
1675         https://bugs.webkit.org/show_bug.cgi?id=196309
1676
1677         Reviewed by Dewei Zhu.
1678
1679         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1680
1681 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1682
1683         run-webkit-tests should check for leaks in WebKit processes
1684         <https://webkit.org/b/193772>
1685         <rdar://problem/46526680>
1686
1687         Reviewed by Ryosuke Niwa.
1688
1689         This works by doing the following:
1690         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1691           The list of child processes are returned one per line:
1692           process.name: pid
1693         - Run the "#LIST CHILD PROCESSES" command just before the
1694           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1695           processes on the ServerProcess object.
1696         - When the `--leaks` switch is handled, run check_for_leaks() on
1697           each child process after the main test harness.
1698
1699         * DumpRenderTree/mac/DumpRenderTree.mm:
1700         (handleControlCommand):
1701         - Use strncmp() instead of strcmp().
1702         - Add support for handling "#LIST CHILD PROCESSES" command.
1703
1704         * Scripts/webkitpy/port/base.py:
1705         (Port.check_for_leaks):
1706         * Scripts/webkitpy/port/darwin.py:
1707         (DarwinPort.check_for_leaks):
1708         - Rename redundant 'process_pid' argument to 'process_id'.
1709
1710         * Scripts/webkitpy/port/driver.py:
1711         (Driver.do_post_tests_work):
1712         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1713           longer the only command this sends to WebKitTestRunner.
1714         - If the `--leaks` switch is present, send the
1715           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1716           result using Port.set_webkit_processes().
1717         (Driver._parse_child_processes_output):
1718         - Add helper method to parse list of child process names and
1719           process IDs returned from WebKitTestRunner.
1720
1721         * Scripts/webkitpy/port/ios_device.py:
1722         (IOSDevicePort.check_for_leaks):
1723         - Rename redundant 'process_pid' argument to 'process_id'.
1724
1725         * Scripts/webkitpy/port/leakdetector.py:
1726         (LeakDetector._parse_leaks_output):
1727         - Return early if there is no leaks_output.
1728         (LeakDetector.check_for_leaks):
1729         - Rename redundant 'process_pid' argument to 'process_id'.
1730
1731         * Scripts/webkitpy/port/server_process.py:
1732         (ServerProcess.__init__):
1733         (ServerProcess.child_processes):
1734         (ServerProcess.set_child_processes):
1735         - Add instance variable to Port to store list of child process
1736           names and process IDs returned from WebKitTestRunner.
1737         (ServerProcess._start):
1738         - Clear self._child_processes.
1739         (ServerProcess.stop):
1740         - If self._child_processes is set, call
1741           self._port.check_for_leaks() for each child process.
1742
1743         * Scripts/webkitpy/port/server_process_unittest.py:
1744         (TrivialMockPort.check_for_leaks):
1745         - Rename redundant 'process_pid' argument to 'process_id'.
1746
1747         * Scripts/webkitpy/port/simulator_process.py:
1748         (SimulatorProcess.stop):
1749         - If self._child_processes is set, call
1750           self._port.check_for_leaks() for each child process.
1751
1752         * Scripts/webkitpy/port/watch_device.py:
1753         (WatchDevicePort.check_for_leaks):
1754         - Rename redundant 'process_pid' argument to 'process_id'.
1755
1756         * WebKitTestRunner/TestController.cpp:
1757         (WTR::TestController::dumpResponse):
1758         - Extract method from findAndDumpWorldLeaks() so that it may be
1759           reused by findAndDumpWebKitProcessIdentifiers().
1760         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1761         - Add method to output process name and process ID of both the
1762           WebContent and Networking processes.
1763         (WTR::TestController::findAndDumpWorldLeaks):
1764         - Fix missing newline in output when there were no abandoned
1765           documents.
1766         - Call dumpResponse() for extracted code.
1767         (WTR::TestController::handleControlCommand):
1768         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1769         - Use strncmp() instead of strcmp().
1770         - Call findAndDumpWebKitProcessIdentifiers() when
1771           "#LIST CHILD PROCESSES" command is sent.
1772         * WebKitTestRunner/TestController.h:
1773         (WTR::TestController::dumpResponse):
1774         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1775         - Declare methods.
1776
1777 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1778
1779         Unreviewed. Add GLib API test cases after r243434.
1780
1781         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1782         (testWebViewActiveURI):
1783         (serverCallback):
1784         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1785         (sendRequestCallback):
1786
1787 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1788
1789         Geolocation request not complete when watch request was started in a different web process
1790         https://bugs.webkit.org/show_bug.cgi?id=195996
1791
1792         Reviewed by Alex Christensen.
1793
1794         Add a test case.
1795
1796         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1797         (TestWebKitAPI::runJavaScriptAlert):
1798         (TestWebKitAPI::TEST):
1799
1800 2019-03-26  Keith Rollin  <krollin@apple.com>
1801
1802         Update the way generate-xcfilelists returns strings from functions
1803         https://bugs.webkit.org/show_bug.cgi?id=195975
1804         <rdar://problem/49040807>
1805
1806         Reviewed by Dean Jackson.
1807
1808         There are places where generate-xcfilelists executes assignments with
1809         statements like:
1810
1811             FOO=$(some_function)
1812
1813         where "some_function" return a string by echoing it. E.g.
1814
1815             some_function()
1816             {
1817                 echo "Hello, World"
1818             }
1819
1820         This is a common idiom, but it has a problem if "some_function" needs
1821         to call "exit" in an attempt to halt the entire script right then and
1822         there. Since "some_function" is called inside of $(), it's being
1823         executed in a sub-shell. Calling exit in that sub-shell simply exits
1824         that shell; it doesn't not exit the outer shell in which the main part
1825         of the script is still running. As such, the main script keeps
1826         executing when the intent was for the script to halt.
1827
1828         The solution to this is to use a different idiom for returning
1829         strings. The one we now is to pass in the name of the variable to
1830         receive the string result:
1831
1832             some_function()
1833             {
1834                 variable_name=$1
1835                 eval $variable_name ="Hello, World"
1836             }
1837
1838         The call site now looks like
1839
1840             some_function FOO
1841
1842         Because there's no invocation of a sub-shell, some_function can now
1843         call "exit" if it wants to, and the entire script will exit at that
1844         point.
1845
1846         * Scripts/generate-xcfilelists:
1847
1848 2019-03-26  Chris Dumez  <cdumez@apple.com>
1849
1850         Add basic layout test coverage for File Picker on iOS
1851         https://bugs.webkit.org/show_bug.cgi?id=196265
1852
1853         Reviewed by Wenson Hsieh.
1854
1855         Add layout test infrastructure to test the file picker on iOS.
1856
1857         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1858         (WTR::UIScriptController::dismissFilePicker):
1859         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1860         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1861         (WTR::UIScriptController::dismissFilePicker):
1862         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1863         * WebKitTestRunner/TestController.cpp:
1864         (WTR::TestController::createWebViewWithOptions):
1865         (WTR::updateTestOptionsFromTestHeader):
1866         * WebKitTestRunner/TestOptions.h:
1867         (WTR::TestOptions::hasSameInitializationOptions const):
1868         * WebKitTestRunner/ios/TestControllerIOS.mm:
1869         (overridePresentViewController):
1870         (WTR::TestController::platformInitialize):
1871         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1872         (WTR::UIScriptController::dismissFilePicker):
1873
1874 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1875
1876         Implement async paste method on UIWKInteractionViewProtocol
1877         https://bugs.webkit.org/show_bug.cgi?id=196267
1878         <rdar://problem/49236346>
1879
1880         Reviewed by Tim Horton.
1881
1882         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1883         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1884         are now a part of all iOS 12 internal SDKs.
1885
1886         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1887
1888         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1889         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1890
1891         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1892         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1893         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1894         * TestWebKitAPI/ios/UIKitSPI.h:
1895
1896 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1897
1898         [ews-build] Use PostgreSQL for ews.webkit.org database
1899         https://bugs.webkit.org/show_bug.cgi?id=196270
1900
1901         Reviewed by Lucas Forschler.
1902
1903         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1904
1905 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1906
1907         [ews] Reset simctl states on reboot
1908         https://bugs.webkit.org/show_bug.cgi?id=196260
1909
1910         Rubber-stamped by Aakash Jain.
1911
1912         * EWSTools/start-queue-mac.sh:
1913
1914 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1915
1916         [ews-build] Use PostgreSQL for ews-build database
1917         https://bugs.webkit.org/show_bug.cgi?id=196229
1918
1919         Reviewed by Lucas Forschler.
1920
1921         * BuildSlaveSupport/ews-build/master.cfg:
1922
1923 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1924
1925         [ews-build] Get master_hostname dynamically in master.cfg
1926         https://bugs.webkit.org/show_bug.cgi?id=196255
1927
1928         Reviewed by Lucas Forschler.
1929
1930         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1931         send events data in test mode.
1932
1933 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1934
1935         [ews-app] Set db_constraint to False for Foreign Keys
1936         https://bugs.webkit.org/show_bug.cgi?id=196252
1937
1938         Reviewed by Lucas Forschler.
1939
1940         * BuildSlaveSupport/ews-app/ews/models/build.py:
1941         * BuildSlaveSupport/ews-app/ews/models/step.py:
1942
1943 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1944
1945         [ews-build] is_test_mode_enabled should default to True
1946         https://bugs.webkit.org/show_bug.cgi?id=196248
1947
1948         Reviewed by Lucas Forschler.
1949
1950         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1951
1952 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1953
1954         [ews-app] Add webkitperl to ENABLED_QUEUES
1955         https://bugs.webkit.org/show_bug.cgi?id=196253
1956
1957         Reviewed by Lucas Forschler.
1958
1959         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1960
1961 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1962
1963         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1964         https://bugs.webkit.org/show_bug.cgi?id=196211
1965         rdar://problem/49110552
1966
1967         Reviewed by Tim Horton.
1968
1969         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1970         Make sure that EventSenderProxy always exists when running tests. We used to create
1971         it when resetting before the first test, which is a bit too late.
1972
1973         * WebKitTestRunner/TestController.h:
1974         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1975         (WTR::TestController::platformCreateWebView):
1976         (WTR::TestController::platformCreateOtherPage):
1977         (WTR::TestController::finishCreatingPlatformWebView):
1978         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1979         (WTR::PlatformWebView::PlatformWebView):
1980         Moved some code that made NSWindow use NSEvent during web view creation. We may
1981         need to move more if some other case us found, but this is enough for now.
1982
1983 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1984
1985         Unreviewed. Fix typo in GLib geolocation API after r243285.
1986
1987         gelocation -> geolocation.
1988
1989         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1990         (testGeolocationManagerWatchPosition):
1991
1992 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1993
1994         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1995         https://bugs.webkit.org/show_bug.cgi?id=196213
1996
1997         Reviewed by Geoff Garen.
1998
1999         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2000         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2001         (credentialWithIdentityAndKeychainPath):
2002         (-[ChallengeDelegate webView:didFinishNavigation:]):
2003         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2004         (TestWebKitAPI::TEST):
2005
2006 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2007
2008         Expected shouldn't assume its contained types are copyable
2009         https://bugs.webkit.org/show_bug.cgi?id=195986
2010
2011         Reviewed by JF Bastien.
2012
2013         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2014         (TestWebKitAPI::NonCopyable::operator== const):
2015         (TestWebKitAPI::NonCopyable::operator!= const):
2016         (TestWebKitAPI::TEST):
2017
2018 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2019
2020         Remove some now-unnecessary dynamic class lookup
2021         https://bugs.webkit.org/show_bug.cgi?id=196237
2022
2023         Reviewed by Simon Fraser.
2024
2025         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2026         (makeRequest):
2027         (TEST):
2028
2029 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2030
2031         Unreviewed, rolling out r243450.
2032
2033         AppleWin and WinCairo port builds get broken.
2034
2035         Reverted changeset:
2036
2037         "Add test for fix of #196095"
2038         https://bugs.webkit.org/show_bug.cgi?id=196097
2039         https://trac.webkit.org/changeset/243450
2040
2041 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2042
2043         Unreviewed, rolling out r243465.
2044         https://bugs.webkit.org/show_bug.cgi?id=196226
2045
2046         the test doesn't build (Requested by thorton on #webkit).
2047
2048         Reverted changeset:
2049
2050         "Do not terminate the NetworkProcess if a third party
2051         application sends a NSCredential with a SecIdentityRef"
2052         https://bugs.webkit.org/show_bug.cgi?id=196213
2053         https://trac.webkit.org/changeset/243465
2054
2055 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2056
2057         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2058         https://bugs.webkit.org/show_bug.cgi?id=196213
2059
2060         Reviewed by Geoff Garen.
2061
2062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2063         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2064         (credentialWithIdentityAndKeychainPath):
2065         (-[ChallengeDelegate webView:didFinishNavigation:]):
2066         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2067         (TestWebKitAPI::TEST):
2068
2069 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2070
2071         [ews-build] Gracefully handle missing patch_id in events
2072         https://bugs.webkit.org/show_bug.cgi?id=196216
2073
2074         Reviewed by Lucas Forschler.
2075
2076         * BuildSlaveSupport/ews-build/events.py:
2077
2078 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2079
2080         [ews-build] use lz4 compression for improving buildbot performance
2081         https://bugs.webkit.org/show_bug.cgi?id=196155
2082
2083         Reviewed by Lucas Forschler.
2084
2085         * BuildSlaveSupport/ews-build/master.cfg:
2086
2087 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2088
2089         Pull some API testing helper methods out of TestWKWebView
2090         https://bugs.webkit.org/show_bug.cgi?id=196212
2091
2092         Reviewed by Tim Horton.
2093
2094         Refactor some more API testing utility methods, so that they can be used in
2095         tests that do not use TestWKWebView.
2096
2097         * TestWebKitAPI/cocoa/TestWKWebView.h:
2098         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2099         (-[WKWebView loadTestPageNamed:]):
2100         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2101         (-[WKWebView synchronouslyLoadHTMLString:]):
2102         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2103         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2104         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2105         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2106         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2107
2108 2019-03-25  Jer Noble  <jer.noble@apple.com>
2109
2110         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2111         https://bugs.webkit.org/show_bug.cgi?id=196097
2112
2113         Reviewed by Eric Carlson.
2114
2115         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2116
2117         * DumpRenderTree/mac/DumpRenderTree.mm:
2118         (resetWebPreferencesToConsistentValues):
2119         * WebKitTestRunner/TestController.cpp:
2120         (WTR::TestController::resetPreferencesToConsistentValues):
2121
2122 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2123
2124         Pull IPadUserInterfaceSwizzler out into a separate header file
2125         https://bugs.webkit.org/show_bug.cgi?id=196193
2126
2127         Reviewed by Anders Carlsson.
2128
2129         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2130         be used in other API tests.
2131
2132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2133         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2134         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2135         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2136         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2137         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2138         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2139
2140 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2141
2142         Remove NavigatorContentUtils in WebCore/Modules
2143         https://bugs.webkit.org/show_bug.cgi?id=196070
2144
2145         Reviewed by Alex Christensen.
2146
2147         NavigatorContentUtils was to support the custom scheme spec [1].
2148         However, in WebKit side, no port has supported the feature in
2149         WebKit layer after EFL port was removed. So there has been the
2150         only IDL implementation of the NavigatorContentUtils in WebCore.
2151         So we don't need to keep the implementation in WebCore anymore.
2152
2153         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2154
2155         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2156
2157 2019-03-24  Andy Estes  <aestes@apple.com>
2158
2159         [watchOS] Remove unused Proximity Networking code
2160         https://bugs.webkit.org/show_bug.cgi?id=196188
2161
2162         Reviewed by Tim Horton.
2163
2164         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2165         (TEST):
2166
2167 2019-03-23  Keith Miller  <keith_miller@apple.com>
2168
2169         Refactor clz/ctz and fix getLSBSet.
2170         https://bugs.webkit.org/show_bug.cgi?id=196162
2171
2172         Reviewed by Saam Barati.
2173
2174         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2175
2176         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2177         (TestWebKitAPI::TEST):
2178
2179 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2180
2181         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2182         https://bugs.webkit.org/show_bug.cgi?id=196143
2183
2184         Reviewed by Michael Catanzaro.
2185
2186         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2187         directories.
2188
2189         * Scripts/webkitpy/style/checkers/cpp.py:
2190         (check_identifier_name_in_declaration):
2191         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2192         (WebKitStyleTest.test_names):
2193
2194 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2195
2196         [Flatpak] Manifest expanding fails for qt WPE extension
2197         https://bugs.webkit.org/show_bug.cgi?id=196148
2198
2199         Reviewed by Alex Christensen.
2200
2201         * flatpak/flatpakutils.py:
2202         (expand_submodules_recurse): The last recurse manifest expand
2203         iteration might lead to a single module so take it into account
2204         and don't try to recurse further.
2205
2206 2019-03-22  Chris Dumez  <cdumez@apple.com>
2207
2208         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2209         https://bugs.webkit.org/show_bug.cgi?id=195348
2210         <rdar://problem/48622090>
2211
2212         Reviewed by Alex Christensen.
2213
2214         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2215         to NO when test.options().shouldIgnoreMetaViewport is false.
2216
2217         * WebKitTestRunner/ios/TestControllerIOS.mm:
2218         (WTR::TestController::platformConfigureViewForTest):
2219
2220 2019-03-22  Chris Dumez  <cdumez@apple.com>
2221
2222         Prewarmed processes should be usable with any website data store
2223         https://bugs.webkit.org/show_bug.cgi?id=196104
2224
2225         Reviewed by Alex Christensen.
2226
2227         Add API test coverage.
2228
2229         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2230         (runInitialWarmedProcessUsedTest):
2231         (TEST):
2232
2233 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2234
2235         Back out local changes to Alex's Subversion working directory
2236
2237         They were accidentally committed.
2238
2239         * Scripts/webkitpy/common/system/abstractexecutive.py:
2240         (AbstractExecutive.wait_newest):
2241         * Scripts/webkitpy/common/system/executive.py:
2242         (Executive.running_pids):
2243         * Scripts/webkitpy/common/system/executive_mock.py:
2244         (MockExecutive.running_pids):
2245         * Scripts/webkitpy/common/system/executive_unittest.py:
2246         (ExecutiveTest.serial_test_running_pids):
2247         * Scripts/webkitpy/port/darwin.py:
2248         (DarwinPort.check_for_leaks):
2249         * Scripts/webkitpy/port/leakdetector.py:
2250         (LeakDetector.check_for_leaks):
2251         - This was the hack attached to Bug 193772.
2252
2253         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2254         (+[WebKitTestRunnerEvent mouseLocation]):
2255         - This works around a crash on an internal build.
2256
2257 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2258
2259         Fix the build after r243354
2260         https://bugs.webkit.org/show_bug.cgi?id=196138
2261         <rdar://problem/49145951>
2262
2263         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2264         (TEST):
2265         * TestWebKitAPI/ios/UIKitSPI.h:
2266
2267 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2268
2269         Adopt UIWKDocumentContext
2270         https://bugs.webkit.org/show_bug.cgi?id=196040
2271         <rdar://problem/48642440>
2272
2273         Reviewed by Ryosuke Niwa.
2274
2275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2276         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2277         (makeRequest):
2278         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2279         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2280         (applyStyle):
2281         (TEST):
2282         Add tests for UIWKDocumentContext.
2283
2284         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2285         (TEST):
2286         (recursiveFindWKContentView): Deleted.
2287         * TestWebKitAPI/cocoa/TestWKWebView.h:
2288         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2289         (recursiveFindWKContentView):
2290         (-[TestWKWebView wkContentView]):
2291         * TestWebKitAPI/ios/UIKitSPI.h:
2292         Share the WKContentView finding code between tests.
2293
2294 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2295
2296         [iOS WK2] Turn on async overflow scrolling by default
2297         https://bugs.webkit.org/show_bug.cgi?id=196011
2298         rdar://problem/48453859
2299
2300         Reviewed by Antti Koivisto.
2301         
2302         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2303         since so many basic layout tests have different results when compositing is triggered for
2304         overflow.
2305         
2306         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2307
2308         * WebKitTestRunner/TestController.cpp:
2309         (WTR::TestController::resetPreferencesToConsistentValues):
2310
2311 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2312
2313         [ews-build] Retry API test in case of failures
2314         https://bugs.webkit.org/show_bug.cgi?id=196004
2315
2316         Reviewed by Lucas Forschler.
2317
2318         * BuildSlaveSupport/ews-build/steps.py:
2319         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2320         (CompileWebKitToT.doStepIf): Ditto.
2321         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2322         (ReRunAPITests): Re-run API tests.
2323         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2324         (RunAPITestsWithoutPatch): Run API tests without patch.
2325         (RunAPITestsWithoutPatch.doStepIf):
2326         (RunAPITestsWithoutPatch.hideStepIf):
2327         (RunAPITestsWithoutPatch.evaluateCommand):
2328         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2329         (AnalyzeAPITestsResults.start):
2330         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2331         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2332         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2333         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2334
2335 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2336
2337         [ews-build] Update queues configurations
2338         https://bugs.webkit.org/show_bug.cgi?id=196074
2339
2340         Reviewed by Dewei Zhu.
2341
2342         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2343         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2344
2345 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2346
2347         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2348         https://bugs.webkit.org/show_bug.cgi?id=195680
2349         <rdar://problem/48903534>
2350
2351         Unreviewed infrastructure fix.
2352
2353         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2354         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2355
2356 2019-03-21  Andy Estes  <aestes@apple.com>
2357
2358         [iOS] Apple Pay should be available in documents with no user agent scripts
2359         https://bugs.webkit.org/show_bug.cgi?id=196061
2360         <rdar://problem/48649391>
2361
2362         Reviewed by Brady Eidson.
2363
2364         Added API tests and related infrastructure.
2365
2366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2367         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2368         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2369         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2370         (TestWebKitAPI::TEST):
2371         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2372         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2373         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2374         * TestWebKitAPI/cocoa/TestProtocol.mm:
2375         (-[TestProtocol startLoading]):
2376         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2377         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2378         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2379         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2380
2381 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2382
2383         REGRESSSION (r243297): webkitpy tests broken
2384         https://bugs.webkit.org/show_bug.cgi?id=196108
2385
2386         Reviewed by Aakash Jain.
2387
2388         r243297 updated contributors.json, which broke a few unit tests.
2389
2390         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2391         (IRCCommandTest.test_whois):
2392         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2393
2394 2019-03-21  Chris Dumez  <cdumez@apple.com>
2395
2396         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2397         https://bugs.webkit.org/show_bug.cgi?id=196041
2398         <rdar://problem/49083230>
2399
2400         Reviewed by Alex Christensen.
2401
2402         Add API test coverage.
2403
2404         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2405         (TEST):
2406
2407 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2408
2409         Add SPI to inform applications of WKContentRuleList actions
2410         https://bugs.webkit.org/show_bug.cgi?id=195965
2411         <rdar://problem/42664365>
2412
2413         Reviewed by Geoff Garen.
2414
2415         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2416         (TestWebKitAPI::allActionsForResourceLoad):
2417         (TestWebKitAPI::testRequest):
2418         (TestWebKitAPI::TEST_F):
2419         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2420         (Notification::description):
2421         (Notification::operator== const):
2422         (toVector):
2423         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2424         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2425         (makeContentRuleList):
2426         (TEST):
2427         (makeWarnContentRuleList): Deleted.
2428
2429 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2430
2431         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2432         https://bugs.webkit.org/show_bug.cgi?id=196088
2433
2434         Reviewed by Brian Burg.
2435
2436         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2437         Support checks when only one platform is specified. Also deprecate macosx() and
2438         force the use of macos() instead.
2439
2440         * Scripts/webkitpy/style/checkers/cpp.py:
2441         (check_min_versions_of_wk_api_available):
2442         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2443         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2444
2445 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2446
2447         Update status inactive committers' status to 'contributor'.
2448
2449         * Scripts/webkitpy/common/config/contributors.json:
2450
2451 2019-03-21  Xan Lopez  <xan@igalia.com>
2452
2453         [JSC][x86] Drop support for x87 floating point
2454         https://bugs.webkit.org/show_bug.cgi?id=194853
2455
2456         Reviewed by Don Olmstead.
2457
2458         Force SSE2 on x86/32bit builds.
2459
2460         * Scripts/webkitdirs.pm:
2461         (generateBuildSystemFromCMakeProject):
2462
2463 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2464
2465         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2466         https://bugs.webkit.org/show_bug.cgi?id=196073
2467
2468         Reviewed by Michael Catanzaro.
2469
2470         Add test cases to check functions and constructors with no arguments but receiving user data.
2471
2472         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2473         (checkUserData):
2474         (testJSCFunction):
2475         (fooCreateWithUserData):
2476         (testJSCClass):
2477
2478 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2479
2480         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2481
2482         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2483
2484         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2485
2486 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2487
2488         [GTK][WPE] Add API to provide geolocation information
2489         https://bugs.webkit.org/show_bug.cgi?id=195940
2490
2491         Reviewed by Michael Catanzaro.
2492
2493         Add a new test to check the new API.
2494
2495         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2496         (testGeolocationManagerCurrentPosition):
2497         (testGeolocationManagerWatchPosition):
2498         (beforeAll):
2499         (afterAll):
2500         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2501         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2502         (beforeAll): Ditto.
2503         * TestWebKitAPI/glib/CMakeLists.txt:
2504
2505 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2506
2507         [GLib] Returning G_TYPE_OBJECT from a method does not work
2508         https://bugs.webkit.org/show_bug.cgi?id=195574
2509
2510         Reviewed by Michael Catanzaro.
2511
2512         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2513
2514         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2515         (getGFile):
2516         (getParent):
2517         (createGString):
2518         (getGString):
2519         (getGStringCopyWillRaise):
2520         (getGStringCopy):
2521         (getGStringStr):
2522         (getGStringLen):
2523         (freeGString):
2524         (testJSCClass):
2525
2526 2019-03-20  Saam Barati  <sbarati@apple.com>
2527
2528         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2529         https://bugs.webkit.org/show_bug.cgi?id=195721
2530
2531         Reviewed by Filip Pizlo.
2532
2533         * Scripts/run-javascriptcore-tests:
2534
2535 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2536
2537         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2538         https://bugs.webkit.org/show_bug.cgi?id=196049
2539
2540         Reviewed by Tim Horton.
2541
2542         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2543         overflow scrolling in general, so rename it.
2544
2545         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2546
2547 2019-03-20  Daniel Bates  <dabates@apple.com>
2548
2549         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2550         https://bugs.webkit.org/show_bug.cgi?id=196031
2551         <rdar://problem/49078172>
2552
2553         Reviewed by Tim Horton.
2554
2555         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2556         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2557         same code path used when the Done button is pressed to dismiss the <select> picker.
2558
2559         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2560         (TestWebKitAPI::TEST):
2561
2562 2019-03-20  Chris Dumez  <cdumez@apple.com>
2563
2564         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2565         https://bugs.webkit.org/show_bug.cgi?id=196029
2566         <rdar://problem/48954651>
2567
2568         Reviewed by Tim Horton.
2569
2570         Add API test coverage.
2571
2572         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2573
2574 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2575
2576         [ews-build] Improve failure summary string for ApplyPatch step
2577         https://bugs.webkit.org/show_bug.cgi?id=195995
2578
2579         Reviewed by Alexey Proskuryakov.
2580
2581         * BuildSlaveSupport/ews-build/steps.py:
2582         (ApplyPatch.getResultSummary): Override getResultSummary.
2583
2584 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2585
2586         AX: Implement support for new meter ARIA role
2587         https://bugs.webkit.org/show_bug.cgi?id=195966
2588
2589         Reviewed by Chris Fleizach.
2590
2591         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2592         to AXLevelIndicator.
2593
2594         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2595
2596 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2597
2598         [WebAuthN] Implement FIDO AppID extension
2599         https://bugs.webkit.org/show_bug.cgi?id=143491
2600         <rdar://problem/48298273>
2601
2602         Reviewed by Brent Fulgham.
2603
2604         Add a test that covers the new flag of convertToU2fSignCommand.
2605
2606         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2607         (TestWebKitAPI::TEST):
2608         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2609         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2610         (TestWebKitAPI::TEST):
2611
2612 2019-03-19  Keith Rollin  <krollin@apple.com>
2613
2614         Add support for more platforms to generate-xcfilelists
2615         https://bugs.webkit.org/show_bug.cgi?id=195977
2616
2617         Reviewed by Alexey Proskuryakov.
2618
2619         generate-xcfilelists incorrectly complains when involved with building
2620         WebKit for iphonesimulator:
2621
2622             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2623             …
2624             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2625
2626         Address this by teaching generate-xcfilelists about more platforms.
2627
2628         * Scripts/generate-xcfilelists:
2629
2630 2019-03-19  John Wilander  <wilander@apple.com>
2631
2632         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2633         https://bugs.webkit.org/show_bug.cgi?id=195923
2634         <rdar://problem/49001272>
2635
2636         Reviewed by Alex Christensen.
2637
2638         This patch does the following to the TestRunner:
2639         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2640         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2641         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2642
2643         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2644         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2645         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2646         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2647         * WebKitTestRunner/TestController.cpp:
2648         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2649         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2650         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2651         * WebKitTestRunner/TestController.h:
2652         * WebKitTestRunner/TestInvocation.cpp:
2653         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2654
2655 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2656
2657         [CMake] Support more clang and gcc sanitizers
2658         https://bugs.webkit.org/show_bug.cgi?id=195956
2659
2660         Reviewed by Michael Catanzaro.
2661
2662         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2663
2664 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2665
2666         [ews-build] Improve summary for PrintConfiguration step
2667         https://bugs.webkit.org/show_bug.cgi?id=195945
2668
2669         Reviewed by Lucas Forschler.
2670
2671         * BuildSlaveSupport/ews-build/steps.py:
2672         (PrintConfiguration.getResultSummary): Override getResultSummary.
2673
2674 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2675
2676         [ews-build] Improve summary for CheckOutSource step
2677         https://bugs.webkit.org/show_bug.cgi?id=195963
2678
2679         Reviewed by Lucas Forschler.
2680
2681         * BuildSlaveSupport/ews-build/steps.py:
2682         (CheckOutSource.getResultSummary):
2683
2684 2019-03-19  Daniel Bates  <dabates@apple.com>
2685
2686         [iOS] Focus not preserved when switching between tabs
2687         https://bugs.webkit.org/show_bug.cgi?id=195820
2688         <rdar://problem/43614450>
2689
2690         Reviewed by Brent Fulgham.
2691
2692         Add tests to ensure that we restore focus when resigning and becoming first responder.
2693
2694         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2695         (TestWebKitAPI::TEST):
2696
2697 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2698
2699         Make WTFLogChannelState and WTFLogLevel enum classes
2700         https://bugs.webkit.org/show_bug.cgi?id=195904
2701
2702         Reviewed by Eric Carlson.
2703
2704         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2705         (TestWebKitAPI::TEST_F):
2706
2707 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2708
2709         [GStreamer][EME] Backported mssdemux protection data crash fix
2710         https://bugs.webkit.org/show_bug.cgi?id=195918
2711
2712         Reviewed by Philippe Normand.
2713
2714         * gstreamer/jhbuild.modules:
2715         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2716
2717 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2718
2719         Unreviewed, rolling out r243132.
2720
2721         Broke GTK build
2722
2723         Reverted changeset:
2724
2725         "Make WTFLogChannelState and WTFLogLevel enum classes"
2726         https://bugs.webkit.org/show_bug.cgi?id=195904
2727         https://trac.webkit.org/changeset/243132
2728
2729 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2730
2731         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2732
2733         * Scripts/webkitdirs.pm:
2734         (builtDylibPathForName): Adjust the shared library name that's changed
2735         with the API version bump in r243073.
2736
2737 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2738
2739         Make WTFLogChannelState and WTFLogLevel enum classes
2740         https://bugs.webkit.org/show_bug.cgi?id=195904
2741
2742         Reviewed by Eric Carlson.
2743
2744         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2745         (TestWebKitAPI::TEST_F):
2746
2747 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2748
2749         Disable flaky test added in r2431100
2750         https://webkit.org/b/195785
2751
2752         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2753         (TestWebKitAPI::TEST):
2754         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2755
2756 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2757
2758         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2759         https://bugs.webkit.org/show_bug.cgi?id=195916
2760
2761         Reviewed by Tim Horton.
2762
2763         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2764         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2765
2766 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2767
2768         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2769
2770         * Scripts/webkitpy/common/config/contributors.json:
2771
2772 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2773
2774         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2775         https://bugs.webkit.org/show_bug.cgi?id=195785
2776
2777         Reviewed by Geoffrey Garen.
2778
2779         * TestWebKitAPI/TCPServer.cpp: Added.
2780         (TestWebKitAPI::TCPServer::TCPServer):
2781         (TestWebKitAPI::TCPServer::~TCPServer):
2782         (TestWebKitAPI::TCPServer::socketBindListen):
2783         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2784         * TestWebKitAPI/TCPServer.h: Added.
2785         (TestWebKitAPI::TCPServer::port const):
2786         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2787         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2788         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2789         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2790         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2791         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2792         (TestWebKitAPI::respondSlowly):
2793         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2794         (TestWebKitAPI::downloadAtRate):
2795         (TestWebKitAPI::TEST):
2796
2797 2019-03-18  Saam Barati  <sbarati@apple.com>
2798
2799         Add a plan file for JetStream 2
2800         https://bugs.webkit.org/show_bug.cgi?id=190734
2801
2802         Reviewed by Mark Lam.
2803
2804         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2805
2806 2019-03-18  Chris Dumez  <cdumez@apple.com>
2807
2808         Delay WebProcess launch until a load is triggered in a Web view
2809         https://bugs.webkit.org/show_bug.cgi?id=195758
2810         <rdar://problem/48126013>
2811
2812         Reviewed by Geoff Garen.
2813
2814         Add API test coverage. Also update some existing API tests to not expect
2815         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2816
2817         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2818         (TestWebKitAPI::TEST):
2819         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2820         (TestWebKitAPI::TEST):
2821         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2822         (TEST):
2823         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2824         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2825         (TEST):
2826         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2827         (TEST):
2828         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2829
2830 2019-03-18  Xan Lopez  <xan@igalia.com>
2831
2832         [CMake] Prevent potential warning when determining $architecture
2833         https://bugs.webkit.org/show_bug.cgi?id=195891
2834
2835         Reviewed by Michael Catanzaro.
2836
2837         It's possible for generateBuildSystemForCMakeProject to be called
2838         before determineArchitecture() is ever called. This will make the
2839         first eq check with $architecture to be bogus (and print a
2840         warning). Change that to an eq check with architecture(), which
2841         implicitly calls determineArchitecture() if needed, and change all
2842         the other similar cases in the method in the same way to prevent
2843         future bugs like this one.
2844
2845         * Scripts/webkitdirs.pm:
2846         (generateBuildSystemFromCMakeProject):
2847
2848 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2849
2850         [WPE] Tarballs generated with “make dist” cannot build documentation
2851         https://bugs.webkit.org/show_bug.cgi?id=195885
2852
2853         Reviewed by Carlos Garcia Campos.
2854
2855         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2856
2857 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2858
2859         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2860         https://bugs.webkit.org/show_bug.cgi?id=195883
2861
2862         Reviewed by Carlos Garcia Campos.
2863
2864         * gtkdoc/gtkdoc.py:
2865         (GTKDoc._run_command): When commands fail to run, include the full command line for
2866         the program invocation and the output it has generated on the standard error stream.
2867
2868 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2869
2870         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2871         https://bugs.webkit.org/show_bug.cgi?id=195786
2872
2873         Reviewed by Philippe Normand.
2874
2875         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2876         * wpe/jhbuild.modules: Ditto.
2877
2878 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2879
2880         [ews-build] Don't run clean builds on EWS builders
2881         https://bugs.webkit.org/show_bug.cgi?id=195851
2882
2883         Reviewed by Geoffrey Garen.
2884
2885         * BuildSlaveSupport/ews-build/factories.py:
2886
2887 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2888
2889         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2890         https://bugs.webkit.org/show_bug.cgi?id=195849
2891
2892         Reviewed by Chris Dumez.
2893
2894         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2895
2896         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2897         (runWebsiteDataStoreCustomPaths):
2898
2899 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2900
2901         webkitpy: Upload test results
2902         https://bugs.webkit.org/show_bug.cgi?id=195755
2903         <rdar://problem/48896182>
2904
2905         Reviewed by Aakash Jain.
2906
2907         Establish a new format for uploading results that is not tied to layout tests, apply
2908         that format to webkitpy tests.
2909
2910         * Scripts/webkitpy/common/checkout/scm/git.py:
2911         (Git.native_branch): Return what branch the current checkout is on.
2912         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2913         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2914         * Scripts/webkitpy/common/checkout/scm/svn.py:
2915         (SVN.native_branch): Ditto.
2916         * Scripts/webkitpy/common/system/platforminfo.py:
2917         (PlatformInfo.build_version): Return a build version for Mac.
2918         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2919         (MockPlatformInfo.__init__):
2920         (MockPlatformInfo.build_version):
2921         * Scripts/webkitpy/results: Added.
2922         * Scripts/webkitpy/results/__init__.py: Added.
2923         * Scripts/webkitpy/results/options.py: Added.
2924         (upload_options): OptParse list for upload options.
2925         * Scripts/webkitpy/results/upload.py: Added.
2926         (Upload): Class which enforces the upload format expected by the results server.
2927         (Upload.Expectations):
2928         (Upload.create_configuration):
2929         (Upload.create_commit):
2930         (Upload.create_details):
2931         (Upload.create_run_stats):
2932         (Upload.create_test_result):
2933         (Upload.__init__):
2934         (Upload.Encoder): Encode Upload object as json.
2935         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2936         * Scripts/webkitpy/results/upload_unittest.py: Added.
2937         * Scripts/webkitpy/test/main.py:
2938         (Tester._parse_args): Add upload arguments.
2939         (Tester._run_tests): Allow results to be uploaded.
2940         * Scripts/webkitpy/test/runner.py:
2941         (Runner.__init__): Record which tests were run, rather than just counting them.
2942         (Runner.handle):
2943         * Scripts/webkitpy/test/runner_unittest.py:
2944         (RunnerTest.test_run):
2945         * Scripts/webkitpy/thirdparty/__init__.py:
2946         (AutoinstallImportHook.find_module): Add requests auto-install.
2947         (AutoinstallImportHook._install_requests):
2948         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2949         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2950
2951 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2952
2953         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2954         https://bugs.webkit.org/show_bug.cgi?id=195810
2955
2956         Reviewed by Tim Horton.
2957
2958         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2959         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2960         ending certain layout tests.
2961
2962         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2963         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2964         (-[TestRunnerWKWebView dealloc]):
2965         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2966
2967         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2968         helper method when destroying the web view, and when resetting state between tests.
2969
2970         * WebKitTestRunner/ios/TestControllerIOS.mm:
2971         (WTR::TestController::platformResetStateToConsistentValues):
2972
2973         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2974
2975 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2976
2977         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2978         https://bugs.webkit.org/show_bug.cgi?id=190350
2979         <rdar://problem/45089503>
2980
2981         Reviewed by Geoffrey Garen.
2982
2983         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2984         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2985         (TEST):
2986         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2987         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2988         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2989         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2990         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2991         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2992         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2993         (runTest):
2994         (createDirectories):
2995         (TEST):
2996         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2997         (TEST):
2998         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2999         (TEST):
3000
3001 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3002
3003         Add support to WebPage for getting the contents as an attributed string.
3004         https://bugs.webkit.org/show_bug.cgi?id=195636
3005         rdar://problem/45055697
3006
3007         Reviewed by Tim Horton.
3008
3009         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3010         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3011
3012 2019-03-15  Chris Dumez  <cdumez@apple.com>
3013
3014         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3015         https://bugs.webkit.org/show_bug.cgi?id=195747
3016
3017         Reviewed by Geoff Garen.
3018
3019         Add API test coverage.
3020
3021         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3022
3023 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3024
3025         Unreviewed, rolling out r242952.
3026
3027         Causing API failures on iOS Simulator
3028
3029         Reverted changeset:
3030
3031         "[PSON] Make sure the WebProcessCache is leverage when
3032         relaunching a process after termination"
3033         https://bugs.webkit.org/show_bug.cgi?id=195747
3034         https://trac.webkit.org/changeset/242952
3035
3036 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3037
3038         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3039         https://bugs.webkit.org/show_bug.cgi?id=195740
3040
3041         Reviewed by Ross Kirsling.
3042
3043         window.open doesn't work for WebKitBrowserWindow because it is not
3044         implemented yet.
3045
3046         1. Implemented createNewPage callback of WKPageUIClient.
3047         2. Changed MainWindow to take a BrowserWindow factory function
3048           instead of BrowserWindowType to be flexible to create
3049           BrowserWindow with extra settings.
3050         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3051           because it is not relevant with MainWindow anymore.
3052
3053         * MiniBrowser/win/Common.cpp:
3054         (parseCommandLine):
3055         * MiniBrowser/win/Common.h:
3056         (CommandLineOptions::CommandLineOptions):
3057         * MiniBrowser/win/MainWindow.cpp:
3058         (MainWindow::MainWindow):
3059         (MainWindow::create):
3060         (MainWindow::init):
3061         (MainWindow::WndProc):
3062         * MiniBrowser/win/MainWindow.h:
3063         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3064         (PrintWebUIDelegate::createWebViewWithRequest):
3065         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3066         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3067         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3068         (WebKitBrowserWindow::updateProxySettings):
3069         (WebKitBrowserWindow::createNewPage):
3070         * MiniBrowser/win/WebKitBrowserWindow.h:
3071         * MiniBrowser/win/WinMain.cpp:
3072         (wWinMain):
3073
3074 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3075
3076         Make it possible to test scrolling tree layer manipulation more easily
3077         https://bugs.webkit.org/show_bug.cgi?id=195780
3078
3079         Reviewed by Tim Horton.
3080         
3081         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3082         cuts off communication of scrolling tree scrolls back to the web process
3083         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3084         allows tests to trigger scrolls which run the scrolling tree layer positioning
3085         logic, but never get another commit from the web process that might mask
3086         scrolling tree bugs.
3087         
3088         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3089         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3090         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3091
3092         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3093         (WTR::UIScriptController::scrollUpdatesDisabled const):
3094         (WTR::UIScriptController::setScrollUpdatesDisabled):
3095         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3096         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3097         (WTR::UIScriptController::scrollUpdatesDisabled const):
3098         (WTR::UIScriptController::setScrollUpdatesDisabled):
3099         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3100         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3101         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3102         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3103         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3104         * WebKitTestRunner/ios/TestControllerIOS.mm:
3105         (WTR::TestController::platformResetStateToConsistentValues):
3106         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3107         (WTR::UIScriptController::scrollUpdatesDisabled const):
3108         (WTR::UIScriptController::setScrollUpdatesDisabled):
3109
3110 2019-03-14  Youenn Fablet  <youenn@apple.com>
3111
3112         Move IDB storage in private browsing mode to NetworkProcess
3113         https://bugs.webkit.org/show_bug.cgi?id=195602
3114
3115         Reviewed by Brady Eidson.
3116
3117         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3118         (TEST):
3119
3120 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3121
3122         [ews-build] Make descriptionDone messages more readable
3123         https://bugs.webkit.org/show_bug.cgi?id=195760
3124
3125         Reviewed by Lucas Forschler.
3126
3127         * BuildSlaveSupport/ews-build/steps.py:
3128         * BuildSlaveSupport/ews-build/steps_unittest.py:
3129
3130 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3131
3132         [ews-build] Generate status-bubble hover-over messages
3133         https://bugs.webkit.org/show_bug.cgi?id=195680
3134
3135         Reviewed by Lucas Forschler.
3136
3137         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3138         (StatusBubble):
3139         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3140         on hover-over.
3141         (StatusBubble._iso_time):
3142         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3143         hover-over message.
3144         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3145
3146 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3147
3148         [ews-app] Gracefully handle the case when state_string is None
3149         https://bugs.webkit.org/show_bug.cgi?id=195753
3150
3151         Reviewed by Lucas Forschler.
3152
3153         * BuildSlaveSupport/ews-app/ews/models/build.py:
3154         * BuildSlaveSupport/ews-app/ews/models/step.py:
3155
3156 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3157
3158         [ews-app] Status bubble display pending for currently running build step
3159         https://bugs.webkit.org/show_bug.cgi?id=195744
3160
3161         Reviewed by Lucas Forschler.
3162
3163         * BuildSlaveSupport/ews-build/events.py:
3164         (Events.stepStarted): If state_string is pending, replace it with step name.
3165
3166 2019-03-14  Chris Dumez  <cdumez@apple.com>
3167
3168         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3169         https://bugs.webkit.org/show_bug.cgi?id=195750
3170
3171         Reviewed by Geoffrey Garen.
3172
3173         Add API test coverage.
3174
3175         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3176         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3177         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3178         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3179
3180 2019-03-14  Chris Dumez  <cdumez@apple.com>
3181
3182         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3183         https://bugs.webkit.org/show_bug.cgi?id=195747
3184
3185         Reviewed by Geoff Garen.
3186
3187         Add API test coverage.
3188
3189         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3190
3191 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3192
3193         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3194         https://bugs.webkit.org/show_bug.cgi?id=195725
3195         <rdar://problem/48545062>
3196
3197         Reviewed by Tim Horton.
3198
3199         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3200         handler is nil.
3201
3202         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3203         (TestWebKitAPI::TEST):
3204
3205 2019-03-13  Sam Weinig  <sam@webkit.org>
3206
3207         Add utility function to allow easy reverse range-based iteration of a container
3208         https://bugs.webkit.org/show_bug.cgi?id=195542
3209
3210         Reviewed by Antti Koivisto.
3211
3212         * TestWebKitAPI/CMakeLists.txt:
3213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3214         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3215         (TestWebKitAPI::TEST):
3216         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3217
3218 2019-03-13  Chris Dumez  <cdumez@apple.com>
3219
3220         Use a ServiceWorker process per registrable domain
3221         https://bugs.webkit.org/show_bug.cgi?id=195649
3222
3223         Reviewed by Youenn Fablet.
3224
3225         Update API test coverage.
3226
3227         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3228
3229 2019-03-13  Chris Dumez  <cdumez@apple.com>
3230
3231         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3232         https://bugs.webkit.org/show_bug.cgi?id=195684
3233         <rdar://problem/48294714>
3234
3235         Reviewed by Antti Koivisto.
3236
3237         Add API test coverage.
3238
3239         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3240
3241 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3242
3243         [ews-app] Remove unused patch view
3244         https://bugs.webkit.org/show_bug.cgi?id=195669
3245
3246         Reviewed by Lucas Forschler.
3247
3248         * BuildSlaveSupport/ews-app/ews/urls.py:
3249         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3250
3251 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3252
3253         [ews-app] Use Buildbot result code variables
3254         https://bugs.webkit.org/show_bug.cgi?id=195668
3255
3256         Reviewed by Alexey Proskuryakov.
3257
3258         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3259         (Buildbot): Added Buildbot result code variables.
3260         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3261         (StatusBubble._build_bubble): Used Buildbot result code variables.
3262
3263 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3264
3265         [Flatpak] Expand submodule recursively
3266         https://bugs.webkit.org/show_bug.cgi?id=195672
3267
3268         Building WPE with flatpak was impossible without that as it was raising an exception.
3269         Also update wpebackend-fdo to match what is built in jhbuild
3270
3271         Reviewed by Philippe Normand.
3272
3273         * flatpak/flatpakutils.py:
3274         (expand_submodules_recurse):
3275         (expand_manifest):
3276         * flatpak/org.webkit.WPEModules.yaml:
3277
3278 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3279
3280         [ews-app] status bubble should be hidden for certain builds
3281         https://bugs.webkit.org/show_bug.cgi?id=194597
3282
3283         Reviewed by Dewei Zhu.
3284
3285         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3286         (StatusBubble._build_bubble):
3287         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3288         because the patch didn't have relevant changes.
3289         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3290         in production yet.
3291
3292 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3293
3294         [Win] Fix a slew of simple clang-cl warnings.
3295         https://bugs.webkit.org/show_bug.cgi?id=195652
3296
3297         Reviewed by Don Olmstead.
3298
3299         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3300         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3301
3302 2019-03-12  Justin Fan  <justin_fan@apple.com>
3303
3304         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3305         https://bugs.webkit.org/show_bug.cgi?id=195518
3306         <rdar://problem/46322356>
3307
3308         Reviewed by Myles C. Maxfield.
3309
3310         * DumpRenderTree/DerivedSources-input.xcfilelist:
3311         * DumpRenderTree/DerivedSources-output.xcfilelist:
3312
3313 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3314
3315         Unreviewed, rolling out r242825.
3316         https://bugs.webkit.org/show_bug.cgi?id=195648
3317
3318         "Broke webkitpy tests with my change to
3319         lldb_dump_class_layout.py" (Requested by rmorisset on
3320         #webkit).
3321
3322         Reverted changeset:
3323
3324         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3325         classes with suspicious padding"
3326         https://bugs.webkit.org/show_bug.cgi?id=195573
3327         https://trac.webkit.org/changeset/242825
3328
3329 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3330
3331         [ews-build] Show status bubbles while the patch is waiting in queue
3332         https://bugs.webkit.org/show_bug.cgi?id=195618
3333
3334         Reviewed by Lucas Forschler.
3335
3336         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3337         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3338         enabled in initial deployment.
3339         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3340         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3341         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3342         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3343         (StatusBubble._build_bubbles_for_patch):
3344
3345 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3346
3347         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3348         https://bugs.webkit.org/show_bug.cgi?id=195573
3349
3350         Reviewed by Simon Fraser.
3351
3352         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3353
3354         * Scripts/dump-class-layout:
3355         (main):
3356         * lldb/lldb_dump_class_layout.py:
3357         (ClassLayout.__init__):
3358         (ClassLayout._compute_padding_recursive):
3359         (LLDBDebuggerInstance.dump_layout_for_classname):
3360         (LLDBDebuggerInstance):
3361         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3362         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3363
3364 2019-03-12  Chris Dumez  <cdumez@apple.com>
3365
3366         Device Orientation access permission should be denied unless explicitly granted by the client
3367         https://bugs.webkit.org/show_bug.cgi?id=195625
3368
3369         Reviewed by Youenn Fablet.
3370
3371         add API test coverage.
3372
3373         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3374         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3375         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3376         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3377         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3378         (runDeviceOrientationTest):
3379         (TEST):
3380         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3381         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3382
3383 2019-03-12  Jer Noble  <jer.noble@apple.com>
3384
3385         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3386         https://bugs.webkit.org/show_bug.cgi?id=195137
3387         <rdar://problem/48810307>
3388
3389         Reviewed by Eric Carlson.
3390
3391         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3392         (TestWebKitAPI::TEST):
3393
3394 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3395
3396         [ews-build] Change urls from uat to production
3397         https://bugs.webkit.org/show_bug.cgi?id=195566
3398
3399         Reviewed by Lucas Forschler.
3400
3401         * BuildSlaveSupport/ews-app/ews/config.py:
3402         * BuildSlaveSupport/ews-build/events.py:
3403         * BuildSlaveSupport/ews-build/steps.py:
3404
3405 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3406
3407         [ews-build] change max_builds for local-worker to 1
3408         https://bugs.webkit.org/show_bug.cgi?id=195568
3409
3410         Reviewed by Lucas Forschler.
3411
3412         * BuildSlaveSupport/ews-build/loadConfig.py:
3413
3414 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3415
3416         Fix the build
3417
3418         * TestRunnerShared/spi/PencilKitTestSPI.h:
3419         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3420
3421 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3422
3423         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3424         https://bugs.webkit.org/show_bug.cgi?id=194131
3425
3426         Reviewed by Michael Catanzaro.
3427
3428         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3429         (uriChanged):
3430         (testUnfinishedSubresourceLoad):
3431         (serverCallback):
3432         (beforeAll):
3433
3434 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3435
3436         WTF::Expected should use std::addressof instead of operator&
3437         https://bugs.webkit.org/show_bug.cgi?id=195604
3438
3439         Reviewed by Myles Maxfield.
3440
3441         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3442         (TestWebKitAPI::Unique::Unique):
3443         (TestWebKitAPI::Unique::operator&):
3444         (TestWebKitAPI::TEST):
3445
3446 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3447
3448         Add Optional to Forward.h.
3449         https://bugs.webkit.org/show_bug.cgi?id=195586
3450
3451         Reviewed by Darin Adler.
3452
3453         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3454         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3455         Remove unnecessary includes from headers.
3456
3457 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3458
3459         Add testing API to hit-test and scroll overflow scrollers
3460         https://bugs.webkit.org/show_bug.cgi?id=195278
3461
3462         Reviewed by Antti Koivisto.
3463         
3464         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3465         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3466         
3467         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3468
3469         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3470         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3471         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3472         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3473         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3474         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3475         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3476         (WTR::enclosingScrollViewIncludingSelf):
3477         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3478
3479 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3480
3481         API test WebKit.RequestTextInputContext fails on iOS
3482         https://bugs.webkit.org/show_bug.cgi?id=195585
3483
3484         Reviewed by Wenson Hsieh and Simon Fraser.
3485
3486         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3487         (applyStyle):
3488         (TEST):
3489         Add a viewport, so that the coordinates match up on iOS.
3490         Scroll by moving the UIScrollView's contentOffset.
3491
3492 2019-03-11  Chris Dumez  <cdumez@apple.com>
3493
3494         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3495         https://bugs.webkit.org/show_bug.cgi?id=195506
3496         <rdar://problem/48733477>
3497
3498         Reviewed by Alex Christensen.
3499
3500         Add API test coverage.
3501
3502         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3503
3504 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3505
3506         Adding myself to contributors.json
3507
3508         Unreviewed, addming myself to contributors.json .
3509
3510         * Scripts/webkitpy/common/config/contributors.json:
3511
3512 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3513
3514         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3515         https://bugs.webkit.org/show_bug.cgi?id=195511
3516         <rdar://problem/44873269>
3517
3518         Reviewed by Darin Adler.
3519
3520         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3521         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3522         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3523         (TEST_F):
3524
3525 2019-03-11  Chris Dumez  <cdumez@apple.com>
3526
3527         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3528         https://bugs.webkit.org/show_bug.cgi?id=195561
3529
3530         Reviewed by Youenn Fablet.
3531
3532         Make sure the JS in the test requests for permission to receive device orientation events.
3533
3534         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3535
3536 2019-03-11  Youenn Fablet  <youenn@apple.com>
3537
3538         Allow storage quota increase by default in WTR
3539         https://bugs.webkit.org/show_bug.cgi?id=195541
3540
3541         Reviewed by Geoffrey Garen.
3542
3543         Allow storage quota increase by default in WTR.
3544         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3545         Use this for tests that explicitly need cache increase.
3546
3547         Instead of increasing quota by 2, make sure the next request is
3548         granted by adding all given parameters.
3549
3550         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3551         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3552         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3553         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3554         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3555         * WebKitTestRunner/TestController.cpp:
3556         (WTR::TestController::setAllowStorageQuotaIncrease):
3557         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3558         * WebKitTestRunner/TestController.h:
3559         * WebKitTestRunner/TestInvocation.cpp:
3560         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3561         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3562         (WTR::TestController::cocoaResetStateToConsistentValues):
3563         (WTR::TestController::setAllowStorageQuotaIncrease):
3564         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3565         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3566         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3567
3568 2019-03-11  Xan Lopez  <xan@igalia.com>
3569
3570         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3571         https://bugs.webkit.org/show_bug.cgi?id=194147
3572
3573         Reviewed by Michael Saboff.
3574
3575         To make --32-bit work correctly on Linux/64bit we need to:
3576
3577         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3578         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3579         unfortunately CMake only allows us to do this during
3580         crosscompilation, which is overkill here.
3581         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3582         pkg-config detection module uses the x86 .pc files instead of the
3583         x86_64 ones.
3584         - Set the -m32 flags for the compiler.
3585
3586         * Scripts/webkitdirs.pm:
3587         (generateBuildSystemFromCMakeProject):
3588
3589 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3590
3591         Add MotionMark-1.1 plan file for run-benchmark script.
3592         https://bugs.webkit.org/show_bug.cgi?id=195481
3593
3594         Rubber-stamped by Darin Adler.
3595
3596         Run-benchmark script should support MontionMark-1.1.
3597
3598         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3599
3600 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3601
3602         [ews-app] Add support for submit-to-ews url
3603         https://bugs.webkit.org/show_bug.cgi?id=195477
3604
3605         Reviewed by Lucas Forschler.
3606
3607         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3608         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3609         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3610         * BuildSlaveSupport/ews-app/ews/urls.py:
3611         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3612
3613 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3614
3615         Unreviewed, rolling out r242688, r242643, r242624.
3616
3617         Caused multiple layout test failures and crashes on iOS and macOS.
3618
3619         Reverted changeset:
3620
3621         "requestAnimationFrame should execute before the next frame"
3622         https://bugs.webkit.org/show_bug.cgi?id=177484
3623         https://trac.webkit.org/changeset/242624/webkit
3624
3625         * Tracing/SystemTracePoints.plist:
3626
3627 2019-03-11  John Wilander  <wilander@apple.com>
3628
3629         Resource Load Statistics: Make it possible exclude localhost from classification
3630         https://bugs.webkit.org/show_bug.cgi?id=195474
3631         <rdar://problem/47520577>
3632
3633         Reviewed by Brent Fulgham.
3634
3635         This patch allows for localhost to be excluded from classification and
3636         treatment as a prevalent resource.
3637
3638         The WebKit Tools change adds a new function called
3639         testRunner.setStatisticsIsRunningTest() which can be used to control this
3640         behavior.
3641
3642         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3643         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3644         (WTR::TestRunner::setStatisticsIsRunningTest):
3645         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3646         * WebKitTestRunner/TestController.cpp:
3647         (WTR::TestController::setStatisticsIsRunningTest):
3648         * WebKitTestRunner/TestController.h:
3649         * WebKitTestRunner/TestInvocation.cpp:
3650         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3651
3652 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3653
3654         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3655         https://bugs.webkit.org/show_bug.cgi?id=195560
3656
3657         Reviewed by Lucas Forschler.
3658
3659         * BuildSlaveSupport/ews-build/master.cfg:
3660
3661 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3662
3663         Unreviewed, rolling out r242698.
3664
3665         API test crashes on bots.
3666
3667         Reverted changeset:
3668
3669         "Add a WKContentRuleList variant that uses copied memory
3670         instead of mmap'd shared memory for class A containerized
3671         apps"
3672         https://bugs.webkit.org/show_bug.cgi?id=195511
3673         https://trac.webkit.org/changeset/242698
3674
3675 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3676
3677         [WPE] Enable web process sandbox
3678         https://bugs.webkit.org/show_bug.cgi?id=195169
3679
3680         Reviewed by Daniel Bates.
3681
3682         * wpe/install-dependencies:
3683         * wpe/jhbuild.modules:
3684
3685 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3686
3687         [ews-app] Use port 17000 for worker communication
3688         https://bugs.webkit.org/show_bug.cgi?id=195558
3689
3690         Reviewed by Lucas Forschler.
3691
3692         * BuildSlaveSupport/ews-build/master.cfg:
3693
3694 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3695
3696         [ews-build] unit-tests fail when passwords.json is missing
3697         https://bugs.webkit.org/show_bug.cgi?id=195557
3698
3699         Reviewed by Lucas Forschler.
3700
3701         * BuildSlaveSupport/ews-build/loadConfig.py:
3702         (loadBuilderConfig):
3703         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3704         (ConfigDotJSONTest.test_configuration):
3705         * BuildSlaveSupport/ews-build/master.cfg:
3706
3707 2019-03-11  Truitt Savell  <tsavell@apple.com>
3708
3709         Unreviewed, rolling out r242702.
3710
3711         Broke High Sierra builders.
3712
3713         Reverted changeset:
3714
3715         "Add utility function to allow easy reverse range-based
3716         iteration of a container"
3717         https://bugs.webkit.org/show_bug.cgi?id=195542
3718         https://trac.webkit.org/changeset/242702
3719
3720 2019-03-11  Sam Weinig  <sam@webkit.org>
3721
3722         Add utility function to allow easy reverse range-based iteration of a container
3723         https://bugs.webkit.org/show_bug.cgi?id=195542
3724
3725         Reviewed by Antti Koivisto.
3726
3727         * TestWebKitAPI/CMakeLists.txt:
3728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3729         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3730         (TestWebKitAPI::TEST):
3731         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3732
3733 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3734
3735         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3736         https://bugs.webkit.org/show_bug.cgi?id=195511
3737         <rdar://problem/44873269>
3738
3739         Reviewed by Darin Adler.
3740
3741         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3742         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3743         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3744         (TEST_F):
3745
3746 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3747
3748         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3749         https://bugs.webkit.org/show_bug.cgi?id=195499
3750
3751         Reviewed by Darin Adler.
3752
3753         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3754         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3755         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3756         (-[WKWebView synchronouslyFocusTextInputContext:]):
3757         (applyStyle):
3758         (applyIframe):
3759         (TEST):
3760         Add some tests for this SPI.
3761
3762 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3763
3764         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3765         https://bugs.webkit.org/show_bug.cgi?id=181151
3766
3767         Reviewed by Don Olmstead.
3768
3769         * TestWebKitAPI/CMakeLists.txt:
3770         * TestWebKitAPI/PlatformWin.cmake:
3771         Enable TestWTF RunLoop tests in all platforms.
3772
3773         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3774         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3775         (TestWebKitAPI::DerivedOneShotTimer::fired):
3776         (TestWebKitAPI::TEST):
3777         Only a few platforms support nested RunLoop.
3778
3779         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3780         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3781
3782 2019-03-10  David Quesada  <david_quesada@apple.com>
3783
3784         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3785         https://bugs.webkit.org/show_bug.cgi?id=152480
3786
3787         Reviewed by Chris Dumez.
3788
3789         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3790         there are no additional references to the process pool besides the one held by
3791         the download, waits for the download to finish (in the sense that the
3792         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3793         measure, also check that the process pool has been deallocated at the end of the
3794         test. The test wouldn't be meaningful if the process pool were still alive.
3795
3796         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3797         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3798         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3799             The download will be canceled because the delegate does not implement the
3800             method to decide the download's destination, so this is where we know the
3801             DownloadProxyMap is done with the DownloadProxy.
3802         (TEST):
3803
3804 2019-03-08  Chris Dumez  <cdumez@apple.com>
3805
3806         Add support for Device Orientation / Motion permission API
3807         https://bugs.webkit.org/show_bug.cgi?id=195329
3808         <rdar://problem/47645367>
3809
3810         Reviewed by Geoffrey Garen.
3811
3812         Add test infrastructure to help test the Device Orientation / Motion permission API.
3813
3814         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3815         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3816         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3817         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3818         * WebKitTestRunner/TestController.cpp:
3819         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3820         (WTR::TestController::createWebViewWithOptions):
3821         (WTR::TestController::resetStateToConsistentValues):
3822         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3823         * WebKitTestRunner/TestController.h:
3824         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3825         * WebKitTestRunner/TestInvocation.cpp:
3826         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3827
3828 2019-03-08  Saam barati  <sbarati@apple.com>
3829
3830         Add a compare-results script to compare benchmark results
3831         https://bugs.webkit.org/show_bug.cgi?id=195486
3832         <rdar://problem/48723397>
3833
3834         Reviewed by Geoffrey Garen.
3835
3836         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3837         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3838         to extend it to learn about our other benchmarks.
3839
3840         * Scripts/compare-results: Added.
3841         (readJSONFile):
3842         (detectJetStream2):
3843         (JetStream2Results):
3844         (detectSpeedometer2):
3845         (Speedometer2Results):
3846         (detectPLT5):
3847         (PLT5Results):
3848         (detectBenchmark):
3849         (biggerIsBetter):
3850         (ttest):
3851         (getOptions):
3852         (main):
3853
3854 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3855
3856         Ensure old tab state is cleared between iterations of run-benchmark
3857         https://bugs.webkit.org/show_bug.cgi?id=195393
3858         <rdar://problem/46885583>
3859
3860         Reviewed by Dewei Zhu.
3861
3862         a) ensure the default to restore state is not set
3863         b) terminate Safari correctly
3864         c) Set the system default to ignore Persistent State in Safari
3865
3866         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3867         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3868         (OSXBrowserDriver.prepare_env): 
3869         (OSXBrowserDriver.restore_env):
3870         (OSXBrowserDriver.close_browsers):
3871         (OSXBrowserDriver._terminate_processes):
3872         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3873         (OSXChromeDriver):
3874         (OSXChromeCanaryDriver):
3875         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3876         (OSXFirefoxDriver):
3877         (OSXFirefoxNightlyDriver):
3878         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3879         (OSXSafariDriver):
3880         (OSXSafariDriver.prepare_env):
3881
3882 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3883
3884         [GTK] Several InputMethodFilter tests are failing
3885         https://bugs.webkit.org/show_bug.cgi?id=195408
3886
3887         Reviewed by Carlos Garcia Campos.
3888
3889         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3890         Regressed in r241751.
3891         Hexadecimal values of keycodes are expressed now in upper letters.
3892         Composited characters should be cast to UTF8 strings.
3893
3894         (TestWebKitAPI::TEST):
3895
3896 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3897
3898         [GTK] Make Tools/gtkdoc python3 compatible
3899         https://bugs.webkit.org/show_bug.cgi?id=195359
3900
3901         Reviewed by Carlos Garcia Campos.
3902
3903         * gtkdoc/generate-gtkdoc:
3904         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3905         work with Python 2 and 3.
3906         (get_gtkdoc_module_paths):
3907         The iteritems() was removed in Python 3, so let's use items() that's
3908         available in Python 2 and 3.
3909         (get_generator_for_config):
3910         * gtkdoc/gtkdoc.py:
3911         (GTKDoc._run_command):
3912         The sys.stdout.write() is expecting str in Python 3 and not bytes
3913         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3914         for passing the bytes there.
3915
3916 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3917
3918         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3919         https://bugs.webkit.org/show_bug.cgi?id=195346
3920         <rdar://problem/48667048>
3921
3922         Unreviewed build fix for clang-cl.
3923
3924         * DumpRenderTree/win/DumpRenderTree.cpp:
3925         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3926
3927 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3928
3929         requestAnimationFrame should execute before the next frame
3930         https://bugs.webkit.org/show_bug.cgi?id=177484
3931
3932         Reviewed by Simon Fraser.
3933
3934         Add trace points for the page RenderingUpdate.
3935
3936         * Tracing/SystemTracePoints.plist:
3937
3938 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3939
3940         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3941         https://bugs.webkit.org/show_bug.cgi?id=195353
3942         <rdar://problem/48626394>
3943
3944         Reviewed by Simon Fraser.
3945
3946         * WebKitTestRunner/ios/TestControllerIOS.mm:
3947         (WTR::TestController::platformResetPreferencesToConsistentValues):
3948
3949 2019-03-07  John Wilander  <wilander@apple.com>
3950
3951         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3952         https://bugs.webkit.org/show_bug.cgi?id=195383
3953         <rdar://problem/48570136>
3954
3955         Reviewed by Brent Fulgham.
3956
3957         This patch adds test infrastructure to purge only script-accessible cookies,
3958         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3959
3960         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3961         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3962         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3963         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3964         * WebKitTestRunner/TestController.cpp:
3965         (WTR::TestController::statisticsDeleteCookiesForHost):
3966         * WebKitTestRunner/TestController.h:
3967         * WebKitTestRunner/TestInvocation.cpp:
3968         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3969
3970 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3971
3972         Unreviewed, rolling out r242354.
3973         https://bugs.webkit.org/show_bug.cgi?id=195402
3974
3975         breaks layout tests in all configurations (Requested by
3976         zdobersek on #webkit).
3977
3978         Reverted changeset:
3979
3980         "[WPE] Enable web process sandbox"
3981         https://bugs.webkit.org/show_bug.cgi?id=195169
3982         https://trac.webkit.org/changeset/242354
3983
3984 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3985
3986         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3987         https://bugs.webkit.org/show_bug.cgi?id=195346
3988
3989         Reviewed by Fujii Hironori.
3990
3991         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3992         (TestWebKitAPI::TEST):
3993         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3994
3995         * DumpRenderTree/win/DumpRenderTree.cpp:
3996         (findFontFallback):
3997         (addFontFallbackIfPresent):
3998         (removeFontFallbackIfPresent):
3999         (main):
4000         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4001         (TestWebKitAPI::Util::moduleDirectory):
4002         (TestWebKitAPI::Util::createInjectedBundlePath):
4003         Use wchar helpers as needed.
4004
4005 2019-03-06  Rob Buis  <rbuis@igalia.com>
4006
4007         Consider supporting the `referrerpolicy` attribute.
4008         https://bugs.webkit.org/show_bug.cgi?id=179053
4009
4010         Reviewed by Darin Adler.
4011
4012         Add a runtime flag for referrerpolicy attribute.
4013
4014         * DumpRenderTree/mac/DumpRenderTree.mm:
4015         (enableExperimentalFeatures):
4016
4017 2019-03-05  Daniel Bates  <dabates@apple.com>
4018
4019         Update expected API test result following r242379
4020         (https://bugs.webkit.org/show_bug.cgi?id=195125)
4021
4022         Update expected x-coordinate of selection rect now that the left padding of
4023         a textarea is sized in ems (so dependent on the font size) just like the left
4024         padding of a text field.
4025
4026         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4027         (TestWebKitAPI::TEST):
4028
4029 2019-03-05  David Quesada  <david_quesada@apple.com>
4030
4031         [WK2] It should be possible to follow links with 'download' attributes
4032         https://bugs.webkit.org/show_bug.cgi?id=195145
4033         rdar://problem/48462642
4034
4035         Reviewed by Alex Christensen.
4036
4037         Add a unit test to verify that activating links with 'download' attributes now
4038         navigates to the linked resource, rather than starts downloading it. Add another
4039         to verify that it is still possible to explicitly download the link via the
4040         'Download' navigation action policy.
4041
4042         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4043         (-[DownloadAttributeTestDelegate init]):
4044         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
4045         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
4046         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
4047         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
4048         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4049         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
4050         (TEST):
4051         * WebKitTestRunner/TestController.cpp:
4052         (WTR::TestController::decidePolicyForNavigationAction):
4053         * WebKitTestRunner/TestController.h:
4054
4055 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
4056
4057         [Curl] Implement Cookie Accept Policy.
4058         https://bugs.webkit.org/show_bug.cgi?id=191645
4059
4060         Reviewed by Fujii Hironori.
4061
4062         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4063         (TestWebKitAPI::Curl::TEST_F):
4064
4065 2019-03-05  Youenn Fablet  <youenn@apple.com>
4066
4067         Rename requestCacheStorageSpace to requestStorageSpace
4068         https://bugs.webkit.org/show_bug.cgi?id=195282
4069
4070         Reviewed by Chris Dumez.
4071
4072         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4073         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4074         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
4075
4076 2019-03-05  Brady Eidson  <beidson@apple.com>
4077
4078         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
4079         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
4080
4081         Reviewed by Tim Horton.
4082
4083         Loading a file: URL into a WKWebView and then loading another file: url from a completely
4084         different directory into that same WKWebView should work.
4085
4086         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4087         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
4088
4089 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
4090
4091         Add WeakHashSet
4092         https://bugs.webkit.org/show_bug.cgi?id=195152
4093
4094         Reviewed by Antti Koivisto.
4095
4096         Added tests for WeakHashSet.
4097
4098         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4099         (TestWebKitAPI::Base::Base): Moved.
4100         (TestWebKitAPI::Derived::foo): Moved.
4101         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
4102         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
4103         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
4104         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
4105
4106 2019-03-04  Chris Dumez  <cdumez@apple.com>
4107
4108         Do not share WebProcesses between private and regular sessions
4109         https://bugs.webkit.org/show_bug.cgi?id=195189
4110         <rdar://problem/48421064>
4111
4112         Reviewed by Alex Christensen.
4113
4114         Add API test coverage.
4115
4116         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4117         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4118
4119 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
4120
4121         [WPE] Enable web process sandbox
4122         https://bugs.webkit.org/show_bug.cgi?id=195169
4123
4124         Reviewed by Daniel Bates.
4125
4126         * wpe/install-dependencies:
4127         * wpe/jhbuild.modules:
4128
4129 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4130
4131         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
4132         https://bugs.webkit.org/show_bug.cgi?id=195206
4133
4134         Reviewed by Žan Doberšek.
4135
4136         Add a new test case.
4137
4138         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4139         (testJSCClass):
4140
4141 2019-03-04  Charlie Turner  <cturner@igalia.com>
4142
4143         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
4144         https://bugs.webkit.org/show_bug.cgi?id=194898
4145
4146         Reviewed by Žan Doberšek.
4147
4148         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
4149         a GCC extension that permits arithmetic on void* pointer. Inline
4150         the macro until this issue is fixed upstream.
4151
4152 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4153
4154         Rid the world of WK_API_ENABLED
4155         https://bugs.webkit.org/show_bug.cgi?id=195263
4156
4157         Reviewed by Dan Bernstein.
4158
4159         List of changed files elided because it's useless.
4160
4161 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4162
4163         Unreviewed follow-up to r242292.
4164
4165         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4166
4167         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4168         (TestWebKitAPI::testStrip): Renamed from strip.
4169         (TestWebKitAPI::TEST):
4170
4171 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4172
4173         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4174
4175         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4176         and bug #194272 for details.
4177
4178         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4179
4180 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4181
4182         Remove some more unused 32-bit code
4183         https://bugs.webkit.org/show_bug.cgi?id=195255
4184
4185         Reviewed by Darin Adler.
4186
4187         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4188         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4189         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4190         (NPP_New):
4191         (NPP_HandleEvent):
4192         (handleEventCarbon): Deleted.
4193
4194 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4195
4196         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4197
4198         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4199         (TestWebKitAPI::TEST):
4200
4201 2019-03-01  Darin Adler  <darin@apple.com>
4202
4203         Finish removing String::format
4204         https://bugs.webkit.org/show_bug.cgi?id=194893
4205
4206         Reviewed by Daniel Bates.
4207 '
4208         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4209
4210 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4211
4212         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4213         https://bugs.webkit.org/show_bug.cgi?id=195229
4214         <rdar://problem/48520362>
4215
4216         Reviewed by Chris Dumez.
4217
4218         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4219         (TEST):
4220
4221 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4222
4223         Add a system trace scope for event region building
4224         https://bugs.webkit.org/show_bug.cgi?id=195226
4225
4226         Reviewed by Jon Lee.
4227
4228         This trace scope measures the time spend converting element rects into Region objects,
4229         which can be large on some pages.
4230
4231         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4232
4233         * Tracing/SystemTracePoints.plist:
4234
4235 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4236
4237         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4238         https://bugs.webkit.org/show_bug.cgi?id=194612
4239
4240         Reviewed by Alex Christensen.
4241
4242         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4243         Just test the new string-processing function and don't touch the actual environment.
4244         (Test cases are all as before, but based on operator== instead of strcmp.)
4245
4246 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4247
4248         [ews-app] Update primary keys for handling multiple Buildbot instances
4249         https://bugs.webkit.org/show_bug.cgi?id=195120
4250
4251         Reviewed by Stephanie Lewis.
4252
4253         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4254         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4255         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4256
4257         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4258         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4259         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4260         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4261         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4262         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4263
4264 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4265
4266         [WinCairo] Enable service worker
4267         https://bugs.webkit.org/show_bug.cgi?id=188318
4268
4269         Reviewed by Youenn Fablet.
4270
4271         * DumpRenderTree/DumpRenderTreePrefix.h:
4272         * TestWebKitAPI/PlatformWin.cmake:
4273         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4274         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4275         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4276
4277 2019-03-01  Justin Fan  <justin_fan@apple.com>
4278
4279         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4280         https://bugs.webkit.org/show_bug.cgi?id=195191
4281
4282         Rubber-stamped by Dean Jackson.
4283
4284         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4285
4286         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4287
4288 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4289
4290         Unreviewed, fix lldb webkitpy tests
4291         https://bugs.webkit.org/show_bug.cgi?id=194375
4292
4293         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4294
4295         * lldb/lldb_webkit.py:
4296         (WTFStringImplProvider.is_8bit):
4297
4298 2019-02-28  David Quesada  <david_quesada@apple.com>
4299
4300         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4301         https://bugs.webkit.org/show_bug.cgi?id=195121
4302         rdar://problem/48450302
4303
4304         Reviewed by Alex Christensen.
4305
4306         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4307         configurations where the 'download' attribute is absent, blank, or populated
4308         with a filename, and where the anchor element is same-origin or cross-origin
4309         (meaning the 'download' attribute shouldn't be honored).
4310
4311         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4312         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4313         (-[NavigationActionTestDelegate init]):
4314         (-[NavigationActionTestDelegate navigationAction]):
4315         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4316         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4317         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4318         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4319         (TEST):
4320
4321 2019-02-28  Antoine Quint  <graouts@apple.com>
4322
4323         Enable the Pointer Events runtime flag by default
4324         https://bugs.webkit.org/show_bug.cgi?id=195156
4325
4326         Reviewed by Dean Jackson.
4327
4328         * DumpRenderTree/mac/DumpRenderTree.mm:
4329         (enableExperimentalFeatures):
4330
4331 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4332
4333         Several PasteImage API tests are flaky
4334         https://bugs.webkit.org/show_bug.cgi?id=195160
4335
4336         Reviewed by Tim Horton.
4337
4338         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4339         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4340         listening for a "load" event after image load is already complete.
4341
4342         To address this, make these tests first register a "load" event handler, then run script to insert an image
4343         element into the document, and finally wait until the load event is observed before checking image size.
4344
4345         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4346
4347 2019-02-28  Chris Dumez  <cdumez@apple.com>
4348
4349         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4350         https://bugs.webkit.org/show_bug.cgi?id=195107
4351
4352         Reviewed by Alex Christensen.
4353
4354         Give some time for the zoom level to get restored.
4355
4356         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4357
4358 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4359