Unreviewed, rolling out r148247.
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-11  Commit Queue  <rniwa@webkit.org>
2
3         Unreviewed, rolling out r148247.
4         http://trac.webkit.org/changeset/148247
5         https://bugs.webkit.org/show_bug.cgi?id=114490
6
7         Cairo dep fails to build on builders due to missing EGL
8         headers (Requested by zdobersek on #webkit).
9
10         * Scripts/webkitdirs.pm:
11         (buildAutotoolsProject):
12         * gtk/jhbuild.modules:
13
14 2013-04-11  Martin Robinson  <mrobinson@igalia.com>
15
16         [GTK] Add accelerated 2D canvas support using cairo-gl
17         https://bugs.webkit.org/show_bug.cgi?id=104672
18
19         Reviewed by Alejandro G. Castro.
20
21         Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
22         dependencies, don't override value of the setting determined by configure.
23         This will make it easier for people using build-webkit, but not the
24         WebKit JHBuild.
25
26         * Scripts/webkitdirs.pm:
27         (buildAutotoolsProject): Add a blacklist for settings to never override.
28         * gtk/jhbuild.modules: Build CairoGL.
29
30 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
31
32         build.webkit.org should link to webkit-queues instead of webkit-commit-queue
33         https://bugs.webkit.org/show_bug.cgi?id=114477
34
35         Reviewed by Benjamin Poulain.
36
37         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
38
39 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
40
41         Leaks builder should not be triggered upon new commits
42         https://bugs.webkit.org/show_bug.cgi?id=114475
43
44         Reviewed by Jessie Berlin.
45
46         Don't trigger them on new checkins. Wait for Mountain Lion (Build), which already triggers
47         the leak builder when builds are done.
48
49         * BuildSlaveSupport/build.webkit.org-config/config.json:
50
51 2013-04-11  Kalev Lember  <kalevlember@gmail.com>
52
53         [GTK] Windows build failure after r136056
54         https://bugs.webkit.org/show_bug.cgi?id=114121
55
56         Reviewed by Martin Robinson.
57
58         * TestWebKitAPI/config.h: Make sure defines are correct for other
59         Windows ports than apple-win.
60
61 2013-04-11  Ojan Vafai  <ojan@chromium.org>
62
63         Remove myself from watchlists.
64         * Scripts/webkitpy/common/config/watchlist:
65
66 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
67
68         Build fix. Don't hard-code queues.webkit.org at least during the transition.
69
70         * QueueStatusServer/templates/statusbubble.html:
71
72 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
73
74         Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
75         https://bugs.webkit.org/show_bug.cgi?id=114397
76
77         Reviewed by Benjamin Poulain.
78
79         Reland the patch since Alan appears to have finished the migration.
80
81         * Scripts/webkitpy/common/net/statusserver.py:
82         (StatusServer):
83
84 2013-04-11  Brian Holt  <brian.holt@samsung.com>
85
86         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
87         https://bugs.webkit.org/show_bug.cgi?id=76796
88
89         Reviewed by Chris Fleizach.
90
91         Make the Gtk window for the DRT a toplevel so that it gets the
92         focus from the window manager when the test starts.
93
94         * DumpRenderTree/gtk/DumpRenderTree.cpp:
95         (main):
96
97 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
98
99         Use CSS4 image-rendering to determing image scaling quality
100         https://bugs.webkit.org/show_bug.cgi?id=113405
101
102         Reviewed by Simon Fraser.
103
104         Introduce new flag to enable experimental support for CSS4 Images.
105
106         * Scripts/webkitperl/FeatureList.pm:
107
108 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
109
110         Remove code for Chromium from wkbuild.py
111         https://bugs.webkit.org/show_bug.cgi?id=114423
112
113         Reviewed by Benjamin Poulain.
114
115         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
116         (_should_file_trigger_build):
117         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
118         (ShouldBuildTest):
119
120 2013-04-11  Philippe Normand  <pnormand@igalia.com>
121
122         Unreviewed, update my IRC nickname.
123
124         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
125
126 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
127
128         Remove the rest of Chromium code from webkitpy
129         https://bugs.webkit.org/show_bug.cgi?id=114420
130
131         Reviewed by Benjamin Poulain.
132
133         * Scripts/webkitpy/common/config/urls.py:
134         (view_revision_url):
135         * Scripts/webkitpy/common/host.py:
136         (Host._engage_awesome_locale_hacks):
137         (Host.initialize_scm):
138         (Host):
139         * Scripts/webkitpy/common/host_mock.py:
140         (MockHost.__init__):
141         (MockHost.checkout):
142         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
143         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
144         (JSONResultsGeneratorBase._insert_generic_metadata):
145         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
146         (TestExpectationParser._tokenize_line):
147         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
148         (ExpectationSyntaxTests.test_bare_name_and_bugs):
149         (ExpectationSyntaxTests.test_warnings):
150         * Scripts/webkitpy/layout_tests/port/base.py:
151         (Port.skips_perf_test):
152         (Port.path_to_test_expectations_file):
153         (Port._port_flag_for_scripts):
154         * Scripts/webkitpy/style/checkers/cpp.py:
155         (check_function_definition):
156         (check_include_line):
157         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
158         (OrderOfIncludesTest.test_check_wtf_includes):
159         (WebKitStyleTest.test_webkit_export_check):
160         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
161         (TestExpectationsTestCase.test_valid_expectations):
162         * Scripts/webkitpy/tool/bot/irc_command.py:
163         (Rollout.execute):
164         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
165         (IRCCommandTest.test_whois):
166         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
167         (IRCBotTest.test_help):
168         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
169         (SheriffBotTest.test_command_aliases):
170
171 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
172
173         roll-chromium-deps doesn't roll DEPS
174         https://bugs.webkit.org/show_bug.cgi?id=114421
175
176         Reviewed by Antti Koivisto.
177
178         Roll DEPS. Rolling DEPS. Rolled DEPS.
179
180         * Scripts/webkitpy/tool/bot/irc_command.py:
181         (RollChromiumDEPS.execute):
182
183 2013-04-11  Glenn Adams  <glenn@skynav.com>
184
185         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
186         https://bugs.webkit.org/show_bug.cgi?id=114418
187
188         Reviewed by Ryosuke Niwa.
189
190         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
191         (MockSCM.add): Remove optional remove_exit_code argument.
192         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
193         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
194         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
195         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
196
197 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
198
199         Fix roll-chromium-deps and hi.
200
201         * Scripts/webkitpy/tool/bot/irc_command.py:
202         (Hi.execute):
203         (RollChromiumDEPS.execute):
204
205 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
206
207         Remove webkitpy code to roll Chromium DEPS
208         https://bugs.webkit.org/show_bug.cgi?id=114415
209
210         Reviewed by Benjamin Poulain.
211
212         Removed the code to roll Chromium DEPS in WebKit.
213
214         * Scripts/webkitpy/common/checkout/checkout.py:
215         (Checkout.bug_id_for_this_commit):
216         * Scripts/webkitpy/common/checkout/checkout_mock.py:
217         (MockCheckout.commit_message_for_this_commit):
218         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
219         (CheckoutTest.test_suggested_reviewers):
220         * Scripts/webkitpy/common/checkout/deps.py: Removed.
221         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
222         * Scripts/webkitpy/tool/bot/irc_command.py:
223         (RollChromiumDEPS): Teach webkitbot a sense of humor.
224         (RollChromiumDEPS.execute):
225         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
226         (IRCCommandTest.test_create_bug):
227         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
228         (IRCBotTest.test_revert):
229         * Scripts/webkitpy/tool/bot/sheriff.py:
230         (Sheriff.post_rollout_patch):
231         * Scripts/webkitpy/tool/commands/__init__.py:
232         * Scripts/webkitpy/tool/commands/roll.py: Removed.
233         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
234         * Scripts/webkitpy/tool/steps/__init__.py:
235         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
236         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
237         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
238
239 2013-04-11  Glenn Adams  <glenn@skynav.com>
240
241         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
242         https://bugs.webkit.org/show_bug.cgi?id=114386
243
244         Reviewed by Benjamin Poulain.
245
246         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
247         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
248         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
249         by default and to return exit code 1 if a file/dir had already been added.
250
251         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
252         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
253         * Scripts/webkitpy/common/checkout/scm/svn.py:
254         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
255
256 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
257
258         Unreviewed.
259
260         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
261
262 2013-04-10  Glenn Adams  <glenn@skynav.com>
263
264         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
265         https://bugs.webkit.org/show_bug.cgi?id=114410
266
267         Reviewed by Ryosuke Niwa.
268
269         * Scripts/webkitpy/common/checkout/scm/git.py:
270         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
271         * Scripts/webkitpy/common/checkout/scm/scm.py:
272         (SCM.add): Remove optional return_exit_code argument.
273         (SCM.add_list): Remove optional return_exit_code argument.
274         * Scripts/webkitpy/common/checkout/scm/svn.py:
275         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
276
277 2013-04-10  Eric Seidel  <eric@webkit.org>
278
279         Remove myself from the watchlists, I'm getting too much bug mail. :)
280
281         * Scripts/webkitpy/common/config/watchlist:
282
283 2013-04-10  Commit Queue  <rniwa@webkit.org>
284
285         Unreviewed, rolling out r148158.
286         http://trac.webkit.org/changeset/148158
287         https://bugs.webkit.org/show_bug.cgi?id=114405
288
289         We need to migrate status data (Requested by rniwa on
290         #webkit).
291
292         * Scripts/webkitpy/common/net/statusserver.py:
293         (StatusServer):
294
295 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
296
297         Mass remove all the empty directories
298
299         Rubberstamped by Ryosuke Niwa.
300
301         * BuildSlaveSupport/gtk/crashmon/log: Removed.
302         * BuildSlaveSupport/gtk/xvfb/log: Removed.
303         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
304         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
305         * MiniBrowser/gtk/WebBundle: Removed.
306         * MiniBrowser/win: Removed.
307         * QtTestPlatformPlugin/mac: Removed.
308         * Scripts/webkitpy/tool/bot/testdata: Removed.
309         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
310         * efl/ImageDiff: Removed.
311         * iExploder/htdocs: Removed.
312         * iExploder/iexploder-1.7.2/output: Removed.
313         * iExploder/tools: Removed.
314         * qmake/config.tests/libexecdir: Removed.
315         * qmake/config.tests/libjpeg: Removed.
316         * qmake/config.tests/libpng: Removed.
317
318 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
319
320         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
321         https://bugs.webkit.org/show_bug.cgi?id=114397
322
323         Reviewed by Benjamin Poulain.
324
325         * Scripts/webkitpy/common/net/statusserver.py:
326         (StatusServer):
327
328 2013-04-10  Adam Barth  <abarth@webkit.org>
329
330         Remove abarth from watchlists
331         https://bugs.webkit.org/show_bug.cgi?id=114390
332
333         Reviewed by Ryosuke Niwa.
334
335         I'm trying to cut down on the amount of bugmail I get so that I'll have
336         more of a chance to notice a piece of bugmail directed at me.
337
338         * Scripts/webkitpy/common/config/watchlist:
339
340 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
341
342         webkit-test-results.appspot.com loads the dashboard for Chromium by default
343         https://bugs.webkit.org/show_bug.cgi?id=114381
344
345         Reviewed by Benjamin Poulain.
346
347         Changed the defaults.
348
349         * TestResultServer/static-dashboards/builders.js:
350         * TestResultServer/static-dashboards/dashboard_base.js:
351         (currentBuilderGroupCategory):
352
353 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
354
355         Remove Chromium EWS bots from the queue status server
356         https://bugs.webkit.org/show_bug.cgi?id=113988
357
358         Reviewed by Benjamin Poulain.
359
360         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
361
362         * QueueStatusServer/app.yaml:
363         * QueueStatusServer/config/queues.py:
364         * QueueStatusServer/model/queues.py:
365         (Queue.short_name):
366         (Queue.display_name):
367         * QueueStatusServer/model/queues_unittest.py:
368         (QueueTest.test_short_name):
369         (QueueTest.test_display_name):
370         (QueueTest.test_name_with_underscores):
371         * QueueStatusServer/templates/activebots.html:
372
373 2013-04-10  Ojan Vafai  <ojan@chromium.org>
374
375         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
376         https://bugs.webkit.org/show_bug.cgi?id=114370
377
378         Reviewed by Ryosuke Niwa.
379
380         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
381         Unfortunately, there's no way to test this until this is committed and there is
382         a master restart.
383
384         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
385         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
390         * TestResultServer/generate_builders_json.py:
391         * TestResultServer/static-dashboards/dashboard_base.js:
392         * TestResultServer/static-dashboards/loader.js:
393
394 2013-04-10  Glenn Adams  <glenn@skynav.com>
395
396         [Qt] Fix regression to test-webkitpy.
397         https://bugs.webkit.org/show_bug.cgi?id=114368
398
399         Reviewed by Ryosuke Niwa.
400
401         * Scripts/webkitpy/layout_tests/port/factory.py:
402         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
403         (PortFactory.get): Remove obsolete chromium port related code.
404         * Scripts/webkitpy/layout_tests/port/mac.py:
405         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
406
407 2013-04-10  Anders Carlsson  <andersca@apple.com>
408
409         Remove unneeded headers from FrameLoader.h
410         https://bugs.webkit.org/show_bug.cgi?id=114223
411
412         Reviewed by Geoffrey Garen.
413
414         Add back headers implicitly included by other headers.
415
416         * WebKitTestRunner/WorkQueueManager.cpp:
417
418 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
419
420         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
421         https://bugs.webkit.org/show_bug.cgi?id=114365
422
423         Reviewed by Martin Robinson.
424
425         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
426         The patch addresses crashes in the tally_event_reply method. It is already committed into the
427         at-spi2-atk source tree and will be available with the next stable release, after which the
428         patch should be removed and the dependency version bumped.
429
430         * gtk/jhbuild.modules:
431         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
432
433 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
434
435         [WinCairo] Unreviewed build fix. Correct DropBox download link.
436
437         * Scripts/update-webkit-wincairo-libs: Revise download URL to
438         match change in DropBox server behavior.
439
440 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
441
442         Removed an annoying message from svn-create-patch
443         https://bugs.webkit.org/show_bug.cgi?id=114332
444
445         Reviewed by Alexey Proskuryakov.
446
447         I see this message basically every time I write a patch, so it must not
448         be true.
449
450         * Scripts/svn-create-patch:
451         (generateDiff):
452
453 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
454
455         [GTK] Add support for Page Visibility
456         https://bugs.webkit.org/show_bug.cgi?id=97324
457
458         Reviewed by Sam Weinig.
459
460         Implemented test runner API for page visibility layout tests.
461
462         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
463         (TestRunner::resetPageVisibility):
464         (TestRunner::setPageVisibility):
465         * Scripts/webkitperl/FeatureList.pm:
466
467 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
468
469         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
470         https://bugs.webkit.org/show_bug.cgi?id=114342
471
472         Reviewed by Gyuyoung Kim.
473
474         Commit 148033 only added an implementation for the Mac port, which made
475         other ports fail most tests since loading the injected bundle failed
476         with a missing symbol.
477
478         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
479         (WTR::AccessibilityUIElement::pathDescription):
480
481 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
482
483         [EFL] Add spell checking option to MiniBrowser
484         https://bugs.webkit.org/show_bug.cgi?id=114282
485
486         Reviewed by Ryosuke Niwa.
487
488         Spell checking is enabled by adding a flag (t/text-checking)
489         with launching MiniBrowser.
490
491         * MiniBrowser/efl/main.c:
492         (window_create):
493         (elm_main):
494
495 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
496
497         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
498         https://bugs.webkit.org/show_bug.cgi?id=113281
499
500         Reviewed by Darin Adler.
501
502         * Scripts/run-gtk-tests:
503         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
504
505 2013-04-09  Glenn Adams  <glenn@skynav.com>
506
507         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
508
509         Unreviewed.
510
511         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
512         (RunTest.test_build_check):
513
514 2013-04-09  Glenn Adams  <glenn@skynav.com>
515
516         [webkitpy] Remove chromium ports.
517         https://bugs.webkit.org/show_bug.cgi?id=114326
518
519         Reviewed by Dirk Pranke.
520
521         As a side effect, also:
522
523         - remove chromium builders from webkitpy.layout_tests.port.builders
524         - remove chromium builders from rebaseline
525         - rewrite chromium dependent tests in rebaseline_unittest
526         - remove chromium platform from garden-o-matic
527         - select apple platform as default platform in garden-o-matic
528         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
529
530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
531         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
532         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
533         (BaselineOptimizerTest.test_move_baselines):
534         (BaselineOptimizerTest.test_efl):
535         (BaselineOptimizerTest.test_no_add_mac_future):
536         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
537         (BaselineOptimizerTest.test_common_directory_includes_root):
538         (BaselineOptimizerTest.test_complex_shadowing):
539         (BaselineOptimizerTest.test_virtual_ports_filtered):
540         * Scripts/webkitpy/layout_tests/port/builders.py:
541         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
542         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
543         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
544         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
545         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
546         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
547         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
548         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
549         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
550         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
551         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
552         * Scripts/webkitpy/layout_tests/port/factory.py:
553         (platform_options):
554         (PortFactory):
555         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
556         (FactoryTest.test_qt):
557         (FactoryTest.test_get_from_builder_name):
558         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
559         (RunTest.test_build_check):
560         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
561         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
562         * Scripts/webkitpy/tool/commands/rebaseline.py:
563         (Rebaseline._builders_to_pull_from):
564         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
565         (_BaseTestCase):
566         (_BaseTestCase.setUp):
567         (TestRebaselineTest.setUp):
568         (TestRebaselineTest.test_baseline_directory):
569         (test_rebaseline_updates_expectations_file):
570         (test_rebaseline_does_not_include_overrides):
571         (test_rebaseline_test):
572         (test_rebaseline_test_and_print_scm_changes):
573         (test_rebaseline_and_copy_test):
574         (test_rebaseline_and_copy_test_no_existing_result):
575         (test_rebaseline_and_copy_test_with_lion_result):
576         (test_rebaseline_and_copy_no_overwrite_test):
577         (TestRebaselineExpectations.test_rebaseline_expectations):
578
579 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
580
581         newcommitbot (WKR) requires a subversion checkout
582         https://bugs.webkit.org/show_bug.cgi?id=114309
583
584         Reviewed by Benjamin Poulain.
585
586         Directly talk to the subversion server instead of relying on a local checkout.
587         This allows us to run WKR off of a git clone.
588
589         * Scripts/webkitpy/tool/commands/newcommitbot.py:
590         (NewCommitBot.next_work_item):
591         (NewCommitBot.process_work_item):
592
593 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
594
595         webkitbot refers to sheriffbot in help
596         https://bugs.webkit.org/show_bug.cgi?id=114307
597
598         Reviewed by Benjamin Poulain.
599
600         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
601
602         * Scripts/webkitpy/tool/bot/irc_command.py:
603         (Help):
604         (Help.execute):
605         (RollChromiumDEPS.execute):
606         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
607         (IRCBotTest.test_help):
608         * Scripts/webkitpy/tool/bot/sheriff.py:
609         (Sheriff.name):
610
611 2013-04-06  Roger Fong  <roger_fong@apple.com>
612
613         Kill old processes between runs on WinEWS bots.
614         Temporarily disable tests to let bots catch up again.
615
616         * EWSTools/start-queue-win.sh:
617         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
618         (WinEWS):
619
620 2013-04-09  Glenn Adams  <glenn@skynav.com>
621
622         [webkitpy] Remove chromium deprecated port support.
623         https://bugs.webkit.org/show_bug.cgi?id=114228
624
625         Reviewed by Ryosuke Niwa.
626
627         * Scripts/webkitpy/common/config/ports.py:
628         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
629         (ChromiumPort): Removed.
630         (ChromiumAndroidPort): Removed.
631         (ChromiumXVFBPort): Removed.
632         * Scripts/webkitpy/common/config/ports_unittest.py:
633         (DeprecatedPortTest.test_chromium_port): Removed.
634         (DeprecatedPortTest.test_chromium_android_port): Removed.
635         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
636         * Scripts/webkitpy/tool/steps/update_unittest.py:
637         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
638         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
639
640 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
641
642         AX: The bounding paths should be made available through accessibility
643         https://bugs.webkit.org/show_bug.cgi?id=113817
644
645         Reviewed by David Kilzer.
646
647         Add a pathDescription property for testing so that it's possible
648         to verify that a path is being returned correctly.
649
650         * DumpRenderTree/AccessibilityUIElement.cpp:
651         (getPathDescriptionCallback):
652         (AccessibilityUIElement::pathDescription):
653         (AccessibilityUIElement::getJSClass):
654         * DumpRenderTree/AccessibilityUIElement.h:
655         (AccessibilityUIElement):
656         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
657         (_CGPathEnumerationIteration):
658         (AccessibilityUIElement::pathDescription):
659         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
660         (AccessibilityUIElement::pathDescription):
661         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
662         (WTR::AccessibilityUIElement::pathDescription):
663         (WTR):
664         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
665         (AccessibilityUIElement):
666         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
667         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
668         (WTR::AccessibilityUIElement::pathDescription):
669         (WTR):
670
671 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
672
673         [EFL] Declare TEST_THEME_DIR in a single place.
674         https://bugs.webkit.org/show_bug.cgi?id=114285
675
676         Reviewed by Anders Carlsson.
677
678         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
679
680         * DumpRenderTree/efl/CMakeLists.txt:
681         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
682         (DumpRenderTreeChrome::createView):
683         (DumpRenderTreeChrome::createInspectorView):
684         (DumpRenderTreeChrome::initialize):
685         (DumpRenderTreeChrome::onDownloadRequest):
686         * EWebLauncher/CMakeLists.txt:
687         * EWebLauncher/main.c:
688         (findThemePath):
689         * EWebLauncher/url_bar.c:
690         (url_bar_add):
691         * MiniBrowser/efl/CMakeLists.txt:
692         * MiniBrowser/efl/main.c:
693         (window_create):
694         * TestWebKitAPI/PlatformEfl.cmake:
695         * TestWebKitAPI/efl/PlatformWebView.cpp:
696         (TestWebKitAPI::PlatformWebView::PlatformWebView):
697         * WebKitTestRunner/PlatformEfl.cmake:
698         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
699         (WTR::PlatformWebView::PlatformWebView):
700
701 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
702
703         [GTK][AC] upversion of clutter and its dependecy
704         https://bugs.webkit.org/show_bug.cgi?id=114016
705
706         Reviewed by Gustavo Noronha Silva.
707
708         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
709
710         * gtk/jhbuild-optional.modules:
711
712 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
713
714         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
715         https://bugs.webkit.org/show_bug.cgi?id=89875
716
717         Reviewed by Maciej Stachowiak.
718
719         Add unit tests to verify if the handling of the open, openat, creat syscall
720         is being done right. We check if the Read/Write/ReadAndWrite permissions
721         are respected, if the canonical path is being resolved and if
722         the permissions are falling back to the topmost parent directory with a
723         policy set when the directory being opened has no policy.
724
725         We also test if any attempt of blocking SIGSYS is silently ignored.
726         SIGSYS cannot be blocked because in it's handler is where we hook
727         syscalls to the broker process.
728
729         Also added libseccomp to EFL's jhbuild to make the life of developers
730         willing to help easier.
731
732         * Scripts/webkitperl/FeatureList.pm:
733         * TestWebKitAPI/PlatformEfl.cmake:
734         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
735         (TestWebKitAPI):
736         (SeccompEnvironment):
737         (TestWebKitAPI::SeccompEnvironment::SetUp):
738         (TestWebKitAPI::SeccompEnvironment::TearDown):
739         (TestWebKitAPI::dummyHandler):
740         (TestWebKitAPI::TEST):
741         (TestWebKitAPI::stressTest):
742         * efl/jhbuild.modules:
743         * qmake/mkspecs/features/features.pri:
744
745 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
746
747         REGRESSION: Autocorrection doesn't work in DumpRenderTree
748         https://bugs.webkit.org/show_bug.cgi?id=113846
749
750         Reviewed by Alexey Proskuryakov.
751
752         The problem was that we were replacing NSSpellCheck's dictionary with our own
753         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
754
755         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
756         and "would" respectively in DumpRenderTree.
757
758         * DumpRenderTree/mac/DumpRenderTree.mm:
759         (resetDefaultsToConsistentValues):
760
761 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
762
763         Remove the gyp files for Tools
764         https://bugs.webkit.org/show_bug.cgi?id=114248
765
766         Reviewed by Ryosuke Niwa.
767
768         * DumpRenderTree/DumpRenderTree.gyp: Removed.
769         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
770         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
771         * DumpRenderTree/DumpRenderTree.gypi: Removed.
772         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
773         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
774         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
775         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
776
777 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
778
779         WKR (new-commit-bot) is too slow
780         https://bugs.webkit.org/show_bug.cgi?id=110087
781
782         Reviewed by Geoffrey Garen.
783
784         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
785         Just run "svn log -r <revision>" instead to cut down the delay.
786
787         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
788
789         * Scripts/webkitpy/tool/commands/newcommitbot.py:
790         (NewCommitBot):
791         (NewCommitBot.next_work_item):
792         (NewCommitBot._is_empty_log):
793         (NewCommitBot._update_checkout):
794
795 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
796
797         Build fix. Can't remove appendCustomBuildFlags.
798
799         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
800         (appendCustomBuildFlags):
801
802 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
803
804         Remove Chromium builders from build.webkit.org
805         https://bugs.webkit.org/show_bug.cgi?id=113990
806
807         Reviewed by Benjamin Poulain.
808
809         Removed.
810
811         * BuildSlaveSupport/build.webkit.org-config/config.json:
812         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
813         (InstallGtkDependencies):
814         (RunUnitTests.start):
815         (RunWebKit2Tests.start):
816         (Factory.__init__):
817         (unitTestsSupported):
818         (TestFactory.__init__):
819         (BuildAndTestFactory.__init__):
820         (BuildAndPerfTestFactory.__init__):
821         (BuildAndPerfTestWebKit2Factory.__init__):
822         (DownloadAndPerfTestFactory.__init__):
823         (loadBuilderConfig):
824         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
825
826 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
827
828         Remove HTML Notification
829         https://bugs.webkit.org/show_bug.cgi?id=114231
830
831         Reviewed by Ryosuke Niwa.
832
833         * qmake/mkspecs/features/features.pri:
834
835 2013-04-08  Glenn Adams  <glenn@skynav.com>
836
837         Remove chromium EWS support, and fix broken test.
838         https://bugs.webkit.org/show_bug.cgi?id=114221
839
840         Reviewed by Ryosuke Niwa.
841
842         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
843         (AbstractChromiumEWS): Removed.
844         (ChromiumLinuxEWS): Removed.
845         (ChromiumLinuxDebugEWS): Removed.
846         (ChromiumWindowsEWS): Removed.
847         (ChromiumAndroidEWS): Removed.
848         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
849         (EarlyWarningSystemTest): Fix misspelled class name.
850         (test_ewses): Fix entry point name to ensure test is run.
851
852 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
853
854         [WIN] Remove WebKit2 source code
855         https://bugs.webkit.org/show_bug.cgi?id=114096
856
857         Reviewed by Anders Carlsson.
858
859         Remove the windows specific parts of the MiniBrowser.
860
861         * MiniBrowser/MiniBrowser.vcproj: Removed.
862         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
863         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
864         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
865         * MiniBrowser/win/BrowserView.cpp: Removed.
866         * MiniBrowser/win/BrowserView.h: Removed.
867         * MiniBrowser/win/BrowserWindow.cpp: Removed.
868         * MiniBrowser/win/BrowserWindow.h: Removed.
869         * MiniBrowser/win/MiniBrowser.cpp: Removed.
870         * MiniBrowser/win/MiniBrowser.h: Removed.
871         * MiniBrowser/win/MiniBrowser.rc: Removed.
872         * MiniBrowser/win/main.cpp: Removed.
873         * MiniBrowser/win/resource.h: Removed.
874         * MiniBrowser/win/stdafx.cpp: Removed.
875         * MiniBrowser/win/stdafx.h: Removed.
876
877 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
878
879         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
880
881         * Scripts/webkitpy/common/config/irc.py:
882
883 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
884
885         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
886         https://bugs.webkit.org/show_bug.cgi?id=113139
887
888         Reviewed by Anders Carlsson.
889
890         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
891         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
892         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
893         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
894         (ToStringAndValueOfObject):
895         (ToStringAndValueOfObject::ToStringAndValueOfObject):
896         (ScriptableObject):
897         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
898         (ToStringAndValueOfObject::ScriptableObject::invoke):
899         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
900         (ToStringAndValueOfObject::NPP_GetValue):
901         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
902         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
903         * GNUmakefile.am:
904
905 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
906
907         [GTK] Bump gnome-themes-standard to 3.6.0
908         https://bugs.webkit.org/show_bug.cgi?id=114155
909
910         Reviewed by Martin Robinson.
911
912         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
913         dependency of gnome-themes-standard accordingly.
914
915 2013-04-08  David Levin  <levin@chromium.org>
916
917         Remove my watchlist entries.
918         https://bugs.webkit.org/show_bug.cgi?id=114180
919
920         Reviewed by Adam Barth.
921
922         * Scripts/webkitpy/common/config/committers.py:
923         * Scripts/webkitpy/common/config/watchlist:
924
925 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
926
927         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
928         https://bugs.webkit.org/show_bug.cgi?id=114161
929
930         Reviewed by Gyuyoung Kim.
931
932         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
933         as it is crashing due to Bug 111074.
934
935         * TestWebKitAPI/PlatformEfl.cmake:
936
937 2013-04-07  David Kilzer  <ddkilzer@apple.com>
938
939         Remove the rest of SVG_DOM_OBJC_BINDINGS
940         <http://webkit.org/b/114112>
941
942         Reviewed by Geoffrey Garen.
943
944         * Scripts/webkitperl/FeatureList.pm:
945         - Remove --svg-dom-objc-bindings switch.
946         * qmake/mkspecs/features/features.pri:
947         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
948
949 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
950
951         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
952         https://bugs.webkit.org/show_bug.cgi?id=114089
953
954         Reviewed by Chris Fleizach.
955
956         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
957         * DumpRenderTree/AccessibilityController.cpp:
958         * DumpRenderTree/AccessibilityUIElement.cpp:
959         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
960         (DumpRenderTreeChrome::DumpRenderTreeChrome):
961         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
962         (DumpRenderTreeChrome):
963
964 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
965
966         Build fix after r147857, remove remaining USE(JSC) guards.
967
968         Unreviewed.
969
970         * DumpRenderTree/config.h:
971         * TestWebKitAPI/config.h:
972         * WebKitTestRunner/config.h:
973
974 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
975
976         Rename sheriffbot to webkitbot
977         https://bugs.webkit.org/show_bug.cgi?id=114109
978
979         Reviewed by Benjamin Poulain.
980
981         Renamed since sheriffbot will be used in Blink.
982
983         * Scripts/webkitpy/tool/commands/sheriffbot.py:
984         (SheriffBot):
985         (SheriffBot.begin_work_queue):
986
987 2013-04-06  Oliver Hunt  <oliver@apple.com>
988
989         Unify the many and varied stack trace mechanisms, and make the result sane.
990         https://bugs.webkit.org/show_bug.cgi?id=114072
991
992         Reviewed by Filip Pizlo.
993
994         The commandline jsc executable no longer requires arguments, so
995         I've made run-jsc work without them.
996
997         * Scripts/run-jsc:
998
999 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
1000
1001         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
1002         https://bugs.webkit.org/show_bug.cgi?id=114086
1003
1004         Reviewed by Tim Horton.
1005
1006         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
1007
1008 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
1009
1010         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
1011         https://bugs.webkit.org/show_bug.cgi?id=114083
1012
1013         Reviewed by Ryosuke Niwa.
1014
1015         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
1016         in TestWebKitAPI and WebKitTestRunner.
1017
1018         * TestWebKitAPI/config.h:
1019         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1020         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1021         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1022         (WTR::InjectedBundle::platformInitialize):
1023
1024 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
1025
1026         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
1027         https://bugs.webkit.org/show_bug.cgi?id=114094
1028
1029         Reviewed by Anders Carlsson.
1030
1031         * Scripts/run-jsc:
1032
1033 2013-04-05  Ojan Vafai  <ojan@chromium.org>
1034
1035         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
1036         https://bugs.webkit.org/show_bug.cgi?id=114080
1037
1038         Reviewed by Ryosuke Niwa.
1039
1040         This way, the WebKit and Blink dashboard code can change as appropriate without
1041         needing to consider the other project's needs. This still doesn't update the
1042         buildbots to upload to the new location, or the dashboard code to pull the
1043         results.json files from the new location, but it at least allows for changing the
1044         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
1045
1046         * TestResultServer/app.yaml:
1047
1048 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1049
1050         Re-enable testing on the commit queue
1051         https://bugs.webkit.org/show_bug.cgi?id=114078
1052
1053         Reviewed by Darin Adler.
1054
1055         Re-enabled the feature and the associated tests.
1056
1057         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1058         (CommitQueueTask.run):
1059         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1060         (CommitQueueTaskTest._run_through_task):
1061         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1062         (CommitQueueTest._mock_test_result):
1063
1064 2013-04-05  Oliver Hunt  <oliver@apple.com>
1065
1066         Unify the many and varied stack trace mechanisms, and make the result sane.
1067         https://bugs.webkit.org/show_bug.cgi?id=114072
1068
1069         Reviewed by Filip Pizlo.
1070
1071         The commandline jsc executable no longer requires arguments, so
1072         I've made run-jsc work without them.
1073
1074         * Scripts/run-jsc:
1075
1076 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1077
1078         AX: Make SVG Group containers accessible elements
1079         https://bugs.webkit.org/show_bug.cgi?id=113939
1080
1081         Reviewed by Simon Fraser.
1082
1083         Implement axController.elementAtPoint for iOS.
1084         Implement a correct version of clickPoint for iOS.
1085
1086         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1087         (AccessibilityController::elementAtPoint):
1088         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1089         (AccessibilityUIElement::clickPointX):
1090         (AccessibilityUIElement::clickPointY):
1091
1092 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1093
1094         Unreviewed, rolling out r147773 and r147774.
1095         http://trac.webkit.org/changeset/147773
1096         http://trac.webkit.org/changeset/147774
1097         https://bugs.webkit.org/show_bug.cgi?id=114056
1098
1099         Causing some exceptions on AppEngine I don't understand
1100         (Requested by rniwa on #webkit).
1101
1102         * QueueStatusServer/config/queues.py:
1103         * QueueStatusServer/model/queues.py:
1104         (Queue.short_name):
1105         (Queue.display_name):
1106         * QueueStatusServer/model/queues_unittest.py:
1107         (QueueTest.test_short_name):
1108         (QueueTest.test_display_name):
1109         (QueueTest.test_name_with_underscores):
1110
1111 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
1112
1113         Fixed run-bindings-tests by removing V8
1114         https://bugs.webkit.org/show_bug.cgi?id=114053
1115
1116         Reviewed by Benjamin Poulain.
1117
1118         * Scripts/run-bindings-tests:
1119         (main):
1120
1121 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1122
1123         Build fix.
1124
1125         * QueueStatusServer/model/queues.py:
1126         (Queue.short_name):
1127         (Queue.display_name):
1128
1129 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1130
1131         Remove Chromium EWS bots from the queue status server
1132         https://bugs.webkit.org/show_bug.cgi?id=113988
1133
1134         Reviewed by Benjamin Poulain.
1135
1136         Removed Chromium EWS bots.
1137
1138         * QueueStatusServer/config/queues.py:
1139         * QueueStatusServer/model/queues.py:
1140         (Queue.short_name):
1141         (Queue.display_name):
1142         * QueueStatusServer/model/queues_unittest.py:
1143         (QueueTest.test_short_name):
1144         (QueueTest.test_display_name):
1145         (QueueTest.test_name_with_underscores):
1146
1147 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1148
1149         [EFL] Enable indexed database
1150         https://bugs.webkit.org/show_bug.cgi?id=107248
1151
1152         Reviewed by Alexis Menard.
1153
1154         * Scripts/webkitperl/FeatureList.pm:
1155
1156 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
1157
1158         Remove vestiges of Chromium bits from watchlists.
1159         https://bugs.webkit.org/show_bug.cgi?id=114047
1160
1161         Reviewed by Ryosuke Niwa.
1162
1163         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
1164
1165 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1166
1167         Add James Craig to the contributors list.
1168
1169         * Scripts/webkitpy/common/config/committers.py:
1170
1171 2013-04-04  Kent Tamura  <tkent@chromium.org>
1172
1173         Remove ChromiumPublicApi pattern, and cc/message rules for it.
1174
1175         * Scripts/webkitpy/common/config/watchlist:
1176
1177 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1178
1179         Temporarily disable the Python unittests broken by the commit queue not running layout tests
1180         https://bugs.webkit.org/show_bug.cgi?id=113997
1181
1182         Reviewed by Ryosuke Niwa.
1183
1184         Disable the tests until Ryosuke gets the time and hardware to have
1185         a testing commit-queue.
1186
1187         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1188         (CommitQueueTaskTest):
1189         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1190         (CommitQueueTest):
1191
1192 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1193
1194         Remove Chromium builders from build.webkit.org
1195         https://bugs.webkit.org/show_bug.cgi?id=113990
1196
1197         Reviewed by Benjamin Poulain.
1198
1199         Land the part to disable triggering of Chromium builders first so that we may start
1200         deleting more Chromium code that breaks the update step.
1201
1202         * BuildSlaveSupport/build.webkit.org-config/config.json:
1203
1204 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1205
1206         Remove Chromium's DumpRenderTree
1207         https://bugs.webkit.org/show_bug.cgi?id=113989
1208
1209         Reviewed by Kent Tamura.
1210
1211         On second thought, let's not go to Camelot. It is a silly place.
1212
1213         * DumpRenderTree/mac/DumpRenderTree.mm:
1214         (resetDefaultsToConsistentValues):
1215
1216 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1217
1218         Nixed the defunct chromium folder from DumpRenderTree
1219         https://bugs.webkit.org/show_bug.cgi?id=113993
1220
1221         Reviewed by Ryosuke Niwa.
1222
1223         * DumpRenderTree/chromium: Removed.
1224         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1225         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1226         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1227         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1228         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1229         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1230         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1231         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1232         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1233         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1234         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1235         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1236         * DumpRenderTree/chromium/Task.cpp: Removed.
1237         * DumpRenderTree/chromium/Task.h: Removed.
1238         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1239         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1240         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1241         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1242         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1243         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1244         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1245         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1246         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1247         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1248         * DumpRenderTree/chromium/TestRunner: Removed.
1249         * DumpRenderTree/chromium/TestRunner/public: Removed.
1250         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1251         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1252         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1253         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1254         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1255         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1256         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1257         * DumpRenderTree/chromium/TestRunner/src: Removed.
1258         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1259         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1260         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1261         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1262         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1263         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1264         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1265         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1266         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1267         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1268         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1269         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1270         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1271         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1272         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1273         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1274         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1275         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
1276         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
1277         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
1278         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
1279         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
1280         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
1281         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1282         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1283         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1284         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1285         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1286         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1287         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1288         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1289         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1290         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1291         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1292         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1293         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1294         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1295         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1296         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1297         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1298         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1299         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1300         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1301         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1302         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1303         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1304         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1305         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1306         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1307         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1308         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1309         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1310         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1311         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1312         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1313         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1314         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1315         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1316         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1317         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1318         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1319         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1320         * DumpRenderTree/chromium/TestShell.h: Removed.
1321         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1322         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1323         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1324         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1325         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1326         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1327         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1328         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1329         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1330         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1331         * DumpRenderTree/chromium/config.h: Removed.
1332         * DumpRenderTree/chromium/fonts.conf: Removed.
1333
1334 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1335
1336         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1337
1338         Rubber stamped by Benjamin Poulain.
1339
1340         * RebaselineQueueServer: Removed.
1341         * RebaselineQueueServer/app.yaml: Removed.
1342         * RebaselineQueueServer/handlers: Removed.
1343         * RebaselineQueueServer/handlers/__init__.py: Removed.
1344         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1345         * RebaselineQueueServer/handlers/pages.py: Removed.
1346         * RebaselineQueueServer/index.yaml: Removed.
1347         * RebaselineQueueServer/main.py: Removed.
1348         * RebaselineQueueServer/model: Removed.
1349         * RebaselineQueueServer/model/__init__.py: Removed.
1350         * RebaselineQueueServer/model/queueentry.py: Removed.
1351         * RebaselineQueueServer/static: Removed.
1352         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1353         * RebaselineQueueServer/static/styles.css: Removed.
1354         * RebaselineQueueServer/templates: Removed.
1355         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1356         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1357         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1358         * RebaselineQueueServer/templates/home.html: Removed.
1359
1360 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1361
1362         Fix setup-commit-queue and temporarily disable testing on commit-queue
1363         https://bugs.webkit.org/show_bug.cgi?id=113979
1364
1365         Reviewed by Benjamin Poulain.
1366
1367         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1368         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1369
1370         * EWSTools/setup-commit-queue.sh:
1371         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1372         (CommitQueueTask.run):
1373
1374 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1375
1376         temporarily make flakiness dashboard work again webkit.org bots
1377         https://bugs.webkit.org/show_bug.cgi?id=113972
1378
1379         Reviewed by Ojan Vafai.
1380
1381         This patch disables the chromium.org layout test bots TestExpectations
1382         parsing temporarily until we can work out the right way to split into
1383         two instances for webkit.org and chromium.org and figure out which
1384         code to delete where :).
1385
1386         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1387
1388 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1389
1390         Fix webkitpy tests after r147678.
1391
1392         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1393         (CommitQueueTest.test_commit_queue):
1394         (test_manual_reject_during_processing):
1395
1396 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1397
1398         The commit queue should use Mac MountainLion port
1399         https://bugs.webkit.org/show_bug.cgi?id=113971
1400
1401         Reviewed by Lucas Forschler.
1402
1403         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1404         * Scripts/webkitpy/tool/commands/queues.py:
1405         (CommitQueue):
1406
1407 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1408
1409         turn off running tests on chromium linux EWS bots
1410         https://bugs.webkit.org/show_bug.cgi?id=113959
1411
1412         Reviewed by Geoffrey Garen.
1413
1414         Now that the Chromium port is no longer being maintained
1415         there's little point in running the tests. Soon we should
1416         just shut this bot off altogether.
1417
1418         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1419         (ChromiumLinuxEWS):
1420
1421 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1422
1423         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1424
1425         * Scripts/webkitpy/common/config/watchlist:
1426
1427 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1428
1429         Indentation fix to get webkit-patch working again after r147625
1430
1431         Unreviewed.
1432
1433         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1434         (MacEWS):
1435         (MacWK2EWS):
1436
1437 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1438
1439         Turn tests back on for Mac WK1/WK2 EWS.
1440         
1441         Unreviewed.
1442         
1443         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1444         (MacEWS):
1445         (MacWK2EWS):
1446
1447 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1448
1449         [GTK][WK2] MiniBrowser custom URI scheme support
1450         https://bugs.webkit.org/show_bug.cgi?id=112419
1451
1452         Reviewed by Carlos Garcia Campos.
1453
1454         Add support for about URIs in MiniBrowser. An example about page is show
1455         with URI "about:minibrowser", the rest of the cases it will show a
1456         proper message explaining that the about page didn't exist.
1457
1458         Internally it uses "minibrowser-about" prefix instead of "about", but
1459         from the user point of view it works with "about" prefix.
1460
1461         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1462         (getInternalURI): Method to convert URIs from "about" prefix to
1463         "minibrowser-about".
1464         (getExternalURI): Opposite method.
1465         (webViewURIChanged): Use "about" prefix to show the URI to users.
1466         (webViewEnterFullScreen): Ditto.
1467         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1468         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1469         (aboutURISchemeRequestCallback): Callback to manage about calls.
1470         (main): Register the URI scheme to manage about URIs.
1471
1472 2013-04-03  Roger Fong  <roger_fong@apple.com>
1473
1474         Re-enable WinEWS tests.
1475
1476         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1477         (WinEWS):
1478
1479 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1480
1481         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1482         https://bugs.webkit.org/show_bug.cgi?id=113883
1483
1484         Reviewed by Martin Robinson.
1485
1486         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1487         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1488         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1489
1490 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1491
1492         [GTK] Include Pango in jhbuild-optional.modules
1493         https://bugs.webkit.org/show_bug.cgi?id=113878
1494
1495         Reviewed by Martin Robinson.
1496
1497         Since r147547 Pango 1.32.0 is required. Including the module in the
1498         JHBuild optional moduleset.
1499
1500         * gtk/jhbuild-optional.modules: Add Pango module.
1501
1502 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1503
1504         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1505         https://bugs.webkit.org/show_bug.cgi?id=113864
1506
1507         Moving setDefersLoading from TestRunnerQt to TestRunner
1508         requires access to the non-Qt TestRunner.
1509         As long as we instantiate both TestRunner and TestRunnerQt,
1510         we need a separate getter for the non-Qt TestRunner instance.
1511
1512         Reviewed by Simon Hausmann.
1513
1514         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1515         (WebPage::resetSettings):
1516         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1517         (DumpRenderTree::jscTestRunner):
1518         * DumpRenderTree/qt/TestRunnerQt.cpp:
1519         (TestRunner::setDefersLoading):
1520             Moving setDefersLoading from TestRunnerQt
1521             to TestRunner.
1522         * DumpRenderTree/qt/TestRunnerQt.h:
1523         (TestRunnerQt):
1524
1525 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1526
1527         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1528         https://bugs.webkit.org/show_bug.cgi?id=104779
1529
1530         Reviewed by Carlos Garcia Campos.
1531
1532         * Scripts/run-gtk-tests:
1533         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1534         passing in current trunk.
1535
1536 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1537
1538         Fix HAVE(QTTESTSUPPORT) logic
1539
1540         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1541         resulting in HAVE(QTTESTSUPPORT) never being true.
1542         Move that logic down in sanitizeFeatures.
1543
1544         Rubber-stamped by Tor Arne Vestbø.
1545
1546         * qmake/mkspecs/features/features.prf:
1547
1548 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1549
1550         [GTK] Bump required versions of some dependencies
1551         https://bugs.webkit.org/show_bug.cgi?id=113282
1552
1553         Reviewed by Martin Robinson.
1554
1555         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1556
1557 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1558
1559         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1560         https://bugs.webkit.org/show_bug.cgi?id=113809
1561
1562         Reviewed by Philippe Normand.
1563
1564         Newer Linux kernels have removed some deprecated macros from v4l2
1565         headers, causing gst-plugins-good's build to break. We don't need it
1566         right now, so just disable it.
1567
1568         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1569
1570 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1571
1572         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1573         https://bugs.webkit.org/show_bug.cgi?id=113535
1574
1575         Reviewed by Simon Hausmann.
1576
1577         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1578
1579         * qmake/mkspecs/features/features.prf:
1580
1581 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1582
1583         [Qt] Move logic of simple forwarding functions to TestRunner.
1584         https://bugs.webkit.org/show_bug.cgi?id=113863
1585
1586         Reviewed by Simon Hausmann.
1587
1588         * DumpRenderTree/qt/TestRunnerQt.cpp:
1589         (TestRunner::setTextDirection):
1590         (TestRunner::goBack):
1591         (TestRunner::evaluateScriptInIsolatedWorld):
1592         (TestRunner::addUserStyleSheet):
1593         * DumpRenderTree/qt/TestRunnerQt.h:
1594         (TestRunnerQt):
1595
1596 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1597
1598         [Qt] Disable media support using QuickTime if deployment target != SDK
1599
1600         We link to a single libWebKitSystemInterface static lib, so unless the
1601         deployment target matches the SDK let's not pretend like we'll be able
1602         to run on anything lower than the SDK version.
1603
1604         Reviewed by Simon Hausmann.
1605
1606         * qmake/mkspecs/features/features.prf:
1607
1608 2013-04-02  James Craig  <james@cookiecrook.com>
1609
1610         AXRoleDescripton for DL is "list"; should be "description list"
1611         https://bugs.webkit.org/show_bug.cgi?id=111665
1612
1613         Reviewed by Chris Fleizach.
1614
1615         Defining the role and description strings.
1616
1617         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1618
1619 2013-04-02  Roger Fong  <roger_fong@apple.com>
1620
1621         Unreviewed. Disable running tests on Win EWS queue.
1622
1623         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1624         (WinEWS):
1625
1626 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1627
1628         Disable running tests on the MAC WK2 EWS queue.
1629         
1630         Unreviewed.
1631         
1632         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1633         (MacWK2EWS):
1634
1635 2013-04-02  Julie Parent  <jparent@chromium.org>
1636
1637         Dashboard refactor: Move dashboard specific history related features to History.
1638         https://bugs.webkit.org/show_bug.cgi?id=113717
1639
1640         Reviewed by Ojan Vafai.
1641         
1642         Each dashboard now creates its own History object, with a custom
1643         configuration. This changes from just overriding global functions
1644         to passing in callbacks for generatePage, handleValidHashParameter,
1645         and handleQueryParameterChange. Same with passing in defaultStateValues
1646         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1647         variables.
1648         
1649         All functions related to these features are now (mostly) private
1650         function on History. 
1651         
1652         Loader no longer needs a loadingComplete callback, since it can just
1653         initialize the history object itself.
1654
1655         * TestResultServer/static-dashboards/aggregate_results.js:
1656         (handleValidHashParameter):
1657         * TestResultServer/static-dashboards/dashboard_base.js:
1658         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1659         (generatePage):
1660         (.switch.return):
1661         (handleQueryParameterChange):
1662         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1663         (resetGlobals):
1664         * TestResultServer/static-dashboards/history.js:
1665         (.):
1666         * TestResultServer/static-dashboards/loader.js:
1667         (.):
1668         * TestResultServer/static-dashboards/loader_unittests.js:
1669         * TestResultServer/static-dashboards/timeline_explorer.js:
1670         (generatePage):
1671         (initCurrentBuilderTestResults):
1672         * TestResultServer/static-dashboards/treemap.js:
1673         (generatePage):
1674         (.switch.return):
1675         (handleQueryParameterChange):
1676
1677 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1678
1679         Unreviewed, rolling out r147401.
1680         http://trac.webkit.org/changeset/147401
1681         https://bugs.webkit.org/show_bug.cgi?id=113767
1682
1683         The patch makes it extremely hard to set up the dependencies
1684         properly on the GTK builders (Requested by zdobersek on
1685         #webkit).
1686
1687         * gtk/jhbuild.modules:
1688
1689 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1690
1691         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1692         https://bugs.webkit.org/show_bug.cgi?id=113382
1693
1694         Reviewed by Gyuyoung Kim.
1695
1696         Do not show the empty tooltip box if the text is null.
1697
1698         * MiniBrowser/efl/main.c:
1699         (popup_menu_populate):
1700
1701 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1702
1703         [GTK] Bump required versions of some dependencies
1704         https://bugs.webkit.org/show_bug.cgi?id=113282
1705
1706         Reviewed by Martin Robinson.
1707
1708         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1709
1710 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1711
1712         Unreviewed, rolling out r147319.
1713         http://trac.webkit.org/changeset/147319
1714         https://bugs.webkit.org/show_bug.cgi?id=113707
1715
1716         The unit test is still failing on the buildbot (Requested by
1717         zdobersek on #webkit).
1718
1719         * Scripts/run-gtk-tests:
1720         (TestRunner):
1721
1722 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1723
1724         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1725         https://bugs.webkit.org/show_bug.cgi?id=104779
1726
1727         Reviewed by Carlos Garcia Campos.
1728
1729         * Scripts/run-gtk-tests:
1730         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1731         passing in current trunk.
1732
1733 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1734
1735         Unreviewed, rolling out r147289.
1736         http://trac.webkit.org/changeset/147289
1737         https://bugs.webkit.org/show_bug.cgi?id=113678
1738
1739         broke Win7 (dbg) build (Requested by shinyak|gardener on
1740         #webkit).
1741
1742         * DumpRenderTree/DumpRenderTree.gypi:
1743         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1744         (WebTestRunner):
1745         (WebUserMediaClientMock):
1746         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1747         (WebTestRunner::WebUserMediaClientMock::taskList):
1748         * Scripts/webkitpy/style/checkers/cpp.py:
1749         (check_function_definition):
1750
1751 2013-03-31  Adam Barth  <abarth@webkit.org>
1752
1753         configure-svn-config.sh fails
1754         https://codereview.chromium.org/13392007/
1755
1756         Reviewed by Eric Seidel.
1757
1758         This script was trying to use "svn checkout" to dowload a file from
1759         svn.webkit.org, but "svn checkout" only works with directories.
1760         Instead, we should use "svn export".
1761
1762         * EWSTools/configure-svn-config.sh:
1763
1764 2013-03-31  Wei Jia  <wjia@chromium.org>
1765
1766         Allow WebUserMediaClientMock to be used by client
1767         https://bugs.webkit.org/show_bug.cgi?id=113633
1768
1769         Reviewed by Adam Barth.
1770
1771         Export WebUserMediaClientMock.
1772         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1773
1774         * DumpRenderTree/DumpRenderTree.gypi:
1775         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1776         (WebUserMediaClientMock):
1777         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1778         * Scripts/webkitpy/style/checkers/cpp.py:
1779         (check_function_definition):
1780
1781 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1782
1783         Expose FeatureObserver data to WebKit clients
1784         https://bugs.webkit.org/show_bug.cgi?id=113613
1785
1786         Reviewed by Sam Weinig.
1787
1788         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1789         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1790
1791 2013-03-29  Greg Hughes  <ghughes@apple.com>
1792
1793         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1794         https://bugs.webkit.org/show_bug.cgi?id=112276
1795
1796         Reviewed by Chris Fleizach.
1797
1798         Added support to test accessibility search predicates with multiple keys.  
1799
1800         * DumpRenderTree/AccessibilityUIElement.cpp:
1801         (uiElementForSearchPredicateCallback):
1802         * DumpRenderTree/AccessibilityUIElement.h:
1803         (AccessibilityUIElement):
1804         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1805         (AccessibilityUIElement::uiElementForSearchPredicate):
1806         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1807         (AccessibilityUIElement::uiElementForSearchPredicate):
1808         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1809         (AccessibilityUIElement::uiElementForSearchPredicate):
1810         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1811         (AccessibilityUIElement::uiElementForSearchPredicate):
1812         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1813         (AccessibilityUIElement::uiElementForSearchPredicate):
1814         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1815         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1816         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1817         (AccessibilityUIElement):
1818         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1819         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1820         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1821         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1822         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1823
1824 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1825
1826         Fix a typo in r147147 to fix Mac EWS.
1827
1828         * Scripts/webkitpy/tool/commands/queues.py:
1829         (PatchProcessingQueue._new_port_name_from_old):
1830
1831 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1832
1833         [EFL] Build break with latest EFL libraries after r146265
1834         https://bugs.webkit.org/show_bug.cgi?id=113558
1835
1836         Unreviewed build fix.
1837
1838         * TestWebKitAPI/PlatformWebView.h:
1839         * WebKitTestRunner/PlatformWebView.h:
1840
1841 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1842
1843         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1844
1845         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1846         in libgcrypt build.
1847
1848 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1849
1850         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1851
1852         Unreviewed.
1853
1854         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1855         (MacEWS):
1856
1857 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1858
1859         Use the right OS name on Mac EWS instead of mac-future.
1860
1861         Rubber-stamped by Dirk Pranke.
1862
1863         * Scripts/webkitpy/tool/commands/queues.py:
1864         (PatchProcessingQueue._new_port_name_from_old):
1865         (PatchProcessingQueue.begin_work_queue):
1866         (PatchProcessingQueue._upload_results_archive_for_patch):
1867
1868 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1869
1870         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1871         https://bugs.webkit.org/show_bug.cgi?id=112546
1872
1873         Reviewed by Martin Robinson.
1874
1875         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1876         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1877
1878 2013-03-28  Ming Xie  <mxie@blackberry.com>
1879
1880         [BlackBerry] Committer Email Updates
1881         https://bugs.webkit.org/show_bug.cgi?id=113435
1882
1883         Reviewed by Rob Buis.
1884
1885         Add the @blackberry.com email address for all our BlackBerry
1886         WebKit committers. This is the first step for our email address
1887         migration.
1888
1889         * Scripts/webkitpy/common/config/committers.py:
1890
1891 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1892
1893         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1894         https://bugs.webkit.org/show_bug.cgi?id=113508
1895
1896         Reviewed by Martin Robinson.
1897
1898         Prevent the GStreamer plugin scanner to load system-wide
1899         plugins. Only the ones built in JHBuild should be loaded and used
1900         at runtime.
1901
1902         * efl/jhbuildrc:
1903         * gtk/jhbuildrc:
1904
1905 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1906
1907         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1908         https://bugs.webkit.org/show_bug.cgi?id=113386
1909
1910         Reviewed by Carlos Garcia Campos.
1911
1912         * Scripts/webkitdirs.pm:
1913         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1914         version to 3.0. Reflect this change so the builtDylibPathForName
1915         function doesn't fail to report the library as found.
1916
1917 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1918
1919         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1920         https://bugs.webkit.org/show_bug.cgi?id=113484
1921
1922         Unreviewed build fix.
1923
1924         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1925
1926         * TestWebKitAPI/CMakeLists.txt:
1927         * WebKitTestRunner/CMakeLists.txt:
1928
1929 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1930
1931         Revision for the internal jhbuild is too old
1932         https://bugs.webkit.org/show_bug.cgi?id=113324
1933
1934         Reviewed by Martin Robinson.
1935
1936         Update the minimum required version to a point where jhbuild won't
1937         fail installing packages when trying to remove a symlink to a directory.
1938
1939         * jhbuild/jhbuild-wrapper: Updated revision.
1940
1941 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1942
1943         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1944         https://bugs.webkit.org/show_bug.cgi?id=113203
1945
1946         Reviewed by Philippe Normand.
1947
1948         We build our libsoup without GNOME support. gst-plugins-good does separate
1949         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1950         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1951         build failures as the headers of those diverge. We do not use souphttpsrc, so
1952         disable it when building gst-plugins-good.
1953
1954         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1955
1956 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1957
1958         Build fix after r146852. Please another reference to the Lion leaks builder.
1959
1960         * BuildSlaveSupport/build.webkit.org-config/config.json:
1961
1962 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1963
1964         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1965         https://bugs.webkit.org/show_bug.cgi?id=113421
1966
1967         Reviewed by Dirk Pranke.
1968
1969         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1970         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1971         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1972         in the GTK-specific TestExpectations files.
1973
1974         To avoid this only enable the warnings only when not using WKTR.
1975
1976         * Scripts/webkitpy/layout_tests/port/gtk.py:
1977         (GtkPort.warn_if_bug_missing_in_test_expectations):
1978
1979 2013-03-27  Antti Koivisto  <antti@apple.com>
1980
1981         Fix Zalan's email.
1982
1983         * Scripts/webkitpy/common/config/committers.py:
1984
1985 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1986
1987         master.cfg cleanup
1988         https://bugs.webkit.org/show_bug.cgi?id=113195
1989
1990         Reviewed by Ryosuke Niwa.
1991
1992         * BuildSlaveSupport/build.webkit.org-config/config.json:
1993         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1994
1995 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1996
1997         master.cfg fine-tuning for Qt Mountain Lion Release bot
1998         https://bugs.webkit.org/show_bug.cgi?id=113191
1999
2000         Reviewed by Ryosuke Niwa.
2001
2002         * BuildSlaveSupport/build.webkit.org-config/config.json:
2003           - Rename the slave due to its location change.
2004           - Update the platform of the slave.
2005         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2006         (RunQtAPITests): Enable running WK2 API tests on Qt.
2007         (RunQtAPITests.start):
2008         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
2009         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
2010
2011 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2012
2013         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
2014         https://bugs.webkit.org/show_bug.cgi?id=113403
2015
2016         Reviewed by Kenneth Rohde Christiansen.
2017
2018         As of Evas 1.7.5, when Wayland is detected on the system, support for
2019         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
2020         The code, however, seems to depend on a few other flags which must be
2021         explicitly enabled.
2022
2023         If those additional GL-related options are passed, we end up
2024         having issues on the WebKit side, so disable Wayland support for
2025         now.
2026
2027         * efl/jhbuild.modules:
2028
2029 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2030
2031         Unreviewed, rolling out r146864.
2032         http://trac.webkit.org/changeset/146864
2033         https://bugs.webkit.org/show_bug.cgi?id=113391
2034
2035         causes crashes on Wk2 EFL release bot (Requested by drott on
2036         #webkit).
2037
2038         * Scripts/webkitperl/FeatureList.pm:
2039
2040 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2041
2042         [jhbuild] Correctly specify an alternate number of make jobs.
2043         https://bugs.webkit.org/show_bug.cgi?id=113396
2044
2045         Reviewed by Philippe Normand.
2046
2047         So far, we were using the `MAKEFLAGS' environment variable to pass the
2048         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
2049         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
2050
2051         We now behave more closely to the rest of the WebKit tools by first
2052         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
2053         not set, just letting jhbuild itself figure out how many jobs to use.
2054
2055         * efl/jhbuildrc:
2056         * gtk/jhbuildrc:
2057
2058 2013-03-27  Zeno Albisser  <zeno@webkit.org>
2059
2060         [Qt] Remove Qt specific WorkQueueItem definitions.
2061         https://bugs.webkit.org/show_bug.cgi?id=112891
2062
2063         This patch is preparation work for removing
2064         WorkQueue related code from TestRunnerQt and
2065         replacing it with generic TestRunner code.
2066
2067         Reviewed by Benjamin Poulain.
2068
2069         * DumpRenderTree/qt/TestRunnerQt.cpp:
2070         (TestRunnerQt::queueBackNavigation):
2071         (TestRunnerQt::queueForwardNavigation):
2072         (TestRunnerQt::queueLoadHTMLString):
2073         (TestRunnerQt::queueReload):
2074         (TestRunnerQt::queueLoadingScript):
2075         (TestRunnerQt::queueNonLoadingScript):
2076         (TestRunner::queueLoad):
2077         * DumpRenderTree/qt/TestRunnerQt.h:
2078         (TestRunnerQt):
2079         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2080         (LoadItem::invoke):
2081         (LoadHTMLStringItem::invoke):
2082         (LoadAlternateHTMLStringItem::invoke):
2083         (ReloadItem::invoke):
2084         (ScriptItem::invoke):
2085         (BackForwardItem::invoke):
2086         * DumpRenderTree/qt/WorkQueueItemQt.h:
2087         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2088         (LoadAlternateHTMLStringItem):
2089
2090 2013-03-26  Julie Parent  <jparent@chromium.org>
2091
2092         Flakiness dashboard: simplify logic around which tests to show.
2093         https://bugs.webkit.org/show_bug.cgi?id=113250
2094
2095         Reviewed by Ojan Vafai.
2096         
2097         The different filters for showing results are only used for layout
2098         tests, otherwise, we show everything.
2099         
2100         Change the defaults to false (what layout tests used), and only
2101         look at the values when viewing layout tests.
2102
2103         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2104         (htmlForTestsWithExpectationsButNoFailures):
2105         (shouldHideTest):
2106
2107 2013-03-26  Isaac Levy  <ilevy@google.com>
2108
2109         Update bots on test-results.appspot
2110         https://bugs.webkit.org/show_bug.cgi?id=113333
2111
2112         Reviewed by Ojan Vafai.
2113
2114         * TestResultServer/static-dashboards/builders.jsonp:
2115
2116 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2117
2118         Unreviewed GTK gardening.
2119
2120         * Scripts/run-gtk-tests:
2121         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
2122
2123 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2124
2125         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
2126         https://bugs.webkit.org/show_bug.cgi?id=113287
2127
2128         Reviewed by Jocelyn Turcotte.
2129
2130         * Scripts/run-qtwebkit-tests:
2131         (Options.__init__):
2132
2133 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2134
2135         [EFL] Enable IndexedDB by default
2136         https://bugs.webkit.org/show_bug.cgi?id=107248
2137
2138         Reviewed by Laszlo Gombos.
2139
2140         * Scripts/webkitperl/FeatureList.pm:
2141         Enable IndexedDB by default on EFL.
2142
2143 2013-03-26  Alan Cutter  <alancutter@chromium.org>
2144
2145         Sheriffbot should explain rollout failures in a human readable form.
2146         https://bugs.webkit.org/show_bug.cgi?id=107092
2147
2148         Reviewed by Ryosuke Niwa.
2149
2150         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
2151
2152         * Scripts/webkitpy/tool/bot/irc_command.py:
2153         (Rollout._check_diff_failure):
2154         (Rollout.execute):
2155         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2156         (IRCCommandTest.test_rollout):
2157
2158 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2159
2160         Unreviewed GTK gardening.
2161
2162         * Scripts/run-gtk-tests:
2163         (TestRunner): Skipping a failing unit test after r146518.
2164
2165 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2166
2167         Remove Lion leaks builder
2168         https://bugs.webkit.org/show_bug.cgi?id=113252
2169
2170         Reviewed by Andreas Kling.
2171
2172         Removed.
2173
2174         * BuildSlaveSupport/build.webkit.org-config/config.json:
2175
2176 2013-03-25  Kent Tamura  <tkent@chromium.org>
2177
2178         Rename ENABLE_INPUT_TYPE_DATETIME
2179         https://bugs.webkit.org/show_bug.cgi?id=113254
2180
2181         Reviewed by Kentaro Hara.
2182
2183         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
2184         Actually I'd like to remove the code, but we shouldn't remove it yet
2185         because we shipped products with it on some platforms.
2186
2187         * Scripts/webkitperl/FeatureList.pm:
2188         * qmake/mkspecs/features/features.pri:
2189
2190 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2191
2192         Remove one more line that was intended to be removed in r146657.
2193
2194         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2195         (summarize_results):
2196
2197 2013-03-25  Roger Fong  <roger_fong@apple.com>
2198
2199         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2200         Re-enable WinEWS tests.
2201
2202         * Scripts/webkitpy/common/config/ports.py:
2203         (WinPort.run_bindings_tests_command):
2204         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2205         (WinEWS):
2206
2207 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2208
2209         Unreviewed, rolling out r146793.
2210         http://trac.webkit.org/changeset/146793
2211         https://bugs.webkit.org/show_bug.cgi?id=113248
2212
2213         Fix did not work (Requested by rfong on #webkit).
2214
2215         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2216         (WinEWS):
2217
2218 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2219
2220         REGRESSION(r146657): Test failures reported incorrectly
2221         https://bugs.webkit.org/show_bug.cgi?id=113223
2222
2223         Reviewed by Dirk Pranke.
2224
2225         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2226
2227         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2228         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2229
2230         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2231         (Manager.run):
2232
2233         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2234         (RunDetails.__init__):
2235         (summarize_results): Remove the line I intended to remove in r146657.
2236
2237         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2238         (logging_run): Return details instead of the exit code.
2239         (run_and_capture): Ditto.
2240
2241         (RunTest.test_full_results_html):
2242         (RunTest.test_hung_thread):
2243         (RunTest.test_no_tests_found):
2244         (RunTest.test_no_tests_found_2):
2245         (RunTest.test_repeat_each_iterations_num_tests):
2246         (RunTest.test_run_singly_actually_runs_tests):
2247         (RunTest.test_test_list):
2248         (RunTest.test_missing_and_unexpected_results):
2249         (RunTest.test_pixel_test_directories):
2250         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2251         (RunTest.test_crash_with_stderr):
2252         (RunTest.test_no_image_failure_with_image_diff):
2253         (RunTest.test_crash_log):
2254         (RunTest.test_exit_after_n_failures_upload):
2255         (RunTest.test_results_directory_absolute):
2256         (RunTest.test_results_directory_relative):
2257         (RunTest.test_retrying_and_flaky_tests):
2258         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2259         (RunTest.test_retrying_uses_retries_directory):
2260         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2261         (RunTest.test_output_diffs):
2262         (EndToEndTest.test_reftest_with_two_notrefs):
2263         (RebaselineTest.test_reset_results):
2264         (RebaselineTest.test_missing_results):
2265         (RebaselineTest.test_new_baseline):
2266
2267         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2268         (BuildBotPrinter.print_results):
2269         (BuildBotPrinter.print_unexpected_results):
2270         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2271         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2272
2273 2013-03-25  Julie Parent  <jparent@chromium.org>
2274
2275         Dashboard refactor: Move cross dashboard history related code into history.js.
2276         https://bugs.webkit.org/show_bug.cgi?id=113104
2277
2278         Reviewed by Ojan Vafai.
2279
2280         All functions relating to cross dashboard behavior move from being
2281         globals to methods on the history.History object. Names stay the same,
2282         except many are made private, ones that should have been constants now
2283         are, and the long standing TODO to change "currentState" to 
2284         dashboardSpecificState is done.
2285         
2286         We now create a global history object in dashboard_base, as an 
2287         intermediate measure.  Once the dashboard specific code is
2288         added to history, each DB will need to create its own, and this
2289         global will be eliminated.
2290         
2291         * TestResultServer/static-dashboards/aggregate_results.js:
2292         (handleValidHashParameter):
2293         (htmlForBuilder):
2294         (rawValuesHTML):
2295         * TestResultServer/static-dashboards/dashboard_base.js:
2296         (parseDashboardSpecificParameters):
2297         (defaultValue):
2298         (currentBuilderGroupCategory):
2299         (currentBuilderGroupName):
2300         (handleLocationChange):
2301         (expectationsMap):
2302         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2303         (generatePage):
2304         (.switch.return):
2305         (platformAndBuildType):
2306         (individualTests):
2307         (substringList):
2308         (processMissingAndExtraExpectations):
2309         (pathToFailureLog):
2310         (showPopupForBuild):
2311         (htmlForTestsWithExpectationsButNoFailures):
2312         (shouldHideTest):
2313         (isCrossBuilderView):
2314         (tableHeaders):
2315         (htmlForSingleTestRow):
2316         (htmlForTableColumnHeader):
2317         (generatePageForExpectationsUpdate):
2318         (handleUpdate):
2319         (nextUpdate):
2320         (setUpdateIndex):
2321         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2322         (.appendExpectationsItem):
2323         (loadExpectations):
2324         (.dummyNode.onload):
2325         (loadExpectationsLayoutTests):
2326         (appendExpectations):
2327         (htmlForNavBar):
2328         (checkBoxToToggleState):
2329         (linkHTMLToToggleState):
2330         (generatePageForBuilder):
2331         (isInvalidKeyForCrossBuilderView):
2332         (handleQueryParameterChange):
2333         (showLegend):
2334         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2335         (resetGlobals):
2336         (test):
2337         * TestResultServer/static-dashboards/history.js:
2338         (.):
2339         * TestResultServer/static-dashboards/history_unittests.js:
2340         * TestResultServer/static-dashboards/loader.js:
2341         (.):
2342         * TestResultServer/static-dashboards/loader_unittests.js:
2343         * TestResultServer/static-dashboards/timeline_explorer.js:
2344         (generatePage):
2345         (initCurrentBuilderTestResults):
2346         (selectBuild):
2347         (showResultsDelta):
2348         * TestResultServer/static-dashboards/treemap.js:
2349         (generatePage):
2350         (.switch.return):
2351         (handleFocus):
2352         * TestResultServer/static-dashboards/ui.js:
2353
2354 2013-03-25  Roger Fong  <roger_fong@apple.com>
2355
2356         Unreviewed. Enable WinEWS tests again.
2357
2358         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2359         (WinEWS):
2360
2361 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2362
2363         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2364         https://bugs.webkit.org/show_bug.cgi?id=112166
2365
2366         HarfBuzz 0.9.14 merged my patch for icu detection without
2367         pkg-config files, as needed by for example Ubuntu 12.04.
2368         This obsoletes our local workaround. Removed it for GTK and EFL.
2369
2370         Reviewed by Martin Robinson.
2371
2372         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2373         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2374         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2375         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2376
2377 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2378
2379         Unreviewed.  Move self from contributor to committer list.
2380
2381         * Scripts/webkitpy/common/config/committers.py:
2382
2383 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2384
2385         EWS should use a human readable port name when uploading layout test archives
2386         https://bugs.webkit.org/show_bug.cgi?id=113099
2387
2388         Reviewed by Dirk Pranke.
2389
2390         Use new port's object's name() method to report human readable port names.
2391         This will also help us resolving the bug to apply layout test results posted by EWS.
2392
2393         * Scripts/webkitpy/tool/bot/botinfo.py:
2394         (BotInfo.__init__): Take port's name.
2395         (BotInfo.summary_text):
2396
2397         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2398         (BotInfoTest.test_summary_text):
2399
2400         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2401         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2402
2403         * Scripts/webkitpy/tool/commands/queues.py:
2404         (PatchProcessingQueue.__init__): Initialize self._port.
2405         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2406         and use that for the attachment filename and the comment posted.
2407
2408         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2409         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2410         "mac-snowleopard" as expected for TestPort.
2411
2412 2013-03-22  Roger Fong  <roger_fong@apple.com>
2413
2414         Unreviewed. Turn off EWS test on Win again.
2415         The battle continues.
2416
2417         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2418         (WinEWS):
2419
2420 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2421
2422         NRWT: Enable pixel tests when retrying tests
2423         https://bugs.webkit.org/show_bug.cgi?id=112898
2424
2425         Reviewed by Dirk Pranke.
2426
2427         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2428         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2429         if we've forced pixel tests in the retry.
2430         (Manager._run_tests):
2431         (Manager._clean_up_run): Fixed the capitalizations.
2432         (Manager._force_pixel_tests_if_needed): Added.
2433
2434         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2435         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2436         'image_diff_percent' if it doesn't already exist.
2437
2438         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2439         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2440         treat this as a regular regression instead of a flakiness.
2441
2442         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2443         run had image diffs.
2444
2445         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2446         (summarized_results):
2447
2448         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2449         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2450         Also removed some dead code.
2451
2452         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2453         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2454         is set and pixel_tests_enabled is set to false.
2455         (EndToEndTest.test_reftest_with_two_notrefs):
2456
2457 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2458
2459         Make it possible to run layout tests on Retina MBP
2460         https://bugs.webkit.org/show_bug.cgi?id=93673
2461
2462         Reviewed by Ryosuke Niwa.
2463
2464         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2465         windows on 2x machines still run at 1x.
2466
2467         * DumpRenderTree/mac/DumpRenderTree.mm:
2468         (createWebViewAndOffscreenWindow):
2469         Reset the window resolution to 1x on creation.
2470         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2471         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2472         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2473         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2474         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2475         (WTR::PlatformWebView::PlatformWebView):
2476         Add NSWindow details, reset the window resolution to 1x on creation.
2477
2478 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2479
2480         Leak bots shouldn't build
2481         https://bugs.webkit.org/show_bug.cgi?id=112774
2482
2483         Reviewed by Simon Fraser.
2484
2485         Since leak bots use regular debug builds, there is no need to build on these bots.
2486         Simply downloading builds will dramatically improve the cycle time of these bots.
2487
2488         * BuildSlaveSupport/build.webkit.org-config/config.json:
2489         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2490         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2491         TestFactory instead of BuildAndTestFactory.
2492
2493 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2494
2495         [Qt] Fix the TestWebKitAPI build
2496         https://bugs.webkit.org/show_bug.cgi?id=113044
2497
2498         Reviewed by Tor Arne Vestbø.
2499
2500         The generate-forwarding-headers script would only be run
2501         after the targets in InjectedBundle.pri since the second
2502         addStrictSubdirOrderBetween call in
2503         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2504         the derived_sources -> injected_bundle order in SUBDIRS.
2505
2506         Fix it by only moving the dependent target at the end of
2507         SUBDIRS, don't touch its dependency.
2508
2509         * qmake/mkspecs/features/functions.prf:
2510
2511 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2512
2513         [EFL][WK2] View is not focused when fullscreen mode toggled
2514         https://bugs.webkit.org/show_bug.cgi?id=113009
2515
2516         Reviewed by Laszlo Gombos.
2517
2518         Set focus on view when fullscreen mode enabled/disabled
2519         by FullScreen API.
2520
2521         * MiniBrowser/efl/main.c:
2522         (on_fullscreen_accept):
2523         (on_fullscreen_deny):
2524
2525 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2526
2527         nrwt is no longer saving retry results in the retries/ subdirectory
2528         https://bugs.webkit.org/show_bug.cgi?id=112995
2529
2530         Reviewed by Ojan Vafai.
2531
2532         I think this has been broken a long time, unfortunately. This
2533         patch should fix that.
2534
2535         In order to do so, I had to pass the directory to use from
2536         the Worker object through the SingleTestWriter to the
2537         TestResultWriter. While I was plumbing that through, I rationalized
2538         the order of the parameter arguments a bit ...
2539
2540         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2541         (Worker._run_single_test):
2542         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2543         (run_single_test):
2544         (SingleTestRunner.__init__):
2545         (SingleTestRunner._run_compare_test):
2546         (SingleTestRunner._run_rebaseline):
2547         (SingleTestRunner._run_reftest):
2548         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2549         (write_test_result):
2550         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2551         (TestResultWriterTest.test_reftest_diff_image):
2552         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2553         (RunTest.test_retrying_uses_retries_directory):
2554
2555 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2556
2557         JSC profiler should have an at-a-glance report of the success of DFG optimization
2558         https://bugs.webkit.org/show_bug.cgi?id=112988
2559
2560         Reviewed by Geoffrey Garen.
2561
2562         * Scripts/display-profiler-output:
2563
2564 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2565
2566         [chromium] Linux ASAN WebKit canary is running out of memory
2567         https://bugs.webkit.org/show_bug.cgi?id=112978
2568
2569         Reviewed by Tony Chang.
2570
2571         Running the AddressSanitizer on a crash takes a lot of
2572         memory, so we should serialize access to it to avoid running
2573         out of memory on a machine.
2574
2575         * Scripts/webkitpy/layout_tests/port/chromium.py:
2576         (ChromiumPort._get_crash_log):
2577         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2578         (HttpLock.__init__):
2579         (HttpLock.wait_for_httpd_lock):
2580
2581 2013-03-21  Min Qin  <qinmin@chromium.org>
2582
2583         Cleanup android media layout test code
2584         https://bugs.webkit.org/show_bug.cgi?id=112944
2585
2586         Reviewed by Adam Barth.
2587
2588         Chromium change: https://codereview.chromium.org/12892010/
2589         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2590         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2591         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2592         Instead, we should switch to use content shell for layout tests.
2593
2594         * DumpRenderTree/chromium/TestShell.cpp:
2595         (TestShell::resetTestController):
2596
2597 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2598
2599         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2600         https://bugs.webkit.org/show_bug.cgi?id=112953
2601
2602         Reviewed by Tony Chang.
2603
2604         When I created the DumpRenderTree_resources target in r144863 I
2605         forgot to declare the needed dependencies on the other resource
2606         targets. Due to a quirk of ordering, this appears to have been fine
2607         w/ ninja but not w/ Xcode (which is still being used on the chromium
2608         mac valgrind bots). Declaring the dependencies fixes the build
2609         failures.
2610
2611         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2612
2613 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2614
2615         [WinCairo] Correct assert in Empty BitmapImage Test.
2616         https://bugs.webkit.org/show_bug.cgi?id=112934
2617
2618         Reviewed by Tim Horton.
2619
2620         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2621         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2622         to avoid ref counting assertion when leaving test scope.
2623
2624 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2625
2626         [GTK] generate-feature-defines-files is incompatible with Python3
2627         https://bugs.webkit.org/show_bug.cgi?id=112956
2628
2629         Reviewed by Martin Robinson.
2630
2631         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2632         method on the dictionary objects when iterating through said dictionaries.
2633
2634         * gtk/generate-feature-defines-files:
2635         (write_feature_defines_header):
2636         (write_flattened_feature_defines_file):
2637
2638 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2639
2640         kill-old-processes spits out error messages on Mac
2641         https://bugs.webkit.org/show_bug.cgi?id=112878
2642
2643         Reviewed by Jessie Berlin.
2644
2645         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2646         included in the list of options grep --help shows.
2647
2648         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2649
2650         * BuildSlaveSupport/kill-old-processes:
2651         (main):
2652
2653 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2654
2655         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2656         https://bugs.webkit.org/show_bug.cgi?id=112597
2657
2658         Reviewed by Xan Lopez.
2659
2660         These were introduced for the Chromium port in r105295. We need
2661         dummy implementations in order to compile the BlackBerry port.
2662
2663         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2664         (AccessibilityUIElement::scrollToMakeVisible):
2665         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2666         (AccessibilityUIElement::scrollToGlobalPoint):
2667
2668 2013-03-21  Roger Fong  <roger_fong@apple.com>
2669
2670         Re-enable WinEWS tests following r146376.
2671
2672         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2673         (WinEWS):
2674
2675 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2676
2677         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2678
2679         * Scripts/webkitpy/common/config/committers.py:
2680
2681 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2682
2683         [GTK] Missing atk in install-dependencies script
2684         https://bugs.webkit.org/show_bug.cgi?id=112272
2685
2686         Reviewed by Gustavo Noronha Silva.
2687
2688         * gtk/install-dependencies: Add missing atk dependency.
2689
2690 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2691
2692         [GTK] Missing backslash in install-dependencies script
2693         https://bugs.webkit.org/show_bug.cgi?id=112907
2694
2695         Reviewed by Philippe Normand.
2696
2697         * gtk/install-dependencies: Add missing backslash to dependencies
2698         list.
2699
2700 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2701
2702         EWS bots have stopped uploading results to bugzilla
2703         https://bugs.webkit.org/show_bug.cgi?id=101091
2704
2705         Reviewed by Adam Barth.
2706
2707         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2708         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2709         this relative file path resoled to a file inside a non-existent directory for "zip".
2710
2711         Fixed the bug by resolving both test results directory and zip archive paths in
2712         LayoutTestResultsReader.archive.
2713
2714         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2715         in the future.
2716
2717         * Scripts/webkitpy/common/system/filesystem_mock.py:
2718         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2719
2720         * Scripts/webkitpy/common/system/workspace.py:
2721         (Workspace.create_zip): Log the source path when "zip" failed.
2722
2723         * Scripts/webkitpy/common/system/workspace_mock.py:
2724         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2725
2726         * Scripts/webkitpy/common/system/workspace_unittest.py:
2727         (WorkspaceTest.test_create_zip_exception): Test that.
2728
2729         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2730         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2731         This is the actual bug fix.
2732
2733         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2734         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2735
2736 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2737
2738         [chromium] move WebThemeEngine implementations to TestRunner library
2739         https://bugs.webkit.org/show_bug.cgi?id=112751
2740
2741         Reviewed by Adam Barth.
2742
2743         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2744         * DumpRenderTree/DumpRenderTree.gypi:
2745         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2746         (WebKit):
2747         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2748         (WebTestRunner::TestInterfaces::themeEngine):
2749         (WebTestRunner):
2750         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2751         (WebKit):
2752         (TestInterfaces):
2753         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2754         (WebTestRunner::WebTestInterfaces::themeEngine):
2755         (WebTestRunner):
2756         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2757         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2758         (WebTestRunner):
2759         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2760         (WebTestRunner::WebTestThemeControlWin::box):
2761         (WebTestRunner::WebTestThemeControlWin::line):
2762         (WebTestRunner::WebTestThemeControlWin::triangle):
2763         (WebTestRunner::WebTestThemeControlWin::roundRect):
2764         (WebTestRunner::WebTestThemeControlWin::oval):
2765         (WebTestRunner::WebTestThemeControlWin::circle):
2766         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2767         (WebTestRunner::WebTestThemeControlWin::markState):
2768         (WebTestRunner::WebTestThemeControlWin::draw):
2769         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2770         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2771         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2772         (WebTestRunner):
2773         (WebTestThemeControlWin):
2774         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2775         (WebTestRunner):
2776         (WebTestThemeEngineMac):
2777         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2778         (+[FakeActiveWindow alwaysActiveWindow]):
2779         (+[FakeActiveWindow alwaysInactiveWindow]):
2780         (-[FakeActiveWindow initWithActiveControls:]):
2781         (-[FakeActiveWindow _hasActiveControls]):
2782         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2783         (WebTestRunner):
2784         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2785         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2786         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2787         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2788         (WebTestRunner):
2789         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2790         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2791         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2792         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2793         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2794         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2795         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2796         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2797         (WebTestRunner::WebTestThemeEngineWin::getSize):
2798         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2799         (WebTestRunner):
2800         (WebTestThemeEngineWin):
2801         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2802         * DumpRenderTree/chromium/TestShell.cpp:
2803         (TestShell::initialize):
2804         * DumpRenderTree/chromium/TestShell.h:
2805         (WebKit):
2806         * DumpRenderTree/chromium/TestShellMac.mm:
2807         (platformInit):
2808         * DumpRenderTree/chromium/TestShellWin.cpp:
2809         (platformInit):
2810         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2811
2812 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2813
2814         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2815
2816         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2817         New property sheet that does not link against CoreFoundation and
2818         CFNetwork.
2819         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2820         Use new TestWebKitAPICommonWinCairo property sheet.
2821         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2822         Ditto.
2823
2824 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2825
2826         [WinCairo] Unreviewed build fix for VS2010.
2827
2828         Had to add WinCairo-specific property sheets to deal with some
2829         library and path differences with the main Apple port.
2830
2831         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2832         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2833         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2834         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2835         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2836         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2837
2838 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2839
2840         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2841         https://bugs.webkit.org/show_bug.cgi?id=112849
2842
2843         Reviewed by Sam Weinig.
2844
2845         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2846         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2847         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2848
2849 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2850
2851         [WinCairo] Build WebKit Tools under VS2010
2852         https://bugs.webkit.org/show_bug.cgi?id=112821
2853
2854         Reviewed by Tim Horton.
2855
2856         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2857         Add WinCairo-specific build target.
2858         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2859         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2860         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2861         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2862         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2863         Add WinCairo-specific build target.
2864         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2865         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2866         Add WinCairo-specific build target.
2867         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2868         WinCairo-specific build target.
2869         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2870         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2871         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2872         specific build target.
2873         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2874         WinCairo-specific build target.
2875         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2876         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2877         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2878
2879 2013-03-20  Roger Fong  <roger_fong@apple.com>
2880
2881         API test gardening AppleWin port.
2882
2883         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2884
2885         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2886         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2887
2888 2013-03-20  Roger Fong  <roger_fong@apple.com>
2889
2890         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2891
2892         * EWSTools/start-queue-win.sh:
2893
2894 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2895
2896         Unreviewed, add myself to committers.py.
2897
2898 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2899
2900         Unreviewed. Adding another email for me.
2901
2902         * Scripts/webkitpy/common/config/committers.py:
2903
2904 2013-03-20  Justin Novosad  <junov@google.com>
2905
2906         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2907         https://bugs.webkit.org/show_bug.cgi?id=112605
2908
2909         Reviewed by James Robinson.
2910
2911         Deleting all the code that was used for propagating and supporting
2912         the Chromium setting for disabling deferred 2d canvas rendering.
2913
2914         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2915         (main):
2916         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2917         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2918         (WebTestRunner::WebPreferences::reset):
2919         (WebTestRunner::WebPreferences::applyTo):
2920         * DumpRenderTree/chromium/TestShell.cpp:
2921         (TestShell::TestShell):
2922         (TestShell::resetWebSettings):
2923         (TestShell::runFileTest):
2924         * DumpRenderTree/chromium/TestShell.h:
2925         (TestShell):
2926
2927 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2928
2929         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2930         https://bugs.webkit.org/show_bug.cgi?id=112699.
2931
2932         Reviewed by Adam Barth.
2933
2934         * Scripts/webkitpy/layout_tests/port/qt.py:
2935         (QtPort._search_paths):
2936         (QtPort._port_specific_expectations_files):
2937         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2938         (QtPortTest):
2939         (QtPortTest._assert_search_path):
2940         (QtPortTest._assert_expectations_files):
2941
2942 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2943
2944         [Qt] Enable kerning by default
2945         https://bugs.webkit.org/show_bug.cgi?id=112704
2946
2947         Reviewed by Jocelyn Turcotte.
2948
2949         Disable kerning by default, since some reference test expectations
2950         expect kerning to be default off.
2951
2952         * DumpRenderTree/qt/TestRunnerQt.cpp:
2953         (TestRunnerQt::reset):
2954         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2955         (WTR::activateFonts):
2956
2957 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2958
2959         [Qt] Remove empty function stubs from TestRunnerQt.
2960         https://bugs.webkit.org/show_bug.cgi?id=112799
2961
2962         We are reducing the code in TestRunnerQt step by step,
2963         in order to finally replace all of it with the generic
2964         TestRunner implementation.
2965         This patch removes several simple function stubs that
2966         currently do not implement any actual functionality.
2967
2968         Reviewed by Kenneth Rohde Christiansen.
2969
2970         * DumpRenderTree/qt/TestRunnerQt.cpp:
2971         * DumpRenderTree/qt/TestRunnerQt.h:
2972         (TestRunnerQt):
2973
2974 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2975
2976         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2977         https://bugs.webkit.org/show_bug.cgi?id=112687
2978
2979         Reviewed by Kenneth Rohde Christiansen.
2980
2981         Hide the SearchBar by default on window creation.
2982
2983         * MiniBrowser/efl/main.c:
2984         (window_create):
2985
2986 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2987
2988         Unreviewed, rolling out r146304.
2989         http://trac.webkit.org/changeset/146304
2990         https://bugs.webkit.org/show_bug.cgi?id=112788
2991
2992         to many expectations to update (Requested by antonm on
2993         #webkit).
2994
2995         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2996         * DumpRenderTree/DumpRenderTree.gypi:
2997         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2998         (WebKit):
2999         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3000         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3001         (TestInterfaces):
3002         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3003         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3004         * DumpRenderTree/chromium/TestShell.cpp:
3005         (TestShell::initialize):
3006         * DumpRenderTree/chromium/TestShell.h:
3007         (WebKit):
3008         * DumpRenderTree/chromium/TestShellMac.mm:
3009         (platformInit):
3010         * DumpRenderTree/chromium/TestShellWin.cpp:
3011         (platformInit):
3012         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3013         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3014         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3015         (WebThemeControlDRTWin::box):
3016         (WebThemeControlDRTWin::line):
3017         (WebThemeControlDRTWin::triangle):
3018         (WebThemeControlDRTWin::roundRect):
3019         (WebThemeControlDRTWin::oval):
3020         (WebThemeControlDRTWin::circle):
3021         (WebThemeControlDRTWin::nestedBoxes):
3022         (WebThemeControlDRTWin::markState):
3023         (WebThemeControlDRTWin::draw):
3024         (WebThemeControlDRTWin::drawTextField):
3025         (WebThemeControlDRTWin::drawProgressBar):
3026         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3027         (WebThemeControlDRTWin):
3028         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3029         (WebThemeEngineDRTMac):
3030         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3031         (+[FakeActiveWindow alwaysActiveWindow]):
3032         (+[FakeActiveWindow alwaysInactiveWindow]):
3033         (-[FakeActiveWindow initWithActiveControls:]):
3034         (-[FakeActiveWindow _hasActiveControls]):
3035         (WebThemeEngineDRTMac::paintScrollbarThumb):
3036         (stateToHIEnableState):
3037         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3038         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3039         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3040         (webRectToSkIRect):
3041         (drawControl):
3042         (drawTextField):
3043         (drawProgressBar):
3044         (WebThemeEngineDRTWin::paintButton):
3045         (WebThemeEngineDRTWin::paintMenuList):
3046         (WebThemeEngineDRTWin::paintScrollbarArrow):
3047         (WebThemeEngineDRTWin::paintScrollbarThumb):
3048         (WebThemeEngineDRTWin::paintScrollbarTrack):
3049         (WebThemeEngineDRTWin::paintSpinButton):
3050         (WebThemeEngineDRTWin::paintTextField):
3051         (WebThemeEngineDRTWin::paintTrackbar):
3052         (WebThemeEngineDRTWin::paintProgressBar):
3053         (WebThemeEngineDRTWin::getSize):
3054         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3055         (WebThemeEngineDRTWin):
3056         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3057
3058 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3059
3060         [Qt] Support -webkit-font-smoothing
3061         https://bugs.webkit.org/show_bug.cgi?id=106009
3062
3063         Reviewed by Jocelyn Turcotte.
3064
3065         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
3066
3067         * DumpRenderTree/qt/TestRunnerQt.cpp:
3068         (TestRunnerQt::reset):
3069
3070 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
3071
3072         [GTK] accessibility/aria-scrollbar-role.html is failing
3073         https://bugs.webkit.org/show_bug.cgi?id=98358
3074
3075         Reviewed by Martin Robinson.
3076
3077         Adds support for checking accessibility object's orientation.
3078         Orientation is checked by retrieving proper state of accessibility object.
3079
3080         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3081         (checkElementState):
3082         (AccessibilityUIElement::orientation):
3083         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3084         (WTR::AccessibilityUIElement::orientation):
3085
3086 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3087
3088         [chromium] move WebThemeEngine implementations to TestRunner library
3089         https://bugs.webkit.org/show_bug.cgi?id=112751
3090
3091         Reviewed by Adam Barth.
3092
3093         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3094         * DumpRenderTree/DumpRenderTree.gypi:
3095         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3096         (WebKit):
3097         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3098         (WebTestRunner::TestInterfaces::themeEngine):
3099         (WebTestRunner):
3100         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3101         (WebKit):
3102         (TestInterfaces):
3103         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3104         (WebTestRunner::WebTestInterfaces::themeEngine):
3105         (WebTestRunner):
3106         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3107         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3108         (WebTestRunner):
3109         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3110         (WebTestRunner::WebTestThemeControlWin::box):
3111         (WebTestRunner::WebTestThemeControlWin::line):
3112         (WebTestRunner::WebTestThemeControlWin::triangle):
3113         (WebTestRunner::WebTestThemeControlWin::roundRect):
3114         (WebTestRunner::WebTestThemeControlWin::oval):
3115         (WebTestRunner::WebTestThemeControlWin::circle):
3116         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3117         (WebTestRunner::WebTestThemeControlWin::markState):
3118         (WebTestRunner::WebTestThemeControlWin::draw):
3119         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3120         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3121         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3122         (WebTestRunner):
3123         (WebTestThemeControlWin):
3124         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3125         (WebTestRunner):
3126         (WebTestThemeEngineMac):
3127         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3128         (+[FakeActiveWindow alwaysActiveWindow]):
3129         (+[FakeActiveWindow alwaysInactiveWindow]):
3130         (-[FakeActiveWindow initWithActiveControls:]):
3131         (-[FakeActiveWindow _hasActiveControls]):
3132         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3133         (WebTestRunner):
3134         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3135         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3136         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3137         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3138         (WebTestRunner):
3139         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3140         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3141         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3142         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3143         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3144         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3145         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3146         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3147         (WebTestRunner::WebTestThemeEngineWin::getSize):
3148         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3149         (WebTestRunner):
3150         (WebTestThemeEngineWin):
3151         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3152         * DumpRenderTree/chromium/TestShell.cpp:
3153         (TestShell::initialize):
3154         * DumpRenderTree/chromium/TestShell.h:
3155         (WebKit):
3156         * DumpRenderTree/chromium/TestShellMac.mm:
3157         (platformInit):
3158         * DumpRenderTree/chromium/TestShellWin.cpp:
3159         (platformInit):
3160         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3161
3162 2013-03-19  Tony Chang  <tony@chromium.org>
3163
3164         Move testRunner.setTouchDragDropEnabled to internals.settings
3165         https://bugs.webkit.org/show_bug.cgi?id=112739
3166
3167         Reviewed by Adam Barth.
3168
3169         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3170         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
3171         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3172         (TestRunner): Remove unnecessary code.
3173         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3174         (WebTestRunner::WebPreferences::reset):
3175         (WebTestRunner::WebPreferences::applyTo): Always set to false.
3176
3177 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
3178
3179         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3180         https://bugs.webkit.org/show_bug.cgi?id=112754
3181
3182         Reviewed by Darin Fisher.
3183
3184         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3185         now that it's always defined.
3186
3187         * DumpRenderTree/chromium/WebViewHost.cpp:
3188         * DumpRenderTree/chromium/WebViewHost.h:
3189         (WebViewHost):
3190
3191 2013-03-19  Kenneth Russell  <kbr@google.com>
3192
3193         Unreviewed, rolling out r146290.
3194         http://trac.webkit.org/changeset/146290
3195         https://bugs.webkit.org/show_bug.cgi?id=112751
3196
3197         Broke Chromium Mac build.
3198
3199         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3200         * DumpRenderTree/DumpRenderTree.gypi:
3201         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3202         (WebKit):
3203         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3204         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3205         (TestInterfaces):
3206         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3207         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3208         * DumpRenderTree/chromium/TestShell.cpp:
3209         (TestShell::initialize):
3210         * DumpRenderTree/chromium/TestShell.h:
3211         (WebKit):
3212         * DumpRenderTree/chromium/TestShellMac.mm:
3213         (platformInit):
3214         * DumpRenderTree/chromium/TestShellWin.cpp:
3215         (platformInit):
3216         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3217         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3218         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3219         (WebThemeControlDRTWin::box):
3220         (WebThemeControlDRTWin::line):
3221         (WebThemeControlDRTWin::triangle):
3222         (WebThemeControlDRTWin::roundRect):
3223         (WebThemeControlDRTWin::oval):
3224         (WebThemeControlDRTWin::circle):
3225         (WebThemeControlDRTWin::nestedBoxes):
3226         (WebThemeControlDRTWin::markState):
3227         (WebThemeControlDRTWin::draw):
3228         (WebThemeControlDRTWin::drawTextField):
3229         (WebThemeControlDRTWin::drawProgressBar):
3230         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3231         (WebThemeControlDRTWin):
3232         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3233         (WebThemeEngineDRTMac):
3234         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3235         (+[FakeActiveWindow alwaysActiveWindow]):
3236         (+[FakeActiveWindow alwaysInactiveWindow]):
3237         (-[FakeActiveWindow initWithActiveControls:]):
3238         (-[FakeActiveWindow _hasActiveControls]):
3239         (WebThemeEngineDRTMac::paintScrollbarThumb):
3240         (stateToHIEnableState):
3241         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3242         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3243         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3244         (webRectToSkIRect):
3245         (drawControl):
3246         (drawTextField):
3247         (drawProgressBar):
3248         (WebThemeEngineDRTWin::paintButton):
3249         (WebThemeEngineDRTWin::paintMenuList):
3250         (WebThemeEngineDRTWin::paintScrollbarArrow):
3251         (WebThemeEngineDRTWin::paintScrollbarThumb):
3252         (WebThemeEngineDRTWin::paintScrollbarTrack):
3253         (WebThemeEngineDRTWin::paintSpinButton):
3254         (WebThemeEngineDRTWin::paintTextField):
3255         (WebThemeEngineDRTWin::paintTrackbar):
3256         (WebThemeEngineDRTWin::paintProgressBar):
3257         (WebThemeEngineDRTWin::getSize):
3258         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3259         (WebThemeEngineDRTWin):
3260         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3261
3262 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
3263
3264         [EFL] canvas-fallback-content.html is failing
3265         https://bugs.webkit.org/show_bug.cgi?id=111998
3266
3267         Reviewed by Chris Fleizach.
3268
3269         Adds support for getting platform name.
3270
3271         * DumpRenderTree/TestRunner.cpp:
3272         (TestRunner::staticValues):
3273         * DumpRenderTree/TestRunner.h:
3274         (TestRunner):
3275         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3276         (TestRunner::platformName):
3277
3278 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3279
3280         [chromium] move WebThemeEngine implementations to TestRunner library
3281         https://bugs.webkit.org/show_bug.cgi?id=112751
3282
3283         Reviewed by Adam Barth.
3284
3285         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3286         * DumpRenderTree/DumpRenderTree.gypi:
3287         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3288         (WebKit):
3289         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3290         (WebTestRunner::TestInterfaces::themeEngine):
3291         (WebTestRunner):
3292         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3293         (WebKit):
3294         (TestInterfaces):
3295         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3296         (WebTestRunner::WebTestInterfaces::themeEngine):
3297         (WebTestRunner):
3298         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3299         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3300         (WebTestRunner):
3301         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3302         (WebTestRunner::WebTestThemeControlWin::box):
3303         (WebTestRunner::WebTestThemeControlWin::line):
3304         (WebTestRunner::WebTestThemeControlWin::triangle):
3305         (WebTestRunner::WebTestThemeControlWin::roundRect):
3306         (WebTestRunner::WebTestThemeControlWin::oval):
3307         (WebTestRunner::WebTestThemeControlWin::circle):
3308         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3309         (WebTestRunner::WebTestThemeControlWin::markState):
3310         (WebTestRunner::WebTestThemeControlWin::draw):
3311         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3312         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3313         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3314         (WebTestRunner):
3315         (WebTestThemeControlWin):
3316         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3317         (WebTestRunner):
3318         (WebTestThemeEngineMac):
3319         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3320         (+[FakeActiveWindow alwaysActiveWindow]):
3321         (+[FakeActiveWindow alwaysInactiveWindow]):
3322         (-[FakeActiveWindow initWithActiveControls:]):
3323         (-[FakeActiveWindow _hasActiveControls]):
3324         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3325         (WebTestRunner):
3326         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3327         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3328         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3329         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3330         (WebTestRunner):
3331         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3332         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3333         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3334         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3335         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3336         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3337         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3338         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3339         (WebTestRunner::WebTestThemeEngineWin::getSize):
3340         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3341         (WebTestRunner):
3342         (WebTestThemeEngineWin):
3343         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3344         * DumpRenderTree/chromium/TestShell.cpp:
3345         (TestShell::initialize):
3346         * DumpRenderTree/chromium/TestShell.h:
3347         (WebKit):
3348         * DumpRenderTree/chromium/TestShellMac.mm:
3349         (platformInit):
3350         * DumpRenderTree/chromium/TestShellWin.cpp:
3351         (platformInit):
3352         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3353
3354 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3355
3356         [EFL][WK2] Separate WebView further from EwkView
3357         https://bugs.webkit.org/show_bug.cgi?id=111591
3358
3359         Reviewed by Caio Marcelo de Oliveira Filho.
3360
3361         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3362         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3363         since we can afford it having EWKViewGetWKView() private API to access WKView.
3364
3365         * TestWebKitAPI/PlatformWebView.h:
3366         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3367         (TestWebKitAPI::TEST):
3368         * TestWebKitAPI/efl/PlatformWebView.cpp:
3369         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3370         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3371         (TestWebKitAPI::PlatformWebView::resizeTo):
3372         (TestWebKitAPI::PlatformWebView::page):
3373         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3374         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3375         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3376         * WebKitTestRunner/PlatformWebView.h:
3377         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3378         (WTR::EventSenderProxy::dispatchEvent):
3379         (WTR::EventSenderProxy::keyDown):
3380         (WTR::EventSenderProxy::sendTouchEvent):
3381         (WTR::EventSenderProxy::setTouchModifier):
3382         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3383         (WTR::PlatformWebView::PlatformWebView):
3384         (WTR::PlatformWebView::~PlatformWebView):
3385         (WTR::PlatformWebView::resizeTo):
3386         (WTR::PlatformWebView::page):
3387         (WTR::PlatformWebView::focus):
3388         (WTR::PlatformWebView::windowSnapshotImage):
3389
3390 2013-03-19  Roger Fong  <roger_fong@apple.com>
3391
3392         Changes to VS2010 project files should only trigger builds on Windows bots.
3393         https://bugs.webkit.org/show_bug.cgi?id=112731
3394
3395         Reviewed by Timothy Horton.
3396
3397         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3398         (_should_file_trigger_build):
3399
3400 2013-03-19  Roger Fong  <roger_fong@apple.com>
3401
3402         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3403
3404         * Scripts/webkitpy/tool/steps/runtests.py:
3405         (RunTests.run):
3406         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3407         (RunTestsTest.test_webkit_run_unit_tests):
3408
3409 2013-03-19  Julie Parent  <jparent@chromium.org>
3410
3411         Dashboards: Introduce history namespace and unit tests.
3412         https://bugs.webkit.org/show_bug.cgi?id=112645
3413
3414         Reviewed by Ojan Vafai.
3415         
3416         Laying the framework for introducing the new history object and
3417         namespace.  This moves only static functions into the history
3418         namespace, and moves corresponding unit tests into seperate
3419         unit test file.
3420
3421         * TestResultServer/static-dashboards/aggregate_results.html:
3422         * TestResultServer/static-dashboards/dashboard_base.js:
3423         (parseCrossDashboardParameters):
3424         (parseDashboardSpecificParameters):
3425         (parseParameters):
3426         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3427         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3428         (.switch.return):
3429         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3430         * TestResultServer/static-dashboards/history.js: Added.
3431         * TestResultServer/static-dashboards/history_unittests.js: Added.
3432         * TestResultServer/static-dashboards/loader.js:
3433         (.):
3434         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3435         * TestResultServer/static-dashboards/run-unittests.html:
3436         * TestResultServer/static-dashboards/timeline_explorer.html:
3437         * TestResultServer/static-dashboards/timeline_explorer.js:
3438         * TestResultServer/static-dashboards/treemap.html:
3439         * TestResultServer/static-dashboards/treemap.js:
3440         (.switch.return):
3441         * TestResultServer/static-dashboards/ui.js:
3442
3443 2013-03-19  Daniel Bates  <dbates@webkit.org>
3444
3445         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3446         https://bugs.webkit.org/show_bug.cgi?id=112732
3447
3448         Reviewed by Eric Seidel.
3449
3450         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3451         of an existing file cannot be applied.
3452
3453         In particular, svn-{apply, unapply} compensate for differences in line endings
3454         by converting the line endings in a diff to match the line endings in the target
3455         file. The diff(1) command precedes the last line of a diff that adds a newline
3456         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3457         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3458         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3459         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3460         the newline characters in this special character sequence to match the line endings
3461         in the target file.
3462
3463         * Scripts/VCSUtils.pm:
3464         (parseDiff):
3465         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3466         Added tests:
3467             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3468             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3469             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3470             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3471         (escapeNewLineCharacters): Added.
3472         (toMacLineEndings): Added.
3473
3474 2013-03-19  James Robinson  <jamesr@chromium.org>
3475
3476         [chromium] Remove compositor settings that don't go through WebKit
3477         https://bugs.webkit.org/show_bug.cgi?id=112718
3478
3479         Reviewed by Adam Barth.
3480
3481         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3482         (main):
3483         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3484         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3485         (WebTestRunner::WebPreferences::reset):
3486         (WebTestRunner::WebPreferences::applyTo):
3487         * DumpRenderTree/chromium/TestShell.cpp:
3488         (TestShell::TestShell):
3489         (TestShell::resetWebSettings):
3490         * DumpRenderTree/chromium/TestShell.h:
3491         (TestShell):
3492
3493 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3494
3495         Unreviewed, rolling out r146101.
3496         https://bugs.webkit.org/show_bug.cgi?id=111884
3497
3498         re-enable custom freetype on asan; this needs to be on
3499         now that the bot is running lucid.
3500
3501         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3502
3503 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3504
3505         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3506         https://bugs.webkit.org/show_bug.cgi?id=112365
3507
3508         Reviewed by Benjamin Poulain.
3509
3510         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3511         harcoding it in wtf/Platform.h
3512
3513         * Scripts/webkitperl/FeatureList.pm:
3514
3515 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3516
3517         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3518         https://bugs.webkit.org/show_bug.cgi?id=94782
3519
3520         Based on patch by Csaba Osztrogonác.
3521         Reviewed by Jocelyn Turcotte.
3522
3523         The diff image is generated with bright red indicating errors, but letting the base image
3524         shine through so the context of the error-pixel can be identified.
3525
3526         * DumpRenderTree/qt/ImageDiff.cpp:
3527         (main):
3528
3529 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3530
3531         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3532
3533         Rubber-stamped by Csaba Osztrogonác.
3534
3535         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3536         since the latter might not cover the former.
3537
3538         * QtTestBrowser/launcherwindow.cpp:
3539         (LauncherWindow::print):
3540
3541 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3542
3543         Style tweeks to default.css.
3544         
3545         Rubber-stamped by David Kilzer.
3546         
3547         Give visited links a different color to other links, so you can
3548         see which builds you've viewed.
3549         
3550         Make the <small> text less tiny.
3551
3552         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3553         (small):
3554         (a:link,a:visited,a:active):
3555         (a:visited):
3556
3557 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3558
3559         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3560         https://bugs.webkit.org/show_bug.cgi?id=112494
3561
3562         Reviewed by Dirk Pranke.
3563
3564         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3565         Also merged two pairs of methods to cleanup the code.
3566
3567         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3568         (PerfTestsRunner.run): Merged _upload_and_show_results.
3569         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3570
3571 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3572
3573         [chromium] build xdisplaycheck when building DRT
3574         https://bugs.webkit.org/show_bug.cgi?id=112636
3575
3576         Reviewed by Tony Chang.
3577
3578         It appears that we need xdisplaycheck to be built in order for
3579         Xvfb to be started correctly on the bots, and DRT was missing
3580         a dependency on it. This may be the cause of the ASAN bot not
3581         starting up properly (it only builds DRT).
3582
3583         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3584
3585 2013-03-18  David Levin  <levin@chromium.org>
3586
3587         Implement icon change notification dump for Chromium's test shell.
3588         https://bugs.webkit.org/show_bug.cgi?id=112614
3589
3590         This was previously implemented for some other platforms in r58111
3591         and r116547.
3592
3593         In r122806, fast/dom/icon-url-property.html stopped using it, but
3594         it is useful for tests, so I plan to re-add it to that test again.
3595
3596         Reviewed by Jochen Eisinger.
3597
3598         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3599         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3600          icon change notifications from WebKit may be logged in test output.
3601         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3602         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3603         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3604         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3605         (WebTestRunner):
3606         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3607         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3608         (TestRunner):
3609         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3610         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3611         (WebTestRunner):
3612         * DumpRenderTree/chromium/WebViewHost.cpp:
3613         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3614         * DumpRenderTree/chromium/WebViewHost.h:
3615         (WebViewHost):
3616
3617 2013-03-18  Julie Parent  <jparent@chromium.org>
3618
3619         Cleanup: Move js for treemap and aggregate_results into own js files.
3620         https://bugs.webkit.org/show_bug.cgi?id=112618
3621
3622         Reviewed by Dirk Pranke.
3623         
3624         No functional changes, just moving the code into separate js file
3625         rather than inlined in the html, so we can test it, make it more
3626         modular, etc.  Other dashboard types are already done this way.
3627
3628         * TestResultServer/static-dashboards/aggregate_results.html:
3629         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3630         (generatePage):
3631         (handleValidHashParameter):
3632         (htmlForBuilder):
3633         (rawValuesHTML):
3634         (chartHTML):
3635         (filteredValues):
3636         (chart):
3637         (htmlForRevisionRows):
3638         (wrapHTMLInTable):
3639         (htmlForSummaryTable):
3640         (valuesPerExpectation):
3641         (htmlForTestType):
3642         (htmlForTableRow):
3643         (extendedEncode):
3644         * TestResultServer/static-dashboards/treemap.html:
3645         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3646         (humanReadableTime):
3647         (convertToWebTreemapFormat):
3648         (reverseSortByAverage):
3649         (generatePage):
3650         (focusPath):
3651         (.switch.return):
3652         (handleQueryParameterChange):
3653         (extractName):
3654         (fullName):
3655         (handleFocus.):
3656         (handleFocus):
3657
3658 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3659
3660         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3661         https://bugs.webkit.org/show_bug.cgi?id=112622
3662
3663         Reviewed by Dirk Pranke.
3664
3665         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3666         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3667
3668 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3669
3670         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3671         https://bugs.webkit.org/show_bug.cgi?id=112619
3672
3673         Reviewed by Dirk Pranke.
3674
3675         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3676         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3677
3678         * Scripts/webkitpy/layout_tests/port/gtk.py:
3679         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3680         Port._webkit_baseline_path method.
3681         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3682         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3683         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3684         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3685         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3686         that are expected based on the builder name.
3687
3688 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3689
3690         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3691         https://bugs.webkit.org/show_bug.cgi?id=112571
3692
3693         Reviewed by Adam Barth.
3694
3695         Update function declarations for new WebFileSystemType enum. (All
3696         changes are behind an #ifdef so we can sync required changes in embedders.)
3697
3698         * DumpRenderTree/chromium/WebViewHost.cpp:
3699         (WebViewHost::openFileSystem):
3700         (WebViewHost::deleteFileSystem):
3701         * DumpRenderTree/chromium/WebViewHost.h:
3702         (WebViewHost):
3703
3704 2013-03-18  Julie Parent  <jparent@chromium.org>
3705
3706         Cleanup: Move timeline_exporer js out of html file into js.
3707         https://bugs.webkit.org/show_bug.cgi?id=112188
3708
3709         Reviewed by Dirk Pranke.
3710         
3711         Moves the javascript out of the html file and into a new js file.
3712         This follows the format of flakiness_dashboard.{html|js}.
3713         
3714         Also moves code from dashboard_base that is used only by this one
3715         dashboard, and makes it private to the dashboard.
3716
3717         * TestResultServer/static-dashboards/dashboard_base.js:
3718         * TestResultServer/static-dashboards/timeline_explorer.html:
3719         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3720         (generatePage):
3721         (initCurrentBuilderTestResults):
3722         (shouldShowWebKitRevisionsOnly):
3723         (updateTimelineForBuilder.):
3724         (updateTimelineForBuilder):
3725         (selectBuild):
3726         (updateBuildIndicator):
3727         (.addRow):
3728         (.addNumberRow):
3729         (.inspectorNode.getElementsByTagName.0.onclick):
3730         (.inspectorNode.getElementsByTagName.1.onclick):
3731         (.inspectorNode.getElementsByTagName.2.onclick):
3732         (updateBuildInspector):
3733         (showResultsDelta):
3734         (decompressResults.addFlakyDelta):
3735         (decompressResults):
3736
3737 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3738
3739         Unreviewed, rolling out r145272.
3740         http://trac.webkit.org/changeset/145272
3741         https://bugs.webkit.org/show_bug.cgi?id=111884
3742
3743         Turns out the ASAN build is still broken; possibly there's
3744         something still setting LD_LIBRARY_PATH, or possibly there's
3745         something else wrong. In the meantime, we need it to work again.
3746
3747         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3748
3749 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3750
3751         delete-stale-build-files is too aggressive
3752         https://bugs.webkit.org/show_bug.cgi?id=112595
3753
3754         Reviewed by Tim Horton.
3755
3756         It appears that whitelisting file extensions to keep is not a good idea.
3757         Blacklist files to delete instead, and only delete .o files for now.
3758         We can add more file extensions as needed.
3759
3760         * BuildSlaveSupport/delete-stale-build-files:
3761
3762 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3763
3764         Disable accessibility notifications after each test
3765         https://bugs.webkit.org/show_bug.cgi?id=112579
3766
3767         Reviewed by Tim Horton.
3768         
3769         In WebKitTestRunner, if any tests triggered accessibility notifications,
3770         the global notification handler would thereafter be active, and fire
3771         notifications for all subsequent tests.
3772         
3773         Fix by implementing AccessibilityController::resetToConsistentState() for
3774         Mac, and using it to clear the global notification handler.
3775
3776         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3777         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3778         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3779         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3780         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3781         (e.g. because of -autorelease).
3782         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3783         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3784         if there is one.
3785         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3786         Add -stopObserving
3787         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3788         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3789         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3790         center.
3791
3792 2013-03-18  Dana Jansens  <danakj@chromium.org>
3793
3794         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3795         https://bugs.webkit.org/show_bug.cgi?id=112392
3796
3797         Reviewed by James Robinson.
3798
3799         Removes the command line flag option from DRT.
3800
3801         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3802         (main):
3803
3804 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3805
3806         [GTK] plugins/plugin-clip-subframe.html is failing
3807         https://bugs.webkit.org/show_bug.cgi?id=112570
3808
3809         Reviewed by Martin Robinson.
3810
3811         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3812
3813 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3814
3815         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3816         https://bugs.webkit.org/show_bug.cgi?id=112442
3817
3818         Reviewed by Gustavo Noronha Silva.
3819
3820         * GtkLauncher/main.c:
3821         (reloadCb):
3822         (createToolbar):
3823         (createWindow):
3824
3825 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3826
3827         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3828         https://bugs.webkit.org/show_bug.cgi?id=112205
3829
3830         Disable this API test until Geoff can fix it.
3831
3832         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3833         (TestWebKitAPI::TEST):
3834
3835 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3836
3837         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3838         https://bugs.webkit.org/show_bug.cgi?id=112478
3839
3840         Reviewed by Tony Chang.
3841
3842         There is nothing that ensures that the log messages from the plugin
3843         come in before the layout test finished loading.
3844
3845         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3846         (PassDifferentNPPStruct::NPP_SetWindow):
3847         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3848         (NPP_SetWindow):
3849
3850 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3851
3852         Have the mac port support per_test_timeout in webkitpy
3853         https://bugs.webkit.org/show_bug.cgi?id=112466
3854
3855         Reviewed by Dirk Pranke.
3856         
3857         Both WTR and DRT handle --timeout arguments, so we can
3858         have the scripts pass the timeout values down to the tools.
3859
3860         * Scripts/webkitpy/layout_tests/port/mac.py:
3861         (MacPort.supports_per_test_timeout):
3862
3863 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3864
3865         Remove setAsynchronousSpellCheckingEnabled from test runners
3866         https://bugs.webkit.org/show_bug.cgi?id=112362
3867
3868         Reviewed by Tony Chang.
3869
3870         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3871         in internals.settings, so all ports can share it.
3872
3873         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3874         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3875         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3876         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3877         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3878         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3879         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3880         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3881         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3882         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3883         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3884         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3885
3886 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3887
3888         Fix the stupid unit tests.
3889
3890         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3891         (test_sample_process):
3892
3893 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3894
3895         Collect samples for unresponsive web processes
3896         https://bugs.webkit.org/show_bug.cgi?id=112409
3897
3898         Reviewed by Tim Horton.
3899         
3900         When we detect that a subprocess was unresponsive, run the 'sample'
3901         tool on that process, for the Mac port.
3902         
3903         The sample will be linked to from the results.html page, next
3904         to the crash log link.
3905
3906         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3907         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3908         look for samples on disk.
3909         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3910         (TestResultWriter):
3911         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3912         -sample.txt files, and have it copy their contents to a new file
3913         next to the test that spawned them (as we do for crash logs).
3914         * Scripts/webkitpy/layout_tests/port/base.py:
3915         (Port.look_for_new_samples): Base class does nothing for sampling.
3916         * Scripts/webkitpy/layout_tests/port/driver.py:
3917         (Driver._check_for_driver_crash): Kick off a sample if we detected
3918         that the subprocess was unresponsive.
3919         * Scripts/webkitpy/layout_tests/port/mac.py:
3920         (MacPort.sample_file_path): Utility to generate the file path
3921         to the generated sample files at the top level of layout-test-results.
3922         (MacPort.look_for_new_crash_logs): Fix typo
3923         (MacPort.look_for_new_samples): New function to find sample files.
3924         (MacPort.sample_process): Use the utility function to get the file path.
3925
3926 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3927
3928         [Qt] Remove simple getters and setters from TestRunnerQt
3929         https://bugs.webkit.org/show_bug.cgi?id=112343
3930
3931         Reviewed by Benjamin Poulain.
3932
3933         The removed functions and boolean members
3934         are being replaced by the implementations in the
3935         generic TestRunner.h.
3936
3937         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3938         (DumpRenderTree::dumpFrameScrollPosition):
3939         (DumpRenderTree::dumpFramesAsText):
3940         (DumpRenderTree::dump):
3941         (DumpRenderTree::titleChanged):
3942         (DumpRenderTree::dumpDatabaseQuota):
3943         (DumpRenderTree::dumpApplicationCacheQuota):
3944         (DumpRenderTree::statusBarMessage):
3945         (DumpRenderTree::createWindow):
3946         * DumpRenderTree/qt/TestRunnerQt.cpp:
3947         (TestRunnerQt::reset):
3948         * DumpRenderTree/qt/TestRunnerQt.h:
3949         (TestRunnerQt):
3950
3951 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3952
3953         Update the link on build.webkit.org to refer to perf.webkit.org
3954         https://bugs.webkit.org/show_bug.cgi?id=112416
3955
3956         Reviewed by Philip Rogers.
3957
3958         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3959
3960         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3961
3962 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3963
3964         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3965         https://bugs.webkit.org/show_bug.cgi?id=112394
3966
3967         Reviewed by Philippe Normand.
3968
3969         * GtkLauncher/main.c:
3970         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3971
3972 2013-03-14  Andreas Kling  <akling@apple.com>
3973
3974         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3975         <http://webkit.org/b/111815>
3976         <rdar://problem/13380145>
3977
3978         Reviewed by Anders Carlsson.
3979
3980         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3981         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3982         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3983
3984         * WebKitTestRunner/PlatformWebView.h:
3985         (PlatformWebView):
3986         * WebKitTestRunner/TestController.cpp:
3987         (WTR::TestController::createOtherPage):
3988         (WTR::TestController::createWebViewWithOptions):
3989         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3990         (WTR::PlatformWebView::didInitializeClients):
3991
3992 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3993
3994         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3995         https://bugs.webkit.org/show_bug.cgi?id=112122
3996
3997         Reviewed by Kenneth Rohde Christiansen.
3998
3999         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
4000
4001         * MiniBrowser/efl/main.c:
4002         (_Browser_Window):
4003         (search_box_show):
4004         (search_box_hide):
4005         (on_key_down):
4006         (on_url_changed):
4007         (on_search_field_aborted):
4008         (on_search_field_activated):
4009         (on_search_field_clicked):
4010         (on_search_backward_button_clicked):
4011         (on_search_forward_button_clicked):
4012         (window_create):
4013
4014 2013-03-14  Julie Parent  <jparent@chromium.org>
4015
4016         Cleanup: Remove g_resourceLoader.
4017         https://bugs.webkit.org/show_bug.cgi?id=112305
4018
4019         Reviewed by Dirk Pranke.
4020         
4021         Removing another global.
4022         
4023         Now, each dashboard creates its own loader, rather than having
4024         a general global one.
4025         
4026         Remove usage of g_resourceLoader.isLoadingComplete from 
4027         handleLocationChange by ensuring that handleLocationChange is
4028         never called before the loader is done.  It was called in two
4029         places before: 1 was from the callback when the loader is done,
4030         so that was obviously true, and the other was from onhashchange,
4031         where it would just return rather than running.  Instead, lets
4032         only register the onhashchange handler once the loader is
4033         setup, so the check is no longer necessary.
4034         
4035         Remove isLoadingComplete since it is now unused.
4036         
4037         Callback for loader is now initializeHistory, rather than just
4038         handleLocationChange which will set up the hashchange handler now.
4039         This will all eventually be moving to a new History object.
4040
4041         * TestResultServer/static-dashboards/aggregate_results.html:
4042         * TestResultServer/static-dashboards/dashboard_base.js:
4043         (handleLocationChange):
4044         (intializeHistory):
4045         (decompressResults):
4046         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4047         (generatePage):
4048         * TestResultServer/static-dashboards/loader.js:
4049         (.):
4050         * TestResultServer/static-dashboards/loader_unittests.js:
4051         * TestResultServer/static-dashboards/timeline_explorer.html:
4052         * TestResultServer/static-dashboards/treemap.html:
4053
4054 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
4055
4056         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
4057         https://bugs.webkit.org/show_bug.cgi?id=109404
4058
4059         Reviewed by Tony Chang.
4060
4061         Removes all the code related to smartInsertDeleteEnabled and
4062         selectTrailingWhitespaceEnabled settings as they will be managed from
4063         internals from now on.
4064
4065         * DumpRenderTree/TestRunner.cpp:
4066         (TestRunner::staticFunctions):
4067         * DumpRenderTree/TestRunner.h:
4068         (TestRunner):
4069         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
4070         (WebKit):
4071         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
4072         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
4073         (DumpRenderTree):
4074         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4075         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4076         (WebTestRunner::WebTestProxy::didStopLoading):
4077         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4078         (WebTestRunner::TestRunner::TestRunner):
4079         (WebTestRunner::TestRunner::reset):
4080         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4081         (TestRunner):
4082         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
4083         (WebTestRunner::WebPreferences::applyTo): Set default values for
4084         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
4085         Chromium DRT default values are different from Chromium browser.
4086         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4087         * DumpRenderTree/chromium/WebViewHost.cpp:
4088         * DumpRenderTree/chromium/WebViewHost.h:
4089         (WebViewHost):
4090         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4091         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4092         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4093         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4094         (resetDefaultsToConsistentValues):
4095         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4096         * DumpRenderTree/mac/DumpRenderTree.mm:
4097         (resetWebViewToConsistentStateBeforeTesting):
4098         * DumpRenderTree/mac/TestRunnerMac.mm:
4099         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4100         (WebCore::WebPage::resetSettings):
4101         * DumpRenderTree/qt/TestRunnerQt.cpp:
4102         * DumpRenderTree/qt/TestRunnerQt.h:
4103         (TestRunnerQt):
4104         * DumpRenderTree/win/DumpRenderTree.cpp:
4105         (resetWebViewToConsistentStateBeforeTesting):
4106         * DumpRenderTree/win/TestRunnerWin.cpp:
4107         * DumpRenderTree/wx/TestRunnerWx.cpp:
4108
4109 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
4110
4111         [Qt] Disable DRT on Windows
4112
4113         Reviewed by Jocelyn Turcotte.
4114
4115         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
4116
4117         * qmake/mkspecs/features/configure.prf:
4118
4119 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
4120
4121         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
4122         https://bugs.webkit.org/show_bug.cgi?id=110728
4123
4124         Reviewed by Gyuyoung Kim.
4125
4126         Use the page group to create the view object.
4127
4128         * MiniBrowser/efl/main.c:
4129         (window_create):
4130
4131 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
4132
4133         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
4134
4135         Reviewed by Tor Arne Vestbø.
4136
4137         The mock versions of these web facing features should be instantiated when
4138         running in DumpRenderTree only. In order for them to work, no extra Qt modules
4139         such as QtLocation are actually needed.
4140
4141         This patch decouples enabling device orientation/motion and geolocation from
4142         the underlying Qt modules and makes them available in developer builds
4143         (!production_build) and backed by mock backends when running in drt.
4144
4145         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
4146         developers the web facing features are always enabled (although requests will
4147         time out) and the mock backends are enabled inside DRT, allowing for the layout
4148         tests to run with less dependencies.
4149
4150         In addition this also enables the mock device motion client, which was
4151         previously never instantiated.
4152
4153         * qmake/mkspecs/features/features.prf:
4154
4155 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4156
4157         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
4158         https://bugs.webkit.org/show_bug.cgi?id=112340
4159
4160         Reviewed by Simon Hausmann.
4161
4162         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4163         (DumpRenderTree::dump):
4164             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
4165         (DumpRenderTree::dumpApplicationCacheQuota):
4166         * DumpRenderTree/qt/TestRunnerQt.cpp:
4167         (TestRunnerQt::reset):
4168         * DumpRenderTree/qt/TestRunnerQt.h:
4169         (TestRunnerQt):
4170
4171 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4172
4173         [Qt] Port DRT to use TestRunner::dumpAsText()
4174         https://bugs.webkit.org/show_bug.cgi?id=112260
4175
4176         Reviewed by Benjamin Poulain.
4177
4178         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4179         (WebCore::DumpRenderTree::open):
4180         (WebCore::methodNameStringForFailedTest):
4181             Change parameter from type TestRunnerQt* to TestRunner*.
4182         (WebCore::DumpRenderTree::dump):
4183             TestRunnerQt::shouldDumpPixels() always returned true in our case.
4184             Instead we should rely on TestRunner::generatePixelResults().
4185         * DumpRenderTree/qt/TestRunnerQt.cpp:
4186         (TestRunnerQt::reset):
4187         * DumpRenderTree/qt/TestRunnerQt.h:
4188         (TestRunnerQt):
4189
4190 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
4191
4192         Implement FontLoader interface
4193         https://bugs.webkit.org/show_bug.cgi?id=98395
4194
4195         Reviewed by Eric Seidel.
4196
4197         Enable FontLoadEvents runtime flag for TestShell.
4198
4199         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4200         (WebTestRunner::TestInterfaces::TestInterfaces):
4201
4202 2013-03-13  Julie Parent  <jparent@chromium.org>
4203
4204         CLeanup: remove unnecessary call to parseParameters.
4205         https://bugs.webkit.org/show_bug.cgi?id=112309
4206
4207         Reviewed by Ojan Vafai.
4208         
4209         We call parseCrossDashboardParameters when the dashboard initially
4210         loads to set the state required for loadBuildersList, and then we
4211         call it again once we are fully done with loading, so there is no
4212         reason to call it in the middle of the loading process here.
4213
4214         * TestResultServer/static-dashboards/loader.js:
4215         (.):
4216
4217 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
4218
4219         Unreviewed. Now I'm a reviewer :)
4220
4221         * Scripts/webkitpy/common/config/committers.py:
4222
4223 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
4224
4225         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
4226         https://bugs.webkit.org/show_bug.cgi?id=112277
4227
4228         Reviewed by Adam Barth.
4229
4230         * Scripts/webkitperl/FeatureList.pm:
4231         * qmake/mkspecs/features/features.pri:
4232
4233 2013-03-13  Adam Barth  <abarth@webkit.org>
4234
4235         run-perf-tests should support content_shell
4236         https://bugs.webkit.org/show_bug.cgi?id=112291
4237
4238         Reviewed by Eric Seidel.
4239
4240         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4241         (PerfTestsRunner._parse_args):
4242
4243 2013-03-13  Oliver Hunt  <oliver@apple.com>
4244
4245         Simplify Checked<> multiplication
4246         https://bugs.webkit.org/show_bug.cgi?id=112286
4247
4248         Reviewed by James Robinson.
4249
4250         Add tests for multiplication by zero and max to ensure we don't
4251         mess them up should we ever make changes to Checked<> in future.
4252
4253         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4254         (TestWebKitAPI):
4255
4256 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4257
4258         [Qt] Unreviewed prospective Windows build fix
4259
4260         Do the usual thing, include the moc generated code in the .cpp file instead
4261         of compiling it standalone, to ensure that config.h is included, too, and
4262         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
4263
4264         * DumpRenderTree/qt/EventSenderQt.cpp:
4265
4266 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4267
4268         [Qt] Port TestRunner::findString to shared interface
4269         https://bugs.webkit.org/show_bug.cgi?id=112147
4270
4271         Reviewed by Jocelyn Turcotte.
4272
4273         This patch also removes DumpRenderTree and some other helper classes from
4274         the WebCore namespace, to which they do not really belong.
4275
4276         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4277         (main):
4278         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4279         (DumpRenderTree::DumpRenderTree):
4280         (DumpRenderTree::~DumpRenderTree):
4281         (DumpRenderTree::instance):
4282         (DumpRenderTree::setShouldTimeout):
4283         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4284         (DumpRenderTree):
4285         * DumpRenderTree/qt/EventSenderQt.cpp:
4286         (EventSender::contextClick):
4287         (EventSender::sendEvent):
4288         (EventSender::postEvent):
4289         * DumpRenderTree/qt/EventSenderQt.h:
4290         (EventSender::isGraphicsBased):
4291         * DumpRenderTree/qt/TestRunnerQt.cpp:
4292         (TestRunnerQt::TestRunnerQt):
4293         (TestRunner::findString):
4294         (TestRunnerQt::setMockDeviceOrientation):
4295         (TestRunnerQt::setGeolocationPermission):
4296         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):