Remove ChromiumPublicApi pattern, and cc/message rules for it.
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-04  Kent Tamura  <tkent@chromium.org>
2
3         Remove ChromiumPublicApi pattern, and cc/message rules for it.
4
5         * Scripts/webkitpy/common/config/watchlist:
6
7 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
8
9         Temporarily disable the Python unittests broken by the commit queue not running layout tests
10         https://bugs.webkit.org/show_bug.cgi?id=113997
11
12         Reviewed by Ryosuke Niwa.
13
14         Disable the tests until Ryosuke gets the time and hardware to have
15         a testing commit-queue.
16
17         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
18         (CommitQueueTaskTest):
19         * Scripts/webkitpy/tool/commands/queues_unittest.py:
20         (CommitQueueTest):
21
22 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
23
24         Remove Chromium builders from build.webkit.org
25         https://bugs.webkit.org/show_bug.cgi?id=113990
26
27         Reviewed by Benjamin Poulain.
28
29         Land the part to disable triggering of Chromium builders first so that we may start
30         deleting more Chromium code that breaks the update step.
31
32         * BuildSlaveSupport/build.webkit.org-config/config.json:
33
34 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
35
36         Remove Chromium's DumpRenderTree
37         https://bugs.webkit.org/show_bug.cgi?id=113989
38
39         Reviewed by Kent Tamura.
40
41         On second thought, let's not go to Camelot. It is a silly place.
42
43         * DumpRenderTree/mac/DumpRenderTree.mm:
44         (resetDefaultsToConsistentValues):
45
46 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
47
48         Nixed the defunct chromium folder from DumpRenderTree
49         https://bugs.webkit.org/show_bug.cgi?id=113993
50
51         Reviewed by Ryosuke Niwa.
52
53         * DumpRenderTree/chromium: Removed.
54         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
55         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
56         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
57         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
58         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
59         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
60         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
61         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
62         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
63         * DumpRenderTree/chromium/MockPlatform.h: Removed.
64         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
65         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
66         * DumpRenderTree/chromium/Task.cpp: Removed.
67         * DumpRenderTree/chromium/Task.h: Removed.
68         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
69         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
70         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
71         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
72         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
73         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
74         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
75         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
76         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
77         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
78         * DumpRenderTree/chromium/TestRunner: Removed.
79         * DumpRenderTree/chromium/TestRunner/public: Removed.
80         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
81         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
82         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
83         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
84         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
85         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
86         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
87         * DumpRenderTree/chromium/TestRunner/src: Removed.
88         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
89         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
90         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
91         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
92         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
93         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
94         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
95         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
96         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
97         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
98         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
99         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
100         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
101         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
102         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
103         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
104         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
105         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
106         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
107         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
108         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
109         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
110         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
111         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
112         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
113         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
114         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
115         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
116         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
117         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
118         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
119         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
120         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
121         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
122         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
123         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
124         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
125         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
126         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
127         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
128         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
129         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
130         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
131         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
132         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
133         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
134         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
135         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
136         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
137         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
138         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
139         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
140         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
141         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
142         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
143         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
144         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
145         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
146         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
147         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
148         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
149         * DumpRenderTree/chromium/TestShell.cpp: Removed.
150         * DumpRenderTree/chromium/TestShell.h: Removed.
151         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
152         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
153         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
154         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
155         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
156         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
157         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
158         * DumpRenderTree/chromium/WebViewHost.h: Removed.
159         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
160         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
161         * DumpRenderTree/chromium/config.h: Removed.
162         * DumpRenderTree/chromium/fonts.conf: Removed.
163
164 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
165
166         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
167
168         Rubber stamped by Benjamin Poulain.
169
170         * RebaselineQueueServer: Removed.
171         * RebaselineQueueServer/app.yaml: Removed.
172         * RebaselineQueueServer/handlers: Removed.
173         * RebaselineQueueServer/handlers/__init__.py: Removed.
174         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
175         * RebaselineQueueServer/handlers/pages.py: Removed.
176         * RebaselineQueueServer/index.yaml: Removed.
177         * RebaselineQueueServer/main.py: Removed.
178         * RebaselineQueueServer/model: Removed.
179         * RebaselineQueueServer/model/__init__.py: Removed.
180         * RebaselineQueueServer/model/queueentry.py: Removed.
181         * RebaselineQueueServer/static: Removed.
182         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
183         * RebaselineQueueServer/static/styles.css: Removed.
184         * RebaselineQueueServer/templates: Removed.
185         * RebaselineQueueServer/templates/builder-picker.html: Removed.
186         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
187         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
188         * RebaselineQueueServer/templates/home.html: Removed.
189
190 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
191
192         Fix setup-commit-queue and temporarily disable testing on commit-queue
193         https://bugs.webkit.org/show_bug.cgi?id=113979
194
195         Reviewed by Benjamin Poulain.
196
197         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
198         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
199
200         * EWSTools/setup-commit-queue.sh:
201         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
202         (CommitQueueTask.run):
203
204 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
205
206         temporarily make flakiness dashboard work again webkit.org bots
207         https://bugs.webkit.org/show_bug.cgi?id=113972
208
209         Reviewed by Ojan Vafai.
210
211         This patch disables the chromium.org layout test bots TestExpectations
212         parsing temporarily until we can work out the right way to split into
213         two instances for webkit.org and chromium.org and figure out which
214         code to delete where :).
215
216         * TestResultServer/static-dashboards/flakiness_dashboard.js:
217
218 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
219
220         Fix webkitpy tests after r147678.
221
222         * Scripts/webkitpy/tool/commands/queues_unittest.py:
223         (CommitQueueTest.test_commit_queue):
224         (test_manual_reject_during_processing):
225
226 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
227
228         The commit queue should use Mac MountainLion port
229         https://bugs.webkit.org/show_bug.cgi?id=113971
230
231         Reviewed by Lucas Forschler.
232
233         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
234         * Scripts/webkitpy/tool/commands/queues.py:
235         (CommitQueue):
236
237 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
238
239         turn off running tests on chromium linux EWS bots
240         https://bugs.webkit.org/show_bug.cgi?id=113959
241
242         Reviewed by Geoffrey Garen.
243
244         Now that the Chromium port is no longer being maintained
245         there's little point in running the tests. Soon we should
246         just shut this bot off altogether.
247
248         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
249         (ChromiumLinuxEWS):
250
251 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
252
253         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
254
255         * Scripts/webkitpy/common/config/watchlist:
256
257 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
258
259         Indentation fix to get webkit-patch working again after r147625
260
261         Unreviewed.
262
263         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
264         (MacEWS):
265         (MacWK2EWS):
266
267 2013-04-04  Lucas Forschler  <lforschler@apple.com>
268
269         Turn tests back on for Mac WK1/WK2 EWS.
270         
271         Unreviewed.
272         
273         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
274         (MacEWS):
275         (MacWK2EWS):
276
277 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
278
279         [GTK][WK2] MiniBrowser custom URI scheme support
280         https://bugs.webkit.org/show_bug.cgi?id=112419
281
282         Reviewed by Carlos Garcia Campos.
283
284         Add support for about URIs in MiniBrowser. An example about page is show
285         with URI "about:minibrowser", the rest of the cases it will show a
286         proper message explaining that the about page didn't exist.
287
288         Internally it uses "minibrowser-about" prefix instead of "about", but
289         from the user point of view it works with "about" prefix.
290
291         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
292         (getInternalURI): Method to convert URIs from "about" prefix to
293         "minibrowser-about".
294         (getExternalURI): Opposite method.
295         (webViewURIChanged): Use "about" prefix to show the URI to users.
296         (webViewEnterFullScreen): Ditto.
297         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
298         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
299         (aboutURISchemeRequestCallback): Callback to manage about calls.
300         (main): Register the URI scheme to manage about URIs.
301
302 2013-04-03  Roger Fong  <roger_fong@apple.com>
303
304         Re-enable WinEWS tests.
305
306         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
307         (WinEWS):
308
309 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
310
311         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
312         https://bugs.webkit.org/show_bug.cgi?id=113883
313
314         Reviewed by Martin Robinson.
315
316         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
317         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
318         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
319
320 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
321
322         [GTK] Include Pango in jhbuild-optional.modules
323         https://bugs.webkit.org/show_bug.cgi?id=113878
324
325         Reviewed by Martin Robinson.
326
327         Since r147547 Pango 1.32.0 is required. Including the module in the
328         JHBuild optional moduleset.
329
330         * gtk/jhbuild-optional.modules: Add Pango module.
331
332 2013-04-03  Zeno Albisser  <zeno@webkit.org>
333
334         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
335         https://bugs.webkit.org/show_bug.cgi?id=113864
336
337         Moving setDefersLoading from TestRunnerQt to TestRunner
338         requires access to the non-Qt TestRunner.
339         As long as we instantiate both TestRunner and TestRunnerQt,
340         we need a separate getter for the non-Qt TestRunner instance.
341
342         Reviewed by Simon Hausmann.
343
344         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
345         (WebPage::resetSettings):
346         * DumpRenderTree/qt/DumpRenderTreeQt.h:
347         (DumpRenderTree::jscTestRunner):
348         * DumpRenderTree/qt/TestRunnerQt.cpp:
349         (TestRunner::setDefersLoading):
350             Moving setDefersLoading from TestRunnerQt
351             to TestRunner.
352         * DumpRenderTree/qt/TestRunnerQt.h:
353         (TestRunnerQt):
354
355 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
356
357         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
358         https://bugs.webkit.org/show_bug.cgi?id=104779
359
360         Reviewed by Carlos Garcia Campos.
361
362         * Scripts/run-gtk-tests:
363         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
364         passing in current trunk.
365
366 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
367
368         Fix HAVE(QTTESTSUPPORT) logic
369
370         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
371         resulting in HAVE(QTTESTSUPPORT) never being true.
372         Move that logic down in sanitizeFeatures.
373
374         Rubber-stamped by Tor Arne Vestbø.
375
376         * qmake/mkspecs/features/features.prf:
377
378 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
379
380         [GTK] Bump required versions of some dependencies
381         https://bugs.webkit.org/show_bug.cgi?id=113282
382
383         Reviewed by Martin Robinson.
384
385         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
386
387 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
388
389         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
390         https://bugs.webkit.org/show_bug.cgi?id=113809
391
392         Reviewed by Philippe Normand.
393
394         Newer Linux kernels have removed some deprecated macros from v4l2
395         headers, causing gst-plugins-good's build to break. We don't need it
396         right now, so just disable it.
397
398         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
399
400 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
401
402         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
403         https://bugs.webkit.org/show_bug.cgi?id=113535
404
405         Reviewed by Simon Hausmann.
406
407         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
408
409         * qmake/mkspecs/features/features.prf:
410
411 2013-04-03  Zeno Albisser  <zeno@webkit.org>
412
413         [Qt] Move logic of simple forwarding functions to TestRunner.
414         https://bugs.webkit.org/show_bug.cgi?id=113863
415
416         Reviewed by Simon Hausmann.
417
418         * DumpRenderTree/qt/TestRunnerQt.cpp:
419         (TestRunner::setTextDirection):
420         (TestRunner::goBack):
421         (TestRunner::evaluateScriptInIsolatedWorld):
422         (TestRunner::addUserStyleSheet):
423         * DumpRenderTree/qt/TestRunnerQt.h:
424         (TestRunnerQt):
425
426 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
427
428         [Qt] Disable media support using QuickTime if deployment target != SDK
429
430         We link to a single libWebKitSystemInterface static lib, so unless the
431         deployment target matches the SDK let's not pretend like we'll be able
432         to run on anything lower than the SDK version.
433
434         Reviewed by Simon Hausmann.
435
436         * qmake/mkspecs/features/features.prf:
437
438 2013-04-02  James Craig  <james@cookiecrook.com>
439
440         AXRoleDescripton for DL is "list"; should be "description list"
441         https://bugs.webkit.org/show_bug.cgi?id=111665
442
443         Reviewed by Chris Fleizach.
444
445         Defining the role and description strings.
446
447         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
448
449 2013-04-02  Roger Fong  <roger_fong@apple.com>
450
451         Unreviewed. Disable running tests on Win EWS queue.
452
453         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
454         (WinEWS):
455
456 2013-04-02  Lucas Forschler  <lforschler@apple.com>
457
458         Disable running tests on the MAC WK2 EWS queue.
459         
460         Unreviewed.
461         
462         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
463         (MacWK2EWS):
464
465 2013-04-02  Julie Parent  <jparent@chromium.org>
466
467         Dashboard refactor: Move dashboard specific history related features to History.
468         https://bugs.webkit.org/show_bug.cgi?id=113717
469
470         Reviewed by Ojan Vafai.
471         
472         Each dashboard now creates its own History object, with a custom
473         configuration. This changes from just overriding global functions
474         to passing in callbacks for generatePage, handleValidHashParameter,
475         and handleQueryParameterChange. Same with passing in defaultStateValues
476         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
477         variables.
478         
479         All functions related to these features are now (mostly) private
480         function on History. 
481         
482         Loader no longer needs a loadingComplete callback, since it can just
483         initialize the history object itself.
484
485         * TestResultServer/static-dashboards/aggregate_results.js:
486         (handleValidHashParameter):
487         * TestResultServer/static-dashboards/dashboard_base.js:
488         * TestResultServer/static-dashboards/flakiness_dashboard.js:
489         (generatePage):
490         (.switch.return):
491         (handleQueryParameterChange):
492         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
493         (resetGlobals):
494         * TestResultServer/static-dashboards/history.js:
495         (.):
496         * TestResultServer/static-dashboards/loader.js:
497         (.):
498         * TestResultServer/static-dashboards/loader_unittests.js:
499         * TestResultServer/static-dashboards/timeline_explorer.js:
500         (generatePage):
501         (initCurrentBuilderTestResults):
502         * TestResultServer/static-dashboards/treemap.js:
503         (generatePage):
504         (.switch.return):
505         (handleQueryParameterChange):
506
507 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
508
509         Unreviewed, rolling out r147401.
510         http://trac.webkit.org/changeset/147401
511         https://bugs.webkit.org/show_bug.cgi?id=113767
512
513         The patch makes it extremely hard to set up the dependencies
514         properly on the GTK builders (Requested by zdobersek on
515         #webkit).
516
517         * gtk/jhbuild.modules:
518
519 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
520
521         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
522         https://bugs.webkit.org/show_bug.cgi?id=113382
523
524         Reviewed by Gyuyoung Kim.
525
526         Do not show the empty tooltip box if the text is null.
527
528         * MiniBrowser/efl/main.c:
529         (popup_menu_populate):
530
531 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
532
533         [GTK] Bump required versions of some dependencies
534         https://bugs.webkit.org/show_bug.cgi?id=113282
535
536         Reviewed by Martin Robinson.
537
538         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
539
540 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
541
542         Unreviewed, rolling out r147319.
543         http://trac.webkit.org/changeset/147319
544         https://bugs.webkit.org/show_bug.cgi?id=113707
545
546         The unit test is still failing on the buildbot (Requested by
547         zdobersek on #webkit).
548
549         * Scripts/run-gtk-tests:
550         (TestRunner):
551
552 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
553
554         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
555         https://bugs.webkit.org/show_bug.cgi?id=104779
556
557         Reviewed by Carlos Garcia Campos.
558
559         * Scripts/run-gtk-tests:
560         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
561         passing in current trunk.
562
563 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
564
565         Unreviewed, rolling out r147289.
566         http://trac.webkit.org/changeset/147289
567         https://bugs.webkit.org/show_bug.cgi?id=113678
568
569         broke Win7 (dbg) build (Requested by shinyak|gardener on
570         #webkit).
571
572         * DumpRenderTree/DumpRenderTree.gypi:
573         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
574         (WebTestRunner):
575         (WebUserMediaClientMock):
576         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
577         (WebTestRunner::WebUserMediaClientMock::taskList):
578         * Scripts/webkitpy/style/checkers/cpp.py:
579         (check_function_definition):
580
581 2013-03-31  Adam Barth  <abarth@webkit.org>
582
583         configure-svn-config.sh fails
584         https://codereview.chromium.org/13392007/
585
586         Reviewed by Eric Seidel.
587
588         This script was trying to use "svn checkout" to dowload a file from
589         svn.webkit.org, but "svn checkout" only works with directories.
590         Instead, we should use "svn export".
591
592         * EWSTools/configure-svn-config.sh:
593
594 2013-03-31  Wei Jia  <wjia@chromium.org>
595
596         Allow WebUserMediaClientMock to be used by client
597         https://bugs.webkit.org/show_bug.cgi?id=113633
598
599         Reviewed by Adam Barth.
600
601         Export WebUserMediaClientMock.
602         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
603
604         * DumpRenderTree/DumpRenderTree.gypi:
605         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
606         (WebUserMediaClientMock):
607         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
608         * Scripts/webkitpy/style/checkers/cpp.py:
609         (check_function_definition):
610
611 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
612
613         Expose FeatureObserver data to WebKit clients
614         https://bugs.webkit.org/show_bug.cgi?id=113613
615
616         Reviewed by Sam Weinig.
617
618         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
619         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
620
621 2013-03-29  Greg Hughes  <ghughes@apple.com>
622
623         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
624         https://bugs.webkit.org/show_bug.cgi?id=112276
625
626         Reviewed by Chris Fleizach.
627
628         Added support to test accessibility search predicates with multiple keys.  
629
630         * DumpRenderTree/AccessibilityUIElement.cpp:
631         (uiElementForSearchPredicateCallback):
632         * DumpRenderTree/AccessibilityUIElement.h:
633         (AccessibilityUIElement):
634         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
635         (AccessibilityUIElement::uiElementForSearchPredicate):
636         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
637         (AccessibilityUIElement::uiElementForSearchPredicate):
638         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
639         (AccessibilityUIElement::uiElementForSearchPredicate):
640         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
641         (AccessibilityUIElement::uiElementForSearchPredicate):
642         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
643         (AccessibilityUIElement::uiElementForSearchPredicate):
644         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
645         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
646         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
647         (AccessibilityUIElement):
648         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
649         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
650         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
651         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
652         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
653
654 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
655
656         Fix a typo in r147147 to fix Mac EWS.
657
658         * Scripts/webkitpy/tool/commands/queues.py:
659         (PatchProcessingQueue._new_port_name_from_old):
660
661 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
662
663         [EFL] Build break with latest EFL libraries after r146265
664         https://bugs.webkit.org/show_bug.cgi?id=113558
665
666         Unreviewed build fix.
667
668         * TestWebKitAPI/PlatformWebView.h:
669         * WebKitTestRunner/PlatformWebView.h:
670
671 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
672
673         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
674
675         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
676         in libgcrypt build.
677
678 2013-03-28  Lucas Forschler  <lforschler@apple.com>
679
680         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
681
682         Unreviewed.
683
684         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
685         (MacEWS):
686
687 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
688
689         Use the right OS name on Mac EWS instead of mac-future.
690
691         Rubber-stamped by Dirk Pranke.
692
693         * Scripts/webkitpy/tool/commands/queues.py:
694         (PatchProcessingQueue._new_port_name_from_old):
695         (PatchProcessingQueue.begin_work_queue):
696         (PatchProcessingQueue._upload_results_archive_for_patch):
697
698 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
699
700         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
701         https://bugs.webkit.org/show_bug.cgi?id=112546
702
703         Reviewed by Martin Robinson.
704
705         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
706         moved back to Source/WebCore/platform. Fix an indentation issue as well.
707
708 2013-03-28  Ming Xie  <mxie@blackberry.com>
709
710         [BlackBerry] Committer Email Updates
711         https://bugs.webkit.org/show_bug.cgi?id=113435
712
713         Reviewed by Rob Buis.
714
715         Add the @blackberry.com email address for all our BlackBerry
716         WebKit committers. This is the first step for our email address
717         migration.
718
719         * Scripts/webkitpy/common/config/committers.py:
720
721 2013-03-28  Philippe Normand  <pnormand@igalia.com>
722
723         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
724         https://bugs.webkit.org/show_bug.cgi?id=113508
725
726         Reviewed by Martin Robinson.
727
728         Prevent the GStreamer plugin scanner to load system-wide
729         plugins. Only the ones built in JHBuild should be loaded and used
730         at runtime.
731
732         * efl/jhbuildrc:
733         * gtk/jhbuildrc:
734
735 2013-03-27  Philippe Normand  <pnormand@igalia.com>
736
737         [GTK] run-launcher --gtk -2 fails on a WK2-only build
738         https://bugs.webkit.org/show_bug.cgi?id=113386
739
740         Reviewed by Carlos Garcia Campos.
741
742         * Scripts/webkitdirs.pm:
743         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
744         version to 3.0. Reflect this change so the builtDylibPathForName
745         function doesn't fail to report the library as found.
746
747 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
748
749         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
750         https://bugs.webkit.org/show_bug.cgi?id=113484
751
752         Unreviewed build fix.
753
754         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
755
756         * TestWebKitAPI/CMakeLists.txt:
757         * WebKitTestRunner/CMakeLists.txt:
758
759 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
760
761         Revision for the internal jhbuild is too old
762         https://bugs.webkit.org/show_bug.cgi?id=113324
763
764         Reviewed by Martin Robinson.
765
766         Update the minimum required version to a point where jhbuild won't
767         fail installing packages when trying to remove a symlink to a directory.
768
769         * jhbuild/jhbuild-wrapper: Updated revision.
770
771 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
772
773         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
774         https://bugs.webkit.org/show_bug.cgi?id=113203
775
776         Reviewed by Philippe Normand.
777
778         We build our libsoup without GNOME support. gst-plugins-good does separate
779         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
780         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
781         build failures as the headers of those diverge. We do not use souphttpsrc, so
782         disable it when building gst-plugins-good.
783
784         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
785
786 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
787
788         Build fix after r146852. Please another reference to the Lion leaks builder.
789
790         * BuildSlaveSupport/build.webkit.org-config/config.json:
791
792 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
793
794         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
795         https://bugs.webkit.org/show_bug.cgi?id=113421
796
797         Reviewed by Dirk Pranke.
798
799         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
800         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
801         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
802         in the GTK-specific TestExpectations files.
803
804         To avoid this only enable the warnings only when not using WKTR.
805
806         * Scripts/webkitpy/layout_tests/port/gtk.py:
807         (GtkPort.warn_if_bug_missing_in_test_expectations):
808
809 2013-03-27  Antti Koivisto  <antti@apple.com>
810
811         Fix Zalan's email.
812
813         * Scripts/webkitpy/common/config/committers.py:
814
815 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
816
817         master.cfg cleanup
818         https://bugs.webkit.org/show_bug.cgi?id=113195
819
820         Reviewed by Ryosuke Niwa.
821
822         * BuildSlaveSupport/build.webkit.org-config/config.json:
823         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
824
825 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
826
827         master.cfg fine-tuning for Qt Mountain Lion Release bot
828         https://bugs.webkit.org/show_bug.cgi?id=113191
829
830         Reviewed by Ryosuke Niwa.
831
832         * BuildSlaveSupport/build.webkit.org-config/config.json:
833           - Rename the slave due to its location change.
834           - Update the platform of the slave.
835         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
836         (RunQtAPITests): Enable running WK2 API tests on Qt.
837         (RunQtAPITests.start):
838         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
839         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
840
841 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
842
843         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
844         https://bugs.webkit.org/show_bug.cgi?id=113403
845
846         Reviewed by Kenneth Rohde Christiansen.
847
848         As of Evas 1.7.5, when Wayland is detected on the system, support for
849         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
850         The code, however, seems to depend on a few other flags which must be
851         explicitly enabled.
852
853         If those additional GL-related options are passed, we end up
854         having issues on the WebKit side, so disable Wayland support for
855         now.
856
857         * efl/jhbuild.modules:
858
859 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
860
861         Unreviewed, rolling out r146864.
862         http://trac.webkit.org/changeset/146864
863         https://bugs.webkit.org/show_bug.cgi?id=113391
864
865         causes crashes on Wk2 EFL release bot (Requested by drott on
866         #webkit).
867
868         * Scripts/webkitperl/FeatureList.pm:
869
870 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
871
872         [jhbuild] Correctly specify an alternate number of make jobs.
873         https://bugs.webkit.org/show_bug.cgi?id=113396
874
875         Reviewed by Philippe Normand.
876
877         So far, we were using the `MAKEFLAGS' environment variable to pass the
878         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
879         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
880
881         We now behave more closely to the rest of the WebKit tools by first
882         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
883         not set, just letting jhbuild itself figure out how many jobs to use.
884
885         * efl/jhbuildrc:
886         * gtk/jhbuildrc:
887
888 2013-03-27  Zeno Albisser  <zeno@webkit.org>
889
890         [Qt] Remove Qt specific WorkQueueItem definitions.
891         https://bugs.webkit.org/show_bug.cgi?id=112891
892
893         This patch is preparation work for removing
894         WorkQueue related code from TestRunnerQt and
895         replacing it with generic TestRunner code.
896
897         Reviewed by Benjamin Poulain.
898
899         * DumpRenderTree/qt/TestRunnerQt.cpp:
900         (TestRunnerQt::queueBackNavigation):
901         (TestRunnerQt::queueForwardNavigation):
902         (TestRunnerQt::queueLoadHTMLString):
903         (TestRunnerQt::queueReload):
904         (TestRunnerQt::queueLoadingScript):
905         (TestRunnerQt::queueNonLoadingScript):
906         (TestRunner::queueLoad):
907         * DumpRenderTree/qt/TestRunnerQt.h:
908         (TestRunnerQt):
909         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
910         (LoadItem::invoke):
911         (LoadHTMLStringItem::invoke):
912         (LoadAlternateHTMLStringItem::invoke):
913         (ReloadItem::invoke):
914         (ScriptItem::invoke):
915         (BackForwardItem::invoke):
916         * DumpRenderTree/qt/WorkQueueItemQt.h:
917         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
918         (LoadAlternateHTMLStringItem):
919
920 2013-03-26  Julie Parent  <jparent@chromium.org>
921
922         Flakiness dashboard: simplify logic around which tests to show.
923         https://bugs.webkit.org/show_bug.cgi?id=113250
924
925         Reviewed by Ojan Vafai.
926         
927         The different filters for showing results are only used for layout
928         tests, otherwise, we show everything.
929         
930         Change the defaults to false (what layout tests used), and only
931         look at the values when viewing layout tests.
932
933         * TestResultServer/static-dashboards/flakiness_dashboard.js:
934         (htmlForTestsWithExpectationsButNoFailures):
935         (shouldHideTest):
936
937 2013-03-26  Isaac Levy  <ilevy@google.com>
938
939         Update bots on test-results.appspot
940         https://bugs.webkit.org/show_bug.cgi?id=113333
941
942         Reviewed by Ojan Vafai.
943
944         * TestResultServer/static-dashboards/builders.jsonp:
945
946 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
947
948         Unreviewed GTK gardening.
949
950         * Scripts/run-gtk-tests:
951         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
952
953 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
954
955         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
956         https://bugs.webkit.org/show_bug.cgi?id=113287
957
958         Reviewed by Jocelyn Turcotte.
959
960         * Scripts/run-qtwebkit-tests:
961         (Options.__init__):
962
963 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
964
965         [EFL] Enable IndexedDB by default
966         https://bugs.webkit.org/show_bug.cgi?id=107248
967
968         Reviewed by Laszlo Gombos.
969
970         * Scripts/webkitperl/FeatureList.pm:
971         Enable IndexedDB by default on EFL.
972
973 2013-03-26  Alan Cutter  <alancutter@chromium.org>
974
975         Sheriffbot should explain rollout failures in a human readable form.
976         https://bugs.webkit.org/show_bug.cgi?id=107092
977
978         Reviewed by Ryosuke Niwa.
979
980         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
981
982         * Scripts/webkitpy/tool/bot/irc_command.py:
983         (Rollout._check_diff_failure):
984         (Rollout.execute):
985         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
986         (IRCCommandTest.test_rollout):
987
988 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
989
990         Unreviewed GTK gardening.
991
992         * Scripts/run-gtk-tests:
993         (TestRunner): Skipping a failing unit test after r146518.
994
995 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
996
997         Remove Lion leaks builder
998         https://bugs.webkit.org/show_bug.cgi?id=113252
999
1000         Reviewed by Andreas Kling.
1001
1002         Removed.
1003
1004         * BuildSlaveSupport/build.webkit.org-config/config.json:
1005
1006 2013-03-25  Kent Tamura  <tkent@chromium.org>
1007
1008         Rename ENABLE_INPUT_TYPE_DATETIME
1009         https://bugs.webkit.org/show_bug.cgi?id=113254
1010
1011         Reviewed by Kentaro Hara.
1012
1013         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1014         Actually I'd like to remove the code, but we shouldn't remove it yet
1015         because we shipped products with it on some platforms.
1016
1017         * Scripts/webkitperl/FeatureList.pm:
1018         * qmake/mkspecs/features/features.pri:
1019
1020 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1021
1022         Remove one more line that was intended to be removed in r146657.
1023
1024         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1025         (summarize_results):
1026
1027 2013-03-25  Roger Fong  <roger_fong@apple.com>
1028
1029         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1030         Re-enable WinEWS tests.
1031
1032         * Scripts/webkitpy/common/config/ports.py:
1033         (WinPort.run_bindings_tests_command):
1034         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1035         (WinEWS):
1036
1037 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1038
1039         Unreviewed, rolling out r146793.
1040         http://trac.webkit.org/changeset/146793
1041         https://bugs.webkit.org/show_bug.cgi?id=113248
1042
1043         Fix did not work (Requested by rfong on #webkit).
1044
1045         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1046         (WinEWS):
1047
1048 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1049
1050         REGRESSION(r146657): Test failures reported incorrectly
1051         https://bugs.webkit.org/show_bug.cgi?id=113223
1052
1053         Reviewed by Dirk Pranke.
1054
1055         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1056
1057         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1058         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1059
1060         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1061         (Manager.run):
1062
1063         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1064         (RunDetails.__init__):
1065         (summarize_results): Remove the line I intended to remove in r146657.
1066
1067         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1068         (logging_run): Return details instead of the exit code.
1069         (run_and_capture): Ditto.
1070
1071         (RunTest.test_full_results_html):
1072         (RunTest.test_hung_thread):
1073         (RunTest.test_no_tests_found):
1074         (RunTest.test_no_tests_found_2):
1075         (RunTest.test_repeat_each_iterations_num_tests):
1076         (RunTest.test_run_singly_actually_runs_tests):
1077         (RunTest.test_test_list):
1078         (RunTest.test_missing_and_unexpected_results):
1079         (RunTest.test_pixel_test_directories):
1080         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1081         (RunTest.test_crash_with_stderr):
1082         (RunTest.test_no_image_failure_with_image_diff):
1083         (RunTest.test_crash_log):
1084         (RunTest.test_exit_after_n_failures_upload):
1085         (RunTest.test_results_directory_absolute):
1086         (RunTest.test_results_directory_relative):
1087         (RunTest.test_retrying_and_flaky_tests):
1088         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1089         (RunTest.test_retrying_uses_retries_directory):
1090         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1091         (RunTest.test_output_diffs):
1092         (EndToEndTest.test_reftest_with_two_notrefs):
1093         (RebaselineTest.test_reset_results):
1094         (RebaselineTest.test_missing_results):
1095         (RebaselineTest.test_new_baseline):
1096
1097         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1098         (BuildBotPrinter.print_results):
1099         (BuildBotPrinter.print_unexpected_results):
1100         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1101         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1102
1103 2013-03-25  Julie Parent  <jparent@chromium.org>
1104
1105         Dashboard refactor: Move cross dashboard history related code into history.js.
1106         https://bugs.webkit.org/show_bug.cgi?id=113104
1107
1108         Reviewed by Ojan Vafai.
1109
1110         All functions relating to cross dashboard behavior move from being
1111         globals to methods on the history.History object. Names stay the same,
1112         except many are made private, ones that should have been constants now
1113         are, and the long standing TODO to change "currentState" to 
1114         dashboardSpecificState is done.
1115         
1116         We now create a global history object in dashboard_base, as an 
1117         intermediate measure.  Once the dashboard specific code is
1118         added to history, each DB will need to create its own, and this
1119         global will be eliminated.
1120         
1121         * TestResultServer/static-dashboards/aggregate_results.js:
1122         (handleValidHashParameter):
1123         (htmlForBuilder):
1124         (rawValuesHTML):
1125         * TestResultServer/static-dashboards/dashboard_base.js:
1126         (parseDashboardSpecificParameters):
1127         (defaultValue):
1128         (currentBuilderGroupCategory):
1129         (currentBuilderGroupName):
1130         (handleLocationChange):
1131         (expectationsMap):
1132         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1133         (generatePage):
1134         (.switch.return):
1135         (platformAndBuildType):
1136         (individualTests):
1137         (substringList):
1138         (processMissingAndExtraExpectations):
1139         (pathToFailureLog):
1140         (showPopupForBuild):
1141         (htmlForTestsWithExpectationsButNoFailures):
1142         (shouldHideTest):
1143         (isCrossBuilderView):
1144         (tableHeaders):
1145         (htmlForSingleTestRow):
1146         (htmlForTableColumnHeader):
1147         (generatePageForExpectationsUpdate):
1148         (handleUpdate):
1149         (nextUpdate):
1150         (setUpdateIndex):
1151         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1152         (.appendExpectationsItem):
1153         (loadExpectations):
1154         (.dummyNode.onload):
1155         (loadExpectationsLayoutTests):
1156         (appendExpectations):
1157         (htmlForNavBar):
1158         (checkBoxToToggleState):
1159         (linkHTMLToToggleState):
1160         (generatePageForBuilder):
1161         (isInvalidKeyForCrossBuilderView):
1162         (handleQueryParameterChange):
1163         (showLegend):
1164         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1165         (resetGlobals):
1166         (test):
1167         * TestResultServer/static-dashboards/history.js:
1168         (.):
1169         * TestResultServer/static-dashboards/history_unittests.js:
1170         * TestResultServer/static-dashboards/loader.js:
1171         (.):
1172         * TestResultServer/static-dashboards/loader_unittests.js:
1173         * TestResultServer/static-dashboards/timeline_explorer.js:
1174         (generatePage):
1175         (initCurrentBuilderTestResults):
1176         (selectBuild):
1177         (showResultsDelta):
1178         * TestResultServer/static-dashboards/treemap.js:
1179         (generatePage):
1180         (.switch.return):
1181         (handleFocus):
1182         * TestResultServer/static-dashboards/ui.js:
1183
1184 2013-03-25  Roger Fong  <roger_fong@apple.com>
1185
1186         Unreviewed. Enable WinEWS tests again.
1187
1188         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1189         (WinEWS):
1190
1191 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1192
1193         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1194         https://bugs.webkit.org/show_bug.cgi?id=112166
1195
1196         HarfBuzz 0.9.14 merged my patch for icu detection without
1197         pkg-config files, as needed by for example Ubuntu 12.04.
1198         This obsoletes our local workaround. Removed it for GTK and EFL.
1199
1200         Reviewed by Martin Robinson.
1201
1202         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1203         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1204         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1205         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1206
1207 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1208
1209         Unreviewed.  Move self from contributor to committer list.
1210
1211         * Scripts/webkitpy/common/config/committers.py:
1212
1213 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1214
1215         EWS should use a human readable port name when uploading layout test archives
1216         https://bugs.webkit.org/show_bug.cgi?id=113099
1217
1218         Reviewed by Dirk Pranke.
1219
1220         Use new port's object's name() method to report human readable port names.
1221         This will also help us resolving the bug to apply layout test results posted by EWS.
1222
1223         * Scripts/webkitpy/tool/bot/botinfo.py:
1224         (BotInfo.__init__): Take port's name.
1225         (BotInfo.summary_text):
1226
1227         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1228         (BotInfoTest.test_summary_text):
1229
1230         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1231         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1232
1233         * Scripts/webkitpy/tool/commands/queues.py:
1234         (PatchProcessingQueue.__init__): Initialize self._port.
1235         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1236         and use that for the attachment filename and the comment posted.
1237
1238         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1239         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1240         "mac-snowleopard" as expected for TestPort.
1241
1242 2013-03-22  Roger Fong  <roger_fong@apple.com>
1243
1244         Unreviewed. Turn off EWS test on Win again.
1245         The battle continues.
1246
1247         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1248         (WinEWS):
1249
1250 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1251
1252         NRWT: Enable pixel tests when retrying tests
1253         https://bugs.webkit.org/show_bug.cgi?id=112898
1254
1255         Reviewed by Dirk Pranke.
1256
1257         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1258         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1259         if we've forced pixel tests in the retry.
1260         (Manager._run_tests):
1261         (Manager._clean_up_run): Fixed the capitalizations.
1262         (Manager._force_pixel_tests_if_needed): Added.
1263
1264         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1265         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1266         'image_diff_percent' if it doesn't already exist.
1267
1268         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1269         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1270         treat this as a regular regression instead of a flakiness.
1271
1272         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1273         run had image diffs.
1274
1275         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1276         (summarized_results):
1277
1278         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1279         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1280         Also removed some dead code.
1281
1282         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1283         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1284         is set and pixel_tests_enabled is set to false.
1285         (EndToEndTest.test_reftest_with_two_notrefs):
1286
1287 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1288
1289         Make it possible to run layout tests on Retina MBP
1290         https://bugs.webkit.org/show_bug.cgi?id=93673
1291
1292         Reviewed by Ryosuke Niwa.
1293
1294         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1295         windows on 2x machines still run at 1x.
1296
1297         * DumpRenderTree/mac/DumpRenderTree.mm:
1298         (createWebViewAndOffscreenWindow):
1299         Reset the window resolution to 1x on creation.
1300         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
1301         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1302         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
1303         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1304         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
1305         (WTR::PlatformWebView::PlatformWebView):
1306         Add NSWindow details, reset the window resolution to 1x on creation.
1307
1308 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1309
1310         Leak bots shouldn't build
1311         https://bugs.webkit.org/show_bug.cgi?id=112774
1312
1313         Reviewed by Simon Fraser.
1314
1315         Since leak bots use regular debug builds, there is no need to build on these bots.
1316         Simply downloading builds will dramatically improve the cycle time of these bots.
1317
1318         * BuildSlaveSupport/build.webkit.org-config/config.json:
1319         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1320         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
1321         TestFactory instead of BuildAndTestFactory.
1322
1323 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1324
1325         [Qt] Fix the TestWebKitAPI build
1326         https://bugs.webkit.org/show_bug.cgi?id=113044
1327
1328         Reviewed by Tor Arne Vestbø.
1329
1330         The generate-forwarding-headers script would only be run
1331         after the targets in InjectedBundle.pri since the second
1332         addStrictSubdirOrderBetween call in
1333         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
1334         the derived_sources -> injected_bundle order in SUBDIRS.
1335
1336         Fix it by only moving the dependent target at the end of
1337         SUBDIRS, don't touch its dependency.
1338
1339         * qmake/mkspecs/features/functions.prf:
1340
1341 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1342
1343         [EFL][WK2] View is not focused when fullscreen mode toggled
1344         https://bugs.webkit.org/show_bug.cgi?id=113009
1345
1346         Reviewed by Laszlo Gombos.
1347
1348         Set focus on view when fullscreen mode enabled/disabled
1349         by FullScreen API.
1350
1351         * MiniBrowser/efl/main.c:
1352         (on_fullscreen_accept):
1353         (on_fullscreen_deny):
1354
1355 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1356
1357         nrwt is no longer saving retry results in the retries/ subdirectory
1358         https://bugs.webkit.org/show_bug.cgi?id=112995
1359
1360         Reviewed by Ojan Vafai.
1361
1362         I think this has been broken a long time, unfortunately. This
1363         patch should fix that.
1364
1365         In order to do so, I had to pass the directory to use from
1366         the Worker object through the SingleTestWriter to the
1367         TestResultWriter. While I was plumbing that through, I rationalized
1368         the order of the parameter arguments a bit ...
1369
1370         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1371         (Worker._run_single_test):
1372         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1373         (run_single_test):
1374         (SingleTestRunner.__init__):
1375         (SingleTestRunner._run_compare_test):
1376         (SingleTestRunner._run_rebaseline):
1377         (SingleTestRunner._run_reftest):
1378         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1379         (write_test_result):
1380         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1381         (TestResultWriterTest.test_reftest_diff_image):
1382         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1383         (RunTest.test_retrying_uses_retries_directory):
1384
1385 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
1386
1387         JSC profiler should have an at-a-glance report of the success of DFG optimization
1388         https://bugs.webkit.org/show_bug.cgi?id=112988
1389
1390         Reviewed by Geoffrey Garen.
1391
1392         * Scripts/display-profiler-output:
1393
1394 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1395
1396         [chromium] Linux ASAN WebKit canary is running out of memory
1397         https://bugs.webkit.org/show_bug.cgi?id=112978
1398
1399         Reviewed by Tony Chang.
1400
1401         Running the AddressSanitizer on a crash takes a lot of
1402         memory, so we should serialize access to it to avoid running
1403         out of memory on a machine.
1404
1405         * Scripts/webkitpy/layout_tests/port/chromium.py:
1406         (ChromiumPort._get_crash_log):
1407         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1408         (HttpLock.__init__):
1409         (HttpLock.wait_for_httpd_lock):
1410
1411 2013-03-21  Min Qin  <qinmin@chromium.org>
1412
1413         Cleanup android media layout test code
1414         https://bugs.webkit.org/show_bug.cgi?id=112944
1415
1416         Reviewed by Adam Barth.
1417
1418         Chromium change: https://codereview.chromium.org/12892010/
1419         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
1420         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
1421         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
1422         Instead, we should switch to use content shell for layout tests.
1423
1424         * DumpRenderTree/chromium/TestShell.cpp:
1425         (TestShell::resetTestController):
1426
1427 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1428
1429         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
1430         https://bugs.webkit.org/show_bug.cgi?id=112953
1431
1432         Reviewed by Tony Chang.
1433
1434         When I created the DumpRenderTree_resources target in r144863 I
1435         forgot to declare the needed dependencies on the other resource
1436         targets. Due to a quirk of ordering, this appears to have been fine
1437         w/ ninja but not w/ Xcode (which is still being used on the chromium
1438         mac valgrind bots). Declaring the dependencies fixes the build
1439         failures.
1440
1441         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1442
1443 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
1444
1445         [WinCairo] Correct assert in Empty BitmapImage Test.
1446         https://bugs.webkit.org/show_bug.cgi?id=112934
1447
1448         Reviewed by Tim Horton.
1449
1450         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1451         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
1452         to avoid ref counting assertion when leaving test scope.
1453
1454 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
1455
1456         [GTK] generate-feature-defines-files is incompatible with Python3
1457         https://bugs.webkit.org/show_bug.cgi?id=112956
1458
1459         Reviewed by Martin Robinson.
1460
1461         Make the generate-feature-defines-files compatible with Python3 by calling the items()
1462         method on the dictionary objects when iterating through said dictionaries.
1463
1464         * gtk/generate-feature-defines-files:
1465         (write_feature_defines_header):
1466         (write_flattened_feature_defines_file):
1467
1468 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1469
1470         kill-old-processes spits out error messages on Mac
1471         https://bugs.webkit.org/show_bug.cgi?id=112878
1472
1473         Reviewed by Jessie Berlin.
1474
1475         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
1476         included in the list of options grep --help shows.
1477
1478         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
1479
1480         * BuildSlaveSupport/kill-old-processes:
1481         (main):
1482
1483 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
1484
1485         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
1486         https://bugs.webkit.org/show_bug.cgi?id=112597
1487
1488         Reviewed by Xan Lopez.
1489
1490         These were introduced for the Chromium port in r105295. We need
1491         dummy implementations in order to compile the BlackBerry port.
1492
1493         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1494         (AccessibilityUIElement::scrollToMakeVisible):
1495         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1496         (AccessibilityUIElement::scrollToGlobalPoint):
1497
1498 2013-03-21  Roger Fong  <roger_fong@apple.com>
1499
1500         Re-enable WinEWS tests following r146376.
1501
1502         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1503         (WinEWS):
1504
1505 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
1506
1507         Unreviewed. Add Bem Jones-Bey to the list of contributors.
1508
1509         * Scripts/webkitpy/common/config/committers.py:
1510
1511 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1512
1513         [GTK] Missing atk in install-dependencies script
1514         https://bugs.webkit.org/show_bug.cgi?id=112272
1515
1516         Reviewed by Gustavo Noronha Silva.
1517
1518         * gtk/install-dependencies: Add missing atk dependency.
1519
1520 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1521
1522         [GTK] Missing backslash in install-dependencies script
1523         https://bugs.webkit.org/show_bug.cgi?id=112907
1524
1525         Reviewed by Philippe Normand.
1526
1527         * gtk/install-dependencies: Add missing backslash to dependencies
1528         list.
1529
1530 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1531
1532         EWS bots have stopped uploading results to bugzilla
1533         https://bugs.webkit.org/show_bug.cgi?id=101091
1534
1535         Reviewed by Adam Barth.
1536
1537         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
1538         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
1539         this relative file path resoled to a file inside a non-existent directory for "zip".
1540
1541         Fixed the bug by resolving both test results directory and zip archive paths in
1542         LayoutTestResultsReader.archive.
1543
1544         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
1545         in the future.
1546
1547         * Scripts/webkitpy/common/system/filesystem_mock.py:
1548         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
1549
1550         * Scripts/webkitpy/common/system/workspace.py:
1551         (Workspace.create_zip): Log the source path when "zip" failed.
1552
1553         * Scripts/webkitpy/common/system/workspace_mock.py:
1554         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
1555
1556         * Scripts/webkitpy/common/system/workspace_unittest.py:
1557         (WorkspaceTest.test_create_zip_exception): Test that.
1558
1559         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1560         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
1561         This is the actual bug fix.
1562
1563         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1564         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
1565
1566 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
1567
1568         [chromium] move WebThemeEngine implementations to TestRunner library
1569         https://bugs.webkit.org/show_bug.cgi?id=112751
1570
1571         Reviewed by Adam Barth.
1572
1573         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1574         * DumpRenderTree/DumpRenderTree.gypi:
1575         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1576         (WebKit):
1577         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1578         (WebTestRunner::TestInterfaces::themeEngine):
1579         (WebTestRunner):
1580         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1581         (WebKit):
1582         (TestInterfaces):
1583         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1584         (WebTestRunner::WebTestInterfaces::themeEngine):
1585         (WebTestRunner):
1586         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1587         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1588         (WebTestRunner):
1589         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1590         (WebTestRunner::WebTestThemeControlWin::box):
1591         (WebTestRunner::WebTestThemeControlWin::line):
1592         (WebTestRunner::WebTestThemeControlWin::triangle):
1593         (WebTestRunner::WebTestThemeControlWin::roundRect):
1594         (WebTestRunner::WebTestThemeControlWin::oval):
1595         (WebTestRunner::WebTestThemeControlWin::circle):
1596         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1597         (WebTestRunner::WebTestThemeControlWin::markState):
1598         (WebTestRunner::WebTestThemeControlWin::draw):
1599         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1600         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1601         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1602         (WebTestRunner):
1603         (WebTestThemeControlWin):
1604         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1605         (WebTestRunner):
1606         (WebTestThemeEngineMac):
1607         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1608         (+[FakeActiveWindow alwaysActiveWindow]):
1609         (+[FakeActiveWindow alwaysInactiveWindow]):
1610         (-[FakeActiveWindow initWithActiveControls:]):
1611         (-[FakeActiveWindow _hasActiveControls]):
1612         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1613         (WebTestRunner):
1614         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1615         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1616         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1617         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1618         (WebTestRunner):
1619         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1620         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1621         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1622         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1623         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1624         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1625         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1626         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1627         (WebTestRunner::WebTestThemeEngineWin::getSize):
1628         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1629         (WebTestRunner):
1630         (WebTestThemeEngineWin):
1631         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1632         * DumpRenderTree/chromium/TestShell.cpp:
1633         (TestShell::initialize):
1634         * DumpRenderTree/chromium/TestShell.h:
1635         (WebKit):
1636         * DumpRenderTree/chromium/TestShellMac.mm:
1637         (platformInit):
1638         * DumpRenderTree/chromium/TestShellWin.cpp:
1639         (platformInit):
1640         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1641
1642 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1643
1644         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
1645
1646         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
1647         New property sheet that does not link against CoreFoundation and
1648         CFNetwork.
1649         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1650         Use new TestWebKitAPICommonWinCairo property sheet.
1651         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1652         Ditto.
1653
1654 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1655
1656         [WinCairo] Unreviewed build fix for VS2010.
1657
1658         Had to add WinCairo-specific property sheets to deal with some
1659         library and path differences with the main Apple port.
1660
1661         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1662         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1663         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1664         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
1665         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
1666         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
1667
1668 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
1669
1670         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
1671         https://bugs.webkit.org/show_bug.cgi?id=112849
1672
1673         Reviewed by Sam Weinig.
1674
1675         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1676         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1677         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1678
1679 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1680
1681         [WinCairo] Build WebKit Tools under VS2010
1682         https://bugs.webkit.org/show_bug.cgi?id=112821
1683
1684         Reviewed by Tim Horton.
1685
1686         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1687         Add WinCairo-specific build target.
1688         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
1689         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
1690         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
1691         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
1692         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1693         Add WinCairo-specific build target.
1694         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1695         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1696         Add WinCairo-specific build target.
1697         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
1698         WinCairo-specific build target.
1699         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
1700         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
1701         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
1702         specific build target.
1703         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
1704         WinCairo-specific build target.
1705         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
1706         * win/record-memory/record-memoryDebugWinCairo.props: Added.
1707         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
1708
1709 2013-03-20  Roger Fong  <roger_fong@apple.com>
1710
1711         API test gardening AppleWin port.
1712
1713         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
1714
1715         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1716         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1717
1718 2013-03-20  Roger Fong  <roger_fong@apple.com>
1719
1720         Test fix for Win EWS bots, catch various errors and restart script if necessary.
1721
1722         * EWSTools/start-queue-win.sh:
1723
1724 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
1725
1726         Unreviewed, add myself to committers.py.
1727
1728 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1729
1730         Unreviewed. Adding another email for me.
1731
1732         * Scripts/webkitpy/common/config/committers.py:
1733
1734 2013-03-20  Justin Novosad  <junov@google.com>
1735
1736         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
1737         https://bugs.webkit.org/show_bug.cgi?id=112605
1738
1739         Reviewed by James Robinson.
1740
1741         Deleting all the code that was used for propagating and supporting
1742         the Chromium setting for disabling deferred 2d canvas rendering.
1743
1744         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1745         (main):
1746         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1747         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1748         (WebTestRunner::WebPreferences::reset):
1749         (WebTestRunner::WebPreferences::applyTo):
1750         * DumpRenderTree/chromium/TestShell.cpp:
1751         (TestShell::TestShell):
1752         (TestShell::resetWebSettings):
1753         (TestShell::runFileTest):
1754         * DumpRenderTree/chromium/TestShell.h:
1755         (TestShell):
1756
1757 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
1758
1759         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
1760         https://bugs.webkit.org/show_bug.cgi?id=112699.
1761
1762         Reviewed by Adam Barth.
1763
1764         * Scripts/webkitpy/layout_tests/port/qt.py:
1765         (QtPort._search_paths):
1766         (QtPort._port_specific_expectations_files):
1767         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1768         (QtPortTest):
1769         (QtPortTest._assert_search_path):
1770         (QtPortTest._assert_expectations_files):
1771
1772 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1773
1774         [Qt] Enable kerning by default
1775         https://bugs.webkit.org/show_bug.cgi?id=112704
1776
1777         Reviewed by Jocelyn Turcotte.
1778
1779         Disable kerning by default, since some reference test expectations
1780         expect kerning to be default off.
1781
1782         * DumpRenderTree/qt/TestRunnerQt.cpp:
1783         (TestRunnerQt::reset):
1784         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1785         (WTR::activateFonts):
1786
1787 2013-03-20  Zeno Albisser  <zeno@webkit.org>
1788
1789         [Qt] Remove empty function stubs from TestRunnerQt.
1790         https://bugs.webkit.org/show_bug.cgi?id=112799
1791
1792         We are reducing the code in TestRunnerQt step by step,
1793         in order to finally replace all of it with the generic
1794         TestRunner implementation.
1795         This patch removes several simple function stubs that
1796         currently do not implement any actual functionality.
1797
1798         Reviewed by Kenneth Rohde Christiansen.
1799
1800         * DumpRenderTree/qt/TestRunnerQt.cpp:
1801         * DumpRenderTree/qt/TestRunnerQt.h:
1802         (TestRunnerQt):
1803
1804 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1805
1806         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
1807         https://bugs.webkit.org/show_bug.cgi?id=112687
1808
1809         Reviewed by Kenneth Rohde Christiansen.
1810
1811         Hide the SearchBar by default on window creation.
1812
1813         * MiniBrowser/efl/main.c:
1814         (window_create):
1815
1816 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1817
1818         Unreviewed, rolling out r146304.
1819         http://trac.webkit.org/changeset/146304
1820         https://bugs.webkit.org/show_bug.cgi?id=112788
1821
1822         to many expectations to update (Requested by antonm on
1823         #webkit).
1824
1825         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1826         * DumpRenderTree/DumpRenderTree.gypi:
1827         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1828         (WebKit):
1829         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1830         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1831         (TestInterfaces):
1832         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1833         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1834         * DumpRenderTree/chromium/TestShell.cpp:
1835         (TestShell::initialize):
1836         * DumpRenderTree/chromium/TestShell.h:
1837         (WebKit):
1838         * DumpRenderTree/chromium/TestShellMac.mm:
1839         (platformInit):
1840         * DumpRenderTree/chromium/TestShellWin.cpp:
1841         (platformInit):
1842         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1843         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1844         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1845         (WebThemeControlDRTWin::box):
1846         (WebThemeControlDRTWin::line):
1847         (WebThemeControlDRTWin::triangle):
1848         (WebThemeControlDRTWin::roundRect):
1849         (WebThemeControlDRTWin::oval):
1850         (WebThemeControlDRTWin::circle):
1851         (WebThemeControlDRTWin::nestedBoxes):
1852         (WebThemeControlDRTWin::markState):
1853         (WebThemeControlDRTWin::draw):
1854         (WebThemeControlDRTWin::drawTextField):
1855         (WebThemeControlDRTWin::drawProgressBar):
1856         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1857         (WebThemeControlDRTWin):
1858         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1859         (WebThemeEngineDRTMac):
1860         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1861         (+[FakeActiveWindow alwaysActiveWindow]):
1862         (+[FakeActiveWindow alwaysInactiveWindow]):
1863         (-[FakeActiveWindow initWithActiveControls:]):
1864         (-[FakeActiveWindow _hasActiveControls]):
1865         (WebThemeEngineDRTMac::paintScrollbarThumb):
1866         (stateToHIEnableState):
1867         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1868         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1869         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
1870         (webRectToSkIRect):
1871         (drawControl):
1872         (drawTextField):
1873         (drawProgressBar):
1874         (WebThemeEngineDRTWin::paintButton):
1875         (WebThemeEngineDRTWin::paintMenuList):
1876         (WebThemeEngineDRTWin::paintScrollbarArrow):
1877         (WebThemeEngineDRTWin::paintScrollbarThumb):
1878         (WebThemeEngineDRTWin::paintScrollbarTrack):
1879         (WebThemeEngineDRTWin::paintSpinButton):
1880         (WebThemeEngineDRTWin::paintTextField):
1881         (WebThemeEngineDRTWin::paintTrackbar):
1882         (WebThemeEngineDRTWin::paintProgressBar):
1883         (WebThemeEngineDRTWin::getSize):
1884         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
1885         (WebThemeEngineDRTWin):
1886         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1887
1888 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1889
1890         [Qt] Support -webkit-font-smoothing
1891         https://bugs.webkit.org/show_bug.cgi?id=106009
1892
1893         Reviewed by Jocelyn Turcotte.
1894
1895         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
1896
1897         * DumpRenderTree/qt/TestRunnerQt.cpp:
1898         (TestRunnerQt::reset):
1899
1900 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
1901
1902         [GTK] accessibility/aria-scrollbar-role.html is failing
1903         https://bugs.webkit.org/show_bug.cgi?id=98358
1904
1905         Reviewed by Martin Robinson.
1906
1907         Adds support for checking accessibility object's orientation.
1908         Orientation is checked by retrieving proper state of accessibility object.
1909
1910         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1911         (checkElementState):
1912         (AccessibilityUIElement::orientation):
1913         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1914         (WTR::AccessibilityUIElement::orientation):
1915
1916 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
1917
1918         [chromium] move WebThemeEngine implementations to TestRunner library
1919         https://bugs.webkit.org/show_bug.cgi?id=112751
1920
1921         Reviewed by Adam Barth.
1922
1923         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1924         * DumpRenderTree/DumpRenderTree.gypi:
1925         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1926         (WebKit):
1927         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1928         (WebTestRunner::TestInterfaces::themeEngine):
1929         (WebTestRunner):
1930         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1931         (WebKit):
1932         (TestInterfaces):
1933         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1934         (WebTestRunner::WebTestInterfaces::themeEngine):
1935         (WebTestRunner):
1936         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1937         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1938         (WebTestRunner):
1939         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1940         (WebTestRunner::WebTestThemeControlWin::box):
1941         (WebTestRunner::WebTestThemeControlWin::line):
1942         (WebTestRunner::WebTestThemeControlWin::triangle):
1943         (WebTestRunner::WebTestThemeControlWin::roundRect):
1944         (WebTestRunner::WebTestThemeControlWin::oval):
1945         (WebTestRunner::WebTestThemeControlWin::circle):
1946         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1947         (WebTestRunner::WebTestThemeControlWin::markState):
1948         (WebTestRunner::WebTestThemeControlWin::draw):
1949         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1950         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1951         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1952         (WebTestRunner):
1953         (WebTestThemeControlWin):
1954         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1955         (WebTestRunner):
1956         (WebTestThemeEngineMac):
1957         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1958         (+[FakeActiveWindow alwaysActiveWindow]):
1959         (+[FakeActiveWindow alwaysInactiveWindow]):
1960         (-[FakeActiveWindow initWithActiveControls:]):
1961         (-[FakeActiveWindow _hasActiveControls]):
1962         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1963         (WebTestRunner):
1964         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1965         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1966         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1967         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1968         (WebTestRunner):
1969         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1970         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1971         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1972         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1973         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1974         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1975         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1976         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1977         (WebTestRunner::WebTestThemeEngineWin::getSize):
1978         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1979         (WebTestRunner):
1980         (WebTestThemeEngineWin):
1981         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1982         * DumpRenderTree/chromium/TestShell.cpp:
1983         (TestShell::initialize):
1984         * DumpRenderTree/chromium/TestShell.h:
1985         (WebKit):
1986         * DumpRenderTree/chromium/TestShellMac.mm:
1987         (platformInit):
1988         * DumpRenderTree/chromium/TestShellWin.cpp:
1989         (platformInit):
1990         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1991
1992 2013-03-19  Tony Chang  <tony@chromium.org>
1993
1994         Move testRunner.setTouchDragDropEnabled to internals.settings
1995         https://bugs.webkit.org/show_bug.cgi?id=112739
1996
1997         Reviewed by Adam Barth.
1998
1999         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2000         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2001         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2002         (TestRunner): Remove unnecessary code.
2003         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2004         (WebTestRunner::WebPreferences::reset):
2005         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2006
2007 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2008
2009         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2010         https://bugs.webkit.org/show_bug.cgi?id=112754
2011
2012         Reviewed by Darin Fisher.
2013
2014         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2015         now that it's always defined.
2016
2017         * DumpRenderTree/chromium/WebViewHost.cpp:
2018         * DumpRenderTree/chromium/WebViewHost.h:
2019         (WebViewHost):
2020
2021 2013-03-19  Kenneth Russell  <kbr@google.com>
2022
2023         Unreviewed, rolling out r146290.
2024         http://trac.webkit.org/changeset/146290
2025         https://bugs.webkit.org/show_bug.cgi?id=112751
2026
2027         Broke Chromium Mac build.
2028
2029         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2030         * DumpRenderTree/DumpRenderTree.gypi:
2031         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2032         (WebKit):
2033         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2034         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2035         (TestInterfaces):
2036         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2037         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2038         * DumpRenderTree/chromium/TestShell.cpp:
2039         (TestShell::initialize):
2040         * DumpRenderTree/chromium/TestShell.h:
2041         (WebKit):
2042         * DumpRenderTree/chromium/TestShellMac.mm:
2043         (platformInit):
2044         * DumpRenderTree/chromium/TestShellWin.cpp:
2045         (platformInit):
2046         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2047         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2048         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2049         (WebThemeControlDRTWin::box):
2050         (WebThemeControlDRTWin::line):
2051         (WebThemeControlDRTWin::triangle):
2052         (WebThemeControlDRTWin::roundRect):
2053         (WebThemeControlDRTWin::oval):
2054         (WebThemeControlDRTWin::circle):
2055         (WebThemeControlDRTWin::nestedBoxes):
2056         (WebThemeControlDRTWin::markState):
2057         (WebThemeControlDRTWin::draw):
2058         (WebThemeControlDRTWin::drawTextField):
2059         (WebThemeControlDRTWin::drawProgressBar):
2060         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2061         (WebThemeControlDRTWin):
2062         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2063         (WebThemeEngineDRTMac):
2064         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2065         (+[FakeActiveWindow alwaysActiveWindow]):
2066         (+[FakeActiveWindow alwaysInactiveWindow]):
2067         (-[FakeActiveWindow initWithActiveControls:]):
2068         (-[FakeActiveWindow _hasActiveControls]):
2069         (WebThemeEngineDRTMac::paintScrollbarThumb):
2070         (stateToHIEnableState):
2071         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2072         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2073         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2074         (webRectToSkIRect):
2075         (drawControl):
2076         (drawTextField):
2077         (drawProgressBar):
2078         (WebThemeEngineDRTWin::paintButton):
2079         (WebThemeEngineDRTWin::paintMenuList):
2080         (WebThemeEngineDRTWin::paintScrollbarArrow):
2081         (WebThemeEngineDRTWin::paintScrollbarThumb):
2082         (WebThemeEngineDRTWin::paintScrollbarTrack):
2083         (WebThemeEngineDRTWin::paintSpinButton):
2084         (WebThemeEngineDRTWin::paintTextField):
2085         (WebThemeEngineDRTWin::paintTrackbar):
2086         (WebThemeEngineDRTWin::paintProgressBar):
2087         (WebThemeEngineDRTWin::getSize):
2088         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2089         (WebThemeEngineDRTWin):
2090         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2091
2092 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2093
2094         [EFL] canvas-fallback-content.html is failing
2095         https://bugs.webkit.org/show_bug.cgi?id=111998
2096
2097         Reviewed by Chris Fleizach.
2098
2099         Adds support for getting platform name.
2100
2101         * DumpRenderTree/TestRunner.cpp:
2102         (TestRunner::staticValues):
2103         * DumpRenderTree/TestRunner.h:
2104         (TestRunner):
2105         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2106         (TestRunner::platformName):
2107
2108 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2109
2110         [chromium] move WebThemeEngine implementations to TestRunner library
2111         https://bugs.webkit.org/show_bug.cgi?id=112751
2112
2113         Reviewed by Adam Barth.
2114
2115         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2116         * DumpRenderTree/DumpRenderTree.gypi:
2117         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2118         (WebKit):
2119         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2120         (WebTestRunner::TestInterfaces::themeEngine):
2121         (WebTestRunner):
2122         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2123         (WebKit):
2124         (TestInterfaces):
2125         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2126         (WebTestRunner::WebTestInterfaces::themeEngine):
2127         (WebTestRunner):
2128         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2129         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2130         (WebTestRunner):
2131         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2132         (WebTestRunner::WebTestThemeControlWin::box):
2133         (WebTestRunner::WebTestThemeControlWin::line):
2134         (WebTestRunner::WebTestThemeControlWin::triangle):
2135         (WebTestRunner::WebTestThemeControlWin::roundRect):
2136         (WebTestRunner::WebTestThemeControlWin::oval):
2137         (WebTestRunner::WebTestThemeControlWin::circle):
2138         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2139         (WebTestRunner::WebTestThemeControlWin::markState):
2140         (WebTestRunner::WebTestThemeControlWin::draw):
2141         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2142         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2143         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2144         (WebTestRunner):
2145         (WebTestThemeControlWin):
2146         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2147         (WebTestRunner):
2148         (WebTestThemeEngineMac):
2149         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2150         (+[FakeActiveWindow alwaysActiveWindow]):
2151         (+[FakeActiveWindow alwaysInactiveWindow]):
2152         (-[FakeActiveWindow initWithActiveControls:]):
2153         (-[FakeActiveWindow _hasActiveControls]):
2154         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2155         (WebTestRunner):
2156         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2157         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2158         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2159         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2160         (WebTestRunner):
2161         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2162         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2163         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2164         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2165         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2166         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2167         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2168         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2169         (WebTestRunner::WebTestThemeEngineWin::getSize):
2170         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2171         (WebTestRunner):
2172         (WebTestThemeEngineWin):
2173         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2174         * DumpRenderTree/chromium/TestShell.cpp:
2175         (TestShell::initialize):
2176         * DumpRenderTree/chromium/TestShell.h:
2177         (WebKit):
2178         * DumpRenderTree/chromium/TestShellMac.mm:
2179         (platformInit):
2180         * DumpRenderTree/chromium/TestShellWin.cpp:
2181         (platformInit):
2182         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2183
2184 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2185
2186         [EFL][WK2] Separate WebView further from EwkView
2187         https://bugs.webkit.org/show_bug.cgi?id=111591
2188
2189         Reviewed by Caio Marcelo de Oliveira Filho.
2190
2191         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2192         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2193         since we can afford it having EWKViewGetWKView() private API to access WKView.
2194
2195         * TestWebKitAPI/PlatformWebView.h:
2196         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2197         (TestWebKitAPI::TEST):
2198         * TestWebKitAPI/efl/PlatformWebView.cpp:
2199         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2200         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2201         (TestWebKitAPI::PlatformWebView::resizeTo):
2202         (TestWebKitAPI::PlatformWebView::page):
2203         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2204         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2205         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2206         * WebKitTestRunner/PlatformWebView.h:
2207         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2208         (WTR::EventSenderProxy::dispatchEvent):
2209         (WTR::EventSenderProxy::keyDown):
2210         (WTR::EventSenderProxy::sendTouchEvent):
2211         (WTR::EventSenderProxy::setTouchModifier):
2212         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2213         (WTR::PlatformWebView::PlatformWebView):
2214         (WTR::PlatformWebView::~PlatformWebView):
2215         (WTR::PlatformWebView::resizeTo):
2216         (WTR::PlatformWebView::page):
2217         (WTR::PlatformWebView::focus):
2218         (WTR::PlatformWebView::windowSnapshotImage):
2219
2220 2013-03-19  Roger Fong  <roger_fong@apple.com>
2221
2222         Changes to VS2010 project files should only trigger builds on Windows bots.
2223         https://bugs.webkit.org/show_bug.cgi?id=112731
2224
2225         Reviewed by Timothy Horton.
2226
2227         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2228         (_should_file_trigger_build):
2229
2230 2013-03-19  Roger Fong  <roger_fong@apple.com>
2231
2232         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2233
2234         * Scripts/webkitpy/tool/steps/runtests.py:
2235         (RunTests.run):
2236         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2237         (RunTestsTest.test_webkit_run_unit_tests):
2238
2239 2013-03-19  Julie Parent  <jparent@chromium.org>
2240
2241         Dashboards: Introduce history namespace and unit tests.
2242         https://bugs.webkit.org/show_bug.cgi?id=112645
2243
2244         Reviewed by Ojan Vafai.
2245         
2246         Laying the framework for introducing the new history object and
2247         namespace.  This moves only static functions into the history
2248         namespace, and moves corresponding unit tests into seperate
2249         unit test file.
2250
2251         * TestResultServer/static-dashboards/aggregate_results.html:
2252         * TestResultServer/static-dashboards/dashboard_base.js:
2253         (parseCrossDashboardParameters):
2254         (parseDashboardSpecificParameters):
2255         (parseParameters):
2256         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2257         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2258         (.switch.return):
2259         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2260         * TestResultServer/static-dashboards/history.js: Added.
2261         * TestResultServer/static-dashboards/history_unittests.js: Added.
2262         * TestResultServer/static-dashboards/loader.js:
2263         (.):
2264         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2265         * TestResultServer/static-dashboards/run-unittests.html:
2266         * TestResultServer/static-dashboards/timeline_explorer.html:
2267         * TestResultServer/static-dashboards/timeline_explorer.js:
2268         * TestResultServer/static-dashboards/treemap.html:
2269         * TestResultServer/static-dashboards/treemap.js:
2270         (.switch.return):
2271         * TestResultServer/static-dashboards/ui.js:
2272
2273 2013-03-19  Daniel Bates  <dbates@webkit.org>
2274
2275         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2276         https://bugs.webkit.org/show_bug.cgi?id=112732
2277
2278         Reviewed by Eric Seidel.
2279
2280         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2281         of an existing file cannot be applied.
2282
2283         In particular, svn-{apply, unapply} compensate for differences in line endings
2284         by converting the line endings in a diff to match the line endings in the target
2285         file. The diff(1) command precedes the last line of a diff that adds a newline
2286         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2287         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2288         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2289         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2290         the newline characters in this special character sequence to match the line endings
2291         in the target file.
2292
2293         * Scripts/VCSUtils.pm:
2294         (parseDiff):
2295         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2296         Added tests:
2297             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2298             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2299             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2300             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2301         (escapeNewLineCharacters): Added.
2302         (toMacLineEndings): Added.
2303
2304 2013-03-19  James Robinson  <jamesr@chromium.org>
2305
2306         [chromium] Remove compositor settings that don't go through WebKit
2307         https://bugs.webkit.org/show_bug.cgi?id=112718
2308
2309         Reviewed by Adam Barth.
2310
2311         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2312         (main):
2313         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2314         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2315         (WebTestRunner::WebPreferences::reset):
2316         (WebTestRunner::WebPreferences::applyTo):
2317         * DumpRenderTree/chromium/TestShell.cpp:
2318         (TestShell::TestShell):
2319         (TestShell::resetWebSettings):
2320         * DumpRenderTree/chromium/TestShell.h:
2321         (TestShell):
2322
2323 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
2324
2325         Unreviewed, rolling out r146101.
2326         https://bugs.webkit.org/show_bug.cgi?id=111884
2327
2328         re-enable custom freetype on asan; this needs to be on
2329         now that the bot is running lucid.
2330
2331         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2332
2333 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
2334
2335         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
2336         https://bugs.webkit.org/show_bug.cgi?id=112365
2337
2338         Reviewed by Benjamin Poulain.
2339
2340         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
2341         harcoding it in wtf/Platform.h
2342
2343         * Scripts/webkitperl/FeatureList.pm:
2344
2345 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2346
2347         [Qt] Make ImageDiff similar to Chromium's ImageDiff
2348         https://bugs.webkit.org/show_bug.cgi?id=94782
2349
2350         Based on patch by Csaba Osztrogonác.
2351         Reviewed by Jocelyn Turcotte.
2352
2353         The diff image is generated with bright red indicating errors, but letting the base image
2354         shine through so the context of the error-pixel can be identified.
2355
2356         * DumpRenderTree/qt/ImageDiff.cpp:
2357         (main):
2358
2359 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
2360
2361         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
2362
2363         Rubber-stamped by Csaba Osztrogonác.
2364
2365         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
2366         since the latter might not cover the former.
2367
2368         * QtTestBrowser/launcherwindow.cpp:
2369         (LauncherWindow::print):
2370
2371 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2372
2373         Style tweeks to default.css.
2374         
2375         Rubber-stamped by David Kilzer.
2376         
2377         Give visited links a different color to other links, so you can
2378         see which builds you've viewed.
2379         
2380         Make the <small> text less tiny.
2381
2382         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2383         (small):
2384         (a:link,a:visited,a:active):
2385         (a:visited):
2386
2387 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2388
2389         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
2390         https://bugs.webkit.org/show_bug.cgi?id=112494
2391
2392         Reviewed by Dirk Pranke.
2393
2394         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
2395         Also merged two pairs of methods to cleanup the code.
2396
2397         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2398         (PerfTestsRunner.run): Merged _upload_and_show_results.
2399         (PerfTestsRunner._generate_results): Merged _generate_output_files.
2400
2401 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2402
2403         [chromium] build xdisplaycheck when building DRT
2404         https://bugs.webkit.org/show_bug.cgi?id=112636
2405
2406         Reviewed by Tony Chang.
2407
2408         It appears that we need xdisplaycheck to be built in order for
2409         Xvfb to be started correctly on the bots, and DRT was missing
2410         a dependency on it. This may be the cause of the ASAN bot not
2411         starting up properly (it only builds DRT).
2412
2413         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2414
2415 2013-03-18  David Levin  <levin@chromium.org>
2416
2417         Implement icon change notification dump for Chromium's test shell.
2418         https://bugs.webkit.org/show_bug.cgi?id=112614
2419
2420         This was previously implemented for some other platforms in r58111
2421         and r116547.
2422
2423         In r122806, fast/dom/icon-url-property.html stopped using it, but
2424         it is useful for tests, so I plan to re-add it to that test again.
2425
2426         Reviewed by Jochen Eisinger.
2427
2428         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2429         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
2430          icon change notifications from WebKit may be logged in test output.
2431         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2432         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
2433         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
2434         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
2435         (WebTestRunner):
2436         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
2437         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2438         (TestRunner):
2439         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2440         (WebTestRunner::WebTestProxyBase::didChangeIcon):
2441         (WebTestRunner):
2442         * DumpRenderTree/chromium/WebViewHost.cpp:
2443         (WebViewHost::didChangeIcon): Add the output about changing the icon.
2444         * DumpRenderTree/chromium/WebViewHost.h:
2445         (WebViewHost):
2446
2447 2013-03-18  Julie Parent  <jparent@chromium.org>
2448
2449         Cleanup: Move js for treemap and aggregate_results into own js files.
2450         https://bugs.webkit.org/show_bug.cgi?id=112618
2451
2452         Reviewed by Dirk Pranke.
2453         
2454         No functional changes, just moving the code into separate js file
2455         rather than inlined in the html, so we can test it, make it more
2456         modular, etc.  Other dashboard types are already done this way.
2457
2458         * TestResultServer/static-dashboards/aggregate_results.html:
2459         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
2460         (generatePage):
2461         (handleValidHashParameter):
2462         (htmlForBuilder):
2463         (rawValuesHTML):
2464         (chartHTML):
2465         (filteredValues):
2466         (chart):
2467         (htmlForRevisionRows):
2468         (wrapHTMLInTable):
2469         (htmlForSummaryTable):
2470         (valuesPerExpectation):
2471         (htmlForTestType):
2472         (htmlForTableRow):
2473         (extendedEncode):
2474         * TestResultServer/static-dashboards/treemap.html:
2475         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
2476         (humanReadableTime):
2477         (convertToWebTreemapFormat):
2478         (reverseSortByAverage):
2479         (generatePage):
2480         (focusPath):
2481         (.switch.return):
2482         (handleQueryParameterChange):
2483         (extractName):
2484         (fullName):
2485         (handleFocus.):
2486         (handleFocus):
2487
2488 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2489
2490         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
2491         https://bugs.webkit.org/show_bug.cgi?id=112622
2492
2493         Reviewed by Dirk Pranke.
2494
2495         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2496         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
2497
2498 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2499
2500         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
2501         https://bugs.webkit.org/show_bug.cgi?id=112619
2502
2503         Reviewed by Dirk Pranke.
2504
2505         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
2506         directory and then fall back to the generic LayoutTests/platform/gtk directory.
2507
2508         * Scripts/webkitpy/layout_tests/port/gtk.py:
2509         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
2510         Port._webkit_baseline_path method.
2511         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2512         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
2513         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
2514         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2515         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
2516         that are expected based on the builder name.
2517
2518 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
2519
2520         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
2521         https://bugs.webkit.org/show_bug.cgi?id=112571
2522
2523         Reviewed by Adam Barth.
2524
2525         Update function declarations for new WebFileSystemType enum. (All
2526         changes are behind an #ifdef so we can sync required changes in embedders.)
2527
2528         * DumpRenderTree/chromium/WebViewHost.cpp:
2529         (WebViewHost::openFileSystem):
2530         (WebViewHost::deleteFileSystem):
2531         * DumpRenderTree/chromium/WebViewHost.h:
2532         (WebViewHost):
2533
2534 2013-03-18  Julie Parent  <jparent@chromium.org>
2535
2536         Cleanup: Move timeline_exporer js out of html file into js.
2537         https://bugs.webkit.org/show_bug.cgi?id=112188
2538
2539         Reviewed by Dirk Pranke.
2540         
2541         Moves the javascript out of the html file and into a new js file.
2542         This follows the format of flakiness_dashboard.{html|js}.
2543         
2544         Also moves code from dashboard_base that is used only by this one
2545         dashboard, and makes it private to the dashboard.
2546
2547         * TestResultServer/static-dashboards/dashboard_base.js:
2548         * TestResultServer/static-dashboards/timeline_explorer.html:
2549         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
2550         (generatePage):
2551         (initCurrentBuilderTestResults):
2552         (shouldShowWebKitRevisionsOnly):
2553         (updateTimelineForBuilder.):
2554         (updateTimelineForBuilder):
2555         (selectBuild):
2556         (updateBuildIndicator):
2557         (.addRow):
2558         (.addNumberRow):
2559         (.inspectorNode.getElementsByTagName.0.onclick):
2560         (.inspectorNode.getElementsByTagName.1.onclick):
2561         (.inspectorNode.getElementsByTagName.2.onclick):
2562         (updateBuildInspector):
2563         (showResultsDelta):
2564         (decompressResults.addFlakyDelta):
2565         (decompressResults):
2566
2567 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2568
2569         Unreviewed, rolling out r145272.
2570         http://trac.webkit.org/changeset/145272
2571         https://bugs.webkit.org/show_bug.cgi?id=111884
2572
2573         Turns out the ASAN build is still broken; possibly there's
2574         something still setting LD_LIBRARY_PATH, or possibly there's
2575         something else wrong. In the meantime, we need it to work again.
2576
2577         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2578
2579 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2580
2581         delete-stale-build-files is too aggressive
2582         https://bugs.webkit.org/show_bug.cgi?id=112595
2583
2584         Reviewed by Tim Horton.
2585
2586         It appears that whitelisting file extensions to keep is not a good idea.
2587         Blacklist files to delete instead, and only delete .o files for now.
2588         We can add more file extensions as needed.
2589
2590         * BuildSlaveSupport/delete-stale-build-files:
2591
2592 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2593
2594         Disable accessibility notifications after each test
2595         https://bugs.webkit.org/show_bug.cgi?id=112579
2596
2597         Reviewed by Tim Horton.
2598         
2599         In WebKitTestRunner, if any tests triggered accessibility notifications,
2600         the global notification handler would thereafter be active, and fire
2601         notifications for all subsequent tests.
2602         
2603         Fix by implementing AccessibilityController::resetToConsistentState() for
2604         Mac, and using it to clear the global notification handler.
2605
2606         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2607         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2608         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
2609         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
2610         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
2611         (e.g. because of -autorelease).
2612         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
2613         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
2614         if there is one.
2615         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
2616         Add -stopObserving
2617         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2618         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
2619         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
2620         center.
2621
2622 2013-03-18  Dana Jansens  <danakj@chromium.org>
2623
2624         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
2625         https://bugs.webkit.org/show_bug.cgi?id=112392
2626
2627         Reviewed by James Robinson.
2628
2629         Removes the command line flag option from DRT.
2630
2631         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2632         (main):
2633
2634 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2635
2636         [GTK] plugins/plugin-clip-subframe.html is failing
2637         https://bugs.webkit.org/show_bug.cgi?id=112570
2638
2639         Reviewed by Martin Robinson.
2640
2641         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
2642
2643 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
2644
2645         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
2646         https://bugs.webkit.org/show_bug.cgi?id=112442
2647
2648         Reviewed by Gustavo Noronha Silva.
2649
2650         * GtkLauncher/main.c:
2651         (reloadCb):
2652         (createToolbar):
2653         (createWindow):
2654
2655 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2656
2657         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
2658         https://bugs.webkit.org/show_bug.cgi?id=112205
2659
2660         Disable this API test until Geoff can fix it.
2661
2662         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2663         (TestWebKitAPI::TEST):
2664
2665 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
2666
2667         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2668         https://bugs.webkit.org/show_bug.cgi?id=112478
2669
2670         Reviewed by Tony Chang.
2671
2672         There is nothing that ensures that the log messages from the plugin
2673         come in before the layout test finished loading.
2674
2675         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2676         (PassDifferentNPPStruct::NPP_SetWindow):
2677         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2678         (NPP_SetWindow):
2679
2680 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2681
2682         Have the mac port support per_test_timeout in webkitpy
2683         https://bugs.webkit.org/show_bug.cgi?id=112466
2684
2685         Reviewed by Dirk Pranke.
2686         
2687         Both WTR and DRT handle --timeout arguments, so we can
2688         have the scripts pass the timeout values down to the tools.
2689
2690         * Scripts/webkitpy/layout_tests/port/mac.py:
2691         (MacPort.supports_per_test_timeout):
2692
2693 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
2694
2695         Remove setAsynchronousSpellCheckingEnabled from test runners
2696         https://bugs.webkit.org/show_bug.cgi?id=112362
2697
2698         Reviewed by Tony Chang.
2699
2700         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
2701         in internals.settings, so all ports can share it.
2702
2703         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2704         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2705         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2706         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2707         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2708         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2709         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2710         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
2711         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2712         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
2713         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2714         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2715
2716 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2717
2718         Fix the stupid unit tests.
2719
2720         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2721         (test_sample_process):
2722
2723 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
2724
2725         Collect samples for unresponsive web processes
2726         https://bugs.webkit.org/show_bug.cgi?id=112409
2727
2728         Reviewed by Tim Horton.
2729         
2730         When we detect that a subprocess was unresponsive, run the 'sample'
2731         tool on that process, for the Mac port.
2732         
2733         The sample will be linked to from the results.html page, next
2734         to the crash log link.
2735
2736         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2737         (Manager._look_for_new_crash_logs): Before looking for crash logs,
2738         look for samples on disk.
2739         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2740         (TestResultWriter):
2741         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
2742         -sample.txt files, and have it copy their contents to a new file
2743         next to the test that spawned them (as we do for crash logs).
2744         * Scripts/webkitpy/layout_tests/port/base.py:
2745         (Port.look_for_new_samples): Base class does nothing for sampling.
2746         * Scripts/webkitpy/layout_tests/port/driver.py:
2747         (Driver._check_for_driver_crash): Kick off a sample if we detected
2748         that the subprocess was unresponsive.
2749         * Scripts/webkitpy/layout_tests/port/mac.py:
2750         (MacPort.sample_file_path): Utility to generate the file path
2751         to the generated sample files at the top level of layout-test-results.
2752         (MacPort.look_for_new_crash_logs): Fix typo
2753         (MacPort.look_for_new_samples): New function to find sample files.
2754         (MacPort.sample_process): Use the utility function to get the file path.
2755
2756 2013-03-15  Zeno Albisser  <zeno@webkit.org>
2757
2758         [Qt] Remove simple getters and setters from TestRunnerQt
2759         https://bugs.webkit.org/show_bug.cgi?id=112343
2760
2761         Reviewed by Benjamin Poulain.
2762
2763         The removed functions and boolean members
2764         are being replaced by the implementations in the
2765         generic TestRunner.h.
2766
2767         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2768         (DumpRenderTree::dumpFrameScrollPosition):
2769         (DumpRenderTree::dumpFramesAsText):
2770         (DumpRenderTree::dump):
2771         (DumpRenderTree::titleChanged):
2772         (DumpRenderTree::dumpDatabaseQuota):
2773         (DumpRenderTree::dumpApplicationCacheQuota):
2774         (DumpRenderTree::statusBarMessage):
2775         (DumpRenderTree::createWindow):
2776         * DumpRenderTree/qt/TestRunnerQt.cpp:
2777         (TestRunnerQt::reset):
2778         * DumpRenderTree/qt/TestRunnerQt.h:
2779         (TestRunnerQt):
2780
2781 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
2782
2783         Update the link on build.webkit.org to refer to perf.webkit.org
2784         https://bugs.webkit.org/show_bug.cgi?id=112416
2785
2786         Reviewed by Philip Rogers.
2787
2788         Updated the link. Also updated the template to use HTML5 DOCTYPE.
2789
2790         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2791
2792 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
2793
2794         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
2795         https://bugs.webkit.org/show_bug.cgi?id=112394
2796
2797         Reviewed by Philippe Normand.
2798
2799         * GtkLauncher/main.c:
2800         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
2801
2802 2013-03-14  Andreas Kling  <akling@apple.com>
2803
2804         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
2805         <http://webkit.org/b/111815>
2806         <rdar://problem/13380145>
2807
2808         Reviewed by Anders Carlsson.
2809
2810         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
2811         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
2812         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
2813
2814         * WebKitTestRunner/PlatformWebView.h:
2815         (PlatformWebView):
2816         * WebKitTestRunner/TestController.cpp:
2817         (WTR::TestController::createOtherPage):
2818         (WTR::TestController::createWebViewWithOptions):
2819         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2820         (WTR::PlatformWebView::didInitializeClients):
2821
2822 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2823
2824         [EFL][MiniBrowser] Add a search field to the MiniBrowser
2825         https://bugs.webkit.org/show_bug.cgi?id=112122
2826
2827         Reviewed by Kenneth Rohde Christiansen.
2828
2829         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
2830
2831         * MiniBrowser/efl/main.c:
2832         (_Browser_Window):
2833         (search_box_show):
2834         (search_box_hide):
2835         (on_key_down):
2836         (on_url_changed):
2837         (on_search_field_aborted):
2838         (on_search_field_activated):
2839         (on_search_field_clicked):
2840         (on_search_backward_button_clicked):
2841         (on_search_forward_button_clicked):
2842         (window_create):
2843
2844 2013-03-14  Julie Parent  <jparent@chromium.org>
2845
2846         Cleanup: Remove g_resourceLoader.
2847         https://bugs.webkit.org/show_bug.cgi?id=112305
2848
2849         Reviewed by Dirk Pranke.
2850         
2851         Removing another global.
2852         
2853         Now, each dashboard creates its own loader, rather than having
2854         a general global one.
2855         
2856         Remove usage of g_resourceLoader.isLoadingComplete from 
2857         handleLocationChange by ensuring that handleLocationChange is
2858         never called before the loader is done.  It was called in two
2859         places before: 1 was from the callback when the loader is done,
2860         so that was obviously true, and the other was from onhashchange,
2861         where it would just return rather than running.  Instead, lets
2862         only register the onhashchange handler once the loader is
2863         setup, so the check is no longer necessary.
2864         
2865         Remove isLoadingComplete since it is now unused.
2866         
2867         Callback for loader is now initializeHistory, rather than just
2868         handleLocationChange which will set up the hashchange handler now.
2869         This will all eventually be moving to a new History object.
2870
2871         * TestResultServer/static-dashboards/aggregate_results.html:
2872         * TestResultServer/static-dashboards/dashboard_base.js:
2873         (handleLocationChange):
2874         (intializeHistory):
2875         (decompressResults):
2876         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2877         (generatePage):
2878         * TestResultServer/static-dashboards/loader.js:
2879         (.):
2880         * TestResultServer/static-dashboards/loader_unittests.js:
2881         * TestResultServer/static-dashboards/timeline_explorer.html:
2882         * TestResultServer/static-dashboards/treemap.html:
2883
2884 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
2885
2886         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
2887         https://bugs.webkit.org/show_bug.cgi?id=109404
2888
2889         Reviewed by Tony Chang.
2890
2891         Removes all the code related to smartInsertDeleteEnabled and
2892         selectTrailingWhitespaceEnabled settings as they will be managed from
2893         internals from now on.
2894
2895         * DumpRenderTree/TestRunner.cpp:
2896         (TestRunner::staticFunctions):
2897         * DumpRenderTree/TestRunner.h:
2898         (TestRunner):
2899         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2900         (WebKit):
2901         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2902         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2903         (DumpRenderTree):
2904         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2905         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2906         (WebTestRunner::WebTestProxy::didStopLoading):
2907         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2908         (WebTestRunner::TestRunner::TestRunner):
2909         (WebTestRunner::TestRunner::reset):
2910         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2911         (TestRunner):
2912         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2913         (WebTestRunner::WebPreferences::applyTo): Set default values for
2914         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
2915         Chromium DRT default values are different from Chromium browser.
2916         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2917         * DumpRenderTree/chromium/WebViewHost.cpp:
2918         * DumpRenderTree/chromium/WebViewHost.h:
2919         (WebViewHost):
2920         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2921         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2922         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2923         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2924         (resetDefaultsToConsistentValues):
2925         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2926         * DumpRenderTree/mac/DumpRenderTree.mm:
2927         (resetWebViewToConsistentStateBeforeTesting):
2928         * DumpRenderTree/mac/TestRunnerMac.mm:
2929         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2930         (WebCore::WebPage::resetSettings):
2931         * DumpRenderTree/qt/TestRunnerQt.cpp:
2932         * DumpRenderTree/qt/TestRunnerQt.h:
2933         (TestRunnerQt):
2934         * DumpRenderTree/win/DumpRenderTree.cpp:
2935         (resetWebViewToConsistentStateBeforeTesting):
2936         * DumpRenderTree/win/TestRunnerWin.cpp:
2937         * DumpRenderTree/wx/TestRunnerWx.cpp:
2938
2939 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2940
2941         [Qt] Disable DRT on Windows
2942
2943         Reviewed by Jocelyn Turcotte.
2944
2945         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
2946
2947         * qmake/mkspecs/features/configure.prf:
2948
2949 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2950
2951         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
2952         https://bugs.webkit.org/show_bug.cgi?id=110728
2953
2954         Reviewed by Gyuyoung Kim.
2955
2956         Use the page group to create the view object.
2957
2958         * MiniBrowser/efl/main.c:
2959         (window_create):
2960
2961 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2962
2963         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
2964
2965         Reviewed by Tor Arne Vestbø.
2966
2967         The mock versions of these web facing features should be instantiated when
2968         running in DumpRenderTree only. In order for them to work, no extra Qt modules
2969         such as QtLocation are actually needed.
2970
2971         This patch decouples enabling device orientation/motion and geolocation from
2972         the underlying Qt modules and makes them available in developer builds
2973         (!production_build) and backed by mock backends when running in drt.
2974
2975         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
2976         developers the web facing features are always enabled (although requests will
2977         time out) and the mock backends are enabled inside DRT, allowing for the layout
2978         tests to run with less dependencies.
2979
2980         In addition this also enables the mock device motion client, which was
2981         previously never instantiated.
2982
2983         * qmake/mkspecs/features/features.prf:
2984
2985 2013-03-14  Zeno Albisser  <zeno@webkit.org>
2986
2987         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
2988         https://bugs.webkit.org/show_bug.cgi?id=112340
2989
2990         Reviewed by Simon Hausmann.
2991
2992         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2993         (DumpRenderTree::dump):
2994             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
2995         (DumpRenderTree::dumpApplicationCacheQuota):
2996         * DumpRenderTree/qt/TestRunnerQt.cpp:
2997         (TestRunnerQt::reset):
2998         * DumpRenderTree/qt/TestRunnerQt.h:
2999         (TestRunnerQt):
3000
3001 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3002
3003         [Qt] Port DRT to use TestRunner::dumpAsText()
3004         https://bugs.webkit.org/show_bug.cgi?id=112260
3005
3006         Reviewed by Benjamin Poulain.
3007
3008         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3009         (WebCore::DumpRenderTree::open):
3010         (WebCore::methodNameStringForFailedTest):
3011             Change parameter from type TestRunnerQt* to TestRunner*.
3012         (WebCore::DumpRenderTree::dump):
3013             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3014             Instead we should rely on TestRunner::generatePixelResults().
3015         * DumpRenderTree/qt/TestRunnerQt.cpp:
3016         (TestRunnerQt::reset):
3017         * DumpRenderTree/qt/TestRunnerQt.h:
3018         (TestRunnerQt):
3019
3020 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3021
3022         Implement FontLoader interface
3023         https://bugs.webkit.org/show_bug.cgi?id=98395
3024
3025         Reviewed by Eric Seidel.
3026
3027         Enable FontLoadEvents runtime flag for TestShell.
3028
3029         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3030         (WebTestRunner::TestInterfaces::TestInterfaces):
3031
3032 2013-03-13  Julie Parent  <jparent@chromium.org>
3033
3034         CLeanup: remove unnecessary call to parseParameters.
3035         https://bugs.webkit.org/show_bug.cgi?id=112309
3036
3037         Reviewed by Ojan Vafai.
3038         
3039         We call parseCrossDashboardParameters when the dashboard initially
3040         loads to set the state required for loadBuildersList, and then we
3041         call it again once we are fully done with loading, so there is no
3042         reason to call it in the middle of the loading process here.
3043
3044         * TestResultServer/static-dashboards/loader.js:
3045         (.):
3046
3047 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3048
3049         Unreviewed. Now I'm a reviewer :)
3050
3051         * Scripts/webkitpy/common/config/committers.py:
3052
3053 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3054
3055         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3056         https://bugs.webkit.org/show_bug.cgi?id=112277
3057
3058         Reviewed by Adam Barth.
3059
3060         * Scripts/webkitperl/FeatureList.pm:
3061         * qmake/mkspecs/features/features.pri:
3062
3063 2013-03-13  Adam Barth  <abarth@webkit.org>
3064
3065         run-perf-tests should support content_shell
3066         https://bugs.webkit.org/show_bug.cgi?id=112291
3067
3068         Reviewed by Eric Seidel.
3069
3070         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3071         (PerfTestsRunner._parse_args):
3072
3073 2013-03-13  Oliver Hunt  <oliver@apple.com>
3074
3075         Simplify Checked<> multiplication
3076         https://bugs.webkit.org/show_bug.cgi?id=112286
3077
3078         Reviewed by James Robinson.
3079
3080         Add tests for multiplication by zero and max to ensure we don't
3081         mess them up should we ever make changes to Checked<> in future.
3082
3083         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3084         (TestWebKitAPI):
3085
3086 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3087
3088         [Qt] Unreviewed prospective Windows build fix
3089
3090         Do the usual thing, include the moc generated code in the .cpp file instead
3091         of compiling it standalone, to ensure that config.h is included, too, and
3092         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3093
3094         * DumpRenderTree/qt/EventSenderQt.cpp:
3095
3096 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3097
3098         [Qt] Port TestRunner::findString to shared interface
3099         https://bugs.webkit.org/show_bug.cgi?id=112147
3100
3101         Reviewed by Jocelyn Turcotte.
3102
3103         This patch also removes DumpRenderTree and some other helper classes from
3104         the WebCore namespace, to which they do not really belong.
3105
3106         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3107         (main):
3108         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3109         (DumpRenderTree::DumpRenderTree):
3110         (DumpRenderTree::~DumpRenderTree):
3111         (DumpRenderTree::instance):
3112         (DumpRenderTree::setShouldTimeout):
3113         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3114         (DumpRenderTree):
3115         * DumpRenderTree/qt/EventSenderQt.cpp:
3116         (EventSender::contextClick):
3117         (EventSender::sendEvent):
3118         (EventSender::postEvent):
3119         * DumpRenderTree/qt/EventSenderQt.h:
3120         (EventSender::isGraphicsBased):
3121         * DumpRenderTree/qt/TestRunnerQt.cpp:
3122         (TestRunnerQt::TestRunnerQt):
3123         (TestRunner::findString):
3124         (TestRunnerQt::setMockDeviceOrientation):
3125         (TestRunnerQt::setGeolocationPermission):
3126         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3127         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3128         (TestRunnerQt::setMockGeolocationPosition):
3129         * DumpRenderTree/qt/TestRunnerQt.h:
3130         (TestRunnerQt):
3131
3132 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3133
3134         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3135         https://bugs.webkit.org/show_bug.cgi?id=112129
3136
3137         Reviewed by Adam Barth.
3138
3139         Following Chromium
3140         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3141         this is being renamed to better explain what it does.
3142
3143         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3144
3145 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3146
3147         [Qt] Unreviewed trivial typo fix
3148
3149         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3150         TextRunner.h. Thanks Zeno :)
3151
3152 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3153
3154         [Qt] Prepare DRT for transition to shared TestRunner interface
3155         https://bugs.webkit.org/show_bug.cgi?id=112144
3156
3157         Reviewed by Benjamin Poulain.
3158
3159         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3160         the JSC C API based one.
3161
3162         This is impplemented by instantiating the QObject based testRunner in
3163         the global object, then instantiating the JSC C based TestRunner
3164         separately and placing it "behind" the QObject based testRunner through
3165         injection of the individual functions through proxies. (prototype
3166         chaining doesn't work due to the this object and Function.prototype.bind
3167         doesn't work due to the native function)
3168
3169         This allows for porting over method by method by removing the method
3170         from the QObject TestRunnerQt and implementing it in the JSC C based
3171         TestRunner.
3172
3173         In order for this to link and run dummy implementations of all the
3174         necessary TestRunner functions are provided.
3175
3176         * DumpRenderTree/qt/DumpRenderTree.pro:
3177         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3178         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3179         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3180         (WebCore::DumpRenderTree::initJSObjects):
3181         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3182         (DumpRenderTree):
3183         * DumpRenderTree/qt/TestRunnerQt.cpp:
3184         (TestRunner::~TestRunner):
3185         (TestRunner::addDisallowedURL):
3186         (TestRunner::queueLoad):
3187         (TestRunner::removeAllVisitedLinks):
3188         (TestRunner::setAcceptsEditing):
3189         (TestRunner::simulateLegacyWebNotificationClick):
3190         (TestRunner::setWindowIsKey):
3191         (TestRunner::setAlwaysAcceptCookies):
3192         (TestRunner::addOriginAccessWhitelistEntry):
3193         (TestRunner::setWebViewEditable):
3194         (TestRunner::clearAllApplicationCaches):
3195         (TestRunner::setTextDirection):
3196         (TestRunner::notifyDone):
3197         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3198         (TestRunner::overridePreference):
3199         (TestRunner::pathToLocalResource):
3200         (TestRunner::removeAllWebNotificationPermissions):
3201         (TestRunner::simulateWebNotificationClick):
3202         (TestRunner::closeIdleLocalStorageDatabases):
3203         (TestRunner::focusWebView):
3204         (TestRunner::setBackingScaleFactor):
3205         (TestRunner::removeChromeInputField):
3206         (TestRunner::addChromeInputField):
3207         (TestRunner::originsWithLocalStorage):
3208         (TestRunner::deleteAllLocalStorage):
3209         (TestRunner::deleteLocalStorageForOrigin):
3210         (TestRunner::observeStorageTrackerNotifications):
3211         (TestRunner::syncLocalStorage):
3212         (TestRunner::windowCount):
3213         (TestRunner::setWaitToDump):
3214         (TestRunner::waitForPolicyDelegate):
3215         (TestRunner::webHistoryItemCount):
3216         (TestRunner::showWebInspector):
3217         (TestRunner::closeWebInspector):
3218         (TestRunner::evaluateInWebInspector):
3219         (TestRunner::setSerializeHTTPLoads):
3220         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3221         (TestRunner::setCustomPolicyDelegate):
3222         (TestRunner::setDatabaseQuota):
3223         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3224         (TestRunner::resetPageVisibility):
3225         (TestRunner::keepWebHistory):
3226         (TestRunner::goBack):
3227         (TestRunner::originsWithApplicationCache):
3228         (TestRunner::applicationCacheDiskUsageForOrigin):
3229         (TestRunner::display):
3230         (TestRunner::dispatchPendingLoadRequests):
3231         (TestRunner::clearPersistentUserStyleSheet):
3232         (TestRunner::callShouldCloseOnWebView):
3233         (TestRunner::copyDecodedHostName):
3234         (TestRunner::clearBackForwardList):
3235         (TestRunner::clearAllDatabases):
3236         (TestRunner::clearApplicationCacheForOrigin):
3237         (TestRunner::apiTestGoToCurrentBackForwardItem):
3238         (TestRunner::authenticateSession):
3239         (TestRunner::abortModal):
3240         (TestRunner::setStorageDatabaseIdleInterval):
3241         (TestRunner::setAsynchronousSpellCheckingEnabled):
3242         (TestRunner::setXSSAuditorEnabled):
3243         (TestRunner::setSpatialNavigationEnabled):
3244         (TestRunner::setScrollbarPolicy):
3245         (TestRunner::setJavaScriptCanAccessClipboard):
3246         (TestRunner::setAutomaticLinkDetectionEnabled):
3247         (TestRunner::setUserStyleSheetEnabled):
3248         (TestRunner::setUserStyleSheetLocation):
3249         (TestRunner::setUseDashboardCompatibilityMode):
3250         (TestRunner::setTabKeyCyclesThroughElements):
3251         (TestRunner::setSmartInsertDeleteEnabled):
3252         (TestRunner::setSelectTrailingWhitespaceEnabled):
3253         (TestRunner::setPrivateBrowsingEnabled):
3254         (TestRunner::setPluginsEnabled):
3255         (TestRunner::setPopupBlockingEnabled):
3256         (TestRunner::setMockSpeechInputDumpRect):
3257         (TestRunner::setPersistentUserStyleSheetLocation):
3258         (TestRunner::setMockGeolocationPosition):
3259         (TestRunner::setMockGeolocationPositionUnavailableError):
3260         (TestRunner::setMockDeviceOrientation):
3261         (TestRunner::setMainFrameIsFirstResponder):
3262         (TestRunner::setIconDatabaseEnabled):
3263         (TestRunner::setGeolocationPermission):
3264         (TestRunner::setDefersLoading):
3265         (TestRunner::setCacheModel):
3266         (TestRunner::setAuthorAndUserStylesEnabled):
3267         (TestRunner::setAllowFileAccessFromFileURLs):
3268         (TestRunner::setAppCacheMaximumSize):
3269         (TestRunner::setAllowUniversalAccessFromFileURLs):
3270         (TestRunner::setApplicationCacheOriginQuota):
3271         (TestRunner::denyWebNotificationPermission):
3272         (TestRunner::grantWebNotificationPermission):
3273         (TestRunner::setValueForUser):
3274         (TestRunner::setViewModeMediaFeature):
3275         (TestRunner::setPageVisibility):
3276         (TestRunner::addMockSpeechInputResult):
3277         (TestRunner::removeOriginAccessWhitelistEntry):
3278         (TestRunner::addUserScript):
3279         (TestRunner::isCommandEnabled):
3280         (TestRunner::evaluateScriptInIsolatedWorld):
3281         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3282         (TestRunner::copyEncodedHostName):
3283         (TestRunner::addUserStyleSheet):
3284         (TestRunner::findString):
3285         (TestRunner::execCommand):
3286         (TestRunner::localStorageDiskUsageForOrigin):
3287
3288 2013-03-12  Julie Parent  <jparent@chromium.org>
3289
3290         Cleanup: Move flatten-trie to loader.
3291         https://bugs.webkit.org/show_bug.cgi?id=112196
3292
3293         Reviewed by Dirk Pranke.
3294
3295         flatten-trie is used only by the loader, so move it there and make it
3296         private, rather than global in dashbaord_base. Moved the corresponding
3297         unit test from flakiness_dashboard_unittests to loader_unittests.
3298         
3299         * TestResultServer/static-dashboards/dashboard_base.js:
3300         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3301         * TestResultServer/static-dashboards/loader.js:
3302         (.):
3303         * TestResultServer/static-dashboards/loader_unittests.js:
3304
3305 2013-03-12  Oliver Hunt  <oliver@apple.com>
3306
3307         Unbreak api tests
3308
3309         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3310         (TestWebKitAPI):
3311
3312 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3313
3314         Unreviewed, disabling tests for Win EWS.
3315
3316         win-ews obviously cannot keep up with running tests, it's >300 behind.
3317         Probably doesn't help that its (likely) running tests serially.
3318
3319         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3320         (WinEWS):
3321
3322 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3323
3324         Add a --build-directory argument to delete-stale-build-files
3325         https://bugs.webkit.org/show_bug.cgi?id=112198
3326
3327         Reviewed by Ryosuke Niwa.
3328
3329         * BuildSlaveSupport/delete-stale-build-files:
3330         (main): Add --build-directory argument.
3331
3332 2013-03-12  Oliver Hunt  <oliver@apple.com>
3333
3334         Appease MSVC
3335
3336         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3337         (TestWebKitAPI):
3338
3339 2013-03-12  Oliver Hunt  <oliver@apple.com>
3340
3341         Add more Checked<> tests
3342         https://bugs.webkit.org/show_bug.cgi?id=112190
3343
3344         Reviewed by Geoffrey Garen.
3345
3346         Tests!
3347
3348         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3349         (TestWebKitAPI):
3350
3351 2013-03-12  Julie Parent  <jparent@chromium.org>
3352
3353         Cleanup: Move loading complete function into callback, rather than global.
3354         https://bugs.webkit.org/show_bug.cgi?id=112167
3355
3356         Reviewed by Dirk Pranke.
3357         
3358         Stop calling global functions, pass in proper handler to Loader
3359         constructor. Note that the callback is optional, as tests, and
3360         some potential dashboards, do not need one.
3361
3362         * TestResultServer/static-dashboards/dashboard_base.js:
3363         * TestResultServer/static-dashboards/loader.js:
3364         (.):
3365         * TestResultServer/static-dashboards/loader_unittests.js:
3366
3367 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3368
3369         [EFL][WK2] Add popup menu support to MiniBrowser
3370         https://bugs.webkit.org/show_bug.cgi?id=108934
3371
3372         Reviewed by Kenneth Rohde Christiansen.
3373
3374         Implement popup menu support in MiniBrowser by handling popup_menu_show
3375         and popup_menu_hide smart functions on the view and using the Ewk popup
3376         menu API.
3377
3378         * MiniBrowser/efl/main.c:
3379         (_Browser_Window):
3380         (on_popup_menu_discarded):
3381         (on_popup_menu_item_clicked):
3382         (popup_menu_populate):
3383         (on_popup_menu_show):
3384         (on_popup_menu_hide):
3385         (window_create): Use calloc() instead of malloc() to allocate memory for
3386         Browser_Window. This makes sure all the structs members are initialized
3387         to 0 (such as the new elm_popup_menu pointer).
3388
3389 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3390
3391         [GTK] Set up the libPlatformGtk.la library
3392         https://bugs.webkit.org/show_bug.cgi?id=111738
3393
3394         Reviewed by Martin Robinson.
3395
3396         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3397         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
3398         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3399
3400 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3401
3402         [GTK] Enable Web Audio in development builds
3403         https://bugs.webkit.org/show_bug.cgi?id=111831
3404
3405         Reviewed by Philippe Normand.
3406
3407         Web Audio is already quite well supported on the GTK port but still has a few issues
3408         that must be addressed before it is enabled by default. Despite that it should be enabled
3409         in development builds just so we are up-to-date with future feature infrastructure changes.
3410         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3411         that's an obvious goal before enabling the feature in release builds.
3412
3413         * Scripts/webkitperl/FeatureList.pm:
3414
3415 2013-03-11  Andreas Kling  <akling@apple.com>
3416
3417         [Mac][WK1] Add support for alert() in MiniBrowser.
3418         <http://webkit.org/b/112090>
3419
3420         Reviewed by Anders Carlsson.
3421
3422         * MiniBrowser/mac/WK1BrowserWindowController.m:
3423         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3424
3425 2013-03-11  Julie Parent  <jparent@chromium.org>
3426
3427         Dashboard cleanup: Create ui.Errors
3428         https://bugs.webkit.org/show_bug.cgi?id=111785
3429
3430         Reviewed by Ojan Vafai.
3431         
3432         Create ui.Errors for handling errors the dashboards
3433         encounter. Loader now has a Error object that it can add to,
3434         and individual dashboards can show errors when desired.
3435         Currently, only flakiness_db shows errors, but this is 
3436         generic and there is no reason why other dbs wouldn't want to
3437         show errors.
3438
3439         * TestResultServer/static-dashboards/dashboard_base.js:
3440         (resourceLoadingComplete):
3441         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3442         (generatePage):
3443         * TestResultServer/static-dashboards/loader.js:
3444         (.):
3445         * TestResultServer/static-dashboards/ui.js:
3446         (.):
3447
3448 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
3449
3450         Some StringHasher tests are broken because of missing null termination
3451         https://bugs.webkit.org/show_bug.cgi?id=111284
3452
3453         Reviewed by Darin Adler.
3454
3455         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3456         (TestWebKitAPI): Added null termination since C strings are null-terminated.
3457         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
3458         the bug caught by it is now fixed.
3459
3460 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3461
3462         Unreviewed, rolling out r145200.
3463         http://trac.webkit.org/changeset/145200
3464         https://bugs.webkit.org/show_bug.cgi?id=112063
3465
3466         Broke a couple of unit tests (Requested by zdobersek on
3467         #webkit).
3468
3469         * Scripts/webkitperl/FeatureList.pm:
3470
3471 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
3472
3473         [GTK] WebKit2-only build fails
3474         https://bugs.webkit.org/show_bug.cgi?id=112033
3475
3476         Reviewed by Gustavo Noronha Silva.
3477
3478         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
3479         generic part, WebKit1-specific part and WebKit2-specific part.
3480         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
3481         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
3482         directly.
3483
3484 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
3485
3486         Adding myself to the committers list.
3487
3488         Unreviewed.
3489
3490         * Scripts/webkitpy/common/config/committers.py:
3491
3492 2013-03-11  Jeff Rogers  <jrogers@rim.com>
3493
3494         [BlackBerry] Disable MathML support
3495         https://bugs.webkit.org/show_bug.cgi?id=111929
3496
3497         Reviewed by Rob Buis.
3498
3499         * Scripts/webkitperl/FeatureList.pm:
3500
3501 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3502
3503         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
3504         https://bugs.webkit.org/show_bug.cgi?id=111970
3505
3506         Reviewed by Chris Fleizach.
3507
3508         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
3509         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
3510         undefined symbol.
3511
3512         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3513         (WTR::AccessibilityUIElement::supportedActions):
3514         (WTR):
3515
3516 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
3517
3518         [chromium] Android apk targets should depend directly on Java library targets
3519         https://bugs.webkit.org/show_bug.cgi?id=111746
3520
3521         Reviewed by Eric Seidel.
3522
3523         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3524         Make DumpRenderTree_apk depend directly on base_java and net_java.
3525         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3526         Make TestWebKitAPI_apk depend directly on base_java.
3527
3528 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
3529
3530         [chromium] remove obsolete user gesture methods from WebFrame
3531         https://bugs.webkit.org/show_bug.cgi?id=111696
3532
3533         Reviewed by Adam Barth.
3534
3535         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3536         (WebTestRunner::TestPlugin::handleInputEvent):
3537         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3538
3539 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
3540
3541         Unreviewed, add myself to commiters.py.
3542
3543         * Scripts/webkitpy/common/config/committers.py:
3544
3545 2013-03-08  Julie Parent  <jparent@chromium.org>
3546
3547         Cleanup: Remove dead code.
3548         https://bugs.webkit.org/show_bug.cgi?id=111900
3549
3550         Reviewed by Dirk Pranke.
3551         
3552         Treemap overrides a global function that used to be in 
3553         dashboard_base, but was removed months ago in
3554         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
3555         no caller. 
3556
3557         * TestResultServer/static-dashboards/treemap.html:
3558
3559 2013-03-08  Harald Alvestrand  <hta@chromium.org>
3560
3561         Implemented new API for RTCStatsReport object.
3562         https://bugs.webkit.org/show_bug.cgi?id=110333
3563
3564         Reviewed by Adam Barth.
3565
3566         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3567         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
3568
3569 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
3570
3571         [chromium] use custom freetype on linux asan builds again
3572         https://bugs.webkit.org/show_bug.cgi?id=111884
3573
3574         Reviewed by Tony Chang.
3575
3576         We no longer need the workaround after chromium r186540.
3577
3578         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3579
3580 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
3581
3582         Warning about the user not having edit rights on Bugzilla is confusing new contributors
3583         https://bugs.webkit.org/show_bug.cgi?id=111798
3584
3585         Reviewed by Dirk Pranke.
3586
3587         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
3588
3589         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3590
3591 2013-03-08  James Robinson  <jamesr@chromium.org>
3592
3593         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
3594         https://bugs.webkit.org/show_bug.cgi?id=111632
3595
3596         Reviewed by Adrienne Walker.
3597
3598         * DumpRenderTree/chromium/WebViewHost.cpp:
3599         (WebViewHost::initializeLayerTreeView):
3600         * DumpRenderTree/chromium/WebViewHost.h:
3601         (WebViewHost):
3602
3603 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
3604
3605         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
3606         https://bugs.webkit.org/show_bug.cgi?id=111297
3607
3608         Reviewed by Kenneth Rohde Christiansen.
3609
3610         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3611         (WTR::TestRunner::setViewModeMediaFeature):
3612
3613 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
3614
3615         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
3616         https://bugs.webkit.org/show_bug.cgi?id=111814
3617
3618         Reviewed by Ryosuke Niwa.
3619
3620         Add the needed supportedActions() attribute to WKTestRunner.
3621
3622         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3623         (WTR::AccessibilityUIElement::supportedActions):
3624         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3625         (AccessibilityUIElement):
3626         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3627         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3628         (WTR::AccessibilityUIElement::supportedActions):
3629
3630 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3631
3632         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
3633         https://bugs.webkit.org/show_bug.cgi?id=111851
3634
3635         Reviewed by Kenneth Rohde Christiansen.
3636
3637         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3638         (TestWebKitAPI::TEST):
3639
3640             Fixed WKURLRef instance leaking.
3641
3642 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3643
3644         [EFL] [WK2] Some authentication tests fail in WebKit2
3645         https://bugs.webkit.org/show_bug.cgi?id=106407
3646
3647         Reviewed by Kenneth Rohde Christiansen.
3648
3649         Add patch from upstream for libsoup 2.40 to fix several authentication
3650         test cases.
3651
3652         * efl/jhbuild.modules:
3653         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
3654
3655 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
3656
3657         [GTK] Enable Web Audio in development builds
3658         https://bugs.webkit.org/show_bug.cgi?id=111831
3659
3660         Reviewed by Philippe Normand.
3661
3662         Web Audio is already quite well supported on the GTK port but still has a few issues
3663         that must be addressed before it is enabled by default. Despite that it should be enabled
3664         in development builds just so we are up-to-date with future feature infrastructure changes.
3665         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3666         that's an obvious goal before enabling the feature in release builds.
3667
3668         * Scripts/webkitperl/FeatureList.pm:
3669
3670 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3671
3672         [chromium] delay clearing the TestRunners until the main view was deleted
3673         https://bugs.webkit.org/show_bug.cgi?id=111823
3674
3675         Reviewed by Eric Seidel.
3676
3677         During WebViewHost::shutdown, we navigate the WebView to about:blank.
3678         This may call into the test runners which assume that the delegate is
3679         always non-NULL.
3680
3681         * DumpRenderTree/chromium/TestShell.cpp:
3682         (TestShell::~TestShell):
3683
3684 2013-03-07  Alan Cutter  <alancutter@chromium.org>
3685
3686         Sheriffbot whois command can't search by full name
3687         https://bugs.webkit.org/show_bug.cgi?id=111825
3688
3689         Reviewed by Eric Seidel.
3690
3691         Allowed multiple arguments to Sheriffbot's whois command.
3692         Updated test expectations.
3693
3694         * Scripts/webkitpy/tool/bot/irc_command.py:
3695         (Whois.execute):
3696         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3697         (IRCCommandTest.test_whois):
3698
3699 2013-03-07  Nils Barth  <nbarth@chromium.org>
3700
3701         Add Nils Barth and Koji Hara to committers.py
3702         https://bugs.webkit.org/show_bug.cgi?id=111806
3703
3704         Reviewed by Eric Seidel.
3705
3706         * Scripts/webkitpy/common/config/committers.py:
3707
3708 2013-03-07  Glenn Adams  <glenn@skynav.com>
3709
3710         run-pert-tests should have a --test-runner-count option
3711         https://bugs.webkit.org/show_bug.cgi?id=111726
3712
3713         Reviewed by Ryosuke Niwa.
3714
3715         Add --test-runner-count option to run-perf-tests, with default value of 4.
3716         This option allows command line configuration of the number of times to invoke
3717         the test runner (serially, not in parallel) when running a specific test in
3718         a test set.
3719
3720         * Scripts/webkitpy/performance_tests/perftest.py:
3721         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
3722         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
3723         (PerfTest.run): Rename process_run_count to test_runner_count.
3724         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
3725         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
3726         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
3727         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
3728         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3729         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
3730         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
3731         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3732         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
3733         (MainTest.test_run_with_repeat):
3734         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
3735         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3736         (MainTest.test_default_args): Add test for default option argument values.
3737         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
3738
3739 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
3740
3741         Add myself to reviewers.py
3742         https://bugs.webkit.org/show_bug.cgi?id=111757
3743
3744         Reviewed by Eric Seidel.
3745
3746         * Scripts/webkitpy/common/config/committers.py:
3747
3748 2013-03-07  Glenn Adams  <glenn@skynav.com>
3749
3750         run-perf-tests should have a --repeat option
3751         https://bugs.webkit.org/show_bug.cgi?id=100030
3752
3753         Reviewed by Ryosuke Niwa.
3754
3755         Add --repeat option to run-perf-tests, with default value of 1. When greater
3756         than 1, runs test set specified number of times. Note that multiple runs are
3757         not aggregated for statistical purposes.
3758
3759         Incidentally fixed typo: s/suceeds/succeeds/.
3760
3761         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3762         (PerfTestsRunner._parse_args): Add repeat option.
3763         (PerfTestsRunner.run): Add outer repeat loop.
3764         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
3765         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
3766         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3767         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
3768         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
3769         (MainTest.test_run_with_json_output): Fix typo.
3770         (MainTest.test_run_with_description): Fix typo.
3771         (MainTest.test_run_respects_no_results): Fix typo.
3772         (MainTest.test_run_with_slave_config_json): Fix typo.
3773         (MainTest.test_run_with_multiple_repositories): Fix typo.
3774         (MainTest.test_run_with_upload_json): Fix typo.
3775         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
3776         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
3777         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3778         (MainTest.test_parse_args): Add test for repeat option parsing.
3779
3780 2013-03-07  Julie Parent  <jparent@chromium.org>
3781
3782         showAllRuns checkbox no longer works on the stats dashboard
3783         https://bugs.webkit.org/show_bug.cgi?id=111673
3784
3785         Reviewed by Ojan Vafai.
3786
3787         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
3788         so we were trying to index into an undefined object.
3789         
3790         * TestResultServer/static-dashboards/dashboard_base.js:
3791         (invalidateQueryParameters):
3792
3793 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
3794
3795         [Chromium] Update #include for WebStorageNamespace.h
3796         https://bugs.webkit.org/show_bug.cgi?id=111748
3797
3798         Reviewed by Adam Barth.
3799
3800         In anticipation of removing
3801         WK/chromium/public/WebStorageNamespace.h (once downstream
3802         references have been updated)
3803
3804         * DumpRenderTree/chromium/WebViewHost.cpp:
3805
3806 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3807
3808         run-perf-tests fails due to svn_revision not working on a pure git clone
3809         https://bugs.webkit.org/show_bug.cgi?id=110839
3810
3811         Reviewed by Ryosuke Niwa.
3812
3813         Previously we would call git svn find-rev to look up the commit for
3814         a given revision, and that'll hang in a pure git checkout.
3815
3816         This patch changes the way we look up svn revisions in a git
3817         repository to use git log --grep 'git-svn-id', which is much faster
3818         than grepping ourselves. It also renames timestamp_of_latest_commit()
3819         to timestamp_of_revision() in order to accurately reflect what
3820         the method is doing. Note that this patch only changes the logic
3821         inside latest_revision() and svn_revision(). I'll file a separate
3822         bug to change git_commit_from_svn_revision().
3823
3824         This patch also contains some fixes to unit tests that had bit-rotted
3825         or were otherwise fragile, so that test-webkitpy --all would pass
3826         cleanly, and a fix to outputcapture so that
3827         test-webkitpy -p would work correctly again.
3828
3829         * Scripts/webkitpy/common/checkout/scm/git.py:
3830         (Git.svn_revision):
3831         (Git.timestamp_of_revision):
3832         * Scripts/webkitpy/common/checkout/scm/scm.py:
3833         (SCM.svn_revision):
3834         (SCM.timestamp_of_revision):
3835         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3836         (MockSCM.timestamp_of_revision):
3837         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3838         (_shared_test_commit_with_message):
3839         (test_commit_without_authorization):
3840         (test_timestamp_of_revision):
3841         * Scripts/webkitpy/common/checkout/scm/svn.py:
3842         (SVN.timestamp_of_revision):
3843         * Scripts/webkitpy/common/system/outputcapture.py:
3844           Importing unittest2 directly may not be safe if this module is
3845           imported before the autoinstaller gets a chance to set things up
3846           properly. We don't actually need unittest2 here.
3847         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3848         (PerfTestsRunner._generate_results_dict):
3849
3850 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3851
3852         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
3853         https://bugs.webkit.org/show_bug.cgi?id=111756
3854
3855         Reviewed by Kenneth Rohde Christiansen.
3856
3857         Bump libsoup to v2.40.3 to fix the regressions introduced by
3858         previous v2.40.0 bump.
3859
3860         * efl/jhbuild.modules:
3861
3862 2013-03-07  Roger Fong  <roger_fong@apple.com>
3863
3864         Re-enable Win EWS tests.
3865
3866         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3867         (WinEWS):
3868
3869 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3870
3871         [nrwt] handle corrupt http server pid files cleanly
3872         https://bugs.webkit.org/show_bug.cgi?id=111628
3873
3874         Reviewed by Eric Seidel.
3875
3876         If the pid file from a previous http server is corrupt for some
3877         reason, NRWT will just raise errors and not clean it up or recover.
3878         This patch fixes that to at least delete the pid file and
3879         not throw; not that we may still have stale http servers left on
3880         the system, since there's no way to know which pid to kill if
3881         the file was corrupted.
3882
3883         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3884         (HttpServerBase.start):
3885         (HttpServerBase.stop):
3886         (HttpServerBase._remove_pid_file):
3887         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
3888         (TestHttpServerBase):
3889         (TestHttpServerBase.test_corrupt_pid_file):
3890
3891 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
3892
3893         AX: Can't activate links with VoiceOver in Safari
3894         https://bugs.webkit.org/show_bug.cgi?id=111755
3895
3896         Reviewed by Tim Horton.
3897
3898         * DumpRenderTree/AccessibilityUIElement.cpp:
3899         (supportedActionsCallback):
3900         (AccessibilityUIElement::getJSClass):
3901         * DumpRenderTree/AccessibilityUIElement.h:
3902         (AccessibilityUIElement):
3903         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3904         (AccessibilityUIElement::supportedActions):
3905
3906 2013-03-07  Roger Fong  <roger_fong@apple.com>
3907
3908         Windows debug layout tests are crashing like crazy again.
3909         Disable tests on Win EWS bots temporarily.
3910
3911         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3912         (WinEWS):
3913
3914 2013-03-07  Roger Fong  <roger_fong@apple.com>
3915
3916         Make EWS bots build and test in release.
3917
3918         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3919         (WinEWS):
3920         * Scripts/webkitpy/tool/steps/runtests.py:
3921         (RunTests.run):
3922
3923 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3924
3925         [chromium] don't track the top loading frame if no layout test is currently running
3926         https://bugs.webkit.org/show_bug.cgi?id=111716
3927
3928         Reviewed by Kentaro Hara.
3929
3930         In DRT, we synchronously stop the test and start loading the next test
3931         URL. However, in content_shell, this happens asynchronously. It's
3932         important that the top loading frame is not changed due to stray
3933         navigation events before the next test starts.
3934
3935         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3936         (WebTestRunner::TestRunner::setTopLoadingFrame):
3937
3938 2013-03-06  Julie Parent  <jparent@chromium.org>
3939
3940         Dashboard cleanup: Move all dashboard ui related code into ui.js.
3941         https://bugs.webkit.org/show_bug.cgi?id=111621
3942
3943         Reviewed by Ojan Vafai.
3944         
3945         Creates ui.js, a package for the common UI code the various
3946         dashboards use. HTML generation is now in the ui.html namespace
3947         and popup handling is in ui.popup.
3948         Also moves the event listening for popups to ui.popup.show and
3949         removes it on ui.popup.hid rather than having listener always
3950         around.
3951
3952         * TestResultServer/static-dashboards/aggregate_results.html:
3953         * TestResultServer/static-dashboards/dashboard_base.js:
3954         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3955         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3956         (showPopupForBuild):
3957         (htmlForNavBar):
3958         (generatePageForIndividualTests.if):
3959         (generatePageForIndividualTests):
3960         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
3961         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3962         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3963         * TestResultServer/static-dashboards/run-unittests.html:
3964         * TestResultServer/static-dashboards/timeline_explorer.html:
3965         * TestResultServer/static-dashboards/treemap.html:
3966         * TestResultServer/static-dashboards/ui.js: Added.
3967         (.):
3968
3969 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
3970
3971         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
3972         https://bugs.webkit.org/show_bug.cgi?id=110584
3973
3974         Reviewed by Gyuyoung Kim.
3975
3976         Adds missing implementation of AccessibilityControllerEfl
3977         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
3978         so that it can make accessibilityController as a js object.
3979
3980         * DumpRenderTree/AccessibilityController.h:
3981         (AccessibilityController):
3982         * DumpRenderTree/AccessibilityUIElement.h:
3983         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3984         (AccessibilityController::childElementById): Moved declaration to base class.
3985         Implementation can be shared among other ports.
3986         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
3987         (AccessibilityController::focusedElement):
3988         (AccessibilityController::rootElement):
3989         (AccessibilityController::accessibleElementById):
3990         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
3991         (AccessibilityUIElement::helpText):
3992         * DumpRenderTree/efl/CMakeLists.txt:
3993         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3994         (DumpRenderTreeChrome::DumpRenderTreeChrome):
3995         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3996         (DumpRenderTreeChrome::onWindowObjectCleared):
3997         (DumpRenderTreeChrome::accessibilityController):
3998         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3999         (DumpRenderTreeChrome):
4000         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
4001
4002 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
4003
4004         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
4005         https://bugs.webkit.org/show_bug.cgi?id=42696
4006
4007         Reviewed by Andreas Kling.
4008
4009         * DumpRenderTree/TestRunner.cpp:
4010         (TestRunner::staticFunctions):
4011         * DumpRenderTree/TestRunner.h:
4012         (TestRunner):
4013         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4014         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4015         (WebTestRunner::TestRunner::TestRunner):
4016         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4017         (TestRunner):
4018         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4019         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4020         * DumpRenderTree/mac/TestRunnerMac.mm:
4021         * DumpRenderTree/qt/TestRunnerQt.cpp:
4022         * DumpRenderTree/qt/TestRunnerQt.h:
4023         (TestRunnerQt):
4024         * DumpRenderTree/win/TestRunnerWin.cpp:
4025         * DumpRenderTree/wx/TestRunnerWx.cpp:
4026
4027 2013-03-06  Roger Fong  <roger_fong@apple.com>
4028
4029         Re-enable WinEWS test and decrease iterations before clean build back to 10.
4030
4031         * EWSTools/start-queue-win.sh:
4032         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4033         (WinEWS):
4034
4035 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
4036
4037         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
4038         https://bugs.webkit.org/show_bug.cgi?id=82866
4039
4040         Reviewed by Martin Robinson.
4041
4042         * Scripts/run-gtk-tests:
4043         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
4044         it is passing now.
4045
4046 2013-03-06  Julie Parent  <jparent@chromium.org>
4047
4048         Dashboard cleanup: remove dashboard time logging.
4049         https://bugs.webkit.org/show_bug.cgi?id=111608
4050
4051         Reviewed by Dirk Pranke.
4052
4053         Remove logTime.  It was never accurate, and the dev tools
4054         have better ways to measure this if anyone cares to look
4055         into dashboard perf.
4056         
4057         * TestResultServer/static-dashboards/dashboard_base.js:
4058         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4059         (processTestRunsForBuilder):
4060         (appendHTML):
4061
4062 2013-03-06  Tony Chang  <tony@chromium.org>
4063
4064         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
4065         https://bugs.webkit.org/show_bug.cgi?id=111509
4066
4067         Reviewed by Dirk Pranke.
4068
4069         Add DumpRenderTree.pak to DumpRenderTree.app again.
4070
4071         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4072
4073 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
4074
4075         [chromium] introduce WebUserGestureIndicator
4076         https://bugs.webkit.org/show_bug.cgi?id=111531
4077
4078         Reviewed by Adam Barth.
4079
4080         * DumpRenderTree/chromium/WebViewHost.cpp:
4081         (WebViewHost::createView):
4082
4083 2013-03-06  Alan Cutter  <alancutter@chromium.org>
4084
4085         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
4086         https://bugs.webkit.org/show_bug.cgi?id=73482
4087
4088         Reviewed by Ryosuke Niwa.
4089
4090         Added input checking to the UpdateChromiumDEPS step.
4091         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
4092
4093         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
4094         (RollChromiumDEPS):
4095         (RollChromiumDEPS._parse_args):
4096         (RollChromiumDEPS.execute):
4097         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
4098         (IRCCommandTest.test_roll_chromium_deps):
4099         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
4100         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
4101         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
4102         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
4103         (UpdateChromiumDEPS._fetch_last_known_good_revision):
4104         (UpdateChromiumDEPS):
4105         (UpdateChromiumDEPS._parse_revision_number):
4106         (UpdateChromiumDEPS._validate_revisions):
4107         (UpdateChromiumDEPS.run):
4108         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
4109         (UpdateChromiumDEPSTest):
4110         (UpdateChromiumDEPSTest.test_parse_revision_number):
4111         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
4112         (RollChromiumDEPS):
4113         (PostChromiumDEPSRoll):
4114
4115 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
4116
4117         [Qt][MiniBrowser] Touch mocking broken for chained getures
4118         https://bugs.webkit.org/show_bug.cgi?id=111430
4119
4120         Reviewed by Jocelyn Turcotte.
4121
4122         Make it possible again to use touch mocking to test gesture chains
4123         like pan->pinch->pan->pinch without lifting the primary "finger".
4124         For this to work we need to track the pressed mouse buttons and
4125         only synthesize touch release events when the ctrl key is released
4126         if no mouse button is pressed. Else the pressed mouse button(s)
4127         should result in a stationary touch point in a touch update event.
4128         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
4129         to check for the state of the ctrl key modifier instead of getting
4130         it from the mouse events.
4131
4132         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4133         (MiniBrowserApplication::MiniBrowserApplication):
4134         (MiniBrowserApplication::notify):
4135
4136 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4137
4138         [chromium] don't use custom freetype on linux asan for now
4139         https://bugs.webkit.org/show_bug.cgi?id=111516
4140
4141         Unreviewed, build fix.
4142
4143         Turns out the custom lib is getting picked up by other binaries
4144         on our bot, which is bad.
4145
4146         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4147
4148 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4149
4150         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
4151         https://bugs.webkit.org/show_bug.cgi?id=111509
4152
4153         Unreviewed, build fix.
4154
4155         Actually comment out the flag :(.
4156
4157         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4158
4159 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4160
4161         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
4162         https://bugs.webkit.org/show_bug.cgi?id=111509
4163
4164         Unreviewed, build fix.
4165
4166         r144863 appears to have broken the xcode build; I'm temporarily
4167         trying this instead, and if this doesn't work, I'll revert the
4168         other changes.
4169
4170         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4171
4172 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4173
4174         [chromium] build a DumpRenderTree.pak even on windows
4175         https://bugs.webkit.org/show_bug.cgi?id=111504
4176
4177         Reviewed by Tony Chang.
4178
4179         The Chromium Aura build uses the default theme to draw
4180         controls, and that theme requires the ui ResourceBundle
4181         to be initialized. On every other platform, we build
4182         a DumpRenderTree.pak that works for this, but on Windows we
4183         still compile the resources directly into DRT. As a first step,
4184         let's build the pak file. I will then need to land a patch
4185         in Chromium to actually load it. Then I can go back and move
4186         the resources over to just use the .pak file and no longer need
4187         the .rc's.
4188
4189         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4190
4191 2013-03-05  Julie Parent  <jparent@chromium.org>
4192         Dashboard cleanup: move string utilities into their own namespace.
4193         
4194         https://bugs.webkit.org/show_bug.cgi?id=111485
4195
4196         Reviewed by Ojan Vafai.
4197         
4198         One of many pieces to clean up dashboard_base.
4199         
4200         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
4201
4202         * TestResultServer/static-dashboards/aggregate_results.html:
4203         * TestResultServer/static-dashboards/dashboard_base.js:
4204         (isTreeMap):
4205         (isFlakinessDashboard):
4206         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4207         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4208         (determineWKPlatform):
4209         (chromiumPlatform):
4210         (platformAndBuildType):
4211         (substringList):
4212         (individualTestsForSubstringList):
4213         (filterBugs):
4214         (populateExpectationsData):
4215         (processMissingTestsWithExpectations):
4216         (processMissingAndExtraExpectations):
4217         (htmlForSingleTestRow):
4218         (.dummyNode.onload):
4219         (expectationsTitle):
4220         * TestResultServer/static-dashboards/run-embedded-unittests.html:
4221         * TestResultServer/static-dashboards/run-unittests.html:
4222         * TestResultServer/static-dashboards/string.js: Added.
4223         * TestResultServer/static-dashboards/timeline_explorer.html:
4224         * TestResultServer/static-dashboards/treemap.html:
4225
4226 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
4227
4228         [EFL] Build break with latest EFL libraries
4229         https://bugs.webkit.org/show_bug.cgi?id=111028
4230
4231         Reviewed by Dirk Pranke.
4232
4233         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
4234         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
4235         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
4236
4237 2013-03-05  Roger Fong  <roger_fong@apple.com>
4238
4239         Increase number of WinEWS iterations to 20.
4240         Don't reboot after each iteration set.
4241         Make EWS bots just build temporarily so that the queue catches up again.
4242
4243         * EWSTools/start-queue-win.sh:
4244         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4245         (WinEWS):
4246
4247 2013-03-04  James Robinson  <jamesr@chromium.org>
4248
4249         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
4250         https://bugs.webkit.org/show_bug.cgi?id=111386
4251
4252         Reviewed by Adrienne Walker.
4253
4254         * DumpRenderTree/chromium/TestShell.cpp:
4255         (TestShell::initialize):
4256
4257 2013-03-05  Min Qin  <qinmin@chromium.org>
4258
4259         Copy dictionary to the external storage before running layout test on android
4260         https://bugs.webkit.org/show_bug.cgi?id=111480
4261
4262         Reviewed by Adam Barth.
4263
4264         TestWebKitPlatformSupport now needs to read an external dictionary file.
4265         This file does not exist on the device. We need to copy it before running layout tests.
4266
4267         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4268         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
4269         (ChromiumAndroidDriver._push_platform_resources):
4270
4271 2013-03-05  Dirk Pranke  <dpranke@chromium.org>