[ews-app] while waiting in queue status-bubble for testers queues should display...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
4         https://bugs.webkit.org/show_bug.cgi?id=196618
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
9         (StatusBubble): Added QUEUE_TRIGGERS.
10         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
11         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
12         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
13         its parent(builder).
14
15 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
16
17         [ews-app] Status-bubble steps are sometimes displayed in reverse order
18         https://bugs.webkit.org/show_bug.cgi?id=196625
19
20         Reviewed by Lucas Forschler.
21
22         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
23         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
24
25 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
26
27         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
28         https://bugs.webkit.org/show_bug.cgi?id=196630
29
30         Reviewed by Wenson Hsieh.
31
32         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
33
34 2019-04-04  Youenn Fablet  <youenn@apple.com>
35
36         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
37         https://bugs.webkit.org/show_bug.cgi?id=196543
38
39         Reviewed by Alex Christensen.
40
41         * WebKitTestRunner/TestController.cpp:
42         (WTR::TestController::generatePageConfiguration):
43
44 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
45
46         [ews-app] Status bubble should not display skipped buildbot steps
47         https://bugs.webkit.org/show_bug.cgi?id=196584
48
49         Reviewed by Lucas Forschler.
50
51         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
52
53 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
54
55         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
56         https://bugs.webkit.org/show_bug.cgi?id=196620
57
58         Reviewed by Lucas Forschler.
59
60         * BuildSlaveSupport/ews-app/ews/config.py:
61
62 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
63
64         [Win] DumpRenderTreeWatchDog.py is not checked into source
65         https://bugs.webkit.org/show_bug.cgi?id=196567
66         <rdar://problem/49525901>
67
68         Reviewed by Lucas Forschler.
69
70         This script is used on Win EWS bots to terminate hanging DRT processes.
71
72         * EWSTools/dumprendertreewatchdog.py: Added.
73
74 2019-04-04  Chris Dumez  <cdumez@apple.com>
75
76         Unreviewed, roll out r243858 which made tests time out.
77
78         Disable new API tests on Windows instead.
79
80         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
81         (TestWebKitAPI::TEST):
82
83 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
84
85         [ATK] Cleanup WebPageAccessibilityObjectAtk
86         https://bugs.webkit.org/show_bug.cgi?id=196537
87
88         Reviewed by Michael Catanzaro.
89
90         Also consider files under atk directories as exceptions for GObject conventions.
91
92         * Scripts/webkitpy/style/checkers/cpp.py:
93         (check_identifier_name_in_declaration):
94
95 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
96
97         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
98         https://bugs.webkit.org/show_bug.cgi?id=196588
99         <rdar://problem/49365787>
100
101         Unreviewed build fix for Windows port.
102
103         error C3861: 'kill': identifier not found
104
105         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
106         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
107
108 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
109
110         [ews-build] Cancel build and similar operations should have authentication
111         https://bugs.webkit.org/show_bug.cgi?id=196520
112
113         Reviewed by Dewei Zhu.
114
115         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
116         environment variables.
117
118 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
119
120         [ews-build] Do not trigger queues which are not in production yet
121         https://bugs.webkit.org/show_bug.cgi?id=196581
122
123         Reviewed by Dewei Zhu.
124
125         * BuildSlaveSupport/ews-build/config.json:
126
127 2019-04-03  Chris Dumez  <cdumez@apple.com>
128
129         Unreviewed, fix typo in the name of API test added in r243848.
130
131         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
132         (TestWebKitAPI::TEST):
133
134 2019-04-03  Chris Dumez  <cdumez@apple.com>
135
136         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
137         https://bugs.webkit.org/show_bug.cgi?id=196588
138         <rdar://problem/49365787>
139
140         Reviewed by Ryosuke Niwa.
141
142         Add API test coverage.
143
144         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
145         (TestWebKitAPI::nullJavaScriptCallback):
146         (TestWebKitAPI::didCrashCheckFrames):
147         (TestWebKitAPI::TEST):
148
149 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
150
151         run-webkit-tests: Upload test results (new results database)
152         https://bugs.webkit.org/show_bug.cgi?id=196577
153         <rdar://problem/34841155>
154
155         Reviewed by Lucas Forschler.
156
157         * Scripts/webkitpy/layout_tests/controllers/manager.py:
158         (Manager.run): Upload results after each device shard, since the configuration will be
159         different for each device.
160         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
161         uploaded to a results database.
162         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
163         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
164
165 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
166
167         -apple-trailing-word is needed for browser detection
168         https://bugs.webkit.org/show_bug.cgi?id=196575
169
170         Unreviewed.
171
172         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
173
174 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
175
176         [CMake][WTF] Mirror XCode header directories
177         https://bugs.webkit.org/show_bug.cgi?id=191662
178
179         Reviewed by Konstantin Tokarev.
180
181         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
182         builds.
183
184         * CMakeLists.txt:
185         * DumpRenderTree/CMakeLists.txt:
186         * DumpRenderTree/PlatformWin.cmake:
187         * MiniBrowser/win/CMakeLists.txt:
188         * TestWebKitAPI/CMakeLists.txt:
189         * TestWebKitAPI/PlatformWin.cmake:
190         * WebKitTestRunner/PlatformGTK.cmake:
191         * WebKitTestRunner/PlatformWin.cmake:
192
193 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
194
195         [ews-app] Status bubble should not display certain infrastructure status messages
196         https://bugs.webkit.org/show_bug.cgi?id=196550
197
198         Reviewed by Lucas Forschler.
199
200         Do not display the steps which are un-needed for end-user. This information is still avaiable
201         if the user click on the bubble and look at the Buildbot build.
202         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
203         (StatusBubble._steps_messages):
204         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
205
206 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
207
208         [ews-build] Use https for sending data to ews-app
209         https://bugs.webkit.org/show_bug.cgi?id=196492
210
211         Reviewed by Lucas Forschler.
212
213         * BuildSlaveSupport/ews-build/events.py:
214
215 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
216
217         Remove support for -apple-trailing-word
218         https://bugs.webkit.org/show_bug.cgi?id=196525
219
220         Reviewed by Zalan Bujtas.
221
222         This CSS property is nonstandard and not used.
223
224         * Scripts/webkitperl/FeatureList.pm:
225         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
226
227 2019-04-03  Youenn Fablet  <youenn@apple.com>
228
229         Add a test for DOMCache on multiple browsing in case of private browsing
230         https://bugs.webkit.org/show_bug.cgi?id=196524
231
232         Reviewed by Alex Christensen.
233
234         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
235         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
236
237 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
238
239         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
240         https://bugs.webkit.org/show_bug.cgi?id=196540
241
242         Reviewed by Aakash Jain.
243
244         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
245
246 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
247
248         Add plumbing for a compatibility mode preference in WebKit
249         https://bugs.webkit.org/show_bug.cgi?id=196005
250
251         Reviewed by Tim Horton.
252
253         Add new API tests.
254
255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
256         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
257
258 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
259
260         [WPE][GTK] Update libsrtp dependency package for Debian
261         https://bugs.webkit.org/show_bug.cgi?id=196528
262
263         Reviewed by Frédéric Wang.
264
265         * gtk/install-dependencies:
266         * wpe/install-dependencies:
267
268 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
269
270         [WK2] Add support for Window's beforeprint / afterprint events
271         https://bugs.webkit.org/show_bug.cgi?id=196478
272         <rdar://problem/49535124>
273
274         Unreviewed build fix for MSVC.
275
276         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
277
278         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
279
280         * WebKitTestRunner/TestController.cpp:
281         (WTR::printFrame): Use int and float literals.
282
283 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
284
285         [ews-build] Reassign bots to queues
286
287         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
288
289 2019-04-02  Chris Dumez  <cdumez@apple.com>
290
291         [WK2] Add support for Window's beforeprint / afterprint events
292         https://bugs.webkit.org/show_bug.cgi?id=196478
293
294         Reviewed by Alex Christensen.
295
296         Add minimal implementation for printFrame in WebKitTestRunner.
297
298         * WebKitTestRunner/TestController.cpp:
299         (WTR::printFrame):
300         (WTR::TestController::createOtherPage):
301         (WTR::TestController::createWebViewWithOptions):
302
303 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
304
305         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
306         https://bugs.webkit.org/show_bug.cgi?id=196491
307
308         Reviewed by Lucas Forschler.
309
310         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
311
312 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
313
314         [ews-build] Configure buildbot try credentials in environment variables
315         https://bugs.webkit.org/show_bug.cgi?id=196501
316
317         Reviewed by Lucas Forschler.
318
319         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
320         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
321         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
322
323 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
324
325         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
326         https://bugs.webkit.org/show_bug.cgi?id=196496
327         <rdar://problem/49521634>
328
329         Reviewed by Chris Dumez.
330
331         Add new API tests (see WebKit ChangeLog for more detail).
332
333         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
334         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
335         (TEST):
336
337 2019-04-02  David Kilzer  <ddkilzer@apple.com>
338
339         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
340         <https://webkit.org/b/196499>
341
342         Reviewed by Alexey Proskuryakov.
343
344         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
345         ENABLE_ADDRESS_SANITIZER.
346
347 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
348
349         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
350         https://bugs.webkit.org/show_bug.cgi?id=182757
351
352         Reviewed by Don Olmstead.
353
354         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
355         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
356
357 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
358
359         run-api-tests: Upload test results
360         https://bugs.webkit.org/show_bug.cgi?id=196323
361         <rdar://problem/49356714>
362
363         Reviewed by Lucas Forschler.
364
365         * Scripts/webkitpy/api_tests/manager.py:
366         (Manager):
367         (Manager.run): Upload results to a results database.
368         * Scripts/webkitpy/api_tests/run_api_tests.py:
369         (parse_args): Add upload arguments.
370         * Scripts/webkitpy/port/base.py:
371         (Port):
372         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
373         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
374         with commits from any other associated repositories.
375         * Scripts/webkitpy/port/device.py:
376         (Device):
377         (Device.build_version): Access build_versoin of underlying platform device.
378         * Scripts/webkitpy/port/ios_simulator_unittest.py:
379         (IOSSimulatorTest):
380         (IOSSimulatorTest.test_configuration_for_upload):
381         * Scripts/webkitpy/port/device_port.py:
382         (DevicePort):
383         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
384         the same as the machine uploading results.
385         * Scripts/webkitpy/port/mac.py:
386         (MacPort):
387         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
388         * Scripts/webkitpy/port/mac_unittest.py:
389         (MacTest):
390         (MacTest.test_configuration_for_upload):
391         * Scripts/webkitpy/xcode/simulated_device.py:
392         (SimulatedDeviceManager._create_device_with_runtime):
393         (SimulatedDevice.__init__): Create simulated device with a build_version.
394         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
395         (test_existing_simulator):
396
397 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
398
399         Remove extra newline characters (Follow-up fix to r243707)
400
401         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
402
403 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
404
405         [ews-app] Use API_KEY to accept results data
406         https://bugs.webkit.org/show_bug.cgi?id=196461
407
408         Reviewed by Dewei Zhu.
409
410         * BuildSlaveSupport/ews-app/ews/views/results.py:
411         (Results.post): Validate EWS_API_KEY before accepting any data.
412         * BuildSlaveSupport/ews-build/events.py:
413         (Events.sendData): Send EWS_API_KEY if available along with event data.
414
415 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
416
417         Unable to copy and paste a PDF from Notes into Mail compose body
418         https://bugs.webkit.org/show_bug.cgi?id=196442
419         <rdar://problem/48573098>
420
421         Reviewed by Tim Horton.
422
423         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
424         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
425         to be specified on the item providers.
426
427         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
428         (TestWebKitAPI::mapItemForTesting):
429         (TestWebKitAPI::contactItemForTesting):
430
431 2019-04-01  Tim Horton  <timothy_horton@apple.com>
432
433         Make UIWKDocumentContext rects per-character instead of per-word
434         https://bugs.webkit.org/show_bug.cgi?id=196459
435
436         Reviewed by Wenson Hsieh.
437
438         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
439         (TEST):
440         Adjust test results due to switching to per-character rects.
441
442 2019-04-01  Chris Dumez  <cdumez@apple.com>
443
444         UIProcess crash when a prewarmed process is terminated
445         https://bugs.webkit.org/show_bug.cgi?id=196451
446         <rdar://problem/49245471>
447
448         Reviewed by Geoffrey Garen.
449
450         Add API test coverage.
451
452         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
453         (TEST):
454
455 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
456
457         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
458         https://bugs.webkit.org/show_bug.cgi?id=196449
459
460         Reviewed by Lucas Forschler.
461
462         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
463         (StatusBubble.get_os_details): Method to get OS and Xcode details.
464         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
465         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
466
467 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
468
469         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
470         https://bugs.webkit.org/show_bug.cgi?id=196444
471
472         Reviewed by Lucas Forschler.
473
474         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
475
476 2019-04-01  Alex Christensen  <achristensen@webkit.org>
477
478         Add SPI to canonicalize NSURLs with WTF::URL
479         https://bugs.webkit.org/show_bug.cgi?id=196415
480         <rdar://problem/44980271>
481
482         Reviewed by Darin Adler.
483
484         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
485         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
486         (TestWebKitAPI::TEST):
487
488 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
489
490         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
491         https://bugs.webkit.org/show_bug.cgi?id=196441
492
493         Reviewed by Carlos Garcia Campos.
494
495         Don't cache the wpe_view_backend object that might not exist yet at the
496         time of EventSenderProxy constructor invocation, but instead retrieve
497         that object whenever it's required for event dispatching. This should
498         avoid crashes in this constructor now that it's invoked before any
499         PlatformWindow has been set up (as changed in r243496).
500
501         * WebKitTestRunner/EventSenderProxy.h:
502         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
503         (WTR::viewBackend):
504         (WTR::EventSenderProxy::EventSenderProxy):
505         (WTR::EventSenderProxy::mouseDown):
506         (WTR::EventSenderProxy::mouseUp):
507         (WTR::EventSenderProxy::mouseMoveTo):
508         (WTR::EventSenderProxy::mouseScrollBy):
509         (WTR::EventSenderProxy::keyDown):
510         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
511
512 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
513
514         [Win][WebKit] MiniBrowser should support high DPI display
515         https://bugs.webkit.org/show_bug.cgi?id=196391
516
517         Reviewed by Alex Christensen.
518
519         * MiniBrowser/win/WebKitBrowserWindow.cpp:
520         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
521         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
522         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
523
524 2019-03-31  Sam Weinig  <weinig@apple.com>
525
526         Remove more i386 specific configurations
527         https://bugs.webkit.org/show_bug.cgi?id=196430
528
529         Reviewed by Alexey Proskuryakov.
530
531         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
532         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
533
534 2019-03-31  Andy Estes  <aestes@apple.com>
535
536         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
537         https://bugs.webkit.org/show_bug.cgi?id=196433
538         <rdar://problem/49293305>
539
540         Reviewed by Tim Horton.
541
542         Enhanced API test coverage to include all navigation response policy decisions in both
543         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
544
545         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
546         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
547         (TestWebKitAPI::TEST):
548         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
549         (readFile):
550         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
551         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
552         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
553         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
554         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
555         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
556         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
557         (-[QuickLookDelegate _downloadDidStart:]):
558         (-[QuickLookDelegate _download:didReceiveResponse:]):
559         (-[QuickLookDelegate _download:didReceiveData:]):
560         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
561         (-[QuickLookDelegate _downloadDidFinish:]):
562         (-[QuickLookDelegate _download:didFailWithError:]):
563         (-[QuickLookDelegate _downloadDidCancel:]):
564         (-[QuickLookDelegate verifyDownload]):
565         (runTest):
566         (runTestDecideBeforeLoading):
567         (runTestDecideAfterLoading):
568         (TEST):
569         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
570         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
571         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
572         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
573         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
574         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
575         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
576         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
577         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
578         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
579         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
580         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
581         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
582         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
583
584 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
585
586         [CMake] add testdfg as target with build-jsc
587         https://bugs.webkit.org/show_bug.cgi?id=196393
588
589         Reviewed by Saam Barati.
590
591         Added testdfg as one of the targets to build when
592         using CMake.
593
594         * Scripts/build-jsc:
595
596 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
597
598         Delete WebMetal implementation in favor of WebGPU
599         https://bugs.webkit.org/show_bug.cgi?id=195418
600
601         Reviewed by Dean Jackson.
602
603         * DumpRenderTree/mac/DumpRenderTree.mm:
604         (enableExperimentalFeatures):
605         (resetWebPreferencesToConsistentValues):
606         * Scripts/webkitperl/FeatureList.pm:
607         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
609         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
610         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
611         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
612         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
613         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
614         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
615         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
616         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
617         (WTR::InjectedBundle::beginTesting):
618         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
619         (WTR::TestRunner::setWebMetalEnabled): Deleted.
620         * WebKitTestRunner/InjectedBundle/TestRunner.h:
621
622 2019-03-29  Chris Dumez  <cdumez@apple.com>
623
624         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
625         https://bugs.webkit.org/show_bug.cgi?id=196405
626         <rdar://problem/49428130>
627
628         Reviewed by Wenson Hsieh.
629
630         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
631         the popover presentation methods to be no-ops. Use this in the new test added in
632         r243523 so that we do not swizzle those methods for all tests. This is needed because
633         those WatchOS tests rely on the popover getting presented and interactive.
634
635         * WebKitTestRunner/TestController.cpp:
636         (WTR::updateTestOptionsFromTestHeader):
637         * WebKitTestRunner/TestController.h:
638         * WebKitTestRunner/TestOptions.h:
639         (WTR::TestOptions::hasSameInitializationOptions const):
640         * WebKitTestRunner/ios/TestControllerIOS.mm:
641         (WTR::TestController::platformInitialize):
642         (WTR::TestController::platformResetStateToConsistentValues):
643
644 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
645
646         [Curl] Add Server Trust Evaluation Support.
647         https://bugs.webkit.org/show_bug.cgi?id=191646
648
649         Reviewed by Fujii Hironori.
650
651         Implemented MiniBrowser UI for asking if user trusts the server.
652
653         * MiniBrowser/win/Common.cpp:
654         (askServerTrustEvaluation):
655         (replaceString):
656         * MiniBrowser/win/Common.h:
657         * MiniBrowser/win/MiniBrowserLib.rc:
658         * MiniBrowser/win/MiniBrowserLibResource.h:
659         * MiniBrowser/win/WebKitBrowserWindow.cpp:
660         (createPEMString):
661         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
662         (WebKitBrowserWindow::canTrustServerCertificate):
663         * MiniBrowser/win/WebKitBrowserWindow.h:
664
665 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
666
667         Implement ResizeObserver.
668         https://bugs.webkit.org/show_bug.cgi?id=157743
669
670         Reviewed by Simon Fraser.
671
672         Support resizeObserverEnabled webPreferences.
673
674         * DumpRenderTree/TestOptions.cpp:
675         (TestOptions::TestOptions):
676         * DumpRenderTree/TestOptions.h:
677         * DumpRenderTree/mac/DumpRenderTree.mm:
678         (setWebPreferencesForTestOptions):
679         * DumpRenderTree/win/DumpRenderTree.cpp:
680         (enableExperimentalFeatures):
681         * Scripts/webkitperl/FeatureList.pm:
682         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
683
684 2019-03-28  John Wilander  <wilander@apple.com>
685
686         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
687         https://bugs.webkit.org/show_bug.cgi?id=196281
688         <rdar://problem/48938748>
689
690         Reviewed by Alex Christensen.
691
692         This patch adds the function isStatisticsHasLocalStorage() to the
693         TestRunner. With it, the page can query the WebsiteDataStore in the
694         UI process to make sure that it sees LocalStorage.
695
696         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
697         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
698         (WTR::TestRunner::isStatisticsHasLocalStorage):
699         * WebKitTestRunner/InjectedBundle/TestRunner.h:
700         * WebKitTestRunner/TestController.cpp:
701         (WTR::TestController::isStatisticsHasLocalStorage):
702         * WebKitTestRunner/TestController.h:
703         * WebKitTestRunner/TestInvocation.cpp:
704         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
705
706 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
707
708         API::Data::createWithoutCopying should do a null check before calling CFRelease
709         https://bugs.webkit.org/show_bug.cgi?id=196276
710         <rdar://problem/48059859>
711
712         Reviewed by Alex Christensen.
713
714         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
715
716         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
717         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
718         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
719         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
720         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
721         (TestWebKitAPI::TEST):
722
723 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
724
725         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
726         https://bugs.webkit.org/show_bug.cgi?id=186276
727
728         Reviewed by Carlos Garcia Campos.
729
730         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
731         (webViewLoadChanged):
732         (testWebResourceGetDataError):
733         (testWebResourceGetDataEmpty):
734         (beforeAll):
735         (webViewloadChanged): Deleted.
736
737 2019-03-27  Andy Estes  <aestes@apple.com>
738
739         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
740         https://bugs.webkit.org/show_bug.cgi?id=196317
741
742         Reviewed by Dan Bernstein.
743
744         package-root copies built products into a staging directory using ditto(1), which does not
745         follow symbolic links as it traverses a directory. Now that the files in
746         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
747         itself, these become broken links when ditto'd into the staging directory.
748
749         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
750
751         * Scripts/package-root:
752
753 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
754
755         [ews-app] Update display text of Submit for ews analysis
756         https://bugs.webkit.org/show_bug.cgi?id=196309
757
758         Reviewed by Dewei Zhu.
759
760         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
761
762 2019-03-27  David Kilzer  <ddkilzer@apple.com>
763
764         run-webkit-tests should check for leaks in WebKit processes
765         <https://webkit.org/b/193772>
766         <rdar://problem/46526680>
767
768         Reviewed by Ryosuke Niwa.
769
770         This works by doing the following:
771         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
772           The list of child processes are returned one per line:
773           process.name: pid
774         - Run the "#LIST CHILD PROCESSES" command just before the
775           "#CHECK FOR WORLD LEAKS" command, and store the list of child
776           processes on the ServerProcess object.
777         - When the `--leaks` switch is handled, run check_for_leaks() on
778           each child process after the main test harness.
779
780         * DumpRenderTree/mac/DumpRenderTree.mm:
781         (handleControlCommand):
782         - Use strncmp() instead of strcmp().
783         - Add support for handling "#LIST CHILD PROCESSES" command.
784
785         * Scripts/webkitpy/port/base.py:
786         (Port.check_for_leaks):
787         * Scripts/webkitpy/port/darwin.py:
788         (DarwinPort.check_for_leaks):
789         - Rename redundant 'process_pid' argument to 'process_id'.
790
791         * Scripts/webkitpy/port/driver.py:
792         (Driver.do_post_tests_work):
793         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
794           longer the only command this sends to WebKitTestRunner.
795         - If the `--leaks` switch is present, send the
796           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
797           result using Port.set_webkit_processes().
798         (Driver._parse_child_processes_output):
799         - Add helper method to parse list of child process names and
800           process IDs returned from WebKitTestRunner.
801
802         * Scripts/webkitpy/port/ios_device.py:
803         (IOSDevicePort.check_for_leaks):
804         - Rename redundant 'process_pid' argument to 'process_id'.
805
806         * Scripts/webkitpy/port/leakdetector.py:
807         (LeakDetector._parse_leaks_output):
808         - Return early if there is no leaks_output.
809         (LeakDetector.check_for_leaks):
810         - Rename redundant 'process_pid' argument to 'process_id'.
811
812         * Scripts/webkitpy/port/server_process.py:
813         (ServerProcess.__init__):
814         (ServerProcess.child_processes):
815         (ServerProcess.set_child_processes):
816         - Add instance variable to Port to store list of child process
817           names and process IDs returned from WebKitTestRunner.
818         (ServerProcess._start):
819         - Clear self._child_processes.
820         (ServerProcess.stop):
821         - If self._child_processes is set, call
822           self._port.check_for_leaks() for each child process.
823
824         * Scripts/webkitpy/port/server_process_unittest.py:
825         (TrivialMockPort.check_for_leaks):
826         - Rename redundant 'process_pid' argument to 'process_id'.
827
828         * Scripts/webkitpy/port/simulator_process.py:
829         (SimulatorProcess.stop):
830         - If self._child_processes is set, call
831           self._port.check_for_leaks() for each child process.
832
833         * Scripts/webkitpy/port/watch_device.py:
834         (WatchDevicePort.check_for_leaks):
835         - Rename redundant 'process_pid' argument to 'process_id'.
836
837         * WebKitTestRunner/TestController.cpp:
838         (WTR::TestController::dumpResponse):
839         - Extract method from findAndDumpWorldLeaks() so that it may be
840           reused by findAndDumpWebKitProcessIdentifiers().
841         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
842         - Add method to output process name and process ID of both the
843           WebContent and Networking processes.
844         (WTR::TestController::findAndDumpWorldLeaks):
845         - Fix missing newline in output when there were no abandoned
846           documents.
847         - Call dumpResponse() for extracted code.
848         (WTR::TestController::handleControlCommand):
849         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
850         - Use strncmp() instead of strcmp().
851         - Call findAndDumpWebKitProcessIdentifiers() when
852           "#LIST CHILD PROCESSES" command is sent.
853         * WebKitTestRunner/TestController.h:
854         (WTR::TestController::dumpResponse):
855         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
856         - Declare methods.
857
858 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
859
860         Unreviewed. Add GLib API test cases after r243434.
861
862         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
863         (testWebViewActiveURI):
864         (serverCallback):
865         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
866         (sendRequestCallback):
867
868 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
869
870         Geolocation request not complete when watch request was started in a different web process
871         https://bugs.webkit.org/show_bug.cgi?id=195996
872
873         Reviewed by Alex Christensen.
874
875         Add a test case.
876
877         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
878         (TestWebKitAPI::runJavaScriptAlert):
879         (TestWebKitAPI::TEST):
880
881 2019-03-26  Keith Rollin  <krollin@apple.com>
882
883         Update the way generate-xcfilelists returns strings from functions
884         https://bugs.webkit.org/show_bug.cgi?id=195975
885         <rdar://problem/49040807>
886
887         Reviewed by Dean Jackson.
888
889         There are places where generate-xcfilelists executes assignments with
890         statements like:
891
892             FOO=$(some_function)
893
894         where "some_function" return a string by echoing it. E.g.
895
896             some_function()
897             {
898                 echo "Hello, World"
899             }
900
901         This is a common idiom, but it has a problem if "some_function" needs
902         to call "exit" in an attempt to halt the entire script right then and
903         there. Since "some_function" is called inside of $(), it's being
904         executed in a sub-shell. Calling exit in that sub-shell simply exits
905         that shell; it doesn't not exit the outer shell in which the main part
906         of the script is still running. As such, the main script keeps
907         executing when the intent was for the script to halt.
908
909         The solution to this is to use a different idiom for returning
910         strings. The one we now is to pass in the name of the variable to
911         receive the string result:
912
913             some_function()
914             {
915                 variable_name=$1
916                 eval $variable_name ="Hello, World"
917             }
918
919         The call site now looks like
920
921             some_function FOO
922
923         Because there's no invocation of a sub-shell, some_function can now
924         call "exit" if it wants to, and the entire script will exit at that
925         point.
926
927         * Scripts/generate-xcfilelists:
928
929 2019-03-26  Chris Dumez  <cdumez@apple.com>
930
931         Add basic layout test coverage for File Picker on iOS
932         https://bugs.webkit.org/show_bug.cgi?id=196265
933
934         Reviewed by Wenson Hsieh.
935
936         Add layout test infrastructure to test the file picker on iOS.
937
938         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
939         (WTR::UIScriptController::dismissFilePicker):
940         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
941         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
942         (WTR::UIScriptController::dismissFilePicker):
943         * TestRunnerShared/UIScriptContext/UIScriptController.h:
944         * WebKitTestRunner/TestController.cpp:
945         (WTR::TestController::createWebViewWithOptions):
946         (WTR::updateTestOptionsFromTestHeader):
947         * WebKitTestRunner/TestOptions.h:
948         (WTR::TestOptions::hasSameInitializationOptions const):
949         * WebKitTestRunner/ios/TestControllerIOS.mm:
950         (overridePresentViewController):
951         (WTR::TestController::platformInitialize):
952         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
953         (WTR::UIScriptController::dismissFilePicker):
954
955 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
956
957         Implement async paste method on UIWKInteractionViewProtocol
958         https://bugs.webkit.org/show_bug.cgi?id=196267
959         <rdar://problem/49236346>
960
961         Reviewed by Tim Horton.
962
963         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
964         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
965         are now a part of all iOS 12 internal SDKs.
966
967         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
968
969         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
970         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
971
972         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
973         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
974         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
975         * TestWebKitAPI/ios/UIKitSPI.h:
976
977 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
978
979         [ews-build] Use PostgreSQL for ews.webkit.org database
980         https://bugs.webkit.org/show_bug.cgi?id=196270
981
982         Reviewed by Lucas Forschler.
983
984         * BuildSlaveSupport/ews-app/ews-app/settings.py:
985
986 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
987
988         [ews] Reset simctl states on reboot
989         https://bugs.webkit.org/show_bug.cgi?id=196260
990
991         Rubber-stamped by Aakash Jain.
992
993         * EWSTools/start-queue-mac.sh:
994
995 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
996
997         [ews-build] Use PostgreSQL for ews-build database
998         https://bugs.webkit.org/show_bug.cgi?id=196229
999
1000         Reviewed by Lucas Forschler.
1001
1002         * BuildSlaveSupport/ews-build/master.cfg:
1003
1004 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1005
1006         [ews-build] Get master_hostname dynamically in master.cfg
1007         https://bugs.webkit.org/show_bug.cgi?id=196255
1008
1009         Reviewed by Lucas Forschler.
1010
1011         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1012         send events data in test mode.
1013
1014 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1015
1016         [ews-app] Set db_constraint to False for Foreign Keys
1017         https://bugs.webkit.org/show_bug.cgi?id=196252
1018
1019         Reviewed by Lucas Forschler.
1020
1021         * BuildSlaveSupport/ews-app/ews/models/build.py:
1022         * BuildSlaveSupport/ews-app/ews/models/step.py:
1023
1024 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1025
1026         [ews-build] is_test_mode_enabled should default to True
1027         https://bugs.webkit.org/show_bug.cgi?id=196248
1028
1029         Reviewed by Lucas Forschler.
1030
1031         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1032
1033 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1034
1035         [ews-app] Add webkitperl to ENABLED_QUEUES
1036         https://bugs.webkit.org/show_bug.cgi?id=196253
1037
1038         Reviewed by Lucas Forschler.
1039
1040         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1041
1042 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1043
1044         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1045         https://bugs.webkit.org/show_bug.cgi?id=196211
1046         rdar://problem/49110552
1047
1048         Reviewed by Tim Horton.
1049
1050         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1051         Make sure that EventSenderProxy always exists when running tests. We used to create
1052         it when resetting before the first test, which is a bit too late.
1053
1054         * WebKitTestRunner/TestController.h:
1055         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1056         (WTR::TestController::platformCreateWebView):
1057         (WTR::TestController::platformCreateOtherPage):
1058         (WTR::TestController::finishCreatingPlatformWebView):
1059         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1060         (WTR::PlatformWebView::PlatformWebView):
1061         Moved some code that made NSWindow use NSEvent during web view creation. We may
1062         need to move more if some other case us found, but this is enough for now.
1063
1064 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1065
1066         Unreviewed. Fix typo in GLib geolocation API after r243285.
1067
1068         gelocation -> geolocation.
1069
1070         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1071         (testGeolocationManagerWatchPosition):
1072
1073 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1074
1075         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1076         https://bugs.webkit.org/show_bug.cgi?id=196213
1077
1078         Reviewed by Geoff Garen.
1079
1080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1081         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1082         (credentialWithIdentityAndKeychainPath):
1083         (-[ChallengeDelegate webView:didFinishNavigation:]):
1084         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1085         (TestWebKitAPI::TEST):
1086
1087 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1088
1089         Expected shouldn't assume its contained types are copyable
1090         https://bugs.webkit.org/show_bug.cgi?id=195986
1091
1092         Reviewed by JF Bastien.
1093
1094         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1095         (TestWebKitAPI::NonCopyable::operator== const):
1096         (TestWebKitAPI::NonCopyable::operator!= const):
1097         (TestWebKitAPI::TEST):
1098
1099 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1100
1101         Remove some now-unnecessary dynamic class lookup
1102         https://bugs.webkit.org/show_bug.cgi?id=196237
1103
1104         Reviewed by Simon Fraser.
1105
1106         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1107         (makeRequest):
1108         (TEST):
1109
1110 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1111
1112         Unreviewed, rolling out r243450.
1113
1114         AppleWin and WinCairo port builds get broken.
1115
1116         Reverted changeset:
1117
1118         "Add test for fix of #196095"
1119         https://bugs.webkit.org/show_bug.cgi?id=196097
1120         https://trac.webkit.org/changeset/243450
1121
1122 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1123
1124         Unreviewed, rolling out r243465.
1125         https://bugs.webkit.org/show_bug.cgi?id=196226
1126
1127         the test doesn't build (Requested by thorton on #webkit).
1128
1129         Reverted changeset:
1130
1131         "Do not terminate the NetworkProcess if a third party
1132         application sends a NSCredential with a SecIdentityRef"
1133         https://bugs.webkit.org/show_bug.cgi?id=196213
1134         https://trac.webkit.org/changeset/243465
1135
1136 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1137
1138         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1139         https://bugs.webkit.org/show_bug.cgi?id=196213
1140
1141         Reviewed by Geoff Garen.
1142
1143         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1144         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1145         (credentialWithIdentityAndKeychainPath):
1146         (-[ChallengeDelegate webView:didFinishNavigation:]):
1147         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1148         (TestWebKitAPI::TEST):
1149
1150 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1151
1152         [ews-build] Gracefully handle missing patch_id in events
1153         https://bugs.webkit.org/show_bug.cgi?id=196216
1154
1155         Reviewed by Lucas Forschler.
1156
1157         * BuildSlaveSupport/ews-build/events.py:
1158
1159 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1160
1161         [ews-build] use lz4 compression for improving buildbot performance
1162         https://bugs.webkit.org/show_bug.cgi?id=196155
1163
1164         Reviewed by Lucas Forschler.
1165
1166         * BuildSlaveSupport/ews-build/master.cfg:
1167
1168 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1169
1170         Pull some API testing helper methods out of TestWKWebView
1171         https://bugs.webkit.org/show_bug.cgi?id=196212
1172
1173         Reviewed by Tim Horton.
1174
1175         Refactor some more API testing utility methods, so that they can be used in
1176         tests that do not use TestWKWebView.
1177
1178         * TestWebKitAPI/cocoa/TestWKWebView.h:
1179         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1180         (-[WKWebView loadTestPageNamed:]):
1181         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1182         (-[WKWebView synchronouslyLoadHTMLString:]):
1183         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1184         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1185         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1186         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1187         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1188
1189 2019-03-25  Jer Noble  <jer.noble@apple.com>
1190
1191         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1192         https://bugs.webkit.org/show_bug.cgi?id=196097
1193
1194         Reviewed by Eric Carlson.
1195
1196         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1197
1198         * DumpRenderTree/mac/DumpRenderTree.mm:
1199         (resetWebPreferencesToConsistentValues):
1200         * WebKitTestRunner/TestController.cpp:
1201         (WTR::TestController::resetPreferencesToConsistentValues):
1202
1203 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1204
1205         Pull IPadUserInterfaceSwizzler out into a separate header file
1206         https://bugs.webkit.org/show_bug.cgi?id=196193
1207
1208         Reviewed by Anders Carlsson.
1209
1210         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1211         be used in other API tests.
1212
1213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1214         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1215         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1216         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1217         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1218         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1219         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1220
1221 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1222
1223         Remove NavigatorContentUtils in WebCore/Modules
1224         https://bugs.webkit.org/show_bug.cgi?id=196070
1225
1226         Reviewed by Alex Christensen.
1227
1228         NavigatorContentUtils was to support the custom scheme spec [1].
1229         However, in WebKit side, no port has supported the feature in
1230         WebKit layer after EFL port was removed. So there has been the
1231         only IDL implementation of the NavigatorContentUtils in WebCore.
1232         So we don't need to keep the implementation in WebCore anymore.
1233
1234         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1235
1236         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1237
1238 2019-03-24  Andy Estes  <aestes@apple.com>
1239
1240         [watchOS] Remove unused Proximity Networking code
1241         https://bugs.webkit.org/show_bug.cgi?id=196188
1242
1243         Reviewed by Tim Horton.
1244
1245         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1246         (TEST):
1247
1248 2019-03-23  Keith Miller  <keith_miller@apple.com>
1249
1250         Refactor clz/ctz and fix getLSBSet.
1251         https://bugs.webkit.org/show_bug.cgi?id=196162
1252
1253         Reviewed by Saam Barati.
1254
1255         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1256
1257         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1258         (TestWebKitAPI::TEST):
1259
1260 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1261
1262         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1263         https://bugs.webkit.org/show_bug.cgi?id=196143
1264
1265         Reviewed by Michael Catanzaro.
1266
1267         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1268         directories.
1269
1270         * Scripts/webkitpy/style/checkers/cpp.py:
1271         (check_identifier_name_in_declaration):
1272         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1273         (WebKitStyleTest.test_names):
1274
1275 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1276
1277         [Flatpak] Manifest expanding fails for qt WPE extension
1278         https://bugs.webkit.org/show_bug.cgi?id=196148
1279
1280         Reviewed by Alex Christensen.
1281
1282         * flatpak/flatpakutils.py:
1283         (expand_submodules_recurse): The last recurse manifest expand
1284         iteration might lead to a single module so take it into account
1285         and don't try to recurse further.
1286
1287 2019-03-22  Chris Dumez  <cdumez@apple.com>
1288
1289         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1290         https://bugs.webkit.org/show_bug.cgi?id=195348
1291         <rdar://problem/48622090>
1292
1293         Reviewed by Alex Christensen.
1294
1295         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1296         to NO when test.options().shouldIgnoreMetaViewport is false.
1297
1298         * WebKitTestRunner/ios/TestControllerIOS.mm:
1299         (WTR::TestController::platformConfigureViewForTest):
1300
1301 2019-03-22  Chris Dumez  <cdumez@apple.com>
1302
1303         Prewarmed processes should be usable with any website data store
1304         https://bugs.webkit.org/show_bug.cgi?id=196104
1305
1306         Reviewed by Alex Christensen.
1307
1308         Add API test coverage.
1309
1310         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1311         (runInitialWarmedProcessUsedTest):
1312         (TEST):
1313
1314 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1315
1316         Back out local changes to Alex's Subversion working directory
1317
1318         They were accidentally committed.
1319
1320         * Scripts/webkitpy/common/system/abstractexecutive.py:
1321         (AbstractExecutive.wait_newest):
1322         * Scripts/webkitpy/common/system/executive.py:
1323         (Executive.running_pids):
1324         * Scripts/webkitpy/common/system/executive_mock.py:
1325         (MockExecutive.running_pids):
1326         * Scripts/webkitpy/common/system/executive_unittest.py:
1327         (ExecutiveTest.serial_test_running_pids):
1328         * Scripts/webkitpy/port/darwin.py:
1329         (DarwinPort.check_for_leaks):
1330         * Scripts/webkitpy/port/leakdetector.py:
1331         (LeakDetector.check_for_leaks):
1332         - This was the hack attached to Bug 193772.
1333
1334         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1335         (+[WebKitTestRunnerEvent mouseLocation]):
1336         - This works around a crash on an internal build.
1337
1338 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1339
1340         Fix the build after r243354
1341         https://bugs.webkit.org/show_bug.cgi?id=196138
1342         <rdar://problem/49145951>
1343
1344         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1345         (TEST):
1346         * TestWebKitAPI/ios/UIKitSPI.h:
1347
1348 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1349
1350         Adopt UIWKDocumentContext
1351         https://bugs.webkit.org/show_bug.cgi?id=196040
1352         <rdar://problem/48642440>
1353
1354         Reviewed by Ryosuke Niwa.
1355
1356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1357         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1358         (makeRequest):
1359         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1360         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1361         (applyStyle):
1362         (TEST):
1363         Add tests for UIWKDocumentContext.
1364
1365         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1366         (TEST):
1367         (recursiveFindWKContentView): Deleted.
1368         * TestWebKitAPI/cocoa/TestWKWebView.h:
1369         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1370         (recursiveFindWKContentView):
1371         (-[TestWKWebView wkContentView]):
1372         * TestWebKitAPI/ios/UIKitSPI.h:
1373         Share the WKContentView finding code between tests.
1374
1375 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1376
1377         [iOS WK2] Turn on async overflow scrolling by default
1378         https://bugs.webkit.org/show_bug.cgi?id=196011
1379         rdar://problem/48453859
1380
1381         Reviewed by Antti Koivisto.
1382         
1383         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1384         since so many basic layout tests have different results when compositing is triggered for
1385         overflow.
1386         
1387         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1388
1389         * WebKitTestRunner/TestController.cpp:
1390         (WTR::TestController::resetPreferencesToConsistentValues):
1391
1392 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1393
1394         [ews-build] Retry API test in case of failures
1395         https://bugs.webkit.org/show_bug.cgi?id=196004
1396
1397         Reviewed by Lucas Forschler.
1398
1399         * BuildSlaveSupport/ews-build/steps.py:
1400         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1401         (CompileWebKitToT.doStepIf): Ditto.
1402         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1403         (ReRunAPITests): Re-run API tests.
1404         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1405         (RunAPITestsWithoutPatch): Run API tests without patch.
1406         (RunAPITestsWithoutPatch.doStepIf):
1407         (RunAPITestsWithoutPatch.hideStepIf):
1408         (RunAPITestsWithoutPatch.evaluateCommand):
1409         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1410         (AnalyzeAPITestsResults.start):
1411         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1412         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1413         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1414         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1415
1416 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1417
1418         [ews-build] Update queues configurations
1419         https://bugs.webkit.org/show_bug.cgi?id=196074
1420
1421         Reviewed by Dewei Zhu.
1422
1423         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1424         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1425
1426 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1427
1428         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1429         https://bugs.webkit.org/show_bug.cgi?id=195680
1430         <rdar://problem/48903534>
1431
1432         Unreviewed infrastructure fix.
1433
1434         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1435         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1436
1437 2019-03-21  Andy Estes  <aestes@apple.com>
1438
1439         [iOS] Apple Pay should be available in documents with no user agent scripts
1440         https://bugs.webkit.org/show_bug.cgi?id=196061
1441         <rdar://problem/48649391>
1442
1443         Reviewed by Brady Eidson.
1444
1445         Added API tests and related infrastructure.
1446
1447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1448         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1449         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1450         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1451         (TestWebKitAPI::TEST):
1452         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1453         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1454         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1455         * TestWebKitAPI/cocoa/TestProtocol.mm:
1456         (-[TestProtocol startLoading]):
1457         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1458         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1459         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1460         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1461
1462 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1463
1464         REGRESSSION (r243297): webkitpy tests broken
1465         https://bugs.webkit.org/show_bug.cgi?id=196108
1466
1467         Reviewed by Aakash Jain.
1468
1469         r243297 updated contributors.json, which broke a few unit tests.
1470
1471         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1472         (IRCCommandTest.test_whois):
1473         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1474
1475 2019-03-21  Chris Dumez  <cdumez@apple.com>
1476
1477         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1478         https://bugs.webkit.org/show_bug.cgi?id=196041
1479         <rdar://problem/49083230>
1480
1481         Reviewed by Alex Christensen.
1482
1483         Add API test coverage.
1484
1485         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1486         (TEST):
1487
1488 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1489
1490         Add SPI to inform applications of WKContentRuleList actions
1491         https://bugs.webkit.org/show_bug.cgi?id=195965
1492         <rdar://problem/42664365>
1493
1494         Reviewed by Geoff Garen.
1495
1496         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1497         (TestWebKitAPI::allActionsForResourceLoad):
1498         (TestWebKitAPI::testRequest):
1499         (TestWebKitAPI::TEST_F):
1500         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1501         (Notification::description):
1502         (Notification::operator== const):
1503         (toVector):
1504         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1505         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1506         (makeContentRuleList):
1507         (TEST):
1508         (makeWarnContentRuleList): Deleted.
1509
1510 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1511
1512         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1513         https://bugs.webkit.org/show_bug.cgi?id=196088
1514
1515         Reviewed by Brian Burg.
1516
1517         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1518         Support checks when only one platform is specified. Also deprecate macosx() and
1519         force the use of macos() instead.
1520
1521         * Scripts/webkitpy/style/checkers/cpp.py:
1522         (check_min_versions_of_wk_api_available):
1523         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1524         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1525
1526 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1527
1528         Update status inactive committers' status to 'contributor'.
1529
1530         * Scripts/webkitpy/common/config/contributors.json:
1531
1532 2019-03-21  Xan Lopez  <xan@igalia.com>
1533
1534         [JSC][x86] Drop support for x87 floating point
1535         https://bugs.webkit.org/show_bug.cgi?id=194853
1536
1537         Reviewed by Don Olmstead.
1538
1539         Force SSE2 on x86/32bit builds.
1540
1541         * Scripts/webkitdirs.pm:
1542         (generateBuildSystemFromCMakeProject):
1543
1544 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1545
1546         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1547         https://bugs.webkit.org/show_bug.cgi?id=196073
1548
1549         Reviewed by Michael Catanzaro.
1550
1551         Add test cases to check functions and constructors with no arguments but receiving user data.
1552
1553         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1554         (checkUserData):
1555         (testJSCFunction):
1556         (fooCreateWithUserData):
1557         (testJSCClass):
1558
1559 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1560
1561         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1562
1563         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1564
1565         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1566
1567 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1568
1569         [GTK][WPE] Add API to provide geolocation information
1570         https://bugs.webkit.org/show_bug.cgi?id=195940
1571
1572         Reviewed by Michael Catanzaro.
1573
1574         Add a new test to check the new API.
1575
1576         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1577         (testGeolocationManagerCurrentPosition):
1578         (testGeolocationManagerWatchPosition):
1579         (beforeAll):
1580         (afterAll):
1581         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1582         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1583         (beforeAll): Ditto.
1584         * TestWebKitAPI/glib/CMakeLists.txt:
1585
1586 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1587
1588         [GLib] Returning G_TYPE_OBJECT from a method does not work
1589         https://bugs.webkit.org/show_bug.cgi?id=195574
1590
1591         Reviewed by Michael Catanzaro.
1592
1593         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1594
1595         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1596         (getGFile):
1597         (getParent):
1598         (createGString):
1599         (getGString):
1600         (getGStringCopyWillRaise):
1601         (getGStringCopy):
1602         (getGStringStr):
1603         (getGStringLen):
1604         (freeGString):
1605         (testJSCClass):
1606
1607 2019-03-20  Saam Barati  <sbarati@apple.com>
1608
1609         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1610         https://bugs.webkit.org/show_bug.cgi?id=195721
1611
1612         Reviewed by Filip Pizlo.
1613
1614         * Scripts/run-javascriptcore-tests:
1615
1616 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1617
1618         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1619         https://bugs.webkit.org/show_bug.cgi?id=196049
1620
1621         Reviewed by Tim Horton.
1622
1623         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1624         overflow scrolling in general, so rename it.
1625
1626         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1627
1628 2019-03-20  Daniel Bates  <dabates@apple.com>
1629
1630         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1631         https://bugs.webkit.org/show_bug.cgi?id=196031
1632         <rdar://problem/49078172>
1633
1634         Reviewed by Tim Horton.
1635
1636         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1637         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1638         same code path used when the Done button is pressed to dismiss the <select> picker.
1639
1640         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1641         (TestWebKitAPI::TEST):
1642
1643 2019-03-20  Chris Dumez  <cdumez@apple.com>
1644
1645         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1646         https://bugs.webkit.org/show_bug.cgi?id=196029
1647         <rdar://problem/48954651>
1648
1649         Reviewed by Tim Horton.
1650
1651         Add API test coverage.
1652
1653         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1654
1655 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1656
1657         [ews-build] Improve failure summary string for ApplyPatch step
1658         https://bugs.webkit.org/show_bug.cgi?id=195995
1659
1660         Reviewed by Alexey Proskuryakov.
1661
1662         * BuildSlaveSupport/ews-build/steps.py:
1663         (ApplyPatch.getResultSummary): Override getResultSummary.
1664
1665 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1666
1667         AX: Implement support for new meter ARIA role
1668         https://bugs.webkit.org/show_bug.cgi?id=195966
1669
1670         Reviewed by Chris Fleizach.
1671
1672         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1673         to AXLevelIndicator.
1674
1675         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1676
1677 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1678
1679         [WebAuthN] Implement FIDO AppID extension
1680         https://bugs.webkit.org/show_bug.cgi?id=143491
1681         <rdar://problem/48298273>
1682
1683         Reviewed by Brent Fulgham.
1684
1685         Add a test that covers the new flag of convertToU2fSignCommand.
1686
1687         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1688         (TestWebKitAPI::TEST):
1689         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1690         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1691         (TestWebKitAPI::TEST):
1692
1693 2019-03-19  Keith Rollin  <krollin@apple.com>
1694
1695         Add support for more platforms to generate-xcfilelists
1696         https://bugs.webkit.org/show_bug.cgi?id=195977
1697
1698         Reviewed by Alexey Proskuryakov.
1699
1700         generate-xcfilelists incorrectly complains when involved with building
1701         WebKit for iphonesimulator:
1702
1703             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1704             …
1705             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1706
1707         Address this by teaching generate-xcfilelists about more platforms.
1708
1709         * Scripts/generate-xcfilelists:
1710
1711 2019-03-19  John Wilander  <wilander@apple.com>
1712
1713         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1714         https://bugs.webkit.org/show_bug.cgi?id=195923
1715         <rdar://problem/49001272>
1716
1717         Reviewed by Alex Christensen.
1718
1719         This patch does the following to the TestRunner:
1720         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1721         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1722         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1723
1724         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1725         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1726         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1727         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1728         * WebKitTestRunner/TestController.cpp:
1729         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1730         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1731         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1732         * WebKitTestRunner/TestController.h:
1733         * WebKitTestRunner/TestInvocation.cpp:
1734         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1735
1736 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1737
1738         [CMake] Support more clang and gcc sanitizers
1739         https://bugs.webkit.org/show_bug.cgi?id=195956
1740
1741         Reviewed by Michael Catanzaro.
1742
1743         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1744
1745 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1746
1747         [ews-build] Improve summary for PrintConfiguration step
1748         https://bugs.webkit.org/show_bug.cgi?id=195945
1749
1750         Reviewed by Lucas Forschler.
1751
1752         * BuildSlaveSupport/ews-build/steps.py:
1753         (PrintConfiguration.getResultSummary): Override getResultSummary.
1754
1755 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1756
1757         [ews-build] Improve summary for CheckOutSource step
1758         https://bugs.webkit.org/show_bug.cgi?id=195963
1759
1760         Reviewed by Lucas Forschler.
1761
1762         * BuildSlaveSupport/ews-build/steps.py:
1763         (CheckOutSource.getResultSummary):
1764
1765 2019-03-19  Daniel Bates  <dabates@apple.com>
1766
1767         [iOS] Focus not preserved when switching between tabs
1768         https://bugs.webkit.org/show_bug.cgi?id=195820
1769         <rdar://problem/43614450>
1770
1771         Reviewed by Brent Fulgham.
1772
1773         Add tests to ensure that we restore focus when resigning and becoming first responder.
1774
1775         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1776         (TestWebKitAPI::TEST):
1777
1778 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1779
1780         Make WTFLogChannelState and WTFLogLevel enum classes
1781         https://bugs.webkit.org/show_bug.cgi?id=195904
1782
1783         Reviewed by Eric Carlson.
1784
1785         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1786         (TestWebKitAPI::TEST_F):
1787
1788 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1789
1790         [GStreamer][EME] Backported mssdemux protection data crash fix
1791         https://bugs.webkit.org/show_bug.cgi?id=195918
1792
1793         Reviewed by Philippe Normand.
1794
1795         * gstreamer/jhbuild.modules:
1796         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1797
1798 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1799
1800         Unreviewed, rolling out r243132.
1801
1802         Broke GTK build
1803
1804         Reverted changeset:
1805
1806         "Make WTFLogChannelState and WTFLogLevel enum classes"
1807         https://bugs.webkit.org/show_bug.cgi?id=195904
1808         https://trac.webkit.org/changeset/243132
1809
1810 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1811
1812         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1813
1814         * Scripts/webkitdirs.pm:
1815         (builtDylibPathForName): Adjust the shared library name that's changed
1816         with the API version bump in r243073.
1817
1818 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1819
1820         Make WTFLogChannelState and WTFLogLevel enum classes
1821         https://bugs.webkit.org/show_bug.cgi?id=195904
1822
1823         Reviewed by Eric Carlson.
1824
1825         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1826         (TestWebKitAPI::TEST_F):
1827
1828 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1829
1830         Disable flaky test added in r2431100
1831         https://webkit.org/b/195785
1832
1833         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1834         (TestWebKitAPI::TEST):
1835         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1836
1837 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1838
1839         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1840         https://bugs.webkit.org/show_bug.cgi?id=195916
1841
1842         Reviewed by Tim Horton.
1843
1844         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1845         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1846
1847 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1848
1849         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1850
1851         * Scripts/webkitpy/common/config/contributors.json:
1852
1853 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1854
1855         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1856         https://bugs.webkit.org/show_bug.cgi?id=195785
1857
1858         Reviewed by Geoffrey Garen.
1859
1860         * TestWebKitAPI/TCPServer.cpp: Added.
1861         (TestWebKitAPI::TCPServer::TCPServer):
1862         (TestWebKitAPI::TCPServer::~TCPServer):
1863         (TestWebKitAPI::TCPServer::socketBindListen):
1864         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1865         * TestWebKitAPI/TCPServer.h: Added.
1866         (TestWebKitAPI::TCPServer::port const):
1867         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1868         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1869         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1870         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1871         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1872         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1873         (TestWebKitAPI::respondSlowly):
1874         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1875         (TestWebKitAPI::downloadAtRate):
1876         (TestWebKitAPI::TEST):
1877
1878 2019-03-18  Saam Barati  <sbarati@apple.com>
1879
1880         Add a plan file for JetStream 2
1881         https://bugs.webkit.org/show_bug.cgi?id=190734
1882
1883         Reviewed by Mark Lam.
1884
1885         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1886
1887 2019-03-18  Chris Dumez  <cdumez@apple.com>
1888
1889         Delay WebProcess launch until a load is triggered in a Web view
1890         https://bugs.webkit.org/show_bug.cgi?id=195758
1891         <rdar://problem/48126013>
1892
1893         Reviewed by Geoff Garen.
1894
1895         Add API test coverage. Also update some existing API tests to not expect
1896         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1897
1898         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1899         (TestWebKitAPI::TEST):
1900         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1901         (TestWebKitAPI::TEST):
1902         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1903         (TEST):
1904         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1905         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1906         (TEST):
1907         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1908         (TEST):
1909         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1910
1911 2019-03-18  Xan Lopez  <xan@igalia.com>
1912
1913         [CMake] Prevent potential warning when determining $architecture
1914         https://bugs.webkit.org/show_bug.cgi?id=195891
1915
1916         Reviewed by Michael Catanzaro.
1917
1918         It's possible for generateBuildSystemForCMakeProject to be called
1919         before determineArchitecture() is ever called. This will make the
1920         first eq check with $architecture to be bogus (and print a
1921         warning). Change that to an eq check with architecture(), which
1922         implicitly calls determineArchitecture() if needed, and change all
1923         the other similar cases in the method in the same way to prevent
1924         future bugs like this one.
1925
1926         * Scripts/webkitdirs.pm:
1927         (generateBuildSystemFromCMakeProject):
1928
1929 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1930
1931         [WPE] Tarballs generated with “make dist” cannot build documentation
1932         https://bugs.webkit.org/show_bug.cgi?id=195885
1933
1934         Reviewed by Carlos Garcia Campos.
1935
1936         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1937
1938 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1939
1940         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1941         https://bugs.webkit.org/show_bug.cgi?id=195883
1942
1943         Reviewed by Carlos Garcia Campos.
1944
1945         * gtkdoc/gtkdoc.py:
1946         (GTKDoc._run_command): When commands fail to run, include the full command line for
1947         the program invocation and the output it has generated on the standard error stream.
1948
1949 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1950
1951         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1952         https://bugs.webkit.org/show_bug.cgi?id=195786
1953
1954         Reviewed by Philippe Normand.
1955
1956         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1957         * wpe/jhbuild.modules: Ditto.
1958
1959 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1960
1961         [ews-build] Don't run clean builds on EWS builders
1962         https://bugs.webkit.org/show_bug.cgi?id=195851
1963
1964         Reviewed by Geoffrey Garen.
1965
1966         * BuildSlaveSupport/ews-build/factories.py:
1967
1968 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1969
1970         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1971         https://bugs.webkit.org/show_bug.cgi?id=195849
1972
1973         Reviewed by Chris Dumez.
1974
1975         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1976
1977         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1978         (runWebsiteDataStoreCustomPaths):
1979
1980 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1981
1982         webkitpy: Upload test results
1983         https://bugs.webkit.org/show_bug.cgi?id=195755
1984         <rdar://problem/48896182>
1985
1986         Reviewed by Aakash Jain.
1987
1988         Establish a new format for uploading results that is not tied to layout tests, apply
1989         that format to webkitpy tests.
1990
1991         * Scripts/webkitpy/common/checkout/scm/git.py:
1992         (Git.native_branch): Return what branch the current checkout is on.
1993         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1994         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1995         * Scripts/webkitpy/common/checkout/scm/svn.py:
1996         (SVN.native_branch): Ditto.
1997         * Scripts/webkitpy/common/system/platforminfo.py:
1998         (PlatformInfo.build_version): Return a build version for Mac.
1999         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2000         (MockPlatformInfo.__init__):
2001         (MockPlatformInfo.build_version):
2002         * Scripts/webkitpy/results: Added.
2003         * Scripts/webkitpy/results/__init__.py: Added.
2004         * Scripts/webkitpy/results/options.py: Added.
2005         (upload_options): OptParse list for upload options.
2006         * Scripts/webkitpy/results/upload.py: Added.
2007         (Upload): Class which enforces the upload format expected by the results server.
2008         (Upload.Expectations):
2009         (Upload.create_configuration):
2010         (Upload.create_commit):
2011         (Upload.create_details):
2012         (Upload.create_run_stats):
2013         (Upload.create_test_result):
2014         (Upload.__init__):
2015         (Upload.Encoder): Encode Upload object as json.
2016         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2017         * Scripts/webkitpy/results/upload_unittest.py: Added.
2018         * Scripts/webkitpy/test/main.py:
2019         (Tester._parse_args): Add upload arguments.
2020         (Tester._run_tests): Allow results to be uploaded.
2021         * Scripts/webkitpy/test/runner.py:
2022         (Runner.__init__): Record which tests were run, rather than just counting them.
2023         (Runner.handle):
2024         * Scripts/webkitpy/test/runner_unittest.py:
2025         (RunnerTest.test_run):
2026         * Scripts/webkitpy/thirdparty/__init__.py:
2027         (AutoinstallImportHook.find_module): Add requests auto-install.
2028         (AutoinstallImportHook._install_requests):
2029         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2030         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2031
2032 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2033
2034         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2035         https://bugs.webkit.org/show_bug.cgi?id=195810
2036
2037         Reviewed by Tim Horton.
2038
2039         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2040         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2041         ending certain layout tests.
2042
2043         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2044         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2045         (-[TestRunnerWKWebView dealloc]):
2046         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2047
2048         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2049         helper method when destroying the web view, and when resetting state between tests.
2050
2051         * WebKitTestRunner/ios/TestControllerIOS.mm:
2052         (WTR::TestController::platformResetStateToConsistentValues):
2053
2054         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2055
2056 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2057
2058         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2059         https://bugs.webkit.org/show_bug.cgi?id=190350
2060         <rdar://problem/45089503>
2061
2062         Reviewed by Geoffrey Garen.
2063
2064         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2065         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2066         (TEST):
2067         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2068         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2069         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2070         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2071         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2072         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2073         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2074         (runTest):
2075         (createDirectories):
2076         (TEST):
2077         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2078         (TEST):
2079         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2080         (TEST):
2081
2082 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2083
2084         Add support to WebPage for getting the contents as an attributed string.
2085         https://bugs.webkit.org/show_bug.cgi?id=195636
2086         rdar://problem/45055697
2087
2088         Reviewed by Tim Horton.
2089
2090         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2091         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2092
2093 2019-03-15  Chris Dumez  <cdumez@apple.com>
2094
2095         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2096         https://bugs.webkit.org/show_bug.cgi?id=195747
2097
2098         Reviewed by Geoff Garen.
2099
2100         Add API test coverage.
2101
2102         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2103
2104 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2105
2106         Unreviewed, rolling out r242952.
2107
2108         Causing API failures on iOS Simulator
2109
2110         Reverted changeset:
2111
2112         "[PSON] Make sure the WebProcessCache is leverage when
2113         relaunching a process after termination"
2114         https://bugs.webkit.org/show_bug.cgi?id=195747
2115         https://trac.webkit.org/changeset/242952
2116
2117 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2118
2119         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2120         https://bugs.webkit.org/show_bug.cgi?id=195740
2121
2122         Reviewed by Ross Kirsling.
2123
2124         window.open doesn't work for WebKitBrowserWindow because it is not
2125         implemented yet.
2126
2127         1. Implemented createNewPage callback of WKPageUIClient.
2128         2. Changed MainWindow to take a BrowserWindow factory function
2129           instead of BrowserWindowType to be flexible to create
2130           BrowserWindow with extra settings.
2131         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2132           because it is not relevant with MainWindow anymore.
2133
2134         * MiniBrowser/win/Common.cpp:
2135         (parseCommandLine):
2136         * MiniBrowser/win/Common.h:
2137         (CommandLineOptions::CommandLineOptions):
2138         * MiniBrowser/win/MainWindow.cpp:
2139         (MainWindow::MainWindow):
2140         (MainWindow::create):
2141         (MainWindow::init):
2142         (MainWindow::WndProc):
2143         * MiniBrowser/win/MainWindow.h:
2144         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2145         (PrintWebUIDelegate::createWebViewWithRequest):
2146         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2147         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2148         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2149         (WebKitBrowserWindow::updateProxySettings):
2150         (WebKitBrowserWindow::createNewPage):
2151         * MiniBrowser/win/WebKitBrowserWindow.h:
2152         * MiniBrowser/win/WinMain.cpp:
2153         (wWinMain):
2154
2155 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2156
2157         Make it possible to test scrolling tree layer manipulation more easily
2158         https://bugs.webkit.org/show_bug.cgi?id=195780
2159
2160         Reviewed by Tim Horton.
2161         
2162         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2163         cuts off communication of scrolling tree scrolls back to the web process
2164         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2165         allows tests to trigger scrolls which run the scrolling tree layer positioning
2166         logic, but never get another commit from the web process that might mask
2167         scrolling tree bugs.
2168         
2169         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2170         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2171         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2172
2173         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2174         (WTR::UIScriptController::scrollUpdatesDisabled const):
2175         (WTR::UIScriptController::setScrollUpdatesDisabled):
2176         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2177         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2178         (WTR::UIScriptController::scrollUpdatesDisabled const):
2179         (WTR::UIScriptController::setScrollUpdatesDisabled):
2180         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2181         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2182         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2183         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2184         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2185         * WebKitTestRunner/ios/TestControllerIOS.mm:
2186         (WTR::TestController::platformResetStateToConsistentValues):
2187         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2188         (WTR::UIScriptController::scrollUpdatesDisabled const):
2189         (WTR::UIScriptController::setScrollUpdatesDisabled):
2190
2191 2019-03-14  Youenn Fablet  <youenn@apple.com>
2192
2193         Move IDB storage in private browsing mode to NetworkProcess
2194         https://bugs.webkit.org/show_bug.cgi?id=195602
2195
2196         Reviewed by Brady Eidson.
2197
2198         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2199         (TEST):
2200
2201 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2202
2203         [ews-build] Make descriptionDone messages more readable
2204         https://bugs.webkit.org/show_bug.cgi?id=195760
2205
2206         Reviewed by Lucas Forschler.
2207
2208         * BuildSlaveSupport/ews-build/steps.py:
2209         * BuildSlaveSupport/ews-build/steps_unittest.py:
2210
2211 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2212
2213         [ews-build] Generate status-bubble hover-over messages
2214         https://bugs.webkit.org/show_bug.cgi?id=195680
2215
2216         Reviewed by Lucas Forschler.
2217
2218         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2219         (StatusBubble):
2220         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2221         on hover-over.
2222         (StatusBubble._iso_time):
2223         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2224         hover-over message.
2225         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2226
2227 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2228
2229         [ews-app] Gracefully handle the case when state_string is None
2230         https://bugs.webkit.org/show_bug.cgi?id=195753
2231
2232         Reviewed by Lucas Forschler.
2233
2234         * BuildSlaveSupport/ews-app/ews/models/build.py:
2235         * BuildSlaveSupport/ews-app/ews/models/step.py:
2236
2237 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2238
2239         [ews-app] Status bubble display pending for currently running build step
2240         https://bugs.webkit.org/show_bug.cgi?id=195744
2241
2242         Reviewed by Lucas Forschler.
2243
2244         * BuildSlaveSupport/ews-build/events.py:
2245         (Events.stepStarted): If state_string is pending, replace it with step name.
2246
2247 2019-03-14  Chris Dumez  <cdumez@apple.com>
2248
2249         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2250         https://bugs.webkit.org/show_bug.cgi?id=195750
2251
2252         Reviewed by Geoffrey Garen.
2253
2254         Add API test coverage.
2255
2256         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2257         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2258         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2259         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2260
2261 2019-03-14  Chris Dumez  <cdumez@apple.com>
2262
2263         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2264         https://bugs.webkit.org/show_bug.cgi?id=195747
2265
2266         Reviewed by Geoff Garen.
2267
2268         Add API test coverage.
2269
2270         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2271
2272 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2273
2274         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2275         https://bugs.webkit.org/show_bug.cgi?id=195725
2276         <rdar://problem/48545062>
2277
2278         Reviewed by Tim Horton.
2279
2280         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2281         handler is nil.
2282
2283         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2284         (TestWebKitAPI::TEST):
2285
2286 2019-03-13  Sam Weinig  <sam@webkit.org>
2287
2288         Add utility function to allow easy reverse range-based iteration of a container
2289         https://bugs.webkit.org/show_bug.cgi?id=195542
2290
2291         Reviewed by Antti Koivisto.
2292
2293         * TestWebKitAPI/CMakeLists.txt:
2294         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2295         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2296         (TestWebKitAPI::TEST):
2297         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2298
2299 2019-03-13  Chris Dumez  <cdumez@apple.com>
2300
2301         Use a ServiceWorker process per registrable domain
2302         https://bugs.webkit.org/show_bug.cgi?id=195649
2303
2304         Reviewed by Youenn Fablet.
2305
2306         Update API test coverage.
2307
2308         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2309
2310 2019-03-13  Chris Dumez  <cdumez@apple.com>
2311
2312         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2313         https://bugs.webkit.org/show_bug.cgi?id=195684
2314         <rdar://problem/48294714>
2315
2316         Reviewed by Antti Koivisto.
2317
2318         Add API test coverage.
2319
2320         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2321
2322 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2323
2324         [ews-app] Remove unused patch view
2325         https://bugs.webkit.org/show_bug.cgi?id=195669
2326
2327         Reviewed by Lucas Forschler.
2328
2329         * BuildSlaveSupport/ews-app/ews/urls.py:
2330         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2331
2332 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2333
2334         [ews-app] Use Buildbot result code variables
2335         https://bugs.webkit.org/show_bug.cgi?id=195668
2336
2337         Reviewed by Alexey Proskuryakov.
2338
2339         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2340         (Buildbot): Added Buildbot result code variables.
2341         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2342         (StatusBubble._build_bubble): Used Buildbot result code variables.
2343
2344 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2345
2346         [Flatpak] Expand submodule recursively
2347         https://bugs.webkit.org/show_bug.cgi?id=195672
2348
2349         Building WPE with flatpak was impossible without that as it was raising an exception.
2350         Also update wpebackend-fdo to match what is built in jhbuild
2351
2352         Reviewed by Philippe Normand.
2353
2354         * flatpak/flatpakutils.py:
2355         (expand_submodules_recurse):
2356         (expand_manifest):
2357         * flatpak/org.webkit.WPEModules.yaml:
2358
2359 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2360
2361         [ews-app] status bubble should be hidden for certain builds
2362         https://bugs.webkit.org/show_bug.cgi?id=194597
2363
2364         Reviewed by Dewei Zhu.
2365
2366         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2367         (StatusBubble._build_bubble):
2368         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2369         because the patch didn't have relevant changes.
2370         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2371         in production yet.
2372
2373 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2374
2375         [Win] Fix a slew of simple clang-cl warnings.
2376         https://bugs.webkit.org/show_bug.cgi?id=195652
2377
2378         Reviewed by Don Olmstead.
2379
2380         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2381         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2382
2383 2019-03-12  Justin Fan  <justin_fan@apple.com>
2384
2385         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2386         https://bugs.webkit.org/show_bug.cgi?id=195518
2387         <rdar://problem/46322356>
2388
2389         Reviewed by Myles C. Maxfield.
2390
2391         * DumpRenderTree/DerivedSources-input.xcfilelist:
2392         * DumpRenderTree/DerivedSources-output.xcfilelist:
2393
2394 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2395
2396         Unreviewed, rolling out r242825.
2397         https://bugs.webkit.org/show_bug.cgi?id=195648
2398
2399         "Broke webkitpy tests with my change to
2400         lldb_dump_class_layout.py" (Requested by rmorisset on
2401         #webkit).
2402
2403         Reverted changeset:
2404
2405         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2406         classes with suspicious padding"
2407         https://bugs.webkit.org/show_bug.cgi?id=195573
2408         https://trac.webkit.org/changeset/242825
2409
2410 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2411
2412         [ews-build] Show status bubbles while the patch is waiting in queue
2413         https://bugs.webkit.org/show_bug.cgi?id=195618
2414
2415         Reviewed by Lucas Forschler.
2416
2417         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2418         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2419         enabled in initial deployment.
2420         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2421         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2422         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2423         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2424         (StatusBubble._build_bubbles_for_patch):
2425
2426 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2427
2428         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2429         https://bugs.webkit.org/show_bug.cgi?id=195573
2430
2431         Reviewed by Simon Fraser.
2432
2433         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2434
2435         * Scripts/dump-class-layout:
2436         (main):
2437         * lldb/lldb_dump_class_layout.py:
2438         (ClassLayout.__init__):
2439         (ClassLayout._compute_padding_recursive):
2440         (LLDBDebuggerInstance.dump_layout_for_classname):
2441         (LLDBDebuggerInstance):
2442         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2443         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2444
2445 2019-03-12  Chris Dumez  <cdumez@apple.com>
2446
2447         Device Orientation access permission should be denied unless explicitly granted by the client
2448         https://bugs.webkit.org/show_bug.cgi?id=195625
2449
2450         Reviewed by Youenn Fablet.
2451
2452         add API test coverage.
2453
2454         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2455         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2456         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2457         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2458         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2459         (runDeviceOrientationTest):
2460         (TEST):
2461         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2462         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2463
2464 2019-03-12  Jer Noble  <jer.noble@apple.com>
2465
2466         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2467         https://bugs.webkit.org/show_bug.cgi?id=195137
2468         <rdar://problem/48810307>
2469
2470         Reviewed by Eric Carlson.
2471
2472         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2473         (TestWebKitAPI::TEST):
2474
2475 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2476
2477         [ews-build] Change urls from uat to production
2478         https://bugs.webkit.org/show_bug.cgi?id=195566
2479
2480         Reviewed by Lucas Forschler.
2481
2482         * BuildSlaveSupport/ews-app/ews/config.py:
2483         * BuildSlaveSupport/ews-build/events.py:
2484         * BuildSlaveSupport/ews-build/steps.py:
2485
2486 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2487
2488         [ews-build] change max_builds for local-worker to 1
2489         https://bugs.webkit.org/show_bug.cgi?id=195568
2490
2491         Reviewed by Lucas Forschler.
2492
2493         * BuildSlaveSupport/ews-build/loadConfig.py:
2494
2495 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2496
2497         Fix the build
2498
2499         * TestRunnerShared/spi/PencilKitTestSPI.h:
2500         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2501
2502 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2503
2504         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2505         https://bugs.webkit.org/show_bug.cgi?id=194131
2506
2507         Reviewed by Michael Catanzaro.
2508
2509         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2510         (uriChanged):
2511         (testUnfinishedSubresourceLoad):
2512         (serverCallback):
2513         (beforeAll):
2514
2515 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2516
2517         WTF::Expected should use std::addressof instead of operator&
2518         https://bugs.webkit.org/show_bug.cgi?id=195604
2519
2520         Reviewed by Myles Maxfield.
2521
2522         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2523         (TestWebKitAPI::Unique::Unique):
2524         (TestWebKitAPI::Unique::operator&):
2525         (TestWebKitAPI::TEST):
2526
2527 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2528
2529         Add Optional to Forward.h.
2530         https://bugs.webkit.org/show_bug.cgi?id=195586
2531
2532         Reviewed by Darin Adler.
2533
2534         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2535         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2536         Remove unnecessary includes from headers.
2537
2538 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2539
2540         Add testing API to hit-test and scroll overflow scrollers
2541         https://bugs.webkit.org/show_bug.cgi?id=195278
2542
2543         Reviewed by Antti Koivisto.
2544         
2545         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2546         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2547         
2548         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2549
2550         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2551         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2552         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2553         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2554         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2555         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2556         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2557         (WTR::enclosingScrollViewIncludingSelf):
2558         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2559
2560 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2561
2562         API test WebKit.RequestTextInputContext fails on iOS
2563         https://bugs.webkit.org/show_bug.cgi?id=195585
2564
2565         Reviewed by Wenson Hsieh and Simon Fraser.
2566
2567         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2568         (applyStyle):
2569         (TEST):
2570         Add a viewport, so that the coordinates match up on iOS.
2571         Scroll by moving the UIScrollView's contentOffset.
2572
2573 2019-03-11  Chris Dumez  <cdumez@apple.com>
2574
2575         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2576         https://bugs.webkit.org/show_bug.cgi?id=195506
2577         <rdar://problem/48733477>
2578
2579         Reviewed by Alex Christensen.
2580
2581         Add API test coverage.
2582
2583         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2584
2585 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2586
2587         Adding myself to contributors.json
2588
2589         Unreviewed, addming myself to contributors.json .
2590
2591         * Scripts/webkitpy/common/config/contributors.json:
2592
2593 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2594
2595         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2596         https://bugs.webkit.org/show_bug.cgi?id=195511
2597         <rdar://problem/44873269>
2598
2599         Reviewed by Darin Adler.
2600
2601         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2602         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2603         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2604         (TEST_F):
2605
2606 2019-03-11  Chris Dumez  <cdumez@apple.com>
2607
2608         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2609         https://bugs.webkit.org/show_bug.cgi?id=195561
2610
2611         Reviewed by Youenn Fablet.
2612
2613         Make sure the JS in the test requests for permission to receive device orientation events.
2614
2615         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2616
2617 2019-03-11  Youenn Fablet  <youenn@apple.com>
2618
2619         Allow storage quota increase by default in WTR
2620         https://bugs.webkit.org/show_bug.cgi?id=195541
2621
2622         Reviewed by Geoffrey Garen.
2623
2624         Allow storage quota increase by default in WTR.
2625         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2626         Use this for tests that explicitly need cache increase.
2627
2628         Instead of increasing quota by 2, make sure the next request is
2629         granted by adding all given parameters.
2630
2631         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2632         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2633         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2634         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2635         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2636         * WebKitTestRunner/TestController.cpp:
2637         (WTR::TestController::setAllowStorageQuotaIncrease):
2638         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2639         * WebKitTestRunner/TestController.h:
2640         * WebKitTestRunner/TestInvocation.cpp:
2641         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2642         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2643         (WTR::TestController::cocoaResetStateToConsistentValues):
2644         (WTR::TestController::setAllowStorageQuotaIncrease):
2645         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2646         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2647         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2648
2649 2019-03-11  Xan Lopez  <xan@igalia.com>
2650
2651         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2652         https://bugs.webkit.org/show_bug.cgi?id=194147
2653
2654         Reviewed by Michael Saboff.
2655
2656         To make --32-bit work correctly on Linux/64bit we need to:
2657
2658         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2659         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2660         unfortunately CMake only allows us to do this during
2661         crosscompilation, which is overkill here.
2662         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2663         pkg-config detection module uses the x86 .pc files instead of the
2664         x86_64 ones.
2665         - Set the -m32 flags for the compiler.
2666
2667         * Scripts/webkitdirs.pm:
2668         (generateBuildSystemFromCMakeProject):
2669
2670 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2671
2672         Add MotionMark-1.1 plan file for run-benchmark script.
2673         https://bugs.webkit.org/show_bug.cgi?id=195481
2674
2675         Rubber-stamped by Darin Adler.
2676
2677         Run-benchmark script should support MontionMark-1.1.
2678
2679         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2680
2681 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2682
2683         [ews-app] Add support for submit-to-ews url
2684         https://bugs.webkit.org/show_bug.cgi?id=195477
2685
2686         Reviewed by Lucas Forschler.
2687
2688         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2689         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2690         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2691         * BuildSlaveSupport/ews-app/ews/urls.py:
2692         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2693
2694 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2695
2696         Unreviewed, rolling out r242688, r242643, r242624.
2697
2698         Caused multiple layout test failures and crashes on iOS and macOS.
2699
2700         Reverted changeset:
2701
2702         "requestAnimationFrame should execute before the next frame"
2703         https://bugs.webkit.org/show_bug.cgi?id=177484
2704         https://trac.webkit.org/changeset/242624/webkit
2705
2706         * Tracing/SystemTracePoints.plist:
2707
2708 2019-03-11  John Wilander  <wilander@apple.com>
2709
2710         Resource Load Statistics: Make it possible exclude localhost from classification
2711         https://bugs.webkit.org/show_bug.cgi?id=195474
2712         <rdar://problem/47520577>
2713
2714         Reviewed by Brent Fulgham.
2715
2716         This patch allows for localhost to be excluded from classification and
2717         treatment as a prevalent resource.
2718
2719         The WebKit Tools change adds a new function called
2720         testRunner.setStatisticsIsRunningTest() which can be used to control this
2721         behavior.
2722
2723         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2724         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2725         (WTR::TestRunner::setStatisticsIsRunningTest):
2726         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2727         * WebKitTestRunner/TestController.cpp:
2728         (WTR::TestController::setStatisticsIsRunningTest):
2729         * WebKitTestRunner/TestController.h:
2730         * WebKitTestRunner/TestInvocation.cpp:
2731         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2732
2733 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2734
2735         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2736         https://bugs.webkit.org/show_bug.cgi?id=195560
2737
2738         Reviewed by Lucas Forschler.
2739
2740         * BuildSlaveSupport/ews-build/master.cfg:
2741
2742 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2743
2744         Unreviewed, rolling out r242698.
2745
2746         API test crashes on bots.
2747
2748         Reverted changeset:
2749
2750         "Add a WKContentRuleList variant that uses copied memory
2751         instead of mmap'd shared memory for class A containerized
2752         apps"
2753         https://bugs.webkit.org/show_bug.cgi?id=195511
2754         https://trac.webkit.org/changeset/242698
2755
2756 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2757
2758         [WPE] Enable web process sandbox
2759         https://bugs.webkit.org/show_bug.cgi?id=195169
2760
2761         Reviewed by Daniel Bates.
2762
2763         * wpe/install-dependencies:
2764         * wpe/jhbuild.modules:
2765
2766 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2767
2768         [ews-app] Use port 17000 for worker communication
2769         https://bugs.webkit.org/show_bug.cgi?id=195558
2770
2771         Reviewed by Lucas Forschler.
2772
2773         * BuildSlaveSupport/ews-build/master.cfg:
2774
2775 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2776
2777         [ews-build] unit-tests fail when passwords.json is missing
2778         https://bugs.webkit.org/show_bug.cgi?id=195557
2779
2780         Reviewed by Lucas Forschler.
2781
2782         * BuildSlaveSupport/ews-build/loadConfig.py:
2783         (loadBuilderConfig):
2784         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2785         (ConfigDotJSONTest.test_configuration):
2786         * BuildSlaveSupport/ews-build/master.cfg:
2787
2788 2019-03-11  Truitt Savell  <tsavell@apple.com>
2789
2790         Unreviewed, rolling out r242702.
2791
2792         Broke High Sierra builders.
2793
2794         Reverted changeset:
2795
2796         "Add utility function to allow easy reverse range-based
2797         iteration of a container"
2798         https://bugs.webkit.org/show_bug.cgi?id=195542
2799         https://trac.webkit.org/changeset/242702
2800
2801 2019-03-11  Sam Weinig  <sam@webkit.org>
2802
2803         Add utility function to allow easy reverse range-based iteration of a container
2804         https://bugs.webkit.org/show_bug.cgi?id=195542
2805
2806         Reviewed by Antti Koivisto.
2807
2808         * TestWebKitAPI/CMakeLists.txt:
2809         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2810         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2811         (TestWebKitAPI::TEST):
2812         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2813
2814 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2815
2816         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2817         https://bugs.webkit.org/show_bug.cgi?id=195511
2818         <rdar://problem/44873269>
2819
2820         Reviewed by Darin Adler.
2821
2822         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2823         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2824         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2825         (TEST_F):
2826
2827 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2828
2829         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2830         https://bugs.webkit.org/show_bug.cgi?id=195499
2831
2832         Reviewed by Darin Adler.
2833
2834         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2835         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2836         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2837         (-[WKWebView synchronouslyFocusTextInputContext:]):
2838         (applyStyle):
2839         (applyIframe):
2840         (TEST):
2841         Add some tests for this SPI.
2842
2843 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2844
2845         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2846         https://bugs.webkit.org/show_bug.cgi?id=181151
2847
2848         Reviewed by Don Olmstead.
2849
2850         * TestWebKitAPI/CMakeLists.txt:
2851         * TestWebKitAPI/PlatformWin.cmake:
2852         Enable TestWTF RunLoop tests in all platforms.
2853
2854         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2855         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2856         (TestWebKitAPI::DerivedOneShotTimer::fired):
2857         (TestWebKitAPI::TEST):
2858         Only a few platforms support nested RunLoop.
2859
2860         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2861         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2862
2863 2019-03-10  David Quesada  <david_quesada@apple.com>
2864
2865         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2866         https://bugs.webkit.org/show_bug.cgi?id=152480
2867
2868         Reviewed by Chris Dumez.
2869
2870         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2871         there are no additional references to the process pool besides the one held by
2872         the download, waits for the download to finish (in the sense that the
2873         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2874         measure, also check that the process pool has been deallocated at the end of the
2875         test. The test wouldn't be meaningful if the process pool were still alive.
2876
2877         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2878         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2879         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2880             The download will be canceled because the delegate does not implement the
2881             method to decide the download's destination, so this is where we know the
2882             DownloadProxyMap is done with the DownloadProxy.
2883         (TEST):
2884
2885 2019-03-08  Chris Dumez  <cdumez@apple.com>
2886
2887         Add support for Device Orientation / Motion permission API
2888         https://bugs.webkit.org/show_bug.cgi?id=195329
2889         <rdar://problem/47645367>
2890
2891         Reviewed by Geoffrey Garen.
2892
2893         Add test infrastructure to help test the Device Orientation / Motion permission API.
2894
2895         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2896         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2897         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2898         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2899         * WebKitTestRunner/TestController.cpp:
2900         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2901         (WTR::TestController::createWebViewWithOptions):
2902         (WTR::TestController::resetStateToConsistentValues):
2903         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2904         * WebKitTestRunner/TestController.h:
2905         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2906         * WebKitTestRunner/TestInvocation.cpp:
2907         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2908
2909 2019-03-08  Saam barati  <sbarati@apple.com>
2910
2911         Add a compare-results script to compare benchmark results
2912         https://bugs.webkit.org/show_bug.cgi?id=195486
2913         <rdar://problem/48723397>
2914
2915         Reviewed by Geoffrey Garen.
2916
2917         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2918         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2919         to extend it to learn about our other benchmarks.
2920
2921         * Scripts/compare-results: Added.
2922         (readJSONFile):
2923         (detectJetStream2):
2924         (JetStream2Results):
2925         (detectSpeedometer2):
2926         (Speedometer2Results):
2927         (detectPLT5):
2928         (PLT5Results):
2929         (detectBenchmark):
2930         (biggerIsBetter):
2931         (ttest):
2932         (getOptions):
2933         (main):
2934
2935 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2936
2937         Ensure old tab state is cleared between iterations of run-benchmark
2938         https://bugs.webkit.org/show_bug.cgi?id=195393
2939         <rdar://problem/46885583>
2940
2941         Reviewed by Dewei Zhu.
2942
2943         a) ensure the default to restore state is not set
2944         b) terminate Safari correctly
2945         c) Set the system default to ignore Persistent State in Safari
2946
2947         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2948         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2949         (OSXBrowserDriver.prepare_env): 
2950         (OSXBrowserDriver.restore_env):
2951         (OSXBrowserDriver.close_browsers):
2952         (OSXBrowserDriver._terminate_processes):
2953         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2954         (OSXChromeDriver):
2955         (OSXChromeCanaryDriver):
2956         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2957         (OSXFirefoxDriver):
2958         (OSXFirefoxNightlyDriver):
2959         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2960         (OSXSafariDriver):
2961         (OSXSafariDriver.prepare_env):
2962
2963 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2964
2965         [GTK] Several InputMethodFilter tests are failing
2966         https://bugs.webkit.org/show_bug.cgi?id=195408
2967
2968         Reviewed by Carlos Garcia Campos.
2969
2970         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2971         Regressed in r241751.
2972         Hexadecimal values of keycodes are expressed now in upper letters.
2973         Composited characters should be cast to UTF8 strings.
2974
2975         (TestWebKitAPI::TEST):
2976
2977 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2978
2979         [GTK] Make Tools/gtkdoc python3 compatible
2980         https://bugs.webkit.org/show_bug.cgi?id=195359
2981
2982         Reviewed by Carlos Garcia Campos.
2983
2984         * gtkdoc/generate-gtkdoc:
2985         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2986         work with Python 2 and 3.
2987         (get_gtkdoc_module_paths):
2988         The iteritems() was removed in Python 3, so let's use items() that's
2989         available in Python 2 and 3.
2990         (get_generator_for_config):
2991         * gtkdoc/gtkdoc.py:
2992         (GTKDoc._run_command):
2993         The sys.stdout.write() is expecting str in Python 3 and not bytes
2994         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2995         for passing the bytes there.
2996
2997 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2998
2999         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3000         https://bugs.webkit.org/show_bug.cgi?id=195346
3001         <rdar://problem/48667048>
3002
3003         Unreviewed build fix for clang-cl.
3004
3005         * DumpRenderTree/win/DumpRenderTree.cpp:
3006         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3007
3008 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3009
3010         requestAnimationFrame should execute before the next frame
3011         https://bugs.webkit.org/show_bug.cgi?id=177484
3012
3013         Reviewed by Simon Fraser.
3014
3015         Add trace points for the page RenderingUpdate.
3016
3017         * Tracing/SystemTracePoints.plist:
3018
3019 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3020
3021         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3022         https://bugs.webkit.org/show_bug.cgi?id=195353
3023         <rdar://problem/48626394>
3024
3025         Reviewed by Simon Fraser.
3026
3027         * WebKitTestRunner/ios/TestControllerIOS.mm:
3028         (WTR::TestController::platformResetPreferencesToConsistentValues):
3029
3030 2019-03-07  John Wilander  <wilander@apple.com>
3031
3032         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3033         https://bugs.webkit.org/show_bug.cgi?id=195383
3034         <rdar://problem/48570136>
3035
3036         Reviewed by Brent Fulgham.
3037
3038         This patch adds test infrastructure to purge only script-accessible cookies,
3039         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3040
3041         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3042         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3043         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3044         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3045         * WebKitTestRunner/TestController.cpp:
3046         (WTR::TestController::statisticsDeleteCookiesForHost):
3047         * WebKitTestRunner/TestController.h:
3048         * WebKitTestRunner/TestInvocation.cpp:
3049         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3050
3051 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3052
3053         Unreviewed, rolling out r242354.
3054         https://bugs.webkit.org/show_bug.cgi?id=195402
3055
3056         breaks layout tests in all configurations (Requested by
3057         zdobersek on #webkit).
3058
3059         Reverted changeset:
3060
3061         "[WPE] Enable web process sandbox"
3062         https://bugs.webkit.org/show_bug.cgi?id=195169
3063         https://trac.webkit.org/changeset/242354
3064
3065 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3066
3067         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3068         https://bugs.webkit.org/show_bug.cgi?id=195346
3069
3070         Reviewed by Fujii Hironori.
3071
3072         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3073         (TestWebKitAPI::TEST):
3074         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3075
3076         * DumpRenderTree/win/DumpRenderTree.cpp:
3077         (findFontFallback):
3078         (addFontFallbackIfPresent):
3079         (removeFontFallbackIfPresent):
3080         (main):
3081         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3082         (TestWebKitAPI::Util::moduleDirectory):
3083         (TestWebKitAPI::Util::createInjectedBundlePath):
3084         Use wchar helpers as needed.
3085
3086 2019-03-06  Rob Buis  <rbuis@igalia.com>
3087
3088         Consider supporting the `referrerpolicy` attribute.
3089         https://bugs.webkit.org/show_bug.cgi?id=179053
3090
3091         Reviewed by Darin Adler.
3092
3093         Add a runtime flag for referrerpolicy attribute.
3094
3095         * DumpRenderTree/mac/DumpRenderTree.mm:
3096         (enableExperimentalFeatures):
3097
3098 2019-03-05  Daniel Bates  <dabates@apple.com>
3099
3100         Update expected API test result following r242379
3101         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3102
3103         Update expected x-coordinate of selection rect now that the left padding of
3104         a textarea is sized in ems (so dependent on the font size) just like the left
3105         padding of a text field.
3106
3107         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3108         (TestWebKitAPI::TEST):
3109
3110 2019-03-05  David Quesada  <david_quesada@apple.com>
3111
3112         [WK2] It should be possible to follow links with 'download' attributes
3113         https://bugs.webkit.org/show_bug.cgi?id=195145
3114         rdar://problem/48462642
3115
3116         Reviewed by Alex Christensen.
3117
3118         Add a unit test to verify that activating links with 'download' attributes now
3119         navigates to the linked resource, rather than starts downloading it. Add another
3120         to verify that it is still possible to explicitly download the link via the
3121         'Download' navigation action policy.
3122
3123         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3124         (-[DownloadAttributeTestDelegate init]):
3125         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3126         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3127         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3128         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3129         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3130         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3131         (TEST):
3132         * WebKitTestRunner/TestController.cpp:
3133         (WTR::TestController::decidePolicyForNavigationAction):
3134         * WebKitTestRunner/TestController.h:
3135
3136 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3137
3138         [Curl] Implement Cookie Accept Policy.
3139         https://bugs.webkit.org/show_bug.cgi?id=191645
3140
3141         Reviewed by Fujii Hironori.
3142
3143         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3144         (TestWebKitAPI::Curl::TEST_F):
3145
3146 2019-03-05  Youenn Fablet  <youenn@apple.com>
3147
3148         Rename requestCacheStorageSpace to requestStorageSpace
3149         https://bugs.webkit.org/show_bug.cgi?id=195282
3150
3151         Reviewed by Chris Dumez.
3152
3153         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3154         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3155         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3156
3157 2019-03-05  Brady Eidson  <beidson@apple.com>
3158
3159         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3160         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3161
3162         Reviewed by Tim Horton.
3163
3164         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3165         different directory into that same WKWebView should work.
3166
3167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3168         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3169
3170 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3171
3172         Add WeakHashSet
3173         https://bugs.webkit.org/show_bug.cgi?id=195152
3174
3175         Reviewed by Antti Koivisto.
3176
3177         Added tests for WeakHashSet.
3178
3179         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3180         (TestWebKitAPI::Base::Base): Moved.
3181         (TestWebKitAPI::Derived::foo): Moved.
3182         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3183         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3184         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3185         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3186
3187 2019-03-04  Chris Dumez  <cdumez@apple.com>
3188
3189         Do not share WebProcesses between private and regular sessions
3190         https://bugs.webkit.org/show_bug.cgi?id=195189
3191         <rdar://problem/48421064>
3192
3193         Reviewed by Alex Christensen.
3194
3195         Add API test coverage.
3196
3197         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3198         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3199
3200 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3201
3202         [WPE] Enable web process sandbox
3203         https://bugs.webkit.org/show_bug.cgi?id=195169
3204
3205         Reviewed by Daniel Bates.
3206
3207         * wpe/install-dependencies:
3208         * wpe/jhbuild.modules:
3209
3210 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3211
3212         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3213         https://bugs.webkit.org/show_bug.cgi?id=195206
3214
3215         Reviewed by Žan Doberšek.
3216
3217         Add a new test case.
3218
3219         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3220         (testJSCClass):
3221
3222 2019-03-04  Charlie Turner  <cturner@igalia.com>
3223
3224         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3225         https://bugs.webkit.org/show_bug.cgi?id=194898
3226
3227         Reviewed by Žan Doberšek.
3228
3229         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3230         a GCC extension that permits arithmetic on void* pointer. Inline
3231         the macro until this issue is fixed upstream.
3232
3233 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3234
3235         Rid the world of WK_API_ENABLED
3236         https://bugs.webkit.org/show_bug.cgi?id=195263
3237
3238         Reviewed by Dan Bernstein.
3239
3240         List of changed files elided because it's useless.
3241
3242 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3243
3244         Unreviewed follow-up to r242292.
3245
3246         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3247
3248         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3249         (TestWebKitAPI::testStrip): Renamed from strip.
3250         (TestWebKitAPI::TEST):
3251
3252 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3253
3254         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3255
3256         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3257         and bug #194272 for details.
3258
3259         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3260
3261 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3262
3263         Remove some more unused 32-bit code
3264         https://bugs.webkit.org/show_bug.cgi?id=195255
3265
3266         Reviewed by Darin Adler.
3267
3268         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3269         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3270         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3271         (NPP_New):
3272         (NPP_HandleEvent):
3273         (handleEventCarbon): Deleted.
3274
3275 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3276
3277         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3278
3279         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3280         (TestWebKitAPI::TEST):
3281
3282 2019-03-01  Darin Adler  <darin@apple.com>
3283
3284         Finish removing String::format
3285         https://bugs.webkit.org/show_bug.cgi?id=194893
3286
3287         Reviewed by Daniel Bates.
3288 '
3289         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3290
3291 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3292
3293         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3294         https://bugs.webkit.org/show_bug.cgi?id=195229
3295         <rdar://problem/48520362>
3296
3297         Reviewed by Chris Dumez.
3298
3299         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3300         (TEST):
3301
3302 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3303
3304         Add a system trace scope for event region building
3305         https://bugs.webkit.org/show_bug.cgi?id=195226
3306
3307         Reviewed by Jon Lee.
3308
3309         This trace scope measures the time spend converting element rects into Region objects,
3310         which can be large on some pages.
3311
3312         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3313
3314         * Tracing/SystemTracePoints.plist:
3315
3316 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3317
3318         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3319         https://bugs.webkit.org/show_bug.cgi?id=194612
3320
3321         Reviewed by Alex Christensen.
3322
3323         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3324         Just test the new string-processing function and don't touch the actual environment.
3325         (Test cases are all as before, but based on operator== instead of strcmp.)
3326
3327 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3328
3329         [ews-app] Update primary keys for handling multiple Buildbot instances
3330         https://bugs.webkit.org/show_bug.cgi?id=195120
3331
3332         Reviewed by Stephanie Lewis.
3333
3334         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3335         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3336         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3337
3338         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3339         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3340         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3341         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3342         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3343         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3344
3345 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3346
3347         [WinCairo] Enable service worker
3348         https://bugs.webkit.org/show_bug.cgi?id=188318
3349
3350         Reviewed by Youenn Fablet.
3351
3352         * DumpRenderTree/DumpRenderTreePrefix.h:
3353         * TestWebKitAPI/PlatformWin.cmake:
3354         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3355         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3356         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3357
3358 2019-03-01  Justin Fan  <justin_fan@apple.com>
3359
3360         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3361         https://bugs.webkit.org/show_bug.cgi?id=195191
3362
3363         Rubber-stamped by Dean Jackson.
3364
3365         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3366
3367         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3368
3369 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3370
3371         Unreviewed, fix lldb webkitpy tests
3372         https://bugs.webkit.org/show_bug.cgi?id=194375
3373
3374         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3375
3376         * lldb/lldb_webkit.py:
3377         (WTFStringImplProvider.is_8bit):
3378
3379 2019-02-28  David Quesada  <david_quesada@apple.com>
3380
3381         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3382         https://bugs.webkit.org/show_bug.cgi?id=195121
3383         rdar://problem/48450302
3384
3385         Reviewed by Alex Christensen.
3386
3387         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3388         configurations where the 'download' attribute is absent, blank, or populated
3389         with a filename, and where the anchor element is same-origin or cross-origin
3390         (meaning the 'download' attribute shouldn't be honored).
3391
3392         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3393         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3394         (-[NavigationActionTestDelegate init]):
3395         (-[NavigationActionTestDelegate navigationAction]):
3396         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3397         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3398         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3399         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3400         (TEST):
3401
3402 2019-02-28  Antoine Quint  <graouts@apple.com>
3403
3404         Enable the Pointer Events runtime flag by default
3405         https://bugs.webkit.org/show_bug.cgi?id=195156
3406
3407         Reviewed by Dean Jackson.
3408
3409         * DumpRenderTree/mac/DumpRenderTree.mm:
3410         (enableExperimentalFeatures):
3411
3412 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3413
3414         Several PasteImage API tests are flaky
3415         https://bugs.webkit.org/show_bug.cgi?id=195160
3416
3417         Reviewed by Tim Horton.
3418
3419         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3420         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3421         listening for a "load" event after image load is already complete.
3422
3423         To address this, make these tests first register a "load" event handler, then run script to insert an image
3424         element into the document, and finally wait until the load event is observed before checking image size.
3425
3426         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3427
3428 2019-02-28  Chris Dumez  <cdumez@apple.com>
3429
3430         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3431         https://bugs.webkit.org/show_bug.cgi?id=195107
3432
3433         Reviewed by Alex Christensen.
3434
3435         Give some time for the zoom level to get restored.
3436
3437         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3438
3439 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3440
3441         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3442         https://bugs.webkit.org/show_bug.cgi?id=194958
3443
3444         Reviewed by Geoffrey Garen.
3445
3446         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3447         (TEST):
3448
3449 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3450
3451         [ews-app] Update method to save build to handle builder_display_name
3452         https://bugs.webkit.org/show_bug.cgi?id=195047
3453
3454         Reviewed by Dewei Zhu.
3455
3456         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3457         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3458
3459 2019-02-28  Justin Fan  <justin_fan@apple.com>
3460
3461         [Web GPU] Enable Web GPU only on 64-bit
3462         https://bugs.webkit.org/show_bug.cgi?id=195139
3463
3464         Because Metal is only supported on 64 bit apps.
3465
3466         Unreviewed build fix.
3467
3468         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3469
3470 2019-02-27  Youenn Fablet  <youenn@apple.com>
3471
3472         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3473         https://bugs.webkit.org/show_bug.cgi?id=194959
3474
3475         Reviewed by Chris Dumez.
3476
3477         Spin loop until getting the condition to remove flakiness.
3478
3479         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3480
3481 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3482
3483         [ews-build] Buildbot should include builder_display_name in the build events
3484         https://bugs.webkit.org/show_bug.cgi?id=195045
3485
3486         Reviewed by Dewei Zhu.
3487
3488         * BuildSlaveSupport/ews-build/events.py:
3489         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3490         buildername to builder_name to be consistent in naming style.
3491         (Events.buildFinished): Ditto.
3492
3493 2019-02-27  Chris Dumez  <cdumez@apple.com>
3494
3495         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3496         https://bugs.webkit.org/show_bug.cgi?id=194480
3497
3498         Reviewed by Brady Eidson.
3499
3500         Update existing API test to make it more likely to reproduce the issue.
3501
3502         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3503
3504 2019-02-27  Brady Eidson  <beidson@apple.com>
3505
3506         Universal links from Google search results pages don't open the app.
3507         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3508
3509         Reviewed by Geoffrey Garen.
3510
3511         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3512         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3513         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3514         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3515
3516 2019-02-27  Chris Dumez  <cdumez@apple.com>
3517
3518         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3519         https://bugs.webkit.org/show_bug.cgi?id=195102
3520
3521         Reviewed by Geoffrey Garen.
3522
3523         If the number of processes is not yet what we expect, wait a bit and check again to give
3524         processes some time to exit.
3525
3526         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3527
3528 2019-02-27  Chris Dumez  <cdumez@apple.com>
3529
3530         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3531         https://bugs.webkit.org/show_bug.cgi?id=194545
3532
3533         Reviewed by Brady Eidson.
3534
3535         Make sure the test navigates forward and then back only once. Previously, navigating
3536         back would trigger a navigation again in a timer.
3537
3538         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3539
3540 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3541
3542         High Sierra Debug JSC test queue should use faster hardware
3543         https://bugs.webkit.org/show_bug.cgi?id=194603
3544
3545         Rubber-stamped by Alexey Proskuryakov.
3546
3547         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3548
3549         * BuildSlaveSupport/build.webkit.org-config/config.json:
3550         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3551         (BubbleQueueServer):
3552         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3553         (WebKitBuildbot):
3554         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3555         * QueueStatusServer/config/queues.py:
3556         * Scripts/webkitpy/common/config/ews.json:
3557         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3558         (test_ews_name):
3559
3560 2019-02-27  John Wilander  <wilander@apple.com>
3561
3562         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3563         https://bugs.webkit.org/show_bug.cgi?id=195071
3564         <rdar://problem/48417690>
3565
3566         Reviewed by Alex Christensen and Brent Fulgham.
3567
3568         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3569         (TestWebKitAPI::createURL):
3570             Convenience function.
3571         (TestWebKitAPI::TEST):
3572             WebCore::AdClickAttribution now takes a URL when creating Source and
3573             Destination.
3574         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3575         (TestWebKitAPI::TEST):
3576             WebCore::AdClickAttribution now takes a URL when creating Source and
3577             Destination.
3578
3579 2019-02-27  Antoine Quint  <graouts@apple.com>
3580
3581         Support Pointer Events on macOS
3582         https://bugs.webkit.org/show_bug.cgi?id=195008
3583         <rdar://problem/47454419>
3584
3585         Reviewed by Dean Jackson.
3586
3587         * DumpRenderTree/mac/DumpRenderTree.mm:
3588         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3589         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3590
3591 2019-02-26  Mark Lam  <mark.lam@apple.com>
3592
3593         Remove remaining poisoning code.
3594         https://bugs.webkit.org/show_bug.cgi?id=194138
3595
3596         Reviewed by Saam Barati.
3597
3598         * TestWebKitAPI/CMakeLists.txt:
3599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3600         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3601         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3602         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3603         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3604         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3605         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3606
3607 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3608
3609         Move ephemeral local storage from WebProcess to UIProcess
3610         https://bugs.webkit.org/show_bug.cgi?id=195074
3611         <rdar://problem/47937975>
3612
3613         Reviewed by Geoff Garen.
3614
3615         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3616
3617 2019-02-20  Jer Noble  <jer.noble@apple.com>
3618
3619         [Cocoa] Media elements will restart network buffering just before suspending
3620         https://bugs.webkit.org/show_bug.cgi?id=193691
3621
3622         Reviewed by Eric Carlson.
3623
3624         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3625         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3626         (TEST):
3627
3628 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3629
3630         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3631         https://bugs.webkit.org/show_bug.cgi?id=191652
3632
3633         Reviewed by Alex Christensen.
3634
3635         Fix WinCairo MiniBrowser behavior of authentication dialog.
3636
3637         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3638         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3639
3640 2019-02-26  Youenn Fablet  <youenn@apple.com>
3641
3642         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3643         https://bugs.webkit.org/show_bug.cgi?id=195028
3644         <rdar://problem/48243733>
3645
3646         Reviewed by Eric Carlson.
3647
3648         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3649
3650 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3651
3652         [WPE] Add API for webview background color configuration
3653         https://bugs.webkit.org/show_bug.cgi?id=192305
3654
3655         Reviewed by Michael Catanzaro.
3656
3657         * MiniBrowser/wpe/main.cpp:
3658         (main): Add a new option to configure the webview background
3659         color. Example: --bg-color=transparent.
3660         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3661         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3662         (beforeAll): Ditto.
3663
3664 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3665
3666         scalableNativeWebpageParameters() is not preserved on new page navigation.
3667         https://bugs.webkit.org/show_bug.cgi?id=194892
3668         <rdar://problem/47538280>
3669
3670         Reviewed by Wenson Hsieh.
3671         
3672         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3673
3674         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3675         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3676         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3677         (WTR::UIScriptController::allowsViewportShrinkToFit):
3678         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3679         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3680         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3681         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3682         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3683         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3684
3685 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3686
3687         [ews-app] Add model for handling multiple Buildbot instances
3688         https://bugs.webkit.org/show_bug.cgi?id=194863
3689
3690         Reviewed by Stephanie Lewis.
3691
3692         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3693
3694 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3695
3696         [ews-app] Remove BuilderMapping table
3697         https://bugs.webkit.org/show_bug.cgi?id=194961
3698
3699         Reviewed by Stephanie Lewis.
3700
3701         Store builder name directly in build table, instead of having a separate
3702         table for it.
3703
3704         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3705         * BuildSlaveSupport/ews-app/ews/models/build.py:
3706         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3707         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3708
3709 2019-02-25  John Wilander  <wilander@apple.com>
3710
3711         Introduce and adopt new class RegistrableDomain for eTLD+1
3712         https://bugs.webkit.org/show_bug.cgi?id=194791
3713         <rdar://problem/48179240>
3714
3715         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3716
3717         This patch adds an API test and replaces two instances of
3718         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3719
3720         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3721         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3722         (TestWebKitAPI::TEST):
3723             Changed two strings to make sure the registrable domains are still considered
3724             invalid and pass the test.
3725         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3726         (TestWebKitAPI::TEST):
3727         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3728         (WTR::InjectedBundle::didReceiveMessageToPage):
3729
3730 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3731
3732         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3733         https://bugs.webkit.org/show_bug.cgi?id=195001
3734
3735         Reviewed by Carlos Garcia Campos.
3736
3737         API version 1.0 always includes the functionality previously guarded with
3738         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3739         unconditionally.
3740
3741         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3742         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3743         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3744         (WebViewTest::showInWindow): Ditto.
3745         (WebViewTest::hideView): Ditto.
3746         * wpe/backends/HeadlessViewBackend.cpp:
3747         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3748         * wpe/backends/ViewBackend.cpp:
3749         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3750         * wpe/backends/WindowViewBackend.cpp:
3751         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3752         WPE_BACKEND_CHECK_VERSION().
3753         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3754
3755 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3756
3757         [Flatpak] Add support for flatpak > 1.1.2
3758         https://bugs.webkit.org/show_bug.cgi?id=194088
3759
3760         Flatpak 1.2 is now out so we need to support that
3761         version now.
3762
3763         Reviewed by Michael Catanzaro.
3764
3765         * flatpak/flatpakutils.py:
3766         (check_flatpak):
3767         (FlatpakPackages.__init__):
3768         (FlatpakPackages.__detect_packages):
3769         (FlatpakPackages.__detect_packages.in):
3770         (FlatpakRepos.update):
3771
3772 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3773
3774         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3775         https://bugs.webkit.org/show_bug.cgi?id=194998
3776
3777         Reviewed by Carlos Garcia Campos.
3778
3779         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3780         to a Git checkout and using the latest commit containing various fixes
3781         and improvements.
3782
3783 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3784
3785         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3786         https://bugs.webkit.org/show_bug.cgi?id=194981
3787
3788         Reviewed by Žan Doberšek.
3789
3790         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3791         (TestWebKitAPI::TEST):
3792
3793 2019-02-23  Keith Miller  <keith_miller@apple.com>
3794
3795         Add new mac target numbers
3796         https://bugs.webkit.org/show_bug.cgi?id=194955
3797
3798         Reviewed by Tim Horton.
3799
3800         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3801         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3802         * MiniBrowser/Configurations/Base.xcconfig:
3803         * TestWebKitAPI/Configurations/Base.xcconfig:
3804         * WebKitTestRunner/Configurations/Base.xcconfig:
3805
3806 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3807
3808         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3809         https://bugs.webkit.org/show_bug.cgi?id=194846
3810
3811         Reviewed by Don Olmstead.
3812
3813         Added _search_paths() and _port_specific_expectations_files() for
3814         WinCairoPort.
3815
3816         * Scripts/webkitpy/port/win.py:
3817         (WinCairoPort.default_baseline_search_path):
3818         (WinCairoPort):
3819         (WinCairoPort._port_specific_expectations_files):
3820         (WinCairoPort._search_paths):
3821
3822 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3823
3824         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3825         https://bugs.webkit.org/show_bug.cgi?id=194963
3826
3827         Reviewed by Dean Jackson.
3828
3829         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3830         Do a `contains` check instead of `equals`, because in debug builds we
3831         put the GraphicsLayer pointer in a prefix.
3832
3833 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3834
3835         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3836         https://bugs.webkit.org/show_bug.cgi?id=194873
3837         <rdar://problem/46701974>
3838
3839         Reviewed by Tim Horton.
3840
3841         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3842
3843         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3844         (WTR::UIScriptController::menuRect const):
3845         (WTR::UIScriptController::isShowingMenu const):
3846         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3847         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3848         (WTR::UIScriptController::menuRect const):
3849
3850         Add a function to query the bounds of the callout menu in content coordinates.
3851
3852         (WTR::UIScriptController::isShowingMenu const):
3853
3854         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3855
3856         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3857         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3858         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3859         (WTR::UIScriptController::rectForMenuAction const):
3860         (WTR::UIScriptController::menuRect const):
3861         (WTR::UIScriptController::isShowingMenu const):
3862         (WTR::findViewInHierarchyOfType): Deleted.
3863
3864 2019-02-22  Chris Dumez  <cdumez@apple.com>
3865
3866         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3867         https://bugs.webkit.org/show_bug.cgi?id=194954
3868         <rdar://problem/48127957>
3869
3870         Reviewed by Alex Christensen.
3871
3872         Add API test coverage.
3873
3874         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3875         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3876         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3877         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3878
3879 2019-02-22  Chris Dumez  <cdumez@apple.com>
3880
3881         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3882         https://bugs.webkit.org/show_bug.cgi?id=194924
3883         <rdar://problem/48216125>
3884
3885         Reviewed by Geoffrey Garen.
3886
3887         Add API test coverage.
3888
3889         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3890
3891 2019-02-22  Chris Dumez  <cdumez@apple.com>
3892
3893         Unreviewed, disable API test added in r241928 on iOS.
3894
3895         The cache is not enabled on devices with less than 3GB of RAM.
3896
3897         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3898
3899 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3900
3901         Hardcode Visual Viewports on everywhere except iOS WK1
3902         https://bugs.webkit.org/show_bug.cgi?id=194928
3903
3904         Reviewed by Zalan Bujtas.
3905
3906         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3907         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3908         set it to false. The setting has shipped for several years and there's no need to turn
3909         it off now.
3910
3911         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3912         Visual Viewports are not enabled.
3913         
3914         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3915         that only runs in WK2
3916
3917         * MiniBrowser/mac/SettingsController.h:
3918         * MiniBrowser/mac/SettingsController.m:
3919         (-[SettingsController init]):
3920         (-[SettingsController _populateMenu]):
3921         (-[SettingsController validateMenuItem:]):
3922         (-[SettingsController visualViewportEnabled]): Deleted.
3923         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3924         * MiniBrowser/mac/WK1BrowserWindowController.m:
3925         (-[WK1BrowserWindowController didChangeSettings]):
3926         * MiniBrowser/mac/WK2BrowserWindowController.m:
3927         (-[WK2BrowserWindowController didChangeSettings]):
3928
3929 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3930
3931         Discard cached processes when clearing website data store
3932         https://bugs.webkit.org/show_bug.cgi?id=194894
3933
3934         Reviewed by Chris Dumez.
3935
3936         Added a test case.
3937
3938         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3939         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3940
3941 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3942
3943         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3944         https://bugs.webkit.org/show_bug.cgi?id=194914
3945         <rdar://problem/47586889>
3946
3947         Reviewed by Geoffrey Garen.
3948
3949         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3950         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3951         (TEST):
3952         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3953
3954 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3955
3956         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3957         <https://webkit.org/b/194761>
3958
3959         Reviewed by Myles Maxfield.
3960
3961         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3962         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3963         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3964         to use ARC-compliant cast.
3965         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3966         ARC-compliant cast.
3967         (WTR::installFakeHelvetica): Log `error` to console if
3968         CTFontManagerRegisterFontsForURL() fails, but only on supported
3969         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3970         Call CFRelease() on `error` to fix the leak.  Update to use
3971         ARC-compliant cast.
3972         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3973         cast.
3974
3975 2019-02-21  Chris Dumez  <cdumez@apple.com>
3976
3977         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3978         https://bugs.webkit.org/show_bug.cgi?id=194481
3979
3980         Reviewed by Alex Christensen.
3981
3982         Give the processes a chance to shutdown and wait until we reached the expected number
3983         of processes.
3984
3985         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3986
3987 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3988
3989         Fix the macOS build
3990
3991         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3992
3993 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3994
3995         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3996
3997         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3998         I am a backwards.
3999
4000 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4001
4002         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4003
4004         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4005         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4006         We could force on UI-side compositing, but I feel like the test might be more
4007         valuable exercising the normal path on each platform (though the original
4008         bug was also UI-side specific). Though we can't validate that the overlay
4009         layer was installed successfully, there are layout tests that do that.
4010
4011 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4012
4013         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4014         https://bugs.webkit.org/show_bug.cgi?id=194845
4015         <rdar://problem/47944579>
4016
4017         Reviewed by Antti Koivisto.
4018
4019         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4020         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4021
4022 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4023
4024         [LFC][Floats] Add support for placing formatting roots in-between floats.
4025         https://bugs.webkit.org/show_bug.cgi?id=194902
4026
4027         Reviewed by Antti Koivisto.
4028
4029         * LayoutReloaded/misc/LFC-passing-tests.txt:
4030
4031 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4032
4033         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4034         https://bugs.webkit.org/show_bug.cgi?id=194901
4035
4036         Unreviewed build fix.
4037
4038         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4039         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4040         WPEBackend-fdo-0.1 as library name.
4041
4042 2019-02-21  Rob Buis  <rbuis@igalia.com>
4043
4044         Update MIME type parser
4045         https://bugs.webkit.org/show_bug.cgi?id=180526
4046
4047         Reviewed by Darin Adler.
4048
4049         Add tests involving leading and trailing whitespace, non-token
4050         characters and quoted strings.
4051
4052         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4053         (TestWebKitAPI::TEST):
4054
4055 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4056
4057         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4058         https://bugs.webkit.org/show_bug.cgi?id=194884
4059
4060         Reviewed by Michael Catanzaro.
4061
4062         * PlatformWin.cmake:
4063
4064 2019-02-20  Chris Dumez  <cdumez@apple.com>
4065
4066         Add API test for <rdar://problem/47471222>
4067         https://bugs.webkit.org/show_bug.cgi?id=194847
4068
4069         Reviewed by Alex Christensen.
4070
4071         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4072
4073 2019-02-20  Chris Dumez  <cdumez@apple.com>
4074
4075         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4076         https://bugs.webkit.org/show_bug.cgi?id=194872
4077         <rdar://problem/47924500>
4078
4079         Reviewed by Alex Christensen.
4080
4081         Add API test coverage.
4082
4083         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4084
4085 2019-02-20  Jer Noble  <jer.noble@apple.com>
4086
4087         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4088         https://bugs.webkit.org/show_bug.cgi?id=191332
4089
4090         Reviewed by Dean Jackson.
4091
4092         * Scripts/git-is-in-range: Added.
4093
4094 2019-02-20  Andy Estes  <aestes@apple.com>
4095
4096         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4097         https://bugs.webkit.org/show_bug.cgi?id=194869
4098
4099         Rubber-stamped by Jer Noble.
4100
4101         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4102         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4103         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4104         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4105         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4106         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4107
4108 2019-02-20  Chris Dumez  <cdumez@apple.com>
4109
4110         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4111         https://bugs.webkit.org/show_bug.cgi?id=194857
4112         <rdar://problem/47759323>
4113
4114         Reviewed by Alex Christensen.
4115
4116         Add API test coverage.
4117
4118         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4119
4120 2019-02-20  Chris Dumez  <cdumez@apple.com>
4121
4122         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4123         https://bugs.webkit.org/show_bug.cgi?id=194829
4124         <rdar://problem/47889906>
4125
4126         Reviewed by Alexey Proskuryakov.
4127
4128         Every time the TestOptions were changing we were creating both a new Web view and
4129         a new WKContext, which would start a new Network process. In most cases, we only
4130         need to contruct a new Web view and we do can keep reusing the same WKContext.
4131         This patch implements this optimization and thus avoids spinning a lot of new
4132         Network processes while running the layout tests.
4133
4134         * WebKitTestRunner/TestController.cpp:
4135         (WTR::TestController::generateContextConfiguration const):
4136         (WTR::TestController::generatePageConfiguration):
4137         (WTR::TestController::createWebViewWithOptions):
4138         (WTR::TestController::resetPreferencesToConsistentValues):
4139         (WTR::updateTestOptionsFromTestHeader):
4140         * WebKitTestRunner/TestController.h:
4141         * WebKitTestRunner/TestOptions.h:
4142         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4143         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4144         (WTR::TestOptions::hasSameInitializationOptions const):
4145         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4146         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4147         (WTR::TestController::platformAddTestOptions const):
4148
4149 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4150
4151         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4152         https://bugs.webkit.org/show_bug.cgi?id=167941
4153
4154         Reviewed by Carlos Garcia Campos.
4155
4156         * MiniBrowser/gtk/main.c:
4157         (filterSavedCallback): Added.
4158         (main): Support loading a JSON rule set file for content filtering.
4159         * MiniBrowser/wpe/main.cpp:
4160         (filterSavedCallback): Added.
4161         (main): Support loading a JSON rule set file for content filtering.
4162         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4163         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4164         (WTF::derefGPtr): Ditto.
4165         (testEmptyStore):
4166         (testSaveInvalidFilter):
4167         (testSaveLoadFilter):
4168         (testSavedFilterIdentifierMatch):
4169         (testRemoveFilter):
4170         (testSaveMultipleFilters):
4171         (testSaveFilterFromFile):
4172         (testFilterPersistence):
4173         (beforeAll):
4174         (afterAll):
4175         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4176         (removeOldInjectedContentAndResetLists): Also reset content filters.
4177         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4178         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4179         the element affected by the style sheet.
4180         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4181         and returns it to be used by tests.
4182         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4183         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4184         (serverCallback): Add support for serving a CSS style sheet for testing.
4185         (beforeAll): Add call to testUserContentManagerContentFilter().
4186         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4187
4188 2019-02-19  Keith Rollin  <krollin@apple.com>
4189
4190         Add timing information to build output
4191         https://bugs.webkit.org/show_bug.cgi?id=194839
4192         <rdar://problem/48219609>
4193
4194         Reviewed by Alexey Proskuryakov.
4195
4196         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4197         emit each project's build time to its output. E.g.,
4198
4199             ** BUILD SUCCEEDED ** [0.132 sec]
4200
4201         * Scripts/webkitdirs.pm:
4202         (XcodeOptions):
4203
4204 2019-02-19  Truitt Savell  <tsavell@apple.com>
4205
4206         Unreviewed, rolling out r241784.
4207
4208         Broke all OpenSource builds.
4209
4210         Reverted changeset:
4211
4212         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4213         instances view"
4214         https://bugs.webkit.org/show_bug.cgi?id=172848
4215         https://trac.webkit.org/changeset/241784
4216
4217 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4218
4219         [LFC][Floats] Remove redundant intersecting logic
4220         https://bugs.webkit.org/show_bug.cgi?id=194804
4221
4222         Reviewed by Antti Koivisto.
4223
4224         * LayoutReloaded/misc/LFC-passing-tests.txt:
4225
4226 2019-02-19  Dean Jackson  <dino@apple.com>
4227
4228         Clean-up output from generate-xcfilelists so it can be filtered
4229         https://bugs.webkit.org/show_bug.cgi?id=194795
4230
4231         Reviewed by Joseph Pecoraro (and Keith Rollin).
4232
4233         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4234         make a slight tweak to filter-build-webkit so such lines are marked
4235         as plain.
4236
4237         * Scripts/filter-build-webkit:
4238         * Scripts/generate-xcfilelists:
4239
4240 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4241
4242         pytest is not correctly auto-installed
4243         https://bugs.webkit.org/show_bug.cgi?id=194707
4244
4245         Reviewed by Carlos Garcia Campos.
4246
4247         * Scripts/webkitpy/thirdparty/__init__.py:
4248         (AutoinstallImportHook._install_pytest):
4249
4250 2019-02-18  Chris Dumez  <cdumez@apple.com>
4251
4252         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4253         https://bugs.webkit.org/show_bug.cgi?id=194797
4254         <rdar://problem/48055151>
4255
4256         Reviewed by Geoffrey Garen.
4257
4258         Add API test coverage.
4259
4260         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4261
4262 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4263
4264         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4265         https://bugs.webkit.org/show_bug.cgi?id=194670
4266         <rdar://problem/39066529>
4267
4268         Reviewed by Tim Horton.
4269
4270         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4271         pasted in an editable area as attachment elements.
4272
4273         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4274         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4275         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4276         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4277         (TestWebKitAPI::TEST):
4278         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4279         (WTR::InjectedBundlePage::InjectedBundlePage):
4280
4281 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4282
4283         Fix API test after r241728
4284        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4285
4286         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4287         (TEST):
4288         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4289
4290 2019-02-18  Daniel Bates  <dabates@apple.com>
4291
4292         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4293         https://bugs.webkit.org/show_bug.cgi?id=192824
4294         <rdar://problem/47100332>
4295
4296         Reviewed by Wenson Hsieh.
4297
4298         Fix a bug where the wrong usage code was used for F13 thru F24.
4299
4300         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4301         (keyCodeForDOMFunctionKey):
4302
4303 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4304
4305         Bytecode cache should a have a boot-specific validation
4306         https://bugs.webkit.org/show_bug.cgi?id=194769
4307         <rdar://problem/48149509>
4308
4309         Reviewed by Keith Miller.
4310
4311         Add test for WTF::bootSessionUUIDString()
4312
4313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4314         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4315         (TEST):
4316
4317 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4318
4319         Disable safe browsing in WKWebView and remove its WKPreferences API
4320         https://bugs.webkit.org/show_bug.cgi?id=194723
4321         <rdar://problem/48122993>
4322
4323         Reviewed by Geoffrey Garen.
4324
4325         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4326         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4327         (TEST):
4328         (safeBrowsingView):
4329         Make tests use SPI instead of API.
4330
4331 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4332
4333         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4334         https://bugs.webkit.org/show_bug.cgi?id=194586
4335
4336         Reviewed by Ross Kirsling.
4337
4338         * DumpRenderTree/win/DumpRenderTree.cpp:
4339         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4340         * Scripts/webkitpy/port/driver.py:
4341         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4342
4343 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4344
4345         Unreviewed, rolling out r241620.
4346
4347         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
4348         (Requested by ddkilzer on #webkit.)
4349
4350         Reverted changeset:
4351
4352         "[WTF] Add environment variable helpers"
4353         https://bugs.webkit.org/show_bug.cgi?id=192405
4354         https://trac.webkit.org/changeset/241620
4355
4356 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4357
4358         [LFC] RenderImage's default intrinsic size is 0.
4359         https://bugs.webkit.org/show_bug.cgi?id=194745
4360
4361         Reviewed by Antti Koivisto.
4362
4363         * LayoutReloaded/misc/LFC-passing-tests.txt:
4364