Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2
3         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
4         https://bugs.webkit.org/show_bug.cgi?id=196948
5         <rdar://problem/49927131>
6
7         Reviewed by Tim Horton.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
10         (TEST): 
11         The expected order of incoming events is
12         1. didInvalidateIntrinsicContentSize
13         2. didFirstLayout
14         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
15         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
16         (and remember, all we care about is ordering).
17
18 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
19
20         Unreviewed, rolling out r244299.
21
22         Breaks internal tests.
23
24         Reverted changeset:
25
26         "InjectedBundle parameters often need initialization function
27         called before unarchiving"
28         https://bugs.webkit.org/show_bug.cgi?id=189709
29         https://trac.webkit.org/changeset/244299
30
31 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
32
33         [WTF] StringBuilder should set correct m_is8Bit flag when merging
34         https://bugs.webkit.org/show_bug.cgi?id=197053
35
36         Reviewed by Saam Barati.
37
38         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
39         (TestWebKitAPI::TEST):
40
41 2019-04-17  Tim Horton  <timothy_horton@apple.com>
42
43         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
44         https://bugs.webkit.org/show_bug.cgi?id=197028
45         <rdar://problem/49985290>
46
47         Reviewed by Wenson Hsieh.
48
49         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
50         (TEST):
51         Liberal application of waitForNextPresentationUpdate works around a race
52         where if the page rapidly changes its viewport arguments (or an API client
53         rapidly changes its viewport arguments), we'd get stuck thinking that the
54         user had intentionally zoomed the page, and stop resetting the initial scale.
55         This deserves a separate bug, but no need to keep the test failing while
56         we think about it.
57
58 2019-04-17  Tim Horton  <timothy_horton@apple.com>
59
60         REGRESSION (r241988): Switching tabs is slow
61         https://bugs.webkit.org/show_bug.cgi?id=197037
62         <rdar://problem/49951473>
63
64         Reviewed by Simon Fraser.
65
66         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
67         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
68         (TEST):
69         * TestWebKitAPI/cocoa/TestWKWebView.h:
70         * TestWebKitAPI/cocoa/TestWKWebView.mm:
71         (-[TestWKWebView addToTestWindow]):
72         Add a test that hangs without this fix.
73
74 2019-04-17  Truitt Savell  <tsavell@apple.com>
75
76         Unreviewed, rolling out r244400.
77
78         Caused testing to exit early with assertionon Debug WK2
79
80         Reverted changeset:
81
82         "UI↔Web deadlock when printing with a JavaScript alert
83         visible"
84         https://bugs.webkit.org/show_bug.cgi?id=196839
85         https://trac.webkit.org/changeset/244400
86
87 2019-04-17  Brady Eidson  <beidson@apple.com>
88
89         Link clicks in PDFs shouldn't send referrer headers.
90         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
91
92         Reviewed by Tim Horton.
93
94         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
95         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
96         (putPDFBytesCallback):
97         (emptyReleaseInfoCallback):
98         (createPDFWithLinkToURL):
99         (TEST):
100
101 2019-04-17  Tim Horton  <timothy_horton@apple.com>
102
103         UI↔Web deadlock when printing with a JavaScript alert visible
104         https://bugs.webkit.org/show_bug.cgi?id=196839
105         <rdar://problem/49157642>
106
107         Reviewed by Andy Estes.
108
109         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
110         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
111         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
112         (TEST):
113
114 2019-04-17  Alex Christensen  <achristensen@webkit.org>
115
116         WKRetainPtr's adoption constructor should be private
117         https://bugs.webkit.org/show_bug.cgi?id=197019
118
119         Reviewed by Tim Horton.
120
121         * DumpRenderTree/mac/DumpRenderTree.mm:
122         (dumpFramesAsText):
123         * TestWebKitAPI/InjectedBundleController.cpp:
124         (TestWebKitAPI::InjectedBundleController::initialize):
125         * TestWebKitAPI/PlatformUtilities.cpp:
126         (TestWebKitAPI::Util::createContextWithInjectedBundle):
127         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
128         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
129         (TestWebKitAPI::Util::toWK):
130         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
131         (TestWebKitAPI::TEST):
132         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
133         (TestWebKitAPI::TEST):
134         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
135         (TestWebKitAPI::TEST):
136         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
137         (TestWebKitAPI::TEST):
138         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
139         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
140         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
141         (TestWebKitAPI::TEST):
142         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
143         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
144         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
145         (TestWebKitAPI::TEST):
146         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
147         (TestWebKitAPI::TEST):
148         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
149         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
150         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
151         (TestWebKitAPI::TEST):
152         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
153         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
154         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
155         (TestWebKitAPI::TEST):
156         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
157         (TestWebKitAPI::TEST):
158         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
159         (TestWebKitAPI::TEST):
160         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
161         (TestWebKitAPI::TEST):
162         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
163         (TestWebKitAPI::TEST):
164         * TestWebKitAPI/Tests/WebKit/Find.cpp:
165         (TestWebKitAPI::TEST):
166         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
167         (TestWebKitAPI::TEST):
168         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
169         (TestWebKitAPI::TEST):
170         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
171         (TestWebKitAPI::TEST):
172         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
173         (TestWebKitAPI::TEST):
174         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
175         (TestWebKitAPI::TEST):
176         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
177         (TestWebKitAPI::TEST):
178         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
179         (TestWebKitAPI::TEST):
180         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
181         (TestWebKitAPI::TEST):
182         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
183         (TestWebKitAPI::TEST):
184         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
185         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
186         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
187         (TestWebKitAPI::TEST):
188         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
189         (TestWebKitAPI::TEST):
190         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
191         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
192         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
193         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
194         (TestWebKitAPI::TEST):
195         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
196         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
197         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
198         (TestWebKitAPI::TEST):
199         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
200         (TestWebKitAPI::TEST):
201         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
202         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
203         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
204         (TestWebKitAPI::TEST):
205         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
206         (TestWebKitAPI::loadAlternateHTMLString):
207         (TestWebKitAPI::TEST):
208         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
209         (TestWebKitAPI::TEST):
210         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
211         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
212         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
213         (TestWebKitAPI::buildAndPerformTest):
214         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
215         (TestWebKitAPI::TEST):
216         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
217         (TestWebKitAPI::TEST):
218         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
219         (TestWebKitAPI::TEST):
220         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
221         (TestWebKitAPI::TEST):
222         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
223         (TestWebKitAPI::TEST):
224         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
225         (TestWebKitAPI::TEST):
226         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
227         (TestWebKitAPI::TEST):
228         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
229         (TestWebKitAPI::TEST):
230         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
231         (TestWebKitAPI::TEST):
232         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
233         (TestWebKitAPI::TEST):
234         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
235         (TestWebKitAPI::TEST):
236         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
237         (TestWebKitAPI::TEST):
238         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
239         (TestWebKitAPI::TEST):
240         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
241         (TestWebKitAPI::TEST):
242         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
243         (TestWebKitAPI::TEST):
244         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
245         (TestWebKitAPI::TEST):
246         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
247         (TestWebKitAPI::TEST):
248         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
249         (TestWebKitAPI::TEST):
250         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
251         (TestWebKitAPI::TEST):
252         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
253         (TestWebKitAPI::TEST):
254         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
255         (TestWebKitAPI::TEST):
256         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
257         (TestWebKitAPI::TEST):
258         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
259         (TestWebKitAPI::TEST):
260         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
261         (TestWebKitAPI::TEST):
262         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
263         (TestWebKitAPI::TEST):
264         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
265         (TestWebKitAPI::TEST):
266         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
267         (TestWebKitAPI::TEST):
268         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
269         (TestWebKitAPI::TEST):
270         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
271         (TestWebKitAPI::TEST):
272         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
273         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
274         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
275         (TestWebKitAPI::TEST):
276         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
277         (TestWebKitAPI::TEST):
278         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
279         (TestWebKitAPI::TEST):
280         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
281         (TestWebKitAPI::TEST):
282         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
283         (TestWebKitAPI::TEST):
284         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
285         (TestWebKitAPI::TEST):
286         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
287         (TestWebKitAPI::TEST):
288         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
289         (TestWebKitAPI::TEST):
290         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
291         (TestWebKitAPI::TEST):
292         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
293         (TestWebKitAPI::TEST):
294         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
295         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
296         (TEST):
297         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
298         (TEST):
299         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
300         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
301         (TEST):
302         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
303         (TestWebKitAPI::TEST):
304         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
305         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
306         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
307         (WTR::getMenuItemTitleCallback):
308         (WTR::createMouseMessageBody):
309         (WTR::EventSendingController::mouseDown):
310         (WTR::EventSendingController::mouseUp):
311         (WTR::EventSendingController::mouseMoveTo):
312         (WTR::EventSendingController::mouseForceClick):
313         (WTR::EventSendingController::startAndCancelMouseForceClick):
314         (WTR::EventSendingController::mouseForceDown):
315         (WTR::EventSendingController::mouseForceUp):
316         (WTR::EventSendingController::mouseForceChanged):
317         (WTR::EventSendingController::leapForward):
318         (WTR::EventSendingController::scheduleAsynchronousClick):
319         (WTR::createKeyDownMessageBody):
320         (WTR::EventSendingController::keyDown):
321         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
322         (WTR::EventSendingController::mouseScrollBy):
323         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
324         (WTR::EventSendingController::continuousMouseScrollBy):
325         (WTR::EventSendingController::addTouchPoint):
326         (WTR::EventSendingController::updateTouchPoint):
327         (WTR::EventSendingController::setTouchModifier):
328         (WTR::EventSendingController::setTouchPointRadius):
329         (WTR::EventSendingController::touchStart):
330         (WTR::EventSendingController::touchMove):
331         (WTR::EventSendingController::touchEnd):
332         (WTR::EventSendingController::touchCancel):
333         (WTR::EventSendingController::clearTouchPoints):
334         (WTR::EventSendingController::releaseTouchPoint):
335         (WTR::EventSendingController::cancelTouchPoint):
336         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
337         (WTR::InjectedBundle::didCreatePage):
338         (WTR::InjectedBundle::didReceiveMessage):
339         (WTR::InjectedBundle::didReceiveMessageToPage):
340         (WTR::InjectedBundle::booleanForKey):
341         (WTR::InjectedBundle::done):
342         (WTR::InjectedBundle::dumpToStdErr):
343         (WTR::InjectedBundle::outputText):
344         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
345         (WTR::InjectedBundle::postAddChromeInputField):
346         (WTR::InjectedBundle::postRemoveChromeInputField):
347         (WTR::InjectedBundle::postFocusWebView):
348         (WTR::InjectedBundle::postSetBackingScaleFactor):
349         (WTR::InjectedBundle::postSetWindowIsKey):
350         (WTR::InjectedBundle::postSetViewSize):
351         (WTR::InjectedBundle::postSimulateWebNotificationClick):
352         (WTR::InjectedBundle::postSetAddsVisitedLinks):
353         (WTR::InjectedBundle::setGeolocationPermission):
354         (WTR::InjectedBundle::setMockGeolocationPosition):
355         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
356         (WTR::InjectedBundle::isGeolocationProviderActive const):
357         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
358         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
359         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
360         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
361         (WTR::InjectedBundle::setCustomPolicyDelegate):
362         (WTR::InjectedBundle::setHidden):
363         (WTR::InjectedBundle::setCacheModel):
364         (WTR::InjectedBundle::shouldProcessWorkQueue const):
365         (WTR::InjectedBundle::processWorkQueue):
366         (WTR::InjectedBundle::queueBackNavigation):
367         (WTR::InjectedBundle::queueForwardNavigation):
368         (WTR::InjectedBundle::queueLoad):
369         (WTR::InjectedBundle::queueLoadHTMLString):
370         (WTR::InjectedBundle::queueReload):
371         (WTR::InjectedBundle::queueLoadingScript):
372         (WTR::InjectedBundle::queueNonLoadingScript):
373         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
374         (WTR::frameToStr):
375         (WTR::InjectedBundlePage::InjectedBundlePage):
376         (WTR::dumpFrameDescriptionSuitableForTestResult):
377         (WTR::dumpFrameScrollPosition):
378         (WTR::dumpDescendantFrameScrollPositions):
379         (WTR::dumpFrameText):
380         (WTR::dumpDescendantFramesText):
381         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
382         (WTR::TestRunner::shouldDumpPixels const):
383         (WTR::TestRunner::setDumpPixels):
384         (WTR::TestRunner::whatToDump const):
385         (WTR::TestRunner::setWhatToDump):
386         (WTR::TestRunner::setWaitUntilDone):
387         (WTR::TestRunner::shouldWaitUntilDone const):
388         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
389         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
390         (WTR::TestRunner::clearAllDatabases):
391         (WTR::TestRunner::setIDBPerOriginQuota):
392         (WTR::TestRunner::originsWithApplicationCache):
393         (WTR::TestRunner::setCanOpenWindows):
394         (WTR::TestRunner::setXSSAuditorEnabled):
395         (WTR::TestRunner::setMediaDevicesEnabled):
396         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
397         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
398         (WTR::TestRunner::setCustomUserAgent):
399         (WTR::TestRunner::setWebAPIStatisticsEnabled):
400         (WTR::TestRunner::setModernMediaControlsEnabled):
401         (WTR::TestRunner::setWebGL2Enabled):
402         (WTR::TestRunner::setWritableStreamAPIEnabled):
403         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
404         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
405         (WTR::TestRunner::setAllowsAnySSLCertificate):
406         (WTR::TestRunner::setPluginsEnabled):
407         (WTR::TestRunner::setValueForUser):
408         (WTR::TestRunner::setAudioResult):
409         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
410         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
411         (WTR::TestRunner::setAlwaysAcceptCookies):
412         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
413         (WTR::TestRunner::isDoingMediaCapture const):
414         (WTR::TestRunner::queueLoad):
415         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
416         (WTR::TestRunner::setHandlesAuthenticationChallenges):
417         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
418         (WTR::TestRunner::setShouldLogDownloadCallbacks):
419         (WTR::TestRunner::setAuthenticationUsername):
420         (WTR::TestRunner::setAuthenticationPassword):
421         (WTR::TestRunner::secureEventInputIsEnabled const):
422         (WTR::TestRunner::setBlockAllPlugins):
423         (WTR::TestRunner::setPluginSupportedMode):
424         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
425         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
426         (WTR::TestRunner::setNavigationGesturesEnabled):
427         (WTR::TestRunner::setIgnoresViewportScaleLimits):
428         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
429         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
430         (WTR::TestRunner::terminateNetworkProcess):
431         (WTR::TestRunner::terminateServiceWorkerProcess):
432         (WTR::TestRunner::runUIScript):
433         (WTR::TestRunner::setStatisticsDebugMode):
434         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
435         (WTR::TestRunner::setStatisticsLastSeen):
436         (WTR::TestRunner::setStatisticsPrevalentResource):
437         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
438         (WTR::TestRunner::dumpResourceLoadStatistics):
439         (WTR::TestRunner::isStatisticsPrevalentResource):
440         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
441         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
442         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
443         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
444         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
445         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
446         (WTR::TestRunner::setStatisticsGrandfathered):
447         (WTR::TestRunner::isStatisticsGrandfathered):
448         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
449         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
450         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
451         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
452         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
453         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
454         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
455         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
456         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
457         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
458         (WTR::TestRunner::statisticsUpdateCookieBlocking):
459         (WTR::TestRunner::statisticsSubmitTelemetry):
460         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
461         (WTR::TestRunner::setStatisticsIsRunningTest):
462         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
463         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
464         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
465         (WTR::TestRunner::setStatisticsGrandfatheringTime):
466         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
467         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
468         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
469         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
470         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
471         (WTR::TestRunner::statisticsDeleteCookiesForHost):
472         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
473         (WTR::TestRunner::statisticsResetToConsistentState):
474         (WTR::TestRunner::setStorageAccessAPIEnabled):
475         (WTR::TestRunner::getAllStorageAccessEntries):
476         (WTR::TestRunner::addMockMediaDevice):
477         (WTR::TestRunner::clearMockMediaDevices):
478         (WTR::TestRunner::removeMockMediaDevice):
479         (WTR::TestRunner::resetMockMediaDevices):
480         (WTR::TestRunner::connectMockGamepad):
481         (WTR::TestRunner::disconnectMockGamepad):
482         (WTR::TestRunner::setMockGamepadDetails):
483         (WTR::TestRunner::setMockGamepadAxisValue):
484         (WTR::TestRunner::setMockGamepadButtonValue):
485         (WTR::TestRunner::removeAllSessionCredentials):
486         (WTR::TestRunner::clearDOMCache):
487         (WTR::TestRunner::clearDOMCaches):
488         (WTR::TestRunner::hasDOMCache):
489         (WTR::TestRunner::domCacheSize):
490         (WTR::TestRunner::setAllowStorageQuotaIncrease):
491         (WTR::TestRunner::getApplicationManifestThen):
492         (WTR::TestRunner::injectUserScript):
493         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
494         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
495         (WTR::TestRunner::addTestKeyToKeychain):
496         (WTR::TestRunner::cleanUpKeychain):
497         (WTR::TestRunner::keyExistsInKeychain):
498         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
499         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
500         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
501         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
502         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
503         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
504         * WebKitTestRunner/TestController.cpp:
505         (WTR::TestController::initialize):
506         (WTR::parseStringTestHeaderValueAsRelativePath):
507         (WTR::updateTestOptionsFromTestHeader):
508         (WTR::TestController::runTest):
509         (WTR::TestController::didReceiveLiveDocumentsList):
510         (WTR::TestController::didReceiveMessageFromInjectedBundle):
511         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
512         (WTR::TestController::didFinishNavigation):
513         (WTR::TestController::didReceiveAuthenticationChallenge):
514         * WebKitTestRunner/TestInvocation.cpp:
515         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
516         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
517         (WTR::TestInvocation::uiScriptDidComplete):
518         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
519         * WebKitTestRunner/WebNotificationProvider.cpp:
520         (WTR::WebNotificationProvider::closeWebNotification):
521         * WebKitTestRunner/WorkQueueManager.cpp:
522         (WTR::ScriptItem::ScriptItem):
523         (WTR::WorkQueueManager::queueLoad):
524         (WTR::WorkQueueManager::queueLoadHTMLString):
525
526 2019-04-17  Alex Christensen  <achristensen@webkit.org>
527
528         Add a comment to make my test from r244139 less mysterious.
529         https://bugs.webkit.org/show_bug.cgi?id=196744
530
531         As suggested by Darin Adler.
532
533         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
534         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
535
536 2019-04-17  Chris Dumez  <cdumez@apple.com>
537
538         Remember device orientation permission for the duration of the browsing session
539         https://bugs.webkit.org/show_bug.cgi?id=196992
540         <rdar://problem/49946067>
541
542         Reviewed by Alex Christensen.
543
544         Add API test coverage.
545
546         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
547         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
548         (TEST):
549
550 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
551
552         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
553         https://bugs.webkit.org/show_bug.cgi?id=196675
554
555         Reviewed by Lucas Forschler.
556
557         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
558         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
559
560 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
561
562         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
563         https://bugs.webkit.org/show_bug.cgi?id=196919
564         <rdar://problem/41630459>
565
566         Reviewed by Tim Horton.
567
568         Add iOS support for several new testing hooks. See below for more detail.
569
570         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
571         (WTR::UIScriptController::isDismissingMenu const):
572
573         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
574         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
575         by UIKit when dismissing the callout bar (i.e. UIMenuController).
576
577         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
578         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
579         (WTR::UIScriptController::isDismissingMenu const):
580         * TestRunnerShared/UIScriptContext/UIScriptController.h:
581         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
582         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
583         (WTR::InjectedBundle::didReceiveMessageToPage):
584         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
585         (WTR::TestRunner::setAllowedMenuActions):
586
587         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
588         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
589         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
590         against the name of the custom action.
591
592         (WTR::TestRunner::installCustomMenuAction):
593
594         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
595         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
596         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
597         triggered.
598
599         (WTR::TestRunner::performCustomMenuAction):
600
601         Invoked when the custom menu action is triggered.
602
603         * WebKitTestRunner/InjectedBundle/TestRunner.h:
604         * WebKitTestRunner/TestController.cpp:
605         (WTR::TestController::installCustomMenuAction):
606         (WTR::TestController::setAllowedMenuActions):
607         * WebKitTestRunner/TestController.h:
608         * WebKitTestRunner/TestInvocation.cpp:
609         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
610         (WTR::TestInvocation::performCustomMenuAction):
611
612         Add plumbing to call back into the injected bundle when performing the custom action.
613
614         * WebKitTestRunner/TestInvocation.h:
615         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
616         (WTR::TestController::installCustomMenuAction):
617         (WTR::TestController::setAllowedMenuActions):
618         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
619         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
620         (-[TestRunnerWKWebView initWithFrame:configuration:]):
621         (-[TestRunnerWKWebView becomeFirstResponder]):
622         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
623
624         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
625         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
626         in the Mail app on iOS.
627
628         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
629         (-[TestRunnerWKWebView setAllowedMenuActions:]):
630         (-[TestRunnerWKWebView resetCustomMenuAction]):
631         (-[TestRunnerWKWebView performCustomAction:]):
632         (-[TestRunnerWKWebView canPerformAction:withSender:]):
633         (-[TestRunnerWKWebView _willHideMenu]):
634         (-[TestRunnerWKWebView _didHideMenu]):
635         * WebKitTestRunner/ios/TestControllerIOS.mm:
636         (WTR::TestController::platformResetStateToConsistentValues):
637
638         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
639         if specified.
640
641         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
642         (WTR::UIScriptController::isDismissingMenu const):
643
644 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
645
646         Allow sharing from imageSheet on an image document
647         https://bugs.webkit.org/show_bug.cgi?id=196891
648         <rdar://problem/25377386>
649
650         Reviewed by Tim Horton.
651
652         Test to make sure that the correct imageURL is extracted from an image element.
653
654         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
655         (TestWebKitAPI::TEST):
656
657 2019-04-16  Alex Christensen  <achristensen@webkit.org>
658
659         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
660         https://bugs.webkit.org/show_bug.cgi?id=196995
661
662         Reviewed by Brady Eidson.
663
664         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
665         (TEST):
666
667 2019-04-16  Chris Dumez  <cdumez@apple.com>
668
669         URL set by document.open() is not communicated to the UIProcess
670         https://bugs.webkit.org/show_bug.cgi?id=196941
671         <rdar://problem/49237544>
672
673         Reviewed by Geoff Garen.
674
675         Add API test coverage.
676
677         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
678         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
679         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
680         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
681         (TEST):
682
683 2019-04-16  Commit Queue  <commit-queue@webkit.org>
684
685         Unreviewed, rolling out r244321.
686         https://bugs.webkit.org/show_bug.cgi?id=196968
687
688         Causing all WK2 Debug builds to exit early after Assertion
689         failures. (Requested by ShawnRoberts on #webkit).
690
691         Reverted changeset:
692
693         "URL set by document.open() is not communicated to the
694         UIProcess"
695         https://bugs.webkit.org/show_bug.cgi?id=196941
696         https://trac.webkit.org/changeset/244321
697
698 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
699
700         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
701         https://bugs.webkit.org/show_bug.cgi?id=196948
702
703         Reviewed by Zalan Bujtas.
704
705         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
706         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
707
708 2019-04-15  Chris Dumez  <cdumez@apple.com>
709
710         URL set by document.open() is not communicated to the UIProcess
711         https://bugs.webkit.org/show_bug.cgi?id=196941
712         <rdar://problem/49237544>
713
714         Reviewed by Geoffrey Garen.
715
716         Add API test coverage.
717
718         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
719         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
720         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
721         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
722         (TEST):
723
724 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
725
726         Using Tools/Scripts/clean-webkit should not install requests
727         https://bugs.webkit.org/show_bug.cgi?id=196940
728
729         Reviewed by Lucas Forschler.
730
731         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
732         existing, depending on the path autoinstalled is run through.
733         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
734         needed.
735         (Port.configuration_for_upload):
736         (Port.commits_for_upload):
737
738 2019-04-15  Alex Christensen  <achristensen@webkit.org>
739
740         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
741         https://bugs.webkit.org/show_bug.cgi?id=196773
742
743         Reviewed by Jer Noble.
744
745         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
746         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
747         (TEST):
748
749 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
750
751         ews-build should clearly indicate flaky test failures
752         https://bugs.webkit.org/show_bug.cgi?id=196947
753
754         Reviewed by Lucas Forschler.
755
756         * BuildSlaveSupport/ews-build/steps.py:
757         (AnalyzeAPITestsResults.analyzeResults):
758
759 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
760
761         InjectedBundle parameters often need initialization function called before unarchiving
762         https://bugs.webkit.org/show_bug.cgi?id=189709
763         <rdar://problem/44573653>
764
765         Reviewed by Ryosuke Niwa.
766
767         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
768         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
769
770 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
771
772         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
773         https://bugs.webkit.org/show_bug.cgi?id=196681
774
775         Reviewed by Darin Adler.
776
777         Added tests.
778
779         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
780         (WTF_HashSet.RemoveIf):
781         (WTF_HashSet.RemoveIfShrinkToBestSize):
782
783 2019-04-15  John Wilander  <wilander@apple.com>
784
785         Send delayed Ad Click Attribution conversion requests to the click source
786         https://bugs.webkit.org/show_bug.cgi?id=196838
787         <rdar://problem/47650157>
788
789         Reviewed by Chris Dumez and Youenn Fablet.
790
791         This patch adds test infrastructure to override the default behavior in
792         WebKit::NetworkAdClickAttribution.
793
794         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
795         (TestWebKitAPI::TEST):
796         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
797         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
798         (WTR::TestRunner::dumpAdClickAttribution):
799         (WTR::TestRunner::clearAdClickAttribution):
800         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
801         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
802         * WebKitTestRunner/InjectedBundle/TestRunner.h:
803         * WebKitTestRunner/TestController.cpp:
804         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
805         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
806         * WebKitTestRunner/TestController.h:
807         * WebKitTestRunner/TestInvocation.cpp:
808         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
809
810 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
811
812         [ews-app] status-bubble should display position in queue
813         https://bugs.webkit.org/show_bug.cgi?id=196607
814
815         Reviewed by Lucas Forschler.
816
817         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
818         (StatusBubble._build_bubble):
819         (StatusBubble._queue_position): Method to calculate patch's position in queue.
820
821 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
822
823         [ews-build] Do not run clean build by default on EWS builders
824         https://bugs.webkit.org/show_bug.cgi?id=196897
825
826         Reviewed by Lucas Forschler.
827
828         * BuildSlaveSupport/ews-build/steps.py:
829         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
830         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
831         untracked directories like WebKitBuild).
832         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
833         untracked files/directories (like WebKitBuild).
834
835 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
836
837         TestRunner::notifyDone() should be safely reentrant
838         https://bugs.webkit.org/show_bug.cgi?id=196898
839
840         Reviewed by Darin Adler.
841
842         It is currently possible that TestRunner::notifyDone() will call itself, since
843         notifyDone() will force a repaint, which can start executing JavaScript, which
844         may call notifyDone() again. This can lead to test failures and flakiness.
845         Fix this by setting the m_waitToDump flag before calling the dump() method.
846
847         * DumpRenderTree/mac/TestRunnerMac.mm:
848         (TestRunner::notifyDone):
849         (TestRunner::forceImmediateCompletion):
850         * DumpRenderTree/win/TestRunnerWin.cpp:
851         (TestRunner::notifyDone):
852         (TestRunner::forceImmediateCompletion):
853
854 2019-04-15  Philippe Normand  <pnormand@igalia.com>
855
856         [GTK][WPE] Add enable-media websetting
857         https://bugs.webkit.org/show_bug.cgi?id=196863
858
859         Reviewed by Michael Catanzaro.
860
861         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
862         (testWebKitSettings): Add test for the enable-media web-setting.
863
864 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
865
866         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
867         https://bugs.webkit.org/show_bug.cgi?id=196905
868         <rdar://problem/49886096>
869
870         Reviewed by Tim Horton.
871
872         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
873         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
874         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
875         delay timer, we end up with this sequence of events in the problematic (failure) case:
876
877         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
878             ...IPC from UI to web process...
879         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
880             ...IPC from web to UI process...
881         (c) [UI]    Invoke completion handler for script #1
882         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
883             ...IPC from UI to web process...
884         (e) [Web]   Evaluate script #2 in the web process
885         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
886
887         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
888         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
889         #2 is run in step (e).
890
891         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
892         the UI process by waiting on a script message posted by the web process, after attachment updates are
893         dispatched.
894
895         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
896         (TestWebKitAPI::TEST):
897
898 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
899
900         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
901         https://bugs.webkit.org/show_bug.cgi?id=196909
902
903         Reviewed by Wenson Hsieh.
904
905         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
906         (TestWebKitAPI::TEST):
907
908 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
909
910         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
911         https://bugs.webkit.org/show_bug.cgi?id=196880
912
913         Reviewed by Yusuke Suzuki.
914
915         Add a new function for bytecode cache tests that does not forceDiskCache
916         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
917         test added in this patch, since the code is invalid and therefore won't be
918         cached. It should also be useful for tests that evaluate dynamically
919         generated code.
920
921         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
922         * Scripts/run-jsc-stress-tests:
923
924 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
925
926         Update AudioSession route sharing policy
927         https://bugs.webkit.org/show_bug.cgi?id=196776
928         <rdar://problem/46501611>
929
930         Reviewed by Jer Noble.
931
932         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
933         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
934         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
935         (TestWebKitAPI::TEST):
936
937 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
938
939         [iOS] Software keyboard is shown too frequently on some websites
940         https://bugs.webkit.org/show_bug.cgi?id=195856
941         <rdar://problem/49191395>
942
943         Reviewed by Darin Adler.
944
945         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
946
947         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
948         (WTR::UIScriptController::setHardwareKeyboardAttached):
949         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
950         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
951         (WTR::UIScriptController::setHardwareKeyboardAttached):
952         * TestRunnerShared/UIScriptContext/UIScriptController.h:
953         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
954
955         Additionally link against GraphicsServices in WebKitTestRunner.
956
957         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
958         (WTR::TestController::platformResetStateToConsistentValues):
959         (WTR::UIScriptController::setHardwareKeyboardAttached):
960
961 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
962
963         [GTK][WPE] Fix pacman install-dependencies packages
964         https://bugs.webkit.org/show_bug.cgi?id=196817
965
966         Reviewed by Žan Doberšek.
967         
968         python3-setuptools is called python-setuptools
969         ruby-highline is only available on AUR
970         libv4l-devel is incorporated in v4l-utils
971
972         * gtk/install-dependencies:
973         * wpe/install-dependencies:
974
975 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
976
977         [GTK] REGRESSION(r243860): Many tests failing
978         https://bugs.webkit.org/show_bug.cgi?id=196791
979
980         Reviewed by Joanmarie Diggs.
981
982         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
983         multiple documents and check that accessibility hierarchy is updated after a navigation.
984
985         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
986         (loadChangedCallback):
987         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
988         (AccessibilityTest::AccessibilityTest):
989         (AccessibilityTest::~AccessibilityTest):
990         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
991         (AccessibilityTest::findTestServerApplication):
992         (AccessibilityTest::findDocumentWeb):
993         (AccessibilityTest::findRootObject):
994         (AccessibilityTest::waitUntilChildrenRemoved):
995         (AccessibilityTest::ensureProxy):
996         (testAtspiBasicHierarchy):
997         (beforeAll):
998         (afterAll):
999
1000 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1001
1002         [ews-build] Handle bug titles with unicode characters
1003         https://bugs.webkit.org/show_bug.cgi?id=196802
1004
1005         Reviewed by Dewei Zhu.
1006
1007         * BuildSlaveSupport/ews-build/steps.py:
1008         (ValidatePatch._is_bug_closed):
1009
1010 2019-04-11  Michael Saboff  <msaboff@apple.com>
1011
1012         Improve the Inline Cache Stats code
1013         https://bugs.webkit.org/show_bug.cgi?id=196836
1014
1015         Reviewed by Saam Barati.
1016
1017         Added a new script to consolidate and arrange the output of --useICStats option.
1018
1019         This script merges the output from every group into one large table and sorts it from most common to
1020         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1021         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1022         Put together, this is useful to see what property accesses are not getting cached.
1023
1024         * Scripts/ic-stats.py: Added.
1025         (ICStats):
1026         (ICStats.__init__):
1027         (ICStats.parse):
1028         (ICStats.dumpStats):
1029         (usage):
1030
1031 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1032
1033         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1034         https://bugs.webkit.org/show_bug.cgi?id=196809
1035         <rdar://49800762>
1036
1037         Reviewed by Brady Eidson.
1038
1039         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1040         (TEST):
1041
1042 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1043
1044         requestAnimationFrame should execute before the next frame
1045         https://bugs.webkit.org/show_bug.cgi?id=177484
1046
1047         Reviewed by Simon Fraser.
1048
1049         Add trace points for the page RenderingUpdate.
1050
1051         * Tracing/SystemTracePoints.plist:
1052
1053 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1054
1055         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1056         https://bugs.webkit.org/show_bug.cgi?id=196760
1057
1058         Reviewed by Don Olmstead.
1059
1060         vswhere.exe has been bundled since Visual Studio 2017 version
1061         15.2. We shouldn't download vswhere.exe.
1062
1063         * Scripts/build-jsc: Do not call update-vswhere.py.
1064         * Scripts/build-webkit: Ditto.
1065         * Scripts/update-vswhere.py: Removed.
1066         * Scripts/webkitdirs.pm:
1067         (requireModulesForVSWhere): Deleted.
1068         (pickCurrentVisualStudioInstallation): Deleted.
1069         (visualStudioInstallDirVSWhere): Return the latest installed VS
1070         installation path by using the bundled vswhere.exe.
1071         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1072         (visualStudioInstallDirFallback): Removed.
1073
1074 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1075
1076         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1077         https://bugs.webkit.org/show_bug.cgi?id=196780
1078
1079         Reviewed by Alexey Proskuryakov.
1080
1081         * BuildSlaveSupport/ews-build/steps.py:
1082         * BuildSlaveSupport/ews-build/steps_unittest.py:
1083
1084 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1085
1086         Add SPI WKNavigationResponse._downloadAttribute
1087         https://bugs.webkit.org/show_bug.cgi?id=196755
1088         <rdar://49587365>
1089
1090         Reviewed by Brady Eidson.
1091
1092         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1093         (-[NavigationResponseTestDelegate navigationResponse]):
1094         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1095         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1096         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1097         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1098         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1099         (readRequest):
1100         (writeResponse):
1101         (TEST):
1102
1103 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1104
1105         Add modern API for overriding the page's specified viewport configuration
1106         https://bugs.webkit.org/show_bug.cgi?id=167734
1107         <rdar://problem/30331795>
1108
1109         Reviewed by Simon Fraser.
1110
1111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1112         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1113
1114 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1115
1116         Add support for incremental bytecode cache updates
1117         https://bugs.webkit.org/show_bug.cgi?id=195000
1118
1119         Reviewed by Filip Pizlo.
1120
1121         Exit when the initial run to generate bytecode fails.
1122
1123         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1124
1125 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1126
1127         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1128         https://bugs.webkit.org/show_bug.cgi?id=196744
1129         <rdar://49415309>
1130
1131         Reviewed by Chris Dumez.
1132
1133         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1134         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1135
1136 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1137
1138         Add a way to opt into modern compatibility mode in layout tests
1139         https://bugs.webkit.org/show_bug.cgi?id=196770
1140         <rdar://problem/49777550>
1141
1142         Reviewed by Antoine Quint.
1143
1144         Add a new test option to enable modern compatibility mode in layout tests.
1145
1146         * WebKitTestRunner/TestController.cpp:
1147         (WTR::updateTestOptionsFromTestHeader):
1148         * WebKitTestRunner/TestController.h:
1149         * WebKitTestRunner/TestOptions.h:
1150         (WTR::TestOptions::hasSameInitializationOptions const):
1151         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1152         (WTR::TestController::platformCreateWebView):
1153         (WTR::TestController::enableModernCompatibilityMode):
1154
1155 2019-04-10  Andy Estes  <aestes@apple.com>
1156
1157         Try to fix the 32-bit watchOS build.
1158
1159         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1160         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1161
1162 2019-04-10  Antoine Quint  <graouts@apple.com>
1163
1164         Enable Pointer Events on watchOS
1165         https://bugs.webkit.org/show_bug.cgi?id=196771
1166         <rdar://problem/49040909>
1167
1168         Reviewed by Dean Jackson.
1169
1170         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1171
1172 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1173
1174         Unreviewed. Fix WPE accessibility tests after r244059.
1175
1176         We are failing to load the injected bundle due to undefined symbol
1177         AccessibilityUIElement::replaceTextInRange().
1178
1179         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1180         (WTR::AccessibilityUIElement::replaceTextInRange):
1181
1182 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1183
1184         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1185         https://bugs.webkit.org/show_bug.cgi?id=196727
1186
1187         Reviewed by Fujii Hironori.
1188
1189         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1190         (WebKitBrowserWindow::create):
1191
1192 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1193
1194         [ews-build] Add unit tests for PrintConfiguration
1195         https://bugs.webkit.org/show_bug.cgi?id=196752
1196
1197         Reviewed by Dewei Zhu.
1198
1199         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1200
1201 2019-04-09  Keith Rollin  <krollin@apple.com>
1202
1203         Unreviewed build maintenance -- update .xcfilelists.
1204
1205         * DumpRenderTree/DerivedSources-input.xcfilelist:
1206         * DumpRenderTree/DerivedSources-output.xcfilelist:
1207
1208 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1209
1210         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1211         https://bugs.webkit.org/show_bug.cgi?id=196743
1212         <rdar://problem/43897551>
1213
1214         Reviewed by Tim Horton.
1215
1216         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1217         (TEST):
1218
1219 2019-04-09  Youenn Fablet  <youenn@apple.com>
1220
1221         Close service worker database on network process suspension
1222         https://bugs.webkit.org/show_bug.cgi?id=196623
1223         <rdar://problem/48930869>
1224
1225         Reviewed by Alex Christensen.
1226
1227         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1228
1229 2019-04-09  Daniel Bates  <dabates@apple.com>
1230
1231         [iPad] Should open popover when the spacebar is pressed
1232         https://bugs.webkit.org/show_bug.cgi?id=196360
1233         <rdar://problem/49389129>
1234
1235         Reviewed by Brent Fulgham.
1236
1237         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1238
1239         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1240         (WTR::UIScriptController::isShowingPopover const): Added.
1241         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1242         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1243         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1244         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1245         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1246         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1247         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1248         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1249         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1250         (WTR::UIScriptController::isShowingPopover const): Added.
1251         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1252         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1253         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1254         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1255         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1256         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1257         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1258         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1259         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1260         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1261         (WTR::UIScriptController::isShowingPopover const): Added.
1262         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1263         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1264
1265 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1266
1267         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1268         https://bugs.webkit.org/show_bug.cgi?id=196665
1269         <rdar://45115669>
1270
1271         Reviewed by Geoff Garen.
1272
1273         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1274         (goBack):
1275         (+[SimpleLookupContext sharedLookupContext]):
1276         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1277         (TEST):
1278         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1279         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1280
1281 2019-04-09  John Wilander  <wilander@apple.com>
1282
1283         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1284         https://bugs.webkit.org/show_bug.cgi?id=196558
1285         <rdar://problem/47650245>
1286
1287         Reviewed by Youenn Fablet.
1288
1289         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1290         (TestWebKitAPI::TEST):
1291             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1292
1293 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1294
1295         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1296         https://bugs.webkit.org/show_bug.cgi?id=196720
1297
1298         Reviewed by Konstantin Tokarev.
1299
1300         * TestWebKitAPI/PlatformMac.cmake:
1301
1302 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1303
1304         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1305         https://bugs.webkit.org/show_bug.cgi?id=196694
1306         <rdar://problem/48388734>
1307
1308         Rubber-stamped by Aakash Jain.
1309
1310         * Scripts/webkitpy/port/image_diff.py:
1311         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1312         * Scripts/webkitpy/port/server_process.py:
1313         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1314         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1315         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1316         * Scripts/webkitpy/port/server_process_mock.py:
1317         (MockServerProcess.has_available_stdout):
1318         * Scripts/webkitpy/port/server_process_unittest.py:
1319         (TestServerProcess.serial_test_basic):
1320
1321 2019-04-09  Jer Noble  <jer.noble@apple.com>
1322
1323         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1324         https://bugs.webkit.org/show_bug.cgi?id=196097
1325
1326         Reviewed by Eric Carlson.
1327
1328         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1329
1330         * DumpRenderTree/mac/DumpRenderTree.mm:
1331         (resetWebPreferencesToConsistentValues):
1332         * WebKitTestRunner/TestController.cpp:
1333         (WTR::TestController::resetPreferencesToConsistentValues):
1334
1335 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1336
1337         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1338         https://bugs.webkit.org/show_bug.cgi?id=196690
1339
1340         Reviewed by Michael Catanzaro.
1341
1342         * QueueStatusServer/config/queues.py:
1343         * Scripts/webkitpy/common/config/ews.json:
1344         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1345         (test_ews_name):
1346
1347 2019-04-09  Chris Dumez  <cdumez@apple.com>
1348
1349         Loads using loadHTMLString() cause flashing when process-swapping
1350         https://bugs.webkit.org/show_bug.cgi?id=196714
1351         <rdar://problem/49637354>
1352
1353         Reviewed by Antti Koivisto.
1354
1355         Add API test coverage.
1356
1357         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1358
1359 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1360
1361         Unreviewed. Fix ATK accessibility tests after r244059.
1362
1363         We are failing to load the injected bundle due to undefined symbol
1364         AccessibilityUIElement::replaceTextInRange().
1365
1366         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1367         (WTR::AccessibilityUIElement::replaceTextInRange):
1368
1369 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1370
1371         AX: Support API: accessibilityReplaceRange:withText
1372         https://bugs.webkit.org/show_bug.cgi?id=196636
1373
1374         Unreviewed build fix for Windows port.
1375
1376         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1377         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1378
1379 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1380
1381         [CMake][WinCairo] Separate copied headers into different directories
1382         https://bugs.webkit.org/show_bug.cgi?id=196655
1383
1384         Reviewed by Michael Catanzaro.
1385
1386         * DumpRenderTree/CMakeLists.txt:
1387         * MiniBrowser/win/CMakeLists.txt:
1388         * TestWebKitAPI/CMakeLists.txt:
1389         * TestWebKitAPI/PlatformWin.cmake:
1390
1391 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1392
1393         Log stack-trace for run-webkit-tests when interrupted
1394         https://bugs.webkit.org/show_bug.cgi?id=176393
1395         <rdar://problem/34262310>
1396
1397         Reviewed by Lucas Forschler.
1398
1399         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1400         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1401         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1402         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1403         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1404         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1405         (main): Set handlers to log stack trace on interruption.
1406
1407 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1408
1409         AX: Support API: accessibilityReplaceRange:withText
1410         https://bugs.webkit.org/show_bug.cgi?id=196636
1411
1412         Unreviewed build fix for Windows port.
1413
1414         * DumpRenderTree/AccessibilityUIElement.cpp:
1415         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1416
1417 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1418
1419         [ews-build] Scripts using Buildbot API have CORS error
1420         https://bugs.webkit.org/show_bug.cgi?id=196709
1421
1422         Reviewed by Alexey Proskuryakov.
1423
1424         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1425
1426 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1427
1428         AX: Support API: accessibilityReplaceRange:withText
1429         https://bugs.webkit.org/show_bug.cgi?id=196636
1430
1431         Reviewed by Daniel Bates.
1432
1433         * DumpRenderTree/AccessibilityUIElement.cpp:
1434         (replaceTextInRangeCallback):
1435         (AccessibilityUIElement::replaceTextInRange):
1436         (AccessibilityUIElement::getJSClass):
1437         * DumpRenderTree/AccessibilityUIElement.h:
1438         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1439         (AccessibilityUIElement::replaceTextInRange):
1440         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1441         (AccessibilityUIElement::replaceTextInRange):
1442         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1443         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1444         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1445         (WTR::AccessibilityUIElement::replaceTextInRange):
1446         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1447         (WTR::AccessibilityUIElement::replaceTextInRange):
1448
1449 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1450
1451         [iOS] Do not allow starting selection drags when selection views are not visible
1452         https://bugs.webkit.org/show_bug.cgi?id=196686
1453         <rdar://problem/49399192>
1454
1455         Reviewed by Tim Horton.
1456
1457         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1458         also add some new API tests to cover scenarios where the web view is not first responder.
1459
1460         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1461         (TestWebKitAPI::TEST):
1462         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1463
1464         Add a switch to optionally make the web view first responder when starting the simulated drag.
1465
1466         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1467         (-[DragAndDropSimulator initWithWebView:]):
1468         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1469
1470 2019-04-08  Justin Fan  <justin_fan@apple.com>
1471
1472         [Web GPU] Fix Web GPU experimental feature on iOS
1473         https://bugs.webkit.org/show_bug.cgi?id=196632
1474
1475         Reviewed by Myles C. Maxfield.
1476
1477         Properly make Web GPU available on iOS 11+.
1478
1479         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1480
1481 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1482
1483         [ews-build] Do not upload archive when Compile Fails
1484         https://bugs.webkit.org/show_bug.cgi?id=196674
1485
1486         Reviewed by Alexey Proskuryakov.
1487
1488         * BuildSlaveSupport/ews-build/factories.py:
1489         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1490         * BuildSlaveSupport/ews-build/steps.py:
1491         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1492         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1493         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1494
1495 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1496
1497         Enable DFG on MIPS
1498         https://bugs.webkit.org/show_bug.cgi?id=196689
1499
1500         Reviewed by Žan Doberšek.
1501
1502         Since the bytecode change, we enabled the baseline JIT on mips in
1503         r240432, but DFG is still missing. With this change, all tests are
1504         passing on a ci20 board.
1505
1506         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1507
1508 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1509
1510         [Flatpak] Second run update-webkitwpe-flatpak fails
1511         https://bugs.webkit.org/show_bug.cgi?id=192702
1512
1513         Reviewed by Carlos Garcia Campos.
1514
1515         * flatpak/flatpakutils.py:
1516         (FlatpakObject.flatpak): Fix typo.
1517         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1518         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1519
1520 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1521
1522         [GTK][WPE] outlook.live.com displays old-fashioned UI
1523         https://bugs.webkit.org/show_bug.cgi?id=196642
1524
1525         Reviewed by Carlos Garcia Campos.
1526
1527         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1528         (TestWebKitAPI::TEST): New Mac platform quirk test.
1529
1530 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1531
1532         Unreviewed, rolling out r243956.
1533         https://bugs.webkit.org/show_bug.cgi?id=196688
1534
1535         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1536         by aakashjain on #webkit).
1537
1538         Reverted changeset:
1539
1540         "Clicking "Go Back" from a safe browsing warning from an
1541         iframe should navigate the WKWebView back to the previous
1542         page"
1543         https://bugs.webkit.org/show_bug.cgi?id=196665
1544         https://trac.webkit.org/changeset/243956
1545
1546 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1547
1548         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1549         https://bugs.webkit.org/show_bug.cgi?id=196669
1550
1551         Reviewed by Geoffrey Garen.
1552
1553         Added three new unit tests for WeakHashSet.
1554
1555         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1556         (WTF_WeakPtr.WeakHashSetConstObjects):
1557         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1558         (WTF_WeakPtr.WeakHashSetComputeSize):
1559
1560 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1561
1562         Hide next and previous form control buttons when WKWebView is editable
1563         https://bugs.webkit.org/show_bug.cgi?id=196672
1564         <rdar://problem/35625321>
1565
1566         Reviewed by Tim Horton.
1567
1568         Add a new API test.
1569
1570         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1571         (-[TestWKWebView lastTrailingBarButtonGroup]):
1572         (TestWebKitAPI::TEST):
1573         * TestWebKitAPI/ios/UIKitSPI.h:
1574
1575 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1576
1577         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1578         https://bugs.webkit.org/show_bug.cgi?id=196077
1579         <rdar://problem/49108202>
1580
1581         Reviewed by Chris Dumez.
1582
1583         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1584         on new web view.
1585
1586         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1587
1588 2019-04-05  Saam Barati  <sbarati@apple.com>
1589
1590         Make compare-results understand MotionMark
1591         https://bugs.webkit.org/show_bug.cgi?id=196666
1592
1593         Reviewed by Yusuke Suzuki.
1594
1595         * Scripts/compare-results:
1596         (PLT5Results):
1597         (detectMotionMark):
1598         (detectMotionMark1_1):
1599         (motionMarkResults):
1600         (motionMark1_1Results):
1601         (detectBenchmark):
1602         (biggerIsBetter):
1603         (main):
1604
1605 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1606
1607         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1608         https://bugs.webkit.org/show_bug.cgi?id=196665
1609         <rdar://45115669>
1610
1611         Reviewed by Geoff Garen.
1612
1613         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1614         (goBack):
1615         (+[SimpleLookupContext sharedLookupContext]):
1616         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1617         (TEST):
1618         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1619         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1620
1621 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1622
1623         [ews-build] Add configuration and architecture for windows builders
1624         https://bugs.webkit.org/show_bug.cgi?id=196660
1625
1626         Reviewed by Lucas Forschler.
1627
1628         * BuildSlaveSupport/ews-build/config.json:
1629
1630 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1631
1632         webkitpy: Don't run subsequent rounds if interrupted
1633         https://bugs.webkit.org/show_bug.cgi?id=196646
1634
1635         Reviewed by Aakash Jain.
1636
1637         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1638         (Manager.run): Bail out if interrupted.
1639
1640 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1641
1642         Test sessionStorage in PSON private browsing mode
1643         https://bugs.webkit.org/show_bug.cgi?id=196561
1644
1645         Reviewed by Alex Christensen.
1646
1647         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1648
1649 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1650
1651         Unreviewed, rolling out r243833.
1652         https://bugs.webkit.org/show_bug.cgi?id=196645
1653
1654         This change breaks build of WPE and GTK ports (Requested by
1655         annulen on #webkit).
1656
1657         Reverted changeset:
1658
1659         "[CMake][WTF] Mirror XCode header directories"
1660         https://bugs.webkit.org/show_bug.cgi?id=191662
1661         https://trac.webkit.org/changeset/243833
1662
1663 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1664
1665         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1666         https://bugs.webkit.org/show_bug.cgi?id=196635
1667
1668         Reviewed by Antti Koivisto.
1669         
1670         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1671         for a test to enable async frame scrolling via:
1672             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1673         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1674         
1675         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1676
1677         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1678         (WTR::InjectedBundle::beginTesting):
1679         * WebKitTestRunner/TestController.cpp:
1680         (WTR::TestController::resetPreferencesToConsistentValues):
1681
1682 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1683
1684         Use a correct LC_RPATH when building with ASan
1685         https://bugs.webkit.org/show_bug.cgi?id=196576
1686
1687         Reviewed by David Kilzer.
1688
1689         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1690         so that ../Frameworks is checked. This is simpler and more reliable than updating
1691         each SPC service xcconfig.
1692
1693 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1694
1695         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1696         https://bugs.webkit.org/show_bug.cgi?id=196629
1697
1698         Reviewed by Lucas Forschler.
1699
1700         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1701
1702 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1703
1704         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1705         https://bugs.webkit.org/show_bug.cgi?id=196618
1706
1707         Reviewed by Lucas Forschler.
1708
1709         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1710         (StatusBubble): Added QUEUE_TRIGGERS.
1711         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1712         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1713         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1714         its parent(builder).
1715
1716 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1717
1718         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1719         https://bugs.webkit.org/show_bug.cgi?id=196625
1720
1721         Reviewed by Lucas Forschler.
1722
1723         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1724         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1725
1726 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1727
1728         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1729         https://bugs.webkit.org/show_bug.cgi?id=196630
1730
1731         Reviewed by Wenson Hsieh.
1732
1733         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1734
1735 2019-04-04  Youenn Fablet  <youenn@apple.com>
1736
1737         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1738         https://bugs.webkit.org/show_bug.cgi?id=196543
1739
1740         Reviewed by Alex Christensen.
1741
1742         * WebKitTestRunner/TestController.cpp:
1743         (WTR::TestController::generatePageConfiguration):
1744
1745 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1746
1747         [ews-app] Status bubble should not display skipped buildbot steps
1748         https://bugs.webkit.org/show_bug.cgi?id=196584
1749
1750         Reviewed by Lucas Forschler.
1751
1752         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1753
1754 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1755
1756         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1757         https://bugs.webkit.org/show_bug.cgi?id=196620
1758
1759         Reviewed by Lucas Forschler.
1760
1761         * BuildSlaveSupport/ews-app/ews/config.py:
1762
1763 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1764
1765         [Win] DumpRenderTreeWatchDog.py is not checked into source
1766         https://bugs.webkit.org/show_bug.cgi?id=196567
1767         <rdar://problem/49525901>
1768
1769         Reviewed by Lucas Forschler.
1770
1771         This script is used on Win EWS bots to terminate hanging DRT processes.
1772
1773         * EWSTools/dumprendertreewatchdog.py: Added.
1774
1775 2019-04-04  Chris Dumez  <cdumez@apple.com>
1776
1777         Unreviewed, roll out r243858 which made tests time out.
1778
1779         Disable new API tests on Windows instead.
1780
1781         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1782         (TestWebKitAPI::TEST):
1783
1784 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1785
1786         [ATK] Cleanup WebPageAccessibilityObjectAtk
1787         https://bugs.webkit.org/show_bug.cgi?id=196537
1788
1789         Reviewed by Michael Catanzaro.
1790
1791         Also consider files under atk directories as exceptions for GObject conventions.
1792
1793         * Scripts/webkitpy/style/checkers/cpp.py:
1794         (check_identifier_name_in_declaration):
1795
1796 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1797
1798         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1799         https://bugs.webkit.org/show_bug.cgi?id=196588
1800         <rdar://problem/49365787>
1801
1802         Unreviewed build fix for Windows port.
1803
1804         error C3861: 'kill': identifier not found
1805
1806         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1807         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1808
1809 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1810
1811         [ews-build] Cancel build and similar operations should have authentication
1812         https://bugs.webkit.org/show_bug.cgi?id=196520
1813
1814         Reviewed by Dewei Zhu.
1815
1816         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1817         environment variables.
1818
1819 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1820
1821         [ews-build] Do not trigger queues which are not in production yet
1822         https://bugs.webkit.org/show_bug.cgi?id=196581
1823
1824         Reviewed by Dewei Zhu.
1825
1826         * BuildSlaveSupport/ews-build/config.json:
1827
1828 2019-04-03  Chris Dumez  <cdumez@apple.com>
1829
1830         Unreviewed, fix typo in the name of API test added in r243848.
1831
1832         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1833         (TestWebKitAPI::TEST):
1834
1835 2019-04-03  Chris Dumez  <cdumez@apple.com>
1836
1837         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1838         https://bugs.webkit.org/show_bug.cgi?id=196588
1839         <rdar://problem/49365787>
1840
1841         Reviewed by Ryosuke Niwa.
1842
1843         Add API test coverage.
1844
1845         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1846         (TestWebKitAPI::nullJavaScriptCallback):
1847         (TestWebKitAPI::didCrashCheckFrames):
1848         (TestWebKitAPI::TEST):
1849
1850 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1851
1852         run-webkit-tests: Upload test results (new results database)
1853         https://bugs.webkit.org/show_bug.cgi?id=196577
1854         <rdar://problem/34841155>
1855
1856         Reviewed by Lucas Forschler.
1857
1858         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1859         (Manager.run): Upload results after each device shard, since the configuration will be
1860         different for each device.
1861         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1862         uploaded to a results database.
1863         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1864         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1865
1866 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1867
1868         -apple-trailing-word is needed for browser detection
1869         https://bugs.webkit.org/show_bug.cgi?id=196575
1870
1871         Unreviewed.
1872
1873         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1874
1875 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1876
1877         [CMake][WTF] Mirror XCode header directories
1878         https://bugs.webkit.org/show_bug.cgi?id=191662
1879
1880         Reviewed by Konstantin Tokarev.
1881
1882         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1883         builds.
1884
1885         * CMakeLists.txt:
1886         * DumpRenderTree/CMakeLists.txt:
1887         * DumpRenderTree/PlatformWin.cmake:
1888         * MiniBrowser/win/CMakeLists.txt:
1889         * TestWebKitAPI/CMakeLists.txt:
1890         * TestWebKitAPI/PlatformWin.cmake:
1891         * WebKitTestRunner/PlatformGTK.cmake:
1892         * WebKitTestRunner/PlatformWin.cmake:
1893
1894 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1895
1896         [ews-app] Status bubble should not display certain infrastructure status messages
1897         https://bugs.webkit.org/show_bug.cgi?id=196550
1898
1899         Reviewed by Lucas Forschler.
1900
1901         Do not display the steps which are un-needed for end-user. This information is still avaiable
1902         if the user click on the bubble and look at the Buildbot build.
1903         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1904         (StatusBubble._steps_messages):
1905         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1906
1907 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1908
1909         [ews-build] Use https for sending data to ews-app
1910         https://bugs.webkit.org/show_bug.cgi?id=196492
1911
1912         Reviewed by Lucas Forschler.
1913
1914         * BuildSlaveSupport/ews-build/events.py:
1915
1916 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1917
1918         Remove support for -apple-trailing-word
1919         https://bugs.webkit.org/show_bug.cgi?id=196525
1920
1921         Reviewed by Zalan Bujtas.
1922
1923         This CSS property is nonstandard and not used.
1924
1925         * Scripts/webkitperl/FeatureList.pm:
1926         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1927
1928 2019-04-03  Youenn Fablet  <youenn@apple.com>
1929
1930         Add a test for DOMCache on multiple browsing in case of private browsing
1931         https://bugs.webkit.org/show_bug.cgi?id=196524
1932
1933         Reviewed by Alex Christensen.
1934
1935         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1936         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1937
1938 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1939
1940         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1941         https://bugs.webkit.org/show_bug.cgi?id=196540
1942
1943         Reviewed by Aakash Jain.
1944
1945         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1946
1947 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1948
1949         Add plumbing for a compatibility mode preference in WebKit
1950         https://bugs.webkit.org/show_bug.cgi?id=196005
1951
1952         Reviewed by Tim Horton.
1953
1954         Add new API tests.
1955
1956         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1957         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1958
1959 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1960
1961         [WPE][GTK] Update libsrtp dependency package for Debian
1962         https://bugs.webkit.org/show_bug.cgi?id=196528
1963
1964         Reviewed by Frédéric Wang.
1965
1966         * gtk/install-dependencies:
1967         * wpe/install-dependencies:
1968
1969 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1970
1971         [WK2] Add support for Window's beforeprint / afterprint events
1972         https://bugs.webkit.org/show_bug.cgi?id=196478
1973         <rdar://problem/49535124>
1974
1975         Unreviewed build fix for MSVC.
1976
1977         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1978
1979         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1980
1981         * WebKitTestRunner/TestController.cpp:
1982         (WTR::printFrame): Use int and float literals.
1983
1984 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1985
1986         [ews-build] Reassign bots to queues
1987
1988         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1989
1990 2019-04-02  Chris Dumez  <cdumez@apple.com>
1991
1992         [WK2] Add support for Window's beforeprint / afterprint events
1993         https://bugs.webkit.org/show_bug.cgi?id=196478
1994
1995         Reviewed by Alex Christensen.
1996
1997         Add minimal implementation for printFrame in WebKitTestRunner.
1998
1999         * WebKitTestRunner/TestController.cpp:
2000         (WTR::printFrame):
2001         (WTR::TestController::createOtherPage):
2002         (WTR::TestController::createWebViewWithOptions):
2003
2004 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2005
2006         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2007         https://bugs.webkit.org/show_bug.cgi?id=196491
2008
2009         Reviewed by Lucas Forschler.
2010
2011         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2012
2013 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2014
2015         [ews-build] Configure buildbot try credentials in environment variables
2016         https://bugs.webkit.org/show_bug.cgi?id=196501
2017
2018         Reviewed by Lucas Forschler.
2019
2020         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2021         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2022         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2023
2024 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2025
2026         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2027         https://bugs.webkit.org/show_bug.cgi?id=196496
2028         <rdar://problem/49521634>
2029
2030         Reviewed by Chris Dumez.
2031
2032         Add new API tests (see WebKit ChangeLog for more detail).
2033
2034         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2035         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2036         (TEST):
2037
2038 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2039
2040         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2041         <https://webkit.org/b/196499>
2042
2043         Reviewed by Alexey Proskuryakov.
2044
2045         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2046         ENABLE_ADDRESS_SANITIZER.
2047
2048 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2049
2050         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2051         https://bugs.webkit.org/show_bug.cgi?id=182757
2052
2053         Reviewed by Don Olmstead.
2054
2055         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2056         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2057
2058 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2059
2060         run-api-tests: Upload test results
2061         https://bugs.webkit.org/show_bug.cgi?id=196323
2062         <rdar://problem/49356714>
2063
2064         Reviewed by Lucas Forschler.
2065
2066         * Scripts/webkitpy/api_tests/manager.py:
2067         (Manager):
2068         (Manager.run): Upload results to a results database.
2069         * Scripts/webkitpy/api_tests/run_api_tests.py:
2070         (parse_args): Add upload arguments.
2071         * Scripts/webkitpy/port/base.py:
2072         (Port):
2073         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2074         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2075         with commits from any other associated repositories.
2076         * Scripts/webkitpy/port/device.py:
2077         (Device):
2078         (Device.build_version): Access build_versoin of underlying platform device.
2079         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2080         (IOSSimulatorTest):
2081         (IOSSimulatorTest.test_configuration_for_upload):
2082         * Scripts/webkitpy/port/device_port.py:
2083         (DevicePort):
2084         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2085         the same as the machine uploading results.
2086         * Scripts/webkitpy/port/mac.py:
2087         (MacPort):
2088         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2089         * Scripts/webkitpy/port/mac_unittest.py:
2090         (MacTest):
2091         (MacTest.test_configuration_for_upload):
2092         * Scripts/webkitpy/xcode/simulated_device.py:
2093         (SimulatedDeviceManager._create_device_with_runtime):
2094         (SimulatedDevice.__init__): Create simulated device with a build_version.
2095         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2096         (test_existing_simulator):
2097
2098 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2099
2100         Remove extra newline characters (Follow-up fix to r243707)
2101
2102         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2103
2104 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2105
2106         [ews-app] Use API_KEY to accept results data
2107         https://bugs.webkit.org/show_bug.cgi?id=196461
2108
2109         Reviewed by Dewei Zhu.
2110
2111         * BuildSlaveSupport/ews-app/ews/views/results.py:
2112         (Results.post): Validate EWS_API_KEY before accepting any data.
2113         * BuildSlaveSupport/ews-build/events.py:
2114         (Events.sendData): Send EWS_API_KEY if available along with event data.
2115
2116 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2117
2118         Unable to copy and paste a PDF from Notes into Mail compose body
2119         https://bugs.webkit.org/show_bug.cgi?id=196442
2120         <rdar://problem/48573098>
2121
2122         Reviewed by Tim Horton.
2123
2124         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2125         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2126         to be specified on the item providers.
2127
2128         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2129         (TestWebKitAPI::mapItemForTesting):
2130         (TestWebKitAPI::contactItemForTesting):
2131
2132 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2133
2134         Make UIWKDocumentContext rects per-character instead of per-word
2135         https://bugs.webkit.org/show_bug.cgi?id=196459
2136
2137         Reviewed by Wenson Hsieh.
2138
2139         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2140         (TEST):
2141         Adjust test results due to switching to per-character rects.
2142
2143 2019-04-01  Chris Dumez  <cdumez@apple.com>
2144
2145         UIProcess crash when a prewarmed process is terminated
2146         https://bugs.webkit.org/show_bug.cgi?id=196451
2147         <rdar://problem/49245471>
2148
2149         Reviewed by Geoffrey Garen.
2150
2151         Add API test coverage.
2152
2153         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2154         (TEST):
2155
2156 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2157
2158         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2159         https://bugs.webkit.org/show_bug.cgi?id=196449
2160
2161         Reviewed by Lucas Forschler.
2162
2163         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2164         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2165         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2166         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2167
2168 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2169
2170         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2171         https://bugs.webkit.org/show_bug.cgi?id=196444
2172
2173         Reviewed by Lucas Forschler.
2174
2175         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2176
2177 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2178
2179         Add SPI to canonicalize NSURLs with WTF::URL
2180         https://bugs.webkit.org/show_bug.cgi?id=196415
2181         <rdar://problem/44980271>
2182
2183         Reviewed by Darin Adler.
2184
2185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2186         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2187         (TestWebKitAPI::TEST):
2188
2189 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2190
2191         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2192         https://bugs.webkit.org/show_bug.cgi?id=196441
2193
2194         Reviewed by Carlos Garcia Campos.
2195
2196         Don't cache the wpe_view_backend object that might not exist yet at the
2197         time of EventSenderProxy constructor invocation, but instead retrieve
2198         that object whenever it's required for event dispatching. This should
2199         avoid crashes in this constructor now that it's invoked before any
2200         PlatformWindow has been set up (as changed in r243496).
2201
2202         * WebKitTestRunner/EventSenderProxy.h:
2203         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2204         (WTR::viewBackend):
2205         (WTR::EventSenderProxy::EventSenderProxy):
2206         (WTR::EventSenderProxy::mouseDown):
2207         (WTR::EventSenderProxy::mouseUp):
2208         (WTR::EventSenderProxy::mouseMoveTo):
2209         (WTR::EventSenderProxy::mouseScrollBy):
2210         (WTR::EventSenderProxy::keyDown):
2211         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2212
2213 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2214
2215         [Win][WebKit] MiniBrowser should support high DPI display
2216         https://bugs.webkit.org/show_bug.cgi?id=196391
2217
2218         Reviewed by Alex Christensen.
2219
2220         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2221         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2222         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2223         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2224
2225 2019-03-31  Sam Weinig  <weinig@apple.com>
2226
2227         Remove more i386 specific configurations
2228         https://bugs.webkit.org/show_bug.cgi?id=196430
2229
2230         Reviewed by Alexey Proskuryakov.
2231
2232         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2233         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2234
2235 2019-03-31  Andy Estes  <aestes@apple.com>
2236
2237         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2238         https://bugs.webkit.org/show_bug.cgi?id=196433
2239         <rdar://problem/49293305>
2240
2241         Reviewed by Tim Horton.
2242
2243         Enhanced API test coverage to include all navigation response policy decisions in both
2244         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2245
2246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2247         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2248         (TestWebKitAPI::TEST):
2249         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2250         (readFile):
2251         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2252         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2253         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2254         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2255         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2256         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2257         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2258         (-[QuickLookDelegate _downloadDidStart:]):
2259         (-[QuickLookDelegate _download:didReceiveResponse:]):
2260         (-[QuickLookDelegate _download:didReceiveData:]):
2261         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2262         (-[QuickLookDelegate _downloadDidFinish:]):
2263         (-[QuickLookDelegate _download:didFailWithError:]):
2264         (-[QuickLookDelegate _downloadDidCancel:]):
2265         (-[QuickLookDelegate verifyDownload]):
2266         (runTest):
2267         (runTestDecideBeforeLoading):
2268         (runTestDecideAfterLoading):
2269         (TEST):
2270         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2271         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2272         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2273         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2274         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2275         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2276         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2277         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2278         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2279         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2280         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2281         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2282         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2283         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2284
2285 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2286
2287         [CMake] add testdfg as target with build-jsc
2288         https://bugs.webkit.org/show_bug.cgi?id=196393
2289
2290         Reviewed by Saam Barati.
2291
2292         Added testdfg as one of the targets to build when
2293         using CMake.
2294
2295         * Scripts/build-jsc:
2296
2297 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2298
2299         Delete WebMetal implementation in favor of WebGPU
2300         https://bugs.webkit.org/show_bug.cgi?id=195418
2301
2302         Reviewed by Dean Jackson.
2303
2304         * DumpRenderTree/mac/DumpRenderTree.mm:
2305         (enableExperimentalFeatures):
2306         (resetWebPreferencesToConsistentValues):
2307         * Scripts/webkitperl/FeatureList.pm:
2308         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2310         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2311         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2312         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2313         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2314         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2315         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2316         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2317         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2318         (WTR::InjectedBundle::beginTesting):
2319         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2320         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2321         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2322
2323 2019-03-29  Chris Dumez  <cdumez@apple.com>
2324
2325         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2326         https://bugs.webkit.org/show_bug.cgi?id=196405
2327         <rdar://problem/49428130>
2328
2329         Reviewed by Wenson Hsieh.
2330
2331         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2332         the popover presentation methods to be no-ops. Use this in the new test added in
2333         r243523 so that we do not swizzle those methods for all tests. This is needed because
2334         those WatchOS tests rely on the popover getting presented and interactive.
2335
2336         * WebKitTestRunner/TestController.cpp:
2337         (WTR::updateTestOptionsFromTestHeader):
2338         * WebKitTestRunner/TestController.h:
2339         * WebKitTestRunner/TestOptions.h:
2340         (WTR::TestOptions::hasSameInitializationOptions const):
2341         * WebKitTestRunner/ios/TestControllerIOS.mm:
2342         (WTR::TestController::platformInitialize):
2343         (WTR::TestController::platformResetStateToConsistentValues):
2344
2345 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2346
2347         [Curl] Add Server Trust Evaluation Support.
2348         https://bugs.webkit.org/show_bug.cgi?id=191646
2349
2350         Reviewed by Fujii Hironori.
2351
2352         Implemented MiniBrowser UI for asking if user trusts the server.
2353
2354         * MiniBrowser/win/Common.cpp:
2355         (askServerTrustEvaluation):
2356         (replaceString):
2357         * MiniBrowser/win/Common.h:
2358         * MiniBrowser/win/MiniBrowserLib.rc:
2359         * MiniBrowser/win/MiniBrowserLibResource.h:
2360         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2361         (createPEMString):
2362         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2363         (WebKitBrowserWindow::canTrustServerCertificate):
2364         * MiniBrowser/win/WebKitBrowserWindow.h:
2365
2366 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2367
2368         Implement ResizeObserver.
2369         https://bugs.webkit.org/show_bug.cgi?id=157743
2370
2371         Reviewed by Simon Fraser.
2372
2373         Support resizeObserverEnabled webPreferences.
2374
2375         * DumpRenderTree/TestOptions.cpp:
2376         (TestOptions::TestOptions):
2377         * DumpRenderTree/TestOptions.h:
2378         * DumpRenderTree/mac/DumpRenderTree.mm:
2379         (setWebPreferencesForTestOptions):
2380         * DumpRenderTree/win/DumpRenderTree.cpp:
2381         (enableExperimentalFeatures):
2382         * Scripts/webkitperl/FeatureList.pm:
2383         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2384
2385 2019-03-28  John Wilander  <wilander@apple.com>
2386
2387         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2388         https://bugs.webkit.org/show_bug.cgi?id=196281
2389         <rdar://problem/48938748>
2390
2391         Reviewed by Alex Christensen.
2392
2393         This patch adds the function isStatisticsHasLocalStorage() to the
2394         TestRunner. With it, the page can query the WebsiteDataStore in the
2395         UI process to make sure that it sees LocalStorage.
2396
2397         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2398         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2399         (WTR::TestRunner::isStatisticsHasLocalStorage):
2400         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2401         * WebKitTestRunner/TestController.cpp:
2402         (WTR::TestController::isStatisticsHasLocalStorage):
2403         * WebKitTestRunner/TestController.h:
2404         * WebKitTestRunner/TestInvocation.cpp:
2405         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2406
2407 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2408
2409         API::Data::createWithoutCopying should do a null check before calling CFRelease
2410         https://bugs.webkit.org/show_bug.cgi?id=196276
2411         <rdar://problem/48059859>
2412
2413         Reviewed by Alex Christensen.
2414
2415         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2416
2417         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2418         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2419         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2420         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2421         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2422         (TestWebKitAPI::TEST):
2423
2424 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2425
2426         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2427         https://bugs.webkit.org/show_bug.cgi?id=186276
2428
2429         Reviewed by Carlos Garcia Campos.
2430
2431         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2432         (webViewLoadChanged):
2433         (testWebResourceGetDataError):
2434         (testWebResourceGetDataEmpty):
2435         (beforeAll):
2436         (webViewloadChanged): Deleted.
2437
2438 2019-03-27  Andy Estes  <aestes@apple.com>
2439
2440         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2441         https://bugs.webkit.org/show_bug.cgi?id=196317
2442
2443         Reviewed by Dan Bernstein.
2444
2445         package-root copies built products into a staging directory using ditto(1), which does not
2446         follow symbolic links as it traverses a directory. Now that the files in
2447         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2448         itself, these become broken links when ditto'd into the staging directory.
2449
2450         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2451
2452         * Scripts/package-root:
2453
2454 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2455
2456         [ews-app] Update display text of Submit for ews analysis
2457         https://bugs.webkit.org/show_bug.cgi?id=196309
2458
2459         Reviewed by Dewei Zhu.
2460
2461         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2462
2463 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2464
2465         run-webkit-tests should check for leaks in WebKit processes
2466         <https://webkit.org/b/193772>
2467         <rdar://problem/46526680>
2468
2469         Reviewed by Ryosuke Niwa.
2470
2471         This works by doing the following:
2472         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2473           The list of child processes are returned one per line:
2474           process.name: pid
2475         - Run the "#LIST CHILD PROCESSES" command just before the
2476           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2477           processes on the ServerProcess object.
2478         - When the `--leaks` switch is handled, run check_for_leaks() on
2479           each child process after the main test harness.
2480
2481         * DumpRenderTree/mac/DumpRenderTree.mm:
2482         (handleControlCommand):
2483         - Use strncmp() instead of strcmp().
2484         - Add support for handling "#LIST CHILD PROCESSES" command.
2485
2486         * Scripts/webkitpy/port/base.py:
2487         (Port.check_for_leaks):
2488         * Scripts/webkitpy/port/darwin.py:
2489         (DarwinPort.check_for_leaks):
2490         - Rename redundant 'process_pid' argument to 'process_id'.
2491
2492         * Scripts/webkitpy/port/driver.py:
2493         (Driver.do_post_tests_work):
2494         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2495           longer the only command this sends to WebKitTestRunner.
2496         - If the `--leaks` switch is present, send the
2497           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2498           result using Port.set_webkit_processes().
2499         (Driver._parse_child_processes_output):
2500         - Add helper method to parse list of child process names and
2501           process IDs returned from WebKitTestRunner.
2502
2503         * Scripts/webkitpy/port/ios_device.py:
2504         (IOSDevicePort.check_for_leaks):
2505         - Rename redundant 'process_pid' argument to 'process_id'.
2506
2507         * Scripts/webkitpy/port/leakdetector.py:
2508         (LeakDetector._parse_leaks_output):
2509         - Return early if there is no leaks_output.
2510         (LeakDetector.check_for_leaks):
2511         - Rename redundant 'process_pid' argument to 'process_id'.
2512
2513         * Scripts/webkitpy/port/server_process.py:
2514         (ServerProcess.__init__):
2515         (ServerProcess.child_processes):
2516         (ServerProcess.set_child_processes):
2517         - Add instance variable to Port to store list of child process
2518           names and process IDs returned from WebKitTestRunner.
2519         (ServerProcess._start):
2520         - Clear self._child_processes.
2521         (ServerProcess.stop):
2522         - If self._child_processes is set, call
2523           self._port.check_for_leaks() for each child process.
2524
2525         * Scripts/webkitpy/port/server_process_unittest.py:
2526         (TrivialMockPort.check_for_leaks):
2527         - Rename redundant 'process_pid' argument to 'process_id'.
2528
2529         * Scripts/webkitpy/port/simulator_process.py:
2530         (SimulatorProcess.stop):
2531         - If self._child_processes is set, call
2532           self._port.check_for_leaks() for each child process.
2533
2534         * Scripts/webkitpy/port/watch_device.py:
2535         (WatchDevicePort.check_for_leaks):
2536         - Rename redundant 'process_pid' argument to 'process_id'.
2537
2538         * WebKitTestRunner/TestController.cpp:
2539         (WTR::TestController::dumpResponse):
2540         - Extract method from findAndDumpWorldLeaks() so that it may be
2541           reused by findAndDumpWebKitProcessIdentifiers().
2542         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2543         - Add method to output process name and process ID of both the
2544           WebContent and Networking processes.
2545         (WTR::TestController::findAndDumpWorldLeaks):
2546         - Fix missing newline in output when there were no abandoned
2547           documents.
2548         - Call dumpResponse() for extracted code.
2549         (WTR::TestController::handleControlCommand):
2550         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2551         - Use strncmp() instead of strcmp().
2552         - Call findAndDumpWebKitProcessIdentifiers() when
2553           "#LIST CHILD PROCESSES" command is sent.
2554         * WebKitTestRunner/TestController.h:
2555         (WTR::TestController::dumpResponse):
2556         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2557         - Declare methods.
2558
2559 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2560
2561         Unreviewed. Add GLib API test cases after r243434.
2562
2563         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2564         (testWebViewActiveURI):
2565         (serverCallback):
2566         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2567         (sendRequestCallback):
2568
2569 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2570
2571         Geolocation request not complete when watch request was started in a different web process
2572         https://bugs.webkit.org/show_bug.cgi?id=195996
2573
2574         Reviewed by Alex Christensen.
2575
2576         Add a test case.
2577
2578         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2579         (TestWebKitAPI::runJavaScriptAlert):
2580         (TestWebKitAPI::TEST):
2581
2582 2019-03-26  Keith Rollin  <krollin@apple.com>
2583
2584         Update the way generate-xcfilelists returns strings from functions
2585         https://bugs.webkit.org/show_bug.cgi?id=195975
2586         <rdar://problem/49040807>
2587
2588         Reviewed by Dean Jackson.
2589
2590         There are places where generate-xcfilelists executes assignments with
2591         statements like:
2592
2593             FOO=$(some_function)
2594
2595         where "some_function" return a string by echoing it. E.g.
2596
2597             some_function()
2598             {
2599                 echo "Hello, World"
2600             }
2601
2602         This is a common idiom, but it has a problem if "some_function" needs
2603         to call "exit" in an attempt to halt the entire script right then and
2604         there. Since "some_function" is called inside of $(), it's being
2605         executed in a sub-shell. Calling exit in that sub-shell simply exits
2606         that shell; it doesn't not exit the outer shell in which the main part
2607         of the script is still running. As such, the main script keeps
2608         executing when the intent was for the script to halt.
2609
2610         The solution to this is to use a different idiom for returning
2611         strings. The one we now is to pass in the name of the variable to
2612         receive the string result:
2613
2614             some_function()
2615             {
2616                 variable_name=$1
2617                 eval $variable_name ="Hello, World"
2618             }
2619
2620         The call site now looks like
2621
2622             some_function FOO
2623
2624         Because there's no invocation of a sub-shell, some_function can now
2625         call "exit" if it wants to, and the entire script will exit at that
2626         point.
2627
2628         * Scripts/generate-xcfilelists:
2629
2630 2019-03-26  Chris Dumez  <cdumez@apple.com>
2631
2632         Add basic layout test coverage for File Picker on iOS
2633         https://bugs.webkit.org/show_bug.cgi?id=196265
2634
2635         Reviewed by Wenson Hsieh.
2636
2637         Add layout test infrastructure to test the file picker on iOS.
2638
2639         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2640         (WTR::UIScriptController::dismissFilePicker):
2641         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2642         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2643         (WTR::UIScriptController::dismissFilePicker):
2644         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2645         * WebKitTestRunner/TestController.cpp:
2646         (WTR::TestController::createWebViewWithOptions):
2647         (WTR::updateTestOptionsFromTestHeader):
2648         * WebKitTestRunner/TestOptions.h:
2649         (WTR::TestOptions::hasSameInitializationOptions const):
2650         * WebKitTestRunner/ios/TestControllerIOS.mm:
2651         (overridePresentViewController):
2652         (WTR::TestController::platformInitialize):
2653         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2654         (WTR::UIScriptController::dismissFilePicker):
2655
2656 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2657
2658         Implement async paste method on UIWKInteractionViewProtocol
2659         https://bugs.webkit.org/show_bug.cgi?id=196267
2660         <rdar://problem/49236346>
2661
2662         Reviewed by Tim Horton.
2663
2664         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2665         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2666         are now a part of all iOS 12 internal SDKs.
2667
2668         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2669
2670         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2671         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2672
2673         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2674         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2675         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2676         * TestWebKitAPI/ios/UIKitSPI.h:
2677
2678 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2679
2680         [ews-build] Use PostgreSQL for ews.webkit.org database
2681         https://bugs.webkit.org/show_bug.cgi?id=196270
2682
2683         Reviewed by Lucas Forschler.
2684
2685         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2686
2687 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2688
2689         [ews] Reset simctl states on reboot
2690         https://bugs.webkit.org/show_bug.cgi?id=196260
2691
2692         Rubber-stamped by Aakash Jain.
2693
2694         * EWSTools/start-queue-mac.sh:
2695
2696 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2697
2698         [ews-build] Use PostgreSQL for ews-build database
2699         https://bugs.webkit.org/show_bug.cgi?id=196229
2700
2701         Reviewed by Lucas Forschler.
2702
2703         * BuildSlaveSupport/ews-build/master.cfg:
2704
2705 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2706
2707         [ews-build] Get master_hostname dynamically in master.cfg
2708         https://bugs.webkit.org/show_bug.cgi?id=196255
2709
2710         Reviewed by Lucas Forschler.
2711
2712         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2713         send events data in test mode.
2714
2715 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2716
2717         [ews-app] Set db_constraint to False for Foreign Keys
2718         https://bugs.webkit.org/show_bug.cgi?id=196252
2719
2720         Reviewed by Lucas Forschler.
2721
2722         * BuildSlaveSupport/ews-app/ews/models/build.py:
2723         * BuildSlaveSupport/ews-app/ews/models/step.py:
2724
2725 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2726
2727         [ews-build] is_test_mode_enabled should default to True
2728         https://bugs.webkit.org/show_bug.cgi?id=196248
2729
2730         Reviewed by Lucas Forschler.
2731
2732         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2733
2734 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2735
2736         [ews-app] Add webkitperl to ENABLED_QUEUES
2737         https://bugs.webkit.org/show_bug.cgi?id=196253
2738
2739         Reviewed by Lucas Forschler.
2740
2741         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2742
2743 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2744
2745         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2746         https://bugs.webkit.org/show_bug.cgi?id=196211
2747         rdar://problem/49110552
2748
2749         Reviewed by Tim Horton.
2750
2751         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2752         Make sure that EventSenderProxy always exists when running tests. We used to create
2753         it when resetting before the first test, which is a bit too late.
2754
2755         * WebKitTestRunner/TestController.h:
2756         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2757         (WTR::TestController::platformCreateWebView):
2758         (WTR::TestController::platformCreateOtherPage):
2759         (WTR::TestController::finishCreatingPlatformWebView):
2760         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2761         (WTR::PlatformWebView::PlatformWebView):
2762         Moved some code that made NSWindow use NSEvent during web view creation. We may
2763         need to move more if some other case us found, but this is enough for now.
2764
2765 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2766
2767         Unreviewed. Fix typo in GLib geolocation API after r243285.
2768
2769         gelocation -> geolocation.
2770
2771         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2772         (testGeolocationManagerWatchPosition):
2773
2774 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2775
2776         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2777         https://bugs.webkit.org/show_bug.cgi?id=196213
2778
2779         Reviewed by Geoff Garen.
2780
2781         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2782         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2783         (credentialWithIdentityAndKeychainPath):
2784         (-[ChallengeDelegate webView:didFinishNavigation:]):
2785         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2786         (TestWebKitAPI::TEST):
2787
2788 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2789
2790         Expected shouldn't assume its contained types are copyable
2791         https://bugs.webkit.org/show_bug.cgi?id=195986
2792
2793         Reviewed by JF Bastien.
2794
2795         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2796         (TestWebKitAPI::NonCopyable::operator== const):
2797         (TestWebKitAPI::NonCopyable::operator!= const):
2798         (TestWebKitAPI::TEST):
2799
2800 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2801
2802         Remove some now-unnecessary dynamic class lookup
2803         https://bugs.webkit.org/show_bug.cgi?id=196237
2804
2805         Reviewed by Simon Fraser.
2806
2807         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2808         (makeRequest):
2809         (TEST):
2810
2811 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2812
2813         Unreviewed, rolling out r243450.
2814
2815         AppleWin and WinCairo port builds get broken.
2816
2817         Reverted changeset:
2818
2819         "Add test for fix of #196095"
2820         https://bugs.webkit.org/show_bug.cgi?id=196097
2821         https://trac.webkit.org/changeset/243450
2822
2823 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2824
2825         Unreviewed, rolling out r243465.
2826         https://bugs.webkit.org/show_bug.cgi?id=196226
2827
2828         the test doesn't build (Requested by thorton on #webkit).
2829
2830         Reverted changeset:
2831
2832         "Do not terminate the NetworkProcess if a third party
2833         application sends a NSCredential with a SecIdentityRef"
2834         https://bugs.webkit.org/show_bug.cgi?id=196213
2835         https://trac.webkit.org/changeset/243465
2836
2837 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2838
2839         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2840         https://bugs.webkit.org/show_bug.cgi?id=196213
2841
2842         Reviewed by Geoff Garen.
2843
2844         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2845         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2846         (credentialWithIdentityAndKeychainPath):
2847         (-[ChallengeDelegate webView:didFinishNavigation:]):
2848         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2849         (TestWebKitAPI::TEST):
2850
2851 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2852
2853         [ews-build] Gracefully handle missing patch_id in events
2854         https://bugs.webkit.org/show_bug.cgi?id=196216
2855
2856         Reviewed by Lucas Forschler.
2857
2858         * BuildSlaveSupport/ews-build/events.py:
2859
2860 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2861
2862         [ews-build] use lz4 compression for improving buildbot performance
2863         https://bugs.webkit.org/show_bug.cgi?id=196155
2864
2865         Reviewed by Lucas Forschler.
2866
2867         * BuildSlaveSupport/ews-build/master.cfg:
2868
2869 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2870
2871         Pull some API testing helper methods out of TestWKWebView
2872         https://bugs.webkit.org/show_bug.cgi?id=196212
2873
2874         Reviewed by Tim Horton.
2875
2876         Refactor some more API testing utility methods, so that they can be used in
2877         tests that do not use TestWKWebView.
2878
2879         * TestWebKitAPI/cocoa/TestWKWebView.h:
2880         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2881         (-[WKWebView loadTestPageNamed:]):
2882         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2883         (-[WKWebView synchronouslyLoadHTMLString:]):
2884         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2885         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2886         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2887         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2888         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2889
2890 2019-03-25  Jer Noble  <jer.noble@apple.com>
2891
2892         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2893         https://bugs.webkit.org/show_bug.cgi?id=196097
2894
2895         Reviewed by Eric Carlson.
2896
2897         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2898
2899         * DumpRenderTree/mac/DumpRenderTree.mm:
2900         (resetWebPreferencesToConsistentValues):
2901         * WebKitTestRunner/TestController.cpp:
2902         (WTR::TestController::resetPreferencesToConsistentValues):
2903
2904 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2905
2906         Pull IPadUserInterfaceSwizzler out into a separate header file
2907         https://bugs.webkit.org/show_bug.cgi?id=196193
2908
2909         Reviewed by Anders Carlsson.
2910
2911         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2912         be used in other API tests.
2913
2914         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2915         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2916         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2917         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2918         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2919         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2920         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2921
2922 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2923
2924         Remove NavigatorContentUtils in WebCore/Modules
2925         https://bugs.webkit.org/show_bug.cgi?id=196070
2926
2927         Reviewed by Alex Christensen.
2928
2929         NavigatorContentUtils was to support the custom scheme spec [1].
2930         However, in WebKit side, no port has supported the feature in
2931         WebKit layer after EFL port was removed. So there has been the
2932         only IDL implementation of the NavigatorContentUtils in WebCore.
2933         So we don't need to keep the implementation in WebCore anymore.
2934
2935         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2936
2937         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2938
2939 2019-03-24  Andy Estes  <aestes@apple.com>
2940
2941         [watchOS] Remove unused Proximity Networking code
2942         https://bugs.webkit.org/show_bug.cgi?id=196188
2943
2944         Reviewed by Tim Horton.
2945
2946         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2947         (TEST):
2948
2949 2019-03-23  Keith Miller  <keith_miller@apple.com>
2950
2951         Refactor clz/ctz and fix getLSBSet.
2952         https://bugs.webkit.org/show_bug.cgi?id=196162
2953
2954         Reviewed by Saam Barati.
2955
2956         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2957
2958         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2959         (TestWebKitAPI::TEST):
2960
2961 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2962
2963         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2964         https://bugs.webkit.org/show_bug.cgi?id=196143
2965
2966         Reviewed by Michael Catanzaro.
2967
2968         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2969         directories.
2970
2971         * Scripts/webkitpy/style/checkers/cpp.py:
2972         (check_identifier_name_in_declaration):
2973         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2974         (WebKitStyleTest.test_names):
2975
2976 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2977
2978         [Flatpak] Manifest expanding fails for qt WPE extension
2979         https://bugs.webkit.org/show_bug.cgi?id=196148
2980
2981         Reviewed by Alex Christensen.
2982
2983         * flatpak/flatpakutils.py:
2984         (expand_submodules_recurse): The last recurse manifest expand
2985         iteration might lead to a single module so take it into account
2986         and don't try to recurse further.
2987
2988 2019-03-22  Chris Dumez  <cdumez@apple.com>
2989
2990         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2991         https://bugs.webkit.org/show_bug.cgi?id=195348
2992         <rdar://problem/48622090>
2993
2994         Reviewed by Alex Christensen.
2995
2996         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2997         to NO when test.options().shouldIgnoreMetaViewport is false.
2998
2999         * WebKitTestRunner/ios/TestControllerIOS.mm:
3000         (WTR::TestController::platformConfigureViewForTest):
3001
3002 2019-03-22  Chris Dumez  <cdumez@apple.com>
3003
3004         Prewarmed processes should be usable with any website data store
3005         https://bugs.webkit.org/show_bug.cgi?id=196104
3006
3007         Reviewed by Alex Christensen.
3008
3009         Add API test coverage.
3010
3011         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3012         (runInitialWarmedProcessUsedTest):
3013         (TEST):
3014
3015 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3016
3017         Back out local changes to Alex's Subversion working directory
3018
3019         They were accidentally committed.
3020
3021         * Scripts/webkitpy/common/system/abstractexecutive.py:
3022         (AbstractExecutive.wait_newest):
3023         * Scripts/webkitpy/common/system/executive.py:
3024         (Executive.running_pids):
3025         * Scripts/webkitpy/common/system/executive_mock.py:
3026         (MockExecutive.running_pids):
3027         * Scripts/webkitpy/common/system/executive_unittest.py:
3028         (ExecutiveTest.serial_test_running_pids):
3029         * Scripts/webkitpy/port/darwin.py:
3030         (DarwinPort.check_for_leaks):
3031         * Scripts/webkitpy/port/leakdetector.py:
3032         (LeakDetector.check_for_leaks):
3033         - This was the hack attached to Bug 193772.
3034
3035         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3036         (+[WebKitTestRunnerEvent mouseLocation]):
3037         - This works around a crash on an internal build.
3038
3039 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3040
3041         Fix the build after r243354
3042         https://bugs.webkit.org/show_bug.cgi?id=196138
3043         <rdar://problem/49145951>
3044
3045         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3046         (TEST):
3047         * TestWebKitAPI/ios/UIKitSPI.h:
3048
3049 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3050
3051         Adopt UIWKDocumentContext
3052         https://bugs.webkit.org/show_bug.cgi?id=196040
3053         <rdar://problem/48642440>
3054
3055         Reviewed by Ryosuke Niwa.
3056
3057         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3058         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3059         (makeRequest):
3060         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3061         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3062         (applyStyle):
3063         (TEST):
3064         Add tests for UIWKDocumentContext.
3065
3066         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3067         (TEST):
3068         (recursiveFindWKContentView): Deleted.
3069         * TestWebKitAPI/cocoa/TestWKWebView.h:
3070         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3071         (recursiveFindWKContentView):
3072         (-[TestWKWebView wkContentView]):
3073         * TestWebKitAPI/ios/UIKitSPI.h:
3074         Share the WKContentView finding code between tests.
3075
3076 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3077
3078         [iOS WK2] Turn on async overflow scrolling by default
3079         https://bugs.webkit.org/show_bug.cgi?id=196011
3080         rdar://problem/48453859
3081
3082         Reviewed by Antti Koivisto.
3083         
3084         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3085         since so many basic layout tests have different results when compositing is triggered for
3086         overflow.
3087         
3088         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3089
3090         * WebKitTestRunner/TestController.cpp:
3091         (WTR::TestController::resetPreferencesToConsistentValues):
3092
3093 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3094
3095         [ews-build] Retry API test in case of failures
3096         https://bugs.webkit.org/show_bug.cgi?id=196004
3097
3098         Reviewed by Lucas Forschler.
3099
3100         * BuildSlaveSupport/ews-build/steps.py:
3101         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3102         (CompileWebKitToT.doStepIf): Ditto.
3103         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3104         (ReRunAPITests): Re-run API tests.
3105         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3106         (RunAPITestsWithoutPatch): Run API tests without patch.
3107         (RunAPITestsWithoutPatch.doStepIf):
3108         (RunAPITestsWithoutPatch.hideStepIf):
3109         (RunAPITestsWithoutPatch.evaluateCommand):
3110         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3111         (AnalyzeAPITestsResults.start):
3112         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3113         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3114         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3115         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3116
3117 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3118
3119         [ews-build] Update queues configurations
3120         https://bugs.webkit.org/show_bug.cgi?id=196074
3121
3122         Reviewed by Dewei Zhu.
3123
3124         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3125         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3126
3127 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3128
3129         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3130         https://bugs.webkit.org/show_bug.cgi?id=195680
3131         <rdar://problem/48903534>
3132
3133         Unreviewed infrastructure fix.
3134
3135         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3136         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3137
3138 2019-03-21  Andy Estes  <aestes@apple.com>
3139
3140         [iOS] Apple Pay should be available in documents with no user agent scripts
3141         https://bugs.webkit.org/show_bug.cgi?id=196061
3142         <rdar://problem/48649391>
3143
3144         Reviewed by Brady Eidson.
3145
3146         Added API tests and related infrastructure.
3147
3148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3149         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3150         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3151         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3152         (TestWebKitAPI::TEST):
3153         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3154         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3155         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3156         * TestWebKitAPI/cocoa/TestProtocol.mm:
3157         (-[TestProtocol startLoading]):
3158         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3159         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3160         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3161         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3162
3163 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3164
3165         REGRESSSION (r243297): webkitpy tests broken
3166         https://bugs.webkit.org/show_bug.cgi?id=196108
3167
3168         Reviewed by Aakash Jain.
3169
3170         r243297 updated contributors.json, which broke a few unit tests.
3171
3172         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3173         (IRCCommandTest.test_whois):
3174         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3175
3176 2019-03-21  Chris Dumez  <cdumez@apple.com>
3177
3178         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3179         https://bugs.webkit.org/show_bug.cgi?id=196041
3180         <rdar://problem/49083230>
3181
3182         Reviewed by Alex Christensen.
3183
3184         Add API test coverage.
3185
3186         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3187         (TEST):
3188
3189 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3190
3191         Add SPI to inform applications of WKContentRuleList actions
3192         https://bugs.webkit.org/show_bug.cgi?id=195965
3193         <rdar://problem/42664365>
3194
3195         Reviewed by Geoff Garen.
3196
3197         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3198         (TestWebKitAPI::allActionsForResourceLoad):
3199         (TestWebKitAPI::testRequest):
3200         (TestWebKitAPI::TEST_F):
3201         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3202         (Notification::description):
3203         (Notification::operator== const):
3204         (toVector):
3205         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3206         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3207         (makeContentRuleList):
3208         (TEST):
3209         (makeWarnContentRuleList): Deleted.
3210
3211 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3212
3213         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3214         https://bugs.webkit.org/show_bug.cgi?id=196088
3215
3216         Reviewed by Brian Burg.
3217
3218         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3219         Support checks when only one platform is specified. Also deprecate macosx() and
3220         force the use of macos() instead.
3221
3222         * Scripts/webkitpy/style/checkers/cpp.py:
3223         (check_min_versions_of_wk_api_available):
3224         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3225         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3226
3227 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3228
3229         Update status inactive committers' status to 'contributor'.
3230
3231         * Scripts/webkitpy/common/config/contributors.json:
3232
3233 2019-03-21  Xan Lopez  <xan@igalia.com>
3234
3235         [JSC][x86] Drop support for x87 floating point
3236         https://bugs.webkit.org/show_bug.cgi?id=194853
3237
3238         Reviewed by Don Olmstead.
3239
3240         Force SSE2 on x86/32bit builds.
3241
3242         * Scripts/webkitdirs.pm:
3243         (generateBuildSystemFromCMakeProject):
3244
3245 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3246
3247         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3248         https://bugs.webkit.org/show_bug.cgi?id=196073
3249
3250         Reviewed by Michael Catanzaro.
3251
3252         Add test cases to check functions and constructors with no arguments but receiving user data.
3253
3254         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3255         (checkUserData):
3256         (testJSCFunction):
3257         (fooCreateWithUserData):
3258         (testJSCClass):
3259
3260 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3261
3262         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3263
3264         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3265
3266         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3267
3268 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3269
3270         [GTK][WPE] Add API to provide geolocation information
3271         https://bugs.webkit.org/show_bug.cgi?id=195940
3272
3273         Reviewed by Michael Catanzaro.
3274
3275         Add a new test to check the new API.
3276
3277         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3278         (testGeolocationManagerCurrentPosition):
3279         (testGeolocationManagerWatchPosition):
3280         (beforeAll):
3281         (afterAll):
3282         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3283         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3284         (beforeAll): Ditto.
3285         * TestWebKitAPI/glib/CMakeLists.txt:
3286
3287 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3288
3289         [GLib] Returning G_TYPE_OBJECT from a method does not work
3290         https://bugs.webkit.org/show_bug.cgi?id=195574
3291
3292         Reviewed by Michael Catanzaro.
3293
3294         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3295
3296         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3297         (getGFile):
3298         (getParent):
3299         (createGString):
3300         (getGString):
3301         (getGStringCopyWillRaise):
3302         (getGStringCopy):
3303         (getGStringStr):
3304         (getGStringLen):
3305         (freeGString):
3306         (testJSCClass):
3307
3308 2019-03-20  Saam Barati  <sbarati@apple.com>
3309
3310         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3311         https://bugs.webkit.org/show_bug.cgi?id=195721
3312
3313         Reviewed by Filip Pizlo.
3314
3315         * Scripts/run-javascriptcore-tests:
3316
3317 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3318
3319         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3320         https://bugs.webkit.org/show_bug.cgi?id=196049
3321
3322         Reviewed by Tim Horton.
3323
3324         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3325         overflow scrolling in general, so rename it.
3326
3327         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3328
3329 2019-03-20  Daniel Bates  <dabates@apple.com>
3330
3331         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3332         https://bugs.webkit.org/show_bug.cgi?id=196031
3333         <rdar://problem/49078172>
3334
3335         Reviewed by Tim Horton.
3336
3337         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3338         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3339         same code path used when the Done button is pressed to dismiss the <select> picker.
3340
3341         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3342         (TestWebKitAPI::TEST):
3343
3344 2019-03-20  Chris Dumez  <cdumez@apple.com>
3345
3346         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3347         https://bugs.webkit.org/show_bug.cgi?id=196029
3348         <rdar://problem/48954651>
3349
3350         Reviewed by Tim Horton.
3351
3352         Add API test coverage.
3353
3354         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3355
3356 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3357
3358         [ews-build] Improve failure summary string for ApplyPatch step
3359         https://bugs.webkit.org/show_bug.cgi?id=195995
3360
3361         Reviewed by Alexey Proskuryakov.
3362
3363         * BuildSlaveSupport/ews-build/steps.py:
3364         (ApplyPatch.getResultSummary): Override getResultSummary.
3365
3366 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3367
3368         AX: Implement support for new meter ARIA role
3369         https://bugs.webkit.org/show_bug.cgi?id=195966
3370
3371         Reviewed by Chris Fleizach.
3372
3373         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3374         to AXLevelIndicator.
3375
3376         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3377
3378 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3379
3380         [WebAuthN] Implement FIDO AppID extension
3381         https://bugs.webkit.org/show_bug.cgi?id=143491
3382         <rdar://problem/48298273>
3383
3384         Reviewed by Brent Fulgham.
3385
3386         Add a test that covers the new flag of convertToU2fSignCommand.
3387
3388         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3389         (TestWebKitAPI::TEST):
3390         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3391         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3392         (TestWebKitAPI::TEST):
3393
3394 2019-03-19  Keith Rollin  <krollin@apple.com>
3395
3396         Add support for more platforms to generate-xcfilelists
3397         https://bugs.webkit.org/show_bug.cgi?id=195977
3398
3399         Reviewed by Alexey Proskuryakov.
3400
3401         generate-xcfilelists incorrectly complains when involved with building
3402         WebKit for iphonesimulator:
3403
3404             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3405             …
3406             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3407
3408         Address this by teaching generate-xcfilelists about more platforms.
3409
3410         * Scripts/generate-xcfilelists:
3411
3412 2019-03-19  John Wilander  <wilander@apple.com>
3413
3414         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3415         https://bugs.webkit.org/show_bug.cgi?id=195923
3416         <rdar://problem/49001272>
3417
3418         Reviewed by Alex Christensen.
3419
3420         This patch does the following to the TestRunner:
3421         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3422         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3423         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3424
3425         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3426         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3427         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3428         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3429         * WebKitTestRunner/TestController.cpp:
3430         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3431         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3432         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3433         * WebKitTestRunner/TestController.h:
3434         * WebKitTestRunner/TestInvocation.cpp:
3435         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3436
3437 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3438
3439         [CMake] Support more clang and gcc sanitizers
3440         https://bugs.webkit.org/show_bug.cgi?id=195956
3441
3442         Reviewed by Michael Catanzaro.
3443
3444         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3445
3446 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3447
3448         [ews-build] Improve summary for PrintConfiguration step
3449         https://bugs.webkit.org/show_bug.cgi?id=195945
3450
3451         Reviewed by Lucas Forschler.
3452
3453         * BuildSlaveSupport/ews-build/steps.py:
3454         (PrintConfiguration.getResultSummary): Override getResultSummary.
3455
3456 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3457
3458         [ews-build] Improve summary for CheckOutSource step
3459         https://bugs.webkit.org/show_bug.cgi?id=195963
3460
3461         Reviewed by Lucas Forschler.
3462
3463         * BuildSlaveSupport/ews-build/steps.py:
3464         (CheckOutSource.getResultSummary):
3465
3466 2019-03-19  Daniel Bates  <dabates@apple.com>
3467
3468         [iOS] Focus not preserved when switching between tabs
3469         https://bugs.webkit.org/show_bug.cgi?id=195820
3470         <rdar://problem/43614450>
3471
3472         Reviewed by Brent Fulgham.
3473
3474         Add tests to ensure that we restore focus when resigning and becoming first responder.
3475
3476         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3477         (TestWebKitAPI::TEST):
3478
3479 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3480
3481         Make WTFLogChannelState and WTFLogLevel enum classes
3482         https://bugs.webkit.org/show_bug.cgi?id=195904
3483
3484         Reviewed by Eric Carlson.
3485
3486         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3487         (TestWebKitAPI::TEST_F):
3488
3489 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3490
3491         [GStreamer][EME] Backported mssdemux protection data crash fix
3492         https://bugs.webkit.org/show_bug.cgi?id=195918
3493
3494         Reviewed by Philippe Normand.
3495
3496         * gstreamer/jhbuild.modules:
3497         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3498
3499 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3500
3501         Unreviewed, rolling out r243132.
3502
3503         Broke GTK build
3504
3505         Reverted changeset:
3506
3507         "Make WTFLogChannelState and WTFLogLevel enum classes"
3508         https://bugs.webkit.org/show_bug.cgi?id=195904
3509         https://trac.webkit.org/changeset/243132
3510
3511 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3512
3513         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3514
3515         * Scripts/webkitdirs.pm:
3516         (builtDylibPathForName): Adjust the shared library name that's changed
3517         with the API version bump in r243073.
3518
3519 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3520
3521         Make WTFLogChannelState and WTFLogLevel enum classes
3522         https://bugs.webkit.org/show_bug.cgi?id=195904
3523
3524         Reviewed by Eric Carlson.
3525
3526         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3527         (TestWebKitAPI::TEST_F):
3528
3529 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3530
3531         Disable flaky test added in r2431100
3532         https://webkit.org/b/195785
3533
3534         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3535         (TestWebKitAPI::TEST):
3536         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3537
3538 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3539
3540         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3541         https://bugs.webkit.org/show_bug.cgi?id=195916
3542
3543         Reviewed by Tim Horton.
3544
3545         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3546         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3547
3548 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3549
3550         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3551
3552         * Scripts/webkitpy/common/config/contributors.json:
3553
3554 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3555
3556         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3557         https://bugs.webkit.org/show_bug.cgi?id=195785
3558
3559         Reviewed by Geoffrey Garen.
3560
3561         * TestWebKitAPI/TCPServer.cpp: Added.
3562         (TestWebKitAPI::TCPServer::TCPServer):
3563         (TestWebKitAPI::TCPServer::~TCPServer):
3564         (TestWebKitAPI::TCPServer::socketBindListen):
3565         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3566         * TestWebKitAPI/TCPServer.h: Added.
3567         (TestWebKitAPI::TCPServer::port const):
3568         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3569         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3570         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3571         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3572         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3573         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3574         (TestWebKitAPI::respondSlowly):
3575         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3576         (TestWebKitAPI::downloadAtRate):
3577         (TestWebKitAPI::TEST):
3578
3579 2019-03-18  Saam Barati  <sbarati@apple.com>
3580
3581         Add a plan file for JetStream 2
3582         https://bugs.webkit.org/show_bug.cgi?id=190734
3583
3584         Reviewed by Mark Lam.
3585
3586         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3587
3588 2019-03-18  Chris Dumez  <cdumez@apple.com>
3589
3590         Delay WebProcess launch until a load is triggered in a Web view
3591         https://bugs.webkit.org/show_bug.cgi?id=195758
3592         <rdar://problem/48126013>
3593
3594         Reviewed by Geoff Garen.
3595
3596         Add API test coverage. Also update some existing API tests to not expect
3597         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3598
3599         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3600         (TestWebKitAPI::TEST):
3601         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3602         (TestWebKitAPI::TEST):
3603         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3604         (TEST):
3605         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3606         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3607         (TEST):
3608         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3609         (TEST):
3610         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3611
3612 2019-03-18  Xan Lopez  <xan@igalia.com>
3613
3614         [CMake] Prevent potential warning when determining $architecture
3615         https://bugs.webkit.org/show_bug.cgi?id=195891
3616
3617         Reviewed by Michael Catanzaro.
3618
3619         It's possible for generateBuildSystemForCMakeProject to be called
3620         before determineArchitecture() is ever called. This will make the
3621         first eq check with $architecture to be bogus (and print a
3622         warning). Change that to an eq check with architecture(), which
3623         implicitly calls determineArchitecture() if needed, and change all
3624         the other similar cases in the method in the same way to prevent
3625         future bugs like this one.
3626
3627         * Scripts/webkitdirs.pm:
3628         (generateBuildSystemFromCMakeProject):
3629
3630 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3631
3632         [WPE] Tarballs generated with “make dist” cannot build documentation
3633         https://bugs.webkit.org/show_bug.cgi?id=195885
3634
3635         Reviewed by Carlos Garcia Campos.
3636
3637         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3638
3639 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3640
3641         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3642         https://bugs.webkit.org/show_bug.cgi?id=195883
3643
3644         Reviewed by Carlos Garcia Campos.
3645
3646         * gtkdoc/gtkdoc.py:
3647         (GTKDoc._run_command): When commands fail to run, include the full command line for
3648         the program invocation and the output it has generated on the standard error stream.
3649
3650 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3651
3652         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3653         https://bugs.webkit.org/show_bug.cgi?id=195786
3654
3655         Reviewed by Philippe Normand.
3656
3657         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3658         * wpe/jhbuild.modules: Ditto.
3659
3660 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3661
3662         [ews-build] Don't run clean builds on EWS builders
3663         https://bugs.webkit.org/show_bug.cgi?id=195851
3664
3665         Reviewed by Geoffrey Garen.
3666
3667         * BuildSlaveSupport/ews-build/factories.py:
3668
3669 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3670
3671         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3672         https://bugs.webkit.org/show_bug.cgi?id=195849
3673
3674         Reviewed by Chris Dumez.
3675
3676         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3677
3678         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3679         (runWebsiteDataStoreCustomPaths):
3680
3681 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3682
3683         webkitpy: Upload test results
3684         https://bugs.webkit.org/show_bug.cgi?id=195755
3685         <rdar://problem/48896182>
3686
3687         Reviewed by Aakash Jain.
3688
3689         Establish a new format for uploading results that is not tied to layout tests, apply
3690         that format to webkitpy tests.
3691
3692         * Scripts/webkitpy/common/checkout/scm/git.py:
3693         (Git.native_branch): Return what branch the current checkout is on.
3694         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3695         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3696         * Scripts/webkitpy/common/checkout/scm/svn.py:
3697         (SVN.native_branch): Ditto.
3698         * Scripts/webkitpy/common/system/platforminfo.py:
3699         (PlatformInfo.build_version): Return a build version for Mac.
3700         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3701         (MockPlatformInfo.__init__):
3702         (MockPlatformInfo.build_version):
3703         * Scripts/webkitpy/results: Added.
3704         * Scripts/webkitpy/results/__init__.py: Added.
3705         * Scripts/webkitpy/results/options.py: Added.
3706         (upload_options): OptParse list for upload options.
3707         * Scripts/webkitpy/results/upload.py: Added.
3708         (Upload): Class which enforces the upload format expected by the results server.
3709         (Upload.Expectations):
3710         (Upload.create_configuration):
3711         (Upload.create_commit):
3712         (Upload.create_details):
3713         (Upload.create_run_stats):
3714         (Upload.create_test_result):
3715         (Upload.__init__):
3716         (Upload.Encoder): Encode Upload object as json.
3717         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3718         * Scripts/webkitpy/results/upload_unittest.py: Added.
3719         * Scripts/webkitpy/test/main.py:
3720         (Tester._parse_args): Add upload arguments.
3721         (Tester._run_tests): Allow results to be uploaded.
3722         * Scripts/webkitpy/test/runner.py:
3723         (Runner.__init__): Record which tests were run, rather than just counting them.
3724         (Runner.handle):
3725         * Scripts/webkitpy/test/runner_unittest.py:
3726         (RunnerTest.test_run):
3727         * Scripts/webkitpy/thirdparty/__init__.py:
3728         (AutoinstallImportHook.find_module): Add requests auto-install.
3729         (AutoinstallImportHook._install_requests):
3730         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3731         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3732
3733 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3734
3735         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3736         https://bugs.webkit.org/show_bug.cgi?id=195810
3737
3738         Reviewed by Tim Horton.
3739
3740         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3741         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3742         ending certain layout tests.
3743
3744         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3745         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3746         (-[TestRunnerWKWebView dealloc]):
3747         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3748
3749         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3750         helper method when destroying the web view, and when resetting state between tests.
3751
3752         * WebKitTestRunner/ios/TestControllerIOS.mm:
3753         (WTR::TestController::platformResetStateToConsistentValues):
3754
3755         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3756
3757 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3758
3759         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3760         https://bugs.webkit.org/show_bug.cgi?id=190350
3761         <rdar://problem/45089503>
3762
3763         Reviewed by Geoffrey Garen.
3764
3765         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3766         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3767         (TEST):
3768         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3769         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3770         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3771         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3772         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3773         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3774         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3775         (runTest):
3776         (createDirectories):
3777         (TEST):
3778         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3779         (TEST):
3780         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3781         (TEST):
3782
3783 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3784
3785         Add support to WebPage for getting the contents as an attributed string.
3786         https://bugs.webkit.org/show_bug.cgi?id=195636
3787         rdar://problem/45055697
3788
3789         Reviewed by Tim Horton.
3790
3791         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3792         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3793
3794 2019-03-15  Chris Dumez  <cdumez@apple.com>
3795
3796         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3797         https://bugs.webkit.org/show_bug.cgi?id=195747
3798
3799         Reviewed by Geoff Garen.
3800
3801         Add API test coverage.
3802
3803         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3804
3805 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3806
3807         Unreviewed, rolling out r242952.
3808
3809         Causing API failures on iOS Simulator
3810
3811         Reverted changeset:
3812
3813         "[PSON] Make sure the WebProcessCache is leverage when
3814         relaunching a process after termination"
3815         https://bugs.webkit.org/show_bug.cgi?id=195747
3816         https://trac.webkit.org/changeset/242952
3817
3818 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3819
3820         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3821         https://bugs.webkit.org/show_bug.cgi?id=195740
3822
3823         Reviewed by Ross Kirsling.
3824
3825         window.open doesn't work for WebKitBrowserWindow because it is not
3826         implemented yet.
3827
3828         1. Implemented createNewPage callback of WKPageUIClient.
3829         2. Changed MainWindow to take a BrowserWindow factory function
3830           instead of BrowserWindowType to be flexible to create
3831           BrowserWindow with extra settings.
3832         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3833           because it is not relevant with MainWindow anymore.
3834
3835         * MiniBrowser/win/Common.cpp:
3836         (parseCommandLine):
3837         * MiniBrowser/win/Common.h:
3838         (CommandLineOptions::CommandLineOptions):
3839         * MiniBrowser/win/MainWindow.cpp:
3840         (MainWindow::MainWindow):
3841         (MainWindow::create):
3842         (MainWindow::init):
3843         (MainWindow::WndProc):
3844         * MiniBrowser/win/MainWindow.h:
3845         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3846         (PrintWebUIDelegate::createWebViewWithRequest):
3847         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3848         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3849         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3850         (WebKitBrowserWindow::updateProxySettings):
3851         (WebKitBrowserWindow::createNewPage):
3852         * MiniBrowser/win/WebKitBrowserWindow.h:
3853         * MiniBrowser/win/WinMain.cpp:
3854         (wWinMain):
3855
3856 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3857
3858         Make it possible to test scrolling tree layer manipulation more easily
3859         https://bugs.webkit.org/show_bug.cgi?id=195780
3860
3861         Reviewed by Tim Horton.
3862         
3863         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3864         cuts off communication of scrolling tree scrolls back to the web process
3865         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3866         allows tests to trigger scrolls which run the scrolling tree layer positioning
3867         logic, but never get another commit from the web process that might mask
3868         scrolling tree bugs.
3869         
3870         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3871         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3872         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3873
3874         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3875         (WTR::UIScriptController::scrollUpdatesDisabled const):
3876         (WTR::UIScriptController::setScrollUpdatesDisabled):
3877         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3878         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3879         (WTR::UIScriptController::scrollUpdatesDisabled const):
3880         (WTR::UIScriptController::setScrollUpdatesDisabled):
3881         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3882         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3883         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3884         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3885         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3886         * WebKitTestRunner/ios/TestControllerIOS.mm:
3887         (WTR::TestController::platformResetStateToConsistentValues):
3888         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3889         (WTR::UIScriptController::scrollUpdatesDisabled const):
3890         (WTR::UIScriptController::setScrollUpdatesDisabled):
3891
3892 2019-03-14  Youenn Fablet  <youenn@apple.com>
3893
3894         Move IDB storage in private browsing mode to NetworkProcess
3895         https://bugs.webkit.org/show_bug.cgi?id=195602
3896
3897         Reviewed by Brady Eidson.
3898
3899         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3900         (TEST):
3901
3902 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3903
3904         [ews-build] Make descriptionDone messages more readable
3905         https://bugs.webkit.org/show_bug.cgi?id=195760
3906
3907         Reviewed by Lucas Forschler.
3908
3909         * BuildSlaveSupport/ews-build/steps.py:
3910         * BuildSlaveSupport/ews-build/steps_unittest.py:
3911
3912 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3913
3914         [ews-build] Generate status-bubble hover-over messages
3915         https://bugs.webkit.org/show_bug.cgi?id=195680
3916
3917         Reviewed by Lucas Forschler.
3918
3919         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3920         (StatusBubble):
3921         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3922         on hover-over.
3923         (StatusBubble._iso_time):
3924         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3925         hover-over message.
3926         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3927
3928 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3929
3930         [ews-app] Gracefully handle the case when state_string is None
3931         https://bugs.webkit.org/show_bug.cgi?id=195753
3932
3933         Reviewed by Lucas Forschler.
3934
3935         * BuildSlaveSupport/ews-app/ews/models/build.py:
3936         * BuildSlaveSupport/ews-app/ews/models/step.py:
3937
3938 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3939
3940         [ews-app] Status bubble display pending for currently running build step
3941         https://bugs.webkit.org/show_bug.cgi?id=195744
3942
3943         Reviewed by Lucas Forschler.
3944
3945         * BuildSlaveSupport/ews-build/events.py:
3946         (Events.stepStarted): If state_string is pending, replace it with step name.
3947
3948 2019-03-14  Chris Dumez  <cdumez@apple.com>
3949
3950         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3951         https://bugs.webkit.org/show_bug.cgi?id=195750
3952
3953         Reviewed by Geoffrey Garen.
3954
3955         Add API test coverage.
3956
3957         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3958         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3959         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3960         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3961
3962 2019-03-14  Chris Dumez  <cdumez@apple.com>
3963
3964         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3965         https://bugs.webkit.org/show_bug.cgi?id=195747
3966
3967         Reviewed by Geoff Garen.
3968
3969         Add API test coverage.
3970
3971         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3972
3973 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3974
3975         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3976         https://bugs.webkit.org/show_bug.cgi?id=195725
3977         <rdar://problem/48545062>
3978
3979         Reviewed by Tim Horton.
3980
3981         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3982         handler is nil.
3983
3984         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3985         (TestWebKitAPI::TEST):
3986
3987 2019-03-13  Sam Weinig  <sam@webkit.org>
3988
3989         Add utility function to allow easy reverse range-based iteration of a container
3990         https://bugs.webkit.org/show_bug.cgi?id=195542
3991
3992         Reviewed by Antti Koivisto.
3993
3994         * TestWebKitAPI/CMakeLists.txt:
3995         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3996         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3997         (TestWebKitAPI::TEST):
3998         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3999
4000 2019-03-13  Chris Dumez  <cdumez@apple.com>
4001
4002         Use a ServiceWorker process per registrable domain
4003         https://bugs.webkit.org/show_bug.cgi?id=195649
4004
4005         Reviewed by Youenn Fablet.
4006
4007         Update API test coverage.
4008
4009         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4010
4011 2019-03-13  Chris Dumez  <cdumez@apple.com>
4012
4013         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
4014         https://bugs.webkit.org/show_bug.cgi?id=195684
4015         <rdar://problem/48294714>
4016
4017         Reviewed by Antti Koivisto.
4018
4019         Add API test coverage.
4020
4021         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4022
4023 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4024
4025         [ews-app] Remove unused patch view
4026         https://bugs.webkit.org/show_bug.cgi?id=195669
4027
4028         Reviewed by Lucas Forschler.
4029
4030         * BuildSlaveSupport/ews-app/ews/urls.py:
4031         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
4032
4033 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4034
4035         [ews-app] Use Buildbot result code variables
4036         https://bugs.webkit.org/show_bug.cgi?id=195668
4037
4038         Reviewed by Alexey Proskuryakov.
4039
4040         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
4041         (Buildbot): Added Buildbot result code variables.
4042         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4043         (StatusBubble._build_bubble): Used Buildbot result code variables.
4044
4045 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
4046
4047         [Flatpak] Expand submodule recursively
4048         https://bugs.webkit.org/show_bug.cgi?id=195672
4049
4050         Building WPE with flatpak was impossible without that as it was raising an exception.
4051         Also update wpebackend-fdo to match what is built in jhbuild
4052
4053         Reviewed by Philippe Normand.
4054
4055         * flatpak/flatpakutils.py:
4056         (expand_submodules_recurse):
4057         (expand_manifest):
4058         * flatpak/org.webkit.WPEModules.yaml:
4059
4060 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4061
4062         [ews-app] status bubble should be hidden for certain builds
4063         https://bugs.webkit.org/show_bug.cgi?id=194597
4064
4065         Reviewed by Dewei Zhu.
4066
4067         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4068         (StatusBubble._build_bubble):
4069         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
4070         because the patch didn't have relevant changes.
4071         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
4072         in production yet.
4073
4074 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
4075
4076         [Win] Fix a slew of simple clang-cl warnings.
4077         https://bugs.webkit.org/show_bug.cgi?id=195652
4078
4079         Reviewed by Don Olmstead.
4080
4081         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4082         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
4083
4084 2019-03-12  Justin Fan  <justin_fan@apple.com>
4085
4086         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
4087         https://bugs.webkit.org/show_bug.cgi?id=195518
4088         <rdar://problem/46322356>
4089
4090         Reviewed by Myles C. Maxfield.
4091
4092         * DumpRenderTree/DerivedSources-input.xcfilelist:
4093         * DumpRenderTree/DerivedSources-output.xcfilelist:
4094
4095 2019-03-12  Commit Queue  <commit-queue@webkit.org>
4096
4097         Unreviewed, rolling out r242825.
4098         https://bugs.webkit.org/show_bug.cgi?id=195648
4099
4100         "Broke webkitpy tests with my change to
4101         lldb_dump_class_layout.py" (Requested by rmorisset on
4102         #webkit).
4103
4104         Reverted changeset:
4105
4106         "Alter Tools/Scripts/dump-class-layout to be able to dump all
4107         classes with suspicious padding"
4108         https://bugs.webkit.org/show_bug.cgi?id=195573
4109         https://trac.webkit.org/changeset/242825
4110
4111 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4112
4113         [ews-build] Show status bubbles while the patch is waiting in queue
4114         https://bugs.webkit.org/show_bug.cgi?id=195618
4115
4116         Reviewed by Lucas Forschler.
4117
4118         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4119         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
4120         enabled in initial deployment.
4121         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
4122         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
4123         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
4124         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
4125         (StatusBubble._build_bubbles_for_patch):
4126
4127 2019-03-12  Robin Morisset  <rmorisset@apple.com>
4128
4129         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
4130         https://bugs.webkit.org/show_bug.cgi?id=195573
4131
4132         Reviewed by Simon Fraser.
4133
4134         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
4135
4136         * Scripts/dump-class-layout:
4137         (main):
4138         * lldb/lldb_dump_class_layout.py:
4139         (ClassLayout.__init__):
4140         (ClassLayout._compute_padding_recursive):
4141         (LLDBDebuggerInstance.dump_layout_for_classname):
4142         (LLDBDebuggerInstance):
4143         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
4144         (LLDBDebuggerInstance.layout_for_classname): Deleted.
4145
4146 2019-03-12  Chris Dumez  <cdumez@apple.com>
4147
4148         Device Orientation access permission should be denied unless explicitly granted by the client
4149         https://bugs.webkit.org/show_bug.cgi?id=195625
4150
4151         Reviewed by Youenn Fablet.
4152
4153         add API test coverage.
4154
4155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4156         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
4157         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
4158         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
4159         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4160         (runDeviceOrientationTest):
4161         (TEST):
4162         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4163         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4164
4165 2019-03-12  Jer Noble  <jer.noble@apple.com>
4166
4167         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
4168         https://bugs.webkit.org/show_bug.cgi?id=195137
4169         <rdar://problem/48810307>
4170
4171         Reviewed by Eric Carlson.
4172
4173         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
4174         (TestWebKitAPI::TEST):
4175
4176 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4177
4178         [ews-build] Change urls from uat to production
4179         https://bugs.webkit.org/show_bug.cgi?id=195566
4180
4181         Reviewed by Lucas Forschler.
4182
4183         * BuildSlaveSupport/ews-app/ews/config.py:
4184         * BuildSlaveSupport/ews-build/events.py:
4185         * BuildSlaveSupport/ews-build/steps.py:
4186
4187 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4188
4189         [ews-build] change max_builds for local-worker to 1
4190         https://bugs.webkit.org/show_bug.cgi?id=195568
4191
4192         Reviewed by Lucas Forschler.
4193
4194         * BuildSlaveSupport/ews-build/loadConfig.py:
4195
4196 2019-03-12  Tim Horton  <timothy_horton@apple.com>
4197
4198         Fix the build
4199
4200         * TestRunnerShared/spi/PencilKitTestSPI.h:
4201         * TestWebKitAPI/ios/PencilKitTestSPI.h:
4202
4203 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
4204
4205         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
4206         https://bugs.webkit.org/show_bug.cgi?id=194131
4207
4208         Reviewed by Michael Catanzaro.
4209
4210         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4211         (uriChanged):
4212         (testUnfinishedSubresourceLoad):
4213         (serverCallback):
4214         (beforeAll):
4215
4216 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4217
4218         WTF::Expected should use std::addressof instead of operator&
4219         https://bugs.webkit.org/show_bug.cgi?id=195604
4220
4221         Reviewed by Myles Maxfield.
4222
4223         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4224         (TestWebKitAPI::Unique::Unique):
4225         (TestWebKitAPI::Unique::operator&):
4226         (TestWebKitAPI::TEST):
4227
4228 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
4229
4230         Add Optional to Forward.h.
4231         https://bugs.webkit.org/show_bug.cgi?id=195586
4232
4233         Reviewed by Darin Adler.
4234
4235         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
4236         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
4237         Remove unnecessary includes from headers.
4238
4239 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
4240
4241         Add testing API to hit-test and scroll overflow scrollers
4242         https://bugs.webkit.org/show_bug.cgi?id=195278
4243
4244         Reviewed by Antti Koivisto.
4245         
4246         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
4247         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
4248         
4249         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
4250
4251         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4252         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4253         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4254         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4255         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4256         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4257         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4258         (WTR::enclosingScrollViewIncludingSelf):
4259         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4260
4261 2019-03-11  Tim Horton  <timothy_horton@apple.com>
4262
4263         API test WebKit.RequestTextInputContext fails on iOS
4264         https://bugs.webkit.org/show_bug.cgi?id=195585
4265
4266         Reviewed by Wenson Hsieh and Simon Fraser.
4267
4268         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4269         (applyStyle):
4270         (TEST):
4271         Add a viewport, so that the coordinates match up on iOS.
4272         Scroll by moving the UIScrollView's contentOffset.
4273
4274 2019-03-11  Chris Dumez  <cdumez@apple.com>
4275
4276         Assert in WebPageProxy::suspendCurrentPageIfPossible()
4277         https://bugs.webkit.org/show_bug.cgi?id=195506
4278         <rdar://problem/48733477>
4279
4280         Reviewed by Alex Christensen.
4281
4282         Add API test coverage.
4283
4284         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4285
4286 2019-03-11  Shawn Roberts  <sroberts@apple.com>
4287
4288         Adding myself to contributors.json
4289
4290         Unreviewed, addming myself to contributors.json .
4291
4292         * Scripts/webkitpy/common/config/contributors.json:
4293
4294 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4295
4296         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
4297         https://bugs.webkit.org/show_bug.cgi?id=195511
4298         <rdar://problem/44873269>
4299
4300         Reviewed by Darin Adler.
4301
4302         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
4303         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
4304         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
4305         (TEST_F):
4306
4307 2019-03-11  Chris Dumez  <cdumez@apple.com>
4308
4309         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
4310         https://bugs.webkit.org/show_bug.cgi?id=195561
4311
4312         Reviewed by Youenn Fablet.
4313
4314         Make sure the JS in the test requests for permission to receive device orientation events.
4315
4316         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4317
4318 2019-03-11  Youenn Fablet  <youenn@apple.com>
4319
4320         Allow storage quota increase by default in WTR
4321         https://bugs.webkit.org/show_bug.cgi?id=195541
4322