ews-build should clearly indicate flaky test failures
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2
3         ews-build should clearly indicate flaky test failures
4         https://bugs.webkit.org/show_bug.cgi?id=196947
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-build/steps.py:
9         (AnalyzeAPITestsResults.analyzeResults):
10
11 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
12
13         InjectedBundle parameters often need initialization function called before unarchiving
14         https://bugs.webkit.org/show_bug.cgi?id=189709
15         <rdar://problem/44573653>
16
17         Reviewed by Ryosuke Niwa.
18
19         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
20         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
21
22 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
23
24         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
25         https://bugs.webkit.org/show_bug.cgi?id=196681
26
27         Reviewed by Darin Adler.
28
29         Added tests.
30
31         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
32         (WTF_HashSet.RemoveIf):
33         (WTF_HashSet.RemoveIfShrinkToBestSize):
34
35 2019-04-15  John Wilander  <wilander@apple.com>
36
37         Send delayed Ad Click Attribution conversion requests to the click source
38         https://bugs.webkit.org/show_bug.cgi?id=196838
39         <rdar://problem/47650157>
40
41         Reviewed by Chris Dumez and Youenn Fablet.
42
43         This patch adds test infrastructure to override the default behavior in
44         WebKit::NetworkAdClickAttribution.
45
46         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
47         (TestWebKitAPI::TEST):
48         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
49         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
50         (WTR::TestRunner::dumpAdClickAttribution):
51         (WTR::TestRunner::clearAdClickAttribution):
52         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
53         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
54         * WebKitTestRunner/InjectedBundle/TestRunner.h:
55         * WebKitTestRunner/TestController.cpp:
56         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
57         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
58         * WebKitTestRunner/TestController.h:
59         * WebKitTestRunner/TestInvocation.cpp:
60         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
61
62 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
63
64         [ews-app] status-bubble should display position in queue
65         https://bugs.webkit.org/show_bug.cgi?id=196607
66
67         Reviewed by Lucas Forschler.
68
69         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
70         (StatusBubble._build_bubble):
71         (StatusBubble._queue_position): Method to calculate patch's position in queue.
72
73 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
74
75         [ews-build] Do not run clean build by default on EWS builders
76         https://bugs.webkit.org/show_bug.cgi?id=196897
77
78         Reviewed by Lucas Forschler.
79
80         * BuildSlaveSupport/ews-build/steps.py:
81         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
82         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
83         untracked directories like WebKitBuild).
84         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
85         untracked files/directories (like WebKitBuild).
86
87 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
88
89         TestRunner::notifyDone() should be safely reentrant
90         https://bugs.webkit.org/show_bug.cgi?id=196898
91
92         Reviewed by Darin Adler.
93
94         It is currently possible that TestRunner::notifyDone() will call itself, since
95         notifyDone() will force a repaint, which can start executing JavaScript, which
96         may call notifyDone() again. This can lead to test failures and flakiness.
97         Fix this by setting the m_waitToDump flag before calling the dump() method.
98
99         * DumpRenderTree/mac/TestRunnerMac.mm:
100         (TestRunner::notifyDone):
101         (TestRunner::forceImmediateCompletion):
102         * DumpRenderTree/win/TestRunnerWin.cpp:
103         (TestRunner::notifyDone):
104         (TestRunner::forceImmediateCompletion):
105
106 2019-04-15  Philippe Normand  <pnormand@igalia.com>
107
108         [GTK][WPE] Add enable-media websetting
109         https://bugs.webkit.org/show_bug.cgi?id=196863
110
111         Reviewed by Michael Catanzaro.
112
113         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
114         (testWebKitSettings): Add test for the enable-media web-setting.
115
116 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
117
118         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
119         https://bugs.webkit.org/show_bug.cgi?id=196905
120         <rdar://problem/49886096>
121
122         Reviewed by Tim Horton.
123
124         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
125         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
126         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
127         delay timer, we end up with this sequence of events in the problematic (failure) case:
128
129         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
130             ...IPC from UI to web process...
131         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
132             ...IPC from web to UI process...
133         (c) [UI]    Invoke completion handler for script #1
134         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
135             ...IPC from UI to web process...
136         (e) [Web]   Evaluate script #2 in the web process
137         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
138
139         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
140         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
141         #2 is run in step (e).
142
143         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
144         the UI process by waiting on a script message posted by the web process, after attachment updates are
145         dispatched.
146
147         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
148         (TestWebKitAPI::TEST):
149
150 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
151
152         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
153         https://bugs.webkit.org/show_bug.cgi?id=196909
154
155         Reviewed by Wenson Hsieh.
156
157         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
158         (TestWebKitAPI::TEST):
159
160 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
161
162         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
163         https://bugs.webkit.org/show_bug.cgi?id=196880
164
165         Reviewed by Yusuke Suzuki.
166
167         Add a new function for bytecode cache tests that does not forceDiskCache
168         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
169         test added in this patch, since the code is invalid and therefore won't be
170         cached. It should also be useful for tests that evaluate dynamically
171         generated code.
172
173         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
174         * Scripts/run-jsc-stress-tests:
175
176 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
177
178         Update AudioSession route sharing policy
179         https://bugs.webkit.org/show_bug.cgi?id=196776
180         <rdar://problem/46501611>
181
182         Reviewed by Jer Noble.
183
184         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
185         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
186         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
187         (TestWebKitAPI::TEST):
188
189 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
190
191         [iOS] Software keyboard is shown too frequently on some websites
192         https://bugs.webkit.org/show_bug.cgi?id=195856
193         <rdar://problem/49191395>
194
195         Reviewed by Darin Adler.
196
197         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
198
199         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
200         (WTR::UIScriptController::setHardwareKeyboardAttached):
201         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
202         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
203         (WTR::UIScriptController::setHardwareKeyboardAttached):
204         * TestRunnerShared/UIScriptContext/UIScriptController.h:
205         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
206
207         Additionally link against GraphicsServices in WebKitTestRunner.
208
209         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
210         (WTR::TestController::platformResetStateToConsistentValues):
211         (WTR::UIScriptController::setHardwareKeyboardAttached):
212
213 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
214
215         [GTK][WPE] Fix pacman install-dependencies packages
216         https://bugs.webkit.org/show_bug.cgi?id=196817
217
218         Reviewed by Žan Doberšek.
219         
220         python3-setuptools is called python-setuptools
221         ruby-highline is only available on AUR
222         libv4l-devel is incorporated in v4l-utils
223
224         * gtk/install-dependencies:
225         * wpe/install-dependencies:
226
227 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
228
229         [GTK] REGRESSION(r243860): Many tests failing
230         https://bugs.webkit.org/show_bug.cgi?id=196791
231
232         Reviewed by Joanmarie Diggs.
233
234         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
235         multiple documents and check that accessibility hierarchy is updated after a navigation.
236
237         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
238         (loadChangedCallback):
239         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
240         (AccessibilityTest::AccessibilityTest):
241         (AccessibilityTest::~AccessibilityTest):
242         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
243         (AccessibilityTest::findTestServerApplication):
244         (AccessibilityTest::findDocumentWeb):
245         (AccessibilityTest::findRootObject):
246         (AccessibilityTest::waitUntilChildrenRemoved):
247         (AccessibilityTest::ensureProxy):
248         (testAtspiBasicHierarchy):
249         (beforeAll):
250         (afterAll):
251
252 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
253
254         [ews-build] Handle bug titles with unicode characters
255         https://bugs.webkit.org/show_bug.cgi?id=196802
256
257         Reviewed by Dewei Zhu.
258
259         * BuildSlaveSupport/ews-build/steps.py:
260         (ValidatePatch._is_bug_closed):
261
262 2019-04-11  Michael Saboff  <msaboff@apple.com>
263
264         Improve the Inline Cache Stats code
265         https://bugs.webkit.org/show_bug.cgi?id=196836
266
267         Reviewed by Saam Barati.
268
269         Added a new script to consolidate and arrange the output of --useICStats option.
270
271         This script merges the output from every group into one large table and sorts it from most common to
272         least common.  It also counts the slow path GetById and PutById variants and then calculates the
273         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
274         Put together, this is useful to see what property accesses are not getting cached.
275
276         * Scripts/ic-stats.py: Added.
277         (ICStats):
278         (ICStats.__init__):
279         (ICStats.parse):
280         (ICStats.dumpStats):
281         (usage):
282
283 2019-04-10  Alex Christensen  <achristensen@webkit.org>
284
285         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
286         https://bugs.webkit.org/show_bug.cgi?id=196809
287         <rdar://49800762>
288
289         Reviewed by Brady Eidson.
290
291         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
292         (TEST):
293
294 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
295
296         requestAnimationFrame should execute before the next frame
297         https://bugs.webkit.org/show_bug.cgi?id=177484
298
299         Reviewed by Simon Fraser.
300
301         Add trace points for the page RenderingUpdate.
302
303         * Tracing/SystemTracePoints.plist:
304
305 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
306
307         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
308         https://bugs.webkit.org/show_bug.cgi?id=196760
309
310         Reviewed by Don Olmstead.
311
312         vswhere.exe has been bundled since Visual Studio 2017 version
313         15.2. We shouldn't download vswhere.exe.
314
315         * Scripts/build-jsc: Do not call update-vswhere.py.
316         * Scripts/build-webkit: Ditto.
317         * Scripts/update-vswhere.py: Removed.
318         * Scripts/webkitdirs.pm:
319         (requireModulesForVSWhere): Deleted.
320         (pickCurrentVisualStudioInstallation): Deleted.
321         (visualStudioInstallDirVSWhere): Return the latest installed VS
322         installation path by using the bundled vswhere.exe.
323         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
324         (visualStudioInstallDirFallback): Removed.
325
326 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
327
328         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
329         https://bugs.webkit.org/show_bug.cgi?id=196780
330
331         Reviewed by Alexey Proskuryakov.
332
333         * BuildSlaveSupport/ews-build/steps.py:
334         * BuildSlaveSupport/ews-build/steps_unittest.py:
335
336 2019-04-10  Alex Christensen  <achristensen@webkit.org>
337
338         Add SPI WKNavigationResponse._downloadAttribute
339         https://bugs.webkit.org/show_bug.cgi?id=196755
340         <rdar://49587365>
341
342         Reviewed by Brady Eidson.
343
344         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
345         (-[NavigationResponseTestDelegate navigationResponse]):
346         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
347         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
348         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
349         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
350         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
351         (readRequest):
352         (writeResponse):
353         (TEST):
354
355 2019-04-10  Tim Horton  <timothy_horton@apple.com>
356
357         Add modern API for overriding the page's specified viewport configuration
358         https://bugs.webkit.org/show_bug.cgi?id=167734
359         <rdar://problem/30331795>
360
361         Reviewed by Simon Fraser.
362
363         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
364         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
365
366 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
367
368         Add support for incremental bytecode cache updates
369         https://bugs.webkit.org/show_bug.cgi?id=195000
370
371         Reviewed by Filip Pizlo.
372
373         Exit when the initial run to generate bytecode fails.
374
375         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
376
377 2019-04-10  Alex Christensen  <achristensen@webkit.org>
378
379         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
380         https://bugs.webkit.org/show_bug.cgi?id=196744
381         <rdar://49415309>
382
383         Reviewed by Chris Dumez.
384
385         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
386         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
387
388 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
389
390         Add a way to opt into modern compatibility mode in layout tests
391         https://bugs.webkit.org/show_bug.cgi?id=196770
392         <rdar://problem/49777550>
393
394         Reviewed by Antoine Quint.
395
396         Add a new test option to enable modern compatibility mode in layout tests.
397
398         * WebKitTestRunner/TestController.cpp:
399         (WTR::updateTestOptionsFromTestHeader):
400         * WebKitTestRunner/TestController.h:
401         * WebKitTestRunner/TestOptions.h:
402         (WTR::TestOptions::hasSameInitializationOptions const):
403         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
404         (WTR::TestController::platformCreateWebView):
405         (WTR::TestController::enableModernCompatibilityMode):
406
407 2019-04-10  Andy Estes  <aestes@apple.com>
408
409         Try to fix the 32-bit watchOS build.
410
411         * TestWebKitAPI/cocoa/TestWKWebView.mm:
412         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
413
414 2019-04-10  Antoine Quint  <graouts@apple.com>
415
416         Enable Pointer Events on watchOS
417         https://bugs.webkit.org/show_bug.cgi?id=196771
418         <rdar://problem/49040909>
419
420         Reviewed by Dean Jackson.
421
422         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
423
424 2019-04-10  Philippe Normand  <pnormand@igalia.com>
425
426         Unreviewed. Fix WPE accessibility tests after r244059.
427
428         We are failing to load the injected bundle due to undefined symbol
429         AccessibilityUIElement::replaceTextInRange().
430
431         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
432         (WTR::AccessibilityUIElement::replaceTextInRange):
433
434 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
435
436         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
437         https://bugs.webkit.org/show_bug.cgi?id=196727
438
439         Reviewed by Fujii Hironori.
440
441         * MiniBrowser/win/WebKitBrowserWindow.cpp:
442         (WebKitBrowserWindow::create):
443
444 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
445
446         [ews-build] Add unit tests for PrintConfiguration
447         https://bugs.webkit.org/show_bug.cgi?id=196752
448
449         Reviewed by Dewei Zhu.
450
451         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
452
453 2019-04-09  Keith Rollin  <krollin@apple.com>
454
455         Unreviewed build maintenance -- update .xcfilelists.
456
457         * DumpRenderTree/DerivedSources-input.xcfilelist:
458         * DumpRenderTree/DerivedSources-output.xcfilelist:
459
460 2019-04-09  Zalan Bujtas  <zalan@apple.com>
461
462         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
463         https://bugs.webkit.org/show_bug.cgi?id=196743
464         <rdar://problem/43897551>
465
466         Reviewed by Tim Horton.
467
468         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
469         (TEST):
470
471 2019-04-09  Youenn Fablet  <youenn@apple.com>
472
473         Close service worker database on network process suspension
474         https://bugs.webkit.org/show_bug.cgi?id=196623
475         <rdar://problem/48930869>
476
477         Reviewed by Alex Christensen.
478
479         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
480
481 2019-04-09  Daniel Bates  <dabates@apple.com>
482
483         [iPad] Should open popover when the spacebar is pressed
484         https://bugs.webkit.org/show_bug.cgi?id=196360
485         <rdar://problem/49389129>
486
487         Reviewed by Brent Fulgham.
488
489         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
490
491         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
492         (WTR::UIScriptController::isShowingPopover const): Added.
493         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
494         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
495         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
496         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
497         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
498         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
499         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
500         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
501         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
502         (WTR::UIScriptController::isShowingPopover const): Added.
503         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
504         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
505         * TestRunnerShared/UIScriptContext/UIScriptController.h:
506         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
507         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
508         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
509         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
510         (-[TestRunnerWKWebView _willPresentPopover]): Added.
511         (-[TestRunnerWKWebView _didDismissPopover]): Added.
512         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
513         (WTR::UIScriptController::isShowingPopover const): Added.
514         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
515         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
516
517 2019-04-09  Alex Christensen  <achristensen@webkit.org>
518
519         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
520         https://bugs.webkit.org/show_bug.cgi?id=196665
521         <rdar://45115669>
522
523         Reviewed by Geoff Garen.
524
525         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
526         (goBack):
527         (+[SimpleLookupContext sharedLookupContext]):
528         (-[SimpleLookupContext lookUpURL:completionHandler:]):
529         (TEST):
530         (+[Simple3LookupContext sharedLookupContext]): Deleted.
531         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
532
533 2019-04-09  John Wilander  <wilander@apple.com>
534
535         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
536         https://bugs.webkit.org/show_bug.cgi?id=196558
537         <rdar://problem/47650245>
538
539         Reviewed by Youenn Fablet.
540
541         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
542         (TestWebKitAPI::TEST):
543             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
544
545 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
546
547         [CMake] Apple builds should use ICU_INCLUDE_DIRS
548         https://bugs.webkit.org/show_bug.cgi?id=196720
549
550         Reviewed by Konstantin Tokarev.
551
552         * TestWebKitAPI/PlatformMac.cmake:
553
554 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
555
556         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
557         https://bugs.webkit.org/show_bug.cgi?id=196694
558         <rdar://problem/48388734>
559
560         Rubber-stamped by Aakash Jain.
561
562         * Scripts/webkitpy/port/image_diff.py:
563         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
564         * Scripts/webkitpy/port/server_process.py:
565         (ServerProcess.has_available_stdout): Check if stdout has data in it.
566         (ServerProcess._wait_for_data_and_update_buffers_using_select):
567         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
568         * Scripts/webkitpy/port/server_process_mock.py:
569         (MockServerProcess.has_available_stdout):
570         * Scripts/webkitpy/port/server_process_unittest.py:
571         (TestServerProcess.serial_test_basic):
572
573 2019-04-09  Jer Noble  <jer.noble@apple.com>
574
575         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
576         https://bugs.webkit.org/show_bug.cgi?id=196097
577
578         Reviewed by Eric Carlson.
579
580         Drive-by bug fix: allow tests to play audio without a user gesture by default.
581
582         * DumpRenderTree/mac/DumpRenderTree.mm:
583         (resetWebPreferencesToConsistentValues):
584         * WebKitTestRunner/TestController.cpp:
585         (WTR::TestController::resetPreferencesToConsistentValues):
586
587 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
588
589         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
590         https://bugs.webkit.org/show_bug.cgi?id=196690
591
592         Reviewed by Michael Catanzaro.
593
594         * QueueStatusServer/config/queues.py:
595         * Scripts/webkitpy/common/config/ews.json:
596         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
597         (test_ews_name):
598
599 2019-04-09  Chris Dumez  <cdumez@apple.com>
600
601         Loads using loadHTMLString() cause flashing when process-swapping
602         https://bugs.webkit.org/show_bug.cgi?id=196714
603         <rdar://problem/49637354>
604
605         Reviewed by Antti Koivisto.
606
607         Add API test coverage.
608
609         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
610
611 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
612
613         Unreviewed. Fix ATK accessibility tests after r244059.
614
615         We are failing to load the injected bundle due to undefined symbol
616         AccessibilityUIElement::replaceTextInRange().
617
618         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
619         (WTR::AccessibilityUIElement::replaceTextInRange):
620
621 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
622
623         AX: Support API: accessibilityReplaceRange:withText
624         https://bugs.webkit.org/show_bug.cgi?id=196636
625
626         Unreviewed build fix for Windows port.
627
628         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
629         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
630
631 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
632
633         [CMake][WinCairo] Separate copied headers into different directories
634         https://bugs.webkit.org/show_bug.cgi?id=196655
635
636         Reviewed by Michael Catanzaro.
637
638         * DumpRenderTree/CMakeLists.txt:
639         * MiniBrowser/win/CMakeLists.txt:
640         * TestWebKitAPI/CMakeLists.txt:
641         * TestWebKitAPI/PlatformWin.cmake:
642
643 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
644
645         Log stack-trace for run-webkit-tests when interrupted
646         https://bugs.webkit.org/show_bug.cgi?id=176393
647         <rdar://problem/34262310>
648
649         Reviewed by Lucas Forschler.
650
651         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
652         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
653         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
654         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
655         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
656         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
657         (main): Set handlers to log stack trace on interruption.
658
659 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
660
661         AX: Support API: accessibilityReplaceRange:withText
662         https://bugs.webkit.org/show_bug.cgi?id=196636
663
664         Unreviewed build fix for Windows port.
665
666         * DumpRenderTree/AccessibilityUIElement.cpp:
667         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
668
669 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
670
671         [ews-build] Scripts using Buildbot API have CORS error
672         https://bugs.webkit.org/show_bug.cgi?id=196709
673
674         Reviewed by Alexey Proskuryakov.
675
676         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
677
678 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
679
680         AX: Support API: accessibilityReplaceRange:withText
681         https://bugs.webkit.org/show_bug.cgi?id=196636
682
683         Reviewed by Daniel Bates.
684
685         * DumpRenderTree/AccessibilityUIElement.cpp:
686         (replaceTextInRangeCallback):
687         (AccessibilityUIElement::replaceTextInRange):
688         (AccessibilityUIElement::getJSClass):
689         * DumpRenderTree/AccessibilityUIElement.h:
690         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
691         (AccessibilityUIElement::replaceTextInRange):
692         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
693         (AccessibilityUIElement::replaceTextInRange):
694         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
695         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
696         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
697         (WTR::AccessibilityUIElement::replaceTextInRange):
698         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
699         (WTR::AccessibilityUIElement::replaceTextInRange):
700
701 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
702
703         [iOS] Do not allow starting selection drags when selection views are not visible
704         https://bugs.webkit.org/show_bug.cgi?id=196686
705         <rdar://problem/49399192>
706
707         Reviewed by Tim Horton.
708
709         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
710         also add some new API tests to cover scenarios where the web view is not first responder.
711
712         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
713         (TestWebKitAPI::TEST):
714         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
715
716         Add a switch to optionally make the web view first responder when starting the simulated drag.
717
718         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
719         (-[DragAndDropSimulator initWithWebView:]):
720         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
721
722 2019-04-08  Justin Fan  <justin_fan@apple.com>
723
724         [Web GPU] Fix Web GPU experimental feature on iOS
725         https://bugs.webkit.org/show_bug.cgi?id=196632
726
727         Reviewed by Myles C. Maxfield.
728
729         Properly make Web GPU available on iOS 11+.
730
731         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
732
733 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
734
735         [ews-build] Do not upload archive when Compile Fails
736         https://bugs.webkit.org/show_bug.cgi?id=196674
737
738         Reviewed by Alexey Proskuryakov.
739
740         * BuildSlaveSupport/ews-build/factories.py:
741         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
742         * BuildSlaveSupport/ews-build/steps.py:
743         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
744         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
745         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
746
747 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
748
749         Enable DFG on MIPS
750         https://bugs.webkit.org/show_bug.cgi?id=196689
751
752         Reviewed by Žan Doberšek.
753
754         Since the bytecode change, we enabled the baseline JIT on mips in
755         r240432, but DFG is still missing. With this change, all tests are
756         passing on a ci20 board.
757
758         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
759
760 2019-04-08  Philippe Normand  <pnormand@igalia.com>
761
762         [Flatpak] Second run update-webkitwpe-flatpak fails
763         https://bugs.webkit.org/show_bug.cgi?id=192702
764
765         Reviewed by Carlos Garcia Campos.
766
767         * flatpak/flatpakutils.py:
768         (FlatpakObject.flatpak): Fix typo.
769         (FlatpakPackage.install): When installing, also update to the configured remote commit.
770         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
771
772 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
773
774         [GTK][WPE] outlook.live.com displays old-fashioned UI
775         https://bugs.webkit.org/show_bug.cgi?id=196642
776
777         Reviewed by Carlos Garcia Campos.
778
779         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
780         (TestWebKitAPI::TEST): New Mac platform quirk test.
781
782 2019-04-07  Commit Queue  <commit-queue@webkit.org>
783
784         Unreviewed, rolling out r243956.
785         https://bugs.webkit.org/show_bug.cgi?id=196688
786
787         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
788         by aakashjain on #webkit).
789
790         Reverted changeset:
791
792         "Clicking "Go Back" from a safe browsing warning from an
793         iframe should navigate the WKWebView back to the previous
794         page"
795         https://bugs.webkit.org/show_bug.cgi?id=196665
796         https://trac.webkit.org/changeset/243956
797
798 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
799
800         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
801         https://bugs.webkit.org/show_bug.cgi?id=196669
802
803         Reviewed by Geoffrey Garen.
804
805         Added three new unit tests for WeakHashSet.
806
807         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
808         (WTF_WeakPtr.WeakHashSetConstObjects):
809         (WTF_WeakPtr.WeakHashSetComputesEmpty):
810         (WTF_WeakPtr.WeakHashSetComputeSize):
811
812 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
813
814         Hide next and previous form control buttons when WKWebView is editable
815         https://bugs.webkit.org/show_bug.cgi?id=196672
816         <rdar://problem/35625321>
817
818         Reviewed by Tim Horton.
819
820         Add a new API test.
821
822         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
823         (-[TestWKWebView lastTrailingBarButtonGroup]):
824         (TestWebKitAPI::TEST):
825         * TestWebKitAPI/ios/UIKitSPI.h:
826
827 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
828
829         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
830         https://bugs.webkit.org/show_bug.cgi?id=196077
831         <rdar://problem/49108202>
832
833         Reviewed by Chris Dumez.
834
835         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
836         on new web view.
837
838         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
839
840 2019-04-05  Saam Barati  <sbarati@apple.com>
841
842         Make compare-results understand MotionMark
843         https://bugs.webkit.org/show_bug.cgi?id=196666
844
845         Reviewed by Yusuke Suzuki.
846
847         * Scripts/compare-results:
848         (PLT5Results):
849         (detectMotionMark):
850         (detectMotionMark1_1):
851         (motionMarkResults):
852         (motionMark1_1Results):
853         (detectBenchmark):
854         (biggerIsBetter):
855         (main):
856
857 2019-04-05  Alex Christensen  <achristensen@webkit.org>
858
859         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
860         https://bugs.webkit.org/show_bug.cgi?id=196665
861         <rdar://45115669>
862
863         Reviewed by Geoff Garen.
864
865         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
866         (goBack):
867         (+[SimpleLookupContext sharedLookupContext]):
868         (-[SimpleLookupContext lookUpURL:completionHandler:]):
869         (TEST):
870         (+[Simple3LookupContext sharedLookupContext]): Deleted.
871         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
872
873 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
874
875         [ews-build] Add configuration and architecture for windows builders
876         https://bugs.webkit.org/show_bug.cgi?id=196660
877
878         Reviewed by Lucas Forschler.
879
880         * BuildSlaveSupport/ews-build/config.json:
881
882 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
883
884         webkitpy: Don't run subsequent rounds if interrupted
885         https://bugs.webkit.org/show_bug.cgi?id=196646
886
887         Reviewed by Aakash Jain.
888
889         * Scripts/webkitpy/layout_tests/controllers/manager.py:
890         (Manager.run): Bail out if interrupted.
891
892 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
893
894         Test sessionStorage in PSON private browsing mode
895         https://bugs.webkit.org/show_bug.cgi?id=196561
896
897         Reviewed by Alex Christensen.
898
899         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
900
901 2019-04-05  Commit Queue  <commit-queue@webkit.org>
902
903         Unreviewed, rolling out r243833.
904         https://bugs.webkit.org/show_bug.cgi?id=196645
905
906         This change breaks build of WPE and GTK ports (Requested by
907         annulen on #webkit).
908
909         Reverted changeset:
910
911         "[CMake][WTF] Mirror XCode header directories"
912         https://bugs.webkit.org/show_bug.cgi?id=191662
913         https://trac.webkit.org/changeset/243833
914
915 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
916
917         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
918         https://bugs.webkit.org/show_bug.cgi?id=196635
919
920         Reviewed by Antti Koivisto.
921         
922         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
923         for a test to enable async frame scrolling via:
924             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
925         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
926         
927         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
928
929         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
930         (WTR::InjectedBundle::beginTesting):
931         * WebKitTestRunner/TestController.cpp:
932         (WTR::TestController::resetPreferencesToConsistentValues):
933
934 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
935
936         Use a correct LC_RPATH when building with ASan
937         https://bugs.webkit.org/show_bug.cgi?id=196576
938
939         Reviewed by David Kilzer.
940
941         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
942         so that ../Frameworks is checked. This is simpler and more reliable than updating
943         each SPC service xcconfig.
944
945 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
946
947         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
948         https://bugs.webkit.org/show_bug.cgi?id=196629
949
950         Reviewed by Lucas Forschler.
951
952         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
953
954 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
955
956         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
957         https://bugs.webkit.org/show_bug.cgi?id=196618
958
959         Reviewed by Lucas Forschler.
960
961         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
962         (StatusBubble): Added QUEUE_TRIGGERS.
963         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
964         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
965         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
966         its parent(builder).
967
968 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
969
970         [ews-app] Status-bubble steps are sometimes displayed in reverse order
971         https://bugs.webkit.org/show_bug.cgi?id=196625
972
973         Reviewed by Lucas Forschler.
974
975         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
976         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
977
978 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
979
980         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
981         https://bugs.webkit.org/show_bug.cgi?id=196630
982
983         Reviewed by Wenson Hsieh.
984
985         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
986
987 2019-04-04  Youenn Fablet  <youenn@apple.com>
988
989         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
990         https://bugs.webkit.org/show_bug.cgi?id=196543
991
992         Reviewed by Alex Christensen.
993
994         * WebKitTestRunner/TestController.cpp:
995         (WTR::TestController::generatePageConfiguration):
996
997 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
998
999         [ews-app] Status bubble should not display skipped buildbot steps
1000         https://bugs.webkit.org/show_bug.cgi?id=196584
1001
1002         Reviewed by Lucas Forschler.
1003
1004         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1005
1006 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1007
1008         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1009         https://bugs.webkit.org/show_bug.cgi?id=196620
1010
1011         Reviewed by Lucas Forschler.
1012
1013         * BuildSlaveSupport/ews-app/ews/config.py:
1014
1015 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1016
1017         [Win] DumpRenderTreeWatchDog.py is not checked into source
1018         https://bugs.webkit.org/show_bug.cgi?id=196567
1019         <rdar://problem/49525901>
1020
1021         Reviewed by Lucas Forschler.
1022
1023         This script is used on Win EWS bots to terminate hanging DRT processes.
1024
1025         * EWSTools/dumprendertreewatchdog.py: Added.
1026
1027 2019-04-04  Chris Dumez  <cdumez@apple.com>
1028
1029         Unreviewed, roll out r243858 which made tests time out.
1030
1031         Disable new API tests on Windows instead.
1032
1033         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1034         (TestWebKitAPI::TEST):
1035
1036 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1037
1038         [ATK] Cleanup WebPageAccessibilityObjectAtk
1039         https://bugs.webkit.org/show_bug.cgi?id=196537
1040
1041         Reviewed by Michael Catanzaro.
1042
1043         Also consider files under atk directories as exceptions for GObject conventions.
1044
1045         * Scripts/webkitpy/style/checkers/cpp.py:
1046         (check_identifier_name_in_declaration):
1047
1048 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1049
1050         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1051         https://bugs.webkit.org/show_bug.cgi?id=196588
1052         <rdar://problem/49365787>
1053
1054         Unreviewed build fix for Windows port.
1055
1056         error C3861: 'kill': identifier not found
1057
1058         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1059         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1060
1061 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1062
1063         [ews-build] Cancel build and similar operations should have authentication
1064         https://bugs.webkit.org/show_bug.cgi?id=196520
1065
1066         Reviewed by Dewei Zhu.
1067
1068         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1069         environment variables.
1070
1071 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1072
1073         [ews-build] Do not trigger queues which are not in production yet
1074         https://bugs.webkit.org/show_bug.cgi?id=196581
1075
1076         Reviewed by Dewei Zhu.
1077
1078         * BuildSlaveSupport/ews-build/config.json:
1079
1080 2019-04-03  Chris Dumez  <cdumez@apple.com>
1081
1082         Unreviewed, fix typo in the name of API test added in r243848.
1083
1084         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1085         (TestWebKitAPI::TEST):
1086
1087 2019-04-03  Chris Dumez  <cdumez@apple.com>
1088
1089         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1090         https://bugs.webkit.org/show_bug.cgi?id=196588
1091         <rdar://problem/49365787>
1092
1093         Reviewed by Ryosuke Niwa.
1094
1095         Add API test coverage.
1096
1097         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1098         (TestWebKitAPI::nullJavaScriptCallback):
1099         (TestWebKitAPI::didCrashCheckFrames):
1100         (TestWebKitAPI::TEST):
1101
1102 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1103
1104         run-webkit-tests: Upload test results (new results database)
1105         https://bugs.webkit.org/show_bug.cgi?id=196577
1106         <rdar://problem/34841155>
1107
1108         Reviewed by Lucas Forschler.
1109
1110         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1111         (Manager.run): Upload results after each device shard, since the configuration will be
1112         different for each device.
1113         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1114         uploaded to a results database.
1115         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1116         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1117
1118 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1119
1120         -apple-trailing-word is needed for browser detection
1121         https://bugs.webkit.org/show_bug.cgi?id=196575
1122
1123         Unreviewed.
1124
1125         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1126
1127 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1128
1129         [CMake][WTF] Mirror XCode header directories
1130         https://bugs.webkit.org/show_bug.cgi?id=191662
1131
1132         Reviewed by Konstantin Tokarev.
1133
1134         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1135         builds.
1136
1137         * CMakeLists.txt:
1138         * DumpRenderTree/CMakeLists.txt:
1139         * DumpRenderTree/PlatformWin.cmake:
1140         * MiniBrowser/win/CMakeLists.txt:
1141         * TestWebKitAPI/CMakeLists.txt:
1142         * TestWebKitAPI/PlatformWin.cmake:
1143         * WebKitTestRunner/PlatformGTK.cmake:
1144         * WebKitTestRunner/PlatformWin.cmake:
1145
1146 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1147
1148         [ews-app] Status bubble should not display certain infrastructure status messages
1149         https://bugs.webkit.org/show_bug.cgi?id=196550
1150
1151         Reviewed by Lucas Forschler.
1152
1153         Do not display the steps which are un-needed for end-user. This information is still avaiable
1154         if the user click on the bubble and look at the Buildbot build.
1155         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1156         (StatusBubble._steps_messages):
1157         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1158
1159 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1160
1161         [ews-build] Use https for sending data to ews-app
1162         https://bugs.webkit.org/show_bug.cgi?id=196492
1163
1164         Reviewed by Lucas Forschler.
1165
1166         * BuildSlaveSupport/ews-build/events.py:
1167
1168 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1169
1170         Remove support for -apple-trailing-word
1171         https://bugs.webkit.org/show_bug.cgi?id=196525
1172
1173         Reviewed by Zalan Bujtas.
1174
1175         This CSS property is nonstandard and not used.
1176
1177         * Scripts/webkitperl/FeatureList.pm:
1178         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1179
1180 2019-04-03  Youenn Fablet  <youenn@apple.com>
1181
1182         Add a test for DOMCache on multiple browsing in case of private browsing
1183         https://bugs.webkit.org/show_bug.cgi?id=196524
1184
1185         Reviewed by Alex Christensen.
1186
1187         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1188         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1189
1190 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1191
1192         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1193         https://bugs.webkit.org/show_bug.cgi?id=196540
1194
1195         Reviewed by Aakash Jain.
1196
1197         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1198
1199 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1200
1201         Add plumbing for a compatibility mode preference in WebKit
1202         https://bugs.webkit.org/show_bug.cgi?id=196005
1203
1204         Reviewed by Tim Horton.
1205
1206         Add new API tests.
1207
1208         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1209         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1210
1211 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1212
1213         [WPE][GTK] Update libsrtp dependency package for Debian
1214         https://bugs.webkit.org/show_bug.cgi?id=196528
1215
1216         Reviewed by Frédéric Wang.
1217
1218         * gtk/install-dependencies:
1219         * wpe/install-dependencies:
1220
1221 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1222
1223         [WK2] Add support for Window's beforeprint / afterprint events
1224         https://bugs.webkit.org/show_bug.cgi?id=196478
1225         <rdar://problem/49535124>
1226
1227         Unreviewed build fix for MSVC.
1228
1229         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1230
1231         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1232
1233         * WebKitTestRunner/TestController.cpp:
1234         (WTR::printFrame): Use int and float literals.
1235
1236 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1237
1238         [ews-build] Reassign bots to queues
1239
1240         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1241
1242 2019-04-02  Chris Dumez  <cdumez@apple.com>
1243
1244         [WK2] Add support for Window's beforeprint / afterprint events
1245         https://bugs.webkit.org/show_bug.cgi?id=196478
1246
1247         Reviewed by Alex Christensen.
1248
1249         Add minimal implementation for printFrame in WebKitTestRunner.
1250
1251         * WebKitTestRunner/TestController.cpp:
1252         (WTR::printFrame):
1253         (WTR::TestController::createOtherPage):
1254         (WTR::TestController::createWebViewWithOptions):
1255
1256 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1257
1258         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1259         https://bugs.webkit.org/show_bug.cgi?id=196491
1260
1261         Reviewed by Lucas Forschler.
1262
1263         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1264
1265 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1266
1267         [ews-build] Configure buildbot try credentials in environment variables
1268         https://bugs.webkit.org/show_bug.cgi?id=196501
1269
1270         Reviewed by Lucas Forschler.
1271
1272         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1273         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1274         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1275
1276 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1277
1278         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1279         https://bugs.webkit.org/show_bug.cgi?id=196496
1280         <rdar://problem/49521634>
1281
1282         Reviewed by Chris Dumez.
1283
1284         Add new API tests (see WebKit ChangeLog for more detail).
1285
1286         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1287         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1288         (TEST):
1289
1290 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1291
1292         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1293         <https://webkit.org/b/196499>
1294
1295         Reviewed by Alexey Proskuryakov.
1296
1297         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1298         ENABLE_ADDRESS_SANITIZER.
1299
1300 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1301
1302         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1303         https://bugs.webkit.org/show_bug.cgi?id=182757
1304
1305         Reviewed by Don Olmstead.
1306
1307         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1308         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1309
1310 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1311
1312         run-api-tests: Upload test results
1313         https://bugs.webkit.org/show_bug.cgi?id=196323
1314         <rdar://problem/49356714>
1315
1316         Reviewed by Lucas Forschler.
1317
1318         * Scripts/webkitpy/api_tests/manager.py:
1319         (Manager):
1320         (Manager.run): Upload results to a results database.
1321         * Scripts/webkitpy/api_tests/run_api_tests.py:
1322         (parse_args): Add upload arguments.
1323         * Scripts/webkitpy/port/base.py:
1324         (Port):
1325         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1326         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1327         with commits from any other associated repositories.
1328         * Scripts/webkitpy/port/device.py:
1329         (Device):
1330         (Device.build_version): Access build_versoin of underlying platform device.
1331         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1332         (IOSSimulatorTest):
1333         (IOSSimulatorTest.test_configuration_for_upload):
1334         * Scripts/webkitpy/port/device_port.py:
1335         (DevicePort):
1336         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1337         the same as the machine uploading results.
1338         * Scripts/webkitpy/port/mac.py:
1339         (MacPort):
1340         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1341         * Scripts/webkitpy/port/mac_unittest.py:
1342         (MacTest):
1343         (MacTest.test_configuration_for_upload):
1344         * Scripts/webkitpy/xcode/simulated_device.py:
1345         (SimulatedDeviceManager._create_device_with_runtime):
1346         (SimulatedDevice.__init__): Create simulated device with a build_version.
1347         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1348         (test_existing_simulator):
1349
1350 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1351
1352         Remove extra newline characters (Follow-up fix to r243707)
1353
1354         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1355
1356 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1357
1358         [ews-app] Use API_KEY to accept results data
1359         https://bugs.webkit.org/show_bug.cgi?id=196461
1360
1361         Reviewed by Dewei Zhu.
1362
1363         * BuildSlaveSupport/ews-app/ews/views/results.py:
1364         (Results.post): Validate EWS_API_KEY before accepting any data.
1365         * BuildSlaveSupport/ews-build/events.py:
1366         (Events.sendData): Send EWS_API_KEY if available along with event data.
1367
1368 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1369
1370         Unable to copy and paste a PDF from Notes into Mail compose body
1371         https://bugs.webkit.org/show_bug.cgi?id=196442
1372         <rdar://problem/48573098>
1373
1374         Reviewed by Tim Horton.
1375
1376         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1377         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1378         to be specified on the item providers.
1379
1380         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1381         (TestWebKitAPI::mapItemForTesting):
1382         (TestWebKitAPI::contactItemForTesting):
1383
1384 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1385
1386         Make UIWKDocumentContext rects per-character instead of per-word
1387         https://bugs.webkit.org/show_bug.cgi?id=196459
1388
1389         Reviewed by Wenson Hsieh.
1390
1391         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1392         (TEST):
1393         Adjust test results due to switching to per-character rects.
1394
1395 2019-04-01  Chris Dumez  <cdumez@apple.com>
1396
1397         UIProcess crash when a prewarmed process is terminated
1398         https://bugs.webkit.org/show_bug.cgi?id=196451
1399         <rdar://problem/49245471>
1400
1401         Reviewed by Geoffrey Garen.
1402
1403         Add API test coverage.
1404
1405         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1406         (TEST):
1407
1408 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1409
1410         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1411         https://bugs.webkit.org/show_bug.cgi?id=196449
1412
1413         Reviewed by Lucas Forschler.
1414
1415         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1416         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1417         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1418         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1419
1420 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1421
1422         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1423         https://bugs.webkit.org/show_bug.cgi?id=196444
1424
1425         Reviewed by Lucas Forschler.
1426
1427         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1428
1429 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1430
1431         Add SPI to canonicalize NSURLs with WTF::URL
1432         https://bugs.webkit.org/show_bug.cgi?id=196415
1433         <rdar://problem/44980271>
1434
1435         Reviewed by Darin Adler.
1436
1437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1438         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1439         (TestWebKitAPI::TEST):
1440
1441 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1442
1443         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1444         https://bugs.webkit.org/show_bug.cgi?id=196441
1445
1446         Reviewed by Carlos Garcia Campos.
1447
1448         Don't cache the wpe_view_backend object that might not exist yet at the
1449         time of EventSenderProxy constructor invocation, but instead retrieve
1450         that object whenever it's required for event dispatching. This should
1451         avoid crashes in this constructor now that it's invoked before any
1452         PlatformWindow has been set up (as changed in r243496).
1453
1454         * WebKitTestRunner/EventSenderProxy.h:
1455         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1456         (WTR::viewBackend):
1457         (WTR::EventSenderProxy::EventSenderProxy):
1458         (WTR::EventSenderProxy::mouseDown):
1459         (WTR::EventSenderProxy::mouseUp):
1460         (WTR::EventSenderProxy::mouseMoveTo):
1461         (WTR::EventSenderProxy::mouseScrollBy):
1462         (WTR::EventSenderProxy::keyDown):
1463         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1464
1465 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1466
1467         [Win][WebKit] MiniBrowser should support high DPI display
1468         https://bugs.webkit.org/show_bug.cgi?id=196391
1469
1470         Reviewed by Alex Christensen.
1471
1472         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1473         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1474         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1475         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1476
1477 2019-03-31  Sam Weinig  <weinig@apple.com>
1478
1479         Remove more i386 specific configurations
1480         https://bugs.webkit.org/show_bug.cgi?id=196430
1481
1482         Reviewed by Alexey Proskuryakov.
1483
1484         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1485         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1486
1487 2019-03-31  Andy Estes  <aestes@apple.com>
1488
1489         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1490         https://bugs.webkit.org/show_bug.cgi?id=196433
1491         <rdar://problem/49293305>
1492
1493         Reviewed by Tim Horton.
1494
1495         Enhanced API test coverage to include all navigation response policy decisions in both
1496         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1497
1498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1499         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1500         (TestWebKitAPI::TEST):
1501         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1502         (readFile):
1503         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1504         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1505         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1506         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1507         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1508         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1509         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1510         (-[QuickLookDelegate _downloadDidStart:]):
1511         (-[QuickLookDelegate _download:didReceiveResponse:]):
1512         (-[QuickLookDelegate _download:didReceiveData:]):
1513         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1514         (-[QuickLookDelegate _downloadDidFinish:]):
1515         (-[QuickLookDelegate _download:didFailWithError:]):
1516         (-[QuickLookDelegate _downloadDidCancel:]):
1517         (-[QuickLookDelegate verifyDownload]):
1518         (runTest):
1519         (runTestDecideBeforeLoading):
1520         (runTestDecideAfterLoading):
1521         (TEST):
1522         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1523         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1524         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1525         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1526         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1527         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1528         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1529         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1530         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1531         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1532         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1533         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1534         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1535         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1536
1537 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1538
1539         [CMake] add testdfg as target with build-jsc
1540         https://bugs.webkit.org/show_bug.cgi?id=196393
1541
1542         Reviewed by Saam Barati.
1543
1544         Added testdfg as one of the targets to build when
1545         using CMake.
1546
1547         * Scripts/build-jsc:
1548
1549 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1550
1551         Delete WebMetal implementation in favor of WebGPU
1552         https://bugs.webkit.org/show_bug.cgi?id=195418
1553
1554         Reviewed by Dean Jackson.
1555
1556         * DumpRenderTree/mac/DumpRenderTree.mm:
1557         (enableExperimentalFeatures):
1558         (resetWebPreferencesToConsistentValues):
1559         * Scripts/webkitperl/FeatureList.pm:
1560         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1562         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1563         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1564         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1565         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1566         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1567         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1568         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1569         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1570         (WTR::InjectedBundle::beginTesting):
1571         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1572         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1573         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1574
1575 2019-03-29  Chris Dumez  <cdumez@apple.com>
1576
1577         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1578         https://bugs.webkit.org/show_bug.cgi?id=196405
1579         <rdar://problem/49428130>
1580
1581         Reviewed by Wenson Hsieh.
1582
1583         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1584         the popover presentation methods to be no-ops. Use this in the new test added in
1585         r243523 so that we do not swizzle those methods for all tests. This is needed because
1586         those WatchOS tests rely on the popover getting presented and interactive.
1587
1588         * WebKitTestRunner/TestController.cpp:
1589         (WTR::updateTestOptionsFromTestHeader):
1590         * WebKitTestRunner/TestController.h:
1591         * WebKitTestRunner/TestOptions.h:
1592         (WTR::TestOptions::hasSameInitializationOptions const):
1593         * WebKitTestRunner/ios/TestControllerIOS.mm:
1594         (WTR::TestController::platformInitialize):
1595         (WTR::TestController::platformResetStateToConsistentValues):
1596
1597 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1598
1599         [Curl] Add Server Trust Evaluation Support.
1600         https://bugs.webkit.org/show_bug.cgi?id=191646
1601
1602         Reviewed by Fujii Hironori.
1603
1604         Implemented MiniBrowser UI for asking if user trusts the server.
1605
1606         * MiniBrowser/win/Common.cpp:
1607         (askServerTrustEvaluation):
1608         (replaceString):
1609         * MiniBrowser/win/Common.h:
1610         * MiniBrowser/win/MiniBrowserLib.rc:
1611         * MiniBrowser/win/MiniBrowserLibResource.h:
1612         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1613         (createPEMString):
1614         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1615         (WebKitBrowserWindow::canTrustServerCertificate):
1616         * MiniBrowser/win/WebKitBrowserWindow.h:
1617
1618 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1619
1620         Implement ResizeObserver.
1621         https://bugs.webkit.org/show_bug.cgi?id=157743
1622
1623         Reviewed by Simon Fraser.
1624
1625         Support resizeObserverEnabled webPreferences.
1626
1627         * DumpRenderTree/TestOptions.cpp:
1628         (TestOptions::TestOptions):
1629         * DumpRenderTree/TestOptions.h:
1630         * DumpRenderTree/mac/DumpRenderTree.mm:
1631         (setWebPreferencesForTestOptions):
1632         * DumpRenderTree/win/DumpRenderTree.cpp:
1633         (enableExperimentalFeatures):
1634         * Scripts/webkitperl/FeatureList.pm:
1635         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1636
1637 2019-03-28  John Wilander  <wilander@apple.com>
1638
1639         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1640         https://bugs.webkit.org/show_bug.cgi?id=196281
1641         <rdar://problem/48938748>
1642
1643         Reviewed by Alex Christensen.
1644
1645         This patch adds the function isStatisticsHasLocalStorage() to the
1646         TestRunner. With it, the page can query the WebsiteDataStore in the
1647         UI process to make sure that it sees LocalStorage.
1648
1649         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1650         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1651         (WTR::TestRunner::isStatisticsHasLocalStorage):
1652         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1653         * WebKitTestRunner/TestController.cpp:
1654         (WTR::TestController::isStatisticsHasLocalStorage):
1655         * WebKitTestRunner/TestController.h:
1656         * WebKitTestRunner/TestInvocation.cpp:
1657         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1658
1659 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1660
1661         API::Data::createWithoutCopying should do a null check before calling CFRelease
1662         https://bugs.webkit.org/show_bug.cgi?id=196276
1663         <rdar://problem/48059859>
1664
1665         Reviewed by Alex Christensen.
1666
1667         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1668
1669         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1670         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1671         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1672         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1673         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1674         (TestWebKitAPI::TEST):
1675
1676 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1677
1678         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1679         https://bugs.webkit.org/show_bug.cgi?id=186276
1680
1681         Reviewed by Carlos Garcia Campos.
1682
1683         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1684         (webViewLoadChanged):
1685         (testWebResourceGetDataError):
1686         (testWebResourceGetDataEmpty):
1687         (beforeAll):
1688         (webViewloadChanged): Deleted.
1689
1690 2019-03-27  Andy Estes  <aestes@apple.com>
1691
1692         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1693         https://bugs.webkit.org/show_bug.cgi?id=196317
1694
1695         Reviewed by Dan Bernstein.
1696
1697         package-root copies built products into a staging directory using ditto(1), which does not
1698         follow symbolic links as it traverses a directory. Now that the files in
1699         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1700         itself, these become broken links when ditto'd into the staging directory.
1701
1702         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1703
1704         * Scripts/package-root:
1705
1706 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1707
1708         [ews-app] Update display text of Submit for ews analysis
1709         https://bugs.webkit.org/show_bug.cgi?id=196309
1710
1711         Reviewed by Dewei Zhu.
1712
1713         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1714
1715 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1716
1717         run-webkit-tests should check for leaks in WebKit processes
1718         <https://webkit.org/b/193772>
1719         <rdar://problem/46526680>
1720
1721         Reviewed by Ryosuke Niwa.
1722
1723         This works by doing the following:
1724         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1725           The list of child processes are returned one per line:
1726           process.name: pid
1727         - Run the "#LIST CHILD PROCESSES" command just before the
1728           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1729           processes on the ServerProcess object.
1730         - When the `--leaks` switch is handled, run check_for_leaks() on
1731           each child process after the main test harness.
1732
1733         * DumpRenderTree/mac/DumpRenderTree.mm:
1734         (handleControlCommand):
1735         - Use strncmp() instead of strcmp().
1736         - Add support for handling "#LIST CHILD PROCESSES" command.
1737
1738         * Scripts/webkitpy/port/base.py:
1739         (Port.check_for_leaks):
1740         * Scripts/webkitpy/port/darwin.py:
1741         (DarwinPort.check_for_leaks):
1742         - Rename redundant 'process_pid' argument to 'process_id'.
1743
1744         * Scripts/webkitpy/port/driver.py:
1745         (Driver.do_post_tests_work):
1746         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1747           longer the only command this sends to WebKitTestRunner.
1748         - If the `--leaks` switch is present, send the
1749           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1750           result using Port.set_webkit_processes().
1751         (Driver._parse_child_processes_output):
1752         - Add helper method to parse list of child process names and
1753           process IDs returned from WebKitTestRunner.
1754
1755         * Scripts/webkitpy/port/ios_device.py:
1756         (IOSDevicePort.check_for_leaks):
1757         - Rename redundant 'process_pid' argument to 'process_id'.
1758
1759         * Scripts/webkitpy/port/leakdetector.py:
1760         (LeakDetector._parse_leaks_output):
1761         - Return early if there is no leaks_output.
1762         (LeakDetector.check_for_leaks):
1763         - Rename redundant 'process_pid' argument to 'process_id'.
1764
1765         * Scripts/webkitpy/port/server_process.py:
1766         (ServerProcess.__init__):
1767         (ServerProcess.child_processes):
1768         (ServerProcess.set_child_processes):
1769         - Add instance variable to Port to store list of child process
1770           names and process IDs returned from WebKitTestRunner.
1771         (ServerProcess._start):
1772         - Clear self._child_processes.
1773         (ServerProcess.stop):
1774         - If self._child_processes is set, call
1775           self._port.check_for_leaks() for each child process.
1776
1777         * Scripts/webkitpy/port/server_process_unittest.py:
1778         (TrivialMockPort.check_for_leaks):
1779         - Rename redundant 'process_pid' argument to 'process_id'.
1780
1781         * Scripts/webkitpy/port/simulator_process.py:
1782         (SimulatorProcess.stop):
1783         - If self._child_processes is set, call
1784           self._port.check_for_leaks() for each child process.
1785
1786         * Scripts/webkitpy/port/watch_device.py:
1787         (WatchDevicePort.check_for_leaks):
1788         - Rename redundant 'process_pid' argument to 'process_id'.
1789
1790         * WebKitTestRunner/TestController.cpp:
1791         (WTR::TestController::dumpResponse):
1792         - Extract method from findAndDumpWorldLeaks() so that it may be
1793           reused by findAndDumpWebKitProcessIdentifiers().
1794         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1795         - Add method to output process name and process ID of both the
1796           WebContent and Networking processes.
1797         (WTR::TestController::findAndDumpWorldLeaks):
1798         - Fix missing newline in output when there were no abandoned
1799           documents.
1800         - Call dumpResponse() for extracted code.
1801         (WTR::TestController::handleControlCommand):
1802         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1803         - Use strncmp() instead of strcmp().
1804         - Call findAndDumpWebKitProcessIdentifiers() when
1805           "#LIST CHILD PROCESSES" command is sent.
1806         * WebKitTestRunner/TestController.h:
1807         (WTR::TestController::dumpResponse):
1808         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1809         - Declare methods.
1810
1811 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1812
1813         Unreviewed. Add GLib API test cases after r243434.
1814
1815         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1816         (testWebViewActiveURI):
1817         (serverCallback):
1818         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1819         (sendRequestCallback):
1820
1821 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1822
1823         Geolocation request not complete when watch request was started in a different web process
1824         https://bugs.webkit.org/show_bug.cgi?id=195996
1825
1826         Reviewed by Alex Christensen.
1827
1828         Add a test case.
1829
1830         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1831         (TestWebKitAPI::runJavaScriptAlert):
1832         (TestWebKitAPI::TEST):
1833
1834 2019-03-26  Keith Rollin  <krollin@apple.com>
1835
1836         Update the way generate-xcfilelists returns strings from functions
1837         https://bugs.webkit.org/show_bug.cgi?id=195975
1838         <rdar://problem/49040807>
1839
1840         Reviewed by Dean Jackson.
1841
1842         There are places where generate-xcfilelists executes assignments with
1843         statements like:
1844
1845             FOO=$(some_function)
1846
1847         where "some_function" return a string by echoing it. E.g.
1848
1849             some_function()
1850             {
1851                 echo "Hello, World"
1852             }
1853
1854         This is a common idiom, but it has a problem if "some_function" needs
1855         to call "exit" in an attempt to halt the entire script right then and
1856         there. Since "some_function" is called inside of $(), it's being
1857         executed in a sub-shell. Calling exit in that sub-shell simply exits
1858         that shell; it doesn't not exit the outer shell in which the main part
1859         of the script is still running. As such, the main script keeps
1860         executing when the intent was for the script to halt.
1861
1862         The solution to this is to use a different idiom for returning
1863         strings. The one we now is to pass in the name of the variable to
1864         receive the string result:
1865
1866             some_function()
1867             {
1868                 variable_name=$1
1869                 eval $variable_name ="Hello, World"
1870             }
1871
1872         The call site now looks like
1873
1874             some_function FOO
1875
1876         Because there's no invocation of a sub-shell, some_function can now
1877         call "exit" if it wants to, and the entire script will exit at that
1878         point.
1879
1880         * Scripts/generate-xcfilelists:
1881
1882 2019-03-26  Chris Dumez  <cdumez@apple.com>
1883
1884         Add basic layout test coverage for File Picker on iOS
1885         https://bugs.webkit.org/show_bug.cgi?id=196265
1886
1887         Reviewed by Wenson Hsieh.
1888
1889         Add layout test infrastructure to test the file picker on iOS.
1890
1891         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1892         (WTR::UIScriptController::dismissFilePicker):
1893         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1894         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1895         (WTR::UIScriptController::dismissFilePicker):
1896         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1897         * WebKitTestRunner/TestController.cpp:
1898         (WTR::TestController::createWebViewWithOptions):
1899         (WTR::updateTestOptionsFromTestHeader):
1900         * WebKitTestRunner/TestOptions.h:
1901         (WTR::TestOptions::hasSameInitializationOptions const):
1902         * WebKitTestRunner/ios/TestControllerIOS.mm:
1903         (overridePresentViewController):
1904         (WTR::TestController::platformInitialize):
1905         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1906         (WTR::UIScriptController::dismissFilePicker):
1907
1908 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1909
1910         Implement async paste method on UIWKInteractionViewProtocol
1911         https://bugs.webkit.org/show_bug.cgi?id=196267
1912         <rdar://problem/49236346>
1913
1914         Reviewed by Tim Horton.
1915
1916         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1917         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1918         are now a part of all iOS 12 internal SDKs.
1919
1920         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1921
1922         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1923         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1924
1925         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1926         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1927         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1928         * TestWebKitAPI/ios/UIKitSPI.h:
1929
1930 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1931
1932         [ews-build] Use PostgreSQL for ews.webkit.org database
1933         https://bugs.webkit.org/show_bug.cgi?id=196270
1934
1935         Reviewed by Lucas Forschler.
1936
1937         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1938
1939 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1940
1941         [ews] Reset simctl states on reboot
1942         https://bugs.webkit.org/show_bug.cgi?id=196260
1943
1944         Rubber-stamped by Aakash Jain.
1945
1946         * EWSTools/start-queue-mac.sh:
1947
1948 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1949
1950         [ews-build] Use PostgreSQL for ews-build database
1951         https://bugs.webkit.org/show_bug.cgi?id=196229
1952
1953         Reviewed by Lucas Forschler.
1954
1955         * BuildSlaveSupport/ews-build/master.cfg:
1956
1957 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1958
1959         [ews-build] Get master_hostname dynamically in master.cfg
1960         https://bugs.webkit.org/show_bug.cgi?id=196255
1961
1962         Reviewed by Lucas Forschler.
1963
1964         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1965         send events data in test mode.
1966
1967 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1968
1969         [ews-app] Set db_constraint to False for Foreign Keys
1970         https://bugs.webkit.org/show_bug.cgi?id=196252
1971
1972         Reviewed by Lucas Forschler.
1973
1974         * BuildSlaveSupport/ews-app/ews/models/build.py:
1975         * BuildSlaveSupport/ews-app/ews/models/step.py:
1976
1977 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1978
1979         [ews-build] is_test_mode_enabled should default to True
1980         https://bugs.webkit.org/show_bug.cgi?id=196248
1981
1982         Reviewed by Lucas Forschler.
1983
1984         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1985
1986 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1987
1988         [ews-app] Add webkitperl to ENABLED_QUEUES
1989         https://bugs.webkit.org/show_bug.cgi?id=196253
1990
1991         Reviewed by Lucas Forschler.
1992
1993         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1994
1995 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1996
1997         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1998         https://bugs.webkit.org/show_bug.cgi?id=196211
1999         rdar://problem/49110552
2000
2001         Reviewed by Tim Horton.
2002
2003         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2004         Make sure that EventSenderProxy always exists when running tests. We used to create
2005         it when resetting before the first test, which is a bit too late.
2006
2007         * WebKitTestRunner/TestController.h:
2008         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2009         (WTR::TestController::platformCreateWebView):
2010         (WTR::TestController::platformCreateOtherPage):
2011         (WTR::TestController::finishCreatingPlatformWebView):
2012         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2013         (WTR::PlatformWebView::PlatformWebView):
2014         Moved some code that made NSWindow use NSEvent during web view creation. We may
2015         need to move more if some other case us found, but this is enough for now.
2016
2017 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2018
2019         Unreviewed. Fix typo in GLib geolocation API after r243285.
2020
2021         gelocation -> geolocation.
2022
2023         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2024         (testGeolocationManagerWatchPosition):
2025
2026 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2027
2028         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2029         https://bugs.webkit.org/show_bug.cgi?id=196213
2030
2031         Reviewed by Geoff Garen.
2032
2033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2034         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2035         (credentialWithIdentityAndKeychainPath):
2036         (-[ChallengeDelegate webView:didFinishNavigation:]):
2037         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2038         (TestWebKitAPI::TEST):
2039
2040 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2041
2042         Expected shouldn't assume its contained types are copyable
2043         https://bugs.webkit.org/show_bug.cgi?id=195986
2044
2045         Reviewed by JF Bastien.
2046
2047         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2048         (TestWebKitAPI::NonCopyable::operator== const):
2049         (TestWebKitAPI::NonCopyable::operator!= const):
2050         (TestWebKitAPI::TEST):
2051
2052 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2053
2054         Remove some now-unnecessary dynamic class lookup
2055         https://bugs.webkit.org/show_bug.cgi?id=196237
2056
2057         Reviewed by Simon Fraser.
2058
2059         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2060         (makeRequest):
2061         (TEST):
2062
2063 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2064
2065         Unreviewed, rolling out r243450.
2066
2067         AppleWin and WinCairo port builds get broken.
2068
2069         Reverted changeset:
2070
2071         "Add test for fix of #196095"
2072         https://bugs.webkit.org/show_bug.cgi?id=196097
2073         https://trac.webkit.org/changeset/243450
2074
2075 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2076
2077         Unreviewed, rolling out r243465.
2078         https://bugs.webkit.org/show_bug.cgi?id=196226
2079
2080         the test doesn't build (Requested by thorton on #webkit).
2081
2082         Reverted changeset:
2083
2084         "Do not terminate the NetworkProcess if a third party
2085         application sends a NSCredential with a SecIdentityRef"
2086         https://bugs.webkit.org/show_bug.cgi?id=196213
2087         https://trac.webkit.org/changeset/243465
2088
2089 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2090
2091         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2092         https://bugs.webkit.org/show_bug.cgi?id=196213
2093
2094         Reviewed by Geoff Garen.
2095
2096         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2097         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2098         (credentialWithIdentityAndKeychainPath):
2099         (-[ChallengeDelegate webView:didFinishNavigation:]):
2100         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2101         (TestWebKitAPI::TEST):
2102
2103 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2104
2105         [ews-build] Gracefully handle missing patch_id in events
2106         https://bugs.webkit.org/show_bug.cgi?id=196216
2107
2108         Reviewed by Lucas Forschler.
2109
2110         * BuildSlaveSupport/ews-build/events.py:
2111
2112 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2113
2114         [ews-build] use lz4 compression for improving buildbot performance
2115         https://bugs.webkit.org/show_bug.cgi?id=196155
2116
2117         Reviewed by Lucas Forschler.
2118
2119         * BuildSlaveSupport/ews-build/master.cfg:
2120
2121 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2122
2123         Pull some API testing helper methods out of TestWKWebView
2124         https://bugs.webkit.org/show_bug.cgi?id=196212
2125
2126         Reviewed by Tim Horton.
2127
2128         Refactor some more API testing utility methods, so that they can be used in
2129         tests that do not use TestWKWebView.
2130
2131         * TestWebKitAPI/cocoa/TestWKWebView.h:
2132         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2133         (-[WKWebView loadTestPageNamed:]):
2134         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2135         (-[WKWebView synchronouslyLoadHTMLString:]):
2136         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2137         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2138         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2139         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2140         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2141
2142 2019-03-25  Jer Noble  <jer.noble@apple.com>
2143
2144         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2145         https://bugs.webkit.org/show_bug.cgi?id=196097
2146
2147         Reviewed by Eric Carlson.
2148
2149         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2150
2151         * DumpRenderTree/mac/DumpRenderTree.mm:
2152         (resetWebPreferencesToConsistentValues):
2153         * WebKitTestRunner/TestController.cpp:
2154         (WTR::TestController::resetPreferencesToConsistentValues):
2155
2156 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2157
2158         Pull IPadUserInterfaceSwizzler out into a separate header file
2159         https://bugs.webkit.org/show_bug.cgi?id=196193
2160
2161         Reviewed by Anders Carlsson.
2162
2163         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2164         be used in other API tests.
2165
2166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2167         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2168         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2169         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2170         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2171         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2172         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2173
2174 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2175
2176         Remove NavigatorContentUtils in WebCore/Modules
2177         https://bugs.webkit.org/show_bug.cgi?id=196070
2178
2179         Reviewed by Alex Christensen.
2180
2181         NavigatorContentUtils was to support the custom scheme spec [1].
2182         However, in WebKit side, no port has supported the feature in
2183         WebKit layer after EFL port was removed. So there has been the
2184         only IDL implementation of the NavigatorContentUtils in WebCore.
2185         So we don't need to keep the implementation in WebCore anymore.
2186
2187         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2188
2189         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2190
2191 2019-03-24  Andy Estes  <aestes@apple.com>
2192
2193         [watchOS] Remove unused Proximity Networking code
2194         https://bugs.webkit.org/show_bug.cgi?id=196188
2195
2196         Reviewed by Tim Horton.
2197
2198         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2199         (TEST):
2200
2201 2019-03-23  Keith Miller  <keith_miller@apple.com>
2202
2203         Refactor clz/ctz and fix getLSBSet.
2204         https://bugs.webkit.org/show_bug.cgi?id=196162
2205
2206         Reviewed by Saam Barati.
2207
2208         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2209
2210         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2211         (TestWebKitAPI::TEST):
2212
2213 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2214
2215         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2216         https://bugs.webkit.org/show_bug.cgi?id=196143
2217
2218         Reviewed by Michael Catanzaro.
2219
2220         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2221         directories.
2222
2223         * Scripts/webkitpy/style/checkers/cpp.py:
2224         (check_identifier_name_in_declaration):
2225         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2226         (WebKitStyleTest.test_names):
2227
2228 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2229
2230         [Flatpak] Manifest expanding fails for qt WPE extension
2231         https://bugs.webkit.org/show_bug.cgi?id=196148
2232
2233         Reviewed by Alex Christensen.
2234
2235         * flatpak/flatpakutils.py:
2236         (expand_submodules_recurse): The last recurse manifest expand
2237         iteration might lead to a single module so take it into account
2238         and don't try to recurse further.
2239
2240 2019-03-22  Chris Dumez  <cdumez@apple.com>
2241
2242         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2243         https://bugs.webkit.org/show_bug.cgi?id=195348
2244         <rdar://problem/48622090>
2245
2246         Reviewed by Alex Christensen.
2247
2248         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2249         to NO when test.options().shouldIgnoreMetaViewport is false.
2250
2251         * WebKitTestRunner/ios/TestControllerIOS.mm:
2252         (WTR::TestController::platformConfigureViewForTest):
2253
2254 2019-03-22  Chris Dumez  <cdumez@apple.com>
2255
2256         Prewarmed processes should be usable with any website data store
2257         https://bugs.webkit.org/show_bug.cgi?id=196104
2258
2259         Reviewed by Alex Christensen.
2260
2261         Add API test coverage.
2262
2263         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2264         (runInitialWarmedProcessUsedTest):
2265         (TEST):
2266
2267 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2268
2269         Back out local changes to Alex's Subversion working directory
2270
2271         They were accidentally committed.
2272
2273         * Scripts/webkitpy/common/system/abstractexecutive.py:
2274         (AbstractExecutive.wait_newest):
2275         * Scripts/webkitpy/common/system/executive.py:
2276         (Executive.running_pids):
2277         * Scripts/webkitpy/common/system/executive_mock.py:
2278         (MockExecutive.running_pids):
2279         * Scripts/webkitpy/common/system/executive_unittest.py:
2280         (ExecutiveTest.serial_test_running_pids):
2281         * Scripts/webkitpy/port/darwin.py:
2282         (DarwinPort.check_for_leaks):
2283         * Scripts/webkitpy/port/leakdetector.py:
2284         (LeakDetector.check_for_leaks):
2285         - This was the hack attached to Bug 193772.
2286
2287         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2288         (+[WebKitTestRunnerEvent mouseLocation]):
2289         - This works around a crash on an internal build.
2290
2291 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2292
2293         Fix the build after r243354
2294         https://bugs.webkit.org/show_bug.cgi?id=196138
2295         <rdar://problem/49145951>
2296
2297         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2298         (TEST):
2299         * TestWebKitAPI/ios/UIKitSPI.h:
2300
2301 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2302
2303         Adopt UIWKDocumentContext
2304         https://bugs.webkit.org/show_bug.cgi?id=196040
2305         <rdar://problem/48642440>
2306
2307         Reviewed by Ryosuke Niwa.
2308
2309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2310         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2311         (makeRequest):
2312         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2313         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2314         (applyStyle):
2315         (TEST):
2316         Add tests for UIWKDocumentContext.
2317
2318         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2319         (TEST):
2320         (recursiveFindWKContentView): Deleted.
2321         * TestWebKitAPI/cocoa/TestWKWebView.h:
2322         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2323         (recursiveFindWKContentView):
2324         (-[TestWKWebView wkContentView]):
2325         * TestWebKitAPI/ios/UIKitSPI.h:
2326         Share the WKContentView finding code between tests.
2327
2328 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2329
2330         [iOS WK2] Turn on async overflow scrolling by default
2331         https://bugs.webkit.org/show_bug.cgi?id=196011
2332         rdar://problem/48453859
2333
2334         Reviewed by Antti Koivisto.
2335         
2336         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2337         since so many basic layout tests have different results when compositing is triggered for
2338         overflow.
2339         
2340         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2341
2342         * WebKitTestRunner/TestController.cpp:
2343         (WTR::TestController::resetPreferencesToConsistentValues):
2344
2345 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2346
2347         [ews-build] Retry API test in case of failures
2348         https://bugs.webkit.org/show_bug.cgi?id=196004
2349
2350         Reviewed by Lucas Forschler.
2351
2352         * BuildSlaveSupport/ews-build/steps.py:
2353         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2354         (CompileWebKitToT.doStepIf): Ditto.
2355         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2356         (ReRunAPITests): Re-run API tests.
2357         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2358         (RunAPITestsWithoutPatch): Run API tests without patch.
2359         (RunAPITestsWithoutPatch.doStepIf):
2360         (RunAPITestsWithoutPatch.hideStepIf):
2361         (RunAPITestsWithoutPatch.evaluateCommand):
2362         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2363         (AnalyzeAPITestsResults.start):
2364         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2365         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2366         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2367         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2368
2369 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2370
2371         [ews-build] Update queues configurations
2372         https://bugs.webkit.org/show_bug.cgi?id=196074
2373
2374         Reviewed by Dewei Zhu.
2375
2376         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2377         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2378
2379 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2380
2381         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2382         https://bugs.webkit.org/show_bug.cgi?id=195680
2383         <rdar://problem/48903534>
2384
2385         Unreviewed infrastructure fix.
2386
2387         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2388         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2389
2390 2019-03-21  Andy Estes  <aestes@apple.com>
2391
2392         [iOS] Apple Pay should be available in documents with no user agent scripts
2393         https://bugs.webkit.org/show_bug.cgi?id=196061
2394         <rdar://problem/48649391>
2395
2396         Reviewed by Brady Eidson.
2397
2398         Added API tests and related infrastructure.
2399
2400         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2401         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2402         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2403         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2404         (TestWebKitAPI::TEST):
2405         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2406         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2407         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2408         * TestWebKitAPI/cocoa/TestProtocol.mm:
2409         (-[TestProtocol startLoading]):
2410         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2411         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2412         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2413         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2414
2415 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2416
2417         REGRESSSION (r243297): webkitpy tests broken
2418         https://bugs.webkit.org/show_bug.cgi?id=196108
2419
2420         Reviewed by Aakash Jain.
2421
2422         r243297 updated contributors.json, which broke a few unit tests.
2423
2424         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2425         (IRCCommandTest.test_whois):
2426         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2427
2428 2019-03-21  Chris Dumez  <cdumez@apple.com>
2429
2430         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2431         https://bugs.webkit.org/show_bug.cgi?id=196041
2432         <rdar://problem/49083230>
2433
2434         Reviewed by Alex Christensen.
2435
2436         Add API test coverage.
2437
2438         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2439         (TEST):
2440
2441 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2442
2443         Add SPI to inform applications of WKContentRuleList actions
2444         https://bugs.webkit.org/show_bug.cgi?id=195965
2445         <rdar://problem/42664365>
2446
2447         Reviewed by Geoff Garen.
2448
2449         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2450         (TestWebKitAPI::allActionsForResourceLoad):
2451         (TestWebKitAPI::testRequest):
2452         (TestWebKitAPI::TEST_F):
2453         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2454         (Notification::description):
2455         (Notification::operator== const):
2456         (toVector):
2457         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2458         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2459         (makeContentRuleList):
2460         (TEST):
2461         (makeWarnContentRuleList): Deleted.
2462
2463 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2464
2465         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2466         https://bugs.webkit.org/show_bug.cgi?id=196088
2467
2468         Reviewed by Brian Burg.
2469
2470         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2471         Support checks when only one platform is specified. Also deprecate macosx() and
2472         force the use of macos() instead.
2473
2474         * Scripts/webkitpy/style/checkers/cpp.py:
2475         (check_min_versions_of_wk_api_available):
2476         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2477         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2478
2479 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2480
2481         Update status inactive committers' status to 'contributor'.
2482
2483         * Scripts/webkitpy/common/config/contributors.json:
2484
2485 2019-03-21  Xan Lopez  <xan@igalia.com>
2486
2487         [JSC][x86] Drop support for x87 floating point
2488         https://bugs.webkit.org/show_bug.cgi?id=194853
2489
2490         Reviewed by Don Olmstead.
2491
2492         Force SSE2 on x86/32bit builds.
2493
2494         * Scripts/webkitdirs.pm:
2495         (generateBuildSystemFromCMakeProject):
2496
2497 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2498
2499         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2500         https://bugs.webkit.org/show_bug.cgi?id=196073
2501
2502         Reviewed by Michael Catanzaro.
2503
2504         Add test cases to check functions and constructors with no arguments but receiving user data.
2505
2506         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2507         (checkUserData):
2508         (testJSCFunction):
2509         (fooCreateWithUserData):
2510         (testJSCClass):
2511
2512 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2513
2514         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2515
2516         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2517
2518         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2519
2520 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2521
2522         [GTK][WPE] Add API to provide geolocation information
2523         https://bugs.webkit.org/show_bug.cgi?id=195940
2524
2525         Reviewed by Michael Catanzaro.
2526
2527         Add a new test to check the new API.
2528
2529         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2530         (testGeolocationManagerCurrentPosition):
2531         (testGeolocationManagerWatchPosition):
2532         (beforeAll):
2533         (afterAll):
2534         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2535         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2536         (beforeAll): Ditto.
2537         * TestWebKitAPI/glib/CMakeLists.txt:
2538
2539 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2540
2541         [GLib] Returning G_TYPE_OBJECT from a method does not work
2542         https://bugs.webkit.org/show_bug.cgi?id=195574
2543
2544         Reviewed by Michael Catanzaro.
2545
2546         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2547
2548         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2549         (getGFile):
2550         (getParent):
2551         (createGString):
2552         (getGString):
2553         (getGStringCopyWillRaise):
2554         (getGStringCopy):
2555         (getGStringStr):
2556         (getGStringLen):
2557         (freeGString):
2558         (testJSCClass):
2559
2560 2019-03-20  Saam Barati  <sbarati@apple.com>
2561
2562         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2563         https://bugs.webkit.org/show_bug.cgi?id=195721
2564
2565         Reviewed by Filip Pizlo.
2566
2567         * Scripts/run-javascriptcore-tests:
2568
2569 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2570
2571         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2572         https://bugs.webkit.org/show_bug.cgi?id=196049
2573
2574         Reviewed by Tim Horton.
2575
2576         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2577         overflow scrolling in general, so rename it.
2578
2579         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2580
2581 2019-03-20  Daniel Bates  <dabates@apple.com>
2582
2583         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2584         https://bugs.webkit.org/show_bug.cgi?id=196031
2585         <rdar://problem/49078172>
2586
2587         Reviewed by Tim Horton.
2588
2589         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2590         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2591         same code path used when the Done button is pressed to dismiss the <select> picker.
2592
2593         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2594         (TestWebKitAPI::TEST):
2595
2596 2019-03-20  Chris Dumez  <cdumez@apple.com>
2597
2598         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2599         https://bugs.webkit.org/show_bug.cgi?id=196029
2600         <rdar://problem/48954651>
2601
2602         Reviewed by Tim Horton.
2603
2604         Add API test coverage.
2605
2606         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2607
2608 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2609
2610         [ews-build] Improve failure summary string for ApplyPatch step
2611         https://bugs.webkit.org/show_bug.cgi?id=195995
2612
2613         Reviewed by Alexey Proskuryakov.
2614
2615         * BuildSlaveSupport/ews-build/steps.py:
2616         (ApplyPatch.getResultSummary): Override getResultSummary.
2617
2618 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2619
2620         AX: Implement support for new meter ARIA role
2621         https://bugs.webkit.org/show_bug.cgi?id=195966
2622
2623         Reviewed by Chris Fleizach.
2624
2625         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2626         to AXLevelIndicator.
2627
2628         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2629
2630 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2631
2632         [WebAuthN] Implement FIDO AppID extension
2633         https://bugs.webkit.org/show_bug.cgi?id=143491
2634         <rdar://problem/48298273>
2635
2636         Reviewed by Brent Fulgham.
2637
2638         Add a test that covers the new flag of convertToU2fSignCommand.
2639
2640         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2641         (TestWebKitAPI::TEST):
2642         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2643         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2644         (TestWebKitAPI::TEST):
2645
2646 2019-03-19  Keith Rollin  <krollin@apple.com>
2647
2648         Add support for more platforms to generate-xcfilelists
2649         https://bugs.webkit.org/show_bug.cgi?id=195977
2650
2651         Reviewed by Alexey Proskuryakov.
2652
2653         generate-xcfilelists incorrectly complains when involved with building
2654         WebKit for iphonesimulator:
2655
2656             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2657             …
2658             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2659
2660         Address this by teaching generate-xcfilelists about more platforms.
2661
2662         * Scripts/generate-xcfilelists:
2663
2664 2019-03-19  John Wilander  <wilander@apple.com>
2665
2666         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2667         https://bugs.webkit.org/show_bug.cgi?id=195923
2668         <rdar://problem/49001272>
2669
2670         Reviewed by Alex Christensen.
2671
2672         This patch does the following to the TestRunner:
2673         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2674         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2675         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2676
2677         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2678         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2679         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2680         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2681         * WebKitTestRunner/TestController.cpp:
2682         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2683         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2684         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2685         * WebKitTestRunner/TestController.h:
2686         * WebKitTestRunner/TestInvocation.cpp:
2687         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2688
2689 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2690
2691         [CMake] Support more clang and gcc sanitizers
2692         https://bugs.webkit.org/show_bug.cgi?id=195956
2693
2694         Reviewed by Michael Catanzaro.
2695
2696         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2697
2698 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2699
2700         [ews-build] Improve summary for PrintConfiguration step
2701         https://bugs.webkit.org/show_bug.cgi?id=195945
2702
2703         Reviewed by Lucas Forschler.
2704
2705         * BuildSlaveSupport/ews-build/steps.py:
2706         (PrintConfiguration.getResultSummary): Override getResultSummary.
2707
2708 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2709
2710         [ews-build] Improve summary for CheckOutSource step
2711         https://bugs.webkit.org/show_bug.cgi?id=195963
2712
2713         Reviewed by Lucas Forschler.
2714
2715         * BuildSlaveSupport/ews-build/steps.py:
2716         (CheckOutSource.getResultSummary):
2717
2718 2019-03-19  Daniel Bates  <dabates@apple.com>
2719
2720         [iOS] Focus not preserved when switching between tabs
2721         https://bugs.webkit.org/show_bug.cgi?id=195820
2722         <rdar://problem/43614450>
2723
2724         Reviewed by Brent Fulgham.
2725
2726         Add tests to ensure that we restore focus when resigning and becoming first responder.
2727
2728         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2729         (TestWebKitAPI::TEST):
2730
2731 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2732
2733         Make WTFLogChannelState and WTFLogLevel enum classes
2734         https://bugs.webkit.org/show_bug.cgi?id=195904
2735
2736         Reviewed by Eric Carlson.
2737
2738         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2739         (TestWebKitAPI::TEST_F):
2740
2741 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2742
2743         [GStreamer][EME] Backported mssdemux protection data crash fix
2744         https://bugs.webkit.org/show_bug.cgi?id=195918
2745
2746         Reviewed by Philippe Normand.
2747
2748         * gstreamer/jhbuild.modules:
2749         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2750
2751 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2752
2753         Unreviewed, rolling out r243132.
2754
2755         Broke GTK build
2756
2757         Reverted changeset:
2758
2759         "Make WTFLogChannelState and WTFLogLevel enum classes"
2760         https://bugs.webkit.org/show_bug.cgi?id=195904
2761         https://trac.webkit.org/changeset/243132
2762
2763 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2764
2765         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2766
2767         * Scripts/webkitdirs.pm:
2768         (builtDylibPathForName): Adjust the shared library name that's changed
2769         with the API version bump in r243073.
2770
2771 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2772
2773         Make WTFLogChannelState and WTFLogLevel enum classes
2774         https://bugs.webkit.org/show_bug.cgi?id=195904
2775
2776         Reviewed by Eric Carlson.
2777
2778         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2779         (TestWebKitAPI::TEST_F):
2780
2781 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2782
2783         Disable flaky test added in r2431100
2784         https://webkit.org/b/195785
2785
2786         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2787         (TestWebKitAPI::TEST):
2788         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2789
2790 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2791
2792         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2793         https://bugs.webkit.org/show_bug.cgi?id=195916
2794
2795         Reviewed by Tim Horton.
2796
2797         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2798         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2799
2800 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2801
2802         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2803
2804         * Scripts/webkitpy/common/config/contributors.json:
2805
2806 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2807
2808         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2809         https://bugs.webkit.org/show_bug.cgi?id=195785
2810
2811         Reviewed by Geoffrey Garen.
2812
2813         * TestWebKitAPI/TCPServer.cpp: Added.
2814         (TestWebKitAPI::TCPServer::TCPServer):
2815         (TestWebKitAPI::TCPServer::~TCPServer):
2816         (TestWebKitAPI::TCPServer::socketBindListen):
2817         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2818         * TestWebKitAPI/TCPServer.h: Added.
2819         (TestWebKitAPI::TCPServer::port const):
2820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2821         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2822         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2823         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2824         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2825         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2826         (TestWebKitAPI::respondSlowly):
2827         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2828         (TestWebKitAPI::downloadAtRate):
2829         (TestWebKitAPI::TEST):
2830
2831 2019-03-18  Saam Barati  <sbarati@apple.com>
2832
2833         Add a plan file for JetStream 2
2834         https://bugs.webkit.org/show_bug.cgi?id=190734
2835
2836         Reviewed by Mark Lam.
2837
2838         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2839
2840 2019-03-18  Chris Dumez  <cdumez@apple.com>
2841
2842         Delay WebProcess launch until a load is triggered in a Web view
2843         https://bugs.webkit.org/show_bug.cgi?id=195758
2844         <rdar://problem/48126013>
2845
2846         Reviewed by Geoff Garen.
2847
2848         Add API test coverage. Also update some existing API tests to not expect
2849         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2850
2851         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2852         (TestWebKitAPI::TEST):
2853         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2854         (TestWebKitAPI::TEST):
2855         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2856         (TEST):
2857         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2858         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2859         (TEST):
2860         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2861         (TEST):
2862         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2863
2864 2019-03-18  Xan Lopez  <xan@igalia.com>
2865
2866         [CMake] Prevent potential warning when determining $architecture
2867         https://bugs.webkit.org/show_bug.cgi?id=195891
2868
2869         Reviewed by Michael Catanzaro.
2870
2871         It's possible for generateBuildSystemForCMakeProject to be called
2872         before determineArchitecture() is ever called. This will make the
2873         first eq check with $architecture to be bogus (and print a
2874         warning). Change that to an eq check with architecture(), which
2875         implicitly calls determineArchitecture() if needed, and change all
2876         the other similar cases in the method in the same way to prevent
2877         future bugs like this one.
2878
2879         * Scripts/webkitdirs.pm:
2880         (generateBuildSystemFromCMakeProject):
2881
2882 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2883
2884         [WPE] Tarballs generated with “make dist” cannot build documentation
2885         https://bugs.webkit.org/show_bug.cgi?id=195885
2886
2887         Reviewed by Carlos Garcia Campos.
2888
2889         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2890
2891 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2892
2893         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2894         https://bugs.webkit.org/show_bug.cgi?id=195883
2895
2896         Reviewed by Carlos Garcia Campos.
2897
2898         * gtkdoc/gtkdoc.py:
2899         (GTKDoc._run_command): When commands fail to run, include the full command line for
2900         the program invocation and the output it has generated on the standard error stream.
2901
2902 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2903
2904         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2905         https://bugs.webkit.org/show_bug.cgi?id=195786
2906
2907         Reviewed by Philippe Normand.
2908
2909         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2910         * wpe/jhbuild.modules: Ditto.
2911
2912 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2913
2914         [ews-build] Don't run clean builds on EWS builders
2915         https://bugs.webkit.org/show_bug.cgi?id=195851
2916
2917         Reviewed by Geoffrey Garen.
2918
2919         * BuildSlaveSupport/ews-build/factories.py:
2920
2921 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2922
2923         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2924         https://bugs.webkit.org/show_bug.cgi?id=195849
2925
2926         Reviewed by Chris Dumez.
2927
2928         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2929
2930         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2931         (runWebsiteDataStoreCustomPaths):
2932
2933 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2934
2935         webkitpy: Upload test results
2936         https://bugs.webkit.org/show_bug.cgi?id=195755
2937         <rdar://problem/48896182>
2938
2939         Reviewed by Aakash Jain.
2940
2941         Establish a new format for uploading results that is not tied to layout tests, apply
2942         that format to webkitpy tests.
2943
2944         * Scripts/webkitpy/common/checkout/scm/git.py:
2945         (Git.native_branch): Return what branch the current checkout is on.
2946         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2947         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2948         * Scripts/webkitpy/common/checkout/scm/svn.py:
2949         (SVN.native_branch): Ditto.
2950         * Scripts/webkitpy/common/system/platforminfo.py:
2951         (PlatformInfo.build_version): Return a build version for Mac.
2952         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2953         (MockPlatformInfo.__init__):
2954         (MockPlatformInfo.build_version):
2955         * Scripts/webkitpy/results: Added.
2956         * Scripts/webkitpy/results/__init__.py: Added.
2957         * Scripts/webkitpy/results/options.py: Added.
2958         (upload_options): OptParse list for upload options.
2959         * Scripts/webkitpy/results/upload.py: Added.
2960         (Upload): Class which enforces the upload format expected by the results server.
2961         (Upload.Expectations):
2962         (Upload.create_configuration):
2963         (Upload.create_commit):
2964         (Upload.create_details):
2965         (Upload.create_run_stats):
2966         (Upload.create_test_result):
2967         (Upload.__init__):
2968         (Upload.Encoder): Encode Upload object as json.
2969         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2970         * Scripts/webkitpy/results/upload_unittest.py: Added.
2971         * Scripts/webkitpy/test/main.py:
2972         (Tester._parse_args): Add upload arguments.
2973         (Tester._run_tests): Allow results to be uploaded.
2974         * Scripts/webkitpy/test/runner.py:
2975         (Runner.__init__): Record which tests were run, rather than just counting them.
2976         (Runner.handle):
2977         * Scripts/webkitpy/test/runner_unittest.py:
2978         (RunnerTest.test_run):
2979         * Scripts/webkitpy/thirdparty/__init__.py:
2980         (AutoinstallImportHook.find_module): Add requests auto-install.
2981         (AutoinstallImportHook._install_requests):
2982         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2983         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2984
2985 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2986
2987         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2988         https://bugs.webkit.org/show_bug.cgi?id=195810
2989
2990         Reviewed by Tim Horton.
2991
2992         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2993         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2994         ending certain layout tests.
2995
2996         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2997         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2998         (-[TestRunnerWKWebView dealloc]):
2999         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3000
3001         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3002         helper method when destroying the web view, and when resetting state between tests.
3003
3004         * WebKitTestRunner/ios/TestControllerIOS.mm:
3005         (WTR::TestController::platformResetStateToConsistentValues):
3006
3007         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3008
3009 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3010
3011         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3012         https://bugs.webkit.org/show_bug.cgi?id=190350
3013         <rdar://problem/45089503>
3014
3015         Reviewed by Geoffrey Garen.
3016
3017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3018         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3019         (TEST):
3020         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3021         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3022         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3023         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3024         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3025         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3026         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3027         (runTest):
3028         (createDirectories):
3029         (TEST):
3030         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3031         (TEST):
3032         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3033         (TEST):
3034
3035 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3036
3037         Add support to WebPage for getting the contents as an attributed string.
3038         https://bugs.webkit.org/show_bug.cgi?id=195636
3039         rdar://problem/45055697
3040
3041         Reviewed by Tim Horton.
3042
3043         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3044         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3045
3046 2019-03-15  Chris Dumez  <cdumez@apple.com>
3047
3048         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3049         https://bugs.webkit.org/show_bug.cgi?id=195747
3050
3051         Reviewed by Geoff Garen.
3052
3053         Add API test coverage.
3054
3055         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3056
3057 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3058
3059         Unreviewed, rolling out r242952.
3060
3061         Causing API failures on iOS Simulator
3062
3063         Reverted changeset:
3064
3065         "[PSON] Make sure the WebProcessCache is leverage when
3066         relaunching a process after termination"
3067         https://bugs.webkit.org/show_bug.cgi?id=195747
3068         https://trac.webkit.org/changeset/242952
3069
3070 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3071
3072         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3073         https://bugs.webkit.org/show_bug.cgi?id=195740
3074
3075         Reviewed by Ross Kirsling.
3076
3077         window.open doesn't work for WebKitBrowserWindow because it is not
3078         implemented yet.
3079
3080         1. Implemented createNewPage callback of WKPageUIClient.
3081         2. Changed MainWindow to take a BrowserWindow factory function
3082           instead of BrowserWindowType to be flexible to create
3083           BrowserWindow with extra settings.
3084         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3085           because it is not relevant with MainWindow anymore.
3086
3087         * MiniBrowser/win/Common.cpp:
3088         (parseCommandLine):
3089         * MiniBrowser/win/Common.h:
3090         (CommandLineOptions::CommandLineOptions):
3091         * MiniBrowser/win/MainWindow.cpp:
3092         (MainWindow::MainWindow):
3093         (MainWindow::create):
3094         (MainWindow::init):
3095         (MainWindow::WndProc):
3096         * MiniBrowser/win/MainWindow.h:
3097         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3098         (PrintWebUIDelegate::createWebViewWithRequest):
3099         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3100         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3101         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3102         (WebKitBrowserWindow::updateProxySettings):
3103         (WebKitBrowserWindow::createNewPage):
3104         * MiniBrowser/win/WebKitBrowserWindow.h:
3105         * MiniBrowser/win/WinMain.cpp:
3106         (wWinMain):
3107
3108 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3109
3110         Make it possible to test scrolling tree layer manipulation more easily
3111         https://bugs.webkit.org/show_bug.cgi?id=195780
3112
3113         Reviewed by Tim Horton.
3114         
3115         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3116         cuts off communication of scrolling tree scrolls back to the web process
3117         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3118         allows tests to trigger scrolls which run the scrolling tree layer positioning
3119         logic, but never get another commit from the web process that might mask
3120         scrolling tree bugs.
3121         
3122         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3123         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3124         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3125
3126         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3127         (WTR::UIScriptController::scrollUpdatesDisabled const):
3128         (WTR::UIScriptController::setScrollUpdatesDisabled):
3129         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3130         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3131         (WTR::UIScriptController::scrollUpdatesDisabled const):
3132         (WTR::UIScriptController::setScrollUpdatesDisabled):
3133         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3134         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3135         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3136         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3137         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3138         * WebKitTestRunner/ios/TestControllerIOS.mm:
3139         (WTR::TestController::platformResetStateToConsistentValues):
3140         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3141         (WTR::UIScriptController::scrollUpdatesDisabled const):
3142         (WTR::UIScriptController::setScrollUpdatesDisabled):
3143
3144 2019-03-14  Youenn Fablet  <youenn@apple.com>
3145
3146         Move IDB storage in private browsing mode to NetworkProcess
3147         https://bugs.webkit.org/show_bug.cgi?id=195602
3148
3149         Reviewed by Brady Eidson.
3150
3151         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3152         (TEST):
3153
3154 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3155
3156         [ews-build] Make descriptionDone messages more readable
3157         https://bugs.webkit.org/show_bug.cgi?id=195760
3158
3159         Reviewed by Lucas Forschler.
3160
3161         * BuildSlaveSupport/ews-build/steps.py:
3162         * BuildSlaveSupport/ews-build/steps_unittest.py:
3163
3164 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3165
3166         [ews-build] Generate status-bubble hover-over messages
3167         https://bugs.webkit.org/show_bug.cgi?id=195680
3168
3169         Reviewed by Lucas Forschler.
3170
3171         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3172         (StatusBubble):
3173         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3174         on hover-over.
3175         (StatusBubble._iso_time):
3176         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3177         hover-over message.
3178         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3179
3180 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3181
3182         [ews-app] Gracefully handle the case when state_string is None
3183         https://bugs.webkit.org/show_bug.cgi?id=195753
3184
3185         Reviewed by Lucas Forschler.
3186
3187         * BuildSlaveSupport/ews-app/ews/models/build.py:
3188         * BuildSlaveSupport/ews-app/ews/models/step.py:
3189
3190 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3191
3192         [ews-app] Status bubble display pending for currently running build step
3193         https://bugs.webkit.org/show_bug.cgi?id=195744
3194
3195         Reviewed by Lucas Forschler.
3196
3197         * BuildSlaveSupport/ews-build/events.py:
3198         (Events.stepStarted): If state_string is pending, replace it with step name.
3199
3200 2019-03-14  Chris Dumez  <cdumez@apple.com>
3201
3202         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3203         https://bugs.webkit.org/show_bug.cgi?id=195750
3204
3205         Reviewed by Geoffrey Garen.
3206
3207         Add API test coverage.
3208
3209         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3210         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3211         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3212         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3213
3214 2019-03-14  Chris Dumez  <cdumez@apple.com>
3215
3216         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3217         https://bugs.webkit.org/show_bug.cgi?id=195747
3218
3219         Reviewed by Geoff Garen.
3220
3221         Add API test coverage.
3222
3223         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3224
3225 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3226
3227         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3228         https://bugs.webkit.org/show_bug.cgi?id=195725
3229         <rdar://problem/48545062>
3230
3231         Reviewed by Tim Horton.
3232
3233         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3234         handler is nil.
3235
3236         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3237         (TestWebKitAPI::TEST):
3238
3239 2019-03-13  Sam Weinig  <sam@webkit.org>
3240
3241         Add utility function to allow easy reverse range-based iteration of a container
3242         https://bugs.webkit.org/show_bug.cgi?id=195542
3243
3244         Reviewed by Antti Koivisto.
3245
3246         * TestWebKitAPI/CMakeLists.txt:
3247         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3248         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3249         (TestWebKitAPI::TEST):
3250         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3251
3252 2019-03-13  Chris Dumez  <cdumez@apple.com>
3253
3254         Use a ServiceWorker process per registrable domain
3255         https://bugs.webkit.org/show_bug.cgi?id=195649
3256
3257         Reviewed by Youenn Fablet.
3258
3259         Update API test coverage.
3260
3261         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3262
3263 2019-03-13  Chris Dumez  <cdumez@apple.com>
3264
3265         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3266         https://bugs.webkit.org/show_bug.cgi?id=195684
3267         <rdar://problem/48294714>
3268
3269         Reviewed by Antti Koivisto.
3270
3271         Add API test coverage.
3272
3273         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3274
3275 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3276
3277         [ews-app] Remove unused patch view
3278         https://bugs.webkit.org/show_bug.cgi?id=195669
3279
3280         Reviewed by Lucas Forschler.
3281
3282         * BuildSlaveSupport/ews-app/ews/urls.py:
3283         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3284
3285 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3286
3287         [ews-app] Use Buildbot result code variables
3288         https://bugs.webkit.org/show_bug.cgi?id=195668
3289
3290         Reviewed by Alexey Proskuryakov.
3291
3292         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3293         (Buildbot): Added Buildbot result code variables.
3294         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3295         (StatusBubble._build_bubble): Used Buildbot result code variables.
3296
3297 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3298
3299         [Flatpak] Expand submodule recursively
3300         https://bugs.webkit.org/show_bug.cgi?id=195672
3301
3302         Building WPE with flatpak was impossible without that as it was raising an exception.
3303         Also update wpebackend-fdo to match what is built in jhbuild
3304
3305         Reviewed by Philippe Normand.
3306
3307         * flatpak/flatpakutils.py:
3308         (expand_submodules_recurse):
3309         (expand_manifest):
3310         * flatpak/org.webkit.WPEModules.yaml:
3311
3312 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3313
3314         [ews-app] status bubble should be hidden for certain builds
3315         https://bugs.webkit.org/show_bug.cgi?id=194597
3316
3317         Reviewed by Dewei Zhu.
3318
3319         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3320         (StatusBubble._build_bubble):
3321         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3322         because the patch didn't have relevant changes.
3323         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3324         in production yet.
3325
3326 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3327
3328         [Win] Fix a slew of simple clang-cl warnings.
3329         https://bugs.webkit.org/show_bug.cgi?id=195652
3330
3331         Reviewed by Don Olmstead.
3332
3333         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3334         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3335
3336 2019-03-12  Justin Fan  <justin_fan@apple.com>
3337
3338         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3339         https://bugs.webkit.org/show_bug.cgi?id=195518
3340         <rdar://problem/46322356>
3341
3342         Reviewed by Myles C. Maxfield.
3343
3344         * DumpRenderTree/DerivedSources-input.xcfilelist:
3345         * DumpRenderTree/DerivedSources-output.xcfilelist:
3346
3347 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3348
3349         Unreviewed, rolling out r242825.
3350         https://bugs.webkit.org/show_bug.cgi?id=195648
3351
3352         "Broke webkitpy tests with my change to
3353         lldb_dump_class_layout.py" (Requested by rmorisset on
3354         #webkit).
3355
3356         Reverted changeset:
3357
3358         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3359         classes with suspicious padding"
3360         https://bugs.webkit.org/show_bug.cgi?id=195573
3361         https://trac.webkit.org/changeset/242825
3362
3363 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3364
3365         [ews-build] Show status bubbles while the patch is waiting in queue
3366         https://bugs.webkit.org/show_bug.cgi?id=195618
3367
3368         Reviewed by Lucas Forschler.
3369
3370         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3371         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3372         enabled in initial deployment.
3373         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3374         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3375         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3376         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3377         (StatusBubble._build_bubbles_for_patch):
3378
3379 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3380
3381         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3382         https://bugs.webkit.org/show_bug.cgi?id=195573
3383
3384         Reviewed by Simon Fraser.
3385
3386         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3387
3388         * Scripts/dump-class-layout:
3389         (main):
3390         * lldb/lldb_dump_class_layout.py:
3391         (ClassLayout.__init__):
3392         (ClassLayout._compute_padding_recursive):
3393         (LLDBDebuggerInstance.dump_layout_for_classname):
3394         (LLDBDebuggerInstance):
3395         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3396         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3397
3398 2019-03-12  Chris Dumez  <cdumez@apple.com>
3399
3400         Device Orientation access permission should be denied unless explicitly granted by the client
3401         https://bugs.webkit.org/show_bug.cgi?id=195625
3402
3403         Reviewed by Youenn Fablet.
3404
3405         add API test coverage.
3406
3407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3408         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3409         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3410         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3411         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3412         (runDeviceOrientationTest):
3413         (TEST):
3414         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3415         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3416
3417 2019-03-12  Jer Noble  <jer.noble@apple.com>
3418
3419         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3420         https://bugs.webkit.org/show_bug.cgi?id=195137
3421         <rdar://problem/48810307>
3422
3423         Reviewed by Eric Carlson.
3424
3425         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3426         (TestWebKitAPI::TEST):
3427
3428 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3429
3430         [ews-build] Change urls from uat to production
3431         https://bugs.webkit.org/show_bug.cgi?id=195566
3432
3433         Reviewed by Lucas Forschler.
3434
3435         * BuildSlaveSupport/ews-app/ews/config.py:
3436         * BuildSlaveSupport/ews-build/events.py:
3437         * BuildSlaveSupport/ews-build/steps.py:
3438
3439 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3440
3441         [ews-build] change max_builds for local-worker to 1
3442         https://bugs.webkit.org/show_bug.cgi?id=195568
3443
3444         Reviewed by Lucas Forschler.
3445
3446         * BuildSlaveSupport/ews-build/loadConfig.py:
3447
3448 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3449
3450         Fix the build
3451
3452         * TestRunnerShared/spi/PencilKitTestSPI.h:
3453         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3454
3455 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3456
3457         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3458         https://bugs.webkit.org/show_bug.cgi?id=194131
3459
3460         Reviewed by Michael Catanzaro.
3461
3462         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3463         (uriChanged):
3464         (testUnfinishedSubresourceLoad):
3465         (serverCallback):
3466         (beforeAll):
3467
3468 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3469
3470         WTF::Expected should use std::addressof instead of operator&
3471         https://bugs.webkit.org/show_bug.cgi?id=195604
3472
3473         Reviewed by Myles Maxfield.
3474
3475         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3476         (TestWebKitAPI::Unique::Unique):
3477         (TestWebKitAPI::Unique::operator&):
3478         (TestWebKitAPI::TEST):
3479
3480 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3481
3482         Add Optional to Forward.h.
3483         https://bugs.webkit.org/show_bug.cgi?id=195586
3484
3485         Reviewed by Darin Adler.
3486
3487         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3488         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3489         Remove unnecessary includes from headers.
3490
3491 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3492
3493         Add testing API to hit-test and scroll overflow scrollers
3494         https://bugs.webkit.org/show_bug.cgi?id=195278
3495
3496         Reviewed by Antti Koivisto.
3497         
3498         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3499         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3500         
3501         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3502
3503         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3504         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3505         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3506         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3507         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3508         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3509         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3510         (WTR::enclosingScrollViewIncludingSelf):
3511         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3512
3513 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3514
3515         API test WebKit.RequestTextInputContext fails on iOS
3516         https://bugs.webkit.org/show_bug.cgi?id=195585
3517
3518         Reviewed by Wenson Hsieh and Simon Fraser.
3519
3520         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3521         (applyStyle):
3522         (TEST):
3523         Add a viewport, so that the coordinates match up on iOS.
3524         Scroll by moving the UIScrollView's contentOffset.
3525
3526 2019-03-11  Chris Dumez  <cdumez@apple.com>
3527
3528         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3529         https://bugs.webkit.org/show_bug.cgi?id=195506
3530         <rdar://problem/48733477>
3531
3532         Reviewed by Alex Christensen.
3533
3534         Add API test coverage.
3535
3536         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3537
3538 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3539
3540         Adding myself to contributors.json
3541
3542         Unreviewed, addming myself to contributors.json .
3543
3544         * Scripts/webkitpy/common/config/contributors.json:
3545
3546 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3547
3548         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3549         https://bugs.webkit.org/show_bug.cgi?id=195511
3550         <rdar://problem/44873269>
3551
3552         Reviewed by Darin Adler.
3553
3554         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3555         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3556         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3557         (TEST_F):
3558
3559 2019-03-11  Chris Dumez  <cdumez@apple.com>
3560
3561         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3562         https://bugs.webkit.org/show_bug.cgi?id=195561
3563
3564         Reviewed by Youenn Fablet.
3565
3566         Make sure the JS in the test requests for permission to receive device orientation events.
3567
3568         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3569
3570 2019-03-11  Youenn Fablet  <youenn@apple.com>
3571
3572         Allow storage quota increase by default in WTR
3573         https://bugs.webkit.org/show_bug.cgi?id=195541
3574
3575         Reviewed by Geoffrey Garen.
3576
3577         Allow storage quota increase by default in WTR.
3578         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3579         Use this for tests that explicitly need cache increase.
3580
3581         Instead of increasing quota by 2, make sure the next request is
3582         granted by adding all given parameters.
3583
3584         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3585         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3586         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3587         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3588         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3589         * WebKitTestRunner/TestController.cpp:
3590         (WTR::TestController::setAllowStorageQuotaIncrease):
3591         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3592         * WebKitTestRunner/TestController.h:
3593         * WebKitTestRunner/TestInvocation.cpp:
3594         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3595         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3596         (WTR::TestController::cocoaResetStateToConsistentValues):
3597         (WTR::TestController::setAllowStorageQuotaIncrease):
3598         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3599         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3600         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3601
3602 2019-03-11  Xan Lopez  <xan@igalia.com>
3603
3604         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3605         https://bugs.webkit.org/show_bug.cgi?id=194147
3606
3607         Reviewed by Michael Saboff.
3608
3609         To make --32-bit work correctly on Linux/64bit we need to:
3610
3611         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3612         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3613         unfortunately CMake only allows us to do this during
3614         crosscompilation, which is overkill here.
3615         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3616         pkg-config detection module uses the x86 .pc files instead of the
3617         x86_64 ones.
3618         - Set the -m32 flags for the compiler.
3619
3620         * Scripts/webkitdirs.pm:
3621         (generateBuildSystemFromCMakeProject):
3622
3623 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3624
3625         Add MotionMark-1.1 plan file for run-benchmark script.
3626         https://bugs.webkit.org/show_bug.cgi?id=195481
3627
3628         Rubber-stamped by Darin Adler.
3629
3630         Run-benchmark script should support MontionMark-1.1.
3631
3632         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3633
3634 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3635
3636         [ews-app] Add support for submit-to-ews url
3637         https://bugs.webkit.org/show_bug.cgi?id=195477
3638
3639         Reviewed by Lucas Forschler.
3640
3641         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3642         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3643         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3644         * BuildSlaveSupport/ews-app/ews/urls.py:
3645         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3646
3647 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3648
3649         Unreviewed, rolling out r242688, r242643, r242624.
3650
3651         Caused multiple layout test failures and crashes on iOS and macOS.
3652
3653         Reverted changeset:
3654
3655         "requestAnimationFrame should execute before the next frame"
3656         https://bugs.webkit.org/show_bug.cgi?id=177484
3657         https://trac.webkit.org/changeset/242624/webkit
3658
3659         * Tracing/SystemTracePoints.plist:
3660
3661 2019-03-11  John Wilander  <wilander@apple.com>
3662
3663         Resource Load Statistics: Make it possible exclude localhost from classification
3664         https://bugs.webkit.org/show_bug.cgi?id=195474
3665         <rdar://problem/47520577>
3666
3667         Reviewed by Brent Fulgham.
3668
3669         This patch allows for localhost to be excluded from classification and
3670         treatment as a prevalent resource.
3671
3672         The WebKit Tools change adds a new function called
3673         testRunner.setStatisticsIsRunningTest() which can be used to control this
3674         behavior.
3675
3676         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3677         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3678         (WTR::TestRunner::setStatisticsIsRunningTest):
3679         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3680         * WebKitTestRunner/TestController.cpp:
3681         (WTR::TestController::setStatisticsIsRunningTest):
3682         * WebKitTestRunner/TestController.h:
3683         * WebKitTestRunner/TestInvocation.cpp:
3684         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3685
3686 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3687
3688         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3689         https://bugs.webkit.org/show_bug.cgi?id=195560
3690
3691         Reviewed by Lucas Forschler.
3692
3693         * BuildSlaveSupport/ews-build/master.cfg:
3694
3695 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3696
3697         Unreviewed, rolling out r242698.
3698
3699         API test crashes on bots.
3700
3701         Reverted changeset:
3702
3703         "Add a WKContentRuleList variant that uses copied memory
3704         instead of mmap'd shared memory for class A containerized
3705         apps"
3706         https://bugs.webkit.org/show_bug.cgi?id=195511
3707         https://trac.webkit.org/changeset/242698
3708
3709 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3710
3711         [WPE] Enable web process sandbox
3712         https://bugs.webkit.org/show_bug.cgi?id=195169
3713
3714         Reviewed by Daniel Bates.
3715
3716         * wpe/install-dependencies:
3717         * wpe/jhbuild.modules:
3718
3719 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3720
3721         [ews-app] Use port 17000 for worker communication
3722         https://bugs.webkit.org/show_bug.cgi?id=195558
3723
3724         Reviewed by Lucas Forschler.
3725
3726         * BuildSlaveSupport/ews-build/master.cfg:
3727
3728 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3729
3730         [ews-build] unit-tests fail when passwords.json is missing
3731         https://bugs.webkit.org/show_bug.cgi?id=195557
3732
3733         Reviewed by Lucas Forschler.
3734
3735         * BuildSlaveSupport/ews-build/loadConfig.py:
3736         (loadBuilderConfig):
3737         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3738         (ConfigDotJSONTest.test_configuration):
3739         * BuildSlaveSupport/ews-build/master.cfg:
3740
3741 2019-03-11  Truitt Savell  <tsavell@apple.com>
3742
3743         Unreviewed, rolling out r242702.
3744
3745         Broke High Sierra builders.
3746
3747         Reverted changeset:
3748
3749         "Add utility function to allow easy reverse range-based
3750         iteration of a container"
3751         https://bugs.webkit.org/show_bug.cgi?id=195542
3752         https://trac.webkit.org/changeset/242702
3753
3754 2019-03-11  Sam Weinig  <sam@webkit.org>
3755
3756         Add utility function to allow easy reverse range-based iteration of a container
3757         https://bugs.webkit.org/show_bug.cgi?id=195542
3758
3759         Reviewed by Antti Koivisto.
3760
3761         * TestWebKitAPI/CMakeLists.txt:
3762         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3763         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3764         (TestWebKitAPI::TEST):
3765         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3766
3767 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3768
3769         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3770         https://bugs.webkit.org/show_bug.cgi?id=195511
3771         <rdar://problem/44873269>
3772
3773         Reviewed by Darin Adler.
3774
3775         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3776         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3777         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3778         (TEST_F):
3779
3780 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3781
3782         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3783         https://bugs.webkit.org/show_bug.cgi?id=195499
3784
3785         Reviewed by Darin Adler.
3786
3787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3788         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3789         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3790         (-[WKWebView synchronouslyFocusTextInputContext:]):
3791         (applyStyle):
3792         (applyIframe):
3793         (TEST):
3794         Add some tests for this SPI.
3795
3796 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3797
3798         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3799         https://bugs.webkit.org/show_bug.cgi?id=181151
3800
3801         Reviewed by Don Olmstead.
3802
3803         * TestWebKitAPI/CMakeLists.txt:
3804         * TestWebKitAPI/PlatformWin.cmake:
3805         Enable TestWTF RunLoop tests in all platforms.
3806
3807         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3808         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3809         (TestWebKitAPI::DerivedOneShotTimer::fired):
3810         (TestWebKitAPI::TEST):
3811         Only a few platforms support nested RunLoop.
3812
3813         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3814         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3815
3816 2019-03-10  David Quesada  <david_quesada@apple.com>
3817
3818         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3819         https://bugs.webkit.org/show_bug.cgi?id=152480
3820
3821         Reviewed by Chris Dumez.
3822
3823         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3824         there are no additional references to the process pool besides the one held by
3825         the download, waits for the download to finish (in the sense that the
3826         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3827         measure, also check that the process pool has been deallocated at the end of the
3828         test. The test wouldn't be meaningful if the process pool were still alive.
3829
3830         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3831         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3832         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3833             The download will be canceled because the delegate does not implement the
3834             method to decide the download's destination, so this is where we know the
3835             DownloadProxyMap is done with the DownloadProxy.
3836         (TEST):
3837
3838 2019-03-08  Chris Dumez  <cdumez@apple.com>
3839
3840         Add support for Device Orientation / Motion permission API
3841         https://bugs.webkit.org/show_bug.cgi?id=195329
3842         <rdar://problem/47645367>
3843
3844         Reviewed by Geoffrey Garen.
3845
3846         Add test infrastructure to help test the Device Orientation / Motion permission API.
3847
3848         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3849         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3850         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3851         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3852         * WebKitTestRunner/TestController.cpp:
3853         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3854         (WTR::TestController::createWebViewWithOptions):
3855         (WTR::TestController::resetStateToConsistentValues):
3856         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3857         * WebKitTestRunner/TestController.h:
3858         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3859         * WebKitTestRunner/TestInvocation.cpp:
3860         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3861
3862 2019-03-08  Saam barati  <sbarati@apple.com>
3863
3864         Add a compare-results script to compare benchmark results
3865         https://bugs.webkit.org/show_bug.cgi?id=195486
3866         <rdar://problem/48723397>
3867
3868         Reviewed by Geoffrey Garen.
3869
3870         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3871         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3872         to extend it to learn about our other benchmarks.
3873
3874         * Scripts/compare-results: Added.
3875         (readJSONFile):
3876         (detectJetStream2):
3877         (JetStream2Results):
3878         (detectSpeedometer2):
3879         (Speedometer2Results):
3880         (detectPLT5):
3881         (PLT5Results):
3882         (detectBenchmark):
3883         (biggerIsBetter):
3884         (ttest):
3885         (getOptions):
3886         (main):
3887
3888 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3889
3890         Ensure old tab state is cleared between iterations of run-benchmark
3891         https://bugs.webkit.org/show_bug.cgi?id=195393
3892         <rdar://problem/46885583>
3893
3894         Reviewed by Dewei Zhu.
3895
3896         a) ensure the default to restore state is not set
3897         b) terminate Safari correctly
3898         c) Set the system default to ignore Persistent State in Safari
3899
3900         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3901         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3902         (OSXBrowserDriver.prepare_env): 
3903         (OSXBrowserDriver.restore_env):
3904         (OSXBrowserDriver.close_browsers):
3905         (OSXBrowserDriver._terminate_processes):
3906         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3907         (OSXChromeDriver):
3908         (OSXChromeCanaryDriver):
3909         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3910         (OSXFirefoxDriver):
3911         (OSXFirefoxNightlyDriver):
3912         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3913         (OSXSafariDriver):
3914         (OSXSafariDriver.prepare_env):
3915
3916 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3917
3918         [GTK] Several InputMethodFilter tests are failing
3919         https://bugs.webkit.org/show_bug.cgi?id=195408
3920
3921         Reviewed by Carlos Garcia Campos.
3922
3923         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3924         Regressed in r241751.
3925         Hexadecimal values of keycodes are expressed now in upper letters.
3926         Composited characters should be cast to UTF8 strings.
3927
3928         (TestWebKitAPI::TEST):
3929
3930 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3931
3932         [GTK] Make Tools/gtkdoc python3 compatible
3933         https://bugs.webkit.org/show_bug.cgi?id=195359
3934
3935         Reviewed by Carlos Garcia Campos.
3936
3937         * gtkdoc/generate-gtkdoc:
3938         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3939         work with Python 2 and 3.
3940         (get_gtkdoc_module_paths):
3941         The iteritems() was removed in Python 3, so let's use items() that's
3942         available in Python 2 and 3.
3943         (get_generator_for_config):
3944         * gtkdoc/gtkdoc.py:
3945         (GTKDoc._run_command):
3946         The sys.stdout.write() is expecting str in Python 3 and not bytes
3947         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3948         for passing the bytes there.
3949
3950 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3951
3952         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3953         https://bugs.webkit.org/show_bug.cgi?id=195346
3954         <rdar://problem/48667048>
3955
3956         Unreviewed build fix for clang-cl.
3957
3958         * DumpRenderTree/win/DumpRenderTree.cpp:
3959         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3960
3961 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3962
3963         requestAnimationFrame should execute before the next frame
3964         https://bugs.webkit.org/show_bug.cgi?id=177484
3965
3966         Reviewed by Simon Fraser.
3967
3968         Add trace points for the page RenderingUpdate.
3969
3970         * Tracing/SystemTracePoints.plist:
3971
3972 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3973
3974         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3975         https://bugs.webkit.org/show_bug.cgi?id=195353
3976         <rdar://problem/48626394>
3977
3978         Reviewed by Simon Fraser.
3979
3980         * WebKitTestRunner/ios/TestControllerIOS.mm:
3981         (WTR::TestController::platformResetPreferencesToConsistentValues):
3982
3983 2019-03-07  John Wilander  <wilander@apple.com>
3984
3985         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3986         https://bugs.webkit.org/show_bug.cgi?id=195383
3987         <rdar://problem/48570136>
3988
3989         Reviewed by Brent Fulgham.
3990
3991         This patch adds test infrastructure to purge only script-accessible cookies,
3992         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3993
3994         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3995         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3996         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3997         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3998         * WebKitTestRunner/TestController.cpp:
3999         (WTR::TestController::statisticsDeleteCookiesForHost):
4000         * WebKitTestRunner/TestController.h:
4001         * WebKitTestRunner/TestInvocation.cpp:
4002         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4003
4004 2019-03-07  Commit Queue  <commit-queue@webkit.org>
4005
4006         Unreviewed, rolling out r242354.
4007         https://bugs.webkit.org/show_bug.cgi?id=195402
4008
4009         breaks layout tests in all configurations (Requested by
4010         zdobersek on #webkit).
4011
4012         Reverted changeset:
4013
4014         "[WPE] Enable web process sandbox"
4015         https://bugs.webkit.org/show_bug.cgi?id=195169
4016         https://trac.webkit.org/changeset/242354
4017
4018 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
4019
4020         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4021         https://bugs.webkit.org/show_bug.cgi?id=195346
4022
4023         Reviewed by Fujii Hironori.
4024
4025         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
4026         (TestWebKitAPI::TEST):
4027         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
4028
4029         * DumpRenderTree/win/DumpRenderTree.cpp:
4030         (findFontFallback):
4031         (addFontFallbackIfPresent):
4032         (removeFontFallbackIfPresent):
4033         (main):
4034         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4035         (TestWebKitAPI::Util::moduleDirectory):
4036         (TestWebKitAPI::Util::createInjectedBundlePath):
4037         Use wchar helpers as needed.
4038
4039 2019-03-06  Rob Buis  <rbuis@igalia.com>
4040
4041         Consider supporting the `referrerpolicy` attribute.
4042         https://bugs.webkit.org/show_bug.cgi?id=179053
4043
4044         Reviewed by Darin Adler.
4045
4046         Add a runtime flag for referrerpolicy attribute.
4047
4048         * DumpRenderTree/mac/DumpRenderTree.mm:
4049         (enableExperimentalFeatures):
4050
4051 2019-03-05  Daniel Bates  <dabates@apple.com>
4052
4053         Update expected API test result following r242379
4054         (https://bugs.webkit.org/show_bug.cgi?id=195125)
4055
4056         Update expected x-coordinate of selection rect now that the left padding of
4057         a textarea is sized in ems (so dependent on the font size) just like the left
4058         padding of a text field.
4059
4060         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4061         (TestWebKitAPI::TEST):
4062
4063 2019-03-05  David Quesada  <david_quesada@apple.com>
4064
4065         [WK2] It should be possible to follow links with 'download' attributes
4066         https://bugs.webkit.org/show_bug.cgi?id=195145
4067         rdar://problem/48462642
4068
4069         Reviewed by Alex Christensen.
4070
4071         Add a unit test to verify that activating links with 'download' attributes now
4072         navigates to the linked resource, rather than starts downloading it. Add another
4073         to verify that it is still possible to explicitly download the link via the
4074         'Download' navigation action policy.
4075
4076         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4077         (-[DownloadAttributeTestDelegate init]):
4078         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
4079         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
4080         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
4081         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
4082         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4083         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
4084         (TEST):
4085         * WebKitTestRunner/TestController.cpp:
4086         (WTR::TestController::decidePolicyForNavigationAction):
4087         * WebKitTestRunner/TestController.h:
4088
4089 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
4090
4091         [Curl] Implement Cookie Accept Policy.
4092         https://bugs.webkit.org/show_bug.cgi?id=191645
4093
4094         Reviewed by Fujii Hironori.
4095
4096         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4097         (TestWebKitAPI::Curl::TEST_F):
4098
4099 2019-03-05  Youenn Fablet  <youenn@apple.com>
4100
4101         Rename requestCacheStorageSpace to requestStorageSpace
4102         https://bugs.webkit.org/show_bug.cgi?id=195282
4103
4104         Reviewed by Chris Dumez.
4105
4106         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4107         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4108         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
4109
4110 2019-03-05  Brady Eidson  <beidson@apple.com>
4111
4112         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
4113         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
4114
4115         Reviewed by Tim Horton.
4116
4117         Loading a file: URL into a WKWebView and then loading another file: url from a completely
4118         different directory into that same WKWebView should work.
4119
4120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4121         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
4122
4123 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
4124
4125         Add WeakHashSet
4126         https://bugs.webkit.org/show_bug.cgi?id=195152
4127
4128         Reviewed by Antti Koivisto.
4129
4130         Added tests for WeakHashSet.
4131
4132         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4133         (TestWebKitAPI::Base::Base): Moved.
4134         (TestWebKitAPI::Derived::foo): Moved.
4135         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
4136         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
4137         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
4138         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
4139
4140 2019-03-04  Chris Dumez  <cdumez@apple.com>
4141
4142         Do not share WebProcesses between private and regular sessions
4143         https://bugs.webkit.org/show_bug.cgi?id=195189
4144         <rdar://problem/48421064>
4145
4146         Reviewed by Alex Christensen.
4147
4148         Add API test coverage.
4149
4150         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4151         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4152
4153 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
4154
4155         [WPE] Enable web process sandbox
4156         https://bugs.webkit.org/show_bug.cgi?id=195169
4157
4158         Reviewed by Daniel Bates.
4159
4160         * wpe/install-dependencies:
4161         * wpe/jhbuild.modules:
4162
4163 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4164
4165         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
4166         https://bugs.webkit.org/show_bug.cgi?id=195206
4167
4168         Reviewed by Žan Doberšek.
4169
4170         Add a new test case.
4171
4172         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4173         (testJSCClass):
4174
4175 2019-03-04  Charlie Turner  <cturner@igalia.com>
4176
4177         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
4178         https://bugs.webkit.org/show_bug.cgi?id=194898
4179
4180         Reviewed by Žan Doberšek.
4181
4182         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
4183         a GCC extension that permits arithmetic on void* pointer. Inline
4184         the macro until this issue is fixed upstream.
4185
4186 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4187
4188         Rid the world of WK_API_ENABLED
4189         https://bugs.webkit.org/show_bug.cgi?id=195263
4190
4191         Reviewed by Dan Bernstein.
4192
4193         List of changed files elided because it's useless.
4194
4195 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4196
4197         Unreviewed follow-up to r242292.
4198
4199         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4200
4201         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4202         (TestWebKitAPI::testStrip): Renamed from strip.
4203         (TestWebKitAPI::TEST):
4204
4205 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4206
4207         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4208
4209         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4210         and bug #194272 for details.
4211
4212         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4213
4214 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4215
4216         Remove some more unused 32-bit code
4217         https://bugs.webkit.org/show_bug.cgi?id=195255
4218
4219         Reviewed by Darin Adler.
4220
4221         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4222         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4223         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4224         (NPP_New):
4225         (NPP_HandleEvent):
4226         (handleEventCarbon): Deleted.
4227
4228 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4229
4230         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4231
4232         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4233         (TestWebKitAPI::TEST):
4234
4235 2019-03-01  Darin Adler  <darin@apple.com>
4236
4237         Finish removing String::format
4238         https://bugs.webkit.org/show_bug.cgi?id=194893
4239
4240         Reviewed by Daniel Bates.
4241 '
4242         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4243
4244 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4245
4246         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4247         https://bugs.webkit.org/show_bug.cgi?id=195229
4248         <rdar://problem/48520362>
4249
4250         Reviewed by Chris Dumez.
4251
4252         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4253         (TEST):
4254
4255 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4256
4257         Add a system trace scope for event region building
4258         https://bugs.webkit.org/show_bug.cgi?id=195226
4259
4260         Reviewed by Jon Lee.
4261
4262         This trace scope measures the time spend converting element rects into Region objects,
4263         which can be large on some pages.
4264
4265         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4266
4267         * Tracing/SystemTracePoints.plist:
4268
4269 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4270
4271         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4272         https://bugs.webkit.org/show_bug.cgi?id=194612
4273
4274         Reviewed by Alex Christensen.
4275
4276         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4277         Just test the new string-processing function and don't touch the actual environment.
4278         (Test cases are all as before, but based on operator== instead of strcmp.)
4279
4280 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4281
4282         [ews-app] Update primary keys for handling multiple Buildbot instances
4283         https://bugs.webkit.org/show_bug.cgi?id=195120
4284
4285         Reviewed by Stephanie Lewis.
4286
4287         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4288         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4289         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4290
4291         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4292         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4293         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4294         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4295         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4296         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4297
4298 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4299
4300         [WinCairo] Enable service worker
4301         https://bugs.webkit.org/show_bug.cgi?id=188318
4302
4303         Reviewed by Youenn Fablet.
4304
4305         * DumpRenderTree/DumpRenderTreePrefix.h:
4306         * TestWebKitAPI/PlatformWin.cmake:
4307         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4308         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4309         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4310
4311 2019-03-01  Justin Fan  <justin_fan@apple.com>
4312
4313         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4314         https://bugs.webkit.org/show_bug.cgi?id=195191
4315
4316         Rubber-stamped by Dean Jackson.
4317
4318         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4319
4320         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4321
4322 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4323
4324         Unreviewed, fix lldb webkitpy tests
4325         https://bugs.webkit.org/show_bug.cgi?id=194375
4326
4327         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4328
4329         * lldb/lldb_webkit.py:
4330         (WTFStringImplProvider.is_8bit):
4331
4332 2019-02-28  David Quesada  <david_quesada@apple.com>
4333
4334         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4335         https://bugs.webkit.org/show_bug.cgi?id=195121
4336         rdar://problem/48450302
4337
4338         Reviewed by Alex Christensen.
4339
4340         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4341         configurations where the 'download' attribute is absent, blank, or populated
4342         with a filename, and where the anchor element is same-origin or cross-origin
4343         (meaning the 'download' attribute shouldn't be honored).
4344
4345         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4346         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4347         (-[NavigationActionTestDelegate init]):
4348         (-[NavigationActionTestDelegate navigationAction]):
4349         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4350         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4351         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4352         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4353         (TEST):
4354
4355 2019-02-28  Antoine Quint  <graouts@apple.com>
4356
4357         Enable the Pointer Events runtime flag by default
4358         https://bugs.webkit.org/show_bug.cgi?id=195156
4359
4360         Reviewed by Dean Jackson.
4361
4362         * DumpRenderTree/mac/DumpRen