JSC should have a "microbenchmarks" directory instead of "regress" directory
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-23  Saam Barati  <sbarati@apple.com>
2
3         JSC should have a "microbenchmarks" directory instead of "regress" directory
4         https://bugs.webkit.org/show_bug.cgi?id=161096
5
6         Rubber stamped by Mark Lam.
7
8         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
9         directory and removes all the related html and txt files. I did this because
10         that directory was only there for microbenchmarks, and not for "regression"
11         tests. I also changed the various scripts to point to it.
12
13         * Scripts/run-javascriptcore-tests:
14         (runJSCStressTests):
15         * Scripts/run-jsc-benchmarks:
16
17 2016-08-23  Alex Christensen  <achristensen@webkit.org>
18
19         Fix EFL build.
20
21         * TestWebKitAPI/CMakeLists.txt:
22         Include new directory.
23
24 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
25
26         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
27         https://bugs.webkit.org/show_bug.cgi?id=160125
28
29         Reviewed by Geoffrey Garen.
30
31         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
32         * Scripts/run-jsc-stress-tests: New test flag!
33
34 2016-08-23  Brady Eidson  <beidson@apple.com>
35
36         WK2 Gamepad layout test support.
37         https://bugs.webkit.org/show_bug.cgi?id=134671
38
39         Reviewed by Alex Christensen.
40         
41         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then 
42         feed back into the UIGamepadProvider.
43         
44         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
45         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
46
47         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
48         
49         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
50         (WTR::TestRunner::setMockGamepadDetails):
51         (WTR::TestRunner::setMockGamepadAxisValue):
52         (WTR::TestRunner::setMockGamepadButtonValue):
53         
54         * WebKitTestRunner/PlatformWebView.h:
55         
56         * WebKitTestRunner/TestController.cpp:
57         (WTR::TestController::initialize):
58         
59         * WebKitTestRunner/TestInvocation.cpp:
60         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
61         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
62         
63         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
64         
65         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
66         (-[WebKitTestRunnerWindow initWithFrame:]):
67         (-[WebKitTestRunnerWindow dealloc]):
68         (WTR::PlatformWebView::keyWindow):
69         
70         * WebKitTestRunner/ios/TestControllerIOS.mm:
71         (WTR::wtr_NSApplication_keyWindow):
72         (WTR::TestController::platformInitialize):
73         
74         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
75         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
76         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
77         (-[WebKitTestRunnerWindow dealloc]):
78         (WTR::PlatformWebView::keyWindow):
79         
80         * WebKitTestRunner/mac/TestControllerMac.mm:
81         (WTR::wtr_NSApplication_keyWindow):
82         (WTR::TestController::platformInitialize):
83         * WebKitTestRunner/mac/main.mm:
84
85 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
86
87         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
88         https://bugs.webkit.org/show_bug.cgi?id=161047
89         rdar://problem/27434307
90
91         Reviewed by Lucas Forschler.
92
93         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
94
95 2016-08-23  Chris Dumez  <cdumez@apple.com>
96
97         Unreviewed, rolling out r204243.
98
99         Caused some layout test failures
100
101         Reverted changeset:
102
103         "Write API test to cover crash fix in r204135"
104         https://bugs.webkit.org/show_bug.cgi?id=160587
105         http://trac.webkit.org/changeset/204243
106
107 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
108
109         Order feature option list in FeatureList.pm
110         https://bugs.webkit.org/show_bug.cgi?id=161074
111
112         Reviewed by Michael Catanzaro.
113
114         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
115
116         * Scripts/webkitperl/FeatureList.pm:
117
118 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
119
120         Stop python icon bouncing in the dock while running browser benchmarks.
121         https://bugs.webkit.org/show_bug.cgi?id=161066
122
123         Reviewed by Ryosuke Niwa.
124
125         Bouncing python icon may impact browser benchmark results.
126         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
127         (OSXBrowserDriver.prepare_env):
128         (OSXBrowserDriver.restore_env):
129
130 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
131
132         <select> menu on iPad causes shifting of hit-testing areas
133         https://bugs.webkit.org/show_bug.cgi?id=150079
134
135         Reviewed by Tim Horton.
136
137         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
138         so when it changes we have to update visible rects. We were doing this on focus, but failing
139         to do it on blur.
140
141         Added the ability to test by:
142         1. Making it possible to initiate an animated scroll in the UI process
143         2. Adding callbacks for starting and ending interaction with a form control. Sadly
144         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
145         have no way currently to know when the dimming view behind the popover animates out,
146         so for now the test keeps trying to tap a button.
147
148         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
149         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
150         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
151         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
152         (WTR::UIScriptController::didStartFormControlInteractionCallback):
153         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
154         (WTR::UIScriptController::didEndFormControlInteractionCallback):
155         (WTR::UIScriptController::scrollToOffset):
156         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
157         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
158         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
159         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
160         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
161         (-[TestRunnerWKWebView dealloc]):
162         (-[TestRunnerWKWebView didStartFormControlInteraction]):
163         (-[TestRunnerWKWebView didEndFormControlInteraction]):
164         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
165         (WTR::contentOffsetBoundedInValidRange):
166         (WTR::UIScriptController::scrollToOffset):
167         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
168         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
169
170 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
171
172         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
173         https://bugs.webkit.org/show_bug.cgi?id=160927
174
175         Reviewed by Daniel Bates.
176
177         * Scripts/process-linux-coredump: Removed.
178         * Scripts/webkitpy/port/efl.py:
179         (EflPort._get_crash_log):
180         * Scripts/webkitpy/port/gtk.py:
181         (GtkPort._get_crash_log):
182         * Scripts/webkitpy/port/linux_get_crash_log.py:
183         (GDBCrashLogGenerator.__init__):
184         (GDBCrashLogGenerator.generate_crash_log):
185         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
186         (GDBCrashLogGeneratorTest.test_generate_crash_log):
187
188 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
189
190         check-webkit-style does not work with Lambda functions in C++
191         https://bugs.webkit.org/show_bug.cgi?id=160910
192
193         Reviewed by Darin Adler.
194
195         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
196
197         * Scripts/webkitpy/style/checkers/cpp.py:
198         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
199         (check_for_non_standard_constructs): Added lambda function check.
200         (check_spacing_for_function_call): Added lambda function check.
201         (check_braces): Added lambda function check.
202         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
203         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
204
205 2016-08-21  Alex Christensen  <achristensen@webkit.org>
206
207         URLParser should parse IPv4 addresses
208         https://bugs.webkit.org/show_bug.cgi?id=161023
209
210         Reviewed by Darin Adler.
211
212         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
213         (TestWebKitAPI::TEST_F):
214         (TestWebKitAPI::checkURLDifferences):
215         We are already getting differences between the old URL::parse and the new URLParser.
216         (TestWebKitAPI::shouldFail):
217
218 2016-08-21  Daniel Bates  <dabates@apple.com>
219
220         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
221         https://bugs.webkit.org/show_bug.cgi?id=148437
222
223         Reviewed by Dan Bernstein.
224
225         * Scripts/prepare-ChangeLog:
226         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
227         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
228         assumes that its line ranges were from a unified diff without any context lines.
229         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
230         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
231         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
232         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
233         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
234         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
235         to /dev/null for the duration of the function call.
236
237 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
238
239         [EFL] Remove unnecessary a patch to mute ecore warnings
240         https://bugs.webkit.org/show_bug.cgi?id=160997
241
242         Reviewed by Darin Adler.
243
244         There is no warning messages during the layout test and perf test
245         after bumping efl version from 1.17 to 1.18. Remove it.
246
247         * efl/patches/ecore_remove_warnings.patch: Removed.
248
249 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
250
251         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
252         https://bugs.webkit.org/show_bug.cgi?id=160985
253
254         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
255         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
256         with that.
257
258         * Scripts/webkitpy/layout_tests/views/printing.py:
259         (Printer.print_config):
260         * Scripts/webkitpy/port/base.py:
261         (Port.driver_cmd_line_for_logging):
262         (Port.driver_cmd_line): Deleted.
263         * Scripts/webkitpy/port/driver.py:
264         (IOSSimulatorDriver.cmd_line):
265         * Scripts/webkitpy/port/ios.py:
266         (IOSSimulatorPort.__init__):
267         (IOSSimulatorPort.driver_cmd_line_for_logging):
268         (IOSSimulatorPort._create_simulators):
269         (IOSSimulatorPort.setup_test_run):
270         (IOSSimulatorPort._quit_ios_simulator):
271         (IOSSimulatorPort.clean_up_test_run):
272         (IOSSimulatorPort._create_device):
273         (IOSSimulatorPort):
274         (IOSSimulatorPort._remove_device):
275         (IOSSimulatorPort._testing_device):
276         (IOSSimulatorPort.device_id_for_worker_number):
277         (IOSSimulatorPort._set_device_class): Deleted.
278         (IOSSimulatorPort.testing_device): Deleted.
279         * Scripts/webkitpy/port/port_testcase.py:
280         (PortTestCase.test_driver_cmd_line):
281         * Scripts/webkitpy/xcode/simulator.py:
282         (Device.shutdown):
283         (Device):
284         (Device.delete):
285         (Device.reset):
286         (Simulator):
287         (Simulator.create_device):
288         (Simulator.remove_device):
289         (Simulator.device_number):
290         (Simulator.device_state_description):
291         (Simulator.wait_until_device_is_in_state):
292
293 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
294
295         Unreviewed, rolling out r204659.
296
297         This change appears to have caused ios-simulator LayoutTests
298         to fail when shutting down the simulator
299
300         Reverted changeset:
301
302         "REGRESSION (r204477): Running LayoutTests on ios-simulator
303         became ~15 minutes slower"
304         https://bugs.webkit.org/show_bug.cgi?id=160985
305         http://trac.webkit.org/changeset/204659
306
307 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
308
309         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
310         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
311
312 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
313
314         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
315         https://bugs.webkit.org/show_bug.cgi?id=160985
316
317         Reviewed by Alexey Proskuryakov.
318         
319         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
320         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
321         must not be @memoized, because their return value depends on the value of simulator_device_type().
322         
323         Fix by adding some global state in simulator.py that tracks the created devices 
324         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
325         and delete them in clean_up_test_run().
326         
327         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
328         that killing the Simulator apps isn't enough.
329         
330         Simulator tracks the devices in a global dictionary, since state needs to persist
331         across different instances of IOSSimulatorPort.
332         
333         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
334         any setup. Rather than implicitly creating a device here (which the old code did),
335         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
336         and set flag to say that device_id_for_worker_number() doesn't need to return a real
337         device id.
338
339         * Scripts/webkitpy/layout_tests/views/printing.py:
340         (print_options):
341         (Printer.print_config):
342         * Scripts/webkitpy/port/base.py:
343         (Port.driver_cmd_line_for_logging):
344         (Port.driver_cmd_line): Deleted.
345         * Scripts/webkitpy/port/driver.py:
346         (IOSSimulatorDriver.cmd_line):
347         * Scripts/webkitpy/port/ios.py:
348         (IOSSimulatorPort.__init__):
349         (IOSSimulatorPort.driver_cmd_line_for_logging):
350         (IOSSimulatorPort._create_simulators):
351         (IOSSimulatorPort.setup_test_run):
352         (IOSSimulatorPort.clean_up_test_run):
353         (IOSSimulatorPort._create_device):
354         (IOSSimulatorPort):
355         (IOSSimulatorPort._remove_device):
356         (IOSSimulatorPort._testing_device):
357         (IOSSimulatorPort.device_id_for_worker_number):
358         (IOSSimulatorPort._set_device_class): Deleted.
359         (IOSSimulatorPort.testing_device): Deleted.
360         * Scripts/webkitpy/port/port_testcase.py:
361         (PortTestCase.test_driver_cmd_line):
362         * Scripts/webkitpy/xcode/simulator.py:
363         (Device.shutdown):
364         (Device.delete):
365         (Device.reset):
366         (Simulator.create_device):
367         (Simulator.remove_device):
368         (Simulator.device_number):
369         (Simulator.device_state_description):
370         (Simulator.wait_until_device_is_in_state):
371
372 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
373
374         Adopt SimServiceContext in LayoutTestRelay
375         https://bugs.webkit.org/show_bug.cgi?id=161000
376         <rdar://problem/25765594>
377
378         Reviewed by Daniel Bates.
379
380         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
381         * LayoutTestRelay/LayoutTestRelay/main.m:
382
383 2016-08-19  Lucas Forschler  <lforschler@apple.com>
384
385         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
386
387         Reviewed by Kocsen Chung.
388
389         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
390         (WebKitBuildbot):
391
392 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
393
394         Partial revert of r203811 - this key is not needed.
395
396         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
397
398 2016-08-19  Daniel Bates  <dabates@apple.com>
399
400         Another attempt to fix the iOS 9.3 build
401
402         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
403
404         * DumpRenderTree/mac/Configurations/Base.xcconfig:
405         * WebKitTestRunner/Configurations/Base.xcconfig:
406
407 2016-08-19  Lucas Forschler  <lforschler@apple.com>
408
409         Remove Yosemite Leaks bot from config.json
410         
411         Reviewed by Alexey Proskuryakov.
412
413         * BuildSlaveSupport/build.webkit.org-config/config.json:
414
415 2016-08-18  Dan Bernstein  <mitz@apple.com>
416
417         [Cocoa] API::Number needs to be wrapped by an NSNumber
418         https://bugs.webkit.org/show_bug.cgi?id=160977
419         <rdar://problem/27877735>
420
421         Reviewed by Anders Carlsson.
422
423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
424         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
425         (TestWebKitAPI::TEST):
426
427 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
428
429         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
430         https://bugs.webkit.org/show_bug.cgi?id=160895
431
432         Reviewed by Dean Jackson.
433
434         Link to the existing CoreText framework.
435
436         * DumpRenderTree/PlatformWin.cmake:
437         * TestWebKitAPI/PlatformWin.cmake:
438
439 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
440
441         [Win] Remove old libraries from build inputs
442         https://bugs.webkit.org/show_bug.cgi?id=160949
443
444         Reviewed by Dean Jackson.
445
446         Modify the download script to remove the old 'icuuc.lib' and
447         'icuin.lib' files for Windows builds.
448
449         * Scripts/update-webkit-auxiliary-libs:
450
451 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
452
453         Extra logging for crash reason
454         https://bugs.webkit.org/show_bug.cgi?id=160943
455
456         Reviewed by Alexey Proskuryakov.
457
458         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
459
460         * Scripts/webkitpy/port/server_process.py:
461         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
462         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
463         (ServerProcess.has_crashed): Ditto.
464
465 2016-08-17  Dan Bernstein  <mitz@apple.com>
466
467         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
468         https://bugs.webkit.org/show_bug.cgi?id=160938
469         <rdar://problem/27876652>
470
471         Reviewed by Anders Carlsson.
472
473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
474         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
475         (TestWebKitAPI::TEST):
476
477 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
478
479         AX: Support abbreviations in iOS
480         https://bugs.webkit.org/show_bug.cgi?id=160907
481
482         Reviewed by Joanmarie Diggs.
483
484         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
485         (AccessibilityUIElement::stringAttributeValue):
486         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
487         (WTR::AccessibilityUIElement::stringAttributeValue):
488
489 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
490
491         [EFL] Bump efl version from 1.17 to 1.18
492         https://bugs.webkit.org/show_bug.cgi?id=160899
493
494         Reviewed by Antonio Gomes.
495
496         To use efl-1.18, EFL port needs to update install dependencies as well.
497
498         * efl/install-dependencies:
499         * efl/jhbuild.modules:
500
501 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
502
503         [Win] Add tests for linked fonts.
504         https://bugs.webkit.org/show_bug.cgi?id=160898
505
506         Reviewed by Brent Fulgham.
507
508         Add tests for https://trac.webkit.org/changeset/204502.
509
510         * TestWebKitAPI/PlatformWin.cmake:
511         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
512         (TestWebKitAPI::TEST):
513
514 2016-08-16  Daniel Bates  <dabates@apple.com>
515
516         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
517         https://bugs.webkit.org/show_bug.cgi?id=160924
518
519         Reviewed by Stephanie Lewis.
520
521         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
522         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
523         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
524         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
525         object that mocks out the file system and SCM operations.
526
527         * Scripts/VCSUtils.pm:
528         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
529         * Scripts/prepare-ChangeLog:
530         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
531         abstracting the logic to query the file system and SCM into functions on a delegate object that
532         we pass to it.
533         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
534         (diffHeaderFormat): Deleted.
535
536 2016-08-16  Alex Christensen  <achristensen@webkit.org>
537
538         URLParser should parse URLs without credentials
539         https://bugs.webkit.org/show_bug.cgi?id=160913
540
541         Reviewed by Brady Eidson.
542
543         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
544         (TestWebKitAPI::s):
545         (TestWebKitAPI::checkURL):
546         (TestWebKitAPI::TEST_F):
547
548 2016-08-16  Anders Carlsson  <andersca@apple.com>
549
550         Add WTF::ScopeExit
551         https://bugs.webkit.org/show_bug.cgi?id=160908
552
553         Reviewed by Geoffrey Garen.
554
555         * TestWebKitAPI/CMakeLists.txt:
556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
557         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
558         (TestWebKitAPI::TEST):
559
560 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
561
562         EWS logs file are rotated too quickly
563         https://bugs.webkit.org/show_bug.cgi?id=160724
564
565         Reviewed by Daniel Bates.
566
567         Currently we are rotating the log file after 10 iterations of queue. If the queue
568         doesn't have any pending patches, these iterations result in very small amount of 
569         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
570         This results in a lot of log files in a day. This patch ensures that we rotate the
571         log file when its file size is greater than or equal to 100 KB.
572
573         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
574
575 2016-08-16  Daniel Bates  <dabates@apple.com>
576
577         WKSI static library should be named by major iOS revision, not individual updates
578         https://bugs.webkit.org/show_bug.cgi?id=160727
579         <rdar://problem/22274848>
580
581         Reviewed by Alexey Proskuryakov.
582
583         * DumpRenderTree/mac/Configurations/Base.xcconfig:
584         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
585         * Scripts/copy-webkitlibraries-to-product-directory:
586         * WebKitTestRunner/Configurations/Base.xcconfig:
587         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
588
589 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
590
591         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
592         https://bugs.webkit.org/show_bug.cgi?id=160909
593
594         Reviewed by Enrica Casucci.
595         
596         Add functions to UIScriptController to dismiss the form accessory view for iOS,
597         and to programmatically pick a row from a <select> picker.
598
599         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
600         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
601         (WTR::UIScriptController::dismissFormAccessoryView):
602         (WTR::UIScriptController::selectFormAccessoryPickerRow):
603         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
604         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
605         (WTR::UIScriptController::dismissFormAccessoryView):
606         (WTR::UIScriptController::selectFormAccessoryPickerRow):
607
608 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
609
610         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
611         https://bugs.webkit.org/show_bug.cgi?id=160878
612
613         Reviewed by Tim Horton.
614         
615         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
616         now that we have the ability to run tests in the iPad simulator.
617
618         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
619         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
620         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
621         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
622         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
623         * WebKitTestRunner/ios/TestControllerIOS.mm:
624         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
625         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
626         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
627         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
628
629 2016-08-15  Anders Carlsson  <andersca@apple.com>
630
631         Add an address-of operator to RetainPtr
632         https://bugs.webkit.org/show_bug.cgi?id=160879
633
634         Reviewed by Tim Horton.
635
636         Test HashMap and HashSet with an object whose operator& is deleted.
637
638         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
639         Sort the Xcode project.
640
641         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
642         (DeletedAddressOfOperator::DeletedAddressOfOperator):
643         (DeletedAddressOfOperator::value):
644         (DeletedAddressOfOperator::operator==):
645         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
646         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
647         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
648         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
649         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
650         (TestWebKitAPI::TEST):
651         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
652         (TestWebKitAPI::TEST):
653
654 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
655
656         False crashes in fast/text/emoji-gender-* tests
657         https://bugs.webkit.org/show_bug.cgi?id=160779
658
659         Reviewed by Alexey Proskuryakov.
660
661         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
662
663         * Scripts/webkitpy/port/driver.py:
664         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
665         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
666         * Scripts/webkitpy/port/server_process.py:
667         (ServerProcess.write): Allow caller to disable crash flag on exception.
668
669 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
670
671         webkitpy error in TestRunResults.merge()
672         https://bugs.webkit.org/show_bug.cgi?id=160882
673
674         Reviewed by Daniel Bates.
675         
676         The argument to TestRunResults.merge() can be None if there are no device-specifc
677         initial results or retry results in Manager.run(), so just return early in that case.
678
679         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
680         (TestRunResults.merge):
681
682 2016-08-15  Sam Weinig  <sam@webkit.org>
683
684         Speed up compile times by not including wtf/Variant.h so much
685         https://bugs.webkit.org/show_bug.cgi?id=160847
686
687         Reviewed by Alex Christensen and Saam Barati.
688
689         * TestWebKitAPI/Tests/WTF/Variant.cpp:
690         (TestWebKitAPI::TEST):
691         Explicitly use std::experimental::variant.
692
693 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
694
695         Allow a port to run tests with a custom device setup
696         https://bugs.webkit.org/show_bug.cgi?id=160833
697
698         Reviewed by Daniel Bates.
699
700         These changes allow the IOSSimulator port to run tests in iPad mode.
701
702         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
703         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
704         a custom device will be collected into a set, and run in that device's environment after
705         the other tests have run.
706
707         * Scripts/webkitpy/layout_tests/controllers/manager.py:
708         (Manager._custom_device_for_test): If the test contains a directory matching a
709         custom device suffix, return that custom device.
710         (Manager._set_up_run): Push the custom device class, if any, into options so
711         that the Worker can get to it.
712         (Manager.run): Go through the list of tests, and break it down into device-generic
713         tests, and tests for each device class. _run_test_subset is then called for
714         each collection of tests, and the results merged.
715         (Manager._run_test_subset): Some lines unwrapped.
716         (Manager._end_test_run):
717         (Manager._run_tests):
718         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
719         (SingleTestRunner.__init__): Unwrapped a line.
720         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
721         (TestRunResults.merge): Add this function to merge TestRunResults
722         * Scripts/webkitpy/layout_tests/views/printing.py:
723         (Printer.print_workers_and_shards): Print the custom device, if any.
724         * Scripts/webkitpy/port/base.py:
725         (Port): Base port has empty array of custom devices.
726         (Port.setup_test_run): Add device_class argument.
727         * Scripts/webkitpy/port/driver.py:
728         (DriverInput.__repr__):
729         (Driver.check_driver.implementation):
730         * Scripts/webkitpy/port/efl.py:
731         (EflPort.setup_test_run):
732         * Scripts/webkitpy/port/gtk.py:
733         (GtkPort.setup_test_run):
734         * Scripts/webkitpy/port/ios.py:
735         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
736         (IOSSimulatorPort.__init__):
737         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
738         based on the custom device class.
739         (IOSSimulatorPort._set_device_class):
740         (IOSSimulatorPort._create_simulators): Factor some code into this function.
741         (IOSSimulatorPort.setup_test_run):
742         (IOSSimulatorPort.testing_device):
743         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
744         seemed wrong for this function. That was moved to setup_test_run().
745         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
746         but this happened too early, before we knew which kind of devices to create. Devices
747         are now created in setup_test_run().
748         * Scripts/webkitpy/port/win.py:
749         (WinPort.setup_test_run):
750
751 2016-08-15  Daniel Bates  <dabates@apple.com>
752
753         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
754         private frameworks and libraries
755         https://bugs.webkit.org/show_bug.cgi?id=155931
756         <rdar://problem/25807989>
757
758         Reviewed by Dan Bernstein.
759
760         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
761         where X is the major version of the active iOS SDK.
762
763         * DumpRenderTree/mac/Configurations/Base.xcconfig:
764         * WebKitTestRunner/Configurations/Base.xcconfig:
765
766 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
767
768         Add a setting and preferences to enable visual viewport mode
769         https://bugs.webkit.org/show_bug.cgi?id=160843
770
771         Reviewed by Sam Weinig.
772         
773         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
774
775         * MiniBrowser/mac/SettingsController.h:
776         * MiniBrowser/mac/SettingsController.m:
777         (-[SettingsController _populateMenu]):
778         (-[SettingsController validateMenuItem:]):
779         (-[SettingsController visualViewportEnabled]):
780         (-[SettingsController toggleVisualViewportEnabled:]):
781         * MiniBrowser/mac/WK1BrowserWindowController.m:
782         (-[WK1BrowserWindowController didChangeSettings]):
783         * MiniBrowser/mac/WK2BrowserWindowController.m:
784         (-[WK2BrowserWindowController didChangeSettings]):
785
786 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
787
788         Allow using make-dist with non-GTK ports
789         https://bugs.webkit.org/show_bug.cgi?id=160842
790
791         Reviewed by Michael Catanzaro.
792
793         This patch adds support for setting base name of tarball and argument
794         passed to cmake's -DPORT= via command line arguments.
795
796         * gtk/make-dist.py:
797         (Distcheck.configure):
798         (Distcheck.check):
799         (get_tarball_root_and_output_filename_from_arguments):
800
801 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
802
803         [GTK] Install script lacks gstreamer related dependencies
804         https://bugs.webkit.org/show_bug.cgi?id=160814
805
806         Reviewed by Carlos Garcia Campos.
807
808         * gtk/install-dependencies: Fedora case had already listed this dependencies,
809         but both Arch and Debian/Ubuntu were missing them.
810
811 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
812
813         make-dist.py should not allow unknown rules in manifest
814         https://bugs.webkit.org/show_bug.cgi?id=160841
815
816         Reviewed by Carlos Garcia Campos.
817
818         * gtk/make-dist.py:
819         (Manifest.process_line):
820
821 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
822
823         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
824         https://bugs.webkit.org/show_bug.cgi?id=160809
825
826         Reviewed by Carlos Garcia Campos.
827
828         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
829         case, and use it also for the new package names of libpng and libgeoclue.
830         * gtk/install-dependencies: Ditto.
831
832 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
833
834         Skip to check directories existence in build-webkit
835         https://bugs.webkit.org/show_bug.cgi?id=160691
836
837         Reviewed by Alex Christensen.
838
839         CMake checks if directories are there itself. So CMake ports
840         don't need to check it in the build-webkit script.
841
842         * Scripts/build-webkit:
843         * Scripts/webkitdirs.pm:
844         (determineSourceDir):
845         (isCMakeBuild):
846
847 2016-08-12  Alex Christensen  <achristensen@webkit.org>
848
849         Make URLParser work with URLs missing URL parts
850         https://bugs.webkit.org/show_bug.cgi?id=160824
851
852         Reviewed by Brady Eidson.
853
854         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
855         (TestWebKitAPI::s):
856         (TestWebKitAPI::checkURL):
857         (TestWebKitAPI::TEST_F):
858         (TestWebKitAPI::eq): Deleted.
859
860 2016-08-12  John Wilander  <wilander@apple.com>
861
862         Add HashCountedSet API tests to TestWTFLibrary target
863         https://bugs.webkit.org/show_bug.cgi?id=160815
864
865         Reviewed by Alex Christensen.
866
867         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
868             Added HashCountedSet.cpp and sorted the file reference section
869             according to UNIX sort.
870
871 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
872
873         run-benchmark should run JetStream 1.1 instead of 1.0.1
874         https://bugs.webkit.org/show_bug.cgi?id=160816
875
876         Reviewed by Filip Pizlo.
877
878         Use the latest JetStream 1.1 in run-benchmark.
879
880         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
881         (BenchmarkBuilder.__exit__):
882         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
883         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
884         change to JetStream directory.
885
886 2016-08-12  Alex Christensen  <achristensen@webkit.org>
887
888         Initial URLParser implementation
889         https://bugs.webkit.org/show_bug.cgi?id=160811
890
891         Reviewed by Brady Eidson.
892
893         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
894         (TestWebKitAPI::eq):
895         (TestWebKitAPI::checkURL):
896         (TestWebKitAPI::TEST_F):
897
898 2016-08-12  Brady Eidson  <beidson@apple.com>
899
900         Fix the 32-bit Mac build after:
901         Add WK2 ExperimentalFeature support to MiniBrowser
902         https://bugs.webkit.org/show_bug.cgi?id=160788
903
904         Unreviewed.
905
906         Sprinkle "#if WK_API_ENABLED"s liberally.
907         
908         * MiniBrowser/mac/AppDelegate.m:
909         (defaultConfiguration):
910         * MiniBrowser/mac/SettingsController.m:
911         (-[SettingsController _populateMenu]):
912         (-[SettingsController validateMenuItem:]):
913
914 2016-08-12  Philippe Normand  <pnormand@igalia.com>
915
916         [GStreamer][OWR] Video rendering fixes
917         https://bugs.webkit.org/show_bug.cgi?id=160764
918
919         Reviewed by Xabier Rodriguez-Calvar.
920
921         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
922
923 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
924
925         Add missing return statement in convertFast function added in r204376.
926
927         Unreviewed.
928
929         * Scripts/webkitpy/common/system/path.py:
930         (_CygPath.convertFast):
931
932 2016-08-11  Brady Eidson  <beidson@apple.com>
933
934         Add WK2 ExperimentalFeature support to MiniBrowser.
935         https://bugs.webkit.org/show_bug.cgi?id=160788
936
937         Reviewed by Alex Christensen.
938
939         * MiniBrowser/mac/AppDelegate.h:
940         * MiniBrowser/mac/AppDelegate.m:
941         (defaultConfiguration):
942         (defaultPreferences):
943         
944         * MiniBrowser/mac/SettingsController.m:
945         (-[SettingsController _populateMenu]):
946         (-[SettingsController validateMenuItem:]):
947         (-[SettingsController toggleExperimentalFeature:]):
948
949 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
950
951         Keep EWS logs for longer
952         https://bugs.webkit.org/show_bug.cgi?id=160776
953
954         Reviewed by Daniel Bates.
955
956         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
957
958 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
959
960         iOS DRT/WTR project cleanup
961         https://bugs.webkit.org/show_bug.cgi?id=160778
962
963         Reviewed by Tim Horton.
964
965         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
966
967         Remove AppDelegate.* which were unused.
968
969         Exclude ios/Launch.storyboard on more platforms.
970
971         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
972         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
973         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
974         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
975         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
976         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
977         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
978
979 2016-08-11  Alex Christensen  <achristensen@webkit.org>
980
981         Fix Yosemite bots' cookie accept policies after r204365.
982         https://bugs.webkit.org/show_bug.cgi?id=160758
983
984         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
985         (TEST):
986         This makes the test fully clean up after itself.
987
988 2016-08-11  Alex Christensen  <achristensen@webkit.org>
989
990         Fix Yosemite bots' cookie accept policies after r204365.
991         https://bugs.webkit.org/show_bug.cgi?id=160758
992
993         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
994         (TEST):
995         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
996         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
997         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
998         causing any problems because there are no other API tests that do anything with cookies.
999         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
1000         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
1001         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
1002
1003 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1004
1005         EWS should check if the patch is still valid before executing every major step
1006         https://bugs.webkit.org/show_bug.cgi?id=160739
1007         rdar://problem/27768813
1008
1009         Reviewed by Alexey Proskuryakov.
1010
1011         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1012         (CommitQueueTask.run): validate method is now executed in base class.
1013         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1014         (EarlyWarningSystemTask.run): validate method is now executed in base class.
1015         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1016         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
1017         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1018         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
1019         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
1020         * Scripts/webkitpy/tool/commands/perfalizer.py:
1021         (PerfalizerTask.validate): Added.
1022         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1023         (test_manual_reject_during_processing): Updated test case.
1024
1025 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1026
1027         Add URLParser stub
1028         https://bugs.webkit.org/show_bug.cgi?id=160770
1029
1030         Reviewed by Sam Weinig.
1031
1032         * TestWebKitAPI/PlatformGTK.cmake:
1033         * TestWebKitAPI/PlatformWin.cmake:
1034         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1035         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
1036         (TestWebKitAPI::TEST_F):
1037
1038 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1039
1040         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
1041         https://bugs.webkit.org/show_bug.cgi?id=160761
1042
1043         Reviewed by Tim Horton.
1044
1045         Give iOS DRT a Launch storyboard.
1046
1047         Have it use a UIViewController so future forms testing works correctly.
1048
1049         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
1050         can run in iPad mode.
1051
1052         Remove empty InfoPlist.strings files.
1053
1054         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1055         * DumpRenderTree/ios/Info.plist:
1056         * DumpRenderTree/ios/Launch.storyboard: Added.
1057         * DumpRenderTree/mac/DumpRenderTree.mm:
1058         (createWebViewAndOffscreenWindow):
1059         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1060         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
1061         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1062         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
1063
1064 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
1065
1066         [Win] Unable to reliably run tests in parallel
1067         https://bugs.webkit.org/show_bug.cgi?id=140914
1068
1069         Reviewed by Brent Fulgham.
1070
1071         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1072         processes. We can use string replacement to convert the Cygwin path to a Windows path
1073         instead.
1074
1075         * Scripts/webkitpy/common/system/path.py:
1076         (cygpathFast):
1077         * Scripts/webkitpy/port/driver.py:
1078         (Driver._command_from_driver_input):
1079
1080 2016-08-10  Alex Christensen  <achristensen@webkit.org>
1081
1082         Fix crash when changing cookie accept policy after r204327
1083         https://bugs.webkit.org/show_bug.cgi?id=160758
1084
1085         Reviewed by Simon Fraser.
1086
1087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1088         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
1089         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
1090         (TEST):
1091         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
1092
1093 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1094
1095         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
1096         https://bugs.webkit.org/show_bug.cgi?id=160757
1097
1098         Reviewed by Tim Horton.
1099
1100         When programmatically creating the test UIWindow, make a root UIViewController and parent
1101         the WKWebView in its view. This makes the app more like a normal UIKit application.
1102         
1103         Move the WKWebView down 20px to avoid the status bar.
1104         
1105         Give the UIWindow a gray background so it's obvious where the window and view positioned.
1106
1107         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
1108         
1109         Remove duplicate references to Launch.storyboard.
1110
1111         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1112         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
1113         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
1114         (-[AppDelegate applicationWillResignActive:]): Deleted.
1115         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
1116         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
1117         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
1118         (-[AppDelegate applicationWillTerminate:]): Deleted.
1119         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1120         (WTR::viewRectForWindowRect):
1121         (WTR::PlatformWebView::PlatformWebView):
1122         (WTR::PlatformWebView::setWindowFrame):
1123
1124 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1125
1126         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
1127         https://bugs.webkit.org/show_bug.cgi?id=160748
1128
1129         Reviewed by Tim Horton.
1130         
1131         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
1132         opens the door for tests using other device sizes.
1133
1134         * WebKitTestRunner/ios/TestControllerIOS.mm:
1135         (WTR::TestController::platformConfigureViewForTest):
1136
1137 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1138
1139         Sort the feature flags in the FEATURE_DEFINES lines
1140         https://bugs.webkit.org/show_bug.cgi?id=160742
1141
1142         Reviewed by Anders Carlsson.
1143         
1144         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1145
1146 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
1147
1148         Logging and other minor improvements to iOS webkitpy
1149         https://bugs.webkit.org/show_bug.cgi?id=160722
1150
1151         Reviewed by Dan Bates.
1152
1153         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
1154         to make it easier to debug launching issues.
1155
1156         Have reset_preferences() reset the device, rather than just nuking the data
1157         directory (which broke some versions of the simulator).
1158
1159         Make the Simulator.app launch in the background with open -g.
1160
1161         Wait for the simulator device to be in a known state in some more places.
1162
1163         * Scripts/webkitpy/port/ios.py:
1164         (IOSSimulatorPort.setup_test_run):
1165         (IOSSimulatorPort._quit_ios_simulator):
1166         (IOSSimulatorPort.clean_up_test_run):
1167         (IOSSimulatorPort.setup_environ_for_server):
1168         (IOSSimulatorPort.reset_preferences):
1169         * Scripts/webkitpy/xcode/simulator.py:
1170         (Device.create):
1171         (Device.delete):
1172         (Device):
1173         (Device.reset):
1174         (Simulator.wait_until_device_is_booted):
1175         (Simulator.wait_until_device_is_in_state):
1176         (Simulator):
1177         (Simulator.delete_device):
1178         (Simulator.reset_device):
1179         (Simulator.lookup_or_create_device):
1180
1181 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1182
1183         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
1184         https://bugs.webkit.org/show_bug.cgi?id=160697
1185
1186         Reviewed by Antonio Gomes.
1187
1188         * Scripts/webkitpy/port/base.py:
1189         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
1190         list of environment variables to copy.
1191
1192 2016-08-09  George Ruan  <gruan@apple.com>
1193
1194         Implement functionality of media capture on iOS
1195         https://bugs.webkit.org/show_bug.cgi?id=158945
1196         <rdar://problem/26893343>
1197
1198         Reviewed by Tim Horton.
1199
1200         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
1201         Capture feature on iOS.
1202
1203 2016-08-09  Saam Barati  <sbarati@apple.com>
1204
1205         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
1206         https://bugs.webkit.org/show_bug.cgi?id=160671
1207         <rdar://problem/27756112>
1208
1209         Reviewed by Mark Lam.
1210
1211         * Scripts/run-jsc-stress-tests:
1212
1213 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
1214
1215         Make directory reading code in iOSSimulatorDevices() more strict
1216         https://bugs.webkit.org/show_bug.cgi?id=160702
1217
1218         Reviewed by Tim Horton.
1219
1220         * Scripts/webkitdirs.pm:
1221         (iOSSimulatorDevices):
1222
1223 2016-08-06  Sam Weinig  <sam@webkit.org>
1224
1225         Replace NodeOrString with std::variant<RefPtr<Node>, String>
1226         https://bugs.webkit.org/show_bug.cgi?id=160638
1227
1228         Reviewed by Anders Carlsson.
1229
1230         * TestWebKitAPI/CMakeLists.txt:
1231         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1232         Add additional tests for the initial state of std::variant and using
1233         makeVisitor for visiting.
1234
1235 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
1236
1237         EWS logging should ensure the logging to file is stopped on queue termination
1238         https://bugs.webkit.org/show_bug.cgi?id=160698
1239         rdar://problem/24464570
1240
1241         Reviewed by Daniel Bates.
1242
1243         * Scripts/webkitpy/tool/bot/queueengine.py:
1244         (QueueEngine._stopping): Stop logging to file on queue termination.
1245         (QueueEngine._begin_logging): Configure the Python logger to log to file.
1246         * Scripts/webkitpy/common/system/logutils.py:
1247         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
1248         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1249         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
1250         * Scripts/webkitpy/tool/commands/queues.py:
1251         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
1252         (AbstractQueue.queue_log_path): Same.
1253         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
1254         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
1255         which moved to QueueEngine now.
1256         (PatchProcessingQueue.__init__): Same.
1257         (CommitQueue.__init__): Same.
1258         (AbstractReviewQueue.__init__): Same.
1259         (StyleQueue.__init__): Same.
1260         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1261         (TestCommitQueue): Removed host parameter.
1262         (TestCommitQueue.__init__): Same.
1263         (AbstractPatchQueueTest.test_next_patch): Same.
1264         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1265         (test_commit_queue_failure): Same.
1266         (mock_run_webkit_patch):
1267         (MockCommitQueueTask.results_from_patch_test_run): Same.
1268         (test_rollout_lands): Same.
1269         (test_non_valid_patch): Same.
1270         (test_auto_retry): Same.
1271         (test_style_queue_with_watch_list_exception): Same.
1272         (TestQueue.__init__): Deleted.
1273         (TestReviewQueue.__init__): Deleted.
1274         (TestFeederQueue.__init__): Deleted.
1275
1276 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
1277
1278         webkit-gtk tarball fails to build due to missing files
1279         https://bugs.webkit.org/show_bug.cgi?id=160684
1280
1281         Reviewed by Alex Christensen.
1282
1283         * gtk/manifest.txt.in: Added back spi directories.
1284
1285 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1286
1287         [GTK] Build the jhbuild with -O2 optimization level by default
1288         https://bugs.webkit.org/show_bug.cgi?id=160544
1289
1290         Reviewed by Michael Catanzaro.
1291
1292         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
1293         which don't increases the required disk space significatively and
1294         provides better debug information than no passing it.
1295
1296 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
1297
1298         Allow more --cmakeargs option in build-jsc and build-webkit
1299         https://bugs.webkit.org/show_bug.cgi?id=160340
1300
1301         Reviewed by Michael Catanzaro.
1302
1303         * Scripts/build-jsc:
1304         * Scripts/build-webkit:
1305
1306 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1307
1308         Do not check if WebKitLibraries folder exists on EFL and GTK
1309         https://bugs.webkit.org/show_bug.cgi?id=160659
1310
1311         Reviewed by Csaba Osztrogonác.
1312
1313         Though WebKitLibraries is only needed by mac and win ports,
1314         EFL and GTK ports have checked whether it exists.
1315
1316         * Scripts/build-webkit:
1317
1318 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
1319
1320         Some EWS console logs doesn't go to log file
1321         https://bugs.webkit.org/show_bug.cgi?id=160585
1322         rdar://problem/24464570
1323
1324         Reviewed by Daniel Bates.
1325
1326         * Scripts/webkitpy/common/system/logutils.py:
1327         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
1328         any possible overwriting.
1329         * Scripts/webkitpy/common/system/filesystem.py:
1330         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
1331         * Scripts/webkitpy/common/system/filesystem_mock.py:
1332         (MockFileSystem.open_text_file_for_writing): Same.
1333         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1334         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
1335         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
1336         * Scripts/webkitpy/tool/commands/queues.py:
1337         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
1338         This will ensure that all the sub-modules inside webkitpy will log to file.
1339
1340 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
1341
1342         Have the iOS platform interit from the Apple platform in webkitpy
1343         https://bugs.webkit.org/show_bug.cgi?id=160672
1344
1345         Reviewed by Dan Bates.
1346         
1347         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
1348         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
1349         ApplePort.
1350         
1351         Since WinPort also inherits from ApplePort, it needs to stub out some things
1352         that are unavailable on Windows (leaks, sampling).
1353         
1354         Some SnowLeopard-related code and the associated test were removed.
1355
1356         * Scripts/webkitpy/port/apple.py:
1357         (ApplePort.__init__):
1358         (ApplePort):
1359         (ApplePort._make_leak_detector):
1360         (ApplePort.default_timeout_ms):
1361         (ApplePort.supports_per_test_timeout):
1362         (ApplePort.should_retry_crashes):
1363         (ApplePort._generate_all_test_configurations):
1364         (ApplePort.check_for_leaks):
1365         (ApplePort.print_leaks_summary):
1366         (ApplePort._path_to_webcore_library):
1367         (ApplePort.show_results_html_file):
1368         (ApplePort._merge_crash_logs):
1369         (ApplePort._look_for_all_crash_logs_in_log_dir):
1370         (ApplePort._get_crash_log):
1371         (ApplePort.look_for_new_crash_logs):
1372         (ApplePort.sample_process):
1373         (ApplePort.sample_file_path):
1374         (ApplePort.look_for_new_samples):
1375         (ApplePort._path_to_helper):
1376         (ApplePort.determine_full_port_name): Deleted.
1377         * Scripts/webkitpy/port/ios.py:
1378         (IOSSimulatorPort):
1379         (IOSSimulatorPort.__init__):
1380         (IOSSimulatorPort.default_timeout_ms): Deleted.
1381         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
1382         (IOSSimulatorPort.should_retry_crashes): Deleted.
1383         (IOSSimulatorPort.check_for_leaks): Deleted.
1384         (IOSSimulatorPort.print_leaks_summary): Deleted.
1385         (IOSSimulatorPort._path_to_webcore_library): Deleted.
1386         (IOSSimulatorPort.show_results_html_file): Deleted.
1387         (IOSSimulatorPort.sample_file_path): Deleted.
1388         (IOSSimulatorPort._merge_crash_logs): Deleted.
1389         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
1390         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
1391         (IOSSimulatorPort.look_for_new_samples): Deleted.
1392         (IOSSimulatorPort.sample_process): Deleted.
1393         (IOSSimulatorPort._path_to_helper): Deleted.
1394         (IOSSimulatorPort.make_command): Deleted.
1395         * Scripts/webkitpy/port/mac.py:
1396         (MacPort.__init__):
1397         (MacPort.make_command):
1398         (MacPort._build_java_test_support):
1399         (MacPort): Deleted.
1400         (MacPort.default_timeout_ms): Deleted.
1401         (MacPort.supports_per_test_timeout): Deleted.
1402         (MacPort.should_retry_crashes): Deleted.
1403         (MacPort.default_child_processes): Deleted.
1404         (MacPort.check_for_leaks): Deleted.
1405         (MacPort.print_leaks_summary): Deleted.
1406         (MacPort._path_to_webcore_library): Deleted.
1407         (MacPort.show_results_html_file): Deleted.
1408         (MacPort.sample_file_path): Deleted.
1409         (MacPort._merge_crash_logs): Deleted.
1410         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
1411         (MacPort.look_for_new_crash_logs): Deleted.
1412         (MacPort.look_for_new_samples): Deleted.
1413         (MacPort.sample_process): Deleted.
1414         (MacPort._path_to_helper): Deleted.
1415         * Scripts/webkitpy/port/mac_unittest.py:
1416         (MacTest.test_default_child_processes): Deleted.
1417         * Scripts/webkitpy/port/win.py:
1418         (WinPort.look_for_new_samples):
1419         (WinPort):
1420         (WinPort.sample_process):
1421         (WinPort._make_leak_detector):
1422         (WinPort.check_for_leaks):
1423         (WinPort.print_leaks_summary):
1424         (WinPort._path_to_webcore_library):
1425
1426 2016-08-08  Matt Baker  <mattbaker@apple.com>
1427
1428         Unreviewed: moved myself to the reviewers list.
1429
1430         * Scripts/webkitpy/common/config/contributors.json:
1431
1432 2016-08-08  Chris Dumez  <cdumez@apple.com>
1433
1434         Update API tests in mac/SetDocumentURI.mm after r204247
1435         https://bugs.webkit.org/show_bug.cgi?id=160660
1436
1437         Reviewed by Alex Christensen.
1438
1439         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1440         (TestWebKitAPI::TEST):
1441
1442 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
1443
1444         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
1445         https://bugs.webkit.org/show_bug.cgi?id=159827
1446
1447         Reviewed by Daniel Bates.
1448
1449         This change was spurred by a process hang which occurred between tests and did
1450         not produce a meaningful crashlog.
1451
1452         * Scripts/webkitpy/port/driver.py:
1453         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
1454
1455          * Scripts/webkitpy/port/ios.py:
1456         (IOSSimulatorPort):
1457         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
1458         * Scripts/webkitpy/port/mac.py:
1459         (MacPort):
1460         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
1461
1462         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
1463         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1464
1465         * WebKitTestRunner/TestController.h:
1466         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1467         * WebKitTestRunner/TestInvocation.cpp:
1468         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1469
1470 2016-08-07  Dan Bernstein  <mitz@apple.com>
1471
1472         [Cocoa] Reply block leaks if the remote object doesn’t call it
1473         https://bugs.webkit.org/show_bug.cgi?id=160642
1474
1475         Reviewed by Sam Weinig.
1476
1477         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
1478         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1479         (TEST): Added a test case that checks that the reply block is released even when it’s not
1480           called.
1481         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1482         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
1483           calling the completion handler.
1484
1485 2016-08-07  Chris Dumez  <cdumez@apple.com>
1486
1487         Write API test to cover crash fix in r204135
1488         https://bugs.webkit.org/show_bug.cgi?id=160587
1489
1490         Reviewed by Darin Adler.
1491
1492         Add API test to cover crash fix in r204135. This reproduces the crash
1493         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1494         callback.
1495
1496         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1497         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1498         (TEST):
1499
1500 2016-08-06  Chris Dumez  <cdumez@apple.com>
1501
1502         Unreviewed, rolling out r204226.
1503
1504         Broke some API tests
1505
1506         Reverted changeset:
1507
1508         "Write API test to cover crash fix in r204135"
1509         https://bugs.webkit.org/show_bug.cgi?id=160587
1510         http://trac.webkit.org/changeset/204226
1511
1512 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
1513
1514         EWS Style Queue fails to process patches which fails validation
1515         https://bugs.webkit.org/show_bug.cgi?id=160632
1516
1517         Reviewed by Alexey Proskuryakov.
1518
1519         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1520         (StyleQueueTask.validate): Add more information about validation failure.
1521         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1522         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1523         (test_non_valid_patch): Add a unit test to test the above code path.
1524
1525 2016-08-06  Sam Weinig  <sam@webkit.org>
1526
1527         WTF needs a variant implementation
1528         https://bugs.webkit.org/show_bug.cgi?id=160618
1529
1530         Reviewed by Darin Adler.
1531
1532         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1533         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
1534         Add tests for the variant implementation.
1535
1536 2016-08-06  Chris Dumez  <cdumez@apple.com>
1537
1538         Write API test to cover crash fix in r204135
1539         https://bugs.webkit.org/show_bug.cgi?id=160587
1540
1541         Reviewed by Darin Adler.
1542
1543         Add API test to cover crash fix in r204135. This reproduces the crash
1544         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1545         callback.
1546
1547         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1548         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1549         (TEST):
1550
1551 2016-08-05  Tim Horton  <timothy_horton@apple.com>
1552
1553         run-api-tests should use a headed simulator
1554         https://bugs.webkit.org/show_bug.cgi?id=160611
1555
1556         Reviewed by Sam Weinig.
1557
1558         CADisplayLink doesn't work in a headless simulator, but is
1559         vital for the proper functioning of WebKit2 painting on iOS.
1560         So, we should not use a headless simulator.
1561
1562         * Scripts/run-api-tests:
1563         Launch a simulator app, don't just boot the simulator.
1564
1565         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1566         Re-enable a test that works now.
1567
1568 2016-08-05  Dan Bernstein  <mitz@apple.com>
1569
1570         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
1571         https://bugs.webkit.org/show_bug.cgi?id=160589
1572
1573         Reviewed by Tim Horton.
1574
1575         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1576         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
1577           blocks, which wasn’t caught because the test wasn’t run correctly.
1578         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1579         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
1580           added a test that sends over an NSRange.
1581         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1582         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
1583           handler with the range‘s location and length.
1584
1585 2016-08-05  Enrica Casucci  <enrica@apple.com>
1586
1587         Fixing tests failing after r204175.
1588
1589         Unreviewed.
1590
1591         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
1592
1593 2016-08-05  Enrica Casucci  <enrica@apple.com>
1594
1595         Build fix after 204053.
1596
1597         Unreviewed.
1598
1599         * TestWebKitAPI/Configurations/Base.xcconfig:
1600         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1601         (-[MockContentFilterEnabler initWithCoder:]):
1602         (-[MockContentFilterEnabler dealloc]):
1603
1604 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
1605
1606         Print test name in "Last character read from DRT..." error message.
1607         https://bugs.webkit.org/show_bug.cgi?id=160559
1608
1609         Reviewed by Michael Catanzaro.
1610
1611         * Scripts/webkitpy/port/driver.py:
1612         (Driver.run_test):
1613         (Driver._read_first_block):
1614         (Driver._read_optional_image_block):
1615         (Driver._read_block):
1616         * Scripts/webkitpy/port/driver_unittest.py:
1617         (DriverTest.test_read_block):
1618         (DriverTest.test_read_binary_block):
1619         (DriverTest.test_read_base64_block):
1620
1621 2016-08-05  Commit Queue  <commit-queue@webkit.org>
1622
1623         Unreviewed, rolling out r204123.
1624         https://bugs.webkit.org/show_bug.cgi?id=160597
1625
1626         Caused layout test timeouts on Windows. (Requested by perarne
1627         on #webkit).
1628
1629         Reverted changeset:
1630
1631         "[Win] Unable to reliably run tests in parallel"
1632         https://bugs.webkit.org/show_bug.cgi?id=140914
1633         http://trac.webkit.org/changeset/204123
1634
1635 2016-08-04  Saam Barati  <sbarati@apple.com>
1636
1637         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1638         https://bugs.webkit.org/show_bug.cgi?id=151241
1639
1640         Reviewed by Benjamin Poulain.
1641
1642         * Scripts/run-jsc-stress-tests:
1643
1644 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1645
1646         UI improvements to Flakiness Dashboard.
1647         https://bugs.webkit.org/show_bug.cgi?id=153295
1648
1649         Reviewed by Alexey Proskuryakov.
1650
1651         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1652         (td.options-container): Center text in most fields.
1653         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1654         (createBugHTML): Text/Grammar updates.
1655         (tableHeaders): Ditto.
1656         (htmlForSingleTestRow): Ditto.
1657         (headerForTestTableHtml): Ditto.
1658         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1659         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1660
1661 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1662
1663         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1664         https://bugs.webkit.org/show_bug.cgi?id=160518
1665
1666         Reviewed by Michael Catanzaro.
1667
1668         * Scripts/webkitpy/thirdparty/__init__.py:
1669         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1670         * gtk/install-dependencies:
1671
1672 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1673
1674         Optimize bot watcher's dashboard a little
1675         https://bugs.webkit.org/show_bug.cgi?id=160515
1676         rdar://problem/26096900
1677
1678         Reviewed by Lucas Forschler.
1679
1680         Made re-sorting after loading an iteration more efficient.
1681
1682         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1683         (BuildbotIteration.prototype._updateWithData):
1684         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1685         (BuildbotQueue.prototype.updateIterationPosition):
1686
1687 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1688
1689         [Win] Unable to reliably run tests in parallel
1690         https://bugs.webkit.org/show_bug.cgi?id=140914
1691
1692         Reviewed by Brent Fulgham.
1693
1694         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1695         processes. We can use string replacement to convert the Cygwin path to a Windows path
1696         instead.
1697  
1698         * Scripts/webkitpy/common/system/path.py:
1699         (cygpathFast):
1700         * Scripts/webkitpy/port/driver.py:
1701         (Driver._command_from_driver_input):
1702
1703 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1704
1705         Document instructions for increasing process and file limits
1706         https://bugs.webkit.org/show_bug.cgi?id=160528
1707         rdar://problem/24777576
1708
1709         Reviewed by Alexey Proskuryakov.
1710
1711         * Scripts/webkitpy/port/ios.py:
1712         (IOSSimulatorPort.default_child_processes):
1713
1714 2016-08-03  Anders Carlsson  <andersca@apple.com>
1715
1716         Remove the Objective-C bindings generator
1717         https://bugs.webkit.org/show_bug.cgi?id=160526
1718
1719         Reviewed by Sam Weinig.
1720
1721         * Scripts/run-bindings-tests:
1722         Update test.
1723
1724 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1725
1726         Revise a TestWebKitAPI comment to mention the actual underlying problem
1727
1728         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1729         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1730
1731 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1732
1733         Benchmark test content-animation timeouts always
1734         https://bugs.webkit.org/show_bug.cgi?id=160057
1735
1736         Reviewed by Simon Fraser.
1737
1738         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1739         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1740         (start):
1741
1742 2016-08-02  Nan Wang  <n_wang@apple.com>
1743
1744         AX: Simulated touch events are not working on iOS
1745         https://bugs.webkit.org/show_bug.cgi?id=160395
1746         <rdar://problem/27633597>
1747
1748         Reviewed by Chris Fleizach.
1749
1750         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1751         (WTR::AccessibilityUIElement::press):
1752         (WTR::AccessibilityUIElement::setSelectedChild):
1753
1754 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1755
1756         run-javascriptcore-tests should accept multiple --extra-tests
1757         https://bugs.webkit.org/show_bug.cgi?id=160486
1758
1759         Reviewed by Saam Barati.
1760         
1761         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1762         test suites. This does it by using GetOpt::Long's array support.
1763
1764         * Scripts/run-javascriptcore-tests:
1765         (runJSCStressTests):
1766
1767 2016-08-02  Enrica Casucci  <enrica@apple.com>
1768
1769         Allow building with content filtering disabled.
1770         https://bugs.webkit.org/show_bug.cgi?id=160454
1771
1772         Reviewed by Simon Fraser.
1773
1774         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1775
1776 2016-08-02  Brady Eidson  <beidson@apple.com>
1777
1778         Removing IndexedDB WebsiteData can fail for some users.
1779         https://bugs.webkit.org/show_bug.cgi?id=160463
1780
1781         Reviewed by Alex Christensen.
1782
1783         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1784
1785 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1786
1787         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1788         https://bugs.webkit.org/show_bug.cgi?id=160437
1789         <rdar://problem/27578272>
1790
1791         Reviewed by Brady Eidson.
1792
1793         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1794         (-[DownloadDelegate _download:didReceiveResponse:]):
1795         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1796         (runTest):
1797         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1798
1799 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1800
1801         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1802         https://bugs.webkit.org/show_bug.cgi?id=160414
1803
1804         Reviewed by Michael Catanzaro.
1805
1806         * Scripts/webkitpy/port/linux_get_crash_log.py:
1807         (GDBCrashLogGenerator._wait_for_corefile):
1808
1809 2016-08-01  Youenn Fablet  <youenn@apple.com>
1810
1811         Make wpt server generate its certificates in layout test results folder
1812         https://bugs.webkit.org/show_bug.cgi?id=160422
1813
1814         Reviewed by Chris Dumez.
1815
1816         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1817         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1818
1819 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1820
1821         Function Call on NULL Object
1822         https://bugs.webkit.org/show_bug.cgi?id=160325
1823
1824         Reviewed by Darin Adler.
1825
1826         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1827         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1828         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1829
1830 2016-08-01  Keith Miller  <keith_miller@apple.com>
1831
1832         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1833         https://bugs.webkit.org/show_bug.cgi?id=160372
1834
1835         Rubber stamped by Geoffrey Garen.
1836
1837         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1838         a new top level directory, JSTests. Having the tests in the Source directory
1839         was both confusing an inconvenient for people that just want to checkout the
1840         source code of WebKit. Since there is no other obvious place to put all the
1841         JavaScript tests a new top level directory seemed the most sensible.
1842
1843         * Scripts/import-test262-tests:
1844         * Scripts/run-javascriptcore-tests:
1845         * Scripts/update-javascriptcore-test-res:
1846
1847 2016-07-31  Nan Wang  <n_wang@apple.com>
1848
1849         AX: Add a check for touch event listener on iOS accessibility object
1850         https://bugs.webkit.org/show_bug.cgi?id=160388
1851
1852         Reviewed by Chris Fleizach.
1853
1854         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1855         (AccessibilityUIElement::boolAttributeValue):
1856         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1857         (WTR::AccessibilityUIElement::boolAttributeValue):
1858
1859 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1860
1861         Unreviewed: add myself to the reviewers list.
1862
1863         * Scripts/webkitpy/common/config/contributors.json:
1864
1865 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1866
1867         Undo r203939, and copy over a rule that clips the logos.
1868
1869         Sierra wasn't the only logo without transparency.
1870
1871         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1872         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1873         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1874
1875 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1876
1877         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1878         https://bugs.webkit.org/show_bug.cgi?id=160377
1879
1880         Reviewed by Brian Weinstein.
1881
1882         Update assets to remove the white background and use a transparent background instead.
1883
1884         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1885         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1886
1887 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1888
1889         Ignore most check-webkit-style checks for ANGLE project
1890         <https://webkit.org/b/160333>
1891
1892         Reviewed by Daniel Bates.
1893
1894         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1895         - No tabs.
1896         - No spaces at the end of lines.
1897         - No carriage returns (DOS line endings).
1898
1899 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1900
1901         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1902         https://bugs.webkit.org/show_bug.cgi?id=160360
1903         <rdar://problem/27179484>
1904
1905         Reviewed by Myles C. Maxfield.
1906
1907         Adds two tests verifying that videos may be considered main content as long as they
1908         are large enough and cover a majority of the mainframe's viewport.
1909
1910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1911         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1912         (TestWebKitAPI::TEST):
1913         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1914         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1915
1916 2016-07-29  Mark Lam  <mark.lam@apple.com>
1917
1918         Gardening: removed unused variable.
1919
1920         Not reviewed.
1921
1922         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1923         (TestWebKitAPI::TEST):
1924
1925 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1926
1927         Add TestWebKitAPI support for interacting with media controls
1928         https://bugs.webkit.org/show_bug.cgi?id=160342
1929         <rdar://problem/27610246>
1930
1931         Reviewed by Beth Dakin.
1932
1933         Adds support for testing interaction with some media controls, as well as a basic test
1934         verifying that media control teardown after interaction does not result in a crash.
1935
1936         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1937         (-[WKWebView mouseDownAtPoint:]):
1938         (-[WKWebView performAfterLoading:]):
1939         (TestWebKitAPI::TEST):
1940
1941 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1942
1943         Crash Log Clobbering on Unbound Crashes
1944         https://bugs.webkit.org/show_bug.cgi?id=160198
1945         <rdar://problem/27472618>
1946
1947         Reviewed by Alexey Proskuryakov.
1948
1949         * Scripts/webkitpy/common/system/crashlogs.py:
1950         (CrashLogs): Fix header order.
1951         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1952         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1953
1954 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1955
1956         Update for contributors.json
1957         https://bugs.webkit.org/show_bug.cgi?id=160294
1958
1959         * Scripts/webkitpy/common/config/contributors.json:
1960
1961 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1962
1963         Remove deprecated SPI for video inline / fullscreen controls
1964         https://bugs.webkit.org/show_bug.cgi?id=160318
1965
1966         Reviewed by Tim Horton.
1967
1968         * DumpRenderTree/mac/DumpRenderTree.mm:
1969         (setDefaultsToConsistentValuesForTesting): Deleted.
1970         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1971         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1972         * WebKitTestRunner/TestController.cpp:
1973         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1974         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1975         (WTR::initializeWebViewConfiguration): Deleted.
1976
1977 2016-07-28  Daniel Bates  <dabates@apple.com>
1978
1979         [iOS] TestWebKitAPI bundle targets are not code signed
1980         https://bugs.webkit.org/show_bug.cgi?id=160328
1981         <rdar://problem/27409246>
1982
1983         Reviewed by Andy Estes.
1984
1985         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1986         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1987         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1988
1989         * TestWebKitAPI/Configurations/Base.xcconfig:
1990
1991 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1992
1993         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1994
1995         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1996         (animatedResizeWebView):
1997         (TEST):
1998         This test times out only when run in the WebKit Testing simulator environment,
1999         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
2000
2001 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2002
2003         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
2004         https://bugs.webkit.org/show_bug.cgi?id=160289
2005         <rdar://problem/27553464>
2006
2007         Reviewed by Simon Fraser.
2008
2009         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2010         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2011         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
2012         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
2013         (-[AnimatedResizeWebView _endAnimatedResize]):
2014         (animatedResizeWebView):
2015         (TEST):
2016         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
2017         Add two tests that ensure that hidden-content and animated resizes
2018         don't cause unnecessary synchronous waits. Only the hidden-content
2019         one fails before my patch, but it seemed reasonable to add both anyway.
2020
2021 2016-07-28  David Kilzer  <ddkilzer@apple.com>
2022
2023         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
2024         <https://webkit.org/b/83342>
2025
2026         Reviewed by Ryosuke Niwa.
2027
2028         * Scripts/webkitpy/common/checkout/scm/git.py:
2029         (Git.revisions_changing_file): Remove code to raise an exception
2030         when the file doesn't exist.  If a file was moved or renamed,
2031         then this caused the script to terminate, which was very
2032         frustrating when you wanted a list of reviewers.
2033         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2034         (SCMTest._shared_test_revisions_changing_file): Update test
2035         expectation to return an empty list of revisions.
2036         (test_create_patch_is_full_patch): Drive-by fix when running all
2037         webkitpy tests (including scm tests).
2038         * Scripts/webkitpy/common/checkout/scm/svn.py:
2039         (SVN.revisions_changing_file): Catch ScriptError exceptions and
2040         return an empty array of revisions if this occurs.
2041
2042 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
2043
2044         EWS error message "Error: * did not process patch" should include explanation
2045         https://bugs.webkit.org/show_bug.cgi?id=159903
2046         <rdar://problem/27410788>
2047
2048         Reviewed by Alexey Proskuryakov.
2049
2050         * QueueStatusServer/handlers/statusbubble.py:
2051         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
2052         is not processed.
2053         * QueueStatusServer/handlers/processingtimesjson.py:
2054         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
2055         of the code.
2056         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2057         (CommitQueueTask.validate): Add more information about validation failure.
2058         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2059         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2060         (EarlyWarningSystemTask.validate): Add more information about validation failure.
2061         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
2062         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2063         (PatchIsNotValid.__init__): Add the failure_message argument.
2064         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2065         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
2066         failure details.
2067         * Scripts/webkitpy/tool/commands/queues.py:
2068         (CommitQueue.process_work_item): Same.
2069         (StyleQueue.review_patch): Same.
2070         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2071         (test_non_valid_patch): Updated test-cases messages to match the above changes.
2072
2073 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
2074
2075         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
2076         https://bugs.webkit.org/show_bug.cgi?id=160262
2077
2078         Reviewed by Daniel Bates.
2079
2080         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2081         (-[LTRelayController installApp]):
2082
2083 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
2084
2085         Disable WebCoreNSURLSessionTest API tests on ios-simulator
2086         https://bugs.webkit.org/show_bug.cgi?id=160225
2087
2088         Reviewed by Alexey Proskuryakov.
2089
2090         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2091
2092 2016-07-27  Miguel Gomez  <magomez@igalia.com>
2093
2094         [GTK] Fix some video/canvas tests that should be passing
2095         https://bugs.webkit.org/show_bug.cgi?id=160023
2096
2097         Reviewed by Carlos Garcia Campos.
2098
2099         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
2100         EFL or GTK platforms.
2101
2102         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2103         (WTR::TestController::platformConfigureViewForTest):
2104         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2105         (WTR::TestController::platformConfigureViewForTest):
2106
2107 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2108
2109         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
2110         https://bugs.webkit.org/show_bug.cgi?id=160247
2111
2112         Reviewed by Michael Catanzaro.
2113
2114         * BuildSlaveSupport/built-product-archive:
2115         (createZip):
2116         (dirContainsdwo):
2117         (archiveBuiltProduct):
2118
2119 2016-07-26  Alex Christensen  <achristensen@webkit.org>
2120
2121         Fix tests after r203743.
2122         https://bugs.webkit.org/show_bug.cgi?id=156947
2123
2124         * WebKitTestRunner/TestController.cpp:
2125         (WTR::TestController::resetStateToConsistentValues):
2126         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
2127
2128 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
2129
2130         [iPhone] Playing a video on tudou.com plays only sound, no video
2131         https://bugs.webkit.org/show_bug.cgi?id=160178
2132         <rdar://problem/27535468>
2133
2134         Reviewed by Dan Bernstein.
2135
2136         * DumpRenderTree/mac/DumpRenderTree.mm:
2137         (setDefaultsToConsistentValuesForTesting):
2138         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2139         (RequiresUserActionForPlaybackTest::SetUp):
2140         * WebKitTestRunner/TestController.cpp:
2141         (WTR::TestController::resetPreferencesToConsistentValues):
2142         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2143         (WTR::initializeWebViewConfiguration):
2144
2145 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2146
2147         Allow LOG macros to be used outside the namespace, and other logging cleanup
2148         https://bugs.webkit.org/show_bug.cgi?id=160216
2149
2150         Reviewed by Anders Carlsson.
2151         
2152         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
2153
2154         * DumpRenderTree/TestRunner.cpp:
2155         * DumpRenderTree/mac/DumpRenderTree.mm:
2156         (resetWebViewToConsistentStateBeforeTesting):
2157
2158 2016-07-26  David Kilzer <ddkilzer@apple.com>
2159
2160         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
2161         https://bugs.webkit.org/show_bug.cgi?id=156947
2162         <rdar://problem/23325160>
2163
2164         Reviewed by Alex Christensen.
2165
2166         * DumpRenderTree/TestRunner.cpp:
2167         (TestRunner::TestRunner):
2168         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
2169         * DumpRenderTree/TestRunner.h:
2170         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2171         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2172         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2173         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2174         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2175         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2176         (WTR::TestRunner::queueNonLoadingScript):
2177         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2178         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2179         * WebKitTestRunner/TestController.cpp:
2180         (WTR::TestController::didReceiveAuthenticationChallenge):
2181         * WebKitTestRunner/TestController.h:
2182         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2183         * WebKitTestRunner/TestInvocation.cpp:
2184         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2185         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
2186
2187 2016-07-26  David Kilzer  <ddkilzer@apple.com>
2188
2189         check-for-exit-time-destructors should be usable outside Xcode
2190         <https://webkit.org/b/160195>
2191
2192         Reviewed by Darin Adler.
2193
2194         * Scripts/check-for-exit-time-destructors: Update to parse
2195         -h|--help switch, or to take one argument to a binary to check
2196         for exit time destructors on the command-line.  The clang
2197         compiler will find these at compile-time with the
2198         -Wexit-time-destructors switch, but this script will check for
2199         them after-the-fact.
2200
2201 2016-07-26  Lucas Forschler  <lforschler@apple.com>
2202
2203         Test svn.webkit.org functionality after maintenance.
2204
2205 2016-07-25  Brady Eidson  <beidson@apple.com>
2206
2207         Modern IDB: Make sure IndexedDB works from file:// url documents by default
2208         https://bugs.webkit.org/show_bug.cgi?id=153783
2209
2210         Reviewed by Alex Christensen.
2211
2212         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
2213         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
2214         
2215         As of https://trac.webkit.org/changeset/203695 this is no longer required.
2216         
2217         Change the relevant API tests to make sure this continues to be no longer required.
2218
2219         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2220         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2221         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2222         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2223         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2224         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2225
2226 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2227
2228         Media controls should not be displayed for a video until it starts playing
2229         https://bugs.webkit.org/show_bug.cgi?id=160092
2230         <rdar://problem/26986673>
2231
2232         Reviewed by Beth Dakin.
2233
2234         Verify that multiple videos do or don't show the media controller depending on whether videos
2235         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
2236         passing because we were always showing media controls for large videos with audio, even if they
2237         had not played back yet. This change ensures that large videos with audio show media controls
2238         only after they begin to play back, and not by virtue of being large enough for main content.
2239
2240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2241         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2242         (TestWebKitAPI::TEST):
2243         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
2244         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
2245         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
2246
2247 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2248
2249         Media controls on apple.com don't disappear when movie finishes playing
2250         https://bugs.webkit.org/show_bug.cgi?id=160068
2251         <rdar://problem/26668526>
2252
2253         Reviewed by Darin Adler.
2254
2255         Adds new API tests. Please see WebCore ChangeLog for more details.
2256
2257         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2258         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2259         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
2260         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2261         (TestWebKitAPI::TEST):
2262         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
2263         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2264         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
2265         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
2266         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
2267
2268 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2269
2270         Unreviewed, fix test-webkitpy after r203674.
2271
2272         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2273         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2274
2275 2016-07-24  Philippe Normand  <pnormand@igalia.com>
2276
2277         Unreviewed, forgot to commit this file in r203674.
2278
2279         * Scripts/process-linux-coredump: Added.
2280         (main):
2281
2282 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2283
2284         Improve GDB backtrace generation for GTK/EFL
2285         https://bugs.webkit.org/show_bug.cgi?id=128928
2286
2287         Reviewed by Carlos Garcia Campos.
2288
2289         The PID of the crashed process is now correctly supplied to the
2290         crash log reporter. The kernel core_pattern needs to be updated
2291         after this change to something like:
2292
2293         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
2294
2295         * Scripts/process-linux-coredump: Added.
2296         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
2297         * Scripts/webkitpy/port/efl.py:
2298         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
2299         * Scripts/webkitpy/port/gtk.py:
2300         (GtkPort._get_crash_log): Ditto.
2301         * Scripts/webkitpy/port/linux_get_crash_log.py:
2302         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
2303         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
2304         (GDBCrashLogGenerator): Deleted.
2305         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2306         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
2307         * WebKitTestRunner/TestController.cpp:
2308         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
2309         (WTR::TestController::databaseProcessDidCrash): Ditto.
2310         (WTR::TestController::processDidCrash): Ditto.
2311
2312 2016-07-23  Youenn Fablet  <youenn@apple.com>
2313
2314         WPT stash server should be kept running when launching wpt server
2315         https://bugs.webkit.org/show_bug.cgi?id=160052
2316
2317         Reviewed by Sam Weinig.
2318
2319         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2320         (main): waiting to read stdin while stash server is started.
2321
2322 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2323
2324         Media controls should be displayed for media in media documents
2325         https://bugs.webkit.org/show_bug.cgi?id=160104
2326         <rdar://problem/27438936>
2327
2328         Reviewed by Myles C. Maxfield.
2329
2330         Verifies that even a small video with audio in a media document gets media controls.
2331
2332         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2333         (TestWebKitAPI::TEST):
2334
2335 2016-07-22  Michael Saboff  <msaboff@apple.com>
2336
2337         REGRESSION(203616): no FTL testing was inadvertently removed
2338         https://bugs.webkit.org/show_bug.cgi?id=160100
2339
2340         Rubber-stamped by Filip Pizlo.
2341
2342         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
2343         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
2344         logic for the runLayout and runNoisy variants to match the run test logic,
2345         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
2346         enabled platforms.
2347
2348         * Scripts/run-jsc-stress-tests:
2349
2350 2016-07-22  Brady Eidson  <beidson@apple.com>
2351
2352         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
2353         https://bugs.webkit.org/show_bug.cgi?id=160089
2354
2355         Reviewed by Darin Adler.
2356
2357         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2358         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
2359         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
2360
2361 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
2362
2363         [GTK] Improved exclusion patterns in make-dist.py manifest.
2364         https://bugs.webkit.org/show_bug.cgi?id=160094
2365
2366         Reviewed by Michael Catanzaro.
2367
2368         * gtk/manifest.txt.in:
2369         Exclude Platform*.cmake files for more ports.
2370         Removed obsolete .gyp and .pro.user patterns.
2371         Exclude 'Configurations' and 'spi' directories.
2372         Exclude CMakeLists.txt.user (Qt Creator IDE).
2373
2374 2016-07-22  Michael Saboff  <msaboff@apple.com>
2375
2376         Don't run FTL related JSC stress tests on non-FTL platforms
2377         https://bugs.webkit.org/show_bug.cgi?id=160033
2378
2379         Reviewed by Mark Lam.
2380
2381         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
2382         Refactored several of the runXXX test methods to always runXXXDefault and made those
2383         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
2384         doesn't cause a problem.
2385
2386         * Scripts/run-jsc-stress-tests:
2387
2388 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
2389
2390         IWebView::mainFrame crashes if called after IWebView::close
2391         https://bugs.webkit.org/show_bug.cgi?id=32868
2392
2393         Reviewed by Brent Fulgham.
2394
2395         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2396         (TestWebKitAPI::TEST_F): Added test.
2397
2398 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2399
2400         [GTK] Enable threaded compositor by default
2401         https://bugs.webkit.org/show_bug.cgi?id=160079
2402
2403         Reviewed by Žan Doberšek.
2404
2405         * Scripts/webkitperl/FeatureList.pm:
2406
2407 2016-07-22  Youenn Fablet  <youenn@apple.com>
2408
2409         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
2410         https://bugs.webkit.org/show_bug.cgi?id=159921
2411
2412         Reviewed by Brian Burg.
2413
2414         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
2415
2416         * Scripts/webkitpy/codegen/main.py:
2417         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
2418         (BuiltinsGeneratorTests):
2419         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
2420         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
2421         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
2422         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
2423
2424 2016-07-21  Dan Bernstein  <mitz@apple.com>
2425
2426         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
2427         https://bugs.webkit.org/show_bug.cgi?id=160072
2428
2429         Reviewed by Andy Estes.
2430
2431         * Scripts/webkitdirs.pm:
2432         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
2433           for old Xcode versions.
2434         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
2435           to readXcodeUserDefault.
2436         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
2437           debugger.
2438         (determineDebugger): Ditto.
2439         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
2440           7.0.
2441         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
2442           switches.
2443         (execMacWebKitAppForDebugging): Removed support for GDB.
2444
2445 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2446
2447         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2448         https://bugs.webkit.org/show_bug.cgi?id=160066
2449
2450         Reviewed by Dean Jackson.
2451
2452         * DumpRenderTree/mac/DumpRenderTree.mm:
2453         (setDefaultsToConsistentValuesForTesting): Deleted.
2454         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2455         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2456         * WebKitTestRunner/TestController.cpp:
2457         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2458         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2459         (WTR::initializeWebViewConfiguration): Deleted.
2460
2461 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
2462
2463         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2464         https://bugs.webkit.org/show_bug.cgi?id=159980
2465         rdar://problem/27450825
2466
2467         Reviewed by Dan Bernstein.
2468
2469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2470         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2471         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2472         when our delegate has hit -dealloc.
2473         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
2474         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
2475         will not be messaged.
2476
2477 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2478
2479         Follow-up patch to r203520
2480         https://bugs.webkit.org/show_bug.cgi?id=159967
2481         <rdar://problem/26964090>
2482
2483         Unreviewed.
2484
2485         * DumpRenderTree/mac/DumpRenderTree.mm:
2486         (setDefaultsToConsistentValuesForTesting):
2487         * WebKitTestRunner/TestController.cpp:
2488         (WTR::TestController::resetPreferencesToConsistentValues):
2489
2490 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2491
2492         [iPhone] Playing a video on tudou.com plays only sound, no video
2493         https://bugs.webkit.org/show_bug.cgi?id=159967
2494         <rdar://problem/26964090>
2495
2496         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2497
2498         Migrate tests to use new SPI.
2499
2500         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2501         (RequiresUserActionForPlaybackTest::SetUp):
2502         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2503         (WTR::initializeWebViewConfiguration):
2504
2505 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
2506
2507         Clarify testing mode names in run-jsc-stress-tests
2508         https://bugs.webkit.org/show_bug.cgi?id=160021
2509
2510         Reviewed by Mark Lam.
2511
2512         Default should mean really default, not default with disabled FTL, renamed
2513         - runMozillaTestDefault to runMozillaTestNoFTL
2514         - runMozillaTestDefaultFTL to runMozillaTestDefault
2515         - runDefault to runNoFTL
2516         - runDefaultFTL to runDefault
2517         - runLayoutTestDefault to runLayoutTestNoFTL
2518         - runLayoutTestDefaultFTL to runLayoutTestDefault
2519         - runNoisyTestDefault to runNoisyTestNoFTL
2520         - runNoisyTestDefaultFTL to runNoisyTestDefault
2521
2522         * Scripts/run-jsc-stress-tests:
2523
2524 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
2525
2526         WebBackForwardList's currentIndex could get out of bounds when filtering items.
2527         https://bugs.webkit.org/show_bug.cgi?id=159986
2528
2529         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
2530         to 0.
2531
2532         Reviewed by Dan Bernstein.
2533
2534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2535         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
2536         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
2537         (TEST):
2538
2539 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2540
2541         [GTK] Web view background colors don't work in accelerated compositing mode
2542         https://bugs.webkit.org/show_bug.cgi?id=159455
2543
2544         Reviewed by Michael Catanzaro.
2545
2546         Set always RGBA visual to the view widget when setting a background color.
2547
2548         * MiniBrowser/gtk/BrowserWindow.c:
2549         (browser_window_set_background_color):
2550
2551 2016-07-20  Youenn Fablet  <youenn@apple.com>
2552
2553         Bots should run built-ins generator tests
2554         https://bugs.webkit.org/show_bug.cgi?id=159971
2555
2556         Reviewed by Alexey Proskuryakov.
2557
2558         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2559         (RunBuiltinsTests): New step to run built-in generator tests.
2560         (TestFactory.__init__): Adding an additional step for bultin generator tests.
2561         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
2562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
2563
2564 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2565
2566         Revert temporary fix r203417
2567         https://bugs.webkit.org/show_bug.cgi?id=160001
2568
2569         Reviewed by Alexey Proskuryakov.
2570
2571         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
2572
2573 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2574
2575         REGRESSION(r148588): ews classes might get garbage collected
2576         https://bugs.webkit.org/show_bug.cgi?id=159990
2577
2578         Reviewed by Ryosuke Niwa.
2579
2580         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
2581         in a variable so that they do not get garbage collected.
2582
2583 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
2584
2585         Add API test for layout constraints after exit fullscreen
2586         https://bugs.webkit.org/show_bug.cgi?id=159900
2587
2588         Reviewed by Jon Lee.
2589
2590         Added Fullscreen.LaytoutConstraints API test. 
2591         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
2592
2593         This test compares layout constraints on the web view before and after fullscreen to make sure 
2594         they are preserved.
2595
2596         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
2597         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
2598         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2599         (TestWebKitAPI::TEST):
2600
2601 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
2602
2603         Disable two failing API tests.
2604
2605         Unreviewed test gardening.
2606
2607         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2608         (TestWebKitAPI::TEST):
2609
2610 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2611
2612         Unreviewed iOS build fix.
2613
2614         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
2615
2616 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2617
2618         Media controls don't appear when pausing a small autoplaying video
2619         https://bugs.webkit.org/show_bug.cgi?id=159972
2620         <rdar://problem/27180657>
2621
2622         Reviewed by Beth Dakin.
2623
2624         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
2625         for simulating basic user interaction in VideoControlsManager.
2626
2627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2628         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2629         (-[WKWebView mouseDownAtPoint:]):
2630         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2631         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2632         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2633         (TestWebKitAPI::TEST):
2634         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2635
2636 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2637
2638         [Win] MathML fonts are not found.
2639         https://bugs.webkit.org/show_bug.cgi?id=159920
2640
2641         Reviewed by Alex Christensen.
2642
2643         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2644         for a specific registry key value.
2645
2646         * Scripts/webkitdirs.pm:
2647         (fontExists):
2648
2649 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2650
2651         Improve prepare-ChangeLog for @media blocks
2652         https://bugs.webkit.org/show_bug.cgi?id=159907
2653
2654         Reviewed by Timothy Hatcher.
2655
2656         * Scripts/prepare-ChangeLog:
2657         (get_selector_line_ranges_for_css):
2658         Get a range for @media blocks just like a selector.
2659             Start Line = line with '{'
2660             End line = line with '}'
2661             Name = "@media ..."
2662
2663         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2664         Improved error messages for unbalanced portions.
2665
2666         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2667         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2668         (.media-query::before):
2669         (@media only screen and (max-width: 980px)):
2670         (.media-query a):
2671         (@media (-webkit-min-device-pixel-ratio: 2)):
2672         (.both a):
2673         (.both b):
2674         (.media-query b):
2675         (.media-query::after):
2676
2677 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2678
2679         Fix expectedFailErrorHandler in run-jsc-stress-tests
2680         https://bugs.webkit.org/show_bug.cgi?id=159811
2681
2682         Reviewed by Yusuke Suzuki.
2683
2684         * Scripts/run-jsc-stress-tests:
2685
2686 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2687
2688         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2689
2690         * TestWebKitAPI/PlatformMac.cmake:
2691
2692 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2693
2694         The default testing mode should not involve disabling the FTL JIT
2695         https://bugs.webkit.org/show_bug.cgi?id=159929
2696
2697         Rubber stamped by Mark Lam and Saam Barati.
2698         
2699         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2700         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2701         FTL was not the default. You had to enable it with an option.
2702         
2703         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2704         all of the major ports. This has become a serious pain. For example, it's useful to be able
2705         to say that a test should only run in the default config that is representative of what a
2706         normal user would see if they ran JSC. Clearly, this would be a config that does not
2707         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2708         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2709         
2710         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2711         try to fix it, because:
2712         
2713         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2714           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2715           doesn't do anything. The code is not really structured to allow this.
2716         
2717         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2718           disabled in testing. On the other hand there are already build bots that do FTL tests
2719           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2720           preserving this broken feature, we should create something that (a) acknowledges the fact
2721           that the FTL is the default on those platforms that support it and (b) avoids running
2722           no-ftl tests on precisely those platforms that don't have FTL.
2723         
2724         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2725           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2726           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2727           pretending that the FTL JIT is not the default just because some bots used that as an
2728           optimization.
2729         
2730         This change allows me to speed up some debug tests and paint some bots green.
2731
2732         * Scripts/run-javascriptcore-tests:
2733         (runJSCStressTests):
2734         * Scripts/run-jsc-stress-tests:
2735
2736 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2737
2738         Fix API test after r203426.
2739         https://bugs.webkit.org/show_bug.cgi?id=159949
2740
2741         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2742         (TEST):
2743         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2744         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2745
2746 2016-07-19  Andy Estes  <aestes@apple.com>
2747
2748         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2749         https://bugs.webkit.org/show_bug.cgi?id=159956
2750
2751         Reviewed by Dan Bernstein.
2752
2753         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2754         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2755         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2756         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2757
2758 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2759
2760         Add regression test for r203392
2761         https://bugs.webkit.org/show_bug.cgi?id=159949
2762
2763         Reviewed by Brady Eidson.
2764
2765         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2766         (fileSize):
2767         (swizzledBundleIdentifierWebBookmarksD):
2768         (defaultApplicationCacheDirectory):
2769         (TEST):
2770         (swizzledBundleIdentifierMobileSafari): Deleted.
2771         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2772         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2773         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2774
2775 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2776
2777         Add regression test for r203392
2778         https://bugs.webkit.org/show_bug.cgi?id=159949
2779
2780         Reviewed by Brady Eidson.
2781
2782         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2783         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2784         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2785         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2786         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2787         (TEST):
2788         (fileSize):
2789         (swizzledBundleIdentifierMobileSafari):
2790         (swizzledBundleIdentifierWebBookmarksD):
2791         (defaultApplicationCacheDirectory):
2792         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2793         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2794         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2795         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2796
2797 2016-07-19  Keith Miller  <keith_miller@apple.com>
2798
2799         Test262 should have a file with the revision and url
2800         https://bugs.webkit.org/show_bug.cgi?id=159937
2801
2802         Reviewed by Mark Lam.
2803
2804         The import script should update the information from
2805         the path to the test262 repository it gets.
2806
2807         * Scripts/import-test262-tests:
2808
2809 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2810
2811         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2812         To be deleted once the root cause is found and addressed.
2813
2814         * EWSTools/start-queue-mac.sh:
2815
2816 2016-07-19  Frederic Wang  <fwang@igalia.com>
2817
2818         [win] Fixup the register name for STIX Math and Latin Modern Math
2819
2820         Unreviewed follow-up of r203406
2821
2822         * Scripts/webkitdirs.pm:
2823         (checkInstalledTools):
2824
2825 2016-07-19  Frederic Wang  <fwang@igalia.com>
2826
2827         [win] Update the list of MathML fonts
2828         https://bugs.webkit.org/show_bug.cgi?id=156838
2829
2830         The set of recommended math fonts is now described at
2831         https://trac.webkit.org/wiki/MathML/Fonts
2832         We update the Perl script to use the latest list of fonts.
2833
2834         Reviewed by Brent Fulgham.
2835
2836         * Scripts/webkitdirs.pm:
2837         (checkInstalledTools):
2838
2839 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2840
2841         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2842         https://bugs.webkit.org/show_bug.cgi?id=159342
2843
2844         Reviewed by Darin Adler.
2845
2846         Implement required functions in event sender.
2847
2848         * DumpRenderTree/PlatformWin.cmake:
2849         * DumpRenderTree/win/EventSender.cpp:
2850         (monitorWheelEvents): Added.
2851         (callAfterScrollingCompletes): Added.
2852
2853 2016-07-19  Youenn Fablet  <youenn@apple.com>
2854
2855         Add new aliases to http test server
2856         https://bugs.webkit.org/show_bug.cgi?id=159878
2857
2858         Reviewed by Darin Adler.
2859
2860         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2861         Adding explicitly these links to perl script.
2862         Extracting default alias in an aliases.json file.
2863         Reading that file from python scripts to initialize aliases from that file.
2864
2865         Python script changes covered by unit tests and changed layout test.
2866
2867         * Scripts/webkitperl/httpd.pm:
2868         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2869         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2870         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2871         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2872         Adding -c directives for each alias.
2873         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2874         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2875         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2876         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2877         Adding alias directive for each alias.
2878         (Lighttpd._prepare_config):
2879         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2880         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2881         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2882         layout tests directory.
2883         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2884         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2885         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2886
2887 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2888
2889         EWS console logs doesn't go to log file
2890         https://bugs.webkit.org/show_bug.cgi?id=159539
2891         <rdar://problem/24464570>
2892
2893         Reviewed by David Kilzer.
2894
2895         * Scripts/webkitpy/common/system/logutils.py:
2896         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2897         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2898         to filesystem. It also supports passing MockFilesystem.
2899         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2900         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2901         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2902         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2903         (_test_ews): Same.
2904         * Scripts/webkitpy/tool/commands/queues.py:
2905         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2906         (AbstractQueue._log_directory): Using filesystem object instead of os.
2907         (AbstractQueue.queue_log_path): Same.
2908         (AbstractQueue.__init__): Passed host parameter.
2909         (PatchProcessingQueue.__init__): Same.
2910         (CommitQueue.__init__): Same.
2911         (AbstractReviewQueue.__init__): Same.
2912         (StyleQueue.__init__): Same.
2913         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2914         (TestCommitQueue): Passed MockHost() as host.
2915         (TestCommitQueue.__init__): Same.
2916         (TestQueue.__init__): Same.
2917         (TestReviewQueue.__init__): Same.
2918         (TestFeederQueue.__init__): Same.
2919         (AbstractPatchQueueTest.test_next_patch): Same.
2920         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2921         (test_commit_queue_failure): Same.
2922         (MockCommitQueueTask.results_from_patch_test_run): Same.
2923         (test_rollout_lands): Same.
2924         (test_non_valid_patch): Same.
2925         (test_auto_retry): Same.
2926         (test_style_queue_with_watch_list_exception): Same.
2927
2928 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2929
2930         WTF::Lock should be fair eventually
2931         https://bugs.webkit.org/show_bug.cgi?id=159384
2932
2933         Reviewed by Geoffrey Garen.
2934
2935         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2936
2937 2016-07-17  Sam Weinig  <sam@webkit.org>
2938
2939         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2940         <rdar://problem/26554137>
2941         https://bugs.webkit.org/show_bug.cgi?id=159856
2942
2943         Reviewed by Dan Bernstein.
2944
2945         * MiniBrowser/mac/WK2BrowserWindowController.m:
2946         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2947         Add basic window.open implementation.
2948
2949         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2950         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2951         to open a single non-web URL, all others are dropped.
2952
2953         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2954         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2955         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2956         Add API for the new SPI.
2957
2958 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2959
2960         [JSC] Enable test262 module tests
2961         https://bugs.webkit.org/show_bug.cgi?id=159854
2962
2963         Reviewed by Saam Barati.
2964
2965         Use --module-file instead.
2966
2967         * Scripts/run-jsc-stress-tests:
2968
2969 2016-07-16  Chris Dumez  <cdumez@apple.com>
2970
2971         Unreviewed, rolling out r203318.
2972
2973         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2974         SunSpider)
2975
2976         Reverted changeset:
2977
2978         "[JSC] Change some parameters based on a random search"
2979         https://bugs.webkit.org/show_bug.cgi?id=158514
2980         http://trac.webkit.org/changeset/203318
2981
2982 2016-07-16  Chris Dumez  <cdumez@apple.com>
2983
2984         Add move constructor / assignment operator to ListHashSet
2985         https://bugs.webkit.org/show_bug.cgi?id=159837
2986
2987         Reviewed by Darin Adler.
2988
2989         Add API tests.
2990
2991         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2992         (TestWebKitAPI::TEST):
2993
2994 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2995
2996         [JSC] Change some parameters based on a random search
2997         https://bugs.webkit.org/show_bug.cgi?id=158514
2998
2999         Reviewed by Saam Barati.
3000
3001         * Scripts/run-jsc-stress-tests:
3002
3003 2016-07-15  Jon Davis  <jond@apple.com>
3004
3005         Changed the start page URL for WebKit Nightly builds.
3006         https://bugs.webkit.org/show_bug.cgi?id=159816
3007
3008         Reviewed by Timothy Hatcher.
3009
3010         * WebKitLauncher/start.html:
3011
3012 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
3013
3014         Uninitialized variable in DIBPixelData can cause a dangerous memory write
3015         https://bugs.webkit.org/show_bug.cgi?id=159414
3016
3017         Reviewed by Brent Fulgham.
3018
3019         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
3020         when the HDC parameter is invalid.
3021
3022         * TestWebKitAPI/PlatformWin.cmake:
3023         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
3024         (TestWebKitAPI::TEST):
3025
3026 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3027
3028         [GTK] Add basic tabs support to MiniBrowser
3029         https://bugs.webkit.org/show_bug.cgi?id=159803
3030
3031         Reviewed by Sergio Villar Senin.
3032
3033         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
3034         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
3035
3036         * MiniBrowser/gtk/BrowserTab.c: Added.
3037         (titleChanged):
3038         (isLoadingChanged):
3039         (decidePolicy):
3040         (removeChildIfInfoBar):
3041         (loadChanged):
3042         (createInfoBarQuestionMessage):
3043         (tlsErrorsDialogResponse):
3044         (loadFailedWithTLSerrors):
3045         (permissionRequestDialogResponse):
3046         (decidePermissionRequest):
3047         (colorChooserRGBAChanged):
3048         (popoverColorClosed):
3049         (colorChooserRequestFinished):
3050         (runColorChooserCallback):
3051         (inspectorOpenedInWindow):
3052         (inspectorClosed):
3053         (browserTabSetProperty):
3054         (browserTabFinalize):
3055         (browser_tab_init):
3056         (browserTabConstructed):
3057         (browser_tab_class_init):
3058         (getInternalURI):
3059         (browser_tab_new):
3060         (browser_tab_get_web_view):
3061         (browser_tab_load_uri):
3062         (browser_tab_get_title_widget):
3063         (browser_tab_set_status_text):
3064         (browser_tab_toggle_inspector):
3065         (browser_tab_start_search):
3066         (browser_tab_stop_search):
3067         (browser_tab_add_accelerators):
3068         (fullScreenMessageTimeoutCallback):
3069         (browser_tab_enter_fullscreen):
3070         (browser_tab_leave_fullscreen):
3071         * MiniBrowser/gtk/BrowserTab.h: Added.
3072         * MiniBrowser/gtk/BrowserWindow.c:
3073         (getExternalURI):
3074         (browserWindowSetStatusText):
3075         (reloadOrStopCallback):
3076         (goBackCallback):
3077         (goForwardCallback):
3078         (settingsCallback):
3079         (webViewURIChanged):
3080         (browserWindowHistoryItemActivated):
3081         (browserWindowUpdateNavigationActions):
3082         (webViewCreate):
3083         (webViewEnterFullScreen):
3084         (webViewLeaveFullScreen):
3085         (webViewDecidePolicy):
3086         (browserWindowCanZoomIn):
3087         (browserWindowCanZoomOut):
3088         (browserWindowZoomIn):
3089         (browserWindowZoomOut):
3090         (scrollEventCallback):
3091         (faviconChanged):
3092         (webViewIsLoadingChanged):
3093         (defaultZoomCallback):
3094         (searchCallback):
3095         (newTabCallback):
3096         (toggleWebInspector):
3097         (reloadPage):
3098         (reloadPageIgnoringCache):
3099         (stopPageLoad):
3100         (loadHomePage):
3101         (editingCommandCallback):
3102         (insertImageCommandCallback):
3103         (insertLinkCommandCallback):
3104         (browserWindowSetupEditorToolbar):
3105         (browserWindowSwitchTab):
3106         (browserWindowTabAddedOrRemoved):
3107         (browser_window_init):
3108         (browserWindowConstructed):
3109         (browserWindowSaveSession):
3110         (browserWindowDeleteEvent):
3111         (browser_window_new):
3112         (browser_window_append_view):
3113         (browser_window_load_uri):
3114         (browser_window_load_session):
3115         (browser_window_set_background_color):
3116         (resetStatusText): Deleted.
3117         (activateUriEntryCallback): Deleted.
3118         (webViewTitleChanged): Deleted.
3119         (resetEntryProgress): Deleted.
3120         (browserWindowCreateBackForwardMenu): Deleted.
3121         (webViewReadyToShow): Deleted.
3122         (webViewLoadFailed): Deleted.
3123         (webViewMouseTargetChanged): Deleted.
3124         (browserWindowUpdateZoomActions): Deleted.
3125         (webViewZoomLevelChanged): Deleted.
3126         (updateUriEntryIcon): Deleted.
3127         (zoomInCallback): Deleted.
3128         (zoomOutCallback): Deleted.
3129         (toggleFullScreen): Deleted.
3130         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
3131         (browserWindowFinalize): Deleted.
3132         (browser_window_class_init): Deleted.
3133         * MiniBrowser/gtk/BrowserWindow.h:
3134         * MiniBrowser/gtk/CMakeLists.txt:
3135         * MiniBrowser/gtk/main.c:
3136         (createBrowserTab):
3137         (aboutURISchemeRequestCallback):
3138         (main):
3139         (parseBackgroundColor): Deleted.
3140
3141 2016-07-14  Alex Christensen  <achristensen@webkit.org>
3142
3143         Allow RefPtrs of const RefCounted types
3144         https://bugs.webkit.org/show_bug.cgi?id=158269
3145
3146         Reviewed by Anders Carlsson.
3147
3148         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3149         (TestWebKitAPI::TEST):
3150         (TestWebKitAPI::ConstRefCounted::create):
3151         (TestWebKitAPI::returnConstRefCountedRef):
3152         (TestWebKitAPI::returnRefCountedRef):
3153
3154 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3155
3156         Test WTF.StringViewIterators is crashing since r203119
3157         https://bugs.webkit.org/show_bug.cgi?id=159710
3158
3159         Reviewed by Darin Adler.
3160
3161         There are two problems in the test case added in r203119. First is that it's testing
3162         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
3163         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
3164         const reference to the string view member of the deleted CodePoints object.
3165
3166         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3167         (TestWebKitAPI::TEST):
3168
3169 2016-07-13  Daniel Bates  <dabates@apple.com>
3170
3171         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
3172         https://bugs.webkit.org/show_bug.cgi?id=159738
3173         <rdar://problem/27304649>
3174
3175         Reviewed by Dan Bernstein.
3176
3177         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
3178         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
3179         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
3180         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
3181
3182         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3183         * WebKitTestRunner/ios/TestControllerIOS.mm:
3184         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
3185         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
3186
3187 2016-07-13  Beth Dakin  <bdakin@apple.com>
3188
3189         Attempted build fix.
3190
3191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3192
3193 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
3194
3195         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
3196         https://bugs.webkit.org/show_bug.cgi?id=159686
3197
3198         Reviewed by Chris Dumez.
3199
3200         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
3201
3202         * WebKitTestRunner/TestController.cpp:
3203         (WTR::runOpenPanel):
3204         (WTR::TestController::createOtherPage):
3205         (WTR::TestController::createWebViewWithOptions):
3206
3207 2016-07-13  Beth Dakin  <bdakin@apple.com>
3208
3209         Add more candidate tests
3210         https://bugs.webkit.org/show_bug.cgi?id=159730
3211
3212         Reviewed by Tim Horton.
3213
3214         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
3215         two new tests to that file.
3216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3217         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
3218         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
3219         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
3220         (TestWebKitAPI::TEST):
3221         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
3222
3223 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
3224
3225         AX: [ATK] spinbutton-crash.html fails
3226         https://bugs.webkit.org/show_bug.cgi?id=159723
3227
3228         Reviewed by Chris Fleizach.
3229
3230         Implement support for AXDecrementButton and AXIncrementButton in
3231         ATK's AccessibilityUIElement::uiElementAttributeValue().
3232
3233         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3234         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3235
3236 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3237
3238         [EFL] [GTK] Enable back crypto subtle on development builds.
3239         https://bugs.webkit.org/show_bug.cgi?id=159260
3240
3241         Reviewed by Carlos Garcia Campos.
3242
3243         * Scripts/webkitperl/FeatureList.pm:
3244
3245 2016-07-12  Mark Lam  <mark.lam@apple.com>
3246
3247         We should use different stack limits for stack checks from JS and host code.
3248         https://bugs.webkit.org/show_bug.cgi?id=159442
3249         <rdar://problem/26889188>
3250
3251         Reviewed by Geoffrey Garen.
3252
3253         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
3254         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
3255         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
3256         order to keep the js/regress-139548.html test happy with this patch.
3257
3258         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
3259         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
3260
3261         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3262         (-[LTRelayController _environmentVariables]):
3263         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3264         (main):
3265
3266 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
3267
3268         platformUserPreferredLanguages on Mac should not try to put the region into the language
3269         https://bugs.webkit.org/show_bug.cgi?id=159693
3270
3271         Rubber stamped by Alexey Proskuryakov.
3272         
3273         Revert the test change in r200105.
3274
3275         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
3276         (TestWebKitAPI::languageForSystemLanguage):
3277
3278 2016-07-12  Chris Dumez  <cdumez@apple.com>
3279
3280         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
3281         https://bugs.webkit.org/show_bug.cgi?id=159663
3282         <rdar://problem/18995873>
3283
3284         Reviewed by Benjamin Poulain.
3285
3286         Add API test coverage.
3287
3288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3289         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
3290         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
3291         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
3292         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
3293         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
3294         (TEST):
3295
3296 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
3297
3298         Relax ordering requirements on StringView::CodePoints iterator
3299         https://bugs.webkit.org/show_bug.cgi?id=159609
3300
3301         Reviewed by Darin Adler.
3302
3303         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3304         (TestWebKitAPI::TEST):
3305
3306 2016-07-12  Youenn Fablet  <youenn@apple.com>
3307
3308         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
3309         https://bugs.webkit.org/show_bug.cgi?id=159564
3310
3311         Reviewed by Brian Burg.
3312
3313         * Scripts/webkitpy/codegen/main.py:
3314         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
3315
3316 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3317
3318         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
3319         https://bugs.webkit.org/show_bug.cgi?id=159671
3320
3321         Reviewed by Csaba Osztrogonác.
3322
3323         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
3324         https://bugs.webkit.org/show_bug.cgi?id=89235
3325
3326         So this guard can be removed in build scripts.
3327
3328         * Scripts/webkitperl/FeatureList.pm:
3329         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3330
3331 2016-07-11  Jason Marcell  <jmarcell@apple.com>
3332
3333         SVN.create_patch should find svn-create-patch relative to the WebKit root.
3334         https://bugs.webkit.org/show_bug.cgi?id=159652
3335
3336         Reviewed by Daniel Bates.
3337
3338         * Scripts/webkitpy/common/checkout/scm/svn.py:
3339         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
3340
3341 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
3342
3343         Implement grapheme cluster iterator on StringView
3344         https://bugs.webkit.org/show_bug.cgi?id=159598
3345
3346         Reviewed by Anders Carlsson.
3347
3348         This is in preparation for honoring the second argument to FontFaceSet.load().
3349
3350         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3351         (TestWebKitAPI::compareLoopIterations):
3352         (TestWebKitAPI::TEST):
3353
3354 2016-07-11  Nan Wang  <n_wang@apple.com>
3355
3356         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
3357         https://bugs.webkit.org/show_bug.cgi?id=158364
3358
3359         Reviewed by Anders Carlsson.
3360
3361         Added a function in TestRunner so that we can toggle the ignoring viewport
3362         scale limits setting. Also added a test option for that in order to change the 
3363         configuration of the webview in test.
3364
3365         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3366         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3367         (WTR::TestRunner::setNavigationGesturesEnabled):
3368         (WTR::TestRunner::setIgnoresViewportScaleLimits):
3369         (WTR::nextUIScriptCallbackID):
3370         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3371         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3372         * WebKitTestRunner/TestController.cpp:
3373         (WTR::TestController::resetStateToConsistentValues):
3374         (WTR::updateTestOptionsFromTestHeader):
3375         (WTR::TestController::setNavigationGesturesEnabled):
3376         (WTR::TestController::setIgnoresViewportScaleLimits):
3377         (WTR::TestController::platformWillRunTest):
3378         * WebKitTestRunner/TestController.h:
3379         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3380         * WebKitTestRunner/TestInvocation.cpp:
3381         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3382         * WebKitTestRunner/TestOptions.h:
3383         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3384         (WTR::TestController::platformCreateWebView):
3385
3386 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
3387
3388         [GTK] install-dependencies should not install packages built by jhbuild.
3389         https://bugs.webkit.org/show_bug.cgi?id=159628
3390
3391         Reviewed by Michael Catanzaro.
3392
3393         * gtk/install-dependencies:
3394         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
3395
3396 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
3397
3398         System proxy settings not used when building deps with jhbuild
3399         https://bugs.webkit.org/show_bug.cgi?id=159567
3400
3401         Reviewed by Michael Catanzaro.
3402
3403         This adds the gsettings-desktop-schemas-devel build dep to enable
3404         the libgiognomeproxy.so gio module in glib-networking, which uses
3405         GSettings on org.gnome.system.proxy.
3406         This is needed to query system proxy settings for Gnome desktops.
3407
3408         dconf can be manually added to jhbuild to build the
3409         libdconfsettings.so gio module for GSettings, so that
3410         libgiognomeproxy.so can access system settings.
3411           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
3412
3413         As an alternative to dconf settings, this commit also adds the
3414         libproxy-devel build dep to enable the libgiolibproxy.so module in
3415         glib-networking (suggested by Fujii Hironori).
3416
3417         It is useful to read proxy settings from environment variables.
3418         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
3419         environment variable to force using the envvar module in libproxy.
3420
3421         * gtk/install-dependencies:
3422
3423 2016-07-11  Mark Lam  <mark.lam@apple.com>
3424
3425         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
3426         https://bugs.webkit.org/show_bug.cgi?id=159524
3427
3428         Reviewed by Michael Saboff.
3429
3430         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
3431         Also fixed up some tests to behave better to work with this new limit.  This
3432         should make stack overflow tests complete sooner.
3433
3434         * Scripts/run-jsc-stress-tests:
3435         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3436         (main):
3437
3438 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3439
3440         [GTK] Whitespace fixes in install-dependencies script
3441
3442         Unreviewed.
3443
3444         * gtk/install-dependencies:
3445
3446 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3447
3448         [GTK] Install missing Fedora dependencies
3449
3450         Unreviewed.
3451
3452         * gtk/install-dependencies:
3453
3454 2016-07-09  Dan Bernstein  <mitz@apple.com>
3455
3456         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
3457         https://bugs.webkit.org/show_bug.cgi?id=159600
3458
3459         Reviewed by Daniel Bates.
3460
3461         * Scripts/git-add-reviewer:
3462         Added the -s|--rubber-stamp option.
3463         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
3464           new option.
3465
3466 2016-07-08  Andy Estes  <aestes@apple.com>
3467
3468         [Content Filtering] Load blocked pages more like other error pages are loaded
3469         https://bugs.webkit.org/show_bug.cgi?id=159485
3470         <rdar://problem/26014076>
3471
3472         Reviewed by Brady Eidson.
3473
3474         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3475         to a content filtering provisional navigation failure is ignored in preference of
3476         ContentFilter's own error page.
3477
3478         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3479         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3480         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3481         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3482         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3483         (loadAlternateTest):
3484         (TEST):
3485         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3486         (-[MockContentFilterEnabler initWithCoder:]):
3487         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3488         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3489         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3490         (TestWebKitAPI::loadAlternateTest):
3491         (TestWebKitAPI::TEST):
3492
3493 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3494
3495         Unreviewed, rolling out r202944.
3496         https://bugs.webkit.org/show_bug.cgi?id=159570
3497
3498         caused some tests to crash under GuardMalloc (Requested by
3499         estes on #webkit).
3500
3501         Reverted changeset:
3502
3503         "[Content Filtering] Load blocked pages more like other error
3504         pages are loaded"
3505         https://bugs.webkit.org/show_bug.cgi?id=159485
3506         http://trac.webkit.org/changeset/202944
3507
3508 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
3509
3510         Remove mrobinson from the MathML watchlist
3511         https://bugs.webkit.org/show_bug.cgi?id=159559
3512
3513         Reviewed by Philippe Normand.
3514
3515         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
3516
3517 2016-07-08  Brady Eidson  <beidson@apple.com>
3518
3519         Clearing LocalStorage doesn't also delete -wal and -shm files.
3520         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
3521
3522         Reviewed by Brent Fulgham.
3523         Also helpfully picked over by Andy "Never Forgets" Estes.
3524
3525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3526         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
3527         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
3528
3529 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
3530
3531         Removed Qt leftovers from Tools.
3532         https://bugs.webkit.org/show_bug.cgi?id=159557
3533
3534         Reviewed by Csaba Osztrogonác.
3535
3536         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3537         Removed 'qt' platform config.
3538         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3539         Deleted non-functional e-mail address.
3540
3541 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3542
3543         Unreviewed, rolling out r202967.
3544         https://bugs.webkit.org/show_bug.cgi?id=159556
3545
3546         This patch caused crashes in https tests on Windows (Requested
3547         by perarne on #webkit).
3548
3549         Reverted changeset:
3550
3551         "[Win] The test http/tests/security/contentSecurityPolicy
3552         /upgrade-insecure-requests/basic-upgrade.https.html is
3553         failing."
3554         https://bugs.webkit.org/show_bug.cgi?id=159510
3555         http://trac.webkit.org/changeset/202967
3556
3557 2016-07-08  Youenn Fablet  <youenn@apple.com>
3558
3559         Generate WebCore builtin wrapper files
3560         https://bugs.webkit.org/show_bug.cgi?id=159461
3561
3562         Reviewed by Brian Burg.
3563
3564         * Scripts/webkitpy/codegen/main.py:
3565         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
3566         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
3567
3568 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
3569
3570         [EFL] Fix build when media-stream is enabled.
3571         https://bugs.webkit.org/show_bug.cgi?id=159206
3572
3573         Bump up the openwebrtc to find the correct package.
3574
3575         Reviewed by Gyuyoung Kim.
3576
3577         * efl/jhbuild.modules:
3578         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
3579
3580 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3581
3582         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
3583         https://bugs.webkit.org/show_bug.cgi?id=159510
3584
3585         Reviewed by Brent Fulgham.
3586
3587         Allow any https certificate when running tests.
3588
3589         * DumpRenderTree/win/DumpRenderTree.cpp:
3590         (runTest):
3591
3592 2016-07-07  Beth Dakin  <bdakin@apple.com>
3593
3594         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3595         https://bugs.webkit.org/show_bug.cgi?id=159532
3596         -and corresponding-
3597         rdar://problem/27177179
3598
3599         Reviewed by Tim Horton.
3600
3601         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
3602         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
3603
3604 2016-07-07  Andy Estes  <aestes@apple.com>
3605
3606         [Content Filtering] Load blocked pages more like other error pages are loaded
3607         https://bugs.webkit.org/show_bug.cgi?id=159485
3608         <rdar://problem/26014076>
3609
3610         Reviewed by Brady Eidson.
3611
3612         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3613         to a content filtering provisional navigation failure is ignored in preference of
3614         ContentFilter's own error page.
3615
3616         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3617         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3618         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3619         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3620         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3621         (loadAlternateTest):
3622         (TEST):
3623         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3624         (-[MockContentFilterEnabler initWithCoder:]):
3625         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3626         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3627         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3628         (TestWebKitAPI::loadAlternateTest):
3629         (TestWebKitAPI::TEST):
3630
3631 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3632
3633         Unreviewed: add myself to the reviewers list.
3634
3635         * Scripts/webkitpy/common/config/contributors.json:
3636
3637 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3638
3639         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
3640         https://bugs.webkit.org/show_bug.cgi?id=159509
3641
3642         Reviewed by Alex Christensen.
3643
3644         We should always insert the url in the url map when identifierForInitialRequest
3645         is called. Otherwise we can end up with identifiers not having an entry in the
3646         url map when urls are written to the test output file. 
3647
3648         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3649         (ResourceLoadDelegate::identifierForInitialRequest):
3650
3651 2016-07-06  Tim Horton  <timothy_horton@apple.com>
3652
3653         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3654         https://bugs.webkit.org/show_bug.cgi?id=159498
3655         <rdar://problem/26719903>
3656
3657         Reviewed by Sam Weinig.
3658
3659         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3660         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3661         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3662         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3663         (expectLinkCount):
3664         (TEST):
3665         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3666         when deciding what to linkify.
3667
3668 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3669
3670         Build fix - work around rdar://problem/27196668.
3671
3672         * LayoutTestRelay/Configurations/Base.xcconfig:
3673
3674 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3675
3676         Enhance Windows DRT implementation to support platform scroll wheel events.
3677         https://bugs.webkit.org/show_bug.cgi?id=36002
3678
3679         Reviewed by Brent Fulgham.
3680
3681         Implement function continuousMouseScrollBy in Windows event sender.
3682
3683         * DumpRenderTree/win/EventSender.cpp:
3684         (mouseScrollBy):
3685         (continuousMouseScrollBy):
3686
3687 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3688
3689         [Sierra] Rebaseline tests to use un-mocked system font metrics
3690         https://bugs.webkit.org/show_bug.cgi?id=159311
3691         <rdar://problem/24138411>
3692
3693         Reviewed in person by Alexey Proskuryakov.
3694
3695         Stop mocking the system font on Sierra.
3696
3697         * DumpRenderTree/mac/DumpRenderTree.mm:
3698         (setDefaultsToConsistentValuesForTesting):
3699         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3700         (WTR::InjectedBundle::platformInitialize):
3701
3702 2016-07-05  Brady Eidson  <beidson@apple.com>
3703
3704         Database process crashes deleting a corrupt SQLite database file (null deref).
3705         https://bugs.webkit.org/show_bug.cgi?id=155506.
3706
3707         Reviewed by Alex Christensen.
3708
3709         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3710         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3711         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3712         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3713         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3714         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3715
3716 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3717
3718         run-webkit-tests should print more complete baseline search paths
3719         https://bugs.webkit.org/show_bug.cgi?id=159354
3720
3721         Reviewed by Daniel Bates.
3722
3723         run-webkit-tests used to only print directory names in baseline search paths.
3724         This was ok in basic usage, but quickly got confusing when using
3725         --additional-platform-directory flags.
3726
3727         * Scripts/webkitpy/layout_tests/views/printing.py:
3728         (Printer.print_config):
3729         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3730         (Testprinter.test_print_config):
3731         (Testprinter.test_print_one_line_summary):
3732
3733 2016-07-04  Brady Eidson  <beidson@apple.com>
3734
3735         WebProcesses don't handle DatabaseProcess going away uncleanly..
3736         https://bugs.webkit.org/show_bug.cgi?id=159371
3737
3738         Reviewed by Alex Christensen.
3739
3740         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3741         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3742         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3743         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3744         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3745
3746 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3747
3748         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3749         https://bugs.webkit.org/show_bug.cgi?id=158141
3750
3751         Rubber-stamped by Michael Catanzaro.
3752
3753         Instead of checking for an specific Ubuntu version, query the apt
3754         database to see which version of PHP is available.
3755
3756         * efl/install-dependencies:
3757         * gtk/install-dependencies:
3758
3759 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3760
3761         webkit-patch failure-reason always raises TypeError
3762         https://bugs.webkit.org/show_bug.cgi?id=159394
3763
3764         Reviewed by Benjamin Poulain.
3765
3766         In r170637 (Bug 133067), the first and second arguments of
3767         pluralize were swapped.
3768
3769         * Scripts/webkitpy/tool/commands/queries.py:
3770         (FailureReason._builder_to_explain): Swap the first and second
3771         arguments of pluralize.
3772
3773 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3774
3775         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3776         https://bugs.webkit.org/show_bug.cgi?id=152486
3777
3778         Reviewed by Daniel Bates.
3779
3780         Add launch of web-platform-tests server by run-webkit-httpd.
3781         Add two options to disable starting httpd and web-platform-tests servers.
3782
3783         * Scripts/run-webkit-httpd:
3784         (parse_args):
3785         (main):
3786
3787 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3788
3789         REGRESSION(r189668): Notification tests are flakey
3790         https://bugs.webkit.org/show_bug.cgi?id=159375
3791         <rdar://problem/22760990>
3792
3793         Reviewed by Alexey Proskuryakov.
3794
3795         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3796         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3797         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3798         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3799
3800         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3801         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3802         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3803         global notification ID mapping, causing the wrong notification to be investigated.
3804
3805         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3806         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3807         notification is created or destroyed. However, because this object is implemented outside WebKit,
3808         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3809         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3810         WebNotificationProvider can properly map between the different IDs.
3811
3812         * WebKitTestRunner/TestController.cpp:
3813         (WTR::TestController::runTestingServerLoop):
3814         (WTR::TestController::simulateWebNotificationClick):
3815         * WebKitTestRunner/WebNotificationProvider.cpp:
3816         (WTR::WebNotificationProvider::showWebNotification):
3817         (WTR::removeGlobalIDFromIDMap):
3818         (WTR::WebNotificationProvider::closeWebNotification):
3819         (WTR::WebNotificationProvider::removeNotificationManager):
3820         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3821         (WTR::WebNotificationProvider::reset):
3822         * WebKitTestRunner/WebNotificationProvider.h:
3823
3824 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3825
3826         Simplify LayoutTestRelay
3827         https://bugs.webkit.org/show_bug.cgi?id=159353
3828
3829         Reviewed by Daniel Bates.
3830
3831         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3832         by name and runtime makes no sense.
3833         2. Removed code to create devices, webkitpy always does this in advance.
3834         3. Don't create copies of testing apps - we can install the same one into
3835         each simulator, now that we don't run multiple tester processes in a single simulator.
3836         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3837         5. Removed code that kept testing apps alive in the background.
3838         6. Slightly updated coding style in functions that I touched.
3839
3840         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3841         Updated for what we acually use at this point.
3842
3843         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3844         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3845         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3846         (-[LTRelayController ipcIdentifier]):
3847         (-[LTRelayController processName]):
3848         (-[LTRelayController didReceiveStdoutData:]):
3849         (-[LTRelayController didCrashWithMessage:]):
3850         (-[LTRelayController installApp]):
3851         (-[LTRelayController _environmentVariables]):
3852         (-[LTRelayController launchApp]):
3853         (-[LTRelayController start]):
3854         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3855         (-[LTRelayController uniqueAppPath]): Deleted.
3856         (-[LTRelayController uniqueAppURL]): Deleted.
3857         (-[LTRelayController uniqueAppIdentifier]): Deleted.
3858         (-[LTRelayController createUniqueApp]): Deleted.
3859         * LayoutTestRelay/LayoutTestRelay/main.m:
3860         (usage):
3861         (getRequiredStringArgument):
3862         (main):
3863         (getTestingSimDevice): Deleted.
3864         * Scripts/webkitpy/port/driver.py:
3865         (IOSSimulatorDriver.cmd_line):
3866         * WebKitTestRunner/ios/TestControllerIOS.mm:
3867         (WTR::TestController::platformInitialize):
3868         * WebKitTestRunner/ios/mainIOS.mm:
3869         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3870         * DumpRenderTree/mac/DumpRenderTree.mm:
3871         (dumpRenderTree):
3872         (-[DumpRenderTree applicationDidEnterBackground:]):
3873
3874 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
3875
3876         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3877         https://bugs.webkit.org/show_bug.cgi?id=159344
3878
3879         Reviewed by Alex Christensen.
3880
3881         * DumpRenderTree/CMakeLists.txt:
3882
3883 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3884
3885         Add a runtime flag for DOM iterators
3886         https://bugs.webkit.org/show_bug.cgi?id=159300
3887
3888         Reviewed by Alex Christensen.
3889
3890         * DumpRenderTree/mac/DumpRenderTree.mm:
3891         (resetWebPreferencesToConsistentValues):
3892         * DumpRenderTree/win/DumpRenderTree.cpp:
3893         (resetWebPreferencesToConsistentValues):
3894         * Scripts/webkitperl/FeatureList.pm:
3895         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3896         (WTR::InjectedBundle::beginTesting):
3897         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3898         (WTR::TestRunner::setDOMIteratorEnabled):
3899         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3900
3901 2016-06-30  Tina Liu  <iting_liu@apple.com>
3902
3903         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3904         https://bugs.webkit.org/show_bug.cgi?id=159326
3905
3906         Reviewed by Brady Eidson.
3907
3908         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3909         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3910         (TestWebKitAPI::didFinishLoadForFrame):
3911         (TestWebKitAPI::didChangeBackForwardListForPage):
3912         (TestWebKitAPI::setPageLoaderClient):
3913         Set the page loader client and register for didFinishLoadForFrame and
3914         didChangeBackForwardList callbacks.
3915         (TestWebKitAPI::createSessionStateData):
3916         Load a webpage ("simple.html") and return the session state for this page.
3917         (TestWebKitAPI::TEST):
3918         Restore the page session state with that of "simple.html" without navigation.
3919         Verify that the committed URL is NULL since there's no navigation involved.
3920         Verify that the current item in the back forward list, which should be what
3921         we restored from the session state, has the expected URL.
3922
3923 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
3924
3925         Generators violate bytecode liveness validation
3926         https://bugs.webkit.org/show_bug.cgi?id=159279
3927
3928         Reviewed by Yusuke Suzuki.
3929         
3930         Add Basic to our test harness.
3931
3932         * Scripts/run-javascriptcore-tests:
3933         (runJSCStressTests):
3934
3935 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
3936
3937         [Win][Debug] Assertion fails in TestWTF.
3938         https://bugs.webkit.org/show_bug.cgi?id=159299
3939
3940         Reviewed by Alex Christensen.
3941
3942         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3943         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3944         the assertion failure. Since the variable is actually used, there is no need to use the
3945         UNUSED_PARAM macro.
3946
3947         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3948         (TestWebKitAPI::TEST):
3949
3950 2016-06-30  Youenn Fablet  <youennf@gmail.com>
3951
3952         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
3953         https://bugs.webkit.org/show_bug.cgi?id=159166
3954         <rdar://problem/27051759>
3955
3956         Reviewed by Alexey Proskuryakov.
3957
3958         Setting the certificate directory to the copied config.json.
3959
3960         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3961         (WebPlatformTestServer._copy_webkit_test_files):
3962
3963 2016-06-29  Mark Lam  <mark.lam@apple.com>
3964
3965         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
3966         https://bugs.webkit.org/show_bug.cgi?id=159274
3967
3968         Reviewed by Keith Miller.
3969
3970         * DumpRenderTree/mac/DumpRenderTree.mm:
3971         (DumpRenderTreeMain):
3972
3973 2016-06-29  Alex Christensen  <achristensen@webkit.org>
3974
3975         WKWebView should ask WKNavigationDelegate about bad ssl certificates
3976         https://bugs.webkit.org/show_bug.cgi?id=159176
3977
3978         Reviewed by Sam Weinig.
3979
3980         * MiniBrowser/mac/WK2BrowserWindowController.m:
3981         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3982         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3983         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3984
3985 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3986
3987         [GTK] Add missing install dependency after r202619
3988         https://bugs.webkit.org/show_bug.cgi?id=156716
3989
3990         Unreviewed.
3991
3992         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3993
3994 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3995
3996         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3997         https://bugs.webkit.org/show_bug.cgi?id=156716
3998
3999         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
4000
4001         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
4002         (parse_args):
4003         * Scripts/webkitpy/port/gtk.py:
4004         (GtkPort.__init__):
4005         (GtkPort._driver_class):
4006         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
4007         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
4008         platform directory for storing the wayland specific layout test results and expectations for ${port}.
4009         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
4010         test expectations file on the GTK port when running the tests with the --wayland command line switch.
4011         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
4012         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
4013         (WestonDriver.check_driver):
4014         (WestonDriver.__init__):
4015         (WestonDriver._start):
4016         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
4017         (WestonXvfbDriverDisplayTest):
4018         (WestonXvfbDriverDisplayTest.__init__):
4019         (WestonXvfbDriverDisplayTest._xvfb_run):
4020         (WestonDriverTest.make_driver):
4021         (WestonDriverTest.test_start):
4022         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
4023         or to satisfy the pkg-config check of the new added modules in JHBuild.
4024         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
4025         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
4026         provided by the system are already new enough.
4027         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
4028         It was the only way to get the software EGL rasterizer working without depending on user drivers.
4029         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
4030         feature to avoid building libdrm when the one provided by the system is new enough.
4031         * gtk/jhbuildrc:
4032         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
4033         Xorg had no support for searching the DRI drivers on a custom path at runtime.
4034         This patch implements support for that reusing the same variable that we use with Mesa to set the
4035         custom path for the DRI drivers path.
4036
4037 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
4038
4039         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
4040         https://bugs.webkit.org/show_bug.cgi?id=159256
4041
4042         Reviewed by Philippe Normand.
4043
4044         We need the last fixes in the repository to make the scream queue
4045         work with apprtc.
4046
4047         * gtk/jhbuild.modules:
4048
4049 2016-06-28  Commit Queue  <commit-queue@webkit.org>
4050
4051         Unreviewed, rolling out r202580.
4052         https://bugs.webkit.org/show_bug.cgi?id=159245
4053
4054         Caused all WKTR tests to fail on GuardMalloc and Production
4055         only for unknown reasons, investigating offline. (Requested by
4056         brrian on #webkit).
4057
4058         Reverted changeset:
4059
4060         "RunLoop::Timer should use constructor templates instead of
4061         class templates"
4062         https://bugs.webkit.org/show_bug.cgi?id=159153
4063         http://trac.webkit.org/changeset/202580
4064
4065 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
4066
4067         Use a regex to check if a test step is for JavaScriptCore
4068         https://bugs.webkit.org/show_bug.cgi?id=159224
4069
4070         Reviewed by Geoffrey Garen.
4071
4072         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
4073         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
4074         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4075         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
4076         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
4077         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
4078
4079 2016-06-28  Michael Saboff  <msaboff@apple.com>
4080
4081         btjs no longer accepts optional frame count argument
4082         https://bugs.webkit.org/show_bug.cgi?id=159235
4083
4084         Reviewed by Saam Barati.
4085
4086         Fix the detection of optional backtrace-depth parameter to use the length
4087         of the command.
4088
4089         * lldb/lldb_webkit.py:
4090         (btjs):
4091
4092 2016-06-28  Jon Lee  <jonlee@apple.com>
4093
4094         Update animometer.plan
4095
4096         Rubber-stamped by Said Abou-Hallawa.
4097
4098         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
4099
4100 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
4101
4102         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
4103
4104         * Scripts/run-javascriptcore-tests:
4105         (runJSCStressTests):
4106
4107 2016-06-28  Brian Burg  <bburg@apple.com>
4108
4109         RunLoop::Timer should use constructor templates instead of class templates
4110         https://bugs.webkit.org/show_bug.cgi?id=159153
4111
4112         Reviewed by Alex Christensen.
4113
4114         Remove the RunLoop::Timer class template argument, and pass its constructor
4115         a reference to `this` instead of a pointer to `this`.
4116
4117         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4118         (WTR::TestRunner::TestRunner):
4119         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4120         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
4121         (TestWebKitAPI::TEST):
4122
4123 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
4124
4125         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
4126         https://bugs.webkit.org/show_bug.cgi?id=159199
4127
4128         Reviewed by Alexey Proskuryakov.
4129
4130         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
4131
4132         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
4133         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
4134         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
4135         an input element getting automatically focused on Mac.
4136
4137 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
4138
4139         [Win] Custom elements tests are failing.
4140         https://bugs.webkit.org/show_bug.cgi?id=159139
4141
4142         Reviewed by Alex Christensen.
4143
4144         Enable custom element API when running tests.
4145
4146         * DumpRenderTree/win/DumpRenderTree.cpp:
4147         (resetWebPreferencesToConsistentValues):
4148
4149 2016-06-27  Lucas Forschler  <lforschler@apple.com>
4150
4151         Test commit. Please ignore.
4152         
4153 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
4154
4155         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
4156         https://bugs.webkit.org/show_bug.cgi?id=155073
4157
4158         Reviewed by Daniel Bates.
4159
4160         * Scripts/webkitperl/FeatureList.pm:
4161
4162 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
4163
4164         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
4165         https://bugs.webkit.org/show_bug.cgi?id=159077
4166
4167         Reviewed by Tim Horton.
4168
4169         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
4170
4171         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
4172         which is necessary for UI-side compositing.
4173
4174         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
4175         seems to happen for some tests that call window.resizeTo().
4176
4177         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4178         (WTR::InjectedBundlePage::dump): Deleted.
4179         * WebKitTestRunner/TestInvocation.cpp:
4180         (WTR::TestInvocation::dumpResults):
4181         * WebKitTestRunner/cg/TestInvocationCG.cpp:
4182         (WTR::createCGContextFromImage):
4183         (WTR::computeMD5HashStringForContext):
4184         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
4185         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4186         (WTR::PlatformWebView::windowSnapshotImage):
4187
4188 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4189
4190         [EFL] Support to build on Debian linux
4191         https://bugs.webkit.org/show_bug.cgi?id=159123
4192
4193         Reviewed by Antonio Gomes.
4194
4195         * efl/install-dependencies: Install libgnutls28-dev.
4196
4197 2016-06-27  Alex Christensen  <achristensen@webkit.org>
4198
4199         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
4200         https://bugs.webkit.org/show_bug.cgi?id=159071
4201
4202         Reviewed by Brady Eidson.
4203
4204         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4205         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4206         (WTR::TestRunner::setHandlesAuthenticationChallenges):
4207         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
4208         (WTR::TestRunner::setAuthenticationUsername):
4209         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4210         * WebKitTestRunner/TestController.cpp:
4211         (WTR::TestController::TestController):
4212         (WTR::TestController::resetStateToConsistentValues):
4213         (WTR::TestController::didFinishNavigation):
4214         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
4215         (WTR::TestController::didReceiveAuthenticationChallenge):
4216         (WTR::TestController::didCommitNavigation):
4217         * WebKitTestRunner/TestController.h:
4218         (WTR::TestController::setBlockAllPlugins):
4219         (WTR::TestController::setShouldLogHistoryClientCallbacks):
4220         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
4221         (WTR::TestController::isCurrentInvocation):
4222         * WebKitTestRunner/TestInvocation.cpp:
4223         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4224         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
4225
4226 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
4227
4228         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
4229         https://bugs.webkit.org/show_bug.cgi?id=159129
4230
4231         Reviewed by Alex Christensen.
4232
4233         Implement the function mouseScrollBy in the Windows event sender.
4234
4235         * DumpRenderTree/win/EventSender.cpp:
4236         (mouseScrollBy):
4237         (mouseScrollByWithWheelAndMomentumPhasesCallback):
4238
4239 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
4240
4241         REGRESSION: Weak symbol warning when linking TestWebKitAPI
4242         https://bugs.webkit.org/show_bug.cgi?id=159104
4243
4244         Reviewed by Dan Bernstein.
4245         
4246         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
4247         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
4248
4249         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
4250         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
4251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
4252
4253 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
4254
4255         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
4256         https://bugs.webkit.org/show_bug.cgi?id=159086
4257
4258         Reviewed by Alex Christensen.
4259
4260         Implement required wheel event function in event sender.
4261  
4262         * DumpRenderTree/win/EventSender.cpp:
4263         (mouseScrollByWithWheelAndMomentumPhasesCallback):
4264
4265 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
4266
4267         REGRESSION: Weak symbol warning when linking TestWebKitAPI
4268         https://bugs.webkit.org/show_bug.cgi?id=159104
4269
4270         Reviewed by Mark Lam.
4271         
4272         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
4273         WK.
4274