GMainLoopSource is exposed to race conditions
[WebKit-https.git] / Tools / ChangeLog
1 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
2
3         GMainLoopSource is exposed to race conditions
4         https://bugs.webkit.org/show_bug.cgi?id=135800
5
6         Reviewed by Carlos Garcia Campos.
7
8         Add unit tests for GMainLoopSource.
9
10         The tests check correct behavior of GMainLoopSource in various conditions --
11         from the most simple rescheduling to rescheduling during dispatch, cancelling
12         or destroying the GMainLoopSource during dispatch, proper destroy callback
13         dispatching etc.
14
15         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
16         State of the GMainLoopSource object (either ready, sheduled or active) is
17         thoroughly tested throughout the lifetime of that object.
18
19         Still missing are tests for socket callbacks, which are a bit trickier because
20         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
21         are also not tested thoroughly, simply because it is at the moment impossible
22         to test that the objects are actually destroyed when the corresponding source
23         is finally deleted.
24
25         * TestWebKitAPI/PlatformGTK.cmake:
26         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
27         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
28         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
29         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
30         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
31         (TestWebKitAPI::GMainLoopSourceTest::finish):
32         (TestWebKitAPI::GMainLoopSourceTest::source):
33         (TestWebKitAPI::TEST):
34
35 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
36
37         Unreviewed, Update my email in contributors.json
38
39         * Scripts/webkitpy/common/config/contributors.json:
40
41 2014-09-17  Daniel Bates  <dabates@apple.com>
42
43         Unreviewed, rolling out r173695.
44
45         Broke building third-party Legacy WebKit apps; will
46         investigate offline
47
48         Reverted changeset:
49
50         "[iOS] Make WebCore build with public iOS SDK"
51         https://bugs.webkit.org/show_bug.cgi?id=136487
52         http://trac.webkit.org/changeset/173695
53
54 2014-09-17  Daniel Bates  <dabates@apple.com>
55
56         [iOS] Make WebCore build with public iOS SDK
57         https://bugs.webkit.org/show_bug.cgi?id=136487
58
59         Reviewed by David Kilzer.
60
61         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
62
63         * DumpRenderTree/mac/CheckedMalloc.cpp:
64
65 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
66
67         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
68         https://bugs.webkit.org/show_bug.cgi?id=136889
69
70         Reviewed by Gustavo Noronha Silva.
71
72         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
73         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
74         event was added to the events vector.
75         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
76         (loadFailedCallback): Do not assume the web view URI is the
77         failing URI when the load fails before the committed state.
78         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
79         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
80         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
81         (LoadTrackingTest::loadFailedWithTLSErrors): Add
82         LoadFailedWithTLSErrors event to the events vector.
83         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
84
85 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
86
87         [EFL][GTK] Remove WebKit1 related codes
88         https://bugs.webkit.org/show_bug.cgi?id=136853
89
90         Reviewed by Csaba Osztrogonác.
91
92         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
93         from scripts.
94
95         * BuildSlaveSupport/build.webkit.org-config/config.json:
96         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
97         (Compile32bitJSC):
98         (BuildAndTestWebKit2Factory):
99         (CompileWebKit1Only): Deleted.
100         (CompileWebKit2Only): Deleted.
101         (BuildAndTestWebKit1OnlyFactory): Deleted.
102         (BuildAndTestWebKit2OnlyFactory): Deleted.
103         * Scripts/build-webkit:
104         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
105         * Scripts/webkitpy/common/config/ports.py:
106         (GtkWK2Port.build_webkit_command):
107         (EflWK2Port.build_webkit_command):
108         * Scripts/webkitpy/common/config/ports_unittest.py:
109         (DeprecatedPortTest.test_gtk_wk2_port):
110         * Scripts/webkitpy/port/efl.py:
111         (EflPort.build_webkit_command):
112         * Scripts/webkitpy/port/gtk.py:
113         (GtkPort._built_libraries_path):
114         (GtkPort._search_paths):
115         (GtkPort.test_expectations_file_position):
116         (GtkPort.build_webkit_command):
117         (GtkPort.run_webkit_tests_command):
118         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
119
120 2014-09-16  Daniel Bates  <dabates@apple.com>
121
122         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
123         https://bugs.webkit.org/show_bug.cgi?id=136862
124
125         Reviewed by David Kilzer.
126
127         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
128         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
129         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
130         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
131
132 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
133
134         Mac queue slaves should reboot every so often
135         https://bugs.webkit.org/show_bug.cgi?id=136791
136
137         Reviewed by Alexey Proskuryakov.
138
139         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
140
141         * EWSTools/start-queue-mac.sh:
142
143 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
144
145         Unreviewed gardening, skip one more tests on Windows.
146
147         * Scripts/run-javascriptcore-tests:
148
149 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
150
151         JSC test gardening
152         https://bugs.webkit.org/show_bug.cgi?id=136823
153
154         Reviewed by Geoffrey Garen.
155
156         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
157
158 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
159
160         Remove shouldAbortEarly cruft from master.cfg
161         https://bugs.webkit.org/show_bug.cgi?id=136779
162
163         Reviewed by Csaba Osztrogonác.
164
165         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
166         (ConfigureBuild.start):
167         (RunWebKitTests.start):
168         (RunWebKit2Tests.start): Deleted.
169
170 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
171
172         Remove ORWT related crufts from webkitdirs.pm
173         https://bugs.webkit.org/show_bug.cgi?id=136821
174
175         Reviewed by Alexey Proskuryakov.
176
177         * Scripts/webkitdirs.pm:
178         (isPerianInstalled): Deleted.
179         (determineIPhoneSimulatorVersion): Deleted.
180         (iPhoneSimulatorVersion): Deleted.
181         (isSnowLeopard): Deleted.
182         (isLion): Deleted.
183         (quitIOSSimulator): Deleted.
184
185 2014-09-15  Roger Fong  <roger_fong@apple.com>
186
187         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
188         https://bugs.webkit.org/show_bug.cgi?id=25160
189
190         * Scripts/run-javascriptcore-tests:
191
192 2014-09-15  Lucas Forschler  <lforschler@apple.com>
193
194         Add another Apple build slave to the Mountain Lion Debug WK1 queue
195         
196         Rubber stamped by Matt Hanson.
197         
198         * BuildSlaveSupport/build.webkit.org-config/config.json:
199
200 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
201
202         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
203         https://bugs.webkit.org/show_bug.cgi?id=136822
204
205         Reviewed by Gyuyoung Kim.
206
207         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
208         initialized as we already does it in PlatformWebView::PlatformWebView
209         calling ewk_init(). The reason for that was to ensure testing for example,
210         WTF where creating the view is not mandatory.
211
212         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
213         in order to properly initalize and release EWebKit.
214
215         * TestWebKitAPI/PlatformEfl.cmake:
216         * TestWebKitAPI/efl/PlatformWebView.cpp:
217         (TestWebKitAPI::PlatformWebView::PlatformWebView):
218         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
219         * TestWebKitAPI/efl/main.cpp:
220         (main):
221
222 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
223
224         [WinCairo] Make it easier to enable/disable GStreamer.
225         https://bugs.webkit.org/show_bug.cgi?id=135766
226
227         Reviewed by Brent Fulgham.
228
229         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
230
231         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
232
233 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
234
235         Web Inspector: remind about rebaselining generator test results
236         https://bugs.webkit.org/show_bug.cgi?id=136759
237
238         Reviewed by Joseph Pecoraro.
239
240         For now, we can implement this as a watchlist message. Add watchlist
241         groups and messages for the inspector and web replay generators.
242
243         * Scripts/webkitpy/common/config/watchlist:
244
245 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
246
247         build.webkit.org/dashboard: Overlapping text when status is long
248         https://bugs.webkit.org/show_bug.cgi?id=136794
249
250         Reviewed by Timothy Hatcher.
251
252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
253         (.status-line): Replaces height with min-height.
254
255 2014-09-12  Timothy Hatcher  <timothy@apple.com>
256
257         Make Brian Burg a WebKit reviewer.
258
259         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
260
261 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
262
263         Multiple EWS or commit bots can pick up processing of the same patch
264         https://bugs.webkit.org/show_bug.cgi?id=136793
265
266         Reviewed by Ryosuke Niwa.
267
268         Change timeout from one hour to two hours. This will let bots finish, and in the
269         unlikely event of a bot being frozen, will only delay patch processing restart by
270         one hour.
271
272         * QueueStatusServer/app.yaml:
273         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
274
275 2014-09-11  Andy Estes  <aestes@apple.com>
276
277         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
278         https://bugs.webkit.org/show_bug.cgi?id=136768
279
280         Reviewed by Tim Horton.
281
282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
283         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
284         (TestWebKitAPI::TEST):
285
286 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
287
288         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
289         https://bugs.webkit.org/show_bug.cgi?id=136669
290
291         Reviewed by Antti Koivisto.
292
293         * Scripts/run-gtk-tests:
294         (TestRunner): Unskip SSL test.
295
296 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
297
298         Strip extraneous AVFoundation and CoreMedia logging
299         https://bugs.webkit.org/show_bug.cgi?id=136747
300
301         Reviewed by Jer Noble.
302
303         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
304         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
305
306         * Scripts/webkitpy/port/base.py:
307         (Port.stderr_patterns_to_strip): Base class, empty list
308
309         * Scripts/webkitpy/port/driver.py:
310         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
311
312         * Scripts/webkitpy/port/ios.py:
313         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
314
315         * Scripts/webkitpy/port/mac.py:
316         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
317
318
319 2014-09-11  Michael Saboff  <msaboff@apple.com>
320
321         lldb_webkit.py:btjs doesn't work with release builds
322         https://bugs.webkit.org/show_bug.cgi?id=136760
323
324         Reviewed by Jer Noble.
325
326         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
327         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
328         we can't get a valid result from trying either call.  In that case, we fallback to
329         just showing the PC.  Also added check for both entry points.  If neither is found,
330         we issue a warning and output the stack trace without JavaScript annotations.
331
332         * lldb/lldb_webkit.py:
333         (btjs):
334
335 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
336
337         webkitpy test failures from import-w3c-tests
338         https://bugs.webkit.org/show_bug.cgi?id=136752
339
340         Reviewed by Bem Jones-Bey.
341
342         This patch fixes a bug in import-w3c-tests where we were appending
343         the wrong set of files to the copy_list. This also updates the tests
344         to clear the failures introduced in the patch for bug 135929.
345
346         * Scripts/webkitpy/w3c/test_converter_unittest.py:
347         (W3CTestConverterTest.test_read_prefixed_property_list):
348         * Scripts/webkitpy/w3c/test_parser.py:
349         (TestParser.analyze_test):
350         (TestParser.support_files):
351         * Scripts/webkitpy/w3c/test_parser_unittest.py:
352
353 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
354
355         Blink merge: Speculative fix for windows run-webkit-tests hangs
356         https://bugs.webkit.org/show_bug.cgi?id=136727
357
358         Reviewed by Csaba Osztrogonác.
359
360         Merged from Blink (patch by Dirk Pranke):
361         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
362
363         * Scripts/webkitpy/common/system/executive.py:
364         (Executive.kill_process):
365
366 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
367
368         Added myself as a committer.
369
370         Unreviewed.
371
372         * Scripts/webkitpy/common/config/contributors.json:
373
374 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
375
376         [JavaScriptCore] Fix FTL on platform EFL.
377         https://bugs.webkit.org/show_bug.cgi?id=133571
378
379         Reviewed by Filip Pizlo.
380
381         * efl/install-dependencies: Revert r169181.
382         * efl/jhbuild.modules: Clone and build a custom branch.
383         This branch contains some fix for FTL of platform EFL.
384         The branch is a fork of llvm r206311.
385
386 2014-09-10  Tanay C  <tanay.c@samsung.com>
387
388         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
389         https://bugs.webkit.org/show_bug.cgi?id=136698
390
391         Reviewed by Gyuyoung Kim.
392
393         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
394         (on_mouse_wheel): Added.
395         (window_free):
396         (window_create):
397
398 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
399
400         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
401         https://bugs.webkit.org/show_bug.cgi?id=136284
402
403         Reviewed by Gyuyoung Kim.
404
405         * MiniBrowser/efl/main.c:
406         (window_create):
407
408 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
409
410         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
411         https://bugs.webkit.org/show_bug.cgi?id=135929
412
413         Reviewed by Bem Jones-Bey.
414
415         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
416         were made when this script was originally written with respect to relative paths
417         in ref files. This patch updates import-w3c-tests to update paths in ref files if
418         they move relative to the test file.
419
420
421         * Scripts/webkitpy/w3c/test_converter.py:
422         (convert_for_webkit):
423         (_W3CTestConverter.__init__):
424         (_W3CTestConverter.convert_reference_relpaths):
425         (_W3CTestConverter.convert_style_data):
426         (_W3CTestConverter.convert_attributes_if_needed):
427         * Scripts/webkitpy/w3c/test_importer.py:
428         (TestImporter.find_importable_tests):
429         (TestImporter.import_tests):
430         * Scripts/webkitpy/w3c/test_parser.py:
431         (TestParser.load_file):
432         (TestParser.analyze_test):
433         (TestParser.support_files):
434
435 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
436
437         [GTK] allow overwriting destination of download
438         https://bugs.webkit.org/show_bug.cgi?id=136372
439
440         Reviewed by Carlos Garcia Campos.
441
442         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
443         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
444         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
445         (createFileAtDestination): Added
446         (testDownloadOverwriteDestinationAllowed): Added
447         (testDownloadOverwriteDestinationDisallowed): Added
448         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
449         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
450         (beforeAll): New tests
451
452 2014-08-05  David Farler  <dfarler@apple.com>
453
454         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
455         https://bugs.webkit.org/show_bug.cgi?id=135551
456
457         Reviewed by Daniel Bates.
458
459         Prevent printing invalid Unicode strings going to stderr.
460         Also, make filesystem.py more tolerant about receiving
461         Unicode (encoded as UTF-8) when writing to files, in the
462         rare case that an NSError description will make it to
463         stderr, such as -[LTRelayController createUniqueApp].
464
465         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
466         (-[LTRelayController launchSimulator]): Removed.
467         (-[LTRelayController createUniqueApp]):
468         Don't explicitly try to uninstall the app. It is automatically handled
469         when installing an app with the same bundle identifier.
470         (-[LTRelayController start]):
471         (-[LTRelayController bootDevice]): Removed.
472         The device already boots as a part of starting the simulator. Attempting
473         to boot a second time may cause spurious stderr output.
474         * Scripts/webkitpy/port/driver.py:
475         (IOSSimulatorDriver._setup_environ_for_driver):
476         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
477         Open the iOS Simulator once instead of the LayoutTestRelay trying
478         to do it.
479         * Scripts/webkitpy/port/ios.py:
480         (IOSSimulatorPort._get_crash_log):
481         Make sure stderr is at least an empty string.
482         (IOSSimulatorPort):
483         (IOSSimulatorPort.developer_dir):
484         New property for setting up DEVELOPER_DIR in the driver environment.
485
486 2014-09-09  Dan Bernstein  <mitz@apple.com>
487
488         Clean up the MiniBrowser Xcode project
489         https://bugs.webkit.org/show_bug.cgi?id=136684
490
491         Reviewed by Tim Horton.
492
493         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
494         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
495         WebKit2.framework. Upgraded project file version.
496
497 2014-09-09  Daniel Bates  <dbates@webkit.org>
498
499         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
500         https://bugs.webkit.org/show_bug.cgi?id=136379
501
502         Reviewed by David Kilzer.
503
504         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
505         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
506         and sets a property on F (say, the executable bit).
507
508         * Scripts/svn-apply:
509         (patch): Only add file if the diff has text chunks.
510         * Scripts/svn-unapply:
511         (patch): Only delete added file if the diff has text chunks.
512
513 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
514
515         [GTK] Unreviewed GTK gardening.
516
517         * Scripts/run-gtk-tests:
518         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
519
520 2014-09-09  Christophe Dumez  <cdumez@apple.com>
521
522         Update my email in contributors.json
523         https://bugs.webkit.org/show_bug.cgi?id=136671
524
525         Reviewed by Andreas Kling.
526
527         * Scripts/webkitpy/common/config/contributors.json:
528
529 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
530
531         [EFL] Enable fixed layout by default
532         https://bugs.webkit.org/show_bug.cgi?id=136607
533
534         Reviewed by Csaba Osztrogonác.
535
536         Fixed layout is being used by Tizen platform by default. However, the feature
537         has still many defects now. So, we need to enable it by default, then should fix
538         those bugs. 
539
540         * MiniBrowser/efl/main.c:
541
542 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
543
544         Remove FILTERS flag
545         https://bugs.webkit.org/show_bug.cgi?id=136571
546
547         Reviewed by Darin Adler.
548
549         * Scripts/webkitperl/FeatureList.pm:
550
551 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
552
553         Dashboard metrics should ignore commits that didn't trigger builds
554         https://bugs.webkit.org/show_bug.cgi?id=136618
555
556         Reviewed by Darin Adler.
557
558         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
559         other platforms etc. It does not make sense to count wait time for these, as it
560         can be arbitrarily long.
561
562         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
563
564         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
565         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
566
567         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
568         We used to walk the timeline to see which revisions are fully tested, but that's not
569         correct. A revision that's only tested by a subset of queues finishes independently
570         of another that's tested by another subset. Now, we just search for the answer for
571         each revision individually.
572
573         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
574         (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
575         the analyzer now reports. Removed best time, which is more confusing than meaningful.
576
577 2014-09-08  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
578
579         Remove EWebLauncher from webkitdirs.pm
580         https://bugs.webkit.org/show_bug.cgi?id=136622
581
582         Reviewed by Gyuyoung Kim.
583
584         * Scripts/webkitdirs.pm:
585         (launcherName):
586
587 2014-09-06  Sam Weinig  <sam@webkit.org>
588
589         XPCPtr should be converted into an all purpose smart pointer for os_objects
590         https://bugs.webkit.org/show_bug.cgi?id=136602
591
592         Reviewed by Darin Adler.
593
594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
595         * TestWebKitAPI/Tests/WTF/darwin: Added.
596         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
597         Add basic unit tests for OSObjectPtr.
598
599 2014-09-06  Saam Barati  <saambarati1@gmail.com>
600
601         Unreviewed. Add myself as a committer.
602
603         * Scripts/webkitpy/common/config/contributors.json:
604
605 2014-09-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
606
607         Unreviewed, EFL build fix when SHARED_CORE is on.
608
609         * TestWebKitAPI/PlatformEfl.cmake:
610
611 2014-09-05  Lucas Forschler  <lforschler@apple.com>
612
613         <https://webkit.org/b/136586> Add bots to Apple build/test queues
614         
615         Reviewed by Daniel Bates.
616
617         * BuildSlaveSupport/build.webkit.org-config/config.json:
618
619 2014-09-05  Alexey Proskuryakov  <ap@apple.com>
620
621         Buildbot metrics page gives wrong results after a new bot gets added
622         https://bugs.webkit.org/show_bug.cgi?id=136516
623
624         Reviewed by Tim Horton.
625
626         Part 2: Fix elapsed times.
627
628         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
629         (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
630         until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
631
632 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
633
634         [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
635         https://bugs.webkit.org/show_bug.cgi?id=136562
636
637         Reviewed by Martin Robinson.
638
639         * Scripts/run-gtk-tests:
640         (TestRunner): Remove failure expectations for tests that now pass.
641
642 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
643
644         Dashboard metrics page wastes a lot of time sorting iterations
645         https://bugs.webkit.org/show_bug.cgi?id=136559
646
647         Reviewed by Tim Horton.
648
649         Also fixes comments here and there, and adds a missing "var".
650
651         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
652         (BuildbotIteration.prototype._parseData):
653         (BuildbotIteration.prototype._updateWithData):
654         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
655         (BuildbotQueue.prototype.loadAll):
656         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
657         (Analyzer.prototype._countTimes):
658
659 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
660
661         [GTK] Unreviewed GTK gardening.
662
663         * Scripts/run-gtk-tests:
664         (TestRunner): Skip tests failing since r173272.
665
666 2014-09-04  Simon Fraser  <simon.fraser@apple.com>
667
668         Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
669         https://bugs.webkit.org/show_bug.cgi?id=136561
670
671         Reviewed by Tim Horton.
672         
673         Log for calloc() and CGBitmapContextCreate() failures.
674
675         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
676         (createBitmapContext):
677         (createBitmapContextFromWebView):
678
679 2014-09-04  Andy Estes  <aestes@apple.com>
680
681         Fix the Mac Production build after r173283.
682
683         * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
684
685 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
686
687         [Win] webkitpy test suite frequently fails to complete
688         https://bugs.webkit.org/show_bug.cgi?id=136546
689
690         Reviewed by Daniel Bates.
691
692         Properly convert the ASCII crash log produced by ntsd into
693         a unicode string as early as possible so that we handle it
694         properly when generating our logs and other test support output.
695
696         We were mixing ASCII/unicode strings under Windows, which was
697         causing test system failures when we processed some crash logs.
698
699         Also do a better job of handling garbage pid entries in the
700         Cygwin lock files.
701
702         * Scripts/webkitpy/common/system/crashlogs.py:
703         (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
704         creates an ASCII file. Decode it as ASCII, not 'utf-8', and
705         handle the strings as unicode from that point on.
706         * Scripts/webkitpy/port/http_lock.py:
707         (HttpLock._current_lock_pid): Add logging and handle case of
708         the current_pid failing to cleanly convert to 'int'.
709         * Scripts/webkitpy/port/win.py:
710         (WinPort): Add 64-bit architecture as a known target for the
711         Windows build.
712
713 2014-09-04  Andy Estes  <aestes@apple.com>
714
715         Address additional review feedback after landing r173283.
716
717         Reviewed by Daniel Bates.
718
719         * DumpRenderTree/config.h: Removed redundant includes.
720         * TestWebKitAPI/config.h: Ditto.
721         * WebKitTestRunner/config.h: Ditto.
722
723 2014-09-03  Andy Estes  <aestes@apple.com>
724
725         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
726         https://bugs.webkit.org/show_bug.cgi?id=136521
727
728         Reviewed by Anders Carlsson.
729
730         * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
731         * TestWebKitAPI/config.h: Ditto.
732         * WebKitTestRunner/config.h: Ditto.
733
734 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
735
736         REGRESSION: Dashboard metrics page aggregation counts performance bots
737         https://bugs.webkit.org/show_bug.cgi?id=136539
738
739         Reviewed by Tim Horton.
740
741         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
742
743 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
744
745         [Win] Perl test fix.
746
747         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
748         VersionStamp.exe tool, not just the driver script.
749
750 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
751
752         Remove CSS_FILTERS flag
753         https://bugs.webkit.org/show_bug.cgi?id=136529
754
755         Reviewed by Dirk Schulze.
756
757         * Scripts/webkitperl/FeatureList.pm:
758
759 2014-09-04  Commit Queue  <commit-queue@webkit.org>
760
761         Unreviewed, rolling out r173201.
762         https://bugs.webkit.org/show_bug.cgi?id=136538
763
764         Improves the situation but also introduces additional crashes.
765         (Requested by zdobersek on #webkit).
766
767         Reverted changeset:
768
769         "GMainLoopSource is exposed to race conditions"
770         https://bugs.webkit.org/show_bug.cgi?id=135800
771         http://trac.webkit.org/changeset/173201
772
773 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
774
775         Buildbot metrics page gives wrong results after a new bot gets added
776         https://bugs.webkit.org/show_bug.cgi?id=136516
777
778         Part 1: Fix red/green counters. Dashboard is considered green at a given time
779         if all the bots that ever had results before this time are green.
780
781         This doesn't (and cannot) address situations where the bot gets removed and then
782         re-added. It also gives wrong results after a bot gets removed, because it doesn't
783         know that it was ever displayed on the dashboard.
784
785         Reviewed by Darin Adler.
786
787         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
788         (Analyzer.prototype._dashboardIsAllGreen):
789         (Analyzer.prototype._updateStretchOfRedCounters):
790         (Analyzer.prototype._countPercentageOfGreen):
791         (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
792
793 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
794
795         [Win] Unreviewed test fix.
796
797         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Don't fail
798         test if user doesn't have the VersionStamp.exe program.
799
800 2014-09-03  Dana Burkart  <dburkart@apple.com>
801
802         Unreviewed. Add myself as a committer.
803
804         * Scripts/webkitpy/common/config/contributors.json:
805
806 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
807
808         build.webkit.org/dashboard performance popover is unstyled
809         https://bugs.webkit.org/show_bug.cgi?id=136499
810
811         Reviewed by Tim Horton.
812
813         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
814         (.performance-popover):
815         (.performance-popover .dashboard-link):
816
817 2014-09-03  Saam Barati  <saambarati1@gmail.com>
818
819         Create tests for type profiling
820         https://bugs.webkit.org/show_bug.cgi?id=136161
821
822         Reviewed by Geoffrey Garen.
823
824         Have run-javascriptcore-tests run the newly created
825         tests for the type profiler.
826
827         * Scripts/run-javascriptcore-tests:
828         * Scripts/run-jsc-stress-tests:
829
830 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
831
832         [Win] Revise test environment for Windows build.
833         https://bugs.webkit.org/show_bug.cgi?id=136486
834
835         Reviewed by David Kilzer.
836
837         The various calls to get the Safari path really only have
838         meaning on the Mac. Other ports get access to the build
839         and test environment separately, so remove the various
840         checks in the Safari-specific code to simplify things.
841
842         Remove some 64-bit hacks used on Windows now that the
843         various tools know how to find the 64-bit runtime environment.
844
845         * Scripts/run-javascriptcore-tests: 
846         * Scripts/webkitdirs.pm:
847         (safariPathFromSafariBundle): Revise to expect Mac.
848         (installedSafariPath): Ditto.
849         (safariPath): Ditto.
850         (appleApplicationSupportPath): Get rid of 64-bit Windows hack.
851         (setPathForRunningWebKitApp): Get rid of unused SafariPath
852         argument for Windows runs.
853
854 2014-09-03  Dana Burkart  <dburkart@apple.com>
855
856         Dashboard should show performance bots.
857         https://bugs.webkit.org/show_bug.cgi?id=136386
858
859         Reviewed by Alexey Proskuryakov.
860
861         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
862         (BuildbotIteration.prototype._parseData.collectPerfTestResults):
863         (BuildbotIteration.prototype._parseData):
864         Support possible performance failures.
865
866         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
867         New QueueView to manage the way we present performance data.
868
869         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
870         (BuildbotQueue):
871         Support new 'performance' and 'performanceTestName' keys.
872
873
874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
875         Add performance column to the main page.
876
877         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
878         (WebKitBuildbot):
879         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
880         (body):
881         Make sure everything fits on 13 inch screens.
882
883         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
884
885 2014-09-03  Zan Dobersek  <zdobersek@igalia.com>
886
887         GMainLoopSource is exposed to race conditions
888         https://bugs.webkit.org/show_bug.cgi?id=135800
889
890         Reviewed by Carlos Garcia Campos.
891
892         Add a unit test for GMainLoopSource that tests different
893         types of rescheduling tasks on already-active sources.
894
895         * TestWebKitAPI/PlatformGTK.cmake:
896         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
897         (GMainLoopSourceTest::GMainLoopSourceTest):
898         (GMainLoopSourceTest::~GMainLoopSourceTest):
899         (GMainLoopSourceTest::runLoop):
900         (GMainLoopSourceTest::finish):
901         (GMainLoopSourceTest::source):
902         (testGMainLoopSourceBasicRescheduling):
903         (testGMainLoopSourceReentrantRescheduling):
904         (testGMainLoopSourceDifferentThreadRescheduling):
905         (beforeAll):
906         (afterAll):
907         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
908         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
909         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
910         (TestWebKitAPI::GMainLoopSourceTest::finish):
911         (TestWebKitAPI::GMainLoopSourceTest::source):
912         (TestWebKitAPI::TEST):
913
914 2014-09-02  Simon Fraser  <simon.fraser@apple.com>
915
916         Make sure WK1 prefs are initialized in MiniBrowser
917         https://bugs.webkit.org/show_bug.cgi?id=136465
918
919         Reviewed by Tim Horton.
920         
921         Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
922         for WK2 windows, to make sure that WebPreferences are updated (to get
923         layer borders to work consistently).
924
925         * MiniBrowser/mac/WK1BrowserWindowController.m:
926         (-[WK1BrowserWindowController awakeFromNib]):
927
928 2014-09-02  Renato Nagy  <rnagy@inf.u-szeged.hu>
929
930         check-webkit-style should complain about C++ comments in Platform.h
931         https://bugs.webkit.org/show_bug.cgi?id=133802
932
933         Reviewed by Csaba Osztrogonác.
934
935         * Scripts/webkitpy/style/checkers/cpp.py:
936         (check_platformh_comments):
937         (_process_lines):
938         (CppChecker):
939         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
940         (CppStyleTest.test_platformh_comment):
941
942 2014-09-02  Brendan Long  <self@brendanlong.com>
943
944         [Gtk] Make install-dependencies work on Arch Linux
945         https://bugs.webkit.org/show_bug.cgi?id=136374
946
947         Reviewed by Philippe Normand.
948
949         * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
950
951 2014-09-01  Brian J. Burg  <burg@cs.washington.edu>
952
953         Provide column numbers to DTrace willExecute/didExecute probes
954         https://bugs.webkit.org/show_bug.cgi?id=136434
955
956         Reviewed by Antti Koivisto.
957
958         Create a directory for DTrace scripts. Add an example script that
959         shows how to use static probes provided by JavaScriptCore's profiler.
960
961         * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
962
963 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
964
965         [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
966         https://bugs.webkit.org/show_bug.cgi?id=136431
967
968         Reviewed by Martin Robinson.
969
970         * gtk/jhbuild.modules: Disable cairo SVG testsuite.
971         Add missing dependencies for librsvg (glib and cairo).
972
973 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
974
975         [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
976         https://bugs.webkit.org/show_bug.cgi?id=136425
977
978         Reviewed by Martin Robinson.
979
980         * gtk/install-dependencies: Add dbus-x11 to the list of packages needed for running the tests.
981
982 2014-09-01  Ryuan Choi  <ryuan.choi@samsung.com>
983
984         Update my list of email addresses in contributors.json
985         https://bugs.webkit.org/show_bug.cgi?id=136424
986
987         Reviewed by Gyuyoung Kim.
988
989         * Scripts/webkitpy/common/config/contributors.json:
990
991 2014-08-30  Filip Pizlo  <fpizlo@apple.com>
992
993         [RJST] eager-no-cjit should really mean eager
994         https://bugs.webkit.org/show_bug.cgi?id=136407
995
996         Reviewed by Mark Hahnenberg.
997         
998         At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
999         and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
1000         after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
1001         all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
1002         threshold setting that NO_CJIT_OPTIONS was currently setting
1003         (thresholdForJITAfterWarmUp). The solution is to make sure that we always append
1004         NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
1005         
1006         Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
1007
1008         * Scripts/run-jsc-stress-tests:
1009
1010 2014-08-29  Daniel Bates  <dabates@apple.com>
1011
1012         [iOS] Configure Xcode to build a command line tool for the iOS Simulator
1013         https://bugs.webkit.org/show_bug.cgi?id=136388
1014
1015         Reviewed by David Kilzer.
1016
1017         Add a script, called configure-xcode-for-ios-development, to configure Xcode to
1018         support building a command line tool for the iOS Simulator. You must run this
1019         script as root.
1020
1021         The script uses the xcspec files in the OS X SDK to create xcspec files in the
1022         iOS Simulator SDK with the product- and package- type definitions to build a
1023         command line tool, if applicable.
1024
1025         * Scripts/configure-xcode-for-ios-development: Added.
1026
1027 2014-08-29  Tim Horton  <timothy_horton@apple.com>
1028
1029         Remove Windows WebKit2 code from TestWebKitAPI
1030         https://bugs.webkit.org/show_bug.cgi?id=136385
1031
1032         Reviewed by Alexey Proskuryakov.
1033
1034         * TestWebKitAPI/PlatformUtilities.h:
1035         * TestWebKitAPI/PlatformWebView.h:
1036         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
1037         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1038         (TestWebKitAPI::TEST): Deleted.
1039         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1040         (TestWebKitAPI::TEST):
1041         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1042         (TestWebKitAPI::TEST):
1043         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
1044         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
1045         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
1046         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
1047         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
1048         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
1049         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
1050
1051 2014-08-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1052
1053         [JSC] Some JSC tests are dependent on the machine time zone.
1054         https://bugs.webkit.org/show_bug.cgi?id=136363
1055
1056         Reviewed by Filip Pizlo.
1057
1058         * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
1059         Unskip the tests that were skipped on r99580.
1060
1061 2014-08-29  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1062
1063         [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
1064         https://bugs.webkit.org/show_bug.cgi?id=135560
1065
1066         Reviewed by Gyuyoung Kim.
1067
1068         * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
1069
1070 2014-08-28  Daniel Bates  <dabates@apple.com>
1071
1072         [Win] update-webkit should update auxiliary libs by default
1073
1074         Reviewed by Dan Bernstein.
1075
1076         The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
1077         from updating the Windows auxiliary libs by default. We should make update-webkit update the
1078         Windows auxiliary libs by default. This will make its behavior match its usage text.
1079
1080         * Scripts/update-webkit:
1081
1082 2014-08-28  Brian J. Burg  <burg@cs.washington.edu>
1083
1084         build-webkit --inspector-frontend tries to copy files from old inspector path
1085         https://bugs.webkit.org/show_bug.cgi?id=136346
1086
1087         Reviewed by Timothy Hatcher.
1088
1089         Remove the old code path for copying inspector resources. It doesn't work.
1090         Complain if this option is passed to CMake-based builds.
1091
1092         * Scripts/build-webkit:
1093         * Scripts/webkitdirs.pm:
1094         (copyInspectorFrontendFiles): Deleted.
1095
1096 2014-08-28  Alexey Proskuryakov  <ap@apple.com>
1097
1098         Dashboard metrics page could show longest stretch of red
1099         https://bugs.webkit.org/show_bug.cgi?id=136334
1100
1101         Reviewed by Sam Weinig.
1102
1103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1104         (Analyzer.prototype._updateStretchOfRedCounters):
1105         (Analyzer.prototype._countPercentageOfGreen):
1106         When counting percentage of green, also keep track of how long the page was red.
1107
1108         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
1109         (MetricsView.prototype._update.addDivider):
1110         (MetricsView.prototype._update.appendQueueResults):
1111         Show it in aggregate queues (can't think of a reason to have it in individual ones).
1112
1113         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
1114         Changed to use an explicit divider element between green time and performance groups,
1115         as there are too many combinations to easily express in CSS.
1116
1117 2014-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1118
1119         [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
1120         https://bugs.webkit.org/show_bug.cgi?id=136248
1121
1122         Reviewed by Gustavo Noronha Silva.
1123
1124         Add new test case for webkit_uri_response_get_http_headers().
1125
1126         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1127         (testURIResponseHTTPHeaders):
1128         (serverCallback):
1129         (beforeAll):
1130
1131 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
1132
1133         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
1134         https://bugs.webkit.org/show_bug.cgi?id=131668
1135
1136         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1137         (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
1138
1139 2014-08-27  Zalan Bujtas  <zalan@apple.com>
1140
1141         Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
1142         https://bugs.webkit.org/show_bug.cgi?id=136264
1143
1144         Reviewed by Simon Fraser.
1145         
1146         1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
1147         functions. ->snappedIntSize()/snapSizeToDevicePixel().
1148         2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
1149
1150         Covered by existing tests.
1151
1152         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1153         (TestWebKitAPI::TEST): Deleted.
1154
1155 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
1156
1157         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
1158         https://bugs.webkit.org/show_bug.cgi?id=131668
1159
1160         Reviewed by Daniel Bates.
1161
1162         We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
1163         to not just hardcode.
1164
1165         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1166         (EWS.prototype.queueStatusURL): Added.
1167
1168         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1169         (EWSQueue.prototype.get statusPageURL): Use the above function.
1170         (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
1171
1172         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
1173         (EWSQueueView.prototype.update): While at it, made a popover show up even if there
1174         are no patches in the queue. The popover has other useful information, such as charts
1175         link and bot status.
1176
1177 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
1178
1179         https://bugs.webkit.org/show_bug.cgi?id=136317
1180         Dashboard metrics page sometimes shows 0 for best time
1181
1182         Reviewed by Tim Horton.
1183
1184         This also affects regular dashboard display in a good way - iterations that failed
1185         due to infrastructure misbehavior will more reliably show up as yellow and not red.
1186
1187         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1188         (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
1189         updated if we rename steps.
1190         (BuildbotIteration.prototype.get productive): Now that computation is more involved,
1191         do it once.
1192         (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
1193         that failed e.g. at downloading built archive step are not productive.
1194
1195 2014-08-27  Brent Fulgham  <bfulgham@apple.com>
1196
1197         [Win] Unreviewed gardening.
1198
1199         * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
1200         of logs assembled into the final build output.
1201
1202 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
1203
1204         build.webkit.org/dashboard: Add a metrics page with overall bot performance results
1205         https://bugs.webkit.org/show_bug.cgi?id=136196
1206
1207         Reviewed by Timothy Hatcher.
1208
1209         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
1210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
1211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
1212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
1213         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
1214         A date range picker control with dependencies.
1215         There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
1216         - Fixed a bug where selected dates were not at midnight the first time a range was chosen
1217         (it didn't happen again upon re-opening the picker).
1218         - Made made style tweaks to match Dashboard UI.
1219
1220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1221         Don't create objects that are not needed by the given app, and thus are not loaded at all.
1222
1223         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
1224         Math to count all the things. Only supports open source tree and trunk at the moment,
1225         but written with internal tree and branches in mind.
1226
1227         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
1228         Like dashboard Main.js, draws the UI and creates all necessary objects.
1229
1230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
1231         A view for table cells.
1232
1233         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1234         (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
1235         Metrics page has individual platforms initially scrolled away form the view, so 
1236         it needs to scroll down to reveal what's being configured.
1237
1238         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1239         Added Array.prototype.average and Array.prototype.median.
1240
1241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1242         Made gear icon fixed instead of absolute, so that it's visible on metrics page when
1243         in settings mode.
1244
1245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
1246         Additional style rules.
1247
1248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
1249         The metrics page.
1250
1251 2014-08-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1252
1253         Remove networkinfo watch category in watchlist
1254         https://bugs.webkit.org/show_bug.cgi?id=136279
1255
1256         Reviewed by Alexey Proskuryakov.
1257
1258         Network info was removed. So, it is not needed anymore.
1259
1260         * Scripts/webkitpy/common/config/watchlist:
1261
1262 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
1263
1264         build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
1265         https://bugs.webkit.org/show_bug.cgi?id=136281
1266
1267         Reviewed by Tim Horton.
1268
1269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1270         Track and expose whether the itertion is being loaded. Made update() a no-op if
1271         the iteration is already being loaded.
1272
1273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1274         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
1275         loading everything at once, ask the queue to load a little more. We can always repeat
1276         if we still don't have enough data.
1277
1278         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1279         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
1280         10 more iterations intelligently.
1281
1282 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
1283
1284         build.webkit.org/dashboard raises an exception when Trac RSS fails to load
1285         https://bugs.webkit.org/show_bug.cgi?id=136283
1286
1287         Reviewed by Tim Horton.
1288
1289         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1290         Don't.
1291
1292 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
1293
1294         build.webkit.org/dashboard raises an exception after a hidden platform is removed
1295         https://bugs.webkit.org/show_bug.cgi?id=136282
1296
1297         Reviewed by Tim Horton.
1298
1299         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1300         (updateHiddenPlatforms): Check that the platform is still valid.
1301
1302 2014-08-26  Matt Lilek  <mrl@apple.com>
1303
1304         Add WebKit SPI to control the navigator.standalone property
1305         https://bugs.webkit.org/show_bug.cgi?id=136189
1306
1307         Reviewed by Andy Estes.
1308
1309         Add API test for WKPreferences
1310
1311         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1312         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
1313         (TEST):
1314
1315 2014-08-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1316
1317         Remove ENABLE_DRT environment variable to enable SHARED_CORE
1318         https://bugs.webkit.org/show_bug.cgi?id=136205
1319
1320         Reviewed by Andrei Bucur.
1321
1322         EFL port doesn't need to enable SHARED_CORE since r172894. Thus, we don't need to
1323         use ENABLE_DRT enviroment variable, which enables SHARED_CORE.
1324
1325         * Scripts/webkitdirs.pm:
1326         (generateBuildSystemFromCMakeProject):
1327
1328 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
1329
1330         [Win] Version stamp should include package-level version
1331         https://bugs.webkit.org/show_bug.cgi?id=136266
1332         <rdar://problem/18134138>
1333
1334         Reviewed by David Kilzer.
1335
1336         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add
1337         tests for the full 3+ digit version.
1338         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1339         Confirm that the final output DLL uses the 3+ digit version.
1340
1341 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
1342
1343         [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE
1344         https://bugs.webkit.org/show_bug.cgi?id=136258
1345         <rdar://problem/18134138>
1346
1347         Reviewed by Tim Horton.
1348
1349         Avoid 32/64-bit truncation by preventing 64-bit HWND (and other)
1350         values from passing through the 32-bit OLE_HANDLE data type.
1351
1352         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1353         (AccessibilityController::rootElement):
1354         * DumpRenderTree/win/DumpRenderTree.cpp:
1355         (resetWebViewToConsistentStateBeforeTesting):
1356         (runTest):
1357         (createWebViewAndOffscreenWindow):
1358         * DumpRenderTree/win/FrameLoadDelegate.h:
1359         (FrameLoadDelegate::didReceiveIcon):
1360         * DumpRenderTree/win/TestRunnerWin.cpp:
1361         (TestRunner::setWindowIsKey):
1362         * DumpRenderTree/win/UIDelegate.cpp:
1363         (UIDelegate::trackCustomPopupMenu):
1364         (UIDelegate::drawHeaderInRect):
1365         (UIDelegate::drawFooterInRect):
1366         (UIDelegate::webViewClose):
1367         (UIDelegate::webViewFocus):
1368         (UIDelegate::webViewSetCursor):
1369         (UIDelegate::drawBackground):
1370         * DumpRenderTree/win/UIDelegate.h:
1371         (UIDelegate::webViewFirstResponder):
1372         (UIDelegate::makeFirstResponder):
1373         (UIDelegate::contextMenuItemsForElement):
1374         (UIDelegate::addCustomMenuDrawingData):
1375         (UIDelegate::cleanUpCustomMenuDrawingData):
1376         (UIDelegate::webViewLostFocus):
1377         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1378         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
1379         * WinLauncher/PrintWebUIDelegate.cpp:
1380         (PrintWebUIDelegate::drawHeaderInRect):
1381         (PrintWebUIDelegate::drawFooterInRect):
1382         * WinLauncher/PrintWebUIDelegate.h:
1383         (PrintWebUIDelegate::webViewFirstResponder):
1384         (PrintWebUIDelegate::makeFirstResponder):
1385         (PrintWebUIDelegate::contextMenuItemsForElement):
1386         (PrintWebUIDelegate::trackCustomPopupMenu):
1387         (PrintWebUIDelegate::addCustomMenuDrawingData):
1388         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
1389         * WinLauncher/WinLauncher.cpp:
1390         (WinLauncher::prepareViews):
1391         * WinLauncher/WinLauncherWebHost.h:
1392         (WinLauncherWebHost::didReceiveIcon):
1393
1394 2014-08-26  Daniel Bates  <dabates@apple.com>
1395
1396         Only define WEBCORE_EXPORT when building DumpRenderTree for Windows and iOS
1397
1398         Rubber-stamped by Tim Horton.
1399
1400         The Windows and iOS ports are the only ports that make use of WebCore headers
1401         in DumpRenderTree.
1402
1403         * DumpRenderTree/config.h:
1404
1405 2014-08-26  Dan Bernstein  <mitz@apple.com>
1406
1407         runSvnUpdateAndResolveChangeLogs() doesn’t work when invoked from a script outside Tools/Scripts
1408         https://bugs.webkit.org/show_bug.cgi?id=136254
1409
1410         Reviewed by Tim Horton.
1411
1412         * Scripts/webkitdirs.pm:
1413         (runSvnUpdateAndResolveChangeLogs): Locate resolve-ChangeLogs relative to the source tree,
1414         not the invoking script.
1415
1416 2014-08-26  Krzysztof Czech  <k.czech@samsung.com>
1417
1418         [EFL] Utilize espeak as a synthesizer back-end for WebSpeech
1419         https://bugs.webkit.org/show_bug.cgi?id=136127
1420
1421         Reviewed by Gyuyoung Kim.
1422
1423         Add espeak dependency.
1424
1425         * efl/install-dependencies:
1426
1427 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
1428
1429         Remove a little more accidentally landed code from r172891.
1430
1431         iteration.branch also wasn't meant to be landed.
1432
1433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1434         (BuildbotIteration.prototype._parseData):
1435
1436 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
1437
1438         REGRESSION (r172891): Internal dashboard is broken.
1439
1440         Removing some accidentally landed code - I needed "changes" for another patch, but
1441         not here, and then I decided to not use it anyway.
1442
1443         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1444         (BuildbotIteration.prototype._parseData):
1445
1446 2014-08-25  Daniel Bates  <dabates@apple.com>
1447
1448         Fix the iOS DumpRenderTree build after <http://trac.webkit.org/changeset/172814/>
1449         (https://bugs.webkit.org/show_bug.cgi?id=136108)
1450
1451         Use a similar approach as in TestWebKitAPI/config.h and define a stub for the macro define WEBCORE_EXPORT
1452         so that we can compile DumpRenderTree for iOS.
1453
1454         * DumpRenderTree/config.h:
1455
1456 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
1457
1458         Make build.webkit.org/dashboard work with changeset_show_files=location
1459         https://bugs.webkit.org/show_bug.cgi?id=136237
1460
1461         Reviewed by Tim Horton.
1462
1463         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1464         (Trac.prototype._convertCommitInfoElementToObject): Remove location information
1465         from description before getting title, and also actually parse the location into
1466         result object when available.
1467
1468         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1469         (String.prototype.startsWith): Added.
1470
1471 2014-08-25  Tanay C  <tanay.c@samsung.com>
1472
1473         [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation
1474         https://bugs.webkit.org/show_bug.cgi?id=135795
1475
1476         Reviewed by Gyuyoung Kim.
1477
1478         * MiniBrowser/efl/main.c: Adding functionality for long press history list navigation
1479         (history_list_hide): Hiding and dereferencing the history list and items
1480         (on_key_down):
1481         (on_mouse_down):
1482         (on_back_button_clicked): Early return for longpress 
1483         (on_forward_button_clicked): Early return for longpress 
1484         (list_item_label_get): Populate item labels
1485         (on_list_item_select): Navigates on selection from history list
1486         (navigation_button_longpress_process): Populates the history list and displays it
1487         (on_forward_button_longpress):
1488         (on_back_button_longpress):
1489         (window_create): Add the widget for history list
1490
1491 2014-08-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1492
1493         [GTK] JHBuild module gst-plugins-base fails to build on x86 with GCC 4.9
1494         https://bugs.webkit.org/show_bug.cgi?id=136152
1495
1496         Reviewed by Philippe Normand.
1497
1498         * gtk/jhbuild.modules: Apply gst-plugins-base-fix-build-gcc-4.9-x86.patch.
1499         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Added.
1500         Cherry pick upstream patches daa194 and 4e3d101.
1501
1502 2014-08-24  Zan Dobersek  <zdobersek@igalia.com>
1503
1504         GenericHashTraits::peek() is producing copies of passed-in temporary values
1505         https://bugs.webkit.org/show_bug.cgi?id=131461
1506
1507         Reviewed by Darin Adler.
1508
1509         Add a test case that checks the number of copies and moves of the mapped objects
1510         when calling HashMap::get(). Exactly one copy of the mapped value should be
1511         performed when there exists a value that is mapped to the specified key, and
1512         exactly one move and no copies of the empty value should be performed when there
1513         isn't any mapped value for the specified key.
1514
1515         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Added.
1516         (CopyMoveCounter::TestingScope::TestingScope):
1517         (CopyMoveCounter::CopyMoveCounter):
1518         (CopyMoveCounter::operator=):
1519         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1520         (TestWebKitAPI::TEST):
1521
1522 2014-08-24  Ryuan Choi  <ryuan.choi@samsung.com>
1523
1524         [EFL] Introduce DEVELOPER_MODE
1525         https://bugs.webkit.org/show_bug.cgi?id=135884
1526
1527         Reviewed by Gyuyoung Kim.
1528
1529         * Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.
1530         (generateBuildSystemFromCMakeProject):
1531
1532 2014-08-24  Alexey Proskuryakov  <ap@apple.com>
1533
1534         build.webkit.org/dashboard unnecessarily loads results of hidden queues
1535         https://bugs.webkit.org/show_bug.cgi?id=136195
1536
1537         Reviewed by Tim Horton.
1538
1539         This patch also makes it possible to avoid any automatic loading, as needed for metrics view.
1540
1541         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1542         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1543         Don't start an update just because a queue object was created. Periodic updates
1544         are triggered by views, so it only makes sense to do the same for the initial update.
1545
1546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1547         Now that Trac object doesn't auto-load, start loading here.
1548
1549         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1550         (QueueView): Calling _updateHiddenState right away was wrong, because it accesses
1551         a data member added by subclasses later. With this.platform being undefined, it
1552         always looked like this queue was not hidden.
1553         (QueueView.prototype._updateHiddenState): Start an immediate update, too.
1554
1555         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1556         (Trac): Don't load anything here, the client may choose to load a custom date range.
1557         (Trac.prototype.startPeriodicUpdates): Added a function to start automatic loading.
1558
1559 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
1560
1561         build.webkit.org/dashboard: Further improve Trac loading
1562         https://bugs.webkit.org/show_bug.cgi?id=136174
1563
1564         Reviewed by Timothy Hatcher.
1565
1566         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1567         (Trac.prototype._xmlTimelineURL): Passing -1 as "max" resulted in an off by one
1568         error, the oldest commit within the range wasn't returned. The correct argument for
1569         "no limit" is 0.
1570         (Trac.prototype.load): Added a function to load a specific time range.
1571         (Trac.prototype._loaded): Updated to support loading revisions that are arbitrarily
1572         positioned with regards to ones that were already known.
1573
1574 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
1575
1576         build.webkit.org/dashboard: Make it possible to pull historic data from Buildbot
1577         https://bugs.webkit.org/show_bug.cgi?id=136182
1578
1579         Reviewed by Timothy Hatcher.
1580
1581         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1582         Make it possible to create a complete BuildbotIteration object with JSON, not only by
1583         loading data from the network.
1584
1585         An iteration has three states:
1586         1. Just created, it only knows the revision, and whether it's already finished.
1587         BuildbotIteration constructor used to create these.
1588         2. A complete JSON report loaded from buildbot. The new constructor form creates these.
1589         3. Data about tests is fetched.
1590
1591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1592         Make it possible to pull all data from a buildbot queue. This needs to be better
1593         optimized eventually, as it's somewhat slow.
1594
1595 2014-08-22  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
1596
1597         Remove LevelDB.
1598         https://bugs.webkit.org/show_bug.cgi?id=136170
1599
1600         Reviewed by Gyuyoung Kim.
1601
1602         * Scripts/webkitpy/common/config/watchlist:
1603         * Scripts/webkitpy/style/checker.py:
1604
1605 2014-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1606
1607         [GTK] install-dependencies don't installs Xvfb that is needed for the tests.
1608         https://bugs.webkit.org/show_bug.cgi?id=136153
1609
1610         Reviewed by Martin Robinson.
1611
1612         * gtk/install-dependencies: Add Xvfb package to the list of dependencies necessary for running tests.
1613
1614 2014-08-21  Alex Christensen  <achristensen@webkit.org>
1615
1616         [Win] Another unreviewed build fix.
1617
1618         * DumpRenderTree/config.h:
1619         Defined WEBCORE_EXPORT on Windows.
1620
1621 2014-08-21  Rohit Kumar  <kumar.rohit@samsung.com>
1622
1623         [EFL][WK2] Minibrowser : Add stop button to abort page load
1624         https://bugs.webkit.org/show_bug.cgi?id=136122
1625
1626         Reviewed by Gyuyoung Kim.
1627
1628         * MiniBrowser/efl/main.c:
1629         (on_key_down):
1630         (on_stop_button_clicked): Callback for stop button press.
1631         (window_create):
1632
1633 2014-08-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1634
1635         [GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb.
1636         https://bugs.webkit.org/show_bug.cgi?id=134070
1637
1638         Reviewed by Martin Robinson.
1639
1640         * Scripts/webkitpy/port/base.py:
1641         (Port.__init__): Set default _jhbuild_wrapper variable.
1642         (Port._should_use_jhbuild): Implement generic check.
1643         * Scripts/webkitpy/port/efl.py: Rename to jhbuild_wrapper variable
1644         to make it consistent with the other ports.
1645         * Scripts/webkitpy/port/gtk.py:
1646         (GtkPort.__init__): Use the new _should_use_jhbuild() method.
1647         (GtkPort.setup_environ_for_server): Get the path for llvmpipe_libgl_path by
1648         querying the jhbuild with printenv. Also check that the path contains
1649         the libraries we expect. Preload this path only for XvfbDriver.
1650         * Scripts/webkitpy/port/xvfbdriver.py:
1651         (XvfbDriver.check_driver): Check for the jhbuild wrapper and use it.
1652         (XvfbDriver._start): The environment for llvmpipe_libgl_path is now
1653         configured at setup_environ_for_server()
1654         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1655         (XvfbDriverTest.make_driver): Get the port default environment.
1656         (XvfbDriverTest.test_start_no_pixel_tests): The expected log now
1657         should include the environment that is passed when running Xvfb.
1658         (XvfbDriverTest.test_start_pixel_tests): Ditto.
1659         (XvfbDriverTest.test_start_arbitrary_worker_number): Ditto.
1660         (XvfbDriverTest.test_start_next_worker): Ditto.
1661         * gtk/jhbuild.modules: Rename checkoutdir to generic "Mesa" to
1662         prevent future problems when the version is raised. Add also a
1663         comment with a warning.
1664         * gtk/jhbuildrc: The path LLVMPIPE_LIBGL_PATH should be the one
1665         that has the llvm optimized Gallium libGL libraries.
1666
1667 2014-08-21  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
1668
1669         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests.
1670         https://bugs.webkit.org/show_bug.cgi?id=136125
1671
1672         Reviewed by Csaba Osztrogonác.
1673
1674         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1675         (RunLLINTCLoopTests.countFailures):
1676         (Run32bitJSCTests.countFailures):
1677         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1678         (RunLLINTCLoopTestsTest):
1679         (RunLLINTCLoopTestsTest.assertResults):
1680         (RunLLINTCLoopTestsTest.test_failures):
1681         (RunLLINTCLoopTestsTest.test_failure):
1682         (RunLLINTCLoopTestsTest.test_no_failure):
1683         (Run32bitJSCTestsTest):
1684         (Run32bitJSCTestsTest.assertResults):
1685         (Run32bitJSCTestsTest.test_failures):
1686         (Run32bitJSCTestsTest.test_failure):
1687         (Run32bitJSCTestsTest.test_no_failure):
1688
1689 2014-08-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1690
1691         Unreviewed, EFL build fix since r172814.
1692
1693         * WebKitTestRunner/config.h: Define WEBCORE_EXPORT.
1694
1695 2014-08-20  Alex Christensen  <achristensen@webkit.org>
1696
1697         Introducing WEBCORE_EXPORT macro.
1698         https://bugs.webkit.org/show_bug.cgi?id=136108
1699
1700         Reviewed by Antti Koivisto.
1701
1702         * TestWebKitAPI/config.h:
1703         Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.
1704
1705 2014-08-20  Rebecca Hauck  <rhauck@adobe.com>
1706
1707         import-w3c-tests doesn't import .svg support files
1708         https://bugs.webkit.org/show_bug.cgi?id=135928
1709
1710         Reviewed by Bem Jones-Bey.
1711
1712         This patch fixes the W3C import script to not treat all
1713         files with an xml mimetype as convertible tests, which
1714         was causing SVG support files to not be imported.
1715
1716         * Scripts/webkitpy/w3c/test_importer.py:
1717         (TestImporter.find_importable_tests):
1718
1719 2014-08-19  Dan Bernstein  <mitz@apple.com>
1720
1721         update-webkit should not check for the presence of Apple’s Internal directory
1722         Last part of https://bugs.webkit.org/show_bug.cgi?id=135815
1723
1724         Reviewed by Tim Horton.
1725
1726         * Scripts/update-webkit:
1727
1728 2014-08-19  Zalan Bujtas  <zalan@apple.com>
1729
1730         Remove ENABLE(SUBPIXEL_LAYOUT).
1731         https://bugs.webkit.org/show_bug.cgi?id=136077
1732
1733         Reviewed by Simon Fraser.
1734
1735         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
1736
1737         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1738
1739 2014-08-19  Akos Kiss  <akiss@inf.u-szeged.hu>
1740
1741         Let the caller define JSC_timeout for run-javascriptcore-tests
1742         https://bugs.webkit.org/show_bug.cgi?id=136068
1743
1744         Reviewed by Csaba Osztrogonác.
1745
1746         Keep the 60 second timeout for jsc tests as the default setting but
1747         don't override the value of JSC_timeout if already set.
1748
1749         * Scripts/run-javascriptcore-tests:
1750
1751 2014-08-19  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
1752
1753         Remove obsolete run-javascriptcore-tests result parsing from master.cfg
1754         https://bugs.webkit.org/show_bug.cgi?id=136039
1755
1756         Reviewed by Csaba Osztrogonác.
1757
1758         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1759         (RunJavaScriptCoreTests.commandComplete):
1760         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1761         (RunJavaScriptCoreTestsTest.test_no_failure_new_output):
1762         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
1763         (RunJavaScriptCoreTestsTest):
1764         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
1765         (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output): Deleted.
1766         (test_layout_failure_new_output): Deleted.
1767         (test_layout_crash_new_output): Deleted.
1768         (test_mozilla_and_layout_failure_new_output): Deleted.
1769         (test_jsc_stress_failure_new_output): Deleted.
1770         (test_js_crashes_and_jsc_stress_failures_new_output): Deleted.
1771
1772 2014-08-19  Alexey Proskuryakov  <ap@apple.com>
1773
1774         build.webkit.org/dashboard should not request 50 revisions from trac each time
1775         https://bugs.webkit.org/show_bug.cgi?id=127130
1776
1777         build.webkit.org/dashboard sometimes fetches a Trac revision in an intermediate state, and never updates later
1778         https://bugs.webkit.org/show_bug.cgi?id=127131
1779
1780         Reviewed by Timothy Hatcher.
1781
1782         Turns out that requesting 50 builds is much slower than requesting by date - even
1783         if the request ends up returning more than 50 results. There is no way to only
1784         request updates, but this change brings request time from 6-8 seconds down to
1785         less than a second.
1786
1787         This patch generalizes date handling for later use in metrics code. As part of the
1788         rewrite, I made newly fetched data update author e-mail in previously fetched
1789         revisions, as it changes after commit queue first lands.
1790
1791         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1792         Updated for event rename. I changed the trac event to not contain the list of new
1793         commits, as we now sometimes update old commits, and that couldn't be expressed
1794         in event data. We never used the list anywhere in the first place.
1795
1796         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1797         (Trac.prototype._xmlTimelineURL): Made this function take arbitrary dates. When called
1798         without arguments, return commits for today and yesterday.
1799         (Trac.prototype._loaded):
1800         (Trac.prototype.update): Moved the function for processing loaded results out of
1801         here for clarity, and also because I'm going to have a separate loading code path
1802         for metrics.
1803
1804 2014-08-18  Dan Bernstein  <mitz@apple.com>
1805
1806         Added an update-webkit option to override the ../Internal check.
1807         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
1808
1809         Reviewed by Tim Horton.
1810
1811         * Scripts/update-webkit:
1812         Added an explicit --internal option to control updating ../Internal, defaulting to whether
1813         ../Internal exists.
1814         (runSvnUpdate): Moved to webkitdirs.pm.
1815         (runGitUpdate): Ditto.
1816         * Scripts/webkitdirs.pm:
1817         (runSvnUpdateAndResolveChangeLogs): Moved runSvnUpdate from update-webkit and renamed to this.
1818         (runGitUpdate): Moved from update-webkit.
1819
1820 2014-08-18  Pratik Solanki  <psolanki@apple.com>
1821
1822         Make update-webkit more lenient for pure git svn repositories
1823         https://bugs.webkit.org/show_bug.cgi?id=135805
1824
1825         Reviewed by Oliver Hunt.
1826
1827         Make the call to git fetch be non fatal. If you have a pure git svn repository, then the
1828         call to git fetch will fail and update-webkit will abort. The purpose of r72966 was to
1829         provide an optimization when you have a git repository setup. We should not fail if the
1830         git setup does not have svn-remote.svn.fetch set.
1831
1832         * Scripts/update-webkit:
1833         (runGitUpdate):
1834
1835 2014-08-18  Simon Fraser  <simon.fraser@apple.com>
1836
1837         Enable Web Inspector in MiniBrowser WK2 windows
1838         https://bugs.webkit.org/show_bug.cgi?id=136045
1839
1840         Reviewed by Tim Horton.
1841         
1842         Set the pref to enable developer extras for all WK2 windows.
1843
1844         * MiniBrowser/mac/WK2BrowserWindowController.m:
1845         (-[WK2BrowserWindowController awakeFromNib]):
1846
1847 2014-08-18  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
1848
1849         master.cfg should handle special return codes of run-perf-tests
1850         https://bugs.webkit.org/show_bug.cgi?id=135974
1851
1852         Reviewed by Ryosuke Niwa.
1853
1854         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1855         (RunAndUploadPerfTests.getText2):
1856         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1857         (RunAndUploadPerfTestsTest):
1858         (RunAndUploadPerfTestsTest.assertResults):
1859         (RunAndUploadPerfTestsTest.test_tests_failed):
1860         (RunAndUploadPerfTestsTest.test_build_bad_build):
1861         (RunAndUploadPerfTestsTest.test_build_bad_source_json):
1862         (RunAndUploadPerfTestsTest.test_build_bad_marge):
1863         (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading):
1864         (RunAndUploadPerfTestsTest.test_build_bad_preparation):
1865
1866 2014-08-17  Brent Fulgham  <bfulgham@apple.com>
1867
1868         [Win] Unreviewed change to force rebuild
1869         (plus drive-by add an accessor I wanted for
1870         some future tooling).
1871
1872         * WinLauncher/WinLauncher.h:
1873         (WinLauncher::webView): Added.
1874
1875 2014-08-16  Mark Hahnenberg  <mhahnenb@gmail.com>
1876
1877         Update contributors.json for my new email
1878         https://bugs.webkit.org/show_bug.cgi?id=136021
1879
1880         Reviewed by Filip Pizlo.
1881
1882         * Scripts/webkitpy/common/config/contributors.json:
1883
1884 2014-08-15  Alexey Proskuryakov  <ap@apple.com>
1885
1886         REGRESSION (r172660): WebKit2.TerminateTwice asserts
1887         https://bugs.webkit.org/show_bug.cgi?id=136012
1888
1889         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Skipped the test in debug mode.
1890
1891 2014-08-15  Ryuan Choi  <ryuan.choi@samsung.com>
1892
1893         Unreviewed build fix attempt on the CMake based pots since r172665
1894
1895         * TestWebKitAPI/CMakeLists.txt: Added JavaScriptCore/interpreter to the include list.
1896
1897 2014-08-15  Brian J. Burg  <burg@cs.washington.edu>
1898
1899         Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
1900         https://bugs.webkit.org/show_bug.cgi?id=131596
1901
1902         Reviewed by Joseph Pecoraro.
1903
1904         * Scripts/run-inspector-generator-tests: Added.
1905         (main):
1906         * Scripts/webkitpy/inspector/__init__.py: Added.
1907         * Scripts/webkitpy/inspector/main.py: Added.
1908         (InspectorGeneratorTests):
1909         (InspectorGeneratorTests.__init__):
1910         (InspectorGeneratorTests.generate_from_json):
1911         (InspectorGeneratorTests.write_error_file):
1912         (InspectorGeneratorTests.detect_changes):
1913         (InspectorGeneratorTests.run_tests):
1914         (InspectorGeneratorTests.main):
1915
1916 2014-08-15  Rebecca Hauck  <rhauck@adobe.com>
1917
1918         run-webkit-tests should skip 'support' directories
1919         https://bugs.webkit.org/show_bug.cgi?id=135910
1920
1921         Reviewed by Bem Jones-Bey.
1922         
1923         This patch adds the 'support' directory to the list
1924         of dirs to skip when looking for runnable tests.
1925         the W3C uses this name for support files, so tests
1926         imported from the W3C will not work without this change
1927         or without many edits.
1928
1929         * Scripts/webkitpy/port/base.py:
1930         (Port._real_tests):
1931
1932 2014-08-14  Brent Fulgham  <bfulgham@apple.com>
1933
1934         [Win] Extend auto-version and version-stamp for RC_ProjectBuildVersion
1935         https://bugs.webkit.org/show_bug.cgi?id=135948
1936         <rdar://problem/18022221>
1937
1938         Reviewed by David Kilzer.
1939
1940         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add tests
1941         for RC_ProjectBuildVersion.
1942
1943 2014-08-05  David Farler  <dfarler@apple.com>
1944
1945         [iOS] run-webkit-tests runs webkit-build-directory on every test
1946         https://bugs.webkit.org/show_bug.cgi?id=135409
1947
1948         Reviewed by Daniel Bates.
1949
1950         * Scripts/webkitpy/port/ios.py:
1951         (IOSSimulatorPort.__init__): Cache Mac build directory.
1952         (IOSSimulatorPort.relay_path): Use cached build directory.
1953         (IOSSimulatorPort._path_to_image_diff): Use cached build directory.
1954
1955 2014-08-14  Zan Dobersek  <zdobersek@igalia.com>
1956
1957         Initialize a separate variable (TestWTF_SOURCES) with the list of files
1958         that are built into the TestWTF executable and move it above the platform-specific
1959         config file inclusion. This makes it possible to add platform-specific files to that
1960         list (e.g. GUniquePtr.cpp for the GTK port).
1961
1962         Rubber-stamped by Carlos Garcia Campos.
1963
1964         * TestWebKitAPI/CMakeLists.txt:
1965         * TestWebKitAPI/PlatformGTK.cmake:
1966
1967 2014-08-13  Akos Kiss  <akiss@inf.u-szeged.hu>
1968
1969         [EFL] Bump up and patch dependencies to allow building for aarch64
1970         https://bugs.webkit.org/show_bug.cgi?id=135885
1971
1972         Reviewed by Gyuyoung Kim.
1973
1974         The currently used versions of pixman, libffi, glib, glib-networking,
1975         and fontconfig fail to configure for aarch64, so they are bumped up to
1976         the latest stable version.
1977
1978         Gstreamer-plugins-base configures for aarch64 but incorrectly recogizes
1979         ARM NEON assembly support, so it is patched with a change that has been
1980         accepted by upstream.
1981
1982         * efl/jhbuild.modules:
1983         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Added.
1984
1985 2014-08-13  Mark Rowe  <mrowe@apple.com>
1986
1987         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
1988
1989         Reviewed by Darin Adler.
1990
1991         * DumpRenderTree/mac/TextInputController.m: Don't use extern "C" in a non-C++ file.
1992
1993 2014-08-13  Alex Christensen  <achristensen@webkit.org>
1994
1995         Progress towards CMake on Mac.
1996         https://bugs.webkit.org/show_bug.cgi?id=135819
1997
1998         Reviewed by Laszlo Gombos.
1999
2000         * WebKitTestRunner/CMakeLists.txt:
2001         Added new cpp parameter for the extension of the generated files.
2002
2003 2014-08-13  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2004
2005         Make check-webkit-style run sort-export-file
2006         https://bugs.webkit.org/show_bug.cgi?id=135877
2007
2008         Reviewed by Csaba Osztrogonác.
2009
2010         * Scripts/webkitpy/style/checker.py:
2011         (_all_categories):
2012         (FileType):
2013         (CheckerDispatcher._file_type):
2014         (CheckerDispatcher._create_checker):
2015         * Scripts/webkitpy/style/checkers/exportfile.py: Added.
2016         (ExportFileChecker):
2017         (ExportFileChecker.__init__):
2018         (ExportFileChecker.check):
2019         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Added.
2020         (handle_style_error):
2021         (MockErrorHandler):
2022         (MockErrorHandler.__init__):
2023         (MockErrorHandler.turn_off_line_filtering):
2024         (MockErrorHandler.__call__):
2025         (ExportFileTest):
2026         (ExportFileTest.setUp):
2027         (ExportFileTest.tearDown):
2028         (ExportFileTest.test_sorted):
2029         (ExportFileTest.test_non_sorted):
2030         (ExportFileTest.test_parse_error):
2031
2032 2014-08-13  Jinwoo Song  <jinwoo7.song@samsung.com>
2033
2034         [EFL] Sets the persistent storage for cookies in MiniBrowser
2035         https://bugs.webkit.org/show_bug.cgi?id=135875
2036
2037         Reviewed by Gyuyoung Kim.
2038
2039         In case of EWK_COOKIE_ACCEPT_POLICY_ALWAYS, sets the persistent storage
2040         for non-session cookies can be stored persistently.
2041
2042         * MiniBrowser/efl/main.c:
2043         (elm_main):
2044
2045 2014-08-12  Daniel Bates  <dabates@apple.com>
2046
2047         [iOS] build-webkit should not build WebKitSystemInterface and WebKitAdditions
2048         https://bugs.webkit.org/show_bug.cgi?id=135845
2049
2050         Reviewed by Andy Estes.
2051
2052         Towards building the iOS WebKit port using the public SDK, remove the logic
2053         added to build-webkit to build projects WebKitSystemInterface and
2054         WebKitAdditions when building the iOS WebKit port.
2055
2056         * Scripts/build-webkit:
2057
2058 2014-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2059
2060         [GTK] Adds dependency for GnuTLS 3.0+ explicitly in gtk/install-dependencies
2061         https://bugs.webkit.org/show_bug.cgi?id=135850
2062
2063         Reviewed by Philippe Normand.
2064
2065         After r172433, GTK port requires GnuTLS 3.0+. In this time, libgnutls-dev is 2.x in
2066         Ubuntu(trusty) and Debian(sid). So added libgnutls28-dev explicitly.
2067
2068         * gtk/install-dependencies:
2069
2070 2014-08-12  Eduardo Lima Mitev  <elima@igalia.com>
2071
2072         [GTK] Subtle-crypto feature off by default and add a new configure flag to enable it
2073         https://bugs.webkit.org/show_bug.cgi?id=135798
2074
2075         Reviewed by Philippe Normand.
2076
2077         * Scripts/webkitperl/FeatureList.pm: Adds new flag --subtle-crypto to
2078             toggle SUBTLE_CRYPTO feature.
2079
2080 2014-08-12  Ryuan Choi  <ryuan.choi@samsung.com>
2081
2082         [EFL] Disable ecore logs about bad fd
2083         https://bugs.webkit.org/show_bug.cgi?id=135831
2084
2085         Reviewed by Gyuyoung Kim.
2086
2087         ecore checks EBADF and prints the warnings.
2088         But, it looks noise in layout test because it's not webkit issue.
2089         This patch disables it until we found right solution.
2090
2091         * efl/jhbuild.modules:
2092         * efl/patches/ecore_remove_warnings.patch: Added.
2093
2094 2014-08-12  Shivakumar JM  <shiva.jm@samsung.com>
2095
2096         [EFL][WK2] Minibrowser: Enhance the application to use download directory selector.
2097         https://bugs.webkit.org/show_bug.cgi?id=135791
2098
2099         Reviewed by Gyuyoung Kim.
2100
2101         Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the
2102         user.
2103
2104         * MiniBrowser/efl/main.c:
2105         (on_download_request):
2106
2107 2014-08-11  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2108
2109         [EFL] Prevent the client from creating ewk_view when EWebkit is not initialized
2110         https://bugs.webkit.org/show_bug.cgi?id=135606
2111
2112         Reviewed by Gyuyoung Kim.
2113
2114         TestWebKitAPI does not initialize EWebkit using ewk_init()
2115         which is not recommended.
2116
2117         * TestWebKitAPI/efl/PlatformWebView.cpp:
2118         (TestWebKitAPI::createEcoreEvas):
2119         Renamed from initEcoreEvas() since it doesn't not initialize
2120         ecore evas.
2121
2122         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2123         Call ewk_init() that initalizes all EFL modules needed by EWebKit
2124         instead of ecore_evas_init() only.
2125
2126         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2127         Call ewk_shutdown() to finalize EWebkit.
2128         (TestWebKitAPI::initEcoreEvas): Deleted.
2129
2130 2014-08-11  Dan Bernstein  <mitz@apple.com>
2131
2132         Added an update-webkit option to update the auxiliary libraries or not.
2133         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
2134
2135         Reviewed by Tim Horton.
2136
2137         * Scripts/update-webkit: Added --[no-]auxiliary-libs option, which defaults to yes unless
2138         an Internal directory exists alongside the WebKit root directory.
2139
2140 2014-08-11  Bem Jones-Bey  <bjonesbe@adobe.com>
2141
2142         Remove hg changeset from w3c-import.log
2143         https://bugs.webkit.org/show_bug.cgi?id=135735
2144
2145         Reviewed by Ryosuke Niwa.
2146
2147         Since the csswg's test suite is now accessible via github and it is
2148         possible to push changes by creating github pull requests, the hg
2149         changeset makes less sense, as many people will just use a clone of
2150         the git repo. There isn't an obvious thing to replace it with, so
2151         might as well remove it for now instead of having it just be set to
2152         UNKNOWN in imports.
2153
2154         This also adds a pointer to the github repo in the generated comments
2155         in the w3c-import.log.
2156
2157         * Scripts/webkitpy/w3c/test_importer.py:
2158         (TestImporter.__init__): Remove changeset handling.
2159         (TestImporter.do_import): Ditto.
2160         (TestImporter.write_import_log): Ditto.
2161         (TestImporter.load_changeset): Deleted.
2162
2163 2014-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2164
2165         Unreviewed. Fix GTK+ make distcheck.
2166
2167         * gtk/manifest.txt: Remove Source/WebCore/Resources/inputSpeech.png.
2168
2169 2014-08-08  Simon Fraser  <simon.fraser@apple.com>
2170
2171         Unbreak webkitpy unit tests by checking for the existence of the image diff template
2172         file before trying to open it (as the tests do for results.html).
2173
2174         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2175         (TestResultWriter.write_image_diff_files):
2176
2177 2014-08-08  Simon Fraser  <simon.fraser@apple.com>
2178
2179         Load the layout test result image diff HTML from a file, rather than having it inline in webkitpy
2180         https://bugs.webkit.org/show_bug.cgi?id=135780
2181
2182         Reviewed by Dan Bates.
2183         
2184         Pull the HTML for the image diff file into a separate file, for easier hackability.
2185
2186         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2187         (TestResultWriter.write_image_diff_files):
2188
2189 2014-08-08  Mark Lam  <mark.lam@apple.com>
2190
2191         Gardening: fix Windows build after r172259.
2192
2193         Not reviewed.
2194
2195         * DumpRenderTree/win/TestRunnerWin.cpp:
2196         (TestRunner::addMockSpeechInputResult): Deleted.
2197         (TestRunner::setMockSpeechInputDumpRect): Deleted.
2198         (TestRunner::startSpeechInput): Deleted.
2199
2200 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
2201
2202         make clean does not work in OpenSource, fails in WebKitLibraries
2203         https://bugs.webkit.org/show_bug.cgi?id=135734
2204
2205         Reviewed by David Kilzer.
2206
2207         * Scripts/copy-webkitlibraries-to-product-directory:
2208         Add a --clean switch that removes possible WebKitSystemInterface
2209         and LLVM libraries and headers that may have been copied to the
2210         product directory.
2211
2212 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
2213
2214         commit-log-message has extra blank line at the top of pre-populated message
2215         https://bugs.webkit.org/show_bug.cgi?id=135744
2216
2217         Reviewed by Csaba Osztrogonác.
2218
2219         Do not add a blank leading line in single ChangeLog commit messages.
2220
2221         * Scripts/commit-log-editor:
2222         (createCommitMessage):
2223         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2224         (test_commit_message_for_one_reviewed_changelog):
2225         (test_commit_message_for_one_rollout_changelog):
2226
2227 2014-08-07  Brent Fulgham  <bfulgham@apple.com>
2228
2229         [Win] Unreviewed gardening.
2230
2231         Have 'Assemble Build Logs' step work properly for DebugSuffix target
2232         (both 32-bit and 64-bit).
2233
2234         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2235
2236 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
2237
2238         Get rid of INPUT_SPEECH
2239         https://bugs.webkit.org/show_bug.cgi?id=135672
2240
2241         Reviewed by Andreas Kling.
2242
2243         * DumpRenderTree/TestRunner.cpp:
2244         (TestRunner::staticFunctions):
2245         (addMockSpeechInputResultCallback): Deleted.
2246         (setMockSpeechInputDumpRectCallback): Deleted.
2247         * DumpRenderTree/TestRunner.h:
2248         * DumpRenderTree/mac/TestRunnerMac.mm:
2249         (TestRunner::addMockSpeechInputResult): Deleted.
2250         (TestRunner::setMockSpeechInputDumpRect): Deleted.
2251         (TestRunner::startSpeechInput): Deleted.
2252
2253 2014-08-07  Bem Jones-Bey  <bjonesbe@adobe.com>
2254
2255         The support directory shouldn't be skipped unconditionally in test import
2256         https://bugs.webkit.org/show_bug.cgi?id=135660
2257
2258         Reviewed by Ryosuke Niwa.
2259
2260         The 'DIRS_TO_SKIP' should only be skipped when in the root directory
2261         of the test repo, as that's the only time they are special. In
2262         addition, instead of hardcoding .hg and .git as special, skip all
2263         directories that begin with '.', just like with files that begin with '.'.
2264         
2265         In order to make this work, the root directory must always be
2266         passed in, so the interface to the script has been changed to take the
2267         root directory, and if one wants to only import a subset of the tests,
2268         a new -t option can be used to limit the tests imported.
2269
2270         * Scripts/webkitpy/w3c/test_importer.py:
2271         (main): Remove repo_dir command line argument.
2272         (parse_args): Add -t option and set expected non-option args to 1.
2273         (TestImporter.__init__): Remove repo_dir.
2274         (TestImporter.do_import): Handle the varying number of import
2275             directories.
2276         (TestImporter.should_keep_subdir): Helper for find_importable_tests to
2277             determine if a subdirectory should be skipped.
2278         (TestImporter.find_importable_tests): Filter directories using new
2279             helper.
2280         (TestImporter.import_tests): Remove use of repo_dir.
2281         (TestImporter.setup_destination_directory): Unused, Deleted. 
2282         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2283         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Update for
2284             new API.
2285         (TestImporterTest.test_import_dir_with_no_tests): Ditto.
2286
2287 2014-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2288
2289         [GTK] Use WebKitNavigationAction also for WebKitNavigationPolicyDecision
2290         https://bugs.webkit.org/show_bug.cgi?id=135695
2291
2292         Reviewed by Gustavo Noronha Silva.
2293
2294         Use WebKitNavigationAction API.
2295
2296         * MiniBrowser/gtk/BrowserWindow.c:
2297         (webViewDecidePolicy):
2298         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
2299         (testNavigationPolicy):
2300
2301 2014-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2302
2303         [GTK] Test /webkit2/WebKitUserContentManager/injected-script fails
2304         https://bugs.webkit.org/show_bug.cgi?id=135696
2305
2306         Reviewed by Sergio Villar Senin.
2307
2308         Don't assume the JavaScript result is always a valid pointer. In case of JavaScript
2309         exception (that happens when testing the script hasn't been injected) the JavaScript
2310         result is NULL.
2311
2312         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2313         (isScriptInjectedForURLAtPath):
2314
2315 2014-08-07  Csaba Osztrogonác  <ossy@webkit.org>
2316
2317         [GTK] Disable IndexedDB
2318         https://bugs.webkit.org/show_bug.cgi?id=135692
2319
2320         Reviewed by Carlos Garcia Campos.
2321
2322         * Scripts/webkitperl/FeatureList.pm:
2323
2324 2014-08-06  Dean Jackson  <dino@apple.com>
2325
2326         ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
2327         https://bugs.webkit.org/show_bug.cgi?id=135675
2328
2329         Reviewed by Sam Weinig.
2330
2331         * Scripts/webkitperl/FeatureList.pm:
2332
2333 2014-08-06  David Farler  <dfarler@apple.com>
2334
2335         Set DSYMUTIL_NUM_THREADS to the number of logical cores
2336         https://bugs.webkit.org/show_bug.cgi?id=135655
2337
2338         Reviewed by Mark Rowe.
2339
2340         * Scripts/webkitdirs.pm:
2341         (buildXCodeProject): Set before calling xcodebuild.
2342
2343 2014-08-06  Adrian Perez de Castro  <aperez@igalia.com>
2344
2345         [GTK] Add support for user scripts to WebKitUserContentManager
2346         https://bugs.webkit.org/show_bug.cgi?id=134738
2347
2348         Reviewed by Carlos Garcia Campos.
2349
2350         Add support for user scripts, to complement the user style sheet
2351         support already present in WebKitUserContentManager. Most of the
2352         moving parts are already present, so this just adds a boxed type
2353         for user scripts (WebKitUserScript) and the corresponding methods
2354         to add and remove scripts from the WebKitUserContentManager.
2355
2356         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2357         Add test case for injected user scripts.
2358         (isScriptInjectedForURLAtPath):
2359         (removeOldInjectedContentAndResetLists):
2360         (testUserContentManagerInjectedStyleSheet):
2361         (testUserContentManagerInjectedScript):
2362         (beforeAll):
2363         (removeOldInjectedStyleSheetsAndResetLists): Deleted.
2364
2365 2014-08-06  Philippe Normand  <pnormand@igalia.com>
2366
2367         [GTK] run-launcher --gtk still fails
2368         https://bugs.webkit.org/show_bug.cgi?id=135642
2369
2370         Reviewed by Carlos Garcia Campos.
2371
2372         The perl interpreter is confused by the combination of string
2373         concatenation and a ternary in the same line. Using a separate
2374         variable to determine the library file extension fixes this issue.
2375
2376         * Scripts/webkitdirs.pm:
2377         (builtDylibPathForName): Use an intermediate variable, it's more
2378         readable and unambiguous.
2379
2380 2014-07-29  Filip Pizlo  <fpizlo@apple.com>
2381
2382         Merge r170564, r170571, r170604, r170628, r170672, r170680, r170724, r170728, r170729, r170819, r170821, r170836, r170855, r170860, r170890, r170907, r170929, r171052, r171106, r171152, r171153, r171214 from ftlopt.
2383
2384     2014-06-25  Filip Pizlo  <fpizlo@apple.com>
2385     
2386             [ftlopt] If a CodeBlock is jettisoned due to a watchpoint then it should be possible to figure out something about that watchpoint
2387             https://bugs.webkit.org/show_bug.cgi?id=134333
2388     
2389             Reviewed by Geoffrey Garen.
2390     
2391             * Scripts/display-profiler-output:
2392     
2393 2014-08-05  David Farler  <dfarler@apple.com>
2394
2395         [iOS] Run ImageDiff in the sim bootstrap
2396         https://bugs.webkit.org/show_bug.cgi?id=135624
2397
2398         Reviewed by David Kilzer.
2399
2400         * Scripts/webkitpy/port/image_diff.py:
2401         (ImageDiffer.stop):
2402         (IOSSimulatorImageDiffer):
2403         (IOSSimulatorImageDiffer._start):
2404         * Scripts/webkitpy/port/ios.py:
2405         (IOSSimulatorPort.diff_image):
2406
2407 2014-08-05  David Farler  <dfarler@apple.com>
2408
2409         [iOS] run-webkit-tests: defaults for --runtime and --device-type flags
2410         https://bugs.webkit.org/show_bug.cgi?id=135441
2411
2412         Reviewed by Tim Horton.
2413
2414         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2415         (parse_args):
2416         (_set_up_derived_options):
2417         If using the ios-simulator platform and runtime or device-type
2418         aren't defined, get the latest runtime from the active Xcode.app
2419         and pick a default device type based on the desired architecture:
2420         iPhone 5 for i386 and iPhone 5s for x86_64.
2421         * Scripts/webkitpy/xcode/__init__.py: Added.
2422         * Scripts/webkitpy/xcode/simulator.py: Added.
2423
2424 2014-08-05  David Farler  <dfarler@apple.com>
2425
2426         [iOS] simctl can hang if run quickly after shutting down CoreSimulator services
2427         https://bugs.webkit.org/show_bug.cgi?id=135626
2428
2429         Reviewed by Dan Bernstein.
2430
2431         * Scripts/webkitpy/port/ios.py:
2432         (IOSSimulatorPort.setup_test_run):
2433         Remove call to simctl shutdown <device> - telling the simulator app to quit
2434         will shut down all booted devices.
2435
2436 2014-08-05  Alexey Proskuryakov  <ap@apple.com>
2437
2438         Remove an unused argument from BuildbotQueue.update()
2439         https://bugs.webkit.org/show_bug.cgi?id=135623
2440
2441         Reviewed by Timothy Hatcher.
2442
2443         Also remaned a constant to better match what it means.
2444
2445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2446
2447 2014-08-05  Vivek Galatage  <vivek.vg@samsung.com>
2448
2449         [gtk] Include llvm-dev(el) package to satisfy mesa build configuration
2450         https://bugs.webkit.org/show_bug.cgi?id=135555
2451
2452         Reviewed by Philippe Normand.
2453
2454         Initial setup of gtk on linux requires this package to be installed.
2455         This is required during the build configuration of mesa through jhbuild.
2456
2457         * gtk/install-dependencies:
2458
2459 2014-08-05  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2460
2461         Fix the commit-log-editor after r167243 and add more unit tests
2462         https://bugs.webkit.org/show_bug.cgi?id=131727
2463
2464         Reviewed by Csaba Osztrogonác.
2465
2466         * Scripts/commit-log-editor:
2467         (createCommitMessage):
2468         (removeLongestCommonPrefixEndingInNewline):
2469         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2470         (CommitMessageForThisCommitTest):
2471         (CommitMessageForThisCommitTest.mock_changelog):
2472         (CommitMessageForThisCommitTest.mock_checkout_for_test):
2473         (CommitMessageForThisCommitTest.test_commit_message_for_unreviewed_changelogs_with_different_messages):
2474         (test_commit_message_for_one_reviewed_changelog):
2475         (test_commit_message_for_changelogs_with_same_messages):
2476         (test_commit_message_for_changelogs_with_different_messages):
2477         (test_commit_message_for_one_rollout_changelog):
2478         (test_commit_message_for_rollout_changelogs_with_different_directories):
2479         (setUp): Deleted.
2480         (test_commit_message_for_this_commit): Deleted.
2481
2482 2014-08-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2483
2484         [GTK] run-launcher --gtk is broken
2485         https://bugs.webkit.org/show_bug.cgi?id=135571
2486
2487         Reviewed by Martin Robinson.
2488
2489         * Scripts/webkitdirs.pm:
2490         (builtDylibPathForName): Search for libwebkit2gtk-4.0
2491
2492 2014-08-04  Matt Baker  <mattbaker@apple.com>
2493
2494         lldb_webkit.py throws exception when generating summary of null StringImpl
2495         https://bugs.webkit.org/show_bug.cgi?id=129448
2496
2497         Reviewed by Jer Noble.
2498
2499         Added checks for null StringImpl and 0 byte ReadMemory calls.
2500
2501         * lldb/lldb_webkit.py:
2502         (WTFStringImpl_SummaryProvider):
2503         (ustring_to_string):
2504         (lstring_to_string):
2505         (WTFStringImplProvider.to_string):
2506         (WTFStringImplProvider.is_initialized):
2507
2508 2014-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2509
2510         [GTK] Do not include JavaScriptCore stress tests in release tarballs
2511         https://bugs.webkit.org/show_bug.cgi?id=135503
2512
2513         Reviewed by Martin Robinson.
2514
2515         * gtk/manifest.txt: Exclude Source/JavaScriptCore/tests dir.
2516
2517 2014-07-30  David Farler  <dfarler@apple.com>
2518
2519         build-webkittestrunner doesn't build the app target for iOS SDKs
2520         https://bugs.webkit.org/show_bug.cgi?id=135433
2521
2522         Reviewed by Dan Bernstein.
2523
2524         * Scripts/build-dumprendertree: Build the app target on iOS.
2525         * Scripts/build-webkittestrunner: Build the app target on iOS.
2526         * Scripts/webkitdirs.pm: Add -sdk flags when building for iOS.
2527         (buildXCodeProject):
2528         * Scripts/webkitpy/port/ios.py: Use --sdk flags instead of SDKROOT.
2529         (IOSSimulatorPort._build_driver_flags):
2530
2531 2014-07-30  David Farler  <dfarler@apple.com>
2532
2533         Remove iOS Perl DumpRenderTree support target
2534         https://bugs.webkit.org/show_bug.cgi?id=135271
2535
2536         Reviewed by Dan Bernstein.
2537
2538         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
2539         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Removed.
2540         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
2541         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
2542         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Removed.
2543         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Removed.
2544         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Removed.
2545         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Removed.
2546         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Removed.
2547         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Removed.
2548         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Removed.
2549         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Removed.
2550         * DumpRenderTree/ios/PerlSupport/Makefile: Removed.
2551
2552 2014-07-30  David Farler  <dfarler@apple.com>
2553
2554         Remove old-run-webkit-tests
2555         https://bugs.webkit.org/show_bug.cgi?id=135374
2556
2557         Reviewed by Csaba Osztrogonác.
2558
2559         * Scripts/old-run-webkit-tests: Removed.
2560
2561 2014-08-02  Dan Bernstein  <mitz@apple.com>
2562
2563         prepare-ChangeLog --no-write shouldn’t require ChangeLog to exist
2564         https://bugs.webkit.org/show_bug.cgi?id=135542
2565
2566         Reviewed by Tim Horton.
2567
2568         * Scripts/prepare-ChangeLog:
2569         (main): Pass $writeChangeLogs for the new requireChangeLogToExist parameter of
2570         findChangeLogs.
2571         (findChangeLogs): Don’t require a ChangeLog file to exist if unless the
2572         requireChangeLogToExist argument is true.
2573
2574 2014-08-01  Dan Bernstein  <mitz@apple.com>
2575
2576         commit-log-editor uses a non-standard message format when git index contains no ChangeLog changes
2577         https://bugs.webkit.org/show_bug.cgi?id=135527
2578
2579         Reviewed by Tim Horton.
2580
2581         * Scripts/commit-log-editor:
2582         In the case of a git repository when there are no changed ChangeLog files, changed to pass
2583         the --delimiters option to prepare-ChangeLog, then process each entry in the output using
2584         commitMessageFromChangeLogEntry.
2585         (commitMessageFromChangeLogEntry): Factored out from createCommitMessage.
2586         (sortKey): Factored out from createCommitMessage.
2587         (createCommitMessage): Changed to use new sortKey and commitMessageFromChangeLogEntry
2588         subroutines.
2589
2590         * Scripts/prepare-ChangeLog:
2591         (main): Parse new --delimiters option.
2592         (generateNewChangeLogs): When --no-write and --delimiters are both specified, always print
2593         the label before each change log entry, and a "~" delimiter on a new line after each entry.
2594
2595 2014-08-01  Bear Travis  <betravis@adobe.com>
2596
2597         [Feature Queries] Enable Feature Queries on EFL/GTK
2598         https://bugs.webkit.org/show_bug.cgi?id=134902
2599
2600         Reviewed by Benjamin Poulain.
2601
2602         Turn the feature on by default for the build script.
2603
2604         * Scripts/webkitperl/FeatureList.pm:
2605
2606 2014-08-01  Timothy Horton  <timothy_horton@apple.com>
2607
2608         Build fix for 32-bit after r171926.
2609
2610         * MiniBrowser/mac/SettingsController.h:
2611         * MiniBrowser/mac/SettingsController.m:
2612
2613 2014-08-01  Tim Horton  <timothy_horton@apple.com>
2614
2615         Confusing build fix after r171926.
2616
2617         * MiniBrowser/mac/AppDelegate.h:
2618         * MiniBrowser/mac/AppDelegate.m:
2619         * MiniBrowser/mac/SettingsController.m:
2620
2621 2014-08-01  Tim Horton  <timothy_horton@apple.com>
2622
2623         Make it easer to add switches to MiniBrowser
2624         https://bugs.webkit.org/show_bug.cgi?id=135499
2625
2626         Reviewed by Simon Fraser.
2627
2628         Add a single class to manage a set of persistent, global settings for MiniBrowser.
2629         Add a new menu that contains items to toggle the aforementioned settings (moving them out of the Debug menu).
2630
2631         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2632         Add SettingsController.{m, h}.
2633
2634         * MiniBrowser/mac/AppDelegate.h:
2635         Move _browserWindowControllers to the implementation.
2636         Get rid of toggleUseWebKit2ByDefault, because SettingsController now takes care
2637         of that; instead, we'll receive didChangeSettings.
2638
2639         * MiniBrowser/mac/AppDelegate.m:
2640         Move the default URL, default URL preference key, and use-WebKit2-by-default
2641         preference key into SettingsController.
2642
2643         (-[BrowserAppDelegate awakeFromNib]):
2644         Add the dynamically-generated SettingsController menu just to the left of the Debug menu.
2645
2646         (-[BrowserAppDelegate newWindow:]):
2647         Ask SettingsController if we should use WebKit2 by default, and what the initial URL to load is.
2648
2649         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2650         SettingsController now takes care of reading the default URL preference.
2651         WK1BrowserWindowController now takes care of enabling the developer extras, via WebPreferences.
2652
2653         (-[BrowserAppDelegate didChangeSettings]):
2654         When settings change, update the key equivalents for the new-window menu items, as they
2655         might have changed (as use-WebKit2-by-default is one of the settings).
2656
2657         Dispatch settings change notifications to all live BrowserControllers.
2658
2659         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2660         (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]): Deleted.
2661         (-[BrowserAppDelegate _useWebKit2ByDefault]): Deleted.
2662         (-[BrowserAppDelegate validateMenuItem:]): Deleted.
2663         All menu item validation for settings is moved into SettingsController.
2664
2665         * MiniBrowser/mac/BrowserWindowController.h:
2666         Simplify the BrowserWindowController interface; "toggling" settings will happen inside SettingsController,
2667         the BrowserWindowController subclasses will be able to a) know when any setting changes, b) query the current setting state.
2668
2669         * MiniBrowser/mac/MainMenu.xib:
2670         Remove the settings menu items from the "Debug" menu.
2671
2672         * MiniBrowser/mac/SettingsController.h: Added.
2673         * MiniBrowser/mac/SettingsController.m: Added.
2674         (+[SettingsController shared]):
2675         (-[SettingsController menu]):
2676
2677         (-[SettingsController _addItemWithTitle:action:indented:]):
2678         (-[SettingsController _addHeaderWithTitle:]):
2679         NSMenuItem-creating helpers.
2680
2681         (-[SettingsController _populateMenu]):
2682         Build the menu. Ideally this and the validation step would eventually be made more dynamic.
2683
2684         (-[SettingsController validateMenuItem:]):
2685         Validate menu items; since they can be used to toggle the default state of a setting,
2686         we'll always return YES. However, we will use this opportunity to set the 'checked' state
2687         of each item.
2688
2689
2690         (-[SettingsController _toggleBooleanDefault:]):
2691         Toggle the given boolean default, and notify BrowserAppDelegate that something changed.
2692
2693         (-[SettingsController toggleUseWebKit2ByDefault:]):
2694         (-[SettingsController useWebKit2ByDefault]):
2695         (-[SettingsController toggleUseTransparentWindows:]):
2696         (-[SettingsController useTransparentWindows]):
2697         (-[SettingsController toggleUsePaginatedMode:]):
2698         (-[SettingsController usePaginatedMode]):
2699         (-[SettingsController toggleUseUISideCompositing:]):
2700         (-[SettingsController useUISideCompositing]):
2701         (-[SettingsController toggleShowLayerBorders:]):
2702         (-[SettingsController layerBordersVisible]):
2703         (-[SettingsController toggleShowTiledScrollingIndicator:]):
2704         (-[SettingsController tiledScrollingIndicatorVisible]):
2705         (-[SettingsController toggleEnableSubPixelCSSOMMetrics:]):
2706         (-[SettingsController subPixelCSSOMMetricsEnabled]):
2707         (-[SettingsController defaultURL]):
2708         Toggle or return the current state of each preference.
2709
2710         * MiniBrowser/mac/WK1BrowserWindowController.m:
2711         (-[WK1BrowserWindowController awakeFromNib]):
2712         (-[WK1BrowserWindowController validateMenuItem:]):
2713         (-[WK1BrowserWindowController windowWillClose:]):
2714         (-[WK1BrowserWindowController find:]):
2715         (-[WK1BrowserWindowController dumpSourceToConsole:]):
2716         (-[WK1BrowserWindowController didChangeSettings]):
2717         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
2718         (-[WK1BrowserWindowController isPaginated]): Deleted.
2719         (-[WK1BrowserWindowController togglePaginationMode:]): Deleted.
2720         (-[WK1BrowserWindowController toggleTransparentWindow:]): Deleted.
2721         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
2722         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
2723         (-[WK1BrowserWindowController layerBordersVisible]): Deleted.
2724         (-[WK1BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
2725         * MiniBrowser/mac/WK2BrowserWindowController.m:
2726         (-[WK2BrowserWindowController awakeFromNib]):
2727         (-[WK2BrowserWindowController validateMenuItem:]):
2728         (-[WK2BrowserWindowController forceRepaint:]):
2729         (-[WK2BrowserWindowController windowWillClose:]):
2730         (-[WK2BrowserWindowController didChangeSettings]):
2731         (-[WK2BrowserWindowController isPaginated]): Deleted.
2732         (-[WK2BrowserWindowController togglePaginationMode:]): Deleted.
2733         (-[WK2BrowserWindowController toggleTransparentWindow:]): Deleted.
2734         (-[WK2BrowserWindowController isUISideCompositingEnabled]): Deleted.
2735         (-[WK2BrowserWindowController toggleUISideCompositing:]): Deleted.
2736         (-[WK2BrowserWindowController layerBordersVisible]): Deleted.
2737         (-[WK2BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
2738         (-[WK2BrowserWindowController tiledScrollingIndicatorVisible]): Deleted.
2739         (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]): Deleted.
2740
2741 2014-08-01  Tim Horton  <timothy_horton@apple.com>
2742
2743         MiniBrowser doesn't support data URLs
2744         https://bugs.webkit.org/show_bug.cgi?id=135492
2745
2746         Reviewed by Simon Fraser.
2747
2748         * MiniBrowser/mac/BrowserWindowController.m:
2749         (-[BrowserWindowController addProtocolIfNecessary:]):
2750         Don't add http:// to data: URLs.
2751
2752         * MiniBrowser/mac/WK2BrowserWindowController.m:
2753         (-[WK2BrowserWindowController fetch:]):
2754         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
2755         Percent-escape the contents of the address field before trying to make a URL.
2756         Percent-unescape the URL when displaying it in the address field.
2757         This is not great, but trivial and good-enough-for-Minibrowser.
2758
2759 2014-07-31  Ryuan Choi  <ryuan.choi@samsung.com>
2760
2761         [EFL][WK2] MiniBrower comes to crash when combo box is pressed
2762         https://bugs.webkit.org/show_bug.cgi?id=135378
2763
2764         Reviewed by Gyuyoung Kim.
2765
2766         "clicked" signal of elm_menu is emitted after EwkView calls popup_menu_hide
2767         and removes Ewk_Popup_Menu instance.
2768
2769         * MiniBrowser/efl/main.c:
2770         (on_popup_menu_show):
2771         (on_popup_menu_discarded): Deleted.
2772
2773 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
2774
2775         [Win] Use RC_PROJECTBUILDVERSION as build portion of version
2776         https://bugs.webkit.org/show_bug.cgi?id=135478
2777
2778         Reviewed by David Kilzer.
2779
2780         Add new test suite for the version-stamp program.
2781
2782         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Added.
2783
2784 2014-07-31  Dan Bernstein  <mitz@apple.com>
2785
2786         Reverted r171893, because it broke http/tests/appcache/different-https-origin-resource-main.html,
2787         which loads HTTPS content without calling the delegate.
2788
2789         Rubber-stamped by Alexey Proskuryakov.
2790
2791         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2792         (WTR::InjectedBundle::platformInitialize):
2793         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2794         (WTR::InjectedBundle::platformInitialize):
2795
2796 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
2797
2798         Unreviewed typo correction (and build fix).
2799
2800         * MiniBrowser/mac/WK2BrowserWindowController.m:
2801         (-[WK2BrowserWindowController awakeFromNib]): Use correct
2802         property name (_fullScreenIsEnabled -> _fullScreenEnabled)
2803
2804 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
2805
2806         MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
2807         https://bugs.webkit.org/show_bug.cgi?id=135482
2808
2809         Reviewed by Simon Fraser.
2810
2811         * MiniBrowser/mac/WK2BrowserWindowController.m:
2812         (-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
2813         feature.
2814
2815 2014-07-31  Alexey Proskuryakov  <ap@apple.com>
2816
2817         [Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
2818         https://bugs.webkit.org/show_bug.cgi?id=135472
2819
2820         Reviewed by Dan Bernstein.
2821
2822         We now handle server trust challenges, and don't need such hacks.
2823
2824         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2825         (WTR::InjectedBundle::platformInitialize):
2826         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2827         (WTR::InjectedBundle::platformInitialize):
2828
2829 2014-07-31  Alexey Proskuryakov  <ap@apple.com>
2830
2831         media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky
2832         on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions
2833         https://bugs.webkit.org/show_bug.cgi?id=135418
2834
2835         Reviewed by Anders Carlsson.
2836
2837         This was only happening in shared web process mode, because WKBundlePostMessage
2838         has different behavior then. When there is no process, the message is dropped on
2839         the floor in multiple process mode, but it's stored to be delivered after launch
2840         in shared process mode.
2841
2842         So, calling resetStateToConsistentValues() resulted in storing a Reset bundle message
2843         that was delivered immediately after launch, when there was nothing to reset.
2844
2845         We don't actually need to reset anything at this point, as the previous call has
2846         already reset everything UI process side, and web process is brand new. All we need
2847         is to reattach the page to a process, as invoke() expects one to exist.
2848
2849         * WebKitTestRunner/TestController.cpp: (WTR::TestController::reattachPageToWebProcess):
2850         * WebKitTestRunner/TestController.h:
2851         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
2852
2853 2014-07-31  Dan Bernstein  <mitz@apple.com>
2854
2855         [WK2] Regression tests can't load HTTPS pages with NetworkProcess due to self-signed certificate
2856         https://bugs.webkit.org/show_bug.cgi?id=115282
2857
2858         Reviewed by Sam Weinig.
2859
2860         * WebKitTestRunner/TestController.cpp:
2861         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true for any
2862         local host server trust protection space.
2863         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Respond with a non-empty
2864         credential to server trust challenges.
2865
2866 2014-07-31  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2867
2868         [webkitpy] Make diff_text generate correct diff if there is no newline at the end of file
2869         https://bugs.webkit.org/show_bug.cgi?id=135381
2870
2871         Reviewed by Csaba Osztrogonác.
2872
2873         * Scripts/webkitpy/port/base.py:
2874         (Port.diff_text):
2875         * Scripts/webkitpy/port/base_unittest.py:
2876         (PortTest.test_diff_text):
2877
2878 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2879
2880         Unreviewed. Fix GTK+ make distcheck.
2881
2882         * gtk/make-dist.py:
2883         (ensure_version_if_possible): Use 4.0 instead of 3.0 as binary
2884         version to find the pkg-config file.
2885         * gtk/manifest.txt: Add missing resource to the tarball.
2886
2887 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2888
2889         [GTK] make distcheck is building from sources dir instead of dist dir
2890         https://bugs.webkit.org/show_bug.cgi?id=135457
2891
2892         Reviewed by Philippe Normand.
2893
2894         * gtk/make-dist.py:
2895         (Distcheck.configure): Use dist_dir as source dir.
2896         (Distcheck.check): Pass dist_dir to configure().
2897
2898 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2899
2900         [GTK] Do not include files that are not in git in the tarball
2901         https://bugs.webkit.org/show_bug.cgi?id=134804
2902
2903         Reviewed by Philippe Normand.
2904
2905         Skip all files in the source tree that are not under version control
2906         except for files added from the build dir like the documentation.
2907
2908         * gtk/make-dist.py:
2909         (Directory.__init__): Initialize the list of files under control version.
2910         (Directory.list_cms_files): Helper function to list all files
2911         under the control version for the current source root.
2912         (Directory.should_skip_file): Return True for files that are not
2913         under control version only when the source root is also under
2914         control version.
2915         (Directory.get_files): Filter the files also using should_skip_file().
2916
2917 2014-07-29  David Farler  <dfarler@apple.com>
2918
2919         iOS Simulator LayoutTestRelay
2920         https://bugs.webkit.org/show_bug.cgi?id=135269
2921
2922         Reviewed by David Kilzer.
2923
2924         * LayoutTestRelay/Configurations/Base.xcconfig: Added.
2925         * LayoutTestRelay/Configurations/DebugRelease.xcconfig: Added.
2926         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj: Added.
2927         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.h: Added.
2928         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.m: Added.
2929         (-[LTPipeRelay inPipePath]):
2930         (-[LTPipeRelay outPipePath]):
2931         (-[LTPipeRelay errorPipePath]):
2932         (-[LTPipeRelay outputStream]):
2933         (-[LTPipeRelay initWithPrefix:]):
2934         (-[LTPipeRelay setup]):
2935         (-[LTPipeRelay tearDown]):
2936         (-[LTPipeRelay connect]):
2937         (-[LTPipeRelay disconnect]):
2938         (-[LTPipeRelay createFIFOs]):
2939         (-[LTPipeRelay destroyFIFOs]):
2940         (-[LTPipeRelay relayStream:]):
2941         (-[LTPipeRelay stream:handleEvent:]):
2942         * LayoutTestRelay/LayoutTestRelay/LTRelay.h: Added.
2943         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h: Added.
2944         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: Added.
2945         (-[LTRelayController uniqueAppPath]):
2946         (-[LTRelayController uniqueAppURL]):
2947         (-[LTRelayController uniqueAppIdentifier]):
2948         (-[LTRelayController processName]):
2949         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
2950         (-[LTRelayController readFileHandle:]):
2951         (-[LTRelayController receivedStandardOutputData:]):
2952         (-[LTRelayController receivedStandardErrorData:]):
2953         (-[LTRelayController disconnected]):
2954         (-[LTRelayController connected]):
2955         (-[LTRelayController crashWithMessage:]):
2956         (-[LTRelayController launchSimulator]):
2957         (-[LTRelayController bootDevice]):
2958         (-[LTRelayController createUniqueApp]):
2959         (-[LTRelayController killApp]):
2960         (-[LTRelayController launchApp]):
2961         (-[LTRelayController start]):
2962         * LayoutTestRelay/LayoutTestRelay/main.m: Added.
2963         (usage):
2964         (getTestingSimDevice):
2965         (getRequiredStringArgument):
2966         (getRemainderArguments):
2967         (main):
2968         * LayoutTestRelay/Makefile: Added.
2969         * Tools/Scripts/build-layouttestrelay: Added.
2970
2971 2014-07-29  Brent Fulgham  <bfulgham@apple.com>
2972
2973         [Win] Modify version numbering scheme to support 5-tuple versions
2974         https://bugs.webkit.org/show_bug.cgi?id=135400
2975         <rdar://problem/17849033>
2976
2977         Reviewed by David Kilzer.
2978
2979         Update test cases to recognize that we can only support Major
2980         values from 0-65535, Minor values from 0-64, Tiny values from 0-999,
2981         Micro values from 0-64, and Nano values from 0-999.
2982
2983         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Update
2984         test expectations for physical limits.
2985
2986 2014-07-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2987
2988         [GTK] GLib tests fail with recent GTK+ due to runtime warning about deprecated properties
2989         https://bugs.webkit.org/show_bug.cgi?id=135411
2990
2991         Reviewed by Sergio Villar Senin.
2992
2993         Recent versions of GTK+ now warn at runtime when a deprecated
2994         property or signal is used. A diagnostic mode was added that is
2995         enabled by default, but that can be disabled by setting
2996         G_ENABLE_DIAGNOSTIC=0. Runtime warnings are considered test
2997         failures by gtester, so we need to run the tests with the
2998         diganostic mode disabled.
2999
3000         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
3001         (main):
3002
3003 2014-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3004
3005         [GTK] Remove WebKitCertificateInfo from WebKit2GTK+ API
3006         https://bugs.webkit.org/show_bug.cgi?id=134830
3007
3008         Reviewed by Gustavo Noronha Silva.
3009
3010         Update the SSL test for the API changes.
3011
3012         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3013         (testLoadFailedWithTLSErrors):
3014
3015 2014-07-24  David Farler  <dfarler@apple.com>
3016
3017         Add knowledge of the iOS Simulator to webkitpy
3018         http://bugs.webkit.org/show_bug.cgi?id=133963
3019
3020         Reviewed by Simon Fraser.
3021
3022         * Scripts/webkitdirs.pm:
3023         (argumentsForConfiguration): Add --ios-sim*
3024         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3025         --runtime and --device-type args added.
3026         * Scripts/webkitpy/port/base.py:
3027         * Scripts/webkitpy/port/driver.py: Add simulator driver.
3028         (IOSSimulatorDriver): Added.
3029         * Scripts/webkitpy/port/factory.py: Add simulator platform.
3030         * Scripts/webkitpy/port/ios.py: Added.
3031
3032 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
3033
3034         fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
3035         https://bugs.webkit.org/show_bug.cgi?id=135398
3036
3037         Reviewed by Zalan Bujtas.
3038
3039         * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):
3040         "hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.
3041
3042         * DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.
3043         For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
3044         sure why.
3045
3046 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
3047
3048         PPT: run-webkit-tests doesn't upload crash logs to bots
3049         https://bugs.webkit.org/show_bug.cgi?id=135391
3050
3051         Reviewed by Joseph Pecoraro.
3052
3053         * WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):
3054         Not a fix to be proud of, but better than not having it work at all.
3055
3056 2014-07-29  Adrian Perez de Castro  <aperez@igalia.com>
3057
3058         [GTK] Remove WebKitWebViewGroup from WebKit2 GTK+ API
3059         https://bugs.webkit.org/show_bug.cgi?id=133729
3060
3061         Reviewed by Carlos Garcia Campos.
3062
3063         Removes WebKitWebViewGroup, effectively reverting the changes
3064         introduced by r149117. The motivation for WebKitWebViewGroup
3065         was using the user style sheet injection API, which has been
3066         moved into WebKitUserContentManager, rendering it unneeded.
3067
3068         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Remove tests
3069         for WebKitWebViewGroup.
3070         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3071         (testWebViewSettings):
3072         Restore the assertions that check that settings objects are
3073         released. Add test for webkit_web_view_new_with_settings().
3074         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Removed.
3075
3076 2014-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3077
3078         Implement webkit_web_view_load_string() in WebKit2
3079         https://bugs.webkit.org/show_bug.cgi?id=134735
3080
3081         Reviewed by Sergio Villar Senin.
3082
3083         Add /webkit2/WebKitWebView/load-bytes test case and simplify
3084         TestDOMXPathNSResolver by using webkit_web_view_load_bytes()
3085         instead of a soup server just to sent the Content-type header.
3086
3087         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
3088         (testWebKitDOMXPathNSResolverNative):
3089         (testWebKitDOMXPathNSResolverCustom):
3090         (beforeAll):
3091         (afterAll):
3092         (serverCallback): Deleted.
3093         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3094         (testLoadBytes):
3095         (beforeAll):
3096         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3097         (LoadTrackingTest::loadBytes):
3098         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
3099         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3100         (WebViewTest::loadBytes):
3101         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3102
3103 2014-07-28  Daniel Bates  <dabates@apple.com>
3104
3105         Add support for running the Clang static analyzer when building WebKit and JSC
3106         https://bugs.webkit.org/show_bug.cgi?id=134955
3107
3108         Reviewed by Brent Fulgham.
3109
3110         * Scripts/build-jsc: Added command line options -[no]-analyze (disabled by default).
3111         * Scripts/build-webkit: Add --analyze command line option to build-webkit to enable
3112         running the Clang static analyzer.
3113         * Scripts/webkitdirs.pm:
3114         (XcodeStaticAnalyzerOption): Added.
3115
3116 2014-07-24  David Farler  <dfarler@apple.com>
3117
3118         Allow for multiple DumpRenderTree and WebKitTestRunner instances in the iOS Simulator
3119         https://bugs.webkit.org/show_bug.cgi?id=135272
3120
3121         Reviewed by Simon Fraser.
3122
3123         * DumpRenderTree/mac/DumpRenderTree.mm:
3124         (dumpRenderTree): Remove hard-coding of FIFO paths.
3125         (-[DumpRenderTree applicationDidEnterBackground:]): Create background task.
3126         (DumpRenderTreeMain): Set DumpRenderTree as UIApplication delegate.
3127         * DumpRenderTree/mac/DumpRenderTreeMac.h: bgTask ivar.
3128         * Scripts/old-run-webkit-tests: Update FIFO paths for ORWT.
3129         * WebKitTestRunner/TestController.cpp: Remove hard-coding of FIFO paths.
3130         * WebKitTestRunner/ios/TestControllerIOS.mm: Move dup2 calls to platformInitialize
3131         * WebKitTestRunner/ios/mainIOS.mm: bgTask ivar.
3132         (-[WebKitTestRunnerApp applicationDidEnterBackground:]): Create background task.
3133         (main): Set WebKitTestRunnerApp as UIApplication delegate.
3134
3135 2014-07-24  David Farler  <dfarler@apple.com>
3136
3137         ImageDiff builds for the simulator when running iOS layout tests
3138         https://bugs.webkit.org/show_bug.cgi?id=135270
3139
3140         Reviewed by Simon Fraser.
3141
3142         * Scripts/build-imagediff: Added.
3143
3144 2014-07-28  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3145
3146         Followup fix after r171594
3147         https://bugs.webkit.org/show_bug.cgi?id=135048
3148
3149         Reviewed by Csaba Osztrogonác.
3150
3151         * Scripts/sort-export-file: Removed extra newlines from help.
3152
3153 2014-07-25  Anders Carlsson  <andersca@apple.com>
3154
3155         WKNavigation's properties are either always nil or don't behave as documented
3156         https://bugs.webkit.org/show_bug.cgi?id=135267
3157         <rdar://problem/17730536>
3158
3159         Reviewed by Andreas Kling.
3160
3161         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3162         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
3163         (TEST):
3164         (-[DidFailProvisionalNavigationDelegate webView:didStartProvisionalNavigation:]):
3165         (-[DidFailProvisionalNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3166
3167 2014-07-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3168
3169         [GTK] install-dependencies needs to install perl-CGI on Fedora
3170         https://bugs.webkit.org/show_bug.cgi?id=135302
3171
3172         Reviewed by Martin Robinson.
3173
3174         * gtk/install-dependencies:
3175         Add perl-CGI to yum dependencies needed for tests
3176
3177 2014-07-25  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3178
3179         Add --dry-run option to sort-export-file
3180         https://bugs.webkit.org/show_bug.cgi?id=135048
3181
3182         Reviewed by Csaba Osztrogonác.
3183
3184         Added --dry-run option to sort-export-file. Running the script with --dry-run
3185         option does not sort the export files but creates a list of the files that
3186         need to be sorted.
3187
3188         * Scripts/sort-export-file:
3189         (sawError):
3190
3191 2014-07-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3192
3193         GTK jhbuild modules needs to build xserver with --disable-local-transport
3194         https://bugs.webkit.org/show_bug.cgi?id=135262
3195
3196         Reviewed by Martin Robinson.
3197
3198         * gtk/jhbuild.modules:
3199         Build X server with --disable-local-transport, since local transport
3200         is only supported on Solaris, SCO, and System V. Fixes build on
3201         Fedora.
3202
3203 2014-07-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3204
3205         [GTK] build-webkit script fails under jhbuild if ACLOCAL_FLAGS is unset
3206         https://bugs.webkit.org/show_bug.cgi?id=135065
3207
3208         Reviewed by Martin Robinson.
3209
3210         * jhbuild/jhbuild-wrapper:
3211         (ensure_jhbuild): do not assume jhbuild sets ACLOCAL_FLAGS
3212
3213 2014-07-23  Joseph Pecoraro  <pecoraro@apple.com>
3214
3215         Unreviewed iOS build fix after r171355.
3216
3217         * TestWebKitAPI/Configurations/Base.xcconfig:
3218         Since all the Tests/WebKit2Cocoa tests are already explicitly skipped on iOS,
3219         simplify to skipping all the tests in the directory. PlatformUtilities are not
3220         building on iOS, which means we are missing necessary Util functions.
3221
3222 2014-07-23  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3223
3224         [EFL] Fix build after r171454
3225         https://bugs.webkit.org/show_bug.cgi?id=135191
3226
3227         Reviewed by Csaba Osztrogonác.
3228
3229         * MiniBrowser/efl/CMakeLists.txt: Add path to new EWebKit2.h location .
3230
3231 2014-07-23  Ryuan Choi  <ryuan.choi@samsung.com>
3232
3233         [EFL] Do not generate forwarding header for ewk headers
3234         https://bugs.webkit.org/show_bug.cgi?id=135147
3235
3236         Reviewed by Gyuyoung Kim.
3237
3238         * WebKitTestRunner/EventSenderProxy.h:
3239
3240 2014-07-21  Sam Weinig  <sam@webkit.org>
3241
3242         [Cocoa] WKScriptMessageHandlers don't seem to function properly after navigating
3243         https://bugs.webkit.org/show_bug.cgi?id=135148
3244
3245         Reviewed by Geoffrey Garen.
3246
3247         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3248         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Added.
3249         (-[SimpleNavigationDelegate webView:didFinishNavigation:]):
3250         (-[ScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3251
3252 2014-07-22  Brent Fulgham  <bfulgham@apple.com>
3253
3254         Correct handling of __VERSION_TEXT__ for 4+-tuple versions
3255         https://bugs.webkit.org/show_bug.cgi?id=135161
3256         <rdar://problem/17763546>
3257
3258         Reviewed by David Kilzer.
3259
3260         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
3261         Add additional test cases to catch errors in multiple-tuple
3262         version string handling.
3263
3264 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
3265
3266         Extend exception fuzzing to the LLInt
3267         https://bugs.webkit.org/show_bug.cgi?id=135076
3268
3269         Reviewed by Oliver Hunt.
3270
3271         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3272
3273 2014-07-22  Jochen Eisinger  <jochen@chromium.org>
3274
3275         Fix my email address in contributors.json
3276         https://bugs.webkit.org/show_bug.cgi?id=135156
3277
3278         Reviewed by Gyuyoung Kim.
3279
3280         * Scripts/webkitpy/common/config/contributors.json:
3281
3282 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
3283
3284         Unreviewed test fix.
3285
3286         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Revert
3287         to older Perl 5.8 syntax for iterating over hashes to allow tests to
3288         run on Mountain Lion bots.
3289
3290 2014-07-21  Alexey Proskuryakov  <ap@apple.com>
3291
3292         https://bugs.webkit.org/show_bug.cgi?id=135137
3293         build.webkit.org/dashboard: webkitperl failures show up as yellow, not red
3294
3295         Reviewed by Darin Adler.
3296
3297         webkitperl results are binary, handle them the same way we handle bindings test results.
3298
3299         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3300         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3301         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
3302
3303 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
3304
3305         [Win] Follow-up for r171324.
3306
3307         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Cygwin
3308         perl reports itself as 'cygwin'; native Windows Perl reports as
3309         'MSWin32'. We need to handle both cases.
3310
3311 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
3312
3313         Unreviewed build fix after r171319.
3314
3315         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: This test should
3316         only execute on Windows. It will fail on other platforms, so give it a way to
3317         successfully exit.
3318
3319 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
3320
3321         [Win] Extend auto-version.pl to support 5-tuple versions
3322         https://bugs.webkit.org/show_bug.cgi?id=135124
3323         <rdar://problem/17750334>
3324
3325         Reviewed by David Kilzer.
3326
3327         Add test cases for auto-version.pl.
3328
3329         * Scripts/webkitperl/auto-version_unittest: Added.
3330         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Added.
3331
3332 2014-07-21  Dean Jackson  <dino@apple.com>
3333
3334         Allow MiniBrowser WK1 to do element fullscreen
3335         https://bugs.webkit.org/show_bug.cgi?id=135125
3336
3337         Reviewed by Simon Fraser.
3338
3339         Allow WK1 windows to go fullscreen using the DOM API.
3340
3341         * MiniBrowser/mac/WK1BrowserWindowController.m:
3342         (-[WK1BrowserWindowController awakeFromNib]): Enable the preference for
3343         fullscreen.
3344
3345 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3346
3347         [GTK] Documentation files are added twice to the tarball
3348         https://bugs.webkit.org/show_bug.cgi?id=135115
3349
3350         Reviewed by Sergio Villar Senin.
3351
3352         * gtk/manifest.txt: Remove duplicated rules.
3353
3354 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3355
3356         [GTK] Simplify make-dist command line arguments
3357         https://bugs.webkit.org/show_bug.cgi?id=134832
3358
3359         Reviewed by Martin Robinson.
3360
3361         Remove --tarball-root and -o command line options and add
3362         --version, since the version can be used to build both, the
3363         tarball root and the output filename. When the version it's not
3364         provided, the pkg-config file is used to get the version. Also
3365         change the default value of build-dir to the current directory,
3366         since it's very common to call make-dist.py from the build dir.
3367
3368         * gtk/make-dist.py:
3369         (get_tarball_root_and_output_filename_from_arguments):
3370
3371 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3372
3373         [GTK] Reduce the size of the tarball generated by distcheck
3374         https://bugs.webkit.org/show_bug.cgi?id=134802
3375
3376         Reviewed by Martin Robinson.
3377
3378         Add more rules to the manifest to decide what files to add:
3379
3380           - Do not include platform specific directories of other ports.
3381           - Do not include port specific cmake files.
3382           - Do not include Objective-C sources.
3383           - Do not include .orig and .rej files.
3384           - Do not include mac specific sandbox files.
3385           - Only include the resources we actually build.
3386
3387         * gtk/manifest.txt:
3388
3389 2014-07-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
3390
3391         [EFL] Enable mpg123 feature for gst-plugin-bad.
3392         https://bugs.webkit.org/show_bug.cgi?id=135016
3393
3394         Reviewed by Laszlo Gombos.
3395
3396         enable-mpg123 feature is added to jhbuild in order to support playback of mp3 format.
3397
3398         * efl/install-dependencies:
3399         * efl/jhbuild.modules:
3400
3401 2014-07-20  Dan Bernstein  <mitz@apple.com>
3402
3403         Test for <rdar://problems/17742611> -[_WKActivatedElementInfo image] is often empty
3404         https://bugs.webkit.org/show_bug.cgi?id=135107
3405
3406         Reviewed by Sam Weinig.
3407
3408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3409         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMNode.mm: Added.
3410         (-[RenderedImageFromDOMNodeFrameLoadDelegate webView:didFinishLoadForFrame:]):
3411         (TestWebKitAPI::TEST):
3412
3413 2014-07-20  David Kilzer  <ddkilzer@apple.com>
3414
3415         Checker: Value stored to 'kernResult' is never read (LayoutTestHelper.m:164)
3416         <http://webkit.org/b/135096>
3417
3418         Reviewed by Alexey Proskuryakov.
3419
3420         * DumpRenderTree/mac/LayoutTestHelper.m:
3421         (lockDownDiscreteGraphics): Check the return values of
3422         IOServiceOpen() and IOObjectRelease(), and log if not
3423         KERN_SUCCESS.
3424
3425 2014-07-19  Anders Carlsson  <andersca@apple.com>
3426
3427         Update.
3428
3429         * Scripts/webkitpy/common/config/watchlist:
3430
3431 2014-07-18  Sam Weinig  <sam@webkit.org>
3432
3433         Revert accidental commit to MiniBrowser to make everything layer backed.
3434
3435         * MiniBrowser/mac/BrowserWindowController.m:
3436         (-[BrowserWindowController windowDidLoad]):
3437
3438 2014-07-18  Dana Burkart  <dburkart@apple.com>
3439
3440         Add a new 'analyze' target to the makefile. This will make use of a new
3441         'PATH_TO_SCAN_BUILD' which, if set will wrap xcodebuild in the clang
3442         static analyzer.
3443         https://bugs.webkit.org/show_bug.cgi?id=135057
3444         <rdar://problem/10193187>
3445
3446         Reviewed by David Kilzer.
3447
3448         * Makefile:
3449
3450 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
3451
3452         Fix EFL+GTK.
3453
3454         * Scripts/run-jsc-stress-tests:
3455
3456 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
3457
3458         Exception fuzzing should work on iOS
3459         https://bugs.webkit.org/show_bug.cgi?id=135070
3460
3461         Reviewed by Mark Hahnenberg.
3462
3463         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3464         (fail):
3465         * Scripts/run-jsc-stress-tests:
3466
3467 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
3468
3469         run-jsc-stress-tests should be able to run helper-based tests in remote mode
3470         https://bugs.webkit.org/show_bug.cgi?id=135064
3471
3472         Reviewed by Mark Hahnenberg.
3473
3474         * Scripts/run-jsc-stress-tests:
3475
3476 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
3477
3478         run-jsc-stress-tests: rename $copy to $doNotMessWithVMPath
3479         https://bugs.webkit.org/show_bug.cgi?id=135061
3480
3481         Rubber stamped by Mark Hahnenberg.
3482
3483         * Scripts/run-jsc-stress-tests:
3484
3485 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
3486
3487         Refactor run-jsc-stress-tests VM copying code to remove some abstractions
3488         https://bugs.webkit.org/show_bug.cgi?id=135059
3489
3490         Reviewed by Mark Lam.
3491         
3492         This is meant to make it easier for me to extend the copying functionality to copy things other than
3493         the framework.
3494
3495         * Scripts/run-jsc-stress-tests:
3496
3497 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
3498
3499         Fix cloop build.
3500
3501         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3502
3503 2014-07-18  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
3504
3505         Fix -v|--verbose option in sort-export-file script.
3506         https://bugs.webkit.org/show_bug.cgi?id=135043
3507
3508         Reviewed by Tim Horton.
3509
3510         -v|--verbose option does not work. Option added to getOptionsResult.
3511
3512         * Scripts/sort-export-file:
3513
3514 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
3515
3516         Really remove dependency on ShellQuote.
3517
3518         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3519
3520 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
3521
3522         Unreviewed, fix build for platforms that don't have ShellQuote.
3523         
3524         * Scripts/jsc-stress-test-helpers/js-exception-fuzz: Take a single argument that has the whole command string.
3525         * Scripts/run-jsc-stress-tests: Do the escaping in Ruby.
3526
3527 2014-07-15  Filip Pizlo  <fpizlo@apple.com>
3528
3529         Need ability to fuzz exception throwing
3530         https://bugs.webkit.org/show_bug.cgi?id=134945
3531         <rdar://problem/17722027>
3532
3533         Reviewed by Sam Weinig.
3534         
3535         Adds a new script, js-exception-fuzz, which will run some jsc command-line using
3536         exception fuzzing. This means that we will force exceptions to be thrown in random
3537         places to see how the engine reacts. This is now integrated with the various test
3538         drivers, so run-javascriptcore-tests will run some exception fuzzing tests by
3539         default.
3540
3541         * Scripts/jsc-stress-test-helpers/js-exception-fuzz: Added.
3542         (fail):
3543         * Scripts/run-javascriptcore-tests:
3544         * Scripts/run-jsc-stress-tests:
3545
3546 2014-07-17  Sam Weinig  <sam@webkit.org>
3547
3548         Fix failing API tests.
3549
3550         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3551         (-[ActiveOffscreenWindow isVisible]):
3552         Override isVisible to make the NSWindows pretend they are visible.
3553
3554 2014-07-17  Alexey Proskuryakov  <ap@apple.com>
3555
3556         Disable button animations in regression tests
3557         https://bugs.webkit.org/show_bug.cgi?id=133647
3558         <rdar://problem/16677530>
3559
3560         Reviewed by Dean Jackson.
3561
3562         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
3563         We already did this for WebKit2, let's do it for WebKit1 too.
3564
3565 2014-07-16  Alexey Proskuryakov  <ap@apple.com>
3566
3567         A test that hangs at cleanup stage confuses webkitpy hugely
3568         https://bugs.webkit.org/show_bug.cgi?id=122475
3569         <rdar://problem/17184354>
3570
3571         Reviewed by Anders Carlsson.
3572
3573         Terminate WebContent process if it freezes between tests. Ideally, we should report
3574         this somehow, but this is better than blaming the wrong test.
3575
3576         * WebKitTestRunner/TestController.cpp:
3577         (WTR::TestController::terminateWebContentProcess):
3578         * WebKitTestRunner/TestController.h:
3579         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
3580
3581 2014-07-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3582
3583         Change style check path with EFL WK2's path in checker_unittest.py
3584         https://bugs.webkit.org/show_bug.cgi?id=134967
3585
3586         Reviewed by Csaba Osztrogonác.
3587
3588         * Scripts/webkitpy/style/checker_unittest.py: Change ewk_view.h path.
3589         (GlobalVariablesTest.test_path_rules_specifier):
3590
3591 2014-07-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3592
3593         Unreviewed. Added myself to the list of committers.
3594
3595         * Scripts/webkitpy/common/config/contributors.json:
3596
3597 2014-07-15  Ryuan Choi  <ryuan.choi@samsung.com>
3598
3599         [EFL] Remove EFL WK1 directory from the checker.py
3600         https://bugs.webkit.org/show_bug.cgi?id=134954
3601
3602         Reviewed by Gyuyoung Kim.
3603
3604         * Scripts/webkitpy/style/checker.py:
3605
3606 2014-07-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3607
3608         Adding myself to contributors.json breaks a webkitpy test
3609         https://bugs.webkit.org/show_bug.cgi?id=134958
3610
3611         Reviewed by Ryosuke Niwa.
3612
3613         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3614         (IRCCommandTest.test_whois): Be more specific and include also the
3615         first name when asking for the whois of Xan in the unit test.
3616
3617 2014-07-14  Daniel Bates  <dabates@apple.com>
3618
3619         check-webkit-style should apply C++ rules to Objective-C++ files
3620         https://bugs.webkit.org/show_bug.cgi?id=134884
3621
3622         Reviewed by Joseph Pecoraro.
3623
3624         Fixes an issue where check-webkit-style doesn't apply applicable C++ rules to
3625         Objective-C++ files.
3626
3627         Currently check-webkit-style doesn't apply the following rules to Objective-C++
3628         files: build/using_std, runtime/max_min_macros, runtime/wtf_move, readability/null.
3629         Instead, we should teach check-webkit-style to apply these rules because, as
3630         its name implies, an Objective-C++ file may contain C++ code.
3631
3632         * Scripts/webkitpy/style/checkers/cpp.py:
3633         (_FileState.__init__): Add instance variable _is_objective_cpp to track whether a file has
3634         extension mm (i.e. an Objective-C++ file).
3635         (_FileState.is_objective_c_or_objective_cpp): Added; returns true if the file
3636         has extension m or mm or if the file has extension h and contains Objective-C directives.
3637         (check_for_null): No change in behavior; don't apply rule to Objective-C++ file.
3638         (check_identifier_name_in_declaration): Substitute _FileState.is_objective_c_or_objective_cpp() for
3639         _FileState.is_c_or_objective_c()
3640         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3641         (WebKitStyleTest.test_null_false_zero): Added test case for Objective-C++ file.
3642         (WebKitStyleTest.test_max_macro): Add test case for Objective-C and Objective-C++ file.
3643         (WebKitStyleTest.test_min_macro): Ditto.
3644         (WebKitStyleTest.test_wtf_move): Add test case for Objective-C++ file.
3645
3646 2014-07-14  Anders Carlsson  <andersca@apple.com>
3647
3648         Make shouldKeepCurrentBackForwardListItemInList part of WKPageLoaderClientV5 to avoid breaking ABI
3649         https://bugs.webkit.org/show_bug.cgi?id=134889
3650
3651         Reviewed by Beth Dakin.
3652
3653         Bump loader version number to 5.
3654
3655         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
3656         (TestWebKitAPI::setPageLoaderClient):
3657         * WebKitTestRunner/TestController.cpp:
3658         (WTR::TestController::createWebViewWithOptions):
3659
3660 2014-07-14  Daniel Bates  <dabates@apple.com>
3661
3662         Teach check-webkit-style to suggest WTF::move() when it sees std::move()
3663         https://bugs.webkit.org/show_bug.cgi?id=134620
3664
3665         Reviewed by Joseph Pecoraro.
3666
3667         * Scripts/webkitpy/style/checkers/cpp.py:
3668         (check_max_min_macros): Fix up comment so that it reads well.
3669         (check_wtf_move): Added.
3670         (check_style): Modified to call check_wtf_move().
3671         (CppChecker): Add category "runtime/wtf_move".
3672         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3673         (WebKitStyleTest.test_wtf_move): Added.
3674
3675 2014-07-12  Peter Szanka  <h868064@stud.u-szeged.hu>
3676
3677         Style checker complains about namespace indentation when there is no namespace
3678         https://bugs.webkit.org/show_bug.cgi?id=105427
3679
3680         Reviewed by Darin Adler.
3681
3682         * Scripts/webkitpy/style/checkers/cpp.py:
3683         (check_namespace_indentation):
3684         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3685         (WebKitStyleTest.test_indentation):
3686
3687         The indentation level depends on the parantheses too, to avoid false warning in case of several statements inside macros.
3688
3689 2014-07-12  Daker Fernandes Pinheiro  <daker.pinheiro@openbossa.org>
3690
3691         Remove excessive nesting from _EnumState.process_clean_line at cpp style checker
3692         https://bugs.webkit.org/show_bug.cgi?id=125317
3693
3694         Reviewed by Darin Adler.
3695
3696         * Scripts/webkitpy/style/checkers/cpp.py:
3697         (_EnumState.process_clean_line):
3698
3699 2014-07-12  Brian Holt  <brian.holt@samsung.com>
3700
3701         Style Checker should prevent enums in bitfields
3702         https://bugs.webkit.org/show_bug.cgi?id=57352
3703
3704         Reviewed by Darin Adler.
3705
3706         Added check that enums are not used as types for bitfields
3707         and a unit test.
3708
3709         * Scripts/webkitpy/style/checkers/cpp.py:
3710         (check_language):
3711         (CppChecker):
3712         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3713         (CppStyleTest):
3714         (CppStyleTest.test_enum_bitfields):
3715         (CppStyleTest.test_plain_integral_bitfields):
3716
3717 2014-07-10  Myles C. Maxfield  <mmaxfield@apple.com>
3718
3719         [iOS] Pasting rich content does not perform a two-step paste
3720         https://bugs.webkit.org/show_bug.cgi?id=134795
3721
3722         Reviewed by Benjamin Poulain.
3723
3724         Two-step paste requires setting InputViewObeysDOMFocus on the UIWebBrowserView.
3725
3726         * DumpRenderTree/mac/DumpRenderTree.mm:
3727         (createWebViewAndOffscreenWindow):
3728
3729 2014-07-10  Carlos Garcia Campos  <cgarcia@igalia.com> and Martin Robinson  <mrobinson@igalia.com>
3730
3731         [GTK][CMake] Add a 'distcheck' target
3732         https://bugs.webkit.org/show_bug.cgi?id=130675
3733
3734         Reviewed by Gustavo Noronha Silva.
3735
3736         Add --check option to make-dist script that builds and installs the tarball.
3737
3738         * gtk/make-dist.py:
3739         (Distcheck.__init__):
3740         (Distcheck.extract_tarball): Extratc the tarball.
3741         (Distcheck.configure): Run cmake.
3742         (Distcheck.configure.create_dir): Helper function to create a directory.
3743         (Distcheck.build): Run make.
3744         (Distcheck.install): Run make install.
3745         (Distcheck.clean): Clean up the extracted tarball.
3746         (Distcheck.check): Run all previous methods in order.
3747         * gtk/manifest.txt: Add missing file.
3748
3749 2014-07-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3750
3751         [GTK] Use the same default options for production builds that previous stable releases
3752         https://bugs.webkit.org/show_bug.cgi?id=134589
3753
3754         Reviewed by Martin Robinson.
3755
3756         Make sure all features enabled in production builds are also
3757         enabled in developer mode.
3758
3759         * Scripts/webkitperl/FeatureList.pm: Enable ACCELERATED_2D_CANVAS
3760         and CSS_FILTERS for the GTK port.
3761
3762 2014-07-09  Brent Fulgham  <bfulgham@apple.com>
3763
3764         [Win] Remove uses of 'bash' in build system
3765         https://bugs.webkit.org/show_bug.cgi?id=134782
3766         <rdar://problem/17615533>
3767
3768         Reviewed by Dean Jackson.
3769
3770         Remove uses of 'bash' by replacing Windows-specific bash scripts
3771         with Perl equivalents.
3772
3773         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
3774         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
3775         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
3776         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
3777         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
3778         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
3779
3780 2014-07-09  Brent Fulgham  <bfulgham@apple.com>
3781
3782         [Win] Remove use of 'grep' in build steps
3783         https://bugs.webkit.org/show_bug.cgi?id=134770
3784         <rdar://problem/17608783>
3785
3786         Reviewed by Tim Horton.
3787
3788         Replace uses of the grep command in Windows builds with the equivalent
3789         Perl program.
3790
3791         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
3792         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
3793         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
3794         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
3795         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
3796         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
3797
3798 2014-07-09  Commit Queue  <commit-queue@webkit.org>
3799
3800         Unreviewed, rolling out r170889.
3801         https://bugs.webkit.org/show_bug.cgi?id=134754
3802
3803         This patch is wrong (Requested by philn on #webkit).
3804
3805         Reverted changeset:
3806
3807         "[GTK] Gstreamer missing from the install-dependencies script"
3808         https://bugs.webkit.org/show_bug.cgi?id=134727
3809         http://trac.webkit.org/changeset/170889
3810
3811 2014-07-08  Brian J. Burg  <burg@cs.washington.edu>
3812
3813         resolve-ChangeLogs fails when WebKit repository is a git submodule
3814         https://bugs.webkit.org/show_bug.cgi?id=134734
3815
3816         Reviewed by David Kilzer.
3817
3818         When using resolve-ChangeLogs in a WebKit git repository with a
3819         non-default arrangement of GIT_DIR and GIT_WORK_TREE, incorrect
3820         paths are computed and the script fails mysteriously.
3821
3822         We were naively computing GIT_WORK_TREE as being one level above
3823         GIT_DIR, but this is not the case for submodules or a manually
3824         configured GIT_WORK_TREE or GIT_DIR location.
3825
3826         * Scripts/VCSUtils.pm:
3827         (gitTreeDirectory): Added. Find the equivalent of GIT_WORK_TREE.
3828         (determineVCSRoot): Calculate the working tree root directly.
3829
3830 2014-07-08  Tim Horton  <timothy_horton@apple.com>
3831
3832         [WK2] Expose a few drawing/compositing settings on WKPreferences(Private)
3833         https://bugs.webkit.org/show_bug.cgi?id=134645
3834
3835         Reviewed by Dan Bernstein.
3836
3837         * MiniBrowser/mac/BrowserWindowController.h:
3838         * MiniBrowser/mac/MainMenu.xib:
3839         Add menu items for layer borders and the tiled scrolling indicator.
3840
3841         * MiniBrowser/mac/WK1BrowserWindowController.m:
3842         (-[WK1BrowserWindowController validateMenuItem:]):
3843         (-[WK1BrowserWindowController layerBordersAreVisible]):
3844         (-[WK1BrowserWindowController toggleLayerBordersVisibility:]):
3845         Add getters/setters/validators for layer borders.
3846
3847         * MiniBrowser/mac/WK2BrowserWindowController.m:
3848         (-[WK2BrowserWindowController awakeFromNib]):
3849         (-[WK2BrowserWindowController validateMenuItem:]):
3850         (-[WK2BrowserWindowController layerBordersAreVisible]):
3851         (-[WK2BrowserWindowController toggleLayerBordersVisibility:]):
3852         (-[WK2BrowserWindowController tiledScrollingIndicatorIsVisible]):
3853         (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]):
3854         Add getters/setters/validators for layer borders and the tiled scrolling indicator.
3855
3856         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
3857         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
3858         Remove the WebKit2 version of the subpixel metrics pref, because it doesn't work, because
3859         nothing in WebKit2 reads this default, and there is no WebKit2 API for adjusting this preference.
3860
3861 2014-07-08  Adrian Perez de Castro  <aperez@igalia.com>
3862
3863         [GTK] Move user style sheet API out of WebKitWebViewGroup
3864         https://bugs.webkit.org/show_bug.cgi?id=134551
3865
3866         Reviewed by Carlos Garcia Campos.
3867
3868         Removes testing user style sheet injection from
3869         TestWebKitWebViewGroup and moves that into a new
3870         TestWebKitUserContentManager, adapting the existing tests to the new
3871         API. Also, it contains a new test case for
3872         webkit_web_view_new_with_user_content_manager().
3873
3874         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3875         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: Added.
3876         (UserContentManagerTest::UserContentManagerTest):
3877         (testWebViewNewWithUserContentManager):
3878         (isStyleSheetInjectedForURLAtPath):
3879         (fillURLListFromPaths):
3880         (removeOldInjectedStyleSheetsAndResetLists):
3881         (testUserContentManagerInjectedStyleSheet):
3882         (serverCallback):
3883         (beforeAll):
3884         (afterAll):
3885         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
3886         (beforeAll):
3887         (afterAll):
3888         (isStyleSheetInjectedForURLAtPath): Deleted.
3889         (fillURLListFromPaths): Deleted.
3890         (removeOldInjectedStyleSheetsAndResetLists): Deleted.
3891         (testWebViewGroupInjectedStyleSheet): Deleted.
3892         (serverCallback): Deleted.
3893         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3894         (WebViewTest::WebViewTest):
3895         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3896
3897 2014-07-08  Ziran Sun  <ziran.sun@samsung.com>
3898
3899         [GTK] Gstreamer missing from the install-dependencies script
3900         https://bugs.webkit.org/show_bug.cgi?id=134727
3901
3902         Reviewed by Mario Sanchez Prada.
3903
3904         Added missing gstreamer dependencies for debian based systems.
3905
3906         * gtk/install-dependencies: Added 2 dependencies for apt-get.
3907
3908 2014-07-08  Myles C. Maxfield  <mmaxfield@apple.com>
3909
3910         Add myself to the watchlist for text-related files
3911         https://bugs.webkit.org/show_bug.cgi?id=134707
3912
3913         Reviewed by Timothy Horton.
3914
3915         * Scripts/webkitpy/common/config/watchlist:
3916
3917 2014-07-08  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
3918
3919         Add option to specify output file location in sunspider.
3920         https://bugs.webkit.org/show_bug.cgi?id=134339
3921
3922         Reviewed by Darin Adler.
3923
3924         * Scripts/run-sunspider:
3925
3926 2014-07-07  Alex Christensen  <achristensen@webkit.org>
3927
3928         Unreviewed build fix.
3929
3930         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3931         Make Common.cpp excluded from both 32-bit and 64-bit builds.
3932
3933 2014-07-07  Simon Fraser  <simon.fraser@apple.com>
3934
3935         Have MiniBrowser log and reload if the Web Content Process crashes
3936         https://bugs.webkit.org/show_bug.cgi?id=134691
3937
3938         Reviewed by Tim Horton.
3939         
3940         Implement _webViewWebProcessDidCrash, log and reload when the web process
3941         crashes.
3942
3943         * MiniBrowser/mac/WK2BrowserWindowController.m:
3944         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]):
3945
3946 2014-07-07  Alberto Garcia  <berto@igalia.com>
3947
3948         update-webkitgtk-libs script fails by unsatisfied dependencies
3949         https://bugs.webkit.org/show_bug.cgi?id=134547
3950
3951         Reviewed by Martin Robinson.
3952
3953         Install libxcb-xfixes0-dev, needed to build Mesa.
3954
3955         * gtk/install-dependencies:
3956
3957 2014-07-06  Yoav Weiss  <yoav@yoav.ws>
3958
3959         Turn on img@sizes compile flag
3960         https://bugs.webkit.org/show_bug.cgi?id=134634
3961
3962         Reviewed by Benjamin Poulain.
3963
3964         * Scripts/webkitperl/FeatureList.pm: Turn on the img@sizes feature.
3965
3966 2014-07-06  Hyowon Kim  <hw1008.kim@samsung.com>
3967
3968         Unreviewed. Adding myself to committers.
3969
3970         * Scripts/webkitpy/common/config/contributors.json:
3971
3972 2014-07-05  KwangHyuk Kim  <hyuki.kim@samsung.com>
3973
3974         [EFL] Add libgeoclue-dev to Tools/efl/install-dependencies.
3975         https://bugs.webkit.org/show_bug.cgi?id=134648
3976
3977         Reviewed by Gyuyoung Kim.
3978
3979         As Geoclue is enabled for EFL, libgeoclue-dev is also added to Tools/efl/install-dependencies.
3980
3981         * efl/install-dependencies:
3982
3983 2014-07-04  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3984
3985         [EFL] Support Geolocation
3986         https://bugs.webkit.org/show_bug.cgi?id=134439
3987
3988         Reviewed by Antonio Gomes.
3989
3990         * Scripts/webkitperl/FeatureList.pm: Enable geolocation for EFL port.
3991
3992 2014-07-04  Shivakumar JM  <shiva.jm@samsung.com>
3993
3994         [EFL][WK2] Enhance the Minibrowser to show selected/highlighted text in search bar, if any.
3995         https://bugs.webkit.org/show_bug.cgi?id=134485
3996
3997         Reviewed by Gyuyoung Kim.
3998
3999         Use script_execute_callback to get selected/highlighted text and show in search bar.
4000
4001         * MiniBrowser/efl/main.c:
4002         (script_execute_callback):
4003         (on_key_down):
4004
4005 2014-07-04  Dan Bernstein  <mitz@apple.com>
4006
4007         Build fix after r170811.
4008
4009         * MiniBrowser/mac/WK2BrowserWindowController.m:
4010         (-[WK2BrowserWindowController reload:]):
4011
4012 2014-07-04  Timothy Horton  <timothy_horton@apple.com>
4013
4014         Typo in watchlist config means four specific people get Cc'd on everything
4015         https://bugs.webkit.org/show_bug.cgi?id=134626
4016
4017         Reviewed by Gyuyoung Kim.
4018
4019         * Scripts/webkitpy/common/config/watchlist:
4020         Remove leading pipe, which meant that this rule matched everything!
4021
4022 2014-07-03  Shivakumar JM  <shiva.jm@samsung.com>
4023
4024         [EFL][WK2] Enhance the Minibrowser to show text search count and close search bar.
4025         https://bugs.webkit.org/show_bug.cgi?id=134486
4026
4027         Reviewed by Gyuyoung Kim.
4028
4029         Use on_search_close_button_clicked() callback to close search bar and on_search_text_found() callback to show search count.
4030
4031         * MiniBrowser/efl/main.c:
4032         (search_box_show):
4033         (search_box_hide):
4034         (on_search_close_button_clicked):
4035         (on_search_text_found):
4036         (window_create):
4037
4038 2014-07-03  Daniel Bates  <dabates@apple.com>
4039
4040         Add WTF::move()
4041         https://bugs.webkit.org/show_bug.cgi?id=134500
4042
4043         Rubber-stamped by Anders Carlsson.
4044
4045         Substitute WTF::move() for std::move().
4046
4047         * DumpRenderTree/win/DRTDataObject.cpp:
4048         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4049         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4050         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
4051         * TestWebKitAPI/Tests/WTF/Vector.cpp:
4052         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
4053         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added FIXME comments that explain that some of the sub-tests
4054         aren't actually testing move semantics in tests: MoveAssignmentFromSameType, MoveAssignmentFromSimilarType,
4055         ConstructionFromSameType, and ConstructionFromSimilarType.
4056         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
4057
4058 2014-07-03  László Langó  <llango.u-szeged@partner.samsung.com>
4059
4060         [JavaScriptCore] Add --cmakeargs option to build-jsc.
4061         https://bugs.webkit.org/show_bug.cgi?id=134590
4062
4063         Reviewed by Ryosuke Niwa.
4064
4065         * Scripts/build-jsc:
4066
4067 2014-07-03  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
4068
4069         Add option to specify jsc args in run-sunspider.
4070         https://bugs.webkit.org/show_bug.cgi?id=134341
4071
4072         Reviewed by Csaba Osztrogonác.
4073
4074         * Scripts/run-sunspider:
4075
4076 2014-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4077
4078         [GTK] Unreviewed gardening.
4079
4080         * Scripts/run-gtk-tests:
4081         (TestRunner): Report and mark flaky test WebKit2Gtk/TestCookieManager:persistent-storage
4082
4083 2014-07-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4084
4085         Clean up unused EFL buildbot information in BuildSlaveSupport and TestResultServer
4086         https://bugs.webkit.org/show_bug.cgi?id=134581
4087
4088         Reviewed by Tim Horton.
4089
4090         Should be removed unused EFL bot info.
4091
4092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4093         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
4094         (EWS):
4095         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4096         (WebKitBuildbot):
4097         * TestResultServer/static-dashboards/builders.jsonp:
4098         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4099         (test):
4100
4101 2014-07-02  Alex Christensen  <achristensen@webkit.org>
4102
4103         Unreviewed.  Moved self to reviewers list.
4104
4105         * Scripts/webkitpy/common/config/contributors.json:
4106         Moved self to reviewers list, added WebGL to expertise.
4107
4108 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
4109
4110         [GTK] Make dist only works when run from the source directory
4111         https://bugs.webkit.org/show_bug.cgi?id=134543
4112
4113         Reviewed by Martin Robinson.
4114
4115         Since the paths in the manifest are relative to the source dir,
4116         and the script expects the current working directory to be the
4117         source directory, resolve all passed in relative paths while
4118         parsing the arguments and then change the current working
4119         directory.
4120
4121         * gtk/make-dist.py:
4122
4123 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
4124
4125         [GTK] make dist is broken
4126         https://bugs.webkit.org/show_bug.cgi?id=134542
4127
4128         Reviewed by Martin Robinson.
4129
4130         * gtk/make-dist.py: Rename command line options to match what cmake uses.
4131         * gtk/manifest.txt: Remove WebKit1 references and add WebKitDOM documentation.
4132
4133 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
4134
4135         [GTK] WebKitWebView::create should receive information about the navigation action
4136         https://bugs.webkit.org/show_bug.cgi?id=133680
4137
4138         Reviewed by Martin Robinson.
4139
4140         Add unit test to check the WebKitNavigationAction passed to
4141         WebKitWebView::create callback.
4142
4143         * MiniBrowser/gtk/BrowserWindow.c:
4144         (webViewCreate): Add WebKitNavigationAction parameter.
4145         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
4146         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
4147         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
4148         (testWebViewCreateNavigationData):
4149         (beforeAll):
4150         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
4151         (createCallback):
4152
4153 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
4154
4155         [GTK] Do not add forward declaration of class struct for interfaces
4156         https://bugs.webkit.org/show_bug.cgi?id=134297
4157
4158         Reviewed by Martin Robinson.
4159
4160         Add Iface symbol to documentation instead of Class for interfaces.
4161
4162         * gtk/webkitdom.py:
4163         (WebKitDOMDocGeneratorSections.write_section):
4164
4165 2014-07-01  Carlos Garcia Campos  <cgarcia@igalia.com>
4166
4167         [GTK] XPathNSResolver should be exposed as an interface instead of as a class
4168         https://bugs.webkit.org/show_bug.cgi?id=134028
4169
4170         Reviewed by Gustavo Noronha Silva.
4171
4172         Add unit tests to check WebKitDOMXPathNSResolver API when using the
4173         native one and a user provided one.
4174
4175         * Scripts/webkitpy/style/checker.py: Add WebKitDOMXPathNSResolver
4176         to the list of GTK+ public API exceptions.
4177         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
4178         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: Added.
4179         (webkitXPathNSResolverLookupNamespaceURI):
4180         (webkitXPathNSResolverDOMXPathNSResolverIfaceInit):
4181         (webkit_xpath_ns_resolver_init):
4182         (webkit_xpath_ns_resolver_class_init):
4183         (WebKitDOMXPathNSResolverTest::create):
4184         (WebKitDOMXPathNSResolverTest::webPageFromArgs):
4185         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
4186         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
4187         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
4188         (WebKitDOMXPathNSResolverTest::runTest):
4189         (registerTests):
4190         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: Added.
4191         (runTest):
4192         (testWebKitDOMXPathNSResolverNative):
4193         (testWebKitDOMXPathNSResolverCustom):
4194         (serverCallback):
4195         (beforeAll):
4196         (afterAll):
4197         * gtk/webkitdom.py:
4198         (WebKitDOMDocGeneratorSections.write_section): Add
4199         WebKitDOMXPathNSResolver to the list of interfaces.
4200
4201 2014-07-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4202
4203         Fix build break on EFL and GTK ports since r170683
4204         https://bugs.webkit.org/show_bug.cgi?id=134536
4205
4206         Unreviewed, build fix.
4207
4208         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
4209
4210 2014-07-01  Sam Weinig  <sam@webkit.org>
4211
4212         [Cocoa][Mac] WKWebView should automatically set topContentInset when beneath a toolbar
4213         <rdar://problem/17523159>
4214         https://bugs.webkit.org/show_bug.cgi?id=134496
4215
4216         Reviewed by Beth Dakin.
4217
4218         * MiniBrowser/mac/BrowserWindowController.m:
4219         (-[BrowserWindowController windowDidLoad]):
4220         Use the NSFullSizeContentViewWindowMask bit on Yosemite and later to enable toolbar blurring.
4221
4222 2014-07-01  Zan Dobersek  <zdobersek@igalia.com>
4223
4224         [CMake] Add necessary support for building for the Wayland target
4225         https://bugs.webkit.org/show_bug.cgi?id=134160
4226
4227         Reviewed by Darin Adler.
4228
4229         * CMakeLists.txt: Only build the TestNetscapePlugIn target in case
4230         the X11 windowing target is enabled.
4231
4232 2014-07-01  Chris Fleizach  <cfleizach@apple.com>
4233
4234         AX: HTML indeterminate IDL attribute not mapped to checkbox value=2
4235         https://bugs.webkit.org/show_bug.cgi?id=134492
4236
4237         Reviewed by Andreas Kling.
4238
4239         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4240         (AccessibilityUIElement::isIndeterminate):
4241         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4242         (WTR::AccessibilityUIElement::isIndeterminate):
4243
4244 2014-07-01  Daniel Bates  <dabates@apple.com>
4245
4246         Remove unnecessary calls to std::move()
4247         https://bugs.webkit.org/show_bug.cgi?id=134493
4248
4249         Reviewed by Anders Carlsson.
4250
4251         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4252         (TestWebKitAPI::TEST):
4253         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
4254         (TestWebKitAPI::TEST):
4255
4256 2014-07-01  Pratik Solanki  <psolanki@apple.com>
4257
4258         Unreviewed. Adding myself to the reviewers list to make commit bot happy.
4259
4260         * Scripts/webkitpy/common/config/contributors.json:
4261
4262 2014-07-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4263
4264         webkit-patch apply-from-bug / apply-attachment should not ask for credentials if none are required
4265         https://bugs.webkit.org/show_bug.cgi?id=40095
4266
4267         Reviewed by Csaba Osztrogonác.
4268
4269         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4270         (Bugzilla.fetch_attachment_contents): make a first fetch on bugzilla without authentication. If failing, use authentication (similar to fetch_bug_dictionary).
4271         (Bugzilla):
4272         (Bugzilla.bug_id_for_attachment_id): ditto.
4273
4274 2014-07-01  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4275
4276         [webkitpy] Refactor pluralizer in grammar.py
4277         https://bugs.webkit.org/show_bug.cgi?id=133067
4278
4279         Reviewed by Csaba Osztrogonác.
4280
4281         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4282         (LayoutTestRunner.run_tests):
4283         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4284         (Manager.run):
4285         * Scripts/webkitpy/layout_tests/views/printing.py:
4286         (Printer.print_found):
4287         (Printer.print_workers_and_shards):
4288         (Printer._print_one_line_summary):
4289         * Scripts/webkitpy/test/printer.py:
4290         (Printer.print_result):
4291         * Scripts/webkitpy/tool/bot/feeders.py:
4292         (EWSFeeder.feed):
4293         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4294         (FlakyTestReporter._lookup_bug_for_flaky_test):
4295         * Scripts/webkitpy/tool/bot/irc_command.py:
4296         (Rollout._check_diff_failure):
4297         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
4298         (IRCCommandTest.test_rollout):
4299         * Scripts/webkitpy/tool/commands/download.py:
4300         (AbstractPatchProcessingCommand._process_patch.execute):
4301         (ProcessBugsMixin._fetch_list_of_patches_to_process):
4302         (ProcessURLsMixin._fetch_list_of_patches_to_process):
4303         * Scripts/webkitpy/tool/commands/queries.py:
4304         (WhatBroke.execute):
4305         * Scripts/webkitpy/tool/commands/suggestnominations.py:
4306         (SuggestNominations._print_nominations):
4307         (SuggestNominations._print_counts):
4308         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
4309         (_make_options):
4310         (test_basic):
4311         (test_with_verbose):
4312         * Scripts/webkitpy/tool/commands/upload.py:
4313         (PostCommits.execute):
4314         * Scripts/webkitpy/tool/grammar.py:
4315         (pluralize):
4316         * Scripts/webkitpy/tool/grammar_unittest.py:
4317         (GrammarTest.test_join_with_separators):
4318         (GrammarTest):
4319         (GrammarTest.test_plural):
4320         (GrammarTest.test_pluralize):
4321         * Scripts/webkitpy/tool/multicommandtool.py:
4322         (Command.check_arguments_and_execute):
4323         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
4324         (ObsoletePatches.run):
4325         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4326         (PrepareChangeLogForRevert._message_for_revert):
4327
4328 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
4329
4330         [iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree