[WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2
3         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
4         https://bugs.webkit.org/show_bug.cgi?id=196727
5
6         Reviewed by Fujii Hironori.
7
8         * MiniBrowser/win/WebKitBrowserWindow.cpp:
9         (WebKitBrowserWindow::create):
10
11 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
12
13         [ews-build] Add unit tests for PrintConfiguration
14         https://bugs.webkit.org/show_bug.cgi?id=196752
15
16         Reviewed by Dewei Zhu.
17
18         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
19
20 2019-04-09  Keith Rollin  <krollin@apple.com>
21
22         Unreviewed build maintenance -- update .xcfilelists.
23
24         * DumpRenderTree/DerivedSources-input.xcfilelist:
25         * DumpRenderTree/DerivedSources-output.xcfilelist:
26
27 2019-04-09  Zalan Bujtas  <zalan@apple.com>
28
29         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
30         https://bugs.webkit.org/show_bug.cgi?id=196743
31         <rdar://problem/43897551>
32
33         Reviewed by Tim Horton.
34
35         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
36         (TEST):
37
38 2019-04-09  Youenn Fablet  <youenn@apple.com>
39
40         Close service worker database on network process suspension
41         https://bugs.webkit.org/show_bug.cgi?id=196623
42         <rdar://problem/48930869>
43
44         Reviewed by Alex Christensen.
45
46         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
47
48 2019-04-09  Daniel Bates  <dabates@apple.com>
49
50         [iPad] Should open popover when the spacebar is pressed
51         https://bugs.webkit.org/show_bug.cgi?id=196360
52         <rdar://problem/49389129>
53
54         Reviewed by Brent Fulgham.
55
56         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
57
58         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
59         (WTR::UIScriptController::isShowingPopover const): Added.
60         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
61         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
62         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
63         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
64         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
65         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
66         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
67         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
68         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
69         (WTR::UIScriptController::isShowingPopover const): Added.
70         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
71         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
72         * TestRunnerShared/UIScriptContext/UIScriptController.h:
73         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
74         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
75         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
76         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
77         (-[TestRunnerWKWebView _willPresentPopover]): Added.
78         (-[TestRunnerWKWebView _didDismissPopover]): Added.
79         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
80         (WTR::UIScriptController::isShowingPopover const): Added.
81         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
82         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
83
84 2019-04-09  Alex Christensen  <achristensen@webkit.org>
85
86         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
87         https://bugs.webkit.org/show_bug.cgi?id=196665
88         <rdar://45115669>
89
90         Reviewed by Geoff Garen.
91
92         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
93         (goBack):
94         (+[SimpleLookupContext sharedLookupContext]):
95         (-[SimpleLookupContext lookUpURL:completionHandler:]):
96         (TEST):
97         (+[Simple3LookupContext sharedLookupContext]): Deleted.
98         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
99
100 2019-04-09  John Wilander  <wilander@apple.com>
101
102         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
103         https://bugs.webkit.org/show_bug.cgi?id=196558
104         <rdar://problem/47650245>
105
106         Reviewed by Youenn Fablet.
107
108         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
109         (TestWebKitAPI::TEST):
110             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
111
112 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
113
114         [CMake] Apple builds should use ICU_INCLUDE_DIRS
115         https://bugs.webkit.org/show_bug.cgi?id=196720
116
117         Reviewed by Konstantin Tokarev.
118
119         * TestWebKitAPI/PlatformMac.cmake:
120
121 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
122
123         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
124         https://bugs.webkit.org/show_bug.cgi?id=196694
125         <rdar://problem/48388734>
126
127         Rubber-stamped by Aakash Jain.
128
129         * Scripts/webkitpy/port/image_diff.py:
130         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
131         * Scripts/webkitpy/port/server_process.py:
132         (ServerProcess.has_available_stdout): Check if stdout has data in it.
133         (ServerProcess._wait_for_data_and_update_buffers_using_select):
134         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
135         * Scripts/webkitpy/port/server_process_mock.py:
136         (MockServerProcess.has_available_stdout):
137         * Scripts/webkitpy/port/server_process_unittest.py:
138         (TestServerProcess.serial_test_basic):
139
140 2019-04-09  Jer Noble  <jer.noble@apple.com>
141
142         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
143         https://bugs.webkit.org/show_bug.cgi?id=196097
144
145         Reviewed by Eric Carlson.
146
147         Drive-by bug fix: allow tests to play audio without a user gesture by default.
148
149         * DumpRenderTree/mac/DumpRenderTree.mm:
150         (resetWebPreferencesToConsistentValues):
151         * WebKitTestRunner/TestController.cpp:
152         (WTR::TestController::resetPreferencesToConsistentValues):
153
154 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
155
156         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
157         https://bugs.webkit.org/show_bug.cgi?id=196690
158
159         Reviewed by Michael Catanzaro.
160
161         * QueueStatusServer/config/queues.py:
162         * Scripts/webkitpy/common/config/ews.json:
163         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
164         (test_ews_name):
165
166 2019-04-09  Chris Dumez  <cdumez@apple.com>
167
168         Loads using loadHTMLString() cause flashing when process-swapping
169         https://bugs.webkit.org/show_bug.cgi?id=196714
170         <rdar://problem/49637354>
171
172         Reviewed by Antti Koivisto.
173
174         Add API test coverage.
175
176         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
177
178 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
179
180         Unreviewed. Fix ATK accessibility tests after r244059.
181
182         We are failing to load the injected bundle due to undefined symbol
183         AccessibilityUIElement::replaceTextInRange().
184
185         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
186         (WTR::AccessibilityUIElement::replaceTextInRange):
187
188 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
189
190         AX: Support API: accessibilityReplaceRange:withText
191         https://bugs.webkit.org/show_bug.cgi?id=196636
192
193         Unreviewed build fix for Windows port.
194
195         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
196         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
197
198 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
199
200         [CMake][WinCairo] Separate copied headers into different directories
201         https://bugs.webkit.org/show_bug.cgi?id=196655
202
203         Reviewed by Michael Catanzaro.
204
205         * DumpRenderTree/CMakeLists.txt:
206         * MiniBrowser/win/CMakeLists.txt:
207         * TestWebKitAPI/CMakeLists.txt:
208         * TestWebKitAPI/PlatformWin.cmake:
209
210 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
211
212         Log stack-trace for run-webkit-tests when interrupted
213         https://bugs.webkit.org/show_bug.cgi?id=176393
214         <rdar://problem/34262310>
215
216         Reviewed by Lucas Forschler.
217
218         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
219         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
220         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
221         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
222         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
223         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
224         (main): Set handlers to log stack trace on interruption.
225
226 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
227
228         AX: Support API: accessibilityReplaceRange:withText
229         https://bugs.webkit.org/show_bug.cgi?id=196636
230
231         Unreviewed build fix for Windows port.
232
233         * DumpRenderTree/AccessibilityUIElement.cpp:
234         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
235
236 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
237
238         [ews-build] Scripts using Buildbot API have CORS error
239         https://bugs.webkit.org/show_bug.cgi?id=196709
240
241         Reviewed by Alexey Proskuryakov.
242
243         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
244
245 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
246
247         AX: Support API: accessibilityReplaceRange:withText
248         https://bugs.webkit.org/show_bug.cgi?id=196636
249
250         Reviewed by Daniel Bates.
251
252         * DumpRenderTree/AccessibilityUIElement.cpp:
253         (replaceTextInRangeCallback):
254         (AccessibilityUIElement::replaceTextInRange):
255         (AccessibilityUIElement::getJSClass):
256         * DumpRenderTree/AccessibilityUIElement.h:
257         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
258         (AccessibilityUIElement::replaceTextInRange):
259         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
260         (AccessibilityUIElement::replaceTextInRange):
261         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
262         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
263         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
264         (WTR::AccessibilityUIElement::replaceTextInRange):
265         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
266         (WTR::AccessibilityUIElement::replaceTextInRange):
267
268 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
269
270         [iOS] Do not allow starting selection drags when selection views are not visible
271         https://bugs.webkit.org/show_bug.cgi?id=196686
272         <rdar://problem/49399192>
273
274         Reviewed by Tim Horton.
275
276         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
277         also add some new API tests to cover scenarios where the web view is not first responder.
278
279         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
280         (TestWebKitAPI::TEST):
281         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
282
283         Add a switch to optionally make the web view first responder when starting the simulated drag.
284
285         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
286         (-[DragAndDropSimulator initWithWebView:]):
287         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
288
289 2019-04-08  Justin Fan  <justin_fan@apple.com>
290
291         [Web GPU] Fix Web GPU experimental feature on iOS
292         https://bugs.webkit.org/show_bug.cgi?id=196632
293
294         Reviewed by Myles C. Maxfield.
295
296         Properly make Web GPU available on iOS 11+.
297
298         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
299
300 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
301
302         [ews-build] Do not upload archive when Compile Fails
303         https://bugs.webkit.org/show_bug.cgi?id=196674
304
305         Reviewed by Alexey Proskuryakov.
306
307         * BuildSlaveSupport/ews-build/factories.py:
308         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
309         * BuildSlaveSupport/ews-build/steps.py:
310         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
311         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
312         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
313
314 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
315
316         Enable DFG on MIPS
317         https://bugs.webkit.org/show_bug.cgi?id=196689
318
319         Reviewed by Žan Doberšek.
320
321         Since the bytecode change, we enabled the baseline JIT on mips in
322         r240432, but DFG is still missing. With this change, all tests are
323         passing on a ci20 board.
324
325         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
326
327 2019-04-08  Philippe Normand  <pnormand@igalia.com>
328
329         [Flatpak] Second run update-webkitwpe-flatpak fails
330         https://bugs.webkit.org/show_bug.cgi?id=192702
331
332         Reviewed by Carlos Garcia Campos.
333
334         * flatpak/flatpakutils.py:
335         (FlatpakObject.flatpak): Fix typo.
336         (FlatpakPackage.install): When installing, also update to the configured remote commit.
337         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
338
339 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
340
341         [GTK][WPE] outlook.live.com displays old-fashioned UI
342         https://bugs.webkit.org/show_bug.cgi?id=196642
343
344         Reviewed by Carlos Garcia Campos.
345
346         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
347         (TestWebKitAPI::TEST): New Mac platform quirk test.
348
349 2019-04-07  Commit Queue  <commit-queue@webkit.org>
350
351         Unreviewed, rolling out r243956.
352         https://bugs.webkit.org/show_bug.cgi?id=196688
353
354         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
355         by aakashjain on #webkit).
356
357         Reverted changeset:
358
359         "Clicking "Go Back" from a safe browsing warning from an
360         iframe should navigate the WKWebView back to the previous
361         page"
362         https://bugs.webkit.org/show_bug.cgi?id=196665
363         https://trac.webkit.org/changeset/243956
364
365 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
366
367         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
368         https://bugs.webkit.org/show_bug.cgi?id=196669
369
370         Reviewed by Geoffrey Garen.
371
372         Added three new unit tests for WeakHashSet.
373
374         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
375         (WTF_WeakPtr.WeakHashSetConstObjects):
376         (WTF_WeakPtr.WeakHashSetComputesEmpty):
377         (WTF_WeakPtr.WeakHashSetComputeSize):
378
379 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
380
381         Hide next and previous form control buttons when WKWebView is editable
382         https://bugs.webkit.org/show_bug.cgi?id=196672
383         <rdar://problem/35625321>
384
385         Reviewed by Tim Horton.
386
387         Add a new API test.
388
389         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
390         (-[TestWKWebView lastTrailingBarButtonGroup]):
391         (TestWebKitAPI::TEST):
392         * TestWebKitAPI/ios/UIKitSPI.h:
393
394 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
395
396         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
397         https://bugs.webkit.org/show_bug.cgi?id=196077
398         <rdar://problem/49108202>
399
400         Reviewed by Chris Dumez.
401
402         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
403         on new web view.
404
405         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
406
407 2019-04-05  Saam Barati  <sbarati@apple.com>
408
409         Make compare-results understand MotionMark
410         https://bugs.webkit.org/show_bug.cgi?id=196666
411
412         Reviewed by Yusuke Suzuki.
413
414         * Scripts/compare-results:
415         (PLT5Results):
416         (detectMotionMark):
417         (detectMotionMark1_1):
418         (motionMarkResults):
419         (motionMark1_1Results):
420         (detectBenchmark):
421         (biggerIsBetter):
422         (main):
423
424 2019-04-05  Alex Christensen  <achristensen@webkit.org>
425
426         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
427         https://bugs.webkit.org/show_bug.cgi?id=196665
428         <rdar://45115669>
429
430         Reviewed by Geoff Garen.
431
432         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
433         (goBack):
434         (+[SimpleLookupContext sharedLookupContext]):
435         (-[SimpleLookupContext lookUpURL:completionHandler:]):
436         (TEST):
437         (+[Simple3LookupContext sharedLookupContext]): Deleted.
438         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
439
440 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
441
442         [ews-build] Add configuration and architecture for windows builders
443         https://bugs.webkit.org/show_bug.cgi?id=196660
444
445         Reviewed by Lucas Forschler.
446
447         * BuildSlaveSupport/ews-build/config.json:
448
449 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
450
451         webkitpy: Don't run subsequent rounds if interrupted
452         https://bugs.webkit.org/show_bug.cgi?id=196646
453
454         Reviewed by Aakash Jain.
455
456         * Scripts/webkitpy/layout_tests/controllers/manager.py:
457         (Manager.run): Bail out if interrupted.
458
459 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
460
461         Test sessionStorage in PSON private browsing mode
462         https://bugs.webkit.org/show_bug.cgi?id=196561
463
464         Reviewed by Alex Christensen.
465
466         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
467
468 2019-04-05  Commit Queue  <commit-queue@webkit.org>
469
470         Unreviewed, rolling out r243833.
471         https://bugs.webkit.org/show_bug.cgi?id=196645
472
473         This change breaks build of WPE and GTK ports (Requested by
474         annulen on #webkit).
475
476         Reverted changeset:
477
478         "[CMake][WTF] Mirror XCode header directories"
479         https://bugs.webkit.org/show_bug.cgi?id=191662
480         https://trac.webkit.org/changeset/243833
481
482 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
483
484         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
485         https://bugs.webkit.org/show_bug.cgi?id=196635
486
487         Reviewed by Antti Koivisto.
488         
489         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
490         for a test to enable async frame scrolling via:
491             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
492         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
493         
494         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
495
496         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
497         (WTR::InjectedBundle::beginTesting):
498         * WebKitTestRunner/TestController.cpp:
499         (WTR::TestController::resetPreferencesToConsistentValues):
500
501 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
502
503         Use a correct LC_RPATH when building with ASan
504         https://bugs.webkit.org/show_bug.cgi?id=196576
505
506         Reviewed by David Kilzer.
507
508         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
509         so that ../Frameworks is checked. This is simpler and more reliable than updating
510         each SPC service xcconfig.
511
512 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
513
514         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
515         https://bugs.webkit.org/show_bug.cgi?id=196629
516
517         Reviewed by Lucas Forschler.
518
519         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
520
521 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
522
523         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
524         https://bugs.webkit.org/show_bug.cgi?id=196618
525
526         Reviewed by Lucas Forschler.
527
528         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
529         (StatusBubble): Added QUEUE_TRIGGERS.
530         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
531         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
532         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
533         its parent(builder).
534
535 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
536
537         [ews-app] Status-bubble steps are sometimes displayed in reverse order
538         https://bugs.webkit.org/show_bug.cgi?id=196625
539
540         Reviewed by Lucas Forschler.
541
542         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
543         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
544
545 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
546
547         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
548         https://bugs.webkit.org/show_bug.cgi?id=196630
549
550         Reviewed by Wenson Hsieh.
551
552         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
553
554 2019-04-04  Youenn Fablet  <youenn@apple.com>
555
556         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
557         https://bugs.webkit.org/show_bug.cgi?id=196543
558
559         Reviewed by Alex Christensen.
560
561         * WebKitTestRunner/TestController.cpp:
562         (WTR::TestController::generatePageConfiguration):
563
564 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
565
566         [ews-app] Status bubble should not display skipped buildbot steps
567         https://bugs.webkit.org/show_bug.cgi?id=196584
568
569         Reviewed by Lucas Forschler.
570
571         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
572
573 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
574
575         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
576         https://bugs.webkit.org/show_bug.cgi?id=196620
577
578         Reviewed by Lucas Forschler.
579
580         * BuildSlaveSupport/ews-app/ews/config.py:
581
582 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
583
584         [Win] DumpRenderTreeWatchDog.py is not checked into source
585         https://bugs.webkit.org/show_bug.cgi?id=196567
586         <rdar://problem/49525901>
587
588         Reviewed by Lucas Forschler.
589
590         This script is used on Win EWS bots to terminate hanging DRT processes.
591
592         * EWSTools/dumprendertreewatchdog.py: Added.
593
594 2019-04-04  Chris Dumez  <cdumez@apple.com>
595
596         Unreviewed, roll out r243858 which made tests time out.
597
598         Disable new API tests on Windows instead.
599
600         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
601         (TestWebKitAPI::TEST):
602
603 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
604
605         [ATK] Cleanup WebPageAccessibilityObjectAtk
606         https://bugs.webkit.org/show_bug.cgi?id=196537
607
608         Reviewed by Michael Catanzaro.
609
610         Also consider files under atk directories as exceptions for GObject conventions.
611
612         * Scripts/webkitpy/style/checkers/cpp.py:
613         (check_identifier_name_in_declaration):
614
615 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
616
617         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
618         https://bugs.webkit.org/show_bug.cgi?id=196588
619         <rdar://problem/49365787>
620
621         Unreviewed build fix for Windows port.
622
623         error C3861: 'kill': identifier not found
624
625         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
626         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
627
628 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
629
630         [ews-build] Cancel build and similar operations should have authentication
631         https://bugs.webkit.org/show_bug.cgi?id=196520
632
633         Reviewed by Dewei Zhu.
634
635         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
636         environment variables.
637
638 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
639
640         [ews-build] Do not trigger queues which are not in production yet
641         https://bugs.webkit.org/show_bug.cgi?id=196581
642
643         Reviewed by Dewei Zhu.
644
645         * BuildSlaveSupport/ews-build/config.json:
646
647 2019-04-03  Chris Dumez  <cdumez@apple.com>
648
649         Unreviewed, fix typo in the name of API test added in r243848.
650
651         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
652         (TestWebKitAPI::TEST):
653
654 2019-04-03  Chris Dumez  <cdumez@apple.com>
655
656         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
657         https://bugs.webkit.org/show_bug.cgi?id=196588
658         <rdar://problem/49365787>
659
660         Reviewed by Ryosuke Niwa.
661
662         Add API test coverage.
663
664         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
665         (TestWebKitAPI::nullJavaScriptCallback):
666         (TestWebKitAPI::didCrashCheckFrames):
667         (TestWebKitAPI::TEST):
668
669 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
670
671         run-webkit-tests: Upload test results (new results database)
672         https://bugs.webkit.org/show_bug.cgi?id=196577
673         <rdar://problem/34841155>
674
675         Reviewed by Lucas Forschler.
676
677         * Scripts/webkitpy/layout_tests/controllers/manager.py:
678         (Manager.run): Upload results after each device shard, since the configuration will be
679         different for each device.
680         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
681         uploaded to a results database.
682         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
683         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
684
685 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
686
687         -apple-trailing-word is needed for browser detection
688         https://bugs.webkit.org/show_bug.cgi?id=196575
689
690         Unreviewed.
691
692         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
693
694 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
695
696         [CMake][WTF] Mirror XCode header directories
697         https://bugs.webkit.org/show_bug.cgi?id=191662
698
699         Reviewed by Konstantin Tokarev.
700
701         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
702         builds.
703
704         * CMakeLists.txt:
705         * DumpRenderTree/CMakeLists.txt:
706         * DumpRenderTree/PlatformWin.cmake:
707         * MiniBrowser/win/CMakeLists.txt:
708         * TestWebKitAPI/CMakeLists.txt:
709         * TestWebKitAPI/PlatformWin.cmake:
710         * WebKitTestRunner/PlatformGTK.cmake:
711         * WebKitTestRunner/PlatformWin.cmake:
712
713 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
714
715         [ews-app] Status bubble should not display certain infrastructure status messages
716         https://bugs.webkit.org/show_bug.cgi?id=196550
717
718         Reviewed by Lucas Forschler.
719
720         Do not display the steps which are un-needed for end-user. This information is still avaiable
721         if the user click on the bubble and look at the Buildbot build.
722         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
723         (StatusBubble._steps_messages):
724         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
725
726 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
727
728         [ews-build] Use https for sending data to ews-app
729         https://bugs.webkit.org/show_bug.cgi?id=196492
730
731         Reviewed by Lucas Forschler.
732
733         * BuildSlaveSupport/ews-build/events.py:
734
735 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
736
737         Remove support for -apple-trailing-word
738         https://bugs.webkit.org/show_bug.cgi?id=196525
739
740         Reviewed by Zalan Bujtas.
741
742         This CSS property is nonstandard and not used.
743
744         * Scripts/webkitperl/FeatureList.pm:
745         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
746
747 2019-04-03  Youenn Fablet  <youenn@apple.com>
748
749         Add a test for DOMCache on multiple browsing in case of private browsing
750         https://bugs.webkit.org/show_bug.cgi?id=196524
751
752         Reviewed by Alex Christensen.
753
754         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
755         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
756
757 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
758
759         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
760         https://bugs.webkit.org/show_bug.cgi?id=196540
761
762         Reviewed by Aakash Jain.
763
764         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
765
766 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
767
768         Add plumbing for a compatibility mode preference in WebKit
769         https://bugs.webkit.org/show_bug.cgi?id=196005
770
771         Reviewed by Tim Horton.
772
773         Add new API tests.
774
775         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
776         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
777
778 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
779
780         [WPE][GTK] Update libsrtp dependency package for Debian
781         https://bugs.webkit.org/show_bug.cgi?id=196528
782
783         Reviewed by Frédéric Wang.
784
785         * gtk/install-dependencies:
786         * wpe/install-dependencies:
787
788 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
789
790         [WK2] Add support for Window's beforeprint / afterprint events
791         https://bugs.webkit.org/show_bug.cgi?id=196478
792         <rdar://problem/49535124>
793
794         Unreviewed build fix for MSVC.
795
796         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
797
798         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
799
800         * WebKitTestRunner/TestController.cpp:
801         (WTR::printFrame): Use int and float literals.
802
803 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
804
805         [ews-build] Reassign bots to queues
806
807         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
808
809 2019-04-02  Chris Dumez  <cdumez@apple.com>
810
811         [WK2] Add support for Window's beforeprint / afterprint events
812         https://bugs.webkit.org/show_bug.cgi?id=196478
813
814         Reviewed by Alex Christensen.
815
816         Add minimal implementation for printFrame in WebKitTestRunner.
817
818         * WebKitTestRunner/TestController.cpp:
819         (WTR::printFrame):
820         (WTR::TestController::createOtherPage):
821         (WTR::TestController::createWebViewWithOptions):
822
823 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
824
825         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
826         https://bugs.webkit.org/show_bug.cgi?id=196491
827
828         Reviewed by Lucas Forschler.
829
830         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
831
832 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
833
834         [ews-build] Configure buildbot try credentials in environment variables
835         https://bugs.webkit.org/show_bug.cgi?id=196501
836
837         Reviewed by Lucas Forschler.
838
839         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
840         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
841         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
842
843 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
844
845         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
846         https://bugs.webkit.org/show_bug.cgi?id=196496
847         <rdar://problem/49521634>
848
849         Reviewed by Chris Dumez.
850
851         Add new API tests (see WebKit ChangeLog for more detail).
852
853         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
854         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
855         (TEST):
856
857 2019-04-02  David Kilzer  <ddkilzer@apple.com>
858
859         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
860         <https://webkit.org/b/196499>
861
862         Reviewed by Alexey Proskuryakov.
863
864         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
865         ENABLE_ADDRESS_SANITIZER.
866
867 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
868
869         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
870         https://bugs.webkit.org/show_bug.cgi?id=182757
871
872         Reviewed by Don Olmstead.
873
874         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
875         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
876
877 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
878
879         run-api-tests: Upload test results
880         https://bugs.webkit.org/show_bug.cgi?id=196323
881         <rdar://problem/49356714>
882
883         Reviewed by Lucas Forschler.
884
885         * Scripts/webkitpy/api_tests/manager.py:
886         (Manager):
887         (Manager.run): Upload results to a results database.
888         * Scripts/webkitpy/api_tests/run_api_tests.py:
889         (parse_args): Add upload arguments.
890         * Scripts/webkitpy/port/base.py:
891         (Port):
892         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
893         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
894         with commits from any other associated repositories.
895         * Scripts/webkitpy/port/device.py:
896         (Device):
897         (Device.build_version): Access build_versoin of underlying platform device.
898         * Scripts/webkitpy/port/ios_simulator_unittest.py:
899         (IOSSimulatorTest):
900         (IOSSimulatorTest.test_configuration_for_upload):
901         * Scripts/webkitpy/port/device_port.py:
902         (DevicePort):
903         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
904         the same as the machine uploading results.
905         * Scripts/webkitpy/port/mac.py:
906         (MacPort):
907         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
908         * Scripts/webkitpy/port/mac_unittest.py:
909         (MacTest):
910         (MacTest.test_configuration_for_upload):
911         * Scripts/webkitpy/xcode/simulated_device.py:
912         (SimulatedDeviceManager._create_device_with_runtime):
913         (SimulatedDevice.__init__): Create simulated device with a build_version.
914         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
915         (test_existing_simulator):
916
917 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
918
919         Remove extra newline characters (Follow-up fix to r243707)
920
921         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
922
923 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
924
925         [ews-app] Use API_KEY to accept results data
926         https://bugs.webkit.org/show_bug.cgi?id=196461
927
928         Reviewed by Dewei Zhu.
929
930         * BuildSlaveSupport/ews-app/ews/views/results.py:
931         (Results.post): Validate EWS_API_KEY before accepting any data.
932         * BuildSlaveSupport/ews-build/events.py:
933         (Events.sendData): Send EWS_API_KEY if available along with event data.
934
935 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
936
937         Unable to copy and paste a PDF from Notes into Mail compose body
938         https://bugs.webkit.org/show_bug.cgi?id=196442
939         <rdar://problem/48573098>
940
941         Reviewed by Tim Horton.
942
943         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
944         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
945         to be specified on the item providers.
946
947         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
948         (TestWebKitAPI::mapItemForTesting):
949         (TestWebKitAPI::contactItemForTesting):
950
951 2019-04-01  Tim Horton  <timothy_horton@apple.com>
952
953         Make UIWKDocumentContext rects per-character instead of per-word
954         https://bugs.webkit.org/show_bug.cgi?id=196459
955
956         Reviewed by Wenson Hsieh.
957
958         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
959         (TEST):
960         Adjust test results due to switching to per-character rects.
961
962 2019-04-01  Chris Dumez  <cdumez@apple.com>
963
964         UIProcess crash when a prewarmed process is terminated
965         https://bugs.webkit.org/show_bug.cgi?id=196451
966         <rdar://problem/49245471>
967
968         Reviewed by Geoffrey Garen.
969
970         Add API test coverage.
971
972         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
973         (TEST):
974
975 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
976
977         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
978         https://bugs.webkit.org/show_bug.cgi?id=196449
979
980         Reviewed by Lucas Forschler.
981
982         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
983         (StatusBubble.get_os_details): Method to get OS and Xcode details.
984         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
985         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
986
987 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
988
989         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
990         https://bugs.webkit.org/show_bug.cgi?id=196444
991
992         Reviewed by Lucas Forschler.
993
994         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
995
996 2019-04-01  Alex Christensen  <achristensen@webkit.org>
997
998         Add SPI to canonicalize NSURLs with WTF::URL
999         https://bugs.webkit.org/show_bug.cgi?id=196415
1000         <rdar://problem/44980271>
1001
1002         Reviewed by Darin Adler.
1003
1004         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1005         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1006         (TestWebKitAPI::TEST):
1007
1008 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1009
1010         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1011         https://bugs.webkit.org/show_bug.cgi?id=196441
1012
1013         Reviewed by Carlos Garcia Campos.
1014
1015         Don't cache the wpe_view_backend object that might not exist yet at the
1016         time of EventSenderProxy constructor invocation, but instead retrieve
1017         that object whenever it's required for event dispatching. This should
1018         avoid crashes in this constructor now that it's invoked before any
1019         PlatformWindow has been set up (as changed in r243496).
1020
1021         * WebKitTestRunner/EventSenderProxy.h:
1022         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1023         (WTR::viewBackend):
1024         (WTR::EventSenderProxy::EventSenderProxy):
1025         (WTR::EventSenderProxy::mouseDown):
1026         (WTR::EventSenderProxy::mouseUp):
1027         (WTR::EventSenderProxy::mouseMoveTo):
1028         (WTR::EventSenderProxy::mouseScrollBy):
1029         (WTR::EventSenderProxy::keyDown):
1030         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1031
1032 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1033
1034         [Win][WebKit] MiniBrowser should support high DPI display
1035         https://bugs.webkit.org/show_bug.cgi?id=196391
1036
1037         Reviewed by Alex Christensen.
1038
1039         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1040         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1041         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1042         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1043
1044 2019-03-31  Sam Weinig  <weinig@apple.com>
1045
1046         Remove more i386 specific configurations
1047         https://bugs.webkit.org/show_bug.cgi?id=196430
1048
1049         Reviewed by Alexey Proskuryakov.
1050
1051         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1052         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1053
1054 2019-03-31  Andy Estes  <aestes@apple.com>
1055
1056         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1057         https://bugs.webkit.org/show_bug.cgi?id=196433
1058         <rdar://problem/49293305>
1059
1060         Reviewed by Tim Horton.
1061
1062         Enhanced API test coverage to include all navigation response policy decisions in both
1063         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1064
1065         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1066         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1067         (TestWebKitAPI::TEST):
1068         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1069         (readFile):
1070         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1071         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1072         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1073         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1074         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1075         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1076         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1077         (-[QuickLookDelegate _downloadDidStart:]):
1078         (-[QuickLookDelegate _download:didReceiveResponse:]):
1079         (-[QuickLookDelegate _download:didReceiveData:]):
1080         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1081         (-[QuickLookDelegate _downloadDidFinish:]):
1082         (-[QuickLookDelegate _download:didFailWithError:]):
1083         (-[QuickLookDelegate _downloadDidCancel:]):
1084         (-[QuickLookDelegate verifyDownload]):
1085         (runTest):
1086         (runTestDecideBeforeLoading):
1087         (runTestDecideAfterLoading):
1088         (TEST):
1089         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1090         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1091         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1092         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1093         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1094         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1095         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1096         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1097         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1098         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1099         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1100         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1101         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1102         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1103
1104 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1105
1106         [CMake] add testdfg as target with build-jsc
1107         https://bugs.webkit.org/show_bug.cgi?id=196393
1108
1109         Reviewed by Saam Barati.
1110
1111         Added testdfg as one of the targets to build when
1112         using CMake.
1113
1114         * Scripts/build-jsc:
1115
1116 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1117
1118         Delete WebMetal implementation in favor of WebGPU
1119         https://bugs.webkit.org/show_bug.cgi?id=195418
1120
1121         Reviewed by Dean Jackson.
1122
1123         * DumpRenderTree/mac/DumpRenderTree.mm:
1124         (enableExperimentalFeatures):
1125         (resetWebPreferencesToConsistentValues):
1126         * Scripts/webkitperl/FeatureList.pm:
1127         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1129         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1130         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1131         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1132         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1133         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1134         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1135         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1136         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1137         (WTR::InjectedBundle::beginTesting):
1138         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1139         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1140         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1141
1142 2019-03-29  Chris Dumez  <cdumez@apple.com>
1143
1144         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1145         https://bugs.webkit.org/show_bug.cgi?id=196405
1146         <rdar://problem/49428130>
1147
1148         Reviewed by Wenson Hsieh.
1149
1150         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1151         the popover presentation methods to be no-ops. Use this in the new test added in
1152         r243523 so that we do not swizzle those methods for all tests. This is needed because
1153         those WatchOS tests rely on the popover getting presented and interactive.
1154
1155         * WebKitTestRunner/TestController.cpp:
1156         (WTR::updateTestOptionsFromTestHeader):
1157         * WebKitTestRunner/TestController.h:
1158         * WebKitTestRunner/TestOptions.h:
1159         (WTR::TestOptions::hasSameInitializationOptions const):
1160         * WebKitTestRunner/ios/TestControllerIOS.mm:
1161         (WTR::TestController::platformInitialize):
1162         (WTR::TestController::platformResetStateToConsistentValues):
1163
1164 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1165
1166         [Curl] Add Server Trust Evaluation Support.
1167         https://bugs.webkit.org/show_bug.cgi?id=191646
1168
1169         Reviewed by Fujii Hironori.
1170
1171         Implemented MiniBrowser UI for asking if user trusts the server.
1172
1173         * MiniBrowser/win/Common.cpp:
1174         (askServerTrustEvaluation):
1175         (replaceString):
1176         * MiniBrowser/win/Common.h:
1177         * MiniBrowser/win/MiniBrowserLib.rc:
1178         * MiniBrowser/win/MiniBrowserLibResource.h:
1179         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1180         (createPEMString):
1181         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1182         (WebKitBrowserWindow::canTrustServerCertificate):
1183         * MiniBrowser/win/WebKitBrowserWindow.h:
1184
1185 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1186
1187         Implement ResizeObserver.
1188         https://bugs.webkit.org/show_bug.cgi?id=157743
1189
1190         Reviewed by Simon Fraser.
1191
1192         Support resizeObserverEnabled webPreferences.
1193
1194         * DumpRenderTree/TestOptions.cpp:
1195         (TestOptions::TestOptions):
1196         * DumpRenderTree/TestOptions.h:
1197         * DumpRenderTree/mac/DumpRenderTree.mm:
1198         (setWebPreferencesForTestOptions):
1199         * DumpRenderTree/win/DumpRenderTree.cpp:
1200         (enableExperimentalFeatures):
1201         * Scripts/webkitperl/FeatureList.pm:
1202         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1203
1204 2019-03-28  John Wilander  <wilander@apple.com>
1205
1206         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1207         https://bugs.webkit.org/show_bug.cgi?id=196281
1208         <rdar://problem/48938748>
1209
1210         Reviewed by Alex Christensen.
1211
1212         This patch adds the function isStatisticsHasLocalStorage() to the
1213         TestRunner. With it, the page can query the WebsiteDataStore in the
1214         UI process to make sure that it sees LocalStorage.
1215
1216         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1217         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1218         (WTR::TestRunner::isStatisticsHasLocalStorage):
1219         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1220         * WebKitTestRunner/TestController.cpp:
1221         (WTR::TestController::isStatisticsHasLocalStorage):
1222         * WebKitTestRunner/TestController.h:
1223         * WebKitTestRunner/TestInvocation.cpp:
1224         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1225
1226 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1227
1228         API::Data::createWithoutCopying should do a null check before calling CFRelease
1229         https://bugs.webkit.org/show_bug.cgi?id=196276
1230         <rdar://problem/48059859>
1231
1232         Reviewed by Alex Christensen.
1233
1234         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1235
1236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1237         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1238         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1239         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1240         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1241         (TestWebKitAPI::TEST):
1242
1243 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1244
1245         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1246         https://bugs.webkit.org/show_bug.cgi?id=186276
1247
1248         Reviewed by Carlos Garcia Campos.
1249
1250         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1251         (webViewLoadChanged):
1252         (testWebResourceGetDataError):
1253         (testWebResourceGetDataEmpty):
1254         (beforeAll):
1255         (webViewloadChanged): Deleted.
1256
1257 2019-03-27  Andy Estes  <aestes@apple.com>
1258
1259         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1260         https://bugs.webkit.org/show_bug.cgi?id=196317
1261
1262         Reviewed by Dan Bernstein.
1263
1264         package-root copies built products into a staging directory using ditto(1), which does not
1265         follow symbolic links as it traverses a directory. Now that the files in
1266         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1267         itself, these become broken links when ditto'd into the staging directory.
1268
1269         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1270
1271         * Scripts/package-root:
1272
1273 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1274
1275         [ews-app] Update display text of Submit for ews analysis
1276         https://bugs.webkit.org/show_bug.cgi?id=196309
1277
1278         Reviewed by Dewei Zhu.
1279
1280         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1281
1282 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1283
1284         run-webkit-tests should check for leaks in WebKit processes
1285         <https://webkit.org/b/193772>
1286         <rdar://problem/46526680>
1287
1288         Reviewed by Ryosuke Niwa.
1289
1290         This works by doing the following:
1291         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1292           The list of child processes are returned one per line:
1293           process.name: pid
1294         - Run the "#LIST CHILD PROCESSES" command just before the
1295           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1296           processes on the ServerProcess object.
1297         - When the `--leaks` switch is handled, run check_for_leaks() on
1298           each child process after the main test harness.
1299
1300         * DumpRenderTree/mac/DumpRenderTree.mm:
1301         (handleControlCommand):
1302         - Use strncmp() instead of strcmp().
1303         - Add support for handling "#LIST CHILD PROCESSES" command.
1304
1305         * Scripts/webkitpy/port/base.py:
1306         (Port.check_for_leaks):
1307         * Scripts/webkitpy/port/darwin.py:
1308         (DarwinPort.check_for_leaks):
1309         - Rename redundant 'process_pid' argument to 'process_id'.
1310
1311         * Scripts/webkitpy/port/driver.py:
1312         (Driver.do_post_tests_work):
1313         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1314           longer the only command this sends to WebKitTestRunner.
1315         - If the `--leaks` switch is present, send the
1316           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1317           result using Port.set_webkit_processes().
1318         (Driver._parse_child_processes_output):
1319         - Add helper method to parse list of child process names and
1320           process IDs returned from WebKitTestRunner.
1321
1322         * Scripts/webkitpy/port/ios_device.py:
1323         (IOSDevicePort.check_for_leaks):
1324         - Rename redundant 'process_pid' argument to 'process_id'.
1325
1326         * Scripts/webkitpy/port/leakdetector.py:
1327         (LeakDetector._parse_leaks_output):
1328         - Return early if there is no leaks_output.
1329         (LeakDetector.check_for_leaks):
1330         - Rename redundant 'process_pid' argument to 'process_id'.
1331
1332         * Scripts/webkitpy/port/server_process.py:
1333         (ServerProcess.__init__):
1334         (ServerProcess.child_processes):
1335         (ServerProcess.set_child_processes):
1336         - Add instance variable to Port to store list of child process
1337           names and process IDs returned from WebKitTestRunner.
1338         (ServerProcess._start):
1339         - Clear self._child_processes.
1340         (ServerProcess.stop):
1341         - If self._child_processes is set, call
1342           self._port.check_for_leaks() for each child process.
1343
1344         * Scripts/webkitpy/port/server_process_unittest.py:
1345         (TrivialMockPort.check_for_leaks):
1346         - Rename redundant 'process_pid' argument to 'process_id'.
1347
1348         * Scripts/webkitpy/port/simulator_process.py:
1349         (SimulatorProcess.stop):
1350         - If self._child_processes is set, call
1351           self._port.check_for_leaks() for each child process.
1352
1353         * Scripts/webkitpy/port/watch_device.py:
1354         (WatchDevicePort.check_for_leaks):
1355         - Rename redundant 'process_pid' argument to 'process_id'.
1356
1357         * WebKitTestRunner/TestController.cpp:
1358         (WTR::TestController::dumpResponse):
1359         - Extract method from findAndDumpWorldLeaks() so that it may be
1360           reused by findAndDumpWebKitProcessIdentifiers().
1361         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1362         - Add method to output process name and process ID of both the
1363           WebContent and Networking processes.
1364         (WTR::TestController::findAndDumpWorldLeaks):
1365         - Fix missing newline in output when there were no abandoned
1366           documents.
1367         - Call dumpResponse() for extracted code.
1368         (WTR::TestController::handleControlCommand):
1369         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1370         - Use strncmp() instead of strcmp().
1371         - Call findAndDumpWebKitProcessIdentifiers() when
1372           "#LIST CHILD PROCESSES" command is sent.
1373         * WebKitTestRunner/TestController.h:
1374         (WTR::TestController::dumpResponse):
1375         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1376         - Declare methods.
1377
1378 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1379
1380         Unreviewed. Add GLib API test cases after r243434.
1381
1382         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1383         (testWebViewActiveURI):
1384         (serverCallback):
1385         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1386         (sendRequestCallback):
1387
1388 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1389
1390         Geolocation request not complete when watch request was started in a different web process
1391         https://bugs.webkit.org/show_bug.cgi?id=195996
1392
1393         Reviewed by Alex Christensen.
1394
1395         Add a test case.
1396
1397         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1398         (TestWebKitAPI::runJavaScriptAlert):
1399         (TestWebKitAPI::TEST):
1400
1401 2019-03-26  Keith Rollin  <krollin@apple.com>
1402
1403         Update the way generate-xcfilelists returns strings from functions
1404         https://bugs.webkit.org/show_bug.cgi?id=195975
1405         <rdar://problem/49040807>
1406
1407         Reviewed by Dean Jackson.
1408
1409         There are places where generate-xcfilelists executes assignments with
1410         statements like:
1411
1412             FOO=$(some_function)
1413
1414         where "some_function" return a string by echoing it. E.g.
1415
1416             some_function()
1417             {
1418                 echo "Hello, World"
1419             }
1420
1421         This is a common idiom, but it has a problem if "some_function" needs
1422         to call "exit" in an attempt to halt the entire script right then and
1423         there. Since "some_function" is called inside of $(), it's being
1424         executed in a sub-shell. Calling exit in that sub-shell simply exits
1425         that shell; it doesn't not exit the outer shell in which the main part
1426         of the script is still running. As such, the main script keeps
1427         executing when the intent was for the script to halt.
1428
1429         The solution to this is to use a different idiom for returning
1430         strings. The one we now is to pass in the name of the variable to
1431         receive the string result:
1432
1433             some_function()
1434             {
1435                 variable_name=$1
1436                 eval $variable_name ="Hello, World"
1437             }
1438
1439         The call site now looks like
1440
1441             some_function FOO
1442
1443         Because there's no invocation of a sub-shell, some_function can now
1444         call "exit" if it wants to, and the entire script will exit at that
1445         point.
1446
1447         * Scripts/generate-xcfilelists:
1448
1449 2019-03-26  Chris Dumez  <cdumez@apple.com>
1450
1451         Add basic layout test coverage for File Picker on iOS
1452         https://bugs.webkit.org/show_bug.cgi?id=196265
1453
1454         Reviewed by Wenson Hsieh.
1455
1456         Add layout test infrastructure to test the file picker on iOS.
1457
1458         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1459         (WTR::UIScriptController::dismissFilePicker):
1460         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1461         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1462         (WTR::UIScriptController::dismissFilePicker):
1463         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1464         * WebKitTestRunner/TestController.cpp:
1465         (WTR::TestController::createWebViewWithOptions):
1466         (WTR::updateTestOptionsFromTestHeader):
1467         * WebKitTestRunner/TestOptions.h:
1468         (WTR::TestOptions::hasSameInitializationOptions const):
1469         * WebKitTestRunner/ios/TestControllerIOS.mm:
1470         (overridePresentViewController):
1471         (WTR::TestController::platformInitialize):
1472         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1473         (WTR::UIScriptController::dismissFilePicker):
1474
1475 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1476
1477         Implement async paste method on UIWKInteractionViewProtocol
1478         https://bugs.webkit.org/show_bug.cgi?id=196267
1479         <rdar://problem/49236346>
1480
1481         Reviewed by Tim Horton.
1482
1483         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1484         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1485         are now a part of all iOS 12 internal SDKs.
1486
1487         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1488
1489         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1490         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1491
1492         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1493         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1494         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1495         * TestWebKitAPI/ios/UIKitSPI.h:
1496
1497 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1498
1499         [ews-build] Use PostgreSQL for ews.webkit.org database
1500         https://bugs.webkit.org/show_bug.cgi?id=196270
1501
1502         Reviewed by Lucas Forschler.
1503
1504         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1505
1506 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1507
1508         [ews] Reset simctl states on reboot
1509         https://bugs.webkit.org/show_bug.cgi?id=196260
1510
1511         Rubber-stamped by Aakash Jain.
1512
1513         * EWSTools/start-queue-mac.sh:
1514
1515 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1516
1517         [ews-build] Use PostgreSQL for ews-build database
1518         https://bugs.webkit.org/show_bug.cgi?id=196229
1519
1520         Reviewed by Lucas Forschler.
1521
1522         * BuildSlaveSupport/ews-build/master.cfg:
1523
1524 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1525
1526         [ews-build] Get master_hostname dynamically in master.cfg
1527         https://bugs.webkit.org/show_bug.cgi?id=196255
1528
1529         Reviewed by Lucas Forschler.
1530
1531         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1532         send events data in test mode.
1533
1534 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1535
1536         [ews-app] Set db_constraint to False for Foreign Keys
1537         https://bugs.webkit.org/show_bug.cgi?id=196252
1538
1539         Reviewed by Lucas Forschler.
1540
1541         * BuildSlaveSupport/ews-app/ews/models/build.py:
1542         * BuildSlaveSupport/ews-app/ews/models/step.py:
1543
1544 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1545
1546         [ews-build] is_test_mode_enabled should default to True
1547         https://bugs.webkit.org/show_bug.cgi?id=196248
1548
1549         Reviewed by Lucas Forschler.
1550
1551         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1552
1553 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1554
1555         [ews-app] Add webkitperl to ENABLED_QUEUES
1556         https://bugs.webkit.org/show_bug.cgi?id=196253
1557
1558         Reviewed by Lucas Forschler.
1559
1560         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1561
1562 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1563
1564         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1565         https://bugs.webkit.org/show_bug.cgi?id=196211
1566         rdar://problem/49110552
1567
1568         Reviewed by Tim Horton.
1569
1570         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1571         Make sure that EventSenderProxy always exists when running tests. We used to create
1572         it when resetting before the first test, which is a bit too late.
1573
1574         * WebKitTestRunner/TestController.h:
1575         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1576         (WTR::TestController::platformCreateWebView):
1577         (WTR::TestController::platformCreateOtherPage):
1578         (WTR::TestController::finishCreatingPlatformWebView):
1579         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1580         (WTR::PlatformWebView::PlatformWebView):
1581         Moved some code that made NSWindow use NSEvent during web view creation. We may
1582         need to move more if some other case us found, but this is enough for now.
1583
1584 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1585
1586         Unreviewed. Fix typo in GLib geolocation API after r243285.
1587
1588         gelocation -> geolocation.
1589
1590         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1591         (testGeolocationManagerWatchPosition):
1592
1593 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1594
1595         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1596         https://bugs.webkit.org/show_bug.cgi?id=196213
1597
1598         Reviewed by Geoff Garen.
1599
1600         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1601         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1602         (credentialWithIdentityAndKeychainPath):
1603         (-[ChallengeDelegate webView:didFinishNavigation:]):
1604         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1605         (TestWebKitAPI::TEST):
1606
1607 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1608
1609         Expected shouldn't assume its contained types are copyable
1610         https://bugs.webkit.org/show_bug.cgi?id=195986
1611
1612         Reviewed by JF Bastien.
1613
1614         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1615         (TestWebKitAPI::NonCopyable::operator== const):
1616         (TestWebKitAPI::NonCopyable::operator!= const):
1617         (TestWebKitAPI::TEST):
1618
1619 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1620
1621         Remove some now-unnecessary dynamic class lookup
1622         https://bugs.webkit.org/show_bug.cgi?id=196237
1623
1624         Reviewed by Simon Fraser.
1625
1626         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1627         (makeRequest):
1628         (TEST):
1629
1630 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1631
1632         Unreviewed, rolling out r243450.
1633
1634         AppleWin and WinCairo port builds get broken.
1635
1636         Reverted changeset:
1637
1638         "Add test for fix of #196095"
1639         https://bugs.webkit.org/show_bug.cgi?id=196097
1640         https://trac.webkit.org/changeset/243450
1641
1642 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1643
1644         Unreviewed, rolling out r243465.
1645         https://bugs.webkit.org/show_bug.cgi?id=196226
1646
1647         the test doesn't build (Requested by thorton on #webkit).
1648
1649         Reverted changeset:
1650
1651         "Do not terminate the NetworkProcess if a third party
1652         application sends a NSCredential with a SecIdentityRef"
1653         https://bugs.webkit.org/show_bug.cgi?id=196213
1654         https://trac.webkit.org/changeset/243465
1655
1656 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1657
1658         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1659         https://bugs.webkit.org/show_bug.cgi?id=196213
1660
1661         Reviewed by Geoff Garen.
1662
1663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1664         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1665         (credentialWithIdentityAndKeychainPath):
1666         (-[ChallengeDelegate webView:didFinishNavigation:]):
1667         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1668         (TestWebKitAPI::TEST):
1669
1670 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1671
1672         [ews-build] Gracefully handle missing patch_id in events
1673         https://bugs.webkit.org/show_bug.cgi?id=196216
1674
1675         Reviewed by Lucas Forschler.
1676
1677         * BuildSlaveSupport/ews-build/events.py:
1678
1679 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1680
1681         [ews-build] use lz4 compression for improving buildbot performance
1682         https://bugs.webkit.org/show_bug.cgi?id=196155
1683
1684         Reviewed by Lucas Forschler.
1685
1686         * BuildSlaveSupport/ews-build/master.cfg:
1687
1688 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1689
1690         Pull some API testing helper methods out of TestWKWebView
1691         https://bugs.webkit.org/show_bug.cgi?id=196212
1692
1693         Reviewed by Tim Horton.
1694
1695         Refactor some more API testing utility methods, so that they can be used in
1696         tests that do not use TestWKWebView.
1697
1698         * TestWebKitAPI/cocoa/TestWKWebView.h:
1699         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1700         (-[WKWebView loadTestPageNamed:]):
1701         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1702         (-[WKWebView synchronouslyLoadHTMLString:]):
1703         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1704         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1705         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1706         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1707         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1708
1709 2019-03-25  Jer Noble  <jer.noble@apple.com>
1710
1711         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1712         https://bugs.webkit.org/show_bug.cgi?id=196097
1713
1714         Reviewed by Eric Carlson.
1715
1716         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1717
1718         * DumpRenderTree/mac/DumpRenderTree.mm:
1719         (resetWebPreferencesToConsistentValues):
1720         * WebKitTestRunner/TestController.cpp:
1721         (WTR::TestController::resetPreferencesToConsistentValues):
1722
1723 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1724
1725         Pull IPadUserInterfaceSwizzler out into a separate header file
1726         https://bugs.webkit.org/show_bug.cgi?id=196193
1727
1728         Reviewed by Anders Carlsson.
1729
1730         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1731         be used in other API tests.
1732
1733         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1734         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1735         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1736         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1737         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1738         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1739         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1740
1741 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1742
1743         Remove NavigatorContentUtils in WebCore/Modules
1744         https://bugs.webkit.org/show_bug.cgi?id=196070
1745
1746         Reviewed by Alex Christensen.
1747
1748         NavigatorContentUtils was to support the custom scheme spec [1].
1749         However, in WebKit side, no port has supported the feature in
1750         WebKit layer after EFL port was removed. So there has been the
1751         only IDL implementation of the NavigatorContentUtils in WebCore.
1752         So we don't need to keep the implementation in WebCore anymore.
1753
1754         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1755
1756         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1757
1758 2019-03-24  Andy Estes  <aestes@apple.com>
1759
1760         [watchOS] Remove unused Proximity Networking code
1761         https://bugs.webkit.org/show_bug.cgi?id=196188
1762
1763         Reviewed by Tim Horton.
1764
1765         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1766         (TEST):
1767
1768 2019-03-23  Keith Miller  <keith_miller@apple.com>
1769
1770         Refactor clz/ctz and fix getLSBSet.
1771         https://bugs.webkit.org/show_bug.cgi?id=196162
1772
1773         Reviewed by Saam Barati.
1774
1775         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1776
1777         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1778         (TestWebKitAPI::TEST):
1779
1780 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1781
1782         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1783         https://bugs.webkit.org/show_bug.cgi?id=196143
1784
1785         Reviewed by Michael Catanzaro.
1786
1787         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1788         directories.
1789
1790         * Scripts/webkitpy/style/checkers/cpp.py:
1791         (check_identifier_name_in_declaration):
1792         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1793         (WebKitStyleTest.test_names):
1794
1795 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1796
1797         [Flatpak] Manifest expanding fails for qt WPE extension
1798         https://bugs.webkit.org/show_bug.cgi?id=196148
1799
1800         Reviewed by Alex Christensen.
1801
1802         * flatpak/flatpakutils.py:
1803         (expand_submodules_recurse): The last recurse manifest expand
1804         iteration might lead to a single module so take it into account
1805         and don't try to recurse further.
1806
1807 2019-03-22  Chris Dumez  <cdumez@apple.com>
1808
1809         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1810         https://bugs.webkit.org/show_bug.cgi?id=195348
1811         <rdar://problem/48622090>
1812
1813         Reviewed by Alex Christensen.
1814
1815         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1816         to NO when test.options().shouldIgnoreMetaViewport is false.
1817
1818         * WebKitTestRunner/ios/TestControllerIOS.mm:
1819         (WTR::TestController::platformConfigureViewForTest):
1820
1821 2019-03-22  Chris Dumez  <cdumez@apple.com>
1822
1823         Prewarmed processes should be usable with any website data store
1824         https://bugs.webkit.org/show_bug.cgi?id=196104
1825
1826         Reviewed by Alex Christensen.
1827
1828         Add API test coverage.
1829
1830         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1831         (runInitialWarmedProcessUsedTest):
1832         (TEST):
1833
1834 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1835
1836         Back out local changes to Alex's Subversion working directory
1837
1838         They were accidentally committed.
1839
1840         * Scripts/webkitpy/common/system/abstractexecutive.py:
1841         (AbstractExecutive.wait_newest):
1842         * Scripts/webkitpy/common/system/executive.py:
1843         (Executive.running_pids):
1844         * Scripts/webkitpy/common/system/executive_mock.py:
1845         (MockExecutive.running_pids):
1846         * Scripts/webkitpy/common/system/executive_unittest.py:
1847         (ExecutiveTest.serial_test_running_pids):
1848         * Scripts/webkitpy/port/darwin.py:
1849         (DarwinPort.check_for_leaks):
1850         * Scripts/webkitpy/port/leakdetector.py:
1851         (LeakDetector.check_for_leaks):
1852         - This was the hack attached to Bug 193772.
1853
1854         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1855         (+[WebKitTestRunnerEvent mouseLocation]):
1856         - This works around a crash on an internal build.
1857
1858 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1859
1860         Fix the build after r243354
1861         https://bugs.webkit.org/show_bug.cgi?id=196138
1862         <rdar://problem/49145951>
1863
1864         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1865         (TEST):
1866         * TestWebKitAPI/ios/UIKitSPI.h:
1867
1868 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1869
1870         Adopt UIWKDocumentContext
1871         https://bugs.webkit.org/show_bug.cgi?id=196040
1872         <rdar://problem/48642440>
1873
1874         Reviewed by Ryosuke Niwa.
1875
1876         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1877         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1878         (makeRequest):
1879         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1880         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1881         (applyStyle):
1882         (TEST):
1883         Add tests for UIWKDocumentContext.
1884
1885         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1886         (TEST):
1887         (recursiveFindWKContentView): Deleted.
1888         * TestWebKitAPI/cocoa/TestWKWebView.h:
1889         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1890         (recursiveFindWKContentView):
1891         (-[TestWKWebView wkContentView]):
1892         * TestWebKitAPI/ios/UIKitSPI.h:
1893         Share the WKContentView finding code between tests.
1894
1895 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1896
1897         [iOS WK2] Turn on async overflow scrolling by default
1898         https://bugs.webkit.org/show_bug.cgi?id=196011
1899         rdar://problem/48453859
1900
1901         Reviewed by Antti Koivisto.
1902         
1903         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1904         since so many basic layout tests have different results when compositing is triggered for
1905         overflow.
1906         
1907         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1908
1909         * WebKitTestRunner/TestController.cpp:
1910         (WTR::TestController::resetPreferencesToConsistentValues):
1911
1912 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1913
1914         [ews-build] Retry API test in case of failures
1915         https://bugs.webkit.org/show_bug.cgi?id=196004
1916
1917         Reviewed by Lucas Forschler.
1918
1919         * BuildSlaveSupport/ews-build/steps.py:
1920         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1921         (CompileWebKitToT.doStepIf): Ditto.
1922         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1923         (ReRunAPITests): Re-run API tests.
1924         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1925         (RunAPITestsWithoutPatch): Run API tests without patch.
1926         (RunAPITestsWithoutPatch.doStepIf):
1927         (RunAPITestsWithoutPatch.hideStepIf):
1928         (RunAPITestsWithoutPatch.evaluateCommand):
1929         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1930         (AnalyzeAPITestsResults.start):
1931         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1932         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1933         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1934         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1935
1936 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1937
1938         [ews-build] Update queues configurations
1939         https://bugs.webkit.org/show_bug.cgi?id=196074
1940
1941         Reviewed by Dewei Zhu.
1942
1943         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1944         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1945
1946 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1947
1948         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1949         https://bugs.webkit.org/show_bug.cgi?id=195680
1950         <rdar://problem/48903534>
1951
1952         Unreviewed infrastructure fix.
1953
1954         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1955         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1956
1957 2019-03-21  Andy Estes  <aestes@apple.com>
1958
1959         [iOS] Apple Pay should be available in documents with no user agent scripts
1960         https://bugs.webkit.org/show_bug.cgi?id=196061
1961         <rdar://problem/48649391>
1962
1963         Reviewed by Brady Eidson.
1964
1965         Added API tests and related infrastructure.
1966
1967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1968         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1969         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1970         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1971         (TestWebKitAPI::TEST):
1972         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1973         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1974         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1975         * TestWebKitAPI/cocoa/TestProtocol.mm:
1976         (-[TestProtocol startLoading]):
1977         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1978         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1979         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1980         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1981
1982 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1983
1984         REGRESSSION (r243297): webkitpy tests broken
1985         https://bugs.webkit.org/show_bug.cgi?id=196108
1986
1987         Reviewed by Aakash Jain.
1988
1989         r243297 updated contributors.json, which broke a few unit tests.
1990
1991         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1992         (IRCCommandTest.test_whois):
1993         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1994
1995 2019-03-21  Chris Dumez  <cdumez@apple.com>
1996
1997         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1998         https://bugs.webkit.org/show_bug.cgi?id=196041
1999         <rdar://problem/49083230>
2000
2001         Reviewed by Alex Christensen.
2002
2003         Add API test coverage.
2004
2005         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2006         (TEST):
2007
2008 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2009
2010         Add SPI to inform applications of WKContentRuleList actions
2011         https://bugs.webkit.org/show_bug.cgi?id=195965
2012         <rdar://problem/42664365>
2013
2014         Reviewed by Geoff Garen.
2015
2016         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2017         (TestWebKitAPI::allActionsForResourceLoad):
2018         (TestWebKitAPI::testRequest):
2019         (TestWebKitAPI::TEST_F):
2020         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2021         (Notification::description):
2022         (Notification::operator== const):
2023         (toVector):
2024         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2025         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2026         (makeContentRuleList):
2027         (TEST):
2028         (makeWarnContentRuleList): Deleted.
2029
2030 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2031
2032         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2033         https://bugs.webkit.org/show_bug.cgi?id=196088
2034
2035         Reviewed by Brian Burg.
2036
2037         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2038         Support checks when only one platform is specified. Also deprecate macosx() and
2039         force the use of macos() instead.
2040
2041         * Scripts/webkitpy/style/checkers/cpp.py:
2042         (check_min_versions_of_wk_api_available):
2043         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2044         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2045
2046 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2047
2048         Update status inactive committers' status to 'contributor'.
2049
2050         * Scripts/webkitpy/common/config/contributors.json:
2051
2052 2019-03-21  Xan Lopez  <xan@igalia.com>
2053
2054         [JSC][x86] Drop support for x87 floating point
2055         https://bugs.webkit.org/show_bug.cgi?id=194853
2056
2057         Reviewed by Don Olmstead.
2058
2059         Force SSE2 on x86/32bit builds.
2060
2061         * Scripts/webkitdirs.pm:
2062         (generateBuildSystemFromCMakeProject):
2063
2064 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2065
2066         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2067         https://bugs.webkit.org/show_bug.cgi?id=196073
2068
2069         Reviewed by Michael Catanzaro.
2070
2071         Add test cases to check functions and constructors with no arguments but receiving user data.
2072
2073         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2074         (checkUserData):
2075         (testJSCFunction):
2076         (fooCreateWithUserData):
2077         (testJSCClass):
2078
2079 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2080
2081         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2082
2083         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2084
2085         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2086
2087 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2088
2089         [GTK][WPE] Add API to provide geolocation information
2090         https://bugs.webkit.org/show_bug.cgi?id=195940
2091
2092         Reviewed by Michael Catanzaro.
2093
2094         Add a new test to check the new API.
2095
2096         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2097         (testGeolocationManagerCurrentPosition):
2098         (testGeolocationManagerWatchPosition):
2099         (beforeAll):
2100         (afterAll):
2101         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2102         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2103         (beforeAll): Ditto.
2104         * TestWebKitAPI/glib/CMakeLists.txt:
2105
2106 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2107
2108         [GLib] Returning G_TYPE_OBJECT from a method does not work
2109         https://bugs.webkit.org/show_bug.cgi?id=195574
2110
2111         Reviewed by Michael Catanzaro.
2112
2113         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2114
2115         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2116         (getGFile):
2117         (getParent):
2118         (createGString):
2119         (getGString):
2120         (getGStringCopyWillRaise):
2121         (getGStringCopy):
2122         (getGStringStr):
2123         (getGStringLen):
2124         (freeGString):
2125         (testJSCClass):
2126
2127 2019-03-20  Saam Barati  <sbarati@apple.com>
2128
2129         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2130         https://bugs.webkit.org/show_bug.cgi?id=195721
2131
2132         Reviewed by Filip Pizlo.
2133
2134         * Scripts/run-javascriptcore-tests:
2135
2136 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2137
2138         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2139         https://bugs.webkit.org/show_bug.cgi?id=196049
2140
2141         Reviewed by Tim Horton.
2142
2143         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2144         overflow scrolling in general, so rename it.
2145
2146         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2147
2148 2019-03-20  Daniel Bates  <dabates@apple.com>
2149
2150         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2151         https://bugs.webkit.org/show_bug.cgi?id=196031
2152         <rdar://problem/49078172>
2153
2154         Reviewed by Tim Horton.
2155
2156         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2157         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2158         same code path used when the Done button is pressed to dismiss the <select> picker.
2159
2160         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2161         (TestWebKitAPI::TEST):
2162
2163 2019-03-20  Chris Dumez  <cdumez@apple.com>
2164
2165         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2166         https://bugs.webkit.org/show_bug.cgi?id=196029
2167         <rdar://problem/48954651>
2168
2169         Reviewed by Tim Horton.
2170
2171         Add API test coverage.
2172
2173         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2174
2175 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2176
2177         [ews-build] Improve failure summary string for ApplyPatch step
2178         https://bugs.webkit.org/show_bug.cgi?id=195995
2179
2180         Reviewed by Alexey Proskuryakov.
2181
2182         * BuildSlaveSupport/ews-build/steps.py:
2183         (ApplyPatch.getResultSummary): Override getResultSummary.
2184
2185 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2186
2187         AX: Implement support for new meter ARIA role
2188         https://bugs.webkit.org/show_bug.cgi?id=195966
2189
2190         Reviewed by Chris Fleizach.
2191
2192         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2193         to AXLevelIndicator.
2194
2195         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2196
2197 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2198
2199         [WebAuthN] Implement FIDO AppID extension
2200         https://bugs.webkit.org/show_bug.cgi?id=143491
2201         <rdar://problem/48298273>
2202
2203         Reviewed by Brent Fulgham.
2204
2205         Add a test that covers the new flag of convertToU2fSignCommand.
2206
2207         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2208         (TestWebKitAPI::TEST):
2209         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2210         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2211         (TestWebKitAPI::TEST):
2212
2213 2019-03-19  Keith Rollin  <krollin@apple.com>
2214
2215         Add support for more platforms to generate-xcfilelists
2216         https://bugs.webkit.org/show_bug.cgi?id=195977
2217
2218         Reviewed by Alexey Proskuryakov.
2219
2220         generate-xcfilelists incorrectly complains when involved with building
2221         WebKit for iphonesimulator:
2222
2223             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2224             …
2225             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2226
2227         Address this by teaching generate-xcfilelists about more platforms.
2228
2229         * Scripts/generate-xcfilelists:
2230
2231 2019-03-19  John Wilander  <wilander@apple.com>
2232
2233         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2234         https://bugs.webkit.org/show_bug.cgi?id=195923
2235         <rdar://problem/49001272>
2236
2237         Reviewed by Alex Christensen.
2238
2239         This patch does the following to the TestRunner:
2240         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2241         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2242         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2243
2244         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2245         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2246         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2247         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2248         * WebKitTestRunner/TestController.cpp:
2249         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2250         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2251         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2252         * WebKitTestRunner/TestController.h:
2253         * WebKitTestRunner/TestInvocation.cpp:
2254         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2255
2256 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2257
2258         [CMake] Support more clang and gcc sanitizers
2259         https://bugs.webkit.org/show_bug.cgi?id=195956
2260
2261         Reviewed by Michael Catanzaro.
2262
2263         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2264
2265 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2266
2267         [ews-build] Improve summary for PrintConfiguration step
2268         https://bugs.webkit.org/show_bug.cgi?id=195945
2269
2270         Reviewed by Lucas Forschler.
2271
2272         * BuildSlaveSupport/ews-build/steps.py:
2273         (PrintConfiguration.getResultSummary): Override getResultSummary.
2274
2275 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2276
2277         [ews-build] Improve summary for CheckOutSource step
2278         https://bugs.webkit.org/show_bug.cgi?id=195963
2279
2280         Reviewed by Lucas Forschler.
2281
2282         * BuildSlaveSupport/ews-build/steps.py:
2283         (CheckOutSource.getResultSummary):
2284
2285 2019-03-19  Daniel Bates  <dabates@apple.com>
2286
2287         [iOS] Focus not preserved when switching between tabs
2288         https://bugs.webkit.org/show_bug.cgi?id=195820
2289         <rdar://problem/43614450>
2290
2291         Reviewed by Brent Fulgham.
2292
2293         Add tests to ensure that we restore focus when resigning and becoming first responder.
2294
2295         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2296         (TestWebKitAPI::TEST):
2297
2298 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2299
2300         Make WTFLogChannelState and WTFLogLevel enum classes
2301         https://bugs.webkit.org/show_bug.cgi?id=195904
2302
2303         Reviewed by Eric Carlson.
2304
2305         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2306         (TestWebKitAPI::TEST_F):
2307
2308 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2309
2310         [GStreamer][EME] Backported mssdemux protection data crash fix
2311         https://bugs.webkit.org/show_bug.cgi?id=195918
2312
2313         Reviewed by Philippe Normand.
2314
2315         * gstreamer/jhbuild.modules:
2316         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2317
2318 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2319
2320         Unreviewed, rolling out r243132.
2321
2322         Broke GTK build
2323
2324         Reverted changeset:
2325
2326         "Make WTFLogChannelState and WTFLogLevel enum classes"
2327         https://bugs.webkit.org/show_bug.cgi?id=195904
2328         https://trac.webkit.org/changeset/243132
2329
2330 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2331
2332         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2333
2334         * Scripts/webkitdirs.pm:
2335         (builtDylibPathForName): Adjust the shared library name that's changed
2336         with the API version bump in r243073.
2337
2338 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2339
2340         Make WTFLogChannelState and WTFLogLevel enum classes
2341         https://bugs.webkit.org/show_bug.cgi?id=195904
2342
2343         Reviewed by Eric Carlson.
2344
2345         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2346         (TestWebKitAPI::TEST_F):
2347
2348 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2349
2350         Disable flaky test added in r2431100
2351         https://webkit.org/b/195785
2352
2353         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2354         (TestWebKitAPI::TEST):
2355         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2356
2357 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2358
2359         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2360         https://bugs.webkit.org/show_bug.cgi?id=195916
2361
2362         Reviewed by Tim Horton.
2363
2364         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2365         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2366
2367 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2368
2369         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2370
2371         * Scripts/webkitpy/common/config/contributors.json:
2372
2373 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2374
2375         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2376         https://bugs.webkit.org/show_bug.cgi?id=195785
2377
2378         Reviewed by Geoffrey Garen.
2379
2380         * TestWebKitAPI/TCPServer.cpp: Added.
2381         (TestWebKitAPI::TCPServer::TCPServer):
2382         (TestWebKitAPI::TCPServer::~TCPServer):
2383         (TestWebKitAPI::TCPServer::socketBindListen):
2384         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2385         * TestWebKitAPI/TCPServer.h: Added.
2386         (TestWebKitAPI::TCPServer::port const):
2387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2388         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2389         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2390         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2391         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2392         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2393         (TestWebKitAPI::respondSlowly):
2394         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2395         (TestWebKitAPI::downloadAtRate):
2396         (TestWebKitAPI::TEST):
2397
2398 2019-03-18  Saam Barati  <sbarati@apple.com>
2399
2400         Add a plan file for JetStream 2
2401         https://bugs.webkit.org/show_bug.cgi?id=190734
2402
2403         Reviewed by Mark Lam.
2404
2405         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2406
2407 2019-03-18  Chris Dumez  <cdumez@apple.com>
2408
2409         Delay WebProcess launch until a load is triggered in a Web view
2410         https://bugs.webkit.org/show_bug.cgi?id=195758
2411         <rdar://problem/48126013>
2412
2413         Reviewed by Geoff Garen.
2414
2415         Add API test coverage. Also update some existing API tests to not expect
2416         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2417
2418         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2419         (TestWebKitAPI::TEST):
2420         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2421         (TestWebKitAPI::TEST):
2422         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2423         (TEST):
2424         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2425         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2426         (TEST):
2427         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2428         (TEST):
2429         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2430
2431 2019-03-18  Xan Lopez  <xan@igalia.com>
2432
2433         [CMake] Prevent potential warning when determining $architecture
2434         https://bugs.webkit.org/show_bug.cgi?id=195891
2435
2436         Reviewed by Michael Catanzaro.
2437
2438         It's possible for generateBuildSystemForCMakeProject to be called
2439         before determineArchitecture() is ever called. This will make the
2440         first eq check with $architecture to be bogus (and print a
2441         warning). Change that to an eq check with architecture(), which
2442         implicitly calls determineArchitecture() if needed, and change all
2443         the other similar cases in the method in the same way to prevent
2444         future bugs like this one.
2445
2446         * Scripts/webkitdirs.pm:
2447         (generateBuildSystemFromCMakeProject):
2448
2449 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2450
2451         [WPE] Tarballs generated with “make dist” cannot build documentation
2452         https://bugs.webkit.org/show_bug.cgi?id=195885
2453
2454         Reviewed by Carlos Garcia Campos.
2455
2456         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2457
2458 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2459
2460         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2461         https://bugs.webkit.org/show_bug.cgi?id=195883
2462
2463         Reviewed by Carlos Garcia Campos.
2464
2465         * gtkdoc/gtkdoc.py:
2466         (GTKDoc._run_command): When commands fail to run, include the full command line for
2467         the program invocation and the output it has generated on the standard error stream.
2468
2469 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2470
2471         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2472         https://bugs.webkit.org/show_bug.cgi?id=195786
2473
2474         Reviewed by Philippe Normand.
2475
2476         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2477         * wpe/jhbuild.modules: Ditto.
2478
2479 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2480
2481         [ews-build] Don't run clean builds on EWS builders
2482         https://bugs.webkit.org/show_bug.cgi?id=195851
2483
2484         Reviewed by Geoffrey Garen.
2485
2486         * BuildSlaveSupport/ews-build/factories.py:
2487
2488 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2489
2490         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2491         https://bugs.webkit.org/show_bug.cgi?id=195849
2492
2493         Reviewed by Chris Dumez.
2494
2495         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2496
2497         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2498         (runWebsiteDataStoreCustomPaths):
2499
2500 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2501
2502         webkitpy: Upload test results
2503         https://bugs.webkit.org/show_bug.cgi?id=195755
2504         <rdar://problem/48896182>
2505
2506         Reviewed by Aakash Jain.
2507
2508         Establish a new format for uploading results that is not tied to layout tests, apply
2509         that format to webkitpy tests.
2510
2511         * Scripts/webkitpy/common/checkout/scm/git.py:
2512         (Git.native_branch): Return what branch the current checkout is on.
2513         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2514         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2515         * Scripts/webkitpy/common/checkout/scm/svn.py:
2516         (SVN.native_branch): Ditto.
2517         * Scripts/webkitpy/common/system/platforminfo.py:
2518         (PlatformInfo.build_version): Return a build version for Mac.
2519         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2520         (MockPlatformInfo.__init__):
2521         (MockPlatformInfo.build_version):
2522         * Scripts/webkitpy/results: Added.
2523         * Scripts/webkitpy/results/__init__.py: Added.
2524         * Scripts/webkitpy/results/options.py: Added.
2525         (upload_options): OptParse list for upload options.
2526         * Scripts/webkitpy/results/upload.py: Added.
2527         (Upload): Class which enforces the upload format expected by the results server.
2528         (Upload.Expectations):
2529         (Upload.create_configuration):
2530         (Upload.create_commit):
2531         (Upload.create_details):
2532         (Upload.create_run_stats):
2533         (Upload.create_test_result):
2534         (Upload.__init__):
2535         (Upload.Encoder): Encode Upload object as json.
2536         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2537         * Scripts/webkitpy/results/upload_unittest.py: Added.
2538         * Scripts/webkitpy/test/main.py:
2539         (Tester._parse_args): Add upload arguments.
2540         (Tester._run_tests): Allow results to be uploaded.
2541         * Scripts/webkitpy/test/runner.py:
2542         (Runner.__init__): Record which tests were run, rather than just counting them.
2543         (Runner.handle):
2544         * Scripts/webkitpy/test/runner_unittest.py:
2545         (RunnerTest.test_run):
2546         * Scripts/webkitpy/thirdparty/__init__.py:
2547         (AutoinstallImportHook.find_module): Add requests auto-install.
2548         (AutoinstallImportHook._install_requests):
2549         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2550         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2551
2552 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2553
2554         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2555         https://bugs.webkit.org/show_bug.cgi?id=195810
2556
2557         Reviewed by Tim Horton.
2558
2559         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2560         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2561         ending certain layout tests.
2562
2563         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2564         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2565         (-[TestRunnerWKWebView dealloc]):
2566         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2567
2568         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2569         helper method when destroying the web view, and when resetting state between tests.
2570
2571         * WebKitTestRunner/ios/TestControllerIOS.mm:
2572         (WTR::TestController::platformResetStateToConsistentValues):
2573
2574         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2575
2576 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2577
2578         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2579         https://bugs.webkit.org/show_bug.cgi?id=190350
2580         <rdar://problem/45089503>
2581
2582         Reviewed by Geoffrey Garen.
2583
2584         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2585         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2586         (TEST):
2587         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2588         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2589         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2590         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2591         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2592         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2593         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2594         (runTest):
2595         (createDirectories):
2596         (TEST):
2597         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2598         (TEST):
2599         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2600         (TEST):
2601
2602 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2603
2604         Add support to WebPage for getting the contents as an attributed string.
2605         https://bugs.webkit.org/show_bug.cgi?id=195636
2606         rdar://problem/45055697
2607
2608         Reviewed by Tim Horton.
2609
2610         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2611         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2612
2613 2019-03-15  Chris Dumez  <cdumez@apple.com>
2614
2615         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2616         https://bugs.webkit.org/show_bug.cgi?id=195747
2617
2618         Reviewed by Geoff Garen.
2619
2620         Add API test coverage.
2621
2622         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2623
2624 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2625
2626         Unreviewed, rolling out r242952.
2627
2628         Causing API failures on iOS Simulator
2629
2630         Reverted changeset:
2631
2632         "[PSON] Make sure the WebProcessCache is leverage when
2633         relaunching a process after termination"
2634         https://bugs.webkit.org/show_bug.cgi?id=195747
2635         https://trac.webkit.org/changeset/242952
2636
2637 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2638
2639         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2640         https://bugs.webkit.org/show_bug.cgi?id=195740
2641
2642         Reviewed by Ross Kirsling.
2643
2644         window.open doesn't work for WebKitBrowserWindow because it is not
2645         implemented yet.
2646
2647         1. Implemented createNewPage callback of WKPageUIClient.
2648         2. Changed MainWindow to take a BrowserWindow factory function
2649           instead of BrowserWindowType to be flexible to create
2650           BrowserWindow with extra settings.
2651         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2652           because it is not relevant with MainWindow anymore.
2653
2654         * MiniBrowser/win/Common.cpp:
2655         (parseCommandLine):
2656         * MiniBrowser/win/Common.h:
2657         (CommandLineOptions::CommandLineOptions):
2658         * MiniBrowser/win/MainWindow.cpp:
2659         (MainWindow::MainWindow):
2660         (MainWindow::create):
2661         (MainWindow::init):
2662         (MainWindow::WndProc):
2663         * MiniBrowser/win/MainWindow.h:
2664         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2665         (PrintWebUIDelegate::createWebViewWithRequest):
2666         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2667         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2668         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2669         (WebKitBrowserWindow::updateProxySettings):
2670         (WebKitBrowserWindow::createNewPage):
2671         * MiniBrowser/win/WebKitBrowserWindow.h:
2672         * MiniBrowser/win/WinMain.cpp:
2673         (wWinMain):
2674
2675 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2676
2677         Make it possible to test scrolling tree layer manipulation more easily
2678         https://bugs.webkit.org/show_bug.cgi?id=195780
2679
2680         Reviewed by Tim Horton.
2681         
2682         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2683         cuts off communication of scrolling tree scrolls back to the web process
2684         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2685         allows tests to trigger scrolls which run the scrolling tree layer positioning
2686         logic, but never get another commit from the web process that might mask
2687         scrolling tree bugs.
2688         
2689         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2690         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2691         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2692
2693         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2694         (WTR::UIScriptController::scrollUpdatesDisabled const):
2695         (WTR::UIScriptController::setScrollUpdatesDisabled):
2696         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2697         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2698         (WTR::UIScriptController::scrollUpdatesDisabled const):
2699         (WTR::UIScriptController::setScrollUpdatesDisabled):
2700         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2701         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2702         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2703         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2704         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2705         * WebKitTestRunner/ios/TestControllerIOS.mm:
2706         (WTR::TestController::platformResetStateToConsistentValues):
2707         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2708         (WTR::UIScriptController::scrollUpdatesDisabled const):
2709         (WTR::UIScriptController::setScrollUpdatesDisabled):
2710
2711 2019-03-14  Youenn Fablet  <youenn@apple.com>
2712
2713         Move IDB storage in private browsing mode to NetworkProcess
2714         https://bugs.webkit.org/show_bug.cgi?id=195602
2715
2716         Reviewed by Brady Eidson.
2717
2718         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2719         (TEST):
2720
2721 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2722
2723         [ews-build] Make descriptionDone messages more readable
2724         https://bugs.webkit.org/show_bug.cgi?id=195760
2725
2726         Reviewed by Lucas Forschler.
2727
2728         * BuildSlaveSupport/ews-build/steps.py:
2729         * BuildSlaveSupport/ews-build/steps_unittest.py:
2730
2731 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2732
2733         [ews-build] Generate status-bubble hover-over messages
2734         https://bugs.webkit.org/show_bug.cgi?id=195680
2735
2736         Reviewed by Lucas Forschler.
2737
2738         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2739         (StatusBubble):
2740         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2741         on hover-over.
2742         (StatusBubble._iso_time):
2743         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2744         hover-over message.
2745         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2746
2747 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2748
2749         [ews-app] Gracefully handle the case when state_string is None
2750         https://bugs.webkit.org/show_bug.cgi?id=195753
2751
2752         Reviewed by Lucas Forschler.
2753
2754         * BuildSlaveSupport/ews-app/ews/models/build.py:
2755         * BuildSlaveSupport/ews-app/ews/models/step.py:
2756
2757 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2758
2759         [ews-app] Status bubble display pending for currently running build step
2760         https://bugs.webkit.org/show_bug.cgi?id=195744
2761
2762         Reviewed by Lucas Forschler.
2763
2764         * BuildSlaveSupport/ews-build/events.py:
2765         (Events.stepStarted): If state_string is pending, replace it with step name.
2766
2767 2019-03-14  Chris Dumez  <cdumez@apple.com>
2768
2769         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2770         https://bugs.webkit.org/show_bug.cgi?id=195750
2771
2772         Reviewed by Geoffrey Garen.
2773
2774         Add API test coverage.
2775
2776         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2777         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2778         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2779         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2780
2781 2019-03-14  Chris Dumez  <cdumez@apple.com>
2782
2783         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2784         https://bugs.webkit.org/show_bug.cgi?id=195747
2785
2786         Reviewed by Geoff Garen.
2787
2788         Add API test coverage.
2789
2790         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2791
2792 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2793
2794         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2795         https://bugs.webkit.org/show_bug.cgi?id=195725
2796         <rdar://problem/48545062>
2797
2798         Reviewed by Tim Horton.
2799
2800         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2801         handler is nil.
2802
2803         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2804         (TestWebKitAPI::TEST):
2805
2806 2019-03-13  Sam Weinig  <sam@webkit.org>
2807
2808         Add utility function to allow easy reverse range-based iteration of a container
2809         https://bugs.webkit.org/show_bug.cgi?id=195542
2810
2811         Reviewed by Antti Koivisto.
2812
2813         * TestWebKitAPI/CMakeLists.txt:
2814         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2815         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2816         (TestWebKitAPI::TEST):
2817         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2818
2819 2019-03-13  Chris Dumez  <cdumez@apple.com>
2820
2821         Use a ServiceWorker process per registrable domain
2822         https://bugs.webkit.org/show_bug.cgi?id=195649
2823
2824         Reviewed by Youenn Fablet.
2825
2826         Update API test coverage.
2827
2828         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2829
2830 2019-03-13  Chris Dumez  <cdumez@apple.com>
2831
2832         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2833         https://bugs.webkit.org/show_bug.cgi?id=195684
2834         <rdar://problem/48294714>
2835
2836         Reviewed by Antti Koivisto.
2837
2838         Add API test coverage.
2839
2840         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2841
2842 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2843
2844         [ews-app] Remove unused patch view
2845         https://bugs.webkit.org/show_bug.cgi?id=195669
2846
2847         Reviewed by Lucas Forschler.
2848
2849         * BuildSlaveSupport/ews-app/ews/urls.py:
2850         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2851
2852 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2853
2854         [ews-app] Use Buildbot result code variables
2855         https://bugs.webkit.org/show_bug.cgi?id=195668
2856
2857         Reviewed by Alexey Proskuryakov.
2858
2859         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2860         (Buildbot): Added Buildbot result code variables.
2861         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2862         (StatusBubble._build_bubble): Used Buildbot result code variables.
2863
2864 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2865
2866         [Flatpak] Expand submodule recursively
2867         https://bugs.webkit.org/show_bug.cgi?id=195672
2868
2869         Building WPE with flatpak was impossible without that as it was raising an exception.
2870         Also update wpebackend-fdo to match what is built in jhbuild
2871
2872         Reviewed by Philippe Normand.
2873
2874         * flatpak/flatpakutils.py:
2875         (expand_submodules_recurse):
2876         (expand_manifest):
2877         * flatpak/org.webkit.WPEModules.yaml:
2878
2879 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2880
2881         [ews-app] status bubble should be hidden for certain builds
2882         https://bugs.webkit.org/show_bug.cgi?id=194597
2883
2884         Reviewed by Dewei Zhu.
2885
2886         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2887         (StatusBubble._build_bubble):
2888         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2889         because the patch didn't have relevant changes.
2890         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2891         in production yet.
2892
2893 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2894
2895         [Win] Fix a slew of simple clang-cl warnings.
2896         https://bugs.webkit.org/show_bug.cgi?id=195652
2897
2898         Reviewed by Don Olmstead.
2899
2900         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2901         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2902
2903 2019-03-12  Justin Fan  <justin_fan@apple.com>
2904
2905         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2906         https://bugs.webkit.org/show_bug.cgi?id=195518
2907         <rdar://problem/46322356>
2908
2909         Reviewed by Myles C. Maxfield.
2910
2911         * DumpRenderTree/DerivedSources-input.xcfilelist:
2912         * DumpRenderTree/DerivedSources-output.xcfilelist:
2913
2914 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2915
2916         Unreviewed, rolling out r242825.
2917         https://bugs.webkit.org/show_bug.cgi?id=195648
2918
2919         "Broke webkitpy tests with my change to
2920         lldb_dump_class_layout.py" (Requested by rmorisset on
2921         #webkit).
2922
2923         Reverted changeset:
2924
2925         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2926         classes with suspicious padding"
2927         https://bugs.webkit.org/show_bug.cgi?id=195573
2928         https://trac.webkit.org/changeset/242825
2929
2930 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2931
2932         [ews-build] Show status bubbles while the patch is waiting in queue
2933         https://bugs.webkit.org/show_bug.cgi?id=195618
2934
2935         Reviewed by Lucas Forschler.
2936
2937         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2938         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2939         enabled in initial deployment.
2940         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2941         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2942         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2943         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2944         (StatusBubble._build_bubbles_for_patch):
2945
2946 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2947
2948         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2949         https://bugs.webkit.org/show_bug.cgi?id=195573
2950
2951         Reviewed by Simon Fraser.
2952
2953         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2954
2955         * Scripts/dump-class-layout:
2956         (main):
2957         * lldb/lldb_dump_class_layout.py:
2958         (ClassLayout.__init__):
2959         (ClassLayout._compute_padding_recursive):
2960         (LLDBDebuggerInstance.dump_layout_for_classname):
2961         (LLDBDebuggerInstance):
2962         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2963         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2964
2965 2019-03-12  Chris Dumez  <cdumez@apple.com>
2966
2967         Device Orientation access permission should be denied unless explicitly granted by the client
2968         https://bugs.webkit.org/show_bug.cgi?id=195625
2969
2970         Reviewed by Youenn Fablet.
2971
2972         add API test coverage.
2973
2974         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2975         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2976         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2977         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2978         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2979         (runDeviceOrientationTest):
2980         (TEST):
2981         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2982         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2983
2984 2019-03-12  Jer Noble  <jer.noble@apple.com>
2985
2986         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2987         https://bugs.webkit.org/show_bug.cgi?id=195137
2988         <rdar://problem/48810307>
2989
2990         Reviewed by Eric Carlson.
2991
2992         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2993         (TestWebKitAPI::TEST):
2994
2995 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2996
2997         [ews-build] Change urls from uat to production
2998         https://bugs.webkit.org/show_bug.cgi?id=195566
2999
3000         Reviewed by Lucas Forschler.
3001
3002         * BuildSlaveSupport/ews-app/ews/config.py:
3003         * BuildSlaveSupport/ews-build/events.py:
3004         * BuildSlaveSupport/ews-build/steps.py:
3005
3006 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3007
3008         [ews-build] change max_builds for local-worker to 1
3009         https://bugs.webkit.org/show_bug.cgi?id=195568
3010
3011         Reviewed by Lucas Forschler.
3012
3013         * BuildSlaveSupport/ews-build/loadConfig.py:
3014
3015 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3016
3017         Fix the build
3018
3019         * TestRunnerShared/spi/PencilKitTestSPI.h:
3020         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3021
3022 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3023
3024         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3025         https://bugs.webkit.org/show_bug.cgi?id=194131
3026
3027         Reviewed by Michael Catanzaro.
3028
3029         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3030         (uriChanged):
3031         (testUnfinishedSubresourceLoad):
3032         (serverCallback):
3033         (beforeAll):
3034
3035 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3036
3037         WTF::Expected should use std::addressof instead of operator&
3038         https://bugs.webkit.org/show_bug.cgi?id=195604
3039
3040         Reviewed by Myles Maxfield.
3041
3042         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3043         (TestWebKitAPI::Unique::Unique):
3044         (TestWebKitAPI::Unique::operator&):
3045         (TestWebKitAPI::TEST):
3046
3047 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3048
3049         Add Optional to Forward.h.
3050         https://bugs.webkit.org/show_bug.cgi?id=195586
3051
3052         Reviewed by Darin Adler.
3053
3054         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3055         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3056         Remove unnecessary includes from headers.
3057
3058 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3059
3060         Add testing API to hit-test and scroll overflow scrollers
3061         https://bugs.webkit.org/show_bug.cgi?id=195278
3062
3063         Reviewed by Antti Koivisto.
3064         
3065         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3066         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3067         
3068         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3069
3070         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3071         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3072         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3073         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3074         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3075         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3076         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3077         (WTR::enclosingScrollViewIncludingSelf):
3078         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3079
3080 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3081
3082         API test WebKit.RequestTextInputContext fails on iOS
3083         https://bugs.webkit.org/show_bug.cgi?id=195585
3084
3085         Reviewed by Wenson Hsieh and Simon Fraser.
3086
3087         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3088         (applyStyle):
3089         (TEST):
3090         Add a viewport, so that the coordinates match up on iOS.
3091         Scroll by moving the UIScrollView's contentOffset.
3092
3093 2019-03-11  Chris Dumez  <cdumez@apple.com>
3094
3095         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3096         https://bugs.webkit.org/show_bug.cgi?id=195506
3097         <rdar://problem/48733477>
3098
3099         Reviewed by Alex Christensen.
3100
3101         Add API test coverage.
3102
3103         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3104
3105 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3106
3107         Adding myself to contributors.json
3108
3109         Unreviewed, addming myself to contributors.json .
3110
3111         * Scripts/webkitpy/common/config/contributors.json:
3112
3113 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3114
3115         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3116         https://bugs.webkit.org/show_bug.cgi?id=195511
3117         <rdar://problem/44873269>
3118
3119         Reviewed by Darin Adler.
3120
3121         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3122         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3123         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3124         (TEST_F):
3125
3126 2019-03-11  Chris Dumez  <cdumez@apple.com>
3127
3128         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3129         https://bugs.webkit.org/show_bug.cgi?id=195561
3130
3131         Reviewed by Youenn Fablet.
3132
3133         Make sure the JS in the test requests for permission to receive device orientation events.
3134
3135         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3136
3137 2019-03-11  Youenn Fablet  <youenn@apple.com>
3138
3139         Allow storage quota increase by default in WTR
3140         https://bugs.webkit.org/show_bug.cgi?id=195541
3141
3142         Reviewed by Geoffrey Garen.
3143
3144         Allow storage quota increase by default in WTR.
3145         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3146         Use this for tests that explicitly need cache increase.
3147
3148         Instead of increasing quota by 2, make sure the next request is
3149         granted by adding all given parameters.
3150
3151         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3152         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3153         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3154         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3155         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3156         * WebKitTestRunner/TestController.cpp:
3157         (WTR::TestController::setAllowStorageQuotaIncrease):
3158         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3159         * WebKitTestRunner/TestController.h:
3160         * WebKitTestRunner/TestInvocation.cpp:
3161         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3162         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3163         (WTR::TestController::cocoaResetStateToConsistentValues):
3164         (WTR::TestController::setAllowStorageQuotaIncrease):
3165         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3166         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3167         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3168
3169 2019-03-11  Xan Lopez  <xan@igalia.com>
3170
3171         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3172         https://bugs.webkit.org/show_bug.cgi?id=194147
3173
3174         Reviewed by Michael Saboff.
3175
3176         To make --32-bit work correctly on Linux/64bit we need to:
3177
3178         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3179         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3180         unfortunately CMake only allows us to do this during
3181         crosscompilation, which is overkill here.
3182         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3183         pkg-config detection module uses the x86 .pc files instead of the
3184         x86_64 ones.
3185         - Set the -m32 flags for the compiler.
3186
3187         * Scripts/webkitdirs.pm:
3188         (generateBuildSystemFromCMakeProject):
3189
3190 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3191
3192         Add MotionMark-1.1 plan file for run-benchmark script.
3193         https://bugs.webkit.org/show_bug.cgi?id=195481
3194
3195         Rubber-stamped by Darin Adler.
3196
3197         Run-benchmark script should support MontionMark-1.1.
3198
3199         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3200
3201 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3202
3203         [ews-app] Add support for submit-to-ews url
3204         https://bugs.webkit.org/show_bug.cgi?id=195477
3205
3206         Reviewed by Lucas Forschler.
3207
3208         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3209         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3210         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3211         * BuildSlaveSupport/ews-app/ews/urls.py:
3212         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3213
3214 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3215
3216         Unreviewed, rolling out r242688, r242643, r242624.
3217
3218         Caused multiple layout test failures and crashes on iOS and macOS.
3219
3220         Reverted changeset:
3221
3222         "requestAnimationFrame should execute before the next frame"
3223         https://bugs.webkit.org/show_bug.cgi?id=177484
3224         https://trac.webkit.org/changeset/242624/webkit
3225
3226         * Tracing/SystemTracePoints.plist:
3227
3228 2019-03-11  John Wilander  <wilander@apple.com>
3229
3230         Resource Load Statistics: Make it possible exclude localhost from classification
3231         https://bugs.webkit.org/show_bug.cgi?id=195474
3232         <rdar://problem/47520577>
3233
3234         Reviewed by Brent Fulgham.
3235
3236         This patch allows for localhost to be excluded from classification and
3237         treatment as a prevalent resource.
3238
3239         The WebKit Tools change adds a new function called
3240         testRunner.setStatisticsIsRunningTest() which can be used to control this
3241         behavior.
3242
3243         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3244         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3245         (WTR::TestRunner::setStatisticsIsRunningTest):
3246         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3247         * WebKitTestRunner/TestController.cpp:
3248         (WTR::TestController::setStatisticsIsRunningTest):
3249         * WebKitTestRunner/TestController.h:
3250         * WebKitTestRunner/TestInvocation.cpp:
3251         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3252
3253 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3254
3255         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3256         https://bugs.webkit.org/show_bug.cgi?id=195560
3257
3258         Reviewed by Lucas Forschler.
3259
3260         * BuildSlaveSupport/ews-build/master.cfg:
3261
3262 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3263
3264         Unreviewed, rolling out r242698.
3265
3266         API test crashes on bots.
3267
3268         Reverted changeset:
3269
3270         "Add a WKContentRuleList variant that uses copied memory
3271         instead of mmap'd shared memory for class A containerized
3272         apps"
3273         https://bugs.webkit.org/show_bug.cgi?id=195511
3274         https://trac.webkit.org/changeset/242698
3275
3276 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3277
3278         [WPE] Enable web process sandbox
3279         https://bugs.webkit.org/show_bug.cgi?id=195169
3280
3281         Reviewed by Daniel Bates.
3282
3283         * wpe/install-dependencies:
3284         * wpe/jhbuild.modules:
3285
3286 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3287
3288         [ews-app] Use port 17000 for worker communication
3289         https://bugs.webkit.org/show_bug.cgi?id=195558
3290
3291         Reviewed by Lucas Forschler.
3292
3293         * BuildSlaveSupport/ews-build/master.cfg:
3294
3295 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3296
3297         [ews-build] unit-tests fail when passwords.json is missing
3298         https://bugs.webkit.org/show_bug.cgi?id=195557
3299
3300         Reviewed by Lucas Forschler.
3301
3302         * BuildSlaveSupport/ews-build/loadConfig.py:
3303         (loadBuilderConfig):
3304         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3305         (ConfigDotJSONTest.test_configuration):
3306         * BuildSlaveSupport/ews-build/master.cfg:
3307
3308 2019-03-11  Truitt Savell  <tsavell@apple.com>
3309
3310         Unreviewed, rolling out r242702.
3311
3312         Broke High Sierra builders.
3313
3314         Reverted changeset:
3315
3316         "Add utility function to allow easy reverse range-based
3317         iteration of a container"
3318         https://bugs.webkit.org/show_bug.cgi?id=195542
3319         https://trac.webkit.org/changeset/242702
3320
3321 2019-03-11  Sam Weinig  <sam@webkit.org>
3322
3323         Add utility function to allow easy reverse range-based iteration of a container
3324         https://bugs.webkit.org/show_bug.cgi?id=195542
3325
3326         Reviewed by Antti Koivisto.
3327
3328         * TestWebKitAPI/CMakeLists.txt:
3329         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3330         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3331         (TestWebKitAPI::TEST):
3332         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3333
3334 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3335
3336         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3337         https://bugs.webkit.org/show_bug.cgi?id=195511
3338         <rdar://problem/44873269>
3339
3340         Reviewed by Darin Adler.
3341
3342         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3343         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3344         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3345         (TEST_F):
3346
3347 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3348
3349         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3350         https://bugs.webkit.org/show_bug.cgi?id=195499
3351
3352         Reviewed by Darin Adler.
3353
3354         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3355         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3356         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3357         (-[WKWebView synchronouslyFocusTextInputContext:]):
3358         (applyStyle):
3359         (applyIframe):
3360         (TEST):
3361         Add some tests for this SPI.
3362
3363 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3364
3365         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3366         https://bugs.webkit.org/show_bug.cgi?id=181151
3367
3368         Reviewed by Don Olmstead.
3369
3370         * TestWebKitAPI/CMakeLists.txt:
3371         * TestWebKitAPI/PlatformWin.cmake:
3372         Enable TestWTF RunLoop tests in all platforms.
3373
3374         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3375         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3376         (TestWebKitAPI::DerivedOneShotTimer::fired):
3377         (TestWebKitAPI::TEST):
3378         Only a few platforms support nested RunLoop.
3379
3380         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3381         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3382
3383 2019-03-10  David Quesada  <david_quesada@apple.com>
3384
3385         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3386         https://bugs.webkit.org/show_bug.cgi?id=152480
3387
3388         Reviewed by Chris Dumez.
3389
3390         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3391         there are no additional references to the process pool besides the one held by
3392         the download, waits for the download to finish (in the sense that the
3393         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3394         measure, also check that the process pool has been deallocated at the end of the
3395         test. The test wouldn't be meaningful if the process pool were still alive.
3396
3397         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3398         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3399         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3400             The download will be canceled because the delegate does not implement the
3401             method to decide the download's destination, so this is where we know the
3402             DownloadProxyMap is done with the DownloadProxy.
3403         (TEST):
3404
3405 2019-03-08  Chris Dumez  <cdumez@apple.com>
3406
3407         Add support for Device Orientation / Motion permission API
3408         https://bugs.webkit.org/show_bug.cgi?id=195329
3409         <rdar://problem/47645367>
3410
3411         Reviewed by Geoffrey Garen.
3412
3413         Add test infrastructure to help test the Device Orientation / Motion permission API.
3414
3415         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3416         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3417         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3418         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3419         * WebKitTestRunner/TestController.cpp:
3420         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3421         (WTR::TestController::createWebViewWithOptions):
3422         (WTR::TestController::resetStateToConsistentValues):
3423         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3424         * WebKitTestRunner/TestController.h:
3425         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3426         * WebKitTestRunner/TestInvocation.cpp:
3427         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3428
3429 2019-03-08  Saam barati  <sbarati@apple.com>
3430
3431         Add a compare-results script to compare benchmark results
3432         https://bugs.webkit.org/show_bug.cgi?id=195486
3433         <rdar://problem/48723397>
3434
3435         Reviewed by Geoffrey Garen.
3436
3437         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3438         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3439         to extend it to learn about our other benchmarks.
3440
3441         * Scripts/compare-results: Added.
3442         (readJSONFile):
3443         (detectJetStream2):
3444         (JetStream2Results):
3445         (detectSpeedometer2):
3446         (Speedometer2Results):
3447         (detectPLT5):
3448         (PLT5Results):
3449         (detectBenchmark):
3450         (biggerIsBetter):
3451         (ttest):
3452         (getOptions):
3453         (main):
3454
3455 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3456
3457         Ensure old tab state is cleared between iterations of run-benchmark
3458         https://bugs.webkit.org/show_bug.cgi?id=195393
3459         <rdar://problem/46885583>
3460
3461         Reviewed by Dewei Zhu.
3462
3463         a) ensure the default to restore state is not set
3464         b) terminate Safari correctly
3465         c) Set the system default to ignore Persistent State in Safari
3466
3467         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3468         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3469         (OSXBrowserDriver.prepare_env): 
3470         (OSXBrowserDriver.restore_env):
3471         (OSXBrowserDriver.close_browsers):
3472         (OSXBrowserDriver._terminate_processes):
3473         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3474         (OSXChromeDriver):
3475         (OSXChromeCanaryDriver):
3476         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3477         (OSXFirefoxDriver):
3478         (OSXFirefoxNightlyDriver):
3479         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3480         (OSXSafariDriver):
3481         (OSXSafariDriver.prepare_env):
3482
3483 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3484
3485         [GTK] Several InputMethodFilter tests are failing
3486         https://bugs.webkit.org/show_bug.cgi?id=195408
3487
3488         Reviewed by Carlos Garcia Campos.
3489
3490         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3491         Regressed in r241751.
3492         Hexadecimal values of keycodes are expressed now in upper letters.
3493         Composited characters should be cast to UTF8 strings.
3494
3495         (TestWebKitAPI::TEST):
3496
3497 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3498
3499         [GTK] Make Tools/gtkdoc python3 compatible
3500         https://bugs.webkit.org/show_bug.cgi?id=195359
3501
3502         Reviewed by Carlos Garcia Campos.
3503
3504         * gtkdoc/generate-gtkdoc:
3505         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3506         work with Python 2 and 3.
3507         (get_gtkdoc_module_paths):
3508         The iteritems() was removed in Python 3, so let's use items() that's
3509         available in Python 2 and 3.
3510         (get_generator_for_config):
3511         * gtkdoc/gtkdoc.py:
3512         (GTKDoc._run_command):
3513         The sys.stdout.write() is expecting str in Python 3 and not bytes
3514         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3515         for passing the bytes there.
3516
3517 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3518
3519         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3520         https://bugs.webkit.org/show_bug.cgi?id=195346
3521         <rdar://problem/48667048>
3522
3523         Unreviewed build fix for clang-cl.
3524
3525         * DumpRenderTree/win/DumpRenderTree.cpp:
3526         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3527
3528 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3529
3530         requestAnimationFrame should execute before the next frame
3531         https://bugs.webkit.org/show_bug.cgi?id=177484
3532
3533         Reviewed by Simon Fraser.
3534
3535         Add trace points for the page RenderingUpdate.
3536
3537         * Tracing/SystemTracePoints.plist:
3538
3539 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3540
3541         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3542         https://bugs.webkit.org/show_bug.cgi?id=195353
3543         <rdar://problem/48626394>
3544
3545         Reviewed by Simon Fraser.
3546
3547         * WebKitTestRunner/ios/TestControllerIOS.mm:
3548         (WTR::TestController::platformResetPreferencesToConsistentValues):
3549
3550 2019-03-07  John Wilander  <wilander@apple.com>
3551
3552         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3553         https://bugs.webkit.org/show_bug.cgi?id=195383
3554         <rdar://problem/48570136>
3555
3556         Reviewed by Brent Fulgham.
3557
3558         This patch adds test infrastructure to purge only script-accessible cookies,
3559         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3560
3561         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3562         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3563         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3564         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3565         * WebKitTestRunner/TestController.cpp:
3566         (WTR::TestController::statisticsDeleteCookiesForHost):
3567         * WebKitTestRunner/TestController.h:
3568         * WebKitTestRunner/TestInvocation.cpp:
3569         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3570
3571 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3572
3573         Unreviewed, rolling out r242354.
3574         https://bugs.webkit.org/show_bug.cgi?id=195402
3575
3576         breaks layout tests in all configurations (Requested by
3577         zdobersek on #webkit).
3578
3579         Reverted changeset:
3580
3581         "[WPE] Enable web process sandbox"
3582         https://bugs.webkit.org/show_bug.cgi?id=195169
3583         https://trac.webkit.org/changeset/242354
3584
3585 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3586
3587         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3588         https://bugs.webkit.org/show_bug.cgi?id=195346
3589
3590         Reviewed by Fujii Hironori.
3591
3592         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3593         (TestWebKitAPI::TEST):
3594         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3595
3596         * DumpRenderTree/win/DumpRenderTree.cpp:
3597         (findFontFallback):
3598         (addFontFallbackIfPresent):
3599         (removeFontFallbackIfPresent):
3600         (main):
3601         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3602         (TestWebKitAPI::Util::moduleDirectory):
3603         (TestWebKitAPI::Util::createInjectedBundlePath):
3604         Use wchar helpers as needed.
3605
3606 2019-03-06  Rob Buis  <rbuis@igalia.com>
3607
3608         Consider supporting the `referrerpolicy` attribute.
3609         https://bugs.webkit.org/show_bug.cgi?id=179053
3610
3611         Reviewed by Darin Adler.
3612
3613         Add a runtime flag for referrerpolicy attribute.
3614
3615         * DumpRenderTree/mac/DumpRenderTree.mm:
3616         (enableExperimentalFeatures):
3617
3618 2019-03-05  Daniel Bates  <dabates@apple.com>
3619
3620         Update expected API test result following r242379
3621         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3622
3623         Update expected x-coordinate of selection rect now that the left padding of
3624         a textarea is sized in ems (so dependent on the font size) just like the left
3625         padding of a text field.
3626
3627         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3628         (TestWebKitAPI::TEST):
3629
3630 2019-03-05  David Quesada  <david_quesada@apple.com>
3631
3632         [WK2] It should be possible to follow links with 'download' attributes
3633         https://bugs.webkit.org/show_bug.cgi?id=195145
3634         rdar://problem/48462642
3635
3636         Reviewed by Alex Christensen.
3637
3638         Add a unit test to verify that activating links with 'download' attributes now
3639         navigates to the linked resource, rather than starts downloading it. Add another
3640         to verify that it is still possible to explicitly download the link via the
3641         'Download' navigation action policy.
3642
3643         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3644         (-[DownloadAttributeTestDelegate init]):
3645         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3646         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3647         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3648         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3649         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3650         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3651         (TEST):
3652         * WebKitTestRunner/TestController.cpp:
3653         (WTR::TestController::decidePolicyForNavigationAction):
3654         * WebKitTestRunner/TestController.h:
3655
3656 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3657
3658         [Curl] Implement Cookie Accept Policy.
3659         https://bugs.webkit.org/show_bug.cgi?id=191645
3660
3661         Reviewed by Fujii Hironori.
3662
3663         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3664         (TestWebKitAPI::Curl::TEST_F):
3665
3666 2019-03-05  Youenn Fablet  <youenn@apple.com>
3667
3668         Rename requestCacheStorageSpace to requestStorageSpace
3669         https://bugs.webkit.org/show_bug.cgi?id=195282
3670
3671         Reviewed by Chris Dumez.
3672
3673         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3674         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3675         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3676
3677 2019-03-05  Brady Eidson  <beidson@apple.com>
3678
3679         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3680         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3681
3682         Reviewed by Tim Horton.
3683
3684         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3685         different directory into that same WKWebView should work.
3686
3687         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3688         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3689
3690 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3691
3692         Add WeakHashSet
3693         https://bugs.webkit.org/show_bug.cgi?id=195152
3694
3695         Reviewed by Antti Koivisto.
3696
3697         Added tests for WeakHashSet.
3698
3699         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3700         (TestWebKitAPI::Base::Base): Moved.
3701         (TestWebKitAPI::Derived::foo): Moved.
3702         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3703         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3704         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3705         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3706
3707 2019-03-04  Chris Dumez  <cdumez@apple.com>
3708
3709         Do not share WebProcesses between private and regular sessions
3710         https://bugs.webkit.org/show_bug.cgi?id=195189
3711         <rdar://problem/48421064>
3712
3713         Reviewed by Alex Christensen.
3714
3715         Add API test coverage.
3716
3717         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3718         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3719
3720 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3721
3722         [WPE] Enable web process sandbox
3723         https://bugs.webkit.org/show_bug.cgi?id=195169
3724
3725         Reviewed by Daniel Bates.
3726
3727         * wpe/install-dependencies:
3728         * wpe/jhbuild.modules:
3729
3730 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3731
3732         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3733         https://bugs.webkit.org/show_bug.cgi?id=195206
3734
3735         Reviewed by Žan Doberšek.
3736
3737         Add a new test case.
3738
3739         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3740         (testJSCClass):
3741
3742 2019-03-04  Charlie Turner  <cturner@igalia.com>
3743
3744         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3745         https://bugs.webkit.org/show_bug.cgi?id=194898
3746
3747         Reviewed by Žan Doberšek.
3748
3749         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3750         a GCC extension that permits arithmetic on void* pointer. Inline
3751         the macro until this issue is fixed upstream.
3752
3753 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3754
3755         Rid the world of WK_API_ENABLED
3756         https://bugs.webkit.org/show_bug.cgi?id=195263
3757
3758         Reviewed by Dan Bernstein.
3759
3760         List of changed files elided because it's useless.
3761
3762 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3763
3764         Unreviewed follow-up to r242292.
3765
3766         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3767
3768         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3769         (TestWebKitAPI::testStrip): Renamed from strip.
3770         (TestWebKitAPI::TEST):
3771
3772 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3773
3774         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3775
3776         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3777         and bug #194272 for details.
3778
3779         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3780
3781 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3782
3783         Remove some more unused 32-bit code
3784         https://bugs.webkit.org/show_bug.cgi?id=195255
3785
3786         Reviewed by Darin Adler.
3787
3788         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3789         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3790         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3791         (NPP_New):
3792         (NPP_HandleEvent):
3793         (handleEventCarbon): Deleted.
3794
3795 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3796
3797         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3798
3799         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3800         (TestWebKitAPI::TEST):
3801
3802 2019-03-01  Darin Adler  <darin@apple.com>
3803
3804         Finish removing String::format
3805         https://bugs.webkit.org/show_bug.cgi?id=194893
3806
3807         Reviewed by Daniel Bates.
3808 '
3809         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3810
3811 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3812
3813         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3814         https://bugs.webkit.org/show_bug.cgi?id=195229
3815         <rdar://problem/48520362>
3816
3817         Reviewed by Chris Dumez.
3818
3819         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3820         (TEST):
3821
3822 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3823
3824         Add a system trace scope for event region building
3825         https://bugs.webkit.org/show_bug.cgi?id=195226
3826
3827         Reviewed by Jon Lee.
3828
3829         This trace scope measures the time spend converting element rects into Region objects,
3830         which can be large on some pages.
3831
3832         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3833
3834         * Tracing/SystemTracePoints.plist:
3835
3836 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3837
3838         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3839         https://bugs.webkit.org/show_bug.cgi?id=194612
3840
3841         Reviewed by Alex Christensen.
3842
3843         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3844         Just test the new string-processing function and don't touch the actual environment.
3845         (Test cases are all as before, but based on operator== instead of strcmp.)
3846
3847 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3848
3849         [ews-app] Update primary keys for handling multiple Buildbot instances
3850         https://bugs.webkit.org/show_bug.cgi?id=195120
3851
3852         Reviewed by Stephanie Lewis.
3853
3854         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3855         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3856         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3857
3858         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3859         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3860         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3861         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3862         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3863         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3864
3865 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3866
3867         [WinCairo] Enable service worker
3868         https://bugs.webkit.org/show_bug.cgi?id=188318
3869
3870         Reviewed by Youenn Fablet.
3871
3872         * DumpRenderTree/DumpRenderTreePrefix.h:
3873         * TestWebKitAPI/PlatformWin.cmake:
3874         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3875         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3876         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3877
3878 2019-03-01  Justin Fan  <justin_fan@apple.com>
3879
3880         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3881         https://bugs.webkit.org/show_bug.cgi?id=195191
3882
3883         Rubber-stamped by Dean Jackson.
3884
3885         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3886
3887         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3888
3889 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3890
3891         Unreviewed, fix lldb webkitpy tests
3892         https://bugs.webkit.org/show_bug.cgi?id=194375
3893
3894         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3895
3896         * lldb/lldb_webkit.py:
3897         (WTFStringImplProvider.is_8bit):
3898
3899 2019-02-28  David Quesada  <david_quesada@apple.com>
3900
3901         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3902         https://bugs.webkit.org/show_bug.cgi?id=195121
3903         rdar://problem/48450302
3904
3905         Reviewed by Alex Christensen.
3906
3907         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3908         configurations where the 'download' attribute is absent, blank, or populated
3909         with a filename, and where the anchor element is same-origin or cross-origin
3910         (meaning the 'download' attribute shouldn't be honored).
3911
3912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3913         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3914         (-[NavigationActionTestDelegate init]):
3915         (-[NavigationActionTestDelegate navigationAction]):
3916         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3917         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3918         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3919         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3920         (TEST):
3921
3922 2019-02-28  Antoine Quint  <graouts@apple.com>
3923
3924         Enable the Pointer Events runtime flag by default
3925         https://bugs.webkit.org/show_bug.cgi?id=195156
3926
3927         Reviewed by Dean Jackson.
3928
3929         * DumpRenderTree/mac/DumpRenderTree.mm:
3930         (enableExperimentalFeatures):
3931
3932 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3933
3934         Several PasteImage API tests are flaky
3935         https://bugs.webkit.org/show_bug.cgi?id=195160
3936
3937         Reviewed by Tim Horton.
3938
3939         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3940         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3941         listening for a "load" event after image load is already complete.
3942
3943         To address this, make these tests first register a "load" event handler, then run script to insert an image
3944         element into the document, and finally wait until the load event is observed before checking image size.
3945
3946         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3947
3948 2019-02-28  Chris Dumez  <cdumez@apple.com>
3949
3950         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3951         https://bugs.webkit.org/show_bug.cgi?id=195107
3952
3953         Reviewed by Alex Christensen.
3954
3955         Give some time for the zoom level to get restored.
3956
3957         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3958
3959 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3960
3961         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3962         https://bugs.webkit.org/show_bug.cgi?id=194958
3963
3964         Reviewed by Geoffrey Garen.
3965
3966         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3967         (TEST):
3968
3969 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3970
3971         [ews-app] Update method to save build to handle builder_display_name
3972         https://bugs.webkit.org/show_bug.cgi?id=195047
3973
3974         Reviewed by Dewei Zhu.
3975
3976         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3977         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3978
3979 2019-02-28  Justin Fan  <justin_fan@apple.com>
3980
3981         [Web GPU] Enable Web GPU only on 64-bit
3982         https://bugs.webkit.org/show_bug.cgi?id=195139
3983
3984         Because Metal is only supported on 64 bit apps.
3985
3986         Unreviewed build fix.
3987
3988         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3989
3990 2019-02-27  Youenn Fablet  <youenn@apple.com>
3991
3992         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3993         https://bugs.webkit.org/show_bug.cgi?id=194959
3994
3995         Reviewed by Chris Dumez.
3996
3997         Spin loop until getting the condition to remove flakiness.
3998
3999         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4000
4001 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4002
4003         [ews-build] Buildbot should include builder_display_name in the build events
4004         https://bugs.webkit.org/show_bug.cgi?id=195045
4005
4006         Reviewed by Dewei Zhu.
4007
4008         * BuildSlaveSupport/ews-build/events.py:
4009         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4010         buildername to builder_name to be consistent in naming style.
4011         (Events.buildFinished): Ditto.
4012
4013 2019-02-27  Chris Dumez  <cdumez@apple.com>
4014
4015         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4016         https://bugs.webkit.org/show_bug.cgi?id=194480
4017
4018         Reviewed by Brady Eidson.
4019
4020         Update existing API test to make it more likely to reproduce the issue.
4021
4022         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4023
4024 2019-02-27  Brady Eidson  <beidson@apple.com>
4025
4026         Universal links from Google search results pages don't open the app.
4027         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4028
4029         Reviewed by Geoffrey Garen.
4030
4031         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4032         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4033         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4034         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4035
4036 2019-02-27  Chris Dumez  <cdumez@apple.com>
4037
4038         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4039         https://bugs.webkit.org/show_bug.cgi?id=195102
4040
4041         Reviewed by Geoffrey Garen.
4042
4043         If the number of processes is not yet what we expect, wait a bit and check again to give
4044         processes some time to exit.
4045
4046         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4047
4048 2019-02-27  Chris Dumez  <cdumez@apple.com>
4049
4050         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4051         https://bugs.webkit.org/show_bug.cgi?id=194545
4052
4053         Reviewed by Brady Eidson.
4054
4055         Make sure the test navigates forward and then back only once. Previously, navigating
4056         back would trigger a navigation again in a timer.
4057
4058         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4059
4060 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4061
4062         High Sierra Debug JSC test queue should use faster hardware
4063         https://bugs.webkit.org/show_bug.cgi?id=194603
4064
4065         Rubber-stamped by Alexey Proskuryakov.
4066
4067         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4068
4069         * BuildSlaveSupport/build.webkit.org-config/config.json:
4070         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4071         (BubbleQueueServer):
4072         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4073         (WebKitBuildbot):
4074         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4075         * QueueStatusServer/config/queues.py:
4076         * Scripts/webkitpy/common/config/ews.json:
4077         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4078         (test_ews_name):
4079
4080 2019-02-27  John Wilander  <wilander@apple.com>
4081
4082         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4083         https://bugs.webkit.org/show_bug.cgi?id=195071
4084         <rdar://problem/48417690>
4085
4086         Reviewed by Alex Christensen and Brent Fulgham.
4087
4088         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4089         (TestWebKitAPI::createURL):
4090             Convenience function.
4091         (TestWebKitAPI::TEST):
4092             WebCore::AdClickAttribution now takes a URL when creating Source and
4093             Destination.
4094         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4095         (TestWebKitAPI::TEST):
4096             WebCore::AdClickAttribution now takes a URL when creating Source and
4097             Destination.
4098
4099 2019-02-27  Antoine Quint  <graouts@apple.com>
4100
4101         Support Pointer Events on macOS
4102         https://bugs.webkit.org/show_bug.cgi?id=195008
4103         <rdar://problem/47454419>
4104
4105         Reviewed by Dean Jackson.
4106
4107         * DumpRenderTree/mac/DumpRenderTree.mm:
4108         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4109         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4110
4111 2019-02-26  Mark Lam  <mark.lam@apple.com>
4112
4113         Remove remaining poisoning code.
4114         https://bugs.webkit.org/show_bug.cgi?id=194138
4115
4116         Reviewed by Saam Barati.
4117
4118         * TestWebKitAPI/CMakeLists.txt:
4119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4120         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4121         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4122         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4123         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4124         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4125         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4126
4127 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4128
4129         Move ephemeral local storage from WebProcess to UIProcess
4130         https://bugs.webkit.org/show_bug.cgi?id=195074
4131         <rdar://problem/47937975>
4132
4133         Reviewed by Geoff Garen.
4134
4135         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4136
4137 2019-02-20  Jer Noble  <jer.noble@apple.com>
4138
4139         [Cocoa] Media elements will restart network buffering just before suspending
4140         https://bugs.webkit.org/show_bug.cgi?id=193691
4141
4142         Reviewed by Eric Carlson.
4143
4144         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4145         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4146         (TEST):
4147
4148 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4149
4150         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4151         https://bugs.webkit.org/show_bug.cgi?id=191652
4152
4153         Reviewed by Alex Christensen.
4154
4155         Fix WinCairo MiniBrowser behavior of authentication dialog.
4156
4157         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4158         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4159
4160 2019-02-26  Youenn Fablet  <youenn@apple.com>
4161
4162         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4163         https://bugs.webkit.org/show_bug.cgi?id=195028
4164         <rdar://problem/48243733>
4165
4166         Reviewed by Eric Carlson.
4167
4168         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4169
4170 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4171
4172         [WPE] Add API for webview background color configuration
4173         https://bugs.webkit.org/show_bug.cgi?id=192305
4174
4175         Reviewed by Michael Catanzaro.
4176
4177         * MiniBrowser/wpe/main.cpp:
4178         (main): Add a new option to configure the webview background
4179         color. Example: --bg-color=transparent.
4180         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4181         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4182         (beforeAll): Ditto.
4183
4184 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4185
4186         scalableNativeWebpageParameters() is not preserved on new page navigation.
4187         https://bugs.webkit.org/show_bug.cgi?id=194892
4188         <rdar://problem/47538280>
4189
4190         Reviewed by Wenson Hsieh.
4191         
4192         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4193
4194         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4195         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4196         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4197         (WTR::UIScriptController::allowsViewportShrinkToFit):
4198         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4199         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4200         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4201         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4202         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4203         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4204
4205 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4206
4207         [ews-app] Add model for handling multiple Buildbot instances
4208         https://bugs.webkit.org/show_bug.cgi?id=194863
4209
4210         Reviewed by Stephanie Lewis.
4211
4212         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4213
4214 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4215
4216         [ews-app] Remove BuilderMapping table
4217         https://bugs.webkit.org/show_bug.cgi?id=194961
4218
4219         Reviewed by Stephanie Lewis.
4220
4221         Store builder name directly in build table, instead of having a separate
4222         table for it.
4223
4224         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4225         * BuildSlaveSupport/ews-app/ews/models/build.py:
4226         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4227         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4228
4229 2019-02-25  John Wilander  <wilander@apple.com>
4230
4231         Introduce and adopt new class RegistrableDomain for eTLD+1
4232         https://bugs.webkit.org/show_bug.cgi?id=194791
4233         <rdar://problem/48179240>
4234
4235         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4236
4237         This patch adds an API test and replaces two instances of
4238         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4239
4240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4241         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4242         (TestWebKitAPI::TEST):
4243             Changed two strings to make sure the registrable domains are still considered
4244             invalid and pass the test.
4245         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4246         (TestWebKitAPI::TEST):
4247         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4248         (WTR::InjectedBundle::didReceiveMessageToPage):
4249
4250 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4251
4252         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4253         https://bugs.webkit.org/show_bug.cgi?id=195001
4254
4255         Reviewed by Carlos Garcia Campos.
4256
4257         API version 1.0 always includes the functionality previously guarded with
4258         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4259         unconditionally.
4260
4261         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4262         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4263         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4264         (WebViewTest::showInWindow): Ditto.
4265         (WebViewTest::hideView): Ditto.
4266         * wpe/backends/HeadlessViewBackend.cpp:
4267         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4268         * wpe/backends/ViewBackend.cpp:
4269         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4270         * wpe/backends/WindowViewBackend.cpp:
4271         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4272         WPE_BACKEND_CHECK_VERSION().
4273         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4274
4275 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4276
4277         [Flatpak] Add support for flatpak > 1.1.2
4278         https://bugs.webkit.org/show_bug.cgi?id=194088
4279
4280         Flatpak 1.2 is now out so we need to support that
4281         version now.
4282
4283         Reviewed by Michael Catanzaro.
4284
4285         * flatpak/flatpakutils.py:
4286         (check_flatpak):
4287         (FlatpakPackages.__init__):
4288         (FlatpakPackages.__detect_packages):
4289         (FlatpakPackages.__detect_packages.in):
4290         (FlatpakRepos.update):
4291
4292 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4293
4294         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4295         https://bugs.webkit.org/show_bug.cgi?id=194998
4296
4297         Reviewed by Carlos Garcia Campos.
4298
4299         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4300         to a Git checkout and using the latest commit containing various fixes
4301         and improvements.
4302
4303 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4304
4305         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4306         https://bugs.webkit.org/show_bug.cgi?id=194981
4307
4308         Reviewed by Žan Doberšek.
4309
4310         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4311         (TestWebKitAPI::TEST):
4312
4313 2019-02-23  Keith Miller  <keith_miller@apple.com>
4314
4315         Add new mac target numbers
4316         https://bugs.webkit.org/show_bug.cgi?id=194955
4317
4318         Reviewed by Tim Horton.
4319
4320         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4321         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4322         * MiniBrowser/Configurations/Base.xcconfig:
4323         * TestWebKitAPI/Configurations/Base.xcconfig:
4324         * WebKitTestRunner/Configurations/Base.xcconfig:
4325
4326 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4327
4328         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4329         https://bugs.webkit.org/show_bug.cgi?id=194846
4330
4331         Reviewed by Don Olmstead.
4332
4333         Added _search_paths() and _port_specific_expectations_files() for
4334         WinCairoPort.
4335
4336         * Scripts/webkitpy/port/win.py:
4337         (WinCairoPort.default_baseline_search_path):
4338         (WinCairoPort):
4339         (WinCairoPort._port_specific_expectations_files):
4340         (WinCairoPort._search_paths):
4341
4342 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4343
4344         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4345         https://bugs.webkit.org/show_bug.cgi?id=194963
4346
4347         Reviewed by Dean Jackson.
4348
4349         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4350         Do a `contains` check instead of `equals`, because in debug builds we
4351         put the GraphicsLayer pointer in a prefix.
4352
4353 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4354
4355         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4356         https://bugs.webkit.org/show_bug.cgi?id=194873
4357         <rdar://problem/46701974>
4358
4359         Reviewed by Tim Horton.
4360
4361         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4362
4363         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4364         (WTR::UIScriptController::menuRect const):
4365         (WTR::UIScriptController::isShowingMenu const):
4366         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4367         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4368         (WTR::UIScriptController::menuRect const):