Source/WebKit/chromium: [Chromium] DeviceOrientation cleanup
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
2
3         [WebKit] DeviceOrientation cleanup
4         https://bugs.webkit.org/show_bug.cgi?id=88406
5
6         Reviewed by Kent Tamura.
7
8         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
9
10         * DumpRenderTree/chromium/LayoutTestController.cpp:
11         (LayoutTestController::setMockDeviceOrientation):
12
13 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
14
15         webkitpy: add support for an ordered dict of test expectations
16         https://bugs.webkit.org/show_bug.cgi?id=87802
17
18         Reviewed by Ojan Vafai.
19
20         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
21         support a cascaded list of test expectations files. An easy way
22         to think of this is as an ordered dictionary of name -> contents
23         for files, where the name is usually a path on disk (I say
24         usually because we want to support other kinds of expectations
25         like the compile-time skips for unsupported features in
26         webkit.py, and we want to continue to support "in-memory" test
27         expectations that don't require a filesystem).
28
29         Conveniently there is an OrderedDict implementation in Python
30         2.7+ and it is available as a backport, so the first step in
31         adding this support is to use that implementation. Subsequent
32         patches will update the test_expectations.py module (and other
33         callers) to access the dict directly.
34
35         This patch just changes the base internal implementation and
36         provides wrappers for compatibility. The derived ports
37         (WebKitPort, TestPort, etc.) still need to be updated.
38
39         * Scripts/webkitpy/layout_tests/port/base.py:
40         (Port._expectations_dict):
41         (Port.test_expectations):
42         (Port):
43         (Port._expectations_overrides_dict):
44         (Port.test_expectations_overrides):
45         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
46         (PortTestCase.test_expectations_ordering):
47         (PortTestCase):
48         (PortTestCase.test_expectations_overrides_ordering):
49         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
50         (OrderedDict):
51         (OrderedDict.__init__):
52         (OrderedDict.clear):
53         (OrderedDict.__setitem__):
54         (OrderedDict.__delitem__):
55         (OrderedDict.__iter__):
56         (OrderedDict.__reversed__):
57         (OrderedDict.popitem):
58         (OrderedDict.__reduce__):
59         (OrderedDict.__repr__):
60         (OrderedDict.copy):
61         (OrderedDict.fromkeys):
62
63 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
64
65         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
66
67         * gtk/run-api-tests:
68         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
69
70 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
71
72         nrwt should look in 'out' for binaries on chromium win to support ninja
73         https://bugs.webkit.org/show_bug.cgi?id=88273
74
75         Reviewed by Tony Chang.
76
77         This patch standardizes the search algorithm the chromium ports
78         use to figure out which driver to run. We will look in a
79         chromium location before a webkit location (e.g., in
80         Source/WebKit/chromium/out before out/) and we will look in the
81         "legacy" directory (xcodebuild) before the directory ninja uses
82         (out).
83
84         Unfortunately due to the way the test code is set up testing the
85         properly requires some duplication of test code. I will fix that
86         in a followup patch.
87
88         * Scripts/webkitpy/layout_tests/port/chromium.py:
89         (ChromiumPort):
90         (ChromiumPort._static_build_path):
91         (ChromiumPort._build_path):
92         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
93         (ChromiumLinuxPort):
94         (ChromiumLinuxPort._determine_driver_path_statically):
95         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
96         (ChromiumLinuxPortTest.test_build_path):
97         (ChromiumLinuxPortTest):
98         (ChromiumLinuxPortTest.test_driver_name_option):
99         (ChromiumLinuxPortTest.path_to_image_diff):
100         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
101         (ChromiumMacPort):
102         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
103         (ChromiumMacPortTest.test_build_path):
104         (ChromiumMacPortTest):
105         (ChromiumMacPortTest.test_driver_name_option):
106         (ChromiumMacPortTest.path_to_image_diff):
107         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
108         (ChromiumPortTest.test_overrides_and_builder_names):
109         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
110         (ChromiumWinPort):
111         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
112         (ChromiumWinTest.test_build_path):
113         (ChromiumWinTest.test_operating_system):
114         (ChromiumWinTest):
115         (ChromiumWinTest.test_driver_name_option):
116         (ChromiumWinPortTest.path_to_image_diff):
117         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
118         (PortTestCase.assert_build_path):
119
120 2012-06-06  Jessie Berlin  <jberlin@apple.com>
121
122         Remove very red Windows WebKit2 testers
123         https://bugs.webkit.org/show_bug.cgi?id=88452
124
125         Reviewed by Steve Falkenburg.
126
127         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
128         need to focus on getting the WK1 testers green.
129
130         * BuildSlaveSupport/build.webkit.org-config/config.json:
131
132 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
133
134         get rebaselining tools to kinda work with the skia overrides file
135         https://bugs.webkit.org/show_bug.cgi?id=88456
136
137         Reviewed by Ryosuke Niwa.
138
139         Update rebaseline-expectations so that we read in the overrides
140         when looking for tests to rebaseline, but don't read in the
141         overrides when we are writing the expectations file back out.
142         This prevents the overrides from getting written into the main
143         file. This is kind of a hack but will have to do until we
144         support multiple expectations files properly.
145
146         * Scripts/webkitpy/tool/commands/rebaseline.py:
147         (RebaselineExpectations._expectations):
148         (RebaselineExpectations._update_expectations_file):
149         (RebaselineExpectations._tests_to_rebaseline):
150         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
151         (test_overrides_are_included_correctly):
152
153 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
154
155         webkitpy: two manager_worker_broker_unittest tests are broken
156         https://bugs.webkit.org/show_bug.cgi?id=88445
157
158         Reviewed by Ojan Vafai.
159
160         These tests were never updated when we removed the
161         --worker-model argument, and we were passing 'inline' instead of
162         1 (for the number of workers) :(. As a result we were creating
163         multiprocessing queues unnecessarily and that was failing on cygwin.
164
165         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
166         (InterfaceTest.test_managerconnection_is_abstract):
167         (InterfaceTest.test_workerconnection_is_abstract):
168
169 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
170
171         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
172         https://bugs.webkit.org/show_bug.cgi?id=87406
173
174         Reviewed by Dirk Pranke.
175
176         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
177         (TestExpectations.__init__):
178         * Scripts/webkitpy/tool/commands/rebaseline.py:
179         (RebaselineTest._update_expectations_file):
180         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
181         (test_rebaseline_does_not_include_overrides):
182
183 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
184
185         webkitpy: perf tests unit tests fail on chromium win
186         https://bugs.webkit.org/show_bug.cgi?id=88279
187
188         Reviewed by Ryosuke Niwa.
189
190         I'm seeing weird failures running the unit tests in my win32
191         checkout, and we don't really expect webpagereplay to work on
192         win32 anyway, so I'm skipping the import of that module for now
193         and adding a warning.
194
195         * Scripts/run-perf-tests:
196         * Scripts/webkitpy/performance_tests/perftest.py:
197
198 2012-06-06  Yong Li <yoli@rim.com>
199
200         Unreviewed. Update my email address in committers.py.
201
202         * Scripts/webkitpy/common/config/committers.py:
203
204 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
205
206         Add Robert Kroeger  to commiters.py
207         https://bugs.webkit.org/show_bug.cgi?id=88415
208
209         Unreviewed.
210
211         * Scripts/webkitpy/common/config/committers.py:
212
213 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
214
215         [EFL][DRT] http/tests/globalhistory testcases do not pass
216         https://bugs.webkit.org/show_bug.cgi?id=82579
217
218         Reviewed by Csaba Osztrogonác.
219
220         DRT has provided callbacks for ewk_view "global history delegate" signals.
221
222         * DumpRenderTree/efl/DumpRenderTree.cpp:
223         (isGlobalHistoryTest): Aux function to ident global history testcase.
224         (createLayoutTestController):
225         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
226         (DumpRenderTreeChrome::createView):
227         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
228         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
229         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
230         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
231         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
232         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
233         (DumpRenderTreeChrome):
234
235 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
236
237         [Qt] run-qtwebkit-tests hangs with -j1
238         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
239         This could happen due to an uncancelled timer after results were returned. This timer was
240         started only if --timeout was set.
241         https://bugs.webkit.org/show_bug.cgi?id=85475
242
243         Reviewed by Csaba Osztrogonác.
244
245         * Scripts/run-qtwebkit-tests:
246         (run_test):
247
248 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
249
250         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
251         https://bugs.webkit.org/show_bug.cgi?id=88327
252
253         Reviewed by Kenneth Rohde Christiansen.
254
255         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
256         * MiniBrowser/qt/icons/contents_width.png: Added.
257         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
258         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
259
260 2012-06-05  Jon Lee  <jonlee@apple.com>
261
262         Buildbot fix.
263
264         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
265         in the function. Store in a local variable.
266         (loadBuilderConfig):
267
268 2012-06-05  Jon Lee  <jonlee@apple.com>
269
270         Buildbot fix.
271
272         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
273         (loadBuilderConfig):
274
275 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
276
277         webkitpy: clean up win-specific path handling and tests
278         https://bugs.webkit.org/show_bug.cgi?id=88281
279
280         Reviewed by Adam Barth.
281
282         There was a bunch of inconsistent logic for handling path
283         conversions for win32 and cygwin paths due to us sometimes
284         looking at sys.platform and sometimes using mock hosts. This
285         patch cleans everything up so that we are required to pass
286         PlatformInfo objects to the path module and stop trying to do
287         different things when running on cygwin or win32 hosts (except
288         in the path_unittest module itself).
289
290         This may slightly reduce test coverage for the win32 code paths
291         but will be a lot easier to follow and maintain.
292
293         * Scripts/webkitpy/common/system/path.py:
294         (abspath_to_uri):
295         (_convert_path):
296         * Scripts/webkitpy/common/system/path_unittest.py:
297         (AbspathTest.platforminfo):
298         (AbspathTest.test_abspath_to_uri_cygwin):
299         (AbspathTest.test_abspath_to_uri_unixy):
300         (AbspathTest.test_abspath_to_uri_win):
301         (AbspathTest.test_abspath_to_uri_escaping_unixy):
302         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
303         (AbspathTest.test_stop_cygpath_subprocess):
304         * Scripts/webkitpy/common/system/platforminfo.py:
305         (PlatformInfo.__init__):
306         (PlatformInfo.is_cygwin):
307         * Scripts/webkitpy/common/system/platforminfo_mock.py:
308         (MockPlatformInfo.is_cygwin):
309         * Scripts/webkitpy/layout_tests/port/base.py:
310         (Port.to.show_results_html_file):
311         * Scripts/webkitpy/layout_tests/port/driver.py:
312         (Driver.test_to_uri):
313         (Driver.uri_to_test):
314         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
315         (DriverTest.test_test_to_uri):
316         (DriverTest.test_uri_to_test):
317         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
318         (MockDRTPortTest.make_port):
319         (MockDRTTest.input_line):
320         (MockChromiumDRTTest.test_pixeltest__fails):
321         * Scripts/webkitpy/layout_tests/port/test.py:
322         * Scripts/webkitpy/layout_tests/port/win.py:
323         (WinPort.show_results_html_file):
324         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
325         (MainTest.test_unexpected_failures):
326         (MainTest.test_results_directory_absolute):
327         (MainTest.test_results_directory_default):
328         (MainTest.test_results_directory_relative):
329
330 2012-06-05  Jon Lee  <jonlee@apple.com>
331
332         Workaround buildbot bug when merging build requests.
333         https://bugs.webkit.org/show_bug.cgi?id=88158
334
335         Reviewed by Mark Rowe.
336
337         For expediency, we still want testers to pick the latest build to test, but to ensure
338         that the builders are reporting the correct revision number, we should let the building bots
339         run as they normally would. That is, the builder picks the oldest revision, and merges
340         subsequent requests. Because merged requests get appended to the list of changes for a given
341         build, the last change in that list is also the latest change. When we used pickLatestBuild
342         for the builders, this was not the case (it would always report the penultimate change).
343
344         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
345
346         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
347         for all Apple builders.
348         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
349         the latest build to run.
350         (loadBuilderConfig):
351
352 2012-06-05  Jessie Berlin  <jberlin@apple.com>
353
354         [Win] DumpRenderTree should call resetInternalsObject
355         https://bugs.webkit.org/show_bug.cgi?id=88346
356
357         Reviewed by Simon Fraser.
358
359         Invoke it on Windows in the same place it is invoked on Mac.
360
361         * DumpRenderTree/win/DumpRenderTree.cpp:
362         (resetWebViewToConsistentStateBeforeTesting):
363
364 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
365
366         [GTK] Fix two more memory leaks in DRT
367         https://bugs.webkit.org/show_bug.cgi?id=88255
368
369         Reviewed by Martin Robinson.
370
371         Fixed memory leaks in GTK's DRT code.
372
373         * DumpRenderTree/gtk/DumpRenderTree.cpp:
374         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
375         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
376         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
377         (createBitmapContextFromWebView): Free the cairo surface.
378
379 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
380
381         [Qt] Building when a top directory is named Source
382         https://bugs.webkit.org/show_bug.cgi?id=77727
383
384         Reviewed by Tor Arne Vestbø.
385
386         Change regex to only replace the last instance of OUT_PWD.
387
388         * qmake/mkspecs/features/default_pre.prf:
389
390 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
391
392         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
393         https://bugs.webkit.org/show_bug.cgi?id=73176
394
395         Reviewed by Adam Barth.
396
397         Two more APIs are added in Custom Scheme Handler specification.
398         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
399         One is 'isProtocolHandlerRegistered' to query whether the specific URL
400         is registered or not.
401         The other is 'unregisterProtocolHandler' to remove the registered URL.
402
403         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
404
405 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
406
407         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
408         https://bugs.webkit.org/show_bug.cgi?id=83879
409
410         Reviewed by Carlos Garcia Campos.
411
412         Make minibrowser connect to the new 'permission requests' signal
413         to allow users handle the Geolocation permission requests.
414
415         * MiniBrowser/gtk/BrowserWindow.c:
416         (geolocationRequestDialogCallback): Callback for the dialog asking
417         the user for allowing or not geolocation permission requests.
418         (webViewDecidePermissionRequest): Launch a dialog to ask the user
419         whether to allow or deny geolocation permission requests.
420         (browserWindowConstructed): Connect to 'permission-request' signal.
421
422 2012-06-04  Chase Phillips  <cmp@google.com>
423
424         Make a builder group support+expect multiple loads.
425         https://bugs.webkit.org/show_bug.cgi?id=88260
426
427         Change BuilderGroup to allow expecting multiple
428         loads.  This allows merging results for a given set
429         of builders into one group.
430
431         Add a test that verifies that the group count
432         increments correctly based on successful and failed
433         list loads.
434
435         Reviewed by Ojan Vafai.
436
437         * TestResultServer/static-dashboards/builders.js:
438         (BuilderGroup):
439         (BuilderGroup.prototype.setbuilder):
440         (BuilderGroup.prototype.append):
441         (BuilderGroup.prototype.loaded):
442         (requestBuilderList.xhr.onload):
443         (requestBuilderList.xhr.onerror):
444         (onErrorLoadingBuilderList):
445         (loadBuildersList):
446         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
447         (test):
448         * TestResultServer/static-dashboards/run-unittests.html:
449
450 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
451
452         Python test fix attempt for Chromium Windows.
453
454         * Scripts/webkitpy/layout_tests/port/driver.py:
455         (Driver.uri_to_test):
456
457 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
458
459         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
460         https://bugs.webkit.org/show_bug.cgi?id=88243
461
462         Reviewed by Adam Barth.
463
464         * qmake/mkspecs/features/features.prf:
465
466 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
467
468         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
469         https://bugs.webkit.org/show_bug.cgi?id=88280
470
471         Unreviewed, build fix.
472
473         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
474         (TestServerProcess.test_basic):
475
476 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
477
478         test-webkitpy is hanging under cygwin
479         https://bugs.webkit.org/show_bug.cgi?id=88269
480
481         Reviewed by Ryosuke Niwa.
482
483         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
484         so we need to skip any tests that use it.
485
486         * Scripts/webkitpy/common/system/executive.py:
487         (Executive.run_in_parallel):
488         * Scripts/webkitpy/common/system/executive_unittest.py:
489         (ExecutiveTest.test_run_in_parallel):
490
491 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
492
493         test-webkitpy is failing on win32 after r115054
494         https://bugs.webkit.org/show_bug.cgi?id=88264
495
496         Reviewed by Ryosuke Niwa.
497
498         The failing http_server test was improperly suppressed (the
499         tuple was missing a comma, and so wasn't a tuple at all, just a
500         string) and so we were skipping *all* tests on win32. The right
501         way to skip a single test is to disable it inside the test
502         itself.
503
504         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
505         (TestHttpServer.test_start_cmd):
506         * Scripts/webkitpy/test/test_finder.py:
507         (TestFinder._default_names):
508         * Scripts/webkitpy/test/main.py:
509         (Tester.run): Add error message if we don't find any tests to run.
510         * Scripts/webkitpy/test/main_unittest.py:
511             
512
513 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
514
515         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
516         https://bugs.webkit.org/show_bug.cgi?id=88215
517
518         Reviewed by Martin Robinson.
519
520         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
521         for newly allocated strings.
522
523         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
524         (attributeSetToString):
525         (AccessibilityUIElement::allAttributes):
526
527 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
528
529         [GTK] Memory leaks in DumpRenderTree.cpp
530         https://bugs.webkit.org/show_bug.cgi?id=88213
531
532         Reviewed by Martin Robinson.
533
534         Fixed memory leaks in DumpRenderTree.
535
536         * DumpRenderTree/gtk/DumpRenderTree.cpp:
537         (appendString): Accepts const gchar* as the second argument.
538         (dumpFramesAsText): Free the string returned by g_strdup_printf().
539         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
540
541 2012-06-04  David Dorwin  <ddorwin@chromium.org>
542
543         Enable Chromium media player to instantiate a plugin
544         https://bugs.webkit.org/show_bug.cgi?id=87399
545
546         Reviewed by Kent Tamura.
547
548         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
549
550         * DumpRenderTree/chromium/WebViewHost.cpp:
551         (WebViewHost::createPopupMenu):
552
553 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
554
555         [GTK][WK2] Implement geolocation provider for the GTK port
556         https://bugs.webkit.org/show_bug.cgi?id=83877
557
558         Reviewed by Carlos Garcia Campos.
559
560         * gtk/generate-gtkdoc:
561         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
562
563 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
564
565         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
566         https://bugs.webkit.org/show_bug.cgi?id=87668
567
568         Reviewed by Ryosuke Niwa.
569
570         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
571         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
572         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
573
574         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
575         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
576
577 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
578
579         [EFL] Refactor ewk_view_context_paint code.
580         https://bugs.webkit.org/show_bug.cgi?id=85588
581
582         Reviewed by Hajime Morita.
583
584         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
585
586 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
587
588         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
589         https://bugs.webkit.org/show_bug.cgi?id=87869
590
591         Reviewed by Andreas Kling.
592
593         Replace %lld by PRId64 macro to print an int64_t value and silent a
594         compilation warning on 64-Bit.
595
596         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
597         (onExceededApplicationCacheQuota):
598
599 2012-06-03  Varun Jain  <varunjain@google.com>
600
601         [chromium] Add new gesture type (two finger tap) that triggers context menu.
602         https://bugs.webkit.org/show_bug.cgi?id=88173
603
604         Reviewed by Adam Barth.
605
606         * DumpRenderTree/chromium/EventSender.cpp:
607         (EventSender::EventSender):
608         (EventSender::gestureTwoFingerTap):
609         (EventSender::gestureEvent):
610         * DumpRenderTree/chromium/EventSender.h:
611         (EventSender):
612
613 2012-06-02  Zeno Albisser  <zeno@webkit.org>
614
615         Fix and enable WebGL for WebKit2 on Qt.
616         https://bugs.webkit.org/show_bug.cgi?id=86214
617
618         Enable WebGL by default for Qt MiniBrowser.
619
620         Reviewed by Noam Rosenthal.
621
622         * MiniBrowser/qt/qml/BrowserWindow.qml:
623
624 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
625
626         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
627         https://bugs.webkit.org/show_bug.cgi?id=88164
628
629         Reviewed by Kentaro Hara.
630
631         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
632         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
633
634         * Scripts/VCSUtils.pm:
635         (adjustPathForRecentRenamings):
636         (fixChangeLogPatch):
637
638 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
639
640         Rename test_expectations.txt to TestExpectations
641         https://bugs.webkit.org/show_bug.cgi?id=86690
642
643         Reviewed by Dirk Pranke.
644
645         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
646         We can the code to read test_expectations.txt once we've successfully transitioned.
647
648         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
649         (TestExpectationParser._check_path_does_not_exist):
650         (TestExpectationParser._tokenize):
651         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
652         * Scripts/webkitpy/layout_tests/port/base.py:
653         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
654         test_expectations.txt if one exists and the path to TestExpectations otherwise.
655         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
656         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
657         virtual.
658         * Scripts/webkitpy/layout_tests/port/chromium.py:
659         (ChromiumPort.path_from_chromium_base):
660         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
661         (ChromiumAndroidPort.test_expectations):
662         * Scripts/webkitpy/layout_tests/port/test.py:
663         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
664         (TestPort.__init__):
665         * Scripts/webkitpy/layout_tests/port/webkit.py:
666         (WebKitPort.baseline_search_path):
667         (WebKitPort.test_expectations):
668         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
669         tests to base as a follow up.
670         (WebKitPortTest.test_path_to_test_expectations_file):
671         (test_test_expectations):
672         (test_legacy_test_expectations):
673         * Scripts/webkitpy/style/checker.py:
674         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
675         with one for TestExpectations.
676         * Scripts/webkitpy/style/checkers/test_expectations.py:
677         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
678         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
679         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
680         test_expectations.txt.
681         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
682         (TestExpectationsTestCase.assert_lines_lint):
683         * Scripts/webkitpy/tool/commands/queries.py:
684         (PrintExpectations.__init__):
685         * Scripts/webkitpy/tool/commands/rebaseline.py:
686         (RebaselineExpectations):
687         * Scripts/webkitpy/tool/steps/commit.py:
688         (Commit._check_test_expectations):
689         * Scripts/webkitpy/tool/steps/commit_unittest.py:
690         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
691         (CommitTest.test_check_test_expectations): For TestExpectations.
692         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
693         * TestResultServer/static-dashboards/dashboard_base.js:
694         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
695         Error only when neither exists.
696         * TestResultServer/static-dashboards/flakiness_dashboard.js:
697         (processMissingAndExtraExpectations):
698         (htmlForTestsWithExpectationsButNoFailures):
699         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
700
701 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
702
703         Remove dependency from ImageDiff to WTF
704         https://bugs.webkit.org/show_bug.cgi?id=88147
705
706         Reviewed by Adam Barth.
707
708         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
709
710 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
711
712         NRWT seems to leak (more?) temp dirs
713         https://bugs.webkit.org/show_bug.cgi?id=88126
714
715         Re-land r119297 with chromium fix (weren't calling the
716         super() method if not in --test-shell mode in start().
717         Add unit tests to chromium_unittest as well to check.
718
719         * Scripts/webkitpy/layout_tests/port/chromium.py:
720         (ChromiumDriver.start):
721         * Scripts/webkitpy/layout_tests/port/webkit.py:
722         (WebKitDriver.__del__):
723         (WebKitDriver._start):
724         (WebKitDriver.run_test):
725         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
726         (WebKitDriverTest.test_check_for_driver_crash):
727         (WebKitDriverTest.test_stop_cleans_up_properly):
728         (WebKitDriverTest):
729         (WebKitDriverTest.test_two_starts_cleans_up_properly):
730         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
731         (ChromiumDriverTest.test_stop_cleans_up_properly):
732         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
733
734 2012-06-01  Tim Horton  <timothy_horton@apple.com>
735
736         Lots of "failed download-built-product" on Apple bots
737         https://bugs.webkit.org/show_bug.cgi?id=88158
738
739         Reviewed by Jessie Berlin.
740         
741         Disable mergeRequests on all Apple builders. This is a speculative fix.
742
743         * BuildSlaveSupport/build.webkit.org-config/config.json:
744
745 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
746
747         Unreviewed, rolling out r119297.
748         http://trac.webkit.org/changeset/119297
749         https://bugs.webkit.org/show_bug.cgi?id=88156
750
751         May have broken Chromium bots (Requested by rniwa on #webkit).
752
753         * Scripts/webkitpy/layout_tests/port/webkit.py:
754         (WebKitDriver.__del__):
755         (WebKitDriver.run_test):
756         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
757         (WebKitDriverTest.test_check_for_driver_crash):
758         (WebKitDriverTest.test_stop_cleans_up_properly):
759
760 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
761
762         nrwt seems to leak tmpdirs
763         https://bugs.webkit.org/show_bug.cgi?id=88126
764
765         Reviewed by Ojan Vafai.
766
767         Fix leak possibly introduced in r118979 - we now will
768         make sure we clean up any stale temp directories during the
769         start routine and attempt to clean up again in __del__. It
770         turns out that asserting in __del__ logs a message but is
771         caught by the runtime, so it's mostly useless.
772
773         * Scripts/webkitpy/layout_tests/port/webkit.py:
774         (WebKitDriver.__del__):
775         (WebKitDriver._start):
776         (WebKitDriver.run_test):
777         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
778         (WebKitDriverTest.test_check_for_driver_crash):
779         (WebKitDriverTest.test_stop_cleans_up_properly):
780         (WebKitDriverTest):
781         (WebKitDriverTest.test_two_starts_cleans_up_properly):
782
783 2012-06-01  Michael Saboff  <msaboff@apple.com>
784
785         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
786         https://bugs.webkit.org/show_bug.cgi?id=88109
787
788         Reviewed by Geoffrey Garen.
789
790         Additional test case.
791
792         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
793         (TestWebKitAPI::TEST):
794
795 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
796
797         [Qt] Use -Werror only in developer builds
798
799         Rubber-stamped by Tor Arne Vestbø.
800
801         In production builds -Werror with custom toolchains and wierd system
802         headers, -Werror is of no use and just creates confusion. So use it
803         only if Qt is configured with -developer-build.
804
805         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
806         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
807         only if qt_developer_build is set.
808
809 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
810
811         [watchlist] Add myself to loader and v8 bindings changes
812         https://bugs.webkit.org/show_bug.cgi?id=88112
813
814         Reviewed by Adam Barth.
815
816         * Scripts/webkitpy/common/config/watchlist:
817
818 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
819
820         Adding Jacky Jiang to committers.py
821         https://bugs.webkit.org/show_bug.cgi?id=88122
822
823         Reviewed by Rob Buis.
824
825         Adding myself to committers.py as a Committer.
826
827         * Scripts/webkitpy/common/config/committers.py:
828
829 2012-06-01  Jessie Berlin  <jberlin@apple.com>
830
831         Fix Windows build.
832
833         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
834
835 2012-06-01  Jessie Berlin  <jberlin@apple.com>
836
837         Windows WK2 MouseMoveAfterCrash API test failing
838         https://bugs.webkit.org/show_bug.cgi?id=69982
839
840         Disable the test on Windows to get the bots greener.
841
842         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
843         (TestWebKitAPI::TEST):
844
845 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
846
847         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
848         https://bugs.webkit.org/show_bug.cgi?id=86866
849
850         Reviewed by Adam Barth.
851
852         Catch new "intent,service,register" signal on the frame and print out
853         information about the Web Intent service in EFL's DumpRenderTree.
854
855         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
856         (DumpRenderTreeChrome::createView):
857         (DumpRenderTreeChrome::onFrameCreated):
858         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
859         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
860         (DumpRenderTreeChrome):
861
862 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
863
864         The ChangeLog parser cannot handle reviewers with initials in their name
865         https://bugs.webkit.org/show_bug.cgi?id=87864
866
867         Reviewed by Ryosuke Niwa.
868
869         Add support in the ChangeLog parser for reviewer names that have
870         initials in them.
871
872         * Scripts/webkitpy/common/checkout/changelog.py:
873         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
874         in the replacement string. This allows for matching the word characters before a
875         period, without totally throwing them away.
876         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
877         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
878         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
879
880 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
881
882         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
883         https://bugs.webkit.org/show_bug.cgi?id=86865
884
885         Reviewed by Adam Barth.
886
887         Add deliverWebIntent method to LayoutTestController and provide
888         implementation for EFL port.
889
890         * DumpRenderTree/LayoutTestController.cpp:
891         (deliverWebIntentCallback):
892         (LayoutTestController::staticFunctions):
893         * DumpRenderTree/LayoutTestController.h:
894         (LayoutTestController):
895         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
896         (LayoutTestController::deliverWebIntent):
897         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
898         (LayoutTestController::deliverWebIntent):
899         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
900         (LayoutTestController::deliverWebIntent):
901         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
902         (LayoutTestController::deliverWebIntent):
903         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
904         (LayoutTestController::deliverWebIntent):
905         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
906         (LayoutTestController::deliverWebIntent):
907
908 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
909
910         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
911
912         Reviewed by Simon Hausmann.
913
914         * Tools.pro:
915
916 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
917
918         Add public page loading performance tests using web-page-replay
919         https://bugs.webkit.org/show_bug.cgi?id=84008
920
921         Reviewed by Dirk Pranke.
922
923         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
924         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
925         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
926
927         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
928         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
929         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
930         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
931
932         * Scripts/webkitpy/layout_tests/port/driver.py:
933         (Driver.is_external_http_test): Added.
934         * Scripts/webkitpy/layout_tests/port/webkit.py:
935         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
936         * Scripts/webkitpy/performance_tests/perftest.py:
937         (PerfTest.__init__): Takes port.
938         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
939         (PerfTest):
940         (PerfTest.run): Calls run_single.
941         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
942         (ChromiumStylePerfTest.__init__):
943         (PageLoadingPerfTest.__init__):
944         (PageLoadingPerfTest.run):
945         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
946         (ReplayServer.__init__):
947         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
948         but it caused a dead lock on some web pages.
949         (ReplayServer.stop):
950         (ReplayServer.__del__):
951         (ReplayPerfTest):
952         (ReplayPerfTest.__init__):
953         (ReplayPerfTest._start_replay_server):
954         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
955         The subsequent runs of the same test will just use test.wpr.
956         (ReplayPerfTest.run_single):
957         (PerfTestFactory):
958         (PerfTestFactory.create_perf_test):
959         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
960         (MainTest.test_parse_output):
961         (MainTest.test_parse_output_with_failing_line):
962         (TestPageLoadingPerfTest.test_run):
963         (TestPageLoadingPerfTest.test_run_with_bad_output):
964         (TestReplayPerfTest):
965         (TestReplayPerfTest.ReplayTestPort):
966         (TestReplayPerfTest.ReplayTestPort.__init__):
967         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
968         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
969         (TestReplayPerfTest.ReplayTestPort._driver_class):
970         (TestReplayPerfTest.MockReplayServer):
971         (TestReplayPerfTest.MockReplayServer.__init__):
972         (TestReplayPerfTest.MockReplayServer.stop):
973         (TestReplayPerfTest._add_file):
974         (TestReplayPerfTest._setup_test):
975         (TestReplayPerfTest.test_run_single):
976         (TestReplayPerfTest.test_run_single.run_test):
977         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
978         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
979         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
980         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
981         (TestReplayPerfTest.test_prepare):
982         (TestReplayPerfTest.test_prepare.run_test):
983         (TestReplayPerfTest.test_prepare_calls_run_single):
984         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
985         (TestPerfTestFactory.test_regular_test):
986         (TestPerfTestFactory.test_inspector_test):
987         (TestPerfTestFactory.test_page_loading_test):
988         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
989         (PerfTestsRunner):
990         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
991         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
992         (PerfTestsRunner._collect_tests._is_test_file):
993         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
994         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
995         (create_runner):
996         (run_test):
997         (_tests_for_runner):
998         (test_run_test_set):
999         (test_run_test_set_kills_drt_per_run):
1000         (test_run_test_pause_before_testing):
1001         (test_run_test_set_for_parser_tests):
1002         (test_run_test_set_with_json_output):
1003         (test_run_test_set_with_json_source):
1004         (test_run_test_set_with_multiple_repositories):
1005         (test_run_with_upload_json):
1006         (test_upload_json):
1007         (test_upload_json.MockFileUploader.upload_single_text_file):
1008         (_add_file):
1009         (test_collect_tests):
1010         (test_collect_tests_with_multile_files):
1011         (test_collect_tests_with_multile_files.add_file):
1012         (test_collect_tests_with_skipped_list):
1013         (test_collect_tests_with_page_load_svg):
1014         (test_collect_tests_should_ignore_replay_tests_by_default):
1015         (test_collect_tests_with_replay_tests):
1016         (test_parse_args):
1017         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
1018         (AutoinstallImportHook.find_module):
1019         (AutoinstallImportHook._install_webpagereplay):
1020
1021 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
1022
1023         Support building the Android port of chromium with Ninja
1024         https://bugs.webkit.org/show_bug.cgi?id=87545
1025
1026         Reviewed by Adam Barth.
1027
1028         Ensures that shared libraries are looked up in a generator-agnostic
1029         way and that output is placed in the correct directory.
1030
1031         Depends on http://codereview.chromium.org/10386188/
1032
1033         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1034
1035 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
1036
1037         [Chromium] Chromium DRT should be able to load external resources
1038         https://bugs.webkit.org/show_bug.cgi?id=87893
1039
1040         Reviewed by Dirk Pranke.
1041
1042         Allow external resources to be loaded when the main frame's URL is also an external resource.
1043         This change is analogous to r118231 for Mac port.
1044
1045         * DumpRenderTree/chromium/WebViewHost.cpp:
1046         (blockRequest):
1047         (isLocalhost):
1048         (hostIsUsedBySomeTestsToGenerateError):
1049         (WebViewHost::willSendRequest):
1050
1051 2012-05-31  Anders Carlsson  <andersca@apple.com>
1052
1053         Build fixes.
1054
1055         Disable the C++11 extensions warning.
1056
1057         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1058         * TestWebKitAPI/Configurations/Base.xcconfig:
1059         * WebKitTestRunner/Configurations/Base.xcconfig:
1060
1061 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
1062
1063         [WK2] window.internals settings are not reset between tests
1064         https://bugs.webkit.org/show_bug.cgi?id=87783
1065
1066         Reviewed by Mihai Parparita.
1067
1068         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1069         (WTR::InjectedBundle::done): Call resetAfterTest().
1070
1071         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1072         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
1073         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
1074         This needs to be done after a tets, because the code assumes that there is an object
1075         with this name in global scope.
1076
1077         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1078
1079 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1080
1081         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
1082         https://bugs.webkit.org/show_bug.cgi?id=85006
1083
1084         Reviewed by Tor Arne Vestbø.
1085
1086         Added navigation_policy_decision implementation for DumpRenderTreeView.
1087         Added LayoutTestController::setCustomPolicyDelegate implementation.
1088         Modified LayoutTestController::waitForPolicyDelegate.
1089
1090         * DumpRenderTree/efl/DumpRenderTree.cpp:
1091         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1092         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1093         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
1094         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1095         (navigationTypeToString): aux function
1096         (onNavigationPolicyDecision): navigation_policy_decision implementation
1097         (drtViewAdd):
1098         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1099         (LayoutTestController::setCustomPolicyDelegate):
1100         (LayoutTestController::waitForPolicyDelegate):
1101
1102 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1103
1104         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
1105         https://bugs.webkit.org/show_bug.cgi?id=86195
1106
1107         Reviewed by Gustavo Noronha Silva.
1108
1109         Implement clearApplicationCacheForOrigin in EFL
1110         LayoutTestController.
1111
1112         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1113         (LayoutTestController::clearApplicationCacheForOrigin):
1114
1115 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1116
1117         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
1118         https://bugs.webkit.org/show_bug.cgi?id=87955
1119
1120         Reviewed by Simon Hausmann.
1121
1122         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1123         * DumpRenderTree/qt/EventSenderQt.cpp:
1124         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1125         * DumpRenderTree/qt/main.cpp:
1126         * QtTestBrowser/cookiejar.cpp:
1127         * QtTestBrowser/launcherwindow.cpp:
1128         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1129         * qmake/mkspecs/features/default_post.prf:
1130
1131 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
1132
1133         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
1134
1135         Rubber-stamped by Kenneth Rohde Christiansen.
1136
1137         * qmake/config.tests/libpng/libpng.pro:
1138
1139 2012-05-30  Peter Beverloo  <peter@chromium.org>
1140
1141         [Chromium] Automatically install 64-bit linker for Android
1142         https://bugs.webkit.org/show_bug.cgi?id=79780
1143
1144         Reviewed by Adam Barth.
1145
1146         Change the update-webkit-chromium script to check whether the 64-bit
1147         linker needs to be installed as part of the update process. The actual
1148         code for doing these checks and "installing" it has been added to the
1149         webkitdirs.pm script.
1150
1151         The linker itself is part of the third_party/aosp repository, which
1152         will be pulled in through the DEPS change.
1153
1154         * Scripts/update-webkit-chromium:
1155         * Scripts/webkitdirs.pm:
1156         (chromiumInstall64BitAndroidLinkerIfNeeded):
1157         (chromiumReplaceAndroidLinkerIfNeeded):
1158
1159 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1160
1161         https://bugs.webkit.org/show_bug.cgi?id=87803
1162         Layout tests often fail trying to stat nonexistent logs 
1163
1164         Reviewed by Dirk Pranke.
1165
1166         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
1167         try/catch block around accessing the logs as a precaution.
1168
1169         * Scripts/webkitpy/common/system/crashlogs.py:
1170         (CrashLogs._find_newest_log_darwin):
1171
1172 2012-05-30  Gavin Peters  <gavinp@chromium.org>
1173
1174         Add a LayoutTest for prerender remove after stop.
1175         https://bugs.webkit.org/show_bug.cgi?id=87860
1176
1177         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
1178         can be tested by LayoutTests now.
1179
1180         Reviewed by Adam Barth.
1181
1182         * DumpRenderTree/DumpRenderTree.gypi:
1183         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
1184         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
1185         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
1186         (MockWebPrerenderingSupport::add):
1187         (MockWebPrerenderingSupport::cancel):
1188         (MockWebPrerenderingSupport::abandon):
1189         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
1190         (MockWebPrerenderingSupport):
1191         * DumpRenderTree/chromium/TestShell.cpp:
1192         (TestShell::initialize):
1193         * DumpRenderTree/chromium/TestShell.h:
1194         (TestShell):
1195         * DumpRenderTree/chromium/WebViewHost.cpp:
1196         (WebViewHost::willAddPrerender):
1197         (WebViewHost::setWebWidget):
1198         * DumpRenderTree/chromium/WebViewHost.h:
1199         (WebViewHost):
1200
1201 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1202
1203         https://bugs.webkit.org/show_bug.cgi?id=87717
1204         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
1205
1206         Reviewed by Dirk Pranke.
1207
1208         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
1209         If there isn't a crash log found for the process add a message saying
1210         the process was unresponsive.
1211
1212         * Scripts/webkitpy/layout_tests/port/webkit.py:
1213         (WebKitDriver.__init__):
1214         (WebKitDriver._check_for_driver_crash):
1215         (WebKitDriver.run_test):
1216         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1217         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
1218         (WebKitDriverTest):
1219         (WebKitDriverTest.test_check_for_driver_crash):
1220         * WebKitTestRunner/TestController.cpp:
1221         (WTR):
1222         (WTR::TestController::runTest):
1223
1224 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1225
1226         https://bugs.webkit.org/show_bug.cgi?id=87714
1227         Mac crash logs can take a really long time to be written out.
1228
1229         Reviewed by Dirk Pranke.
1230
1231         Make a second pass looking for crash logs after the tests have completed running.
1232
1233         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1234         (use_trac_links_in_results_html):
1235         (Manager.run):
1236         * Scripts/webkitpy/layout_tests/port/base.py:
1237         (Port.repository_paths):
1238         (Port.look_for_new_crash_logs):
1239         * Scripts/webkitpy/layout_tests/port/mac.py:
1240         (MacPort.look_for_new_crash_logs):
1241         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1242         (test_get_crash_log):
1243         (test_look_for_new_crash_logs):
1244         (test_look_for_new_crash_logs.fake_time_cb):
1245
1246 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1247
1248         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
1249
1250         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1251         (LayoutWebViewEventHandler::OnAlertEvent):
1252         (LayoutWebViewEventHandler::OnConfirmEvent):
1253         (LayoutWebViewEventHandler):
1254         (LayoutWebViewEventHandler::OnPromptEvent):
1255         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1256         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
1257
1258 2012-05-30  Ojan Vafai  <ojan@chromium.org>
1259
1260         Only give lint errors for -expected.png png files that lack a checksum
1261         https://bugs.webkit.org/show_bug.cgi?id=87875
1262
1263         Reviewed by Tony Chang.
1264
1265         We have other pngs in the tree, e.g. for the inspector, that legitimately
1266         lack a checksum.
1267
1268         * Scripts/webkitpy/style/checkers/png.py:
1269         (PNGChecker.check):
1270         * Scripts/webkitpy/style/checkers/png_unittest.py:
1271         (PNGCheckerTest.test_check):
1272
1273 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
1274
1275         nrwt: seems to leak temp dirs
1276         https://bugs.webkit.org/show_bug.cgi?id=87795
1277
1278         Reviewed by Ojan Vafai.
1279
1280         There appears to be a bug where the chromium bots are creating
1281         temporary directories and not cleaning them up that started
1282         after the switch to WebKitDriver. It's possible that __del__
1283         wasn't getting called in a timely manner (or at all), and it's
1284         generally bad style to rely on __del__ being called, so this
1285         code changes things so that we create a temp dir in
1286         driver.start() and remove it in driver.stop(). We could be
1287         paranoid and leave the __del__ code in, but there doesn't seem
1288         to be much advantage to it. If there are bugs that result in
1289         drivers being started but not stopped, we have other problems.
1290
1291         * Scripts/webkitpy/common/system/filesystem_mock.py:
1292         (MockFileSystem.__init__):
1293         (MockFileSystem._mktemp):
1294         (MockFileSystem.mkdtemp):
1295         * Scripts/webkitpy/layout_tests/port/webkit.py:
1296         (WebKitDriver.__init__):
1297         (WebKitDriver._start):
1298         (WebKitDriver.stop):
1299         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1300         (WebKitDriverTest.test_check_for_driver_crash):
1301         (WebKitDriverTest):
1302         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
1303         (WebKitDriverTest.test_stop_cleans_up_properly):
1304
1305 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1306
1307         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
1308         https://bugs.webkit.org/show_bug.cgi?id=86841
1309
1310         Reviewed by Adam Barth.
1311
1312         Print the number of MessagePorts for each new intent in EFL's DRT.
1313         This output is expected by several Web Intents test cases.
1314
1315         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1316         (DumpRenderTreeChrome::onFrameIntentNew):
1317
1318 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1319
1320         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
1321
1322         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1323
1324 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1325
1326         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
1327         https://bugs.webkit.org/show_bug.cgi?id=87829
1328
1329         Reviewed by Adam Barth.
1330
1331         EFL's LayoutTestController now makes uses of the new helper method in
1332         DumpRenderTreeSupportEfl in order to send the intent response. This is
1333         now needed because the Ewk_Intent_Request postResult / postFailure
1334         methods were made private.
1335
1336         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1337         (LayoutTestController::sendWebIntentResponse):
1338
1339 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
1340
1341         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
1342         https://bugs.webkit.org/show_bug.cgi?id=86296
1343
1344         Reviewed by Tony Chang.
1345
1346         * DumpRenderTree/win/DRTDataObject.cpp: Added.
1347         (cfHDropFormat):
1348         (cfFileNameWFormat):
1349         (cfUrlWFormat):
1350         (WCEnumFormatEtc):
1351         (WCEnumFormatEtc::WCEnumFormatEtc):
1352         (WCEnumFormatEtc::QueryInterface):
1353         (WCEnumFormatEtc::AddRef):
1354         (WCEnumFormatEtc::Release):
1355         (WCEnumFormatEtc::Next):
1356         (WCEnumFormatEtc::Skip):
1357         (WCEnumFormatEtc::Reset):
1358         (WCEnumFormatEtc::Clone):
1359         (DRTDataObject::createInstance):
1360         (DRTDataObject::DRTDataObject):
1361         (DRTDataObject::~DRTDataObject):
1362         (DRTDataObject::QueryInterface):
1363         (DRTDataObject::AddRef):
1364         (DRTDataObject::Release):
1365         (DRTDataObject::GetData):
1366         (DRTDataObject::GetDataHere):
1367         (DRTDataObject::QueryGetData):
1368         (DRTDataObject::GetCanonicalFormatEtc):
1369         (DRTDataObject::SetData):
1370         (DRTDataObject::CopyMedium):
1371         (DRTDataObject::EnumFormatEtc):
1372         (DRTDataObject::DAdvise):
1373         (DRTDataObject::DUnadvise):
1374         (DRTDataObject::EnumDAdvise):
1375         (DRTDataObject::clearData):
1376         * DumpRenderTree/win/DRTDataObject.h: Added.
1377         (DRTDataObject):
1378         * DumpRenderTree/win/DRTDropSource.cpp: Added.
1379         (DRTDropSource::DRTDropSource):
1380         (DRTDropSource::~DRTDropSource):
1381         (DRTDropSource::QueryInterface):
1382         (DRTDropSource::AddRef):
1383         (DRTDropSource::Release):
1384         (DRTDropSource::createInstance):
1385         (DRTDropSource::QueryContinueDrag):
1386         (DRTDropSource::GiveFeedback):
1387         * DumpRenderTree/win/DRTDropSource.h: Added.
1388         (DRTDropSource):
1389         * DumpRenderTree/win/DumpRenderTree.vcproj:
1390         * DumpRenderTree/win/EventSender.cpp:
1391         (beginDragWithFilesCallback):
1392
1393 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
1394
1395         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
1396         https://bugs.webkit.org/show_bug.cgi?id=58593
1397
1398         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
1399         to WebKitTestRunner's LayoutTestController. The flag is modified via the
1400         public C API of the WebProcess.
1401
1402         Reviewed by Darin Adler.
1403
1404         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1405         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1406         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
1407         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
1408         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1409
1410 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1411
1412         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
1413         https://bugs.webkit.org/show_bug.cgi?id=87848
1414
1415         Reviewed by Csaba Osztrogonác.
1416
1417         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
1418         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
1419         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
1420
1421         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1422         (DumpRenderTreeChrome::extraViews):
1423         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1424         (DumpRenderTreeChrome):
1425
1426 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1427
1428         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
1429         https://bugs.webkit.org/show_bug.cgi?id=87833
1430
1431         Reviewed by Tor Arne Vestbø.
1432
1433         Print "postProgressFinishedNotification" message if frame load finished 
1434         to unskip http/tests/loading/progress-finished-callback.html.
1435
1436         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1437         (DumpRenderTreeChrome::onFrameLoadFinished):
1438
1439 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
1440
1441         [EFL][WK2] Fix WebKit2-EFL build
1442         https://bugs.webkit.org/show_bug.cgi?id=83693
1443
1444         Reviewed by Carlos Garcia Campos.
1445
1446         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
1447
1448 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
1449
1450         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
1451         (They only used to check for Skipped in platform/qt-5.0-wk1)
1452         https://bugs.webkit.org/show_bug.cgi?id=87376
1453
1454         Reviewed by Csaba Osztrogonác.
1455
1456         * Scripts/old-run-webkit-tests:
1457         (buildPlatformResultHierarchy):
1458         * Scripts/webkitpy/layout_tests/port/qt.py:
1459         (QtPort.baseline_search_path):
1460
1461 2012-05-29  Ojan Vafai  <ojan@chromium.org>
1462
1463         Add a linter error for pngs that lack an embedded checksum
1464         https://bugs.webkit.org/show_bug.cgi?id=87793
1465
1466         Reviewed by Dirk Pranke.
1467
1468         * Scripts/read-checksum-from-png:
1469         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
1470         (read_checksum):
1471         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
1472         (ReadChecksumFromPngTest):
1473         (ReadChecksumFromPngTest.test_read_checksum):
1474         * Scripts/webkitpy/layout_tests/port/base.py:
1475         * Scripts/webkitpy/style/checkers/png.py:
1476         (PNGChecker.check):
1477         * Scripts/webkitpy/style/checkers/png_unittest.py:
1478         (PNGCheckerTest.test_check):
1479
1480 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1481
1482         https://bugs.webkit.org/show_bug.cgi?id=87720
1483         WebProcess is often killed due to being unresponsive on the bots
1484
1485         Reviewed by Alexey Proskuryakov.
1486
1487         Blind attempt to improve flakiness on the bots by reducing the number
1488         of crashes due to an unresponsive process.  This helped on my personal machine
1489         under stress conditions.  I don't have enough cores to hit the problem
1490         under normal conditions.
1491
1492         * WebKitTestRunner/TestController.cpp:
1493         (WTR):
1494
1495 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1496
1497         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
1498         https://bugs.webkit.org/show_bug.cgi?id=87779
1499
1500         Reviewed by Eric Seidel.
1501
1502         Update output to match the names in scm.py as per
1503         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
1504
1505         * Scripts/webkitpy/tool/commands/rebaseline.py:
1506         (RebaselineTest.execute):
1507         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1508         (test_rebaseline_test_and_print_scm_changes):
1509         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1510         (GardeningServerTest.test_rebaselineall):
1511
1512 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1513
1514         https://bugs.webkit.org/show_bug.cgi?id=87711
1515
1516         Reviewed by Jessie Berlin.
1517
1518         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
1519         are better maintained.
1520
1521         * BuildSlaveSupport/build.webkit.org-config/config.json:
1522
1523 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1524
1525         webkit-patch optimize-baselines should add/delete files in batches from the vcs
1526         https://bugs.webkit.org/show_bug.cgi?id=87538
1527
1528         Reviewed by Ojan Vafai.
1529
1530         Invoking git and svn on one file at a time is kinda slow. We
1531         should batch the add and rm operations together.
1532
1533         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1534         (BaselineOptimizer._move_baselines):
1535
1536 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1537
1538         garden-o-matic should rebaseline baselines in parallel
1539         https://bugs.webkit.org/show_bug.cgi?id=87451
1540
1541         Reviewed by Ojan Vafai.
1542                                                                                
1543         This modifies garden-o-matic so that we will fetch all                  
1544         of the baselines in parallel from the bots, and then                    
1545         optimize the baselines serially (since that should be fairly            
1546         quick and we get into trouble if we optimize in parallel due            
1547         to concurrent access to the source control system).                     
1548
1549         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
1550         so that the files that need to be modified in the SCM are returned to 
1551         garden-o-matic rather than actually added or removed. This is done so that
1552         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
1553         concurrently). In order to safely return the files (as a JSON dict) I
1554         needed to shift all of the logging in rebaseline-test to use the logging
1555         module (and hence log to stderr).
1556
1557         I also had to stub out a line in chromium.py that would get confused if
1558         the skia overrides file didn't exist in a mock checkout.
1559
1560         * Scripts/webkitpy/common/system/executive.py:
1561         (Executive.popen):
1562         (Executive):
1563         (Executive.run_in_parallel):
1564         (_run_command_thunk):
1565         * Scripts/webkitpy/common/system/executive_mock.py:
1566         (MockExecutive.run_in_parallel):
1567         * Scripts/webkitpy/common/system/executive_unittest.py:
1568         (ExecutiveTest.test_run_in_parallel):
1569         * Scripts/webkitpy/layout_tests/port/chromium.py:
1570         (ChromiumPort._expectations_file_contents):
1571         * Scripts/webkitpy/tool/commands/rebaseline.py:
1572         (AbstractRebaseliningCommand.__init__):
1573         (RebaselineTest.__init__):
1574         (RebaselineTest._copy_existing_baseline):
1575         (RebaselineTest._save_baseline):
1576         (RebaselineTest):
1577         (RebaselineTest._add_to_scm):
1578         (RebaselineTest._rebaseline_test):
1579         (RebaselineTest.execute):
1580         (RebaselineExpectations._rebaseline_port):
1581         (RebaselineExpectations.execute):
1582         (Rebaseline._builder_to_pull_from):
1583         (Rebaseline.execute):
1584         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1585         (test_rebaseline_updates_expectations_file):
1586         (test_rebaseline_test):
1587         (test_rebaseline_test_and_print_scm_changes):
1588         (test_rebaseline_and_copy_test):
1589         (test_rebaseline_and_copy_test_no_existing_result):
1590         (test_rebaseline_and_copy_test_with_lion_result):
1591         (test_rebaseline_and_copy_no_overwrite_test):
1592         (test_rebaseline_expectations):
1593         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1594         (GardeningHTTPRequestHandler._rebaseline_commands):
1595         (GardeningHTTPRequestHandler):
1596         (GardeningHTTPRequestHandler._files_to_add):
1597         (GardeningHTTPRequestHandler._optimize_baselines):
1598         (GardeningHTTPRequestHandler.rebaselineall):
1599         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1600         (GardeningServerTest._post_to_path):
1601         (GardeningServerTest.test_rebaselineall):
1602         (GardeningServerTest.test_rebaselineall.run_command):
1603
1604 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
1605
1606         Fix the type of dispatch_time() offset
1607
1608         Rubber-stamped by Joseph Pecoraro.
1609
1610         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
1611
1612         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1613         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1614
1615 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1616
1617         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1618
1619         [BlackBerry] OpenGL content is not rendered on simulator
1620         https://bugs.webkit.org/show_bug.cgi?id=87721
1621
1622         Reviewed by George Staikos.
1623
1624         Fixed by enabling GLES2 support in simulator builds.
1625
1626         To experiment with building without OpenGL support, you can set the
1627         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
1628
1629         PR #150695
1630
1631         * Scripts/webkitdirs.pm:
1632         (blackberryCMakeArguments):
1633
1634 2012-05-29  David Barr  <davidbarr@chromium.org>
1635
1636         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
1637         https://bugs.webkit.org/show_bug.cgi?id=87685
1638
1639         Reviewed by Eric Seidel.
1640
1641         Add a configuration option for CSS image-resolution support, disabling it by default.
1642
1643         * Scripts/webkitperl/FeatureList.pm:
1644         * qmake/mkspecs/features/features.pri:
1645
1646 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1647
1648         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
1649
1650         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
1651             valid for C++/ObjC++ but not for C [enabled by default]"
1652
1653         Reviewed by Simon Hausmann.
1654
1655         * qmake/mkspecs/features/unix/default_post.prf:
1656
1657 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1658
1659         [Qt] Sync up favicon-implementation with WebView url changes in r118158
1660
1661         https://bugs.webkit.org/show_bug.cgi?id=87133
1662
1663         We now base64-encode the page url in the image-provider url, so that any
1664         normalization done by QUrl will not mess up the page-url. The logic of
1665         creating and parsing the provider-url has been moved into the image
1666         provider, to keep it in one place.
1667
1668         We were also releasing icons (even ones we hadn't retained), which we can't
1669         do since we don't know when the icon url is no longer in use.
1670
1671         Reviewed-by Simon Hausmann.
1672
1673         * MiniBrowser/qt/icons/favicon.png:
1674         * MiniBrowser/qt/qml/BrowserWindow.qml:
1675
1676 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1677
1678         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
1679         https://bugs.webkit.org/show_bug.cgi?id=87654
1680
1681         Reviewed by Csaba Osztrogonác.
1682
1683         Event sender provides strings for all the key events.
1684         Also KeyEventInfo constructor parameters order was changed to simplify the case when
1685         a key event has empty string.
1686
1687         * DumpRenderTree/efl/EventSender.cpp:
1688         (KeyEventInfo::KeyEventInfo):
1689         (keyPadNameFromJSValue):
1690         (keyNameFromJSValue):
1691
1692 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1693
1694         [Qt] Cancel potential url-edit when going back/forward
1695
1696         Reviewed by Kenneth Rohde Christiansen.
1697
1698         * MiniBrowser/qt/qml/BrowserWindow.qml:
1699
1700 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
1701
1702         [EFL] Compilation warning in DumpRenderTreeView.cpp
1703         https://bugs.webkit.org/show_bug.cgi?id=87636
1704
1705         Reviewed by Filip Pizlo.
1706
1707         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
1708         specifier in printf. Also fix the return type for
1709         onExceededApplicationCacheQuota callback.
1710
1711         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1712         (onExceededApplicationCacheQuota):
1713
1714 2012-05-29  Hironori Bono  <hbono@chromium.org>
1715
1716         Adding Hironori Bono to committers.py.
1717         https://bugs.webkit.org/show_bug.cgi?id=87697
1718
1719         * Scripts/webkitpy/common/config/committers.py:
1720
1721 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1722
1723         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
1724         https://bugs.webkit.org/show_bug.cgi?id=80135
1725
1726         Reviewed by Rob Buis.
1727
1728         Implemented interface function didReceiveAuthenticationChallenge in class
1729         DumpRenderTree.
1730
1731         Resubmit the patch reverted by r115104 after the digest infinite loop
1732         issue for BlackBerry porting get identified and fixed.
1733
1734         Internally reviewed by Joe Mason <jmason@rim.com>
1735
1736         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1737         (drtCredentialDescription):
1738         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
1739         (WebKit):
1740         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1741         (WebCore):
1742         (DumpRenderTree):
1743
1744 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1745
1746         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
1747         https://bugs.webkit.org/show_bug.cgi?id=42328
1748
1749         Reviewed by Eric Seidel.
1750
1751         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
1752         move to windows.internals.settings.
1753
1754         * DumpRenderTree/LayoutTestController.cpp:
1755         (LayoutTestController::staticFunctions):
1756         * DumpRenderTree/LayoutTestController.h:
1757         (LayoutTestController):
1758         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1759         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1760         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1761         (DRTDevToolsAgent):
1762         * DumpRenderTree/chromium/LayoutTestController.cpp:
1763         (LayoutTestController::LayoutTestController):
1764         * DumpRenderTree/chromium/LayoutTestController.h:
1765         (LayoutTestController):
1766         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1767         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1768         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1769         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1770         * DumpRenderTree/mac/DumpRenderTree.mm:
1771         (resetWebViewToConsistentStateBeforeTesting):
1772         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1773         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1774         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1775         (LayoutTestController):
1776         * DumpRenderTree/win/DumpRenderTree.cpp:
1777         (resetWebViewToConsistentStateBeforeTesting):
1778         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1779         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1780         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1781         (LayoutTestController):
1782
1783 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1784
1785         Move allowRoundingHacks to Internals interface
1786         https://bugs.webkit.org/show_bug.cgi?id=87328
1787
1788         Reviewed by Hajime Morita.
1789
1790         Remove allowRoundingHacks functions, because it is able to work in the
1791         cross-port way through the Internals interface.
1792
1793         * DumpRenderTree/LayoutTestController.cpp:
1794         (LayoutTestController::staticFunctions):
1795         * DumpRenderTree/LayoutTestController.h:
1796         (LayoutTestController):
1797         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1798         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1799         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1800         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1801         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1802         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1803
1804 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
1805
1806         Fix mac build with older XCode by defining NSEC_PER_MSEC.
1807         https://bugs.webkit.org/show_bug.cgi?id=87616
1808
1809         Reviewed by Hajime Morita.
1810
1811         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
1812         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
1813         Patch just adds a #ifndef / #define check.
1814
1815         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1816         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1817
1818 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1819
1820         [EFL] Enable blob support for the EFL port
1821         https://bugs.webkit.org/show_bug.cgi?id=85363
1822
1823         Reviewed by Hajime Morita.
1824
1825         Enable Blob support by default for the EFL port.
1826
1827         * Scripts/webkitperl/FeatureList.pm:
1828
1829 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
1830
1831         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
1832         https://bugs.webkit.org/show_bug.cgi?id=87582
1833
1834         Reviewed by Darin Adler.
1835
1836         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
1837         possible to test pages in a similar way as they are loaded in Browsers.
1838
1839         * DumpRenderTree/LayoutTestController.cpp:
1840         (LayoutTestController::LayoutTestController):
1841         (setUseDeferredFrameLoadingCallback):
1842         (LayoutTestController::staticFunctions):
1843         * DumpRenderTree/LayoutTestController.h:
1844         (LayoutTestController::useDeferredFrameLoading):
1845         (LayoutTestController::setUseDeferredFrameLoading):
1846         (LayoutTestController):
1847         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1848         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1849
1850 2012-05-27  David Barton  <dbarton@mathscribe.com>
1851
1852         [watchlist] Improve MathML rule
1853         https://bugs.webkit.org/show_bug.cgi?id=87592
1854
1855         Reviewed by Adam Barth.
1856
1857         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
1858         but if this changed the rule would be slow. We protect against this, clarify the rule,
1859         and make it more similar to existing rules.
1860
1861         * Scripts/webkitpy/common/config/watchlist:
1862
1863 2012-05-27  David Barton  <dbarton@mathscribe.com>
1864
1865         [watchlist] Add myself & a rule for MathML
1866         https://bugs.webkit.org/show_bug.cgi?id=87586
1867
1868         Reviewed by Adam Barth.
1869
1870         * Scripts/webkitpy/common/config/watchlist:
1871
1872 2012-05-26  David Kilzer  <ddkilzer@apple.com>
1873
1874         Use xcrun to find path to nm for Mac port
1875         <http://webkit.org/b/87588>
1876
1877         Reviewed by Dan Bernstein.
1878
1879         * Scripts/webkitpy/layout_tests/port/mac.py:
1880         (MacPort.nm_command): Add. Tries to find a path for the nm
1881         command using xcrun.  Falls back to returning 'nm'.
1882         * Scripts/webkitpy/layout_tests/port/webkit.py:
1883         (WebKitPort.nm_command): Add. Returns 'nm'.
1884         (WebKitPort._webcore_symbols_string): Call self.nm_command().
1885
1886 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
1887
1888         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
1889
1890         Reviewed by Eric Seidel.
1891
1892         * DumpRenderTree/win/DumpRenderTree.vcproj:
1893         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1894         (FrameLoadDelegate::FrameLoadDelegate):
1895         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1896         * DumpRenderTree/win/FrameLoadDelegate.h:
1897         (FrameLoadDelegate):
1898         * DumpRenderTree/win/TextInputController.cpp: Added.
1899         (setMarkedTextCallback):
1900         (hasMarkedTextCallback):
1901         (unmarkTextCallback):
1902         (markedRangeCallback):
1903         (insertTextCallback):
1904         (firstRectForCharacterRangeCallback):
1905         (selectedRangeCallback):
1906         (TextInputController::makeWindowObject):
1907         (TextInputController::getJSClass):
1908         (TextInputController::staticValues):
1909         (TextInputController::staticFunctions):
1910         * DumpRenderTree/win/TextInputController.h: Added.
1911         (TextInputController):
1912         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
1913         (TextInputController::setMarkedText):
1914         (TextInputController::hasMarkedText):
1915         (TextInputController::unmarkText):
1916         (TextInputController::markedRange):
1917         (TextInputController::insertText):
1918         (TextInputController::firstRectForCharacterRange):
1919         (TextInputController::selectedRange):
1920
1921 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
1922
1923         webkitpy: change scm.add(), scm.delete() to accept multiple paths
1924         https://bugs.webkit.org/show_bug.cgi?id=87528
1925
1926         Reviewed by Ojan Vafai.
1927
1928         launching git or svn for individual files can be slow; this
1929         change will hand multiple paths at once to git and svn so they
1930         can be added in a batch.
1931
1932         * Scripts/webkitpy/common/checkout/scm/git.py:
1933         (Git.add_list):
1934         (Git.delete_list):
1935         * Scripts/webkitpy/common/checkout/scm/scm.py:
1936         (SCM.add):
1937         (SCM):
1938         (SCM.add_list):
1939         (SCM.delete):
1940         (SCM.delete_list):
1941         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1942         (MockSCM.add):
1943         (MockSCM):
1944         (MockSCM.add_list):
1945         (MockSCM.delete):
1946         (MockSCM.delete_list):
1947         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1948         (_shared_test_exists):
1949         (_shared_test_added_files):
1950         (_test_delete_list):
1951         * Scripts/webkitpy/common/checkout/scm/svn.py:
1952         (SVN.add_list):
1953         (SVN.delete_list):
1954
1955 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1956
1957         [NRWT] Add unit testing for perf tests on locked shards
1958         https://bugs.webkit.org/show_bug.cgi?id=87489
1959
1960         Reviewed by Dirk Pranke.
1961
1962         Adding utests that makes sure that perf tests are running in locked
1963         shards and by passing --no-http won't break NRWT (r118421).
1964
1965         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1966         (ShardingTests):
1967         (ShardingTests.test_shard_by_dir):
1968         (ShardingTests.test_shard_every_file):
1969         (ShardingTests.test_shard_in_two):
1970         (ShardingTests.test_multiple_locked_shards):
1971         (LockCheckingManager):
1972         (LockCheckingManager.__init__):
1973         (LockCheckingManager.handle_finished_list):
1974         (ManagerTest.test_http_locking):
1975         (ManagerTest):
1976         (ManagerTest.test_perf_locking):
1977         * Scripts/webkitpy/layout_tests/port/test.py:
1978
1979 2012-05-25  Jessie Berlin  <jberlin@apple.com>
1980
1981         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
1982         https://bugs.webkit.org/show_bug.cgi?id=87511
1983
1984         Reviewed by Alexey Proskuryakov.
1985
1986         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
1987
1988         * DumpRenderTree/win/EventSender.cpp:
1989         (keyDownCallback):
1990
1991 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
1992
1993         Adding Ken Buchanan to committers.py
1994         https://bugs.webkit.org/show_bug.cgi?id=87443
1995
1996         Unreviewed.
1997
1998         Adding self to committers.py as a Committer.
1999
2000         * Scripts/webkitpy/common/config/committers.py:
2001
2002 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2003
2004         [Qt] Buildfix for newer Qt5
2005         https://bugs.webkit.org/show_bug.cgi?id=87257
2006
2007         Reviewed by Simon Hausmann.
2008
2009         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
2010
2011 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2012
2013         [Qt] Unreviewed fix after r118484.
2014
2015         Enable CSS_EXCLUSIONS and CSS_REGIONS.
2016         They were enabled uncoditinally before r118484.
2017
2018         * qmake/mkspecs/features/features.pri:
2019
2020 2012-05-24  Tim Horton  <timothy_horton@apple.com>
2021
2022         Add feature defines for web-facing parts of CSS Regions and Exclusions
2023         https://bugs.webkit.org/show_bug.cgi?id=87442
2024         <rdar://problem/10887709>
2025
2026         Reviewed by Dan Bernstein.
2027
2028         * Scripts/webkitperl/FeatureList.pm:
2029
2030 2012-05-24  Hironori Bono  <hbono@chromium.org>
2031
2032         Enable grammar checking on Chromium when we paste text (Take 2)
2033         https://bugs.webkit.org/show_bug.cgi?id=74393
2034
2035         Reviewed by Ryosuke Niwa.
2036
2037         This change enables grammar checking on Chromium and implements a mock grammar
2038         checker to fix a failing test.
2039
2040         * DumpRenderTree/DumpRenderTree.gypi:
2041         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2042         (MockGrammarCheck::checkGrammarOfString):
2043         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2044         (WebKit):
2045         (MockGrammarCheck):
2046         * DumpRenderTree/chromium/WebViewHost.cpp:
2047         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2048
2049 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2050
2051         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
2052         https://bugs.webkit.org/show_bug.cgi?id=86842
2053
2054         Reviewed by Antonio Gomes.
2055
2056         Add support for overriding the application cache support preference
2057         through EFL's LayoutTestController.
2058
2059         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2060         (LayoutTestController::overridePreference):
2061
2062 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2063
2064         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
2065         https://bugs.webkit.org/show_bug.cgi?id=85209
2066
2067         Reviewed by Antonio Gomes.
2068
2069         Set developer extras setting called twice on the test startup. Hence, removing
2070         an unnecessary extra call which set wrong value. 
2071
2072         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2073         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2074
2075 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2076
2077         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2078         https://bugs.webkit.org/show_bug.cgi?id=86916
2079
2080         Reviewed by Adam Barth.
2081
2082         Note that if release and debug are failing differently, debug
2083         will be ignored ...
2084
2085         Note: also change the use of a fake port name from
2086         "mock-port-name" to "test-mac-leopard" to make it more friendly
2087         to the port factory ("mock" actually is a real port).
2088
2089         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2090         (GardeningHTTPRequestHandler._builders_to_fetch_from):
2091         (GardeningHTTPRequestHandler.rebaselineall):
2092         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2093         (GardeningServerTest.test_rebaselineall):
2094         (GardeningServerTest.test_rebaseline_new_port):
2095
2096 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2097
2098         nrwt: fix baseline search path for official chrome builders
2099         https://bugs.webkit.org/show_bug.cgi?id=87432
2100
2101         Reviewed by Tony Chang.
2102
2103         The official chrome builders need to use the win7 and SL
2104         baseline paths, not the XP and Leopard paths. Linux is correct.
2105
2106         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2107         (GoogleChromeMacPort.determine_full_port_name):
2108         (GoogleChromeWinPort.determine_full_port_name):
2109         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2110         (TestGoogleChromePort._verify_baseline_search_path_startswith):
2111         (TestGoogleChromePort.test_get_google_chrome_port):
2112
2113 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2114
2115         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
2116         https://bugs.webkit.org/show_bug.cgi?id=86800
2117
2118         Reviewed by Dirk Pranke.
2119
2120         Don't launch a HTTP server with lock based only on the existence of
2121         locked shards since we now run perf on locked shards too.
2122
2123         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2124         (Manager._run_tests):
2125
2126 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
2127
2128         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2129         https://bugs.webkit.org/show_bug.cgi?id=87128
2130
2131         Reviewed by Dirk Pranke.
2132
2133         * Scripts/webkitpy/layout_tests/port/base.py:
2134         (Port.driver_name):
2135         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2136         (ChromiumLinuxPort._path_to_driver):
2137         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2138         (ChromiumPortTest.test_driver_name_option):
2139         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2140         (ChromiumWinPort._path_to_driver):
2141         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2142         (parse_args):
2143
2144 2012-05-24  John Mellor  <johnme@chromium.org>
2145
2146         Font Boosting: Add compile flag and runtime setting
2147         https://bugs.webkit.org/show_bug.cgi?id=87394
2148
2149         Reviewed by Adam Barth.
2150
2151         Add ENABLE_FONT_BOOSTING.
2152
2153         * Scripts/webkitperl/FeatureList.pm:
2154         * qmake/mkspecs/features/features.pri:
2155
2156 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2157
2158         [EFL] [DRT] keyboard-related tests do not pass
2159         https://bugs.webkit.org/show_bug.cgi?id=85369
2160
2161         Reviewed by Gustavo Noronha Silva.
2162
2163         Add SHIFT modifier for capital letters as VK_ 
2164         codes do not distinguish between lows and caps and also to be consistent
2165         with other ports which send caps as lowercase letters with the shift key down.
2166
2167         * DumpRenderTree/efl/EventSender.cpp:
2168         (keyNameFromJSValue): 
2169
2170 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
2171
2172         [WK2] Let the client give local files universal access on a case by case basis
2173         https://bugs.webkit.org/show_bug.cgi?id=87174
2174         <rdar://problem/11024330>
2175
2176         Reviewed by Maciej Stachowiak.
2177
2178         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
2179         Added initialization of a new structure member to prevent build failure.
2180
2181 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
2182
2183         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
2184         https://bugs.webkit.org/show_bug.cgi?id=87203
2185
2186         Reviewed by Andreas Kling.
2187
2188         Add the required changes to make
2189         fast/events/keydown-leftright-keys.html pass after r118001.
2190
2191         * DumpRenderTree/efl/EventSender.cpp:
2192         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
2193         into the proper X11 keysym definitions.
2194
2195 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2196
2197         Unreviewed, rolling out r118352.
2198         http://trac.webkit.org/changeset/118352
2199         https://bugs.webkit.org/show_bug.cgi?id=87390
2200
2201         Caused 6 editing/spelling tests crash/fail on chromium in
2202         debug. (Requested by vsevik on #webkit).
2203
2204         * DumpRenderTree/DumpRenderTree.gypi:
2205         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
2206         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
2207         * DumpRenderTree/chromium/WebViewHost.cpp:
2208         (WebViewHost::finishLastTextCheck):
2209
2210 2012-05-24  Peter Beverloo  <peter@chromium.org>
2211
2212         Add John Mellor as a contributor
2213         https://bugs.webkit.org/show_bug.cgi?id=87389
2214
2215         Reviewed by Kenneth Rohde Christiansen.
2216
2217         John will be working on Font Boosting and is very involved with various
2218         web-facing subjects of Chrome for Android, such as viewport.
2219
2220         * Scripts/webkitpy/common/config/committers.py:
2221
2222 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2223
2224         [EFL][DRT] LayoutTestController's setCacheModel() implementation
2225         https://bugs.webkit.org/show_bug.cgi?id=86840
2226
2227         Reviewed by Csaba Osztrogonác.
2228
2229         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2230         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
2231         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2232         (LayoutTestController::setCacheModel): Implementation added.
2233
2234 2012-05-24  Hironori Bono  <hbono@chromium.org>
2235
2236         Enable grammar checking on Chromium when we paste text.
2237         https://bugs.webkit.org/show_bug.cgi?id=74393
2238
2239         Reviewed by Hajime Morita.
2240
2241         This change enables grammar checking on Chromium and implements a mock grammar
2242         checker to fix a failing test.
2243
2244         * DumpRenderTree/DumpRenderTree.gypi:
2245         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2246         (MockGrammarCheck::checkGrammarOfString):
2247         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2248         (WebKit):
2249         (MockGrammarCheck):
2250         * DumpRenderTree/chromium/WebViewHost.cpp:
2251         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2252
2253 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
2254
2255         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
2256
2257         * qmake/mkspecs/features/features.pri:
2258
2259 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2260
2261         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
2262         https://bugs.webkit.org/show_bug.cgi?id=86867
2263
2264         Reviewed by Adam Barth.
2265
2266         Add implementation for sendWebIntentResponse() in EFL's
2267         LayoutTestController and add empty implementation for other ports.
2268
2269         * DumpRenderTree/LayoutTestController.cpp:
2270         (sendWebIntentResponseCallback):
2271         (LayoutTestController::staticFunctions):
2272         * DumpRenderTree/LayoutTestController.h:
2273         (LayoutTestController):
2274         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2275         (LayoutTestController::sendWebIntentResponse):
2276         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2277         (DumpRenderTreeChrome::currentIntentRequest):
2278         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2279         (DumpRenderTreeChrome::onFrameIntentNew):
2280         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2281         (DumpRenderTreeChrome):
2282         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2283         (LayoutTestController::sendWebIntentResponse):
2284         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2285         (LayoutTestController::sendWebIntentResponse):
2286         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2287         (LayoutTestController::sendWebIntentResponse):
2288         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2289         (LayoutTestController::sendWebIntentResponse):
2290         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2291         (LayoutTestController::sendWebIntentResponse):
2292
2293 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2294
2295         [EFL] The EFL port has no support for title directionality
2296         https://bugs.webkit.org/show_bug.cgi?id=86462
2297
2298         Reviewed by Gustavo Noronha Silva.
2299
2300         Update "title,changed" signal handlers in DRT and EWebLauncher to
2301         reflect the change from const char* to Ewk_Text_With_Direction* type
2302         for the title.
2303
2304         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2305         (DumpRenderTreeChrome::onTitleChanged):
2306         * EWebLauncher/main.c:
2307         (title_set):
2308         (on_title_changed):
2309         (on_key_down):
2310
2311 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2312
2313         Change EFL debug build name with more detail one
2314         https://bugs.webkit.org/show_bug.cgi?id=87254
2315
2316         Reviewed by Ryosuke Niwa.
2317
2318         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
2319         In addition, remove efl-linux-debug triggerable since nobody uses it.
2320
2321         * BuildSlaveSupport/build.webkit.org-config/config.json:
2322
2323 2012-05-23  Kangil Han  <kangil.han@samsung.com>
2324
2325         [EFL][DRT] Fix WebCore library path and rebaseline result
2326         https://bugs.webkit.org/show_bug.cgi?id=86355
2327
2328         Reviewed by Dirk Pranke.
2329
2330         Currently EFL DRT uses wrong WebCore library path when running DRT.
2331         Therefore, this patch adjusted the path correctly.
2332
2333         * Scripts/webkitpy/layout_tests/port/efl.py:
2334         (EflPort._path_to_webcore_library):
2335
2336 2012-05-23  Ojan Vafai  <ojan@chromium.org>
2337
2338         add back the ability to disable flexbox
2339         https://bugs.webkit.org/show_bug.cgi?id=87147
2340
2341         Reviewed by Tony Chang.
2342
2343         * Scripts/webkitperl/FeatureList.pm:
2344
2345 2012-05-23  Tony Chang  <tony@chromium.org>
2346
2347         Remove the Chromium Grid Layout bot from the waterfall
2348         https://bugs.webkit.org/show_bug.cgi?id=87311
2349
2350         Reviewed by Ryosuke Niwa.
2351
2352         I removed the compiler define in r117613, so we don't need a separate
2353         bot to compile/test this code.
2354
2355         * BuildSlaveSupport/build.webkit.org-config/config.json:
2356
2357 2012-05-23  Ian Vollick  <vollick@chromium.org>
2358
2359         Add vollick to list of contributors.
2360         https://bugs.webkit.org/show_bug.cgi?id=87305
2361
2362         Reviewed by Adam Barth.
2363
2364         * Scripts/webkitpy/common/config/committers.py:
2365
2366 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2367
2368         [Chromium-Android] Fix chromium_android_unittest
2369         https://bugs.webkit.org/show_bug.cgi?id=87196
2370
2371         Reviewed by Tony Chang.
2372
2373         Update unit tests after ChromiumAndroidPort supported apk based
2374         DumpRenderTree.
2375
2376         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2377         (ChromiumAndroidPortTest):
2378         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
2379         (ChromiumAndroidPortTest.test_get_last_stacktrace):
2380         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
2381         (ChromiumAndroidDriverTest):
2382         (ChromiumAndroidDriverTest.setUp):
2383         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
2384         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
2385
2386 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2387
2388         [watchlist] Add myself and create a watch rule to catch Attribute related patches
2389         https://bugs.webkit.org/show_bug.cgi?id=87303
2390
2391         Reviewed by Alexis Menard.
2392
2393         * Scripts/webkitpy/common/config/watchlist:
2394
2395 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
2396
2397         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2398         https://bugs.webkit.org/show_bug.cgi?id=86916
2399
2400         Reviewed by Adam Barth.
2401
2402         This change pushes all of the logic for rebaselining a cluster
2403         of failures (a list of tests failing a list of suffixes on a
2404         list of bots) onto the server, so there is a single call from
2405         the web page; we will then be able to optimize the performance
2406         of the rebaselining better.
2407
2408         Also remove the 'optimizebaseline' entry point on garden-o-matic
2409         (and the client-side call) since we don't need it any more.
2410
2411         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2413         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2414         (GardeningHTTPRequestHandler.rebaselineall):
2415         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2416
2417 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
2418
2419         Mac DRT should be able to load external URLs for replay performance tests
2420         https://bugs.webkit.org/show_bug.cgi?id=86191
2421
2422         Reviewed by Alexey Proskuryakov.
2423
2424         Let external URL requests go through if the test file is not a local file or hosted at localhost.
2425         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
2426         "DumpRenderTree http://localhost:8000/".
2427
2428         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2429         (isLocalhost):
2430         (hostIsUsedBySomeTestsToGenerateError):
2431         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2432
2433 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
2434
2435         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
2436         debug symbols for easier debugging.
2437         https://bugs.webkit.org/show_bug.cgi?id=87151
2438
2439         Reviewed by Kevin Ollivier.
2440
2441         * waf/build/settings.py:
2442         (common_configure):
2443
2444 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2445
2446         Unreviewed. Move myself to reviewers.
2447
2448         * Scripts/webkitpy/common/config/committers.py:
2449
2450 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
2451
2452         [EFL] Implements the registerProtocolHandler method and option.
2453         https://bugs.webkit.org/show_bug.cgi?id=73638
2454
2455         Reviewed by Andreas Kling.
2456
2457         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
2458
2459 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
2460
2461         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
2462         https://bugs.webkit.org/show_bug.cgi?id=87221
2463
2464         Reviewed by Martin Robinson.
2465
2466         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
2467         rightShift key names into proper GDK key symbols.
2468
2469         * DumpRenderTree/gtk/EventSender.cpp:
2470         (createKeyPressEvent):
2471
2472 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2473
2474         [Qt] Make the web view's url property follow the active url
2475
2476         https://bugs.webkit.org/show_bug.cgi?id=77554
2477
2478         Update  the location bar in the minibrowser to behave
2479         a bit more like normal browsers in terms of when the url will change
2480         and how active focus is handled.
2481
2482         Reviewed by Simon Hausmann.
2483
2484         * MiniBrowser/qt/qml/BrowserWindow.qml:
2485
2486 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2487
2488         [Qt] Remove references to $$QT_SOURCE_TREE
2489
2490         With a modularized Qt, it's ambigious. What we really want is qtbase,
2491         which qtcore is a proxy for (we assume it will always live in qtbase).
2492
2493         Reviewed by Tor Arne Vestbø.
2494
2495         * DumpRenderTree/qt/DumpRenderTree.pro:
2496
2497 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2498
2499         [Qt] Fix qmake conditional for c++-11 compat warnings
2500
2501         Reviewed by Tor Arne Vestbø.
2502
2503         * qmake/mkspecs/features/unix/default_post.prf:
2504
2505 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2506
2507         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
2508         https://bugs.webkit.org/show_bug.cgi?id=85956
2509
2510         Reviewed by Gustavo Noronha Silva.
2511
2512         Catch new "load,provisional,failed" signal and print
2513         didFailProvisionalLoadWithError messages when LayoutTestController's
2514         dumpFrameLoadCallbacks() returns true. Also make sure the
2515         didFailLoadWithError message is not printed in case of provisional
2516         load failure.
2517
2518         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2519         (DumpRenderTreeChrome::createView):
2520         (DumpRenderTreeChrome::onFrameCreated):
2521         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
2522         (DumpRenderTreeChrome::onFrameLoadError):
2523         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2524         (DumpRenderTreeChrome):
2525
2526 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2527
2528         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
2529         https://bugs.webkit.org/show_bug.cgi?id=86366
2530
2531         Reviewed by Antonio Gomes.
2532
2533         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
2534
2535         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2536         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2537
2538 2012-05-22  Darin Adler  <darin@apple.com>
2539
2540         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
2541         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
2542
2543 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2544
2545         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
2546         https://bugs.webkit.org/show_bug.cgi?id=86922
2547
2548         Because we have new platformInit() in TestShellAndroid.cpp, and
2549         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
2550         is split into TestShellPosix.cpp and TestShellX11.cpp.
2551
2552         Reviewed by Kent Tamura.
2553
2554         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2555         * DumpRenderTree/DumpRenderTree.gypi:
2556         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
2557         (platformInit):
2558         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
2559         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
2560         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
2561         (AlarmHandler):
2562         (TestShell::waitTestFinished):
2563         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
2564         (openStartupDialog): from TestShellGtk.cpp
2565         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
2566         (setupFontconfig):
2567         (platformInit):
2568
2569 2012-05-22  Kangil Han  <kangil.han@samsung.com>
2570
2571         [EFL][DRT] Implement touch event
2572         https://bugs.webkit.org/show_bug.cgi?id=86720
2573
2574         Reviewed by Hajime Morita.
2575
2576         Currently EFL DRT doesn't support touch event.
2577         Therefore, this patch enabled it and implemented some eventSender function callbacks.
2578
2579         * DumpRenderTree/efl/EventSender.cpp:
2580         (TouchEventInfo::TouchEventInfo):
2581         (TouchEventInfo):
2582         (touchPointList):
2583         (sendTouchEvent):
2584         (addTouchPointCallback):
2585         (touchStartCallback):
2586         (updateTouchPointCallback):
2587         (touchMoveCallback):
2588         (cancelTouchPointCallback):
2589         (touchCancelCallback):
2590         (releaseTouchPointCallback):
2591         (touchEndCallback):
2592         (clearTouchPointsCallback):
2593         (setTouchModifierCallback):
2594         * Scripts/webkitperl/FeatureList.pm:
2595
2596 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2597
2598         [Chromium-Android] Fix chromium_android_unittest
2599         https://bugs.webkit.org/show_bug.cgi?id=87196
2600
2601         Not reviewed.
2602         Temporarily disable chromium_android_unittest.
2603
2604         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2605         (ChromiumAndroidPortTest):
2606         (ChromiumAndroidDriverTest):
2607
2608 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2609
2610         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
2611         https://bugs.webkit.org/show_bug.cgi?id=64313
2612
2613         Reviewed by Jon Honeycutt.
2614
2615         Add it.
2616
2617         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2618         Make sure to generate the binding.
2619
2620         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2621         (WTR::LayoutTestController::setDefersLoading):
2622         Call WKBundlePageSetDefersLoading.
2623         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2624
2625 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2626
2627         [Chromium-Android] Run DumpRenderTree as an apk (python part)
2628         https://bugs.webkit.org/show_bug.cgi?id=86923
2629
2630         chromium_android.py is modified to support running DumpRenderTree as
2631         an apk, so that we can run the tests (e.g. video) requiring features
2632         implemented in Java on Android.
2633
2634         Reviewed by Adam Barth.
2635
2636         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2637         (ChromiumAndroidPort.__init__):
2638         (ChromiumAndroidPort.default_child_processes):
2639         (ChromiumAndroidPort.check_wdiff):
2640         (ChromiumAndroidPort.check_build):
2641         (ChromiumAndroidPort.start_helper):
2642         (ChromiumAndroidPort.skipped_layout_tests):
2643         (ChromiumAndroidPort):
2644         (ChromiumAndroidPort._path_to_driver):
2645         (ChromiumAndroidPort._get_crash_log):
2646         (ChromiumAndroidPort._push_executable):
2647         (ChromiumAndroidPort._run_adb_command):
2648         (ChromiumAndroidPort._get_last_stacktrace):
2649         (ChromiumAndroidPort._get_logcat):
2650         (ChromiumAndroidPort._setup_performance):
2651         (ChromiumAndroidDriver):
2652         (ChromiumAndroidDriver.__init__):
2653         (ChromiumAndroidDriver._command_wrapper):
2654         (ChromiumAndroidDriver.cmd_line):
2655         (ChromiumAndroidDriver._file_exists_on_device):
2656         (ChromiumAndroidDriver._deadlock_detector):
2657         (ChromiumAndroidDriver._start):
2658         (ChromiumAndroidDriver.run_test):
2659         (ChromiumAndroidDriver.stop):
2660         (ChromiumAndroidDriver._write_command_and_read_line):
2661         (ChromiumAndroidDriver._output_image):
2662         (ChromiumAndroidDriver._get_stderr):
2663
2664 2012-05-22  Joshua Bell  <jsbell@chromium.org>
2665
2666         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
2667
2668         Unreviewed gardening.
2669
2670         * Scripts/webkitpy/layout_tests/port/base.py:
2671         (Port.driver_name):
2672         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2673         (ChromiumLinuxPort._path_to_driver):
2674         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2675         (ChromiumPortTest.test_overrides_and_builder_names):
2676         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2677         (ChromiumWinPort._path_to_driver):
2678         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2679         (parse_args):
2680
2681 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2682
2683         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
2684         https://bugs.webkit.org/show_bug.cgi?id=87176
2685
2686         Reviewed by Tony Chang.
2687
2688         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2689         * DumpRenderTree/DumpRenderTree.gypi:
2690
2691 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
2692
2693         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2694         https://bugs.webkit.org/show_bug.cgi?id=87128
2695
2696         Reviewed by Dirk Pranke.
2697
2698         * Scripts/webkitpy/layout_tests/port/base.py:
2699         (Port.driver_name):
2700         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2701         (ChromiumLinuxPort._path_to_driver):
2702         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2703         (ChromiumPortTest.test_driver_name_option):
2704         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2705         (ChromiumWinPort._path_to_driver):
2706         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2707         (parse_args):
2708
2709 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2710
2711         WTR fix after r118001.
2712
2713         Rubber-stamped by Alexey Proskuryakov.
2714
2715         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
2716
2717         * WebKitTestRunner/mac/EventSenderProxy.mm:
2718         (WTR::EventSenderProxy::keyDown):
2719
2720 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
2721
2722         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
2723         https://bugs.webkit.org/show_bug.cgi?id=86684
2724
2725         Reviewed by Darin Fisher.
2726
2727         * DumpRenderTree/chromium/LayoutTestController.cpp:
2728         (LayoutTestController::numberOfPages):
2729         * DumpRenderTree/chromium/WebViewHost.cpp:
2730         (WebViewHost::printPage):
2731
2732 == Rolled over to ChangeLog-2012-05-22 ==