RemoteObjectRegistry message receiver should be removed when WebPage::close is called...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2
3         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
4         https://bugs.webkit.org/show_bug.cgi?id=196744
5         <rdar://49415309>
6
7         Reviewed by Chris Dumez.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
10         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
11
12 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
13
14         Add a way to opt into modern compatibility mode in layout tests
15         https://bugs.webkit.org/show_bug.cgi?id=196770
16         <rdar://problem/49777550>
17
18         Reviewed by Antoine Quint.
19
20         Add a new test option to enable modern compatibility mode in layout tests.
21
22         * WebKitTestRunner/TestController.cpp:
23         (WTR::updateTestOptionsFromTestHeader):
24         * WebKitTestRunner/TestController.h:
25         * WebKitTestRunner/TestOptions.h:
26         (WTR::TestOptions::hasSameInitializationOptions const):
27         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
28         (WTR::TestController::platformCreateWebView):
29         (WTR::TestController::enableModernCompatibilityMode):
30
31 2019-04-10  Andy Estes  <aestes@apple.com>
32
33         Try to fix the 32-bit watchOS build.
34
35         * TestWebKitAPI/cocoa/TestWKWebView.mm:
36         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
37
38 2019-04-10  Antoine Quint  <graouts@apple.com>
39
40         Enable Pointer Events on watchOS
41         https://bugs.webkit.org/show_bug.cgi?id=196771
42         <rdar://problem/49040909>
43
44         Reviewed by Dean Jackson.
45
46         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
47
48 2019-04-10  Philippe Normand  <pnormand@igalia.com>
49
50         Unreviewed. Fix WPE accessibility tests after r244059.
51
52         We are failing to load the injected bundle due to undefined symbol
53         AccessibilityUIElement::replaceTextInRange().
54
55         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
56         (WTR::AccessibilityUIElement::replaceTextInRange):
57
58 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
59
60         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
61         https://bugs.webkit.org/show_bug.cgi?id=196727
62
63         Reviewed by Fujii Hironori.
64
65         * MiniBrowser/win/WebKitBrowserWindow.cpp:
66         (WebKitBrowserWindow::create):
67
68 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
69
70         [ews-build] Add unit tests for PrintConfiguration
71         https://bugs.webkit.org/show_bug.cgi?id=196752
72
73         Reviewed by Dewei Zhu.
74
75         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
76
77 2019-04-09  Keith Rollin  <krollin@apple.com>
78
79         Unreviewed build maintenance -- update .xcfilelists.
80
81         * DumpRenderTree/DerivedSources-input.xcfilelist:
82         * DumpRenderTree/DerivedSources-output.xcfilelist:
83
84 2019-04-09  Zalan Bujtas  <zalan@apple.com>
85
86         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
87         https://bugs.webkit.org/show_bug.cgi?id=196743
88         <rdar://problem/43897551>
89
90         Reviewed by Tim Horton.
91
92         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
93         (TEST):
94
95 2019-04-09  Youenn Fablet  <youenn@apple.com>
96
97         Close service worker database on network process suspension
98         https://bugs.webkit.org/show_bug.cgi?id=196623
99         <rdar://problem/48930869>
100
101         Reviewed by Alex Christensen.
102
103         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
104
105 2019-04-09  Daniel Bates  <dabates@apple.com>
106
107         [iPad] Should open popover when the spacebar is pressed
108         https://bugs.webkit.org/show_bug.cgi?id=196360
109         <rdar://problem/49389129>
110
111         Reviewed by Brent Fulgham.
112
113         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
114
115         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
116         (WTR::UIScriptController::isShowingPopover const): Added.
117         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
118         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
119         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
120         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
121         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
122         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
123         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
124         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
125         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
126         (WTR::UIScriptController::isShowingPopover const): Added.
127         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
128         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
129         * TestRunnerShared/UIScriptContext/UIScriptController.h:
130         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
131         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
132         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
133         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
134         (-[TestRunnerWKWebView _willPresentPopover]): Added.
135         (-[TestRunnerWKWebView _didDismissPopover]): Added.
136         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
137         (WTR::UIScriptController::isShowingPopover const): Added.
138         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
139         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
140
141 2019-04-09  Alex Christensen  <achristensen@webkit.org>
142
143         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
144         https://bugs.webkit.org/show_bug.cgi?id=196665
145         <rdar://45115669>
146
147         Reviewed by Geoff Garen.
148
149         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
150         (goBack):
151         (+[SimpleLookupContext sharedLookupContext]):
152         (-[SimpleLookupContext lookUpURL:completionHandler:]):
153         (TEST):
154         (+[Simple3LookupContext sharedLookupContext]): Deleted.
155         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
156
157 2019-04-09  John Wilander  <wilander@apple.com>
158
159         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
160         https://bugs.webkit.org/show_bug.cgi?id=196558
161         <rdar://problem/47650245>
162
163         Reviewed by Youenn Fablet.
164
165         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
166         (TestWebKitAPI::TEST):
167             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
168
169 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
170
171         [CMake] Apple builds should use ICU_INCLUDE_DIRS
172         https://bugs.webkit.org/show_bug.cgi?id=196720
173
174         Reviewed by Konstantin Tokarev.
175
176         * TestWebKitAPI/PlatformMac.cmake:
177
178 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
179
180         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
181         https://bugs.webkit.org/show_bug.cgi?id=196694
182         <rdar://problem/48388734>
183
184         Rubber-stamped by Aakash Jain.
185
186         * Scripts/webkitpy/port/image_diff.py:
187         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
188         * Scripts/webkitpy/port/server_process.py:
189         (ServerProcess.has_available_stdout): Check if stdout has data in it.
190         (ServerProcess._wait_for_data_and_update_buffers_using_select):
191         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
192         * Scripts/webkitpy/port/server_process_mock.py:
193         (MockServerProcess.has_available_stdout):
194         * Scripts/webkitpy/port/server_process_unittest.py:
195         (TestServerProcess.serial_test_basic):
196
197 2019-04-09  Jer Noble  <jer.noble@apple.com>
198
199         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
200         https://bugs.webkit.org/show_bug.cgi?id=196097
201
202         Reviewed by Eric Carlson.
203
204         Drive-by bug fix: allow tests to play audio without a user gesture by default.
205
206         * DumpRenderTree/mac/DumpRenderTree.mm:
207         (resetWebPreferencesToConsistentValues):
208         * WebKitTestRunner/TestController.cpp:
209         (WTR::TestController::resetPreferencesToConsistentValues):
210
211 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
212
213         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
214         https://bugs.webkit.org/show_bug.cgi?id=196690
215
216         Reviewed by Michael Catanzaro.
217
218         * QueueStatusServer/config/queues.py:
219         * Scripts/webkitpy/common/config/ews.json:
220         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
221         (test_ews_name):
222
223 2019-04-09  Chris Dumez  <cdumez@apple.com>
224
225         Loads using loadHTMLString() cause flashing when process-swapping
226         https://bugs.webkit.org/show_bug.cgi?id=196714
227         <rdar://problem/49637354>
228
229         Reviewed by Antti Koivisto.
230
231         Add API test coverage.
232
233         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
234
235 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
236
237         Unreviewed. Fix ATK accessibility tests after r244059.
238
239         We are failing to load the injected bundle due to undefined symbol
240         AccessibilityUIElement::replaceTextInRange().
241
242         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
243         (WTR::AccessibilityUIElement::replaceTextInRange):
244
245 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
246
247         AX: Support API: accessibilityReplaceRange:withText
248         https://bugs.webkit.org/show_bug.cgi?id=196636
249
250         Unreviewed build fix for Windows port.
251
252         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
253         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
254
255 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
256
257         [CMake][WinCairo] Separate copied headers into different directories
258         https://bugs.webkit.org/show_bug.cgi?id=196655
259
260         Reviewed by Michael Catanzaro.
261
262         * DumpRenderTree/CMakeLists.txt:
263         * MiniBrowser/win/CMakeLists.txt:
264         * TestWebKitAPI/CMakeLists.txt:
265         * TestWebKitAPI/PlatformWin.cmake:
266
267 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
268
269         Log stack-trace for run-webkit-tests when interrupted
270         https://bugs.webkit.org/show_bug.cgi?id=176393
271         <rdar://problem/34262310>
272
273         Reviewed by Lucas Forschler.
274
275         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
276         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
277         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
278         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
279         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
280         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
281         (main): Set handlers to log stack trace on interruption.
282
283 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
284
285         AX: Support API: accessibilityReplaceRange:withText
286         https://bugs.webkit.org/show_bug.cgi?id=196636
287
288         Unreviewed build fix for Windows port.
289
290         * DumpRenderTree/AccessibilityUIElement.cpp:
291         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
292
293 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
294
295         [ews-build] Scripts using Buildbot API have CORS error
296         https://bugs.webkit.org/show_bug.cgi?id=196709
297
298         Reviewed by Alexey Proskuryakov.
299
300         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
301
302 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
303
304         AX: Support API: accessibilityReplaceRange:withText
305         https://bugs.webkit.org/show_bug.cgi?id=196636
306
307         Reviewed by Daniel Bates.
308
309         * DumpRenderTree/AccessibilityUIElement.cpp:
310         (replaceTextInRangeCallback):
311         (AccessibilityUIElement::replaceTextInRange):
312         (AccessibilityUIElement::getJSClass):
313         * DumpRenderTree/AccessibilityUIElement.h:
314         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
315         (AccessibilityUIElement::replaceTextInRange):
316         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
317         (AccessibilityUIElement::replaceTextInRange):
318         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
319         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
320         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
321         (WTR::AccessibilityUIElement::replaceTextInRange):
322         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
323         (WTR::AccessibilityUIElement::replaceTextInRange):
324
325 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
326
327         [iOS] Do not allow starting selection drags when selection views are not visible
328         https://bugs.webkit.org/show_bug.cgi?id=196686
329         <rdar://problem/49399192>
330
331         Reviewed by Tim Horton.
332
333         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
334         also add some new API tests to cover scenarios where the web view is not first responder.
335
336         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
337         (TestWebKitAPI::TEST):
338         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
339
340         Add a switch to optionally make the web view first responder when starting the simulated drag.
341
342         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
343         (-[DragAndDropSimulator initWithWebView:]):
344         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
345
346 2019-04-08  Justin Fan  <justin_fan@apple.com>
347
348         [Web GPU] Fix Web GPU experimental feature on iOS
349         https://bugs.webkit.org/show_bug.cgi?id=196632
350
351         Reviewed by Myles C. Maxfield.
352
353         Properly make Web GPU available on iOS 11+.
354
355         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
356
357 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
358
359         [ews-build] Do not upload archive when Compile Fails
360         https://bugs.webkit.org/show_bug.cgi?id=196674
361
362         Reviewed by Alexey Proskuryakov.
363
364         * BuildSlaveSupport/ews-build/factories.py:
365         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
366         * BuildSlaveSupport/ews-build/steps.py:
367         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
368         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
369         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
370
371 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
372
373         Enable DFG on MIPS
374         https://bugs.webkit.org/show_bug.cgi?id=196689
375
376         Reviewed by Žan Doberšek.
377
378         Since the bytecode change, we enabled the baseline JIT on mips in
379         r240432, but DFG is still missing. With this change, all tests are
380         passing on a ci20 board.
381
382         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
383
384 2019-04-08  Philippe Normand  <pnormand@igalia.com>
385
386         [Flatpak] Second run update-webkitwpe-flatpak fails
387         https://bugs.webkit.org/show_bug.cgi?id=192702
388
389         Reviewed by Carlos Garcia Campos.
390
391         * flatpak/flatpakutils.py:
392         (FlatpakObject.flatpak): Fix typo.
393         (FlatpakPackage.install): When installing, also update to the configured remote commit.
394         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
395
396 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
397
398         [GTK][WPE] outlook.live.com displays old-fashioned UI
399         https://bugs.webkit.org/show_bug.cgi?id=196642
400
401         Reviewed by Carlos Garcia Campos.
402
403         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
404         (TestWebKitAPI::TEST): New Mac platform quirk test.
405
406 2019-04-07  Commit Queue  <commit-queue@webkit.org>
407
408         Unreviewed, rolling out r243956.
409         https://bugs.webkit.org/show_bug.cgi?id=196688
410
411         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
412         by aakashjain on #webkit).
413
414         Reverted changeset:
415
416         "Clicking "Go Back" from a safe browsing warning from an
417         iframe should navigate the WKWebView back to the previous
418         page"
419         https://bugs.webkit.org/show_bug.cgi?id=196665
420         https://trac.webkit.org/changeset/243956
421
422 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
423
424         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
425         https://bugs.webkit.org/show_bug.cgi?id=196669
426
427         Reviewed by Geoffrey Garen.
428
429         Added three new unit tests for WeakHashSet.
430
431         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
432         (WTF_WeakPtr.WeakHashSetConstObjects):
433         (WTF_WeakPtr.WeakHashSetComputesEmpty):
434         (WTF_WeakPtr.WeakHashSetComputeSize):
435
436 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
437
438         Hide next and previous form control buttons when WKWebView is editable
439         https://bugs.webkit.org/show_bug.cgi?id=196672
440         <rdar://problem/35625321>
441
442         Reviewed by Tim Horton.
443
444         Add a new API test.
445
446         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
447         (-[TestWKWebView lastTrailingBarButtonGroup]):
448         (TestWebKitAPI::TEST):
449         * TestWebKitAPI/ios/UIKitSPI.h:
450
451 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
452
453         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
454         https://bugs.webkit.org/show_bug.cgi?id=196077
455         <rdar://problem/49108202>
456
457         Reviewed by Chris Dumez.
458
459         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
460         on new web view.
461
462         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
463
464 2019-04-05  Saam Barati  <sbarati@apple.com>
465
466         Make compare-results understand MotionMark
467         https://bugs.webkit.org/show_bug.cgi?id=196666
468
469         Reviewed by Yusuke Suzuki.
470
471         * Scripts/compare-results:
472         (PLT5Results):
473         (detectMotionMark):
474         (detectMotionMark1_1):
475         (motionMarkResults):
476         (motionMark1_1Results):
477         (detectBenchmark):
478         (biggerIsBetter):
479         (main):
480
481 2019-04-05  Alex Christensen  <achristensen@webkit.org>
482
483         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
484         https://bugs.webkit.org/show_bug.cgi?id=196665
485         <rdar://45115669>
486
487         Reviewed by Geoff Garen.
488
489         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
490         (goBack):
491         (+[SimpleLookupContext sharedLookupContext]):
492         (-[SimpleLookupContext lookUpURL:completionHandler:]):
493         (TEST):
494         (+[Simple3LookupContext sharedLookupContext]): Deleted.
495         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
496
497 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
498
499         [ews-build] Add configuration and architecture for windows builders
500         https://bugs.webkit.org/show_bug.cgi?id=196660
501
502         Reviewed by Lucas Forschler.
503
504         * BuildSlaveSupport/ews-build/config.json:
505
506 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
507
508         webkitpy: Don't run subsequent rounds if interrupted
509         https://bugs.webkit.org/show_bug.cgi?id=196646
510
511         Reviewed by Aakash Jain.
512
513         * Scripts/webkitpy/layout_tests/controllers/manager.py:
514         (Manager.run): Bail out if interrupted.
515
516 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
517
518         Test sessionStorage in PSON private browsing mode
519         https://bugs.webkit.org/show_bug.cgi?id=196561
520
521         Reviewed by Alex Christensen.
522
523         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
524
525 2019-04-05  Commit Queue  <commit-queue@webkit.org>
526
527         Unreviewed, rolling out r243833.
528         https://bugs.webkit.org/show_bug.cgi?id=196645
529
530         This change breaks build of WPE and GTK ports (Requested by
531         annulen on #webkit).
532
533         Reverted changeset:
534
535         "[CMake][WTF] Mirror XCode header directories"
536         https://bugs.webkit.org/show_bug.cgi?id=191662
537         https://trac.webkit.org/changeset/243833
538
539 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
540
541         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
542         https://bugs.webkit.org/show_bug.cgi?id=196635
543
544         Reviewed by Antti Koivisto.
545         
546         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
547         for a test to enable async frame scrolling via:
548             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
549         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
550         
551         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
552
553         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
554         (WTR::InjectedBundle::beginTesting):
555         * WebKitTestRunner/TestController.cpp:
556         (WTR::TestController::resetPreferencesToConsistentValues):
557
558 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
559
560         Use a correct LC_RPATH when building with ASan
561         https://bugs.webkit.org/show_bug.cgi?id=196576
562
563         Reviewed by David Kilzer.
564
565         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
566         so that ../Frameworks is checked. This is simpler and more reliable than updating
567         each SPC service xcconfig.
568
569 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
570
571         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
572         https://bugs.webkit.org/show_bug.cgi?id=196629
573
574         Reviewed by Lucas Forschler.
575
576         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
577
578 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
579
580         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
581         https://bugs.webkit.org/show_bug.cgi?id=196618
582
583         Reviewed by Lucas Forschler.
584
585         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
586         (StatusBubble): Added QUEUE_TRIGGERS.
587         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
588         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
589         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
590         its parent(builder).
591
592 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
593
594         [ews-app] Status-bubble steps are sometimes displayed in reverse order
595         https://bugs.webkit.org/show_bug.cgi?id=196625
596
597         Reviewed by Lucas Forschler.
598
599         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
600         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
601
602 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
603
604         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
605         https://bugs.webkit.org/show_bug.cgi?id=196630
606
607         Reviewed by Wenson Hsieh.
608
609         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
610
611 2019-04-04  Youenn Fablet  <youenn@apple.com>
612
613         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
614         https://bugs.webkit.org/show_bug.cgi?id=196543
615
616         Reviewed by Alex Christensen.
617
618         * WebKitTestRunner/TestController.cpp:
619         (WTR::TestController::generatePageConfiguration):
620
621 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
622
623         [ews-app] Status bubble should not display skipped buildbot steps
624         https://bugs.webkit.org/show_bug.cgi?id=196584
625
626         Reviewed by Lucas Forschler.
627
628         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
629
630 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
631
632         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
633         https://bugs.webkit.org/show_bug.cgi?id=196620
634
635         Reviewed by Lucas Forschler.
636
637         * BuildSlaveSupport/ews-app/ews/config.py:
638
639 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
640
641         [Win] DumpRenderTreeWatchDog.py is not checked into source
642         https://bugs.webkit.org/show_bug.cgi?id=196567
643         <rdar://problem/49525901>
644
645         Reviewed by Lucas Forschler.
646
647         This script is used on Win EWS bots to terminate hanging DRT processes.
648
649         * EWSTools/dumprendertreewatchdog.py: Added.
650
651 2019-04-04  Chris Dumez  <cdumez@apple.com>
652
653         Unreviewed, roll out r243858 which made tests time out.
654
655         Disable new API tests on Windows instead.
656
657         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
658         (TestWebKitAPI::TEST):
659
660 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
661
662         [ATK] Cleanup WebPageAccessibilityObjectAtk
663         https://bugs.webkit.org/show_bug.cgi?id=196537
664
665         Reviewed by Michael Catanzaro.
666
667         Also consider files under atk directories as exceptions for GObject conventions.
668
669         * Scripts/webkitpy/style/checkers/cpp.py:
670         (check_identifier_name_in_declaration):
671
672 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
673
674         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
675         https://bugs.webkit.org/show_bug.cgi?id=196588
676         <rdar://problem/49365787>
677
678         Unreviewed build fix for Windows port.
679
680         error C3861: 'kill': identifier not found
681
682         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
683         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
684
685 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
686
687         [ews-build] Cancel build and similar operations should have authentication
688         https://bugs.webkit.org/show_bug.cgi?id=196520
689
690         Reviewed by Dewei Zhu.
691
692         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
693         environment variables.
694
695 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
696
697         [ews-build] Do not trigger queues which are not in production yet
698         https://bugs.webkit.org/show_bug.cgi?id=196581
699
700         Reviewed by Dewei Zhu.
701
702         * BuildSlaveSupport/ews-build/config.json:
703
704 2019-04-03  Chris Dumez  <cdumez@apple.com>
705
706         Unreviewed, fix typo in the name of API test added in r243848.
707
708         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
709         (TestWebKitAPI::TEST):
710
711 2019-04-03  Chris Dumez  <cdumez@apple.com>
712
713         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
714         https://bugs.webkit.org/show_bug.cgi?id=196588
715         <rdar://problem/49365787>
716
717         Reviewed by Ryosuke Niwa.
718
719         Add API test coverage.
720
721         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
722         (TestWebKitAPI::nullJavaScriptCallback):
723         (TestWebKitAPI::didCrashCheckFrames):
724         (TestWebKitAPI::TEST):
725
726 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
727
728         run-webkit-tests: Upload test results (new results database)
729         https://bugs.webkit.org/show_bug.cgi?id=196577
730         <rdar://problem/34841155>
731
732         Reviewed by Lucas Forschler.
733
734         * Scripts/webkitpy/layout_tests/controllers/manager.py:
735         (Manager.run): Upload results after each device shard, since the configuration will be
736         different for each device.
737         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
738         uploaded to a results database.
739         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
740         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
741
742 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
743
744         -apple-trailing-word is needed for browser detection
745         https://bugs.webkit.org/show_bug.cgi?id=196575
746
747         Unreviewed.
748
749         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
750
751 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
752
753         [CMake][WTF] Mirror XCode header directories
754         https://bugs.webkit.org/show_bug.cgi?id=191662
755
756         Reviewed by Konstantin Tokarev.
757
758         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
759         builds.
760
761         * CMakeLists.txt:
762         * DumpRenderTree/CMakeLists.txt:
763         * DumpRenderTree/PlatformWin.cmake:
764         * MiniBrowser/win/CMakeLists.txt:
765         * TestWebKitAPI/CMakeLists.txt:
766         * TestWebKitAPI/PlatformWin.cmake:
767         * WebKitTestRunner/PlatformGTK.cmake:
768         * WebKitTestRunner/PlatformWin.cmake:
769
770 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
771
772         [ews-app] Status bubble should not display certain infrastructure status messages
773         https://bugs.webkit.org/show_bug.cgi?id=196550
774
775         Reviewed by Lucas Forschler.
776
777         Do not display the steps which are un-needed for end-user. This information is still avaiable
778         if the user click on the bubble and look at the Buildbot build.
779         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
780         (StatusBubble._steps_messages):
781         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
782
783 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
784
785         [ews-build] Use https for sending data to ews-app
786         https://bugs.webkit.org/show_bug.cgi?id=196492
787
788         Reviewed by Lucas Forschler.
789
790         * BuildSlaveSupport/ews-build/events.py:
791
792 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
793
794         Remove support for -apple-trailing-word
795         https://bugs.webkit.org/show_bug.cgi?id=196525
796
797         Reviewed by Zalan Bujtas.
798
799         This CSS property is nonstandard and not used.
800
801         * Scripts/webkitperl/FeatureList.pm:
802         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
803
804 2019-04-03  Youenn Fablet  <youenn@apple.com>
805
806         Add a test for DOMCache on multiple browsing in case of private browsing
807         https://bugs.webkit.org/show_bug.cgi?id=196524
808
809         Reviewed by Alex Christensen.
810
811         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
812         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
813
814 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
815
816         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
817         https://bugs.webkit.org/show_bug.cgi?id=196540
818
819         Reviewed by Aakash Jain.
820
821         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
822
823 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
824
825         Add plumbing for a compatibility mode preference in WebKit
826         https://bugs.webkit.org/show_bug.cgi?id=196005
827
828         Reviewed by Tim Horton.
829
830         Add new API tests.
831
832         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
833         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
834
835 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
836
837         [WPE][GTK] Update libsrtp dependency package for Debian
838         https://bugs.webkit.org/show_bug.cgi?id=196528
839
840         Reviewed by Frédéric Wang.
841
842         * gtk/install-dependencies:
843         * wpe/install-dependencies:
844
845 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
846
847         [WK2] Add support for Window's beforeprint / afterprint events
848         https://bugs.webkit.org/show_bug.cgi?id=196478
849         <rdar://problem/49535124>
850
851         Unreviewed build fix for MSVC.
852
853         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
854
855         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
856
857         * WebKitTestRunner/TestController.cpp:
858         (WTR::printFrame): Use int and float literals.
859
860 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
861
862         [ews-build] Reassign bots to queues
863
864         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
865
866 2019-04-02  Chris Dumez  <cdumez@apple.com>
867
868         [WK2] Add support for Window's beforeprint / afterprint events
869         https://bugs.webkit.org/show_bug.cgi?id=196478
870
871         Reviewed by Alex Christensen.
872
873         Add minimal implementation for printFrame in WebKitTestRunner.
874
875         * WebKitTestRunner/TestController.cpp:
876         (WTR::printFrame):
877         (WTR::TestController::createOtherPage):
878         (WTR::TestController::createWebViewWithOptions):
879
880 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
881
882         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
883         https://bugs.webkit.org/show_bug.cgi?id=196491
884
885         Reviewed by Lucas Forschler.
886
887         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
888
889 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
890
891         [ews-build] Configure buildbot try credentials in environment variables
892         https://bugs.webkit.org/show_bug.cgi?id=196501
893
894         Reviewed by Lucas Forschler.
895
896         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
897         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
898         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
899
900 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
901
902         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
903         https://bugs.webkit.org/show_bug.cgi?id=196496
904         <rdar://problem/49521634>
905
906         Reviewed by Chris Dumez.
907
908         Add new API tests (see WebKit ChangeLog for more detail).
909
910         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
911         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
912         (TEST):
913
914 2019-04-02  David Kilzer  <ddkilzer@apple.com>
915
916         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
917         <https://webkit.org/b/196499>
918
919         Reviewed by Alexey Proskuryakov.
920
921         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
922         ENABLE_ADDRESS_SANITIZER.
923
924 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
925
926         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
927         https://bugs.webkit.org/show_bug.cgi?id=182757
928
929         Reviewed by Don Olmstead.
930
931         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
932         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
933
934 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
935
936         run-api-tests: Upload test results
937         https://bugs.webkit.org/show_bug.cgi?id=196323
938         <rdar://problem/49356714>
939
940         Reviewed by Lucas Forschler.
941
942         * Scripts/webkitpy/api_tests/manager.py:
943         (Manager):
944         (Manager.run): Upload results to a results database.
945         * Scripts/webkitpy/api_tests/run_api_tests.py:
946         (parse_args): Add upload arguments.
947         * Scripts/webkitpy/port/base.py:
948         (Port):
949         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
950         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
951         with commits from any other associated repositories.
952         * Scripts/webkitpy/port/device.py:
953         (Device):
954         (Device.build_version): Access build_versoin of underlying platform device.
955         * Scripts/webkitpy/port/ios_simulator_unittest.py:
956         (IOSSimulatorTest):
957         (IOSSimulatorTest.test_configuration_for_upload):
958         * Scripts/webkitpy/port/device_port.py:
959         (DevicePort):
960         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
961         the same as the machine uploading results.
962         * Scripts/webkitpy/port/mac.py:
963         (MacPort):
964         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
965         * Scripts/webkitpy/port/mac_unittest.py:
966         (MacTest):
967         (MacTest.test_configuration_for_upload):
968         * Scripts/webkitpy/xcode/simulated_device.py:
969         (SimulatedDeviceManager._create_device_with_runtime):
970         (SimulatedDevice.__init__): Create simulated device with a build_version.
971         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
972         (test_existing_simulator):
973
974 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
975
976         Remove extra newline characters (Follow-up fix to r243707)
977
978         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
979
980 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
981
982         [ews-app] Use API_KEY to accept results data
983         https://bugs.webkit.org/show_bug.cgi?id=196461
984
985         Reviewed by Dewei Zhu.
986
987         * BuildSlaveSupport/ews-app/ews/views/results.py:
988         (Results.post): Validate EWS_API_KEY before accepting any data.
989         * BuildSlaveSupport/ews-build/events.py:
990         (Events.sendData): Send EWS_API_KEY if available along with event data.
991
992 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
993
994         Unable to copy and paste a PDF from Notes into Mail compose body
995         https://bugs.webkit.org/show_bug.cgi?id=196442
996         <rdar://problem/48573098>
997
998         Reviewed by Tim Horton.
999
1000         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1001         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1002         to be specified on the item providers.
1003
1004         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1005         (TestWebKitAPI::mapItemForTesting):
1006         (TestWebKitAPI::contactItemForTesting):
1007
1008 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1009
1010         Make UIWKDocumentContext rects per-character instead of per-word
1011         https://bugs.webkit.org/show_bug.cgi?id=196459
1012
1013         Reviewed by Wenson Hsieh.
1014
1015         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1016         (TEST):
1017         Adjust test results due to switching to per-character rects.
1018
1019 2019-04-01  Chris Dumez  <cdumez@apple.com>
1020
1021         UIProcess crash when a prewarmed process is terminated
1022         https://bugs.webkit.org/show_bug.cgi?id=196451
1023         <rdar://problem/49245471>
1024
1025         Reviewed by Geoffrey Garen.
1026
1027         Add API test coverage.
1028
1029         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1030         (TEST):
1031
1032 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1033
1034         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1035         https://bugs.webkit.org/show_bug.cgi?id=196449
1036
1037         Reviewed by Lucas Forschler.
1038
1039         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1040         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1041         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1042         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1043
1044 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1045
1046         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1047         https://bugs.webkit.org/show_bug.cgi?id=196444
1048
1049         Reviewed by Lucas Forschler.
1050
1051         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1052
1053 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1054
1055         Add SPI to canonicalize NSURLs with WTF::URL
1056         https://bugs.webkit.org/show_bug.cgi?id=196415
1057         <rdar://problem/44980271>
1058
1059         Reviewed by Darin Adler.
1060
1061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1062         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1063         (TestWebKitAPI::TEST):
1064
1065 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1066
1067         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1068         https://bugs.webkit.org/show_bug.cgi?id=196441
1069
1070         Reviewed by Carlos Garcia Campos.
1071
1072         Don't cache the wpe_view_backend object that might not exist yet at the
1073         time of EventSenderProxy constructor invocation, but instead retrieve
1074         that object whenever it's required for event dispatching. This should
1075         avoid crashes in this constructor now that it's invoked before any
1076         PlatformWindow has been set up (as changed in r243496).
1077
1078         * WebKitTestRunner/EventSenderProxy.h:
1079         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1080         (WTR::viewBackend):
1081         (WTR::EventSenderProxy::EventSenderProxy):
1082         (WTR::EventSenderProxy::mouseDown):
1083         (WTR::EventSenderProxy::mouseUp):
1084         (WTR::EventSenderProxy::mouseMoveTo):
1085         (WTR::EventSenderProxy::mouseScrollBy):
1086         (WTR::EventSenderProxy::keyDown):
1087         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1088
1089 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1090
1091         [Win][WebKit] MiniBrowser should support high DPI display
1092         https://bugs.webkit.org/show_bug.cgi?id=196391
1093
1094         Reviewed by Alex Christensen.
1095
1096         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1097         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1098         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1099         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1100
1101 2019-03-31  Sam Weinig  <weinig@apple.com>
1102
1103         Remove more i386 specific configurations
1104         https://bugs.webkit.org/show_bug.cgi?id=196430
1105
1106         Reviewed by Alexey Proskuryakov.
1107
1108         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1109         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1110
1111 2019-03-31  Andy Estes  <aestes@apple.com>
1112
1113         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1114         https://bugs.webkit.org/show_bug.cgi?id=196433
1115         <rdar://problem/49293305>
1116
1117         Reviewed by Tim Horton.
1118
1119         Enhanced API test coverage to include all navigation response policy decisions in both
1120         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1121
1122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1123         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1124         (TestWebKitAPI::TEST):
1125         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1126         (readFile):
1127         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1128         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1129         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1130         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1131         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1132         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1133         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1134         (-[QuickLookDelegate _downloadDidStart:]):
1135         (-[QuickLookDelegate _download:didReceiveResponse:]):
1136         (-[QuickLookDelegate _download:didReceiveData:]):
1137         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1138         (-[QuickLookDelegate _downloadDidFinish:]):
1139         (-[QuickLookDelegate _download:didFailWithError:]):
1140         (-[QuickLookDelegate _downloadDidCancel:]):
1141         (-[QuickLookDelegate verifyDownload]):
1142         (runTest):
1143         (runTestDecideBeforeLoading):
1144         (runTestDecideAfterLoading):
1145         (TEST):
1146         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1147         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1148         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1149         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1150         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1151         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1152         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1153         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1154         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1155         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1156         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1157         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1158         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1159         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1160
1161 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1162
1163         [CMake] add testdfg as target with build-jsc
1164         https://bugs.webkit.org/show_bug.cgi?id=196393
1165
1166         Reviewed by Saam Barati.
1167
1168         Added testdfg as one of the targets to build when
1169         using CMake.
1170
1171         * Scripts/build-jsc:
1172
1173 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1174
1175         Delete WebMetal implementation in favor of WebGPU
1176         https://bugs.webkit.org/show_bug.cgi?id=195418
1177
1178         Reviewed by Dean Jackson.
1179
1180         * DumpRenderTree/mac/DumpRenderTree.mm:
1181         (enableExperimentalFeatures):
1182         (resetWebPreferencesToConsistentValues):
1183         * Scripts/webkitperl/FeatureList.pm:
1184         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1186         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1187         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1188         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1189         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1190         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1191         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1192         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1193         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1194         (WTR::InjectedBundle::beginTesting):
1195         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1196         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1197         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1198
1199 2019-03-29  Chris Dumez  <cdumez@apple.com>
1200
1201         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1202         https://bugs.webkit.org/show_bug.cgi?id=196405
1203         <rdar://problem/49428130>
1204
1205         Reviewed by Wenson Hsieh.
1206
1207         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1208         the popover presentation methods to be no-ops. Use this in the new test added in
1209         r243523 so that we do not swizzle those methods for all tests. This is needed because
1210         those WatchOS tests rely on the popover getting presented and interactive.
1211
1212         * WebKitTestRunner/TestController.cpp:
1213         (WTR::updateTestOptionsFromTestHeader):
1214         * WebKitTestRunner/TestController.h:
1215         * WebKitTestRunner/TestOptions.h:
1216         (WTR::TestOptions::hasSameInitializationOptions const):
1217         * WebKitTestRunner/ios/TestControllerIOS.mm:
1218         (WTR::TestController::platformInitialize):
1219         (WTR::TestController::platformResetStateToConsistentValues):
1220
1221 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1222
1223         [Curl] Add Server Trust Evaluation Support.
1224         https://bugs.webkit.org/show_bug.cgi?id=191646
1225
1226         Reviewed by Fujii Hironori.
1227
1228         Implemented MiniBrowser UI for asking if user trusts the server.
1229
1230         * MiniBrowser/win/Common.cpp:
1231         (askServerTrustEvaluation):
1232         (replaceString):
1233         * MiniBrowser/win/Common.h:
1234         * MiniBrowser/win/MiniBrowserLib.rc:
1235         * MiniBrowser/win/MiniBrowserLibResource.h:
1236         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1237         (createPEMString):
1238         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1239         (WebKitBrowserWindow::canTrustServerCertificate):
1240         * MiniBrowser/win/WebKitBrowserWindow.h:
1241
1242 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1243
1244         Implement ResizeObserver.
1245         https://bugs.webkit.org/show_bug.cgi?id=157743
1246
1247         Reviewed by Simon Fraser.
1248
1249         Support resizeObserverEnabled webPreferences.
1250
1251         * DumpRenderTree/TestOptions.cpp:
1252         (TestOptions::TestOptions):
1253         * DumpRenderTree/TestOptions.h:
1254         * DumpRenderTree/mac/DumpRenderTree.mm:
1255         (setWebPreferencesForTestOptions):
1256         * DumpRenderTree/win/DumpRenderTree.cpp:
1257         (enableExperimentalFeatures):
1258         * Scripts/webkitperl/FeatureList.pm:
1259         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1260
1261 2019-03-28  John Wilander  <wilander@apple.com>
1262
1263         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1264         https://bugs.webkit.org/show_bug.cgi?id=196281
1265         <rdar://problem/48938748>
1266
1267         Reviewed by Alex Christensen.
1268
1269         This patch adds the function isStatisticsHasLocalStorage() to the
1270         TestRunner. With it, the page can query the WebsiteDataStore in the
1271         UI process to make sure that it sees LocalStorage.
1272
1273         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1274         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1275         (WTR::TestRunner::isStatisticsHasLocalStorage):
1276         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1277         * WebKitTestRunner/TestController.cpp:
1278         (WTR::TestController::isStatisticsHasLocalStorage):
1279         * WebKitTestRunner/TestController.h:
1280         * WebKitTestRunner/TestInvocation.cpp:
1281         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1282
1283 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1284
1285         API::Data::createWithoutCopying should do a null check before calling CFRelease
1286         https://bugs.webkit.org/show_bug.cgi?id=196276
1287         <rdar://problem/48059859>
1288
1289         Reviewed by Alex Christensen.
1290
1291         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1292
1293         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1294         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1295         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1296         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1297         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1298         (TestWebKitAPI::TEST):
1299
1300 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1301
1302         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1303         https://bugs.webkit.org/show_bug.cgi?id=186276
1304
1305         Reviewed by Carlos Garcia Campos.
1306
1307         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1308         (webViewLoadChanged):
1309         (testWebResourceGetDataError):
1310         (testWebResourceGetDataEmpty):
1311         (beforeAll):
1312         (webViewloadChanged): Deleted.
1313
1314 2019-03-27  Andy Estes  <aestes@apple.com>
1315
1316         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1317         https://bugs.webkit.org/show_bug.cgi?id=196317
1318
1319         Reviewed by Dan Bernstein.
1320
1321         package-root copies built products into a staging directory using ditto(1), which does not
1322         follow symbolic links as it traverses a directory. Now that the files in
1323         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1324         itself, these become broken links when ditto'd into the staging directory.
1325
1326         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1327
1328         * Scripts/package-root:
1329
1330 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1331
1332         [ews-app] Update display text of Submit for ews analysis
1333         https://bugs.webkit.org/show_bug.cgi?id=196309
1334
1335         Reviewed by Dewei Zhu.
1336
1337         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1338
1339 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1340
1341         run-webkit-tests should check for leaks in WebKit processes
1342         <https://webkit.org/b/193772>
1343         <rdar://problem/46526680>
1344
1345         Reviewed by Ryosuke Niwa.
1346
1347         This works by doing the following:
1348         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1349           The list of child processes are returned one per line:
1350           process.name: pid
1351         - Run the "#LIST CHILD PROCESSES" command just before the
1352           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1353           processes on the ServerProcess object.
1354         - When the `--leaks` switch is handled, run check_for_leaks() on
1355           each child process after the main test harness.
1356
1357         * DumpRenderTree/mac/DumpRenderTree.mm:
1358         (handleControlCommand):
1359         - Use strncmp() instead of strcmp().
1360         - Add support for handling "#LIST CHILD PROCESSES" command.
1361
1362         * Scripts/webkitpy/port/base.py:
1363         (Port.check_for_leaks):
1364         * Scripts/webkitpy/port/darwin.py:
1365         (DarwinPort.check_for_leaks):
1366         - Rename redundant 'process_pid' argument to 'process_id'.
1367
1368         * Scripts/webkitpy/port/driver.py:
1369         (Driver.do_post_tests_work):
1370         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1371           longer the only command this sends to WebKitTestRunner.
1372         - If the `--leaks` switch is present, send the
1373           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1374           result using Port.set_webkit_processes().
1375         (Driver._parse_child_processes_output):
1376         - Add helper method to parse list of child process names and
1377           process IDs returned from WebKitTestRunner.
1378
1379         * Scripts/webkitpy/port/ios_device.py:
1380         (IOSDevicePort.check_for_leaks):
1381         - Rename redundant 'process_pid' argument to 'process_id'.
1382
1383         * Scripts/webkitpy/port/leakdetector.py:
1384         (LeakDetector._parse_leaks_output):
1385         - Return early if there is no leaks_output.
1386         (LeakDetector.check_for_leaks):
1387         - Rename redundant 'process_pid' argument to 'process_id'.
1388
1389         * Scripts/webkitpy/port/server_process.py:
1390         (ServerProcess.__init__):
1391         (ServerProcess.child_processes):
1392         (ServerProcess.set_child_processes):
1393         - Add instance variable to Port to store list of child process
1394           names and process IDs returned from WebKitTestRunner.
1395         (ServerProcess._start):
1396         - Clear self._child_processes.
1397         (ServerProcess.stop):
1398         - If self._child_processes is set, call
1399           self._port.check_for_leaks() for each child process.
1400
1401         * Scripts/webkitpy/port/server_process_unittest.py:
1402         (TrivialMockPort.check_for_leaks):
1403         - Rename redundant 'process_pid' argument to 'process_id'.
1404
1405         * Scripts/webkitpy/port/simulator_process.py:
1406         (SimulatorProcess.stop):
1407         - If self._child_processes is set, call
1408           self._port.check_for_leaks() for each child process.
1409
1410         * Scripts/webkitpy/port/watch_device.py:
1411         (WatchDevicePort.check_for_leaks):
1412         - Rename redundant 'process_pid' argument to 'process_id'.
1413
1414         * WebKitTestRunner/TestController.cpp:
1415         (WTR::TestController::dumpResponse):
1416         - Extract method from findAndDumpWorldLeaks() so that it may be
1417           reused by findAndDumpWebKitProcessIdentifiers().
1418         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1419         - Add method to output process name and process ID of both the
1420           WebContent and Networking processes.
1421         (WTR::TestController::findAndDumpWorldLeaks):
1422         - Fix missing newline in output when there were no abandoned
1423           documents.
1424         - Call dumpResponse() for extracted code.
1425         (WTR::TestController::handleControlCommand):
1426         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1427         - Use strncmp() instead of strcmp().
1428         - Call findAndDumpWebKitProcessIdentifiers() when
1429           "#LIST CHILD PROCESSES" command is sent.
1430         * WebKitTestRunner/TestController.h:
1431         (WTR::TestController::dumpResponse):
1432         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1433         - Declare methods.
1434
1435 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1436
1437         Unreviewed. Add GLib API test cases after r243434.
1438
1439         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1440         (testWebViewActiveURI):
1441         (serverCallback):
1442         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1443         (sendRequestCallback):
1444
1445 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1446
1447         Geolocation request not complete when watch request was started in a different web process
1448         https://bugs.webkit.org/show_bug.cgi?id=195996
1449
1450         Reviewed by Alex Christensen.
1451
1452         Add a test case.
1453
1454         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1455         (TestWebKitAPI::runJavaScriptAlert):
1456         (TestWebKitAPI::TEST):
1457
1458 2019-03-26  Keith Rollin  <krollin@apple.com>
1459
1460         Update the way generate-xcfilelists returns strings from functions
1461         https://bugs.webkit.org/show_bug.cgi?id=195975
1462         <rdar://problem/49040807>
1463
1464         Reviewed by Dean Jackson.
1465
1466         There are places where generate-xcfilelists executes assignments with
1467         statements like:
1468
1469             FOO=$(some_function)
1470
1471         where "some_function" return a string by echoing it. E.g.
1472
1473             some_function()
1474             {
1475                 echo "Hello, World"
1476             }
1477
1478         This is a common idiom, but it has a problem if "some_function" needs
1479         to call "exit" in an attempt to halt the entire script right then and
1480         there. Since "some_function" is called inside of $(), it's being
1481         executed in a sub-shell. Calling exit in that sub-shell simply exits
1482         that shell; it doesn't not exit the outer shell in which the main part
1483         of the script is still running. As such, the main script keeps
1484         executing when the intent was for the script to halt.
1485
1486         The solution to this is to use a different idiom for returning
1487         strings. The one we now is to pass in the name of the variable to
1488         receive the string result:
1489
1490             some_function()
1491             {
1492                 variable_name=$1
1493                 eval $variable_name ="Hello, World"
1494             }
1495
1496         The call site now looks like
1497
1498             some_function FOO
1499
1500         Because there's no invocation of a sub-shell, some_function can now
1501         call "exit" if it wants to, and the entire script will exit at that
1502         point.
1503
1504         * Scripts/generate-xcfilelists:
1505
1506 2019-03-26  Chris Dumez  <cdumez@apple.com>
1507
1508         Add basic layout test coverage for File Picker on iOS
1509         https://bugs.webkit.org/show_bug.cgi?id=196265
1510
1511         Reviewed by Wenson Hsieh.
1512
1513         Add layout test infrastructure to test the file picker on iOS.
1514
1515         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1516         (WTR::UIScriptController::dismissFilePicker):
1517         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1518         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1519         (WTR::UIScriptController::dismissFilePicker):
1520         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1521         * WebKitTestRunner/TestController.cpp:
1522         (WTR::TestController::createWebViewWithOptions):
1523         (WTR::updateTestOptionsFromTestHeader):
1524         * WebKitTestRunner/TestOptions.h:
1525         (WTR::TestOptions::hasSameInitializationOptions const):
1526         * WebKitTestRunner/ios/TestControllerIOS.mm:
1527         (overridePresentViewController):
1528         (WTR::TestController::platformInitialize):
1529         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1530         (WTR::UIScriptController::dismissFilePicker):
1531
1532 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1533
1534         Implement async paste method on UIWKInteractionViewProtocol
1535         https://bugs.webkit.org/show_bug.cgi?id=196267
1536         <rdar://problem/49236346>
1537
1538         Reviewed by Tim Horton.
1539
1540         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1541         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1542         are now a part of all iOS 12 internal SDKs.
1543
1544         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1545
1546         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1547         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1548
1549         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1550         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1551         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1552         * TestWebKitAPI/ios/UIKitSPI.h:
1553
1554 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1555
1556         [ews-build] Use PostgreSQL for ews.webkit.org database
1557         https://bugs.webkit.org/show_bug.cgi?id=196270
1558
1559         Reviewed by Lucas Forschler.
1560
1561         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1562
1563 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1564
1565         [ews] Reset simctl states on reboot
1566         https://bugs.webkit.org/show_bug.cgi?id=196260
1567
1568         Rubber-stamped by Aakash Jain.
1569
1570         * EWSTools/start-queue-mac.sh:
1571
1572 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1573
1574         [ews-build] Use PostgreSQL for ews-build database
1575         https://bugs.webkit.org/show_bug.cgi?id=196229
1576
1577         Reviewed by Lucas Forschler.
1578
1579         * BuildSlaveSupport/ews-build/master.cfg:
1580
1581 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1582
1583         [ews-build] Get master_hostname dynamically in master.cfg
1584         https://bugs.webkit.org/show_bug.cgi?id=196255
1585
1586         Reviewed by Lucas Forschler.
1587
1588         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1589         send events data in test mode.
1590
1591 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1592
1593         [ews-app] Set db_constraint to False for Foreign Keys
1594         https://bugs.webkit.org/show_bug.cgi?id=196252
1595
1596         Reviewed by Lucas Forschler.
1597
1598         * BuildSlaveSupport/ews-app/ews/models/build.py:
1599         * BuildSlaveSupport/ews-app/ews/models/step.py:
1600
1601 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1602
1603         [ews-build] is_test_mode_enabled should default to True
1604         https://bugs.webkit.org/show_bug.cgi?id=196248
1605
1606         Reviewed by Lucas Forschler.
1607
1608         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1609
1610 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1611
1612         [ews-app] Add webkitperl to ENABLED_QUEUES
1613         https://bugs.webkit.org/show_bug.cgi?id=196253
1614
1615         Reviewed by Lucas Forschler.
1616
1617         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1618
1619 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1620
1621         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1622         https://bugs.webkit.org/show_bug.cgi?id=196211
1623         rdar://problem/49110552
1624
1625         Reviewed by Tim Horton.
1626
1627         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1628         Make sure that EventSenderProxy always exists when running tests. We used to create
1629         it when resetting before the first test, which is a bit too late.
1630
1631         * WebKitTestRunner/TestController.h:
1632         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1633         (WTR::TestController::platformCreateWebView):
1634         (WTR::TestController::platformCreateOtherPage):
1635         (WTR::TestController::finishCreatingPlatformWebView):
1636         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1637         (WTR::PlatformWebView::PlatformWebView):
1638         Moved some code that made NSWindow use NSEvent during web view creation. We may
1639         need to move more if some other case us found, but this is enough for now.
1640
1641 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1642
1643         Unreviewed. Fix typo in GLib geolocation API after r243285.
1644
1645         gelocation -> geolocation.
1646
1647         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1648         (testGeolocationManagerWatchPosition):
1649
1650 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1651
1652         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1653         https://bugs.webkit.org/show_bug.cgi?id=196213
1654
1655         Reviewed by Geoff Garen.
1656
1657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1658         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1659         (credentialWithIdentityAndKeychainPath):
1660         (-[ChallengeDelegate webView:didFinishNavigation:]):
1661         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1662         (TestWebKitAPI::TEST):
1663
1664 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1665
1666         Expected shouldn't assume its contained types are copyable
1667         https://bugs.webkit.org/show_bug.cgi?id=195986
1668
1669         Reviewed by JF Bastien.
1670
1671         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1672         (TestWebKitAPI::NonCopyable::operator== const):
1673         (TestWebKitAPI::NonCopyable::operator!= const):
1674         (TestWebKitAPI::TEST):
1675
1676 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1677
1678         Remove some now-unnecessary dynamic class lookup
1679         https://bugs.webkit.org/show_bug.cgi?id=196237
1680
1681         Reviewed by Simon Fraser.
1682
1683         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1684         (makeRequest):
1685         (TEST):
1686
1687 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1688
1689         Unreviewed, rolling out r243450.
1690
1691         AppleWin and WinCairo port builds get broken.
1692
1693         Reverted changeset:
1694
1695         "Add test for fix of #196095"
1696         https://bugs.webkit.org/show_bug.cgi?id=196097
1697         https://trac.webkit.org/changeset/243450
1698
1699 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1700
1701         Unreviewed, rolling out r243465.
1702         https://bugs.webkit.org/show_bug.cgi?id=196226
1703
1704         the test doesn't build (Requested by thorton on #webkit).
1705
1706         Reverted changeset:
1707
1708         "Do not terminate the NetworkProcess if a third party
1709         application sends a NSCredential with a SecIdentityRef"
1710         https://bugs.webkit.org/show_bug.cgi?id=196213
1711         https://trac.webkit.org/changeset/243465
1712
1713 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1714
1715         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1716         https://bugs.webkit.org/show_bug.cgi?id=196213
1717
1718         Reviewed by Geoff Garen.
1719
1720         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1721         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1722         (credentialWithIdentityAndKeychainPath):
1723         (-[ChallengeDelegate webView:didFinishNavigation:]):
1724         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1725         (TestWebKitAPI::TEST):
1726
1727 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1728
1729         [ews-build] Gracefully handle missing patch_id in events
1730         https://bugs.webkit.org/show_bug.cgi?id=196216
1731
1732         Reviewed by Lucas Forschler.
1733
1734         * BuildSlaveSupport/ews-build/events.py:
1735
1736 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1737
1738         [ews-build] use lz4 compression for improving buildbot performance
1739         https://bugs.webkit.org/show_bug.cgi?id=196155
1740
1741         Reviewed by Lucas Forschler.
1742
1743         * BuildSlaveSupport/ews-build/master.cfg:
1744
1745 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1746
1747         Pull some API testing helper methods out of TestWKWebView
1748         https://bugs.webkit.org/show_bug.cgi?id=196212
1749
1750         Reviewed by Tim Horton.
1751
1752         Refactor some more API testing utility methods, so that they can be used in
1753         tests that do not use TestWKWebView.
1754
1755         * TestWebKitAPI/cocoa/TestWKWebView.h:
1756         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1757         (-[WKWebView loadTestPageNamed:]):
1758         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1759         (-[WKWebView synchronouslyLoadHTMLString:]):
1760         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1761         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1762         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1763         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1764         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1765
1766 2019-03-25  Jer Noble  <jer.noble@apple.com>
1767
1768         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1769         https://bugs.webkit.org/show_bug.cgi?id=196097
1770
1771         Reviewed by Eric Carlson.
1772
1773         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1774
1775         * DumpRenderTree/mac/DumpRenderTree.mm:
1776         (resetWebPreferencesToConsistentValues):
1777         * WebKitTestRunner/TestController.cpp:
1778         (WTR::TestController::resetPreferencesToConsistentValues):
1779
1780 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1781
1782         Pull IPadUserInterfaceSwizzler out into a separate header file
1783         https://bugs.webkit.org/show_bug.cgi?id=196193
1784
1785         Reviewed by Anders Carlsson.
1786
1787         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1788         be used in other API tests.
1789
1790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1791         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1792         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1793         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1794         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1795         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1796         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1797
1798 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1799
1800         Remove NavigatorContentUtils in WebCore/Modules
1801         https://bugs.webkit.org/show_bug.cgi?id=196070
1802
1803         Reviewed by Alex Christensen.
1804
1805         NavigatorContentUtils was to support the custom scheme spec [1].
1806         However, in WebKit side, no port has supported the feature in
1807         WebKit layer after EFL port was removed. So there has been the
1808         only IDL implementation of the NavigatorContentUtils in WebCore.
1809         So we don't need to keep the implementation in WebCore anymore.
1810
1811         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1812
1813         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1814
1815 2019-03-24  Andy Estes  <aestes@apple.com>
1816
1817         [watchOS] Remove unused Proximity Networking code
1818         https://bugs.webkit.org/show_bug.cgi?id=196188
1819
1820         Reviewed by Tim Horton.
1821
1822         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1823         (TEST):
1824
1825 2019-03-23  Keith Miller  <keith_miller@apple.com>
1826
1827         Refactor clz/ctz and fix getLSBSet.
1828         https://bugs.webkit.org/show_bug.cgi?id=196162
1829
1830         Reviewed by Saam Barati.
1831
1832         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1833
1834         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1835         (TestWebKitAPI::TEST):
1836
1837 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1838
1839         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1840         https://bugs.webkit.org/show_bug.cgi?id=196143
1841
1842         Reviewed by Michael Catanzaro.
1843
1844         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1845         directories.
1846
1847         * Scripts/webkitpy/style/checkers/cpp.py:
1848         (check_identifier_name_in_declaration):
1849         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1850         (WebKitStyleTest.test_names):
1851
1852 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1853
1854         [Flatpak] Manifest expanding fails for qt WPE extension
1855         https://bugs.webkit.org/show_bug.cgi?id=196148
1856
1857         Reviewed by Alex Christensen.
1858
1859         * flatpak/flatpakutils.py:
1860         (expand_submodules_recurse): The last recurse manifest expand
1861         iteration might lead to a single module so take it into account
1862         and don't try to recurse further.
1863
1864 2019-03-22  Chris Dumez  <cdumez@apple.com>
1865
1866         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1867         https://bugs.webkit.org/show_bug.cgi?id=195348
1868         <rdar://problem/48622090>
1869
1870         Reviewed by Alex Christensen.
1871
1872         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1873         to NO when test.options().shouldIgnoreMetaViewport is false.
1874
1875         * WebKitTestRunner/ios/TestControllerIOS.mm:
1876         (WTR::TestController::platformConfigureViewForTest):
1877
1878 2019-03-22  Chris Dumez  <cdumez@apple.com>
1879
1880         Prewarmed processes should be usable with any website data store
1881         https://bugs.webkit.org/show_bug.cgi?id=196104
1882
1883         Reviewed by Alex Christensen.
1884
1885         Add API test coverage.
1886
1887         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1888         (runInitialWarmedProcessUsedTest):
1889         (TEST):
1890
1891 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1892
1893         Back out local changes to Alex's Subversion working directory
1894
1895         They were accidentally committed.
1896
1897         * Scripts/webkitpy/common/system/abstractexecutive.py:
1898         (AbstractExecutive.wait_newest):
1899         * Scripts/webkitpy/common/system/executive.py:
1900         (Executive.running_pids):
1901         * Scripts/webkitpy/common/system/executive_mock.py:
1902         (MockExecutive.running_pids):
1903         * Scripts/webkitpy/common/system/executive_unittest.py:
1904         (ExecutiveTest.serial_test_running_pids):
1905         * Scripts/webkitpy/port/darwin.py:
1906         (DarwinPort.check_for_leaks):
1907         * Scripts/webkitpy/port/leakdetector.py:
1908         (LeakDetector.check_for_leaks):
1909         - This was the hack attached to Bug 193772.
1910
1911         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1912         (+[WebKitTestRunnerEvent mouseLocation]):
1913         - This works around a crash on an internal build.
1914
1915 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1916
1917         Fix the build after r243354
1918         https://bugs.webkit.org/show_bug.cgi?id=196138
1919         <rdar://problem/49145951>
1920
1921         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1922         (TEST):
1923         * TestWebKitAPI/ios/UIKitSPI.h:
1924
1925 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1926
1927         Adopt UIWKDocumentContext
1928         https://bugs.webkit.org/show_bug.cgi?id=196040
1929         <rdar://problem/48642440>
1930
1931         Reviewed by Ryosuke Niwa.
1932
1933         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1934         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1935         (makeRequest):
1936         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1937         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1938         (applyStyle):
1939         (TEST):
1940         Add tests for UIWKDocumentContext.
1941
1942         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1943         (TEST):
1944         (recursiveFindWKContentView): Deleted.
1945         * TestWebKitAPI/cocoa/TestWKWebView.h:
1946         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1947         (recursiveFindWKContentView):
1948         (-[TestWKWebView wkContentView]):
1949         * TestWebKitAPI/ios/UIKitSPI.h:
1950         Share the WKContentView finding code between tests.
1951
1952 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1953
1954         [iOS WK2] Turn on async overflow scrolling by default
1955         https://bugs.webkit.org/show_bug.cgi?id=196011
1956         rdar://problem/48453859
1957
1958         Reviewed by Antti Koivisto.
1959         
1960         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1961         since so many basic layout tests have different results when compositing is triggered for
1962         overflow.
1963         
1964         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1965
1966         * WebKitTestRunner/TestController.cpp:
1967         (WTR::TestController::resetPreferencesToConsistentValues):
1968
1969 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1970
1971         [ews-build] Retry API test in case of failures
1972         https://bugs.webkit.org/show_bug.cgi?id=196004
1973
1974         Reviewed by Lucas Forschler.
1975
1976         * BuildSlaveSupport/ews-build/steps.py:
1977         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1978         (CompileWebKitToT.doStepIf): Ditto.
1979         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1980         (ReRunAPITests): Re-run API tests.
1981         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1982         (RunAPITestsWithoutPatch): Run API tests without patch.
1983         (RunAPITestsWithoutPatch.doStepIf):
1984         (RunAPITestsWithoutPatch.hideStepIf):
1985         (RunAPITestsWithoutPatch.evaluateCommand):
1986         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1987         (AnalyzeAPITestsResults.start):
1988         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1989         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1990         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1991         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1992
1993 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1994
1995         [ews-build] Update queues configurations
1996         https://bugs.webkit.org/show_bug.cgi?id=196074
1997
1998         Reviewed by Dewei Zhu.
1999
2000         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2001         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2002
2003 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2004
2005         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2006         https://bugs.webkit.org/show_bug.cgi?id=195680
2007         <rdar://problem/48903534>
2008
2009         Unreviewed infrastructure fix.
2010
2011         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2012         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2013
2014 2019-03-21  Andy Estes  <aestes@apple.com>
2015
2016         [iOS] Apple Pay should be available in documents with no user agent scripts
2017         https://bugs.webkit.org/show_bug.cgi?id=196061
2018         <rdar://problem/48649391>
2019
2020         Reviewed by Brady Eidson.
2021
2022         Added API tests and related infrastructure.
2023
2024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2025         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2026         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2027         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2028         (TestWebKitAPI::TEST):
2029         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2030         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2031         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2032         * TestWebKitAPI/cocoa/TestProtocol.mm:
2033         (-[TestProtocol startLoading]):
2034         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2035         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2036         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2037         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2038
2039 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2040
2041         REGRESSSION (r243297): webkitpy tests broken
2042         https://bugs.webkit.org/show_bug.cgi?id=196108
2043
2044         Reviewed by Aakash Jain.
2045
2046         r243297 updated contributors.json, which broke a few unit tests.
2047
2048         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2049         (IRCCommandTest.test_whois):
2050         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2051
2052 2019-03-21  Chris Dumez  <cdumez@apple.com>
2053
2054         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2055         https://bugs.webkit.org/show_bug.cgi?id=196041
2056         <rdar://problem/49083230>
2057
2058         Reviewed by Alex Christensen.
2059
2060         Add API test coverage.
2061
2062         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2063         (TEST):
2064
2065 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2066
2067         Add SPI to inform applications of WKContentRuleList actions
2068         https://bugs.webkit.org/show_bug.cgi?id=195965
2069         <rdar://problem/42664365>
2070
2071         Reviewed by Geoff Garen.
2072
2073         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2074         (TestWebKitAPI::allActionsForResourceLoad):
2075         (TestWebKitAPI::testRequest):
2076         (TestWebKitAPI::TEST_F):
2077         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2078         (Notification::description):
2079         (Notification::operator== const):
2080         (toVector):
2081         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2082         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2083         (makeContentRuleList):
2084         (TEST):
2085         (makeWarnContentRuleList): Deleted.
2086
2087 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2088
2089         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2090         https://bugs.webkit.org/show_bug.cgi?id=196088
2091
2092         Reviewed by Brian Burg.
2093
2094         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2095         Support checks when only one platform is specified. Also deprecate macosx() and
2096         force the use of macos() instead.
2097
2098         * Scripts/webkitpy/style/checkers/cpp.py:
2099         (check_min_versions_of_wk_api_available):
2100         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2101         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2102
2103 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2104
2105         Update status inactive committers' status to 'contributor'.
2106
2107         * Scripts/webkitpy/common/config/contributors.json:
2108
2109 2019-03-21  Xan Lopez  <xan@igalia.com>
2110
2111         [JSC][x86] Drop support for x87 floating point
2112         https://bugs.webkit.org/show_bug.cgi?id=194853
2113
2114         Reviewed by Don Olmstead.
2115
2116         Force SSE2 on x86/32bit builds.
2117
2118         * Scripts/webkitdirs.pm:
2119         (generateBuildSystemFromCMakeProject):
2120
2121 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2122
2123         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2124         https://bugs.webkit.org/show_bug.cgi?id=196073
2125
2126         Reviewed by Michael Catanzaro.
2127
2128         Add test cases to check functions and constructors with no arguments but receiving user data.
2129
2130         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2131         (checkUserData):
2132         (testJSCFunction):
2133         (fooCreateWithUserData):
2134         (testJSCClass):
2135
2136 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2137
2138         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2139
2140         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2141
2142         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2143
2144 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2145
2146         [GTK][WPE] Add API to provide geolocation information
2147         https://bugs.webkit.org/show_bug.cgi?id=195940
2148
2149         Reviewed by Michael Catanzaro.
2150
2151         Add a new test to check the new API.
2152
2153         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2154         (testGeolocationManagerCurrentPosition):
2155         (testGeolocationManagerWatchPosition):
2156         (beforeAll):
2157         (afterAll):
2158         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2159         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2160         (beforeAll): Ditto.
2161         * TestWebKitAPI/glib/CMakeLists.txt:
2162
2163 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2164
2165         [GLib] Returning G_TYPE_OBJECT from a method does not work
2166         https://bugs.webkit.org/show_bug.cgi?id=195574
2167
2168         Reviewed by Michael Catanzaro.
2169
2170         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2171
2172         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2173         (getGFile):
2174         (getParent):
2175         (createGString):
2176         (getGString):
2177         (getGStringCopyWillRaise):
2178         (getGStringCopy):
2179         (getGStringStr):
2180         (getGStringLen):
2181         (freeGString):
2182         (testJSCClass):
2183
2184 2019-03-20  Saam Barati  <sbarati@apple.com>
2185
2186         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2187         https://bugs.webkit.org/show_bug.cgi?id=195721
2188
2189         Reviewed by Filip Pizlo.
2190
2191         * Scripts/run-javascriptcore-tests:
2192
2193 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2194
2195         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2196         https://bugs.webkit.org/show_bug.cgi?id=196049
2197
2198         Reviewed by Tim Horton.
2199
2200         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2201         overflow scrolling in general, so rename it.
2202
2203         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2204
2205 2019-03-20  Daniel Bates  <dabates@apple.com>
2206
2207         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2208         https://bugs.webkit.org/show_bug.cgi?id=196031
2209         <rdar://problem/49078172>
2210
2211         Reviewed by Tim Horton.
2212
2213         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2214         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2215         same code path used when the Done button is pressed to dismiss the <select> picker.
2216
2217         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2218         (TestWebKitAPI::TEST):
2219
2220 2019-03-20  Chris Dumez  <cdumez@apple.com>
2221
2222         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2223         https://bugs.webkit.org/show_bug.cgi?id=196029
2224         <rdar://problem/48954651>
2225
2226         Reviewed by Tim Horton.
2227
2228         Add API test coverage.
2229
2230         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2231
2232 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2233
2234         [ews-build] Improve failure summary string for ApplyPatch step
2235         https://bugs.webkit.org/show_bug.cgi?id=195995
2236
2237         Reviewed by Alexey Proskuryakov.
2238
2239         * BuildSlaveSupport/ews-build/steps.py:
2240         (ApplyPatch.getResultSummary): Override getResultSummary.
2241
2242 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2243
2244         AX: Implement support for new meter ARIA role
2245         https://bugs.webkit.org/show_bug.cgi?id=195966
2246
2247         Reviewed by Chris Fleizach.
2248
2249         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2250         to AXLevelIndicator.
2251
2252         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2253
2254 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2255
2256         [WebAuthN] Implement FIDO AppID extension
2257         https://bugs.webkit.org/show_bug.cgi?id=143491
2258         <rdar://problem/48298273>
2259
2260         Reviewed by Brent Fulgham.
2261
2262         Add a test that covers the new flag of convertToU2fSignCommand.
2263
2264         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2265         (TestWebKitAPI::TEST):
2266         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2267         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2268         (TestWebKitAPI::TEST):
2269
2270 2019-03-19  Keith Rollin  <krollin@apple.com>
2271
2272         Add support for more platforms to generate-xcfilelists
2273         https://bugs.webkit.org/show_bug.cgi?id=195977
2274
2275         Reviewed by Alexey Proskuryakov.
2276
2277         generate-xcfilelists incorrectly complains when involved with building
2278         WebKit for iphonesimulator:
2279
2280             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2281             …
2282             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2283
2284         Address this by teaching generate-xcfilelists about more platforms.
2285
2286         * Scripts/generate-xcfilelists:
2287
2288 2019-03-19  John Wilander  <wilander@apple.com>
2289
2290         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2291         https://bugs.webkit.org/show_bug.cgi?id=195923
2292         <rdar://problem/49001272>
2293
2294         Reviewed by Alex Christensen.
2295
2296         This patch does the following to the TestRunner:
2297         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2298         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2299         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2300
2301         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2302         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2303         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2304         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2305         * WebKitTestRunner/TestController.cpp:
2306         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2307         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2308         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2309         * WebKitTestRunner/TestController.h:
2310         * WebKitTestRunner/TestInvocation.cpp:
2311         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2312
2313 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2314
2315         [CMake] Support more clang and gcc sanitizers
2316         https://bugs.webkit.org/show_bug.cgi?id=195956
2317
2318         Reviewed by Michael Catanzaro.
2319
2320         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2321
2322 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2323
2324         [ews-build] Improve summary for PrintConfiguration step
2325         https://bugs.webkit.org/show_bug.cgi?id=195945
2326
2327         Reviewed by Lucas Forschler.
2328
2329         * BuildSlaveSupport/ews-build/steps.py:
2330         (PrintConfiguration.getResultSummary): Override getResultSummary.
2331
2332 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2333
2334         [ews-build] Improve summary for CheckOutSource step
2335         https://bugs.webkit.org/show_bug.cgi?id=195963
2336
2337         Reviewed by Lucas Forschler.
2338
2339         * BuildSlaveSupport/ews-build/steps.py:
2340         (CheckOutSource.getResultSummary):
2341
2342 2019-03-19  Daniel Bates  <dabates@apple.com>
2343
2344         [iOS] Focus not preserved when switching between tabs
2345         https://bugs.webkit.org/show_bug.cgi?id=195820
2346         <rdar://problem/43614450>
2347
2348         Reviewed by Brent Fulgham.
2349
2350         Add tests to ensure that we restore focus when resigning and becoming first responder.
2351
2352         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2353         (TestWebKitAPI::TEST):
2354
2355 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2356
2357         Make WTFLogChannelState and WTFLogLevel enum classes
2358         https://bugs.webkit.org/show_bug.cgi?id=195904
2359
2360         Reviewed by Eric Carlson.
2361
2362         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2363         (TestWebKitAPI::TEST_F):
2364
2365 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2366
2367         [GStreamer][EME] Backported mssdemux protection data crash fix
2368         https://bugs.webkit.org/show_bug.cgi?id=195918
2369
2370         Reviewed by Philippe Normand.
2371
2372         * gstreamer/jhbuild.modules:
2373         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2374
2375 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2376
2377         Unreviewed, rolling out r243132.
2378
2379         Broke GTK build
2380
2381         Reverted changeset:
2382
2383         "Make WTFLogChannelState and WTFLogLevel enum classes"
2384         https://bugs.webkit.org/show_bug.cgi?id=195904
2385         https://trac.webkit.org/changeset/243132
2386
2387 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2388
2389         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2390
2391         * Scripts/webkitdirs.pm:
2392         (builtDylibPathForName): Adjust the shared library name that's changed
2393         with the API version bump in r243073.
2394
2395 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2396
2397         Make WTFLogChannelState and WTFLogLevel enum classes
2398         https://bugs.webkit.org/show_bug.cgi?id=195904
2399
2400         Reviewed by Eric Carlson.
2401
2402         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2403         (TestWebKitAPI::TEST_F):
2404
2405 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2406
2407         Disable flaky test added in r2431100
2408         https://webkit.org/b/195785
2409
2410         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2411         (TestWebKitAPI::TEST):
2412         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2413
2414 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2415
2416         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2417         https://bugs.webkit.org/show_bug.cgi?id=195916
2418
2419         Reviewed by Tim Horton.
2420
2421         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2422         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2423
2424 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2425
2426         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2427
2428         * Scripts/webkitpy/common/config/contributors.json:
2429
2430 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2431
2432         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2433         https://bugs.webkit.org/show_bug.cgi?id=195785
2434
2435         Reviewed by Geoffrey Garen.
2436
2437         * TestWebKitAPI/TCPServer.cpp: Added.
2438         (TestWebKitAPI::TCPServer::TCPServer):
2439         (TestWebKitAPI::TCPServer::~TCPServer):
2440         (TestWebKitAPI::TCPServer::socketBindListen):
2441         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2442         * TestWebKitAPI/TCPServer.h: Added.
2443         (TestWebKitAPI::TCPServer::port const):
2444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2445         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2446         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2447         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2448         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2449         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2450         (TestWebKitAPI::respondSlowly):
2451         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2452         (TestWebKitAPI::downloadAtRate):
2453         (TestWebKitAPI::TEST):
2454
2455 2019-03-18  Saam Barati  <sbarati@apple.com>
2456
2457         Add a plan file for JetStream 2
2458         https://bugs.webkit.org/show_bug.cgi?id=190734
2459
2460         Reviewed by Mark Lam.
2461
2462         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2463
2464 2019-03-18  Chris Dumez  <cdumez@apple.com>
2465
2466         Delay WebProcess launch until a load is triggered in a Web view
2467         https://bugs.webkit.org/show_bug.cgi?id=195758
2468         <rdar://problem/48126013>
2469
2470         Reviewed by Geoff Garen.
2471
2472         Add API test coverage. Also update some existing API tests to not expect
2473         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2474
2475         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2476         (TestWebKitAPI::TEST):
2477         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2478         (TestWebKitAPI::TEST):
2479         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2480         (TEST):
2481         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2482         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2483         (TEST):
2484         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2485         (TEST):
2486         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2487
2488 2019-03-18  Xan Lopez  <xan@igalia.com>
2489
2490         [CMake] Prevent potential warning when determining $architecture
2491         https://bugs.webkit.org/show_bug.cgi?id=195891
2492
2493         Reviewed by Michael Catanzaro.
2494
2495         It's possible for generateBuildSystemForCMakeProject to be called
2496         before determineArchitecture() is ever called. This will make the
2497         first eq check with $architecture to be bogus (and print a
2498         warning). Change that to an eq check with architecture(), which
2499         implicitly calls determineArchitecture() if needed, and change all
2500         the other similar cases in the method in the same way to prevent
2501         future bugs like this one.
2502
2503         * Scripts/webkitdirs.pm:
2504         (generateBuildSystemFromCMakeProject):
2505
2506 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2507
2508         [WPE] Tarballs generated with “make dist” cannot build documentation
2509         https://bugs.webkit.org/show_bug.cgi?id=195885
2510
2511         Reviewed by Carlos Garcia Campos.
2512
2513         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2514
2515 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2516
2517         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2518         https://bugs.webkit.org/show_bug.cgi?id=195883
2519
2520         Reviewed by Carlos Garcia Campos.
2521
2522         * gtkdoc/gtkdoc.py:
2523         (GTKDoc._run_command): When commands fail to run, include the full command line for
2524         the program invocation and the output it has generated on the standard error stream.
2525
2526 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2527
2528         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2529         https://bugs.webkit.org/show_bug.cgi?id=195786
2530
2531         Reviewed by Philippe Normand.
2532
2533         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2534         * wpe/jhbuild.modules: Ditto.
2535
2536 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2537
2538         [ews-build] Don't run clean builds on EWS builders
2539         https://bugs.webkit.org/show_bug.cgi?id=195851
2540
2541         Reviewed by Geoffrey Garen.
2542
2543         * BuildSlaveSupport/ews-build/factories.py:
2544
2545 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2546
2547         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2548         https://bugs.webkit.org/show_bug.cgi?id=195849
2549
2550         Reviewed by Chris Dumez.
2551
2552         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2553
2554         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2555         (runWebsiteDataStoreCustomPaths):
2556
2557 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2558
2559         webkitpy: Upload test results
2560         https://bugs.webkit.org/show_bug.cgi?id=195755
2561         <rdar://problem/48896182>
2562
2563         Reviewed by Aakash Jain.
2564
2565         Establish a new format for uploading results that is not tied to layout tests, apply
2566         that format to webkitpy tests.
2567
2568         * Scripts/webkitpy/common/checkout/scm/git.py:
2569         (Git.native_branch): Return what branch the current checkout is on.
2570         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2571         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2572         * Scripts/webkitpy/common/checkout/scm/svn.py:
2573         (SVN.native_branch): Ditto.
2574         * Scripts/webkitpy/common/system/platforminfo.py:
2575         (PlatformInfo.build_version): Return a build version for Mac.
2576         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2577         (MockPlatformInfo.__init__):
2578         (MockPlatformInfo.build_version):
2579         * Scripts/webkitpy/results: Added.
2580         * Scripts/webkitpy/results/__init__.py: Added.
2581         * Scripts/webkitpy/results/options.py: Added.
2582         (upload_options): OptParse list for upload options.
2583         * Scripts/webkitpy/results/upload.py: Added.
2584         (Upload): Class which enforces the upload format expected by the results server.
2585         (Upload.Expectations):
2586         (Upload.create_configuration):
2587         (Upload.create_commit):
2588         (Upload.create_details):
2589         (Upload.create_run_stats):
2590         (Upload.create_test_result):
2591         (Upload.__init__):
2592         (Upload.Encoder): Encode Upload object as json.
2593         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2594         * Scripts/webkitpy/results/upload_unittest.py: Added.
2595         * Scripts/webkitpy/test/main.py:
2596         (Tester._parse_args): Add upload arguments.
2597         (Tester._run_tests): Allow results to be uploaded.
2598         * Scripts/webkitpy/test/runner.py:
2599         (Runner.__init__): Record which tests were run, rather than just counting them.
2600         (Runner.handle):
2601         * Scripts/webkitpy/test/runner_unittest.py:
2602         (RunnerTest.test_run):
2603         * Scripts/webkitpy/thirdparty/__init__.py:
2604         (AutoinstallImportHook.find_module): Add requests auto-install.
2605         (AutoinstallImportHook._install_requests):
2606         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2607         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2608
2609 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2610
2611         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2612         https://bugs.webkit.org/show_bug.cgi?id=195810
2613
2614         Reviewed by Tim Horton.
2615
2616         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2617         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2618         ending certain layout tests.
2619
2620         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2621         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2622         (-[TestRunnerWKWebView dealloc]):
2623         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2624
2625         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2626         helper method when destroying the web view, and when resetting state between tests.
2627
2628         * WebKitTestRunner/ios/TestControllerIOS.mm:
2629         (WTR::TestController::platformResetStateToConsistentValues):
2630
2631         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2632
2633 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2634
2635         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2636         https://bugs.webkit.org/show_bug.cgi?id=190350
2637         <rdar://problem/45089503>
2638
2639         Reviewed by Geoffrey Garen.
2640
2641         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2642         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2643         (TEST):
2644         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2645         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2646         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2647         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2648         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2649         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2650         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2651         (runTest):
2652         (createDirectories):
2653         (TEST):
2654         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2655         (TEST):
2656         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2657         (TEST):
2658
2659 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2660
2661         Add support to WebPage for getting the contents as an attributed string.
2662         https://bugs.webkit.org/show_bug.cgi?id=195636
2663         rdar://problem/45055697
2664
2665         Reviewed by Tim Horton.
2666
2667         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2668         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2669
2670 2019-03-15  Chris Dumez  <cdumez@apple.com>
2671
2672         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2673         https://bugs.webkit.org/show_bug.cgi?id=195747
2674
2675         Reviewed by Geoff Garen.
2676
2677         Add API test coverage.
2678
2679         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2680
2681 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2682
2683         Unreviewed, rolling out r242952.
2684
2685         Causing API failures on iOS Simulator
2686
2687         Reverted changeset:
2688
2689         "[PSON] Make sure the WebProcessCache is leverage when
2690         relaunching a process after termination"
2691         https://bugs.webkit.org/show_bug.cgi?id=195747
2692         https://trac.webkit.org/changeset/242952
2693
2694 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2695
2696         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2697         https://bugs.webkit.org/show_bug.cgi?id=195740
2698
2699         Reviewed by Ross Kirsling.
2700
2701         window.open doesn't work for WebKitBrowserWindow because it is not
2702         implemented yet.
2703
2704         1. Implemented createNewPage callback of WKPageUIClient.
2705         2. Changed MainWindow to take a BrowserWindow factory function
2706           instead of BrowserWindowType to be flexible to create
2707           BrowserWindow with extra settings.
2708         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2709           because it is not relevant with MainWindow anymore.
2710
2711         * MiniBrowser/win/Common.cpp:
2712         (parseCommandLine):
2713         * MiniBrowser/win/Common.h:
2714         (CommandLineOptions::CommandLineOptions):
2715         * MiniBrowser/win/MainWindow.cpp:
2716         (MainWindow::MainWindow):
2717         (MainWindow::create):
2718         (MainWindow::init):
2719         (MainWindow::WndProc):
2720         * MiniBrowser/win/MainWindow.h:
2721         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2722         (PrintWebUIDelegate::createWebViewWithRequest):
2723         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2724         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2725         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2726         (WebKitBrowserWindow::updateProxySettings):
2727         (WebKitBrowserWindow::createNewPage):
2728         * MiniBrowser/win/WebKitBrowserWindow.h:
2729         * MiniBrowser/win/WinMain.cpp:
2730         (wWinMain):
2731
2732 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2733
2734         Make it possible to test scrolling tree layer manipulation more easily
2735         https://bugs.webkit.org/show_bug.cgi?id=195780
2736
2737         Reviewed by Tim Horton.
2738         
2739         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2740         cuts off communication of scrolling tree scrolls back to the web process
2741         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2742         allows tests to trigger scrolls which run the scrolling tree layer positioning
2743         logic, but never get another commit from the web process that might mask
2744         scrolling tree bugs.
2745         
2746         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2747         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2748         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2749
2750         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2751         (WTR::UIScriptController::scrollUpdatesDisabled const):
2752         (WTR::UIScriptController::setScrollUpdatesDisabled):
2753         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2754         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2755         (WTR::UIScriptController::scrollUpdatesDisabled const):
2756         (WTR::UIScriptController::setScrollUpdatesDisabled):
2757         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2758         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2759         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2760         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2761         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2762         * WebKitTestRunner/ios/TestControllerIOS.mm:
2763         (WTR::TestController::platformResetStateToConsistentValues):
2764         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2765         (WTR::UIScriptController::scrollUpdatesDisabled const):
2766         (WTR::UIScriptController::setScrollUpdatesDisabled):
2767
2768 2019-03-14  Youenn Fablet  <youenn@apple.com>
2769
2770         Move IDB storage in private browsing mode to NetworkProcess
2771         https://bugs.webkit.org/show_bug.cgi?id=195602
2772
2773         Reviewed by Brady Eidson.
2774
2775         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2776         (TEST):
2777
2778 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2779
2780         [ews-build] Make descriptionDone messages more readable
2781         https://bugs.webkit.org/show_bug.cgi?id=195760
2782
2783         Reviewed by Lucas Forschler.
2784
2785         * BuildSlaveSupport/ews-build/steps.py:
2786         * BuildSlaveSupport/ews-build/steps_unittest.py:
2787
2788 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2789
2790         [ews-build] Generate status-bubble hover-over messages
2791         https://bugs.webkit.org/show_bug.cgi?id=195680
2792
2793         Reviewed by Lucas Forschler.
2794
2795         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2796         (StatusBubble):
2797         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2798         on hover-over.
2799         (StatusBubble._iso_time):
2800         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2801         hover-over message.
2802         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2803
2804 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2805
2806         [ews-app] Gracefully handle the case when state_string is None
2807         https://bugs.webkit.org/show_bug.cgi?id=195753
2808
2809         Reviewed by Lucas Forschler.
2810
2811         * BuildSlaveSupport/ews-app/ews/models/build.py:
2812         * BuildSlaveSupport/ews-app/ews/models/step.py:
2813
2814 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2815
2816         [ews-app] Status bubble display pending for currently running build step
2817         https://bugs.webkit.org/show_bug.cgi?id=195744
2818
2819         Reviewed by Lucas Forschler.
2820
2821         * BuildSlaveSupport/ews-build/events.py:
2822         (Events.stepStarted): If state_string is pending, replace it with step name.
2823
2824 2019-03-14  Chris Dumez  <cdumez@apple.com>
2825
2826         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2827         https://bugs.webkit.org/show_bug.cgi?id=195750
2828
2829         Reviewed by Geoffrey Garen.
2830
2831         Add API test coverage.
2832
2833         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2834         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2835         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2836         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2837
2838 2019-03-14  Chris Dumez  <cdumez@apple.com>
2839
2840         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2841         https://bugs.webkit.org/show_bug.cgi?id=195747
2842
2843         Reviewed by Geoff Garen.
2844
2845         Add API test coverage.
2846
2847         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2848
2849 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2850
2851         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2852         https://bugs.webkit.org/show_bug.cgi?id=195725
2853         <rdar://problem/48545062>
2854
2855         Reviewed by Tim Horton.
2856
2857         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2858         handler is nil.
2859
2860         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2861         (TestWebKitAPI::TEST):
2862
2863 2019-03-13  Sam Weinig  <sam@webkit.org>
2864
2865         Add utility function to allow easy reverse range-based iteration of a container
2866         https://bugs.webkit.org/show_bug.cgi?id=195542
2867
2868         Reviewed by Antti Koivisto.
2869
2870         * TestWebKitAPI/CMakeLists.txt:
2871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2872         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2873         (TestWebKitAPI::TEST):
2874         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2875
2876 2019-03-13  Chris Dumez  <cdumez@apple.com>
2877
2878         Use a ServiceWorker process per registrable domain
2879         https://bugs.webkit.org/show_bug.cgi?id=195649
2880
2881         Reviewed by Youenn Fablet.
2882
2883         Update API test coverage.
2884
2885         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2886
2887 2019-03-13  Chris Dumez  <cdumez@apple.com>
2888
2889         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2890         https://bugs.webkit.org/show_bug.cgi?id=195684
2891         <rdar://problem/48294714>
2892
2893         Reviewed by Antti Koivisto.
2894
2895         Add API test coverage.
2896
2897         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2898
2899 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2900
2901         [ews-app] Remove unused patch view
2902         https://bugs.webkit.org/show_bug.cgi?id=195669
2903
2904         Reviewed by Lucas Forschler.
2905
2906         * BuildSlaveSupport/ews-app/ews/urls.py:
2907         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2908
2909 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2910
2911         [ews-app] Use Buildbot result code variables
2912         https://bugs.webkit.org/show_bug.cgi?id=195668
2913
2914         Reviewed by Alexey Proskuryakov.
2915
2916         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2917         (Buildbot): Added Buildbot result code variables.
2918         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2919         (StatusBubble._build_bubble): Used Buildbot result code variables.
2920
2921 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2922
2923         [Flatpak] Expand submodule recursively
2924         https://bugs.webkit.org/show_bug.cgi?id=195672
2925
2926         Building WPE with flatpak was impossible without that as it was raising an exception.
2927         Also update wpebackend-fdo to match what is built in jhbuild
2928
2929         Reviewed by Philippe Normand.
2930
2931         * flatpak/flatpakutils.py:
2932         (expand_submodules_recurse):
2933         (expand_manifest):
2934         * flatpak/org.webkit.WPEModules.yaml:
2935
2936 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2937
2938         [ews-app] status bubble should be hidden for certain builds
2939         https://bugs.webkit.org/show_bug.cgi?id=194597
2940
2941         Reviewed by Dewei Zhu.
2942
2943         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2944         (StatusBubble._build_bubble):
2945         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2946         because the patch didn't have relevant changes.
2947         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2948         in production yet.
2949
2950 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2951
2952         [Win] Fix a slew of simple clang-cl warnings.
2953         https://bugs.webkit.org/show_bug.cgi?id=195652
2954
2955         Reviewed by Don Olmstead.
2956
2957         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2958         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2959
2960 2019-03-12  Justin Fan  <justin_fan@apple.com>
2961
2962         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2963         https://bugs.webkit.org/show_bug.cgi?id=195518
2964         <rdar://problem/46322356>
2965
2966         Reviewed by Myles C. Maxfield.
2967
2968         * DumpRenderTree/DerivedSources-input.xcfilelist:
2969         * DumpRenderTree/DerivedSources-output.xcfilelist:
2970
2971 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2972
2973         Unreviewed, rolling out r242825.
2974         https://bugs.webkit.org/show_bug.cgi?id=195648
2975
2976         "Broke webkitpy tests with my change to
2977         lldb_dump_class_layout.py" (Requested by rmorisset on
2978         #webkit).
2979
2980         Reverted changeset:
2981
2982         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2983         classes with suspicious padding"
2984         https://bugs.webkit.org/show_bug.cgi?id=195573
2985         https://trac.webkit.org/changeset/242825
2986
2987 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2988
2989         [ews-build] Show status bubbles while the patch is waiting in queue
2990         https://bugs.webkit.org/show_bug.cgi?id=195618
2991
2992         Reviewed by Lucas Forschler.
2993
2994         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2995         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2996         enabled in initial deployment.
2997         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2998         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2999         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3000         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3001         (StatusBubble._build_bubbles_for_patch):
3002
3003 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3004
3005         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3006         https://bugs.webkit.org/show_bug.cgi?id=195573
3007
3008         Reviewed by Simon Fraser.
3009
3010         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3011
3012         * Scripts/dump-class-layout:
3013         (main):
3014         * lldb/lldb_dump_class_layout.py:
3015         (ClassLayout.__init__):
3016         (ClassLayout._compute_padding_recursive):
3017         (LLDBDebuggerInstance.dump_layout_for_classname):
3018         (LLDBDebuggerInstance):
3019         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3020         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3021
3022 2019-03-12  Chris Dumez  <cdumez@apple.com>
3023
3024         Device Orientation access permission should be denied unless explicitly granted by the client
3025         https://bugs.webkit.org/show_bug.cgi?id=195625
3026
3027         Reviewed by Youenn Fablet.
3028
3029         add API test coverage.
3030
3031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3032         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3033         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3034         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3035         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3036         (runDeviceOrientationTest):
3037         (TEST):
3038         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3039         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3040
3041 2019-03-12  Jer Noble  <jer.noble@apple.com>
3042
3043         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3044         https://bugs.webkit.org/show_bug.cgi?id=195137
3045         <rdar://problem/48810307>
3046
3047         Reviewed by Eric Carlson.
3048
3049         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3050         (TestWebKitAPI::TEST):
3051
3052 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3053
3054         [ews-build] Change urls from uat to production
3055         https://bugs.webkit.org/show_bug.cgi?id=195566
3056
3057         Reviewed by Lucas Forschler.
3058
3059         * BuildSlaveSupport/ews-app/ews/config.py:
3060         * BuildSlaveSupport/ews-build/events.py:
3061         * BuildSlaveSupport/ews-build/steps.py:
3062
3063 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3064
3065         [ews-build] change max_builds for local-worker to 1
3066         https://bugs.webkit.org/show_bug.cgi?id=195568
3067
3068         Reviewed by Lucas Forschler.
3069
3070         * BuildSlaveSupport/ews-build/loadConfig.py:
3071
3072 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3073
3074         Fix the build
3075
3076         * TestRunnerShared/spi/PencilKitTestSPI.h:
3077         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3078
3079 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3080
3081         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3082         https://bugs.webkit.org/show_bug.cgi?id=194131
3083
3084         Reviewed by Michael Catanzaro.
3085
3086         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3087         (uriChanged):
3088         (testUnfinishedSubresourceLoad):
3089         (serverCallback):
3090         (beforeAll):
3091
3092 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3093
3094         WTF::Expected should use std::addressof instead of operator&
3095         https://bugs.webkit.org/show_bug.cgi?id=195604
3096
3097         Reviewed by Myles Maxfield.
3098
3099         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3100         (TestWebKitAPI::Unique::Unique):
3101         (TestWebKitAPI::Unique::operator&):
3102         (TestWebKitAPI::TEST):
3103
3104 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3105
3106         Add Optional to Forward.h.
3107         https://bugs.webkit.org/show_bug.cgi?id=195586
3108
3109         Reviewed by Darin Adler.
3110
3111         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3112         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3113         Remove unnecessary includes from headers.
3114
3115 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3116
3117         Add testing API to hit-test and scroll overflow scrollers
3118         https://bugs.webkit.org/show_bug.cgi?id=195278
3119
3120         Reviewed by Antti Koivisto.
3121         
3122         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3123         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3124         
3125         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3126
3127         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3128         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3129         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3130         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3131         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3132         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3133         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3134         (WTR::enclosingScrollViewIncludingSelf):
3135         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3136
3137 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3138
3139         API test WebKit.RequestTextInputContext fails on iOS
3140         https://bugs.webkit.org/show_bug.cgi?id=195585
3141
3142         Reviewed by Wenson Hsieh and Simon Fraser.
3143
3144         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3145         (applyStyle):
3146         (TEST):
3147         Add a viewport, so that the coordinates match up on iOS.
3148         Scroll by moving the UIScrollView's contentOffset.
3149
3150 2019-03-11  Chris Dumez  <cdumez@apple.com>
3151
3152         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3153         https://bugs.webkit.org/show_bug.cgi?id=195506
3154         <rdar://problem/48733477>
3155
3156         Reviewed by Alex Christensen.
3157
3158         Add API test coverage.
3159
3160         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3161
3162 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3163
3164         Adding myself to contributors.json
3165
3166         Unreviewed, addming myself to contributors.json .
3167
3168         * Scripts/webkitpy/common/config/contributors.json:
3169
3170 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3171
3172         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3173         https://bugs.webkit.org/show_bug.cgi?id=195511
3174         <rdar://problem/44873269>
3175
3176         Reviewed by Darin Adler.
3177
3178         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3179         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3180         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3181         (TEST_F):
3182
3183 2019-03-11  Chris Dumez  <cdumez@apple.com>
3184
3185         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3186         https://bugs.webkit.org/show_bug.cgi?id=195561
3187
3188         Reviewed by Youenn Fablet.
3189
3190         Make sure the JS in the test requests for permission to receive device orientation events.
3191
3192         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3193
3194 2019-03-11  Youenn Fablet  <youenn@apple.com>
3195
3196         Allow storage quota increase by default in WTR
3197         https://bugs.webkit.org/show_bug.cgi?id=195541
3198
3199         Reviewed by Geoffrey Garen.
3200
3201         Allow storage quota increase by default in WTR.
3202         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3203         Use this for tests that explicitly need cache increase.
3204
3205         Instead of increasing quota by 2, make sure the next request is
3206         granted by adding all given parameters.
3207
3208         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3209         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3210         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3211         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3212         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3213         * WebKitTestRunner/TestController.cpp:
3214         (WTR::TestController::setAllowStorageQuotaIncrease):
3215         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3216         * WebKitTestRunner/TestController.h:
3217         * WebKitTestRunner/TestInvocation.cpp:
3218         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3219         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3220         (WTR::TestController::cocoaResetStateToConsistentValues):
3221         (WTR::TestController::setAllowStorageQuotaIncrease):
3222         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3223         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3224         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3225
3226 2019-03-11  Xan Lopez  <xan@igalia.com>
3227
3228         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3229         https://bugs.webkit.org/show_bug.cgi?id=194147
3230
3231         Reviewed by Michael Saboff.
3232
3233         To make --32-bit work correctly on Linux/64bit we need to:
3234
3235         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3236         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3237         unfortunately CMake only allows us to do this during
3238         crosscompilation, which is overkill here.
3239         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3240         pkg-config detection module uses the x86 .pc files instead of the
3241         x86_64 ones.
3242         - Set the -m32 flags for the compiler.
3243
3244         * Scripts/webkitdirs.pm:
3245         (generateBuildSystemFromCMakeProject):
3246
3247 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3248
3249         Add MotionMark-1.1 plan file for run-benchmark script.
3250         https://bugs.webkit.org/show_bug.cgi?id=195481
3251
3252         Rubber-stamped by Darin Adler.
3253
3254         Run-benchmark script should support MontionMark-1.1.
3255
3256         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3257
3258 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3259
3260         [ews-app] Add support for submit-to-ews url
3261         https://bugs.webkit.org/show_bug.cgi?id=195477
3262
3263         Reviewed by Lucas Forschler.
3264
3265         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3266         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3267         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3268         * BuildSlaveSupport/ews-app/ews/urls.py:
3269         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3270
3271 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3272
3273         Unreviewed, rolling out r242688, r242643, r242624.
3274
3275         Caused multiple layout test failures and crashes on iOS and macOS.
3276
3277         Reverted changeset:
3278
3279         "requestAnimationFrame should execute before the next frame"
3280         https://bugs.webkit.org/show_bug.cgi?id=177484
3281         https://trac.webkit.org/changeset/242624/webkit
3282
3283         * Tracing/SystemTracePoints.plist:
3284
3285 2019-03-11  John Wilander  <wilander@apple.com>
3286
3287         Resource Load Statistics: Make it possible exclude localhost from classification
3288         https://bugs.webkit.org/show_bug.cgi?id=195474
3289         <rdar://problem/47520577>
3290
3291         Reviewed by Brent Fulgham.
3292
3293         This patch allows for localhost to be excluded from classification and
3294         treatment as a prevalent resource.
3295
3296         The WebKit Tools change adds a new function called
3297         testRunner.setStatisticsIsRunningTest() which can be used to control this
3298         behavior.
3299
3300         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3301         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3302         (WTR::TestRunner::setStatisticsIsRunningTest):
3303         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3304         * WebKitTestRunner/TestController.cpp:
3305         (WTR::TestController::setStatisticsIsRunningTest):
3306         * WebKitTestRunner/TestController.h:
3307         * WebKitTestRunner/TestInvocation.cpp:
3308         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3309
3310 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3311
3312         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3313         https://bugs.webkit.org/show_bug.cgi?id=195560
3314
3315         Reviewed by Lucas Forschler.
3316
3317         * BuildSlaveSupport/ews-build/master.cfg:
3318
3319 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3320
3321         Unreviewed, rolling out r242698.
3322
3323         API test crashes on bots.
3324
3325         Reverted changeset:
3326
3327         "Add a WKContentRuleList variant that uses copied memory
3328         instead of mmap'd shared memory for class A containerized
3329         apps"
3330         https://bugs.webkit.org/show_bug.cgi?id=195511
3331         https://trac.webkit.org/changeset/242698
3332
3333 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3334
3335         [WPE] Enable web process sandbox
3336         https://bugs.webkit.org/show_bug.cgi?id=195169
3337
3338         Reviewed by Daniel Bates.
3339
3340         * wpe/install-dependencies:
3341         * wpe/jhbuild.modules:
3342
3343 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3344
3345         [ews-app] Use port 17000 for worker communication
3346         https://bugs.webkit.org/show_bug.cgi?id=195558
3347
3348         Reviewed by Lucas Forschler.
3349
3350         * BuildSlaveSupport/ews-build/master.cfg:
3351
3352 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3353
3354         [ews-build] unit-tests fail when passwords.json is missing
3355         https://bugs.webkit.org/show_bug.cgi?id=195557
3356
3357         Reviewed by Lucas Forschler.
3358
3359         * BuildSlaveSupport/ews-build/loadConfig.py:
3360         (loadBuilderConfig):
3361         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3362         (ConfigDotJSONTest.test_configuration):
3363         * BuildSlaveSupport/ews-build/master.cfg:
3364
3365 2019-03-11  Truitt Savell  <tsavell@apple.com>
3366
3367         Unreviewed, rolling out r242702.
3368
3369         Broke High Sierra builders.
3370
3371         Reverted changeset:
3372
3373         "Add utility function to allow easy reverse range-based
3374         iteration of a container"
3375         https://bugs.webkit.org/show_bug.cgi?id=195542
3376         https://trac.webkit.org/changeset/242702
3377
3378 2019-03-11  Sam Weinig  <sam@webkit.org>
3379
3380         Add utility function to allow easy reverse range-based iteration of a container
3381         https://bugs.webkit.org/show_bug.cgi?id=195542
3382
3383         Reviewed by Antti Koivisto.
3384
3385         * TestWebKitAPI/CMakeLists.txt:
3386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3387         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3388         (TestWebKitAPI::TEST):
3389         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3390
3391 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3392
3393         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3394         https://bugs.webkit.org/show_bug.cgi?id=195511
3395         <rdar://problem/44873269>
3396
3397         Reviewed by Darin Adler.
3398
3399         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3400         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3401         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3402         (TEST_F):
3403
3404 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3405
3406         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3407         https://bugs.webkit.org/show_bug.cgi?id=195499
3408
3409         Reviewed by Darin Adler.
3410
3411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3412         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3413         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3414         (-[WKWebView synchronouslyFocusTextInputContext:]):
3415         (applyStyle):
3416         (applyIframe):
3417         (TEST):
3418         Add some tests for this SPI.
3419
3420 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3421
3422         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3423         https://bugs.webkit.org/show_bug.cgi?id=181151
3424
3425         Reviewed by Don Olmstead.
3426
3427         * TestWebKitAPI/CMakeLists.txt:
3428         * TestWebKitAPI/PlatformWin.cmake:
3429         Enable TestWTF RunLoop tests in all platforms.
3430
3431         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3432         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3433         (TestWebKitAPI::DerivedOneShotTimer::fired):
3434         (TestWebKitAPI::TEST):
3435         Only a few platforms support nested RunLoop.
3436
3437         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3438         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3439
3440 2019-03-10  David Quesada  <david_quesada@apple.com>
3441
3442         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3443         https://bugs.webkit.org/show_bug.cgi?id=152480
3444
3445         Reviewed by Chris Dumez.
3446
3447         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3448         there are no additional references to the process pool besides the one held by
3449         the download, waits for the download to finish (in the sense that the
3450         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3451         measure, also check that the process pool has been deallocated at the end of the
3452         test. The test wouldn't be meaningful if the process pool were still alive.
3453
3454         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3455         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3456         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3457             The download will be canceled because the delegate does not implement the
3458             method to decide the download's destination, so this is where we know the
3459             DownloadProxyMap is done with the DownloadProxy.
3460         (TEST):
3461
3462 2019-03-08  Chris Dumez  <cdumez@apple.com>
3463
3464         Add support for Device Orientation / Motion permission API
3465         https://bugs.webkit.org/show_bug.cgi?id=195329
3466         <rdar://problem/47645367>
3467
3468         Reviewed by Geoffrey Garen.
3469
3470         Add test infrastructure to help test the Device Orientation / Motion permission API.
3471
3472         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3473         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3474         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3475         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3476         * WebKitTestRunner/TestController.cpp:
3477         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3478         (WTR::TestController::createWebViewWithOptions):
3479         (WTR::TestController::resetStateToConsistentValues):
3480         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3481         * WebKitTestRunner/TestController.h:
3482         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3483         * WebKitTestRunner/TestInvocation.cpp:
3484         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3485
3486 2019-03-08  Saam barati  <sbarati@apple.com>
3487
3488         Add a compare-results script to compare benchmark results
3489         https://bugs.webkit.org/show_bug.cgi?id=195486
3490         <rdar://problem/48723397>
3491
3492         Reviewed by Geoffrey Garen.
3493
3494         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3495         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3496         to extend it to learn about our other benchmarks.
3497
3498         * Scripts/compare-results: Added.
3499         (readJSONFile):
3500         (detectJetStream2):
3501         (JetStream2Results):
3502         (detectSpeedometer2):
3503         (Speedometer2Results):
3504         (detectPLT5):
3505         (PLT5Results):
3506         (detectBenchmark):
3507         (biggerIsBetter):
3508         (ttest):
3509         (getOptions):
3510         (main):
3511
3512 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3513
3514         Ensure old tab state is cleared between iterations of run-benchmark
3515         https://bugs.webkit.org/show_bug.cgi?id=195393
3516         <rdar://problem/46885583>
3517
3518         Reviewed by Dewei Zhu.
3519
3520         a) ensure the default to restore state is not set
3521         b) terminate Safari correctly
3522         c) Set the system default to ignore Persistent State in Safari
3523
3524         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3525         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3526         (OSXBrowserDriver.prepare_env): 
3527         (OSXBrowserDriver.restore_env):
3528         (OSXBrowserDriver.close_browsers):
3529         (OSXBrowserDriver._terminate_processes):
3530         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3531         (OSXChromeDriver):
3532         (OSXChromeCanaryDriver):
3533         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3534         (OSXFirefoxDriver):
3535         (OSXFirefoxNightlyDriver):
3536         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3537         (OSXSafariDriver):
3538         (OSXSafariDriver.prepare_env):
3539
3540 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3541
3542         [GTK] Several InputMethodFilter tests are failing
3543         https://bugs.webkit.org/show_bug.cgi?id=195408
3544
3545         Reviewed by Carlos Garcia Campos.
3546
3547         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3548         Regressed in r241751.
3549         Hexadecimal values of keycodes are expressed now in upper letters.
3550         Composited characters should be cast to UTF8 strings.
3551
3552         (TestWebKitAPI::TEST):
3553
3554 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3555
3556         [GTK] Make Tools/gtkdoc python3 compatible
3557         https://bugs.webkit.org/show_bug.cgi?id=195359
3558
3559         Reviewed by Carlos Garcia Campos.
3560
3561         * gtkdoc/generate-gtkdoc:
3562         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3563         work with Python 2 and 3.
3564         (get_gtkdoc_module_paths):
3565         The iteritems() was removed in Python 3, so let's use items() that's
3566         available in Python 2 and 3.
3567         (get_generator_for_config):
3568         * gtkdoc/gtkdoc.py:
3569         (GTKDoc._run_command):
3570         The sys.stdout.write() is expecting str in Python 3 and not bytes
3571         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3572         for passing the bytes there.
3573
3574 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3575
3576         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3577         https://bugs.webkit.org/show_bug.cgi?id=195346
3578         <rdar://problem/48667048>
3579
3580         Unreviewed build fix for clang-cl.
3581
3582         * DumpRenderTree/win/DumpRenderTree.cpp:
3583         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3584
3585 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3586
3587         requestAnimationFrame should execute before the next frame
3588         https://bugs.webkit.org/show_bug.cgi?id=177484
3589
3590         Reviewed by Simon Fraser.
3591
3592         Add trace points for the page RenderingUpdate.
3593
3594         * Tracing/SystemTracePoints.plist:
3595
3596 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3597
3598         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3599         https://bugs.webkit.org/show_bug.cgi?id=195353
3600         <rdar://problem/48626394>
3601
3602         Reviewed by Simon Fraser.
3603
3604         * WebKitTestRunner/ios/TestControllerIOS.mm:
3605         (WTR::TestController::platformResetPreferencesToConsistentValues):
3606
3607 2019-03-07  John Wilander  <wilander@apple.com>
3608
3609         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3610         https://bugs.webkit.org/show_bug.cgi?id=195383
3611         <rdar://problem/48570136>
3612
3613         Reviewed by Brent Fulgham.
3614
3615         This patch adds test infrastructure to purge only script-accessible cookies,
3616         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3617
3618         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3619         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3620         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3621         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3622         * WebKitTestRunner/TestController.cpp:
3623         (WTR::TestController::statisticsDeleteCookiesForHost):
3624         * WebKitTestRunner/TestController.h:
3625         * WebKitTestRunner/TestInvocation.cpp:
3626         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3627
3628 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3629
3630         Unreviewed, rolling out r242354.
3631         https://bugs.webkit.org/show_bug.cgi?id=195402
3632
3633         breaks layout tests in all configurations (Requested by
3634         zdobersek on #webkit).
3635
3636         Reverted changeset:
3637
3638         "[WPE] Enable web process sandbox"
3639         https://bugs.webkit.org/show_bug.cgi?id=195169
3640         https://trac.webkit.org/changeset/242354
3641
3642 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3643
3644         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3645         https://bugs.webkit.org/show_bug.cgi?id=195346
3646
3647         Reviewed by Fujii Hironori.
3648
3649         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3650         (TestWebKitAPI::TEST):
3651         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3652
3653         * DumpRenderTree/win/DumpRenderTree.cpp:
3654         (findFontFallback):
3655         (addFontFallbackIfPresent):
3656         (removeFontFallbackIfPresent):
3657         (main):
3658         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3659         (TestWebKitAPI::Util::moduleDirectory):
3660         (TestWebKitAPI::Util::createInjectedBundlePath):
3661         Use wchar helpers as needed.
3662
3663 2019-03-06  Rob Buis  <rbuis@igalia.com>
3664
3665         Consider supporting the `referrerpolicy` attribute.
3666         https://bugs.webkit.org/show_bug.cgi?id=179053
3667
3668         Reviewed by Darin Adler.
3669
3670         Add a runtime flag for referrerpolicy attribute.
3671
3672         * DumpRenderTree/mac/DumpRenderTree.mm:
3673         (enableExperimentalFeatures):
3674
3675 2019-03-05  Daniel Bates  <dabates@apple.com>
3676
3677         Update expected API test result following r242379
3678         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3679
3680         Update expected x-coordinate of selection rect now that the left padding of
3681         a textarea is sized in ems (so dependent on the font size) just like the left
3682         padding of a text field.
3683
3684         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3685         (TestWebKitAPI::TEST):
3686
3687 2019-03-05  David Quesada  <david_quesada@apple.com>
3688
3689         [WK2] It should be possible to follow links with 'download' attributes
3690         https://bugs.webkit.org/show_bug.cgi?id=195145
3691         rdar://problem/48462642
3692
3693         Reviewed by Alex Christensen.
3694
3695         Add a unit test to verify that activating links with 'download' attributes now
3696         navigates to the linked resource, rather than starts downloading it. Add another
3697         to verify that it is still possible to explicitly download the link via the
3698         'Download' navigation action policy.
3699
3700         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3701         (-[DownloadAttributeTestDelegate init]):
3702         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3703         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3704         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3705         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3706         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3707         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3708         (TEST):
3709         * WebKitTestRunner/TestController.cpp:
3710         (WTR::TestController::decidePolicyForNavigationAction):
3711         * WebKitTestRunner/TestController.h:
3712
3713 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3714
3715         [Curl] Implement Cookie Accept Policy.
3716         https://bugs.webkit.org/show_bug.cgi?id=191645
3717
3718         Reviewed by Fujii Hironori.
3719
3720         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3721         (TestWebKitAPI::Curl::TEST_F):
3722
3723 2019-03-05  Youenn Fablet  <youenn@apple.com>
3724
3725         Rename requestCacheStorageSpace to requestStorageSpace
3726         https://bugs.webkit.org/show_bug.cgi?id=195282
3727
3728         Reviewed by Chris Dumez.
3729
3730         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3731         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3732         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3733
3734 2019-03-05  Brady Eidson  <beidson@apple.com>
3735
3736         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3737         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3738
3739         Reviewed by Tim Horton.
3740
3741         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3742         different directory into that same WKWebView should work.
3743
3744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3745         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3746
3747 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3748
3749         Add WeakHashSet
3750         https://bugs.webkit.org/show_bug.cgi?id=195152
3751
3752         Reviewed by Antti Koivisto.
3753
3754         Added tests for WeakHashSet.
3755
3756         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3757         (TestWebKitAPI::Base::Base): Moved.
3758         (TestWebKitAPI::Derived::foo): Moved.
3759         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3760         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3761         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3762         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3763
3764 2019-03-04  Chris Dumez  <cdumez@apple.com>
3765
3766         Do not share WebProcesses between private and regular sessions
3767         https://bugs.webkit.org/show_bug.cgi?id=195189
3768         <rdar://problem/48421064>
3769
3770         Reviewed by Alex Christensen.
3771
3772         Add API test coverage.
3773
3774         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3775         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3776
3777 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3778
3779         [WPE] Enable web process sandbox
3780         https://bugs.webkit.org/show_bug.cgi?id=195169
3781
3782         Reviewed by Daniel Bates.
3783
3784         * wpe/install-dependencies:
3785         * wpe/jhbuild.modules:
3786
3787 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3788
3789         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3790         https://bugs.webkit.org/show_bug.cgi?id=195206
3791
3792         Reviewed by Žan Doberšek.
3793
3794         Add a new test case.
3795
3796         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3797         (testJSCClass):
3798
3799 2019-03-04  Charlie Turner  <cturner@igalia.com>
3800
3801         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3802         https://bugs.webkit.org/show_bug.cgi?id=194898
3803
3804         Reviewed by Žan Doberšek.
3805
3806         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3807         a GCC extension that permits arithmetic on void* pointer. Inline
3808         the macro until this issue is fixed upstream.
3809
3810 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3811
3812         Rid the world of WK_API_ENABLED
3813         https://bugs.webkit.org/show_bug.cgi?id=195263
3814
3815         Reviewed by Dan Bernstein.
3816
3817         List of changed files elided because it's useless.
3818
3819 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3820
3821         Unreviewed follow-up to r242292.
3822
3823         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3824
3825         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3826         (TestWebKitAPI::testStrip): Renamed from strip.
3827         (TestWebKitAPI::TEST):
3828
3829 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3830
3831         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3832
3833         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3834         and bug #194272 for details.
3835
3836         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3837
3838 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3839
3840         Remove some more unused 32-bit code
3841         https://bugs.webkit.org/show_bug.cgi?id=195255
3842
3843         Reviewed by Darin Adler.
3844
3845         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3846         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3847         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3848         (NPP_New):
3849         (NPP_HandleEvent):
3850         (handleEventCarbon): Deleted.
3851
3852 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3853
3854         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3855
3856         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3857         (TestWebKitAPI::TEST):
3858
3859 2019-03-01  Darin Adler  <darin@apple.com>
3860
3861         Finish removing String::format
3862         https://bugs.webkit.org/show_bug.cgi?id=194893
3863
3864         Reviewed by Daniel Bates.
3865 '
3866         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3867
3868 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3869
3870         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3871         https://bugs.webkit.org/show_bug.cgi?id=195229
3872         <rdar://problem/48520362>
3873
3874         Reviewed by Chris Dumez.
3875
3876         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3877         (TEST):
3878
3879 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3880
3881         Add a system trace scope for event region building
3882         https://bugs.webkit.org/show_bug.cgi?id=195226
3883
3884         Reviewed by Jon Lee.
3885
3886         This trace scope measures the time spend converting element rects into Region objects,
3887         which can be large on some pages.
3888
3889         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3890
3891         * Tracing/SystemTracePoints.plist:
3892
3893 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3894
3895         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3896         https://bugs.webkit.org/show_bug.cgi?id=194612
3897
3898         Reviewed by Alex Christensen.
3899
3900         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3901         Just test the new string-processing function and don't touch the actual environment.
3902         (Test cases are all as before, but based on operator== instead of strcmp.)
3903
3904 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3905
3906         [ews-app] Update primary keys for handling multiple Buildbot instances
3907         https://bugs.webkit.org/show_bug.cgi?id=195120
3908
3909         Reviewed by Stephanie Lewis.
3910
3911         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3912         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3913         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3914
3915         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3916         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3917         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3918         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3919         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3920         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3921
3922 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3923
3924         [WinCairo] Enable service worker
3925         https://bugs.webkit.org/show_bug.cgi?id=188318
3926
3927         Reviewed by Youenn Fablet.
3928
3929         * DumpRenderTree/DumpRenderTreePrefix.h:
3930         * TestWebKitAPI/PlatformWin.cmake:
3931         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3932         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3933         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3934
3935 2019-03-01  Justin Fan  <justin_fan@apple.com>
3936
3937         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3938         https://bugs.webkit.org/show_bug.cgi?id=195191
3939
3940         Rubber-stamped by Dean Jackson.
3941
3942         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3943
3944         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3945
3946 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3947
3948         Unreviewed, fix lldb webkitpy tests
3949         https://bugs.webkit.org/show_bug.cgi?id=194375
3950
3951         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3952
3953         * lldb/lldb_webkit.py:
3954         (WTFStringImplProvider.is_8bit):
3955
3956 2019-02-28  David Quesada  <david_quesada@apple.com>
3957
3958         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3959         https://bugs.webkit.org/show_bug.cgi?id=195121
3960         rdar://problem/48450302
3961
3962         Reviewed by Alex Christensen.
3963
3964         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3965         configurations where the 'download' attribute is absent, blank, or populated
3966         with a filename, and where the anchor element is same-origin or cross-origin
3967         (meaning the 'download' attribute shouldn't be honored).
3968
3969         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3970         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3971         (-[NavigationActionTestDelegate init]):
3972         (-[NavigationActionTestDelegate navigationAction]):
3973         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3974         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3975         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3976         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3977         (TEST):
3978
3979 2019-02-28  Antoine Quint  <graouts@apple.com>
3980
3981         Enable the Pointer Events runtime flag by default
3982         https://bugs.webkit.org/show_bug.cgi?id=195156
3983
3984         Reviewed by Dean Jackson.
3985
3986         * DumpRenderTree/mac/DumpRenderTree.mm:
3987         (enableExperimentalFeatures):
3988
3989 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3990
3991         Several PasteImage API tests are flaky
3992         https://bugs.webkit.org/show_bug.cgi?id=195160
3993
3994         Reviewed by Tim Horton.
3995
3996         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3997         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3998         listening for a "load" event after image load is already complete.
3999
4000         To address this, make these tests first register a "load" event handler, then run script to insert an image
4001         element into the document, and finally wait until the load event is observed before checking image size.
4002
4003         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4004
4005 2019-02-28  Chris Dumez  <cdumez@apple.com>
4006
4007         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4008         https://bugs.webkit.org/show_bug.cgi?id=195107
4009
4010         Reviewed by Alex Christensen.
4011
4012         Give some time for the zoom level to get restored.
4013
4014         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4015
4016 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4017
4018         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4019         https://bugs.webkit.org/show_bug.cgi?id=194958
4020
4021         Reviewed by Geoffrey Garen.
4022
4023         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4024         (TEST):
4025
4026 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4027
4028         [ews-app] Update method to save build to handle builder_display_name
4029         https://bugs.webkit.org/show_bug.cgi?id=195047
4030
4031         Reviewed by Dewei Zhu.
4032
4033         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4034         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4035
4036 2019-02-28  Justin Fan  <justin_fan@apple.com>
4037
4038         [Web GPU] Enable Web GPU only on 64-bit
4039         https://bugs.webkit.org/show_bug.cgi?id=195139
4040
4041         Because Metal is only supported on 64 bit apps.
4042
4043         Unreviewed build fix.
4044
4045         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4046
4047 2019-02-27  Youenn Fablet  <youenn@apple.com>
4048
4049         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4050         https://bugs.webkit.org/show_bug.cgi?id=194959
4051
4052         Reviewed by Chris Dumez.
4053
4054         Spin loop until getting the condition to remove flakiness.
4055
4056         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4057
4058 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4059
4060         [ews-build] Buildbot should include builder_display_name in the build events
4061         https://bugs.webkit.org/show_bug.cgi?id=195045
4062
4063         Reviewed by Dewei Zhu.
4064
4065         * BuildSlaveSupport/ews-build/events.py:
4066         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4067         buildername to builder_name to be consistent in naming style.
4068         (Events.buildFinished): Ditto.
4069
4070 2019-02-27  Chris Dumez  <cdumez@apple.com>
4071
4072         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4073         https://bugs.webkit.org/show_bug.cgi?id=194480
4074
4075         Reviewed by Brady Eidson.
4076
4077         Update existing API test to make it more likely to reproduce the issue.
4078
4079         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4080
4081 2019-02-27  Brady Eidson  <beidson@apple.com>
4082
4083         Universal links from Google search results pages don't open the app.
4084         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4085
4086         Reviewed by Geoffrey Garen.
4087
4088         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4089         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4090         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4091         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4092
4093 2019-02-27  Chris Dumez  <cdumez@apple.com>
4094
4095         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4096         https://bugs.webkit.org/show_bug.cgi?id=195102
4097
4098         Reviewed by Geoffrey Garen.
4099
4100         If the number of processes is not yet what we expect, wait a bit and check again to give
4101         processes some time to exit.
4102
4103         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4104
4105 2019-02-27  Chris Dumez  <cdumez@apple.com>
4106
4107         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4108         https://bugs.webkit.org/show_bug.cgi?id=194545
4109
4110         Reviewed by Brady Eidson.
4111
4112         Make sure the test navigates forward and then back only once. Previously, navigating
4113         back would trigger a navigation again in a timer.
4114
4115         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4116
4117 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4118
4119         High Sierra Debug JSC test queue should use faster hardware
4120         https://bugs.webkit.org/show_bug.cgi?id=194603
4121
4122         Rubber-stamped by Alexey Proskuryakov.
4123
4124         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4125
4126         * BuildSlaveSupport/build.webkit.org-config/config.json:
4127         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4128         (BubbleQueueServer):
4129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4130         (WebKitBuildbot):
4131         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4132         * QueueStatusServer/config/queues.py:
4133         * Scripts/webkitpy/common/config/ews.json:
4134         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4135         (test_ews_name):
4136
4137 2019-02-27  John Wilander  <wilander@apple.com>
4138
4139         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4140         https://bugs.webkit.org/show_bug.cgi?id=195071
4141         <rdar://problem/48417690>
4142
4143         Reviewed by Alex Christensen and Brent Fulgham.
4144
4145         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4146         (TestWebKitAPI::createURL):
4147             Convenience function.
4148         (TestWebKitAPI::TEST):
4149             WebCore::AdClickAttribution now takes a URL when creating Source and
4150             Destination.
4151         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4152         (TestWebKitAPI::TEST):
4153             WebCore::AdClickAttribution now takes a URL when creating Source and
4154             Destination.
4155
4156 2019-02-27  Antoine Quint  <graouts@apple.com>
4157
4158         Support Pointer Events on macOS
4159         https://bugs.webkit.org/show_bug.cgi?id=195008
4160         <rdar://problem/47454419>
4161
4162         Reviewed by Dean Jackson.
4163
4164         * DumpRenderTree/mac/DumpRenderTree.mm:
4165         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4166         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4167
4168 2019-02-26  Mark Lam  <mark.lam@apple.com>
4169
4170         Remove remaining poisoning code.
4171         https://bugs.webkit.org/show_bug.cgi?id=194138
4172
4173         Reviewed by Saam Barati.
4174
4175         * TestWebKitAPI/CMakeLists.txt:
4176         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4177         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4178         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4179         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4180         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4181         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4182         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4183
4184 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4185
4186         Move ephemeral local storage from WebProcess to UIProcess
4187         https://bugs.webkit.org/show_bug.cgi?id=195074
4188         <rdar://problem/47937975>
4189
4190         Reviewed by Geoff Garen.
4191
4192         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4193
4194 2019-02-20  Jer Noble  <jer.noble@apple.com>
4195
4196         [Cocoa] Media elements will restart network buffering just before suspending
4197         https://bugs.webkit.org/show_bug.cgi?id=193691
4198
4199         Reviewed by Eric Carlson.
4200
4201         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4202         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4203         (TEST):
4204
4205 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4206
4207         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4208         https://bugs.webkit.org/show_bug.cgi?id=191652
4209
4210         Reviewed by Alex Christensen.
4211
4212         Fix WinCairo MiniBrowser behavior of authentication dialog.
4213
4214         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4215         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4216
4217 2019-02-26  Youenn Fablet  <youenn@apple.com>
4218
4219         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4220         https://bugs.webkit.org/show_bug.cgi?id=195028
4221         <rdar://problem/48243733>
4222
4223         Reviewed by Eric Carlson.
4224
4225         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4226
4227 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4228
4229         [WPE] Add API for webview background color configuration
4230         https://bugs.webkit.org/show_bug.cgi?id=192305
4231
4232         Reviewed by Michael Catanzaro.
4233
4234         * MiniBrowser/wpe/main.cpp:
4235         (main): Add a new option to configure the webview background
4236         color. Example: --bg-color=transparent.
4237         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4238         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4239         (beforeAll): Ditto.
4240
4241 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4242
4243         scalableNativeWebpageParameters() is not preserved on new page navigation.
4244         https://bugs.webkit.org/show_bug.cgi?id=194892
4245         <rdar://problem/47538280>
4246
4247         Reviewed by Wenson Hsieh.
4248         
4249         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4250
4251         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4252         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4253         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4254         (WTR::UIScriptController::allowsViewportShrinkToFit):
4255         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4256         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4257         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4258         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4259         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4260         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4261
4262 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4263
4264         [ews-app] Add model for handling multiple Buildbot instances
4265         https://bugs.webkit.org/show_bug.cgi?id=194863
4266
4267         Reviewed by Stephanie Lewis.
4268
4269         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4270
4271 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4272
4273         [ews-app] Remove BuilderMapping table
4274         https://bugs.webkit.org/show_bug.cgi?id=194961
4275
4276         Reviewed by Stephanie Lewis.
4277
4278         Store builder name directly in build table, instead of having a separate
4279         table for it.
4280
4281         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4282         * BuildSlaveSupport/ews-app/ews/models/build.py:
4283         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4284         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4285
4286 2019-02-25  John Wilander  <wilander@apple.com>
4287
4288         Introduce and adopt new class RegistrableDomain for eTLD+1
4289         https://bugs.webkit.org/show_bug.cgi?id=194791
4290         <rdar://problem/48179240>
4291
4292         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4293
4294         This patch adds an API test and replaces two instances of
4295         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4296
4297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4298         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4299         (TestWebKitAPI::TEST):
4300             Changed two strings to make sure the registrable domains are still considered
4301             invalid and pass the test.
4302         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4303         (TestWebKitAPI::TEST):
4304         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4305         (WTR::InjectedBundle::didReceiveMessageToPage):
4306
4307 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4308
4309         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4310         https://bugs.webkit.org/show_bug.cgi?id=195001
4311
4312         Reviewed by Carlos Garcia Campos.
4313
4314         API version 1.0 always includes the functionality previously guarded with
4315         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4316         unconditionally.
4317
4318         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4319         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4320         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4321         (WebViewTest::showInWindow): Ditto.
4322         (WebViewTest::hideView): Ditto.
4323         * wpe/backends/HeadlessViewBackend.cpp:
4324         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4325         * wpe/backends/ViewBackend.cpp:
4326         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4327         * wpe/backends/WindowViewBackend.cpp:
4328         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4329         WPE_BACKEND_CHECK_VERSION().
4330         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4331
4332 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4333
4334         [Flatpak] Add support for flatpak > 1.1.2
4335         https://bugs.webkit.org/show_bug.cgi?id=194088
4336
4337         Flatpak 1.2 is now out so we need to support that
4338         version now.
4339
4340         Reviewed by Michael Catanzaro.
4341
4342         * flatpak/flatpakutils.py:
4343         (check_flatpak):
4344         (FlatpakPackages.__init__):
4345         (FlatpakPackages.__detect_packages):
4346         (FlatpakPackages.__detect_packages.in):
4347         (FlatpakRepos.update):
4348
4349 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4350
4351         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4352         https://bugs.webkit.org/show_bug.cgi?id=194998
4353
4354         Reviewed by Carlos Garcia Campos.
4355
4356         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4357         to a Git checkout and using the latest commit containing various fixes
4358         and improvements.
4359
4360 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4361
4362         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4363         https://bugs.webkit.org/show_bug.cgi?id=194981
4364
4365         Reviewed by Žan Doberšek.
4366
4367         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4368         (TestWebKitAPI::TEST):
4369