REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
2
3         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
4         https://bugs.webkit.org/show_bug.cgi?id=160985
5
6         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
7         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
8         with that.
9
10         * Scripts/webkitpy/layout_tests/views/printing.py:
11         (Printer.print_config):
12         * Scripts/webkitpy/port/base.py:
13         (Port.driver_cmd_line_for_logging):
14         (Port.driver_cmd_line): Deleted.
15         * Scripts/webkitpy/port/driver.py:
16         (IOSSimulatorDriver.cmd_line):
17         * Scripts/webkitpy/port/ios.py:
18         (IOSSimulatorPort.__init__):
19         (IOSSimulatorPort.driver_cmd_line_for_logging):
20         (IOSSimulatorPort._create_simulators):
21         (IOSSimulatorPort.setup_test_run):
22         (IOSSimulatorPort._quit_ios_simulator):
23         (IOSSimulatorPort.clean_up_test_run):
24         (IOSSimulatorPort._create_device):
25         (IOSSimulatorPort):
26         (IOSSimulatorPort._remove_device):
27         (IOSSimulatorPort._testing_device):
28         (IOSSimulatorPort.device_id_for_worker_number):
29         (IOSSimulatorPort._set_device_class): Deleted.
30         (IOSSimulatorPort.testing_device): Deleted.
31         * Scripts/webkitpy/port/port_testcase.py:
32         (PortTestCase.test_driver_cmd_line):
33         * Scripts/webkitpy/xcode/simulator.py:
34         (Device.shutdown):
35         (Device):
36         (Device.delete):
37         (Device.reset):
38         (Simulator):
39         (Simulator.create_device):
40         (Simulator.remove_device):
41         (Simulator.device_number):
42         (Simulator.device_state_description):
43         (Simulator.wait_until_device_is_in_state):
44
45 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
46
47         Unreviewed, rolling out r204659.
48
49         This change appears to have caused ios-simulator LayoutTests
50         to fail when shutting down the simulator
51
52         Reverted changeset:
53
54         "REGRESSION (r204477): Running LayoutTests on ios-simulator
55         became ~15 minutes slower"
56         https://bugs.webkit.org/show_bug.cgi?id=160985
57         http://trac.webkit.org/changeset/204659
58
59 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
60
61         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
62         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
63
64 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
65
66         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
67         https://bugs.webkit.org/show_bug.cgi?id=160985
68
69         Reviewed by Alexey Proskuryakov.
70         
71         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
72         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
73         must not be @memoized, because their return value depends on the value of simulator_device_type().
74         
75         Fix by adding some global state in simulator.py that tracks the created devices 
76         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
77         and delete them in clean_up_test_run().
78         
79         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
80         that killing the Simulator apps isn't enough.
81         
82         Simulator tracks the devices in a global dictionary, since state needs to persist
83         across different instances of IOSSimulatorPort.
84         
85         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
86         any setup. Rather than implicitly creating a device here (which the old code did),
87         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
88         and set flag to say that device_id_for_worker_number() doesn't need to return a real
89         device id.
90
91         * Scripts/webkitpy/layout_tests/views/printing.py:
92         (print_options):
93         (Printer.print_config):
94         * Scripts/webkitpy/port/base.py:
95         (Port.driver_cmd_line_for_logging):
96         (Port.driver_cmd_line): Deleted.
97         * Scripts/webkitpy/port/driver.py:
98         (IOSSimulatorDriver.cmd_line):
99         * Scripts/webkitpy/port/ios.py:
100         (IOSSimulatorPort.__init__):
101         (IOSSimulatorPort.driver_cmd_line_for_logging):
102         (IOSSimulatorPort._create_simulators):
103         (IOSSimulatorPort.setup_test_run):
104         (IOSSimulatorPort.clean_up_test_run):
105         (IOSSimulatorPort._create_device):
106         (IOSSimulatorPort):
107         (IOSSimulatorPort._remove_device):
108         (IOSSimulatorPort._testing_device):
109         (IOSSimulatorPort.device_id_for_worker_number):
110         (IOSSimulatorPort._set_device_class): Deleted.
111         (IOSSimulatorPort.testing_device): Deleted.
112         * Scripts/webkitpy/port/port_testcase.py:
113         (PortTestCase.test_driver_cmd_line):
114         * Scripts/webkitpy/xcode/simulator.py:
115         (Device.shutdown):
116         (Device.delete):
117         (Device.reset):
118         (Simulator.create_device):
119         (Simulator.remove_device):
120         (Simulator.device_number):
121         (Simulator.device_state_description):
122         (Simulator.wait_until_device_is_in_state):
123
124 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
125
126         Adopt SimServiceContext in LayoutTestRelay
127         https://bugs.webkit.org/show_bug.cgi?id=161000
128         <rdar://problem/25765594>
129
130         Reviewed by Daniel Bates.
131
132         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
133         * LayoutTestRelay/LayoutTestRelay/main.m:
134
135 2016-08-19  Lucas Forschler  <lforschler@apple.com>
136
137         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
138
139         Reviewed by Kocsen Chung.
140
141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
142         (WebKitBuildbot):
143
144 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
145
146         Partial revert of r203811 - this key is not needed.
147
148         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
149
150 2016-08-19  Daniel Bates  <dabates@apple.com>
151
152         Another attempt to fix the iOS 9.3 build
153
154         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
155
156         * DumpRenderTree/mac/Configurations/Base.xcconfig:
157         * WebKitTestRunner/Configurations/Base.xcconfig:
158
159 2016-08-19  Lucas Forschler  <lforschler@apple.com>
160
161         Remove Yosemite Leaks bot from config.json
162         
163         Reviewed by Alexey Proskuryakov.
164
165         * BuildSlaveSupport/build.webkit.org-config/config.json:
166
167 2016-08-18  Dan Bernstein  <mitz@apple.com>
168
169         [Cocoa] API::Number needs to be wrapped by an NSNumber
170         https://bugs.webkit.org/show_bug.cgi?id=160977
171         <rdar://problem/27877735>
172
173         Reviewed by Anders Carlsson.
174
175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
176         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
177         (TestWebKitAPI::TEST):
178
179 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
180
181         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
182         https://bugs.webkit.org/show_bug.cgi?id=160895
183
184         Reviewed by Dean Jackson.
185
186         Link to the existing CoreText framework.
187
188         * DumpRenderTree/PlatformWin.cmake:
189         * TestWebKitAPI/PlatformWin.cmake:
190
191 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
192
193         [Win] Remove old libraries from build inputs
194         https://bugs.webkit.org/show_bug.cgi?id=160949
195
196         Reviewed by Dean Jackson.
197
198         Modify the download script to remove the old 'icuuc.lib' and
199         'icuin.lib' files for Windows builds.
200
201         * Scripts/update-webkit-auxiliary-libs:
202
203 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
204
205         Extra logging for crash reason
206         https://bugs.webkit.org/show_bug.cgi?id=160943
207
208         Reviewed by Alexey Proskuryakov.
209
210         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
211
212         * Scripts/webkitpy/port/server_process.py:
213         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
214         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
215         (ServerProcess.has_crashed): Ditto.
216
217 2016-08-17  Dan Bernstein  <mitz@apple.com>
218
219         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
220         https://bugs.webkit.org/show_bug.cgi?id=160938
221         <rdar://problem/27876652>
222
223         Reviewed by Anders Carlsson.
224
225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
226         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
227         (TestWebKitAPI::TEST):
228
229 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
230
231         AX: Support abbreviations in iOS
232         https://bugs.webkit.org/show_bug.cgi?id=160907
233
234         Reviewed by Joanmarie Diggs.
235
236         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
237         (AccessibilityUIElement::stringAttributeValue):
238         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
239         (WTR::AccessibilityUIElement::stringAttributeValue):
240
241 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
242
243         [EFL] Bump efl version from 1.17 to 1.18
244         https://bugs.webkit.org/show_bug.cgi?id=160899
245
246         Reviewed by Antonio Gomes.
247
248         To use efl-1.18, EFL port needs to update install dependencies as well.
249
250         * efl/install-dependencies:
251         * efl/jhbuild.modules:
252
253 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
254
255         [Win] Add tests for linked fonts.
256         https://bugs.webkit.org/show_bug.cgi?id=160898
257
258         Reviewed by Brent Fulgham.
259
260         Add tests for https://trac.webkit.org/changeset/204502.
261
262         * TestWebKitAPI/PlatformWin.cmake:
263         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
264         (TestWebKitAPI::TEST):
265
266 2016-08-16  Daniel Bates  <dabates@apple.com>
267
268         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
269         https://bugs.webkit.org/show_bug.cgi?id=160924
270
271         Reviewed by Stephanie Lewis.
272
273         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
274         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
275         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
276         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
277         object that mocks out the file system and SCM operations.
278
279         * Scripts/VCSUtils.pm:
280         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
281         * Scripts/prepare-ChangeLog:
282         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
283         abstracting the logic to query the file system and SCM into functions on a delegate object that
284         we pass to it.
285         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
286         (diffHeaderFormat): Deleted.
287
288 2016-08-16  Alex Christensen  <achristensen@webkit.org>
289
290         URLParser should parse URLs without credentials
291         https://bugs.webkit.org/show_bug.cgi?id=160913
292
293         Reviewed by Brady Eidson.
294
295         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
296         (TestWebKitAPI::s):
297         (TestWebKitAPI::checkURL):
298         (TestWebKitAPI::TEST_F):
299
300 2016-08-16  Anders Carlsson  <andersca@apple.com>
301
302         Add WTF::ScopeExit
303         https://bugs.webkit.org/show_bug.cgi?id=160908
304
305         Reviewed by Geoffrey Garen.
306
307         * TestWebKitAPI/CMakeLists.txt:
308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
309         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
310         (TestWebKitAPI::TEST):
311
312 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
313
314         EWS logs file are rotated too quickly
315         https://bugs.webkit.org/show_bug.cgi?id=160724
316
317         Reviewed by Daniel Bates.
318
319         Currently we are rotating the log file after 10 iterations of queue. If the queue
320         doesn't have any pending patches, these iterations result in very small amount of 
321         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
322         This results in a lot of log files in a day. This patch ensures that we rotate the
323         log file when its file size is greater than or equal to 100 KB.
324
325         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
326
327 2016-08-16  Daniel Bates  <dabates@apple.com>
328
329         WKSI static library should be named by major iOS revision, not individual updates
330         https://bugs.webkit.org/show_bug.cgi?id=160727
331         <rdar://problem/22274848>
332
333         Reviewed by Alexey Proskuryakov.
334
335         * DumpRenderTree/mac/Configurations/Base.xcconfig:
336         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
337         * Scripts/copy-webkitlibraries-to-product-directory:
338         * WebKitTestRunner/Configurations/Base.xcconfig:
339         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
340
341 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
342
343         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
344         https://bugs.webkit.org/show_bug.cgi?id=160909
345
346         Reviewed by Enrica Casucci.
347         
348         Add functions to UIScriptController to dismiss the form accessory view for iOS,
349         and to programmatically pick a row from a <select> picker.
350
351         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
352         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
353         (WTR::UIScriptController::dismissFormAccessoryView):
354         (WTR::UIScriptController::selectFormAccessoryPickerRow):
355         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
356         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
357         (WTR::UIScriptController::dismissFormAccessoryView):
358         (WTR::UIScriptController::selectFormAccessoryPickerRow):
359
360 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
361
362         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
363         https://bugs.webkit.org/show_bug.cgi?id=160878
364
365         Reviewed by Tim Horton.
366         
367         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
368         now that we have the ability to run tests in the iPad simulator.
369
370         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
371         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
372         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
373         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
374         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
375         * WebKitTestRunner/ios/TestControllerIOS.mm:
376         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
377         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
378         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
379         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
380
381 2016-08-15  Anders Carlsson  <andersca@apple.com>
382
383         Add an address-of operator to RetainPtr
384         https://bugs.webkit.org/show_bug.cgi?id=160879
385
386         Reviewed by Tim Horton.
387
388         Test HashMap and HashSet with an object whose operator& is deleted.
389
390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
391         Sort the Xcode project.
392
393         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
394         (DeletedAddressOfOperator::DeletedAddressOfOperator):
395         (DeletedAddressOfOperator::value):
396         (DeletedAddressOfOperator::operator==):
397         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
398         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
399         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
400         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
401         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
402         (TestWebKitAPI::TEST):
403         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
404         (TestWebKitAPI::TEST):
405
406 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
407
408         False crashes in fast/text/emoji-gender-* tests
409         https://bugs.webkit.org/show_bug.cgi?id=160779
410
411         Reviewed by Alexey Proskuryakov.
412
413         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
414
415         * Scripts/webkitpy/port/driver.py:
416         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
417         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
418         * Scripts/webkitpy/port/server_process.py:
419         (ServerProcess.write): Allow caller to disable crash flag on exception.
420
421 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
422
423         webkitpy error in TestRunResults.merge()
424         https://bugs.webkit.org/show_bug.cgi?id=160882
425
426         Reviewed by Daniel Bates.
427         
428         The argument to TestRunResults.merge() can be None if there are no device-specifc
429         initial results or retry results in Manager.run(), so just return early in that case.
430
431         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
432         (TestRunResults.merge):
433
434 2016-08-15  Sam Weinig  <sam@webkit.org>
435
436         Speed up compile times by not including wtf/Variant.h so much
437         https://bugs.webkit.org/show_bug.cgi?id=160847
438
439         Reviewed by Alex Christensen and Saam Barati.
440
441         * TestWebKitAPI/Tests/WTF/Variant.cpp:
442         (TestWebKitAPI::TEST):
443         Explicitly use std::experimental::variant.
444
445 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
446
447         Allow a port to run tests with a custom device setup
448         https://bugs.webkit.org/show_bug.cgi?id=160833
449
450         Reviewed by Daniel Bates.
451
452         These changes allow the IOSSimulator port to run tests in iPad mode.
453
454         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
455         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
456         a custom device will be collected into a set, and run in that device's environment after
457         the other tests have run.
458
459         * Scripts/webkitpy/layout_tests/controllers/manager.py:
460         (Manager._custom_device_for_test): If the test contains a directory matching a
461         custom device suffix, return that custom device.
462         (Manager._set_up_run): Push the custom device class, if any, into options so
463         that the Worker can get to it.
464         (Manager.run): Go through the list of tests, and break it down into device-generic
465         tests, and tests for each device class. _run_test_subset is then called for
466         each collection of tests, and the results merged.
467         (Manager._run_test_subset): Some lines unwrapped.
468         (Manager._end_test_run):
469         (Manager._run_tests):
470         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
471         (SingleTestRunner.__init__): Unwrapped a line.
472         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
473         (TestRunResults.merge): Add this function to merge TestRunResults
474         * Scripts/webkitpy/layout_tests/views/printing.py:
475         (Printer.print_workers_and_shards): Print the custom device, if any.
476         * Scripts/webkitpy/port/base.py:
477         (Port): Base port has empty array of custom devices.
478         (Port.setup_test_run): Add device_class argument.
479         * Scripts/webkitpy/port/driver.py:
480         (DriverInput.__repr__):
481         (Driver.check_driver.implementation):
482         * Scripts/webkitpy/port/efl.py:
483         (EflPort.setup_test_run):
484         * Scripts/webkitpy/port/gtk.py:
485         (GtkPort.setup_test_run):
486         * Scripts/webkitpy/port/ios.py:
487         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
488         (IOSSimulatorPort.__init__):
489         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
490         based on the custom device class.
491         (IOSSimulatorPort._set_device_class):
492         (IOSSimulatorPort._create_simulators): Factor some code into this function.
493         (IOSSimulatorPort.setup_test_run):
494         (IOSSimulatorPort.testing_device):
495         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
496         seemed wrong for this function. That was moved to setup_test_run().
497         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
498         but this happened too early, before we knew which kind of devices to create. Devices
499         are now created in setup_test_run().
500         * Scripts/webkitpy/port/win.py:
501         (WinPort.setup_test_run):
502
503 2016-08-15  Daniel Bates  <dabates@apple.com>
504
505         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
506         private frameworks and libraries
507         https://bugs.webkit.org/show_bug.cgi?id=155931
508         <rdar://problem/25807989>
509
510         Reviewed by Dan Bernstein.
511
512         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
513         where X is the major version of the active iOS SDK.
514
515         * DumpRenderTree/mac/Configurations/Base.xcconfig:
516         * WebKitTestRunner/Configurations/Base.xcconfig:
517
518 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
519
520         Add a setting and preferences to enable visual viewport mode
521         https://bugs.webkit.org/show_bug.cgi?id=160843
522
523         Reviewed by Sam Weinig.
524         
525         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
526
527         * MiniBrowser/mac/SettingsController.h:
528         * MiniBrowser/mac/SettingsController.m:
529         (-[SettingsController _populateMenu]):
530         (-[SettingsController validateMenuItem:]):
531         (-[SettingsController visualViewportEnabled]):
532         (-[SettingsController toggleVisualViewportEnabled:]):
533         * MiniBrowser/mac/WK1BrowserWindowController.m:
534         (-[WK1BrowserWindowController didChangeSettings]):
535         * MiniBrowser/mac/WK2BrowserWindowController.m:
536         (-[WK2BrowserWindowController didChangeSettings]):
537
538 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
539
540         Allow using make-dist with non-GTK ports
541         https://bugs.webkit.org/show_bug.cgi?id=160842
542
543         Reviewed by Michael Catanzaro.
544
545         This patch adds support for setting base name of tarball and argument
546         passed to cmake's -DPORT= via command line arguments.
547
548         * gtk/make-dist.py:
549         (Distcheck.configure):
550         (Distcheck.check):
551         (get_tarball_root_and_output_filename_from_arguments):
552
553 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
554
555         [GTK] Install script lacks gstreamer related dependencies
556         https://bugs.webkit.org/show_bug.cgi?id=160814
557
558         Reviewed by Carlos Garcia Campos.
559
560         * gtk/install-dependencies: Fedora case had already listed this dependencies,
561         but both Arch and Debian/Ubuntu were missing them.
562
563 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
564
565         make-dist.py should not allow unknown rules in manifest
566         https://bugs.webkit.org/show_bug.cgi?id=160841
567
568         Reviewed by Carlos Garcia Campos.
569
570         * gtk/make-dist.py:
571         (Manifest.process_line):
572
573 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
574
575         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
576         https://bugs.webkit.org/show_bug.cgi?id=160809
577
578         Reviewed by Carlos Garcia Campos.
579
580         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
581         case, and use it also for the new package names of libpng and libgeoclue.
582         * gtk/install-dependencies: Ditto.
583
584 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
585
586         Skip to check directories existence in build-webkit
587         https://bugs.webkit.org/show_bug.cgi?id=160691
588
589         Reviewed by Alex Christensen.
590
591         CMake checks if directories are there itself. So CMake ports
592         don't need to check it in the build-webkit script.
593
594         * Scripts/build-webkit:
595         * Scripts/webkitdirs.pm:
596         (determineSourceDir):
597         (isCMakeBuild):
598
599 2016-08-12  Alex Christensen  <achristensen@webkit.org>
600
601         Make URLParser work with URLs missing URL parts
602         https://bugs.webkit.org/show_bug.cgi?id=160824
603
604         Reviewed by Brady Eidson.
605
606         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
607         (TestWebKitAPI::s):
608         (TestWebKitAPI::checkURL):
609         (TestWebKitAPI::TEST_F):
610         (TestWebKitAPI::eq): Deleted.
611
612 2016-08-12  John Wilander  <wilander@apple.com>
613
614         Add HashCountedSet API tests to TestWTFLibrary target
615         https://bugs.webkit.org/show_bug.cgi?id=160815
616
617         Reviewed by Alex Christensen.
618
619         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
620             Added HashCountedSet.cpp and sorted the file reference section
621             according to UNIX sort.
622
623 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
624
625         run-benchmark should run JetStream 1.1 instead of 1.0.1
626         https://bugs.webkit.org/show_bug.cgi?id=160816
627
628         Reviewed by Filip Pizlo.
629
630         Use the latest JetStream 1.1 in run-benchmark.
631
632         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
633         (BenchmarkBuilder.__exit__):
634         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
635         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
636         change to JetStream directory.
637
638 2016-08-12  Alex Christensen  <achristensen@webkit.org>
639
640         Initial URLParser implementation
641         https://bugs.webkit.org/show_bug.cgi?id=160811
642
643         Reviewed by Brady Eidson.
644
645         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
646         (TestWebKitAPI::eq):
647         (TestWebKitAPI::checkURL):
648         (TestWebKitAPI::TEST_F):
649
650 2016-08-12  Brady Eidson  <beidson@apple.com>
651
652         Fix the 32-bit Mac build after:
653         Add WK2 ExperimentalFeature support to MiniBrowser
654         https://bugs.webkit.org/show_bug.cgi?id=160788
655
656         Unreviewed.
657
658         Sprinkle "#if WK_API_ENABLED"s liberally.
659         
660         * MiniBrowser/mac/AppDelegate.m:
661         (defaultConfiguration):
662         * MiniBrowser/mac/SettingsController.m:
663         (-[SettingsController _populateMenu]):
664         (-[SettingsController validateMenuItem:]):
665
666 2016-08-12  Philippe Normand  <pnormand@igalia.com>
667
668         [GStreamer][OWR] Video rendering fixes
669         https://bugs.webkit.org/show_bug.cgi?id=160764
670
671         Reviewed by Xabier Rodriguez-Calvar.
672
673         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
674
675 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
676
677         Add missing return statement in convertFast function added in r204376.
678
679         Unreviewed.
680
681         * Scripts/webkitpy/common/system/path.py:
682         (_CygPath.convertFast):
683
684 2016-08-11  Brady Eidson  <beidson@apple.com>
685
686         Add WK2 ExperimentalFeature support to MiniBrowser.
687         https://bugs.webkit.org/show_bug.cgi?id=160788
688
689         Reviewed by Alex Christensen.
690
691         * MiniBrowser/mac/AppDelegate.h:
692         * MiniBrowser/mac/AppDelegate.m:
693         (defaultConfiguration):
694         (defaultPreferences):
695         
696         * MiniBrowser/mac/SettingsController.m:
697         (-[SettingsController _populateMenu]):
698         (-[SettingsController validateMenuItem:]):
699         (-[SettingsController toggleExperimentalFeature:]):
700
701 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
702
703         Keep EWS logs for longer
704         https://bugs.webkit.org/show_bug.cgi?id=160776
705
706         Reviewed by Daniel Bates.
707
708         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
709
710 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
711
712         iOS DRT/WTR project cleanup
713         https://bugs.webkit.org/show_bug.cgi?id=160778
714
715         Reviewed by Tim Horton.
716
717         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
718
719         Remove AppDelegate.* which were unused.
720
721         Exclude ios/Launch.storyboard on more platforms.
722
723         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
724         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
725         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
726         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
727         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
728         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
729         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
730
731 2016-08-11  Alex Christensen  <achristensen@webkit.org>
732
733         Fix Yosemite bots' cookie accept policies after r204365.
734         https://bugs.webkit.org/show_bug.cgi?id=160758
735
736         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
737         (TEST):
738         This makes the test fully clean up after itself.
739
740 2016-08-11  Alex Christensen  <achristensen@webkit.org>
741
742         Fix Yosemite bots' cookie accept policies after r204365.
743         https://bugs.webkit.org/show_bug.cgi?id=160758
744
745         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
746         (TEST):
747         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
748         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
749         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
750         causing any problems because there are no other API tests that do anything with cookies.
751         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
752         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
753         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
754
755 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
756
757         EWS should check if the patch is still valid before executing every major step
758         https://bugs.webkit.org/show_bug.cgi?id=160739
759         rdar://problem/27768813
760
761         Reviewed by Alexey Proskuryakov.
762
763         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
764         (CommitQueueTask.run): validate method is now executed in base class.
765         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
766         (EarlyWarningSystemTask.run): validate method is now executed in base class.
767         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
768         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
769         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
770         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
771         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
772         * Scripts/webkitpy/tool/commands/perfalizer.py:
773         (PerfalizerTask.validate): Added.
774         * Scripts/webkitpy/tool/commands/queues_unittest.py:
775         (test_manual_reject_during_processing): Updated test case.
776
777 2016-08-11  Alex Christensen  <achristensen@webkit.org>
778
779         Add URLParser stub
780         https://bugs.webkit.org/show_bug.cgi?id=160770
781
782         Reviewed by Sam Weinig.
783
784         * TestWebKitAPI/PlatformGTK.cmake:
785         * TestWebKitAPI/PlatformWin.cmake:
786         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
787         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
788         (TestWebKitAPI::TEST_F):
789
790 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
791
792         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
793         https://bugs.webkit.org/show_bug.cgi?id=160761
794
795         Reviewed by Tim Horton.
796
797         Give iOS DRT a Launch storyboard.
798
799         Have it use a UIViewController so future forms testing works correctly.
800
801         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
802         can run in iPad mode.
803
804         Remove empty InfoPlist.strings files.
805
806         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
807         * DumpRenderTree/ios/Info.plist:
808         * DumpRenderTree/ios/Launch.storyboard: Added.
809         * DumpRenderTree/mac/DumpRenderTree.mm:
810         (createWebViewAndOffscreenWindow):
811         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
812         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
813         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
814         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
815
816 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
817
818         [Win] Unable to reliably run tests in parallel
819         https://bugs.webkit.org/show_bug.cgi?id=140914
820
821         Reviewed by Brent Fulgham.
822
823         The cygpath utility function can fail badly when running with multiple DumpRenderTree
824         processes. We can use string replacement to convert the Cygwin path to a Windows path
825         instead.
826
827         * Scripts/webkitpy/common/system/path.py:
828         (cygpathFast):
829         * Scripts/webkitpy/port/driver.py:
830         (Driver._command_from_driver_input):
831
832 2016-08-10  Alex Christensen  <achristensen@webkit.org>
833
834         Fix crash when changing cookie accept policy after r204327
835         https://bugs.webkit.org/show_bug.cgi?id=160758
836
837         Reviewed by Simon Fraser.
838
839         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
840         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
841         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
842         (TEST):
843         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
844
845 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
846
847         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
848         https://bugs.webkit.org/show_bug.cgi?id=160757
849
850         Reviewed by Tim Horton.
851
852         When programmatically creating the test UIWindow, make a root UIViewController and parent
853         the WKWebView in its view. This makes the app more like a normal UIKit application.
854         
855         Move the WKWebView down 20px to avoid the status bar.
856         
857         Give the UIWindow a gray background so it's obvious where the window and view positioned.
858
859         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
860         
861         Remove duplicate references to Launch.storyboard.
862
863         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
864         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
865         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
866         (-[AppDelegate applicationWillResignActive:]): Deleted.
867         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
868         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
869         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
870         (-[AppDelegate applicationWillTerminate:]): Deleted.
871         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
872         (WTR::viewRectForWindowRect):
873         (WTR::PlatformWebView::PlatformWebView):
874         (WTR::PlatformWebView::setWindowFrame):
875
876 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
877
878         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
879         https://bugs.webkit.org/show_bug.cgi?id=160748
880
881         Reviewed by Tim Horton.
882         
883         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
884         opens the door for tests using other device sizes.
885
886         * WebKitTestRunner/ios/TestControllerIOS.mm:
887         (WTR::TestController::platformConfigureViewForTest):
888
889 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
890
891         Sort the feature flags in the FEATURE_DEFINES lines
892         https://bugs.webkit.org/show_bug.cgi?id=160742
893
894         Reviewed by Anders Carlsson.
895         
896         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
897
898 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
899
900         Logging and other minor improvements to iOS webkitpy
901         https://bugs.webkit.org/show_bug.cgi?id=160722
902
903         Reviewed by Dan Bates.
904
905         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
906         to make it easier to debug launching issues.
907
908         Have reset_preferences() reset the device, rather than just nuking the data
909         directory (which broke some versions of the simulator).
910
911         Make the Simulator.app launch in the background with open -g.
912
913         Wait for the simulator device to be in a known state in some more places.
914
915         * Scripts/webkitpy/port/ios.py:
916         (IOSSimulatorPort.setup_test_run):
917         (IOSSimulatorPort._quit_ios_simulator):
918         (IOSSimulatorPort.clean_up_test_run):
919         (IOSSimulatorPort.setup_environ_for_server):
920         (IOSSimulatorPort.reset_preferences):
921         * Scripts/webkitpy/xcode/simulator.py:
922         (Device.create):
923         (Device.delete):
924         (Device):
925         (Device.reset):
926         (Simulator.wait_until_device_is_booted):
927         (Simulator.wait_until_device_is_in_state):
928         (Simulator):
929         (Simulator.delete_device):
930         (Simulator.reset_device):
931         (Simulator.lookup_or_create_device):
932
933 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
934
935         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
936         https://bugs.webkit.org/show_bug.cgi?id=160697
937
938         Reviewed by Antonio Gomes.
939
940         * Scripts/webkitpy/port/base.py:
941         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
942         list of environment variables to copy.
943
944 2016-08-09  George Ruan  <gruan@apple.com>
945
946         Implement functionality of media capture on iOS
947         https://bugs.webkit.org/show_bug.cgi?id=158945
948         <rdar://problem/26893343>
949
950         Reviewed by Tim Horton.
951
952         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
953         Capture feature on iOS.
954
955 2016-08-09  Saam Barati  <sbarati@apple.com>
956
957         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
958         https://bugs.webkit.org/show_bug.cgi?id=160671
959         <rdar://problem/27756112>
960
961         Reviewed by Mark Lam.
962
963         * Scripts/run-jsc-stress-tests:
964
965 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
966
967         Make directory reading code in iOSSimulatorDevices() more strict
968         https://bugs.webkit.org/show_bug.cgi?id=160702
969
970         Reviewed by Tim Horton.
971
972         * Scripts/webkitdirs.pm:
973         (iOSSimulatorDevices):
974
975 2016-08-06  Sam Weinig  <sam@webkit.org>
976
977         Replace NodeOrString with std::variant<RefPtr<Node>, String>
978         https://bugs.webkit.org/show_bug.cgi?id=160638
979
980         Reviewed by Anders Carlsson.
981
982         * TestWebKitAPI/CMakeLists.txt:
983         * TestWebKitAPI/Tests/WTF/Variant.cpp:
984         Add additional tests for the initial state of std::variant and using
985         makeVisitor for visiting.
986
987 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
988
989         EWS logging should ensure the logging to file is stopped on queue termination
990         https://bugs.webkit.org/show_bug.cgi?id=160698
991         rdar://problem/24464570
992
993         Reviewed by Daniel Bates.
994
995         * Scripts/webkitpy/tool/bot/queueengine.py:
996         (QueueEngine._stopping): Stop logging to file on queue termination.
997         (QueueEngine._begin_logging): Configure the Python logger to log to file.
998         * Scripts/webkitpy/common/system/logutils.py:
999         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
1000         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1001         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
1002         * Scripts/webkitpy/tool/commands/queues.py:
1003         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
1004         (AbstractQueue.queue_log_path): Same.
1005         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
1006         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
1007         which moved to QueueEngine now.
1008         (PatchProcessingQueue.__init__): Same.
1009         (CommitQueue.__init__): Same.
1010         (AbstractReviewQueue.__init__): Same.
1011         (StyleQueue.__init__): Same.
1012         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1013         (TestCommitQueue): Removed host parameter.
1014         (TestCommitQueue.__init__): Same.
1015         (AbstractPatchQueueTest.test_next_patch): Same.
1016         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1017         (test_commit_queue_failure): Same.
1018         (mock_run_webkit_patch):
1019         (MockCommitQueueTask.results_from_patch_test_run): Same.
1020         (test_rollout_lands): Same.
1021         (test_non_valid_patch): Same.
1022         (test_auto_retry): Same.
1023         (test_style_queue_with_watch_list_exception): Same.
1024         (TestQueue.__init__): Deleted.
1025         (TestReviewQueue.__init__): Deleted.
1026         (TestFeederQueue.__init__): Deleted.
1027
1028 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
1029
1030         webkit-gtk tarball fails to build due to missing files
1031         https://bugs.webkit.org/show_bug.cgi?id=160684
1032
1033         Reviewed by Alex Christensen.
1034
1035         * gtk/manifest.txt.in: Added back spi directories.
1036
1037 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1038
1039         [GTK] Build the jhbuild with -O2 optimization level by default
1040         https://bugs.webkit.org/show_bug.cgi?id=160544
1041
1042         Reviewed by Michael Catanzaro.
1043
1044         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
1045         which don't increases the required disk space significatively and
1046         provides better debug information than no passing it.
1047
1048 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
1049
1050         Allow more --cmakeargs option in build-jsc and build-webkit
1051         https://bugs.webkit.org/show_bug.cgi?id=160340
1052
1053         Reviewed by Michael Catanzaro.
1054
1055         * Scripts/build-jsc:
1056         * Scripts/build-webkit:
1057
1058 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1059
1060         Do not check if WebKitLibraries folder exists on EFL and GTK
1061         https://bugs.webkit.org/show_bug.cgi?id=160659
1062
1063         Reviewed by Csaba Osztrogonác.
1064
1065         Though WebKitLibraries is only needed by mac and win ports,
1066         EFL and GTK ports have checked whether it exists.
1067
1068         * Scripts/build-webkit:
1069
1070 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
1071
1072         Some EWS console logs doesn't go to log file
1073         https://bugs.webkit.org/show_bug.cgi?id=160585
1074         rdar://problem/24464570
1075
1076         Reviewed by Daniel Bates.
1077
1078         * Scripts/webkitpy/common/system/logutils.py:
1079         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
1080         any possible overwriting.
1081         * Scripts/webkitpy/common/system/filesystem.py:
1082         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
1083         * Scripts/webkitpy/common/system/filesystem_mock.py:
1084         (MockFileSystem.open_text_file_for_writing): Same.
1085         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1086         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
1087         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
1088         * Scripts/webkitpy/tool/commands/queues.py:
1089         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
1090         This will ensure that all the sub-modules inside webkitpy will log to file.
1091
1092 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
1093
1094         Have the iOS platform interit from the Apple platform in webkitpy
1095         https://bugs.webkit.org/show_bug.cgi?id=160672
1096
1097         Reviewed by Dan Bates.
1098         
1099         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
1100         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
1101         ApplePort.
1102         
1103         Since WinPort also inherits from ApplePort, it needs to stub out some things
1104         that are unavailable on Windows (leaks, sampling).
1105         
1106         Some SnowLeopard-related code and the associated test were removed.
1107
1108         * Scripts/webkitpy/port/apple.py:
1109         (ApplePort.__init__):
1110         (ApplePort):
1111         (ApplePort._make_leak_detector):
1112         (ApplePort.default_timeout_ms):
1113         (ApplePort.supports_per_test_timeout):
1114         (ApplePort.should_retry_crashes):
1115         (ApplePort._generate_all_test_configurations):
1116         (ApplePort.check_for_leaks):
1117         (ApplePort.print_leaks_summary):
1118         (ApplePort._path_to_webcore_library):
1119         (ApplePort.show_results_html_file):
1120         (ApplePort._merge_crash_logs):
1121         (ApplePort._look_for_all_crash_logs_in_log_dir):
1122         (ApplePort._get_crash_log):
1123         (ApplePort.look_for_new_crash_logs):
1124         (ApplePort.sample_process):
1125         (ApplePort.sample_file_path):
1126         (ApplePort.look_for_new_samples):
1127         (ApplePort._path_to_helper):
1128         (ApplePort.determine_full_port_name): Deleted.
1129         * Scripts/webkitpy/port/ios.py:
1130         (IOSSimulatorPort):
1131         (IOSSimulatorPort.__init__):
1132         (IOSSimulatorPort.default_timeout_ms): Deleted.
1133         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
1134         (IOSSimulatorPort.should_retry_crashes): Deleted.
1135         (IOSSimulatorPort.check_for_leaks): Deleted.
1136         (IOSSimulatorPort.print_leaks_summary): Deleted.
1137         (IOSSimulatorPort._path_to_webcore_library): Deleted.
1138         (IOSSimulatorPort.show_results_html_file): Deleted.
1139         (IOSSimulatorPort.sample_file_path): Deleted.
1140         (IOSSimulatorPort._merge_crash_logs): Deleted.
1141         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
1142         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
1143         (IOSSimulatorPort.look_for_new_samples): Deleted.
1144         (IOSSimulatorPort.sample_process): Deleted.
1145         (IOSSimulatorPort._path_to_helper): Deleted.
1146         (IOSSimulatorPort.make_command): Deleted.
1147         * Scripts/webkitpy/port/mac.py:
1148         (MacPort.__init__):
1149         (MacPort.make_command):
1150         (MacPort._build_java_test_support):
1151         (MacPort): Deleted.
1152         (MacPort.default_timeout_ms): Deleted.
1153         (MacPort.supports_per_test_timeout): Deleted.
1154         (MacPort.should_retry_crashes): Deleted.
1155         (MacPort.default_child_processes): Deleted.
1156         (MacPort.check_for_leaks): Deleted.
1157         (MacPort.print_leaks_summary): Deleted.
1158         (MacPort._path_to_webcore_library): Deleted.
1159         (MacPort.show_results_html_file): Deleted.
1160         (MacPort.sample_file_path): Deleted.
1161         (MacPort._merge_crash_logs): Deleted.
1162         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
1163         (MacPort.look_for_new_crash_logs): Deleted.
1164         (MacPort.look_for_new_samples): Deleted.
1165         (MacPort.sample_process): Deleted.
1166         (MacPort._path_to_helper): Deleted.
1167         * Scripts/webkitpy/port/mac_unittest.py:
1168         (MacTest.test_default_child_processes): Deleted.
1169         * Scripts/webkitpy/port/win.py:
1170         (WinPort.look_for_new_samples):
1171         (WinPort):
1172         (WinPort.sample_process):
1173         (WinPort._make_leak_detector):
1174         (WinPort.check_for_leaks):
1175         (WinPort.print_leaks_summary):
1176         (WinPort._path_to_webcore_library):
1177
1178 2016-08-08  Matt Baker  <mattbaker@apple.com>
1179
1180         Unreviewed: moved myself to the reviewers list.
1181
1182         * Scripts/webkitpy/common/config/contributors.json:
1183
1184 2016-08-08  Chris Dumez  <cdumez@apple.com>
1185
1186         Update API tests in mac/SetDocumentURI.mm after r204247
1187         https://bugs.webkit.org/show_bug.cgi?id=160660
1188
1189         Reviewed by Alex Christensen.
1190
1191         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1192         (TestWebKitAPI::TEST):
1193
1194 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
1195
1196         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
1197         https://bugs.webkit.org/show_bug.cgi?id=159827
1198
1199         Reviewed by Daniel Bates.
1200
1201         This change was spurred by a process hang which occurred between tests and did
1202         not produce a meaningful crashlog.
1203
1204         * Scripts/webkitpy/port/driver.py:
1205         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
1206
1207          * Scripts/webkitpy/port/ios.py:
1208         (IOSSimulatorPort):
1209         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
1210         * Scripts/webkitpy/port/mac.py:
1211         (MacPort):
1212         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
1213
1214         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
1215         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1216
1217         * WebKitTestRunner/TestController.h:
1218         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1219         * WebKitTestRunner/TestInvocation.cpp:
1220         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1221
1222 2016-08-07  Dan Bernstein  <mitz@apple.com>
1223
1224         [Cocoa] Reply block leaks if the remote object doesn’t call it
1225         https://bugs.webkit.org/show_bug.cgi?id=160642
1226
1227         Reviewed by Sam Weinig.
1228
1229         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
1230         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1231         (TEST): Added a test case that checks that the reply block is released even when it’s not
1232           called.
1233         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1234         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
1235           calling the completion handler.
1236
1237 2016-08-07  Chris Dumez  <cdumez@apple.com>
1238
1239         Write API test to cover crash fix in r204135
1240         https://bugs.webkit.org/show_bug.cgi?id=160587
1241
1242         Reviewed by Darin Adler.
1243
1244         Add API test to cover crash fix in r204135. This reproduces the crash
1245         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1246         callback.
1247
1248         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1249         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1250         (TEST):
1251
1252 2016-08-06  Chris Dumez  <cdumez@apple.com>
1253
1254         Unreviewed, rolling out r204226.
1255
1256         Broke some API tests
1257
1258         Reverted changeset:
1259
1260         "Write API test to cover crash fix in r204135"
1261         https://bugs.webkit.org/show_bug.cgi?id=160587
1262         http://trac.webkit.org/changeset/204226
1263
1264 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
1265
1266         EWS Style Queue fails to process patches which fails validation
1267         https://bugs.webkit.org/show_bug.cgi?id=160632
1268
1269         Reviewed by Alexey Proskuryakov.
1270
1271         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1272         (StyleQueueTask.validate): Add more information about validation failure.
1273         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1274         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1275         (test_non_valid_patch): Add a unit test to test the above code path.
1276
1277 2016-08-06  Sam Weinig  <sam@webkit.org>
1278
1279         WTF needs a variant implementation
1280         https://bugs.webkit.org/show_bug.cgi?id=160618
1281
1282         Reviewed by Darin Adler.
1283
1284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1285         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
1286         Add tests for the variant implementation.
1287
1288 2016-08-06  Chris Dumez  <cdumez@apple.com>
1289
1290         Write API test to cover crash fix in r204135
1291         https://bugs.webkit.org/show_bug.cgi?id=160587
1292
1293         Reviewed by Darin Adler.
1294
1295         Add API test to cover crash fix in r204135. This reproduces the crash
1296         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1297         callback.
1298
1299         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1300         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1301         (TEST):
1302
1303 2016-08-05  Tim Horton  <timothy_horton@apple.com>
1304
1305         run-api-tests should use a headed simulator
1306         https://bugs.webkit.org/show_bug.cgi?id=160611
1307
1308         Reviewed by Sam Weinig.
1309
1310         CADisplayLink doesn't work in a headless simulator, but is
1311         vital for the proper functioning of WebKit2 painting on iOS.
1312         So, we should not use a headless simulator.
1313
1314         * Scripts/run-api-tests:
1315         Launch a simulator app, don't just boot the simulator.
1316
1317         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1318         Re-enable a test that works now.
1319
1320 2016-08-05  Dan Bernstein  <mitz@apple.com>
1321
1322         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
1323         https://bugs.webkit.org/show_bug.cgi?id=160589
1324
1325         Reviewed by Tim Horton.
1326
1327         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1328         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
1329           blocks, which wasn’t caught because the test wasn’t run correctly.
1330         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1331         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
1332           added a test that sends over an NSRange.
1333         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1334         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
1335           handler with the range‘s location and length.
1336
1337 2016-08-05  Enrica Casucci  <enrica@apple.com>
1338
1339         Fixing tests failing after r204175.
1340
1341         Unreviewed.
1342
1343         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
1344
1345 2016-08-05  Enrica Casucci  <enrica@apple.com>
1346
1347         Build fix after 204053.
1348
1349         Unreviewed.
1350
1351         * TestWebKitAPI/Configurations/Base.xcconfig:
1352         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1353         (-[MockContentFilterEnabler initWithCoder:]):
1354         (-[MockContentFilterEnabler dealloc]):
1355
1356 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
1357
1358         Print test name in "Last character read from DRT..." error message.
1359         https://bugs.webkit.org/show_bug.cgi?id=160559
1360
1361         Reviewed by Michael Catanzaro.
1362
1363         * Scripts/webkitpy/port/driver.py:
1364         (Driver.run_test):
1365         (Driver._read_first_block):
1366         (Driver._read_optional_image_block):
1367         (Driver._read_block):
1368         * Scripts/webkitpy/port/driver_unittest.py:
1369         (DriverTest.test_read_block):
1370         (DriverTest.test_read_binary_block):
1371         (DriverTest.test_read_base64_block):
1372
1373 2016-08-05  Commit Queue  <commit-queue@webkit.org>
1374
1375         Unreviewed, rolling out r204123.
1376         https://bugs.webkit.org/show_bug.cgi?id=160597
1377
1378         Caused layout test timeouts on Windows. (Requested by perarne
1379         on #webkit).
1380
1381         Reverted changeset:
1382
1383         "[Win] Unable to reliably run tests in parallel"
1384         https://bugs.webkit.org/show_bug.cgi?id=140914
1385         http://trac.webkit.org/changeset/204123
1386
1387 2016-08-04  Saam Barati  <sbarati@apple.com>
1388
1389         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1390         https://bugs.webkit.org/show_bug.cgi?id=151241
1391
1392         Reviewed by Benjamin Poulain.
1393
1394         * Scripts/run-jsc-stress-tests:
1395
1396 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1397
1398         UI improvements to Flakiness Dashboard.
1399         https://bugs.webkit.org/show_bug.cgi?id=153295
1400
1401         Reviewed by Alexey Proskuryakov.
1402
1403         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1404         (td.options-container): Center text in most fields.
1405         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1406         (createBugHTML): Text/Grammar updates.
1407         (tableHeaders): Ditto.
1408         (htmlForSingleTestRow): Ditto.
1409         (headerForTestTableHtml): Ditto.
1410         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1411         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1412
1413 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1414
1415         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1416         https://bugs.webkit.org/show_bug.cgi?id=160518
1417
1418         Reviewed by Michael Catanzaro.
1419
1420         * Scripts/webkitpy/thirdparty/__init__.py:
1421         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1422         * gtk/install-dependencies:
1423
1424 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1425
1426         Optimize bot watcher's dashboard a little
1427         https://bugs.webkit.org/show_bug.cgi?id=160515
1428         rdar://problem/26096900
1429
1430         Reviewed by Lucas Forschler.
1431
1432         Made re-sorting after loading an iteration more efficient.
1433
1434         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1435         (BuildbotIteration.prototype._updateWithData):
1436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1437         (BuildbotQueue.prototype.updateIterationPosition):
1438
1439 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1440
1441         [Win] Unable to reliably run tests in parallel
1442         https://bugs.webkit.org/show_bug.cgi?id=140914
1443
1444         Reviewed by Brent Fulgham.
1445
1446         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1447         processes. We can use string replacement to convert the Cygwin path to a Windows path
1448         instead.
1449  
1450         * Scripts/webkitpy/common/system/path.py:
1451         (cygpathFast):
1452         * Scripts/webkitpy/port/driver.py:
1453         (Driver._command_from_driver_input):
1454
1455 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1456
1457         Document instructions for increasing process and file limits
1458         https://bugs.webkit.org/show_bug.cgi?id=160528
1459         rdar://problem/24777576
1460
1461         Reviewed by Alexey Proskuryakov.
1462
1463         * Scripts/webkitpy/port/ios.py:
1464         (IOSSimulatorPort.default_child_processes):
1465
1466 2016-08-03  Anders Carlsson  <andersca@apple.com>
1467
1468         Remove the Objective-C bindings generator
1469         https://bugs.webkit.org/show_bug.cgi?id=160526
1470
1471         Reviewed by Sam Weinig.
1472
1473         * Scripts/run-bindings-tests:
1474         Update test.
1475
1476 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1477
1478         Revise a TestWebKitAPI comment to mention the actual underlying problem
1479
1480         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1481         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1482
1483 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1484
1485         Benchmark test content-animation timeouts always
1486         https://bugs.webkit.org/show_bug.cgi?id=160057
1487
1488         Reviewed by Simon Fraser.
1489
1490         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1491         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1492         (start):
1493
1494 2016-08-02  Nan Wang  <n_wang@apple.com>
1495
1496         AX: Simulated touch events are not working on iOS
1497         https://bugs.webkit.org/show_bug.cgi?id=160395
1498         <rdar://problem/27633597>
1499
1500         Reviewed by Chris Fleizach.
1501
1502         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1503         (WTR::AccessibilityUIElement::press):
1504         (WTR::AccessibilityUIElement::setSelectedChild):
1505
1506 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1507
1508         run-javascriptcore-tests should accept multiple --extra-tests
1509         https://bugs.webkit.org/show_bug.cgi?id=160486
1510
1511         Reviewed by Saam Barati.
1512         
1513         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1514         test suites. This does it by using GetOpt::Long's array support.
1515
1516         * Scripts/run-javascriptcore-tests:
1517         (runJSCStressTests):
1518
1519 2016-08-02  Enrica Casucci  <enrica@apple.com>
1520
1521         Allow building with content filtering disabled.
1522         https://bugs.webkit.org/show_bug.cgi?id=160454
1523
1524         Reviewed by Simon Fraser.
1525
1526         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1527
1528 2016-08-02  Brady Eidson  <beidson@apple.com>
1529
1530         Removing IndexedDB WebsiteData can fail for some users.
1531         https://bugs.webkit.org/show_bug.cgi?id=160463
1532
1533         Reviewed by Alex Christensen.
1534
1535         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1536
1537 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1538
1539         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1540         https://bugs.webkit.org/show_bug.cgi?id=160437
1541         <rdar://problem/27578272>
1542
1543         Reviewed by Brady Eidson.
1544
1545         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1546         (-[DownloadDelegate _download:didReceiveResponse:]):
1547         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1548         (runTest):
1549         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1550
1551 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1552
1553         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1554         https://bugs.webkit.org/show_bug.cgi?id=160414
1555
1556         Reviewed by Michael Catanzaro.
1557
1558         * Scripts/webkitpy/port/linux_get_crash_log.py:
1559         (GDBCrashLogGenerator._wait_for_corefile):
1560
1561 2016-08-01  Youenn Fablet  <youenn@apple.com>
1562
1563         Make wpt server generate its certificates in layout test results folder
1564         https://bugs.webkit.org/show_bug.cgi?id=160422
1565
1566         Reviewed by Chris Dumez.
1567
1568         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1569         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1570
1571 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1572
1573         Function Call on NULL Object
1574         https://bugs.webkit.org/show_bug.cgi?id=160325
1575
1576         Reviewed by Darin Adler.
1577
1578         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1579         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1580         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1581
1582 2016-08-01  Keith Miller  <keith_miller@apple.com>
1583
1584         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1585         https://bugs.webkit.org/show_bug.cgi?id=160372
1586
1587         Rubber stamped by Geoffrey Garen.
1588
1589         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1590         a new top level directory, JSTests. Having the tests in the Source directory
1591         was both confusing an inconvenient for people that just want to checkout the
1592         source code of WebKit. Since there is no other obvious place to put all the
1593         JavaScript tests a new top level directory seemed the most sensible.
1594
1595         * Scripts/import-test262-tests:
1596         * Scripts/run-javascriptcore-tests:
1597         * Scripts/update-javascriptcore-test-res:
1598
1599 2016-07-31  Nan Wang  <n_wang@apple.com>
1600
1601         AX: Add a check for touch event listener on iOS accessibility object
1602         https://bugs.webkit.org/show_bug.cgi?id=160388
1603
1604         Reviewed by Chris Fleizach.
1605
1606         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1607         (AccessibilityUIElement::boolAttributeValue):
1608         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1609         (WTR::AccessibilityUIElement::boolAttributeValue):
1610
1611 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1612
1613         Unreviewed: add myself to the reviewers list.
1614
1615         * Scripts/webkitpy/common/config/contributors.json:
1616
1617 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1618
1619         Undo r203939, and copy over a rule that clips the logos.
1620
1621         Sierra wasn't the only logo without transparency.
1622
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1624         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1625         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1626
1627 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1628
1629         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1630         https://bugs.webkit.org/show_bug.cgi?id=160377
1631
1632         Reviewed by Brian Weinstein.
1633
1634         Update assets to remove the white background and use a transparent background instead.
1635
1636         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1638
1639 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1640
1641         Ignore most check-webkit-style checks for ANGLE project
1642         <https://webkit.org/b/160333>
1643
1644         Reviewed by Daniel Bates.
1645
1646         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1647         - No tabs.
1648         - No spaces at the end of lines.
1649         - No carriage returns (DOS line endings).
1650
1651 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1652
1653         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1654         https://bugs.webkit.org/show_bug.cgi?id=160360
1655         <rdar://problem/27179484>
1656
1657         Reviewed by Myles C. Maxfield.
1658
1659         Adds two tests verifying that videos may be considered main content as long as they
1660         are large enough and cover a majority of the mainframe's viewport.
1661
1662         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1663         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1664         (TestWebKitAPI::TEST):
1665         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1666         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1667
1668 2016-07-29  Mark Lam  <mark.lam@apple.com>
1669
1670         Gardening: removed unused variable.
1671
1672         Not reviewed.
1673
1674         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1675         (TestWebKitAPI::TEST):
1676
1677 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1678
1679         Add TestWebKitAPI support for interacting with media controls
1680         https://bugs.webkit.org/show_bug.cgi?id=160342
1681         <rdar://problem/27610246>
1682
1683         Reviewed by Beth Dakin.
1684
1685         Adds support for testing interaction with some media controls, as well as a basic test
1686         verifying that media control teardown after interaction does not result in a crash.
1687
1688         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1689         (-[WKWebView mouseDownAtPoint:]):
1690         (-[WKWebView performAfterLoading:]):
1691         (TestWebKitAPI::TEST):
1692
1693 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1694
1695         Crash Log Clobbering on Unbound Crashes
1696         https://bugs.webkit.org/show_bug.cgi?id=160198
1697         <rdar://problem/27472618>
1698
1699         Reviewed by Alexey Proskuryakov.
1700
1701         * Scripts/webkitpy/common/system/crashlogs.py:
1702         (CrashLogs): Fix header order.
1703         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1704         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1705
1706 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1707
1708         Update for contributors.json
1709         https://bugs.webkit.org/show_bug.cgi?id=160294
1710
1711         * Scripts/webkitpy/common/config/contributors.json:
1712
1713 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1714
1715         Remove deprecated SPI for video inline / fullscreen controls
1716         https://bugs.webkit.org/show_bug.cgi?id=160318
1717
1718         Reviewed by Tim Horton.
1719
1720         * DumpRenderTree/mac/DumpRenderTree.mm:
1721         (setDefaultsToConsistentValuesForTesting): Deleted.
1722         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1723         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1724         * WebKitTestRunner/TestController.cpp:
1725         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1726         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1727         (WTR::initializeWebViewConfiguration): Deleted.
1728
1729 2016-07-28  Daniel Bates  <dabates@apple.com>
1730
1731         [iOS] TestWebKitAPI bundle targets are not code signed
1732         https://bugs.webkit.org/show_bug.cgi?id=160328
1733         <rdar://problem/27409246>
1734
1735         Reviewed by Andy Estes.
1736
1737         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1738         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1739         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1740
1741         * TestWebKitAPI/Configurations/Base.xcconfig:
1742
1743 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1744
1745         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1746
1747         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1748         (animatedResizeWebView):
1749         (TEST):
1750         This test times out only when run in the WebKit Testing simulator environment,
1751         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1752
1753 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1754
1755         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1756         https://bugs.webkit.org/show_bug.cgi?id=160289
1757         <rdar://problem/27553464>
1758
1759         Reviewed by Simon Fraser.
1760
1761         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1762         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1763         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1764         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1765         (-[AnimatedResizeWebView _endAnimatedResize]):
1766         (animatedResizeWebView):
1767         (TEST):
1768         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1769         Add two tests that ensure that hidden-content and animated resizes
1770         don't cause unnecessary synchronous waits. Only the hidden-content
1771         one fails before my patch, but it seemed reasonable to add both anyway.
1772
1773 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1774
1775         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1776         <https://webkit.org/b/83342>
1777
1778         Reviewed by Ryosuke Niwa.
1779
1780         * Scripts/webkitpy/common/checkout/scm/git.py:
1781         (Git.revisions_changing_file): Remove code to raise an exception
1782         when the file doesn't exist.  If a file was moved or renamed,
1783         then this caused the script to terminate, which was very
1784         frustrating when you wanted a list of reviewers.
1785         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1786         (SCMTest._shared_test_revisions_changing_file): Update test
1787         expectation to return an empty list of revisions.
1788         (test_create_patch_is_full_patch): Drive-by fix when running all
1789         webkitpy tests (including scm tests).
1790         * Scripts/webkitpy/common/checkout/scm/svn.py:
1791         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1792         return an empty array of revisions if this occurs.
1793
1794 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1795
1796         EWS error message "Error: * did not process patch" should include explanation
1797         https://bugs.webkit.org/show_bug.cgi?id=159903
1798         <rdar://problem/27410788>
1799
1800         Reviewed by Alexey Proskuryakov.
1801
1802         * QueueStatusServer/handlers/statusbubble.py:
1803         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1804         is not processed.
1805         * QueueStatusServer/handlers/processingtimesjson.py:
1806         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1807         of the code.
1808         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1809         (CommitQueueTask.validate): Add more information about validation failure.
1810         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1811         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1812         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1813         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1814         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1815         (PatchIsNotValid.__init__): Add the failure_message argument.
1816         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1817         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1818         failure details.
1819         * Scripts/webkitpy/tool/commands/queues.py:
1820         (CommitQueue.process_work_item): Same.
1821         (StyleQueue.review_patch): Same.
1822         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1823         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1824
1825 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1826
1827         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1828         https://bugs.webkit.org/show_bug.cgi?id=160262
1829
1830         Reviewed by Daniel Bates.
1831
1832         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1833         (-[LTRelayController installApp]):
1834
1835 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1836
1837         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1838         https://bugs.webkit.org/show_bug.cgi?id=160225
1839
1840         Reviewed by Alexey Proskuryakov.
1841
1842         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1843
1844 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1845
1846         [GTK] Fix some video/canvas tests that should be passing
1847         https://bugs.webkit.org/show_bug.cgi?id=160023
1848
1849         Reviewed by Carlos Garcia Campos.
1850
1851         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1852         EFL or GTK platforms.
1853
1854         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1855         (WTR::TestController::platformConfigureViewForTest):
1856         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1857         (WTR::TestController::platformConfigureViewForTest):
1858
1859 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1860
1861         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1862         https://bugs.webkit.org/show_bug.cgi?id=160247
1863
1864         Reviewed by Michael Catanzaro.
1865
1866         * BuildSlaveSupport/built-product-archive:
1867         (createZip):
1868         (dirContainsdwo):
1869         (archiveBuiltProduct):
1870
1871 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1872
1873         Fix tests after r203743.
1874         https://bugs.webkit.org/show_bug.cgi?id=156947
1875
1876         * WebKitTestRunner/TestController.cpp:
1877         (WTR::TestController::resetStateToConsistentValues):
1878         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1879
1880 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1881
1882         [iPhone] Playing a video on tudou.com plays only sound, no video
1883         https://bugs.webkit.org/show_bug.cgi?id=160178
1884         <rdar://problem/27535468>
1885
1886         Reviewed by Dan Bernstein.
1887
1888         * DumpRenderTree/mac/DumpRenderTree.mm:
1889         (setDefaultsToConsistentValuesForTesting):
1890         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1891         (RequiresUserActionForPlaybackTest::SetUp):
1892         * WebKitTestRunner/TestController.cpp:
1893         (WTR::TestController::resetPreferencesToConsistentValues):
1894         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1895         (WTR::initializeWebViewConfiguration):
1896
1897 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1898
1899         Allow LOG macros to be used outside the namespace, and other logging cleanup
1900         https://bugs.webkit.org/show_bug.cgi?id=160216
1901
1902         Reviewed by Anders Carlsson.
1903         
1904         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1905
1906         * DumpRenderTree/TestRunner.cpp:
1907         * DumpRenderTree/mac/DumpRenderTree.mm:
1908         (resetWebViewToConsistentStateBeforeTesting):
1909
1910 2016-07-26  David Kilzer <ddkilzer@apple.com>
1911
1912         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1913         https://bugs.webkit.org/show_bug.cgi?id=156947
1914         <rdar://problem/23325160>
1915
1916         Reviewed by Alex Christensen.
1917
1918         * DumpRenderTree/TestRunner.cpp:
1919         (TestRunner::TestRunner):
1920         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1921         * DumpRenderTree/TestRunner.h:
1922         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1923         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1924         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1925         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1926         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1927         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1928         (WTR::TestRunner::queueNonLoadingScript):
1929         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1930         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1931         * WebKitTestRunner/TestController.cpp:
1932         (WTR::TestController::didReceiveAuthenticationChallenge):
1933         * WebKitTestRunner/TestController.h:
1934         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1935         * WebKitTestRunner/TestInvocation.cpp:
1936         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1937         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1938
1939 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1940
1941         check-for-exit-time-destructors should be usable outside Xcode
1942         <https://webkit.org/b/160195>
1943
1944         Reviewed by Darin Adler.
1945
1946         * Scripts/check-for-exit-time-destructors: Update to parse
1947         -h|--help switch, or to take one argument to a binary to check
1948         for exit time destructors on the command-line.  The clang
1949         compiler will find these at compile-time with the
1950         -Wexit-time-destructors switch, but this script will check for
1951         them after-the-fact.
1952
1953 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1954
1955         Test svn.webkit.org functionality after maintenance.
1956
1957 2016-07-25  Brady Eidson  <beidson@apple.com>
1958
1959         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1960         https://bugs.webkit.org/show_bug.cgi?id=153783
1961
1962         Reviewed by Alex Christensen.
1963
1964         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
1965         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1966         
1967         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1968         
1969         Change the relevant API tests to make sure this continues to be no longer required.
1970
1971         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1972         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1973         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1974         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1975         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1976         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1977
1978 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1979
1980         Media controls should not be displayed for a video until it starts playing
1981         https://bugs.webkit.org/show_bug.cgi?id=160092
1982         <rdar://problem/26986673>
1983
1984         Reviewed by Beth Dakin.
1985
1986         Verify that multiple videos do or don't show the media controller depending on whether videos
1987         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1988         passing because we were always showing media controls for large videos with audio, even if they
1989         had not played back yet. This change ensures that large videos with audio show media controls
1990         only after they begin to play back, and not by virtue of being large enough for main content.
1991
1992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1993         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1994         (TestWebKitAPI::TEST):
1995         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1996         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1997         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1998
1999 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2000
2001         Media controls on apple.com don't disappear when movie finishes playing
2002         https://bugs.webkit.org/show_bug.cgi?id=160068
2003         <rdar://problem/26668526>
2004
2005         Reviewed by Darin Adler.
2006
2007         Adds new API tests. Please see WebCore ChangeLog for more details.
2008
2009         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2010         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2011         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
2012         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2013         (TestWebKitAPI::TEST):
2014         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
2015         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2016         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
2017         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
2018         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
2019
2020 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2021
2022         Unreviewed, fix test-webkitpy after r203674.
2023
2024         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2025         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2026
2027 2016-07-24  Philippe Normand  <pnormand@igalia.com>
2028
2029         Unreviewed, forgot to commit this file in r203674.
2030
2031         * Scripts/process-linux-coredump: Added.
2032         (main):
2033
2034 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2035
2036         Improve GDB backtrace generation for GTK/EFL
2037         https://bugs.webkit.org/show_bug.cgi?id=128928
2038
2039         Reviewed by Carlos Garcia Campos.
2040
2041         The PID of the crashed process is now correctly supplied to the
2042         crash log reporter. The kernel core_pattern needs to be updated
2043         after this change to something like:
2044
2045         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
2046
2047         * Scripts/process-linux-coredump: Added.
2048         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
2049         * Scripts/webkitpy/port/efl.py:
2050         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
2051         * Scripts/webkitpy/port/gtk.py:
2052         (GtkPort._get_crash_log): Ditto.
2053         * Scripts/webkitpy/port/linux_get_crash_log.py:
2054         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
2055         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
2056         (GDBCrashLogGenerator): Deleted.
2057         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2058         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
2059         * WebKitTestRunner/TestController.cpp:
2060         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
2061         (WTR::TestController::databaseProcessDidCrash): Ditto.
2062         (WTR::TestController::processDidCrash): Ditto.
2063
2064 2016-07-23  Youenn Fablet  <youenn@apple.com>
2065
2066         WPT stash server should be kept running when launching wpt server
2067         https://bugs.webkit.org/show_bug.cgi?id=160052
2068
2069         Reviewed by Sam Weinig.
2070
2071         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2072         (main): waiting to read stdin while stash server is started.
2073
2074 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2075
2076         Media controls should be displayed for media in media documents
2077         https://bugs.webkit.org/show_bug.cgi?id=160104
2078         <rdar://problem/27438936>
2079
2080         Reviewed by Myles C. Maxfield.
2081
2082         Verifies that even a small video with audio in a media document gets media controls.
2083
2084         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2085         (TestWebKitAPI::TEST):
2086
2087 2016-07-22  Michael Saboff  <msaboff@apple.com>
2088
2089         REGRESSION(203616): no FTL testing was inadvertently removed
2090         https://bugs.webkit.org/show_bug.cgi?id=160100
2091
2092         Rubber-stamped by Filip Pizlo.
2093
2094         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
2095         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
2096         logic for the runLayout and runNoisy variants to match the run test logic,
2097         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
2098         enabled platforms.
2099
2100         * Scripts/run-jsc-stress-tests:
2101
2102 2016-07-22  Brady Eidson  <beidson@apple.com>
2103
2104         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
2105         https://bugs.webkit.org/show_bug.cgi?id=160089
2106
2107         Reviewed by Darin Adler.
2108
2109         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2110         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
2111         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
2112
2113 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
2114
2115         [GTK] Improved exclusion patterns in make-dist.py manifest.
2116         https://bugs.webkit.org/show_bug.cgi?id=160094
2117
2118         Reviewed by Michael Catanzaro.
2119
2120         * gtk/manifest.txt.in:
2121         Exclude Platform*.cmake files for more ports.
2122         Removed obsolete .gyp and .pro.user patterns.
2123         Exclude 'Configurations' and 'spi' directories.
2124         Exclude CMakeLists.txt.user (Qt Creator IDE).
2125
2126 2016-07-22  Michael Saboff  <msaboff@apple.com>
2127
2128         Don't run FTL related JSC stress tests on non-FTL platforms
2129         https://bugs.webkit.org/show_bug.cgi?id=160033
2130
2131         Reviewed by Mark Lam.
2132
2133         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
2134         Refactored several of the runXXX test methods to always runXXXDefault and made those
2135         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
2136         doesn't cause a problem.
2137
2138         * Scripts/run-jsc-stress-tests:
2139
2140 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
2141
2142         IWebView::mainFrame crashes if called after IWebView::close
2143         https://bugs.webkit.org/show_bug.cgi?id=32868
2144
2145         Reviewed by Brent Fulgham.
2146
2147         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2148         (TestWebKitAPI::TEST_F): Added test.
2149
2150 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2151
2152         [GTK] Enable threaded compositor by default
2153         https://bugs.webkit.org/show_bug.cgi?id=160079
2154
2155         Reviewed by Žan Doberšek.
2156
2157         * Scripts/webkitperl/FeatureList.pm:
2158
2159 2016-07-22  Youenn Fablet  <youenn@apple.com>
2160
2161         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
2162         https://bugs.webkit.org/show_bug.cgi?id=159921
2163
2164         Reviewed by Brian Burg.
2165
2166         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
2167
2168         * Scripts/webkitpy/codegen/main.py:
2169         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
2170         (BuiltinsGeneratorTests):
2171         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
2172         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
2173         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
2174         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
2175
2176 2016-07-21  Dan Bernstein  <mitz@apple.com>
2177
2178         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
2179         https://bugs.webkit.org/show_bug.cgi?id=160072
2180
2181         Reviewed by Andy Estes.
2182
2183         * Scripts/webkitdirs.pm:
2184         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
2185           for old Xcode versions.
2186         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
2187           to readXcodeUserDefault.
2188         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
2189           debugger.
2190         (determineDebugger): Ditto.
2191         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
2192           7.0.
2193         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
2194           switches.
2195         (execMacWebKitAppForDebugging): Removed support for GDB.
2196
2197 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2198
2199         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2200         https://bugs.webkit.org/show_bug.cgi?id=160066
2201
2202         Reviewed by Dean Jackson.
2203
2204         * DumpRenderTree/mac/DumpRenderTree.mm:
2205         (setDefaultsToConsistentValuesForTesting): Deleted.
2206         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2207         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2208         * WebKitTestRunner/TestController.cpp:
2209         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2210         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2211         (WTR::initializeWebViewConfiguration): Deleted.
2212
2213 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
2214
2215         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2216         https://bugs.webkit.org/show_bug.cgi?id=159980
2217         rdar://problem/27450825
2218
2219         Reviewed by Dan Bernstein.
2220
2221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2222         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2223         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2224         when our delegate has hit -dealloc.
2225         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
2226         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
2227         will not be messaged.
2228
2229 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2230
2231         Follow-up patch to r203520
2232         https://bugs.webkit.org/show_bug.cgi?id=159967
2233         <rdar://problem/26964090>
2234
2235         Unreviewed.
2236
2237         * DumpRenderTree/mac/DumpRenderTree.mm:
2238         (setDefaultsToConsistentValuesForTesting):
2239         * WebKitTestRunner/TestController.cpp:
2240         (WTR::TestController::resetPreferencesToConsistentValues):
2241
2242 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2243
2244         [iPhone] Playing a video on tudou.com plays only sound, no video
2245         https://bugs.webkit.org/show_bug.cgi?id=159967
2246         <rdar://problem/26964090>
2247
2248         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2249
2250         Migrate tests to use new SPI.
2251
2252         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2253         (RequiresUserActionForPlaybackTest::SetUp):
2254         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2255         (WTR::initializeWebViewConfiguration):
2256
2257 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
2258
2259         Clarify testing mode names in run-jsc-stress-tests
2260         https://bugs.webkit.org/show_bug.cgi?id=160021
2261
2262         Reviewed by Mark Lam.
2263
2264         Default should mean really default, not default with disabled FTL, renamed
2265         - runMozillaTestDefault to runMozillaTestNoFTL
2266         - runMozillaTestDefaultFTL to runMozillaTestDefault
2267         - runDefault to runNoFTL
2268         - runDefaultFTL to runDefault
2269         - runLayoutTestDefault to runLayoutTestNoFTL
2270         - runLayoutTestDefaultFTL to runLayoutTestDefault
2271         - runNoisyTestDefault to runNoisyTestNoFTL
2272         - runNoisyTestDefaultFTL to runNoisyTestDefault
2273
2274         * Scripts/run-jsc-stress-tests:
2275
2276 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
2277
2278         WebBackForwardList's currentIndex could get out of bounds when filtering items.
2279         https://bugs.webkit.org/show_bug.cgi?id=159986
2280
2281         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
2282         to 0.
2283
2284         Reviewed by Dan Bernstein.
2285
2286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2287         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
2288         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
2289         (TEST):
2290
2291 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2292
2293         [GTK] Web view background colors don't work in accelerated compositing mode
2294         https://bugs.webkit.org/show_bug.cgi?id=159455
2295
2296         Reviewed by Michael Catanzaro.
2297
2298         Set always RGBA visual to the view widget when setting a background color.
2299
2300         * MiniBrowser/gtk/BrowserWindow.c:
2301         (browser_window_set_background_color):
2302
2303 2016-07-20  Youenn Fablet  <youenn@apple.com>
2304
2305         Bots should run built-ins generator tests
2306         https://bugs.webkit.org/show_bug.cgi?id=159971
2307
2308         Reviewed by Alexey Proskuryakov.
2309
2310         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2311         (RunBuiltinsTests): New step to run built-in generator tests.
2312         (TestFactory.__init__): Adding an additional step for bultin generator tests.
2313         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
2314         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
2315
2316 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2317
2318         Revert temporary fix r203417
2319         https://bugs.webkit.org/show_bug.cgi?id=160001
2320
2321         Reviewed by Alexey Proskuryakov.
2322
2323         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
2324
2325 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2326
2327         REGRESSION(r148588): ews classes might get garbage collected
2328         https://bugs.webkit.org/show_bug.cgi?id=159990
2329
2330         Reviewed by Ryosuke Niwa.
2331
2332         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
2333         in a variable so that they do not get garbage collected.
2334
2335 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
2336
2337         Add API test for layout constraints after exit fullscreen
2338         https://bugs.webkit.org/show_bug.cgi?id=159900
2339
2340         Reviewed by Jon Lee.
2341
2342         Added Fullscreen.LaytoutConstraints API test. 
2343         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
2344
2345         This test compares layout constraints on the web view before and after fullscreen to make sure 
2346         they are preserved.
2347
2348         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
2349         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
2350         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2351         (TestWebKitAPI::TEST):
2352
2353 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
2354
2355         Disable two failing API tests.
2356
2357         Unreviewed test gardening.
2358
2359         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2360         (TestWebKitAPI::TEST):
2361
2362 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2363
2364         Unreviewed iOS build fix.
2365
2366         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
2367
2368 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2369
2370         Media controls don't appear when pausing a small autoplaying video
2371         https://bugs.webkit.org/show_bug.cgi?id=159972
2372         <rdar://problem/27180657>
2373
2374         Reviewed by Beth Dakin.
2375
2376         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
2377         for simulating basic user interaction in VideoControlsManager.
2378
2379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2380         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2381         (-[WKWebView mouseDownAtPoint:]):
2382         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2383         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2384         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2385         (TestWebKitAPI::TEST):
2386         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2387
2388 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2389
2390         [Win] MathML fonts are not found.
2391         https://bugs.webkit.org/show_bug.cgi?id=159920
2392
2393         Reviewed by Alex Christensen.
2394
2395         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2396         for a specific registry key value.
2397
2398         * Scripts/webkitdirs.pm:
2399         (fontExists):
2400
2401 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2402
2403         Improve prepare-ChangeLog for @media blocks
2404         https://bugs.webkit.org/show_bug.cgi?id=159907
2405
2406         Reviewed by Timothy Hatcher.
2407
2408         * Scripts/prepare-ChangeLog:
2409         (get_selector_line_ranges_for_css):
2410         Get a range for @media blocks just like a selector.
2411             Start Line = line with '{'
2412             End line = line with '}'
2413             Name = "@media ..."
2414
2415         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2416         Improved error messages for unbalanced portions.
2417
2418         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2419         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2420         (.media-query::before):
2421         (@media only screen and (max-width: 980px)):
2422         (.media-query a):
2423         (@media (-webkit-min-device-pixel-ratio: 2)):
2424         (.both a):
2425         (.both b):
2426         (.media-query b):
2427         (.media-query::after):
2428
2429 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2430
2431         Fix expectedFailErrorHandler in run-jsc-stress-tests
2432         https://bugs.webkit.org/show_bug.cgi?id=159811
2433
2434         Reviewed by Yusuke Suzuki.
2435
2436         * Scripts/run-jsc-stress-tests:
2437
2438 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2439
2440         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2441
2442         * TestWebKitAPI/PlatformMac.cmake:
2443
2444 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2445
2446         The default testing mode should not involve disabling the FTL JIT
2447         https://bugs.webkit.org/show_bug.cgi?id=159929
2448
2449         Rubber stamped by Mark Lam and Saam Barati.
2450         
2451         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2452         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2453         FTL was not the default. You had to enable it with an option.
2454         
2455         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2456         all of the major ports. This has become a serious pain. For example, it's useful to be able
2457         to say that a test should only run in the default config that is representative of what a
2458         normal user would see if they ran JSC. Clearly, this would be a config that does not
2459         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2460         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2461         
2462         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2463         try to fix it, because:
2464         
2465         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2466           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2467           doesn't do anything. The code is not really structured to allow this.
2468         
2469         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2470           disabled in testing. On the other hand there are already build bots that do FTL tests
2471           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2472           preserving this broken feature, we should create something that (a) acknowledges the fact
2473           that the FTL is the default on those platforms that support it and (b) avoids running
2474           no-ftl tests on precisely those platforms that don't have FTL.
2475         
2476         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2477           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2478           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2479           pretending that the FTL JIT is not the default just because some bots used that as an
2480           optimization.
2481         
2482         This change allows me to speed up some debug tests and paint some bots green.
2483
2484         * Scripts/run-javascriptcore-tests:
2485         (runJSCStressTests):
2486         * Scripts/run-jsc-stress-tests:
2487
2488 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2489
2490         Fix API test after r203426.
2491         https://bugs.webkit.org/show_bug.cgi?id=159949
2492
2493         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2494         (TEST):
2495         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2496         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2497
2498 2016-07-19  Andy Estes  <aestes@apple.com>
2499
2500         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2501         https://bugs.webkit.org/show_bug.cgi?id=159956
2502
2503         Reviewed by Dan Bernstein.
2504
2505         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2506         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2507         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2508         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2509
2510 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2511
2512         Add regression test for r203392
2513         https://bugs.webkit.org/show_bug.cgi?id=159949
2514
2515         Reviewed by Brady Eidson.
2516
2517         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2518         (fileSize):
2519         (swizzledBundleIdentifierWebBookmarksD):
2520         (defaultApplicationCacheDirectory):
2521         (TEST):
2522         (swizzledBundleIdentifierMobileSafari): Deleted.
2523         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2524         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2525         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2526
2527 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2528
2529         Add regression test for r203392
2530         https://bugs.webkit.org/show_bug.cgi?id=159949
2531
2532         Reviewed by Brady Eidson.
2533
2534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2535         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2536         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2537         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2538         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2539         (TEST):
2540         (fileSize):
2541         (swizzledBundleIdentifierMobileSafari):
2542         (swizzledBundleIdentifierWebBookmarksD):
2543         (defaultApplicationCacheDirectory):
2544         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2545         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2546         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2547         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2548
2549 2016-07-19  Keith Miller  <keith_miller@apple.com>
2550
2551         Test262 should have a file with the revision and url
2552         https://bugs.webkit.org/show_bug.cgi?id=159937
2553
2554         Reviewed by Mark Lam.
2555
2556         The import script should update the information from
2557         the path to the test262 repository it gets.
2558
2559         * Scripts/import-test262-tests:
2560
2561 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2562
2563         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2564         To be deleted once the root cause is found and addressed.
2565
2566         * EWSTools/start-queue-mac.sh:
2567
2568 2016-07-19  Frederic Wang  <fwang@igalia.com>
2569
2570         [win] Fixup the register name for STIX Math and Latin Modern Math
2571
2572         Unreviewed follow-up of r203406
2573
2574         * Scripts/webkitdirs.pm:
2575         (checkInstalledTools):
2576
2577 2016-07-19  Frederic Wang  <fwang@igalia.com>
2578
2579         [win] Update the list of MathML fonts
2580         https://bugs.webkit.org/show_bug.cgi?id=156838
2581
2582         The set of recommended math fonts is now described at
2583         https://trac.webkit.org/wiki/MathML/Fonts
2584         We update the Perl script to use the latest list of fonts.
2585
2586         Reviewed by Brent Fulgham.
2587
2588         * Scripts/webkitdirs.pm:
2589         (checkInstalledTools):
2590
2591 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2592
2593         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2594         https://bugs.webkit.org/show_bug.cgi?id=159342
2595
2596         Reviewed by Darin Adler.
2597
2598         Implement required functions in event sender.
2599
2600         * DumpRenderTree/PlatformWin.cmake:
2601         * DumpRenderTree/win/EventSender.cpp:
2602         (monitorWheelEvents): Added.
2603         (callAfterScrollingCompletes): Added.
2604
2605 2016-07-19  Youenn Fablet  <youenn@apple.com>
2606
2607         Add new aliases to http test server
2608         https://bugs.webkit.org/show_bug.cgi?id=159878
2609
2610         Reviewed by Darin Adler.
2611
2612         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2613         Adding explicitly these links to perl script.
2614         Extracting default alias in an aliases.json file.
2615         Reading that file from python scripts to initialize aliases from that file.
2616
2617         Python script changes covered by unit tests and changed layout test.
2618
2619         * Scripts/webkitperl/httpd.pm:
2620         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2621         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2622         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2623         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2624         Adding -c directives for each alias.
2625         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2626         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2627         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2628         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2629         Adding alias directive for each alias.
2630         (Lighttpd._prepare_config):
2631         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2632         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2633         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2634         layout tests directory.
2635         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2636         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2637         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2638
2639 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2640
2641         EWS console logs doesn't go to log file
2642         https://bugs.webkit.org/show_bug.cgi?id=159539
2643         <rdar://problem/24464570>
2644
2645         Reviewed by David Kilzer.
2646
2647         * Scripts/webkitpy/common/system/logutils.py:
2648         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2649         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2650         to filesystem. It also supports passing MockFilesystem.
2651         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2652         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2653         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2654         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2655         (_test_ews): Same.
2656         * Scripts/webkitpy/tool/commands/queues.py:
2657         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2658         (AbstractQueue._log_directory): Using filesystem object instead of os.
2659         (AbstractQueue.queue_log_path): Same.
2660         (AbstractQueue.__init__): Passed host parameter.
2661         (PatchProcessingQueue.__init__): Same.
2662         (CommitQueue.__init__): Same.
2663         (AbstractReviewQueue.__init__): Same.
2664         (StyleQueue.__init__): Same.
2665         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2666         (TestCommitQueue): Passed MockHost() as host.
2667         (TestCommitQueue.__init__): Same.
2668         (TestQueue.__init__): Same.
2669         (TestReviewQueue.__init__): Same.
2670         (TestFeederQueue.__init__): Same.
2671         (AbstractPatchQueueTest.test_next_patch): Same.
2672         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2673         (test_commit_queue_failure): Same.
2674         (MockCommitQueueTask.results_from_patch_test_run): Same.
2675         (test_rollout_lands): Same.
2676         (test_non_valid_patch): Same.
2677         (test_auto_retry): Same.
2678         (test_style_queue_with_watch_list_exception): Same.
2679
2680 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2681
2682         WTF::Lock should be fair eventually
2683         https://bugs.webkit.org/show_bug.cgi?id=159384
2684
2685         Reviewed by Geoffrey Garen.
2686
2687         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2688
2689 2016-07-17  Sam Weinig  <sam@webkit.org>
2690
2691         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2692         <rdar://problem/26554137>
2693         https://bugs.webkit.org/show_bug.cgi?id=159856
2694
2695         Reviewed by Dan Bernstein.
2696
2697         * MiniBrowser/mac/WK2BrowserWindowController.m:
2698         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2699         Add basic window.open implementation.
2700
2701         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2702         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2703         to open a single non-web URL, all others are dropped.
2704
2705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2706         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2707         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2708         Add API for the new SPI.
2709
2710 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2711
2712         [JSC] Enable test262 module tests
2713         https://bugs.webkit.org/show_bug.cgi?id=159854
2714
2715         Reviewed by Saam Barati.
2716
2717         Use --module-file instead.
2718
2719         * Scripts/run-jsc-stress-tests:
2720
2721 2016-07-16  Chris Dumez  <cdumez@apple.com>
2722
2723         Unreviewed, rolling out r203318.
2724
2725         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2726         SunSpider)
2727
2728         Reverted changeset:
2729
2730         "[JSC] Change some parameters based on a random search"
2731         https://bugs.webkit.org/show_bug.cgi?id=158514
2732         http://trac.webkit.org/changeset/203318
2733
2734 2016-07-16  Chris Dumez  <cdumez@apple.com>
2735
2736         Add move constructor / assignment operator to ListHashSet
2737         https://bugs.webkit.org/show_bug.cgi?id=159837
2738
2739         Reviewed by Darin Adler.
2740
2741         Add API tests.
2742
2743         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2744         (TestWebKitAPI::TEST):
2745
2746 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2747
2748         [JSC] Change some parameters based on a random search
2749         https://bugs.webkit.org/show_bug.cgi?id=158514
2750
2751         Reviewed by Saam Barati.
2752
2753         * Scripts/run-jsc-stress-tests:
2754
2755 2016-07-15  Jon Davis  <jond@apple.com>
2756
2757         Changed the start page URL for WebKit Nightly builds.
2758         https://bugs.webkit.org/show_bug.cgi?id=159816
2759
2760         Reviewed by Timothy Hatcher.
2761
2762         * WebKitLauncher/start.html:
2763
2764 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2765
2766         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2767         https://bugs.webkit.org/show_bug.cgi?id=159414
2768
2769         Reviewed by Brent Fulgham.
2770
2771         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2772         when the HDC parameter is invalid.
2773
2774         * TestWebKitAPI/PlatformWin.cmake:
2775         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2776         (TestWebKitAPI::TEST):
2777
2778 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2779
2780         [GTK] Add basic tabs support to MiniBrowser
2781         https://bugs.webkit.org/show_bug.cgi?id=159803
2782
2783         Reviewed by Sergio Villar Senin.
2784
2785         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2786         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2787
2788         * MiniBrowser/gtk/BrowserTab.c: Added.
2789         (titleChanged):
2790         (isLoadingChanged):
2791         (decidePolicy):
2792         (removeChildIfInfoBar):
2793         (loadChanged):
2794         (createInfoBarQuestionMessage):
2795         (tlsErrorsDialogResponse):
2796         (loadFailedWithTLSerrors):
2797         (permissionRequestDialogResponse):
2798         (decidePermissionRequest):
2799         (colorChooserRGBAChanged):
2800         (popoverColorClosed):
2801         (colorChooserRequestFinished):
2802         (runColorChooserCallback):
2803         (inspectorOpenedInWindow):
2804         (inspectorClosed):
2805         (browserTabSetProperty):
2806         (browserTabFinalize):
2807         (browser_tab_init):
2808         (browserTabConstructed):
2809         (browser_tab_class_init):
2810         (getInternalURI):
2811         (browser_tab_new):
2812         (browser_tab_get_web_view):
2813         (browser_tab_load_uri):
2814         (browser_tab_get_title_widget):
2815         (browser_tab_set_status_text):
2816         (browser_tab_toggle_inspector):
2817         (browser_tab_start_search):
2818         (browser_tab_stop_search):
2819         (browser_tab_add_accelerators):
2820         (fullScreenMessageTimeoutCallback):
2821         (browser_tab_enter_fullscreen):
2822         (browser_tab_leave_fullscreen):
2823         * MiniBrowser/gtk/BrowserTab.h: Added.
2824         * MiniBrowser/gtk/BrowserWindow.c:
2825         (getExternalURI):
2826         (browserWindowSetStatusText):
2827         (reloadOrStopCallback):
2828         (goBackCallback):
2829         (goForwardCallback):
2830         (settingsCallback):
2831         (webViewURIChanged):
2832         (browserWindowHistoryItemActivated):
2833         (browserWindowUpdateNavigationActions):
2834         (webViewCreate):
2835         (webViewEnterFullScreen):
2836         (webViewLeaveFullScreen):
2837         (webViewDecidePolicy):
2838         (browserWindowCanZoomIn):
2839         (browserWindowCanZoomOut):
2840         (browserWindowZoomIn):
2841         (browserWindowZoomOut):
2842         (scrollEventCallback):
2843         (faviconChanged):
2844         (webViewIsLoadingChanged):
2845         (defaultZoomCallback):
2846         (searchCallback):
2847         (newTabCallback):
2848         (toggleWebInspector):
2849         (reloadPage):
2850         (reloadPageIgnoringCache):
2851         (stopPageLoad):
2852         (loadHomePage):
2853         (editingCommandCallback):
2854         (insertImageCommandCallback):
2855         (insertLinkCommandCallback):
2856         (browserWindowSetupEditorToolbar):
2857         (browserWindowSwitchTab):
2858         (browserWindowTabAddedOrRemoved):
2859         (browser_window_init):
2860         (browserWindowConstructed):
2861         (browserWindowSaveSession):
2862         (browserWindowDeleteEvent):
2863         (browser_window_new):
2864         (browser_window_append_view):
2865         (browser_window_load_uri):
2866         (browser_window_load_session):
2867         (browser_window_set_background_color):
2868         (resetStatusText): Deleted.
2869         (activateUriEntryCallback): Deleted.
2870         (webViewTitleChanged): Deleted.
2871         (resetEntryProgress): Deleted.
2872         (browserWindowCreateBackForwardMenu): Deleted.
2873         (webViewReadyToShow): Deleted.
2874         (webViewLoadFailed): Deleted.
2875         (webViewMouseTargetChanged): Deleted.
2876         (browserWindowUpdateZoomActions): Deleted.
2877         (webViewZoomLevelChanged): Deleted.
2878         (updateUriEntryIcon): Deleted.
2879         (zoomInCallback): Deleted.
2880         (zoomOutCallback): Deleted.
2881         (toggleFullScreen): Deleted.
2882         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2883         (browserWindowFinalize): Deleted.
2884         (browser_window_class_init): Deleted.
2885         * MiniBrowser/gtk/BrowserWindow.h:
2886         * MiniBrowser/gtk/CMakeLists.txt:
2887         * MiniBrowser/gtk/main.c:
2888         (createBrowserTab):
2889         (aboutURISchemeRequestCallback):
2890         (main):
2891         (parseBackgroundColor): Deleted.
2892
2893 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2894
2895         Allow RefPtrs of const RefCounted types
2896         https://bugs.webkit.org/show_bug.cgi?id=158269
2897
2898         Reviewed by Anders Carlsson.
2899
2900         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2901         (TestWebKitAPI::TEST):
2902         (TestWebKitAPI::ConstRefCounted::create):
2903         (TestWebKitAPI::returnConstRefCountedRef):
2904         (TestWebKitAPI::returnRefCountedRef):
2905
2906 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2907
2908         Test WTF.StringViewIterators is crashing since r203119
2909         https://bugs.webkit.org/show_bug.cgi?id=159710
2910
2911         Reviewed by Darin Adler.
2912
2913         There are two problems in the test case added in r203119. First is that it's testing
2914         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2915         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2916         const reference to the string view member of the deleted CodePoints object.
2917
2918         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2919         (TestWebKitAPI::TEST):
2920
2921 2016-07-13  Daniel Bates  <dabates@apple.com>
2922
2923         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2924         https://bugs.webkit.org/show_bug.cgi?id=159738
2925         <rdar://problem/27304649>
2926
2927         Reviewed by Dan Bernstein.
2928
2929         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2930         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2931         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2932         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2933
2934         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2935         * WebKitTestRunner/ios/TestControllerIOS.mm:
2936         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2937         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2938
2939 2016-07-13  Beth Dakin  <bdakin@apple.com>
2940
2941         Attempted build fix.
2942
2943         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2944
2945 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2946
2947         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2948         https://bugs.webkit.org/show_bug.cgi?id=159686
2949
2950         Reviewed by Chris Dumez.
2951
2952         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2953
2954         * WebKitTestRunner/TestController.cpp:
2955         (WTR::runOpenPanel):
2956         (WTR::TestController::createOtherPage):
2957         (WTR::TestController::createWebViewWithOptions):
2958
2959 2016-07-13  Beth Dakin  <bdakin@apple.com>
2960
2961         Add more candidate tests
2962         https://bugs.webkit.org/show_bug.cgi?id=159730
2963
2964         Reviewed by Tim Horton.
2965
2966         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
2967         two new tests to that file.
2968         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2969         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2970         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2971         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2972         (TestWebKitAPI::TEST):
2973         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2974
2975 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2976
2977         AX: [ATK] spinbutton-crash.html fails
2978         https://bugs.webkit.org/show_bug.cgi?id=159723
2979
2980         Reviewed by Chris Fleizach.
2981
2982         Implement support for AXDecrementButton and AXIncrementButton in
2983         ATK's AccessibilityUIElement::uiElementAttributeValue().
2984
2985         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2986         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2987
2988 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2989
2990         [EFL] [GTK] Enable back crypto subtle on development builds.
2991         https://bugs.webkit.org/show_bug.cgi?id=159260
2992
2993         Reviewed by Carlos Garcia Campos.
2994
2995         * Scripts/webkitperl/FeatureList.pm:
2996
2997 2016-07-12  Mark Lam  <mark.lam@apple.com>
2998
2999         We should use different stack limits for stack checks from JS and host code.
3000         https://bugs.webkit.org/show_bug.cgi?id=159442
3001         <rdar://problem/26889188>
3002
3003         Reviewed by Geoffrey Garen.
3004
3005         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
3006         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
3007         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
3008         order to keep the js/regress-139548.html test happy with this patch.
3009
3010         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
3011         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
3012
3013         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3014         (-[LTRelayController _environmentVariables]):
3015         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3016         (main):
3017
3018 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
3019
3020         platformUserPreferredLanguages on Mac should not try to put the region into the language
3021         https://bugs.webkit.org/show_bug.cgi?id=159693
3022
3023         Rubber stamped by Alexey Proskuryakov.
3024         
3025         Revert the test change in r200105.
3026
3027         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
3028         (TestWebKitAPI::languageForSystemLanguage):
3029
3030 2016-07-12  Chris Dumez  <cdumez@apple.com>
3031
3032         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
3033         https://bugs.webkit.org/show_bug.cgi?id=159663
3034         <rdar://problem/18995873>
3035
3036         Reviewed by Benjamin Poulain.
3037
3038         Add API test coverage.
3039
3040         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3041         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
3042         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
3043         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
3044         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
3045         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
3046         (TEST):
3047
3048 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
3049
3050         Relax ordering requirements on StringView::CodePoints iterator
3051         https://bugs.webkit.org/show_bug.cgi?id=159609
3052
3053         Reviewed by Darin Adler.
3054
3055         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3056         (TestWebKitAPI::TEST):
3057
3058 2016-07-12  Youenn Fablet  <youenn@apple.com>
3059
3060         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
3061         https://bugs.webkit.org/show_bug.cgi?id=159564
3062
3063         Reviewed by Brian Burg.
3064
3065         * Scripts/webkitpy/codegen/main.py:
3066         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
3067
3068 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3069
3070         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
3071         https://bugs.webkit.org/show_bug.cgi?id=159671
3072
3073         Reviewed by Csaba Osztrogonác.
3074
3075         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
3076         https://bugs.webkit.org/show_bug.cgi?id=89235
3077
3078         So this guard can be removed in build scripts.
3079
3080         * Scripts/webkitperl/FeatureList.pm:
3081         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3082
3083 2016-07-11  Jason Marcell  <jmarcell@apple.com>
3084
3085         SVN.create_patch should find svn-create-patch relative to the WebKit root.
3086         https://bugs.webkit.org/show_bug.cgi?id=159652
3087
3088         Reviewed by Daniel Bates.
3089
3090         * Scripts/webkitpy/common/checkout/scm/svn.py:
3091         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
3092
3093 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
3094
3095         Implement grapheme cluster iterator on StringView
3096         https://bugs.webkit.org/show_bug.cgi?id=159598
3097
3098         Reviewed by Anders Carlsson.
3099
3100         This is in preparation for honoring the second argument to FontFaceSet.load().
3101
3102         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3103         (TestWebKitAPI::compareLoopIterations):
3104         (TestWebKitAPI::TEST):
3105
3106 2016-07-11  Nan Wang  <n_wang@apple.com>
3107
3108         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
3109         https://bugs.webkit.org/show_bug.cgi?id=158364
3110
3111         Reviewed by Anders Carlsson.
3112
3113         Added a function in TestRunner so that we can toggle the ignoring viewport
3114         scale limits setting. Also added a test option for that in order to change the 
3115         configuration of the webview in test.
3116
3117         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3118         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3119         (WTR::TestRunner::setNavigationGesturesEnabled):
3120         (WTR::TestRunner::setIgnoresViewportScaleLimits):
3121         (WTR::nextUIScriptCallbackID):
3122         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3123         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3124         * WebKitTestRunner/TestController.cpp:
3125         (WTR::TestController::resetStateToConsistentValues):
3126         (WTR::updateTestOptionsFromTestHeader):
3127         (WTR::TestController::setNavigationGesturesEnabled):
3128         (WTR::TestController::setIgnoresViewportScaleLimits):
3129         (WTR::TestController::platformWillRunTest):
3130         * WebKitTestRunner/TestController.h:
3131         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3132         * WebKitTestRunner/TestInvocation.cpp:
3133         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3134         * WebKitTestRunner/TestOptions.h:
3135         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3136         (WTR::TestController::platformCreateWebView):
3137
3138 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
3139
3140         [GTK] install-dependencies should not install packages built by jhbuild.
3141         https://bugs.webkit.org/show_bug.cgi?id=159628
3142
3143         Reviewed by Michael Catanzaro.
3144
3145         * gtk/install-dependencies:
3146         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
3147
3148 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
3149
3150         System proxy settings not used when building deps with jhbuild
3151         https://bugs.webkit.org/show_bug.cgi?id=159567
3152
3153         Reviewed by Michael Catanzaro.
3154
3155         This adds the gsettings-desktop-schemas-devel build dep to enable
3156         the libgiognomeproxy.so gio module in glib-networking, which uses
3157         GSettings on org.gnome.system.proxy.
3158         This is needed to query system proxy settings for Gnome desktops.
3159
3160         dconf can be manually added to jhbuild to build the
3161         libdconfsettings.so gio module for GSettings, so that
3162         libgiognomeproxy.so can access system settings.
3163           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
3164
3165         As an alternative to dconf settings, this commit also adds the
3166         libproxy-devel build dep to enable the libgiolibproxy.so module in
3167         glib-networking (suggested by Fujii Hironori).
3168
3169         It is useful to read proxy settings from environment variables.
3170         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
3171         environment variable to force using the envvar module in libproxy.
3172
3173         * gtk/install-dependencies:
3174
3175 2016-07-11  Mark Lam  <mark.lam@apple.com>
3176
3177         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
3178         https://bugs.webkit.org/show_bug.cgi?id=159524
3179
3180         Reviewed by Michael Saboff.
3181
3182         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
3183         Also fixed up some tests to behave better to work with this new limit.  This
3184         should make stack overflow tests complete sooner.
3185
3186         * Scripts/run-jsc-stress-tests:
3187         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3188         (main):
3189
3190 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3191
3192         [GTK] Whitespace fixes in install-dependencies script
3193
3194         Unreviewed.
3195
3196         * gtk/install-dependencies:
3197
3198 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3199
3200         [GTK] Install missing Fedora dependencies
3201
3202         Unreviewed.
3203
3204         * gtk/install-dependencies:
3205
3206 2016-07-09  Dan Bernstein  <mitz@apple.com>
3207
3208         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
3209         https://bugs.webkit.org/show_bug.cgi?id=159600
3210
3211         Reviewed by Daniel Bates.
3212
3213         * Scripts/git-add-reviewer:
3214         Added the -s|--rubber-stamp option.
3215         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
3216           new option.
3217
3218 2016-07-08  Andy Estes  <aestes@apple.com>
3219
3220         [Content Filtering] Load blocked pages more like other error pages are loaded
3221         https://bugs.webkit.org/show_bug.cgi?id=159485
3222         <rdar://problem/26014076>
3223
3224         Reviewed by Brady Eidson.
3225
3226         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3227         to a content filtering provisional navigation failure is ignored in preference of
3228         ContentFilter's own error page.
3229
3230         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3232         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3233         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3234         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3235         (loadAlternateTest):
3236         (TEST):
3237         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3238         (-[MockContentFilterEnabler initWithCoder:]):
3239         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3240         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3241         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3242         (TestWebKitAPI::loadAlternateTest):
3243         (TestWebKitAPI::TEST):
3244
3245 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3246
3247         Unreviewed, rolling out r202944.
3248         https://bugs.webkit.org/show_bug.cgi?id=159570
3249
3250         caused some tests to crash under GuardMalloc (Requested by
3251         estes on #webkit).
3252
3253         Reverted changeset:
3254
3255         "[Content Filtering] Load blocked pages more like other error
3256         pages are loaded"
3257         https://bugs.webkit.org/show_bug.cgi?id=159485
3258         http://trac.webkit.org/changeset/202944
3259
3260 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
3261
3262         Remove mrobinson from the MathML watchlist
3263         https://bugs.webkit.org/show_bug.cgi?id=159559
3264
3265         Reviewed by Philippe Normand.
3266
3267         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
3268
3269 2016-07-08  Brady Eidson  <beidson@apple.com>
3270
3271         Clearing LocalStorage doesn't also delete -wal and -shm files.
3272         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
3273
3274         Reviewed by Brent Fulgham.
3275         Also helpfully picked over by Andy "Never Forgets" Estes.
3276
3277         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3278         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
3279         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
3280
3281 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
3282
3283         Removed Qt leftovers from Tools.
3284         https://bugs.webkit.org/show_bug.cgi?id=159557
3285
3286         Reviewed by Csaba Osztrogonác.
3287
3288         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3289         Removed 'qt' platform config.
3290         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3291         Deleted non-functional e-mail address.
3292
3293 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3294
3295         Unreviewed, rolling out r202967.
3296         https://bugs.webkit.org/show_bug.cgi?id=159556
3297
3298         This patch caused crashes in https tests on Windows (Requested
3299         by perarne on #webkit).
3300
3301         Reverted changeset:
3302
3303         "[Win] The test http/tests/security/contentSecurityPolicy
3304         /upgrade-insecure-requests/basic-upgrade.https.html is
3305         failing."
3306         https://bugs.webkit.org/show_bug.cgi?id=159510
3307         http://trac.webkit.org/changeset/202967
3308
3309 2016-07-08  Youenn Fablet  <youenn@apple.com>
3310
3311         Generate WebCore builtin wrapper files
3312         https://bugs.webkit.org/show_bug.cgi?id=159461
3313
3314         Reviewed by Brian Burg.
3315
3316         * Scripts/webkitpy/codegen/main.py:
3317         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
3318         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
3319
3320 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
3321
3322         [EFL] Fix build when media-stream is enabled.
3323         https://bugs.webkit.org/show_bug.cgi?id=159206
3324
3325         Bump up the openwebrtc to find the correct package.
3326
3327         Reviewed by Gyuyoung Kim.
3328
3329         * efl/jhbuild.modules:
3330         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
3331
3332 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3333
3334         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
3335         https://bugs.webkit.org/show_bug.cgi?id=159510
3336
3337         Reviewed by Brent Fulgham.
3338
3339         Allow any https certificate when running tests.
3340
3341         * DumpRenderTree/win/DumpRenderTree.cpp:
3342         (runTest):
3343
3344 2016-07-07  Beth Dakin  <bdakin@apple.com>
3345
3346         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3347         https://bugs.webkit.org/show_bug.cgi?id=159532
3348         -and corresponding-
3349         rdar://problem/27177179
3350
3351         Reviewed by Tim Horton.
3352
3353         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
3354         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
3355
3356 2016-07-07  Andy Estes  <aestes@apple.com>
3357
3358         [Content Filtering] Load blocked pages more like other error pages are loaded
3359         https://bugs.webkit.org/show_bug.cgi?id=159485
3360         <rdar://problem/26014076>
3361
3362         Reviewed by Brady Eidson.
3363
3364         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3365         to a content filtering provisional navigation failure is ignored in preference of
3366         ContentFilter's own error page.
3367
3368         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3370         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3371         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3372         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3373         (loadAlternateTest):
3374         (TEST):
3375         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3376         (-[MockContentFilterEnabler initWithCoder:]):
3377         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3378         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3379         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3380         (TestWebKitAPI::loadAlternateTest):
3381         (TestWebKitAPI::TEST):
3382
3383 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3384
3385         Unreviewed: add myself to the reviewers list.
3386
3387         * Scripts/webkitpy/common/config/contributors.json:
3388
3389 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3390
3391         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
3392         https://bugs.webkit.org/show_bug.cgi?id=159509
3393
3394         Reviewed by Alex Christensen.
3395
3396         We should always insert the url in the url map when identifierForInitialRequest
3397         is called. Otherwise we can end up with identifiers not having an entry in the
3398         url map when urls are written to the test output file. 
3399
3400         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3401         (ResourceLoadDelegate::identifierForInitialRequest):
3402
3403 2016-07-06  Tim Horton  <timothy_horton@apple.com>
3404
3405         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3406         https://bugs.webkit.org/show_bug.cgi?id=159498
3407         <rdar://problem/26719903>
3408
3409         Reviewed by Sam Weinig.
3410
3411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3412         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3413         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3414         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3415         (expectLinkCount):
3416         (TEST):
3417         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3418         when deciding what to linkify.
3419
3420 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3421
3422         Build fix - work around rdar://problem/27196668.
3423
3424         * LayoutTestRelay/Configurations/Base.xcconfig:
3425
3426 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3427
3428         Enhance Windows DRT implementation to support platform scroll wheel events.
3429         https://bugs.webkit.org/show_bug.cgi?id=36002
3430
3431         Reviewed by Brent Fulgham.
3432
3433         Implement function continuousMouseScrollBy in Windows event sender.
3434
3435         * DumpRenderTree/win/EventSender.cpp:
3436         (mouseScrollBy):
3437         (continuousMouseScrollBy):
3438
3439 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3440
3441         [Sierra] Rebaseline tests to use un-mocked system font metrics
3442         https://bugs.webkit.org/show_bug.cgi?id=159311
3443         <rdar://problem/24138411>
3444
3445         Reviewed in person by Alexey Proskuryakov.
3446
3447         Stop mocking the system font on Sierra.
3448
3449         * DumpRenderTree/mac/DumpRenderTree.mm:
3450         (setDefaultsToConsistentValuesForTesting):
3451         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3452         (WTR::InjectedBundle::platformInitialize):
3453
3454 2016-07-05  Brady Eidson  <beidson@apple.com>
3455
3456         Database process crashes deleting a corrupt SQLite database file (null deref).
3457         https://bugs.webkit.org/show_bug.cgi?id=155506.
3458
3459         Reviewed by Alex Christensen.
3460
3461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3462         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3463         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3464         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3465         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3466         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3467
3468 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3469
3470         run-webkit-tests should print more complete baseline search paths
3471         https://bugs.webkit.org/show_bug.cgi?id=159354
3472
3473         Reviewed by Daniel Bates.
3474
3475         run-webkit-tests used to only print directory names in baseline search paths.
3476         This was ok in basic usage, but quickly got confusing when using
3477         --additional-platform-directory flags.
3478
3479         * Scripts/webkitpy/layout_tests/views/printing.py:
3480         (Printer.print_config):
3481         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3482         (Testprinter.test_print_config):
3483         (Testprinter.test_print_one_line_summary):
3484
3485 2016-07-04  Brady Eidson  <beidson@apple.com>
3486
3487         WebProcesses don't handle DatabaseProcess going away uncleanly..
3488         https://bugs.webkit.org/show_bug.cgi?id=159371
3489
3490         Reviewed by Alex Christensen.
3491
3492         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3493         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3494         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3495         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3496         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3497
3498 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3499
3500         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3501         https://bugs.webkit.org/show_bug.cgi?id=158141
3502
3503         Rubber-stamped by Michael Catanzaro.
3504
3505         Instead of checking for an specific Ubuntu version, query the apt
3506         database to see which version of PHP is available.
3507
3508         * efl/install-dependencies:
3509         * gtk/install-dependencies:
3510
3511 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3512
3513         webkit-patch failure-reason always raises TypeError
3514         https://bugs.webkit.org/show_bug.cgi?id=159394
3515
3516         Reviewed by Benjamin Poulain.
3517
3518         In r170637 (Bug 133067), the first and second arguments of
3519         pluralize were swapped.
3520
3521         * Scripts/webkitpy/tool/commands/queries.py:
3522         (FailureReason._builder_to_explain): Swap the first and second
3523         arguments of pluralize.
3524
3525 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3526
3527         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3528         https://bugs.webkit.org/show_bug.cgi?id=152486
3529
3530         Reviewed by Daniel Bates.
3531
3532         Add launch of web-platform-tests server by run-webkit-httpd.
3533         Add two options to disable starting httpd and web-platform-tests servers.
3534
3535         * Scripts/run-webkit-httpd:
3536         (parse_args):
3537         (main):
3538
3539 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3540
3541         REGRESSION(r189668): Notification tests are flakey
3542         https://bugs.webkit.org/show_bug.cgi?id=159375
3543         <rdar://problem/22760990>
3544
3545         Reviewed by Alexey Proskuryakov.
3546
3547         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3548         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3549         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3550         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3551
3552         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3553         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3554         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3555         global notification ID mapping, causing the wrong notification to be investigated.
3556
3557         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3558         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3559         notification is created or destroyed. However, because this object is implemented outside WebKit,
3560         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3561         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3562         WebNotificationProvider can properly map between the different IDs.
3563
3564         * WebKitTestRunner/TestController.cpp:
3565         (WTR::TestController::runTestingServerLoop):
3566         (WTR::TestController::simulateWebNotificationClick):
3567         * WebKitTestRunner/WebNotificationProvider.cpp:
3568         (WTR::WebNotificationProvider::showWebNotification):
3569         (WTR::removeGlobalIDFromIDMap):
3570         (WTR::WebNotificationProvider::closeWebNotification):
3571         (WTR::WebNotificationProvider::removeNotificationManager):
3572         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3573         (WTR::WebNotificationProvider::reset):
3574         * WebKitTestRunner/WebNotificationProvider.h:
3575
3576 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3577
3578         Simplify LayoutTestRelay
3579         https://bugs.webkit.org/show_bug.cgi?id=159353
3580
3581         Reviewed by Daniel Bates.
3582
3583         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3584         by name and runtime makes no sense.
3585         2. Removed code to create devices, webkitpy always does this in advance.
3586         3. Don't create copies of testing apps - we can install the same one into
3587         each simulator, now that we don't run multiple tester processes in a single simulator.
3588         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3589         5. Removed code that kept testing apps alive in the background.
3590         6. Slightly updated coding style in functions that I touched.
3591
3592         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3593         Updated for what we acually use at this point.
3594
3595         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3596         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3597         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3598         (-[LTRelayController ipcIdentifier]):
3599         (-[LTRelayController processName]):
3600         (-[LTRelayController didReceiveStdoutData:]):
3601         (-[LTRelayController didCrashWithMessage:]):
3602         (-[LTRelayController installApp]):
3603         (-[LTRelayController _environmentVariables]):
3604         (-[LTRelayController launchApp]):
3605         (-[LTRelayController start]):
3606         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3607         (-[LTRelayController uniqueAppPath]): Deleted.
3608         (-[LTRelayController uniqueAppURL]): Deleted.
3609         (-[LTRelayController uniqueAppIdentifier]): Deleted.
3610         (-[LTRelayController createUniqueApp]): Deleted.
3611         * LayoutTestRelay/LayoutTestRelay/main.m:
3612         (usage):
3613         (getRequiredStringArgument):
3614         (main):
3615         (getTestingSimDevice): Deleted.
3616         * Scripts/webkitpy/port/driver.py:
3617         (IOSSimulatorDriver.cmd_line):
3618         * WebKitTestRunner/ios/TestControllerIOS.mm:
3619         (WTR::TestController::platformInitialize):
3620         * WebKitTestRunner/ios/mainIOS.mm:
3621         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3622         * DumpRenderTree/mac/DumpRenderTree.mm:
3623         (dumpRenderTree):
3624         (-[DumpRenderTree applicationDidEnterBackground:]):
3625
3626 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
3627
3628         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3629         https://bugs.webkit.org/show_bug.cgi?id=159344
3630
3631         Reviewed by Alex Christensen.
3632
3633         * DumpRenderTree/CMakeLists.txt:
3634
3635 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3636
3637         Add a runtime flag for DOM iterators
3638         https://bugs.webkit.org/show_bug.cgi?id=159300
3639
3640         Reviewed by Alex Christensen.
3641
3642         * DumpRenderTree/mac/DumpRenderTree.mm:
3643         (resetWebPreferencesToConsistentValues):
3644         * DumpRenderTree/win/DumpRenderTree.cpp:
3645         (resetWebPreferencesToConsistentValues):
3646         * Scripts/webkitperl/FeatureList.pm:
3647         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3648         (WTR::InjectedBundle::beginTesting):
3649         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3650         (WTR::TestRunner::setDOMIteratorEnabled):
3651         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3652
3653 2016-06-30  Tina Liu  <iting_liu@apple.com>
3654
3655         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3656         https://bugs.webkit.org/show_bug.cgi?id=159326
3657
3658         Reviewed by Brady Eidson.
3659
3660         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3661         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3662         (TestWebKitAPI::didFinishLoadForFrame):
3663         (TestWebKitAPI::didChangeBackForwardListForPage):
3664         (TestWebKitAPI::setPageLoaderClient):
3665         Set the page loader client and register for didFinishLoadForFrame and
3666         didChangeBackForwardList callbacks.
3667         (TestWebKitAPI::createSessionStateData):
3668         Load a webpage ("simple.html") and return the session state for this page.
3669         (TestWebKitAPI::TEST):
3670         Restore the page session state with that of "simple.html" without navigation.
3671         Verify that the committed URL is NULL since there's no navigation involved.
3672         Verify that the current item in the back forward list, which should be what
3673         we restored from the session state, has the expected URL.
3674
3675 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
3676
3677         Generators violate bytecode liveness validation
3678         https://bugs.webkit.org/show_bug.cgi?id=159279
3679
3680         Reviewed by Yusuke Suzuki.
3681         
3682         Add Basic to our test harness.
3683
3684         * Scripts/run-javascriptcore-tests:
3685         (runJSCStressTests):
3686
3687 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
3688
3689         [Win][Debug] Assertion fails in TestWTF.
3690         https://bugs.webkit.org/show_bug.cgi?id=159299
3691
3692         Reviewed by Alex Christensen.
3693
3694         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3695         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3696         the assertion failure. Since the variable is actually used, there is no need to use the
3697         UNUSED_PARAM macro.
3698
3699         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3700         (TestWebKitAPI::TEST):
3701
3702 2016-06-30  Youenn Fablet  <youennf@gmail.com>
3703
3704         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
3705         https://bugs.webkit.org/show_bug.cgi?id=159166
3706         <rdar://problem/27051759>
3707
3708         Reviewed by Alexey Proskuryakov.
3709
3710         Setting the certificate directory to the copied config.json.
3711
3712         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3713         (WebPlatformTestServer._copy_webkit_test_files):
3714
3715 2016-06-29  Mark Lam  <mark.lam@apple.com>
3716
3717         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
3718         https://bugs.webkit.org/show_bug.cgi?id=159274
3719
3720         Reviewed by Keith Miller.
3721
3722         * DumpRenderTree/mac/DumpRenderTree.mm:
3723         (DumpRenderTreeMain):
3724
3725 2016-06-29  Alex Christensen  <achristensen@webkit.org>
3726
3727         WKWebView should ask WKNavigationDelegate about bad ssl certificates
3728         https://bugs.webkit.org/show_bug.cgi?id=159176
3729
3730         Reviewed by Sam Weinig.
3731
3732         * MiniBrowser/mac/WK2BrowserWindowController.m:
3733         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3734         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3735         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3736
3737 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3738
3739         [GTK] Add missing install dependency after r202619
3740         https://bugs.webkit.org/show_bug.cgi?id=156716
3741
3742         Unreviewed.
3743
3744         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3745
3746 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3747
3748         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3749         https://bugs.webkit.org/show_bug.cgi?id=156716
3750
3751         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3752
3753         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3754         (parse_args):
3755         * Scripts/webkitpy/port/gtk.py:
3756         (GtkPort.__init__):
3757         (GtkPort._driver_class):
3758         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3759         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3760         platform directory for storing the wayland specific layout test results and expectations for ${port}.
3761         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3762         test expectations file on the GTK port when running the tests with the --wayland command line switch.
3763         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3764         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3765         (WestonDriver.check_driver):
3766         (WestonDriver.__init__):
3767         (WestonDriver._start):
3768         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3769         (WestonXvfbDriverDisplayTest):
3770         (WestonXvfbDriverDisplayTest.__init__):
3771         (WestonXvfbDriverDisplayTest._xvfb_run):
3772         (WestonDriverTest.make_driver):
3773         (WestonDriverTest.test_start):
3774         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3775         or to satisfy the pkg-config check of the new added modules in JHBuild.
3776         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3777         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3778         provided by the system are already new enough.
3779         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3780         It was the only way to get the software EGL rasterizer working without depending on user drivers.
3781         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3782         feature to avoid building libdrm when the one provided by the system is new enough.
3783         * gtk/jhbuildrc:
3784         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
3785         Xorg had no support for searching the DRI drivers on a custom path at runtime.
3786         This patch implements support for that reusing the same variable that we use with Mesa to set the
3787         custom path for the DRI drivers path.
3788
3789 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
3790
3791         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
3792         https://bugs.webkit.org/show_bug.cgi?id=159256
3793
3794         Reviewed by Philippe Normand.
3795
3796         We need the last fixes in the repository to make the scream queue
3797         work with apprtc.
3798
3799         * gtk/jhbuild.modules:
3800
3801 2016-06-28  Commit Queue  <commit-queue@webkit.org>
3802
3803         Unreviewed, rolling out r202580.
3804         https://bugs.webkit.org/show_bug.cgi?id=159245
3805
3806         Caused all WKTR tests to fail on GuardMalloc and Production
3807         only for unknown reasons, investigating offline. (Requested by
3808         brrian on #webkit).
3809
3810         Reverted changeset:
3811
3812         "RunLoop::Timer should use constructor templates instead of
3813         class templates"
3814         https://bugs.webkit.org/show_bug.cgi?id=159153
3815         http://trac.webkit.org/changeset/202580
3816
3817 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3818
3819         Use a regex to check if a test step is for JavaScriptCore
3820         https://bugs.webkit.org/show_bug.cgi?id=159224
3821
3822         Reviewed by Geoffrey Garen.
3823
3824         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3825         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
3826         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3827         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
3828         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3829         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
3830
3831 2016-06-28  Michael Saboff  <msaboff@apple.com>
3832
3833         btjs no longer accepts optional frame count argument
3834         https://bugs.webkit.org/show_bug.cgi?id=159235
3835
3836         Reviewed by Saam Barati.
3837
3838         Fix the detection of optional backtrace-depth parameter to use the length
3839         of the command.
3840
3841         * lldb/lldb_webkit.py:
3842         (btjs):
3843
3844 2016-06-28  Jon Lee  <jonlee@apple.com>
3845
3846         Update animometer.plan
3847
3848         Rubber-stamped by Said Abou-Hallawa.
3849
3850         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
3851
3852 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
3853
3854         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
3855
3856         * Scripts/run-javascriptcore-tests:
3857         (runJSCStressTests):
3858
3859 2016-06-28  Brian Burg  <bburg@apple.com>
3860
3861         RunLoop::Timer should use constructor templates instead of class templates
3862         https://bugs.webkit.org/show_bug.cgi?id=159153
3863
3864         Reviewed by Alex Christensen.
3865
3866         Remove the RunLoop::Timer class template argument, and pass its constructor
3867         a reference to `this` instead of a pointer to `this`.
3868
3869         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3870         (WTR::TestRunner::TestRunner):
3871         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3872         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3873         (TestWebKitAPI::TEST):
3874
3875 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3876
3877         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3878         https://bugs.webkit.org/show_bug.cgi?id=159199
3879
3880         Reviewed by Alexey Proskuryakov.
3881
3882         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
3883
3884         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3885         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3886         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
3887         an input element getting automatically focused on Mac.
3888
3889 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
3890
3891         [Win] Custom elements tests are failing.
3892         https://bugs.webkit.org/show_bug.cgi?id=159139
3893
3894         Reviewed by Alex Christensen.
3895
3896         Enable custom element API when running tests.
3897
3898         * DumpRenderTree/win/DumpRenderTree.cpp:
3899         (resetWebPreferencesToConsistentValues):
3900
3901 2016-06-27  Lucas Forschler  <lforschler@apple.com>
3902
3903         Test commit. Please ignore.
3904         
3905 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3906
3907         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
3908         https://bugs.webkit.org/show_bug.cgi?id=155073
3909
3910         Reviewed by Daniel Bates.
3911
3912         * Scripts/webkitperl/FeatureList.pm:
3913
3914 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
3915
3916         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3917         https://bugs.webkit.org/show_bug.cgi?id=159077
3918
3919         Reviewed by Tim Horton.
3920
3921         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
3922
3923         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
3924         which is necessary for UI-side compositing.
3925
3926         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
3927         seems to happen for some tests that call window.resizeTo().
3928
3929         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3930         (WTR::InjectedBundlePage::dump): Deleted.
3931         * WebKitTestRunner/TestInvocation.cpp:
3932         (WTR::TestInvocation::dumpResults):
3933         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3934         (WTR::createCGContextFromImage):
3935         (WTR::computeMD5HashStringForContext):
3936         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3937         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3938         (WTR::PlatformWebView::windowSnapshotImage):
3939
3940 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3941
3942         [EFL] Support to build on Debian linux
3943         https://bugs.webkit.org/show_bug.cgi?id=159123
3944
3945         Reviewed by Antonio Gomes.
3946
3947         * efl/install-dependencies: Install libgnutls28-dev.
3948
3949 2016-06-27  Alex Christensen  <achristensen@webkit.org>
3950
3951         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
3952         https://bugs.webkit.org/show_bug.cgi?id=159071
3953
3954         Reviewed by Brady Eidson.
3955
3956         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3957         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3958         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3959         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3960         (WTR::TestRunner::setAuthenticationUsername):
3961         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3962         * WebKitTestRunner/TestController.cpp:
3963         (WTR::TestController::TestController):
3964         (WTR::TestController::resetStateToConsistentValues):
3965         (WTR::TestController::didFinishNavigation):
3966         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3967         (WTR::TestController::didReceiveAuthenticationChallenge):
3968         (WTR::TestController::didCommitNavigation):
3969         * WebKitTestRunner/TestController.h:
3970         (WTR::TestController::setBlockAllPlugins):
3971         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3972         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
3973         (WTR::TestController::isCurrentInvocation):
3974         * WebKitTestRunner/TestInvocation.cpp:
3975         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3976         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
3977
3978 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
3979
3980         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
3981         https://bugs.webkit.org/show_bug.cgi?id=159129
3982
3983         Reviewed by Alex Christensen.
3984
3985         Implement the function mouseScrollBy in the Windows event sender.
3986
3987         * DumpRenderTree/win/EventSender.cpp:
3988         (mouseScrollBy):
3989         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3990
3991 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
3992
3993         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3994         https://bugs.webkit.org/show_bug.cgi?id=159104
3995
3996         Reviewed by Dan Bernstein.
3997         
3998         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
3999         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
4000
4001         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
4002         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
4003         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
4004
4005 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
4006
4007         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
4008         https://bugs.webkit.org/show_bug.cgi?id=159086
4009
4010         Reviewed by Alex Christensen.
4011
4012         Implement required wheel event function in event sender.
4013  
4014         * DumpRenderTree/win/EventSender.cpp:
4015         (mouseScrollByWithWheelAndMomentumPhasesCallback):
4016
4017 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
4018
4019         REGRESSION: Weak symbol warning when linking TestWebKitAPI
4020         https://bugs.webkit.org/show_bug.cgi?id=159104
4021
4022         Reviewed by Mark Lam.
4023         
4024         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
4025         WK.
4026
4027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4028
4029 2016-06-24  David Kilzer  <ddkilzer@apple.com>
4030
4031         parser_unittests.pl should not hardcode list of tests
4032         <https://webkit.org/b/159074>
4033
4034         Reviewed by Daniel Bates.
4035
4036         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
4037         Update to read the list of tests from the 'resources' directory,
4038         and instead map file extensions to subroutine names.  Switch to
4039         use File::Basename::fileparse() to get basename and file
4040         extension for each test.
4041         (readTestFiles): Added.  Reads files from the directory passed
4042         in and ignores: hidden files, anything that isn't a plain file,
4043         and expected test results files.
4044
4045 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
4046
4047         Fix Windows build.
4048
4049         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
4050         * DumpRenderTree/cg/PixelDumpSupportCG.h:
4051
4052 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4053
4054         [EFL] Change download path of libxslt
4055
4056         Unreviewed EFL build fix.
4057
4058         In Korea current download path can't be accessed. Change it.
4059
4060         * efl/jhbuild.modules:
4061
4062 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
4063
4064         https://bugs.webkit.org/show_bug.cgi?id=159077
4065
4066         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
4067         snapshot the final state of the test in release builds. 
4068
4069         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4070         (WTR::InjectedBundlePage::dump):
4071
4072 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
4073
4074         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
4075
4076         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
4077         (createBitmapContextFromWebView):
4078         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4079         (WTR::PlatformWebView::windowSnapshotImage):
4080
4081 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
4082
4083         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
4084         https://bugs.webkit.org/show_bug.cgi?id=159077
4085
4086         Reviewed by Tim Horton.
4087
4088         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
4089         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
4090         thus enabling testing of more things.
4091
4092         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
4093         (createBitmapContext): Moved to this file to share it.
4094         * DumpRenderTree/cg/PixelDumpSupportCG.h:
4095         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
4096         (createBitmapContextFromWebView):
4097         (BitmapContext::createFromUIImage): Deleted.
4098         (BitmapContext::pixelData): Deleted.
4099         (BitmapContext::BitmapContext): Deleted.
4100         (computeMD5HashStringForBitmapContext): Deleted.
4101         (dumpBitmap): Deleted.
4102         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
4103         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
4104         (createPagedBitmapContext):
4105         (createBitmapContext): Deleted.
4106         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
4107         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4108         (WTR::InjectedBundlePage::dump): Deleted.
4109         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4110         (WTR::PlatformWebView::windowSnapshotImage):
4111
4112 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
4113
4114         [jhbuild] Added libxslt module.
4115         https://bugs.webkit.org/show_bug.cgi?id=159034
4116
4117         Unreviewed, followup for r202373.
4118
4119         * efl/install-dependencies: Removed libxslt 
4120         * gtk/install-dependencies: Ditto.
4121
4122 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4123
4124         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
4125         https://bugs.webkit.org/show_bug.cgi?id=159050
4126
4127         Reviewed by Antonio Gomes.
4128
4129         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
4130
4131         * efl/jhbuild.modules:
4132         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
4133         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
4134
4135 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
4136
4137         [jhbuild] Added libxslt module.
4138         https://bugs.webkit.org/show_bug.cgi?id=159034
4139
4140         Reviewed by Michael Catanzaro.
4141
4142         * efl/jhbuild.modules:
4143         * gtk/jhbuild.modules:
4144
4145 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4146
4147         [Win] Use Windows api function to find top level parent.
4148         https://bugs.webkit.org/show_bug.cgi?id=159021
4149
4150         Reviewed by Brent Fulgham.
4151
4152         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
4153  
4154         * DumpRenderTree/win/UIDelegate.cpp:
4155         (UIDelegate::runModal):
4156         (findTopLevelParent): Deleted.
4157         * MiniBrowser/win/PrintWebUIDelegate.cpp:
4158         (PrintWebUIDelegate::runModal):
4159         (findTopLevelParent): Deleted.
4160
4161 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4162
4163         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
4164         https://bugs.webkit.org/show_bug.cgi?id=158934
4165
4166         Reviewed by Brent Fulgham.
4167
4168         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
4169
4170         * DumpRenderTree/win/TestRunnerWin.cpp:
4171         (TestRunner::clearAllDatabases):
4172
4173 2016-06-22  Saam Barati  <sbarati@apple.com>
4174
4175         run-javascriptcore-tests should have some environment variables for commonly used settings
4176         https://bugs.webkit.org/show_bug.cgi?id=159047
4177
4178         Reviewed by Keith Miller.
4179
4180         This patch adds three environment variables that run-javascriptcore-tests
4181         consults:
4182         - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
4183           determines if we should run the api tests or not.
4184         - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
4185           determines if we will perform a build or not before running the tests.
4186           to set the default should-build setting.
4187         - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
4188           a yaml file. If set, we will run the extra tests it refers to.
4189
4190         All the values in these environment variables will be overridden if an
4191         option is explicitly passed in. For example, the following will run
4192         the api tests:
4193         `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
4194
4195         * Scripts/run-javascriptcore-tests:
4196
4197 2016-06-22  Saam barati  <sbarati@apple.com>
4198
4199         TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
4200         https://bugs.webkit.org/show_bug.cgi?id=159037
4201         <rdar://problem/26935349>
4202
4203         Reviewed by Benjamin Poulain.
4204
4205         Run typeProfiler.yaml tests under an additional CJIT enabled mode.
4206
4207         * Scripts/run-jsc-stress-tests:
4208
4209 2016-06-22  Aakash Jain  <aakash_jain@apple.com>
4210
4211         Fix style issues in webkitpy
4212         https://bugs.webkit.org/show_bug.cgi?id=159019
4213
4214         Reviewed by Daniel Bates.
4215
4216         Fixed the formatting issues as reported by check-webkit-style in webkitpy.
4217         There is no functionality change.
4218         Only affected file names retained below for brevity.
4219
4220         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
4221         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
4222         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
4223         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
4224         * Scripts/webkitpy/benchmark_runner/utils.py:
4225         * Scripts/webkitpy/common/checkout/changelog.py:
4226         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4227         * Scripts/webkitpy/common/checkout/checkout.py:
4228         * Scripts/webkitpy/common/checkout/checkout_mock.py:
4229         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
4230         * Scripts/webkitpy/common/checkout/commitinfo.py:
4231         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
4232         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
4233         * Scripts/webkitpy/common/checkout/scm/scm.py:
4234         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4235         * Scripts/webkitpy/common/config/committers_unittest.py:
4236         * Scripts/webkitpy/common/config/irc.py:
4237         * Scripts/webkitpy/common/config/ports.py:
4238         * Scripts/webkitpy/common/config/ports_unittest.py:
4239         * Scripts/webkitpy/common/config/urls.py:
4240         * Scripts/webkitpy/common/host_mock.py:
4241         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4242         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4243         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4244         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
4245         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4246         * Scripts/webkitpy/common/net/credentials_unittest.py:
4247         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
4248         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
4249         * Scripts/webkitpy/common/net/statusserver.py:
4250         * Scripts/webkitpy/common/system/autoinstall.py:
4251         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
4252         * Scripts/webkitpy/common/system/executive.py:
4253         * Scripts/webkitpy/common/system/executive_mock.py:
4254         * Scripts/webkitpy/common/system/executive_unittest.py:
4255         * Scripts/webkitpy/common/system/filesystem_mock.py:
4256         * Scripts/webkitpy/common/system/filesystem_unittest.py:
4257         * Scripts/webkitpy/common/system/logutils_unittest.py:
4258         * Scripts/webkitpy/common/system/path.py:
4259         * Scripts/webkitpy/common/system/path_unittest.py:
4260         * Scripts/webkitpy/common/system/platforminfo.py:
4261         * Scripts/webkitpy/common/system/user.py:
4262         * Scripts/webkitpy/common/system/user_unittest.py:
4263         * Scripts/webkitpy/common/system/workspace_unittest.py:
4264         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
4265         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
4266         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
4267         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4268         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4269         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4270         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
4271         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
4272         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4273         * Scripts/webkitpy/layout_tests/models/test_failures.py:
4274         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
4275         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4276         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
4277         * Scripts/webkitpy/layout_tests/views/printing.py:
4278         * Scripts/webkitpy/performance_tests/perftestsrunner.py: