REGRESSION(r168471): Update the builder names on the scheduler list.
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2
3         REGRESSION(r168471): Update the builder names on the scheduler list.
4         https://bugs.webkit.org/show_bug.cgi?id=132699
5
6         Reviewed by Martin Robinson.
7
8         On r168471 I missed to update the builder names for the GTK build
9         bots on the AnyBranchScheduler type scheduler list of bots.
10
11         * BuildSlaveSupport/build.webkit.org-config/config.json:
12
13 2014-05-08  Brady Eidson  <beidson@apple.com>
14
15         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
16         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
17
18         Reviewed by Tim Horton.
19
20         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
21         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
22
23 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
24
25         REGRESSION(r168471): Duplicate builddirs broke the build master.
26         https://bugs.webkit.org/show_bug.cgi?id=132688
27
28         Reviewed by Carlos Garcia Campos.
29
30         Rename the builddirs of the new GTK bots introduced on r168471 to
31         be unique. Otherwise the master will break.
32
33         * BuildSlaveSupport/build.webkit.org-config/config.json:
34
35 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
36
37         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
38         https://bugs.webkit.org/show_bug.cgi?id=132674
39
40         Reviewed by Philippe Normand.
41
42         Only ignore mkdir failure when exception is raised because the
43         file already exists and it's a directory.
44
45         * gtk/webkitdom.py:
46         (write_doc_files):
47
48 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
49
50         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
51         https://bugs.webkit.org/show_bug.cgi?id=131358
52
53         Reviewed by Carlos Garcia Campos.
54
55         Current 64-bit GTK build bots (Release and Debug) not only test
56         the build, but run all tests. Split each one of the bots in
57         BuildOnly and TestWebKit2.
58
59         This will allow us to have a better overview of the status of
60         the GTK port.
61
62         Original patch from Sergio Villar Senin <svillar@igalia.com>
63
64         * BuildSlaveSupport/build.webkit.org-config/config.json:
65         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
66         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
67         (WebKitBuildbot):
68         * Scripts/webkitpy/port/builders.py:
69         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
70         (TestRebaselineTest.test_baseline_directory):
71         * TestResultServer/static-dashboards/builders.jsonp:
72         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
73         (resetGlobals):
74         * TestResultServer/static-dashboards/loader_unittests.js:
75
76 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
77
78         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
79         https://bugs.webkit.org/show_bug.cgi?id=126022
80
81         Reviewed by Benjamin Poulain.
82
83         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
84
85         Added an unit test case to check if scroll position and scale are restored properly.
86
87         * TestWebKitAPI/PlatformEfl.cmake:
88         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
89         (TestWebKitAPI::didFinishLoadForFrame):
90         (TestWebKitAPI::didChangeContentsPosition):
91         (TestWebKitAPI::TEST):
92         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
93         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
94
95 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
96
97         WebKit1 is flashy when compositing layers come and go
98         https://bugs.webkit.org/show_bug.cgi?id=132655
99         <rdar://problem/16830981&16788846>
100
101         Reviewed by Sam Weinig.
102         
103         Revert the change from r166117.
104
105         * DumpRenderTree/mac/DumpRenderTree.mm:
106         (updateDisplay):
107
108 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
109
110         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
111         https://bugs.webkit.org/show_bug.cgi?id=132622
112
113         Reviewed by Mario Sanchez Prada.
114
115         * DumpRenderTree/AccessibilityUIElement.cpp:
116         (selectTextWithCriteriaCallback):
117         (isEqualCallback):
118         * DumpRenderTree/AccessibilityUIElement.h:
119         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
120         (AccessibilityUIElement::selectTextWithCriteria):
121         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
122         (AccessibilityUIElement::selectTextWithCriteria):
123         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
124         (selectTextParameterizedAttributeForCriteria):
125         (AccessibilityUIElement::selectTextWithCriteria):
126         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
127         (AccessibilityUIElement::selectTextWithCriteria):
128         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
129         (WTR::AccessibilityUIElement::selectTextWithCriteria):
130         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
131         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
132         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
133         (WTR::AccessibilityUIElement::selectTextWithCriteria):
134         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
135         (WTR::AccessibilityUIElement::selectTextWithCriteria):
136         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
137         (WTR::selectTextParameterizedAttributeForCriteria):
138         (WTR::AccessibilityUIElement::selectTextWithCriteria):
139
140 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
141
142         [SOUP] TLSErrors do not cause page load to fail when not ignored
143         https://bugs.webkit.org/show_bug.cgi?id=121548
144
145         Reviewed by Sergio Villar Senin.
146
147         Add unit tests to check that the load fails with TLS errors in
148         case of a redirection.
149
150         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
151         (testTLSErrorsRedirect):
152         (httpsServerCallback):
153         (beforeAll):
154
155 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
156
157         [CSS Grid Layout] Remove runtime feature
158         https://bugs.webkit.org/show_bug.cgi?id=132382
159
160         Reviewed by Benjamin Poulain.
161
162         Remove cssGridLayoutEnabled setting usage.
163
164         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
165         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
166         * DumpRenderTree/efl/TestRunnerEfl.cpp:
167         (TestRunner::overridePreference):
168         * DumpRenderTree/mac/DumpRenderTree.mm:
169         (resetWebPreferencesToConsistentValues):
170
171 2014-05-06  David Kilzer  <ddkilzer@apple.com>
172
173         Add Makefile targets for copying static libraries (LLVM and WKSI)
174         <http://webkit.org/b/132619>
175
176         Reviewed by Mark Rowe.
177
178         * Scripts/copy-webkitlibraries-to-product-directory: Set a
179         sensible default for product directory if not specified on
180         either the command-line or in the environment (by Xcode) by
181         calling productDir() in webkitdirs.pm.
182
183 2014-05-06  Brady Eidson  <beidson@apple.com>
184
185         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
186         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
187
188         Reviewed by Sam Weinig.
189
190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
191
192         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
193         (TestWebKitAPI::itemURLLastComponentIsString):
194         (TestWebKitAPI::didFinishLoadForFrame):
195         (TestWebKitAPI::willGoToBackForwardListItem):
196         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
197         (TestWebKitAPI::setPageLoaderClient):
198         (TestWebKitAPI::TEST):
199         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
200         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
201
202         * WebKitTestRunner/TestController.cpp:
203         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
204
205 2014-05-06  Darin Adler  <darin@apple.com>
206
207         Try to fix iOS build.
208
209         * DumpRenderTree/mac/TestRunnerMac.mm:
210         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
211         Updated since I changed testRunner into a pointer instead of a reference.
212         Updated argument names to avoid conflict with field names.
213         (-[APITestDelegateIPhone run]): Ditto.
214         (-[APITestDelegateIPhone _cleanUp]): Ditto.
215
216 2014-05-06  Commit Queue  <commit-queue@webkit.org>
217
218         Unreviewed, rolling out r168304.
219         https://bugs.webkit.org/show_bug.cgi?id=132607
220
221         Broke the build (Requested by KaL on #webkit).
222
223         Reverted changeset:
224
225         "[GTK][CMake] Unable to do make install"
226         https://bugs.webkit.org/show_bug.cgi?id=130188
227         http://trac.webkit.org/changeset/168304
228
229 2014-05-04  Darin Adler  <darin@apple.com>
230
231         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
232         https://bugs.webkit.org/show_bug.cgi?id=80222
233
234         Reviewed by Alexey Proskuryakov.
235
236         * DumpRenderTree/mac/TestRunnerMac.mm:
237         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
238         do more work here so we don't use RetainPtr local variables.
239         (-[APITestDelegateIPhone dealloc]): Added.
240         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
241         created. Updated for changes to member names and types.
242         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
243         updated for changes to member names and types. Changed to two word spelling.
244         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
245         name of _cleanUp method.
246         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
247         Ditto.
248         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
249
250 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
251
252         Clean up Image Document and tweak the layout and viewport
253         https://bugs.webkit.org/show_bug.cgi?id=132552
254
255         Reviewed by Anders Carlsson.
256
257         * DumpRenderTree/mac/DumpRenderTree.mm:
258         (resetWebPreferencesToConsistentValues):
259         Update the default settings to have something consistent with WebKit2.
260
261 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
262
263         [GTK][CMake] Unable to do make install
264         https://bugs.webkit.org/show_bug.cgi?id=130188
265
266         Reviewed by Carlos Garcia Campos.
267
268         * Scripts/webkitdirs.pm:
269         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
270         will give an early signal that a change has broken the documentation.
271
272 2014-05-05  Pratik Solanki  <psolanki@apple.com>
273
274         Update framework locations in package-root
275         https://bugs.webkit.org/show_bug.cgi?id=132571
276
277         Reviewed by Simon Fraser.
278
279         * Scripts/package-root:
280
281 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
282
283         [EFL][WK2] Refactor favicon database APIs
284         https://bugs.webkit.org/show_bug.cgi?id=132519
285
286         Reviewed by Gyuyoung Kim.
287
288         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
289         (update_view_favicon):
290         (on_icon_changed_cb):
291         (window_free):
292         (on_url_changed):
293         (window_create):
294         (on_view_favicon_changed): Deleted.
295
296 2014-05-02  Mark Rowe  <mrowe@apple.com>
297
298         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
299
300         Reviewed by Dan Bernstein.
301
302         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
303         when determining which LLVM archive to extract.
304
305 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
306
307         Add Jeremy as a committer.
308         https://bugs.webkit.org/show_bug.cgi?id=132492
309
310         Reviewed by Jer Noble.
311
312         Add myself as a committer.
313
314         * Scripts/webkitpy/common/config/contributors.json:
315
316 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
317
318         Add Jeremy as a committer.
319         https://bugs.webkit.org/show_bug.cgi?id=132492
320
321         Reviewed by Jer Noble.
322
323         Add Jeremy Jones to the committers file.
324
325         * Scripts/webkitpy/common/config/contributors.json:
326
327 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
328
329         Hard to figure out how to run a single test with run-api-tests
330         https://bugs.webkit.org/show_bug.cgi?id=116332
331
332         Reviewed by Alexey Proskuryakov.
333
334         * Scripts/run-api-tests: add two examples to the help message.
335
336 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
337
338         Fix several memory leaks found by code inspection
339         https://bugs.webkit.org/show_bug.cgi?id=132472
340
341         Reviewed by Geoffrey Garen.
342         
343         Fix memory leaks.
344
345         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
346         (TestWebKitAPI::TEST):
347         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
348         (WTR::InjectedBundlePage::willSendRequestForFrame):
349         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
350         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
351
352 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
353
354         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
355         https://bugs.webkit.org/show_bug.cgi?id=132446
356
357         Reviewed by Mark Hahnenberg.
358         
359         Test the FTL by default now that it's enabled by default.
360
361         * Scripts/run-javascriptcore-tests:
362
363 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
364
365         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
366         https://bugs.webkit.org/show_bug.cgi?id=132240
367
368         Reviewed by Anders Carlsson.
369
370         Removed ewk_view_setting_tiled_backingstore related code.
371
372         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
373         (DumpRenderTreeChrome::createView):
374         (shouldUseTiledBackingStore): Deleted.
375         * EWebLauncher/main.c:
376         (windowCreate):
377         (parseUserArguments):
378
379 2014-05-01  Anders Carlsson  <andersca@apple.com>
380
381         window.testRunner.keepWebHistory() should update the UI process state
382         https://bugs.webkit.org/show_bug.cgi?id=132440
383
384         Reviewed by Dan Bernstein.
385
386         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
387         (WTR::InjectedBundle::postSetAddsVisitedLinks):
388         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
389         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
390         (WTR::TestRunner::keepWebHistory):
391         * WebKitTestRunner/TestInvocation.cpp:
392         (WTR::TestInvocation::invoke):
393         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
394
395 2014-05-01  David Kilzer  <ddkilzer@apple.com>
396
397         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
398         <http://webkit.org/b/132432>
399
400         Reviewed by Tim Horton.
401
402         * Scripts/webkitperl/FeatureList.pm: Remove support for
403         --plugin-proxy-for-video switch.
404
405 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
406
407         Kernel sysctl interface hw.activecpu don't exists on Linux.
408         https://bugs.webkit.org/show_bug.cgi?id=132286
409
410         Reviewed by Filip Pizlo.
411
412         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
413         calling sysctl over hw.activecpu
414
415 2014-04-30  Anders Carlsson  <andersca@apple.com>
416
417         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
418         https://bugs.webkit.org/show_bug.cgi?id=132399
419         <rdar://problem/15920046>
420
421         Reviewed by Dan Bernstein.
422
423         * Scripts/check-for-webkit-framework-include-consistency:
424         Allos WAK headers in WebKitLegacy as well as WebKit.
425
426         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
427         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
428         Update header imports.
429
430 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
431
432         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
433         https://bugs.webkit.org/show_bug.cgi?id=131954
434
435         Reviewed by Darin Adler.
436         
437         WebKitTestRunner was adding application-specific information to crash reports
438         to log the test path, but only in the web process. Fix it to also do this
439         for the UI process, for both iOS and OS X.
440         
441         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
442         both iOS and OS X.
443         
444         Factored crash reprorter-related code into CrashReporterInfo, and call it from
445         a new TestController::platformWillRunTest() function on Mac and iOS.
446         
447         Also remove Xcode-added unit test junk from the project.
448
449         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
450         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
451         * WebKitTestRunner/TestController.cpp:
452         (WTR::TestController::runTest):
453         * WebKitTestRunner/TestController.h:
454         * WebKitTestRunner/TestInvocation.cpp:
455         (WTR::TestInvocation::url):
456         * WebKitTestRunner/TestInvocation.h:
457         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
458         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
459         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
460         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
461         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
462         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
463         (WTR::testPathFromURL):
464         (WTR::setCrashReportApplicationSpecificInformationToURL):
465         * WebKitTestRunner/efl/TestControllerEfl.cpp:
466         (WTR::TestController::platformWillRunTest):
467         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
468         (WTR::TestController::platformWillRunTest):
469         * WebKitTestRunner/ios/TestControllerIOS.mm:
470         (WTR::TestController::platformWillRunTest):
471         (WTR::TestController::setHidden):
472         * WebKitTestRunner/mac/TestControllerMac.mm:
473         (WTR::TestController::platformWillRunTest):
474
475 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
476
477         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
478
479         Reviewed by Tim Horton.
480
481         * DumpRenderTree/mac/DumpRenderTree.mm:
482         (resetWebPreferencesToConsistentValues):
483         (prepareConsistentTestingEnvironment):
484
485 2014-04-30  Anders Carlsson  <andersca@apple.com>
486
487         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
488         https://bugs.webkit.org/show_bug.cgi?id=132397
489
490         Reviewed by Dan Bernstein.
491
492         * Scripts/check-for-inappropriate-macros-in-external-headers:
493
494 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
495
496         [GTK] Make it easier to run CMake for downstreams
497         https://bugs.webkit.org/show_bug.cgi?id=132370
498
499         Reviewed by Carlos Garcia Campos.
500
501         * Scripts/webkitdirs.pm:
502         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
503         the GTK+ port.
504
505 2014-04-29  Stephanie Lewis  <slewis@apple.com>
506
507         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
508         
509         Rubber stamped by Jessie Berlin.
510
511         JSON.pm was removed from our tools setup.
512
513         * Scripts/generate-coverage-data:
514
515 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
516
517         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
518         https://bugs.webkit.org/show_bug.cgi?id=112840
519
520         Rubber stamped by Geoffrey Garen.
521
522         * Scripts/build-jsc: Enable it on Mac.
523         * Scripts/build-webkit: Enable it on Mac.
524         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
525
526 2014-04-28  Sam Weinig  <sam@webkit.org>
527
528         REGRESSION (r167751): svn-create-patch is very slow
529         https://bugs.webkit.org/show_bug.cgi?id=132300
530
531         Reviewed by Alexey Proskuryakov.
532
533         * Scripts/svn-create-patch:
534         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
535         by calling `svn-create-patch --style`.
536
537 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
538
539         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
540         https://bugs.webkit.org/show_bug.cgi?id=132190
541
542         Reviewed by Gustavo Noronha Silva.
543
544         * Scripts/webkitdirs.pm:
545         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
546             if ninja is in the path.
547         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
548             to the previous ninja generator if not.
549
550 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
551
552         check-webkit-style should understand --git-index
553         https://bugs.webkit.org/show_bug.cgi?id=125364
554
555         Reviewed by Csaba Osztrogonác.
556
557         * Scripts/webkitpy/common/checkout/scm/git.py:
558         (Git.create_patch): The command now supports the --cached option.
559         * Scripts/webkitpy/style/main.py:
560         (CheckWebKitStyle.main): Passing the --git-index option.
561         * Scripts/webkitpy/style/optparser.py:
562         (CommandOptionValues.__init__): The git-index option is switched off by default.
563         (CommandOptionValues.__eq__): Equality check for the new option.
564         (ArgumentParser._create_option_parser):Adding the --git-index option
565         (ArgumentParser.parse):
566         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
567         (CommandOptionValuesTest.test_init): 
568         (CommandOptionValuesTest.test_eq):
569
570 2014-04-28  Michael Saboff  <msaboff@apple.com>
571
572         Crash in platform/mac/accessibility/table-visible-rows.html
573         https://bugs.webkit.org/show_bug.cgi?id=132146
574
575         Reviewed by Filip Pizlo.
576
577         Instead of creating a local JSValueRef array on the stack and passing that to
578         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
579         values using the JSObjectSetPropertyAtIndex() API.
580
581         * DumpRenderTree/AccessibilityUIElement.cpp:
582         (elementsForRangeCallback):
583         (convertElementsToObjectArray):
584         * DumpRenderTree/mac/TestRunnerMac.mm:
585         (originsArrayToJS):
586         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
587         (WTR::EventSendingController::contextClick):
588         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
589         (WTR::stringArrayToJS):
590         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
591         (WTR::convertElementsToObjectArray):
592
593 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
594
595         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
596         "no-cjit" runs force the old-school threshold.
597
598         Rubber stamped by Mark Hahnenberg.
599
600         * Scripts/run-jsc-stress-tests:
601
602 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
603
604         [GTK] install-dependencies should also install ruby-json and ruby-highline
605         https://bugs.webkit.org/show_bug.cgi?id=132292
606
607         Reviewed by Philippe Normand.
608
609         * gtk/install-dependencies: Install ruby json and highline packages.
610
611 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
612
613         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
614         https://bugs.webkit.org/show_bug.cgi?id=132176
615
616         Reviewed by Gyuyoung Kim.
617
618         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
619         and turn off indexedDB feature until the sqlite implementation is introduced.
620
621         * Scripts/webkitperl/FeatureList.pm:
622
623 2014-04-25  James Craig  <jcraig@apple.com>
624
625         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
626         https://bugs.webkit.org/show_bug.cgi?id=132209
627
628         Reviewed by Daniel Bates.
629
630         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
631         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
632
633         * Scripts/prepare-ChangeLog:
634         (main): 
635
636 2014-04-25  Michael Saboff  <msaboff@apple.com>
637
638         Crash in platform/mac/accessibility/table-visible-rows.html
639         https://bugs.webkit.org/show_bug.cgi?id=132146
640
641         Reviewed by Mark Lam.
642
643         Changed to use a local JSValueRef array temporary instead of a
644         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
645         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
646         the temporary values could be collected.
647
648         * DumpRenderTree/AccessibilityUIElement.cpp:
649         (convertElementsToObjectArray):
650         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
651         (WTR::EventSendingController::contextClick):
652         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
653         (WTR::convertElementsToObjectArray):
654
655 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
656
657         Unreviewed GTK gardening
658
659         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
660         (TestRunner):
661
662 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
663
664         prepare-ChangeLog reports as deleted methods that has not been removed.
665         https://bugs.webkit.org/show_bug.cgi?id=131733
666
667         Reviewed by Ryosuke Niwa.
668
669         * Scripts/prepare-ChangeLog:
670         (originalFile): Set merge base to origin/master by default.
671
672 2014-04-23  James Craig  <jcraig@apple.com>
673
674         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
675         https://bugs.webkit.org/show_bug.cgi?id=131115
676
677         Reviewed by Daniel Bates.
678
679         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
680
681         * Scripts/commit-log-editor: Added --no-style.
682         * Scripts/prepare-ChangeLog: Primary patch.
683         (main): Primary patch.
684         (createPatchCommand): Added --no-style.
685         * Scripts/svn-create-patch: Primary patch.
686         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
687         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
688         (SVN.create_patch): Added --no-style.
689
690 2014-04-23  Anders Carlsson  <andersca@apple.com>
691
692         Try to fix iOS build.
693
694         * DumpRenderTree/mac/DumpRenderTree.mm:
695
696 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
697
698         Eliminate internals.setMockScrollbarsEnabled()
699         https://bugs.webkit.org/show_bug.cgi?id=132085
700
701         Reviewed by Tim Horton.
702
703         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
704         No need to reset the preference, there is no way it can change.
705
706 2014-04-23  James Craig  <jcraig@apple.com>
707
708         Unreviewed. Moving myself from Contributors to Committers list.
709
710         * Scripts/webkitpy/common/config/contributors.json:
711
712 2014-04-23  Tim Horton  <timothy_horton@apple.com>
713
714         Mock scrollbars don't always work in DumpRenderTree
715         https://bugs.webkit.org/show_bug.cgi?id=132082
716
717         Reviewed by Alexey Proskuryakov.
718
719         * DumpRenderTree/mac/DumpRenderTree.mm:
720         (prepareConsistentTestingEnvironment):
721         Set the mock scrollbar setting before creating the WebView, as this setting
722         cannot be dynamically changed, so any scrollbars that are created during
723         WebView initialization and are not replaced before snapshotting will end
724         up being platform scrollbars instead of mock ones.
725         WebKitTestRunner already sets this preference before creating WKViews,
726         so we're just matching its behavior.
727
728 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
729
730         [GTK] ShadowRoot API was removed in r164131
731         https://bugs.webkit.org/show_bug.cgi?id=132059
732
733         Reviewed by Gustavo Noronha Silva.
734
735         Add WebKitDOMShadowRoot to the list of deleted classes to generate
736         the API docs.
737
738         * gtk/webkitdom.py:
739         (WebKitDOMDocGenerator):
740
741 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
742
743         [GTK] run-webkit-tests script is failing to invoke run-launcher
744         https://bugs.webkit.org/show_bug.cgi?id=132051
745
746         Reviewed by Philippe Normand.
747
748         After the WK1 support was dropped, if run-webkit-tests is executed
749         without --no-show-results parameter, the launcher is being called
750         using a -2 parameter that is it causing the run-launcher to break.
751
752         * Scripts/webkitpy/port/gtk.py:
753         (GtkPort.show_results_html_file):
754
755 2014-04-22  Tim Horton  <timothy_horton@apple.com>
756
757         DumpRenderTree generates black snapshots on some platforms
758         https://bugs.webkit.org/show_bug.cgi?id=132029
759         <rdar://problem/16679363>
760
761         Reviewed by Simon Fraser.
762
763         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
764         (createBitmapContextFromWebView):
765         DRT checks with the WebView to determine whether it can use the window's
766         backing store directly or (because of compositing) needs to take a WindowServer
767         snapshot. However, on some platforms and in some situations, the window can
768         be layer backed without the WebView necessarily currently being composited.
769         We should check with the window in addition to the WebView before going
770         ahead and using its backing store.
771
772 2014-04-22  Tim Horton  <timothy_horton@apple.com>
773
774         DumpRenderTree generates white snapshots on some platforms
775         https://bugs.webkit.org/show_bug.cgi?id=132026
776         <rdar://problem/16679363>
777
778         Reviewed by Simon Fraser.
779
780         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
781         Link DRT against QuartzCore.
782
783         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
784         (createBitmapContextFromWebView):
785         Force CoreAnimation to synchronously update layers in a more explicit
786         way that doesn't depend on AppKit behavior. This is very similar to what
787         WebKitTestRunner does (indirectly) during its force repaint.
788
789 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
790
791         [Win] Support Python 2.7 in Cygwin
792         https://bugs.webkit.org/show_bug.cgi?id=132023
793
794         Reviewed by Michael Saboff.
795
796         * Scripts/webkitdirs.pm:
797         (checkInstalledTools): Remove check for Python 2.7, since
798         it now works properly.
799
800 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
801
802         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
803         https://bugs.webkit.org/show_bug.cgi?id=130867
804         <rdar://problem/16432456> 
805
806         Reviewed by Mark Hahnenberg.
807
808         * Scripts/build-webkit:
809         * Scripts/copy-webkitlibraries-to-product-directory:
810
811 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
812
813         [GTK] Fails to build documentation when output is redirected
814         https://bugs.webkit.org/show_bug.cgi?id=131178
815
816         Reviewed by Martin Robinson.
817
818         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
819         explicitly to avoid encoding issues when they are redirected.
820
821 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
822
823         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
824         https://bugs.webkit.org/show_bug.cgi?id=131911
825
826         Reviewed by Martin Robinson.
827
828         common.get_build_path returns release path even though Debug configuration
829         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
830
831         * gtk/ycm_extra_conf.py:
832         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
833         (FlagsForFile):
834
835 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
836
837         Unreviewed build fix.
838
839         * DumpRenderTree/mac/EventSendingController.mm:
840         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
841         Correct a typo that prevented tests from working properly.
842
843 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
844
845         [GTK] Should have the ability to output composited contents during layout testing
846         https://bugs.webkit.org/show_bug.cgi?id=131864
847
848         Reviewed by Philippe Normand.
849
850         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
851         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
852         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
853         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
854         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
855
856 2014-04-21  Sam Weinig  <sam@webkit.org>
857
858         Attempt to fix the tests.
859
860         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
861         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
862         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
863
864 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
865
866         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
867         being the same as a "quick run", which is meant for genuinely slow tests).
868
869         * Scripts/run-jsc-stress-tests:
870
871 2014-04-21  Darin Adler  <darin@apple.com>
872
873         Add HashSet::takeAny
874         https://bugs.webkit.org/show_bug.cgi?id=131928
875
876         Reviewed by Benjamin Poulain.
877
878         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
879
880 2014-04-20  Dan Bernstein  <mitz@apple.com>
881
882         Fixed a test timing out after r167572.
883
884         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
885         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
886         -webView:didFinishLoadingNavigation:.
887
888 2014-04-20  Commit Queue  <commit-queue@webkit.org>
889
890         Unreviewed, rolling out r167510.
891         https://bugs.webkit.org/show_bug.cgi?id=131915
892
893         broke GTK Debug bot (Requested by philn on #webkit).
894
895         Reverted changeset:
896
897         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
898         it when running layout tests"
899         https://bugs.webkit.org/show_bug.cgi?id=131472
900         http://trac.webkit.org/changeset/167510
901
902 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
903
904         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
905         https://bugs.webkit.org/show_bug.cgi?id=131472
906
907         Reviewed by Philippe Normand.
908
909         * Scripts/webkitpy/port/gtk.py:
910         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
911         when running WebKitTestRunner with run-webkit-tests.
912         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
913         installed.
914         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
915         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
916         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
917         deal.
918
919 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
920
921         DownloadDecideDestinationCrash API test uses an incorrect value for path
922         https://bugs.webkit.org/show_bug.cgi?id=131845
923         <rdar://problem/15925560>
924
925         Reviewed by Enrica Casucci.
926
927         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
928         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
929
930 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
931
932         [Mac] AttributedStringTest API tests fail with async text input
933         https://bugs.webkit.org/show_bug.cgi?id=131833
934
935         Reviewed by Enrica Casucci.
936
937         Don't run sync NSTextInputClient tests where we don't implement these calls.
938
939         * TestWebKitAPI/Tests/mac/AttributedString.mm:
940         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
941         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
942         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
943         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
944         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
945         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
946
947 2014-04-18  Philippe Normand  <pnormand@igalia.com>
948
949         Remove NETWORK_INFO support
950         https://bugs.webkit.org/show_bug.cgi?id=131841
951
952         Reviewed by Gyuyoung Kim.
953
954         * Scripts/webkitperl/FeatureList.pm:
955
956 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
957
958         [GTK] YouCompleteMe doesn't work for cmake build system.
959         https://bugs.webkit.org/show_bug.cgi?id=131591
960
961         Reviewed by Martin Robinson.
962
963         Add cmake build system support for YouCompleteMe. It should work regardless of
964         using make or ninja. In addition, autotools related code is removed since it's
965         not used anymore in WebKit.
966
967         * Scripts/webkitdirs.pm:
968         (generateBuildSystemFromCMakeProject):
969         * gtk/ycm_extra_conf.py:
970         (transform_relative_paths_to_absolute_paths):
971         (FlagsForFile):
972
973 2014-04-17  Anders Carlsson  <andersca@apple.com>
974
975         Fix build.
976
977         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
978         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
979         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
980
981 2014-04-17  Anders Carlsson  <andersca@apple.com>
982
983         Remove unused API enums
984         https://bugs.webkit.org/show_bug.cgi?id=131836
985
986         Reviewed by Tim Horton.
987
988         * MiniBrowser/mac/WK2BrowserWindowController.m:
989         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
990
991 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
992
993         [Win] A few final cleanups to the DataObject classes.
994         https://bugs.webkit.org/show_bug.cgi?id=131784
995
996         Reviewed by Anders Carlsson.
997
998         * DumpRenderTree/win/DRTDataObject.cpp:
999         (DRTDataObject::clearData): Use 'last()' method.
1000         * DumpRenderTree/win/UIDelegate.cpp:
1001         (DRTUndoStack::pop): Use 'takeLast()' method.
1002
1003 2014-04-17  Andres Gomez  <agomez@igalia.com>
1004
1005         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
1006         https://bugs.webkit.org/show_bug.cgi?id=131365
1007
1008         Reviewed by Brent Fulgham.
1009
1010         The cygwin installer is now downloading the wanted versions for
1011         the local installation given to the setup wizard.
1012
1013         * CygwinDownloader/cygwin-downloader.py:
1014         * CygwinDownloader/cygwin-downloader.zip:
1015
1016 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
1017
1018         [GTK] Make run-webkit-tests always use WKTR
1019         https://bugs.webkit.org/show_bug.cgi?id=131737
1020
1021         Reviewed by Darin Adler.
1022
1023         Now that the GTK+ port only has support for WebKit2, instruct
1024         run-webkit-tests to always use WKTR. This avoids needing to pass
1025         flag "-2" every time.
1026
1027         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
1028         (_set_up_derived_options): Always set webkit_test_runner when
1029         the platform is GTK+.
1030
1031 2014-04-17  Brendan Long  <b.long@cablelabs.com>
1032
1033         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
1034         https://bugs.webkit.org/show_bug.cgi?id=131760
1035
1036         Reviewed by Philippe Normand.
1037
1038         * gtk/install-dependencies: Install ninja-build when it's available.
1039
1040 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
1041
1042         [Win] run-javascriptcore-tests fails to run.
1043         https://bugs.webkit.org/show_bug.cgi?id=131761
1044
1045         Reviewed by Brent Fulgham.
1046
1047         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
1048
1049 2014-04-16  Andres Gomez  <agomez@igalia.com>
1050
1051         [Win] Pass default parameters to cygwin setup wizard
1052         https://bugs.webkit.org/show_bug.cgi?id=131361
1053
1054         Reviewed by Brent Fulgham.
1055
1056         Added some parameters to the cygwin setup wizard so the user
1057         doesn't really have to do any interaction.
1058
1059         * CygwinDownloader/cygwin-downloader.py:
1060         * CygwinDownloader/cygwin-downloader.zip:
1061
1062 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
1063
1064         [Win] Eliminate use of deleteAllValues in Windows Files
1065         https://bugs.webkit.org/show_bug.cgi?id=131631
1066
1067         Reviewed by Darin Adler.
1068
1069         Switch to std::unique_ptr for memory lifetime. Get rid of
1070         deleteAllValues now that it is no longer needed. Use ranged
1071         for loops where possible.
1072
1073         * DumpRenderTree/win/DRTDataObject.cpp:
1074         (WCEnumFormatEtc::WCEnumFormatEtc):
1075         (DRTDataObject::~DRTDataObject):
1076         (DRTDataObject::GetData):
1077         (DRTDataObject::QueryGetData):
1078         (DRTDataObject::SetData):
1079         (DRTDataObject::clearData):
1080         * DumpRenderTree/win/DRTDataObject.h:
1081         * DumpRenderTree/win/UIDelegate.cpp:
1082         (DRTUndoObject::DRTUndoObject):
1083         (DRTUndoObject::~DRTUndoObject):
1084         (DRTUndoStack::~DRTUndoStack):
1085         (DRTUndoStack::clear):
1086         (DRTUndoStack::pop):
1087         (DRTUndoManager::DRTUndoManager):
1088         (DRTUndoManager::redo):
1089         (DRTUndoManager::undo):
1090         (UIDelegate::UIDelegate):
1091         (UIDelegate::resetUndoManager):
1092         * DumpRenderTree/win/UIDelegate.h:
1093
1094 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1095
1096         [GTK] Unreviewed GTK gardening.
1097
1098         Update list of skipped unit tests:
1099
1100           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
1101
1102           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
1103           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
1104
1105         * Scripts/run-gtk-tests:
1106         (TestRunner):
1107
1108 2014-04-16  Tim Horton  <timothy_horton@apple.com>
1109
1110         check-webkit-style doesn't check code style in .mm or .m files
1111         https://bugs.webkit.org/show_bug.cgi?id=131708
1112
1113         Reviewed by Darin Adler.
1114
1115         * Scripts/webkitpy/style/checker.py:
1116         * Scripts/webkitpy/style/checker_unittest.py:
1117         (CheckerDispatcherDispatchTest.test_cpp_paths):
1118         (CheckerDispatcherDispatchTest.test_text_paths):
1119         Check .mm and .m files as C++.
1120
1121         * Scripts/webkitpy/style/checkers/cpp.py:
1122         (check_spacing):
1123         Add an override for our ordinary "missing spaces around =" for @synthesize,
1124         which should look like "@synthesize propertyName=_varName;"
1125
1126         Add an override for "missing space before {" for blocks' "^{".
1127
1128         Don't follow the "extra space before [" rule for Objective-C, because
1129         it breaks this rule in a multitude of ways because of method calls.
1130
1131         (check_braces):
1132         Don't complain about { not being on the end of the previous line if
1133         the previous line starts with "- (" or "+ (", which would indicate a
1134         Objective-C method definition.
1135
1136 2014-04-16  Darin Adler  <darin@apple.com>
1137
1138         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
1139         https://bugs.webkit.org/show_bug.cgi?id=131735
1140
1141         Reviewed by Alexey Proskuryakov.
1142
1143         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
1144         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
1145         is on the right. This can be confusing since our JavaScript test framework does it the opposite
1146         way, but gtest works better this way.
1147
1148 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
1149
1150         [EFL] Fix problems with the pixel dump.
1151         https://bugs.webkit.org/show_bug.cgi?id=131265
1152
1153         Reviewed by Gyuyoung Kim.
1154
1155         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
1156         However pixel dump codes still call deprecated functions like ewk_view_paint(),
1157         which causes that nothing is drawn.
1158
1159         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
1160         One of new functions is AcceleratedCompositingContext::extractImageData(),
1161         which replaces deprecated function calls. Besides the extractImageData() is invoked by
1162         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
1163
1164         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1165         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
1166
1167 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
1168
1169         Update LLVM export scrpt to handle the build directory being different from the
1170         source directory.
1171
1172         Rubber stamped by Geoffrey Garen.
1173
1174         * Scripts/export-llvm-build:
1175
1176 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
1177
1178         Update the hyperlink to waterfall views of perf bots on build.webkit.org
1179         https://bugs.webkit.org/show_bug.cgi?id=131695
1180
1181         Reviewed by Antti Koivisto.
1182
1183         Updated.
1184
1185         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1186
1187 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1188
1189         [GTK] Reduce the binary size by compressing the text based web inspector resources
1190         https://bugs.webkit.org/show_bug.cgi?id=121545
1191
1192         Reviewed by Gustavo Noronha Silva.
1193
1194         Compress text based files when compiling inspector resources. It
1195         reduces the binary size in 3MB.
1196
1197         * gtk/generate-inspector-gresource-manifest.py:
1198         (find_all_files_in_directory):
1199         (is_compressible):
1200
1201 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1202
1203         Remove Gtk WebKit1 tester.
1204
1205         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
1206         results over and over as fast as it could.
1207
1208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1209         (WebKitBuildbot):
1210
1211 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1212
1213         Wrong link for webkitpy tests results in dashboard popover
1214         https://bugs.webkit.org/show_bug.cgi?id=131664
1215
1216         Reviewed by Timothy Hatcher.
1217
1218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1219         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
1220         Use a correct link.
1221
1222 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1223
1224         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
1225
1226         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
1227
1228         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1229         (CommitMessageForThisCommitTest):
1230
1231 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1232
1233         Fix commit-log-editor bug revealed by r165447
1234         https://bugs.webkit.org/show_bug.cgi?id=130676
1235
1236         Reviewed by Csaba Osztrogonác.
1237
1238         * Scripts/commit-log-editor:
1239         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
1240         Add \n before the first block too, because the longest common prefix now ends with only one newline.
1241         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
1242         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
1243
1244 2014-04-13  Darin Adler  <darin@apple.com>
1245
1246         userVisibleString should not try to "encode" host names
1247         https://bugs.webkit.org/show_bug.cgi?id=131587
1248         rdar://problem/14686849
1249
1250         Reviewed by Alexey Proskuryakov.
1251
1252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
1253
1254         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
1255         Coverage is tiny at this point; we could add a lot more cases!
1256
1257 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1258
1259         Use #include instead of #import
1260         https://bugs.webkit.org/show_bug.cgi?id=131604
1261
1262         Reviewed by Darin Adler.
1263
1264         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
1265
1266         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1267
1268 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
1269
1270         Make slow-stress tests run faster by running fewer VM variants.
1271
1272         Rubber stamped by Geoffrey Garen.
1273
1274         * Scripts/run-javascriptcore-tests:
1275         * Scripts/run-jsc-stress-tests:
1276
1277 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
1278
1279         [CMake] Add missing WTF unit tests
1280         https://bugs.webkit.org/show_bug.cgi?id=131459
1281
1282         Reviewed by Martin Robinson.
1283
1284         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1285         that should be compiled into the TestWTF binary.
1286
1287 2014-04-10  Brendan Long  <b.long@cablelabs.com>
1288
1289         [Gtk] run-launcher doesn't work by default
1290         https://bugs.webkit.org/show_bug.cgi?id=131494
1291
1292         Reviewed by Philippe Normand.
1293
1294         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1295         * Scripts/webkitdirs.pm:
1296         (launcherName): Same.
1297         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1298         * gtk/common.py:
1299         (get_build_path.is_valid_build_directory): Same.
1300         * gtk/manifest.txt: Same.
1301
1302 2014-04-09  Commit Queue  <commit-queue@webkit.org>
1303
1304         Unreviewed, rolling out r167046.
1305         https://bugs.webkit.org/show_bug.cgi?id=131479
1306
1307         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1308         on #webkit).
1309
1310         Reverted changeset:
1311
1312         "Remove "System Font" from whitelisted DRT fonts and char
1313         width calculations"
1314         https://bugs.webkit.org/show_bug.cgi?id=131411
1315         http://trac.webkit.org/changeset/167046
1316
1317 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1318
1319         Remove "System Font" from whitelisted DRT fonts and char width calculations
1320         https://bugs.webkit.org/show_bug.cgi?id=131411
1321
1322         Reviewed by Tim Horton.
1323
1324         Covered by existing tests.
1325
1326         * DumpRenderTree/mac/DumpRenderTree.mm:
1327         (allowedFontFamilySet):
1328
1329 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1330
1331         systemHiddenFontFamilySet in DRT is unnecessary
1332         https://bugs.webkit.org/show_bug.cgi?id=131414
1333
1334         Reviewed by Tim Horton.
1335
1336         It doesn't seem to affect test results on my machine.
1337
1338         * DumpRenderTree/mac/DumpRenderTree.mm:
1339         (drt_NSFontManager_availableFonts):
1340         (systemHiddenFontFamilySet): Deleted.
1341
1342 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1343
1344         [Win] Unreviewed test fix: Don't double-release BSTR.
1345
1346         * DumpRenderTree/win/DumpRenderTree.cpp:
1347         (dump): Remove unneeded call to SysFreeString now that we are
1348         using _bstr_t for this variable.
1349
1350 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1351
1352         [Win] Various DumpRenderTree Fixes.
1353         https://bugs.webkit.org/show_bug.cgi?id=131446.
1354
1355         Reviewed by Tim Horton.
1356
1357         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1358         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1359         (AccessibilityUIElement::description): Ditto.
1360         (AccessibilityUIElement::helpText): Ditto.
1361         (AccessibilityUIElement::intValue): Ditto.
1362         (AccessibilityUIElement::isPressActionSupported): Ditto.
1363         (AccessibilityUIElement::accessibilityValue): Ditto.
1364         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1365         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1366         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1367         (DRTDesktopNotificationPresenter::Release): Ditto.
1368         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1369         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1370         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1371         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1372         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1373         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1374         * DumpRenderTree/win/DumpRenderTree.cpp:
1375         (dumpFrameScrollPosition): Ditto.
1376         (dumpFramesAsText): Ditto.
1377         (compareHistoryItems): Ditto.
1378         (dumpHistoryItem): Ditto.
1379         (dump): Ditto.
1380         (resetDefaultsToConsistentValues): Ditto.
1381         (resetWebViewToConsistentStateBeforeTesting): Ditto.
1382         (runTest): Ditto.
1383         (createWebViewAndOffscreenWindow): Ditto.
1384         * DumpRenderTree/win/EditingDelegate.cpp:
1385         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1386         (EditingDelegate::AddRef): Ditto.
1387         (EditingDelegate::Release): Ditto.
1388         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
1389         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
1390         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1391         (EditingDelegate::shouldInsertNode): Ditto.
1392         (EditingDelegate::shouldInsertText): Ditto.
1393         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1394         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1395         (EditingDelegate::shouldApplyStyle): Ditto.
1396         (EditingDelegate::shouldChangeTypingStyle): Ditto.
1397         (EditingDelegate::doPlatformCommand): Ditto.
1398         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1399         (EditingDelegate::webViewDidChange): Ditto.
1400         (EditingDelegate::webViewDidEndEditing): Ditto.
1401         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
1402         (EditingDelegate::webViewDidChangeSelection): Ditto.
1403         (EditingDelegate::checkSpellingOfString): Ditto.
1404         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1405         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1406         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
1407         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1408         (FrameLoadDelegate::AddRef): Ditto.
1409         (FrameLoadDelegate::Release): Ditto.
1410         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1411         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
1412         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
1413         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
1414         (FrameLoadDelegate::didReceiveTitle): Ditto.
1415         (FrameLoadDelegate::didChangeIcons): Ditto.
1416         (delegatesWithDelayedWork): Ditto.
1417         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
1418         (FrameLoadDelegate::didFailLoadWithError): Ditto.
1419         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
1420         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
1421         (FrameLoadDelegate::willCloseFrame): Ditto.
1422         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
1423         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
1424         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1425         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
1426         (FrameLoadDelegate::didRunInsecureContent): Ditto.
1427         * DumpRenderTree/win/FrameLoadDelegate.h:
1428         * DumpRenderTree/win/HistoryDelegate.cpp:
1429         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1430         (HistoryDelegate::updateHistoryTitle): Ditto.
1431         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
1432         * DumpRenderTree/win/PolicyDelegate.cpp:
1433         (dumpPath):
1434         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1435         (PolicyDelegate::AddRef): Ditto.
1436         (PolicyDelegate::Release): Ditto.
1437         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1438         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
1439         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1440         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1441         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1442         (ResourceLoadDelegate::AddRef): Ditto.
1443         (ResourceLoadDelegate::Release): Ditto.
1444         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1445         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
1446         (ResourceLoadDelegate::willSendRequest): Ditto.
1447         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
1448         (ResourceLoadDelegate::didReceiveResponse): Ditto.
1449         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
1450         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
1451         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1452         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1453         (TestRunner::setUserStyleSheetLocation): Ditto.
1454         (TestRunner::execCommand): Ditto.
1455         (TestRunner::overridePreference): Ditto.
1456         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
1457         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
1458         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1459         (TextInputController::insertText): Ditto.
1460         * DumpRenderTree/win/UIDelegate.cpp:
1461         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1462         (UIDelegate::AddRef): Ditto.
1463         (UIDelegate::Release): Ditto.
1464         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1465         (UIDelegate::trackCustomPopupMenu): Ditto.
1466         (UIDelegate::registerUndoWithTarget): Ditto.
1467         (UIDelegate::removeAllActionsWithTarget): Ditto.
1468         (UIDelegate::setActionTitle): Ditto.
1469         (UIDelegate::undo): Ditto.
1470         (UIDelegate::redo): Ditto.
1471         (UIDelegate::canUndo): Ditto.
1472         (UIDelegate::canRedo): Ditto.
1473         (UIDelegate::printFrame): Ditto.
1474         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
1475         (UIDelegate::webViewHeaderHeight): Ditto.
1476         (UIDelegate::webViewFooterHeight): Ditto.
1477         (UIDelegate::drawHeaderInRect): Ditto.
1478         (UIDelegate::drawFooterInRect): Ditto.
1479         (UIDelegate::webViewPrintingMarginRect): Ditto.
1480         (UIDelegate::canRunModal): Ditto.
1481         (UIDelegate::createModalDialog): Ditto.
1482         (UIDelegate::runModal): Ditto.
1483         (UIDelegate::isMenuBarVisible): Ditto.
1484         (UIDelegate::setMenuBarVisible): Ditto.
1485         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
1486         (UIDelegate::paintCustomScrollbar): Ditto.
1487         (UIDelegate::paintCustomScrollCorner): Ditto.
1488         (UIDelegate::setFrame): Ditto.
1489         (UIDelegate::webViewFrame): Ditto.
1490         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
1491         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1492         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1493         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1494         (UIDelegate::webViewAddMessageToConsole): Ditto.
1495         (UIDelegate::doDragDrop): Ditto.
1496         (UIDelegate::webViewGetDlgCode): Ditto.
1497         (UIDelegate::createWebViewWithRequest): Ditto.
1498         (UIDelegate::webViewClose): Ditto.
1499         (UIDelegate::webViewFocus): Ditto.
1500         (UIDelegate::webViewUnfocus): Ditto.
1501         (UIDelegate::webViewPainted): Ditto.
1502         (UIDelegate::exceededDatabaseQuota): Ditto.
1503         (UIDelegate::embeddedViewWithArguments): Ditto.
1504         (UIDelegate::webViewClosing): Ditto.
1505         (UIDelegate::webViewSetCursor): Ditto.
1506         (UIDelegate::webViewDidInvalidate): Ditto.
1507         (UIDelegate::setStatusText): Ditto.
1508         (UIDelegate::desktopNotificationsDelegate): Ditto.
1509         (UIDelegate::drawBackground): Ditto.
1510         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
1511         (UIDelegate::didPressMissingPluginButton): Ditto.
1512         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
1513         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
1514         (LoadHTMLStringItem::invoke): Ditto.
1515         (ScriptItem::invoke): Ditto.
1516
1517 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1518
1519         Stylechecker: False positive on inline asm code.
1520         https://bugs.webkit.org/show_bug.cgi?id=130570
1521
1522         Reviewed by Csaba Osztrogonác.
1523
1524         Disable stylechecking in asm blocks.
1525
1526         * Scripts/webkitpy/style/checkers/cpp.py:
1527         (process_line):
1528         (_InlineASMState):
1529         (_InlineASMState.__init__):
1530         (_InlineASMState.process_line):
1531         (_InlineASMState.isInside):
1532         (_process_lines):
1533         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1534         (WebKitStyleTest.test_member_initialization_list):
1535
1536 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1537
1538         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
1539         https://bugs.webkit.org/show_bug.cgi?id=131029
1540
1541         Reviewed by Philippe Normand.
1542
1543         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
1544         tests and remove the getWebKit1TestResoucesDir() method.
1545
1546         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1547         (testDownloadLocalFile): Use Test::getResourcesDir().
1548         (testDownloadLocalFileError): Ditto.
1549         (serverCallback): Ditto.
1550         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1551         (serverCallback): Ditto.
1552         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1553         (httpServerCallback): Ditto.
1554         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1555         (serverCallback): Ditto.
1556         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
1557         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
1558         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1559         (Test::getWebKit1TestResoucesDir): Deleted.
1560
1561 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1562
1563         [WK2] HTTP authentication regression tests fail
1564         https://bugs.webkit.org/show_bug.cgi?id=81627
1565         <rdar://problem/11079296>
1566
1567         Reviewed by Anders Carlsson.
1568
1569         * WebKitTestRunner/TestController.h:
1570         * WebKitTestRunner/TestController.cpp:
1571         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
1572         to pageLoaderClient structure.
1573         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
1574         for password based authentication (we do get server trust challenges on some tests,
1575         which WKTR can't handle).
1576         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
1577         calls won't be made, at least on CFNetwork based platforms.
1578         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
1579         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
1580         make sense to associate auth requests with individual resources - there can be
1581         multiple resources loading at once from the same protection space, so WebKit1 API
1582         that had a resource identifier was inherently racy.
1583
1584 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
1585
1586         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
1587         https://bugs.webkit.org/show_bug.cgi?id=131427
1588
1589         Reviewed by Gyuyoung Kim.
1590
1591         Since r166973, font path was changed.
1592
1593         * DumpRenderTree/PlatformEfl.cmake:
1594         * WebKitTestRunner/PlatformEfl.cmake:
1595
1596 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1597
1598         Fix the build-jsc build
1599         https://bugs.webkit.org/show_bug.cgi?id=131410
1600
1601         Reviewed by Michael Saboff.
1602
1603         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
1604         WTF depends on it.
1605
1606 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1607
1608         [GTK] Remove WebKit1 unit tests
1609         https://bugs.webkit.org/show_bug.cgi?id=131359
1610
1611         Reviewed by Anders Carlsson.
1612
1613         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
1614         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
1615         they were inadvertently left in http://trac.webkit.org/changeset/166504.
1616
1617         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
1618         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
1619         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
1620         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
1621         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
1622         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
1623         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
1624         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
1625         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
1626         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
1627         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
1628         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
1629         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
1630         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
1631         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
1632         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
1633         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
1634         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
1635         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
1636         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
1637         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
1638         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
1639         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
1640         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
1641         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
1642         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
1643         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
1644         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
1645         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
1646         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
1647         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
1648         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
1649         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
1650         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
1651         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
1652         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
1653         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
1654         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
1655
1656 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1657
1658         Unreviewed gardening (Take 2): Prevent users from attempting
1659         to build with known invalid cURL. 
1660
1661         * Scripts/webkitdirs.pm:
1662         (checkInstalledTools): Check for 7.34.0 (the broken version), not
1663         7.33.0 (the known good version).
1664
1665 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1666
1667         [GTK] Remove DumpRenderTree and GtkLauncher
1668         https://bugs.webkit.org/show_bug.cgi?id=131373
1669
1670         Reviewed by Andreas Kling.
1671
1672         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
1673         no longer necessary now that WebKit1 GTK+ will be removed.
1674
1675         * CMakeLists.txt:
1676         * DumpRenderTree/PlatformGTK.cmake: Removed.
1677         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
1678         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
1679         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
1680         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
1681         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
1682         * DumpRenderTree/gtk/EventSender.cpp: Removed.
1683         * DumpRenderTree/gtk/EventSender.h: Removed.
1684         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
1685         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
1686         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
1687         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
1688         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
1689         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
1690         * DumpRenderTree/gtk/TextInputController.h: Removed.
1691         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
1692         * GtkLauncher/CMakeLists.txt: Removed.
1693         * GtkLauncher/LauncherInspectorWindow.c: Removed.
1694         * GtkLauncher/LauncherInspectorWindow.h: Removed.
1695         * GtkLauncher/main.c: Removed.
1696         * GtkLauncher/simple.svg: Removed.
1697         * GtkLauncher/text.html: Removed.
1698         * WebKitTestRunner/PlatformGTK.cmake:
1699         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
1700         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
1701         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
1702
1703 2014-04-08  Mark Rowe  <mrowe@apple.com>
1704
1705         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
1706         <https://webkit.org/b/131388> / <rdar://problem/16291687>
1707
1708         Reviewed by Alexey Proskuryakov.
1709
1710         * Scripts/webkitdirs.pm:
1711         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
1712         (execMacWebKitAppForDebugging): Ditto.
1713
1714 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1715
1716         Build bmalloc on iOS too
1717         https://bugs.webkit.org/show_bug.cgi?id=131381
1718
1719         Reviewed by Andreas Kling.
1720
1721         * Scripts/build-webkit:
1722
1723 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1724
1725         Unreviewed gardening: Prevent users from attempting
1726         to build with known invalid cURL.
1727
1728         * Scripts/webkitdirs.pm:
1729         (checkInstalledTools): Block build attempts with bad
1730         Cygwin tool set.
1731
1732 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
1733
1734         Build bmalloc on Mac
1735         https://bugs.webkit.org/show_bug.cgi?id=131333
1736
1737         Reviewed by Mark Rowe.
1738
1739         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
1740         (Note: Just testing Mac is not good enough because in this
1741         script 'Mac' means 'Mac or iOS'.)
1742
1743 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
1744
1745         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
1746         https://bugs.webkit.org/show_bug.cgi?id=130951
1747
1748         Reviewed by Geoffrey Garen.
1749
1750         * Scripts/run-javascriptcore-tests:
1751
1752 2014-04-06  Darin Adler  <darin@apple.com>
1753
1754         Rework CSS calc logic, fixing some reference count mistakes in Length
1755         https://bugs.webkit.org/show_bug.cgi?id=131280
1756
1757         Reviewed by Andreas Kling.
1758
1759         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
1760         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
1761
1762 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
1763
1764         Enable WEB_REPLAY for PLATFORM(MAC)
1765         https://bugs.webkit.org/show_bug.cgi?id=130700
1766
1767         Reviewed by Timothy Hatcher.
1768
1769         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
1770
1771 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1772
1773         [CMake] Include X11's include dirs in TestNetscapePlugin
1774         https://bugs.webkit.org/show_bug.cgi?id=131270
1775
1776         Reviewed by Martin Robinson.
1777
1778         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
1779         TestNetscapePlugin includes WebCore code that includes X headers.
1780
1781 2014-04-05  David Kilzer  <ddkilzer@apple.com>
1782
1783         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
1784         <http://webkit.org/b/130986>
1785
1786         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
1787         prefix to TileCache class names in exception list.
1788
1789 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1790
1791         [GTK] kill-old-processes should kill dbus-daemon processes
1792         https://bugs.webkit.org/show_bug.cgi?id=127352
1793
1794         Reviewed by Martin Robinson.
1795
1796         * BuildSlaveSupport/kill-old-processes:
1797         (main):
1798
1799 2014-04-04  Andres Gomez  <agomez@igalia.com>
1800
1801         [Win] Update obsolete packages in cygwin
1802         https://bugs.webkit.org/show_bug.cgi?id=126264
1803
1804         Reviewed by Brent Fulgham.
1805
1806         Removed "apache" and "minires" as the first has been replaced by
1807         "lighttpd" and the second is now integrated into
1808         "cygwin". Replaced the transitional and now obsolete "gcc" package
1809         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
1810         since the newer version available is "2.7.3" which breaks the
1811         build due to some funniness with environment variable handling.
1812
1813         * CygwinDownloader/cygwin-downloader.py:
1814         * CygwinDownloader/cygwin-downloader.zip:
1815
1816 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
1817
1818         check-webkit-style: Improve warnings on Objective-C @property syntax
1819         https://bugs.webkit.org/show_bug.cgi?id=131200
1820
1821         Reviewed by Dan Bernstein.
1822
1823         * Scripts/webkitpy/style/checkers/cpp.py:
1824         (check_spacing):
1825         (CppChecker):
1826         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1827         (CppStyleTest.test_spacing_in_objective_c_properties):
1828
1829 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1830
1831         Unreviewed. Moving my name to commiter section
1832
1833         * Scripts/webkitpy/common/config/contributors.json:
1834
1835 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1836
1837         Unreviewed. Add myself as a committer.
1838
1839         * Scripts/webkitpy/common/config/contributors.json:
1840
1841 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
1842
1843         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
1844         https://bugs.webkit.org/show_bug.cgi?id=130391
1845
1846         Reviewed by Gyuyoung Kim.
1847
1848         Change the implementation of the zoom functionality from ewk_view_scale_set
1849         to ewk_view_page_zoom_set.
1850
1851         * MiniBrowser/efl/main.c:
1852
1853 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1854
1855         [webkitpy] perf profiler does not understand --call-graph argument
1856         https://bugs.webkit.org/show_bug.cgi?id=131132
1857
1858         Reviewed by Ryosuke Niwa.
1859
1860         New versions of perf profiler have changed the argument from --call-graph to -g.
1861
1862         * Scripts/webkitpy/common/system/profiler.py:
1863         (Perf.wrapper_arguments): Use -g instead of --call-graph.
1864         * Scripts/webkitpy/port/driver_unittest.py:
1865         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
1866
1867 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1868
1869         Add EFL WK2 performance bot to build.webkit.org
1870         https://bugs.webkit.org/show_bug.cgi?id=131034
1871
1872         Fix after r166707, use "Perf" instead of "perf" for consistency.
1873
1874         Reviewed by Csaba Osztrogonác.
1875
1876         * BuildSlaveSupport/build.webkit.org-config/config.json:
1877
1878 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1879
1880         Add EFL WK2 performance bot to build.webkit.org
1881         https://bugs.webkit.org/show_bug.cgi?id=131034
1882
1883         Reviewed by Csaba Osztrogonác.
1884
1885         * BuildSlaveSupport/build.webkit.org-config/config.json:
1886
1887 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
1888
1889         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
1890         https://bugs.webkit.org/show_bug.cgi?id=131151
1891
1892         Reviewed by Gyuyoung Kim.
1893
1894         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
1895         (TouchEventInfo::TouchEventInfo):
1896         (sendTouchEvent):
1897         (addTouchPointCallback):
1898         (updateTouchPointCallback):
1899         (cancelTouchPointCallback):
1900         (releaseTouchPointCallback):
1901
1902 2014-04-02  David Kilzer  <ddkilzer@apple.com>
1903
1904         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
1905         <http://webkit.org/b/131045>
1906
1907         Reviewed by Daniel Bates.
1908
1909         * Scripts/filter-build-webkit:
1910         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
1911         of clang, plus debug data for all DVTAssertions.
1912
1913 2014-04-01  Dean Jackson  <dino@apple.com>
1914
1915         Load Media Controls js/css from bundle
1916         https://bugs.webkit.org/show_bug.cgi?id=131086
1917
1918         Reviewed by Eric Carlson.
1919
1920         We're now putting CSS files into the bundle, so remove the test for them.
1921
1922         * Scripts/check-for-inappropriate-files-in-framework:
1923
1924 2014-04-02  Martin Hock  <mhock@apple.com>
1925
1926         Unify private browsing with sessions.
1927         https://bugs.webkit.org/show_bug.cgi?id=130099
1928
1929         Reviewed by Alexey Proskuryakov.
1930
1931         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
1932         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1933         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1934         (TestWebKitAPI::didNavigateWithNavigationData):
1935         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1936         (TestWebKitAPI::TEST):
1937
1938         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
1939         (TestWebKitAPI::didNavigateWithoutNavigationData):
1940         (TestWebKitAPI::didNavigateWithNavigationData):
1941         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1942         (TestWebKitAPI::TEST):
1943
1944 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
1945
1946         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
1947         https://bugs.webkit.org/show_bug.cgi?id=130343
1948
1949         Reviewed by Gustavo Noronha Silva.
1950
1951         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
1952         of directories on the command line and look for all appropriate files in those directories for the
1953         GResource archive. Also make archive paths relative to those directories.
1954         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
1955         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
1956
1957 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1958
1959         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
1960         https://bugs.webkit.org/show_bug.cgi?id=131106
1961
1962         Reviewed by Csaba Osztrogonác.
1963
1964         * Scripts/webkitpy/tool/commands/download.py:
1965         (AbstractRolloutPrepCommand._prepare_state):
1966         * Scripts/webkitpy/tool/commands/download_unittest.py:
1967         (test_prepare_rollout):
1968         (test_create_rollout):
1969         (test_create_rollout_resolved):
1970         (test_rollout):
1971
1972 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
1973
1974         [EFL] Add option to use separate web process for new window in MiniBrowser
1975         https://bugs.webkit.org/show_bug.cgi?id=130190
1976
1977         Reviewed by Gyuyoung Kim.
1978
1979         New created window (CTRL + n) will be open in separated web process.
1980         This option is enabled by adding a flag (S/separate-process) with launching
1981         MiniBrowser.
1982
1983         * MiniBrowser/efl/main.c:
1984         (elm_main):
1985
1986 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1987
1988         [GTK] Move NEWS file to a new location
1989         https://bugs.webkit.org/show_bug.cgi?id=130901
1990
1991         Reviewed by Brent Fulgham.
1992
1993         * gtk/manifest.txt: Update the NEWS file path.
1994
1995 2014-04-01  Anders Carlsson  <andersca@apple.com>
1996
1997         Fix build.
1998
1999         * MiniBrowser/mac/WK2BrowserWindowController.m:
2000         (-[WK2BrowserWindowController awakeFromNib]):
2001         (-[WK2BrowserWindowController dealloc]):
2002         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2003
2004 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
2005
2006         Unreviewed test gardening.
2007
2008         * Scripts/webkitpy/port/base_unittest.py:
2009         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
2010
2011 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
2012
2013         [CSS Exclusions] Remove exclusions parsing support
2014         https://bugs.webkit.org/show_bug.cgi?id=131046
2015
2016         Reviewed by David Hyatt.
2017
2018         * Scripts/webkitperl/FeatureList.pm:
2019
2020 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2021
2022         [GTK] Remove last reference to GTK+ WK1 EWS
2023         https://bugs.webkit.org/show_bug.cgi?id=131058
2024
2025         Reviewed by Martin Robinson.
2026
2027         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
2028
2029         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
2030
2031 2014-04-01  Lucas Forschler  <lforschler@apple.com>
2032
2033         Add a 32bit JSC builder/tester.
2034         https://bugs.webkit.org/show_bug.cgi?id=131054
2035         
2036         Reviewed by Michael Saboff.
2037
2038         * BuildSlaveSupport/build.webkit.org-config/config.json:
2039         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2040         (Compile32bitJSC):
2041         (Run32bitJSCTests):
2042         (Run32bitJSCTests.countFailures):
2043         (BuildAndTest32bitJSCFactory):
2044         (BuildAndTest32bitJSCFactory.__init__):
2045
2046 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
2047
2048         [GTK] No longer build WebKit1 gtkdoc
2049         https://bugs.webkit.org/show_bug.cgi?id=130970
2050
2051         Reviewed by Anders Carlsson.
2052
2053         * gtk/common.py:
2054         (gtk_version_of_pkg_config_file): Deleted.
2055         * gtk/generate-gtkdoc:
2056         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
2057         was only applicable for WebKit1.
2058         (get_generator_for_config): No longer look for the WebKit1 configuration file.
2059
2060 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
2061
2062         [GTK] Running minibrowser with url crashes in debug build
2063         https://bugs.webkit.org/show_bug.cgi?id=130492
2064
2065         Reviewed by Martin Robinson.
2066
2067         Update "uri-scheme" test not to use invalid URIs in it, so we
2068         don't get a mistmatch when comparing the original URI stored in
2069         the test class with the one returned by the WebKitWebView.
2070
2071         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2072         (testWebContextURIScheme): Update the test.
2073
2074 2014-04-01  Mihai Tica  <mitica@adobe.com>
2075
2076         Unreviewed: Add myself as a commiter to the contributors list.
2077
2078         * Scripts/webkitpy/common/config/contributors.json:
2079
2080 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2081
2082         [EFL][WK2] Extract the control of page background out of color_set
2083         https://bugs.webkit.org/show_bug.cgi?id=127539
2084
2085         Reviewed by Gyuyoung Kim.
2086
2087         Added an option(C) to change background color.
2088
2089         * MiniBrowser/efl/main.c:
2090         (window_create):
2091         (elm_main):
2092
2093 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
2094
2095         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
2096
2097         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
2098
2099 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2100
2101         Unreviewed test correction after r166530.
2102
2103         * DumpRenderTree/mac/DumpRenderTree.mm:
2104         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
2105         fine-grained setting for swipe tests. This prevents existing tests from breaking.
2106
2107 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2108
2109         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
2110         https://bugs.webkit.org/show_bug.cgi?id=130987
2111
2112         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
2113         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
2114
2115         Reviewed by Martin Robinson.
2116
2117         * BuildSlaveSupport/build.webkit.org-config/config.json:
2118
2119 2014-03-31  Dean Jackson  <dino@apple.com>
2120
2121         Remove WEB_ANIMATIONS
2122         https://bugs.webkit.org/show_bug.cgi?id=130989
2123
2124         Reviewed by Simon Fraser.
2125
2126         Remove this feature flag until we plan to implement.
2127
2128         * Scripts/webkitperl/FeatureList.pm:
2129
2130 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
2131
2132         Reduced Latched Scroll Test Flakiness
2133         https://bugs.webkit.org/show_bug.cgi?id=130983
2134
2135         Reviewed by Darin Adler.
2136
2137         * DumpRenderTree/mac/DumpRenderTree.mm:
2138         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
2139         * DumpRenderTree/mac/EventSendingController.mm:
2140         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
2141         with high resolution flags turned on.
2142         * WebKitTestRunner/mac/EventSenderProxy.mm:
2143         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2144
2145 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2146
2147         run-webkit-tests should have a --no-timeout option
2148         https://bugs.webkit.org/show_bug.cgi?id=128286
2149
2150         Reviewed by Joseph Pecoraro.
2151
2152         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2153         (Worker._run_test): Renaming _run_test_with_timeout()
2154         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
2155         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
2156         (Worker._run_test_in_this_thread):
2157         (Worker._run_test_with_timeout): Deleted.
2158         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2159         (parse_args): Added the --no-timeout option
2160
2161 2014-03-31  Samuel White  <samuel_white@apple.com>
2162
2163         AX: Need ability to get line range for text marker.
2164         https://bugs.webkit.org/show_bug.cgi?id=130906
2165
2166         Reviewed by Chris Fleizach.
2167
2168         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
2169
2170         * DumpRenderTree/AccessibilityUIElement.cpp:
2171         (lineTextMarkerRangeForTextMarkerCallback):
2172         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2173         (AccessibilityUIElement::getJSClass):
2174         * DumpRenderTree/AccessibilityUIElement.h:
2175         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2176         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2177         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2178         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2179         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2180         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2181         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2182         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2183         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2184         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2185         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2186         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2187
2188 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
2189
2190         More validation for FTL inline caches
2191         https://bugs.webkit.org/show_bug.cgi?id=130948
2192
2193         Reviewed by Geoffrey Garen.
2194
2195         * Scripts/run-jsc-stress-tests:
2196
2197 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2198
2199         [GTK] Do not run WebKit1 unit tests by default
2200         https://bugs.webkit.org/show_bug.cgi?id=130968
2201
2202         Reviewed by Martin Robinson.
2203
2204         * Scripts/run-gtk-tests:
2205         (TestRunner):
2206
2207 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
2208
2209         [GTK] Remove scripts code only applicable to autotools
2210         https://bugs.webkit.org/show_bug.cgi?id=130841
2211
2212         Reviewed by Anders Carlsson.
2213
2214         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2215         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
2216         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
2217         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
2218         * gtk/find-make-dist-errors: Removed.
2219         * gtk/generate-feature-defines-files: Removed.
2220         * gtk/manifest.txt: No longer need to consider autotools files.
2221
2222 2014-03-30  Andy Estes  <aestes@apple.com>
2223
2224         Fix two failing layout tests on Mountain Lion after r166466.
2225
2226         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2227         (-[DownloadDelegate _downloadDidStart:]):
2228
2229 2014-03-30  Andy Estes  <aestes@apple.com>
2230
2231         [Cocoa] Add an originatingWebView property to _WKDownload
2232         https://bugs.webkit.org/show_bug.cgi?id=130945
2233
2234         Reviewed by Anders Carlsson.
2235
2236         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2237         (-[DownloadDelegate _downloadDidStart:]):
2238         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
2239         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2240         (TEST):
2241
2242 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
2243
2244         Land the stackmap register liveness glue with the uses of the liveness disabled
2245         https://bugs.webkit.org/show_bug.cgi?id=130924
2246
2247         Reviewed by Oliver Hunt.
2248
2249         * Scripts/run-jsc-stress-tests:
2250
2251 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
2252
2253         Update WebKit1.StringTruncator for Mountain Lion.
2254
2255         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
2256         due to different font metrics on 10.8.
2257
2258 2014-03-28  Darin Adler  <darin@apple.com>
2259
2260         Fix recently-introduced off-by-one error in centerTruncateToBuffer
2261         https://bugs.webkit.org/show_bug.cgi?id=130889
2262
2263         Reviewed by Alexey Proskuryakov.
2264
2265         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
2266         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
2267         WebStringTruncator methods; should be good for a start. These are dependent on the
2268         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
2269
2270 2014-03-28  Martin Hock  <mhock@apple.com>
2271
2272         Unreviewed. Add myself as a committer.
2273
2274         * Scripts/webkitpy/common/config/contributors.json:
2275
2276 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
2277
2278         Remove WebKit1 GTK+ bots
2279         https://bugs.webkit.org/show_bug.cgi?id=130904
2280
2281         Reviewed by Anders Carlsson.
2282
2283         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2284         all bots are testing WebKit2 only.
2285         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2286         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2287         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2288         * Scripts/webkitpy/port/builders.py: Ditto.
2289         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2290         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2291
2292 2014-03-28  Timothy Hatcher  <timothy@apple.com>
2293
2294         Remove Brian Burg's apple.com email address.
2295
2296         * Scripts/webkitpy/common/config/contributors.json:
2297
2298 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2299
2300         bisect-builds should print Trac 'changeset' URL if only one build is detected
2301         <http://webkit.org/b/130903>
2302
2303         Reviewed by Dan Bernstein.
2304
2305         * Scripts/bisect-builds:
2306         (printTracLink): Print a direct link to the Trac 'changeset'
2307         URL if there is only one revision in the range.
2308
2309 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2310
2311         [EFL] Bump glib version from 2.36 to 2.38 
2312         https://bugs.webkit.org/show_bug.cgi?id=130886
2313
2314         Reviewed by Csaba Osztrogonác.
2315
2316         There is a build break on EFL port when using glib 2.36 ver. To fix it,
2317         we need to bump glib version up to 2.38 as gtk port.
2318
2319         * efl/jhbuild.modules:
2320
2321 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2322
2323         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2324
2325         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2326         the globalhistory directory.
2327
2328         Reviewed by Sam Weinig.
2329
2330         * WebKitTestRunner/TestController.cpp:
2331         (WTR::TestController::TestController):
2332         (WTR::TestController::initialize): Set the history client.
2333         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2334         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2335         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2336         and we don't yet have API to access the data in question.
2337         (WTR::TestController::didPerformClientRedirect):
2338         (WTR::TestController::didPerformServerRedirect):
2339         (WTR::TestController::didUpdateHistoryTitle):
2340         * WebKitTestRunner/TestController.h:
2341         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2342         * WebKitTestRunner/TestInvocation.cpp:
2343         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2344         (WTR::TestInvocation::invoke):
2345
2346 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2347
2348         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2349
2350         * Scripts/build-webkit:
2351         * Scripts/copy-webkitlibraries-to-product-directory:
2352
2353 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2354
2355         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2356         https://bugs.webkit.org/show_bug.cgi?id=130867
2357         <rdar://problem/16432456> 
2358
2359         Reviewed by Mark Hahnenberg.
2360
2361         * Scripts/build-webkit:
2362         * Scripts/copy-webkitlibraries-to-product-directory:
2363
2364 2014-03-26  Andy Estes  <aestes@apple.com>
2365
2366         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2367         https://bugs.webkit.org/show_bug.cgi?id=130805
2368
2369         Reviewed by Dan Bernstein.
2370
2371         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2372         (-[DownloadDelegate _download:didReceiveResponse:]):
2373         (-[DownloadDelegate _downloadDidFinish:]):
2374         (runTest):
2375         (TEST):
2376         (-[FailingDownloadDelegate _downloadDidFinish:]):
2377         (-[FailingDownloadDelegate _download:didFailWithError:]):
2378         (-[FailingDownloadDelegate _downloadDidCancel:]):
2379         (-[CancelledDownloadDelegate _downloadDidStart:]):
2380         (-[CancelledDownloadDelegate _downloadDidFinish:]):
2381         (-[CancelledDownloadDelegate _download:didFailWithError:]):
2382         (-[CancelledDownloadDelegate _downloadDidCancel:]):
2383         (-[DownloadDelegate initWithSourceURL:]): Deleted.
2384         (-[DownloadDelegate sourceURL]): Deleted.
2385         (runTestWithNavigationDelegate): Deleted.
2386
2387 2014-03-26  Anders Carlsson  <andersca@apple.com>
2388
2389         Change MiniBrowser to hold on to window controllers instead of windows
2390         https://bugs.webkit.org/show_bug.cgi?id=130797
2391
2392         Reviewed by Oliver Hunt.
2393
2394         * MiniBrowser/mac/AppDelegate.h:
2395         * MiniBrowser/mac/AppDelegate.m:
2396         (-[BrowserAppDelegate init]):
2397         (-[BrowserAppDelegate newWindow:]):
2398         (-[BrowserAppDelegate browserWindowWillClose:]):
2399         (-[BrowserAppDelegate applicationWillTerminate:]):
2400         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2401
2402 2014-03-26  Commit Queue  <commit-queue@webkit.org>
2403
2404         Unreviewed, rolling out r166264.
2405         https://bugs.webkit.org/show_bug.cgi?id=130785
2406
2407         Broke some window.opener tests for WK2 Mavericks (Requested by
2408         brrian__ on #webkit).
2409
2410         Reverted changeset:
2411
2412         "Web Replay: resource unique identifiers should be unique-per-
2413         frame, not globally"
2414         https://bugs.webkit.org/show_bug.cgi?id=130632
2415         http://trac.webkit.org/changeset/166264
2416
2417 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2418
2419         [CSS Shapes] Remove shape-inside support
2420         https://bugs.webkit.org/show_bug.cgi?id=130698
2421
2422         Reviewed by David Hyatt.
2423
2424         * Scripts/webkitperl/FeatureList.pm:
2425
2426 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
2427
2428         Unreviewed. Add myself as a committer.
2429
2430         * Scripts/webkitpy/common/config/contributors.json:
2431
2432 2014-03-26  Tomas Popela  <tpopela@redhat.com>
2433
2434         run-launcher is Perl script so use elsif and not elif
2435         https://bugs.webkit.org/show_bug.cgi?id=130771
2436
2437         Reviewed by Carlos Garcia Campos.
2438
2439         * Scripts/run-launcher:
2440
2441 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
2442
2443         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2444         https://bugs.webkit.org/show_bug.cgi?id=130575
2445
2446         Reviewed by Mario Sanchez Prada.
2447
2448         Change ATK version to 2.11.92. Adjust current implementation.
2449
2450         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2451         (AccessibilityUIElement::intValue):
2452         (AccessibilityUIElement::minValue):
2453         (AccessibilityUIElement::maxValue):
2454         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2455         (WTR::AccessibilityUIElement::intValue):
2456         (WTR::AccessibilityUIElement::minValue):
2457         (WTR::AccessibilityUIElement::maxValue):
2458         * efl/jhbuild.modules:
2459         * gtk/jhbuild.modules:
2460
2461 2014-03-12  Philippe Normand  <pnormand@igalia.com>
2462
2463         [GTK] The gnumake package is no longer needed in jhbuild
2464         https://bugs.webkit.org/show_bug.cgi?id=130121
2465
2466         Reviewed by Martin Robinson.
2467
2468         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
2469         for a debug build cmake/system-gnumake worked just fine for me.
2470
2471         * gtk/jhbuild.modules: Removed gnumake.
2472         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
2473         * gtk/patches/make-3.82-parallel-build.patch: Removed.
2474
2475 2014-03-25  Andy Estes  <aestes@apple.com>
2476
2477         Fix a failing API test on Mountain Lion and remove temporary debug logging.
2478
2479         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2480         (-[DownloadDelegate _download:didReceiveData:]):
2481         (-[DownloadDelegate _downloadDidFinish:]):
2482
2483 2014-03-25  Brian Burg  <bburg@apple.com>
2484
2485         Web Replay: resource unique identifiers should be unique-per-frame, not globally
2486         https://bugs.webkit.org/show_bug.cgi?id=130623
2487
2488         Reviewed by Timothy Hatcher.
2489
2490         The resource loader callback dumping routines assumed that resource identifiers
2491         were globally unique. Its map of resource identifiers to URLs must also track the
2492         frame associated with the resource.
2493
2494         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2495         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
2496         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
2497         stable as long as the frame is valid.
2498         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2499         (WTR::InjectedBundlePage::willSendRequestForFrame):
2500         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2501         (WTR::InjectedBundlePage::didFinishLoadForResource):
2502         (WTR::InjectedBundlePage::didFailLoadForResource):
2503
2504 2014-03-25  Andy Estes  <aestes@apple.com>
2505
2506         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
2507
2508         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2509         (-[DownloadDelegate _download:didReceiveResponse:]):
2510         (-[DownloadDelegate _download:didReceiveData:]):
2511
2512 2014-03-25  Andy Estes  <aestes@apple.com>
2513
2514         Add some debug logging to an API test that's failing on Mountain Lion.
2515
2516         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2517         (-[DownloadDelegate _download:didReceiveResponse:]):
2518         (-[DownloadDelegate _downloadDidFinish:]):
2519
2520 2014-03-25  Anders Carlsson  <andersca@apple.com>
2521
2522         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
2523         https://bugs.webkit.org/show_bug.cgi?id=130732
2524
2525         Reviewed by Tim Horton.
2526
2527         * MiniBrowser/mac/WK2BrowserWindowController.m:
2528         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2529
2530 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
2531
2532         [GTK] Remove the autotools build
2533         https://bugs.webkit.org/show_bug.cgi?id=130717
2534
2535         Reviewed by Anders Carlsson.
2536
2537         * DumpRenderTree/config.h: Remove references to the autotools configure file.
2538         * GNUmakefile.am: Removed.
2539         * GtkLauncher/GNUmakefile.am: Removed.
2540         * GtkLauncher/main.c: Remove references to the autotools configure file.
2541         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
2542         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
2543         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
2544         * MiniBrowser/gtk/GNUmakefile.am: Removed.
2545         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
2546         * Scripts/build-webkit: No longer handle autotools.
2547         * Scripts/run-gtk-tests: Ditto.
2548         (TestRunner._setup_testing_environment):
2549         * Scripts/run-launcher: Ditto.
2550         * Scripts/webkitdirs.pm: Ditto.
2551         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
2552         * Scripts/webkitpy/common/config/contributors.json: Ditto.
2553         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
2554         * Scripts/webkitpy/style/checker.py:
2555         * TestWebKitAPI/GNUmakefile.am: Removed.
2556         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
2557         * WebKitTestRunner/GNUmakefile.am: Removed.
2558         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
2559         * gtk/GNUmakefile.am: Removed.
2560         * gtk/common.py: Remove checks for the autotools build.
2561         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
2562
2563 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
2564
2565         prepare-ChangeLog throws false positive warnings for modified files.
2566         https://bugs.webkit.org/show_bug.cgi?id=130687
2567
2568         Reviewed by Darin Adler.
2569
2570         * Scripts/prepare-ChangeLog:
2571         (originalFile): Ignore git commit paremeter.
2572         We don't need this to get the unmodified file.
2573         (extractLineRangeBeforeChange):
2574         Simplify the if statement. Follow-up after r166189.
2575
2576 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
2577
2578         [EFL] Add ARM64 build support
2579         https://bugs.webkit.org/show_bug.cgi?id=130506
2580
2581         Rubber stamped by Gyuyoung Kim.
2582
2583         * Scripts/webkitdirs.pm:
2584         (isARM): Detect aarch64 as ARM.
2585
2586 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2587
2588         [webkitpy] Improve _parse_bug_description to recognize more descriptions
2589         https://bugs.webkit.org/show_bug.cgi?id=130137
2590
2591         Reviewed by Csaba Osztrogonác.
2592
2593         * Scripts/webkitpy/common/checkout/changelog.py:
2594         (ChangeLogEntry._parse_bug_description):
2595         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2596         (test_parse_log_entries_from_changelog):
2597         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2598         (CheckoutTest.test_commit_info_for_revision):
2599
2600 2014-03-24  Andy Estes  <aestes@apple.com>
2601
2602         Fix the iOS build of TestWebKitAPI.
2603
2604         * TestWebKitAPI/Configurations/Base.xcconfig:
2605         * TestWebKitAPI/PlatformUtilities.h:
2606
2607 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2608
2609         Fix prepare-ChangeLog after r166156.
2610         https://bugs.webkit.org/show_bug.cgi?id=130674
2611
2612         Reviewed by Darin Adler.
2613
2614         * Scripts/prepare-ChangeLog:
2615         (generateFunctionLists):
2616         (extractLineRangeBeforeChange):
2617
2618 2014-03-24  Andy Estes  <aestes@apple.com>
2619
2620         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2621         https://bugs.webkit.org/show_bug.cgi?id=129322
2622
2623         Reviewed by Anders Carlsson.
2624
2625         Add an API test suite for _WKDownload.
2626
2627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2628         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
2629         (-[DownloadDelegate initWithSourceURL:]):
2630         (-[DownloadDelegate sourceURL]):
2631         (-[DownloadDelegate _downloadDidStart:]):
2632         (-[DownloadDelegate _download:didReceiveResponse:]):
2633         (-[DownloadDelegate _download:didReceiveData:]):
2634         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2635         (-[DownloadDelegate _downloadDidFinish:]):
2636         (TEST):
2637         (runTestWithNavigationDelegate):
2638         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2639         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2640
2641 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
2642
2643         filter-build-webkit: reduce unfiltered output
2644         https://bugs.webkit.org/show_bug.cgi?id=130485
2645
2646         Reviewed by Brent Fulgham.
2647
2648         * Scripts/filter-build-webkit:
2649         (shouldIgnoreLine):
2650
2651 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2652
2653         prepare-ChangeLog should list functions that have been removed too.
2654         https://bugs.webkit.org/show_bug.cgi?id=130508
2655
2656         Reviewed by Darin Adler.
2657
2658         The prepare-ChangeLog does not list the deleted functions in the Changelog.
2659         We have to read the functions and the line ranges of them from the source
2660         before the change, then search for overlaps between them and the changed
2661         line ranges from diff.
2662
2663         * Scripts/prepare-ChangeLog:
2664         (originalFile): Get original source command.
2665         (generateFunctionLists): Collect deleted functions too.
2666         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
2667         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
2668         deleted functions ranges too.
2669         (extractLineRange): Renamed to extractLineRangeAfterChange.
2670
2671 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
2672
2673         Move all EFL typedefs into EflTypedefs.h.
2674         https://bugs.webkit.org/show_bug.cgi?id=130511
2675
2676         Reviewed by Gyuyoung Kim.
2677
2678         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
2679         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2680         * WebKitTestRunner/PlatformWebView.h: Ditto.
2681
2682 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
2683
2684         Don't flush compositing layers within FrameView::willPaintContents()
2685         https://bugs.webkit.org/show_bug.cgi?id=130627
2686         <rdar://problem/16368869>
2687
2688         Reviewed by Sam Weinig.
2689         
2690         Fix DRT to correctly render tests with layers now that FrameView::paintContents
2691         does not flush.
2692         
2693         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
2694         into an explicit function called before dumping. 
2695         
2696         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
2697         are flushed to CA. They will be pushed to the window by snapshotting.
2698
2699         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2700         Fix weird path to IOKit.framework.
2701         * DumpRenderTree/mac/DumpRenderTree.mm:
2702         (updateDisplay):
2703         (dump):
2704         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2705         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
2706         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
2707
2708 2014-03-21  David Kilzer  <ddkilzer@apple.com>
2709
2710         fix-blink-patch: tool to fix up renamed directory paths in Blink
2711         <http://webkit.org/b/130609>
2712
2713         Reviewed by Ryosuke Niwa.
2714
2715         Usage: cat blink.patch | fix-blink-patch | svn-apply
2716
2717         * Scripts/fix-blink-patch: Added.
2718
2719 2014-03-21  Darin Adler  <darin@apple.com>
2720
2721         Remove use of deprecatedCharacters in WebKit API tests
2722         https://bugs.webkit.org/show_bug.cgi?id=130602
2723
2724         Reviewed by Antti Koivisto.
2725
2726         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2727         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
2728         (TestWebKitAPI::expectEmpty): Use characters8.
2729         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
2730
2731         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2732         Removed the test that is entirely about 16-bit conversion since that's basically a test of
2733         the deprecatedCharacters function itself, which we are about to delete.
2734
2735 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2736
2737         [webkitpy] Fix has_valid_reviewer()
2738         https://bugs.webkit.org/show_bug.cgi?id=130589
2739
2740         Reviewed by Csaba Osztrogonác.
2741
2742         * Scripts/webkitpy/common/checkout/changelog.py:
2743         (ChangeLogEntry.has_valid_reviewer):
2744         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2745         (test_has_valid_reviewer):
2746         * Scripts/webkitpy/common/config/committers.py:
2747         (CommitterList._reviewer_only):
2748         (CommitterList.committer_by_name):
2749         (CommitterList.reviewer_by_email):
2750         (CommitterList):
2751         (CommitterList.reviewer_by_name):
2752
2753 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2754
2755         Add cache support for jhbuild
2756         https://bugs.webkit.org/show_bug.cgi?id=130588
2757
2758         Reviewed by Csaba Osztrogonác.
2759
2760         * jhbuild/jhbuildrc_common.py:
2761         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
2762
2763 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2764
2765         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
2766         https://bugs.webkit.org/show_bug.cgi?id=130504
2767
2768         Reviewed by Martin Robinson.
2769
2770         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
2771         CMake if not specified.
2772         * Scripts/webkitdirs.pm:
2773         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
2774         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
2775
2776 2014-03-21  Andreas Kling  <akling@apple.com>
2777
2778         RetainPtr API test should use CFArray instead of CFString for testing.
2779         <rdar://problem/16384899>
2780
2781         Unreviewed bot fix.
2782
2783         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2784         (TestWebKitAPI::TEST):
2785         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2786         (TestWebKitAPI::TEST):
2787
2788 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
2789
2790         Move to using std::unique_ptr for EFL objects.
2791         https://bugs.webkit.org/show_bug.cgi?id=129853
2792
2793         Reviewed by Gyuyoung Kim.
2794
2795         EflUniquePtr is a template alias of std::unique_ptr
2796         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
2797         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
2798
2799         * DumpRenderTree/efl/DumpRenderTree.cpp:
2800         (main):
2801         * ImageDiff/efl/ImageDiff.cpp:
2802         (initEfl):
2803         (main):
2804
2805 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
2806
2807         Unreviewed buildfix after r165983 for non Cocoa platforms
2808
2809         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
2810
2811         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2812         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2813         * WebKitTestRunner/TestController.cpp:
2814
2815 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
2816
2817         [GTK][CMake] Add support for building with Clang
2818         https://bugs.webkit.org/show_bug.cgi?id=130260
2819
2820         Reviewed by Martin Robinson.
2821
2822         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
2823         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
2824         included GTest framework headers.
2825         * gtk/generate-gtkdoc:
2826         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
2827         in case of using Clang since that is now set by the CMake rule.
2828
2829 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
2830
2831         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
2832         https://bugs.webkit.org/show_bug.cgi?id=130476
2833
2834         Reviewed by Anders Carlsson.
2835         
2836         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
2837
2838         * MiniBrowser/mac/WK1BrowserWindowController.m:
2839         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2840         Remove log.
2841         * MiniBrowser/mac/WK2BrowserWindowController.m:
2842         (-[WK2BrowserWindowController awakeFromNib]):
2843         (-[WK2BrowserWindowController validateMenuItem:]):
2844         (-[WK2BrowserWindowController reload:]):
2845         Hook up reload.
2846         (-[WK2BrowserWindowController toggleZoomMode:]):
2847         (-[WK2BrowserWindowController resetZoom:]):
2848         (-[WK2BrowserWindowController canResetZoom]):
2849         (-[WK2BrowserWindowController currentZoomFactor]):
2850         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2851         (-[WK2BrowserWindowController canZoomIn]):
2852         (-[WK2BrowserWindowController canZoomOut]):
2853
2854 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
2855
2856         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2857         https://bugs.webkit.org/show_bug.cgi?id=130463
2858
2859         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
2860
2861 2014-03-18  Samuel White  <samuel_white@apple.com>
2862
2863         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
2864         https://bugs.webkit.org/show_bug.cgi?id=130250
2865
2866         Reviewed by Chris Fleizach.
2867
2868         Added ability to toggle enhanced accessibility on and off to support tests that require it.
2869
2870         * DumpRenderTree/AccessibilityController.cpp:
2871         (enableEnhancedAccessibilityCallback):
2872         (getEnhancedAccessibilityEnabledCallback):
2873         (AccessibilityController::getJSClass):
2874         * DumpRenderTree/AccessibilityController.h:
2875         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2876         (AccessibilityController::enableEnhancedAccessibility):
2877         (AccessibilityController::enhancedAccessibilityEnabled):
2878         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2879         (AccessibilityController::enableEnhancedAccessibility):
2880         (AccessibilityController::enhancedAccessibilityEnabled):
2881         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2882         (AccessibilityController::enableEnhancedAccessibility):
2883         (AccessibilityController::enhancedAccessibilityEnabled):
2884         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2885         (AccessibilityController::enableEnhancedAccessibility):
2886         (AccessibilityController::enhancedAccessibilityEnabled):
2887         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2888         (WTR::AccessibilityController::enableEnhancedAccessibility):
2889         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
2890         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2891         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2892
2893 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
2894
2895         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
2896         yet).
2897
2898         * Scripts/webkitpy/common/config/contributors.json:
2899
2900 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
2901
2902         Web Inspector: Remove stale ReportMemoryUsagePlugin
2903         https://bugs.webkit.org/show_bug.cgi?id=130405
2904
2905         Reviewed by Andreas Kling.
2906
2907         This clang plugin looks like it was used for the old Inspector memory
2908         instrumentation that was removed. So the tool can be removed.
2909
2910         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
2911         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
2912         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
2913         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
2914
2915 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2916
2917         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
2918         https://bugs.webkit.org/show_bug.cgi?id=130220
2919
2920         Reviewed by Csaba Osztrogonác.
2921
2922         * Scripts/webkitpy/common/checkout/changelog.py:
2923         (ChangeLog.set_reviewer):
2924         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2925         (test_set_reviewer):
2926
2927 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
2928
2929         More FTL enabling.
2930
2931         Rubber stamped by Dan Bernstein.
2932
2933         * Tools/Scripts/build-webkit:
2934
2935 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2936
2937         Renable pagination mode in WK2 MiniBrowser
2938         https://bugs.webkit.org/show_bug.cgi?id=130374
2939
2940         Reviewed by Anders Carlsson.
2941         
2942         Put the implementation of togglePaginationMode: back, and correctly
2943         enable the menu item.
2944
2945         * MiniBrowser/mac/WK2BrowserWindowController.m:
2946         (-[WK2BrowserWindowController validateMenuItem:]):
2947         (-[WK2BrowserWindowController isPaginated]):
2948         (-[WK2BrowserWindowController togglePaginationMode:]):
2949
2950 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2951
2952         Add --reset option to Tools/Scripts/set-webkit-configuration script
2953         https://bugs.webkit.org/show_bug.cgi?id=130401
2954
2955         Reviewed by Csaba Osztrogonác.
2956
2957         * Scripts/set-webkit-configuration:
2958
2959 2014-03-18  Alberto Garcia  <berto@igalia.com>
2960
2961         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
2962         https://bugs.webkit.org/show_bug.cgi?id=130388
2963
2964         Reviewed by Sergio Villar Senin.
2965
2966         * Scripts/webkitdirs.pm:
2967         (shouldRemoveCMakeCache): make sure that the build directory
2968         exists before attempting to create a file in it.
2969
2970 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
2971
2972         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
2973         https://bugs.webkit.org/show_bug.cgi?id=130336
2974
2975         Reviewed by Gyuyoung Kim.
2976
2977         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
2978         requires a space between literal and string macro [-Wliteral-suffix]'
2979         warning treated as error.
2980
2981         This patch applies a solution from r162448 to the EFL port.
2982
2983         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2984         * efl/jhbuild.modules: Added appropriate patch section.
2985
2986 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2987
2988         webkitpy test rebaseline.
2989
2990         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2991         (MainTest.test_default_args):
2992
2993 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2994
2995         --profile should imply --test-runner-count=1 in run-perf-tests
2996         https://bugs.webkit.org/show_bug.cgi?id=130375
2997
2998         Reviewed by Benjamin Poulain.
2999
3000         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
3001
3002         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3003         (PerfTestsRunner._parse_args): Use -1 as the default value.
3004         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
3005         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
3006         should be 1.
3007
3008 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3009
3010         Address some style nits.
3011
3012         * MiniBrowser/mac/WK2BrowserWindowController.m:
3013
3014 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3015
3016         Add transparent window support back into MiniBrowser
3017         https://bugs.webkit.org/show_bug.cgi?id=130363
3018
3019         Reviewed by Anders Carlsson.
3020         
3021         Re-enable transparent window support for WK2.
3022
3023         * MiniBrowser/mac/WK2BrowserWindowController.m:
3024         (-[WK2BrowserWindowController validateMenuItem:]):
3025         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3026
3027 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3028
3029         Fix the 32-bit build; make the open panel make a WK1 window.
3030
3031         * MiniBrowser/mac/AppDelegate.m:
3032         (-[BrowserAppDelegate openDocument:]):
3033
3034 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
3035
3036         Convert MiniBrowser to use WKWebView API
3037         https://bugs.webkit.org/show_bug.cgi?id=130061
3038
3039         Reviewed by Anders Carlsson.
3040         
3041         Convert the MiniBrowser WK2 window to use WebKit2 API as much
3042         as possible.
3043         
3044         Some functionality was removed temporarily:
3045             - text zoom, page zoom
3046             - reload
3047             - pagination mode
3048             - transparent window
3049             - dumping source
3050             - window.open support
3051             - beforeUnload panel
3052             - find in page
3053
3054         * MiniBrowser/mac/AppDelegate.h:
3055         * MiniBrowser/mac/AppDelegate.m:
3056         (-[BrowserAppDelegate init]):
3057         (-[BrowserAppDelegate newWindow:]):
3058         (-[BrowserAppDelegate applicationWillTerminate:]):
3059         (-[BrowserAppDelegate openDocument:]):
3060         * MiniBrowser/mac/WK2BrowserWindowController.h:
3061         * MiniBrowser/mac/WK2BrowserWindowController.m:
3062         (-[WK2BrowserWindowController awakeFromNib]):
3063         (-[WK2BrowserWindowController dealloc]):
3064         (-[WK2BrowserWindowController fetch:]):
3065         (-[WK2BrowserWindowController validateMenuItem:]):
3066         (-[WK2BrowserWindowController reload:]):
3067         (-[WK2BrowserWindowController goBack:]):
3068         (-[WK2BrowserWindowController goForward:]):
3069         (-[WK2BrowserWindowController toggleZoomMode:]):
3070         (-[WK2BrowserWindowController resetZoom:]):
3071         (-[WK2BrowserWindowController canResetZoom]):
3072         (-[WK2BrowserWindowController dumpSourceToConsole:]):
3073         (-[WK2BrowserWindowController togglePaginationMode:]):
3074         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3075         (-[WK2BrowserWindowController windowShouldClose:]):
3076         (-[WK2BrowserWindowController applicationTerminating]):
3077         (-[WK2BrowserWindowController currentZoomFactor]):
3078         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3079         (-[WK2BrowserWindowController toggleTransparentWindow:]):
3080         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3081         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3082         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3083         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3084         (-[WK2BrowserWindowController find:]):
3085         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
3086         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
3087         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
3088         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
3089         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3090         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3091         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3092         * WebKitTestRunner/PlatformWebView.h:
3093         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3094         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3095
3096 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
3097
3098         Use RunLoop objects through references instead of pointers
3099         https://bugs.webkit.org/show_bug.cgi?id=130313
3100
3101         Reviewed by Andreas Kling.
3102
3103         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
3104         return RunLoop reference instead of a pointer.
3105
3106         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
3107         (loadedCallback):
3108         (clickedCallback):
3109
3110 2014-03-17  Tim Horton  <timothy_horton@apple.com>
3111
3112         sort-export-file --help doesn't work (missing 'use')
3113         https://bugs.webkit.org/show_bug.cgi?id=130338
3114
3115         Reviewed by Anders Carlsson.
3116
3117         * Scripts/sort-export-file:
3118         Add a missing 'use', and fix a typo in an error message.
3119
3120 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
3121
3122         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
3123         https://bugs.webkit.org/show_bug.cgi?id=130155
3124
3125         Reviewed by Philippe Normand.
3126
3127         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
3128
3129 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3130
3131         [GTK] MiniBrowser fails to load injected bundle lib
3132         https://bugs.webkit.org/show_bug.cgi?id=130332
3133
3134         Reviewed by Anders Carlsson.
3135
3136         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
3137
3138         * MiniBrowser/gtk/main.c:
3139         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
3140         process is spawn.
3141
3142 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
3143
3144         [EFL] Enable TOUCH_SLIDER macro
3145         https://bugs.webkit.org/show_bug.cgi?id=130185
3146
3147         Reviewed by Gyuyoung Kim.
3148
3149         * Scripts/webkitperl/FeatureList.pm:
3150
3151 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
3152
3153         [GTK][CMake] Build with -fno-rtti
3154         https://bugs.webkit.org/show_bug.cgi?id=130261
3155
3156         Reviewed by Martin Robinson.
3157
3158         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
3159         defined to 0 to prevent typeid use in included GTest headers.
3160
3161 2014-03-16  Brian Burg  <bburg@apple.com>
3162
3163         Web Inspector: vended backend commands file should be generated as part of the build
3164         https://bugs.webkit.org/show_bug.cgi?id=130110
3165
3166         Reviewed by Timothy Hatcher.
3167
3168         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
3169
3170 2014-03-16  Diego Pino García  <dpino@igalia.com>
3171
3172         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
3173         https://bugs.webkit.org/show_bug.cgi?id=128999
3174
3175         Reviewed by Philippe Normand.
3176
3177         * MiniBrowser/gtk/BrowserWindow.c:
3178         (reloadPage):
3179         (reloadPageIgnoringCache):
3180         (browser_window_init):
3181
3182 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
3183
3184         [GTK] Improve ninja detection in webkitdirs.pm
3185         https://bugs.webkit.org/show_bug.cgi?id=129902
3186
3187         Reviewed by Daniel Bates.
3188
3189         * Scripts/webkitdirs.pm:
3190         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
3191         us to look for ninja-build as well.
3192
3193 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
3194
3195         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
3196         https://bugs.webkit.org/show_bug.cgi?id=130276
3197         <rdar://problem/16266927>
3198         
3199         Reviewed by Simon Fraser.
3200
3201         * BuildSlaveSupport/build-launcher-app:
3202         * BuildSlaveSupport/build-launcher-dmg:
3203         * DumpRenderTree/DumpRenderTree.h:
3204         * DumpRenderTree/DumpRenderTreePrefix.h:
3205         * DumpRenderTree/GCController.cpp:
3206         * DumpRenderTree/GCController.h:
3207         * DumpRenderTree/JavaScriptThreading.cpp:
3208         * DumpRenderTree/JavaScriptThreading.h:
3209         * DumpRenderTree/PixelDumpSupport.cpp:
3210         * DumpRenderTree/PixelDumpSupport.h:
3211         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
3212         * DumpRenderTree/TestRunner.cpp:
3213         * DumpRenderTree/TestRunner.h:
3214         * DumpRenderTree/WorkQueue.cpp:
3215         * DumpRenderTree/WorkQueue.h:
3216         * DumpRenderTree/WorkQueueItem.h:
3217         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3218         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3219         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
3220         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3221         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3222         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3223         * DumpRenderTree/efl/EditingCallbacks.cpp:
3224         * DumpRenderTree/efl/EditingCallbacks.h:
3225         * DumpRenderTree/efl/EventSender.cpp:
3226         * DumpRenderTree/efl/EventSender.h:
3227         * DumpRenderTree/efl/GCControllerEfl.cpp:
3228         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3229         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3230         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3231         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3232         * DumpRenderTree/gtk/EditingCallbacks.cpp:
3233         * DumpRenderTree/gtk/EditingCallbacks.h:
3234         * DumpRenderTree/gtk/EventSender.cpp:
3235         * DumpRenderTree/gtk/EventSender.h:
3236         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3237         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3238         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
3239         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
3240         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3241         * DumpRenderTree/gtk/TextInputController.cpp:
3242         * DumpRenderTree/gtk/TextInputController.h:
3243         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
3244         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
3245         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3246         * DumpRenderTree/mac/AppleScriptController.h:
3247         * DumpRenderTree/mac/AppleScriptController.m:
3248         * DumpRenderTree/mac/CheckedMalloc.cpp:
3249         * DumpRenderTree/mac/CheckedMalloc.h:
3250         * DumpRenderTree/mac/DumpRenderTree.mm:
3251         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3252         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3253         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3254         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3255         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3256         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3257         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3258         * DumpRenderTree/mac/EditingDelegate.h:
3259         * DumpRenderTree/mac/EditingDelegate.mm:
3260         * DumpRenderTree/mac/EventSendingController.h:
3261         * DumpRenderTree/mac/EventSendingController.mm:
3262         * DumpRenderTree/mac/FrameLoadDelegate.h:
3263         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3264         * DumpRenderTree/mac/GCControllerMac.mm:
3265         * DumpRenderTree/mac/MockWebNotificationProvider.h:
3266         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3267         * DumpRenderTree/mac/NavigationController.h:
3268         * DumpRenderTree/mac/NavigationController.m:
3269         * DumpRenderTree/mac/ObjCController.h:
3270         * DumpRenderTree/mac/ObjCController.m:
3271         * DumpRenderTree/mac/ObjCPlugin.h:
3272         * DumpRenderTree/mac/ObjCPlugin.m:
3273         * DumpRenderTree/mac/ObjCPluginFunction.h:
3274         * DumpRenderTree/mac/ObjCPluginFunction.m:
3275         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3276         * DumpRenderTree/mac/PolicyDelegate.h:
3277         * DumpRenderTree/mac/PolicyDelegate.mm:
3278         * DumpRenderTree/mac/ResourceLoadDelegate.h:
3279         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3280         * DumpRenderTree/mac/TestRunnerMac.mm:
3281         * DumpRenderTree/mac/TextInputController.h:
3282         * DumpRenderTree/mac/TextInputController.m:
3283         * DumpRenderTree/mac/UIDelegate.h:
3284         * DumpRenderTree/mac/UIDelegate.mm:
3285         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3286         * DumpRenderTree/win/DRTDataObject.cpp:
3287         * DumpRenderTree/win/DRTDataObject.h:
3288         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3289         * DumpRenderTree/win/DRTDropSource.cpp:
3290         * DumpRenderTree/win/DRTDropSource.h:
3291         * DumpRenderTree/win/DraggingInfo.h:
3292         * DumpRenderTree/win/DumpRenderTree.cpp:
3293         * DumpRenderTree/win/DumpRenderTreeWin.h:
3294         * DumpRenderTree/win/EditingDelegate.cpp:
3295         * DumpRenderTree/win/EditingDelegate.h:
3296         * DumpRenderTree/win/EventSender.cpp:
3297         * DumpRenderTree/win/EventSender.h:
3298         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3299         * DumpRenderTree/win/FrameLoadDelegate.h:
3300         * DumpRenderTree/win/GCControllerWin.cpp:
3301         * DumpRenderTree/win/HistoryDelegate.cpp:
3302         * DumpRenderTree/win/HistoryDelegate.h:
3303         * DumpRenderTree/win/MD5.cpp:
3304         * DumpRenderTree/win/MD5.h:
3305         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3306         * DumpRenderTree/win/PolicyDelegate.cpp:
3307         * DumpRenderTree/win/PolicyDelegate.h:
3308         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3309         * DumpRenderTree/win/ResourceLoadDelegate.h:
3310         * DumpRenderTree/win/TestRunnerWin.cpp:
3311         * DumpRenderTree/win/TextInputController.cpp:
3312         * DumpRenderTree/win/TextInputController.h:
3313         * DumpRenderTree/win/TextInputControllerWin.cpp:
3314         * DumpRenderTree/win/UIDelegate.cpp:
3315         * DumpRenderTree/win/UIDelegate.h:
3316         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3317         * EWebLauncher/main.c:
3318         * GtkLauncher/main.c:
3319         * ImageDiff/efl/ImageDiff.cpp:
3320         * ImageDiff/gtk/ImageDiff.cpp:
3321         * MiniBrowser/gtk/main.c:
3322         * Scripts/SpacingHeuristics.pm:
3323         * Scripts/VCSUtils.pm:
3324         * Scripts/bisect-builds:
3325         * Scripts/build-dumprendertree:
3326         * Scripts/build-jsc:
3327         * Scripts/build-webkit:
3328         * Scripts/check-dom-results:
3329         * Scripts/check-for-exit-time-destructors:
3330         * Scripts/check-for-global-initializers:
3331         * Scripts/commit-log-editor:
3332         * Scripts/compare-timing-files:
3333         * Scripts/debug-minibrowser:
3334         * Scripts/debug-safari:
3335         * Scripts/do-file-rename:
3336         * Scripts/find-extra-includes:
3337         * Scripts/generate-coverage-data:
3338         * Scripts/make-script-test-wrappers:
3339         * Scripts/malloc-tree:
3340         * Scripts/old-run-webkit-tests:
3341         * Scripts/parse-malloc-history:
3342         * Scripts/report-include-statistics:
3343         * Scripts/resolve-ChangeLogs:
3344         * Scripts/run-bindings-tests:
3345         * Scripts/run-iexploder-tests:
3346         * Scripts/run-javascriptcore-tests:
3347         * Scripts/run-jsc:
3348         * Scripts/run-launcher:
3349         * Scripts/run-leaks:
3350         * Scripts/run-mangleme-tests:
3351         * Scripts/run-minibrowser:
3352         * Scripts/run-pageloadtest:
3353         * Scripts/run-regexp-tests:
3354         * Scripts/run-safari:
3355         * Scripts/run-sunspider:
3356         * Scripts/run-webkit-app:
3357         * Scripts/sampstat:
3358         * Scripts/set-webkit-configuration:
3359         * Scripts/sort-Xcode-project-file:
3360         * Scripts/sort-export-file:
3361         * Scripts/split-file-by-class:
3362         * Scripts/sunspider-compare-results:
3363         * Scripts/svn-apply:
3364         * Scripts/svn-create-patch:
3365         * Scripts/svn-unapply:
3366         * Scripts/test-webkit-scripts:
3367         * Scripts/update-javascriptcore-test-results:
3368         * Scripts/update-webkit:
3369         * Scripts/update-webkit-auxiliary-libs:
3370         * Scripts/update-webkit-dependency:
3371         * Scripts/update-webkit-localizable-strings:
3372         * Scripts/update-webkit-support-libs:
3373         * Scripts/update-webkit-wincairo-libs:
3374         * Scripts/webkit-build-directory:
3375         * Scripts/webkitdirs.pm:
3376         (installedSafariPath):
3377         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3378         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3379         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3380         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3381         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3382         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3383         * Scripts/webkitperl/features.pm:
3384         * Scripts/webkitperl/httpd.pm:
3385         * Scripts/webkitpy/bindings/main.py:
3386         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3387         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3388         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3389         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3390         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3391         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3392         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3393         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3394         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3395         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
3396         * WebKitTestRunner/PixelDumpSupport.cpp:
3397         * WebKitTestRunner/PixelDumpSupport.h:
3398         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3399         * WinLauncher/WinLauncher.cpp:
3400         * WinLauncher/WinLauncher.h:
3401         * WinLauncher/stdafx.cpp:
3402         * WinLauncher/stdafx.h:
3403
3404 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
3405
3406         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
3407         https://bugs.webkit.org/show_bug.cgi?id=130265
3408
3409         Reviewed by Michael Saboff.
3410
3411         * Scripts/build-webkit:
3412         * Scripts/copy-webkitlibraries-to-product-directory:
3413
3414 2014-03-14  Landry Breuil  <landry@openbsd.org>
3415
3416         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
3417         Also allow to set MAKE in the environment.
3418         https://bugs.webkit.org/show_bug.cgi?id=129991
3419
3420         Reviewed by Andreas Kling.
3421
3422         * Scripts/webkitdirs.pm:
3423         (determineArchitecture):
3424         (determineNumberOfCPUs):
3425         (isBSD):
3426         (buildAutotoolsProject):
3427         * Scripts/webkitpy/common/system/platforminfo.py:
3428         (PlatformInfo.__init__):
3429         (PlatformInfo.is_openbsd):
3430         (PlatformInfo):
3431         (PlatformInfo.is_netbsd):
3432         (PlatformInfo._determine_os_name):
3433
3434 2014-03-14  Dean Jackson  <dino@apple.com>
3435
3436         Remove libWebKitSystemInterfaceLion.a
3437         https://bugs.webkit.org/show_bug.cgi?id=130254
3438
3439         Reviewed by Geoffrey Garen and Andreas Kling.
3440
3441         No need to copy the Lion libraries into the build.
3442
3443         * Scripts/copy-webkitlibraries-to-product-directory:
3444
3445 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3446
3447         [EFL][MiniBrowser] Revise help messages of command line parameters
3448         https://bugs.webkit.org/show_bug.cgi?id=130222
3449
3450         Reviewed by Csaba Osztrogonác.
3451
3452         Correct the default value description and make help messages to be consistent.
3453
3454         * MiniBrowser/efl/main.c:
3455
3456 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
3457
3458         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
3459         https://bugs.webkit.org/show_bug.cgi?id=129612
3460
3461         Reviewed by Darin Adler.
3462
3463         For new code use static NeverDestroyed<T> instead.
3464
3465         * DumpRenderTree/JavaScriptThreading.cpp:
3466         (javaScriptThreadsMutex):
3467         (javaScriptThreads):
3468         * DumpRenderTree/efl/EventSender.cpp:
3469         (touchPointList):
3470         (delayedEventQueue):
3471         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3472         (delegatesWithDelayedWork):
3473         * Scripts/check-for-exit-time-destructors:
3474         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
3475         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3476         (testsMap):
3477
3478 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
3479
3480         [EFL][WK2] Fix compilation warning in Minibrowser
3481         https://bugs.webkit.org/show_bug.cgi?id=130132
3482
3483         Reviewed by Csaba Osztrogonác.
3484
3485         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
3486
3487         * MiniBrowser/efl/main.c:
3488         (on_download_request):
3489
3490 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
3491
3492         FTL should support IsBlah
3493         https://bugs.webkit.org/show_bug.cgi?id=130202
3494
3495         Reviewed by Geoffrey Garen.
3496         
3497         Running existing JSRegress tests with noInline gives us coverage for these
3498         changes. Chances are, this will also give coverage for other interesting things
3499         as well.
3500
3501         * Scripts/run-jsc-stress-tests:
3502
3503 2014-03-12  Brian Burg  <bburg@apple.com>
3504
3505         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
3506         https://bugs.webkit.org/show_bug.cgi?id=129744
3507
3508         Reviewed by Timothy Hatcher.
3509
3510         * DumpRenderTree/TestRunner.cpp:
3511         (evaluateInWebInspectorCallback):
3512         * DumpRenderTree/TestRunner.h:
3513         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3514         (TestRunner::evaluateInWebInspector):
3515         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3516         (TestRunner::evaluateInWebInspector):
3517         * DumpRenderTree/mac/TestRunnerMac.mm:
3518         (TestRunner::evaluateInWebInspector):
3519         * DumpRenderTree/win/TestRunnerWin.cpp:
3520         (TestRunner::evaluateInWebInspector):
3521         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3522         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3523         (WTR::TestRunner::evaluateInWebInspector):
3524         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3525
3526 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3527
3528         [GTK] build-webkit shouldn't show error message when ninja isn't installed
3529         https://bugs.webkit.org/show_bug.cgi?id=130129
3530
3531         Reviewed by Csaba Osztrogonác.
3532
3533         * Scripts/webkitdirs.pm:
3534         (canUseNinja): Redirecting stderr to /dev/null
3535
3536 2014-03-13  Andres Gomez  <agomez@igalia.com>
3537
3538         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
3539         https://bugs.webkit.org/show_bug.cgi?id=130092
3540
3541         Reviewed by Csaba Osztrogonác.
3542
3543         Added "python-dev" as dependency for deb based distros. It is
3544         already present for rpm based distros. This dependency will allow
3545         libxml2 to generate its python bindings, needed by gtk-doc.
3546
3547         * gtk/install-dependencies:
3548
3549 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3550
3551         Unreviewed. Fix GTK+ cmake build after r165488.
3552
3553         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
3554
3555 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3556
3557         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
3558         https://bugs.webkit.org/show_bug.cgi?id=130014
3559
3560         Reviewed by Martin Robinson.
3561
3562         Include cmake or autotools config header.
3563
3564         * MiniBrowser/gtk/BrowserDownloadsBar.c:
3565         * MiniBrowser/gtk/BrowserSearchBar.c:
3566         * MiniBrowser/gtk/BrowserWindow.c:
3567         * MiniBrowser/gtk/main.c:
3568
3569 2014-03-12  Commit Queue  <commit-queue@webkit.org>
3570
3571         Unreviewed, rolling out r165471.
3572         https://bugs.webkit.org/show_bug.cgi?id=130139
3573
3574         Didn't really fix the issue and broke another bot (Requested
3575         by mrobinson on #webkit).
3576
3577         Reverted changeset:
3578
3579         "[CMake] Newer versions of CMake cannot find older versions of
3580         Freetype"
3581         https://bugs.webkit.org/show_bug.cgi?id=130107
3582         http://trac.webkit.org/changeset/165471
3583
3584 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
3585
3586         It should be possible to build WebKit with FTL on iOS
3587         https://bugs.webkit.org/show_bug.cgi?id=130116
3588
3589         Reviewed by Dan Bernstein.
3590
3591         * Scripts/build-webkit:
3592         * Scripts/copy-webkitlibraries-to-product-directory:
3593
3594 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
3595
3596         [Win] Remove use of QTSDK
3597         https://bugs.webkit.org/show_bug.cgi?id=130049
3598
3599         Reviewed by Darin Adler.
3600
3601         * DumpRenderTree/win/DumpRenderTree.cpp:
3602         (initialize): Remove QuickTime code.
3603         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
3604         building QTMovieWin.
3605
3606 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
3607
3608         [GTK][CMAKE] Too verbose build output
3609         https://bugs.webkit.org/show_bug.cgi?id=130076
3610
3611         Reviewed by Carlos Garcia Campos.
3612
3613         Instead of building with cmake --build which isn't smart about pretty printing and
3614         colors, we build with a script which calls the proper build command.
3615
3616         * Scripts/webkitdirs.pm:
3617         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
3618         the CMake configuration pass.
3619
3620 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3621
3622         [CMake] Newer versions of CMake cannot find older versions of Freetype
3623         https://bugs.webkit.org/show_bug.cgi?id=130107
3624
3625         Reviewed by Gustavo Noronha Silva.
3626
3627         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
3628         to CMake during jhbuild initialization.
3629
3630 2014-03-12  Zalan Bujtas  <zalan@apple.com>
3631
3632         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
3633         https://bugs.webkit.org/show_bug.cgi?id=129961
3634
3635         Reviewed by Simon Fraser.
3636
3637         Now scaled content can go through the window capturing mechanism too for compositing content.
3638         AppleMagnifiedMode is redundant.
3639
3640         * DumpRenderTree/mac/DumpRenderTree.mm:
3641         (setDefaultsToConsistentValuesForTesting):
3642         (runTest):
3643         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3644         (createBitmapContextFromWebView):
3645         * WebKitTestRunner/PlatformWebView.h:
3646         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3647         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3648         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3649         (WTR::PlatformWebView::didInitializeClients):
3650         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3651         (WTR::PlatformWebView::forceWindowFramesChanged):
3652         * WebKitTestRunner/mac/main.mm:
3653         (setDefaultsToConsistentValuesForTesting):
3654
3655 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
3656
3657         Unreviewed. Add myself as a committer.
3658
3659         * Scripts/webkitpy/common/config/contributors.json:
3660
3661 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
3662
3663         Unreviewed build fix on the EFL port when used lower version of ATK
3664
3665         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3666         (WTR::AccessibilityUIElement::y): Fixed typo.
3667
3668 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3669
3670         Some images are blank in the rebaseline server UI
3671         https://bugs.webkit.org/show_bug.cgi?id=130104
3672
3673         Reviewed by Tim Horton.
3674
3675         Let the server check for images in the 'retries' directory
3676         if it can't find an image otherwise.
3677
3678         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3679         (RebaselineHTTPRequestHandler.test_result):
3680
3681 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3682
3683         [GTK][CMake] --update-gtk has no effect
3684         https://bugs.webkit.org/show_bug.cgi?id=130088
3685
3686         Reviewed by Philippe Normand.
3687
3688         * Scripts/webkitdirs.pm:
3689         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
3690         as an argument.
3691
3692 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3693
3694         Add "System Font" to the list of whitelisted DRT fonts
3695         https://bugs.webkit.org/show_bug.cgi?id=130046
3696
3697         Reviewed by Darin Adler.
3698
3699         * DumpRenderTree/mac/DumpRenderTree.mm:
3700         (allowedFontFamilySet):
3701         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3702
3703 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3704
3705         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
3706         https://bugs.webkit.org/show_bug.cgi?id=130064
3707
3708         Reviewed by Philippe Normand.
3709
3710         * efl/jhbuildrc: Remove duplicated code.
3711         * gtk/jhbuildrc: Remove duplicated code.
3712         * jhbuild/jhbuildrc_common.py:
3713         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
3714         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
3715         and is apparently necessary for GTK+.
3716
3717 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3718
3719         check-webkit-style failed to complain about missing braces
3720         https://bugs.webkit.org/show_bug.cgi?id=34189
3721
3722         Reviewed by Ryosuke Niwa.
3723
3724         * Scripts/webkitpy/style/checkers/cpp.py:
3725         (check_braces):
3726         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3727         (WebKitStyleTest.test_braces):
3728
3729 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3730
3731         Remove Qt cruft from style checker.
3732         https://bugs.webkit.org/show_bug.cgi?id=130085
3733
3734         Reviewed by Csaba Osztrogonác.
3735
3736         There is no 'foreach' keyword in c++. That was a Qt feature
3737         added in: http://trac.webkit.org/changeset/46113
3738         Qt was removed from WebKit, so we should remove the checks
3739         of this keyword from check-webkit-style scripts.
3740
3741         * Scripts/webkitpy/style/checkers/cpp.py:
3742         (check_spacing_for_function_call):
3743         (check_spacing):
3744         (check_braces):
3745         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3746         (CppStyleTest.test_mismatching_spaces_in_parens):
3747         (CppStyleTest.test_spacing_for_fncall):
3748         (WebKitStyleTest.test_braces):
3749
3750 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
3751
3752         [GTK] update-webkitgtk-libs needs itstool
3753         https://bugs.webkit.org/show_bug.cgi?id=130082
3754
3755         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
3756         itstool is a dependency of building gtk-doc from version 1.19, so it should
3757         be added to Tools/gtk/install-dependencies script, too.
3758
3759         Reviewed by Philippe Normand.
3760
3761         * gtk/install-dependencies:
3762
3763 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3764
3765         webkitbot rollout ChangeLogs should be nicer
3766         https://bugs.webkit.org/show_bug.cgi?id=122654
3767
3768         Reviewed by Csaba Osztrogonác.
3769
3770         Added bug urls and descriptions of rolled out patches to the rollout changelog
3771         if they are present in the original changelog. Additionally removed the list of
3772         changed files and functions.
3773
3774         * Scripts/webkitpy/common/checkout/changelog.py:
3775         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
3776         * Scripts/webkitpy/common/checkout/checkout.py:
3777         (Checkout._changelog_data_for_revision): Store bug description.
3778         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3779         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3780         (CheckoutTest.test_commit_info_for_revision):
3781         * Scripts/webkitpy/common/checkout/commitinfo.py:
3782         (CommitInfo.bug_description): Added.
3783         (CommitInfo.to_json):
3784         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3785         (CommitInfoTest.test_commit_info_creation):
3786         * Scripts/webkitpy/tool/commands/download.py:
3787         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
3788         out patches for creating rollout changelog.
3789         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
3790         caused the regression is stored in state["bug_blocked"] now.
3791         * Scripts/webkitpy/tool/commands/download_unittest.py:
3792         (test_prepare_rollout):
3793         (test_create_rollout_multiple_revision):
3794         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3795         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
3796         rolled out patches to the changelog.
3797         (PrepareChangeLogForRevert.run):
3798         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3799         (UpdateChangeLogsForRevertTest):
3800         (test_message_for_revert):
3801         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3802         (ReopenBugAfterRollout.run):
3803
3804 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3805
3806         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
3807         https://bugs.webkit.org/show_bug.cgi?id=130021
3808
3809         Reviewed by Mario Sanchez Prada.
3810
3811         Replace deprecated functions to use new API from ATK 2.11.90.
3812
3813         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3814         (AccessibilityUIElement::x):
3815         (AccessibilityUIElement::y):
3816         (AccessibilityUIElement::width):
3817         (AccessibilityUIElement::height):
3818         (AccessibilityUIElement::clickPointX):
3819         (AccessibilityUIElement::clickPointY):
3820         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3821         (WTR::AccessibilityUIElement::x):
3822         (WTR::AccessibilityUIElement::y):
3823         (WTR::AccessibilityUIElement::width):
3824         (WTR::AccessibilityUIElement::height):
3825         (WTR::AccessibilityUIElement::clickPointX):
3826         (WTR::AccessibilityUIElement::clickPointY):
3827
3828 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3829
3830         [ATK] Expose aria-posinset and aria-setsize through object attributes
3831         https://bugs.webkit.org/show_bug.cgi?id=130011
3832
3833         Reviewed by Chris Fleizach.
3834
3835         Added missing implementation of numberAttributeValue both to WKTR and DRT.
3836
3837         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3838         (AccessibilityUIElement::numberAttributeValue):
3839         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3840         (WTR::AccessibilityUIElement::numberAttributeValue):
3841
3842 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3843
3844         [Win] Unreviewed build fix.
3845
3846         Some bad Windows code was committed at some point that prevents the Apple Windows port
3847         from finding its runtime dependencies reliably.
3848
3849         * win/DLLLauncher/DLLLauncherMain.cpp:
3850         (appleApplicationSupportDirectory): Restored this function.
3851         (modifyPath): Update to use appleApplicationSupportDirectory function.
3852
3853 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
3854
3855         Let the user define the full address of the performance-site-server for uploading results
3856         https://bugs.webkit.org/show_bug.cgi?id=129819
3857
3858         Reviewed by Ryosuke Niwa.
3859
3860         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
3861         can be confusing. It's more straightforward, if you need to define explicitly the server's full
3862         address along with the protocol, when you're using this parameter. I added HTTPS as the default
3863         protocol for now, in order to avoid breaking the perf bots.
3864
3865         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3866         (_upload_json):
3867         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3868         (MainTest.test_upload_json):
3869
3870 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3871
3872         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
3873         https://bugs.webkit.org/show_bug.cgi?id=130023
3874
3875         Reviewed by Dean Jackson.
3876
3877         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
3878         /SAFESEH flag to DLL launcher process.
3879
3880 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3881
3882         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
3883         https://bugs.webkit.org/show_bug.cgi?id=129980
3884
3885         Reviewed by Carlos Garcia Campos.
3886
3887         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
3888
3889 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3890
3891         [GTK] Remove the WebView source-mode WebKit1 test
3892         https://bugs.webkit.org/show_bug.cgi?id=129976
3893
3894         Reviewed by Carlos Garcia Campos.
3895
3896         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
3897
3898 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
3899
3900         Unreviewed build fix for GTKbuild after the switch to CMake
3901
3902         * gtk/common.py:
3903         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
3904         test-only bot doesn't have any build files.
3905
3906 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3907
3908         [GTK] built-product-archive does not handle GTK+ CMake build
3909         https://bugs.webkit.org/show_bug.cgi?id=129941
3910
3911         * BuildSlaveSupport/built-product-archive:
3912         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
3913         the CMake build.
3914
3915 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
3916
3917         [GTK] Include CMake into install-dependencies script
3918         https://bugs.webkit.org/show_bug.cgi?id=129909
3919
3920         Reviewed by Martin Robinson.
3921
3922         As since r165267 buid-webkit uses CMake by default, the dependency
3923         with 'cmake' package should be introduced.
3924
3925         * gtk/install-dependencies: Ditto.
3926
3927 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3928
3929         REGRESSION(165267): Broke a webkitpy unit tests
3930         https://bugs.webkit.org/show_bug.cgi?id=129904
3931
3932         Reviewed by Jon Honeycutt.
3933
3934         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
3935         (GtkPort._is_cmake_build):
3936
3937 2014-03-07  Andres Gomez  <agomez@igalia.com>
3938
3939         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
3940         https://bugs.webkit.org/show_bug.cgi?id=129893
3941
3942         Reviewed by Martin Robinson.
3943
3944         Added "git-svn" as dependency for deb based distros and,
3945         additionally, "subversion" for rpm based distros.
3946
3947         * gtk/install-dependencies:
3948
3949 2014-03-07  Roger Fong  <roger_fong@apple.com>
3950
3951         Remove dummy setSystemWebGLLoadPolicy client method.
3952         https://bugs.webkit.org/show_bug.cgi?id=129873.
3953
3954         Reviewed by Dean Jackson.
3955
3956         * WebKitTestRunner/TestController.cpp:
3957         (WTR::TestController::createWebViewWithOptions):
3958
3959 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
3960
3961         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
3962         https://bugs.webkit.org/show_bug.cgi?id=129886
3963
3964         Reviewed by Mark Lam.
3965
3966         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
3967         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
3968         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
3969         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
3970         make it through when in non-verbose mode.
3971
3972 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3973
3974         [GTK] buid-webkit should use CMake by default
3975         https://bugs.webkit.org/show_bug.cgi?id=129855
3976
3977         Reviewed by Carlos Garcia Campos.
3978
3979         Make the CMake build the default GTK+ build when using build-webkit. This will
3980         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
3981         so that we have --gtk and --gtkautotools.
3982
3983         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
3984         * Scripts/webkitpy/port/gtk.py: Ditto.
3985
3986 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
3987
3988         [CMake] [GTK] Build with ninja when it is available
3989         https://bugs.webkit.org/show_bug.cgi?id=129805
3990
3991         Reviewed by Philippe Normand.
3992
3993         * Scripts/webkitdirs.pm:
3994         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
3995         if it's available on the system.
3996         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
3997         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
3998
3999 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
4000
4001         If the FTL is build-time enabled then it should be run-time enabled.
4002
4003         Rubber stamped by Geoffrey Garen.
4004
4005         * Scripts/run-jsc-stress-tests:
4006
4007 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
4008
4009         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
4010         https://bugs.webkit.org/show_bug.cgi?id=129837
4011
4012         Reviewed by Michael Saboff.
4013
4014         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
4015         The fix is to use find instead of ls like we do in shell-runner.sh.
4016
4017         * Scripts/run-jsc-stress-tests:
4018
4019 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
4020
4021         filter-build-webkit should not strip .o
4022         https://bugs.webkit.org/show_bug.cgi?id=129614
4023
4024         Reviewed by Dean Jackson.
4025
4026         This makes it much easier to jump from the failing output at
4027         the end back up to the compile errors earlier in the output.
4028
4029         * Scripts/filter-build-webkit:
4030
4031 2014-03-06  Anders Carlsson  <andersca@apple.com>
4032
4033         Build WebKit2 before building WebKit
4034         https://bugs.webkit.org/show_bug.cgi?id=129831
4035         <rdar://problem/15920020>
4036
4037         Reviewed by Dan Bernstein.
4038
4039         * Scripts/build-webkit:
4040         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
4041
4042 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
4043
4044         make-3.82 fails to build on ARM/Linux
4045         https://bugs.webkit.org/show_bug.cgi?id=107926
4046
4047         Reviewed by Martin Robinson.
4048
4049         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
4050         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
4051         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
4052         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
4053
4054         * gtk/patches/make-3.82-arg-list-length.patch:
4055
4056 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4057
4058         [GTK] Close the page when the view is disposed instead of when finalized
4059         https://bugs.webkit.org/show_bug.cgi?id=129783
4060
4061         Reviewed by Sergio Villar Senin.
4062
4063         Add test case but disabled for now because it's affetected by bug #129684.
4064
4065         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
4066         (testProcessPerWebView):
4067
4068 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4069
4070         [GTK] MiniBrowser crashes when opening several urls passed as command line options
4071         https://bugs.webkit.org/show_bug.cgi?id=129738
4072
4073         Reviewed by Sergio Villar Senin.
4074
4075         The problem is that we are calling g_object_unref() for the
4076         WebKitWebSettings everytime we set it to a WebKitWebView, but the
4077         view only increases the reference counter when the settings is not
4078         the same it currently has. We should release our reference once.
4079
4080         * MiniBrowser/gtk/main.c:
4081         (createBrowserWindow):
4082         (main):
4083
4084 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4085
4086         [GTK][CMake] Tarball is created with wrong tarball paths
4087         https://bugs.webkit.org/show_bug.cgi?id=129496
4088
4089         Reviewed by Daniel Bates.
4090
4091         * gtk/make-dist.py:
4092         (Manifest.__init__): I inadvertently inverted the logic of these checks when
4093         landing the original patch with some suggestions from the reviewer. With the
4094         checks corrected, the tarball path is constructed properly.
4095
4096 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
4097
4098         Unreviewed. Update my email in contributors.json
4099
4100         * Scripts/webkitpy/common/config/contributors.json:
4101
4102 2014-03-05  Dean Jackson  <dino@apple.com>
4103
4104         [WebGL] Use WKSI to see what the system policy for WebGL is
4105         https://bugs.webkit.org/show_bug.cgi?id=129722
4106         <rdar://problem/15790542>
4107
4108         Reviewed by Tim Horton.
4109
4110         Dummy entry for setSystemWebGLLoadPolicy.
4111
4112         * WebKitTestRunner/TestController.cpp:
4113         (WTR::TestController::createWebViewWithOptions):
4114
4115 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
4116
4117         [GTK][CMake] Generate documentation for the DOM bindings
4118         https://bugs.webkit.org/show_bug.cgi?id=126211
4119
4120         Reviewed by Carlos Garcia Campos.
4121
4122         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
4123         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
4124         * gtk/generate-webkitdom-doc-files: Removed.
4125         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
4126         that it can be called by generate-gtkdoc.
4127
4128 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4129
4130         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
4131         https://bugs.webkit.org/show_bug.cgi?id=129380
4132
4133         Reviewed by Philippe Normand.
4134
4135         * Scripts/webkitdirs.pm:
4136         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
4137         skipping CMake execution.
4138
4139 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4140
4141         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
4142         https://bugs.webkit.org/show_bug.cgi?id=129651
4143
4144         Reviewed by Philippe Normand.
4145
4146         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
4147
4148 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
4149
4150         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
4151         https://bugs.webkit.org/show_bug.cgi?id=129637
4152
4153         Reviewed by Carlos Garcia Campos.
4154
4155         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4156         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
4157         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
4158         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
4159         New API typically just requires a rebaseline and isn't necessarily a faiulre.
4160         (TestFactory.__init__): Add the test for GTK+.
4161         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
4162
4163 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
4164
4165         [ATK] Expose missing functionalities of AtkTableCell to AT
4166         https://bugs.webkit.org/show_bug.cgi?id=129492
4167
4168         Reviewed by Mario Sanchez Prada.
4169
4170         Reducing some code by using new API of AtkTableCell.
4171
4172         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4173         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4174
4175 2014-03-04  Alex Christensen  <achristensen@webkit.org>
4176
4177         Preparing to run layout tests on Wincairo.
4178         https://bugs.webkit.org/show_bug.cgi?id=129709
4179
4180         Reviewed by Brent Fulgham.
4181
4182         * Scripts/webkitdirs.pm:
4183         (setPathForRunningWebKitApp):
4184         Add GStreamer directory for WinCairo running layout tests.
4185         * win/DLLLauncher/DLLLauncherMain.cpp:
4186         (modifyPath):
4187         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
4188
4189 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
4190
4191         [GTK] Simplify the GObject DOM bindings API break check into one step
4192         https://bugs.webkit.org/show_bug.cgi?id=129571
4193
4194         Reviewed by Carlos Garcia Campos.
4195
4196         * GNUmakefile.am: Add the API break check to 'make check.'
4197         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
4198         * gtk/check-gdom-symbols: Removed.
4199         * gtk/webkitdom.py: Added.
4200         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
4201         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
4202
4203 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
4204
4205         Add Jeremy Jones to the contributors list as a contributor.
4206
4207         * Scripts/webkitpy/common/config/contributors.json:
4208
4209 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
4210
4211         Unreviewed. Update contact email.
4212         https://bugs.webkit.org/show_bug.cgi?id=129610
4213
4214         * Scripts/webkitpy/common/config/contributors.json:
4215
4216 2014-03-02  Brian Burg  <bburg@apple.com>
4217
4218         Web Inspector model tests load wrong inspector page under WebKitTestRunner
4219         https://bugs.webkit.org/show_bug.cgi?id=129460
4220
4221         Reviewed by Dan Bernstein.
4222
4223         Don't unconditionally open the inspector before running an inspector test.
4224         Instead, the test should request that the inspector open when it's ready.
4225
4226         This change was lost during a rebase, but is the same change made to
4227         DumpRenderTree.
4228
4229         * WebKitTestRunner/TestInvocation.cpp:
4230         (WTR::TestInvocation::invoke): 
4231
4232 2014-03-02  Darin Adler  <darin@apple.com>
4233
4234         Split TextIteratorBehavior into a separate header
4235         https://bugs.webkit.org/show_bug.cgi?id=129578
4236
4237         Reviewed by Sam Weinig.
4238
4239         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
4240         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
4241         task easy, but the remove is still a bit of a pain.
4242
4243 2014-03-02  Darin Adler  <darin@apple.com>
4244
4245         Sort Mac platform export files so they merge better
4246         https://bugs.webkit.org/show_bug.cgi?id=129581
4247
4248         Reviewed by Sam Weinig.
4249
4250         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
4251         Mac export files in a "canonical" order for this project.
4252
4253 2014-02-28  Zalan Bujtas  <zalan@apple.com>
4254
4255         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
4256         https://bugs.webkit.org/show_bug.cgi?id=129438
4257
4258         Reviewed by Simon Fraser.
4259
4260         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
4261         offscreen window. It makes testing subpixel rendering and positioning possible.
4262
4263         Both the offscreen window's and WebKit's scaling are set accordingly.
4264
4265         * DumpRenderTree/mac/DumpRenderTree.mm:
4266         (createWebViewAndOffscreenWindow): cleanup
4267         (destroyWebViewAndOffscreenWindow): cleanup
4268         (dumpRenderTree):
4269         (changeWindowScaleIfNeeded):
4270         (runTest):
4271         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
4272         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
4273         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
4274         * WebKitTestRunner/PlatformWebView.h:
4275         * WebKitTestRunner/TestInvocation.cpp:
4276         (WTR::changeWindowScaleIfNeeded):
4277         (WTR::TestInvocation::invoke):
4278         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4279         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4280         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4281         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4282         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4283         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4284         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4285         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4286
4287 2014-02-28  Anders Carlsson  <andersca@apple.com>
4288
4289         Remove logging.
4290
4291         Reviewed by Dan Bernstein.
4292
4293         * MiniBrowser/mac/WK2BrowserWindowController.m:
4294         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
4295
4296 2014-02-28  Daniel Bates  <dabates@apple.com>
4297
4298         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
4299         https://bugs.webkit.org/show_bug.cgi?id=129163
4300
4301         Reviewed by David Kilzer.
4302
4303         Fixes an issue where DumpRenderTree Perl Support may build with the specified
4304         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
4305         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
4306         bundle.
4307
4308         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
4309         which is specified either explicitly when building with MAKE(1) or implicitly by
4310         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
4311         the OS X SDK and toolchain since the built products are only applicable to OS X.
4312
4313         * DumpRenderTree/ios/PerlSupport/Makefile:
4314
4315 2014-02-28  Commit Queue  <commit-queue@webkit.org>
4316
4317         Unreviewed, rolling out r164859.
4318         http://trac.webkit.org/changeset/164859
4319         https://bugs.webkit.org/show_bug.cgi?id=129483
4320
4321         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
4322         #webkit).
4323
4324         * DumpRenderTree/mac/DumpRenderTree.mm:
4325         (createWebViewAndOffscreenWindow):