Adopt SimServiceContext in LayoutTestRelay
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
2
3         Adopt SimServiceContext in LayoutTestRelay
4         https://bugs.webkit.org/show_bug.cgi?id=161000
5         <rdar://problem/25765594>
6
7         Reviewed by Daniel Bates.
8
9         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
10         * LayoutTestRelay/LayoutTestRelay/main.m:
11
12 2016-08-19  Lucas Forschler  <lforschler@apple.com>
13
14         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
15
16         Reviewed by Kocsen Chung.
17
18         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
19         (WebKitBuildbot):
20
21 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
22
23         Partial revert of r203811 - this key is not needed.
24
25         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
26
27 2016-08-19  Daniel Bates  <dabates@apple.com>
28
29         Another attempt to fix the iOS 9.3 build
30
31         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
32
33         * DumpRenderTree/mac/Configurations/Base.xcconfig:
34         * WebKitTestRunner/Configurations/Base.xcconfig:
35
36 2016-08-19  Lucas Forschler  <lforschler@apple.com>
37
38         Remove Yosemite Leaks bot from config.json
39         
40         Reviewed by Alexey Proskuryakov.
41
42         * BuildSlaveSupport/build.webkit.org-config/config.json:
43
44 2016-08-18  Dan Bernstein  <mitz@apple.com>
45
46         [Cocoa] API::Number needs to be wrapped by an NSNumber
47         https://bugs.webkit.org/show_bug.cgi?id=160977
48         <rdar://problem/27877735>
49
50         Reviewed by Anders Carlsson.
51
52         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
53         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
54         (TestWebKitAPI::TEST):
55
56 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
57
58         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
59         https://bugs.webkit.org/show_bug.cgi?id=160895
60
61         Reviewed by Dean Jackson.
62
63         Link to the existing CoreText framework.
64
65         * DumpRenderTree/PlatformWin.cmake:
66         * TestWebKitAPI/PlatformWin.cmake:
67
68 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
69
70         [Win] Remove old libraries from build inputs
71         https://bugs.webkit.org/show_bug.cgi?id=160949
72
73         Reviewed by Dean Jackson.
74
75         Modify the download script to remove the old 'icuuc.lib' and
76         'icuin.lib' files for Windows builds.
77
78         * Scripts/update-webkit-auxiliary-libs:
79
80 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
81
82         Extra logging for crash reason
83         https://bugs.webkit.org/show_bug.cgi?id=160943
84
85         Reviewed by Alexey Proskuryakov.
86
87         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
88
89         * Scripts/webkitpy/port/server_process.py:
90         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
91         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
92         (ServerProcess.has_crashed): Ditto.
93
94 2016-08-17  Dan Bernstein  <mitz@apple.com>
95
96         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
97         https://bugs.webkit.org/show_bug.cgi?id=160938
98         <rdar://problem/27876652>
99
100         Reviewed by Anders Carlsson.
101
102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
103         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
104         (TestWebKitAPI::TEST):
105
106 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
107
108         AX: Support abbreviations in iOS
109         https://bugs.webkit.org/show_bug.cgi?id=160907
110
111         Reviewed by Joanmarie Diggs.
112
113         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
114         (AccessibilityUIElement::stringAttributeValue):
115         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
116         (WTR::AccessibilityUIElement::stringAttributeValue):
117
118 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
119
120         [EFL] Bump efl version from 1.17 to 1.18
121         https://bugs.webkit.org/show_bug.cgi?id=160899
122
123         Reviewed by Antonio Gomes.
124
125         To use efl-1.18, EFL port needs to update install dependencies as well.
126
127         * efl/install-dependencies:
128         * efl/jhbuild.modules:
129
130 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
131
132         [Win] Add tests for linked fonts.
133         https://bugs.webkit.org/show_bug.cgi?id=160898
134
135         Reviewed by Brent Fulgham.
136
137         Add tests for https://trac.webkit.org/changeset/204502.
138
139         * TestWebKitAPI/PlatformWin.cmake:
140         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
141         (TestWebKitAPI::TEST):
142
143 2016-08-16  Daniel Bates  <dabates@apple.com>
144
145         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
146         https://bugs.webkit.org/show_bug.cgi?id=160924
147
148         Reviewed by Stephanie Lewis.
149
150         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
151         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
152         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
153         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
154         object that mocks out the file system and SCM operations.
155
156         * Scripts/VCSUtils.pm:
157         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
158         * Scripts/prepare-ChangeLog:
159         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
160         abstracting the logic to query the file system and SCM into functions on a delegate object that
161         we pass to it.
162         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
163         (diffHeaderFormat): Deleted.
164
165 2016-08-16  Alex Christensen  <achristensen@webkit.org>
166
167         URLParser should parse URLs without credentials
168         https://bugs.webkit.org/show_bug.cgi?id=160913
169
170         Reviewed by Brady Eidson.
171
172         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
173         (TestWebKitAPI::s):
174         (TestWebKitAPI::checkURL):
175         (TestWebKitAPI::TEST_F):
176
177 2016-08-16  Anders Carlsson  <andersca@apple.com>
178
179         Add WTF::ScopeExit
180         https://bugs.webkit.org/show_bug.cgi?id=160908
181
182         Reviewed by Geoffrey Garen.
183
184         * TestWebKitAPI/CMakeLists.txt:
185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
186         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
187         (TestWebKitAPI::TEST):
188
189 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
190
191         EWS logs file are rotated too quickly
192         https://bugs.webkit.org/show_bug.cgi?id=160724
193
194         Reviewed by Daniel Bates.
195
196         Currently we are rotating the log file after 10 iterations of queue. If the queue
197         doesn't have any pending patches, these iterations result in very small amount of 
198         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
199         This results in a lot of log files in a day. This patch ensures that we rotate the
200         log file when its file size is greater than or equal to 100 KB.
201
202         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
203
204 2016-08-16  Daniel Bates  <dabates@apple.com>
205
206         WKSI static library should be named by major iOS revision, not individual updates
207         https://bugs.webkit.org/show_bug.cgi?id=160727
208         <rdar://problem/22274848>
209
210         Reviewed by Alexey Proskuryakov.
211
212         * DumpRenderTree/mac/Configurations/Base.xcconfig:
213         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
214         * Scripts/copy-webkitlibraries-to-product-directory:
215         * WebKitTestRunner/Configurations/Base.xcconfig:
216         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
217
218 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
219
220         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
221         https://bugs.webkit.org/show_bug.cgi?id=160909
222
223         Reviewed by Enrica Casucci.
224         
225         Add functions to UIScriptController to dismiss the form accessory view for iOS,
226         and to programmatically pick a row from a <select> picker.
227
228         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
229         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
230         (WTR::UIScriptController::dismissFormAccessoryView):
231         (WTR::UIScriptController::selectFormAccessoryPickerRow):
232         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
233         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
234         (WTR::UIScriptController::dismissFormAccessoryView):
235         (WTR::UIScriptController::selectFormAccessoryPickerRow):
236
237 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
238
239         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
240         https://bugs.webkit.org/show_bug.cgi?id=160878
241
242         Reviewed by Tim Horton.
243         
244         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
245         now that we have the ability to run tests in the iPad simulator.
246
247         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
248         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
249         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
250         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
251         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
252         * WebKitTestRunner/ios/TestControllerIOS.mm:
253         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
254         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
255         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
256         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
257
258 2016-08-15  Anders Carlsson  <andersca@apple.com>
259
260         Add an address-of operator to RetainPtr
261         https://bugs.webkit.org/show_bug.cgi?id=160879
262
263         Reviewed by Tim Horton.
264
265         Test HashMap and HashSet with an object whose operator& is deleted.
266
267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
268         Sort the Xcode project.
269
270         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
271         (DeletedAddressOfOperator::DeletedAddressOfOperator):
272         (DeletedAddressOfOperator::value):
273         (DeletedAddressOfOperator::operator==):
274         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
275         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
276         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
277         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
278         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
279         (TestWebKitAPI::TEST):
280         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
281         (TestWebKitAPI::TEST):
282
283 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
284
285         False crashes in fast/text/emoji-gender-* tests
286         https://bugs.webkit.org/show_bug.cgi?id=160779
287
288         Reviewed by Alexey Proskuryakov.
289
290         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
291
292         * Scripts/webkitpy/port/driver.py:
293         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
294         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
295         * Scripts/webkitpy/port/server_process.py:
296         (ServerProcess.write): Allow caller to disable crash flag on exception.
297
298 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
299
300         webkitpy error in TestRunResults.merge()
301         https://bugs.webkit.org/show_bug.cgi?id=160882
302
303         Reviewed by Daniel Bates.
304         
305         The argument to TestRunResults.merge() can be None if there are no device-specifc
306         initial results or retry results in Manager.run(), so just return early in that case.
307
308         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
309         (TestRunResults.merge):
310
311 2016-08-15  Sam Weinig  <sam@webkit.org>
312
313         Speed up compile times by not including wtf/Variant.h so much
314         https://bugs.webkit.org/show_bug.cgi?id=160847
315
316         Reviewed by Alex Christensen and Saam Barati.
317
318         * TestWebKitAPI/Tests/WTF/Variant.cpp:
319         (TestWebKitAPI::TEST):
320         Explicitly use std::experimental::variant.
321
322 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
323
324         Allow a port to run tests with a custom device setup
325         https://bugs.webkit.org/show_bug.cgi?id=160833
326
327         Reviewed by Daniel Bates.
328
329         These changes allow the IOSSimulator port to run tests in iPad mode.
330
331         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
332         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
333         a custom device will be collected into a set, and run in that device's environment after
334         the other tests have run.
335
336         * Scripts/webkitpy/layout_tests/controllers/manager.py:
337         (Manager._custom_device_for_test): If the test contains a directory matching a
338         custom device suffix, return that custom device.
339         (Manager._set_up_run): Push the custom device class, if any, into options so
340         that the Worker can get to it.
341         (Manager.run): Go through the list of tests, and break it down into device-generic
342         tests, and tests for each device class. _run_test_subset is then called for
343         each collection of tests, and the results merged.
344         (Manager._run_test_subset): Some lines unwrapped.
345         (Manager._end_test_run):
346         (Manager._run_tests):
347         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
348         (SingleTestRunner.__init__): Unwrapped a line.
349         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
350         (TestRunResults.merge): Add this function to merge TestRunResults
351         * Scripts/webkitpy/layout_tests/views/printing.py:
352         (Printer.print_workers_and_shards): Print the custom device, if any.
353         * Scripts/webkitpy/port/base.py:
354         (Port): Base port has empty array of custom devices.
355         (Port.setup_test_run): Add device_class argument.
356         * Scripts/webkitpy/port/driver.py:
357         (DriverInput.__repr__):
358         (Driver.check_driver.implementation):
359         * Scripts/webkitpy/port/efl.py:
360         (EflPort.setup_test_run):
361         * Scripts/webkitpy/port/gtk.py:
362         (GtkPort.setup_test_run):
363         * Scripts/webkitpy/port/ios.py:
364         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
365         (IOSSimulatorPort.__init__):
366         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
367         based on the custom device class.
368         (IOSSimulatorPort._set_device_class):
369         (IOSSimulatorPort._create_simulators): Factor some code into this function.
370         (IOSSimulatorPort.setup_test_run):
371         (IOSSimulatorPort.testing_device):
372         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
373         seemed wrong for this function. That was moved to setup_test_run().
374         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
375         but this happened too early, before we knew which kind of devices to create. Devices
376         are now created in setup_test_run().
377         * Scripts/webkitpy/port/win.py:
378         (WinPort.setup_test_run):
379
380 2016-08-15  Daniel Bates  <dabates@apple.com>
381
382         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
383         private frameworks and libraries
384         https://bugs.webkit.org/show_bug.cgi?id=155931
385         <rdar://problem/25807989>
386
387         Reviewed by Dan Bernstein.
388
389         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
390         where X is the major version of the active iOS SDK.
391
392         * DumpRenderTree/mac/Configurations/Base.xcconfig:
393         * WebKitTestRunner/Configurations/Base.xcconfig:
394
395 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
396
397         Add a setting and preferences to enable visual viewport mode
398         https://bugs.webkit.org/show_bug.cgi?id=160843
399
400         Reviewed by Sam Weinig.
401         
402         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
403
404         * MiniBrowser/mac/SettingsController.h:
405         * MiniBrowser/mac/SettingsController.m:
406         (-[SettingsController _populateMenu]):
407         (-[SettingsController validateMenuItem:]):
408         (-[SettingsController visualViewportEnabled]):
409         (-[SettingsController toggleVisualViewportEnabled:]):
410         * MiniBrowser/mac/WK1BrowserWindowController.m:
411         (-[WK1BrowserWindowController didChangeSettings]):
412         * MiniBrowser/mac/WK2BrowserWindowController.m:
413         (-[WK2BrowserWindowController didChangeSettings]):
414
415 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
416
417         Allow using make-dist with non-GTK ports
418         https://bugs.webkit.org/show_bug.cgi?id=160842
419
420         Reviewed by Michael Catanzaro.
421
422         This patch adds support for setting base name of tarball and argument
423         passed to cmake's -DPORT= via command line arguments.
424
425         * gtk/make-dist.py:
426         (Distcheck.configure):
427         (Distcheck.check):
428         (get_tarball_root_and_output_filename_from_arguments):
429
430 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
431
432         [GTK] Install script lacks gstreamer related dependencies
433         https://bugs.webkit.org/show_bug.cgi?id=160814
434
435         Reviewed by Carlos Garcia Campos.
436
437         * gtk/install-dependencies: Fedora case had already listed this dependencies,
438         but both Arch and Debian/Ubuntu were missing them.
439
440 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
441
442         make-dist.py should not allow unknown rules in manifest
443         https://bugs.webkit.org/show_bug.cgi?id=160841
444
445         Reviewed by Carlos Garcia Campos.
446
447         * gtk/make-dist.py:
448         (Manifest.process_line):
449
450 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
451
452         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
453         https://bugs.webkit.org/show_bug.cgi?id=160809
454
455         Reviewed by Carlos Garcia Campos.
456
457         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
458         case, and use it also for the new package names of libpng and libgeoclue.
459         * gtk/install-dependencies: Ditto.
460
461 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
462
463         Skip to check directories existence in build-webkit
464         https://bugs.webkit.org/show_bug.cgi?id=160691
465
466         Reviewed by Alex Christensen.
467
468         CMake checks if directories are there itself. So CMake ports
469         don't need to check it in the build-webkit script.
470
471         * Scripts/build-webkit:
472         * Scripts/webkitdirs.pm:
473         (determineSourceDir):
474         (isCMakeBuild):
475
476 2016-08-12  Alex Christensen  <achristensen@webkit.org>
477
478         Make URLParser work with URLs missing URL parts
479         https://bugs.webkit.org/show_bug.cgi?id=160824
480
481         Reviewed by Brady Eidson.
482
483         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
484         (TestWebKitAPI::s):
485         (TestWebKitAPI::checkURL):
486         (TestWebKitAPI::TEST_F):
487         (TestWebKitAPI::eq): Deleted.
488
489 2016-08-12  John Wilander  <wilander@apple.com>
490
491         Add HashCountedSet API tests to TestWTFLibrary target
492         https://bugs.webkit.org/show_bug.cgi?id=160815
493
494         Reviewed by Alex Christensen.
495
496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
497             Added HashCountedSet.cpp and sorted the file reference section
498             according to UNIX sort.
499
500 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
501
502         run-benchmark should run JetStream 1.1 instead of 1.0.1
503         https://bugs.webkit.org/show_bug.cgi?id=160816
504
505         Reviewed by Filip Pizlo.
506
507         Use the latest JetStream 1.1 in run-benchmark.
508
509         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
510         (BenchmarkBuilder.__exit__):
511         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
512         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
513         change to JetStream directory.
514
515 2016-08-12  Alex Christensen  <achristensen@webkit.org>
516
517         Initial URLParser implementation
518         https://bugs.webkit.org/show_bug.cgi?id=160811
519
520         Reviewed by Brady Eidson.
521
522         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
523         (TestWebKitAPI::eq):
524         (TestWebKitAPI::checkURL):
525         (TestWebKitAPI::TEST_F):
526
527 2016-08-12  Brady Eidson  <beidson@apple.com>
528
529         Fix the 32-bit Mac build after:
530         Add WK2 ExperimentalFeature support to MiniBrowser
531         https://bugs.webkit.org/show_bug.cgi?id=160788
532
533         Unreviewed.
534
535         Sprinkle "#if WK_API_ENABLED"s liberally.
536         
537         * MiniBrowser/mac/AppDelegate.m:
538         (defaultConfiguration):
539         * MiniBrowser/mac/SettingsController.m:
540         (-[SettingsController _populateMenu]):
541         (-[SettingsController validateMenuItem:]):
542
543 2016-08-12  Philippe Normand  <pnormand@igalia.com>
544
545         [GStreamer][OWR] Video rendering fixes
546         https://bugs.webkit.org/show_bug.cgi?id=160764
547
548         Reviewed by Xabier Rodriguez-Calvar.
549
550         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
551
552 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
553
554         Add missing return statement in convertFast function added in r204376.
555
556         Unreviewed.
557
558         * Scripts/webkitpy/common/system/path.py:
559         (_CygPath.convertFast):
560
561 2016-08-11  Brady Eidson  <beidson@apple.com>
562
563         Add WK2 ExperimentalFeature support to MiniBrowser.
564         https://bugs.webkit.org/show_bug.cgi?id=160788
565
566         Reviewed by Alex Christensen.
567
568         * MiniBrowser/mac/AppDelegate.h:
569         * MiniBrowser/mac/AppDelegate.m:
570         (defaultConfiguration):
571         (defaultPreferences):
572         
573         * MiniBrowser/mac/SettingsController.m:
574         (-[SettingsController _populateMenu]):
575         (-[SettingsController validateMenuItem:]):
576         (-[SettingsController toggleExperimentalFeature:]):
577
578 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
579
580         Keep EWS logs for longer
581         https://bugs.webkit.org/show_bug.cgi?id=160776
582
583         Reviewed by Daniel Bates.
584
585         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
586
587 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
588
589         iOS DRT/WTR project cleanup
590         https://bugs.webkit.org/show_bug.cgi?id=160778
591
592         Reviewed by Tim Horton.
593
594         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
595
596         Remove AppDelegate.* which were unused.
597
598         Exclude ios/Launch.storyboard on more platforms.
599
600         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
601         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
602         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
603         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
604         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
605         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
606         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
607
608 2016-08-11  Alex Christensen  <achristensen@webkit.org>
609
610         Fix Yosemite bots' cookie accept policies after r204365.
611         https://bugs.webkit.org/show_bug.cgi?id=160758
612
613         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
614         (TEST):
615         This makes the test fully clean up after itself.
616
617 2016-08-11  Alex Christensen  <achristensen@webkit.org>
618
619         Fix Yosemite bots' cookie accept policies after r204365.
620         https://bugs.webkit.org/show_bug.cgi?id=160758
621
622         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
623         (TEST):
624         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
625         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
626         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
627         causing any problems because there are no other API tests that do anything with cookies.
628         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
629         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
630         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
631
632 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
633
634         EWS should check if the patch is still valid before executing every major step
635         https://bugs.webkit.org/show_bug.cgi?id=160739
636         rdar://problem/27768813
637
638         Reviewed by Alexey Proskuryakov.
639
640         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
641         (CommitQueueTask.run): validate method is now executed in base class.
642         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
643         (EarlyWarningSystemTask.run): validate method is now executed in base class.
644         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
645         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
646         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
647         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
648         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
649         * Scripts/webkitpy/tool/commands/perfalizer.py:
650         (PerfalizerTask.validate): Added.
651         * Scripts/webkitpy/tool/commands/queues_unittest.py:
652         (test_manual_reject_during_processing): Updated test case.
653
654 2016-08-11  Alex Christensen  <achristensen@webkit.org>
655
656         Add URLParser stub
657         https://bugs.webkit.org/show_bug.cgi?id=160770
658
659         Reviewed by Sam Weinig.
660
661         * TestWebKitAPI/PlatformGTK.cmake:
662         * TestWebKitAPI/PlatformWin.cmake:
663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
664         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
665         (TestWebKitAPI::TEST_F):
666
667 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
668
669         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
670         https://bugs.webkit.org/show_bug.cgi?id=160761
671
672         Reviewed by Tim Horton.
673
674         Give iOS DRT a Launch storyboard.
675
676         Have it use a UIViewController so future forms testing works correctly.
677
678         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
679         can run in iPad mode.
680
681         Remove empty InfoPlist.strings files.
682
683         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
684         * DumpRenderTree/ios/Info.plist:
685         * DumpRenderTree/ios/Launch.storyboard: Added.
686         * DumpRenderTree/mac/DumpRenderTree.mm:
687         (createWebViewAndOffscreenWindow):
688         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
689         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
690         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
691         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
692
693 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
694
695         [Win] Unable to reliably run tests in parallel
696         https://bugs.webkit.org/show_bug.cgi?id=140914
697
698         Reviewed by Brent Fulgham.
699
700         The cygpath utility function can fail badly when running with multiple DumpRenderTree
701         processes. We can use string replacement to convert the Cygwin path to a Windows path
702         instead.
703
704         * Scripts/webkitpy/common/system/path.py:
705         (cygpathFast):
706         * Scripts/webkitpy/port/driver.py:
707         (Driver._command_from_driver_input):
708
709 2016-08-10  Alex Christensen  <achristensen@webkit.org>
710
711         Fix crash when changing cookie accept policy after r204327
712         https://bugs.webkit.org/show_bug.cgi?id=160758
713
714         Reviewed by Simon Fraser.
715
716         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
717         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
718         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
719         (TEST):
720         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
721
722 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
723
724         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
725         https://bugs.webkit.org/show_bug.cgi?id=160757
726
727         Reviewed by Tim Horton.
728
729         When programmatically creating the test UIWindow, make a root UIViewController and parent
730         the WKWebView in its view. This makes the app more like a normal UIKit application.
731         
732         Move the WKWebView down 20px to avoid the status bar.
733         
734         Give the UIWindow a gray background so it's obvious where the window and view positioned.
735
736         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
737         
738         Remove duplicate references to Launch.storyboard.
739
740         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
741         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
742         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
743         (-[AppDelegate applicationWillResignActive:]): Deleted.
744         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
745         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
746         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
747         (-[AppDelegate applicationWillTerminate:]): Deleted.
748         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
749         (WTR::viewRectForWindowRect):
750         (WTR::PlatformWebView::PlatformWebView):
751         (WTR::PlatformWebView::setWindowFrame):
752
753 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
754
755         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
756         https://bugs.webkit.org/show_bug.cgi?id=160748
757
758         Reviewed by Tim Horton.
759         
760         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
761         opens the door for tests using other device sizes.
762
763         * WebKitTestRunner/ios/TestControllerIOS.mm:
764         (WTR::TestController::platformConfigureViewForTest):
765
766 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
767
768         Sort the feature flags in the FEATURE_DEFINES lines
769         https://bugs.webkit.org/show_bug.cgi?id=160742
770
771         Reviewed by Anders Carlsson.
772         
773         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
774
775 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
776
777         Logging and other minor improvements to iOS webkitpy
778         https://bugs.webkit.org/show_bug.cgi?id=160722
779
780         Reviewed by Dan Bates.
781
782         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
783         to make it easier to debug launching issues.
784
785         Have reset_preferences() reset the device, rather than just nuking the data
786         directory (which broke some versions of the simulator).
787
788         Make the Simulator.app launch in the background with open -g.
789
790         Wait for the simulator device to be in a known state in some more places.
791
792         * Scripts/webkitpy/port/ios.py:
793         (IOSSimulatorPort.setup_test_run):
794         (IOSSimulatorPort._quit_ios_simulator):
795         (IOSSimulatorPort.clean_up_test_run):
796         (IOSSimulatorPort.setup_environ_for_server):
797         (IOSSimulatorPort.reset_preferences):
798         * Scripts/webkitpy/xcode/simulator.py:
799         (Device.create):
800         (Device.delete):
801         (Device):
802         (Device.reset):
803         (Simulator.wait_until_device_is_booted):
804         (Simulator.wait_until_device_is_in_state):
805         (Simulator):
806         (Simulator.delete_device):
807         (Simulator.reset_device):
808         (Simulator.lookup_or_create_device):
809
810 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
811
812         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
813         https://bugs.webkit.org/show_bug.cgi?id=160697
814
815         Reviewed by Antonio Gomes.
816
817         * Scripts/webkitpy/port/base.py:
818         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
819         list of environment variables to copy.
820
821 2016-08-09  George Ruan  <gruan@apple.com>
822
823         Implement functionality of media capture on iOS
824         https://bugs.webkit.org/show_bug.cgi?id=158945
825         <rdar://problem/26893343>
826
827         Reviewed by Tim Horton.
828
829         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
830         Capture feature on iOS.
831
832 2016-08-09  Saam Barati  <sbarati@apple.com>
833
834         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
835         https://bugs.webkit.org/show_bug.cgi?id=160671
836         <rdar://problem/27756112>
837
838         Reviewed by Mark Lam.
839
840         * Scripts/run-jsc-stress-tests:
841
842 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
843
844         Make directory reading code in iOSSimulatorDevices() more strict
845         https://bugs.webkit.org/show_bug.cgi?id=160702
846
847         Reviewed by Tim Horton.
848
849         * Scripts/webkitdirs.pm:
850         (iOSSimulatorDevices):
851
852 2016-08-06  Sam Weinig  <sam@webkit.org>
853
854         Replace NodeOrString with std::variant<RefPtr<Node>, String>
855         https://bugs.webkit.org/show_bug.cgi?id=160638
856
857         Reviewed by Anders Carlsson.
858
859         * TestWebKitAPI/CMakeLists.txt:
860         * TestWebKitAPI/Tests/WTF/Variant.cpp:
861         Add additional tests for the initial state of std::variant and using
862         makeVisitor for visiting.
863
864 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
865
866         EWS logging should ensure the logging to file is stopped on queue termination
867         https://bugs.webkit.org/show_bug.cgi?id=160698
868         rdar://problem/24464570
869
870         Reviewed by Daniel Bates.
871
872         * Scripts/webkitpy/tool/bot/queueengine.py:
873         (QueueEngine._stopping): Stop logging to file on queue termination.
874         (QueueEngine._begin_logging): Configure the Python logger to log to file.
875         * Scripts/webkitpy/common/system/logutils.py:
876         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
877         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
878         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
879         * Scripts/webkitpy/tool/commands/queues.py:
880         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
881         (AbstractQueue.queue_log_path): Same.
882         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
883         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
884         which moved to QueueEngine now.
885         (PatchProcessingQueue.__init__): Same.
886         (CommitQueue.__init__): Same.
887         (AbstractReviewQueue.__init__): Same.
888         (StyleQueue.__init__): Same.
889         * Scripts/webkitpy/tool/commands/queues_unittest.py:
890         (TestCommitQueue): Removed host parameter.
891         (TestCommitQueue.__init__): Same.
892         (AbstractPatchQueueTest.test_next_patch): Same.
893         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
894         (test_commit_queue_failure): Same.
895         (mock_run_webkit_patch):
896         (MockCommitQueueTask.results_from_patch_test_run): Same.
897         (test_rollout_lands): Same.
898         (test_non_valid_patch): Same.
899         (test_auto_retry): Same.
900         (test_style_queue_with_watch_list_exception): Same.
901         (TestQueue.__init__): Deleted.
902         (TestReviewQueue.__init__): Deleted.
903         (TestFeederQueue.__init__): Deleted.
904
905 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
906
907         webkit-gtk tarball fails to build due to missing files
908         https://bugs.webkit.org/show_bug.cgi?id=160684
909
910         Reviewed by Alex Christensen.
911
912         * gtk/manifest.txt.in: Added back spi directories.
913
914 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
915
916         [GTK] Build the jhbuild with -O2 optimization level by default
917         https://bugs.webkit.org/show_bug.cgi?id=160544
918
919         Reviewed by Michael Catanzaro.
920
921         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
922         which don't increases the required disk space significatively and
923         provides better debug information than no passing it.
924
925 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
926
927         Allow more --cmakeargs option in build-jsc and build-webkit
928         https://bugs.webkit.org/show_bug.cgi?id=160340
929
930         Reviewed by Michael Catanzaro.
931
932         * Scripts/build-jsc:
933         * Scripts/build-webkit:
934
935 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
936
937         Do not check if WebKitLibraries folder exists on EFL and GTK
938         https://bugs.webkit.org/show_bug.cgi?id=160659
939
940         Reviewed by Csaba Osztrogonác.
941
942         Though WebKitLibraries is only needed by mac and win ports,
943         EFL and GTK ports have checked whether it exists.
944
945         * Scripts/build-webkit:
946
947 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
948
949         Some EWS console logs doesn't go to log file
950         https://bugs.webkit.org/show_bug.cgi?id=160585
951         rdar://problem/24464570
952
953         Reviewed by Daniel Bates.
954
955         * Scripts/webkitpy/common/system/logutils.py:
956         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
957         any possible overwriting.
958         * Scripts/webkitpy/common/system/filesystem.py:
959         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
960         * Scripts/webkitpy/common/system/filesystem_mock.py:
961         (MockFileSystem.open_text_file_for_writing): Same.
962         * Scripts/webkitpy/common/system/filesystem_unittest.py:
963         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
964         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
965         * Scripts/webkitpy/tool/commands/queues.py:
966         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
967         This will ensure that all the sub-modules inside webkitpy will log to file.
968
969 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
970
971         Have the iOS platform interit from the Apple platform in webkitpy
972         https://bugs.webkit.org/show_bug.cgi?id=160672
973
974         Reviewed by Dan Bates.
975         
976         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
977         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
978         ApplePort.
979         
980         Since WinPort also inherits from ApplePort, it needs to stub out some things
981         that are unavailable on Windows (leaks, sampling).
982         
983         Some SnowLeopard-related code and the associated test were removed.
984
985         * Scripts/webkitpy/port/apple.py:
986         (ApplePort.__init__):
987         (ApplePort):
988         (ApplePort._make_leak_detector):
989         (ApplePort.default_timeout_ms):
990         (ApplePort.supports_per_test_timeout):
991         (ApplePort.should_retry_crashes):
992         (ApplePort._generate_all_test_configurations):
993         (ApplePort.check_for_leaks):
994         (ApplePort.print_leaks_summary):
995         (ApplePort._path_to_webcore_library):
996         (ApplePort.show_results_html_file):
997         (ApplePort._merge_crash_logs):
998         (ApplePort._look_for_all_crash_logs_in_log_dir):
999         (ApplePort._get_crash_log):
1000         (ApplePort.look_for_new_crash_logs):
1001         (ApplePort.sample_process):
1002         (ApplePort.sample_file_path):
1003         (ApplePort.look_for_new_samples):
1004         (ApplePort._path_to_helper):
1005         (ApplePort.determine_full_port_name): Deleted.
1006         * Scripts/webkitpy/port/ios.py:
1007         (IOSSimulatorPort):
1008         (IOSSimulatorPort.__init__):
1009         (IOSSimulatorPort.default_timeout_ms): Deleted.
1010         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
1011         (IOSSimulatorPort.should_retry_crashes): Deleted.
1012         (IOSSimulatorPort.check_for_leaks): Deleted.
1013         (IOSSimulatorPort.print_leaks_summary): Deleted.
1014         (IOSSimulatorPort._path_to_webcore_library): Deleted.
1015         (IOSSimulatorPort.show_results_html_file): Deleted.
1016         (IOSSimulatorPort.sample_file_path): Deleted.
1017         (IOSSimulatorPort._merge_crash_logs): Deleted.
1018         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
1019         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
1020         (IOSSimulatorPort.look_for_new_samples): Deleted.
1021         (IOSSimulatorPort.sample_process): Deleted.
1022         (IOSSimulatorPort._path_to_helper): Deleted.
1023         (IOSSimulatorPort.make_command): Deleted.
1024         * Scripts/webkitpy/port/mac.py:
1025         (MacPort.__init__):
1026         (MacPort.make_command):
1027         (MacPort._build_java_test_support):
1028         (MacPort): Deleted.
1029         (MacPort.default_timeout_ms): Deleted.
1030         (MacPort.supports_per_test_timeout): Deleted.
1031         (MacPort.should_retry_crashes): Deleted.
1032         (MacPort.default_child_processes): Deleted.
1033         (MacPort.check_for_leaks): Deleted.
1034         (MacPort.print_leaks_summary): Deleted.
1035         (MacPort._path_to_webcore_library): Deleted.
1036         (MacPort.show_results_html_file): Deleted.
1037         (MacPort.sample_file_path): Deleted.
1038         (MacPort._merge_crash_logs): Deleted.
1039         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
1040         (MacPort.look_for_new_crash_logs): Deleted.
1041         (MacPort.look_for_new_samples): Deleted.
1042         (MacPort.sample_process): Deleted.
1043         (MacPort._path_to_helper): Deleted.
1044         * Scripts/webkitpy/port/mac_unittest.py:
1045         (MacTest.test_default_child_processes): Deleted.
1046         * Scripts/webkitpy/port/win.py:
1047         (WinPort.look_for_new_samples):
1048         (WinPort):
1049         (WinPort.sample_process):
1050         (WinPort._make_leak_detector):
1051         (WinPort.check_for_leaks):
1052         (WinPort.print_leaks_summary):
1053         (WinPort._path_to_webcore_library):
1054
1055 2016-08-08  Matt Baker  <mattbaker@apple.com>
1056
1057         Unreviewed: moved myself to the reviewers list.
1058
1059         * Scripts/webkitpy/common/config/contributors.json:
1060
1061 2016-08-08  Chris Dumez  <cdumez@apple.com>
1062
1063         Update API tests in mac/SetDocumentURI.mm after r204247
1064         https://bugs.webkit.org/show_bug.cgi?id=160660
1065
1066         Reviewed by Alex Christensen.
1067
1068         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1069         (TestWebKitAPI::TEST):
1070
1071 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
1072
1073         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
1074         https://bugs.webkit.org/show_bug.cgi?id=159827
1075
1076         Reviewed by Daniel Bates.
1077
1078         This change was spurred by a process hang which occurred between tests and did
1079         not produce a meaningful crashlog.
1080
1081         * Scripts/webkitpy/port/driver.py:
1082         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
1083
1084          * Scripts/webkitpy/port/ios.py:
1085         (IOSSimulatorPort):
1086         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
1087         * Scripts/webkitpy/port/mac.py:
1088         (MacPort):
1089         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
1090
1091         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
1092         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1093
1094         * WebKitTestRunner/TestController.h:
1095         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1096         * WebKitTestRunner/TestInvocation.cpp:
1097         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1098
1099 2016-08-07  Dan Bernstein  <mitz@apple.com>
1100
1101         [Cocoa] Reply block leaks if the remote object doesn’t call it
1102         https://bugs.webkit.org/show_bug.cgi?id=160642
1103
1104         Reviewed by Sam Weinig.
1105
1106         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
1107         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1108         (TEST): Added a test case that checks that the reply block is released even when it’s not
1109           called.
1110         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1111         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
1112           calling the completion handler.
1113
1114 2016-08-07  Chris Dumez  <cdumez@apple.com>
1115
1116         Write API test to cover crash fix in r204135
1117         https://bugs.webkit.org/show_bug.cgi?id=160587
1118
1119         Reviewed by Darin Adler.
1120
1121         Add API test to cover crash fix in r204135. This reproduces the crash
1122         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1123         callback.
1124
1125         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1126         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1127         (TEST):
1128
1129 2016-08-06  Chris Dumez  <cdumez@apple.com>
1130
1131         Unreviewed, rolling out r204226.
1132
1133         Broke some API tests
1134
1135         Reverted changeset:
1136
1137         "Write API test to cover crash fix in r204135"
1138         https://bugs.webkit.org/show_bug.cgi?id=160587
1139         http://trac.webkit.org/changeset/204226
1140
1141 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
1142
1143         EWS Style Queue fails to process patches which fails validation
1144         https://bugs.webkit.org/show_bug.cgi?id=160632
1145
1146         Reviewed by Alexey Proskuryakov.
1147
1148         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1149         (StyleQueueTask.validate): Add more information about validation failure.
1150         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1151         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1152         (test_non_valid_patch): Add a unit test to test the above code path.
1153
1154 2016-08-06  Sam Weinig  <sam@webkit.org>
1155
1156         WTF needs a variant implementation
1157         https://bugs.webkit.org/show_bug.cgi?id=160618
1158
1159         Reviewed by Darin Adler.
1160
1161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1162         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
1163         Add tests for the variant implementation.
1164
1165 2016-08-06  Chris Dumez  <cdumez@apple.com>
1166
1167         Write API test to cover crash fix in r204135
1168         https://bugs.webkit.org/show_bug.cgi?id=160587
1169
1170         Reviewed by Darin Adler.
1171
1172         Add API test to cover crash fix in r204135. This reproduces the crash
1173         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1174         callback.
1175
1176         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1177         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1178         (TEST):
1179
1180 2016-08-05  Tim Horton  <timothy_horton@apple.com>
1181
1182         run-api-tests should use a headed simulator
1183         https://bugs.webkit.org/show_bug.cgi?id=160611
1184
1185         Reviewed by Sam Weinig.
1186
1187         CADisplayLink doesn't work in a headless simulator, but is
1188         vital for the proper functioning of WebKit2 painting on iOS.
1189         So, we should not use a headless simulator.
1190
1191         * Scripts/run-api-tests:
1192         Launch a simulator app, don't just boot the simulator.
1193
1194         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1195         Re-enable a test that works now.
1196
1197 2016-08-05  Dan Bernstein  <mitz@apple.com>
1198
1199         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
1200         https://bugs.webkit.org/show_bug.cgi?id=160589
1201
1202         Reviewed by Tim Horton.
1203
1204         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1205         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
1206           blocks, which wasn’t caught because the test wasn’t run correctly.
1207         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1208         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
1209           added a test that sends over an NSRange.
1210         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1211         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
1212           handler with the range‘s location and length.
1213
1214 2016-08-05  Enrica Casucci  <enrica@apple.com>
1215
1216         Fixing tests failing after r204175.
1217
1218         Unreviewed.
1219
1220         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
1221
1222 2016-08-05  Enrica Casucci  <enrica@apple.com>
1223
1224         Build fix after 204053.
1225
1226         Unreviewed.
1227
1228         * TestWebKitAPI/Configurations/Base.xcconfig:
1229         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1230         (-[MockContentFilterEnabler initWithCoder:]):
1231         (-[MockContentFilterEnabler dealloc]):
1232
1233 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
1234
1235         Print test name in "Last character read from DRT..." error message.
1236         https://bugs.webkit.org/show_bug.cgi?id=160559
1237
1238         Reviewed by Michael Catanzaro.
1239
1240         * Scripts/webkitpy/port/driver.py:
1241         (Driver.run_test):
1242         (Driver._read_first_block):
1243         (Driver._read_optional_image_block):
1244         (Driver._read_block):
1245         * Scripts/webkitpy/port/driver_unittest.py:
1246         (DriverTest.test_read_block):
1247         (DriverTest.test_read_binary_block):
1248         (DriverTest.test_read_base64_block):
1249
1250 2016-08-05  Commit Queue  <commit-queue@webkit.org>
1251
1252         Unreviewed, rolling out r204123.
1253         https://bugs.webkit.org/show_bug.cgi?id=160597
1254
1255         Caused layout test timeouts on Windows. (Requested by perarne
1256         on #webkit).
1257
1258         Reverted changeset:
1259
1260         "[Win] Unable to reliably run tests in parallel"
1261         https://bugs.webkit.org/show_bug.cgi?id=140914
1262         http://trac.webkit.org/changeset/204123
1263
1264 2016-08-04  Saam Barati  <sbarati@apple.com>
1265
1266         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1267         https://bugs.webkit.org/show_bug.cgi?id=151241
1268
1269         Reviewed by Benjamin Poulain.
1270
1271         * Scripts/run-jsc-stress-tests:
1272
1273 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1274
1275         UI improvements to Flakiness Dashboard.
1276         https://bugs.webkit.org/show_bug.cgi?id=153295
1277
1278         Reviewed by Alexey Proskuryakov.
1279
1280         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1281         (td.options-container): Center text in most fields.
1282         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1283         (createBugHTML): Text/Grammar updates.
1284         (tableHeaders): Ditto.
1285         (htmlForSingleTestRow): Ditto.
1286         (headerForTestTableHtml): Ditto.
1287         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1288         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1289
1290 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1291
1292         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1293         https://bugs.webkit.org/show_bug.cgi?id=160518
1294
1295         Reviewed by Michael Catanzaro.
1296
1297         * Scripts/webkitpy/thirdparty/__init__.py:
1298         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1299         * gtk/install-dependencies:
1300
1301 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1302
1303         Optimize bot watcher's dashboard a little
1304         https://bugs.webkit.org/show_bug.cgi?id=160515
1305         rdar://problem/26096900
1306
1307         Reviewed by Lucas Forschler.
1308
1309         Made re-sorting after loading an iteration more efficient.
1310
1311         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1312         (BuildbotIteration.prototype._updateWithData):
1313         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1314         (BuildbotQueue.prototype.updateIterationPosition):
1315
1316 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1317
1318         [Win] Unable to reliably run tests in parallel
1319         https://bugs.webkit.org/show_bug.cgi?id=140914
1320
1321         Reviewed by Brent Fulgham.
1322
1323         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1324         processes. We can use string replacement to convert the Cygwin path to a Windows path
1325         instead.
1326  
1327         * Scripts/webkitpy/common/system/path.py:
1328         (cygpathFast):
1329         * Scripts/webkitpy/port/driver.py:
1330         (Driver._command_from_driver_input):
1331
1332 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1333
1334         Document instructions for increasing process and file limits
1335         https://bugs.webkit.org/show_bug.cgi?id=160528
1336         rdar://problem/24777576
1337
1338         Reviewed by Alexey Proskuryakov.
1339
1340         * Scripts/webkitpy/port/ios.py:
1341         (IOSSimulatorPort.default_child_processes):
1342
1343 2016-08-03  Anders Carlsson  <andersca@apple.com>
1344
1345         Remove the Objective-C bindings generator
1346         https://bugs.webkit.org/show_bug.cgi?id=160526
1347
1348         Reviewed by Sam Weinig.
1349
1350         * Scripts/run-bindings-tests:
1351         Update test.
1352
1353 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1354
1355         Revise a TestWebKitAPI comment to mention the actual underlying problem
1356
1357         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1358         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1359
1360 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1361
1362         Benchmark test content-animation timeouts always
1363         https://bugs.webkit.org/show_bug.cgi?id=160057
1364
1365         Reviewed by Simon Fraser.
1366
1367         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1368         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1369         (start):
1370
1371 2016-08-02  Nan Wang  <n_wang@apple.com>
1372
1373         AX: Simulated touch events are not working on iOS
1374         https://bugs.webkit.org/show_bug.cgi?id=160395
1375         <rdar://problem/27633597>
1376
1377         Reviewed by Chris Fleizach.
1378
1379         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1380         (WTR::AccessibilityUIElement::press):
1381         (WTR::AccessibilityUIElement::setSelectedChild):
1382
1383 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1384
1385         run-javascriptcore-tests should accept multiple --extra-tests
1386         https://bugs.webkit.org/show_bug.cgi?id=160486
1387
1388         Reviewed by Saam Barati.
1389         
1390         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1391         test suites. This does it by using GetOpt::Long's array support.
1392
1393         * Scripts/run-javascriptcore-tests:
1394         (runJSCStressTests):
1395
1396 2016-08-02  Enrica Casucci  <enrica@apple.com>
1397
1398         Allow building with content filtering disabled.
1399         https://bugs.webkit.org/show_bug.cgi?id=160454
1400
1401         Reviewed by Simon Fraser.
1402
1403         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1404
1405 2016-08-02  Brady Eidson  <beidson@apple.com>
1406
1407         Removing IndexedDB WebsiteData can fail for some users.
1408         https://bugs.webkit.org/show_bug.cgi?id=160463
1409
1410         Reviewed by Alex Christensen.
1411
1412         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1413
1414 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1415
1416         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1417         https://bugs.webkit.org/show_bug.cgi?id=160437
1418         <rdar://problem/27578272>
1419
1420         Reviewed by Brady Eidson.
1421
1422         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1423         (-[DownloadDelegate _download:didReceiveResponse:]):
1424         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1425         (runTest):
1426         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1427
1428 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1429
1430         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1431         https://bugs.webkit.org/show_bug.cgi?id=160414
1432
1433         Reviewed by Michael Catanzaro.
1434
1435         * Scripts/webkitpy/port/linux_get_crash_log.py:
1436         (GDBCrashLogGenerator._wait_for_corefile):
1437
1438 2016-08-01  Youenn Fablet  <youenn@apple.com>
1439
1440         Make wpt server generate its certificates in layout test results folder
1441         https://bugs.webkit.org/show_bug.cgi?id=160422
1442
1443         Reviewed by Chris Dumez.
1444
1445         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1446         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1447
1448 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1449
1450         Function Call on NULL Object
1451         https://bugs.webkit.org/show_bug.cgi?id=160325
1452
1453         Reviewed by Darin Adler.
1454
1455         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1456         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1457         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1458
1459 2016-08-01  Keith Miller  <keith_miller@apple.com>
1460
1461         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1462         https://bugs.webkit.org/show_bug.cgi?id=160372
1463
1464         Rubber stamped by Geoffrey Garen.
1465
1466         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1467         a new top level directory, JSTests. Having the tests in the Source directory
1468         was both confusing an inconvenient for people that just want to checkout the
1469         source code of WebKit. Since there is no other obvious place to put all the
1470         JavaScript tests a new top level directory seemed the most sensible.
1471
1472         * Scripts/import-test262-tests:
1473         * Scripts/run-javascriptcore-tests:
1474         * Scripts/update-javascriptcore-test-res:
1475
1476 2016-07-31  Nan Wang  <n_wang@apple.com>
1477
1478         AX: Add a check for touch event listener on iOS accessibility object
1479         https://bugs.webkit.org/show_bug.cgi?id=160388
1480
1481         Reviewed by Chris Fleizach.
1482
1483         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1484         (AccessibilityUIElement::boolAttributeValue):
1485         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1486         (WTR::AccessibilityUIElement::boolAttributeValue):
1487
1488 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1489
1490         Unreviewed: add myself to the reviewers list.
1491
1492         * Scripts/webkitpy/common/config/contributors.json:
1493
1494 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1495
1496         Undo r203939, and copy over a rule that clips the logos.
1497
1498         Sierra wasn't the only logo without transparency.
1499
1500         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1503
1504 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1505
1506         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1507         https://bugs.webkit.org/show_bug.cgi?id=160377
1508
1509         Reviewed by Brian Weinstein.
1510
1511         Update assets to remove the white background and use a transparent background instead.
1512
1513         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1515
1516 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1517
1518         Ignore most check-webkit-style checks for ANGLE project
1519         <https://webkit.org/b/160333>
1520
1521         Reviewed by Daniel Bates.
1522
1523         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1524         - No tabs.
1525         - No spaces at the end of lines.
1526         - No carriage returns (DOS line endings).
1527
1528 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1529
1530         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1531         https://bugs.webkit.org/show_bug.cgi?id=160360
1532         <rdar://problem/27179484>
1533
1534         Reviewed by Myles C. Maxfield.
1535
1536         Adds two tests verifying that videos may be considered main content as long as they
1537         are large enough and cover a majority of the mainframe's viewport.
1538
1539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1540         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1541         (TestWebKitAPI::TEST):
1542         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1543         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1544
1545 2016-07-29  Mark Lam  <mark.lam@apple.com>
1546
1547         Gardening: removed unused variable.
1548
1549         Not reviewed.
1550
1551         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1552         (TestWebKitAPI::TEST):
1553
1554 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1555
1556         Add TestWebKitAPI support for interacting with media controls
1557         https://bugs.webkit.org/show_bug.cgi?id=160342
1558         <rdar://problem/27610246>
1559
1560         Reviewed by Beth Dakin.
1561
1562         Adds support for testing interaction with some media controls, as well as a basic test
1563         verifying that media control teardown after interaction does not result in a crash.
1564
1565         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1566         (-[WKWebView mouseDownAtPoint:]):
1567         (-[WKWebView performAfterLoading:]):
1568         (TestWebKitAPI::TEST):
1569
1570 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1571
1572         Crash Log Clobbering on Unbound Crashes
1573         https://bugs.webkit.org/show_bug.cgi?id=160198
1574         <rdar://problem/27472618>
1575
1576         Reviewed by Alexey Proskuryakov.
1577
1578         * Scripts/webkitpy/common/system/crashlogs.py:
1579         (CrashLogs): Fix header order.
1580         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1581         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1582
1583 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1584
1585         Update for contributors.json
1586         https://bugs.webkit.org/show_bug.cgi?id=160294
1587
1588         * Scripts/webkitpy/common/config/contributors.json:
1589
1590 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1591
1592         Remove deprecated SPI for video inline / fullscreen controls
1593         https://bugs.webkit.org/show_bug.cgi?id=160318
1594
1595         Reviewed by Tim Horton.
1596
1597         * DumpRenderTree/mac/DumpRenderTree.mm:
1598         (setDefaultsToConsistentValuesForTesting): Deleted.
1599         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1600         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1601         * WebKitTestRunner/TestController.cpp:
1602         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1603         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1604         (WTR::initializeWebViewConfiguration): Deleted.
1605
1606 2016-07-28  Daniel Bates  <dabates@apple.com>
1607
1608         [iOS] TestWebKitAPI bundle targets are not code signed
1609         https://bugs.webkit.org/show_bug.cgi?id=160328
1610         <rdar://problem/27409246>
1611
1612         Reviewed by Andy Estes.
1613
1614         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1615         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1616         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1617
1618         * TestWebKitAPI/Configurations/Base.xcconfig:
1619
1620 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1621
1622         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1623
1624         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1625         (animatedResizeWebView):
1626         (TEST):
1627         This test times out only when run in the WebKit Testing simulator environment,
1628         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1629
1630 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1631
1632         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1633         https://bugs.webkit.org/show_bug.cgi?id=160289
1634         <rdar://problem/27553464>
1635
1636         Reviewed by Simon Fraser.
1637
1638         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1639         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1640         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1641         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1642         (-[AnimatedResizeWebView _endAnimatedResize]):
1643         (animatedResizeWebView):
1644         (TEST):
1645         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1646         Add two tests that ensure that hidden-content and animated resizes
1647         don't cause unnecessary synchronous waits. Only the hidden-content
1648         one fails before my patch, but it seemed reasonable to add both anyway.
1649
1650 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1651
1652         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1653         <https://webkit.org/b/83342>
1654
1655         Reviewed by Ryosuke Niwa.
1656
1657         * Scripts/webkitpy/common/checkout/scm/git.py:
1658         (Git.revisions_changing_file): Remove code to raise an exception
1659         when the file doesn't exist.  If a file was moved or renamed,
1660         then this caused the script to terminate, which was very
1661         frustrating when you wanted a list of reviewers.
1662         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1663         (SCMTest._shared_test_revisions_changing_file): Update test
1664         expectation to return an empty list of revisions.
1665         (test_create_patch_is_full_patch): Drive-by fix when running all
1666         webkitpy tests (including scm tests).
1667         * Scripts/webkitpy/common/checkout/scm/svn.py:
1668         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1669         return an empty array of revisions if this occurs.
1670
1671 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1672
1673         EWS error message "Error: * did not process patch" should include explanation
1674         https://bugs.webkit.org/show_bug.cgi?id=159903
1675         <rdar://problem/27410788>
1676
1677         Reviewed by Alexey Proskuryakov.
1678
1679         * QueueStatusServer/handlers/statusbubble.py:
1680         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1681         is not processed.
1682         * QueueStatusServer/handlers/processingtimesjson.py:
1683         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1684         of the code.
1685         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1686         (CommitQueueTask.validate): Add more information about validation failure.
1687         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1688         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1689         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1690         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1691         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1692         (PatchIsNotValid.__init__): Add the failure_message argument.
1693         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1694         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1695         failure details.
1696         * Scripts/webkitpy/tool/commands/queues.py:
1697         (CommitQueue.process_work_item): Same.
1698         (StyleQueue.review_patch): Same.
1699         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1700         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1701
1702 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1703
1704         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1705         https://bugs.webkit.org/show_bug.cgi?id=160262
1706
1707         Reviewed by Daniel Bates.
1708
1709         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1710         (-[LTRelayController installApp]):
1711
1712 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1713
1714         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1715         https://bugs.webkit.org/show_bug.cgi?id=160225
1716
1717         Reviewed by Alexey Proskuryakov.
1718
1719         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1720
1721 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1722
1723         [GTK] Fix some video/canvas tests that should be passing
1724         https://bugs.webkit.org/show_bug.cgi?id=160023
1725
1726         Reviewed by Carlos Garcia Campos.
1727
1728         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1729         EFL or GTK platforms.
1730
1731         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1732         (WTR::TestController::platformConfigureViewForTest):
1733         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1734         (WTR::TestController::platformConfigureViewForTest):
1735
1736 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1737
1738         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1739         https://bugs.webkit.org/show_bug.cgi?id=160247
1740
1741         Reviewed by Michael Catanzaro.
1742
1743         * BuildSlaveSupport/built-product-archive:
1744         (createZip):
1745         (dirContainsdwo):
1746         (archiveBuiltProduct):
1747
1748 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1749
1750         Fix tests after r203743.
1751         https://bugs.webkit.org/show_bug.cgi?id=156947
1752
1753         * WebKitTestRunner/TestController.cpp:
1754         (WTR::TestController::resetStateToConsistentValues):
1755         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1756
1757 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1758
1759         [iPhone] Playing a video on tudou.com plays only sound, no video
1760         https://bugs.webkit.org/show_bug.cgi?id=160178
1761         <rdar://problem/27535468>
1762
1763         Reviewed by Dan Bernstein.
1764
1765         * DumpRenderTree/mac/DumpRenderTree.mm:
1766         (setDefaultsToConsistentValuesForTesting):
1767         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1768         (RequiresUserActionForPlaybackTest::SetUp):
1769         * WebKitTestRunner/TestController.cpp:
1770         (WTR::TestController::resetPreferencesToConsistentValues):
1771         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1772         (WTR::initializeWebViewConfiguration):
1773
1774 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1775
1776         Allow LOG macros to be used outside the namespace, and other logging cleanup
1777         https://bugs.webkit.org/show_bug.cgi?id=160216
1778
1779         Reviewed by Anders Carlsson.
1780         
1781         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1782
1783         * DumpRenderTree/TestRunner.cpp:
1784         * DumpRenderTree/mac/DumpRenderTree.mm:
1785         (resetWebViewToConsistentStateBeforeTesting):
1786
1787 2016-07-26  David Kilzer <ddkilzer@apple.com>
1788
1789         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1790         https://bugs.webkit.org/show_bug.cgi?id=156947
1791         <rdar://problem/23325160>
1792
1793         Reviewed by Alex Christensen.
1794
1795         * DumpRenderTree/TestRunner.cpp:
1796         (TestRunner::TestRunner):
1797         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1798         * DumpRenderTree/TestRunner.h:
1799         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1800         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1801         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1802         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1803         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1804         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1805         (WTR::TestRunner::queueNonLoadingScript):
1806         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1807         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1808         * WebKitTestRunner/TestController.cpp:
1809         (WTR::TestController::didReceiveAuthenticationChallenge):
1810         * WebKitTestRunner/TestController.h:
1811         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1812         * WebKitTestRunner/TestInvocation.cpp:
1813         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1814         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1815
1816 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1817
1818         check-for-exit-time-destructors should be usable outside Xcode
1819         <https://webkit.org/b/160195>
1820
1821         Reviewed by Darin Adler.
1822
1823         * Scripts/check-for-exit-time-destructors: Update to parse
1824         -h|--help switch, or to take one argument to a binary to check
1825         for exit time destructors on the command-line.  The clang
1826         compiler will find these at compile-time with the
1827         -Wexit-time-destructors switch, but this script will check for
1828         them after-the-fact.
1829
1830 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1831
1832         Test svn.webkit.org functionality after maintenance.
1833
1834 2016-07-25  Brady Eidson  <beidson@apple.com>
1835
1836         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1837         https://bugs.webkit.org/show_bug.cgi?id=153783
1838
1839         Reviewed by Alex Christensen.
1840
1841         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
1842         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1843         
1844         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1845         
1846         Change the relevant API tests to make sure this continues to be no longer required.
1847
1848         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1849         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1850         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1851         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1852         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1853         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1854
1855 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1856
1857         Media controls should not be displayed for a video until it starts playing
1858         https://bugs.webkit.org/show_bug.cgi?id=160092
1859         <rdar://problem/26986673>
1860
1861         Reviewed by Beth Dakin.
1862
1863         Verify that multiple videos do or don't show the media controller depending on whether videos
1864         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1865         passing because we were always showing media controls for large videos with audio, even if they
1866         had not played back yet. This change ensures that large videos with audio show media controls
1867         only after they begin to play back, and not by virtue of being large enough for main content.
1868
1869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1870         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1871         (TestWebKitAPI::TEST):
1872         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1873         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1874         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1875
1876 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1877
1878         Media controls on apple.com don't disappear when movie finishes playing
1879         https://bugs.webkit.org/show_bug.cgi?id=160068
1880         <rdar://problem/26668526>
1881
1882         Reviewed by Darin Adler.
1883
1884         Adds new API tests. Please see WebCore ChangeLog for more details.
1885
1886         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1887         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1888         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1889         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1890         (TestWebKitAPI::TEST):
1891         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1892         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1893         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1894         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1895         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1896
1897 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1898
1899         Unreviewed, fix test-webkitpy after r203674.
1900
1901         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1902         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1903
1904 2016-07-24  Philippe Normand  <pnormand@igalia.com>
1905
1906         Unreviewed, forgot to commit this file in r203674.
1907
1908         * Scripts/process-linux-coredump: Added.
1909         (main):
1910
1911 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1912
1913         Improve GDB backtrace generation for GTK/EFL
1914         https://bugs.webkit.org/show_bug.cgi?id=128928
1915
1916         Reviewed by Carlos Garcia Campos.
1917
1918         The PID of the crashed process is now correctly supplied to the
1919         crash log reporter. The kernel core_pattern needs to be updated
1920         after this change to something like:
1921
1922         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1923
1924         * Scripts/process-linux-coredump: Added.
1925         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1926         * Scripts/webkitpy/port/efl.py:
1927         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1928         * Scripts/webkitpy/port/gtk.py:
1929         (GtkPort._get_crash_log): Ditto.
1930         * Scripts/webkitpy/port/linux_get_crash_log.py:
1931         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1932         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1933         (GDBCrashLogGenerator): Deleted.
1934         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1935         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
1936         * WebKitTestRunner/TestController.cpp:
1937         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
1938         (WTR::TestController::databaseProcessDidCrash): Ditto.
1939         (WTR::TestController::processDidCrash): Ditto.
1940
1941 2016-07-23  Youenn Fablet  <youenn@apple.com>
1942
1943         WPT stash server should be kept running when launching wpt server
1944         https://bugs.webkit.org/show_bug.cgi?id=160052
1945
1946         Reviewed by Sam Weinig.
1947
1948         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1949         (main): waiting to read stdin while stash server is started.
1950
1951 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1952
1953         Media controls should be displayed for media in media documents
1954         https://bugs.webkit.org/show_bug.cgi?id=160104
1955         <rdar://problem/27438936>
1956
1957         Reviewed by Myles C. Maxfield.
1958
1959         Verifies that even a small video with audio in a media document gets media controls.
1960
1961         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1962         (TestWebKitAPI::TEST):
1963
1964 2016-07-22  Michael Saboff  <msaboff@apple.com>
1965
1966         REGRESSION(203616): no FTL testing was inadvertently removed
1967         https://bugs.webkit.org/show_bug.cgi?id=160100
1968
1969         Rubber-stamped by Filip Pizlo.
1970
1971         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
1972         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
1973         logic for the runLayout and runNoisy variants to match the run test logic,
1974         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
1975         enabled platforms.
1976
1977         * Scripts/run-jsc-stress-tests:
1978
1979 2016-07-22  Brady Eidson  <beidson@apple.com>
1980
1981         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
1982         https://bugs.webkit.org/show_bug.cgi?id=160089
1983
1984         Reviewed by Darin Adler.
1985
1986         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1987         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
1988         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
1989
1990 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
1991
1992         [GTK] Improved exclusion patterns in make-dist.py manifest.
1993         https://bugs.webkit.org/show_bug.cgi?id=160094
1994
1995         Reviewed by Michael Catanzaro.
1996
1997         * gtk/manifest.txt.in:
1998         Exclude Platform*.cmake files for more ports.
1999         Removed obsolete .gyp and .pro.user patterns.
2000         Exclude 'Configurations' and 'spi' directories.
2001         Exclude CMakeLists.txt.user (Qt Creator IDE).
2002
2003 2016-07-22  Michael Saboff  <msaboff@apple.com>
2004
2005         Don't run FTL related JSC stress tests on non-FTL platforms
2006         https://bugs.webkit.org/show_bug.cgi?id=160033
2007
2008         Reviewed by Mark Lam.
2009
2010         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
2011         Refactored several of the runXXX test methods to always runXXXDefault and made those
2012         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
2013         doesn't cause a problem.
2014
2015         * Scripts/run-jsc-stress-tests:
2016
2017 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
2018
2019         IWebView::mainFrame crashes if called after IWebView::close
2020         https://bugs.webkit.org/show_bug.cgi?id=32868
2021
2022         Reviewed by Brent Fulgham.
2023
2024         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2025         (TestWebKitAPI::TEST_F): Added test.
2026
2027 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2028
2029         [GTK] Enable threaded compositor by default
2030         https://bugs.webkit.org/show_bug.cgi?id=160079
2031
2032         Reviewed by Žan Doberšek.
2033
2034         * Scripts/webkitperl/FeatureList.pm:
2035
2036 2016-07-22  Youenn Fablet  <youenn@apple.com>
2037
2038         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
2039         https://bugs.webkit.org/show_bug.cgi?id=159921
2040
2041         Reviewed by Brian Burg.
2042
2043         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
2044
2045         * Scripts/webkitpy/codegen/main.py:
2046         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
2047         (BuiltinsGeneratorTests):
2048         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
2049         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
2050         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
2051         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
2052
2053 2016-07-21  Dan Bernstein  <mitz@apple.com>
2054
2055         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
2056         https://bugs.webkit.org/show_bug.cgi?id=160072
2057
2058         Reviewed by Andy Estes.
2059
2060         * Scripts/webkitdirs.pm:
2061         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
2062           for old Xcode versions.
2063         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
2064           to readXcodeUserDefault.
2065         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
2066           debugger.
2067         (determineDebugger): Ditto.
2068         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
2069           7.0.
2070         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
2071           switches.
2072         (execMacWebKitAppForDebugging): Removed support for GDB.
2073
2074 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2075
2076         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2077         https://bugs.webkit.org/show_bug.cgi?id=160066
2078
2079         Reviewed by Dean Jackson.
2080
2081         * DumpRenderTree/mac/DumpRenderTree.mm:
2082         (setDefaultsToConsistentValuesForTesting): Deleted.
2083         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2084         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2085         * WebKitTestRunner/TestController.cpp:
2086         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2087         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2088         (WTR::initializeWebViewConfiguration): Deleted.
2089
2090 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
2091
2092         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2093         https://bugs.webkit.org/show_bug.cgi?id=159980
2094         rdar://problem/27450825
2095
2096         Reviewed by Dan Bernstein.
2097
2098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2099         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2100         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2101         when our delegate has hit -dealloc.
2102         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
2103         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
2104         will not be messaged.
2105
2106 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2107
2108         Follow-up patch to r203520
2109         https://bugs.webkit.org/show_bug.cgi?id=159967
2110         <rdar://problem/26964090>
2111
2112         Unreviewed.
2113
2114         * DumpRenderTree/mac/DumpRenderTree.mm:
2115         (setDefaultsToConsistentValuesForTesting):
2116         * WebKitTestRunner/TestController.cpp:
2117         (WTR::TestController::resetPreferencesToConsistentValues):
2118
2119 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2120
2121         [iPhone] Playing a video on tudou.com plays only sound, no video
2122         https://bugs.webkit.org/show_bug.cgi?id=159967
2123         <rdar://problem/26964090>
2124
2125         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2126
2127         Migrate tests to use new SPI.
2128
2129         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2130         (RequiresUserActionForPlaybackTest::SetUp):
2131         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2132         (WTR::initializeWebViewConfiguration):
2133
2134 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
2135
2136         Clarify testing mode names in run-jsc-stress-tests
2137         https://bugs.webkit.org/show_bug.cgi?id=160021
2138
2139         Reviewed by Mark Lam.
2140
2141         Default should mean really default, not default with disabled FTL, renamed
2142         - runMozillaTestDefault to runMozillaTestNoFTL
2143         - runMozillaTestDefaultFTL to runMozillaTestDefault
2144         - runDefault to runNoFTL
2145         - runDefaultFTL to runDefault
2146         - runLayoutTestDefault to runLayoutTestNoFTL
2147         - runLayoutTestDefaultFTL to runLayoutTestDefault
2148         - runNoisyTestDefault to runNoisyTestNoFTL
2149         - runNoisyTestDefaultFTL to runNoisyTestDefault
2150
2151         * Scripts/run-jsc-stress-tests:
2152
2153 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
2154
2155         WebBackForwardList's currentIndex could get out of bounds when filtering items.
2156         https://bugs.webkit.org/show_bug.cgi?id=159986
2157
2158         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
2159         to 0.
2160
2161         Reviewed by Dan Bernstein.
2162
2163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2164         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
2165         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
2166         (TEST):
2167
2168 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2169
2170         [GTK] Web view background colors don't work in accelerated compositing mode
2171         https://bugs.webkit.org/show_bug.cgi?id=159455
2172
2173         Reviewed by Michael Catanzaro.
2174
2175         Set always RGBA visual to the view widget when setting a background color.
2176
2177         * MiniBrowser/gtk/BrowserWindow.c:
2178         (browser_window_set_background_color):
2179
2180 2016-07-20  Youenn Fablet  <youenn@apple.com>
2181
2182         Bots should run built-ins generator tests
2183         https://bugs.webkit.org/show_bug.cgi?id=159971
2184
2185         Reviewed by Alexey Proskuryakov.
2186
2187         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2188         (RunBuiltinsTests): New step to run built-in generator tests.
2189         (TestFactory.__init__): Adding an additional step for bultin generator tests.
2190         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
2191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
2192
2193 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2194
2195         Revert temporary fix r203417
2196         https://bugs.webkit.org/show_bug.cgi?id=160001
2197
2198         Reviewed by Alexey Proskuryakov.
2199
2200         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
2201
2202 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2203
2204         REGRESSION(r148588): ews classes might get garbage collected
2205         https://bugs.webkit.org/show_bug.cgi?id=159990
2206
2207         Reviewed by Ryosuke Niwa.
2208
2209         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
2210         in a variable so that they do not get garbage collected.
2211
2212 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
2213
2214         Add API test for layout constraints after exit fullscreen
2215         https://bugs.webkit.org/show_bug.cgi?id=159900
2216
2217         Reviewed by Jon Lee.
2218
2219         Added Fullscreen.LaytoutConstraints API test. 
2220         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
2221
2222         This test compares layout constraints on the web view before and after fullscreen to make sure 
2223         they are preserved.
2224
2225         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
2226         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
2227         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2228         (TestWebKitAPI::TEST):
2229
2230 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
2231
2232         Disable two failing API tests.
2233
2234         Unreviewed test gardening.
2235
2236         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2237         (TestWebKitAPI::TEST):
2238
2239 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2240
2241         Unreviewed iOS build fix.
2242
2243         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
2244
2245 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2246
2247         Media controls don't appear when pausing a small autoplaying video
2248         https://bugs.webkit.org/show_bug.cgi?id=159972
2249         <rdar://problem/27180657>
2250
2251         Reviewed by Beth Dakin.
2252
2253         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
2254         for simulating basic user interaction in VideoControlsManager.
2255
2256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2257         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2258         (-[WKWebView mouseDownAtPoint:]):
2259         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2260         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2261         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2262         (TestWebKitAPI::TEST):
2263         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2264
2265 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2266
2267         [Win] MathML fonts are not found.
2268         https://bugs.webkit.org/show_bug.cgi?id=159920
2269
2270         Reviewed by Alex Christensen.
2271
2272         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2273         for a specific registry key value.
2274
2275         * Scripts/webkitdirs.pm:
2276         (fontExists):
2277
2278 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2279
2280         Improve prepare-ChangeLog for @media blocks
2281         https://bugs.webkit.org/show_bug.cgi?id=159907
2282
2283         Reviewed by Timothy Hatcher.
2284
2285         * Scripts/prepare-ChangeLog:
2286         (get_selector_line_ranges_for_css):
2287         Get a range for @media blocks just like a selector.
2288             Start Line = line with '{'
2289             End line = line with '}'
2290             Name = "@media ..."
2291
2292         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2293         Improved error messages for unbalanced portions.
2294
2295         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2296         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2297         (.media-query::before):
2298         (@media only screen and (max-width: 980px)):
2299         (.media-query a):
2300         (@media (-webkit-min-device-pixel-ratio: 2)):
2301         (.both a):
2302         (.both b):
2303         (.media-query b):
2304         (.media-query::after):
2305
2306 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2307
2308         Fix expectedFailErrorHandler in run-jsc-stress-tests
2309         https://bugs.webkit.org/show_bug.cgi?id=159811
2310
2311         Reviewed by Yusuke Suzuki.
2312
2313         * Scripts/run-jsc-stress-tests:
2314
2315 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2316
2317         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2318
2319         * TestWebKitAPI/PlatformMac.cmake:
2320
2321 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2322
2323         The default testing mode should not involve disabling the FTL JIT
2324         https://bugs.webkit.org/show_bug.cgi?id=159929
2325
2326         Rubber stamped by Mark Lam and Saam Barati.
2327         
2328         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2329         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2330         FTL was not the default. You had to enable it with an option.
2331         
2332         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2333         all of the major ports. This has become a serious pain. For example, it's useful to be able
2334         to say that a test should only run in the default config that is representative of what a
2335         normal user would see if they ran JSC. Clearly, this would be a config that does not
2336         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2337         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2338         
2339         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2340         try to fix it, because:
2341         
2342         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2343           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2344           doesn't do anything. The code is not really structured to allow this.
2345         
2346         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2347           disabled in testing. On the other hand there are already build bots that do FTL tests
2348           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2349           preserving this broken feature, we should create something that (a) acknowledges the fact
2350           that the FTL is the default on those platforms that support it and (b) avoids running
2351           no-ftl tests on precisely those platforms that don't have FTL.
2352         
2353         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2354           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2355           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2356           pretending that the FTL JIT is not the default just because some bots used that as an
2357           optimization.
2358         
2359         This change allows me to speed up some debug tests and paint some bots green.
2360
2361         * Scripts/run-javascriptcore-tests:
2362         (runJSCStressTests):
2363         * Scripts/run-jsc-stress-tests:
2364
2365 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2366
2367         Fix API test after r203426.
2368         https://bugs.webkit.org/show_bug.cgi?id=159949
2369
2370         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2371         (TEST):
2372         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2373         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2374
2375 2016-07-19  Andy Estes  <aestes@apple.com>
2376
2377         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2378         https://bugs.webkit.org/show_bug.cgi?id=159956
2379
2380         Reviewed by Dan Bernstein.
2381
2382         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2383         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2384         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2385         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2386
2387 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2388
2389         Add regression test for r203392
2390         https://bugs.webkit.org/show_bug.cgi?id=159949
2391
2392         Reviewed by Brady Eidson.
2393
2394         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2395         (fileSize):
2396         (swizzledBundleIdentifierWebBookmarksD):
2397         (defaultApplicationCacheDirectory):
2398         (TEST):
2399         (swizzledBundleIdentifierMobileSafari): Deleted.
2400         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2401         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2402         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2403
2404 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2405
2406         Add regression test for r203392
2407         https://bugs.webkit.org/show_bug.cgi?id=159949
2408
2409         Reviewed by Brady Eidson.
2410
2411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2412         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2413         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2414         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2415         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2416         (TEST):
2417         (fileSize):
2418         (swizzledBundleIdentifierMobileSafari):
2419         (swizzledBundleIdentifierWebBookmarksD):
2420         (defaultApplicationCacheDirectory):
2421         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2422         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2423         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2424         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2425
2426 2016-07-19  Keith Miller  <keith_miller@apple.com>
2427
2428         Test262 should have a file with the revision and url
2429         https://bugs.webkit.org/show_bug.cgi?id=159937
2430
2431         Reviewed by Mark Lam.
2432
2433         The import script should update the information from
2434         the path to the test262 repository it gets.
2435
2436         * Scripts/import-test262-tests:
2437
2438 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2439
2440         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2441         To be deleted once the root cause is found and addressed.
2442
2443         * EWSTools/start-queue-mac.sh:
2444
2445 2016-07-19  Frederic Wang  <fwang@igalia.com>
2446
2447         [win] Fixup the register name for STIX Math and Latin Modern Math
2448
2449         Unreviewed follow-up of r203406
2450
2451         * Scripts/webkitdirs.pm:
2452         (checkInstalledTools):
2453
2454 2016-07-19  Frederic Wang  <fwang@igalia.com>
2455
2456         [win] Update the list of MathML fonts
2457         https://bugs.webkit.org/show_bug.cgi?id=156838
2458
2459         The set of recommended math fonts is now described at
2460         https://trac.webkit.org/wiki/MathML/Fonts
2461         We update the Perl script to use the latest list of fonts.
2462
2463         Reviewed by Brent Fulgham.
2464
2465         * Scripts/webkitdirs.pm:
2466         (checkInstalledTools):
2467
2468 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2469
2470         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2471         https://bugs.webkit.org/show_bug.cgi?id=159342
2472
2473         Reviewed by Darin Adler.
2474
2475         Implement required functions in event sender.
2476
2477         * DumpRenderTree/PlatformWin.cmake:
2478         * DumpRenderTree/win/EventSender.cpp:
2479         (monitorWheelEvents): Added.
2480         (callAfterScrollingCompletes): Added.
2481
2482 2016-07-19  Youenn Fablet  <youenn@apple.com>
2483
2484         Add new aliases to http test server
2485         https://bugs.webkit.org/show_bug.cgi?id=159878
2486
2487         Reviewed by Darin Adler.
2488
2489         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2490         Adding explicitly these links to perl script.
2491         Extracting default alias in an aliases.json file.
2492         Reading that file from python scripts to initialize aliases from that file.
2493
2494         Python script changes covered by unit tests and changed layout test.
2495
2496         * Scripts/webkitperl/httpd.pm:
2497         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2498         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2499         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2500         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2501         Adding -c directives for each alias.
2502         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2503         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2504         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2505         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2506         Adding alias directive for each alias.
2507         (Lighttpd._prepare_config):
2508         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2509         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2510         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2511         layout tests directory.
2512         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2513         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2514         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2515
2516 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2517
2518         EWS console logs doesn't go to log file
2519         https://bugs.webkit.org/show_bug.cgi?id=159539
2520         <rdar://problem/24464570>
2521
2522         Reviewed by David Kilzer.
2523
2524         * Scripts/webkitpy/common/system/logutils.py:
2525         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2526         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2527         to filesystem. It also supports passing MockFilesystem.
2528         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2529         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2530         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2531         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2532         (_test_ews): Same.
2533         * Scripts/webkitpy/tool/commands/queues.py:
2534         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2535         (AbstractQueue._log_directory): Using filesystem object instead of os.
2536         (AbstractQueue.queue_log_path): Same.
2537         (AbstractQueue.__init__): Passed host parameter.
2538         (PatchProcessingQueue.__init__): Same.
2539         (CommitQueue.__init__): Same.
2540         (AbstractReviewQueue.__init__): Same.
2541         (StyleQueue.__init__): Same.
2542         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2543         (TestCommitQueue): Passed MockHost() as host.
2544         (TestCommitQueue.__init__): Same.
2545         (TestQueue.__init__): Same.
2546         (TestReviewQueue.__init__): Same.
2547         (TestFeederQueue.__init__): Same.
2548         (AbstractPatchQueueTest.test_next_patch): Same.
2549         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2550         (test_commit_queue_failure): Same.
2551         (MockCommitQueueTask.results_from_patch_test_run): Same.
2552         (test_rollout_lands): Same.
2553         (test_non_valid_patch): Same.
2554         (test_auto_retry): Same.
2555         (test_style_queue_with_watch_list_exception): Same.
2556
2557 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2558
2559         WTF::Lock should be fair eventually
2560         https://bugs.webkit.org/show_bug.cgi?id=159384
2561
2562         Reviewed by Geoffrey Garen.
2563
2564         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2565
2566 2016-07-17  Sam Weinig  <sam@webkit.org>
2567
2568         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2569         <rdar://problem/26554137>
2570         https://bugs.webkit.org/show_bug.cgi?id=159856
2571
2572         Reviewed by Dan Bernstein.
2573
2574         * MiniBrowser/mac/WK2BrowserWindowController.m:
2575         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2576         Add basic window.open implementation.
2577
2578         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2579         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2580         to open a single non-web URL, all others are dropped.
2581
2582         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2583         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2584         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2585         Add API for the new SPI.
2586
2587 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2588
2589         [JSC] Enable test262 module tests
2590         https://bugs.webkit.org/show_bug.cgi?id=159854
2591
2592         Reviewed by Saam Barati.
2593
2594         Use --module-file instead.
2595
2596         * Scripts/run-jsc-stress-tests:
2597
2598 2016-07-16  Chris Dumez  <cdumez@apple.com>
2599
2600         Unreviewed, rolling out r203318.
2601
2602         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2603         SunSpider)
2604
2605         Reverted changeset:
2606
2607         "[JSC] Change some parameters based on a random search"
2608         https://bugs.webkit.org/show_bug.cgi?id=158514
2609         http://trac.webkit.org/changeset/203318
2610
2611 2016-07-16  Chris Dumez  <cdumez@apple.com>
2612
2613         Add move constructor / assignment operator to ListHashSet
2614         https://bugs.webkit.org/show_bug.cgi?id=159837
2615
2616         Reviewed by Darin Adler.
2617
2618         Add API tests.
2619
2620         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2621         (TestWebKitAPI::TEST):
2622
2623 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2624
2625         [JSC] Change some parameters based on a random search
2626         https://bugs.webkit.org/show_bug.cgi?id=158514
2627
2628         Reviewed by Saam Barati.
2629
2630         * Scripts/run-jsc-stress-tests:
2631
2632 2016-07-15  Jon Davis  <jond@apple.com>
2633
2634         Changed the start page URL for WebKit Nightly builds.
2635         https://bugs.webkit.org/show_bug.cgi?id=159816
2636
2637         Reviewed by Timothy Hatcher.
2638
2639         * WebKitLauncher/start.html:
2640
2641 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2642
2643         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2644         https://bugs.webkit.org/show_bug.cgi?id=159414
2645
2646         Reviewed by Brent Fulgham.
2647
2648         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2649         when the HDC parameter is invalid.
2650
2651         * TestWebKitAPI/PlatformWin.cmake:
2652         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2653         (TestWebKitAPI::TEST):
2654
2655 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2656
2657         [GTK] Add basic tabs support to MiniBrowser
2658         https://bugs.webkit.org/show_bug.cgi?id=159803
2659
2660         Reviewed by Sergio Villar Senin.
2661
2662         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2663         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2664
2665         * MiniBrowser/gtk/BrowserTab.c: Added.
2666         (titleChanged):
2667         (isLoadingChanged):
2668         (decidePolicy):
2669         (removeChildIfInfoBar):
2670         (loadChanged):
2671         (createInfoBarQuestionMessage):
2672         (tlsErrorsDialogResponse):
2673         (loadFailedWithTLSerrors):
2674         (permissionRequestDialogResponse):
2675         (decidePermissionRequest):
2676         (colorChooserRGBAChanged):
2677         (popoverColorClosed):
2678         (colorChooserRequestFinished):
2679         (runColorChooserCallback):
2680         (inspectorOpenedInWindow):
2681         (inspectorClosed):
2682         (browserTabSetProperty):
2683         (browserTabFinalize):
2684         (browser_tab_init):
2685         (browserTabConstructed):
2686         (browser_tab_class_init):
2687         (getInternalURI):
2688         (browser_tab_new):
2689         (browser_tab_get_web_view):
2690         (browser_tab_load_uri):
2691         (browser_tab_get_title_widget):
2692         (browser_tab_set_status_text):
2693         (browser_tab_toggle_inspector):
2694         (browser_tab_start_search):
2695         (browser_tab_stop_search):
2696         (browser_tab_add_accelerators):
2697         (fullScreenMessageTimeoutCallback):
2698         (browser_tab_enter_fullscreen):
2699         (browser_tab_leave_fullscreen):
2700         * MiniBrowser/gtk/BrowserTab.h: Added.
2701         * MiniBrowser/gtk/BrowserWindow.c:
2702         (getExternalURI):
2703         (browserWindowSetStatusText):
2704         (reloadOrStopCallback):
2705         (goBackCallback):
2706         (goForwardCallback):
2707         (settingsCallback):
2708         (webViewURIChanged):
2709         (browserWindowHistoryItemActivated):
2710         (browserWindowUpdateNavigationActions):
2711         (webViewCreate):
2712         (webViewEnterFullScreen):
2713         (webViewLeaveFullScreen):
2714         (webViewDecidePolicy):
2715         (browserWindowCanZoomIn):
2716         (browserWindowCanZoomOut):
2717         (browserWindowZoomIn):
2718         (browserWindowZoomOut):
2719         (scrollEventCallback):
2720         (faviconChanged):
2721         (webViewIsLoadingChanged):
2722         (defaultZoomCallback):
2723         (searchCallback):
2724         (newTabCallback):
2725         (toggleWebInspector):
2726         (reloadPage):
2727         (reloadPageIgnoringCache):
2728         (stopPageLoad):
2729         (loadHomePage):
2730         (editingCommandCallback):
2731         (insertImageCommandCallback):
2732         (insertLinkCommandCallback):
2733         (browserWindowSetupEditorToolbar):
2734         (browserWindowSwitchTab):
2735         (browserWindowTabAddedOrRemoved):
2736         (browser_window_init):
2737         (browserWindowConstructed):
2738         (browserWindowSaveSession):
2739         (browserWindowDeleteEvent):
2740         (browser_window_new):
2741         (browser_window_append_view):
2742         (browser_window_load_uri):
2743         (browser_window_load_session):
2744         (browser_window_set_background_color):
2745         (resetStatusText): Deleted.
2746         (activateUriEntryCallback): Deleted.
2747         (webViewTitleChanged): Deleted.
2748         (resetEntryProgress): Deleted.
2749         (browserWindowCreateBackForwardMenu): Deleted.
2750         (webViewReadyToShow): Deleted.
2751         (webViewLoadFailed): Deleted.
2752         (webViewMouseTargetChanged): Deleted.
2753         (browserWindowUpdateZoomActions): Deleted.
2754         (webViewZoomLevelChanged): Deleted.
2755         (updateUriEntryIcon): Deleted.
2756         (zoomInCallback): Deleted.
2757         (zoomOutCallback): Deleted.
2758         (toggleFullScreen): Deleted.
2759         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2760         (browserWindowFinalize): Deleted.
2761         (browser_window_class_init): Deleted.
2762         * MiniBrowser/gtk/BrowserWindow.h:
2763         * MiniBrowser/gtk/CMakeLists.txt:
2764         * MiniBrowser/gtk/main.c:
2765         (createBrowserTab):
2766         (aboutURISchemeRequestCallback):
2767         (main):
2768         (parseBackgroundColor): Deleted.
2769
2770 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2771
2772         Allow RefPtrs of const RefCounted types
2773         https://bugs.webkit.org/show_bug.cgi?id=158269
2774
2775         Reviewed by Anders Carlsson.
2776
2777         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2778         (TestWebKitAPI::TEST):
2779         (TestWebKitAPI::ConstRefCounted::create):
2780         (TestWebKitAPI::returnConstRefCountedRef):
2781         (TestWebKitAPI::returnRefCountedRef):
2782
2783 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2784
2785         Test WTF.StringViewIterators is crashing since r203119
2786         https://bugs.webkit.org/show_bug.cgi?id=159710
2787
2788         Reviewed by Darin Adler.
2789
2790         There are two problems in the test case added in r203119. First is that it's testing
2791         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2792         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2793         const reference to the string view member of the deleted CodePoints object.
2794
2795         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2796         (TestWebKitAPI::TEST):
2797
2798 2016-07-13  Daniel Bates  <dabates@apple.com>
2799
2800         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2801         https://bugs.webkit.org/show_bug.cgi?id=159738
2802         <rdar://problem/27304649>
2803
2804         Reviewed by Dan Bernstein.
2805
2806         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2807         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2808         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2809         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2810
2811         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2812         * WebKitTestRunner/ios/TestControllerIOS.mm:
2813         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2814         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2815
2816 2016-07-13  Beth Dakin  <bdakin@apple.com>
2817
2818         Attempted build fix.
2819
2820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2821
2822 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2823
2824         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2825         https://bugs.webkit.org/show_bug.cgi?id=159686
2826
2827         Reviewed by Chris Dumez.
2828
2829         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2830
2831         * WebKitTestRunner/TestController.cpp:
2832         (WTR::runOpenPanel):
2833         (WTR::TestController::createOtherPage):
2834         (WTR::TestController::createWebViewWithOptions):
2835
2836 2016-07-13  Beth Dakin  <bdakin@apple.com>
2837
2838         Add more candidate tests
2839         https://bugs.webkit.org/show_bug.cgi?id=159730
2840
2841         Reviewed by Tim Horton.
2842
2843         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
2844         two new tests to that file.
2845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2846         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2847         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2848         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2849         (TestWebKitAPI::TEST):
2850         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2851
2852 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2853
2854         AX: [ATK] spinbutton-crash.html fails
2855         https://bugs.webkit.org/show_bug.cgi?id=159723
2856
2857         Reviewed by Chris Fleizach.
2858
2859         Implement support for AXDecrementButton and AXIncrementButton in
2860         ATK's AccessibilityUIElement::uiElementAttributeValue().
2861
2862         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2863         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2864
2865 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2866
2867         [EFL] [GTK] Enable back crypto subtle on development builds.
2868         https://bugs.webkit.org/show_bug.cgi?id=159260
2869
2870         Reviewed by Carlos Garcia Campos.
2871
2872         * Scripts/webkitperl/FeatureList.pm:
2873
2874 2016-07-12  Mark Lam  <mark.lam@apple.com>
2875
2876         We should use different stack limits for stack checks from JS and host code.
2877         https://bugs.webkit.org/show_bug.cgi?id=159442
2878         <rdar://problem/26889188>
2879
2880         Reviewed by Geoffrey Garen.
2881
2882         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2883         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
2884         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
2885         order to keep the js/regress-139548.html test happy with this patch.
2886
2887         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2888         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
2889
2890         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2891         (-[LTRelayController _environmentVariables]):
2892         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2893         (main):
2894
2895 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
2896
2897         platformUserPreferredLanguages on Mac should not try to put the region into the language
2898         https://bugs.webkit.org/show_bug.cgi?id=159693
2899
2900         Rubber stamped by Alexey Proskuryakov.
2901         
2902         Revert the test change in r200105.
2903
2904         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2905         (TestWebKitAPI::languageForSystemLanguage):
2906
2907 2016-07-12  Chris Dumez  <cdumez@apple.com>
2908
2909         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2910         https://bugs.webkit.org/show_bug.cgi?id=159663
2911         <rdar://problem/18995873>
2912
2913         Reviewed by Benjamin Poulain.
2914
2915         Add API test coverage.
2916
2917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2918         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2919         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2920         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2921         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2922         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2923         (TEST):
2924
2925 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
2926
2927         Relax ordering requirements on StringView::CodePoints iterator
2928         https://bugs.webkit.org/show_bug.cgi?id=159609
2929
2930         Reviewed by Darin Adler.
2931
2932         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2933         (TestWebKitAPI::TEST):
2934
2935 2016-07-12  Youenn Fablet  <youenn@apple.com>
2936
2937         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
2938         https://bugs.webkit.org/show_bug.cgi?id=159564
2939
2940         Reviewed by Brian Burg.
2941
2942         * Scripts/webkitpy/codegen/main.py:
2943         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
2944
2945 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2946
2947         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2948         https://bugs.webkit.org/show_bug.cgi?id=159671
2949
2950         Reviewed by Csaba Osztrogonác.
2951
2952         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2953         https://bugs.webkit.org/show_bug.cgi?id=89235
2954
2955         So this guard can be removed in build scripts.
2956
2957         * Scripts/webkitperl/FeatureList.pm:
2958         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2959
2960 2016-07-11  Jason Marcell  <jmarcell@apple.com>
2961
2962         SVN.create_patch should find svn-create-patch relative to the WebKit root.
2963         https://bugs.webkit.org/show_bug.cgi?id=159652
2964
2965         Reviewed by Daniel Bates.
2966
2967         * Scripts/webkitpy/common/checkout/scm/svn.py:
2968         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
2969
2970 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2971
2972         Implement grapheme cluster iterator on StringView
2973         https://bugs.webkit.org/show_bug.cgi?id=159598
2974
2975         Reviewed by Anders Carlsson.
2976
2977         This is in preparation for honoring the second argument to FontFaceSet.load().
2978
2979         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2980         (TestWebKitAPI::compareLoopIterations):
2981         (TestWebKitAPI::TEST):
2982
2983 2016-07-11  Nan Wang  <n_wang@apple.com>
2984
2985         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
2986         https://bugs.webkit.org/show_bug.cgi?id=158364
2987
2988         Reviewed by Anders Carlsson.
2989
2990         Added a function in TestRunner so that we can toggle the ignoring viewport
2991         scale limits setting. Also added a test option for that in order to change the 
2992         configuration of the webview in test.
2993
2994         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2995         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2996         (WTR::TestRunner::setNavigationGesturesEnabled):
2997         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2998         (WTR::nextUIScriptCallbackID):
2999         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3000         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3001         * WebKitTestRunner/TestController.cpp:
3002         (WTR::TestController::resetStateToConsistentValues):
3003         (WTR::updateTestOptionsFromTestHeader):
3004         (WTR::TestController::setNavigationGesturesEnabled):
3005         (WTR::TestController::setIgnoresViewportScaleLimits):
3006         (WTR::TestController::platformWillRunTest):
3007         * WebKitTestRunner/TestController.h:
3008         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3009         * WebKitTestRunner/TestInvocation.cpp:
3010         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3011         * WebKitTestRunner/TestOptions.h:
3012         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3013         (WTR::TestController::platformCreateWebView):
3014
3015 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
3016
3017         [GTK] install-dependencies should not install packages built by jhbuild.
3018         https://bugs.webkit.org/show_bug.cgi?id=159628
3019
3020         Reviewed by Michael Catanzaro.
3021
3022         * gtk/install-dependencies:
3023         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
3024
3025 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
3026
3027         System proxy settings not used when building deps with jhbuild
3028         https://bugs.webkit.org/show_bug.cgi?id=159567
3029
3030         Reviewed by Michael Catanzaro.
3031
3032         This adds the gsettings-desktop-schemas-devel build dep to enable
3033         the libgiognomeproxy.so gio module in glib-networking, which uses
3034         GSettings on org.gnome.system.proxy.
3035         This is needed to query system proxy settings for Gnome desktops.
3036
3037         dconf can be manually added to jhbuild to build the
3038         libdconfsettings.so gio module for GSettings, so that
3039         libgiognomeproxy.so can access system settings.
3040           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
3041
3042         As an alternative to dconf settings, this commit also adds the
3043         libproxy-devel build dep to enable the libgiolibproxy.so module in
3044         glib-networking (suggested by Fujii Hironori).
3045
3046         It is useful to read proxy settings from environment variables.
3047         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
3048         environment variable to force using the envvar module in libproxy.
3049
3050         * gtk/install-dependencies:
3051
3052 2016-07-11  Mark Lam  <mark.lam@apple.com>
3053
3054         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
3055         https://bugs.webkit.org/show_bug.cgi?id=159524
3056
3057         Reviewed by Michael Saboff.
3058
3059         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
3060         Also fixed up some tests to behave better to work with this new limit.  This
3061         should make stack overflow tests complete sooner.
3062
3063         * Scripts/run-jsc-stress-tests:
3064         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3065         (main):
3066
3067 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3068
3069         [GTK] Whitespace fixes in install-dependencies script
3070
3071         Unreviewed.
3072
3073         * gtk/install-dependencies:
3074
3075 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3076
3077         [GTK] Install missing Fedora dependencies
3078
3079         Unreviewed.
3080
3081         * gtk/install-dependencies:
3082
3083 2016-07-09  Dan Bernstein  <mitz@apple.com>
3084
3085         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
3086         https://bugs.webkit.org/show_bug.cgi?id=159600
3087
3088         Reviewed by Daniel Bates.
3089
3090         * Scripts/git-add-reviewer:
3091         Added the -s|--rubber-stamp option.
3092         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
3093           new option.
3094
3095 2016-07-08  Andy Estes  <aestes@apple.com>
3096
3097         [Content Filtering] Load blocked pages more like other error pages are loaded
3098         https://bugs.webkit.org/show_bug.cgi?id=159485
3099         <rdar://problem/26014076>
3100
3101         Reviewed by Brady Eidson.
3102
3103         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3104         to a content filtering provisional navigation failure is ignored in preference of
3105         ContentFilter's own error page.
3106
3107         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3108         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3109         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3110         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3111         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3112         (loadAlternateTest):
3113         (TEST):
3114         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3115         (-[MockContentFilterEnabler initWithCoder:]):
3116         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3117         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3118         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3119         (TestWebKitAPI::loadAlternateTest):
3120         (TestWebKitAPI::TEST):
3121
3122 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3123
3124         Unreviewed, rolling out r202944.
3125         https://bugs.webkit.org/show_bug.cgi?id=159570
3126
3127         caused some tests to crash under GuardMalloc (Requested by
3128         estes on #webkit).
3129
3130         Reverted changeset:
3131
3132         "[Content Filtering] Load blocked pages more like other error
3133         pages are loaded"
3134         https://bugs.webkit.org/show_bug.cgi?id=159485
3135         http://trac.webkit.org/changeset/202944
3136
3137 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
3138
3139         Remove mrobinson from the MathML watchlist
3140         https://bugs.webkit.org/show_bug.cgi?id=159559
3141
3142         Reviewed by Philippe Normand.
3143
3144         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
3145
3146 2016-07-08  Brady Eidson  <beidson@apple.com>
3147
3148         Clearing LocalStorage doesn't also delete -wal and -shm files.
3149         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
3150
3151         Reviewed by Brent Fulgham.
3152         Also helpfully picked over by Andy "Never Forgets" Estes.
3153
3154         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3155         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
3156         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
3157
3158 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
3159
3160         Removed Qt leftovers from Tools.
3161         https://bugs.webkit.org/show_bug.cgi?id=159557
3162
3163         Reviewed by Csaba Osztrogonác.
3164
3165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3166         Removed 'qt' platform config.
3167         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3168         Deleted non-functional e-mail address.
3169
3170 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3171
3172         Unreviewed, rolling out r202967.
3173         https://bugs.webkit.org/show_bug.cgi?id=159556
3174
3175         This patch caused crashes in https tests on Windows (Requested
3176         by perarne on #webkit).
3177
3178         Reverted changeset:
3179
3180         "[Win] The test http/tests/security/contentSecurityPolicy
3181         /upgrade-insecure-requests/basic-upgrade.https.html is
3182         failing."
3183         https://bugs.webkit.org/show_bug.cgi?id=159510
3184         http://trac.webkit.org/changeset/202967
3185
3186 2016-07-08  Youenn Fablet  <youenn@apple.com>
3187
3188         Generate WebCore builtin wrapper files
3189         https://bugs.webkit.org/show_bug.cgi?id=159461
3190
3191         Reviewed by Brian Burg.
3192
3193         * Scripts/webkitpy/codegen/main.py:
3194         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
3195         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
3196
3197 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
3198
3199         [EFL] Fix build when media-stream is enabled.
3200         https://bugs.webkit.org/show_bug.cgi?id=159206
3201
3202         Bump up the openwebrtc to find the correct package.
3203
3204         Reviewed by Gyuyoung Kim.
3205
3206         * efl/jhbuild.modules:
3207         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
3208
3209 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3210
3211         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
3212         https://bugs.webkit.org/show_bug.cgi?id=159510
3213
3214         Reviewed by Brent Fulgham.
3215
3216         Allow any https certificate when running tests.
3217
3218         * DumpRenderTree/win/DumpRenderTree.cpp:
3219         (runTest):
3220
3221 2016-07-07  Beth Dakin  <bdakin@apple.com>
3222
3223         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3224         https://bugs.webkit.org/show_bug.cgi?id=159532
3225         -and corresponding-
3226         rdar://problem/27177179
3227
3228         Reviewed by Tim Horton.
3229
3230         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
3231         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
3232
3233 2016-07-07  Andy Estes  <aestes@apple.com>
3234
3235         [Content Filtering] Load blocked pages more like other error pages are loaded
3236         https://bugs.webkit.org/show_bug.cgi?id=159485
3237         <rdar://problem/26014076>
3238
3239         Reviewed by Brady Eidson.
3240
3241         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3242         to a content filtering provisional navigation failure is ignored in preference of
3243         ContentFilter's own error page.
3244
3245         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3247         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3248         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3249         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3250         (loadAlternateTest):
3251         (TEST):
3252         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3253         (-[MockContentFilterEnabler initWithCoder:]):
3254         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3255         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3256         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3257         (TestWebKitAPI::loadAlternateTest):
3258         (TestWebKitAPI::TEST):
3259
3260 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3261
3262         Unreviewed: add myself to the reviewers list.
3263
3264         * Scripts/webkitpy/common/config/contributors.json:
3265
3266 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3267
3268         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
3269         https://bugs.webkit.org/show_bug.cgi?id=159509
3270
3271         Reviewed by Alex Christensen.
3272
3273         We should always insert the url in the url map when identifierForInitialRequest
3274         is called. Otherwise we can end up with identifiers not having an entry in the
3275         url map when urls are written to the test output file. 
3276
3277         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3278         (ResourceLoadDelegate::identifierForInitialRequest):
3279
3280 2016-07-06  Tim Horton  <timothy_horton@apple.com>
3281
3282         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3283         https://bugs.webkit.org/show_bug.cgi?id=159498
3284         <rdar://problem/26719903>
3285
3286         Reviewed by Sam Weinig.
3287
3288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3289         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3290         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3291         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3292         (expectLinkCount):
3293         (TEST):
3294         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3295         when deciding what to linkify.
3296
3297 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3298
3299         Build fix - work around rdar://problem/27196668.
3300
3301         * LayoutTestRelay/Configurations/Base.xcconfig:
3302
3303 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3304
3305         Enhance Windows DRT implementation to support platform scroll wheel events.
3306         https://bugs.webkit.org/show_bug.cgi?id=36002
3307
3308         Reviewed by Brent Fulgham.
3309
3310         Implement function continuousMouseScrollBy in Windows event sender.
3311
3312         * DumpRenderTree/win/EventSender.cpp:
3313         (mouseScrollBy):
3314         (continuousMouseScrollBy):
3315
3316 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3317
3318         [Sierra] Rebaseline tests to use un-mocked system font metrics
3319         https://bugs.webkit.org/show_bug.cgi?id=159311
3320         <rdar://problem/24138411>
3321
3322         Reviewed in person by Alexey Proskuryakov.
3323
3324         Stop mocking the system font on Sierra.
3325
3326         * DumpRenderTree/mac/DumpRenderTree.mm:
3327         (setDefaultsToConsistentValuesForTesting):
3328         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3329         (WTR::InjectedBundle::platformInitialize):
3330
3331 2016-07-05  Brady Eidson  <beidson@apple.com>
3332
3333         Database process crashes deleting a corrupt SQLite database file (null deref).
3334         https://bugs.webkit.org/show_bug.cgi?id=155506.
3335
3336         Reviewed by Alex Christensen.
3337
3338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3339         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3340         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3341         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3342         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3343         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3344
3345 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3346
3347         run-webkit-tests should print more complete baseline search paths
3348         https://bugs.webkit.org/show_bug.cgi?id=159354
3349
3350         Reviewed by Daniel Bates.
3351
3352         run-webkit-tests used to only print directory names in baseline search paths.
3353         This was ok in basic usage, but quickly got confusing when using
3354         --additional-platform-directory flags.
3355
3356         * Scripts/webkitpy/layout_tests/views/printing.py:
3357         (Printer.print_config):
3358         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3359         (Testprinter.test_print_config):
3360         (Testprinter.test_print_one_line_summary):
3361
3362 2016-07-04  Brady Eidson  <beidson@apple.com>
3363
3364         WebProcesses don't handle DatabaseProcess going away uncleanly..
3365         https://bugs.webkit.org/show_bug.cgi?id=159371
3366
3367         Reviewed by Alex Christensen.
3368
3369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3370         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3371         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3372         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3373         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3374
3375 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3376
3377         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3378         https://bugs.webkit.org/show_bug.cgi?id=158141
3379
3380         Rubber-stamped by Michael Catanzaro.
3381
3382         Instead of checking for an specific Ubuntu version, query the apt
3383         database to see which version of PHP is available.
3384
3385         * efl/install-dependencies:
3386         * gtk/install-dependencies:
3387
3388 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3389
3390         webkit-patch failure-reason always raises TypeError
3391         https://bugs.webkit.org/show_bug.cgi?id=159394
3392
3393         Reviewed by Benjamin Poulain.
3394
3395         In r170637 (Bug 133067), the first and second arguments of
3396         pluralize were swapped.
3397
3398         * Scripts/webkitpy/tool/commands/queries.py:
3399         (FailureReason._builder_to_explain): Swap the first and second
3400         arguments of pluralize.
3401
3402 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3403
3404         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3405         https://bugs.webkit.org/show_bug.cgi?id=152486
3406
3407         Reviewed by Daniel Bates.
3408
3409         Add launch of web-platform-tests server by run-webkit-httpd.
3410         Add two options to disable starting httpd and web-platform-tests servers.
3411
3412         * Scripts/run-webkit-httpd:
3413         (parse_args):
3414         (main):
3415
3416 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3417
3418         REGRESSION(r189668): Notification tests are flakey
3419         https://bugs.webkit.org/show_bug.cgi?id=159375
3420         <rdar://problem/22760990>
3421
3422         Reviewed by Alexey Proskuryakov.
3423
3424         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3425         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3426         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3427         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3428
3429         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3430         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3431         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3432         global notification ID mapping, causing the wrong notification to be investigated.
3433
3434         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3435         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3436         notification is created or destroyed. However, because this object is implemented outside WebKit,
3437         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3438         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3439         WebNotificationProvider can properly map between the different IDs.
3440
3441         * WebKitTestRunner/TestController.cpp:
3442         (WTR::TestController::runTestingServerLoop):
3443         (WTR::TestController::simulateWebNotificationClick):
3444         * WebKitTestRunner/WebNotificationProvider.cpp:
3445         (WTR::WebNotificationProvider::showWebNotification):
3446         (WTR::removeGlobalIDFromIDMap):
3447         (WTR::WebNotificationProvider::closeWebNotification):
3448         (WTR::WebNotificationProvider::removeNotificationManager):
3449         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3450         (WTR::WebNotificationProvider::reset):
3451         * WebKitTestRunner/WebNotificationProvider.h:
3452
3453 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3454
3455         Simplify LayoutTestRelay
3456         https://bugs.webkit.org/show_bug.cgi?id=159353
3457
3458         Reviewed by Daniel Bates.
3459
3460         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3461         by name and runtime makes no sense.
3462         2. Removed code to create devices, webkitpy always does this in advance.
3463         3. Don't create copies of testing apps - we can install the same one into
3464         each simulator, now that we don't run multiple tester processes in a single simulator.
3465         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3466         5. Removed code that kept testing apps alive in the background.
3467         6. Slightly updated coding style in functions that I touched.
3468
3469         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3470         Updated for what we acually use at this point.
3471
3472         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3473         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3474         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3475         (-[LTRelayController ipcIdentifier]):
3476         (-[LTRelayController processName]):
3477         (-[LTRelayController didReceiveStdoutData:]):
3478         (-[LTRelayController didCrashWithMessage:]):
3479         (-[LTRelayController installApp]):
3480         (-[LTRelayController _environmentVariables]):
3481         (-[LTRelayController launchApp]):
3482         (-[LTRelayController start]):
3483         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3484         (-[LTRelayController uniqueAppPath]): Deleted.
3485         (-[LTRelayController uniqueAppURL]): Deleted.
3486         (-[LTRelayController uniqueAppIdentifier]): Deleted.
3487         (-[LTRelayController createUniqueApp]): Deleted.
3488         * LayoutTestRelay/LayoutTestRelay/main.m:
3489         (usage):
3490         (getRequiredStringArgument):
3491         (main):
3492         (getTestingSimDevice): Deleted.
3493         * Scripts/webkitpy/port/driver.py:
3494         (IOSSimulatorDriver.cmd_line):
3495         * WebKitTestRunner/ios/TestControllerIOS.mm:
3496         (WTR::TestController::platformInitialize):
3497         * WebKitTestRunner/ios/mainIOS.mm:
3498         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3499         * DumpRenderTree/mac/DumpRenderTree.mm:
3500         (dumpRenderTree):
3501         (-[DumpRenderTree applicationDidEnterBackground:]):
3502
3503 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
3504
3505         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3506         https://bugs.webkit.org/show_bug.cgi?id=159344
3507
3508         Reviewed by Alex Christensen.
3509
3510         * DumpRenderTree/CMakeLists.txt:
3511
3512 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3513
3514         Add a runtime flag for DOM iterators
3515         https://bugs.webkit.org/show_bug.cgi?id=159300
3516
3517         Reviewed by Alex Christensen.
3518
3519         * DumpRenderTree/mac/DumpRenderTree.mm:
3520         (resetWebPreferencesToConsistentValues):
3521         * DumpRenderTree/win/DumpRenderTree.cpp:
3522         (resetWebPreferencesToConsistentValues):
3523         * Scripts/webkitperl/FeatureList.pm:
3524         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3525         (WTR::InjectedBundle::beginTesting):
3526         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3527         (WTR::TestRunner::setDOMIteratorEnabled):
3528         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3529
3530 2016-06-30  Tina Liu  <iting_liu@apple.com>
3531
3532         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3533         https://bugs.webkit.org/show_bug.cgi?id=159326
3534
3535         Reviewed by Brady Eidson.
3536
3537         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3538         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3539         (TestWebKitAPI::didFinishLoadForFrame):
3540         (TestWebKitAPI::didChangeBackForwardListForPage):
3541         (TestWebKitAPI::setPageLoaderClient):
3542         Set the page loader client and register for didFinishLoadForFrame and
3543         didChangeBackForwardList callbacks.
3544         (TestWebKitAPI::createSessionStateData):
3545         Load a webpage ("simple.html") and return the session state for this page.
3546         (TestWebKitAPI::TEST):
3547         Restore the page session state with that of "simple.html" without navigation.
3548         Verify that the committed URL is NULL since there's no navigation involved.
3549         Verify that the current item in the back forward list, which should be what
3550         we restored from the session state, has the expected URL.
3551
3552 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
3553
3554         Generators violate bytecode liveness validation
3555         https://bugs.webkit.org/show_bug.cgi?id=159279
3556
3557         Reviewed by Yusuke Suzuki.
3558         
3559         Add Basic to our test harness.
3560
3561         * Scripts/run-javascriptcore-tests:
3562         (runJSCStressTests):
3563
3564 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
3565
3566         [Win][Debug] Assertion fails in TestWTF.
3567         https://bugs.webkit.org/show_bug.cgi?id=159299
3568
3569         Reviewed by Alex Christensen.
3570
3571         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3572         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3573         the assertion failure. Since the variable is actually used, there is no need to use the
3574         UNUSED_PARAM macro.
3575
3576         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3577         (TestWebKitAPI::TEST):
3578
3579 2016-06-30  Youenn Fablet  <youennf@gmail.com>
3580
3581         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
3582         https://bugs.webkit.org/show_bug.cgi?id=159166
3583         <rdar://problem/27051759>
3584
3585         Reviewed by Alexey Proskuryakov.
3586
3587         Setting the certificate directory to the copied config.json.
3588
3589         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3590         (WebPlatformTestServer._copy_webkit_test_files):
3591
3592 2016-06-29  Mark Lam  <mark.lam@apple.com>
3593
3594         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
3595         https://bugs.webkit.org/show_bug.cgi?id=159274
3596
3597         Reviewed by Keith Miller.
3598
3599         * DumpRenderTree/mac/DumpRenderTree.mm:
3600         (DumpRenderTreeMain):
3601
3602 2016-06-29  Alex Christensen  <achristensen@webkit.org>
3603
3604         WKWebView should ask WKNavigationDelegate about bad ssl certificates
3605         https://bugs.webkit.org/show_bug.cgi?id=159176
3606
3607         Reviewed by Sam Weinig.
3608
3609         * MiniBrowser/mac/WK2BrowserWindowController.m:
3610         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3611         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3612         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3613
3614 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3615
3616         [GTK] Add missing install dependency after r202619
3617         https://bugs.webkit.org/show_bug.cgi?id=156716
3618
3619         Unreviewed.
3620
3621         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3622
3623 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3624
3625         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3626         https://bugs.webkit.org/show_bug.cgi?id=156716
3627
3628         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3629
3630         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3631         (parse_args):
3632         * Scripts/webkitpy/port/gtk.py:
3633         (GtkPort.__init__):
3634         (GtkPort._driver_class):
3635         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3636         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3637         platform directory for storing the wayland specific layout test results and expectations for ${port}.
3638         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3639         test expectations file on the GTK port when running the tests with the --wayland command line switch.
3640         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3641         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3642         (WestonDriver.check_driver):
3643         (WestonDriver.__init__):
3644         (WestonDriver._start):
3645         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3646         (WestonXvfbDriverDisplayTest):
3647         (WestonXvfbDriverDisplayTest.__init__):
3648         (WestonXvfbDriverDisplayTest._xvfb_run):
3649         (WestonDriverTest.make_driver):
3650         (WestonDriverTest.test_start):
3651         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3652         or to satisfy the pkg-config check of the new added modules in JHBuild.
3653         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3654         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3655         provided by the system are already new enough.
3656         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3657         It was the only way to get the software EGL rasterizer working without depending on user drivers.
3658         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3659         feature to avoid building libdrm when the one provided by the system is new enough.
3660         * gtk/jhbuildrc:
3661         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
3662         Xorg had no support for searching the DRI drivers on a custom path at runtime.
3663         This patch implements support for that reusing the same variable that we use with Mesa to set the
3664         custom path for the DRI drivers path.
3665
3666 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
3667
3668         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
3669         https://bugs.webkit.org/show_bug.cgi?id=159256
3670
3671         Reviewed by Philippe Normand.
3672
3673         We need the last fixes in the repository to make the scream queue
3674         work with apprtc.
3675
3676         * gtk/jhbuild.modules:
3677
3678 2016-06-28  Commit Queue  <commit-queue@webkit.org>
3679
3680         Unreviewed, rolling out r202580.
3681         https://bugs.webkit.org/show_bug.cgi?id=159245
3682
3683         Caused all WKTR tests to fail on GuardMalloc and Production
3684         only for unknown reasons, investigating offline. (Requested by
3685         brrian on #webkit).
3686
3687         Reverted changeset:
3688
3689         "RunLoop::Timer should use constructor templates instead of
3690         class templates"
3691         https://bugs.webkit.org/show_bug.cgi?id=159153
3692         http://trac.webkit.org/changeset/202580
3693
3694 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3695
3696         Use a regex to check if a test step is for JavaScriptCore
3697         https://bugs.webkit.org/show_bug.cgi?id=159224
3698
3699         Reviewed by Geoffrey Garen.
3700
3701         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3702         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
3703         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3704         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
3705         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3706         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
3707
3708 2016-06-28  Michael Saboff  <msaboff@apple.com>
3709
3710         btjs no longer accepts optional frame count argument
3711         https://bugs.webkit.org/show_bug.cgi?id=159235
3712
3713         Reviewed by Saam Barati.
3714
3715         Fix the detection of optional backtrace-depth parameter to use the length
3716         of the command.
3717
3718         * lldb/lldb_webkit.py:
3719         (btjs):
3720
3721 2016-06-28  Jon Lee  <jonlee@apple.com>
3722
3723         Update animometer.plan
3724
3725         Rubber-stamped by Said Abou-Hallawa.
3726
3727         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
3728
3729 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
3730
3731         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
3732
3733         * Scripts/run-javascriptcore-tests:
3734         (runJSCStressTests):
3735
3736 2016-06-28  Brian Burg  <bburg@apple.com>
3737
3738         RunLoop::Timer should use constructor templates instead of class templates
3739         https://bugs.webkit.org/show_bug.cgi?id=159153
3740
3741         Reviewed by Alex Christensen.
3742
3743         Remove the RunLoop::Timer class template argument, and pass its constructor
3744         a reference to `this` instead of a pointer to `this`.
3745
3746         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3747         (WTR::TestRunner::TestRunner):
3748         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3749         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3750         (TestWebKitAPI::TEST):
3751
3752 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3753
3754         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3755         https://bugs.webkit.org/show_bug.cgi?id=159199
3756
3757         Reviewed by Alexey Proskuryakov.
3758
3759         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
3760
3761         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3762         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3763         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
3764         an input element getting automatically focused on Mac.
3765
3766 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
3767
3768         [Win] Custom elements tests are failing.
3769         https://bugs.webkit.org/show_bug.cgi?id=159139
3770
3771         Reviewed by Alex Christensen.
3772
3773         Enable custom element API when running tests.
3774
3775         * DumpRenderTree/win/DumpRenderTree.cpp:
3776         (resetWebPreferencesToConsistentValues):
3777
3778 2016-06-27  Lucas Forschler  <lforschler@apple.com>
3779
3780         Test commit. Please ignore.
3781         
3782 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3783
3784         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
3785         https://bugs.webkit.org/show_bug.cgi?id=155073
3786
3787         Reviewed by Daniel Bates.
3788
3789         * Scripts/webkitperl/FeatureList.pm:
3790
3791 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
3792
3793         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3794         https://bugs.webkit.org/show_bug.cgi?id=159077
3795
3796         Reviewed by Tim Horton.
3797
3798         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
3799
3800         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
3801         which is necessary for UI-side compositing.
3802
3803         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
3804         seems to happen for some tests that call window.resizeTo().
3805
3806         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3807         (WTR::InjectedBundlePage::dump): Deleted.
3808         * WebKitTestRunner/TestInvocation.cpp:
3809         (WTR::TestInvocation::dumpResults):
3810         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3811         (WTR::createCGContextFromImage):
3812         (WTR::computeMD5HashStringForContext):
3813         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3814         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3815         (WTR::PlatformWebView::windowSnapshotImage):
3816
3817 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3818
3819         [EFL] Support to build on Debian linux
3820         https://bugs.webkit.org/show_bug.cgi?id=159123
3821
3822         Reviewed by Antonio Gomes.
3823
3824         * efl/install-dependencies: Install libgnutls28-dev.
3825
3826 2016-06-27  Alex Christensen  <achristensen@webkit.org>
3827
3828         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
3829         https://bugs.webkit.org/show_bug.cgi?id=159071
3830
3831         Reviewed by Brady Eidson.
3832
3833         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3834         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3835         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3836         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3837         (WTR::TestRunner::setAuthenticationUsername):
3838         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3839         * WebKitTestRunner/TestController.cpp:
3840         (WTR::TestController::TestController):
3841         (WTR::TestController::resetStateToConsistentValues):
3842         (WTR::TestController::didFinishNavigation):
3843         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3844         (WTR::TestController::didReceiveAuthenticationChallenge):
3845         (WTR::TestController::didCommitNavigation):
3846         * WebKitTestRunner/TestController.h:
3847         (WTR::TestController::setBlockAllPlugins):
3848         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3849         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
3850         (WTR::TestController::isCurrentInvocation):
3851         * WebKitTestRunner/TestInvocation.cpp:
3852         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3853         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
3854
3855 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
3856
3857         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
3858         https://bugs.webkit.org/show_bug.cgi?id=159129
3859
3860         Reviewed by Alex Christensen.
3861
3862         Implement the function mouseScrollBy in the Windows event sender.
3863
3864         * DumpRenderTree/win/EventSender.cpp:
3865         (mouseScrollBy):
3866         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3867
3868 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
3869
3870         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3871         https://bugs.webkit.org/show_bug.cgi?id=159104
3872
3873         Reviewed by Dan Bernstein.
3874         
3875         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
3876         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
3877
3878         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3879         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3880         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
3881
3882 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
3883
3884         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
3885         https://bugs.webkit.org/show_bug.cgi?id=159086
3886
3887         Reviewed by Alex Christensen.
3888
3889         Implement required wheel event function in event sender.
3890  
3891         * DumpRenderTree/win/EventSender.cpp:
3892         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3893
3894 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
3895
3896         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3897         https://bugs.webkit.org/show_bug.cgi?id=159104
3898
3899         Reviewed by Mark Lam.
3900         
3901         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
3902         WK.
3903
3904         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3905
3906 2016-06-24  David Kilzer  <ddkilzer@apple.com>
3907
3908         parser_unittests.pl should not hardcode list of tests
3909         <https://webkit.org/b/159074>
3910
3911         Reviewed by Daniel Bates.
3912
3913         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3914         Update to read the list of tests from the 'resources' directory,
3915         and instead map file extensions to subroutine names.  Switch to
3916         use File::Basename::fileparse() to get basename and file
3917         extension for each test.
3918         (readTestFiles): Added.  Reads files from the directory passed
3919         in and ignores: hidden files, anything that isn't a plain file,
3920         and expected test results files.
3921
3922 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3923
3924         Fix Windows build.
3925
3926         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3927         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3928
3929 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3930
3931         [EFL] Change download path of libxslt
3932
3933         Unreviewed EFL build fix.
3934
3935         In Korea current download path can't be accessed. Change it.
3936
3937         * efl/jhbuild.modules:
3938
3939 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3940
3941         https://bugs.webkit.org/show_bug.cgi?id=159077
3942
3943         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
3944         snapshot the final state of the test in release builds. 
3945
3946         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3947         (WTR::InjectedBundlePage::dump):
3948
3949 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3950
3951         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
3952
3953         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3954         (createBitmapContextFromWebView):
3955         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3956         (WTR::PlatformWebView::windowSnapshotImage):
3957
3958 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3959
3960         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3961         https://bugs.webkit.org/show_bug.cgi?id=159077
3962
3963         Reviewed by Tim Horton.
3964
3965         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
3966         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
3967         thus enabling testing of more things.
3968
3969         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3970         (createBitmapContext): Moved to this file to share it.
3971         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3972         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3973         (createBitmapContextFromWebView):
3974         (BitmapContext::createFromUIImage): Deleted.
3975         (BitmapContext::pixelData): Deleted.
3976         (BitmapContext::BitmapContext): Deleted.
3977         (computeMD5HashStringForBitmapContext): Deleted.
3978         (dumpBitmap): Deleted.
3979         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
3980         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3981         (createPagedBitmapContext):
3982         (createBitmapContext): Deleted.
3983         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
3984         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3985         (WTR::InjectedBundlePage::dump): Deleted.
3986         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3987         (WTR::PlatformWebView::windowSnapshotImage):
3988
3989 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3990
3991         [jhbuild] Added libxslt module.
3992         https://bugs.webkit.org/show_bug.cgi?id=159034
3993
3994         Unreviewed, followup for r202373.
3995
3996         * efl/install-dependencies: Removed libxslt 
3997         * gtk/install-dependencies: Ditto.
3998
3999 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4000
4001         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
4002         https://bugs.webkit.org/show_bug.cgi?id=159050
4003
4004         Reviewed by Antonio Gomes.
4005
4006         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
4007
4008         * efl/jhbuild.modules:
4009         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
4010         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
4011
4012 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
4013
4014         [jhbuild] Added libxslt module.
4015         https://bugs.webkit.org/show_bug.cgi?id=159034
4016
4017         Reviewed by Michael Catanzaro.
4018
4019         * efl/jhbuild.modules:
4020         * gtk/jhbuild.modules:
4021
4022 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4023
4024         [Win] Use Windows api function to find top level parent.
4025         https://bugs.webkit.org/show_bug.cgi?id=159021
4026
4027         Reviewed by Brent Fulgham.
4028
4029         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
4030  
4031         * DumpRenderTree/win/UIDelegate.cpp:
4032         (UIDelegate::runModal):
4033         (findTopLevelParent): Deleted.
4034         * MiniBrowser/win/PrintWebUIDelegate.cpp:
4035         (PrintWebUIDelegate::runModal):
4036         (findTopLevelParent): Deleted.
4037
4038 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4039
4040         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
4041         https://bugs.webkit.org/show_bug.cgi?id=158934
4042
4043         Reviewed by Brent Fulgham.
4044
4045         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
4046
4047         * DumpRenderTree/win/TestRunnerWin.cpp:
4048         (TestRunner::clearAllDatabases):
4049
4050 2016-06-22  Saam Barati  <sbarati@apple.com>
4051
4052         run-javascriptcore-tests should have some environment variables for commonly used settings
4053         https://bugs.webkit.org/show_bug.cgi?id=159047
4054
4055         Reviewed by Keith Miller.
4056
4057         This patch adds three environment variables that run-javascriptcore-tests
4058         consults:
4059         - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
4060           determines if we should run the api tests or not.
4061         - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
4062           determines if we will perform a build or not before running the tests.
4063           to set the default should-build setting.
4064         - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
4065           a yaml file. If set, we will run the extra tests it refers to.
4066
4067         All the values in these environment variables will be overridden if an
4068         option is explicitly passed in. For example, the following will run
4069         the api tests:
4070         `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
4071
4072         * Scripts/run-javascriptcore-tests:
4073
4074 2016-06-22  Saam barati  <sbarati@apple.com>
4075
4076         TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
4077         https://bugs.webkit.org/show_bug.cgi?id=159037
4078         <rdar://problem/26935349>
4079
4080         Reviewed by Benjamin Poulain.
4081
4082         Run typeProfiler.yaml tests under an additional CJIT enabled mode.
4083
4084         * Scripts/run-jsc-stress-tests:
4085
4086 2016-06-22  Aakash Jain  <aakash_jain@apple.com>
4087
4088         Fix style issues in webkitpy
4089         https://bugs.webkit.org/show_bug.cgi?id=159019
4090
4091         Reviewed by Daniel Bates.
4092
4093         Fixed the formatting issues as reported by check-webkit-style in webkitpy.
4094         There is no functionality change.
4095         Only affected file names retained below for brevity.
4096
4097         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
4098         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
4099         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
4100         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
4101         * Scripts/webkitpy/benchmark_runner/utils.py:
4102         * Scripts/webkitpy/common/checkout/changelog.py:
4103         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4104         * Scripts/webkitpy/common/checkout/checkout.py:
4105         * Scripts/webkitpy/common/checkout/checkout_mock.py:
4106         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
4107         * Scripts/webkitpy/common/checkout/commitinfo.py:
4108         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
4109         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
4110         * Scripts/webkitpy/common/checkout/scm/scm.py:
4111         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4112         * Scripts/webkitpy/common/config/committers_unittest.py:
4113         * Scripts/webkitpy/common/config/irc.py:
4114         * Scripts/webkitpy/common/config/ports.py:
4115         * Scripts/webkitpy/common/config/ports_unittest.py:
4116         * Scripts/webkitpy/common/config/urls.py:
4117         * Scripts/webkitpy/common/host_mock.py:
4118         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4119         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4120         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4121         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
4122         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4123         * Scripts/webkitpy/common/net/credentials_unittest.py:
4124         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
4125         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
4126         * Scripts/webkitpy/common/net/statusserver.py:
4127         * Scripts/webkitpy/common/system/autoinstall.py:
4128         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
4129         * Scripts/webkitpy/common/system/executive.py:
4130         * Scripts/webkitpy/common/system/executive_mock.py:
4131         * Scripts/webkitpy/common/system/executive_unittest.py:
4132         * Scripts/webkitpy/common/system/filesystem_mock.py:
4133         * Scripts/webkitpy/common/system/filesystem_unittest.py:
4134         * Scripts/webkitpy/common/system/logutils_unittest.py:
4135         * Scripts/webkitpy/common/system/path.py:
4136         * Scripts/webkitpy/common/system/path_unittest.py:
4137         * Scripts/webkitpy/common/system/platforminfo.py:
4138         * Scripts/webkitpy/common/system/user.py:
4139         * Scripts/webkitpy/common/system/user_unittest.py:
4140         * Scripts/webkitpy/common/system/workspace_unittest.py:
4141         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
4142         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
4143         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
4144         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4145         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4146         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4147         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
4148         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
4149         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4150         * Scripts/webkitpy/layout_tests/models/test_failures.py:
4151         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
4152         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4153         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
4154         * Scripts/webkitpy/layout_tests/views/printing.py:
4155         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4156         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
4157         * Scripts/webkitpy/port/base_unittest.py:
4158         * Scripts/webkitpy/port/driver.py:
4159         * Scripts/webkitpy/port/driver_unittest.py:
4160         * Scripts/webkitpy/port/factory.py:
4161         * Scripts/webkitpy/port/gtk.py:
4162         * Scripts/webkitpy/port/server_process_unittest.py:
4163         * Scripts/webkitpy/port/test.py:
4164         * Scripts/webkitpy/port/win.py:
4165         * Scripts/webkitpy/style/checker.py:
4166         * Scripts/webkitpy/style/checkers/common_unittest.py:
4167         * Scripts/webkitpy/style/checkers/cpp.py:
4168         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4169         * Scripts/webkitpy/style/checkers/js.py:
4170         * Scripts/webkitpy/style/checkers/jsonchecker.py:
4171         * Scripts/webkitpy/style/checkers/png.py:
4172         * Scripts/webkitpy/style/checkers/text.py:
4173         * Scripts/webkitpy/style/checkers/text_unittest.py:
4174         * Scripts/webkitpy/style/error_handlers.py:
4175         * Scripts/webkitpy/style/filter.py:
4176         * Scripts/webkitpy/style/filter_unittest.py:
4177         * Scripts/webkitpy/style/optparser.py:
4178         * Scripts/webkitpy/style/optparser_unittest.py:
4179         * Scripts/webkitpy/test/main.py:
4180         * Scripts/webkitpy/w3c/test_converter.py:
4181         * Scripts/webkitpy/w3c/test_converter_unittest.py:
4182         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4183         * Scripts/webkitpy/xcode/simulator.py:
4184
4185 2016-06-22  Brady Eidson  <beidson@apple.com>
4186
4187         DatabaseProcess doesn't handle WebProcesses going away uncleanly.
4188         https://bugs.webkit.org/show_bug.cgi?id=158894
4189
4190         Reviewed by Alex Christensen.
4191
4192         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4193         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
4194         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
4195         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
4196
4197 2016-06-22  Jon Lee  <jonlee@apple.com>
4198
4199         Update animometer.plan
4200         https://bugs.webkit.org/show_bug.cgi?id=159012
4201
4202         Reviewed by Ryosuke Niwa.
4203
4204         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
4205
4206 2016-06-22  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4207
4208         W3C test importer should generate files to ignore by WebKit SCM
4209         https://bugs.webkit.org/show_bug.cgi?id=142743
4210
4211         Reviewed by Darin Adler.
4212
4213         TestDownloader generates the .gitignore file according submodules git repository information.
4214         TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.
4215
4216         * Scripts/webkitpy/w3c/test_downloader.py:
4217         (TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
4218         * Scripts/webkitpy/w3c/test_importer.py:
4219         (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
4220         (TestImporter):
4221         (TestImporter.write_init_py): Writing not empty __init__.py files.
4222         (TestImporter.import_tests): Using  of write_init_py. 
4223         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4224         (TestImporterTest.test_git_ignore_generation): Added .gitignore test.
4225         (TestImporterTest):
4226         (TestImporterTest.test_initpy_generation): Added __init__.py test.
4227
4228 2016-06-21  Sam Weinig  <sam@webkit.org>
4229
4230         WKWebView with no WKNavigationDelegate does not follow universal links
4231         <rdar://problem/24374110>
4232         https://bugs.webkit.org/show_bug.cgi?id=158997
4233
4234         Reviewed by Dan Bernstein.
4235
4236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4237         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
4238         Add a new test that shows that we have a default navigation delegate by swizzling
4239         -[NSWorkspace openURL:]. This will only be called if there is a default client.
4240
4241 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4242
4243         [Win] Implement modal dialog support in MiniBrowser.
4244         https://bugs.webkit.org/show_bug.cgi?id=158976
4245
4246         Reviewed by Brent Fulgham.
4247
4248         * MiniBrowser/win/PrintWebUIDelegate.cpp:
4249         (PrintWebUIDelegate::createWebViewWithRequest):
4250         (getHandleFromWebView):
4251         (PrintWebUIDelegate::webViewClose):
4252         (PrintWebUIDelegate::setFrame):
4253         (PrintWebUIDelegate::webViewFrame):
4254         (PrintWebUIDelegate::canRunModal):
4255         (findTopLevelParent):
4256         (PrintWebUIDelegate::runModal):
4257         (PrintWebUIDelegate::createModalDialog):
4258         * MiniBrowser/win/PrintWebUIDelegate.h:
4259         (PrintWebUIDelegate::webViewClose):
4260         (PrintWebUIDelegate::setFrame):
4261         (PrintWebUIDelegate::webViewFrame):
4262         (PrintWebUIDelegate::canRunModal):
4263         (PrintWebUIDelegate::runModal):
4264
4265 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4266
4267         window.showModalDialog doesn't work in DumpRenderTree on Windows
4268         https://bugs.webkit.org/show_bug.cgi?id=53675
4269
4270         Reviewed by Brent Fulgham.
4271
4272         Implement modal dialog support in DumpRenderTree.
4273
4274         * DumpRenderTree/win/UIDelegate.cpp:
4275         (UIDelegate::canRunModal):
4276         (getHandleFromWebView):
4277         (UIDelegate::createModalDialog):
4278         (findTopLevelParent):
4279         (UIDelegate::runModal):
4280         (UIDelegate::webViewClose):
4281         * DumpRenderTree/win/UIDelegate.h: