Update existing .xcfilelists
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-25  Keith Rollin  <krollin@apple.com>
2
3         Update existing .xcfilelists
4         https://bugs.webkit.org/show_bug.cgi?id=193791
5         <rdar://problem/47201706>
6
7         Reviewed by Alex Christensen.
8
9         Many .xcfilelist files were added in r238824 in order to support
10         XCBuild. Update these with recent changes to the set of build files
11         and with the current generate-xcfilelist script.
12
13         * DumpRenderTree/DerivedSources-input.xcfilelist:
14         * DumpRenderTree/DerivedSources-output.xcfilelist:
15         * WebKitTestRunner/DerivedSources-input.xcfilelist:
16         * WebKitTestRunner/DerivedSources-output.xcfilelist:
17
18 2019-01-25  Keith Rollin  <krollin@apple.com>
19
20         Fix missing dependencies in extract-dependencies-from-makefile
21         https://bugs.webkit.org/show_bug.cgi?id=193783
22         <rdar://problem/47201571>
23
24         Reviewed by Alex Christensen.
25
26         The extract-dependencies-from-makefile script generates .xcfilelists
27         for XCBuild by invoking a makefile in --debug mode, parsing the
28         dependency information in the output, and extracting information
29         regarding targets and dependents. However, the way `make` emits this
30         dependency information is not rigorous, and so we need to determine
31         what lines to look for and parse by trial and error. This approach
32         didn't coriginally atch all the information we needed to collect, so
33         update the script to look for the additional lines we now know to look
34         for.
35
36         * Scripts/extract-dependencies-from-makefile:
37         (Parser):
38         (Parser.addTarget):
39         (Parser.addPrereq):
40         (Parser.doParse):
41
42 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
43
44         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
45         https://bugs.webkit.org/show_bug.cgi?id=193297
46         <rdar://problem/47158841>
47
48         Reviewed by Alex Christensen.
49
50         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
51             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
52         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
53         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
54         activating the message used to trigger the callback when it is set.
55
56 2019-01-25  Alex Christensen  <achristensen@webkit.org>
57
58         WKWebView.goBack should reload if there is a safe browsing warning
59         https://bugs.webkit.org/show_bug.cgi?id=193805
60         <rdar://problem/46908216>
61
62         Reviewed by Geoff Garen.
63
64         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
65         (+[Simple3LookupContext sharedLookupContext]):
66         (-[Simple3LookupContext lookUpURL:completionHandler:]):
67         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
68         (TEST):
69
70 2019-01-25  Chris Dumez  <cdumez@apple.com>
71
72         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
73         https://bugs.webkit.org/show_bug.cgi?id=193788
74         <rdar://problem/47531231>
75
76         Reviewed by Alex Christensen.
77
78         Add API test coverage.
79
80         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
81         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
82
83 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
84
85         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
86         https://bugs.webkit.org/show_bug.cgi?id=193771
87
88         Unreviewed infrastructure fix.
89
90         * Scripts/webkitpy/port/darwin.py:
91         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
92
93 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
94
95         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
96
97 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
98
99         Add contributors.json entries for Ling Ho and for a new bot watchers group.
100
101         * Scripts/webkitpy/common/config/contributors.json:
102
103 2019-01-25  Chris Dumez  <cdumez@apple.com>
104
105         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
106         https://bugs.webkit.org/show_bug.cgi?id=193779
107         <rdar://problem/46170903>
108
109         Reviewed by Antti Koivisto.
110
111         Add API test that quickly navigates forward to a previous process without waiting for it to
112         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
113         the process' previous page when reconnecting the it for the forward navigation.
114
115         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
116
117 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
118
119         Need a way for JavaScript (or bundle) code to participate in undo
120         https://bugs.webkit.org/show_bug.cgi?id=190009
121         <rdar://problem/44807048>
122
123         Reviewed by Ryosuke Niwa.
124
125         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
126         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
127
128         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
129         (WTR::UIScriptController::lastUndoLabel const):
130         (WTR::UIScriptController::firstRedoLabel const):
131         (WTR::UIScriptController::platformUndoManager const):
132         * DumpRenderTree/mac/UIScriptControllerMac.mm:
133         (WTR::UIScriptController::lastUndoLabel const):
134         (WTR::UIScriptController::firstRedoLabel const):
135         (WTR::UIScriptController::platformUndoManager const):
136         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
137         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
138         (WTR::UIScriptController::lastUndoLabel const):
139         (WTR::UIScriptController::firstRedoLabel const):
140         * TestRunnerShared/UIScriptContext/UIScriptController.h:
141         * WebKitTestRunner/UIScriptControllerCocoa.mm:
142         (WTR::UIScriptController::lastUndoLabel const):
143         (WTR::UIScriptController::firstRedoLabel const):
144         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
145         (WTR::UIScriptController::platformUndoManager const):
146         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
147         (WTR::UIScriptController::platformUndoManager const):
148
149 2019-01-25  Zalan Bujtas  <zalan@apple.com>
150
151         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
152         https://bugs.webkit.org/show_bug.cgi?id=193824
153
154         Reviewed by Antti Koivisto.
155
156         * LayoutReloaded/misc/LFC-passing-tests.txt:
157
158 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
159
160         Update macOS JSC bot configurations
161         https://bugs.webkit.org/show_bug.cgi?id=193739
162
163         Reviewed by Alexey Proskuryakov.
164
165         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
166         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
167         (BubbleQueueServer): Move JSC EWS to Mojave section.
168         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
169         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
170         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
171
172 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
173
174         [Win][WebKitTestRunner] Implement EventSenderProxy
175         https://bugs.webkit.org/show_bug.cgi?id=193755
176
177         Reviewed by Don Olmstead.
178
179         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
180         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
181         (WTR::EventSenderProxy::dispatchMessage):
182         (WTR::EventSenderProxy::EventSenderProxy):
183         (WTR::EventSenderProxy::mouseDown):
184         (WTR::EventSenderProxy::mouseUp):
185         (WTR::EventSenderProxy::mouseMoveTo):
186         (WTR::EventSenderProxy::mouseScrollBy):
187         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
188
189 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
190
191         Unreviewed fix for API test failure after r240437.
192
193         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
194
195         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
196
197 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
198
199         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
200         https://bugs.webkit.org/show_bug.cgi?id=193787
201         <rdar://problem/47497634>
202
203         Reviewed by Alexey Proskuryakov.
204
205         * Scripts/webkitdirs.pm:
206         (iosSimulatorApplicationsPath): Pick from available runtime directories.
207
208 2019-01-24  Truitt Savell  <tsavell@apple.com>
209
210         Unreviewed, rolling out r240446.
211
212         Casued 5 API failures
213
214         Reverted changeset:
215
216         "Activate the WebResourceLoadStatisticsStore in the
217         NetworkProcess and deactivate it in the UIProcess."
218         https://bugs.webkit.org/show_bug.cgi?id=193297
219         https://trac.webkit.org/changeset/240446
220
221 2019-01-24  Zalan Bujtas  <zalan@apple.com>
222
223         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
224         https://bugs.webkit.org/show_bug.cgi?id=193741
225         <rdar://problem/47135030>
226
227         Reviewed by Antti Koivisto and Simon Fraser.
228
229         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
230         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
231         (TestWebKitAPI::TEST):
232
233 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
234
235         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
236         https://bugs.webkit.org/show_bug.cgi?id=193297
237         <rdar://problem/47158841>
238
239         Reviewed by Alex Christensen.
240
241         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
242         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
243         activating the message used to trigger the callback when it is set.
244
245 2019-01-24  John Wilander  <wilander@apple.com>
246
247         Add Ad Click Attribution as an internal/experimental feature
248         https://bugs.webkit.org/show_bug.cgi?id=193685
249         <rdar://problem/47450399>
250
251         Reviewed by Brent Fulgham.
252
253         Added test option adClickAttributionEnabled.
254
255         * DumpRenderTree/TestOptions.cpp:
256         (TestOptions::TestOptions):
257         * DumpRenderTree/TestOptions.h:
258         * DumpRenderTree/mac/DumpRenderTree.mm:
259         (setWebPreferencesForTestOptions):
260
261 2019-01-24  Antti Koivisto  <antti@apple.com>
262
263         [PSON] Flash on back navigation on Mac
264         https://bugs.webkit.org/show_bug.cgi?id=193716
265         <rdar://problem/47148458>
266
267         Reviewed by Chris Dumez.
268
269         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
270
271         Closing of the previous page is delayed so waiting for didFinishNavigation is
272         not sufficient to guarantee we have received all the messages. Wait for them.
273
274 2019-01-24  Chris Dumez  <cdumez@apple.com>
275
276         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
277         https://bugs.webkit.org/show_bug.cgi?id=193761
278         <rdar://problem/47456405>
279
280         Reviewed by Alex Christensen.
281
282         Add API test coverage.
283
284         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
285
286 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
287
288         webkitpy: Missing PID in crashlog name should not be fatal
289         https://bugs.webkit.org/show_bug.cgi?id=193771
290
291         If we can't determine the PID of a crashlog, just ignore the crashlog instead
292         of raising an exception.
293
294         Reviewed by Lucas Forschler.
295
296         * Scripts/webkitpy/port/darwin.py:
297         (DarwinPort._merge_crash_logs):
298
299 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
300
301         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
302         https://bugs.webkit.org/show_bug.cgi?id=193746
303
304         Reviewed by Youenn Fablet.
305
306         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
307         so we'd best just not call it.
308
309         * Scripts/webkitpy/w3c/test_exporter.py:
310         (WebPlatformTestExporter.create_branch_with_patch):
311
312 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
313
314         Move FileSystem to WTF
315         https://bugs.webkit.org/show_bug.cgi?id=193602
316
317         Reviewed by Yusuke Suzuki.
318
319         * DumpRenderTree/win/DumpRenderTree.cpp:
320         * TestWebKitAPI/CMakeLists.txt:
321         * TestWebKitAPI/PlatformGTK.cmake:
322         * TestWebKitAPI/PlatformJSCOnly.cmake:
323         * TestWebKitAPI/PlatformPlayStation.cmake:
324         * TestWebKitAPI/PlatformWPE.cmake:
325         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
326         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
327         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
328         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
329         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
330         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
331         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
332         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
333         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
334         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
335
336 2019-01-24  Philippe Normand  <pnormand@igalia.com>
337
338         [WPE] Remove hard dependency on subprocess32 for the API tests
339
340         Rubber-stamped by Carlos Garcia Campos.
341
342         * glib/api_test_runner.py:
343         (TestRunner._run_test_qt): Lazily import subprocess32 and check
344         its presence only when running WPEQt tests.
345
346 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
347
348         [GLIB] Expose JavaScriptCore options in GLib public API
349         https://bugs.webkit.org/show_bug.cgi?id=188742
350
351         Reviewed by Michael Catanzaro.
352
353         Add a test for the new API.
354
355         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
356         (testsJSCOptions):
357         (main):
358
359 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
360
361         [GTK][WPE] Support JPEG 2000 images
362         https://bugs.webkit.org/show_bug.cgi?id=186272
363
364         Reviewed by Žan Doberšek.
365
366         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
367
368         * gtk/jhbuild.modules:
369         * wpe/jhbuild.modules:
370
371 2019-01-23  David Kilzer  <ddkilzer@apple.com>
372
373         check-webkit-style should warn when using soft-linking macros in a header
374         <https://webkit.org/b/193750>
375
376         Reviewed by Darin Adler.
377
378         * Scripts/webkitpy/style/checkers/cpp.py:
379         (check_language): Add softlink/header check by refactoring the
380         softlink/framework check.
381         (CppChecker): Enable softlink/header check by default.
382         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
383         (CppStyleTest.test_softlink_framework): Rename from
384         CppStyleTest.test_softlink() and change test framework name in
385         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
386         files. Set file_name for macros that only appear in headers.
387         (CppStyleTest.test_softlink_header): Add tests for using
388         soft-link macros in headers.
389
390 2019-01-23  Chris Dumez  <cdumez@apple.com>
391
392         Deprecate API to limit the maximum number of WebProcesses
393         https://bugs.webkit.org/show_bug.cgi?id=193725
394         <rdar://problem/47464879>
395
396         Reviewed by Geoff Garen.
397
398         Update existing API tests to stop using deprecated API.
399
400         * MiniBrowser/mac/AppDelegate.m:
401         (defaultConfiguration):
402         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
403         (TestWebKitAPI::TEST):
404         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
405         (TestWebKitAPI::TEST):
406         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
407         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
408         (TEST):
409         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
410         (TEST):
411
412 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
413
414         [ews-app] Rename ews model buildermappings to buildermapping
415         https://bugs.webkit.org/show_bug.cgi?id=193729
416
417         Reviewed by Lucas Forschler.
418
419         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
420         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
421         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
422
423 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
424
425         [ews-app] Rename ews model steps to step
426         https://bugs.webkit.org/show_bug.cgi?id=193697
427
428         Reviewed by Lucas Forschler.
429
430         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
431         (Step): Renamed Steps to Step.
432
433 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
434
435         Clean up IndexedDB files between tests
436         https://bugs.webkit.org/show_bug.cgi?id=192796
437         <rdar://problem/46824999>
438
439         Reviewed by Geoffrey Garen.
440
441         * DumpRenderTree/mac/DumpRenderTree.mm:
442         (runTest):
443         * WebKitTestRunner/TestController.cpp:
444         (WTR::TestController::resetStateToConsistentValues):
445         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
446         (WTR::RemoveAllIndexedDatabasesCallback):
447         (WTR::TestController::ClearIndexedDatabases):
448         * WebKitTestRunner/TestController.h:
449         * WebKitTestRunner/TestInvocation.cpp:
450         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
451
452 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
453
454         [ews-app] Rename ews model Builds to Build
455         https://bugs.webkit.org/show_bug.cgi?id=193695
456
457         Reviewed by Lucas Forschler.
458
459         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
460         (Build): Renamed Builds to Build.
461
462 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
463
464         webkitpy: Wait longer when launching WebKitTestRunner
465         https://bugs.webkit.org/show_bug.cgi?id=193734
466
467         Reviewed by Aakash Jain.
468
469         * Scripts/webkitpy/port/simulator_process.py:
470         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
471
472 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
473
474         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
475         https://bugs.webkit.org/show_bug.cgi?id=193182
476         <rdar://problem/47452154>
477
478         Reviewed by Tim Horton.
479
480         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
481         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
482         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
483
484         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
485         preventing later tests from recognizing gestures.
486
487         * WebKitTestRunner/ios/TestControllerIOS.mm:
488         (WTR::TestController::platformResetStateToConsistentValues):
489
490         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
491
492 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
493
494         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
495         https://bugs.webkit.org/show_bug.cgi?id=193722
496         <rdar://problem/47481475>
497
498         Reviewed by Lucas Forschler.
499
500         iPhone and iPad ports should both use the iOS config.
501
502         * Scripts/webkitpy/port/ios_simulator.py:
503         (IPhoneSimulatorPort.__init__):
504         (IPadSimulatorPort.__init__):
505
506 2019-01-23  Rob Buis  <rbuis@igalia.com>
507
508         Update MIME type parser
509         https://bugs.webkit.org/show_bug.cgi?id=180526
510
511         Reviewed by Frédéric Wang.
512
513         Add unit tests for both parse modes of ParsedContentType.
514
515         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
516         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
517         (TestWebKitAPI::TEST):
518
519 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
520
521         [ews-app] fetch loop should not stop on network issues
522         https://bugs.webkit.org/show_bug.cgi?id=193666
523
524         Reviewed by Lucas Forschler.
525
526         * BuildSlaveSupport/ews-app/ews/fetcher.py:
527         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
528
529 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
530
531         [iOS] Multiple WKWebViewAutofillTests are flaky failures
532         https://bugs.webkit.org/show_bug.cgi?id=189165
533         <rdar://problem/47433765>
534
535         Reviewed by Tim Horton.
536
537         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
538         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
539         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
540         process in sufficient to ensure that any previous action that blurred the focused element in the web process
541         would make its way to the UI process by the time the layer tree commit is finished.
542
543         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
544         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
545         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
546         will fail because it asks for -_autofillContext too early.
547
548         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
549         is handled in the UI process.
550
551         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
552
553         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
554         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
555         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
556         input session.
557
558         (-[AutofillTestView textInputHasAutofillContext]):
559
560         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
561
562         * TestWebKitAPI/cocoa/TestWKWebView.h:
563         * TestWebKitAPI/cocoa/TestWKWebView.mm:
564         (nextInputSessionChangeCount):
565
566         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
567         This includes changing the focused element from one to another.
568
569         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
570         (-[TestWKWebView didStartFormControlInteraction]):
571         (-[TestWKWebView didEndFormControlInteraction]):
572         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
573
574         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
575         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
576         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
577         that doesn't require an input session to one that doesn't.
578
579 2019-01-22  David Kilzer  <ddkilzer@apple.com>
580
581         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
582         <https://webkit.org/b/193676>
583
584         Reviewed by Alexey Proskuryakov.
585
586         * Scripts/webkitpy/style/checkers/cpp.py:
587         (check_member_initialization_list):
588         - Don't report missing whitespace around colon if the colon at
589           the start of the line is formatted correctly.
590         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
591         (WebKitStyleTest.test_member_initialization_list):
592         - Add a test for a missing permutation of existing tests.
593         - Add a test this false-positive.
594         - Add blank lines between subtests to make them easier to read.
595
596 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
597
598         [build.webkit.org] Unit-test failure after r237113
599         https://bugs.webkit.org/show_bug.cgi?id=193669
600
601         Reviewed by Michael Catanzaro.
602
603         * BuildSlaveSupport/build.webkit.org-config/factories.py:
604         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
605         multiple or zero flags.
606
607 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
608
609         Cache bytecode to disk
610         https://bugs.webkit.org/show_bug.cgi?id=192782
611         <rdar://problem/46084932>
612
613         Reviewed by Keith Miller.
614
615         Add test helper to execute bytecode-cache tests: it executes each test
616         twice, the first with JSC_diskCachePath set to a temporary directory
617         and second with JSC_forceDiskCache=true (in addition to the cache path)
618         to guarantee that only the disk cache is being used and no new
619         UnlinkedCodeBlocks are being created.
620
621         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
622         * Scripts/run-jsc-stress-tests:
623
624 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
625
626         [css-logical] Implement flow-relative margin, padding and border shorthands
627         https://bugs.webkit.org/show_bug.cgi?id=188697
628
629         Reviewed by Simon Fraser and Antti Koivisto.
630
631         * DumpRenderTree/TestOptions.cpp:
632         (TestOptions::TestOptions):
633         * DumpRenderTree/TestOptions.h:
634         * DumpRenderTree/mac/DumpRenderTree.mm:
635         (setWebPreferencesForTestOptions):
636         Allow tests to enable the CSSLogicalEnabled flag in WK1.
637
638         * Scripts/webkitpy/style/checkers/jsonchecker.py:
639         (JSONCSSPropertiesChecker.check_codegen_properties):
640         Allow CSS property definitions to have a 'runtime-flag' parameter which
641         disables the property when the specified runtime flag is disabled.
642
643 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
644
645         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
646         https://bugs.webkit.org/show_bug.cgi?id=193643
647
648         Reviewed by Michael Catanzaro.
649
650         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
651         * wpe/jhbuild.modules: Ditto.
652
653 2019-01-21  Zalan Bujtas  <zalan@apple.com>
654
655         [LFC][Floats] Take float top position into account when computing containing block height.
656         https://bugs.webkit.org/show_bug.cgi?id=193655
657
658         Reviewed by Antti Koivisto.
659
660         * LayoutReloaded/misc/LFC-passing-tests.txt:
661
662 2019-01-21  David Kilzer  <ddkilzer@apple.com>
663
664         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
665         <https://webkit.org/b/193645>
666         <rdar://problem/47421574>
667
668         Reviewed by Alex Christensen.
669
670         - Now checks for local soft-linking of all frameworks that have
671           their own *SoftLinking.{cpp,h,mm} files.
672         - Changes softlink/uikit warning to softlink/framework.
673
674         * Scripts/webkitpy/style/checkers/cpp.py:
675         (check_language):
676         (CppChecker):
677         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
678         (CppStyleTest):
679
680 2019-01-20  Saam Barati  <sbarati@apple.com>
681
682         Rollout r240210: It broke tests on iOS
683         https://bugs.webkit.org/show_bug.cgi?id=193640
684
685         Unreviewed.
686
687         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
688         * Scripts/run-jsc-stress-tests:
689
690 2019-01-20  chris fleizach  <cfleizach@apple.com>
691
692         AX: Support returning relative frames for accessibility
693         https://bugs.webkit.org/show_bug.cgi?id=193414
694         <rdar://problem/47268501>
695
696         Reviewed by Zalan Bujtas.
697
698         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
699         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
700         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
701         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
702         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
703         (WTR::attributesOfElement):
704         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
705
706 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
707
708         Unreviewed, add my new email address
709
710         * Scripts/webkitpy/common/config/contributors.json:
711
712 2019-01-19  Zalan Bujtas  <zalan@apple.com>
713
714         [LFC][BFC] <body>'s overflow property value is propagated to viewport
715         https://bugs.webkit.org/show_bug.cgi?id=193617
716
717         Reviewed by Antti Koivisto.
718
719         * LayoutReloaded/misc/LFC-passing-tests.txt:
720
721 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
722
723         Unreviewed, rolling out r240209.
724
725         Broke GTK/WPE injected bundle
726
727         Reverted changeset:
728
729         "AX: Support returning relative frames for accessibility"
730         https://bugs.webkit.org/show_bug.cgi?id=193414
731         https://trac.webkit.org/changeset/240209
732
733 2019-01-12  Dan Bernstein  <mitz@apple.com>
734
735         [Cocoa] Avoid importing directly from subumbrella frameworks
736         https://bugs.webkit.org/show_bug.cgi?id=186016
737         <rdar://problem/40591038>
738
739         Reviewed by Sam Weinig.
740
741         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
742           LaunchServices header.
743         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
744           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
745         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
746           when using SDKs earlier than 10.13.
747         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
748           and OTHER_CPLUSPLUSFLAGS.
749         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
750           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
751         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
752           LaunchServices header.
753
754 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
755
756         Cache bytecode to disk
757         https://bugs.webkit.org/show_bug.cgi?id=192782
758         <rdar://problem/46084932>
759
760         Reviewed by Keith Miller.
761
762         Add test helper to execute bytecode-cache tests: it executes each test
763         twice, the first with JSC_diskCachePath set to a temporary directory
764         and second with JSC_forceDiskCache=true (in addition to the cache path)
765         to guarantee that only the disk cache is being used and no new
766         UnlinkedCodeBlocks are being created.
767
768         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
769         * Scripts/run-jsc-stress-tests:
770
771 2019-01-20  chris fleizach  <cfleizach@apple.com>
772
773         AX: Support returning relative frames for accessibility
774         https://bugs.webkit.org/show_bug.cgi?id=193414
775         <rdar://problem/47268501>
776
777         Reviewed by Zalan Bujtas.
778
779         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
780         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
781         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
782         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
783         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
784         (WTR::attributesOfElement):
785         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
786
787 2019-01-20  Antoine Quint  <graouts@apple.com>
788
789         Add a POINTER_EVENTS feature flag
790         https://bugs.webkit.org/show_bug.cgi?id=193577
791         <rdar://problem/47408511>
792
793         Unreviewed. Also enable Pointer Events for iosmac.
794
795         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
796
797 2019-01-19  Zalan Bujtas  <zalan@apple.com>
798
799         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
800         https://bugs.webkit.org/show_bug.cgi?id=193613
801
802         Reviewed by Antti Koivisto.
803
804         * LayoutReloaded/misc/LFC-passing-tests.txt:
805
806 2019-01-19  Antoine Quint  <graouts@apple.com>
807
808         Add a POINTER_EVENTS feature flag
809         https://bugs.webkit.org/show_bug.cgi?id=193577
810
811         Reviewed by Dean Jackson.
812
813         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
814
815 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
816
817         Disable the run-jsc-stress-test remote host key check [second round].
818         https://bugs.webkit.org/show_bug.cgi?id=192988
819
820         Reviewed by Dewei Zhu.
821
822         * Scripts/run-jsc-stress-tests:
823
824 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
825
826         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
827         https://bugs.webkit.org/show_bug.cgi?id=193597
828
829         Reviewed by Lucas Forschler.
830
831         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
832
833 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
834
835         [build.webkit.org] api tests failures are incorrectly named as unit test failures
836         https://bugs.webkit.org/show_bug.cgi?id=193595
837
838         Reviewed by Lucas Forschler.
839
840         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
841         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
842         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
843
844 2019-01-18  Chris Dumez  <cdumez@apple.com>
845
846         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
847         https://bugs.webkit.org/show_bug.cgi?id=193588
848         <rdar://problem/47131566>
849
850         Reviewed by Alex Christensen.
851
852         Add layout test coverage.
853
854         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
855
856 2019-01-18  Jer Noble  <jer.noble@apple.com>
857
858         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
859         https://bugs.webkit.org/show_bug.cgi?id=189553
860
861         Reviewed by Tim Horton.
862
863         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
864
865         * ContentExtensionTester/Configurations/Base.xcconfig:
866         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
867         * DumpRenderTree/mac/Configurations/Base.xcconfig:
868         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
869         * ImageDiff/cg/Configurations/Base.xcconfig:
870         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
871         * MiniBrowser/Configurations/Base.xcconfig:
872         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
873         * MobileMiniBrowser/Configurations/Base.xcconfig:
874         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
875         * Scripts/webkitpy/style/checker.py:
876         (_all_categories):
877         (FileType):
878         (CheckerDispatcher._file_type):
879         (CheckerDispatcher._create_checker):
880         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
881         (SDKVariantChecker):
882         (SDKVariantChecker.__init__):
883         (SDKVariantChecker.check):
884         * TestWebKitAPI/Configurations/Base.xcconfig:
885         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
886         * WebEditingTester/Configurations/Base.xcconfig:
887         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
888         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
889         * WebKitTestRunner/Configurations/Base.xcconfig:
890         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
891         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
892         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
893
894 2019-01-18  David Kilzer  <ddkilzer@apple.com>
895
896         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
897         <https://webkit.org/b/193568>
898         <rdar://problem/47381130>
899
900         Reviewed by Alex Christensen.
901
902         Make sure no one re-introduces UIKit soft-linking by adding a
903         style rule.
904
905         * Scripts/webkitpy/style/checkers/cpp.py:
906         (check_language): Add softlink/uikit check.
907         (CppChecker): Enable softlink/uikit check.
908         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
909         (CppStyleTest): Add test for softlink/uikit.
910
911 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
912
913         [GTK] install-dependencies tool looks for libunistring-dev for dnf
914         https://bugs.webkit.org/show_bug.cgi?id=193584
915
916         Change "-dev" to "-devel".
917
918         Reviewed by Michael Catanzaro.
919
920         * gtk/install-dependencies:
921
922 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
923
924         webkitpy: Add iPhone and iPad ports
925         https://bugs.webkit.org/show_bug.cgi?id=193537
926         <rdar://problem/47353390>
927
928         Reviewed by Lucas Forschler.
929
930         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
931         ports. Note that this separation is optional, the --ios-simulator command remains.
932
933         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
934         (RunTest.test_device_type_test_division): Drive-by fix.
935         (RunTest.test_device_type_specific_listing): Ditto.
936         (RunTest.test_ipad_test_division):
937         (RunTest):
938         (RunTest.test_ipad_listing):
939         * Scripts/webkitpy/port/factory.py:
940         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
941         (PortFactory):
942         * Scripts/webkitpy/port/ios_simulator.py:
943         (IPhoneSimulatorPort):
944         (IPadSimulatorPort):
945
946 2019-01-18  Chris Dumez  <cdumez@apple.com>
947
948         Regression(PSON) Scroll position is not always restored properly when navigating back
949         https://bugs.webkit.org/show_bug.cgi?id=193578
950         <rdar://problem/47386331>
951
952         Reviewed by Tim Horton.
953
954         Add API test coverage.
955
956         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
957
958 2019-01-18  Youenn Fablet  <youenn@apple.com>
959
960         Add a new SPI to request for cache storage quota increase
961         https://bugs.webkit.org/show_bug.cgi?id=193323
962
963         Reviewed by Alex Christensen.
964
965         Implement WebsiteDataStore quota delegate to handle quota requests.
966         By default, do not update quota.
967         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
968
969         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
970         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
971         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
972         * WebKitTestRunner/InjectedBundle/TestRunner.h:
973         * WebKitTestRunner/TestController.cpp:
974         (WTR::TestController::allowCacheStorageQuotaIncrease):
975         * WebKitTestRunner/TestController.h:
976         * WebKitTestRunner/TestInvocation.cpp:
977         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
978         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
979         (-[CacheStorageQuotaManager init]):
980         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
981         (WTR::initializeWebViewConfiguration):
982         (WTR::TestController::cocoaResetStateToConsistentValues):
983         (WTR::TestController::allowCacheStorageQuotaIncrease):
984
985 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
986
987         [ews-build] Pass owner to the triggered builds
988         https://bugs.webkit.org/show_bug.cgi?id=193574
989
990         Reviewed by Lucas Forschler.
991
992         * BuildSlaveSupport/ews-build/factories.py:
993         (BuildFactory.propertiesToPassToTriggers):
994
995 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
996
997         [ews-app] Send patch author as a build property
998         https://bugs.webkit.org/show_bug.cgi?id=193560
999
1000         Reviewed by Lucas Forschler.
1001
1002         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1003         (BugzillaPatchFetcher.fetch):
1004
1005 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1006
1007         webkitpy: Implement device type specific expected results (Follow-up fix)
1008         https://bugs.webkit.org/show_bug.cgi?id=192162
1009         <rdar://problem/46345449>
1010
1011         Unreviewed infrastructure fix.
1012
1013         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1014         (Manager.run): Don't boot a device if no tests are available to run on it.
1015
1016 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1017
1018         webkitpy: Implement device type specific expected results (Follow-up fix)
1019         https://bugs.webkit.org/show_bug.cgi?id=192162
1020         <rdar://problem/46345449>
1021
1022         Unreviewed infrastructure fix.
1023
1024         * Scripts/webkitpy/api_tests/manager.py:
1025         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
1026
1027 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1028
1029         webkitpy: Implement device type specific expected results (Part 2)
1030         https://bugs.webkit.org/show_bug.cgi?id=192162
1031         <rdar://problem/46345449>
1032
1033         Rubber-stamped by Aakash Jain.
1034
1035         This change uses device_type to select a different set of TestExpectation files based on the type of device running
1036         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
1037         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
1038
1039         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1040         (LayoutTestFinder.find_tests): Pass device_type through.
1041         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
1042         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
1043         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1044         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
1045         (Manager._collect_tests): Pass device type to test finder.
1046         (Manager._needs_web_platform_test):
1047         (Manager._prepare_lists): Index _expectations by device type.
1048         (Manager._test_input_for_file):
1049         (Manager._test_is_slow): Ditto.
1050         (Manager._test_should_dump_jsconsolelog_in_stderr):
1051         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
1052         (Manager._get_test_inputs):
1053         (Manager._update_worker_count):
1054         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
1055         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
1056         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
1057         the one which runs the test.
1058         (Manager._run_test_subset):
1059         (Manager._run_tests): Index _expectations by current_device_type.
1060         (Manager._print_expectation_line_for_test): Ditto.
1061         (Manager._print_expectations_for_subset): Ditto.
1062         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
1063         Unlike run, this function will behave the same regardless of what devices are available.
1064         (Manager._custom_device_for_test): Deleted.
1065         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1066         (ManagerTest.test_uses_custom_device): Deleted.
1067         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
1068         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1069         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
1070         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
1071         all of the expectations.
1072         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1073         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
1074         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1075         (TestExpectations.__init__): Allow device_type to be passed through.
1076         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
1077         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
1078         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1079         (summarize_results):
1080         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1081         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
1082         a test ran with, one must check all expectations to find the first non-skip expectation.
1083         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1084         (RunTest.test_device_type_test_division):
1085         (RunTest):
1086         (RunTest.test_device_type_specific_listing):
1087         * Scripts/webkitpy/port/base.py:
1088         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
1089         (Port.supported_device_types): The result of this function will change based on what devices are available.
1090         * Scripts/webkitpy/port/device_port.py:
1091         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1092         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1093         can be used.
1094         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1095         any, or the DEFAULT_DEVICE_TYPES of the port.
1096         * Scripts/webkitpy/port/ios.py:
1097         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1098         * Scripts/webkitpy/port/ios_simulator.py:
1099         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1100         * Scripts/webkitpy/port/watch.py:
1101         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1102         * Scripts/webkitpy/port/watch_simulator.py:
1103         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1104         * Scripts/webkitpy/xcode/device_type.py:
1105         (DeviceType):
1106         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1107
1108 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1109
1110         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1111         https://bugs.webkit.org/show_bug.cgi?id=193575
1112
1113         Reviewed by Michael Catanzaro.
1114
1115         Allow the script to run without explicit port argument because
1116         it's specific to the WPE port anyway.
1117
1118         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1119         and simplify the rest of the code accordingly.
1120
1121 2019-01-18  Charlie Turner  <cturner@igalia.com>
1122
1123         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1124         https://bugs.webkit.org/show_bug.cgi?id=192229
1125
1126         Reviewed by Xabier Rodriguez-Calvar.
1127
1128         * MiniBrowser/wpe/main.cpp:
1129         (main): Enable encrypted-media by default.
1130
1131 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1132
1133         [Flatpak] Missing KeyboardInterrupt exception handler
1134         https://bugs.webkit.org/show_bug.cgi?id=193570
1135
1136         Reviewed by Michael Catanzaro.
1137
1138         * flatpak/flatpakutils.py:
1139         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1140
1141 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1142
1143         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1144         https://bugs.webkit.org/show_bug.cgi?id=193564
1145
1146         Reviewed by Antti Koivisto.
1147
1148         * LayoutReloaded/misc/LFC-passing-tests.txt:
1149
1150 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1151
1152         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1153         https://bugs.webkit.org/show_bug.cgi?id=193562
1154
1155         Reviewed by Antti Koivisto.
1156
1157         * LayoutReloaded/misc/LFC-passing-tests.txt:
1158
1159 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1160
1161         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1162         https://bugs.webkit.org/show_bug.cgi?id=193555
1163
1164         Reviewed by Antti Koivisto.
1165
1166         * LayoutReloaded/misc/LFC-passing-tests.txt:
1167
1168 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1169
1170         [WPE] Add Qt extension
1171         https://bugs.webkit.org/show_bug.cgi?id=191464
1172
1173         Reviewed by Carlos Garcia Campos.
1174
1175         MiniBrowser and API tests for the WPE Qt API. To run the
1176         MiniBrowser a new script is introduced. Example invocation:
1177
1178         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1179
1180         Also note-worthy is the introduction of the python2-subprocess32
1181         dependency to run the GLib API tests.
1182
1183         * MiniBrowser/wpe/CMakeLists.txt:
1184         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1185         * MiniBrowser/wpe/qt/main.cpp: Added.
1186         (main):
1187         * MiniBrowser/wpe/qt/main.qml: Added.
1188         * MiniBrowser/wpe/qt/qml.qrc: Added.
1189         * Scripts/run-gtk-tests:
1190         (GtkTestRunner.is_google_test):
1191         (GtkTestRunner):
1192         (GtkTestRunner.is_qt_test):
1193         * Scripts/run-qt-wpe-minibrowser: Added.
1194         * Scripts/run-wpe-tests:
1195         (WPETestRunner):
1196         (WPETestRunner.is_google_test):
1197         (WPETestRunner.is_qt_test):
1198         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1199         (TestLoad::main):
1200         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1201         (TestLoadHtml::main):
1202         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1203         (TestLoadRequest::main):
1204         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1205         (TestRunJavaScript::main):
1206         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1207         (waitForSignal):
1208         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1209         (LoadSpy::LoadSpy):
1210         (LoadSpy::~LoadSpy):
1211         (LoadSpy::onLoadingChanged):
1212         (LoadStartedCatcher::LoadStartedCatcher):
1213         (LoadStartedCatcher::~LoadStartedCatcher):
1214         (LoadStartedCatcher::onLoadingChanged):
1215         (waitForLoadSucceeded):
1216         (waitForLoadFailed):
1217         * TestWebKitAPI/glib/CMakeLists.txt:
1218         * flatpak/flatpakutils.py:
1219         (WebkitFlatpak.load_from_args):
1220         (WebkitFlatpak.__init__):
1221         (WebkitFlatpak.clean_args):
1222         (WebkitFlatpak.run_in_sandbox):
1223         * flatpak/org.webkit.CommonModules.yaml:
1224         * flatpak/org.webkit.WPE.yaml:
1225         * flatpak/org.webkit.WPEModules.yaml:
1226         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1227         * flatpak/org.webkit.WebKit.yaml:
1228         * glib/api_test_runner.py:
1229         (TestRunner._run_test_qt):
1230         (TestRunner.is_qt_test):
1231         (TestRunner._run_test):
1232
1233 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1234
1235         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1236         https://bugs.webkit.org/show_bug.cgi?id=193494
1237         <rdar://problem/46859627>
1238
1239         Reviewed by Simon Fraser and Tim Horton.
1240
1241         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1242         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1243
1244         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1245         (WTR::UIScriptController::contentOffsetX const):
1246         (WTR::UIScriptController::contentOffsetY const):
1247         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1248         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1249         (WTR::UIScriptController::contentOffsetX const):
1250         (WTR::UIScriptController::contentOffsetY const):
1251         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1252
1253         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1254
1255         * WebKitTestRunner/TestController.cpp:
1256         (WTR::updateTestOptionsFromTestHeader):
1257         * WebKitTestRunner/TestOptions.h:
1258         (WTR::TestOptions::hasSameInitializationOptions const):
1259         * WebKitTestRunner/ios/TestControllerIOS.mm:
1260         (WTR::TestController::platformResetStateToConsistentValues):
1261         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1262         (WTR::UIScriptController::contentOffsetX const):
1263         (WTR::UIScriptController::contentOffsetY const):
1264
1265 2019-01-17  Truitt Savell  <tsavell@apple.com>
1266
1267         Unreviewed, rolling out r240124.
1268
1269         This commit broke an internal build.
1270
1271         Reverted changeset:
1272
1273         "SDK_VARIANT build destinations should be separate from non-
1274         SDK_VARIANT builds"
1275         https://bugs.webkit.org/show_bug.cgi?id=189553
1276         https://trac.webkit.org/changeset/240124
1277
1278 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1279
1280         Fix string concatenation API test after r239920
1281         https://bugs.webkit.org/show_bug.cgi?id=193551
1282         <rdar://problem/47359304>
1283
1284         Reviewed by Youenn Fablet.
1285
1286         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1287         (TestWebKitAPI::TEST):
1288         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1289         in WebKit's build configuration like it apparently is on Linux.
1290
1291 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1292
1293         [ews-build] validate-patch should handle the case when bug_id is None
1294         https://bugs.webkit.org/show_bug.cgi?id=193547
1295
1296         Reviewed by Lucas Forschler.
1297
1298         * BuildSlaveSupport/ews-build/steps.py:
1299         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1300         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1301
1302 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1303
1304         [ews-build] Add patch author information in build
1305         https://bugs.webkit.org/show_bug.cgi?id=193465
1306
1307         Reviewed by Lucas Forschler.
1308
1309         * BuildSlaveSupport/ews-build/steps.py:
1310         (ValidatePatch._is_patch_obsolete):
1311
1312 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1313
1314         [ews-build] Pass bug_id to the triggered builds
1315         https://bugs.webkit.org/show_bug.cgi?id=193548
1316
1317         Reviewed by Lucas Forschler.
1318
1319         * BuildSlaveSupport/ews-build/factories.py:
1320         (BuildFactory.propertiesToPassToTriggers):
1321
1322 2019-01-17  Jer Noble  <jer.noble@apple.com>
1323
1324         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1325         https://bugs.webkit.org/show_bug.cgi?id=189553
1326
1327         Reviewed by Tim Horton.
1328
1329         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1330
1331         * ContentExtensionTester/Configurations/Base.xcconfig:
1332         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1333         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1334         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1335         * ImageDiff/cg/Configurations/Base.xcconfig:
1336         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1337         * MiniBrowser/Configurations/Base.xcconfig:
1338         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1339         * MobileMiniBrowser/Configurations/Base.xcconfig:
1340         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1341         * Scripts/webkitpy/style/checker.py:
1342         (_all_categories):
1343         (FileType):
1344         (CheckerDispatcher._file_type):
1345         (CheckerDispatcher._create_checker):
1346         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1347         (SDKVariantChecker):
1348         (SDKVariantChecker.__init__):
1349         (SDKVariantChecker.check):
1350         * TestWebKitAPI/Configurations/Base.xcconfig:
1351         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1352         * WebEditingTester/Configurations/Base.xcconfig:
1353         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1354         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1355         * WebKitTestRunner/Configurations/Base.xcconfig:
1356         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1357         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1358         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1359
1360 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1361
1362         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1363         https://bugs.webkit.org/show_bug.cgi?id=193534
1364
1365         Reviewed by Antti Koivisto.
1366
1367         * LayoutReloaded/misc/LFC-passing-tests.txt:
1368
1369 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1370
1371         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1372         https://bugs.webkit.org/show_bug.cgi?id=193528
1373
1374         Reviewed by Antti Koivisto.
1375
1376         * LayoutReloaded/misc/LFC-passing-tests.txt:
1377
1378 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1379
1380         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1381         https://bugs.webkit.org/show_bug.cgi?id=193520
1382
1383         Reviewed by Antti Koivisto.
1384
1385         * LayoutReloaded/misc/LFC-passing-tests.txt:
1386
1387 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1388
1389         [ews-build] unapply-patch step should not update source
1390         https://bugs.webkit.org/show_bug.cgi?id=193234
1391
1392         Reviewed by Lucas Forschler.
1393
1394         * BuildSlaveSupport/ews-build/steps.py:
1395         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1396         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1397
1398 2019-01-16  Youenn Fablet  <youenn@apple.com>
1399
1400         Add a new SPI for controlling getUserMedia
1401         https://bugs.webkit.org/show_bug.cgi?id=192793
1402
1403         Reviewed by Eric Carlson.
1404
1405         * MiniBrowser/mac/WK2BrowserWindowController.m:
1406         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1407         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1408         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1409         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1410         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1411         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1412         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1413         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1414         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1415         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1416         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1417         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1418         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1419         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1420
1421 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1422
1423         [LFC][BFC] Inflow non-replaced used width should not be negative.
1424         https://bugs.webkit.org/show_bug.cgi?id=193495
1425
1426         Reviewed by Antti Koivisto.
1427
1428         * LayoutReloaded/misc/LFC-passing-tests.txt:
1429
1430 2019-01-16  Chris Dumez  <cdumez@apple.com>
1431
1432         Regression(PSON) View becomes blank after click a cross-site download link
1433         https://bugs.webkit.org/show_bug.cgi?id=193361
1434         <rdar://problem/47099573>
1435
1436         Reviewed by Geoffrey Garen.
1437
1438         Add API test coverage.
1439
1440         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1441         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1442
1443 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1444
1445         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1446         https://bugs.webkit.org/show_bug.cgi?id=193470
1447
1448         Reviewed by Antti Koivisto.
1449
1450         * LayoutReloaded/misc/LFC-passing-tests.txt:
1451
1452 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1453
1454         [LFC] Adjust margin box verification.
1455         https://bugs.webkit.org/show_bug.cgi?id=193482
1456
1457         Reviewed by Antti Koivisto.
1458
1459         * LayoutReloaded/misc/LFC-passing-tests.txt:
1460
1461 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1462
1463         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1464         https://bugs.webkit.org/show_bug.cgi?id=193451
1465
1466         Reviewed by Geoffrey Garen.
1467
1468         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1469         (TEST):
1470         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1471         (runWebsiteDataStoreCustomPaths):
1472
1473 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1474
1475         webkitpy: Support boolean simctl isAvailable
1476         https://bugs.webkit.org/show_bug.cgi?id=193472
1477         <rdar://problem/47296150>
1478
1479         Reviewed by Ryosuke Niwa.
1480
1481         * Scripts/webkitpy/xcode/simulated_device.py:
1482         (SimulatedDeviceManager._create_runtimes):
1483         (SimulatedDeviceManager._create_device_with_runtime):
1484
1485 2019-01-15  Chris Dumez  <cdumez@apple.com>
1486
1487         Unreviewed, rolling out r239993, r239995, r239997, and
1488         r239999.
1489
1490         Caused assertions under
1491         ViewGestureController::disconnectFromProcess()
1492
1493         Reverted changesets:
1494
1495         "Regression(PSON) View becomes blank after click a cross-site
1496         download link"
1497         https://bugs.webkit.org/show_bug.cgi?id=193361
1498         https://trac.webkit.org/changeset/239993
1499
1500         "Unreviewed iOS build fix after r239993."
1501         https://trac.webkit.org/changeset/239995
1502
1503         "Fix iOS build after r239993"
1504         https://bugs.webkit.org/show_bug.cgi?id=193361
1505         https://trac.webkit.org/changeset/239997
1506
1507         "Unreviewed, revert part of r239997 as it is not needed to fix
1508         the build."
1509         https://trac.webkit.org/changeset/239999
1510
1511 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1512
1513         Cannot tab out of WKWebView on macOS
1514         https://bugs.webkit.org/show_bug.cgi?id=161448
1515         <rdar://problem/28100085>
1516
1517         Reviewed by Dean Jackson.
1518
1519         Add a test that tabbing into and out of WKWebView works correctly.
1520
1521         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1522         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1523         (WebKit2_CommandBackForwardTest::SetUp):
1524         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1525         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1526         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1527         (-[FocusableView canBecomeKeyView]):
1528         (TEST):
1529         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1530         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1531         (-[OffscreenWindow initWithSize:]):
1532         (-[OffscreenWindow isKeyWindow]):
1533         (-[OffscreenWindow isVisible]):
1534         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1535         (TestWebKitAPI::PlatformWebView::initialize):
1536         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1537         (-[ActiveOffscreenWindow isVisible]): Deleted.
1538         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1539
1540 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1541
1542         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1543         https://bugs.webkit.org/show_bug.cgi?id=193459
1544
1545         Reviewed by Mark Lam.
1546
1547         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1548         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1549
1550 2019-01-15  Chris Dumez  <cdumez@apple.com>
1551
1552         Regression(PSON) View becomes blank after click a cross-site download link
1553         https://bugs.webkit.org/show_bug.cgi?id=193361
1554         <rdar://problem/47099573>
1555
1556         Reviewed by Geoff Garen.
1557
1558         Add API test coverage.
1559
1560         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1561         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1562
1563 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1564
1565         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
1566         https://bugs.webkit.org/show_bug.cgi?id=193448
1567
1568         Reviewed by Antti Koivisto.
1569
1570         * LayoutReloaded/misc/LFC-passing-tests.txt:
1571
1572 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1573
1574         webkitpy: Implement device type specific expected results (Part 1)
1575         https://bugs.webkit.org/show_bug.cgi?id=192162
1576
1577         Reviewed by Lucas Forschler.
1578
1579         Device type specific expected results covers two related ideas. The first (covered by this change)
1580         is where to search for -expected.* files. The second is which tests to run based on the
1581         TestExpectations.txt file.
1582
1583         After this change, the baseline search path will be determined by the type of device running a
1584         test. Device type will be passed into any function which picks a file based on the baseline search
1585         path.
1586
1587         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1588         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
1589         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1590         (Manager.run): Print baseline search path for each round of devices.
1591         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1592         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
1593         (SingleTestRunner._expected_driver_output): Ditto.
1594         (SingleTestRunner._driver_input): Ditto.
1595         * Scripts/webkitpy/layout_tests/views/printing.py:
1596         (Printer.print_config): Move printing of baseline search path to a separate function.
1597         (Printer.print_baseline_search_path): Moved from Printer.print_config.
1598         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1599         (Testprinter.test_print_config):
1600         (Testprinter.test_print_baseline_search_path):
1601         * Scripts/webkitpy/port/base.py:
1602         (Port.baseline_search_path): Pass device_type through.
1603         (Port._expected_baselines_for_suffixes): Ditto.
1604         (Port.expected_baselines): Ditto.
1605         (Port.expected_filename): Ditto.
1606         (Port.expected_checksum): Ditto.
1607         (Port.expected_image): Ditto.
1608         (Port.expected_audio): Ditto.
1609         (Port.expected_text): Ditto.
1610         (Port.reference_files): Ditto.
1611         (Port.tests): Ditto.
1612         (Port._expanded_paths): Ditto.
1613         (Port.skipped_layout_tests): Ditto.
1614         (Port.expectations_dict): Ditto.
1615         (Port._port_specific_expectations_files): Ditto.
1616         (Port.expectations_files): Ditto.
1617         (Port.test_search_path): Ditto.
1618         (Port._tests_for_other_platforms): Ditto.
1619         * Scripts/webkitpy/port/base_unittest.py:
1620         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
1621         (PortTest.test_nonexistant_expectations): Ditto.
1622         (test_ref_tests_platform_directory): Ditto.
1623         * Scripts/webkitpy/port/darwin.py:
1624         (DarwinPort._port_specific_expectations_files): Accept device_type.
1625         * Scripts/webkitpy/port/driver.py:
1626         (DriverProxy):
1627         (DriverProxy.host): Expose _target_host for device_type information.
1628         * Scripts/webkitpy/port/gtk.py:
1629         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
1630         * Scripts/webkitpy/port/ios.py:
1631         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1632         * Scripts/webkitpy/port/mac.py:
1633         (MacPort. default_baseline_search_path): Ditto.
1634         * Scripts/webkitpy/port/port_testcase.py:
1635         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
1636         * Scripts/webkitpy/port/test.py:
1637         * Scripts/webkitpy/port/watch.py:
1638         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1639         * Scripts/webkitpy/port/win.py:
1640         (WinPort.test_search_path): Accept, but do not use, device_type.
1641         * Scripts/webkitpy/port/wpe.py:
1642         (WPEPort._port_specific_expectations_files): Ditto.
1643         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1644         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
1645
1646 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1647
1648         [LFC] Use the containing block's padding box to position out-of-flow elements.
1649         https://bugs.webkit.org/show_bug.cgi?id=193431
1650
1651         Reviewed by Antti Koivisto.
1652
1653         * LayoutReloaded/misc/LFC-passing-tests.txt:
1654
1655 2019-01-14  Tim Horton  <timothy_horton@apple.com>
1656
1657         Move a test implementation file that got misplaced in the Xcode project
1658
1659         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1660
1661 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1662
1663         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1664         r239913, and r239914.
1665         https://bugs.webkit.org/show_bug.cgi?id=193407
1666
1667         These revisions caused an internal failure (Requested by
1668         Truitt on #webkit).
1669
1670         Reverted changesets:
1671
1672         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1673         https://bugs.webkit.org/show_bug.cgi?id=186016
1674         https://trac.webkit.org/changeset/239901
1675
1676         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1677         https://trac.webkit.org/changeset/239909
1678
1679         "Tried to fix the build."
1680         https://trac.webkit.org/changeset/239910
1681
1682         "Fixed iOS builds after r239910."
1683         https://trac.webkit.org/changeset/239912
1684
1685         "More build fixing."
1686         https://trac.webkit.org/changeset/239913
1687
1688         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1689         https://trac.webkit.org/changeset/239914
1690
1691 2019-01-14  Mark Lam  <mark.lam@apple.com>
1692
1693         Re-enable ability to build --cloop builds.
1694         https://bugs.webkit.org/show_bug.cgi?id=192955
1695         <rdar://problem/46882363>
1696
1697         Reviewed by Saam barati and Keith Miller.
1698
1699         The --cloop build option was being ignored this whole time since r236381.
1700         This patch makes it possible to build CLoop builds again.
1701
1702         * Scripts/build-jsc:
1703         * Scripts/webkitperl/FeatureList.pm:
1704         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1705
1706 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1707
1708         webkitpy: Expose device_type from host-like objects
1709         https://bugs.webkit.org/show_bug.cgi?id=193406
1710         <rdar://problem/47262305>
1711
1712         Reviewed by Lucas Forschler.
1713
1714         Devices should expose device_type. As a result, all host objects should
1715         provide a device_type property, even if they do not yet define a device_type.
1716
1717         * Scripts/webkitpy/common/system/systemhost.py:
1718         (SystemHost):
1719         (SystemHost.device_type):
1720         * Scripts/webkitpy/common/system/systemhost_mock.py:
1721         (MockSystemHost):
1722         (MockSystemHost.device_type):
1723         * Scripts/webkitpy/port/device.py:
1724         (Device):
1725         (Device.device_type):
1726         * Scripts/webkitpy/xcode/simulated_device.py:
1727         (SimulatedDeviceManager._find_exisiting_device_for_request):
1728         (SimulatedDeviceManager._disambiguate_device_type):
1729         (SimulatedDeviceManager._does_fulfill_request):
1730         (SimulatedDeviceManager.device_count_for_type):
1731         (SimulatedDeviceManager.initialize_devices):
1732         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1733         (test_available_devices):
1734         (test_swapping_devices):
1735
1736 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1737
1738         webkitpy: Support alternate simctl device list output (Follow-up fix)
1739         https://bugs.webkit.org/show_bug.cgi?id=193362
1740         <rdar://problem/47122965>
1741
1742         Rubber-stamped by Lucas Forschler.
1743
1744         * Scripts/webkitpy/xcode/simulated_device.py:
1745         (SimulatedDeviceManager.populate_available_devices):
1746
1747 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1748
1749         [iOS] Expose SPI to access the current sentence boundary and selection state
1750         https://bugs.webkit.org/show_bug.cgi?id=193398
1751         <rdar://problem/45893108>
1752
1753         Reviewed by Dean Jackson.
1754
1755         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
1756         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
1757         expected.
1758
1759         * TestWebKitAPI/EditingTestHarness.h:
1760         * TestWebKitAPI/EditingTestHarness.mm:
1761         (-[EditingTestHarness moveBackward]):
1762         (-[EditingTestHarness moveForward]):
1763         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
1764
1765         Add a couple of new helper methods on EditingTestHarness.
1766
1767         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1768         (-[SelectionChangeObserver initWithWebView:]):
1769         (-[SelectionChangeObserver webView]):
1770         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
1771         (-[SelectionChangeObserver currentSelectionAttributes]):
1772
1773 2019-01-14  Zalan Bujtas  <zalan@apple.com>
1774
1775         [LFC][BFC] Add basic box-sizing support.
1776         https://bugs.webkit.org/show_bug.cgi?id=193392
1777
1778         Reviewed by Antti Koivisto.
1779
1780         * LayoutReloaded/misc/LFC-passing-tests.txt:
1781
1782 2019-01-14  Charlie Turner  <cturner@igalia.com>
1783
1784         [WPE] API test gardening
1785         https://bugs.webkit.org/show_bug.cgi?id=193319
1786
1787         Reviewed by Michael Catanzaro.
1788
1789         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
1790         passing tests.
1791
1792 2019-01-14  Charlie Turner  <cturner@igalia.com>
1793
1794         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
1795         https://bugs.webkit.org/show_bug.cgi?id=192977
1796
1797         Reviewed by Carlos Garcia Campos.
1798
1799         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
1800         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1801         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
1802         (TestWebKitAPI::GStreamerTest::SetUp):
1803         (TestWebKitAPI::GStreamerTest::TearDown):
1804         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
1805         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
1806         (TestWebKitAPI::TEST_F):
1807
1808 2019-01-14  Charlie Turner  <cturner@igalia.com>
1809
1810         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
1811         https://bugs.webkit.org/show_bug.cgi?id=193332
1812
1813         Reviewed by Michael Catanzaro.
1814
1815         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
1816         defined as a char16_t, which changed in ICU 59, the
1817         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
1818         unsigned short. This test is relying on the behaviour that
1819         UChar=unsigned short, which doesn't hold across platforms and ICU
1820         library versions. The full fix would be a special syntax for
1821         literal characters so that these ambiguities do not arise. That
1822         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
1823         (TestWebKitAPI::TEST):
1824
1825 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1826
1827         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
1828
1829         * Scripts/make-dist:
1830         (Distcheck.configure):
1831
1832 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
1833
1834         [ews-build] Update macOS queue configurations
1835         https://bugs.webkit.org/show_bug.cgi?id=193365
1836         <rdar://problem/47221073>
1837
1838         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
1839
1840         * BuildSlaveSupport/ews-build/config.json:
1841
1842 2019-01-13  Zalan Bujtas  <zalan@apple.com>
1843
1844         [LFC] Adjust assert for statically positioned fixed elements
1845         https://bugs.webkit.org/show_bug.cgi?id=193385
1846
1847         Reviewed by Antti Koivisto.
1848
1849         * LayoutReloaded/misc/LFC-passing-tests.txt:
1850
1851 2019-01-13  Philippe Normand  <pnormand@igalia.com>
1852
1853         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
1854         https://bugs.webkit.org/show_bug.cgi?id=193387
1855
1856         Reviewed by Carlos Garcia Campos.
1857
1858         * MiniBrowser/wpe/main.cpp:
1859         (main):
1860
1861 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1862
1863         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1864         https://bugs.webkit.org/show_bug.cgi?id=191655
1865         rdar://problem/46074680
1866
1867         Reviewed by Megan Gardner.
1868
1869         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1870         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1871
1872 2019-01-12  Dan Bernstein  <mitz@apple.com>
1873
1874         [Cocoa] Avoid importing directly from subumbrella frameworks
1875         https://bugs.webkit.org/show_bug.cgi?id=186016
1876         <rdar://problem/40591038>
1877
1878         Reviewed by Sam Weinig.
1879
1880         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1881           LaunchServices header.
1882         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1883           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1884         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1885           when using SDKs earlier than 10.13.
1886         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1887           and OTHER_CPLUSPLUSFLAGS.
1888         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1889           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1890         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1891           LaunchServices header.
1892
1893 2019-01-11  John Wilander  <wilander@apple.com>
1894
1895         Compile out Web API Statistics Collection
1896         https://bugs.webkit.org/show_bug.cgi?id=193370
1897         <rdar://problem/45388584>
1898
1899         Reviewed by Brent Fulgham.
1900
1901         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1902             Defined ENABLE_WEB_API_STATISTICS, off by default.
1903
1904 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1905
1906         [WPE] Add gtk-doc
1907         https://bugs.webkit.org/show_bug.cgi?id=178900
1908
1909         Reviewed by Michael Catanzaro.
1910
1911         Add Tools/gtkdoc to manifest.txt.in files.
1912         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
1913
1914         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
1915         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
1916
1917 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1918
1919         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
1920         https://bugs.webkit.org/show_bug.cgi?id=193364
1921         <rdar://problem/47214117>
1922
1923         Reviewed by Tim Horton.
1924
1925         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
1926         precise, whereas dragging near the middle of the textarea does.
1927
1928         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1929         (TestWebKitAPI::TEST):
1930
1931 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1932
1933         webkitpy: Support alternate simctl device list output
1934         https://bugs.webkit.org/show_bug.cgi?id=193362
1935         <rdar://problem/47122965>
1936
1937         Reviewed by Lucas Forschler.
1938
1939         * Scripts/webkitpy/xcode/simulated_device.py:
1940         (SimulatedDeviceManager.populate_available_devices):
1941
1942 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
1943
1944         [ews-build] Update macOS queue configurations
1945         https://bugs.webkit.org/show_bug.cgi?id=193365
1946
1947         Reviewed by Lucas Forschler.
1948
1949         * BuildSlaveSupport/ews-build/config.json:
1950
1951 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1952
1953         webkitpy: Incorporate device type into baseline search path
1954         https://bugs.webkit.org/show_bug.cgi?id=193356
1955         <rdar://problem/47215515>
1956
1957         Reviewed by Lucas Forschler.
1958
1959         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
1960
1961         * Scripts/webkitpy/port/base.py:
1962         (Port.default_baseline_search_path): Allow device type to be passed in.
1963         * Scripts/webkitpy/port/gtk.py:
1964         (GtkPort.default_baseline_search_path): Ignore device type.
1965         * Scripts/webkitpy/port/ios.py:
1966         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
1967         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
1968         * Scripts/webkitpy/port/ios_device_unittest.py:
1969         (IOSDeviceTest):
1970         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1971         (IOSSimulatorTest):
1972         * Scripts/webkitpy/port/mac.py:
1973         (MacPort.default_baseline_search_path): Ignore device type.
1974         * Scripts/webkitpy/port/watch.py:
1975         (WatchPort.default_baseline_search_path): Ditto.
1976         * Scripts/webkitpy/port/win.py:
1977         (WinPort.default_baseline_search_path): Ditto.
1978         (WinCairoPort.default_baseline_search_path): Ditto.
1979         * Scripts/webkitpy/port/wpe.py:
1980         (WPEPort.default_baseline_search_path): Ditto.
1981
1982 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1983
1984         webkitpy: Print abbreviated baseline search path that includes only folders that exist
1985         https://bugs.webkit.org/show_bug.cgi?id=193352
1986         <rdar://problem/47210736>
1987
1988         Reviewed by Lucas Forschler.
1989
1990         * Scripts/webkitpy/layout_tests/views/printing.py:
1991         (Printer.print_config): Print list on only baseline search paths which exist. 
1992         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1993         (Testprinter.test_print_config):
1994
1995 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
1996
1997         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
1998         https://bugs.webkit.org/show_bug.cgi?id=193340
1999
2000         Reviewed by David Kilzer.
2001
2002         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2003         (WTR::InjectedBundle::didReceiveMessageToPage):
2004         Pull the strings out into a WKRetainPtr.
2005
2006         * WebKitTestRunner/WebNotificationProvider.cpp:
2007         (WTR::WebNotificationProvider::closeWebNotification):
2008         Adopt the created value into the WKRetainPtr.
2009
2010         * WebKitTestRunner/mac/TestControllerMac.mm:
2011         (WTR::generateWhitelist):
2012         Immediately adopt a created value to avoid potential mistakes.
2013
2014 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
2015
2016         Enable DFG on ARM/Linux again
2017         https://bugs.webkit.org/show_bug.cgi?id=192496
2018
2019         Reviewed by Yusuke Suzuki.
2020
2021         After changing the bytecode format DFG was disabled on all 32-bit
2022         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2023         on ARM by default.
2024
2025         * Scripts/run-jsc-stress-tests:
2026
2027 2019-01-11  Timothy Hatcher  <timothy@apple.com>
2028
2029         Unreviewed, fix #ifdef in API test added in r239851.
2030         https://bugs.webkit.org/show_bug.cgi?id=193327
2031         rdar://problem/47093222
2032
2033         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
2034
2035 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2036
2037         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
2038         https://bugs.webkit.org/show_bug.cgi?id=193109
2039         <rdar://problem/44807048>
2040
2041         Reviewed by Ryosuke Niwa.
2042
2043         Introduce and respect a test option to enable the UndoManager API.
2044
2045         * WebKitTestRunner/TestController.cpp:
2046         (WTR::updateTestOptionsFromTestHeader):
2047         * WebKitTestRunner/TestOptions.h:
2048         (WTR::TestOptions::hasSameInitializationOptions const):
2049         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2050         (WTR::TestController::platformCreateWebView):
2051
2052 2019-01-11  Zalan Bujtas  <zalan@apple.com>
2053
2054         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
2055         https://bugs.webkit.org/show_bug.cgi?id=193346
2056
2057         Reviewed by Antti Koivisto.
2058
2059         * LayoutReloaded/misc/LFC-passing-tests.txt:
2060
2061 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2062
2063         Unreviewed, fix typo that breaks dashboard link.
2064
2065         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2066         (WebKitBuildbot):
2067
2068 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2069
2070         Update macOS queue configurations
2071         https://bugs.webkit.org/show_bug.cgi?id=193329
2072
2073         Reviewed by Alexey Proskuryakov.
2074
2075         * BuildSlaveSupport/build.webkit.org-config/config.json:
2076         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2077         (BubbleQueueServer):
2078         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2079         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2080         (WebKitBuildbot):
2081         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2082         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
2083         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2084
2085 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2086
2087         MiniBrowser should be able to navigate to about:blank
2088         https://bugs.webkit.org/show_bug.cgi?id=193345
2089
2090         Reviewed by Simon Fraser.
2091
2092         * MiniBrowser/mac/BrowserWindowController.m:
2093         (-[BrowserWindowController addProtocolIfNecessary:]):
2094         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2095
2096         * MiniBrowser/mac/WK1BrowserWindowController.m:
2097         (-[WK1BrowserWindowController fetch:]):
2098         * MiniBrowser/mac/WK2BrowserWindowController.m:
2099         (-[WK2BrowserWindowController fetch:]):
2100         Clean up the code that uses this to match style.
2101
2102 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2103
2104         Remove MiniBrowser custom "Process Swap" menu item which does not work
2105         https://bugs.webkit.org/show_bug.cgi?id=193344
2106
2107         Reviewed by Simon Fraser.
2108
2109         There is a menu item under the Experimental menu that does work.
2110
2111         * MiniBrowser/mac/AppDelegate.m:
2112         (defaultConfiguration):
2113         * MiniBrowser/mac/SettingsController.h:
2114         * MiniBrowser/mac/SettingsController.m:
2115         (-[SettingsController _populateMenu]):
2116         (-[SettingsController validateMenuItem:]):
2117         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2118         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2119
2120 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2121
2122         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2123         https://bugs.webkit.org/show_bug.cgi?id=193327
2124         rdar://problem/47093222
2125
2126         Reviewed by Tim Horton.
2127
2128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2129         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2130         (TestWebKitAPI::didFinishNavigation):
2131         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2132         (TestWebKitAPI::TEST):
2133         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2134         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2135         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2136         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2137         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2138
2139 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2140
2141         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2142         https://bugs.webkit.org/show_bug.cgi?id=193338
2143         <rdar://problem/46664774>
2144
2145         Reviewed by David Kilzer.
2146
2147         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2148         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2149
2150 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2151
2152         Unreviewed, rolling out r239825.
2153         https://bugs.webkit.org/show_bug.cgi?id=193330
2154
2155         Broke tests on armv7/linux bots (Requested by guijemont on
2156         #webkit).
2157
2158         Reverted changeset:
2159
2160         "Enable DFG on ARM/Linux again"
2161         https://bugs.webkit.org/show_bug.cgi?id=192496
2162         https://trac.webkit.org/changeset/239825
2163
2164 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2165
2166         Disable the run-jsc-stress-test remote host key check.
2167         https://bugs.webkit.org/show_bug.cgi?id=192988
2168
2169         Reviewed by Alexey Proskuryakov.
2170
2171         * Scripts/run-jsc-stress-tests:
2172
2173 2019-01-10  John Wilander  <wilander@apple.com>
2174
2175         Override the session configuration for cookieAcceptPolicy
2176         https://bugs.webkit.org/show_bug.cgi?id=190925
2177         <rdar://problem/45497382>
2178
2179         Reviewed by Alexey Proskuryakov and Alex Christensen.
2180
2181         Test infrastructure for setting a first-party-only cookie policy.
2182
2183         * DumpRenderTree/TestRunner.cpp:
2184         (setOnlyAcceptFirstPartyCookiesCallback):
2185         (TestRunner::staticFunctions):
2186         * DumpRenderTree/TestRunner.h:
2187         * DumpRenderTree/mac/TestRunnerMac.mm:
2188         (TestRunner::setOnlyAcceptFirstPartyCookies):
2189         * DumpRenderTree/win/TestRunnerWin.cpp:
2190         (TestRunner::setOnlyAcceptFirstPartyCookies):
2191         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2192         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2193         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2194         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2195         * WebKitTestRunner/TestInvocation.cpp:
2196         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2197
2198 2019-01-09  Matt Rajca  <mrajca@apple.com>
2199
2200         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2201         https://bugs.webkit.org/show_bug.cgi?id=193301
2202
2203         Reviewed by Jer Noble.
2204         
2205         Added API tests.
2206
2207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2208         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2209         (TEST):
2210         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2211
2212 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2213
2214         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2215         https://bugs.webkit.org/show_bug.cgi?id=193310
2216
2217         Reviewed by Antti Koivisto.
2218
2219         * LayoutReloaded/misc/LFC-passing-tests.txt:
2220
2221 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2222
2223         Enable DFG on ARM/Linux again
2224         https://bugs.webkit.org/show_bug.cgi?id=192496
2225
2226         Reviewed by Yusuke Suzuki.
2227
2228         After changing the bytecode format DFG was disabled on all 32-bit
2229         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2230         on ARM by default.
2231
2232         * Scripts/run-jsc-stress-tests:
2233
2234 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2235
2236         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2237         https://bugs.webkit.org/show_bug.cgi?id=193271
2238
2239         Reviewed by Brent Fulgham.
2240
2241         BSTR is a special data structure created by SysAllocString, not a
2242         wchar_t null-terminated string.
2243
2244         * DumpRenderTree/win/TestRunnerWin.cpp:
2245         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2246         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2247         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2248         BSTR from wide string literals.
2249
2250 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2251
2252         Tweak wording for build/version_check style checker error
2253         https://bugs.webkit.org/show_bug.cgi?id=193256
2254
2255         Reviewed by Tim Horton.
2256
2257         * Scripts/webkitpy/style/checkers/cpp.py:
2258         (check_os_version_checks):
2259         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2260         (WebKitStyleTest.test_os_version_checks):
2261
2262 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2263
2264         [ews-build] Add link to bug along with bug title
2265         https://bugs.webkit.org/show_bug.cgi?id=193293
2266
2267         Reviewed by Lucas Forschler.
2268
2269         * BuildSlaveSupport/ews-build/steps.py:
2270         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2271         (ConfigureBuild.add_bug_id_url): Deleted.
2272         (ConfigureBuild.getBugURL): Deleted.
2273
2274 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2275
2276         [ews-build] Use https for ews-build server
2277         https://bugs.webkit.org/show_bug.cgi?id=193193
2278
2279         Reviewed by Lucas Forschler.
2280
2281         * BuildSlaveSupport/ews-build/steps.py:
2282
2283 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2284
2285         [ews-build] Parse and display number of style failures
2286         https://bugs.webkit.org/show_bug.cgi?id=193280
2287
2288         Reviewed by Lucas Forschler.
2289
2290         * BuildSlaveSupport/ews-build/steps.py:
2291         (CheckStyle): Use TestWithFailureCount as base class.
2292         (CheckStyle.countFailures): Count the number of style failures.
2293
2294 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2295
2296         [ews-build] use patch_id instead of ewspatchid
2297         https://bugs.webkit.org/show_bug.cgi?id=193235
2298
2299         Reviewed by Lucas Forschler.
2300
2301         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2302         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2303         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2304
2305 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2306
2307         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2308         https://bugs.webkit.org/show_bug.cgi?id=192625
2309
2310         Reviewed by Antti Koivisto.
2311
2312         * LayoutReloaded/misc/LFC-passing-tests.txt:
2313
2314 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2315
2316         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2317         https://bugs.webkit.org/show_bug.cgi?id=192841
2318
2319         Reviewed by Carlos Garcia Campos.
2320
2321         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2322         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2323         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2324
2325         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2326
2327         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2328         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2329         (WebKitWebEditorTest::testSelectionChanged):
2330         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2331         (WebKitFrameTest::testMainFrame):
2332         (WebKitFrameTest::testURI):
2333         (WebKitFrameTest::testJavaScriptContext):
2334         (WebKitFrameTest::testJavaScriptValues):
2335         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2336         (testWebViewAuthenticationRequest):
2337         (testWebViewAuthenticationLoadCancelled):
2338         (testWebViewAuthenticationFailure):
2339         (testWebViewAuthenticationStorage):
2340         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2341         (testWebViewAuthenticationProxy):
2342         (testWebViewAuthenticationProxyHTTPS):
2343         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2344         (testAutomationSessionRequestSession):
2345         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2346         (testBackForwardListNavigation):
2347         (testWebKitWebViewSessionState):
2348         (testWebKitWebViewSessionStateWithFormData):
2349         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2350         (ConsoleMessageTest::consoleMessageReceivedCallback):
2351         (testWebKitConsoleMessageConsoleAPI):
2352         (testWebKitConsoleMessageJavaScriptException):
2353         (testWebKitConsoleMessageNetworkError):
2354         (testWebKitConsoleMessageSecurityError):
2355         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2356         (testCookieManagerAcceptPolicy):
2357         (testCookieManagerCookiesChanged):
2358         (testCookieManagerPersistentStorage):
2359         (testCookieManagerPersistentStorageDeleteAll):
2360         (testCookieManagerEphemeral):
2361         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2362         (testWebKitDOMElementAutoFill):
2363         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2364         (downloadLocalFileSuccessfully):
2365         (createFileAtDestination):
2366         (testDownloadOverwriteDestinationDisallowed):
2367         (testDownloadLocalFileError):
2368         (testDownloadRemoteFile):
2369         (testDownloadRemoteFileError):
2370         (testWebViewDownloadURI):
2371         (testPolicyResponseDownload):
2372         (testPolicyResponseDownloadCancel):
2373         (testDownloadMIMEType):
2374         (contextMenuCallback):
2375         (testContextMenuDownloadActions):
2376         (testBlobDownload):
2377         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2378         (testWebKitWebEditorSelectionChanged):
2379         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2380         (testWebKitFrameMainFrame):
2381         (testWebKitFrameURI):
2382         (testWebKitFrameJavaScriptContext):
2383         (testWebKitFrameJavaScriptValues):
2384         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2385         (LoadStopTrackingTest::loadFailed):
2386         (testWebViewTitle):
2387         (testURIRequestHTTPHeaders):
2388         (testURIRequestHTTPMethod):
2389         (testURIResponseHTTPHeaders):
2390         (testRedirectToDataURI):
2391         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2392         (testProcessPerWebView):
2393         (testWebProcessLimit):
2394         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2395         (testWebViewResources):
2396         (testWebResourceLoading):
2397         (testWebResourceSuggestedFilename):
2398         (testWebResourceGetData):
2399         (testWebResourceGetDataError):
2400         (testWebViewResourcesHistoryCache):
2401         (testWebResourceSendRequest):
2402         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2403         (testSSL):
2404         (testInsecureContent):
2405         (testTLSErrorsPolicy):
2406         (testTLSErrorsRedirect):
2407         (testTLSErrorsHTTPAuth):
2408         (testLoadFailedWithTLSErrors):
2409         (testSubresourceLoadFailedWithTLSErrors):
2410         (httpsServerCallback):
2411         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2412         (testWebViewCreateNavigationData):
2413         (testWebViewJavaScriptDialogs):
2414         (testWebViewWindowProperties):
2415         (testWebViewMouseTarget):
2416         (testWebViewFileChooserRequest):
2417         (testWebViewColorChooserRequest):
2418         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2419         (testWebExtensionGetTitle):
2420         (testDocumentLoadedSignal):
2421         (testWebKitWebViewProcessCrashed):
2422         (testWebExtensionWindowObjectCleared):
2423         (testWebExtensionIsolatedWorld):
2424         (permissionRequestCallback):
2425         (didAssociateFormControlsCallback):
2426         (testWebExtensionFormControlsAssociated):
2427         (FormSubmissionTest::FormSubmissionTest):
2428         (FormSubmissionTest::testFormSubmissionResult):
2429         (testWebExtensionFormSubmissionSteps):
2430         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2431         (testNotInitialized):
2432         (testClearDatabase):
2433         (testPrivateBrowsing):
2434         (testGetFavicon):
2435         (testWebViewFavicon):
2436         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2437         (testFindControllerTextFound):
2438         (testFindControllerTextNotFound):
2439         (testFindControllerMatchCount):
2440         (testFindControllerMaxMatchCount):
2441         (testFindControllerNext):
2442         (testFindControllerPrevious):
2443         (testFindControllerCountedMatches):
2444         (testFindControllerOptions):
2445         (testFindControllerHide):
2446         (testFindControllerInstance):
2447         (testFindControllerGetters):
2448         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2449         (testNavigationPolicy):
2450         (testResponsePolicy):
2451         (testNewWindowPolicy):
2452         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2453         (testSecurityOriginBasicConstructor):
2454         (testSecurityOriginURIConstructor):
2455         (testSecurityOriginDefaultPort):
2456         (testSecurityOriginFileURI):
2457         (testOpaqueSecurityOrigin):
2458         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2459         (testWebKitSettings):
2460         (testWebKitSettingsNewWithSettings):
2461         (testWebKitSettingsUserAgent):
2462         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2463         (testWebViewNewWithUserContentManager):
2464         (isStyleSheetInjectedForURLAtPath):
2465         (isScriptInjectedForURLAtPath):
2466         (testUserContentManagerInjectedStyleSheet):
2467         (testUserContentManagerInjectedScript):
2468         (UserScriptMessageTest::scriptMessageReceived):
2469         (UserScriptMessageTest::waitUntilMessageReceived):
2470         (UserScriptMessageTest::runJavaScriptFinished):
2471         (testUserContentManagerScriptMessageReceived):
2472         (testUserContentManagerScriptMessageInWorldReceived):
2473         (testUserContentManagerScriptMessageFromDOMBindings):
2474         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2475         (testWebContextDefault):
2476         (testWebContextEphemeral):
2477         (testWebContextGetPlugins):
2478         (testWebContextURIScheme):
2479         (testWebContextSpellChecker):
2480         (testWebContextLanguages):
2481         (consoleMessageReceivedCallback):
2482         (testWebContextSecurityFileXHR):
2483         (ProxyTest::ProxyTest):
2484         (testWebContextProxySettings):
2485         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2486         (testWebViewWebContext):
2487         (testWebViewWebBackend):
2488         (testWebViewEphemeral):
2489         (testWebViewCustomCharset):
2490         (testWebViewSettings):
2491         (testWebViewRunJavaScript):
2492         (testWebViewCanShowMIMEType):
2493         (testWebViewSubmitForm):
2494         (testWebViewSave):
2495         (testWebViewPageVisibility):
2496         (testWebViewSnapshot):
2497         (testWebViewNotification):
2498         (testWebViewNotificationInitialPermissionAllowed):
2499         (testWebViewNotificationInitialPermissionDisallowed):
2500         (testWebViewIsPlayingAudio):
2501         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2502         (WebsiteDataTest::WebsiteDataTest):
2503         (WebsiteDataTest::remove):
2504         (WebsiteDataTest::clear):
2505         (testWebsiteDataConfiguration):
2506         (testWebsiteDataEphemeral):
2507         (testWebsiteDataCache):
2508         (testWebsiteDataStorage):
2509         (testWebsiteDataDatabases):
2510         (testWebsiteDataAppcache):
2511         (testWebsiteDataCookies):
2512         (testWebsiteDataDeviceIdHashSalt):
2513         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2514         (emitDocumentLoaded):
2515         (emitURIChanged):
2516         (sendRequestCallback):
2517         (contextMenuCallback):
2518         (consoleMessageSentCallback):
2519         (emitFormControlsAssociated):
2520         (formControlsAssociatedCallback):
2521         (emitFormSubmissionEvent):
2522         (willSubmitFormCallback):
2523         (windowObjectCleared):
2524         (methodCallCallback):
2525         (registerGResource):
2526         (webkit_web_extension_initialize_with_user_data):
2527         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2528         (checkLeaks):
2529         (WebProcessTest::create):
2530         (runTest):
2531         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2532         (AutocleanupsTest::testWebProcessAutocleanups):
2533         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2534         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2535         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2536         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2537         (WebKitDOMDOMWindowTest::testSignals):
2538         (WebKitDOMDOMWindowTest::testDispatchEvent):
2539         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2540         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2541         (WebKitDOMNodeFilterTest::testTreeWalker):
2542         (WebKitDOMNodeFilterTest::testNodeIterator):
2543         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2544         (WebKitDOMNodeTest::testHierarchyNavigation):
2545         (WebKitDOMNodeTest::testInsertion):
2546         (WebKitDOMNodeTest::testTagNamesNodeList):
2547         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2548         (WebKitDOMNodeTest::testDOMCache):
2549         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2550         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2551         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2552         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2553         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2554         (testUIProcessAutocleanups):
2555         (testWebProcessAutocleanups):
2556         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2557         (testContextMenuPopulateMenu):
2558         (testContextMenuDismissed):
2559         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2560         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2561         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2562         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
2563         (testWebKitDOMDOMWindowSignals):
2564         (testWebKitDOMDOMWindowDispatchEvent):
2565         (testWebKitDOMDOMWindowGetComputedStyle):
2566         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
2567         (testWebKitDOMNodeHierarchyNavigation):
2568         (testWebKitDOMNodeInsertion):
2569         (testWebKitDOMNodeTagNamesNodeList):
2570         (testWebKitDOMNodeTagNamesHTMLCollection):
2571         (testWebKitDOMObjectCache):
2572         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
2573         (testWebKitDOMNodeFilterTreeWalker):
2574         (testWebKitDOMNodeFilterNodeIterator):
2575         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
2576         (testWebKitDOMXPathNSResolverNative):
2577         (testWebKitDOMXPathNSResolverCustom):
2578         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2579         (testInspectorDefault):
2580         (testInspectorManualAttachDetach):
2581         (testInspectorCustomContainerDestroyed):
2582         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
2583         (startTestServer):
2584         (testInspectorServerPageList):
2585         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
2586         (OptionMenuTest::showOptionMenuCallback):
2587         (OptionMenuTest::menuCloseCallback):
2588         (OptionMenuTest::close):
2589         (OptionMenuTest::activateItem):
2590         (OptionMenuTest::selectItem):
2591         (testOptionMenuSimple):
2592         (testOptionMenuGroups):
2593         (testOptionMenuActivate):
2594         (testOptionMenuSelect):
2595         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2596         (testPrintOperationPrintSettings):
2597         (webViewPrintCallback):
2598         (testPrintOperationPrint):
2599         (testPrintCustomWidget):
2600         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2601         (checkAtspiAccessible):
2602         (testAtspiBasicHierarchy):
2603         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
2604         (testWebKitCheckVersion):
2605         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2606         (testWebViewEditorCutCopyPasteNonEditable):
2607         (testWebViewEditorCutCopyPasteEditable):
2608         (testWebViewEditorSelectAllNonEditable):
2609         (testWebViewEditorSelectAllEditable):
2610         (loadContentsAndTryToCutSelection):
2611         (testWebViewEditorNonEditable):
2612         (testWebViewEditorEditable):
2613         (testWebViewEditorEditorStateTypingAttributes):
2614         (testWebViewEditorInsertImage):
2615         (testWebViewEditorCreateLink):
2616         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2617         (loadChangedCallback):
2618         (loadFailedCallback):
2619         (loadFailedWithTLSErrorsCallback):
2620         (LoadTrackingTest::LoadTrackingTest):
2621         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2622         (registerGResource):
2623         (removeNonEmptyDirectory):
2624         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2625         (Test::adoptView):
2626         (Test::~Test):
2627         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2628         (WebKitTestBus::getOrCreateConnection):
2629         (WebKitTestBus::createProxy):
2630         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2631         (WebKitTestServer::getWebSocketURIForPath const):
2632         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2633         (WebViewTest::initializeWebView):
2634         (WebViewTest::loadURI):
2635         (WebViewTest::loadHtml):
2636         (WebViewTest::loadPlainText):
2637         (WebViewTest::loadBytes):
2638         (WebViewTest::loadRequest):
2639         (WebViewTest::loadAlternateHTML):
2640         (WebViewTest::goBack):
2641         (WebViewTest::goForward):
2642         (WebViewTest::goToBackForwardListItem):
2643         (resourceGetDataCallback):
2644         (WebViewTest::mainResourceData):
2645         (WebViewTest::javascriptResultToCString):
2646         (WebViewTest::javascriptResultToNumber):
2647         (WebViewTest::javascriptResultToBoolean):
2648         (WebViewTest::javascriptResultIsNull):
2649         (WebViewTest::javascriptResultIsUndefined):
2650         (onSnapshotReady):
2651         (WebViewTest::runWebProcessTest):
2652         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
2653         (WebViewTest::platformInitializeWebView):
2654         (WebViewTest::showInWindow):
2655         (WebViewTest::showInWindowAndWaitUntilMapped):
2656         (WebViewTest::mouseMoveTo):
2657         (WebViewTest::emitPopupMenuSignal):
2658         (WebViewTest::keyStroke):
2659         (WebViewTest::doMouseButtonEvent):
2660
2661 2019-01-09  Philippe Normand  <pnormand@igalia.com>
2662
2663         [WPE] API tests can't run in flatpak environment
2664         https://bugs.webkit.org/show_bug.cgi?id=193242
2665
2666         Reviewed by Michael Catanzaro.
2667
2668         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
2669         flatpakutils so that it knows which port it's dealing with.
2670         * glib/common.py: Remove build_dir globals so that subsequent
2671         calls actually take args into account.
2672         (library_build_path):
2673         (binary_build_path):
2674
2675 2019-01-08  Dean Jackson  <dino@apple.com>
2676
2677         Blob references for System Previews don't get a correct file extension
2678         https://bugs.webkit.org/show_bug.cgi?id=193268
2679         <rdar://problem/47133037>
2680
2681         Reviewed by Tim Horton.
2682
2683         New test that a Blob download of a USDZ file gets named correctly.
2684
2685         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2686         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2687         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2688         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
2689         (TEST):
2690         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
2691
2692 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
2693
2694         [WebAuthN] Support U2F HID Authenticators on macOS
2695         https://bugs.webkit.org/show_bug.cgi?id=191535
2696         <rdar://problem/47102027>
2697
2698         Reviewed by Brent Fulgham.
2699
2700         This patch:
2701         1) adds support for U2F mocking mechanism;
2702         2) updates tests to reflect U2fCommandConstructor changes.
2703
2704         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2705         (TestWebKitAPI::TEST):
2706         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2707         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2708         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2709
2710 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2711
2712         [iOS] Dispatch a synthetic mousedown event prior to starting drags
2713         https://bugs.webkit.org/show_bug.cgi?id=193229
2714         <rdar://problem/46717097>
2715
2716         Reviewed by Tim Horton.
2717
2718         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
2719         prevents a drag from starting.
2720
2721         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2722         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
2723
2724         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
2725
2726 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
2727   
2728         Layout test will generate a perf metric file to results dir.
2729         https://bugs.webkit.org/show_bug.cgi?id=192030
2730         <rdar://problem/32779516>
2731
2732         Reviewed by Aakash Jain.
2733
2734         Layout test running time will be collected to a perf metric file.
2735         For now, instead of outputing running time of all tests (which is huge),
2736         we aggregate them by test directories which are at most two level deep. 
2737
2738         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2739         (Manager._end_test_run):
2740         (Manager._output_perf_metrics):
2741         (Manager._print_expectation_line_for_test):
2742         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2743         (add_test_perf_metric):
2744         (test_perf_metrics):
2745         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2746         (JSONGeneratorTest.test_test_timings_trie):
2747         (JSONGeneratorTest):
2748         (JSONGeneratorTest.test_test_perf_metrics):
2749         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2750         (RebaselineTest.test_reset_results):
2751         (RebaselineTest.test_missing_results):
2752         (RebaselineTest.test_new_baseline):
2753
2754 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
2755
2756         [WPE][GTK] Add php-json to install-dependencies
2757         https://bugs.webkit.org/show_bug.cgi?id=193233
2758
2759         Reviewed by Michael Catanzaro.
2760
2761         * gtk/install-dependencies:
2762         * wpe/install-dependencies:
2763
2764 2019-01-08  Chris Dumez  <cdumez@apple.com>
2765
2766         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
2767         https://bugs.webkit.org/show_bug.cgi?id=193224
2768         <rdar://problem/47097726>
2769
2770         Reviewed by Alex Christensen.
2771
2772         Add API test coverage.
2773
2774         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2775
2776 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2777
2778         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
2779         <https://webkit.org/b/193222>
2780         <rdar://problem/46862309>
2781
2782         Reviewed by Joseph Pecoraro.
2783
2784         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2785         (WTR::executeCallback): Fix camel case of variable name.
2786         (WTR::EventSendingController::callAfterScrollingCompletes): If
2787         WKBundlePageRegisterScrollOperationCompletionCallback() returns
2788         false, make sure to release the ScrollCompletionCallbackData
2789         object.  This fixes the leak.
2790
2791 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2792
2793         [Win] EWS: wincairo-ews cannot apply a patch with *.png
2794         https://bugs.webkit.org/show_bug.cgi?id=193044
2795
2796         Reviewed by Daniel Bates.
2797
2798         WinCairo EWS bots are using Windows Perl. Binary files should be
2799         opened as binary mode.
2800
2801         * Scripts/svn-apply:
2802         (handleGitBinaryChange): Use 'binmode' for binary file handles.
2803
2804 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
2805
2806         [CMake] Add ENABLE_CSS_TYPED_OM option
2807         https://bugs.webkit.org/show_bug.cgi?id=193216
2808
2809         Reviewed by Michael Catanzaro.
2810
2811         * Scripts/webkitperl/FeatureList.pm:
2812
2813 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2814
2815         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
2816         <https://webkit.org/b/193056>
2817
2818         Reviewed by Alex Christensen.
2819
2820         * Scripts/webkitpy/style/checker.py:
2821         - Ignore use of new runtime/retainptr check in
2822           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
2823           contains tests to ensure RetainPtr<NSObject *> is compatible
2824           with RetainPtr<NSObject>.
2825
2826         * Scripts/webkitpy/style/checkers/cpp.py:
2827         (check_language):
2828         (CppChecker):
2829         - Add checker for use of '*' in RetainPtr<> type.  A for loop
2830           was used instead of a single regex so that angle brackets
2831           could be matched up when checking the type contained within
2832           the RetainPtr<> type.
2833
2834         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2835         (CppStyleTest):
2836         - Add unit test for new runtime/retainptr check.
2837
2838         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
2839         * TestWebKitAPI/EditingTestHarness.h:
2840         - Remove '*' from RetainPtr<> type.
2841
2842         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2843         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
2844           regressed in r201938.
2845
2846         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2847         (TestWebKitAPI::TEST):
2848         - Update tests to match RetainPtr.mm tests (except for the
2849           `*SimilarNSType` tests since there is no CF equivalent of
2850           RetainPtr<NSString> and RetainPtr<NSString *>).
2851
2852         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2853         (TestWebKitAPI::TEST):
2854         - Update tests to:
2855           - Not conflict by name with equivalent CF tests in
2856             RetainPtr.cpp.
2857           - Add test cases for RetainPtr<NSObject>,
2858             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
2859           - Add `*SimilarNSType` tests for converting between
2860             RetainPtr<NSObject> and RetainPtr<NSObject *>.
2861           - Change `0` to `nil` as appropriate.
2862           - Re-alphabetize the tests by name.
2863           - Add Optional<RetainPtr<>> tests.
2864           - Add retainPtr() tests.
2865
2866         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2867         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2868         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
2869         (TEST):
2870         - Remove '*' from RetainPtr<> type.
2871
2872         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
2873         (TEST(WebKit, JITEnabled)):
2874         - Add missing WTFMove().  Apparently a temporary was being
2875           created before in the argument list due to mismatched
2876           RetainPtr<> types.
2877
2878         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2879         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2880         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
2881         (TestWebKitAPI::TEST):
2882         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2883         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2884         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2885         (WTR::resourcesDirectoryURL):
2886         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2887         (WTR::InjectedBundle::platformInitialize):
2888         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2889         - Remove '*' from RetainPtr<> type.
2890
2891 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
2892
2893         A MediaTime timescale must never be zero
2894         https://bugs.webkit.org/show_bug.cgi?id=193156
2895         <rdar://problem/32504501>
2896
2897         Reviewed by Jer Noble.
2898
2899         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2900         (TestWebKitAPI::TEST): Add tests for zero timescale.
2901
2902 2019-01-07  Youenn Fablet  <youenn@apple.com>
2903
2904         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
2905         https://bugs.webkit.org/show_bug.cgi?id=193175
2906
2907         Reviewed by Chris Dumez.
2908
2909         Updated API test as we bumped the SW schema to version 4.
2910
2911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2912         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
2913         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2914         (TEST):
2915
2916 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2917
2918         [Win][Clang] Fix compilation warnings of MiniBrowser
2919         https://bugs.webkit.org/show_bug.cgi?id=193029
2920
2921         Reviewed by Ross Kirsling.
2922
2923         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
2924         and m_URLBarFont. Reorder member variables to fix -Wreorder
2925         warning.
2926         * MiniBrowser/win/PageLoadTestClient.cpp:
2927         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
2928         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
2929         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
2930         m_currentURLIndex.
2931         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2932         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
2933         navigationClient with '{ }' to fix the missing field warning.
2934         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2935         (initDocStruct): Changed the argument type docname to const.
2936
2937 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
2938
2939         [WebAuthN] Import U2F command/response converters from Chromium
2940         https://bugs.webkit.org/show_bug.cgi?id=193150
2941         <rdar://problem/47054028>
2942
2943         Reviewed by Brent Fulgham.
2944
2945         Adds API tests.
2946
2947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2948         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2949         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
2950         (TestWebKitAPI::getTestAuthenticatorDataBytes):
2951         (TestWebKitAPI::getTestAttestationObjectBytes):
2952         (TestWebKitAPI::getTestSignResponse):
2953         (TestWebKitAPI::getTestU2fRegisterResponse):
2954         (TestWebKitAPI::TEST):
2955         (TestWebKitAPI::convertToVector): Deleted.
2956         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2957         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
2958         (TestWebKitAPI::constructMakeCredentialRequest):
2959         (TestWebKitAPI::constructGetAssertionRequest):
2960         (TestWebKitAPI::TEST):
2961
2962 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
2963
2964         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
2965         https://bugs.webkit.org/show_bug.cgi?id=193136
2966
2967         Reviewed by Michael Catanzaro.
2968
2969         * gtk/install-dependencies:
2970         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
2971         they are needed by update-webkitgtk-libs.
2972
2973 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
2974
2975         Unreviewed follow-up fix to r239650
2976         https://bugs.webkit.org/show_bug.cgi?id=193140
2977         <rdar://problem/47063037>
2978
2979         Typecast patch_id to string.
2980
2981         * BuildSlaveSupport/ews-build/steps.py:
2982         (ValidatePatch._is_patch_obsolete):
2983
2984 2019-01-04  Daniel Bates  <dabates@apple.com>
2985
2986         [lldb-webkit]: Add support for pretty-printing raw bitmask types
2987         https://bugs.webkit.org/show_bug.cgi?id=193024
2988
2989         Reviewed by Jer Noble.
2990
2991         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
2992         for the bitmask type WebEventFlags as an example.
2993
2994         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
2995         that can be used to register summary and synthetic child formatters for a bitmask type.
2996         For example, consider the following enum and bitmask typedefs:
2997
2998         typedef enum {
2999             A = 1 << 0,
3000             B = 1 << 1,
3001             C = 1 << 2,
3002         } SpecialFlagValues;
3003         typedef unsigned SpecialFlags;
3004
3005         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
3006         __lldb_init_module():
3007
3008             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
3009                     1 << 0: "A",
3010                     1 << 1: "B",
3011                     1 << 2: "C",
3012             })
3013
3014         * lldb/lldb_webkit.py:
3015         (addSummaryAndSyntheticFormattersForRawBitmaskType):
3016         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
3017         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
3018         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
3019         A convenience function to dynamically creaste a synthetic formatter class and summary
3020         string function for the specified bitmask type and enumerator value to name map. This
3021         function register the dynamically created class and function with LLDB.
3022
3023         (__lldb_init_module):
3024         (FlagEnumerationProvider):
3025         (FlagEnumerationProvider._enumerator_value_to_name_map):
3026         (FlagEnumerationProvider._bitmask):
3027         (FlagEnumerationProvider._update):
3028         (FlagEnumerationProvider.has_children):
3029         (FlagEnumerationProvider.num_children):
3030         (FlagEnumerationProvider.get_child_index):
3031         (FlagEnumerationProvider.get_child_at_index):
3032         (FlagEnumerationProvider.update):
3033         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
3034
3035         (WTFOptionSetProvider):
3036         (WTFOptionSetProvider._enumerator_value_to_name_map):
3037         (WTFOptionSetProvider._bitmask):
3038         (WTFOptionSetProvider._update):
3039         Write in terms of the base class.
3040
3041         (RawBitmaskProviderBase):
3042         (RawBitmaskProviderBase._enumerator_value_to_name_map):
3043         (RawBitmaskProviderBase._bitmask):
3044         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
3045         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
3046         {
3047             1 << 0: "A",
3048             1 << 1: "B",
3049             1 << 2: "C",
3050         }
3051         It is not necessary to instantiate such a derived class directory. Instead use the convenience
3052         function addSummaryAndSyntheticFormattersForRawBitmaskType.
3053
3054         (WTFOptionSetProvider.has_children): Deleted.
3055         (WTFOptionSetProvider.num_children): Deleted.
3056         (WTFOptionSetProvider.get_child_index): Deleted.
3057         (WTFOptionSetProvider.get_child_at_index): Deleted.
3058         (WTFOptionSetProvider.update): Deleted.
3059
3060 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3061
3062         [ews-build] Add build step to validate the patch before processing it
3063         https://bugs.webkit.org/show_bug.cgi?id=193140
3064
3065         Reviewed by Lucas Forschler.
3066
3067         * BuildSlaveSupport/ews-build/factories.py:
3068         (Factory.__init__): Added ValidatePatch step.
3069         * BuildSlaveSupport/ews-build/steps.py:
3070         (ValidatePatch):
3071         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
3072         (ValidatePatch.get_patch_json): Get patch json data.
3073         (ValidatePatch.get_bug_json): Get bug json data.
3074         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
3075         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
3076         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
3077         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
3078         (ValidatePatch.skip_build): Skip the build.
3079         (ValidatePatch.start):
3080
3081 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3082
3083         Progress towards fixing Mac CMake build
3084         https://bugs.webkit.org/show_bug.cgi?id=193105
3085
3086         Reviewed by Don Olmstead.
3087
3088         * TestWebKitAPI/PlatformMac.cmake:
3089
3090 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3091
3092         Fix API test after r239631
3093         https://bugs.webkit.org/show_bug.cgi?id=193118
3094
3095         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3096         (TestWebKitAPI::TEST):
3097         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
3098         Do the same thing via the API to fix the test.
3099
3100 2019-01-04  Jer Noble  <jer.noble@apple.com>
3101
3102         [WebKitLegacy] Media playback pauses on scroll
3103         https://bugs.webkit.org/show_bug.cgi?id=192829
3104
3105         Reviewed by Eric Carlson.
3106
3107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3108         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
3109         (TestWebKitAPI::TEST):
3110         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
3111         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
3112         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
3113         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
3114         (TestWebKitAPI::TEST):
3115
3116 2019-01-04  Chris Dumez  <cdumez@apple.com>
3117
3118         Add support for toggling device orientation API support per site
3119         https://bugs.webkit.org/show_bug.cgi?id=193143
3120         <rdar://problem/46605724>
3121
3122         Reviewed by Alex Christensen.
3123
3124         Add API test coverage.
3125
3126         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3127         (-[DataMappingSchemeHandler setTaskHandler:]):
3128         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3129         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
3130         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3131         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
3132
3133 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3134
3135         [ews-build] use svn-apply script to apply the patches
3136         https://bugs.webkit.org/show_bug.cgi?id=193138
3137
3138         Reviewed by Lucas Forschler.
3139
3140         * BuildSlaveSupport/ews-build/factories.py:
3141         (Factory.__init__): Add the ApplyPatch step.
3142         * BuildSlaveSupport/ews-build/steps.py:
3143         (CheckOutSource): Added step name.
3144         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
3145         (ApplyPatch): Build step to apply patch using svn-apply script.
3146         (UnApplyPatchIfRequired):
3147         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
3148
3149 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3150
3151         Deprecate WKContextCreate
3152         https://bugs.webkit.org/show_bug.cgi?id=193118
3153
3154         Reviewed by Brady Eidson.
3155
3156         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3157         (WebKitBrowserWindow::WebKitBrowserWindow):
3158         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
3159         (TestWebKitAPI::TEST):
3160         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3161         (TestWebKitAPI::TEST):
3162         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3163         (TestWebKitAPI::TEST):
3164         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3165         (TestWebKitAPI::TEST):
3166         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3167         (TestWebKitAPI::TEST):
3168         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3169         (TestWebKitAPI::TEST):
3170         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3171         (TestWebKitAPI::TEST):
3172         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3173         (TestWebKitAPI::TEST):
3174         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3175         (TestWebKitAPI::TEST):
3176         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3177         (TestWebKitAPI::TEST):
3178         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3179         (TestWebKitAPI::TEST):
3180         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3181         (TestWebKitAPI::TEST):
3182         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3183         (TestWebKitAPI::TEST):
3184         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3185         (TestWebKitAPI::TEST):
3186         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3187         (TestWebKitAPI::TEST):
3188         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3189         (TestWebKitAPI::TEST):
3190         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3191         (TestWebKitAPI::TEST):
3192         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3193         (TestWebKitAPI::TEST):
3194         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3195         (TestWebKitAPI::loadAlternateHTMLString):
3196         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3197         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3198         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3199         (TestWebKitAPI::buildAndPerformTest):
3200         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3201         (TestWebKitAPI::TEST):
3202         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3203         (TestWebKitAPI::TEST):
3204         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3205         (TestWebKitAPI::TEST):
3206         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3207         (TestWebKitAPI::TEST):
3208         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3209         (TestWebKitAPI::TEST):
3210         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3211         (TestWebKitAPI::TEST):
3212         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3213         (TestWebKitAPI::TEST):
3214         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3215         (TestWebKitAPI::TEST):
3216         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3217         (TestWebKitAPI::TEST):
3218         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3219         (TestWebKitAPI::TEST):
3220         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3221         (TestWebKitAPI::TEST):
3222         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3223         (TestWebKitAPI::TEST):
3224         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3225         (TestWebKitAPI::TEST):
3226         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3227         (TestWebKitAPI::TEST):
3228         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3229         (TestWebKitAPI::TEST):
3230         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3231         (TestWebKitAPI::TEST):
3232         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3233         (TestWebKitAPI::TEST):
3234         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3235         (TestWebKitAPI::TEST):
3236         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3237         (TestWebKitAPI::TEST):
3238         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3239         (TestWebKitAPI::TEST):
3240         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3241         (TestWebKitAPI::TEST):
3242         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3243         (TestWebKitAPI::TEST):
3244         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3245         (TestWebKitAPI::TEST):
3246         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3247         (TestWebKitAPI::TEST):
3248         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3249         (TestWebKitAPI::TEST):
3250         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3251         (TestWebKitAPI::TEST):
3252         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3253         (WebKit2_CommandBackForwardTestWKView::SetUp):
3254         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3255         (TestWebKitAPI::TEST):
3256         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3257         (TestWebKitAPI::TEST):
3258         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3259         (TestWebKitAPI::TEST):
3260         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3261         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3262
3263 2019-01-03  Matt Rajca  <mrajca@apple.com>
3264
3265         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3266         https://bugs.webkit.org/show_bug.cgi?id=193128
3267         rdar://34554231
3268
3269         Reviewed by Jer Noble.
3270
3271         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3272         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3273         event along with a flag that indicates whether or not autoplay was actually prevented.
3274
3275         Tests: existing API tests were updated to reflect the new names. New API tests
3276         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3277
3278         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3279         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3280         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3281         (TEST):
3282         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3283         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3284
3285 2019-01-04  Chris Dumez  <cdumez@apple.com>
3286
3287         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3288         https://bugs.webkit.org/show_bug.cgi?id=193120
3289
3290         Reviewed by Alex Christensen.
3291
3292         Add API test coverage.
3293
3294         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3295
3296 2019-01-04  Chris Dumez  <cdumez@apple.com>
3297
3298         Crash under WebProcessPool::addSuspendedPage()
3299         https://bugs.webkit.org/show_bug.cgi?id=193110
3300
3301         Reviewed by Youenn Fablet.
3302
3303         Add API test coverage.
3304
3305         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3306
3307 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3308
3309         [ews-build] Check patch relevance before applying the patch
3310         https://bugs.webkit.org/show_bug.cgi?id=193102
3311
3312         Reviewed by Lucas Forschler.
3313
3314         * BuildSlaveSupport/ews-build/factories.py:
3315         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3316
3317 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3318
3319         [ews-build] Check patch relevance step should print patch id
3320         https://bugs.webkit.org/show_bug.cgi?id=193137
3321
3322         Reviewed by Lucas Forschler.
3323
3324         * BuildSlaveSupport/ews-build/steps.py:
3325         (CheckPatchRelevance.start): Update the status to include patch id.
3326
3327 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3328
3329         webkitpy: Increase simulator teardown timeout
3330         https://bugs.webkit.org/show_bug.cgi?id=193141
3331         <rdar://problem/46174217>
3332
3333         Rubber-stamped by Aakash Jain.
3334
3335         * Scripts/webkitpy/xcode/simulated_device.py:
3336         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3337
3338 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3339
3340         test262-runner misbehaves when test file YAML has a trailing space
3341         https://bugs.webkit.org/show_bug.cgi?id=193053
3342
3343         Reviewed by Yusuke Suzuki.
3344
3345         * Scripts/test262/Runner.pm:
3346         (parseData):
3347         Accept trailing space when parsing a test file's YAML block.
3348
3349 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3350
3351         UserMedia test should use WKPageNavigationClient
3352         https://bugs.webkit.org/show_bug.cgi?id=192913
3353
3354         Reviewed by Youenn Fablet.
3355
3356         The test currently uses the deprecated WKPageLoaderClient. It should use
3357         WKPageNavigationClient instead, which provides the same callback under a similar name.
3358
3359         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3360         (TestWebKitAPI::TEST):
3361
3362 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3363
3364         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3365         https://bugs.webkit.org/show_bug.cgi?id=192944
3366
3367         Reviewed by Tim Horton.
3368
3369         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3370         (TestWebKitAPI::TEST):
3371
3372 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3373
3374         Add support for using the current text selection as the find string on iOS
3375         https://bugs.webkit.org/show_bug.cgi?id=193034
3376         <rdar://problem/45138739>
3377
3378         Reviewed by Tim Horton.
3379
3380         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3381         _setStringForFind) works as expected.
3382
3383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3384         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3385
3386 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3387
3388         [ews-build] Use git on OpenSource EWS bots
3389         https://bugs.webkit.org/show_bug.cgi?id=193092
3390
3391         Reviewed by Lucas Forschler.
3392
3393         * BuildSlaveSupport/ews-build/steps.py:
3394         (CheckOutSource): Use git instead of svn.
3395         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3396
3397 2019-01-02  Daniel Bates  <dabates@apple.com>
3398
3399         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3400         https://bugs.webkit.org/show_bug.cgi?id=193023
3401
3402         Reviewed by Simon Fraser.
3403
3404         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3405         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3406         enumerator values. We should just remove this code.
3407
3408         * lldb/lldb_webkit.py:
3409         (WTFOptionSetProvider.has_children):
3410         (WTFOptionSetProvider.num_children):
3411         (WTFOptionSetProvider.get_child_index):
3412         (WTFOptionSetProvider.get_child_at_index):
3413
3414 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3415
3416         .ycm_extra_conf.py should handle XXXInlines.h
3417         https://bugs.webkit.org/show_bug.cgi?id=193055
3418
3419         Reviewed by Carlos Garcia Campos.
3420
3421         compile_commands.json database only records flags and options for cpp source files.
3422         So, when we open headers, this database does not have any information for that.
3423         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3424         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3425         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3426         we attempt to find XXX.cpp and use the configuration if it exists.
3427
3428         * gtk/ycm_extra_conf.py:
3429         (getImplementationFilename):
3430         (FlagsForFile):
3431
3432 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3433
3434         Unreviewed. Support PHP 7.3 in Debian.
3435
3436         Add 7.3 to the list of php versions supported in Debian.
3437
3438         * Scripts/webkitpy/port/base.py:
3439         (Port._debian_php_version):
3440
3441 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3442
3443         Resurrect Mac CMake build
3444         https://bugs.webkit.org/show_bug.cgi?id=192658
3445
3446         Reviewed by Yusuke Suzuki.
3447
3448         * DumpRenderTree/PlatformMac.cmake:
3449         * MiniBrowser/mac/CMakeLists.txt:
3450         * TestWebKitAPI/PlatformMac.cmake:
3451
3452 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3453
3454         [Tools] Remove references to Bison and Flex
3455         https://bugs.webkit.org/show_bug.cgi?id=193033
3456
3457         Reviewed by Michael Catanzaro.
3458
3459         The Bison and Flex tools are not needed anymore since r209883.
3460
3461         * CygwinDownloader/cygwin-downloader.py:
3462         * EWSTools/ubuntu-ews-packages:
3463         * Scripts/filter-build-webkit:
3464         (shouldIgnoreLine):
3465         * gtk/install-dependencies:
3466         * wpe/install-dependencies:
3467
3468 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3469
3470         WebDriver: warn about non existing tests when parsing expectations
3471         https://bugs.webkit.org/show_bug.cgi?id=192979
3472
3473         Reviewed by Michael Catanzaro.
3474
3475         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
3476         renamed.
3477
3478         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3479         (WebDriverTestRunner.__init__):
3480
3481 2018-12-21  Chris Dumez  <cdumez@apple.com>
3482
3483         navigator.userAgent in service workers does not reflect customUserAgent set by client
3484         https://bugs.webkit.org/show_bug.cgi?id=192951
3485
3486         Reviewed by Youenn Fablet.
3487
3488         Extend API test coverage.
3489
3490         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3491         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
3492         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3493         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
3494         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3495
3496 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3497
3498         [WebAuthN] userPresence should always be true
3499         https://bugs.webkit.org/show_bug.cgi?id=192835
3500         <rdar://problem/46538788>
3501
3502         Reviewed by Brent Fulgham.
3503
3504         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3505         (TestWebKitAPI::TEST):
3506
3507 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
3508
3509         Add support to run-benchmark to use non-default copies of the browser apps
3510         https://bugs.webkit.org/show_bug.cgi?id=192905
3511         rdar://problem/46845840
3512
3513         Reviewed by Dewei Zhu.
3514         
3515         Add support for a --browser-path argument to run-benchmark, which allows you to use
3516         a custom app bundle for a given browser (only implemented for Safari at present).
3517
3518         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3519         (BenchmarkRunner.__init__):
3520         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3521         (BrowserDriver.__init__):
3522         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3523         (BrowserDriverFactory.create):
3524         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3525         (OSXBrowserDriver._launch_process):
3526         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
3527         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
3528         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3529         (OSXChromeCanaryDriver.launch_url):
3530         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3531         (OSXFirefoxNightlyDriver.launch_url):
3532         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3533         (OSXSafariDriver.__init__):
3534         (OSXSafariDriver.launch_url):
3535         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3536         (parse_args):
3537         (run_benchmark_plan):
3538         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3539         (WebServerBenchmarkRunner.__init__):
3540         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
3541         (FakeBenchmarkRunner.__init__):
3542
3543 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3544
3545         [WebAuthN] Import an APDU coder from Chromium
3546         https://bugs.webkit.org/show_bug.cgi?id=192949
3547         <rdar://problem/46879933>
3548
3549         Reviewed by Brent Fulgham.
3550
3551         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3552         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
3553         (TestWebKitAPI::TEST):
3554
3555 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3556
3557         Setting the file wrapper and content type of an attachment to a PDF should update its image
3558         https://bugs.webkit.org/show_bug.cgi?id=192984
3559         <rdar://problem/46798028>
3560
3561         Reviewed by Tim Horton.
3562
3563         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
3564         PDF data correctly updates the image element.
3565
3566         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3567
3568 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3569
3570         Add JSCOnly to bot dashboard
3571         https://bugs.webkit.org/show_bug.cgi?id=192964
3572
3573         Reviewed by Alexey Proskuryakov.
3574
3575         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
3576         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
3577         useful if they were not so secret, so add them.
3578
3579         There appear to be no build-only bots, so the first column is blank. And of course there are
3580         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
3581         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
3582         and there's plenty of room in the final column for all the bots.
3583
3584         I had a hard time picking a logo to use, because the JavaScript language does not have an
3585         official logo. But I believe I've found one that will be satisfactory.
3586
3587         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
3588
3589         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
3590         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
3591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3592         (BubbleQueueServer):
3593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3594         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3595         (WebKitBuildbot):
3596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3597         (table.queue-grid tr.platform.linux-jsconly img.logo):
3598
3599 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
3600
3601         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3602         https://bugs.webkit.org/show_bug.cgi?id=192821
3603
3604         Reviewed by Chris Dumez.
3605
3606         * DumpRenderTree/mac/DumpRenderTree.mm:
3607         (createWebViewAndOffscreenWindow):
3608         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3609
3610 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3611
3612         [Win][Clang] Fix compilation warnings of DumpRenderTree
3613         https://bugs.webkit.org/show_bug.cgi?id=192924
3614
3615         Reviewed by Alex Christensen.
3616
3617         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
3618         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3619         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
3620         * DumpRenderTree/win/DumpRenderTree.cpp:
3621         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
3622         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
3623         object to the argument of setDefaultTextEncodingName instead of a
3624         const string literal.
3625         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
3626         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
3627         (setCacheFolder): Deleted.
3628         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
3629         * DumpRenderTree/win/EditingDelegate.cpp:
3630         (dump): Use %d for int.
3631         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
3632         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3633         (BSTRFromString): Deleted unused function.
3634         * DumpRenderTree/win/TestRunnerWin.cpp:
3635         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
3636         the arguemnt of setQuota instead of const string literal.
3637         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3638         (jsStringRefToWString): Deleted unused function.
3639
3640 2018-12-20  Chris Dumez  <cdumez@apple.com>
3641
3642         Add API test coverage for customUserAgent client setting and service workers
3643         https://bugs.webkit.org/show_bug.cgi?id=192952
3644
3645         Reviewed by Alex Christensen.
3646
3647         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3648         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
3649         (-[SWSchemes webView:startURLSchemeTask:]):
3650         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3651         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3652
3653 2018-12-20  Chris Dumez  <cdumez@apple.com>
3654
3655         Use Optional::hasValue() instead of Optional::has_value()
3656         https://bugs.webkit.org/show_bug.cgi?id=192948
3657
3658         Reviewed by Tim Horton.
3659
3660         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
3661         (TestWebKitAPI::TEST):
3662         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
3663         (TestWebKitAPI::TEST):
3664         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3665         (TestWebKitAPI::TEST_F):
3666
3667 2018-12-20  Chris Dumez  <cdumez@apple.com>
3668
3669         Add style script rule to check for uses of std::optional<>
3670         https://bugs.webkit.org/show_bug.cgi?id=192931
3671
3672         Reviewed by Tim Horton.
3673
3674         * Scripts/webkitpy/style/checkers/cpp.py:
3675         (check_wtf_optional):
3676         (check_style):
3677
3678 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
3679
3680         [WebAuthN] Add a runtime flag for local authenticator
3681         https://bugs.webkit.org/show_bug.cgi?id=192792
3682         <rdar://problem/46798738>
3683
3684         Reviewed by Brent Fulgham.
3685
3686         * DumpRenderTree/TestOptions.cpp:
3687         (TestOptions::TestOptions):
3688         * DumpRenderTree/TestOptions.h:
3689         * DumpRenderTree/mac/DumpRenderTree.mm:
3690         (enableExperimentalFeatures):
3691         (setWebPreferencesForTestOptions):
3692         * WebKitTestRunner/TestController.cpp:
3693         (WTR::TestController::resetPreferencesToConsistentValues):
3694         (WTR::updateTestOptionsFromTestHeader):
3695         * WebKitTestRunner/TestOptions.h:
3696         (WTR::TestOptions::hasSameInitializationOptions const):
3697
3698 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
3699
3700         webkitpy: Autoinstall package URLs have changed
3701         https://bugs.webkit.org/show_bug.cgi?id=192909
3702         <rdar://problem/46860359>
3703
3704         Rubber-stamped by Alexey Proskuryakov.
3705
3706         PyPi urls have been moved around, we need to update our auto-installed packages.
3707
3708         We should check for Selenium before asking PyPi for the latest version.
3709
3710         * Scripts/webkitpy/thirdparty/__init__.py:
3711         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
3712         (AutoinstallImportHook._install_keyring): Ditto.
3713         (AutoinstallImportHook._install_pep8): Ditto.
3714         (AutoinstallImportHook._install_mozlog): Ditto.
3715         (AutoinstallImportHook._install_mozprocess): Ditto.
3716         (AutoinstallImportHook._install_pytest_timeout): Ditto.
3717         (AutoinstallImportHook._install_pytest): Ditto.
3718         (AutoinstallImportHook._install_pylint): Ditto.
3719         (AutoinstallImportHook._install_buildbot): Ditto.
3720         (AutoinstallImportHook._install_coverage): Ditto.
3721         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
3722         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
3723         for new Selenium if the installed version isn't sufficient.
3724         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
3725
3726 2018-12-20  Chris Dumez  <cdumez@apple.com>
3727
3728         Use Optional::valueOr() instead of Optional::value_or()
3729         https://bugs.webkit.org/show_bug.cgi?id=192933
3730
3731         Reviewed by Geoffrey Garen.
3732
3733         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3734         (TestWebKitAPI::checkURL):
3735         (TestWebKitAPI::checkRelativeURL):
3736         (TestWebKitAPI::checkURLDifferences):
3737         (TestWebKitAPI::checkRelativeURLDifferences):
3738         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
3739         (TestWebKitAPI::checkURL):
3740
3741 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
3742
3743         Unreviewed, rolling out r239417.
3744
3745         Introduced two API test failures on macOS.
3746
3747         Reverted changeset:
3748
3749         "<rdar://problem/46194315> macOS: WebKit1 does not handle
3750         occlusion changes"
3751         https://bugs.webkit.org/show_bug.cgi?id=192821
3752         https://trac.webkit.org/changeset/239417
3753
3754 2018-12-20  Devin Rousso  <drousso@apple.com>
3755
3756         Web Inspector: UIString should take an optional key and description to aid localization
3757         https://bugs.webkit.org/show_bug.cgi?id=153962
3758         <rdar://problem/24542505>
3759
3760         Reviewed by Brian Burg.
3761
3762         * Scripts/extract-localizable-js-strings:
3763
3764 2018-12-20  Tim Horton  <timothy_horton@apple.com>
3765
3766         Unparented WKWebView can't retrieve main resource data for a main frame plugin
3767         https://bugs.webkit.org/show_bug.cgi?id=192923
3768         <rdar://problem/46859068>
3769
3770         Reviewed by Wenson Hsieh.
3771
3772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3773         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
3774         Add a test ensuring that both parented and unparented WKWebViews can
3775         retrieve main resource data when loading a PDF.
3776
3777 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3778
3779         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
3780         https://bugs.webkit.org/show_bug.cgi?id=192852
3781
3782         Reviewed by Michael Catanzaro.
3783
3784         EmojiOne font was replaced by Noto Color Emoji.
3785
3786         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
3787         * gtk/jhbuild.modules:
3788         * wpe/jhbuild.modules:
3789
3790 2018-12-19  Chris Dumez  <cdumez@apple.com>
3791
3792         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
3793         https://bugs.webkit.org/show_bug.cgi?id=192728
3794         <rdar://problem/46746779>
3795
3796         Reviewed by Geoff Garen.
3797
3798         * DumpRenderTree/*:
3799         * MiniBrowser/*:
3800         * TestRunnerShared/*:
3801         * TestWebKitAPI/*:
3802         * WebGPUAPIStructure/*:
3803         * WebKitTestRunner/*:
3804
3805 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
3806
3807         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3808         https://bugs.webkit.org/show_bug.cgi?id=192821
3809
3810         Reviewed by Chris Dumez.
3811
3812         * DumpRenderTree/mac/DumpRenderTree.mm:
3813         (createWebViewAndOffscreenWindow):
3814
3815 2018-12-19  Alex Christensen  <achristensen@webkit.org>
3816
3817         Navigations away from the SafeBrowsing interstitial show a flash of old content
3818         https://bugs.webkit.org/show_bug.cgi?id=192676
3819
3820         Reviewed by Chris Dumez.
3821
3822         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3823         (safeBrowsingView):
3824         (TEST):
3825         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3826
3827 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
3828
3829         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
3830         https://bugs.webkit.org/show_bug.cgi?id=192855
3831
3832         Reviewed by Michael Catanzaro.
3833
3834         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3835         (WTR::TestController::notifyDone): Use the WPE implementation.
3836         (WTR::TestController::platformRunUntil): Use the WPE implementation.
3837         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
3838         (WTR::TestController::platformRunUntil): Honor the condition flag.
3839
3840 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
3841
3842         Allow clients to set the navigator platform
3843         https://bugs.webkit.org/show_bug.cgi?id=192735
3844
3845         Reviewed by Tim Horton.
3846
3847         Add a test for setting a custom navigator platform.
3848
3849         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3850         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3851         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
3852
3853 2018-12-19  Truitt Savell  <tsavell@apple.com>
3854
3855         Unreviewed, rolling out r239358.
3856
3857         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
3858         crash on Debug bots
3859
3860         Reverted changeset:
3861
3862         "Clean up IndexedDB files between tests"
3863         https://bugs.webkit.org/show_bug.cgi?id=192796
3864         https://trac.webkit.org/changeset/239358
3865
3866 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3867
3868         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
3869         https://bugs.webkit.org/show_bug.cgi?id=192842
3870         <rdar://problem/46823586>
3871
3872         Reviewed by Tim Horton.
3873
3874         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
3875         item provider when dragging a rich text selection.
3876
3877         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3878
3879 2018-12-18  David Quesada  <david_quesada@apple.com>
3880
3881         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
3882         https://bugs.webkit.org/show_bug.cgi?id=192810
3883         <rdar://problem/46812536>
3884
3885         Reviewed by Alex Christensen.
3886
3887         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3888         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3889             After releasing our reference to the web view, wait until the next turn of the runloop
3890             before checking that the originatingWebView has been zeroed, since the web view might
3891             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
3892             testing general memory management of WKWebViews, only that _WKDownload does not retain
3893             its web view via the 'originatingWebView' property.
3894
3895 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
3896
3897         Clean up IndexedDB files between tests
3898         https://bugs.webkit.org/show_bug.cgi?id=192796
3899
3900         Reviewed by Geoffrey Garen.
3901
3902         * DumpRenderTree/mac/DumpRenderTree.mm:
3903         (runTest):
3904         * WebKitTestRunner/TestController.cpp:
3905         (WTR::TestController::resetStateToConsistentValues):
3906         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3907         (WTR::RemoveAllIndexedDatabasesCallback):
3908         (WTR::TestController::ClearIndexedDatabases):
3909         * WebKitTestRunner/TestController.h:
3910
3911 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3912
3913         Fix API test introduced in r239339 on iOS.
3914         https://bugs.webkit.org/show_bug.cgi?id=192675
3915
3916         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3917         (TEST):
3918         The iOS implementation of the safe browsing warning is a little different.
3919         It does some element creation when it is added to the window so it knows how big it is.
3920         To test these elements, we need to simulate adding it to the window.
3921         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
3922
3923 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
3924
3925         webkitpy: Ignore device type for test when using --force
3926         https://bugs.webkit.org/show_bug.cgi?id=192786
3927         <rdar://problem/46794894>
3928
3929         Reviewed by Daniel Bates.
3930
3931         It is sometimes the case that a contributor will wish to run a test on a specific device,
3932         despite expectations which indicate a test should not be run on that device.
3933
3934         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3935         (parse_args):
3936         * Scripts/webkitpy/port/device_port.py:
3937         (DevicePort.default_child_processes): Strip device type information when using --force.
3938         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
3939
3940 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3941
3942         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
3943         https://bugs.webkit.org/show_bug.cgi?id=192675
3944
3945         Reviewed by Geoffrey Garen.
3946
3947         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3948         (goBack):
3949         (TEST):
3950         (visitUnsafeSite):
3951         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
3952         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3953
3954 2018-12-18  Chris Dumez  <cdumez@apple.com>
3955
3956         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
3957         https://bugs.webkit.org/show_bug.cgi?id=192772
3958
3959         Reviewed by Antti Koivisto.
3960
3961         Add API test coverage.
3962
3963         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3964
3965 2018-12-18  Philippe Normand  <pnormand@igalia.com>
3966
3967         Unreviewed, JHBuild GTK build fix attempt
3968
3969         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
3970         There's no ninja module either, it should be provided by the
3971         host system.
3972
3973 2018-12-17  Chris Dumez  <cdumez@apple.com>
3974
3975         Allow passing nil as session state to [WKWebView _restoreSessionState:]
3976         https://bugs.webkit.org/show_bug.cgi?id=192789
3977         <rdar://problem/46755277>
3978
3979         Reviewed by Alex Christensen.
3980
3981         Add API test coverage.
3982
3983         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3984         (TEST):
3985
3986 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
3987
3988         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
3989         https://bugs.webkit.org/show_bug.cgi?id=192780
3990         rdar://problem/43394387
3991
3992         Reviewed by Tim Horton.
3993
3994         No need to set "AppleFontSmoothing" defaults for WK2.
3995
3996         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3997         (WTR::InjectedBundle::platformInitialize):
3998
3999 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
4000
4001         webkitpy: Handle case where stdout and stderr don't accept unicode
4002         https://bugs.webkit.org/show_bug.cgi?id=192775
4003         <rdar://problem/46497303>
4004
4005         Reviewed by Stephanie Lewis.
4006
4007         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
4008         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
4009         characters with '?'.
4010         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
4011         (RegularTest.test_stream_with_encoding):
4012
4013 2018-12-17  Daniel Bates  <dabates@apple.com>
4014
4015         Support concatenating StringView with other string types
4016         https://bugs.webkit.org/show_bug.cgi?id=177566
4017
4018         Reviewed by Darin Adler.
4019
4020         Add some tests to ensure we do not regress the number of allocations needed when performing
4021         string concatenation with string views.
4022
4023         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
4024         (TestWebKitAPI::TEST):
4025
4026 2018-12-17  Commit Queue  <commit-queue@webkit.org>
4027
4028         Unreviewed, rolling out r239265 and r239274.
4029         https://bugs.webkit.org/show_bug.cgi?id=192765
4030
4031         unorm_normalize is deprecated, and broke an internal build
4032         (Requested by Truitt on #webkit).
4033
4034         Reverted changesets:
4035
4036         "[GTK][WPE] Need a function to convert internal URI to display
4037         ("pretty") URI"
4038         https://bugs.webkit.org/show_bug.cgi?id=174816
4039         https://trac.webkit.org/changeset/239265
4040
4041         "Fix the Apple Internal Mac build with a newer SDK"
4042         https://trac.webkit.org/changeset/239274
4043
4044 2018-12-17  Daniel Bates  <dabates@apple.com>
4045
4046         Implement UIScriptController::toggleCapsLock() for iOS
4047         https://bugs.webkit.org/show_bug.cgi?id=191815
4048
4049         Reviewed by Andy Estes.
4050
4051         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
4052
4053         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4054         * WebKitTestRunner/TestController.cpp:
4055         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
4056         before running a test. This ensures that the caps lock state does not persist between
4057         tests should a test enable caps lock and not disable it.
4058         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4059         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
4060         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4061         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
4062         create the event. Also substituted NSString* for const String& as the data type for the first
4063         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
4064         below.
4065         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
4066         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
4067
4068 2018-12-17  Daniel Bates  <dabates@apple.com>
4069
4070         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
4071         https://bugs.webkit.org/show_bug.cgi?id=192633
4072
4073         Reviewed by Wenson Hsieh.
4074
4075         Update code to use the modern initializer.
4076
4077         * DumpRenderTree/mac/EventSendingController.mm:
4078         (-[EventSendingController keyDown:withModifiers:withLocation:]):
4079
4080 2018-12-17  Matt Lewis  <jlewis3@apple.com>
4081
4082         Unreviewed, rolling out r239254.
4083
4084         This broke the Windows 10 Debug build
4085
4086         Reverted changeset:
4087
4088         "Replace many uses of String::format with more type-safe
4089         alternatives"
4090         https://bugs.webkit.org/show_bug.cgi?id=192742
4091         https://trac.webkit.org/changeset/239254
4092
4093 2018-12-17  David Kilzer  <ddkilzer@apple.com>
4094
4095         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
4096         <https://webkit.org/b/192751>
4097         <rdar://problem/46771623>
4098
4099         Reviewed by Daniel Bates.
4100
4101         Change loop variables to const references to avoid unnecessary
4102         copies.
4103
4104         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
4105         (-[LocalPasteboard pasteboardItems]):
4106
4107 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
4108
4109         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
4110         https://bugs.webkit.org/show_bug.cgi?id=174816
4111
4112         Reviewed by Michael Catanzaro.
4113
4114         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
4115
4116         * TestWebKitAPI/CMakeLists.txt:
4117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4118         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
4119         (TestWebKitAPI::TEST):
4120         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
4121         (testURIForDisplayUnaffected):
4122         (testURIForDisplayAffected):
4123         (beforeAll):
4124         (afterAll):
4125         * TestWebKitAPI/glib/CMakeLists.txt:
4126
4127 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
4128
4129         [WPE] Add API to notify about frame displayed view backend callback
4130         https://bugs.webkit.org/show_bug.cgi?id=192224
4131
4132         Reviewed by Michael Catanzaro.
4133
4134         Add a test case to check the new API.
4135
4136         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4137         (testWebViewFrameDisplayed):
4138         (beforeAll):
4139         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
4140
4141 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
4142
4143         Unreviewed build fix after r239253
4144
4145         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
4146
4147 2018-12-15  Darin Adler  <darin@apple.com>
4148
4149         Use warning-ignoring macros more consistently and simply
4150         https://bugs.webkit.org/show_bug.cgi?id=192743
4151
4152         Reviewed by Mark Lam.
4153
4154         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4155         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
4156         * DumpRenderTree/mac/TextInputControllerMac.m:
4157         (-[TextInputController interpretKeyEvents:withSender:]): Use
4158         IGNORE_WARNINGS_BEGIN/END.
4159         * WebKitTestRunner/mac/EventSenderProxy.mm:
4160         (WTR::EventSenderProxy::mouseForceClick): Use
4161         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
4162         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
4163         (WTR::EventSenderProxy::mouseForceDown): Ditto.
4164         (WTR::EventSenderProxy::mouseForceUp): Ditto.
4165         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
4166
4167 2018-12-15  Darin Adler  <darin@apple.com>
4168
4169         Replace many uses of String::format with more type-safe alternatives
4170         https://bugs.webkit.org/show_bug.cgi?id=192742
4171
4172         Reviewed by Mark Lam.
4173
4174         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4175         (WTR::cacheTestRunnerCallback): Use makeString.
4176         * WebKitTestRunner/TestController.cpp:
4177         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
4178         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
4179
4180 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
4181
4182         [WPE][GTK] Add libpsl to JHBuild module sets
4183         https://bugs.webkit.org/show_bug.cgi?id=192740
4184
4185         Reviewed by Michael Catanzaro.
4186
4187         * gtk/jhbuild.modules: Add libpsl module.
4188         * wpe/jhbuild.modules: Ditto.
4189
4190 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
4191
4192         Add a style checker rule for Xcode version macros use
4193         https://bugs.webkit.org/show_bug.cgi?id=192703
4194
4195         Reviewed by Alex Christensen.
4196
4197         * Scripts/webkitpy/style/checkers/cpp.py:
4198         (check_os_version_checks):
4199         (process_line):
4200         (CppChecker):
4201         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4202         (WebKitStyleTest.test_os_version_checks):
4203
4204 2018-12-14  Chris Dumez  <cdumez@apple.com>
4205
4206         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
4207         https://bugs.webkit.org/show_bug.cgi?id=192704
4208
4209         Reviewed by Geoffrey Garen.
4210
4211         Extend existing API test to reproduce the problem.
4212
4213         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4214
4215 2018-12-14  Chris Dumez  <cdumez@apple.com>
4216
4217         [PSON] WebsitePolicies are lost on process-swap
4218         https://bugs.webkit.org/show_bug.cgi?id=192694
4219         <rdar://problem/46715748>
4220
4221         Reviewed by Brady Eidson.
4222
4223         Extend existing API test to reproduce the issue.
4224
4225         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4226
4227 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
4228
4229         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
4230         https://bugs.webkit.org/show_bug.cgi?id=192678
4231
4232         Reviewed by Carlos Garcia Campos.
4233
4234         Update our ancient versions of libsoup and glib-networking.
4235
4236         * gtk/install-dependencies:
4237         * gtk/jhbuild.modules:
4238         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
4239         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
4240         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
4241         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
4242         * wpe/install-dependencies:
4243         * wpe/jhbuild.modules:
4244         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
4245
4246 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4247
4248         [WPE] Use new view state API from libwpe
4249         https://bugs.webkit.org/show_bug.cgi?id=191906
4250
4251         Reviewed by Žan Doberšek.
4252
4253         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4254         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
4255         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4256         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
4257         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
4258         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4259         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
4260         wpe_view_activity_state_focused state flags.
4261         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
4262         * wpe/backends/HeadlessViewBackend.cpp:
4263         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
4264         * wpe/backends/WindowViewBackend.cpp:
4265         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
4266         received in configure callback.
4267         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
4268
4269 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
4270
4271         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
4272         https://bugs.webkit.org/show_bug.cgi?id=192688
4273
4274         Reviewed by Ross Kirsling.
4275
4276         * win/DLLLauncher/DLLLauncherMain.cpp:
4277         (copyEnvironmentVariable): Moved.
4278         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
4279         (applePathFromRegistry): Ditto.
4280         (appleApplicationSupportDirectory): Ditto.
4281         (prependPath): Ditto.
4282
4283 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
4284
4285         Unreviewed. Changed my status to a reviewer.
4286
4287         * Scripts/webkitpy/common/config/contributors.json:
4288
4289 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4290
4291         [iOS] Support dropping contact card data (public.vcard) in editable content
4292         https://bugs.webkit.org/show_bug.cgi?id=192570
4293         <rdar://problem/35626913>
4294
4295         Reviewed by Tim Horton.
4296
4297         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4298
4299         Add API tests to verify that registering `M