[Web GPU] Fix Web GPU experimental feature on iOS
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-08  Justin Fan  <justin_fan@apple.com>
2
3         [Web GPU] Fix Web GPU experimental feature on iOS
4         https://bugs.webkit.org/show_bug.cgi?id=196632
5
6         Reviewed by Myles C. Maxfield.
7
8         Properly make Web GPU available on iOS 11+.
9
10         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
11
12 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
13
14         [ews-build] Do not upload archive when Compile Fails
15         https://bugs.webkit.org/show_bug.cgi?id=196674
16
17         Reviewed by Alexey Proskuryakov.
18
19         * BuildSlaveSupport/ews-build/factories.py:
20         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
21         * BuildSlaveSupport/ews-build/steps.py:
22         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
23         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
24         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
25
26 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
27
28         Enable DFG on MIPS
29         https://bugs.webkit.org/show_bug.cgi?id=196689
30
31         Reviewed by Žan Doberšek.
32
33         Since the bytecode change, we enabled the baseline JIT on mips in
34         r240432, but DFG is still missing. With this change, all tests are
35         passing on a ci20 board.
36
37         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
38
39 2019-04-08  Philippe Normand  <pnormand@igalia.com>
40
41         [Flatpak] Second run update-webkitwpe-flatpak fails
42         https://bugs.webkit.org/show_bug.cgi?id=192702
43
44         Reviewed by Carlos Garcia Campos.
45
46         * flatpak/flatpakutils.py:
47         (FlatpakObject.flatpak): Fix typo.
48         (FlatpakPackage.install): When installing, also update to the configured remote commit.
49         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
50
51 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
52
53         [GTK][WPE] outlook.live.com displays old-fashioned UI
54         https://bugs.webkit.org/show_bug.cgi?id=196642
55
56         Reviewed by Carlos Garcia Campos.
57
58         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
59         (TestWebKitAPI::TEST): New Mac platform quirk test.
60
61 2019-04-07  Commit Queue  <commit-queue@webkit.org>
62
63         Unreviewed, rolling out r243956.
64         https://bugs.webkit.org/show_bug.cgi?id=196688
65
66         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
67         by aakashjain on #webkit).
68
69         Reverted changeset:
70
71         "Clicking "Go Back" from a safe browsing warning from an
72         iframe should navigate the WKWebView back to the previous
73         page"
74         https://bugs.webkit.org/show_bug.cgi?id=196665
75         https://trac.webkit.org/changeset/243956
76
77 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
78
79         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
80         https://bugs.webkit.org/show_bug.cgi?id=196669
81
82         Reviewed by Geoffrey Garen.
83
84         Added three new unit tests for WeakHashSet.
85
86         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
87         (WTF_WeakPtr.WeakHashSetConstObjects):
88         (WTF_WeakPtr.WeakHashSetComputesEmpty):
89         (WTF_WeakPtr.WeakHashSetComputeSize):
90
91 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
92
93         Hide next and previous form control buttons when WKWebView is editable
94         https://bugs.webkit.org/show_bug.cgi?id=196672
95         <rdar://problem/35625321>
96
97         Reviewed by Tim Horton.
98
99         Add a new API test.
100
101         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
102         (-[TestWKWebView lastTrailingBarButtonGroup]):
103         (TestWebKitAPI::TEST):
104         * TestWebKitAPI/ios/UIKitSPI.h:
105
106 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
107
108         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
109         https://bugs.webkit.org/show_bug.cgi?id=196077
110         <rdar://problem/49108202>
111
112         Reviewed by Chris Dumez.
113
114         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
115         on new web view.
116
117         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
118
119 2019-04-05  Saam Barati  <sbarati@apple.com>
120
121         Make compare-results understand MotionMark
122         https://bugs.webkit.org/show_bug.cgi?id=196666
123
124         Reviewed by Yusuke Suzuki.
125
126         * Scripts/compare-results:
127         (PLT5Results):
128         (detectMotionMark):
129         (detectMotionMark1_1):
130         (motionMarkResults):
131         (motionMark1_1Results):
132         (detectBenchmark):
133         (biggerIsBetter):
134         (main):
135
136 2019-04-05  Alex Christensen  <achristensen@webkit.org>
137
138         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
139         https://bugs.webkit.org/show_bug.cgi?id=196665
140         <rdar://45115669>
141
142         Reviewed by Geoff Garen.
143
144         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
145         (goBack):
146         (+[SimpleLookupContext sharedLookupContext]):
147         (-[SimpleLookupContext lookUpURL:completionHandler:]):
148         (TEST):
149         (+[Simple3LookupContext sharedLookupContext]): Deleted.
150         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
151
152 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
153
154         [ews-build] Add configuration and architecture for windows builders
155         https://bugs.webkit.org/show_bug.cgi?id=196660
156
157         Reviewed by Lucas Forschler.
158
159         * BuildSlaveSupport/ews-build/config.json:
160
161 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
162
163         webkitpy: Don't run subsequent rounds if interrupted
164         https://bugs.webkit.org/show_bug.cgi?id=196646
165
166         Reviewed by Aakash Jain.
167
168         * Scripts/webkitpy/layout_tests/controllers/manager.py:
169         (Manager.run): Bail out if interrupted.
170
171 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
172
173         Test sessionStorage in PSON private browsing mode
174         https://bugs.webkit.org/show_bug.cgi?id=196561
175
176         Reviewed by Alex Christensen.
177
178         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
179
180 2019-04-05  Commit Queue  <commit-queue@webkit.org>
181
182         Unreviewed, rolling out r243833.
183         https://bugs.webkit.org/show_bug.cgi?id=196645
184
185         This change breaks build of WPE and GTK ports (Requested by
186         annulen on #webkit).
187
188         Reverted changeset:
189
190         "[CMake][WTF] Mirror XCode header directories"
191         https://bugs.webkit.org/show_bug.cgi?id=191662
192         https://trac.webkit.org/changeset/243833
193
194 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
195
196         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
197         https://bugs.webkit.org/show_bug.cgi?id=196635
198
199         Reviewed by Antti Koivisto.
200         
201         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
202         for a test to enable async frame scrolling via:
203             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
204         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
205         
206         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
207
208         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
209         (WTR::InjectedBundle::beginTesting):
210         * WebKitTestRunner/TestController.cpp:
211         (WTR::TestController::resetPreferencesToConsistentValues):
212
213 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
214
215         Use a correct LC_RPATH when building with ASan
216         https://bugs.webkit.org/show_bug.cgi?id=196576
217
218         Reviewed by David Kilzer.
219
220         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
221         so that ../Frameworks is checked. This is simpler and more reliable than updating
222         each SPC service xcconfig.
223
224 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
225
226         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
227         https://bugs.webkit.org/show_bug.cgi?id=196629
228
229         Reviewed by Lucas Forschler.
230
231         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
232
233 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
234
235         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
236         https://bugs.webkit.org/show_bug.cgi?id=196618
237
238         Reviewed by Lucas Forschler.
239
240         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
241         (StatusBubble): Added QUEUE_TRIGGERS.
242         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
243         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
244         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
245         its parent(builder).
246
247 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
248
249         [ews-app] Status-bubble steps are sometimes displayed in reverse order
250         https://bugs.webkit.org/show_bug.cgi?id=196625
251
252         Reviewed by Lucas Forschler.
253
254         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
255         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
256
257 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
258
259         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
260         https://bugs.webkit.org/show_bug.cgi?id=196630
261
262         Reviewed by Wenson Hsieh.
263
264         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
265
266 2019-04-04  Youenn Fablet  <youenn@apple.com>
267
268         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
269         https://bugs.webkit.org/show_bug.cgi?id=196543
270
271         Reviewed by Alex Christensen.
272
273         * WebKitTestRunner/TestController.cpp:
274         (WTR::TestController::generatePageConfiguration):
275
276 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
277
278         [ews-app] Status bubble should not display skipped buildbot steps
279         https://bugs.webkit.org/show_bug.cgi?id=196584
280
281         Reviewed by Lucas Forschler.
282
283         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
284
285 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
286
287         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
288         https://bugs.webkit.org/show_bug.cgi?id=196620
289
290         Reviewed by Lucas Forschler.
291
292         * BuildSlaveSupport/ews-app/ews/config.py:
293
294 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
295
296         [Win] DumpRenderTreeWatchDog.py is not checked into source
297         https://bugs.webkit.org/show_bug.cgi?id=196567
298         <rdar://problem/49525901>
299
300         Reviewed by Lucas Forschler.
301
302         This script is used on Win EWS bots to terminate hanging DRT processes.
303
304         * EWSTools/dumprendertreewatchdog.py: Added.
305
306 2019-04-04  Chris Dumez  <cdumez@apple.com>
307
308         Unreviewed, roll out r243858 which made tests time out.
309
310         Disable new API tests on Windows instead.
311
312         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
313         (TestWebKitAPI::TEST):
314
315 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
316
317         [ATK] Cleanup WebPageAccessibilityObjectAtk
318         https://bugs.webkit.org/show_bug.cgi?id=196537
319
320         Reviewed by Michael Catanzaro.
321
322         Also consider files under atk directories as exceptions for GObject conventions.
323
324         * Scripts/webkitpy/style/checkers/cpp.py:
325         (check_identifier_name_in_declaration):
326
327 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
328
329         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
330         https://bugs.webkit.org/show_bug.cgi?id=196588
331         <rdar://problem/49365787>
332
333         Unreviewed build fix for Windows port.
334
335         error C3861: 'kill': identifier not found
336
337         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
338         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
339
340 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
341
342         [ews-build] Cancel build and similar operations should have authentication
343         https://bugs.webkit.org/show_bug.cgi?id=196520
344
345         Reviewed by Dewei Zhu.
346
347         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
348         environment variables.
349
350 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
351
352         [ews-build] Do not trigger queues which are not in production yet
353         https://bugs.webkit.org/show_bug.cgi?id=196581
354
355         Reviewed by Dewei Zhu.
356
357         * BuildSlaveSupport/ews-build/config.json:
358
359 2019-04-03  Chris Dumez  <cdumez@apple.com>
360
361         Unreviewed, fix typo in the name of API test added in r243848.
362
363         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
364         (TestWebKitAPI::TEST):
365
366 2019-04-03  Chris Dumez  <cdumez@apple.com>
367
368         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
369         https://bugs.webkit.org/show_bug.cgi?id=196588
370         <rdar://problem/49365787>
371
372         Reviewed by Ryosuke Niwa.
373
374         Add API test coverage.
375
376         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
377         (TestWebKitAPI::nullJavaScriptCallback):
378         (TestWebKitAPI::didCrashCheckFrames):
379         (TestWebKitAPI::TEST):
380
381 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
382
383         run-webkit-tests: Upload test results (new results database)
384         https://bugs.webkit.org/show_bug.cgi?id=196577
385         <rdar://problem/34841155>
386
387         Reviewed by Lucas Forschler.
388
389         * Scripts/webkitpy/layout_tests/controllers/manager.py:
390         (Manager.run): Upload results after each device shard, since the configuration will be
391         different for each device.
392         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
393         uploaded to a results database.
394         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
395         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
396
397 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
398
399         -apple-trailing-word is needed for browser detection
400         https://bugs.webkit.org/show_bug.cgi?id=196575
401
402         Unreviewed.
403
404         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
405
406 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
407
408         [CMake][WTF] Mirror XCode header directories
409         https://bugs.webkit.org/show_bug.cgi?id=191662
410
411         Reviewed by Konstantin Tokarev.
412
413         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
414         builds.
415
416         * CMakeLists.txt:
417         * DumpRenderTree/CMakeLists.txt:
418         * DumpRenderTree/PlatformWin.cmake:
419         * MiniBrowser/win/CMakeLists.txt:
420         * TestWebKitAPI/CMakeLists.txt:
421         * TestWebKitAPI/PlatformWin.cmake:
422         * WebKitTestRunner/PlatformGTK.cmake:
423         * WebKitTestRunner/PlatformWin.cmake:
424
425 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
426
427         [ews-app] Status bubble should not display certain infrastructure status messages
428         https://bugs.webkit.org/show_bug.cgi?id=196550
429
430         Reviewed by Lucas Forschler.
431
432         Do not display the steps which are un-needed for end-user. This information is still avaiable
433         if the user click on the bubble and look at the Buildbot build.
434         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
435         (StatusBubble._steps_messages):
436         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
437
438 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
439
440         [ews-build] Use https for sending data to ews-app
441         https://bugs.webkit.org/show_bug.cgi?id=196492
442
443         Reviewed by Lucas Forschler.
444
445         * BuildSlaveSupport/ews-build/events.py:
446
447 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
448
449         Remove support for -apple-trailing-word
450         https://bugs.webkit.org/show_bug.cgi?id=196525
451
452         Reviewed by Zalan Bujtas.
453
454         This CSS property is nonstandard and not used.
455
456         * Scripts/webkitperl/FeatureList.pm:
457         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
458
459 2019-04-03  Youenn Fablet  <youenn@apple.com>
460
461         Add a test for DOMCache on multiple browsing in case of private browsing
462         https://bugs.webkit.org/show_bug.cgi?id=196524
463
464         Reviewed by Alex Christensen.
465
466         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
467         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
468
469 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
470
471         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
472         https://bugs.webkit.org/show_bug.cgi?id=196540
473
474         Reviewed by Aakash Jain.
475
476         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
477
478 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
479
480         Add plumbing for a compatibility mode preference in WebKit
481         https://bugs.webkit.org/show_bug.cgi?id=196005
482
483         Reviewed by Tim Horton.
484
485         Add new API tests.
486
487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
488         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
489
490 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
491
492         [WPE][GTK] Update libsrtp dependency package for Debian
493         https://bugs.webkit.org/show_bug.cgi?id=196528
494
495         Reviewed by Frédéric Wang.
496
497         * gtk/install-dependencies:
498         * wpe/install-dependencies:
499
500 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
501
502         [WK2] Add support for Window's beforeprint / afterprint events
503         https://bugs.webkit.org/show_bug.cgi?id=196478
504         <rdar://problem/49535124>
505
506         Unreviewed build fix for MSVC.
507
508         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
509
510         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
511
512         * WebKitTestRunner/TestController.cpp:
513         (WTR::printFrame): Use int and float literals.
514
515 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
516
517         [ews-build] Reassign bots to queues
518
519         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
520
521 2019-04-02  Chris Dumez  <cdumez@apple.com>
522
523         [WK2] Add support for Window's beforeprint / afterprint events
524         https://bugs.webkit.org/show_bug.cgi?id=196478
525
526         Reviewed by Alex Christensen.
527
528         Add minimal implementation for printFrame in WebKitTestRunner.
529
530         * WebKitTestRunner/TestController.cpp:
531         (WTR::printFrame):
532         (WTR::TestController::createOtherPage):
533         (WTR::TestController::createWebViewWithOptions):
534
535 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
536
537         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
538         https://bugs.webkit.org/show_bug.cgi?id=196491
539
540         Reviewed by Lucas Forschler.
541
542         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
543
544 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
545
546         [ews-build] Configure buildbot try credentials in environment variables
547         https://bugs.webkit.org/show_bug.cgi?id=196501
548
549         Reviewed by Lucas Forschler.
550
551         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
552         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
553         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
554
555 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
556
557         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
558         https://bugs.webkit.org/show_bug.cgi?id=196496
559         <rdar://problem/49521634>
560
561         Reviewed by Chris Dumez.
562
563         Add new API tests (see WebKit ChangeLog for more detail).
564
565         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
566         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
567         (TEST):
568
569 2019-04-02  David Kilzer  <ddkilzer@apple.com>
570
571         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
572         <https://webkit.org/b/196499>
573
574         Reviewed by Alexey Proskuryakov.
575
576         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
577         ENABLE_ADDRESS_SANITIZER.
578
579 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
580
581         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
582         https://bugs.webkit.org/show_bug.cgi?id=182757
583
584         Reviewed by Don Olmstead.
585
586         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
587         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
588
589 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
590
591         run-api-tests: Upload test results
592         https://bugs.webkit.org/show_bug.cgi?id=196323
593         <rdar://problem/49356714>
594
595         Reviewed by Lucas Forschler.
596
597         * Scripts/webkitpy/api_tests/manager.py:
598         (Manager):
599         (Manager.run): Upload results to a results database.
600         * Scripts/webkitpy/api_tests/run_api_tests.py:
601         (parse_args): Add upload arguments.
602         * Scripts/webkitpy/port/base.py:
603         (Port):
604         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
605         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
606         with commits from any other associated repositories.
607         * Scripts/webkitpy/port/device.py:
608         (Device):
609         (Device.build_version): Access build_versoin of underlying platform device.
610         * Scripts/webkitpy/port/ios_simulator_unittest.py:
611         (IOSSimulatorTest):
612         (IOSSimulatorTest.test_configuration_for_upload):
613         * Scripts/webkitpy/port/device_port.py:
614         (DevicePort):
615         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
616         the same as the machine uploading results.
617         * Scripts/webkitpy/port/mac.py:
618         (MacPort):
619         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
620         * Scripts/webkitpy/port/mac_unittest.py:
621         (MacTest):
622         (MacTest.test_configuration_for_upload):
623         * Scripts/webkitpy/xcode/simulated_device.py:
624         (SimulatedDeviceManager._create_device_with_runtime):
625         (SimulatedDevice.__init__): Create simulated device with a build_version.
626         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
627         (test_existing_simulator):
628
629 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
630
631         Remove extra newline characters (Follow-up fix to r243707)
632
633         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
634
635 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
636
637         [ews-app] Use API_KEY to accept results data
638         https://bugs.webkit.org/show_bug.cgi?id=196461
639
640         Reviewed by Dewei Zhu.
641
642         * BuildSlaveSupport/ews-app/ews/views/results.py:
643         (Results.post): Validate EWS_API_KEY before accepting any data.
644         * BuildSlaveSupport/ews-build/events.py:
645         (Events.sendData): Send EWS_API_KEY if available along with event data.
646
647 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
648
649         Unable to copy and paste a PDF from Notes into Mail compose body
650         https://bugs.webkit.org/show_bug.cgi?id=196442
651         <rdar://problem/48573098>
652
653         Reviewed by Tim Horton.
654
655         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
656         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
657         to be specified on the item providers.
658
659         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
660         (TestWebKitAPI::mapItemForTesting):
661         (TestWebKitAPI::contactItemForTesting):
662
663 2019-04-01  Tim Horton  <timothy_horton@apple.com>
664
665         Make UIWKDocumentContext rects per-character instead of per-word
666         https://bugs.webkit.org/show_bug.cgi?id=196459
667
668         Reviewed by Wenson Hsieh.
669
670         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
671         (TEST):
672         Adjust test results due to switching to per-character rects.
673
674 2019-04-01  Chris Dumez  <cdumez@apple.com>
675
676         UIProcess crash when a prewarmed process is terminated
677         https://bugs.webkit.org/show_bug.cgi?id=196451
678         <rdar://problem/49245471>
679
680         Reviewed by Geoffrey Garen.
681
682         Add API test coverage.
683
684         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
685         (TEST):
686
687 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
688
689         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
690         https://bugs.webkit.org/show_bug.cgi?id=196449
691
692         Reviewed by Lucas Forschler.
693
694         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
695         (StatusBubble.get_os_details): Method to get OS and Xcode details.
696         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
697         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
698
699 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
700
701         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
702         https://bugs.webkit.org/show_bug.cgi?id=196444
703
704         Reviewed by Lucas Forschler.
705
706         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
707
708 2019-04-01  Alex Christensen  <achristensen@webkit.org>
709
710         Add SPI to canonicalize NSURLs with WTF::URL
711         https://bugs.webkit.org/show_bug.cgi?id=196415
712         <rdar://problem/44980271>
713
714         Reviewed by Darin Adler.
715
716         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
717         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
718         (TestWebKitAPI::TEST):
719
720 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
721
722         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
723         https://bugs.webkit.org/show_bug.cgi?id=196441
724
725         Reviewed by Carlos Garcia Campos.
726
727         Don't cache the wpe_view_backend object that might not exist yet at the
728         time of EventSenderProxy constructor invocation, but instead retrieve
729         that object whenever it's required for event dispatching. This should
730         avoid crashes in this constructor now that it's invoked before any
731         PlatformWindow has been set up (as changed in r243496).
732
733         * WebKitTestRunner/EventSenderProxy.h:
734         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
735         (WTR::viewBackend):
736         (WTR::EventSenderProxy::EventSenderProxy):
737         (WTR::EventSenderProxy::mouseDown):
738         (WTR::EventSenderProxy::mouseUp):
739         (WTR::EventSenderProxy::mouseMoveTo):
740         (WTR::EventSenderProxy::mouseScrollBy):
741         (WTR::EventSenderProxy::keyDown):
742         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
743
744 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
745
746         [Win][WebKit] MiniBrowser should support high DPI display
747         https://bugs.webkit.org/show_bug.cgi?id=196391
748
749         Reviewed by Alex Christensen.
750
751         * MiniBrowser/win/WebKitBrowserWindow.cpp:
752         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
753         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
754         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
755
756 2019-03-31  Sam Weinig  <weinig@apple.com>
757
758         Remove more i386 specific configurations
759         https://bugs.webkit.org/show_bug.cgi?id=196430
760
761         Reviewed by Alexey Proskuryakov.
762
763         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
764         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
765
766 2019-03-31  Andy Estes  <aestes@apple.com>
767
768         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
769         https://bugs.webkit.org/show_bug.cgi?id=196433
770         <rdar://problem/49293305>
771
772         Reviewed by Tim Horton.
773
774         Enhanced API test coverage to include all navigation response policy decisions in both
775         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
776
777         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
778         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
779         (TestWebKitAPI::TEST):
780         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
781         (readFile):
782         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
783         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
784         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
785         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
786         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
787         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
788         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
789         (-[QuickLookDelegate _downloadDidStart:]):
790         (-[QuickLookDelegate _download:didReceiveResponse:]):
791         (-[QuickLookDelegate _download:didReceiveData:]):
792         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
793         (-[QuickLookDelegate _downloadDidFinish:]):
794         (-[QuickLookDelegate _download:didFailWithError:]):
795         (-[QuickLookDelegate _downloadDidCancel:]):
796         (-[QuickLookDelegate verifyDownload]):
797         (runTest):
798         (runTestDecideBeforeLoading):
799         (runTestDecideAfterLoading):
800         (TEST):
801         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
802         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
803         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
804         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
805         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
806         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
807         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
808         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
809         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
810         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
811         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
812         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
813         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
814         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
815
816 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
817
818         [CMake] add testdfg as target with build-jsc
819         https://bugs.webkit.org/show_bug.cgi?id=196393
820
821         Reviewed by Saam Barati.
822
823         Added testdfg as one of the targets to build when
824         using CMake.
825
826         * Scripts/build-jsc:
827
828 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
829
830         Delete WebMetal implementation in favor of WebGPU
831         https://bugs.webkit.org/show_bug.cgi?id=195418
832
833         Reviewed by Dean Jackson.
834
835         * DumpRenderTree/mac/DumpRenderTree.mm:
836         (enableExperimentalFeatures):
837         (resetWebPreferencesToConsistentValues):
838         * Scripts/webkitperl/FeatureList.pm:
839         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
841         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
842         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
843         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
844         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
845         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
846         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
847         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
848         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
849         (WTR::InjectedBundle::beginTesting):
850         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
851         (WTR::TestRunner::setWebMetalEnabled): Deleted.
852         * WebKitTestRunner/InjectedBundle/TestRunner.h:
853
854 2019-03-29  Chris Dumez  <cdumez@apple.com>
855
856         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
857         https://bugs.webkit.org/show_bug.cgi?id=196405
858         <rdar://problem/49428130>
859
860         Reviewed by Wenson Hsieh.
861
862         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
863         the popover presentation methods to be no-ops. Use this in the new test added in
864         r243523 so that we do not swizzle those methods for all tests. This is needed because
865         those WatchOS tests rely on the popover getting presented and interactive.
866
867         * WebKitTestRunner/TestController.cpp:
868         (WTR::updateTestOptionsFromTestHeader):
869         * WebKitTestRunner/TestController.h:
870         * WebKitTestRunner/TestOptions.h:
871         (WTR::TestOptions::hasSameInitializationOptions const):
872         * WebKitTestRunner/ios/TestControllerIOS.mm:
873         (WTR::TestController::platformInitialize):
874         (WTR::TestController::platformResetStateToConsistentValues):
875
876 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
877
878         [Curl] Add Server Trust Evaluation Support.
879         https://bugs.webkit.org/show_bug.cgi?id=191646
880
881         Reviewed by Fujii Hironori.
882
883         Implemented MiniBrowser UI for asking if user trusts the server.
884
885         * MiniBrowser/win/Common.cpp:
886         (askServerTrustEvaluation):
887         (replaceString):
888         * MiniBrowser/win/Common.h:
889         * MiniBrowser/win/MiniBrowserLib.rc:
890         * MiniBrowser/win/MiniBrowserLibResource.h:
891         * MiniBrowser/win/WebKitBrowserWindow.cpp:
892         (createPEMString):
893         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
894         (WebKitBrowserWindow::canTrustServerCertificate):
895         * MiniBrowser/win/WebKitBrowserWindow.h:
896
897 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
898
899         Implement ResizeObserver.
900         https://bugs.webkit.org/show_bug.cgi?id=157743
901
902         Reviewed by Simon Fraser.
903
904         Support resizeObserverEnabled webPreferences.
905
906         * DumpRenderTree/TestOptions.cpp:
907         (TestOptions::TestOptions):
908         * DumpRenderTree/TestOptions.h:
909         * DumpRenderTree/mac/DumpRenderTree.mm:
910         (setWebPreferencesForTestOptions):
911         * DumpRenderTree/win/DumpRenderTree.cpp:
912         (enableExperimentalFeatures):
913         * Scripts/webkitperl/FeatureList.pm:
914         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
915
916 2019-03-28  John Wilander  <wilander@apple.com>
917
918         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
919         https://bugs.webkit.org/show_bug.cgi?id=196281
920         <rdar://problem/48938748>
921
922         Reviewed by Alex Christensen.
923
924         This patch adds the function isStatisticsHasLocalStorage() to the
925         TestRunner. With it, the page can query the WebsiteDataStore in the
926         UI process to make sure that it sees LocalStorage.
927
928         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
929         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
930         (WTR::TestRunner::isStatisticsHasLocalStorage):
931         * WebKitTestRunner/InjectedBundle/TestRunner.h:
932         * WebKitTestRunner/TestController.cpp:
933         (WTR::TestController::isStatisticsHasLocalStorage):
934         * WebKitTestRunner/TestController.h:
935         * WebKitTestRunner/TestInvocation.cpp:
936         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
937
938 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
939
940         API::Data::createWithoutCopying should do a null check before calling CFRelease
941         https://bugs.webkit.org/show_bug.cgi?id=196276
942         <rdar://problem/48059859>
943
944         Reviewed by Alex Christensen.
945
946         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
947
948         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
949         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
950         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
951         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
952         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
953         (TestWebKitAPI::TEST):
954
955 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
956
957         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
958         https://bugs.webkit.org/show_bug.cgi?id=186276
959
960         Reviewed by Carlos Garcia Campos.
961
962         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
963         (webViewLoadChanged):
964         (testWebResourceGetDataError):
965         (testWebResourceGetDataEmpty):
966         (beforeAll):
967         (webViewloadChanged): Deleted.
968
969 2019-03-27  Andy Estes  <aestes@apple.com>
970
971         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
972         https://bugs.webkit.org/show_bug.cgi?id=196317
973
974         Reviewed by Dan Bernstein.
975
976         package-root copies built products into a staging directory using ditto(1), which does not
977         follow symbolic links as it traverses a directory. Now that the files in
978         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
979         itself, these become broken links when ditto'd into the staging directory.
980
981         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
982
983         * Scripts/package-root:
984
985 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
986
987         [ews-app] Update display text of Submit for ews analysis
988         https://bugs.webkit.org/show_bug.cgi?id=196309
989
990         Reviewed by Dewei Zhu.
991
992         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
993
994 2019-03-27  David Kilzer  <ddkilzer@apple.com>
995
996         run-webkit-tests should check for leaks in WebKit processes
997         <https://webkit.org/b/193772>
998         <rdar://problem/46526680>
999
1000         Reviewed by Ryosuke Niwa.
1001
1002         This works by doing the following:
1003         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1004           The list of child processes are returned one per line:
1005           process.name: pid
1006         - Run the "#LIST CHILD PROCESSES" command just before the
1007           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1008           processes on the ServerProcess object.
1009         - When the `--leaks` switch is handled, run check_for_leaks() on
1010           each child process after the main test harness.
1011
1012         * DumpRenderTree/mac/DumpRenderTree.mm:
1013         (handleControlCommand):
1014         - Use strncmp() instead of strcmp().
1015         - Add support for handling "#LIST CHILD PROCESSES" command.
1016
1017         * Scripts/webkitpy/port/base.py:
1018         (Port.check_for_leaks):
1019         * Scripts/webkitpy/port/darwin.py:
1020         (DarwinPort.check_for_leaks):
1021         - Rename redundant 'process_pid' argument to 'process_id'.
1022
1023         * Scripts/webkitpy/port/driver.py:
1024         (Driver.do_post_tests_work):
1025         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1026           longer the only command this sends to WebKitTestRunner.
1027         - If the `--leaks` switch is present, send the
1028           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1029           result using Port.set_webkit_processes().
1030         (Driver._parse_child_processes_output):
1031         - Add helper method to parse list of child process names and
1032           process IDs returned from WebKitTestRunner.
1033
1034         * Scripts/webkitpy/port/ios_device.py:
1035         (IOSDevicePort.check_for_leaks):
1036         - Rename redundant 'process_pid' argument to 'process_id'.
1037
1038         * Scripts/webkitpy/port/leakdetector.py:
1039         (LeakDetector._parse_leaks_output):
1040         - Return early if there is no leaks_output.
1041         (LeakDetector.check_for_leaks):
1042         - Rename redundant 'process_pid' argument to 'process_id'.
1043
1044         * Scripts/webkitpy/port/server_process.py:
1045         (ServerProcess.__init__):
1046         (ServerProcess.child_processes):
1047         (ServerProcess.set_child_processes):
1048         - Add instance variable to Port to store list of child process
1049           names and process IDs returned from WebKitTestRunner.
1050         (ServerProcess._start):
1051         - Clear self._child_processes.
1052         (ServerProcess.stop):
1053         - If self._child_processes is set, call
1054           self._port.check_for_leaks() for each child process.
1055
1056         * Scripts/webkitpy/port/server_process_unittest.py:
1057         (TrivialMockPort.check_for_leaks):
1058         - Rename redundant 'process_pid' argument to 'process_id'.
1059
1060         * Scripts/webkitpy/port/simulator_process.py:
1061         (SimulatorProcess.stop):
1062         - If self._child_processes is set, call
1063           self._port.check_for_leaks() for each child process.
1064
1065         * Scripts/webkitpy/port/watch_device.py:
1066         (WatchDevicePort.check_for_leaks):
1067         - Rename redundant 'process_pid' argument to 'process_id'.
1068
1069         * WebKitTestRunner/TestController.cpp:
1070         (WTR::TestController::dumpResponse):
1071         - Extract method from findAndDumpWorldLeaks() so that it may be
1072           reused by findAndDumpWebKitProcessIdentifiers().
1073         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1074         - Add method to output process name and process ID of both the
1075           WebContent and Networking processes.
1076         (WTR::TestController::findAndDumpWorldLeaks):
1077         - Fix missing newline in output when there were no abandoned
1078           documents.
1079         - Call dumpResponse() for extracted code.
1080         (WTR::TestController::handleControlCommand):
1081         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1082         - Use strncmp() instead of strcmp().
1083         - Call findAndDumpWebKitProcessIdentifiers() when
1084           "#LIST CHILD PROCESSES" command is sent.
1085         * WebKitTestRunner/TestController.h:
1086         (WTR::TestController::dumpResponse):
1087         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1088         - Declare methods.
1089
1090 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1091
1092         Unreviewed. Add GLib API test cases after r243434.
1093
1094         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1095         (testWebViewActiveURI):
1096         (serverCallback):
1097         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1098         (sendRequestCallback):
1099
1100 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1101
1102         Geolocation request not complete when watch request was started in a different web process
1103         https://bugs.webkit.org/show_bug.cgi?id=195996
1104
1105         Reviewed by Alex Christensen.
1106
1107         Add a test case.
1108
1109         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1110         (TestWebKitAPI::runJavaScriptAlert):
1111         (TestWebKitAPI::TEST):
1112
1113 2019-03-26  Keith Rollin  <krollin@apple.com>
1114
1115         Update the way generate-xcfilelists returns strings from functions
1116         https://bugs.webkit.org/show_bug.cgi?id=195975
1117         <rdar://problem/49040807>
1118
1119         Reviewed by Dean Jackson.
1120
1121         There are places where generate-xcfilelists executes assignments with
1122         statements like:
1123
1124             FOO=$(some_function)
1125
1126         where "some_function" return a string by echoing it. E.g.
1127
1128             some_function()
1129             {
1130                 echo "Hello, World"
1131             }
1132
1133         This is a common idiom, but it has a problem if "some_function" needs
1134         to call "exit" in an attempt to halt the entire script right then and
1135         there. Since "some_function" is called inside of $(), it's being
1136         executed in a sub-shell. Calling exit in that sub-shell simply exits
1137         that shell; it doesn't not exit the outer shell in which the main part
1138         of the script is still running. As such, the main script keeps
1139         executing when the intent was for the script to halt.
1140
1141         The solution to this is to use a different idiom for returning
1142         strings. The one we now is to pass in the name of the variable to
1143         receive the string result:
1144
1145             some_function()
1146             {
1147                 variable_name=$1
1148                 eval $variable_name ="Hello, World"
1149             }
1150
1151         The call site now looks like
1152
1153             some_function FOO
1154
1155         Because there's no invocation of a sub-shell, some_function can now
1156         call "exit" if it wants to, and the entire script will exit at that
1157         point.
1158
1159         * Scripts/generate-xcfilelists:
1160
1161 2019-03-26  Chris Dumez  <cdumez@apple.com>
1162
1163         Add basic layout test coverage for File Picker on iOS
1164         https://bugs.webkit.org/show_bug.cgi?id=196265
1165
1166         Reviewed by Wenson Hsieh.
1167
1168         Add layout test infrastructure to test the file picker on iOS.
1169
1170         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1171         (WTR::UIScriptController::dismissFilePicker):
1172         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1173         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1174         (WTR::UIScriptController::dismissFilePicker):
1175         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1176         * WebKitTestRunner/TestController.cpp:
1177         (WTR::TestController::createWebViewWithOptions):
1178         (WTR::updateTestOptionsFromTestHeader):
1179         * WebKitTestRunner/TestOptions.h:
1180         (WTR::TestOptions::hasSameInitializationOptions const):
1181         * WebKitTestRunner/ios/TestControllerIOS.mm:
1182         (overridePresentViewController):
1183         (WTR::TestController::platformInitialize):
1184         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1185         (WTR::UIScriptController::dismissFilePicker):
1186
1187 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1188
1189         Implement async paste method on UIWKInteractionViewProtocol
1190         https://bugs.webkit.org/show_bug.cgi?id=196267
1191         <rdar://problem/49236346>
1192
1193         Reviewed by Tim Horton.
1194
1195         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1196         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1197         are now a part of all iOS 12 internal SDKs.
1198
1199         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1200
1201         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1202         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1203
1204         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1205         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1206         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1207         * TestWebKitAPI/ios/UIKitSPI.h:
1208
1209 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1210
1211         [ews-build] Use PostgreSQL for ews.webkit.org database
1212         https://bugs.webkit.org/show_bug.cgi?id=196270
1213
1214         Reviewed by Lucas Forschler.
1215
1216         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1217
1218 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1219
1220         [ews] Reset simctl states on reboot
1221         https://bugs.webkit.org/show_bug.cgi?id=196260
1222
1223         Rubber-stamped by Aakash Jain.
1224
1225         * EWSTools/start-queue-mac.sh:
1226
1227 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1228
1229         [ews-build] Use PostgreSQL for ews-build database
1230         https://bugs.webkit.org/show_bug.cgi?id=196229
1231
1232         Reviewed by Lucas Forschler.
1233
1234         * BuildSlaveSupport/ews-build/master.cfg:
1235
1236 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1237
1238         [ews-build] Get master_hostname dynamically in master.cfg
1239         https://bugs.webkit.org/show_bug.cgi?id=196255
1240
1241         Reviewed by Lucas Forschler.
1242
1243         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1244         send events data in test mode.
1245
1246 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1247
1248         [ews-app] Set db_constraint to False for Foreign Keys
1249         https://bugs.webkit.org/show_bug.cgi?id=196252
1250
1251         Reviewed by Lucas Forschler.
1252
1253         * BuildSlaveSupport/ews-app/ews/models/build.py:
1254         * BuildSlaveSupport/ews-app/ews/models/step.py:
1255
1256 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1257
1258         [ews-build] is_test_mode_enabled should default to True
1259         https://bugs.webkit.org/show_bug.cgi?id=196248
1260
1261         Reviewed by Lucas Forschler.
1262
1263         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1264
1265 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1266
1267         [ews-app] Add webkitperl to ENABLED_QUEUES
1268         https://bugs.webkit.org/show_bug.cgi?id=196253
1269
1270         Reviewed by Lucas Forschler.
1271
1272         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1273
1274 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1275
1276         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1277         https://bugs.webkit.org/show_bug.cgi?id=196211
1278         rdar://problem/49110552
1279
1280         Reviewed by Tim Horton.
1281
1282         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1283         Make sure that EventSenderProxy always exists when running tests. We used to create
1284         it when resetting before the first test, which is a bit too late.
1285
1286         * WebKitTestRunner/TestController.h:
1287         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1288         (WTR::TestController::platformCreateWebView):
1289         (WTR::TestController::platformCreateOtherPage):
1290         (WTR::TestController::finishCreatingPlatformWebView):
1291         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1292         (WTR::PlatformWebView::PlatformWebView):
1293         Moved some code that made NSWindow use NSEvent during web view creation. We may
1294         need to move more if some other case us found, but this is enough for now.
1295
1296 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1297
1298         Unreviewed. Fix typo in GLib geolocation API after r243285.
1299
1300         gelocation -> geolocation.
1301
1302         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1303         (testGeolocationManagerWatchPosition):
1304
1305 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1306
1307         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1308         https://bugs.webkit.org/show_bug.cgi?id=196213
1309
1310         Reviewed by Geoff Garen.
1311
1312         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1313         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1314         (credentialWithIdentityAndKeychainPath):
1315         (-[ChallengeDelegate webView:didFinishNavigation:]):
1316         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1317         (TestWebKitAPI::TEST):
1318
1319 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1320
1321         Expected shouldn't assume its contained types are copyable
1322         https://bugs.webkit.org/show_bug.cgi?id=195986
1323
1324         Reviewed by JF Bastien.
1325
1326         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1327         (TestWebKitAPI::NonCopyable::operator== const):
1328         (TestWebKitAPI::NonCopyable::operator!= const):
1329         (TestWebKitAPI::TEST):
1330
1331 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1332
1333         Remove some now-unnecessary dynamic class lookup
1334         https://bugs.webkit.org/show_bug.cgi?id=196237
1335
1336         Reviewed by Simon Fraser.
1337
1338         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1339         (makeRequest):
1340         (TEST):
1341
1342 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1343
1344         Unreviewed, rolling out r243450.
1345
1346         AppleWin and WinCairo port builds get broken.
1347
1348         Reverted changeset:
1349
1350         "Add test for fix of #196095"
1351         https://bugs.webkit.org/show_bug.cgi?id=196097
1352         https://trac.webkit.org/changeset/243450
1353
1354 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1355
1356         Unreviewed, rolling out r243465.
1357         https://bugs.webkit.org/show_bug.cgi?id=196226
1358
1359         the test doesn't build (Requested by thorton on #webkit).
1360
1361         Reverted changeset:
1362
1363         "Do not terminate the NetworkProcess if a third party
1364         application sends a NSCredential with a SecIdentityRef"
1365         https://bugs.webkit.org/show_bug.cgi?id=196213
1366         https://trac.webkit.org/changeset/243465
1367
1368 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1369
1370         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1371         https://bugs.webkit.org/show_bug.cgi?id=196213
1372
1373         Reviewed by Geoff Garen.
1374
1375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1376         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1377         (credentialWithIdentityAndKeychainPath):
1378         (-[ChallengeDelegate webView:didFinishNavigation:]):
1379         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1380         (TestWebKitAPI::TEST):
1381
1382 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1383
1384         [ews-build] Gracefully handle missing patch_id in events
1385         https://bugs.webkit.org/show_bug.cgi?id=196216
1386
1387         Reviewed by Lucas Forschler.
1388
1389         * BuildSlaveSupport/ews-build/events.py:
1390
1391 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1392
1393         [ews-build] use lz4 compression for improving buildbot performance
1394         https://bugs.webkit.org/show_bug.cgi?id=196155
1395
1396         Reviewed by Lucas Forschler.
1397
1398         * BuildSlaveSupport/ews-build/master.cfg:
1399
1400 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1401
1402         Pull some API testing helper methods out of TestWKWebView
1403         https://bugs.webkit.org/show_bug.cgi?id=196212
1404
1405         Reviewed by Tim Horton.
1406
1407         Refactor some more API testing utility methods, so that they can be used in
1408         tests that do not use TestWKWebView.
1409
1410         * TestWebKitAPI/cocoa/TestWKWebView.h:
1411         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1412         (-[WKWebView loadTestPageNamed:]):
1413         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1414         (-[WKWebView synchronouslyLoadHTMLString:]):
1415         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1416         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1417         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1418         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1419         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1420
1421 2019-03-25  Jer Noble  <jer.noble@apple.com>
1422
1423         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1424         https://bugs.webkit.org/show_bug.cgi?id=196097
1425
1426         Reviewed by Eric Carlson.
1427
1428         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1429
1430         * DumpRenderTree/mac/DumpRenderTree.mm:
1431         (resetWebPreferencesToConsistentValues):
1432         * WebKitTestRunner/TestController.cpp:
1433         (WTR::TestController::resetPreferencesToConsistentValues):
1434
1435 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1436
1437         Pull IPadUserInterfaceSwizzler out into a separate header file
1438         https://bugs.webkit.org/show_bug.cgi?id=196193
1439
1440         Reviewed by Anders Carlsson.
1441
1442         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1443         be used in other API tests.
1444
1445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1446         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1447         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1448         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1449         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1450         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1451         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1452
1453 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1454
1455         Remove NavigatorContentUtils in WebCore/Modules
1456         https://bugs.webkit.org/show_bug.cgi?id=196070
1457
1458         Reviewed by Alex Christensen.
1459
1460         NavigatorContentUtils was to support the custom scheme spec [1].
1461         However, in WebKit side, no port has supported the feature in
1462         WebKit layer after EFL port was removed. So there has been the
1463         only IDL implementation of the NavigatorContentUtils in WebCore.
1464         So we don't need to keep the implementation in WebCore anymore.
1465
1466         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1467
1468         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1469
1470 2019-03-24  Andy Estes  <aestes@apple.com>
1471
1472         [watchOS] Remove unused Proximity Networking code
1473         https://bugs.webkit.org/show_bug.cgi?id=196188
1474
1475         Reviewed by Tim Horton.
1476
1477         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1478         (TEST):
1479
1480 2019-03-23  Keith Miller  <keith_miller@apple.com>
1481
1482         Refactor clz/ctz and fix getLSBSet.
1483         https://bugs.webkit.org/show_bug.cgi?id=196162
1484
1485         Reviewed by Saam Barati.
1486
1487         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1488
1489         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1490         (TestWebKitAPI::TEST):
1491
1492 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1493
1494         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1495         https://bugs.webkit.org/show_bug.cgi?id=196143
1496
1497         Reviewed by Michael Catanzaro.
1498
1499         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1500         directories.
1501
1502         * Scripts/webkitpy/style/checkers/cpp.py:
1503         (check_identifier_name_in_declaration):
1504         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1505         (WebKitStyleTest.test_names):
1506
1507 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1508
1509         [Flatpak] Manifest expanding fails for qt WPE extension
1510         https://bugs.webkit.org/show_bug.cgi?id=196148
1511
1512         Reviewed by Alex Christensen.
1513
1514         * flatpak/flatpakutils.py:
1515         (expand_submodules_recurse): The last recurse manifest expand
1516         iteration might lead to a single module so take it into account
1517         and don't try to recurse further.
1518
1519 2019-03-22  Chris Dumez  <cdumez@apple.com>
1520
1521         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1522         https://bugs.webkit.org/show_bug.cgi?id=195348
1523         <rdar://problem/48622090>
1524
1525         Reviewed by Alex Christensen.
1526
1527         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1528         to NO when test.options().shouldIgnoreMetaViewport is false.
1529
1530         * WebKitTestRunner/ios/TestControllerIOS.mm:
1531         (WTR::TestController::platformConfigureViewForTest):
1532
1533 2019-03-22  Chris Dumez  <cdumez@apple.com>
1534
1535         Prewarmed processes should be usable with any website data store
1536         https://bugs.webkit.org/show_bug.cgi?id=196104
1537
1538         Reviewed by Alex Christensen.
1539
1540         Add API test coverage.
1541
1542         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1543         (runInitialWarmedProcessUsedTest):
1544         (TEST):
1545
1546 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1547
1548         Back out local changes to Alex's Subversion working directory
1549
1550         They were accidentally committed.
1551
1552         * Scripts/webkitpy/common/system/abstractexecutive.py:
1553         (AbstractExecutive.wait_newest):
1554         * Scripts/webkitpy/common/system/executive.py:
1555         (Executive.running_pids):
1556         * Scripts/webkitpy/common/system/executive_mock.py:
1557         (MockExecutive.running_pids):
1558         * Scripts/webkitpy/common/system/executive_unittest.py:
1559         (ExecutiveTest.serial_test_running_pids):
1560         * Scripts/webkitpy/port/darwin.py:
1561         (DarwinPort.check_for_leaks):
1562         * Scripts/webkitpy/port/leakdetector.py:
1563         (LeakDetector.check_for_leaks):
1564         - This was the hack attached to Bug 193772.
1565
1566         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1567         (+[WebKitTestRunnerEvent mouseLocation]):
1568         - This works around a crash on an internal build.
1569
1570 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1571
1572         Fix the build after r243354
1573         https://bugs.webkit.org/show_bug.cgi?id=196138
1574         <rdar://problem/49145951>
1575
1576         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1577         (TEST):
1578         * TestWebKitAPI/ios/UIKitSPI.h:
1579
1580 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1581
1582         Adopt UIWKDocumentContext
1583         https://bugs.webkit.org/show_bug.cgi?id=196040
1584         <rdar://problem/48642440>
1585
1586         Reviewed by Ryosuke Niwa.
1587
1588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1589         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1590         (makeRequest):
1591         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1592         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1593         (applyStyle):
1594         (TEST):
1595         Add tests for UIWKDocumentContext.
1596
1597         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1598         (TEST):
1599         (recursiveFindWKContentView): Deleted.
1600         * TestWebKitAPI/cocoa/TestWKWebView.h:
1601         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1602         (recursiveFindWKContentView):
1603         (-[TestWKWebView wkContentView]):
1604         * TestWebKitAPI/ios/UIKitSPI.h:
1605         Share the WKContentView finding code between tests.
1606
1607 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1608
1609         [iOS WK2] Turn on async overflow scrolling by default
1610         https://bugs.webkit.org/show_bug.cgi?id=196011
1611         rdar://problem/48453859
1612
1613         Reviewed by Antti Koivisto.
1614         
1615         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1616         since so many basic layout tests have different results when compositing is triggered for
1617         overflow.
1618         
1619         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1620
1621         * WebKitTestRunner/TestController.cpp:
1622         (WTR::TestController::resetPreferencesToConsistentValues):
1623
1624 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1625
1626         [ews-build] Retry API test in case of failures
1627         https://bugs.webkit.org/show_bug.cgi?id=196004
1628
1629         Reviewed by Lucas Forschler.
1630
1631         * BuildSlaveSupport/ews-build/steps.py:
1632         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1633         (CompileWebKitToT.doStepIf): Ditto.
1634         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1635         (ReRunAPITests): Re-run API tests.
1636         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1637         (RunAPITestsWithoutPatch): Run API tests without patch.
1638         (RunAPITestsWithoutPatch.doStepIf):
1639         (RunAPITestsWithoutPatch.hideStepIf):
1640         (RunAPITestsWithoutPatch.evaluateCommand):
1641         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1642         (AnalyzeAPITestsResults.start):
1643         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1644         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1645         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1646         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1647
1648 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1649
1650         [ews-build] Update queues configurations
1651         https://bugs.webkit.org/show_bug.cgi?id=196074
1652
1653         Reviewed by Dewei Zhu.
1654
1655         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1656         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1657
1658 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1659
1660         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1661         https://bugs.webkit.org/show_bug.cgi?id=195680
1662         <rdar://problem/48903534>
1663
1664         Unreviewed infrastructure fix.
1665
1666         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1667         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1668
1669 2019-03-21  Andy Estes  <aestes@apple.com>
1670
1671         [iOS] Apple Pay should be available in documents with no user agent scripts
1672         https://bugs.webkit.org/show_bug.cgi?id=196061
1673         <rdar://problem/48649391>
1674
1675         Reviewed by Brady Eidson.
1676
1677         Added API tests and related infrastructure.
1678
1679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1680         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1681         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1682         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1683         (TestWebKitAPI::TEST):
1684         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1685         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1686         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1687         * TestWebKitAPI/cocoa/TestProtocol.mm:
1688         (-[TestProtocol startLoading]):
1689         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1690         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1691         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1692         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1693
1694 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1695
1696         REGRESSSION (r243297): webkitpy tests broken
1697         https://bugs.webkit.org/show_bug.cgi?id=196108
1698
1699         Reviewed by Aakash Jain.
1700
1701         r243297 updated contributors.json, which broke a few unit tests.
1702
1703         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1704         (IRCCommandTest.test_whois):
1705         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1706
1707 2019-03-21  Chris Dumez  <cdumez@apple.com>
1708
1709         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1710         https://bugs.webkit.org/show_bug.cgi?id=196041
1711         <rdar://problem/49083230>
1712
1713         Reviewed by Alex Christensen.
1714
1715         Add API test coverage.
1716
1717         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1718         (TEST):
1719
1720 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1721
1722         Add SPI to inform applications of WKContentRuleList actions
1723         https://bugs.webkit.org/show_bug.cgi?id=195965
1724         <rdar://problem/42664365>
1725
1726         Reviewed by Geoff Garen.
1727
1728         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1729         (TestWebKitAPI::allActionsForResourceLoad):
1730         (TestWebKitAPI::testRequest):
1731         (TestWebKitAPI::TEST_F):
1732         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1733         (Notification::description):
1734         (Notification::operator== const):
1735         (toVector):
1736         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1737         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1738         (makeContentRuleList):
1739         (TEST):
1740         (makeWarnContentRuleList): Deleted.
1741
1742 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1743
1744         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1745         https://bugs.webkit.org/show_bug.cgi?id=196088
1746
1747         Reviewed by Brian Burg.
1748
1749         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1750         Support checks when only one platform is specified. Also deprecate macosx() and
1751         force the use of macos() instead.
1752
1753         * Scripts/webkitpy/style/checkers/cpp.py:
1754         (check_min_versions_of_wk_api_available):
1755         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1756         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1757
1758 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1759
1760         Update status inactive committers' status to 'contributor'.
1761
1762         * Scripts/webkitpy/common/config/contributors.json:
1763
1764 2019-03-21  Xan Lopez  <xan@igalia.com>
1765
1766         [JSC][x86] Drop support for x87 floating point
1767         https://bugs.webkit.org/show_bug.cgi?id=194853
1768
1769         Reviewed by Don Olmstead.
1770
1771         Force SSE2 on x86/32bit builds.
1772
1773         * Scripts/webkitdirs.pm:
1774         (generateBuildSystemFromCMakeProject):
1775
1776 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1777
1778         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1779         https://bugs.webkit.org/show_bug.cgi?id=196073
1780
1781         Reviewed by Michael Catanzaro.
1782
1783         Add test cases to check functions and constructors with no arguments but receiving user data.
1784
1785         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1786         (checkUserData):
1787         (testJSCFunction):
1788         (fooCreateWithUserData):
1789         (testJSCClass):
1790
1791 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1792
1793         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1794
1795         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1796
1797         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1798
1799 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1800
1801         [GTK][WPE] Add API to provide geolocation information
1802         https://bugs.webkit.org/show_bug.cgi?id=195940
1803
1804         Reviewed by Michael Catanzaro.
1805
1806         Add a new test to check the new API.
1807
1808         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1809         (testGeolocationManagerCurrentPosition):
1810         (testGeolocationManagerWatchPosition):
1811         (beforeAll):
1812         (afterAll):
1813         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1814         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1815         (beforeAll): Ditto.
1816         * TestWebKitAPI/glib/CMakeLists.txt:
1817
1818 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1819
1820         [GLib] Returning G_TYPE_OBJECT from a method does not work
1821         https://bugs.webkit.org/show_bug.cgi?id=195574
1822
1823         Reviewed by Michael Catanzaro.
1824
1825         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1826
1827         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1828         (getGFile):
1829         (getParent):
1830         (createGString):
1831         (getGString):
1832         (getGStringCopyWillRaise):
1833         (getGStringCopy):
1834         (getGStringStr):
1835         (getGStringLen):
1836         (freeGString):
1837         (testJSCClass):
1838
1839 2019-03-20  Saam Barati  <sbarati@apple.com>
1840
1841         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1842         https://bugs.webkit.org/show_bug.cgi?id=195721
1843
1844         Reviewed by Filip Pizlo.
1845
1846         * Scripts/run-javascriptcore-tests:
1847
1848 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1849
1850         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1851         https://bugs.webkit.org/show_bug.cgi?id=196049
1852
1853         Reviewed by Tim Horton.
1854
1855         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1856         overflow scrolling in general, so rename it.
1857
1858         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1859
1860 2019-03-20  Daniel Bates  <dabates@apple.com>
1861
1862         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1863         https://bugs.webkit.org/show_bug.cgi?id=196031
1864         <rdar://problem/49078172>
1865
1866         Reviewed by Tim Horton.
1867
1868         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1869         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1870         same code path used when the Done button is pressed to dismiss the <select> picker.
1871
1872         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1873         (TestWebKitAPI::TEST):
1874
1875 2019-03-20  Chris Dumez  <cdumez@apple.com>
1876
1877         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1878         https://bugs.webkit.org/show_bug.cgi?id=196029
1879         <rdar://problem/48954651>
1880
1881         Reviewed by Tim Horton.
1882
1883         Add API test coverage.
1884
1885         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1886
1887 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1888
1889         [ews-build] Improve failure summary string for ApplyPatch step
1890         https://bugs.webkit.org/show_bug.cgi?id=195995
1891
1892         Reviewed by Alexey Proskuryakov.
1893
1894         * BuildSlaveSupport/ews-build/steps.py:
1895         (ApplyPatch.getResultSummary): Override getResultSummary.
1896
1897 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1898
1899         AX: Implement support for new meter ARIA role
1900         https://bugs.webkit.org/show_bug.cgi?id=195966
1901
1902         Reviewed by Chris Fleizach.
1903
1904         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1905         to AXLevelIndicator.
1906
1907         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1908
1909 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1910
1911         [WebAuthN] Implement FIDO AppID extension
1912         https://bugs.webkit.org/show_bug.cgi?id=143491
1913         <rdar://problem/48298273>
1914
1915         Reviewed by Brent Fulgham.
1916
1917         Add a test that covers the new flag of convertToU2fSignCommand.
1918
1919         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1920         (TestWebKitAPI::TEST):
1921         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1922         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1923         (TestWebKitAPI::TEST):
1924
1925 2019-03-19  Keith Rollin  <krollin@apple.com>
1926
1927         Add support for more platforms to generate-xcfilelists
1928         https://bugs.webkit.org/show_bug.cgi?id=195977
1929
1930         Reviewed by Alexey Proskuryakov.
1931
1932         generate-xcfilelists incorrectly complains when involved with building
1933         WebKit for iphonesimulator:
1934
1935             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1936             …
1937             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1938
1939         Address this by teaching generate-xcfilelists about more platforms.
1940
1941         * Scripts/generate-xcfilelists:
1942
1943 2019-03-19  John Wilander  <wilander@apple.com>
1944
1945         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1946         https://bugs.webkit.org/show_bug.cgi?id=195923
1947         <rdar://problem/49001272>
1948
1949         Reviewed by Alex Christensen.
1950
1951         This patch does the following to the TestRunner:
1952         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1953         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1954         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1955
1956         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1957         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1958         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1959         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1960         * WebKitTestRunner/TestController.cpp:
1961         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1962         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1963         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1964         * WebKitTestRunner/TestController.h:
1965         * WebKitTestRunner/TestInvocation.cpp:
1966         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1967
1968 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1969
1970         [CMake] Support more clang and gcc sanitizers
1971         https://bugs.webkit.org/show_bug.cgi?id=195956
1972
1973         Reviewed by Michael Catanzaro.
1974
1975         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1976
1977 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1978
1979         [ews-build] Improve summary for PrintConfiguration step
1980         https://bugs.webkit.org/show_bug.cgi?id=195945
1981
1982         Reviewed by Lucas Forschler.
1983
1984         * BuildSlaveSupport/ews-build/steps.py:
1985         (PrintConfiguration.getResultSummary): Override getResultSummary.
1986
1987 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1988
1989         [ews-build] Improve summary for CheckOutSource step
1990         https://bugs.webkit.org/show_bug.cgi?id=195963
1991
1992         Reviewed by Lucas Forschler.
1993
1994         * BuildSlaveSupport/ews-build/steps.py:
1995         (CheckOutSource.getResultSummary):
1996
1997 2019-03-19  Daniel Bates  <dabates@apple.com>
1998
1999         [iOS] Focus not preserved when switching between tabs
2000         https://bugs.webkit.org/show_bug.cgi?id=195820
2001         <rdar://problem/43614450>
2002
2003         Reviewed by Brent Fulgham.
2004
2005         Add tests to ensure that we restore focus when resigning and becoming first responder.
2006
2007         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2008         (TestWebKitAPI::TEST):
2009
2010 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2011
2012         Make WTFLogChannelState and WTFLogLevel enum classes
2013         https://bugs.webkit.org/show_bug.cgi?id=195904
2014
2015         Reviewed by Eric Carlson.
2016
2017         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2018         (TestWebKitAPI::TEST_F):
2019
2020 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2021
2022         [GStreamer][EME] Backported mssdemux protection data crash fix
2023         https://bugs.webkit.org/show_bug.cgi?id=195918
2024
2025         Reviewed by Philippe Normand.
2026
2027         * gstreamer/jhbuild.modules:
2028         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2029
2030 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2031
2032         Unreviewed, rolling out r243132.
2033
2034         Broke GTK build
2035
2036         Reverted changeset:
2037
2038         "Make WTFLogChannelState and WTFLogLevel enum classes"
2039         https://bugs.webkit.org/show_bug.cgi?id=195904
2040         https://trac.webkit.org/changeset/243132
2041
2042 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2043
2044         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2045
2046         * Scripts/webkitdirs.pm:
2047         (builtDylibPathForName): Adjust the shared library name that's changed
2048         with the API version bump in r243073.
2049
2050 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2051
2052         Make WTFLogChannelState and WTFLogLevel enum classes
2053         https://bugs.webkit.org/show_bug.cgi?id=195904
2054
2055         Reviewed by Eric Carlson.
2056
2057         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2058         (TestWebKitAPI::TEST_F):
2059
2060 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2061
2062         Disable flaky test added in r2431100
2063         https://webkit.org/b/195785
2064
2065         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2066         (TestWebKitAPI::TEST):
2067         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2068
2069 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2070
2071         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2072         https://bugs.webkit.org/show_bug.cgi?id=195916
2073
2074         Reviewed by Tim Horton.
2075
2076         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2077         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2078
2079 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2080
2081         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2082
2083         * Scripts/webkitpy/common/config/contributors.json:
2084
2085 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2086
2087         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2088         https://bugs.webkit.org/show_bug.cgi?id=195785
2089
2090         Reviewed by Geoffrey Garen.
2091
2092         * TestWebKitAPI/TCPServer.cpp: Added.
2093         (TestWebKitAPI::TCPServer::TCPServer):
2094         (TestWebKitAPI::TCPServer::~TCPServer):
2095         (TestWebKitAPI::TCPServer::socketBindListen):
2096         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2097         * TestWebKitAPI/TCPServer.h: Added.
2098         (TestWebKitAPI::TCPServer::port const):
2099         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2100         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2101         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2102         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2103         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2104         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2105         (TestWebKitAPI::respondSlowly):
2106         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2107         (TestWebKitAPI::downloadAtRate):
2108         (TestWebKitAPI::TEST):
2109
2110 2019-03-18  Saam Barati  <sbarati@apple.com>
2111
2112         Add a plan file for JetStream 2
2113         https://bugs.webkit.org/show_bug.cgi?id=190734
2114
2115         Reviewed by Mark Lam.
2116
2117         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2118
2119 2019-03-18  Chris Dumez  <cdumez@apple.com>
2120
2121         Delay WebProcess launch until a load is triggered in a Web view
2122         https://bugs.webkit.org/show_bug.cgi?id=195758
2123         <rdar://problem/48126013>
2124
2125         Reviewed by Geoff Garen.
2126
2127         Add API test coverage. Also update some existing API tests to not expect
2128         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2129
2130         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2131         (TestWebKitAPI::TEST):
2132         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2133         (TestWebKitAPI::TEST):
2134         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2135         (TEST):
2136         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2137         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2138         (TEST):
2139         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2140         (TEST):
2141         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2142
2143 2019-03-18  Xan Lopez  <xan@igalia.com>
2144
2145         [CMake] Prevent potential warning when determining $architecture
2146         https://bugs.webkit.org/show_bug.cgi?id=195891
2147
2148         Reviewed by Michael Catanzaro.
2149
2150         It's possible for generateBuildSystemForCMakeProject to be called
2151         before determineArchitecture() is ever called. This will make the
2152         first eq check with $architecture to be bogus (and print a
2153         warning). Change that to an eq check with architecture(), which
2154         implicitly calls determineArchitecture() if needed, and change all
2155         the other similar cases in the method in the same way to prevent
2156         future bugs like this one.
2157
2158         * Scripts/webkitdirs.pm:
2159         (generateBuildSystemFromCMakeProject):
2160
2161 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2162
2163         [WPE] Tarballs generated with “make dist” cannot build documentation
2164         https://bugs.webkit.org/show_bug.cgi?id=195885
2165
2166         Reviewed by Carlos Garcia Campos.
2167
2168         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2169
2170 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2171
2172         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2173         https://bugs.webkit.org/show_bug.cgi?id=195883
2174
2175         Reviewed by Carlos Garcia Campos.
2176
2177         * gtkdoc/gtkdoc.py:
2178         (GTKDoc._run_command): When commands fail to run, include the full command line for
2179         the program invocation and the output it has generated on the standard error stream.
2180
2181 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2182
2183         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2184         https://bugs.webkit.org/show_bug.cgi?id=195786
2185
2186         Reviewed by Philippe Normand.
2187
2188         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2189         * wpe/jhbuild.modules: Ditto.
2190
2191 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2192
2193         [ews-build] Don't run clean builds on EWS builders
2194         https://bugs.webkit.org/show_bug.cgi?id=195851
2195
2196         Reviewed by Geoffrey Garen.
2197
2198         * BuildSlaveSupport/ews-build/factories.py:
2199
2200 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2201
2202         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2203         https://bugs.webkit.org/show_bug.cgi?id=195849
2204
2205         Reviewed by Chris Dumez.
2206
2207         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2208
2209         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2210         (runWebsiteDataStoreCustomPaths):
2211
2212 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2213
2214         webkitpy: Upload test results
2215         https://bugs.webkit.org/show_bug.cgi?id=195755
2216         <rdar://problem/48896182>
2217
2218         Reviewed by Aakash Jain.
2219
2220         Establish a new format for uploading results that is not tied to layout tests, apply
2221         that format to webkitpy tests.
2222
2223         * Scripts/webkitpy/common/checkout/scm/git.py:
2224         (Git.native_branch): Return what branch the current checkout is on.
2225         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2226         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2227         * Scripts/webkitpy/common/checkout/scm/svn.py:
2228         (SVN.native_branch): Ditto.
2229         * Scripts/webkitpy/common/system/platforminfo.py:
2230         (PlatformInfo.build_version): Return a build version for Mac.
2231         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2232         (MockPlatformInfo.__init__):
2233         (MockPlatformInfo.build_version):
2234         * Scripts/webkitpy/results: Added.
2235         * Scripts/webkitpy/results/__init__.py: Added.
2236         * Scripts/webkitpy/results/options.py: Added.
2237         (upload_options): OptParse list for upload options.
2238         * Scripts/webkitpy/results/upload.py: Added.
2239         (Upload): Class which enforces the upload format expected by the results server.
2240         (Upload.Expectations):
2241         (Upload.create_configuration):
2242         (Upload.create_commit):
2243         (Upload.create_details):
2244         (Upload.create_run_stats):
2245         (Upload.create_test_result):
2246         (Upload.__init__):
2247         (Upload.Encoder): Encode Upload object as json.
2248         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2249         * Scripts/webkitpy/results/upload_unittest.py: Added.
2250         * Scripts/webkitpy/test/main.py:
2251         (Tester._parse_args): Add upload arguments.
2252         (Tester._run_tests): Allow results to be uploaded.
2253         * Scripts/webkitpy/test/runner.py:
2254         (Runner.__init__): Record which tests were run, rather than just counting them.
2255         (Runner.handle):
2256         * Scripts/webkitpy/test/runner_unittest.py:
2257         (RunnerTest.test_run):
2258         * Scripts/webkitpy/thirdparty/__init__.py:
2259         (AutoinstallImportHook.find_module): Add requests auto-install.
2260         (AutoinstallImportHook._install_requests):
2261         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2262         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2263
2264 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2265
2266         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2267         https://bugs.webkit.org/show_bug.cgi?id=195810
2268
2269         Reviewed by Tim Horton.
2270
2271         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2272         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2273         ending certain layout tests.
2274
2275         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2276         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2277         (-[TestRunnerWKWebView dealloc]):
2278         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2279
2280         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2281         helper method when destroying the web view, and when resetting state between tests.
2282
2283         * WebKitTestRunner/ios/TestControllerIOS.mm:
2284         (WTR::TestController::platformResetStateToConsistentValues):
2285
2286         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2287
2288 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2289
2290         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2291         https://bugs.webkit.org/show_bug.cgi?id=190350
2292         <rdar://problem/45089503>
2293
2294         Reviewed by Geoffrey Garen.
2295
2296         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2297         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2298         (TEST):
2299         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2300         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2301         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2302         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2303         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2304         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2305         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2306         (runTest):
2307         (createDirectories):
2308         (TEST):
2309         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2310         (TEST):
2311         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2312         (TEST):
2313
2314 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2315
2316         Add support to WebPage for getting the contents as an attributed string.
2317         https://bugs.webkit.org/show_bug.cgi?id=195636
2318         rdar://problem/45055697
2319
2320         Reviewed by Tim Horton.
2321
2322         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2323         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2324
2325 2019-03-15  Chris Dumez  <cdumez@apple.com>
2326
2327         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2328         https://bugs.webkit.org/show_bug.cgi?id=195747
2329
2330         Reviewed by Geoff Garen.
2331
2332         Add API test coverage.
2333
2334         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2335
2336 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2337
2338         Unreviewed, rolling out r242952.
2339
2340         Causing API failures on iOS Simulator
2341
2342         Reverted changeset:
2343
2344         "[PSON] Make sure the WebProcessCache is leverage when
2345         relaunching a process after termination"
2346         https://bugs.webkit.org/show_bug.cgi?id=195747
2347         https://trac.webkit.org/changeset/242952
2348
2349 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2350
2351         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2352         https://bugs.webkit.org/show_bug.cgi?id=195740
2353
2354         Reviewed by Ross Kirsling.
2355
2356         window.open doesn't work for WebKitBrowserWindow because it is not
2357         implemented yet.
2358
2359         1. Implemented createNewPage callback of WKPageUIClient.
2360         2. Changed MainWindow to take a BrowserWindow factory function
2361           instead of BrowserWindowType to be flexible to create
2362           BrowserWindow with extra settings.
2363         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2364           because it is not relevant with MainWindow anymore.
2365
2366         * MiniBrowser/win/Common.cpp:
2367         (parseCommandLine):
2368         * MiniBrowser/win/Common.h:
2369         (CommandLineOptions::CommandLineOptions):
2370         * MiniBrowser/win/MainWindow.cpp:
2371         (MainWindow::MainWindow):
2372         (MainWindow::create):
2373         (MainWindow::init):
2374         (MainWindow::WndProc):
2375         * MiniBrowser/win/MainWindow.h:
2376         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2377         (PrintWebUIDelegate::createWebViewWithRequest):
2378         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2379         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2380         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2381         (WebKitBrowserWindow::updateProxySettings):
2382         (WebKitBrowserWindow::createNewPage):
2383         * MiniBrowser/win/WebKitBrowserWindow.h:
2384         * MiniBrowser/win/WinMain.cpp:
2385         (wWinMain):
2386
2387 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2388
2389         Make it possible to test scrolling tree layer manipulation more easily
2390         https://bugs.webkit.org/show_bug.cgi?id=195780
2391
2392         Reviewed by Tim Horton.
2393         
2394         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2395         cuts off communication of scrolling tree scrolls back to the web process
2396         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2397         allows tests to trigger scrolls which run the scrolling tree layer positioning
2398         logic, but never get another commit from the web process that might mask
2399         scrolling tree bugs.
2400         
2401         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2402         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2403         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2404
2405         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2406         (WTR::UIScriptController::scrollUpdatesDisabled const):
2407         (WTR::UIScriptController::setScrollUpdatesDisabled):
2408         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2409         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2410         (WTR::UIScriptController::scrollUpdatesDisabled const):
2411         (WTR::UIScriptController::setScrollUpdatesDisabled):
2412         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2413         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2414         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2415         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2416         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2417         * WebKitTestRunner/ios/TestControllerIOS.mm:
2418         (WTR::TestController::platformResetStateToConsistentValues):
2419         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2420         (WTR::UIScriptController::scrollUpdatesDisabled const):
2421         (WTR::UIScriptController::setScrollUpdatesDisabled):
2422
2423 2019-03-14  Youenn Fablet  <youenn@apple.com>
2424
2425         Move IDB storage in private browsing mode to NetworkProcess
2426         https://bugs.webkit.org/show_bug.cgi?id=195602
2427
2428         Reviewed by Brady Eidson.
2429
2430         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2431         (TEST):
2432
2433 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2434
2435         [ews-build] Make descriptionDone messages more readable
2436         https://bugs.webkit.org/show_bug.cgi?id=195760
2437
2438         Reviewed by Lucas Forschler.
2439
2440         * BuildSlaveSupport/ews-build/steps.py:
2441         * BuildSlaveSupport/ews-build/steps_unittest.py:
2442
2443 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2444
2445         [ews-build] Generate status-bubble hover-over messages
2446         https://bugs.webkit.org/show_bug.cgi?id=195680
2447
2448         Reviewed by Lucas Forschler.
2449
2450         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2451         (StatusBubble):
2452         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2453         on hover-over.
2454         (StatusBubble._iso_time):
2455         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2456         hover-over message.
2457         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2458
2459 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2460
2461         [ews-app] Gracefully handle the case when state_string is None
2462         https://bugs.webkit.org/show_bug.cgi?id=195753
2463
2464         Reviewed by Lucas Forschler.
2465
2466         * BuildSlaveSupport/ews-app/ews/models/build.py:
2467         * BuildSlaveSupport/ews-app/ews/models/step.py:
2468
2469 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2470
2471         [ews-app] Status bubble display pending for currently running build step
2472         https://bugs.webkit.org/show_bug.cgi?id=195744
2473
2474         Reviewed by Lucas Forschler.
2475
2476         * BuildSlaveSupport/ews-build/events.py:
2477         (Events.stepStarted): If state_string is pending, replace it with step name.
2478
2479 2019-03-14  Chris Dumez  <cdumez@apple.com>
2480
2481         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2482         https://bugs.webkit.org/show_bug.cgi?id=195750
2483
2484         Reviewed by Geoffrey Garen.
2485
2486         Add API test coverage.
2487
2488         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2489         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2490         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2491         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2492
2493 2019-03-14  Chris Dumez  <cdumez@apple.com>
2494
2495         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2496         https://bugs.webkit.org/show_bug.cgi?id=195747
2497
2498         Reviewed by Geoff Garen.
2499
2500         Add API test coverage.
2501
2502         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2503
2504 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2505
2506         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2507         https://bugs.webkit.org/show_bug.cgi?id=195725
2508         <rdar://problem/48545062>
2509
2510         Reviewed by Tim Horton.
2511
2512         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2513         handler is nil.
2514
2515         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2516         (TestWebKitAPI::TEST):
2517
2518 2019-03-13  Sam Weinig  <sam@webkit.org>
2519
2520         Add utility function to allow easy reverse range-based iteration of a container
2521         https://bugs.webkit.org/show_bug.cgi?id=195542
2522
2523         Reviewed by Antti Koivisto.
2524
2525         * TestWebKitAPI/CMakeLists.txt:
2526         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2527         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2528         (TestWebKitAPI::TEST):
2529         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2530
2531 2019-03-13  Chris Dumez  <cdumez@apple.com>
2532
2533         Use a ServiceWorker process per registrable domain
2534         https://bugs.webkit.org/show_bug.cgi?id=195649
2535
2536         Reviewed by Youenn Fablet.
2537
2538         Update API test coverage.
2539
2540         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2541
2542 2019-03-13  Chris Dumez  <cdumez@apple.com>
2543
2544         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2545         https://bugs.webkit.org/show_bug.cgi?id=195684
2546         <rdar://problem/48294714>
2547
2548         Reviewed by Antti Koivisto.
2549
2550         Add API test coverage.
2551
2552         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2553
2554 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2555
2556         [ews-app] Remove unused patch view
2557         https://bugs.webkit.org/show_bug.cgi?id=195669
2558
2559         Reviewed by Lucas Forschler.
2560
2561         * BuildSlaveSupport/ews-app/ews/urls.py:
2562         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2563
2564 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2565
2566         [ews-app] Use Buildbot result code variables
2567         https://bugs.webkit.org/show_bug.cgi?id=195668
2568
2569         Reviewed by Alexey Proskuryakov.
2570
2571         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2572         (Buildbot): Added Buildbot result code variables.
2573         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2574         (StatusBubble._build_bubble): Used Buildbot result code variables.
2575
2576 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2577
2578         [Flatpak] Expand submodule recursively
2579         https://bugs.webkit.org/show_bug.cgi?id=195672
2580
2581         Building WPE with flatpak was impossible without that as it was raising an exception.
2582         Also update wpebackend-fdo to match what is built in jhbuild
2583
2584         Reviewed by Philippe Normand.
2585
2586         * flatpak/flatpakutils.py:
2587         (expand_submodules_recurse):
2588         (expand_manifest):
2589         * flatpak/org.webkit.WPEModules.yaml:
2590
2591 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2592
2593         [ews-app] status bubble should be hidden for certain builds
2594         https://bugs.webkit.org/show_bug.cgi?id=194597
2595
2596         Reviewed by Dewei Zhu.
2597
2598         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2599         (StatusBubble._build_bubble):
2600         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2601         because the patch didn't have relevant changes.
2602         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2603         in production yet.
2604
2605 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2606
2607         [Win] Fix a slew of simple clang-cl warnings.
2608         https://bugs.webkit.org/show_bug.cgi?id=195652
2609
2610         Reviewed by Don Olmstead.
2611
2612         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2613         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2614
2615 2019-03-12  Justin Fan  <justin_fan@apple.com>
2616
2617         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2618         https://bugs.webkit.org/show_bug.cgi?id=195518
2619         <rdar://problem/46322356>
2620
2621         Reviewed by Myles C. Maxfield.
2622
2623         * DumpRenderTree/DerivedSources-input.xcfilelist:
2624         * DumpRenderTree/DerivedSources-output.xcfilelist:
2625
2626 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2627
2628         Unreviewed, rolling out r242825.
2629         https://bugs.webkit.org/show_bug.cgi?id=195648
2630
2631         "Broke webkitpy tests with my change to
2632         lldb_dump_class_layout.py" (Requested by rmorisset on
2633         #webkit).
2634
2635         Reverted changeset:
2636
2637         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2638         classes with suspicious padding"
2639         https://bugs.webkit.org/show_bug.cgi?id=195573
2640         https://trac.webkit.org/changeset/242825
2641
2642 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2643
2644         [ews-build] Show status bubbles while the patch is waiting in queue
2645         https://bugs.webkit.org/show_bug.cgi?id=195618
2646
2647         Reviewed by Lucas Forschler.
2648
2649         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2650         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2651         enabled in initial deployment.
2652         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2653         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2654         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2655         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2656         (StatusBubble._build_bubbles_for_patch):
2657
2658 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2659
2660         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2661         https://bugs.webkit.org/show_bug.cgi?id=195573
2662
2663         Reviewed by Simon Fraser.
2664
2665         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2666
2667         * Scripts/dump-class-layout:
2668         (main):
2669         * lldb/lldb_dump_class_layout.py:
2670         (ClassLayout.__init__):
2671         (ClassLayout._compute_padding_recursive):
2672         (LLDBDebuggerInstance.dump_layout_for_classname):
2673         (LLDBDebuggerInstance):
2674         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2675         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2676
2677 2019-03-12  Chris Dumez  <cdumez@apple.com>
2678
2679         Device Orientation access permission should be denied unless explicitly granted by the client
2680         https://bugs.webkit.org/show_bug.cgi?id=195625
2681
2682         Reviewed by Youenn Fablet.
2683
2684         add API test coverage.
2685
2686         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2687         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2688         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2689         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2690         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2691         (runDeviceOrientationTest):
2692         (TEST):
2693         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2694         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2695
2696 2019-03-12  Jer Noble  <jer.noble@apple.com>
2697
2698         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2699         https://bugs.webkit.org/show_bug.cgi?id=195137
2700         <rdar://problem/48810307>
2701
2702         Reviewed by Eric Carlson.
2703
2704         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2705         (TestWebKitAPI::TEST):
2706
2707 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2708
2709         [ews-build] Change urls from uat to production
2710         https://bugs.webkit.org/show_bug.cgi?id=195566
2711
2712         Reviewed by Lucas Forschler.
2713
2714         * BuildSlaveSupport/ews-app/ews/config.py:
2715         * BuildSlaveSupport/ews-build/events.py:
2716         * BuildSlaveSupport/ews-build/steps.py:
2717
2718 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2719
2720         [ews-build] change max_builds for local-worker to 1
2721         https://bugs.webkit.org/show_bug.cgi?id=195568
2722
2723         Reviewed by Lucas Forschler.
2724
2725         * BuildSlaveSupport/ews-build/loadConfig.py:
2726
2727 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2728
2729         Fix the build
2730
2731         * TestRunnerShared/spi/PencilKitTestSPI.h:
2732         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2733
2734 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2735
2736         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2737         https://bugs.webkit.org/show_bug.cgi?id=194131
2738
2739         Reviewed by Michael Catanzaro.
2740
2741         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2742         (uriChanged):
2743         (testUnfinishedSubresourceLoad):
2744         (serverCallback):
2745         (beforeAll):
2746
2747 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2748
2749         WTF::Expected should use std::addressof instead of operator&
2750         https://bugs.webkit.org/show_bug.cgi?id=195604
2751
2752         Reviewed by Myles Maxfield.
2753
2754         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2755         (TestWebKitAPI::Unique::Unique):
2756         (TestWebKitAPI::Unique::operator&):
2757         (TestWebKitAPI::TEST):
2758
2759 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2760
2761         Add Optional to Forward.h.
2762         https://bugs.webkit.org/show_bug.cgi?id=195586
2763
2764         Reviewed by Darin Adler.
2765
2766         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2767         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2768         Remove unnecessary includes from headers.
2769
2770 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2771
2772         Add testing API to hit-test and scroll overflow scrollers
2773         https://bugs.webkit.org/show_bug.cgi?id=195278
2774
2775         Reviewed by Antti Koivisto.
2776         
2777         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2778         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2779         
2780         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2781
2782         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2783         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2784         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2785         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2786         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2787         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2788         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2789         (WTR::enclosingScrollViewIncludingSelf):
2790         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2791
2792 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2793
2794         API test WebKit.RequestTextInputContext fails on iOS
2795         https://bugs.webkit.org/show_bug.cgi?id=195585
2796
2797         Reviewed by Wenson Hsieh and Simon Fraser.
2798
2799         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2800         (applyStyle):
2801         (TEST):
2802         Add a viewport, so that the coordinates match up on iOS.
2803         Scroll by moving the UIScrollView's contentOffset.
2804
2805 2019-03-11  Chris Dumez  <cdumez@apple.com>
2806
2807         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2808         https://bugs.webkit.org/show_bug.cgi?id=195506
2809         <rdar://problem/48733477>
2810
2811         Reviewed by Alex Christensen.
2812
2813         Add API test coverage.
2814
2815         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2816
2817 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2818
2819         Adding myself to contributors.json
2820
2821         Unreviewed, addming myself to contributors.json .
2822
2823         * Scripts/webkitpy/common/config/contributors.json:
2824
2825 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2826
2827         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2828         https://bugs.webkit.org/show_bug.cgi?id=195511
2829         <rdar://problem/44873269>
2830
2831         Reviewed by Darin Adler.
2832
2833         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2834         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2835         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2836         (TEST_F):
2837
2838 2019-03-11  Chris Dumez  <cdumez@apple.com>
2839
2840         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2841         https://bugs.webkit.org/show_bug.cgi?id=195561
2842
2843         Reviewed by Youenn Fablet.
2844
2845         Make sure the JS in the test requests for permission to receive device orientation events.
2846
2847         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2848
2849 2019-03-11  Youenn Fablet  <youenn@apple.com>
2850
2851         Allow storage quota increase by default in WTR
2852         https://bugs.webkit.org/show_bug.cgi?id=195541
2853
2854         Reviewed by Geoffrey Garen.
2855
2856         Allow storage quota increase by default in WTR.
2857         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2858         Use this for tests that explicitly need cache increase.
2859
2860         Instead of increasing quota by 2, make sure the next request is
2861         granted by adding all given parameters.
2862
2863         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2864         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2865         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2866         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2867         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2868         * WebKitTestRunner/TestController.cpp:
2869         (WTR::TestController::setAllowStorageQuotaIncrease):
2870         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2871         * WebKitTestRunner/TestController.h:
2872         * WebKitTestRunner/TestInvocation.cpp:
2873         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2874         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2875         (WTR::TestController::cocoaResetStateToConsistentValues):
2876         (WTR::TestController::setAllowStorageQuotaIncrease):
2877         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2878         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2879         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2880
2881 2019-03-11  Xan Lopez  <xan@igalia.com>
2882
2883         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2884         https://bugs.webkit.org/show_bug.cgi?id=194147
2885
2886         Reviewed by Michael Saboff.
2887
2888         To make --32-bit work correctly on Linux/64bit we need to:
2889
2890         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2891         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2892         unfortunately CMake only allows us to do this during
2893         crosscompilation, which is overkill here.
2894         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2895         pkg-config detection module uses the x86 .pc files instead of the
2896         x86_64 ones.
2897         - Set the -m32 flags for the compiler.
2898
2899         * Scripts/webkitdirs.pm:
2900         (generateBuildSystemFromCMakeProject):
2901
2902 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2903
2904         Add MotionMark-1.1 plan file for run-benchmark script.
2905         https://bugs.webkit.org/show_bug.cgi?id=195481
2906
2907         Rubber-stamped by Darin Adler.
2908
2909         Run-benchmark script should support MontionMark-1.1.
2910
2911         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2912
2913 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2914
2915         [ews-app] Add support for submit-to-ews url
2916         https://bugs.webkit.org/show_bug.cgi?id=195477
2917
2918         Reviewed by Lucas Forschler.
2919
2920         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2921         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2922         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2923         * BuildSlaveSupport/ews-app/ews/urls.py:
2924         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2925
2926 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2927
2928         Unreviewed, rolling out r242688, r242643, r242624.
2929
2930         Caused multiple layout test failures and crashes on iOS and macOS.
2931
2932         Reverted changeset:
2933
2934         "requestAnimationFrame should execute before the next frame"
2935         https://bugs.webkit.org/show_bug.cgi?id=177484
2936         https://trac.webkit.org/changeset/242624/webkit
2937
2938         * Tracing/SystemTracePoints.plist:
2939
2940 2019-03-11  John Wilander  <wilander@apple.com>
2941
2942         Resource Load Statistics: Make it possible exclude localhost from classification
2943         https://bugs.webkit.org/show_bug.cgi?id=195474
2944         <rdar://problem/47520577>
2945
2946         Reviewed by Brent Fulgham.
2947
2948         This patch allows for localhost to be excluded from classification and
2949         treatment as a prevalent resource.
2950
2951         The WebKit Tools change adds a new function called
2952         testRunner.setStatisticsIsRunningTest() which can be used to control this
2953         behavior.
2954
2955         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2956         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2957         (WTR::TestRunner::setStatisticsIsRunningTest):
2958         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2959         * WebKitTestRunner/TestController.cpp:
2960         (WTR::TestController::setStatisticsIsRunningTest):
2961         * WebKitTestRunner/TestController.h:
2962         * WebKitTestRunner/TestInvocation.cpp:
2963         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2964
2965 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2966
2967         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2968         https://bugs.webkit.org/show_bug.cgi?id=195560
2969
2970         Reviewed by Lucas Forschler.
2971
2972         * BuildSlaveSupport/ews-build/master.cfg:
2973
2974 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2975
2976         Unreviewed, rolling out r242698.
2977
2978         API test crashes on bots.
2979
2980         Reverted changeset:
2981
2982         "Add a WKContentRuleList variant that uses copied memory
2983         instead of mmap'd shared memory for class A containerized
2984         apps"
2985         https://bugs.webkit.org/show_bug.cgi?id=195511
2986         https://trac.webkit.org/changeset/242698
2987
2988 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2989
2990         [WPE] Enable web process sandbox
2991         https://bugs.webkit.org/show_bug.cgi?id=195169
2992
2993         Reviewed by Daniel Bates.
2994
2995         * wpe/install-dependencies:
2996         * wpe/jhbuild.modules:
2997
2998 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2999
3000         [ews-app] Use port 17000 for worker communication
3001         https://bugs.webkit.org/show_bug.cgi?id=195558
3002
3003         Reviewed by Lucas Forschler.
3004
3005         * BuildSlaveSupport/ews-build/master.cfg:
3006
3007 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3008
3009         [ews-build] unit-tests fail when passwords.json is missing
3010         https://bugs.webkit.org/show_bug.cgi?id=195557
3011
3012         Reviewed by Lucas Forschler.
3013
3014         * BuildSlaveSupport/ews-build/loadConfig.py:
3015         (loadBuilderConfig):
3016         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3017         (ConfigDotJSONTest.test_configuration):
3018         * BuildSlaveSupport/ews-build/master.cfg:
3019
3020 2019-03-11  Truitt Savell  <tsavell@apple.com>
3021
3022         Unreviewed, rolling out r242702.
3023
3024         Broke High Sierra builders.
3025
3026         Reverted changeset:
3027
3028         "Add utility function to allow easy reverse range-based
3029         iteration of a container"
3030         https://bugs.webkit.org/show_bug.cgi?id=195542
3031         https://trac.webkit.org/changeset/242702
3032
3033 2019-03-11  Sam Weinig  <sam@webkit.org>
3034
3035         Add utility function to allow easy reverse range-based iteration of a container
3036         https://bugs.webkit.org/show_bug.cgi?id=195542
3037
3038         Reviewed by Antti Koivisto.
3039
3040         * TestWebKitAPI/CMakeLists.txt:
3041         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3042         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3043         (TestWebKitAPI::TEST):
3044         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3045
3046 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3047
3048         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3049         https://bugs.webkit.org/show_bug.cgi?id=195511
3050         <rdar://problem/44873269>
3051
3052         Reviewed by Darin Adler.
3053
3054         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3055         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3056         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3057         (TEST_F):
3058
3059 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3060
3061         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3062         https://bugs.webkit.org/show_bug.cgi?id=195499
3063
3064         Reviewed by Darin Adler.
3065
3066         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3067         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3068         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3069         (-[WKWebView synchronouslyFocusTextInputContext:]):
3070         (applyStyle):
3071         (applyIframe):
3072         (TEST):
3073         Add some tests for this SPI.
3074
3075 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3076
3077         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3078         https://bugs.webkit.org/show_bug.cgi?id=181151
3079
3080         Reviewed by Don Olmstead.
3081
3082         * TestWebKitAPI/CMakeLists.txt:
3083         * TestWebKitAPI/PlatformWin.cmake:
3084         Enable TestWTF RunLoop tests in all platforms.
3085
3086         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3087         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3088         (TestWebKitAPI::DerivedOneShotTimer::fired):
3089         (TestWebKitAPI::TEST):
3090         Only a few platforms support nested RunLoop.
3091
3092         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3093         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3094
3095 2019-03-10  David Quesada  <david_quesada@apple.com>
3096
3097         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3098         https://bugs.webkit.org/show_bug.cgi?id=152480
3099
3100         Reviewed by Chris Dumez.
3101
3102         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3103         there are no additional references to the process pool besides the one held by
3104         the download, waits for the download to finish (in the sense that the
3105         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3106         measure, also check that the process pool has been deallocated at the end of the
3107         test. The test wouldn't be meaningful if the process pool were still alive.
3108
3109         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3110         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3111         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3112             The download will be canceled because the delegate does not implement the
3113             method to decide the download's destination, so this is where we know the
3114             DownloadProxyMap is done with the DownloadProxy.
3115         (TEST):
3116
3117 2019-03-08  Chris Dumez  <cdumez@apple.com>
3118
3119         Add support for Device Orientation / Motion permission API
3120         https://bugs.webkit.org/show_bug.cgi?id=195329
3121         <rdar://problem/47645367>
3122
3123         Reviewed by Geoffrey Garen.
3124
3125         Add test infrastructure to help test the Device Orientation / Motion permission API.
3126
3127         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3128         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3129         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3130         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3131         * WebKitTestRunner/TestController.cpp:
3132         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3133         (WTR::TestController::createWebViewWithOptions):
3134         (WTR::TestController::resetStateToConsistentValues):
3135         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3136         * WebKitTestRunner/TestController.h:
3137         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3138         * WebKitTestRunner/TestInvocation.cpp:
3139         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3140
3141 2019-03-08  Saam barati  <sbarati@apple.com>
3142
3143         Add a compare-results script to compare benchmark results
3144         https://bugs.webkit.org/show_bug.cgi?id=195486
3145         <rdar://problem/48723397>
3146
3147         Reviewed by Geoffrey Garen.
3148
3149         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3150         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3151         to extend it to learn about our other benchmarks.
3152
3153         * Scripts/compare-results: Added.
3154         (readJSONFile):
3155         (detectJetStream2):
3156         (JetStream2Results):
3157         (detectSpeedometer2):
3158         (Speedometer2Results):
3159         (detectPLT5):
3160         (PLT5Results):
3161         (detectBenchmark):
3162         (biggerIsBetter):
3163         (ttest):
3164         (getOptions):
3165         (main):
3166
3167 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3168
3169         Ensure old tab state is cleared between iterations of run-benchmark
3170         https://bugs.webkit.org/show_bug.cgi?id=195393
3171         <rdar://problem/46885583>
3172
3173         Reviewed by Dewei Zhu.
3174
3175         a) ensure the default to restore state is not set
3176         b) terminate Safari correctly
3177         c) Set the system default to ignore Persistent State in Safari
3178
3179         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3180         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3181         (OSXBrowserDriver.prepare_env): 
3182         (OSXBrowserDriver.restore_env):
3183         (OSXBrowserDriver.close_browsers):
3184         (OSXBrowserDriver._terminate_processes):
3185         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3186         (OSXChromeDriver):
3187         (OSXChromeCanaryDriver):
3188         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3189         (OSXFirefoxDriver):
3190         (OSXFirefoxNightlyDriver):
3191         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3192         (OSXSafariDriver):
3193         (OSXSafariDriver.prepare_env):
3194
3195 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3196
3197         [GTK] Several InputMethodFilter tests are failing
3198         https://bugs.webkit.org/show_bug.cgi?id=195408
3199
3200         Reviewed by Carlos Garcia Campos.
3201
3202         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3203         Regressed in r241751.
3204         Hexadecimal values of keycodes are expressed now in upper letters.
3205         Composited characters should be cast to UTF8 strings.
3206
3207         (TestWebKitAPI::TEST):
3208
3209 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3210
3211         [GTK] Make Tools/gtkdoc python3 compatible
3212         https://bugs.webkit.org/show_bug.cgi?id=195359
3213
3214         Reviewed by Carlos Garcia Campos.
3215
3216         * gtkdoc/generate-gtkdoc:
3217         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3218         work with Python 2 and 3.
3219         (get_gtkdoc_module_paths):
3220         The iteritems() was removed in Python 3, so let's use items() that's
3221         available in Python 2 and 3.
3222         (get_generator_for_config):
3223         * gtkdoc/gtkdoc.py:
3224         (GTKDoc._run_command):
3225         The sys.stdout.write() is expecting str in Python 3 and not bytes
3226         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3227         for passing the bytes there.
3228
3229 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3230
3231         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3232         https://bugs.webkit.org/show_bug.cgi?id=195346
3233         <rdar://problem/48667048>
3234
3235         Unreviewed build fix for clang-cl.
3236
3237         * DumpRenderTree/win/DumpRenderTree.cpp:
3238         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3239
3240 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3241
3242         requestAnimationFrame should execute before the next frame
3243         https://bugs.webkit.org/show_bug.cgi?id=177484
3244
3245         Reviewed by Simon Fraser.
3246
3247         Add trace points for the page RenderingUpdate.
3248
3249         * Tracing/SystemTracePoints.plist:
3250
3251 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3252
3253         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3254         https://bugs.webkit.org/show_bug.cgi?id=195353
3255         <rdar://problem/48626394>
3256
3257         Reviewed by Simon Fraser.
3258
3259         * WebKitTestRunner/ios/TestControllerIOS.mm:
3260         (WTR::TestController::platformResetPreferencesToConsistentValues):
3261
3262 2019-03-07  John Wilander  <wilander@apple.com>
3263
3264         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3265         https://bugs.webkit.org/show_bug.cgi?id=195383
3266         <rdar://problem/48570136>
3267
3268         Reviewed by Brent Fulgham.
3269
3270         This patch adds test infrastructure to purge only script-accessible cookies,
3271         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3272
3273         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3274         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3275         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3276         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3277         * WebKitTestRunner/TestController.cpp:
3278         (WTR::TestController::statisticsDeleteCookiesForHost):
3279         * WebKitTestRunner/TestController.h:
3280         * WebKitTestRunner/TestInvocation.cpp:
3281         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3282
3283 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3284
3285         Unreviewed, rolling out r242354.
3286         https://bugs.webkit.org/show_bug.cgi?id=195402
3287
3288         breaks layout tests in all configurations (Requested by
3289         zdobersek on #webkit).
3290
3291         Reverted changeset:
3292
3293         "[WPE] Enable web process sandbox"
3294         https://bugs.webkit.org/show_bug.cgi?id=195169
3295         https://trac.webkit.org/changeset/242354
3296
3297 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3298
3299         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3300         https://bugs.webkit.org/show_bug.cgi?id=195346
3301
3302         Reviewed by Fujii Hironori.
3303
3304         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3305         (TestWebKitAPI::TEST):
3306         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3307
3308         * DumpRenderTree/win/DumpRenderTree.cpp:
3309         (findFontFallback):
3310         (addFontFallbackIfPresent):
3311         (removeFontFallbackIfPresent):
3312         (main):
3313         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3314         (TestWebKitAPI::Util::moduleDirectory):
3315         (TestWebKitAPI::Util::createInjectedBundlePath):
3316         Use wchar helpers as needed.
3317
3318 2019-03-06  Rob Buis  <rbuis@igalia.com>
3319
3320         Consider supporting the `referrerpolicy` attribute.
3321         https://bugs.webkit.org/show_bug.cgi?id=179053
3322
3323         Reviewed by Darin Adler.
3324
3325         Add a runtime flag for referrerpolicy attribute.
3326
3327         * DumpRenderTree/mac/DumpRenderTree.mm:
3328         (enableExperimentalFeatures):
3329
3330 2019-03-05  Daniel Bates  <dabates@apple.com>
3331
3332         Update expected API test result following r242379
3333         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3334
3335         Update expected x-coordinate of selection rect now that the left padding of
3336         a textarea is sized in ems (so dependent on the font size) just like the left
3337         padding of a text field.
3338
3339         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3340         (TestWebKitAPI::TEST):
3341
3342 2019-03-05  David Quesada  <david_quesada@apple.com>
3343
3344         [WK2] It should be possible to follow links with 'download' attributes
3345         https://bugs.webkit.org/show_bug.cgi?id=195145
3346         rdar://problem/48462642
3347
3348         Reviewed by Alex Christensen.
3349
3350         Add a unit test to verify that activating links with 'download' attributes now
3351         navigates to the linked resource, rather than starts downloading it. Add another
3352         to verify that it is still possible to explicitly download the link via the
3353         'Download' navigation action policy.
3354
3355         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3356         (-[DownloadAttributeTestDelegate init]):
3357         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3358         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3359         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3360         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3361         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3362         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3363         (TEST):
3364         * WebKitTestRunner/TestController.cpp:
3365         (WTR::TestController::decidePolicyForNavigationAction):
3366         * WebKitTestRunner/TestController.h:
3367
3368 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3369
3370         [Curl] Implement Cookie Accept Policy.
3371         https://bugs.webkit.org/show_bug.cgi?id=191645
3372
3373         Reviewed by Fujii Hironori.
3374
3375         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3376         (TestWebKitAPI::Curl::TEST_F):
3377
3378 2019-03-05  Youenn Fablet  <youenn@apple.com>
3379
3380         Rename requestCacheStorageSpace to requestStorageSpace
3381         https://bugs.webkit.org/show_bug.cgi?id=195282
3382
3383         Reviewed by Chris Dumez.
3384
3385         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3386         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3387         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3388
3389 2019-03-05  Brady Eidson  <beidson@apple.com>
3390
3391         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3392         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3393
3394         Reviewed by Tim Horton.
3395
3396         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3397         different directory into that same WKWebView should work.
3398
3399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3400         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3401
3402 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3403
3404         Add WeakHashSet
3405         https://bugs.webkit.org/show_bug.cgi?id=195152
3406
3407         Reviewed by Antti Koivisto.
3408
3409         Added tests for WeakHashSet.
3410
3411         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3412         (TestWebKitAPI::Base::Base): Moved.
3413         (TestWebKitAPI::Derived::foo): Moved.
3414         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3415         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3416         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3417         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3418
3419 2019-03-04  Chris Dumez  <cdumez@apple.com>
3420
3421         Do not share WebProcesses between private and regular sessions
3422         https://bugs.webkit.org/show_bug.cgi?id=195189
3423         <rdar://problem/48421064>
3424
3425         Reviewed by Alex Christensen.
3426
3427         Add API test coverage.
3428
3429         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3430         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3431
3432 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3433
3434         [WPE] Enable web process sandbox
3435         https://bugs.webkit.org/show_bug.cgi?id=195169
3436
3437         Reviewed by Daniel Bates.
3438
3439         * wpe/install-dependencies:
3440         * wpe/jhbuild.modules:
3441
3442 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3443
3444         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3445         https://bugs.webkit.org/show_bug.cgi?id=195206
3446
3447         Reviewed by Žan Doberšek.
3448
3449         Add a new test case.
3450
3451         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3452         (testJSCClass):
3453
3454 2019-03-04  Charlie Turner  <cturner@igalia.com>
3455
3456         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3457         https://bugs.webkit.org/show_bug.cgi?id=194898
3458
3459         Reviewed by Žan Doberšek.
3460
3461         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3462         a GCC extension that permits arithmetic on void* pointer. Inline
3463         the macro until this issue is fixed upstream.
3464
3465 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3466
3467         Rid the world of WK_API_ENABLED
3468         https://bugs.webkit.org/show_bug.cgi?id=195263
3469
3470         Reviewed by Dan Bernstein.
3471
3472         List of changed files elided because it's useless.
3473
3474 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3475
3476         Unreviewed follow-up to r242292.
3477
3478         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3479
3480         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3481         (TestWebKitAPI::testStrip): Renamed from strip.
3482         (TestWebKitAPI::TEST):
3483
3484 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3485
3486         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3487
3488         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3489         and bug #194272 for details.
3490
3491         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3492
3493 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3494
3495         Remove some more unused 32-bit code
3496         https://bugs.webkit.org/show_bug.cgi?id=195255
3497
3498         Reviewed by Darin Adler.
3499
3500         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3501         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3502         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3503         (NPP_New):
3504         (NPP_HandleEvent):
3505         (handleEventCarbon): Deleted.
3506
3507 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3508
3509         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3510
3511         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3512         (TestWebKitAPI::TEST):
3513
3514 2019-03-01  Darin Adler  <darin@apple.com>
3515
3516         Finish removing String::format
3517         https://bugs.webkit.org/show_bug.cgi?id=194893
3518
3519         Reviewed by Daniel Bates.
3520 '
3521         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3522
3523 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3524
3525         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3526         https://bugs.webkit.org/show_bug.cgi?id=195229
3527         <rdar://problem/48520362>
3528
3529         Reviewed by Chris Dumez.
3530
3531         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3532         (TEST):
3533
3534 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3535
3536         Add a system trace scope for event region building
3537         https://bugs.webkit.org/show_bug.cgi?id=195226
3538
3539         Reviewed by Jon Lee.
3540
3541         This trace scope measures the time spend converting element rects into Region objects,
3542         which can be large on some pages.
3543
3544         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3545
3546         * Tracing/SystemTracePoints.plist:
3547
3548 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3549
3550         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3551         https://bugs.webkit.org/show_bug.cgi?id=194612
3552
3553         Reviewed by Alex Christensen.
3554
3555         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3556         Just test the new string-processing function and don't touch the actual environment.
3557         (Test cases are all as before, but based on operator== instead of strcmp.)
3558
3559 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3560
3561         [ews-app] Update primary keys for handling multiple Buildbot instances
3562         https://bugs.webkit.org/show_bug.cgi?id=195120
3563
3564         Reviewed by Stephanie Lewis.
3565
3566         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3567         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3568         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3569
3570         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3571         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3572         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3573         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3574         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3575         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3576
3577 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3578
3579         [WinCairo] Enable service worker
3580         https://bugs.webkit.org/show_bug.cgi?id=188318
3581
3582         Reviewed by Youenn Fablet.
3583
3584         * DumpRenderTree/DumpRenderTreePrefix.h:
3585         * TestWebKitAPI/PlatformWin.cmake:
3586         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3587         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3588         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3589
3590 2019-03-01  Justin Fan  <justin_fan@apple.com>
3591
3592         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3593         https://bugs.webkit.org/show_bug.cgi?id=195191
3594
3595         Rubber-stamped by Dean Jackson.
3596
3597         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3598
3599         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3600
3601 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3602
3603         Unreviewed, fix lldb webkitpy tests
3604         https://bugs.webkit.org/show_bug.cgi?id=194375
3605
3606         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3607
3608         * lldb/lldb_webkit.py:
3609         (WTFStringImplProvider.is_8bit):
3610
3611 2019-02-28  David Quesada  <david_quesada@apple.com>
3612
3613         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3614         https://bugs.webkit.org/show_bug.cgi?id=195121
3615         rdar://problem/48450302
3616
3617         Reviewed by Alex Christensen.
3618
3619         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3620         configurations where the 'download' attribute is absent, blank, or populated
3621         with a filename, and where the anchor element is same-origin or cross-origin
3622         (meaning the 'download' attribute shouldn't be honored).
3623
3624         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3625         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3626         (-[NavigationActionTestDelegate init]):
3627         (-[NavigationActionTestDelegate navigationAction]):
3628         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3629         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3630         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3631         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3632         (TEST):
3633
3634 2019-02-28  Antoine Quint  <graouts@apple.com>
3635
3636         Enable the Pointer Events runtime flag by default
3637         https://bugs.webkit.org/show_bug.cgi?id=195156
3638
3639         Reviewed by Dean Jackson.
3640
3641         * DumpRenderTree/mac/DumpRenderTree.mm:
3642         (enableExperimentalFeatures):
3643
3644 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3645
3646         Several PasteImage API tests are flaky
3647         https://bugs.webkit.org/show_bug.cgi?id=195160
3648
3649         Reviewed by Tim Horton.
3650
3651         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3652         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3653         listening for a "load" event after image load is already complete.
3654
3655         To address this, make these tests first register a "load" event handler, then run script to insert an image
3656         element into the document, and finally wait until the load event is observed before checking image size.
3657
3658         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3659
3660 2019-02-28  Chris Dumez  <cdumez@apple.com>
3661
3662         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3663         https://bugs.webkit.org/show_bug.cgi?id=195107
3664
3665         Reviewed by Alex Christensen.
3666
3667         Give some time for the zoom level to get restored.
3668
3669         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3670
3671 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3672
3673         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3674         https://bugs.webkit.org/show_bug.cgi?id=194958
3675
3676         Reviewed by Geoffrey Garen.
3677
3678         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3679         (TEST):
3680
3681 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3682
3683         [ews-app] Update method to save build to handle builder_display_name
3684         https://bugs.webkit.org/show_bug.cgi?id=195047
3685
3686         Reviewed by Dewei Zhu.
3687
3688         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3689         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3690
3691 2019-02-28  Justin Fan  <justin_fan@apple.com>
3692
3693         [Web GPU] Enable Web GPU only on 64-bit
3694         https://bugs.webkit.org/show_bug.cgi?id=195139
3695
3696         Because Metal is only supported on 64 bit apps.
3697
3698         Unreviewed build fix.
3699
3700         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3701
3702 2019-02-27  Youenn Fablet  <youenn@apple.com>
3703
3704         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3705         https://bugs.webkit.org/show_bug.cgi?id=194959
3706
3707         Reviewed by Chris Dumez.
3708
3709         Spin loop until getting the condition to remove flakiness.
3710
3711         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3712
3713 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3714
3715         [ews-build] Buildbot should include builder_display_name in the build events
3716         https://bugs.webkit.org/show_bug.cgi?id=195045
3717
3718         Reviewed by Dewei Zhu.
3719
3720         * BuildSlaveSupport/ews-build/events.py:
3721         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3722         buildername to builder_name to be consistent in naming style.
3723         (Events.buildFinished): Ditto.
3724
3725 2019-02-27  Chris Dumez  <cdumez@apple.com>
3726
3727         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3728         https://bugs.webkit.org/show_bug.cgi?id=194480
3729
3730         Reviewed by Brady Eidson.
3731
3732         Update existing API test to make it more likely to reproduce the issue.
3733
3734         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3735
3736 2019-02-27  Brady Eidson  <beidson@apple.com>
3737
3738         Universal links from Google search results pages don't open the app.
3739         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3740
3741         Reviewed by Geoffrey Garen.
3742
3743         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3744         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3745         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3746         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3747
3748 2019-02-27  Chris Dumez  <cdumez@apple.com>
3749
3750         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3751         https://bugs.webkit.org/show_bug.cgi?id=195102
3752
3753         Reviewed by Geoffrey Garen.
3754
3755         If the number of processes is not yet what we expect, wait a bit and check again to give
3756         processes some time to exit.
3757
3758         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3759
3760 2019-02-27  Chris Dumez  <cdumez@apple.com>
3761
3762         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3763         https://bugs.webkit.org/show_bug.cgi?id=194545
3764
3765         Reviewed by Brady Eidson.
3766
3767         Make sure the test navigates forward and then back only once. Previously, navigating
3768         back would trigger a navigation again in a timer.
3769
3770         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3771
3772 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3773
3774         High Sierra Debug JSC test queue should use faster hardware
3775         https://bugs.webkit.org/show_bug.cgi?id=194603
3776
3777         Rubber-stamped by Alexey Proskuryakov.
3778
3779         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3780
3781         * BuildSlaveSupport/build.webkit.org-config/config.json:
3782         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3783         (BubbleQueueServer):
3784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3785         (WebKitBuildbot):
3786         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3787         * QueueStatusServer/config/queues.py:
3788         * Scripts/webkitpy/common/config/ews.json:
3789         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3790         (test_ews_name):
3791
3792 2019-02-27  John Wilander  <wilander@apple.com>
3793
3794         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3795         https://bugs.webkit.org/show_bug.cgi?id=195071
3796         <rdar://problem/48417690>
3797
3798         Reviewed by Alex Christensen and Brent Fulgham.
3799
3800         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3801         (TestWebKitAPI::createURL):
3802             Convenience function.
3803         (TestWebKitAPI::TEST):
3804             WebCore::AdClickAttribution now takes a URL when creating Source and
3805             Destination.
3806         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3807         (TestWebKitAPI::TEST):
3808             WebCore::AdClickAttribution now takes a URL when creating Source and
3809             Destination.
3810
3811 2019-02-27  Antoine Quint  <graouts@apple.com>
3812
3813         Support Pointer Events on macOS
3814         https://bugs.webkit.org/show_bug.cgi?id=195008
3815         <rdar://problem/47454419>
3816
3817         Reviewed by Dean Jackson.
3818
3819         * DumpRenderTree/mac/DumpRenderTree.mm:
3820         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3821         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3822
3823 2019-02-26  Mark Lam  <mark.lam@apple.com>
3824
3825         Remove remaining poisoning code.
3826         https://bugs.webkit.org/show_bug.cgi?id=194138
3827
3828         Reviewed by Saam Barati.
3829
3830         * TestWebKitAPI/CMakeLists.txt:
3831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3832         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3833         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3834         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3835         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3836         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3837         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3838
3839 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3840
3841         Move ephemeral local storage from WebProcess to UIProcess
3842         https://bugs.webkit.org/show_bug.cgi?id=195074
3843         <rdar://problem/47937975>
3844
3845         Reviewed by Geoff Garen.
3846
3847         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3848
3849 2019-02-20  Jer Noble  <jer.noble@apple.com>
3850
3851         [Cocoa] Media elements will restart network buffering just before suspending
3852         https://bugs.webkit.org/show_bug.cgi?id=193691
3853
3854         Reviewed by Eric Carlson.
3855
3856         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3857         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3858         (TEST):
3859
3860 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3861
3862         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3863         https://bugs.webkit.org/show_bug.cgi?id=191652
3864
3865         Reviewed by Alex Christensen.
3866
3867         Fix WinCairo MiniBrowser behavior of authentication dialog.
3868
3869         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3870         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3871
3872 2019-02-26  Youenn Fablet  <youenn@apple.com>
3873
3874         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3875         https://bugs.webkit.org/show_bug.cgi?id=195028
3876         <rdar://problem/48243733>
3877
3878         Reviewed by Eric Carlson.
3879
3880         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3881
3882 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3883
3884         [WPE] Add API for webview background color configuration
3885         https://bugs.webkit.org/show_bug.cgi?id=192305
3886
3887         Reviewed by Michael Catanzaro.
3888
3889         * MiniBrowser/wpe/main.cpp:
3890         (main): Add a new option to configure the webview background
3891         color. Example: --bg-color=transparent.
3892         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3893         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3894         (beforeAll): Ditto.
3895
3896 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3897
3898         scalableNativeWebpageParameters() is not preserved on new page navigation.
3899         https://bugs.webkit.org/show_bug.cgi?id=194892
3900         <rdar://problem/47538280>
3901
3902         Reviewed by Wenson Hsieh.
3903         
3904         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3905
3906         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3907         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3908         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3909         (WTR::UIScriptController::allowsViewportShrinkToFit):
3910         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3911         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3912         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3913         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3914         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3915         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3916
3917 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3918
3919         [ews-app] Add model for handling multiple Buildbot instances
3920         https://bugs.webkit.org/show_bug.cgi?id=194863
3921
3922         Reviewed by Stephanie Lewis.
3923
3924         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3925
3926 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3927
3928         [ews-app] Remove BuilderMapping table
3929         https://bugs.webkit.org/show_bug.cgi?id=194961
3930
3931         Reviewed by Stephanie Lewis.
3932
3933         Store builder name directly in build table, instead of having a separate
3934         table for it.
3935
3936         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3937         * BuildSlaveSupport/ews-app/ews/models/build.py:
3938         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3939         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3940
3941 2019-02-25  John Wilander  <wilander@apple.com>
3942
3943         Introduce and adopt new class RegistrableDomain for eTLD+1
3944         https://bugs.webkit.org/show_bug.cgi?id=194791
3945         <rdar://problem/48179240>
3946
3947         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3948
3949         This patch adds an API test and replaces two instances of
3950         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3951
3952         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3953         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3954         (TestWebKitAPI::TEST):
3955             Changed two strings to make sure the registrable domains are still considered
3956             invalid and pass the test.
3957         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3958         (TestWebKitAPI::TEST):
3959         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3960         (WTR::InjectedBundle::didReceiveMessageToPage):
3961
3962 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3963
3964         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3965         https://bugs.webkit.org/show_bug.cgi?id=195001
3966
3967         Reviewed by Carlos Garcia Campos.
3968
3969         API version 1.0 always includes the functionality previously guarded with
3970         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3971         unconditionally.
3972
3973         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3974         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3975         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3976         (WebViewTest::showInWindow): Ditto.
3977         (WebViewTest::hideView): Ditto.
3978         * wpe/backends/HeadlessViewBackend.cpp:
3979         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3980         * wpe/backends/ViewBackend.cpp:
3981         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3982         * wpe/backends/WindowViewBackend.cpp:
3983         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3984         WPE_BACKEND_CHECK_VERSION().
3985         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3986
3987 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3988
3989         [Flatpak] Add support for flatpak > 1.1.2
3990         https://bugs.webkit.org/show_bug.cgi?id=194088
3991
3992         Flatpak 1.2 is now out so we need to support that
3993         version now.
3994
3995         Reviewed by Michael Catanzaro.
3996
3997         * flatpak/flatpakutils.py:
3998         (check_flatpak):
3999         (FlatpakPackages.__init__):
4000         (FlatpakPackages.__detect_packages):
4001         (FlatpakPackages.__detect_packages.in):
4002         (FlatpakRepos.update):
4003
4004 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4005
4006         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4007         https://bugs.webkit.org/show_bug.cgi?id=194998
4008
4009         Reviewed by Carlos Garcia Campos.
4010
4011         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4012         to a Git checkout and using the latest commit containing various fixes
4013         and improvements.
4014
4015 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4016
4017         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4018         https://bugs.webkit.org/show_bug.cgi?id=194981
4019
4020         Reviewed by Žan Doberšek.
4021
4022         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4023         (TestWebKitAPI::TEST):
4024
4025 2019-02-23  Keith Miller  <keith_miller@apple.com>
4026
4027         Add new mac target numbers
4028         https://bugs.webkit.org/show_bug.cgi?id=194955
4029
4030         Reviewed by Tim Horton.
4031
4032         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4033         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4034         * MiniBrowser/Configurations/Base.xcconfig:
4035         * TestWebKitAPI/Configurations/Base.xcconfig:
4036         * WebKitTestRunner/Configurations/Base.xcconfig:
4037
4038 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4039
4040         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4041         https://bugs.webkit.org/show_bug.cgi?id=194846
4042
4043         Reviewed by Don Olmstead.
4044
4045         Added _search_paths() and _port_specific_expectations_files() for
4046         WinCairoPort.
4047
4048         * Scripts/webkitpy/port/win.py:
4049         (WinCairoPort.default_baseline_search_path):
4050         (WinCairoPort):
4051         (WinCairoPort._port_specific_expectations_files):
4052         (WinCairoPort._search_paths):
4053
4054 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4055
4056         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4057         https://bugs.webkit.org/show_bug.cgi?id=194963
4058
4059         Reviewed by Dean Jackson.
4060
4061         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4062         Do a `contains` check instead of `equals`, because in debug builds we
4063         put the GraphicsLayer pointer in a prefix.
4064
4065 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4066
4067         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4068         https://bugs.webkit.org/show_bug.cgi?id=194873
4069         <rdar://problem/46701974>
4070
4071         Reviewed by Tim Horton.
4072
4073         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4074
4075         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4076         (WTR::UIScriptController::menuRect const):
4077         (WTR::UIScriptController::isShowingMenu const):
4078         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4079         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4080         (WTR::UIScriptController::menuRect const):
4081
4082         Add a function to query the bounds of the callout menu in content coordinates.
4083
4084         (WTR::UIScriptController::isShowingMenu const):
4085
4086         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4087
4088         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4089         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4090         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4091         (WTR::UIScriptController::rectForMenuAction const):
4092         (WTR::UIScriptController::menuRect const):
4093         (WTR::UIScriptController::isShowingMenu const):
4094         (WTR::findViewInHierarchyOfType): Deleted.
4095
4096 2019-02-22  Chris Dumez  <cdumez@apple.com>
4097
4098         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4099         https://bugs.webkit.org/show_bug.cgi?id=194954
4100         <rdar://problem/48127957>
4101
4102         Reviewed by Alex Christensen.
4103
4104         Add API test coverage.
4105
4106         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4107         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4108         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4109         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4110
4111 2019-02-22  Chris Dumez  <cdumez@apple.com>
4112
4113         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4114         https://bugs.webkit.org/show_bug.cgi?id=194924
4115         <rdar://problem/48216125>
4116
4117         Reviewed by Geoffrey Garen.
4118
4119         Add API test coverage.
4120
4121         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4122
4123 2019-02-22  Chris Dumez  <cdumez@apple.com>
4124
4125         Unreviewed, disable API test added in r241928 on iOS.
4126
4127         The cache is not enabled on devices with less than 3GB of RAM.
4128
4129         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4130
4131 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4132
4133         Hardcode Visual Viewports on everywhere except iOS WK1
4134         https://bugs.webkit.org/show_bug.cgi?id=194928
4135
4136         Reviewed by Zalan Bujtas.
4137
4138         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4139         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4140         set it to false. The setting has shipped for several years and there's no need to turn
4141         it off now.
4142
4143         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4144         Visual Viewports are not enabled.
4145         
4146         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4147         that only runs in WK2
4148
4149         * MiniBrowser/mac/SettingsController.h:
4150         * MiniBrowser/mac/SettingsController.m:
4151         (-[SettingsController init]):
4152         (-[SettingsController _populateMenu]):
4153         (-[SettingsController validateMenuItem:]):
4154         (-[SettingsController visualViewportEnabled]): Deleted.
4155         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4156         * MiniBrowser/mac/WK1BrowserWindowController.m:
4157         (-[WK1BrowserWindowController didChangeSettings]):
4158         * MiniBrowser/mac/WK2BrowserWindowController.m:
4159         (-[WK2BrowserWindowController didChangeSettings]):
4160
4161 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4162
4163         Discard cached processes when clearing website data store
4164         https://bugs.webkit.org/show_bug.cgi?id=194894
4165
4166         Reviewed by Chris Dumez.
4167
4168         Added a test case.
4169
4170         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4171         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4172
4173 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4174
4175         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4176         https://bugs.webkit.org/show_bug.cgi?id=194914
4177         <rdar://problem/47586889>
4178
4179         Reviewed by Geoffrey Garen.
4180
4181         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4182         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4183         (TEST):
4184         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4185
4186 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4187
4188         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4189         <https://webkit.org/b/194761>
4190
4191         Reviewed by Myles Maxfield.
4192
4193         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4194         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4195         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4196         to use ARC-compliant cast.
4197         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4198         ARC-compliant cast.
4199         (WTR::installFakeHelvetica): Log `error` to console if
4200         CTFontManagerRegisterFontsForURL() fails, but only on supported
4201         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4202         Call CFRelease() on `error` to fix the leak.  Update to use
4203         ARC-compliant cast.
4204         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4205         cast.
4206
4207 2019-02-21  Chris Dumez  <cdumez@apple.com>
4208
4209         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4210         https://bugs.webkit.org/show_bug.cgi?id=194481
4211
4212         Reviewed by Alex Christensen.
4213
4214         Give the processes a chance to shutdown and wait until we reached the expected number
4215         of processes.
4216
4217         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4218
4219 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4220
4221         Fix the macOS build
4222
4223         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4224
4225 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4226
4227         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4228
4229         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4230         I am a backwards.
4231
4232 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4233
4234         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4235
4236         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4237         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4238         We could force on UI-side compositing, but I feel like the test might be more
4239         valuable exercising the normal path on each platform (though the original
4240         bug was also UI-side specific). Though we can't validate that the overlay
4241         layer was installed successfully, there are layout tests that do that.
4242
4243 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4244
4245         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4246         https://bugs.webkit.org/show_bug.cgi?id=194845
4247         <rdar://problem/47944579>
4248
4249         Reviewed by Antti Koivisto.
4250
4251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4252         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4253
4254 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4255
4256         [LFC][Floats] Add support for placing formatting roots in-between floats.
4257         https://bugs.webkit.org/show_bug.cgi?id=194902
4258
4259         Reviewed by Antti Koivisto.
4260
4261         * LayoutReloaded/misc/LFC-passing-tests.txt:
4262
4263 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4264
4265         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4266         https://bugs.webkit.org/show_bug.cgi?id=194901
4267
4268         Unreviewed build fix.
4269
4270         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4271         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4272         WPEBackend-fdo-0.1 as library name.
4273
4274 2019-02-21  Rob Buis  <rbuis@igalia.com>
4275
4276         Update MIME type parser
4277         https://bugs.webkit.org/show_bug.cgi?id=180526
4278
4279         Reviewed by Darin Adler.
4280
4281         Add tests involving leading and trailing whitespace, non-token
4282         characters and quoted strings.
4283
4284         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4285         (TestWebKitAPI::TEST):
4286
4287 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4288
4289         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4290         https://bugs.webkit.org/show_bug.cgi?id=194884
4291
4292         Reviewed by Michael Catanzaro.
4293
4294         * PlatformWin.cmake:
4295
4296 2019-02-20  Chris Dumez  <cdumez@apple.com>
4297
4298         Add API test for <rdar://problem/47471222>
4299         https://bugs.webkit.org/show_bug.cgi?id=194847
4300
4301         Reviewed by Alex Christensen.
4302
4303         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4304
4305 2019-02-20  Chris Dumez  <cdumez@apple.com>
4306
4307         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4308         https://bugs.webkit.org/show_bug.cgi?id=194872
4309         <rdar://problem/47924500>
4310
4311         Reviewed by Alex Christensen.
4312
4313         Add API test coverage.
4314
4315         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4316
4317 2019-02-20  Jer Noble  <jer.noble@apple.com>
4318
4319         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4320         https://bugs.webkit.org/show_bug.cgi?id=191332
4321
4322         Reviewed by Dean Jackson.
4323
4324         * Scripts/git-is-in-range: Added.
4325
4326 2019-02-20  Andy Estes  <aestes@apple.com>
4327
4328         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4329         https://bugs.webkit.org/show_bug.cgi?id=194869
4330
4331         Rubber-stamped by Jer Noble.
4332
4333         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4334         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4335         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4336         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4338         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4339
4340 2019-02-20  Chris Dumez  <cdumez@apple.com>
4341
4342         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4343         https://bugs.webkit.org/show_bug.cgi?id=194857
4344         <rdar://problem/47759323>
4345
4346         Reviewed by Alex Christensen.
4347
4348         Add API test coverage.
4349
4350         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4351
4352 2019-02-20  Chris Dumez  <cdumez@apple.com>
4353
4354         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4355         https://bugs.webkit.org/show_bug.cgi?id=194829
4356         <rdar://problem/47889906>
4357
4358         Reviewed by Alexey Proskuryakov.
4359
4360         Every time the TestOptions were changing we were creating both a new Web view and
4361         a new WKContext, which would start a new Network process. In most cases, we only
4362         need to contruct a new Web view and we do can keep reusing the same WKContext.
4363         This patch implements this optimization and thus avoids spinning a lot of new
4364         Network processes while running the layout tests.
4365
4366         * WebKitTestRunner/TestController.cpp:
4367         (WTR::TestController::generateContextConfiguration const):
4368         (WTR::TestController::generatePageConfiguration):
4369         (WTR::TestController::createWebViewWithOptions):
4370         (WTR::TestController::resetPreferencesToConsistentValues):