[ews-build] Add unit tests for PrintConfiguration
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Add unit tests for PrintConfiguration
4         https://bugs.webkit.org/show_bug.cgi?id=196752
5
6         Reviewed by Dewei Zhu.
7
8         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
9
10 2019-04-09  Keith Rollin  <krollin@apple.com>
11
12         Unreviewed build maintenance -- update .xcfilelists.
13
14         * DumpRenderTree/DerivedSources-input.xcfilelist:
15         * DumpRenderTree/DerivedSources-output.xcfilelist:
16
17 2019-04-09  Zalan Bujtas  <zalan@apple.com>
18
19         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
20         https://bugs.webkit.org/show_bug.cgi?id=196743
21         <rdar://problem/43897551>
22
23         Reviewed by Tim Horton.
24
25         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
26         (TEST):
27
28 2019-04-09  Youenn Fablet  <youenn@apple.com>
29
30         Close service worker database on network process suspension
31         https://bugs.webkit.org/show_bug.cgi?id=196623
32         <rdar://problem/48930869>
33
34         Reviewed by Alex Christensen.
35
36         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
37
38 2019-04-09  Daniel Bates  <dabates@apple.com>
39
40         [iPad] Should open popover when the spacebar is pressed
41         https://bugs.webkit.org/show_bug.cgi?id=196360
42         <rdar://problem/49389129>
43
44         Reviewed by Brent Fulgham.
45
46         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
47
48         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
49         (WTR::UIScriptController::isShowingPopover const): Added.
50         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
51         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
52         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
53         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
54         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
55         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
56         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
57         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
58         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
59         (WTR::UIScriptController::isShowingPopover const): Added.
60         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
61         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
62         * TestRunnerShared/UIScriptContext/UIScriptController.h:
63         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
64         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
65         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
66         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
67         (-[TestRunnerWKWebView _willPresentPopover]): Added.
68         (-[TestRunnerWKWebView _didDismissPopover]): Added.
69         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
70         (WTR::UIScriptController::isShowingPopover const): Added.
71         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
72         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
73
74 2019-04-09  Alex Christensen  <achristensen@webkit.org>
75
76         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
77         https://bugs.webkit.org/show_bug.cgi?id=196665
78         <rdar://45115669>
79
80         Reviewed by Geoff Garen.
81
82         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
83         (goBack):
84         (+[SimpleLookupContext sharedLookupContext]):
85         (-[SimpleLookupContext lookUpURL:completionHandler:]):
86         (TEST):
87         (+[Simple3LookupContext sharedLookupContext]): Deleted.
88         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
89
90 2019-04-09  John Wilander  <wilander@apple.com>
91
92         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
93         https://bugs.webkit.org/show_bug.cgi?id=196558
94         <rdar://problem/47650245>
95
96         Reviewed by Youenn Fablet.
97
98         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
99         (TestWebKitAPI::TEST):
100             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
101
102 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
103
104         [CMake] Apple builds should use ICU_INCLUDE_DIRS
105         https://bugs.webkit.org/show_bug.cgi?id=196720
106
107         Reviewed by Konstantin Tokarev.
108
109         * TestWebKitAPI/PlatformMac.cmake:
110
111 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
112
113         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
114         https://bugs.webkit.org/show_bug.cgi?id=196694
115         <rdar://problem/48388734>
116
117         Rubber-stamped by Aakash Jain.
118
119         * Scripts/webkitpy/port/image_diff.py:
120         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
121         * Scripts/webkitpy/port/server_process.py:
122         (ServerProcess.has_available_stdout): Check if stdout has data in it.
123         (ServerProcess._wait_for_data_and_update_buffers_using_select):
124         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
125         * Scripts/webkitpy/port/server_process_mock.py:
126         (MockServerProcess.has_available_stdout):
127         * Scripts/webkitpy/port/server_process_unittest.py:
128         (TestServerProcess.serial_test_basic):
129
130 2019-04-09  Jer Noble  <jer.noble@apple.com>
131
132         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
133         https://bugs.webkit.org/show_bug.cgi?id=196097
134
135         Reviewed by Eric Carlson.
136
137         Drive-by bug fix: allow tests to play audio without a user gesture by default.
138
139         * DumpRenderTree/mac/DumpRenderTree.mm:
140         (resetWebPreferencesToConsistentValues):
141         * WebKitTestRunner/TestController.cpp:
142         (WTR::TestController::resetPreferencesToConsistentValues):
143
144 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
145
146         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
147         https://bugs.webkit.org/show_bug.cgi?id=196690
148
149         Reviewed by Michael Catanzaro.
150
151         * QueueStatusServer/config/queues.py:
152         * Scripts/webkitpy/common/config/ews.json:
153         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
154         (test_ews_name):
155
156 2019-04-09  Chris Dumez  <cdumez@apple.com>
157
158         Loads using loadHTMLString() cause flashing when process-swapping
159         https://bugs.webkit.org/show_bug.cgi?id=196714
160         <rdar://problem/49637354>
161
162         Reviewed by Antti Koivisto.
163
164         Add API test coverage.
165
166         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
167
168 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
169
170         Unreviewed. Fix ATK accessibility tests after r244059.
171
172         We are failing to load the injected bundle due to undefined symbol
173         AccessibilityUIElement::replaceTextInRange().
174
175         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
176         (WTR::AccessibilityUIElement::replaceTextInRange):
177
178 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
179
180         AX: Support API: accessibilityReplaceRange:withText
181         https://bugs.webkit.org/show_bug.cgi?id=196636
182
183         Unreviewed build fix for Windows port.
184
185         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
186         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
187
188 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
189
190         [CMake][WinCairo] Separate copied headers into different directories
191         https://bugs.webkit.org/show_bug.cgi?id=196655
192
193         Reviewed by Michael Catanzaro.
194
195         * DumpRenderTree/CMakeLists.txt:
196         * MiniBrowser/win/CMakeLists.txt:
197         * TestWebKitAPI/CMakeLists.txt:
198         * TestWebKitAPI/PlatformWin.cmake:
199
200 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
201
202         Log stack-trace for run-webkit-tests when interrupted
203         https://bugs.webkit.org/show_bug.cgi?id=176393
204         <rdar://problem/34262310>
205
206         Reviewed by Lucas Forschler.
207
208         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
209         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
210         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
211         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
212         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
213         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
214         (main): Set handlers to log stack trace on interruption.
215
216 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
217
218         AX: Support API: accessibilityReplaceRange:withText
219         https://bugs.webkit.org/show_bug.cgi?id=196636
220
221         Unreviewed build fix for Windows port.
222
223         * DumpRenderTree/AccessibilityUIElement.cpp:
224         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
225
226 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
227
228         [ews-build] Scripts using Buildbot API have CORS error
229         https://bugs.webkit.org/show_bug.cgi?id=196709
230
231         Reviewed by Alexey Proskuryakov.
232
233         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
234
235 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
236
237         AX: Support API: accessibilityReplaceRange:withText
238         https://bugs.webkit.org/show_bug.cgi?id=196636
239
240         Reviewed by Daniel Bates.
241
242         * DumpRenderTree/AccessibilityUIElement.cpp:
243         (replaceTextInRangeCallback):
244         (AccessibilityUIElement::replaceTextInRange):
245         (AccessibilityUIElement::getJSClass):
246         * DumpRenderTree/AccessibilityUIElement.h:
247         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
248         (AccessibilityUIElement::replaceTextInRange):
249         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
250         (AccessibilityUIElement::replaceTextInRange):
251         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
252         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
253         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
254         (WTR::AccessibilityUIElement::replaceTextInRange):
255         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
256         (WTR::AccessibilityUIElement::replaceTextInRange):
257
258 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
259
260         [iOS] Do not allow starting selection drags when selection views are not visible
261         https://bugs.webkit.org/show_bug.cgi?id=196686
262         <rdar://problem/49399192>
263
264         Reviewed by Tim Horton.
265
266         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
267         also add some new API tests to cover scenarios where the web view is not first responder.
268
269         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
270         (TestWebKitAPI::TEST):
271         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
272
273         Add a switch to optionally make the web view first responder when starting the simulated drag.
274
275         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
276         (-[DragAndDropSimulator initWithWebView:]):
277         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
278
279 2019-04-08  Justin Fan  <justin_fan@apple.com>
280
281         [Web GPU] Fix Web GPU experimental feature on iOS
282         https://bugs.webkit.org/show_bug.cgi?id=196632
283
284         Reviewed by Myles C. Maxfield.
285
286         Properly make Web GPU available on iOS 11+.
287
288         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
289
290 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
291
292         [ews-build] Do not upload archive when Compile Fails
293         https://bugs.webkit.org/show_bug.cgi?id=196674
294
295         Reviewed by Alexey Proskuryakov.
296
297         * BuildSlaveSupport/ews-build/factories.py:
298         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
299         * BuildSlaveSupport/ews-build/steps.py:
300         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
301         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
302         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
303
304 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
305
306         Enable DFG on MIPS
307         https://bugs.webkit.org/show_bug.cgi?id=196689
308
309         Reviewed by Žan Doberšek.
310
311         Since the bytecode change, we enabled the baseline JIT on mips in
312         r240432, but DFG is still missing. With this change, all tests are
313         passing on a ci20 board.
314
315         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
316
317 2019-04-08  Philippe Normand  <pnormand@igalia.com>
318
319         [Flatpak] Second run update-webkitwpe-flatpak fails
320         https://bugs.webkit.org/show_bug.cgi?id=192702
321
322         Reviewed by Carlos Garcia Campos.
323
324         * flatpak/flatpakutils.py:
325         (FlatpakObject.flatpak): Fix typo.
326         (FlatpakPackage.install): When installing, also update to the configured remote commit.
327         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
328
329 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
330
331         [GTK][WPE] outlook.live.com displays old-fashioned UI
332         https://bugs.webkit.org/show_bug.cgi?id=196642
333
334         Reviewed by Carlos Garcia Campos.
335
336         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
337         (TestWebKitAPI::TEST): New Mac platform quirk test.
338
339 2019-04-07  Commit Queue  <commit-queue@webkit.org>
340
341         Unreviewed, rolling out r243956.
342         https://bugs.webkit.org/show_bug.cgi?id=196688
343
344         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
345         by aakashjain on #webkit).
346
347         Reverted changeset:
348
349         "Clicking "Go Back" from a safe browsing warning from an
350         iframe should navigate the WKWebView back to the previous
351         page"
352         https://bugs.webkit.org/show_bug.cgi?id=196665
353         https://trac.webkit.org/changeset/243956
354
355 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
356
357         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
358         https://bugs.webkit.org/show_bug.cgi?id=196669
359
360         Reviewed by Geoffrey Garen.
361
362         Added three new unit tests for WeakHashSet.
363
364         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
365         (WTF_WeakPtr.WeakHashSetConstObjects):
366         (WTF_WeakPtr.WeakHashSetComputesEmpty):
367         (WTF_WeakPtr.WeakHashSetComputeSize):
368
369 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
370
371         Hide next and previous form control buttons when WKWebView is editable
372         https://bugs.webkit.org/show_bug.cgi?id=196672
373         <rdar://problem/35625321>
374
375         Reviewed by Tim Horton.
376
377         Add a new API test.
378
379         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
380         (-[TestWKWebView lastTrailingBarButtonGroup]):
381         (TestWebKitAPI::TEST):
382         * TestWebKitAPI/ios/UIKitSPI.h:
383
384 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
385
386         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
387         https://bugs.webkit.org/show_bug.cgi?id=196077
388         <rdar://problem/49108202>
389
390         Reviewed by Chris Dumez.
391
392         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
393         on new web view.
394
395         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
396
397 2019-04-05  Saam Barati  <sbarati@apple.com>
398
399         Make compare-results understand MotionMark
400         https://bugs.webkit.org/show_bug.cgi?id=196666
401
402         Reviewed by Yusuke Suzuki.
403
404         * Scripts/compare-results:
405         (PLT5Results):
406         (detectMotionMark):
407         (detectMotionMark1_1):
408         (motionMarkResults):
409         (motionMark1_1Results):
410         (detectBenchmark):
411         (biggerIsBetter):
412         (main):
413
414 2019-04-05  Alex Christensen  <achristensen@webkit.org>
415
416         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
417         https://bugs.webkit.org/show_bug.cgi?id=196665
418         <rdar://45115669>
419
420         Reviewed by Geoff Garen.
421
422         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
423         (goBack):
424         (+[SimpleLookupContext sharedLookupContext]):
425         (-[SimpleLookupContext lookUpURL:completionHandler:]):
426         (TEST):
427         (+[Simple3LookupContext sharedLookupContext]): Deleted.
428         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
429
430 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
431
432         [ews-build] Add configuration and architecture for windows builders
433         https://bugs.webkit.org/show_bug.cgi?id=196660
434
435         Reviewed by Lucas Forschler.
436
437         * BuildSlaveSupport/ews-build/config.json:
438
439 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
440
441         webkitpy: Don't run subsequent rounds if interrupted
442         https://bugs.webkit.org/show_bug.cgi?id=196646
443
444         Reviewed by Aakash Jain.
445
446         * Scripts/webkitpy/layout_tests/controllers/manager.py:
447         (Manager.run): Bail out if interrupted.
448
449 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
450
451         Test sessionStorage in PSON private browsing mode
452         https://bugs.webkit.org/show_bug.cgi?id=196561
453
454         Reviewed by Alex Christensen.
455
456         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
457
458 2019-04-05  Commit Queue  <commit-queue@webkit.org>
459
460         Unreviewed, rolling out r243833.
461         https://bugs.webkit.org/show_bug.cgi?id=196645
462
463         This change breaks build of WPE and GTK ports (Requested by
464         annulen on #webkit).
465
466         Reverted changeset:
467
468         "[CMake][WTF] Mirror XCode header directories"
469         https://bugs.webkit.org/show_bug.cgi?id=191662
470         https://trac.webkit.org/changeset/243833
471
472 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
473
474         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
475         https://bugs.webkit.org/show_bug.cgi?id=196635
476
477         Reviewed by Antti Koivisto.
478         
479         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
480         for a test to enable async frame scrolling via:
481             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
482         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
483         
484         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
485
486         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
487         (WTR::InjectedBundle::beginTesting):
488         * WebKitTestRunner/TestController.cpp:
489         (WTR::TestController::resetPreferencesToConsistentValues):
490
491 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
492
493         Use a correct LC_RPATH when building with ASan
494         https://bugs.webkit.org/show_bug.cgi?id=196576
495
496         Reviewed by David Kilzer.
497
498         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
499         so that ../Frameworks is checked. This is simpler and more reliable than updating
500         each SPC service xcconfig.
501
502 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
503
504         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
505         https://bugs.webkit.org/show_bug.cgi?id=196629
506
507         Reviewed by Lucas Forschler.
508
509         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
510
511 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
512
513         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
514         https://bugs.webkit.org/show_bug.cgi?id=196618
515
516         Reviewed by Lucas Forschler.
517
518         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
519         (StatusBubble): Added QUEUE_TRIGGERS.
520         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
521         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
522         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
523         its parent(builder).
524
525 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
526
527         [ews-app] Status-bubble steps are sometimes displayed in reverse order
528         https://bugs.webkit.org/show_bug.cgi?id=196625
529
530         Reviewed by Lucas Forschler.
531
532         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
533         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
534
535 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
536
537         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
538         https://bugs.webkit.org/show_bug.cgi?id=196630
539
540         Reviewed by Wenson Hsieh.
541
542         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
543
544 2019-04-04  Youenn Fablet  <youenn@apple.com>
545
546         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
547         https://bugs.webkit.org/show_bug.cgi?id=196543
548
549         Reviewed by Alex Christensen.
550
551         * WebKitTestRunner/TestController.cpp:
552         (WTR::TestController::generatePageConfiguration):
553
554 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
555
556         [ews-app] Status bubble should not display skipped buildbot steps
557         https://bugs.webkit.org/show_bug.cgi?id=196584
558
559         Reviewed by Lucas Forschler.
560
561         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
562
563 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
564
565         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
566         https://bugs.webkit.org/show_bug.cgi?id=196620
567
568         Reviewed by Lucas Forschler.
569
570         * BuildSlaveSupport/ews-app/ews/config.py:
571
572 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
573
574         [Win] DumpRenderTreeWatchDog.py is not checked into source
575         https://bugs.webkit.org/show_bug.cgi?id=196567
576         <rdar://problem/49525901>
577
578         Reviewed by Lucas Forschler.
579
580         This script is used on Win EWS bots to terminate hanging DRT processes.
581
582         * EWSTools/dumprendertreewatchdog.py: Added.
583
584 2019-04-04  Chris Dumez  <cdumez@apple.com>
585
586         Unreviewed, roll out r243858 which made tests time out.
587
588         Disable new API tests on Windows instead.
589
590         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
591         (TestWebKitAPI::TEST):
592
593 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
594
595         [ATK] Cleanup WebPageAccessibilityObjectAtk
596         https://bugs.webkit.org/show_bug.cgi?id=196537
597
598         Reviewed by Michael Catanzaro.
599
600         Also consider files under atk directories as exceptions for GObject conventions.
601
602         * Scripts/webkitpy/style/checkers/cpp.py:
603         (check_identifier_name_in_declaration):
604
605 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
606
607         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
608         https://bugs.webkit.org/show_bug.cgi?id=196588
609         <rdar://problem/49365787>
610
611         Unreviewed build fix for Windows port.
612
613         error C3861: 'kill': identifier not found
614
615         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
616         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
617
618 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
619
620         [ews-build] Cancel build and similar operations should have authentication
621         https://bugs.webkit.org/show_bug.cgi?id=196520
622
623         Reviewed by Dewei Zhu.
624
625         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
626         environment variables.
627
628 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
629
630         [ews-build] Do not trigger queues which are not in production yet
631         https://bugs.webkit.org/show_bug.cgi?id=196581
632
633         Reviewed by Dewei Zhu.
634
635         * BuildSlaveSupport/ews-build/config.json:
636
637 2019-04-03  Chris Dumez  <cdumez@apple.com>
638
639         Unreviewed, fix typo in the name of API test added in r243848.
640
641         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
642         (TestWebKitAPI::TEST):
643
644 2019-04-03  Chris Dumez  <cdumez@apple.com>
645
646         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
647         https://bugs.webkit.org/show_bug.cgi?id=196588
648         <rdar://problem/49365787>
649
650         Reviewed by Ryosuke Niwa.
651
652         Add API test coverage.
653
654         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
655         (TestWebKitAPI::nullJavaScriptCallback):
656         (TestWebKitAPI::didCrashCheckFrames):
657         (TestWebKitAPI::TEST):
658
659 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
660
661         run-webkit-tests: Upload test results (new results database)
662         https://bugs.webkit.org/show_bug.cgi?id=196577
663         <rdar://problem/34841155>
664
665         Reviewed by Lucas Forschler.
666
667         * Scripts/webkitpy/layout_tests/controllers/manager.py:
668         (Manager.run): Upload results after each device shard, since the configuration will be
669         different for each device.
670         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
671         uploaded to a results database.
672         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
673         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
674
675 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
676
677         -apple-trailing-word is needed for browser detection
678         https://bugs.webkit.org/show_bug.cgi?id=196575
679
680         Unreviewed.
681
682         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
683
684 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
685
686         [CMake][WTF] Mirror XCode header directories
687         https://bugs.webkit.org/show_bug.cgi?id=191662
688
689         Reviewed by Konstantin Tokarev.
690
691         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
692         builds.
693
694         * CMakeLists.txt:
695         * DumpRenderTree/CMakeLists.txt:
696         * DumpRenderTree/PlatformWin.cmake:
697         * MiniBrowser/win/CMakeLists.txt:
698         * TestWebKitAPI/CMakeLists.txt:
699         * TestWebKitAPI/PlatformWin.cmake:
700         * WebKitTestRunner/PlatformGTK.cmake:
701         * WebKitTestRunner/PlatformWin.cmake:
702
703 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
704
705         [ews-app] Status bubble should not display certain infrastructure status messages
706         https://bugs.webkit.org/show_bug.cgi?id=196550
707
708         Reviewed by Lucas Forschler.
709
710         Do not display the steps which are un-needed for end-user. This information is still avaiable
711         if the user click on the bubble and look at the Buildbot build.
712         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
713         (StatusBubble._steps_messages):
714         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
715
716 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
717
718         [ews-build] Use https for sending data to ews-app
719         https://bugs.webkit.org/show_bug.cgi?id=196492
720
721         Reviewed by Lucas Forschler.
722
723         * BuildSlaveSupport/ews-build/events.py:
724
725 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
726
727         Remove support for -apple-trailing-word
728         https://bugs.webkit.org/show_bug.cgi?id=196525
729
730         Reviewed by Zalan Bujtas.
731
732         This CSS property is nonstandard and not used.
733
734         * Scripts/webkitperl/FeatureList.pm:
735         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
736
737 2019-04-03  Youenn Fablet  <youenn@apple.com>
738
739         Add a test for DOMCache on multiple browsing in case of private browsing
740         https://bugs.webkit.org/show_bug.cgi?id=196524
741
742         Reviewed by Alex Christensen.
743
744         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
745         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
746
747 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
748
749         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
750         https://bugs.webkit.org/show_bug.cgi?id=196540
751
752         Reviewed by Aakash Jain.
753
754         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
755
756 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
757
758         Add plumbing for a compatibility mode preference in WebKit
759         https://bugs.webkit.org/show_bug.cgi?id=196005
760
761         Reviewed by Tim Horton.
762
763         Add new API tests.
764
765         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
766         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
767
768 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
769
770         [WPE][GTK] Update libsrtp dependency package for Debian
771         https://bugs.webkit.org/show_bug.cgi?id=196528
772
773         Reviewed by Frédéric Wang.
774
775         * gtk/install-dependencies:
776         * wpe/install-dependencies:
777
778 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
779
780         [WK2] Add support for Window's beforeprint / afterprint events
781         https://bugs.webkit.org/show_bug.cgi?id=196478
782         <rdar://problem/49535124>
783
784         Unreviewed build fix for MSVC.
785
786         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
787
788         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
789
790         * WebKitTestRunner/TestController.cpp:
791         (WTR::printFrame): Use int and float literals.
792
793 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
794
795         [ews-build] Reassign bots to queues
796
797         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
798
799 2019-04-02  Chris Dumez  <cdumez@apple.com>
800
801         [WK2] Add support for Window's beforeprint / afterprint events
802         https://bugs.webkit.org/show_bug.cgi?id=196478
803
804         Reviewed by Alex Christensen.
805
806         Add minimal implementation for printFrame in WebKitTestRunner.
807
808         * WebKitTestRunner/TestController.cpp:
809         (WTR::printFrame):
810         (WTR::TestController::createOtherPage):
811         (WTR::TestController::createWebViewWithOptions):
812
813 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
814
815         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
816         https://bugs.webkit.org/show_bug.cgi?id=196491
817
818         Reviewed by Lucas Forschler.
819
820         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
821
822 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
823
824         [ews-build] Configure buildbot try credentials in environment variables
825         https://bugs.webkit.org/show_bug.cgi?id=196501
826
827         Reviewed by Lucas Forschler.
828
829         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
830         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
831         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
832
833 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
834
835         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
836         https://bugs.webkit.org/show_bug.cgi?id=196496
837         <rdar://problem/49521634>
838
839         Reviewed by Chris Dumez.
840
841         Add new API tests (see WebKit ChangeLog for more detail).
842
843         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
844         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
845         (TEST):
846
847 2019-04-02  David Kilzer  <ddkilzer@apple.com>
848
849         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
850         <https://webkit.org/b/196499>
851
852         Reviewed by Alexey Proskuryakov.
853
854         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
855         ENABLE_ADDRESS_SANITIZER.
856
857 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
858
859         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
860         https://bugs.webkit.org/show_bug.cgi?id=182757
861
862         Reviewed by Don Olmstead.
863
864         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
865         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
866
867 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
868
869         run-api-tests: Upload test results
870         https://bugs.webkit.org/show_bug.cgi?id=196323
871         <rdar://problem/49356714>
872
873         Reviewed by Lucas Forschler.
874
875         * Scripts/webkitpy/api_tests/manager.py:
876         (Manager):
877         (Manager.run): Upload results to a results database.
878         * Scripts/webkitpy/api_tests/run_api_tests.py:
879         (parse_args): Add upload arguments.
880         * Scripts/webkitpy/port/base.py:
881         (Port):
882         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
883         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
884         with commits from any other associated repositories.
885         * Scripts/webkitpy/port/device.py:
886         (Device):
887         (Device.build_version): Access build_versoin of underlying platform device.
888         * Scripts/webkitpy/port/ios_simulator_unittest.py:
889         (IOSSimulatorTest):
890         (IOSSimulatorTest.test_configuration_for_upload):
891         * Scripts/webkitpy/port/device_port.py:
892         (DevicePort):
893         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
894         the same as the machine uploading results.
895         * Scripts/webkitpy/port/mac.py:
896         (MacPort):
897         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
898         * Scripts/webkitpy/port/mac_unittest.py:
899         (MacTest):
900         (MacTest.test_configuration_for_upload):
901         * Scripts/webkitpy/xcode/simulated_device.py:
902         (SimulatedDeviceManager._create_device_with_runtime):
903         (SimulatedDevice.__init__): Create simulated device with a build_version.
904         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
905         (test_existing_simulator):
906
907 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
908
909         Remove extra newline characters (Follow-up fix to r243707)
910
911         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
912
913 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
914
915         [ews-app] Use API_KEY to accept results data
916         https://bugs.webkit.org/show_bug.cgi?id=196461
917
918         Reviewed by Dewei Zhu.
919
920         * BuildSlaveSupport/ews-app/ews/views/results.py:
921         (Results.post): Validate EWS_API_KEY before accepting any data.
922         * BuildSlaveSupport/ews-build/events.py:
923         (Events.sendData): Send EWS_API_KEY if available along with event data.
924
925 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
926
927         Unable to copy and paste a PDF from Notes into Mail compose body
928         https://bugs.webkit.org/show_bug.cgi?id=196442
929         <rdar://problem/48573098>
930
931         Reviewed by Tim Horton.
932
933         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
934         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
935         to be specified on the item providers.
936
937         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
938         (TestWebKitAPI::mapItemForTesting):
939         (TestWebKitAPI::contactItemForTesting):
940
941 2019-04-01  Tim Horton  <timothy_horton@apple.com>
942
943         Make UIWKDocumentContext rects per-character instead of per-word
944         https://bugs.webkit.org/show_bug.cgi?id=196459
945
946         Reviewed by Wenson Hsieh.
947
948         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
949         (TEST):
950         Adjust test results due to switching to per-character rects.
951
952 2019-04-01  Chris Dumez  <cdumez@apple.com>
953
954         UIProcess crash when a prewarmed process is terminated
955         https://bugs.webkit.org/show_bug.cgi?id=196451
956         <rdar://problem/49245471>
957
958         Reviewed by Geoffrey Garen.
959
960         Add API test coverage.
961
962         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
963         (TEST):
964
965 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
966
967         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
968         https://bugs.webkit.org/show_bug.cgi?id=196449
969
970         Reviewed by Lucas Forschler.
971
972         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
973         (StatusBubble.get_os_details): Method to get OS and Xcode details.
974         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
975         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
976
977 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
978
979         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
980         https://bugs.webkit.org/show_bug.cgi?id=196444
981
982         Reviewed by Lucas Forschler.
983
984         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
985
986 2019-04-01  Alex Christensen  <achristensen@webkit.org>
987
988         Add SPI to canonicalize NSURLs with WTF::URL
989         https://bugs.webkit.org/show_bug.cgi?id=196415
990         <rdar://problem/44980271>
991
992         Reviewed by Darin Adler.
993
994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
995         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
996         (TestWebKitAPI::TEST):
997
998 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
999
1000         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1001         https://bugs.webkit.org/show_bug.cgi?id=196441
1002
1003         Reviewed by Carlos Garcia Campos.
1004
1005         Don't cache the wpe_view_backend object that might not exist yet at the
1006         time of EventSenderProxy constructor invocation, but instead retrieve
1007         that object whenever it's required for event dispatching. This should
1008         avoid crashes in this constructor now that it's invoked before any
1009         PlatformWindow has been set up (as changed in r243496).
1010
1011         * WebKitTestRunner/EventSenderProxy.h:
1012         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1013         (WTR::viewBackend):
1014         (WTR::EventSenderProxy::EventSenderProxy):
1015         (WTR::EventSenderProxy::mouseDown):
1016         (WTR::EventSenderProxy::mouseUp):
1017         (WTR::EventSenderProxy::mouseMoveTo):
1018         (WTR::EventSenderProxy::mouseScrollBy):
1019         (WTR::EventSenderProxy::keyDown):
1020         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1021
1022 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1023
1024         [Win][WebKit] MiniBrowser should support high DPI display
1025         https://bugs.webkit.org/show_bug.cgi?id=196391
1026
1027         Reviewed by Alex Christensen.
1028
1029         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1030         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1031         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1032         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1033
1034 2019-03-31  Sam Weinig  <weinig@apple.com>
1035
1036         Remove more i386 specific configurations
1037         https://bugs.webkit.org/show_bug.cgi?id=196430
1038
1039         Reviewed by Alexey Proskuryakov.
1040
1041         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1042         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1043
1044 2019-03-31  Andy Estes  <aestes@apple.com>
1045
1046         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1047         https://bugs.webkit.org/show_bug.cgi?id=196433
1048         <rdar://problem/49293305>
1049
1050         Reviewed by Tim Horton.
1051
1052         Enhanced API test coverage to include all navigation response policy decisions in both
1053         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1054
1055         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1056         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1057         (TestWebKitAPI::TEST):
1058         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1059         (readFile):
1060         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1061         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1062         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1063         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1064         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1065         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1066         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1067         (-[QuickLookDelegate _downloadDidStart:]):
1068         (-[QuickLookDelegate _download:didReceiveResponse:]):
1069         (-[QuickLookDelegate _download:didReceiveData:]):
1070         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1071         (-[QuickLookDelegate _downloadDidFinish:]):
1072         (-[QuickLookDelegate _download:didFailWithError:]):
1073         (-[QuickLookDelegate _downloadDidCancel:]):
1074         (-[QuickLookDelegate verifyDownload]):
1075         (runTest):
1076         (runTestDecideBeforeLoading):
1077         (runTestDecideAfterLoading):
1078         (TEST):
1079         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1080         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1081         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1082         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1083         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1084         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1085         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1086         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1087         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1088         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1089         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1090         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1091         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1092         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1093
1094 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1095
1096         [CMake] add testdfg as target with build-jsc
1097         https://bugs.webkit.org/show_bug.cgi?id=196393
1098
1099         Reviewed by Saam Barati.
1100
1101         Added testdfg as one of the targets to build when
1102         using CMake.
1103
1104         * Scripts/build-jsc:
1105
1106 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1107
1108         Delete WebMetal implementation in favor of WebGPU
1109         https://bugs.webkit.org/show_bug.cgi?id=195418
1110
1111         Reviewed by Dean Jackson.
1112
1113         * DumpRenderTree/mac/DumpRenderTree.mm:
1114         (enableExperimentalFeatures):
1115         (resetWebPreferencesToConsistentValues):
1116         * Scripts/webkitperl/FeatureList.pm:
1117         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1119         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1120         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1121         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1122         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1123         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1124         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1125         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1126         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1127         (WTR::InjectedBundle::beginTesting):
1128         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1129         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1130         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1131
1132 2019-03-29  Chris Dumez  <cdumez@apple.com>
1133
1134         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1135         https://bugs.webkit.org/show_bug.cgi?id=196405
1136         <rdar://problem/49428130>
1137
1138         Reviewed by Wenson Hsieh.
1139
1140         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1141         the popover presentation methods to be no-ops. Use this in the new test added in
1142         r243523 so that we do not swizzle those methods for all tests. This is needed because
1143         those WatchOS tests rely on the popover getting presented and interactive.
1144
1145         * WebKitTestRunner/TestController.cpp:
1146         (WTR::updateTestOptionsFromTestHeader):
1147         * WebKitTestRunner/TestController.h:
1148         * WebKitTestRunner/TestOptions.h:
1149         (WTR::TestOptions::hasSameInitializationOptions const):
1150         * WebKitTestRunner/ios/TestControllerIOS.mm:
1151         (WTR::TestController::platformInitialize):
1152         (WTR::TestController::platformResetStateToConsistentValues):
1153
1154 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1155
1156         [Curl] Add Server Trust Evaluation Support.
1157         https://bugs.webkit.org/show_bug.cgi?id=191646
1158
1159         Reviewed by Fujii Hironori.
1160
1161         Implemented MiniBrowser UI for asking if user trusts the server.
1162
1163         * MiniBrowser/win/Common.cpp:
1164         (askServerTrustEvaluation):
1165         (replaceString):
1166         * MiniBrowser/win/Common.h:
1167         * MiniBrowser/win/MiniBrowserLib.rc:
1168         * MiniBrowser/win/MiniBrowserLibResource.h:
1169         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1170         (createPEMString):
1171         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1172         (WebKitBrowserWindow::canTrustServerCertificate):
1173         * MiniBrowser/win/WebKitBrowserWindow.h:
1174
1175 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1176
1177         Implement ResizeObserver.
1178         https://bugs.webkit.org/show_bug.cgi?id=157743
1179
1180         Reviewed by Simon Fraser.
1181
1182         Support resizeObserverEnabled webPreferences.
1183
1184         * DumpRenderTree/TestOptions.cpp:
1185         (TestOptions::TestOptions):
1186         * DumpRenderTree/TestOptions.h:
1187         * DumpRenderTree/mac/DumpRenderTree.mm:
1188         (setWebPreferencesForTestOptions):
1189         * DumpRenderTree/win/DumpRenderTree.cpp:
1190         (enableExperimentalFeatures):
1191         * Scripts/webkitperl/FeatureList.pm:
1192         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1193
1194 2019-03-28  John Wilander  <wilander@apple.com>
1195
1196         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1197         https://bugs.webkit.org/show_bug.cgi?id=196281
1198         <rdar://problem/48938748>
1199
1200         Reviewed by Alex Christensen.
1201
1202         This patch adds the function isStatisticsHasLocalStorage() to the
1203         TestRunner. With it, the page can query the WebsiteDataStore in the
1204         UI process to make sure that it sees LocalStorage.
1205
1206         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1207         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1208         (WTR::TestRunner::isStatisticsHasLocalStorage):
1209         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1210         * WebKitTestRunner/TestController.cpp:
1211         (WTR::TestController::isStatisticsHasLocalStorage):
1212         * WebKitTestRunner/TestController.h:
1213         * WebKitTestRunner/TestInvocation.cpp:
1214         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1215
1216 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1217
1218         API::Data::createWithoutCopying should do a null check before calling CFRelease
1219         https://bugs.webkit.org/show_bug.cgi?id=196276
1220         <rdar://problem/48059859>
1221
1222         Reviewed by Alex Christensen.
1223
1224         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1225
1226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1227         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1228         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1229         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1230         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1231         (TestWebKitAPI::TEST):
1232
1233 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1234
1235         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1236         https://bugs.webkit.org/show_bug.cgi?id=186276
1237
1238         Reviewed by Carlos Garcia Campos.
1239
1240         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1241         (webViewLoadChanged):
1242         (testWebResourceGetDataError):
1243         (testWebResourceGetDataEmpty):
1244         (beforeAll):
1245         (webViewloadChanged): Deleted.
1246
1247 2019-03-27  Andy Estes  <aestes@apple.com>
1248
1249         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1250         https://bugs.webkit.org/show_bug.cgi?id=196317
1251
1252         Reviewed by Dan Bernstein.
1253
1254         package-root copies built products into a staging directory using ditto(1), which does not
1255         follow symbolic links as it traverses a directory. Now that the files in
1256         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1257         itself, these become broken links when ditto'd into the staging directory.
1258
1259         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1260
1261         * Scripts/package-root:
1262
1263 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1264
1265         [ews-app] Update display text of Submit for ews analysis
1266         https://bugs.webkit.org/show_bug.cgi?id=196309
1267
1268         Reviewed by Dewei Zhu.
1269
1270         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1271
1272 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1273
1274         run-webkit-tests should check for leaks in WebKit processes
1275         <https://webkit.org/b/193772>
1276         <rdar://problem/46526680>
1277
1278         Reviewed by Ryosuke Niwa.
1279
1280         This works by doing the following:
1281         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1282           The list of child processes are returned one per line:
1283           process.name: pid
1284         - Run the "#LIST CHILD PROCESSES" command just before the
1285           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1286           processes on the ServerProcess object.
1287         - When the `--leaks` switch is handled, run check_for_leaks() on
1288           each child process after the main test harness.
1289
1290         * DumpRenderTree/mac/DumpRenderTree.mm:
1291         (handleControlCommand):
1292         - Use strncmp() instead of strcmp().
1293         - Add support for handling "#LIST CHILD PROCESSES" command.
1294
1295         * Scripts/webkitpy/port/base.py:
1296         (Port.check_for_leaks):
1297         * Scripts/webkitpy/port/darwin.py:
1298         (DarwinPort.check_for_leaks):
1299         - Rename redundant 'process_pid' argument to 'process_id'.
1300
1301         * Scripts/webkitpy/port/driver.py:
1302         (Driver.do_post_tests_work):
1303         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1304           longer the only command this sends to WebKitTestRunner.
1305         - If the `--leaks` switch is present, send the
1306           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1307           result using Port.set_webkit_processes().
1308         (Driver._parse_child_processes_output):
1309         - Add helper method to parse list of child process names and
1310           process IDs returned from WebKitTestRunner.
1311
1312         * Scripts/webkitpy/port/ios_device.py:
1313         (IOSDevicePort.check_for_leaks):
1314         - Rename redundant 'process_pid' argument to 'process_id'.
1315
1316         * Scripts/webkitpy/port/leakdetector.py:
1317         (LeakDetector._parse_leaks_output):
1318         - Return early if there is no leaks_output.
1319         (LeakDetector.check_for_leaks):
1320         - Rename redundant 'process_pid' argument to 'process_id'.
1321
1322         * Scripts/webkitpy/port/server_process.py:
1323         (ServerProcess.__init__):
1324         (ServerProcess.child_processes):
1325         (ServerProcess.set_child_processes):
1326         - Add instance variable to Port to store list of child process
1327           names and process IDs returned from WebKitTestRunner.
1328         (ServerProcess._start):
1329         - Clear self._child_processes.
1330         (ServerProcess.stop):
1331         - If self._child_processes is set, call
1332           self._port.check_for_leaks() for each child process.
1333
1334         * Scripts/webkitpy/port/server_process_unittest.py:
1335         (TrivialMockPort.check_for_leaks):
1336         - Rename redundant 'process_pid' argument to 'process_id'.
1337
1338         * Scripts/webkitpy/port/simulator_process.py:
1339         (SimulatorProcess.stop):
1340         - If self._child_processes is set, call
1341           self._port.check_for_leaks() for each child process.
1342
1343         * Scripts/webkitpy/port/watch_device.py:
1344         (WatchDevicePort.check_for_leaks):
1345         - Rename redundant 'process_pid' argument to 'process_id'.
1346
1347         * WebKitTestRunner/TestController.cpp:
1348         (WTR::TestController::dumpResponse):
1349         - Extract method from findAndDumpWorldLeaks() so that it may be
1350           reused by findAndDumpWebKitProcessIdentifiers().
1351         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1352         - Add method to output process name and process ID of both the
1353           WebContent and Networking processes.
1354         (WTR::TestController::findAndDumpWorldLeaks):
1355         - Fix missing newline in output when there were no abandoned
1356           documents.
1357         - Call dumpResponse() for extracted code.
1358         (WTR::TestController::handleControlCommand):
1359         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1360         - Use strncmp() instead of strcmp().
1361         - Call findAndDumpWebKitProcessIdentifiers() when
1362           "#LIST CHILD PROCESSES" command is sent.
1363         * WebKitTestRunner/TestController.h:
1364         (WTR::TestController::dumpResponse):
1365         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1366         - Declare methods.
1367
1368 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1369
1370         Unreviewed. Add GLib API test cases after r243434.
1371
1372         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1373         (testWebViewActiveURI):
1374         (serverCallback):
1375         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1376         (sendRequestCallback):
1377
1378 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1379
1380         Geolocation request not complete when watch request was started in a different web process
1381         https://bugs.webkit.org/show_bug.cgi?id=195996
1382
1383         Reviewed by Alex Christensen.
1384
1385         Add a test case.
1386
1387         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1388         (TestWebKitAPI::runJavaScriptAlert):
1389         (TestWebKitAPI::TEST):
1390
1391 2019-03-26  Keith Rollin  <krollin@apple.com>
1392
1393         Update the way generate-xcfilelists returns strings from functions
1394         https://bugs.webkit.org/show_bug.cgi?id=195975
1395         <rdar://problem/49040807>
1396
1397         Reviewed by Dean Jackson.
1398
1399         There are places where generate-xcfilelists executes assignments with
1400         statements like:
1401
1402             FOO=$(some_function)
1403
1404         where "some_function" return a string by echoing it. E.g.
1405
1406             some_function()
1407             {
1408                 echo "Hello, World"
1409             }
1410
1411         This is a common idiom, but it has a problem if "some_function" needs
1412         to call "exit" in an attempt to halt the entire script right then and
1413         there. Since "some_function" is called inside of $(), it's being
1414         executed in a sub-shell. Calling exit in that sub-shell simply exits
1415         that shell; it doesn't not exit the outer shell in which the main part
1416         of the script is still running. As such, the main script keeps
1417         executing when the intent was for the script to halt.
1418
1419         The solution to this is to use a different idiom for returning
1420         strings. The one we now is to pass in the name of the variable to
1421         receive the string result:
1422
1423             some_function()
1424             {
1425                 variable_name=$1
1426                 eval $variable_name ="Hello, World"
1427             }
1428
1429         The call site now looks like
1430
1431             some_function FOO
1432
1433         Because there's no invocation of a sub-shell, some_function can now
1434         call "exit" if it wants to, and the entire script will exit at that
1435         point.
1436
1437         * Scripts/generate-xcfilelists:
1438
1439 2019-03-26  Chris Dumez  <cdumez@apple.com>
1440
1441         Add basic layout test coverage for File Picker on iOS
1442         https://bugs.webkit.org/show_bug.cgi?id=196265
1443
1444         Reviewed by Wenson Hsieh.
1445
1446         Add layout test infrastructure to test the file picker on iOS.
1447
1448         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1449         (WTR::UIScriptController::dismissFilePicker):
1450         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1451         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1452         (WTR::UIScriptController::dismissFilePicker):
1453         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1454         * WebKitTestRunner/TestController.cpp:
1455         (WTR::TestController::createWebViewWithOptions):
1456         (WTR::updateTestOptionsFromTestHeader):
1457         * WebKitTestRunner/TestOptions.h:
1458         (WTR::TestOptions::hasSameInitializationOptions const):
1459         * WebKitTestRunner/ios/TestControllerIOS.mm:
1460         (overridePresentViewController):
1461         (WTR::TestController::platformInitialize):
1462         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1463         (WTR::UIScriptController::dismissFilePicker):
1464
1465 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1466
1467         Implement async paste method on UIWKInteractionViewProtocol
1468         https://bugs.webkit.org/show_bug.cgi?id=196267
1469         <rdar://problem/49236346>
1470
1471         Reviewed by Tim Horton.
1472
1473         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1474         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1475         are now a part of all iOS 12 internal SDKs.
1476
1477         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1478
1479         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1480         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1481
1482         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1483         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1484         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1485         * TestWebKitAPI/ios/UIKitSPI.h:
1486
1487 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1488
1489         [ews-build] Use PostgreSQL for ews.webkit.org database
1490         https://bugs.webkit.org/show_bug.cgi?id=196270
1491
1492         Reviewed by Lucas Forschler.
1493
1494         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1495
1496 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1497
1498         [ews] Reset simctl states on reboot
1499         https://bugs.webkit.org/show_bug.cgi?id=196260
1500
1501         Rubber-stamped by Aakash Jain.
1502
1503         * EWSTools/start-queue-mac.sh:
1504
1505 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1506
1507         [ews-build] Use PostgreSQL for ews-build database
1508         https://bugs.webkit.org/show_bug.cgi?id=196229
1509
1510         Reviewed by Lucas Forschler.
1511
1512         * BuildSlaveSupport/ews-build/master.cfg:
1513
1514 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1515
1516         [ews-build] Get master_hostname dynamically in master.cfg
1517         https://bugs.webkit.org/show_bug.cgi?id=196255
1518
1519         Reviewed by Lucas Forschler.
1520
1521         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1522         send events data in test mode.
1523
1524 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1525
1526         [ews-app] Set db_constraint to False for Foreign Keys
1527         https://bugs.webkit.org/show_bug.cgi?id=196252
1528
1529         Reviewed by Lucas Forschler.
1530
1531         * BuildSlaveSupport/ews-app/ews/models/build.py:
1532         * BuildSlaveSupport/ews-app/ews/models/step.py:
1533
1534 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1535
1536         [ews-build] is_test_mode_enabled should default to True
1537         https://bugs.webkit.org/show_bug.cgi?id=196248
1538
1539         Reviewed by Lucas Forschler.
1540
1541         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1542
1543 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1544
1545         [ews-app] Add webkitperl to ENABLED_QUEUES
1546         https://bugs.webkit.org/show_bug.cgi?id=196253
1547
1548         Reviewed by Lucas Forschler.
1549
1550         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1551
1552 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1553
1554         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1555         https://bugs.webkit.org/show_bug.cgi?id=196211
1556         rdar://problem/49110552
1557
1558         Reviewed by Tim Horton.
1559
1560         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1561         Make sure that EventSenderProxy always exists when running tests. We used to create
1562         it when resetting before the first test, which is a bit too late.
1563
1564         * WebKitTestRunner/TestController.h:
1565         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1566         (WTR::TestController::platformCreateWebView):
1567         (WTR::TestController::platformCreateOtherPage):
1568         (WTR::TestController::finishCreatingPlatformWebView):
1569         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1570         (WTR::PlatformWebView::PlatformWebView):
1571         Moved some code that made NSWindow use NSEvent during web view creation. We may
1572         need to move more if some other case us found, but this is enough for now.
1573
1574 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1575
1576         Unreviewed. Fix typo in GLib geolocation API after r243285.
1577
1578         gelocation -> geolocation.
1579
1580         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1581         (testGeolocationManagerWatchPosition):
1582
1583 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1584
1585         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1586         https://bugs.webkit.org/show_bug.cgi?id=196213
1587
1588         Reviewed by Geoff Garen.
1589
1590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1591         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1592         (credentialWithIdentityAndKeychainPath):
1593         (-[ChallengeDelegate webView:didFinishNavigation:]):
1594         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1595         (TestWebKitAPI::TEST):
1596
1597 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1598
1599         Expected shouldn't assume its contained types are copyable
1600         https://bugs.webkit.org/show_bug.cgi?id=195986
1601
1602         Reviewed by JF Bastien.
1603
1604         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1605         (TestWebKitAPI::NonCopyable::operator== const):
1606         (TestWebKitAPI::NonCopyable::operator!= const):
1607         (TestWebKitAPI::TEST):
1608
1609 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1610
1611         Remove some now-unnecessary dynamic class lookup
1612         https://bugs.webkit.org/show_bug.cgi?id=196237
1613
1614         Reviewed by Simon Fraser.
1615
1616         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1617         (makeRequest):
1618         (TEST):
1619
1620 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1621
1622         Unreviewed, rolling out r243450.
1623
1624         AppleWin and WinCairo port builds get broken.
1625
1626         Reverted changeset:
1627
1628         "Add test for fix of #196095"
1629         https://bugs.webkit.org/show_bug.cgi?id=196097
1630         https://trac.webkit.org/changeset/243450
1631
1632 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1633
1634         Unreviewed, rolling out r243465.
1635         https://bugs.webkit.org/show_bug.cgi?id=196226
1636
1637         the test doesn't build (Requested by thorton on #webkit).
1638
1639         Reverted changeset:
1640
1641         "Do not terminate the NetworkProcess if a third party
1642         application sends a NSCredential with a SecIdentityRef"
1643         https://bugs.webkit.org/show_bug.cgi?id=196213
1644         https://trac.webkit.org/changeset/243465
1645
1646 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1647
1648         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1649         https://bugs.webkit.org/show_bug.cgi?id=196213
1650
1651         Reviewed by Geoff Garen.
1652
1653         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1654         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1655         (credentialWithIdentityAndKeychainPath):
1656         (-[ChallengeDelegate webView:didFinishNavigation:]):
1657         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1658         (TestWebKitAPI::TEST):
1659
1660 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1661
1662         [ews-build] Gracefully handle missing patch_id in events
1663         https://bugs.webkit.org/show_bug.cgi?id=196216
1664
1665         Reviewed by Lucas Forschler.
1666
1667         * BuildSlaveSupport/ews-build/events.py:
1668
1669 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1670
1671         [ews-build] use lz4 compression for improving buildbot performance
1672         https://bugs.webkit.org/show_bug.cgi?id=196155
1673
1674         Reviewed by Lucas Forschler.
1675
1676         * BuildSlaveSupport/ews-build/master.cfg:
1677
1678 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1679
1680         Pull some API testing helper methods out of TestWKWebView
1681         https://bugs.webkit.org/show_bug.cgi?id=196212
1682
1683         Reviewed by Tim Horton.
1684
1685         Refactor some more API testing utility methods, so that they can be used in
1686         tests that do not use TestWKWebView.
1687
1688         * TestWebKitAPI/cocoa/TestWKWebView.h:
1689         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1690         (-[WKWebView loadTestPageNamed:]):
1691         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1692         (-[WKWebView synchronouslyLoadHTMLString:]):
1693         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1694         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1695         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1696         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1697         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1698
1699 2019-03-25  Jer Noble  <jer.noble@apple.com>
1700
1701         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1702         https://bugs.webkit.org/show_bug.cgi?id=196097
1703
1704         Reviewed by Eric Carlson.
1705
1706         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1707
1708         * DumpRenderTree/mac/DumpRenderTree.mm:
1709         (resetWebPreferencesToConsistentValues):
1710         * WebKitTestRunner/TestController.cpp:
1711         (WTR::TestController::resetPreferencesToConsistentValues):
1712
1713 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1714
1715         Pull IPadUserInterfaceSwizzler out into a separate header file
1716         https://bugs.webkit.org/show_bug.cgi?id=196193
1717
1718         Reviewed by Anders Carlsson.
1719
1720         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1721         be used in other API tests.
1722
1723         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1724         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1725         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1726         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1727         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1728         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1729         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1730
1731 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1732
1733         Remove NavigatorContentUtils in WebCore/Modules
1734         https://bugs.webkit.org/show_bug.cgi?id=196070
1735
1736         Reviewed by Alex Christensen.
1737
1738         NavigatorContentUtils was to support the custom scheme spec [1].
1739         However, in WebKit side, no port has supported the feature in
1740         WebKit layer after EFL port was removed. So there has been the
1741         only IDL implementation of the NavigatorContentUtils in WebCore.
1742         So we don't need to keep the implementation in WebCore anymore.
1743
1744         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1745
1746         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1747
1748 2019-03-24  Andy Estes  <aestes@apple.com>
1749
1750         [watchOS] Remove unused Proximity Networking code
1751         https://bugs.webkit.org/show_bug.cgi?id=196188
1752
1753         Reviewed by Tim Horton.
1754
1755         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1756         (TEST):
1757
1758 2019-03-23  Keith Miller  <keith_miller@apple.com>
1759
1760         Refactor clz/ctz and fix getLSBSet.
1761         https://bugs.webkit.org/show_bug.cgi?id=196162
1762
1763         Reviewed by Saam Barati.
1764
1765         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1766
1767         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1768         (TestWebKitAPI::TEST):
1769
1770 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1771
1772         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1773         https://bugs.webkit.org/show_bug.cgi?id=196143
1774
1775         Reviewed by Michael Catanzaro.
1776
1777         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1778         directories.
1779
1780         * Scripts/webkitpy/style/checkers/cpp.py:
1781         (check_identifier_name_in_declaration):
1782         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1783         (WebKitStyleTest.test_names):
1784
1785 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1786
1787         [Flatpak] Manifest expanding fails for qt WPE extension
1788         https://bugs.webkit.org/show_bug.cgi?id=196148
1789
1790         Reviewed by Alex Christensen.
1791
1792         * flatpak/flatpakutils.py:
1793         (expand_submodules_recurse): The last recurse manifest expand
1794         iteration might lead to a single module so take it into account
1795         and don't try to recurse further.
1796
1797 2019-03-22  Chris Dumez  <cdumez@apple.com>
1798
1799         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1800         https://bugs.webkit.org/show_bug.cgi?id=195348
1801         <rdar://problem/48622090>
1802
1803         Reviewed by Alex Christensen.
1804
1805         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1806         to NO when test.options().shouldIgnoreMetaViewport is false.
1807
1808         * WebKitTestRunner/ios/TestControllerIOS.mm:
1809         (WTR::TestController::platformConfigureViewForTest):
1810
1811 2019-03-22  Chris Dumez  <cdumez@apple.com>
1812
1813         Prewarmed processes should be usable with any website data store
1814         https://bugs.webkit.org/show_bug.cgi?id=196104
1815
1816         Reviewed by Alex Christensen.
1817
1818         Add API test coverage.
1819
1820         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1821         (runInitialWarmedProcessUsedTest):
1822         (TEST):
1823
1824 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1825
1826         Back out local changes to Alex's Subversion working directory
1827
1828         They were accidentally committed.
1829
1830         * Scripts/webkitpy/common/system/abstractexecutive.py:
1831         (AbstractExecutive.wait_newest):
1832         * Scripts/webkitpy/common/system/executive.py:
1833         (Executive.running_pids):
1834         * Scripts/webkitpy/common/system/executive_mock.py:
1835         (MockExecutive.running_pids):
1836         * Scripts/webkitpy/common/system/executive_unittest.py:
1837         (ExecutiveTest.serial_test_running_pids):
1838         * Scripts/webkitpy/port/darwin.py:
1839         (DarwinPort.check_for_leaks):
1840         * Scripts/webkitpy/port/leakdetector.py:
1841         (LeakDetector.check_for_leaks):
1842         - This was the hack attached to Bug 193772.
1843
1844         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1845         (+[WebKitTestRunnerEvent mouseLocation]):
1846         - This works around a crash on an internal build.
1847
1848 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1849
1850         Fix the build after r243354
1851         https://bugs.webkit.org/show_bug.cgi?id=196138
1852         <rdar://problem/49145951>
1853
1854         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1855         (TEST):
1856         * TestWebKitAPI/ios/UIKitSPI.h:
1857
1858 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1859
1860         Adopt UIWKDocumentContext
1861         https://bugs.webkit.org/show_bug.cgi?id=196040
1862         <rdar://problem/48642440>
1863
1864         Reviewed by Ryosuke Niwa.
1865
1866         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1867         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1868         (makeRequest):
1869         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1870         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1871         (applyStyle):
1872         (TEST):
1873         Add tests for UIWKDocumentContext.
1874
1875         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1876         (TEST):
1877         (recursiveFindWKContentView): Deleted.
1878         * TestWebKitAPI/cocoa/TestWKWebView.h:
1879         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1880         (recursiveFindWKContentView):
1881         (-[TestWKWebView wkContentView]):
1882         * TestWebKitAPI/ios/UIKitSPI.h:
1883         Share the WKContentView finding code between tests.
1884
1885 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1886
1887         [iOS WK2] Turn on async overflow scrolling by default
1888         https://bugs.webkit.org/show_bug.cgi?id=196011
1889         rdar://problem/48453859
1890
1891         Reviewed by Antti Koivisto.
1892         
1893         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1894         since so many basic layout tests have different results when compositing is triggered for
1895         overflow.
1896         
1897         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1898
1899         * WebKitTestRunner/TestController.cpp:
1900         (WTR::TestController::resetPreferencesToConsistentValues):
1901
1902 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1903
1904         [ews-build] Retry API test in case of failures
1905         https://bugs.webkit.org/show_bug.cgi?id=196004
1906
1907         Reviewed by Lucas Forschler.
1908
1909         * BuildSlaveSupport/ews-build/steps.py:
1910         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1911         (CompileWebKitToT.doStepIf): Ditto.
1912         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1913         (ReRunAPITests): Re-run API tests.
1914         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1915         (RunAPITestsWithoutPatch): Run API tests without patch.
1916         (RunAPITestsWithoutPatch.doStepIf):
1917         (RunAPITestsWithoutPatch.hideStepIf):
1918         (RunAPITestsWithoutPatch.evaluateCommand):
1919         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1920         (AnalyzeAPITestsResults.start):
1921         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1922         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1923         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1924         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1925
1926 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1927
1928         [ews-build] Update queues configurations
1929         https://bugs.webkit.org/show_bug.cgi?id=196074
1930
1931         Reviewed by Dewei Zhu.
1932
1933         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1934         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1935
1936 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1937
1938         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1939         https://bugs.webkit.org/show_bug.cgi?id=195680
1940         <rdar://problem/48903534>
1941
1942         Unreviewed infrastructure fix.
1943
1944         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1945         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1946
1947 2019-03-21  Andy Estes  <aestes@apple.com>
1948
1949         [iOS] Apple Pay should be available in documents with no user agent scripts
1950         https://bugs.webkit.org/show_bug.cgi?id=196061
1951         <rdar://problem/48649391>
1952
1953         Reviewed by Brady Eidson.
1954
1955         Added API tests and related infrastructure.
1956
1957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1958         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1959         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1960         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1961         (TestWebKitAPI::TEST):
1962         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1963         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1964         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1965         * TestWebKitAPI/cocoa/TestProtocol.mm:
1966         (-[TestProtocol startLoading]):
1967         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1968         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1969         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1970         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1971
1972 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1973
1974         REGRESSSION (r243297): webkitpy tests broken
1975         https://bugs.webkit.org/show_bug.cgi?id=196108
1976
1977         Reviewed by Aakash Jain.
1978
1979         r243297 updated contributors.json, which broke a few unit tests.
1980
1981         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1982         (IRCCommandTest.test_whois):
1983         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1984
1985 2019-03-21  Chris Dumez  <cdumez@apple.com>
1986
1987         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1988         https://bugs.webkit.org/show_bug.cgi?id=196041
1989         <rdar://problem/49083230>
1990
1991         Reviewed by Alex Christensen.
1992
1993         Add API test coverage.
1994
1995         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1996         (TEST):
1997
1998 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1999
2000         Add SPI to inform applications of WKContentRuleList actions
2001         https://bugs.webkit.org/show_bug.cgi?id=195965
2002         <rdar://problem/42664365>
2003
2004         Reviewed by Geoff Garen.
2005
2006         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2007         (TestWebKitAPI::allActionsForResourceLoad):
2008         (TestWebKitAPI::testRequest):
2009         (TestWebKitAPI::TEST_F):
2010         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2011         (Notification::description):
2012         (Notification::operator== const):
2013         (toVector):
2014         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2015         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2016         (makeContentRuleList):
2017         (TEST):
2018         (makeWarnContentRuleList): Deleted.
2019
2020 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2021
2022         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2023         https://bugs.webkit.org/show_bug.cgi?id=196088
2024
2025         Reviewed by Brian Burg.
2026
2027         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2028         Support checks when only one platform is specified. Also deprecate macosx() and
2029         force the use of macos() instead.
2030
2031         * Scripts/webkitpy/style/checkers/cpp.py:
2032         (check_min_versions_of_wk_api_available):
2033         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2034         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2035
2036 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2037
2038         Update status inactive committers' status to 'contributor'.
2039
2040         * Scripts/webkitpy/common/config/contributors.json:
2041
2042 2019-03-21  Xan Lopez  <xan@igalia.com>
2043
2044         [JSC][x86] Drop support for x87 floating point
2045         https://bugs.webkit.org/show_bug.cgi?id=194853
2046
2047         Reviewed by Don Olmstead.
2048
2049         Force SSE2 on x86/32bit builds.
2050
2051         * Scripts/webkitdirs.pm:
2052         (generateBuildSystemFromCMakeProject):
2053
2054 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2055
2056         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2057         https://bugs.webkit.org/show_bug.cgi?id=196073
2058
2059         Reviewed by Michael Catanzaro.
2060
2061         Add test cases to check functions and constructors with no arguments but receiving user data.
2062
2063         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2064         (checkUserData):
2065         (testJSCFunction):
2066         (fooCreateWithUserData):
2067         (testJSCClass):
2068
2069 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2070
2071         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2072
2073         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2074
2075         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2076
2077 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2078
2079         [GTK][WPE] Add API to provide geolocation information
2080         https://bugs.webkit.org/show_bug.cgi?id=195940
2081
2082         Reviewed by Michael Catanzaro.
2083
2084         Add a new test to check the new API.
2085
2086         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2087         (testGeolocationManagerCurrentPosition):
2088         (testGeolocationManagerWatchPosition):
2089         (beforeAll):
2090         (afterAll):
2091         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2092         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2093         (beforeAll): Ditto.
2094         * TestWebKitAPI/glib/CMakeLists.txt:
2095
2096 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2097
2098         [GLib] Returning G_TYPE_OBJECT from a method does not work
2099         https://bugs.webkit.org/show_bug.cgi?id=195574
2100
2101         Reviewed by Michael Catanzaro.
2102
2103         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2104
2105         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2106         (getGFile):
2107         (getParent):
2108         (createGString):
2109         (getGString):
2110         (getGStringCopyWillRaise):
2111         (getGStringCopy):
2112         (getGStringStr):
2113         (getGStringLen):
2114         (freeGString):
2115         (testJSCClass):
2116
2117 2019-03-20  Saam Barati  <sbarati@apple.com>
2118
2119         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2120         https://bugs.webkit.org/show_bug.cgi?id=195721
2121
2122         Reviewed by Filip Pizlo.
2123
2124         * Scripts/run-javascriptcore-tests:
2125
2126 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2127
2128         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2129         https://bugs.webkit.org/show_bug.cgi?id=196049
2130
2131         Reviewed by Tim Horton.
2132
2133         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2134         overflow scrolling in general, so rename it.
2135
2136         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2137
2138 2019-03-20  Daniel Bates  <dabates@apple.com>
2139
2140         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2141         https://bugs.webkit.org/show_bug.cgi?id=196031
2142         <rdar://problem/49078172>
2143
2144         Reviewed by Tim Horton.
2145
2146         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2147         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2148         same code path used when the Done button is pressed to dismiss the <select> picker.
2149
2150         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2151         (TestWebKitAPI::TEST):
2152
2153 2019-03-20  Chris Dumez  <cdumez@apple.com>
2154
2155         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2156         https://bugs.webkit.org/show_bug.cgi?id=196029
2157         <rdar://problem/48954651>
2158
2159         Reviewed by Tim Horton.
2160
2161         Add API test coverage.
2162
2163         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2164
2165 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2166
2167         [ews-build] Improve failure summary string for ApplyPatch step
2168         https://bugs.webkit.org/show_bug.cgi?id=195995
2169
2170         Reviewed by Alexey Proskuryakov.
2171
2172         * BuildSlaveSupport/ews-build/steps.py:
2173         (ApplyPatch.getResultSummary): Override getResultSummary.
2174
2175 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2176
2177         AX: Implement support for new meter ARIA role
2178         https://bugs.webkit.org/show_bug.cgi?id=195966
2179
2180         Reviewed by Chris Fleizach.
2181
2182         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2183         to AXLevelIndicator.
2184
2185         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2186
2187 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2188
2189         [WebAuthN] Implement FIDO AppID extension
2190         https://bugs.webkit.org/show_bug.cgi?id=143491
2191         <rdar://problem/48298273>
2192
2193         Reviewed by Brent Fulgham.
2194
2195         Add a test that covers the new flag of convertToU2fSignCommand.
2196
2197         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2198         (TestWebKitAPI::TEST):
2199         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2200         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2201         (TestWebKitAPI::TEST):
2202
2203 2019-03-19  Keith Rollin  <krollin@apple.com>
2204
2205         Add support for more platforms to generate-xcfilelists
2206         https://bugs.webkit.org/show_bug.cgi?id=195977
2207
2208         Reviewed by Alexey Proskuryakov.
2209
2210         generate-xcfilelists incorrectly complains when involved with building
2211         WebKit for iphonesimulator:
2212
2213             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2214             …
2215             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2216
2217         Address this by teaching generate-xcfilelists about more platforms.
2218
2219         * Scripts/generate-xcfilelists:
2220
2221 2019-03-19  John Wilander  <wilander@apple.com>
2222
2223         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2224         https://bugs.webkit.org/show_bug.cgi?id=195923
2225         <rdar://problem/49001272>
2226
2227         Reviewed by Alex Christensen.
2228
2229         This patch does the following to the TestRunner:
2230         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2231         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2232         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2233
2234         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2235         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2236         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2237         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2238         * WebKitTestRunner/TestController.cpp:
2239         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2240         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2241         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2242         * WebKitTestRunner/TestController.h:
2243         * WebKitTestRunner/TestInvocation.cpp:
2244         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2245
2246 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2247
2248         [CMake] Support more clang and gcc sanitizers
2249         https://bugs.webkit.org/show_bug.cgi?id=195956
2250
2251         Reviewed by Michael Catanzaro.
2252
2253         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2254
2255 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2256
2257         [ews-build] Improve summary for PrintConfiguration step
2258         https://bugs.webkit.org/show_bug.cgi?id=195945
2259
2260         Reviewed by Lucas Forschler.
2261
2262         * BuildSlaveSupport/ews-build/steps.py:
2263         (PrintConfiguration.getResultSummary): Override getResultSummary.
2264
2265 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2266
2267         [ews-build] Improve summary for CheckOutSource step
2268         https://bugs.webkit.org/show_bug.cgi?id=195963
2269
2270         Reviewed by Lucas Forschler.
2271
2272         * BuildSlaveSupport/ews-build/steps.py:
2273         (CheckOutSource.getResultSummary):
2274
2275 2019-03-19  Daniel Bates  <dabates@apple.com>
2276
2277         [iOS] Focus not preserved when switching between tabs
2278         https://bugs.webkit.org/show_bug.cgi?id=195820
2279         <rdar://problem/43614450>
2280
2281         Reviewed by Brent Fulgham.
2282
2283         Add tests to ensure that we restore focus when resigning and becoming first responder.
2284
2285         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2286         (TestWebKitAPI::TEST):
2287
2288 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2289
2290         Make WTFLogChannelState and WTFLogLevel enum classes
2291         https://bugs.webkit.org/show_bug.cgi?id=195904
2292
2293         Reviewed by Eric Carlson.
2294
2295         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2296         (TestWebKitAPI::TEST_F):
2297
2298 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2299
2300         [GStreamer][EME] Backported mssdemux protection data crash fix
2301         https://bugs.webkit.org/show_bug.cgi?id=195918
2302
2303         Reviewed by Philippe Normand.
2304
2305         * gstreamer/jhbuild.modules:
2306         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2307
2308 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2309
2310         Unreviewed, rolling out r243132.
2311
2312         Broke GTK build
2313
2314         Reverted changeset:
2315
2316         "Make WTFLogChannelState and WTFLogLevel enum classes"
2317         https://bugs.webkit.org/show_bug.cgi?id=195904
2318         https://trac.webkit.org/changeset/243132
2319
2320 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2321
2322         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2323
2324         * Scripts/webkitdirs.pm:
2325         (builtDylibPathForName): Adjust the shared library name that's changed
2326         with the API version bump in r243073.
2327
2328 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2329
2330         Make WTFLogChannelState and WTFLogLevel enum classes
2331         https://bugs.webkit.org/show_bug.cgi?id=195904
2332
2333         Reviewed by Eric Carlson.
2334
2335         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2336         (TestWebKitAPI::TEST_F):
2337
2338 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2339
2340         Disable flaky test added in r2431100
2341         https://webkit.org/b/195785
2342
2343         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2344         (TestWebKitAPI::TEST):
2345         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2346
2347 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2348
2349         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2350         https://bugs.webkit.org/show_bug.cgi?id=195916
2351
2352         Reviewed by Tim Horton.
2353
2354         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2355         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2356
2357 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2358
2359         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2360
2361         * Scripts/webkitpy/common/config/contributors.json:
2362
2363 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2364
2365         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2366         https://bugs.webkit.org/show_bug.cgi?id=195785
2367
2368         Reviewed by Geoffrey Garen.
2369
2370         * TestWebKitAPI/TCPServer.cpp: Added.
2371         (TestWebKitAPI::TCPServer::TCPServer):
2372         (TestWebKitAPI::TCPServer::~TCPServer):
2373         (TestWebKitAPI::TCPServer::socketBindListen):
2374         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2375         * TestWebKitAPI/TCPServer.h: Added.
2376         (TestWebKitAPI::TCPServer::port const):
2377         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2378         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2379         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2380         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2381         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2382         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2383         (TestWebKitAPI::respondSlowly):
2384         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2385         (TestWebKitAPI::downloadAtRate):
2386         (TestWebKitAPI::TEST):
2387
2388 2019-03-18  Saam Barati  <sbarati@apple.com>
2389
2390         Add a plan file for JetStream 2
2391         https://bugs.webkit.org/show_bug.cgi?id=190734
2392
2393         Reviewed by Mark Lam.
2394
2395         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2396
2397 2019-03-18  Chris Dumez  <cdumez@apple.com>
2398
2399         Delay WebProcess launch until a load is triggered in a Web view
2400         https://bugs.webkit.org/show_bug.cgi?id=195758
2401         <rdar://problem/48126013>
2402
2403         Reviewed by Geoff Garen.
2404
2405         Add API test coverage. Also update some existing API tests to not expect
2406         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2407
2408         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2409         (TestWebKitAPI::TEST):
2410         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2411         (TestWebKitAPI::TEST):
2412         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2413         (TEST):
2414         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2415         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2416         (TEST):
2417         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2418         (TEST):
2419         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2420
2421 2019-03-18  Xan Lopez  <xan@igalia.com>
2422
2423         [CMake] Prevent potential warning when determining $architecture
2424         https://bugs.webkit.org/show_bug.cgi?id=195891
2425
2426         Reviewed by Michael Catanzaro.
2427
2428         It's possible for generateBuildSystemForCMakeProject to be called
2429         before determineArchitecture() is ever called. This will make the
2430         first eq check with $architecture to be bogus (and print a
2431         warning). Change that to an eq check with architecture(), which
2432         implicitly calls determineArchitecture() if needed, and change all
2433         the other similar cases in the method in the same way to prevent
2434         future bugs like this one.
2435
2436         * Scripts/webkitdirs.pm:
2437         (generateBuildSystemFromCMakeProject):
2438
2439 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2440
2441         [WPE] Tarballs generated with “make dist” cannot build documentation
2442         https://bugs.webkit.org/show_bug.cgi?id=195885
2443
2444         Reviewed by Carlos Garcia Campos.
2445
2446         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2447
2448 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2449
2450         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2451         https://bugs.webkit.org/show_bug.cgi?id=195883
2452
2453         Reviewed by Carlos Garcia Campos.
2454
2455         * gtkdoc/gtkdoc.py:
2456         (GTKDoc._run_command): When commands fail to run, include the full command line for
2457         the program invocation and the output it has generated on the standard error stream.
2458
2459 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2460
2461         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2462         https://bugs.webkit.org/show_bug.cgi?id=195786
2463
2464         Reviewed by Philippe Normand.
2465
2466         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2467         * wpe/jhbuild.modules: Ditto.
2468
2469 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2470
2471         [ews-build] Don't run clean builds on EWS builders
2472         https://bugs.webkit.org/show_bug.cgi?id=195851
2473
2474         Reviewed by Geoffrey Garen.
2475
2476         * BuildSlaveSupport/ews-build/factories.py:
2477
2478 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2479
2480         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2481         https://bugs.webkit.org/show_bug.cgi?id=195849
2482
2483         Reviewed by Chris Dumez.
2484
2485         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2486
2487         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2488         (runWebsiteDataStoreCustomPaths):
2489
2490 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2491
2492         webkitpy: Upload test results
2493         https://bugs.webkit.org/show_bug.cgi?id=195755
2494         <rdar://problem/48896182>
2495
2496         Reviewed by Aakash Jain.
2497
2498         Establish a new format for uploading results that is not tied to layout tests, apply
2499         that format to webkitpy tests.
2500
2501         * Scripts/webkitpy/common/checkout/scm/git.py:
2502         (Git.native_branch): Return what branch the current checkout is on.
2503         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2504         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2505         * Scripts/webkitpy/common/checkout/scm/svn.py:
2506         (SVN.native_branch): Ditto.
2507         * Scripts/webkitpy/common/system/platforminfo.py:
2508         (PlatformInfo.build_version): Return a build version for Mac.
2509         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2510         (MockPlatformInfo.__init__):
2511         (MockPlatformInfo.build_version):
2512         * Scripts/webkitpy/results: Added.
2513         * Scripts/webkitpy/results/__init__.py: Added.
2514         * Scripts/webkitpy/results/options.py: Added.
2515         (upload_options): OptParse list for upload options.
2516         * Scripts/webkitpy/results/upload.py: Added.
2517         (Upload): Class which enforces the upload format expected by the results server.
2518         (Upload.Expectations):
2519         (Upload.create_configuration):
2520         (Upload.create_commit):
2521         (Upload.create_details):
2522         (Upload.create_run_stats):
2523         (Upload.create_test_result):
2524         (Upload.__init__):
2525         (Upload.Encoder): Encode Upload object as json.
2526         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2527         * Scripts/webkitpy/results/upload_unittest.py: Added.
2528         * Scripts/webkitpy/test/main.py:
2529         (Tester._parse_args): Add upload arguments.
2530         (Tester._run_tests): Allow results to be uploaded.
2531         * Scripts/webkitpy/test/runner.py:
2532         (Runner.__init__): Record which tests were run, rather than just counting them.
2533         (Runner.handle):
2534         * Scripts/webkitpy/test/runner_unittest.py:
2535         (RunnerTest.test_run):
2536         * Scripts/webkitpy/thirdparty/__init__.py:
2537         (AutoinstallImportHook.find_module): Add requests auto-install.
2538         (AutoinstallImportHook._install_requests):
2539         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2540         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2541
2542 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2543
2544         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2545         https://bugs.webkit.org/show_bug.cgi?id=195810
2546
2547         Reviewed by Tim Horton.
2548
2549         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2550         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2551         ending certain layout tests.
2552
2553         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2554         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2555         (-[TestRunnerWKWebView dealloc]):
2556         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2557
2558         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2559         helper method when destroying the web view, and when resetting state between tests.
2560
2561         * WebKitTestRunner/ios/TestControllerIOS.mm:
2562         (WTR::TestController::platformResetStateToConsistentValues):
2563
2564         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2565
2566 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2567
2568         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2569         https://bugs.webkit.org/show_bug.cgi?id=190350
2570         <rdar://problem/45089503>
2571
2572         Reviewed by Geoffrey Garen.
2573
2574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2575         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2576         (TEST):
2577         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2578         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2579         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2580         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2581         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2582         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2583         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2584         (runTest):
2585         (createDirectories):
2586         (TEST):
2587         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2588         (TEST):
2589         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2590         (TEST):
2591
2592 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2593
2594         Add support to WebPage for getting the contents as an attributed string.
2595         https://bugs.webkit.org/show_bug.cgi?id=195636
2596         rdar://problem/45055697
2597
2598         Reviewed by Tim Horton.
2599
2600         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2601         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2602
2603 2019-03-15  Chris Dumez  <cdumez@apple.com>
2604
2605         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2606         https://bugs.webkit.org/show_bug.cgi?id=195747
2607
2608         Reviewed by Geoff Garen.
2609
2610         Add API test coverage.
2611
2612         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2613
2614 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2615
2616         Unreviewed, rolling out r242952.
2617
2618         Causing API failures on iOS Simulator
2619
2620         Reverted changeset:
2621
2622         "[PSON] Make sure the WebProcessCache is leverage when
2623         relaunching a process after termination"
2624         https://bugs.webkit.org/show_bug.cgi?id=195747
2625         https://trac.webkit.org/changeset/242952
2626
2627 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2628
2629         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2630         https://bugs.webkit.org/show_bug.cgi?id=195740
2631
2632         Reviewed by Ross Kirsling.
2633
2634         window.open doesn't work for WebKitBrowserWindow because it is not
2635         implemented yet.
2636
2637         1. Implemented createNewPage callback of WKPageUIClient.
2638         2. Changed MainWindow to take a BrowserWindow factory function
2639           instead of BrowserWindowType to be flexible to create
2640           BrowserWindow with extra settings.
2641         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2642           because it is not relevant with MainWindow anymore.
2643
2644         * MiniBrowser/win/Common.cpp:
2645         (parseCommandLine):
2646         * MiniBrowser/win/Common.h:
2647         (CommandLineOptions::CommandLineOptions):
2648         * MiniBrowser/win/MainWindow.cpp:
2649         (MainWindow::MainWindow):
2650         (MainWindow::create):
2651         (MainWindow::init):
2652         (MainWindow::WndProc):
2653         * MiniBrowser/win/MainWindow.h:
2654         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2655         (PrintWebUIDelegate::createWebViewWithRequest):
2656         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2657         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2658         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2659         (WebKitBrowserWindow::updateProxySettings):
2660         (WebKitBrowserWindow::createNewPage):
2661         * MiniBrowser/win/WebKitBrowserWindow.h:
2662         * MiniBrowser/win/WinMain.cpp:
2663         (wWinMain):
2664
2665 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2666
2667         Make it possible to test scrolling tree layer manipulation more easily
2668         https://bugs.webkit.org/show_bug.cgi?id=195780
2669
2670         Reviewed by Tim Horton.
2671         
2672         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2673         cuts off communication of scrolling tree scrolls back to the web process
2674         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2675         allows tests to trigger scrolls which run the scrolling tree layer positioning
2676         logic, but never get another commit from the web process that might mask
2677         scrolling tree bugs.
2678         
2679         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2680         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2681         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2682
2683         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2684         (WTR::UIScriptController::scrollUpdatesDisabled const):
2685         (WTR::UIScriptController::setScrollUpdatesDisabled):
2686         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2687         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2688         (WTR::UIScriptController::scrollUpdatesDisabled const):
2689         (WTR::UIScriptController::setScrollUpdatesDisabled):
2690         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2691         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2692         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2693         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2694         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2695         * WebKitTestRunner/ios/TestControllerIOS.mm:
2696         (WTR::TestController::platformResetStateToConsistentValues):
2697         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2698         (WTR::UIScriptController::scrollUpdatesDisabled const):
2699         (WTR::UIScriptController::setScrollUpdatesDisabled):
2700
2701 2019-03-14  Youenn Fablet  <youenn@apple.com>
2702
2703         Move IDB storage in private browsing mode to NetworkProcess
2704         https://bugs.webkit.org/show_bug.cgi?id=195602
2705
2706         Reviewed by Brady Eidson.
2707
2708         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2709         (TEST):
2710
2711 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2712
2713         [ews-build] Make descriptionDone messages more readable
2714         https://bugs.webkit.org/show_bug.cgi?id=195760
2715
2716         Reviewed by Lucas Forschler.
2717
2718         * BuildSlaveSupport/ews-build/steps.py:
2719         * BuildSlaveSupport/ews-build/steps_unittest.py:
2720
2721 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2722
2723         [ews-build] Generate status-bubble hover-over messages
2724         https://bugs.webkit.org/show_bug.cgi?id=195680
2725
2726         Reviewed by Lucas Forschler.
2727
2728         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2729         (StatusBubble):
2730         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2731         on hover-over.
2732         (StatusBubble._iso_time):
2733         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2734         hover-over message.
2735         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2736
2737 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2738
2739         [ews-app] Gracefully handle the case when state_string is None
2740         https://bugs.webkit.org/show_bug.cgi?id=195753
2741
2742         Reviewed by Lucas Forschler.
2743
2744         * BuildSlaveSupport/ews-app/ews/models/build.py:
2745         * BuildSlaveSupport/ews-app/ews/models/step.py:
2746
2747 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2748
2749         [ews-app] Status bubble display pending for currently running build step
2750         https://bugs.webkit.org/show_bug.cgi?id=195744
2751
2752         Reviewed by Lucas Forschler.
2753
2754         * BuildSlaveSupport/ews-build/events.py:
2755         (Events.stepStarted): If state_string is pending, replace it with step name.
2756
2757 2019-03-14  Chris Dumez  <cdumez@apple.com>
2758
2759         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2760         https://bugs.webkit.org/show_bug.cgi?id=195750
2761
2762         Reviewed by Geoffrey Garen.
2763
2764         Add API test coverage.
2765
2766         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2767         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2768         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2769         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2770
2771 2019-03-14  Chris Dumez  <cdumez@apple.com>
2772
2773         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2774         https://bugs.webkit.org/show_bug.cgi?id=195747
2775
2776         Reviewed by Geoff Garen.
2777
2778         Add API test coverage.
2779
2780         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2781
2782 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2783
2784         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2785         https://bugs.webkit.org/show_bug.cgi?id=195725
2786         <rdar://problem/48545062>
2787
2788         Reviewed by Tim Horton.
2789
2790         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2791         handler is nil.
2792
2793         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2794         (TestWebKitAPI::TEST):
2795
2796 2019-03-13  Sam Weinig  <sam@webkit.org>
2797
2798         Add utility function to allow easy reverse range-based iteration of a container
2799         https://bugs.webkit.org/show_bug.cgi?id=195542
2800
2801         Reviewed by Antti Koivisto.
2802
2803         * TestWebKitAPI/CMakeLists.txt:
2804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2805         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2806         (TestWebKitAPI::TEST):
2807         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2808
2809 2019-03-13  Chris Dumez  <cdumez@apple.com>
2810
2811         Use a ServiceWorker process per registrable domain
2812         https://bugs.webkit.org/show_bug.cgi?id=195649
2813
2814         Reviewed by Youenn Fablet.
2815
2816         Update API test coverage.
2817
2818         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2819
2820 2019-03-13  Chris Dumez  <cdumez@apple.com>
2821
2822         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2823         https://bugs.webkit.org/show_bug.cgi?id=195684
2824         <rdar://problem/48294714>
2825
2826         Reviewed by Antti Koivisto.
2827
2828         Add API test coverage.
2829
2830         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2831
2832 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2833
2834         [ews-app] Remove unused patch view
2835         https://bugs.webkit.org/show_bug.cgi?id=195669
2836
2837         Reviewed by Lucas Forschler.
2838
2839         * BuildSlaveSupport/ews-app/ews/urls.py:
2840         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2841
2842 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2843
2844         [ews-app] Use Buildbot result code variables
2845         https://bugs.webkit.org/show_bug.cgi?id=195668
2846
2847         Reviewed by Alexey Proskuryakov.
2848
2849         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2850         (Buildbot): Added Buildbot result code variables.
2851         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2852         (StatusBubble._build_bubble): Used Buildbot result code variables.
2853
2854 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2855
2856         [Flatpak] Expand submodule recursively
2857         https://bugs.webkit.org/show_bug.cgi?id=195672
2858
2859         Building WPE with flatpak was impossible without that as it was raising an exception.
2860         Also update wpebackend-fdo to match what is built in jhbuild
2861
2862         Reviewed by Philippe Normand.
2863
2864         * flatpak/flatpakutils.py:
2865         (expand_submodules_recurse):
2866         (expand_manifest):
2867         * flatpak/org.webkit.WPEModules.yaml:
2868
2869 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2870
2871         [ews-app] status bubble should be hidden for certain builds
2872         https://bugs.webkit.org/show_bug.cgi?id=194597
2873
2874         Reviewed by Dewei Zhu.
2875
2876         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2877         (StatusBubble._build_bubble):
2878         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2879         because the patch didn't have relevant changes.
2880         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2881         in production yet.
2882
2883 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2884
2885         [Win] Fix a slew of simple clang-cl warnings.
2886         https://bugs.webkit.org/show_bug.cgi?id=195652
2887
2888         Reviewed by Don Olmstead.
2889
2890         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2891         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2892
2893 2019-03-12  Justin Fan  <justin_fan@apple.com>
2894
2895         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2896         https://bugs.webkit.org/show_bug.cgi?id=195518
2897         <rdar://problem/46322356>
2898
2899         Reviewed by Myles C. Maxfield.
2900
2901         * DumpRenderTree/DerivedSources-input.xcfilelist:
2902         * DumpRenderTree/DerivedSources-output.xcfilelist:
2903
2904 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2905
2906         Unreviewed, rolling out r242825.
2907         https://bugs.webkit.org/show_bug.cgi?id=195648
2908
2909         "Broke webkitpy tests with my change to
2910         lldb_dump_class_layout.py" (Requested by rmorisset on
2911         #webkit).
2912
2913         Reverted changeset:
2914
2915         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2916         classes with suspicious padding"
2917         https://bugs.webkit.org/show_bug.cgi?id=195573
2918         https://trac.webkit.org/changeset/242825
2919
2920 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2921
2922         [ews-build] Show status bubbles while the patch is waiting in queue
2923         https://bugs.webkit.org/show_bug.cgi?id=195618
2924
2925         Reviewed by Lucas Forschler.
2926
2927         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2928         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2929         enabled in initial deployment.
2930         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2931         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2932         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2933         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2934         (StatusBubble._build_bubbles_for_patch):
2935
2936 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2937
2938         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2939         https://bugs.webkit.org/show_bug.cgi?id=195573
2940
2941         Reviewed by Simon Fraser.
2942
2943         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2944
2945         * Scripts/dump-class-layout:
2946         (main):
2947         * lldb/lldb_dump_class_layout.py:
2948         (ClassLayout.__init__):
2949         (ClassLayout._compute_padding_recursive):
2950         (LLDBDebuggerInstance.dump_layout_for_classname):
2951         (LLDBDebuggerInstance):
2952         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2953         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2954
2955 2019-03-12  Chris Dumez  <cdumez@apple.com>
2956
2957         Device Orientation access permission should be denied unless explicitly granted by the client
2958         https://bugs.webkit.org/show_bug.cgi?id=195625
2959
2960         Reviewed by Youenn Fablet.
2961
2962         add API test coverage.
2963
2964         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2965         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2966         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2967         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2968         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2969         (runDeviceOrientationTest):
2970         (TEST):
2971         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2972         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2973
2974 2019-03-12  Jer Noble  <jer.noble@apple.com>
2975
2976         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2977         https://bugs.webkit.org/show_bug.cgi?id=195137
2978         <rdar://problem/48810307>
2979
2980         Reviewed by Eric Carlson.
2981
2982         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2983         (TestWebKitAPI::TEST):
2984
2985 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2986
2987         [ews-build] Change urls from uat to production
2988         https://bugs.webkit.org/show_bug.cgi?id=195566
2989
2990         Reviewed by Lucas Forschler.
2991
2992         * BuildSlaveSupport/ews-app/ews/config.py:
2993         * BuildSlaveSupport/ews-build/events.py:
2994         * BuildSlaveSupport/ews-build/steps.py:
2995
2996 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2997
2998         [ews-build] change max_builds for local-worker to 1
2999         https://bugs.webkit.org/show_bug.cgi?id=195568
3000
3001         Reviewed by Lucas Forschler.
3002
3003         * BuildSlaveSupport/ews-build/loadConfig.py:
3004
3005 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3006
3007         Fix the build
3008
3009         * TestRunnerShared/spi/PencilKitTestSPI.h:
3010         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3011
3012 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3013
3014         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3015         https://bugs.webkit.org/show_bug.cgi?id=194131
3016
3017         Reviewed by Michael Catanzaro.
3018
3019         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3020         (uriChanged):
3021         (testUnfinishedSubresourceLoad):
3022         (serverCallback):
3023         (beforeAll):
3024
3025 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3026
3027         WTF::Expected should use std::addressof instead of operator&
3028         https://bugs.webkit.org/show_bug.cgi?id=195604
3029
3030         Reviewed by Myles Maxfield.
3031
3032         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3033         (TestWebKitAPI::Unique::Unique):
3034         (TestWebKitAPI::Unique::operator&):
3035         (TestWebKitAPI::TEST):
3036
3037 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3038
3039         Add Optional to Forward.h.
3040         https://bugs.webkit.org/show_bug.cgi?id=195586
3041
3042         Reviewed by Darin Adler.
3043
3044         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3045         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3046         Remove unnecessary includes from headers.
3047
3048 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3049
3050         Add testing API to hit-test and scroll overflow scrollers
3051         https://bugs.webkit.org/show_bug.cgi?id=195278
3052
3053         Reviewed by Antti Koivisto.
3054         
3055         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3056         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3057         
3058         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3059
3060         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3061         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3062         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3063         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3064         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3065         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3066         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3067         (WTR::enclosingScrollViewIncludingSelf):
3068         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3069
3070 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3071
3072         API test WebKit.RequestTextInputContext fails on iOS
3073         https://bugs.webkit.org/show_bug.cgi?id=195585
3074
3075         Reviewed by Wenson Hsieh and Simon Fraser.
3076
3077         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3078         (applyStyle):
3079         (TEST):
3080         Add a viewport, so that the coordinates match up on iOS.
3081         Scroll by moving the UIScrollView's contentOffset.
3082
3083 2019-03-11  Chris Dumez  <cdumez@apple.com>
3084
3085         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3086         https://bugs.webkit.org/show_bug.cgi?id=195506
3087         <rdar://problem/48733477>
3088
3089         Reviewed by Alex Christensen.
3090
3091         Add API test coverage.
3092
3093         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3094
3095 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3096
3097         Adding myself to contributors.json
3098
3099         Unreviewed, addming myself to contributors.json .
3100
3101         * Scripts/webkitpy/common/config/contributors.json:
3102
3103 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3104
3105         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3106         https://bugs.webkit.org/show_bug.cgi?id=195511
3107         <rdar://problem/44873269>
3108
3109         Reviewed by Darin Adler.
3110
3111         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3112         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3113         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3114         (TEST_F):
3115
3116 2019-03-11  Chris Dumez  <cdumez@apple.com>
3117
3118         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3119         https://bugs.webkit.org/show_bug.cgi?id=195561
3120
3121         Reviewed by Youenn Fablet.
3122
3123         Make sure the JS in the test requests for permission to receive device orientation events.
3124
3125         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3126
3127 2019-03-11  Youenn Fablet  <youenn@apple.com>
3128
3129         Allow storage quota increase by default in WTR
3130         https://bugs.webkit.org/show_bug.cgi?id=195541
3131
3132         Reviewed by Geoffrey Garen.
3133
3134         Allow storage quota increase by default in WTR.
3135         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3136         Use this for tests that explicitly need cache increase.
3137
3138         Instead of increasing quota by 2, make sure the next request is
3139         granted by adding all given parameters.
3140
3141         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3142         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3143         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3144         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3145         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3146         * WebKitTestRunner/TestController.cpp:
3147         (WTR::TestController::setAllowStorageQuotaIncrease):
3148         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3149         * WebKitTestRunner/TestController.h:
3150         * WebKitTestRunner/TestInvocation.cpp:
3151         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3152         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3153         (WTR::TestController::cocoaResetStateToConsistentValues):
3154         (WTR::TestController::setAllowStorageQuotaIncrease):
3155         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3156         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3157         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3158
3159 2019-03-11  Xan Lopez  <xan@igalia.com>
3160
3161         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3162         https://bugs.webkit.org/show_bug.cgi?id=194147
3163
3164         Reviewed by Michael Saboff.
3165
3166         To make --32-bit work correctly on Linux/64bit we need to:
3167
3168         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3169         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3170         unfortunately CMake only allows us to do this during
3171         crosscompilation, which is overkill here.
3172         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3173         pkg-config detection module uses the x86 .pc files instead of the
3174         x86_64 ones.
3175         - Set the -m32 flags for the compiler.
3176
3177         * Scripts/webkitdirs.pm:
3178         (generateBuildSystemFromCMakeProject):
3179
3180 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3181
3182         Add MotionMark-1.1 plan file for run-benchmark script.
3183         https://bugs.webkit.org/show_bug.cgi?id=195481
3184
3185         Rubber-stamped by Darin Adler.
3186
3187         Run-benchmark script should support MontionMark-1.1.
3188
3189         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3190
3191 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3192
3193         [ews-app] Add support for submit-to-ews url
3194         https://bugs.webkit.org/show_bug.cgi?id=195477
3195
3196         Reviewed by Lucas Forschler.
3197
3198         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3199         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3200         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3201         * BuildSlaveSupport/ews-app/ews/urls.py:
3202         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3203
3204 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3205
3206         Unreviewed, rolling out r242688, r242643, r242624.
3207
3208         Caused multiple layout test failures and crashes on iOS and macOS.
3209
3210         Reverted changeset:
3211
3212         "requestAnimationFrame should execute before the next frame"
3213         https://bugs.webkit.org/show_bug.cgi?id=177484
3214         https://trac.webkit.org/changeset/242624/webkit
3215
3216         * Tracing/SystemTracePoints.plist:
3217
3218 2019-03-11  John Wilander  <wilander@apple.com>
3219
3220         Resource Load Statistics: Make it possible exclude localhost from classification
3221         https://bugs.webkit.org/show_bug.cgi?id=195474
3222         <rdar://problem/47520577>
3223
3224         Reviewed by Brent Fulgham.
3225
3226         This patch allows for localhost to be excluded from classification and
3227         treatment as a prevalent resource.
3228
3229         The WebKit Tools change adds a new function called
3230         testRunner.setStatisticsIsRunningTest() which can be used to control this
3231         behavior.
3232
3233         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3234         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3235         (WTR::TestRunner::setStatisticsIsRunningTest):
3236         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3237         * WebKitTestRunner/TestController.cpp:
3238         (WTR::TestController::setStatisticsIsRunningTest):
3239         * WebKitTestRunner/TestController.h:
3240         * WebKitTestRunner/TestInvocation.cpp:
3241         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3242
3243 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3244
3245         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3246         https://bugs.webkit.org/show_bug.cgi?id=195560
3247
3248         Reviewed by Lucas Forschler.
3249
3250         * BuildSlaveSupport/ews-build/master.cfg:
3251
3252 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3253
3254         Unreviewed, rolling out r242698.
3255
3256         API test crashes on bots.
3257
3258         Reverted changeset:
3259
3260         "Add a WKContentRuleList variant that uses copied memory
3261         instead of mmap'd shared memory for class A containerized
3262         apps"
3263         https://bugs.webkit.org/show_bug.cgi?id=195511
3264         https://trac.webkit.org/changeset/242698
3265
3266 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3267
3268         [WPE] Enable web process sandbox
3269         https://bugs.webkit.org/show_bug.cgi?id=195169
3270
3271         Reviewed by Daniel Bates.
3272
3273         * wpe/install-dependencies:
3274         * wpe/jhbuild.modules:
3275
3276 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3277
3278         [ews-app] Use port 17000 for worker communication
3279         https://bugs.webkit.org/show_bug.cgi?id=195558
3280
3281         Reviewed by Lucas Forschler.
3282
3283         * BuildSlaveSupport/ews-build/master.cfg:
3284
3285 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3286
3287         [ews-build] unit-tests fail when passwords.json is missing
3288         https://bugs.webkit.org/show_bug.cgi?id=195557
3289
3290         Reviewed by Lucas Forschler.
3291
3292         * BuildSlaveSupport/ews-build/loadConfig.py:
3293         (loadBuilderConfig):
3294         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3295         (ConfigDotJSONTest.test_configuration):
3296         * BuildSlaveSupport/ews-build/master.cfg:
3297
3298 2019-03-11  Truitt Savell  <tsavell@apple.com>
3299
3300         Unreviewed, rolling out r242702.
3301
3302         Broke High Sierra builders.
3303
3304         Reverted changeset:
3305
3306         "Add utility function to allow easy reverse range-based
3307         iteration of a container"
3308         https://bugs.webkit.org/show_bug.cgi?id=195542
3309         https://trac.webkit.org/changeset/242702
3310
3311 2019-03-11  Sam Weinig  <sam@webkit.org>
3312
3313         Add utility function to allow easy reverse range-based iteration of a container
3314         https://bugs.webkit.org/show_bug.cgi?id=195542
3315
3316         Reviewed by Antti Koivisto.
3317
3318         * TestWebKitAPI/CMakeLists.txt:
3319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3320         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3321         (TestWebKitAPI::TEST):
3322         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3323
3324 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3325
3326         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3327         https://bugs.webkit.org/show_bug.cgi?id=195511
3328         <rdar://problem/44873269>
3329
3330         Reviewed by Darin Adler.
3331
3332         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3333         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3334         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3335         (TEST_F):
3336
3337 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3338
3339         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3340         https://bugs.webkit.org/show_bug.cgi?id=195499
3341
3342         Reviewed by Darin Adler.
3343
3344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3345         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3346         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3347         (-[WKWebView synchronouslyFocusTextInputContext:]):
3348         (applyStyle):
3349         (applyIframe):
3350         (TEST):
3351         Add some tests for this SPI.
3352
3353 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3354
3355         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3356         https://bugs.webkit.org/show_bug.cgi?id=181151
3357
3358         Reviewed by Don Olmstead.
3359
3360         * TestWebKitAPI/CMakeLists.txt:
3361         * TestWebKitAPI/PlatformWin.cmake:
3362         Enable TestWTF RunLoop tests in all platforms.
3363
3364         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3365         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3366         (TestWebKitAPI::DerivedOneShotTimer::fired):
3367         (TestWebKitAPI::TEST):
3368         Only a few platforms support nested RunLoop.
3369
3370         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3371         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3372
3373 2019-03-10  David Quesada  <david_quesada@apple.com>
3374
3375         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3376         https://bugs.webkit.org/show_bug.cgi?id=152480
3377
3378         Reviewed by Chris Dumez.
3379
3380         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3381         there are no additional references to the process pool besides the one held by
3382         the download, waits for the download to finish (in the sense that the
3383         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3384         measure, also check that the process pool has been deallocated at the end of the
3385         test. The test wouldn't be meaningful if the process pool were still alive.
3386
3387         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3388         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3389         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3390             The download will be canceled because the delegate does not implement the
3391             method to decide the download's destination, so this is where we know the
3392             DownloadProxyMap is done with the DownloadProxy.
3393         (TEST):
3394
3395 2019-03-08  Chris Dumez  <cdumez@apple.com>
3396
3397         Add support for Device Orientation / Motion permission API
3398         https://bugs.webkit.org/show_bug.cgi?id=195329
3399         <rdar://problem/47645367>
3400
3401         Reviewed by Geoffrey Garen.
3402
3403         Add test infrastructure to help test the Device Orientation / Motion permission API.
3404
3405         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3406         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3407         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3408         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3409         * WebKitTestRunner/TestController.cpp:
3410         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3411         (WTR::TestController::createWebViewWithOptions):
3412         (WTR::TestController::resetStateToConsistentValues):
3413         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3414         * WebKitTestRunner/TestController.h:
3415         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3416         * WebKitTestRunner/TestInvocation.cpp:
3417         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3418
3419 2019-03-08  Saam barati  <sbarati@apple.com>
3420
3421         Add a compare-results script to compare benchmark results
3422         https://bugs.webkit.org/show_bug.cgi?id=195486
3423         <rdar://problem/48723397>
3424
3425         Reviewed by Geoffrey Garen.
3426
3427         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3428         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3429         to extend it to learn about our other benchmarks.
3430
3431         * Scripts/compare-results: Added.
3432         (readJSONFile):
3433         (detectJetStream2):
3434         (JetStream2Results):
3435         (detectSpeedometer2):
3436         (Speedometer2Results):
3437         (detectPLT5):
3438         (PLT5Results):
3439         (detectBenchmark):
3440         (biggerIsBetter):
3441         (ttest):
3442         (getOptions):
3443         (main):
3444
3445 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3446
3447         Ensure old tab state is cleared between iterations of run-benchmark
3448         https://bugs.webkit.org/show_bug.cgi?id=195393
3449         <rdar://problem/46885583>
3450
3451         Reviewed by Dewei Zhu.
3452
3453         a) ensure the default to restore state is not set
3454         b) terminate Safari correctly
3455         c) Set the system default to ignore Persistent State in Safari
3456
3457         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3458         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3459         (OSXBrowserDriver.prepare_env): 
3460         (OSXBrowserDriver.restore_env):
3461         (OSXBrowserDriver.close_browsers):
3462         (OSXBrowserDriver._terminate_processes):
3463         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3464         (OSXChromeDriver):
3465         (OSXChromeCanaryDriver):
3466         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3467         (OSXFirefoxDriver):
3468         (OSXFirefoxNightlyDriver):
3469         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3470         (OSXSafariDriver):
3471         (OSXSafariDriver.prepare_env):
3472
3473 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3474
3475         [GTK] Several InputMethodFilter tests are failing
3476         https://bugs.webkit.org/show_bug.cgi?id=195408
3477
3478         Reviewed by Carlos Garcia Campos.
3479
3480         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3481         Regressed in r241751.
3482         Hexadecimal values of keycodes are expressed now in upper letters.
3483         Composited characters should be cast to UTF8 strings.
3484
3485         (TestWebKitAPI::TEST):
3486
3487 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3488
3489         [GTK] Make Tools/gtkdoc python3 compatible
3490         https://bugs.webkit.org/show_bug.cgi?id=195359
3491
3492         Reviewed by Carlos Garcia Campos.
3493
3494         * gtkdoc/generate-gtkdoc:
3495         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3496         work with Python 2 and 3.
3497         (get_gtkdoc_module_paths):
3498         The iteritems() was removed in Python 3, so let's use items() that's
3499         available in Python 2 and 3.
3500         (get_generator_for_config):
3501         * gtkdoc/gtkdoc.py:
3502         (GTKDoc._run_command):
3503         The sys.stdout.write() is expecting str in Python 3 and not bytes
3504         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3505         for passing the bytes there.
3506
3507 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3508
3509         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3510         https://bugs.webkit.org/show_bug.cgi?id=195346
3511         <rdar://problem/48667048>
3512
3513         Unreviewed build fix for clang-cl.
3514
3515         * DumpRenderTree/win/DumpRenderTree.cpp:
3516         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3517
3518 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3519
3520         requestAnimationFrame should execute before the next frame
3521         https://bugs.webkit.org/show_bug.cgi?id=177484
3522
3523         Reviewed by Simon Fraser.
3524
3525         Add trace points for the page RenderingUpdate.
3526
3527         * Tracing/SystemTracePoints.plist:
3528
3529 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3530
3531         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3532         https://bugs.webkit.org/show_bug.cgi?id=195353
3533         <rdar://problem/48626394>
3534
3535         Reviewed by Simon Fraser.
3536
3537         * WebKitTestRunner/ios/TestControllerIOS.mm:
3538         (WTR::TestController::platformResetPreferencesToConsistentValues):
3539
3540 2019-03-07  John Wilander  <wilander@apple.com>
3541
3542         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3543         https://bugs.webkit.org/show_bug.cgi?id=195383
3544         <rdar://problem/48570136>
3545
3546         Reviewed by Brent Fulgham.
3547
3548         This patch adds test infrastructure to purge only script-accessible cookies,
3549         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3550
3551         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3552         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3553         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3554         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3555         * WebKitTestRunner/TestController.cpp:
3556         (WTR::TestController::statisticsDeleteCookiesForHost):
3557         * WebKitTestRunner/TestController.h:
3558         * WebKitTestRunner/TestInvocation.cpp:
3559         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3560
3561 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3562
3563         Unreviewed, rolling out r242354.
3564         https://bugs.webkit.org/show_bug.cgi?id=195402
3565
3566         breaks layout tests in all configurations (Requested by
3567         zdobersek on #webkit).
3568
3569         Reverted changeset:
3570
3571         "[WPE] Enable web process sandbox"
3572         https://bugs.webkit.org/show_bug.cgi?id=195169
3573         https://trac.webkit.org/changeset/242354
3574
3575 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3576
3577         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3578         https://bugs.webkit.org/show_bug.cgi?id=195346
3579
3580         Reviewed by Fujii Hironori.
3581
3582         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3583         (TestWebKitAPI::TEST):
3584         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3585
3586         * DumpRenderTree/win/DumpRenderTree.cpp:
3587         (findFontFallback):
3588         (addFontFallbackIfPresent):
3589         (removeFontFallbackIfPresent):
3590         (main):
3591         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3592         (TestWebKitAPI::Util::moduleDirectory):
3593         (TestWebKitAPI::Util::createInjectedBundlePath):
3594         Use wchar helpers as needed.
3595
3596 2019-03-06  Rob Buis  <rbuis@igalia.com>
3597
3598         Consider supporting the `referrerpolicy` attribute.
3599         https://bugs.webkit.org/show_bug.cgi?id=179053
3600
3601         Reviewed by Darin Adler.
3602
3603         Add a runtime flag for referrerpolicy attribute.
3604
3605         * DumpRenderTree/mac/DumpRenderTree.mm:
3606         (enableExperimentalFeatures):
3607
3608 2019-03-05  Daniel Bates  <dabates@apple.com>
3609
3610         Update expected API test result following r242379
3611         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3612
3613         Update expected x-coordinate of selection rect now that the left padding of
3614         a textarea is sized in ems (so dependent on the font size) just like the left
3615         padding of a text field.
3616
3617         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3618         (TestWebKitAPI::TEST):
3619
3620 2019-03-05  David Quesada  <david_quesada@apple.com>
3621
3622         [WK2] It should be possible to follow links with 'download' attributes
3623         https://bugs.webkit.org/show_bug.cgi?id=195145
3624         rdar://problem/48462642
3625
3626         Reviewed by Alex Christensen.
3627
3628         Add a unit test to verify that activating links with 'download' attributes now
3629         navigates to the linked resource, rather than starts downloading it. Add another
3630         to verify that it is still possible to explicitly download the link via the
3631         'Download' navigation action policy.
3632
3633         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3634         (-[DownloadAttributeTestDelegate init]):
3635         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3636         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3637         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3638         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3639         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3640         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3641         (TEST):
3642         * WebKitTestRunner/TestController.cpp:
3643         (WTR::TestController::decidePolicyForNavigationAction):
3644         * WebKitTestRunner/TestController.h:
3645
3646 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3647
3648         [Curl] Implement Cookie Accept Policy.
3649         https://bugs.webkit.org/show_bug.cgi?id=191645
3650
3651         Reviewed by Fujii Hironori.
3652
3653         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3654         (TestWebKitAPI::Curl::TEST_F):
3655
3656 2019-03-05  Youenn Fablet  <youenn@apple.com>
3657
3658         Rename requestCacheStorageSpace to requestStorageSpace
3659         https://bugs.webkit.org/show_bug.cgi?id=195282
3660
3661         Reviewed by Chris Dumez.
3662
3663         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3664         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3665         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3666
3667 2019-03-05  Brady Eidson  <beidson@apple.com>
3668
3669         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3670         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3671
3672         Reviewed by Tim Horton.
3673
3674         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3675         different directory into that same WKWebView should work.
3676
3677         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3678         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3679
3680 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3681
3682         Add WeakHashSet
3683         https://bugs.webkit.org/show_bug.cgi?id=195152
3684
3685         Reviewed by Antti Koivisto.
3686
3687         Added tests for WeakHashSet.
3688
3689         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3690         (TestWebKitAPI::Base::Base): Moved.
3691         (TestWebKitAPI::Derived::foo): Moved.
3692         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3693         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3694         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3695         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3696
3697 2019-03-04  Chris Dumez  <cdumez@apple.com>
3698
3699         Do not share WebProcesses between private and regular sessions
3700         https://bugs.webkit.org/show_bug.cgi?id=195189
3701         <rdar://problem/48421064>
3702
3703         Reviewed by Alex Christensen.
3704
3705         Add API test coverage.
3706
3707         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3708         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3709
3710 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3711
3712         [WPE] Enable web process sandbox
3713         https://bugs.webkit.org/show_bug.cgi?id=195169
3714
3715         Reviewed by Daniel Bates.
3716
3717         * wpe/install-dependencies:
3718         * wpe/jhbuild.modules:
3719
3720 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3721
3722         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3723         https://bugs.webkit.org/show_bug.cgi?id=195206
3724
3725         Reviewed by Žan Doberšek.
3726
3727         Add a new test case.
3728
3729         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3730         (testJSCClass):
3731
3732 2019-03-04  Charlie Turner  <cturner@igalia.com>
3733
3734         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3735         https://bugs.webkit.org/show_bug.cgi?id=194898
3736
3737         Reviewed by Žan Doberšek.
3738
3739         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3740         a GCC extension that permits arithmetic on void* pointer. Inline
3741         the macro until this issue is fixed upstream.
3742
3743 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3744
3745         Rid the world of WK_API_ENABLED
3746         https://bugs.webkit.org/show_bug.cgi?id=195263
3747
3748         Reviewed by Dan Bernstein.
3749
3750         List of changed files elided because it's useless.
3751
3752 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3753
3754         Unreviewed follow-up to r242292.
3755
3756         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3757
3758         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3759         (TestWebKitAPI::testStrip): Renamed from strip.
3760         (TestWebKitAPI::TEST):
3761
3762 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3763
3764         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3765
3766         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3767         and bug #194272 for details.
3768
3769         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3770
3771 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3772
3773         Remove some more unused 32-bit code
3774         https://bugs.webkit.org/show_bug.cgi?id=195255
3775
3776         Reviewed by Darin Adler.
3777
3778         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3779         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3780         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3781         (NPP_New):
3782         (NPP_HandleEvent):
3783         (handleEventCarbon): Deleted.
3784
3785 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3786
3787         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3788
3789         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3790         (TestWebKitAPI::TEST):
3791
3792 2019-03-01  Darin Adler  <darin@apple.com>
3793
3794         Finish removing String::format
3795         https://bugs.webkit.org/show_bug.cgi?id=194893
3796
3797         Reviewed by Daniel Bates.
3798 '
3799         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3800
3801 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3802
3803         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3804         https://bugs.webkit.org/show_bug.cgi?id=195229
3805         <rdar://problem/48520362>
3806
3807         Reviewed by Chris Dumez.
3808
3809         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3810         (TEST):
3811
3812 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3813
3814         Add a system trace scope for event region building
3815         https://bugs.webkit.org/show_bug.cgi?id=195226
3816
3817         Reviewed by Jon Lee.
3818
3819         This trace scope measures the time spend converting element rects into Region objects,
3820         which can be large on some pages.
3821
3822         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3823
3824         * Tracing/SystemTracePoints.plist:
3825
3826 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3827
3828         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3829         https://bugs.webkit.org/show_bug.cgi?id=194612
3830
3831         Reviewed by Alex Christensen.
3832
3833         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3834         Just test the new string-processing function and don't touch the actual environment.
3835         (Test cases are all as before, but based on operator== instead of strcmp.)
3836
3837 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3838
3839         [ews-app] Update primary keys for handling multiple Buildbot instances
3840         https://bugs.webkit.org/show_bug.cgi?id=195120
3841
3842         Reviewed by Stephanie Lewis.
3843
3844         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3845         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3846         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3847
3848         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3849         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3850         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3851         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3852         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3853         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3854
3855 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3856
3857         [WinCairo] Enable service worker
3858         https://bugs.webkit.org/show_bug.cgi?id=188318
3859
3860         Reviewed by Youenn Fablet.
3861
3862         * DumpRenderTree/DumpRenderTreePrefix.h:
3863         * TestWebKitAPI/PlatformWin.cmake:
3864         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3865         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3866         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3867
3868 2019-03-01  Justin Fan  <justin_fan@apple.com>
3869
3870         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3871         https://bugs.webkit.org/show_bug.cgi?id=195191
3872
3873         Rubber-stamped by Dean Jackson.
3874
3875         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3876
3877         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3878
3879 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3880
3881         Unreviewed, fix lldb webkitpy tests
3882         https://bugs.webkit.org/show_bug.cgi?id=194375
3883
3884         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3885
3886         * lldb/lldb_webkit.py:
3887         (WTFStringImplProvider.is_8bit):
3888
3889 2019-02-28  David Quesada  <david_quesada@apple.com>
3890
3891         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3892         https://bugs.webkit.org/show_bug.cgi?id=195121
3893         rdar://problem/48450302
3894
3895         Reviewed by Alex Christensen.
3896
3897         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3898         configurations where the 'download' attribute is absent, blank, or populated
3899         with a filename, and where the anchor element is same-origin or cross-origin
3900         (meaning the 'download' attribute shouldn't be honored).
3901
3902         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3903         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3904         (-[NavigationActionTestDelegate init]):
3905         (-[NavigationActionTestDelegate navigationAction]):
3906         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3907         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3908         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3909         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3910         (TEST):
3911
3912 2019-02-28  Antoine Quint  <graouts@apple.com>
3913
3914         Enable the Pointer Events runtime flag by default
3915         https://bugs.webkit.org/show_bug.cgi?id=195156
3916
3917         Reviewed by Dean Jackson.
3918
3919         * DumpRenderTree/mac/DumpRenderTree.mm:
3920         (enableExperimentalFeatures):
3921
3922 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3923
3924         Several PasteImage API tests are flaky
3925         https://bugs.webkit.org/show_bug.cgi?id=195160
3926
3927         Reviewed by Tim Horton.
3928
3929         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3930         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3931         listening for a "load" event after image load is already complete.
3932
3933         To address this, make these tests first register a "load" event handler, then run script to insert an image
3934         element into the document, and finally wait until the load event is observed before checking image size.
3935
3936         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3937
3938 2019-02-28  Chris Dumez  <cdumez@apple.com>
3939
3940         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3941         https://bugs.webkit.org/show_bug.cgi?id=195107
3942
3943         Reviewed by Alex Christensen.
3944
3945         Give some time for the zoom level to get restored.
3946
3947         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3948
3949 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3950
3951         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3952         https://bugs.webkit.org/show_bug.cgi?id=194958
3953
3954         Reviewed by Geoffrey Garen.
3955
3956         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3957         (TEST):
3958
3959 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3960
3961         [ews-app] Update method to save build to handle builder_display_name
3962         https://bugs.webkit.org/show_bug.cgi?id=195047
3963
3964         Reviewed by Dewei Zhu.
3965
3966         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3967         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3968
3969 2019-02-28  Justin Fan  <justin_fan@apple.com>
3970
3971         [Web GPU] Enable Web GPU only on 64-bit
3972         https://bugs.webkit.org/show_bug.cgi?id=195139
3973
3974         Because Metal is only supported on 64 bit apps.
3975
3976         Unreviewed build fix.
3977
3978         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3979
3980 2019-02-27  Youenn Fablet  <youenn@apple.com>
3981
3982         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3983         https://bugs.webkit.org/show_bug.cgi?id=194959
3984
3985         Reviewed by Chris Dumez.
3986
3987         Spin loop until getting the condition to remove flakiness.
3988
3989         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3990
3991 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3992
3993         [ews-build] Buildbot should include builder_display_name in the build events
3994         https://bugs.webkit.org/show_bug.cgi?id=195045
3995
3996         Reviewed by Dewei Zhu.
3997
3998         * BuildSlaveSupport/ews-build/events.py:
3999         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4000         buildername to builder_name to be consistent in naming style.
4001         (Events.buildFinished): Ditto.
4002
4003 2019-02-27  Chris Dumez  <cdumez@apple.com>
4004
4005         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4006         https://bugs.webkit.org/show_bug.cgi?id=194480
4007
4008         Reviewed by Brady Eidson.
4009
4010         Update existing API test to make it more likely to reproduce the issue.
4011
4012         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4013
4014 2019-02-27  Brady Eidson  <beidson@apple.com>
4015
4016         Universal links from Google search results pages don't open the app.
4017         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4018
4019         Reviewed by Geoffrey Garen.
4020
4021         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4022         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4023         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4024         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4025
4026 2019-02-27  Chris Dumez  <cdumez@apple.com>
4027
4028         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4029         https://bugs.webkit.org/show_bug.cgi?id=195102
4030
4031         Reviewed by Geoffrey Garen.
4032
4033         If the number of processes is not yet what we expect, wait a bit and check again to give
4034         processes some time to exit.
4035
4036         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4037
4038 2019-02-27  Chris Dumez  <cdumez@apple.com>
4039
4040         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4041         https://bugs.webkit.org/show_bug.cgi?id=194545
4042
4043         Reviewed by Brady Eidson.
4044
4045         Make sure the test navigates forward and then back only once. Previously, navigating
4046         back would trigger a navigation again in a timer.
4047
4048         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4049
4050 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4051
4052         High Sierra Debug JSC test queue should use faster hardware
4053         https://bugs.webkit.org/show_bug.cgi?id=194603
4054
4055         Rubber-stamped by Alexey Proskuryakov.
4056
4057         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4058
4059         * BuildSlaveSupport/build.webkit.org-config/config.json:
4060         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4061         (BubbleQueueServer):
4062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4063         (WebKitBuildbot):
4064         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4065         * QueueStatusServer/config/queues.py:
4066         * Scripts/webkitpy/common/config/ews.json:
4067         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4068         (test_ews_name):
4069
4070 2019-02-27  John Wilander  <wilander@apple.com>
4071
4072         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4073         https://bugs.webkit.org/show_bug.cgi?id=195071
4074         <rdar://problem/48417690>
4075
4076         Reviewed by Alex Christensen and Brent Fulgham.
4077
4078         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4079         (TestWebKitAPI::createURL):
4080             Convenience function.
4081         (TestWebKitAPI::TEST):
4082             WebCore::AdClickAttribution now takes a URL when creating Source and
4083             Destination.
4084         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4085         (TestWebKitAPI::TEST):
4086             WebCore::AdClickAttribution now takes a URL when creating Source and
4087             Destination.
4088
4089 2019-02-27  Antoine Quint  <graouts@apple.com>
4090
4091         Support Pointer Events on macOS
4092         https://bugs.webkit.org/show_bug.cgi?id=195008
4093         <rdar://problem/47454419>
4094
4095         Reviewed by Dean Jackson.
4096
4097         * DumpRenderTree/mac/DumpRenderTree.mm:
4098         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4099         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4100
4101 2019-02-26  Mark Lam  <mark.lam@apple.com>
4102
4103         Remove remaining poisoning code.
4104         https://bugs.webkit.org/show_bug.cgi?id=194138
4105
4106         Reviewed by Saam Barati.
4107
4108         * TestWebKitAPI/CMakeLists.txt:
4109         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4110         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4111         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4112         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4113         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4114         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4115         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4116
4117 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4118
4119         Move ephemeral local storage from WebProcess to UIProcess
4120         https://bugs.webkit.org/show_bug.cgi?id=195074
4121         <rdar://problem/47937975>
4122
4123         Reviewed by Geoff Garen.
4124
4125         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4126
4127 2019-02-20  Jer Noble  <jer.noble@apple.com>
4128
4129         [Cocoa] Media elements will restart network buffering just before suspending
4130         https://bugs.webkit.org/show_bug.cgi?id=193691
4131
4132         Reviewed by Eric Carlson.
4133
4134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4135         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4136         (TEST):
4137
4138 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4139
4140         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4141         https://bugs.webkit.org/show_bug.cgi?id=191652
4142
4143         Reviewed by Alex Christensen.
4144
4145         Fix WinCairo MiniBrowser behavior of authentication dialog.
4146
4147         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4148         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4149
4150 2019-02-26  Youenn Fablet  <youenn@apple.com>
4151
4152         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4153         https://bugs.webkit.org/show_bug.cgi?id=195028
4154         <rdar://problem/48243733>
4155
4156         Reviewed by Eric Carlson.
4157
4158         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4159
4160 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4161
4162         [WPE] Add API for webview background color configuration
4163         https://bugs.webkit.org/show_bug.cgi?id=192305
4164
4165         Reviewed by Michael Catanzaro.
4166
4167         * MiniBrowser/wpe/main.cpp:
4168         (main): Add a new option to configure the webview background
4169         color. Example: --bg-color=transparent.
4170         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4171         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4172         (beforeAll): Ditto.
4173
4174 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4175
4176         scalableNativeWebpageParameters() is not preserved on new page navigation.
4177         https://bugs.webkit.org/show_bug.cgi?id=194892
4178         <rdar://problem/47538280>
4179
4180         Reviewed by Wenson Hsieh.
4181         
4182         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4183
4184         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4185         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4186         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4187         (WTR::UIScriptController::allowsViewportShrinkToFit):
4188         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4189         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4190         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4191         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4192         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4193         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4194
4195 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4196
4197         [ews-app] Add model for handling multiple Buildbot instances
4198         https://bugs.webkit.org/show_bug.cgi?id=194863
4199
4200         Reviewed by Stephanie Lewis.
4201
4202         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4203
4204 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4205
4206         [ews-app] Remove BuilderMapping table
4207         https://bugs.webkit.org/show_bug.cgi?id=194961
4208
4209         Reviewed by Stephanie Lewis.
4210
4211         Store builder name directly in build table, instead of having a separate
4212         table for it.
4213
4214         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4215         * BuildSlaveSupport/ews-app/ews/models/build.py:
4216         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4217         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4218
4219 2019-02-25  John Wilander  <wilander@apple.com>
4220
4221         Introduce and adopt new class RegistrableDomain for eTLD+1
4222         https://bugs.webkit.org/show_bug.cgi?id=194791
4223         <rdar://problem/48179240>
4224
4225         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4226
4227         This patch adds an API test and replaces two instances of
4228         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4229
4230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4231         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4232         (TestWebKitAPI::TEST):
4233             Changed two strings to make sure the registrable domains are still considered
4234             invalid and pass the test.
4235         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4236         (TestWebKitAPI::TEST):
4237         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4238         (WTR::InjectedBundle::didReceiveMessageToPage):
4239
4240 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4241
4242         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4243         https://bugs.webkit.org/show_bug.cgi?id=195001
4244
4245         Reviewed by Carlos Garcia Campos.
4246
4247         API version 1.0 always includes the functionality previously guarded with
4248         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4249         unconditionally.
4250
4251         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4252         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4253         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4254         (WebViewTest::showInWindow): Ditto.
4255         (WebViewTest::hideView): Ditto.
4256         * wpe/backends/HeadlessViewBackend.cpp:
4257         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4258         * wpe/backends/ViewBackend.cpp:
4259         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4260         * wpe/backends/WindowViewBackend.cpp:
4261         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4262         WPE_BACKEND_CHECK_VERSION().
4263         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4264
4265 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4266
4267         [Flatpak] Add support for flatpak > 1.1.2
4268         https://bugs.webkit.org/show_bug.cgi?id=194088
4269
4270         Flatpak 1.2 is now out so we need to support that
4271         version now.
4272
4273         Reviewed by Michael Catanzaro.
4274
4275         * flatpak/flatpakutils.py:
4276         (check_flatpak):
4277         (FlatpakPackages.__init__):
4278         (FlatpakPackages.__detect_packages):
4279         (FlatpakPackages.__detect_packages.in):
4280         (FlatpakRepos.update):
4281
4282 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4283
4284         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4285         https://bugs.webkit.org/show_bug.cgi?id=194998
4286
4287         Reviewed by Carlos Garcia Campos.
4288
4289         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4290         to a Git checkout and using the latest commit containing various fixes
4291         and improvements.
4292
4293 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4294
4295         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4296         https://bugs.webkit.org/show_bug.cgi?id=194981
4297
4298         Reviewed by Žan Doberšek.
4299
4300         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4301         (TestWebKitAPI::TEST):
4302
4303 2019-02-23  Keith Miller  <keith_miller@apple.com>
4304
4305         Add new mac target numbers
4306         https://bugs.webkit.org/show_bug.cgi?id=194955
4307
4308         Reviewed by Tim Horton.
4309
4310         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4311         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4312         * MiniBrowser/Configurations/Base.xcconfig:
4313         * TestWebKitAPI/Configurations/Base.xcconfig:
4314         * WebKitTestRunner/Configurations/Base.xcconfig:
4315
4316 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4317
4318         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4319         https://bugs.webkit.org/show_bug.cgi?id=194846
4320
4321         Reviewed by Don Olmstead.
4322
4323         Added _search_paths() and _port_specific_expectations_files() for
4324         WinCairoPort.
4325
4326         * Scripts/webkitpy/port/win.py:
4327         (WinCairoPort.default_baseline_search_path):
4328         (WinCairoPort):
4329         (WinCairoPort._port_specific_expectations_files):
4330         (WinCairoPort._search_paths):
4331
4332 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4333
4334         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4335         https://bugs.webkit.org/show_bug.cgi?id=194963
4336
4337         Reviewed by Dean Jackson.
4338
4339         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4340         Do a `contains` check instead of `equals`, because in debug builds we
4341         put the GraphicsLayer pointer in a prefix.
4342
4343 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4344
4345         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4346         https://bugs.webkit.org/show_bug.cgi?id=194873
4347         <rdar://problem/46701974>
4348
4349         Reviewed by Tim Horton.
4350
4351         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4352
4353         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4354         (WTR::UIScriptController::menuRect const):
4355         (WTR::UIScriptController::isShowingMenu const):
4356         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4357         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4358         (WTR::UIScriptController::menuRect const):
4359
4360         Add a function to query the bounds of the callout menu in content coordinates.
4361
4362         (WTR::UIScriptController::isShowingMenu const):
4363
4364         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4365
4366         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4367         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4368  &nbs