AX: Support API: accessibilityReplaceRange:withText
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2
3         AX: Support API: accessibilityReplaceRange:withText
4         https://bugs.webkit.org/show_bug.cgi?id=196636
5
6         Reviewed by Daniel Bates.
7
8         * DumpRenderTree/AccessibilityUIElement.cpp:
9         (replaceTextInRangeCallback):
10         (AccessibilityUIElement::replaceTextInRange):
11         (AccessibilityUIElement::getJSClass):
12         * DumpRenderTree/AccessibilityUIElement.h:
13         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
14         (AccessibilityUIElement::replaceTextInRange):
15         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
16         (AccessibilityUIElement::replaceTextInRange):
17         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
18         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
19         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
20         (WTR::AccessibilityUIElement::replaceTextInRange):
21         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
22         (WTR::AccessibilityUIElement::replaceTextInRange):
23
24 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
25
26         [iOS] Do not allow starting selection drags when selection views are not visible
27         https://bugs.webkit.org/show_bug.cgi?id=196686
28         <rdar://problem/49399192>
29
30         Reviewed by Tim Horton.
31
32         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
33         also add some new API tests to cover scenarios where the web view is not first responder.
34
35         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
36         (TestWebKitAPI::TEST):
37         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
38
39         Add a switch to optionally make the web view first responder when starting the simulated drag.
40
41         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
42         (-[DragAndDropSimulator initWithWebView:]):
43         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
44
45 2019-04-08  Justin Fan  <justin_fan@apple.com>
46
47         [Web GPU] Fix Web GPU experimental feature on iOS
48         https://bugs.webkit.org/show_bug.cgi?id=196632
49
50         Reviewed by Myles C. Maxfield.
51
52         Properly make Web GPU available on iOS 11+.
53
54         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
55
56 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
57
58         [ews-build] Do not upload archive when Compile Fails
59         https://bugs.webkit.org/show_bug.cgi?id=196674
60
61         Reviewed by Alexey Proskuryakov.
62
63         * BuildSlaveSupport/ews-build/factories.py:
64         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
65         * BuildSlaveSupport/ews-build/steps.py:
66         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
67         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
68         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
69
70 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
71
72         Enable DFG on MIPS
73         https://bugs.webkit.org/show_bug.cgi?id=196689
74
75         Reviewed by Žan Doberšek.
76
77         Since the bytecode change, we enabled the baseline JIT on mips in
78         r240432, but DFG is still missing. With this change, all tests are
79         passing on a ci20 board.
80
81         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
82
83 2019-04-08  Philippe Normand  <pnormand@igalia.com>
84
85         [Flatpak] Second run update-webkitwpe-flatpak fails
86         https://bugs.webkit.org/show_bug.cgi?id=192702
87
88         Reviewed by Carlos Garcia Campos.
89
90         * flatpak/flatpakutils.py:
91         (FlatpakObject.flatpak): Fix typo.
92         (FlatpakPackage.install): When installing, also update to the configured remote commit.
93         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
94
95 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
96
97         [GTK][WPE] outlook.live.com displays old-fashioned UI
98         https://bugs.webkit.org/show_bug.cgi?id=196642
99
100         Reviewed by Carlos Garcia Campos.
101
102         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
103         (TestWebKitAPI::TEST): New Mac platform quirk test.
104
105 2019-04-07  Commit Queue  <commit-queue@webkit.org>
106
107         Unreviewed, rolling out r243956.
108         https://bugs.webkit.org/show_bug.cgi?id=196688
109
110         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
111         by aakashjain on #webkit).
112
113         Reverted changeset:
114
115         "Clicking "Go Back" from a safe browsing warning from an
116         iframe should navigate the WKWebView back to the previous
117         page"
118         https://bugs.webkit.org/show_bug.cgi?id=196665
119         https://trac.webkit.org/changeset/243956
120
121 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
122
123         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
124         https://bugs.webkit.org/show_bug.cgi?id=196669
125
126         Reviewed by Geoffrey Garen.
127
128         Added three new unit tests for WeakHashSet.
129
130         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
131         (WTF_WeakPtr.WeakHashSetConstObjects):
132         (WTF_WeakPtr.WeakHashSetComputesEmpty):
133         (WTF_WeakPtr.WeakHashSetComputeSize):
134
135 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
136
137         Hide next and previous form control buttons when WKWebView is editable
138         https://bugs.webkit.org/show_bug.cgi?id=196672
139         <rdar://problem/35625321>
140
141         Reviewed by Tim Horton.
142
143         Add a new API test.
144
145         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
146         (-[TestWKWebView lastTrailingBarButtonGroup]):
147         (TestWebKitAPI::TEST):
148         * TestWebKitAPI/ios/UIKitSPI.h:
149
150 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
151
152         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
153         https://bugs.webkit.org/show_bug.cgi?id=196077
154         <rdar://problem/49108202>
155
156         Reviewed by Chris Dumez.
157
158         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
159         on new web view.
160
161         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
162
163 2019-04-05  Saam Barati  <sbarati@apple.com>
164
165         Make compare-results understand MotionMark
166         https://bugs.webkit.org/show_bug.cgi?id=196666
167
168         Reviewed by Yusuke Suzuki.
169
170         * Scripts/compare-results:
171         (PLT5Results):
172         (detectMotionMark):
173         (detectMotionMark1_1):
174         (motionMarkResults):
175         (motionMark1_1Results):
176         (detectBenchmark):
177         (biggerIsBetter):
178         (main):
179
180 2019-04-05  Alex Christensen  <achristensen@webkit.org>
181
182         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
183         https://bugs.webkit.org/show_bug.cgi?id=196665
184         <rdar://45115669>
185
186         Reviewed by Geoff Garen.
187
188         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
189         (goBack):
190         (+[SimpleLookupContext sharedLookupContext]):
191         (-[SimpleLookupContext lookUpURL:completionHandler:]):
192         (TEST):
193         (+[Simple3LookupContext sharedLookupContext]): Deleted.
194         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
195
196 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
197
198         [ews-build] Add configuration and architecture for windows builders
199         https://bugs.webkit.org/show_bug.cgi?id=196660
200
201         Reviewed by Lucas Forschler.
202
203         * BuildSlaveSupport/ews-build/config.json:
204
205 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
206
207         webkitpy: Don't run subsequent rounds if interrupted
208         https://bugs.webkit.org/show_bug.cgi?id=196646
209
210         Reviewed by Aakash Jain.
211
212         * Scripts/webkitpy/layout_tests/controllers/manager.py:
213         (Manager.run): Bail out if interrupted.
214
215 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
216
217         Test sessionStorage in PSON private browsing mode
218         https://bugs.webkit.org/show_bug.cgi?id=196561
219
220         Reviewed by Alex Christensen.
221
222         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
223
224 2019-04-05  Commit Queue  <commit-queue@webkit.org>
225
226         Unreviewed, rolling out r243833.
227         https://bugs.webkit.org/show_bug.cgi?id=196645
228
229         This change breaks build of WPE and GTK ports (Requested by
230         annulen on #webkit).
231
232         Reverted changeset:
233
234         "[CMake][WTF] Mirror XCode header directories"
235         https://bugs.webkit.org/show_bug.cgi?id=191662
236         https://trac.webkit.org/changeset/243833
237
238 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
239
240         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
241         https://bugs.webkit.org/show_bug.cgi?id=196635
242
243         Reviewed by Antti Koivisto.
244         
245         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
246         for a test to enable async frame scrolling via:
247             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
248         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
249         
250         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
251
252         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
253         (WTR::InjectedBundle::beginTesting):
254         * WebKitTestRunner/TestController.cpp:
255         (WTR::TestController::resetPreferencesToConsistentValues):
256
257 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
258
259         Use a correct LC_RPATH when building with ASan
260         https://bugs.webkit.org/show_bug.cgi?id=196576
261
262         Reviewed by David Kilzer.
263
264         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
265         so that ../Frameworks is checked. This is simpler and more reliable than updating
266         each SPC service xcconfig.
267
268 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
269
270         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
271         https://bugs.webkit.org/show_bug.cgi?id=196629
272
273         Reviewed by Lucas Forschler.
274
275         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
276
277 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
278
279         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
280         https://bugs.webkit.org/show_bug.cgi?id=196618
281
282         Reviewed by Lucas Forschler.
283
284         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
285         (StatusBubble): Added QUEUE_TRIGGERS.
286         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
287         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
288         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
289         its parent(builder).
290
291 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
292
293         [ews-app] Status-bubble steps are sometimes displayed in reverse order
294         https://bugs.webkit.org/show_bug.cgi?id=196625
295
296         Reviewed by Lucas Forschler.
297
298         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
299         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
300
301 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
302
303         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
304         https://bugs.webkit.org/show_bug.cgi?id=196630
305
306         Reviewed by Wenson Hsieh.
307
308         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
309
310 2019-04-04  Youenn Fablet  <youenn@apple.com>
311
312         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
313         https://bugs.webkit.org/show_bug.cgi?id=196543
314
315         Reviewed by Alex Christensen.
316
317         * WebKitTestRunner/TestController.cpp:
318         (WTR::TestController::generatePageConfiguration):
319
320 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
321
322         [ews-app] Status bubble should not display skipped buildbot steps
323         https://bugs.webkit.org/show_bug.cgi?id=196584
324
325         Reviewed by Lucas Forschler.
326
327         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
328
329 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
330
331         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
332         https://bugs.webkit.org/show_bug.cgi?id=196620
333
334         Reviewed by Lucas Forschler.
335
336         * BuildSlaveSupport/ews-app/ews/config.py:
337
338 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
339
340         [Win] DumpRenderTreeWatchDog.py is not checked into source
341         https://bugs.webkit.org/show_bug.cgi?id=196567
342         <rdar://problem/49525901>
343
344         Reviewed by Lucas Forschler.
345
346         This script is used on Win EWS bots to terminate hanging DRT processes.
347
348         * EWSTools/dumprendertreewatchdog.py: Added.
349
350 2019-04-04  Chris Dumez  <cdumez@apple.com>
351
352         Unreviewed, roll out r243858 which made tests time out.
353
354         Disable new API tests on Windows instead.
355
356         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
357         (TestWebKitAPI::TEST):
358
359 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
360
361         [ATK] Cleanup WebPageAccessibilityObjectAtk
362         https://bugs.webkit.org/show_bug.cgi?id=196537
363
364         Reviewed by Michael Catanzaro.
365
366         Also consider files under atk directories as exceptions for GObject conventions.
367
368         * Scripts/webkitpy/style/checkers/cpp.py:
369         (check_identifier_name_in_declaration):
370
371 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
372
373         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
374         https://bugs.webkit.org/show_bug.cgi?id=196588
375         <rdar://problem/49365787>
376
377         Unreviewed build fix for Windows port.
378
379         error C3861: 'kill': identifier not found
380
381         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
382         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
383
384 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
385
386         [ews-build] Cancel build and similar operations should have authentication
387         https://bugs.webkit.org/show_bug.cgi?id=196520
388
389         Reviewed by Dewei Zhu.
390
391         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
392         environment variables.
393
394 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
395
396         [ews-build] Do not trigger queues which are not in production yet
397         https://bugs.webkit.org/show_bug.cgi?id=196581
398
399         Reviewed by Dewei Zhu.
400
401         * BuildSlaveSupport/ews-build/config.json:
402
403 2019-04-03  Chris Dumez  <cdumez@apple.com>
404
405         Unreviewed, fix typo in the name of API test added in r243848.
406
407         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
408         (TestWebKitAPI::TEST):
409
410 2019-04-03  Chris Dumez  <cdumez@apple.com>
411
412         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
413         https://bugs.webkit.org/show_bug.cgi?id=196588
414         <rdar://problem/49365787>
415
416         Reviewed by Ryosuke Niwa.
417
418         Add API test coverage.
419
420         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
421         (TestWebKitAPI::nullJavaScriptCallback):
422         (TestWebKitAPI::didCrashCheckFrames):
423         (TestWebKitAPI::TEST):
424
425 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
426
427         run-webkit-tests: Upload test results (new results database)
428         https://bugs.webkit.org/show_bug.cgi?id=196577
429         <rdar://problem/34841155>
430
431         Reviewed by Lucas Forschler.
432
433         * Scripts/webkitpy/layout_tests/controllers/manager.py:
434         (Manager.run): Upload results after each device shard, since the configuration will be
435         different for each device.
436         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
437         uploaded to a results database.
438         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
439         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
440
441 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
442
443         -apple-trailing-word is needed for browser detection
444         https://bugs.webkit.org/show_bug.cgi?id=196575
445
446         Unreviewed.
447
448         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
449
450 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
451
452         [CMake][WTF] Mirror XCode header directories
453         https://bugs.webkit.org/show_bug.cgi?id=191662
454
455         Reviewed by Konstantin Tokarev.
456
457         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
458         builds.
459
460         * CMakeLists.txt:
461         * DumpRenderTree/CMakeLists.txt:
462         * DumpRenderTree/PlatformWin.cmake:
463         * MiniBrowser/win/CMakeLists.txt:
464         * TestWebKitAPI/CMakeLists.txt:
465         * TestWebKitAPI/PlatformWin.cmake:
466         * WebKitTestRunner/PlatformGTK.cmake:
467         * WebKitTestRunner/PlatformWin.cmake:
468
469 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
470
471         [ews-app] Status bubble should not display certain infrastructure status messages
472         https://bugs.webkit.org/show_bug.cgi?id=196550
473
474         Reviewed by Lucas Forschler.
475
476         Do not display the steps which are un-needed for end-user. This information is still avaiable
477         if the user click on the bubble and look at the Buildbot build.
478         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
479         (StatusBubble._steps_messages):
480         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
481
482 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
483
484         [ews-build] Use https for sending data to ews-app
485         https://bugs.webkit.org/show_bug.cgi?id=196492
486
487         Reviewed by Lucas Forschler.
488
489         * BuildSlaveSupport/ews-build/events.py:
490
491 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
492
493         Remove support for -apple-trailing-word
494         https://bugs.webkit.org/show_bug.cgi?id=196525
495
496         Reviewed by Zalan Bujtas.
497
498         This CSS property is nonstandard and not used.
499
500         * Scripts/webkitperl/FeatureList.pm:
501         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
502
503 2019-04-03  Youenn Fablet  <youenn@apple.com>
504
505         Add a test for DOMCache on multiple browsing in case of private browsing
506         https://bugs.webkit.org/show_bug.cgi?id=196524
507
508         Reviewed by Alex Christensen.
509
510         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
511         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
512
513 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
514
515         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
516         https://bugs.webkit.org/show_bug.cgi?id=196540
517
518         Reviewed by Aakash Jain.
519
520         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
521
522 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
523
524         Add plumbing for a compatibility mode preference in WebKit
525         https://bugs.webkit.org/show_bug.cgi?id=196005
526
527         Reviewed by Tim Horton.
528
529         Add new API tests.
530
531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
532         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
533
534 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
535
536         [WPE][GTK] Update libsrtp dependency package for Debian
537         https://bugs.webkit.org/show_bug.cgi?id=196528
538
539         Reviewed by Frédéric Wang.
540
541         * gtk/install-dependencies:
542         * wpe/install-dependencies:
543
544 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
545
546         [WK2] Add support for Window's beforeprint / afterprint events
547         https://bugs.webkit.org/show_bug.cgi?id=196478
548         <rdar://problem/49535124>
549
550         Unreviewed build fix for MSVC.
551
552         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
553
554         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
555
556         * WebKitTestRunner/TestController.cpp:
557         (WTR::printFrame): Use int and float literals.
558
559 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
560
561         [ews-build] Reassign bots to queues
562
563         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
564
565 2019-04-02  Chris Dumez  <cdumez@apple.com>
566
567         [WK2] Add support for Window's beforeprint / afterprint events
568         https://bugs.webkit.org/show_bug.cgi?id=196478
569
570         Reviewed by Alex Christensen.
571
572         Add minimal implementation for printFrame in WebKitTestRunner.
573
574         * WebKitTestRunner/TestController.cpp:
575         (WTR::printFrame):
576         (WTR::TestController::createOtherPage):
577         (WTR::TestController::createWebViewWithOptions):
578
579 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
580
581         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
582         https://bugs.webkit.org/show_bug.cgi?id=196491
583
584         Reviewed by Lucas Forschler.
585
586         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
587
588 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
589
590         [ews-build] Configure buildbot try credentials in environment variables
591         https://bugs.webkit.org/show_bug.cgi?id=196501
592
593         Reviewed by Lucas Forschler.
594
595         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
596         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
597         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
598
599 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
600
601         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
602         https://bugs.webkit.org/show_bug.cgi?id=196496
603         <rdar://problem/49521634>
604
605         Reviewed by Chris Dumez.
606
607         Add new API tests (see WebKit ChangeLog for more detail).
608
609         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
610         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
611         (TEST):
612
613 2019-04-02  David Kilzer  <ddkilzer@apple.com>
614
615         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
616         <https://webkit.org/b/196499>
617
618         Reviewed by Alexey Proskuryakov.
619
620         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
621         ENABLE_ADDRESS_SANITIZER.
622
623 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
624
625         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
626         https://bugs.webkit.org/show_bug.cgi?id=182757
627
628         Reviewed by Don Olmstead.
629
630         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
631         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
632
633 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
634
635         run-api-tests: Upload test results
636         https://bugs.webkit.org/show_bug.cgi?id=196323
637         <rdar://problem/49356714>
638
639         Reviewed by Lucas Forschler.
640
641         * Scripts/webkitpy/api_tests/manager.py:
642         (Manager):
643         (Manager.run): Upload results to a results database.
644         * Scripts/webkitpy/api_tests/run_api_tests.py:
645         (parse_args): Add upload arguments.
646         * Scripts/webkitpy/port/base.py:
647         (Port):
648         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
649         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
650         with commits from any other associated repositories.
651         * Scripts/webkitpy/port/device.py:
652         (Device):
653         (Device.build_version): Access build_versoin of underlying platform device.
654         * Scripts/webkitpy/port/ios_simulator_unittest.py:
655         (IOSSimulatorTest):
656         (IOSSimulatorTest.test_configuration_for_upload):
657         * Scripts/webkitpy/port/device_port.py:
658         (DevicePort):
659         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
660         the same as the machine uploading results.
661         * Scripts/webkitpy/port/mac.py:
662         (MacPort):
663         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
664         * Scripts/webkitpy/port/mac_unittest.py:
665         (MacTest):
666         (MacTest.test_configuration_for_upload):
667         * Scripts/webkitpy/xcode/simulated_device.py:
668         (SimulatedDeviceManager._create_device_with_runtime):
669         (SimulatedDevice.__init__): Create simulated device with a build_version.
670         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
671         (test_existing_simulator):
672
673 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
674
675         Remove extra newline characters (Follow-up fix to r243707)
676
677         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
678
679 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
680
681         [ews-app] Use API_KEY to accept results data
682         https://bugs.webkit.org/show_bug.cgi?id=196461
683
684         Reviewed by Dewei Zhu.
685
686         * BuildSlaveSupport/ews-app/ews/views/results.py:
687         (Results.post): Validate EWS_API_KEY before accepting any data.
688         * BuildSlaveSupport/ews-build/events.py:
689         (Events.sendData): Send EWS_API_KEY if available along with event data.
690
691 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
692
693         Unable to copy and paste a PDF from Notes into Mail compose body
694         https://bugs.webkit.org/show_bug.cgi?id=196442
695         <rdar://problem/48573098>
696
697         Reviewed by Tim Horton.
698
699         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
700         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
701         to be specified on the item providers.
702
703         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
704         (TestWebKitAPI::mapItemForTesting):
705         (TestWebKitAPI::contactItemForTesting):
706
707 2019-04-01  Tim Horton  <timothy_horton@apple.com>
708
709         Make UIWKDocumentContext rects per-character instead of per-word
710         https://bugs.webkit.org/show_bug.cgi?id=196459
711
712         Reviewed by Wenson Hsieh.
713
714         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
715         (TEST):
716         Adjust test results due to switching to per-character rects.
717
718 2019-04-01  Chris Dumez  <cdumez@apple.com>
719
720         UIProcess crash when a prewarmed process is terminated
721         https://bugs.webkit.org/show_bug.cgi?id=196451
722         <rdar://problem/49245471>
723
724         Reviewed by Geoffrey Garen.
725
726         Add API test coverage.
727
728         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
729         (TEST):
730
731 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
732
733         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
734         https://bugs.webkit.org/show_bug.cgi?id=196449
735
736         Reviewed by Lucas Forschler.
737
738         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
739         (StatusBubble.get_os_details): Method to get OS and Xcode details.
740         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
741         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
742
743 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
744
745         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
746         https://bugs.webkit.org/show_bug.cgi?id=196444
747
748         Reviewed by Lucas Forschler.
749
750         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
751
752 2019-04-01  Alex Christensen  <achristensen@webkit.org>
753
754         Add SPI to canonicalize NSURLs with WTF::URL
755         https://bugs.webkit.org/show_bug.cgi?id=196415
756         <rdar://problem/44980271>
757
758         Reviewed by Darin Adler.
759
760         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
761         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
762         (TestWebKitAPI::TEST):
763
764 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
765
766         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
767         https://bugs.webkit.org/show_bug.cgi?id=196441
768
769         Reviewed by Carlos Garcia Campos.
770
771         Don't cache the wpe_view_backend object that might not exist yet at the
772         time of EventSenderProxy constructor invocation, but instead retrieve
773         that object whenever it's required for event dispatching. This should
774         avoid crashes in this constructor now that it's invoked before any
775         PlatformWindow has been set up (as changed in r243496).
776
777         * WebKitTestRunner/EventSenderProxy.h:
778         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
779         (WTR::viewBackend):
780         (WTR::EventSenderProxy::EventSenderProxy):
781         (WTR::EventSenderProxy::mouseDown):
782         (WTR::EventSenderProxy::mouseUp):
783         (WTR::EventSenderProxy::mouseMoveTo):
784         (WTR::EventSenderProxy::mouseScrollBy):
785         (WTR::EventSenderProxy::keyDown):
786         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
787
788 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
789
790         [Win][WebKit] MiniBrowser should support high DPI display
791         https://bugs.webkit.org/show_bug.cgi?id=196391
792
793         Reviewed by Alex Christensen.
794
795         * MiniBrowser/win/WebKitBrowserWindow.cpp:
796         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
797         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
798         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
799
800 2019-03-31  Sam Weinig  <weinig@apple.com>
801
802         Remove more i386 specific configurations
803         https://bugs.webkit.org/show_bug.cgi?id=196430
804
805         Reviewed by Alexey Proskuryakov.
806
807         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
808         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
809
810 2019-03-31  Andy Estes  <aestes@apple.com>
811
812         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
813         https://bugs.webkit.org/show_bug.cgi?id=196433
814         <rdar://problem/49293305>
815
816         Reviewed by Tim Horton.
817
818         Enhanced API test coverage to include all navigation response policy decisions in both
819         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
820
821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
822         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
823         (TestWebKitAPI::TEST):
824         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
825         (readFile):
826         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
827         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
828         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
829         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
830         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
831         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
832         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
833         (-[QuickLookDelegate _downloadDidStart:]):
834         (-[QuickLookDelegate _download:didReceiveResponse:]):
835         (-[QuickLookDelegate _download:didReceiveData:]):
836         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
837         (-[QuickLookDelegate _downloadDidFinish:]):
838         (-[QuickLookDelegate _download:didFailWithError:]):
839         (-[QuickLookDelegate _downloadDidCancel:]):
840         (-[QuickLookDelegate verifyDownload]):
841         (runTest):
842         (runTestDecideBeforeLoading):
843         (runTestDecideAfterLoading):
844         (TEST):
845         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
846         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
847         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
848         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
849         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
850         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
851         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
852         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
853         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
854         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
855         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
856         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
857         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
858         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
859
860 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
861
862         [CMake] add testdfg as target with build-jsc
863         https://bugs.webkit.org/show_bug.cgi?id=196393
864
865         Reviewed by Saam Barati.
866
867         Added testdfg as one of the targets to build when
868         using CMake.
869
870         * Scripts/build-jsc:
871
872 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
873
874         Delete WebMetal implementation in favor of WebGPU
875         https://bugs.webkit.org/show_bug.cgi?id=195418
876
877         Reviewed by Dean Jackson.
878
879         * DumpRenderTree/mac/DumpRenderTree.mm:
880         (enableExperimentalFeatures):
881         (resetWebPreferencesToConsistentValues):
882         * Scripts/webkitperl/FeatureList.pm:
883         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
885         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
886         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
887         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
888         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
889         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
890         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
891         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
892         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
893         (WTR::InjectedBundle::beginTesting):
894         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
895         (WTR::TestRunner::setWebMetalEnabled): Deleted.
896         * WebKitTestRunner/InjectedBundle/TestRunner.h:
897
898 2019-03-29  Chris Dumez  <cdumez@apple.com>
899
900         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
901         https://bugs.webkit.org/show_bug.cgi?id=196405
902         <rdar://problem/49428130>
903
904         Reviewed by Wenson Hsieh.
905
906         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
907         the popover presentation methods to be no-ops. Use this in the new test added in
908         r243523 so that we do not swizzle those methods for all tests. This is needed because
909         those WatchOS tests rely on the popover getting presented and interactive.
910
911         * WebKitTestRunner/TestController.cpp:
912         (WTR::updateTestOptionsFromTestHeader):
913         * WebKitTestRunner/TestController.h:
914         * WebKitTestRunner/TestOptions.h:
915         (WTR::TestOptions::hasSameInitializationOptions const):
916         * WebKitTestRunner/ios/TestControllerIOS.mm:
917         (WTR::TestController::platformInitialize):
918         (WTR::TestController::platformResetStateToConsistentValues):
919
920 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
921
922         [Curl] Add Server Trust Evaluation Support.
923         https://bugs.webkit.org/show_bug.cgi?id=191646
924
925         Reviewed by Fujii Hironori.
926
927         Implemented MiniBrowser UI for asking if user trusts the server.
928
929         * MiniBrowser/win/Common.cpp:
930         (askServerTrustEvaluation):
931         (replaceString):
932         * MiniBrowser/win/Common.h:
933         * MiniBrowser/win/MiniBrowserLib.rc:
934         * MiniBrowser/win/MiniBrowserLibResource.h:
935         * MiniBrowser/win/WebKitBrowserWindow.cpp:
936         (createPEMString):
937         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
938         (WebKitBrowserWindow::canTrustServerCertificate):
939         * MiniBrowser/win/WebKitBrowserWindow.h:
940
941 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
942
943         Implement ResizeObserver.
944         https://bugs.webkit.org/show_bug.cgi?id=157743
945
946         Reviewed by Simon Fraser.
947
948         Support resizeObserverEnabled webPreferences.
949
950         * DumpRenderTree/TestOptions.cpp:
951         (TestOptions::TestOptions):
952         * DumpRenderTree/TestOptions.h:
953         * DumpRenderTree/mac/DumpRenderTree.mm:
954         (setWebPreferencesForTestOptions):
955         * DumpRenderTree/win/DumpRenderTree.cpp:
956         (enableExperimentalFeatures):
957         * Scripts/webkitperl/FeatureList.pm:
958         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
959
960 2019-03-28  John Wilander  <wilander@apple.com>
961
962         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
963         https://bugs.webkit.org/show_bug.cgi?id=196281
964         <rdar://problem/48938748>
965
966         Reviewed by Alex Christensen.
967
968         This patch adds the function isStatisticsHasLocalStorage() to the
969         TestRunner. With it, the page can query the WebsiteDataStore in the
970         UI process to make sure that it sees LocalStorage.
971
972         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
973         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
974         (WTR::TestRunner::isStatisticsHasLocalStorage):
975         * WebKitTestRunner/InjectedBundle/TestRunner.h:
976         * WebKitTestRunner/TestController.cpp:
977         (WTR::TestController::isStatisticsHasLocalStorage):
978         * WebKitTestRunner/TestController.h:
979         * WebKitTestRunner/TestInvocation.cpp:
980         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
981
982 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
983
984         API::Data::createWithoutCopying should do a null check before calling CFRelease
985         https://bugs.webkit.org/show_bug.cgi?id=196276
986         <rdar://problem/48059859>
987
988         Reviewed by Alex Christensen.
989
990         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
991
992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
993         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
994         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
995         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
996         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
997         (TestWebKitAPI::TEST):
998
999 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1000
1001         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1002         https://bugs.webkit.org/show_bug.cgi?id=186276
1003
1004         Reviewed by Carlos Garcia Campos.
1005
1006         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1007         (webViewLoadChanged):
1008         (testWebResourceGetDataError):
1009         (testWebResourceGetDataEmpty):
1010         (beforeAll):
1011         (webViewloadChanged): Deleted.
1012
1013 2019-03-27  Andy Estes  <aestes@apple.com>
1014
1015         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1016         https://bugs.webkit.org/show_bug.cgi?id=196317
1017
1018         Reviewed by Dan Bernstein.
1019
1020         package-root copies built products into a staging directory using ditto(1), which does not
1021         follow symbolic links as it traverses a directory. Now that the files in
1022         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1023         itself, these become broken links when ditto'd into the staging directory.
1024
1025         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1026
1027         * Scripts/package-root:
1028
1029 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1030
1031         [ews-app] Update display text of Submit for ews analysis
1032         https://bugs.webkit.org/show_bug.cgi?id=196309
1033
1034         Reviewed by Dewei Zhu.
1035
1036         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1037
1038 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1039
1040         run-webkit-tests should check for leaks in WebKit processes
1041         <https://webkit.org/b/193772>
1042         <rdar://problem/46526680>
1043
1044         Reviewed by Ryosuke Niwa.
1045
1046         This works by doing the following:
1047         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1048           The list of child processes are returned one per line:
1049           process.name: pid
1050         - Run the "#LIST CHILD PROCESSES" command just before the
1051           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1052           processes on the ServerProcess object.
1053         - When the `--leaks` switch is handled, run check_for_leaks() on
1054           each child process after the main test harness.
1055
1056         * DumpRenderTree/mac/DumpRenderTree.mm:
1057         (handleControlCommand):
1058         - Use strncmp() instead of strcmp().
1059         - Add support for handling "#LIST CHILD PROCESSES" command.
1060
1061         * Scripts/webkitpy/port/base.py:
1062         (Port.check_for_leaks):
1063         * Scripts/webkitpy/port/darwin.py:
1064         (DarwinPort.check_for_leaks):
1065         - Rename redundant 'process_pid' argument to 'process_id'.
1066
1067         * Scripts/webkitpy/port/driver.py:
1068         (Driver.do_post_tests_work):
1069         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1070           longer the only command this sends to WebKitTestRunner.
1071         - If the `--leaks` switch is present, send the
1072           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1073           result using Port.set_webkit_processes().
1074         (Driver._parse_child_processes_output):
1075         - Add helper method to parse list of child process names and
1076           process IDs returned from WebKitTestRunner.
1077
1078         * Scripts/webkitpy/port/ios_device.py:
1079         (IOSDevicePort.check_for_leaks):
1080         - Rename redundant 'process_pid' argument to 'process_id'.
1081
1082         * Scripts/webkitpy/port/leakdetector.py:
1083         (LeakDetector._parse_leaks_output):
1084         - Return early if there is no leaks_output.
1085         (LeakDetector.check_for_leaks):
1086         - Rename redundant 'process_pid' argument to 'process_id'.
1087
1088         * Scripts/webkitpy/port/server_process.py:
1089         (ServerProcess.__init__):
1090         (ServerProcess.child_processes):
1091         (ServerProcess.set_child_processes):
1092         - Add instance variable to Port to store list of child process
1093           names and process IDs returned from WebKitTestRunner.
1094         (ServerProcess._start):
1095         - Clear self._child_processes.
1096         (ServerProcess.stop):
1097         - If self._child_processes is set, call
1098           self._port.check_for_leaks() for each child process.
1099
1100         * Scripts/webkitpy/port/server_process_unittest.py:
1101         (TrivialMockPort.check_for_leaks):
1102         - Rename redundant 'process_pid' argument to 'process_id'.
1103
1104         * Scripts/webkitpy/port/simulator_process.py:
1105         (SimulatorProcess.stop):
1106         - If self._child_processes is set, call
1107           self._port.check_for_leaks() for each child process.
1108
1109         * Scripts/webkitpy/port/watch_device.py:
1110         (WatchDevicePort.check_for_leaks):
1111         - Rename redundant 'process_pid' argument to 'process_id'.
1112
1113         * WebKitTestRunner/TestController.cpp:
1114         (WTR::TestController::dumpResponse):
1115         - Extract method from findAndDumpWorldLeaks() so that it may be
1116           reused by findAndDumpWebKitProcessIdentifiers().
1117         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1118         - Add method to output process name and process ID of both the
1119           WebContent and Networking processes.
1120         (WTR::TestController::findAndDumpWorldLeaks):
1121         - Fix missing newline in output when there were no abandoned
1122           documents.
1123         - Call dumpResponse() for extracted code.
1124         (WTR::TestController::handleControlCommand):
1125         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1126         - Use strncmp() instead of strcmp().
1127         - Call findAndDumpWebKitProcessIdentifiers() when
1128           "#LIST CHILD PROCESSES" command is sent.
1129         * WebKitTestRunner/TestController.h:
1130         (WTR::TestController::dumpResponse):
1131         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1132         - Declare methods.
1133
1134 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1135
1136         Unreviewed. Add GLib API test cases after r243434.
1137
1138         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1139         (testWebViewActiveURI):
1140         (serverCallback):
1141         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1142         (sendRequestCallback):
1143
1144 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1145
1146         Geolocation request not complete when watch request was started in a different web process
1147         https://bugs.webkit.org/show_bug.cgi?id=195996
1148
1149         Reviewed by Alex Christensen.
1150
1151         Add a test case.
1152
1153         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1154         (TestWebKitAPI::runJavaScriptAlert):
1155         (TestWebKitAPI::TEST):
1156
1157 2019-03-26  Keith Rollin  <krollin@apple.com>
1158
1159         Update the way generate-xcfilelists returns strings from functions
1160         https://bugs.webkit.org/show_bug.cgi?id=195975
1161         <rdar://problem/49040807>
1162
1163         Reviewed by Dean Jackson.
1164
1165         There are places where generate-xcfilelists executes assignments with
1166         statements like:
1167
1168             FOO=$(some_function)
1169
1170         where "some_function" return a string by echoing it. E.g.
1171
1172             some_function()
1173             {
1174                 echo "Hello, World"
1175             }
1176
1177         This is a common idiom, but it has a problem if "some_function" needs
1178         to call "exit" in an attempt to halt the entire script right then and
1179         there. Since "some_function" is called inside of $(), it's being
1180         executed in a sub-shell. Calling exit in that sub-shell simply exits
1181         that shell; it doesn't not exit the outer shell in which the main part
1182         of the script is still running. As such, the main script keeps
1183         executing when the intent was for the script to halt.
1184
1185         The solution to this is to use a different idiom for returning
1186         strings. The one we now is to pass in the name of the variable to
1187         receive the string result:
1188
1189             some_function()
1190             {
1191                 variable_name=$1
1192                 eval $variable_name ="Hello, World"
1193             }
1194
1195         The call site now looks like
1196
1197             some_function FOO
1198
1199         Because there's no invocation of a sub-shell, some_function can now
1200         call "exit" if it wants to, and the entire script will exit at that
1201         point.
1202
1203         * Scripts/generate-xcfilelists:
1204
1205 2019-03-26  Chris Dumez  <cdumez@apple.com>
1206
1207         Add basic layout test coverage for File Picker on iOS
1208         https://bugs.webkit.org/show_bug.cgi?id=196265
1209
1210         Reviewed by Wenson Hsieh.
1211
1212         Add layout test infrastructure to test the file picker on iOS.
1213
1214         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1215         (WTR::UIScriptController::dismissFilePicker):
1216         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1217         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1218         (WTR::UIScriptController::dismissFilePicker):
1219         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1220         * WebKitTestRunner/TestController.cpp:
1221         (WTR::TestController::createWebViewWithOptions):
1222         (WTR::updateTestOptionsFromTestHeader):
1223         * WebKitTestRunner/TestOptions.h:
1224         (WTR::TestOptions::hasSameInitializationOptions const):
1225         * WebKitTestRunner/ios/TestControllerIOS.mm:
1226         (overridePresentViewController):
1227         (WTR::TestController::platformInitialize):
1228         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1229         (WTR::UIScriptController::dismissFilePicker):
1230
1231 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1232
1233         Implement async paste method on UIWKInteractionViewProtocol
1234         https://bugs.webkit.org/show_bug.cgi?id=196267
1235         <rdar://problem/49236346>
1236
1237         Reviewed by Tim Horton.
1238
1239         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1240         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1241         are now a part of all iOS 12 internal SDKs.
1242
1243         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1244
1245         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1246         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1247
1248         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1249         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1250         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1251         * TestWebKitAPI/ios/UIKitSPI.h:
1252
1253 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1254
1255         [ews-build] Use PostgreSQL for ews.webkit.org database
1256         https://bugs.webkit.org/show_bug.cgi?id=196270
1257
1258         Reviewed by Lucas Forschler.
1259
1260         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1261
1262 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1263
1264         [ews] Reset simctl states on reboot
1265         https://bugs.webkit.org/show_bug.cgi?id=196260
1266
1267         Rubber-stamped by Aakash Jain.
1268
1269         * EWSTools/start-queue-mac.sh:
1270
1271 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1272
1273         [ews-build] Use PostgreSQL for ews-build database
1274         https://bugs.webkit.org/show_bug.cgi?id=196229
1275
1276         Reviewed by Lucas Forschler.
1277
1278         * BuildSlaveSupport/ews-build/master.cfg:
1279
1280 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1281
1282         [ews-build] Get master_hostname dynamically in master.cfg
1283         https://bugs.webkit.org/show_bug.cgi?id=196255
1284
1285         Reviewed by Lucas Forschler.
1286
1287         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1288         send events data in test mode.
1289
1290 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1291
1292         [ews-app] Set db_constraint to False for Foreign Keys
1293         https://bugs.webkit.org/show_bug.cgi?id=196252
1294
1295         Reviewed by Lucas Forschler.
1296
1297         * BuildSlaveSupport/ews-app/ews/models/build.py:
1298         * BuildSlaveSupport/ews-app/ews/models/step.py:
1299
1300 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1301
1302         [ews-build] is_test_mode_enabled should default to True
1303         https://bugs.webkit.org/show_bug.cgi?id=196248
1304
1305         Reviewed by Lucas Forschler.
1306
1307         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1308
1309 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1310
1311         [ews-app] Add webkitperl to ENABLED_QUEUES
1312         https://bugs.webkit.org/show_bug.cgi?id=196253
1313
1314         Reviewed by Lucas Forschler.
1315
1316         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1317
1318 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1319
1320         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1321         https://bugs.webkit.org/show_bug.cgi?id=196211
1322         rdar://problem/49110552
1323
1324         Reviewed by Tim Horton.
1325
1326         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1327         Make sure that EventSenderProxy always exists when running tests. We used to create
1328         it when resetting before the first test, which is a bit too late.
1329
1330         * WebKitTestRunner/TestController.h:
1331         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1332         (WTR::TestController::platformCreateWebView):
1333         (WTR::TestController::platformCreateOtherPage):
1334         (WTR::TestController::finishCreatingPlatformWebView):
1335         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1336         (WTR::PlatformWebView::PlatformWebView):
1337         Moved some code that made NSWindow use NSEvent during web view creation. We may
1338         need to move more if some other case us found, but this is enough for now.
1339
1340 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1341
1342         Unreviewed. Fix typo in GLib geolocation API after r243285.
1343
1344         gelocation -> geolocation.
1345
1346         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1347         (testGeolocationManagerWatchPosition):
1348
1349 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1350
1351         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1352         https://bugs.webkit.org/show_bug.cgi?id=196213
1353
1354         Reviewed by Geoff Garen.
1355
1356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1357         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1358         (credentialWithIdentityAndKeychainPath):
1359         (-[ChallengeDelegate webView:didFinishNavigation:]):
1360         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1361         (TestWebKitAPI::TEST):
1362
1363 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1364
1365         Expected shouldn't assume its contained types are copyable
1366         https://bugs.webkit.org/show_bug.cgi?id=195986
1367
1368         Reviewed by JF Bastien.
1369
1370         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1371         (TestWebKitAPI::NonCopyable::operator== const):
1372         (TestWebKitAPI::NonCopyable::operator!= const):
1373         (TestWebKitAPI::TEST):
1374
1375 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1376
1377         Remove some now-unnecessary dynamic class lookup
1378         https://bugs.webkit.org/show_bug.cgi?id=196237
1379
1380         Reviewed by Simon Fraser.
1381
1382         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1383         (makeRequest):
1384         (TEST):
1385
1386 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1387
1388         Unreviewed, rolling out r243450.
1389
1390         AppleWin and WinCairo port builds get broken.
1391
1392         Reverted changeset:
1393
1394         "Add test for fix of #196095"
1395         https://bugs.webkit.org/show_bug.cgi?id=196097
1396         https://trac.webkit.org/changeset/243450
1397
1398 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1399
1400         Unreviewed, rolling out r243465.
1401         https://bugs.webkit.org/show_bug.cgi?id=196226
1402
1403         the test doesn't build (Requested by thorton on #webkit).
1404
1405         Reverted changeset:
1406
1407         "Do not terminate the NetworkProcess if a third party
1408         application sends a NSCredential with a SecIdentityRef"
1409         https://bugs.webkit.org/show_bug.cgi?id=196213
1410         https://trac.webkit.org/changeset/243465
1411
1412 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1413
1414         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1415         https://bugs.webkit.org/show_bug.cgi?id=196213
1416
1417         Reviewed by Geoff Garen.
1418
1419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1420         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1421         (credentialWithIdentityAndKeychainPath):
1422         (-[ChallengeDelegate webView:didFinishNavigation:]):
1423         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1424         (TestWebKitAPI::TEST):
1425
1426 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1427
1428         [ews-build] Gracefully handle missing patch_id in events
1429         https://bugs.webkit.org/show_bug.cgi?id=196216
1430
1431         Reviewed by Lucas Forschler.
1432
1433         * BuildSlaveSupport/ews-build/events.py:
1434
1435 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1436
1437         [ews-build] use lz4 compression for improving buildbot performance
1438         https://bugs.webkit.org/show_bug.cgi?id=196155
1439
1440         Reviewed by Lucas Forschler.
1441
1442         * BuildSlaveSupport/ews-build/master.cfg:
1443
1444 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1445
1446         Pull some API testing helper methods out of TestWKWebView
1447         https://bugs.webkit.org/show_bug.cgi?id=196212
1448
1449         Reviewed by Tim Horton.
1450
1451         Refactor some more API testing utility methods, so that they can be used in
1452         tests that do not use TestWKWebView.
1453
1454         * TestWebKitAPI/cocoa/TestWKWebView.h:
1455         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1456         (-[WKWebView loadTestPageNamed:]):
1457         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1458         (-[WKWebView synchronouslyLoadHTMLString:]):
1459         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1460         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1461         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1462         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1463         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1464
1465 2019-03-25  Jer Noble  <jer.noble@apple.com>
1466
1467         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1468         https://bugs.webkit.org/show_bug.cgi?id=196097
1469
1470         Reviewed by Eric Carlson.
1471
1472         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1473
1474         * DumpRenderTree/mac/DumpRenderTree.mm:
1475         (resetWebPreferencesToConsistentValues):
1476         * WebKitTestRunner/TestController.cpp:
1477         (WTR::TestController::resetPreferencesToConsistentValues):
1478
1479 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1480
1481         Pull IPadUserInterfaceSwizzler out into a separate header file
1482         https://bugs.webkit.org/show_bug.cgi?id=196193
1483
1484         Reviewed by Anders Carlsson.
1485
1486         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1487         be used in other API tests.
1488
1489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1490         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1491         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1492         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1493         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1494         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1495         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1496
1497 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1498
1499         Remove NavigatorContentUtils in WebCore/Modules
1500         https://bugs.webkit.org/show_bug.cgi?id=196070
1501
1502         Reviewed by Alex Christensen.
1503
1504         NavigatorContentUtils was to support the custom scheme spec [1].
1505         However, in WebKit side, no port has supported the feature in
1506         WebKit layer after EFL port was removed. So there has been the
1507         only IDL implementation of the NavigatorContentUtils in WebCore.
1508         So we don't need to keep the implementation in WebCore anymore.
1509
1510         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1511
1512         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1513
1514 2019-03-24  Andy Estes  <aestes@apple.com>
1515
1516         [watchOS] Remove unused Proximity Networking code
1517         https://bugs.webkit.org/show_bug.cgi?id=196188
1518
1519         Reviewed by Tim Horton.
1520
1521         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1522         (TEST):
1523
1524 2019-03-23  Keith Miller  <keith_miller@apple.com>
1525
1526         Refactor clz/ctz and fix getLSBSet.
1527         https://bugs.webkit.org/show_bug.cgi?id=196162
1528
1529         Reviewed by Saam Barati.
1530
1531         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1532
1533         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1534         (TestWebKitAPI::TEST):
1535
1536 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1537
1538         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1539         https://bugs.webkit.org/show_bug.cgi?id=196143
1540
1541         Reviewed by Michael Catanzaro.
1542
1543         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1544         directories.
1545
1546         * Scripts/webkitpy/style/checkers/cpp.py:
1547         (check_identifier_name_in_declaration):
1548         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1549         (WebKitStyleTest.test_names):
1550
1551 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1552
1553         [Flatpak] Manifest expanding fails for qt WPE extension
1554         https://bugs.webkit.org/show_bug.cgi?id=196148
1555
1556         Reviewed by Alex Christensen.
1557
1558         * flatpak/flatpakutils.py:
1559         (expand_submodules_recurse): The last recurse manifest expand
1560         iteration might lead to a single module so take it into account
1561         and don't try to recurse further.
1562
1563 2019-03-22  Chris Dumez  <cdumez@apple.com>
1564
1565         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1566         https://bugs.webkit.org/show_bug.cgi?id=195348
1567         <rdar://problem/48622090>
1568
1569         Reviewed by Alex Christensen.
1570
1571         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1572         to NO when test.options().shouldIgnoreMetaViewport is false.
1573
1574         * WebKitTestRunner/ios/TestControllerIOS.mm:
1575         (WTR::TestController::platformConfigureViewForTest):
1576
1577 2019-03-22  Chris Dumez  <cdumez@apple.com>
1578
1579         Prewarmed processes should be usable with any website data store
1580         https://bugs.webkit.org/show_bug.cgi?id=196104
1581
1582         Reviewed by Alex Christensen.
1583
1584         Add API test coverage.
1585
1586         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1587         (runInitialWarmedProcessUsedTest):
1588         (TEST):
1589
1590 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1591
1592         Back out local changes to Alex's Subversion working directory
1593
1594         They were accidentally committed.
1595
1596         * Scripts/webkitpy/common/system/abstractexecutive.py:
1597         (AbstractExecutive.wait_newest):
1598         * Scripts/webkitpy/common/system/executive.py:
1599         (Executive.running_pids):
1600         * Scripts/webkitpy/common/system/executive_mock.py:
1601         (MockExecutive.running_pids):
1602         * Scripts/webkitpy/common/system/executive_unittest.py:
1603         (ExecutiveTest.serial_test_running_pids):
1604         * Scripts/webkitpy/port/darwin.py:
1605         (DarwinPort.check_for_leaks):
1606         * Scripts/webkitpy/port/leakdetector.py:
1607         (LeakDetector.check_for_leaks):
1608         - This was the hack attached to Bug 193772.
1609
1610         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1611         (+[WebKitTestRunnerEvent mouseLocation]):
1612         - This works around a crash on an internal build.
1613
1614 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1615
1616         Fix the build after r243354
1617         https://bugs.webkit.org/show_bug.cgi?id=196138
1618         <rdar://problem/49145951>
1619
1620         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1621         (TEST):
1622         * TestWebKitAPI/ios/UIKitSPI.h:
1623
1624 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1625
1626         Adopt UIWKDocumentContext
1627         https://bugs.webkit.org/show_bug.cgi?id=196040
1628         <rdar://problem/48642440>
1629
1630         Reviewed by Ryosuke Niwa.
1631
1632         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1633         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1634         (makeRequest):
1635         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1636         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1637         (applyStyle):
1638         (TEST):
1639         Add tests for UIWKDocumentContext.
1640
1641         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1642         (TEST):
1643         (recursiveFindWKContentView): Deleted.
1644         * TestWebKitAPI/cocoa/TestWKWebView.h:
1645         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1646         (recursiveFindWKContentView):
1647         (-[TestWKWebView wkContentView]):
1648         * TestWebKitAPI/ios/UIKitSPI.h:
1649         Share the WKContentView finding code between tests.
1650
1651 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1652
1653         [iOS WK2] Turn on async overflow scrolling by default
1654         https://bugs.webkit.org/show_bug.cgi?id=196011
1655         rdar://problem/48453859
1656
1657         Reviewed by Antti Koivisto.
1658         
1659         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1660         since so many basic layout tests have different results when compositing is triggered for
1661         overflow.
1662         
1663         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1664
1665         * WebKitTestRunner/TestController.cpp:
1666         (WTR::TestController::resetPreferencesToConsistentValues):
1667
1668 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1669
1670         [ews-build] Retry API test in case of failures
1671         https://bugs.webkit.org/show_bug.cgi?id=196004
1672
1673         Reviewed by Lucas Forschler.
1674
1675         * BuildSlaveSupport/ews-build/steps.py:
1676         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1677         (CompileWebKitToT.doStepIf): Ditto.
1678         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1679         (ReRunAPITests): Re-run API tests.
1680         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1681         (RunAPITestsWithoutPatch): Run API tests without patch.
1682         (RunAPITestsWithoutPatch.doStepIf):
1683         (RunAPITestsWithoutPatch.hideStepIf):
1684         (RunAPITestsWithoutPatch.evaluateCommand):
1685         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1686         (AnalyzeAPITestsResults.start):
1687         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1688         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1689         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1690         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1691
1692 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1693
1694         [ews-build] Update queues configurations
1695         https://bugs.webkit.org/show_bug.cgi?id=196074
1696
1697         Reviewed by Dewei Zhu.
1698
1699         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1700         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1701
1702 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1703
1704         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1705         https://bugs.webkit.org/show_bug.cgi?id=195680
1706         <rdar://problem/48903534>
1707
1708         Unreviewed infrastructure fix.
1709
1710         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1711         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1712
1713 2019-03-21  Andy Estes  <aestes@apple.com>
1714
1715         [iOS] Apple Pay should be available in documents with no user agent scripts
1716         https://bugs.webkit.org/show_bug.cgi?id=196061
1717         <rdar://problem/48649391>
1718
1719         Reviewed by Brady Eidson.
1720
1721         Added API tests and related infrastructure.
1722
1723         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1724         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1725         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1726         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1727         (TestWebKitAPI::TEST):
1728         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1729         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1730         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1731         * TestWebKitAPI/cocoa/TestProtocol.mm:
1732         (-[TestProtocol startLoading]):
1733         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1734         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1735         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1736         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1737
1738 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1739
1740         REGRESSSION (r243297): webkitpy tests broken
1741         https://bugs.webkit.org/show_bug.cgi?id=196108
1742
1743         Reviewed by Aakash Jain.
1744
1745         r243297 updated contributors.json, which broke a few unit tests.
1746
1747         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1748         (IRCCommandTest.test_whois):
1749         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1750
1751 2019-03-21  Chris Dumez  <cdumez@apple.com>
1752
1753         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1754         https://bugs.webkit.org/show_bug.cgi?id=196041
1755         <rdar://problem/49083230>
1756
1757         Reviewed by Alex Christensen.
1758
1759         Add API test coverage.
1760
1761         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1762         (TEST):
1763
1764 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1765
1766         Add SPI to inform applications of WKContentRuleList actions
1767         https://bugs.webkit.org/show_bug.cgi?id=195965
1768         <rdar://problem/42664365>
1769
1770         Reviewed by Geoff Garen.
1771
1772         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1773         (TestWebKitAPI::allActionsForResourceLoad):
1774         (TestWebKitAPI::testRequest):
1775         (TestWebKitAPI::TEST_F):
1776         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1777         (Notification::description):
1778         (Notification::operator== const):
1779         (toVector):
1780         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1781         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1782         (makeContentRuleList):
1783         (TEST):
1784         (makeWarnContentRuleList): Deleted.
1785
1786 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1787
1788         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1789         https://bugs.webkit.org/show_bug.cgi?id=196088
1790
1791         Reviewed by Brian Burg.
1792
1793         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1794         Support checks when only one platform is specified. Also deprecate macosx() and
1795         force the use of macos() instead.
1796
1797         * Scripts/webkitpy/style/checkers/cpp.py:
1798         (check_min_versions_of_wk_api_available):
1799         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1800         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1801
1802 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1803
1804         Update status inactive committers' status to 'contributor'.
1805
1806         * Scripts/webkitpy/common/config/contributors.json:
1807
1808 2019-03-21  Xan Lopez  <xan@igalia.com>
1809
1810         [JSC][x86] Drop support for x87 floating point
1811         https://bugs.webkit.org/show_bug.cgi?id=194853
1812
1813         Reviewed by Don Olmstead.
1814
1815         Force SSE2 on x86/32bit builds.
1816
1817         * Scripts/webkitdirs.pm:
1818         (generateBuildSystemFromCMakeProject):
1819
1820 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1821
1822         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1823         https://bugs.webkit.org/show_bug.cgi?id=196073
1824
1825         Reviewed by Michael Catanzaro.
1826
1827         Add test cases to check functions and constructors with no arguments but receiving user data.
1828
1829         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1830         (checkUserData):
1831         (testJSCFunction):
1832         (fooCreateWithUserData):
1833         (testJSCClass):
1834
1835 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1836
1837         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1838
1839         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1840
1841         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1842
1843 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1844
1845         [GTK][WPE] Add API to provide geolocation information
1846         https://bugs.webkit.org/show_bug.cgi?id=195940
1847
1848         Reviewed by Michael Catanzaro.
1849
1850         Add a new test to check the new API.
1851
1852         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1853         (testGeolocationManagerCurrentPosition):
1854         (testGeolocationManagerWatchPosition):
1855         (beforeAll):
1856         (afterAll):
1857         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1858         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1859         (beforeAll): Ditto.
1860         * TestWebKitAPI/glib/CMakeLists.txt:
1861
1862 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1863
1864         [GLib] Returning G_TYPE_OBJECT from a method does not work
1865         https://bugs.webkit.org/show_bug.cgi?id=195574
1866
1867         Reviewed by Michael Catanzaro.
1868
1869         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1870
1871         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1872         (getGFile):
1873         (getParent):
1874         (createGString):
1875         (getGString):
1876         (getGStringCopyWillRaise):
1877         (getGStringCopy):
1878         (getGStringStr):
1879         (getGStringLen):
1880         (freeGString):
1881         (testJSCClass):
1882
1883 2019-03-20  Saam Barati  <sbarati@apple.com>
1884
1885         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1886         https://bugs.webkit.org/show_bug.cgi?id=195721
1887
1888         Reviewed by Filip Pizlo.
1889
1890         * Scripts/run-javascriptcore-tests:
1891
1892 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1893
1894         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1895         https://bugs.webkit.org/show_bug.cgi?id=196049
1896
1897         Reviewed by Tim Horton.
1898
1899         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1900         overflow scrolling in general, so rename it.
1901
1902         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1903
1904 2019-03-20  Daniel Bates  <dabates@apple.com>
1905
1906         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1907         https://bugs.webkit.org/show_bug.cgi?id=196031
1908         <rdar://problem/49078172>
1909
1910         Reviewed by Tim Horton.
1911
1912         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1913         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1914         same code path used when the Done button is pressed to dismiss the <select> picker.
1915
1916         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1917         (TestWebKitAPI::TEST):
1918
1919 2019-03-20  Chris Dumez  <cdumez@apple.com>
1920
1921         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1922         https://bugs.webkit.org/show_bug.cgi?id=196029
1923         <rdar://problem/48954651>
1924
1925         Reviewed by Tim Horton.
1926
1927         Add API test coverage.
1928
1929         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1930
1931 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1932
1933         [ews-build] Improve failure summary string for ApplyPatch step
1934         https://bugs.webkit.org/show_bug.cgi?id=195995
1935
1936         Reviewed by Alexey Proskuryakov.
1937
1938         * BuildSlaveSupport/ews-build/steps.py:
1939         (ApplyPatch.getResultSummary): Override getResultSummary.
1940
1941 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1942
1943         AX: Implement support for new meter ARIA role
1944         https://bugs.webkit.org/show_bug.cgi?id=195966
1945
1946         Reviewed by Chris Fleizach.
1947
1948         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1949         to AXLevelIndicator.
1950
1951         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1952
1953 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1954
1955         [WebAuthN] Implement FIDO AppID extension
1956         https://bugs.webkit.org/show_bug.cgi?id=143491
1957         <rdar://problem/48298273>
1958
1959         Reviewed by Brent Fulgham.
1960
1961         Add a test that covers the new flag of convertToU2fSignCommand.
1962
1963         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1964         (TestWebKitAPI::TEST):
1965         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1966         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1967         (TestWebKitAPI::TEST):
1968
1969 2019-03-19  Keith Rollin  <krollin@apple.com>
1970
1971         Add support for more platforms to generate-xcfilelists
1972         https://bugs.webkit.org/show_bug.cgi?id=195977
1973
1974         Reviewed by Alexey Proskuryakov.
1975
1976         generate-xcfilelists incorrectly complains when involved with building
1977         WebKit for iphonesimulator:
1978
1979             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1980             …
1981             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1982
1983         Address this by teaching generate-xcfilelists about more platforms.
1984
1985         * Scripts/generate-xcfilelists:
1986
1987 2019-03-19  John Wilander  <wilander@apple.com>
1988
1989         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1990         https://bugs.webkit.org/show_bug.cgi?id=195923
1991         <rdar://problem/49001272>
1992
1993         Reviewed by Alex Christensen.
1994
1995         This patch does the following to the TestRunner:
1996         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1997         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1998         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1999
2000         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2001         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2002         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2003         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2004         * WebKitTestRunner/TestController.cpp:
2005         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2006         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2007         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2008         * WebKitTestRunner/TestController.h:
2009         * WebKitTestRunner/TestInvocation.cpp:
2010         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2011
2012 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2013
2014         [CMake] Support more clang and gcc sanitizers
2015         https://bugs.webkit.org/show_bug.cgi?id=195956
2016
2017         Reviewed by Michael Catanzaro.
2018
2019         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2020
2021 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2022
2023         [ews-build] Improve summary for PrintConfiguration step
2024         https://bugs.webkit.org/show_bug.cgi?id=195945
2025
2026         Reviewed by Lucas Forschler.
2027
2028         * BuildSlaveSupport/ews-build/steps.py:
2029         (PrintConfiguration.getResultSummary): Override getResultSummary.
2030
2031 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2032
2033         [ews-build] Improve summary for CheckOutSource step
2034         https://bugs.webkit.org/show_bug.cgi?id=195963
2035
2036         Reviewed by Lucas Forschler.
2037
2038         * BuildSlaveSupport/ews-build/steps.py:
2039         (CheckOutSource.getResultSummary):
2040
2041 2019-03-19  Daniel Bates  <dabates@apple.com>
2042
2043         [iOS] Focus not preserved when switching between tabs
2044         https://bugs.webkit.org/show_bug.cgi?id=195820
2045         <rdar://problem/43614450>
2046
2047         Reviewed by Brent Fulgham.
2048
2049         Add tests to ensure that we restore focus when resigning and becoming first responder.
2050
2051         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2052         (TestWebKitAPI::TEST):
2053
2054 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2055
2056         Make WTFLogChannelState and WTFLogLevel enum classes
2057         https://bugs.webkit.org/show_bug.cgi?id=195904
2058
2059         Reviewed by Eric Carlson.
2060
2061         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2062         (TestWebKitAPI::TEST_F):
2063
2064 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2065
2066         [GStreamer][EME] Backported mssdemux protection data crash fix
2067         https://bugs.webkit.org/show_bug.cgi?id=195918
2068
2069         Reviewed by Philippe Normand.
2070
2071         * gstreamer/jhbuild.modules:
2072         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2073
2074 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2075
2076         Unreviewed, rolling out r243132.
2077
2078         Broke GTK build
2079
2080         Reverted changeset:
2081
2082         "Make WTFLogChannelState and WTFLogLevel enum classes"
2083         https://bugs.webkit.org/show_bug.cgi?id=195904
2084         https://trac.webkit.org/changeset/243132
2085
2086 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2087
2088         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2089
2090         * Scripts/webkitdirs.pm:
2091         (builtDylibPathForName): Adjust the shared library name that's changed
2092         with the API version bump in r243073.
2093
2094 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2095
2096         Make WTFLogChannelState and WTFLogLevel enum classes
2097         https://bugs.webkit.org/show_bug.cgi?id=195904
2098
2099         Reviewed by Eric Carlson.
2100
2101         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2102         (TestWebKitAPI::TEST_F):
2103
2104 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2105
2106         Disable flaky test added in r2431100
2107         https://webkit.org/b/195785
2108
2109         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2110         (TestWebKitAPI::TEST):
2111         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2112
2113 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2114
2115         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2116         https://bugs.webkit.org/show_bug.cgi?id=195916
2117
2118         Reviewed by Tim Horton.
2119
2120         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2121         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2122
2123 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2124
2125         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2126
2127         * Scripts/webkitpy/common/config/contributors.json:
2128
2129 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2130
2131         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2132         https://bugs.webkit.org/show_bug.cgi?id=195785
2133
2134         Reviewed by Geoffrey Garen.
2135
2136         * TestWebKitAPI/TCPServer.cpp: Added.
2137         (TestWebKitAPI::TCPServer::TCPServer):
2138         (TestWebKitAPI::TCPServer::~TCPServer):
2139         (TestWebKitAPI::TCPServer::socketBindListen):
2140         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2141         * TestWebKitAPI/TCPServer.h: Added.
2142         (TestWebKitAPI::TCPServer::port const):
2143         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2144         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2145         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2146         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2147         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2148         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2149         (TestWebKitAPI::respondSlowly):
2150         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2151         (TestWebKitAPI::downloadAtRate):
2152         (TestWebKitAPI::TEST):
2153
2154 2019-03-18  Saam Barati  <sbarati@apple.com>
2155
2156         Add a plan file for JetStream 2
2157         https://bugs.webkit.org/show_bug.cgi?id=190734
2158
2159         Reviewed by Mark Lam.
2160
2161         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2162
2163 2019-03-18  Chris Dumez  <cdumez@apple.com>
2164
2165         Delay WebProcess launch until a load is triggered in a Web view
2166         https://bugs.webkit.org/show_bug.cgi?id=195758
2167         <rdar://problem/48126013>
2168
2169         Reviewed by Geoff Garen.
2170
2171         Add API test coverage. Also update some existing API tests to not expect
2172         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2173
2174         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2175         (TestWebKitAPI::TEST):
2176         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2177         (TestWebKitAPI::TEST):
2178         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2179         (TEST):
2180         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2181         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2182         (TEST):
2183         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2184         (TEST):
2185         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2186
2187 2019-03-18  Xan Lopez  <xan@igalia.com>
2188
2189         [CMake] Prevent potential warning when determining $architecture
2190         https://bugs.webkit.org/show_bug.cgi?id=195891
2191
2192         Reviewed by Michael Catanzaro.
2193
2194         It's possible for generateBuildSystemForCMakeProject to be called
2195         before determineArchitecture() is ever called. This will make the
2196         first eq check with $architecture to be bogus (and print a
2197         warning). Change that to an eq check with architecture(), which
2198         implicitly calls determineArchitecture() if needed, and change all
2199         the other similar cases in the method in the same way to prevent
2200         future bugs like this one.
2201
2202         * Scripts/webkitdirs.pm:
2203         (generateBuildSystemFromCMakeProject):
2204
2205 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2206
2207         [WPE] Tarballs generated with “make dist” cannot build documentation
2208         https://bugs.webkit.org/show_bug.cgi?id=195885
2209
2210         Reviewed by Carlos Garcia Campos.
2211
2212         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2213
2214 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2215
2216         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2217         https://bugs.webkit.org/show_bug.cgi?id=195883
2218
2219         Reviewed by Carlos Garcia Campos.
2220
2221         * gtkdoc/gtkdoc.py:
2222         (GTKDoc._run_command): When commands fail to run, include the full command line for
2223         the program invocation and the output it has generated on the standard error stream.
2224
2225 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2226
2227         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2228         https://bugs.webkit.org/show_bug.cgi?id=195786
2229
2230         Reviewed by Philippe Normand.
2231
2232         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2233         * wpe/jhbuild.modules: Ditto.
2234
2235 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2236
2237         [ews-build] Don't run clean builds on EWS builders
2238         https://bugs.webkit.org/show_bug.cgi?id=195851
2239
2240         Reviewed by Geoffrey Garen.
2241
2242         * BuildSlaveSupport/ews-build/factories.py:
2243
2244 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2245
2246         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2247         https://bugs.webkit.org/show_bug.cgi?id=195849
2248
2249         Reviewed by Chris Dumez.
2250
2251         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2252
2253         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2254         (runWebsiteDataStoreCustomPaths):
2255
2256 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2257
2258         webkitpy: Upload test results
2259         https://bugs.webkit.org/show_bug.cgi?id=195755
2260         <rdar://problem/48896182>
2261
2262         Reviewed by Aakash Jain.
2263
2264         Establish a new format for uploading results that is not tied to layout tests, apply
2265         that format to webkitpy tests.
2266
2267         * Scripts/webkitpy/common/checkout/scm/git.py:
2268         (Git.native_branch): Return what branch the current checkout is on.
2269         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2270         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2271         * Scripts/webkitpy/common/checkout/scm/svn.py:
2272         (SVN.native_branch): Ditto.
2273         * Scripts/webkitpy/common/system/platforminfo.py:
2274         (PlatformInfo.build_version): Return a build version for Mac.
2275         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2276         (MockPlatformInfo.__init__):
2277         (MockPlatformInfo.build_version):
2278         * Scripts/webkitpy/results: Added.
2279         * Scripts/webkitpy/results/__init__.py: Added.
2280         * Scripts/webkitpy/results/options.py: Added.
2281         (upload_options): OptParse list for upload options.
2282         * Scripts/webkitpy/results/upload.py: Added.
2283         (Upload): Class which enforces the upload format expected by the results server.
2284         (Upload.Expectations):
2285         (Upload.create_configuration):
2286         (Upload.create_commit):
2287         (Upload.create_details):
2288         (Upload.create_run_stats):
2289         (Upload.create_test_result):
2290         (Upload.__init__):
2291         (Upload.Encoder): Encode Upload object as json.
2292         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2293         * Scripts/webkitpy/results/upload_unittest.py: Added.
2294         * Scripts/webkitpy/test/main.py:
2295         (Tester._parse_args): Add upload arguments.
2296         (Tester._run_tests): Allow results to be uploaded.
2297         * Scripts/webkitpy/test/runner.py:
2298         (Runner.__init__): Record which tests were run, rather than just counting them.
2299         (Runner.handle):
2300         * Scripts/webkitpy/test/runner_unittest.py:
2301         (RunnerTest.test_run):
2302         * Scripts/webkitpy/thirdparty/__init__.py:
2303         (AutoinstallImportHook.find_module): Add requests auto-install.
2304         (AutoinstallImportHook._install_requests):
2305         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2306         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2307
2308 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2309
2310         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2311         https://bugs.webkit.org/show_bug.cgi?id=195810
2312
2313         Reviewed by Tim Horton.
2314
2315         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2316         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2317         ending certain layout tests.
2318
2319         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2320         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2321         (-[TestRunnerWKWebView dealloc]):
2322         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2323
2324         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2325         helper method when destroying the web view, and when resetting state between tests.
2326
2327         * WebKitTestRunner/ios/TestControllerIOS.mm:
2328         (WTR::TestController::platformResetStateToConsistentValues):
2329
2330         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2331
2332 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2333
2334         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2335         https://bugs.webkit.org/show_bug.cgi?id=190350
2336         <rdar://problem/45089503>
2337
2338         Reviewed by Geoffrey Garen.
2339
2340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2341         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2342         (TEST):
2343         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2344         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2345         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2346         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2347         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2348         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2349         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2350         (runTest):
2351         (createDirectories):
2352         (TEST):
2353         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2354         (TEST):
2355         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2356         (TEST):
2357
2358 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2359
2360         Add support to WebPage for getting the contents as an attributed string.
2361         https://bugs.webkit.org/show_bug.cgi?id=195636
2362         rdar://problem/45055697
2363
2364         Reviewed by Tim Horton.
2365
2366         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2367         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2368
2369 2019-03-15  Chris Dumez  <cdumez@apple.com>
2370
2371         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2372         https://bugs.webkit.org/show_bug.cgi?id=195747
2373
2374         Reviewed by Geoff Garen.
2375
2376         Add API test coverage.
2377
2378         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2379
2380 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2381
2382         Unreviewed, rolling out r242952.
2383
2384         Causing API failures on iOS Simulator
2385
2386         Reverted changeset:
2387
2388         "[PSON] Make sure the WebProcessCache is leverage when
2389         relaunching a process after termination"
2390         https://bugs.webkit.org/show_bug.cgi?id=195747
2391         https://trac.webkit.org/changeset/242952
2392
2393 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2394
2395         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2396         https://bugs.webkit.org/show_bug.cgi?id=195740
2397
2398         Reviewed by Ross Kirsling.
2399
2400         window.open doesn't work for WebKitBrowserWindow because it is not
2401         implemented yet.
2402
2403         1. Implemented createNewPage callback of WKPageUIClient.
2404         2. Changed MainWindow to take a BrowserWindow factory function
2405           instead of BrowserWindowType to be flexible to create
2406           BrowserWindow with extra settings.
2407         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2408           because it is not relevant with MainWindow anymore.
2409
2410         * MiniBrowser/win/Common.cpp:
2411         (parseCommandLine):
2412         * MiniBrowser/win/Common.h:
2413         (CommandLineOptions::CommandLineOptions):
2414         * MiniBrowser/win/MainWindow.cpp:
2415         (MainWindow::MainWindow):
2416         (MainWindow::create):
2417         (MainWindow::init):
2418         (MainWindow::WndProc):
2419         * MiniBrowser/win/MainWindow.h:
2420         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2421         (PrintWebUIDelegate::createWebViewWithRequest):
2422         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2423         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2424         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2425         (WebKitBrowserWindow::updateProxySettings):
2426         (WebKitBrowserWindow::createNewPage):
2427         * MiniBrowser/win/WebKitBrowserWindow.h:
2428         * MiniBrowser/win/WinMain.cpp:
2429         (wWinMain):
2430
2431 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2432
2433         Make it possible to test scrolling tree layer manipulation more easily
2434         https://bugs.webkit.org/show_bug.cgi?id=195780
2435
2436         Reviewed by Tim Horton.
2437         
2438         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2439         cuts off communication of scrolling tree scrolls back to the web process
2440         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2441         allows tests to trigger scrolls which run the scrolling tree layer positioning
2442         logic, but never get another commit from the web process that might mask
2443         scrolling tree bugs.
2444         
2445         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2446         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2447         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2448
2449         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2450         (WTR::UIScriptController::scrollUpdatesDisabled const):
2451         (WTR::UIScriptController::setScrollUpdatesDisabled):
2452         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2453         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2454         (WTR::UIScriptController::scrollUpdatesDisabled const):
2455         (WTR::UIScriptController::setScrollUpdatesDisabled):
2456         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2457         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2458         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2459         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2460         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2461         * WebKitTestRunner/ios/TestControllerIOS.mm:
2462         (WTR::TestController::platformResetStateToConsistentValues):
2463         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2464         (WTR::UIScriptController::scrollUpdatesDisabled const):
2465         (WTR::UIScriptController::setScrollUpdatesDisabled):
2466
2467 2019-03-14  Youenn Fablet  <youenn@apple.com>
2468
2469         Move IDB storage in private browsing mode to NetworkProcess
2470         https://bugs.webkit.org/show_bug.cgi?id=195602
2471
2472         Reviewed by Brady Eidson.
2473
2474         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2475         (TEST):
2476
2477 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2478
2479         [ews-build] Make descriptionDone messages more readable
2480         https://bugs.webkit.org/show_bug.cgi?id=195760
2481
2482         Reviewed by Lucas Forschler.
2483
2484         * BuildSlaveSupport/ews-build/steps.py:
2485         * BuildSlaveSupport/ews-build/steps_unittest.py:
2486
2487 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2488
2489         [ews-build] Generate status-bubble hover-over messages
2490         https://bugs.webkit.org/show_bug.cgi?id=195680
2491
2492         Reviewed by Lucas Forschler.
2493
2494         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2495         (StatusBubble):
2496         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2497         on hover-over.
2498         (StatusBubble._iso_time):
2499         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2500         hover-over message.
2501         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2502
2503 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2504
2505         [ews-app] Gracefully handle the case when state_string is None
2506         https://bugs.webkit.org/show_bug.cgi?id=195753
2507
2508         Reviewed by Lucas Forschler.
2509
2510         * BuildSlaveSupport/ews-app/ews/models/build.py:
2511         * BuildSlaveSupport/ews-app/ews/models/step.py:
2512
2513 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2514
2515         [ews-app] Status bubble display pending for currently running build step
2516         https://bugs.webkit.org/show_bug.cgi?id=195744
2517
2518         Reviewed by Lucas Forschler.
2519
2520         * BuildSlaveSupport/ews-build/events.py:
2521         (Events.stepStarted): If state_string is pending, replace it with step name.
2522
2523 2019-03-14  Chris Dumez  <cdumez@apple.com>
2524
2525         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2526         https://bugs.webkit.org/show_bug.cgi?id=195750
2527
2528         Reviewed by Geoffrey Garen.
2529
2530         Add API test coverage.
2531
2532         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2533         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2534         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2535         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2536
2537 2019-03-14  Chris Dumez  <cdumez@apple.com>
2538
2539         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2540         https://bugs.webkit.org/show_bug.cgi?id=195747
2541
2542         Reviewed by Geoff Garen.
2543
2544         Add API test coverage.
2545
2546         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2547
2548 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2549
2550         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2551         https://bugs.webkit.org/show_bug.cgi?id=195725
2552         <rdar://problem/48545062>
2553
2554         Reviewed by Tim Horton.
2555
2556         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2557         handler is nil.
2558
2559         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2560         (TestWebKitAPI::TEST):
2561
2562 2019-03-13  Sam Weinig  <sam@webkit.org>
2563
2564         Add utility function to allow easy reverse range-based iteration of a container
2565         https://bugs.webkit.org/show_bug.cgi?id=195542
2566
2567         Reviewed by Antti Koivisto.
2568
2569         * TestWebKitAPI/CMakeLists.txt:
2570         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2571         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2572         (TestWebKitAPI::TEST):
2573         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2574
2575 2019-03-13  Chris Dumez  <cdumez@apple.com>
2576
2577         Use a ServiceWorker process per registrable domain
2578         https://bugs.webkit.org/show_bug.cgi?id=195649
2579
2580         Reviewed by Youenn Fablet.
2581
2582         Update API test coverage.
2583
2584         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2585
2586 2019-03-13  Chris Dumez  <cdumez@apple.com>
2587
2588         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2589         https://bugs.webkit.org/show_bug.cgi?id=195684
2590         <rdar://problem/48294714>
2591
2592         Reviewed by Antti Koivisto.
2593
2594         Add API test coverage.
2595
2596         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2597
2598 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2599
2600         [ews-app] Remove unused patch view
2601         https://bugs.webkit.org/show_bug.cgi?id=195669
2602
2603         Reviewed by Lucas Forschler.
2604
2605         * BuildSlaveSupport/ews-app/ews/urls.py:
2606         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2607
2608 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2609
2610         [ews-app] Use Buildbot result code variables
2611         https://bugs.webkit.org/show_bug.cgi?id=195668
2612
2613         Reviewed by Alexey Proskuryakov.
2614
2615         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2616         (Buildbot): Added Buildbot result code variables.
2617         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2618         (StatusBubble._build_bubble): Used Buildbot result code variables.
2619
2620 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2621
2622         [Flatpak] Expand submodule recursively
2623         https://bugs.webkit.org/show_bug.cgi?id=195672
2624
2625         Building WPE with flatpak was impossible without that as it was raising an exception.
2626         Also update wpebackend-fdo to match what is built in jhbuild
2627
2628         Reviewed by Philippe Normand.
2629
2630         * flatpak/flatpakutils.py:
2631         (expand_submodules_recurse):
2632         (expand_manifest):
2633         * flatpak/org.webkit.WPEModules.yaml:
2634
2635 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2636
2637         [ews-app] status bubble should be hidden for certain builds
2638         https://bugs.webkit.org/show_bug.cgi?id=194597
2639
2640         Reviewed by Dewei Zhu.
2641
2642         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2643         (StatusBubble._build_bubble):
2644         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2645         because the patch didn't have relevant changes.
2646         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2647         in production yet.
2648
2649 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2650
2651         [Win] Fix a slew of simple clang-cl warnings.
2652         https://bugs.webkit.org/show_bug.cgi?id=195652
2653
2654         Reviewed by Don Olmstead.
2655
2656         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2657         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2658
2659 2019-03-12  Justin Fan  <justin_fan@apple.com>
2660
2661         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2662         https://bugs.webkit.org/show_bug.cgi?id=195518
2663         <rdar://problem/46322356>
2664
2665         Reviewed by Myles C. Maxfield.
2666
2667         * DumpRenderTree/DerivedSources-input.xcfilelist:
2668         * DumpRenderTree/DerivedSources-output.xcfilelist:
2669
2670 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2671
2672         Unreviewed, rolling out r242825.
2673         https://bugs.webkit.org/show_bug.cgi?id=195648
2674
2675         "Broke webkitpy tests with my change to
2676         lldb_dump_class_layout.py" (Requested by rmorisset on
2677         #webkit).
2678
2679         Reverted changeset:
2680
2681         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2682         classes with suspicious padding"
2683         https://bugs.webkit.org/show_bug.cgi?id=195573
2684         https://trac.webkit.org/changeset/242825
2685
2686 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2687
2688         [ews-build] Show status bubbles while the patch is waiting in queue
2689         https://bugs.webkit.org/show_bug.cgi?id=195618
2690
2691         Reviewed by Lucas Forschler.
2692
2693         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2694         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2695         enabled in initial deployment.
2696         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2697         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2698         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2699         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2700         (StatusBubble._build_bubbles_for_patch):
2701
2702 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2703
2704         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2705         https://bugs.webkit.org/show_bug.cgi?id=195573
2706
2707         Reviewed by Simon Fraser.
2708
2709         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2710
2711         * Scripts/dump-class-layout:
2712         (main):
2713         * lldb/lldb_dump_class_layout.py:
2714         (ClassLayout.__init__):
2715         (ClassLayout._compute_padding_recursive):
2716         (LLDBDebuggerInstance.dump_layout_for_classname):
2717         (LLDBDebuggerInstance):
2718         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2719         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2720
2721 2019-03-12  Chris Dumez  <cdumez@apple.com>
2722
2723         Device Orientation access permission should be denied unless explicitly granted by the client
2724         https://bugs.webkit.org/show_bug.cgi?id=195625
2725
2726         Reviewed by Youenn Fablet.
2727
2728         add API test coverage.
2729
2730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2731         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2732         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2733         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2734         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2735         (runDeviceOrientationTest):
2736         (TEST):
2737         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2738         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2739
2740 2019-03-12  Jer Noble  <jer.noble@apple.com>
2741
2742         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2743         https://bugs.webkit.org/show_bug.cgi?id=195137
2744         <rdar://problem/48810307>
2745
2746         Reviewed by Eric Carlson.
2747
2748         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2749         (TestWebKitAPI::TEST):
2750
2751 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2752
2753         [ews-build] Change urls from uat to production
2754         https://bugs.webkit.org/show_bug.cgi?id=195566
2755
2756         Reviewed by Lucas Forschler.
2757
2758         * BuildSlaveSupport/ews-app/ews/config.py:
2759         * BuildSlaveSupport/ews-build/events.py:
2760         * BuildSlaveSupport/ews-build/steps.py:
2761
2762 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2763
2764         [ews-build] change max_builds for local-worker to 1
2765         https://bugs.webkit.org/show_bug.cgi?id=195568
2766
2767         Reviewed by Lucas Forschler.
2768
2769         * BuildSlaveSupport/ews-build/loadConfig.py:
2770
2771 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2772
2773         Fix the build
2774
2775         * TestRunnerShared/spi/PencilKitTestSPI.h:
2776         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2777
2778 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2779
2780         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2781         https://bugs.webkit.org/show_bug.cgi?id=194131
2782
2783         Reviewed by Michael Catanzaro.
2784
2785         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2786         (uriChanged):
2787         (testUnfinishedSubresourceLoad):
2788         (serverCallback):
2789         (beforeAll):
2790
2791 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2792
2793         WTF::Expected should use std::addressof instead of operator&
2794         https://bugs.webkit.org/show_bug.cgi?id=195604
2795
2796         Reviewed by Myles Maxfield.
2797
2798         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2799         (TestWebKitAPI::Unique::Unique):
2800         (TestWebKitAPI::Unique::operator&):
2801         (TestWebKitAPI::TEST):
2802
2803 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2804
2805         Add Optional to Forward.h.
2806         https://bugs.webkit.org/show_bug.cgi?id=195586
2807
2808         Reviewed by Darin Adler.
2809
2810         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2811         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2812         Remove unnecessary includes from headers.
2813
2814 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2815
2816         Add testing API to hit-test and scroll overflow scrollers
2817         https://bugs.webkit.org/show_bug.cgi?id=195278
2818
2819         Reviewed by Antti Koivisto.
2820         
2821         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2822         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2823         
2824         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2825
2826         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2827         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2828         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2829         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2830         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2831         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2832         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2833         (WTR::enclosingScrollViewIncludingSelf):
2834         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2835
2836 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2837
2838         API test WebKit.RequestTextInputContext fails on iOS
2839         https://bugs.webkit.org/show_bug.cgi?id=195585
2840
2841         Reviewed by Wenson Hsieh and Simon Fraser.
2842
2843         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2844         (applyStyle):
2845         (TEST):
2846         Add a viewport, so that the coordinates match up on iOS.
2847         Scroll by moving the UIScrollView's contentOffset.
2848
2849 2019-03-11  Chris Dumez  <cdumez@apple.com>
2850
2851         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2852         https://bugs.webkit.org/show_bug.cgi?id=195506
2853         <rdar://problem/48733477>
2854
2855         Reviewed by Alex Christensen.
2856
2857         Add API test coverage.
2858
2859         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2860
2861 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2862
2863         Adding myself to contributors.json
2864
2865         Unreviewed, addming myself to contributors.json .
2866
2867         * Scripts/webkitpy/common/config/contributors.json:
2868
2869 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2870
2871         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2872         https://bugs.webkit.org/show_bug.cgi?id=195511
2873         <rdar://problem/44873269>
2874
2875         Reviewed by Darin Adler.
2876
2877         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2878         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2879         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2880         (TEST_F):
2881
2882 2019-03-11  Chris Dumez  <cdumez@apple.com>
2883
2884         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2885         https://bugs.webkit.org/show_bug.cgi?id=195561
2886
2887         Reviewed by Youenn Fablet.
2888
2889         Make sure the JS in the test requests for permission to receive device orientation events.
2890
2891         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2892
2893 2019-03-11  Youenn Fablet  <youenn@apple.com>
2894
2895         Allow storage quota increase by default in WTR
2896         https://bugs.webkit.org/show_bug.cgi?id=195541
2897
2898         Reviewed by Geoffrey Garen.
2899
2900         Allow storage quota increase by default in WTR.
2901         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2902         Use this for tests that explicitly need cache increase.
2903
2904         Instead of increasing quota by 2, make sure the next request is
2905         granted by adding all given parameters.
2906
2907         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2908         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2909         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2910         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2911         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2912         * WebKitTestRunner/TestController.cpp:
2913         (WTR::TestController::setAllowStorageQuotaIncrease):
2914         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2915         * WebKitTestRunner/TestController.h:
2916         * WebKitTestRunner/TestInvocation.cpp:
2917         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2918         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2919         (WTR::TestController::cocoaResetStateToConsistentValues):
2920         (WTR::TestController::setAllowStorageQuotaIncrease):
2921         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2922         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2923         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2924
2925 2019-03-11  Xan Lopez  <xan@igalia.com>
2926
2927         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2928         https://bugs.webkit.org/show_bug.cgi?id=194147
2929
2930         Reviewed by Michael Saboff.
2931
2932         To make --32-bit work correctly on Linux/64bit we need to:
2933
2934         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2935         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2936         unfortunately CMake only allows us to do this during
2937         crosscompilation, which is overkill here.
2938         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2939         pkg-config detection module uses the x86 .pc files instead of the
2940         x86_64 ones.
2941         - Set the -m32 flags for the compiler.
2942
2943         * Scripts/webkitdirs.pm:
2944         (generateBuildSystemFromCMakeProject):
2945
2946 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2947
2948         Add MotionMark-1.1 plan file for run-benchmark script.
2949         https://bugs.webkit.org/show_bug.cgi?id=195481
2950
2951         Rubber-stamped by Darin Adler.
2952
2953         Run-benchmark script should support MontionMark-1.1.
2954
2955         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2956
2957 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2958
2959         [ews-app] Add support for submit-to-ews url
2960         https://bugs.webkit.org/show_bug.cgi?id=195477
2961
2962         Reviewed by Lucas Forschler.
2963
2964         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2965         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2966         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2967         * BuildSlaveSupport/ews-app/ews/urls.py:
2968         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2969
2970 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2971
2972         Unreviewed, rolling out r242688, r242643, r242624.
2973
2974         Caused multiple layout test failures and crashes on iOS and macOS.
2975
2976         Reverted changeset:
2977
2978         "requestAnimationFrame should execute before the next frame"
2979         https://bugs.webkit.org/show_bug.cgi?id=177484
2980         https://trac.webkit.org/changeset/242624/webkit
2981
2982         * Tracing/SystemTracePoints.plist:
2983
2984 2019-03-11  John Wilander  <wilander@apple.com>
2985
2986         Resource Load Statistics: Make it possible exclude localhost from classification
2987         https://bugs.webkit.org/show_bug.cgi?id=195474
2988         <rdar://problem/47520577>
2989
2990         Reviewed by Brent Fulgham.
2991
2992         This patch allows for localhost to be excluded from classification and
2993         treatment as a prevalent resource.
2994
2995         The WebKit Tools change adds a new function called
2996         testRunner.setStatisticsIsRunningTest() which can be used to control this
2997         behavior.
2998
2999         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3000         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3001         (WTR::TestRunner::setStatisticsIsRunningTest):
3002         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3003         * WebKitTestRunner/TestController.cpp:
3004         (WTR::TestController::setStatisticsIsRunningTest):
3005         * WebKitTestRunner/TestController.h:
3006         * WebKitTestRunner/TestInvocation.cpp:
3007         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3008
3009 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3010
3011         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3012         https://bugs.webkit.org/show_bug.cgi?id=195560
3013
3014         Reviewed by Lucas Forschler.
3015
3016         * BuildSlaveSupport/ews-build/master.cfg:
3017
3018 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3019
3020         Unreviewed, rolling out r242698.
3021
3022         API test crashes on bots.
3023
3024         Reverted changeset:
3025
3026         "Add a WKContentRuleList variant that uses copied memory
3027         instead of mmap'd shared memory for class A containerized
3028         apps"
3029         https://bugs.webkit.org/show_bug.cgi?id=195511
3030         https://trac.webkit.org/changeset/242698
3031
3032 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3033
3034         [WPE] Enable web process sandbox
3035         https://bugs.webkit.org/show_bug.cgi?id=195169
3036
3037         Reviewed by Daniel Bates.
3038
3039         * wpe/install-dependencies:
3040         * wpe/jhbuild.modules:
3041
3042 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3043
3044         [ews-app] Use port 17000 for worker communication
3045         https://bugs.webkit.org/show_bug.cgi?id=195558
3046
3047         Reviewed by Lucas Forschler.
3048
3049         * BuildSlaveSupport/ews-build/master.cfg:
3050
3051 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3052
3053         [ews-build] unit-tests fail when passwords.json is missing
3054         https://bugs.webkit.org/show_bug.cgi?id=195557
3055
3056         Reviewed by Lucas Forschler.
3057
3058         * BuildSlaveSupport/ews-build/loadConfig.py:
3059         (loadBuilderConfig):
3060         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3061         (ConfigDotJSONTest.test_configuration):
3062         * BuildSlaveSupport/ews-build/master.cfg:
3063
3064 2019-03-11  Truitt Savell  <tsavell@apple.com>
3065
3066         Unreviewed, rolling out r242702.
3067
3068         Broke High Sierra builders.
3069
3070         Reverted changeset:
3071
3072         "Add utility function to allow easy reverse range-based
3073         iteration of a container"
3074         https://bugs.webkit.org/show_bug.cgi?id=195542
3075         https://trac.webkit.org/changeset/242702
3076
3077 2019-03-11  Sam Weinig  <sam@webkit.org>
3078
3079         Add utility function to allow easy reverse range-based iteration of a container
3080         https://bugs.webkit.org/show_bug.cgi?id=195542
3081
3082         Reviewed by Antti Koivisto.
3083
3084         * TestWebKitAPI/CMakeLists.txt:
3085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3086         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3087         (TestWebKitAPI::TEST):
3088         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3089
3090 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3091
3092         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3093         https://bugs.webkit.org/show_bug.cgi?id=195511
3094         <rdar://problem/44873269>
3095
3096         Reviewed by Darin Adler.
3097
3098         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3099         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3100         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3101         (TEST_F):
3102
3103 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3104
3105         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3106         https://bugs.webkit.org/show_bug.cgi?id=195499
3107
3108         Reviewed by Darin Adler.
3109
3110         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3111         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3112         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3113         (-[WKWebView synchronouslyFocusTextInputContext:]):
3114         (applyStyle):
3115         (applyIframe):
3116         (TEST):
3117         Add some tests for this SPI.
3118
3119 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3120
3121         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3122         https://bugs.webkit.org/show_bug.cgi?id=181151
3123
3124         Reviewed by Don Olmstead.
3125
3126         * TestWebKitAPI/CMakeLists.txt:
3127         * TestWebKitAPI/PlatformWin.cmake:
3128         Enable TestWTF RunLoop tests in all platforms.
3129
3130         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3131         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3132         (TestWebKitAPI::DerivedOneShotTimer::fired):
3133         (TestWebKitAPI::TEST):
3134         Only a few platforms support nested RunLoop.
3135
3136         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3137         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3138
3139 2019-03-10  David Quesada  <david_quesada@apple.com>
3140
3141         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3142         https://bugs.webkit.org/show_bug.cgi?id=152480
3143
3144         Reviewed by Chris Dumez.
3145
3146         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3147         there are no additional references to the process pool besides the one held by
3148         the download, waits for the download to finish (in the sense that the
3149         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3150         measure, also check that the process pool has been deallocated at the end of the
3151         test. The test wouldn't be meaningful if the process pool were still alive.
3152
3153         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3154         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3155         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3156             The download will be canceled because the delegate does not implement the
3157             method to decide the download's destination, so this is where we know the
3158             DownloadProxyMap is done with the DownloadProxy.
3159         (TEST):
3160
3161 2019-03-08  Chris Dumez  <cdumez@apple.com>
3162
3163         Add support for Device Orientation / Motion permission API
3164         https://bugs.webkit.org/show_bug.cgi?id=195329
3165         <rdar://problem/47645367>
3166
3167         Reviewed by Geoffrey Garen.
3168
3169         Add test infrastructure to help test the Device Orientation / Motion permission API.
3170
3171         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3172         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3173         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3174         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3175         * WebKitTestRunner/TestController.cpp:
3176         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3177         (WTR::TestController::createWebViewWithOptions):
3178         (WTR::TestController::resetStateToConsistentValues):
3179         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3180         * WebKitTestRunner/TestController.h:
3181         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3182         * WebKitTestRunner/TestInvocation.cpp:
3183         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3184
3185 2019-03-08  Saam barati  <sbarati@apple.com>
3186
3187         Add a compare-results script to compare benchmark results
3188         https://bugs.webkit.org/show_bug.cgi?id=195486
3189         <rdar://problem/48723397>
3190
3191         Reviewed by Geoffrey Garen.
3192
3193         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3194         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3195         to extend it to learn about our other benchmarks.
3196
3197         * Scripts/compare-results: Added.
3198         (readJSONFile):
3199         (detectJetStream2):
3200         (JetStream2Results):
3201         (detectSpeedometer2):
3202         (Speedometer2Results):
3203         (detectPLT5):
3204         (PLT5Results):
3205         (detectBenchmark):
3206         (biggerIsBetter):
3207         (ttest):
3208         (getOptions):
3209         (main):
3210
3211 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3212
3213         Ensure old tab state is cleared between iterations of run-benchmark
3214         https://bugs.webkit.org/show_bug.cgi?id=195393
3215         <rdar://problem/46885583>
3216
3217         Reviewed by Dewei Zhu.
3218
3219         a) ensure the default to restore state is not set
3220         b) terminate Safari correctly
3221         c) Set the system default to ignore Persistent State in Safari
3222
3223         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3224         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3225         (OSXBrowserDriver.prepare_env): 
3226         (OSXBrowserDriver.restore_env):
3227         (OSXBrowserDriver.close_browsers):
3228         (OSXBrowserDriver._terminate_processes):
3229         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3230         (OSXChromeDriver):
3231         (OSXChromeCanaryDriver):
3232         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3233         (OSXFirefoxDriver):
3234         (OSXFirefoxNightlyDriver):
3235         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3236         (OSXSafariDriver):
3237         (OSXSafariDriver.prepare_env):
3238
3239 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3240
3241         [GTK] Several InputMethodFilter tests are failing
3242         https://bugs.webkit.org/show_bug.cgi?id=195408
3243
3244         Reviewed by Carlos Garcia Campos.
3245
3246         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3247         Regressed in r241751.
3248         Hexadecimal values of keycodes are expressed now in upper letters.
3249         Composited characters should be cast to UTF8 strings.
3250
3251         (TestWebKitAPI::TEST):
3252
3253 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3254
3255         [GTK] Make Tools/gtkdoc python3 compatible
3256         https://bugs.webkit.org/show_bug.cgi?id=195359
3257
3258         Reviewed by Carlos Garcia Campos.
3259
3260         * gtkdoc/generate-gtkdoc:
3261         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3262         work with Python 2 and 3.
3263         (get_gtkdoc_module_paths):
3264         The iteritems() was removed in Python 3, so let's use items() that's
3265         available in Python 2 and 3.
3266         (get_generator_for_config):
3267         * gtkdoc/gtkdoc.py:
3268         (GTKDoc._run_command):
3269         The sys.stdout.write() is expecting str in Python 3 and not bytes
3270         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3271         for passing the bytes there.
3272
3273 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3274
3275         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3276         https://bugs.webkit.org/show_bug.cgi?id=195346
3277         <rdar://problem/48667048>
3278
3279         Unreviewed build fix for clang-cl.
3280
3281         * DumpRenderTree/win/DumpRenderTree.cpp:
3282         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3283
3284 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3285
3286         requestAnimationFrame should execute before the next frame
3287         https://bugs.webkit.org/show_bug.cgi?id=177484
3288
3289         Reviewed by Simon Fraser.
3290
3291         Add trace points for the page RenderingUpdate.
3292
3293         * Tracing/SystemTracePoints.plist:
3294
3295 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3296
3297         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3298         https://bugs.webkit.org/show_bug.cgi?id=195353
3299         <rdar://problem/48626394>
3300
3301         Reviewed by Simon Fraser.
3302
3303         * WebKitTestRunner/ios/TestControllerIOS.mm:
3304         (WTR::TestController::platformResetPreferencesToConsistentValues):
3305
3306 2019-03-07  John Wilander  <wilander@apple.com>
3307
3308         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3309         https://bugs.webkit.org/show_bug.cgi?id=195383
3310         <rdar://problem/48570136>
3311
3312         Reviewed by Brent Fulgham.
3313
3314         This patch adds test infrastructure to purge only script-accessible cookies,
3315         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3316
3317         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3318         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3319         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3320         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3321         * WebKitTestRunner/TestController.cpp:
3322         (WTR::TestController::statisticsDeleteCookiesForHost):
3323         * WebKitTestRunner/TestController.h:
3324         * WebKitTestRunner/TestInvocation.cpp:
3325         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3326
3327 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3328
3329         Unreviewed, rolling out r242354.
3330         https://bugs.webkit.org/show_bug.cgi?id=195402
3331
3332         breaks layout tests in all configurations (Requested by
3333         zdobersek on #webkit).
3334
3335         Reverted changeset:
3336
3337         "[WPE] Enable web process sandbox"
3338         https://bugs.webkit.org/show_bug.cgi?id=195169
3339         https://trac.webkit.org/changeset/242354
3340
3341 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3342
3343         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3344         https://bugs.webkit.org/show_bug.cgi?id=195346
3345
3346         Reviewed by Fujii Hironori.
3347
3348         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3349         (TestWebKitAPI::TEST):
3350         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3351
3352         * DumpRenderTree/win/DumpRenderTree.cpp:
3353         (findFontFallback):
3354         (addFontFallbackIfPresent):
3355         (removeFontFallbackIfPresent):
3356         (main):
3357         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3358         (TestWebKitAPI::Util::moduleDirectory):
3359         (TestWebKitAPI::Util::createInjectedBundlePath):
3360         Use wchar helpers as needed.
3361
3362 2019-03-06  Rob Buis  <rbuis@igalia.com>
3363
3364         Consider supporting the `referrerpolicy` attribute.
3365         https://bugs.webkit.org/show_bug.cgi?id=179053
3366
3367         Reviewed by Darin Adler.
3368
3369         Add a runtime flag for referrerpolicy attribute.
3370
3371         * DumpRenderTree/mac/DumpRenderTree.mm:
3372         (enableExperimentalFeatures):
3373
3374 2019-03-05  Daniel Bates  <dabates@apple.com>
3375
3376         Update expected API test result following r242379
3377         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3378
3379         Update expected x-coordinate of selection rect now that the left padding of
3380         a textarea is sized in ems (so dependent on the font size) just like the left
3381         padding of a text field.
3382
3383         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3384         (TestWebKitAPI::TEST):
3385
3386 2019-03-05  David Quesada  <david_quesada@apple.com>
3387
3388         [WK2] It should be possible to follow links with 'download' attributes
3389         https://bugs.webkit.org/show_bug.cgi?id=195145
3390         rdar://problem/48462642
3391
3392         Reviewed by Alex Christensen.
3393
3394         Add a unit test to verify that activating links with 'download' attributes now
3395         navigates to the linked resource, rather than starts downloading it. Add another
3396         to verify that it is still possible to explicitly download the link via the
3397         'Download' navigation action policy.
3398
3399         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3400         (-[DownloadAttributeTestDelegate init]):
3401         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3402         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3403         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3404         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3405         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3406         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3407         (TEST):
3408         * WebKitTestRunner/TestController.cpp:
3409         (WTR::TestController::decidePolicyForNavigationAction):
3410         * WebKitTestRunner/TestController.h:
3411
3412 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3413
3414         [Curl] Implement Cookie Accept Policy.
3415         https://bugs.webkit.org/show_bug.cgi?id=191645
3416
3417         Reviewed by Fujii Hironori.
3418
3419         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3420         (TestWebKitAPI::Curl::TEST_F):
3421
3422 2019-03-05  Youenn Fablet  <youenn@apple.com>
3423
3424         Rename requestCacheStorageSpace to requestStorageSpace
3425         https://bugs.webkit.org/show_bug.cgi?id=195282
3426
3427         Reviewed by Chris Dumez.
3428
3429         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3430         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3431         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3432
3433 2019-03-05  Brady Eidson  <beidson@apple.com>
3434
3435         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3436         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3437
3438         Reviewed by Tim Horton.
3439
3440         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3441         different directory into that same WKWebView should work.
3442
3443         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3444         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3445
3446 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3447
3448         Add WeakHashSet
3449         https://bugs.webkit.org/show_bug.cgi?id=195152
3450
3451         Reviewed by Antti Koivisto.
3452
3453         Added tests for WeakHashSet.
3454
3455         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3456         (TestWebKitAPI::Base::Base): Moved.
3457         (TestWebKitAPI::Derived::foo): Moved.
3458         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3459         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3460         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3461         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3462
3463 2019-03-04  Chris Dumez  <cdumez@apple.com>
3464
3465         Do not share WebProcesses between private and regular sessions
3466         https://bugs.webkit.org/show_bug.cgi?id=195189
3467         <rdar://problem/48421064>
3468
3469         Reviewed by Alex Christensen.
3470
3471         Add API test coverage.
3472
3473         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3474         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3475
3476 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3477
3478         [WPE] Enable web process sandbox
3479         https://bugs.webkit.org/show_bug.cgi?id=195169
3480
3481         Reviewed by Daniel Bates.
3482
3483         * wpe/install-dependencies:
3484         * wpe/jhbuild.modules:
3485
3486 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3487
3488         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3489         https://bugs.webkit.org/show_bug.cgi?id=195206
3490
3491         Reviewed by Žan Doberšek.
3492
3493         Add a new test case.
3494
3495         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3496         (testJSCClass):
3497
3498 2019-03-04  Charlie Turner  <cturner@igalia.com>
3499
3500         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3501         https://bugs.webkit.org/show_bug.cgi?id=194898
3502
3503         Reviewed by Žan Doberšek.
3504
3505         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3506         a GCC extension that permits arithmetic on void* pointer. Inline
3507         the macro until this issue is fixed upstream.
3508
3509 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3510
3511         Rid the world of WK_API_ENABLED
3512         https://bugs.webkit.org/show_bug.cgi?id=195263
3513
3514         Reviewed by Dan Bernstein.
3515
3516         List of changed files elided because it's useless.
3517
3518 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3519
3520         Unreviewed follow-up to r242292.
3521
3522         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3523
3524         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3525         (TestWebKitAPI::testStrip): Renamed from strip.
3526         (TestWebKitAPI::TEST):
3527
3528 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3529
3530         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3531
3532         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3533         and bug #194272 for details.
3534
3535         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3536
3537 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3538
3539         Remove some more unused 32-bit code
3540         https://bugs.webkit.org/show_bug.cgi?id=195255
3541
3542         Reviewed by Darin Adler.
3543
3544         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3545         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3546         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3547         (NPP_New):
3548         (NPP_HandleEvent):
3549         (handleEventCarbon): Deleted.
3550
3551 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3552
3553         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3554
3555         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3556         (TestWebKitAPI::TEST):
3557
3558 2019-03-01  Darin Adler  <darin@apple.com>
3559
3560         Finish removing String::format
3561         https://bugs.webkit.org/show_bug.cgi?id=194893
3562
3563         Reviewed by Daniel Bates.
3564 '
3565         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3566
3567 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3568
3569         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3570         https://bugs.webkit.org/show_bug.cgi?id=195229
3571         <rdar://problem/48520362>
3572
3573         Reviewed by Chris Dumez.
3574
3575         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3576         (TEST):
3577
3578 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3579
3580         Add a system trace scope for event region building
3581         https://bugs.webkit.org/show_bug.cgi?id=195226
3582
3583         Reviewed by Jon Lee.
3584
3585         This trace scope measures the time spend converting element rects into Region objects,
3586         which can be large on some pages.
3587
3588         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3589
3590         * Tracing/SystemTracePoints.plist:
3591
3592 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3593
3594         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3595         https://bugs.webkit.org/show_bug.cgi?id=194612
3596
3597         Reviewed by Alex Christensen.
3598
3599         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3600         Just test the new string-processing function and don't touch the actual environment.
3601         (Test cases are all as before, but based on operator== instead of strcmp.)
3602
3603 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3604
3605         [ews-app] Update primary keys for handling multiple Buildbot instances
3606         https://bugs.webkit.org/show_bug.cgi?id=195120
3607
3608         Reviewed by Stephanie Lewis.
3609
3610         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3611         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3612         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3613
3614         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3615         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3616         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3617         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3618         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3619         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3620
3621 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3622
3623         [WinCairo] Enable service worker
3624         https://bugs.webkit.org/show_bug.cgi?id=188318
3625
3626         Reviewed by Youenn Fablet.
3627
3628         * DumpRenderTree/DumpRenderTreePrefix.h:
3629         * TestWebKitAPI/PlatformWin.cmake:
3630         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3631         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3632         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3633
3634 2019-03-01  Justin Fan  <justin_fan@apple.com>
3635
3636         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3637         https://bugs.webkit.org/show_bug.cgi?id=195191
3638
3639         Rubber-stamped by Dean Jackson.
3640
3641         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3642
3643         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3644
3645 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3646
3647         Unreviewed, fix lldb webkitpy tests
3648         https://bugs.webkit.org/show_bug.cgi?id=194375
3649
3650         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3651
3652         * lldb/lldb_webkit.py:
3653         (WTFStringImplProvider.is_8bit):
3654
3655 2019-02-28  David Quesada  <david_quesada@apple.com>
3656
3657         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3658         https://bugs.webkit.org/show_bug.cgi?id=195121
3659         rdar://problem/48450302
3660
3661         Reviewed by Alex Christensen.
3662
3663         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3664         configurations where the 'download' attribute is absent, blank, or populated
3665         with a filename, and where the anchor element is same-origin or cross-origin
3666         (meaning the 'download' attribute shouldn't be honored).
3667
3668         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3669         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3670         (-[NavigationActionTestDelegate init]):
3671         (-[NavigationActionTestDelegate navigationAction]):
3672         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3673         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3674         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3675         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3676         (TEST):
3677
3678 2019-02-28  Antoine Quint  <graouts@apple.com>
3679
3680         Enable the Pointer Events runtime flag by default
3681         https://bugs.webkit.org/show_bug.cgi?id=195156
3682
3683         Reviewed by Dean Jackson.
3684
3685         * DumpRenderTree/mac/DumpRenderTree.mm:
3686         (enableExperimentalFeatures):
3687
3688 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3689
3690         Several PasteImage API tests are flaky
3691         https://bugs.webkit.org/show_bug.cgi?id=195160
3692
3693         Reviewed by Tim Horton.
3694
3695         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3696         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3697         listening for a "load" event after image load is already complete.
3698
3699         To address this, make these tests first register a "load" event handler, then run script to insert an image
3700         element into the document, and finally wait until the load event is observed before checking image size.
3701
3702         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3703
3704 2019-02-28  Chris Dumez  <cdumez@apple.com>
3705
3706         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3707         https://bugs.webkit.org/show_bug.cgi?id=195107
3708
3709         Reviewed by Alex Christensen.
3710
3711         Give some time for the zoom level to get restored.
3712
3713         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3714
3715 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3716
3717         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3718         https://bugs.webkit.org/show_bug.cgi?id=194958
3719
3720         Reviewed by Geoffrey Garen.
3721
3722         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3723         (TEST):
3724
3725 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3726
3727         [ews-app] Update method to save build to handle builder_display_name
3728         https://bugs.webkit.org/show_bug.cgi?id=195047
3729
3730         Reviewed by Dewei Zhu.
3731
3732         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3733         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3734
3735 2019-02-28  Justin Fan  <justin_fan@apple.com>
3736
3737         [Web GPU] Enable Web GPU only on 64-bit
3738         https://bugs.webkit.org/show_bug.cgi?id=195139
3739
3740         Because Metal is only supported on 64 bit apps.
3741
3742         Unreviewed build fix.
3743
3744         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3745
3746 2019-02-27  Youenn Fablet  <youenn@apple.com>
3747
3748         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3749         https://bugs.webkit.org/show_bug.cgi?id=194959
3750
3751         Reviewed by Chris Dumez.
3752
3753         Spin loop until getting the condition to remove flakiness.
3754
3755         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3756
3757 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3758
3759         [ews-build] Buildbot should include builder_display_name in the build events
3760         https://bugs.webkit.org/show_bug.cgi?id=195045
3761
3762         Reviewed by Dewei Zhu.
3763
3764         * BuildSlaveSupport/ews-build/events.py:
3765         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3766         buildername to builder_name to be consistent in naming style.
3767         (Events.buildFinished): Ditto.
3768
3769 2019-02-27  Chris Dumez  <cdumez@apple.com>
3770
3771         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3772         https://bugs.webkit.org/show_bug.cgi?id=194480
3773
3774         Reviewed by Brady Eidson.
3775
3776         Update existing API test to make it more likely to reproduce the issue.
3777
3778         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3779
3780 2019-02-27  Brady Eidson  <beidson@apple.com>
3781
3782         Universal links from Google search results pages don't open the app.
3783         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3784
3785         Reviewed by Geoffrey Garen.
3786
3787         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3788         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3789         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3790         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3791
3792 2019-02-27  Chris Dumez  <cdumez@apple.com>
3793
3794         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3795         https://bugs.webkit.org/show_bug.cgi?id=195102
3796
3797         Reviewed by Geoffrey Garen.
3798
3799         If the number of processes is not yet what we expect, wait a bit and check again to give
3800         processes some time to exit.
3801
3802         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3803
3804 2019-02-27  Chris Dumez  <cdumez@apple.com>
3805
3806         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3807         https://bugs.webkit.org/show_bug.cgi?id=194545
3808
3809         Reviewed by Brady Eidson.
3810
3811         Make sure the test navigates forward and then back only once. Previously, navigating
3812         back would trigger a navigation again in a timer.
3813
3814         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3815
3816 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3817
3818         High Sierra Debug JSC test queue should use faster hardware
3819         https://bugs.webkit.org/show_bug.cgi?id=194603
3820
3821         Rubber-stamped by Alexey Proskuryakov.
3822
3823         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3824
3825         * BuildSlaveSupport/build.webkit.org-config/config.json:
3826         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3827         (BubbleQueueServer):
3828         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3829         (WebKitBuildbot):
3830         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3831         * QueueStatusServer/config/queues.py:
3832         * Scripts/webkitpy/common/config/ews.json:
3833         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3834         (test_ews_name):
3835
3836 2019-02-27  John Wilander  <wilander@apple.com>
3837
3838         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3839         https://bugs.webkit.org/show_bug.cgi?id=195071
3840         <rdar://problem/48417690>
3841
3842         Reviewed by Alex Christensen and Brent Fulgham.
3843
3844         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3845         (TestWebKitAPI::createURL):
3846             Convenience function.
3847         (TestWebKitAPI::TEST):
3848             WebCore::AdClickAttribution now takes a URL when creating Source and
3849             Destination.
3850         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3851         (TestWebKitAPI::TEST):
3852             WebCore::AdClickAttribution now takes a URL when creating Source and
3853             Destination.
3854
3855 2019-02-27  Antoine Quint  <graouts@apple.com>
3856
3857         Support Pointer Events on macOS
3858         https://bugs.webkit.org/show_bug.cgi?id=195008
3859         <rdar://problem/47454419>
3860
3861         Reviewed by Dean Jackson.
3862
3863         * DumpRenderTree/mac/DumpRenderTree.mm:
3864         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3865         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3866
3867 2019-02-26  Mark Lam  <mark.lam@apple.com>
3868
3869         Remove remaining poisoning code.
3870         https://bugs.webkit.org/show_bug.cgi?id=194138
3871
3872         Reviewed by Saam Barati.
3873
3874         * TestWebKitAPI/CMakeLists.txt:
3875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3876         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3877         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3878         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3879         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3880         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3881         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3882
3883 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3884
3885         Move ephemeral local storage from WebProcess to UIProcess
3886         https://bugs.webkit.org/show_bug.cgi?id=195074
3887         <rdar://problem/47937975>
3888
3889         Reviewed by Geoff Garen.
3890
3891         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3892
3893 2019-02-20  Jer Noble  <jer.noble@apple.com>
3894
3895         [Cocoa] Media elements will restart network buffering just before suspending
3896         https://bugs.webkit.org/show_bug.cgi?id=193691
3897
3898         Reviewed by Eric Carlson.
3899
3900         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3901         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3902         (TEST):
3903
3904 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3905
3906         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3907         https://bugs.webkit.org/show_bug.cgi?id=191652
3908
3909         Reviewed by Alex Christensen.
3910
3911         Fix WinCairo MiniBrowser behavior of authentication dialog.
3912
3913         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3914         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3915
3916 2019-02-26  Youenn Fablet  <youenn@apple.com>
3917
3918         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3919         https://bugs.webkit.org/show_bug.cgi?id=195028
3920         <rdar://problem/48243733>
3921
3922         Reviewed by Eric Carlson.
3923
3924         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3925
3926 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3927
3928         [WPE] Add API for webview background color configuration
3929         https://bugs.webkit.org/show_bug.cgi?id=192305
3930
3931         Reviewed by Michael Catanzaro.
3932
3933         * MiniBrowser/wpe/main.cpp:
3934         (main): Add a new option to configure the webview background
3935         color. Example: --bg-color=transparent.
3936         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3937         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3938         (beforeAll): Ditto.
3939
3940 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3941
3942         scalableNativeWebpageParameters() is not preserved on new page navigation.
3943         https://bugs.webkit.org/show_bug.cgi?id=194892
3944         <rdar://problem/47538280>
3945
3946         Reviewed by Wenson Hsieh.
3947         
3948         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3949
3950         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3951         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3952         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3953         (WTR::UIScriptController::allowsViewportShrinkToFit):
3954         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3955         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3956         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3957         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3958         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3959         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3960
3961 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3962
3963         [ews-app] Add model for handling multiple Buildbot instances
3964         https://bugs.webkit.org/show_bug.cgi?id=194863
3965
3966         Reviewed by Stephanie Lewis.
3967
3968         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3969
3970 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3971
3972         [ews-app] Remove BuilderMapping table
3973         https://bugs.webkit.org/show_bug.cgi?id=194961
3974
3975         Reviewed by Stephanie Lewis.
3976
3977         Store builder name directly in build table, instead of having a separate
3978         table for it.
3979
3980         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3981         * BuildSlaveSupport/ews-app/ews/models/build.py:
3982         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3983         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3984
3985 2019-02-25  John Wilander  <wilander@apple.com>
3986
3987         Introduce and adopt new class RegistrableDomain for eTLD+1
3988         https://bugs.webkit.org/show_bug.cgi?id=194791
3989         <rdar://problem/48179240>
3990
3991         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3992
3993         This patch adds an API test and replaces two instances of
3994         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3995
3996         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3997         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3998         (TestWebKitAPI::TEST):
3999             Changed two strings to make sure the registrable domains are still considered
4000             invalid and pass the test.
4001         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4002         (TestWebKitAPI::TEST):
4003         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4004         (WTR::InjectedBundle::didReceiveMessageToPage):
4005
4006 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4007
4008         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4009         https://bugs.webkit.org/show_bug.cgi?id=195001
4010
4011         Reviewed by Carlos Garcia Campos.
4012
4013         API version 1.0 always includes the functionality previously guarded with
4014         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4015         unconditionally.
4016
4017         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4018         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4019         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4020         (WebViewTest::showInWindow): Ditto.
4021         (WebViewTest::hideView): Ditto.
4022         * wpe/backends/HeadlessViewBackend.cpp:
4023         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4024         * wpe/backends/ViewBackend.cpp:
4025         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4026         * wpe/backends/WindowViewBackend.cpp:
4027         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4028         WPE_BACKEND_CHECK_VERSION().
4029         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4030
4031 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4032
4033         [Flatpak] Add support for flatpak > 1.1.2
4034         https://bugs.webkit.org/show_bug.cgi?id=194088
4035
4036         Flatpak 1.2 is now out so we need to support that
4037         version now.
4038
4039         Reviewed by Michael Catanzaro.
4040
4041         * flatpak/flatpakutils.py:
4042         (check_flatpak):
4043         (FlatpakPackages.__init__):
4044         (FlatpakPackages.__detect_packages):
4045         (FlatpakPackages.__detect_packages.in):
4046         (FlatpakRepos.update):
4047
4048 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4049
4050         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4051         https://bugs.webkit.org/show_bug.cgi?id=194998
4052
4053         Reviewed by Carlos Garcia Campos.
4054
4055         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4056         to a Git checkout and using the latest commit containing various fixes
4057         and improvements.
4058
4059 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4060
4061         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4062         https://bugs.webkit.org/show_bug.cgi?id=194981
4063
4064         Reviewed by Žan Doberšek.
4065
4066         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4067         (TestWebKitAPI::TEST):
4068
4069 2019-02-23  Keith Miller  <keith_miller@apple.com>
4070
4071         Add new mac target numbers
4072         https://bugs.webkit.org/show_bug.cgi?id=194955
4073
4074         Reviewed by Tim Horton.
4075
4076         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4077         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4078         * MiniBrowser/Configurations/Base.xcconfig:
4079         * TestWebKitAPI/Configurations/Base.xcconfig:
4080         * WebKitTestRunner/Configurations/Base.xcconfig:
4081
4082 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4083
4084         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4085         https://bugs.webkit.org/show_bug.cgi?id=194846
4086
4087         Reviewed by Don Olmstead.
4088
4089         Added _search_paths() and _port_specific_expectations_files() for
4090         WinCairoPort.
4091
4092         * Scripts/webkitpy/port/win.py:
4093         (WinCairoPort.default_baseline_search_path):
4094         (WinCairoPort):
4095         (WinCairoPort._port_specific_expectations_files):
4096         (WinCairoPort._search_paths):
4097
4098 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4099
4100         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4101         https://bugs.webkit.org/show_bug.cgi?id=194963
4102
4103         Reviewed by Dean Jackson.
4104
4105         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4106         Do a `contains` check instead of `equals`, because in debug builds we
4107         put the GraphicsLayer pointer in a prefix.
4108
4109 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4110
4111         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4112         https://bugs.webkit.org/show_bug.cgi?id=194873
4113         <rdar://problem/46701974>
4114
4115         Reviewed by Tim Horton.
4116
4117         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4118
4119         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4120         (WTR::UIScriptController::menuRect const):
4121         (WTR::UIScriptController::isShowingMenu const):
4122         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4123         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4124         (WTR::UIScriptController::menuRect const):
4125
4126         Add a function to query the bounds of the callout menu in content coordinates.
4127
4128         (WTR::UIScriptController::isShowingMenu const):
4129
4130         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4131
4132         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4133         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4134         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4135         (WTR::UIScriptController::rectForMenuAction const):
4136         (WTR::UIScriptController::menuRect const):
4137         (WTR::UIScriptController::isShowingMenu const):
4138         (WTR::findViewInHierarchyOfType): Deleted.
4139
4140 2019-02-22  Chris Dumez  <cdumez@apple.com>
4141
4142         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4143         https://bugs.webkit.org/show_bug.cgi?id=194954
4144         <rdar://problem/48127957>
4145
4146         Reviewed by Alex Christensen.
4147
4148         Add API test coverage.
4149
4150         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4151         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4152         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4153         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4154
4155 2019-02-22  Chris Dumez  <cdumez@apple.com>
4156
4157         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4158         https://bugs.webkit.org/show_bug.cgi?id=194924
4159         <rdar://problem/48216125>
4160
4161         Reviewed by Geoffrey Garen.
4162
4163         Add API test coverage.
4164
4165         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4166
4167 2019-02-22  Chris Dumez  <cdumez@apple.com>
4168
4169         Unreviewed, disable API test added in r241928 on iOS.
4170
4171         The cache is not enabled on devices with less than 3GB of RAM.
4172
4173         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4174
4175 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4176
4177         Hardcode Visual Viewports on everywhere except iOS WK1
4178         https://bugs.webkit.org/show_bug.cgi?id=194928
4179
4180         Reviewed by Zalan Bujtas.
4181
4182         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4183         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4184         set it to false. The setting has shipped for several years and there's no need to turn
4185         it off now.
4186
4187         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4188         Visual Viewports are not enabled.
4189         
4190         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4191         that only runs in WK2
4192
4193         * MiniBrowser/mac/SettingsController.h:
4194         * MiniBrowser/mac/SettingsController.m:
4195         (-[SettingsController init]):
4196         (-[SettingsController _populateMenu]):
4197         (-[SettingsController validateMenuItem:]):
4198         (-[SettingsController visualViewportEnabled]): Deleted.
4199         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4200         * MiniBrowser/mac/WK1BrowserWindowController.m:
4201         (-[WK1BrowserWindowController didChangeSettings]):
4202         * MiniBrowser/mac/WK2BrowserWindowController.m:
4203         (-[WK2BrowserWindowController didChangeSettings]):
4204
4205 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4206
4207         Discard cached processes when clearing website data store
4208         https://bugs.webkit.org/show_bug.cgi?id=194894
4209
4210         Reviewed by Chris Dumez.
4211
4212         Added a test case.
4213
4214         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4215         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4216
4217 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4218
4219         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4220         https://bugs.webkit.org/show_bug.cgi?id=194914
4221         <rdar://problem/47586889>
4222
4223         Reviewed by Geoffrey Garen.
4224
4225         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4226         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4227         (TEST):
4228         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4229
4230 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4231
4232         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4233         <https://webkit.org/b/194761>
4234
4235         Reviewed by Myles Maxfield.
4236
4237         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4238         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4239         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4240         to use ARC-compliant cast.
4241         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4242         ARC-compliant cast.
4243         (WTR::installFakeHelvetica): Log `error` to console if
4244         CTFontManagerRegisterFontsForURL() fails, but only on supported
4245         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4246         Call CFRelease() on `error` to fix the leak.  Update to use
4247         ARC-compliant cast.
4248         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4249         cast.
4250
4251 2019-02-21  Chris Dumez  <cdumez@apple.com>
4252
4253         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4254         https://bugs.webkit.org/show_bug.cgi?id=194481
4255
4256         Reviewed by Alex Christensen.
4257
4258         Give the processes a chance to shutdown and wait until we reached the expected number
4259         of processes.
4260
4261         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4262
4263 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4264
4265         Fix the macOS build
4266
4267         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4268
4269 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4270
4271         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4272
4273         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4274         I am a backwards.
4275
4276 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4277
4278         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4279
4280         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4281         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4282         We could force on UI-side compositing, but I feel like the test might be more
4283         valuable exercising the normal path on each platform (though the original
4284         bug was also UI-side specific). Though we can't validate that the overlay
4285         layer was installed successfully, there are layout tests that do that.
4286
4287 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4288
4289         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4290         https://bugs.webkit.org/show_bug.cgi?id=194845
4291         <rdar://problem/47944579>
4292
4293         Reviewed by Antti Koivisto.
4294
4295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4296         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4297
4298 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4299
4300         [LFC][Floats] Add support for placing formatting roots in-between floats.
4301         https://bugs.webkit.org/show_bug.cgi?id=194902
4302
4303         Reviewed by Antti Koivisto.
4304
4305         * LayoutReloaded/misc/LFC-passing-tests.txt:
4306
4307 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4308
4309         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4310         https://bugs.webkit.org/show_bug.cgi?id=194901
4311
4312         Unreviewed build fix.
4313
4314         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4315         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4316         WPEBackend-fdo-0.1 as library name.
4317
4318 2019-02-21  Rob Buis  <rbuis@igalia.com>
4319
4320         Update MIME type parser
4321         https://bugs.webkit.org/show_bug.cgi?id=180526
4322
4323         Reviewed by Darin Adler.
4324
4325         Add tests involving leading and trailing whitespace, non-token
4326         characters and quoted strings.
4327
4328         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4329         (TestWebKitAPI::TEST):
4330
4331 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4332
4333         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4334         https://bugs.webkit.org/show_bug.cgi?id=194884
4335
4336         Reviewed by Michael Catanzaro.
4337
4338         * PlatformWin.cmake:
4339
4340 2019-02-20  Chris Dumez  <cdumez@apple.com>
4341
4342         Add API test for <rdar://problem/47471222>
4343         https://bugs.webkit.org/show_bug.cgi?id=194847
4344
4345         Reviewed by Alex Christensen.
4346
4347         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4348
4349 2019-02-20  Chris Dumez  <cdumez@apple.com>
4350
4351         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4352         https://bugs.webkit.org/show_bug.cgi?id=194872
4353         <rdar://problem/47924500>
4354
4355         Reviewed by Alex Christensen.
4356
4357         Add API test coverage.
4358
4359         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4360
4361 2019-02-20  Jer Noble  <jer.noble@apple.com>
4362
4363         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4364         https://bugs.webkit.org/show_bug.cgi?id=191332
4365
4366         Reviewed by Dean Jackson.
4367
4368         * Scripts/git-is-in-range: Added.
4369
4370 2019-02-20  Andy Estes  <aestes@apple.com>
<