iOS 12 Simulator Release WK2 frequently timing out while running layout tests
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2
3         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
4         https://bugs.webkit.org/show_bug.cgi?id=196694
5         <rdar://problem/48388734>
6
7         Rubber-stamped by Aakash Jain.
8
9         * Scripts/webkitpy/port/image_diff.py:
10         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
11         * Scripts/webkitpy/port/server_process.py:
12         (ServerProcess.has_available_stdout): Check if stdout has data in it.
13         (ServerProcess._wait_for_data_and_update_buffers_using_select):
14         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
15         * Scripts/webkitpy/port/server_process_mock.py:
16         (MockServerProcess.has_available_stdout):
17         * Scripts/webkitpy/port/server_process_unittest.py:
18         (TestServerProcess.serial_test_basic):
19
20 2019-04-09  Jer Noble  <jer.noble@apple.com>
21
22         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
23         https://bugs.webkit.org/show_bug.cgi?id=196097
24
25         Reviewed by Eric Carlson.
26
27         Drive-by bug fix: allow tests to play audio without a user gesture by default.
28
29         * DumpRenderTree/mac/DumpRenderTree.mm:
30         (resetWebPreferencesToConsistentValues):
31         * WebKitTestRunner/TestController.cpp:
32         (WTR::TestController::resetPreferencesToConsistentValues):
33
34 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
35
36         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
37         https://bugs.webkit.org/show_bug.cgi?id=196690
38
39         Reviewed by Michael Catanzaro.
40
41         * QueueStatusServer/config/queues.py:
42         * Scripts/webkitpy/common/config/ews.json:
43         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
44         (test_ews_name):
45
46 2019-04-09  Chris Dumez  <cdumez@apple.com>
47
48         Loads using loadHTMLString() cause flashing when process-swapping
49         https://bugs.webkit.org/show_bug.cgi?id=196714
50         <rdar://problem/49637354>
51
52         Reviewed by Antti Koivisto.
53
54         Add API test coverage.
55
56         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
57
58 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
59
60         Unreviewed. Fix ATK accessibility tests after r244059.
61
62         We are failing to load the injected bundle due to undefined symbol
63         AccessibilityUIElement::replaceTextInRange().
64
65         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
66         (WTR::AccessibilityUIElement::replaceTextInRange):
67
68 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
69
70         AX: Support API: accessibilityReplaceRange:withText
71         https://bugs.webkit.org/show_bug.cgi?id=196636
72
73         Unreviewed build fix for Windows port.
74
75         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
76         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
77
78 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
79
80         [CMake][WinCairo] Separate copied headers into different directories
81         https://bugs.webkit.org/show_bug.cgi?id=196655
82
83         Reviewed by Michael Catanzaro.
84
85         * DumpRenderTree/CMakeLists.txt:
86         * MiniBrowser/win/CMakeLists.txt:
87         * TestWebKitAPI/CMakeLists.txt:
88         * TestWebKitAPI/PlatformWin.cmake:
89
90 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
91
92         Log stack-trace for run-webkit-tests when interrupted
93         https://bugs.webkit.org/show_bug.cgi?id=176393
94         <rdar://problem/34262310>
95
96         Reviewed by Lucas Forschler.
97
98         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
99         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
100         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
101         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
102         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
103         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
104         (main): Set handlers to log stack trace on interruption.
105
106 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
107
108         AX: Support API: accessibilityReplaceRange:withText
109         https://bugs.webkit.org/show_bug.cgi?id=196636
110
111         Unreviewed build fix for Windows port.
112
113         * DumpRenderTree/AccessibilityUIElement.cpp:
114         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
115
116 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
117
118         [ews-build] Scripts using Buildbot API have CORS error
119         https://bugs.webkit.org/show_bug.cgi?id=196709
120
121         Reviewed by Alexey Proskuryakov.
122
123         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
124
125 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
126
127         AX: Support API: accessibilityReplaceRange:withText
128         https://bugs.webkit.org/show_bug.cgi?id=196636
129
130         Reviewed by Daniel Bates.
131
132         * DumpRenderTree/AccessibilityUIElement.cpp:
133         (replaceTextInRangeCallback):
134         (AccessibilityUIElement::replaceTextInRange):
135         (AccessibilityUIElement::getJSClass):
136         * DumpRenderTree/AccessibilityUIElement.h:
137         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
138         (AccessibilityUIElement::replaceTextInRange):
139         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
140         (AccessibilityUIElement::replaceTextInRange):
141         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
142         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
143         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
144         (WTR::AccessibilityUIElement::replaceTextInRange):
145         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
146         (WTR::AccessibilityUIElement::replaceTextInRange):
147
148 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
149
150         [iOS] Do not allow starting selection drags when selection views are not visible
151         https://bugs.webkit.org/show_bug.cgi?id=196686
152         <rdar://problem/49399192>
153
154         Reviewed by Tim Horton.
155
156         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
157         also add some new API tests to cover scenarios where the web view is not first responder.
158
159         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
160         (TestWebKitAPI::TEST):
161         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
162
163         Add a switch to optionally make the web view first responder when starting the simulated drag.
164
165         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
166         (-[DragAndDropSimulator initWithWebView:]):
167         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
168
169 2019-04-08  Justin Fan  <justin_fan@apple.com>
170
171         [Web GPU] Fix Web GPU experimental feature on iOS
172         https://bugs.webkit.org/show_bug.cgi?id=196632
173
174         Reviewed by Myles C. Maxfield.
175
176         Properly make Web GPU available on iOS 11+.
177
178         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
179
180 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
181
182         [ews-build] Do not upload archive when Compile Fails
183         https://bugs.webkit.org/show_bug.cgi?id=196674
184
185         Reviewed by Alexey Proskuryakov.
186
187         * BuildSlaveSupport/ews-build/factories.py:
188         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
189         * BuildSlaveSupport/ews-build/steps.py:
190         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
191         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
192         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
193
194 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
195
196         Enable DFG on MIPS
197         https://bugs.webkit.org/show_bug.cgi?id=196689
198
199         Reviewed by Žan Doberšek.
200
201         Since the bytecode change, we enabled the baseline JIT on mips in
202         r240432, but DFG is still missing. With this change, all tests are
203         passing on a ci20 board.
204
205         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
206
207 2019-04-08  Philippe Normand  <pnormand@igalia.com>
208
209         [Flatpak] Second run update-webkitwpe-flatpak fails
210         https://bugs.webkit.org/show_bug.cgi?id=192702
211
212         Reviewed by Carlos Garcia Campos.
213
214         * flatpak/flatpakutils.py:
215         (FlatpakObject.flatpak): Fix typo.
216         (FlatpakPackage.install): When installing, also update to the configured remote commit.
217         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
218
219 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
220
221         [GTK][WPE] outlook.live.com displays old-fashioned UI
222         https://bugs.webkit.org/show_bug.cgi?id=196642
223
224         Reviewed by Carlos Garcia Campos.
225
226         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
227         (TestWebKitAPI::TEST): New Mac platform quirk test.
228
229 2019-04-07  Commit Queue  <commit-queue@webkit.org>
230
231         Unreviewed, rolling out r243956.
232         https://bugs.webkit.org/show_bug.cgi?id=196688
233
234         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
235         by aakashjain on #webkit).
236
237         Reverted changeset:
238
239         "Clicking "Go Back" from a safe browsing warning from an
240         iframe should navigate the WKWebView back to the previous
241         page"
242         https://bugs.webkit.org/show_bug.cgi?id=196665
243         https://trac.webkit.org/changeset/243956
244
245 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
246
247         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
248         https://bugs.webkit.org/show_bug.cgi?id=196669
249
250         Reviewed by Geoffrey Garen.
251
252         Added three new unit tests for WeakHashSet.
253
254         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
255         (WTF_WeakPtr.WeakHashSetConstObjects):
256         (WTF_WeakPtr.WeakHashSetComputesEmpty):
257         (WTF_WeakPtr.WeakHashSetComputeSize):
258
259 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
260
261         Hide next and previous form control buttons when WKWebView is editable
262         https://bugs.webkit.org/show_bug.cgi?id=196672
263         <rdar://problem/35625321>
264
265         Reviewed by Tim Horton.
266
267         Add a new API test.
268
269         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
270         (-[TestWKWebView lastTrailingBarButtonGroup]):
271         (TestWebKitAPI::TEST):
272         * TestWebKitAPI/ios/UIKitSPI.h:
273
274 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
275
276         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
277         https://bugs.webkit.org/show_bug.cgi?id=196077
278         <rdar://problem/49108202>
279
280         Reviewed by Chris Dumez.
281
282         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
283         on new web view.
284
285         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
286
287 2019-04-05  Saam Barati  <sbarati@apple.com>
288
289         Make compare-results understand MotionMark
290         https://bugs.webkit.org/show_bug.cgi?id=196666
291
292         Reviewed by Yusuke Suzuki.
293
294         * Scripts/compare-results:
295         (PLT5Results):
296         (detectMotionMark):
297         (detectMotionMark1_1):
298         (motionMarkResults):
299         (motionMark1_1Results):
300         (detectBenchmark):
301         (biggerIsBetter):
302         (main):
303
304 2019-04-05  Alex Christensen  <achristensen@webkit.org>
305
306         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
307         https://bugs.webkit.org/show_bug.cgi?id=196665
308         <rdar://45115669>
309
310         Reviewed by Geoff Garen.
311
312         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
313         (goBack):
314         (+[SimpleLookupContext sharedLookupContext]):
315         (-[SimpleLookupContext lookUpURL:completionHandler:]):
316         (TEST):
317         (+[Simple3LookupContext sharedLookupContext]): Deleted.
318         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
319
320 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
321
322         [ews-build] Add configuration and architecture for windows builders
323         https://bugs.webkit.org/show_bug.cgi?id=196660
324
325         Reviewed by Lucas Forschler.
326
327         * BuildSlaveSupport/ews-build/config.json:
328
329 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
330
331         webkitpy: Don't run subsequent rounds if interrupted
332         https://bugs.webkit.org/show_bug.cgi?id=196646
333
334         Reviewed by Aakash Jain.
335
336         * Scripts/webkitpy/layout_tests/controllers/manager.py:
337         (Manager.run): Bail out if interrupted.
338
339 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
340
341         Test sessionStorage in PSON private browsing mode
342         https://bugs.webkit.org/show_bug.cgi?id=196561
343
344         Reviewed by Alex Christensen.
345
346         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
347
348 2019-04-05  Commit Queue  <commit-queue@webkit.org>
349
350         Unreviewed, rolling out r243833.
351         https://bugs.webkit.org/show_bug.cgi?id=196645
352
353         This change breaks build of WPE and GTK ports (Requested by
354         annulen on #webkit).
355
356         Reverted changeset:
357
358         "[CMake][WTF] Mirror XCode header directories"
359         https://bugs.webkit.org/show_bug.cgi?id=191662
360         https://trac.webkit.org/changeset/243833
361
362 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
363
364         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
365         https://bugs.webkit.org/show_bug.cgi?id=196635
366
367         Reviewed by Antti Koivisto.
368         
369         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
370         for a test to enable async frame scrolling via:
371             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
372         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
373         
374         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
375
376         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
377         (WTR::InjectedBundle::beginTesting):
378         * WebKitTestRunner/TestController.cpp:
379         (WTR::TestController::resetPreferencesToConsistentValues):
380
381 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
382
383         Use a correct LC_RPATH when building with ASan
384         https://bugs.webkit.org/show_bug.cgi?id=196576
385
386         Reviewed by David Kilzer.
387
388         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
389         so that ../Frameworks is checked. This is simpler and more reliable than updating
390         each SPC service xcconfig.
391
392 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
393
394         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
395         https://bugs.webkit.org/show_bug.cgi?id=196629
396
397         Reviewed by Lucas Forschler.
398
399         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
400
401 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
402
403         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
404         https://bugs.webkit.org/show_bug.cgi?id=196618
405
406         Reviewed by Lucas Forschler.
407
408         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
409         (StatusBubble): Added QUEUE_TRIGGERS.
410         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
411         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
412         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
413         its parent(builder).
414
415 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
416
417         [ews-app] Status-bubble steps are sometimes displayed in reverse order
418         https://bugs.webkit.org/show_bug.cgi?id=196625
419
420         Reviewed by Lucas Forschler.
421
422         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
423         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
424
425 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
426
427         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
428         https://bugs.webkit.org/show_bug.cgi?id=196630
429
430         Reviewed by Wenson Hsieh.
431
432         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
433
434 2019-04-04  Youenn Fablet  <youenn@apple.com>
435
436         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
437         https://bugs.webkit.org/show_bug.cgi?id=196543
438
439         Reviewed by Alex Christensen.
440
441         * WebKitTestRunner/TestController.cpp:
442         (WTR::TestController::generatePageConfiguration):
443
444 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
445
446         [ews-app] Status bubble should not display skipped buildbot steps
447         https://bugs.webkit.org/show_bug.cgi?id=196584
448
449         Reviewed by Lucas Forschler.
450
451         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
452
453 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
454
455         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
456         https://bugs.webkit.org/show_bug.cgi?id=196620
457
458         Reviewed by Lucas Forschler.
459
460         * BuildSlaveSupport/ews-app/ews/config.py:
461
462 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
463
464         [Win] DumpRenderTreeWatchDog.py is not checked into source
465         https://bugs.webkit.org/show_bug.cgi?id=196567
466         <rdar://problem/49525901>
467
468         Reviewed by Lucas Forschler.
469
470         This script is used on Win EWS bots to terminate hanging DRT processes.
471
472         * EWSTools/dumprendertreewatchdog.py: Added.
473
474 2019-04-04  Chris Dumez  <cdumez@apple.com>
475
476         Unreviewed, roll out r243858 which made tests time out.
477
478         Disable new API tests on Windows instead.
479
480         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
481         (TestWebKitAPI::TEST):
482
483 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
484
485         [ATK] Cleanup WebPageAccessibilityObjectAtk
486         https://bugs.webkit.org/show_bug.cgi?id=196537
487
488         Reviewed by Michael Catanzaro.
489
490         Also consider files under atk directories as exceptions for GObject conventions.
491
492         * Scripts/webkitpy/style/checkers/cpp.py:
493         (check_identifier_name_in_declaration):
494
495 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
496
497         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
498         https://bugs.webkit.org/show_bug.cgi?id=196588
499         <rdar://problem/49365787>
500
501         Unreviewed build fix for Windows port.
502
503         error C3861: 'kill': identifier not found
504
505         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
506         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
507
508 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
509
510         [ews-build] Cancel build and similar operations should have authentication
511         https://bugs.webkit.org/show_bug.cgi?id=196520
512
513         Reviewed by Dewei Zhu.
514
515         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
516         environment variables.
517
518 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
519
520         [ews-build] Do not trigger queues which are not in production yet
521         https://bugs.webkit.org/show_bug.cgi?id=196581
522
523         Reviewed by Dewei Zhu.
524
525         * BuildSlaveSupport/ews-build/config.json:
526
527 2019-04-03  Chris Dumez  <cdumez@apple.com>
528
529         Unreviewed, fix typo in the name of API test added in r243848.
530
531         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
532         (TestWebKitAPI::TEST):
533
534 2019-04-03  Chris Dumez  <cdumez@apple.com>
535
536         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
537         https://bugs.webkit.org/show_bug.cgi?id=196588
538         <rdar://problem/49365787>
539
540         Reviewed by Ryosuke Niwa.
541
542         Add API test coverage.
543
544         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
545         (TestWebKitAPI::nullJavaScriptCallback):
546         (TestWebKitAPI::didCrashCheckFrames):
547         (TestWebKitAPI::TEST):
548
549 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
550
551         run-webkit-tests: Upload test results (new results database)
552         https://bugs.webkit.org/show_bug.cgi?id=196577
553         <rdar://problem/34841155>
554
555         Reviewed by Lucas Forschler.
556
557         * Scripts/webkitpy/layout_tests/controllers/manager.py:
558         (Manager.run): Upload results after each device shard, since the configuration will be
559         different for each device.
560         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
561         uploaded to a results database.
562         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
563         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
564
565 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
566
567         -apple-trailing-word is needed for browser detection
568         https://bugs.webkit.org/show_bug.cgi?id=196575
569
570         Unreviewed.
571
572         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
573
574 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
575
576         [CMake][WTF] Mirror XCode header directories
577         https://bugs.webkit.org/show_bug.cgi?id=191662
578
579         Reviewed by Konstantin Tokarev.
580
581         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
582         builds.
583
584         * CMakeLists.txt:
585         * DumpRenderTree/CMakeLists.txt:
586         * DumpRenderTree/PlatformWin.cmake:
587         * MiniBrowser/win/CMakeLists.txt:
588         * TestWebKitAPI/CMakeLists.txt:
589         * TestWebKitAPI/PlatformWin.cmake:
590         * WebKitTestRunner/PlatformGTK.cmake:
591         * WebKitTestRunner/PlatformWin.cmake:
592
593 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
594
595         [ews-app] Status bubble should not display certain infrastructure status messages
596         https://bugs.webkit.org/show_bug.cgi?id=196550
597
598         Reviewed by Lucas Forschler.
599
600         Do not display the steps which are un-needed for end-user. This information is still avaiable
601         if the user click on the bubble and look at the Buildbot build.
602         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
603         (StatusBubble._steps_messages):
604         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
605
606 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
607
608         [ews-build] Use https for sending data to ews-app
609         https://bugs.webkit.org/show_bug.cgi?id=196492
610
611         Reviewed by Lucas Forschler.
612
613         * BuildSlaveSupport/ews-build/events.py:
614
615 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
616
617         Remove support for -apple-trailing-word
618         https://bugs.webkit.org/show_bug.cgi?id=196525
619
620         Reviewed by Zalan Bujtas.
621
622         This CSS property is nonstandard and not used.
623
624         * Scripts/webkitperl/FeatureList.pm:
625         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
626
627 2019-04-03  Youenn Fablet  <youenn@apple.com>
628
629         Add a test for DOMCache on multiple browsing in case of private browsing
630         https://bugs.webkit.org/show_bug.cgi?id=196524
631
632         Reviewed by Alex Christensen.
633
634         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
635         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
636
637 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
638
639         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
640         https://bugs.webkit.org/show_bug.cgi?id=196540
641
642         Reviewed by Aakash Jain.
643
644         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
645
646 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
647
648         Add plumbing for a compatibility mode preference in WebKit
649         https://bugs.webkit.org/show_bug.cgi?id=196005
650
651         Reviewed by Tim Horton.
652
653         Add new API tests.
654
655         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
656         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
657
658 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
659
660         [WPE][GTK] Update libsrtp dependency package for Debian
661         https://bugs.webkit.org/show_bug.cgi?id=196528
662
663         Reviewed by Frédéric Wang.
664
665         * gtk/install-dependencies:
666         * wpe/install-dependencies:
667
668 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
669
670         [WK2] Add support for Window's beforeprint / afterprint events
671         https://bugs.webkit.org/show_bug.cgi?id=196478
672         <rdar://problem/49535124>
673
674         Unreviewed build fix for MSVC.
675
676         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
677
678         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
679
680         * WebKitTestRunner/TestController.cpp:
681         (WTR::printFrame): Use int and float literals.
682
683 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
684
685         [ews-build] Reassign bots to queues
686
687         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
688
689 2019-04-02  Chris Dumez  <cdumez@apple.com>
690
691         [WK2] Add support for Window's beforeprint / afterprint events
692         https://bugs.webkit.org/show_bug.cgi?id=196478
693
694         Reviewed by Alex Christensen.
695
696         Add minimal implementation for printFrame in WebKitTestRunner.
697
698         * WebKitTestRunner/TestController.cpp:
699         (WTR::printFrame):
700         (WTR::TestController::createOtherPage):
701         (WTR::TestController::createWebViewWithOptions):
702
703 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
704
705         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
706         https://bugs.webkit.org/show_bug.cgi?id=196491
707
708         Reviewed by Lucas Forschler.
709
710         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
711
712 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
713
714         [ews-build] Configure buildbot try credentials in environment variables
715         https://bugs.webkit.org/show_bug.cgi?id=196501
716
717         Reviewed by Lucas Forschler.
718
719         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
720         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
721         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
722
723 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
724
725         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
726         https://bugs.webkit.org/show_bug.cgi?id=196496
727         <rdar://problem/49521634>
728
729         Reviewed by Chris Dumez.
730
731         Add new API tests (see WebKit ChangeLog for more detail).
732
733         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
734         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
735         (TEST):
736
737 2019-04-02  David Kilzer  <ddkilzer@apple.com>
738
739         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
740         <https://webkit.org/b/196499>
741
742         Reviewed by Alexey Proskuryakov.
743
744         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
745         ENABLE_ADDRESS_SANITIZER.
746
747 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
748
749         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
750         https://bugs.webkit.org/show_bug.cgi?id=182757
751
752         Reviewed by Don Olmstead.
753
754         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
755         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
756
757 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
758
759         run-api-tests: Upload test results
760         https://bugs.webkit.org/show_bug.cgi?id=196323
761         <rdar://problem/49356714>
762
763         Reviewed by Lucas Forschler.
764
765         * Scripts/webkitpy/api_tests/manager.py:
766         (Manager):
767         (Manager.run): Upload results to a results database.
768         * Scripts/webkitpy/api_tests/run_api_tests.py:
769         (parse_args): Add upload arguments.
770         * Scripts/webkitpy/port/base.py:
771         (Port):
772         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
773         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
774         with commits from any other associated repositories.
775         * Scripts/webkitpy/port/device.py:
776         (Device):
777         (Device.build_version): Access build_versoin of underlying platform device.
778         * Scripts/webkitpy/port/ios_simulator_unittest.py:
779         (IOSSimulatorTest):
780         (IOSSimulatorTest.test_configuration_for_upload):
781         * Scripts/webkitpy/port/device_port.py:
782         (DevicePort):
783         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
784         the same as the machine uploading results.
785         * Scripts/webkitpy/port/mac.py:
786         (MacPort):
787         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
788         * Scripts/webkitpy/port/mac_unittest.py:
789         (MacTest):
790         (MacTest.test_configuration_for_upload):
791         * Scripts/webkitpy/xcode/simulated_device.py:
792         (SimulatedDeviceManager._create_device_with_runtime):
793         (SimulatedDevice.__init__): Create simulated device with a build_version.
794         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
795         (test_existing_simulator):
796
797 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
798
799         Remove extra newline characters (Follow-up fix to r243707)
800
801         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
802
803 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
804
805         [ews-app] Use API_KEY to accept results data
806         https://bugs.webkit.org/show_bug.cgi?id=196461
807
808         Reviewed by Dewei Zhu.
809
810         * BuildSlaveSupport/ews-app/ews/views/results.py:
811         (Results.post): Validate EWS_API_KEY before accepting any data.
812         * BuildSlaveSupport/ews-build/events.py:
813         (Events.sendData): Send EWS_API_KEY if available along with event data.
814
815 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
816
817         Unable to copy and paste a PDF from Notes into Mail compose body
818         https://bugs.webkit.org/show_bug.cgi?id=196442
819         <rdar://problem/48573098>
820
821         Reviewed by Tim Horton.
822
823         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
824         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
825         to be specified on the item providers.
826
827         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
828         (TestWebKitAPI::mapItemForTesting):
829         (TestWebKitAPI::contactItemForTesting):
830
831 2019-04-01  Tim Horton  <timothy_horton@apple.com>
832
833         Make UIWKDocumentContext rects per-character instead of per-word
834         https://bugs.webkit.org/show_bug.cgi?id=196459
835
836         Reviewed by Wenson Hsieh.
837
838         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
839         (TEST):
840         Adjust test results due to switching to per-character rects.
841
842 2019-04-01  Chris Dumez  <cdumez@apple.com>
843
844         UIProcess crash when a prewarmed process is terminated
845         https://bugs.webkit.org/show_bug.cgi?id=196451
846         <rdar://problem/49245471>
847
848         Reviewed by Geoffrey Garen.
849
850         Add API test coverage.
851
852         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
853         (TEST):
854
855 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
856
857         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
858         https://bugs.webkit.org/show_bug.cgi?id=196449
859
860         Reviewed by Lucas Forschler.
861
862         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
863         (StatusBubble.get_os_details): Method to get OS and Xcode details.
864         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
865         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
866
867 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
868
869         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
870         https://bugs.webkit.org/show_bug.cgi?id=196444
871
872         Reviewed by Lucas Forschler.
873
874         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
875
876 2019-04-01  Alex Christensen  <achristensen@webkit.org>
877
878         Add SPI to canonicalize NSURLs with WTF::URL
879         https://bugs.webkit.org/show_bug.cgi?id=196415
880         <rdar://problem/44980271>
881
882         Reviewed by Darin Adler.
883
884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
885         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
886         (TestWebKitAPI::TEST):
887
888 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
889
890         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
891         https://bugs.webkit.org/show_bug.cgi?id=196441
892
893         Reviewed by Carlos Garcia Campos.
894
895         Don't cache the wpe_view_backend object that might not exist yet at the
896         time of EventSenderProxy constructor invocation, but instead retrieve
897         that object whenever it's required for event dispatching. This should
898         avoid crashes in this constructor now that it's invoked before any
899         PlatformWindow has been set up (as changed in r243496).
900
901         * WebKitTestRunner/EventSenderProxy.h:
902         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
903         (WTR::viewBackend):
904         (WTR::EventSenderProxy::EventSenderProxy):
905         (WTR::EventSenderProxy::mouseDown):
906         (WTR::EventSenderProxy::mouseUp):
907         (WTR::EventSenderProxy::mouseMoveTo):
908         (WTR::EventSenderProxy::mouseScrollBy):
909         (WTR::EventSenderProxy::keyDown):
910         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
911
912 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
913
914         [Win][WebKit] MiniBrowser should support high DPI display
915         https://bugs.webkit.org/show_bug.cgi?id=196391
916
917         Reviewed by Alex Christensen.
918
919         * MiniBrowser/win/WebKitBrowserWindow.cpp:
920         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
921         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
922         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
923
924 2019-03-31  Sam Weinig  <weinig@apple.com>
925
926         Remove more i386 specific configurations
927         https://bugs.webkit.org/show_bug.cgi?id=196430
928
929         Reviewed by Alexey Proskuryakov.
930
931         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
932         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
933
934 2019-03-31  Andy Estes  <aestes@apple.com>
935
936         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
937         https://bugs.webkit.org/show_bug.cgi?id=196433
938         <rdar://problem/49293305>
939
940         Reviewed by Tim Horton.
941
942         Enhanced API test coverage to include all navigation response policy decisions in both
943         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
944
945         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
946         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
947         (TestWebKitAPI::TEST):
948         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
949         (readFile):
950         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
951         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
952         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
953         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
954         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
955         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
956         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
957         (-[QuickLookDelegate _downloadDidStart:]):
958         (-[QuickLookDelegate _download:didReceiveResponse:]):
959         (-[QuickLookDelegate _download:didReceiveData:]):
960         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
961         (-[QuickLookDelegate _downloadDidFinish:]):
962         (-[QuickLookDelegate _download:didFailWithError:]):
963         (-[QuickLookDelegate _downloadDidCancel:]):
964         (-[QuickLookDelegate verifyDownload]):
965         (runTest):
966         (runTestDecideBeforeLoading):
967         (runTestDecideAfterLoading):
968         (TEST):
969         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
970         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
971         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
972         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
973         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
974         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
975         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
976         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
977         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
978         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
979         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
980         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
981         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
982         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
983
984 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
985
986         [CMake] add testdfg as target with build-jsc
987         https://bugs.webkit.org/show_bug.cgi?id=196393
988
989         Reviewed by Saam Barati.
990
991         Added testdfg as one of the targets to build when
992         using CMake.
993
994         * Scripts/build-jsc:
995
996 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
997
998         Delete WebMetal implementation in favor of WebGPU
999         https://bugs.webkit.org/show_bug.cgi?id=195418
1000
1001         Reviewed by Dean Jackson.
1002
1003         * DumpRenderTree/mac/DumpRenderTree.mm:
1004         (enableExperimentalFeatures):
1005         (resetWebPreferencesToConsistentValues):
1006         * Scripts/webkitperl/FeatureList.pm:
1007         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1008         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1009         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1010         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1011         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1012         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1013         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1014         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1015         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1016         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1017         (WTR::InjectedBundle::beginTesting):
1018         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1019         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1020         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1021
1022 2019-03-29  Chris Dumez  <cdumez@apple.com>
1023
1024         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1025         https://bugs.webkit.org/show_bug.cgi?id=196405
1026         <rdar://problem/49428130>
1027
1028         Reviewed by Wenson Hsieh.
1029
1030         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1031         the popover presentation methods to be no-ops. Use this in the new test added in
1032         r243523 so that we do not swizzle those methods for all tests. This is needed because
1033         those WatchOS tests rely on the popover getting presented and interactive.
1034
1035         * WebKitTestRunner/TestController.cpp:
1036         (WTR::updateTestOptionsFromTestHeader):
1037         * WebKitTestRunner/TestController.h:
1038         * WebKitTestRunner/TestOptions.h:
1039         (WTR::TestOptions::hasSameInitializationOptions const):
1040         * WebKitTestRunner/ios/TestControllerIOS.mm:
1041         (WTR::TestController::platformInitialize):
1042         (WTR::TestController::platformResetStateToConsistentValues):
1043
1044 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1045
1046         [Curl] Add Server Trust Evaluation Support.
1047         https://bugs.webkit.org/show_bug.cgi?id=191646
1048
1049         Reviewed by Fujii Hironori.
1050
1051         Implemented MiniBrowser UI for asking if user trusts the server.
1052
1053         * MiniBrowser/win/Common.cpp:
1054         (askServerTrustEvaluation):
1055         (replaceString):
1056         * MiniBrowser/win/Common.h:
1057         * MiniBrowser/win/MiniBrowserLib.rc:
1058         * MiniBrowser/win/MiniBrowserLibResource.h:
1059         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1060         (createPEMString):
1061         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1062         (WebKitBrowserWindow::canTrustServerCertificate):
1063         * MiniBrowser/win/WebKitBrowserWindow.h:
1064
1065 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1066
1067         Implement ResizeObserver.
1068         https://bugs.webkit.org/show_bug.cgi?id=157743
1069
1070         Reviewed by Simon Fraser.
1071
1072         Support resizeObserverEnabled webPreferences.
1073
1074         * DumpRenderTree/TestOptions.cpp:
1075         (TestOptions::TestOptions):
1076         * DumpRenderTree/TestOptions.h:
1077         * DumpRenderTree/mac/DumpRenderTree.mm:
1078         (setWebPreferencesForTestOptions):
1079         * DumpRenderTree/win/DumpRenderTree.cpp:
1080         (enableExperimentalFeatures):
1081         * Scripts/webkitperl/FeatureList.pm:
1082         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1083
1084 2019-03-28  John Wilander  <wilander@apple.com>
1085
1086         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1087         https://bugs.webkit.org/show_bug.cgi?id=196281
1088         <rdar://problem/48938748>
1089
1090         Reviewed by Alex Christensen.
1091
1092         This patch adds the function isStatisticsHasLocalStorage() to the
1093         TestRunner. With it, the page can query the WebsiteDataStore in the
1094         UI process to make sure that it sees LocalStorage.
1095
1096         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1097         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1098         (WTR::TestRunner::isStatisticsHasLocalStorage):
1099         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1100         * WebKitTestRunner/TestController.cpp:
1101         (WTR::TestController::isStatisticsHasLocalStorage):
1102         * WebKitTestRunner/TestController.h:
1103         * WebKitTestRunner/TestInvocation.cpp:
1104         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1105
1106 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1107
1108         API::Data::createWithoutCopying should do a null check before calling CFRelease
1109         https://bugs.webkit.org/show_bug.cgi?id=196276
1110         <rdar://problem/48059859>
1111
1112         Reviewed by Alex Christensen.
1113
1114         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1115
1116         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1117         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1118         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1119         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1120         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1121         (TestWebKitAPI::TEST):
1122
1123 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1124
1125         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1126         https://bugs.webkit.org/show_bug.cgi?id=186276
1127
1128         Reviewed by Carlos Garcia Campos.
1129
1130         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1131         (webViewLoadChanged):
1132         (testWebResourceGetDataError):
1133         (testWebResourceGetDataEmpty):
1134         (beforeAll):
1135         (webViewloadChanged): Deleted.
1136
1137 2019-03-27  Andy Estes  <aestes@apple.com>
1138
1139         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1140         https://bugs.webkit.org/show_bug.cgi?id=196317
1141
1142         Reviewed by Dan Bernstein.
1143
1144         package-root copies built products into a staging directory using ditto(1), which does not
1145         follow symbolic links as it traverses a directory. Now that the files in
1146         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1147         itself, these become broken links when ditto'd into the staging directory.
1148
1149         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1150
1151         * Scripts/package-root:
1152
1153 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1154
1155         [ews-app] Update display text of Submit for ews analysis
1156         https://bugs.webkit.org/show_bug.cgi?id=196309
1157
1158         Reviewed by Dewei Zhu.
1159
1160         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1161
1162 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1163
1164         run-webkit-tests should check for leaks in WebKit processes
1165         <https://webkit.org/b/193772>
1166         <rdar://problem/46526680>
1167
1168         Reviewed by Ryosuke Niwa.
1169
1170         This works by doing the following:
1171         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1172           The list of child processes are returned one per line:
1173           process.name: pid
1174         - Run the "#LIST CHILD PROCESSES" command just before the
1175           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1176           processes on the ServerProcess object.
1177         - When the `--leaks` switch is handled, run check_for_leaks() on
1178           each child process after the main test harness.
1179
1180         * DumpRenderTree/mac/DumpRenderTree.mm:
1181         (handleControlCommand):
1182         - Use strncmp() instead of strcmp().
1183         - Add support for handling "#LIST CHILD PROCESSES" command.
1184
1185         * Scripts/webkitpy/port/base.py:
1186         (Port.check_for_leaks):
1187         * Scripts/webkitpy/port/darwin.py:
1188         (DarwinPort.check_for_leaks):
1189         - Rename redundant 'process_pid' argument to 'process_id'.
1190
1191         * Scripts/webkitpy/port/driver.py:
1192         (Driver.do_post_tests_work):
1193         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1194           longer the only command this sends to WebKitTestRunner.
1195         - If the `--leaks` switch is present, send the
1196           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1197           result using Port.set_webkit_processes().
1198         (Driver._parse_child_processes_output):
1199         - Add helper method to parse list of child process names and
1200           process IDs returned from WebKitTestRunner.
1201
1202         * Scripts/webkitpy/port/ios_device.py:
1203         (IOSDevicePort.check_for_leaks):
1204         - Rename redundant 'process_pid' argument to 'process_id'.
1205
1206         * Scripts/webkitpy/port/leakdetector.py:
1207         (LeakDetector._parse_leaks_output):
1208         - Return early if there is no leaks_output.
1209         (LeakDetector.check_for_leaks):
1210         - Rename redundant 'process_pid' argument to 'process_id'.
1211
1212         * Scripts/webkitpy/port/server_process.py:
1213         (ServerProcess.__init__):
1214         (ServerProcess.child_processes):
1215         (ServerProcess.set_child_processes):
1216         - Add instance variable to Port to store list of child process
1217           names and process IDs returned from WebKitTestRunner.
1218         (ServerProcess._start):
1219         - Clear self._child_processes.
1220         (ServerProcess.stop):
1221         - If self._child_processes is set, call
1222           self._port.check_for_leaks() for each child process.
1223
1224         * Scripts/webkitpy/port/server_process_unittest.py:
1225         (TrivialMockPort.check_for_leaks):
1226         - Rename redundant 'process_pid' argument to 'process_id'.
1227
1228         * Scripts/webkitpy/port/simulator_process.py:
1229         (SimulatorProcess.stop):
1230         - If self._child_processes is set, call
1231           self._port.check_for_leaks() for each child process.
1232
1233         * Scripts/webkitpy/port/watch_device.py:
1234         (WatchDevicePort.check_for_leaks):
1235         - Rename redundant 'process_pid' argument to 'process_id'.
1236
1237         * WebKitTestRunner/TestController.cpp:
1238         (WTR::TestController::dumpResponse):
1239         - Extract method from findAndDumpWorldLeaks() so that it may be
1240           reused by findAndDumpWebKitProcessIdentifiers().
1241         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1242         - Add method to output process name and process ID of both the
1243           WebContent and Networking processes.
1244         (WTR::TestController::findAndDumpWorldLeaks):
1245         - Fix missing newline in output when there were no abandoned
1246           documents.
1247         - Call dumpResponse() for extracted code.
1248         (WTR::TestController::handleControlCommand):
1249         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1250         - Use strncmp() instead of strcmp().
1251         - Call findAndDumpWebKitProcessIdentifiers() when
1252           "#LIST CHILD PROCESSES" command is sent.
1253         * WebKitTestRunner/TestController.h:
1254         (WTR::TestController::dumpResponse):
1255         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1256         - Declare methods.
1257
1258 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1259
1260         Unreviewed. Add GLib API test cases after r243434.
1261
1262         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1263         (testWebViewActiveURI):
1264         (serverCallback):
1265         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1266         (sendRequestCallback):
1267
1268 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1269
1270         Geolocation request not complete when watch request was started in a different web process
1271         https://bugs.webkit.org/show_bug.cgi?id=195996
1272
1273         Reviewed by Alex Christensen.
1274
1275         Add a test case.
1276
1277         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1278         (TestWebKitAPI::runJavaScriptAlert):
1279         (TestWebKitAPI::TEST):
1280
1281 2019-03-26  Keith Rollin  <krollin@apple.com>
1282
1283         Update the way generate-xcfilelists returns strings from functions
1284         https://bugs.webkit.org/show_bug.cgi?id=195975
1285         <rdar://problem/49040807>
1286
1287         Reviewed by Dean Jackson.
1288
1289         There are places where generate-xcfilelists executes assignments with
1290         statements like:
1291
1292             FOO=$(some_function)
1293
1294         where "some_function" return a string by echoing it. E.g.
1295
1296             some_function()
1297             {
1298                 echo "Hello, World"
1299             }
1300
1301         This is a common idiom, but it has a problem if "some_function" needs
1302         to call "exit" in an attempt to halt the entire script right then and
1303         there. Since "some_function" is called inside of $(), it's being
1304         executed in a sub-shell. Calling exit in that sub-shell simply exits
1305         that shell; it doesn't not exit the outer shell in which the main part
1306         of the script is still running. As such, the main script keeps
1307         executing when the intent was for the script to halt.
1308
1309         The solution to this is to use a different idiom for returning
1310         strings. The one we now is to pass in the name of the variable to
1311         receive the string result:
1312
1313             some_function()
1314             {
1315                 variable_name=$1
1316                 eval $variable_name ="Hello, World"
1317             }
1318
1319         The call site now looks like
1320
1321             some_function FOO
1322
1323         Because there's no invocation of a sub-shell, some_function can now
1324         call "exit" if it wants to, and the entire script will exit at that
1325         point.
1326
1327         * Scripts/generate-xcfilelists:
1328
1329 2019-03-26  Chris Dumez  <cdumez@apple.com>
1330
1331         Add basic layout test coverage for File Picker on iOS
1332         https://bugs.webkit.org/show_bug.cgi?id=196265
1333
1334         Reviewed by Wenson Hsieh.
1335
1336         Add layout test infrastructure to test the file picker on iOS.
1337
1338         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1339         (WTR::UIScriptController::dismissFilePicker):
1340         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1341         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1342         (WTR::UIScriptController::dismissFilePicker):
1343         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1344         * WebKitTestRunner/TestController.cpp:
1345         (WTR::TestController::createWebViewWithOptions):
1346         (WTR::updateTestOptionsFromTestHeader):
1347         * WebKitTestRunner/TestOptions.h:
1348         (WTR::TestOptions::hasSameInitializationOptions const):
1349         * WebKitTestRunner/ios/TestControllerIOS.mm:
1350         (overridePresentViewController):
1351         (WTR::TestController::platformInitialize):
1352         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1353         (WTR::UIScriptController::dismissFilePicker):
1354
1355 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1356
1357         Implement async paste method on UIWKInteractionViewProtocol
1358         https://bugs.webkit.org/show_bug.cgi?id=196267
1359         <rdar://problem/49236346>
1360
1361         Reviewed by Tim Horton.
1362
1363         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1364         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1365         are now a part of all iOS 12 internal SDKs.
1366
1367         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1368
1369         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1370         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1371
1372         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1373         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1374         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1375         * TestWebKitAPI/ios/UIKitSPI.h:
1376
1377 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1378
1379         [ews-build] Use PostgreSQL for ews.webkit.org database
1380         https://bugs.webkit.org/show_bug.cgi?id=196270
1381
1382         Reviewed by Lucas Forschler.
1383
1384         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1385
1386 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1387
1388         [ews] Reset simctl states on reboot
1389         https://bugs.webkit.org/show_bug.cgi?id=196260
1390
1391         Rubber-stamped by Aakash Jain.
1392
1393         * EWSTools/start-queue-mac.sh:
1394
1395 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1396
1397         [ews-build] Use PostgreSQL for ews-build database
1398         https://bugs.webkit.org/show_bug.cgi?id=196229
1399
1400         Reviewed by Lucas Forschler.
1401
1402         * BuildSlaveSupport/ews-build/master.cfg:
1403
1404 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1405
1406         [ews-build] Get master_hostname dynamically in master.cfg
1407         https://bugs.webkit.org/show_bug.cgi?id=196255
1408
1409         Reviewed by Lucas Forschler.
1410
1411         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1412         send events data in test mode.
1413
1414 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1415
1416         [ews-app] Set db_constraint to False for Foreign Keys
1417         https://bugs.webkit.org/show_bug.cgi?id=196252
1418
1419         Reviewed by Lucas Forschler.
1420
1421         * BuildSlaveSupport/ews-app/ews/models/build.py:
1422         * BuildSlaveSupport/ews-app/ews/models/step.py:
1423
1424 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1425
1426         [ews-build] is_test_mode_enabled should default to True
1427         https://bugs.webkit.org/show_bug.cgi?id=196248
1428
1429         Reviewed by Lucas Forschler.
1430
1431         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1432
1433 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1434
1435         [ews-app] Add webkitperl to ENABLED_QUEUES
1436         https://bugs.webkit.org/show_bug.cgi?id=196253
1437
1438         Reviewed by Lucas Forschler.
1439
1440         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1441
1442 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1443
1444         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1445         https://bugs.webkit.org/show_bug.cgi?id=196211
1446         rdar://problem/49110552
1447
1448         Reviewed by Tim Horton.
1449
1450         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1451         Make sure that EventSenderProxy always exists when running tests. We used to create
1452         it when resetting before the first test, which is a bit too late.
1453
1454         * WebKitTestRunner/TestController.h:
1455         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1456         (WTR::TestController::platformCreateWebView):
1457         (WTR::TestController::platformCreateOtherPage):
1458         (WTR::TestController::finishCreatingPlatformWebView):
1459         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1460         (WTR::PlatformWebView::PlatformWebView):
1461         Moved some code that made NSWindow use NSEvent during web view creation. We may
1462         need to move more if some other case us found, but this is enough for now.
1463
1464 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1465
1466         Unreviewed. Fix typo in GLib geolocation API after r243285.
1467
1468         gelocation -> geolocation.
1469
1470         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1471         (testGeolocationManagerWatchPosition):
1472
1473 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1474
1475         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1476         https://bugs.webkit.org/show_bug.cgi?id=196213
1477
1478         Reviewed by Geoff Garen.
1479
1480         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1481         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1482         (credentialWithIdentityAndKeychainPath):
1483         (-[ChallengeDelegate webView:didFinishNavigation:]):
1484         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1485         (TestWebKitAPI::TEST):
1486
1487 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1488
1489         Expected shouldn't assume its contained types are copyable
1490         https://bugs.webkit.org/show_bug.cgi?id=195986
1491
1492         Reviewed by JF Bastien.
1493
1494         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1495         (TestWebKitAPI::NonCopyable::operator== const):
1496         (TestWebKitAPI::NonCopyable::operator!= const):
1497         (TestWebKitAPI::TEST):
1498
1499 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1500
1501         Remove some now-unnecessary dynamic class lookup
1502         https://bugs.webkit.org/show_bug.cgi?id=196237
1503
1504         Reviewed by Simon Fraser.
1505
1506         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1507         (makeRequest):
1508         (TEST):
1509
1510 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1511
1512         Unreviewed, rolling out r243450.
1513
1514         AppleWin and WinCairo port builds get broken.
1515
1516         Reverted changeset:
1517
1518         "Add test for fix of #196095"
1519         https://bugs.webkit.org/show_bug.cgi?id=196097
1520         https://trac.webkit.org/changeset/243450
1521
1522 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1523
1524         Unreviewed, rolling out r243465.
1525         https://bugs.webkit.org/show_bug.cgi?id=196226
1526
1527         the test doesn't build (Requested by thorton on #webkit).
1528
1529         Reverted changeset:
1530
1531         "Do not terminate the NetworkProcess if a third party
1532         application sends a NSCredential with a SecIdentityRef"
1533         https://bugs.webkit.org/show_bug.cgi?id=196213
1534         https://trac.webkit.org/changeset/243465
1535
1536 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1537
1538         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1539         https://bugs.webkit.org/show_bug.cgi?id=196213
1540
1541         Reviewed by Geoff Garen.
1542
1543         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1544         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1545         (credentialWithIdentityAndKeychainPath):
1546         (-[ChallengeDelegate webView:didFinishNavigation:]):
1547         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1548         (TestWebKitAPI::TEST):
1549
1550 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1551
1552         [ews-build] Gracefully handle missing patch_id in events
1553         https://bugs.webkit.org/show_bug.cgi?id=196216
1554
1555         Reviewed by Lucas Forschler.
1556
1557         * BuildSlaveSupport/ews-build/events.py:
1558
1559 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1560
1561         [ews-build] use lz4 compression for improving buildbot performance
1562         https://bugs.webkit.org/show_bug.cgi?id=196155
1563
1564         Reviewed by Lucas Forschler.
1565
1566         * BuildSlaveSupport/ews-build/master.cfg:
1567
1568 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1569
1570         Pull some API testing helper methods out of TestWKWebView
1571         https://bugs.webkit.org/show_bug.cgi?id=196212
1572
1573         Reviewed by Tim Horton.
1574
1575         Refactor some more API testing utility methods, so that they can be used in
1576         tests that do not use TestWKWebView.
1577
1578         * TestWebKitAPI/cocoa/TestWKWebView.h:
1579         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1580         (-[WKWebView loadTestPageNamed:]):
1581         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1582         (-[WKWebView synchronouslyLoadHTMLString:]):
1583         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1584         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1585         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1586         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1587         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1588
1589 2019-03-25  Jer Noble  <jer.noble@apple.com>
1590
1591         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1592         https://bugs.webkit.org/show_bug.cgi?id=196097
1593
1594         Reviewed by Eric Carlson.
1595
1596         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1597
1598         * DumpRenderTree/mac/DumpRenderTree.mm:
1599         (resetWebPreferencesToConsistentValues):
1600         * WebKitTestRunner/TestController.cpp:
1601         (WTR::TestController::resetPreferencesToConsistentValues):
1602
1603 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1604
1605         Pull IPadUserInterfaceSwizzler out into a separate header file
1606         https://bugs.webkit.org/show_bug.cgi?id=196193
1607
1608         Reviewed by Anders Carlsson.
1609
1610         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1611         be used in other API tests.
1612
1613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1614         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1615         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1616         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1617         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1618         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1619         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1620
1621 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1622
1623         Remove NavigatorContentUtils in WebCore/Modules
1624         https://bugs.webkit.org/show_bug.cgi?id=196070
1625
1626         Reviewed by Alex Christensen.
1627
1628         NavigatorContentUtils was to support the custom scheme spec [1].
1629         However, in WebKit side, no port has supported the feature in
1630         WebKit layer after EFL port was removed. So there has been the
1631         only IDL implementation of the NavigatorContentUtils in WebCore.
1632         So we don't need to keep the implementation in WebCore anymore.
1633
1634         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1635
1636         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1637
1638 2019-03-24  Andy Estes  <aestes@apple.com>
1639
1640         [watchOS] Remove unused Proximity Networking code
1641         https://bugs.webkit.org/show_bug.cgi?id=196188
1642
1643         Reviewed by Tim Horton.
1644
1645         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1646         (TEST):
1647
1648 2019-03-23  Keith Miller  <keith_miller@apple.com>
1649
1650         Refactor clz/ctz and fix getLSBSet.
1651         https://bugs.webkit.org/show_bug.cgi?id=196162
1652
1653         Reviewed by Saam Barati.
1654
1655         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1656
1657         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1658         (TestWebKitAPI::TEST):
1659
1660 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1661
1662         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1663         https://bugs.webkit.org/show_bug.cgi?id=196143
1664
1665         Reviewed by Michael Catanzaro.
1666
1667         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1668         directories.
1669
1670         * Scripts/webkitpy/style/checkers/cpp.py:
1671         (check_identifier_name_in_declaration):
1672         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1673         (WebKitStyleTest.test_names):
1674
1675 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1676
1677         [Flatpak] Manifest expanding fails for qt WPE extension
1678         https://bugs.webkit.org/show_bug.cgi?id=196148
1679
1680         Reviewed by Alex Christensen.
1681
1682         * flatpak/flatpakutils.py:
1683         (expand_submodules_recurse): The last recurse manifest expand
1684         iteration might lead to a single module so take it into account
1685         and don't try to recurse further.
1686
1687 2019-03-22  Chris Dumez  <cdumez@apple.com>
1688
1689         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1690         https://bugs.webkit.org/show_bug.cgi?id=195348
1691         <rdar://problem/48622090>
1692
1693         Reviewed by Alex Christensen.
1694
1695         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1696         to NO when test.options().shouldIgnoreMetaViewport is false.
1697
1698         * WebKitTestRunner/ios/TestControllerIOS.mm:
1699         (WTR::TestController::platformConfigureViewForTest):
1700
1701 2019-03-22  Chris Dumez  <cdumez@apple.com>
1702
1703         Prewarmed processes should be usable with any website data store
1704         https://bugs.webkit.org/show_bug.cgi?id=196104
1705
1706         Reviewed by Alex Christensen.
1707
1708         Add API test coverage.
1709
1710         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1711         (runInitialWarmedProcessUsedTest):
1712         (TEST):
1713
1714 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1715
1716         Back out local changes to Alex's Subversion working directory
1717
1718         They were accidentally committed.
1719
1720         * Scripts/webkitpy/common/system/abstractexecutive.py:
1721         (AbstractExecutive.wait_newest):
1722         * Scripts/webkitpy/common/system/executive.py:
1723         (Executive.running_pids):
1724         * Scripts/webkitpy/common/system/executive_mock.py:
1725         (MockExecutive.running_pids):
1726         * Scripts/webkitpy/common/system/executive_unittest.py:
1727         (ExecutiveTest.serial_test_running_pids):
1728         * Scripts/webkitpy/port/darwin.py:
1729         (DarwinPort.check_for_leaks):
1730         * Scripts/webkitpy/port/leakdetector.py:
1731         (LeakDetector.check_for_leaks):
1732         - This was the hack attached to Bug 193772.
1733
1734         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1735         (+[WebKitTestRunnerEvent mouseLocation]):
1736         - This works around a crash on an internal build.
1737
1738 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1739
1740         Fix the build after r243354
1741         https://bugs.webkit.org/show_bug.cgi?id=196138
1742         <rdar://problem/49145951>
1743
1744         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1745         (TEST):
1746         * TestWebKitAPI/ios/UIKitSPI.h:
1747
1748 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1749
1750         Adopt UIWKDocumentContext
1751         https://bugs.webkit.org/show_bug.cgi?id=196040
1752         <rdar://problem/48642440>
1753
1754         Reviewed by Ryosuke Niwa.
1755
1756         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1757         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1758         (makeRequest):
1759         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1760         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1761         (applyStyle):
1762         (TEST):
1763         Add tests for UIWKDocumentContext.
1764
1765         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1766         (TEST):
1767         (recursiveFindWKContentView): Deleted.
1768         * TestWebKitAPI/cocoa/TestWKWebView.h:
1769         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1770         (recursiveFindWKContentView):
1771         (-[TestWKWebView wkContentView]):
1772         * TestWebKitAPI/ios/UIKitSPI.h:
1773         Share the WKContentView finding code between tests.
1774
1775 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1776
1777         [iOS WK2] Turn on async overflow scrolling by default
1778         https://bugs.webkit.org/show_bug.cgi?id=196011
1779         rdar://problem/48453859
1780
1781         Reviewed by Antti Koivisto.
1782         
1783         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1784         since so many basic layout tests have different results when compositing is triggered for
1785         overflow.
1786         
1787         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1788
1789         * WebKitTestRunner/TestController.cpp:
1790         (WTR::TestController::resetPreferencesToConsistentValues):
1791
1792 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1793
1794         [ews-build] Retry API test in case of failures
1795         https://bugs.webkit.org/show_bug.cgi?id=196004
1796
1797         Reviewed by Lucas Forschler.
1798
1799         * BuildSlaveSupport/ews-build/steps.py:
1800         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1801         (CompileWebKitToT.doStepIf): Ditto.
1802         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1803         (ReRunAPITests): Re-run API tests.
1804         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1805         (RunAPITestsWithoutPatch): Run API tests without patch.
1806         (RunAPITestsWithoutPatch.doStepIf):
1807         (RunAPITestsWithoutPatch.hideStepIf):
1808         (RunAPITestsWithoutPatch.evaluateCommand):
1809         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1810         (AnalyzeAPITestsResults.start):
1811         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1812         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1813         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1814         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1815
1816 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1817
1818         [ews-build] Update queues configurations
1819         https://bugs.webkit.org/show_bug.cgi?id=196074
1820
1821         Reviewed by Dewei Zhu.
1822
1823         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1824         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1825
1826 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1827
1828         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1829         https://bugs.webkit.org/show_bug.cgi?id=195680
1830         <rdar://problem/48903534>
1831
1832         Unreviewed infrastructure fix.
1833
1834         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1835         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1836
1837 2019-03-21  Andy Estes  <aestes@apple.com>
1838
1839         [iOS] Apple Pay should be available in documents with no user agent scripts
1840         https://bugs.webkit.org/show_bug.cgi?id=196061
1841         <rdar://problem/48649391>
1842
1843         Reviewed by Brady Eidson.
1844
1845         Added API tests and related infrastructure.
1846
1847         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1848         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1849         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1850         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1851         (TestWebKitAPI::TEST):
1852         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1853         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1854         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1855         * TestWebKitAPI/cocoa/TestProtocol.mm:
1856         (-[TestProtocol startLoading]):
1857         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1858         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1859         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1860         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1861
1862 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1863
1864         REGRESSSION (r243297): webkitpy tests broken
1865         https://bugs.webkit.org/show_bug.cgi?id=196108
1866
1867         Reviewed by Aakash Jain.
1868
1869         r243297 updated contributors.json, which broke a few unit tests.
1870
1871         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1872         (IRCCommandTest.test_whois):
1873         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1874
1875 2019-03-21  Chris Dumez  <cdumez@apple.com>
1876
1877         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1878         https://bugs.webkit.org/show_bug.cgi?id=196041
1879         <rdar://problem/49083230>
1880
1881         Reviewed by Alex Christensen.
1882
1883         Add API test coverage.
1884
1885         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1886         (TEST):
1887
1888 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1889
1890         Add SPI to inform applications of WKContentRuleList actions
1891         https://bugs.webkit.org/show_bug.cgi?id=195965
1892         <rdar://problem/42664365>
1893
1894         Reviewed by Geoff Garen.
1895
1896         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1897         (TestWebKitAPI::allActionsForResourceLoad):
1898         (TestWebKitAPI::testRequest):
1899         (TestWebKitAPI::TEST_F):
1900         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1901         (Notification::description):
1902         (Notification::operator== const):
1903         (toVector):
1904         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1905         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1906         (makeContentRuleList):
1907         (TEST):
1908         (makeWarnContentRuleList): Deleted.
1909
1910 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1911
1912         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1913         https://bugs.webkit.org/show_bug.cgi?id=196088
1914
1915         Reviewed by Brian Burg.
1916
1917         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1918         Support checks when only one platform is specified. Also deprecate macosx() and
1919         force the use of macos() instead.
1920
1921         * Scripts/webkitpy/style/checkers/cpp.py:
1922         (check_min_versions_of_wk_api_available):
1923         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1924         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1925
1926 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1927
1928         Update status inactive committers' status to 'contributor'.
1929
1930         * Scripts/webkitpy/common/config/contributors.json:
1931
1932 2019-03-21  Xan Lopez  <xan@igalia.com>
1933
1934         [JSC][x86] Drop support for x87 floating point
1935         https://bugs.webkit.org/show_bug.cgi?id=194853
1936
1937         Reviewed by Don Olmstead.
1938
1939         Force SSE2 on x86/32bit builds.
1940
1941         * Scripts/webkitdirs.pm:
1942         (generateBuildSystemFromCMakeProject):
1943
1944 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1945
1946         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1947         https://bugs.webkit.org/show_bug.cgi?id=196073
1948
1949         Reviewed by Michael Catanzaro.
1950
1951         Add test cases to check functions and constructors with no arguments but receiving user data.
1952
1953         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1954         (checkUserData):
1955         (testJSCFunction):
1956         (fooCreateWithUserData):
1957         (testJSCClass):
1958
1959 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1960
1961         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1962
1963         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1964
1965         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1966
1967 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1968
1969         [GTK][WPE] Add API to provide geolocation information
1970         https://bugs.webkit.org/show_bug.cgi?id=195940
1971
1972         Reviewed by Michael Catanzaro.
1973
1974         Add a new test to check the new API.
1975
1976         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1977         (testGeolocationManagerCurrentPosition):
1978         (testGeolocationManagerWatchPosition):
1979         (beforeAll):
1980         (afterAll):
1981         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1982         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1983         (beforeAll): Ditto.
1984         * TestWebKitAPI/glib/CMakeLists.txt:
1985
1986 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1987
1988         [GLib] Returning G_TYPE_OBJECT from a method does not work
1989         https://bugs.webkit.org/show_bug.cgi?id=195574
1990
1991         Reviewed by Michael Catanzaro.
1992
1993         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1994
1995         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1996         (getGFile):
1997         (getParent):
1998         (createGString):
1999         (getGString):
2000         (getGStringCopyWillRaise):
2001         (getGStringCopy):
2002         (getGStringStr):
2003         (getGStringLen):
2004         (freeGString):
2005         (testJSCClass):
2006
2007 2019-03-20  Saam Barati  <sbarati@apple.com>
2008
2009         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2010         https://bugs.webkit.org/show_bug.cgi?id=195721
2011
2012         Reviewed by Filip Pizlo.
2013
2014         * Scripts/run-javascriptcore-tests:
2015
2016 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2017
2018         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2019         https://bugs.webkit.org/show_bug.cgi?id=196049
2020
2021         Reviewed by Tim Horton.
2022
2023         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2024         overflow scrolling in general, so rename it.
2025
2026         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2027
2028 2019-03-20  Daniel Bates  <dabates@apple.com>
2029
2030         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2031         https://bugs.webkit.org/show_bug.cgi?id=196031
2032         <rdar://problem/49078172>
2033
2034         Reviewed by Tim Horton.
2035
2036         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2037         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2038         same code path used when the Done button is pressed to dismiss the <select> picker.
2039
2040         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2041         (TestWebKitAPI::TEST):
2042
2043 2019-03-20  Chris Dumez  <cdumez@apple.com>
2044
2045         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2046         https://bugs.webkit.org/show_bug.cgi?id=196029
2047         <rdar://problem/48954651>
2048
2049         Reviewed by Tim Horton.
2050
2051         Add API test coverage.
2052
2053         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2054
2055 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2056
2057         [ews-build] Improve failure summary string for ApplyPatch step
2058         https://bugs.webkit.org/show_bug.cgi?id=195995
2059
2060         Reviewed by Alexey Proskuryakov.
2061
2062         * BuildSlaveSupport/ews-build/steps.py:
2063         (ApplyPatch.getResultSummary): Override getResultSummary.
2064
2065 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2066
2067         AX: Implement support for new meter ARIA role
2068         https://bugs.webkit.org/show_bug.cgi?id=195966
2069
2070         Reviewed by Chris Fleizach.
2071
2072         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2073         to AXLevelIndicator.
2074
2075         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2076
2077 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2078
2079         [WebAuthN] Implement FIDO AppID extension
2080         https://bugs.webkit.org/show_bug.cgi?id=143491
2081         <rdar://problem/48298273>
2082
2083         Reviewed by Brent Fulgham.
2084
2085         Add a test that covers the new flag of convertToU2fSignCommand.
2086
2087         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2088         (TestWebKitAPI::TEST):
2089         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2090         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2091         (TestWebKitAPI::TEST):
2092
2093 2019-03-19  Keith Rollin  <krollin@apple.com>
2094
2095         Add support for more platforms to generate-xcfilelists
2096         https://bugs.webkit.org/show_bug.cgi?id=195977
2097
2098         Reviewed by Alexey Proskuryakov.
2099
2100         generate-xcfilelists incorrectly complains when involved with building
2101         WebKit for iphonesimulator:
2102
2103             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2104             …
2105             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2106
2107         Address this by teaching generate-xcfilelists about more platforms.
2108
2109         * Scripts/generate-xcfilelists:
2110
2111 2019-03-19  John Wilander  <wilander@apple.com>
2112
2113         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2114         https://bugs.webkit.org/show_bug.cgi?id=195923
2115         <rdar://problem/49001272>
2116
2117         Reviewed by Alex Christensen.
2118
2119         This patch does the following to the TestRunner:
2120         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2121         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2122         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2123
2124         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2125         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2126         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2127         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2128         * WebKitTestRunner/TestController.cpp:
2129         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2130         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2131         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2132         * WebKitTestRunner/TestController.h:
2133         * WebKitTestRunner/TestInvocation.cpp:
2134         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2135
2136 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2137
2138         [CMake] Support more clang and gcc sanitizers
2139         https://bugs.webkit.org/show_bug.cgi?id=195956
2140
2141         Reviewed by Michael Catanzaro.
2142
2143         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2144
2145 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2146
2147         [ews-build] Improve summary for PrintConfiguration step
2148         https://bugs.webkit.org/show_bug.cgi?id=195945
2149
2150         Reviewed by Lucas Forschler.
2151
2152         * BuildSlaveSupport/ews-build/steps.py:
2153         (PrintConfiguration.getResultSummary): Override getResultSummary.
2154
2155 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2156
2157         [ews-build] Improve summary for CheckOutSource step
2158         https://bugs.webkit.org/show_bug.cgi?id=195963
2159
2160         Reviewed by Lucas Forschler.
2161
2162         * BuildSlaveSupport/ews-build/steps.py:
2163         (CheckOutSource.getResultSummary):
2164
2165 2019-03-19  Daniel Bates  <dabates@apple.com>
2166
2167         [iOS] Focus not preserved when switching between tabs
2168         https://bugs.webkit.org/show_bug.cgi?id=195820
2169         <rdar://problem/43614450>
2170
2171         Reviewed by Brent Fulgham.
2172
2173         Add tests to ensure that we restore focus when resigning and becoming first responder.
2174
2175         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2176         (TestWebKitAPI::TEST):
2177
2178 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2179
2180         Make WTFLogChannelState and WTFLogLevel enum classes
2181         https://bugs.webkit.org/show_bug.cgi?id=195904
2182
2183         Reviewed by Eric Carlson.
2184
2185         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2186         (TestWebKitAPI::TEST_F):
2187
2188 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2189
2190         [GStreamer][EME] Backported mssdemux protection data crash fix
2191         https://bugs.webkit.org/show_bug.cgi?id=195918
2192
2193         Reviewed by Philippe Normand.
2194
2195         * gstreamer/jhbuild.modules:
2196         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2197
2198 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2199
2200         Unreviewed, rolling out r243132.
2201
2202         Broke GTK build
2203
2204         Reverted changeset:
2205
2206         "Make WTFLogChannelState and WTFLogLevel enum classes"
2207         https://bugs.webkit.org/show_bug.cgi?id=195904
2208         https://trac.webkit.org/changeset/243132
2209
2210 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2211
2212         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2213
2214         * Scripts/webkitdirs.pm:
2215         (builtDylibPathForName): Adjust the shared library name that's changed
2216         with the API version bump in r243073.
2217
2218 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2219
2220         Make WTFLogChannelState and WTFLogLevel enum classes
2221         https://bugs.webkit.org/show_bug.cgi?id=195904
2222
2223         Reviewed by Eric Carlson.
2224
2225         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2226         (TestWebKitAPI::TEST_F):
2227
2228 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2229
2230         Disable flaky test added in r2431100
2231         https://webkit.org/b/195785
2232
2233         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2234         (TestWebKitAPI::TEST):
2235         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2236
2237 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2238
2239         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2240         https://bugs.webkit.org/show_bug.cgi?id=195916
2241
2242         Reviewed by Tim Horton.
2243
2244         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2245         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2246
2247 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2248
2249         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2250
2251         * Scripts/webkitpy/common/config/contributors.json:
2252
2253 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2254
2255         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2256         https://bugs.webkit.org/show_bug.cgi?id=195785
2257
2258         Reviewed by Geoffrey Garen.
2259
2260         * TestWebKitAPI/TCPServer.cpp: Added.
2261         (TestWebKitAPI::TCPServer::TCPServer):
2262         (TestWebKitAPI::TCPServer::~TCPServer):
2263         (TestWebKitAPI::TCPServer::socketBindListen):
2264         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2265         * TestWebKitAPI/TCPServer.h: Added.
2266         (TestWebKitAPI::TCPServer::port const):
2267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2268         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2269         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2270         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2271         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2272         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2273         (TestWebKitAPI::respondSlowly):
2274         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2275         (TestWebKitAPI::downloadAtRate):
2276         (TestWebKitAPI::TEST):
2277
2278 2019-03-18  Saam Barati  <sbarati@apple.com>
2279
2280         Add a plan file for JetStream 2
2281         https://bugs.webkit.org/show_bug.cgi?id=190734
2282
2283         Reviewed by Mark Lam.
2284
2285         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2286
2287 2019-03-18  Chris Dumez  <cdumez@apple.com>
2288
2289         Delay WebProcess launch until a load is triggered in a Web view
2290         https://bugs.webkit.org/show_bug.cgi?id=195758
2291         <rdar://problem/48126013>
2292
2293         Reviewed by Geoff Garen.
2294
2295         Add API test coverage. Also update some existing API tests to not expect
2296         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2297
2298         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2299         (TestWebKitAPI::TEST):
2300         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2301         (TestWebKitAPI::TEST):
2302         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2303         (TEST):
2304         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2305         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2306         (TEST):
2307         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2308         (TEST):
2309         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2310
2311 2019-03-18  Xan Lopez  <xan@igalia.com>
2312
2313         [CMake] Prevent potential warning when determining $architecture
2314         https://bugs.webkit.org/show_bug.cgi?id=195891
2315
2316         Reviewed by Michael Catanzaro.
2317
2318         It's possible for generateBuildSystemForCMakeProject to be called
2319         before determineArchitecture() is ever called. This will make the
2320         first eq check with $architecture to be bogus (and print a
2321         warning). Change that to an eq check with architecture(), which
2322         implicitly calls determineArchitecture() if needed, and change all
2323         the other similar cases in the method in the same way to prevent
2324         future bugs like this one.
2325
2326         * Scripts/webkitdirs.pm:
2327         (generateBuildSystemFromCMakeProject):
2328
2329 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2330
2331         [WPE] Tarballs generated with “make dist” cannot build documentation
2332         https://bugs.webkit.org/show_bug.cgi?id=195885
2333
2334         Reviewed by Carlos Garcia Campos.
2335
2336         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2337
2338 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2339
2340         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2341         https://bugs.webkit.org/show_bug.cgi?id=195883
2342
2343         Reviewed by Carlos Garcia Campos.
2344
2345         * gtkdoc/gtkdoc.py:
2346         (GTKDoc._run_command): When commands fail to run, include the full command line for
2347         the program invocation and the output it has generated on the standard error stream.
2348
2349 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2350
2351         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2352         https://bugs.webkit.org/show_bug.cgi?id=195786
2353
2354         Reviewed by Philippe Normand.
2355
2356         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2357         * wpe/jhbuild.modules: Ditto.
2358
2359 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2360
2361         [ews-build] Don't run clean builds on EWS builders
2362         https://bugs.webkit.org/show_bug.cgi?id=195851
2363
2364         Reviewed by Geoffrey Garen.
2365
2366         * BuildSlaveSupport/ews-build/factories.py:
2367
2368 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2369
2370         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2371         https://bugs.webkit.org/show_bug.cgi?id=195849
2372
2373         Reviewed by Chris Dumez.
2374
2375         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2376
2377         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2378         (runWebsiteDataStoreCustomPaths):
2379
2380 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2381
2382         webkitpy: Upload test results
2383         https://bugs.webkit.org/show_bug.cgi?id=195755
2384         <rdar://problem/48896182>
2385
2386         Reviewed by Aakash Jain.
2387
2388         Establish a new format for uploading results that is not tied to layout tests, apply
2389         that format to webkitpy tests.
2390
2391         * Scripts/webkitpy/common/checkout/scm/git.py:
2392         (Git.native_branch): Return what branch the current checkout is on.
2393         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2394         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2395         * Scripts/webkitpy/common/checkout/scm/svn.py:
2396         (SVN.native_branch): Ditto.
2397         * Scripts/webkitpy/common/system/platforminfo.py:
2398         (PlatformInfo.build_version): Return a build version for Mac.
2399         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2400         (MockPlatformInfo.__init__):
2401         (MockPlatformInfo.build_version):
2402         * Scripts/webkitpy/results: Added.
2403         * Scripts/webkitpy/results/__init__.py: Added.
2404         * Scripts/webkitpy/results/options.py: Added.
2405         (upload_options): OptParse list for upload options.
2406         * Scripts/webkitpy/results/upload.py: Added.
2407         (Upload): Class which enforces the upload format expected by the results server.
2408         (Upload.Expectations):
2409         (Upload.create_configuration):
2410         (Upload.create_commit):
2411         (Upload.create_details):
2412         (Upload.create_run_stats):
2413         (Upload.create_test_result):
2414         (Upload.__init__):
2415         (Upload.Encoder): Encode Upload object as json.
2416         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2417         * Scripts/webkitpy/results/upload_unittest.py: Added.
2418         * Scripts/webkitpy/test/main.py:
2419         (Tester._parse_args): Add upload arguments.
2420         (Tester._run_tests): Allow results to be uploaded.
2421         * Scripts/webkitpy/test/runner.py:
2422         (Runner.__init__): Record which tests were run, rather than just counting them.
2423         (Runner.handle):
2424         * Scripts/webkitpy/test/runner_unittest.py:
2425         (RunnerTest.test_run):
2426         * Scripts/webkitpy/thirdparty/__init__.py:
2427         (AutoinstallImportHook.find_module): Add requests auto-install.
2428         (AutoinstallImportHook._install_requests):
2429         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2430         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2431
2432 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2433
2434         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2435         https://bugs.webkit.org/show_bug.cgi?id=195810
2436
2437         Reviewed by Tim Horton.
2438
2439         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2440         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2441         ending certain layout tests.
2442
2443         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2444         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2445         (-[TestRunnerWKWebView dealloc]):
2446         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2447
2448         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2449         helper method when destroying the web view, and when resetting state between tests.
2450
2451         * WebKitTestRunner/ios/TestControllerIOS.mm:
2452         (WTR::TestController::platformResetStateToConsistentValues):
2453
2454         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2455
2456 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2457
2458         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2459         https://bugs.webkit.org/show_bug.cgi?id=190350
2460         <rdar://problem/45089503>
2461
2462         Reviewed by Geoffrey Garen.
2463
2464         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2465         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2466         (TEST):
2467         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2468         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2469         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2470         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2471         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2472         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2473         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2474         (runTest):
2475         (createDirectories):
2476         (TEST):
2477         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2478         (TEST):
2479         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2480         (TEST):
2481
2482 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2483
2484         Add support to WebPage for getting the contents as an attributed string.
2485         https://bugs.webkit.org/show_bug.cgi?id=195636
2486         rdar://problem/45055697
2487
2488         Reviewed by Tim Horton.
2489
2490         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2491         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2492
2493 2019-03-15  Chris Dumez  <cdumez@apple.com>
2494
2495         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2496         https://bugs.webkit.org/show_bug.cgi?id=195747
2497
2498         Reviewed by Geoff Garen.
2499
2500         Add API test coverage.
2501
2502         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2503
2504 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2505
2506         Unreviewed, rolling out r242952.
2507
2508         Causing API failures on iOS Simulator
2509
2510         Reverted changeset:
2511
2512         "[PSON] Make sure the WebProcessCache is leverage when
2513         relaunching a process after termination"
2514         https://bugs.webkit.org/show_bug.cgi?id=195747
2515         https://trac.webkit.org/changeset/242952
2516
2517 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2518
2519         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2520         https://bugs.webkit.org/show_bug.cgi?id=195740
2521
2522         Reviewed by Ross Kirsling.
2523
2524         window.open doesn't work for WebKitBrowserWindow because it is not
2525         implemented yet.
2526
2527         1. Implemented createNewPage callback of WKPageUIClient.
2528         2. Changed MainWindow to take a BrowserWindow factory function
2529           instead of BrowserWindowType to be flexible to create
2530           BrowserWindow with extra settings.
2531         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2532           because it is not relevant with MainWindow anymore.
2533
2534         * MiniBrowser/win/Common.cpp:
2535         (parseCommandLine):
2536         * MiniBrowser/win/Common.h:
2537         (CommandLineOptions::CommandLineOptions):
2538         * MiniBrowser/win/MainWindow.cpp:
2539         (MainWindow::MainWindow):
2540         (MainWindow::create):
2541         (MainWindow::init):
2542         (MainWindow::WndProc):
2543         * MiniBrowser/win/MainWindow.h:
2544         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2545         (PrintWebUIDelegate::createWebViewWithRequest):
2546         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2547         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2548         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2549         (WebKitBrowserWindow::updateProxySettings):
2550         (WebKitBrowserWindow::createNewPage):
2551         * MiniBrowser/win/WebKitBrowserWindow.h:
2552         * MiniBrowser/win/WinMain.cpp:
2553         (wWinMain):
2554
2555 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2556
2557         Make it possible to test scrolling tree layer manipulation more easily
2558         https://bugs.webkit.org/show_bug.cgi?id=195780
2559
2560         Reviewed by Tim Horton.
2561         
2562         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2563         cuts off communication of scrolling tree scrolls back to the web process
2564         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2565         allows tests to trigger scrolls which run the scrolling tree layer positioning
2566         logic, but never get another commit from the web process that might mask
2567         scrolling tree bugs.
2568         
2569         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2570         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2571         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2572
2573         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2574         (WTR::UIScriptController::scrollUpdatesDisabled const):
2575         (WTR::UIScriptController::setScrollUpdatesDisabled):
2576         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2577         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2578         (WTR::UIScriptController::scrollUpdatesDisabled const):
2579         (WTR::UIScriptController::setScrollUpdatesDisabled):
2580         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2581         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2582         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2583         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2584         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2585         * WebKitTestRunner/ios/TestControllerIOS.mm:
2586         (WTR::TestController::platformResetStateToConsistentValues):
2587         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2588         (WTR::UIScriptController::scrollUpdatesDisabled const):
2589         (WTR::UIScriptController::setScrollUpdatesDisabled):
2590
2591 2019-03-14  Youenn Fablet  <youenn@apple.com>
2592
2593         Move IDB storage in private browsing mode to NetworkProcess
2594         https://bugs.webkit.org/show_bug.cgi?id=195602
2595
2596         Reviewed by Brady Eidson.
2597
2598         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2599         (TEST):
2600
2601 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2602
2603         [ews-build] Make descriptionDone messages more readable
2604         https://bugs.webkit.org/show_bug.cgi?id=195760
2605
2606         Reviewed by Lucas Forschler.
2607
2608         * BuildSlaveSupport/ews-build/steps.py:
2609         * BuildSlaveSupport/ews-build/steps_unittest.py:
2610
2611 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2612
2613         [ews-build] Generate status-bubble hover-over messages
2614         https://bugs.webkit.org/show_bug.cgi?id=195680
2615
2616         Reviewed by Lucas Forschler.
2617
2618         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2619         (StatusBubble):
2620         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2621         on hover-over.
2622         (StatusBubble._iso_time):
2623         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2624         hover-over message.
2625         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2626
2627 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2628
2629         [ews-app] Gracefully handle the case when state_string is None
2630         https://bugs.webkit.org/show_bug.cgi?id=195753
2631
2632         Reviewed by Lucas Forschler.
2633
2634         * BuildSlaveSupport/ews-app/ews/models/build.py:
2635         * BuildSlaveSupport/ews-app/ews/models/step.py:
2636
2637 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2638
2639         [ews-app] Status bubble display pending for currently running build step
2640         https://bugs.webkit.org/show_bug.cgi?id=195744
2641
2642         Reviewed by Lucas Forschler.
2643
2644         * BuildSlaveSupport/ews-build/events.py:
2645         (Events.stepStarted): If state_string is pending, replace it with step name.
2646
2647 2019-03-14  Chris Dumez  <cdumez@apple.com>
2648
2649         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2650         https://bugs.webkit.org/show_bug.cgi?id=195750
2651
2652         Reviewed by Geoffrey Garen.
2653
2654         Add API test coverage.
2655
2656         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2657         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2658         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2659         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2660
2661 2019-03-14  Chris Dumez  <cdumez@apple.com>
2662
2663         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2664         https://bugs.webkit.org/show_bug.cgi?id=195747
2665
2666         Reviewed by Geoff Garen.
2667
2668         Add API test coverage.
2669
2670         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2671
2672 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2673
2674         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2675         https://bugs.webkit.org/show_bug.cgi?id=195725
2676         <rdar://problem/48545062>
2677
2678         Reviewed by Tim Horton.
2679
2680         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2681         handler is nil.
2682
2683         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2684         (TestWebKitAPI::TEST):
2685
2686 2019-03-13  Sam Weinig  <sam@webkit.org>
2687
2688         Add utility function to allow easy reverse range-based iteration of a container
2689         https://bugs.webkit.org/show_bug.cgi?id=195542
2690
2691         Reviewed by Antti Koivisto.
2692
2693         * TestWebKitAPI/CMakeLists.txt:
2694         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2695         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2696         (TestWebKitAPI::TEST):
2697         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2698
2699 2019-03-13  Chris Dumez  <cdumez@apple.com>
2700
2701         Use a ServiceWorker process per registrable domain
2702         https://bugs.webkit.org/show_bug.cgi?id=195649
2703
2704         Reviewed by Youenn Fablet.
2705
2706         Update API test coverage.
2707
2708         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2709
2710 2019-03-13  Chris Dumez  <cdumez@apple.com>
2711
2712         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2713         https://bugs.webkit.org/show_bug.cgi?id=195684
2714         <rdar://problem/48294714>
2715
2716         Reviewed by Antti Koivisto.
2717
2718         Add API test coverage.
2719
2720         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2721
2722 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2723
2724         [ews-app] Remove unused patch view
2725         https://bugs.webkit.org/show_bug.cgi?id=195669
2726
2727         Reviewed by Lucas Forschler.
2728
2729         * BuildSlaveSupport/ews-app/ews/urls.py:
2730         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2731
2732 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2733
2734         [ews-app] Use Buildbot result code variables
2735         https://bugs.webkit.org/show_bug.cgi?id=195668
2736
2737         Reviewed by Alexey Proskuryakov.
2738
2739         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2740         (Buildbot): Added Buildbot result code variables.
2741         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2742         (StatusBubble._build_bubble): Used Buildbot result code variables.
2743
2744 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2745
2746         [Flatpak] Expand submodule recursively
2747         https://bugs.webkit.org/show_bug.cgi?id=195672
2748
2749         Building WPE with flatpak was impossible without that as it was raising an exception.
2750         Also update wpebackend-fdo to match what is built in jhbuild
2751
2752         Reviewed by Philippe Normand.
2753
2754         * flatpak/flatpakutils.py:
2755         (expand_submodules_recurse):
2756         (expand_manifest):
2757         * flatpak/org.webkit.WPEModules.yaml:
2758
2759 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2760
2761         [ews-app] status bubble should be hidden for certain builds
2762         https://bugs.webkit.org/show_bug.cgi?id=194597
2763
2764         Reviewed by Dewei Zhu.
2765
2766         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2767         (StatusBubble._build_bubble):
2768         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2769         because the patch didn't have relevant changes.
2770         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2771         in production yet.
2772
2773 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2774
2775         [Win] Fix a slew of simple clang-cl warnings.
2776         https://bugs.webkit.org/show_bug.cgi?id=195652
2777
2778         Reviewed by Don Olmstead.
2779
2780         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2781         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2782
2783 2019-03-12  Justin Fan  <justin_fan@apple.com>
2784
2785         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2786         https://bugs.webkit.org/show_bug.cgi?id=195518
2787         <rdar://problem/46322356>
2788
2789         Reviewed by Myles C. Maxfield.
2790
2791         * DumpRenderTree/DerivedSources-input.xcfilelist:
2792         * DumpRenderTree/DerivedSources-output.xcfilelist:
2793
2794 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2795
2796         Unreviewed, rolling out r242825.
2797         https://bugs.webkit.org/show_bug.cgi?id=195648
2798
2799         "Broke webkitpy tests with my change to
2800         lldb_dump_class_layout.py" (Requested by rmorisset on
2801         #webkit).
2802
2803         Reverted changeset:
2804
2805         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2806         classes with suspicious padding"
2807         https://bugs.webkit.org/show_bug.cgi?id=195573
2808         https://trac.webkit.org/changeset/242825
2809
2810 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2811
2812         [ews-build] Show status bubbles while the patch is waiting in queue
2813         https://bugs.webkit.org/show_bug.cgi?id=195618
2814
2815         Reviewed by Lucas Forschler.
2816
2817         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2818         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2819         enabled in initial deployment.
2820         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2821         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2822         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2823         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2824         (StatusBubble._build_bubbles_for_patch):
2825
2826 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2827
2828         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2829         https://bugs.webkit.org/show_bug.cgi?id=195573
2830
2831         Reviewed by Simon Fraser.
2832
2833         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2834
2835         * Scripts/dump-class-layout:
2836         (main):
2837         * lldb/lldb_dump_class_layout.py:
2838         (ClassLayout.__init__):
2839         (ClassLayout._compute_padding_recursive):
2840         (LLDBDebuggerInstance.dump_layout_for_classname):
2841         (LLDBDebuggerInstance):
2842         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2843         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2844
2845 2019-03-12  Chris Dumez  <cdumez@apple.com>
2846
2847         Device Orientation access permission should be denied unless explicitly granted by the client
2848         https://bugs.webkit.org/show_bug.cgi?id=195625
2849
2850         Reviewed by Youenn Fablet.
2851
2852         add API test coverage.
2853
2854         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2855         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2856         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2857         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2858         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2859         (runDeviceOrientationTest):
2860         (TEST):
2861         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2862         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2863
2864 2019-03-12  Jer Noble  <jer.noble@apple.com>
2865
2866         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2867         https://bugs.webkit.org/show_bug.cgi?id=195137
2868         <rdar://problem/48810307>
2869
2870         Reviewed by Eric Carlson.
2871
2872         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2873         (TestWebKitAPI::TEST):
2874
2875 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2876
2877         [ews-build] Change urls from uat to production
2878         https://bugs.webkit.org/show_bug.cgi?id=195566
2879
2880         Reviewed by Lucas Forschler.
2881
2882         * BuildSlaveSupport/ews-app/ews/config.py:
2883         * BuildSlaveSupport/ews-build/events.py:
2884         * BuildSlaveSupport/ews-build/steps.py:
2885
2886 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2887
2888         [ews-build] change max_builds for local-worker to 1
2889         https://bugs.webkit.org/show_bug.cgi?id=195568
2890
2891         Reviewed by Lucas Forschler.
2892
2893         * BuildSlaveSupport/ews-build/loadConfig.py:
2894
2895 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2896
2897         Fix the build
2898
2899         * TestRunnerShared/spi/PencilKitTestSPI.h:
2900         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2901
2902 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2903
2904         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2905         https://bugs.webkit.org/show_bug.cgi?id=194131
2906
2907         Reviewed by Michael Catanzaro.
2908
2909         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2910         (uriChanged):
2911         (testUnfinishedSubresourceLoad):
2912         (serverCallback):
2913         (beforeAll):
2914
2915 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2916
2917         WTF::Expected should use std::addressof instead of operator&
2918         https://bugs.webkit.org/show_bug.cgi?id=195604
2919
2920         Reviewed by Myles Maxfield.
2921
2922         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2923         (TestWebKitAPI::Unique::Unique):
2924         (TestWebKitAPI::Unique::operator&):
2925         (TestWebKitAPI::TEST):
2926
2927 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2928
2929         Add Optional to Forward.h.
2930         https://bugs.webkit.org/show_bug.cgi?id=195586
2931
2932         Reviewed by Darin Adler.
2933
2934         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2935         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2936         Remove unnecessary includes from headers.
2937
2938 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2939
2940         Add testing API to hit-test and scroll overflow scrollers
2941         https://bugs.webkit.org/show_bug.cgi?id=195278
2942
2943         Reviewed by Antti Koivisto.
2944         
2945         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2946         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2947         
2948         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2949
2950         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2951         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2952         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2953         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2954         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2955         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2956         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2957         (WTR::enclosingScrollViewIncludingSelf):
2958         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2959
2960 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2961
2962         API test WebKit.RequestTextInputContext fails on iOS
2963         https://bugs.webkit.org/show_bug.cgi?id=195585
2964
2965         Reviewed by Wenson Hsieh and Simon Fraser.
2966
2967         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2968         (applyStyle):
2969         (TEST):
2970         Add a viewport, so that the coordinates match up on iOS.
2971         Scroll by moving the UIScrollView's contentOffset.
2972
2973 2019-03-11  Chris Dumez  <cdumez@apple.com>
2974
2975         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2976         https://bugs.webkit.org/show_bug.cgi?id=195506
2977         <rdar://problem/48733477>
2978
2979         Reviewed by Alex Christensen.
2980
2981         Add API test coverage.
2982
2983         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2984
2985 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2986
2987         Adding myself to contributors.json
2988
2989         Unreviewed, addming myself to contributors.json .
2990
2991         * Scripts/webkitpy/common/config/contributors.json:
2992
2993 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2994
2995         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2996         https://bugs.webkit.org/show_bug.cgi?id=195511
2997         <rdar://problem/44873269>
2998
2999         Reviewed by Darin Adler.
3000
3001         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3002         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3003         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3004         (TEST_F):
3005
3006 2019-03-11  Chris Dumez  <cdumez@apple.com>
3007
3008         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3009         https://bugs.webkit.org/show_bug.cgi?id=195561
3010
3011         Reviewed by Youenn Fablet.
3012
3013         Make sure the JS in the test requests for permission to receive device orientation events.
3014
3015         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3016
3017 2019-03-11  Youenn Fablet  <youenn@apple.com>
3018
3019         Allow storage quota increase by default in WTR
3020         https://bugs.webkit.org/show_bug.cgi?id=195541
3021
3022         Reviewed by Geoffrey Garen.
3023
3024         Allow storage quota increase by default in WTR.
3025         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3026         Use this for tests that explicitly need cache increase.
3027
3028         Instead of increasing quota by 2, make sure the next request is
3029         granted by adding all given parameters.
3030
3031         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3032         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3033         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3034         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3035         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3036         * WebKitTestRunner/TestController.cpp:
3037         (WTR::TestController::setAllowStorageQuotaIncrease):
3038         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3039         * WebKitTestRunner/TestController.h:
3040         * WebKitTestRunner/TestInvocation.cpp:
3041         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3042         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3043         (WTR::TestController::cocoaResetStateToConsistentValues):
3044         (WTR::TestController::setAllowStorageQuotaIncrease):
3045         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3046         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3047         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3048
3049 2019-03-11  Xan Lopez  <xan@igalia.com>
3050
3051         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3052         https://bugs.webkit.org/show_bug.cgi?id=194147
3053
3054         Reviewed by Michael Saboff.
3055
3056         To make --32-bit work correctly on Linux/64bit we need to:
3057
3058         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3059         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3060         unfortunately CMake only allows us to do this during
3061         crosscompilation, which is overkill here.
3062         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3063         pkg-config detection module uses the x86 .pc files instead of the
3064         x86_64 ones.
3065         - Set the -m32 flags for the compiler.
3066
3067         * Scripts/webkitdirs.pm:
3068         (generateBuildSystemFromCMakeProject):
3069
3070 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3071
3072         Add MotionMark-1.1 plan file for run-benchmark script.
3073         https://bugs.webkit.org/show_bug.cgi?id=195481
3074
3075         Rubber-stamped by Darin Adler.
3076
3077         Run-benchmark script should support MontionMark-1.1.
3078
3079         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3080
3081 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3082
3083         [ews-app] Add support for submit-to-ews url
3084         https://bugs.webkit.org/show_bug.cgi?id=195477
3085
3086         Reviewed by Lucas Forschler.
3087
3088         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3089         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3090         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3091         * BuildSlaveSupport/ews-app/ews/urls.py:
3092         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3093
3094 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3095
3096         Unreviewed, rolling out r242688, r242643, r242624.
3097
3098         Caused multiple layout test failures and crashes on iOS and macOS.
3099
3100         Reverted changeset:
3101
3102         "requestAnimationFrame should execute before the next frame"
3103         https://bugs.webkit.org/show_bug.cgi?id=177484
3104         https://trac.webkit.org/changeset/242624/webkit
3105
3106         * Tracing/SystemTracePoints.plist:
3107
3108 2019-03-11  John Wilander  <wilander@apple.com>
3109
3110         Resource Load Statistics: Make it possible exclude localhost from classification
3111         https://bugs.webkit.org/show_bug.cgi?id=195474
3112         <rdar://problem/47520577>
3113
3114         Reviewed by Brent Fulgham.
3115
3116         This patch allows for localhost to be excluded from classification and
3117         treatment as a prevalent resource.
3118
3119         The WebKit Tools change adds a new function called
3120         testRunner.setStatisticsIsRunningTest() which can be used to control this
3121         behavior.
3122
3123         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3124         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3125         (WTR::TestRunner::setStatisticsIsRunningTest):
3126         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3127         * WebKitTestRunner/TestController.cpp:
3128         (WTR::TestController::setStatisticsIsRunningTest):
3129         * WebKitTestRunner/TestController.h:
3130         * WebKitTestRunner/TestInvocation.cpp:
3131         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3132
3133 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3134
3135         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3136         https://bugs.webkit.org/show_bug.cgi?id=195560
3137
3138         Reviewed by Lucas Forschler.
3139
3140         * BuildSlaveSupport/ews-build/master.cfg:
3141
3142 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3143
3144         Unreviewed, rolling out r242698.
3145
3146         API test crashes on bots.
3147
3148         Reverted changeset:
3149
3150         "Add a WKContentRuleList variant that uses copied memory
3151         instead of mmap'd shared memory for class A containerized
3152         apps"
3153         https://bugs.webkit.org/show_bug.cgi?id=195511
3154         https://trac.webkit.org/changeset/242698
3155
3156 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3157
3158         [WPE] Enable web process sandbox
3159         https://bugs.webkit.org/show_bug.cgi?id=195169
3160
3161         Reviewed by Daniel Bates.
3162
3163         * wpe/install-dependencies:
3164         * wpe/jhbuild.modules:
3165
3166 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3167
3168         [ews-app] Use port 17000 for worker communication
3169         https://bugs.webkit.org/show_bug.cgi?id=195558
3170
3171         Reviewed by Lucas Forschler.
3172
3173         * BuildSlaveSupport/ews-build/master.cfg:
3174
3175 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3176
3177         [ews-build] unit-tests fail when passwords.json is missing
3178         https://bugs.webkit.org/show_bug.cgi?id=195557
3179
3180         Reviewed by Lucas Forschler.
3181
3182         * BuildSlaveSupport/ews-build/loadConfig.py:
3183         (loadBuilderConfig):
3184         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3185         (ConfigDotJSONTest.test_configuration):
3186         * BuildSlaveSupport/ews-build/master.cfg:
3187
3188 2019-03-11  Truitt Savell  <tsavell@apple.com>
3189
3190         Unreviewed, rolling out r242702.
3191
3192         Broke High Sierra builders.
3193
3194         Reverted changeset:
3195
3196         "Add utility function to allow easy reverse range-based
3197         iteration of a container"
3198         https://bugs.webkit.org/show_bug.cgi?id=195542
3199         https://trac.webkit.org/changeset/242702
3200
3201 2019-03-11  Sam Weinig  <sam@webkit.org>
3202
3203         Add utility function to allow easy reverse range-based iteration of a container
3204         https://bugs.webkit.org/show_bug.cgi?id=195542
3205
3206         Reviewed by Antti Koivisto.
3207
3208         * TestWebKitAPI/CMakeLists.txt:
3209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3210         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3211         (TestWebKitAPI::TEST):
3212         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3213
3214 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3215
3216         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3217         https://bugs.webkit.org/show_bug.cgi?id=195511
3218         <rdar://problem/44873269>
3219
3220         Reviewed by Darin Adler.
3221
3222         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3223         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3224         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3225         (TEST_F):
3226
3227 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3228
3229         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3230         https://bugs.webkit.org/show_bug.cgi?id=195499
3231
3232         Reviewed by Darin Adler.
3233
3234         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3235         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3236         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3237         (-[WKWebView synchronouslyFocusTextInputContext:]):
3238         (applyStyle):
3239         (applyIframe):
3240         (TEST):
3241         Add some tests for this SPI.
3242
3243 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3244
3245         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3246         https://bugs.webkit.org/show_bug.cgi?id=181151
3247
3248         Reviewed by Don Olmstead.
3249
3250         * TestWebKitAPI/CMakeLists.txt:
3251         * TestWebKitAPI/PlatformWin.cmake:
3252         Enable TestWTF RunLoop tests in all platforms.
3253
3254         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3255         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3256         (TestWebKitAPI::DerivedOneShotTimer::fired):
3257         (TestWebKitAPI::TEST):
3258         Only a few platforms support nested RunLoop.
3259
3260         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3261         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3262
3263 2019-03-10  David Quesada  <david_quesada@apple.com>
3264
3265         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3266         https://bugs.webkit.org/show_bug.cgi?id=152480
3267
3268         Reviewed by Chris Dumez.
3269
3270         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3271         there are no additional references to the process pool besides the one held by
3272         the download, waits for the download to finish (in the sense that the
3273         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3274         measure, also check that the process pool has been deallocated at the end of the
3275         test. The test wouldn't be meaningful if the process pool were still alive.
3276
3277         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3278         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3279         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3280             The download will be canceled because the delegate does not implement the
3281             method to decide the download's destination, so this is where we know the
3282             DownloadProxyMap is done with the DownloadProxy.
3283         (TEST):
3284
3285 2019-03-08  Chris Dumez  <cdumez@apple.com>
3286
3287         Add support for Device Orientation / Motion permission API
3288         https://bugs.webkit.org/show_bug.cgi?id=195329
3289         <rdar://problem/47645367>
3290
3291         Reviewed by Geoffrey Garen.
3292
3293         Add test infrastructure to help test the Device Orientation / Motion permission API.
3294
3295         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3296         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3297         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3298         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3299         * WebKitTestRunner/TestController.cpp:
3300         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3301         (WTR::TestController::createWebViewWithOptions):
3302         (WTR::TestController::resetStateToConsistentValues):
3303         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3304         * WebKitTestRunner/TestController.h:
3305         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3306         * WebKitTestRunner/TestInvocation.cpp:
3307         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3308
3309 2019-03-08  Saam barati  <sbarati@apple.com>
3310
3311         Add a compare-results script to compare benchmark results
3312         https://bugs.webkit.org/show_bug.cgi?id=195486
3313         <rdar://problem/48723397>
3314
3315         Reviewed by Geoffrey Garen.
3316
3317         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3318         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3319         to extend it to learn about our other benchmarks.
3320
3321         * Scripts/compare-results: Added.
3322         (readJSONFile):
3323         (detectJetStream2):
3324         (JetStream2Results):
3325         (detectSpeedometer2):
3326         (Speedometer2Results):
3327         (detectPLT5):
3328         (PLT5Results):
3329         (detectBenchmark):
3330         (biggerIsBetter):
3331         (ttest):
3332         (getOptions):
3333         (main):
3334
3335 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3336
3337         Ensure old tab state is cleared between iterations of run-benchmark
3338         https://bugs.webkit.org/show_bug.cgi?id=195393
3339         <rdar://problem/46885583>
3340
3341         Reviewed by Dewei Zhu.
3342
3343         a) ensure the default to restore state is not set
3344         b) terminate Safari correctly
3345         c) Set the system default to ignore Persistent State in Safari
3346
3347         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3348         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3349         (OSXBrowserDriver.prepare_env): 
3350         (OSXBrowserDriver.restore_env):
3351         (OSXBrowserDriver.close_browsers):
3352         (OSXBrowserDriver._terminate_processes):
3353         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3354         (OSXChromeDriver):
3355         (OSXChromeCanaryDriver):
3356         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3357         (OSXFirefoxDriver):
3358         (OSXFirefoxNightlyDriver):
3359         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3360         (OSXSafariDriver):
3361         (OSXSafariDriver.prepare_env):
3362
3363 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3364
3365         [GTK] Several InputMethodFilter tests are failing
3366         https://bugs.webkit.org/show_bug.cgi?id=195408
3367
3368         Reviewed by Carlos Garcia Campos.
3369
3370         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3371         Regressed in r241751.
3372         Hexadecimal values of keycodes are expressed now in upper letters.
3373         Composited characters should be cast to UTF8 strings.
3374
3375         (TestWebKitAPI::TEST):
3376
3377 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3378
3379         [GTK] Make Tools/gtkdoc python3 compatible
3380         https://bugs.webkit.org/show_bug.cgi?id=195359
3381
3382         Reviewed by Carlos Garcia Campos.
3383
3384         * gtkdoc/generate-gtkdoc:
3385         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3386         work with Python 2 and 3.
3387         (get_gtkdoc_module_paths):
3388         The iteritems() was removed in Python 3, so let's use items() that's
3389         available in Python 2 and 3.
3390         (get_generator_for_config):
3391         * gtkdoc/gtkdoc.py:
3392         (GTKDoc._run_command):
3393         The sys.stdout.write() is expecting str in Python 3 and not bytes
3394         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3395         for passing the bytes there.
3396
3397 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3398
3399         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3400         https://bugs.webkit.org/show_bug.cgi?id=195346
3401         <rdar://problem/48667048>
3402
3403         Unreviewed build fix for clang-cl.
3404
3405         * DumpRenderTree/win/DumpRenderTree.cpp:
3406         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3407
3408 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3409
3410         requestAnimationFrame should execute before the next frame
3411         https://bugs.webkit.org/show_bug.cgi?id=177484
3412
3413         Reviewed by Simon Fraser.
3414
3415         Add trace points for the page RenderingUpdate.
3416
3417         * Tracing/SystemTracePoints.plist:
3418
3419 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3420
3421         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3422         https://bugs.webkit.org/show_bug.cgi?id=195353
3423         <rdar://problem/48626394>
3424
3425         Reviewed by Simon Fraser.
3426
3427         * WebKitTestRunner/ios/TestControllerIOS.mm:
3428         (WTR::TestController::platformResetPreferencesToConsistentValues):
3429
3430 2019-03-07  John Wilander  <wilander@apple.com>
3431
3432         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3433         https://bugs.webkit.org/show_bug.cgi?id=195383
3434         <rdar://problem/48570136>
3435
3436         Reviewed by Brent Fulgham.
3437
3438         This patch adds test infrastructure to purge only script-accessible cookies,
3439         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3440
3441         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3442         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3443         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3444         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3445         * WebKitTestRunner/TestController.cpp:
3446         (WTR::TestController::statisticsDeleteCookiesForHost):
3447         * WebKitTestRunner/TestController.h:
3448         * WebKitTestRunner/TestInvocation.cpp:
3449         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3450
3451 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3452
3453         Unreviewed, rolling out r242354.
3454         https://bugs.webkit.org/show_bug.cgi?id=195402
3455
3456         breaks layout tests in all configurations (Requested by
3457         zdobersek on #webkit).
3458
3459         Reverted changeset:
3460
3461         "[WPE] Enable web process sandbox"
3462         https://bugs.webkit.org/show_bug.cgi?id=195169
3463         https://trac.webkit.org/changeset/242354
3464
3465 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3466
3467         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3468         https://bugs.webkit.org/show_bug.cgi?id=195346
3469
3470         Reviewed by Fujii Hironori.
3471
3472         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3473         (TestWebKitAPI::TEST):
3474         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3475
3476         * DumpRenderTree/win/DumpRenderTree.cpp:
3477         (findFontFallback):
3478         (addFontFallbackIfPresent):
3479         (removeFontFallbackIfPresent):
3480         (main):
3481         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3482         (TestWebKitAPI::Util::moduleDirectory):
3483         (TestWebKitAPI::Util::createInjectedBundlePath):
3484         Use wchar helpers as needed.
3485
3486 2019-03-06  Rob Buis  <rbuis@igalia.com>
3487
3488         Consider supporting the `referrerpolicy` attribute.
3489         https://bugs.webkit.org/show_bug.cgi?id=179053
3490
3491         Reviewed by Darin Adler.
3492
3493         Add a runtime flag for referrerpolicy attribute.
3494
3495         * DumpRenderTree/mac/DumpRenderTree.mm:
3496         (enableExperimentalFeatures):
3497
3498 2019-03-05  Daniel Bates  <dabates@apple.com>
3499
3500         Update expected API test result following r242379
3501         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3502
3503         Update expected x-coordinate of selection rect now that the left padding of
3504         a textarea is sized in ems (so dependent on the font size) just like the left
3505         padding of a text field.
3506
3507         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3508         (TestWebKitAPI::TEST):
3509
3510 2019-03-05  David Quesada  <david_quesada@apple.com>
3511
3512         [WK2] It should be possible to follow links with 'download' attributes
3513         https://bugs.webkit.org/show_bug.cgi?id=195145
3514         rdar://problem/48462642
3515
3516         Reviewed by Alex Christensen.
3517
3518         Add a unit test to verify that activating links with 'download' attributes now
3519         navigates to the linked resource, rather than starts downloading it. Add another
3520         to verify that it is still possible to explicitly download the link via the
3521         'Download' navigation action policy.
3522
3523         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3524         (-[DownloadAttributeTestDelegate init]):
3525         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3526         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3527         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3528         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3529         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3530         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3531         (TEST):
3532         * WebKitTestRunner/TestController.cpp:
3533         (WTR::TestController::decidePolicyForNavigationAction):
3534         * WebKitTestRunner/TestController.h:
3535
3536 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3537
3538         [Curl] Implement Cookie Accept Policy.
3539         https://bugs.webkit.org/show_bug.cgi?id=191645
3540
3541         Reviewed by Fujii Hironori.
3542
3543         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3544         (TestWebKitAPI::Curl::TEST_F):
3545
3546 2019-03-05  Youenn Fablet  <youenn@apple.com>
3547
3548         Rename requestCacheStorageSpace to requestStorageSpace
3549         https://bugs.webkit.org/show_bug.cgi?id=195282
3550
3551         Reviewed by Chris Dumez.
3552
3553         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3554         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3555         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3556
3557 2019-03-05  Brady Eidson  <beidson@apple.com>
3558
3559         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3560         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3561
3562         Reviewed by Tim Horton.
3563
3564         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3565         different directory into that same WKWebView should work.
3566
3567         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3568         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3569
3570 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3571
3572         Add WeakHashSet
3573         https://bugs.webkit.org/show_bug.cgi?id=195152
3574
3575         Reviewed by Antti Koivisto.
3576
3577         Added tests for WeakHashSet.
3578
3579         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3580         (TestWebKitAPI::Base::Base): Moved.
3581         (TestWebKitAPI::Derived::foo): Moved.
3582         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3583         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3584         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3585         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3586
3587 2019-03-04  Chris Dumez  <cdumez@apple.com>
3588
3589         Do not share WebProcesses between private and regular sessions
3590         https://bugs.webkit.org/show_bug.cgi?id=195189
3591         <rdar://problem/48421064>
3592
3593         Reviewed by Alex Christensen.
3594
3595         Add API test coverage.
3596
3597         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3598         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3599
3600 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3601
3602         [WPE] Enable web process sandbox
3603         https://bugs.webkit.org/show_bug.cgi?id=195169
3604
3605         Reviewed by Daniel Bates.
3606
3607         * wpe/install-dependencies:
3608         * wpe/jhbuild.modules:
3609
3610 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3611
3612         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3613         https://bugs.webkit.org/show_bug.cgi?id=195206
3614
3615         Reviewed by Žan Doberšek.
3616
3617         Add a new test case.
3618
3619         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3620         (testJSCClass):
3621
3622 2019-03-04  Charlie Turner  <cturner@igalia.com>
3623
3624         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3625         https://bugs.webkit.org/show_bug.cgi?id=194898
3626
3627         Reviewed by Žan Doberšek.
3628
3629         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3630         a GCC extension that permits arithmetic on void* pointer. Inline
3631         the macro until this issue is fixed upstream.
3632
3633 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3634
3635         Rid the world of WK_API_ENABLED
3636         https://bugs.webkit.org/show_bug.cgi?id=195263
3637
3638         Reviewed by Dan Bernstein.
3639
3640         List of changed files elided because it's useless.
3641
3642 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3643
3644         Unreviewed follow-up to r242292.
3645
3646         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3647
3648         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3649         (TestWebKitAPI::testStrip): Renamed from strip.
3650         (TestWebKitAPI::TEST):
3651
3652 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3653
3654         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3655
3656         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3657         and bug #194272 for details.
3658
3659         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3660
3661 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3662
3663         Remove some more unused 32-bit code
3664         https://bugs.webkit.org/show_bug.cgi?id=195255
3665
3666         Reviewed by Darin Adler.
3667
3668         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3669         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3670         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3671         (NPP_New):
3672         (NPP_HandleEvent):
3673         (handleEventCarbon): Deleted.
3674
3675 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3676
3677         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3678
3679         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3680         (TestWebKitAPI::TEST):
3681
3682 2019-03-01  Darin Adler  <darin@apple.com>
3683
3684         Finish removing String::format
3685         https://bugs.webkit.org/show_bug.cgi?id=194893
3686
3687         Reviewed by Daniel Bates.
3688 '
3689         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3690
3691 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3692
3693         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3694         https://bugs.webkit.org/show_bug.cgi?id=195229
3695         <rdar://problem/48520362>
3696
3697         Reviewed by Chris Dumez.
3698
3699         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3700         (TEST):
3701
3702 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3703
3704         Add a system trace scope for event region building
3705         https://bugs.webkit.org/show_bug.cgi?id=195226
3706
3707         Reviewed by Jon Lee.
3708
3709         This trace scope measures the time spend converting element rects into Region objects,
3710         which can be large on some pages.
3711
3712         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3713
3714         * Tracing/SystemTracePoints.plist:
3715
3716 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3717
3718         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3719         https://bugs.webkit.org/show_bug.cgi?id=194612
3720
3721         Reviewed by Alex Christensen.
3722
3723         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3724         Just test the new string-processing function and don't touch the actual environment.
3725         (Test cases are all as before, but based on operator== instead of strcmp.)
3726
3727 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3728
3729         [ews-app] Update primary keys for handling multiple Buildbot instances
3730         https://bugs.webkit.org/show_bug.cgi?id=195120
3731
3732         Reviewed by Stephanie Lewis.
3733
3734         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3735         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3736         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3737
3738         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3739         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3740         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3741         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3742         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3743         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3744
3745 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3746
3747         [WinCairo] Enable service worker
3748         https://bugs.webkit.org/show_bug.cgi?id=188318
3749
3750         Reviewed by Youenn Fablet.
3751
3752         * DumpRenderTree/DumpRenderTreePrefix.h:
3753         * TestWebKitAPI/PlatformWin.cmake:
3754         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3755         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3756         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3757
3758 2019-03-01  Justin Fan  <justin_fan@apple.com>
3759
3760         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3761         https://bugs.webkit.org/show_bug.cgi?id=195191
3762
3763         Rubber-stamped by Dean Jackson.
3764
3765         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3766
3767         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3768
3769 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3770
3771         Unreviewed, fix lldb webkitpy tests
3772         https://bugs.webkit.org/show_bug.cgi?id=194375
3773
3774         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3775
3776         * lldb/lldb_webkit.py:
3777         (WTFStringImplProvider.is_8bit):
3778
3779 2019-02-28  David Quesada  <david_quesada@apple.com>
3780
3781         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3782         https://bugs.webkit.org/show_bug.cgi?id=195121
3783         rdar://problem/48450302
3784
3785         Reviewed by Alex Christensen.
3786
3787         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3788         configurations where the 'download' attribute is absent, blank, or populated
3789         with a filename, and where the anchor element is same-origin or cross-origin
3790         (meaning the 'download' attribute shouldn't be honored).
3791
3792         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3793         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3794         (-[NavigationActionTestDelegate init]):
3795         (-[NavigationActionTestDelegate navigationAction]):
3796         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3797         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3798         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3799         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3800         (TEST):
3801
3802 2019-02-28  Antoine Quint  <graouts@apple.com>
3803
3804         Enable the Pointer Events runtime flag by default
3805         https://bugs.webkit.org/show_bug.cgi?id=195156
3806
3807         Reviewed by Dean Jackson.
3808
3809         * DumpRenderTree/mac/DumpRenderTree.mm:
3810         (enableExperimentalFeatures):
3811
3812 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3813
3814         Several PasteImage API tests are flaky
3815         https://bugs.webkit.org/show_bug.cgi?id=195160
3816
3817         Reviewed by Tim Horton.
3818
3819         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3820         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3821         listening for a "load" event after image load is already complete.
3822
3823         To address this, make these tests first register a "load" event handler, then run script to insert an image
3824         element into the document, and finally wait until the load event is observed before checking image size.
3825
3826         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3827
3828 2019-02-28  Chris Dumez  <cdumez@apple.com>
3829
3830         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3831         https://bugs.webkit.org/show_bug.cgi?id=195107
3832
3833         Reviewed by Alex Christensen.
3834
3835         Give some time for the zoom level to get restored.
3836
3837         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3838
3839 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3840
3841         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3842         https://bugs.webkit.org/show_bug.cgi?id=194958
3843
3844         Reviewed by Geoffrey Garen.
3845
3846         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3847         (TEST):
3848
3849 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3850
3851         [ews-app] Update method to save build to handle builder_display_name
3852         https://bugs.webkit.org/show_bug.cgi?id=195047
3853
3854         Reviewed by Dewei Zhu.
3855
3856         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3857         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3858
3859 2019-02-28  Justin Fan  <justin_fan@apple.com>
3860
3861         [Web GPU] Enable Web GPU only on 64-bit
3862         https://bugs.webkit.org/show_bug.cgi?id=195139
3863
3864         Because Metal is only supported on 64 bit apps.
3865
3866         Unreviewed build fix.
3867
3868         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3869
3870 2019-02-27  Youenn Fablet  <youenn@apple.com>
3871
3872         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3873         https://bugs.webkit.org/show_bug.cgi?id=194959
3874
3875         Reviewed by Chris Dumez.
3876
3877         Spin loop until getting the condition to remove flakiness.
3878
3879         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3880
3881 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3882
3883         [ews-build] Buildbot should include builder_display_name in the build events
3884         https://bugs.webkit.org/show_bug.cgi?id=195045
3885
3886         Reviewed by Dewei Zhu.
3887
3888         * BuildSlaveSupport/ews-build/events.py:
3889         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3890         buildername to builder_name to be consistent in naming style.
3891         (Events.buildFinished): Ditto.
3892
3893 2019-02-27  Chris Dumez  <cdumez@apple.com>
3894
3895         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3896         https://bugs.webkit.org/show_bug.cgi?id=194480
3897
3898         Reviewed by Brady Eidson.
3899
3900         Update existing API test to make it more likely to reproduce the issue.
3901
3902         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3903
3904 2019-02-27  Brady Eidson  <beidson@apple.com>
3905
3906         Universal links from Google search results pages don't open the app.
3907         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3908
3909         Reviewed by Geoffrey Garen.
3910
3911         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3912         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3913         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3914         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3915
3916 2019-02-27  Chris Dumez  <cdumez@apple.com>
3917
3918         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3919         https://bugs.webkit.org/show_bug.cgi?id=195102
3920
3921         Reviewed by Geoffrey Garen.
3922
3923         If the number of processes is not yet what we expect, wait a bit and check again to give
3924         processes some time to exit.
3925
3926         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3927
3928 2019-02-27  Chris Dumez  <cdumez@apple.com>
3929
3930         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3931         https://bugs.webkit.org/show_bug.cgi?id=194545
3932
3933         Reviewed by Brady Eidson.
3934
3935         Make sure the test navigates forward and then back only once. Previously, navigating
3936         back would trigger a navigation again in a timer.
3937
3938         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3939
3940 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3941
3942         High Sierra Debug JSC test queue should use faster hardware
3943         https://bugs.webkit.org/show_bug.cgi?id=194603
3944
3945         Rubber-stamped by Alexey Proskuryakov.
3946
3947         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3948
3949         * BuildSlaveSupport/build.webkit.org-config/config.json:
3950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3951         (BubbleQueueServer):
3952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3953         (WebKitBuildbot):
3954         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3955         * QueueStatusServer/config/queues.py:
3956         * Scripts/webkitpy/common/config/ews.json:
3957         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3958         (test_ews_name):
3959
3960 2019-02-27  John Wilander  <wilander@apple.com>
3961
3962         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3963         https://bugs.webkit.org/show_bug.cgi?id=195071
3964         <rdar://problem/48417690>
3965
3966         Reviewed by Alex Christensen and Brent Fulgham.
3967
3968         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3969         (TestWebKitAPI::createURL):
3970             Convenience function.
3971         (TestWebKitAPI::TEST):
3972             WebCore::AdClickAttribution now takes a URL when creating Source and
3973             Destination.
3974         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3975         (TestWebKitAPI::TEST):
3976             WebCore::AdClickAttribution now takes a URL when creating Source and
3977             Destination.
3978
3979 2019-02-27  Antoine Quint  <graouts@apple.com>
3980
3981         Support Pointer Events on macOS
3982         https://bugs.webkit.org/show_bug.cgi?id=195008
3983         <rdar://problem/47454419>
3984
3985         Reviewed by Dean Jackson.
3986
3987         * DumpRenderTree/mac/DumpRenderTree.mm:
3988         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3989         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3990
3991 2019-02-26  Mark Lam  <mark.lam@apple.com>
3992
3993         Remove remaining poisoning code.
3994         https://bugs.webkit.org/show_bug.cgi?id=194138
3995
3996         Reviewed by Saam Barati.
3997
3998         * TestWebKitAPI/CMakeLists.txt:
3999         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4000         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4001         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4002         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4003         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4004         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4005         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4006
4007 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4008
4009         Move ephemeral local storage from WebProcess to UIProcess
4010         https://bugs.webkit.org/show_bug.cgi?id=195074
4011         <rdar://problem/47937975>
4012
4013         Reviewed by Geoff Garen.
4014
4015         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4016
4017 2019-02-20  Jer Noble  <jer.noble@apple.com>
4018
4019         [Cocoa] Media elements will restart network buffering just before suspending
4020         https://bugs.webkit.org/show_bug.cgi?id=193691
4021
4022         Reviewed by Eric Carlson.
4023
4024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4025         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4026         (TEST):
4027
4028 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4029
4030         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4031         https://bugs.webkit.org/show_bug.cgi?id=191652
4032
4033         Reviewed by Alex Christensen.
4034
4035         Fix WinCairo MiniBrowser behavior of authentication dialog.
4036
4037         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4038         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4039
4040 2019-02-26  Youenn Fablet  <youenn@apple.com>
4041
4042         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4043         https://bugs.webkit.org/show_bug.cgi?id=195028
4044         <rdar://problem/48243733>
4045
4046         Reviewed by Eric Carlson.
4047
4048         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4049
4050 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4051
4052         [WPE] Add API for webview background color configuration
4053         https://bugs.webkit.org/show_bug.cgi?id=192305
4054
4055         Reviewed by Michael Catanzaro.
4056
4057         * MiniBrowser/wpe/main.cpp:
4058         (main): Add a new option to configure the webview background
4059         color. Example: --bg-color=transparent.
4060         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4061         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4062         (beforeAll): Ditto.
4063
4064 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4065
4066         scalableNativeWebpageParameters() is not preserved on new page navigation.
4067         https://bugs.webkit.org/show_bug.cgi?id=194892
4068         <rdar://problem/47538280>
4069
4070         Reviewed by Wenson Hsieh.
4071         
4072         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4073
4074         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4075         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4076         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4077         (WTR::UIScriptController::allowsViewportShrinkToFit):
4078         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4079         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4080         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4081         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4082         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4083         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4084
4085 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4086
4087         [ews-app] Add model for handling multiple Buildbot instances
4088         https://bugs.webkit.org/show_bug.cgi?id=194863
4089
4090         Reviewed by Stephanie Lewis.
4091
4092         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4093
4094 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4095
4096         [ews-app] Remove BuilderMapping table
4097         https://bugs.webkit.org/show_bug.cgi?id=194961
4098
4099         Reviewed by Stephanie Lewis.
4100
4101         Store builder name directly in build table, instead of having a separate
4102         table for it.
4103
4104         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4105         * BuildSlaveSupport/ews-app/ews/models/build.py:
4106         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4107         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4108
4109 2019-02-25  John Wilander  <wilander@apple.com>
4110
4111         Introduce and adopt new class RegistrableDomain for eTLD+1
4112         https://bugs.webkit.org/show_bug.cgi?id=194791
4113         <rdar://problem/48179240>
4114
4115         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4116
4117         This patch adds an API test and replaces two instances of
4118         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4119
4120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4121         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4122         (TestWebKitAPI::TEST):
4123             Changed two strings to make sure the registrable domains are still considered
4124             invalid and pass the test.
4125         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4126         (TestWebKitAPI::TEST):
4127         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4128         (WTR::InjectedBundle::didReceiveMessageToPage):
4129
4130 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4131
4132         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4133         https://bugs.webkit.org/show_bug.cgi?id=195001
4134
4135         Reviewed by Carlos Garcia Campos.
4136
4137         API version 1.0 always includes the functionality previously guarded with
4138         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4139         unconditionally.
4140
4141         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4142         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4143         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4144         (WebViewTest::showInWindow): Ditto.
4145         (WebViewTest::hideView): Ditto.
4146         * wpe/backends/HeadlessViewBackend.cpp:
4147         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4148         * wpe/backends/ViewBackend.cpp:
4149         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4150         * wpe/backends/WindowViewBackend.cpp:
4151         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4152         WPE_BACKEND_CHECK_VERSION().
4153         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4154
4155 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4156
4157         [Flatpak] Add support for flatpak > 1.1.2
4158         https://bugs.webkit.org/show_bug.cgi?id=194088
4159
4160         Flatpak 1.2 is now out so we need to support that
4161         version now.
4162
4163         Reviewed by Michael Catanzaro.
4164
4165         * flatpak/flatpakutils.py:
4166         (check_flatpak):
4167         (FlatpakPackages.__init__):
4168         (FlatpakPackages.__detect_packages):
4169         (FlatpakPackages.__detect_packages.in):
4170         (FlatpakRepos.update):
4171
4172 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4173
4174         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4175         https://bugs.webkit.org/show_bug.cgi?id=194998
4176
4177         Reviewed by Carlos Garcia Campos.
4178
4179         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4180         to a Git checkout and using the latest commit containing various fixes
4181         and improvements.
4182
4183 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4184
4185         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4186         https://bugs.webkit.org/show_bug.cgi?id=194981
4187
4188         Reviewed by Žan Doberšek.
4189
4190         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4191         (TestWebKitAPI::TEST):
4192
4193 2019-02-23  Keith Miller  <keith_miller@apple.com>
4194
4195         Add new mac target numbers
4196         https://bugs.webkit.org/show_bug.cgi?id=194955
4197
4198         Reviewed by Tim Horton.
4199
4200         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4201         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4202         * MiniBrowser/Configurations/Base.xcconfig:
4203         * TestWebKitAPI/Configurations/Base.xcconfig:
4204         * WebKitTestRunner/Configurations/Base.xcconfig:
4205
4206 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4207
4208         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4209         https://bugs.webkit.org/show_bug.cgi?id=194846
4210
4211         Reviewed by Don Olmstead.
4212
4213         Added _search_paths() and _port_specific_expectations_files() for
4214         WinCairoPort.
4215
4216         * Scripts/webkitpy/port/win.py:
4217         (WinCairoPort.default_baseline_search_path):
4218         (WinCairoPort):
4219         (WinCairoPort._port_specific_expectations_files):
4220         (WinCairoPort._search_paths):
4221
4222 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4223
4224         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4225         https://bugs.webkit.org/show_bug.cgi?id=194963
4226
4227         Reviewed by Dean Jackson.
4228
4229         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4230         Do a `contains` check instead of `equals`, because in debug builds we
4231         put the GraphicsLayer pointer in a prefix.
4232
4233 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4234
4235         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4236         https://bugs.webkit.org/show_bug.cgi?id=194873
4237         <rdar://problem/46701974>
4238
4239         Reviewed by Tim Horton.
4240
4241         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4242
4243         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4244         (WTR::UIScriptController::menuRect const):
4245         (WTR::UIScriptController::isShowingMenu const):
4246         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4247         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4248         (WTR::UIScriptController::menuRect const):
4249
4250         Add a function to query the bounds of the callout menu in content coordinates.
4251
4252         (WTR::UIScriptController::isShowingMenu const):
4253
4254         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4255
4256         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4257         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4258         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4259         (WTR::UIScriptController::rectForMenuAction const):
4260         (WTR::UIScriptController::menuRect const):
4261         (WTR::UIScriptController::isShowingMenu const):
4262         (WTR::findViewInHierarchyOfType): Deleted.
4263
4264 2019-02-22  Chris Dumez  <cdumez@apple.com>
4265
4266         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4267         https://bugs.webkit.org/show_bug.cgi?id=194954
4268         <rdar://problem/48127957>
4269
4270         Reviewed by Alex Christensen.
4271
4272         Add API test coverage.
4273
4274         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4275         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4276         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4277         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4278
4279 2019-02-22  Chris Dumez  <cdumez@apple.com>
4280
4281         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4282         https://bugs.webkit.org/show_bug.cgi?id=194924
4283         <rdar://problem/48216125>
4284
4285         Reviewed by Geoffrey Garen.
4286
4287         Add API test coverage.
4288
4289         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4290
4291 2019-02-22  Chris Dumez  <cdumez@apple.com>
4292
4293         Unreviewed, disable API test added in r241928 on iOS.
4294
4295         The cache is not enabled on devices with less than 3GB of RAM.
4296
4297         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4298
4299 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4300
4301         Hardcode Visual Viewports on everywhere except iOS WK1
4302         https://bugs.webkit.org/show_bug.cgi?id=194928
4303
4304         Reviewed by Zalan Bujtas.
4305
4306         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4307         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4308         set it to false. The setting has shipped for several years and there's no need to turn
4309         it off now.
4310
4311         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4312         Visual Viewports are not enabled.
4313         
4314         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4315         that only runs in WK2
4316
4317         * MiniBrowser/mac/SettingsController.h:
4318         * MiniBrowser/mac/SettingsController.m:
4319         (-[SettingsController init]):
4320         (-[SettingsController _populateMenu]):
4321         (-[SettingsController validateMenuItem:]):
4322         (-[SettingsController visualViewportEnabled]): Deleted.
4323         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4324         * MiniBrowser/mac/WK1BrowserWindowController.m:
4325         (-[WK1BrowserWindowController didChangeSettings]):
4326         * MiniBrowser/mac/WK2BrowserWindowController.m:
4327         (-[WK2BrowserWindowController didChangeSettings]):
4328
4329 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4330
4331         Discard cached processes when clearing website data store
4332         https://bugs.webkit.org/show_bug.cgi?id=194894
4333
4334         Reviewed by Chris Dumez.
4335
4336         Added a test case.
4337
4338         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4339         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4340
4341 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4342
4343         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4344         https://bugs.webkit.org/show_bug.cgi?id=194914
4345         <rdar://problem/47586889>
4346
4347         Reviewed by Geoffrey Garen.
4348
4349         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4350         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4351         (TEST):
4352         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4353
4354 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4355
4356         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4357         <https://webkit.org/b/194761>
4358
4359         Reviewed by Myles Maxfield.
4360
4361         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4362         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4363         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4364         to use ARC-compliant cast.
4365         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4366         ARC-compliant cast.