Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate...
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2
3         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4         https://bugs.webkit.org/show_bug.cgi?id=193297
5         <rdar://problem/47158841>
6
7         Reviewed by Alex Christensen.
8
9         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
10         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
11         activating the message used to trigger the callback when it is set.
12
13 2019-01-24  John Wilander  <wilander@apple.com>
14
15         Add Ad Click Attribution as an internal/experimental feature
16         https://bugs.webkit.org/show_bug.cgi?id=193685
17         <rdar://problem/47450399>
18
19         Reviewed by Brent Fulgham.
20
21         Added test option adClickAttributionEnabled.
22
23         * DumpRenderTree/TestOptions.cpp:
24         (TestOptions::TestOptions):
25         * DumpRenderTree/TestOptions.h:
26         * DumpRenderTree/mac/DumpRenderTree.mm:
27         (setWebPreferencesForTestOptions):
28
29 2019-01-24  Antti Koivisto  <antti@apple.com>
30
31         [PSON] Flash on back navigation on Mac
32         https://bugs.webkit.org/show_bug.cgi?id=193716
33         <rdar://problem/47148458>
34
35         Reviewed by Chris Dumez.
36
37         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
38
39         Closing of the previous page is delayed so waiting for didFinishNavigation is
40         not sufficient to guarantee we have received all the messages. Wait for them.
41
42 2019-01-24  Chris Dumez  <cdumez@apple.com>
43
44         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
45         https://bugs.webkit.org/show_bug.cgi?id=193761
46         <rdar://problem/47456405>
47
48         Reviewed by Alex Christensen.
49
50         Add API test coverage.
51
52         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
53
54 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
55
56         webkitpy: Missing PID in crashlog name should not be fatal
57         https://bugs.webkit.org/show_bug.cgi?id=193771
58
59         If we can't determine the PID of a crashlog, just ignore the crashlog instead
60         of raising an exception.
61
62         Reviewed by Lucas Forschler.
63
64         * Scripts/webkitpy/port/darwin.py:
65         (DarwinPort._merge_crash_logs):
66
67 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
68
69         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
70         https://bugs.webkit.org/show_bug.cgi?id=193746
71
72         Reviewed by Youenn Fablet.
73
74         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
75         so we'd best just not call it.
76
77         * Scripts/webkitpy/w3c/test_exporter.py:
78         (WebPlatformTestExporter.create_branch_with_patch):
79
80 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
81
82         Move FileSystem to WTF
83         https://bugs.webkit.org/show_bug.cgi?id=193602
84
85         Reviewed by Yusuke Suzuki.
86
87         * DumpRenderTree/win/DumpRenderTree.cpp:
88         * TestWebKitAPI/CMakeLists.txt:
89         * TestWebKitAPI/PlatformGTK.cmake:
90         * TestWebKitAPI/PlatformJSCOnly.cmake:
91         * TestWebKitAPI/PlatformPlayStation.cmake:
92         * TestWebKitAPI/PlatformWPE.cmake:
93         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
94         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
95         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
96         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
97         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
98         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
99         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
100         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
101         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
102         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
103
104 2019-01-24  Philippe Normand  <pnormand@igalia.com>
105
106         [WPE] Remove hard dependency on subprocess32 for the API tests
107
108         Rubber-stamped by Carlos Garcia Campos.
109
110         * glib/api_test_runner.py:
111         (TestRunner._run_test_qt): Lazily import subprocess32 and check
112         its presence only when running WPEQt tests.
113
114 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
115
116         [GLIB] Expose JavaScriptCore options in GLib public API
117         https://bugs.webkit.org/show_bug.cgi?id=188742
118
119         Reviewed by Michael Catanzaro.
120
121         Add a test for the new API.
122
123         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
124         (testsJSCOptions):
125         (main):
126
127 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
128
129         [GTK][WPE] Support JPEG 2000 images
130         https://bugs.webkit.org/show_bug.cgi?id=186272
131
132         Reviewed by Žan Doberšek.
133
134         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
135
136         * gtk/jhbuild.modules:
137         * wpe/jhbuild.modules:
138
139 2019-01-23  David Kilzer  <ddkilzer@apple.com>
140
141         check-webkit-style should warn when using soft-linking macros in a header
142         <https://webkit.org/b/193750>
143
144         Reviewed by Darin Adler.
145
146         * Scripts/webkitpy/style/checkers/cpp.py:
147         (check_language): Add softlink/header check by refactoring the
148         softlink/framework check.
149         (CppChecker): Enable softlink/header check by default.
150         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
151         (CppStyleTest.test_softlink_framework): Rename from
152         CppStyleTest.test_softlink() and change test framework name in
153         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
154         files. Set file_name for macros that only appear in headers.
155         (CppStyleTest.test_softlink_header): Add tests for using
156         soft-link macros in headers.
157
158 2019-01-23  Chris Dumez  <cdumez@apple.com>
159
160         Deprecate API to limit the maximum number of WebProcesses
161         https://bugs.webkit.org/show_bug.cgi?id=193725
162         <rdar://problem/47464879>
163
164         Reviewed by Geoff Garen.
165
166         Update existing API tests to stop using deprecated API.
167
168         * MiniBrowser/mac/AppDelegate.m:
169         (defaultConfiguration):
170         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
171         (TestWebKitAPI::TEST):
172         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
173         (TestWebKitAPI::TEST):
174         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
175         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
176         (TEST):
177         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
178         (TEST):
179
180 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
181
182         [ews-app] Rename ews model buildermappings to buildermapping
183         https://bugs.webkit.org/show_bug.cgi?id=193729
184
185         Reviewed by Lucas Forschler.
186
187         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
188         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
189         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
190
191 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
192
193         [ews-app] Rename ews model steps to step
194         https://bugs.webkit.org/show_bug.cgi?id=193697
195
196         Reviewed by Lucas Forschler.
197
198         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
199         (Step): Renamed Steps to Step.
200
201 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
202
203         Clean up IndexedDB files between tests
204         https://bugs.webkit.org/show_bug.cgi?id=192796
205         <rdar://problem/46824999>
206
207         Reviewed by Geoffrey Garen.
208
209         * DumpRenderTree/mac/DumpRenderTree.mm:
210         (runTest):
211         * WebKitTestRunner/TestController.cpp:
212         (WTR::TestController::resetStateToConsistentValues):
213         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
214         (WTR::RemoveAllIndexedDatabasesCallback):
215         (WTR::TestController::ClearIndexedDatabases):
216         * WebKitTestRunner/TestController.h:
217         * WebKitTestRunner/TestInvocation.cpp:
218         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
219
220 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
221
222         [ews-app] Rename ews model Builds to Build
223         https://bugs.webkit.org/show_bug.cgi?id=193695
224
225         Reviewed by Lucas Forschler.
226
227         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
228         (Build): Renamed Builds to Build.
229
230 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
231
232         webkitpy: Wait longer when launching WebKitTestRunner
233         https://bugs.webkit.org/show_bug.cgi?id=193734
234
235         Reviewed by Aakash Jain.
236
237         * Scripts/webkitpy/port/simulator_process.py:
238         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
239
240 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
241
242         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
243         https://bugs.webkit.org/show_bug.cgi?id=193182
244         <rdar://problem/47452154>
245
246         Reviewed by Tim Horton.
247
248         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
249         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
250         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
251
252         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
253         preventing later tests from recognizing gestures.
254
255         * WebKitTestRunner/ios/TestControllerIOS.mm:
256         (WTR::TestController::platformResetStateToConsistentValues):
257
258         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
259
260 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
261
262         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
263         https://bugs.webkit.org/show_bug.cgi?id=193722
264         <rdar://problem/47481475>
265
266         Reviewed by Lucas Forschler.
267
268         iPhone and iPad ports should both use the iOS config.
269
270         * Scripts/webkitpy/port/ios_simulator.py:
271         (IPhoneSimulatorPort.__init__):
272         (IPadSimulatorPort.__init__):
273
274 2019-01-23  Rob Buis  <rbuis@igalia.com>
275
276         Update MIME type parser
277         https://bugs.webkit.org/show_bug.cgi?id=180526
278
279         Reviewed by Frédéric Wang.
280
281         Add unit tests for both parse modes of ParsedContentType.
282
283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
284         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
285         (TestWebKitAPI::TEST):
286
287 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
288
289         [ews-app] fetch loop should not stop on network issues
290         https://bugs.webkit.org/show_bug.cgi?id=193666
291
292         Reviewed by Lucas Forschler.
293
294         * BuildSlaveSupport/ews-app/ews/fetcher.py:
295         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
296
297 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
298
299         [iOS] Multiple WKWebViewAutofillTests are flaky failures
300         https://bugs.webkit.org/show_bug.cgi?id=189165
301         <rdar://problem/47433765>
302
303         Reviewed by Tim Horton.
304
305         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
306         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
307         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
308         process in sufficient to ensure that any previous action that blurred the focused element in the web process
309         would make its way to the UI process by the time the layer tree commit is finished.
310
311         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
312         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
313         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
314         will fail because it asks for -_autofillContext too early.
315
316         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
317         is handled in the UI process.
318
319         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
320
321         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
322         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
323         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
324         input session.
325
326         (-[AutofillTestView textInputHasAutofillContext]):
327
328         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
329
330         * TestWebKitAPI/cocoa/TestWKWebView.h:
331         * TestWebKitAPI/cocoa/TestWKWebView.mm:
332         (nextInputSessionChangeCount):
333
334         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
335         This includes changing the focused element from one to another.
336
337         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
338         (-[TestWKWebView didStartFormControlInteraction]):
339         (-[TestWKWebView didEndFormControlInteraction]):
340         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
341
342         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
343         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
344         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
345         that doesn't require an input session to one that doesn't.
346
347 2019-01-22  David Kilzer  <ddkilzer@apple.com>
348
349         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
350         <https://webkit.org/b/193676>
351
352         Reviewed by Alexey Proskuryakov.
353
354         * Scripts/webkitpy/style/checkers/cpp.py:
355         (check_member_initialization_list):
356         - Don't report missing whitespace around colon if the colon at
357           the start of the line is formatted correctly.
358         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
359         (WebKitStyleTest.test_member_initialization_list):
360         - Add a test for a missing permutation of existing tests.
361         - Add a test this false-positive.
362         - Add blank lines between subtests to make them easier to read.
363
364 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
365
366         [build.webkit.org] Unit-test failure after r237113
367         https://bugs.webkit.org/show_bug.cgi?id=193669
368
369         Reviewed by Michael Catanzaro.
370
371         * BuildSlaveSupport/build.webkit.org-config/factories.py:
372         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
373         multiple or zero flags.
374
375 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
376
377         Cache bytecode to disk
378         https://bugs.webkit.org/show_bug.cgi?id=192782
379         <rdar://problem/46084932>
380
381         Reviewed by Keith Miller.
382
383         Add test helper to execute bytecode-cache tests: it executes each test
384         twice, the first with JSC_diskCachePath set to a temporary directory
385         and second with JSC_forceDiskCache=true (in addition to the cache path)
386         to guarantee that only the disk cache is being used and no new
387         UnlinkedCodeBlocks are being created.
388
389         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
390         * Scripts/run-jsc-stress-tests:
391
392 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
393
394         [css-logical] Implement flow-relative margin, padding and border shorthands
395         https://bugs.webkit.org/show_bug.cgi?id=188697
396
397         Reviewed by Simon Fraser and Antti Koivisto.
398
399         * DumpRenderTree/TestOptions.cpp:
400         (TestOptions::TestOptions):
401         * DumpRenderTree/TestOptions.h:
402         * DumpRenderTree/mac/DumpRenderTree.mm:
403         (setWebPreferencesForTestOptions):
404         Allow tests to enable the CSSLogicalEnabled flag in WK1.
405
406         * Scripts/webkitpy/style/checkers/jsonchecker.py:
407         (JSONCSSPropertiesChecker.check_codegen_properties):
408         Allow CSS property definitions to have a 'runtime-flag' parameter which
409         disables the property when the specified runtime flag is disabled.
410
411 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
412
413         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
414         https://bugs.webkit.org/show_bug.cgi?id=193643
415
416         Reviewed by Michael Catanzaro.
417
418         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
419         * wpe/jhbuild.modules: Ditto.
420
421 2019-01-21  Zalan Bujtas  <zalan@apple.com>
422
423         [LFC][Floats] Take float top position into account when computing containing block height.
424         https://bugs.webkit.org/show_bug.cgi?id=193655
425
426         Reviewed by Antti Koivisto.
427
428         * LayoutReloaded/misc/LFC-passing-tests.txt:
429
430 2019-01-21  David Kilzer  <ddkilzer@apple.com>
431
432         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
433         <https://webkit.org/b/193645>
434         <rdar://problem/47421574>
435
436         Reviewed by Alex Christensen.
437
438         - Now checks for local soft-linking of all frameworks that have
439           their own *SoftLinking.{cpp,h,mm} files.
440         - Changes softlink/uikit warning to softlink/framework.
441
442         * Scripts/webkitpy/style/checkers/cpp.py:
443         (check_language):
444         (CppChecker):
445         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
446         (CppStyleTest):
447
448 2019-01-20  Saam Barati  <sbarati@apple.com>
449
450         Rollout r240210: It broke tests on iOS
451         https://bugs.webkit.org/show_bug.cgi?id=193640
452
453         Unreviewed.
454
455         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
456         * Scripts/run-jsc-stress-tests:
457
458 2019-01-20  chris fleizach  <cfleizach@apple.com>
459
460         AX: Support returning relative frames for accessibility
461         https://bugs.webkit.org/show_bug.cgi?id=193414
462         <rdar://problem/47268501>
463
464         Reviewed by Zalan Bujtas.
465
466         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
467         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
468         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
469         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
470         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
471         (WTR::attributesOfElement):
472         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
473
474 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
475
476         Unreviewed, add my new email address
477
478         * Scripts/webkitpy/common/config/contributors.json:
479
480 2019-01-19  Zalan Bujtas  <zalan@apple.com>
481
482         [LFC][BFC] <body>'s overflow property value is propagated to viewport
483         https://bugs.webkit.org/show_bug.cgi?id=193617
484
485         Reviewed by Antti Koivisto.
486
487         * LayoutReloaded/misc/LFC-passing-tests.txt:
488
489 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
490
491         Unreviewed, rolling out r240209.
492
493         Broke GTK/WPE injected bundle
494
495         Reverted changeset:
496
497         "AX: Support returning relative frames for accessibility"
498         https://bugs.webkit.org/show_bug.cgi?id=193414
499         https://trac.webkit.org/changeset/240209
500
501 2019-01-12  Dan Bernstein  <mitz@apple.com>
502
503         [Cocoa] Avoid importing directly from subumbrella frameworks
504         https://bugs.webkit.org/show_bug.cgi?id=186016
505         <rdar://problem/40591038>
506
507         Reviewed by Sam Weinig.
508
509         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
510           LaunchServices header.
511         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
512           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
513         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
514           when using SDKs earlier than 10.13.
515         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
516           and OTHER_CPLUSPLUSFLAGS.
517         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
518           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
519         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
520           LaunchServices header.
521
522 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
523
524         Cache bytecode to disk
525         https://bugs.webkit.org/show_bug.cgi?id=192782
526         <rdar://problem/46084932>
527
528         Reviewed by Keith Miller.
529
530         Add test helper to execute bytecode-cache tests: it executes each test
531         twice, the first with JSC_diskCachePath set to a temporary directory
532         and second with JSC_forceDiskCache=true (in addition to the cache path)
533         to guarantee that only the disk cache is being used and no new
534         UnlinkedCodeBlocks are being created.
535
536         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
537         * Scripts/run-jsc-stress-tests:
538
539 2019-01-20  chris fleizach  <cfleizach@apple.com>
540
541         AX: Support returning relative frames for accessibility
542         https://bugs.webkit.org/show_bug.cgi?id=193414
543         <rdar://problem/47268501>
544
545         Reviewed by Zalan Bujtas.
546
547         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
548         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
549         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
550         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
551         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
552         (WTR::attributesOfElement):
553         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
554
555 2019-01-20  Antoine Quint  <graouts@apple.com>
556
557         Add a POINTER_EVENTS feature flag
558         https://bugs.webkit.org/show_bug.cgi?id=193577
559         <rdar://problem/47408511>
560
561         Unreviewed. Also enable Pointer Events for iosmac.
562
563         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
564
565 2019-01-19  Zalan Bujtas  <zalan@apple.com>
566
567         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
568         https://bugs.webkit.org/show_bug.cgi?id=193613
569
570         Reviewed by Antti Koivisto.
571
572         * LayoutReloaded/misc/LFC-passing-tests.txt:
573
574 2019-01-19  Antoine Quint  <graouts@apple.com>
575
576         Add a POINTER_EVENTS feature flag
577         https://bugs.webkit.org/show_bug.cgi?id=193577
578
579         Reviewed by Dean Jackson.
580
581         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
582
583 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
584
585         Disable the run-jsc-stress-test remote host key check [second round].
586         https://bugs.webkit.org/show_bug.cgi?id=192988
587
588         Reviewed by Dewei Zhu.
589
590         * Scripts/run-jsc-stress-tests:
591
592 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
593
594         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
595         https://bugs.webkit.org/show_bug.cgi?id=193597
596
597         Reviewed by Lucas Forschler.
598
599         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
600
601 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
602
603         [build.webkit.org] api tests failures are incorrectly named as unit test failures
604         https://bugs.webkit.org/show_bug.cgi?id=193595
605
606         Reviewed by Lucas Forschler.
607
608         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
609         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
610         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
611
612 2019-01-18  Chris Dumez  <cdumez@apple.com>
613
614         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
615         https://bugs.webkit.org/show_bug.cgi?id=193588
616         <rdar://problem/47131566>
617
618         Reviewed by Alex Christensen.
619
620         Add layout test coverage.
621
622         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
623
624 2019-01-18  Jer Noble  <jer.noble@apple.com>
625
626         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
627         https://bugs.webkit.org/show_bug.cgi?id=189553
628
629         Reviewed by Tim Horton.
630
631         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
632
633         * ContentExtensionTester/Configurations/Base.xcconfig:
634         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
635         * DumpRenderTree/mac/Configurations/Base.xcconfig:
636         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
637         * ImageDiff/cg/Configurations/Base.xcconfig:
638         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
639         * MiniBrowser/Configurations/Base.xcconfig:
640         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
641         * MobileMiniBrowser/Configurations/Base.xcconfig:
642         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
643         * Scripts/webkitpy/style/checker.py:
644         (_all_categories):
645         (FileType):
646         (CheckerDispatcher._file_type):
647         (CheckerDispatcher._create_checker):
648         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
649         (SDKVariantChecker):
650         (SDKVariantChecker.__init__):
651         (SDKVariantChecker.check):
652         * TestWebKitAPI/Configurations/Base.xcconfig:
653         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
654         * WebEditingTester/Configurations/Base.xcconfig:
655         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
656         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
657         * WebKitTestRunner/Configurations/Base.xcconfig:
658         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
659         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
660         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
661
662 2019-01-18  David Kilzer  <ddkilzer@apple.com>
663
664         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
665         <https://webkit.org/b/193568>
666         <rdar://problem/47381130>
667
668         Reviewed by Alex Christensen.
669
670         Make sure no one re-introduces UIKit soft-linking by adding a
671         style rule.
672
673         * Scripts/webkitpy/style/checkers/cpp.py:
674         (check_language): Add softlink/uikit check.
675         (CppChecker): Enable softlink/uikit check.
676         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
677         (CppStyleTest): Add test for softlink/uikit.
678
679 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
680
681         [GTK] install-dependencies tool looks for libunistring-dev for dnf
682         https://bugs.webkit.org/show_bug.cgi?id=193584
683
684         Change "-dev" to "-devel".
685
686         Reviewed by Michael Catanzaro.
687
688         * gtk/install-dependencies:
689
690 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
691
692         webkitpy: Add iPhone and iPad ports
693         https://bugs.webkit.org/show_bug.cgi?id=193537
694         <rdar://problem/47353390>
695
696         Reviewed by Lucas Forschler.
697
698         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
699         ports. Note that this separation is optional, the --ios-simulator command remains.
700
701         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
702         (RunTest.test_device_type_test_division): Drive-by fix.
703         (RunTest.test_device_type_specific_listing): Ditto.
704         (RunTest.test_ipad_test_division):
705         (RunTest):
706         (RunTest.test_ipad_listing):
707         * Scripts/webkitpy/port/factory.py:
708         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
709         (PortFactory):
710         * Scripts/webkitpy/port/ios_simulator.py:
711         (IPhoneSimulatorPort):
712         (IPadSimulatorPort):
713
714 2019-01-18  Chris Dumez  <cdumez@apple.com>
715
716         Regression(PSON) Scroll position is not always restored properly when navigating back
717         https://bugs.webkit.org/show_bug.cgi?id=193578
718         <rdar://problem/47386331>
719
720         Reviewed by Tim Horton.
721
722         Add API test coverage.
723
724         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
725
726 2019-01-18  Youenn Fablet  <youenn@apple.com>
727
728         Add a new SPI to request for cache storage quota increase
729         https://bugs.webkit.org/show_bug.cgi?id=193323
730
731         Reviewed by Alex Christensen.
732
733         Implement WebsiteDataStore quota delegate to handle quota requests.
734         By default, do not update quota.
735         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
736
737         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
738         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
739         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
740         * WebKitTestRunner/InjectedBundle/TestRunner.h:
741         * WebKitTestRunner/TestController.cpp:
742         (WTR::TestController::allowCacheStorageQuotaIncrease):
743         * WebKitTestRunner/TestController.h:
744         * WebKitTestRunner/TestInvocation.cpp:
745         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
746         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
747         (-[CacheStorageQuotaManager init]):
748         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
749         (WTR::initializeWebViewConfiguration):
750         (WTR::TestController::cocoaResetStateToConsistentValues):
751         (WTR::TestController::allowCacheStorageQuotaIncrease):
752
753 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
754
755         [ews-build] Pass owner to the triggered builds
756         https://bugs.webkit.org/show_bug.cgi?id=193574
757
758         Reviewed by Lucas Forschler.
759
760         * BuildSlaveSupport/ews-build/factories.py:
761         (BuildFactory.propertiesToPassToTriggers):
762
763 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
764
765         [ews-app] Send patch author as a build property
766         https://bugs.webkit.org/show_bug.cgi?id=193560
767
768         Reviewed by Lucas Forschler.
769
770         * BuildSlaveSupport/ews-app/ews/fetcher.py:
771         (BugzillaPatchFetcher.fetch):
772
773 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
774
775         webkitpy: Implement device type specific expected results (Follow-up fix)
776         https://bugs.webkit.org/show_bug.cgi?id=192162
777         <rdar://problem/46345449>
778
779         Unreviewed infrastructure fix.
780
781         * Scripts/webkitpy/layout_tests/controllers/manager.py:
782         (Manager.run): Don't boot a device if no tests are available to run on it.
783
784 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
785
786         webkitpy: Implement device type specific expected results (Follow-up fix)
787         https://bugs.webkit.org/show_bug.cgi?id=192162
788         <rdar://problem/46345449>
789
790         Unreviewed infrastructure fix.
791
792         * Scripts/webkitpy/api_tests/manager.py:
793         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
794
795 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
796
797         webkitpy: Implement device type specific expected results (Part 2)
798         https://bugs.webkit.org/show_bug.cgi?id=192162
799         <rdar://problem/46345449>
800
801         Rubber-stamped by Aakash Jain.
802
803         This change uses device_type to select a different set of TestExpectation files based on the type of device running
804         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
805         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
806
807         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
808         (LayoutTestFinder.find_tests): Pass device_type through.
809         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
810         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
811         * Scripts/webkitpy/layout_tests/controllers/manager.py:
812         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
813         (Manager._collect_tests): Pass device type to test finder.
814         (Manager._needs_web_platform_test):
815         (Manager._prepare_lists): Index _expectations by device type.
816         (Manager._test_input_for_file):
817         (Manager._test_is_slow): Ditto.
818         (Manager._test_should_dump_jsconsolelog_in_stderr):
819         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
820         (Manager._get_test_inputs):
821         (Manager._update_worker_count):
822         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
823         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
824         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
825         the one which runs the test.
826         (Manager._run_test_subset):
827         (Manager._run_tests): Index _expectations by current_device_type.
828         (Manager._print_expectation_line_for_test): Ditto.
829         (Manager._print_expectations_for_subset): Ditto.
830         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
831         Unlike run, this function will behave the same regardless of what devices are available.
832         (Manager._custom_device_for_test): Deleted.
833         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
834         (ManagerTest.test_uses_custom_device): Deleted.
835         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
836         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
837         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
838         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
839         all of the expectations.
840         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
841         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
842         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
843         (TestExpectations.__init__): Allow device_type to be passed through.
844         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
845         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
846         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
847         (summarize_results):
848         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
849         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
850         a test ran with, one must check all expectations to find the first non-skip expectation.
851         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
852         (RunTest.test_device_type_test_division):
853         (RunTest):
854         (RunTest.test_device_type_specific_listing):
855         * Scripts/webkitpy/port/base.py:
856         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
857         (Port.supported_device_types): The result of this function will change based on what devices are available.
858         * Scripts/webkitpy/port/device_port.py:
859         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
860         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
861         can be used.
862         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
863         any, or the DEFAULT_DEVICE_TYPES of the port.
864         * Scripts/webkitpy/port/ios.py:
865         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
866         * Scripts/webkitpy/port/ios_simulator.py:
867         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
868         * Scripts/webkitpy/port/watch.py:
869         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
870         * Scripts/webkitpy/port/watch_simulator.py:
871         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
872         * Scripts/webkitpy/xcode/device_type.py:
873         (DeviceType):
874         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
875
876 2019-01-18  Philippe Normand  <pnormand@igalia.com>
877
878         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
879         https://bugs.webkit.org/show_bug.cgi?id=193575
880
881         Reviewed by Michael Catanzaro.
882
883         Allow the script to run without explicit port argument because
884         it's specific to the WPE port anyway.
885
886         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
887         and simplify the rest of the code accordingly.
888
889 2019-01-18  Charlie Turner  <cturner@igalia.com>
890
891         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
892         https://bugs.webkit.org/show_bug.cgi?id=192229
893
894         Reviewed by Xabier Rodriguez-Calvar.
895
896         * MiniBrowser/wpe/main.cpp:
897         (main): Enable encrypted-media by default.
898
899 2019-01-18  Philippe Normand  <pnormand@igalia.com>
900
901         [Flatpak] Missing KeyboardInterrupt exception handler
902         https://bugs.webkit.org/show_bug.cgi?id=193570
903
904         Reviewed by Michael Catanzaro.
905
906         * flatpak/flatpakutils.py:
907         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
908
909 2019-01-18  Zalan Bujtas  <zalan@apple.com>
910
911         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
912         https://bugs.webkit.org/show_bug.cgi?id=193564
913
914         Reviewed by Antti Koivisto.
915
916         * LayoutReloaded/misc/LFC-passing-tests.txt:
917
918 2019-01-18  Zalan Bujtas  <zalan@apple.com>
919
920         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
921         https://bugs.webkit.org/show_bug.cgi?id=193562
922
923         Reviewed by Antti Koivisto.
924
925         * LayoutReloaded/misc/LFC-passing-tests.txt:
926
927 2019-01-18  Zalan Bujtas  <zalan@apple.com>
928
929         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
930         https://bugs.webkit.org/show_bug.cgi?id=193555
931
932         Reviewed by Antti Koivisto.
933
934         * LayoutReloaded/misc/LFC-passing-tests.txt:
935
936 2019-01-18  Philippe Normand  <pnormand@igalia.com>
937
938         [WPE] Add Qt extension
939         https://bugs.webkit.org/show_bug.cgi?id=191464
940
941         Reviewed by Carlos Garcia Campos.
942
943         MiniBrowser and API tests for the WPE Qt API. To run the
944         MiniBrowser a new script is introduced. Example invocation:
945
946         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
947
948         Also note-worthy is the introduction of the python2-subprocess32
949         dependency to run the GLib API tests.
950
951         * MiniBrowser/wpe/CMakeLists.txt:
952         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
953         * MiniBrowser/wpe/qt/main.cpp: Added.
954         (main):
955         * MiniBrowser/wpe/qt/main.qml: Added.
956         * MiniBrowser/wpe/qt/qml.qrc: Added.
957         * Scripts/run-gtk-tests:
958         (GtkTestRunner.is_google_test):
959         (GtkTestRunner):
960         (GtkTestRunner.is_qt_test):
961         * Scripts/run-qt-wpe-minibrowser: Added.
962         * Scripts/run-wpe-tests:
963         (WPETestRunner):
964         (WPETestRunner.is_google_test):
965         (WPETestRunner.is_qt_test):
966         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
967         (TestLoad::main):
968         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
969         (TestLoadHtml::main):
970         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
971         (TestLoadRequest::main):
972         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
973         (TestRunJavaScript::main):
974         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
975         (waitForSignal):
976         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
977         (LoadSpy::LoadSpy):
978         (LoadSpy::~LoadSpy):
979         (LoadSpy::onLoadingChanged):
980         (LoadStartedCatcher::LoadStartedCatcher):
981         (LoadStartedCatcher::~LoadStartedCatcher):
982         (LoadStartedCatcher::onLoadingChanged):
983         (waitForLoadSucceeded):
984         (waitForLoadFailed):
985         * TestWebKitAPI/glib/CMakeLists.txt:
986         * flatpak/flatpakutils.py:
987         (WebkitFlatpak.load_from_args):
988         (WebkitFlatpak.__init__):
989         (WebkitFlatpak.clean_args):
990         (WebkitFlatpak.run_in_sandbox):
991         * flatpak/org.webkit.CommonModules.yaml:
992         * flatpak/org.webkit.WPE.yaml:
993         * flatpak/org.webkit.WPEModules.yaml:
994         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
995         * flatpak/org.webkit.WebKit.yaml:
996         * glib/api_test_runner.py:
997         (TestRunner._run_test_qt):
998         (TestRunner.is_qt_test):
999         (TestRunner._run_test):
1000
1001 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1002
1003         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1004         https://bugs.webkit.org/show_bug.cgi?id=193494
1005         <rdar://problem/46859627>
1006
1007         Reviewed by Simon Fraser and Tim Horton.
1008
1009         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1010         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1011
1012         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1013         (WTR::UIScriptController::contentOffsetX const):
1014         (WTR::UIScriptController::contentOffsetY const):
1015         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1016         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1017         (WTR::UIScriptController::contentOffsetX const):
1018         (WTR::UIScriptController::contentOffsetY const):
1019         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1020
1021         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1022
1023         * WebKitTestRunner/TestController.cpp:
1024         (WTR::updateTestOptionsFromTestHeader):
1025         * WebKitTestRunner/TestOptions.h:
1026         (WTR::TestOptions::hasSameInitializationOptions const):
1027         * WebKitTestRunner/ios/TestControllerIOS.mm:
1028         (WTR::TestController::platformResetStateToConsistentValues):
1029         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1030         (WTR::UIScriptController::contentOffsetX const):
1031         (WTR::UIScriptController::contentOffsetY const):
1032
1033 2019-01-17  Truitt Savell  <tsavell@apple.com>
1034
1035         Unreviewed, rolling out r240124.
1036
1037         This commit broke an internal build.
1038
1039         Reverted changeset:
1040
1041         "SDK_VARIANT build destinations should be separate from non-
1042         SDK_VARIANT builds"
1043         https://bugs.webkit.org/show_bug.cgi?id=189553
1044         https://trac.webkit.org/changeset/240124
1045
1046 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1047
1048         Fix string concatenation API test after r239920
1049         https://bugs.webkit.org/show_bug.cgi?id=193551
1050         <rdar://problem/47359304>
1051
1052         Reviewed by Youenn Fablet.
1053
1054         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1055         (TestWebKitAPI::TEST):
1056         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1057         in WebKit's build configuration like it apparently is on Linux.
1058
1059 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1060
1061         [ews-build] validate-patch should handle the case when bug_id is None
1062         https://bugs.webkit.org/show_bug.cgi?id=193547
1063
1064         Reviewed by Lucas Forschler.
1065
1066         * BuildSlaveSupport/ews-build/steps.py:
1067         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1068         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1069
1070 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1071
1072         [ews-build] Add patch author information in build
1073         https://bugs.webkit.org/show_bug.cgi?id=193465
1074
1075         Reviewed by Lucas Forschler.
1076
1077         * BuildSlaveSupport/ews-build/steps.py:
1078         (ValidatePatch._is_patch_obsolete):
1079
1080 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1081
1082         [ews-build] Pass bug_id to the triggered builds
1083         https://bugs.webkit.org/show_bug.cgi?id=193548
1084
1085         Reviewed by Lucas Forschler.
1086
1087         * BuildSlaveSupport/ews-build/factories.py:
1088         (BuildFactory.propertiesToPassToTriggers):
1089
1090 2019-01-17  Jer Noble  <jer.noble@apple.com>
1091
1092         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1093         https://bugs.webkit.org/show_bug.cgi?id=189553
1094
1095         Reviewed by Tim Horton.
1096
1097         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1098
1099         * ContentExtensionTester/Configurations/Base.xcconfig:
1100         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1101         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1102         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1103         * ImageDiff/cg/Configurations/Base.xcconfig:
1104         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1105         * MiniBrowser/Configurations/Base.xcconfig:
1106         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1107         * MobileMiniBrowser/Configurations/Base.xcconfig:
1108         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1109         * Scripts/webkitpy/style/checker.py:
1110         (_all_categories):
1111         (FileType):
1112         (CheckerDispatcher._file_type):
1113         (CheckerDispatcher._create_checker):
1114         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1115         (SDKVariantChecker):
1116         (SDKVariantChecker.__init__):
1117         (SDKVariantChecker.check):
1118         * TestWebKitAPI/Configurations/Base.xcconfig:
1119         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1120         * WebEditingTester/Configurations/Base.xcconfig:
1121         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1122         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1123         * WebKitTestRunner/Configurations/Base.xcconfig:
1124         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1125         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1126         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1127
1128 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1129
1130         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1131         https://bugs.webkit.org/show_bug.cgi?id=193534
1132
1133         Reviewed by Antti Koivisto.
1134
1135         * LayoutReloaded/misc/LFC-passing-tests.txt:
1136
1137 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1138
1139         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1140         https://bugs.webkit.org/show_bug.cgi?id=193528
1141
1142         Reviewed by Antti Koivisto.
1143
1144         * LayoutReloaded/misc/LFC-passing-tests.txt:
1145
1146 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1147
1148         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1149         https://bugs.webkit.org/show_bug.cgi?id=193520
1150
1151         Reviewed by Antti Koivisto.
1152
1153         * LayoutReloaded/misc/LFC-passing-tests.txt:
1154
1155 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1156
1157         [ews-build] unapply-patch step should not update source
1158         https://bugs.webkit.org/show_bug.cgi?id=193234
1159
1160         Reviewed by Lucas Forschler.
1161
1162         * BuildSlaveSupport/ews-build/steps.py:
1163         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1164         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1165
1166 2019-01-16  Youenn Fablet  <youenn@apple.com>
1167
1168         Add a new SPI for controlling getUserMedia
1169         https://bugs.webkit.org/show_bug.cgi?id=192793
1170
1171         Reviewed by Eric Carlson.
1172
1173         * MiniBrowser/mac/WK2BrowserWindowController.m:
1174         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1175         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1176         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1177         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1178         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1179         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1180         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1181         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1182         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1183         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1184         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1185         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1186         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1187         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1188
1189 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1190
1191         [LFC][BFC] Inflow non-replaced used width should not be negative.
1192         https://bugs.webkit.org/show_bug.cgi?id=193495
1193
1194         Reviewed by Antti Koivisto.
1195
1196         * LayoutReloaded/misc/LFC-passing-tests.txt:
1197
1198 2019-01-16  Chris Dumez  <cdumez@apple.com>
1199
1200         Regression(PSON) View becomes blank after click a cross-site download link
1201         https://bugs.webkit.org/show_bug.cgi?id=193361
1202         <rdar://problem/47099573>
1203
1204         Reviewed by Geoffrey Garen.
1205
1206         Add API test coverage.
1207
1208         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1209         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1210
1211 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1212
1213         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1214         https://bugs.webkit.org/show_bug.cgi?id=193470
1215
1216         Reviewed by Antti Koivisto.
1217
1218         * LayoutReloaded/misc/LFC-passing-tests.txt:
1219
1220 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1221
1222         [LFC] Adjust margin box verification.
1223         https://bugs.webkit.org/show_bug.cgi?id=193482
1224
1225         Reviewed by Antti Koivisto.
1226
1227         * LayoutReloaded/misc/LFC-passing-tests.txt:
1228
1229 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1230
1231         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1232         https://bugs.webkit.org/show_bug.cgi?id=193451
1233
1234         Reviewed by Geoffrey Garen.
1235
1236         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1237         (TEST):
1238         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1239         (runWebsiteDataStoreCustomPaths):
1240
1241 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1242
1243         webkitpy: Support boolean simctl isAvailable
1244         https://bugs.webkit.org/show_bug.cgi?id=193472
1245         <rdar://problem/47296150>
1246
1247         Reviewed by Ryosuke Niwa.
1248
1249         * Scripts/webkitpy/xcode/simulated_device.py:
1250         (SimulatedDeviceManager._create_runtimes):
1251         (SimulatedDeviceManager._create_device_with_runtime):
1252
1253 2019-01-15  Chris Dumez  <cdumez@apple.com>
1254
1255         Unreviewed, rolling out r239993, r239995, r239997, and
1256         r239999.
1257
1258         Caused assertions under
1259         ViewGestureController::disconnectFromProcess()
1260
1261         Reverted changesets:
1262
1263         "Regression(PSON) View becomes blank after click a cross-site
1264         download link"
1265         https://bugs.webkit.org/show_bug.cgi?id=193361
1266         https://trac.webkit.org/changeset/239993
1267
1268         "Unreviewed iOS build fix after r239993."
1269         https://trac.webkit.org/changeset/239995
1270
1271         "Fix iOS build after r239993"
1272         https://bugs.webkit.org/show_bug.cgi?id=193361
1273         https://trac.webkit.org/changeset/239997
1274
1275         "Unreviewed, revert part of r239997 as it is not needed to fix
1276         the build."
1277         https://trac.webkit.org/changeset/239999
1278
1279 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1280
1281         Cannot tab out of WKWebView on macOS
1282         https://bugs.webkit.org/show_bug.cgi?id=161448
1283         <rdar://problem/28100085>
1284
1285         Reviewed by Dean Jackson.
1286
1287         Add a test that tabbing into and out of WKWebView works correctly.
1288
1289         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1290         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1291         (WebKit2_CommandBackForwardTest::SetUp):
1292         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1293         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1294         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1295         (-[FocusableView canBecomeKeyView]):
1296         (TEST):
1297         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1298         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1299         (-[OffscreenWindow initWithSize:]):
1300         (-[OffscreenWindow isKeyWindow]):
1301         (-[OffscreenWindow isVisible]):
1302         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1303         (TestWebKitAPI::PlatformWebView::initialize):
1304         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1305         (-[ActiveOffscreenWindow isVisible]): Deleted.
1306         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1307
1308 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1309
1310         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1311         https://bugs.webkit.org/show_bug.cgi?id=193459
1312
1313         Reviewed by Mark Lam.
1314
1315         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1316         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1317
1318 2019-01-15  Chris Dumez  <cdumez@apple.com>
1319
1320         Regression(PSON) View becomes blank after click a cross-site download link
1321         https://bugs.webkit.org/show_bug.cgi?id=193361
1322         <rdar://problem/47099573>
1323
1324         Reviewed by Geoff Garen.
1325
1326         Add API test coverage.
1327
1328         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1329         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1330
1331 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1332
1333         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
1334         https://bugs.webkit.org/show_bug.cgi?id=193448
1335
1336         Reviewed by Antti Koivisto.
1337
1338         * LayoutReloaded/misc/LFC-passing-tests.txt:
1339
1340 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1341
1342         webkitpy: Implement device type specific expected results (Part 1)
1343         https://bugs.webkit.org/show_bug.cgi?id=192162
1344
1345         Reviewed by Lucas Forschler.
1346
1347         Device type specific expected results covers two related ideas. The first (covered by this change)
1348         is where to search for -expected.* files. The second is which tests to run based on the
1349         TestExpectations.txt file.
1350
1351         After this change, the baseline search path will be determined by the type of device running a
1352         test. Device type will be passed into any function which picks a file based on the baseline search
1353         path.
1354
1355         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1356         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
1357         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1358         (Manager.run): Print baseline search path for each round of devices.
1359         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1360         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
1361         (SingleTestRunner._expected_driver_output): Ditto.
1362         (SingleTestRunner._driver_input): Ditto.
1363         * Scripts/webkitpy/layout_tests/views/printing.py:
1364         (Printer.print_config): Move printing of baseline search path to a separate function.
1365         (Printer.print_baseline_search_path): Moved from Printer.print_config.
1366         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1367         (Testprinter.test_print_config):
1368         (Testprinter.test_print_baseline_search_path):
1369         * Scripts/webkitpy/port/base.py:
1370         (Port.baseline_search_path): Pass device_type through.
1371         (Port._expected_baselines_for_suffixes): Ditto.
1372         (Port.expected_baselines): Ditto.
1373         (Port.expected_filename): Ditto.
1374         (Port.expected_checksum): Ditto.
1375         (Port.expected_image): Ditto.
1376         (Port.expected_audio): Ditto.
1377         (Port.expected_text): Ditto.
1378         (Port.reference_files): Ditto.
1379         (Port.tests): Ditto.
1380         (Port._expanded_paths): Ditto.
1381         (Port.skipped_layout_tests): Ditto.
1382         (Port.expectations_dict): Ditto.
1383         (Port._port_specific_expectations_files): Ditto.
1384         (Port.expectations_files): Ditto.
1385         (Port.test_search_path): Ditto.
1386         (Port._tests_for_other_platforms): Ditto.
1387         * Scripts/webkitpy/port/base_unittest.py:
1388         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
1389         (PortTest.test_nonexistant_expectations): Ditto.
1390         (test_ref_tests_platform_directory): Ditto.
1391         * Scripts/webkitpy/port/darwin.py:
1392         (DarwinPort._port_specific_expectations_files): Accept device_type.
1393         * Scripts/webkitpy/port/driver.py:
1394         (DriverProxy):
1395         (DriverProxy.host): Expose _target_host for device_type information.
1396         * Scripts/webkitpy/port/gtk.py:
1397         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
1398         * Scripts/webkitpy/port/ios.py:
1399         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1400         * Scripts/webkitpy/port/mac.py:
1401         (MacPort. default_baseline_search_path): Ditto.
1402         * Scripts/webkitpy/port/port_testcase.py:
1403         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
1404         * Scripts/webkitpy/port/test.py:
1405         * Scripts/webkitpy/port/watch.py:
1406         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1407         * Scripts/webkitpy/port/win.py:
1408         (WinPort.test_search_path): Accept, but do not use, device_type.
1409         * Scripts/webkitpy/port/wpe.py:
1410         (WPEPort._port_specific_expectations_files): Ditto.
1411         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1412         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
1413
1414 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1415
1416         [LFC] Use the containing block's padding box to position out-of-flow elements.
1417         https://bugs.webkit.org/show_bug.cgi?id=193431
1418
1419         Reviewed by Antti Koivisto.
1420
1421         * LayoutReloaded/misc/LFC-passing-tests.txt:
1422
1423 2019-01-14  Tim Horton  <timothy_horton@apple.com>
1424
1425         Move a test implementation file that got misplaced in the Xcode project
1426
1427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1428
1429 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1430
1431         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1432         r239913, and r239914.
1433         https://bugs.webkit.org/show_bug.cgi?id=193407
1434
1435         These revisions caused an internal failure (Requested by
1436         Truitt on #webkit).
1437
1438         Reverted changesets:
1439
1440         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1441         https://bugs.webkit.org/show_bug.cgi?id=186016
1442         https://trac.webkit.org/changeset/239901
1443
1444         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1445         https://trac.webkit.org/changeset/239909
1446
1447         "Tried to fix the build."
1448         https://trac.webkit.org/changeset/239910
1449
1450         "Fixed iOS builds after r239910."
1451         https://trac.webkit.org/changeset/239912
1452
1453         "More build fixing."
1454         https://trac.webkit.org/changeset/239913
1455
1456         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1457         https://trac.webkit.org/changeset/239914
1458
1459 2019-01-14  Mark Lam  <mark.lam@apple.com>
1460
1461         Re-enable ability to build --cloop builds.
1462         https://bugs.webkit.org/show_bug.cgi?id=192955
1463         <rdar://problem/46882363>
1464
1465         Reviewed by Saam barati and Keith Miller.
1466
1467         The --cloop build option was being ignored this whole time since r236381.
1468         This patch makes it possible to build CLoop builds again.
1469
1470         * Scripts/build-jsc:
1471         * Scripts/webkitperl/FeatureList.pm:
1472         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1473
1474 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1475
1476         webkitpy: Expose device_type from host-like objects
1477         https://bugs.webkit.org/show_bug.cgi?id=193406
1478         <rdar://problem/47262305>
1479
1480         Reviewed by Lucas Forschler.
1481
1482         Devices should expose device_type. As a result, all host objects should
1483         provide a device_type property, even if they do not yet define a device_type.
1484
1485         * Scripts/webkitpy/common/system/systemhost.py:
1486         (SystemHost):
1487         (SystemHost.device_type):
1488         * Scripts/webkitpy/common/system/systemhost_mock.py:
1489         (MockSystemHost):
1490         (MockSystemHost.device_type):
1491         * Scripts/webkitpy/port/device.py:
1492         (Device):
1493         (Device.device_type):
1494         * Scripts/webkitpy/xcode/simulated_device.py:
1495         (SimulatedDeviceManager._find_exisiting_device_for_request):
1496         (SimulatedDeviceManager._disambiguate_device_type):
1497         (SimulatedDeviceManager._does_fulfill_request):
1498         (SimulatedDeviceManager.device_count_for_type):
1499         (SimulatedDeviceManager.initialize_devices):
1500         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1501         (test_available_devices):
1502         (test_swapping_devices):
1503
1504 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1505
1506         webkitpy: Support alternate simctl device list output (Follow-up fix)
1507         https://bugs.webkit.org/show_bug.cgi?id=193362
1508         <rdar://problem/47122965>
1509
1510         Rubber-stamped by Lucas Forschler.
1511
1512         * Scripts/webkitpy/xcode/simulated_device.py:
1513         (SimulatedDeviceManager.populate_available_devices):
1514
1515 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1516
1517         [iOS] Expose SPI to access the current sentence boundary and selection state
1518         https://bugs.webkit.org/show_bug.cgi?id=193398
1519         <rdar://problem/45893108>
1520
1521         Reviewed by Dean Jackson.
1522
1523         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
1524         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
1525         expected.
1526
1527         * TestWebKitAPI/EditingTestHarness.h:
1528         * TestWebKitAPI/EditingTestHarness.mm:
1529         (-[EditingTestHarness moveBackward]):
1530         (-[EditingTestHarness moveForward]):
1531         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
1532
1533         Add a couple of new helper methods on EditingTestHarness.
1534
1535         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1536         (-[SelectionChangeObserver initWithWebView:]):
1537         (-[SelectionChangeObserver webView]):
1538         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
1539         (-[SelectionChangeObserver currentSelectionAttributes]):
1540
1541 2019-01-14  Zalan Bujtas  <zalan@apple.com>
1542
1543         [LFC][BFC] Add basic box-sizing support.
1544         https://bugs.webkit.org/show_bug.cgi?id=193392
1545
1546         Reviewed by Antti Koivisto.
1547
1548         * LayoutReloaded/misc/LFC-passing-tests.txt:
1549
1550 2019-01-14  Charlie Turner  <cturner@igalia.com>
1551
1552         [WPE] API test gardening
1553         https://bugs.webkit.org/show_bug.cgi?id=193319
1554
1555         Reviewed by Michael Catanzaro.
1556
1557         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
1558         passing tests.
1559
1560 2019-01-14  Charlie Turner  <cturner@igalia.com>
1561
1562         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
1563         https://bugs.webkit.org/show_bug.cgi?id=192977
1564
1565         Reviewed by Carlos Garcia Campos.
1566
1567         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
1568         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1569         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
1570         (TestWebKitAPI::GStreamerTest::SetUp):
1571         (TestWebKitAPI::GStreamerTest::TearDown):
1572         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
1573         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
1574         (TestWebKitAPI::TEST_F):
1575
1576 2019-01-14  Charlie Turner  <cturner@igalia.com>
1577
1578         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
1579         https://bugs.webkit.org/show_bug.cgi?id=193332
1580
1581         Reviewed by Michael Catanzaro.
1582
1583         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
1584         defined as a char16_t, which changed in ICU 59, the
1585         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
1586         unsigned short. This test is relying on the behaviour that
1587         UChar=unsigned short, which doesn't hold across platforms and ICU
1588         library versions. The full fix would be a special syntax for
1589         literal characters so that these ambiguities do not arise. That
1590         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
1591         (TestWebKitAPI::TEST):
1592
1593 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1594
1595         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
1596
1597         * Scripts/make-dist:
1598         (Distcheck.configure):
1599
1600 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
1601
1602         [ews-build] Update macOS queue configurations
1603         https://bugs.webkit.org/show_bug.cgi?id=193365
1604         <rdar://problem/47221073>
1605
1606         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
1607
1608         * BuildSlaveSupport/ews-build/config.json:
1609
1610 2019-01-13  Zalan Bujtas  <zalan@apple.com>
1611
1612         [LFC] Adjust assert for statically positioned fixed elements
1613         https://bugs.webkit.org/show_bug.cgi?id=193385
1614
1615         Reviewed by Antti Koivisto.
1616
1617         * LayoutReloaded/misc/LFC-passing-tests.txt:
1618
1619 2019-01-13  Philippe Normand  <pnormand@igalia.com>
1620
1621         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
1622         https://bugs.webkit.org/show_bug.cgi?id=193387
1623
1624         Reviewed by Carlos Garcia Campos.
1625
1626         * MiniBrowser/wpe/main.cpp:
1627         (main):
1628
1629 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1630
1631         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1632         https://bugs.webkit.org/show_bug.cgi?id=191655
1633         rdar://problem/46074680
1634
1635         Reviewed by Megan Gardner.
1636
1637         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1638         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1639
1640 2019-01-12  Dan Bernstein  <mitz@apple.com>
1641
1642         [Cocoa] Avoid importing directly from subumbrella frameworks
1643         https://bugs.webkit.org/show_bug.cgi?id=186016
1644         <rdar://problem/40591038>
1645
1646         Reviewed by Sam Weinig.
1647
1648         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1649           LaunchServices header.
1650         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1651           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1652         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1653           when using SDKs earlier than 10.13.
1654         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1655           and OTHER_CPLUSPLUSFLAGS.
1656         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1657           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1658         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1659           LaunchServices header.
1660
1661 2019-01-11  John Wilander  <wilander@apple.com>
1662
1663         Compile out Web API Statistics Collection
1664         https://bugs.webkit.org/show_bug.cgi?id=193370
1665         <rdar://problem/45388584>
1666
1667         Reviewed by Brent Fulgham.
1668
1669         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1670             Defined ENABLE_WEB_API_STATISTICS, off by default.
1671
1672 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1673
1674         [WPE] Add gtk-doc
1675         https://bugs.webkit.org/show_bug.cgi?id=178900
1676
1677         Reviewed by Michael Catanzaro.
1678
1679         Add Tools/gtkdoc to manifest.txt.in files.
1680         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
1681
1682         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
1683         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
1684
1685 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1686
1687         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
1688         https://bugs.webkit.org/show_bug.cgi?id=193364
1689         <rdar://problem/47214117>
1690
1691         Reviewed by Tim Horton.
1692
1693         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
1694         precise, whereas dragging near the middle of the textarea does.
1695
1696         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1697         (TestWebKitAPI::TEST):
1698
1699 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1700
1701         webkitpy: Support alternate simctl device list output
1702         https://bugs.webkit.org/show_bug.cgi?id=193362
1703         <rdar://problem/47122965>
1704
1705         Reviewed by Lucas Forschler.
1706
1707         * Scripts/webkitpy/xcode/simulated_device.py:
1708         (SimulatedDeviceManager.populate_available_devices):
1709
1710 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
1711
1712         [ews-build] Update macOS queue configurations
1713         https://bugs.webkit.org/show_bug.cgi?id=193365
1714
1715         Reviewed by Lucas Forschler.
1716
1717         * BuildSlaveSupport/ews-build/config.json:
1718
1719 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1720
1721         webkitpy: Incorporate device type into baseline search path
1722         https://bugs.webkit.org/show_bug.cgi?id=193356
1723         <rdar://problem/47215515>
1724
1725         Reviewed by Lucas Forschler.
1726
1727         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
1728
1729         * Scripts/webkitpy/port/base.py:
1730         (Port.default_baseline_search_path): Allow device type to be passed in.
1731         * Scripts/webkitpy/port/gtk.py:
1732         (GtkPort.default_baseline_search_path): Ignore device type.
1733         * Scripts/webkitpy/port/ios.py:
1734         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
1735         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
1736         * Scripts/webkitpy/port/ios_device_unittest.py:
1737         (IOSDeviceTest):
1738         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1739         (IOSSimulatorTest):
1740         * Scripts/webkitpy/port/mac.py:
1741         (MacPort.default_baseline_search_path): Ignore device type.
1742         * Scripts/webkitpy/port/watch.py:
1743         (WatchPort.default_baseline_search_path): Ditto.
1744         * Scripts/webkitpy/port/win.py:
1745         (WinPort.default_baseline_search_path): Ditto.
1746         (WinCairoPort.default_baseline_search_path): Ditto.
1747         * Scripts/webkitpy/port/wpe.py:
1748         (WPEPort.default_baseline_search_path): Ditto.
1749
1750 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1751
1752         webkitpy: Print abbreviated baseline search path that includes only folders that exist
1753         https://bugs.webkit.org/show_bug.cgi?id=193352
1754         <rdar://problem/47210736>
1755
1756         Reviewed by Lucas Forschler.
1757
1758         * Scripts/webkitpy/layout_tests/views/printing.py:
1759         (Printer.print_config): Print list on only baseline search paths which exist. 
1760         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1761         (Testprinter.test_print_config):
1762
1763 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
1764
1765         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
1766         https://bugs.webkit.org/show_bug.cgi?id=193340
1767
1768         Reviewed by David Kilzer.
1769
1770         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1771         (WTR::InjectedBundle::didReceiveMessageToPage):
1772         Pull the strings out into a WKRetainPtr.
1773
1774         * WebKitTestRunner/WebNotificationProvider.cpp:
1775         (WTR::WebNotificationProvider::closeWebNotification):
1776         Adopt the created value into the WKRetainPtr.
1777
1778         * WebKitTestRunner/mac/TestControllerMac.mm:
1779         (WTR::generateWhitelist):
1780         Immediately adopt a created value to avoid potential mistakes.
1781
1782 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
1783
1784         Enable DFG on ARM/Linux again
1785         https://bugs.webkit.org/show_bug.cgi?id=192496
1786
1787         Reviewed by Yusuke Suzuki.
1788
1789         After changing the bytecode format DFG was disabled on all 32-bit
1790         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1791         on ARM by default.
1792
1793         * Scripts/run-jsc-stress-tests:
1794
1795 2019-01-11  Timothy Hatcher  <timothy@apple.com>
1796
1797         Unreviewed, fix #ifdef in API test added in r239851.
1798         https://bugs.webkit.org/show_bug.cgi?id=193327
1799         rdar://problem/47093222
1800
1801         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1802
1803 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1804
1805         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
1806         https://bugs.webkit.org/show_bug.cgi?id=193109
1807         <rdar://problem/44807048>
1808
1809         Reviewed by Ryosuke Niwa.
1810
1811         Introduce and respect a test option to enable the UndoManager API.
1812
1813         * WebKitTestRunner/TestController.cpp:
1814         (WTR::updateTestOptionsFromTestHeader):
1815         * WebKitTestRunner/TestOptions.h:
1816         (WTR::TestOptions::hasSameInitializationOptions const):
1817         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1818         (WTR::TestController::platformCreateWebView):
1819
1820 2019-01-11  Zalan Bujtas  <zalan@apple.com>
1821
1822         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
1823         https://bugs.webkit.org/show_bug.cgi?id=193346
1824
1825         Reviewed by Antti Koivisto.
1826
1827         * LayoutReloaded/misc/LFC-passing-tests.txt:
1828
1829 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1830
1831         Unreviewed, fix typo that breaks dashboard link.
1832
1833         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1834         (WebKitBuildbot):
1835
1836 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1837
1838         Update macOS queue configurations
1839         https://bugs.webkit.org/show_bug.cgi?id=193329
1840
1841         Reviewed by Alexey Proskuryakov.
1842
1843         * BuildSlaveSupport/build.webkit.org-config/config.json:
1844         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1845         (BubbleQueueServer):
1846         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1847         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1848         (WebKitBuildbot):
1849         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1850         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
1851         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1852
1853 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1854
1855         MiniBrowser should be able to navigate to about:blank
1856         https://bugs.webkit.org/show_bug.cgi?id=193345
1857
1858         Reviewed by Simon Fraser.
1859
1860         * MiniBrowser/mac/BrowserWindowController.m:
1861         (-[BrowserWindowController addProtocolIfNecessary:]):
1862         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
1863
1864         * MiniBrowser/mac/WK1BrowserWindowController.m:
1865         (-[WK1BrowserWindowController fetch:]):
1866         * MiniBrowser/mac/WK2BrowserWindowController.m:
1867         (-[WK2BrowserWindowController fetch:]):
1868         Clean up the code that uses this to match style.
1869
1870 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1871
1872         Remove MiniBrowser custom "Process Swap" menu item which does not work
1873         https://bugs.webkit.org/show_bug.cgi?id=193344
1874
1875         Reviewed by Simon Fraser.
1876
1877         There is a menu item under the Experimental menu that does work.
1878
1879         * MiniBrowser/mac/AppDelegate.m:
1880         (defaultConfiguration):
1881         * MiniBrowser/mac/SettingsController.h:
1882         * MiniBrowser/mac/SettingsController.m:
1883         (-[SettingsController _populateMenu]):
1884         (-[SettingsController validateMenuItem:]):
1885         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
1886         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
1887
1888 2019-01-10  Timothy Hatcher  <timothy@apple.com>
1889
1890         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
1891         https://bugs.webkit.org/show_bug.cgi?id=193327
1892         rdar://problem/47093222
1893
1894         Reviewed by Tim Horton.
1895
1896         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1897         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
1898         (TestWebKitAPI::didFinishNavigation):
1899         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1900         (TestWebKitAPI::TEST):
1901         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
1902         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
1903         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
1904         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
1905         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
1906
1907 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1908
1909         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
1910         https://bugs.webkit.org/show_bug.cgi?id=193338
1911         <rdar://problem/46664774>
1912
1913         Reviewed by David Kilzer.
1914
1915         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1916         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1917
1918 2019-01-10  Commit Queue  <commit-queue@webkit.org>
1919
1920         Unreviewed, rolling out r239825.
1921         https://bugs.webkit.org/show_bug.cgi?id=193330
1922
1923         Broke tests on armv7/linux bots (Requested by guijemont on
1924         #webkit).
1925
1926         Reverted changeset:
1927
1928         "Enable DFG on ARM/Linux again"
1929         https://bugs.webkit.org/show_bug.cgi?id=192496
1930         https://trac.webkit.org/changeset/239825
1931
1932 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
1933
1934         Disable the run-jsc-stress-test remote host key check.
1935         https://bugs.webkit.org/show_bug.cgi?id=192988
1936
1937         Reviewed by Alexey Proskuryakov.
1938
1939         * Scripts/run-jsc-stress-tests:
1940
1941 2019-01-10  John Wilander  <wilander@apple.com>
1942
1943         Override the session configuration for cookieAcceptPolicy
1944         https://bugs.webkit.org/show_bug.cgi?id=190925
1945         <rdar://problem/45497382>
1946
1947         Reviewed by Alexey Proskuryakov and Alex Christensen.
1948
1949         Test infrastructure for setting a first-party-only cookie policy.
1950
1951         * DumpRenderTree/TestRunner.cpp:
1952         (setOnlyAcceptFirstPartyCookiesCallback):
1953         (TestRunner::staticFunctions):
1954         * DumpRenderTree/TestRunner.h:
1955         * DumpRenderTree/mac/TestRunnerMac.mm:
1956         (TestRunner::setOnlyAcceptFirstPartyCookies):
1957         * DumpRenderTree/win/TestRunnerWin.cpp:
1958         (TestRunner::setOnlyAcceptFirstPartyCookies):
1959         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1960         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1961         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1962         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1963         * WebKitTestRunner/TestInvocation.cpp:
1964         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1965
1966 2019-01-09  Matt Rajca  <mrajca@apple.com>
1967
1968         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
1969         https://bugs.webkit.org/show_bug.cgi?id=193301
1970
1971         Reviewed by Jer Noble.
1972         
1973         Added API tests.
1974
1975         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1976         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1977         (TEST):
1978         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
1979
1980 2019-01-10  Zalan Bujtas  <zalan@apple.com>
1981
1982         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
1983         https://bugs.webkit.org/show_bug.cgi?id=193310
1984
1985         Reviewed by Antti Koivisto.
1986
1987         * LayoutReloaded/misc/LFC-passing-tests.txt:
1988
1989 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
1990
1991         Enable DFG on ARM/Linux again
1992         https://bugs.webkit.org/show_bug.cgi?id=192496
1993
1994         Reviewed by Yusuke Suzuki.
1995
1996         After changing the bytecode format DFG was disabled on all 32-bit
1997         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1998         on ARM by default.
1999
2000         * Scripts/run-jsc-stress-tests:
2001
2002 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2003
2004         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2005         https://bugs.webkit.org/show_bug.cgi?id=193271
2006
2007         Reviewed by Brent Fulgham.
2008
2009         BSTR is a special data structure created by SysAllocString, not a
2010         wchar_t null-terminated string.
2011
2012         * DumpRenderTree/win/TestRunnerWin.cpp:
2013         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2014         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2015         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2016         BSTR from wide string literals.
2017
2018 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2019
2020         Tweak wording for build/version_check style checker error
2021         https://bugs.webkit.org/show_bug.cgi?id=193256
2022
2023         Reviewed by Tim Horton.
2024
2025         * Scripts/webkitpy/style/checkers/cpp.py:
2026         (check_os_version_checks):
2027         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2028         (WebKitStyleTest.test_os_version_checks):
2029
2030 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2031
2032         [ews-build] Add link to bug along with bug title
2033         https://bugs.webkit.org/show_bug.cgi?id=193293
2034
2035         Reviewed by Lucas Forschler.
2036
2037         * BuildSlaveSupport/ews-build/steps.py:
2038         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2039         (ConfigureBuild.add_bug_id_url): Deleted.
2040         (ConfigureBuild.getBugURL): Deleted.
2041
2042 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2043
2044         [ews-build] Use https for ews-build server
2045         https://bugs.webkit.org/show_bug.cgi?id=193193
2046
2047         Reviewed by Lucas Forschler.
2048
2049         * BuildSlaveSupport/ews-build/steps.py:
2050
2051 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2052
2053         [ews-build] Parse and display number of style failures
2054         https://bugs.webkit.org/show_bug.cgi?id=193280
2055
2056         Reviewed by Lucas Forschler.
2057
2058         * BuildSlaveSupport/ews-build/steps.py:
2059         (CheckStyle): Use TestWithFailureCount as base class.
2060         (CheckStyle.countFailures): Count the number of style failures.
2061
2062 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2063
2064         [ews-build] use patch_id instead of ewspatchid
2065         https://bugs.webkit.org/show_bug.cgi?id=193235
2066
2067         Reviewed by Lucas Forschler.
2068
2069         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2070         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2071         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2072
2073 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2074
2075         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2076         https://bugs.webkit.org/show_bug.cgi?id=192625
2077
2078         Reviewed by Antti Koivisto.
2079
2080         * LayoutReloaded/misc/LFC-passing-tests.txt:
2081
2082 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2083
2084         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2085         https://bugs.webkit.org/show_bug.cgi?id=192841
2086
2087         Reviewed by Carlos Garcia Campos.
2088
2089         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2090         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2091         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2092
2093         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2094
2095         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2096         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2097         (WebKitWebEditorTest::testSelectionChanged):
2098         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2099         (WebKitFrameTest::testMainFrame):
2100         (WebKitFrameTest::testURI):
2101         (WebKitFrameTest::testJavaScriptContext):
2102         (WebKitFrameTest::testJavaScriptValues):
2103         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2104         (testWebViewAuthenticationRequest):
2105         (testWebViewAuthenticationLoadCancelled):
2106         (testWebViewAuthenticationFailure):
2107         (testWebViewAuthenticationStorage):
2108         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2109         (testWebViewAuthenticationProxy):
2110         (testWebViewAuthenticationProxyHTTPS):
2111         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2112         (testAutomationSessionRequestSession):
2113         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2114         (testBackForwardListNavigation):
2115         (testWebKitWebViewSessionState):
2116         (testWebKitWebViewSessionStateWithFormData):
2117         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2118         (ConsoleMessageTest::consoleMessageReceivedCallback):
2119         (testWebKitConsoleMessageConsoleAPI):
2120         (testWebKitConsoleMessageJavaScriptException):
2121         (testWebKitConsoleMessageNetworkError):
2122         (testWebKitConsoleMessageSecurityError):
2123         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2124         (testCookieManagerAcceptPolicy):
2125         (testCookieManagerCookiesChanged):
2126         (testCookieManagerPersistentStorage):
2127         (testCookieManagerPersistentStorageDeleteAll):
2128         (testCookieManagerEphemeral):
2129         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2130         (testWebKitDOMElementAutoFill):
2131         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2132         (downloadLocalFileSuccessfully):
2133         (createFileAtDestination):
2134         (testDownloadOverwriteDestinationDisallowed):
2135         (testDownloadLocalFileError):
2136         (testDownloadRemoteFile):
2137         (testDownloadRemoteFileError):
2138         (testWebViewDownloadURI):
2139         (testPolicyResponseDownload):
2140         (testPolicyResponseDownloadCancel):
2141         (testDownloadMIMEType):
2142         (contextMenuCallback):
2143         (testContextMenuDownloadActions):
2144         (testBlobDownload):
2145         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2146         (testWebKitWebEditorSelectionChanged):
2147         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2148         (testWebKitFrameMainFrame):
2149         (testWebKitFrameURI):
2150         (testWebKitFrameJavaScriptContext):
2151         (testWebKitFrameJavaScriptValues):
2152         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2153         (LoadStopTrackingTest::loadFailed):
2154         (testWebViewTitle):
2155         (testURIRequestHTTPHeaders):
2156         (testURIRequestHTTPMethod):
2157         (testURIResponseHTTPHeaders):
2158         (testRedirectToDataURI):
2159         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2160         (testProcessPerWebView):
2161         (testWebProcessLimit):
2162         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2163         (testWebViewResources):
2164         (testWebResourceLoading):
2165         (testWebResourceSuggestedFilename):
2166         (testWebResourceGetData):
2167         (testWebResourceGetDataError):
2168         (testWebViewResourcesHistoryCache):
2169         (testWebResourceSendRequest):
2170         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2171         (testSSL):
2172         (testInsecureContent):
2173         (testTLSErrorsPolicy):
2174         (testTLSErrorsRedirect):
2175         (testTLSErrorsHTTPAuth):
2176         (testLoadFailedWithTLSErrors):
2177         (testSubresourceLoadFailedWithTLSErrors):
2178         (httpsServerCallback):
2179         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2180         (testWebViewCreateNavigationData):
2181         (testWebViewJavaScriptDialogs):
2182         (testWebViewWindowProperties):
2183         (testWebViewMouseTarget):
2184         (testWebViewFileChooserRequest):
2185         (testWebViewColorChooserRequest):
2186         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2187         (testWebExtensionGetTitle):
2188         (testDocumentLoadedSignal):
2189         (testWebKitWebViewProcessCrashed):
2190         (testWebExtensionWindowObjectCleared):
2191         (testWebExtensionIsolatedWorld):
2192         (permissionRequestCallback):
2193         (didAssociateFormControlsCallback):
2194         (testWebExtensionFormControlsAssociated):
2195         (FormSubmissionTest::FormSubmissionTest):
2196         (FormSubmissionTest::testFormSubmissionResult):
2197         (testWebExtensionFormSubmissionSteps):
2198         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2199         (testNotInitialized):
2200         (testClearDatabase):
2201         (testPrivateBrowsing):
2202         (testGetFavicon):
2203         (testWebViewFavicon):
2204         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2205         (testFindControllerTextFound):
2206         (testFindControllerTextNotFound):
2207         (testFindControllerMatchCount):
2208         (testFindControllerMaxMatchCount):
2209         (testFindControllerNext):
2210         (testFindControllerPrevious):
2211         (testFindControllerCountedMatches):
2212         (testFindControllerOptions):
2213         (testFindControllerHide):
2214         (testFindControllerInstance):
2215         (testFindControllerGetters):
2216         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2217         (testNavigationPolicy):
2218         (testResponsePolicy):
2219         (testNewWindowPolicy):
2220         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2221         (testSecurityOriginBasicConstructor):
2222         (testSecurityOriginURIConstructor):
2223         (testSecurityOriginDefaultPort):
2224         (testSecurityOriginFileURI):
2225         (testOpaqueSecurityOrigin):
2226         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2227         (testWebKitSettings):
2228         (testWebKitSettingsNewWithSettings):
2229         (testWebKitSettingsUserAgent):
2230         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2231         (testWebViewNewWithUserContentManager):
2232         (isStyleSheetInjectedForURLAtPath):
2233         (isScriptInjectedForURLAtPath):
2234         (testUserContentManagerInjectedStyleSheet):
2235         (testUserContentManagerInjectedScript):
2236         (UserScriptMessageTest::scriptMessageReceived):
2237         (UserScriptMessageTest::waitUntilMessageReceived):
2238         (UserScriptMessageTest::runJavaScriptFinished):
2239         (testUserContentManagerScriptMessageReceived):
2240         (testUserContentManagerScriptMessageInWorldReceived):
2241         (testUserContentManagerScriptMessageFromDOMBindings):
2242         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2243         (testWebContextDefault):
2244         (testWebContextEphemeral):
2245         (testWebContextGetPlugins):
2246         (testWebContextURIScheme):
2247         (testWebContextSpellChecker):
2248         (testWebContextLanguages):
2249         (consoleMessageReceivedCallback):
2250         (testWebContextSecurityFileXHR):
2251         (ProxyTest::ProxyTest):
2252         (testWebContextProxySettings):
2253         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2254         (testWebViewWebContext):
2255         (testWebViewWebBackend):
2256         (testWebViewEphemeral):
2257         (testWebViewCustomCharset):
2258         (testWebViewSettings):
2259         (testWebViewRunJavaScript):
2260         (testWebViewCanShowMIMEType):
2261         (testWebViewSubmitForm):
2262         (testWebViewSave):
2263         (testWebViewPageVisibility):
2264         (testWebViewSnapshot):
2265         (testWebViewNotification):
2266         (testWebViewNotificationInitialPermissionAllowed):
2267         (testWebViewNotificationInitialPermissionDisallowed):
2268         (testWebViewIsPlayingAudio):
2269         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2270         (WebsiteDataTest::WebsiteDataTest):
2271         (WebsiteDataTest::remove):
2272         (WebsiteDataTest::clear):
2273         (testWebsiteDataConfiguration):
2274         (testWebsiteDataEphemeral):
2275         (testWebsiteDataCache):
2276         (testWebsiteDataStorage):
2277         (testWebsiteDataDatabases):
2278         (testWebsiteDataAppcache):
2279         (testWebsiteDataCookies):
2280         (testWebsiteDataDeviceIdHashSalt):
2281         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2282         (emitDocumentLoaded):
2283         (emitURIChanged):
2284         (sendRequestCallback):
2285         (contextMenuCallback):
2286         (consoleMessageSentCallback):
2287         (emitFormControlsAssociated):
2288         (formControlsAssociatedCallback):
2289         (emitFormSubmissionEvent):
2290         (willSubmitFormCallback):
2291         (windowObjectCleared):
2292         (methodCallCallback):
2293         (registerGResource):
2294         (webkit_web_extension_initialize_with_user_data):
2295         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2296         (checkLeaks):
2297         (WebProcessTest::create):
2298         (runTest):
2299         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2300         (AutocleanupsTest::testWebProcessAutocleanups):
2301         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2302         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2303         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2304         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2305         (WebKitDOMDOMWindowTest::testSignals):
2306         (WebKitDOMDOMWindowTest::testDispatchEvent):
2307         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2308         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2309         (WebKitDOMNodeFilterTest::testTreeWalker):
2310         (WebKitDOMNodeFilterTest::testNodeIterator):
2311         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2312         (WebKitDOMNodeTest::testHierarchyNavigation):
2313         (WebKitDOMNodeTest::testInsertion):
2314         (WebKitDOMNodeTest::testTagNamesNodeList):
2315         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2316         (WebKitDOMNodeTest::testDOMCache):
2317         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2318         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2319         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2320         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2321         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2322         (testUIProcessAutocleanups):
2323         (testWebProcessAutocleanups):
2324         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2325         (testContextMenuPopulateMenu):
2326         (testContextMenuDismissed):
2327         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2328         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2329         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2330         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
2331         (testWebKitDOMDOMWindowSignals):
2332         (testWebKitDOMDOMWindowDispatchEvent):
2333         (testWebKitDOMDOMWindowGetComputedStyle):
2334         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
2335         (testWebKitDOMNodeHierarchyNavigation):
2336         (testWebKitDOMNodeInsertion):
2337         (testWebKitDOMNodeTagNamesNodeList):
2338         (testWebKitDOMNodeTagNamesHTMLCollection):
2339         (testWebKitDOMObjectCache):
2340         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
2341         (testWebKitDOMNodeFilterTreeWalker):
2342         (testWebKitDOMNodeFilterNodeIterator):
2343         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
2344         (testWebKitDOMXPathNSResolverNative):
2345         (testWebKitDOMXPathNSResolverCustom):
2346         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2347         (testInspectorDefault):
2348         (testInspectorManualAttachDetach):
2349         (testInspectorCustomContainerDestroyed):
2350         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
2351         (startTestServer):
2352         (testInspectorServerPageList):
2353         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
2354         (OptionMenuTest::showOptionMenuCallback):
2355         (OptionMenuTest::menuCloseCallback):
2356         (OptionMenuTest::close):
2357         (OptionMenuTest::activateItem):
2358         (OptionMenuTest::selectItem):
2359         (testOptionMenuSimple):
2360         (testOptionMenuGroups):
2361         (testOptionMenuActivate):
2362         (testOptionMenuSelect):
2363         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2364         (testPrintOperationPrintSettings):
2365         (webViewPrintCallback):
2366         (testPrintOperationPrint):
2367         (testPrintCustomWidget):
2368         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2369         (checkAtspiAccessible):
2370         (testAtspiBasicHierarchy):
2371         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
2372         (testWebKitCheckVersion):
2373         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2374         (testWebViewEditorCutCopyPasteNonEditable):
2375         (testWebViewEditorCutCopyPasteEditable):
2376         (testWebViewEditorSelectAllNonEditable):
2377         (testWebViewEditorSelectAllEditable):
2378         (loadContentsAndTryToCutSelection):
2379         (testWebViewEditorNonEditable):
2380         (testWebViewEditorEditable):
2381         (testWebViewEditorEditorStateTypingAttributes):
2382         (testWebViewEditorInsertImage):
2383         (testWebViewEditorCreateLink):
2384         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2385         (loadChangedCallback):
2386         (loadFailedCallback):
2387         (loadFailedWithTLSErrorsCallback):
2388         (LoadTrackingTest::LoadTrackingTest):
2389         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2390         (registerGResource):
2391         (removeNonEmptyDirectory):
2392         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2393         (Test::adoptView):
2394         (Test::~Test):
2395         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2396         (WebKitTestBus::getOrCreateConnection):
2397         (WebKitTestBus::createProxy):
2398         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2399         (WebKitTestServer::getWebSocketURIForPath const):
2400         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2401         (WebViewTest::initializeWebView):
2402         (WebViewTest::loadURI):
2403         (WebViewTest::loadHtml):
2404         (WebViewTest::loadPlainText):
2405         (WebViewTest::loadBytes):
2406         (WebViewTest::loadRequest):
2407         (WebViewTest::loadAlternateHTML):
2408         (WebViewTest::goBack):
2409         (WebViewTest::goForward):
2410         (WebViewTest::goToBackForwardListItem):
2411         (resourceGetDataCallback):
2412         (WebViewTest::mainResourceData):
2413         (WebViewTest::javascriptResultToCString):
2414         (WebViewTest::javascriptResultToNumber):
2415         (WebViewTest::javascriptResultToBoolean):
2416         (WebViewTest::javascriptResultIsNull):
2417         (WebViewTest::javascriptResultIsUndefined):
2418         (onSnapshotReady):
2419         (WebViewTest::runWebProcessTest):
2420         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
2421         (WebViewTest::platformInitializeWebView):
2422         (WebViewTest::showInWindow):
2423         (WebViewTest::showInWindowAndWaitUntilMapped):
2424         (WebViewTest::mouseMoveTo):
2425         (WebViewTest::emitPopupMenuSignal):
2426         (WebViewTest::keyStroke):
2427         (WebViewTest::doMouseButtonEvent):
2428
2429 2019-01-09  Philippe Normand  <pnormand@igalia.com>
2430
2431         [WPE] API tests can't run in flatpak environment
2432         https://bugs.webkit.org/show_bug.cgi?id=193242
2433
2434         Reviewed by Michael Catanzaro.
2435
2436         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
2437         flatpakutils so that it knows which port it's dealing with.
2438         * glib/common.py: Remove build_dir globals so that subsequent
2439         calls actually take args into account.
2440         (library_build_path):
2441         (binary_build_path):
2442
2443 2019-01-08  Dean Jackson  <dino@apple.com>
2444
2445         Blob references for System Previews don't get a correct file extension
2446         https://bugs.webkit.org/show_bug.cgi?id=193268
2447         <rdar://problem/47133037>
2448
2449         Reviewed by Tim Horton.
2450
2451         New test that a Blob download of a USDZ file gets named correctly.
2452
2453         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2454         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2455         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2456         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
2457         (TEST):
2458         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
2459
2460 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
2461
2462         [WebAuthN] Support U2F HID Authenticators on macOS
2463         https://bugs.webkit.org/show_bug.cgi?id=191535
2464         <rdar://problem/47102027>
2465
2466         Reviewed by Brent Fulgham.
2467
2468         This patch:
2469         1) adds support for U2F mocking mechanism;
2470         2) updates tests to reflect U2fCommandConstructor changes.
2471
2472         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2473         (TestWebKitAPI::TEST):
2474         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2475         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2476         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2477
2478 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2479
2480         [iOS] Dispatch a synthetic mousedown event prior to starting drags
2481         https://bugs.webkit.org/show_bug.cgi?id=193229
2482         <rdar://problem/46717097>
2483
2484         Reviewed by Tim Horton.
2485
2486         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
2487         prevents a drag from starting.
2488
2489         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2490         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
2491
2492         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
2493
2494 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
2495   
2496         Layout test will generate a perf metric file to results dir.
2497         https://bugs.webkit.org/show_bug.cgi?id=192030
2498         <rdar://problem/32779516>
2499
2500         Reviewed by Aakash Jain.
2501
2502         Layout test running time will be collected to a perf metric file.
2503         For now, instead of outputing running time of all tests (which is huge),
2504         we aggregate them by test directories which are at most two level deep. 
2505
2506         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2507         (Manager._end_test_run):
2508         (Manager._output_perf_metrics):
2509         (Manager._print_expectation_line_for_test):
2510         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2511         (add_test_perf_metric):
2512         (test_perf_metrics):
2513         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2514         (JSONGeneratorTest.test_test_timings_trie):
2515         (JSONGeneratorTest):
2516         (JSONGeneratorTest.test_test_perf_metrics):
2517         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2518         (RebaselineTest.test_reset_results):
2519         (RebaselineTest.test_missing_results):
2520         (RebaselineTest.test_new_baseline):
2521
2522 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
2523
2524         [WPE][GTK] Add php-json to install-dependencies
2525         https://bugs.webkit.org/show_bug.cgi?id=193233
2526
2527         Reviewed by Michael Catanzaro.
2528
2529         * gtk/install-dependencies:
2530         * wpe/install-dependencies:
2531
2532 2019-01-08  Chris Dumez  <cdumez@apple.com>
2533
2534         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
2535         https://bugs.webkit.org/show_bug.cgi?id=193224
2536         <rdar://problem/47097726>
2537
2538         Reviewed by Alex Christensen.
2539
2540         Add API test coverage.
2541
2542         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2543
2544 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2545
2546         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
2547         <https://webkit.org/b/193222>
2548         <rdar://problem/46862309>
2549
2550         Reviewed by Joseph Pecoraro.
2551
2552         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2553         (WTR::executeCallback): Fix camel case of variable name.
2554         (WTR::EventSendingController::callAfterScrollingCompletes): If
2555         WKBundlePageRegisterScrollOperationCompletionCallback() returns
2556         false, make sure to release the ScrollCompletionCallbackData
2557         object.  This fixes the leak.
2558
2559 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2560
2561         [Win] EWS: wincairo-ews cannot apply a patch with *.png
2562         https://bugs.webkit.org/show_bug.cgi?id=193044
2563
2564         Reviewed by Daniel Bates.
2565
2566         WinCairo EWS bots are using Windows Perl. Binary files should be
2567         opened as binary mode.
2568
2569         * Scripts/svn-apply:
2570         (handleGitBinaryChange): Use 'binmode' for binary file handles.
2571
2572 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
2573
2574         [CMake] Add ENABLE_CSS_TYPED_OM option
2575         https://bugs.webkit.org/show_bug.cgi?id=193216
2576
2577         Reviewed by Michael Catanzaro.
2578
2579         * Scripts/webkitperl/FeatureList.pm:
2580
2581 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2582
2583         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
2584         <https://webkit.org/b/193056>
2585
2586         Reviewed by Alex Christensen.
2587
2588         * Scripts/webkitpy/style/checker.py:
2589         - Ignore use of new runtime/retainptr check in
2590           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
2591           contains tests to ensure RetainPtr<NSObject *> is compatible
2592           with RetainPtr<NSObject>.
2593
2594         * Scripts/webkitpy/style/checkers/cpp.py:
2595         (check_language):
2596         (CppChecker):
2597         - Add checker for use of '*' in RetainPtr<> type.  A for loop
2598           was used instead of a single regex so that angle brackets
2599           could be matched up when checking the type contained within
2600           the RetainPtr<> type.
2601
2602         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2603         (CppStyleTest):
2604         - Add unit test for new runtime/retainptr check.
2605
2606         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
2607         * TestWebKitAPI/EditingTestHarness.h:
2608         - Remove '*' from RetainPtr<> type.
2609
2610         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2611         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
2612           regressed in r201938.
2613
2614         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2615         (TestWebKitAPI::TEST):
2616         - Update tests to match RetainPtr.mm tests (except for the
2617           `*SimilarNSType` tests since there is no CF equivalent of
2618           RetainPtr<NSString> and RetainPtr<NSString *>).
2619
2620         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2621         (TestWebKitAPI::TEST):
2622         - Update tests to:
2623           - Not conflict by name with equivalent CF tests in
2624             RetainPtr.cpp.
2625           - Add test cases for RetainPtr<NSObject>,
2626             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
2627           - Add `*SimilarNSType` tests for converting between
2628             RetainPtr<NSObject> and RetainPtr<NSObject *>.
2629           - Change `0` to `nil` as appropriate.
2630           - Re-alphabetize the tests by name.
2631           - Add Optional<RetainPtr<>> tests.
2632           - Add retainPtr() tests.
2633
2634         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2635         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2636         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
2637         (TEST):
2638         - Remove '*' from RetainPtr<> type.
2639
2640         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
2641         (TEST(WebKit, JITEnabled)):
2642         - Add missing WTFMove().  Apparently a temporary was being
2643           created before in the argument list due to mismatched
2644           RetainPtr<> types.
2645
2646         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2647         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2648         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
2649         (TestWebKitAPI::TEST):
2650         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2651         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2652         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2653         (WTR::resourcesDirectoryURL):
2654         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2655         (WTR::InjectedBundle::platformInitialize):
2656         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2657         - Remove '*' from RetainPtr<> type.
2658
2659 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
2660
2661         A MediaTime timescale must never be zero
2662         https://bugs.webkit.org/show_bug.cgi?id=193156
2663         <rdar://problem/32504501>
2664
2665         Reviewed by Jer Noble.
2666
2667         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2668         (TestWebKitAPI::TEST): Add tests for zero timescale.
2669
2670 2019-01-07  Youenn Fablet  <youenn@apple.com>
2671
2672         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
2673         https://bugs.webkit.org/show_bug.cgi?id=193175
2674
2675         Reviewed by Chris Dumez.
2676
2677         Updated API test as we bumped the SW schema to version 4.
2678
2679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2680         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
2681         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2682         (TEST):
2683
2684 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2685
2686         [Win][Clang] Fix compilation warnings of MiniBrowser
2687         https://bugs.webkit.org/show_bug.cgi?id=193029
2688
2689         Reviewed by Ross Kirsling.
2690
2691         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
2692         and m_URLBarFont. Reorder member variables to fix -Wreorder
2693         warning.
2694         * MiniBrowser/win/PageLoadTestClient.cpp:
2695         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
2696         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
2697         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
2698         m_currentURLIndex.
2699         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2700         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
2701         navigationClient with '{ }' to fix the missing field warning.
2702         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2703         (initDocStruct): Changed the argument type docname to const.
2704
2705 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
2706
2707         [WebAuthN] Import U2F command/response converters from Chromium
2708         https://bugs.webkit.org/show_bug.cgi?id=193150
2709         <rdar://problem/47054028>
2710
2711         Reviewed by Brent Fulgham.
2712
2713         Adds API tests.
2714
2715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2716         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2717         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
2718         (TestWebKitAPI::getTestAuthenticatorDataBytes):
2719         (TestWebKitAPI::getTestAttestationObjectBytes):
2720         (TestWebKitAPI::getTestSignResponse):
2721         (TestWebKitAPI::getTestU2fRegisterResponse):
2722         (TestWebKitAPI::TEST):
2723         (TestWebKitAPI::convertToVector): Deleted.
2724         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2725         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
2726         (TestWebKitAPI::constructMakeCredentialRequest):
2727         (TestWebKitAPI::constructGetAssertionRequest):
2728         (TestWebKitAPI::TEST):
2729
2730 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
2731
2732         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
2733         https://bugs.webkit.org/show_bug.cgi?id=193136
2734
2735         Reviewed by Michael Catanzaro.
2736
2737         * gtk/install-dependencies:
2738         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
2739         they are needed by update-webkitgtk-libs.
2740
2741 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
2742
2743         Unreviewed follow-up fix to r239650
2744         https://bugs.webkit.org/show_bug.cgi?id=193140
2745         <rdar://problem/47063037>
2746
2747         Typecast patch_id to string.
2748
2749         * BuildSlaveSupport/ews-build/steps.py:
2750         (ValidatePatch._is_patch_obsolete):
2751
2752 2019-01-04  Daniel Bates  <dabates@apple.com>
2753
2754         [lldb-webkit]: Add support for pretty-printing raw bitmask types
2755         https://bugs.webkit.org/show_bug.cgi?id=193024
2756
2757         Reviewed by Jer Noble.
2758
2759         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
2760         for the bitmask type WebEventFlags as an example.
2761
2762         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
2763         that can be used to register summary and synthetic child formatters for a bitmask type.
2764         For example, consider the following enum and bitmask typedefs:
2765
2766         typedef enum {
2767             A = 1 << 0,
2768             B = 1 << 1,
2769             C = 1 << 2,
2770         } SpecialFlagValues;
2771         typedef unsigned SpecialFlags;
2772
2773         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
2774         __lldb_init_module():
2775
2776             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
2777                     1 << 0: "A",
2778                     1 << 1: "B",
2779                     1 << 2: "C",
2780             })
2781
2782         * lldb/lldb_webkit.py:
2783         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2784         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
2785         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
2786         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
2787         A convenience function to dynamically creaste a synthetic formatter class and summary
2788         string function for the specified bitmask type and enumerator value to name map. This
2789         function register the dynamically created class and function with LLDB.
2790
2791         (__lldb_init_module):
2792         (FlagEnumerationProvider):
2793         (FlagEnumerationProvider._enumerator_value_to_name_map):
2794         (FlagEnumerationProvider._bitmask):
2795         (FlagEnumerationProvider._update):
2796         (FlagEnumerationProvider.has_children):
2797         (FlagEnumerationProvider.num_children):
2798         (FlagEnumerationProvider.get_child_index):
2799         (FlagEnumerationProvider.get_child_at_index):
2800         (FlagEnumerationProvider.update):
2801         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
2802
2803         (WTFOptionSetProvider):
2804         (WTFOptionSetProvider._enumerator_value_to_name_map):
2805         (WTFOptionSetProvider._bitmask):
2806         (WTFOptionSetProvider._update):
2807         Write in terms of the base class.
2808
2809         (RawBitmaskProviderBase):
2810         (RawBitmaskProviderBase._enumerator_value_to_name_map):
2811         (RawBitmaskProviderBase._bitmask):
2812         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
2813         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
2814         {
2815             1 << 0: "A",
2816             1 << 1: "B",
2817             1 << 2: "C",
2818         }
2819         It is not necessary to instantiate such a derived class directory. Instead use the convenience
2820         function addSummaryAndSyntheticFormattersForRawBitmaskType.
2821
2822         (WTFOptionSetProvider.has_children): Deleted.
2823         (WTFOptionSetProvider.num_children): Deleted.
2824         (WTFOptionSetProvider.get_child_index): Deleted.
2825         (WTFOptionSetProvider.get_child_at_index): Deleted.
2826         (WTFOptionSetProvider.update): Deleted.
2827
2828 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2829
2830         [ews-build] Add build step to validate the patch before processing it
2831         https://bugs.webkit.org/show_bug.cgi?id=193140
2832
2833         Reviewed by Lucas Forschler.
2834
2835         * BuildSlaveSupport/ews-build/factories.py:
2836         (Factory.__init__): Added ValidatePatch step.
2837         * BuildSlaveSupport/ews-build/steps.py:
2838         (ValidatePatch):
2839         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
2840         (ValidatePatch.get_patch_json): Get patch json data.
2841         (ValidatePatch.get_bug_json): Get bug json data.
2842         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
2843         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
2844         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
2845         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
2846         (ValidatePatch.skip_build): Skip the build.
2847         (ValidatePatch.start):
2848
2849 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2850
2851         Progress towards fixing Mac CMake build
2852         https://bugs.webkit.org/show_bug.cgi?id=193105
2853
2854         Reviewed by Don Olmstead.
2855
2856         * TestWebKitAPI/PlatformMac.cmake:
2857
2858 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2859
2860         Fix API test after r239631
2861         https://bugs.webkit.org/show_bug.cgi?id=193118
2862
2863         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2864         (TestWebKitAPI::TEST):
2865         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
2866         Do the same thing via the API to fix the test.
2867
2868 2019-01-04  Jer Noble  <jer.noble@apple.com>
2869
2870         [WebKitLegacy] Media playback pauses on scroll
2871         https://bugs.webkit.org/show_bug.cgi?id=192829
2872
2873         Reviewed by Eric Carlson.
2874
2875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2876         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
2877         (TestWebKitAPI::TEST):
2878         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
2879         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
2880         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
2881         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
2882         (TestWebKitAPI::TEST):
2883
2884 2019-01-04  Chris Dumez  <cdumez@apple.com>
2885
2886         Add support for toggling device orientation API support per site
2887         https://bugs.webkit.org/show_bug.cgi?id=193143
2888         <rdar://problem/46605724>
2889
2890         Reviewed by Alex Christensen.
2891
2892         Add API test coverage.
2893
2894         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2895         (-[DataMappingSchemeHandler setTaskHandler:]):
2896         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
2897         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
2898         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2899         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
2900
2901 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2902
2903         [ews-build] use svn-apply script to apply the patches
2904         https://bugs.webkit.org/show_bug.cgi?id=193138
2905
2906         Reviewed by Lucas Forschler.
2907
2908         * BuildSlaveSupport/ews-build/factories.py:
2909         (Factory.__init__): Add the ApplyPatch step.
2910         * BuildSlaveSupport/ews-build/steps.py:
2911         (CheckOutSource): Added step name.
2912         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
2913         (ApplyPatch): Build step to apply patch using svn-apply script.
2914         (UnApplyPatchIfRequired):
2915         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
2916
2917 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2918
2919         Deprecate WKContextCreate
2920         https://bugs.webkit.org/show_bug.cgi?id=193118
2921
2922         Reviewed by Brady Eidson.
2923
2924         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2925         (WebKitBrowserWindow::WebKitBrowserWindow):
2926         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
2927         (TestWebKitAPI::TEST):
2928         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2929         (TestWebKitAPI::TEST):
2930         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2931         (TestWebKitAPI::TEST):
2932         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
2933         (TestWebKitAPI::TEST):
2934         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
2935         (TestWebKitAPI::TEST):
2936         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2937         (TestWebKitAPI::TEST):
2938         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2939         (TestWebKitAPI::TEST):
2940         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2941         (TestWebKitAPI::TEST):
2942         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2943         (TestWebKitAPI::TEST):
2944         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2945         (TestWebKitAPI::TEST):
2946         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2947         (TestWebKitAPI::TEST):
2948         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2949         (TestWebKitAPI::TEST):
2950         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2951         (TestWebKitAPI::TEST):
2952         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2953         (TestWebKitAPI::TEST):
2954         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2955         (TestWebKitAPI::TEST):
2956         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2957         (TestWebKitAPI::TEST):
2958         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2959         (TestWebKitAPI::TEST):
2960         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2961         (TestWebKitAPI::TEST):
2962         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2963         (TestWebKitAPI::loadAlternateHTMLString):
2964         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2965         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2966         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2967         (TestWebKitAPI::buildAndPerformTest):
2968         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2969         (TestWebKitAPI::TEST):
2970         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
2971         (TestWebKitAPI::TEST):
2972         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
2973         (TestWebKitAPI::TEST):
2974         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2975         (TestWebKitAPI::TEST):
2976         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2977         (TestWebKitAPI::TEST):
2978         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2979         (TestWebKitAPI::TEST):
2980         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2981         (TestWebKitAPI::TEST):
2982         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2983         (TestWebKitAPI::TEST):
2984         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2985         (TestWebKitAPI::TEST):
2986         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2987         (TestWebKitAPI::TEST):
2988         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2989         (TestWebKitAPI::TEST):
2990         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2991         (TestWebKitAPI::TEST):
2992         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2993         (TestWebKitAPI::TEST):
2994         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2995         (TestWebKitAPI::TEST):
2996         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2997         (TestWebKitAPI::TEST):
2998         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2999         (TestWebKitAPI::TEST):
3000         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3001         (TestWebKitAPI::TEST):
3002         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3003         (TestWebKitAPI::TEST):
3004         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3005         (TestWebKitAPI::TEST):
3006         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3007         (TestWebKitAPI::TEST):
3008         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3009         (TestWebKitAPI::TEST):
3010         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3011         (TestWebKitAPI::TEST):
3012         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3013         (TestWebKitAPI::TEST):
3014         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3015         (TestWebKitAPI::TEST):
3016         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3017         (TestWebKitAPI::TEST):
3018         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3019         (TestWebKitAPI::TEST):
3020         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3021         (WebKit2_CommandBackForwardTestWKView::SetUp):
3022         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3023         (TestWebKitAPI::TEST):
3024         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3025         (TestWebKitAPI::TEST):
3026         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3027         (TestWebKitAPI::TEST):
3028         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3029         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3030
3031 2019-01-03  Matt Rajca  <mrajca@apple.com>
3032
3033         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3034         https://bugs.webkit.org/show_bug.cgi?id=193128
3035         rdar://34554231
3036
3037         Reviewed by Jer Noble.
3038
3039         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3040         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3041         event along with a flag that indicates whether or not autoplay was actually prevented.
3042
3043         Tests: existing API tests were updated to reflect the new names. New API tests
3044         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3045
3046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3047         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3048         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3049         (TEST):
3050         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3051         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3052
3053 2019-01-04  Chris Dumez  <cdumez@apple.com>
3054
3055         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3056         https://bugs.webkit.org/show_bug.cgi?id=193120
3057
3058         Reviewed by Alex Christensen.
3059
3060         Add API test coverage.
3061
3062         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3063
3064 2019-01-04  Chris Dumez  <cdumez@apple.com>
3065
3066         Crash under WebProcessPool::addSuspendedPage()
3067         https://bugs.webkit.org/show_bug.cgi?id=193110
3068
3069         Reviewed by Youenn Fablet.
3070
3071         Add API test coverage.
3072
3073         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3074
3075 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3076
3077         [ews-build] Check patch relevance before applying the patch
3078         https://bugs.webkit.org/show_bug.cgi?id=193102
3079
3080         Reviewed by Lucas Forschler.
3081
3082         * BuildSlaveSupport/ews-build/factories.py:
3083         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3084
3085 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3086
3087         [ews-build] Check patch relevance step should print patch id
3088         https://bugs.webkit.org/show_bug.cgi?id=193137
3089
3090         Reviewed by Lucas Forschler.
3091
3092         * BuildSlaveSupport/ews-build/steps.py:
3093         (CheckPatchRelevance.start): Update the status to include patch id.
3094
3095 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3096
3097         webkitpy: Increase simulator teardown timeout
3098         https://bugs.webkit.org/show_bug.cgi?id=193141
3099         <rdar://problem/46174217>
3100
3101         Rubber-stamped by Aakash Jain.
3102
3103         * Scripts/webkitpy/xcode/simulated_device.py:
3104         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3105
3106 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3107
3108         test262-runner misbehaves when test file YAML has a trailing space
3109         https://bugs.webkit.org/show_bug.cgi?id=193053
3110
3111         Reviewed by Yusuke Suzuki.
3112
3113         * Scripts/test262/Runner.pm:
3114         (parseData):
3115         Accept trailing space when parsing a test file's YAML block.
3116
3117 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3118
3119         UserMedia test should use WKPageNavigationClient
3120         https://bugs.webkit.org/show_bug.cgi?id=192913
3121
3122         Reviewed by Youenn Fablet.
3123
3124         The test currently uses the deprecated WKPageLoaderClient. It should use
3125         WKPageNavigationClient instead, which provides the same callback under a similar name.
3126
3127         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3128         (TestWebKitAPI::TEST):
3129
3130 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3131
3132         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3133         https://bugs.webkit.org/show_bug.cgi?id=192944
3134
3135         Reviewed by Tim Horton.
3136
3137         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3138         (TestWebKitAPI::TEST):
3139
3140 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3141
3142         Add support for using the current text selection as the find string on iOS
3143         https://bugs.webkit.org/show_bug.cgi?id=193034
3144         <rdar://problem/45138739>
3145
3146         Reviewed by Tim Horton.
3147
3148         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3149         _setStringForFind) works as expected.
3150
3151         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3152         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3153
3154 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3155
3156         [ews-build] Use git on OpenSource EWS bots
3157         https://bugs.webkit.org/show_bug.cgi?id=193092
3158
3159         Reviewed by Lucas Forschler.
3160
3161         * BuildSlaveSupport/ews-build/steps.py:
3162         (CheckOutSource): Use git instead of svn.
3163         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3164
3165 2019-01-02  Daniel Bates  <dabates@apple.com>
3166
3167         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3168         https://bugs.webkit.org/show_bug.cgi?id=193023
3169
3170         Reviewed by Simon Fraser.
3171
3172         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3173         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3174         enumerator values. We should just remove this code.
3175
3176         * lldb/lldb_webkit.py:
3177         (WTFOptionSetProvider.has_children):
3178         (WTFOptionSetProvider.num_children):
3179         (WTFOptionSetProvider.get_child_index):
3180         (WTFOptionSetProvider.get_child_at_index):
3181
3182 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3183
3184         .ycm_extra_conf.py should handle XXXInlines.h
3185         https://bugs.webkit.org/show_bug.cgi?id=193055
3186
3187         Reviewed by Carlos Garcia Campos.
3188
3189         compile_commands.json database only records flags and options for cpp source files.
3190         So, when we open headers, this database does not have any information for that.
3191         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3192         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3193         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3194         we attempt to find XXX.cpp and use the configuration if it exists.
3195
3196         * gtk/ycm_extra_conf.py:
3197         (getImplementationFilename):
3198         (FlagsForFile):
3199
3200 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3201
3202         Unreviewed. Support PHP 7.3 in Debian.
3203
3204         Add 7.3 to the list of php versions supported in Debian.
3205
3206         * Scripts/webkitpy/port/base.py:
3207         (Port._debian_php_version):
3208
3209 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3210
3211         Resurrect Mac CMake build
3212         https://bugs.webkit.org/show_bug.cgi?id=192658
3213
3214         Reviewed by Yusuke Suzuki.
3215
3216         * DumpRenderTree/PlatformMac.cmake:
3217         * MiniBrowser/mac/CMakeLists.txt:
3218         * TestWebKitAPI/PlatformMac.cmake:
3219
3220 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3221
3222         [Tools] Remove references to Bison and Flex
3223         https://bugs.webkit.org/show_bug.cgi?id=193033
3224
3225         Reviewed by Michael Catanzaro.
3226
3227         The Bison and Flex tools are not needed anymore since r209883.
3228
3229         * CygwinDownloader/cygwin-downloader.py:
3230         * EWSTools/ubuntu-ews-packages:
3231         * Scripts/filter-build-webkit:
3232         (shouldIgnoreLine):
3233         * gtk/install-dependencies:
3234         * wpe/install-dependencies:
3235
3236 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3237
3238         WebDriver: warn about non existing tests when parsing expectations
3239         https://bugs.webkit.org/show_bug.cgi?id=192979
3240
3241         Reviewed by Michael Catanzaro.
3242
3243         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
3244         renamed.
3245
3246         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3247         (WebDriverTestRunner.__init__):
3248
3249 2018-12-21  Chris Dumez  <cdumez@apple.com>
3250
3251         navigator.userAgent in service workers does not reflect customUserAgent set by client
3252         https://bugs.webkit.org/show_bug.cgi?id=192951
3253
3254         Reviewed by Youenn Fablet.
3255
3256         Extend API test coverage.
3257
3258         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3259         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
3260         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3261         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
3262         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3263
3264 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3265
3266         [WebAuthN] userPresence should always be true
3267         https://bugs.webkit.org/show_bug.cgi?id=192835
3268         <rdar://problem/46538788>
3269
3270         Reviewed by Brent Fulgham.
3271
3272         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3273         (TestWebKitAPI::TEST):
3274
3275 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
3276
3277         Add support to run-benchmark to use non-default copies of the browser apps
3278         https://bugs.webkit.org/show_bug.cgi?id=192905
3279         rdar://problem/46845840
3280
3281         Reviewed by Dewei Zhu.
3282         
3283         Add support for a --browser-path argument to run-benchmark, which allows you to use
3284         a custom app bundle for a given browser (only implemented for Safari at present).
3285
3286         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3287         (BenchmarkRunner.__init__):
3288         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3289         (BrowserDriver.__init__):
3290         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3291         (BrowserDriverFactory.create):
3292         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3293         (OSXBrowserDriver._launch_process):
3294         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
3295         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
3296         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3297         (OSXChromeCanaryDriver.launch_url):
3298         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3299         (OSXFirefoxNightlyDriver.launch_url):
3300         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3301         (OSXSafariDriver.__init__):
3302         (OSXSafariDriver.launch_url):
3303         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3304         (parse_args):
3305         (run_benchmark_plan):
3306         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3307         (WebServerBenchmarkRunner.__init__):
3308         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
3309         (FakeBenchmarkRunner.__init__):
3310
3311 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3312
3313         [WebAuthN] Import an APDU coder from Chromium
3314         https://bugs.webkit.org/show_bug.cgi?id=192949
3315         <rdar://problem/46879933>
3316
3317         Reviewed by Brent Fulgham.
3318
3319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3320         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
3321         (TestWebKitAPI::TEST):
3322
3323 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3324
3325         Setting the file wrapper and content type of an attachment to a PDF should update its image
3326         https://bugs.webkit.org/show_bug.cgi?id=192984
3327         <rdar://problem/46798028>
3328
3329         Reviewed by Tim Horton.
3330
3331         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
3332         PDF data correctly updates the image element.
3333
3334         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3335
3336 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3337
3338         Add JSCOnly to bot dashboard
3339         https://bugs.webkit.org/show_bug.cgi?id=192964
3340
3341         Reviewed by Alexey Proskuryakov.
3342
3343         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
3344         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
3345         useful if they were not so secret, so add them.
3346
3347         There appear to be no build-only bots, so the first column is blank. And of course there are
3348         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
3349         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
3350         and there's plenty of room in the final column for all the bots.
3351
3352         I had a hard time picking a logo to use, because the JavaScript language does not have an
3353         official logo. But I believe I've found one that will be satisfactory.
3354
3355         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
3356
3357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
3358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
3359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3360         (BubbleQueueServer):
3361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3362         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3363         (WebKitBuildbot):
3364         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3365         (table.queue-grid tr.platform.linux-jsconly img.logo):
3366
3367 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
3368
3369         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3370         https://bugs.webkit.org/show_bug.cgi?id=192821
3371
3372         Reviewed by Chris Dumez.
3373
3374         * DumpRenderTree/mac/DumpRenderTree.mm:
3375         (createWebViewAndOffscreenWindow):
3376         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3377
3378 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3379
3380         [Win][Clang] Fix compilation warnings of DumpRenderTree
3381         https://bugs.webkit.org/show_bug.cgi?id=192924
3382
3383         Reviewed by Alex Christensen.
3384
3385         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
3386         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3387         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
3388         * DumpRenderTree/win/DumpRenderTree.cpp:
3389         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
3390         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
3391         object to the argument of setDefaultTextEncodingName instead of a
3392         const string literal.
3393         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
3394         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
3395         (setCacheFolder): Deleted.
3396         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
3397         * DumpRenderTree/win/EditingDelegate.cpp:
3398         (dump): Use %d for int.
3399         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
3400         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3401         (BSTRFromString): Deleted unused function.
3402         * DumpRenderTree/win/TestRunnerWin.cpp:
3403         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
3404         the arguemnt of setQuota instead of const string literal.
3405         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3406         (jsStringRefToWString): Deleted unused function.
3407
3408 2018-12-20  Chris Dumez  <cdumez@apple.com>
3409
3410         Add API test coverage for customUserAgent client setting and service workers
3411         https://bugs.webkit.org/show_bug.cgi?id=192952
3412
3413         Reviewed by Alex Christensen.
3414
3415         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3416         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
3417         (-[SWSchemes webView:startURLSchemeTask:]):
3418         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3419         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3420
3421 2018-12-20  Chris Dumez  <cdumez@apple.com>
3422
3423         Use Optional::hasValue() instead of Optional::has_value()
3424         https://bugs.webkit.org/show_bug.cgi?id=192948
3425
3426         Reviewed by Tim Horton.
3427
3428         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
3429         (TestWebKitAPI::TEST):
3430         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
3431         (TestWebKitAPI::TEST):
3432         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3433         (TestWebKitAPI::TEST_F):
3434
3435 2018-12-20  Chris Dumez  <cdumez@apple.com>
3436
3437         Add style script rule to check for uses of std::optional<>
3438         https://bugs.webkit.org/show_bug.cgi?id=192931
3439
3440         Reviewed by Tim Horton.
3441
3442         * Scripts/webkitpy/style/checkers/cpp.py:
3443         (check_wtf_optional):
3444         (check_style):
3445
3446 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
3447
3448         [WebAuthN] Add a runtime flag for local authenticator
3449         https://bugs.webkit.org/show_bug.cgi?id=192792
3450         <rdar://problem/46798738>
3451
3452         Reviewed by Brent Fulgham.
3453
3454         * DumpRenderTree/TestOptions.cpp:
3455         (TestOptions::TestOptions):
3456         * DumpRenderTree/TestOptions.h:
3457         * DumpRenderTree/mac/DumpRenderTree.mm:
3458         (enableExperimentalFeatures):
3459         (setWebPreferencesForTestOptions):
3460         * WebKitTestRunner/TestController.cpp:
3461         (WTR::TestController::resetPreferencesToConsistentValues):
3462         (WTR::updateTestOptionsFromTestHeader):
3463         * WebKitTestRunner/TestOptions.h:
3464         (WTR::TestOptions::hasSameInitializationOptions const):
3465
3466 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
3467
3468         webkitpy: Autoinstall package URLs have changed
3469         https://bugs.webkit.org/show_bug.cgi?id=192909
3470         <rdar://problem/46860359>
3471
3472         Rubber-stamped by Alexey Proskuryakov.
3473
3474         PyPi urls have been moved around, we need to update our auto-installed packages.
3475
3476         We should check for Selenium before asking PyPi for the latest version.
3477
3478         * Scripts/webkitpy/thirdparty/__init__.py:
3479         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
3480         (AutoinstallImportHook._install_keyring): Ditto.
3481         (AutoinstallImportHook._install_pep8): Ditto.
3482         (AutoinstallImportHook._install_mozlog): Ditto.
3483         (AutoinstallImportHook._install_mozprocess): Ditto.
3484         (AutoinstallImportHook._install_pytest_timeout): Ditto.
3485         (AutoinstallImportHook._install_pytest): Ditto.
3486         (AutoinstallImportHook._install_pylint): Ditto.
3487         (AutoinstallImportHook._install_buildbot): Ditto.
3488         (AutoinstallImportHook._install_coverage): Ditto.
3489         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
3490         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
3491         for new Selenium if the installed version isn't sufficient.
3492         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
3493
3494 2018-12-20  Chris Dumez  <cdumez@apple.com>
3495
3496         Use Optional::valueOr() instead of Optional::value_or()
3497         https://bugs.webkit.org/show_bug.cgi?id=192933
3498
3499         Reviewed by Geoffrey Garen.
3500
3501         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3502         (TestWebKitAPI::checkURL):
3503         (TestWebKitAPI::checkRelativeURL):
3504         (TestWebKitAPI::checkURLDifferences):
3505         (TestWebKitAPI::checkRelativeURLDifferences):
3506         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
3507         (TestWebKitAPI::checkURL):
3508
3509 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
3510
3511         Unreviewed, rolling out r239417.
3512
3513         Introduced two API test failures on macOS.
3514
3515         Reverted changeset:
3516
3517         "<rdar://problem/46194315> macOS: WebKit1 does not handle
3518         occlusion changes"
3519         https://bugs.webkit.org/show_bug.cgi?id=192821
3520         https://trac.webkit.org/changeset/239417
3521
3522 2018-12-20  Devin Rousso  <drousso@apple.com>
3523
3524         Web Inspector: UIString should take an optional key and description to aid localization
3525         https://bugs.webkit.org/show_bug.cgi?id=153962
3526         <rdar://problem/24542505>
3527
3528         Reviewed by Brian Burg.
3529
3530         * Scripts/extract-localizable-js-strings:
3531
3532 2018-12-20  Tim Horton  <timothy_horton@apple.com>
3533
3534         Unparented WKWebView can't retrieve main resource data for a main frame plugin
3535         https://bugs.webkit.org/show_bug.cgi?id=192923
3536         <rdar://problem/46859068>
3537
3538         Reviewed by Wenson Hsieh.
3539
3540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3541         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
3542         Add a test ensuring that both parented and unparented WKWebViews can
3543         retrieve main resource data when loading a PDF.
3544
3545 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3546
3547         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
3548         https://bugs.webkit.org/show_bug.cgi?id=192852
3549
3550         Reviewed by Michael Catanzaro.
3551
3552         EmojiOne font was replaced by Noto Color Emoji.
3553
3554         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
3555         * gtk/jhbuild.modules:
3556         * wpe/jhbuild.modules:
3557
3558 2018-12-19  Chris Dumez  <cdumez@apple.com>
3559
3560         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
3561         https://bugs.webkit.org/show_bug.cgi?id=192728
3562         <rdar://problem/46746779>
3563
3564         Reviewed by Geoff Garen.
3565
3566         * DumpRenderTree/*:
3567         * MiniBrowser/*:
3568         * TestRunnerShared/*:
3569         * TestWebKitAPI/*:
3570         * WebGPUAPIStructure/*:
3571         * WebKitTestRunner/*:
3572
3573 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
3574
3575         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3576         https://bugs.webkit.org/show_bug.cgi?id=192821
3577
3578         Reviewed by Chris Dumez.
3579
3580         * DumpRenderTree/mac/DumpRenderTree.mm:
3581         (createWebViewAndOffscreenWindow):
3582
3583 2018-12-19  Alex Christensen  <achristensen@webkit.org>
3584
3585         Navigations away from the SafeBrowsing interstitial show a flash of old content
3586         https://bugs.webkit.org/show_bug.cgi?id=192676
3587
3588         Reviewed by Chris Dumez.
3589
3590         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3591         (safeBrowsingView):
3592         (TEST):
3593         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3594
3595 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
3596
3597         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
3598         https://bugs.webkit.org/show_bug.cgi?id=192855
3599
3600         Reviewed by Michael Catanzaro.
3601
3602         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3603         (WTR::TestController::notifyDone): Use the WPE implementation.
3604         (WTR::TestController::platformRunUntil): Use the WPE implementation.
3605         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
3606         (WTR::TestController::platformRunUntil): Honor the condition flag.
3607
3608 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
3609
3610         Allow clients to set the navigator platform
3611         https://bugs.webkit.org/show_bug.cgi?id=192735
3612
3613         Reviewed by Tim Horton.
3614
3615         Add a test for setting a custom navigator platform.
3616
3617         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3618         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3619         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
3620
3621 2018-12-19  Truitt Savell  <tsavell@apple.com>
3622
3623         Unreviewed, rolling out r239358.
3624
3625         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
3626         crash on Debug bots
3627
3628         Reverted changeset:
3629
3630         "Clean up IndexedDB files between tests"
3631         https://bugs.webkit.org/show_bug.cgi?id=192796
3632         https://trac.webkit.org/changeset/239358
3633
3634 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3635
3636         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
3637         https://bugs.webkit.org/show_bug.cgi?id=192842
3638         <rdar://problem/46823586>
3639
3640         Reviewed by Tim Horton.
3641
3642         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
3643         item provider when dragging a rich text selection.
3644
3645         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3646
3647 2018-12-18  David Quesada  <david_quesada@apple.com>
3648
3649         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
3650         https://bugs.webkit.org/show_bug.cgi?id=192810
3651         <rdar://problem/46812536>
3652
3653         Reviewed by Alex Christensen.
3654
3655         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3656         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3657             After releasing our reference to the web view, wait until the next turn of the runloop
3658             before checking that the originatingWebView has been zeroed, since the web view might
3659             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
3660             testing general memory management of WKWebViews, only that _WKDownload does not retain
3661             its web view via the 'originatingWebView' property.
3662
3663 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
3664
3665         Clean up IndexedDB files between tests
3666         https://bugs.webkit.org/show_bug.cgi?id=192796
3667
3668         Reviewed by Geoffrey Garen.
3669
3670         * DumpRenderTree/mac/DumpRenderTree.mm:
3671         (runTest):
3672         * WebKitTestRunner/TestController.cpp:
3673         (WTR::TestController::resetStateToConsistentValues):
3674         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3675         (WTR::RemoveAllIndexedDatabasesCallback):
3676         (WTR::TestController::ClearIndexedDatabases):
3677         * WebKitTestRunner/TestController.h:
3678
3679 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3680
3681         Fix API test introduced in r239339 on iOS.
3682         https://bugs.webkit.org/show_bug.cgi?id=192675
3683
3684         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3685         (TEST):
3686         The iOS implementation of the safe browsing warning is a little different.
3687         It does some element creation when it is added to the window so it knows how big it is.
3688         To test these elements, we need to simulate adding it to the window.
3689         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
3690
3691 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
3692
3693         webkitpy: Ignore device type for test when using --force
3694         https://bugs.webkit.org/show_bug.cgi?id=192786
3695         <rdar://problem/46794894>
3696
3697         Reviewed by Daniel Bates.
3698
3699         It is sometimes the case that a contributor will wish to run a test on a specific device,
3700         despite expectations which indicate a test should not be run on that device.
3701
3702         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3703         (parse_args):
3704         * Scripts/webkitpy/port/device_port.py:
3705         (DevicePort.default_child_processes): Strip device type information when using --force.
3706         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
3707
3708 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3709
3710         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
3711         https://bugs.webkit.org/show_bug.cgi?id=192675
3712
3713         Reviewed by Geoffrey Garen.
3714
3715         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3716         (goBack):
3717         (TEST):
3718         (visitUnsafeSite):
3719         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
3720         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3721
3722 2018-12-18  Chris Dumez  <cdumez@apple.com>
3723
3724         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
3725         https://bugs.webkit.org/show_bug.cgi?id=192772
3726
3727         Reviewed by Antti Koivisto.
3728
3729         Add API test coverage.
3730
3731         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3732
3733 2018-12-18  Philippe Normand  <pnormand@igalia.com>
3734
3735         Unreviewed, JHBuild GTK build fix attempt
3736
3737         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
3738         There's no ninja module either, it should be provided by the
3739         host system.
3740
3741 2018-12-17  Chris Dumez  <cdumez@apple.com>
3742
3743         Allow passing nil as session state to [WKWebView _restoreSessionState:]
3744         https://bugs.webkit.org/show_bug.cgi?id=192789
3745         <rdar://problem/46755277>
3746
3747         Reviewed by Alex Christensen.
3748
3749         Add API test coverage.
3750
3751         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3752         (TEST):
3753
3754 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
3755
3756         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
3757         https://bugs.webkit.org/show_bug.cgi?id=192780
3758         rdar://problem/43394387
3759
3760         Reviewed by Tim Horton.
3761
3762         No need to set "AppleFontSmoothing" defaults for WK2.
3763
3764         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3765         (WTR::InjectedBundle::platformInitialize):
3766
3767 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
3768
3769         webkitpy: Handle case where stdout and stderr don't accept unicode
3770         https://bugs.webkit.org/show_bug.cgi?id=192775
3771         <rdar://problem/46497303>
3772
3773         Reviewed by Stephanie Lewis.
3774
3775         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3776         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
3777         characters with '?'.
3778         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3779         (RegularTest.test_stream_with_encoding):
3780
3781 2018-12-17  Daniel Bates  <dabates@apple.com>
3782
3783         Support concatenating StringView with other string types
3784         https://bugs.webkit.org/show_bug.cgi?id=177566
3785
3786         Reviewed by Darin Adler.
3787
3788         Add some tests to ensure we do not regress the number of allocations needed when performing
3789         string concatenation with string views.
3790
3791         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3792         (TestWebKitAPI::TEST):
3793
3794 2018-12-17  Commit Queue  <commit-queue@webkit.org>
3795
3796         Unreviewed, rolling out r239265 and r239274.
3797         https://bugs.webkit.org/show_bug.cgi?id=192765
3798
3799         unorm_normalize is deprecated, and broke an internal build
3800         (Requested by Truitt on #webkit).
3801
3802         Reverted changesets:
3803
3804         "[GTK][WPE] Need a function to convert internal URI to display
3805         ("pretty") URI"
3806         https://bugs.webkit.org/show_bug.cgi?id=174816
3807         https://trac.webkit.org/changeset/239265
3808
3809         "Fix the Apple Internal Mac build with a newer SDK"
3810         https://trac.webkit.org/changeset/239274
3811
3812 2018-12-17  Daniel Bates  <dabates@apple.com>
3813
3814         Implement UIScriptController::toggleCapsLock() for iOS
3815         https://bugs.webkit.org/show_bug.cgi?id=191815
3816
3817         Reviewed by Andy Estes.
3818
3819         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
3820
3821         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3822         * WebKitTestRunner/TestController.cpp:
3823         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
3824         before running a test. This ensures that the caps lock state does not persist between
3825         tests should a test enable caps lock and not disable it.
3826         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3827         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
3828         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3829         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
3830         create the event. Also substituted NSString* for const String& as the data type for the first
3831         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
3832         below.
3833         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
3834         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
3835
3836 2018-12-17  Daniel Bates  <dabates@apple.com>
3837
3838         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
3839         https://bugs.webkit.org/show_bug.cgi?id=192633
3840
3841         Reviewed by Wenson Hsieh.
3842
3843         Update code to use the modern initializer.
3844
3845         * DumpRenderTree/mac/EventSendingController.mm:
3846         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3847
3848 2018-12-17  Matt Lewis  <jlewis3@apple.com>
3849
3850         Unreviewed, rolling out r239254.
3851
3852         This broke the Windows 10 Debug build
3853
3854         Reverted changeset:
3855
3856         "Replace many uses of String::format with more type-safe
3857         alternatives"
3858         https://bugs.webkit.org/show_bug.cgi?id=192742
3859         https://trac.webkit.org/changeset/239254
3860
3861 2018-12-17  David Kilzer  <ddkilzer@apple.com>
3862
3863         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
3864         <https://webkit.org/b/192751>
3865         <rdar://problem/46771623>
3866
3867         Reviewed by Daniel Bates.
3868
3869         Change loop variables to const references to avoid unnecessary
3870         copies.
3871
3872         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
3873         (-[LocalPasteboard pasteboardItems]):
3874
3875 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
3876
3877         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3878         https://bugs.webkit.org/show_bug.cgi?id=174816
3879
3880         Reviewed by Michael Catanzaro.
3881
3882         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
3883
3884         * TestWebKitAPI/CMakeLists.txt:
3885         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3886         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
3887         (TestWebKitAPI::TEST):
3888         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3889         (testURIForDisplayUnaffected):
3890         (testURIForDisplayAffected):
3891         (beforeAll):
3892         (afterAll):
3893         * TestWebKitAPI/glib/CMakeLists.txt:
3894
3895 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3896
3897         [WPE] Add API to notify about frame displayed view backend callback
3898         https://bugs.webkit.org/show_bug.cgi?id=192224
3899
3900         Reviewed by Michael Catanzaro.
3901
3902         Add a test case to check the new API.
3903
3904         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3905         (testWebViewFrameDisplayed):
3906         (beforeAll):
3907         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
3908
3909 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
3910
3911         Unreviewed build fix after r239253
3912
3913         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
3914
3915 2018-12-15  Darin Adler  <darin@apple.com>
3916
3917         Use warning-ignoring macros more consistently and simply
3918         https://bugs.webkit.org/show_bug.cgi?id=192743
3919
3920         Reviewed by Mark Lam.
3921
3922         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3923         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
3924         * DumpRenderTree/mac/TextInputControllerMac.m:
3925         (-[TextInputController interpretKeyEvents:withSender:]): Use
3926         IGNORE_WARNINGS_BEGIN/END.
3927         * WebKitTestRunner/mac/EventSenderProxy.mm:
3928         (WTR::EventSenderProxy::mouseForceClick): Use
3929         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
3930         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
3931         (WTR::EventSenderProxy::mouseForceDown): Ditto.
3932         (WTR::EventSenderProxy::mouseForceUp): Ditto.
3933         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
3934
3935 2018-12-15  Darin Adler  <darin@apple.com>
3936
3937         Replace many uses of String::format with more type-safe alternatives
3938         https://bugs.webkit.org/show_bug.cgi?id=192742
3939
3940         Reviewed by Mark Lam.
3941
3942         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3943         (WTR::cacheTestRunnerCallback): Use makeString.
3944         * WebKitTestRunner/TestController.cpp:
3945         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3946         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3947
3948 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
3949
3950         [WPE][GTK] Add libpsl to JHBuild module sets
3951         https://bugs.webkit.org/show_bug.cgi?id=192740
3952
3953         Reviewed by Michael Catanzaro.
3954
3955         * gtk/jhbuild.modules: Add libpsl module.
3956         * wpe/jhbuild.modules: Ditto.
3957
3958 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
3959
3960         Add a style checker rule for Xcode version macros use
3961         https://bugs.webkit.org/show_bug.cgi?id=192703
3962
3963         Reviewed by Alex Christensen.
3964
3965         * Scripts/webkitpy/style/checkers/cpp.py:
3966         (check_os_version_checks):
3967         (process_line):
3968         (CppChecker):
3969         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3970         (WebKitStyleTest.test_os_version_checks):
3971
3972 2018-12-14  Chris Dumez  <cdumez@apple.com>
3973
3974         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
3975         https://bugs.webkit.org/show_bug.cgi?id=192704
3976
3977         Reviewed by Geoffrey Garen.
3978
3979         Extend existing API test to reproduce the problem.
3980
3981         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3982
3983 2018-12-14  Chris Dumez  <cdumez@apple.com>
3984
3985         [PSON] WebsitePolicies are lost on process-swap
3986         https://bugs.webkit.org/show_bug.cgi?id=192694
3987         <rdar://problem/46715748>
3988
3989         Reviewed by Brady Eidson.
3990
3991         Extend existing API test to reproduce the issue.
3992
3993         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3994
3995 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
3996
3997         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
3998         https://bugs.webkit.org/show_bug.cgi?id=192678
3999
4000         Reviewed by Carlos Garcia Campos.
4001
4002         Update our ancient versions of libsoup and glib-networking.
4003
4004         * gtk/install-dependencies:
4005         * gtk/jhbuild.modules:
4006         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
4007         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
4008         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
4009         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
4010         * wpe/install-dependencies:
4011         * wpe/jhbuild.modules:
4012         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
4013
4014 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4015
4016         [WPE] Use new view state API from libwpe
4017         https://bugs.webkit.org/show_bug.cgi?id=191906
4018
4019         Reviewed by Žan Doberšek.
4020
4021         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4022         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
4023         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4024         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
4025         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
4026         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4027         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
4028         wpe_view_activity_state_focused state flags.
4029         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
4030         * wpe/backends/HeadlessViewBackend.cpp:
4031         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
4032         * wpe/backends/WindowViewBackend.cpp:
4033         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
4034         received in configure callback.
4035         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
4036
4037 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
4038
4039         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
4040         https://bugs.webkit.org/show_bug.cgi?id=192688
4041
4042         Reviewed by Ross Kirsling.
4043
4044         * win/DLLLauncher/DLLLauncherMain.cpp:
4045         (copyEnvironmentVariable): Moved.
4046         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
4047         (applePathFromRegistry): Ditto.
4048         (appleApplicationSupportDirectory): Ditto.
4049         (prependPath): Ditto.
4050
4051 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
4052
4053         Unreviewed. Changed my status to a reviewer.
4054
4055         * Scripts/webkitpy/common/config/contributors.json:
4056
4057 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4058
4059         [iOS] Support dropping contact card data (public.vcard) in editable content
4060         https://bugs.webkit.org/show_bug.cgi?id=192570
4061         <rdar://problem/35626913>
4062
4063         Reviewed by Tim Horton.
4064
4065         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4066
4067         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
4068         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
4069         additionally inserts a link).
4070
4071         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4072         (TestWebKitAPI::createMapItemForTesting):
4073         (TestWebKitAPI::createContactItemForTesting):
4074
4075         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
4076         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
4077         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
4078         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
4079         files.
4080
4081 2018-12-13  Ross Kirsling  <ross.kirsling@sony.com>
4082
4083         Unreviewed -- update my status to "reviewer".
4084
4085         * Scripts/webkitpy/common/config/contributors.json:
4086
4087 2018-12-13  Youenn Fablet  <youenn@apple.com>
4088
4089         On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
4090         https://bugs.webkit.org/show_bug.cgi?id=192657
4091
4092         Reviewed by Eric Carlson.
4093
4094         Add a test that loads a page registering ondevicechange,
4095         load another page in the same process, closes the first page.
4096         Ensure that the process does not crash in that case.
4097
4098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4099         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4100         (TestWebKitAPI::TEST):
4101         (TestWebKitAPI::didCrashCallback):
4102         * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
4103
4104 2018-12-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4105
4106         [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
4107         https://bugs.webkit.org/show_bug.cgi?id=192643
4108
4109         Reviewed by Philippe Normand.
4110
4111         This problem happens with Arch Linux users which have libfdk-2.0.0
4112         installed (which is anybody with gst-plugins-bad 1.14.4 installed).
4113
4114         The problem has already been solved upstream at
4115         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
4116
4117         Adding patches while this problem is not in a release yet.
4118
4119         * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
4120         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
4121         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
4122
4123 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4124
4125         [FreeType] Add initial implementation of variation fonts
4126         https://bugs.webkit.org/show_bug.cgi?id=192151
4127
4128         Reviewed by Michael Catanzaro.
4129
4130         Add cairo patch to avoid crashes.
4131
4132         * gtk/jhbuild.modules:
4133         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
4134
4135 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
4136
4137         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
4138         https://bugs.webkit.org/show_bug.cgi?id=192618
4139
4140         Reviewed by Alex Christensen.
4141
4142         * DumpRenderTree/win/DRTDataObject.cpp:
4143         * DumpRenderTree/win/DRTDataObject.h:
4144         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
4145         * DumpRenderTree/win/DRTDropSource.h:
4146         * DumpRenderTree/win/EditingDelegate.h:
4147         * DumpRenderTree/win/PolicyDelegate.h:
4148         * DumpRenderTree/win/UIDelegate.h:
4149
4150 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
4151
4152         Make TextInputController.legacyAttributedString take DOM nodes and offsets
4153         https://bugs.webkit.org/show_bug.cgi?id=192653
4154
4155         Reviewed by Wenson Hsieh.
4156
4157         Updated TextInputController.legacyAttributedString to take DOM nodes and offsets instead of
4158         a DOM Range object in preparation to add layout tests for HTMLConverter which crosses
4159         shadow boundaries.
4160
4161         * DumpRenderTree/mac/TextInputControllerMac.m:
4162         (+[TextInputController isSelectorExcludedFromWebScript:]): Updated the selector signature.
4163         (+[TextInputController webScriptNameForSelector:]): Ditto.
4164         (-[TextInputController legacyAttributedString:offset:to:offset:]): Made this function take
4165         start node and offset then end node and offset pairs.
4166
4167 2018-12-12  Alex Christensen  <achristensen@webkit.org>
4168
4169         Implement safe browsing in WebKit on WatchOS
4170         https://bugs.webkit.org/show_bug.cgi?id=192641
4171         <rdar://problem/46376188>
4172
4173         Reviewed by Geoff Garen.
4174
4175         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4176         (-[SafeBrowsingNavigationDelegate _webViewDidShowSafeBrowsingWarning:]):
4177         (safeBrowsingView):
4178         Add a test that the new delegate callback is called.
4179
4180 2018-12-12  Michael Catanzaro  <mcatanzaro@igalia.com>
4181
4182         Unreviewed manual rollout of r239100-r239102 and r239116
4183         https://bugs.webkit.org/show_bug.cgi?id=192151
4184         <rdar://problem/46655586>
4185
4186         * gtk/jhbuild.modules:
4187         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Removed.
4188
4189 2018-12-12  Commit Queue  <commit-queue@webkit.org>
4190
4191         Unreviewed, rolling out r239103.
4192         https://bugs.webkit.org/show_bug.cgi?id=192627
4193
4194         It broke the built because it depends on another patch that
4195         didn't land yet (Requested by KaL on #webkit).
4196
4197         Reverted changeset:
4198
4199         "[WPE] Add API to notify about frame displayed view backend
4200         callback"
4201         https://bugs.webkit.org/show_bug.cgi?id=192224
4202         https://trac.webkit.org/changeset/239103
4203
4204 2018-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
4205
4206         [WPE] Add API to notify about frame displayed view backend callback
4207         https://bugs.webkit.org/show_bug.cgi?id=192224
4208
4209         Reviewed by Michael Catanzaro.
4210
4211         Add a test case to check the new API.
4212
4213         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4214         (testWebViewFrameDisplayed):
4215         (beforeAll):
4216
4217 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4218
4219         [FreeType] Add initial implementation of variation fonts
4220         https://bugs.webkit.org/show_bug.cgi?id=192151
4221
4222         Reviewed by Michael Catanzaro.
4223
4224         Add cairo patch to avoid crashes.
4225
4226         * gtk/jhbuild.modules:
4227         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
4228
4229 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
4230
4231         Implement feature flag for CSS Typed OM
4232         https://bugs.webkit.org/show_bug.cgi?id=192610
4233
4234         Reviewed by Ryosuke Niwa.
4235
4236         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4237
4238 2018-12-11  Chris Dumez  <cdumez@apple.com>
4239
4240         Unreviewed, fix bad check in API test added in r239080.
4241
4242         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4243
4244 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
4245
4246         [Win][Clang] Fix warning -Wmissing-field-initializers
4247         https://bugs.webkit.org/show_bug.cgi?id=192584
4248
4249         Reviewed by Yusuke Suzuki.
4250
4251         Initialize a struct with '{ }' instead of '= {0}'.
4252
4253         * DumpRenderTree/win/DumpRenderTree.cpp:
4254         (runTest):
4255         * DumpRenderTree/win/EventSender.cpp:
4256         (makeMsg):
4257         (replaySavedEvents):
4258         (beginDragWithFilesCallback):
4259         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
4260         (createBitmapContextFromWebView):
4261         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
4262         (updateMenuItemForHistoryItem):
4263         * MiniBrowser/win/WinMain.cpp:
4264         (wWinMain):
4265         * TestWebKitAPI/win/HostWindow.cpp:
4266         (TestWebKitAPI::HostWindow::clientRect const):
4267         (TestWebKitAPI::HostWindow::registerWindowClass):
4268         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
4269         (TestWebKitAPI::PlatformWebView::registerWindowClass):
4270         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4271         (WTR::registerWindowClass):
4272         (WTR::PlatformWebView::windowFrame):
4273         (WTR::PlatformWebView::windowSnapshotImage):
4274
4275 2018-12-11  Chris Dumez  <cdumez@apple.com>
4276
4277         PSON logic gets confused by concurrent decidePolicyForNavigationAction requests
4278         https://bugs.webkit.org/show_bug.cgi?id=192482
4279         <rdar://problem/46470145>
4280
4281         Reviewed by Antti Koivisto.
4282
4283         Add API test coverage.
4284
4285         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4286
4287 2018-12-11  Andy Estes  <aestes@apple.com>
4288
4289         Introduce makeBlockPtr for lambdas
4290         https://bugs.webkit.org/show_bug.cgi?id=192594
4291
4292         Reviewed by Alex Christensen.
4293
4294         Adopted makeBlockPtr and added API tests.
4295
4296         * DumpRenderTree/TestRunner.cpp:
4297         (TestRunner::callUIScriptCallback):
4298         * TestWebKitAPI/Tests/WTF/BlockPtr.mm:
4299         (TestWebKitAPI::TEST):
4300         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4301         (-[DownloadProgressTestRunner init]):