[ews-app] Use Buildbot result code variables
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] Use Buildbot result code variables
4         https://bugs.webkit.org/show_bug.cgi?id=195668
5
6         Reviewed by Alexey Proskuryakov.
7
8         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
9         (Buildbot): Added Buildbot result code variables.
10         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
11         (StatusBubble._build_bubble): Used Buildbot result code variables.
12
13 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
14
15         [Flatpak] Expand submodule recursively
16         https://bugs.webkit.org/show_bug.cgi?id=195672
17
18         Building WPE with flatpak was impossible without that as it was raising an exception.
19         Also update wpebackend-fdo to match what is built in jhbuild
20
21         Reviewed by Philippe Normand.
22
23         * flatpak/flatpakutils.py:
24         (expand_submodules_recurse):
25         (expand_manifest):
26         * flatpak/org.webkit.WPEModules.yaml:
27
28 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
29
30         [ews-app] status bubble should be hidden for certain builds
31         https://bugs.webkit.org/show_bug.cgi?id=194597
32
33         Reviewed by Dewei Zhu.
34
35         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
36         (StatusBubble._build_bubble):
37         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
38         because the patch didn't have relevant changes.
39         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
40         in production yet.
41
42 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
43
44         [Win] Fix a slew of simple clang-cl warnings.
45         https://bugs.webkit.org/show_bug.cgi?id=195652
46
47         Reviewed by Don Olmstead.
48
49         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
50         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
51
52 2019-03-12  Justin Fan  <justin_fan@apple.com>
53
54         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
55         https://bugs.webkit.org/show_bug.cgi?id=195518
56         <rdar://problem/46322356>
57
58         Reviewed by Myles C. Maxfield.
59
60         * DumpRenderTree/DerivedSources-input.xcfilelist:
61         * DumpRenderTree/DerivedSources-output.xcfilelist:
62
63 2019-03-12  Commit Queue  <commit-queue@webkit.org>
64
65         Unreviewed, rolling out r242825.
66         https://bugs.webkit.org/show_bug.cgi?id=195648
67
68         "Broke webkitpy tests with my change to
69         lldb_dump_class_layout.py" (Requested by rmorisset on
70         #webkit).
71
72         Reverted changeset:
73
74         "Alter Tools/Scripts/dump-class-layout to be able to dump all
75         classes with suspicious padding"
76         https://bugs.webkit.org/show_bug.cgi?id=195573
77         https://trac.webkit.org/changeset/242825
78
79 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
80
81         [ews-build] Show status bubbles while the patch is waiting in queue
82         https://bugs.webkit.org/show_bug.cgi?id=195618
83
84         Reviewed by Lucas Forschler.
85
86         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
87         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
88         enabled in initial deployment.
89         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
90         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
91         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
92         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
93         (StatusBubble._build_bubbles_for_patch):
94
95 2019-03-12  Robin Morisset  <rmorisset@apple.com>
96
97         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
98         https://bugs.webkit.org/show_bug.cgi?id=195573
99
100         Reviewed by Simon Fraser.
101
102         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
103
104         * Scripts/dump-class-layout:
105         (main):
106         * lldb/lldb_dump_class_layout.py:
107         (ClassLayout.__init__):
108         (ClassLayout._compute_padding_recursive):
109         (LLDBDebuggerInstance.dump_layout_for_classname):
110         (LLDBDebuggerInstance):
111         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
112         (LLDBDebuggerInstance.layout_for_classname): Deleted.
113
114 2019-03-12  Chris Dumez  <cdumez@apple.com>
115
116         Device Orientation access permission should be denied unless explicitly granted by the client
117         https://bugs.webkit.org/show_bug.cgi?id=195625
118
119         Reviewed by Youenn Fablet.
120
121         add API test coverage.
122
123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
124         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
125         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
126         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
127         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
128         (runDeviceOrientationTest):
129         (TEST):
130         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
131         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
132
133 2019-03-12  Jer Noble  <jer.noble@apple.com>
134
135         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
136         https://bugs.webkit.org/show_bug.cgi?id=195137
137         <rdar://problem/48810307>
138
139         Reviewed by Eric Carlson.
140
141         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
142         (TestWebKitAPI::TEST):
143
144 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
145
146         [ews-build] Change urls from uat to production
147         https://bugs.webkit.org/show_bug.cgi?id=195566
148
149         Reviewed by Lucas Forschler.
150
151         * BuildSlaveSupport/ews-app/ews/config.py:
152         * BuildSlaveSupport/ews-build/events.py:
153         * BuildSlaveSupport/ews-build/steps.py:
154
155 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
156
157         [ews-build] change max_builds for local-worker to 1
158         https://bugs.webkit.org/show_bug.cgi?id=195568
159
160         Reviewed by Lucas Forschler.
161
162         * BuildSlaveSupport/ews-build/loadConfig.py:
163
164 2019-03-12  Tim Horton  <timothy_horton@apple.com>
165
166         Fix the build
167
168         * TestRunnerShared/spi/PencilKitTestSPI.h:
169         * TestWebKitAPI/ios/PencilKitTestSPI.h:
170
171 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
172
173         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
174         https://bugs.webkit.org/show_bug.cgi?id=194131
175
176         Reviewed by Michael Catanzaro.
177
178         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
179         (uriChanged):
180         (testUnfinishedSubresourceLoad):
181         (serverCallback):
182         (beforeAll):
183
184 2019-03-11  Alex Christensen  <achristensen@webkit.org>
185
186         WTF::Expected should use std::addressof instead of operator&
187         https://bugs.webkit.org/show_bug.cgi?id=195604
188
189         Reviewed by Myles Maxfield.
190
191         * TestWebKitAPI/Tests/WTF/Expected.cpp:
192         (TestWebKitAPI::Unique::Unique):
193         (TestWebKitAPI::Unique::operator&):
194         (TestWebKitAPI::TEST):
195
196 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
197
198         Add Optional to Forward.h.
199         https://bugs.webkit.org/show_bug.cgi?id=195586
200
201         Reviewed by Darin Adler.
202
203         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
204         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
205         Remove unnecessary includes from headers.
206
207 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
208
209         Add testing API to hit-test and scroll overflow scrollers
210         https://bugs.webkit.org/show_bug.cgi?id=195278
211
212         Reviewed by Antti Koivisto.
213         
214         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
215         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
216         
217         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
218
219         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
220         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
221         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
222         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
223         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
224         * TestRunnerShared/UIScriptContext/UIScriptController.h:
225         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
226         (WTR::enclosingScrollViewIncludingSelf):
227         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
228
229 2019-03-11  Tim Horton  <timothy_horton@apple.com>
230
231         API test WebKit.RequestTextInputContext fails on iOS
232         https://bugs.webkit.org/show_bug.cgi?id=195585
233
234         Reviewed by Wenson Hsieh and Simon Fraser.
235
236         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
237         (applyStyle):
238         (TEST):
239         Add a viewport, so that the coordinates match up on iOS.
240         Scroll by moving the UIScrollView's contentOffset.
241
242 2019-03-11  Chris Dumez  <cdumez@apple.com>
243
244         Assert in WebPageProxy::suspendCurrentPageIfPossible()
245         https://bugs.webkit.org/show_bug.cgi?id=195506
246         <rdar://problem/48733477>
247
248         Reviewed by Alex Christensen.
249
250         Add API test coverage.
251
252         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
253
254 2019-03-11  Shawn Roberts  <sroberts@apple.com>
255
256         Adding myself to contributors.json
257
258         Unreviewed, addming myself to contributors.json .
259
260         * Scripts/webkitpy/common/config/contributors.json:
261
262 2019-03-11  Alex Christensen  <achristensen@webkit.org>
263
264         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
265         https://bugs.webkit.org/show_bug.cgi?id=195511
266         <rdar://problem/44873269>
267
268         Reviewed by Darin Adler.
269
270         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
271         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
272         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
273         (TEST_F):
274
275 2019-03-11  Chris Dumez  <cdumez@apple.com>
276
277         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
278         https://bugs.webkit.org/show_bug.cgi?id=195561
279
280         Reviewed by Youenn Fablet.
281
282         Make sure the JS in the test requests for permission to receive device orientation events.
283
284         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
285
286 2019-03-11  Youenn Fablet  <youenn@apple.com>
287
288         Allow storage quota increase by default in WTR
289         https://bugs.webkit.org/show_bug.cgi?id=195541
290
291         Reviewed by Geoffrey Garen.
292
293         Allow storage quota increase by default in WTR.
294         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
295         Use this for tests that explicitly need cache increase.
296
297         Instead of increasing quota by 2, make sure the next request is
298         granted by adding all given parameters.
299
300         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
301         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
302         (WTR::TestRunner::setAllowStorageQuotaIncrease):
303         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
304         * WebKitTestRunner/InjectedBundle/TestRunner.h:
305         * WebKitTestRunner/TestController.cpp:
306         (WTR::TestController::setAllowStorageQuotaIncrease):
307         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
308         * WebKitTestRunner/TestController.h:
309         * WebKitTestRunner/TestInvocation.cpp:
310         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
311         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
312         (WTR::TestController::cocoaResetStateToConsistentValues):
313         (WTR::TestController::setAllowStorageQuotaIncrease):
314         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
315         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
316         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
317
318 2019-03-11  Xan Lopez  <xan@igalia.com>
319
320         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
321         https://bugs.webkit.org/show_bug.cgi?id=194147
322
323         Reviewed by Michael Saboff.
324
325         To make --32-bit work correctly on Linux/64bit we need to:
326
327         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
328         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
329         unfortunately CMake only allows us to do this during
330         crosscompilation, which is overkill here.
331         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
332         pkg-config detection module uses the x86 .pc files instead of the
333         x86_64 ones.
334         - Set the -m32 flags for the compiler.
335
336         * Scripts/webkitdirs.pm:
337         (generateBuildSystemFromCMakeProject):
338
339 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
340
341         Add MotionMark-1.1 plan file for run-benchmark script.
342         https://bugs.webkit.org/show_bug.cgi?id=195481
343
344         Rubber-stamped by Darin Adler.
345
346         Run-benchmark script should support MontionMark-1.1.
347
348         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
349
350 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
351
352         [ews-app] Add support for submit-to-ews url
353         https://bugs.webkit.org/show_bug.cgi?id=195477
354
355         Reviewed by Lucas Forschler.
356
357         * BuildSlaveSupport/ews-app/ews/fetcher.py:
358         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
359         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
360         * BuildSlaveSupport/ews-app/ews/urls.py:
361         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
362
363 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
364
365         Unreviewed, rolling out r242688, r242643, r242624.
366
367         Caused multiple layout test failures and crashes on iOS and macOS.
368
369         Reverted changeset:
370
371         "requestAnimationFrame should execute before the next frame"
372         https://bugs.webkit.org/show_bug.cgi?id=177484
373         https://trac.webkit.org/changeset/242624/webkit
374
375         * Tracing/SystemTracePoints.plist:
376
377 2019-03-11  John Wilander  <wilander@apple.com>
378
379         Resource Load Statistics: Make it possible exclude localhost from classification
380         https://bugs.webkit.org/show_bug.cgi?id=195474
381         <rdar://problem/47520577>
382
383         Reviewed by Brent Fulgham.
384
385         This patch allows for localhost to be excluded from classification and
386         treatment as a prevalent resource.
387
388         The WebKit Tools change adds a new function called
389         testRunner.setStatisticsIsRunningTest() which can be used to control this
390         behavior.
391
392         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
393         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
394         (WTR::TestRunner::setStatisticsIsRunningTest):
395         * WebKitTestRunner/InjectedBundle/TestRunner.h:
396         * WebKitTestRunner/TestController.cpp:
397         (WTR::TestController::setStatisticsIsRunningTest):
398         * WebKitTestRunner/TestController.h:
399         * WebKitTestRunner/TestInvocation.cpp:
400         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
401
402 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
403
404         [ews-build] Disable waterfall and console view for ews-build.webkit.org
405         https://bugs.webkit.org/show_bug.cgi?id=195560
406
407         Reviewed by Lucas Forschler.
408
409         * BuildSlaveSupport/ews-build/master.cfg:
410
411 2019-03-11  Alex Christensen  <achristensen@webkit.org>
412
413         Unreviewed, rolling out r242698.
414
415         API test crashes on bots.
416
417         Reverted changeset:
418
419         "Add a WKContentRuleList variant that uses copied memory
420         instead of mmap'd shared memory for class A containerized
421         apps"
422         https://bugs.webkit.org/show_bug.cgi?id=195511
423         https://trac.webkit.org/changeset/242698
424
425 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
426
427         [WPE] Enable web process sandbox
428         https://bugs.webkit.org/show_bug.cgi?id=195169
429
430         Reviewed by Daniel Bates.
431
432         * wpe/install-dependencies:
433         * wpe/jhbuild.modules:
434
435 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
436
437         [ews-app] Use port 17000 for worker communication
438         https://bugs.webkit.org/show_bug.cgi?id=195558
439
440         Reviewed by Lucas Forschler.
441
442         * BuildSlaveSupport/ews-build/master.cfg:
443
444 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
445
446         [ews-build] unit-tests fail when passwords.json is missing
447         https://bugs.webkit.org/show_bug.cgi?id=195557
448
449         Reviewed by Lucas Forschler.
450
451         * BuildSlaveSupport/ews-build/loadConfig.py:
452         (loadBuilderConfig):
453         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
454         (ConfigDotJSONTest.test_configuration):
455         * BuildSlaveSupport/ews-build/master.cfg:
456
457 2019-03-11  Truitt Savell  <tsavell@apple.com>
458
459         Unreviewed, rolling out r242702.
460
461         Broke High Sierra builders.
462
463         Reverted changeset:
464
465         "Add utility function to allow easy reverse range-based
466         iteration of a container"
467         https://bugs.webkit.org/show_bug.cgi?id=195542
468         https://trac.webkit.org/changeset/242702
469
470 2019-03-11  Sam Weinig  <sam@webkit.org>
471
472         Add utility function to allow easy reverse range-based iteration of a container
473         https://bugs.webkit.org/show_bug.cgi?id=195542
474
475         Reviewed by Antti Koivisto.
476
477         * TestWebKitAPI/CMakeLists.txt:
478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
479         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
480         (TestWebKitAPI::TEST):
481         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
482
483 2019-03-10  Alex Christensen  <achristensen@webkit.org>
484
485         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
486         https://bugs.webkit.org/show_bug.cgi?id=195511
487         <rdar://problem/44873269>
488
489         Reviewed by Darin Adler.
490
491         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
492         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
493         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
494         (TEST_F):
495
496 2019-03-10  Tim Horton  <timothy_horton@apple.com>
497
498         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
499         https://bugs.webkit.org/show_bug.cgi?id=195499
500
501         Reviewed by Darin Adler.
502
503         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
504         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
505         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
506         (-[WKWebView synchronouslyFocusTextInputContext:]):
507         (applyStyle):
508         (applyIframe):
509         (TEST):
510         Add some tests for this SPI.
511
512 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
513
514         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
515         https://bugs.webkit.org/show_bug.cgi?id=181151
516
517         Reviewed by Don Olmstead.
518
519         * TestWebKitAPI/CMakeLists.txt:
520         * TestWebKitAPI/PlatformWin.cmake:
521         Enable TestWTF RunLoop tests in all platforms.
522
523         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
524         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
525         (TestWebKitAPI::DerivedOneShotTimer::fired):
526         (TestWebKitAPI::TEST):
527         Only a few platforms support nested RunLoop.
528
529         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
530         (TestWebKitAPI::DerivedRepeatingTimer::fired):
531
532 2019-03-10  David Quesada  <david_quesada@apple.com>
533
534         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
535         https://bugs.webkit.org/show_bug.cgi?id=152480
536
537         Reviewed by Chris Dumez.
538
539         Add a unit test based on Daniel Bates's test case that starts a download, ensures
540         there are no additional references to the process pool besides the one held by
541         the download, waits for the download to finish (in the sense that the
542         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
543         measure, also check that the process pool has been deallocated at the end of the
544         test. The test wouldn't be meaningful if the process pool were still alive.
545
546         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
547         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
548         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
549             The download will be canceled because the delegate does not implement the
550             method to decide the download's destination, so this is where we know the
551             DownloadProxyMap is done with the DownloadProxy.
552         (TEST):
553
554 2019-03-08  Chris Dumez  <cdumez@apple.com>
555
556         Add support for Device Orientation / Motion permission API
557         https://bugs.webkit.org/show_bug.cgi?id=195329
558         <rdar://problem/47645367>
559
560         Reviewed by Geoffrey Garen.
561
562         Add test infrastructure to help test the Device Orientation / Motion permission API.
563
564         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
565         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
566         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
567         * WebKitTestRunner/InjectedBundle/TestRunner.h:
568         * WebKitTestRunner/TestController.cpp:
569         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
570         (WTR::TestController::createWebViewWithOptions):
571         (WTR::TestController::resetStateToConsistentValues):
572         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
573         * WebKitTestRunner/TestController.h:
574         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
575         * WebKitTestRunner/TestInvocation.cpp:
576         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
577
578 2019-03-08  Saam barati  <sbarati@apple.com>
579
580         Add a compare-results script to compare benchmark results
581         https://bugs.webkit.org/show_bug.cgi?id=195486
582         <rdar://problem/48723397>
583
584         Reviewed by Geoffrey Garen.
585
586         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
587         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
588         to extend it to learn about our other benchmarks.
589
590         * Scripts/compare-results: Added.
591         (readJSONFile):
592         (detectJetStream2):
593         (JetStream2Results):
594         (detectSpeedometer2):
595         (Speedometer2Results):
596         (detectPLT5):
597         (PLT5Results):
598         (detectBenchmark):
599         (biggerIsBetter):
600         (ttest):
601         (getOptions):
602         (main):
603
604 2019-03-08  Stephanie Lewis  <slewis@apple.com>
605
606         Ensure old tab state is cleared between iterations of run-benchmark
607         https://bugs.webkit.org/show_bug.cgi?id=195393
608         <rdar://problem/46885583>
609
610         Reviewed by Dewei Zhu.
611
612         a) ensure the default to restore state is not set
613         b) terminate Safari correctly
614         c) Set the system default to ignore Persistent State in Safari
615
616         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
617         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
618         (OSXBrowserDriver.prepare_env): 
619         (OSXBrowserDriver.restore_env):
620         (OSXBrowserDriver.close_browsers):
621         (OSXBrowserDriver._terminate_processes):
622         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
623         (OSXChromeDriver):
624         (OSXChromeCanaryDriver):
625         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
626         (OSXFirefoxDriver):
627         (OSXFirefoxNightlyDriver):
628         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
629         (OSXSafariDriver):
630         (OSXSafariDriver.prepare_env):
631
632 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
633
634         [GTK] Several InputMethodFilter tests are failing
635         https://bugs.webkit.org/show_bug.cgi?id=195408
636
637         Reviewed by Carlos Garcia Campos.
638
639         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
640         Regressed in r241751.
641         Hexadecimal values of keycodes are expressed now in upper letters.
642         Composited characters should be cast to UTF8 strings.
643
644         (TestWebKitAPI::TEST):
645
646 2019-03-07  Tomas Popela  <tpopela@redhat.com>
647
648         [GTK] Make Tools/gtkdoc python3 compatible
649         https://bugs.webkit.org/show_bug.cgi?id=195359
650
651         Reviewed by Carlos Garcia Campos.
652
653         * gtkdoc/generate-gtkdoc:
654         ConfigParser was reworked in Python 3.2 so we have adapt the code to
655         work with Python 2 and 3.
656         (get_gtkdoc_module_paths):
657         The iteritems() was removed in Python 3, so let's use items() that's
658         available in Python 2 and 3.
659         (get_generator_for_config):
660         * gtkdoc/gtkdoc.py:
661         (GTKDoc._run_command):
662         The sys.stdout.write() is expecting str in Python 3 and not bytes
663         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
664         for passing the bytes there.
665
666 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
667
668         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
669         https://bugs.webkit.org/show_bug.cgi?id=195346
670         <rdar://problem/48667048>
671
672         Unreviewed build fix for clang-cl.
673
674         * DumpRenderTree/win/DumpRenderTree.cpp:
675         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
676
677 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
678
679         requestAnimationFrame should execute before the next frame
680         https://bugs.webkit.org/show_bug.cgi?id=177484
681
682         Reviewed by Simon Fraser.
683
684         Add trace points for the page RenderingUpdate.
685
686         * Tracing/SystemTracePoints.plist:
687
688 2019-03-07  Zalan Bujtas  <zalan@apple.com>
689
690         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
691         https://bugs.webkit.org/show_bug.cgi?id=195353
692         <rdar://problem/48626394>
693
694         Reviewed by Simon Fraser.
695
696         * WebKitTestRunner/ios/TestControllerIOS.mm:
697         (WTR::TestController::platformResetPreferencesToConsistentValues):
698
699 2019-03-07  John Wilander  <wilander@apple.com>
700
701         Resource Load Statistics: Make it possible to purge only script-accessible cookies
702         https://bugs.webkit.org/show_bug.cgi?id=195383
703         <rdar://problem/48570136>
704
705         Reviewed by Brent Fulgham.
706
707         This patch adds test infrastructure to purge only script-accessible cookies,
708         including a new testRunner function called statisticsDeleteCookiesForHost().git a
709
710         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
711         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
712         (WTR::TestRunner::statisticsDeleteCookiesForHost):
713         * WebKitTestRunner/InjectedBundle/TestRunner.h:
714         * WebKitTestRunner/TestController.cpp:
715         (WTR::TestController::statisticsDeleteCookiesForHost):
716         * WebKitTestRunner/TestController.h:
717         * WebKitTestRunner/TestInvocation.cpp:
718         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
719
720 2019-03-07  Commit Queue  <commit-queue@webkit.org>
721
722         Unreviewed, rolling out r242354.
723         https://bugs.webkit.org/show_bug.cgi?id=195402
724
725         breaks layout tests in all configurations (Requested by
726         zdobersek on #webkit).
727
728         Reverted changeset:
729
730         "[WPE] Enable web process sandbox"
731         https://bugs.webkit.org/show_bug.cgi?id=195169
732         https://trac.webkit.org/changeset/242354
733
734 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
735
736         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
737         https://bugs.webkit.org/show_bug.cgi?id=195346
738
739         Reviewed by Fujii Hironori.
740
741         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
742         (TestWebKitAPI::TEST):
743         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
744
745         * DumpRenderTree/win/DumpRenderTree.cpp:
746         (findFontFallback):
747         (addFontFallbackIfPresent):
748         (removeFontFallbackIfPresent):
749         (main):
750         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
751         (TestWebKitAPI::Util::moduleDirectory):
752         (TestWebKitAPI::Util::createInjectedBundlePath):
753         Use wchar helpers as needed.
754
755 2019-03-06  Rob Buis  <rbuis@igalia.com>
756
757         Consider supporting the `referrerpolicy` attribute.
758         https://bugs.webkit.org/show_bug.cgi?id=179053
759
760         Reviewed by Darin Adler.
761
762         Add a runtime flag for referrerpolicy attribute.
763
764         * DumpRenderTree/mac/DumpRenderTree.mm:
765         (enableExperimentalFeatures):
766
767 2019-03-05  Daniel Bates  <dabates@apple.com>
768
769         Update expected API test result following r242379
770         (https://bugs.webkit.org/show_bug.cgi?id=195125)
771
772         Update expected x-coordinate of selection rect now that the left padding of
773         a textarea is sized in ems (so dependent on the font size) just like the left
774         padding of a text field.
775
776         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
777         (TestWebKitAPI::TEST):
778
779 2019-03-05  David Quesada  <david_quesada@apple.com>
780
781         [WK2] It should be possible to follow links with 'download' attributes
782         https://bugs.webkit.org/show_bug.cgi?id=195145
783         rdar://problem/48462642
784
785         Reviewed by Alex Christensen.
786
787         Add a unit test to verify that activating links with 'download' attributes now
788         navigates to the linked resource, rather than starts downloading it. Add another
789         to verify that it is still possible to explicitly download the link via the
790         'Download' navigation action policy.
791
792         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
793         (-[DownloadAttributeTestDelegate init]):
794         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
795         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
796         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
797         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
798         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
799         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
800         (TEST):
801         * WebKitTestRunner/TestController.cpp:
802         (WTR::TestController::decidePolicyForNavigationAction):
803         * WebKitTestRunner/TestController.h:
804
805 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
806
807         [Curl] Implement Cookie Accept Policy.
808         https://bugs.webkit.org/show_bug.cgi?id=191645
809
810         Reviewed by Fujii Hironori.
811
812         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
813         (TestWebKitAPI::Curl::TEST_F):
814
815 2019-03-05  Youenn Fablet  <youenn@apple.com>
816
817         Rename requestCacheStorageSpace to requestStorageSpace
818         https://bugs.webkit.org/show_bug.cgi?id=195282
819
820         Reviewed by Chris Dumez.
821
822         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
823         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
824         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
825
826 2019-03-05  Brady Eidson  <beidson@apple.com>
827
828         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
829         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
830
831         Reviewed by Tim Horton.
832
833         Loading a file: URL into a WKWebView and then loading another file: url from a completely
834         different directory into that same WKWebView should work.
835
836         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
837         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
838
839 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
840
841         Add WeakHashSet
842         https://bugs.webkit.org/show_bug.cgi?id=195152
843
844         Reviewed by Antti Koivisto.
845
846         Added tests for WeakHashSet.
847
848         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
849         (TestWebKitAPI::Base::Base): Moved.
850         (TestWebKitAPI::Derived::foo): Moved.
851         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
852         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
853         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
854         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
855
856 2019-03-04  Chris Dumez  <cdumez@apple.com>
857
858         Do not share WebProcesses between private and regular sessions
859         https://bugs.webkit.org/show_bug.cgi?id=195189
860         <rdar://problem/48421064>
861
862         Reviewed by Alex Christensen.
863
864         Add API test coverage.
865
866         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
867         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
868
869 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
870
871         [WPE] Enable web process sandbox
872         https://bugs.webkit.org/show_bug.cgi?id=195169
873
874         Reviewed by Daniel Bates.
875
876         * wpe/install-dependencies:
877         * wpe/jhbuild.modules:
878
879 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
880
881         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
882         https://bugs.webkit.org/show_bug.cgi?id=195206
883
884         Reviewed by Žan Doberšek.
885
886         Add a new test case.
887
888         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
889         (testJSCClass):
890
891 2019-03-04  Charlie Turner  <cturner@igalia.com>
892
893         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
894         https://bugs.webkit.org/show_bug.cgi?id=194898
895
896         Reviewed by Žan Doberšek.
897
898         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
899         a GCC extension that permits arithmetic on void* pointer. Inline
900         the macro until this issue is fixed upstream.
901
902 2019-03-03  Tim Horton  <timothy_horton@apple.com>
903
904         Rid the world of WK_API_ENABLED
905         https://bugs.webkit.org/show_bug.cgi?id=195263
906
907         Reviewed by Dan Bernstein.
908
909         List of changed files elided because it's useless.
910
911 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
912
913         Unreviewed follow-up to r242292.
914
915         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
916
917         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
918         (TestWebKitAPI::testStrip): Renamed from strip.
919         (TestWebKitAPI::TEST):
920
921 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
922
923         Unreviewed, remove accidentally-committed URLHelpers.cpp test
924
925         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
926         and bug #194272 for details.
927
928         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
929
930 2019-03-03  Tim Horton  <timothy_horton@apple.com>
931
932         Remove some more unused 32-bit code
933         https://bugs.webkit.org/show_bug.cgi?id=195255
934
935         Reviewed by Darin Adler.
936
937         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
938         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
939         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
940         (NPP_New):
941         (NPP_HandleEvent):
942         (handleEventCarbon): Deleted.
943
944 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
945
946         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
947
948         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
949         (TestWebKitAPI::TEST):
950
951 2019-03-01  Darin Adler  <darin@apple.com>
952
953         Finish removing String::format
954         https://bugs.webkit.org/show_bug.cgi?id=194893
955
956         Reviewed by Daniel Bates.
957 '
958         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
959
960 2019-03-01  Alex Christensen  <achristensen@webkit.org>
961
962         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
963         https://bugs.webkit.org/show_bug.cgi?id=195229
964         <rdar://problem/48520362>
965
966         Reviewed by Chris Dumez.
967
968         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
969         (TEST):
970
971 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
972
973         Add a system trace scope for event region building
974         https://bugs.webkit.org/show_bug.cgi?id=195226
975
976         Reviewed by Jon Lee.
977
978         This trace scope measures the time spend converting element rects into Region objects,
979         which can be large on some pages.
980
981         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
982
983         * Tracing/SystemTracePoints.plist:
984
985 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
986
987         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
988         https://bugs.webkit.org/show_bug.cgi?id=194612
989
990         Reviewed by Alex Christensen.
991
992         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
993         Just test the new string-processing function and don't touch the actual environment.
994         (Test cases are all as before, but based on operator== instead of strcmp.)
995
996 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
997
998         [ews-app] Update primary keys for handling multiple Buildbot instances
999         https://bugs.webkit.org/show_bug.cgi?id=195120
1000
1001         Reviewed by Stephanie Lewis.
1002
1003         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
1004         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
1005         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
1006
1007         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
1008         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
1009         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
1010         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
1011         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
1012         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
1013
1014 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
1015
1016         [WinCairo] Enable service worker
1017         https://bugs.webkit.org/show_bug.cgi?id=188318
1018
1019         Reviewed by Youenn Fablet.
1020
1021         * DumpRenderTree/DumpRenderTreePrefix.h:
1022         * TestWebKitAPI/PlatformWin.cmake:
1023         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
1024         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
1025         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1026
1027 2019-03-01  Justin Fan  <justin_fan@apple.com>
1028
1029         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
1030         https://bugs.webkit.org/show_bug.cgi?id=195191
1031
1032         Rubber-stamped by Dean Jackson.
1033
1034         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
1035
1036         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1037
1038 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
1039
1040         Unreviewed, fix lldb webkitpy tests
1041         https://bugs.webkit.org/show_bug.cgi?id=194375
1042
1043         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
1044
1045         * lldb/lldb_webkit.py:
1046         (WTFStringImplProvider.is_8bit):
1047
1048 2019-02-28  David Quesada  <david_quesada@apple.com>
1049
1050         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
1051         https://bugs.webkit.org/show_bug.cgi?id=195121
1052         rdar://problem/48450302
1053
1054         Reviewed by Alex Christensen.
1055
1056         Add API tests for -WKNavigationAction._shouldPerformDownload in various
1057         configurations where the 'download' attribute is absent, blank, or populated
1058         with a filename, and where the anchor element is same-origin or cross-origin
1059         (meaning the 'download' attribute shouldn't be honored).
1060
1061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1062         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
1063         (-[NavigationActionTestDelegate init]):
1064         (-[NavigationActionTestDelegate navigationAction]):
1065         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
1066         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
1067         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1068         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
1069         (TEST):
1070
1071 2019-02-28  Antoine Quint  <graouts@apple.com>
1072
1073         Enable the Pointer Events runtime flag by default
1074         https://bugs.webkit.org/show_bug.cgi?id=195156
1075
1076         Reviewed by Dean Jackson.
1077
1078         * DumpRenderTree/mac/DumpRenderTree.mm:
1079         (enableExperimentalFeatures):
1080
1081 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1082
1083         Several PasteImage API tests are flaky
1084         https://bugs.webkit.org/show_bug.cgi?id=195160
1085
1086         Reviewed by Tim Horton.
1087
1088         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
1089         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
1090         listening for a "load" event after image load is already complete.
1091
1092         To address this, make these tests first register a "load" event handler, then run script to insert an image
1093         element into the document, and finally wait until the load event is observed before checking image size.
1094
1095         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1096
1097 2019-02-28  Chris Dumez  <cdumez@apple.com>
1098
1099         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
1100         https://bugs.webkit.org/show_bug.cgi?id=195107
1101
1102         Reviewed by Alex Christensen.
1103
1104         Give some time for the zoom level to get restored.
1105
1106         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1107
1108 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
1109
1110         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
1111         https://bugs.webkit.org/show_bug.cgi?id=194958
1112
1113         Reviewed by Geoffrey Garen.
1114
1115         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
1116         (TEST):
1117
1118 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
1119
1120         [ews-app] Update method to save build to handle builder_display_name
1121         https://bugs.webkit.org/show_bug.cgi?id=195047
1122
1123         Reviewed by Dewei Zhu.
1124
1125         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
1126         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
1127
1128 2019-02-28  Justin Fan  <justin_fan@apple.com>
1129
1130         [Web GPU] Enable Web GPU only on 64-bit
1131         https://bugs.webkit.org/show_bug.cgi?id=195139
1132
1133         Because Metal is only supported on 64 bit apps.
1134
1135         Unreviewed build fix.
1136
1137         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1138
1139 2019-02-27  Youenn Fablet  <youenn@apple.com>
1140
1141         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
1142         https://bugs.webkit.org/show_bug.cgi?id=194959
1143
1144         Reviewed by Chris Dumez.
1145
1146         Spin loop until getting the condition to remove flakiness.
1147
1148         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1149
1150 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
1151
1152         [ews-build] Buildbot should include builder_display_name in the build events
1153         https://bugs.webkit.org/show_bug.cgi?id=195045
1154
1155         Reviewed by Dewei Zhu.
1156
1157         * BuildSlaveSupport/ews-build/events.py:
1158         (Events.buildStarted): Included builder_display_name in event data. Also renamed
1159         buildername to builder_name to be consistent in naming style.
1160         (Events.buildFinished): Ditto.
1161
1162 2019-02-27  Chris Dumez  <cdumez@apple.com>
1163
1164         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
1165         https://bugs.webkit.org/show_bug.cgi?id=194480
1166
1167         Reviewed by Brady Eidson.
1168
1169         Update existing API test to make it more likely to reproduce the issue.
1170
1171         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1172
1173 2019-02-27  Brady Eidson  <beidson@apple.com>
1174
1175         Universal links from Google search results pages don't open the app.
1176         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
1177
1178         Reviewed by Geoffrey Garen.
1179
1180         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1181         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1182         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1183         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1184
1185 2019-02-27  Chris Dumez  <cdumez@apple.com>
1186
1187         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
1188         https://bugs.webkit.org/show_bug.cgi?id=195102
1189
1190         Reviewed by Geoffrey Garen.
1191
1192         If the number of processes is not yet what we expect, wait a bit and check again to give
1193         processes some time to exit.
1194
1195         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1196
1197 2019-02-27  Chris Dumez  <cdumez@apple.com>
1198
1199         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
1200         https://bugs.webkit.org/show_bug.cgi?id=194545
1201
1202         Reviewed by Brady Eidson.
1203
1204         Make sure the test navigates forward and then back only once. Previously, navigating
1205         back would trigger a navigation again in a timer.
1206
1207         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1208
1209 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
1210
1211         High Sierra Debug JSC test queue should use faster hardware
1212         https://bugs.webkit.org/show_bug.cgi?id=194603
1213
1214         Rubber-stamped by Alexey Proskuryakov.
1215
1216         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
1217
1218         * BuildSlaveSupport/build.webkit.org-config/config.json:
1219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1220         (BubbleQueueServer):
1221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1222         (WebKitBuildbot):
1223         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1224         * QueueStatusServer/config/queues.py:
1225         * Scripts/webkitpy/common/config/ews.json:
1226         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1227         (test_ews_name):
1228
1229 2019-02-27  John Wilander  <wilander@apple.com>
1230
1231         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
1232         https://bugs.webkit.org/show_bug.cgi?id=195071
1233         <rdar://problem/48417690>
1234
1235         Reviewed by Alex Christensen and Brent Fulgham.
1236
1237         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1238         (TestWebKitAPI::createURL):
1239             Convenience function.
1240         (TestWebKitAPI::TEST):
1241             WebCore::AdClickAttribution now takes a URL when creating Source and
1242             Destination.
1243         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1244         (TestWebKitAPI::TEST):
1245             WebCore::AdClickAttribution now takes a URL when creating Source and
1246             Destination.
1247
1248 2019-02-27  Antoine Quint  <graouts@apple.com>
1249
1250         Support Pointer Events on macOS
1251         https://bugs.webkit.org/show_bug.cgi?id=195008
1252         <rdar://problem/47454419>
1253
1254         Reviewed by Dean Jackson.
1255
1256         * DumpRenderTree/mac/DumpRenderTree.mm:
1257         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
1258         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1259
1260 2019-02-26  Mark Lam  <mark.lam@apple.com>
1261
1262         Remove remaining poisoning code.
1263         https://bugs.webkit.org/show_bug.cgi?id=194138
1264
1265         Reviewed by Saam Barati.
1266
1267         * TestWebKitAPI/CMakeLists.txt:
1268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1269         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
1270         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
1271         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
1272         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
1273         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
1274         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
1275
1276 2019-02-26  Alex Christensen  <achristensen@webkit.org>
1277
1278         Move ephemeral local storage from WebProcess to UIProcess
1279         https://bugs.webkit.org/show_bug.cgi?id=195074
1280         <rdar://problem/47937975>
1281
1282         Reviewed by Geoff Garen.
1283
1284         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1285
1286 2019-02-20  Jer Noble  <jer.noble@apple.com>
1287
1288         [Cocoa] Media elements will restart network buffering just before suspending
1289         https://bugs.webkit.org/show_bug.cgi?id=193691
1290
1291         Reviewed by Eric Carlson.
1292
1293         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1294         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1295         (TEST):
1296
1297 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
1298
1299         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
1300         https://bugs.webkit.org/show_bug.cgi?id=191652
1301
1302         Reviewed by Alex Christensen.
1303
1304         Fix WinCairo MiniBrowser behavior of authentication dialog.
1305
1306         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1307         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1308
1309 2019-02-26  Youenn Fablet  <youenn@apple.com>
1310
1311         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
1312         https://bugs.webkit.org/show_bug.cgi?id=195028
1313         <rdar://problem/48243733>
1314
1315         Reviewed by Eric Carlson.
1316
1317         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1318
1319 2019-02-26  Philippe Normand  <pnormand@igalia.com>
1320
1321         [WPE] Add API for webview background color configuration
1322         https://bugs.webkit.org/show_bug.cgi?id=192305
1323
1324         Reviewed by Michael Catanzaro.
1325
1326         * MiniBrowser/wpe/main.cpp:
1327         (main): Add a new option to configure the webview background
1328         color. Example: --bg-color=transparent.
1329         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1330         (testWebViewBackgroundColor): Enable background color API tests for WPE.
1331         (beforeAll): Ditto.
1332
1333 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
1334
1335         scalableNativeWebpageParameters() is not preserved on new page navigation.
1336         https://bugs.webkit.org/show_bug.cgi?id=194892
1337         <rdar://problem/47538280>
1338
1339         Reviewed by Wenson Hsieh.
1340         
1341         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
1342
1343         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1344         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1345         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1346         (WTR::UIScriptController::allowsViewportShrinkToFit):
1347         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1348         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1349         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1350         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1351         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1352         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1353
1354 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1355
1356         [ews-app] Add model for handling multiple Buildbot instances
1357         https://bugs.webkit.org/show_bug.cgi?id=194863
1358
1359         Reviewed by Stephanie Lewis.
1360
1361         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
1362
1363 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1364
1365         [ews-app] Remove BuilderMapping table
1366         https://bugs.webkit.org/show_bug.cgi?id=194961
1367
1368         Reviewed by Stephanie Lewis.
1369
1370         Store builder name directly in build table, instead of having a separate
1371         table for it.
1372
1373         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1374         * BuildSlaveSupport/ews-app/ews/models/build.py:
1375         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
1376         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1377
1378 2019-02-25  John Wilander  <wilander@apple.com>
1379
1380         Introduce and adopt new class RegistrableDomain for eTLD+1
1381         https://bugs.webkit.org/show_bug.cgi?id=194791
1382         <rdar://problem/48179240>
1383
1384         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
1385
1386         This patch adds an API test and replaces two instances of
1387         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
1388
1389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1390         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1391         (TestWebKitAPI::TEST):
1392             Changed two strings to make sure the registrable domains are still considered
1393             invalid and pass the test.
1394         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
1395         (TestWebKitAPI::TEST):
1396         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1397         (WTR::InjectedBundle::didReceiveMessageToPage):
1398
1399 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
1400
1401         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
1402         https://bugs.webkit.org/show_bug.cgi?id=195001
1403
1404         Reviewed by Carlos Garcia Campos.
1405
1406         API version 1.0 always includes the functionality previously guarded with
1407         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
1408         unconditionally.
1409
1410         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1411         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
1412         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
1413         (WebViewTest::showInWindow): Ditto.
1414         (WebViewTest::hideView): Ditto.
1415         * wpe/backends/HeadlessViewBackend.cpp:
1416         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
1417         * wpe/backends/ViewBackend.cpp:
1418         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
1419         * wpe/backends/WindowViewBackend.cpp:
1420         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
1421         WPE_BACKEND_CHECK_VERSION().
1422         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
1423
1424 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
1425
1426         [Flatpak] Add support for flatpak > 1.1.2
1427         https://bugs.webkit.org/show_bug.cgi?id=194088
1428
1429         Flatpak 1.2 is now out so we need to support that
1430         version now.
1431
1432         Reviewed by Michael Catanzaro.
1433
1434         * flatpak/flatpakutils.py:
1435         (check_flatpak):
1436         (FlatpakPackages.__init__):
1437         (FlatpakPackages.__detect_packages):
1438         (FlatpakPackages.__detect_packages.in):
1439         (FlatpakRepos.update):
1440
1441 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
1442
1443         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
1444         https://bugs.webkit.org/show_bug.cgi?id=194998
1445
1446         Reviewed by Carlos Garcia Campos.
1447
1448         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
1449         to a Git checkout and using the latest commit containing various fixes
1450         and improvements.
1451
1452 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1453
1454         [WPE][GTK] Remove user agent quirk for washingtonpost.com
1455         https://bugs.webkit.org/show_bug.cgi?id=194981
1456
1457         Reviewed by Žan Doberšek.
1458
1459         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1460         (TestWebKitAPI::TEST):
1461
1462 2019-02-23  Keith Miller  <keith_miller@apple.com>
1463
1464         Add new mac target numbers
1465         https://bugs.webkit.org/show_bug.cgi?id=194955
1466
1467         Reviewed by Tim Horton.
1468
1469         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1470         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1471         * MiniBrowser/Configurations/Base.xcconfig:
1472         * TestWebKitAPI/Configurations/Base.xcconfig:
1473         * WebKitTestRunner/Configurations/Base.xcconfig:
1474
1475 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1476
1477         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1478         https://bugs.webkit.org/show_bug.cgi?id=194846
1479
1480         Reviewed by Don Olmstead.
1481
1482         Added _search_paths() and _port_specific_expectations_files() for
1483         WinCairoPort.
1484
1485         * Scripts/webkitpy/port/win.py:
1486         (WinCairoPort.default_baseline_search_path):
1487         (WinCairoPort):
1488         (WinCairoPort._port_specific_expectations_files):
1489         (WinCairoPort._search_paths):
1490
1491 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1492
1493         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1494         https://bugs.webkit.org/show_bug.cgi?id=194963
1495
1496         Reviewed by Dean Jackson.
1497
1498         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1499         Do a `contains` check instead of `equals`, because in debug builds we
1500         put the GraphicsLayer pointer in a prefix.
1501
1502 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1503
1504         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1505         https://bugs.webkit.org/show_bug.cgi?id=194873
1506         <rdar://problem/46701974>
1507
1508         Reviewed by Tim Horton.
1509
1510         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1511
1512         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1513         (WTR::UIScriptController::menuRect const):
1514         (WTR::UIScriptController::isShowingMenu const):
1515         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1516         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1517         (WTR::UIScriptController::menuRect const):
1518
1519         Add a function to query the bounds of the callout menu in content coordinates.
1520
1521         (WTR::UIScriptController::isShowingMenu const):
1522
1523         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1524
1525         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1526         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1527         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1528         (WTR::UIScriptController::rectForMenuAction const):
1529         (WTR::UIScriptController::menuRect const):
1530         (WTR::UIScriptController::isShowingMenu const):
1531         (WTR::findViewInHierarchyOfType): Deleted.
1532
1533 2019-02-22  Chris Dumez  <cdumez@apple.com>
1534
1535         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1536         https://bugs.webkit.org/show_bug.cgi?id=194954
1537         <rdar://problem/48127957>
1538
1539         Reviewed by Alex Christensen.
1540
1541         Add API test coverage.
1542
1543         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1544         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1545         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1546         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1547
1548 2019-02-22  Chris Dumez  <cdumez@apple.com>
1549
1550         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1551         https://bugs.webkit.org/show_bug.cgi?id=194924
1552         <rdar://problem/48216125>
1553
1554         Reviewed by Geoffrey Garen.
1555
1556         Add API test coverage.
1557
1558         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1559
1560 2019-02-22  Chris Dumez  <cdumez@apple.com>
1561
1562         Unreviewed, disable API test added in r241928 on iOS.
1563
1564         The cache is not enabled on devices with less than 3GB of RAM.
1565
1566         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1567
1568 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1569
1570         Hardcode Visual Viewports on everywhere except iOS WK1
1571         https://bugs.webkit.org/show_bug.cgi?id=194928
1572
1573         Reviewed by Zalan Bujtas.
1574
1575         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1576         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1577         set it to false. The setting has shipped for several years and there's no need to turn
1578         it off now.
1579
1580         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1581         Visual Viewports are not enabled.
1582         
1583         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1584         that only runs in WK2
1585
1586         * MiniBrowser/mac/SettingsController.h:
1587         * MiniBrowser/mac/SettingsController.m:
1588         (-[SettingsController init]):
1589         (-[SettingsController _populateMenu]):
1590         (-[SettingsController validateMenuItem:]):
1591         (-[SettingsController visualViewportEnabled]): Deleted.
1592         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1593         * MiniBrowser/mac/WK1BrowserWindowController.m:
1594         (-[WK1BrowserWindowController didChangeSettings]):
1595         * MiniBrowser/mac/WK2BrowserWindowController.m:
1596         (-[WK2BrowserWindowController didChangeSettings]):
1597
1598 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1599
1600         Discard cached processes when clearing website data store
1601         https://bugs.webkit.org/show_bug.cgi?id=194894
1602
1603         Reviewed by Chris Dumez.
1604
1605         Added a test case.
1606
1607         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1608         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1609
1610 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1611
1612         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1613         https://bugs.webkit.org/show_bug.cgi?id=194914
1614         <rdar://problem/47586889>
1615
1616         Reviewed by Geoffrey Garen.
1617
1618         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1619         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1620         (TEST):
1621         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1622
1623 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1624
1625         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1626         <https://webkit.org/b/194761>
1627
1628         Reviewed by Myles Maxfield.
1629
1630         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1631         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1632         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1633         to use ARC-compliant cast.
1634         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1635         ARC-compliant cast.
1636         (WTR::installFakeHelvetica): Log `error` to console if
1637         CTFontManagerRegisterFontsForURL() fails, but only on supported
1638         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1639         Call CFRelease() on `error` to fix the leak.  Update to use
1640         ARC-compliant cast.
1641         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1642         cast.
1643
1644 2019-02-21  Chris Dumez  <cdumez@apple.com>
1645
1646         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1647         https://bugs.webkit.org/show_bug.cgi?id=194481
1648
1649         Reviewed by Alex Christensen.
1650
1651         Give the processes a chance to shutdown and wait until we reached the expected number
1652         of processes.
1653
1654         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1655
1656 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1657
1658         Fix the macOS build
1659
1660         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1661
1662 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1663
1664         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1665
1666         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1667         I am a backwards.
1668
1669 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1670
1671         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1672
1673         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1674         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1675         We could force on UI-side compositing, but I feel like the test might be more
1676         valuable exercising the normal path on each platform (though the original
1677         bug was also UI-side specific). Though we can't validate that the overlay
1678         layer was installed successfully, there are layout tests that do that.
1679
1680 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1681
1682         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1683         https://bugs.webkit.org/show_bug.cgi?id=194845
1684         <rdar://problem/47944579>
1685
1686         Reviewed by Antti Koivisto.
1687
1688         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1689         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1690
1691 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1692
1693         [LFC][Floats] Add support for placing formatting roots in-between floats.
1694         https://bugs.webkit.org/show_bug.cgi?id=194902
1695
1696         Reviewed by Antti Koivisto.
1697
1698         * LayoutReloaded/misc/LFC-passing-tests.txt:
1699
1700 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1701
1702         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1703         https://bugs.webkit.org/show_bug.cgi?id=194901
1704
1705         Unreviewed build fix.
1706
1707         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1708         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1709         WPEBackend-fdo-0.1 as library name.
1710
1711 2019-02-21  Rob Buis  <rbuis@igalia.com>
1712
1713         Update MIME type parser
1714         https://bugs.webkit.org/show_bug.cgi?id=180526
1715
1716         Reviewed by Darin Adler.
1717
1718         Add tests involving leading and trailing whitespace, non-token
1719         characters and quoted strings.
1720
1721         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1722         (TestWebKitAPI::TEST):
1723
1724 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1725
1726         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1727         https://bugs.webkit.org/show_bug.cgi?id=194884
1728
1729         Reviewed by Michael Catanzaro.
1730
1731         * PlatformWin.cmake:
1732
1733 2019-02-20  Chris Dumez  <cdumez@apple.com>
1734
1735         Add API test for <rdar://problem/47471222>
1736         https://bugs.webkit.org/show_bug.cgi?id=194847
1737
1738         Reviewed by Alex Christensen.
1739
1740         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1741
1742 2019-02-20  Chris Dumez  <cdumez@apple.com>
1743
1744         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1745         https://bugs.webkit.org/show_bug.cgi?id=194872
1746         <rdar://problem/47924500>
1747
1748         Reviewed by Alex Christensen.
1749
1750         Add API test coverage.
1751
1752         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1753
1754 2019-02-20  Jer Noble  <jer.noble@apple.com>
1755
1756         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1757         https://bugs.webkit.org/show_bug.cgi?id=191332
1758
1759         Reviewed by Dean Jackson.
1760
1761         * Scripts/git-is-in-range: Added.
1762
1763 2019-02-20  Andy Estes  <aestes@apple.com>
1764
1765         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1766         https://bugs.webkit.org/show_bug.cgi?id=194869
1767
1768         Rubber-stamped by Jer Noble.
1769
1770         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1771         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1772         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1773         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1774         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1775         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1776
1777 2019-02-20  Chris Dumez  <cdumez@apple.com>
1778
1779         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1780         https://bugs.webkit.org/show_bug.cgi?id=194857
1781         <rdar://problem/47759323>
1782
1783         Reviewed by Alex Christensen.
1784
1785         Add API test coverage.
1786
1787         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1788
1789 2019-02-20  Chris Dumez  <cdumez@apple.com>
1790
1791         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1792         https://bugs.webkit.org/show_bug.cgi?id=194829
1793         <rdar://problem/47889906>
1794
1795         Reviewed by Alexey Proskuryakov.
1796
1797         Every time the TestOptions were changing we were creating both a new Web view and
1798         a new WKContext, which would start a new Network process. In most cases, we only
1799         need to contruct a new Web view and we do can keep reusing the same WKContext.
1800         This patch implements this optimization and thus avoids spinning a lot of new
1801         Network processes while running the layout tests.
1802
1803         * WebKitTestRunner/TestController.cpp:
1804         (WTR::TestController::generateContextConfiguration const):
1805         (WTR::TestController::generatePageConfiguration):
1806         (WTR::TestController::createWebViewWithOptions):
1807         (WTR::TestController::resetPreferencesToConsistentValues):
1808         (WTR::updateTestOptionsFromTestHeader):
1809         * WebKitTestRunner/TestController.h:
1810         * WebKitTestRunner/TestOptions.h:
1811         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1812         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1813         (WTR::TestOptions::hasSameInitializationOptions const):
1814         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1815         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1816         (WTR::TestController::platformAddTestOptions const):
1817
1818 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1819
1820         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1821         https://bugs.webkit.org/show_bug.cgi?id=167941
1822
1823         Reviewed by Carlos Garcia Campos.
1824
1825         * MiniBrowser/gtk/main.c:
1826         (filterSavedCallback): Added.
1827         (main): Support loading a JSON rule set file for content filtering.
1828         * MiniBrowser/wpe/main.cpp:
1829         (filterSavedCallback): Added.
1830         (main): Support loading a JSON rule set file for content filtering.
1831         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1832         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1833         (WTF::derefGPtr): Ditto.
1834         (testEmptyStore):
1835         (testSaveInvalidFilter):
1836         (testSaveLoadFilter):
1837         (testSavedFilterIdentifierMatch):
1838         (testRemoveFilter):
1839         (testSaveMultipleFilters):
1840         (testSaveFilterFromFile):
1841         (testFilterPersistence):
1842         (beforeAll):
1843         (afterAll):
1844         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1845         (removeOldInjectedContentAndResetLists): Also reset content filters.
1846         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1847         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1848         the element affected by the style sheet.
1849         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1850         and returns it to be used by tests.
1851         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1852         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1853         (serverCallback): Add support for serving a CSS style sheet for testing.
1854         (beforeAll): Add call to testUserContentManagerContentFilter().
1855         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1856
1857 2019-02-19  Keith Rollin  <krollin@apple.com>
1858
1859         Add timing information to build output
1860         https://bugs.webkit.org/show_bug.cgi?id=194839
1861         <rdar://problem/48219609>
1862
1863         Reviewed by Alexey Proskuryakov.
1864
1865         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1866         emit each project's build time to its output. E.g.,
1867
1868             ** BUILD SUCCEEDED ** [0.132 sec]
1869
1870         * Scripts/webkitdirs.pm:
1871         (XcodeOptions):
1872
1873 2019-02-19  Truitt Savell  <tsavell@apple.com>
1874
1875         Unreviewed, rolling out r241784.
1876
1877         Broke all OpenSource builds.
1878
1879         Reverted changeset:
1880
1881         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1882         instances view"
1883         https://bugs.webkit.org/show_bug.cgi?id=172848
1884         https://trac.webkit.org/changeset/241784
1885
1886 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1887
1888         [LFC][Floats] Remove redundant intersecting logic
1889         https://bugs.webkit.org/show_bug.cgi?id=194804
1890
1891         Reviewed by Antti Koivisto.
1892
1893         * LayoutReloaded/misc/LFC-passing-tests.txt:
1894
1895 2019-02-19  Dean Jackson  <dino@apple.com>
1896
1897         Clean-up output from generate-xcfilelists so it can be filtered
1898         https://bugs.webkit.org/show_bug.cgi?id=194795
1899
1900         Reviewed by Joseph Pecoraro (and Keith Rollin).
1901
1902         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1903         make a slight tweak to filter-build-webkit so such lines are marked
1904         as plain.
1905
1906         * Scripts/filter-build-webkit:
1907         * Scripts/generate-xcfilelists:
1908
1909 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1910
1911         pytest is not correctly auto-installed
1912         https://bugs.webkit.org/show_bug.cgi?id=194707
1913
1914         Reviewed by Carlos Garcia Campos.
1915
1916         * Scripts/webkitpy/thirdparty/__init__.py:
1917         (AutoinstallImportHook._install_pytest):
1918
1919 2019-02-18  Chris Dumez  <cdumez@apple.com>
1920
1921         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1922         https://bugs.webkit.org/show_bug.cgi?id=194797
1923         <rdar://problem/48055151>
1924
1925         Reviewed by Geoffrey Garen.
1926
1927         Add API test coverage.
1928
1929         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1930
1931 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1932
1933         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1934         https://bugs.webkit.org/show_bug.cgi?id=194670
1935         <rdar://problem/39066529>
1936
1937         Reviewed by Tim Horton.
1938
1939         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1940         pasted in an editable area as attachment elements.
1941
1942         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1943         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1944         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1945         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1946         (TestWebKitAPI::TEST):
1947         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1948         (WTR::InjectedBundlePage::InjectedBundlePage):
1949
1950 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1951
1952         Fix API test after r241728
1953        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1954
1955         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1956         (TEST):
1957         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1958
1959 2019-02-18  Daniel Bates  <dabates@apple.com>
1960
1961         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1962         https://bugs.webkit.org/show_bug.cgi?id=192824
1963         <rdar://problem/47100332>
1964
1965         Reviewed by Wenson Hsieh.
1966
1967         Fix a bug where the wrong usage code was used for F13 thru F24.
1968
1969         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1970         (keyCodeForDOMFunctionKey):
1971
1972 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1973
1974         Bytecode cache should a have a boot-specific validation
1975         https://bugs.webkit.org/show_bug.cgi?id=194769
1976         <rdar://problem/48149509>
1977
1978         Reviewed by Keith Miller.
1979
1980         Add test for WTF::bootSessionUUIDString()
1981
1982         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1983         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1984         (TEST):
1985
1986 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1987
1988         Disable safe browsing in WKWebView and remove its WKPreferences API
1989         https://bugs.webkit.org/show_bug.cgi?id=194723
1990         <rdar://problem/48122993>
1991
1992         Reviewed by Geoffrey Garen.
1993
1994         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1995         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1996         (TEST):
1997         (safeBrowsingView):
1998         Make tests use SPI instead of API.
1999
2000 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2001
2002         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
2003         https://bugs.webkit.org/show_bug.cgi?id=194586
2004
2005         Reviewed by Ross Kirsling.
2006
2007         * DumpRenderTree/win/DumpRenderTree.cpp:
2008         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
2009         * Scripts/webkitpy/port/driver.py:
2010         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
2011
2012 2019-02-17  David Kilzer  <ddkilzer@apple.com>
2013
2014         Unreviewed, rolling out r241620.
2015
2016         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
2017         (Requested by ddkilzer on #webkit.)
2018
2019         Reverted changeset:
2020
2021         "[WTF] Add environment variable helpers"
2022         https://bugs.webkit.org/show_bug.cgi?id=192405
2023         https://trac.webkit.org/changeset/241620
2024
2025 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2026
2027         [LFC] RenderImage's default intrinsic size is 0.
2028         https://bugs.webkit.org/show_bug.cgi?id=194745
2029
2030         Reviewed by Antti Koivisto.
2031
2032         * LayoutReloaded/misc/LFC-passing-tests.txt:
2033
2034 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2035
2036         [LFC][BFC] Add support for block replaced intrinsic width.
2037         https://bugs.webkit.org/show_bug.cgi?id=194705
2038
2039         Reviewed by Simon Fraser.
2040
2041         * LayoutReloaded/misc/LFC-passing-tests.txt:
2042
2043 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2044
2045         [LFC] Apply min/max width constraints to preferred width computation
2046         https://bugs.webkit.org/show_bug.cgi?id=194739
2047
2048         Reviewed by Simon Fraser.
2049
2050         * LayoutReloaded/misc/LFC-passing-tests.txt:
2051
2052 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
2053
2054         [WTF] Add environment variable helpers
2055         https://bugs.webkit.org/show_bug.cgi?id=192405
2056
2057         Reviewed by Michael Catanzaro.
2058
2059         * DumpRenderTree/mac/DumpRenderTree.mm:
2060         (libraryPathForDumpRenderTree):
2061         * DumpRenderTree/win/DumpRenderTree.cpp:
2062         (libraryPathForDumpRenderTree):
2063         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2064         (setUpIOSLayoutTestCommunication):
2065         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2066         (beforeAll):
2067         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2068         (main):
2069         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2070         (WebKitTestBus::run):
2071         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2072         (WTR::getOutputDir):
2073         (WTR::initializeFontConfigSetting):
2074         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2075         (WTR::InjectedBundle::platformInitialize):
2076         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2077         (WTR::topLevelPath):
2078         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2079         (WTR::topLevelPath):
2080         (WTR::getOutputDir):
2081         (WTR::activateFonts):
2082         * WebKitTestRunner/TestController.cpp:
2083         (WTR::TestController::libraryPathForTesting):
2084         (WTR::TestController::generateContextConfiguration const):
2085         (WTR::TestController::generatePageConfiguration):
2086         (WTR::TestController::decideDestinationWithSuggestedFilename):
2087         (WTR::TestController::platformAdjustContext):
2088         * WebKitTestRunner/TestController.h:
2089         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2090         (WTR::TestController::cocoaPlatformInitialize):
2091         (WTR::TestController::platformAdjustContext):
2092         * WebKitTestRunner/gtk/main.cpp:
2093         (main):
2094         * WebKitTestRunner/mac/TestControllerMac.mm:
2095         (WTR::TestController::configureContentExtensionForTest):
2096         * WebKitTestRunner/wpe/main.cpp:
2097         (main):
2098         Utilize WTF::Environment where possible.
2099
2100 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2101
2102         [iOS] WKWebView callout bar is missing Change Writing Direction item
2103         https://bugs.webkit.org/show_bug.cgi?id=190015
2104         <rdar://problem/44810366>
2105
2106         Reviewed by Tim Horton.
2107
2108         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
2109         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
2110
2111         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2112         (TestWebKitAPI::TEST):
2113
2114 2019-02-15  Chris Dumez  <cdumez@apple.com>
2115
2116         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
2117         https://bugs.webkit.org/show_bug.cgi?id=194717
2118         <rdar://problem/47884404>
2119
2120         Reviewed by Brady Eidson.
2121
2122         Add API test coverage.
2123
2124         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2125
2126 2019-02-15  Youenn Fablet  <youenn@apple.com>
2127
2128         Make navigator.mediaDevices SecureContext
2129         https://bugs.webkit.org/show_bug.cgi?id=194666
2130
2131         Reviewed by Eric Carlson.
2132
2133         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2134         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2135         (TEST_F):
2136
2137 2019-02-15  Brian Burg  <bburg@apple.com>
2138
2139         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2140         https://bugs.webkit.org/show_bug.cgi?id=194411
2141         <rdar://problem/47787614>
2142
2143         Reviewed by Joseph Pecoraro.
2144
2145         Remove unnecessary soft linking macro usage.
2146
2147         * DumpRenderTree/mac/TestRunnerMac.mm:
2148         (TestRunner::inspectorTestStubURL):
2149         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2150         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2151         (WTR::TestRunner::inspectorTestStubURL):
2152
2153 2019-02-15  Commit Queue  <commit-queue@webkit.org>
2154
2155         Unreviewed, rolling out r241559 and r241566.
2156         https://bugs.webkit.org/show_bug.cgi?id=194710
2157
2158         Causes layout test crashes under GuardMalloc (Requested by
2159         ryanhaddad on #webkit).
2160
2161         Reverted changesets:
2162
2163         "[WTF] Add environment variable helpers"
2164         https://bugs.webkit.org/show_bug.cgi?id=192405
2165         https://trac.webkit.org/changeset/241559
2166
2167         "Unreviewed build fix for WinCairo Debug after r241559."
2168         https://trac.webkit.org/changeset/241566
2169
2170 2019-02-15  Zalan Bujtas  <zalan@apple.com>
2171
2172         [LFC] Out-of-flow box is never a float box
2173         https://bugs.webkit.org/show_bug.cgi?id=194704
2174
2175         Reviewed by Antti Koivisto.
2176
2177         * LayoutReloaded/misc/LFC-passing-tests.txt:
2178
2179 2019-02-10  Darin Adler  <darin@apple.com>
2180
2181         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
2182         https://bugs.webkit.org/show_bug.cgi?id=194487
2183
2184         Reviewed by Daniel Bates.
2185
2186         * DumpRenderTree/win/DumpRenderTree.cpp:
2187         (applicationId): Use makeString instead of String::format.
2188         (main): Ditto.
2189         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2190         (TestWebKitAPI::Util::createURLForResource): Ditto.
2191         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2192         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
2193
2194         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2195         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
2196         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
2197         (WTR::createStringWithAttributes): Use appendLiteral.
2198         (WTR::AccessibilityUIElement::helpText const): Ditto.
2199         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
2200         directly instead of using String::format.
2201         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
2202         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
2203
2204 2019-02-15  Truitt Savell  <tsavell@apple.com>
2205
2206         Unreviewed, rolling out r241564.
2207
2208         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
2209
2210         Reverted changeset:
2211
2212         "[Mac] WebInspectorUI.framework does not need to be soft-
2213         linked anymore"
2214         https://bugs.webkit.org/show_bug.cgi?id=194411
2215         https://trac.webkit.org/changeset/241564
2216
2217 2019-02-15  Saam barati  <sbarati@apple.com>
2218
2219         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
2220         https://bugs.webkit.org/show_bug.cgi?id=194036
2221
2222         Reviewed by Yusuke Suzuki.
2223
2224         * Scripts/run-jsc-stress-tests:
2225
2226 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2227
2228         Fix the build.
2229
2230         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2231         (WTR::UIScriptController::drawSquareInEditableImage):
2232         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2233         (TestWebKitAPI::drawSquareInEditableImage):
2234
2235 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2236
2237         Fix the build.
2238
2239         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2240         (WTR::UIScriptController::drawSquareInEditableImage):
2241         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2242         (TestWebKitAPI::drawSquareInEditableImage):
2243
2244 2019-02-14  Brian Burg  <bburg@apple.com>
2245
2246         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2247         https://bugs.webkit.org/show_bug.cgi?id=194411
2248         <rdar://problem/47787614>
2249
2250         Reviewed by Joseph Pecoraro.
2251
2252         Remove unnecessary soft linking macro usage.
2253
2254         * DumpRenderTree/mac/TestRunnerMac.mm:
2255         (TestRunner::inspectorTestStubURL):
2256         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2257         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2258         (WTR::TestRunner::inspectorTestStubURL):
2259
2260 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2261
2262         [ews-app] status bubble should fetch builder name info from BuilderMapping table
2263         https://bugs.webkit.org/show_bug.cgi?id=194599
2264
2265         Reviewed by Lucas Forschler.
2266
2267         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2268         (StatusBubble._build_bubble):
2269
2270 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2271
2272         [ews-app] Set Foreign Key in Django build model
2273         https://bugs.webkit.org/show_bug.cgi?id=194667
2274
2275         Reviewed by Lucas Forschler.
2276
2277         * BuildSlaveSupport/ews-app/ews/models/build.py:
2278         (Build):
2279
2280 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
2281
2282         [WTF] Add environment variable helpers
2283         https://bugs.webkit.org/show_bug.cgi?id=192405
2284
2285         Reviewed by Michael Catanzaro.
2286
2287         * DumpRenderTree/mac/DumpRenderTree.mm:
2288         (libraryPathForDumpRenderTree):
2289         * DumpRenderTree/win/DumpRenderTree.cpp:
2290         (libraryPathForDumpRenderTree):
2291         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2292         (setUpIOSLayoutTestCommunication):
2293         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2294         (TestWebKitAPI::strip):
2295         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2296         (beforeAll):
2297         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2298         (main):
2299         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2300         (WebKitTestBus::run):
2301         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2302         (WTR::getOutputDir):
2303         (WTR::initializeFontConfigSetting):
2304         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2305         (WTR::InjectedBundle::platformInitialize):
2306         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2307         (WTR::topLevelPath):
2308         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2309         (WTR::topLevelPath):
2310         (WTR::getOutputDir):
2311         (WTR::activateFonts):
2312         * WebKitTestRunner/TestController.cpp:
2313         (WTR::TestController::libraryPathForTesting):
2314         (WTR::TestController::generateContextConfiguration const):
2315         (WTR::TestController::generatePageConfiguration):
2316         (WTR::TestController::decideDestinationWithSuggestedFilename):
2317         (WTR::TestController::platformAdjustContext):
2318         * WebKitTestRunner/TestController.h:
2319         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2320         (WTR::TestController::cocoaPlatformInitialize):
2321         (WTR::TestController::platformAdjustContext):
2322         * WebKitTestRunner/gtk/main.cpp:
2323         (main):
2324         * WebKitTestRunner/mac/TestControllerMac.mm:
2325         (WTR::TestController::configureContentExtensionForTest):
2326         * WebKitTestRunner/wpe/main.cpp:
2327         (main):
2328         Utilize WTF::Environment where possible.
2329
2330 2019-02-14  Chris Dumez  <cdumez@apple.com>
2331
2332         [PSON] Introduce a WebContent Process cache
2333         https://bugs.webkit.org/show_bug.cgi?id=194594
2334         <rdar://problem/46793397>
2335
2336         Reviewed by Geoff Garen.
2337
2338         Update API tests to turn on the WebContent Process cache.
2339
2340         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2341
2342 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
2343
2344         Unreviewed, build fix after r241480
2345
2346         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2347         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2348         (-[DragAndDropSimulator initWithWebView:]):
2349
2350 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
2351
2352         AX: ARIA Reflection was disabled in error
2353         https://bugs.webkit.org/show_bug.cgi?id=194647
2354         <rdar://problem/48068336>
2355
2356         Reviewed by Ryosuke Niwa.
2357
2358         Remove test override now that this feature should be enabled by default.
2359
2360         * WebKitTestRunner/TestController.cpp:
2361         (WTR::TestController::resetPreferencesToConsistentValues):
2362
2363 2019-02-14  Commit Queue  <commit-queue@webkit.org>
2364
2365         Unreviewed, rolling out r241486.
2366         https://bugs.webkit.org/show_bug.cgi?id=194655
2367
2368         causing API failures in builds (Requested by ShawnRoberts on
2369         #webkit).
2370
2371         Reverted changeset:
2372
2373         "[Cocoa] Media elements will restart network buffering just
2374         before suspending"
2375         https://bugs.webkit.org/show_bug.cgi?id=193691
2376         https://trac.webkit.org/changeset/241486
2377
2378 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2379
2380         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
2381         https://bugs.webkit.org/show_bug.cgi?id=194622
2382
2383         Reviewed by Antti Koivisto.
2384
2385         * LayoutReloaded/misc/LFC-passing-tests.txt:
2386
2387 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2388
2389         [LFC] Shrink-to-fit-width should be constrained by min/max width
2390         https://bugs.webkit.org/show_bug.cgi?id=194653
2391
2392         Reviewed by Antti Koivisto.
2393
2394         * LayoutReloaded/misc/LFC-passing-tests.txt:
2395
2396 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2397
2398         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
2399         https://bugs.webkit.org/show_bug.cgi?id=194641
2400
2401         Reviewed by Geoffrey Garen.
2402
2403         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
2404         so that the test would fail without this fix.
2405
2406         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2407         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2408
2409 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2410
2411         [ews-app] Change log level for a log statement
2412
2413         Unreviewed minor fix.
2414
2415         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2416         (Patch.save_patch):
2417
2418 2019-02-13  Jer Noble  <jer.noble@apple.com>
2419
2420         [Cocoa] Media elements will restart network buffering just before suspending
2421         https://bugs.webkit.org/show_bug.cgi?id=193691
2422
2423         Reviewed by Eric Carlson.
2424
2425         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2426         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2427         (TEST):
2428
2429 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2430
2431         [ews-app] Fetch builder id to name mapping
2432         https://bugs.webkit.org/show_bug.cgi?id=194355
2433
2434         Reviewed by Lucas Forschler.
2435
2436         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2437         (Buildbot.get_builder_id_to_name_mapping):
2438         (Buildbot._get_display_name_from_builder_name):
2439
2440 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
2441
2442         Further restricting webarchive loads
2443         https://bugs.webkit.org/show_bug.cgi?id=194567
2444         <rdar://problem/47610130>
2445
2446         Reviewed by Youenn Fablet.
2447
2448         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
2449         navigations on drop.
2450
2451         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2452         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
2453         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
2454         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2455         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2456         (TestWebKitAPI::TEST):
2457         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
2458         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
2459         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
2460         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2461         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2462         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2463         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
2464
2465 2019-02-13  John Wilander  <wilander@apple.com>
2466
2467         Store Ad Click Attribution requests in the network process
2468         https://bugs.webkit.org/show_bug.cgi?id=194510
2469         <rdar://problem/47650118>
2470
2471         Reviewed by Alex Christensen and Daniel Bates.
2472
2473         This patch adds two TestRunner functions:
2474         - dumpAdClickAttribution()
2475         - clearAdClickAttribution()
2476
2477         They call into the network process to dump and clear Ad Click
2478         Attribution state, respectively.
2479
2480         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2481         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2482         (WTR::TestRunner::dumpAdClickAttribution):
2483         (WTR::TestRunner::clearAdClickAttribution):
2484         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2485         * WebKitTestRunner/TestController.cpp:
2486         (WTR::TestController::resetStateToConsistentValues):
2487         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2488         (WTR::adClickAttributionStringResultCallback):
2489         (WTR::TestController::dumpAdClickAttribution):
2490         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2491         (WTR::adClickAttributionVoidCallback):
2492         (WTR::TestController::clearAdClickAttribution):
2493         * WebKitTestRunner/TestController.h:
2494         * WebKitTestRunner/TestInvocation.cpp:
2495         (WTR::TestInvocation::dumpResults):
2496         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2497         (WTR::TestInvocation::dumpAdClickAttribution):
2498         * WebKitTestRunner/TestInvocation.h:
2499
2500 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2501
2502         [ews-app] Generate status-bubble
2503         https://bugs.webkit.org/show_bug.cgi?id=194572
2504
2505         Reviewed by Lucas Forschler.
2506
2507         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2508         (StatusBubble._build_bubble):
2509         (StatusBubble._should_show_bubble_for):
2510         (StatusBubble._build_bubbles_for_patch):
2511
2512 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2513
2514         [ews-app] Add status bubble html template
2515         https://bugs.webkit.org/show_bug.cgi?id=194571
2516
2517         Reviewed by Lucas Forschler.
2518
2519         * BuildSlaveSupport/ews-app/ews/templates: Added.
2520         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2521
2522 2019-02-12  Chris Dumez  <cdumez@apple.com>
2523
2524         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2525         https://bugs.webkit.org/show_bug.cgi?id=194568
2526         <rdar://problem/47944490>
2527
2528         Reviewed by Ryosuke Niwa.
2529
2530         Add API test coverage.
2531
2532         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2533         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2534
2535 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2536
2537         webkitpy: Remove bug_dummy from parsed test expectations
2538         https://bugs.webkit.org/show_bug.cgi?id=194562
2539         <rdar://problem/47853999>
2540
2541         Reviewed by Lucas Forschler.
2542
2543         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2544         (TestExpectationParser):
2545         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2546         skipped tests.
2547         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2548
2549 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2550
2551         [ews-app] Add method to fetch patch
2552         https://bugs.webkit.org/show_bug.cgi?id=194518
2553
2554         Reviewed by Lucas Forschler.
2555
2556         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2557         (Patch.get_patch):
2558
2559 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2560
2561         [LFC] Expand tests coverage (60 new tests -> 860)
2562
2563         Unreviewed test gardening (run-singly, --child-processes=1).
2564
2565         * LayoutReloaded/misc/LFC-passing-tests.txt:
2566
2567 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2568
2569         Allow pages to trigger programmatic paste from script on iOS
2570         https://bugs.webkit.org/show_bug.cgi?id=194271
2571         <rdar://problem/47808810>
2572
2573         Reviewed by Tim Horton.
2574
2575         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2576
2577         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2578         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2579         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2580         (WTR::UIScriptController::rectForMenuAction const):
2581
2582         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2583         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2584         for when the menu is shown or hidden.
2585
2586         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2587         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2588         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2589         (WTR::UIScriptController::setDidShowMenuCallback):
2590         (WTR::UIScriptController::didShowMenuCallback const):
2591         (WTR::UIScriptController::setDidHideMenuCallback):
2592         (WTR::UIScriptController::didHideMenuCallback const):
2593         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2594         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2595         (WTR::UIScriptController::rectForMenuAction const):
2596         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2597         * WebKitTestRunner/TestController.cpp:
2598         (WTR::TestController::resetPreferencesToConsistentValues):
2599         (WTR::updateTestOptionsFromTestHeader):
2600         * WebKitTestRunner/TestOptions.h:
2601
2602         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2603         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2604
2605         (WTR::TestOptions::hasSameInitializationOptions const):
2606         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2607         (WTR::UIScriptController::calendarType const):
2608         (WTR::UIScriptController::platformUndoManager const):
2609         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2610         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2611         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2612         (-[TestRunnerWKWebView dealloc]):
2613         (-[TestRunnerWKWebView _didShowMenu]):
2614         (-[TestRunnerWKWebView _didHideMenu]):
2615
2616         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2617
2618         * WebKitTestRunner/ios/TestControllerIOS.mm:
2619         (WTR::handleMenuWillHideNotification):
2620         (WTR::handleMenuDidHideNotification):
2621         (WTR::TestController::platformInitialize):
2622         (WTR::TestController::platformDestroy):
2623         (WTR::TestController::platformResetStateToConsistentValues):
2624
2625         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2626         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2627
2628         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2629         (WTR::forEachViewInHierarchy):
2630         (WTR::findViewInHierarchyOfType):
2631
2632         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2633         functions that dig through a given view's hierarchy in search of a view of a given class.
2634
2635         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2636         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2637         (WTR::UIScriptController::selectionCaretViewRect const):
2638         (WTR::UIScriptController::selectionRangeViewRects const):
2639         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2640         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2641
2642         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2643
2644         (WTR::UIScriptController::rectForMenuAction const):
2645
2646         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2647         callout bar) whose label matches the given string.
2648
2649         (WTR::UIScriptController::platformContentView const):
2650
2651         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2652         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2653         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2654
2655         (WTR::UIScriptController::platformUndoManager const): Deleted.
2656         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2657         (WTR::UIScriptController::platformContentView const):
2658         (WTR::UIScriptController::platformUndoManager const): Deleted.
2659
2660 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2661
2662         webkitpy: No option to only show unexpected failures in results.html for iPad
2663         https://bugs.webkit.org/show_bug.cgi?id=194554
2664         <rdar://problem/47922442>
2665
2666         Rubber-stamped by Aakash Jain.
2667
2668         Just because a TestExpecations file does not exist for a specific platform does not mean that
2669         TestExpecations are not being used, given that platforms inherit test expectations.
2670
2671         * Scripts/webkitpy/port/base.py:
2672         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2673         * Scripts/webkitpy/port/base_unittest.py:
2674         (PortTest.test_uses_test_expectations_file):
2675
2676 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2677
2678         Remove setDefersLoading infrastructure from WebKit2
2679         https://bugs.webkit.org/show_bug.cgi?id=194506
2680
2681         Reviewed by Brady Eidson.
2682
2683         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2684         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2685         (WTR::TestRunner::setDefersLoading): Deleted.
2686         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2687
2688 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2689
2690         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2691         https://bugs.webkit.org/show_bug.cgi?id=194522
2692         <rdar://problem/47789393>
2693
2694         Reviewed by Chris Dumez.
2695
2696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2697         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2698         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2699         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2700
2701 2019-02-12  Andy Estes  <aestes@apple.com>
2702
2703         [iOSMac] Enable Parental Controls Content Filtering
2704         https://bugs.webkit.org/show_bug.cgi?id=194521
2705         <rdar://39732376>
2706
2707         Reviewed by Tim Horton.
2708
2709         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2710
2711 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2712
2713         [LFC][IFC] Add intrinsic width support for float boxes.
2714         https://bugs.webkit.org/show_bug.cgi?id=194528
2715
2716         Reviewed by Antti Koivisto.
2717
2718         Expand tests coverage (2 new tests -> 800).
2719         (This is the correct test ordering --runs-singly --child-processes=1)
2720
2721         * LayoutReloaded/misc/LFC-passing-tests.txt:
2722
2723 2019-02-12  Rob Buis  <rbuis@igalia.com>
2724
2725         Implement serializing in MIME type parser
2726         https://bugs.webkit.org/show_bug.cgi?id=193909
2727
2728         Reviewed by Darin Adler.
2729
2730         Add various tests involving upper case, non-ASCII, control/null characters,
2731         various HTTP whitespace, single quotes and an unpaired surrogate.
2732
2733         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2734         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2735         (TestWebKitAPI::serializeIfValid):
2736         (TestWebKitAPI::TEST):
2737
2738 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2739
2740         [Cocoa] Ask platform for generic font family mappings
2741         https://bugs.webkit.org/show_bug.cgi?id=187723
2742         <rdar://problem/41892438>
2743
2744         Reviewed by Brent Fulgham.
2745
2746         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2747
2748         * DumpRenderTree/mac/DumpRenderTree.mm:
2749         (allowedFontFamilySet):
2750         * WebKitTestRunner/mac/TestControllerMac.mm:
2751         (WTR::allowedFontFamilySet):
2752
2753 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2754
2755         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2756         https://bugs.webkit.org/show_bug.cgi?id=193622
2757
2758         Reviewed by Michael Catanzaro.
2759
2760         This adds support for loading content extension rule sets from the JSON files which
2761         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2762         of WKTR for this could be removed, but that is left for a follow-up patch with
2763         cleanups.
2764
2765         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2766         * WebKitTestRunner/TestController.cpp:
2767         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2768         avoid having the null-terminator copied into the result.
2769         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2770         part of the preparations to run a test.
2771         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2772         (WTR::contentExtensionStoreCallback): Added.
2773         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2774         used for content extensions test.
2775         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2776         extensions and compiling the JSON rule set for tests involving content extensions.
2777         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2778         testing and disables content extensions.
2779         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2780         resetContentExtensions().
2781         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2782         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2783         configureContentExtensionForTest(), and userContentController().
2784
2785 2019-02-11  Daniel Bates  <dabates@apple.com>
2786
2787         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2788         https://bugs.webkit.org/show_bug.cgi?id=191446
2789         <rdar://problem/45929460>
2790
2791         Reviewed by Tim Horton.
2792
2793         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2794
2795         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2796         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2797         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2798         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2799         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2800         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2801         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2802         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2803         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2804         (WTR::arrayLength):
2805         (WTR::parseModifierArray):
2806         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2807         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2808         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2809         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2810
2811 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2812
2813         Unreviewed, rolling out r241272 and r241276.
2814         https://bugs.webkit.org/show_bug.cgi?id=194514
2815
2816         Broke the Apple Internal build and the fix requires human
2817         intervention :( (Requested by dydz on #webkit).
2818
2819         Reverted changesets:
2820
2821         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2822         https://bugs.webkit.org/show_bug.cgi?id=191446
2823         https://trac.webkit.org/changeset/241272
2824
2825         "Fix internal iOS build after r241272"
2826         https://bugs.webkit.org/show_bug.cgi?id=191446
2827         https://trac.webkit.org/changeset/241276
2828
2829 2019-02-11  Truitt Savell  <tsavell@apple.com>
2830
2831         Unreviewed, rolling out r241269.
2832
2833         Caused 5 layout tests crashes on Mac WK1
2834
2835         Reverted changeset:
2836
2837         "DumpRenderTree should report unknown options"
2838         https://bugs.webkit.org/show_bug.cgi?id=191303
2839         https://trac.webkit.org/changeset/241269
2840
2841 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2842
2843         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2844         https://bugs.webkit.org/show_bug.cgi?id=194313
2845
2846         Reviewed by Tim Horton.
2847
2848         Add a helper to determine whether the web view is presenting modal UI.
2849
2850         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2851         (WTR::UIScriptController::isPresentingModally const):
2852         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2853         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2854         (WTR::UIScriptController::isPresentingModally const):
2855         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2856         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2857         (WTR::UIScriptController::calendarType const): Deleted.
2858         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2859         (WTR::UIScriptController::isPresentingModally const):
2860         (WTR::UIScriptController::calendarType const):
2861         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2862         (WTR::UIScriptController::calendarType const):
2863
2864 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2865
2866         GCHeapInspector: Show the retained sizes in more places
2867         https://bugs.webkit.org/show_bug.cgi?id=194464
2868
2869         Reviewed by Simon Fraser.
2870
2871         * GCHeapInspector/gc-heap-inspector.html:
2872         * GCHeapInspector/script/interface.js:
2873         (HeapInspectorUtils.humanReadableSize):
2874         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2875         (HeapInspectorUtils.spanForNode.span.span):
2876         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2877         (HeapSnapshotInspector.prototype.buildRoots):
2878
2879 2019-02-11  Daniel Bates  <dabates@apple.com>
2880
2881         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2882         https://bugs.webkit.org/show_bug.cgi?id=191446
2883         <rdar://problem/45929460>
2884
2885         Reviewed by Tim Horton.
2886
2887         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2888
2889         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2890         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2891         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2892         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2893         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2894         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2895         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2896         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2897         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2898         (WTR::arrayLength):
2899         (WTR::parseModifierArray):
2900         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2901         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2902         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2903         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2904
2905 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2906
2907         DumpRenderTree should report unknown options
2908         https://bugs.webkit.org/show_bug.cgi?id=191303
2909
2910         Reviewed by Frédéric Wang.
2911
2912         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2913         to report unknown options.
2914         Added and assigned test options which are currently used in tests.
2915
2916         * DumpRenderTree/TestOptions.cpp:
2917         (TestOptions::TestOptions):
2918
2919 2019-02-11  Truitt Savell  <tsavell@apple.com>
2920
2921         Unreviewed, rolling out r241229.
2922
2923         Revision broke internal builds for watchOS.
2924
2925         Reverted changeset:
2926
2927         "[Cocoa] Ask platform for generic font family mappings"
2928         https://bugs.webkit.org/show_bug.cgi?id=187723
2929         https://trac.webkit.org/changeset/241229
2930
2931 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2932
2933         [WinCairo][MiniBrowser] Basic authentication always fails.
2934         https://bugs.webkit.org/show_bug.cgi?id=194496
2935
2936         Reviewed by Don Olmstead.
2937
2938         * MiniBrowser/win/DialogHelper.h:
2939         (Dialog::getText):
2940
2941 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2942
2943         [GStreamer] GstMappedBuffer testsuite build fails
2944         https://bugs.webkit.org/show_bug.cgi?id=194495
2945
2946         Reviewed by Carlos Garcia Campos.
2947
2948         Fix the build by explicitely adding the gstreamer1.0-audio include
2949         directories to the include path.
2950
2951         * TestWebKitAPI/PlatformGTK.cmake:
2952         * TestWebKitAPI/PlatformWPE.cmake:
2953
2954 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2955
2956         [GTK][WPE] Add enable-javascript-markup setting
2957         https://bugs.webkit.org/show_bug.cgi?id=193439
2958
2959         Reviewed by Michael Catanzaro.
2960
2961         Add test cases to check the new setting.
2962
2963         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2964         (testWebKitSettings):
2965         (testWebKitSettingsJavaScriptMarkup):
2966         (beforeAll):
2967
2968 2019-02-10  Darin Adler  <darin@apple.com>
2969
2970         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2971         https://bugs.webkit.org/show_bug.cgi?id=194485
2972
2973         Reviewed by Daniel Bates.
2974
2975         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2976
2977 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2978
2979         Add more tests for clampTo<>()
2980         https://bugs.webkit.org/show_bug.cgi?id=194462
2981
2982         Reviewed by Geoffrey Garen.
2983
2984         Darin suggested to test the very last floating point number
2985         at the boundaries when truncating to integer.
2986         I added test for max/min and max-1/min-1.
2987
2988         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2989         (TestWebKitAPI::TEST):
2990
2991 2019-02-09  Darin Adler  <darin@apple.com>
2992
2993         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2994         https://bugs.webkit.org/show_bug.cgi?id=194021
2995
2996         Reviewed by Geoffrey Garen.
2997
2998         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2999         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
3000         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
3001
3002 2019-02-09  Zalan Bujtas  <zalan@apple.com>
3003
3004         [LFC][IFC] Add intrinsic width support for basic inline containers
3005         https://bugs.webkit.org/show_bug.cgi?id=194473
3006
3007         Reviewed by Antti Koivisto.
3008
3009         Expand tests coverage (11 new tests -> 798)
3010
3011         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
3012
3013 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
3014
3015         Fix MiniBrowser's entitlements
3016         https://bugs.webkit.org/show_bug.cgi?id=192431
3017
3018         Reviewed by Joseph Pecoraro.
3019
3020         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
3021         files, making it impossible to load any extension.
3022
3023         * MiniBrowser/MiniBrowser.entitlements:
3024
3025 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
3026
3027         [Cocoa] Ask platform for generic font family mappings
3028         https://bugs.webkit.org/show_bug.cgi?id=187723
3029         <rdar://problem/41892438>
3030
3031         Reviewed by Brent Fulgham.
3032
3033         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
3034
3035         * DumpRenderTree/mac/DumpRenderTree.mm:
3036         (allowedFontFamilySet):
3037         * WebKitTestRunner/mac/TestControllerMac.mm:
3038         (WTR::allowedFontFamilySet):
3039
3040 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
3041
3042         [GTK] Implement back/forward touchpad gesture
3043         https://bugs.webkit.org/show_bug.cgi?id=193919
3044
3045         Reviewed by Michael Catanzaro.
3046
3047         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3048         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
3049
3050 2019-02-08  Alex Christensen  <achristensen@webkit.org>
3051
3052         Add SPI to use networking daemon instead of XPC service
3053         https://bugs.webkit.org/show_bug.cgi?id=194427
3054
3055         Reviewed by Geoffrey Garen
3056
3057         * MiniBrowser/MiniBrowser.entitlements:
3058
3059 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3060
3061         [ews-build] Ensure that every builder in config.json has short name
3062         https://bugs.webkit.org/show_bug.cgi?id=194461
3063
3064         Reviewed by Lucas Forschler.
3065
3066         * BuildSlaveSupport/ews-build/loadConfig.py:
3067         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
3068
3069 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3070
3071         [ews-build] Add short name to config.json
3072         https://bugs.webkit.org/show_bug.cgi?id=194456
3073
3074         Reviewed by Lucas Forschler.
3075
3076         * BuildSlaveSupport/ews-build/config.json: Added short name.
3077         * BuildSlaveSupport/ews-build/loadConfig.py:
3078         (loadBuilderConfig): Set the short name as the builder description.
3079
3080 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
3081
3082         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
3083         https://bugs.webkit.org/show_bug.cgi?id=194418
3084
3085         Reviewed by Lucas Forschler.
3086
3087         Do not include errors trying when finding crashlogs at the end of
3088         a run-webkit-tests run since we don't process those errors.
3089
3090         * Scripts/webkitpy/port/darwin.py:
3091         (DarwinPort._look_for_all_crash_logs_in_log_dir):
3092         * Scripts/webkitpy/port/ios_device.py:
3093         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
3094         * Scripts/webkitpy/port/watch_device.py:
3095         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
3096
3097 2019-02-08  Beth Dakin  <bdakin@apple.com>
3098
3099         Add afterScreenUpdates to WKSnapshotConfiguration
3100         https://bugs.webkit.org/show_bug.cgi?id=194362
3101         -and corresponding-
3102         <rdar://problem/40655528> Please add an "after screen updates" property to 
3103         WKSnapshotConfiguration (to solve blank snapshots)
3104
3105         Reviewed by Tim Horton.
3106
3107         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
3108         (TEST):
3109
3110 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
3111
3112         clampTo(): do not convert the input to double when dealing with integers
3113         https://bugs.webkit.org/show_bug.cgi?id=194263
3114         <rdar://problem/47692312>
3115
3116         Reviewed by Darin Adler.
3117
3118         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3119         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
3120         (TestWebKitAPI::testClampFloatingPointToInteger):
3121         (TestWebKitAPI::testClampSameSignIntegers):
3122         (TestWebKitAPI::testClampUnsignedToSigned):
3123         (TestWebKitAPI::testClampSignedToUnsigned):
3124
3125 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
3126
3127         webkitpy: Respect --dedicated-simulators flag
3128         https://bugs.webkit.org/show_bug.cgi?id=194416
3129         <rdar://problem/47894722>
3130
3131         Reviewed by Lucas Forschler.
3132
3133         * Scripts/webkitpy/port/device_port.py:
3134         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
3135         available devices can be safely ignored.
3136
3137 2019-02-07  Keith Rollin  <krollin@apple.com>
3138
3139         Remove extra copy of 100x100-red.tga
3140         https://bugs.webkit.org/show_bug.cgi?id=194371
3141         <rdar://problem/47873465>
3142
3143         Reviewed by Said Abou-Hallawa.
3144
3145         In order to help it pass its tests, Bug 194190 added a second copy of
3146         the file 100x100-red.tga. However, it turns out that this additional
3147         file wasn't actually needed, and that that sole previous copy was
3148         sufficient. At the same time, this second copy -- which was copied to
3149         the same location in the build output as the first copy -- now caused
3150         XCBuild to complain because there were two production rules for the
3151         same output file. Address this by removing the newly-added extra copy.
3152
3153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3154         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
3155
3156 2019-02-07  Alex Christensen  <achristensen@webkit.org>
3157
3158         Deprecate WKBundlePageSetDefersLoading
3159         https://bugs.webkit.org/show_bug.cgi?id=191394
3160
3161         Reviewed by Dean Jackson.
3162
3163         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3164         (WTR::TestRunner::setDefersLoading):
3165
3166 2019-02-07  Zalan Bujtas  <zalan@apple.com>
3167
3168         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
3169         https://bugs.webkit.org/show_bug.cgi?id=194391
3170
3171         Reviewed by Antti Koivisto.
3172
3173         * LayoutReloaded/misc/LFC-passing-tests.txt:
3174
3175 2019-02-06  Keith Rollin  <krollin@apple.com>
3176
3177         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
3178         https://bugs.webkit.org/show_bug.cgi?id=193975
3179         <rdar://problem/47643306>
3180
3181         Reviewed by Tim Horton.
3182
3183         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
3184         the Info.plist file into the bundle. This step is not necessary as the
3185         implicit "bundle up all the build products into a framework" build
3186         phase does this already. Having the Copy Bundle Resources phase do
3187         this causes a conflict under XCBuild, which objects to two build
3188         phases producing the same file (Info.plist). Address this by removing
3189         Info.plist from the Copy Bundle Resources phase.
3190
3191         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3192
3193 2019-02-06  Keith Rollin  <krollin@apple.com>
3194
3195         Really enable the automatic checking and regenerations of .xcfilelists during builds
3196         https://bugs.webkit.org/show_bug.cgi?id=194357
3197         <rdar://problem/47861231>
3198
3199         Reviewed by Chris Dumez.
3200
3201         Bug 194124 was supposed to enable the automatic checking and
3202         regenerating of .xcfilelist files during the build. While related
3203         changes were included in that patch, the change to actually enable the
3204         operation somehow was omitted. This patch actually enables the
3205         operation. The check-xcfilelist.sh scripts now check
3206         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
3207         from the checking.
3208
3209         * DumpRenderTree/Scripts/check-xcfilelists.sh:
3210         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
3211
3212 2019-02-06  David Kilzer  <ddkilzer@apple.com>
3213
3214         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
3215         <https://webkit.org/b/194286>
3216         <rdar://problem/47815558>
3217
3218         Reviewed by Alexey Proskuryakov.
3219
3220         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3221         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
3222         WKRetainPtr<> to avoid leaking the WKDataRef.
3223
3224 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3225
3226         Unreviewed, fix a typo
3227
3228         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3229
3230 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
3231
3232         [GTK][WPE] force libpsl build to use ICU in jhbuild
3233         https://bugs.webkit.org/show_bug.cgi?id=194288
3234
3235         Reviewed by Carlos Garcia Campos.
3236
3237         * gtk/jhbuild.modules:
3238         Require ICU for libpsl build in jhbuild, like done in WPE.
3239
3240 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3241
3242         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
3243         https://bugs.webkit.org/show_bug.cgi?id=194209
3244
3245         Reviewed by Carlos Garcia Campos.
3246
3247         Enhance TestCookieManager to ensure this doesn't happen again.
3248
3249         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3250         (testCookieManagerPersistentStorage):
3251         (beforeAll):
3252
3253 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3254
3255         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
3256         https://bugs.webkit.org/show_bug.cgi?id=194324
3257
3258         Reviewed by Andy Estes.
3259
3260         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
3261         part of the name is already implicit, since this is in testing code in TestOptions.
3262
3263         * WebKitTestRunner/TestController.cpp:
3264         (WTR::TestController::generateContextConfiguration const):
3265         (WTR::updateTestOptionsFromTestHeader):
3266         * WebKitTestRunner/TestOptions.h:
3267         (WTR::TestOptions::hasSameInitializationOptions const):
3268
3269 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3270
3271         [ews-build] Allow * as platform for builders and workers
3272         https://bugs.webkit.org/show_bug.cgi?id=188533
3273
3274         Reviewed by Lucas Forschler.
3275
3276         * BuildSlaveSupport/ews-build/loadConfig.py:
3277         (checkWorkersAndBuildersForConsistency):
3278
3279 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3280
3281         [ews-build] Add few bots to config.json
3282         https://bugs.webkit.org/show_bug.cgi?id=194304
3283
3284         Reviewed by Lucas Forschler.
3285
3286         * BuildSlaveSupport/ews-build/config.json:
3287
3288 2019-02-05  Keith Rollin  <krollin@apple.com>
3289
3290         Enable the automatic checking and regenerations of .xcfilelists during builds
3291         https://bugs.webkit.org/show_bug.cgi?id=194124
3292         <rdar://problem/47721277>
3293
3294         Reviewed by Tim Horton.
3295
3296         Bug 193790 add a facility for checking -- during build time -- that
3297         any needed .xcfilelist files are up-to-date and for updating them if
3298         they are not. This facility was initially opt-in by setting
3299         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
3300         the process seemed robust. Its now time to enable this facility and
3301         make it opt-out. If there is a need to disable this facility, set and
3302         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
3303         running `make` or `build-webkit`, or before running Xcode from the
3304         command line.
3305
3306         Additionally, remove the step that generates a list of source files
3307         going into the UnifiedSources build step. It's only necessarily to
3308         specify Sources.txt and SourcesCocoa.txt as inputs.
3309
3310         * Scripts/generate-xcfilelists:
3311
3312 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3313
3314         [GTK][WPE] force libpsl build to use ICU in jhbuild
3315         https://bugs.webkit.org/show_bug.cgi?id=194288
3316
3317         Reviewed by Philippe Normand.
3318
3319         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
3320         This can cause build failures if libidn is detected but libunistring is not available.
3321
3322         Make sure that ICU is used for runtime and builtin PSL data.
3323
3324         * gtk/jhbuild.modules:
3325         * wpe/jhbuild.modules:
3326
3327 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3328
3329         [ews-app] Modified timestamp should be updated on updating data
3330         https://bugs.webkit.org/show_bug.cgi?id=194295
3331
3332         Reviewed by Lucas Forschler.
3333
3334         * BuildSlaveSupport/ews-app/ews/models/build.py:
3335         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3336         * BuildSlaveSupport/ews-app/ews/models/step.py:
3337
3338 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
3339
3340         Unreviewed, rolling out r240742.
3341
3342         Causes crashes on iOS simulator.
3343
3344         Reverted changeset:
3345
3346         "[iOS] Keyups for non-modifier keys identified as "Dead" when
3347         not focused in a content-editable element"
3348         https://bugs.webkit.org/show_bug.cgi?id=192824
3349         https://trac.webkit.org/changeset/240742
3350
3351 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
3352
3353         run-webkit-tests emits message "...running None" when running tests
3354         https://bugs.webkit.org/show_bug.cgi?id=194133
3355         <rdar://problem/47724738>
3356
3357         Reviewed by Lucas Forschler.
3358
3359         * Scripts/webkitpy/xcode/device_type.py:
3360         (DeviceType.__str__): Use both version mapping tables and use just the variant
3361         name if no version name is available.
3362         * Scripts/webkitpy/xcode/device_type_unittest.py:
3363         (DeviceTypeTest):
3364         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
3365         an associated named.
3366
3367 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3368
3369         [WPE] require python3-setuptools for meson build in jhbuild
3370         https://bugs.webkit.org/show_bug.cgi?id=194287
3371
3372         Reviewed by Philippe Normand.
3373
3374         python3-setuptools is needed to build meson in jhbuild.
3375         It is already required by the GTK port.
3376
3377         * wpe/install-dependencies:
3378
3379 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3380
3381         [ews-app] Add method to save BuilderMapping to database
3382         https://bugs.webkit.org/show_bug.cgi?id=194264
3383
3384         Reviewed by Lucas Forschler.
3385
3386         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3387         (BuilderMapping.__str__):
3388         (BuilderMapping):
3389         (BuilderMapping.save_mapping):
3390         (BuilderMapping.update_mapping):
3391         (BuilderMapping.get_existing_mapping):
3392         (BuilderMapping.is_valid_mapping):
3393
3394 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3395
3396         [ews-app] Add timestamp fields for BuilderMappings
3397         https://bugs.webkit.org/show_bug.cgi?id=194266
3398
3399         Reviewed by Lucas Forschler.
3400
3401         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3402         (BuilderMapping):
3403
3404 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
3405
3406         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3407         https://bugs.webkit.org/show_bug.cgi?id=174816
3408
3409         Reviewed by Michael Catanzaro.
3410
3411         Add tests for webkit_uri_for_display().
3412
3413         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3414         (testURIForDisplayUnaffected):
3415         (testURIForDisplayAffected):
3416         (beforeAll):
3417         (afterAll):
3418         * TestWebKitAPI/glib/CMakeLists.txt:
3419
3420 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
3421
3422         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
3423         https://bugs.webkit.org/show_bug.cgi?id=194158
3424         <rdar://problem/47737268>
3425
3426         Rubber-stamped by Aakash Jain.
3427
3428         * Scripts/webkitpy/port/device_port.py:
3429         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
3430
3431 2019-02-04  Said Abou-Hallawa  <said@apple.com>
3432
3433         [CG] Enable setAdditionalSupportedImageTypes for WK1
3434         https://bugs.webkit.org/show_bug.cgi?id=194190
3435
3436         Reviewed by Tim Horton.
3437
3438         Add a test similar to the one under WebKit Cocoa but make it create a
3439         WebView instead of a WKWebView.
3440
3441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3442         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
3443         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
3444         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
3445         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
3446         (TestWebKitAPI::runTest):
3447         (TestWebKitAPI::TEST):
3448
3449 2019-02-04  Zalan Bujtas  <zalan@apple.com>
3450
3451         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
3452         https://bugs.webkit.org/show_bug.cgi?id=194168
3453
3454         Reviewed by Simon Fraser.
3455
3456         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
3457
3458         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3459         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
3460         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
3461         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
3462         (TEST):
3463         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
3464         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
3465
3466 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
3467
3468         REGRESSION (r237269): webkit-patch what-broke is broken 
3469         https://bugs.webkit.org/show_bug.cgi?id=193025
3470
3471         Reviewed by Aakash Jain.
3472
3473         * Scripts/webkitpy/common/host.py:
3474         (Host.buildbot):
3475         (Host.bugzilla): Renamed to 'buildbot'.
3476
3477 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3478
3479         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
3480         https://bugs.webkit.org/show_bug.cgi?id=194207
3481
3482         Reviewed by Tim Horton.
3483
3484         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
3485         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
3486         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
3487         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
3488         start and delete forwards to remove the original attachment.
3489
3490         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3491         (TestWebKitAPI::TEST):
3492
3493 2019-02-04  Youenn Fablet  <youenn@apple.com>
3494
3495         Capture state should be managed consistently when doing process swapping
3496         https://bugs.webkit.org/show_bug.cgi?id=194122
3497         <rdar://problem/47609293>
3498
3499         Reviewed by Eric Carlson.
3500
3501         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3502         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3503         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3504         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
3505         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3506         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3507         (WTR::TestRunner::isDoingMediaCapture const):
3508         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3509         * WebKitTestRunner/TestController.cpp:
3510         (WTR::TestController::isDoingMediaCapture const):
3511         * WebKitTestRunner/TestController.h:
3512         * WebKitTestRunner/TestInvocation.cpp:
3513         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3514         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3515         (WTR::TestController::isDoingMediaCapture const):
3516
3517 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3518
3519         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3520         https://bugs.webkit.org/show_bug.cgi?id=194142
3521
3522         Reviewed by Ross Kirsling.
3523
3524         There three 'separator' variables in TestController.cpp. Renamed
3525         it 'pathSeparator', and unified them.
3526
3527         * WebKitTestRunner/TestController.cpp:
3528         (WTR::TestController::generateContextConfiguration const):
3529         (WTR::createTestURL):
3530         (WTR::TestController::platformAdjustContext):
3531
3532 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3533
3534         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3535         https://bugs.webkit.org/show_bug.cgi?id=194198
3536
3537         Reviewed by Antti Koivisto.
3538
3539         No need to set the banner heights on navigation now, since Page stores them.
3540
3541         * MiniBrowser/mac/WK2BrowserWindowController.m:
3542         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3543
3544 2019-02-03  John Wilander  <wilander@apple.com>
3545
3546         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3547         https://bugs.webkit.org/show_bug.cgi?id=194104
3548         <rdar://problem/47649991>
3549
3550         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3551
3552         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3553         (TestWebKitAPI::TEST):
3554             Changed numeric types from unsigned short to uint32_t.
3555
3556 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3557
3558         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3559         <https://webkit.org/b/194178>
3560         <rdar://problem/47753473>
3561
3562         Reviewed by Alexey Proskuryakov.
3563
3564         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3565         (WTR::uninstallFakeHelvetica): Pass nullptr into
3566         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3567
3568 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3569
3570         [LFC] Initialize ICB's style with fixed width/height.
3571         https://bugs.webkit.org/show_bug.cgi?id=194188
3572
3573         Reviewed by Antti Koivisto.
3574
3575         * LayoutReloaded/misc/LFC-passing-tests.txt:
3576
3577 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3578
3579         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3580         https://bugs.webkit.org/show_bug.cgi?id=194185
3581
3582         Reviewed by Antti Koivisto.
3583
3584         * LayoutReloaded/misc/LFC-passing-tests.txt:
3585
3586 2018-12-16  Darin Adler  <darin@apple.com>
3587
3588         Convert additional String::format clients to alternative approaches
3589         https://bugs.webkit.org/show_bug.cgi?id=192746
3590
3591         Reviewed by Alexey Proskuryakov.
3592
3593         * WebKitTestRunner/TestController.cpp:
3594         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3595         as an intermediate in code that ultimately constructs a WTF::String.
3596         (WTR::userMediaOriginHash): Use makeString.
3597         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3598         (WTR::TestController::didPerformClientRedirect): Ditto.
3599         (WTR::TestController::didPerformServerRedirect): Ditto.
3600         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3601
3602 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3603
3604         [ews-build] Add unit test to verify builder keys
3605         https://bugs.webkit.org/show_bug.cgi?id=194152
3606
3607         Reviewed by Lucas Forschler.
3608
3609         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3610         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3611
3612 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3613
3614         [LFC] Expand tests coverage (12 new tests -> 787)
3615
3616         Unreviewed test gardening.
3617
3618         * LayoutReloaded/misc/LFC-passing-tests.txt:
3619
3620 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3621
3622         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3623         https://bugs.webkit.org/show_bug.cgi?id=194163
3624
3625         Reviewed by Simon Fraser.
3626
3627         775
3628
3629         * LayoutReloaded/misc/LFC-passing-tests.txt:
3630
3631 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3632
3633         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3634         https://bugs.webkit.org/show_bug.cgi?id=194140
3635         <rdar://problem/47728098>
3636
3637         Reviewed by Tim Horton.
3638
3639         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3640         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3641         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3642
3643         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3644         test to induce an IPC deadlock when presenting a modal alert during touch start.
3645
3646         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3647         * WebKitTestRunner/TestController.cpp:
3648         (WTR::runJavaScriptAlert):
3649
3650         Add a client callback function for running JavaScript alerts.
3651
3652         (WTR::TestController::createOtherPage):
3653         (WTR::TestController::generateContextConfiguration const):
3654
3655         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3656         the fix in this patch.
3657
3658         (WTR::TestController::createWebViewWithOptions):
3659
3660         Plumb TestOptions to generateContextConfiguration.
3661
3662         (WTR::TestController::resetPreferencesToConsistentValues):
3663         (WTR::TestController::resetStateToConsistentValues):
3664         (WTR::updateTestOptionsFromTestHeader):
3665         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3666         (WTR::TestController::handleJavaScriptAlert):
3667         * WebKitTestRunner/TestController.h:
3668         * WebKitTestRunner/TestInvocation.cpp:
3669         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3670         * WebKitTestRunner/TestOptions.h:
3671         (WTR::TestOptions::hasSameInitializationOptions const):
3672
3673 2019-02-01  Chris Dumez  <cdumez@apple.com>
3674
3675         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3676         https://bugs.webkit.org/show_bug.cgi?id=193740
3677         <rdar://problem/47527267>
3678
3679         Reviewed by Alex Christensen.
3680
3681         Add API test coverage.
3682
3683         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3684
3685 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3686
3687         [ews-app] Add display name field to BuilderMapping model
3688         https://bugs.webkit.org/show_bug.cgi?id=194153
3689
3690         Reviewed by Lucas Forschler.
3691
3692         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3693         (BuilderMapping):
3694
3695 2019-02-01  Youenn Fablet  <youenn@apple.com>
3696
3697         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3698         https://bugs.webkit.org/show_bug.cgi?id=194155
3699
3700         Reviewed by Eric Carlson.
3701
3702         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3703         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3704         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3705
3706 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3707
3708         [LFC] Adjust replaced element's intrinsic ratio
3709         https://bugs.webkit.org/show_bug.cgi?id=194154
3710
3711         Reviewed by Antti Koivisto.
3712
3713         761
3714
3715         * LayoutReloaded/misc/LFC-passing-tests.txt:
3716
3717 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3718
3719         [WPE] Show test results in minibrowser
3720         https://bugs.webkit.org/show_bug.cgi?id=194150
3721
3722         Reviewed by Žan Doberšek.
3723
3724         * Scripts/webkitpy/port/wpe.py:
3725         (WPEPort.show_results_html_file):
3726
3727 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3728
3729         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3730         https://bugs.webkit.org/show_bug.cgi?id=194151
3731
3732         Reviewed by Žan Doberšek.
3733
3734         ALT + <- go back
3735         ALT + -> go forward
3736
3737         * MiniBrowser/wpe/main.cpp:
3738         (main):
3739
3740 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3741
3742         [LFC] Set intrinsic size on Layout::Replaced
3743         https://bugs.webkit.org/show_bug.cgi?id=194139
3744
3745         Reviewed by Antti Koivisto.
3746
3747         744
3748
3749         * LayoutReloaded/misc/LFC-passing-tests.txt:
3750
3751 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3752
3753         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3754         https://bugs.webkit.org/show_bug.cgi?id=194146
3755
3756         Reviewed by Xabier Rodriguez-Calvar.
3757
3758         It allows to open relative paths.
3759
3760         * MiniBrowser/wpe/main.cpp:
3761         (main):
3762
3763 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3764
3765         Update flakiness dashboard configuration after recent queue changes
3766         https://bugs.webkit.org/show_bug.cgi?id=194127
3767
3768         Rubber-stamped by Aakash Jain.
3769
3770         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3771
3772         * TestResultServer/static-dashboards/builders.jsonp:
3773
3774 2019-01-31  Youenn Fablet  <youenn@apple.com>
3775
3776         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3777         https://bugs.webkit.org/show_bug.cgi?id=194106
3778         <rdar://problem/47676333>
3779
3780         Reviewed by Ryosuke Niwa.
3781
3782         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3783         (TestWebKitAPI::didFinishNavigation):
3784         (TestWebKitAPI::TEST):
3785         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3786
3787 2019-01-31  Chris Dumez  <cdumez@apple.com>
3788
3789         Page zoom level is lost after a process swap or a crash
3790         https://bugs.webkit.org/show_bug.cgi?id=194105
3791         <rdar://problem/47610781>
3792
3793         Reviewed by Alex Christensen.
3794
3795         Add API test coverage.
3796
3797         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3798         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3799
3800 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3801
3802         Revert r238819 which is unneeded and caused a performance regression.
3803         https://bugs.webkit.org/show_bug.cgi?id=192272
3804         <rdar://problem/46664625>
3805
3806         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3807         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3808         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3809
3810 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3811
3812         Formalize WebKitAdditions mechanism of LoadOptimizer
3813         https://bugs.webkit.org/show_bug.cgi?id=193886
3814         <rdar://problem/47696809>
3815
3816         Reviewed by Brent Fulgham.
3817
3818         * MiniBrowser/MiniBrowser.entitlements:
3819         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3820
3821 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3822
3823         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3824         https://bugs.webkit.org/show_bug.cgi?id=194090
3825
3826         Reviewed by Antti Koivisto.
3827
3828         * LayoutReloaded/misc/LFC-passing-tests.txt:
3829
3830 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3831
3832         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3833         https://bugs.webkit.org/show_bug.cgi?id=194074
3834
3835         Reviewed by Antti Koivisto.
3836
3837         * LayoutReloaded/misc/LFC-passing-tests.txt:
3838
3839 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3840
3841         [LFC][BFC] Add support for block level replaced box.
3842         https://bugs.webkit.org/show_bug.cgi?id=194071
3843
3844         Reviewed by Antti Koivisto.
3845
3846         * LayoutReloaded/misc/LFC-passing-tests.txt:
3847
3848 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3849
3850         Fix WebKitTestRunner's testPath with Windows full paths
3851         https://bugs.webkit.org/show_bug.cgi?id=194012
3852
3853         Reviewed by Alex Christensen.
3854
3855         updateTestOptionsFromTestHeader failed to open test files because
3856         testPath returned wrong file paths. It returned a path "/C:/..."
3857         if a URL "file:///C:/..." was given.
3858
3859         * WebKitTestRunner/TestController.cpp:
3860         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3861
3862 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3863
3864         [WPE] Bump font related dependencies to match the GTK+ port
3865         https://bugs.webkit.org/show_bug.cgi?id=194017
3866
3867         Reviewed by Žan Doberšek.
3868
3869         * wpe/jhbuild.modules:
3870         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3871         * wpe/patches/icudata-stdlibs.patch: Added.
3872
3873 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3874
3875         Enable swipe tests on iOS
3876         https://bugs.webkit.org/show_bug.cgi?id=194076
3877
3878         Reviewed by Geoffrey Garen.
3879
3880         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3881         it causes a debug assertion failure in runUIScript.
3882
3883         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3884         (WTR::UIScriptController::beginBackSwipe):
3885         (WTR::UIScriptController::completeBackSwipe):
3886
3887 2019-01-30  Keith Rollin  <krollin@apple.com>
3888
3889         Use correct printf format specifier
3890         https://bugs.webkit.org/show_bug.cgi?id=194062
3891         <rdar://problem/47686167>
3892
3893         Reviewed by Alexey Proskuryakov.
3894
3895         LayoutTestSpellChecker.mm is trying to format a variable of type
3896         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3897         actually an unsigned long long. Fix this by formatting with %llu.
3898
3899         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3900         (-[LayoutTestTextCheckingResult description]):
3901
3902 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3903
3904         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3905         https://bugs.webkit.org/show_bug.cgi?id=193979
3906
3907         Reviewed by Wenson Hsieh.
3908
3909         Fix the test for iOS. Make the test work with iOS UA string.
3910
3911         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3912
3913 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3914
3915         Replace High Sierra LLINT CLoop bot due to hardware failure
3916         https://bugs.webkit.org/show_bug.cgi?id=194066
3917
3918         Reviewed by Aakash Jain.
3919
3920         * BuildSlaveSupport/build.webkit.org-config/config.json:
3921
3922 2019-01-30  Keith Rollin  <krollin@apple.com>
3923
3924         [NSDragItem init] is unavailable
3925         https://bugs.webkit.org/show_bug.cgi?id=194059
3926         <rdar://problem/47685715>
3927
3928         Reviewed by Wenson Hsieh.
3929
3930         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3931         DumpRenderTree and TestWebKitAPI, which both try to create an
3932         NSDragItem in a manner that invokes this method. Address this by using
3933         -initWithPasteboardWriter instead.
3934
3935         Note that the parameter passed to initWithPasteboardWriter is likely
3936         incorrect. In both cases, the object passed does not conform to
3937         NSPasteboardWriting. However, with this fix, we're no worse off than
3938         before, and can now perform builds with newer compilers and SDKs until
3939         a real fix can be crafted. That work is tracked in
3940         https://bugs.webkit.org/show_bug.cgi?id=194060
3941
3942         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3943         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3944         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3945         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3946
3947 2019-01-30  Daniel Bates  <dabates@apple.com>
3948
3949         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3950         https://bugs.webkit.org/show_bug.cgi?id=192824
3951         <rdar://problem/47100332>
3952
3953         Reviewed by Wenson Hsieh.
3954
3955         Fix a bug where the wrong usage code was used for F13 thru F24.
3956
3957         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3958         (keyCodeForDOMFunctionKey):
3959
3960 2019-01-30  Chris Dumez  <cdumez@apple.com>
3961
3962         Regression(PSON) Load hang can occur on history navigation
3963         https://bugs.webkit.org/show_bug.cgi?id=194030
3964         <rdar://problem/47656939>
3965
3966         Reviewed by Antti Koivisto.
3967
3968         Add API test coverage.
3969
3970         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3971
3972 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3973
3974         [LFC] Expand tests coverage.
3975
3976         Unreviewed test gardening.
3977
3978         * LayoutReloaded/misc/LFC-passing-tests.txt:
3979
3980 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3981
3982         [Flatpak] Add openjpeg support
3983         https://bugs.webkit.org/show_bug.cgi?id=194019
3984
3985         Reviewed by Michael Catanzaro.
3986
3987         * flatpak/org.webkit.CommonModules.yaml:
3988
3989 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3990
3991         Unreviewed, rolling out r240708.
3992         https://bugs.webkit.org/show_bug.cgi?id=194022
3993
3994         It broke WPE build (Requested by KaL on #webkit).
3995
3996         Reverted changeset:
3997
3998         "[WPE] Bump font related dependencies to match the GTK+ port"
3999         https://bugs.webkit.org/show_bug.cgi?id=194017
4000         https://trac.webkit.org/changeset/240708
4001
4002 2019-01-30  Zalan Bujtas  <zalan@apple.com>
4003
4004         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
4005         https://bugs.webkit.org/show_bug.cgi?id=194001
4006
4007         Reviewed by Antti Koivisto.
4008
4009         * LayoutReloaded/misc/LFC-passing-tests.txt:
4010
4011 2019-01-30  Zalan Bujtas  <zalan@apple.com>
4012
4013         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
4014         https://bugs.webkit.org/show_bug.cgi?id=194020
4015
4016         Reviewed by Antti Koivisto.
4017
4018         * LayoutReloaded/misc/LFC-passing-tests.txt:
4019
4020 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
4021
4022         AX: Support color well on iOS
4023         https://bugs.webkit.org/show_bug.cgi?id=194010
4024
4025         Reviewed by Joanmarie Diggs.
4026
4027         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4028         (WTR::AccessibilityUIElement::stringAttributeValue):
4029
4030 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
4031
4032         [WPE] Bump font related dependencies to match the GTK+ port
4033         https://bugs.webkit.org/show_bug.cgi?id=194017
4034
4035         Reviewed by Žan Doberšek.
4036
4037         * wpe/jhbuild.modules:
4038         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
4039         * wpe/patches/icudata-stdlibs.patch: Added.
4040
4041 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
4042
4043         [Mac] Update window scale API usage
4044         https://bugs.webkit.org/show_bug.cgi?id=193991
4045         rdar://problem/47614795
4046
4047         Reviewed by Tim Horton.
4048
4049         * DumpRenderTree/mac/DumpRenderTree.mm:
4050         (changeWindowScaleIfNeeded):
4051         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
4052         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4053         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4054
4055 2019-01-29  Chris Dumez  <cdumez@apple.com>
4056
4057         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
4058         https://bugs.webkit.org/show_bug.cgi?id=193977
4059         <rdar://problem/47643716>
4060
4061         Reviewed by Geoff Garen.
4062
4063         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
4064         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
4065         to the previous provisional committing *before* we make the last load. 
4066
4067         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4068
4069 2019-01-29  Youenn Fablet  <youenn@apple.com>
4070
4071         Adopt new SPI to evaluate server certificate trust
4072         https://bugs.webkit.org/show_bug.cgi?id=193355
4073
4074         Reviewed by Alex Christensen.
4075
4076         Add infrastructure to handle HTTPS server trust evaluation testing.
4077
4078         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4079         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4080         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
4081         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
4082         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
4083         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4084         * WebKitTestRunner/TestController.cpp:
4085         (WTR::TestController::resetPreferencesToConsistentValues):
4086         (WTR::TestController::didReceiveAuthenticationChallenge):
4087         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
4088         * WebKitTestRunner/TestController.h:
4089         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
4090         * WebKitTestRunner/TestInvocation.cpp:
4091         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4092         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4093         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
4094
4095 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
4096
4097         [ews-build] Add build step to print bot Configuration
4098         https://bugs.webkit.org/show_bug.cgi?id=193887
4099
4100         Reviewed by Lucas Forschler.
4101
4102         * BuildSlaveSupport/ews-build/steps.py:
4103         (PrintConfiguration): Build step to print configuration.
4104         * BuildSlaveSupport/ews-build/factories.py:
4105
4106 2019-01-29  Chris Dumez  <cdumez@apple.com>
4107
4108         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
4109         https://bugs.webkit.org/show_bug.cgi?id=193967
4110         <rdar://problem/47635348>
4111
4112         Reviewed by Alex Christensen.
4113
4114         Add API test coverage.
4115
4116         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4117         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
4118
4119 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
4120
4121         [ews-app] Handle incoming results data
4122         https://bugs.webkit.org/show_bug.cgi?id=193973
4123
4124         Reviewed by Lucas Forschler.
4125
4126         * BuildSlaveSupport/ews-app/ews/views/results.py:
4127
4128 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
4129
4130         [ews-app] Make the results url generic
4131         https://bugs.webkit.org/show_bug.cgi?id=193928
4132
4133         Reviewed by Lucas Forschler.
4134
4135         * BuildSlaveSupport/ews-app/ews/urls.py:
4136
4137 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
4138
4139         [ews-build] Configure buildbot to send events to ews-app
4140         https://bugs.webkit.org/show_bug.cgi?id=193968
4141
4142         Reviewed by Lucas Forschler.
4143
4144         * BuildSlaveSupport/ews-build/events.py: Added.
4145         * BuildSlaveSupport/ews-build/master.cfg:
4146
4147 2019-01-29  Keith Rollin  <krollin@apple.com>
4148
4149         Add .xcfilelists to Run Script build phases
4150         https://bugs.webkit.org/show_bug.cgi?id=193792
4151         <rdar://problem/47201785>
4152
4153         Reviewed by Alex Christensen.
4154
4155         As part of supporting XCBuild, update the necessary Run Script build
4156         phases in their Xcode projects to refer to their associated
4157         .xcfilelist files.
4158
4159         Note that the addition of these files bumps the Xcode project version
4160         number to something that's Xcode 10 compatible. This change means that
4161         older versions of the Xcode IDE can't read these projects. Nor can it
4162         fully load workspaces that refer to these projects (the updated
4163         projects are shown as non-expandable placeholders). `xcodebuild` can
4164         still build these projects; it's just that the IDE can't open them.
4165
4166         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4167         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4168
4169 2019-01-29  John Wilander  <wilander@apple.com>
4170
4171         Add data abstraction and validation for Ad Click Attribution
4172         https://bugs.webkit.org/show_bug.cgi?id=193916
4173         <rdar://problem/47603481>
4174
4175         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
4176
4177         Ad click attribution has two steps. First, the storage of an ad
4178         campaign ID for a click that takes the user to a destination
4179         site. Second, a conversion on the destination site that can be
4180         attributed to the ad click.
4181
4182         This patch adds a class that represents a request for ad click
4183         attribution. Validation makes sure that the bits of entropy
4184         reported through this mechanism is limited.
4185
4186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4187         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
4188         (TestWebKitAPI::TEST):
4189
4190 2019-01-29  Chris Dumez  <cdumez@apple.com>
4191
4192         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
4193         https://bugs.webkit.org/show_bug.cgi?id=193932
4194         <rdar://problem/47598947>
4195
4196         Reviewed by Brady Eidson.
4197
4198         Add API test coverage.
4199
4200         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4201
4202 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4203
4204         Adding new passing LFC tests.
4205
4206         Unreviewed test gardening.
4207
4208         * LayoutReloaded/misc/LFC-passing-tests.txt:
4209
4210 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4211
4212         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
4213         https://bugs.webkit.org/show_bug.cgi?id=193964
4214
4215         Reviewed by Antti Koivisto.
4216
4217         * LayoutReloaded/misc/LFC-passing-tests.txt:
4218
4219 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4220
4221         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
4222         https://bugs.webkit.org/show_bug.cgi?id=193954
4223
4224         Reviewed by Antti Koivisto.
4225
4226         * LayoutReloaded/misc/LFC-passing-tests.txt:
4227
4228 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
4229
4230         WebDriver: add support for running subtests
4231         https://bugs.webkit.org/show_bug.cgi?id=193904
4232
4233         Reviewed by Michael Catanzaro.
4234
4235         pytest already supports it by passing test.py::subtest, so we can do the same.
4236
4237         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
4238         (get_item_name): Made this global.
4239         (CollectRecorder.__init__): Receive the parameter to ignore.
4240         (CollectRecorder.pytest_collectreport): Collect also the subtests.
4241         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
4242         (collect): Add parameter to ignore.
4243         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
4244         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
4245         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
4246         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
4247         (WebDriverTestRunnerSelenium.run): Ditto.
4248         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
4249         (WebDriverTestRunnerW3C.collect_tests): Ditto.
4250         (WebDriverTestRunnerW3C.run): Ditto.
4251
4252 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
4253
4254         User agent string override for navigator.userAgent should be site specific quirks
4255         https://bugs.webkit.org/show_bug.cgi?id=193950
4256
4257         Reviewed by Brent Fulgham.
4258
4259         Updated per the _WKWebsitePolicies rename.
4260
4261         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4262         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4263
4264 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
4265
4266         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
4267         https://bugs.webkit.org/show_bug.cgi?id=193941
4268
4269         Reviewed by Alex Christensen.
4270
4271         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
4272         * TestWebKitAPI/Tests/WTF/Condition.cpp:
4273         * TestWebKitAPI/Tests/WTF/Lock.cpp:
4274         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
4275         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
4276         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
4277         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
4278         * TestWebKitAPI/Tests/WTF/Time.cpp:
4279         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
4280         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
4281         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
4282         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
4283
4284 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
4285
4286         Unreviewed, reorder my emails to fix autocomplete in bugzilla
4287
4288         * Scripts/webkitpy/common/config/contributors.json:
4289
4290 2019-01-28  Andy Estes  <aestes@apple.com>
4291
4292         [watchOS] Enable Parental Controls content filtering
4293         https://bugs.webkit.org/show_bug.cgi?id=193939
4294         <rdar://problem/46641912>
4295
4296         Reviewed by Ryosuke Niwa.
4297
4298         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4299
4300 2019-01-28  David Kilzer  <ddkilzer@apple.com>
4301
4302         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
4303         <https://webkit.org/b/193884>
4304
4305         Reviewed by Jiewen Tan.
4306
4307         * Scripts/webkitpy/style/checkers/cpp.py:
4308         (check_language): Add LocalAuthentication to
4309         `frameworks_with_soft_links`.
4310
4311 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
4312
4313         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
4314         https://bugs.webkit.org/show_bug.cgi?id=193891
4315
4316         Reviewed by Ross Kirsling.
4317
4318         There were three problems in window sizes of WebView and the host window.
4319         1. The sizes of pixel image output were incorrect.
4320         2. The host window is going to appear after window.resize was invoked.
4321         3. window.resize resized only the host window, not WebView.
4322
4323         This change solves them with a following approach.
4324         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
4325         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
4326            as well as DumpRenderTree in order to match the client area and the window area.
4327         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
4328         d. PlatformWebView::setWindowFrame changes both window sizes.
4329         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
4330
4331         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4332         (WTR::PlatformWebView::PlatformWebView): Create the host window
4333         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
4334         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
4335         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
4336
4337 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4338
4339         [ews-app] Add method to save Step data to database
4340         https://bugs.webkit.org/show_bug.cgi?id=193890
4341
4342         Reviewed by Lucas Forschler.
4343
4344         * BuildSlaveSupport/ews-app/ews/models/step.py:
4345         (Step.save_step): Method to save step data.
4346         (Step.update_step): Method to update step data.
4347         (Step.get_existing_step): Method to fetch existing step from database.
4348         (Step.is_valid_result): Method to validate valid step result.
4349
4350 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4351
4352         [ews-app] Add method to save Build data to database
4353         https://bugs.webkit.org/show_bug.cgi?id=193735
4354
4355         Reviewed by Lucas Forschler.
4356
4357         * BuildSlaveSupport/ews-app/ews/models/build.py:
4358         (Build.save_build): Method to save build information to database.
4359         (Build.get_existing_build): Method to fetch existing build from database.
4360         (Build.is_valid_result): Method to validate build result.
4361         * BuildSlaveSupport/ews-app/ews/common/util.py:
4362         (is_valid_int_id): Method to validate valid id.
4363
4364 2019-01-28  Chris Dumez  <cdumez@apple.com>
4365
4366         Regression(PSON) Crash under WebPageProxy::didStartProgress()
4367         https://bugs.webkit.org/show_bug.cgi?id=193915
4368         <rdar://problem/47560907>
4369
4370         Reviewed by Alex Christensen.
4371
4372         Add API test coverage.
4373
4374         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4375
4376 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4377
4378         [ews-app] Rename id variables
4379         https://bugs.webkit.org/show_bug.cgi?id=193883
4380
4381         Reviewed by Lucas Forschler.
4382
4383         * BuildSlaveSupport/ews-app/ews/models/build.py:
4384  &n