WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-24  Alex Christensen  <achristensen@webkit.org>
2
3         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
4         https://bugs.webkit.org/show_bug.cgi?id=197078
5         <rdar://problem/49564348>
6
7         Reviewed by Geoff Garen.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
10         (TEST_F):
11         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
12         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
13         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
14
15 2019-04-24  Alex Christensen  <achristensen@webkit.org>
16
17         Add unit test for r239322
18         https://bugs.webkit.org/show_bug.cgi?id=197236
19
20         Reviewed by Chris Dumez.
21
22         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
23         May as well add the test infrastructure which was needed before and will be needed in the future.
24
25         * TestWebKitAPI/TCPServer.cpp:
26         (TestWebKitAPI::TCPServer::TCPServer):
27         * TestWebKitAPI/TCPServer.h:
28         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
29         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
30         (TestWebKitAPI::TEST):
31         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
32         (TestWebKitAPI::downloadAtRate):
33         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
34         (TEST):
35         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
36         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
37         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
38         (TestWebKitAPI::TEST):
39         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
40         (TEST):
41
42 2019-04-24  Chris Dumez  <cdumez@apple.com>
43
44         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
45         https://bugs.webkit.org/show_bug.cgi?id=197214
46         <rdar://problem/49237544>
47
48         Reviewed by Alex Christensen.
49
50         Extend API test coverage.
51
52         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
53         (TEST):
54
55 2019-04-24  Philippe Normand  <pnormand@igalia.com>
56
57         [Build][GStreamer] Update to 1.16.0
58         https://bugs.webkit.org/show_bug.cgi?id=197157
59
60         Reviewed by Xabier Rodriguez-Calvar.
61
62         The upstreamed patches were removed and a new one was added for a
63         regression detected in the scaletempo GStreamer element. The GNOME
64         Flatpak was migrated to 3.32 and I switched a few modules to Meson
65         on the way, as it is the preferred build system now in GStreamer
66         1.16.
67
68         * flatpak/files/httpd-autogen.sh:
69         * flatpak/flatpakutils.py:
70         (FlatpakPackage.install):
71         (WebkitFlatpak.run_in_sandbox):
72         * flatpak/org.webkit.CommonModules.yaml:
73         * flatpak/org.webkit.WebKit.yaml:
74         * gstreamer/jhbuild.modules:
75         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
76         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
77         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
78         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
79         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
80         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
81         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
82         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
83         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
84         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
85         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
86         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
87         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
88         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
89         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
90         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
91         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
92         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
93         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
94         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
95         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
96         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
97
98 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
99
100         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
101         https://bugs.webkit.org/show_bug.cgi?id=197156
102
103         Reviewed by Michael Catanzaro.
104
105         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
106         support was added.
107
108         * MiniBrowser/gtk/BrowserTab.c:
109         (browser_tab_set_background_color): Set the passed in color as web view background color.
110         * MiniBrowser/gtk/BrowserTab.h:
111         * MiniBrowser/gtk/BrowserWindow.c:
112         (browser_window_init): Initialize backgroundColor.
113         (browser_window_append_view): Call browser_tab_set_background_color().
114         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
115         are added.
116         * MiniBrowser/gtk/main.c:
117         (main): Call browser_window_set_background_color() before creating the tabs.
118
119 2019-04-23  John Wilander  <wilander@apple.com>
120
121         Move Ad Click Attribution from internal feature to experimental feature
122         https://bugs.webkit.org/show_bug.cgi?id=197218
123         <rdar://problem/47651691>
124
125         Reviewed by Brent Fulgham.
126
127         * DumpRenderTree/TestOptions.cpp:
128         (TestOptions::TestOptions):
129
130 2019-04-23  Andy Estes  <aestes@apple.com>
131
132         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
133         https://bugs.webkit.org/show_bug.cgi?id=196749
134         <rdar://problem/35773454>
135
136         Reviewed by Daniel Bates.
137
138         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
139
140         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
141         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
142         (-[QuickLookDelegate webView:didFinishNavigation:]):
143         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
144         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
145         (runTest):
146         (runTestDecideBeforeLoading):
147         (runTestDecideAfterLoading):
148         (TEST):
149
150 2019-04-23  John Wilander  <wilander@apple.com>
151
152         Remove Ad Click Attribution data when removing website data
153         https://bugs.webkit.org/show_bug.cgi?id=197215
154         <rdar://problem/47668988>
155
156         Reviewed by Chris Dumez.
157
158         This patch adds test infrastructure to delete Ad Click Attribution data
159         through WebsiteDataStore::removeData().
160
161         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
162         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
163         (WTR::TestRunner::clearAdClickAttribution):
164         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
165         * WebKitTestRunner/InjectedBundle/TestRunner.h:
166         * WebKitTestRunner/TestController.cpp:
167         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
168         * WebKitTestRunner/TestController.h:
169         * WebKitTestRunner/TestInvocation.cpp:
170         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
171
172 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
173
174         webkitpy: Kill unresponsive worker processes
175         https://bugs.webkit.org/show_bug.cgi?id=197205
176         <rdar://problem/50104388>
177
178         Reviewed by Lucas Forschler.
179
180         * Scripts/webkitpy/common/message_pool.py:
181         (_MessagePool.__init__): Add close timeout.
182         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
183
184 2019-04-23  Alex Christensen  <achristensen@webkit.org>
185
186         Add unit tests for WKWebView.serverTrust
187         https://bugs.webkit.org/show_bug.cgi?id=197202
188
189         Reviewed by Youenn Fablet
190
191         * TestWebKitAPI/TCPServer.cpp:
192         (TestWebKitAPI::deleter<BIO>::operator()):
193         (TestWebKitAPI::deleter<SSL>::operator()):
194         (TestWebKitAPI::deleter<X509>::operator()):
195         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
196         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
197         (TestWebKitAPI::TCPServer::TCPServer):
198         (TestWebKitAPI::TCPServer::listenForConnections):
199         * TestWebKitAPI/TCPServer.h:
200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
201         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
202         (TestWebKitAPI::TEST):
203         (verifyCertificateAndPublicKey):
204         (-[ServerTrustDelegate webView:didFinishNavigation:]):
205         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
206         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
207         (TestWebKitAPI::downloadAtRate):
208         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
209         (TEST):
210         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
211         (TEST):
212
213 2019-04-23  Commit Queue  <commit-queue@webkit.org>
214
215         Unreviewed, rolling out r244556.
216         https://bugs.webkit.org/show_bug.cgi?id=197212
217
218         Causing build failures on multiple builders (Requested by
219         ShawnRoberts on #webkit).
220
221         Reverted changeset:
222
223         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
224         https://bugs.webkit.org/show_bug.cgi?id=197171
225         https://trac.webkit.org/changeset/244556
226
227 2019-04-23  Alex Christensen  <achristensen@webkit.org>
228
229         Fix iOS build.
230         https://bugs.webkit.org/show_bug.cgi?id=195537
231
232         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
233         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
234         AdoptWK constructor is private now.  Use adoptWK instead.
235
236 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
237
238         Accessibility text search and selection API enhancements.
239         https://bugs.webkit.org/show_bug.cgi?id=197095
240         <rdar://problem/48181791>
241
242         Reviewed by Chris Fleizach.
243
244         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
245
246         * DumpRenderTree/AccessibilityTextMarker.h:
247         * DumpRenderTree/AccessibilityUIElement.cpp:
248         (searchTextWithCriteriaCallback):
249         (AccessibilityUIElement::getJSClass):
250         * DumpRenderTree/AccessibilityUIElement.h:
251         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
252         (convertVectorToObjectArray):
253         (convertNSArrayToVector):
254         (searchTextParameterizedAttributeForCriteria):
255         (AccessibilityUIElement::getLinkedUIElements):
256         (AccessibilityUIElement::getDocumentLinks):
257         (AccessibilityUIElement::getChildren):
258         (AccessibilityUIElement::getChildrenWithRange):
259         (AccessibilityUIElement::rowHeaders const):
260         (AccessibilityUIElement::columnHeaders const):
261         (AccessibilityUIElement::uiElementArrayAttributeValue const):
262         (AccessibilityUIElement::searchTextWithCriteria):
263         (AccessibilityUIElement::attributesOfColumnHeaders):
264         (AccessibilityUIElement::attributesOfRowHeaders):
265         (AccessibilityUIElement::attributesOfColumns):
266         (AccessibilityUIElement::attributesOfRows):
267         (AccessibilityUIElement::attributesOfVisibleCells):
268         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
269         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
270         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
271         (WTR::convertVectorToObjectArray):
272         (WTR::convertNSArrayToVector):
273         (WTR::searchTextParameterizedAttributeForCriteria):
274         (WTR::AccessibilityUIElement::getLinkedUIElements):
275         (WTR::AccessibilityUIElement::getDocumentLinks):
276         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
277         (WTR::AccessibilityUIElement::getChildren):
278         (WTR::AccessibilityUIElement::getChildrenWithRange):
279         (WTR::AccessibilityUIElement::rowHeaders const):
280         (WTR::AccessibilityUIElement::columnHeaders const):
281         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
282         (WTR::AccessibilityUIElement::searchTextWithCriteria):
283         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
284         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
285         (WTR::AccessibilityUIElement::attributesOfColumns):
286         (WTR::AccessibilityUIElement::attributesOfRows):
287         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
288         (WTR::convertElementsToObjectArray): Deleted.
289
290 2019-04-23  Guy Lewin  <guy@lewin.co.il>
291
292         Multiple File Input Icon Set Regardless of File List
293         https://bugs.webkit.org/show_bug.cgi?id=195537
294
295         Reviewed by Alexey Proskuryakov.
296
297         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
298         display string in iOS file inputs
299
300         * DumpRenderTree/TestRunner.cpp:
301         (SetOpenPanelFilesMediaIconCallback):
302         (TestRunner::staticFunctions):
303         (TestRunner::setOpenPanelFilesMediaIcon):
304         * DumpRenderTree/TestRunner.h:
305         (TestRunner::openPanelFilesMediaIcon const):
306         * DumpRenderTree/mac/UIDelegate.mm:
307         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
308         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
309         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
310         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
311         * WebKitTestRunner/InjectedBundle/TestRunner.h:
312         * WebKitTestRunner/TestController.cpp:
313         (WTR::runOpenPanel):
314         (WTR::TestController::resetStateToConsistentValues):
315         * WebKitTestRunner/TestController.h:
316         (WTR::TestController::openPanelFileURLsMediaIcon const):
317         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
318         * WebKitTestRunner/TestInvocation.cpp:
319         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
320
321 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
322
323         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
324         https://bugs.webkit.org/show_bug.cgi?id=197171
325         <rdar://problem/47454979>
326
327         Reviewed by Youenn Fablet.
328
329         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
330         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
331         (TestWebKitAPI::TEST):
332
333 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
334
335         [ews-build] Add unit tests for UnApplyPatchIfRequired
336         https://bugs.webkit.org/show_bug.cgi?id=197197
337
338         Reviewed by Lucas Forschler.
339
340         * BuildSlaveSupport/ews-build/steps_unittest.py:
341         (TestUnApplyPatchIfRequired):
342         (TestUnApplyPatchIfRequired.test_success):
343         (TestUnApplyPatchIfRequired.test_failure):
344         (TestUnApplyPatchIfRequired.test_skip):
345
346 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
347
348         [ews-build] Add unit tests for CleanWorkingDirectory
349         https://bugs.webkit.org/show_bug.cgi?id=197195
350
351         Reviewed by Lucas Forschler.
352
353         * BuildSlaveSupport/ews-build/steps_unittest.py:
354         (TestCleanWorkingDirectory):
355         (TestCleanWorkingDirectory.test_success):
356         (TestCleanWorkingDirectory.test_failure):
357
358 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
359
360         [ews-build] Use explicit imports instead of wildcard imports
361         https://bugs.webkit.org/show_bug.cgi?id=197194
362
363         Reviewed by Lucas Forschler.
364
365         * BuildSlaveSupport/ews-build/factories.py:
366         * BuildSlaveSupport/ews-build/loadConfig.py:
367         * BuildSlaveSupport/ews-build/steps_unittest.py:
368
369 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
370
371         [ews-build] Add unit tests for DownloadBuiltProduct
372         https://bugs.webkit.org/show_bug.cgi?id=197193
373
374         Reviewed by Lucas Forschler.
375
376         * BuildSlaveSupport/ews-build/steps_unittest.py:
377         (TestDownloadBuiltProduct):
378         (TestDownloadBuiltProduct.setUp):
379         (TestDownloadBuiltProduct.tearDown):
380         (TestDownloadBuiltProduct.test_success):
381         (TestDownloadBuiltProduct.test_failure):
382
383 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
384
385         [ews-app] Exception while loading status-bubble when no build step has started
386         https://bugs.webkit.org/show_bug.cgi?id=196676
387
388         Reviewed by Lucas Forschler.
389
390         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
391         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
392
393 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
394
395         [PlayStation] Support running of JSC tests on remote playstation devices
396         https://bugs.webkit.org/show_bug.cgi?id=197170
397
398         Reviewed by Ross Kirsling.
399
400         Script changes
401
402         * Scripts/run-javascriptcore-tests:
403         (runJSCStressTests): Pass arguments for playstation to
404         run-jsc-stress-tests
405         * Scripts/run-jsc-stress-tests:
406         Handle $hostOS=="playstation" for determineArchitecture, turning
407         off $isFTLPlatform and runProfiler and defaulting test writer.
408         * Scripts/webkitdirs.pm:
409         (jscPath): PlayStation WebKit executables have .elf extension
410         (executableProductDir): PlayStation builds on Windows hosts but
411         uses bin directory rather than bin64/bin32 for executable output
412         location.
413         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
414
415 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
416
417         [CMake][Win] Use target oriented design for WebKit
418         https://bugs.webkit.org/show_bug.cgi?id=197173
419
420         Reviewed by Alex Christensen.
421
422         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
423         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
424
425 2019-04-23  Chris Dumez  <cdumez@apple.com>
426
427         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
428         https://bugs.webkit.org/show_bug.cgi?id=197097
429         <rdar://problem/50048318>
430
431         Reviewed by Alex Christensen.
432
433         Add API test coverage.
434
435         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
436         (-[PSONScheme webView:startURLSchemeTask:]):
437
438 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
439
440         [ATK] Implement AtkComponentIface scroll_to methods
441         https://bugs.webkit.org/show_bug.cgi?id=196856
442
443         Reviewed by Michael Catanzaro.
444
445         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
446         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
447         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
448         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
449
450 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
451
452         [ews-build] Improve summary for UploadBuiltProduct step
453         https://bugs.webkit.org/show_bug.cgi?id=197182
454
455         Reviewed by Lucas Forschler.
456
457         * BuildSlaveSupport/ews-build/steps.py:
458         (UploadBuiltProduct): Added descriptionDone.
459         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
460         * BuildSlaveSupport/ews-build/steps_unittest.py:
461         (TestUploadBuiltProduct.test_success): Updated unit-test.
462         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
463
464 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
465
466         [ews-build] Trigger queues only after uploading the archive
467         https://bugs.webkit.org/show_bug.cgi?id=197180
468
469         Reviewed by Lucas Forschler.
470
471         * BuildSlaveSupport/ews-build/factories.py:
472         (Factory.__init__):
473         (BuildFactory.__init__): Remove trigger step from factories.
474         (BuildFactory.propertiesToPassToTriggers): Deleted.
475         * BuildSlaveSupport/ews-build/steps.py:
476         (ConfigureBuild.__init__): Confiure triggers property.
477         (Trigger): Step to trigger other queues.
478         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
479         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
480
481 2019-04-22  Alex Christensen  <achristensen@webkit.org>
482
483         Deprecate WKContextCreateWithInjectedBundlePath
484         https://bugs.webkit.org/show_bug.cgi?id=197169
485
486         Reviewed by Youenn Fablet.
487
488         * TestWebKitAPI/PlatformUtilities.cpp:
489         (TestWebKitAPI::Util::createContextWithInjectedBundle):
490         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
491
492 2019-04-22  Alex Christensen  <achristensen@webkit.org>
493
494         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
495         https://bugs.webkit.org/show_bug.cgi?id=197093
496         <rdar://problem/49708268>
497
498         Reviewed by Chris Dumez.
499
500         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
501         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
502         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
503         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
504         and one for loads without credentials, so there are two TCP connections to the same server in this test.
505
506         * TestWebKitAPI/TCPServer.cpp:
507         (TestWebKitAPI::TCPServer::TCPServer):
508         (TestWebKitAPI::TCPServer::~TCPServer):
509         (TestWebKitAPI::TCPServer::socketBindListen):
510         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
511         * TestWebKitAPI/TCPServer.h:
512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
513         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
514         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
515         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
516         (respondWithChallengeThenOK):
517         (TestWebKitAPI::TEST):
518         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
519         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
520         (TEST):
521
522 2019-04-22  Chris Dumez  <cdumez@apple.com>
523
524         Delayed WebProcessLaunch may break the _relatedWebView SPI
525         https://bugs.webkit.org/show_bug.cgi?id=197160
526
527         Reviewed by Alex Christensen.
528
529         Add API test coverage.
530
531         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
532
533 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
534
535         Use curl to download packages for webkitpy autoinstaller
536         https://bugs.webkit.org/show_bug.cgi?id=197164
537
538         Reviewed by Darin Adler.
539
540         * Scripts/webkitpy/common/system/autoinstall.py:
541         (AutoInstaller._download): Use curl(1) to download packages necessary for
542         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
543         errors which are not present when using curl(1).
544
545 2019-04-22  Chris Dumez  <cdumez@apple.com>
546
547         Unreviewed, rolling out r244502.
548
549         Caused crashes on the bots
550
551         Reverted changeset:
552
553         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
554         https://bugs.webkit.org/show_bug.cgi?id=197160
555         https://trac.webkit.org/changeset/244502
556
557 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
558
559         Unreviewed, rolling out r244437.
560
561         Still breaks internal tests.
562
563         Reverted changeset:
564
565         "InjectedBundle parameters often need initialization function
566         called before unarchiving"
567         https://bugs.webkit.org/show_bug.cgi?id=189709
568         https://trac.webkit.org/changeset/244437
569
570 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
571
572         [ews-build] Use singular verb in failure description in case of single api test failure
573         https://bugs.webkit.org/show_bug.cgi?id=197013
574
575         Reviewed by Lucas Forschler.
576
577         * BuildSlaveSupport/ews-build/steps.py:
578         (AnalyzeAPITestsResults.analyzeResults):
579
580 2019-04-22  Chris Dumez  <cdumez@apple.com>
581
582         Delayed WebProcessLaunch may break the _relatedWebView SPI
583         https://bugs.webkit.org/show_bug.cgi?id=197160
584
585         Reviewed by Alex Christensen.
586
587         Add API test coverage.
588
589         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
590
591 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
592
593         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
594         https://bugs.webkit.org/show_bug.cgi?id=194630
595
596         Reviewed by Michael Catanzaro.
597
598         Return early from getAttributeSet() is passed in accessible is nullptr.
599
600         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
601
602 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
603
604         Defer EditorState updates until the next layer tree flush in a few additional circumstances
605         https://bugs.webkit.org/show_bug.cgi?id=197145
606         <rdar://problem/50078170>
607
608         Reviewed by Darin Adler.
609
610         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
611         focus, or showing the font manager.
612
613         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
614         (TestWebKitAPI::TEST):
615         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
616         (TEST):
617         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
618         (TestWebKitAPI::TEST):
619
620 2019-04-21  Brian Burg  <bburg@apple.com>
621
622         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
623         https://bugs.webkit.org/show_bug.cgi?id=197125
624         <rdar://problem/50061468>
625
626         Reviewed by Darin Adler.
627
628         Sometimes I want to run wptserve independently of tests. Make it easier to script that
629         using this class rather than making our own ./wpt serve invocation.
630
631         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
632         (WebDriverW3CWebServer):
633         (WebDriverW3CWebServer.document_root): Expose this to clients.
634         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
635
636         (WebDriverW3CWebServer.__enter__):
637         (WebDriverW3CWebServer.__exit__):
638         Make it possible to use the web server with a 'with' statement.
639
640 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
641
642         [CMake][Win] Use target oriented design for WebKitLegacy
643         https://bugs.webkit.org/show_bug.cgi?id=197112
644
645         Reviewed by Konstantin Tokarev.
646
647         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
648
649         * DumpRenderTree/CMakeLists.txt:
650         * DumpRenderTree/PlatformWin.cmake:
651         * DumpRenderTree/win/EventSender.cpp:
652
653 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
654
655         Update text for old EWS submit button
656         https://bugs.webkit.org/show_bug.cgi?id=197140
657
658         Reviewed by Alexey Proskuryakov.
659
660         * QueueStatusServer/templates/statusbubble.html:
661
662 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
663
664         [ews-app] New EWS should poll bugzilla more frequently
665         https://bugs.webkit.org/show_bug.cgi?id=197138
666
667         Reviewed by Alexey Proskuryakov.
668
669         * BuildSlaveSupport/ews-app/ews/fetcher.py:
670         (FetchLoop.__init__):
671
672 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
673
674         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
675         https://bugs.webkit.org/show_bug.cgi?id=197139
676
677         Reviewed by Alexey Proskuryakov.
678
679         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
680         * QueueStatusServer/templates/statusbubble.html:
681
682 2019-04-20  Chris Dumez  <cdumez@apple.com>
683
684         Unreviewed, fix iOS build with recent SDKs.
685
686         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
687
688 2019-04-19  Keith Miller  <keith_miller@apple.com>
689
690         Add script to merge run_benchmark jsons
691         https://bugs.webkit.org/show_bug.cgi?id=197107
692
693         Reviewed by Michael Saboff.
694
695         The script basically recursively decends through all json objects until it gets
696         to an array or JSON primitive and concats or takes the first value, respectively.
697
698         This patch also adds +x bits to the compare-results script so it
699         can be run directly from the command line. I had to add a new line so that svn
700         will accept the change... yay svn!
701
702         * Scripts/compare-results:
703         * Scripts/merge-result-jsons: Added.
704         (readJSONFile):
705         (deepAppend):
706         (mergeJSONs):
707         (main):
708
709 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
710
711         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
712         https://bugs.webkit.org/show_bug.cgi?id=197079
713
714         Reviewed by Darin Adler.
715
716         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
717
718         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
719         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
720
721 2019-04-18  Commit Queue  <commit-queue@webkit.org>
722
723         Unreviewed, rolling out r244434.
724         https://bugs.webkit.org/show_bug.cgi?id=197089
725
726         caused 1 API test failure (Requested by zalan on #webkit).
727
728         Reverted changeset:
729
730         "Regression (r244291): Broken API Test
731         AutoLayoutRenderingProgressRelativeOrdering"
732         https://bugs.webkit.org/show_bug.cgi?id=196948
733         https://trac.webkit.org/changeset/244434
734
735 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
736
737         Add new compatibility mode API on WKNavigation
738         https://bugs.webkit.org/show_bug.cgi?id=197069
739         <rdar://problem/50025800>
740
741         Reviewed by Tim Horton.
742
743         Add a block property for -didCommitNavigation to TestNavigationDelegate.
744
745         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
746         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
747         (-[TestNavigationDelegate webView:didCommitNavigation:]):
748
749 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
750
751         [CMake] Make WebCore headers copies
752         https://bugs.webkit.org/show_bug.cgi?id=182512
753         <rdar://problem/37510435>
754
755         Reviewed by Alex Christensen.
756
757         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
758         ports.
759
760         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
761         of WebCore headers using "*.h" were modified to <WebCore/*.h>
762
763         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
764         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
765         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
766         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
767         * TestWebKitAPI/CMakeLists.txt:
768         * TestWebKitAPI/PlatformWin.cmake:
769         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
770         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
771         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
772
773 2019-04-18  Jer Noble  <jer.noble@apple.com>
774
775         Add support for parsing FairPlayStreaming PSSH boxes.
776         https://bugs.webkit.org/show_bug.cgi?id=197064
777
778         Reviewed by Eric Carlson.
779
780         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
781         (TestWebKitAPI::TEST):
782
783 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
784
785         InjectedBundle parameters often need initialization function called before unarchiving
786         https://bugs.webkit.org/show_bug.cgi?id=189709
787         <rdar://problem/44573653>
788
789         Reviewed by Ryosuke Niwa.
790
791         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
792         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
793
794 2019-04-18  Zalan Bujtas  <zalan@apple.com>
795
796         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
797         https://bugs.webkit.org/show_bug.cgi?id=196948
798         <rdar://problem/49927131>
799
800         Reviewed by Tim Horton.
801
802         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
803         (TEST): 
804         The expected order of incoming events is
805         1. didInvalidateIntrinsicContentSize
806         2. didFirstLayout
807         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
808         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
809         (and remember, all we care about is ordering).
810
811 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
812
813         Unreviewed, rolling out r244299.
814
815         Breaks internal tests.
816
817         Reverted changeset:
818
819         "InjectedBundle parameters often need initialization function
820         called before unarchiving"
821         https://bugs.webkit.org/show_bug.cgi?id=189709
822         https://trac.webkit.org/changeset/244299
823
824 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
825
826         [WTF] StringBuilder should set correct m_is8Bit flag when merging
827         https://bugs.webkit.org/show_bug.cgi?id=197053
828
829         Reviewed by Saam Barati.
830
831         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
832         (TestWebKitAPI::TEST):
833
834 2019-04-17  Tim Horton  <timothy_horton@apple.com>
835
836         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
837         https://bugs.webkit.org/show_bug.cgi?id=197028
838         <rdar://problem/49985290>
839
840         Reviewed by Wenson Hsieh.
841
842         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
843         (TEST):
844         Liberal application of waitForNextPresentationUpdate works around a race
845         where if the page rapidly changes its viewport arguments (or an API client
846         rapidly changes its viewport arguments), we'd get stuck thinking that the
847         user had intentionally zoomed the page, and stop resetting the initial scale.
848         This deserves a separate bug, but no need to keep the test failing while
849         we think about it.
850
851 2019-04-17  Tim Horton  <timothy_horton@apple.com>
852
853         REGRESSION (r241988): Switching tabs is slow
854         https://bugs.webkit.org/show_bug.cgi?id=197037
855         <rdar://problem/49951473>
856
857         Reviewed by Simon Fraser.
858
859         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
860         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
861         (TEST):
862         * TestWebKitAPI/cocoa/TestWKWebView.h:
863         * TestWebKitAPI/cocoa/TestWKWebView.mm:
864         (-[TestWKWebView addToTestWindow]):
865         Add a test that hangs without this fix.
866
867 2019-04-17  Truitt Savell  <tsavell@apple.com>
868
869         Unreviewed, rolling out r244400.
870
871         Caused testing to exit early with assertionon Debug WK2
872
873         Reverted changeset:
874
875         "UI↔Web deadlock when printing with a JavaScript alert
876         visible"
877         https://bugs.webkit.org/show_bug.cgi?id=196839
878         https://trac.webkit.org/changeset/244400
879
880 2019-04-17  Brady Eidson  <beidson@apple.com>
881
882         Link clicks in PDFs shouldn't send referrer headers.
883         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
884
885         Reviewed by Tim Horton.
886
887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
888         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
889         (putPDFBytesCallback):
890         (emptyReleaseInfoCallback):
891         (createPDFWithLinkToURL):
892         (TEST):
893
894 2019-04-17  Tim Horton  <timothy_horton@apple.com>
895
896         UI↔Web deadlock when printing with a JavaScript alert visible
897         https://bugs.webkit.org/show_bug.cgi?id=196839
898         <rdar://problem/49157642>
899
900         Reviewed by Andy Estes.
901
902         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
903         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
904         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
905         (TEST):
906
907 2019-04-17  Alex Christensen  <achristensen@webkit.org>
908
909         WKRetainPtr's adoption constructor should be private
910         https://bugs.webkit.org/show_bug.cgi?id=197019
911
912         Reviewed by Tim Horton.
913
914         * DumpRenderTree/mac/DumpRenderTree.mm:
915         (dumpFramesAsText):
916         * TestWebKitAPI/InjectedBundleController.cpp:
917         (TestWebKitAPI::InjectedBundleController::initialize):
918         * TestWebKitAPI/PlatformUtilities.cpp:
919         (TestWebKitAPI::Util::createContextWithInjectedBundle):
920         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
921         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
922         (TestWebKitAPI::Util::toWK):
923         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
924         (TestWebKitAPI::TEST):
925         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
926         (TestWebKitAPI::TEST):
927         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
928         (TestWebKitAPI::TEST):
929         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
930         (TestWebKitAPI::TEST):
931         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
932         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
933         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
934         (TestWebKitAPI::TEST):
935         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
936         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
937         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
938         (TestWebKitAPI::TEST):
939         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
940         (TestWebKitAPI::TEST):
941         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
942         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
943         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
944         (TestWebKitAPI::TEST):
945         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
946         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
947         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
948         (TestWebKitAPI::TEST):
949         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
950         (TestWebKitAPI::TEST):
951         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
952         (TestWebKitAPI::TEST):
953         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
954         (TestWebKitAPI::TEST):
955         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
956         (TestWebKitAPI::TEST):
957         * TestWebKitAPI/Tests/WebKit/Find.cpp:
958         (TestWebKitAPI::TEST):
959         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
960         (TestWebKitAPI::TEST):
961         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
962         (TestWebKitAPI::TEST):
963         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
964         (TestWebKitAPI::TEST):
965         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
966         (TestWebKitAPI::TEST):
967         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
968         (TestWebKitAPI::TEST):
969         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
970         (TestWebKitAPI::TEST):
971         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
972         (TestWebKitAPI::TEST):
973         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
974         (TestWebKitAPI::TEST):
975         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
976         (TestWebKitAPI::TEST):
977         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
978         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
979         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
980         (TestWebKitAPI::TEST):
981         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
982         (TestWebKitAPI::TEST):
983         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
984         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
985         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
986         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
987         (TestWebKitAPI::TEST):
988         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
989         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
990         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
991         (TestWebKitAPI::TEST):
992         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
993         (TestWebKitAPI::TEST):
994         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
995         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
996         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
997         (TestWebKitAPI::TEST):
998         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
999         (TestWebKitAPI::loadAlternateHTMLString):
1000         (TestWebKitAPI::TEST):
1001         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1002         (TestWebKitAPI::TEST):
1003         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1004         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1005         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1006         (TestWebKitAPI::buildAndPerformTest):
1007         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1008         (TestWebKitAPI::TEST):
1009         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1010         (TestWebKitAPI::TEST):
1011         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1012         (TestWebKitAPI::TEST):
1013         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1014         (TestWebKitAPI::TEST):
1015         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1016         (TestWebKitAPI::TEST):
1017         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1018         (TestWebKitAPI::TEST):
1019         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1020         (TestWebKitAPI::TEST):
1021         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1022         (TestWebKitAPI::TEST):
1023         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1024         (TestWebKitAPI::TEST):
1025         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1026         (TestWebKitAPI::TEST):
1027         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1028         (TestWebKitAPI::TEST):
1029         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1030         (TestWebKitAPI::TEST):
1031         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1032         (TestWebKitAPI::TEST):
1033         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1034         (TestWebKitAPI::TEST):
1035         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1036         (TestWebKitAPI::TEST):
1037         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1038         (TestWebKitAPI::TEST):
1039         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1040         (TestWebKitAPI::TEST):
1041         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1042         (TestWebKitAPI::TEST):
1043         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1044         (TestWebKitAPI::TEST):
1045         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1046         (TestWebKitAPI::TEST):
1047         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1048         (TestWebKitAPI::TEST):
1049         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1050         (TestWebKitAPI::TEST):
1051         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1052         (TestWebKitAPI::TEST):
1053         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1054         (TestWebKitAPI::TEST):
1055         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1056         (TestWebKitAPI::TEST):
1057         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1058         (TestWebKitAPI::TEST):
1059         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1060         (TestWebKitAPI::TEST):
1061         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1062         (TestWebKitAPI::TEST):
1063         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1064         (TestWebKitAPI::TEST):
1065         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1066         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1067         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1068         (TestWebKitAPI::TEST):
1069         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1070         (TestWebKitAPI::TEST):
1071         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1072         (TestWebKitAPI::TEST):
1073         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1074         (TestWebKitAPI::TEST):
1075         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1076         (TestWebKitAPI::TEST):
1077         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1078         (TestWebKitAPI::TEST):
1079         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1080         (TestWebKitAPI::TEST):
1081         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1082         (TestWebKitAPI::TEST):
1083         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1084         (TestWebKitAPI::TEST):
1085         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1086         (TestWebKitAPI::TEST):
1087         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1088         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1089         (TEST):
1090         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1091         (TEST):
1092         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1093         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1094         (TEST):
1095         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1096         (TestWebKitAPI::TEST):
1097         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1098         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1099         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1100         (WTR::getMenuItemTitleCallback):
1101         (WTR::createMouseMessageBody):
1102         (WTR::EventSendingController::mouseDown):
1103         (WTR::EventSendingController::mouseUp):
1104         (WTR::EventSendingController::mouseMoveTo):
1105         (WTR::EventSendingController::mouseForceClick):
1106         (WTR::EventSendingController::startAndCancelMouseForceClick):
1107         (WTR::EventSendingController::mouseForceDown):
1108         (WTR::EventSendingController::mouseForceUp):
1109         (WTR::EventSendingController::mouseForceChanged):
1110         (WTR::EventSendingController::leapForward):
1111         (WTR::EventSendingController::scheduleAsynchronousClick):
1112         (WTR::createKeyDownMessageBody):
1113         (WTR::EventSendingController::keyDown):
1114         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1115         (WTR::EventSendingController::mouseScrollBy):
1116         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1117         (WTR::EventSendingController::continuousMouseScrollBy):
1118         (WTR::EventSendingController::addTouchPoint):
1119         (WTR::EventSendingController::updateTouchPoint):
1120         (WTR::EventSendingController::setTouchModifier):
1121         (WTR::EventSendingController::setTouchPointRadius):
1122         (WTR::EventSendingController::touchStart):
1123         (WTR::EventSendingController::touchMove):
1124         (WTR::EventSendingController::touchEnd):
1125         (WTR::EventSendingController::touchCancel):
1126         (WTR::EventSendingController::clearTouchPoints):
1127         (WTR::EventSendingController::releaseTouchPoint):
1128         (WTR::EventSendingController::cancelTouchPoint):
1129         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1130         (WTR::InjectedBundle::didCreatePage):
1131         (WTR::InjectedBundle::didReceiveMessage):
1132         (WTR::InjectedBundle::didReceiveMessageToPage):
1133         (WTR::InjectedBundle::booleanForKey):
1134         (WTR::InjectedBundle::done):
1135         (WTR::InjectedBundle::dumpToStdErr):
1136         (WTR::InjectedBundle::outputText):
1137         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1138         (WTR::InjectedBundle::postAddChromeInputField):
1139         (WTR::InjectedBundle::postRemoveChromeInputField):
1140         (WTR::InjectedBundle::postFocusWebView):
1141         (WTR::InjectedBundle::postSetBackingScaleFactor):
1142         (WTR::InjectedBundle::postSetWindowIsKey):
1143         (WTR::InjectedBundle::postSetViewSize):
1144         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1145         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1146         (WTR::InjectedBundle::setGeolocationPermission):
1147         (WTR::InjectedBundle::setMockGeolocationPosition):
1148         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1149         (WTR::InjectedBundle::isGeolocationProviderActive const):
1150         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1151         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1152         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1153         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1154         (WTR::InjectedBundle::setCustomPolicyDelegate):
1155         (WTR::InjectedBundle::setHidden):
1156         (WTR::InjectedBundle::setCacheModel):
1157         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1158         (WTR::InjectedBundle::processWorkQueue):
1159         (WTR::InjectedBundle::queueBackNavigation):
1160         (WTR::InjectedBundle::queueForwardNavigation):
1161         (WTR::InjectedBundle::queueLoad):
1162         (WTR::InjectedBundle::queueLoadHTMLString):
1163         (WTR::InjectedBundle::queueReload):
1164         (WTR::InjectedBundle::queueLoadingScript):
1165         (WTR::InjectedBundle::queueNonLoadingScript):
1166         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1167         (WTR::frameToStr):
1168         (WTR::InjectedBundlePage::InjectedBundlePage):
1169         (WTR::dumpFrameDescriptionSuitableForTestResult):
1170         (WTR::dumpFrameScrollPosition):
1171         (WTR::dumpDescendantFrameScrollPositions):
1172         (WTR::dumpFrameText):
1173         (WTR::dumpDescendantFramesText):
1174         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1175         (WTR::TestRunner::shouldDumpPixels const):
1176         (WTR::TestRunner::setDumpPixels):
1177         (WTR::TestRunner::whatToDump const):
1178         (WTR::TestRunner::setWhatToDump):
1179         (WTR::TestRunner::setWaitUntilDone):
1180         (WTR::TestRunner::shouldWaitUntilDone const):
1181         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1182         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1183         (WTR::TestRunner::clearAllDatabases):
1184         (WTR::TestRunner::setIDBPerOriginQuota):
1185         (WTR::TestRunner::originsWithApplicationCache):
1186         (WTR::TestRunner::setCanOpenWindows):
1187         (WTR::TestRunner::setXSSAuditorEnabled):
1188         (WTR::TestRunner::setMediaDevicesEnabled):
1189         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1190         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1191         (WTR::TestRunner::setCustomUserAgent):
1192         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1193         (WTR::TestRunner::setModernMediaControlsEnabled):
1194         (WTR::TestRunner::setWebGL2Enabled):
1195         (WTR::TestRunner::setWritableStreamAPIEnabled):
1196         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1197         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1198         (WTR::TestRunner::setAllowsAnySSLCertificate):
1199         (WTR::TestRunner::setPluginsEnabled):
1200         (WTR::TestRunner::setValueForUser):
1201         (WTR::TestRunner::setAudioResult):
1202         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1203         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1204         (WTR::TestRunner::setAlwaysAcceptCookies):
1205         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1206         (WTR::TestRunner::isDoingMediaCapture const):
1207         (WTR::TestRunner::queueLoad):
1208         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1209         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1210         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1211         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1212         (WTR::TestRunner::setAuthenticationUsername):
1213         (WTR::TestRunner::setAuthenticationPassword):
1214         (WTR::TestRunner::secureEventInputIsEnabled const):
1215         (WTR::TestRunner::setBlockAllPlugins):
1216         (WTR::TestRunner::setPluginSupportedMode):
1217         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1218         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1219         (WTR::TestRunner::setNavigationGesturesEnabled):
1220         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1221         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1222         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1223         (WTR::TestRunner::terminateNetworkProcess):
1224         (WTR::TestRunner::terminateServiceWorkerProcess):
1225         (WTR::TestRunner::runUIScript):
1226         (WTR::TestRunner::setStatisticsDebugMode):
1227         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1228         (WTR::TestRunner::setStatisticsLastSeen):
1229         (WTR::TestRunner::setStatisticsPrevalentResource):
1230         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1231         (WTR::TestRunner::dumpResourceLoadStatistics):
1232         (WTR::TestRunner::isStatisticsPrevalentResource):
1233         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1234         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1235         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1236         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1237         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1238         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1239         (WTR::TestRunner::setStatisticsGrandfathered):
1240         (WTR::TestRunner::isStatisticsGrandfathered):
1241         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1242         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1243         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1244         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1245         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1246         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1247         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1248         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1249         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1250         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1251         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1252         (WTR::TestRunner::statisticsSubmitTelemetry):
1253         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1254         (WTR::TestRunner::setStatisticsIsRunningTest):
1255         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1256         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1257         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1258         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1259         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1260         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1261         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1262         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1263         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1264         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1265         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1266         (WTR::TestRunner::statisticsResetToConsistentState):
1267         (WTR::TestRunner::setStorageAccessAPIEnabled):
1268         (WTR::TestRunner::getAllStorageAccessEntries):
1269         (WTR::TestRunner::addMockMediaDevice):
1270         (WTR::TestRunner::clearMockMediaDevices):
1271         (WTR::TestRunner::removeMockMediaDevice):
1272         (WTR::TestRunner::resetMockMediaDevices):
1273         (WTR::TestRunner::connectMockGamepad):
1274         (WTR::TestRunner::disconnectMockGamepad):
1275         (WTR::TestRunner::setMockGamepadDetails):
1276         (WTR::TestRunner::setMockGamepadAxisValue):
1277         (WTR::TestRunner::setMockGamepadButtonValue):
1278         (WTR::TestRunner::removeAllSessionCredentials):
1279         (WTR::TestRunner::clearDOMCache):
1280         (WTR::TestRunner::clearDOMCaches):
1281         (WTR::TestRunner::hasDOMCache):
1282         (WTR::TestRunner::domCacheSize):
1283         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1284         (WTR::TestRunner::getApplicationManifestThen):
1285         (WTR::TestRunner::injectUserScript):
1286         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1287         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1288         (WTR::TestRunner::addTestKeyToKeychain):
1289         (WTR::TestRunner::cleanUpKeychain):
1290         (WTR::TestRunner::keyExistsInKeychain):
1291         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1292         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1293         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1294         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1295         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1296         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1297         * WebKitTestRunner/TestController.cpp:
1298         (WTR::TestController::initialize):
1299         (WTR::parseStringTestHeaderValueAsRelativePath):
1300         (WTR::updateTestOptionsFromTestHeader):
1301         (WTR::TestController::runTest):
1302         (WTR::TestController::didReceiveLiveDocumentsList):
1303         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1304         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1305         (WTR::TestController::didFinishNavigation):
1306         (WTR::TestController::didReceiveAuthenticationChallenge):
1307         * WebKitTestRunner/TestInvocation.cpp:
1308         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1309         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1310         (WTR::TestInvocation::uiScriptDidComplete):
1311         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1312         * WebKitTestRunner/WebNotificationProvider.cpp:
1313         (WTR::WebNotificationProvider::closeWebNotification):
1314         * WebKitTestRunner/WorkQueueManager.cpp:
1315         (WTR::ScriptItem::ScriptItem):
1316         (WTR::WorkQueueManager::queueLoad):
1317         (WTR::WorkQueueManager::queueLoadHTMLString):
1318
1319 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1320
1321         Add a comment to make my test from r244139 less mysterious.
1322         https://bugs.webkit.org/show_bug.cgi?id=196744
1323
1324         As suggested by Darin Adler.
1325
1326         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1327         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1328
1329 2019-04-17  Chris Dumez  <cdumez@apple.com>
1330
1331         Remember device orientation permission for the duration of the browsing session
1332         https://bugs.webkit.org/show_bug.cgi?id=196992
1333         <rdar://problem/49946067>
1334
1335         Reviewed by Alex Christensen.
1336
1337         Add API test coverage.
1338
1339         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1340         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1341         (TEST):
1342
1343 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1344
1345         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1346         https://bugs.webkit.org/show_bug.cgi?id=196675
1347
1348         Reviewed by Lucas Forschler.
1349
1350         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1351         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
1352
1353 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1354
1355         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
1356         https://bugs.webkit.org/show_bug.cgi?id=196919
1357         <rdar://problem/41630459>
1358
1359         Reviewed by Tim Horton.
1360
1361         Add iOS support for several new testing hooks. See below for more detail.
1362
1363         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1364         (WTR::UIScriptController::isDismissingMenu const):
1365
1366         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
1367         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
1368         by UIKit when dismissing the callout bar (i.e. UIMenuController).
1369
1370         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1371         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1372         (WTR::UIScriptController::isDismissingMenu const):
1373         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1374         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1375         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1376         (WTR::InjectedBundle::didReceiveMessageToPage):
1377         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1378         (WTR::TestRunner::setAllowedMenuActions):
1379
1380         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
1381         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
1382         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
1383         against the name of the custom action.
1384
1385         (WTR::TestRunner::installCustomMenuAction):
1386
1387         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
1388         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
1389         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
1390         triggered.
1391
1392         (WTR::TestRunner::performCustomMenuAction):
1393
1394         Invoked when the custom menu action is triggered.
1395
1396         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1397         * WebKitTestRunner/TestController.cpp:
1398         (WTR::TestController::installCustomMenuAction):
1399         (WTR::TestController::setAllowedMenuActions):
1400         * WebKitTestRunner/TestController.h:
1401         * WebKitTestRunner/TestInvocation.cpp:
1402         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1403         (WTR::TestInvocation::performCustomMenuAction):
1404
1405         Add plumbing to call back into the injected bundle when performing the custom action.
1406
1407         * WebKitTestRunner/TestInvocation.h:
1408         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1409         (WTR::TestController::installCustomMenuAction):
1410         (WTR::TestController::setAllowedMenuActions):
1411         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1412         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1413         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1414         (-[TestRunnerWKWebView becomeFirstResponder]):
1415         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
1416
1417         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
1418         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
1419         in the Mail app on iOS.
1420
1421         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
1422         (-[TestRunnerWKWebView setAllowedMenuActions:]):
1423         (-[TestRunnerWKWebView resetCustomMenuAction]):
1424         (-[TestRunnerWKWebView performCustomAction:]):
1425         (-[TestRunnerWKWebView canPerformAction:withSender:]):
1426         (-[TestRunnerWKWebView _willHideMenu]):
1427         (-[TestRunnerWKWebView _didHideMenu]):
1428         * WebKitTestRunner/ios/TestControllerIOS.mm:
1429         (WTR::TestController::platformResetStateToConsistentValues):
1430
1431         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
1432         if specified.
1433
1434         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1435         (WTR::UIScriptController::isDismissingMenu const):
1436
1437 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
1438
1439         Allow sharing from imageSheet on an image document
1440         https://bugs.webkit.org/show_bug.cgi?id=196891
1441         <rdar://problem/25377386>
1442
1443         Reviewed by Tim Horton.
1444
1445         Test to make sure that the correct imageURL is extracted from an image element.
1446
1447         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1448         (TestWebKitAPI::TEST):
1449
1450 2019-04-16  Alex Christensen  <achristensen@webkit.org>
1451
1452         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
1453         https://bugs.webkit.org/show_bug.cgi?id=196995
1454
1455         Reviewed by Brady Eidson.
1456
1457         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1458         (TEST):
1459
1460 2019-04-16  Chris Dumez  <cdumez@apple.com>
1461
1462         URL set by document.open() is not communicated to the UIProcess
1463         https://bugs.webkit.org/show_bug.cgi?id=196941
1464         <rdar://problem/49237544>
1465
1466         Reviewed by Geoff Garen.
1467
1468         Add API test coverage.
1469
1470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1471         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1472         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1473         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1474         (TEST):
1475
1476 2019-04-16  Commit Queue  <commit-queue@webkit.org>
1477
1478         Unreviewed, rolling out r244321.
1479         https://bugs.webkit.org/show_bug.cgi?id=196968
1480
1481         Causing all WK2 Debug builds to exit early after Assertion
1482         failures. (Requested by ShawnRoberts on #webkit).
1483
1484         Reverted changeset:
1485
1486         "URL set by document.open() is not communicated to the
1487         UIProcess"
1488         https://bugs.webkit.org/show_bug.cgi?id=196941
1489         https://trac.webkit.org/changeset/244321
1490
1491 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1492
1493         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1494         https://bugs.webkit.org/show_bug.cgi?id=196948
1495
1496         Reviewed by Zalan Bujtas.
1497
1498         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1499         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
1500
1501 2019-04-15  Chris Dumez  <cdumez@apple.com>
1502
1503         URL set by document.open() is not communicated to the UIProcess
1504         https://bugs.webkit.org/show_bug.cgi?id=196941
1505         <rdar://problem/49237544>
1506
1507         Reviewed by Geoffrey Garen.
1508
1509         Add API test coverage.
1510
1511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1512         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1513         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1514         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1515         (TEST):
1516
1517 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
1518
1519         Using Tools/Scripts/clean-webkit should not install requests
1520         https://bugs.webkit.org/show_bug.cgi?id=196940
1521
1522         Reviewed by Lucas Forschler.
1523
1524         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
1525         existing, depending on the path autoinstalled is run through.
1526         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
1527         needed.
1528         (Port.configuration_for_upload):
1529         (Port.commits_for_upload):
1530
1531 2019-04-15  Alex Christensen  <achristensen@webkit.org>
1532
1533         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
1534         https://bugs.webkit.org/show_bug.cgi?id=196773
1535
1536         Reviewed by Jer Noble.
1537
1538         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
1539         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
1540         (TEST):
1541
1542 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1543
1544         ews-build should clearly indicate flaky test failures
1545         https://bugs.webkit.org/show_bug.cgi?id=196947
1546
1547         Reviewed by Lucas Forschler.
1548
1549         * BuildSlaveSupport/ews-build/steps.py:
1550         (AnalyzeAPITestsResults.analyzeResults):
1551
1552 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
1553
1554         InjectedBundle parameters often need initialization function called before unarchiving
1555         https://bugs.webkit.org/show_bug.cgi?id=189709
1556         <rdar://problem/44573653>
1557
1558         Reviewed by Ryosuke Niwa.
1559
1560         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1561         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1562
1563 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1564
1565         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
1566         https://bugs.webkit.org/show_bug.cgi?id=196681
1567
1568         Reviewed by Darin Adler.
1569
1570         Added tests.
1571
1572         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1573         (WTF_HashSet.RemoveIf):
1574         (WTF_HashSet.RemoveIfShrinkToBestSize):
1575
1576 2019-04-15  John Wilander  <wilander@apple.com>
1577
1578         Send delayed Ad Click Attribution conversion requests to the click source
1579         https://bugs.webkit.org/show_bug.cgi?id=196838
1580         <rdar://problem/47650157>
1581
1582         Reviewed by Chris Dumez and Youenn Fablet.
1583
1584         This patch adds test infrastructure to override the default behavior in
1585         WebKit::NetworkAdClickAttribution.
1586
1587         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1588         (TestWebKitAPI::TEST):
1589         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1590         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1591         (WTR::TestRunner::dumpAdClickAttribution):
1592         (WTR::TestRunner::clearAdClickAttribution):
1593         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1594         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1595         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1596         * WebKitTestRunner/TestController.cpp:
1597         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
1598         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
1599         * WebKitTestRunner/TestController.h:
1600         * WebKitTestRunner/TestInvocation.cpp:
1601         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1602
1603 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1604
1605         [ews-app] status-bubble should display position in queue
1606         https://bugs.webkit.org/show_bug.cgi?id=196607
1607
1608         Reviewed by Lucas Forschler.
1609
1610         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1611         (StatusBubble._build_bubble):
1612         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1613
1614 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1615
1616         [ews-build] Do not run clean build by default on EWS builders
1617         https://bugs.webkit.org/show_bug.cgi?id=196897
1618
1619         Reviewed by Lucas Forschler.
1620
1621         * BuildSlaveSupport/ews-build/steps.py:
1622         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1623         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1624         untracked directories like WebKitBuild).
1625         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1626         untracked files/directories (like WebKitBuild).
1627
1628 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1629
1630         TestRunner::notifyDone() should be safely reentrant
1631         https://bugs.webkit.org/show_bug.cgi?id=196898
1632
1633         Reviewed by Darin Adler.
1634
1635         It is currently possible that TestRunner::notifyDone() will call itself, since
1636         notifyDone() will force a repaint, which can start executing JavaScript, which
1637         may call notifyDone() again. This can lead to test failures and flakiness.
1638         Fix this by setting the m_waitToDump flag before calling the dump() method.
1639
1640         * DumpRenderTree/mac/TestRunnerMac.mm:
1641         (TestRunner::notifyDone):
1642         (TestRunner::forceImmediateCompletion):
1643         * DumpRenderTree/win/TestRunnerWin.cpp:
1644         (TestRunner::notifyDone):
1645         (TestRunner::forceImmediateCompletion):
1646
1647 2019-04-15  Philippe Normand  <pnormand@igalia.com>
1648
1649         [GTK][WPE] Add enable-media websetting
1650         https://bugs.webkit.org/show_bug.cgi?id=196863
1651
1652         Reviewed by Michael Catanzaro.
1653
1654         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1655         (testWebKitSettings): Add test for the enable-media web-setting.
1656
1657 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1658
1659         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1660         https://bugs.webkit.org/show_bug.cgi?id=196905
1661         <rdar://problem/49886096>
1662
1663         Reviewed by Tim Horton.
1664
1665         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1666         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1667         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1668         delay timer, we end up with this sequence of events in the problematic (failure) case:
1669
1670         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1671             ...IPC from UI to web process...
1672         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1673             ...IPC from web to UI process...
1674         (c) [UI]    Invoke completion handler for script #1
1675         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1676             ...IPC from UI to web process...
1677         (e) [Web]   Evaluate script #2 in the web process
1678         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1679
1680         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1681         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1682         #2 is run in step (e).
1683
1684         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1685         the UI process by waiting on a script message posted by the web process, after attachment updates are
1686         dispatched.
1687
1688         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1689         (TestWebKitAPI::TEST):
1690
1691 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1692
1693         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1694         https://bugs.webkit.org/show_bug.cgi?id=196909
1695
1696         Reviewed by Wenson Hsieh.
1697
1698         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1699         (TestWebKitAPI::TEST):
1700
1701 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1702
1703         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1704         https://bugs.webkit.org/show_bug.cgi?id=196880
1705
1706         Reviewed by Yusuke Suzuki.
1707
1708         Add a new function for bytecode cache tests that does not forceDiskCache
1709         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1710         test added in this patch, since the code is invalid and therefore won't be
1711         cached. It should also be useful for tests that evaluate dynamically
1712         generated code.
1713
1714         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1715         * Scripts/run-jsc-stress-tests:
1716
1717 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1718
1719         Update AudioSession route sharing policy
1720         https://bugs.webkit.org/show_bug.cgi?id=196776
1721         <rdar://problem/46501611>
1722
1723         Reviewed by Jer Noble.
1724
1725         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1726         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1727         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1728         (TestWebKitAPI::TEST):
1729
1730 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1731
1732         [iOS] Software keyboard is shown too frequently on some websites
1733         https://bugs.webkit.org/show_bug.cgi?id=195856
1734         <rdar://problem/49191395>
1735
1736         Reviewed by Darin Adler.
1737
1738         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1739
1740         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1741         (WTR::UIScriptController::setHardwareKeyboardAttached):
1742         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1743         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1744         (WTR::UIScriptController::setHardwareKeyboardAttached):
1745         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1746         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1747
1748         Additionally link against GraphicsServices in WebKitTestRunner.
1749
1750         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1751         (WTR::TestController::platformResetStateToConsistentValues):
1752         (WTR::UIScriptController::setHardwareKeyboardAttached):
1753
1754 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1755
1756         [GTK][WPE] Fix pacman install-dependencies packages
1757         https://bugs.webkit.org/show_bug.cgi?id=196817
1758
1759         Reviewed by Žan Doberšek.
1760         
1761         python3-setuptools is called python-setuptools
1762         ruby-highline is only available on AUR
1763         libv4l-devel is incorporated in v4l-utils
1764
1765         * gtk/install-dependencies:
1766         * wpe/install-dependencies:
1767
1768 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1769
1770         [GTK] REGRESSION(r243860): Many tests failing
1771         https://bugs.webkit.org/show_bug.cgi?id=196791
1772
1773         Reviewed by Joanmarie Diggs.
1774
1775         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1776         multiple documents and check that accessibility hierarchy is updated after a navigation.
1777
1778         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1779         (loadChangedCallback):
1780         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1781         (AccessibilityTest::AccessibilityTest):
1782         (AccessibilityTest::~AccessibilityTest):
1783         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1784         (AccessibilityTest::findTestServerApplication):
1785         (AccessibilityTest::findDocumentWeb):
1786         (AccessibilityTest::findRootObject):
1787         (AccessibilityTest::waitUntilChildrenRemoved):
1788         (AccessibilityTest::ensureProxy):
1789         (testAtspiBasicHierarchy):
1790         (beforeAll):
1791         (afterAll):
1792
1793 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1794
1795         [ews-build] Handle bug titles with unicode characters
1796         https://bugs.webkit.org/show_bug.cgi?id=196802
1797
1798         Reviewed by Dewei Zhu.
1799
1800         * BuildSlaveSupport/ews-build/steps.py:
1801         (ValidatePatch._is_bug_closed):
1802
1803 2019-04-11  Michael Saboff  <msaboff@apple.com>
1804
1805         Improve the Inline Cache Stats code
1806         https://bugs.webkit.org/show_bug.cgi?id=196836
1807
1808         Reviewed by Saam Barati.
1809
1810         Added a new script to consolidate and arrange the output of --useICStats option.
1811
1812         This script merges the output from every group into one large table and sorts it from most common to
1813         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1814         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1815         Put together, this is useful to see what property accesses are not getting cached.
1816
1817         * Scripts/ic-stats.py: Added.
1818         (ICStats):
1819         (ICStats.__init__):
1820         (ICStats.parse):
1821         (ICStats.dumpStats):
1822         (usage):
1823
1824 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1825
1826         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1827         https://bugs.webkit.org/show_bug.cgi?id=196809
1828         <rdar://49800762>
1829
1830         Reviewed by Brady Eidson.
1831
1832         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1833         (TEST):
1834
1835 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1836
1837         requestAnimationFrame should execute before the next frame
1838         https://bugs.webkit.org/show_bug.cgi?id=177484
1839
1840         Reviewed by Simon Fraser.
1841
1842         Add trace points for the page RenderingUpdate.
1843
1844         * Tracing/SystemTracePoints.plist:
1845
1846 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1847
1848         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1849         https://bugs.webkit.org/show_bug.cgi?id=196760
1850
1851         Reviewed by Don Olmstead.
1852
1853         vswhere.exe has been bundled since Visual Studio 2017 version
1854         15.2. We shouldn't download vswhere.exe.
1855
1856         * Scripts/build-jsc: Do not call update-vswhere.py.
1857         * Scripts/build-webkit: Ditto.
1858         * Scripts/update-vswhere.py: Removed.
1859         * Scripts/webkitdirs.pm:
1860         (requireModulesForVSWhere): Deleted.
1861         (pickCurrentVisualStudioInstallation): Deleted.
1862         (visualStudioInstallDirVSWhere): Return the latest installed VS
1863         installation path by using the bundled vswhere.exe.
1864         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1865         (visualStudioInstallDirFallback): Removed.
1866
1867 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1868
1869         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1870         https://bugs.webkit.org/show_bug.cgi?id=196780
1871
1872         Reviewed by Alexey Proskuryakov.
1873
1874         * BuildSlaveSupport/ews-build/steps.py:
1875         * BuildSlaveSupport/ews-build/steps_unittest.py:
1876
1877 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1878
1879         Add SPI WKNavigationResponse._downloadAttribute
1880         https://bugs.webkit.org/show_bug.cgi?id=196755
1881         <rdar://49587365>
1882
1883         Reviewed by Brady Eidson.
1884
1885         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1886         (-[NavigationResponseTestDelegate navigationResponse]):
1887         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1888         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1889         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1890         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1891         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1892         (readRequest):
1893         (writeResponse):
1894         (TEST):
1895
1896 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1897
1898         Add modern API for overriding the page's specified viewport configuration
1899         https://bugs.webkit.org/show_bug.cgi?id=167734
1900         <rdar://problem/30331795>
1901
1902         Reviewed by Simon Fraser.
1903
1904         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1905         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1906
1907 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1908
1909         Add support for incremental bytecode cache updates
1910         https://bugs.webkit.org/show_bug.cgi?id=195000
1911
1912         Reviewed by Filip Pizlo.
1913
1914         Exit when the initial run to generate bytecode fails.
1915
1916         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1917
1918 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1919
1920         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1921         https://bugs.webkit.org/show_bug.cgi?id=196744
1922         <rdar://49415309>
1923
1924         Reviewed by Chris Dumez.
1925
1926         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1927         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1928
1929 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1930
1931         Add a way to opt into modern compatibility mode in layout tests
1932         https://bugs.webkit.org/show_bug.cgi?id=196770
1933         <rdar://problem/49777550>
1934
1935         Reviewed by Antoine Quint.
1936
1937         Add a new test option to enable modern compatibility mode in layout tests.
1938
1939         * WebKitTestRunner/TestController.cpp:
1940         (WTR::updateTestOptionsFromTestHeader):
1941         * WebKitTestRunner/TestController.h:
1942         * WebKitTestRunner/TestOptions.h:
1943         (WTR::TestOptions::hasSameInitializationOptions const):
1944         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1945         (WTR::TestController::platformCreateWebView):
1946         (WTR::TestController::enableModernCompatibilityMode):
1947
1948 2019-04-10  Andy Estes  <aestes@apple.com>
1949
1950         Try to fix the 32-bit watchOS build.
1951
1952         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1953         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1954
1955 2019-04-10  Antoine Quint  <graouts@apple.com>
1956
1957         Enable Pointer Events on watchOS
1958         https://bugs.webkit.org/show_bug.cgi?id=196771
1959         <rdar://problem/49040909>
1960
1961         Reviewed by Dean Jackson.
1962
1963         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1964
1965 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1966
1967         Unreviewed. Fix WPE accessibility tests after r244059.
1968
1969         We are failing to load the injected bundle due to undefined symbol
1970         AccessibilityUIElement::replaceTextInRange().
1971
1972         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1973         (WTR::AccessibilityUIElement::replaceTextInRange):
1974
1975 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1976
1977         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1978         https://bugs.webkit.org/show_bug.cgi?id=196727
1979
1980         Reviewed by Fujii Hironori.
1981
1982         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1983         (WebKitBrowserWindow::create):
1984
1985 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1986
1987         [ews-build] Add unit tests for PrintConfiguration
1988         https://bugs.webkit.org/show_bug.cgi?id=196752
1989
1990         Reviewed by Dewei Zhu.
1991
1992         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1993
1994 2019-04-09  Keith Rollin  <krollin@apple.com>
1995
1996         Unreviewed build maintenance -- update .xcfilelists.
1997
1998         * DumpRenderTree/DerivedSources-input.xcfilelist:
1999         * DumpRenderTree/DerivedSources-output.xcfilelist:
2000
2001 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2002
2003         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2004         https://bugs.webkit.org/show_bug.cgi?id=196743
2005         <rdar://problem/43897551>
2006
2007         Reviewed by Tim Horton.
2008
2009         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2010         (TEST):
2011
2012 2019-04-09  Youenn Fablet  <youenn@apple.com>
2013
2014         Close service worker database on network process suspension
2015         https://bugs.webkit.org/show_bug.cgi?id=196623
2016         <rdar://problem/48930869>
2017
2018         Reviewed by Alex Christensen.
2019
2020         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2021
2022 2019-04-09  Daniel Bates  <dabates@apple.com>
2023
2024         [iPad] Should open popover when the spacebar is pressed
2025         https://bugs.webkit.org/show_bug.cgi?id=196360
2026         <rdar://problem/49389129>
2027
2028         Reviewed by Brent Fulgham.
2029
2030         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2031
2032         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2033         (WTR::UIScriptController::isShowingPopover const): Added.
2034         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2035         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2036         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2037         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2038         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2039         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2040         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2041         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2042         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2043         (WTR::UIScriptController::isShowingPopover const): Added.
2044         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2045         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2046         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2047         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2048         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2049         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2050         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2051         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2052         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2053         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2054         (WTR::UIScriptController::isShowingPopover const): Added.
2055         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2056         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2057
2058 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2059
2060         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2061         https://bugs.webkit.org/show_bug.cgi?id=196665
2062         <rdar://45115669>
2063
2064         Reviewed by Geoff Garen.
2065
2066         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2067         (goBack):
2068         (+[SimpleLookupContext sharedLookupContext]):
2069         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2070         (TEST):
2071         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2072         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2073
2074 2019-04-09  John Wilander  <wilander@apple.com>
2075
2076         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2077         https://bugs.webkit.org/show_bug.cgi?id=196558
2078         <rdar://problem/47650245>
2079
2080         Reviewed by Youenn Fablet.
2081
2082         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2083         (TestWebKitAPI::TEST):
2084             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2085
2086 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2087
2088         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2089         https://bugs.webkit.org/show_bug.cgi?id=196720
2090
2091         Reviewed by Konstantin Tokarev.
2092
2093         * TestWebKitAPI/PlatformMac.cmake:
2094
2095 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2096
2097         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2098         https://bugs.webkit.org/show_bug.cgi?id=196694
2099         <rdar://problem/48388734>
2100
2101         Rubber-stamped by Aakash Jain.
2102
2103         * Scripts/webkitpy/port/image_diff.py:
2104         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2105         * Scripts/webkitpy/port/server_process.py:
2106         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2107         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2108         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2109         * Scripts/webkitpy/port/server_process_mock.py:
2110         (MockServerProcess.has_available_stdout):
2111         * Scripts/webkitpy/port/server_process_unittest.py:
2112         (TestServerProcess.serial_test_basic):
2113
2114 2019-04-09  Jer Noble  <jer.noble@apple.com>
2115
2116         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2117         https://bugs.webkit.org/show_bug.cgi?id=196097
2118
2119         Reviewed by Eric Carlson.
2120
2121         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2122
2123         * DumpRenderTree/mac/DumpRenderTree.mm:
2124         (resetWebPreferencesToConsistentValues):
2125         * WebKitTestRunner/TestController.cpp:
2126         (WTR::TestController::resetPreferencesToConsistentValues):
2127
2128 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2129
2130         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2131         https://bugs.webkit.org/show_bug.cgi?id=196690
2132
2133         Reviewed by Michael Catanzaro.
2134
2135         * QueueStatusServer/config/queues.py:
2136         * Scripts/webkitpy/common/config/ews.json:
2137         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2138         (test_ews_name):
2139
2140 2019-04-09  Chris Dumez  <cdumez@apple.com>
2141
2142         Loads using loadHTMLString() cause flashing when process-swapping
2143         https://bugs.webkit.org/show_bug.cgi?id=196714
2144         <rdar://problem/49637354>
2145
2146         Reviewed by Antti Koivisto.
2147
2148         Add API test coverage.
2149
2150         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2151
2152 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2153
2154         Unreviewed. Fix ATK accessibility tests after r244059.
2155
2156         We are failing to load the injected bundle due to undefined symbol
2157         AccessibilityUIElement::replaceTextInRange().
2158
2159         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2160         (WTR::AccessibilityUIElement::replaceTextInRange):
2161
2162 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2163
2164         AX: Support API: accessibilityReplaceRange:withText
2165         https://bugs.webkit.org/show_bug.cgi?id=196636
2166
2167         Unreviewed build fix for Windows port.
2168
2169         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2170         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2171
2172 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2173
2174         [CMake][WinCairo] Separate copied headers into different directories
2175         https://bugs.webkit.org/show_bug.cgi?id=196655
2176
2177         Reviewed by Michael Catanzaro.
2178
2179         * DumpRenderTree/CMakeLists.txt:
2180         * MiniBrowser/win/CMakeLists.txt:
2181         * TestWebKitAPI/CMakeLists.txt:
2182         * TestWebKitAPI/PlatformWin.cmake:
2183
2184 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2185
2186         Log stack-trace for run-webkit-tests when interrupted
2187         https://bugs.webkit.org/show_bug.cgi?id=176393
2188         <rdar://problem/34262310>
2189
2190         Reviewed by Lucas Forschler.
2191
2192         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2193         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2194         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2195         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2196         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2197         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2198         (main): Set handlers to log stack trace on interruption.
2199
2200 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2201
2202         AX: Support API: accessibilityReplaceRange:withText
2203         https://bugs.webkit.org/show_bug.cgi?id=196636
2204
2205         Unreviewed build fix for Windows port.
2206
2207         * DumpRenderTree/AccessibilityUIElement.cpp:
2208         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2209
2210 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2211
2212         [ews-build] Scripts using Buildbot API have CORS error
2213         https://bugs.webkit.org/show_bug.cgi?id=196709
2214
2215         Reviewed by Alexey Proskuryakov.
2216
2217         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2218
2219 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2220
2221         AX: Support API: accessibilityReplaceRange:withText
2222         https://bugs.webkit.org/show_bug.cgi?id=196636
2223
2224         Reviewed by Daniel Bates.
2225
2226         * DumpRenderTree/AccessibilityUIElement.cpp:
2227         (replaceTextInRangeCallback):
2228         (AccessibilityUIElement::replaceTextInRange):
2229         (AccessibilityUIElement::getJSClass):
2230         * DumpRenderTree/AccessibilityUIElement.h:
2231         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2232         (AccessibilityUIElement::replaceTextInRange):
2233         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2234         (AccessibilityUIElement::replaceTextInRange):
2235         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2236         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2237         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2238         (WTR::AccessibilityUIElement::replaceTextInRange):
2239         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2240         (WTR::AccessibilityUIElement::replaceTextInRange):
2241
2242 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2243
2244         [iOS] Do not allow starting selection drags when selection views are not visible
2245         https://bugs.webkit.org/show_bug.cgi?id=196686
2246         <rdar://problem/49399192>
2247
2248         Reviewed by Tim Horton.
2249
2250         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2251         also add some new API tests to cover scenarios where the web view is not first responder.
2252
2253         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2254         (TestWebKitAPI::TEST):
2255         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2256
2257         Add a switch to optionally make the web view first responder when starting the simulated drag.
2258
2259         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2260         (-[DragAndDropSimulator initWithWebView:]):
2261         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2262
2263 2019-04-08  Justin Fan  <justin_fan@apple.com>
2264
2265         [Web GPU] Fix Web GPU experimental feature on iOS
2266         https://bugs.webkit.org/show_bug.cgi?id=196632
2267
2268         Reviewed by Myles C. Maxfield.
2269
2270         Properly make Web GPU available on iOS 11+.
2271
2272         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2273
2274 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2275
2276         [ews-build] Do not upload archive when Compile Fails
2277         https://bugs.webkit.org/show_bug.cgi?id=196674
2278
2279         Reviewed by Alexey Proskuryakov.
2280
2281         * BuildSlaveSupport/ews-build/factories.py:
2282         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2283         * BuildSlaveSupport/ews-build/steps.py:
2284         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2285         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2286         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2287
2288 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2289
2290         Enable DFG on MIPS
2291         https://bugs.webkit.org/show_bug.cgi?id=196689
2292
2293         Reviewed by Žan Doberšek.
2294
2295         Since the bytecode change, we enabled the baseline JIT on mips in
2296         r240432, but DFG is still missing. With this change, all tests are
2297         passing on a ci20 board.
2298
2299         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2300
2301 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2302
2303         [Flatpak] Second run update-webkitwpe-flatpak fails
2304         https://bugs.webkit.org/show_bug.cgi?id=192702
2305
2306         Reviewed by Carlos Garcia Campos.
2307
2308         * flatpak/flatpakutils.py:
2309         (FlatpakObject.flatpak): Fix typo.
2310         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2311         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2312
2313 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2314
2315         [GTK][WPE] outlook.live.com displays old-fashioned UI
2316         https://bugs.webkit.org/show_bug.cgi?id=196642
2317
2318         Reviewed by Carlos Garcia Campos.
2319
2320         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2321         (TestWebKitAPI::TEST): New Mac platform quirk test.
2322
2323 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2324
2325         Unreviewed, rolling out r243956.
2326         https://bugs.webkit.org/show_bug.cgi?id=196688
2327
2328         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2329         by aakashjain on #webkit).
2330
2331         Reverted changeset:
2332
2333         "Clicking "Go Back" from a safe browsing warning from an
2334         iframe should navigate the WKWebView back to the previous
2335         page"
2336         https://bugs.webkit.org/show_bug.cgi?id=196665
2337         https://trac.webkit.org/changeset/243956
2338
2339 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2340
2341         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2342         https://bugs.webkit.org/show_bug.cgi?id=196669
2343
2344         Reviewed by Geoffrey Garen.
2345
2346         Added three new unit tests for WeakHashSet.
2347
2348         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2349         (WTF_WeakPtr.WeakHashSetConstObjects):
2350         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2351         (WTF_WeakPtr.WeakHashSetComputeSize):
2352
2353 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2354
2355         Hide next and previous form control buttons when WKWebView is editable
2356         https://bugs.webkit.org/show_bug.cgi?id=196672
2357         <rdar://problem/35625321>
2358
2359         Reviewed by Tim Horton.
2360
2361         Add a new API test.
2362
2363         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2364         (-[TestWKWebView lastTrailingBarButtonGroup]):
2365         (TestWebKitAPI::TEST):
2366         * TestWebKitAPI/ios/UIKitSPI.h:
2367
2368 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2369
2370         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
2371         https://bugs.webkit.org/show_bug.cgi?id=196077
2372         <rdar://problem/49108202>
2373
2374         Reviewed by Chris Dumez.
2375
2376         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
2377         on new web view.
2378
2379         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2380
2381 2019-04-05  Saam Barati  <sbarati@apple.com>
2382
2383         Make compare-results understand MotionMark
2384         https://bugs.webkit.org/show_bug.cgi?id=196666
2385
2386         Reviewed by Yusuke Suzuki.
2387
2388         * Scripts/compare-results:
2389         (PLT5Results):
2390         (detectMotionMark):
2391         (detectMotionMark1_1):
2392         (motionMarkResults):
2393         (motionMark1_1Results):
2394         (detectBenchmark):
2395         (biggerIsBetter):
2396         (main):
2397
2398 2019-04-05  Alex Christensen  <achristensen@webkit.org>
2399
2400         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2401         https://bugs.webkit.org/show_bug.cgi?id=196665
2402         <rdar://45115669>
2403
2404         Reviewed by Geoff Garen.
2405
2406         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2407         (goBack):
2408         (+[SimpleLookupContext sharedLookupContext]):
2409         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2410         (TEST):
2411         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2412         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2413
2414 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
2415
2416         [ews-build] Add configuration and architecture for windows builders
2417         https://bugs.webkit.org/show_bug.cgi?id=196660
2418
2419         Reviewed by Lucas Forschler.
2420
2421         * BuildSlaveSupport/ews-build/config.json:
2422
2423 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
2424
2425         webkitpy: Don't run subsequent rounds if interrupted
2426         https://bugs.webkit.org/show_bug.cgi?id=196646
2427
2428         Reviewed by Aakash Jain.
2429
2430         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2431         (Manager.run): Bail out if interrupted.
2432
2433 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
2434
2435         Test sessionStorage in PSON private browsing mode
2436         https://bugs.webkit.org/show_bug.cgi?id=196561
2437
2438         Reviewed by Alex Christensen.
2439
2440         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2441
2442 2019-04-05  Commit Queue  <commit-queue@webkit.org>
2443
2444         Unreviewed, rolling out r243833.
2445         https://bugs.webkit.org/show_bug.cgi?id=196645
2446
2447         This change breaks build of WPE and GTK ports (Requested by
2448         annulen on #webkit).
2449
2450         Reverted changeset:
2451
2452         "[CMake][WTF] Mirror XCode header directories"
2453         https://bugs.webkit.org/show_bug.cgi?id=191662
2454         https://trac.webkit.org/changeset/243833
2455
2456 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
2457
2458         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
2459         https://bugs.webkit.org/show_bug.cgi?id=196635
2460
2461         Reviewed by Antti Koivisto.
2462         
2463         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
2464         for a test to enable async frame scrolling via:
2465             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
2466         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
2467         
2468         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
2469
2470         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2471         (WTR::InjectedBundle::beginTesting):
2472         * WebKitTestRunner/TestController.cpp:
2473         (WTR::TestController::resetPreferencesToConsistentValues):
2474
2475 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
2476
2477         Use a correct LC_RPATH when building with ASan
2478         https://bugs.webkit.org/show_bug.cgi?id=196576
2479
2480         Reviewed by David Kilzer.
2481
2482         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
2483         so that ../Frameworks is checked. This is simpler and more reliable than updating
2484         each SPC service xcconfig.
2485
2486 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2487
2488         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
2489         https://bugs.webkit.org/show_bug.cgi?id=196629
2490
2491         Reviewed by Lucas Forschler.
2492
2493         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2494
2495 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2496
2497         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
2498         https://bugs.webkit.org/show_bug.cgi?id=196618
2499
2500         Reviewed by Lucas Forschler.
2501
2502         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2503         (StatusBubble): Added QUEUE_TRIGGERS.
2504         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
2505         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
2506         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
2507         its parent(builder).
2508
2509 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2510
2511         [ews-app] Status-bubble steps are sometimes displayed in reverse order
2512         https://bugs.webkit.org/show_bug.cgi?id=196625
2513
2514         Reviewed by Lucas Forschler.
2515
2516         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2517         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
2518
2519 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2520
2521         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
2522         https://bugs.webkit.org/show_bug.cgi?id=196630
2523
2524         Reviewed by Wenson Hsieh.
2525
2526         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2527
2528 2019-04-04  Youenn Fablet  <youenn@apple.com>
2529
2530         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
2531         https://bugs.webkit.org/show_bug.cgi?id=196543
2532
2533         Reviewed by Alex Christensen.
2534
2535         * WebKitTestRunner/TestController.cpp:
2536         (WTR::TestController::generatePageConfiguration):
2537
2538 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2539
2540         [ews-app] Status bubble should not display skipped buildbot steps
2541         https://bugs.webkit.org/show_bug.cgi?id=196584
2542
2543         Reviewed by Lucas Forschler.
2544
2545         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2546
2547 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2548
2549         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
2550         https://bugs.webkit.org/show_bug.cgi?id=196620
2551
2552         Reviewed by Lucas Forschler.
2553
2554         * BuildSlaveSupport/ews-app/ews/config.py:
2555
2556 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
2557
2558         [Win] DumpRenderTreeWatchDog.py is not checked into source
2559         https://bugs.webkit.org/show_bug.cgi?id=196567
2560         <rdar://problem/49525901>
2561
2562         Reviewed by Lucas Forschler.
2563
2564         This script is used on Win EWS bots to terminate hanging DRT processes.
2565
2566         * EWSTools/dumprendertreewatchdog.py: Added.
2567
2568 2019-04-04  Chris Dumez  <cdumez@apple.com>
2569
2570         Unreviewed, roll out r243858 which made tests time out.
2571
2572         Disable new API tests on Windows instead.
2573
2574         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2575         (TestWebKitAPI::TEST):
2576
2577 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2578
2579         [ATK] Cleanup WebPageAccessibilityObjectAtk
2580         https://bugs.webkit.org/show_bug.cgi?id=196537
2581
2582         Reviewed by Michael Catanzaro.
2583
2584         Also consider files under atk directories as exceptions for GObject conventions.
2585
2586         * Scripts/webkitpy/style/checkers/cpp.py:
2587         (check_identifier_name_in_declaration):
2588
2589 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2590
2591         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2592         https://bugs.webkit.org/show_bug.cgi?id=196588
2593         <rdar://problem/49365787>
2594
2595         Unreviewed build fix for Windows port.
2596
2597         error C3861: 'kill': identifier not found
2598
2599         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2600         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2601
2602 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2603
2604         [ews-build] Cancel build and similar operations should have authentication
2605         https://bugs.webkit.org/show_bug.cgi?id=196520
2606
2607         Reviewed by Dewei Zhu.
2608
2609         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2610         environment variables.
2611
2612 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2613
2614         [ews-build] Do not trigger queues which are not in production yet
2615         https://bugs.webkit.org/show_bug.cgi?id=196581
2616
2617         Reviewed by Dewei Zhu.
2618
2619         * BuildSlaveSupport/ews-build/config.json:
2620
2621 2019-04-03  Chris Dumez  <cdumez@apple.com>
2622
2623         Unreviewed, fix typo in the name of API test added in r243848.
2624
2625         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2626         (TestWebKitAPI::TEST):
2627
2628 2019-04-03  Chris Dumez  <cdumez@apple.com>
2629
2630         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2631         https://bugs.webkit.org/show_bug.cgi?id=196588
2632         <rdar://problem/49365787>
2633
2634         Reviewed by Ryosuke Niwa.
2635
2636         Add API test coverage.
2637
2638         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2639         (TestWebKitAPI::nullJavaScriptCallback):
2640         (TestWebKitAPI::didCrashCheckFrames):
2641         (TestWebKitAPI::TEST):
2642
2643 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2644
2645         run-webkit-tests: Upload test results (new results database)
2646         https://bugs.webkit.org/show_bug.cgi?id=196577
2647         <rdar://problem/34841155>
2648
2649         Reviewed by Lucas Forschler.
2650
2651         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2652         (Manager.run): Upload results after each device shard, since the configuration will be
2653         different for each device.
2654         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2655         uploaded to a results database.
2656         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2657         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2658
2659 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2660
2661         -apple-trailing-word is needed for browser detection
2662         https://bugs.webkit.org/show_bug.cgi?id=196575
2663
2664         Unreviewed.
2665
2666         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2667
2668 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2669
2670         [CMake][WTF] Mirror XCode header directories
2671         https://bugs.webkit.org/show_bug.cgi?id=191662
2672
2673         Reviewed by Konstantin Tokarev.
2674
2675         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2676         builds.
2677
2678         * CMakeLists.txt:
2679         * DumpRenderTree/CMakeLists.txt:
2680         * DumpRenderTree/PlatformWin.cmake:
2681         * MiniBrowser/win/CMakeLists.txt:
2682         * TestWebKitAPI/CMakeLists.txt:
2683         * TestWebKitAPI/PlatformWin.cmake:
2684         * WebKitTestRunner/PlatformGTK.cmake:
2685         * WebKitTestRunner/PlatformWin.cmake:
2686
2687 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2688
2689         [ews-app] Status bubble should not display certain infrastructure status messages
2690         https://bugs.webkit.org/show_bug.cgi?id=196550
2691
2692         Reviewed by Lucas Forschler.
2693
2694         Do not display the steps which are un-needed for end-user. This information is still avaiable
2695         if the user click on the bubble and look at the Buildbot build.
2696         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2697         (StatusBubble._steps_messages):
2698         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2699
2700 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2701
2702         [ews-build] Use https for sending data to ews-app
2703         https://bugs.webkit.org/show_bug.cgi?id=196492
2704
2705         Reviewed by Lucas Forschler.
2706
2707         * BuildSlaveSupport/ews-build/events.py:
2708
2709 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2710
2711         Remove support for -apple-trailing-word
2712         https://bugs.webkit.org/show_bug.cgi?id=196525
2713
2714         Reviewed by Zalan Bujtas.
2715
2716         This CSS property is nonstandard and not used.
2717
2718         * Scripts/webkitperl/FeatureList.pm:
2719         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2720
2721 2019-04-03  Youenn Fablet  <youenn@apple.com>
2722
2723         Add a test for DOMCache on multiple browsing in case of private browsing
2724         https://bugs.webkit.org/show_bug.cgi?id=196524
2725
2726         Reviewed by Alex Christensen.
2727
2728         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2729         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2730
2731 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2732
2733         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2734         https://bugs.webkit.org/show_bug.cgi?id=196540
2735
2736         Reviewed by Aakash Jain.
2737
2738         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2739
2740 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2741
2742         Add plumbing for a compatibility mode preference in WebKit
2743         https://bugs.webkit.org/show_bug.cgi?id=196005
2744
2745         Reviewed by Tim Horton.
2746
2747         Add new API tests.
2748
2749         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2750         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2751
2752 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2753
2754         [WPE][GTK] Update libsrtp dependency package for Debian
2755         https://bugs.webkit.org/show_bug.cgi?id=196528
2756
2757         Reviewed by Frédéric Wang.
2758
2759         * gtk/install-dependencies:
2760         * wpe/install-dependencies:
2761
2762 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2763
2764         [WK2] Add support for Window's beforeprint / afterprint events
2765         https://bugs.webkit.org/show_bug.cgi?id=196478
2766         <rdar://problem/49535124>
2767
2768         Unreviewed build fix for MSVC.
2769
2770         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2771
2772         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2773
2774         * WebKitTestRunner/TestController.cpp:
2775         (WTR::printFrame): Use int and float literals.
2776
2777 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2778
2779         [ews-build] Reassign bots to queues
2780
2781         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2782
2783 2019-04-02  Chris Dumez  <cdumez@apple.com>
2784
2785         [WK2] Add support for Window's beforeprint / afterprint events
2786         https://bugs.webkit.org/show_bug.cgi?id=196478
2787
2788         Reviewed by Alex Christensen.
2789
2790         Add minimal implementation for printFrame in WebKitTestRunner.
2791
2792         * WebKitTestRunner/TestController.cpp:
2793         (WTR::printFrame):
2794         (WTR::TestController::createOtherPage):
2795         (WTR::TestController::createWebViewWithOptions):
2796
2797 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2798
2799         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2800         https://bugs.webkit.org/show_bug.cgi?id=196491
2801
2802         Reviewed by Lucas Forschler.
2803
2804         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2805
2806 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2807
2808         [ews-build] Configure buildbot try credentials in environment variables
2809         https://bugs.webkit.org/show_bug.cgi?id=196501
2810
2811         Reviewed by Lucas Forschler.
2812
2813         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2814         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2815         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2816
2817 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2818
2819         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2820         https://bugs.webkit.org/show_bug.cgi?id=196496
2821         <rdar://problem/49521634>
2822
2823         Reviewed by Chris Dumez.
2824
2825         Add new API tests (see WebKit ChangeLog for more detail).
2826
2827         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2828         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2829         (TEST):
2830
2831 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2832
2833         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2834         <https://webkit.org/b/196499>
2835
2836         Reviewed by Alexey Proskuryakov.
2837
2838         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2839         ENABLE_ADDRESS_SANITIZER.
2840
2841 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2842
2843         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2844         https://bugs.webkit.org/show_bug.cgi?id=182757
2845
2846         Reviewed by Don Olmstead.
2847
2848         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2849         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2850
2851 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2852
2853         run-api-tests: Upload test results
2854         https://bugs.webkit.org/show_bug.cgi?id=196323
2855         <rdar://problem/49356714>
2856
2857         Reviewed by Lucas Forschler.
2858
2859         * Scripts/webkitpy/api_tests/manager.py:
2860         (Manager):
2861         (Manager.run): Upload results to a results database.
2862         * Scripts/webkitpy/api_tests/run_api_tests.py:
2863         (parse_args): Add upload arguments.
2864         * Scripts/webkitpy/port/base.py:
2865         (Port):
2866         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2867         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2868         with commits from any other associated repositories.
2869         * Scripts/webkitpy/port/device.py:
2870         (Device):
2871         (Device.build_version): Access build_versoin of underlying platform device.
2872         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2873         (IOSSimulatorTest):
2874         (IOSSimulatorTest.test_configuration_for_upload):
2875         * Scripts/webkitpy/port/device_port.py:
2876         (DevicePort):
2877         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2878         the same as the machine uploading results.
2879         * Scripts/webkitpy/port/mac.py:
2880         (MacPort):
2881         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2882         * Scripts/webkitpy/port/mac_unittest.py:
2883         (MacTest):
2884         (MacTest.test_configuration_for_upload):
2885         * Scripts/webkitpy/xcode/simulated_device.py:
2886         (SimulatedDeviceManager._create_device_with_runtime):
2887         (SimulatedDevice.__init__): Create simulated device with a build_version.
2888         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2889         (test_existing_simulator):
2890
2891 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2892
2893         Remove extra newline characters (Follow-up fix to r243707)
2894
2895         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2896
2897 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2898
2899         [ews-app] Use API_KEY to accept results data
2900         https://bugs.webkit.org/show_bug.cgi?id=196461
2901
2902         Reviewed by Dewei Zhu.
2903
2904         * BuildSlaveSupport/ews-app/ews/views/results.py:
2905         (Results.post): Validate EWS_API_KEY before accepting any data.
2906         * BuildSlaveSupport/ews-build/events.py:
2907         (Events.sendData): Send EWS_API_KEY if available along with event data.
2908
2909 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2910
2911         Unable to copy and paste a PDF from Notes into Mail compose body
2912         https://bugs.webkit.org/show_bug.cgi?id=196442
2913         <rdar://problem/48573098>
2914
2915         Reviewed by Tim Horton.
2916
2917         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2918         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2919         to be specified on the item providers.
2920
2921         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2922         (TestWebKitAPI::mapItemForTesting):
2923         (TestWebKitAPI::contactItemForTesting):
2924
2925 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2926
2927         Make UIWKDocumentContext rects per-character instead of per-word
2928         https://bugs.webkit.org/show_bug.cgi?id=196459
2929
2930         Reviewed by Wenson Hsieh.
2931
2932         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2933         (TEST):
2934         Adjust test results due to switching to per-character rects.
2935
2936 2019-04-01  Chris Dumez  <cdumez@apple.com>
2937
2938         UIProcess crash when a prewarmed process is terminated
2939         https://bugs.webkit.org/show_bug.cgi?id=196451
2940         <rdar://problem/49245471>
2941
2942         Reviewed by Geoffrey Garen.
2943
2944         Add API test coverage.
2945
2946         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2947         (TEST):
2948
2949 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2950
2951         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2952         https://bugs.webkit.org/show_bug.cgi?id=196449
2953
2954         Reviewed by Lucas Forschler.
2955
2956         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2957         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2958         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2959         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2960
2961 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2962
2963         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2964         https://bugs.webkit.org/show_bug.cgi?id=196444
2965
2966         Reviewed by Lucas Forschler.
2967
2968         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2969
2970 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2971
2972         Add SPI to canonicalize NSURLs with WTF::URL
2973         https://bugs.webkit.org/show_bug.cgi?id=196415
2974         <rdar://problem/44980271>
2975
2976         Reviewed by Darin Adler.
2977
2978         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2979         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2980         (TestWebKitAPI::TEST):
2981
2982 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2983
2984         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2985         https://bugs.webkit.org/show_bug.cgi?id=196441
2986
2987         Reviewed by Carlos Garcia Campos.
2988
2989         Don't cache the wpe_view_backend object that might not exist yet at the
2990         time of EventSenderProxy constructor invocation, but instead retrieve
2991         that object whenever it's required for event dispatching. This should
2992         avoid crashes in this constructor now that it's invoked before any
2993         PlatformWindow has been set up (as changed in r243496).
2994
2995         * WebKitTestRunner/EventSenderProxy.h:
2996         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2997         (WTR::viewBackend):
2998         (WTR::EventSenderProxy::EventSenderProxy):
2999         (WTR::EventSenderProxy::mouseDown):
3000         (WTR::EventSenderProxy::mouseUp):
3001         (WTR::EventSenderProxy::mouseMoveTo):
3002         (WTR::EventSenderProxy::mouseScrollBy):
3003         (WTR::EventSenderProxy::keyDown):
3004         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3005
3006 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3007
3008         [Win][WebKit] MiniBrowser should support high DPI display
3009         https://bugs.webkit.org/show_bug.cgi?id=196391
3010
3011         Reviewed by Alex Christensen.
3012
3013         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3014         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3015         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3016         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3017
3018 2019-03-31  Sam Weinig  <weinig@apple.com>
3019
3020         Remove more i386 specific configurations
3021         https://bugs.webkit.org/show_bug.cgi?id=196430
3022
3023         Reviewed by Alexey Proskuryakov.
3024
3025         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3026         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3027
3028 2019-03-31  Andy Estes  <aestes@apple.com>
3029
3030         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3031         https://bugs.webkit.org/show_bug.cgi?id=196433
3032         <rdar://problem/49293305>
3033
3034         Reviewed by Tim Horton.
3035
3036         Enhanced API test coverage to include all navigation response policy decisions in both
3037         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3038
3039         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3040         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3041         (TestWebKitAPI::TEST):
3042         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3043         (readFile):
3044         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3045         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3046         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3047         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3048         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3049         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3050         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3051         (-[QuickLookDelegate _downloadDidStart:]):
3052         (-[QuickLookDelegate _download:didReceiveResponse:]):
3053         (-[QuickLookDelegate _download:didReceiveData:]):
3054         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3055         (-[QuickLookDelegate _downloadDidFinish:]):
3056         (-[QuickLookDelegate _download:didFailWithError:]):
3057         (-[QuickLookDelegate _downloadDidCancel:]):
3058         (-[QuickLookDelegate verifyDownload]):
3059         (runTest):
3060         (runTestDecideBeforeLoading):
3061         (runTestDecideAfterLoading):
3062         (TEST):
3063         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3064         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3065         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3066         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3067         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3068         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3069         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3070         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3071         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3072         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3073         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3074         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3075         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3076         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3077
3078 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3079
3080         [CMake] add testdfg as target with build-jsc
3081         https://bugs.webkit.org/show_bug.cgi?id=196393
3082
3083         Reviewed by Saam Barati.
3084
3085         Added testdfg as one of the targets to build when
3086         using CMake.
3087
3088         * Scripts/build-jsc:
3089
3090 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3091
3092         Delete WebMetal implementation in favor of WebGPU
3093         https://bugs.webkit.org/show_bug.cgi?id=195418
3094
3095         Reviewed by Dean Jackson.
3096
3097         * DumpRenderTree/mac/DumpRenderTree.mm:
3098         (enableExperimentalFeatures):
3099         (resetWebPreferencesToConsistentValues):
3100         * Scripts/webkitperl/FeatureList.pm:
3101         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3102         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3103         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3104         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3105         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3106         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3107         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3108         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3109         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3110         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3111         (WTR::InjectedBundle::beginTesting):
3112         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3113         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3114         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3115
3116 2019-03-29  Chris Dumez  <cdumez@apple.com>
3117
3118         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3119         https://bugs.webkit.org/show_bug.cgi?id=196405
3120         <rdar://problem/49428130>
3121
3122         Reviewed by Wenson Hsieh.
3123
3124         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3125         the popover presentation methods to be no-ops. Use this in the new test added in
3126         r243523 so that we do not swizzle those methods for all tests. This is needed because
3127         those WatchOS tests rely on the popover getting presented and interactive.
3128
3129         * WebKitTestRunner/TestController.cpp:
3130         (WTR::updateTestOptionsFromTestHeader):
3131         * WebKitTestRunner/TestController.h:
3132         * WebKitTestRunner/TestOptions.h:
3133         (WTR::TestOptions::hasSameInitializationOptions const):
3134         * WebKitTestRunner/ios/TestControllerIOS.mm:
3135         (WTR::TestController::platformInitialize):
3136         (WTR::TestController::platformResetStateToConsistentValues):
3137
3138 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3139
3140         [Curl] Add Server Trust Evaluation Support.
3141         https://bugs.webkit.org/show_bug.cgi?id=191646
3142
3143         Reviewed by Fujii Hironori.
3144
3145         Implemented MiniBrowser UI for asking if user trusts the server.
3146
3147         * MiniBrowser/win/Common.cpp:
3148         (askServerTrustEvaluation):
3149         (replaceString):
3150         * MiniBrowser/win/Common.h:
3151         * MiniBrowser/win/MiniBrowserLib.rc:
3152         * MiniBrowser/win/MiniBrowserLibResource.h:
3153         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3154         (createPEMString):
3155         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3156         (WebKitBrowserWindow::canTrustServerCertificate):
3157         * MiniBrowser/win/WebKitBrowserWindow.h:
3158
3159 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3160
3161         Implement ResizeObserver.
3162         https://bugs.webkit.org/show_bug.cgi?id=157743
3163
3164         Reviewed by Simon Fraser.
3165
3166         Support resizeObserverEnabled webPreferences.
3167
3168         * DumpRenderTree/TestOptions.cpp:
3169         (TestOptions::TestOptions):
3170         * DumpRenderTree/TestOptions.h:
3171         * DumpRenderTree/mac/DumpRenderTree.mm:
3172         (setWebPreferencesForTestOptions):
3173         * DumpRenderTree/win/DumpRenderTree.cpp:
3174         (enableExperimentalFeatures):
3175         * Scripts/webkitperl/FeatureList.pm:
3176         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3177
3178 2019-03-28  John Wilander  <wilander@apple.com>
3179
3180         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3181         https://bugs.webkit.org/show_bug.cgi?id=196281
3182         <rdar://problem/48938748>
3183
3184         Reviewed by Alex Christensen.
3185
3186         This patch adds the function isStatisticsHasLocalStorage() to the
3187         TestRunner. With it, the page can query the WebsiteDataStore in the
3188         UI process to make sure that it sees LocalStorage.
3189
3190         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3191         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3192         (WTR::TestRunner::isStatisticsHasLocalStorage):
3193         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3194         * WebKitTestRunner/TestController.cpp:
3195         (WTR::TestController::isStatisticsHasLocalStorage):
3196         * WebKitTestRunner/TestController.h:
3197         * WebKitTestRunner/TestInvocation.cpp:
3198         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3199
3200 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3201
3202         API::Data::createWithoutCopying should do a null check before calling CFRelease
3203         https://bugs.webkit.org/show_bug.cgi?id=196276
3204         <rdar://problem/48059859>
3205
3206         Reviewed by Alex Christensen.
3207
3208         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3209
3210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3211         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3212         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3213         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3214         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3215         (TestWebKitAPI::TEST):
3216
3217 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3218
3219         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3220         https://bugs.webkit.org/show_bug.cgi?id=186276
3221
3222         Reviewed by Carlos Garcia Campos.
3223
3224         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3225         (webViewLoadChanged):
3226         (testWebResourceGetDataError):
3227         (testWebResourceGetDataEmpty):
3228         (beforeAll):
3229         (webViewloadChanged): Deleted.
3230
3231 2019-03-27  Andy Estes  <aestes@apple.com>
3232
3233         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3234         https://bugs.webkit.org/show_bug.cgi?id=196317
3235
3236         Reviewed by Dan Bernstein.
3237
3238         package-root copies built products into a staging directory using ditto(1), which does not
3239         follow symbolic links as it traverses a directory. Now that the files in
3240         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3241         itself, these become broken links when ditto'd into the staging directory.
3242
3243         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3244
3245         * Scripts/package-root:
3246
3247 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3248
3249         [ews-app] Update display text of Submit for ews analysis
3250         https://bugs.webkit.org/show_bug.cgi?id=196309
3251
3252         Reviewed by Dewei Zhu.
3253
3254         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3255
3256 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3257
3258         run-webkit-tests should check for leaks in WebKit processes
3259         <https://webkit.org/b/193772>
3260         <rdar://problem/46526680>
3261
3262         Reviewed by Ryosuke Niwa.
3263
3264         This works by doing the following:
3265         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3266           The list of child processes are returned one per line:
3267           process.name: pid
3268         - Run the "#LIST CHILD PROCESSES" command just before the
3269           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3270           processes on the ServerProcess object.
3271         - When the `--leaks` switch is handled, run check_for_leaks() on
3272           each child process after the main test harness.
3273
3274         * DumpRenderTree/mac/DumpRenderTree.mm:
3275         (handleControlCommand):
3276         - Use strncmp() instead of strcmp().
3277         - Add support for handling "#LIST CHILD PROCESSES" command.
3278
3279         * Scripts/webkitpy/port/base.py:
3280         (Port.check_for_leaks):
3281         * Scripts/webkitpy/port/darwin.py:
3282         (DarwinPort.check_for_leaks):
3283         - Rename redundant 'process_pid' argument to 'process_id'.
3284
3285         * Scripts/webkitpy/port/driver.py:
3286         (Driver.do_post_tests_work):
3287         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3288           longer the only command this sends to WebKitTestRunner.
3289         - If the `--leaks` switch is present, send the
3290           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3291           result using Port.set_webkit_processes().
3292         (Driver._parse_child_processes_output):
3293         - Add helper method to parse list of child process names and
3294           process IDs returned from WebKitTestRunner.
3295
3296         * Scripts/webkitpy/port/ios_device.py:
3297         (IOSDevicePort.check_for_leaks):
3298         - Rename redundant 'process_pid' argument to 'process_id'.
3299
3300         * Scripts/webkitpy/port/leakdetector.py:
3301         (LeakDetector._parse_leaks_output):
3302         - Return early if there is no leaks_output.
3303         (LeakDetector.check_for_leaks):
3304         - Rename redundant 'process_pid' argument to 'process_id'.
3305
3306         * Scripts/webkitpy/port/server_process.py:
3307         (ServerProcess.__init__):
3308         (ServerProcess.child_processes):
3309         (ServerProcess.set_child_processes):
3310         - Add instance variable to Port to store list of child process
3311           names and process IDs returned from WebKitTestRunner.
3312         (ServerProcess._start):
3313         - Clear self._child_processes.
3314         (ServerProcess.stop):
3315         - If self._child_processes is set, call
3316           self._port.check_for_leaks() for each child process.
3317
3318         * Scripts/webkitpy/port/server_process_unittest.py:
3319         (TrivialMockPort.check_for_leaks):
3320         - Rename redundant 'process_pid' argument to 'process_id'.
3321
3322         * Scripts/webkitpy/port/simulator_process.py:
3323         (SimulatorProcess.stop):
3324         - If self._child_processes is set, call
3325           self._port.check_for_leaks() for each child process.
3326
3327         * Scripts/webkitpy/port/watch_device.py:
3328         (WatchDevicePort.check_for_leaks):
3329         - Rename redundant 'process_pid' argument to 'process_id'.
3330
3331         * WebKitTestRunner/TestController.cpp:
3332         (WTR::TestController::dumpResponse):
3333         - Extract method from findAndDumpWorldLeaks() so that it may be
3334           reused by findAndDumpWebKitProcessIdentifiers().
3335         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3336         - Add method to output process name and process ID of both the
3337           WebContent and Networking processes.
3338         (WTR::TestController::findAndDumpWorldLeaks):
3339         - Fix missing newline in output when there were no abandoned
3340           documents.
3341         - Call dumpResponse() for extracted code.
3342         (WTR::TestController::handleControlCommand):
3343         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3344         - Use strncmp() instead of strcmp().
3345         - Call findAndDumpWebKitProcessIdentifiers() when
3346           "#LIST CHILD PROCESSES" command is sent.
3347         * WebKitTestRunner/TestController.h:
3348         (WTR::TestController::dumpResponse):
3349         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3350         - Declare methods.
3351
3352 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3353
3354         Unreviewed. Add GLib API test cases after r243434.
3355
3356         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3357         (testWebViewActiveURI):
3358         (serverCallback):
3359         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3360         (sendRequestCallback):
3361
3362 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3363
3364         Geolocation request not complete when watch request was started in a different web process
3365         https://bugs.webkit.org/show_bug.cgi?id=195996
3366
3367         Reviewed by Alex Christensen.
3368
3369         Add a test case.
3370
3371         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3372         (TestWebKitAPI::runJavaScriptAlert):
3373         (TestWebKitAPI::TEST):
3374
3375 2019-03-26  Keith Rollin  <krollin@apple.com>
3376
3377         Update the way generate-xcfilelists returns strings from functions
3378         https://bugs.webkit.org/show_bug.cgi?id=195975
3379         <rdar://problem/49040807>
3380
3381         Reviewed by Dean Jackson.
3382
3383         There are places where generate-xcfilelists executes assignments with
3384         statements like:
3385
3386             FOO=$(some_function)
3387
3388         where "some_function" return a string by echoing it. E.g.
3389
3390             some_function()
3391             {
3392                 echo "Hello, World"
3393             }
3394
3395         This is a common idiom, but it has a problem if "some_function" needs
3396         to call "exit" in an attempt to halt the entire script right then and
3397         there. Since "some_function" is called inside of $(), it's being
3398         executed in a sub-shell. Calling exit in that sub-shell simply exits
3399         that shell; it doesn't not exit the outer shell in which the main part
3400         of the script is still running. As such, the main script keeps
3401         executing when the intent was for the script to halt.
3402
3403         The solution to this is to use a different idiom for returning
3404         strings. The one we now is to pass in the name of the variable to
3405         receive the string result:
3406
3407             some_function()
3408             {
3409                 variable_name=$1
3410                 eval $variable_name ="Hello, World"
3411             }
3412
3413         The call site now looks like
3414
3415             some_function FOO
3416
3417         Because there's no invocation of a sub-shell, some_function can now
3418         call "exit" if it wants to, and the entire script will exit at that
3419         point.
3420
3421         * Scripts/generate-xcfilelists:
3422
3423 2019-03-26  Chris Dumez  <cdumez@apple.com>
3424
3425         Add basic layout test coverage for File Picker on iOS
3426         https://bugs.webkit.org/show_bug.cgi?id=196265
3427
3428         Reviewed by Wenson Hsieh.
3429
3430         Add layout test infrastructure to test the file picker on iOS.
3431
3432         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3433         (WTR::UIScriptController::dismissFilePicker):
3434         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3435         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3436         (WTR::UIScriptController::dismissFilePicker):
3437         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3438         * WebKitTestRunner/TestController.cpp:
3439         (WTR::TestController::createWebViewWithOptions):
3440         (WTR::updateTestOptionsFromTestHeader):
3441         * WebKitTestRunner/TestOptions.h:
3442         (WTR::TestOptions::hasSameInitializationOptions const):
3443         * WebKitTestRunner/ios/TestControllerIOS.mm:
3444         (overridePresentViewController):
3445         (WTR::TestController::platformInitialize):
3446         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3447         (WTR::UIScriptController::dismissFilePicker):
3448
3449 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3450
3451         Implement async paste method on UIWKInteractionViewProtocol
3452         https://bugs.webkit.org/show_bug.cgi?id=196267
3453         <rdar://problem/49236346>
3454
3455         Reviewed by Tim Horton.
3456
3457         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
3458         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
3459         are now a part of all iOS 12 internal SDKs.
3460
3461         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3462
3463         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
3464         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
3465
3466         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3467         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3468         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
3469         * TestWebKitAPI/ios/UIKitSPI.h:
3470
3471 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3472
3473         [ews-build] Use PostgreSQL for ews.webkit.org database
3474         https://bugs.webkit.org/show_bug.cgi?id=196270
3475
3476         Reviewed by Lucas Forschler.
3477
3478         * BuildSlaveSupport/ews-app/ews-app/settings.py:
3479
3480 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
3481
3482         [ews] Reset simctl states on reboot
3483         https://bugs.webkit.org/show_bug.cgi?id=196260
3484
3485         Rubber-stamped by Aakash Jain.
3486
3487         * EWSTools/start-queue-mac.sh:
3488
3489 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3490
3491         [ews-build] Use PostgreSQL for ews-build database
3492         https://bugs.webkit.org/show_bug.cgi?id=196229
3493
3494         Reviewed by Lucas Forschler.
3495
3496         * BuildSlaveSupport/ews-build/master.cfg:
3497
3498 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3499
3500         [ews-build] Get master_hostname dynamically in master.cfg
3501         https://bugs.webkit.org/show_bug.cgi?id=196255
3502
3503         Reviewed by Lucas Forschler.
3504
3505         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
3506         send events data in test mode.
3507
3508 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3509
3510         [ews-app] Set db_constraint to False for Foreign Keys
3511         https://bugs.webkit.org/show_bug.cgi?id=196252
3512
3513         Reviewed by Lucas Forschler.
3514
3515         * BuildSlaveSupport/ews-app/ews/models/build.py:
3516         * BuildSlaveSupport/ews-app/ews/models/step.py:
3517
3518 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3519
3520         [ews-build] is_test_mode_enabled should default to True
3521         https://bugs.webkit.org/show_bug.cgi?id=196248
3522
3523         Reviewed by Lucas Forschler.
3524
3525         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
3526
3527 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3528
3529         [ews-app] Add webkitperl to ENABLED_QUEUES
3530         https://bugs.webkit.org/show_bug.cgi?id=196253
3531
3532         Reviewed by Lucas Forschler.
3533
3534         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3535
3536 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
3537
3538         Address NSWindow sometimes using WebKitTestRunnerEvent too early
3539         https://bugs.webkit.org/show_bug.cgi?id=196211
3540         rdar://problem/49110552
3541
3542         Reviewed by Tim Horton.
3543
3544         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
3545         Make sure that EventSenderProxy always exists when running tests. We used to create
3546         it when resetting before the first test, which is a bit too late.
3547
3548         * WebKitTestRunner/TestController.h:
3549         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3550         (WTR::TestController::platformCreateWebView):
3551         (WTR::TestController::platformCreateOtherPage):
3552         (WTR::TestController::finishCreatingPlatformWebView):
3553         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3554         (WTR::PlatformWebView::PlatformWebView):
3555         Moved some code that made NSWindow use NSEvent during web view creation. We may
3556         need to move more if some other case us found, but this is enough for now.
3557
3558 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3559
3560         Unreviewed. Fix typo in GLib geolocation API after r243285.
3561
3562         gelocation -> geolocation.
3563
3564         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
3565         (testGeolocationManagerWatchPosition):
3566
3567 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3568
3569         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3570         https://bugs.webkit.org/show_bug.cgi?id=196213
3571
3572         Reviewed by Geoff Garen.
3573
3574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3575         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3576         (credentialWithIdentityAndKeychainPath):
3577         (-[ChallengeDelegate webView:didFinishNavigation:]):
3578         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3579         (TestWebKitAPI::TEST):
3580
3581 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3582
3583         Expected shouldn't assume its contained types are copyable
3584         https://bugs.webkit.org/show_bug.cgi?id=195986
3585
3586         Reviewed by JF Bastien.
3587
3588         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3589         (TestWebKitAPI::NonCopyable::operator== const):
3590         (TestWebKitAPI::NonCopyable::operator!= const):
3591         (TestWebKitAPI::TEST):
3592
3593 2019-03-25  Tim Horton  <timothy_horton@apple.com>
3594
3595         Remove some now-unnecessary dynamic class lookup
3596         https://bugs.webkit.org/show_bug.cgi?id=196237
3597
3598         Reviewed by Simon Fraser.
3599
3600         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3601         (makeRequest):
3602         (TEST):
3603
3604 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
3605
3606         Unreviewed, rolling out r243450.
3607
3608         AppleWin and WinCairo port builds get broken.
3609
3610         Reverted changeset:
3611
3612         "Add test for fix of #196095"
3613         https://bugs.webkit.org/show_bug.cgi?id=196097
3614         https://trac.webkit.org/changeset/243450
3615
3616 2019-03-25  Commit Queue  <commit-queue@webkit.org>
3617
3618         Unreviewed, rolling out r243465.
3619         https://bugs.webkit.org/show_bug.cgi?id=196226
3620
3621         the test doesn't build (Requested by thorton on #webkit).
3622
3623         Reverted changeset:
3624
3625         "Do not terminate the NetworkProcess if a third party
3626         application sends a NSCredential with a SecIdentityRef"
3627         https://bugs.webkit.org/show_bug.cgi?id=196213
3628         https://trac.webkit.org/changeset/243465
3629
3630 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3631
3632         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3633         https://bugs.webkit.org/show_bug.cgi?id=196213
3634
3635         Reviewed by Geoff Garen.
3636
3637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3638         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3639         (credentialWithIdentityAndKeychainPath):
3640         (-[ChallengeDelegate webView:didFinishNavigation:]):
3641         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3642         (TestWebKitAPI::TEST):
3643
3644 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3645
3646         [ews-build] Gracefully handle missing patch_id in events
3647         https://bugs.webkit.org/show_bug.cgi?id=196216
3648
3649         Reviewed by Lucas Forschler.
3650
3651         * BuildSlaveSupport/ews-build/events.py:
3652
3653 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3654
3655         [ews-build] use lz4 compression for improving buildbot performance
3656         https://bugs.webkit.org/show_bug.cgi?id=196155
3657
3658         Reviewed by Lucas Forschler.
3659
3660         * BuildSlaveSupport/ews-build/master.cfg:
3661
3662 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3663
3664         Pull some API testing helper methods out of TestWKWebView
3665         https://bugs.webkit.org/show_bug.cgi?id=196212
3666
3667         Reviewed by Tim Horton.
3668
3669         Refactor some more API testing utility methods, so that they can be used in
3670         tests that do not use TestWKWebView.
3671
3672         * TestWebKitAPI/cocoa/TestWKWebView.h:
3673         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3674         (-[WKWebView loadTestPageNamed:]):
3675         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
3676         (-[WKWebView synchronouslyLoadHTMLString:]):
3677         (-[WKWebView synchronouslyLoadTestPageNamed:]):
3678         (-[TestWKWebView loadTestPageNamed:]): Deleted.
3679         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
3680         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
3681         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
3682
3683 2019-03-25  Jer Noble  <jer.noble@apple.com>
3684
3685         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3686         https://bugs.webkit.org/show_bug.cgi?id=196097
3687
3688         Reviewed by Eric Carlson.
3689
3690         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3691
3692         * DumpRenderTree/mac/DumpRenderTree.mm:
3693         (resetWebPreferencesToConsistentValues):
3694         * WebKitTestRunner/TestController.cpp:
3695         (WTR::TestController::resetPreferencesToConsistentValues):
3696
3697 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3698
3699         Pull IPadUserInterfaceSwizzler out into a separate header file
3700         https://bugs.webkit.org/show_bug.cgi?id=196193
3701
3702         Reviewed by Anders Carlsson.
3703
3704         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
3705         be used in other API tests.
3706
3707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3708         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3709         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
3710         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
3711         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
3712         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3713         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3714
3715 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3716
3717         Remove NavigatorContentUtils in WebCore/Modules
3718         https://bugs.webkit.org/show_bug.cgi?id=196070
3719
3720         Reviewed by Alex Christensen.
3721
3722         NavigatorContentUtils was to support the custom scheme spec [1].
3723         However, in WebKit side, no port has supported the feature in
3724         WebKit layer after EFL port was removed. So there has been the
3725         only IDL implementation of the NavigatorContentUtils in WebCore.
3726         So we don't need to keep the implementation in WebCore anymore.
3727
3728         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
3729
3730         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3731
3732 2019-03-24  Andy Estes  <aestes@apple.com>
3733
3734         [watchOS] Remove unused Proximity Networking code
3735         https://bugs.webkit.org/show_bug.cgi?id=196188
3736
3737         Reviewed by Tim Horton.
3738
3739         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3740         (TEST):
3741
3742 2019-03-23  Keith Miller  <keith_miller@apple.com>
3743
3744         Refactor clz/ctz and fix getLSBSet.
3745         https://bugs.webkit.org/show_bug.cgi?id=196162
3746
3747         Reviewed by Saam Barati.
3748
3749         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3750
3751         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3752         (TestWebKitAPI::TEST):
3753
3754 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3755
3756         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3757         https://bugs.webkit.org/show_bug.cgi?id=196143
3758
3759         Reviewed by Michael Catanzaro.
3760
3761         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3762         directories.
3763
3764         * Scripts/webkitpy/style/checkers/cpp.py:
3765         (check_identifier_name_in_declaration):
3766         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3767         (WebKitStyleTest.test_names):
3768
3769 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3770
3771         [Flatpak] Manifest expanding fails for qt WPE extension
3772         https://bugs.webkit.org/show_bug.cgi?id=196148
3773
3774         Reviewed by Alex Christensen.
3775
3776         * flatpak/flatpakutils.py:
3777         (expand_submodules_recurse): The last recurse manifest expand
3778         iteration might lead to a single module so take it into account
3779         and don't try to recurse further.
3780
3781 2019-03-22  Chris Dumez  <cdumez@apple.com>
3782
3783         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3784         https://bugs.webkit.org/show_bug.cgi?id=195348
3785         <rdar://problem/48622090>
3786
3787         Reviewed by Alex Christensen.
3788
3789         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3790         to NO when test.options().shouldIgnoreMetaViewport is false.
3791
3792         * WebKitTestRunner/ios/TestControllerIOS.mm:
3793         (WTR::TestController::platformConfigureViewForTest):
3794
3795 2019-03-22  Chris Dumez  <cdumez@apple.com>
3796
3797         Prewarmed processes should be usable with any website data store
3798         https://bugs.webkit.org/show_bug.cgi?id=196104
3799
3800         Reviewed by Alex Christensen.
3801
3802         Add API test coverage.
3803
3804         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3805         (runInitialWarmedProcessUsedTest):
3806         (TEST):
3807
3808 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3809
3810         Back out local changes to Alex's Subversion working directory
3811
3812         They were accidentally committed.
3813
3814         * Scripts/webkitpy/common/system/abstractexecutive.py:
3815         (AbstractExecutive.wait_newest):
3816         * Scripts/webkitpy/common/system/executive.py:
3817         (Executive.running_pids):
3818         * Scripts/webkitpy/common/system/executive_mock.py:
3819         (MockExecutive.running_pids):
3820         * Scripts/webkitpy/common/system/executive_unittest.py:
3821         (ExecutiveTest.serial_test_running_pids):
3822         * Scripts/webkitpy/port/darwin.py:
3823         (DarwinPort.check_for_leaks):
3824         * Scripts/webkitpy/port/leakdetector.py:
3825         (LeakDetector.check_for_leaks):
3826         - This was the hack attached to Bug 193772.
3827
3828         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3829         (+[WebKitTestRunnerEvent mouseLocation]):
3830         - This works around a crash on an internal build.
3831
3832 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3833
3834         Fix the build after r243354
3835         https://bugs.webkit.org/show_bug.cgi?id=196138
3836         <rdar://problem/49145951>
3837
3838         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3839         (TEST):
3840         * TestWebKitAPI/ios/UIKitSPI.h:
3841
3842 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3843
3844         Adopt UIWKDocumentContext
3845         https://bugs.webkit.org/show_bug.cgi?id=196040
3846         <rdar://problem/48642440>
3847
3848         Reviewed by Ryosuke Niwa.
3849
3850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3851         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3852         (makeRequest):
3853         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3854         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3855         (applyStyle):
3856         (TEST):
3857         Add tests for UIWKDocumentContext.
3858
3859         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3860         (TEST):
3861         (recursiveFindWKContentView): Deleted.
3862         * TestWebKitAPI/cocoa/TestWKWebView.h:
3863         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3864         (recursiveFindWKContentView):
3865         (-[TestWKWebView wkContentView]):
3866         * TestWebKitAPI/ios/UIKitSPI.h:
3867         Share the WKContentView finding code between tests.
3868
3869 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3870
3871         [iOS WK2] Turn on async overflow scrolling by default
3872         https://bugs.webkit.org/show_bug.cgi?id=196011
3873         rdar://problem/48453859
3874
3875         Reviewed by Antti Koivisto.
3876         
3877         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3878         since so many basic layout tests have different results when compositing is triggered for
3879         overflow.
3880         
3881         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3882
3883         * WebKitTestRunner/TestController.cpp:
3884         (WTR::TestController::resetPreferencesToConsistentValues):
3885
3886 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3887
3888         [ews-build] Retry API test in case of failures
3889         https://bugs.webkit.org/show_bug.cgi?id=196004
3890
3891         Reviewed by Lucas Forschler.
3892
3893         * BuildSlaveSupport/ews-build/steps.py:
3894         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3895         (CompileWebKitToT.doStepIf): Ditto.
3896         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3897         (ReRunAPITests): Re-run API tests.
3898         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3899         (RunAPITestsWithoutPatch): Run API tests without patch.
3900         (RunAPITestsWithoutPatch.doStepIf):
3901         (RunAPITestsWithoutPatch.hideStepIf):
3902         (RunAPITestsWithoutPatch.evaluateCommand):
3903         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3904         (AnalyzeAPITestsResults.start):
3905         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3906         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3907         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3908         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3909
3910 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3911
3912         [ews-build] Update queues configurations
3913         https://bugs.webkit.org/show_bug.cgi?id=196074
3914
3915         Reviewed by Dewei Zhu.
3916
3917         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3918         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3919
3920 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3921
3922         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3923         https://bugs.webkit.org/show_bug.cgi?id=195680
3924         <rdar://problem/48903534>
3925
3926         Unreviewed infrastructure fix.
3927
3928         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3929         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3930
3931 2019-03-21  Andy Estes  <aestes@apple.com>
3932
3933         [iOS] Apple Pay should be available in documents with no user agent scripts
3934         https://bugs.webkit.org/show_bug.cgi?id=196061
3935         <rdar://problem/48649391>
3936
3937         Reviewed by Brady Eidson.
3938
3939         Added API tests and related infrastructure.
3940
3941         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3942         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3943         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3944         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3945         (TestWebKitAPI::TEST):
3946         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3947         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3948         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3949         * TestWebKitAPI/cocoa/TestProtocol.mm:
3950         (-[TestProtocol startLoading]):
3951         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3952         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3953         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3954         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3955
3956 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3957
3958         REGRESSSION (r243297): webkitpy tests broken
3959         https://bugs.webkit.org/show_bug.cgi?id=196108
3960
3961         Reviewed by Aakash Jain.
3962
3963         r243297 updated contributors.json, which broke a few unit tests.
3964
3965         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3966         (IRCCommandTest.test_whois):
3967         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3968
3969 2019-03-21  Chris Dumez  <cdumez@apple.com>
3970
3971         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3972         https://bugs.webkit.org/show_bug.cgi?id=196041
3973         <rdar://problem/49083230>
3974
3975         Reviewed by Alex Christensen.
3976
3977         Add API test coverage.
3978
3979         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3980         (TEST):
3981
3982 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3983
3984         Add SPI to inform applications of WKContentRuleList actions
3985         https://bugs.webkit.org/show_bug.cgi?id=195965
3986         <rdar://problem/42664365>
3987
3988         Reviewed by Geoff Garen.
3989
3990         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3991         (TestWebKitAPI::allActionsForResourceLoad):
3992         (TestWebKitAPI::testRequest):
3993         (TestWebKitAPI::TEST_F):
3994         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3995         (Notification::description):
3996         (Notification::operator== const):
3997         (toVector):
3998         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3999         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
4000         (makeContentRuleList):
4001         (TEST):
4002         (makeWarnContentRuleList): Deleted.
4003
4004 2019-03-21  Timothy Hatcher  <timothy@apple.com>
4005
4006         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
4007         https://bugs.webkit.org/show_bug.cgi?id=196088
4008
4009         Reviewed by Brian Burg.
4010
4011         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
4012         Support checks when only one platform is specified. Also deprecate macosx() and
4013         force the use of macos() instead.
4014
4015         * Scripts/webkitpy/style/checkers/cpp.py:
4016         (check_min_versions_of_wk_api_available):
4017         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4018         (WebKitStyleTest.test_min_versions_of_wk_api_available):
4019
4020 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
4021
4022         Update status inactive committers' status to 'contributor'.
4023
4024         * Scripts/webkitpy/common/config/contributors.json:
4025
4026 2019-03-21  Xan Lopez  <xan@igalia.com>
4027
4028         [JSC][x86] Drop support for x87 floating point
4029         https://bugs.webkit.org/show_bug.cgi?id=194853
4030
4031         Reviewed by Don Olmstead.
4032
4033         Force SSE2 on x86/32bit builds.
4034
4035         * Scripts/webkitdirs.pm:
4036         (generateBuildSystemFromCMakeProject):
4037
4038 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
4039
4040         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
4041         https://bugs.webkit.org/show_bug.cgi?id=196073
4042
4043         Reviewed by Michael Catanzaro.
4044
4045         Add test cases to check functions and constructors with no arguments but receiving user data.
4046
4047         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4048         (checkUserData):
4049         (testJSCFunction):
4050         (fooCreateWithUserData):
4051         (testJSCClass):
4052
4053 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
4054
4055         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
4056
4057         Add g_assert_cmpfloat_with_epsilon macro if not defined.
4058
4059         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4060
4061 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
4062
4063         [GTK][WPE] Add API to provide geolocation information
4064         https://bugs.webkit.org/show_bug.cgi?id=195940
4065
4066         Reviewed by Michael Catanzaro.
4067
4068         Add a new test to check the new API.
4069
4070         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
4071         (testGeolocationManagerCurrentPosition):
4072         (testGeolocationManagerWatchPosition):
4073         (beforeAll):
4074         (afterAll):
4075         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
4076         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
4077         (beforeAll): Ditto.
4078         * TestWebKitAPI/glib/CMakeLists.txt:
4079
4080 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
4081
4082         [GLib] Returning G_TYPE_OBJECT from a method does not work
4083         https://bugs.webkit.org/show_bug.cgi?id=195574
4084
4085         Reviewed by Michael Catanzaro.
4086
4087         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
4088
4089         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4090         (getGFile):
4091         (getParent):
4092         (createGString):
4093         (getGString):
4094         (getGStringCopyWillRaise):
4095         (getGStringCopy):
4096         (getGStringStr):
4097         (getGStringLen):
4098         (freeGString):
4099         (testJSCClass):
4100
4101 2019-03-20  Saam Barati  <sbarati@apple.com>
4102
4103         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
4104         https://bugs.webkit.org/show_bug.cgi?id=195721
4105
4106         Reviewed by Filip Pizlo.
4107
4108         * Scripts/run-javascriptcore-tests:
4109
4110 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
4111
4112         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
4113         https://bugs.webkit.org/show_bug.cgi?id=196049
4114
4115         Reviewed by Tim Horton.
4116
4117         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
4118         overflow scrolling in general, so rename it.
4119
4120         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4121
4122 2019-03-20  Daniel Bates  <dabates@apple.com>
4123
4124         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
4125         https://bugs.webkit.org/show_bug.cgi?id=196031
4126         <rdar://problem/49078172>
4127
4128         Reviewed by Tim Horton.
4129
4130         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
4131         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
4132         same code path used when the Done button is pressed to dismiss the <select> picker.
4133
4134         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
4135         (TestWebKitAPI::TEST):
4136
4137 2019-03-20  Chris Dumez  <cdumez@apple.com>
4138
4139         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
4140         https://bugs.webkit.org/show_bug.cgi?id=196029
4141         <rdar://problem/48954651>
4142
4143         Reviewed by Tim Horton.
4144
4145         Add API test coverage.
4146
4147         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4148
4149 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
4150
4151         [ews-build] Improve failure summary string for ApplyPatch step
4152         https://bugs.webkit.org/show_bug.cgi?id=195995
4153
4154         Reviewed by Alexey Proskuryakov.
4155
4156         * BuildSlaveSupport/ews-build/steps.py:
4157         (ApplyPatch.getResultSummary): Override getResultSummary.
4158
4159 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
4160
4161         AX: Implement support for new meter ARIA role
4162         https://bugs.webkit.org/show_bug.cgi?id=195966
4163
4164         Reviewed by Chris Fleizach.
4165
4166         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
4167         to AXLevelIndicator.
4168
4169         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4170
4171 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
4172
4173         [WebAuthN] Implement FIDO AppID extension
4174         https://bugs.webkit.org/show_bug.cgi?id=143491
4175         <rdar://problem/48298273>
4176
4177         Reviewed by Brent Fulgham.
4178
4179         Add a test that covers the new flag of convertToU2fSignCommand.
4180
4181         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
4182         (TestWebKitAPI::TEST):
4183         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
4184         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
4185         (TestWebKitAPI::TEST):
4186
4187 2019-03-19  Keith Rollin  <krollin@apple.com>
4188
4189         Add support for more platforms to generate-xcfilelists
4190         https://bugs.webkit.org/show_bug.cgi?id=195977
4191
4192         Reviewed by Alexey Proskuryakov.
4193
4194         generate-xcfilelists incorrectly complains when involved with building
4195         WebKit for iphonesimulator:
4196
4197             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
4198             …
4199             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
4200
4201         Address this by teaching generate-xcfilelists about more platforms.
4202
4203         * Scripts/generate-xcfilelists:
4204
4205 2019-03-19  John Wilander  <wilander@apple.com>
4206
4207         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
4208         https://bugs.webkit.org/show_bug.cgi?id=195923
4209         <rdar://problem/49001272>
4210
4211         Reviewed by Alex Christensen.
4212
4213         This patch does the following to the TestRunner:
4214         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
4215         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
4216         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
4217
4218         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4219         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4220         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
4221         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4222         * WebKitTestRunner/TestController.cpp:
4223         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
4224         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
4225         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
4226         * WebKitTestRunner/TestController.h:
4227         * WebKitTestRunner/TestInvocation.cpp:
4228         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4229
4230 2019-03-19  Christopher Reid  <chris.reid@sony.com>
4231
4232         [CMake] Support more clang and gcc sanitizers
4233         https://bugs.webkit.org/show_bug.cgi?id=195956
4234
4235         Reviewed by Michael Catanzaro.
4236
4237         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
4238
4239 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
4240
4241         [ews-build] Improve summary for PrintConfiguration step
4242         https://bugs.webkit.org/show_bug.cgi?id=195945
4243
4244         Reviewed by Lucas Forschler.
4245
4246         * BuildSlaveSupport/ews-build/steps.py:
4247         (PrintConfiguration.getResultSummary): Override getResultSummary.
4248
4249 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
4250
4251         [ews-build] Improve summary for CheckOutSource step
4252         https://bugs.webkit.org/show_bug.cgi?id=195963
4253
4254         Reviewed by Lucas Forschler.
4255
4256         * BuildSlaveSupport/ews-build/steps.py:
4257         (CheckOutSource.getResultSummary):
4258
4259 2019-03-19  Daniel Bates  <dabates@apple.com>
4260
4261         [iOS] Focus not preserved when switching between tabs
4262         https://bugs.webkit.org/show_bug.cgi?id=195820
4263         <rdar://problem/43614450>
4264
4265         Reviewed by Brent Fulgham.
4266
4267         Add tests to ensure that we restore focus when resigning and becoming first responder.
4268
4269         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4270         (TestWebKitAPI::TEST):
4271
4272 2019-03-19  Alex Christensen  <achristensen@webkit.org>
4273
4274         Make WTFLogChannelState and WTFLogLevel enum classes
4275         https://bugs.webkit.org/show_bug.cgi?id=195904
4276
4277         Reviewed by Eric Carlson.
4278
4279         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
4280         (TestWebKitAPI::TEST_F):
4281
4282 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
4283
4284         [GStreamer][EME] Backported mssdemux protection data crash fix
4285         https://bugs.webkit.org/show_bug.cgi?id=195918
4286
4287         Reviewed by Philippe Normand.
4288
4289         * gstreamer/jhbuild.modules:
4290         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
4291
4292 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
4293
4294         Unreviewed, rolling out r243132.
4295
4296         Broke GTK build
4297
4298         Reverted changeset:
4299
4300         "Make WTFLogChannelState and WTFLogLevel enum classes"
4301         https://bugs.webkit.org/show_bug.cgi?id=195904
4302         https://trac.webkit.org/changeset/243132
4303
4304 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
4305
4306         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
4307
4308         * Scripts/webkitdirs.pm:
4309         (builtDylibPathForName): Adjust the shared library name that's changed
4310         with the API version bump in r243073.
4311
4312 2019-03-18  Alex