Unreviewed, rolling out r240209.
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         Unreviewed, rolling out r240209.
4
5         Broke GTK/WPE injected bundle
6
7         Reverted changeset:
8
9         "AX: Support returning relative frames for accessibility"
10         https://bugs.webkit.org/show_bug.cgi?id=193414
11         https://trac.webkit.org/changeset/240209
12
13 2019-01-12  Dan Bernstein  <mitz@apple.com>
14
15         [Cocoa] Avoid importing directly from subumbrella frameworks
16         https://bugs.webkit.org/show_bug.cgi?id=186016
17         <rdar://problem/40591038>
18
19         Reviewed by Sam Weinig.
20
21         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
22           LaunchServices header.
23         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
24           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
25         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
26           when using SDKs earlier than 10.13.
27         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
28           and OTHER_CPLUSPLUSFLAGS.
29         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
30           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
31         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
32           LaunchServices header.
33
34 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
35
36         Cache bytecode to disk
37         https://bugs.webkit.org/show_bug.cgi?id=192782
38         <rdar://problem/46084932>
39
40         Reviewed by Keith Miller.
41
42         Add test helper to execute bytecode-cache tests: it executes each test
43         twice, the first with JSC_diskCachePath set to a temporary directory
44         and second with JSC_forceDiskCache=true (in addition to the cache path)
45         to guarantee that only the disk cache is being used and no new
46         UnlinkedCodeBlocks are being created.
47
48         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
49         * Scripts/run-jsc-stress-tests:
50
51 2019-01-20  chris fleizach  <cfleizach@apple.com>
52
53         AX: Support returning relative frames for accessibility
54         https://bugs.webkit.org/show_bug.cgi?id=193414
55         <rdar://problem/47268501>
56
57         Reviewed by Zalan Bujtas.
58
59         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
60         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
61         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
62         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
63         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
64         (WTR::attributesOfElement):
65         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
66
67 2019-01-20  Antoine Quint  <graouts@apple.com>
68
69         Add a POINTER_EVENTS feature flag
70         https://bugs.webkit.org/show_bug.cgi?id=193577
71         <rdar://problem/47408511>
72
73         Unreviewed. Also enable Pointer Events for iosmac.
74
75         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
76
77 2019-01-19  Zalan Bujtas  <zalan@apple.com>
78
79         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
80         https://bugs.webkit.org/show_bug.cgi?id=193613
81
82         Reviewed by Antti Koivisto.
83
84         * LayoutReloaded/misc/LFC-passing-tests.txt:
85
86 2019-01-19  Antoine Quint  <graouts@apple.com>
87
88         Add a POINTER_EVENTS feature flag
89         https://bugs.webkit.org/show_bug.cgi?id=193577
90
91         Reviewed by Dean Jackson.
92
93         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
94
95 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
96
97         Disable the run-jsc-stress-test remote host key check [second round].
98         https://bugs.webkit.org/show_bug.cgi?id=192988
99
100         Reviewed by Dewei Zhu.
101
102         * Scripts/run-jsc-stress-tests:
103
104 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
105
106         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
107         https://bugs.webkit.org/show_bug.cgi?id=193597
108
109         Reviewed by Lucas Forschler.
110
111         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
112
113 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
114
115         [build.webkit.org] api tests failures are incorrectly named as unit test failures
116         https://bugs.webkit.org/show_bug.cgi?id=193595
117
118         Reviewed by Lucas Forschler.
119
120         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
121         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
122         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
123
124 2019-01-18  Chris Dumez  <cdumez@apple.com>
125
126         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
127         https://bugs.webkit.org/show_bug.cgi?id=193588
128         <rdar://problem/47131566>
129
130         Reviewed by Alex Christensen.
131
132         Add layout test coverage.
133
134         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
135
136 2019-01-18  Jer Noble  <jer.noble@apple.com>
137
138         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
139         https://bugs.webkit.org/show_bug.cgi?id=189553
140
141         Reviewed by Tim Horton.
142
143         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
144
145         * ContentExtensionTester/Configurations/Base.xcconfig:
146         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
147         * DumpRenderTree/mac/Configurations/Base.xcconfig:
148         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
149         * ImageDiff/cg/Configurations/Base.xcconfig:
150         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
151         * MiniBrowser/Configurations/Base.xcconfig:
152         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
153         * MobileMiniBrowser/Configurations/Base.xcconfig:
154         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
155         * Scripts/webkitpy/style/checker.py:
156         (_all_categories):
157         (FileType):
158         (CheckerDispatcher._file_type):
159         (CheckerDispatcher._create_checker):
160         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
161         (SDKVariantChecker):
162         (SDKVariantChecker.__init__):
163         (SDKVariantChecker.check):
164         * TestWebKitAPI/Configurations/Base.xcconfig:
165         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
166         * WebEditingTester/Configurations/Base.xcconfig:
167         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
168         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
169         * WebKitTestRunner/Configurations/Base.xcconfig:
170         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
171         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
172         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
173
174 2019-01-18  David Kilzer  <ddkilzer@apple.com>
175
176         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
177         <https://webkit.org/b/193568>
178         <rdar://problem/47381130>
179
180         Reviewed by Alex Christensen.
181
182         Make sure no one re-introduces UIKit soft-linking by adding a
183         style rule.
184
185         * Scripts/webkitpy/style/checkers/cpp.py:
186         (check_language): Add softlink/uikit check.
187         (CppChecker): Enable softlink/uikit check.
188         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
189         (CppStyleTest): Add test for softlink/uikit.
190
191 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
192
193         [GTK] install-dependencies tool looks for libunistring-dev for dnf
194         https://bugs.webkit.org/show_bug.cgi?id=193584
195
196         Change "-dev" to "-devel".
197
198         Reviewed by Michael Catanzaro.
199
200         * gtk/install-dependencies:
201
202 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
203
204         webkitpy: Add iPhone and iPad ports
205         https://bugs.webkit.org/show_bug.cgi?id=193537
206         <rdar://problem/47353390>
207
208         Reviewed by Lucas Forschler.
209
210         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
211         ports. Note that this separation is optional, the --ios-simulator command remains.
212
213         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
214         (RunTest.test_device_type_test_division): Drive-by fix.
215         (RunTest.test_device_type_specific_listing): Ditto.
216         (RunTest.test_ipad_test_division):
217         (RunTest):
218         (RunTest.test_ipad_listing):
219         * Scripts/webkitpy/port/factory.py:
220         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
221         (PortFactory):
222         * Scripts/webkitpy/port/ios_simulator.py:
223         (IPhoneSimulatorPort):
224         (IPadSimulatorPort):
225
226 2019-01-18  Chris Dumez  <cdumez@apple.com>
227
228         Regression(PSON) Scroll position is not always restored properly when navigating back
229         https://bugs.webkit.org/show_bug.cgi?id=193578
230         <rdar://problem/47386331>
231
232         Reviewed by Tim Horton.
233
234         Add API test coverage.
235
236         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
237
238 2019-01-18  Youenn Fablet  <youenn@apple.com>
239
240         Add a new SPI to request for cache storage quota increase
241         https://bugs.webkit.org/show_bug.cgi?id=193323
242
243         Reviewed by Alex Christensen.
244
245         Implement WebsiteDataStore quota delegate to handle quota requests.
246         By default, do not update quota.
247         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
248
249         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
250         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
251         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
252         * WebKitTestRunner/InjectedBundle/TestRunner.h:
253         * WebKitTestRunner/TestController.cpp:
254         (WTR::TestController::allowCacheStorageQuotaIncrease):
255         * WebKitTestRunner/TestController.h:
256         * WebKitTestRunner/TestInvocation.cpp:
257         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
258         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
259         (-[CacheStorageQuotaManager init]):
260         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
261         (WTR::initializeWebViewConfiguration):
262         (WTR::TestController::cocoaResetStateToConsistentValues):
263         (WTR::TestController::allowCacheStorageQuotaIncrease):
264
265 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
266
267         [ews-build] Pass owner to the triggered builds
268         https://bugs.webkit.org/show_bug.cgi?id=193574
269
270         Reviewed by Lucas Forschler.
271
272         * BuildSlaveSupport/ews-build/factories.py:
273         (BuildFactory.propertiesToPassToTriggers):
274
275 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
276
277         [ews-app] Send patch author as a build property
278         https://bugs.webkit.org/show_bug.cgi?id=193560
279
280         Reviewed by Lucas Forschler.
281
282         * BuildSlaveSupport/ews-app/ews/fetcher.py:
283         (BugzillaPatchFetcher.fetch):
284
285 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
286
287         webkitpy: Implement device type specific expected results (Follow-up fix)
288         https://bugs.webkit.org/show_bug.cgi?id=192162
289         <rdar://problem/46345449>
290
291         Unreviewed infrastructure fix.
292
293         * Scripts/webkitpy/layout_tests/controllers/manager.py:
294         (Manager.run): Don't boot a device if no tests are available to run on it.
295
296 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
297
298         webkitpy: Implement device type specific expected results (Follow-up fix)
299         https://bugs.webkit.org/show_bug.cgi?id=192162
300         <rdar://problem/46345449>
301
302         Unreviewed infrastructure fix.
303
304         * Scripts/webkitpy/api_tests/manager.py:
305         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
306
307 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
308
309         webkitpy: Implement device type specific expected results (Part 2)
310         https://bugs.webkit.org/show_bug.cgi?id=192162
311         <rdar://problem/46345449>
312
313         Rubber-stamped by Aakash Jain.
314
315         This change uses device_type to select a different set of TestExpectation files based on the type of device running
316         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
317         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
318
319         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
320         (LayoutTestFinder.find_tests): Pass device_type through.
321         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
322         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
323         * Scripts/webkitpy/layout_tests/controllers/manager.py:
324         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
325         (Manager._collect_tests): Pass device type to test finder.
326         (Manager._needs_web_platform_test):
327         (Manager._prepare_lists): Index _expectations by device type.
328         (Manager._test_input_for_file):
329         (Manager._test_is_slow): Ditto.
330         (Manager._test_should_dump_jsconsolelog_in_stderr):
331         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
332         (Manager._get_test_inputs):
333         (Manager._update_worker_count):
334         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
335         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
336         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
337         the one which runs the test.
338         (Manager._run_test_subset):
339         (Manager._run_tests): Index _expectations by current_device_type.
340         (Manager._print_expectation_line_for_test): Ditto.
341         (Manager._print_expectations_for_subset): Ditto.
342         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
343         Unlike run, this function will behave the same regardless of what devices are available.
344         (Manager._custom_device_for_test): Deleted.
345         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
346         (ManagerTest.test_uses_custom_device): Deleted.
347         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
348         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
349         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
350         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
351         all of the expectations.
352         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
353         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
354         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
355         (TestExpectations.__init__): Allow device_type to be passed through.
356         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
357         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
358         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
359         (summarize_results):
360         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
361         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
362         a test ran with, one must check all expectations to find the first non-skip expectation.
363         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
364         (RunTest.test_device_type_test_division):
365         (RunTest):
366         (RunTest.test_device_type_specific_listing):
367         * Scripts/webkitpy/port/base.py:
368         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
369         (Port.supported_device_types): The result of this function will change based on what devices are available.
370         * Scripts/webkitpy/port/device_port.py:
371         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
372         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
373         can be used.
374         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
375         any, or the DEFAULT_DEVICE_TYPES of the port.
376         * Scripts/webkitpy/port/ios.py:
377         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
378         * Scripts/webkitpy/port/ios_simulator.py:
379         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
380         * Scripts/webkitpy/port/watch.py:
381         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
382         * Scripts/webkitpy/port/watch_simulator.py:
383         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
384         * Scripts/webkitpy/xcode/device_type.py:
385         (DeviceType):
386         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
387
388 2019-01-18  Philippe Normand  <pnormand@igalia.com>
389
390         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
391         https://bugs.webkit.org/show_bug.cgi?id=193575
392
393         Reviewed by Michael Catanzaro.
394
395         Allow the script to run without explicit port argument because
396         it's specific to the WPE port anyway.
397
398         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
399         and simplify the rest of the code accordingly.
400
401 2019-01-18  Charlie Turner  <cturner@igalia.com>
402
403         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
404         https://bugs.webkit.org/show_bug.cgi?id=192229
405
406         Reviewed by Xabier Rodriguez-Calvar.
407
408         * MiniBrowser/wpe/main.cpp:
409         (main): Enable encrypted-media by default.
410
411 2019-01-18  Philippe Normand  <pnormand@igalia.com>
412
413         [Flatpak] Missing KeyboardInterrupt exception handler
414         https://bugs.webkit.org/show_bug.cgi?id=193570
415
416         Reviewed by Michael Catanzaro.
417
418         * flatpak/flatpakutils.py:
419         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
420
421 2019-01-18  Zalan Bujtas  <zalan@apple.com>
422
423         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
424         https://bugs.webkit.org/show_bug.cgi?id=193564
425
426         Reviewed by Antti Koivisto.
427
428         * LayoutReloaded/misc/LFC-passing-tests.txt:
429
430 2019-01-18  Zalan Bujtas  <zalan@apple.com>
431
432         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
433         https://bugs.webkit.org/show_bug.cgi?id=193562
434
435         Reviewed by Antti Koivisto.
436
437         * LayoutReloaded/misc/LFC-passing-tests.txt:
438
439 2019-01-18  Zalan Bujtas  <zalan@apple.com>
440
441         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
442         https://bugs.webkit.org/show_bug.cgi?id=193555
443
444         Reviewed by Antti Koivisto.
445
446         * LayoutReloaded/misc/LFC-passing-tests.txt:
447
448 2019-01-18  Philippe Normand  <pnormand@igalia.com>
449
450         [WPE] Add Qt extension
451         https://bugs.webkit.org/show_bug.cgi?id=191464
452
453         Reviewed by Carlos Garcia Campos.
454
455         MiniBrowser and API tests for the WPE Qt API. To run the
456         MiniBrowser a new script is introduced. Example invocation:
457
458         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
459
460         Also note-worthy is the introduction of the python2-subprocess32
461         dependency to run the GLib API tests.
462
463         * MiniBrowser/wpe/CMakeLists.txt:
464         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
465         * MiniBrowser/wpe/qt/main.cpp: Added.
466         (main):
467         * MiniBrowser/wpe/qt/main.qml: Added.
468         * MiniBrowser/wpe/qt/qml.qrc: Added.
469         * Scripts/run-gtk-tests:
470         (GtkTestRunner.is_google_test):
471         (GtkTestRunner):
472         (GtkTestRunner.is_qt_test):
473         * Scripts/run-qt-wpe-minibrowser: Added.
474         * Scripts/run-wpe-tests:
475         (WPETestRunner):
476         (WPETestRunner.is_google_test):
477         (WPETestRunner.is_qt_test):
478         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
479         (TestLoad::main):
480         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
481         (TestLoadHtml::main):
482         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
483         (TestLoadRequest::main):
484         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
485         (TestRunJavaScript::main):
486         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
487         (waitForSignal):
488         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
489         (LoadSpy::LoadSpy):
490         (LoadSpy::~LoadSpy):
491         (LoadSpy::onLoadingChanged):
492         (LoadStartedCatcher::LoadStartedCatcher):
493         (LoadStartedCatcher::~LoadStartedCatcher):
494         (LoadStartedCatcher::onLoadingChanged):
495         (waitForLoadSucceeded):
496         (waitForLoadFailed):
497         * TestWebKitAPI/glib/CMakeLists.txt:
498         * flatpak/flatpakutils.py:
499         (WebkitFlatpak.load_from_args):
500         (WebkitFlatpak.__init__):
501         (WebkitFlatpak.clean_args):
502         (WebkitFlatpak.run_in_sandbox):
503         * flatpak/org.webkit.CommonModules.yaml:
504         * flatpak/org.webkit.WPE.yaml:
505         * flatpak/org.webkit.WPEModules.yaml:
506         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
507         * flatpak/org.webkit.WebKit.yaml:
508         * glib/api_test_runner.py:
509         (TestRunner._run_test_qt):
510         (TestRunner.is_qt_test):
511         (TestRunner._run_test):
512
513 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
514
515         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
516         https://bugs.webkit.org/show_bug.cgi?id=193494
517         <rdar://problem/46859627>
518
519         Reviewed by Simon Fraser and Tim Horton.
520
521         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
522         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
523
524         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
525         (WTR::UIScriptController::contentOffsetX const):
526         (WTR::UIScriptController::contentOffsetY const):
527         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
528         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
529         (WTR::UIScriptController::contentOffsetX const):
530         (WTR::UIScriptController::contentOffsetY const):
531         * TestRunnerShared/UIScriptContext/UIScriptController.h:
532
533         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
534
535         * WebKitTestRunner/TestController.cpp:
536         (WTR::updateTestOptionsFromTestHeader):
537         * WebKitTestRunner/TestOptions.h:
538         (WTR::TestOptions::hasSameInitializationOptions const):
539         * WebKitTestRunner/ios/TestControllerIOS.mm:
540         (WTR::TestController::platformResetStateToConsistentValues):
541         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
542         (WTR::UIScriptController::contentOffsetX const):
543         (WTR::UIScriptController::contentOffsetY const):
544
545 2019-01-17  Truitt Savell  <tsavell@apple.com>
546
547         Unreviewed, rolling out r240124.
548
549         This commit broke an internal build.
550
551         Reverted changeset:
552
553         "SDK_VARIANT build destinations should be separate from non-
554         SDK_VARIANT builds"
555         https://bugs.webkit.org/show_bug.cgi?id=189553
556         https://trac.webkit.org/changeset/240124
557
558 2019-01-17  Alex Christensen  <achristensen@webkit.org>
559
560         Fix string concatenation API test after r239920
561         https://bugs.webkit.org/show_bug.cgi?id=193551
562         <rdar://problem/47359304>
563
564         Reviewed by Youenn Fablet.
565
566         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
567         (TestWebKitAPI::TEST):
568         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
569         in WebKit's build configuration like it apparently is on Linux.
570
571 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
572
573         [ews-build] validate-patch should handle the case when bug_id is None
574         https://bugs.webkit.org/show_bug.cgi?id=193547
575
576         Reviewed by Lucas Forschler.
577
578         * BuildSlaveSupport/ews-build/steps.py:
579         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
580         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
581
582 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
583
584         [ews-build] Add patch author information in build
585         https://bugs.webkit.org/show_bug.cgi?id=193465
586
587         Reviewed by Lucas Forschler.
588
589         * BuildSlaveSupport/ews-build/steps.py:
590         (ValidatePatch._is_patch_obsolete):
591
592 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
593
594         [ews-build] Pass bug_id to the triggered builds
595         https://bugs.webkit.org/show_bug.cgi?id=193548
596
597         Reviewed by Lucas Forschler.
598
599         * BuildSlaveSupport/ews-build/factories.py:
600         (BuildFactory.propertiesToPassToTriggers):
601
602 2019-01-17  Jer Noble  <jer.noble@apple.com>
603
604         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
605         https://bugs.webkit.org/show_bug.cgi?id=189553
606
607         Reviewed by Tim Horton.
608
609         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
610
611         * ContentExtensionTester/Configurations/Base.xcconfig:
612         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
613         * DumpRenderTree/mac/Configurations/Base.xcconfig:
614         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
615         * ImageDiff/cg/Configurations/Base.xcconfig:
616         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
617         * MiniBrowser/Configurations/Base.xcconfig:
618         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
619         * MobileMiniBrowser/Configurations/Base.xcconfig:
620         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
621         * Scripts/webkitpy/style/checker.py:
622         (_all_categories):
623         (FileType):
624         (CheckerDispatcher._file_type):
625         (CheckerDispatcher._create_checker):
626         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
627         (SDKVariantChecker):
628         (SDKVariantChecker.__init__):
629         (SDKVariantChecker.check):
630         * TestWebKitAPI/Configurations/Base.xcconfig:
631         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
632         * WebEditingTester/Configurations/Base.xcconfig:
633         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
634         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
635         * WebKitTestRunner/Configurations/Base.xcconfig:
636         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
637         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
638         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
639
640 2019-01-17  Zalan Bujtas  <zalan@apple.com>
641
642         [LFC][BFC] An element with transform is a containing block for positioned descendants.
643         https://bugs.webkit.org/show_bug.cgi?id=193534
644
645         Reviewed by Antti Koivisto.
646
647         * LayoutReloaded/misc/LFC-passing-tests.txt:
648
649 2019-01-17  Zalan Bujtas  <zalan@apple.com>
650
651         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
652         https://bugs.webkit.org/show_bug.cgi?id=193528
653
654         Reviewed by Antti Koivisto.
655
656         * LayoutReloaded/misc/LFC-passing-tests.txt:
657
658 2019-01-17  Zalan Bujtas  <zalan@apple.com>
659
660         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
661         https://bugs.webkit.org/show_bug.cgi?id=193520
662
663         Reviewed by Antti Koivisto.
664
665         * LayoutReloaded/misc/LFC-passing-tests.txt:
666
667 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
668
669         [ews-build] unapply-patch step should not update source
670         https://bugs.webkit.org/show_bug.cgi?id=193234
671
672         Reviewed by Lucas Forschler.
673
674         * BuildSlaveSupport/ews-build/steps.py:
675         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
676         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
677
678 2019-01-16  Youenn Fablet  <youenn@apple.com>
679
680         Add a new SPI for controlling getUserMedia
681         https://bugs.webkit.org/show_bug.cgi?id=192793
682
683         Reviewed by Eric Carlson.
684
685         * MiniBrowser/mac/WK2BrowserWindowController.m:
686         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
687         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
688         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
689         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
690         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
691         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
692         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
693         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
694         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
695         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
696         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
697         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
698         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
699         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
700
701 2019-01-16  Zalan Bujtas  <zalan@apple.com>
702
703         [LFC][BFC] Inflow non-replaced used width should not be negative.
704         https://bugs.webkit.org/show_bug.cgi?id=193495
705
706         Reviewed by Antti Koivisto.
707
708         * LayoutReloaded/misc/LFC-passing-tests.txt:
709
710 2019-01-16  Chris Dumez  <cdumez@apple.com>
711
712         Regression(PSON) View becomes blank after click a cross-site download link
713         https://bugs.webkit.org/show_bug.cgi?id=193361
714         <rdar://problem/47099573>
715
716         Reviewed by Geoffrey Garen.
717
718         Add API test coverage.
719
720         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
721         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
722
723 2019-01-16  Zalan Bujtas  <zalan@apple.com>
724
725         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
726         https://bugs.webkit.org/show_bug.cgi?id=193470
727
728         Reviewed by Antti Koivisto.
729
730         * LayoutReloaded/misc/LFC-passing-tests.txt:
731
732 2019-01-16  Zalan Bujtas  <zalan@apple.com>
733
734         [LFC] Adjust margin box verification.
735         https://bugs.webkit.org/show_bug.cgi?id=193482
736
737         Reviewed by Antti Koivisto.
738
739         * LayoutReloaded/misc/LFC-passing-tests.txt:
740
741 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
742
743         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
744         https://bugs.webkit.org/show_bug.cgi?id=193451
745
746         Reviewed by Geoffrey Garen.
747
748         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
749         (TEST):
750         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
751         (runWebsiteDataStoreCustomPaths):
752
753 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
754
755         webkitpy: Support boolean simctl isAvailable
756         https://bugs.webkit.org/show_bug.cgi?id=193472
757         <rdar://problem/47296150>
758
759         Reviewed by Ryosuke Niwa.
760
761         * Scripts/webkitpy/xcode/simulated_device.py:
762         (SimulatedDeviceManager._create_runtimes):
763         (SimulatedDeviceManager._create_device_with_runtime):
764
765 2019-01-15  Chris Dumez  <cdumez@apple.com>
766
767         Unreviewed, rolling out r239993, r239995, r239997, and
768         r239999.
769
770         Caused assertions under
771         ViewGestureController::disconnectFromProcess()
772
773         Reverted changesets:
774
775         "Regression(PSON) View becomes blank after click a cross-site
776         download link"
777         https://bugs.webkit.org/show_bug.cgi?id=193361
778         https://trac.webkit.org/changeset/239993
779
780         "Unreviewed iOS build fix after r239993."
781         https://trac.webkit.org/changeset/239995
782
783         "Fix iOS build after r239993"
784         https://bugs.webkit.org/show_bug.cgi?id=193361
785         https://trac.webkit.org/changeset/239997
786
787         "Unreviewed, revert part of r239997 as it is not needed to fix
788         the build."
789         https://trac.webkit.org/changeset/239999
790
791 2019-01-15  Tim Horton  <timothy_horton@apple.com>
792
793         Cannot tab out of WKWebView on macOS
794         https://bugs.webkit.org/show_bug.cgi?id=161448
795         <rdar://problem/28100085>
796
797         Reviewed by Dean Jackson.
798
799         Add a test that tabbing into and out of WKWebView works correctly.
800
801         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
802         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
803         (WebKit2_CommandBackForwardTest::SetUp):
804         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
805         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
806         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
807         (-[FocusableView canBecomeKeyView]):
808         (TEST):
809         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
810         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
811         (-[OffscreenWindow initWithSize:]):
812         (-[OffscreenWindow isKeyWindow]):
813         (-[OffscreenWindow isVisible]):
814         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
815         (TestWebKitAPI::PlatformWebView::initialize):
816         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
817         (-[ActiveOffscreenWindow isVisible]): Deleted.
818         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
819
820 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
821
822         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
823         https://bugs.webkit.org/show_bug.cgi?id=193459
824
825         Reviewed by Mark Lam.
826
827         * BuildSlaveSupport/build.webkit.org-config/steps.py:
828         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
829
830 2019-01-15  Chris Dumez  <cdumez@apple.com>
831
832         Regression(PSON) View becomes blank after click a cross-site download link
833         https://bugs.webkit.org/show_bug.cgi?id=193361
834         <rdar://problem/47099573>
835
836         Reviewed by Geoff Garen.
837
838         Add API test coverage.
839
840         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
841         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
842
843 2019-01-15  Zalan Bujtas  <zalan@apple.com>
844
845         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
846         https://bugs.webkit.org/show_bug.cgi?id=193448
847
848         Reviewed by Antti Koivisto.
849
850         * LayoutReloaded/misc/LFC-passing-tests.txt:
851
852 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
853
854         webkitpy: Implement device type specific expected results (Part 1)
855         https://bugs.webkit.org/show_bug.cgi?id=192162
856
857         Reviewed by Lucas Forschler.
858
859         Device type specific expected results covers two related ideas. The first (covered by this change)
860         is where to search for -expected.* files. The second is which tests to run based on the
861         TestExpectations.txt file.
862
863         After this change, the baseline search path will be determined by the type of device running a
864         test. Device type will be passed into any function which picks a file based on the baseline search
865         path.
866
867         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
868         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
869         * Scripts/webkitpy/layout_tests/controllers/manager.py:
870         (Manager.run): Print baseline search path for each round of devices.
871         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
872         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
873         (SingleTestRunner._expected_driver_output): Ditto.
874         (SingleTestRunner._driver_input): Ditto.
875         * Scripts/webkitpy/layout_tests/views/printing.py:
876         (Printer.print_config): Move printing of baseline search path to a separate function.
877         (Printer.print_baseline_search_path): Moved from Printer.print_config.
878         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
879         (Testprinter.test_print_config):
880         (Testprinter.test_print_baseline_search_path):
881         * Scripts/webkitpy/port/base.py:
882         (Port.baseline_search_path): Pass device_type through.
883         (Port._expected_baselines_for_suffixes): Ditto.
884         (Port.expected_baselines): Ditto.
885         (Port.expected_filename): Ditto.
886         (Port.expected_checksum): Ditto.
887         (Port.expected_image): Ditto.
888         (Port.expected_audio): Ditto.
889         (Port.expected_text): Ditto.
890         (Port.reference_files): Ditto.
891         (Port.tests): Ditto.
892         (Port._expanded_paths): Ditto.
893         (Port.skipped_layout_tests): Ditto.
894         (Port.expectations_dict): Ditto.
895         (Port._port_specific_expectations_files): Ditto.
896         (Port.expectations_files): Ditto.
897         (Port.test_search_path): Ditto.
898         (Port._tests_for_other_platforms): Ditto.
899         * Scripts/webkitpy/port/base_unittest.py:
900         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
901         (PortTest.test_nonexistant_expectations): Ditto.
902         (test_ref_tests_platform_directory): Ditto.
903         * Scripts/webkitpy/port/darwin.py:
904         (DarwinPort._port_specific_expectations_files): Accept device_type.
905         * Scripts/webkitpy/port/driver.py:
906         (DriverProxy):
907         (DriverProxy.host): Expose _target_host for device_type information.
908         * Scripts/webkitpy/port/gtk.py:
909         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
910         * Scripts/webkitpy/port/ios.py:
911         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
912         * Scripts/webkitpy/port/mac.py:
913         (MacPort. default_baseline_search_path): Ditto.
914         * Scripts/webkitpy/port/port_testcase.py:
915         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
916         * Scripts/webkitpy/port/test.py:
917         * Scripts/webkitpy/port/watch.py:
918         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
919         * Scripts/webkitpy/port/win.py:
920         (WinPort.test_search_path): Accept, but do not use, device_type.
921         * Scripts/webkitpy/port/wpe.py:
922         (WPEPort._port_specific_expectations_files): Ditto.
923         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
924         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
925
926 2019-01-15  Zalan Bujtas  <zalan@apple.com>
927
928         [LFC] Use the containing block's padding box to position out-of-flow elements.
929         https://bugs.webkit.org/show_bug.cgi?id=193431
930
931         Reviewed by Antti Koivisto.
932
933         * LayoutReloaded/misc/LFC-passing-tests.txt:
934
935 2019-01-14  Tim Horton  <timothy_horton@apple.com>
936
937         Move a test implementation file that got misplaced in the Xcode project
938
939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
940
941 2019-01-14  Commit Queue  <commit-queue@webkit.org>
942
943         Unreviewed, rolling out r239901, r239909, r239910, r239912,
944         r239913, and r239914.
945         https://bugs.webkit.org/show_bug.cgi?id=193407
946
947         These revisions caused an internal failure (Requested by
948         Truitt on #webkit).
949
950         Reverted changesets:
951
952         "[Cocoa] Avoid importing directly from subumbrella frameworks"
953         https://bugs.webkit.org/show_bug.cgi?id=186016
954         https://trac.webkit.org/changeset/239901
955
956         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
957         https://trac.webkit.org/changeset/239909
958
959         "Tried to fix the build."
960         https://trac.webkit.org/changeset/239910
961
962         "Fixed iOS builds after r239910."
963         https://trac.webkit.org/changeset/239912
964
965         "More build fixing."
966         https://trac.webkit.org/changeset/239913
967
968         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
969         https://trac.webkit.org/changeset/239914
970
971 2019-01-14  Mark Lam  <mark.lam@apple.com>
972
973         Re-enable ability to build --cloop builds.
974         https://bugs.webkit.org/show_bug.cgi?id=192955
975         <rdar://problem/46882363>
976
977         Reviewed by Saam barati and Keith Miller.
978
979         The --cloop build option was being ignored this whole time since r236381.
980         This patch makes it possible to build CLoop builds again.
981
982         * Scripts/build-jsc:
983         * Scripts/webkitperl/FeatureList.pm:
984         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
985
986 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
987
988         webkitpy: Expose device_type from host-like objects
989         https://bugs.webkit.org/show_bug.cgi?id=193406
990         <rdar://problem/47262305>
991
992         Reviewed by Lucas Forschler.
993
994         Devices should expose device_type. As a result, all host objects should
995         provide a device_type property, even if they do not yet define a device_type.
996
997         * Scripts/webkitpy/common/system/systemhost.py:
998         (SystemHost):
999         (SystemHost.device_type):
1000         * Scripts/webkitpy/common/system/systemhost_mock.py:
1001         (MockSystemHost):
1002         (MockSystemHost.device_type):
1003         * Scripts/webkitpy/port/device.py:
1004         (Device):
1005         (Device.device_type):
1006         * Scripts/webkitpy/xcode/simulated_device.py:
1007         (SimulatedDeviceManager._find_exisiting_device_for_request):
1008         (SimulatedDeviceManager._disambiguate_device_type):
1009         (SimulatedDeviceManager._does_fulfill_request):
1010         (SimulatedDeviceManager.device_count_for_type):
1011         (SimulatedDeviceManager.initialize_devices):
1012         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1013         (test_available_devices):
1014         (test_swapping_devices):
1015
1016 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1017
1018         webkitpy: Support alternate simctl device list output (Follow-up fix)
1019         https://bugs.webkit.org/show_bug.cgi?id=193362
1020         <rdar://problem/47122965>
1021
1022         Rubber-stamped by Lucas Forschler.
1023
1024         * Scripts/webkitpy/xcode/simulated_device.py:
1025         (SimulatedDeviceManager.populate_available_devices):
1026
1027 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1028
1029         [iOS] Expose SPI to access the current sentence boundary and selection state
1030         https://bugs.webkit.org/show_bug.cgi?id=193398
1031         <rdar://problem/45893108>
1032
1033         Reviewed by Dean Jackson.
1034
1035         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
1036         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
1037         expected.
1038
1039         * TestWebKitAPI/EditingTestHarness.h:
1040         * TestWebKitAPI/EditingTestHarness.mm:
1041         (-[EditingTestHarness moveBackward]):
1042         (-[EditingTestHarness moveForward]):
1043         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
1044
1045         Add a couple of new helper methods on EditingTestHarness.
1046
1047         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1048         (-[SelectionChangeObserver initWithWebView:]):
1049         (-[SelectionChangeObserver webView]):
1050         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
1051         (-[SelectionChangeObserver currentSelectionAttributes]):
1052
1053 2019-01-14  Zalan Bujtas  <zalan@apple.com>
1054
1055         [LFC][BFC] Add basic box-sizing support.
1056         https://bugs.webkit.org/show_bug.cgi?id=193392
1057
1058         Reviewed by Antti Koivisto.
1059
1060         * LayoutReloaded/misc/LFC-passing-tests.txt:
1061
1062 2019-01-14  Charlie Turner  <cturner@igalia.com>
1063
1064         [WPE] API test gardening
1065         https://bugs.webkit.org/show_bug.cgi?id=193319
1066
1067         Reviewed by Michael Catanzaro.
1068
1069         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
1070         passing tests.
1071
1072 2019-01-14  Charlie Turner  <cturner@igalia.com>
1073
1074         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
1075         https://bugs.webkit.org/show_bug.cgi?id=192977
1076
1077         Reviewed by Carlos Garcia Campos.
1078
1079         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
1080         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1081         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
1082         (TestWebKitAPI::GStreamerTest::SetUp):
1083         (TestWebKitAPI::GStreamerTest::TearDown):
1084         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
1085         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
1086         (TestWebKitAPI::TEST_F):
1087
1088 2019-01-14  Charlie Turner  <cturner@igalia.com>
1089
1090         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
1091         https://bugs.webkit.org/show_bug.cgi?id=193332
1092
1093         Reviewed by Michael Catanzaro.
1094
1095         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
1096         defined as a char16_t, which changed in ICU 59, the
1097         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
1098         unsigned short. This test is relying on the behaviour that
1099         UChar=unsigned short, which doesn't hold across platforms and ICU
1100         library versions. The full fix would be a special syntax for
1101         literal characters so that these ambiguities do not arise. That
1102         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
1103         (TestWebKitAPI::TEST):
1104
1105 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1106
1107         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
1108
1109         * Scripts/make-dist:
1110         (Distcheck.configure):
1111
1112 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
1113
1114         [ews-build] Update macOS queue configurations
1115         https://bugs.webkit.org/show_bug.cgi?id=193365
1116         <rdar://problem/47221073>
1117
1118         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
1119
1120         * BuildSlaveSupport/ews-build/config.json:
1121
1122 2019-01-13  Zalan Bujtas  <zalan@apple.com>
1123
1124         [LFC] Adjust assert for statically positioned fixed elements
1125         https://bugs.webkit.org/show_bug.cgi?id=193385
1126
1127         Reviewed by Antti Koivisto.
1128
1129         * LayoutReloaded/misc/LFC-passing-tests.txt:
1130
1131 2019-01-13  Philippe Normand  <pnormand@igalia.com>
1132
1133         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
1134         https://bugs.webkit.org/show_bug.cgi?id=193387
1135
1136         Reviewed by Carlos Garcia Campos.
1137
1138         * MiniBrowser/wpe/main.cpp:
1139         (main):
1140
1141 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1142
1143         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1144         https://bugs.webkit.org/show_bug.cgi?id=191655
1145         rdar://problem/46074680
1146
1147         Reviewed by Megan Gardner.
1148
1149         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1150         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1151
1152 2019-01-12  Dan Bernstein  <mitz@apple.com>
1153
1154         [Cocoa] Avoid importing directly from subumbrella frameworks
1155         https://bugs.webkit.org/show_bug.cgi?id=186016
1156         <rdar://problem/40591038>
1157
1158         Reviewed by Sam Weinig.
1159
1160         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1161           LaunchServices header.
1162         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1163           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1164         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1165           when using SDKs earlier than 10.13.
1166         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1167           and OTHER_CPLUSPLUSFLAGS.
1168         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1169           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1170         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1171           LaunchServices header.
1172
1173 2019-01-11  John Wilander  <wilander@apple.com>
1174
1175         Compile out Web API Statistics Collection
1176         https://bugs.webkit.org/show_bug.cgi?id=193370
1177         <rdar://problem/45388584>
1178
1179         Reviewed by Brent Fulgham.
1180
1181         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1182             Defined ENABLE_WEB_API_STATISTICS, off by default.
1183
1184 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1185
1186         [WPE] Add gtk-doc
1187         https://bugs.webkit.org/show_bug.cgi?id=178900
1188
1189         Reviewed by Michael Catanzaro.
1190
1191         Add Tools/gtkdoc to manifest.txt.in files.
1192         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
1193
1194         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
1195         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
1196
1197 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1198
1199         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
1200         https://bugs.webkit.org/show_bug.cgi?id=193364
1201         <rdar://problem/47214117>
1202
1203         Reviewed by Tim Horton.
1204
1205         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
1206         precise, whereas dragging near the middle of the textarea does.
1207
1208         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1209         (TestWebKitAPI::TEST):
1210
1211 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1212
1213         webkitpy: Support alternate simctl device list output
1214         https://bugs.webkit.org/show_bug.cgi?id=193362
1215         <rdar://problem/47122965>
1216
1217         Reviewed by Lucas Forschler.
1218
1219         * Scripts/webkitpy/xcode/simulated_device.py:
1220         (SimulatedDeviceManager.populate_available_devices):
1221
1222 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
1223
1224         [ews-build] Update macOS queue configurations
1225         https://bugs.webkit.org/show_bug.cgi?id=193365
1226
1227         Reviewed by Lucas Forschler.
1228
1229         * BuildSlaveSupport/ews-build/config.json:
1230
1231 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1232
1233         webkitpy: Incorporate device type into baseline search path
1234         https://bugs.webkit.org/show_bug.cgi?id=193356
1235         <rdar://problem/47215515>
1236
1237         Reviewed by Lucas Forschler.
1238
1239         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
1240
1241         * Scripts/webkitpy/port/base.py:
1242         (Port.default_baseline_search_path): Allow device type to be passed in.
1243         * Scripts/webkitpy/port/gtk.py:
1244         (GtkPort.default_baseline_search_path): Ignore device type.
1245         * Scripts/webkitpy/port/ios.py:
1246         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
1247         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
1248         * Scripts/webkitpy/port/ios_device_unittest.py:
1249         (IOSDeviceTest):
1250         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1251         (IOSSimulatorTest):
1252         * Scripts/webkitpy/port/mac.py:
1253         (MacPort.default_baseline_search_path): Ignore device type.
1254         * Scripts/webkitpy/port/watch.py:
1255         (WatchPort.default_baseline_search_path): Ditto.
1256         * Scripts/webkitpy/port/win.py:
1257         (WinPort.default_baseline_search_path): Ditto.
1258         (WinCairoPort.default_baseline_search_path): Ditto.
1259         * Scripts/webkitpy/port/wpe.py:
1260         (WPEPort.default_baseline_search_path): Ditto.
1261
1262 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1263
1264         webkitpy: Print abbreviated baseline search path that includes only folders that exist
1265         https://bugs.webkit.org/show_bug.cgi?id=193352
1266         <rdar://problem/47210736>
1267
1268         Reviewed by Lucas Forschler.
1269
1270         * Scripts/webkitpy/layout_tests/views/printing.py:
1271         (Printer.print_config): Print list on only baseline search paths which exist. 
1272         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1273         (Testprinter.test_print_config):
1274
1275 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
1276
1277         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
1278         https://bugs.webkit.org/show_bug.cgi?id=193340
1279
1280         Reviewed by David Kilzer.
1281
1282         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1283         (WTR::InjectedBundle::didReceiveMessageToPage):
1284         Pull the strings out into a WKRetainPtr.
1285
1286         * WebKitTestRunner/WebNotificationProvider.cpp:
1287         (WTR::WebNotificationProvider::closeWebNotification):
1288         Adopt the created value into the WKRetainPtr.
1289
1290         * WebKitTestRunner/mac/TestControllerMac.mm:
1291         (WTR::generateWhitelist):
1292         Immediately adopt a created value to avoid potential mistakes.
1293
1294 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
1295
1296         Enable DFG on ARM/Linux again
1297         https://bugs.webkit.org/show_bug.cgi?id=192496
1298
1299         Reviewed by Yusuke Suzuki.
1300
1301         After changing the bytecode format DFG was disabled on all 32-bit
1302         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1303         on ARM by default.
1304
1305         * Scripts/run-jsc-stress-tests:
1306
1307 2019-01-11  Timothy Hatcher  <timothy@apple.com>
1308
1309         Unreviewed, fix #ifdef in API test added in r239851.
1310         https://bugs.webkit.org/show_bug.cgi?id=193327
1311         rdar://problem/47093222
1312
1313         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1314
1315 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1316
1317         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
1318         https://bugs.webkit.org/show_bug.cgi?id=193109
1319         <rdar://problem/44807048>
1320
1321         Reviewed by Ryosuke Niwa.
1322
1323         Introduce and respect a test option to enable the UndoManager API.
1324
1325         * WebKitTestRunner/TestController.cpp:
1326         (WTR::updateTestOptionsFromTestHeader):
1327         * WebKitTestRunner/TestOptions.h:
1328         (WTR::TestOptions::hasSameInitializationOptions const):
1329         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1330         (WTR::TestController::platformCreateWebView):
1331
1332 2019-01-11  Zalan Bujtas  <zalan@apple.com>
1333
1334         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
1335         https://bugs.webkit.org/show_bug.cgi?id=193346
1336
1337         Reviewed by Antti Koivisto.
1338
1339         * LayoutReloaded/misc/LFC-passing-tests.txt:
1340
1341 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1342
1343         Unreviewed, fix typo that breaks dashboard link.
1344
1345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1346         (WebKitBuildbot):
1347
1348 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1349
1350         Update macOS queue configurations
1351         https://bugs.webkit.org/show_bug.cgi?id=193329
1352
1353         Reviewed by Alexey Proskuryakov.
1354
1355         * BuildSlaveSupport/build.webkit.org-config/config.json:
1356         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1357         (BubbleQueueServer):
1358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1360         (WebKitBuildbot):
1361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1362         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
1363         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1364
1365 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1366
1367         MiniBrowser should be able to navigate to about:blank
1368         https://bugs.webkit.org/show_bug.cgi?id=193345
1369
1370         Reviewed by Simon Fraser.
1371
1372         * MiniBrowser/mac/BrowserWindowController.m:
1373         (-[BrowserWindowController addProtocolIfNecessary:]):
1374         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
1375
1376         * MiniBrowser/mac/WK1BrowserWindowController.m:
1377         (-[WK1BrowserWindowController fetch:]):
1378         * MiniBrowser/mac/WK2BrowserWindowController.m:
1379         (-[WK2BrowserWindowController fetch:]):
1380         Clean up the code that uses this to match style.
1381
1382 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1383
1384         Remove MiniBrowser custom "Process Swap" menu item which does not work
1385         https://bugs.webkit.org/show_bug.cgi?id=193344
1386
1387         Reviewed by Simon Fraser.
1388
1389         There is a menu item under the Experimental menu that does work.
1390
1391         * MiniBrowser/mac/AppDelegate.m:
1392         (defaultConfiguration):
1393         * MiniBrowser/mac/SettingsController.h:
1394         * MiniBrowser/mac/SettingsController.m:
1395         (-[SettingsController _populateMenu]):
1396         (-[SettingsController validateMenuItem:]):
1397         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
1398         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
1399
1400 2019-01-10  Timothy Hatcher  <timothy@apple.com>
1401
1402         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
1403         https://bugs.webkit.org/show_bug.cgi?id=193327
1404         rdar://problem/47093222
1405
1406         Reviewed by Tim Horton.
1407
1408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1409         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
1410         (TestWebKitAPI::didFinishNavigation):
1411         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1412         (TestWebKitAPI::TEST):
1413         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
1414         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
1415         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
1416         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
1417         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
1418
1419 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1420
1421         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
1422         https://bugs.webkit.org/show_bug.cgi?id=193338
1423         <rdar://problem/46664774>
1424
1425         Reviewed by David Kilzer.
1426
1427         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1428         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1429
1430 2019-01-10  Commit Queue  <commit-queue@webkit.org>
1431
1432         Unreviewed, rolling out r239825.
1433         https://bugs.webkit.org/show_bug.cgi?id=193330
1434
1435         Broke tests on armv7/linux bots (Requested by guijemont on
1436         #webkit).
1437
1438         Reverted changeset:
1439
1440         "Enable DFG on ARM/Linux again"
1441         https://bugs.webkit.org/show_bug.cgi?id=192496
1442         https://trac.webkit.org/changeset/239825
1443
1444 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
1445
1446         Disable the run-jsc-stress-test remote host key check.
1447         https://bugs.webkit.org/show_bug.cgi?id=192988
1448
1449         Reviewed by Alexey Proskuryakov.
1450
1451         * Scripts/run-jsc-stress-tests:
1452
1453 2019-01-10  John Wilander  <wilander@apple.com>
1454
1455         Override the session configuration for cookieAcceptPolicy
1456         https://bugs.webkit.org/show_bug.cgi?id=190925
1457         <rdar://problem/45497382>
1458
1459         Reviewed by Alexey Proskuryakov and Alex Christensen.
1460
1461         Test infrastructure for setting a first-party-only cookie policy.
1462
1463         * DumpRenderTree/TestRunner.cpp:
1464         (setOnlyAcceptFirstPartyCookiesCallback):
1465         (TestRunner::staticFunctions):
1466         * DumpRenderTree/TestRunner.h:
1467         * DumpRenderTree/mac/TestRunnerMac.mm:
1468         (TestRunner::setOnlyAcceptFirstPartyCookies):
1469         * DumpRenderTree/win/TestRunnerWin.cpp:
1470         (TestRunner::setOnlyAcceptFirstPartyCookies):
1471         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1472         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1473         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1474         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1475         * WebKitTestRunner/TestInvocation.cpp:
1476         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1477
1478 2019-01-09  Matt Rajca  <mrajca@apple.com>
1479
1480         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
1481         https://bugs.webkit.org/show_bug.cgi?id=193301
1482
1483         Reviewed by Jer Noble.
1484         
1485         Added API tests.
1486
1487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1488         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1489         (TEST):
1490         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
1491
1492 2019-01-10  Zalan Bujtas  <zalan@apple.com>
1493
1494         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
1495         https://bugs.webkit.org/show_bug.cgi?id=193310
1496
1497         Reviewed by Antti Koivisto.
1498
1499         * LayoutReloaded/misc/LFC-passing-tests.txt:
1500
1501 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
1502
1503         Enable DFG on ARM/Linux again
1504         https://bugs.webkit.org/show_bug.cgi?id=192496
1505
1506         Reviewed by Yusuke Suzuki.
1507
1508         After changing the bytecode format DFG was disabled on all 32-bit
1509         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1510         on ARM by default.
1511
1512         * Scripts/run-jsc-stress-tests:
1513
1514 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1515
1516         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
1517         https://bugs.webkit.org/show_bug.cgi?id=193271
1518
1519         Reviewed by Brent Fulgham.
1520
1521         BSTR is a special data structure created by SysAllocString, not a
1522         wchar_t null-terminated string.
1523
1524         * DumpRenderTree/win/TestRunnerWin.cpp:
1525         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
1526         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1527         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
1528         BSTR from wide string literals.
1529
1530 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
1531
1532         Tweak wording for build/version_check style checker error
1533         https://bugs.webkit.org/show_bug.cgi?id=193256
1534
1535         Reviewed by Tim Horton.
1536
1537         * Scripts/webkitpy/style/checkers/cpp.py:
1538         (check_os_version_checks):
1539         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1540         (WebKitStyleTest.test_os_version_checks):
1541
1542 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1543
1544         [ews-build] Add link to bug along with bug title
1545         https://bugs.webkit.org/show_bug.cgi?id=193293
1546
1547         Reviewed by Lucas Forschler.
1548
1549         * BuildSlaveSupport/ews-build/steps.py:
1550         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
1551         (ConfigureBuild.add_bug_id_url): Deleted.
1552         (ConfigureBuild.getBugURL): Deleted.
1553
1554 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1555
1556         [ews-build] Use https for ews-build server
1557         https://bugs.webkit.org/show_bug.cgi?id=193193
1558
1559         Reviewed by Lucas Forschler.
1560
1561         * BuildSlaveSupport/ews-build/steps.py:
1562
1563 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1564
1565         [ews-build] Parse and display number of style failures
1566         https://bugs.webkit.org/show_bug.cgi?id=193280
1567
1568         Reviewed by Lucas Forschler.
1569
1570         * BuildSlaveSupport/ews-build/steps.py:
1571         (CheckStyle): Use TestWithFailureCount as base class.
1572         (CheckStyle.countFailures): Count the number of style failures.
1573
1574 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1575
1576         [ews-build] use patch_id instead of ewspatchid
1577         https://bugs.webkit.org/show_bug.cgi?id=193235
1578
1579         Reviewed by Lucas Forschler.
1580
1581         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
1582         * BuildSlaveSupport/ews-build/steps.py: Ditto.
1583         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
1584
1585 2019-01-09  Zalan Bujtas  <zalan@apple.com>
1586
1587         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
1588         https://bugs.webkit.org/show_bug.cgi?id=192625
1589
1590         Reviewed by Antti Koivisto.
1591
1592         * LayoutReloaded/misc/LFC-passing-tests.txt:
1593
1594 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1595
1596         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
1597         https://bugs.webkit.org/show_bug.cgi?id=192841
1598
1599         Reviewed by Carlos Garcia Campos.
1600
1601         There are separate g_assert_*() macros for use in tests, which we use inconsistently
1602         currently. Use them always. We'll get nicer error messages now when tests fail, and the
1603         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
1604
1605         Note that the documentation of g_assert() says that it is not to be used when writing tests.
1606
1607         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1608         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
1609         (WebKitWebEditorTest::testSelectionChanged):
1610         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1611         (WebKitFrameTest::testMainFrame):
1612         (WebKitFrameTest::testURI):
1613         (WebKitFrameTest::testJavaScriptContext):
1614         (WebKitFrameTest::testJavaScriptValues):
1615         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1616         (testWebViewAuthenticationRequest):
1617         (testWebViewAuthenticationLoadCancelled):
1618         (testWebViewAuthenticationFailure):
1619         (testWebViewAuthenticationStorage):
1620         (ProxyAuthenticationTest::ProxyAuthenticationTest):
1621         (testWebViewAuthenticationProxy):
1622         (testWebViewAuthenticationProxyHTTPS):
1623         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1624         (testAutomationSessionRequestSession):
1625         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
1626         (testBackForwardListNavigation):
1627         (testWebKitWebViewSessionState):
1628         (testWebKitWebViewSessionStateWithFormData):
1629         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1630         (ConsoleMessageTest::consoleMessageReceivedCallback):
1631         (testWebKitConsoleMessageConsoleAPI):
1632         (testWebKitConsoleMessageJavaScriptException):
1633         (testWebKitConsoleMessageNetworkError):
1634         (testWebKitConsoleMessageSecurityError):
1635         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1636         (testCookieManagerAcceptPolicy):
1637         (testCookieManagerCookiesChanged):
1638         (testCookieManagerPersistentStorage):
1639         (testCookieManagerPersistentStorageDeleteAll):
1640         (testCookieManagerEphemeral):
1641         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
1642         (testWebKitDOMElementAutoFill):
1643         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1644         (downloadLocalFileSuccessfully):
1645         (createFileAtDestination):
1646         (testDownloadOverwriteDestinationDisallowed):
1647         (testDownloadLocalFileError):
1648         (testDownloadRemoteFile):
1649         (testDownloadRemoteFileError):
1650         (testWebViewDownloadURI):
1651         (testPolicyResponseDownload):
1652         (testPolicyResponseDownloadCancel):
1653         (testDownloadMIMEType):
1654         (contextMenuCallback):
1655         (testContextMenuDownloadActions):
1656         (testBlobDownload):
1657         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
1658         (testWebKitWebEditorSelectionChanged):
1659         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1660         (testWebKitFrameMainFrame):
1661         (testWebKitFrameURI):
1662         (testWebKitFrameJavaScriptContext):
1663         (testWebKitFrameJavaScriptValues):
1664         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1665         (LoadStopTrackingTest::loadFailed):
1666         (testWebViewTitle):
1667         (testURIRequestHTTPHeaders):
1668         (testURIRequestHTTPMethod):
1669         (testURIResponseHTTPHeaders):
1670         (testRedirectToDataURI):
1671         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1672         (testProcessPerWebView):
1673         (testWebProcessLimit):
1674         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1675         (testWebViewResources):
1676         (testWebResourceLoading):
1677         (testWebResourceSuggestedFilename):
1678         (testWebResourceGetData):
1679         (testWebResourceGetDataError):
1680         (testWebViewResourcesHistoryCache):
1681         (testWebResourceSendRequest):
1682         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1683         (testSSL):
1684         (testInsecureContent):
1685         (testTLSErrorsPolicy):
1686         (testTLSErrorsRedirect):
1687         (testTLSErrorsHTTPAuth):
1688         (testLoadFailedWithTLSErrors):
1689         (testSubresourceLoadFailedWithTLSErrors):
1690         (httpsServerCallback):
1691         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1692         (testWebViewCreateNavigationData):
1693         (testWebViewJavaScriptDialogs):
1694         (testWebViewWindowProperties):
1695         (testWebViewMouseTarget):
1696         (testWebViewFileChooserRequest):
1697         (testWebViewColorChooserRequest):
1698         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1699         (testWebExtensionGetTitle):
1700         (testDocumentLoadedSignal):
1701         (testWebKitWebViewProcessCrashed):
1702         (testWebExtensionWindowObjectCleared):
1703         (testWebExtensionIsolatedWorld):
1704         (permissionRequestCallback):
1705         (didAssociateFormControlsCallback):
1706         (testWebExtensionFormControlsAssociated):
1707         (FormSubmissionTest::FormSubmissionTest):
1708         (FormSubmissionTest::testFormSubmissionResult):
1709         (testWebExtensionFormSubmissionSteps):
1710         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1711         (testNotInitialized):
1712         (testClearDatabase):
1713         (testPrivateBrowsing):
1714         (testGetFavicon):
1715         (testWebViewFavicon):
1716         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
1717         (testFindControllerTextFound):
1718         (testFindControllerTextNotFound):
1719         (testFindControllerMatchCount):
1720         (testFindControllerMaxMatchCount):
1721         (testFindControllerNext):
1722         (testFindControllerPrevious):
1723         (testFindControllerCountedMatches):
1724         (testFindControllerOptions):
1725         (testFindControllerHide):
1726         (testFindControllerInstance):
1727         (testFindControllerGetters):
1728         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
1729         (testNavigationPolicy):
1730         (testResponsePolicy):
1731         (testNewWindowPolicy):
1732         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
1733         (testSecurityOriginBasicConstructor):
1734         (testSecurityOriginURIConstructor):
1735         (testSecurityOriginDefaultPort):
1736         (testSecurityOriginFileURI):
1737         (testOpaqueSecurityOrigin):
1738         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1739         (testWebKitSettings):
1740         (testWebKitSettingsNewWithSettings):
1741         (testWebKitSettingsUserAgent):
1742         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1743         (testWebViewNewWithUserContentManager):
1744         (isStyleSheetInjectedForURLAtPath):
1745         (isScriptInjectedForURLAtPath):
1746         (testUserContentManagerInjectedStyleSheet):
1747         (testUserContentManagerInjectedScript):
1748         (UserScriptMessageTest::scriptMessageReceived):
1749         (UserScriptMessageTest::waitUntilMessageReceived):
1750         (UserScriptMessageTest::runJavaScriptFinished):
1751         (testUserContentManagerScriptMessageReceived):
1752         (testUserContentManagerScriptMessageInWorldReceived):
1753         (testUserContentManagerScriptMessageFromDOMBindings):
1754         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1755         (testWebContextDefault):
1756         (testWebContextEphemeral):
1757         (testWebContextGetPlugins):
1758         (testWebContextURIScheme):
1759         (testWebContextSpellChecker):
1760         (testWebContextLanguages):
1761         (consoleMessageReceivedCallback):
1762         (testWebContextSecurityFileXHR):
1763         (ProxyTest::ProxyTest):
1764         (testWebContextProxySettings):
1765         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1766         (testWebViewWebContext):
1767         (testWebViewWebBackend):
1768         (testWebViewEphemeral):
1769         (testWebViewCustomCharset):
1770         (testWebViewSettings):
1771         (testWebViewRunJavaScript):
1772         (testWebViewCanShowMIMEType):
1773         (testWebViewSubmitForm):
1774         (testWebViewSave):
1775         (testWebViewPageVisibility):
1776         (testWebViewSnapshot):
1777         (testWebViewNotification):
1778         (testWebViewNotificationInitialPermissionAllowed):
1779         (testWebViewNotificationInitialPermissionDisallowed):
1780         (testWebViewIsPlayingAudio):
1781         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1782         (WebsiteDataTest::WebsiteDataTest):
1783         (WebsiteDataTest::remove):
1784         (WebsiteDataTest::clear):
1785         (testWebsiteDataConfiguration):
1786         (testWebsiteDataEphemeral):
1787         (testWebsiteDataCache):
1788         (testWebsiteDataStorage):
1789         (testWebsiteDataDatabases):
1790         (testWebsiteDataAppcache):
1791         (testWebsiteDataCookies):
1792         (testWebsiteDataDeviceIdHashSalt):
1793         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1794         (emitDocumentLoaded):
1795         (emitURIChanged):
1796         (sendRequestCallback):
1797         (contextMenuCallback):
1798         (consoleMessageSentCallback):
1799         (emitFormControlsAssociated):
1800         (formControlsAssociatedCallback):
1801         (emitFormSubmissionEvent):
1802         (willSubmitFormCallback):
1803         (windowObjectCleared):
1804         (methodCallCallback):
1805         (registerGResource):
1806         (webkit_web_extension_initialize_with_user_data):
1807         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
1808         (checkLeaks):
1809         (WebProcessTest::create):
1810         (runTest):
1811         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
1812         (AutocleanupsTest::testWebProcessAutocleanups):
1813         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
1814         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
1815         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
1816         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
1817         (WebKitDOMDOMWindowTest::testSignals):
1818         (WebKitDOMDOMWindowTest::testDispatchEvent):
1819         (WebKitDOMDOMWindowTest::testGetComputedStyle):
1820         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
1821         (WebKitDOMNodeFilterTest::testTreeWalker):
1822         (WebKitDOMNodeFilterTest::testNodeIterator):
1823         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
1824         (WebKitDOMNodeTest::testHierarchyNavigation):
1825         (WebKitDOMNodeTest::testInsertion):
1826         (WebKitDOMNodeTest::testTagNamesNodeList):
1827         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1828         (WebKitDOMNodeTest::testDOMCache):
1829         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
1830         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
1831         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1832         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1833         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
1834         (testUIProcessAutocleanups):
1835         (testWebProcessAutocleanups):
1836         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1837         (testContextMenuPopulateMenu):
1838         (testContextMenuDismissed):
1839         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
1840         (testWebKitDOMClientRectDivBoundingClientRectPosition):
1841         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
1842         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
1843         (testWebKitDOMDOMWindowSignals):
1844         (testWebKitDOMDOMWindowDispatchEvent):
1845         (testWebKitDOMDOMWindowGetComputedStyle):
1846         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
1847         (testWebKitDOMNodeHierarchyNavigation):
1848         (testWebKitDOMNodeInsertion):
1849         (testWebKitDOMNodeTagNamesNodeList):
1850         (testWebKitDOMNodeTagNamesHTMLCollection):
1851         (testWebKitDOMObjectCache):
1852         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
1853         (testWebKitDOMNodeFilterTreeWalker):
1854         (testWebKitDOMNodeFilterNodeIterator):
1855         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
1856         (testWebKitDOMXPathNSResolverNative):
1857         (testWebKitDOMXPathNSResolverCustom):
1858         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
1859         (testInspectorDefault):
1860         (testInspectorManualAttachDetach):
1861         (testInspectorCustomContainerDestroyed):
1862         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
1863         (startTestServer):
1864         (testInspectorServerPageList):
1865         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
1866         (OptionMenuTest::showOptionMenuCallback):
1867         (OptionMenuTest::menuCloseCallback):
1868         (OptionMenuTest::close):
1869         (OptionMenuTest::activateItem):
1870         (OptionMenuTest::selectItem):
1871         (testOptionMenuSimple):
1872         (testOptionMenuGroups):
1873         (testOptionMenuActivate):
1874         (testOptionMenuSelect):
1875         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
1876         (testPrintOperationPrintSettings):
1877         (webViewPrintCallback):
1878         (testPrintOperationPrint):
1879         (testPrintCustomWidget):
1880         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1881         (checkAtspiAccessible):
1882         (testAtspiBasicHierarchy):
1883         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
1884         (testWebKitCheckVersion):
1885         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
1886         (testWebViewEditorCutCopyPasteNonEditable):
1887         (testWebViewEditorCutCopyPasteEditable):
1888         (testWebViewEditorSelectAllNonEditable):
1889         (testWebViewEditorSelectAllEditable):
1890         (loadContentsAndTryToCutSelection):
1891         (testWebViewEditorNonEditable):
1892         (testWebViewEditorEditable):
1893         (testWebViewEditorEditorStateTypingAttributes):
1894         (testWebViewEditorInsertImage):
1895         (testWebViewEditorCreateLink):
1896         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1897         (loadChangedCallback):
1898         (loadFailedCallback):
1899         (loadFailedWithTLSErrorsCallback):
1900         (LoadTrackingTest::LoadTrackingTest):
1901         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1902         (registerGResource):
1903         (removeNonEmptyDirectory):
1904         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1905         (Test::adoptView):
1906         (Test::~Test):
1907         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1908         (WebKitTestBus::getOrCreateConnection):
1909         (WebKitTestBus::createProxy):
1910         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
1911         (WebKitTestServer::getWebSocketURIForPath const):
1912         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1913         (WebViewTest::initializeWebView):
1914         (WebViewTest::loadURI):
1915         (WebViewTest::loadHtml):
1916         (WebViewTest::loadPlainText):
1917         (WebViewTest::loadBytes):
1918         (WebViewTest::loadRequest):
1919         (WebViewTest::loadAlternateHTML):
1920         (WebViewTest::goBack):
1921         (WebViewTest::goForward):
1922         (WebViewTest::goToBackForwardListItem):
1923         (resourceGetDataCallback):
1924         (WebViewTest::mainResourceData):
1925         (WebViewTest::javascriptResultToCString):
1926         (WebViewTest::javascriptResultToNumber):
1927         (WebViewTest::javascriptResultToBoolean):
1928         (WebViewTest::javascriptResultIsNull):
1929         (WebViewTest::javascriptResultIsUndefined):
1930         (onSnapshotReady):
1931         (WebViewTest::runWebProcessTest):
1932         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
1933         (WebViewTest::platformInitializeWebView):
1934         (WebViewTest::showInWindow):
1935         (WebViewTest::showInWindowAndWaitUntilMapped):
1936         (WebViewTest::mouseMoveTo):
1937         (WebViewTest::emitPopupMenuSignal):
1938         (WebViewTest::keyStroke):
1939         (WebViewTest::doMouseButtonEvent):
1940
1941 2019-01-09  Philippe Normand  <pnormand@igalia.com>
1942
1943         [WPE] API tests can't run in flatpak environment
1944         https://bugs.webkit.org/show_bug.cgi?id=193242
1945
1946         Reviewed by Michael Catanzaro.
1947
1948         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
1949         flatpakutils so that it knows which port it's dealing with.
1950         * glib/common.py: Remove build_dir globals so that subsequent
1951         calls actually take args into account.
1952         (library_build_path):
1953         (binary_build_path):
1954
1955 2019-01-08  Dean Jackson  <dino@apple.com>
1956
1957         Blob references for System Previews don't get a correct file extension
1958         https://bugs.webkit.org/show_bug.cgi?id=193268
1959         <rdar://problem/47133037>
1960
1961         Reviewed by Tim Horton.
1962
1963         New test that a Blob download of a USDZ file gets named correctly.
1964
1965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1966         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1967         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1968         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
1969         (TEST):
1970         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
1971
1972 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
1973
1974         [WebAuthN] Support U2F HID Authenticators on macOS
1975         https://bugs.webkit.org/show_bug.cgi?id=191535
1976         <rdar://problem/47102027>
1977
1978         Reviewed by Brent Fulgham.
1979
1980         This patch:
1981         1) adds support for U2F mocking mechanism;
1982         2) updates tests to reflect U2fCommandConstructor changes.
1983
1984         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
1985         (TestWebKitAPI::TEST):
1986         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1987         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1988         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1989
1990 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1991
1992         [iOS] Dispatch a synthetic mousedown event prior to starting drags
1993         https://bugs.webkit.org/show_bug.cgi?id=193229
1994         <rdar://problem/46717097>
1995
1996         Reviewed by Tim Horton.
1997
1998         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
1999         prevents a drag from starting.
2000
2001         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2002         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
2003
2004         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
2005
2006 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
2007   
2008         Layout test will generate a perf metric file to results dir.
2009         https://bugs.webkit.org/show_bug.cgi?id=192030
2010         <rdar://problem/32779516>
2011
2012         Reviewed by Aakash Jain.
2013
2014         Layout test running time will be collected to a perf metric file.
2015         For now, instead of outputing running time of all tests (which is huge),
2016         we aggregate them by test directories which are at most two level deep. 
2017
2018         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2019         (Manager._end_test_run):
2020         (Manager._output_perf_metrics):
2021         (Manager._print_expectation_line_for_test):
2022         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2023         (add_test_perf_metric):
2024         (test_perf_metrics):
2025         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2026         (JSONGeneratorTest.test_test_timings_trie):
2027         (JSONGeneratorTest):
2028         (JSONGeneratorTest.test_test_perf_metrics):
2029         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2030         (RebaselineTest.test_reset_results):
2031         (RebaselineTest.test_missing_results):
2032         (RebaselineTest.test_new_baseline):
2033
2034 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
2035
2036         [WPE][GTK] Add php-json to install-dependencies
2037         https://bugs.webkit.org/show_bug.cgi?id=193233
2038
2039         Reviewed by Michael Catanzaro.
2040
2041         * gtk/install-dependencies:
2042         * wpe/install-dependencies:
2043
2044 2019-01-08  Chris Dumez  <cdumez@apple.com>
2045
2046         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
2047         https://bugs.webkit.org/show_bug.cgi?id=193224
2048         <rdar://problem/47097726>
2049
2050         Reviewed by Alex Christensen.
2051
2052         Add API test coverage.
2053
2054         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2055
2056 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2057
2058         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
2059         <https://webkit.org/b/193222>
2060         <rdar://problem/46862309>
2061
2062         Reviewed by Joseph Pecoraro.
2063
2064         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2065         (WTR::executeCallback): Fix camel case of variable name.
2066         (WTR::EventSendingController::callAfterScrollingCompletes): If
2067         WKBundlePageRegisterScrollOperationCompletionCallback() returns
2068         false, make sure to release the ScrollCompletionCallbackData
2069         object.  This fixes the leak.
2070
2071 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2072
2073         [Win] EWS: wincairo-ews cannot apply a patch with *.png
2074         https://bugs.webkit.org/show_bug.cgi?id=193044
2075
2076         Reviewed by Daniel Bates.
2077
2078         WinCairo EWS bots are using Windows Perl. Binary files should be
2079         opened as binary mode.
2080
2081         * Scripts/svn-apply:
2082         (handleGitBinaryChange): Use 'binmode' for binary file handles.
2083
2084 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
2085
2086         [CMake] Add ENABLE_CSS_TYPED_OM option
2087         https://bugs.webkit.org/show_bug.cgi?id=193216
2088
2089         Reviewed by Michael Catanzaro.
2090
2091         * Scripts/webkitperl/FeatureList.pm:
2092
2093 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2094
2095         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
2096         <https://webkit.org/b/193056>
2097
2098         Reviewed by Alex Christensen.
2099
2100         * Scripts/webkitpy/style/checker.py:
2101         - Ignore use of new runtime/retainptr check in
2102           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
2103           contains tests to ensure RetainPtr<NSObject *> is compatible
2104           with RetainPtr<NSObject>.
2105
2106         * Scripts/webkitpy/style/checkers/cpp.py:
2107         (check_language):
2108         (CppChecker):
2109         - Add checker for use of '*' in RetainPtr<> type.  A for loop
2110           was used instead of a single regex so that angle brackets
2111           could be matched up when checking the type contained within
2112           the RetainPtr<> type.
2113
2114         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2115         (CppStyleTest):
2116         - Add unit test for new runtime/retainptr check.
2117
2118         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
2119         * TestWebKitAPI/EditingTestHarness.h:
2120         - Remove '*' from RetainPtr<> type.
2121
2122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2123         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
2124           regressed in r201938.
2125
2126         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2127         (TestWebKitAPI::TEST):
2128         - Update tests to match RetainPtr.mm tests (except for the
2129           `*SimilarNSType` tests since there is no CF equivalent of
2130           RetainPtr<NSString> and RetainPtr<NSString *>).
2131
2132         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2133         (TestWebKitAPI::TEST):
2134         - Update tests to:
2135           - Not conflict by name with equivalent CF tests in
2136             RetainPtr.cpp.
2137           - Add test cases for RetainPtr<NSObject>,
2138             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
2139           - Add `*SimilarNSType` tests for converting between
2140             RetainPtr<NSObject> and RetainPtr<NSObject *>.
2141           - Change `0` to `nil` as appropriate.
2142           - Re-alphabetize the tests by name.
2143           - Add Optional<RetainPtr<>> tests.
2144           - Add retainPtr() tests.
2145
2146         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2147         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2148         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
2149         (TEST):
2150         - Remove '*' from RetainPtr<> type.
2151
2152         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
2153         (TEST(WebKit, JITEnabled)):
2154         - Add missing WTFMove().  Apparently a temporary was being
2155           created before in the argument list due to mismatched
2156           RetainPtr<> types.
2157
2158         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2159         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2160         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
2161         (TestWebKitAPI::TEST):
2162         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2163         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2164         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2165         (WTR::resourcesDirectoryURL):
2166         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2167         (WTR::InjectedBundle::platformInitialize):
2168         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2169         - Remove '*' from RetainPtr<> type.
2170
2171 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
2172
2173         A MediaTime timescale must never be zero
2174         https://bugs.webkit.org/show_bug.cgi?id=193156
2175         <rdar://problem/32504501>
2176
2177         Reviewed by Jer Noble.
2178
2179         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2180         (TestWebKitAPI::TEST): Add tests for zero timescale.
2181
2182 2019-01-07  Youenn Fablet  <youenn@apple.com>
2183
2184         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
2185         https://bugs.webkit.org/show_bug.cgi?id=193175
2186
2187         Reviewed by Chris Dumez.
2188
2189         Updated API test as we bumped the SW schema to version 4.
2190
2191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2192         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
2193         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2194         (TEST):
2195
2196 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2197
2198         [Win][Clang] Fix compilation warnings of MiniBrowser
2199         https://bugs.webkit.org/show_bug.cgi?id=193029
2200
2201         Reviewed by Ross Kirsling.
2202
2203         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
2204         and m_URLBarFont. Reorder member variables to fix -Wreorder
2205         warning.
2206         * MiniBrowser/win/PageLoadTestClient.cpp:
2207         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
2208         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
2209         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
2210         m_currentURLIndex.
2211         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2212         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
2213         navigationClient with '{ }' to fix the missing field warning.
2214         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2215         (initDocStruct): Changed the argument type docname to const.
2216
2217 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
2218
2219         [WebAuthN] Import U2F command/response converters from Chromium
2220         https://bugs.webkit.org/show_bug.cgi?id=193150
2221         <rdar://problem/47054028>
2222
2223         Reviewed by Brent Fulgham.
2224
2225         Adds API tests.
2226
2227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2228         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2229         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
2230         (TestWebKitAPI::getTestAuthenticatorDataBytes):
2231         (TestWebKitAPI::getTestAttestationObjectBytes):
2232         (TestWebKitAPI::getTestSignResponse):
2233         (TestWebKitAPI::getTestU2fRegisterResponse):
2234         (TestWebKitAPI::TEST):
2235         (TestWebKitAPI::convertToVector): Deleted.
2236         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2237         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
2238         (TestWebKitAPI::constructMakeCredentialRequest):
2239         (TestWebKitAPI::constructGetAssertionRequest):
2240         (TestWebKitAPI::TEST):
2241
2242 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
2243
2244         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
2245         https://bugs.webkit.org/show_bug.cgi?id=193136
2246
2247         Reviewed by Michael Catanzaro.
2248
2249         * gtk/install-dependencies:
2250         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
2251         they are needed by update-webkitgtk-libs.
2252
2253 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
2254
2255         Unreviewed follow-up fix to r239650
2256         https://bugs.webkit.org/show_bug.cgi?id=193140
2257         <rdar://problem/47063037>
2258
2259         Typecast patch_id to string.
2260
2261         * BuildSlaveSupport/ews-build/steps.py:
2262         (ValidatePatch._is_patch_obsolete):
2263
2264 2019-01-04  Daniel Bates  <dabates@apple.com>
2265
2266         [lldb-webkit]: Add support for pretty-printing raw bitmask types
2267         https://bugs.webkit.org/show_bug.cgi?id=193024
2268
2269         Reviewed by Jer Noble.
2270
2271         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
2272         for the bitmask type WebEventFlags as an example.
2273
2274         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
2275         that can be used to register summary and synthetic child formatters for a bitmask type.
2276         For example, consider the following enum and bitmask typedefs:
2277
2278         typedef enum {
2279             A = 1 << 0,
2280             B = 1 << 1,
2281             C = 1 << 2,
2282         } SpecialFlagValues;
2283         typedef unsigned SpecialFlags;
2284
2285         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
2286         __lldb_init_module():
2287
2288             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
2289                     1 << 0: "A",
2290                     1 << 1: "B",
2291                     1 << 2: "C",
2292             })
2293
2294         * lldb/lldb_webkit.py:
2295         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2296         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
2297         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
2298         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
2299         A convenience function to dynamically creaste a synthetic formatter class and summary
2300         string function for the specified bitmask type and enumerator value to name map. This
2301         function register the dynamically created class and function with LLDB.
2302
2303         (__lldb_init_module):
2304         (FlagEnumerationProvider):
2305         (FlagEnumerationProvider._enumerator_value_to_name_map):
2306         (FlagEnumerationProvider._bitmask):
2307         (FlagEnumerationProvider._update):
2308         (FlagEnumerationProvider.has_children):
2309         (FlagEnumerationProvider.num_children):
2310         (FlagEnumerationProvider.get_child_index):
2311         (FlagEnumerationProvider.get_child_at_index):
2312         (FlagEnumerationProvider.update):
2313         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
2314
2315         (WTFOptionSetProvider):
2316         (WTFOptionSetProvider._enumerator_value_to_name_map):
2317         (WTFOptionSetProvider._bitmask):
2318         (WTFOptionSetProvider._update):
2319         Write in terms of the base class.
2320
2321         (RawBitmaskProviderBase):
2322         (RawBitmaskProviderBase._enumerator_value_to_name_map):
2323         (RawBitmaskProviderBase._bitmask):
2324         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
2325         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
2326         {
2327             1 << 0: "A",
2328             1 << 1: "B",
2329             1 << 2: "C",
2330         }
2331         It is not necessary to instantiate such a derived class directory. Instead use the convenience
2332         function addSummaryAndSyntheticFormattersForRawBitmaskType.
2333
2334         (WTFOptionSetProvider.has_children): Deleted.
2335         (WTFOptionSetProvider.num_children): Deleted.
2336         (WTFOptionSetProvider.get_child_index): Deleted.
2337         (WTFOptionSetProvider.get_child_at_index): Deleted.
2338         (WTFOptionSetProvider.update): Deleted.
2339
2340 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2341
2342         [ews-build] Add build step to validate the patch before processing it
2343         https://bugs.webkit.org/show_bug.cgi?id=193140
2344
2345         Reviewed by Lucas Forschler.
2346
2347         * BuildSlaveSupport/ews-build/factories.py:
2348         (Factory.__init__): Added ValidatePatch step.
2349         * BuildSlaveSupport/ews-build/steps.py:
2350         (ValidatePatch):
2351         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
2352         (ValidatePatch.get_patch_json): Get patch json data.
2353         (ValidatePatch.get_bug_json): Get bug json data.
2354         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
2355         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
2356         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
2357         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
2358         (ValidatePatch.skip_build): Skip the build.
2359         (ValidatePatch.start):
2360
2361 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2362
2363         Progress towards fixing Mac CMake build
2364         https://bugs.webkit.org/show_bug.cgi?id=193105
2365
2366         Reviewed by Don Olmstead.
2367
2368         * TestWebKitAPI/PlatformMac.cmake:
2369
2370 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2371
2372         Fix API test after r239631
2373         https://bugs.webkit.org/show_bug.cgi?id=193118
2374
2375         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2376         (TestWebKitAPI::TEST):
2377         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
2378         Do the same thing via the API to fix the test.
2379
2380 2019-01-04  Jer Noble  <jer.noble@apple.com>
2381
2382         [WebKitLegacy] Media playback pauses on scroll
2383         https://bugs.webkit.org/show_bug.cgi?id=192829
2384
2385         Reviewed by Eric Carlson.
2386
2387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2388         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
2389         (TestWebKitAPI::TEST):
2390         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
2391         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
2392         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
2393         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
2394         (TestWebKitAPI::TEST):
2395
2396 2019-01-04  Chris Dumez  <cdumez@apple.com>
2397
2398         Add support for toggling device orientation API support per site
2399         https://bugs.webkit.org/show_bug.cgi?id=193143
2400         <rdar://problem/46605724>
2401
2402         Reviewed by Alex Christensen.
2403
2404         Add API test coverage.
2405
2406         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2407         (-[DataMappingSchemeHandler setTaskHandler:]):
2408         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
2409         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
2410         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2411         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
2412
2413 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2414
2415         [ews-build] use svn-apply script to apply the patches
2416         https://bugs.webkit.org/show_bug.cgi?id=193138
2417
2418         Reviewed by Lucas Forschler.
2419
2420         * BuildSlaveSupport/ews-build/factories.py:
2421         (Factory.__init__): Add the ApplyPatch step.
2422         * BuildSlaveSupport/ews-build/steps.py:
2423         (CheckOutSource): Added step name.
2424         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
2425         (ApplyPatch): Build step to apply patch using svn-apply script.
2426         (UnApplyPatchIfRequired):
2427         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
2428
2429 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2430
2431         Deprecate WKContextCreate
2432         https://bugs.webkit.org/show_bug.cgi?id=193118
2433
2434         Reviewed by Brady Eidson.
2435
2436         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2437         (WebKitBrowserWindow::WebKitBrowserWindow):
2438         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
2439         (TestWebKitAPI::TEST):
2440         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2441         (TestWebKitAPI::TEST):
2442         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2443         (TestWebKitAPI::TEST):
2444         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
2445         (TestWebKitAPI::TEST):
2446         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
2447         (TestWebKitAPI::TEST):
2448         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2449         (TestWebKitAPI::TEST):
2450         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2451         (TestWebKitAPI::TEST):
2452         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2453         (TestWebKitAPI::TEST):
2454         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2455         (TestWebKitAPI::TEST):
2456         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2457         (TestWebKitAPI::TEST):
2458         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2459         (TestWebKitAPI::TEST):
2460         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2461         (TestWebKitAPI::TEST):
2462         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2463         (TestWebKitAPI::TEST):
2464         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2465         (TestWebKitAPI::TEST):
2466         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2467         (TestWebKitAPI::TEST):
2468         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2469         (TestWebKitAPI::TEST):
2470         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2471         (TestWebKitAPI::TEST):
2472         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2473         (TestWebKitAPI::TEST):
2474         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2475         (TestWebKitAPI::loadAlternateHTMLString):
2476         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2477         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2478         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2479         (TestWebKitAPI::buildAndPerformTest):
2480         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2481         (TestWebKitAPI::TEST):
2482         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
2483         (TestWebKitAPI::TEST):
2484         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
2485         (TestWebKitAPI::TEST):
2486         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2487         (TestWebKitAPI::TEST):
2488         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2489         (TestWebKitAPI::TEST):
2490         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2491         (TestWebKitAPI::TEST):
2492         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2493         (TestWebKitAPI::TEST):
2494         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2495         (TestWebKitAPI::TEST):
2496         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2497         (TestWebKitAPI::TEST):
2498         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2499         (TestWebKitAPI::TEST):
2500         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2501         (TestWebKitAPI::TEST):
2502         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2503         (TestWebKitAPI::TEST):
2504         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2505         (TestWebKitAPI::TEST):
2506         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2507         (TestWebKitAPI::TEST):
2508         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2509         (TestWebKitAPI::TEST):
2510         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2511         (TestWebKitAPI::TEST):
2512         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2513         (TestWebKitAPI::TEST):
2514         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2515         (TestWebKitAPI::TEST):
2516         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
2517         (TestWebKitAPI::TEST):
2518         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2519         (TestWebKitAPI::TEST):
2520         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2521         (TestWebKitAPI::TEST):
2522         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2523         (TestWebKitAPI::TEST):
2524         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2525         (TestWebKitAPI::TEST):
2526         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
2527         (TestWebKitAPI::TEST):
2528         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2529         (TestWebKitAPI::TEST):
2530         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2531         (TestWebKitAPI::TEST):
2532         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2533         (WebKit2_CommandBackForwardTestWKView::SetUp):
2534         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2535         (TestWebKitAPI::TEST):
2536         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2537         (TestWebKitAPI::TEST):
2538         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
2539         (TestWebKitAPI::TEST):
2540         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2541         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2542
2543 2019-01-03  Matt Rajca  <mrajca@apple.com>
2544
2545         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
2546         https://bugs.webkit.org/show_bug.cgi?id=193128
2547         rdar://34554231
2548
2549         Reviewed by Jer Noble.
2550
2551         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
2552         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
2553         event along with a flag that indicates whether or not autoplay was actually prevented.
2554
2555         Tests: existing API tests were updated to reflect the new names. New API tests
2556         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
2557
2558         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2559         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
2560         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2561         (TEST):
2562         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
2563         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
2564
2565 2019-01-04  Chris Dumez  <cdumez@apple.com>
2566
2567         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
2568         https://bugs.webkit.org/show_bug.cgi?id=193120
2569
2570         Reviewed by Alex Christensen.
2571
2572         Add API test coverage.
2573
2574         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2575
2576 2019-01-04  Chris Dumez  <cdumez@apple.com>
2577
2578         Crash under WebProcessPool::addSuspendedPage()
2579         https://bugs.webkit.org/show_bug.cgi?id=193110
2580
2581         Reviewed by Youenn Fablet.
2582
2583         Add API test coverage.
2584
2585         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2586
2587 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2588
2589         [ews-build] Check patch relevance before applying the patch
2590         https://bugs.webkit.org/show_bug.cgi?id=193102
2591
2592         Reviewed by Lucas Forschler.
2593
2594         * BuildSlaveSupport/ews-build/factories.py:
2595         (Factory.__init__): Moved CheckPatchRelevance step to base class.
2596
2597 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2598
2599         [ews-build] Check patch relevance step should print patch id
2600         https://bugs.webkit.org/show_bug.cgi?id=193137
2601
2602         Reviewed by Lucas Forschler.
2603
2604         * BuildSlaveSupport/ews-build/steps.py:
2605         (CheckPatchRelevance.start): Update the status to include patch id.
2606
2607 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
2608
2609         webkitpy: Increase simulator teardown timeout
2610         https://bugs.webkit.org/show_bug.cgi?id=193141
2611         <rdar://problem/46174217>
2612
2613         Rubber-stamped by Aakash Jain.
2614
2615         * Scripts/webkitpy/xcode/simulated_device.py:
2616         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
2617
2618 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
2619
2620         test262-runner misbehaves when test file YAML has a trailing space
2621         https://bugs.webkit.org/show_bug.cgi?id=193053
2622
2623         Reviewed by Yusuke Suzuki.
2624
2625         * Scripts/test262/Runner.pm:
2626         (parseData):
2627         Accept trailing space when parsing a test file's YAML block.
2628
2629 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2630
2631         UserMedia test should use WKPageNavigationClient
2632         https://bugs.webkit.org/show_bug.cgi?id=192913
2633
2634         Reviewed by Youenn Fablet.
2635
2636         The test currently uses the deprecated WKPageLoaderClient. It should use
2637         WKPageNavigationClient instead, which provides the same callback under a similar name.
2638
2639         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2640         (TestWebKitAPI::TEST):
2641
2642 2019-01-02  Alex Christensen  <achristensen@webkit.org>
2643
2644         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
2645         https://bugs.webkit.org/show_bug.cgi?id=192944
2646
2647         Reviewed by Tim Horton.
2648
2649         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2650         (TestWebKitAPI::TEST):
2651
2652 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2653
2654         Add support for using the current text selection as the find string on iOS
2655         https://bugs.webkit.org/show_bug.cgi?id=193034
2656         <rdar://problem/45138739>
2657
2658         Reviewed by Tim Horton.
2659
2660         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
2661         _setStringForFind) works as expected.
2662
2663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2664         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
2665
2666 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
2667
2668         [ews-build] Use git on OpenSource EWS bots
2669         https://bugs.webkit.org/show_bug.cgi?id=193092
2670
2671         Reviewed by Lucas Forschler.
2672
2673         * BuildSlaveSupport/ews-build/steps.py:
2674         (CheckOutSource): Use git instead of svn.
2675         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
2676
2677 2019-01-02  Daniel Bates  <dabates@apple.com>
2678
2679         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
2680         https://bugs.webkit.org/show_bug.cgi?id=193023
2681
2682         Reviewed by Simon Fraser.
2683
2684         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
2685         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
2686         enumerator values. We should just remove this code.
2687
2688         * lldb/lldb_webkit.py:
2689         (WTFOptionSetProvider.has_children):
2690         (WTFOptionSetProvider.num_children):
2691         (WTFOptionSetProvider.get_child_index):
2692         (WTFOptionSetProvider.get_child_at_index):
2693
2694 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2695
2696         .ycm_extra_conf.py should handle XXXInlines.h
2697         https://bugs.webkit.org/show_bug.cgi?id=193055
2698
2699         Reviewed by Carlos Garcia Campos.
2700
2701         compile_commands.json database only records flags and options for cpp source files.
2702         So, when we open headers, this database does not have any information for that.
2703         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
2704         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
2705         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
2706         we attempt to find XXX.cpp and use the configuration if it exists.
2707
2708         * gtk/ycm_extra_conf.py:
2709         (getImplementationFilename):
2710         (FlagsForFile):
2711
2712 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2713
2714         Unreviewed. Support PHP 7.3 in Debian.
2715
2716         Add 7.3 to the list of php versions supported in Debian.
2717
2718         * Scripts/webkitpy/port/base.py:
2719         (Port._debian_php_version):
2720
2721 2018-12-27  Alex Christensen  <achristensen@webkit.org>
2722
2723         Resurrect Mac CMake build
2724         https://bugs.webkit.org/show_bug.cgi?id=192658
2725
2726         Reviewed by Yusuke Suzuki.
2727
2728         * DumpRenderTree/PlatformMac.cmake:
2729         * MiniBrowser/mac/CMakeLists.txt:
2730         * TestWebKitAPI/PlatformMac.cmake:
2731
2732 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
2733
2734         [Tools] Remove references to Bison and Flex
2735         https://bugs.webkit.org/show_bug.cgi?id=193033
2736
2737         Reviewed by Michael Catanzaro.
2738
2739         The Bison and Flex tools are not needed anymore since r209883.
2740
2741         * CygwinDownloader/cygwin-downloader.py:
2742         * EWSTools/ubuntu-ews-packages:
2743         * Scripts/filter-build-webkit:
2744         (shouldIgnoreLine):
2745         * gtk/install-dependencies:
2746         * wpe/install-dependencies:
2747
2748 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2749
2750         WebDriver: warn about non existing tests when parsing expectations
2751         https://bugs.webkit.org/show_bug.cgi?id=192979
2752
2753         Reviewed by Michael Catanzaro.
2754
2755         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
2756         renamed.
2757
2758         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2759         (WebDriverTestRunner.__init__):
2760
2761 2018-12-21  Chris Dumez  <cdumez@apple.com>
2762
2763         navigator.userAgent in service workers does not reflect customUserAgent set by client
2764         https://bugs.webkit.org/show_bug.cgi?id=192951
2765
2766         Reviewed by Youenn Fablet.
2767
2768         Extend API test coverage.
2769
2770         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2771         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
2772         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2773         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
2774         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2775
2776 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2777
2778         [WebAuthN] userPresence should always be true
2779         https://bugs.webkit.org/show_bug.cgi?id=192835
2780         <rdar://problem/46538788>
2781
2782         Reviewed by Brent Fulgham.
2783
2784         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2785         (TestWebKitAPI::TEST):
2786
2787 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
2788
2789         Add support to run-benchmark to use non-default copies of the browser apps
2790         https://bugs.webkit.org/show_bug.cgi?id=192905
2791         rdar://problem/46845840
2792
2793         Reviewed by Dewei Zhu.
2794         
2795         Add support for a --browser-path argument to run-benchmark, which allows you to use
2796         a custom app bundle for a given browser (only implemented for Safari at present).
2797
2798         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2799         (BenchmarkRunner.__init__):
2800         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2801         (BrowserDriver.__init__):
2802         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2803         (BrowserDriverFactory.create):
2804         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2805         (OSXBrowserDriver._launch_process):
2806         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
2807         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
2808         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2809         (OSXChromeCanaryDriver.launch_url):
2810         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2811         (OSXFirefoxNightlyDriver.launch_url):
2812         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2813         (OSXSafariDriver.__init__):
2814         (OSXSafariDriver.launch_url):
2815         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2816         (parse_args):
2817         (run_benchmark_plan):
2818         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
2819         (WebServerBenchmarkRunner.__init__):
2820         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
2821         (FakeBenchmarkRunner.__init__):
2822
2823 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2824
2825         [WebAuthN] Import an APDU coder from Chromium
2826         https://bugs.webkit.org/show_bug.cgi?id=192949
2827         <rdar://problem/46879933>
2828
2829         Reviewed by Brent Fulgham.
2830
2831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2832         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
2833         (TestWebKitAPI::TEST):
2834
2835 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2836
2837         Setting the file wrapper and content type of an attachment to a PDF should update its image
2838         https://bugs.webkit.org/show_bug.cgi?id=192984
2839         <rdar://problem/46798028>
2840
2841         Reviewed by Tim Horton.
2842
2843         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
2844         PDF data correctly updates the image element.
2845
2846         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2847
2848 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2849
2850         Add JSCOnly to bot dashboard
2851         https://bugs.webkit.org/show_bug.cgi?id=192964
2852
2853         Reviewed by Alexey Proskuryakov.
2854
2855         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
2856         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
2857         useful if they were not so secret, so add them.
2858
2859         There appear to be no build-only bots, so the first column is blank. And of course there are
2860         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
2861         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
2862         and there's plenty of room in the final column for all the bots.
2863
2864         I had a hard time picking a logo to use, because the JavaScript language does not have an
2865         official logo. But I believe I've found one that will be satisfactory.
2866
2867         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
2868
2869         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
2870         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
2871         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2872         (BubbleQueueServer):
2873         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2874         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2875         (WebKitBuildbot):
2876         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2877         (table.queue-grid tr.platform.linux-jsconly img.logo):
2878
2879 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
2880
2881         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
2882         https://bugs.webkit.org/show_bug.cgi?id=192821
2883
2884         Reviewed by Chris Dumez.
2885
2886         * DumpRenderTree/mac/DumpRenderTree.mm:
2887         (createWebViewAndOffscreenWindow):
2888         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2889
2890 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2891
2892         [Win][Clang] Fix compilation warnings of DumpRenderTree
2893         https://bugs.webkit.org/show_bug.cgi?id=192924
2894
2895         Reviewed by Alex Christensen.
2896
2897         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
2898         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2899         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
2900         * DumpRenderTree/win/DumpRenderTree.cpp:
2901         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
2902         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
2903         object to the argument of setDefaultTextEncodingName instead of a
2904         const string literal.
2905         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
2906         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
2907         (setCacheFolder): Deleted.
2908         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
2909         * DumpRenderTree/win/EditingDelegate.cpp:
2910         (dump): Use %d for int.
2911         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
2912         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2913         (BSTRFromString): Deleted unused function.
2914         * DumpRenderTree/win/TestRunnerWin.cpp:
2915         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
2916         the arguemnt of setQuota instead of const string literal.
2917         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2918         (jsStringRefToWString): Deleted unused function.
2919
2920 2018-12-20  Chris Dumez  <cdumez@apple.com>
2921
2922         Add API test coverage for customUserAgent client setting and service workers
2923         https://bugs.webkit.org/show_bug.cgi?id=192952
2924
2925         Reviewed by Alex Christensen.
2926
2927         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2928         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
2929         (-[SWSchemes webView:startURLSchemeTask:]):
2930         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2931         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2932
2933 2018-12-20  Chris Dumez  <cdumez@apple.com>
2934
2935         Use Optional::hasValue() instead of Optional::has_value()
2936         https://bugs.webkit.org/show_bug.cgi?id=192948
2937
2938         Reviewed by Tim Horton.
2939
2940         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
2941         (TestWebKitAPI::TEST):
2942         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
2943         (TestWebKitAPI::TEST):
2944         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2945         (TestWebKitAPI::TEST_F):
2946
2947 2018-12-20  Chris Dumez  <cdumez@apple.com>
2948
2949         Add style script rule to check for uses of std::optional<>
2950         https://bugs.webkit.org/show_bug.cgi?id=192931
2951
2952         Reviewed by Tim Horton.
2953
2954         * Scripts/webkitpy/style/checkers/cpp.py:
2955         (check_wtf_optional):
2956         (check_style):
2957
2958 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
2959
2960         [WebAuthN] Add a runtime flag for local authenticator
2961         https://bugs.webkit.org/show_bug.cgi?id=192792
2962         <rdar://problem/46798738>
2963
2964         Reviewed by Brent Fulgham.
2965
2966         * DumpRenderTree/TestOptions.cpp:
2967         (TestOptions::TestOptions):
2968         * DumpRenderTree/TestOptions.h:
2969         * DumpRenderTree/mac/DumpRenderTree.mm:
2970         (enableExperimentalFeatures):
2971         (setWebPreferencesForTestOptions):
2972         * WebKitTestRunner/TestController.cpp:
2973         (WTR::TestController::resetPreferencesToConsistentValues):
2974         (WTR::updateTestOptionsFromTestHeader):
2975         * WebKitTestRunner/TestOptions.h:
2976         (WTR::TestOptions::hasSameInitializationOptions const):
2977
2978 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
2979
2980         webkitpy: Autoinstall package URLs have changed
2981         https://bugs.webkit.org/show_bug.cgi?id=192909
2982         <rdar://problem/46860359>
2983
2984         Rubber-stamped by Alexey Proskuryakov.
2985
2986         PyPi urls have been moved around, we need to update our auto-installed packages.
2987
2988         We should check for Selenium before asking PyPi for the latest version.
2989
2990         * Scripts/webkitpy/thirdparty/__init__.py:
2991         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
2992         (AutoinstallImportHook._install_keyring): Ditto.
2993         (AutoinstallImportHook._install_pep8): Ditto.
2994         (AutoinstallImportHook._install_mozlog): Ditto.
2995         (AutoinstallImportHook._install_mozprocess): Ditto.
2996         (AutoinstallImportHook._install_pytest_timeout): Ditto.
2997         (AutoinstallImportHook._install_pytest): Ditto.
2998         (AutoinstallImportHook._install_pylint): Ditto.
2999         (AutoinstallImportHook._install_buildbot): Ditto.
3000         (AutoinstallImportHook._install_coverage): Ditto.
3001         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
3002         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
3003         for new Selenium if the installed version isn't sufficient.
3004         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
3005
3006 2018-12-20  Chris Dumez  <cdumez@apple.com>
3007
3008         Use Optional::valueOr() instead of Optional::value_or()
3009         https://bugs.webkit.org/show_bug.cgi?id=192933
3010
3011         Reviewed by Geoffrey Garen.
3012
3013         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3014         (TestWebKitAPI::checkURL):
3015         (TestWebKitAPI::checkRelativeURL):
3016         (TestWebKitAPI::checkURLDifferences):
3017         (TestWebKitAPI::checkRelativeURLDifferences):
3018         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
3019         (TestWebKitAPI::checkURL):
3020
3021 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
3022
3023         Unreviewed, rolling out r239417.
3024
3025         Introduced two API test failures on macOS.
3026
3027         Reverted changeset:
3028
3029         "<rdar://problem/46194315> macOS: WebKit1 does not handle
3030         occlusion changes"
3031         https://bugs.webkit.org/show_bug.cgi?id=192821
3032         https://trac.webkit.org/changeset/239417
3033
3034 2018-12-20  Devin Rousso  <drousso@apple.com>
3035
3036         Web Inspector: UIString should take an optional key and description to aid localization
3037         https://bugs.webkit.org/show_bug.cgi?id=153962
3038         <rdar://problem/24542505>
3039
3040         Reviewed by Brian Burg.
3041
3042         * Scripts/extract-localizable-js-strings:
3043
3044 2018-12-20  Tim Horton  <timothy_horton@apple.com>
3045
3046         Unparented WKWebView can't retrieve main resource data for a main frame plugin
3047         https://bugs.webkit.org/show_bug.cgi?id=192923
3048         <rdar://problem/46859068>
3049
3050         Reviewed by Wenson Hsieh.
3051
3052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3053         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
3054         Add a test ensuring that both parented and unparented WKWebViews can
3055         retrieve main resource data when loading a PDF.
3056
3057 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3058
3059         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
3060         https://bugs.webkit.org/show_bug.cgi?id=192852
3061
3062         Reviewed by Michael Catanzaro.
3063
3064         EmojiOne font was replaced by Noto Color Emoji.
3065
3066         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
3067         * gtk/jhbuild.modules:
3068         * wpe/jhbuild.modules:
3069
3070 2018-12-19  Chris Dumez  <cdumez@apple.com>
3071
3072         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
3073         https://bugs.webkit.org/show_bug.cgi?id=192728
3074         <rdar://problem/46746779>
3075
3076         Reviewed by Geoff Garen.
3077
3078         * DumpRenderTree/*:
3079         * MiniBrowser/*:
3080         * TestRunnerShared/*:
3081         * TestWebKitAPI/*:
3082         * WebGPUAPIStructure/*:
3083         * WebKitTestRunner/*:
3084
3085 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
3086
3087         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3088         https://bugs.webkit.org/show_bug.cgi?id=192821
3089
3090         Reviewed by Chris Dumez.
3091
3092         * DumpRenderTree/mac/DumpRenderTree.mm:
3093         (createWebViewAndOffscreenWindow):
3094
3095 2018-12-19  Alex Christensen  <achristensen@webkit.org>
3096
3097         Navigations away from the SafeBrowsing interstitial show a flash of old content
3098         https://bugs.webkit.org/show_bug.cgi?id=192676
3099
3100         Reviewed by Chris Dumez.
3101
3102         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3103         (safeBrowsingView):
3104         (TEST):
3105         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3106
3107 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
3108
3109         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
3110         https://bugs.webkit.org/show_bug.cgi?id=192855
3111
3112         Reviewed by Michael Catanzaro.
3113
3114         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3115         (WTR::TestController::notifyDone): Use the WPE implementation.
3116         (WTR::TestController::platformRunUntil): Use the WPE implementation.
3117         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
3118         (WTR::TestController::platformRunUntil): Honor the condition flag.
3119
3120 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
3121
3122         Allow clients to set the navigator platform
3123         https://bugs.webkit.org/show_bug.cgi?id=192735
3124
3125         Reviewed by Tim Horton.
3126
3127         Add a test for setting a custom navigator platform.
3128
3129         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3130         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3131         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
3132
3133 2018-12-19  Truitt Savell  <tsavell@apple.com>
3134
3135         Unreviewed, rolling out r239358.
3136
3137         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
3138         crash on Debug bots
3139
3140         Reverted changeset:
3141
3142         "Clean up IndexedDB files between tests"
3143         https://bugs.webkit.org/show_bug.cgi?id=192796
3144         https://trac.webkit.org/changeset/239358
3145
3146 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3147
3148         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
3149         https://bugs.webkit.org/show_bug.cgi?id=192842
3150         <rdar://problem/46823586>
3151
3152         Reviewed by Tim Horton.
3153
3154         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
3155         item provider when dragging a rich text selection.
3156
3157         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3158
3159 2018-12-18  David Quesada  <david_quesada@apple.com>
3160
3161         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
3162         https://bugs.webkit.org/show_bug.cgi?id=192810
3163         <rdar://problem/46812536>
3164
3165         Reviewed by Alex Christensen.
3166
3167         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3168         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3169             After releasing our reference to the web view, wait until the next turn of the runloop
3170             before checking that the originatingWebView has been zeroed, since the web view might
3171             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
3172             testing general memory management of WKWebViews, only that _WKDownload does not retain
3173             its web view via the 'originatingWebView' property.
3174
3175 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
3176
3177         Clean up IndexedDB files between tests
3178         https://bugs.webkit.org/show_bug.cgi?id=192796
3179
3180         Reviewed by Geoffrey Garen.
3181
3182         * DumpRenderTree/mac/DumpRenderTree.mm:
3183         (runTest):
3184         * WebKitTestRunner/TestController.cpp:
3185         (WTR::TestController::resetStateToConsistentValues):
3186         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3187         (WTR::RemoveAllIndexedDatabasesCallback):
3188         (WTR::TestController::ClearIndexedDatabases):
3189         * WebKitTestRunner/TestController.h:
3190
3191 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3192
3193         Fix API test introduced in r239339 on iOS.
3194         https://bugs.webkit.org/show_bug.cgi?id=192675
3195
3196         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3197         (TEST):
3198         The iOS implementation of the safe browsing warning is a little different.
3199         It does some element creation when it is added to the window so it knows how big it is.
3200         To test these elements, we need to simulate adding it to the window.
3201         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
3202
3203 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
3204
3205         webkitpy: Ignore device type for test when using --force
3206         https://bugs.webkit.org/show_bug.cgi?id=192786
3207         <rdar://problem/46794894>
3208
3209         Reviewed by Daniel Bates.
3210
3211         It is sometimes the case that a contributor will wish to run a test on a specific device,
3212         despite expectations which indicate a test should not be run on that device.
3213
3214         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3215         (parse_args):
3216         * Scripts/webkitpy/port/device_port.py:
3217         (DevicePort.default_child_processes): Strip device type information when using --force.
3218         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
3219
3220 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3221
3222         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
3223         https://bugs.webkit.org/show_bug.cgi?id=192675
3224
3225         Reviewed by Geoffrey Garen.
3226
3227         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3228         (goBack):
3229         (TEST):
3230         (visitUnsafeSite):
3231         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
3232         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3233
3234 2018-12-18  Chris Dumez  <cdumez@apple.com>
3235
3236         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
3237         https://bugs.webkit.org/show_bug.cgi?id=192772
3238
3239         Reviewed by Antti Koivisto.
3240
3241         Add API test coverage.
3242
3243         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3244
3245 2018-12-18  Philippe Normand  <pnormand@igalia.com>
3246
3247         Unreviewed, JHBuild GTK build fix attempt
3248
3249         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
3250         There's no ninja module either, it should be provided by the
3251         host system.
3252
3253 2018-12-17  Chris Dumez  <cdumez@apple.com>
3254
3255         Allow passing nil as session state to [WKWebView _restoreSessionState:]
3256         https://bugs.webkit.org/show_bug.cgi?id=192789
3257         <rdar://problem/46755277>
3258
3259         Reviewed by Alex Christensen.
3260
3261         Add API test coverage.
3262
3263         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3264         (TEST):
3265
3266 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
3267
3268         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
3269         https://bugs.webkit.org/show_bug.cgi?id=192780
3270         rdar://problem/43394387
3271
3272         Reviewed by Tim Horton.
3273
3274         No need to set "AppleFontSmoothing" defaults for WK2.
3275
3276         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3277         (WTR::InjectedBundle::platformInitialize):
3278
3279 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
3280
3281         webkitpy: Handle case where stdout and stderr don't accept unicode
3282         https://bugs.webkit.org/show_bug.cgi?id=192775
3283         <rdar://problem/46497303>
3284
3285         Reviewed by Stephanie Lewis.
3286
3287         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3288         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
3289         characters with '?'.
3290         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3291         (RegularTest.test_stream_with_encoding):
3292
3293 2018-12-17  Daniel Bates  <dabates@apple.com>
3294
3295         Support concatenating StringView with other string types
3296         https://bugs.webkit.org/show_bug.cgi?id=177566
3297
3298         Reviewed by Darin Adler.
3299
3300         Add some tests to ensure we do not regress the number of allocations needed when performing
3301         string concatenation with string views.
3302
3303         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3304         (TestWebKitAPI::TEST):
3305
3306 2018-12-17  Commit Queue  <commit-queue@webkit.org>
3307
3308         Unreviewed, rolling out r239265 and r239274.
3309         https://bugs.webkit.org/show_bug.cgi?id=192765
3310
3311         unorm_normalize is deprecated, and broke an internal build
3312         (Requested by Truitt on #webkit).
3313
3314         Reverted changesets:
3315
3316         "[GTK][WPE] Need a function to convert internal URI to display
3317         ("pretty") URI"
3318         https://bugs.webkit.org/show_bug.cgi?id=174816
3319         https://trac.webkit.org/changeset/239265
3320
3321         "Fix the Apple Internal Mac build with a newer SDK"
3322         https://trac.webkit.org/changeset/239274
3323
3324 2018-12-17  Daniel Bates  <dabates@apple.com>
3325
3326         Implement UIScriptController::toggleCapsLock() for iOS
3327         https://bugs.webkit.org/show_bug.cgi?id=191815
3328
3329         Reviewed by Andy Estes.
3330
3331         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
3332
3333         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3334         * WebKitTestRunner/TestController.cpp:
3335         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
3336         before running a test. This ensures that the caps lock state does not persist between
3337         tests should a test enable caps lock and not disable it.
3338         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3339         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
3340         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3341         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
3342         create the event. Also substituted NSString* for const String& as the data type for the first
3343         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
3344         below.
3345         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
3346         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
3347
3348 2018-12-17  Daniel Bates  <dabates@apple.com>
3349
3350         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
3351         https://bugs.webkit.org/show_bug.cgi?id=192633
3352
3353         Reviewed by Wenson Hsieh.
3354
3355         Update code to use the modern initializer.
3356
3357         * DumpRenderTree/mac/EventSendingController.mm:
3358         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3359
3360 2018-12-17  Matt Lewis  <jlewis3@apple.com>
3361
3362         Unreviewed, rolling out r239254.
3363
3364         This broke the Windows 10 Debug build
3365
3366         Reverted changeset:
3367
3368         "Replace many uses of String::format with more type-safe
3369         alternatives"
3370         https://bugs.webkit.org/show_bug.cgi?id=192742
3371         https://trac.webkit.org/changeset/239254
3372
3373 2018-12-17  David Kilzer  <ddkilzer@apple.com>
3374
3375         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
3376         <https://webkit.org/b/192751>
3377         <rdar://problem/46771623>
3378
3379         Reviewed by Daniel Bates.
3380
3381         Change loop variables to const references to avoid unnecessary
3382         copies.
3383
3384         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
3385         (-[LocalPasteboard pasteboardItems]):
3386
3387 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
3388
3389         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3390         https://bugs.webkit.org/show_bug.cgi?id=174816
3391
3392         Reviewed by Michael Catanzaro.
3393
3394         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
3395
3396         * TestWebKitAPI/CMakeLists.txt:
3397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3398         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
3399         (TestWebKitAPI::TEST):
3400         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3401         (testURIForDisplayUnaffected):
3402         (testURIForDisplayAffected):
3403         (beforeAll):
3404         (afterAll):
3405         * TestWebKitAPI/glib/CMakeLists.txt:
3406
3407 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3408
3409         [WPE] Add API to notify about frame displayed view backend callback
3410         https://bugs.webkit.org/show_bug.cgi?id=192224
3411
3412         Reviewed by Michael Catanzaro.
3413
3414         Add a test case to check the new API.
3415
3416         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3417         (testWebViewFrameDisplayed):
3418         (beforeAll):
3419         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
3420
3421 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
3422
3423         Unreviewed build fix after r239253
3424
3425         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
3426
3427 2018-12-15  Darin Adler  <darin@apple.com>
3428
3429         Use warning-ignoring macros more consistently and simply
3430         https://bugs.webkit.org/show_bug.cgi?id=192743
3431
3432         Reviewed by Mark Lam.
3433
3434         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3435         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
3436         * DumpRenderTree/mac/TextInputControllerMac.m:
3437         (-[TextInputController interpretKeyEvents:withSender:]): Use
3438         IGNORE_WARNINGS_BEGIN/END.
3439         * WebKitTestRunner/mac/EventSenderProxy.mm:
3440         (WTR::EventSenderProxy::mouseForceClick): Use
3441         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
3442         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
3443         (WTR::EventSenderProxy::mouseForceDown): Ditto.
3444         (WTR::EventSenderProxy::mouseForceUp): Ditto.
3445         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
3446
3447 2018-12-15  Darin Adler  <darin@apple.com>
3448
3449         Replace many uses of String::format with more type-safe alternatives
3450         https://bugs.webkit.org/show_bug.cgi?id=192742
3451
3452         Reviewed by Mark Lam.
3453
3454         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3455         (WTR::cacheTestRunnerCallback): Use makeString.
3456         * WebKitTestRunner/TestController.cpp:
3457         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3458         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3459
3460 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
3461
3462         [WPE][GTK] Add libpsl to JHBuild module sets
3463         https://bugs.webkit.org/show_bug.cgi?id=192740
3464
3465         Reviewed by Michael Catanzaro.
3466
3467         * gtk/jhbuild.modules: Add libpsl module.
3468         * wpe/jhbuild.modules: Ditto.
3469
3470 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
3471
3472         Add a style checker rule for Xcode version macros use
3473         https://bugs.webkit.org/show_bug.cgi?id=192703
3474
3475         Reviewed by Alex Christensen.
3476
3477         * Scripts/webkitpy/style/checkers/cpp.py:
3478         (check_os_version_checks):
3479         (process_line):
3480         (CppChecker):
3481         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3482         (WebKitStyleTest.test_os_version_checks):
3483
3484 2018-12-14  Chris Dumez  <cdumez@apple.com>
3485
3486         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
3487         https://bugs.webkit.org/show_bug.cgi?id=192704
3488
3489         Reviewed by Geoffrey Garen.
3490
3491         Extend existing API test to reproduce the problem.
3492
3493         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3494
3495 2018-12-14  Chris Dumez  <cdumez@apple.com>
3496
3497         [PSON] WebsitePolicies are lost on process-swap
3498         https://bugs.webkit.org/show_bug.cgi?id=192694
3499         <rdar://problem/46715748>
3500
3501         Reviewed by Brady Eidson.
3502
3503         Extend existing API test to reproduce the issue.
3504
3505         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3506
3507 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
3508
3509         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
3510         https://bugs.webkit.org/show_bug.cgi?id=192678
3511
3512         Reviewed by Carlos Garcia Campos.
3513
3514         Update our ancient versions of libsoup and glib-networking.
3515
3516         * gtk/install-dependencies:
3517         * gtk/jhbuild.modules:
3518         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
3519         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
3520         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
3521         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
3522         * wpe/install-dependencies:
3523         * wpe/jhbuild.modules:
3524         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
3525
3526 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3527
3528         [WPE] Use new view state API from libwpe
3529         https://bugs.webkit.org/show_bug.cgi?id=191906
3530
3531         Reviewed by Žan Doberšek.
3532
3533         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3534         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
3535         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3536         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
3537         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3538         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3539         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
3540         wpe_view_activity_state_focused state flags.
3541         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
3542         * wpe/backends/HeadlessViewBackend.cpp:
3543         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
3544         * wpe/backends/WindowViewBackend.cpp:
3545         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
3546         received in configure callback.
3547         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
3548
3549 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
3550
3551         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
3552         https://bugs.webkit.org/show_bug.cgi?id=192688
3553
3554         Reviewed by Ross Kirsling.
3555
3556         * win/DLLLauncher/DLLLauncherMain.cpp:
3557         (copyEnvironmentVariable): Moved.
3558         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
3559         (applePathFromRegistry): Ditto.
3560         (appleApplicationSupportDirectory): Ditto.
3561         (prependPath): Ditto.
3562
3563 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
3564
3565         Unreviewed. Changed my status to a reviewer.
3566
3567         * Scripts/webkitpy/common/config/contributors.json:
3568
3569 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3570
3571         [iOS] Support dropping contact card data (public.vcard) in editable content
3572         https://bugs.webkit.org/show_bug.cgi?id=192570
3573         <rdar://problem/35626913>
3574
3575         Reviewed by Tim Horton.
3576
3577         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3578
3579         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
3580         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
3581         additionally inserts a link).
3582
3583         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3584         (TestWebKitAPI::createMapItemForTesting):
3585         (TestWebKitAPI::createContactItemForTesting):
3586
3587         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
3588         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
3589         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
3590         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
3591         files.
3592
3593 2018-12-13  Ross Kirsling  <ross.kirsling@sony.com>
3594
3595         Unreviewed -- update my status to "reviewer".
3596
3597         * Scripts/webkitpy/common/config/contributors.json:
3598
3599 2018-12-13  Youenn Fablet  <youenn@apple.com>
3600
3601         On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
3602         https://bugs.webkit.org/show_bug.cgi?id=192657
3603
3604         Reviewed by Eric Carlson.
3605
3606         Add a test that loads a page registering ondevicechange,
3607         load another page in the same process, closes the first page.
3608         Ensure that the process does not crash in that case.
3609
3610         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3611         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3612         (TestWebKitAPI::TEST):
3613         (TestWebKitAPI::didCrashCallback):
3614         * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
3615
3616 2018-12-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3617
3618         [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
3619         https://bugs.webkit.org/show_bug.cgi?id=192643
3620
3621         Reviewed by Philippe Normand.
3622
3623         This problem happens with Arch Linux users which have libfdk-2.0.0
3624         installed (which is anybody with gst-plugins-bad 1.14.4 installed).
3625
3626         The problem has already been solved upstream at
3627         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
3628
3629         Adding patches while this problem is not in a release yet.
3630
3631         * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
3632         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
3633         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
3634
3635 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3636
3637         [FreeType] Add initial implementation of variation fonts
3638         https://bugs.webkit.org/show_bug.cgi?id=192151
3639
3640         Reviewed by Michael Catanzaro.
3641
3642         Add cairo patch to avoid crashes.
3643
3644         * gtk/jhbuild.modules:
3645         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3646
3647 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
3648
3649         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
3650         https://bugs.webkit.org/show_bug.cgi?id=192618
3651
3652         Reviewed by Alex Christensen.
3653
3654         * DumpRenderTree/win/DRTDataObject.cpp:
3655         * DumpRenderTree/win/DRTDataObject.h:
3656         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3657         * DumpRenderTree/win/DRTDropSource.h:
3658         * DumpRenderTree/win/EditingDelegate.h:
3659         * DumpRenderTree/win/PolicyDelegate.h:
3660         * DumpRenderTree/win/UIDelegate.h:
3661
3662 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
3663
3664         Make TextInputController.legacyAttributedString take DOM nodes and offsets
3665         https://bugs.webkit.org/show_bug.cgi?id=192653
3666
3667         Reviewed by Wenson Hsieh.
3668
3669         Updated TextInputController.legacyAttributedString to take DOM nodes and offsets instead of
3670         a DOM Range object in preparation to add layout tests for HTMLConverter which crosses
3671         shadow boundaries.
3672
3673         * DumpRenderTree/mac/TextInputControllerMac.m:
3674         (+[TextInputController isSelectorExcludedFromWebScript:]): Updated the selector signature.
3675         (+[TextInputController webScriptNameForSelector:]): Ditto.
3676         (-[TextInputController legacyAttributedString:offset:to:offset:]): Made this function take
3677         start node and offset then end node and offset pairs.
3678
3679 2018-12-12  Alex Christensen  <achristensen@webkit.org>
3680
3681         Implement safe browsing in WebKit on WatchOS
3682         https://bugs.webkit.org/show_bug.cgi?id=192641
3683         <rdar://problem/46376188>
3684
3685         Reviewed by Geoff Garen.
3686
3687         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3688         (-[SafeBrowsingNavigationDelegate _webViewDidShowSafeBrowsingWarning:]):
3689         (safeBrowsingView):
3690         Add a test that the new delegate callback is called.
3691
3692 2018-12-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3693
3694         Unreviewed manual rollout of r239100-r239102 and r239116
3695         https://bugs.webkit.org/show_bug.cgi?id=192151
3696         <rdar://problem/46655586>
3697
3698         * gtk/jhbuild.modules:
3699         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Removed.
3700
3701 2018-12-12  Commit Queue  <commit-queue@webkit.org>
3702
3703         Unreviewed, rolling out r239103.
3704         https://bugs.webkit.org/show_bug.cgi?id=192627
3705
3706         It broke the built because it depends on another patch that
3707         didn't land yet (Requested by KaL on #webkit).
3708
3709         Reverted changeset:
3710
3711         "[WPE] Add API to notify about frame displayed view backend
3712         callback"
3713         https://bugs.webkit.org/show_bug.cgi?id=192224
3714         https://trac.webkit.org/changeset/239103
3715
3716 2018-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3717
3718         [WPE] Add API to notify about frame displayed view backend callback
3719         https://bugs.webkit.org/show_bug.cgi?id=192224
3720
3721         Reviewed by Michael Catanzaro.
3722
3723         Add a test case to check the new API.
3724
3725         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3726         (testWebViewFrameDisplayed):
3727         (beforeAll):
3728
3729 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3730
3731         [FreeType] Add initial implementation of variation fonts
3732         https://bugs.webkit.org/show_bug.cgi?id=192151
3733
3734         Reviewed by Michael Catanzaro.
3735
3736         Add cairo patch to avoid crashes.
3737
3738         * gtk/jhbuild.modules:
3739         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3740
3741 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
3742
3743         Implement feature flag for CSS Typed OM
3744         https://bugs.webkit.org/show_bug.cgi?id=192610
3745
3746         Reviewed by Ryosuke Niwa.
3747
3748         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3749
3750 2018-12-11  Chris Dumez  <cdumez@apple.com>
3751
3752         Unreviewed, fix bad check in API test added in r239080.
3753
3754         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3755
3756 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
3757
3758         [Win][Clang] Fix warning -Wmissing-field-initializers
3759         https://bugs.webkit.org/show_bug.cgi?id=192584
3760
3761         Reviewed by Yusuke Suzuki.
3762
3763         Initialize a struct with '{ }' instead of '= {0}'.
3764
3765         * DumpRenderTree/win/DumpRenderTree.cpp:
3766         (runTest):
3767         * DumpRenderTree/win/EventSender.cpp:
3768         (makeMsg):
3769         (replaySavedEvents):
3770         (beginDragWithFilesCallback):
3771         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3772         (createBitmapContextFromWebView):
3773         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3774         (updateMenuItemForHistoryItem):
3775         * MiniBrowser/win/WinMain.cpp:
3776         (wWinMain):
3777         * TestWebKitAPI/win/HostWindow.cpp:
3778         (TestWebKitAPI::HostWindow::clientRect const):
3779         (TestWebKitAPI::HostWindow::registerWindowClass):
3780         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3781         (TestWebKitAPI::PlatformWebView::registerWindowClass):
3782         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3783         (WTR::registerWindowClass):
3784         (WTR::PlatformWebView::windowFrame):
3785         (WTR::PlatformWebView::windowSnapshotImage):
3786
3787 2018-12-11  Chris Dumez  <cdumez@apple.com>
3788
3789         PSON logic gets confused by concurrent decidePolicyForNavigationAction requests
3790         https://bugs.webkit.org/show_bug.cgi?id=192482
3791         <rdar://problem/46470145>
3792
3793         Reviewed by Antti Koivisto.
3794
3795         Add API test coverage.
3796
3797         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3798
3799 2018-12-11  Andy Estes  <aestes@apple.com>
3800
3801         Introduce makeBlockPtr for lambdas
3802         https://bugs.webkit.org/show_bug.cgi?id=192594
3803
3804         Reviewed by Alex Christensen.
3805
3806         Adopted makeBlockPtr and added API tests.
3807
3808         * DumpRenderTree/TestRunner.cpp:
3809         (TestRunner::callUIScriptCallback):
3810         * TestWebKitAPI/Tests/WTF/BlockPtr.mm:
3811         (TestWebKitAPI::TEST):
3812         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3813         (-[DownloadProgressTestRunner init]):
3814         (-[DownloadProgressTestRunner subscribeAndWaitForProgress]):
3815
3816 2018-12-11  Chris Dumez  <cdumez@apple.com>
3817
3818         REGRESSION (r238764-238783): TestWTF.WTF.StringOperators is failing
3819         https://bugs.webkit.org/show_bug.cgi?id=192361
3820         <rdar://problem/46524903>
3821
3822         Reviewed by Alex Christensen.
3823
3824         Compile StringOperators.cpp with -O1 optimization level instead of -Os. This
3825         fixes the failures for me locally.
3826
3827         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3828
3829 2018-12-11  Philippe Normand  <pnormand@igalia.com>
3830
3831         Unreviewed, WPE build fix after r239028
3832
3833         The FLATPAK_USER_DIR env var is not set early enough, leading to:
3834
3835         Traceback (most recent call last):
3836         File "/home/phil/WebKit/Tools/Scripts/webkit-flatpak", line 28, in <module>
3837           sys.exit(WebkitFlatpak.load_from_args().run())
3838         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 761, in run
3839           if not self.clean_args():
3840         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 574, in clean_args
3841           _log.debug("Using flatpak user dir: %s" % os.environ["FLATPAK_USER_DIR"])
3842         File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__
3843           raise KeyError(key)
3844         KeyError: 'FLATPAK_USER_DIR'
3845
3846         * flatpak/flatpakutils.py:
3847         (WebkitFlatpak.clean_args):
3848
3849 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3850
3851         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
3852         https://bugs.webkit.org/show_bug.cgi?id=192573
3853
3854         Reviewed by Simon Fraser.
3855
3856         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3857
3858 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3859
3860         [CMake] Add ENABLE_RESOURCE_LOAD_STATISTICS to WebKitFeatures.cmake
3861         https://bugs.webkit.org/show_bug.cgi?id=192574
3862
3863         Reviewed by Michael Catanzaro.
3864
3865         * Scripts/webkitperl/FeatureList.pm:
3866
3867 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3868
3869         Sync FeatureList.pm
3870         https://bugs.webkit.org/show_bug.cgi?id=192565
3871
3872         Reviewed by Michael Catanzaro.
3873
3874         * Scripts/webkitperl/FeatureList.pm:
3875
3876 2018-12-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3877
3878         [iOS] Unable to upload data that conforms to "public.item" but not "public.content"
3879         https://bugs.webkit.org/show_bug.cgi?id=192555
3880         <rdar://problem/35204990>
3881
3882         Reviewed by Tim Horton.
3883
3884         Add a test to verify that `.p12` files may be uploaded as files via drag and drop. "com.rsa.pkcs-12" is an
3885         example of a data type that conforms to "public.item", but not "public.content"; before this patch, we would
3886         only support uploading "public.content", so files such as these would not be accepted when dropping into file
3887         inputs, or be exposed as files on DataTransfer.
3888
3889         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3890         (TestWebKitAPI::TEST):
3891
3892 2018-12-10  David Kilzer  <ddkilzer@apple.com>
3893
3894         Injected bundle for WebKitTestRunner leaks WKTypeRef objects
3895         <https://webkit.org/b/192481>
3896         <rdar://problem/46539059>
3897
3898         Follow-up to address Darin's feedback.
3899
3900         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3901         (WTR::TestRunner::shouldDumpPixels const):
3902         (WTR::TestRunner::whatToDump const):
3903         (WTR::TestRunner::shouldWaitUntilDone const):
3904         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
3905         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
3906         (WTR::TestRunner::secureEventInputIsEnabled const):
3907         (WTR::TestRunner::isStatisticsPrevalentResource):
3908         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
3909         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
3910         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
3911         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
3912         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
3913         (WTR::TestRunner::isStatisticsGrandfathered):
3914         (WTR::TestRunner::hasDOMCache):
3915         (WTR::TestRunner::keyExistsInKeychain):
3916
3917 2018-12-10  Jonathan Bedard  <jbedard@apple.com>
3918
3919         webkitpy: Ref tests don't respect platform specific expectations
3920         https://bugs.webkit.org/show_bug.cgi?id=192515
3921         <rdar://problem/46564839>
3922
3923         Reviewed by Lucas Forschler.
3924
3925         * Scripts/webkitpy/port/base.py:
3926         (Port._expected_baselines_for_suffixes): Accept multiple suffixes so ref tests can use this function.
3927         (Port.expected_baselines): Move implementation to _expected_baselines_for_suffixes.
3928         (Port.expected_filename): Remove irrelevant FIXME, code clean-up.
3929         (Port.reference_files): Instead of just searching a single directory, use _expected_baselines_for_suffixes to
3930         search all platform expectations as well.
3931         * Scripts/webkitpy/port/base_unittest.py:
3932         (test_ref_tests_platform_directory):
3933
3934 2018-12-10  Chris Dumez  <cdumez@apple.com>
3935
3936         Add SPI to allow the client to set the user-agent at main frame level, from the UIProcess
3937         https://bugs.webkit.org/show_bug.cgi?id=192509
3938         <rdar://problem/46500832>
3939
3940         Reviewed by Alex Christensen.
3941
3942         Add API test coverage.
3943
3944         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3945         (-[DataMappingSchemeHandler addMappingFromURLString:toData:]):
3946         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3947         (-[DataMappingSchemeHandler webView:stopURLSchemeTask:]):
3948         (-[CustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3949         (-[CustomUserAgentDelegate webView:didFinishNavigation:]):
3950
3951 2018-12-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3952
3953         [iOS] Caret is obscured by finger when dragging over an editable element
3954         https://bugs.webkit.org/show_bug.cgi?id=192499
3955         <rdar://problem/46570101>
3956
3957         Reviewed by Tim Horton.
3958
3959         Augment some existing API tests to check that the `precise` flag is either on or off on `UIDropProposal`.
3960
3961         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3962         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3963         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3964         (-[DragAndDropSimulator _resetSimulatedState]):
3965         (-[DragAndDropSimulator lastKnownDropProposal]):
3966
3967         Rename `currentDropProposal` to `lastKnownDropProposal`, and expose it as a readonly property.
3968
3969         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
3970         (-[DragAndDropSimulator _advanceProgress]):
3971         (-[DragAndDropSimulator setShowCustomActionSheetBlock:]):
3972         (-[DragAndDropSimulator showCustomActionSheetBlock]):
3973         (-[DragAndDropSimulator setConvertItemProvidersBlock:]):
3974         (-[DragAndDropSimulator convertItemProvidersBlock]):
3975         (-[DragAndDropSimulator setOverridePerformDropBlock:]):
3976         (-[DragAndDropSimulator overridePerformDropBlock]):
3977         (-[DragAndDropSimulator setOverrideDragUpdateBlock:]):
3978         (-[DragAndDropSimulator overrideDragUpdateBlock]):
3979         (-[DragAndDropSimulator setDropCompletionBlock:]):
3980         (-[DragAndDropSimulator dropCompletionBlock]):
3981
3982         Refactor these properties to return and take normal Objective-C blocks, rather than `BlockPtr`s. However, use
3983         `BlockPtr` instance variables to manage the lifetimes of these blocks.
3984
3985         (-[DragAndDropSimulator _webView:willUpdateDropProposalToProposal:forSession:]):
3986         (-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]): Deleted.
3987
3988         Update this to use the new WebKit delegate hook for overriding the drop proposal.
3989
3990 2018-12-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3991
3992         [WPE][GTK] run-minibrowser improperly creates webkit-flatpak environment
3993         https://bugs.webkit.org/show_bug.cgi?id=190241
3994
3995         Reviewed by Carlos Garcia Campos.
3996
3997         run-minibrowser calls into webkit-flatpak to check if a flatpak environment is available.
3998         Currently this actually creates the directories needed for the flatpak environment. Fix it.
3999
4000         * flatpak/flatpakutils.py:
4001         (WebkitFlatpak.clean_args):
4002         (WebkitFlatpak.run):
4003
4004 2018-12-10  Michael Catanzaro  <mcatanzaro@igalia.com>
4005
4006         [GTK] Don't use the slice allocator
4007         https://bugs.webkit.org/show_bug.cgi?id=192360
4008
4009         Reviewed by Carlos Garcia Campos.
4010
4011         * MiniBrowser/gtk/main.c:
4012         (aboutDataRequestFree):
4013         (aboutDataRequestNew):
4014
4015 2018-12-10  Tim Horton  <timothy_horton@apple.com>
4016
4017         WKWebView should support custom tintColor
4018         https://bugs.webkit.org/show_bug.cgi?id=192518
4019         <rdar://problem/37243261>
4020
4021         Reviewed by Wenson Hsieh.
4022
4023         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
4024         (TestWebKitAPI::TEST):
4025         Add a test that tintColor affects UITextInputTraits' interaction colors.
4026
4027 2018-12-09  Wenson Hsieh  <wenson_hsieh@apple.com>
4028
4029         [iOS] DragAndDropTests.RespectsExternalSourceFidelityRankings is flaky
4030         https://bugs.webkit.org/show_bug.cgi?id=192524
4031
4032         Reviewed by Ryosuke Niwa.
4033
4034         This test started failing on certain builds of iOS where UIKit now attempts to reveal the selection by scrolling
4035         (see <rdar://problem/28300343>). This API test simulates two drops from external sources, both from the point
4036         (300, 400) to (100, 300) in window coordinates. On these aforementioned builds of iOS, what happens is that the
4037         first drop inserts text that overflows the editable region by an enormous amount, which creates an extremely
4038         wide selection rect and increases the width of the document; revealing this selection causes the web view to
4039         scroll horizontally, such that the second attempt to simulate a drag from (300, 400) to (100, 300) fails, since
4040         these window coordinates no longer correspond to the drop destination element in the document.
4041
4042         To fix this test, we simply mark the drop destination as `overflow: hidden` to ensure that we don't try and
4043         scroll horizontally after the first drop.
4044
4045         * TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html:
4046
4047 2018-12-08  Daniel Bates  <dabates@apple.com>
4048
4049         Fix lldb_webkit.py following r238771
4050         (https://bugs.webkit.org/show_bug.cgi?id=190234)
4051
4052         Substitute WTFURLProvider for WebCoreURLProvider in one call site that was inadvertently
4053         missed in r238771.
4054
4055         * lldb/lldb_webkit.py:
4056         (WebCoreDocumentProvider.url):
4057
4058 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4059
4060         [ews-build] check-patch-relevance failure should not mark the overall build as failure
4061         https://bugs.webkit.org/show_bug.cgi?id=192510
4062
4063         Reviewed by Lucas Forschler.
4064
4065         * BuildSlaveSupport/ews-build/steps.py:
4066         (CheckPatchRelevance.start):
4067
4068 2018-12-07  Chris Dumez  <cdumez@apple.com>
4069
4070         ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
4071         https://bugs.webkit.org/show_bug.cgi?id=192362
4072         <rdar://problem/46460360>
4073
4074         Reviewed by Ryosuke Niwa.
4075
4076         Move the call to _setCookieAcceptPolicy *after* we've constructed a WKWebView and thus
4077         *after* we know for sure we have a network process to communicate the policy to.
4078         This should address the failures on iOS.
4079
4080         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4081
4082 2018-12-07  Jiewen Tan  <jiewen_tan@apple.com>
4083
4084         Add keychain access entitlement to WebKitTestRunnerApp
4085         https://bugs.webkit.org/show_bug.cgi?id=192489
4086         <rdar://problem/45057952>
4087
4088         Reviewed by Alexey Proskuryakov.
4089
4090         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
4091
4092 2018-12-07  Saam Barati  <sbarati@apple.com>
4093
4094         WKWebProcessPlugInLoadDelegate should have API for saying which rendering events it wants to listen for
4095         https://bugs.webkit.org/show_bug.cgi?id=192473
4096
4097         Reviewed by Andy Estes.
4098
4099         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4100         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgress.mm: Added.
4101         (-[DidFirstMeaningfulPaintRemoteObject didFirstMeaningfulPaint]):
4102         (TEST):
4103         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressPlugIn.mm: Added.
4104         (-[RenderingProgressPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4105         (-[RenderingProgressPlugIn webProcessPlugInBrowserContextControllerRenderingProgressEvents:]):
4106         (-[RenderingProgressPlugIn webProcessPlugInBrowserContextController:renderingProgressDidChange:]):
4107         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressProtocol.h: Added.
4108
4109 2018-12-07  Jonathan Bedard  <jbedard@apple.com>
4110
4111         REGRESSION: run-webkit-tests may fail when using booted simulators (Follow-up fix)
4112         https://bugs.webkit.org/show_bug.cgi?id=192470
4113         <rdar://problem/46532001>
4114
4115         Unreviewed infrastructure fix.
4116
4117         * Scripts/webkitpy/port/device_port.py:
4118         (DevicePort.setup_test_run): Check that the number of initialized devices matches the
4119         number of child processes.
4120
4121 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4122
4123         [ews-app] Send bug id as a build property
4124         https://bugs.webkit.org/show_bug.cgi?id=192494
4125
4126         Reviewed by Lucas Forschler.
4127
4128         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4129         (BugzillaPatchFetcher.fetch):
4130
4131 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4132
4133         [ews-build] Builds should have a link to patch and bug
4134         https://bugs.webkit.org/show_bug.cgi?id=192492
4135
4136         Reviewed by Lucas Forschler.
4137
4138         * BuildSlaveSupport/ews-build/steps.py:
4139         (ConfigureBuild.add_patch_id_url): Method to add Patch URL.
4140         (ConfigureBuild.add_bug_id_url): Method to add Bug URL.
4141         (ConfigureBuild.getPatchURL): Method to get Patch URL.
4142         (ConfigureBuild.getBugURL): Method to get Bug URL.
4143
4144 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4145
4146         [ews-app] Configure logfile for ews-app logs
4147         https://bugs.webkit.org/show_bug.cgi?id=192493
4148
4149         Reviewed by Lucas Forschler.
4150
4151         * BuildSlaveSupport/ews-app/ews/__init__.py:
4152
4153 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4154
4155         Style queue exception on some security bugs
4156         https://bugs.webkit.org/show_bug.cgi?id=190793
4157
4158         Reviewed by Lucas Forschler.
4159
4160         * Scripts/webkitpy/tool/steps/applywatchlist.py:
4161         (ApplyWatchList.run):
4162
4163 2018-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
4164
4165         [Attachment Support] Cloned attachment elements lose their unique identifiers
4166         https://bugs.webkit.org/show_bug.cgi?id=192483
4167
4168         Reviewed by Tim Horton.
4169
4170         Introduce a new API test.
4171
4172         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4173         (TestWebKitAPI::TEST):
4174
4175 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
4176
4177         Consecutive DumpRenderTree crashes are happening again on WinCairo BuildBots since r238903
4178         https://bugs.webkit.org/show_bug.cgi?id=192486
4179
4180         Unreviewed infrastructure fix.
4181
4182         WinCairo bots define WEBKIT_TEST_CHILD_PROCESSES to run less processes due to RAM restrictions.
4183
4184         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4185         (_set_up_derived_options):
4186
4187 2018-12-06  David Kilzer  <ddkilzer@apple.com>
4188
4189         Injected bundle for WebKitTestRunner leaks WKTypeRef objects
4190         <https://webkit.org/b/192481>
4191         <rdar://problem/46539059>
4192
4193         Reviewed by Simon Fraser.
4194
4195         This patch:
4196         - Fixes leaks in various injected bundle methods that return +1
4197           retained WKTypeRef objects via pointer.
4198         - Asserts the returned object is the expected WKTypeRef.
4199         - Replaces 0 with nullptr in many places.
4200
4201         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4202         (WTR::InjectedBundle::didCreatePage):
4203         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4204         (WTR::TestRunner::shouldDumpPixels const):
4205         (WTR::TestRunner::whatToDump const):
4206         (WTR::TestRunner::shouldWaitUntilDone const):
4207         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
4208         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
4209         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
4210         (WTR::TestRunner::secureEventInputIsEnabled const):
4211         (WTR::TestRunner::isStatisticsPrevalentResource):
4212         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
4213         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
4214         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
4215         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
4216         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
4217         (WTR::TestRunner::isStatisticsGrandfathered):
4218         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
4219         (WTR::TestRunner::statisticsUpdateCookieBlocking):
4220         (WTR::TestRunner::statisticsSubmitTelemetry):
4221         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
4222         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
4223         (WTR::TestRunner::statisticsResetToConsistentState):
4224         (WTR::TestRunner::getAllStorageAccessEntries):
4225         (WTR::TestRunner::hasDOMCache):
4226         (WTR::TestRunner::domCacheSize):
4227         (WTR::TestRunner::injectUserScript):
4228         (WTR::TestRunner::keyExistsInKeychain):
4229
4230 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
4231
4232         REGRESSION: run-webkit-tests may fail when using booted simulators
4233         https://bugs.webkit.org/show_bug.cgi?id=192470
4234         <rdar://problem/46532001>
4235
4236         Reviewed by Lucas Forschler.
4237
4238         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4239         (Manager.run): Logging uses the number of child processes to print out information about how efficiently tests
4240         were sharded after the fact. This number is the most meaningful if it is the maximum number of child processes used.
4241         * Scripts/webkitpy/port/base.py:
4242         (Port.max_child_processes): By default, Ports do not support running on any specific kind of device.
4243         * Scripts/webkitpy/port/device_port.py:
4244         (DevicePort.default_child_processes): Rather than using the currently initialized devices as a proxy for how many
4245         child processes are being used, check the device manager every time. Regardless of which devices are attached or
4246         available, iOS cannot boot watchOS devices and vice-versa. dedicated_simulators is not a known argument to
4247         device_count_for_type, use use_booted_simulator instead.
4248         (DevicePort.max_child_processes): Simulators can boot more devices than what is specified by device_count_for_type,
4249         but, if no devices are available, then max_child_processes should return 0 even for simulators.
4250         * Scripts/webkitpy/port/ios_device_unittest.py:
4251         (IOSDeviceTest):
4252         (IOSDeviceTest.test_max_child_processes):
4253         * Scripts/webkitpy/port/ios_simulator_unittest.py:
4254         (IOSSimulatorTest):
4255         (IOSSimulatorTest.test_max_child_processes):
4256         * Scripts/webkitpy/port/port_testcase.py:
4257         (PortTestCase):
4258         (PortTestCase.test_max_child_processes):
4259         * Scripts/webkitpy/port/watch_simulator_unittest.py:
4260         (WatchSimulatorTest):
4261         (WatchSimulatorTest.test_max_child_processes):
4262
4263 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
4264
4265         webkitpy: Ignore case when comparing device types (Follow-up fix)
4266         https://bugs.webkit.org/show_bug.cgi?id=192409
4267         <rdar://problem/46491558>
4268
4269         Unreviewed typo fix.
4270
4271         * Scripts/webkitpy/xcode/device_type_unittest.py:
4272         (DeviceTypeTest.test_comparison_lower_case):
4273         (DeviceTypeTest.test_comparsion_lower_case): Deleted.
4274
4275 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
4276
4277         webkitpy: Create device given lower-case DeviceType
4278         <https://bugs.webkit.org/show_bug.cgi?id=192472>
4279         <rdar://problem/46532650>
4280
4281         Reviewed by Lucas Forschler.
4282
4283         * Scripts/webkitpy/xcode/simulated_device.py:
4284         (SimulatedDeviceManager._get_device_identifier_for_type): Comparing simctl device identifiers with DeviceTypes
4285         should be letter-case agnostic.
4286         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
4287         (test_lower_case_device_type):
4288
4289 2018-12-06  Wenson Hsieh  <wenson_hsieh@apple.com>
4290
4291         [iOS] WKWebView should match UITextView behavior when editing text with an RTL keyboard
4292         https://bugs.webkit.org/show_bug.cgi?id=187554
4293         <rdar://problem/42075638>
4294
4295         Reviewed by Tim Horton.