Unreviewed, rolling out r147773 and r147774.
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r147773 and r147774.
4         http://trac.webkit.org/changeset/147773
5         http://trac.webkit.org/changeset/147774
6         https://bugs.webkit.org/show_bug.cgi?id=114056
7
8         Causing some exceptions on AppEngine I don't understand
9         (Requested by rniwa on #webkit).
10
11         * QueueStatusServer/config/queues.py:
12         * QueueStatusServer/model/queues.py:
13         (Queue.short_name):
14         (Queue.display_name):
15         * QueueStatusServer/model/queues_unittest.py:
16         (QueueTest.test_short_name):
17         (QueueTest.test_display_name):
18         (QueueTest.test_name_with_underscores):
19
20 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
21
22         Fixed run-bindings-tests by removing V8
23         https://bugs.webkit.org/show_bug.cgi?id=114053
24
25         Reviewed by Benjamin Poulain.
26
27         * Scripts/run-bindings-tests:
28         (main):
29
30 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
31
32         Build fix.
33
34         * QueueStatusServer/model/queues.py:
35         (Queue.short_name):
36         (Queue.display_name):
37
38 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
39
40         Remove Chromium EWS bots from the queue status server
41         https://bugs.webkit.org/show_bug.cgi?id=113988
42
43         Reviewed by Benjamin Poulain.
44
45         Removed Chromium EWS bots.
46
47         * QueueStatusServer/config/queues.py:
48         * QueueStatusServer/model/queues.py:
49         (Queue.short_name):
50         (Queue.display_name):
51         * QueueStatusServer/model/queues_unittest.py:
52         (QueueTest.test_short_name):
53         (QueueTest.test_display_name):
54         (QueueTest.test_name_with_underscores):
55
56 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
57
58         [EFL] Enable indexed database
59         https://bugs.webkit.org/show_bug.cgi?id=107248
60
61         Reviewed by Alexis Menard.
62
63         * Scripts/webkitperl/FeatureList.pm:
64
65 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
66
67         Remove vestiges of Chromium bits from watchlists.
68         https://bugs.webkit.org/show_bug.cgi?id=114047
69
70         Reviewed by Ryosuke Niwa.
71
72         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
73
74 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
75
76         Add James Craig to the contributors list.
77
78         * Scripts/webkitpy/common/config/committers.py:
79
80 2013-04-04  Kent Tamura  <tkent@chromium.org>
81
82         Remove ChromiumPublicApi pattern, and cc/message rules for it.
83
84         * Scripts/webkitpy/common/config/watchlist:
85
86 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
87
88         Temporarily disable the Python unittests broken by the commit queue not running layout tests
89         https://bugs.webkit.org/show_bug.cgi?id=113997
90
91         Reviewed by Ryosuke Niwa.
92
93         Disable the tests until Ryosuke gets the time and hardware to have
94         a testing commit-queue.
95
96         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
97         (CommitQueueTaskTest):
98         * Scripts/webkitpy/tool/commands/queues_unittest.py:
99         (CommitQueueTest):
100
101 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
102
103         Remove Chromium builders from build.webkit.org
104         https://bugs.webkit.org/show_bug.cgi?id=113990
105
106         Reviewed by Benjamin Poulain.
107
108         Land the part to disable triggering of Chromium builders first so that we may start
109         deleting more Chromium code that breaks the update step.
110
111         * BuildSlaveSupport/build.webkit.org-config/config.json:
112
113 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
114
115         Remove Chromium's DumpRenderTree
116         https://bugs.webkit.org/show_bug.cgi?id=113989
117
118         Reviewed by Kent Tamura.
119
120         On second thought, let's not go to Camelot. It is a silly place.
121
122         * DumpRenderTree/mac/DumpRenderTree.mm:
123         (resetDefaultsToConsistentValues):
124
125 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
126
127         Nixed the defunct chromium folder from DumpRenderTree
128         https://bugs.webkit.org/show_bug.cgi?id=113993
129
130         Reviewed by Ryosuke Niwa.
131
132         * DumpRenderTree/chromium: Removed.
133         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
134         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
135         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
136         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
137         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
138         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
139         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
140         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
141         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
142         * DumpRenderTree/chromium/MockPlatform.h: Removed.
143         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
144         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
145         * DumpRenderTree/chromium/Task.cpp: Removed.
146         * DumpRenderTree/chromium/Task.h: Removed.
147         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
148         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
149         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
150         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
151         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
152         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
153         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
154         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
155         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
156         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
157         * DumpRenderTree/chromium/TestRunner: Removed.
158         * DumpRenderTree/chromium/TestRunner/public: Removed.
159         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
160         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
161         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
162         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
163         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
164         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
165         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
166         * DumpRenderTree/chromium/TestRunner/src: Removed.
167         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
168         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
169         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
170         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
171         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
172         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
173         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
174         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
175         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
176         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
177         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
178         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
179         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
180         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
181         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
182         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
183         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
184         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
185         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
186         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
187         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
188         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
189         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
190         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
191         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
192         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
193         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
194         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
195         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
196         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
197         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
198         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
199         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
200         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
201         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
202         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
203         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
204         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
205         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
206         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
207         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
208         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
209         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
210         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
211         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
212         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
213         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
214         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
215         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
216         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
217         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
218         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
219         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
220         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
221         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
222         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
223         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
224         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
225         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
226         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
227         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
228         * DumpRenderTree/chromium/TestShell.cpp: Removed.
229         * DumpRenderTree/chromium/TestShell.h: Removed.
230         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
231         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
232         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
233         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
234         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
235         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
236         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
237         * DumpRenderTree/chromium/WebViewHost.h: Removed.
238         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
239         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
240         * DumpRenderTree/chromium/config.h: Removed.
241         * DumpRenderTree/chromium/fonts.conf: Removed.
242
243 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
244
245         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
246
247         Rubber stamped by Benjamin Poulain.
248
249         * RebaselineQueueServer: Removed.
250         * RebaselineQueueServer/app.yaml: Removed.
251         * RebaselineQueueServer/handlers: Removed.
252         * RebaselineQueueServer/handlers/__init__.py: Removed.
253         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
254         * RebaselineQueueServer/handlers/pages.py: Removed.
255         * RebaselineQueueServer/index.yaml: Removed.
256         * RebaselineQueueServer/main.py: Removed.
257         * RebaselineQueueServer/model: Removed.
258         * RebaselineQueueServer/model/__init__.py: Removed.
259         * RebaselineQueueServer/model/queueentry.py: Removed.
260         * RebaselineQueueServer/static: Removed.
261         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
262         * RebaselineQueueServer/static/styles.css: Removed.
263         * RebaselineQueueServer/templates: Removed.
264         * RebaselineQueueServer/templates/builder-picker.html: Removed.
265         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
266         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
267         * RebaselineQueueServer/templates/home.html: Removed.
268
269 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
270
271         Fix setup-commit-queue and temporarily disable testing on commit-queue
272         https://bugs.webkit.org/show_bug.cgi?id=113979
273
274         Reviewed by Benjamin Poulain.
275
276         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
277         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
278
279         * EWSTools/setup-commit-queue.sh:
280         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
281         (CommitQueueTask.run):
282
283 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
284
285         temporarily make flakiness dashboard work again webkit.org bots
286         https://bugs.webkit.org/show_bug.cgi?id=113972
287
288         Reviewed by Ojan Vafai.
289
290         This patch disables the chromium.org layout test bots TestExpectations
291         parsing temporarily until we can work out the right way to split into
292         two instances for webkit.org and chromium.org and figure out which
293         code to delete where :).
294
295         * TestResultServer/static-dashboards/flakiness_dashboard.js:
296
297 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
298
299         Fix webkitpy tests after r147678.
300
301         * Scripts/webkitpy/tool/commands/queues_unittest.py:
302         (CommitQueueTest.test_commit_queue):
303         (test_manual_reject_during_processing):
304
305 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
306
307         The commit queue should use Mac MountainLion port
308         https://bugs.webkit.org/show_bug.cgi?id=113971
309
310         Reviewed by Lucas Forschler.
311
312         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
313         * Scripts/webkitpy/tool/commands/queues.py:
314         (CommitQueue):
315
316 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
317
318         turn off running tests on chromium linux EWS bots
319         https://bugs.webkit.org/show_bug.cgi?id=113959
320
321         Reviewed by Geoffrey Garen.
322
323         Now that the Chromium port is no longer being maintained
324         there's little point in running the tests. Soon we should
325         just shut this bot off altogether.
326
327         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
328         (ChromiumLinuxEWS):
329
330 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
331
332         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
333
334         * Scripts/webkitpy/common/config/watchlist:
335
336 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
337
338         Indentation fix to get webkit-patch working again after r147625
339
340         Unreviewed.
341
342         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
343         (MacEWS):
344         (MacWK2EWS):
345
346 2013-04-04  Lucas Forschler  <lforschler@apple.com>
347
348         Turn tests back on for Mac WK1/WK2 EWS.
349         
350         Unreviewed.
351         
352         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
353         (MacEWS):
354         (MacWK2EWS):
355
356 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
357
358         [GTK][WK2] MiniBrowser custom URI scheme support
359         https://bugs.webkit.org/show_bug.cgi?id=112419
360
361         Reviewed by Carlos Garcia Campos.
362
363         Add support for about URIs in MiniBrowser. An example about page is show
364         with URI "about:minibrowser", the rest of the cases it will show a
365         proper message explaining that the about page didn't exist.
366
367         Internally it uses "minibrowser-about" prefix instead of "about", but
368         from the user point of view it works with "about" prefix.
369
370         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
371         (getInternalURI): Method to convert URIs from "about" prefix to
372         "minibrowser-about".
373         (getExternalURI): Opposite method.
374         (webViewURIChanged): Use "about" prefix to show the URI to users.
375         (webViewEnterFullScreen): Ditto.
376         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
377         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
378         (aboutURISchemeRequestCallback): Callback to manage about calls.
379         (main): Register the URI scheme to manage about URIs.
380
381 2013-04-03  Roger Fong  <roger_fong@apple.com>
382
383         Re-enable WinEWS tests.
384
385         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
386         (WinEWS):
387
388 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
389
390         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
391         https://bugs.webkit.org/show_bug.cgi?id=113883
392
393         Reviewed by Martin Robinson.
394
395         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
396         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
397         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
398
399 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
400
401         [GTK] Include Pango in jhbuild-optional.modules
402         https://bugs.webkit.org/show_bug.cgi?id=113878
403
404         Reviewed by Martin Robinson.
405
406         Since r147547 Pango 1.32.0 is required. Including the module in the
407         JHBuild optional moduleset.
408
409         * gtk/jhbuild-optional.modules: Add Pango module.
410
411 2013-04-03  Zeno Albisser  <zeno@webkit.org>
412
413         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
414         https://bugs.webkit.org/show_bug.cgi?id=113864
415
416         Moving setDefersLoading from TestRunnerQt to TestRunner
417         requires access to the non-Qt TestRunner.
418         As long as we instantiate both TestRunner and TestRunnerQt,
419         we need a separate getter for the non-Qt TestRunner instance.
420
421         Reviewed by Simon Hausmann.
422
423         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
424         (WebPage::resetSettings):
425         * DumpRenderTree/qt/DumpRenderTreeQt.h:
426         (DumpRenderTree::jscTestRunner):
427         * DumpRenderTree/qt/TestRunnerQt.cpp:
428         (TestRunner::setDefersLoading):
429             Moving setDefersLoading from TestRunnerQt
430             to TestRunner.
431         * DumpRenderTree/qt/TestRunnerQt.h:
432         (TestRunnerQt):
433
434 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
435
436         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
437         https://bugs.webkit.org/show_bug.cgi?id=104779
438
439         Reviewed by Carlos Garcia Campos.
440
441         * Scripts/run-gtk-tests:
442         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
443         passing in current trunk.
444
445 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
446
447         Fix HAVE(QTTESTSUPPORT) logic
448
449         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
450         resulting in HAVE(QTTESTSUPPORT) never being true.
451         Move that logic down in sanitizeFeatures.
452
453         Rubber-stamped by Tor Arne Vestbø.
454
455         * qmake/mkspecs/features/features.prf:
456
457 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
458
459         [GTK] Bump required versions of some dependencies
460         https://bugs.webkit.org/show_bug.cgi?id=113282
461
462         Reviewed by Martin Robinson.
463
464         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
465
466 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
467
468         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
469         https://bugs.webkit.org/show_bug.cgi?id=113809
470
471         Reviewed by Philippe Normand.
472
473         Newer Linux kernels have removed some deprecated macros from v4l2
474         headers, causing gst-plugins-good's build to break. We don't need it
475         right now, so just disable it.
476
477         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
478
479 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
480
481         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
482         https://bugs.webkit.org/show_bug.cgi?id=113535
483
484         Reviewed by Simon Hausmann.
485
486         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
487
488         * qmake/mkspecs/features/features.prf:
489
490 2013-04-03  Zeno Albisser  <zeno@webkit.org>
491
492         [Qt] Move logic of simple forwarding functions to TestRunner.
493         https://bugs.webkit.org/show_bug.cgi?id=113863
494
495         Reviewed by Simon Hausmann.
496
497         * DumpRenderTree/qt/TestRunnerQt.cpp:
498         (TestRunner::setTextDirection):
499         (TestRunner::goBack):
500         (TestRunner::evaluateScriptInIsolatedWorld):
501         (TestRunner::addUserStyleSheet):
502         * DumpRenderTree/qt/TestRunnerQt.h:
503         (TestRunnerQt):
504
505 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
506
507         [Qt] Disable media support using QuickTime if deployment target != SDK
508
509         We link to a single libWebKitSystemInterface static lib, so unless the
510         deployment target matches the SDK let's not pretend like we'll be able
511         to run on anything lower than the SDK version.
512
513         Reviewed by Simon Hausmann.
514
515         * qmake/mkspecs/features/features.prf:
516
517 2013-04-02  James Craig  <james@cookiecrook.com>
518
519         AXRoleDescripton for DL is "list"; should be "description list"
520         https://bugs.webkit.org/show_bug.cgi?id=111665
521
522         Reviewed by Chris Fleizach.
523
524         Defining the role and description strings.
525
526         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
527
528 2013-04-02  Roger Fong  <roger_fong@apple.com>
529
530         Unreviewed. Disable running tests on Win EWS queue.
531
532         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
533         (WinEWS):
534
535 2013-04-02  Lucas Forschler  <lforschler@apple.com>
536
537         Disable running tests on the MAC WK2 EWS queue.
538         
539         Unreviewed.
540         
541         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
542         (MacWK2EWS):
543
544 2013-04-02  Julie Parent  <jparent@chromium.org>
545
546         Dashboard refactor: Move dashboard specific history related features to History.
547         https://bugs.webkit.org/show_bug.cgi?id=113717
548
549         Reviewed by Ojan Vafai.
550         
551         Each dashboard now creates its own History object, with a custom
552         configuration. This changes from just overriding global functions
553         to passing in callbacks for generatePage, handleValidHashParameter,
554         and handleQueryParameterChange. Same with passing in defaultStateValues
555         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
556         variables.
557         
558         All functions related to these features are now (mostly) private
559         function on History. 
560         
561         Loader no longer needs a loadingComplete callback, since it can just
562         initialize the history object itself.
563
564         * TestResultServer/static-dashboards/aggregate_results.js:
565         (handleValidHashParameter):
566         * TestResultServer/static-dashboards/dashboard_base.js:
567         * TestResultServer/static-dashboards/flakiness_dashboard.js:
568         (generatePage):
569         (.switch.return):
570         (handleQueryParameterChange):
571         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
572         (resetGlobals):
573         * TestResultServer/static-dashboards/history.js:
574         (.):
575         * TestResultServer/static-dashboards/loader.js:
576         (.):
577         * TestResultServer/static-dashboards/loader_unittests.js:
578         * TestResultServer/static-dashboards/timeline_explorer.js:
579         (generatePage):
580         (initCurrentBuilderTestResults):
581         * TestResultServer/static-dashboards/treemap.js:
582         (generatePage):
583         (.switch.return):
584         (handleQueryParameterChange):
585
586 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
587
588         Unreviewed, rolling out r147401.
589         http://trac.webkit.org/changeset/147401
590         https://bugs.webkit.org/show_bug.cgi?id=113767
591
592         The patch makes it extremely hard to set up the dependencies
593         properly on the GTK builders (Requested by zdobersek on
594         #webkit).
595
596         * gtk/jhbuild.modules:
597
598 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
599
600         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
601         https://bugs.webkit.org/show_bug.cgi?id=113382
602
603         Reviewed by Gyuyoung Kim.
604
605         Do not show the empty tooltip box if the text is null.
606
607         * MiniBrowser/efl/main.c:
608         (popup_menu_populate):
609
610 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
611
612         [GTK] Bump required versions of some dependencies
613         https://bugs.webkit.org/show_bug.cgi?id=113282
614
615         Reviewed by Martin Robinson.
616
617         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
618
619 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
620
621         Unreviewed, rolling out r147319.
622         http://trac.webkit.org/changeset/147319
623         https://bugs.webkit.org/show_bug.cgi?id=113707
624
625         The unit test is still failing on the buildbot (Requested by
626         zdobersek on #webkit).
627
628         * Scripts/run-gtk-tests:
629         (TestRunner):
630
631 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
632
633         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
634         https://bugs.webkit.org/show_bug.cgi?id=104779
635
636         Reviewed by Carlos Garcia Campos.
637
638         * Scripts/run-gtk-tests:
639         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
640         passing in current trunk.
641
642 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
643
644         Unreviewed, rolling out r147289.
645         http://trac.webkit.org/changeset/147289
646         https://bugs.webkit.org/show_bug.cgi?id=113678
647
648         broke Win7 (dbg) build (Requested by shinyak|gardener on
649         #webkit).
650
651         * DumpRenderTree/DumpRenderTree.gypi:
652         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
653         (WebTestRunner):
654         (WebUserMediaClientMock):
655         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
656         (WebTestRunner::WebUserMediaClientMock::taskList):
657         * Scripts/webkitpy/style/checkers/cpp.py:
658         (check_function_definition):
659
660 2013-03-31  Adam Barth  <abarth@webkit.org>
661
662         configure-svn-config.sh fails
663         https://codereview.chromium.org/13392007/
664
665         Reviewed by Eric Seidel.
666
667         This script was trying to use "svn checkout" to dowload a file from
668         svn.webkit.org, but "svn checkout" only works with directories.
669         Instead, we should use "svn export".
670
671         * EWSTools/configure-svn-config.sh:
672
673 2013-03-31  Wei Jia  <wjia@chromium.org>
674
675         Allow WebUserMediaClientMock to be used by client
676         https://bugs.webkit.org/show_bug.cgi?id=113633
677
678         Reviewed by Adam Barth.
679
680         Export WebUserMediaClientMock.
681         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
682
683         * DumpRenderTree/DumpRenderTree.gypi:
684         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
685         (WebUserMediaClientMock):
686         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
687         * Scripts/webkitpy/style/checkers/cpp.py:
688         (check_function_definition):
689
690 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
691
692         Expose FeatureObserver data to WebKit clients
693         https://bugs.webkit.org/show_bug.cgi?id=113613
694
695         Reviewed by Sam Weinig.
696
697         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
698         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
699
700 2013-03-29  Greg Hughes  <ghughes@apple.com>
701
702         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
703         https://bugs.webkit.org/show_bug.cgi?id=112276
704
705         Reviewed by Chris Fleizach.
706
707         Added support to test accessibility search predicates with multiple keys.  
708
709         * DumpRenderTree/AccessibilityUIElement.cpp:
710         (uiElementForSearchPredicateCallback):
711         * DumpRenderTree/AccessibilityUIElement.h:
712         (AccessibilityUIElement):
713         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
714         (AccessibilityUIElement::uiElementForSearchPredicate):
715         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
716         (AccessibilityUIElement::uiElementForSearchPredicate):
717         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
718         (AccessibilityUIElement::uiElementForSearchPredicate):
719         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
720         (AccessibilityUIElement::uiElementForSearchPredicate):
721         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
722         (AccessibilityUIElement::uiElementForSearchPredicate):
723         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
724         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
725         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
726         (AccessibilityUIElement):
727         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
728         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
729         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
730         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
731         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
732
733 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
734
735         Fix a typo in r147147 to fix Mac EWS.
736
737         * Scripts/webkitpy/tool/commands/queues.py:
738         (PatchProcessingQueue._new_port_name_from_old):
739
740 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
741
742         [EFL] Build break with latest EFL libraries after r146265
743         https://bugs.webkit.org/show_bug.cgi?id=113558
744
745         Unreviewed build fix.
746
747         * TestWebKitAPI/PlatformWebView.h:
748         * WebKitTestRunner/PlatformWebView.h:
749
750 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
751
752         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
753
754         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
755         in libgcrypt build.
756
757 2013-03-28  Lucas Forschler  <lforschler@apple.com>
758
759         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
760
761         Unreviewed.
762
763         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
764         (MacEWS):
765
766 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
767
768         Use the right OS name on Mac EWS instead of mac-future.
769
770         Rubber-stamped by Dirk Pranke.
771
772         * Scripts/webkitpy/tool/commands/queues.py:
773         (PatchProcessingQueue._new_port_name_from_old):
774         (PatchProcessingQueue.begin_work_queue):
775         (PatchProcessingQueue._upload_results_archive_for_patch):
776
777 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
778
779         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
780         https://bugs.webkit.org/show_bug.cgi?id=112546
781
782         Reviewed by Martin Robinson.
783
784         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
785         moved back to Source/WebCore/platform. Fix an indentation issue as well.
786
787 2013-03-28  Ming Xie  <mxie@blackberry.com>
788
789         [BlackBerry] Committer Email Updates
790         https://bugs.webkit.org/show_bug.cgi?id=113435
791
792         Reviewed by Rob Buis.
793
794         Add the @blackberry.com email address for all our BlackBerry
795         WebKit committers. This is the first step for our email address
796         migration.
797
798         * Scripts/webkitpy/common/config/committers.py:
799
800 2013-03-28  Philippe Normand  <pnormand@igalia.com>
801
802         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
803         https://bugs.webkit.org/show_bug.cgi?id=113508
804
805         Reviewed by Martin Robinson.
806
807         Prevent the GStreamer plugin scanner to load system-wide
808         plugins. Only the ones built in JHBuild should be loaded and used
809         at runtime.
810
811         * efl/jhbuildrc:
812         * gtk/jhbuildrc:
813
814 2013-03-27  Philippe Normand  <pnormand@igalia.com>
815
816         [GTK] run-launcher --gtk -2 fails on a WK2-only build
817         https://bugs.webkit.org/show_bug.cgi?id=113386
818
819         Reviewed by Carlos Garcia Campos.
820
821         * Scripts/webkitdirs.pm:
822         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
823         version to 3.0. Reflect this change so the builtDylibPathForName
824         function doesn't fail to report the library as found.
825
826 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
827
828         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
829         https://bugs.webkit.org/show_bug.cgi?id=113484
830
831         Unreviewed build fix.
832
833         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
834
835         * TestWebKitAPI/CMakeLists.txt:
836         * WebKitTestRunner/CMakeLists.txt:
837
838 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
839
840         Revision for the internal jhbuild is too old
841         https://bugs.webkit.org/show_bug.cgi?id=113324
842
843         Reviewed by Martin Robinson.
844
845         Update the minimum required version to a point where jhbuild won't
846         fail installing packages when trying to remove a symlink to a directory.
847
848         * jhbuild/jhbuild-wrapper: Updated revision.
849
850 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
851
852         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
853         https://bugs.webkit.org/show_bug.cgi?id=113203
854
855         Reviewed by Philippe Normand.
856
857         We build our libsoup without GNOME support. gst-plugins-good does separate
858         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
859         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
860         build failures as the headers of those diverge. We do not use souphttpsrc, so
861         disable it when building gst-plugins-good.
862
863         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
864
865 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
866
867         Build fix after r146852. Please another reference to the Lion leaks builder.
868
869         * BuildSlaveSupport/build.webkit.org-config/config.json:
870
871 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
872
873         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
874         https://bugs.webkit.org/show_bug.cgi?id=113421
875
876         Reviewed by Dirk Pranke.
877
878         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
879         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
880         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
881         in the GTK-specific TestExpectations files.
882
883         To avoid this only enable the warnings only when not using WKTR.
884
885         * Scripts/webkitpy/layout_tests/port/gtk.py:
886         (GtkPort.warn_if_bug_missing_in_test_expectations):
887
888 2013-03-27  Antti Koivisto  <antti@apple.com>
889
890         Fix Zalan's email.
891
892         * Scripts/webkitpy/common/config/committers.py:
893
894 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
895
896         master.cfg cleanup
897         https://bugs.webkit.org/show_bug.cgi?id=113195
898
899         Reviewed by Ryosuke Niwa.
900
901         * BuildSlaveSupport/build.webkit.org-config/config.json:
902         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
903
904 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
905
906         master.cfg fine-tuning for Qt Mountain Lion Release bot
907         https://bugs.webkit.org/show_bug.cgi?id=113191
908
909         Reviewed by Ryosuke Niwa.
910
911         * BuildSlaveSupport/build.webkit.org-config/config.json:
912           - Rename the slave due to its location change.
913           - Update the platform of the slave.
914         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
915         (RunQtAPITests): Enable running WK2 API tests on Qt.
916         (RunQtAPITests.start):
917         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
918         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
919
920 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
921
922         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
923         https://bugs.webkit.org/show_bug.cgi?id=113403
924
925         Reviewed by Kenneth Rohde Christiansen.
926
927         As of Evas 1.7.5, when Wayland is detected on the system, support for
928         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
929         The code, however, seems to depend on a few other flags which must be
930         explicitly enabled.
931
932         If those additional GL-related options are passed, we end up
933         having issues on the WebKit side, so disable Wayland support for
934         now.
935
936         * efl/jhbuild.modules:
937
938 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
939
940         Unreviewed, rolling out r146864.
941         http://trac.webkit.org/changeset/146864
942         https://bugs.webkit.org/show_bug.cgi?id=113391
943
944         causes crashes on Wk2 EFL release bot (Requested by drott on
945         #webkit).
946
947         * Scripts/webkitperl/FeatureList.pm:
948
949 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
950
951         [jhbuild] Correctly specify an alternate number of make jobs.
952         https://bugs.webkit.org/show_bug.cgi?id=113396
953
954         Reviewed by Philippe Normand.
955
956         So far, we were using the `MAKEFLAGS' environment variable to pass the
957         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
958         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
959
960         We now behave more closely to the rest of the WebKit tools by first
961         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
962         not set, just letting jhbuild itself figure out how many jobs to use.
963
964         * efl/jhbuildrc:
965         * gtk/jhbuildrc:
966
967 2013-03-27  Zeno Albisser  <zeno@webkit.org>
968
969         [Qt] Remove Qt specific WorkQueueItem definitions.
970         https://bugs.webkit.org/show_bug.cgi?id=112891
971
972         This patch is preparation work for removing
973         WorkQueue related code from TestRunnerQt and
974         replacing it with generic TestRunner code.
975
976         Reviewed by Benjamin Poulain.
977
978         * DumpRenderTree/qt/TestRunnerQt.cpp:
979         (TestRunnerQt::queueBackNavigation):
980         (TestRunnerQt::queueForwardNavigation):
981         (TestRunnerQt::queueLoadHTMLString):
982         (TestRunnerQt::queueReload):
983         (TestRunnerQt::queueLoadingScript):
984         (TestRunnerQt::queueNonLoadingScript):
985         (TestRunner::queueLoad):
986         * DumpRenderTree/qt/TestRunnerQt.h:
987         (TestRunnerQt):
988         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
989         (LoadItem::invoke):
990         (LoadHTMLStringItem::invoke):
991         (LoadAlternateHTMLStringItem::invoke):
992         (ReloadItem::invoke):
993         (ScriptItem::invoke):
994         (BackForwardItem::invoke):
995         * DumpRenderTree/qt/WorkQueueItemQt.h:
996         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
997         (LoadAlternateHTMLStringItem):
998
999 2013-03-26  Julie Parent  <jparent@chromium.org>
1000
1001         Flakiness dashboard: simplify logic around which tests to show.
1002         https://bugs.webkit.org/show_bug.cgi?id=113250
1003
1004         Reviewed by Ojan Vafai.
1005         
1006         The different filters for showing results are only used for layout
1007         tests, otherwise, we show everything.
1008         
1009         Change the defaults to false (what layout tests used), and only
1010         look at the values when viewing layout tests.
1011
1012         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1013         (htmlForTestsWithExpectationsButNoFailures):
1014         (shouldHideTest):
1015
1016 2013-03-26  Isaac Levy  <ilevy@google.com>
1017
1018         Update bots on test-results.appspot
1019         https://bugs.webkit.org/show_bug.cgi?id=113333
1020
1021         Reviewed by Ojan Vafai.
1022
1023         * TestResultServer/static-dashboards/builders.jsonp:
1024
1025 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1026
1027         Unreviewed GTK gardening.
1028
1029         * Scripts/run-gtk-tests:
1030         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1031
1032 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1033
1034         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1035         https://bugs.webkit.org/show_bug.cgi?id=113287
1036
1037         Reviewed by Jocelyn Turcotte.
1038
1039         * Scripts/run-qtwebkit-tests:
1040         (Options.__init__):
1041
1042 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1043
1044         [EFL] Enable IndexedDB by default
1045         https://bugs.webkit.org/show_bug.cgi?id=107248
1046
1047         Reviewed by Laszlo Gombos.
1048
1049         * Scripts/webkitperl/FeatureList.pm:
1050         Enable IndexedDB by default on EFL.
1051
1052 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1053
1054         Sheriffbot should explain rollout failures in a human readable form.
1055         https://bugs.webkit.org/show_bug.cgi?id=107092
1056
1057         Reviewed by Ryosuke Niwa.
1058
1059         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1060
1061         * Scripts/webkitpy/tool/bot/irc_command.py:
1062         (Rollout._check_diff_failure):
1063         (Rollout.execute):
1064         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1065         (IRCCommandTest.test_rollout):
1066
1067 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1068
1069         Unreviewed GTK gardening.
1070
1071         * Scripts/run-gtk-tests:
1072         (TestRunner): Skipping a failing unit test after r146518.
1073
1074 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1075
1076         Remove Lion leaks builder
1077         https://bugs.webkit.org/show_bug.cgi?id=113252
1078
1079         Reviewed by Andreas Kling.
1080
1081         Removed.
1082
1083         * BuildSlaveSupport/build.webkit.org-config/config.json:
1084
1085 2013-03-25  Kent Tamura  <tkent@chromium.org>
1086
1087         Rename ENABLE_INPUT_TYPE_DATETIME
1088         https://bugs.webkit.org/show_bug.cgi?id=113254
1089
1090         Reviewed by Kentaro Hara.
1091
1092         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1093         Actually I'd like to remove the code, but we shouldn't remove it yet
1094         because we shipped products with it on some platforms.
1095
1096         * Scripts/webkitperl/FeatureList.pm:
1097         * qmake/mkspecs/features/features.pri:
1098
1099 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1100
1101         Remove one more line that was intended to be removed in r146657.
1102
1103         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1104         (summarize_results):
1105
1106 2013-03-25  Roger Fong  <roger_fong@apple.com>
1107
1108         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1109         Re-enable WinEWS tests.
1110
1111         * Scripts/webkitpy/common/config/ports.py:
1112         (WinPort.run_bindings_tests_command):
1113         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1114         (WinEWS):
1115
1116 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1117
1118         Unreviewed, rolling out r146793.
1119         http://trac.webkit.org/changeset/146793
1120         https://bugs.webkit.org/show_bug.cgi?id=113248
1121
1122         Fix did not work (Requested by rfong on #webkit).
1123
1124         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1125         (WinEWS):
1126
1127 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1128
1129         REGRESSION(r146657): Test failures reported incorrectly
1130         https://bugs.webkit.org/show_bug.cgi?id=113223
1131
1132         Reviewed by Dirk Pranke.
1133
1134         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1135
1136         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1137         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1138
1139         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1140         (Manager.run):
1141
1142         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1143         (RunDetails.__init__):
1144         (summarize_results): Remove the line I intended to remove in r146657.
1145
1146         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1147         (logging_run): Return details instead of the exit code.
1148         (run_and_capture): Ditto.
1149
1150         (RunTest.test_full_results_html):
1151         (RunTest.test_hung_thread):
1152         (RunTest.test_no_tests_found):
1153         (RunTest.test_no_tests_found_2):
1154         (RunTest.test_repeat_each_iterations_num_tests):
1155         (RunTest.test_run_singly_actually_runs_tests):
1156         (RunTest.test_test_list):
1157         (RunTest.test_missing_and_unexpected_results):
1158         (RunTest.test_pixel_test_directories):
1159         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1160         (RunTest.test_crash_with_stderr):
1161         (RunTest.test_no_image_failure_with_image_diff):
1162         (RunTest.test_crash_log):
1163         (RunTest.test_exit_after_n_failures_upload):
1164         (RunTest.test_results_directory_absolute):
1165         (RunTest.test_results_directory_relative):
1166         (RunTest.test_retrying_and_flaky_tests):
1167         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1168         (RunTest.test_retrying_uses_retries_directory):
1169         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1170         (RunTest.test_output_diffs):
1171         (EndToEndTest.test_reftest_with_two_notrefs):
1172         (RebaselineTest.test_reset_results):
1173         (RebaselineTest.test_missing_results):
1174         (RebaselineTest.test_new_baseline):
1175
1176         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1177         (BuildBotPrinter.print_results):
1178         (BuildBotPrinter.print_unexpected_results):
1179         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1180         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1181
1182 2013-03-25  Julie Parent  <jparent@chromium.org>
1183
1184         Dashboard refactor: Move cross dashboard history related code into history.js.
1185         https://bugs.webkit.org/show_bug.cgi?id=113104
1186
1187         Reviewed by Ojan Vafai.
1188
1189         All functions relating to cross dashboard behavior move from being
1190         globals to methods on the history.History object. Names stay the same,
1191         except many are made private, ones that should have been constants now
1192         are, and the long standing TODO to change "currentState" to 
1193         dashboardSpecificState is done.
1194         
1195         We now create a global history object in dashboard_base, as an 
1196         intermediate measure.  Once the dashboard specific code is
1197         added to history, each DB will need to create its own, and this
1198         global will be eliminated.
1199         
1200         * TestResultServer/static-dashboards/aggregate_results.js:
1201         (handleValidHashParameter):
1202         (htmlForBuilder):
1203         (rawValuesHTML):
1204         * TestResultServer/static-dashboards/dashboard_base.js:
1205         (parseDashboardSpecificParameters):
1206         (defaultValue):
1207         (currentBuilderGroupCategory):
1208         (currentBuilderGroupName):
1209         (handleLocationChange):
1210         (expectationsMap):
1211         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1212         (generatePage):
1213         (.switch.return):
1214         (platformAndBuildType):
1215         (individualTests):
1216         (substringList):
1217         (processMissingAndExtraExpectations):
1218         (pathToFailureLog):
1219         (showPopupForBuild):
1220         (htmlForTestsWithExpectationsButNoFailures):
1221         (shouldHideTest):
1222         (isCrossBuilderView):
1223         (tableHeaders):
1224         (htmlForSingleTestRow):
1225         (htmlForTableColumnHeader):
1226         (generatePageForExpectationsUpdate):
1227         (handleUpdate):
1228         (nextUpdate):
1229         (setUpdateIndex):
1230         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1231         (.appendExpectationsItem):
1232         (loadExpectations):
1233         (.dummyNode.onload):
1234         (loadExpectationsLayoutTests):
1235         (appendExpectations):
1236         (htmlForNavBar):
1237         (checkBoxToToggleState):
1238         (linkHTMLToToggleState):
1239         (generatePageForBuilder):
1240         (isInvalidKeyForCrossBuilderView):
1241         (handleQueryParameterChange):
1242         (showLegend):
1243         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1244         (resetGlobals):
1245         (test):
1246         * TestResultServer/static-dashboards/history.js:
1247         (.):
1248         * TestResultServer/static-dashboards/history_unittests.js:
1249         * TestResultServer/static-dashboards/loader.js:
1250         (.):
1251         * TestResultServer/static-dashboards/loader_unittests.js:
1252         * TestResultServer/static-dashboards/timeline_explorer.js:
1253         (generatePage):
1254         (initCurrentBuilderTestResults):
1255         (selectBuild):
1256         (showResultsDelta):
1257         * TestResultServer/static-dashboards/treemap.js:
1258         (generatePage):
1259         (.switch.return):
1260         (handleFocus):
1261         * TestResultServer/static-dashboards/ui.js:
1262
1263 2013-03-25  Roger Fong  <roger_fong@apple.com>
1264
1265         Unreviewed. Enable WinEWS tests again.
1266
1267         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1268         (WinEWS):
1269
1270 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1271
1272         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1273         https://bugs.webkit.org/show_bug.cgi?id=112166
1274
1275         HarfBuzz 0.9.14 merged my patch for icu detection without
1276         pkg-config files, as needed by for example Ubuntu 12.04.
1277         This obsoletes our local workaround. Removed it for GTK and EFL.
1278
1279         Reviewed by Martin Robinson.
1280
1281         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1282         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1283         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1284         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1285
1286 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1287
1288         Unreviewed.  Move self from contributor to committer list.
1289
1290         * Scripts/webkitpy/common/config/committers.py:
1291
1292 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1293
1294         EWS should use a human readable port name when uploading layout test archives
1295         https://bugs.webkit.org/show_bug.cgi?id=113099
1296
1297         Reviewed by Dirk Pranke.
1298
1299         Use new port's object's name() method to report human readable port names.
1300         This will also help us resolving the bug to apply layout test results posted by EWS.
1301
1302         * Scripts/webkitpy/tool/bot/botinfo.py:
1303         (BotInfo.__init__): Take port's name.
1304         (BotInfo.summary_text):
1305
1306         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1307         (BotInfoTest.test_summary_text):
1308
1309         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1310         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1311
1312         * Scripts/webkitpy/tool/commands/queues.py:
1313         (PatchProcessingQueue.__init__): Initialize self._port.
1314         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1315         and use that for the attachment filename and the comment posted.
1316
1317         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1318         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1319         "mac-snowleopard" as expected for TestPort.
1320
1321 2013-03-22  Roger Fong  <roger_fong@apple.com>
1322
1323         Unreviewed. Turn off EWS test on Win again.
1324         The battle continues.
1325
1326         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1327         (WinEWS):
1328
1329 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1330
1331         NRWT: Enable pixel tests when retrying tests
1332         https://bugs.webkit.org/show_bug.cgi?id=112898
1333
1334         Reviewed by Dirk Pranke.
1335
1336         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1337         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1338         if we've forced pixel tests in the retry.
1339         (Manager._run_tests):
1340         (Manager._clean_up_run): Fixed the capitalizations.
1341         (Manager._force_pixel_tests_if_needed): Added.
1342
1343         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1344         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1345         'image_diff_percent' if it doesn't already exist.
1346
1347         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1348         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1349         treat this as a regular regression instead of a flakiness.
1350
1351         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1352         run had image diffs.
1353
1354         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1355         (summarized_results):
1356
1357         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1358         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1359         Also removed some dead code.
1360
1361         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1362         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1363         is set and pixel_tests_enabled is set to false.
1364         (EndToEndTest.test_reftest_with_two_notrefs):
1365
1366 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1367
1368         Make it possible to run layout tests on Retina MBP
1369         https://bugs.webkit.org/show_bug.cgi?id=93673
1370
1371         Reviewed by Ryosuke Niwa.
1372
1373         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1374         windows on 2x machines still run at 1x.
1375
1376         * DumpRenderTree/mac/DumpRenderTree.mm:
1377         (createWebViewAndOffscreenWindow):
1378         Reset the window resolution to 1x on creation.
1379         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
1380         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1381         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
1382         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1383         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
1384         (WTR::PlatformWebView::PlatformWebView):
1385         Add NSWindow details, reset the window resolution to 1x on creation.
1386
1387 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1388
1389         Leak bots shouldn't build
1390         https://bugs.webkit.org/show_bug.cgi?id=112774
1391
1392         Reviewed by Simon Fraser.
1393
1394         Since leak bots use regular debug builds, there is no need to build on these bots.
1395         Simply downloading builds will dramatically improve the cycle time of these bots.
1396
1397         * BuildSlaveSupport/build.webkit.org-config/config.json:
1398         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1399         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
1400         TestFactory instead of BuildAndTestFactory.
1401
1402 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1403
1404         [Qt] Fix the TestWebKitAPI build
1405         https://bugs.webkit.org/show_bug.cgi?id=113044
1406
1407         Reviewed by Tor Arne Vestbø.
1408
1409         The generate-forwarding-headers script would only be run
1410         after the targets in InjectedBundle.pri since the second
1411         addStrictSubdirOrderBetween call in
1412         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
1413         the derived_sources -> injected_bundle order in SUBDIRS.
1414
1415         Fix it by only moving the dependent target at the end of
1416         SUBDIRS, don't touch its dependency.
1417
1418         * qmake/mkspecs/features/functions.prf:
1419
1420 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1421
1422         [EFL][WK2] View is not focused when fullscreen mode toggled
1423         https://bugs.webkit.org/show_bug.cgi?id=113009
1424
1425         Reviewed by Laszlo Gombos.
1426
1427         Set focus on view when fullscreen mode enabled/disabled
1428         by FullScreen API.
1429
1430         * MiniBrowser/efl/main.c:
1431         (on_fullscreen_accept):
1432         (on_fullscreen_deny):
1433
1434 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1435
1436         nrwt is no longer saving retry results in the retries/ subdirectory
1437         https://bugs.webkit.org/show_bug.cgi?id=112995
1438
1439         Reviewed by Ojan Vafai.
1440
1441         I think this has been broken a long time, unfortunately. This
1442         patch should fix that.
1443
1444         In order to do so, I had to pass the directory to use from
1445         the Worker object through the SingleTestWriter to the
1446         TestResultWriter. While I was plumbing that through, I rationalized
1447         the order of the parameter arguments a bit ...
1448
1449         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1450         (Worker._run_single_test):
1451         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1452         (run_single_test):
1453         (SingleTestRunner.__init__):
1454         (SingleTestRunner._run_compare_test):
1455         (SingleTestRunner._run_rebaseline):
1456         (SingleTestRunner._run_reftest):
1457         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1458         (write_test_result):
1459         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1460         (TestResultWriterTest.test_reftest_diff_image):
1461         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1462         (RunTest.test_retrying_uses_retries_directory):
1463
1464 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
1465
1466         JSC profiler should have an at-a-glance report of the success of DFG optimization
1467         https://bugs.webkit.org/show_bug.cgi?id=112988
1468
1469         Reviewed by Geoffrey Garen.
1470
1471         * Scripts/display-profiler-output:
1472
1473 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1474
1475         [chromium] Linux ASAN WebKit canary is running out of memory
1476         https://bugs.webkit.org/show_bug.cgi?id=112978
1477
1478         Reviewed by Tony Chang.
1479
1480         Running the AddressSanitizer on a crash takes a lot of
1481         memory, so we should serialize access to it to avoid running
1482         out of memory on a machine.
1483
1484         * Scripts/webkitpy/layout_tests/port/chromium.py:
1485         (ChromiumPort._get_crash_log):
1486         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1487         (HttpLock.__init__):
1488         (HttpLock.wait_for_httpd_lock):
1489
1490 2013-03-21  Min Qin  <qinmin@chromium.org>
1491
1492         Cleanup android media layout test code
1493         https://bugs.webkit.org/show_bug.cgi?id=112944
1494
1495         Reviewed by Adam Barth.
1496
1497         Chromium change: https://codereview.chromium.org/12892010/
1498         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
1499         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
1500         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
1501         Instead, we should switch to use content shell for layout tests.
1502
1503         * DumpRenderTree/chromium/TestShell.cpp:
1504         (TestShell::resetTestController):
1505
1506 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1507
1508         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
1509         https://bugs.webkit.org/show_bug.cgi?id=112953
1510
1511         Reviewed by Tony Chang.
1512
1513         When I created the DumpRenderTree_resources target in r144863 I
1514         forgot to declare the needed dependencies on the other resource
1515         targets. Due to a quirk of ordering, this appears to have been fine
1516         w/ ninja but not w/ Xcode (which is still being used on the chromium
1517         mac valgrind bots). Declaring the dependencies fixes the build
1518         failures.
1519
1520         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1521
1522 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
1523
1524         [WinCairo] Correct assert in Empty BitmapImage Test.
1525         https://bugs.webkit.org/show_bug.cgi?id=112934
1526
1527         Reviewed by Tim Horton.
1528
1529         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1530         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
1531         to avoid ref counting assertion when leaving test scope.
1532
1533 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
1534
1535         [GTK] generate-feature-defines-files is incompatible with Python3
1536         https://bugs.webkit.org/show_bug.cgi?id=112956
1537
1538         Reviewed by Martin Robinson.
1539
1540         Make the generate-feature-defines-files compatible with Python3 by calling the items()
1541         method on the dictionary objects when iterating through said dictionaries.
1542
1543         * gtk/generate-feature-defines-files:
1544         (write_feature_defines_header):
1545         (write_flattened_feature_defines_file):
1546
1547 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1548
1549         kill-old-processes spits out error messages on Mac
1550         https://bugs.webkit.org/show_bug.cgi?id=112878
1551
1552         Reviewed by Jessie Berlin.
1553
1554         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
1555         included in the list of options grep --help shows.
1556
1557         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
1558
1559         * BuildSlaveSupport/kill-old-processes:
1560         (main):
1561
1562 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
1563
1564         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
1565         https://bugs.webkit.org/show_bug.cgi?id=112597
1566
1567         Reviewed by Xan Lopez.
1568
1569         These were introduced for the Chromium port in r105295. We need
1570         dummy implementations in order to compile the BlackBerry port.
1571
1572         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1573         (AccessibilityUIElement::scrollToMakeVisible):
1574         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1575         (AccessibilityUIElement::scrollToGlobalPoint):
1576
1577 2013-03-21  Roger Fong  <roger_fong@apple.com>
1578
1579         Re-enable WinEWS tests following r146376.
1580
1581         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1582         (WinEWS):
1583
1584 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
1585
1586         Unreviewed. Add Bem Jones-Bey to the list of contributors.
1587
1588         * Scripts/webkitpy/common/config/committers.py:
1589
1590 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1591
1592         [GTK] Missing atk in install-dependencies script
1593         https://bugs.webkit.org/show_bug.cgi?id=112272
1594
1595         Reviewed by Gustavo Noronha Silva.
1596
1597         * gtk/install-dependencies: Add missing atk dependency.
1598
1599 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1600
1601         [GTK] Missing backslash in install-dependencies script
1602         https://bugs.webkit.org/show_bug.cgi?id=112907
1603
1604         Reviewed by Philippe Normand.
1605
1606         * gtk/install-dependencies: Add missing backslash to dependencies
1607         list.
1608
1609 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1610
1611         EWS bots have stopped uploading results to bugzilla
1612         https://bugs.webkit.org/show_bug.cgi?id=101091
1613
1614         Reviewed by Adam Barth.
1615
1616         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
1617         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
1618         this relative file path resoled to a file inside a non-existent directory for "zip".
1619
1620         Fixed the bug by resolving both test results directory and zip archive paths in
1621         LayoutTestResultsReader.archive.
1622
1623         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
1624         in the future.
1625
1626         * Scripts/webkitpy/common/system/filesystem_mock.py:
1627         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
1628
1629         * Scripts/webkitpy/common/system/workspace.py:
1630         (Workspace.create_zip): Log the source path when "zip" failed.
1631
1632         * Scripts/webkitpy/common/system/workspace_mock.py:
1633         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
1634
1635         * Scripts/webkitpy/common/system/workspace_unittest.py:
1636         (WorkspaceTest.test_create_zip_exception): Test that.
1637
1638         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1639         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
1640         This is the actual bug fix.
1641
1642         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1643         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
1644
1645 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
1646
1647         [chromium] move WebThemeEngine implementations to TestRunner library
1648         https://bugs.webkit.org/show_bug.cgi?id=112751
1649
1650         Reviewed by Adam Barth.
1651
1652         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1653         * DumpRenderTree/DumpRenderTree.gypi:
1654         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1655         (WebKit):
1656         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1657         (WebTestRunner::TestInterfaces::themeEngine):
1658         (WebTestRunner):
1659         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1660         (WebKit):
1661         (TestInterfaces):
1662         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1663         (WebTestRunner::WebTestInterfaces::themeEngine):
1664         (WebTestRunner):
1665         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1666         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1667         (WebTestRunner):
1668         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1669         (WebTestRunner::WebTestThemeControlWin::box):
1670         (WebTestRunner::WebTestThemeControlWin::line):
1671         (WebTestRunner::WebTestThemeControlWin::triangle):
1672         (WebTestRunner::WebTestThemeControlWin::roundRect):
1673         (WebTestRunner::WebTestThemeControlWin::oval):
1674         (WebTestRunner::WebTestThemeControlWin::circle):
1675         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1676         (WebTestRunner::WebTestThemeControlWin::markState):
1677         (WebTestRunner::WebTestThemeControlWin::draw):
1678         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1679         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1680         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1681         (WebTestRunner):
1682         (WebTestThemeControlWin):
1683         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1684         (WebTestRunner):
1685         (WebTestThemeEngineMac):
1686         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1687         (+[FakeActiveWindow alwaysActiveWindow]):
1688         (+[FakeActiveWindow alwaysInactiveWindow]):
1689         (-[FakeActiveWindow initWithActiveControls:]):
1690         (-[FakeActiveWindow _hasActiveControls]):
1691         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1692         (WebTestRunner):
1693         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1694         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1695         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1696         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1697         (WebTestRunner):
1698         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1699         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1700         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1701         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1702         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1703         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1704         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1705         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1706         (WebTestRunner::WebTestThemeEngineWin::getSize):
1707         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1708         (WebTestRunner):
1709         (WebTestThemeEngineWin):
1710         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1711         * DumpRenderTree/chromium/TestShell.cpp:
1712         (TestShell::initialize):
1713         * DumpRenderTree/chromium/TestShell.h:
1714         (WebKit):
1715         * DumpRenderTree/chromium/TestShellMac.mm:
1716         (platformInit):
1717         * DumpRenderTree/chromium/TestShellWin.cpp:
1718         (platformInit):
1719         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1720
1721 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1722
1723         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
1724
1725         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
1726         New property sheet that does not link against CoreFoundation and
1727         CFNetwork.
1728         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1729         Use new TestWebKitAPICommonWinCairo property sheet.
1730         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1731         Ditto.
1732
1733 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1734
1735         [WinCairo] Unreviewed build fix for VS2010.
1736
1737         Had to add WinCairo-specific property sheets to deal with some
1738         library and path differences with the main Apple port.
1739
1740         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1741         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1742         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1743         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
1744         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
1745         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
1746
1747 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
1748
1749         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
1750         https://bugs.webkit.org/show_bug.cgi?id=112849
1751
1752         Reviewed by Sam Weinig.
1753
1754         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1755         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1756         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1757
1758 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1759
1760         [WinCairo] Build WebKit Tools under VS2010
1761         https://bugs.webkit.org/show_bug.cgi?id=112821
1762
1763         Reviewed by Tim Horton.
1764
1765         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1766         Add WinCairo-specific build target.
1767         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
1768         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
1769         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
1770         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
1771         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1772         Add WinCairo-specific build target.
1773         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1774         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1775         Add WinCairo-specific build target.
1776         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
1777         WinCairo-specific build target.
1778         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
1779         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
1780         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
1781         specific build target.
1782         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
1783         WinCairo-specific build target.
1784         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
1785         * win/record-memory/record-memoryDebugWinCairo.props: Added.
1786         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
1787
1788 2013-03-20  Roger Fong  <roger_fong@apple.com>
1789
1790         API test gardening AppleWin port.
1791
1792         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
1793
1794         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1795         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1796
1797 2013-03-20  Roger Fong  <roger_fong@apple.com>
1798
1799         Test fix for Win EWS bots, catch various errors and restart script if necessary.
1800
1801         * EWSTools/start-queue-win.sh:
1802
1803 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
1804
1805         Unreviewed, add myself to committers.py.
1806
1807 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1808
1809         Unreviewed. Adding another email for me.
1810
1811         * Scripts/webkitpy/common/config/committers.py:
1812
1813 2013-03-20  Justin Novosad  <junov@google.com>
1814
1815         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
1816         https://bugs.webkit.org/show_bug.cgi?id=112605
1817
1818         Reviewed by James Robinson.
1819
1820         Deleting all the code that was used for propagating and supporting
1821         the Chromium setting for disabling deferred 2d canvas rendering.
1822
1823         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1824         (main):
1825         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1826         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1827         (WebTestRunner::WebPreferences::reset):
1828         (WebTestRunner::WebPreferences::applyTo):
1829         * DumpRenderTree/chromium/TestShell.cpp:
1830         (TestShell::TestShell):
1831         (TestShell::resetWebSettings):
1832         (TestShell::runFileTest):
1833         * DumpRenderTree/chromium/TestShell.h:
1834         (TestShell):
1835
1836 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
1837
1838         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
1839         https://bugs.webkit.org/show_bug.cgi?id=112699.
1840
1841         Reviewed by Adam Barth.
1842
1843         * Scripts/webkitpy/layout_tests/port/qt.py:
1844         (QtPort._search_paths):
1845         (QtPort._port_specific_expectations_files):
1846         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1847         (QtPortTest):
1848         (QtPortTest._assert_search_path):
1849         (QtPortTest._assert_expectations_files):
1850
1851 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1852
1853         [Qt] Enable kerning by default
1854         https://bugs.webkit.org/show_bug.cgi?id=112704
1855
1856         Reviewed by Jocelyn Turcotte.
1857
1858         Disable kerning by default, since some reference test expectations
1859         expect kerning to be default off.
1860
1861         * DumpRenderTree/qt/TestRunnerQt.cpp:
1862         (TestRunnerQt::reset):
1863         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1864         (WTR::activateFonts):
1865
1866 2013-03-20  Zeno Albisser  <zeno@webkit.org>
1867
1868         [Qt] Remove empty function stubs from TestRunnerQt.
1869         https://bugs.webkit.org/show_bug.cgi?id=112799
1870
1871         We are reducing the code in TestRunnerQt step by step,
1872         in order to finally replace all of it with the generic
1873         TestRunner implementation.
1874         This patch removes several simple function stubs that
1875         currently do not implement any actual functionality.
1876
1877         Reviewed by Kenneth Rohde Christiansen.
1878
1879         * DumpRenderTree/qt/TestRunnerQt.cpp:
1880         * DumpRenderTree/qt/TestRunnerQt.h:
1881         (TestRunnerQt):
1882
1883 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1884
1885         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
1886         https://bugs.webkit.org/show_bug.cgi?id=112687
1887
1888         Reviewed by Kenneth Rohde Christiansen.
1889
1890         Hide the SearchBar by default on window creation.
1891
1892         * MiniBrowser/efl/main.c:
1893         (window_create):
1894
1895 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1896
1897         Unreviewed, rolling out r146304.
1898         http://trac.webkit.org/changeset/146304
1899         https://bugs.webkit.org/show_bug.cgi?id=112788
1900
1901         to many expectations to update (Requested by antonm on
1902         #webkit).
1903
1904         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1905         * DumpRenderTree/DumpRenderTree.gypi:
1906         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1907         (WebKit):
1908         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1909         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1910         (TestInterfaces):
1911         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1912         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1913         * DumpRenderTree/chromium/TestShell.cpp:
1914         (TestShell::initialize):
1915         * DumpRenderTree/chromium/TestShell.h:
1916         (WebKit):
1917         * DumpRenderTree/chromium/TestShellMac.mm:
1918         (platformInit):
1919         * DumpRenderTree/chromium/TestShellWin.cpp:
1920         (platformInit):
1921         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1922         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1923         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1924         (WebThemeControlDRTWin::box):
1925         (WebThemeControlDRTWin::line):
1926         (WebThemeControlDRTWin::triangle):
1927         (WebThemeControlDRTWin::roundRect):
1928         (WebThemeControlDRTWin::oval):
1929         (WebThemeControlDRTWin::circle):
1930         (WebThemeControlDRTWin::nestedBoxes):
1931         (WebThemeControlDRTWin::markState):
1932         (WebThemeControlDRTWin::draw):
1933         (WebThemeControlDRTWin::drawTextField):
1934         (WebThemeControlDRTWin::drawProgressBar):
1935         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1936         (WebThemeControlDRTWin):
1937         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1938         (WebThemeEngineDRTMac):
1939         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1940         (+[FakeActiveWindow alwaysActiveWindow]):
1941         (+[FakeActiveWindow alwaysInactiveWindow]):
1942         (-[FakeActiveWindow initWithActiveControls:]):
1943         (-[FakeActiveWindow _hasActiveControls]):
1944         (WebThemeEngineDRTMac::paintScrollbarThumb):
1945         (stateToHIEnableState):
1946         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1947         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1948         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
1949         (webRectToSkIRect):
1950         (drawControl):
1951         (drawTextField):
1952         (drawProgressBar):
1953         (WebThemeEngineDRTWin::paintButton):
1954         (WebThemeEngineDRTWin::paintMenuList):
1955         (WebThemeEngineDRTWin::paintScrollbarArrow):
1956         (WebThemeEngineDRTWin::paintScrollbarThumb):
1957         (WebThemeEngineDRTWin::paintScrollbarTrack):
1958         (WebThemeEngineDRTWin::paintSpinButton):
1959         (WebThemeEngineDRTWin::paintTextField):
1960         (WebThemeEngineDRTWin::paintTrackbar):
1961         (WebThemeEngineDRTWin::paintProgressBar):
1962         (WebThemeEngineDRTWin::getSize):
1963         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
1964         (WebThemeEngineDRTWin):
1965         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1966
1967 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1968
1969         [Qt] Support -webkit-font-smoothing
1970         https://bugs.webkit.org/show_bug.cgi?id=106009
1971
1972         Reviewed by Jocelyn Turcotte.
1973
1974         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
1975
1976         * DumpRenderTree/qt/TestRunnerQt.cpp:
1977         (TestRunnerQt::reset):
1978
1979 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
1980
1981         [GTK] accessibility/aria-scrollbar-role.html is failing
1982         https://bugs.webkit.org/show_bug.cgi?id=98358
1983
1984         Reviewed by Martin Robinson.
1985
1986         Adds support for checking accessibility object's orientation.
1987         Orientation is checked by retrieving proper state of accessibility object.
1988
1989         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1990         (checkElementState):
1991         (AccessibilityUIElement::orientation):
1992         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1993         (WTR::AccessibilityUIElement::orientation):
1994
1995 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
1996
1997         [chromium] move WebThemeEngine implementations to TestRunner library
1998         https://bugs.webkit.org/show_bug.cgi?id=112751
1999
2000         Reviewed by Adam Barth.
2001
2002         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2003         * DumpRenderTree/DumpRenderTree.gypi:
2004         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2005         (WebKit):
2006         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2007         (WebTestRunner::TestInterfaces::themeEngine):
2008         (WebTestRunner):
2009         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2010         (WebKit):
2011         (TestInterfaces):
2012         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2013         (WebTestRunner::WebTestInterfaces::themeEngine):
2014         (WebTestRunner):
2015         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2016         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2017         (WebTestRunner):
2018         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2019         (WebTestRunner::WebTestThemeControlWin::box):
2020         (WebTestRunner::WebTestThemeControlWin::line):
2021         (WebTestRunner::WebTestThemeControlWin::triangle):
2022         (WebTestRunner::WebTestThemeControlWin::roundRect):
2023         (WebTestRunner::WebTestThemeControlWin::oval):
2024         (WebTestRunner::WebTestThemeControlWin::circle):
2025         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2026         (WebTestRunner::WebTestThemeControlWin::markState):
2027         (WebTestRunner::WebTestThemeControlWin::draw):
2028         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2029         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2030         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2031         (WebTestRunner):
2032         (WebTestThemeControlWin):
2033         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2034         (WebTestRunner):
2035         (WebTestThemeEngineMac):
2036         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2037         (+[FakeActiveWindow alwaysActiveWindow]):
2038         (+[FakeActiveWindow alwaysInactiveWindow]):
2039         (-[FakeActiveWindow initWithActiveControls:]):
2040         (-[FakeActiveWindow _hasActiveControls]):
2041         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2042         (WebTestRunner):
2043         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2044         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2045         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2046         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2047         (WebTestRunner):
2048         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2049         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2050         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2051         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2052         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2053         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2054         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2055         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2056         (WebTestRunner::WebTestThemeEngineWin::getSize):
2057         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2058         (WebTestRunner):
2059         (WebTestThemeEngineWin):
2060         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2061         * DumpRenderTree/chromium/TestShell.cpp:
2062         (TestShell::initialize):
2063         * DumpRenderTree/chromium/TestShell.h:
2064         (WebKit):
2065         * DumpRenderTree/chromium/TestShellMac.mm:
2066         (platformInit):
2067         * DumpRenderTree/chromium/TestShellWin.cpp:
2068         (platformInit):
2069         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2070
2071 2013-03-19  Tony Chang  <tony@chromium.org>
2072
2073         Move testRunner.setTouchDragDropEnabled to internals.settings
2074         https://bugs.webkit.org/show_bug.cgi?id=112739
2075
2076         Reviewed by Adam Barth.
2077
2078         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2079         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2080         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2081         (TestRunner): Remove unnecessary code.
2082         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2083         (WebTestRunner::WebPreferences::reset):
2084         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2085
2086 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2087
2088         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2089         https://bugs.webkit.org/show_bug.cgi?id=112754
2090
2091         Reviewed by Darin Fisher.
2092
2093         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2094         now that it's always defined.
2095
2096         * DumpRenderTree/chromium/WebViewHost.cpp:
2097         * DumpRenderTree/chromium/WebViewHost.h:
2098         (WebViewHost):
2099
2100 2013-03-19  Kenneth Russell  <kbr@google.com>
2101
2102         Unreviewed, rolling out r146290.
2103         http://trac.webkit.org/changeset/146290
2104         https://bugs.webkit.org/show_bug.cgi?id=112751
2105
2106         Broke Chromium Mac build.
2107
2108         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2109         * DumpRenderTree/DumpRenderTree.gypi:
2110         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2111         (WebKit):
2112         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2113         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2114         (TestInterfaces):
2115         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2116         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2117         * DumpRenderTree/chromium/TestShell.cpp:
2118         (TestShell::initialize):
2119         * DumpRenderTree/chromium/TestShell.h:
2120         (WebKit):
2121         * DumpRenderTree/chromium/TestShellMac.mm:
2122         (platformInit):
2123         * DumpRenderTree/chromium/TestShellWin.cpp:
2124         (platformInit):
2125         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2126         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2127         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2128         (WebThemeControlDRTWin::box):
2129         (WebThemeControlDRTWin::line):
2130         (WebThemeControlDRTWin::triangle):
2131         (WebThemeControlDRTWin::roundRect):
2132         (WebThemeControlDRTWin::oval):
2133         (WebThemeControlDRTWin::circle):
2134         (WebThemeControlDRTWin::nestedBoxes):
2135         (WebThemeControlDRTWin::markState):
2136         (WebThemeControlDRTWin::draw):
2137         (WebThemeControlDRTWin::drawTextField):
2138         (WebThemeControlDRTWin::drawProgressBar):
2139         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2140         (WebThemeControlDRTWin):
2141         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2142         (WebThemeEngineDRTMac):
2143         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2144         (+[FakeActiveWindow alwaysActiveWindow]):
2145         (+[FakeActiveWindow alwaysInactiveWindow]):
2146         (-[FakeActiveWindow initWithActiveControls:]):
2147         (-[FakeActiveWindow _hasActiveControls]):
2148         (WebThemeEngineDRTMac::paintScrollbarThumb):
2149         (stateToHIEnableState):
2150         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2151         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2152         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2153         (webRectToSkIRect):
2154         (drawControl):
2155         (drawTextField):
2156         (drawProgressBar):
2157         (WebThemeEngineDRTWin::paintButton):
2158         (WebThemeEngineDRTWin::paintMenuList):
2159         (WebThemeEngineDRTWin::paintScrollbarArrow):
2160         (WebThemeEngineDRTWin::paintScrollbarThumb):
2161         (WebThemeEngineDRTWin::paintScrollbarTrack):
2162         (WebThemeEngineDRTWin::paintSpinButton):
2163         (WebThemeEngineDRTWin::paintTextField):
2164         (WebThemeEngineDRTWin::paintTrackbar):
2165         (WebThemeEngineDRTWin::paintProgressBar):
2166         (WebThemeEngineDRTWin::getSize):
2167         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2168         (WebThemeEngineDRTWin):
2169         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2170
2171 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2172
2173         [EFL] canvas-fallback-content.html is failing
2174         https://bugs.webkit.org/show_bug.cgi?id=111998
2175
2176         Reviewed by Chris Fleizach.
2177
2178         Adds support for getting platform name.
2179
2180         * DumpRenderTree/TestRunner.cpp:
2181         (TestRunner::staticValues):
2182         * DumpRenderTree/TestRunner.h:
2183         (TestRunner):
2184         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2185         (TestRunner::platformName):
2186
2187 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2188
2189         [chromium] move WebThemeEngine implementations to TestRunner library
2190         https://bugs.webkit.org/show_bug.cgi?id=112751
2191
2192         Reviewed by Adam Barth.
2193
2194         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2195         * DumpRenderTree/DumpRenderTree.gypi:
2196         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2197         (WebKit):
2198         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2199         (WebTestRunner::TestInterfaces::themeEngine):
2200         (WebTestRunner):
2201         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2202         (WebKit):
2203         (TestInterfaces):
2204         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2205         (WebTestRunner::WebTestInterfaces::themeEngine):
2206         (WebTestRunner):
2207         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2208         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2209         (WebTestRunner):
2210         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2211         (WebTestRunner::WebTestThemeControlWin::box):
2212         (WebTestRunner::WebTestThemeControlWin::line):
2213         (WebTestRunner::WebTestThemeControlWin::triangle):
2214         (WebTestRunner::WebTestThemeControlWin::roundRect):
2215         (WebTestRunner::WebTestThemeControlWin::oval):
2216         (WebTestRunner::WebTestThemeControlWin::circle):
2217         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2218         (WebTestRunner::WebTestThemeControlWin::markState):
2219         (WebTestRunner::WebTestThemeControlWin::draw):
2220         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2221         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2222         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2223         (WebTestRunner):
2224         (WebTestThemeControlWin):
2225         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2226         (WebTestRunner):
2227         (WebTestThemeEngineMac):
2228         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2229         (+[FakeActiveWindow alwaysActiveWindow]):
2230         (+[FakeActiveWindow alwaysInactiveWindow]):
2231         (-[FakeActiveWindow initWithActiveControls:]):
2232         (-[FakeActiveWindow _hasActiveControls]):
2233         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2234         (WebTestRunner):
2235         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2236         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2237         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2238         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2239         (WebTestRunner):
2240         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2241         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2242         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2243         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2244         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2245         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2246         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2247         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2248         (WebTestRunner::WebTestThemeEngineWin::getSize):
2249         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2250         (WebTestRunner):
2251         (WebTestThemeEngineWin):
2252         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2253         * DumpRenderTree/chromium/TestShell.cpp:
2254         (TestShell::initialize):
2255         * DumpRenderTree/chromium/TestShell.h:
2256         (WebKit):
2257         * DumpRenderTree/chromium/TestShellMac.mm:
2258         (platformInit):
2259         * DumpRenderTree/chromium/TestShellWin.cpp:
2260         (platformInit):
2261         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2262
2263 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2264
2265         [EFL][WK2] Separate WebView further from EwkView
2266         https://bugs.webkit.org/show_bug.cgi?id=111591
2267
2268         Reviewed by Caio Marcelo de Oliveira Filho.
2269
2270         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2271         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2272         since we can afford it having EWKViewGetWKView() private API to access WKView.
2273
2274         * TestWebKitAPI/PlatformWebView.h:
2275         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2276         (TestWebKitAPI::TEST):
2277         * TestWebKitAPI/efl/PlatformWebView.cpp:
2278         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2279         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2280         (TestWebKitAPI::PlatformWebView::resizeTo):
2281         (TestWebKitAPI::PlatformWebView::page):
2282         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2283         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2284         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2285         * WebKitTestRunner/PlatformWebView.h:
2286         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2287         (WTR::EventSenderProxy::dispatchEvent):
2288         (WTR::EventSenderProxy::keyDown):
2289         (WTR::EventSenderProxy::sendTouchEvent):
2290         (WTR::EventSenderProxy::setTouchModifier):
2291         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2292         (WTR::PlatformWebView::PlatformWebView):
2293         (WTR::PlatformWebView::~PlatformWebView):
2294         (WTR::PlatformWebView::resizeTo):
2295         (WTR::PlatformWebView::page):
2296         (WTR::PlatformWebView::focus):
2297         (WTR::PlatformWebView::windowSnapshotImage):
2298
2299 2013-03-19  Roger Fong  <roger_fong@apple.com>
2300
2301         Changes to VS2010 project files should only trigger builds on Windows bots.
2302         https://bugs.webkit.org/show_bug.cgi?id=112731
2303
2304         Reviewed by Timothy Horton.
2305
2306         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2307         (_should_file_trigger_build):
2308
2309 2013-03-19  Roger Fong  <roger_fong@apple.com>
2310
2311         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2312
2313         * Scripts/webkitpy/tool/steps/runtests.py:
2314         (RunTests.run):
2315         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2316         (RunTestsTest.test_webkit_run_unit_tests):
2317
2318 2013-03-19  Julie Parent  <jparent@chromium.org>
2319
2320         Dashboards: Introduce history namespace and unit tests.
2321         https://bugs.webkit.org/show_bug.cgi?id=112645
2322
2323         Reviewed by Ojan Vafai.
2324         
2325         Laying the framework for introducing the new history object and
2326         namespace.  This moves only static functions into the history
2327         namespace, and moves corresponding unit tests into seperate
2328         unit test file.
2329
2330         * TestResultServer/static-dashboards/aggregate_results.html:
2331         * TestResultServer/static-dashboards/dashboard_base.js:
2332         (parseCrossDashboardParameters):
2333         (parseDashboardSpecificParameters):
2334         (parseParameters):
2335         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2336         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2337         (.switch.return):
2338         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2339         * TestResultServer/static-dashboards/history.js: Added.
2340         * TestResultServer/static-dashboards/history_unittests.js: Added.
2341         * TestResultServer/static-dashboards/loader.js:
2342         (.):
2343         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2344         * TestResultServer/static-dashboards/run-unittests.html:
2345         * TestResultServer/static-dashboards/timeline_explorer.html:
2346         * TestResultServer/static-dashboards/timeline_explorer.js:
2347         * TestResultServer/static-dashboards/treemap.html:
2348         * TestResultServer/static-dashboards/treemap.js:
2349         (.switch.return):
2350         * TestResultServer/static-dashboards/ui.js:
2351
2352 2013-03-19  Daniel Bates  <dbates@webkit.org>
2353
2354         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2355         https://bugs.webkit.org/show_bug.cgi?id=112732
2356
2357         Reviewed by Eric Seidel.
2358
2359         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2360         of an existing file cannot be applied.
2361
2362         In particular, svn-{apply, unapply} compensate for differences in line endings
2363         by converting the line endings in a diff to match the line endings in the target
2364         file. The diff(1) command precedes the last line of a diff that adds a newline
2365         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2366         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2367         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2368         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2369         the newline characters in this special character sequence to match the line endings
2370         in the target file.
2371
2372         * Scripts/VCSUtils.pm:
2373         (parseDiff):
2374         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2375         Added tests:
2376             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2377             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2378             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2379             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2380         (escapeNewLineCharacters): Added.
2381         (toMacLineEndings): Added.
2382
2383 2013-03-19  James Robinson  <jamesr@chromium.org>
2384
2385         [chromium] Remove compositor settings that don't go through WebKit
2386         https://bugs.webkit.org/show_bug.cgi?id=112718
2387
2388         Reviewed by Adam Barth.
2389
2390         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2391         (main):
2392         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2393         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2394         (WebTestRunner::WebPreferences::reset):
2395         (WebTestRunner::WebPreferences::applyTo):
2396         * DumpRenderTree/chromium/TestShell.cpp:
2397         (TestShell::TestShell):
2398         (TestShell::resetWebSettings):
2399         * DumpRenderTree/chromium/TestShell.h:
2400         (TestShell):
2401
2402 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
2403
2404         Unreviewed, rolling out r146101.
2405         https://bugs.webkit.org/show_bug.cgi?id=111884
2406
2407         re-enable custom freetype on asan; this needs to be on
2408         now that the bot is running lucid.
2409
2410         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2411
2412 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
2413
2414         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
2415         https://bugs.webkit.org/show_bug.cgi?id=112365
2416
2417         Reviewed by Benjamin Poulain.
2418
2419         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
2420         harcoding it in wtf/Platform.h
2421
2422         * Scripts/webkitperl/FeatureList.pm:
2423
2424 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2425
2426         [Qt] Make ImageDiff similar to Chromium's ImageDiff
2427         https://bugs.webkit.org/show_bug.cgi?id=94782
2428
2429         Based on patch by Csaba Osztrogonác.
2430         Reviewed by Jocelyn Turcotte.
2431
2432         The diff image is generated with bright red indicating errors, but letting the base image
2433         shine through so the context of the error-pixel can be identified.
2434
2435         * DumpRenderTree/qt/ImageDiff.cpp:
2436         (main):
2437
2438 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
2439
2440         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
2441
2442         Rubber-stamped by Csaba Osztrogonác.
2443
2444         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
2445         since the latter might not cover the former.
2446
2447         * QtTestBrowser/launcherwindow.cpp:
2448         (LauncherWindow::print):
2449
2450 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2451
2452         Style tweeks to default.css.
2453         
2454         Rubber-stamped by David Kilzer.
2455         
2456         Give visited links a different color to other links, so you can
2457         see which builds you've viewed.
2458         
2459         Make the <small> text less tiny.
2460
2461         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2462         (small):
2463         (a:link,a:visited,a:active):
2464         (a:visited):
2465
2466 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2467
2468         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
2469         https://bugs.webkit.org/show_bug.cgi?id=112494
2470
2471         Reviewed by Dirk Pranke.
2472
2473         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
2474         Also merged two pairs of methods to cleanup the code.
2475
2476         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2477         (PerfTestsRunner.run): Merged _upload_and_show_results.
2478         (PerfTestsRunner._generate_results): Merged _generate_output_files.
2479
2480 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2481
2482         [chromium] build xdisplaycheck when building DRT
2483         https://bugs.webkit.org/show_bug.cgi?id=112636
2484
2485         Reviewed by Tony Chang.
2486
2487         It appears that we need xdisplaycheck to be built in order for
2488         Xvfb to be started correctly on the bots, and DRT was missing
2489         a dependency on it. This may be the cause of the ASAN bot not
2490         starting up properly (it only builds DRT).
2491
2492         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2493
2494 2013-03-18  David Levin  <levin@chromium.org>
2495
2496         Implement icon change notification dump for Chromium's test shell.
2497         https://bugs.webkit.org/show_bug.cgi?id=112614
2498
2499         This was previously implemented for some other platforms in r58111
2500         and r116547.
2501
2502         In r122806, fast/dom/icon-url-property.html stopped using it, but
2503         it is useful for tests, so I plan to re-add it to that test again.
2504
2505         Reviewed by Jochen Eisinger.
2506
2507         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2508         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
2509          icon change notifications from WebKit may be logged in test output.
2510         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2511         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
2512         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
2513         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
2514         (WebTestRunner):
2515         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
2516         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2517         (TestRunner):
2518         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2519         (WebTestRunner::WebTestProxyBase::didChangeIcon):
2520         (WebTestRunner):
2521         * DumpRenderTree/chromium/WebViewHost.cpp:
2522         (WebViewHost::didChangeIcon): Add the output about changing the icon.
2523         * DumpRenderTree/chromium/WebViewHost.h:
2524         (WebViewHost):
2525
2526 2013-03-18  Julie Parent  <jparent@chromium.org>
2527
2528         Cleanup: Move js for treemap and aggregate_results into own js files.
2529         https://bugs.webkit.org/show_bug.cgi?id=112618
2530
2531         Reviewed by Dirk Pranke.
2532         
2533         No functional changes, just moving the code into separate js file
2534         rather than inlined in the html, so we can test it, make it more
2535         modular, etc.  Other dashboard types are already done this way.
2536
2537         * TestResultServer/static-dashboards/aggregate_results.html:
2538         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
2539         (generatePage):
2540         (handleValidHashParameter):
2541         (htmlForBuilder):
2542         (rawValuesHTML):
2543         (chartHTML):
2544         (filteredValues):
2545         (chart):
2546         (htmlForRevisionRows):
2547         (wrapHTMLInTable):
2548         (htmlForSummaryTable):
2549         (valuesPerExpectation):
2550         (htmlForTestType):
2551         (htmlForTableRow):
2552         (extendedEncode):
2553         * TestResultServer/static-dashboards/treemap.html:
2554         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
2555         (humanReadableTime):
2556         (convertToWebTreemapFormat):
2557         (reverseSortByAverage):
2558         (generatePage):
2559         (focusPath):
2560         (.switch.return):
2561         (handleQueryParameterChange):
2562         (extractName):
2563         (fullName):
2564         (handleFocus.):
2565         (handleFocus):
2566
2567 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2568
2569         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
2570         https://bugs.webkit.org/show_bug.cgi?id=112622
2571
2572         Reviewed by Dirk Pranke.
2573
2574         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2575         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
2576
2577 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2578
2579         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
2580         https://bugs.webkit.org/show_bug.cgi?id=112619
2581
2582         Reviewed by Dirk Pranke.
2583
2584         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
2585         directory and then fall back to the generic LayoutTests/platform/gtk directory.
2586
2587         * Scripts/webkitpy/layout_tests/port/gtk.py:
2588         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
2589         Port._webkit_baseline_path method.
2590         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2591         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
2592         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
2593         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2594         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
2595         that are expected based on the builder name.
2596
2597 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
2598
2599         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
2600         https://bugs.webkit.org/show_bug.cgi?id=112571
2601
2602         Reviewed by Adam Barth.
2603
2604         Update function declarations for new WebFileSystemType enum. (All
2605         changes are behind an #ifdef so we can sync required changes in embedders.)
2606
2607         * DumpRenderTree/chromium/WebViewHost.cpp:
2608         (WebViewHost::openFileSystem):
2609         (WebViewHost::deleteFileSystem):
2610         * DumpRenderTree/chromium/WebViewHost.h:
2611         (WebViewHost):
2612
2613 2013-03-18  Julie Parent  <jparent@chromium.org>
2614
2615         Cleanup: Move timeline_exporer js out of html file into js.
2616         https://bugs.webkit.org/show_bug.cgi?id=112188
2617
2618         Reviewed by Dirk Pranke.
2619         
2620         Moves the javascript out of the html file and into a new js file.
2621         This follows the format of flakiness_dashboard.{html|js}.
2622         
2623         Also moves code from dashboard_base that is used only by this one
2624         dashboard, and makes it private to the dashboard.
2625
2626         * TestResultServer/static-dashboards/dashboard_base.js:
2627         * TestResultServer/static-dashboards/timeline_explorer.html:
2628         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
2629         (generatePage):
2630         (initCurrentBuilderTestResults):
2631         (shouldShowWebKitRevisionsOnly):
2632         (updateTimelineForBuilder.):
2633         (updateTimelineForBuilder):
2634         (selectBuild):
2635         (updateBuildIndicator):
2636         (.addRow):
2637         (.addNumberRow):
2638         (.inspectorNode.getElementsByTagName.0.onclick):
2639         (.inspectorNode.getElementsByTagName.1.onclick):
2640         (.inspectorNode.getElementsByTagName.2.onclick):
2641         (updateBuildInspector):
2642         (showResultsDelta):
2643         (decompressResults.addFlakyDelta):
2644         (decompressResults):
2645
2646 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2647
2648         Unreviewed, rolling out r145272.
2649         http://trac.webkit.org/changeset/145272
2650         https://bugs.webkit.org/show_bug.cgi?id=111884
2651
2652         Turns out the ASAN build is still broken; possibly there's
2653         something still setting LD_LIBRARY_PATH, or possibly there's
2654         something else wrong. In the meantime, we need it to work again.
2655
2656         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2657
2658 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2659
2660         delete-stale-build-files is too aggressive
2661         https://bugs.webkit.org/show_bug.cgi?id=112595
2662
2663         Reviewed by Tim Horton.
2664
2665         It appears that whitelisting file extensions to keep is not a good idea.
2666         Blacklist files to delete instead, and only delete .o files for now.
2667         We can add more file extensions as needed.
2668
2669         * BuildSlaveSupport/delete-stale-build-files:
2670
2671 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2672
2673         Disable accessibility notifications after each test
2674         https://bugs.webkit.org/show_bug.cgi?id=112579
2675
2676         Reviewed by Tim Horton.
2677         
2678         In WebKitTestRunner, if any tests triggered accessibility notifications,
2679         the global notification handler would thereafter be active, and fire
2680         notifications for all subsequent tests.
2681         
2682         Fix by implementing AccessibilityController::resetToConsistentState() for
2683         Mac, and using it to clear the global notification handler.
2684
2685         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2686         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2687         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
2688         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
2689         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
2690         (e.g. because of -autorelease).
2691         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
2692         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
2693         if there is one.
2694         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
2695         Add -stopObserving
2696         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2697         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
2698         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
2699         center.
2700
2701 2013-03-18  Dana Jansens  <danakj@chromium.org>
2702
2703         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
2704         https://bugs.webkit.org/show_bug.cgi?id=112392
2705
2706         Reviewed by James Robinson.
2707
2708         Removes the command line flag option from DRT.
2709
2710         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2711         (main):
2712
2713 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2714
2715         [GTK] plugins/plugin-clip-subframe.html is failing
2716         https://bugs.webkit.org/show_bug.cgi?id=112570
2717
2718         Reviewed by Martin Robinson.
2719
2720         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
2721
2722 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
2723
2724         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
2725         https://bugs.webkit.org/show_bug.cgi?id=112442
2726
2727         Reviewed by Gustavo Noronha Silva.
2728
2729         * GtkLauncher/main.c:
2730         (reloadCb):
2731         (createToolbar):
2732         (createWindow):
2733
2734 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2735
2736         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
2737         https://bugs.webkit.org/show_bug.cgi?id=112205
2738
2739         Disable this API test until Geoff can fix it.
2740
2741         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2742         (TestWebKitAPI::TEST):
2743
2744 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
2745
2746         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2747         https://bugs.webkit.org/show_bug.cgi?id=112478
2748
2749         Reviewed by Tony Chang.
2750
2751         There is nothing that ensures that the log messages from the plugin
2752         come in before the layout test finished loading.
2753
2754         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2755         (PassDifferentNPPStruct::NPP_SetWindow):
2756         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2757         (NPP_SetWindow):
2758
2759 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2760
2761         Have the mac port support per_test_timeout in webkitpy
2762         https://bugs.webkit.org/show_bug.cgi?id=112466
2763
2764         Reviewed by Dirk Pranke.
2765         
2766         Both WTR and DRT handle --timeout arguments, so we can
2767         have the scripts pass the timeout values down to the tools.
2768
2769         * Scripts/webkitpy/layout_tests/port/mac.py:
2770         (MacPort.supports_per_test_timeout):
2771
2772 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
2773
2774         Remove setAsynchronousSpellCheckingEnabled from test runners
2775         https://bugs.webkit.org/show_bug.cgi?id=112362
2776
2777         Reviewed by Tony Chang.
2778
2779         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
2780         in internals.settings, so all ports can share it.
2781
2782         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2783         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2784         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2785         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2786         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2787         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2788         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2789         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
2790         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2791         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
2792         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2793         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2794
2795 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2796
2797         Fix the stupid unit tests.
2798
2799         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2800         (test_sample_process):
2801
2802 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
2803
2804         Collect samples for unresponsive web processes
2805         https://bugs.webkit.org/show_bug.cgi?id=112409
2806
2807         Reviewed by Tim Horton.
2808         
2809         When we detect that a subprocess was unresponsive, run the 'sample'
2810         tool on that process, for the Mac port.
2811         
2812         The sample will be linked to from the results.html page, next
2813         to the crash log link.
2814
2815         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2816         (Manager._look_for_new_crash_logs): Before looking for crash logs,
2817         look for samples on disk.
2818         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2819         (TestResultWriter):
2820         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
2821         -sample.txt files, and have it copy their contents to a new file
2822         next to the test that spawned them (as we do for crash logs).
2823         * Scripts/webkitpy/layout_tests/port/base.py:
2824         (Port.look_for_new_samples): Base class does nothing for sampling.
2825         * Scripts/webkitpy/layout_tests/port/driver.py:
2826         (Driver._check_for_driver_crash): Kick off a sample if we detected
2827         that the subprocess was unresponsive.
2828         * Scripts/webkitpy/layout_tests/port/mac.py:
2829         (MacPort.sample_file_path): Utility to generate the file path
2830         to the generated sample files at the top level of layout-test-results.
2831         (MacPort.look_for_new_crash_logs): Fix typo
2832         (MacPort.look_for_new_samples): New function to find sample files.
2833         (MacPort.sample_process): Use the utility function to get the file path.
2834
2835 2013-03-15  Zeno Albisser  <zeno@webkit.org>
2836
2837         [Qt] Remove simple getters and setters from TestRunnerQt
2838         https://bugs.webkit.org/show_bug.cgi?id=112343
2839
2840         Reviewed by Benjamin Poulain.
2841
2842         The removed functions and boolean members
2843         are being replaced by the implementations in the
2844         generic TestRunner.h.
2845
2846         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2847         (DumpRenderTree::dumpFrameScrollPosition):
2848         (DumpRenderTree::dumpFramesAsText):
2849         (DumpRenderTree::dump):
2850         (DumpRenderTree::titleChanged):
2851         (DumpRenderTree::dumpDatabaseQuota):
2852         (DumpRenderTree::dumpApplicationCacheQuota):
2853         (DumpRenderTree::statusBarMessage):
2854         (DumpRenderTree::createWindow):
2855         * DumpRenderTree/qt/TestRunnerQt.cpp:
2856         (TestRunnerQt::reset):
2857         * DumpRenderTree/qt/TestRunnerQt.h:
2858         (TestRunnerQt):
2859
2860 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
2861
2862         Update the link on build.webkit.org to refer to perf.webkit.org
2863         https://bugs.webkit.org/show_bug.cgi?id=112416
2864
2865         Reviewed by Philip Rogers.
2866
2867         Updated the link. Also updated the template to use HTML5 DOCTYPE.
2868
2869         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2870
2871 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
2872
2873         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
2874         https://bugs.webkit.org/show_bug.cgi?id=112394
2875
2876         Reviewed by Philippe Normand.
2877
2878         * GtkLauncher/main.c:
2879         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
2880
2881 2013-03-14  Andreas Kling  <akling@apple.com>
2882
2883         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
2884         <http://webkit.org/b/111815>
2885         <rdar://problem/13380145>
2886
2887         Reviewed by Anders Carlsson.
2888
2889         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
2890         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
2891         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
2892
2893         * WebKitTestRunner/PlatformWebView.h:
2894         (PlatformWebView):
2895         * WebKitTestRunner/TestController.cpp:
2896         (WTR::TestController::createOtherPage):
2897         (WTR::TestController::createWebViewWithOptions):
2898         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2899         (WTR::PlatformWebView::didInitializeClients):
2900
2901 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2902
2903         [EFL][MiniBrowser] Add a search field to the MiniBrowser
2904         https://bugs.webkit.org/show_bug.cgi?id=112122
2905
2906         Reviewed by Kenneth Rohde Christiansen.
2907
2908         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
2909
2910         * MiniBrowser/efl/main.c:
2911         (_Browser_Window):
2912         (search_box_show):
2913         (search_box_hide):
2914         (on_key_down):
2915         (on_url_changed):
2916         (on_search_field_aborted):
2917         (on_search_field_activated):
2918         (on_search_field_clicked):
2919         (on_search_backward_button_clicked):
2920         (on_search_forward_button_clicked):
2921         (window_create):
2922
2923 2013-03-14  Julie Parent  <jparent@chromium.org>
2924
2925         Cleanup: Remove g_resourceLoader.
2926         https://bugs.webkit.org/show_bug.cgi?id=112305
2927
2928         Reviewed by Dirk Pranke.
2929         
2930         Removing another global.
2931         
2932         Now, each dashboard creates its own loader, rather than having
2933         a general global one.
2934         
2935         Remove usage of g_resourceLoader.isLoadingComplete from 
2936         handleLocationChange by ensuring that handleLocationChange is
2937         never called before the loader is done.  It was called in two
2938         places before: 1 was from the callback when the loader is done,
2939         so that was obviously true, and the other was from onhashchange,
2940         where it would just return rather than running.  Instead, lets
2941         only register the onhashchange handler once the loader is
2942         setup, so the check is no longer necessary.
2943         
2944         Remove isLoadingComplete since it is now unused.
2945         
2946         Callback for loader is now initializeHistory, rather than just
2947         handleLocationChange which will set up the hashchange handler now.
2948         This will all eventually be moving to a new History object.
2949
2950         * TestResultServer/static-dashboards/aggregate_results.html:
2951         * TestResultServer/static-dashboards/dashboard_base.js:
2952         (handleLocationChange):
2953         (intializeHistory):
2954         (decompressResults):
2955         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2956         (generatePage):
2957         * TestResultServer/static-dashboards/loader.js:
2958         (.):
2959         * TestResultServer/static-dashboards/loader_unittests.js:
2960         * TestResultServer/static-dashboards/timeline_explorer.html:
2961         * TestResultServer/static-dashboards/treemap.html:
2962
2963 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
2964
2965         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
2966         https://bugs.webkit.org/show_bug.cgi?id=109404
2967
2968         Reviewed by Tony Chang.
2969
2970         Removes all the code related to smartInsertDeleteEnabled and
2971         selectTrailingWhitespaceEnabled settings as they will be managed from
2972         internals from now on.
2973
2974         * DumpRenderTree/TestRunner.cpp:
2975         (TestRunner::staticFunctions):
2976         * DumpRenderTree/TestRunner.h:
2977         (TestRunner):
2978         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2979         (WebKit):
2980         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2981         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2982         (DumpRenderTree):
2983         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2984         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2985         (WebTestRunner::WebTestProxy::didStopLoading):
2986         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2987         (WebTestRunner::TestRunner::TestRunner):
2988         (WebTestRunner::TestRunner::reset):
2989         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2990         (TestRunner):
2991         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2992         (WebTestRunner::WebPreferences::applyTo): Set default values for
2993         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
2994         Chromium DRT default values are different from Chromium browser.
2995         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2996         * DumpRenderTree/chromium/WebViewHost.cpp:
2997         * DumpRenderTree/chromium/WebViewHost.h:
2998         (WebViewHost):
2999         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3000         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3001         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3002         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3003         (resetDefaultsToConsistentValues):
3004         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3005         * DumpRenderTree/mac/DumpRenderTree.mm:
3006         (resetWebViewToConsistentStateBeforeTesting):
3007         * DumpRenderTree/mac/TestRunnerMac.mm:
3008         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3009         (WebCore::WebPage::resetSettings):
3010         * DumpRenderTree/qt/TestRunnerQt.cpp:
3011         * DumpRenderTree/qt/TestRunnerQt.h:
3012         (TestRunnerQt):
3013         * DumpRenderTree/win/DumpRenderTree.cpp:
3014         (resetWebViewToConsistentStateBeforeTesting):
3015         * DumpRenderTree/win/TestRunnerWin.cpp:
3016         * DumpRenderTree/wx/TestRunnerWx.cpp:
3017
3018 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3019
3020         [Qt] Disable DRT on Windows
3021
3022         Reviewed by Jocelyn Turcotte.
3023
3024         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3025
3026         * qmake/mkspecs/features/configure.prf:
3027
3028 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3029
3030         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
3031         https://bugs.webkit.org/show_bug.cgi?id=110728
3032
3033         Reviewed by Gyuyoung Kim.
3034
3035         Use the page group to create the view object.
3036
3037         * MiniBrowser/efl/main.c:
3038         (window_create):
3039
3040 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3041
3042         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
3043
3044         Reviewed by Tor Arne Vestbø.
3045
3046         The mock versions of these web facing features should be instantiated when
3047         running in DumpRenderTree only. In order for them to work, no extra Qt modules
3048         such as QtLocation are actually needed.
3049
3050         This patch decouples enabling device orientation/motion and geolocation from
3051         the underlying Qt modules and makes them available in developer builds
3052         (!production_build) and backed by mock backends when running in drt.
3053
3054         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
3055         developers the web facing features are always enabled (although requests will
3056         time out) and the mock backends are enabled inside DRT, allowing for the layout
3057         tests to run with less dependencies.
3058
3059         In addition this also enables the mock device motion client, which was
3060         previously never instantiated.
3061
3062         * qmake/mkspecs/features/features.prf:
3063
3064 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3065
3066         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
3067         https://bugs.webkit.org/show_bug.cgi?id=112340
3068
3069         Reviewed by Simon Hausmann.
3070
3071         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3072         (DumpRenderTree::dump):
3073             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
3074         (DumpRenderTree::dumpApplicationCacheQuota):
3075         * DumpRenderTree/qt/TestRunnerQt.cpp:
3076         (TestRunnerQt::reset):
3077         * DumpRenderTree/qt/TestRunnerQt.h:
3078         (TestRunnerQt):
3079
3080 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3081
3082         [Qt] Port DRT to use TestRunner::dumpAsText()
3083         https://bugs.webkit.org/show_bug.cgi?id=112260
3084
3085         Reviewed by Benjamin Poulain.
3086
3087         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3088         (WebCore::DumpRenderTree::open):
3089         (WebCore::methodNameStringForFailedTest):
3090             Change parameter from type TestRunnerQt* to TestRunner*.
3091         (WebCore::DumpRenderTree::dump):
3092             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3093             Instead we should rely on TestRunner::generatePixelResults().
3094         * DumpRenderTree/qt/TestRunnerQt.cpp:
3095         (TestRunnerQt::reset):
3096         * DumpRenderTree/qt/TestRunnerQt.h:
3097         (TestRunnerQt):
3098
3099 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3100
3101         Implement FontLoader interface
3102         https://bugs.webkit.org/show_bug.cgi?id=98395
3103
3104         Reviewed by Eric Seidel.
3105
3106         Enable FontLoadEvents runtime flag for TestShell.
3107
3108         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3109         (WebTestRunner::TestInterfaces::TestInterfaces):
3110
3111 2013-03-13  Julie Parent  <jparent@chromium.org>
3112
3113         CLeanup: remove unnecessary call to parseParameters.
3114         https://bugs.webkit.org/show_bug.cgi?id=112309
3115
3116         Reviewed by Ojan Vafai.
3117         
3118         We call parseCrossDashboardParameters when the dashboard initially
3119         loads to set the state required for loadBuildersList, and then we
3120         call it again once we are fully done with loading, so there is no
3121         reason to call it in the middle of the loading process here.
3122
3123         * TestResultServer/static-dashboards/loader.js:
3124         (.):
3125
3126 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3127
3128         Unreviewed. Now I'm a reviewer :)
3129
3130         * Scripts/webkitpy/common/config/committers.py:
3131
3132 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3133
3134         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3135         https://bugs.webkit.org/show_bug.cgi?id=112277
3136
3137         Reviewed by Adam Barth.
3138
3139         * Scripts/webkitperl/FeatureList.pm:
3140         * qmake/mkspecs/features/features.pri:
3141
3142 2013-03-13  Adam Barth  <abarth@webkit.org>
3143
3144         run-perf-tests should support content_shell
3145         https://bugs.webkit.org/show_bug.cgi?id=112291
3146
3147         Reviewed by Eric Seidel.
3148
3149         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3150         (PerfTestsRunner._parse_args):
3151
3152 2013-03-13  Oliver Hunt  <oliver@apple.com>
3153
3154         Simplify Checked<> multiplication
3155         https://bugs.webkit.org/show_bug.cgi?id=112286
3156
3157         Reviewed by James Robinson.
3158
3159         Add tests for multiplication by zero and max to ensure we don't
3160         mess them up should we ever make changes to Checked<> in future.
3161
3162         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3163         (TestWebKitAPI):
3164
3165 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3166
3167         [Qt] Unreviewed prospective Windows build fix
3168
3169         Do the usual thing, include the moc generated code in the .cpp file instead
3170         of compiling it standalone, to ensure that config.h is included, too, and
3171         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3172
3173         * DumpRenderTree/qt/EventSenderQt.cpp:
3174
3175 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3176
3177         [Qt] Port TestRunner::findString to shared interface
3178         https://bugs.webkit.org/show_bug.cgi?id=112147
3179
3180         Reviewed by Jocelyn Turcotte.
3181
3182         This patch also removes DumpRenderTree and some other helper classes from
3183         the WebCore namespace, to which they do not really belong.
3184
3185         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3186         (main):
3187         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3188         (DumpRenderTree::DumpRenderTree):
3189         (DumpRenderTree::~DumpRenderTree):
3190         (DumpRenderTree::instance):
3191         (DumpRenderTree::setShouldTimeout):
3192         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3193         (DumpRenderTree):
3194         * DumpRenderTree/qt/EventSenderQt.cpp:
3195         (EventSender::contextClick):
3196         (EventSender::sendEvent):
3197         (EventSender::postEvent):
3198         * DumpRenderTree/qt/EventSenderQt.h:
3199         (EventSender::isGraphicsBased):
3200         * DumpRenderTree/qt/TestRunnerQt.cpp:
3201         (TestRunnerQt::TestRunnerQt):
3202         (TestRunner::findString):
3203         (TestRunnerQt::setMockDeviceOrientation):
3204         (TestRunnerQt::setGeolocationPermission):
3205         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3206         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3207         (TestRunnerQt::setMockGeolocationPosition):
3208         * DumpRenderTree/qt/TestRunnerQt.h:
3209         (TestRunnerQt):
3210
3211 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3212
3213         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3214         https://bugs.webkit.org/show_bug.cgi?id=112129
3215
3216         Reviewed by Adam Barth.
3217
3218         Following Chromium
3219         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3220         this is being renamed to better explain what it does.
3221
3222         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3223
3224 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3225
3226         [Qt] Unreviewed trivial typo fix
3227
3228         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3229         TextRunner.h. Thanks Zeno :)
3230
3231 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3232
3233         [Qt] Prepare DRT for transition to shared TestRunner interface
3234         https://bugs.webkit.org/show_bug.cgi?id=112144
3235
3236         Reviewed by Benjamin Poulain.
3237
3238         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3239         the JSC C API based one.
3240
3241         This is impplemented by instantiating the QObject based testRunner in
3242         the global object, then instantiating the JSC C based TestRunner
3243         separately and placing it "behind" the QObject based testRunner through
3244         injection of the individual functions through proxies. (prototype
3245         chaining doesn't work due to the this object and Function.prototype.bind
3246         doesn't work due to the native function)
3247
3248         This allows for porting over method by method by removing the method
3249         from the QObject TestRunnerQt and implementing it in the JSC C based
3250         TestRunner.
3251
3252         In order for this to link and run dummy implementations of all the
3253         necessary TestRunner functions are provided.
3254
3255         * DumpRenderTree/qt/DumpRenderTree.pro:
3256         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3257         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3258         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3259         (WebCore::DumpRenderTree::initJSObjects):
3260         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3261         (DumpRenderTree):
3262         * DumpRenderTree/qt/TestRunnerQt.cpp:
3263         (TestRunner::~TestRunner):
3264         (TestRunner::addDisallowedURL):
3265         (TestRunner::queueLoad):
3266         (TestRunner::removeAllVisitedLinks):
3267         (TestRunner::setAcceptsEditing):
3268         (TestRunner::simulateLegacyWebNotificationClick):
3269         (TestRunner::setWindowIsKey):
3270         (TestRunner::setAlwaysAcceptCookies):
3271         (TestRunner::addOriginAccessWhitelistEntry):
3272         (TestRunner::setWebViewEditable):
3273         (TestRunner::clearAllApplicationCaches):
3274         (TestRunner::setTextDirection):
3275         (TestRunner::notifyDone):
3276         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3277         (TestRunner::overridePreference):
3278         (TestRunner::pathToLocalResource):
3279         (TestRunner::removeAllWebNotificationPermissions):
3280         (TestRunner::simulateWebNotificationClick):
3281         (TestRunner::closeIdleLocalStorageDatabases):
3282         (TestRunner::focusWebView):
3283         (TestRunner::setBackingScaleFactor):
3284         (TestRunner::removeChromeInputField):
3285         (TestRunner::addChromeInputField):
3286         (TestRunner::originsWithLocalStorage):
3287         (TestRunner::deleteAllLocalStorage):
3288         (TestRunner::deleteLocalStorageForOrigin):
3289         (TestRunner::observeStorageTrackerNotifications):
3290         (TestRunner::syncLocalStorage):
3291         (TestRunner::windowCount):
3292         (TestRunner::setWaitToDump):
3293         (TestRunner::waitForPolicyDelegate):
3294         (TestRunner::webHistoryItemCount):
3295         (TestRunner::showWebInspector):
3296         (TestRunner::closeWebInspector):
3297         (TestRunner::evaluateInWebInspector):
3298         (TestRunner::setSerializeHTTPLoads):
3299         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3300         (TestRunner::setCustomPolicyDelegate):
3301         (TestRunner::setDatabaseQuota):
3302         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3303         (TestRunner::resetPageVisibility):
3304         (TestRunner::keepWebHistory):
3305         (TestRunner::goBack):
3306         (TestRunner::originsWithApplicationCache):
3307         (TestRunner::applicationCacheDiskUsageForOrigin):
3308         (TestRunner::display):
3309         (TestRunner::dispatchPendingLoadRequests):
3310         (TestRunner::clearPersistentUserStyleSheet):
3311         (TestRunner::callShouldCloseOnWebView):
3312         (TestRunner::copyDecodedHostName):
3313         (TestRunner::clearBackForwardList):
3314         (TestRunner::clearAllDatabases):
3315         (TestRunner::clearApplicationCacheForOrigin):
3316         (TestRunner::apiTestGoToCurrentBackForwardItem):
3317         (TestRunner::authenticateSession):
3318         (TestRunner::abortModal):
3319         (TestRunner::setStorageDatabaseIdleInterval):
3320         (TestRunner::setAsynchronousSpellCheckingEnabled):
3321         (TestRunner::setXSSAuditorEnabled):
3322         (TestRunner::setSpatialNavigationEnabled):
3323         (TestRunner::setScrollbarPolicy):
3324         (TestRunner::setJavaScriptCanAccessClipboard):
3325         (TestRunner::setAutomaticLinkDetectionEnabled):
3326         (TestRunner::setUserStyleSheetEnabled):
3327         (TestRunner::setUserStyleSheetLocation):
3328         (TestRunner::setUseDashboardCompatibilityMode):
3329         (TestRunner::setTabKeyCyclesThroughElements):
3330         (TestRunner::setSmartInsertDeleteEnabled):
3331         (TestRunner::setSelectTrailingWhitespaceEnabled):
3332         (TestRunner::setPrivateBrowsingEnabled):
3333         (TestRunner::setPluginsEnabled):
3334         (TestRunner::setPopupBlockingEnabled):
3335         (TestRunner::setMockSpeechInputDumpRect):
3336         (TestRunner::setPersistentUserStyleSheetLocation):
3337         (TestRunner::setMockGeolocationPosition):
3338         (TestRunner::setMockGeolocationPositionUnavailableError):
3339         (TestRunner::setMockDeviceOrientation):
3340         (TestRunner::setMainFrameIsFirstResponder):
3341         (TestRunner::setIconDatabaseEnabled):
3342         (TestRunner::setGeolocationPermission):
3343         (TestRunner::setDefersLoading):
3344         (TestRunner::setCacheModel):
3345         (TestRunner::setAuthorAndUserStylesEnabled):
3346         (TestRunner::setAllowFileAccessFromFileURLs):
3347         (TestRunner::setAppCacheMaximumSize):
3348         (TestRunner::setAllowUniversalAccessFromFileURLs):
3349         (TestRunner::setApplicationCacheOriginQuota):
3350         (TestRunner::denyWebNotificationPermission):
3351         (TestRunner::grantWebNotificationPermission):
3352         (TestRunner::setValueForUser):
3353         (TestRunner::setViewModeMediaFeature):
3354         (TestRunner::setPageVisibility):
3355         (TestRunner::addMockSpeechInputResult):
3356         (TestRunner::removeOriginAccessWhitelistEntry):
3357         (TestRunner::addUserScript):
3358         (TestRunner::isCommandEnabled):
3359         (TestRunner::evaluateScriptInIsolatedWorld):
3360         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3361         (TestRunner::copyEncodedHostName):
3362         (TestRunner::addUserStyleSheet):
3363         (TestRunner::findString):
3364         (TestRunner::execCommand):
3365         (TestRunner::localStorageDiskUsageForOrigin):
3366
3367 2013-03-12  Julie Parent  <jparent@chromium.org>
3368
3369         Cleanup: Move flatten-trie to loader.
3370         https://bugs.webkit.org/show_bug.cgi?id=112196
3371
3372         Reviewed by Dirk Pranke.
3373
3374         flatten-trie is used only by the loader, so move it there and make it
3375         private, rather than global in dashbaord_base. Moved the corresponding
3376         unit test from flakiness_dashboard_unittests to loader_unittests.
3377         
3378         * TestResultServer/static-dashboards/dashboard_base.js:
3379         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3380         * TestResultServer/static-dashboards/loader.js:
3381         (.):
3382         * TestResultServer/static-dashboards/loader_unittests.js:
3383
3384 2013-03-12  Oliver Hunt  <oliver@apple.com>
3385
3386         Unbreak api tests
3387
3388         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3389         (TestWebKitAPI):
3390
3391 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3392
3393         Unreviewed, disabling tests for Win EWS.
3394
3395         win-ews obviously cannot keep up with running tests, it's >300 behind.
3396         Probably doesn't help that its (likely) running tests serially.
3397
3398         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3399         (WinEWS):
3400
3401 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3402
3403         Add a --build-directory argument to delete-stale-build-files
3404         https://bugs.webkit.org/show_bug.cgi?id=112198
3405
3406         Reviewed by Ryosuke Niwa.
3407
3408         * BuildSlaveSupport/delete-stale-build-files:
3409         (main): Add --build-directory argument.
3410
3411 2013-03-12  Oliver Hunt  <oliver@apple.com>
3412
3413         Appease MSVC
3414
3415         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3416         (TestWebKitAPI):
3417
3418 2013-03-12  Oliver Hunt  <oliver@apple.com>
3419
3420         Add more Checked<> tests
3421         https://bugs.webkit.org/show_bug.cgi?id=112190
3422
3423         Reviewed by Geoffrey Garen.
3424
3425         Tests!
3426
3427         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3428         (TestWebKitAPI):
3429
3430 2013-03-12  Julie Parent  <jparent@chromium.org>
3431
3432         Cleanup: Move loading complete function into callback, rather than global.
3433         https://bugs.webkit.org/show_bug.cgi?id=112167
3434
3435         Reviewed by Dirk Pranke.
3436         
3437         Stop calling global functions, pass in proper handler to Loader
3438         constructor. Note that the callback is optional, as tests, and
3439         some potential dashboards, do not need one.
3440
3441         * TestResultServer/static-dashboards/dashboard_base.js:
3442         * TestResultServer/static-dashboards/loader.js:
3443         (.):
3444         * TestResultServer/static-dashboards/loader_unittests.js:
3445
3446 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3447
3448         [EFL][WK2] Add popup menu support to MiniBrowser
3449         https://bugs.webkit.org/show_bug.cgi?id=108934
3450
3451         Reviewed by Kenneth Rohde Christiansen.
3452
3453         Implement popup menu support in MiniBrowser by handling popup_menu_show
3454         and popup_menu_hide smart functions on the view and using the Ewk popup
3455         menu API.
3456
3457         * MiniBrowser/efl/main.c:
3458         (_Browser_Window):
3459         (on_popup_menu_discarded):
3460         (on_popup_menu_item_clicked):
3461         (popup_menu_populate):
3462         (on_popup_menu_show):
3463         (on_popup_menu_hide):
3464         (window_create): Use calloc() instead of malloc() to allocate memory for
3465         Browser_Window. This makes sure all the structs members are initialized
3466         to 0 (such as the new elm_popup_menu pointer).
3467
3468 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3469
3470         [GTK] Set up the libPlatformGtk.la library
3471         https://bugs.webkit.org/show_bug.cgi?id=111738
3472
3473         Reviewed by Martin Robinson.
3474
3475         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3476         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
3477         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3478
3479 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3480
3481         [GTK] Enable Web Audio in development builds
3482         https://bugs.webkit.org/show_bug.cgi?id=111831
3483
3484         Reviewed by Philippe Normand.
3485
3486         Web Audio is already quite well supported on the GTK port but still has a few issues
3487         that must be addressed before it is enabled by default. Despite that it should be enabled
3488         in development builds just so we are up-to-date with future feature infrastructure changes.
3489         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3490         that's an obvious goal before enabling the feature in release builds.
3491
3492         * Scripts/webkitperl/FeatureList.pm:
3493
3494 2013-03-11  Andreas Kling  <akling@apple.com>
3495
3496         [Mac][WK1] Add support for alert() in MiniBrowser.
3497         <http://webkit.org/b/112090>
3498
3499         Reviewed by Anders Carlsson.
3500
3501         * MiniBrowser/mac/WK1BrowserWindowController.m:
3502         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3503
3504 2013-03-11  Julie Parent  <jparent@chromium.org>
3505
3506         Dashboard cleanup: Create ui.Errors
3507         https://bugs.webkit.org/show_bug.cgi?id=111785
3508
3509         Reviewed by Ojan Vafai.
3510         
3511         Create ui.Errors for handling errors the dashboards
3512         encounter. Loader now has a Error object that it can add to,
3513         and individual dashboards can show errors when desired.
3514         Currently, only flakiness_db shows errors, but this is 
3515         generic and there is no reason why other dbs wouldn't want to
3516         show errors.
3517
3518         * TestResultServer/static-dashboards/dashboard_base.js:
3519         (resourceLoadingComplete):
3520         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3521         (generatePage):
3522         * TestResultServer/static-dashboards/loader.js:
3523         (.):
3524         * TestResultServer/static-dashboards/ui.js:
3525         (.):
3526
3527 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
3528
3529         Some StringHasher tests are broken because of missing null termination
3530         https://bugs.webkit.org/show_bug.cgi?id=111284
3531
3532         Reviewed by Darin Adler.
3533
3534         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3535         (TestWebKitAPI): Added null termination since C strings are null-terminated.
3536         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
3537         the bug caught by it is now fixed.
3538
3539 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3540
3541         Unreviewed, rolling out r145200.
3542         http://trac.webkit.org/changeset/145200
3543         https://bugs.webkit.org/show_bug.cgi?id=112063
3544
3545         Broke a couple of unit tests (Requested by zdobersek on
3546         #webkit).
3547
3548         * Scripts/webkitperl/FeatureList.pm:
3549
3550 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
3551
3552         [GTK] WebKit2-only build fails
3553         https://bugs.webkit.org/show_bug.cgi?id=112033
3554
3555         Reviewed by Gustavo Noronha Silva.
3556
3557         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
3558         generic part, WebKit1-specific part and WebKit2-specific part.
3559         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
3560         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
3561         directly.
3562
3563 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
3564
3565         Adding myself to the committers list.
3566
3567         Unreviewed.
3568
3569         * Scripts/webkitpy/common/config/committers.py:
3570
3571 2013-03-11  Jeff Rogers  <jrogers@rim.com>
3572
3573         [BlackBerry] Disable MathML support
3574         https://bugs.webkit.org/show_bug.cgi?id=111929
3575
3576         Reviewed by Rob Buis.
3577
3578         * Scripts/webkitperl/FeatureList.pm:
3579
3580 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3581
3582         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
3583         https://bugs.webkit.org/show_bug.cgi?id=111970
3584
3585         Reviewed by Chris Fleizach.
3586
3587         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
3588         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
3589         undefined symbol.
3590
3591         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3592         (WTR::AccessibilityUIElement::supportedActions):
3593         (WTR):
3594
3595 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
3596
3597         [chromium] Android apk targets should depend directly on Java library targets
3598         https://bugs.webkit.org/show_bug.cgi?id=111746
3599
3600         Reviewed by Eric Seidel.
3601
3602         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3603         Make DumpRenderTree_apk depend directly on base_java and net_java.
3604         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3605         Make TestWebKitAPI_apk depend directly on base_java.
3606
3607 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
3608
3609         [chromium] remove obsolete user gesture methods from WebFrame
3610         https://bugs.webkit.org/show_bug.cgi?id=111696
3611
3612         Reviewed by Adam Barth.
3613
3614         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3615         (WebTestRunner::TestPlugin::handleInputEvent):
3616         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3617
3618 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
3619
3620         Unreviewed, add myself to commiters.py.
3621
3622         * Scripts/webkitpy/common/config/committers.py:
3623
3624 2013-03-08  Julie Parent  <jparent@chromium.org>
3625
3626         Cleanup: Remove dead code.
3627         https://bugs.webkit.org/show_bug.cgi?id=111900
3628
3629         Reviewed by Dirk Pranke.
3630         
3631         Treemap overrides a global function that used to be in 
3632         dashboard_base, but was removed months ago in
3633         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
3634         no caller. 
3635
3636         * TestResultServer/static-dashboards/treemap.html:
3637
3638 2013-03-08  Harald Alvestrand  <hta@chromium.org>
3639
3640         Implemented new API for RTCStatsReport object.
3641         https://bugs.webkit.org/show_bug.cgi?id=110333
3642
3643         Reviewed by Adam Barth.
3644
3645         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3646         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
3647
3648 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
3649
3650         [chromium] use custom freetype on linux asan builds again
3651         https://bugs.webkit.org/show_bug.cgi?id=111884
3652
3653         Reviewed by Tony Chang.
3654
3655         We no longer need the workaround after chromium r186540.
3656
3657         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3658
3659 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
3660
3661         Warning about the user not having edit rights on Bugzilla is confusing new contributors
3662         https://bugs.webkit.org/show_bug.cgi?id=111798
3663
3664         Reviewed by Dirk Pranke.
3665
3666         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
3667
3668         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3669
3670 2013-03-08  James Robinson  <jamesr@chromium.org>
3671
3672         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
3673         https://bugs.webkit.org/show_bug.cgi?id=111632
3674
3675         Reviewed by Adrienne Walker.
3676
3677         * DumpRenderTree/chromium/WebViewHost.cpp:
3678         (WebViewHost::initializeLayerTreeView):
3679         * DumpRenderTree/chromium/WebViewHost.h:
3680         (WebViewHost):
3681
3682 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
3683
3684         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
3685         https://bugs.webkit.org/show_bug.cgi?id=111297
3686
3687         Reviewed by Kenneth Rohde Christiansen.
3688
3689         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3690         (WTR::TestRunner::setViewModeMediaFeature):
3691
3692 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
3693
3694         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
3695         https://bugs.webkit.org/show_bug.cgi?id=111814
3696
3697         Reviewed by Ryosuke Niwa.
3698
3699         Add the needed supportedActions() attribute to WKTestRunner.
3700
3701         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3702         (WTR::AccessibilityUIElement::supportedActions):
3703         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3704         (AccessibilityUIElement):
3705         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3706         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3707         (WTR::AccessibilityUIElement::supportedActions):
3708
3709 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3710
3711         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
3712         https://bugs.webkit.org/show_bug.cgi?id=111851
3713
3714         Reviewed by Kenneth Rohde Christiansen.
3715
3716         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3717         (TestWebKitAPI::TEST):
3718
3719             Fixed WKURLRef instance leaking.
3720
3721 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3722
3723         [EFL] [WK2] Some authentication tests fail in WebKit2
3724         https://bugs.webkit.org/show_bug.cgi?id=106407
3725
3726         Reviewed by Kenneth Rohde Christiansen.
3727
3728         Add patch from upstream for libsoup 2.40 to fix several authentication
3729         test cases.
3730
3731         * efl/jhbuild.modules:
3732         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
3733
3734 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
3735
3736         [GTK] Enable Web Audio in development builds
3737         https://bugs.webkit.org/show_bug.cgi?id=111831
3738
3739         Reviewed by Philippe Normand.
3740
3741         Web Audio is already quite well supported on the GTK port but still has a few issues
3742         that must be addressed before it is enabled by default. Despite that it should be enabled
3743         in development builds just so we are up-to-date with future feature infrastructure changes.
3744         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3745         that's an obvious goal before enabling the feature in release builds.
3746
3747         * Scripts/webkitperl/FeatureList.pm:
3748
3749 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3750
3751         [chromium] delay clearing the TestRunners until the main view was deleted
3752         https://bugs.webkit.org/show_bug.cgi?id=111823
3753
3754         Reviewed by Eric Seidel.
3755
3756         During WebViewHost::shutdown, we navigate the WebView to about:blank.
3757         This may call into the test runners which assume that the delegate is
3758         always non-NULL.
3759
3760         * DumpRenderTree/chromium/TestShell.cpp:
3761         (TestShell::~TestShell):
3762
3763 2013-03-07  Alan Cutter  <alancutter@chromium.org>
3764
3765         Sheriffbot whois command can't search by full name
3766         https://bugs.webkit.org/show_bug.cgi?id=111825
3767
3768         Reviewed by Eric Seidel.
3769
3770         Allowed multiple arguments to Sheriffbot's whois command.
3771         Updated test expectations.
3772
3773         * Scripts/webkitpy/tool/bot/irc_command.py:
3774         (Whois.execute):
3775         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3776         (IRCCommandTest.test_whois):
3777
3778 2013-03-07  Nils Barth  <nbarth@chromium.org>
3779
3780         Add Nils Barth and Koji Hara to committers.py
3781         https://bugs.webkit.org/show_bug.cgi?id=111806
3782
3783         Reviewed by Eric Seidel.
3784
3785         * Scripts/webkitpy/common/config/committers.py:
3786
3787 2013-03-07  Glenn Adams  <glenn@skynav.com>
3788
3789         run-pert-tests should have a --test-runner-count option
3790         https://bugs.webkit.org/show_bug.cgi?id=111726
3791
3792         Reviewed by Ryosuke Niwa.
3793
3794         Add --test-runner-count option to run-perf-tests, with default value of 4.
3795         This option allows command line configuration of the number of times to invoke
3796         the test runner (serially, not in parallel) when running a specific test in
3797         a test set.
3798
3799         * Scripts/webkitpy/performance_tests/perftest.py:
3800         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
3801         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
3802         (PerfTest.run): Rename process_run_count to test_runner_count.
3803         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
3804         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
3805         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
3806         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
3807         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3808         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
3809         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
3810         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3811         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
3812         (MainTest.test_run_with_repeat):
3813         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
3814         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3815         (MainTest.test_default_args): Add test for default option argument values.
3816         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
3817
3818 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
3819
3820         Add myself to reviewers.py
3821         https://bugs.webkit.org/show_bug.cgi?id=111757
3822
3823         Reviewed by Eric Seidel.
3824
3825         * Scripts/webkitpy/common/config/committers.py:
3826
3827 2013-03-07  Glenn Adams  <glenn@skynav.com>
3828
3829         run-perf-tests should have a --repeat option
3830         https://bugs.webkit.org/show_bug.cgi?id=100030
3831
3832         Reviewed by Ryosuke Niwa.
3833
3834         Add --repeat option to run-perf-tests, with default value of 1. When greater
3835         than 1, runs test set specified number of times. Note that multiple runs are
3836         not aggregated for statistical purposes.
3837
3838         Incidentally fixed typo: s/suceeds/succeeds/.
3839
3840         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3841         (PerfTestsRunner._parse_args): Add repeat option.
3842         (PerfTestsRunner.run): Add outer repeat loop.
3843         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
3844         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
3845         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3846         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
3847         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
3848         (MainTest.test_run_with_json_output): Fix typo.
3849         (MainTest.test_run_with_description): Fix typo.
3850         (MainTest.test_run_respects_no_results): Fix typo.
3851         (MainTest.test_run_with_slave_config_json): Fix typo.
3852         (MainTest.test_run_with_multiple_repositories): Fix typo.
3853         (MainTest.test_run_with_upload_json): Fix typo.
3854         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
3855         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
3856         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3857         (MainTest.test_parse_args): Add test for repeat option parsing.
3858
3859 2013-03-07  Julie Parent  <jparent@chromium.org>
3860
3861         showAllRuns checkbox no longer works on the stats dashboard
3862         https://bugs.webkit.org/show_bug.cgi?id=111673
3863
3864         Reviewed by Ojan Vafai.
3865
3866         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
3867         so we were trying to index into an undefined object.
3868         
3869         * TestResultServer/static-dashboards/dashboard_base.js:
3870         (invalidateQueryParameters):
3871
3872 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
3873
3874         [Chromium] Update #include for WebStorageNamespace.h
3875         https://bugs.webkit.org/show_bug.cgi?id=111748
3876
3877         Reviewed by Adam Barth.
3878
3879         In anticipation of removing
3880         WK/chromium/public/WebStorageNamespace.h (once downstream
3881         references have been updated)
3882
3883         * DumpRenderTree/chromium/WebViewHost.cpp:
3884
3885 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3886
3887         run-perf-tests fails due to svn_revision not working on a pure git clone
3888         https://bugs.webkit.org/show_bug.cgi?id=110839
3889
3890         Reviewed by Ryosuke Niwa.
3891
3892         Previously we would call git svn find-rev to look up the commit for
3893         a given revision, and that'll hang in a pure git checkout.
3894
3895         This patch changes the way we look up svn revisions in a git
3896         repository to use git log --grep 'git-svn-id', which is much faster
3897         than grepping ourselves. It also renames timestamp_of_latest_commit()
3898         to timestamp_of_revision() in order to accurately reflect what
3899         the method is doing. Note that this patch only changes the logic
3900         inside latest_revision() and svn_revision(). I'll file a separate
3901         bug to change git_commit_from_svn_revision().
3902
3903         This patch also contains some fixes to unit tests that had bit-rotted
3904         or were otherwise fragile, so that test-webkitpy --all would pass
3905         cleanly, and a fix to outputcapture so that
3906         test-webkitpy -p would work correctly again.
3907
3908         * Scripts/webkitpy/common/checkout/scm/git.py:
3909         (Git.svn_revision):
3910         (Git.timestamp_of_revision):
3911         * Scripts/webkitpy/common/checkout/scm/scm.py:
3912         (SCM.svn_revision):
3913         (SCM.timestamp_of_revision):
3914         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3915         (MockSCM.timestamp_of_revision):
3916         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3917         (_shared_test_commit_with_message):
3918         (test_commit_without_authorization):
3919         (test_timestamp_of_revision):
3920         * Scripts/webkitpy/common/checkout/scm/svn.py:
3921         (SVN.timestamp_of_revision):
3922         * Scripts/webkitpy/common/system/outputcapture.py:
3923           Importing unittest2 directly may not be safe if this module is
3924           imported before the autoinstaller gets a chance to set things up
3925           properly. We don't actually need unittest2 here.
3926         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3927         (PerfTestsRunner._generate_results_dict):
3928
3929 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3930
3931         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
3932         https://bugs.webkit.org/show_bug.cgi?id=111756
3933
3934         Reviewed by Kenneth Rohde Christiansen.
3935
3936         Bump libsoup to v2.40.3 to fix the regressions introduced by
3937         previous v2.40.0 bump.
3938
3939         * efl/jhbuild.modules:
3940
3941 2013-03-07  Roger Fong  <roger_fong@apple.com>
3942
3943         Re-enable Win EWS tests.
3944
3945         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3946         (WinEWS):
3947
3948 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3949
3950         [nrwt] handle corrupt http server pid files cleanly
3951         https://bugs.webkit.org/show_bug.cgi?id=111628
3952
3953         Reviewed by Eric Seidel.
3954
3955         If the pid file from a previous http server is corrupt for some
3956         reason, NRWT will just raise errors and not clean it up or recover.
3957         This patch fixes that to at least delete the pid file and
3958         not throw; not that we may still have stale http servers left on
3959         the system, since there's no way to know which pid to kill if
3960         the file was corrupted.
3961
3962         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3963         (HttpServerBase.start):
3964         (HttpServerBase.stop):
3965         (HttpServerBase._remove_pid_file):
3966         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
3967         (TestHttpServerBase):
3968         (TestHttpServerBase.test_corrupt_pid_file):
3969
3970 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
3971
3972         AX: Can't activate links with VoiceOver in Safari
3973         https://bugs.webkit.org/show_bug.cgi?id=111755
3974
3975         Reviewed by Tim Horton.
3976
3977         * DumpRenderTree/AccessibilityUIElement.cpp:
3978         (supportedActionsCallback):
3979         (AccessibilityUIElement::getJSClass):
3980         * DumpRenderTree/AccessibilityUIElement.h:
3981         (AccessibilityUIElement):
3982         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3983         (AccessibilityUIElement::supportedActions):
3984
3985 2013-03-07  Roger Fong  <roger_fong@apple.com>
3986
3987         Windows debug layout tests are crashing like crazy again.
3988         Disable tests on Win EWS bots temporarily.
3989
3990         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3991         (WinEWS):
3992
3993 2013-03-07  Roger Fong  <roger_fong@apple.com>
3994
3995         Make EWS bots build and test in release.
3996
3997         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3998         (WinEWS):
3999         * Scripts/webkitpy/tool/steps/runtests.py:
4000         (RunTests.run):
4001
4002 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
4003
4004         [chromium] don't track the top loading frame if no layout test is currently running
4005         https://bugs.webkit.org/show_bug.cgi?id=111716
4006
4007         Reviewed by Kentaro Hara.
4008
4009         In DRT, we synchronously stop the test and start loading the next test
4010         URL. However, in content_shell, this happens asynchronously. It's
4011         important that the top loading frame is not changed due to stray
4012         navigation events before the next test starts.
4013
4014         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4015         (WebTestRunner::TestRunner::setTopLoadingFrame):
4016
4017 2013-03-06  Julie Parent  <jparent@chromium.org>
4018
4019         Dashboard cleanup: Move all dashboard ui related code into ui.js.
4020         https://bugs.webkit.org/show_bug.cgi?id=111621
4021
4022         Reviewed by Ojan Vafai.
4023         
4024         Creates ui.js, a package for the common UI code the various
4025         dashboards use. HTML generation is now in the ui.html namespace
4026         and popup handling is in ui.popup.
4027         Also moves the event listening for popups to ui.popup.show and
4028         removes it on ui.popup.hid rather than having listener always
4029         around.
4030
4031         * TestResultServer/static-dashboards/aggregate_results.html:
4032         * TestResultServer/static-dashboards/dashboard_base.js:
4033         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4034         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4035         (showPopupForBuild):
4036         (htmlForNavBar):
4037         (generatePageForIndividualTests.if):
4038         (generatePageForIndividualTests):
4039         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
4040         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4041         * TestResultServer/static-dashboards/run-embedded-unittests.html:
4042         * TestResultServer/static-dashboards/run-unittests.html:
4043         * TestResultServer/static-dashboards/timeline_explorer.html:
4044         * TestResultServer/static-dashboards/treemap.html:
4045         * TestResultServer/static-dashboards/ui.js: Added.
4046         (.):
4047
4048 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
4049
4050         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
4051         https://bugs.webkit.org/show_bug.cgi?id=110584
4052
4053         Reviewed by Gyuyoung Kim.
4054
4055         Adds missing implementation of AccessibilityControllerEfl
4056         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
4057         so that it can make accessibilityController as a js object.
4058
4059         * DumpRenderTree/AccessibilityController.h:
4060         (AccessibilityController):
4061         * DumpRenderTree/AccessibilityUIElement.h:
4062         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
4063         (AccessibilityController::childElementById): Moved declaration to base class.
4064         Implementation can be shared among other ports.
4065         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
4066         (AccessibilityController::focusedElement):
4067         (AccessibilityController::rootElement):
4068         (AccessibilityController::accessibleElementById):
4069         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
4070         (AccessibilityUIElement::helpText):
4071         * DumpRenderTree/efl/CMakeLists.txt:
4072         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4073         (DumpRenderTreeChrome::DumpRenderTreeChrome):
4074         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4075         (DumpRenderTreeChrome::onWindowObjectCleared):
4076         (DumpRenderTreeChrome::accessibilityController):
4077         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
4078         (DumpRenderTreeChrome):
4079         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
4080
4081 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
4082
4083         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
4084         https://bugs.webkit.org/show_bug.cgi?id=42696
4085
4086         Reviewed by Andreas Kling.
4087
4088         * DumpRenderTree/TestRunner.cpp:
4089         (TestRunner::staticFunctions):
4090         * DumpRenderTree/TestRunner.h:
4091         (TestRunner):
4092         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4093         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4094         (WebTestRunner::TestRunner::TestRunner):
4095         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4096         (TestRunner):
4097         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4098         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4099         * DumpRenderTree/mac/TestRunnerMac.mm:
4100         * DumpRenderTree/qt/TestRunnerQt.cpp:
4101         * DumpRenderTree/qt/TestRunnerQt.h:
4102         (TestRunnerQt):
4103         * DumpRenderTree/win/TestRunnerWin.cpp:
4104         * DumpRenderTree/wx/TestRunnerWx.cpp:
4105
4106 2013-03-06  Roger Fong  <roger_fong@apple.com>
4107
4108         Re-enable WinEWS test and decrease iterations before clean build back to 10.
4109
4110         * EWSTools/start-queue-win.sh:
4111         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4112         (WinEWS):
4113
4114 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
4115
4116         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
4117         https://bugs.webkit.org/show_bug.cgi?id=82866
4118
4119         Reviewed by Martin Robinson.
4120
4121         * Scripts/run-gtk-tests:
4122         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
4123         it is passing now.
4124
4125 2013-03-06  Julie Parent  <jparent@chromium.org>
4126
4127         Dashboard cleanup: remove dashboard time logging.
4128         https://bugs.webkit.org/show_bug.cgi?id=111608
4129
4130         Reviewed by Dirk Pranke.
4131
4132         Remove logTime.  It was never accurate, and the dev tools
4133         have better ways to measure this if anyone cares to look
4134         into dashboard perf.
4135         
4136         * TestResultServer/static-dashboards/dashboard_base.js:
4137         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4138         (processTestRunsForBuilder):
4139         (appendHTML):
4140
4141 2013-03-06  Tony Chang  <tony@chromium.org>
4142
4143         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
4144         https://bugs.webkit.org/show_bug.cgi?id=111509
4145
4146         Reviewed by Dirk Pranke.
4147
4148         Add DumpRenderTree.pak to DumpRenderTree.app again.
4149
4150         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4151
4152 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
4153
4154         [chromium] introduce WebUserGestureIndicator
4155         https://bugs.webkit.org/show_bug.cgi?id=111531
4156
4157         Reviewed by Adam Barth.
4158
4159         * DumpRenderTree/chromium/WebViewHost.cpp:
4160         (WebViewHost::createView):
4161
4162 2013-03-06  Alan Cutter  <alancutter@chromium.org>
4163
4164         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
4165         https://bugs.webkit.org/show_bug.cgi?id=73482
4166
4167         Reviewed by Ryosuke Niwa.
4168
4169         Added input checking to the UpdateChromiumDEPS step.
4170         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
4171
4172         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
4173         (RollChromiumDEPS):
4174         (RollChromiumDEPS._parse_args):
4175         (RollChromiumDEPS.execute):
4176         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
4177         (IRCCommandTest.test_roll_chromium_deps):
4178         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
4179         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
4180         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
4181         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
4182         (UpdateChromiumDEPS._fetch_last_known_good_revision):
4183         (UpdateChromiumDEPS):
4184         (UpdateChromiumDEPS._parse_revision_number):
4185         (UpdateChromiumDEPS._validate_revisions):
4186         (UpdateChromiumDEPS.run):
4187         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
4188         (UpdateChromiumDEPSTest):
4189         (UpdateChromiumDEPSTest.test_parse_revision_number):
4190         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
4191         (RollChromiumDEPS):
4192         (PostChromiumDEPSRoll):
4193
4194 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
4195
4196         [Qt][MiniBrowser] Touch mocking broken for chained getures
4197         https://bugs.webkit.org/show_bug.cgi?id=111430
4198
4199         Reviewed by Jocelyn Turcotte.
4200
4201         Make it possible again to use touch mocking to test gesture chains
4202         like pan->pinch->pan->pinch without lifting the primary "finger".
4203         For this to work we need to track the pressed mouse buttons and
4204         only synthesize touch release events when the ctrl key is released
4205         if no mouse button is pressed. Else the pressed mouse button(s)
4206         should result in a stationary touch point in a touch update event.
4207         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
4208         to check for the state of the ctrl key modifier instead of getting
4209         it from the mouse events.
4210
4211         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4212         (MiniBrowserApplication::MiniBrowserApplication):
4213         (MiniBrowserApplication::notify):
4214
4215 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4216
4217         [chromium] don't use custom freetype on linux asan for now
4218         https://bugs.webkit.org/show_bug.cgi?id=111516
4219
4220         Unreviewed, build fix.
4221
4222         Turns out the custom lib is getting picked up by other binaries
4223         on our bot, which is bad.
4224
4225         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4226
4227 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4228
4229         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
4230         https://bugs.webkit.org/show_bug.cgi?id=111509
4231
4232         Unreviewed, build fix.
4233
4234         Actually comment out the flag :(.
4235
4236         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4237
4238 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4239
4240         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
4241         https://bugs.webkit.org/show_bug.cgi?id=111509
4242
4243         Unreviewed, build fix.
4244
4245         r144863 appears to have broken the xcode build; I'm temporarily
4246         trying this instead, and if this doesn't work, I'll revert the
4247         other changes.
4248
4249         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4250
4251 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
4252
4253         [chromium] build a DumpRenderTree.pak even on windows
4254         https://bugs.webkit.org/show_bug.cgi?id=111504
4255
4256         Reviewed by Tony Chang.
4257
4258         The Chromium Aura build uses the default theme to draw
4259         controls, and that theme requires the ui ResourceBundle
4260         to be initialized. On every other platform, we build
4261         a DumpRenderTree.pak that works for this, but on Windows we
4262         still compile the resources directly into DRT. As a first step,
4263         let's build the pak file. I will then need to land a patch
4264         in Chromium to actually load it. Then I can go back and move
4265         the resources over to just use the .pak file and no longer need
4266         the .rc's.
4267
4268         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4269
4270 2013-03-05  Julie Parent  <jparent@chromium.org>
4271         Dashboard cleanup: move string utilities into their own namespace.
4272         
4273         https://bugs.webkit.org/show_bug.cgi?id=111485
4274
4275         Reviewed by Ojan Vafai.
4276         
4277         One of many pieces to clean up dashboard_bas