[CMake][WTF] Mirror XCode header directories
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2
3         [CMake][WTF] Mirror XCode header directories
4         https://bugs.webkit.org/show_bug.cgi?id=191662
5
6         Reviewed by Konstantin Tokarev.
7
8         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
9         builds.
10
11         * CMakeLists.txt:
12         * DumpRenderTree/CMakeLists.txt:
13         * DumpRenderTree/PlatformWin.cmake:
14         * MiniBrowser/win/CMakeLists.txt:
15         * TestWebKitAPI/CMakeLists.txt:
16         * TestWebKitAPI/PlatformWin.cmake:
17         * WebKitTestRunner/PlatformGTK.cmake:
18         * WebKitTestRunner/PlatformWin.cmake:
19
20 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
21
22         [ews-app] Status bubble should not display certain infrastructure status messages
23         https://bugs.webkit.org/show_bug.cgi?id=196550
24
25         Reviewed by Lucas Forschler.
26
27         Do not display the steps which are un-needed for end-user. This information is still avaiable
28         if the user click on the bubble and look at the Buildbot build.
29         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
30         (StatusBubble._steps_messages):
31         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
32
33 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
34
35         [ews-build] Use https for sending data to ews-app
36         https://bugs.webkit.org/show_bug.cgi?id=196492
37
38         Reviewed by Lucas Forschler.
39
40         * BuildSlaveSupport/ews-build/events.py:
41
42 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
43
44         Remove support for -apple-trailing-word
45         https://bugs.webkit.org/show_bug.cgi?id=196525
46
47         Reviewed by Zalan Bujtas.
48
49         This CSS property is nonstandard and not used.
50
51         * Scripts/webkitperl/FeatureList.pm:
52         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
53
54 2019-04-03  Youenn Fablet  <youenn@apple.com>
55
56         Add a test for DOMCache on multiple browsing in case of private browsing
57         https://bugs.webkit.org/show_bug.cgi?id=196524
58
59         Reviewed by Alex Christensen.
60
61         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
62         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
63
64 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
65
66         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
67         https://bugs.webkit.org/show_bug.cgi?id=196540
68
69         Reviewed by Aakash Jain.
70
71         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
72
73 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
74
75         Add plumbing for a compatibility mode preference in WebKit
76         https://bugs.webkit.org/show_bug.cgi?id=196005
77
78         Reviewed by Tim Horton.
79
80         Add new API tests.
81
82         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
83         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
84
85 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
86
87         [WPE][GTK] Update libsrtp dependency package for Debian
88         https://bugs.webkit.org/show_bug.cgi?id=196528
89
90         Reviewed by Frédéric Wang.
91
92         * gtk/install-dependencies:
93         * wpe/install-dependencies:
94
95 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
96
97         [WK2] Add support for Window's beforeprint / afterprint events
98         https://bugs.webkit.org/show_bug.cgi?id=196478
99         <rdar://problem/49535124>
100
101         Unreviewed build fix for MSVC.
102
103         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
104
105         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
106
107         * WebKitTestRunner/TestController.cpp:
108         (WTR::printFrame): Use int and float literals.
109
110 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
111
112         [ews-build] Reassign bots to queues
113
114         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
115
116 2019-04-02  Chris Dumez  <cdumez@apple.com>
117
118         [WK2] Add support for Window's beforeprint / afterprint events
119         https://bugs.webkit.org/show_bug.cgi?id=196478
120
121         Reviewed by Alex Christensen.
122
123         Add minimal implementation for printFrame in WebKitTestRunner.
124
125         * WebKitTestRunner/TestController.cpp:
126         (WTR::printFrame):
127         (WTR::TestController::createOtherPage):
128         (WTR::TestController::createWebViewWithOptions):
129
130 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
131
132         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
133         https://bugs.webkit.org/show_bug.cgi?id=196491
134
135         Reviewed by Lucas Forschler.
136
137         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
138
139 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
140
141         [ews-build] Configure buildbot try credentials in environment variables
142         https://bugs.webkit.org/show_bug.cgi?id=196501
143
144         Reviewed by Lucas Forschler.
145
146         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
147         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
148         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
149
150 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
151
152         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
153         https://bugs.webkit.org/show_bug.cgi?id=196496
154         <rdar://problem/49521634>
155
156         Reviewed by Chris Dumez.
157
158         Add new API tests (see WebKit ChangeLog for more detail).
159
160         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
161         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
162         (TEST):
163
164 2019-04-02  David Kilzer  <ddkilzer@apple.com>
165
166         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
167         <https://webkit.org/b/196499>
168
169         Reviewed by Alexey Proskuryakov.
170
171         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
172         ENABLE_ADDRESS_SANITIZER.
173
174 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
175
176         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
177         https://bugs.webkit.org/show_bug.cgi?id=182757
178
179         Reviewed by Don Olmstead.
180
181         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
182         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
183
184 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
185
186         run-api-tests: Upload test results
187         https://bugs.webkit.org/show_bug.cgi?id=196323
188         <rdar://problem/49356714>
189
190         Reviewed by Lucas Forschler.
191
192         * Scripts/webkitpy/api_tests/manager.py:
193         (Manager):
194         (Manager.run): Upload results to a results database.
195         * Scripts/webkitpy/api_tests/run_api_tests.py:
196         (parse_args): Add upload arguments.
197         * Scripts/webkitpy/port/base.py:
198         (Port):
199         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
200         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
201         with commits from any other associated repositories.
202         * Scripts/webkitpy/port/device.py:
203         (Device):
204         (Device.build_version): Access build_versoin of underlying platform device.
205         * Scripts/webkitpy/port/ios_simulator_unittest.py:
206         (IOSSimulatorTest):
207         (IOSSimulatorTest.test_configuration_for_upload):
208         * Scripts/webkitpy/port/device_port.py:
209         (DevicePort):
210         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
211         the same as the machine uploading results.
212         * Scripts/webkitpy/port/mac.py:
213         (MacPort):
214         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
215         * Scripts/webkitpy/port/mac_unittest.py:
216         (MacTest):
217         (MacTest.test_configuration_for_upload):
218         * Scripts/webkitpy/xcode/simulated_device.py:
219         (SimulatedDeviceManager._create_device_with_runtime):
220         (SimulatedDevice.__init__): Create simulated device with a build_version.
221         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
222         (test_existing_simulator):
223
224 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
225
226         Remove extra newline characters (Follow-up fix to r243707)
227
228         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
229
230 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
231
232         [ews-app] Use API_KEY to accept results data
233         https://bugs.webkit.org/show_bug.cgi?id=196461
234
235         Reviewed by Dewei Zhu.
236
237         * BuildSlaveSupport/ews-app/ews/views/results.py:
238         (Results.post): Validate EWS_API_KEY before accepting any data.
239         * BuildSlaveSupport/ews-build/events.py:
240         (Events.sendData): Send EWS_API_KEY if available along with event data.
241
242 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
243
244         Unable to copy and paste a PDF from Notes into Mail compose body
245         https://bugs.webkit.org/show_bug.cgi?id=196442
246         <rdar://problem/48573098>
247
248         Reviewed by Tim Horton.
249
250         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
251         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
252         to be specified on the item providers.
253
254         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
255         (TestWebKitAPI::mapItemForTesting):
256         (TestWebKitAPI::contactItemForTesting):
257
258 2019-04-01  Tim Horton  <timothy_horton@apple.com>
259
260         Make UIWKDocumentContext rects per-character instead of per-word
261         https://bugs.webkit.org/show_bug.cgi?id=196459
262
263         Reviewed by Wenson Hsieh.
264
265         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
266         (TEST):
267         Adjust test results due to switching to per-character rects.
268
269 2019-04-01  Chris Dumez  <cdumez@apple.com>
270
271         UIProcess crash when a prewarmed process is terminated
272         https://bugs.webkit.org/show_bug.cgi?id=196451
273         <rdar://problem/49245471>
274
275         Reviewed by Geoffrey Garen.
276
277         Add API test coverage.
278
279         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
280         (TEST):
281
282 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
283
284         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
285         https://bugs.webkit.org/show_bug.cgi?id=196449
286
287         Reviewed by Lucas Forschler.
288
289         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
290         (StatusBubble.get_os_details): Method to get OS and Xcode details.
291         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
292         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
293
294 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
295
296         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
297         https://bugs.webkit.org/show_bug.cgi?id=196444
298
299         Reviewed by Lucas Forschler.
300
301         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
302
303 2019-04-01  Alex Christensen  <achristensen@webkit.org>
304
305         Add SPI to canonicalize NSURLs with WTF::URL
306         https://bugs.webkit.org/show_bug.cgi?id=196415
307         <rdar://problem/44980271>
308
309         Reviewed by Darin Adler.
310
311         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
312         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
313         (TestWebKitAPI::TEST):
314
315 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
316
317         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
318         https://bugs.webkit.org/show_bug.cgi?id=196441
319
320         Reviewed by Carlos Garcia Campos.
321
322         Don't cache the wpe_view_backend object that might not exist yet at the
323         time of EventSenderProxy constructor invocation, but instead retrieve
324         that object whenever it's required for event dispatching. This should
325         avoid crashes in this constructor now that it's invoked before any
326         PlatformWindow has been set up (as changed in r243496).
327
328         * WebKitTestRunner/EventSenderProxy.h:
329         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
330         (WTR::viewBackend):
331         (WTR::EventSenderProxy::EventSenderProxy):
332         (WTR::EventSenderProxy::mouseDown):
333         (WTR::EventSenderProxy::mouseUp):
334         (WTR::EventSenderProxy::mouseMoveTo):
335         (WTR::EventSenderProxy::mouseScrollBy):
336         (WTR::EventSenderProxy::keyDown):
337         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
338
339 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
340
341         [Win][WebKit] MiniBrowser should support high DPI display
342         https://bugs.webkit.org/show_bug.cgi?id=196391
343
344         Reviewed by Alex Christensen.
345
346         * MiniBrowser/win/WebKitBrowserWindow.cpp:
347         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
348         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
349         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
350
351 2019-03-31  Sam Weinig  <weinig@apple.com>
352
353         Remove more i386 specific configurations
354         https://bugs.webkit.org/show_bug.cgi?id=196430
355
356         Reviewed by Alexey Proskuryakov.
357
358         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
359         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
360
361 2019-03-31  Andy Estes  <aestes@apple.com>
362
363         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
364         https://bugs.webkit.org/show_bug.cgi?id=196433
365         <rdar://problem/49293305>
366
367         Reviewed by Tim Horton.
368
369         Enhanced API test coverage to include all navigation response policy decisions in both
370         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
371
372         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
373         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
374         (TestWebKitAPI::TEST):
375         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
376         (readFile):
377         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
378         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
379         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
380         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
381         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
382         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
383         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
384         (-[QuickLookDelegate _downloadDidStart:]):
385         (-[QuickLookDelegate _download:didReceiveResponse:]):
386         (-[QuickLookDelegate _download:didReceiveData:]):
387         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
388         (-[QuickLookDelegate _downloadDidFinish:]):
389         (-[QuickLookDelegate _download:didFailWithError:]):
390         (-[QuickLookDelegate _downloadDidCancel:]):
391         (-[QuickLookDelegate verifyDownload]):
392         (runTest):
393         (runTestDecideBeforeLoading):
394         (runTestDecideAfterLoading):
395         (TEST):
396         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
397         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
398         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
399         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
400         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
401         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
402         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
403         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
404         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
405         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
406         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
407         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
408         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
409         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
410
411 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
412
413         [CMake] add testdfg as target with build-jsc
414         https://bugs.webkit.org/show_bug.cgi?id=196393
415
416         Reviewed by Saam Barati.
417
418         Added testdfg as one of the targets to build when
419         using CMake.
420
421         * Scripts/build-jsc:
422
423 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
424
425         Delete WebMetal implementation in favor of WebGPU
426         https://bugs.webkit.org/show_bug.cgi?id=195418
427
428         Reviewed by Dean Jackson.
429
430         * DumpRenderTree/mac/DumpRenderTree.mm:
431         (enableExperimentalFeatures):
432         (resetWebPreferencesToConsistentValues):
433         * Scripts/webkitperl/FeatureList.pm:
434         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
436         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
437         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
438         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
439         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
440         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
441         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
442         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
443         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
444         (WTR::InjectedBundle::beginTesting):
445         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
446         (WTR::TestRunner::setWebMetalEnabled): Deleted.
447         * WebKitTestRunner/InjectedBundle/TestRunner.h:
448
449 2019-03-29  Chris Dumez  <cdumez@apple.com>
450
451         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
452         https://bugs.webkit.org/show_bug.cgi?id=196405
453         <rdar://problem/49428130>
454
455         Reviewed by Wenson Hsieh.
456
457         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
458         the popover presentation methods to be no-ops. Use this in the new test added in
459         r243523 so that we do not swizzle those methods for all tests. This is needed because
460         those WatchOS tests rely on the popover getting presented and interactive.
461
462         * WebKitTestRunner/TestController.cpp:
463         (WTR::updateTestOptionsFromTestHeader):
464         * WebKitTestRunner/TestController.h:
465         * WebKitTestRunner/TestOptions.h:
466         (WTR::TestOptions::hasSameInitializationOptions const):
467         * WebKitTestRunner/ios/TestControllerIOS.mm:
468         (WTR::TestController::platformInitialize):
469         (WTR::TestController::platformResetStateToConsistentValues):
470
471 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
472
473         [Curl] Add Server Trust Evaluation Support.
474         https://bugs.webkit.org/show_bug.cgi?id=191646
475
476         Reviewed by Fujii Hironori.
477
478         Implemented MiniBrowser UI for asking if user trusts the server.
479
480         * MiniBrowser/win/Common.cpp:
481         (askServerTrustEvaluation):
482         (replaceString):
483         * MiniBrowser/win/Common.h:
484         * MiniBrowser/win/MiniBrowserLib.rc:
485         * MiniBrowser/win/MiniBrowserLibResource.h:
486         * MiniBrowser/win/WebKitBrowserWindow.cpp:
487         (createPEMString):
488         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
489         (WebKitBrowserWindow::canTrustServerCertificate):
490         * MiniBrowser/win/WebKitBrowserWindow.h:
491
492 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
493
494         Implement ResizeObserver.
495         https://bugs.webkit.org/show_bug.cgi?id=157743
496
497         Reviewed by Simon Fraser.
498
499         Support resizeObserverEnabled webPreferences.
500
501         * DumpRenderTree/TestOptions.cpp:
502         (TestOptions::TestOptions):
503         * DumpRenderTree/TestOptions.h:
504         * DumpRenderTree/mac/DumpRenderTree.mm:
505         (setWebPreferencesForTestOptions):
506         * DumpRenderTree/win/DumpRenderTree.cpp:
507         (enableExperimentalFeatures):
508         * Scripts/webkitperl/FeatureList.pm:
509         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
510
511 2019-03-28  John Wilander  <wilander@apple.com>
512
513         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
514         https://bugs.webkit.org/show_bug.cgi?id=196281
515         <rdar://problem/48938748>
516
517         Reviewed by Alex Christensen.
518
519         This patch adds the function isStatisticsHasLocalStorage() to the
520         TestRunner. With it, the page can query the WebsiteDataStore in the
521         UI process to make sure that it sees LocalStorage.
522
523         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
524         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
525         (WTR::TestRunner::isStatisticsHasLocalStorage):
526         * WebKitTestRunner/InjectedBundle/TestRunner.h:
527         * WebKitTestRunner/TestController.cpp:
528         (WTR::TestController::isStatisticsHasLocalStorage):
529         * WebKitTestRunner/TestController.h:
530         * WebKitTestRunner/TestInvocation.cpp:
531         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
532
533 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
534
535         API::Data::createWithoutCopying should do a null check before calling CFRelease
536         https://bugs.webkit.org/show_bug.cgi?id=196276
537         <rdar://problem/48059859>
538
539         Reviewed by Alex Christensen.
540
541         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
542
543         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
544         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
545         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
546         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
547         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
548         (TestWebKitAPI::TEST):
549
550 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
551
552         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
553         https://bugs.webkit.org/show_bug.cgi?id=186276
554
555         Reviewed by Carlos Garcia Campos.
556
557         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
558         (webViewLoadChanged):
559         (testWebResourceGetDataError):
560         (testWebResourceGetDataEmpty):
561         (beforeAll):
562         (webViewloadChanged): Deleted.
563
564 2019-03-27  Andy Estes  <aestes@apple.com>
565
566         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
567         https://bugs.webkit.org/show_bug.cgi?id=196317
568
569         Reviewed by Dan Bernstein.
570
571         package-root copies built products into a staging directory using ditto(1), which does not
572         follow symbolic links as it traverses a directory. Now that the files in
573         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
574         itself, these become broken links when ditto'd into the staging directory.
575
576         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
577
578         * Scripts/package-root:
579
580 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
581
582         [ews-app] Update display text of Submit for ews analysis
583         https://bugs.webkit.org/show_bug.cgi?id=196309
584
585         Reviewed by Dewei Zhu.
586
587         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
588
589 2019-03-27  David Kilzer  <ddkilzer@apple.com>
590
591         run-webkit-tests should check for leaks in WebKit processes
592         <https://webkit.org/b/193772>
593         <rdar://problem/46526680>
594
595         Reviewed by Ryosuke Niwa.
596
597         This works by doing the following:
598         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
599           The list of child processes are returned one per line:
600           process.name: pid
601         - Run the "#LIST CHILD PROCESSES" command just before the
602           "#CHECK FOR WORLD LEAKS" command, and store the list of child
603           processes on the ServerProcess object.
604         - When the `--leaks` switch is handled, run check_for_leaks() on
605           each child process after the main test harness.
606
607         * DumpRenderTree/mac/DumpRenderTree.mm:
608         (handleControlCommand):
609         - Use strncmp() instead of strcmp().
610         - Add support for handling "#LIST CHILD PROCESSES" command.
611
612         * Scripts/webkitpy/port/base.py:
613         (Port.check_for_leaks):
614         * Scripts/webkitpy/port/darwin.py:
615         (DarwinPort.check_for_leaks):
616         - Rename redundant 'process_pid' argument to 'process_id'.
617
618         * Scripts/webkitpy/port/driver.py:
619         (Driver.do_post_tests_work):
620         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
621           longer the only command this sends to WebKitTestRunner.
622         - If the `--leaks` switch is present, send the
623           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
624           result using Port.set_webkit_processes().
625         (Driver._parse_child_processes_output):
626         - Add helper method to parse list of child process names and
627           process IDs returned from WebKitTestRunner.
628
629         * Scripts/webkitpy/port/ios_device.py:
630         (IOSDevicePort.check_for_leaks):
631         - Rename redundant 'process_pid' argument to 'process_id'.
632
633         * Scripts/webkitpy/port/leakdetector.py:
634         (LeakDetector._parse_leaks_output):
635         - Return early if there is no leaks_output.
636         (LeakDetector.check_for_leaks):
637         - Rename redundant 'process_pid' argument to 'process_id'.
638
639         * Scripts/webkitpy/port/server_process.py:
640         (ServerProcess.__init__):
641         (ServerProcess.child_processes):
642         (ServerProcess.set_child_processes):
643         - Add instance variable to Port to store list of child process
644           names and process IDs returned from WebKitTestRunner.
645         (ServerProcess._start):
646         - Clear self._child_processes.
647         (ServerProcess.stop):
648         - If self._child_processes is set, call
649           self._port.check_for_leaks() for each child process.
650
651         * Scripts/webkitpy/port/server_process_unittest.py:
652         (TrivialMockPort.check_for_leaks):
653         - Rename redundant 'process_pid' argument to 'process_id'.
654
655         * Scripts/webkitpy/port/simulator_process.py:
656         (SimulatorProcess.stop):
657         - If self._child_processes is set, call
658           self._port.check_for_leaks() for each child process.
659
660         * Scripts/webkitpy/port/watch_device.py:
661         (WatchDevicePort.check_for_leaks):
662         - Rename redundant 'process_pid' argument to 'process_id'.
663
664         * WebKitTestRunner/TestController.cpp:
665         (WTR::TestController::dumpResponse):
666         - Extract method from findAndDumpWorldLeaks() so that it may be
667           reused by findAndDumpWebKitProcessIdentifiers().
668         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
669         - Add method to output process name and process ID of both the
670           WebContent and Networking processes.
671         (WTR::TestController::findAndDumpWorldLeaks):
672         - Fix missing newline in output when there were no abandoned
673           documents.
674         - Call dumpResponse() for extracted code.
675         (WTR::TestController::handleControlCommand):
676         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
677         - Use strncmp() instead of strcmp().
678         - Call findAndDumpWebKitProcessIdentifiers() when
679           "#LIST CHILD PROCESSES" command is sent.
680         * WebKitTestRunner/TestController.h:
681         (WTR::TestController::dumpResponse):
682         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
683         - Declare methods.
684
685 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
686
687         Unreviewed. Add GLib API test cases after r243434.
688
689         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
690         (testWebViewActiveURI):
691         (serverCallback):
692         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
693         (sendRequestCallback):
694
695 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
696
697         Geolocation request not complete when watch request was started in a different web process
698         https://bugs.webkit.org/show_bug.cgi?id=195996
699
700         Reviewed by Alex Christensen.
701
702         Add a test case.
703
704         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
705         (TestWebKitAPI::runJavaScriptAlert):
706         (TestWebKitAPI::TEST):
707
708 2019-03-26  Keith Rollin  <krollin@apple.com>
709
710         Update the way generate-xcfilelists returns strings from functions
711         https://bugs.webkit.org/show_bug.cgi?id=195975
712         <rdar://problem/49040807>
713
714         Reviewed by Dean Jackson.
715
716         There are places where generate-xcfilelists executes assignments with
717         statements like:
718
719             FOO=$(some_function)
720
721         where "some_function" return a string by echoing it. E.g.
722
723             some_function()
724             {
725                 echo "Hello, World"
726             }
727
728         This is a common idiom, but it has a problem if "some_function" needs
729         to call "exit" in an attempt to halt the entire script right then and
730         there. Since "some_function" is called inside of $(), it's being
731         executed in a sub-shell. Calling exit in that sub-shell simply exits
732         that shell; it doesn't not exit the outer shell in which the main part
733         of the script is still running. As such, the main script keeps
734         executing when the intent was for the script to halt.
735
736         The solution to this is to use a different idiom for returning
737         strings. The one we now is to pass in the name of the variable to
738         receive the string result:
739
740             some_function()
741             {
742                 variable_name=$1
743                 eval $variable_name ="Hello, World"
744             }
745
746         The call site now looks like
747
748             some_function FOO
749
750         Because there's no invocation of a sub-shell, some_function can now
751         call "exit" if it wants to, and the entire script will exit at that
752         point.
753
754         * Scripts/generate-xcfilelists:
755
756 2019-03-26  Chris Dumez  <cdumez@apple.com>
757
758         Add basic layout test coverage for File Picker on iOS
759         https://bugs.webkit.org/show_bug.cgi?id=196265
760
761         Reviewed by Wenson Hsieh.
762
763         Add layout test infrastructure to test the file picker on iOS.
764
765         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
766         (WTR::UIScriptController::dismissFilePicker):
767         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
768         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
769         (WTR::UIScriptController::dismissFilePicker):
770         * TestRunnerShared/UIScriptContext/UIScriptController.h:
771         * WebKitTestRunner/TestController.cpp:
772         (WTR::TestController::createWebViewWithOptions):
773         (WTR::updateTestOptionsFromTestHeader):
774         * WebKitTestRunner/TestOptions.h:
775         (WTR::TestOptions::hasSameInitializationOptions const):
776         * WebKitTestRunner/ios/TestControllerIOS.mm:
777         (overridePresentViewController):
778         (WTR::TestController::platformInitialize):
779         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
780         (WTR::UIScriptController::dismissFilePicker):
781
782 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
783
784         Implement async paste method on UIWKInteractionViewProtocol
785         https://bugs.webkit.org/show_bug.cgi?id=196267
786         <rdar://problem/49236346>
787
788         Reviewed by Tim Horton.
789
790         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
791         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
792         are now a part of all iOS 12 internal SDKs.
793
794         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
795
796         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
797         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
798
799         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
800         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
801         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
802         * TestWebKitAPI/ios/UIKitSPI.h:
803
804 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
805
806         [ews-build] Use PostgreSQL for ews.webkit.org database
807         https://bugs.webkit.org/show_bug.cgi?id=196270
808
809         Reviewed by Lucas Forschler.
810
811         * BuildSlaveSupport/ews-app/ews-app/settings.py:
812
813 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
814
815         [ews] Reset simctl states on reboot
816         https://bugs.webkit.org/show_bug.cgi?id=196260
817
818         Rubber-stamped by Aakash Jain.
819
820         * EWSTools/start-queue-mac.sh:
821
822 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
823
824         [ews-build] Use PostgreSQL for ews-build database
825         https://bugs.webkit.org/show_bug.cgi?id=196229
826
827         Reviewed by Lucas Forschler.
828
829         * BuildSlaveSupport/ews-build/master.cfg:
830
831 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
832
833         [ews-build] Get master_hostname dynamically in master.cfg
834         https://bugs.webkit.org/show_bug.cgi?id=196255
835
836         Reviewed by Lucas Forschler.
837
838         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
839         send events data in test mode.
840
841 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
842
843         [ews-app] Set db_constraint to False for Foreign Keys
844         https://bugs.webkit.org/show_bug.cgi?id=196252
845
846         Reviewed by Lucas Forschler.
847
848         * BuildSlaveSupport/ews-app/ews/models/build.py:
849         * BuildSlaveSupport/ews-app/ews/models/step.py:
850
851 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
852
853         [ews-build] is_test_mode_enabled should default to True
854         https://bugs.webkit.org/show_bug.cgi?id=196248
855
856         Reviewed by Lucas Forschler.
857
858         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
859
860 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
861
862         [ews-app] Add webkitperl to ENABLED_QUEUES
863         https://bugs.webkit.org/show_bug.cgi?id=196253
864
865         Reviewed by Lucas Forschler.
866
867         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
868
869 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
870
871         Address NSWindow sometimes using WebKitTestRunnerEvent too early
872         https://bugs.webkit.org/show_bug.cgi?id=196211
873         rdar://problem/49110552
874
875         Reviewed by Tim Horton.
876
877         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
878         Make sure that EventSenderProxy always exists when running tests. We used to create
879         it when resetting before the first test, which is a bit too late.
880
881         * WebKitTestRunner/TestController.h:
882         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
883         (WTR::TestController::platformCreateWebView):
884         (WTR::TestController::platformCreateOtherPage):
885         (WTR::TestController::finishCreatingPlatformWebView):
886         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
887         (WTR::PlatformWebView::PlatformWebView):
888         Moved some code that made NSWindow use NSEvent during web view creation. We may
889         need to move more if some other case us found, but this is enough for now.
890
891 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
892
893         Unreviewed. Fix typo in GLib geolocation API after r243285.
894
895         gelocation -> geolocation.
896
897         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
898         (testGeolocationManagerWatchPosition):
899
900 2019-03-25  Alex Christensen  <achristensen@webkit.org>
901
902         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
903         https://bugs.webkit.org/show_bug.cgi?id=196213
904
905         Reviewed by Geoff Garen.
906
907         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
908         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
909         (credentialWithIdentityAndKeychainPath):
910         (-[ChallengeDelegate webView:didFinishNavigation:]):
911         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
912         (TestWebKitAPI::TEST):
913
914 2019-03-25  Alex Christensen  <achristensen@webkit.org>
915
916         Expected shouldn't assume its contained types are copyable
917         https://bugs.webkit.org/show_bug.cgi?id=195986
918
919         Reviewed by JF Bastien.
920
921         * TestWebKitAPI/Tests/WTF/Expected.cpp:
922         (TestWebKitAPI::NonCopyable::operator== const):
923         (TestWebKitAPI::NonCopyable::operator!= const):
924         (TestWebKitAPI::TEST):
925
926 2019-03-25  Tim Horton  <timothy_horton@apple.com>
927
928         Remove some now-unnecessary dynamic class lookup
929         https://bugs.webkit.org/show_bug.cgi?id=196237
930
931         Reviewed by Simon Fraser.
932
933         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
934         (makeRequest):
935         (TEST):
936
937 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
938
939         Unreviewed, rolling out r243450.
940
941         AppleWin and WinCairo port builds get broken.
942
943         Reverted changeset:
944
945         "Add test for fix of #196095"
946         https://bugs.webkit.org/show_bug.cgi?id=196097
947         https://trac.webkit.org/changeset/243450
948
949 2019-03-25  Commit Queue  <commit-queue@webkit.org>
950
951         Unreviewed, rolling out r243465.
952         https://bugs.webkit.org/show_bug.cgi?id=196226
953
954         the test doesn't build (Requested by thorton on #webkit).
955
956         Reverted changeset:
957
958         "Do not terminate the NetworkProcess if a third party
959         application sends a NSCredential with a SecIdentityRef"
960         https://bugs.webkit.org/show_bug.cgi?id=196213
961         https://trac.webkit.org/changeset/243465
962
963 2019-03-25  Alex Christensen  <achristensen@webkit.org>
964
965         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
966         https://bugs.webkit.org/show_bug.cgi?id=196213
967
968         Reviewed by Geoff Garen.
969
970         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
971         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
972         (credentialWithIdentityAndKeychainPath):
973         (-[ChallengeDelegate webView:didFinishNavigation:]):
974         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
975         (TestWebKitAPI::TEST):
976
977 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
978
979         [ews-build] Gracefully handle missing patch_id in events
980         https://bugs.webkit.org/show_bug.cgi?id=196216
981
982         Reviewed by Lucas Forschler.
983
984         * BuildSlaveSupport/ews-build/events.py:
985
986 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
987
988         [ews-build] use lz4 compression for improving buildbot performance
989         https://bugs.webkit.org/show_bug.cgi?id=196155
990
991         Reviewed by Lucas Forschler.
992
993         * BuildSlaveSupport/ews-build/master.cfg:
994
995 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
996
997         Pull some API testing helper methods out of TestWKWebView
998         https://bugs.webkit.org/show_bug.cgi?id=196212
999
1000         Reviewed by Tim Horton.
1001
1002         Refactor some more API testing utility methods, so that they can be used in
1003         tests that do not use TestWKWebView.
1004
1005         * TestWebKitAPI/cocoa/TestWKWebView.h:
1006         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1007         (-[WKWebView loadTestPageNamed:]):
1008         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1009         (-[WKWebView synchronouslyLoadHTMLString:]):
1010         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1011         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1012         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1013         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1014         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1015
1016 2019-03-25  Jer Noble  <jer.noble@apple.com>
1017
1018         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1019         https://bugs.webkit.org/show_bug.cgi?id=196097
1020
1021         Reviewed by Eric Carlson.
1022
1023         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1024
1025         * DumpRenderTree/mac/DumpRenderTree.mm:
1026         (resetWebPreferencesToConsistentValues):
1027         * WebKitTestRunner/TestController.cpp:
1028         (WTR::TestController::resetPreferencesToConsistentValues):
1029
1030 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1031
1032         Pull IPadUserInterfaceSwizzler out into a separate header file
1033         https://bugs.webkit.org/show_bug.cgi?id=196193
1034
1035         Reviewed by Anders Carlsson.
1036
1037         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1038         be used in other API tests.
1039
1040         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1041         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1042         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1043         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1044         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1045         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1046         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1047
1048 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1049
1050         Remove NavigatorContentUtils in WebCore/Modules
1051         https://bugs.webkit.org/show_bug.cgi?id=196070
1052
1053         Reviewed by Alex Christensen.
1054
1055         NavigatorContentUtils was to support the custom scheme spec [1].
1056         However, in WebKit side, no port has supported the feature in
1057         WebKit layer after EFL port was removed. So there has been the
1058         only IDL implementation of the NavigatorContentUtils in WebCore.
1059         So we don't need to keep the implementation in WebCore anymore.
1060
1061         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1062
1063         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1064
1065 2019-03-24  Andy Estes  <aestes@apple.com>
1066
1067         [watchOS] Remove unused Proximity Networking code
1068         https://bugs.webkit.org/show_bug.cgi?id=196188
1069
1070         Reviewed by Tim Horton.
1071
1072         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1073         (TEST):
1074
1075 2019-03-23  Keith Miller  <keith_miller@apple.com>
1076
1077         Refactor clz/ctz and fix getLSBSet.
1078         https://bugs.webkit.org/show_bug.cgi?id=196162
1079
1080         Reviewed by Saam Barati.
1081
1082         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1083
1084         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1085         (TestWebKitAPI::TEST):
1086
1087 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1088
1089         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1090         https://bugs.webkit.org/show_bug.cgi?id=196143
1091
1092         Reviewed by Michael Catanzaro.
1093
1094         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1095         directories.
1096
1097         * Scripts/webkitpy/style/checkers/cpp.py:
1098         (check_identifier_name_in_declaration):
1099         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1100         (WebKitStyleTest.test_names):
1101
1102 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1103
1104         [Flatpak] Manifest expanding fails for qt WPE extension
1105         https://bugs.webkit.org/show_bug.cgi?id=196148
1106
1107         Reviewed by Alex Christensen.
1108
1109         * flatpak/flatpakutils.py:
1110         (expand_submodules_recurse): The last recurse manifest expand
1111         iteration might lead to a single module so take it into account
1112         and don't try to recurse further.
1113
1114 2019-03-22  Chris Dumez  <cdumez@apple.com>
1115
1116         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1117         https://bugs.webkit.org/show_bug.cgi?id=195348
1118         <rdar://problem/48622090>
1119
1120         Reviewed by Alex Christensen.
1121
1122         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1123         to NO when test.options().shouldIgnoreMetaViewport is false.
1124
1125         * WebKitTestRunner/ios/TestControllerIOS.mm:
1126         (WTR::TestController::platformConfigureViewForTest):
1127
1128 2019-03-22  Chris Dumez  <cdumez@apple.com>
1129
1130         Prewarmed processes should be usable with any website data store
1131         https://bugs.webkit.org/show_bug.cgi?id=196104
1132
1133         Reviewed by Alex Christensen.
1134
1135         Add API test coverage.
1136
1137         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1138         (runInitialWarmedProcessUsedTest):
1139         (TEST):
1140
1141 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1142
1143         Back out local changes to Alex's Subversion working directory
1144
1145         They were accidentally committed.
1146
1147         * Scripts/webkitpy/common/system/abstractexecutive.py:
1148         (AbstractExecutive.wait_newest):
1149         * Scripts/webkitpy/common/system/executive.py:
1150         (Executive.running_pids):
1151         * Scripts/webkitpy/common/system/executive_mock.py:
1152         (MockExecutive.running_pids):
1153         * Scripts/webkitpy/common/system/executive_unittest.py:
1154         (ExecutiveTest.serial_test_running_pids):
1155         * Scripts/webkitpy/port/darwin.py:
1156         (DarwinPort.check_for_leaks):
1157         * Scripts/webkitpy/port/leakdetector.py:
1158         (LeakDetector.check_for_leaks):
1159         - This was the hack attached to Bug 193772.
1160
1161         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1162         (+[WebKitTestRunnerEvent mouseLocation]):
1163         - This works around a crash on an internal build.
1164
1165 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1166
1167         Fix the build after r243354
1168         https://bugs.webkit.org/show_bug.cgi?id=196138
1169         <rdar://problem/49145951>
1170
1171         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1172         (TEST):
1173         * TestWebKitAPI/ios/UIKitSPI.h:
1174
1175 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1176
1177         Adopt UIWKDocumentContext
1178         https://bugs.webkit.org/show_bug.cgi?id=196040
1179         <rdar://problem/48642440>
1180
1181         Reviewed by Ryosuke Niwa.
1182
1183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1184         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1185         (makeRequest):
1186         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1187         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1188         (applyStyle):
1189         (TEST):
1190         Add tests for UIWKDocumentContext.
1191
1192         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1193         (TEST):
1194         (recursiveFindWKContentView): Deleted.
1195         * TestWebKitAPI/cocoa/TestWKWebView.h:
1196         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1197         (recursiveFindWKContentView):
1198         (-[TestWKWebView wkContentView]):
1199         * TestWebKitAPI/ios/UIKitSPI.h:
1200         Share the WKContentView finding code between tests.
1201
1202 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1203
1204         [iOS WK2] Turn on async overflow scrolling by default
1205         https://bugs.webkit.org/show_bug.cgi?id=196011
1206         rdar://problem/48453859
1207
1208         Reviewed by Antti Koivisto.
1209         
1210         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1211         since so many basic layout tests have different results when compositing is triggered for
1212         overflow.
1213         
1214         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1215
1216         * WebKitTestRunner/TestController.cpp:
1217         (WTR::TestController::resetPreferencesToConsistentValues):
1218
1219 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1220
1221         [ews-build] Retry API test in case of failures
1222         https://bugs.webkit.org/show_bug.cgi?id=196004
1223
1224         Reviewed by Lucas Forschler.
1225
1226         * BuildSlaveSupport/ews-build/steps.py:
1227         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1228         (CompileWebKitToT.doStepIf): Ditto.
1229         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1230         (ReRunAPITests): Re-run API tests.
1231         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1232         (RunAPITestsWithoutPatch): Run API tests without patch.
1233         (RunAPITestsWithoutPatch.doStepIf):
1234         (RunAPITestsWithoutPatch.hideStepIf):
1235         (RunAPITestsWithoutPatch.evaluateCommand):
1236         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1237         (AnalyzeAPITestsResults.start):
1238         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1239         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1240         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1241         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1242
1243 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1244
1245         [ews-build] Update queues configurations
1246         https://bugs.webkit.org/show_bug.cgi?id=196074
1247
1248         Reviewed by Dewei Zhu.
1249
1250         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1251         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1252
1253 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1254
1255         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1256         https://bugs.webkit.org/show_bug.cgi?id=195680
1257         <rdar://problem/48903534>
1258
1259         Unreviewed infrastructure fix.
1260
1261         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1262         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1263
1264 2019-03-21  Andy Estes  <aestes@apple.com>
1265
1266         [iOS] Apple Pay should be available in documents with no user agent scripts
1267         https://bugs.webkit.org/show_bug.cgi?id=196061
1268         <rdar://problem/48649391>
1269
1270         Reviewed by Brady Eidson.
1271
1272         Added API tests and related infrastructure.
1273
1274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1275         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1276         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1277         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1278         (TestWebKitAPI::TEST):
1279         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1280         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1281         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1282         * TestWebKitAPI/cocoa/TestProtocol.mm:
1283         (-[TestProtocol startLoading]):
1284         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1285         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1286         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1287         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1288
1289 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1290
1291         REGRESSSION (r243297): webkitpy tests broken
1292         https://bugs.webkit.org/show_bug.cgi?id=196108
1293
1294         Reviewed by Aakash Jain.
1295
1296         r243297 updated contributors.json, which broke a few unit tests.
1297
1298         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1299         (IRCCommandTest.test_whois):
1300         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1301
1302 2019-03-21  Chris Dumez  <cdumez@apple.com>
1303
1304         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1305         https://bugs.webkit.org/show_bug.cgi?id=196041
1306         <rdar://problem/49083230>
1307
1308         Reviewed by Alex Christensen.
1309
1310         Add API test coverage.
1311
1312         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1313         (TEST):
1314
1315 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1316
1317         Add SPI to inform applications of WKContentRuleList actions
1318         https://bugs.webkit.org/show_bug.cgi?id=195965
1319         <rdar://problem/42664365>
1320
1321         Reviewed by Geoff Garen.
1322
1323         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1324         (TestWebKitAPI::allActionsForResourceLoad):
1325         (TestWebKitAPI::testRequest):
1326         (TestWebKitAPI::TEST_F):
1327         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1328         (Notification::description):
1329         (Notification::operator== const):
1330         (toVector):
1331         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1332         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1333         (makeContentRuleList):
1334         (TEST):
1335         (makeWarnContentRuleList): Deleted.
1336
1337 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1338
1339         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1340         https://bugs.webkit.org/show_bug.cgi?id=196088
1341
1342         Reviewed by Brian Burg.
1343
1344         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1345         Support checks when only one platform is specified. Also deprecate macosx() and
1346         force the use of macos() instead.
1347
1348         * Scripts/webkitpy/style/checkers/cpp.py:
1349         (check_min_versions_of_wk_api_available):
1350         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1351         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1352
1353 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1354
1355         Update status inactive committers' status to 'contributor'.
1356
1357         * Scripts/webkitpy/common/config/contributors.json:
1358
1359 2019-03-21  Xan Lopez  <xan@igalia.com>
1360
1361         [JSC][x86] Drop support for x87 floating point
1362         https://bugs.webkit.org/show_bug.cgi?id=194853
1363
1364         Reviewed by Don Olmstead.
1365
1366         Force SSE2 on x86/32bit builds.
1367
1368         * Scripts/webkitdirs.pm:
1369         (generateBuildSystemFromCMakeProject):
1370
1371 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1372
1373         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1374         https://bugs.webkit.org/show_bug.cgi?id=196073
1375
1376         Reviewed by Michael Catanzaro.
1377
1378         Add test cases to check functions and constructors with no arguments but receiving user data.
1379
1380         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1381         (checkUserData):
1382         (testJSCFunction):
1383         (fooCreateWithUserData):
1384         (testJSCClass):
1385
1386 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1387
1388         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1389
1390         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1391
1392         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1393
1394 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1395
1396         [GTK][WPE] Add API to provide geolocation information
1397         https://bugs.webkit.org/show_bug.cgi?id=195940
1398
1399         Reviewed by Michael Catanzaro.
1400
1401         Add a new test to check the new API.
1402
1403         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1404         (testGeolocationManagerCurrentPosition):
1405         (testGeolocationManagerWatchPosition):
1406         (beforeAll):
1407         (afterAll):
1408         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1409         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1410         (beforeAll): Ditto.
1411         * TestWebKitAPI/glib/CMakeLists.txt:
1412
1413 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1414
1415         [GLib] Returning G_TYPE_OBJECT from a method does not work
1416         https://bugs.webkit.org/show_bug.cgi?id=195574
1417
1418         Reviewed by Michael Catanzaro.
1419
1420         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1421
1422         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1423         (getGFile):
1424         (getParent):
1425         (createGString):
1426         (getGString):
1427         (getGStringCopyWillRaise):
1428         (getGStringCopy):
1429         (getGStringStr):
1430         (getGStringLen):
1431         (freeGString):
1432         (testJSCClass):
1433
1434 2019-03-20  Saam Barati  <sbarati@apple.com>
1435
1436         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1437         https://bugs.webkit.org/show_bug.cgi?id=195721
1438
1439         Reviewed by Filip Pizlo.
1440
1441         * Scripts/run-javascriptcore-tests:
1442
1443 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1444
1445         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1446         https://bugs.webkit.org/show_bug.cgi?id=196049
1447
1448         Reviewed by Tim Horton.
1449
1450         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1451         overflow scrolling in general, so rename it.
1452
1453         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1454
1455 2019-03-20  Daniel Bates  <dabates@apple.com>
1456
1457         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1458         https://bugs.webkit.org/show_bug.cgi?id=196031
1459         <rdar://problem/49078172>
1460
1461         Reviewed by Tim Horton.
1462
1463         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1464         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1465         same code path used when the Done button is pressed to dismiss the <select> picker.
1466
1467         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1468         (TestWebKitAPI::TEST):
1469
1470 2019-03-20  Chris Dumez  <cdumez@apple.com>
1471
1472         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1473         https://bugs.webkit.org/show_bug.cgi?id=196029
1474         <rdar://problem/48954651>
1475
1476         Reviewed by Tim Horton.
1477
1478         Add API test coverage.
1479
1480         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1481
1482 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1483
1484         [ews-build] Improve failure summary string for ApplyPatch step
1485         https://bugs.webkit.org/show_bug.cgi?id=195995
1486
1487         Reviewed by Alexey Proskuryakov.
1488
1489         * BuildSlaveSupport/ews-build/steps.py:
1490         (ApplyPatch.getResultSummary): Override getResultSummary.
1491
1492 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1493
1494         AX: Implement support for new meter ARIA role
1495         https://bugs.webkit.org/show_bug.cgi?id=195966
1496
1497         Reviewed by Chris Fleizach.
1498
1499         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1500         to AXLevelIndicator.
1501
1502         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1503
1504 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1505
1506         [WebAuthN] Implement FIDO AppID extension
1507         https://bugs.webkit.org/show_bug.cgi?id=143491
1508         <rdar://problem/48298273>
1509
1510         Reviewed by Brent Fulgham.
1511
1512         Add a test that covers the new flag of convertToU2fSignCommand.
1513
1514         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1515         (TestWebKitAPI::TEST):
1516         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1517         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1518         (TestWebKitAPI::TEST):
1519
1520 2019-03-19  Keith Rollin  <krollin@apple.com>
1521
1522         Add support for more platforms to generate-xcfilelists
1523         https://bugs.webkit.org/show_bug.cgi?id=195977
1524
1525         Reviewed by Alexey Proskuryakov.
1526
1527         generate-xcfilelists incorrectly complains when involved with building
1528         WebKit for iphonesimulator:
1529
1530             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1531             …
1532             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1533
1534         Address this by teaching generate-xcfilelists about more platforms.
1535
1536         * Scripts/generate-xcfilelists:
1537
1538 2019-03-19  John Wilander  <wilander@apple.com>
1539
1540         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1541         https://bugs.webkit.org/show_bug.cgi?id=195923
1542         <rdar://problem/49001272>
1543
1544         Reviewed by Alex Christensen.
1545
1546         This patch does the following to the TestRunner:
1547         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1548         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1549         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1550
1551         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1552         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1553         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1554         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1555         * WebKitTestRunner/TestController.cpp:
1556         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1557         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1558         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1559         * WebKitTestRunner/TestController.h:
1560         * WebKitTestRunner/TestInvocation.cpp:
1561         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1562
1563 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1564
1565         [CMake] Support more clang and gcc sanitizers
1566         https://bugs.webkit.org/show_bug.cgi?id=195956
1567
1568         Reviewed by Michael Catanzaro.
1569
1570         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1571
1572 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1573
1574         [ews-build] Improve summary for PrintConfiguration step
1575         https://bugs.webkit.org/show_bug.cgi?id=195945
1576
1577         Reviewed by Lucas Forschler.
1578
1579         * BuildSlaveSupport/ews-build/steps.py:
1580         (PrintConfiguration.getResultSummary): Override getResultSummary.
1581
1582 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1583
1584         [ews-build] Improve summary for CheckOutSource step
1585         https://bugs.webkit.org/show_bug.cgi?id=195963
1586
1587         Reviewed by Lucas Forschler.
1588
1589         * BuildSlaveSupport/ews-build/steps.py:
1590         (CheckOutSource.getResultSummary):
1591
1592 2019-03-19  Daniel Bates  <dabates@apple.com>
1593
1594         [iOS] Focus not preserved when switching between tabs
1595         https://bugs.webkit.org/show_bug.cgi?id=195820
1596         <rdar://problem/43614450>
1597
1598         Reviewed by Brent Fulgham.
1599
1600         Add tests to ensure that we restore focus when resigning and becoming first responder.
1601
1602         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1603         (TestWebKitAPI::TEST):
1604
1605 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1606
1607         Make WTFLogChannelState and WTFLogLevel enum classes
1608         https://bugs.webkit.org/show_bug.cgi?id=195904
1609
1610         Reviewed by Eric Carlson.
1611
1612         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1613         (TestWebKitAPI::TEST_F):
1614
1615 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1616
1617         [GStreamer][EME] Backported mssdemux protection data crash fix
1618         https://bugs.webkit.org/show_bug.cgi?id=195918
1619
1620         Reviewed by Philippe Normand.
1621
1622         * gstreamer/jhbuild.modules:
1623         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1624
1625 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1626
1627         Unreviewed, rolling out r243132.
1628
1629         Broke GTK build
1630
1631         Reverted changeset:
1632
1633         "Make WTFLogChannelState and WTFLogLevel enum classes"
1634         https://bugs.webkit.org/show_bug.cgi?id=195904
1635         https://trac.webkit.org/changeset/243132
1636
1637 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1638
1639         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1640
1641         * Scripts/webkitdirs.pm:
1642         (builtDylibPathForName): Adjust the shared library name that's changed
1643         with the API version bump in r243073.
1644
1645 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1646
1647         Make WTFLogChannelState and WTFLogLevel enum classes
1648         https://bugs.webkit.org/show_bug.cgi?id=195904
1649
1650         Reviewed by Eric Carlson.
1651
1652         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1653         (TestWebKitAPI::TEST_F):
1654
1655 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1656
1657         Disable flaky test added in r2431100
1658         https://webkit.org/b/195785
1659
1660         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1661         (TestWebKitAPI::TEST):
1662         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1663
1664 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1665
1666         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1667         https://bugs.webkit.org/show_bug.cgi?id=195916
1668
1669         Reviewed by Tim Horton.
1670
1671         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1672         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1673
1674 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1675
1676         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1677
1678         * Scripts/webkitpy/common/config/contributors.json:
1679
1680 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1681
1682         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1683         https://bugs.webkit.org/show_bug.cgi?id=195785
1684
1685         Reviewed by Geoffrey Garen.
1686
1687         * TestWebKitAPI/TCPServer.cpp: Added.
1688         (TestWebKitAPI::TCPServer::TCPServer):
1689         (TestWebKitAPI::TCPServer::~TCPServer):
1690         (TestWebKitAPI::TCPServer::socketBindListen):
1691         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1692         * TestWebKitAPI/TCPServer.h: Added.
1693         (TestWebKitAPI::TCPServer::port const):
1694         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1695         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1696         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1697         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1698         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1699         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1700         (TestWebKitAPI::respondSlowly):
1701         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1702         (TestWebKitAPI::downloadAtRate):
1703         (TestWebKitAPI::TEST):
1704
1705 2019-03-18  Saam Barati  <sbarati@apple.com>
1706
1707         Add a plan file for JetStream 2
1708         https://bugs.webkit.org/show_bug.cgi?id=190734
1709
1710         Reviewed by Mark Lam.
1711
1712         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1713
1714 2019-03-18  Chris Dumez  <cdumez@apple.com>
1715
1716         Delay WebProcess launch until a load is triggered in a Web view
1717         https://bugs.webkit.org/show_bug.cgi?id=195758
1718         <rdar://problem/48126013>
1719
1720         Reviewed by Geoff Garen.
1721
1722         Add API test coverage. Also update some existing API tests to not expect
1723         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1724
1725         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1726         (TestWebKitAPI::TEST):
1727         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1728         (TestWebKitAPI::TEST):
1729         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1730         (TEST):
1731         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1732         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1733         (TEST):
1734         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1735         (TEST):
1736         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1737
1738 2019-03-18  Xan Lopez  <xan@igalia.com>
1739
1740         [CMake] Prevent potential warning when determining $architecture
1741         https://bugs.webkit.org/show_bug.cgi?id=195891
1742
1743         Reviewed by Michael Catanzaro.
1744
1745         It's possible for generateBuildSystemForCMakeProject to be called
1746         before determineArchitecture() is ever called. This will make the
1747         first eq check with $architecture to be bogus (and print a
1748         warning). Change that to an eq check with architecture(), which
1749         implicitly calls determineArchitecture() if needed, and change all
1750         the other similar cases in the method in the same way to prevent
1751         future bugs like this one.
1752
1753         * Scripts/webkitdirs.pm:
1754         (generateBuildSystemFromCMakeProject):
1755
1756 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1757
1758         [WPE] Tarballs generated with “make dist” cannot build documentation
1759         https://bugs.webkit.org/show_bug.cgi?id=195885
1760
1761         Reviewed by Carlos Garcia Campos.
1762
1763         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1764
1765 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1766
1767         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1768         https://bugs.webkit.org/show_bug.cgi?id=195883
1769
1770         Reviewed by Carlos Garcia Campos.
1771
1772         * gtkdoc/gtkdoc.py:
1773         (GTKDoc._run_command): When commands fail to run, include the full command line for
1774         the program invocation and the output it has generated on the standard error stream.
1775
1776 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1777
1778         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1779         https://bugs.webkit.org/show_bug.cgi?id=195786
1780
1781         Reviewed by Philippe Normand.
1782
1783         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1784         * wpe/jhbuild.modules: Ditto.
1785
1786 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1787
1788         [ews-build] Don't run clean builds on EWS builders
1789         https://bugs.webkit.org/show_bug.cgi?id=195851
1790
1791         Reviewed by Geoffrey Garen.
1792
1793         * BuildSlaveSupport/ews-build/factories.py:
1794
1795 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1796
1797         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1798         https://bugs.webkit.org/show_bug.cgi?id=195849
1799
1800         Reviewed by Chris Dumez.
1801
1802         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1803
1804         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1805         (runWebsiteDataStoreCustomPaths):
1806
1807 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1808
1809         webkitpy: Upload test results
1810         https://bugs.webkit.org/show_bug.cgi?id=195755
1811         <rdar://problem/48896182>
1812
1813         Reviewed by Aakash Jain.
1814
1815         Establish a new format for uploading results that is not tied to layout tests, apply
1816         that format to webkitpy tests.
1817
1818         * Scripts/webkitpy/common/checkout/scm/git.py:
1819         (Git.native_branch): Return what branch the current checkout is on.
1820         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1821         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1822         * Scripts/webkitpy/common/checkout/scm/svn.py:
1823         (SVN.native_branch): Ditto.
1824         * Scripts/webkitpy/common/system/platforminfo.py:
1825         (PlatformInfo.build_version): Return a build version for Mac.
1826         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1827         (MockPlatformInfo.__init__):
1828         (MockPlatformInfo.build_version):
1829         * Scripts/webkitpy/results: Added.
1830         * Scripts/webkitpy/results/__init__.py: Added.
1831         * Scripts/webkitpy/results/options.py: Added.
1832         (upload_options): OptParse list for upload options.
1833         * Scripts/webkitpy/results/upload.py: Added.
1834         (Upload): Class which enforces the upload format expected by the results server.
1835         (Upload.Expectations):
1836         (Upload.create_configuration):
1837         (Upload.create_commit):
1838         (Upload.create_details):
1839         (Upload.create_run_stats):
1840         (Upload.create_test_result):
1841         (Upload.__init__):
1842         (Upload.Encoder): Encode Upload object as json.
1843         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1844         * Scripts/webkitpy/results/upload_unittest.py: Added.
1845         * Scripts/webkitpy/test/main.py:
1846         (Tester._parse_args): Add upload arguments.
1847         (Tester._run_tests): Allow results to be uploaded.
1848         * Scripts/webkitpy/test/runner.py:
1849         (Runner.__init__): Record which tests were run, rather than just counting them.
1850         (Runner.handle):
1851         * Scripts/webkitpy/test/runner_unittest.py:
1852         (RunnerTest.test_run):
1853         * Scripts/webkitpy/thirdparty/__init__.py:
1854         (AutoinstallImportHook.find_module): Add requests auto-install.
1855         (AutoinstallImportHook._install_requests):
1856         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1857         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1858
1859 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1860
1861         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1862         https://bugs.webkit.org/show_bug.cgi?id=195810
1863
1864         Reviewed by Tim Horton.
1865
1866         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1867         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1868         ending certain layout tests.
1869
1870         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1871         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1872         (-[TestRunnerWKWebView dealloc]):
1873         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1874
1875         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1876         helper method when destroying the web view, and when resetting state between tests.
1877
1878         * WebKitTestRunner/ios/TestControllerIOS.mm:
1879         (WTR::TestController::platformResetStateToConsistentValues):
1880
1881         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1882
1883 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1884
1885         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1886         https://bugs.webkit.org/show_bug.cgi?id=190350
1887         <rdar://problem/45089503>
1888
1889         Reviewed by Geoffrey Garen.
1890
1891         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1892         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1893         (TEST):
1894         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1895         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1896         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1897         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1898         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1899         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1900         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1901         (runTest):
1902         (createDirectories):
1903         (TEST):
1904         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1905         (TEST):
1906         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1907         (TEST):
1908
1909 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1910
1911         Add support to WebPage for getting the contents as an attributed string.
1912         https://bugs.webkit.org/show_bug.cgi?id=195636
1913         rdar://problem/45055697
1914
1915         Reviewed by Tim Horton.
1916
1917         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1918         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1919
1920 2019-03-15  Chris Dumez  <cdumez@apple.com>
1921
1922         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1923         https://bugs.webkit.org/show_bug.cgi?id=195747
1924
1925         Reviewed by Geoff Garen.
1926
1927         Add API test coverage.
1928
1929         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1930
1931 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1932
1933         Unreviewed, rolling out r242952.
1934
1935         Causing API failures on iOS Simulator
1936
1937         Reverted changeset:
1938
1939         "[PSON] Make sure the WebProcessCache is leverage when
1940         relaunching a process after termination"
1941         https://bugs.webkit.org/show_bug.cgi?id=195747
1942         https://trac.webkit.org/changeset/242952
1943
1944 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1945
1946         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1947         https://bugs.webkit.org/show_bug.cgi?id=195740
1948
1949         Reviewed by Ross Kirsling.
1950
1951         window.open doesn't work for WebKitBrowserWindow because it is not
1952         implemented yet.
1953
1954         1. Implemented createNewPage callback of WKPageUIClient.
1955         2. Changed MainWindow to take a BrowserWindow factory function
1956           instead of BrowserWindowType to be flexible to create
1957           BrowserWindow with extra settings.
1958         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1959           because it is not relevant with MainWindow anymore.
1960
1961         * MiniBrowser/win/Common.cpp:
1962         (parseCommandLine):
1963         * MiniBrowser/win/Common.h:
1964         (CommandLineOptions::CommandLineOptions):
1965         * MiniBrowser/win/MainWindow.cpp:
1966         (MainWindow::MainWindow):
1967         (MainWindow::create):
1968         (MainWindow::init):
1969         (MainWindow::WndProc):
1970         * MiniBrowser/win/MainWindow.h:
1971         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1972         (PrintWebUIDelegate::createWebViewWithRequest):
1973         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1974         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1975         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1976         (WebKitBrowserWindow::updateProxySettings):
1977         (WebKitBrowserWindow::createNewPage):
1978         * MiniBrowser/win/WebKitBrowserWindow.h:
1979         * MiniBrowser/win/WinMain.cpp:
1980         (wWinMain):
1981
1982 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1983
1984         Make it possible to test scrolling tree layer manipulation more easily
1985         https://bugs.webkit.org/show_bug.cgi?id=195780
1986
1987         Reviewed by Tim Horton.
1988         
1989         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1990         cuts off communication of scrolling tree scrolls back to the web process
1991         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1992         allows tests to trigger scrolls which run the scrolling tree layer positioning
1993         logic, but never get another commit from the web process that might mask
1994         scrolling tree bugs.
1995         
1996         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1997         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1998         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1999
2000         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2001         (WTR::UIScriptController::scrollUpdatesDisabled const):
2002         (WTR::UIScriptController::setScrollUpdatesDisabled):
2003         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2004         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2005         (WTR::UIScriptController::scrollUpdatesDisabled const):
2006         (WTR::UIScriptController::setScrollUpdatesDisabled):
2007         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2008         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2009         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2010         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2011         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2012         * WebKitTestRunner/ios/TestControllerIOS.mm:
2013         (WTR::TestController::platformResetStateToConsistentValues):
2014         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2015         (WTR::UIScriptController::scrollUpdatesDisabled const):
2016         (WTR::UIScriptController::setScrollUpdatesDisabled):
2017
2018 2019-03-14  Youenn Fablet  <youenn@apple.com>
2019
2020         Move IDB storage in private browsing mode to NetworkProcess
2021         https://bugs.webkit.org/show_bug.cgi?id=195602
2022
2023         Reviewed by Brady Eidson.
2024
2025         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2026         (TEST):
2027
2028 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2029
2030         [ews-build] Make descriptionDone messages more readable
2031         https://bugs.webkit.org/show_bug.cgi?id=195760
2032
2033         Reviewed by Lucas Forschler.
2034
2035         * BuildSlaveSupport/ews-build/steps.py:
2036         * BuildSlaveSupport/ews-build/steps_unittest.py:
2037
2038 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2039
2040         [ews-build] Generate status-bubble hover-over messages
2041         https://bugs.webkit.org/show_bug.cgi?id=195680
2042
2043         Reviewed by Lucas Forschler.
2044
2045         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2046         (StatusBubble):
2047         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2048         on hover-over.
2049         (StatusBubble._iso_time):
2050         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2051         hover-over message.
2052         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2053
2054 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2055
2056         [ews-app] Gracefully handle the case when state_string is None
2057         https://bugs.webkit.org/show_bug.cgi?id=195753
2058
2059         Reviewed by Lucas Forschler.
2060
2061         * BuildSlaveSupport/ews-app/ews/models/build.py:
2062         * BuildSlaveSupport/ews-app/ews/models/step.py:
2063
2064 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2065
2066         [ews-app] Status bubble display pending for currently running build step
2067         https://bugs.webkit.org/show_bug.cgi?id=195744
2068
2069         Reviewed by Lucas Forschler.
2070
2071         * BuildSlaveSupport/ews-build/events.py:
2072         (Events.stepStarted): If state_string is pending, replace it with step name.
2073
2074 2019-03-14  Chris Dumez  <cdumez@apple.com>
2075
2076         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2077         https://bugs.webkit.org/show_bug.cgi?id=195750
2078
2079         Reviewed by Geoffrey Garen.
2080
2081         Add API test coverage.
2082
2083         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2084         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2085         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2086         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2087
2088 2019-03-14  Chris Dumez  <cdumez@apple.com>
2089
2090         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2091         https://bugs.webkit.org/show_bug.cgi?id=195747
2092
2093         Reviewed by Geoff Garen.
2094
2095         Add API test coverage.
2096
2097         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2098
2099 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2100
2101         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2102         https://bugs.webkit.org/show_bug.cgi?id=195725
2103         <rdar://problem/48545062>
2104
2105         Reviewed by Tim Horton.
2106
2107         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2108         handler is nil.
2109
2110         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2111         (TestWebKitAPI::TEST):
2112
2113 2019-03-13  Sam Weinig  <sam@webkit.org>
2114
2115         Add utility function to allow easy reverse range-based iteration of a container
2116         https://bugs.webkit.org/show_bug.cgi?id=195542
2117
2118         Reviewed by Antti Koivisto.
2119
2120         * TestWebKitAPI/CMakeLists.txt:
2121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2122         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2123         (TestWebKitAPI::TEST):
2124         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2125
2126 2019-03-13  Chris Dumez  <cdumez@apple.com>
2127
2128         Use a ServiceWorker process per registrable domain
2129         https://bugs.webkit.org/show_bug.cgi?id=195649
2130
2131         Reviewed by Youenn Fablet.
2132
2133         Update API test coverage.
2134
2135         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2136
2137 2019-03-13  Chris Dumez  <cdumez@apple.com>
2138
2139         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2140         https://bugs.webkit.org/show_bug.cgi?id=195684
2141         <rdar://problem/48294714>
2142
2143         Reviewed by Antti Koivisto.
2144
2145         Add API test coverage.
2146
2147         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2148
2149 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2150
2151         [ews-app] Remove unused patch view
2152         https://bugs.webkit.org/show_bug.cgi?id=195669
2153
2154         Reviewed by Lucas Forschler.
2155
2156         * BuildSlaveSupport/ews-app/ews/urls.py:
2157         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2158
2159 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2160
2161         [ews-app] Use Buildbot result code variables
2162         https://bugs.webkit.org/show_bug.cgi?id=195668
2163
2164         Reviewed by Alexey Proskuryakov.
2165
2166         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2167         (Buildbot): Added Buildbot result code variables.
2168         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2169         (StatusBubble._build_bubble): Used Buildbot result code variables.
2170
2171 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2172
2173         [Flatpak] Expand submodule recursively
2174         https://bugs.webkit.org/show_bug.cgi?id=195672
2175
2176         Building WPE with flatpak was impossible without that as it was raising an exception.
2177         Also update wpebackend-fdo to match what is built in jhbuild
2178
2179         Reviewed by Philippe Normand.
2180
2181         * flatpak/flatpakutils.py:
2182         (expand_submodules_recurse):
2183         (expand_manifest):
2184         * flatpak/org.webkit.WPEModules.yaml:
2185
2186 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2187
2188         [ews-app] status bubble should be hidden for certain builds
2189         https://bugs.webkit.org/show_bug.cgi?id=194597
2190
2191         Reviewed by Dewei Zhu.
2192
2193         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2194         (StatusBubble._build_bubble):
2195         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2196         because the patch didn't have relevant changes.
2197         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2198         in production yet.
2199
2200 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2201
2202         [Win] Fix a slew of simple clang-cl warnings.
2203         https://bugs.webkit.org/show_bug.cgi?id=195652
2204
2205         Reviewed by Don Olmstead.
2206
2207         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2208         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2209
2210 2019-03-12  Justin Fan  <justin_fan@apple.com>
2211
2212         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2213         https://bugs.webkit.org/show_bug.cgi?id=195518
2214         <rdar://problem/46322356>
2215
2216         Reviewed by Myles C. Maxfield.
2217
2218         * DumpRenderTree/DerivedSources-input.xcfilelist:
2219         * DumpRenderTree/DerivedSources-output.xcfilelist:
2220
2221 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2222
2223         Unreviewed, rolling out r242825.
2224         https://bugs.webkit.org/show_bug.cgi?id=195648
2225
2226         "Broke webkitpy tests with my change to
2227         lldb_dump_class_layout.py" (Requested by rmorisset on
2228         #webkit).
2229
2230         Reverted changeset:
2231
2232         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2233         classes with suspicious padding"
2234         https://bugs.webkit.org/show_bug.cgi?id=195573
2235         https://trac.webkit.org/changeset/242825
2236
2237 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2238
2239         [ews-build] Show status bubbles while the patch is waiting in queue
2240         https://bugs.webkit.org/show_bug.cgi?id=195618
2241
2242         Reviewed by Lucas Forschler.
2243
2244         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2245         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2246         enabled in initial deployment.
2247         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2248         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2249         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2250         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2251         (StatusBubble._build_bubbles_for_patch):
2252
2253 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2254
2255         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2256         https://bugs.webkit.org/show_bug.cgi?id=195573
2257
2258         Reviewed by Simon Fraser.
2259
2260         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2261
2262         * Scripts/dump-class-layout:
2263         (main):
2264         * lldb/lldb_dump_class_layout.py:
2265         (ClassLayout.__init__):
2266         (ClassLayout._compute_padding_recursive):
2267         (LLDBDebuggerInstance.dump_layout_for_classname):
2268         (LLDBDebuggerInstance):
2269         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2270         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2271
2272 2019-03-12  Chris Dumez  <cdumez@apple.com>
2273
2274         Device Orientation access permission should be denied unless explicitly granted by the client
2275         https://bugs.webkit.org/show_bug.cgi?id=195625
2276
2277         Reviewed by Youenn Fablet.
2278
2279         add API test coverage.
2280
2281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2282         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2283         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2284         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2285         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2286         (runDeviceOrientationTest):
2287         (TEST):
2288         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2289         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2290
2291 2019-03-12  Jer Noble  <jer.noble@apple.com>
2292
2293         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2294         https://bugs.webkit.org/show_bug.cgi?id=195137
2295         <rdar://problem/48810307>
2296
2297         Reviewed by Eric Carlson.
2298
2299         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2300         (TestWebKitAPI::TEST):
2301
2302 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2303
2304         [ews-build] Change urls from uat to production
2305         https://bugs.webkit.org/show_bug.cgi?id=195566
2306
2307         Reviewed by Lucas Forschler.
2308
2309         * BuildSlaveSupport/ews-app/ews/config.py:
2310         * BuildSlaveSupport/ews-build/events.py:
2311         * BuildSlaveSupport/ews-build/steps.py:
2312
2313 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2314
2315         [ews-build] change max_builds for local-worker to 1
2316         https://bugs.webkit.org/show_bug.cgi?id=195568
2317
2318         Reviewed by Lucas Forschler.
2319
2320         * BuildSlaveSupport/ews-build/loadConfig.py:
2321
2322 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2323
2324         Fix the build
2325
2326         * TestRunnerShared/spi/PencilKitTestSPI.h:
2327         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2328
2329 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2330
2331         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2332         https://bugs.webkit.org/show_bug.cgi?id=194131
2333
2334         Reviewed by Michael Catanzaro.
2335
2336         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2337         (uriChanged):
2338         (testUnfinishedSubresourceLoad):
2339         (serverCallback):
2340         (beforeAll):
2341
2342 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2343
2344         WTF::Expected should use std::addressof instead of operator&
2345         https://bugs.webkit.org/show_bug.cgi?id=195604
2346
2347         Reviewed by Myles Maxfield.
2348
2349         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2350         (TestWebKitAPI::Unique::Unique):
2351         (TestWebKitAPI::Unique::operator&):
2352         (TestWebKitAPI::TEST):
2353
2354 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2355
2356         Add Optional to Forward.h.
2357         https://bugs.webkit.org/show_bug.cgi?id=195586
2358
2359         Reviewed by Darin Adler.
2360
2361         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2362         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2363         Remove unnecessary includes from headers.
2364
2365 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2366
2367         Add testing API to hit-test and scroll overflow scrollers
2368         https://bugs.webkit.org/show_bug.cgi?id=195278
2369
2370         Reviewed by Antti Koivisto.
2371         
2372         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2373         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2374         
2375         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2376
2377         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2378         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2379         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2380         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2381         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2382         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2383         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2384         (WTR::enclosingScrollViewIncludingSelf):
2385         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2386
2387 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2388
2389         API test WebKit.RequestTextInputContext fails on iOS
2390         https://bugs.webkit.org/show_bug.cgi?id=195585
2391
2392         Reviewed by Wenson Hsieh and Simon Fraser.
2393
2394         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2395         (applyStyle):
2396         (TEST):
2397         Add a viewport, so that the coordinates match up on iOS.
2398         Scroll by moving the UIScrollView's contentOffset.
2399
2400 2019-03-11  Chris Dumez  <cdumez@apple.com>
2401
2402         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2403         https://bugs.webkit.org/show_bug.cgi?id=195506
2404         <rdar://problem/48733477>
2405
2406         Reviewed by Alex Christensen.
2407
2408         Add API test coverage.
2409
2410         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2411
2412 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2413
2414         Adding myself to contributors.json
2415
2416         Unreviewed, addming myself to contributors.json .
2417
2418         * Scripts/webkitpy/common/config/contributors.json:
2419
2420 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2421
2422         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2423         https://bugs.webkit.org/show_bug.cgi?id=195511
2424         <rdar://problem/44873269>
2425
2426         Reviewed by Darin Adler.
2427
2428         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2429         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2430         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2431         (TEST_F):
2432
2433 2019-03-11  Chris Dumez  <cdumez@apple.com>
2434
2435         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2436         https://bugs.webkit.org/show_bug.cgi?id=195561
2437
2438         Reviewed by Youenn Fablet.
2439
2440         Make sure the JS in the test requests for permission to receive device orientation events.
2441
2442         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2443
2444 2019-03-11  Youenn Fablet  <youenn@apple.com>
2445
2446         Allow storage quota increase by default in WTR
2447         https://bugs.webkit.org/show_bug.cgi?id=195541
2448
2449         Reviewed by Geoffrey Garen.
2450
2451         Allow storage quota increase by default in WTR.
2452         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2453         Use this for tests that explicitly need cache increase.
2454
2455         Instead of increasing quota by 2, make sure the next request is
2456         granted by adding all given parameters.
2457
2458         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2459         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2460         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2461         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2462         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2463         * WebKitTestRunner/TestController.cpp:
2464         (WTR::TestController::setAllowStorageQuotaIncrease):
2465         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2466         * WebKitTestRunner/TestController.h:
2467         * WebKitTestRunner/TestInvocation.cpp:
2468         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2469         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2470         (WTR::TestController::cocoaResetStateToConsistentValues):
2471         (WTR::TestController::setAllowStorageQuotaIncrease):
2472         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2473         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2474         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2475
2476 2019-03-11  Xan Lopez  <xan@igalia.com>
2477
2478         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2479         https://bugs.webkit.org/show_bug.cgi?id=194147
2480
2481         Reviewed by Michael Saboff.
2482
2483         To make --32-bit work correctly on Linux/64bit we need to:
2484
2485         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2486         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2487         unfortunately CMake only allows us to do this during
2488         crosscompilation, which is overkill here.
2489         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2490         pkg-config detection module uses the x86 .pc files instead of the
2491         x86_64 ones.
2492         - Set the -m32 flags for the compiler.
2493
2494         * Scripts/webkitdirs.pm:
2495         (generateBuildSystemFromCMakeProject):
2496
2497 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2498
2499         Add MotionMark-1.1 plan file for run-benchmark script.
2500         https://bugs.webkit.org/show_bug.cgi?id=195481
2501
2502         Rubber-stamped by Darin Adler.
2503
2504         Run-benchmark script should support MontionMark-1.1.
2505
2506         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2507
2508 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2509
2510         [ews-app] Add support for submit-to-ews url
2511         https://bugs.webkit.org/show_bug.cgi?id=195477
2512
2513         Reviewed by Lucas Forschler.
2514
2515         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2516         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2517         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2518         * BuildSlaveSupport/ews-app/ews/urls.py:
2519         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2520
2521 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2522
2523         Unreviewed, rolling out r242688, r242643, r242624.
2524
2525         Caused multiple layout test failures and crashes on iOS and macOS.
2526
2527         Reverted changeset:
2528
2529         "requestAnimationFrame should execute before the next frame"
2530         https://bugs.webkit.org/show_bug.cgi?id=177484
2531         https://trac.webkit.org/changeset/242624/webkit
2532
2533         * Tracing/SystemTracePoints.plist:
2534
2535 2019-03-11  John Wilander  <wilander@apple.com>
2536
2537         Resource Load Statistics: Make it possible exclude localhost from classification
2538         https://bugs.webkit.org/show_bug.cgi?id=195474
2539         <rdar://problem/47520577>
2540
2541         Reviewed by Brent Fulgham.
2542
2543         This patch allows for localhost to be excluded from classification and
2544         treatment as a prevalent resource.
2545
2546         The WebKit Tools change adds a new function called
2547         testRunner.setStatisticsIsRunningTest() which can be used to control this
2548         behavior.
2549
2550         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2551         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2552         (WTR::TestRunner::setStatisticsIsRunningTest):
2553         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2554         * WebKitTestRunner/TestController.cpp:
2555         (WTR::TestController::setStatisticsIsRunningTest):
2556         * WebKitTestRunner/TestController.h:
2557         * WebKitTestRunner/TestInvocation.cpp:
2558         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2559
2560 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2561
2562         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2563         https://bugs.webkit.org/show_bug.cgi?id=195560
2564
2565         Reviewed by Lucas Forschler.
2566
2567         * BuildSlaveSupport/ews-build/master.cfg:
2568
2569 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2570
2571         Unreviewed, rolling out r242698.
2572
2573         API test crashes on bots.
2574
2575         Reverted changeset:
2576
2577         "Add a WKContentRuleList variant that uses copied memory
2578         instead of mmap'd shared memory for class A containerized
2579         apps"
2580         https://bugs.webkit.org/show_bug.cgi?id=195511
2581         https://trac.webkit.org/changeset/242698
2582
2583 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2584
2585         [WPE] Enable web process sandbox
2586         https://bugs.webkit.org/show_bug.cgi?id=195169
2587
2588         Reviewed by Daniel Bates.
2589
2590         * wpe/install-dependencies:
2591         * wpe/jhbuild.modules:
2592
2593 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2594
2595         [ews-app] Use port 17000 for worker communication
2596         https://bugs.webkit.org/show_bug.cgi?id=195558
2597
2598         Reviewed by Lucas Forschler.
2599
2600         * BuildSlaveSupport/ews-build/master.cfg:
2601
2602 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2603
2604         [ews-build] unit-tests fail when passwords.json is missing
2605         https://bugs.webkit.org/show_bug.cgi?id=195557
2606
2607         Reviewed by Lucas Forschler.
2608
2609         * BuildSlaveSupport/ews-build/loadConfig.py:
2610         (loadBuilderConfig):
2611         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2612         (ConfigDotJSONTest.test_configuration):
2613         * BuildSlaveSupport/ews-build/master.cfg:
2614
2615 2019-03-11  Truitt Savell  <tsavell@apple.com>
2616
2617         Unreviewed, rolling out r242702.
2618
2619         Broke High Sierra builders.
2620
2621         Reverted changeset:
2622
2623         "Add utility function to allow easy reverse range-based
2624         iteration of a container"
2625         https://bugs.webkit.org/show_bug.cgi?id=195542
2626         https://trac.webkit.org/changeset/242702
2627
2628 2019-03-11  Sam Weinig  <sam@webkit.org>
2629
2630         Add utility function to allow easy reverse range-based iteration of a container
2631         https://bugs.webkit.org/show_bug.cgi?id=195542
2632
2633         Reviewed by Antti Koivisto.
2634
2635         * TestWebKitAPI/CMakeLists.txt:
2636         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2637         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2638         (TestWebKitAPI::TEST):
2639         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2640
2641 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2642
2643         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2644         https://bugs.webkit.org/show_bug.cgi?id=195511
2645         <rdar://problem/44873269>
2646
2647         Reviewed by Darin Adler.
2648
2649         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2650         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2651         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2652         (TEST_F):
2653
2654 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2655
2656         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2657         https://bugs.webkit.org/show_bug.cgi?id=195499
2658
2659         Reviewed by Darin Adler.
2660
2661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2662         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2663         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2664         (-[WKWebView synchronouslyFocusTextInputContext:]):
2665         (applyStyle):
2666         (applyIframe):
2667         (TEST):
2668         Add some tests for this SPI.
2669
2670 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2671
2672         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2673         https://bugs.webkit.org/show_bug.cgi?id=181151
2674
2675         Reviewed by Don Olmstead.
2676
2677         * TestWebKitAPI/CMakeLists.txt:
2678         * TestWebKitAPI/PlatformWin.cmake:
2679         Enable TestWTF RunLoop tests in all platforms.
2680
2681         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2682         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2683         (TestWebKitAPI::DerivedOneShotTimer::fired):
2684         (TestWebKitAPI::TEST):
2685         Only a few platforms support nested RunLoop.
2686
2687         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2688         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2689
2690 2019-03-10  David Quesada  <david_quesada@apple.com>
2691
2692         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2693         https://bugs.webkit.org/show_bug.cgi?id=152480
2694
2695         Reviewed by Chris Dumez.
2696
2697         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2698         there are no additional references to the process pool besides the one held by
2699         the download, waits for the download to finish (in the sense that the
2700         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2701         measure, also check that the process pool has been deallocated at the end of the
2702         test. The test wouldn't be meaningful if the process pool were still alive.
2703
2704         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2705         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2706         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2707             The download will be canceled because the delegate does not implement the
2708             method to decide the download's destination, so this is where we know the
2709             DownloadProxyMap is done with the DownloadProxy.
2710         (TEST):
2711
2712 2019-03-08  Chris Dumez  <cdumez@apple.com>
2713
2714         Add support for Device Orientation / Motion permission API
2715         https://bugs.webkit.org/show_bug.cgi?id=195329
2716         <rdar://problem/47645367>
2717
2718         Reviewed by Geoffrey Garen.
2719
2720         Add test infrastructure to help test the Device Orientation / Motion permission API.
2721
2722         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2723         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2724         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2725         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2726         * WebKitTestRunner/TestController.cpp:
2727         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2728         (WTR::TestController::createWebViewWithOptions):
2729         (WTR::TestController::resetStateToConsistentValues):
2730         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2731         * WebKitTestRunner/TestController.h:
2732         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2733         * WebKitTestRunner/TestInvocation.cpp:
2734         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2735
2736 2019-03-08  Saam barati  <sbarati@apple.com>
2737
2738         Add a compare-results script to compare benchmark results
2739         https://bugs.webkit.org/show_bug.cgi?id=195486
2740         <rdar://problem/48723397>
2741
2742         Reviewed by Geoffrey Garen.
2743
2744         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2745         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2746         to extend it to learn about our other benchmarks.
2747
2748         * Scripts/compare-results: Added.
2749         (readJSONFile):
2750         (detectJetStream2):
2751         (JetStream2Results):
2752         (detectSpeedometer2):
2753         (Speedometer2Results):
2754         (detectPLT5):
2755         (PLT5Results):
2756         (detectBenchmark):
2757         (biggerIsBetter):
2758         (ttest):
2759         (getOptions):
2760         (main):
2761
2762 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2763
2764         Ensure old tab state is cleared between iterations of run-benchmark
2765         https://bugs.webkit.org/show_bug.cgi?id=195393
2766         <rdar://problem/46885583>
2767
2768         Reviewed by Dewei Zhu.
2769
2770         a) ensure the default to restore state is not set
2771         b) terminate Safari correctly
2772         c) Set the system default to ignore Persistent State in Safari
2773
2774         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2775         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2776         (OSXBrowserDriver.prepare_env): 
2777         (OSXBrowserDriver.restore_env):
2778         (OSXBrowserDriver.close_browsers):
2779         (OSXBrowserDriver._terminate_processes):
2780         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2781         (OSXChromeDriver):
2782         (OSXChromeCanaryDriver):
2783         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2784         (OSXFirefoxDriver):
2785         (OSXFirefoxNightlyDriver):
2786         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2787         (OSXSafariDriver):
2788         (OSXSafariDriver.prepare_env):
2789
2790 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2791
2792         [GTK] Several InputMethodFilter tests are failing
2793         https://bugs.webkit.org/show_bug.cgi?id=195408
2794
2795         Reviewed by Carlos Garcia Campos.
2796
2797         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2798         Regressed in r241751.
2799         Hexadecimal values of keycodes are expressed now in upper letters.
2800         Composited characters should be cast to UTF8 strings.
2801
2802         (TestWebKitAPI::TEST):
2803
2804 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2805
2806         [GTK] Make Tools/gtkdoc python3 compatible
2807         https://bugs.webkit.org/show_bug.cgi?id=195359
2808
2809         Reviewed by Carlos Garcia Campos.
2810
2811         * gtkdoc/generate-gtkdoc:
2812         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2813         work with Python 2 and 3.
2814         (get_gtkdoc_module_paths):
2815         The iteritems() was removed in Python 3, so let's use items() that's
2816         available in Python 2 and 3.
2817         (get_generator_for_config):
2818         * gtkdoc/gtkdoc.py:
2819         (GTKDoc._run_command):
2820         The sys.stdout.write() is expecting str in Python 3 and not bytes
2821         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2822         for passing the bytes there.
2823
2824 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2825
2826         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2827         https://bugs.webkit.org/show_bug.cgi?id=195346
2828         <rdar://problem/48667048>
2829
2830         Unreviewed build fix for clang-cl.
2831
2832         * DumpRenderTree/win/DumpRenderTree.cpp:
2833         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2834
2835 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2836
2837         requestAnimationFrame should execute before the next frame
2838         https://bugs.webkit.org/show_bug.cgi?id=177484
2839
2840         Reviewed by Simon Fraser.
2841
2842         Add trace points for the page RenderingUpdate.
2843
2844         * Tracing/SystemTracePoints.plist:
2845
2846 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2847
2848         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2849         https://bugs.webkit.org/show_bug.cgi?id=195353
2850         <rdar://problem/48626394>
2851
2852         Reviewed by Simon Fraser.
2853
2854         * WebKitTestRunner/ios/TestControllerIOS.mm:
2855         (WTR::TestController::platformResetPreferencesToConsistentValues):
2856
2857 2019-03-07  John Wilander  <wilander@apple.com>
2858
2859         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2860         https://bugs.webkit.org/show_bug.cgi?id=195383
2861         <rdar://problem/48570136>
2862
2863         Reviewed by Brent Fulgham.
2864
2865         This patch adds test infrastructure to purge only script-accessible cookies,
2866         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2867
2868         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2869         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2870         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2871         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2872         * WebKitTestRunner/TestController.cpp:
2873         (WTR::TestController::statisticsDeleteCookiesForHost):
2874         * WebKitTestRunner/TestController.h:
2875         * WebKitTestRunner/TestInvocation.cpp:
2876         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2877
2878 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2879
2880         Unreviewed, rolling out r242354.
2881         https://bugs.webkit.org/show_bug.cgi?id=195402
2882
2883         breaks layout tests in all configurations (Requested by
2884         zdobersek on #webkit).
2885
2886         Reverted changeset:
2887
2888         "[WPE] Enable web process sandbox"
2889         https://bugs.webkit.org/show_bug.cgi?id=195169
2890         https://trac.webkit.org/changeset/242354
2891
2892 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2893
2894         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2895         https://bugs.webkit.org/show_bug.cgi?id=195346
2896
2897         Reviewed by Fujii Hironori.
2898
2899         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2900         (TestWebKitAPI::TEST):
2901         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2902
2903         * DumpRenderTree/win/DumpRenderTree.cpp:
2904         (findFontFallback):
2905         (addFontFallbackIfPresent):
2906         (removeFontFallbackIfPresent):
2907         (main):
2908         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2909         (TestWebKitAPI::Util::moduleDirectory):
2910         (TestWebKitAPI::Util::createInjectedBundlePath):
2911         Use wchar helpers as needed.
2912
2913 2019-03-06  Rob Buis  <rbuis@igalia.com>
2914
2915         Consider supporting the `referrerpolicy` attribute.
2916         https://bugs.webkit.org/show_bug.cgi?id=179053
2917
2918         Reviewed by Darin Adler.
2919
2920         Add a runtime flag for referrerpolicy attribute.
2921
2922         * DumpRenderTree/mac/DumpRenderTree.mm:
2923         (enableExperimentalFeatures):
2924
2925 2019-03-05  Daniel Bates  <dabates@apple.com>
2926
2927         Update expected API test result following r242379
2928         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2929
2930         Update expected x-coordinate of selection rect now that the left padding of
2931         a textarea is sized in ems (so dependent on the font size) just like the left
2932         padding of a text field.
2933
2934         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2935         (TestWebKitAPI::TEST):
2936
2937 2019-03-05  David Quesada  <david_quesada@apple.com>
2938
2939         [WK2] It should be possible to follow links with 'download' attributes
2940         https://bugs.webkit.org/show_bug.cgi?id=195145
2941         rdar://problem/48462642
2942
2943         Reviewed by Alex Christensen.
2944
2945         Add a unit test to verify that activating links with 'download' attributes now
2946         navigates to the linked resource, rather than starts downloading it. Add another
2947         to verify that it is still possible to explicitly download the link via the
2948         'Download' navigation action policy.
2949
2950         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2951         (-[DownloadAttributeTestDelegate init]):
2952         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2953         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2954         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2955         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2956         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2957         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2958         (TEST):
2959         * WebKitTestRunner/TestController.cpp:
2960         (WTR::TestController::decidePolicyForNavigationAction):
2961         * WebKitTestRunner/TestController.h:
2962
2963 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2964
2965         [Curl] Implement Cookie Accept Policy.
2966         https://bugs.webkit.org/show_bug.cgi?id=191645
2967
2968         Reviewed by Fujii Hironori.
2969
2970         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2971         (TestWebKitAPI::Curl::TEST_F):
2972
2973 2019-03-05  Youenn Fablet  <youenn@apple.com>
2974
2975         Rename requestCacheStorageSpace to requestStorageSpace
2976         https://bugs.webkit.org/show_bug.cgi?id=195282
2977
2978         Reviewed by Chris Dumez.
2979
2980         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2981         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2982         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2983
2984 2019-03-05  Brady Eidson  <beidson@apple.com>
2985
2986         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2987         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2988
2989         Reviewed by Tim Horton.
2990
2991         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2992         different directory into that same WKWebView should work.
2993
2994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2995         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2996
2997 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2998
2999         Add WeakHashSet
3000         https://bugs.webkit.org/show_bug.cgi?id=195152
3001
3002         Reviewed by Antti Koivisto.
3003
3004         Added tests for WeakHashSet.
3005
3006         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3007         (TestWebKitAPI::Base::Base): Moved.
3008         (TestWebKitAPI::Derived::foo): Moved.
3009         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3010         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3011         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3012         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3013
3014 2019-03-04  Chris Dumez  <cdumez@apple.com>
3015
3016         Do not share WebProcesses between private and regular sessions
3017         https://bugs.webkit.org/show_bug.cgi?id=195189
3018         <rdar://problem/48421064>
3019
3020         Reviewed by Alex Christensen.
3021
3022         Add API test coverage.
3023
3024         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3025         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3026
3027 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3028
3029         [WPE] Enable web process sandbox
3030         https://bugs.webkit.org/show_bug.cgi?id=195169
3031
3032         Reviewed by Daniel Bates.
3033
3034         * wpe/install-dependencies:
3035         * wpe/jhbuild.modules:
3036
3037 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3038
3039         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3040         https://bugs.webkit.org/show_bug.cgi?id=195206
3041
3042         Reviewed by Žan Doberšek.
3043
3044         Add a new test case.
3045
3046         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3047         (testJSCClass):
3048
3049 2019-03-04  Charlie Turner  <cturner@igalia.com>
3050
3051         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3052         https://bugs.webkit.org/show_bug.cgi?id=194898
3053
3054         Reviewed by Žan Doberšek.
3055
3056         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3057         a GCC extension that permits arithmetic on void* pointer. Inline
3058         the macro until this issue is fixed upstream.
3059
3060 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3061
3062         Rid the world of WK_API_ENABLED
3063         https://bugs.webkit.org/show_bug.cgi?id=195263
3064
3065         Reviewed by Dan Bernstein.
3066
3067         List of changed files elided because it's useless.
3068
3069 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3070
3071         Unreviewed follow-up to r242292.
3072
3073         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3074
3075         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3076         (TestWebKitAPI::testStrip): Renamed from strip.
3077         (TestWebKitAPI::TEST):
3078
3079 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3080
3081         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3082
3083         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3084         and bug #194272 for details.
3085
3086         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3087
3088 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3089
3090         Remove some more unused 32-bit code
3091         https://bugs.webkit.org/show_bug.cgi?id=195255
3092
3093         Reviewed by Darin Adler.
3094
3095         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3096         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3097         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3098         (NPP_New):
3099         (NPP_HandleEvent):
3100         (handleEventCarbon): Deleted.
3101
3102 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3103
3104         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3105
3106         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3107         (TestWebKitAPI::TEST):
3108
3109 2019-03-01  Darin Adler  <darin@apple.com>
3110
3111         Finish removing String::format
3112         https://bugs.webkit.org/show_bug.cgi?id=194893
3113
3114         Reviewed by Daniel Bates.
3115 '
3116         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3117
3118 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3119
3120         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3121         https://bugs.webkit.org/show_bug.cgi?id=195229
3122         <rdar://problem/48520362>
3123
3124         Reviewed by Chris Dumez.
3125
3126         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3127         (TEST):
3128
3129 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3130
3131         Add a system trace scope for event region building
3132         https://bugs.webkit.org/show_bug.cgi?id=195226
3133
3134         Reviewed by Jon Lee.
3135
3136         This trace scope measures the time spend converting element rects into Region objects,
3137         which can be large on some pages.
3138
3139         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3140
3141         * Tracing/SystemTracePoints.plist:
3142
3143 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3144
3145         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3146         https://bugs.webkit.org/show_bug.cgi?id=194612
3147
3148         Reviewed by Alex Christensen.
3149
3150         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3151         Just test the new string-processing function and don't touch the actual environment.
3152         (Test cases are all as before, but based on operator== instead of strcmp.)
3153
3154 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3155
3156         [ews-app] Update primary keys for handling multiple Buildbot instances
3157         https://bugs.webkit.org/show_bug.cgi?id=195120
3158
3159         Reviewed by Stephanie Lewis.
3160
3161         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3162         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3163         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3164
3165         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3166         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3167         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3168         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3169         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3170         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3171
3172 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3173
3174         [WinCairo] Enable service worker
3175         https://bugs.webkit.org/show_bug.cgi?id=188318
3176
3177         Reviewed by Youenn Fablet.
3178
3179         * DumpRenderTree/DumpRenderTreePrefix.h:
3180         * TestWebKitAPI/PlatformWin.cmake:
3181         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3182         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3183         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3184
3185 2019-03-01  Justin Fan  <justin_fan@apple.com>
3186
3187         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3188         https://bugs.webkit.org/show_bug.cgi?id=195191
3189
3190         Rubber-stamped by Dean Jackson.
3191
3192         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3193
3194         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3195
3196 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3197
3198         Unreviewed, fix lldb webkitpy tests
3199         https://bugs.webkit.org/show_bug.cgi?id=194375
3200
3201         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3202
3203         * lldb/lldb_webkit.py:
3204         (WTFStringImplProvider.is_8bit):
3205
3206 2019-02-28  David Quesada  <david_quesada@apple.com>
3207
3208         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3209         https://bugs.webkit.org/show_bug.cgi?id=195121
3210         rdar://problem/48450302
3211
3212         Reviewed by Alex Christensen.
3213
3214         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3215         configurations where the 'download' attribute is absent, blank, or populated
3216         with a filename, and where the anchor element is same-origin or cross-origin
3217         (meaning the 'download' attribute shouldn't be honored).
3218
3219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3220         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3221         (-[NavigationActionTestDelegate init]):
3222         (-[NavigationActionTestDelegate navigationAction]):
3223         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3224         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3225         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3226         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3227         (TEST):
3228
3229 2019-02-28  Antoine Quint  <graouts@apple.com>
3230
3231         Enable the Pointer Events runtime flag by default
3232         https://bugs.webkit.org/show_bug.cgi?id=195156
3233
3234         Reviewed by Dean Jackson.
3235
3236         * DumpRenderTree/mac/DumpRenderTree.mm:
3237         (enableExperimentalFeatures):
3238
3239 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3240
3241         Several PasteImage API tests are flaky
3242         https://bugs.webkit.org/show_bug.cgi?id=195160
3243
3244         Reviewed by Tim Horton.
3245
3246         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3247         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3248         listening for a "load" event after image load is already complete.
3249
3250         To address this, make these tests first register a "load" event handler, then run script to insert an image
3251         element into the document, and finally wait until the load event is observed before checking image size.
3252
3253         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3254
3255 2019-02-28  Chris Dumez  <cdumez@apple.com>
3256
3257         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3258         https://bugs.webkit.org/show_bug.cgi?id=195107
3259
3260         Reviewed by Alex Christensen.
3261
3262         Give some time for the zoom level to get restored.
3263
3264         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3265
3266 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3267
3268         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3269         https://bugs.webkit.org/show_bug.cgi?id=194958
3270
3271         Reviewed by Geoffrey Garen.
3272
3273         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3274         (TEST):
3275
3276 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3277
3278         [ews-app] Update method to save build to handle builder_display_name
3279         https://bugs.webkit.org/show_bug.cgi?id=195047
3280
3281         Reviewed by Dewei Zhu.
3282
3283         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3284         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3285
3286 2019-02-28  Justin Fan  <justin_fan@apple.com>
3287
3288         [Web GPU] Enable Web GPU only on 64-bit
3289         https://bugs.webkit.org/show_bug.cgi?id=195139
3290
3291         Because Metal is only supported on 64 bit apps.
3292
3293         Unreviewed build fix.
3294
3295         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3296
3297 2019-02-27  Youenn Fablet  <youenn@apple.com>
3298
3299         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3300         https://bugs.webkit.org/show_bug.cgi?id=194959
3301
3302         Reviewed by Chris Dumez.
3303
3304         Spin loop until getting the condition to remove flakiness.
3305
3306         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3307
3308 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3309
3310         [ews-build] Buildbot should include builder_display_name in the build events
3311         https://bugs.webkit.org/show_bug.cgi?id=195045
3312
3313         Reviewed by Dewei Zhu.
3314
3315         * BuildSlaveSupport/ews-build/events.py:
3316         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3317         buildername to builder_name to be consistent in naming style.
3318         (Events.buildFinished): Ditto.
3319
3320 2019-02-27  Chris Dumez  <cdumez@apple.com>
3321
3322         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3323         https://bugs.webkit.org/show_bug.cgi?id=194480
3324
3325         Reviewed by Brady Eidson.
3326
3327         Update existing API test to make it more likely to reproduce the issue.
3328
3329         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3330
3331 2019-02-27  Brady Eidson  <beidson@apple.com>
3332
3333         Universal links from Google search results pages don't open the app.
3334         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3335
3336         Reviewed by Geoffrey Garen.
3337
3338         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3339         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3340         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3341         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3342
3343 2019-02-27  Chris Dumez  <cdumez@apple.com>
3344
3345         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3346         https://bugs.webkit.org/show_bug.cgi?id=195102
3347
3348         Reviewed by Geoffrey Garen.
3349
3350         If the number of processes is not yet what we expect, wait a bit and check again to give
3351         processes some time to exit.
3352
3353         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3354
3355 2019-02-27  Chris Dumez  <cdumez@apple.com>
3356
3357         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3358         https://bugs.webkit.org/show_bug.cgi?id=194545
3359
3360         Reviewed by Brady Eidson.
3361
3362         Make sure the test navigates forward and then back only once. Previously, navigating
3363         back would trigger a navigation again in a timer.
3364
3365         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3366
3367 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3368
3369         High Sierra Debug JSC test queue should use faster hardware
3370         https://bugs.webkit.org/show_bug.cgi?id=194603
3371
3372         Rubber-stamped by Alexey Proskuryakov.
3373
3374         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3375
3376         * BuildSlaveSupport/build.webkit.org-config/config.json:
3377         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3378         (BubbleQueueServer):
3379         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3380         (WebKitBuildbot):
3381         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3382         * QueueStatusServer/config/queues.py:
3383         * Scripts/webkitpy/common/config/ews.json:
3384         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3385         (test_ews_name):
3386
3387 2019-02-27  John Wilander  <wilander@apple.com>
3388
3389         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3390         https://bugs.webkit.org/show_bug.cgi?id=195071
3391         <rdar://problem/48417690>
3392
3393         Reviewed by Alex Christensen and Brent Fulgham.
3394
3395         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3396         (TestWebKitAPI::createURL):
3397             Convenience function.
3398         (TestWebKitAPI::TEST):
3399             WebCore::AdClickAttribution now takes a URL when creating Source and
3400             Destination.
3401         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3402         (TestWebKitAPI::TEST):
3403             WebCore::AdClickAttribution now takes a URL when creating Source and
3404             Destination.
3405
3406 2019-02-27  Antoine Quint  <graouts@apple.com>
3407
3408         Support Pointer Events on macOS
3409         https://bugs.webkit.org/show_bug.cgi?id=195008
3410         <rdar://problem/47454419>
3411
3412         Reviewed by Dean Jackson.
3413
3414         * DumpRenderTree/mac/DumpRenderTree.mm:
3415         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3416         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3417
3418 2019-02-26  Mark Lam  <mark.lam@apple.com>
3419
3420         Remove remaining poisoning code.
3421         https://bugs.webkit.org/show_bug.cgi?id=194138
3422
3423         Reviewed by Saam Barati.
3424
3425         * TestWebKitAPI/CMakeLists.txt:
3426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3427         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3428         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3429         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3430         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3431         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3432         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3433
3434 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3435
3436         Move ephemeral local storage from WebProcess to UIProcess
3437         https://bugs.webkit.org/show_bug.cgi?id=195074
3438         <rdar://problem/47937975>
3439
3440         Reviewed by Geoff Garen.
3441
3442         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3443
3444 2019-02-20  Jer Noble  <jer.noble@apple.com>
3445
3446         [Cocoa] Media elements will restart network buffering just before suspending
3447         https://bugs.webkit.org/show_bug.cgi?id=193691
3448
3449         Reviewed by Eric Carlson.
3450
3451         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3452         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3453         (TEST):
3454
3455 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3456
3457         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3458         https://bugs.webkit.org/show_bug.cgi?id=191652
3459
3460         Reviewed by Alex Christensen.
3461
3462         Fix WinCairo MiniBrowser behavior of authentication dialog.
3463
3464         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3465         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3466
3467 2019-02-26  Youenn Fablet  <youenn@apple.com>
3468
3469         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3470         https://bugs.webkit.org/show_bug.cgi?id=195028
3471         <rdar://problem/48243733>
3472
3473         Reviewed by Eric Carlson.
3474
3475         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3476
3477 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3478
3479         [WPE] Add API for webview background color configuration
3480         https://bugs.webkit.org/show_bug.cgi?id=192305
3481
3482         Reviewed by Michael Catanzaro.
3483
3484         * MiniBrowser/wpe/main.cpp:
3485         (main): Add a new option to configure the webview background
3486         color. Example: --bg-color=transparent.
3487         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3488         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3489         (beforeAll): Ditto.
3490
3491 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3492
3493         scalableNativeWebpageParameters() is not preserved on new page navigation.
3494         https://bugs.webkit.org/show_bug.cgi?id=194892
3495         <rdar://problem/47538280>
3496
3497         Reviewed by Wenson Hsieh.
3498         
3499         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3500
3501         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3502         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3503         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3504         (WTR::UIScriptController::allowsViewportShrinkToFit):
3505         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3506         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3507         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3508         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3509         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3510         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3511
3512 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3513
3514         [ews-app] Add model for handling multiple Buildbot instances
3515         https://bugs.webkit.org/show_bug.cgi?id=194863
3516
3517         Reviewed by Stephanie Lewis.
3518
3519         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3520
3521 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3522
3523         [ews-app] Remove BuilderMapping table
3524         https://bugs.webkit.org/show_bug.cgi?id=194961
3525
3526         Reviewed by Stephanie Lewis.
3527
3528         Store builder name directly in build table, instead of having a separate
3529         table for it.
3530
3531         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3532         * BuildSlaveSupport/ews-app/ews/models/build.py:
3533         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3534         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3535
3536 2019-02-25  John Wilander  <wilander@apple.com>
3537
3538         Introduce and adopt new class RegistrableDomain for eTLD+1
3539         https://bugs.webkit.org/show_bug.cgi?id=194791
3540         <rdar://problem/48179240>
3541
3542         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3543
3544         This patch adds an API test and replaces two instances of
3545         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3546
3547         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3548         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3549         (TestWebKitAPI::TEST):
3550             Changed two strings to make sure the registrable domains are still considered
3551             invalid and pass the test.
3552         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3553         (TestWebKitAPI::TEST):
3554         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3555         (WTR::InjectedBundle::didReceiveMessageToPage):
3556
3557 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3558
3559         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3560         https://bugs.webkit.org/show_bug.cgi?id=195001
3561
3562         Reviewed by Carlos Garcia Campos.
3563
3564         API version 1.0 always includes the functionality previously guarded with
3565         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3566         unconditionally.
3567
3568         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3569         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3570         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3571         (WebViewTest::showInWindow): Ditto.
3572         (WebViewTest::hideView): Ditto.
3573         * wpe/backends/HeadlessViewBackend.cpp:
3574         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3575         * wpe/backends/ViewBackend.cpp:
3576         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3577         * wpe/backends/WindowViewBackend.cpp:
3578         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3579         WPE_BACKEND_CHECK_VERSION().
3580         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3581
3582 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3583
3584         [Flatpak] Add support for flatpak > 1.1.2
3585         https://bugs.webkit.org/show_bug.cgi?id=194088
3586
3587         Flatpak 1.2 is now out so we need to support that
3588         version now.
3589
3590         Reviewed by Michael Catanzaro.
3591
3592         * flatpak/flatpakutils.py:
3593         (check_flatpak):
3594         (FlatpakPackages.__init__):
3595         (FlatpakPackages.__detect_packages):
3596         (FlatpakPackages.__detect_packages.in):
3597         (FlatpakRepos.update):
3598
3599 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3600
3601         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3602         https://bugs.webkit.org/show_bug.cgi?id=194998
3603
3604         Reviewed by Carlos Garcia Campos.
3605
3606         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3607         to a Git checkout and using the latest commit containing various fixes
3608         and improvements.
3609
3610 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3611
3612         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3613         https://bugs.webkit.org/show_bug.cgi?id=194981
3614
3615         Reviewed by Žan Doberšek.
3616
3617         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3618         (TestWebKitAPI::TEST):
3619
3620 2019-02-23  Keith Miller  <keith_miller@apple.com>
3621
3622         Add new mac target numbers
3623         https://bugs.webkit.org/show_bug.cgi?id=194955
3624
3625         Reviewed by Tim Horton.
3626
3627         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3628         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3629         * MiniBrowser/Configurations/Base.xcconfig:
3630         * TestWebKitAPI/Configurations/Base.xcconfig:
3631         * WebKitTestRunner/Configurations/Base.xcconfig:
3632
3633 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3634
3635         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3636         https://bugs.webkit.org/show_bug.cgi?id=194846
3637
3638         Reviewed by Don Olmstead.
3639
3640         Added _search_paths() and _port_specific_expectations_files() for
3641         WinCairoPort.
3642
3643         * Scripts/webkitpy/port/win.py:
3644         (WinCairoPort.default_baseline_search_path):
3645         (WinCairoPort):
3646         (WinCairoPort._port_specific_expectations_files):
3647         (WinCairoPort._search_paths):
3648
3649 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3650
3651         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3652         https://bugs.webkit.org/show_bug.cgi?id=194963
3653
3654         Reviewed by Dean Jackson.
3655
3656         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3657         Do a `contains` check instead of `equals`, because in debug builds we
3658         put the GraphicsLayer pointer in a prefix.
3659
3660 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3661
3662         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3663         https://bugs.webkit.org/show_bug.cgi?id=194873
3664         <rdar://problem/46701974>
3665
3666         Reviewed by Tim Horton.
3667
3668         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3669
3670         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3671         (WTR::UIScriptController::menuRect const):
3672         (WTR::UIScriptController::isShowingMenu const):
3673         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3674         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3675         (WTR::UIScriptController::menuRect const):
3676
3677         Add a function to query the bounds of the callout menu in content coordinates.
3678
3679         (WTR::UIScriptController::isShowingMenu const):
3680
3681         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3682
3683         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3684         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3685         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3686         (WTR::UIScriptController::rectForMenuAction const):
3687         (WTR::UIScriptController::menuRect const):
3688         (WTR::UIScriptController::isShowingMenu const):
3689         (WTR::findViewInHierarchyOfType): Deleted.
3690
3691 2019-02-22  Chris Dumez  <cdumez@apple.com>
3692
3693         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3694         https://bugs.webkit.org/show_bug.cgi?id=194954
3695         <rdar://problem/48127957>
3696
3697         Reviewed by Alex Christensen.
3698
3699         Add API test coverage.
3700
3701         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3702         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3703         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3704         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3705
3706 2019-02-22  Chris Dumez  <cdumez@apple.com>
3707
3708         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3709         https://bugs.webkit.org/show_bug.cgi?id=194924
3710         <rdar://problem/48216125>
3711
3712         Reviewed by Geoffrey Garen.
3713
3714         Add API test coverage.
3715
3716         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3717
3718 2019-02-22  Chris Dumez  <cdumez@apple.com>
3719
3720         Unreviewed, disable API test added in r241928 on iOS.
3721
3722         The cache is not enabled on devices with less than 3GB of RAM.
3723
3724         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3725
3726 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3727
3728         Hardcode Visual Viewports on everywhere except iOS WK1
3729         https://bugs.webkit.org/show_bug.cgi?id=194928
3730
3731         Reviewed by Zalan Bujtas.
3732
3733         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3734         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3735         set it to false. The setting has shipped for several years and there's no need to turn
3736         it off now.
3737
3738         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3739         Visual Viewports are not enabled.
3740         
3741         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3742         that only runs in WK2
3743
3744         * MiniBrowser/mac/SettingsController.h:
3745         * MiniBrowser/mac/SettingsController.m:
3746         (-[SettingsController init]):
3747         (-[SettingsController _populateMenu]):
3748         (-[SettingsController validateMenuItem:]):
3749         (-[SettingsController visualViewportEnabled]): Deleted.
3750         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3751         * MiniBrowser/mac/WK1BrowserWindowController.m:
3752         (-[WK1BrowserWindowController didChangeSettings]):
3753         * MiniBrowser/mac/WK2BrowserWindowController.m:
3754         (-[WK2BrowserWindowController didChangeSettings]):
3755
3756 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3757
3758         Discard cached processes when clearing website data store
3759         https://bugs.webkit.org/show_bug.cgi?id=194894
3760
3761         Reviewed by Chris Dumez.
3762
3763         Added a test case.
3764
3765         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3766         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3767
3768 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3769
3770         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3771         https://bugs.webkit.org/show_bug.cgi?id=194914
3772         <rdar://problem/47586889>
3773
3774         Reviewed by Geoffrey Garen.
3775
3776         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3777         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3778         (TEST):
3779         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3780
3781 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3782
3783         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3784         <https://webkit.org/b/194761>
3785
3786         Reviewed by Myles Maxfield.
3787
3788         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3789         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3790         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3791         to use ARC-compliant cast.
3792         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3793         ARC-compliant cast.
3794         (WTR::installFakeHelvetica): Log `error` to console if
3795         CTFontManagerRegisterFontsForURL() fails, but only on supported
3796         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3797         Call CFRelease() on `error` to fix the leak.  Update to use
3798         ARC-compliant cast.
3799         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3800         cast.
3801
3802 2019-02-21  Chris Dumez  <cdumez@apple.com>
3803
3804         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3805         https://bugs.webkit.org/show_bug.cgi?id=194481
3806
3807         Reviewed by Alex Christensen.
3808
3809         Give the processes a chance to shutdown and wait until we reached the expected number
3810         of processes.
3811
3812         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3813
3814 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3815
3816         Fix the macOS build
3817
3818         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3819
3820 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3821
3822         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3823
3824         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3825         I am a backwards.
3826
3827 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3828
3829         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3830
3831         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3832         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3833         We could force on UI-side compositing, but I feel like the test might be more
3834         valuable exercising the normal path on each platform (though the original
3835         bug was also UI-side specific). Though we can't validate that the overlay
3836         layer was installed successfully, there are layout tests that do that.
3837
3838 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3839
3840         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3841         https://bugs.webkit.org/show_bug.cgi?id=194845
3842         <rdar://problem/47944579>
3843
3844         Reviewed by Antti Koivisto.
3845
3846         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3847         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3848
3849 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3850
3851         [LFC][Floats] Add support for placing formatting roots in-between floats.
3852         https://bugs.webkit.org/show_bug.cgi?id=194902
3853
3854         Reviewed by Antti Koivisto.
3855
3856         * LayoutReloaded/misc/LFC-passing-tests.txt:
3857
3858 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3859
3860         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3861         https://bugs.webkit.org/show_bug.cgi?id=194901
3862
3863         Unreviewed build fix.
3864
3865         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3866         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3867         WPEBackend-fdo-0.1 as library name.
3868
3869 2019-02-21  Rob Buis  <rbuis@igalia.com>
3870
3871         Update MIME type parser
3872         https://bugs.webkit.org/show_bug.cgi?id=180526
3873
3874         Reviewed by Darin Adler.
3875
3876         Add tests involving leading and trailing whitespace, non-token
3877         characters and quoted strings.
3878
3879         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3880         (TestWebKitAPI::TEST):
3881
3882 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3883
3884         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3885         https://bugs.webkit.org/show_bug.cgi?id=194884
3886
3887         Reviewed by Michael Catanzaro.
3888
3889         * PlatformWin.cmake:
3890
3891 2019-02-20  Chris Dumez  <cdumez@apple.com>
3892
3893         Add API test for <rdar://problem/47471222>
3894         https://bugs.webkit.org/show_bug.cgi?id=194847
3895
3896         Reviewed by Alex Christensen.
3897
3898         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3899
3900 2019-02-20  Chris Dumez  <cdumez@apple.com>
3901
3902         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3903         https://bugs.webkit.org/show_bug.cgi?id=194872
3904         <rdar://problem/47924500>
3905
3906         Reviewed by Alex Christensen.
3907
3908         Add API test coverage.
3909
3910         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3911
3912 2019-02-20  Jer Noble  <jer.noble@apple.com>
3913
3914         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3915         https://bugs.webkit.org/show_bug.cgi?id=191332
3916
3917         Reviewed by Dean Jackson.
3918
3919         * Scripts/git-is-in-range: Added.
3920
3921 2019-02-20  Andy Estes  <aestes@apple.com>
3922
3923         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3924         https://bugs.webkit.org/show_bug.cgi?id=194869
3925
3926         Rubber-stamped by Jer Noble.
3927
3928         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3929         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3930         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3931         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3932         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3933         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3934
3935 2019-02-20  Chris Dumez  <cdumez@apple.com>
3936
3937         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3938         https://bugs.webkit.org/show_bug.cgi?id=194857
3939         <rdar://problem/47759323>
3940
3941         Reviewed by Alex Christensen.
3942
3943         Add API test coverage.
3944
3945         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3946
3947 2019-02-20  Chris Dumez  <cdumez@apple.com>
3948
3949         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3950         https://bugs.webkit.org/show_bug.cgi?id=194829
3951         <rdar://problem/47889906>
3952
3953         Reviewed by Alexey Proskuryakov.
3954
3955         Every time the TestOptions were changing we were creating both a new Web view and
3956         a new WKContext, which would start a new Network process. In most cases, we only
3957         need to contruct a new Web view and we do can keep reusing the same WKContext.
3958         This patch implements this optimization and thus avoids spinning a lot of new
3959         Network processes while running the layout tests.
3960
3961         * WebKitTestRunner/TestController.cpp:
3962         (WTR::TestController::generateContextConfiguration const):
3963         (WTR::TestController::generatePageConfiguration):
3964         (WTR::TestController::createWebViewWithOptions):
3965         (WTR::TestController::resetPreferencesToConsistentValues):
3966         (WTR::updateTestOptionsFromTestHeader):
3967         * WebKitTestRunner/TestController.h:
3968         * WebKitTestRunner/TestOptions.h:
3969         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3970         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3971         (WTR::TestOptions::hasSameInitializationOptions const):
3972         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3973         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3974         (WTR::TestController::platformAddTestOptions const):
3975
3976 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3977
3978         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3979         https://bugs.webkit.org/show_bug.cgi?id=167941
3980
3981         Reviewed by Carlos Garcia Campos.
3982
3983         * MiniBrowser/gtk/main.c:
3984         (filterSavedCallback): Added.
3985         (main): Support loading a JSON rule set file for content filtering.
3986         * MiniBrowser/wpe/main.cpp:
3987         (filterSavedCallback): Added.
3988         (main): Support loading a JSON rule set file for content filtering.
3989         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3990         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3991         (WTF::derefGPtr): Ditto.
3992         (testEmptyStore):
3993         (testSaveInvalidFilter):
3994         (testSaveLoadFilter):
3995         (testSavedFilterIdentifierMatch):
3996         (testRemoveFilter):
3997         (testSaveMultipleFilters):
3998         (testSaveFilterFromFile):
3999         (testFilterPersistence):
4000         (beforeAll):
4001         (afterAll):
4002         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4003         (removeOldInjectedContentAndResetLists): Also reset content filters.
4004         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4005         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4006         the element affected by the style sheet.
4007         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4008         and returns it to be used by tests.
4009         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4010         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4011         (serverCallback): Add support for serving a CSS style sheet for testing.
4012         (beforeAll): Add call to testUserContentManagerContentFilter().
4013         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4014
4015 2019-02-19  Keith Rollin  <krollin@apple.com>
4016
4017         Add timing information to build output
4018         https://bugs.webkit.org/show_bug.cgi?id=194839
4019         <rdar://problem/48219609>
4020
4021         Reviewed by Alexey Proskuryakov.
4022
4023         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4024         emit each project's build time to its output. E.g.,
4025
4026             ** BUILD SUCCEEDED ** [0.132 sec]
4027
4028         * Scripts/webkitdirs.pm:
4029         (XcodeOptions):
4030
4031 2019-02-19  Truitt Savell  <tsavell@apple.com>
4032
4033         Unreviewed, rolling out r241784.
4034
4035         Broke all OpenSource builds.
4036
4037         Reverted changeset:
4038
4039         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4040         instances view"
4041         https://bugs.webkit.org/show_bug.cgi?id=172848
4042         https://trac.webkit.org/changeset/241784
4043
4044 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4045
4046         [LFC][Floats] Remove redundant intersecting logic
4047         https://bugs.webkit.org/show_bug.cgi?id=194804
4048
4049         Reviewed by Antti Koivisto.
4050
4051         * LayoutReloaded/misc/LFC-passing-tests.txt:
4052
4053 2019-02-19  Dean Jackson  <dino@apple.com>
4054
4055         Clean-up output from generate-xcfilelists so it can be filtered
4056         https://bugs.webkit.org/show_bug.cgi?id=194795
4057
4058         Reviewed by Joseph Pecoraro (and Keith Rollin).
4059
4060         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4061         make a slight tweak to filter-build-webkit so such lines are marked
4062         as plain.
4063
4064         * Scripts/filter-build-webkit:
4065         * Scripts/generate-xcfilelists:
4066
4067 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4068
4069         pytest is not correctly auto-installed
4070         https://bugs.webkit.org/show_bug.cgi?id=194707
4071
4072         Reviewed by Carlos Garcia Campos.
4073
4074         * Scripts/webkitpy/thirdparty/__init__.py:
4075         (AutoinstallImportHook._install_pytest):
4076
4077 2019-02-18  Chris Dumez  <cdumez@apple.com>
4078
4079         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4080         https://bugs.webkit.org/show_bug.cgi?id=194797
4081         <rdar://problem/48055151>
4082
4083         Reviewed by Geoffrey Garen.
4084
4085         Add API test coverage.
4086
4087         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4088
4089 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4090
4091         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4092         https://bugs.webkit.org/show_bug.cgi?id=194670
4093         <rdar://problem/39066529>
4094
4095         Reviewed by Tim Horton.
4096
4097         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4098         pasted in an editable area as attachment elements.
4099
4100         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4101         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4102         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4103         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4104         (TestWebKitAPI::TEST):
4105         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4106         (WTR::InjectedBundlePage::InjectedBundlePage):
4107
4108 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4109
4110         Fix API test after r241728
4111        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4112
4113         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4114         (TEST):
4115         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4116
4117 2019-02-18  Daniel Bates  <dabates@apple.com>
4118
4119         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4120         https://bugs.webkit.org/show_bug.cgi?id=192824
4121         <rdar://problem/47100332>
4122
4123         Reviewed by Wenson Hsieh.
4124
4125         Fix a bug where the wrong usage code was used for F13 thru F24.
4126
4127         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4128         (keyCodeForDOMFunctionKey):
4129
4130 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4131
4132         Bytecode cache should a have a boot-specific validation
4133         https://bugs.webkit.org/show_bug.cgi?id=194769
4134         <rdar://problem/48149509>
4135
4136         Reviewed by Keith Miller.
4137
4138         Add test for WTF::bootSessionUUIDString()
4139
4140         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4141         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4142         (TEST):
4143
4144 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4145
4146         Disable safe browsing in WKWebView and remove its WKPreferences API
4147         https://bugs.webkit.org/show_bug.cgi?id=194723
4148         <rdar://problem/48122993>
4149
4150         Reviewed by Geoffrey Garen.
4151
4152         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4153         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4154         (TEST):
4155         (safeBrowsingView):
4156         Make tests use SPI instead of API.
4157
4158 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4159
4160         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4161         https://bugs.webkit.org/show_bug.cgi?id=194586
4162
4163         Reviewed by Ross Kirsling.
4164
4165         * DumpRenderTree/win/DumpRenderTree.cpp:
4166         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4167         * Scripts/webkitpy/port/driver.py:
4168         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4169
4170 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4171
4172         Unreviewed, rolling out r241620.
4173
4174         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
4175         (Requested by ddkilzer on #webkit.)
4176
4177         Reverted changeset:
4178
4179         "[WTF] Add environment variable helpers"
4180         https://bugs.webkit.org/show_bug.cgi?id=192405
4181         https://trac.webkit.org/changeset/241620
4182
4183 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4184
4185         [LFC] RenderImage's default intrinsic size is 0.
4186         https://bugs.webkit.org/show_bug.cgi?id=194745
4187
4188         Reviewed by Antti Koivisto.
4189
4190         * LayoutReloaded/misc/LFC-passing-tests.txt:
4191
4192 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4193
4194         [LFC][BFC] Add support for block replaced intrinsic width.
4195         https://bugs.webkit.org/show_bug.cgi?id=194705
4196
4197         Reviewed by Simon Fraser.
4198
4199         * LayoutReloaded/misc/LFC-passing-tests.txt:
4200
4201 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4202
4203         [LFC] Apply min/max width constraints to preferred width computation
4204         https://bugs.webkit.org/show_bug.cgi?id=194739
4205
4206         Reviewed by Simon Fraser.
4207
4208         * LayoutReloaded/misc/LFC-passing-tests.txt:
4209
4210 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
4211
4212         [WTF] Add environment variable helpers
4213         https://bugs.webkit.org/show_bug.cgi?id=192405
4214
4215         Reviewed by Michael Catanzaro.
4216
4217         * DumpRenderTree/mac/DumpRenderTree.mm:
4218         (libraryPathForDumpRenderTree):
4219         * DumpRenderTree/win/DumpRenderTree.cpp:
4220         (libraryPathForDumpRenderTree):
4221         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4222         (setUpIOSLayoutTestCommunication):
4223         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4224         (beforeAll):
4225         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4226         (main):
4227         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4228         (WebKitTestBus::run):
4229         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4230         (WTR::getOutputDir):
4231         (WTR::initializeFontConfigSetting):
4232         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4233         (WTR::InjectedBundle::platformInitialize):
4234         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4235         (WTR::topLevelPath):
4236         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4237         (WTR::topLevelPath):
4238         (WTR::getOutputDir):
4239         (WTR::activateFonts):
4240         * WebKitTestRunner/TestController.cpp:
4241         (WTR::TestController::libraryPathForTesting):
4242         (WTR::TestController::generateContextConfiguration const):
4243         (WTR::TestController::generatePageConfiguration):
4244         (WTR::TestController::decideDestinationWithSuggestedFilename):
4245         (WTR::TestController::platformAdjustContext):
4246         * WebKitTestRunner/TestController.h:
4247         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4248         (WTR::TestController::cocoaPlatformInitialize):
4249         (WTR::TestController::platformAdjustContext):
4250         * WebKitTestRunner/gtk/main.cpp:
4251         (main):
4252         * WebKitTestRunner/mac/TestControllerMac.mm:
4253         (WTR::TestController::configureContentExtensionForTest):
4254         * WebKitTestRunner/wpe/main.cpp:
4255         (main):
4256         Utilize WTF::Environment where possible.
4257
4258 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4259
4260         [iOS] WKWebView callout bar is missing Change Writing Direction item
4261         https://bugs.webkit.org/show_bug.cgi?id=190015
4262         <rdar://problem/44810366>
4263
4264         Reviewed by Tim Horton.
4265
4266         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
4267         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
4268
4269         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
4270         (TestWebKitAPI::TEST):
4271
4272 2019-02-15  Chris Dumez  <cdumez@apple.com>
4273
4274         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
4275         https://bugs.webkit.org/show_bug.cgi?id=194717
4276         <rdar://problem/47884404>
4277
4278         Reviewed by Brady Eidson.
4279
4280         Add API test coverage.
4281
4282         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4283
4284 2019-02-15  Youenn Fablet  <youenn@apple.com>
4285
4286         Make navigator.mediaDevices SecureContext
4287         https://bugs.webkit.org/show_bug.cgi?id=194666
4288
4289         Reviewed by Eric Carlson.
4290
4291         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4292         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4293         (TEST_F):
4294
4295 2019-02-15  Brian Burg  <bburg@apple.com>
4296
4297         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4298         https://bugs.webkit.org/show_bug.cgi?id=194411
4299         <rdar://problem/47787614>
4300
4301         Reviewed by Joseph Pecoraro.
4302
4303         Remove unnecessary soft linking macro usage.
4304
4305         * DumpRenderTree/mac/TestRunnerMac.mm:
4306         (TestRunner::inspectorTestStubURL):
4307         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4308         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4309         (WTR::TestRunner::inspectorTestStubURL):
4310
4311 2019-02-15  Commit Queue  <commit-queue@webkit.org>
4312
4313         Unreviewed, rolling out r241559 and r241566.
4314         https://bugs.webkit.org/show_bug.cgi?id=194710
4315
4316         Causes layout test crashes under GuardMalloc (Requested by
4317         ryanhaddad on #webkit).
4318
4319         Reverted changesets:
4320
4321         "[WTF] Add environment variable helpers"
4322         https://bugs.webkit.org/show_bug.cgi?id=192405
4323         https://trac.webkit.org/changeset/241559
4324
4325         "Unreviewed build fix for WinCairo Debug after r241559."
4326         https://trac.webkit.org/changeset/241566
4327
4328 2019-02-15  Zalan Bujtas  <zalan@apple.com>
4329
4330         [LFC] Out-of-flow box is never a float box
4331         https://bugs.webkit.org/show_bug.cgi?id=194704
4332
4333         Reviewed by Antti Koivisto.
4334
4335         * LayoutReloaded/misc/LFC-passing-tests.txt:
4336
4337 2019-02-10  Darin Adler  <darin@apple.com>
4338
4339         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
4340         https://bugs.webkit.org/show_bug.cgi?id=194487
4341
4342         Reviewed by Daniel Bates.
4343
4344         * DumpRenderTree/win/DumpRenderTree.cpp:
4345         (applicationId): Use makeString instead of String::format.
4346         (main): Ditto.
4347         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4348         (TestWebKitAPI::Util::createURLForResource): Ditto.
4349         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
4350         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
4351
4352         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4353         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
4354         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
4355         (WTR::createStringWithAttributes): Use appendLiteral.
4356         (WTR::AccessibilityUIElement::helpText const): Ditto.
4357         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
4358         directly instead of using String::format.
4359         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
4360