Add testing API to hit-test and scroll overflow scrollers
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2
3         Add testing API to hit-test and scroll overflow scrollers
4         https://bugs.webkit.org/show_bug.cgi?id=195278
5
6         Reviewed by Antti Koivisto.
7         
8         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
9         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
10         
11         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
12
13         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
14         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
15         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
16         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
17         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
18         * TestRunnerShared/UIScriptContext/UIScriptController.h:
19         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
20         (WTR::enclosingScrollViewIncludingSelf):
21         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
22
23 2019-03-11  Tim Horton  <timothy_horton@apple.com>
24
25         API test WebKit.RequestTextInputContext fails on iOS
26         https://bugs.webkit.org/show_bug.cgi?id=195585
27
28         Reviewed by Wenson Hsieh and Simon Fraser.
29
30         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
31         (applyStyle):
32         (TEST):
33         Add a viewport, so that the coordinates match up on iOS.
34         Scroll by moving the UIScrollView's contentOffset.
35
36 2019-03-11  Chris Dumez  <cdumez@apple.com>
37
38         Assert in WebPageProxy::suspendCurrentPageIfPossible()
39         https://bugs.webkit.org/show_bug.cgi?id=195506
40         <rdar://problem/48733477>
41
42         Reviewed by Alex Christensen.
43
44         Add API test coverage.
45
46         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
47
48 2019-03-11  Shawn Roberts  <sroberts@apple.com>
49
50         Adding myself to contributors.json
51
52         Unreviewed, addming myself to contributors.json .
53
54         * Scripts/webkitpy/common/config/contributors.json:
55
56 2019-03-11  Alex Christensen  <achristensen@webkit.org>
57
58         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
59         https://bugs.webkit.org/show_bug.cgi?id=195511
60         <rdar://problem/44873269>
61
62         Reviewed by Darin Adler.
63
64         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
65         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
66         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
67         (TEST_F):
68
69 2019-03-11  Chris Dumez  <cdumez@apple.com>
70
71         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
72         https://bugs.webkit.org/show_bug.cgi?id=195561
73
74         Reviewed by Youenn Fablet.
75
76         Make sure the JS in the test requests for permission to receive device orientation events.
77
78         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
79
80 2019-03-11  Youenn Fablet  <youenn@apple.com>
81
82         Allow storage quota increase by default in WTR
83         https://bugs.webkit.org/show_bug.cgi?id=195541
84
85         Reviewed by Geoffrey Garen.
86
87         Allow storage quota increase by default in WTR.
88         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
89         Use this for tests that explicitly need cache increase.
90
91         Instead of increasing quota by 2, make sure the next request is
92         granted by adding all given parameters.
93
94         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
95         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
96         (WTR::TestRunner::setAllowStorageQuotaIncrease):
97         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
98         * WebKitTestRunner/InjectedBundle/TestRunner.h:
99         * WebKitTestRunner/TestController.cpp:
100         (WTR::TestController::setAllowStorageQuotaIncrease):
101         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
102         * WebKitTestRunner/TestController.h:
103         * WebKitTestRunner/TestInvocation.cpp:
104         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
105         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
106         (WTR::TestController::cocoaResetStateToConsistentValues):
107         (WTR::TestController::setAllowStorageQuotaIncrease):
108         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
109         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
110         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
111
112 2019-03-11  Xan Lopez  <xan@igalia.com>
113
114         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
115         https://bugs.webkit.org/show_bug.cgi?id=194147
116
117         Reviewed by Michael Saboff.
118
119         To make --32-bit work correctly on Linux/64bit we need to:
120
121         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
122         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
123         unfortunately CMake only allows us to do this during
124         crosscompilation, which is overkill here.
125         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
126         pkg-config detection module uses the x86 .pc files instead of the
127         x86_64 ones.
128         - Set the -m32 flags for the compiler.
129
130         * Scripts/webkitdirs.pm:
131         (generateBuildSystemFromCMakeProject):
132
133 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
134
135         Add MotionMark-1.1 plan file for run-benchmark script.
136         https://bugs.webkit.org/show_bug.cgi?id=195481
137
138         Rubber-stamped by Darin Adler.
139
140         Run-benchmark script should support MontionMark-1.1.
141
142         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
143
144 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
145
146         [ews-app] Add support for submit-to-ews url
147         https://bugs.webkit.org/show_bug.cgi?id=195477
148
149         Reviewed by Lucas Forschler.
150
151         * BuildSlaveSupport/ews-app/ews/fetcher.py:
152         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
153         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
154         * BuildSlaveSupport/ews-app/ews/urls.py:
155         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
156
157 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
158
159         Unreviewed, rolling out r242688, r242643, r242624.
160
161         Caused multiple layout test failures and crashes on iOS and macOS.
162
163         Reverted changeset:
164
165         "requestAnimationFrame should execute before the next frame"
166         https://bugs.webkit.org/show_bug.cgi?id=177484
167         https://trac.webkit.org/changeset/242624/webkit
168
169         * Tracing/SystemTracePoints.plist:
170
171 2019-03-11  John Wilander  <wilander@apple.com>
172
173         Resource Load Statistics: Make it possible exclude localhost from classification
174         https://bugs.webkit.org/show_bug.cgi?id=195474
175         <rdar://problem/47520577>
176
177         Reviewed by Brent Fulgham.
178
179         This patch allows for localhost to be excluded from classification and
180         treatment as a prevalent resource.
181
182         The WebKit Tools change adds a new function called
183         testRunner.setStatisticsIsRunningTest() which can be used to control this
184         behavior.
185
186         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
187         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
188         (WTR::TestRunner::setStatisticsIsRunningTest):
189         * WebKitTestRunner/InjectedBundle/TestRunner.h:
190         * WebKitTestRunner/TestController.cpp:
191         (WTR::TestController::setStatisticsIsRunningTest):
192         * WebKitTestRunner/TestController.h:
193         * WebKitTestRunner/TestInvocation.cpp:
194         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
195
196 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
197
198         [ews-build] Disable waterfall and console view for ews-build.webkit.org
199         https://bugs.webkit.org/show_bug.cgi?id=195560
200
201         Reviewed by Lucas Forschler.
202
203         * BuildSlaveSupport/ews-build/master.cfg:
204
205 2019-03-11  Alex Christensen  <achristensen@webkit.org>
206
207         Unreviewed, rolling out r242698.
208
209         API test crashes on bots.
210
211         Reverted changeset:
212
213         "Add a WKContentRuleList variant that uses copied memory
214         instead of mmap'd shared memory for class A containerized
215         apps"
216         https://bugs.webkit.org/show_bug.cgi?id=195511
217         https://trac.webkit.org/changeset/242698
218
219 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
220
221         [WPE] Enable web process sandbox
222         https://bugs.webkit.org/show_bug.cgi?id=195169
223
224         Reviewed by Daniel Bates.
225
226         * wpe/install-dependencies:
227         * wpe/jhbuild.modules:
228
229 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
230
231         [ews-app] Use port 17000 for worker communication
232         https://bugs.webkit.org/show_bug.cgi?id=195558
233
234         Reviewed by Lucas Forschler.
235
236         * BuildSlaveSupport/ews-build/master.cfg:
237
238 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
239
240         [ews-build] unit-tests fail when passwords.json is missing
241         https://bugs.webkit.org/show_bug.cgi?id=195557
242
243         Reviewed by Lucas Forschler.
244
245         * BuildSlaveSupport/ews-build/loadConfig.py:
246         (loadBuilderConfig):
247         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
248         (ConfigDotJSONTest.test_configuration):
249         * BuildSlaveSupport/ews-build/master.cfg:
250
251 2019-03-11  Truitt Savell  <tsavell@apple.com>
252
253         Unreviewed, rolling out r242702.
254
255         Broke High Sierra builders.
256
257         Reverted changeset:
258
259         "Add utility function to allow easy reverse range-based
260         iteration of a container"
261         https://bugs.webkit.org/show_bug.cgi?id=195542
262         https://trac.webkit.org/changeset/242702
263
264 2019-03-11  Sam Weinig  <sam@webkit.org>
265
266         Add utility function to allow easy reverse range-based iteration of a container
267         https://bugs.webkit.org/show_bug.cgi?id=195542
268
269         Reviewed by Antti Koivisto.
270
271         * TestWebKitAPI/CMakeLists.txt:
272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
273         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
274         (TestWebKitAPI::TEST):
275         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
276
277 2019-03-10  Alex Christensen  <achristensen@webkit.org>
278
279         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
280         https://bugs.webkit.org/show_bug.cgi?id=195511
281         <rdar://problem/44873269>
282
283         Reviewed by Darin Adler.
284
285         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
286         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
287         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
288         (TEST_F):
289
290 2019-03-10  Tim Horton  <timothy_horton@apple.com>
291
292         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
293         https://bugs.webkit.org/show_bug.cgi?id=195499
294
295         Reviewed by Darin Adler.
296
297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
298         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
299         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
300         (-[WKWebView synchronouslyFocusTextInputContext:]):
301         (applyStyle):
302         (applyIframe):
303         (TEST):
304         Add some tests for this SPI.
305
306 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
307
308         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
309         https://bugs.webkit.org/show_bug.cgi?id=181151
310
311         Reviewed by Don Olmstead.
312
313         * TestWebKitAPI/CMakeLists.txt:
314         * TestWebKitAPI/PlatformWin.cmake:
315         Enable TestWTF RunLoop tests in all platforms.
316
317         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
318         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
319         (TestWebKitAPI::DerivedOneShotTimer::fired):
320         (TestWebKitAPI::TEST):
321         Only a few platforms support nested RunLoop.
322
323         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
324         (TestWebKitAPI::DerivedRepeatingTimer::fired):
325
326 2019-03-10  David Quesada  <david_quesada@apple.com>
327
328         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
329         https://bugs.webkit.org/show_bug.cgi?id=152480
330
331         Reviewed by Chris Dumez.
332
333         Add a unit test based on Daniel Bates's test case that starts a download, ensures
334         there are no additional references to the process pool besides the one held by
335         the download, waits for the download to finish (in the sense that the
336         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
337         measure, also check that the process pool has been deallocated at the end of the
338         test. The test wouldn't be meaningful if the process pool were still alive.
339
340         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
341         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
342         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
343             The download will be canceled because the delegate does not implement the
344             method to decide the download's destination, so this is where we know the
345             DownloadProxyMap is done with the DownloadProxy.
346         (TEST):
347
348 2019-03-08  Chris Dumez  <cdumez@apple.com>
349
350         Add support for Device Orientation / Motion permission API
351         https://bugs.webkit.org/show_bug.cgi?id=195329
352         <rdar://problem/47645367>
353
354         Reviewed by Geoffrey Garen.
355
356         Add test infrastructure to help test the Device Orientation / Motion permission API.
357
358         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
359         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
360         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
361         * WebKitTestRunner/InjectedBundle/TestRunner.h:
362         * WebKitTestRunner/TestController.cpp:
363         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
364         (WTR::TestController::createWebViewWithOptions):
365         (WTR::TestController::resetStateToConsistentValues):
366         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
367         * WebKitTestRunner/TestController.h:
368         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
369         * WebKitTestRunner/TestInvocation.cpp:
370         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
371
372 2019-03-08  Saam barati  <sbarati@apple.com>
373
374         Add a compare-results script to compare benchmark results
375         https://bugs.webkit.org/show_bug.cgi?id=195486
376         <rdar://problem/48723397>
377
378         Reviewed by Geoffrey Garen.
379
380         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
381         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
382         to extend it to learn about our other benchmarks.
383
384         * Scripts/compare-results: Added.
385         (readJSONFile):
386         (detectJetStream2):
387         (JetStream2Results):
388         (detectSpeedometer2):
389         (Speedometer2Results):
390         (detectPLT5):
391         (PLT5Results):
392         (detectBenchmark):
393         (biggerIsBetter):
394         (ttest):
395         (getOptions):
396         (main):
397
398 2019-03-08  Stephanie Lewis  <slewis@apple.com>
399
400         Ensure old tab state is cleared between iterations of run-benchmark
401         https://bugs.webkit.org/show_bug.cgi?id=195393
402         <rdar://problem/46885583>
403
404         Reviewed by Dewei Zhu.
405
406         a) ensure the default to restore state is not set
407         b) terminate Safari correctly
408         c) Set the system default to ignore Persistent State in Safari
409
410         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
411         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
412         (OSXBrowserDriver.prepare_env): 
413         (OSXBrowserDriver.restore_env):
414         (OSXBrowserDriver.close_browsers):
415         (OSXBrowserDriver._terminate_processes):
416         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
417         (OSXChromeDriver):
418         (OSXChromeCanaryDriver):
419         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
420         (OSXFirefoxDriver):
421         (OSXFirefoxNightlyDriver):
422         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
423         (OSXSafariDriver):
424         (OSXSafariDriver.prepare_env):
425
426 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
427
428         [GTK] Several InputMethodFilter tests are failing
429         https://bugs.webkit.org/show_bug.cgi?id=195408
430
431         Reviewed by Carlos Garcia Campos.
432
433         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
434         Regressed in r241751.
435         Hexadecimal values of keycodes are expressed now in upper letters.
436         Composited characters should be cast to UTF8 strings.
437
438         (TestWebKitAPI::TEST):
439
440 2019-03-07  Tomas Popela  <tpopela@redhat.com>
441
442         [GTK] Make Tools/gtkdoc python3 compatible
443         https://bugs.webkit.org/show_bug.cgi?id=195359
444
445         Reviewed by Carlos Garcia Campos.
446
447         * gtkdoc/generate-gtkdoc:
448         ConfigParser was reworked in Python 3.2 so we have adapt the code to
449         work with Python 2 and 3.
450         (get_gtkdoc_module_paths):
451         The iteritems() was removed in Python 3, so let's use items() that's
452         available in Python 2 and 3.
453         (get_generator_for_config):
454         * gtkdoc/gtkdoc.py:
455         (GTKDoc._run_command):
456         The sys.stdout.write() is expecting str in Python 3 and not bytes
457         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
458         for passing the bytes there.
459
460 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
461
462         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
463         https://bugs.webkit.org/show_bug.cgi?id=195346
464         <rdar://problem/48667048>
465
466         Unreviewed build fix for clang-cl.
467
468         * DumpRenderTree/win/DumpRenderTree.cpp:
469         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
470
471 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
472
473         requestAnimationFrame should execute before the next frame
474         https://bugs.webkit.org/show_bug.cgi?id=177484
475
476         Reviewed by Simon Fraser.
477
478         Add trace points for the page RenderingUpdate.
479
480         * Tracing/SystemTracePoints.plist:
481
482 2019-03-07  Zalan Bujtas  <zalan@apple.com>
483
484         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
485         https://bugs.webkit.org/show_bug.cgi?id=195353
486         <rdar://problem/48626394>
487
488         Reviewed by Simon Fraser.
489
490         * WebKitTestRunner/ios/TestControllerIOS.mm:
491         (WTR::TestController::platformResetPreferencesToConsistentValues):
492
493 2019-03-07  John Wilander  <wilander@apple.com>
494
495         Resource Load Statistics: Make it possible to purge only script-accessible cookies
496         https://bugs.webkit.org/show_bug.cgi?id=195383
497         <rdar://problem/48570136>
498
499         Reviewed by Brent Fulgham.
500
501         This patch adds test infrastructure to purge only script-accessible cookies,
502         including a new testRunner function called statisticsDeleteCookiesForHost().git a
503
504         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
505         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
506         (WTR::TestRunner::statisticsDeleteCookiesForHost):
507         * WebKitTestRunner/InjectedBundle/TestRunner.h:
508         * WebKitTestRunner/TestController.cpp:
509         (WTR::TestController::statisticsDeleteCookiesForHost):
510         * WebKitTestRunner/TestController.h:
511         * WebKitTestRunner/TestInvocation.cpp:
512         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
513
514 2019-03-07  Commit Queue  <commit-queue@webkit.org>
515
516         Unreviewed, rolling out r242354.
517         https://bugs.webkit.org/show_bug.cgi?id=195402
518
519         breaks layout tests in all configurations (Requested by
520         zdobersek on #webkit).
521
522         Reverted changeset:
523
524         "[WPE] Enable web process sandbox"
525         https://bugs.webkit.org/show_bug.cgi?id=195169
526         https://trac.webkit.org/changeset/242354
527
528 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
529
530         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
531         https://bugs.webkit.org/show_bug.cgi?id=195346
532
533         Reviewed by Fujii Hironori.
534
535         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
536         (TestWebKitAPI::TEST):
537         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
538
539         * DumpRenderTree/win/DumpRenderTree.cpp:
540         (findFontFallback):
541         (addFontFallbackIfPresent):
542         (removeFontFallbackIfPresent):
543         (main):
544         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
545         (TestWebKitAPI::Util::moduleDirectory):
546         (TestWebKitAPI::Util::createInjectedBundlePath):
547         Use wchar helpers as needed.
548
549 2019-03-06  Rob Buis  <rbuis@igalia.com>
550
551         Consider supporting the `referrerpolicy` attribute.
552         https://bugs.webkit.org/show_bug.cgi?id=179053
553
554         Reviewed by Darin Adler.
555
556         Add a runtime flag for referrerpolicy attribute.
557
558         * DumpRenderTree/mac/DumpRenderTree.mm:
559         (enableExperimentalFeatures):
560
561 2019-03-05  Daniel Bates  <dabates@apple.com>
562
563         Update expected API test result following r242379
564         (https://bugs.webkit.org/show_bug.cgi?id=195125)
565
566         Update expected x-coordinate of selection rect now that the left padding of
567         a textarea is sized in ems (so dependent on the font size) just like the left
568         padding of a text field.
569
570         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
571         (TestWebKitAPI::TEST):
572
573 2019-03-05  David Quesada  <david_quesada@apple.com>
574
575         [WK2] It should be possible to follow links with 'download' attributes
576         https://bugs.webkit.org/show_bug.cgi?id=195145
577         rdar://problem/48462642
578
579         Reviewed by Alex Christensen.
580
581         Add a unit test to verify that activating links with 'download' attributes now
582         navigates to the linked resource, rather than starts downloading it. Add another
583         to verify that it is still possible to explicitly download the link via the
584         'Download' navigation action policy.
585
586         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
587         (-[DownloadAttributeTestDelegate init]):
588         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
589         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
590         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
591         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
592         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
593         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
594         (TEST):
595         * WebKitTestRunner/TestController.cpp:
596         (WTR::TestController::decidePolicyForNavigationAction):
597         * WebKitTestRunner/TestController.h:
598
599 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
600
601         [Curl] Implement Cookie Accept Policy.
602         https://bugs.webkit.org/show_bug.cgi?id=191645
603
604         Reviewed by Fujii Hironori.
605
606         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
607         (TestWebKitAPI::Curl::TEST_F):
608
609 2019-03-05  Youenn Fablet  <youenn@apple.com>
610
611         Rename requestCacheStorageSpace to requestStorageSpace
612         https://bugs.webkit.org/show_bug.cgi?id=195282
613
614         Reviewed by Chris Dumez.
615
616         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
617         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
618         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
619
620 2019-03-05  Brady Eidson  <beidson@apple.com>
621
622         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
623         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
624
625         Reviewed by Tim Horton.
626
627         Loading a file: URL into a WKWebView and then loading another file: url from a completely
628         different directory into that same WKWebView should work.
629
630         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
631         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
632
633 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
634
635         Add WeakHashSet
636         https://bugs.webkit.org/show_bug.cgi?id=195152
637
638         Reviewed by Antti Koivisto.
639
640         Added tests for WeakHashSet.
641
642         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
643         (TestWebKitAPI::Base::Base): Moved.
644         (TestWebKitAPI::Derived::foo): Moved.
645         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
646         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
647         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
648         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
649
650 2019-03-04  Chris Dumez  <cdumez@apple.com>
651
652         Do not share WebProcesses between private and regular sessions
653         https://bugs.webkit.org/show_bug.cgi?id=195189
654         <rdar://problem/48421064>
655
656         Reviewed by Alex Christensen.
657
658         Add API test coverage.
659
660         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
661         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
662
663 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
664
665         [WPE] Enable web process sandbox
666         https://bugs.webkit.org/show_bug.cgi?id=195169
667
668         Reviewed by Daniel Bates.
669
670         * wpe/install-dependencies:
671         * wpe/jhbuild.modules:
672
673 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
674
675         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
676         https://bugs.webkit.org/show_bug.cgi?id=195206
677
678         Reviewed by Žan Doberšek.
679
680         Add a new test case.
681
682         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
683         (testJSCClass):
684
685 2019-03-04  Charlie Turner  <cturner@igalia.com>
686
687         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
688         https://bugs.webkit.org/show_bug.cgi?id=194898
689
690         Reviewed by Žan Doberšek.
691
692         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
693         a GCC extension that permits arithmetic on void* pointer. Inline
694         the macro until this issue is fixed upstream.
695
696 2019-03-03  Tim Horton  <timothy_horton@apple.com>
697
698         Rid the world of WK_API_ENABLED
699         https://bugs.webkit.org/show_bug.cgi?id=195263
700
701         Reviewed by Dan Bernstein.
702
703         List of changed files elided because it's useless.
704
705 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
706
707         Unreviewed follow-up to r242292.
708
709         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
710
711         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
712         (TestWebKitAPI::testStrip): Renamed from strip.
713         (TestWebKitAPI::TEST):
714
715 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
716
717         Unreviewed, remove accidentally-committed URLHelpers.cpp test
718
719         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
720         and bug #194272 for details.
721
722         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
723
724 2019-03-03  Tim Horton  <timothy_horton@apple.com>
725
726         Remove some more unused 32-bit code
727         https://bugs.webkit.org/show_bug.cgi?id=195255
728
729         Reviewed by Darin Adler.
730
731         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
732         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
733         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
734         (NPP_New):
735         (NPP_HandleEvent):
736         (handleEventCarbon): Deleted.
737
738 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
739
740         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
741
742         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
743         (TestWebKitAPI::TEST):
744
745 2019-03-01  Darin Adler  <darin@apple.com>
746
747         Finish removing String::format
748         https://bugs.webkit.org/show_bug.cgi?id=194893
749
750         Reviewed by Daniel Bates.
751 '
752         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
753
754 2019-03-01  Alex Christensen  <achristensen@webkit.org>
755
756         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
757         https://bugs.webkit.org/show_bug.cgi?id=195229
758         <rdar://problem/48520362>
759
760         Reviewed by Chris Dumez.
761
762         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
763         (TEST):
764
765 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
766
767         Add a system trace scope for event region building
768         https://bugs.webkit.org/show_bug.cgi?id=195226
769
770         Reviewed by Jon Lee.
771
772         This trace scope measures the time spend converting element rects into Region objects,
773         which can be large on some pages.
774
775         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
776
777         * Tracing/SystemTracePoints.plist:
778
779 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
780
781         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
782         https://bugs.webkit.org/show_bug.cgi?id=194612
783
784         Reviewed by Alex Christensen.
785
786         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
787         Just test the new string-processing function and don't touch the actual environment.
788         (Test cases are all as before, but based on operator== instead of strcmp.)
789
790 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
791
792         [ews-app] Update primary keys for handling multiple Buildbot instances
793         https://bugs.webkit.org/show_bug.cgi?id=195120
794
795         Reviewed by Stephanie Lewis.
796
797         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
798         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
799         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
800
801         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
802         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
803         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
804         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
805         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
806         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
807
808 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
809
810         [WinCairo] Enable service worker
811         https://bugs.webkit.org/show_bug.cgi?id=188318
812
813         Reviewed by Youenn Fablet.
814
815         * DumpRenderTree/DumpRenderTreePrefix.h:
816         * TestWebKitAPI/PlatformWin.cmake:
817         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
818         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
819         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
820
821 2019-03-01  Justin Fan  <justin_fan@apple.com>
822
823         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
824         https://bugs.webkit.org/show_bug.cgi?id=195191
825
826         Rubber-stamped by Dean Jackson.
827
828         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
829
830         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
831
832 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
833
834         Unreviewed, fix lldb webkitpy tests
835         https://bugs.webkit.org/show_bug.cgi?id=194375
836
837         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
838
839         * lldb/lldb_webkit.py:
840         (WTFStringImplProvider.is_8bit):
841
842 2019-02-28  David Quesada  <david_quesada@apple.com>
843
844         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
845         https://bugs.webkit.org/show_bug.cgi?id=195121
846         rdar://problem/48450302
847
848         Reviewed by Alex Christensen.
849
850         Add API tests for -WKNavigationAction._shouldPerformDownload in various
851         configurations where the 'download' attribute is absent, blank, or populated
852         with a filename, and where the anchor element is same-origin or cross-origin
853         (meaning the 'download' attribute shouldn't be honored).
854
855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
856         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
857         (-[NavigationActionTestDelegate init]):
858         (-[NavigationActionTestDelegate navigationAction]):
859         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
860         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
861         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
862         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
863         (TEST):
864
865 2019-02-28  Antoine Quint  <graouts@apple.com>
866
867         Enable the Pointer Events runtime flag by default
868         https://bugs.webkit.org/show_bug.cgi?id=195156
869
870         Reviewed by Dean Jackson.
871
872         * DumpRenderTree/mac/DumpRenderTree.mm:
873         (enableExperimentalFeatures):
874
875 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
876
877         Several PasteImage API tests are flaky
878         https://bugs.webkit.org/show_bug.cgi?id=195160
879
880         Reviewed by Tim Horton.
881
882         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
883         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
884         listening for a "load" event after image load is already complete.
885
886         To address this, make these tests first register a "load" event handler, then run script to insert an image
887         element into the document, and finally wait until the load event is observed before checking image size.
888
889         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
890
891 2019-02-28  Chris Dumez  <cdumez@apple.com>
892
893         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
894         https://bugs.webkit.org/show_bug.cgi?id=195107
895
896         Reviewed by Alex Christensen.
897
898         Give some time for the zoom level to get restored.
899
900         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
901
902 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
903
904         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
905         https://bugs.webkit.org/show_bug.cgi?id=194958
906
907         Reviewed by Geoffrey Garen.
908
909         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
910         (TEST):
911
912 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
913
914         [ews-app] Update method to save build to handle builder_display_name
915         https://bugs.webkit.org/show_bug.cgi?id=195047
916
917         Reviewed by Dewei Zhu.
918
919         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
920         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
921
922 2019-02-28  Justin Fan  <justin_fan@apple.com>
923
924         [Web GPU] Enable Web GPU only on 64-bit
925         https://bugs.webkit.org/show_bug.cgi?id=195139
926
927         Because Metal is only supported on 64 bit apps.
928
929         Unreviewed build fix.
930
931         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
932
933 2019-02-27  Youenn Fablet  <youenn@apple.com>
934
935         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
936         https://bugs.webkit.org/show_bug.cgi?id=194959
937
938         Reviewed by Chris Dumez.
939
940         Spin loop until getting the condition to remove flakiness.
941
942         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
943
944 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
945
946         [ews-build] Buildbot should include builder_display_name in the build events
947         https://bugs.webkit.org/show_bug.cgi?id=195045
948
949         Reviewed by Dewei Zhu.
950
951         * BuildSlaveSupport/ews-build/events.py:
952         (Events.buildStarted): Included builder_display_name in event data. Also renamed
953         buildername to builder_name to be consistent in naming style.
954         (Events.buildFinished): Ditto.
955
956 2019-02-27  Chris Dumez  <cdumez@apple.com>
957
958         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
959         https://bugs.webkit.org/show_bug.cgi?id=194480
960
961         Reviewed by Brady Eidson.
962
963         Update existing API test to make it more likely to reproduce the issue.
964
965         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
966
967 2019-02-27  Brady Eidson  <beidson@apple.com>
968
969         Universal links from Google search results pages don't open the app.
970         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
971
972         Reviewed by Geoffrey Garen.
973
974         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
975         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
976         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
977         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
978
979 2019-02-27  Chris Dumez  <cdumez@apple.com>
980
981         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
982         https://bugs.webkit.org/show_bug.cgi?id=195102
983
984         Reviewed by Geoffrey Garen.
985
986         If the number of processes is not yet what we expect, wait a bit and check again to give
987         processes some time to exit.
988
989         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
990
991 2019-02-27  Chris Dumez  <cdumez@apple.com>
992
993         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
994         https://bugs.webkit.org/show_bug.cgi?id=194545
995
996         Reviewed by Brady Eidson.
997
998         Make sure the test navigates forward and then back only once. Previously, navigating
999         back would trigger a navigation again in a timer.
1000
1001         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1002
1003 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
1004
1005         High Sierra Debug JSC test queue should use faster hardware
1006         https://bugs.webkit.org/show_bug.cgi?id=194603
1007
1008         Rubber-stamped by Alexey Proskuryakov.
1009
1010         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
1011
1012         * BuildSlaveSupport/build.webkit.org-config/config.json:
1013         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1014         (BubbleQueueServer):
1015         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1016         (WebKitBuildbot):
1017         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1018         * QueueStatusServer/config/queues.py:
1019         * Scripts/webkitpy/common/config/ews.json:
1020         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1021         (test_ews_name):
1022
1023 2019-02-27  John Wilander  <wilander@apple.com>
1024
1025         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
1026         https://bugs.webkit.org/show_bug.cgi?id=195071
1027         <rdar://problem/48417690>
1028
1029         Reviewed by Alex Christensen and Brent Fulgham.
1030
1031         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1032         (TestWebKitAPI::createURL):
1033             Convenience function.
1034         (TestWebKitAPI::TEST):
1035             WebCore::AdClickAttribution now takes a URL when creating Source and
1036             Destination.
1037         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1038         (TestWebKitAPI::TEST):
1039             WebCore::AdClickAttribution now takes a URL when creating Source and
1040             Destination.
1041
1042 2019-02-27  Antoine Quint  <graouts@apple.com>
1043
1044         Support Pointer Events on macOS
1045         https://bugs.webkit.org/show_bug.cgi?id=195008
1046         <rdar://problem/47454419>
1047
1048         Reviewed by Dean Jackson.
1049
1050         * DumpRenderTree/mac/DumpRenderTree.mm:
1051         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
1052         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1053
1054 2019-02-26  Mark Lam  <mark.lam@apple.com>
1055
1056         Remove remaining poisoning code.
1057         https://bugs.webkit.org/show_bug.cgi?id=194138
1058
1059         Reviewed by Saam Barati.
1060
1061         * TestWebKitAPI/CMakeLists.txt:
1062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1063         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
1064         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
1065         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
1066         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
1067         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
1068         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
1069
1070 2019-02-26  Alex Christensen  <achristensen@webkit.org>
1071
1072         Move ephemeral local storage from WebProcess to UIProcess
1073         https://bugs.webkit.org/show_bug.cgi?id=195074
1074         <rdar://problem/47937975>
1075
1076         Reviewed by Geoff Garen.
1077
1078         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1079
1080 2019-02-20  Jer Noble  <jer.noble@apple.com>
1081
1082         [Cocoa] Media elements will restart network buffering just before suspending
1083         https://bugs.webkit.org/show_bug.cgi?id=193691
1084
1085         Reviewed by Eric Carlson.
1086
1087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1088         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1089         (TEST):
1090
1091 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
1092
1093         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
1094         https://bugs.webkit.org/show_bug.cgi?id=191652
1095
1096         Reviewed by Alex Christensen.
1097
1098         Fix WinCairo MiniBrowser behavior of authentication dialog.
1099
1100         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1101         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1102
1103 2019-02-26  Youenn Fablet  <youenn@apple.com>
1104
1105         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
1106         https://bugs.webkit.org/show_bug.cgi?id=195028
1107         <rdar://problem/48243733>
1108
1109         Reviewed by Eric Carlson.
1110
1111         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1112
1113 2019-02-26  Philippe Normand  <pnormand@igalia.com>
1114
1115         [WPE] Add API for webview background color configuration
1116         https://bugs.webkit.org/show_bug.cgi?id=192305
1117
1118         Reviewed by Michael Catanzaro.
1119
1120         * MiniBrowser/wpe/main.cpp:
1121         (main): Add a new option to configure the webview background
1122         color. Example: --bg-color=transparent.
1123         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1124         (testWebViewBackgroundColor): Enable background color API tests for WPE.
1125         (beforeAll): Ditto.
1126
1127 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
1128
1129         scalableNativeWebpageParameters() is not preserved on new page navigation.
1130         https://bugs.webkit.org/show_bug.cgi?id=194892
1131         <rdar://problem/47538280>
1132
1133         Reviewed by Wenson Hsieh.
1134         
1135         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
1136
1137         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1138         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1139         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1140         (WTR::UIScriptController::allowsViewportShrinkToFit):
1141         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1142         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1143         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1144         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1145         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1146         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1147
1148 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1149
1150         [ews-app] Add model for handling multiple Buildbot instances
1151         https://bugs.webkit.org/show_bug.cgi?id=194863
1152
1153         Reviewed by Stephanie Lewis.
1154
1155         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
1156
1157 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1158
1159         [ews-app] Remove BuilderMapping table
1160         https://bugs.webkit.org/show_bug.cgi?id=194961
1161
1162         Reviewed by Stephanie Lewis.
1163
1164         Store builder name directly in build table, instead of having a separate
1165         table for it.
1166
1167         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1168         * BuildSlaveSupport/ews-app/ews/models/build.py:
1169         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
1170         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1171
1172 2019-02-25  John Wilander  <wilander@apple.com>
1173
1174         Introduce and adopt new class RegistrableDomain for eTLD+1
1175         https://bugs.webkit.org/show_bug.cgi?id=194791
1176         <rdar://problem/48179240>
1177
1178         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
1179
1180         This patch adds an API test and replaces two instances of
1181         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
1182
1183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1184         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1185         (TestWebKitAPI::TEST):
1186             Changed two strings to make sure the registrable domains are still considered
1187             invalid and pass the test.
1188         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
1189         (TestWebKitAPI::TEST):
1190         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1191         (WTR::InjectedBundle::didReceiveMessageToPage):
1192
1193 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
1194
1195         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
1196         https://bugs.webkit.org/show_bug.cgi?id=195001
1197
1198         Reviewed by Carlos Garcia Campos.
1199
1200         API version 1.0 always includes the functionality previously guarded with
1201         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
1202         unconditionally.
1203
1204         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1205         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
1206         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
1207         (WebViewTest::showInWindow): Ditto.
1208         (WebViewTest::hideView): Ditto.
1209         * wpe/backends/HeadlessViewBackend.cpp:
1210         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
1211         * wpe/backends/ViewBackend.cpp:
1212         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
1213         * wpe/backends/WindowViewBackend.cpp:
1214         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
1215         WPE_BACKEND_CHECK_VERSION().
1216         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
1217
1218 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
1219
1220         [Flatpak] Add support for flatpak > 1.1.2
1221         https://bugs.webkit.org/show_bug.cgi?id=194088
1222
1223         Flatpak 1.2 is now out so we need to support that
1224         version now.
1225
1226         Reviewed by Michael Catanzaro.
1227
1228         * flatpak/flatpakutils.py:
1229         (check_flatpak):
1230         (FlatpakPackages.__init__):
1231         (FlatpakPackages.__detect_packages):
1232         (FlatpakPackages.__detect_packages.in):
1233         (FlatpakRepos.update):
1234
1235 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
1236
1237         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
1238         https://bugs.webkit.org/show_bug.cgi?id=194998
1239
1240         Reviewed by Carlos Garcia Campos.
1241
1242         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
1243         to a Git checkout and using the latest commit containing various fixes
1244         and improvements.
1245
1246 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1247
1248         [WPE][GTK] Remove user agent quirk for washingtonpost.com
1249         https://bugs.webkit.org/show_bug.cgi?id=194981
1250
1251         Reviewed by Žan Doberšek.
1252
1253         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1254         (TestWebKitAPI::TEST):
1255
1256 2019-02-23  Keith Miller  <keith_miller@apple.com>
1257
1258         Add new mac target numbers
1259         https://bugs.webkit.org/show_bug.cgi?id=194955
1260
1261         Reviewed by Tim Horton.
1262
1263         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1264         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1265         * MiniBrowser/Configurations/Base.xcconfig:
1266         * TestWebKitAPI/Configurations/Base.xcconfig:
1267         * WebKitTestRunner/Configurations/Base.xcconfig:
1268
1269 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1270
1271         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1272         https://bugs.webkit.org/show_bug.cgi?id=194846
1273
1274         Reviewed by Don Olmstead.
1275
1276         Added _search_paths() and _port_specific_expectations_files() for
1277         WinCairoPort.
1278
1279         * Scripts/webkitpy/port/win.py:
1280         (WinCairoPort.default_baseline_search_path):
1281         (WinCairoPort):
1282         (WinCairoPort._port_specific_expectations_files):
1283         (WinCairoPort._search_paths):
1284
1285 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1286
1287         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1288         https://bugs.webkit.org/show_bug.cgi?id=194963
1289
1290         Reviewed by Dean Jackson.
1291
1292         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1293         Do a `contains` check instead of `equals`, because in debug builds we
1294         put the GraphicsLayer pointer in a prefix.
1295
1296 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1297
1298         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1299         https://bugs.webkit.org/show_bug.cgi?id=194873
1300         <rdar://problem/46701974>
1301
1302         Reviewed by Tim Horton.
1303
1304         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1305
1306         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1307         (WTR::UIScriptController::menuRect const):
1308         (WTR::UIScriptController::isShowingMenu const):
1309         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1310         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1311         (WTR::UIScriptController::menuRect const):
1312
1313         Add a function to query the bounds of the callout menu in content coordinates.
1314
1315         (WTR::UIScriptController::isShowingMenu const):
1316
1317         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1318
1319         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1320         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1321         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1322         (WTR::UIScriptController::rectForMenuAction const):
1323         (WTR::UIScriptController::menuRect const):
1324         (WTR::UIScriptController::isShowingMenu const):
1325         (WTR::findViewInHierarchyOfType): Deleted.
1326
1327 2019-02-22  Chris Dumez  <cdumez@apple.com>
1328
1329         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1330         https://bugs.webkit.org/show_bug.cgi?id=194954
1331         <rdar://problem/48127957>
1332
1333         Reviewed by Alex Christensen.
1334
1335         Add API test coverage.
1336
1337         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1338         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1339         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1340         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1341
1342 2019-02-22  Chris Dumez  <cdumez@apple.com>
1343
1344         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1345         https://bugs.webkit.org/show_bug.cgi?id=194924
1346         <rdar://problem/48216125>
1347
1348         Reviewed by Geoffrey Garen.
1349
1350         Add API test coverage.
1351
1352         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1353
1354 2019-02-22  Chris Dumez  <cdumez@apple.com>
1355
1356         Unreviewed, disable API test added in r241928 on iOS.
1357
1358         The cache is not enabled on devices with less than 3GB of RAM.
1359
1360         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1361
1362 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1363
1364         Hardcode Visual Viewports on everywhere except iOS WK1
1365         https://bugs.webkit.org/show_bug.cgi?id=194928
1366
1367         Reviewed by Zalan Bujtas.
1368
1369         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1370         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1371         set it to false. The setting has shipped for several years and there's no need to turn
1372         it off now.
1373
1374         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1375         Visual Viewports are not enabled.
1376         
1377         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1378         that only runs in WK2
1379
1380         * MiniBrowser/mac/SettingsController.h:
1381         * MiniBrowser/mac/SettingsController.m:
1382         (-[SettingsController init]):
1383         (-[SettingsController _populateMenu]):
1384         (-[SettingsController validateMenuItem:]):
1385         (-[SettingsController visualViewportEnabled]): Deleted.
1386         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1387         * MiniBrowser/mac/WK1BrowserWindowController.m:
1388         (-[WK1BrowserWindowController didChangeSettings]):
1389         * MiniBrowser/mac/WK2BrowserWindowController.m:
1390         (-[WK2BrowserWindowController didChangeSettings]):
1391
1392 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1393
1394         Discard cached processes when clearing website data store
1395         https://bugs.webkit.org/show_bug.cgi?id=194894
1396
1397         Reviewed by Chris Dumez.
1398
1399         Added a test case.
1400
1401         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1402         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1403
1404 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1405
1406         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1407         https://bugs.webkit.org/show_bug.cgi?id=194914
1408         <rdar://problem/47586889>
1409
1410         Reviewed by Geoffrey Garen.
1411
1412         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1413         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1414         (TEST):
1415         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1416
1417 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1418
1419         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1420         <https://webkit.org/b/194761>
1421
1422         Reviewed by Myles Maxfield.
1423
1424         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1425         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1426         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1427         to use ARC-compliant cast.
1428         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1429         ARC-compliant cast.
1430         (WTR::installFakeHelvetica): Log `error` to console if
1431         CTFontManagerRegisterFontsForURL() fails, but only on supported
1432         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1433         Call CFRelease() on `error` to fix the leak.  Update to use
1434         ARC-compliant cast.
1435         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1436         cast.
1437
1438 2019-02-21  Chris Dumez  <cdumez@apple.com>
1439
1440         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1441         https://bugs.webkit.org/show_bug.cgi?id=194481
1442
1443         Reviewed by Alex Christensen.
1444
1445         Give the processes a chance to shutdown and wait until we reached the expected number
1446         of processes.
1447
1448         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1449
1450 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1451
1452         Fix the macOS build
1453
1454         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1455
1456 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1457
1458         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1459
1460         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1461         I am a backwards.
1462
1463 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1464
1465         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1466
1467         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1468         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1469         We could force on UI-side compositing, but I feel like the test might be more
1470         valuable exercising the normal path on each platform (though the original
1471         bug was also UI-side specific). Though we can't validate that the overlay
1472         layer was installed successfully, there are layout tests that do that.
1473
1474 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1475
1476         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1477         https://bugs.webkit.org/show_bug.cgi?id=194845
1478         <rdar://problem/47944579>
1479
1480         Reviewed by Antti Koivisto.
1481
1482         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1483         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1484
1485 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1486
1487         [LFC][Floats] Add support for placing formatting roots in-between floats.
1488         https://bugs.webkit.org/show_bug.cgi?id=194902
1489
1490         Reviewed by Antti Koivisto.
1491
1492         * LayoutReloaded/misc/LFC-passing-tests.txt:
1493
1494 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1495
1496         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1497         https://bugs.webkit.org/show_bug.cgi?id=194901
1498
1499         Unreviewed build fix.
1500
1501         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1502         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1503         WPEBackend-fdo-0.1 as library name.
1504
1505 2019-02-21  Rob Buis  <rbuis@igalia.com>
1506
1507         Update MIME type parser
1508         https://bugs.webkit.org/show_bug.cgi?id=180526
1509
1510         Reviewed by Darin Adler.
1511
1512         Add tests involving leading and trailing whitespace, non-token
1513         characters and quoted strings.
1514
1515         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1516         (TestWebKitAPI::TEST):
1517
1518 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1519
1520         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1521         https://bugs.webkit.org/show_bug.cgi?id=194884
1522
1523         Reviewed by Michael Catanzaro.
1524
1525         * PlatformWin.cmake:
1526
1527 2019-02-20  Chris Dumez  <cdumez@apple.com>
1528
1529         Add API test for <rdar://problem/47471222>
1530         https://bugs.webkit.org/show_bug.cgi?id=194847
1531
1532         Reviewed by Alex Christensen.
1533
1534         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1535
1536 2019-02-20  Chris Dumez  <cdumez@apple.com>
1537
1538         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1539         https://bugs.webkit.org/show_bug.cgi?id=194872
1540         <rdar://problem/47924500>
1541
1542         Reviewed by Alex Christensen.
1543
1544         Add API test coverage.
1545
1546         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1547
1548 2019-02-20  Jer Noble  <jer.noble@apple.com>
1549
1550         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1551         https://bugs.webkit.org/show_bug.cgi?id=191332
1552
1553         Reviewed by Dean Jackson.
1554
1555         * Scripts/git-is-in-range: Added.
1556
1557 2019-02-20  Andy Estes  <aestes@apple.com>
1558
1559         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1560         https://bugs.webkit.org/show_bug.cgi?id=194869
1561
1562         Rubber-stamped by Jer Noble.
1563
1564         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1565         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1566         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1567         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1568         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1569         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1570
1571 2019-02-20  Chris Dumez  <cdumez@apple.com>
1572
1573         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1574         https://bugs.webkit.org/show_bug.cgi?id=194857
1575         <rdar://problem/47759323>
1576
1577         Reviewed by Alex Christensen.
1578
1579         Add API test coverage.
1580
1581         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1582
1583 2019-02-20  Chris Dumez  <cdumez@apple.com>
1584
1585         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1586         https://bugs.webkit.org/show_bug.cgi?id=194829
1587         <rdar://problem/47889906>
1588
1589         Reviewed by Alexey Proskuryakov.
1590
1591         Every time the TestOptions were changing we were creating both a new Web view and
1592         a new WKContext, which would start a new Network process. In most cases, we only
1593         need to contruct a new Web view and we do can keep reusing the same WKContext.
1594         This patch implements this optimization and thus avoids spinning a lot of new
1595         Network processes while running the layout tests.
1596
1597         * WebKitTestRunner/TestController.cpp:
1598         (WTR::TestController::generateContextConfiguration const):
1599         (WTR::TestController::generatePageConfiguration):
1600         (WTR::TestController::createWebViewWithOptions):
1601         (WTR::TestController::resetPreferencesToConsistentValues):
1602         (WTR::updateTestOptionsFromTestHeader):
1603         * WebKitTestRunner/TestController.h:
1604         * WebKitTestRunner/TestOptions.h:
1605         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1606         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1607         (WTR::TestOptions::hasSameInitializationOptions const):
1608         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1609         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1610         (WTR::TestController::platformAddTestOptions const):
1611
1612 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1613
1614         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1615         https://bugs.webkit.org/show_bug.cgi?id=167941
1616
1617         Reviewed by Carlos Garcia Campos.
1618
1619         * MiniBrowser/gtk/main.c:
1620         (filterSavedCallback): Added.
1621         (main): Support loading a JSON rule set file for content filtering.
1622         * MiniBrowser/wpe/main.cpp:
1623         (filterSavedCallback): Added.
1624         (main): Support loading a JSON rule set file for content filtering.
1625         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1626         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1627         (WTF::derefGPtr): Ditto.
1628         (testEmptyStore):
1629         (testSaveInvalidFilter):
1630         (testSaveLoadFilter):
1631         (testSavedFilterIdentifierMatch):
1632         (testRemoveFilter):
1633         (testSaveMultipleFilters):
1634         (testSaveFilterFromFile):
1635         (testFilterPersistence):
1636         (beforeAll):
1637         (afterAll):
1638         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1639         (removeOldInjectedContentAndResetLists): Also reset content filters.
1640         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1641         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1642         the element affected by the style sheet.
1643         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1644         and returns it to be used by tests.
1645         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1646         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1647         (serverCallback): Add support for serving a CSS style sheet for testing.
1648         (beforeAll): Add call to testUserContentManagerContentFilter().
1649         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1650
1651 2019-02-19  Keith Rollin  <krollin@apple.com>
1652
1653         Add timing information to build output
1654         https://bugs.webkit.org/show_bug.cgi?id=194839
1655         <rdar://problem/48219609>
1656
1657         Reviewed by Alexey Proskuryakov.
1658
1659         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1660         emit each project's build time to its output. E.g.,
1661
1662             ** BUILD SUCCEEDED ** [0.132 sec]
1663
1664         * Scripts/webkitdirs.pm:
1665         (XcodeOptions):
1666
1667 2019-02-19  Truitt Savell  <tsavell@apple.com>
1668
1669         Unreviewed, rolling out r241784.
1670
1671         Broke all OpenSource builds.
1672
1673         Reverted changeset:
1674
1675         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1676         instances view"
1677         https://bugs.webkit.org/show_bug.cgi?id=172848
1678         https://trac.webkit.org/changeset/241784
1679
1680 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1681
1682         [LFC][Floats] Remove redundant intersecting logic
1683         https://bugs.webkit.org/show_bug.cgi?id=194804
1684
1685         Reviewed by Antti Koivisto.
1686
1687         * LayoutReloaded/misc/LFC-passing-tests.txt:
1688
1689 2019-02-19  Dean Jackson  <dino@apple.com>
1690
1691         Clean-up output from generate-xcfilelists so it can be filtered
1692         https://bugs.webkit.org/show_bug.cgi?id=194795
1693
1694         Reviewed by Joseph Pecoraro (and Keith Rollin).
1695
1696         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1697         make a slight tweak to filter-build-webkit so such lines are marked
1698         as plain.
1699
1700         * Scripts/filter-build-webkit:
1701         * Scripts/generate-xcfilelists:
1702
1703 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1704
1705         pytest is not correctly auto-installed
1706         https://bugs.webkit.org/show_bug.cgi?id=194707
1707
1708         Reviewed by Carlos Garcia Campos.
1709
1710         * Scripts/webkitpy/thirdparty/__init__.py:
1711         (AutoinstallImportHook._install_pytest):
1712
1713 2019-02-18  Chris Dumez  <cdumez@apple.com>
1714
1715         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1716         https://bugs.webkit.org/show_bug.cgi?id=194797
1717         <rdar://problem/48055151>
1718
1719         Reviewed by Geoffrey Garen.
1720
1721         Add API test coverage.
1722
1723         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1724
1725 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1726
1727         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1728         https://bugs.webkit.org/show_bug.cgi?id=194670
1729         <rdar://problem/39066529>
1730
1731         Reviewed by Tim Horton.
1732
1733         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1734         pasted in an editable area as attachment elements.
1735
1736         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1737         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1738         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1739         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1740         (TestWebKitAPI::TEST):
1741         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1742         (WTR::InjectedBundlePage::InjectedBundlePage):
1743
1744 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1745
1746         Fix API test after r241728
1747        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1748
1749         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1750         (TEST):
1751         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1752
1753 2019-02-18  Daniel Bates  <dabates@apple.com>
1754
1755         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1756         https://bugs.webkit.org/show_bug.cgi?id=192824
1757         <rdar://problem/47100332>
1758
1759         Reviewed by Wenson Hsieh.
1760
1761         Fix a bug where the wrong usage code was used for F13 thru F24.
1762
1763         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1764         (keyCodeForDOMFunctionKey):
1765
1766 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1767
1768         Bytecode cache should a have a boot-specific validation
1769         https://bugs.webkit.org/show_bug.cgi?id=194769
1770         <rdar://problem/48149509>
1771
1772         Reviewed by Keith Miller.
1773
1774         Add test for WTF::bootSessionUUIDString()
1775
1776         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1777         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1778         (TEST):
1779
1780 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1781
1782         Disable safe browsing in WKWebView and remove its WKPreferences API
1783         https://bugs.webkit.org/show_bug.cgi?id=194723
1784         <rdar://problem/48122993>
1785
1786         Reviewed by Geoffrey Garen.
1787
1788         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1789         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1790         (TEST):
1791         (safeBrowsingView):
1792         Make tests use SPI instead of API.
1793
1794 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1795
1796         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1797         https://bugs.webkit.org/show_bug.cgi?id=194586
1798
1799         Reviewed by Ross Kirsling.
1800
1801         * DumpRenderTree/win/DumpRenderTree.cpp:
1802         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1803         * Scripts/webkitpy/port/driver.py:
1804         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1805
1806 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1807
1808         Unreviewed, rolling out r241620.
1809
1810         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1811         (Requested by ddkilzer on #webkit.)
1812
1813         Reverted changeset:
1814
1815         "[WTF] Add environment variable helpers"
1816         https://bugs.webkit.org/show_bug.cgi?id=192405
1817         https://trac.webkit.org/changeset/241620
1818
1819 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1820
1821         [LFC] RenderImage's default intrinsic size is 0.
1822         https://bugs.webkit.org/show_bug.cgi?id=194745
1823
1824         Reviewed by Antti Koivisto.
1825
1826         * LayoutReloaded/misc/LFC-passing-tests.txt:
1827
1828 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1829
1830         [LFC][BFC] Add support for block replaced intrinsic width.
1831         https://bugs.webkit.org/show_bug.cgi?id=194705
1832
1833         Reviewed by Simon Fraser.
1834
1835         * LayoutReloaded/misc/LFC-passing-tests.txt:
1836
1837 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1838
1839         [LFC] Apply min/max width constraints to preferred width computation
1840         https://bugs.webkit.org/show_bug.cgi?id=194739
1841
1842         Reviewed by Simon Fraser.
1843
1844         * LayoutReloaded/misc/LFC-passing-tests.txt:
1845
1846 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1847
1848         [WTF] Add environment variable helpers
1849         https://bugs.webkit.org/show_bug.cgi?id=192405
1850
1851         Reviewed by Michael Catanzaro.
1852
1853         * DumpRenderTree/mac/DumpRenderTree.mm:
1854         (libraryPathForDumpRenderTree):
1855         * DumpRenderTree/win/DumpRenderTree.cpp:
1856         (libraryPathForDumpRenderTree):
1857         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1858         (setUpIOSLayoutTestCommunication):
1859         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1860         (beforeAll):
1861         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1862         (main):
1863         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1864         (WebKitTestBus::run):
1865         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1866         (WTR::getOutputDir):
1867         (WTR::initializeFontConfigSetting):
1868         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1869         (WTR::InjectedBundle::platformInitialize):
1870         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1871         (WTR::topLevelPath):
1872         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1873         (WTR::topLevelPath):
1874         (WTR::getOutputDir):
1875         (WTR::activateFonts):
1876         * WebKitTestRunner/TestController.cpp:
1877         (WTR::TestController::libraryPathForTesting):
1878         (WTR::TestController::generateContextConfiguration const):
1879         (WTR::TestController::generatePageConfiguration):
1880         (WTR::TestController::decideDestinationWithSuggestedFilename):
1881         (WTR::TestController::platformAdjustContext):
1882         * WebKitTestRunner/TestController.h:
1883         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1884         (WTR::TestController::cocoaPlatformInitialize):
1885         (WTR::TestController::platformAdjustContext):
1886         * WebKitTestRunner/gtk/main.cpp:
1887         (main):
1888         * WebKitTestRunner/mac/TestControllerMac.mm:
1889         (WTR::TestController::configureContentExtensionForTest):
1890         * WebKitTestRunner/wpe/main.cpp:
1891         (main):
1892         Utilize WTF::Environment where possible.
1893
1894 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1895
1896         [iOS] WKWebView callout bar is missing Change Writing Direction item
1897         https://bugs.webkit.org/show_bug.cgi?id=190015
1898         <rdar://problem/44810366>
1899
1900         Reviewed by Tim Horton.
1901
1902         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1903         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1904
1905         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1906         (TestWebKitAPI::TEST):
1907
1908 2019-02-15  Chris Dumez  <cdumez@apple.com>
1909
1910         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1911         https://bugs.webkit.org/show_bug.cgi?id=194717
1912         <rdar://problem/47884404>
1913
1914         Reviewed by Brady Eidson.
1915
1916         Add API test coverage.
1917
1918         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1919
1920 2019-02-15  Youenn Fablet  <youenn@apple.com>
1921
1922         Make navigator.mediaDevices SecureContext
1923         https://bugs.webkit.org/show_bug.cgi?id=194666
1924
1925         Reviewed by Eric Carlson.
1926
1927         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1928         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1929         (TEST_F):
1930
1931 2019-02-15  Brian Burg  <bburg@apple.com>
1932
1933         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1934         https://bugs.webkit.org/show_bug.cgi?id=194411
1935         <rdar://problem/47787614>
1936
1937         Reviewed by Joseph Pecoraro.
1938
1939         Remove unnecessary soft linking macro usage.
1940
1941         * DumpRenderTree/mac/TestRunnerMac.mm:
1942         (TestRunner::inspectorTestStubURL):
1943         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1944         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1945         (WTR::TestRunner::inspectorTestStubURL):
1946
1947 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1948
1949         Unreviewed, rolling out r241559 and r241566.
1950         https://bugs.webkit.org/show_bug.cgi?id=194710
1951
1952         Causes layout test crashes under GuardMalloc (Requested by
1953         ryanhaddad on #webkit).
1954
1955         Reverted changesets:
1956
1957         "[WTF] Add environment variable helpers"
1958         https://bugs.webkit.org/show_bug.cgi?id=192405
1959         https://trac.webkit.org/changeset/241559
1960
1961         "Unreviewed build fix for WinCairo Debug after r241559."
1962         https://trac.webkit.org/changeset/241566
1963
1964 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1965
1966         [LFC] Out-of-flow box is never a float box
1967         https://bugs.webkit.org/show_bug.cgi?id=194704
1968
1969         Reviewed by Antti Koivisto.
1970
1971         * LayoutReloaded/misc/LFC-passing-tests.txt:
1972
1973 2019-02-10  Darin Adler  <darin@apple.com>
1974
1975         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1976         https://bugs.webkit.org/show_bug.cgi?id=194487
1977
1978         Reviewed by Daniel Bates.
1979
1980         * DumpRenderTree/win/DumpRenderTree.cpp:
1981         (applicationId): Use makeString instead of String::format.
1982         (main): Ditto.
1983         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1984         (TestWebKitAPI::Util::createURLForResource): Ditto.
1985         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1986         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1987
1988         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1989         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1990         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1991         (WTR::createStringWithAttributes): Use appendLiteral.
1992         (WTR::AccessibilityUIElement::helpText const): Ditto.
1993         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1994         directly instead of using String::format.
1995         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1996         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1997
1998 2019-02-15  Truitt Savell  <tsavell@apple.com>
1999
2000         Unreviewed, rolling out r241564.
2001
2002         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
2003
2004         Reverted changeset:
2005
2006         "[Mac] WebInspectorUI.framework does not need to be soft-
2007         linked anymore"
2008         https://bugs.webkit.org/show_bug.cgi?id=194411
2009         https://trac.webkit.org/changeset/241564
2010
2011 2019-02-15  Saam barati  <sbarati@apple.com>
2012
2013         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
2014         https://bugs.webkit.org/show_bug.cgi?id=194036
2015
2016         Reviewed by Yusuke Suzuki.
2017
2018         * Scripts/run-jsc-stress-tests:
2019
2020 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2021
2022         Fix the build.
2023
2024         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2025         (WTR::UIScriptController::drawSquareInEditableImage):
2026         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2027         (TestWebKitAPI::drawSquareInEditableImage):
2028
2029 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2030
2031         Fix the build.
2032
2033         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2034         (WTR::UIScriptController::drawSquareInEditableImage):
2035         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2036         (TestWebKitAPI::drawSquareInEditableImage):
2037
2038 2019-02-14  Brian Burg  <bburg@apple.com>
2039
2040         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2041         https://bugs.webkit.org/show_bug.cgi?id=194411
2042         <rdar://problem/47787614>
2043
2044         Reviewed by Joseph Pecoraro.
2045
2046         Remove unnecessary soft linking macro usage.
2047
2048         * DumpRenderTree/mac/TestRunnerMac.mm:
2049         (TestRunner::inspectorTestStubURL):
2050         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2051         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2052         (WTR::TestRunner::inspectorTestStubURL):
2053
2054 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2055
2056         [ews-app] status bubble should fetch builder name info from BuilderMapping table
2057         https://bugs.webkit.org/show_bug.cgi?id=194599
2058
2059         Reviewed by Lucas Forschler.
2060
2061         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2062         (StatusBubble._build_bubble):
2063
2064 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2065
2066         [ews-app] Set Foreign Key in Django build model
2067         https://bugs.webkit.org/show_bug.cgi?id=194667
2068
2069         Reviewed by Lucas Forschler.
2070
2071         * BuildSlaveSupport/ews-app/ews/models/build.py:
2072         (Build):
2073
2074 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
2075
2076         [WTF] Add environment variable helpers
2077         https://bugs.webkit.org/show_bug.cgi?id=192405
2078
2079         Reviewed by Michael Catanzaro.
2080
2081         * DumpRenderTree/mac/DumpRenderTree.mm:
2082         (libraryPathForDumpRenderTree):
2083         * DumpRenderTree/win/DumpRenderTree.cpp:
2084         (libraryPathForDumpRenderTree):
2085         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2086         (setUpIOSLayoutTestCommunication):
2087         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2088         (TestWebKitAPI::strip):
2089         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2090         (beforeAll):
2091         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2092         (main):
2093         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2094         (WebKitTestBus::run):
2095         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2096         (WTR::getOutputDir):
2097         (WTR::initializeFontConfigSetting):
2098         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2099         (WTR::InjectedBundle::platformInitialize):
2100         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2101         (WTR::topLevelPath):
2102         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2103         (WTR::topLevelPath):
2104         (WTR::getOutputDir):
2105         (WTR::activateFonts):
2106         * WebKitTestRunner/TestController.cpp:
2107         (WTR::TestController::libraryPathForTesting):
2108         (WTR::TestController::generateContextConfiguration const):
2109         (WTR::TestController::generatePageConfiguration):
2110         (WTR::TestController::decideDestinationWithSuggestedFilename):
2111         (WTR::TestController::platformAdjustContext):
2112         * WebKitTestRunner/TestController.h:
2113         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2114         (WTR::TestController::cocoaPlatformInitialize):
2115         (WTR::TestController::platformAdjustContext):
2116         * WebKitTestRunner/gtk/main.cpp:
2117         (main):
2118         * WebKitTestRunner/mac/TestControllerMac.mm:
2119         (WTR::TestController::configureContentExtensionForTest):
2120         * WebKitTestRunner/wpe/main.cpp:
2121         (main):
2122         Utilize WTF::Environment where possible.
2123
2124 2019-02-14  Chris Dumez  <cdumez@apple.com>
2125
2126         [PSON] Introduce a WebContent Process cache
2127         https://bugs.webkit.org/show_bug.cgi?id=194594
2128         <rdar://problem/46793397>
2129
2130         Reviewed by Geoff Garen.
2131
2132         Update API tests to turn on the WebContent Process cache.
2133
2134         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2135
2136 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
2137
2138         Unreviewed, build fix after r241480
2139
2140         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2141         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2142         (-[DragAndDropSimulator initWithWebView:]):
2143
2144 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
2145
2146         AX: ARIA Reflection was disabled in error
2147         https://bugs.webkit.org/show_bug.cgi?id=194647
2148         <rdar://problem/48068336>
2149
2150         Reviewed by Ryosuke Niwa.
2151
2152         Remove test override now that this feature should be enabled by default.
2153
2154         * WebKitTestRunner/TestController.cpp:
2155         (WTR::TestController::resetPreferencesToConsistentValues):
2156
2157 2019-02-14  Commit Queue  <commit-queue@webkit.org>
2158
2159         Unreviewed, rolling out r241486.
2160         https://bugs.webkit.org/show_bug.cgi?id=194655
2161
2162         causing API failures in builds (Requested by ShawnRoberts on
2163         #webkit).
2164
2165         Reverted changeset:
2166
2167         "[Cocoa] Media elements will restart network buffering just
2168         before suspending"
2169         https://bugs.webkit.org/show_bug.cgi?id=193691
2170         https://trac.webkit.org/changeset/241486
2171
2172 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2173
2174         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
2175         https://bugs.webkit.org/show_bug.cgi?id=194622
2176
2177         Reviewed by Antti Koivisto.
2178
2179         * LayoutReloaded/misc/LFC-passing-tests.txt:
2180
2181 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2182
2183         [LFC] Shrink-to-fit-width should be constrained by min/max width
2184         https://bugs.webkit.org/show_bug.cgi?id=194653
2185
2186         Reviewed by Antti Koivisto.
2187
2188         * LayoutReloaded/misc/LFC-passing-tests.txt:
2189
2190 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2191
2192         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
2193         https://bugs.webkit.org/show_bug.cgi?id=194641
2194
2195         Reviewed by Geoffrey Garen.
2196
2197         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
2198         so that the test would fail without this fix.
2199
2200         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2201         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2202
2203 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2204
2205         [ews-app] Change log level for a log statement
2206
2207         Unreviewed minor fix.
2208
2209         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2210         (Patch.save_patch):
2211
2212 2019-02-13  Jer Noble  <jer.noble@apple.com>
2213
2214         [Cocoa] Media elements will restart network buffering just before suspending
2215         https://bugs.webkit.org/show_bug.cgi?id=193691
2216
2217         Reviewed by Eric Carlson.
2218
2219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2220         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2221         (TEST):
2222
2223 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2224
2225         [ews-app] Fetch builder id to name mapping
2226         https://bugs.webkit.org/show_bug.cgi?id=194355
2227
2228         Reviewed by Lucas Forschler.
2229
2230         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2231         (Buildbot.get_builder_id_to_name_mapping):
2232         (Buildbot._get_display_name_from_builder_name):
2233
2234 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
2235
2236         Further restricting webarchive loads
2237         https://bugs.webkit.org/show_bug.cgi?id=194567
2238         <rdar://problem/47610130>
2239
2240         Reviewed by Youenn Fablet.
2241
2242         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
2243         navigations on drop.
2244
2245         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2246         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
2247         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
2248         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2249         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2250         (TestWebKitAPI::TEST):
2251         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
2252         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
2253         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
2254         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2255         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2256         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2257         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
2258
2259 2019-02-13  John Wilander  <wilander@apple.com>
2260
2261         Store Ad Click Attribution requests in the network process
2262         https://bugs.webkit.org/show_bug.cgi?id=194510
2263         <rdar://problem/47650118>
2264
2265         Reviewed by Alex Christensen and Daniel Bates.
2266
2267         This patch adds two TestRunner functions:
2268         - dumpAdClickAttribution()
2269         - clearAdClickAttribution()
2270
2271         They call into the network process to dump and clear Ad Click
2272         Attribution state, respectively.
2273
2274         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2275         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2276         (WTR::TestRunner::dumpAdClickAttribution):
2277         (WTR::TestRunner::clearAdClickAttribution):
2278         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2279         * WebKitTestRunner/TestController.cpp:
2280         (WTR::TestController::resetStateToConsistentValues):
2281         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2282         (WTR::adClickAttributionStringResultCallback):
2283         (WTR::TestController::dumpAdClickAttribution):
2284         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2285         (WTR::adClickAttributionVoidCallback):
2286         (WTR::TestController::clearAdClickAttribution):
2287         * WebKitTestRunner/TestController.h:
2288         * WebKitTestRunner/TestInvocation.cpp:
2289         (WTR::TestInvocation::dumpResults):
2290         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2291         (WTR::TestInvocation::dumpAdClickAttribution):
2292         * WebKitTestRunner/TestInvocation.h:
2293
2294 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2295
2296         [ews-app] Generate status-bubble
2297         https://bugs.webkit.org/show_bug.cgi?id=194572
2298
2299         Reviewed by Lucas Forschler.
2300
2301         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2302         (StatusBubble._build_bubble):
2303         (StatusBubble._should_show_bubble_for):
2304         (StatusBubble._build_bubbles_for_patch):
2305
2306 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2307
2308         [ews-app] Add status bubble html template
2309         https://bugs.webkit.org/show_bug.cgi?id=194571
2310
2311         Reviewed by Lucas Forschler.
2312
2313         * BuildSlaveSupport/ews-app/ews/templates: Added.
2314         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2315
2316 2019-02-12  Chris Dumez  <cdumez@apple.com>
2317
2318         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2319         https://bugs.webkit.org/show_bug.cgi?id=194568
2320         <rdar://problem/47944490>
2321
2322         Reviewed by Ryosuke Niwa.
2323
2324         Add API test coverage.
2325
2326         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2327         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2328
2329 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2330
2331         webkitpy: Remove bug_dummy from parsed test expectations
2332         https://bugs.webkit.org/show_bug.cgi?id=194562
2333         <rdar://problem/47853999>
2334
2335         Reviewed by Lucas Forschler.
2336
2337         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2338         (TestExpectationParser):
2339         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2340         skipped tests.
2341         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2342
2343 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2344
2345         [ews-app] Add method to fetch patch
2346         https://bugs.webkit.org/show_bug.cgi?id=194518
2347
2348         Reviewed by Lucas Forschler.
2349
2350         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2351         (Patch.get_patch):
2352
2353 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2354
2355         [LFC] Expand tests coverage (60 new tests -> 860)
2356
2357         Unreviewed test gardening (run-singly, --child-processes=1).
2358
2359         * LayoutReloaded/misc/LFC-passing-tests.txt:
2360
2361 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2362
2363         Allow pages to trigger programmatic paste from script on iOS
2364         https://bugs.webkit.org/show_bug.cgi?id=194271
2365         <rdar://problem/47808810>
2366
2367         Reviewed by Tim Horton.
2368
2369         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2370
2371         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2372         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2373         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2374         (WTR::UIScriptController::rectForMenuAction const):
2375
2376         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2377         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2378         for when the menu is shown or hidden.
2379
2380         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2381         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2382         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2383         (WTR::UIScriptController::setDidShowMenuCallback):
2384         (WTR::UIScriptController::didShowMenuCallback const):
2385         (WTR::UIScriptController::setDidHideMenuCallback):
2386         (WTR::UIScriptController::didHideMenuCallback const):
2387         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2388         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2389         (WTR::UIScriptController::rectForMenuAction const):
2390         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2391         * WebKitTestRunner/TestController.cpp:
2392         (WTR::TestController::resetPreferencesToConsistentValues):
2393         (WTR::updateTestOptionsFromTestHeader):
2394         * WebKitTestRunner/TestOptions.h:
2395
2396         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2397         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2398
2399         (WTR::TestOptions::hasSameInitializationOptions const):
2400         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2401         (WTR::UIScriptController::calendarType const):
2402         (WTR::UIScriptController::platformUndoManager const):
2403         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2404         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2405         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2406         (-[TestRunnerWKWebView dealloc]):
2407         (-[TestRunnerWKWebView _didShowMenu]):
2408         (-[TestRunnerWKWebView _didHideMenu]):
2409
2410         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2411
2412         * WebKitTestRunner/ios/TestControllerIOS.mm:
2413         (WTR::handleMenuWillHideNotification):
2414         (WTR::handleMenuDidHideNotification):
2415         (WTR::TestController::platformInitialize):
2416         (WTR::TestController::platformDestroy):
2417         (WTR::TestController::platformResetStateToConsistentValues):
2418
2419         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2420         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2421
2422         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2423         (WTR::forEachViewInHierarchy):
2424         (WTR::findViewInHierarchyOfType):
2425
2426         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2427         functions that dig through a given view's hierarchy in search of a view of a given class.
2428
2429         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2430         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2431         (WTR::UIScriptController::selectionCaretViewRect const):
2432         (WTR::UIScriptController::selectionRangeViewRects const):
2433         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2434         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2435
2436         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2437
2438         (WTR::UIScriptController::rectForMenuAction const):
2439
2440         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2441         callout bar) whose label matches the given string.
2442
2443         (WTR::UIScriptController::platformContentView const):
2444
2445         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2446         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2447         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2448
2449         (WTR::UIScriptController::platformUndoManager const): Deleted.
2450         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2451         (WTR::UIScriptController::platformContentView const):
2452         (WTR::UIScriptController::platformUndoManager const): Deleted.
2453
2454 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2455
2456         webkitpy: No option to only show unexpected failures in results.html for iPad
2457         https://bugs.webkit.org/show_bug.cgi?id=194554
2458         <rdar://problem/47922442>
2459
2460         Rubber-stamped by Aakash Jain.
2461
2462         Just because a TestExpecations file does not exist for a specific platform does not mean that
2463         TestExpecations are not being used, given that platforms inherit test expectations.
2464
2465         * Scripts/webkitpy/port/base.py:
2466         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2467         * Scripts/webkitpy/port/base_unittest.py:
2468         (PortTest.test_uses_test_expectations_file):
2469
2470 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2471
2472         Remove setDefersLoading infrastructure from WebKit2
2473         https://bugs.webkit.org/show_bug.cgi?id=194506
2474
2475         Reviewed by Brady Eidson.
2476
2477         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2478         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2479         (WTR::TestRunner::setDefersLoading): Deleted.
2480         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2481
2482 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2483
2484         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2485         https://bugs.webkit.org/show_bug.cgi?id=194522
2486         <rdar://problem/47789393>
2487
2488         Reviewed by Chris Dumez.
2489
2490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2491         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2492         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2493         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2494
2495 2019-02-12  Andy Estes  <aestes@apple.com>
2496
2497         [iOSMac] Enable Parental Controls Content Filtering
2498         https://bugs.webkit.org/show_bug.cgi?id=194521
2499         <rdar://39732376>
2500
2501         Reviewed by Tim Horton.
2502
2503         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2504
2505 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2506
2507         [LFC][IFC] Add intrinsic width support for float boxes.
2508         https://bugs.webkit.org/show_bug.cgi?id=194528
2509
2510         Reviewed by Antti Koivisto.
2511
2512         Expand tests coverage (2 new tests -> 800).
2513         (This is the correct test ordering --runs-singly --child-processes=1)
2514
2515         * LayoutReloaded/misc/LFC-passing-tests.txt:
2516
2517 2019-02-12  Rob Buis  <rbuis@igalia.com>
2518
2519         Implement serializing in MIME type parser
2520         https://bugs.webkit.org/show_bug.cgi?id=193909
2521
2522         Reviewed by Darin Adler.
2523
2524         Add various tests involving upper case, non-ASCII, control/null characters,
2525         various HTTP whitespace, single quotes and an unpaired surrogate.
2526
2527         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2528         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2529         (TestWebKitAPI::serializeIfValid):
2530         (TestWebKitAPI::TEST):
2531
2532 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2533
2534         [Cocoa] Ask platform for generic font family mappings
2535         https://bugs.webkit.org/show_bug.cgi?id=187723
2536         <rdar://problem/41892438>
2537
2538         Reviewed by Brent Fulgham.
2539
2540         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2541
2542         * DumpRenderTree/mac/DumpRenderTree.mm:
2543         (allowedFontFamilySet):
2544         * WebKitTestRunner/mac/TestControllerMac.mm:
2545         (WTR::allowedFontFamilySet):
2546
2547 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2548
2549         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2550         https://bugs.webkit.org/show_bug.cgi?id=193622
2551
2552         Reviewed by Michael Catanzaro.
2553
2554         This adds support for loading content extension rule sets from the JSON files which
2555         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2556         of WKTR for this could be removed, but that is left for a follow-up patch with
2557         cleanups.
2558
2559         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2560         * WebKitTestRunner/TestController.cpp:
2561         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2562         avoid having the null-terminator copied into the result.
2563         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2564         part of the preparations to run a test.
2565         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2566         (WTR::contentExtensionStoreCallback): Added.
2567         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2568         used for content extensions test.
2569         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2570         extensions and compiling the JSON rule set for tests involving content extensions.
2571         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2572         testing and disables content extensions.
2573         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2574         resetContentExtensions().
2575         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2576         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2577         configureContentExtensionForTest(), and userContentController().
2578
2579 2019-02-11  Daniel Bates  <dabates@apple.com>
2580
2581         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2582         https://bugs.webkit.org/show_bug.cgi?id=191446
2583         <rdar://problem/45929460>
2584
2585         Reviewed by Tim Horton.
2586
2587         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2588
2589         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2590         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2591         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2592         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2593         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2594         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2595         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2596         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2597         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2598         (WTR::arrayLength):
2599         (WTR::parseModifierArray):
2600         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2601         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2602         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2603         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2604
2605 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2606
2607         Unreviewed, rolling out r241272 and r241276.
2608         https://bugs.webkit.org/show_bug.cgi?id=194514
2609
2610         Broke the Apple Internal build and the fix requires human
2611         intervention :( (Requested by dydz on #webkit).
2612
2613         Reverted changesets:
2614
2615         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2616         https://bugs.webkit.org/show_bug.cgi?id=191446
2617         https://trac.webkit.org/changeset/241272
2618
2619         "Fix internal iOS build after r241272"
2620         https://bugs.webkit.org/show_bug.cgi?id=191446
2621         https://trac.webkit.org/changeset/241276
2622
2623 2019-02-11  Truitt Savell  <tsavell@apple.com>
2624
2625         Unreviewed, rolling out r241269.
2626
2627         Caused 5 layout tests crashes on Mac WK1
2628
2629         Reverted changeset:
2630
2631         "DumpRenderTree should report unknown options"
2632         https://bugs.webkit.org/show_bug.cgi?id=191303
2633         https://trac.webkit.org/changeset/241269
2634
2635 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2636
2637         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2638         https://bugs.webkit.org/show_bug.cgi?id=194313
2639
2640         Reviewed by Tim Horton.
2641
2642         Add a helper to determine whether the web view is presenting modal UI.
2643
2644         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2645         (WTR::UIScriptController::isPresentingModally const):
2646         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2647         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2648         (WTR::UIScriptController::isPresentingModally const):
2649         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2650         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2651         (WTR::UIScriptController::calendarType const): Deleted.
2652         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2653         (WTR::UIScriptController::isPresentingModally const):
2654         (WTR::UIScriptController::calendarType const):
2655         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2656         (WTR::UIScriptController::calendarType const):
2657
2658 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2659
2660         GCHeapInspector: Show the retained sizes in more places
2661         https://bugs.webkit.org/show_bug.cgi?id=194464
2662
2663         Reviewed by Simon Fraser.
2664
2665         * GCHeapInspector/gc-heap-inspector.html:
2666         * GCHeapInspector/script/interface.js:
2667         (HeapInspectorUtils.humanReadableSize):
2668         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2669         (HeapInspectorUtils.spanForNode.span.span):
2670         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2671         (HeapSnapshotInspector.prototype.buildRoots):
2672
2673 2019-02-11  Daniel Bates  <dabates@apple.com>
2674
2675         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2676         https://bugs.webkit.org/show_bug.cgi?id=191446
2677         <rdar://problem/45929460>
2678
2679         Reviewed by Tim Horton.
2680
2681         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2682
2683         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2684         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2685         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2686         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2687         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2688         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2689         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2690         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2691         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2692         (WTR::arrayLength):
2693         (WTR::parseModifierArray):
2694         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2695         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2696         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2697         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2698
2699 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2700
2701         DumpRenderTree should report unknown options
2702         https://bugs.webkit.org/show_bug.cgi?id=191303
2703
2704         Reviewed by Frédéric Wang.
2705
2706         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2707         to report unknown options.
2708         Added and assigned test options which are currently used in tests.
2709
2710         * DumpRenderTree/TestOptions.cpp:
2711         (TestOptions::TestOptions):
2712
2713 2019-02-11  Truitt Savell  <tsavell@apple.com>
2714
2715         Unreviewed, rolling out r241229.
2716
2717         Revision broke internal builds for watchOS.
2718
2719         Reverted changeset:
2720
2721         "[Cocoa] Ask platform for generic font family mappings"
2722         https://bugs.webkit.org/show_bug.cgi?id=187723
2723         https://trac.webkit.org/changeset/241229
2724
2725 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2726
2727         [WinCairo][MiniBrowser] Basic authentication always fails.
2728         https://bugs.webkit.org/show_bug.cgi?id=194496
2729
2730         Reviewed by Don Olmstead.
2731
2732         * MiniBrowser/win/DialogHelper.h:
2733         (Dialog::getText):
2734
2735 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2736
2737         [GStreamer] GstMappedBuffer testsuite build fails
2738         https://bugs.webkit.org/show_bug.cgi?id=194495
2739
2740         Reviewed by Carlos Garcia Campos.
2741
2742         Fix the build by explicitely adding the gstreamer1.0-audio include
2743         directories to the include path.
2744
2745         * TestWebKitAPI/PlatformGTK.cmake:
2746         * TestWebKitAPI/PlatformWPE.cmake:
2747
2748 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2749
2750         [GTK][WPE] Add enable-javascript-markup setting
2751         https://bugs.webkit.org/show_bug.cgi?id=193439
2752
2753         Reviewed by Michael Catanzaro.
2754
2755         Add test cases to check the new setting.
2756
2757         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2758         (testWebKitSettings):
2759         (testWebKitSettingsJavaScriptMarkup):
2760         (beforeAll):
2761
2762 2019-02-10  Darin Adler  <darin@apple.com>
2763
2764         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2765         https://bugs.webkit.org/show_bug.cgi?id=194485
2766
2767         Reviewed by Daniel Bates.
2768
2769         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2770
2771 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2772
2773         Add more tests for clampTo<>()
2774         https://bugs.webkit.org/show_bug.cgi?id=194462
2775
2776         Reviewed by Geoffrey Garen.
2777
2778         Darin suggested to test the very last floating point number
2779         at the boundaries when truncating to integer.
2780         I added test for max/min and max-1/min-1.
2781
2782         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2783         (TestWebKitAPI::TEST):
2784
2785 2019-02-09  Darin Adler  <darin@apple.com>
2786
2787         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2788         https://bugs.webkit.org/show_bug.cgi?id=194021
2789
2790         Reviewed by Geoffrey Garen.
2791
2792         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2793         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2794         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2795
2796 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2797
2798         [LFC][IFC] Add intrinsic width support for basic inline containers
2799         https://bugs.webkit.org/show_bug.cgi?id=194473
2800
2801         Reviewed by Antti Koivisto.
2802
2803         Expand tests coverage (11 new tests -> 798)
2804
2805         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2806
2807 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2808
2809         Fix MiniBrowser's entitlements
2810         https://bugs.webkit.org/show_bug.cgi?id=192431
2811
2812         Reviewed by Joseph Pecoraro.
2813
2814         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2815         files, making it impossible to load any extension.
2816
2817         * MiniBrowser/MiniBrowser.entitlements:
2818
2819 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2820
2821         [Cocoa] Ask platform for generic font family mappings
2822         https://bugs.webkit.org/show_bug.cgi?id=187723
2823         <rdar://problem/41892438>
2824
2825         Reviewed by Brent Fulgham.
2826
2827         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2828
2829         * DumpRenderTree/mac/DumpRenderTree.mm:
2830         (allowedFontFamilySet):
2831         * WebKitTestRunner/mac/TestControllerMac.mm:
2832         (WTR::allowedFontFamilySet):
2833
2834 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2835
2836         [GTK] Implement back/forward touchpad gesture
2837         https://bugs.webkit.org/show_bug.cgi?id=193919
2838
2839         Reviewed by Michael Catanzaro.
2840
2841         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2842         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2843
2844 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2845
2846         Add SPI to use networking daemon instead of XPC service
2847         https://bugs.webkit.org/show_bug.cgi?id=194427
2848
2849         Reviewed by Geoffrey Garen
2850
2851         * MiniBrowser/MiniBrowser.entitlements:
2852
2853 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2854
2855         [ews-build] Ensure that every builder in config.json has short name
2856         https://bugs.webkit.org/show_bug.cgi?id=194461
2857
2858         Reviewed by Lucas Forschler.
2859
2860         * BuildSlaveSupport/ews-build/loadConfig.py:
2861         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2862
2863 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2864
2865         [ews-build] Add short name to config.json
2866         https://bugs.webkit.org/show_bug.cgi?id=194456
2867
2868         Reviewed by Lucas Forschler.
2869
2870         * BuildSlaveSupport/ews-build/config.json: Added short name.
2871         * BuildSlaveSupport/ews-build/loadConfig.py:
2872         (loadBuilderConfig): Set the short name as the builder description.
2873
2874 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2875
2876         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2877         https://bugs.webkit.org/show_bug.cgi?id=194418
2878
2879         Reviewed by Lucas Forschler.
2880
2881         Do not include errors trying when finding crashlogs at the end of
2882         a run-webkit-tests run since we don't process those errors.
2883
2884         * Scripts/webkitpy/port/darwin.py:
2885         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2886         * Scripts/webkitpy/port/ios_device.py:
2887         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2888         * Scripts/webkitpy/port/watch_device.py:
2889         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2890
2891 2019-02-08  Beth Dakin  <bdakin@apple.com>
2892
2893         Add afterScreenUpdates to WKSnapshotConfiguration
2894         https://bugs.webkit.org/show_bug.cgi?id=194362
2895         -and corresponding-
2896         <rdar://problem/40655528> Please add an "after screen updates" property to 
2897         WKSnapshotConfiguration (to solve blank snapshots)
2898
2899         Reviewed by Tim Horton.
2900
2901         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2902         (TEST):
2903
2904 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2905
2906         clampTo(): do not convert the input to double when dealing with integers
2907         https://bugs.webkit.org/show_bug.cgi?id=194263
2908         <rdar://problem/47692312>
2909
2910         Reviewed by Darin Adler.
2911
2912         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2913         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2914         (TestWebKitAPI::testClampFloatingPointToInteger):
2915         (TestWebKitAPI::testClampSameSignIntegers):
2916         (TestWebKitAPI::testClampUnsignedToSigned):
2917         (TestWebKitAPI::testClampSignedToUnsigned):
2918
2919 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2920
2921         webkitpy: Respect --dedicated-simulators flag
2922         https://bugs.webkit.org/show_bug.cgi?id=194416
2923         <rdar://problem/47894722>
2924
2925         Reviewed by Lucas Forschler.
2926
2927         * Scripts/webkitpy/port/device_port.py:
2928         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2929         available devices can be safely ignored.
2930
2931 2019-02-07  Keith Rollin  <krollin@apple.com>
2932
2933         Remove extra copy of 100x100-red.tga
2934         https://bugs.webkit.org/show_bug.cgi?id=194371
2935         <rdar://problem/47873465>
2936
2937         Reviewed by Said Abou-Hallawa.
2938
2939         In order to help it pass its tests, Bug 194190 added a second copy of
2940         the file 100x100-red.tga. However, it turns out that this additional
2941         file wasn't actually needed, and that that sole previous copy was
2942         sufficient. At the same time, this second copy -- which was copied to
2943         the same location in the build output as the first copy -- now caused
2944         XCBuild to complain because there were two production rules for the
2945         same output file. Address this by removing the newly-added extra copy.
2946
2947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2948         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2949
2950 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2951
2952         Deprecate WKBundlePageSetDefersLoading
2953         https://bugs.webkit.org/show_bug.cgi?id=191394
2954
2955         Reviewed by Dean Jackson.
2956
2957         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2958         (WTR::TestRunner::setDefersLoading):
2959
2960 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2961
2962         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2963         https://bugs.webkit.org/show_bug.cgi?id=194391
2964
2965         Reviewed by Antti Koivisto.
2966
2967         * LayoutReloaded/misc/LFC-passing-tests.txt:
2968
2969 2019-02-06  Keith Rollin  <krollin@apple.com>
2970
2971         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2972         https://bugs.webkit.org/show_bug.cgi?id=193975
2973         <rdar://problem/47643306>
2974
2975         Reviewed by Tim Horton.
2976
2977         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2978         the Info.plist file into the bundle. This step is not necessary as the
2979         implicit "bundle up all the build products into a framework" build
2980         phase does this already. Having the Copy Bundle Resources phase do
2981         this causes a conflict under XCBuild, which objects to two build
2982         phases producing the same file (Info.plist). Address this by removing
2983         Info.plist from the Copy Bundle Resources phase.
2984
2985         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2986
2987 2019-02-06  Keith Rollin  <krollin@apple.com>
2988
2989         Really enable the automatic checking and regenerations of .xcfilelists during builds
2990         https://bugs.webkit.org/show_bug.cgi?id=194357
2991         <rdar://problem/47861231>
2992
2993         Reviewed by Chris Dumez.
2994
2995         Bug 194124 was supposed to enable the automatic checking and
2996         regenerating of .xcfilelist files during the build. While related
2997         changes were included in that patch, the change to actually enable the
2998         operation somehow was omitted. This patch actually enables the
2999         operation. The check-xcfilelist.sh scripts now check
3000         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
3001         from the checking.
3002
3003         * DumpRenderTree/Scripts/check-xcfilelists.sh:
3004         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
3005
3006 2019-02-06  David Kilzer  <ddkilzer@apple.com>
3007
3008         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
3009         <https://webkit.org/b/194286>
3010         <rdar://problem/47815558>
3011
3012         Reviewed by Alexey Proskuryakov.
3013
3014         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3015         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
3016         WKRetainPtr<> to avoid leaking the WKDataRef.
3017
3018 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3019
3020         Unreviewed, fix a typo
3021
3022         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3023
3024 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
3025
3026         [GTK][WPE] force libpsl build to use ICU in jhbuild
3027         https://bugs.webkit.org/show_bug.cgi?id=194288
3028
3029         Reviewed by Carlos Garcia Campos.
3030
3031         * gtk/jhbuild.modules:
3032         Require ICU for libpsl build in jhbuild, like done in WPE.
3033
3034 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3035
3036         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
3037         https://bugs.webkit.org/show_bug.cgi?id=194209
3038
3039         Reviewed by Carlos Garcia Campos.
3040
3041         Enhance TestCookieManager to ensure this doesn't happen again.
3042
3043         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3044         (testCookieManagerPersistentStorage):
3045         (beforeAll):
3046
3047 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3048
3049         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
3050         https://bugs.webkit.org/show_bug.cgi?id=194324
3051
3052         Reviewed by Andy Estes.
3053
3054         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
3055         part of the name is already implicit, since this is in testing code in TestOptions.
3056
3057         * WebKitTestRunner/TestController.cpp:
3058         (WTR::TestController::generateContextConfiguration const):
3059         (WTR::updateTestOptionsFromTestHeader):
3060         * WebKitTestRunner/TestOptions.h:
3061         (WTR::TestOptions::hasSameInitializationOptions const):
3062
3063 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3064
3065         [ews-build] Allow * as platform for builders and workers
3066         https://bugs.webkit.org/show_bug.cgi?id=188533
3067
3068         Reviewed by Lucas Forschler.
3069
3070         * BuildSlaveSupport/ews-build/loadConfig.py:
3071         (checkWorkersAndBuildersForConsistency):
3072
3073 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3074
3075         [ews-build] Add few bots to config.json
3076         https://bugs.webkit.org/show_bug.cgi?id=194304
3077
3078         Reviewed by Lucas Forschler.
3079
3080         * BuildSlaveSupport/ews-build/config.json:
3081
3082 2019-02-05  Keith Rollin  <krollin@apple.com>
3083
3084         Enable the automatic checking and regenerations of .xcfilelists during builds
3085         https://bugs.webkit.org/show_bug.cgi?id=194124
3086         <rdar://problem/47721277>
3087
3088         Reviewed by Tim Horton.
3089
3090         Bug 193790 add a facility for checking -- during build time -- that
3091         any needed .xcfilelist files are up-to-date and for updating them if
3092         they are not. This facility was initially opt-in by setting
3093         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
3094         the process seemed robust. Its now time to enable this facility and
3095         make it opt-out. If there is a need to disable this facility, set and
3096         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
3097         running `make` or `build-webkit`, or before running Xcode from the
3098         command line.
3099
3100         Additionally, remove the step that generates a list of source files
3101         going into the UnifiedSources build step. It's only necessarily to
3102         specify Sources.txt and SourcesCocoa.txt as inputs.
3103
3104         * Scripts/generate-xcfilelists:
3105
3106 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3107
3108         [GTK][WPE] force libpsl build to use ICU in jhbuild
3109         https://bugs.webkit.org/show_bug.cgi?id=194288
3110
3111         Reviewed by Philippe Normand.
3112
3113         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
3114         This can cause build failures if libidn is detected but libunistring is not available.
3115
3116         Make sure that ICU is used for runtime and builtin PSL data.
3117
3118         * gtk/jhbuild.modules:
3119         * wpe/jhbuild.modules:
3120
3121 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3122
3123         [ews-app] Modified timestamp should be updated on updating data
3124         https://bugs.webkit.org/show_bug.cgi?id=194295
3125
3126         Reviewed by Lucas Forschler.
3127
3128         * BuildSlaveSupport/ews-app/ews/models/build.py:
3129         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3130         * BuildSlaveSupport/ews-app/ews/models/step.py:
3131
3132 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
3133
3134         Unreviewed, rolling out r240742.
3135
3136         Causes crashes on iOS simulator.
3137
3138         Reverted changeset:
3139
3140         "[iOS] Keyups for non-modifier keys identified as "Dead" when
3141         not focused in a content-editable element"
3142         https://bugs.webkit.org/show_bug.cgi?id=192824
3143         https://trac.webkit.org/changeset/240742
3144
3145 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
3146
3147         run-webkit-tests emits message "...running None" when running tests
3148         https://bugs.webkit.org/show_bug.cgi?id=194133
3149         <rdar://problem/47724738>
3150
3151         Reviewed by Lucas Forschler.
3152
3153         * Scripts/webkitpy/xcode/device_type.py:
3154         (DeviceType.__str__): Use both version mapping tables and use just the variant
3155         name if no version name is available.
3156         * Scripts/webkitpy/xcode/device_type_unittest.py:
3157         (DeviceTypeTest):
3158         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
3159         an associated named.
3160
3161 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3162
3163         [WPE] require python3-setuptools for meson build in jhbuild
3164         https://bugs.webkit.org/show_bug.cgi?id=194287
3165
3166         Reviewed by Philippe Normand.
3167
3168         python3-setuptools is needed to build meson in jhbuild.
3169         It is already required by the GTK port.
3170
3171         * wpe/install-dependencies:
3172
3173 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3174
3175         [ews-app] Add method to save BuilderMapping to database
3176         https://bugs.webkit.org/show_bug.cgi?id=194264
3177
3178         Reviewed by Lucas Forschler.
3179
3180         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3181         (BuilderMapping.__str__):
3182         (BuilderMapping):
3183         (BuilderMapping.save_mapping):
3184         (BuilderMapping.update_mapping):
3185         (BuilderMapping.get_existing_mapping):
3186         (BuilderMapping.is_valid_mapping):
3187
3188 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3189
3190         [ews-app] Add timestamp fields for BuilderMappings
3191         https://bugs.webkit.org/show_bug.cgi?id=194266
3192
3193         Reviewed by Lucas Forschler.
3194
3195         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3196         (BuilderMapping):
3197
3198 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
3199
3200         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3201         https://bugs.webkit.org/show_bug.cgi?id=174816
3202
3203         Reviewed by Michael Catanzaro.
3204
3205         Add tests for webkit_uri_for_display().
3206
3207         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3208         (testURIForDisplayUnaffected):
3209         (testURIForDisplayAffected):
3210         (beforeAll):
3211         (afterAll):
3212         * TestWebKitAPI/glib/CMakeLists.txt:
3213
3214 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
3215
3216         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
3217         https://bugs.webkit.org/show_bug.cgi?id=194158
3218         <rdar://problem/47737268>
3219
3220         Rubber-stamped by Aakash Jain.
3221
3222         * Scripts/webkitpy/port/device_port.py:
3223         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
3224
3225 2019-02-04  Said Abou-Hallawa  <said@apple.com>
3226
3227         [CG] Enable setAdditionalSupportedImageTypes for WK1
3228         https://bugs.webkit.org/show_bug.cgi?id=194190
3229
3230         Reviewed by Tim Horton.
3231
3232         Add a test similar to the one under WebKit Cocoa but make it create a
3233         WebView instead of a WKWebView.
3234
3235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3236         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
3237         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
3238         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
3239         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
3240         (TestWebKitAPI::runTest):
3241         (TestWebKitAPI::TEST):
3242
3243 2019-02-04  Zalan Bujtas  <zalan@apple.com>
3244
3245         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
3246         https://bugs.webkit.org/show_bug.cgi?id=194168
3247
3248         Reviewed by Simon Fraser.
3249
3250         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
3251
3252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3253         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
3254         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
3255         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
3256         (TEST):
3257         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
3258         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
3259
3260 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
3261
3262         REGRESSION (r237269): webkit-patch what-broke is broken 
3263         https://bugs.webkit.org/show_bug.cgi?id=193025
3264
3265         Reviewed by Aakash Jain.
3266
3267         * Scripts/webkitpy/common/host.py:
3268         (Host.buildbot):
3269         (Host.bugzilla): Renamed to 'buildbot'.
3270
3271 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3272
3273         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
3274         https://bugs.webkit.org/show_bug.cgi?id=194207
3275
3276         Reviewed by Tim Horton.
3277
3278         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
3279         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
3280         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
3281         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
3282         start and delete forwards to remove the original attachment.
3283
3284         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3285         (TestWebKitAPI::TEST):
3286
3287 2019-02-04  Youenn Fablet  <youenn@apple.com>
3288
3289         Capture state should be managed consistently when doing process swapping
3290         https://bugs.webkit.org/show_bug.cgi?id=194122
3291         <rdar://problem/47609293>
3292
3293         Reviewed by Eric Carlson.
3294
3295         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3296         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3297         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3298         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
3299         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3300         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3301         (WTR::TestRunner::isDoingMediaCapture const):
3302         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3303         * WebKitTestRunner/TestController.cpp:
3304         (WTR::TestController::isDoingMediaCapture const):
3305         * WebKitTestRunner/TestController.h:
3306         * WebKitTestRunner/TestInvocation.cpp:
3307         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3308         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3309         (WTR::TestController::isDoingMediaCapture const):
3310
3311 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3312
3313         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3314         https://bugs.webkit.org/show_bug.cgi?id=194142
3315
3316         Reviewed by Ross Kirsling.
3317
3318         There three 'separator' variables in TestController.cpp. Renamed
3319         it 'pathSeparator', and unified them.
3320
3321         * WebKitTestRunner/TestController.cpp:
3322         (WTR::TestController::generateContextConfiguration const):
3323         (WTR::createTestURL):
3324         (WTR::TestController::platformAdjustContext):
3325
3326 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3327
3328         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3329         https://bugs.webkit.org/show_bug.cgi?id=194198
3330
3331         Reviewed by Antti Koivisto.
3332
3333         No need to set the banner heights on navigation now, since Page stores them.
3334
3335         * MiniBrowser/mac/WK2BrowserWindowController.m:
3336         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3337
3338 2019-02-03  John Wilander  <wilander@apple.com>
3339
3340         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3341         https://bugs.webkit.org/show_bug.cgi?id=194104
3342         <rdar://problem/47649991>
3343
3344         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3345
3346         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3347         (TestWebKitAPI::TEST):
3348             Changed numeric types from unsigned short to uint32_t.
3349
3350 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3351
3352         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3353         <https://webkit.org/b/194178>
3354         <rdar://problem/47753473>
3355
3356         Reviewed by Alexey Proskuryakov.
3357
3358         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3359         (WTR::uninstallFakeHelvetica): Pass nullptr into
3360         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3361
3362 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3363
3364         [LFC] Initialize ICB's style with fixed width/height.
3365         https://bugs.webkit.org/show_bug.cgi?id=194188
3366
3367         Reviewed by Antti Koivisto.
3368
3369         * LayoutReloaded/misc/LFC-passing-tests.txt:
3370
3371 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3372
3373         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3374         https://bugs.webkit.org/show_bug.cgi?id=194185
3375
3376         Reviewed by Antti Koivisto.
3377
3378         * LayoutReloaded/misc/LFC-passing-tests.txt:
3379
3380 2018-12-16  Darin Adler  <darin@apple.com>
3381
3382         Convert additional String::format clients to alternative approaches
3383         https://bugs.webkit.org/show_bug.cgi?id=192746
3384
3385         Reviewed by Alexey Proskuryakov.
3386
3387         * WebKitTestRunner/TestController.cpp:
3388         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3389         as an intermediate in code that ultimately constructs a WTF::String.
3390         (WTR::userMediaOriginHash): Use makeString.
3391         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3392         (WTR::TestController::didPerformClientRedirect): Ditto.
3393         (WTR::TestController::didPerformServerRedirect): Ditto.
3394         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3395
3396 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3397
3398         [ews-build] Add unit test to verify builder keys
3399         https://bugs.webkit.org/show_bug.cgi?id=194152
3400
3401         Reviewed by Lucas Forschler.
3402
3403         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3404         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3405
3406 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3407
3408         [LFC] Expand tests coverage (12 new tests -> 787)
3409
3410         Unreviewed test gardening.
3411
3412         * LayoutReloaded/misc/LFC-passing-tests.txt:
3413
3414 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3415
3416         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3417         https://bugs.webkit.org/show_bug.cgi?id=194163
3418
3419         Reviewed by Simon Fraser.
3420
3421         775
3422
3423         * LayoutReloaded/misc/LFC-passing-tests.txt:
3424
3425 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3426
3427         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3428         https://bugs.webkit.org/show_bug.cgi?id=194140
3429         <rdar://problem/47728098>
3430
3431         Reviewed by Tim Horton.
3432
3433         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3434         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3435         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3436
3437         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3438         test to induce an IPC deadlock when presenting a modal alert during touch start.
3439
3440         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3441         * WebKitTestRunner/TestController.cpp:
3442         (WTR::runJavaScriptAlert):
3443
3444         Add a client callback function for running JavaScript alerts.
3445
3446         (WTR::TestController::createOtherPage):
3447         (WTR::TestController::generateContextConfiguration const):
3448
3449         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3450         the fix in this patch.
3451
3452         (WTR::TestController::createWebViewWithOptions):
3453
3454         Plumb TestOptions to generateContextConfiguration.
3455
3456         (WTR::TestController::resetPreferencesToConsistentValues):
3457         (WTR::TestController::resetStateToConsistentValues):
3458         (WTR::updateTestOptionsFromTestHeader):
3459         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3460         (WTR::TestController::handleJavaScriptAlert):
3461         * WebKitTestRunner/TestController.h:
3462         * WebKitTestRunner/TestInvocation.cpp:
3463         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3464         * WebKitTestRunner/TestOptions.h:
3465         (WTR::TestOptions::hasSameInitializationOptions const):
3466
3467 2019-02-01  Chris Dumez  <cdumez@apple.com>
3468
3469         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3470         https://bugs.webkit.org/show_bug.cgi?id=193740
3471         <rdar://problem/47527267>
3472
3473         Reviewed by Alex Christensen.
3474
3475         Add API test coverage.
3476
3477         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3478
3479 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3480
3481         [ews-app] Add display name field to BuilderMapping model
3482         https://bugs.webkit.org/show_bug.cgi?id=194153
3483
3484         Reviewed by Lucas Forschler.
3485
3486         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3487         (BuilderMapping):
3488
3489 2019-02-01  Youenn Fablet  <youenn@apple.com>
3490
3491         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3492         https://bugs.webkit.org/show_bug.cgi?id=194155
3493
3494         Reviewed by Eric Carlson.
3495
3496         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3497         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3498         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3499
3500 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3501
3502         [LFC] Adjust replaced element's intrinsic ratio
3503         https://bugs.webkit.org/show_bug.cgi?id=194154
3504
3505         Reviewed by Antti Koivisto.
3506
3507         761
3508
3509         * LayoutReloaded/misc/LFC-passing-tests.txt:
3510
3511 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3512
3513         [WPE] Show test results in minibrowser
3514         https://bugs.webkit.org/show_bug.cgi?id=194150
3515
3516         Reviewed by Žan Doberšek.
3517
3518         * Scripts/webkitpy/port/wpe.py:
3519         (WPEPort.show_results_html_file):
3520
3521 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3522
3523         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3524         https://bugs.webkit.org/show_bug.cgi?id=194151
3525
3526         Reviewed by Žan Doberšek.
3527
3528         ALT + <- go back
3529         ALT + -> go forward
3530
3531         * MiniBrowser/wpe/main.cpp:
3532         (main):
3533
3534 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3535
3536         [LFC] Set intrinsic size on Layout::Replaced
3537         https://bugs.webkit.org/show_bug.cgi?id=194139
3538
3539         Reviewed by Antti Koivisto.
3540
3541         744
3542
3543         * LayoutReloaded/misc/LFC-passing-tests.txt:
3544
3545 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3546
3547         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3548         https://bugs.webkit.org/show_bug.cgi?id=194146
3549
3550         Reviewed by Xabier Rodriguez-Calvar.
3551
3552         It allows to open relative paths.
3553
3554         * MiniBrowser/wpe/main.cpp:
3555         (main):
3556
3557 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3558
3559         Update flakiness dashboard configuration after recent queue changes
3560         https://bugs.webkit.org/show_bug.cgi?id=194127
3561
3562         Rubber-stamped by Aakash Jain.
3563
3564         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3565
3566         * TestResultServer/static-dashboards/builders.jsonp:
3567
3568 2019-01-31  Youenn Fablet  <youenn@apple.com>
3569
3570         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3571         https://bugs.webkit.org/show_bug.cgi?id=194106
3572         <rdar://problem/47676333>
3573
3574         Reviewed by Ryosuke Niwa.
3575
3576         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3577         (TestWebKitAPI::didFinishNavigation):
3578         (TestWebKitAPI::TEST):
3579         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3580
3581 2019-01-31  Chris Dumez  <cdumez@apple.com>
3582
3583         Page zoom level is lost after a process swap or a crash
3584         https://bugs.webkit.org/show_bug.cgi?id=194105
3585         <rdar://problem/47610781>
3586
3587         Reviewed by Alex Christensen.
3588
3589         Add API test coverage.
3590
3591         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3592         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3593
3594 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3595
3596         Revert r238819 which is unneeded and caused a performance regression.
3597         https://bugs.webkit.org/show_bug.cgi?id=192272
3598         <rdar://problem/46664625>
3599
3600         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3601         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3602         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3603
3604 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3605
3606         Formalize WebKitAdditions mechanism of LoadOptimizer
3607         https://bugs.webkit.org/show_bug.cgi?id=193886
3608         <rdar://problem/47696809>
3609
3610         Reviewed by Brent Fulgham.
3611
3612         * MiniBrowser/MiniBrowser.entitlements:
3613         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3614
3615 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3616
3617         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3618         https://bugs.webkit.org/show_bug.cgi?id=194090
3619
3620         Reviewed by Antti Koivisto.
3621
3622         * LayoutReloaded/misc/LFC-passing-tests.txt:
3623
3624 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3625
3626         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3627         https://bugs.webkit.org/show_bug.cgi?id=194074
3628
3629         Reviewed by Antti Koivisto.
3630
3631         * LayoutReloaded/misc/LFC-passing-tests.txt:
3632
3633 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3634
3635         [LFC][BFC] Add support for block level replaced box.
3636         https://bugs.webkit.org/show_bug.cgi?id=194071
3637
3638         Reviewed by Antti Koivisto.
3639
3640         * LayoutReloaded/misc/LFC-passing-tests.txt:
3641
3642 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3643
3644         Fix WebKitTestRunner's testPath with Windows full paths
3645         https://bugs.webkit.org/show_bug.cgi?id=194012
3646
3647         Reviewed by Alex Christensen.
3648
3649         updateTestOptionsFromTestHeader failed to open test files because
3650         testPath returned wrong file paths. It returned a path "/C:/..."
3651         if a URL "file:///C:/..." was given.
3652
3653         * WebKitTestRunner/TestController.cpp:
3654         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3655
3656 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3657
3658         [WPE] Bump font related dependencies to match the GTK+ port
3659         https://bugs.webkit.org/show_bug.cgi?id=194017
3660
3661         Reviewed by Žan Doberšek.
3662
3663         * wpe/jhbuild.modules:
3664         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3665         * wpe/patches/icudata-stdlibs.patch: Added.
3666
3667 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3668
3669         Enable swipe tests on iOS
3670         https://bugs.webkit.org/show_bug.cgi?id=194076
3671
3672         Reviewed by Geoffrey Garen.
3673
3674         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3675         it causes a debug assertion failure in runUIScript.
3676
3677         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3678         (WTR::UIScriptController::beginBackSwipe):
3679         (WTR::UIScriptController::completeBackSwipe):
3680
3681 2019-01-30  Keith Rollin  <krollin@apple.com>
3682
3683         Use correct printf format specifier
3684         https://bugs.webkit.org/show_bug.cgi?id=194062
3685         <rdar://problem/47686167>
3686
3687         Reviewed by Alexey Proskuryakov.
3688
3689         LayoutTestSpellChecker.mm is trying to format a variable of type
3690         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3691         actually an unsigned long long. Fix this by formatting with %llu.
3692
3693         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3694         (-[LayoutTestTextCheckingResult description]):
3695
3696 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3697
3698         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3699         https://bugs.webkit.org/show_bug.cgi?id=193979
3700
3701         Reviewed by Wenson Hsieh.
3702
3703         Fix the test for iOS. Make the test work with iOS UA string.
3704
3705         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3706
3707 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3708
3709         Replace High Sierra LLINT CLoop bot due to hardware failure
3710         https://bugs.webkit.org/show_bug.cgi?id=194066
3711
3712         Reviewed by Aakash Jain.
3713
3714         * BuildSlaveSupport/build.webkit.org-config/config.json:
3715
3716 2019-01-30  Keith Rollin  <krollin@apple.com>
3717
3718         [NSDragItem init] is unavailable
3719         https://bugs.webkit.org/show_bug.cgi?id=194059
3720         <rdar://problem/47685715>
3721
3722         Reviewed by Wenson Hsieh.
3723
3724         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3725         DumpRenderTree and TestWebKitAPI, which both try to create an
3726         NSDragItem in a manner that invokes this method. Address this by using
3727         -initWithPasteboardWriter instead.
3728
3729         Note that the parameter passed to initWithPasteboardWriter is likely
3730         incorrect. In both cases, the object passed does not conform to
3731         NSPasteboardWriting. However, with this fix, we're no worse off than
3732         before, and can now perform builds with newer compilers and SDKs until
3733         a real fix can be crafted. That work is tracked in
3734         https://bugs.webkit.org/show_bug.cgi?id=194060
3735
3736         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3737         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3738         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3739         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3740
3741 2019-01-30  Daniel Bates  <dabates@apple.com>
3742
3743         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3744         https://bugs.webkit.org/show_bug.cgi?id=192824
3745         <rdar://problem/47100332>
3746
3747         Reviewed by Wenson Hsieh.
3748
3749         Fix a bug where the wrong usage code was used for F13 thru F24.
3750
3751         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3752         (keyCodeForDOMFunctionKey):
3753
3754 2019-01-30  Chris Dumez  <cdumez@apple.com>
3755
3756         Regression(PSON) Load hang can occur on history navigation
3757         https://bugs.webkit.org/show_bug.cgi?id=194030
3758         <rdar://problem/47656939>
3759
3760         Reviewed by Antti Koivisto.
3761
3762         Add API test coverage.
3763
3764         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3765
3766 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3767
3768         [LFC] Expand tests coverage.
3769
3770         Unreviewed test gardening.
3771
3772         * LayoutReloaded/misc/LFC-passing-tests.txt:
3773
3774 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3775
3776         [Flatpak] Add openjpeg support
3777         https://bugs.webkit.org/show_bug.cgi?id=194019
3778
3779         Reviewed by Michael Catanzaro.
3780
3781         * flatpak/org.webkit.CommonModules.yaml:
3782
3783 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3784
3785         Unreviewed, rolling out r240708.
3786         https://bugs.webkit.org/show_bug.cgi?id=194022
3787
3788         It broke WPE build (Requested by KaL on #webkit).
3789
3790         Reverted changeset:
3791
3792         "[WPE] Bump font related dependencies to match the GTK+ port"
3793         https://bugs.webkit.org/show_bug.cgi?id=194017
3794         https://trac.webkit.org/changeset/240708
3795
3796 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3797
3798         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3799         https://bugs.webkit.org/show_bug.cgi?id=194001
3800
3801         Reviewed by Antti Koivisto.
3802
3803         * LayoutReloaded/misc/LFC-passing-tests.txt:
3804
3805 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3806
3807         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3808         https://bugs.webkit.org/show_bug.cgi?id=194020
3809
3810         Reviewed by Antti Koivisto.
3811
3812         * LayoutReloaded/misc/LFC-passing-tests.txt:
3813
3814 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3815
3816         AX: Support color well on iOS
3817         https://bugs.webkit.org/show_bug.cgi?id=194010
3818
3819         Reviewed by Joanmarie Diggs.
3820
3821         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3822         (WTR::AccessibilityUIElement::stringAttributeValue):
3823
3824 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3825
3826         [WPE] Bump font related dependencies to match the GTK+ port
3827         https://bugs.webkit.org/show_bug.cgi?id=194017
3828
3829         Reviewed by Žan Doberšek.
3830
3831         * wpe/jhbuild.modules:
3832         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3833         * wpe/patches/icudata-stdlibs.patch: Added.
3834
3835 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3836
3837         [Mac] Update window scale API usage
3838         https://bugs.webkit.org/show_bug.cgi?id=193991
3839         rdar://problem/47614795
3840
3841         Reviewed by Tim Horton.
3842
3843         * DumpRenderTree/mac/DumpRenderTree.mm:
3844         (changeWindowScaleIfNeeded):
3845         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3846         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3847         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3848
3849 2019-01-29  Chris Dumez  <cdumez@apple.com>
3850
3851         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3852         https://bugs.webkit.org/show_bug.cgi?id=193977
3853         <rdar://problem/47643716>
3854
3855         Reviewed by Geoff Garen.
3856
3857         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3858         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3859         to the previous provisional committing *before* we make the last load. 
3860
3861         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3862
3863 2019-01-29  Youenn Fablet  <youenn@apple.com>
3864
3865         Adopt new SPI to evaluate server certificate trust
3866         https://bugs.webkit.org/show_bug.cgi?id=193355
3867
3868         Reviewed by Alex Christensen.
3869
3870         Add infrastructure to handle HTTPS server trust evaluation testing.
3871
3872         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3873         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3874         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3875         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3876         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3877         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3878         * WebKitTestRunner/TestController.cpp:
3879         (WTR::TestController::resetPreferencesToConsistentValues):
3880         (WTR::TestController::didReceiveAuthenticationChallenge):
3881         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3882         * WebKitTestRunner/TestController.h:
3883         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3884         * WebKitTestRunner/TestInvocation.cpp:
3885         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3886         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3887         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3888
3889 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3890
3891         [ews-build] Add build step to print bot Configuration
3892         https://bugs.webkit.org/show_bug.cgi?id=193887
3893
3894         Reviewed by Lucas Forschler.
3895
3896         * BuildSlaveSupport/ews-build/steps.py:
3897         (PrintConfiguration): Build step to print configuration.
3898         * BuildSlaveSupport/ews-build/factories.py:
3899
3900 2019-01-29  Chris Dumez  <cdumez@apple.com>
3901
3902         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3903         https://bugs.webkit.org/show_bug.cgi?id=193967
3904         <rdar://problem/47635348>
3905
3906         Reviewed by Alex Christensen.
3907
3908         Add API test coverage.
3909
3910         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3911         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3912
3913 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3914
3915         [ews-app] Handle incoming results data
3916         https://bugs.webkit.org/show_bug.cgi?id=193973
3917
3918         Reviewed by Lucas Forschler.
3919
3920         * BuildSlaveSupport/ews-app/ews/views/results.py:
3921
3922 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3923
3924         [ews-app] Make the results url generic
3925         https://bugs.webkit.org/show_bug.cgi?id=193928
3926
3927         Reviewed by Lucas Forschler.
3928
3929         * BuildSlaveSupport/ews-app/ews/urls.py:
3930
3931 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3932
3933         [ews-build] Configure buildbot to send events to ews-app
3934         https://bugs.webkit.org/show_bug.cgi?id=193968
3935
3936         Reviewed by Lucas Forschler.
3937
3938         * BuildSlaveSupport/ews-build/events.py: Added.
3939         * BuildSlaveSupport/ews-build/master.cfg:
3940
3941 2019-01-29  Keith Rollin  <krollin@apple.com>
3942
3943         Add .xcfilelists to Run Script build phases
3944         https://bugs.webkit.org/show_bug.cgi?id=193792
3945         <rdar://problem/47201785>
3946
3947         Reviewed by Alex Christensen.
3948
3949         As part of supporting XCBuild, update the necessary Run Script build
3950         phases in their Xcode projects to refer to their associated
3951         .xcfilelist files.
3952
3953         Note that the addition of these files bumps the Xcode project version
3954         number to something that's Xcode 10 compatible. This change means that
3955         older versions of the Xcode IDE can't read these projects. Nor can it
3956         fully load workspaces that refer to these projects (the updated
3957         projects are shown as non-expandable placeholders). `xcodebuild` can
3958         still build these projects; it's just that the IDE can't open them.
3959
3960         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3961         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3962
3963 2019-01-29  John Wilander  <wilander@apple.com>
3964
3965         Add data abstraction and validation for Ad Click Attribution
3966         https://bugs.webkit.org/show_bug.cgi?id=193916
3967         <rdar://problem/47603481>
3968
3969         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3970
3971         Ad click attribution has two steps. First, the storage of an ad
3972         campaign ID for a click that takes the user to a destination
3973         site. Second, a conversion on the destination site that can be
3974         attributed to the ad click.
3975
3976         This patch adds a class that represents a request for ad click
3977         attribution. Validation makes sure that the bits of entropy
3978         reported through this mechanism is limited.
3979
3980         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3981         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3982         (TestWebKitAPI::TEST):
3983
3984 2019-01-29  Chris Dumez  <cdumez@apple.com>
3985
3986         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3987         https://bugs.webkit.org/show_bug.cgi?id=193932
3988         <rdar://problem/47598947>
3989
3990         Reviewed by Brady Eidson.
3991
3992         Add API test coverage.
3993
3994         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3995
3996 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3997
3998         Adding new passing LFC tests.
3999
4000         Unreviewed test gardening.
4001
4002         * LayoutReloaded/misc/LFC-passing-tests.txt:
4003
4004 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4005
4006         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
4007         https://bugs.webkit.org/show_bug.cgi?id=193964
4008
4009         Reviewed by Antti Koivisto.
4010
4011         * LayoutReloaded/misc/LFC-passing-tests.txt:
4012
4013 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4014
4015         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
4016         https://bugs.webkit.org/show_bug.cgi?id=193954
4017
4018         Reviewed by Antti Koivisto.
4019
4020         * LayoutReloaded/misc/LFC-passing-tests.txt:
4021
4022 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
4023
4024         WebDriver: add support for running subtests
4025         https://bugs.webkit.org/show_bug.cgi?id=193904
4026
4027         Reviewed by Michael Catanzaro.
4028
4029         pytest already supports it by passing test.py::subtest, so we can do the same.
4030
4031         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
4032         (get_item_name): Made this global.
4033         (CollectRecorder.__init__): Receive the parameter to ignore.
4034         (CollectRecorder.pytest_collectreport): Collect also the subtests.
4035         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
4036         (collect): Add parameter to ignore.
4037         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
4038         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
4039         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
4040         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
4041         (WebDriverTestRunnerSelenium.run): Ditto.
4042         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
4043         (WebDriverTestRunnerW3C.collect_tests): Ditto.
4044         (WebDriverTestRunnerW3C.run): Ditto.
4045
4046 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
4047
4048         User agent string override for navigator.userAgent should be site specific quirks
4049         https://bugs.webkit.org/show_bug.cgi?id=193950
4050
4051         Reviewed by Brent Fulgham.
4052
4053         Updated per the _WKWebsitePolicies rename.
4054
4055         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4056         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4057
4058 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
4059
4060         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
4061         https://bugs.webkit.org/show_bug.cgi?id=193941
4062
4063         Reviewed by Alex Christensen.
4064
4065         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
4066         * TestWebKitAPI/Tests/WTF/Condition.cpp:
4067         * TestWebKitAPI/Tests/WTF/Lock.cpp:
4068         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
4069         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
4070         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
4071         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
4072         * TestWebKitAPI/Tests/WTF/Time.cpp:
4073         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
4074         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
4075         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
4076         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
4077
4078 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
4079
4080         Unreviewed, reorder my emails to fix autocomplete in bugzilla
4081
4082         * Scripts/webkitpy/common/config/contributors.json:
4083
4084 2019-01-28  Andy Estes  <aestes@apple.com>
4085
4086         [watchOS] Enable Parental Controls content filtering
4087         https://bugs.webkit.org/show_bug.cgi?id=193939
4088         <rdar://problem/46641912>
4089
4090         Reviewed by Ryosuke Niwa.
4091
4092         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4093
4094 2019-01-28  David Kilzer  <ddkilzer@apple.com>
4095
4096         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
4097         <https://webkit.org/b/193884>
4098
4099         Reviewed by Jiewen Tan.
4100
4101         * Scripts/webkitpy/style/checkers/cpp.py:
4102         (check_language): Add LocalAuthentication to
4103         `frameworks_with_soft_links`.
4104
4105 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
4106
4107         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
4108         https://bugs.webkit.org/show_bug.cgi?id=193891
4109
4110         Reviewed by Ross Kirsling.
4111
4112         There were three problems in window sizes of WebView and the host window.
4113         1. The sizes of pixel image output were incorrect.
4114         2. The host window is going to appear after window.resize was invoked.
4115         3. window.resize resized only the host window, not WebView.
4116
4117         This change solves them with a following approach.
4118         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
4119         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
4120            as well as DumpRenderTree in order to match the client area and the window area.
4121         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
4122         d. PlatformWebView::setWindowFrame changes both window sizes.
4123         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
4124
4125         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4126         (WTR::PlatformWebView::PlatformWebView): Create the host window
4127         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
4128         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
4129         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
4130
4131 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4132
4133         [ews-app] Add method to save Step data to database
4134         https://bugs.webkit.org/show_bug.cgi?id=193890
4135
4136         Reviewed by Lucas Forschler.
4137
4138         * BuildSlaveSupport/ews-app/ews/models/step.py:
4139         (Step.save_step): Method to save step data.
4140         (Step.update_step): Method to update step data.
4141         (Step.get_existing_step): Method to fetch existing step from database.
4142         (Step.is_valid_result): Method to validate valid step result.
4143
4144 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4145
4146         [ews-app] Add method to save Build data to database
4147         https://bugs.webkit.org/show_bug.cgi?id=193735
4148
4149         Reviewed by Lucas Forschler.
4150
4151         * BuildSlaveSupport/ews-app/ews/models/build.py:
4152         (Build.save_build): Method to save build information to database.
4153         (Build.get_existing_build): Method to fetch existing build from database.
4154         (Build.is_valid_result): Method to validate build result.
4155         * BuildSlaveSupport/ews-app/ews/common/util.py:
4156         (is_valid_int_id): Method to validate valid id.
4157
4158 2019-01-28  Chris Dumez  <cdumez@apple.com>
4159
4160         Regression(PSON) Crash under WebPageProxy::didStartProgress()
4161         https://bugs.webkit.org/show_bug.cgi?id=193915
4162         <rdar://problem/47560907>
4163
4164         Reviewed by Alex Christensen.
4165
4166         Add API test coverage.
4167
4168         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4169
4170 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4171
4172         [ews-app] Rename id variables
4173         https://bugs.webkit.org/show_bug.cgi?id=193883
4174
4175         Reviewed by Lucas Forschler.
4176
4177         * BuildSlaveSupport/ews-app/ews/models/build.py:
4178         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
4179         * BuildSlaveSupport/ews-app/ews/models/step.py:
4180         * BuildSlaveSupport/ews-app/ews/urls.py:
4181         * BuildSlaveSupport/ews-app/ews/views/patch.py:
4182         * BuildSlaveSupport/ews-app/ews/views/results.py:
4183         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4184
4185 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4186
4187         [ews-app] Allow certain fields to be empty
4188         https://bugs.webkit.org/show_bug.cgi?id=193892
4189
4190         Reviewed by Lucas Forschler.
4191
4192         * BuildSlaveSupport/ews-app/ews/models/build.py:
4193         * BuildSlaveSupport/ews-app/ews/models/step.py:
4194
4195 2019-01-28  Rob Buis  <rbuis@igalia.com>
4196
4197         Update MIME type parser
4198         https://bugs.webkit.org/show_bug.cgi?id=180526
4199
4200         Reviewed by Frédéric Wang.
4201
4202         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4203         (TestWebKitAPI::TEST):
4204
4205 2019-01-28  Zalan Bujtas  <zalan@apple.com>
4206
4207         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
4208         https://bugs.webkit.org/show_bug.cgi?id=193896
4209
4210         Reviewed by Antti Koivisto.
4211
4212         * LayoutReloaded/misc/LFC-passing-tests.txt:
4213
4214 2018-12-15  Darin Adler  <darin@apple.com>
4215
4216         Replace many uses of String::format with more type-safe alternatives
4217         https://bugs.webkit.org/show_bug.cgi?id=192742
4218
4219         Reviewed by Mark Lam.
4220
4221         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4222         (WTR::cacheTestRunnerCallback): Use makeString.
4223         * WebKitTestRunner/TestController.cpp:
4224         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
4225         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
4226
4227 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
4228
4229         Use a load optimizer for some sites
4230         https://bugs.webkit.org/show_bug.cgi?id=193881
4231         <rdar://problem/46325455>
4232
4233         Reviewed by Brent Fulgham.
4234
4235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4236         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
4237
4238 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
4239
4240         AX: Introduce a static accessibility tree
4241         https://bugs.webkit.org/show_bug.cgi?id=193348
4242         <rdar://problem/47203295>
4243
4244         Reviewed by Ryosuke Niwa.
4245
4246         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4247
4248 2019-01-26  Zalan Bujtas  <zalan@apple.com>
4249
4250         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
4251         https://bugs.webkit.org/show_bug.cgi?id=193867
4252
4253         Reviewed by Antti Koivisto.
4254
4255         * LayoutReloaded/misc/LFC-passing-tests.txt:
4256
4257 2019-01-26  Zalan Bujtas  <zalan@apple.com>
4258
4259         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
4260         https://bugs.webkit.org/show_bug.cgi?id=193865
4261
4262         Reviewed by Antti Koivisto.
4263
4264         * LayoutReloaded/misc/LFC-passing-tests.txt:
4265
4266 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
4267
4268         Need a mechanism to override navigator.userAgent
4269         https://bugs.webkit.org/show_bug.cgi?id=193762
4270         <rdar://problem/47504939>
4271
4272         Reviewed by Brent Fulgham.
4273
4274         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
4275
4276         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4277         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4278         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
4279
4280 2019-01-25  Dean Jackson  <dino@apple.com>
4281
4282         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
4283         https://bugs.webkit.org/show_bug.cgi?id=193831
4284         <rdar://problem/47399263>
4285
4286         Reviewed by Chris Dumez.
4287
4288         Two new tests that exercise cross-origin and same-origin System
4289         Previews.
4290
4291         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4292
4293 2019-01-25  Keith Rollin  <krollin@apple.com>
4294
4295         Update Xcode projects with "Check .xcfilelists" build phase
4296         https://bugs.webkit.org/show_bug.cgi?id=193790
4297         <rdar://problem/47201374>
4298
4299         Reviewed by Alex Christensen.
4300
4301         Support for XCBuild includes specifying inputs and outputs to various
4302         Run Script build phases. These inputs and outputs are specified as
4303         .xcfilelist files. Once created, these .xcfilelist files need to be
4304         kept up-to-date. In order to check that they are up-to-date or not,
4305         add an Xcode build step that invokes an external script that performs
4306         the checking. If the .xcfilelists are found to be out-of-date, update
4307         them, halt the build, and instruct the developer to restart the build
4308         with up-to-date files.
4309
4310         At this time, the checking and regenerating is performed only if the
4311         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
4312         who want to use this facility can set this variable and test out the
4313         checking/regenerating. Once it seems like there are no egregious
4314         issues that upset a developer's workflow, we'll unconditionally enable
4315         this facility.
4316
4317         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4318         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
4319         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
4320         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4321
4322 2019-01-25  Keith Rollin  <krollin@apple.com>
4323
4324         Update Xcode projects with "Apply Configuration to XCFileLists" build target
4325         https://bugs.webkit.org/show_bug.cgi?id=193781
4326         <rdar://problem/47201153>
4327
4328         Reviewed by Alex Christensen.
4329
4330         Part of generating the .xcfilelists used as part of adopting XCBuild
4331         includes running `make DerivedSources.make` from a standalone script.
4332         It’s important for this invocation to have the same environment as
4333         when the actual build invokes `make DerivedSources.make`. If the
4334         environments are different, then the two invocations will provide
4335         different results. In order to get the same environment in the
4336         standalone script, have the script launch xcodebuild targeting the
4337         "Apply Configuration to XCFileLists" build target, which will then
4338         re-invoke our standalone script. The script is now running again, this
4339         time in an environment with all workspace, project, target, xcconfig
4340         and other environment variables established.
4341
4342         The "Apply Configuration to XCFileLists" build target accomplishes
4343         this task via a small embedded shell script that consists only of:
4344
4345             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
4346
4347         The process that invokes "Apply Configuration to XCFileLists" first
4348         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
4349         evaluated and exports it into the shell environment. When xcodebuild
4350         is invoked, it inherits the value of this variable and can `eval` the
4351         contents of that variable. Our external standalone script can then set
4352         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
4353         of command-line parameters needed to restart itself in the appropriate
4354         state.
4355
4356         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4357         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4358
4359 2019-01-25  Alex Christensen  <achristensen@webkit.org>
4360
4361         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
4362         https://bugs.webkit.org/show_bug.cgi?id=193802
4363         <rdar://problem/46010580>
4364
4365         Reviewed by Andy Estes.
4366
4367         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4368         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
4369         (TEST):
4370
4371 2019-01-25  Daniel Bates  <dabates@apple.com>
4372
4373         [iOS] uiController.keyDown() does not translate Control modified key
4374         https://bugs.webkit.org/show_bug.cgi?id=192898
4375
4376 &nbs