[Qt] Building when a top directory is named Source
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2
3         [Qt] Building when a top directory is named Source
4         https://bugs.webkit.org/show_bug.cgi?id=77727
5
6         Reviewed by Tor Arne Vestbø.
7
8         Change regex to only replace the last instance of OUT_PWD.
9
10         * qmake/mkspecs/features/default_pre.prf:
11
12 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
13
14         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
15         https://bugs.webkit.org/show_bug.cgi?id=73176
16
17         Reviewed by Adam Barth.
18
19         Two more APIs are added in Custom Scheme Handler specification.
20         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
21         One is 'isProtocolHandlerRegistered' to query whether the specific URL
22         is registered or not.
23         The other is 'unregisterProtocolHandler' to remove the registered URL.
24
25         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
26
27 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
28
29         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
30         https://bugs.webkit.org/show_bug.cgi?id=83879
31
32         Reviewed by Carlos Garcia Campos.
33
34         Make minibrowser connect to the new 'permission requests' signal
35         to allow users handle the Geolocation permission requests.
36
37         * MiniBrowser/gtk/BrowserWindow.c:
38         (geolocationRequestDialogCallback): Callback for the dialog asking
39         the user for allowing or not geolocation permission requests.
40         (webViewDecidePermissionRequest): Launch a dialog to ask the user
41         whether to allow or deny geolocation permission requests.
42         (browserWindowConstructed): Connect to 'permission-request' signal.
43
44 2012-06-04  Chase Phillips  <cmp@google.com>
45
46         Make a builder group support+expect multiple loads.
47         https://bugs.webkit.org/show_bug.cgi?id=88260
48
49         Change BuilderGroup to allow expecting multiple
50         loads.  This allows merging results for a given set
51         of builders into one group.
52
53         Add a test that verifies that the group count
54         increments correctly based on successful and failed
55         list loads.
56
57         Reviewed by Ojan Vafai.
58
59         * TestResultServer/static-dashboards/builders.js:
60         (BuilderGroup):
61         (BuilderGroup.prototype.setbuilder):
62         (BuilderGroup.prototype.append):
63         (BuilderGroup.prototype.loaded):
64         (requestBuilderList.xhr.onload):
65         (requestBuilderList.xhr.onerror):
66         (onErrorLoadingBuilderList):
67         (loadBuildersList):
68         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
69         (test):
70         * TestResultServer/static-dashboards/run-unittests.html:
71
72 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
73
74         Python test fix attempt for Chromium Windows.
75
76         * Scripts/webkitpy/layout_tests/port/driver.py:
77         (Driver.uri_to_test):
78
79 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
80
81         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
82         https://bugs.webkit.org/show_bug.cgi?id=88243
83
84         Reviewed by Adam Barth.
85
86         * qmake/mkspecs/features/features.prf:
87
88 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
89
90         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
91         https://bugs.webkit.org/show_bug.cgi?id=88280
92
93         Unreviewed, build fix.
94
95         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
96         (TestServerProcess.test_basic):
97
98 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
99
100         test-webkitpy is hanging under cygwin
101         https://bugs.webkit.org/show_bug.cgi?id=88269
102
103         Reviewed by Ryosuke Niwa.
104
105         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
106         so we need to skip any tests that use it.
107
108         * Scripts/webkitpy/common/system/executive.py:
109         (Executive.run_in_parallel):
110         * Scripts/webkitpy/common/system/executive_unittest.py:
111         (ExecutiveTest.test_run_in_parallel):
112
113 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
114
115         test-webkitpy is failing on win32 after r115054
116         https://bugs.webkit.org/show_bug.cgi?id=88264
117
118         Reviewed by Ryosuke Niwa.
119
120         The failing http_server test was improperly suppressed (the
121         tuple was missing a comma, and so wasn't a tuple at all, just a
122         string) and so we were skipping *all* tests on win32. The right
123         way to skip a single test is to disable it inside the test
124         itself.
125
126         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
127         (TestHttpServer.test_start_cmd):
128         * Scripts/webkitpy/test/test_finder.py:
129         (TestFinder._default_names):
130         * Scripts/webkitpy/test/main.py:
131         (Tester.run): Add error message if we don't find any tests to run.
132         * Scripts/webkitpy/test/main_unittest.py:
133             
134
135 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
136
137         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
138         https://bugs.webkit.org/show_bug.cgi?id=88215
139
140         Reviewed by Martin Robinson.
141
142         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
143         for newly allocated strings.
144
145         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
146         (attributeSetToString):
147         (AccessibilityUIElement::allAttributes):
148
149 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
150
151         [GTK] Memory leaks in DumpRenderTree.cpp
152         https://bugs.webkit.org/show_bug.cgi?id=88213
153
154         Reviewed by Martin Robinson.
155
156         Fixed memory leaks in DumpRenderTree.
157
158         * DumpRenderTree/gtk/DumpRenderTree.cpp:
159         (appendString): Accepts const gchar* as the second argument.
160         (dumpFramesAsText): Free the string returned by g_strdup_printf().
161         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
162
163 2012-06-04  David Dorwin  <ddorwin@chromium.org>
164
165         Enable Chromium media player to instantiate a plugin
166         https://bugs.webkit.org/show_bug.cgi?id=87399
167
168         Reviewed by Kent Tamura.
169
170         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
171
172         * DumpRenderTree/chromium/WebViewHost.cpp:
173         (WebViewHost::createPopupMenu):
174
175 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
176
177         [GTK][WK2] Implement geolocation provider for the GTK port
178         https://bugs.webkit.org/show_bug.cgi?id=83877
179
180         Reviewed by Carlos Garcia Campos.
181
182         * gtk/generate-gtkdoc:
183         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
184
185 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
186
187         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
188         https://bugs.webkit.org/show_bug.cgi?id=87668
189
190         Reviewed by Ryosuke Niwa.
191
192         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
193         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
194         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
195
196         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
197         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
198
199 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
200
201         [EFL] Refactor ewk_view_context_paint code.
202         https://bugs.webkit.org/show_bug.cgi?id=85588
203
204         Reviewed by Hajime Morita.
205
206         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
207
208 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
209
210         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
211         https://bugs.webkit.org/show_bug.cgi?id=87869
212
213         Reviewed by Andreas Kling.
214
215         Replace %lld by PRId64 macro to print an int64_t value and silent a
216         compilation warning on 64-Bit.
217
218         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
219         (onExceededApplicationCacheQuota):
220
221 2012-06-03  Varun Jain  <varunjain@google.com>
222
223         [chromium] Add new gesture type (two finger tap) that triggers context menu.
224         https://bugs.webkit.org/show_bug.cgi?id=88173
225
226         Reviewed by Adam Barth.
227
228         * DumpRenderTree/chromium/EventSender.cpp:
229         (EventSender::EventSender):
230         (EventSender::gestureTwoFingerTap):
231         (EventSender::gestureEvent):
232         * DumpRenderTree/chromium/EventSender.h:
233         (EventSender):
234
235 2012-06-02  Zeno Albisser  <zeno@webkit.org>
236
237         Fix and enable WebGL for WebKit2 on Qt.
238         https://bugs.webkit.org/show_bug.cgi?id=86214
239
240         Enable WebGL by default for Qt MiniBrowser.
241
242         Reviewed by Noam Rosenthal.
243
244         * MiniBrowser/qt/qml/BrowserWindow.qml:
245
246 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
247
248         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
249         https://bugs.webkit.org/show_bug.cgi?id=88164
250
251         Reviewed by Kentaro Hara.
252
253         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
254         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
255
256         * Scripts/VCSUtils.pm:
257         (adjustPathForRecentRenamings):
258         (fixChangeLogPatch):
259
260 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
261
262         Rename test_expectations.txt to TestExpectations
263         https://bugs.webkit.org/show_bug.cgi?id=86690
264
265         Reviewed by Dirk Pranke.
266
267         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
268         We can the code to read test_expectations.txt once we've successfully transitioned.
269
270         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
271         (TestExpectationParser._check_path_does_not_exist):
272         (TestExpectationParser._tokenize):
273         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
274         * Scripts/webkitpy/layout_tests/port/base.py:
275         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
276         test_expectations.txt if one exists and the path to TestExpectations otherwise.
277         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
278         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
279         virtual.
280         * Scripts/webkitpy/layout_tests/port/chromium.py:
281         (ChromiumPort.path_from_chromium_base):
282         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
283         (ChromiumAndroidPort.test_expectations):
284         * Scripts/webkitpy/layout_tests/port/test.py:
285         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
286         (TestPort.__init__):
287         * Scripts/webkitpy/layout_tests/port/webkit.py:
288         (WebKitPort.baseline_search_path):
289         (WebKitPort.test_expectations):
290         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
291         tests to base as a follow up.
292         (WebKitPortTest.test_path_to_test_expectations_file):
293         (test_test_expectations):
294         (test_legacy_test_expectations):
295         * Scripts/webkitpy/style/checker.py:
296         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
297         with one for TestExpectations.
298         * Scripts/webkitpy/style/checkers/test_expectations.py:
299         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
300         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
301         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
302         test_expectations.txt.
303         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
304         (TestExpectationsTestCase.assert_lines_lint):
305         * Scripts/webkitpy/tool/commands/queries.py:
306         (PrintExpectations.__init__):
307         * Scripts/webkitpy/tool/commands/rebaseline.py:
308         (RebaselineExpectations):
309         * Scripts/webkitpy/tool/steps/commit.py:
310         (Commit._check_test_expectations):
311         * Scripts/webkitpy/tool/steps/commit_unittest.py:
312         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
313         (CommitTest.test_check_test_expectations): For TestExpectations.
314         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
315         * TestResultServer/static-dashboards/dashboard_base.js:
316         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
317         Error only when neither exists.
318         * TestResultServer/static-dashboards/flakiness_dashboard.js:
319         (processMissingAndExtraExpectations):
320         (htmlForTestsWithExpectationsButNoFailures):
321         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
322
323 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
324
325         Remove dependency from ImageDiff to WTF
326         https://bugs.webkit.org/show_bug.cgi?id=88147
327
328         Reviewed by Adam Barth.
329
330         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
331
332 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
333
334         NRWT seems to leak (more?) temp dirs
335         https://bugs.webkit.org/show_bug.cgi?id=88126
336
337         Re-land r119297 with chromium fix (weren't calling the
338         super() method if not in --test-shell mode in start().
339         Add unit tests to chromium_unittest as well to check.
340
341         * Scripts/webkitpy/layout_tests/port/chromium.py:
342         (ChromiumDriver.start):
343         * Scripts/webkitpy/layout_tests/port/webkit.py:
344         (WebKitDriver.__del__):
345         (WebKitDriver._start):
346         (WebKitDriver.run_test):
347         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
348         (WebKitDriverTest.test_check_for_driver_crash):
349         (WebKitDriverTest.test_stop_cleans_up_properly):
350         (WebKitDriverTest):
351         (WebKitDriverTest.test_two_starts_cleans_up_properly):
352         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
353         (ChromiumDriverTest.test_stop_cleans_up_properly):
354         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
355
356 2012-06-01  Tim Horton  <timothy_horton@apple.com>
357
358         Lots of "failed download-built-product" on Apple bots
359         https://bugs.webkit.org/show_bug.cgi?id=88158
360
361         Reviewed by Jessie Berlin.
362         
363         Disable mergeRequests on all Apple builders. This is a speculative fix.
364
365         * BuildSlaveSupport/build.webkit.org-config/config.json:
366
367 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
368
369         Unreviewed, rolling out r119297.
370         http://trac.webkit.org/changeset/119297
371         https://bugs.webkit.org/show_bug.cgi?id=88156
372
373         May have broken Chromium bots (Requested by rniwa on #webkit).
374
375         * Scripts/webkitpy/layout_tests/port/webkit.py:
376         (WebKitDriver.__del__):
377         (WebKitDriver.run_test):
378         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
379         (WebKitDriverTest.test_check_for_driver_crash):
380         (WebKitDriverTest.test_stop_cleans_up_properly):
381
382 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
383
384         nrwt seems to leak tmpdirs
385         https://bugs.webkit.org/show_bug.cgi?id=88126
386
387         Reviewed by Ojan Vafai.
388
389         Fix leak possibly introduced in r118979 - we now will
390         make sure we clean up any stale temp directories during the
391         start routine and attempt to clean up again in __del__. It
392         turns out that asserting in __del__ logs a message but is
393         caught by the runtime, so it's mostly useless.
394
395         * Scripts/webkitpy/layout_tests/port/webkit.py:
396         (WebKitDriver.__del__):
397         (WebKitDriver._start):
398         (WebKitDriver.run_test):
399         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
400         (WebKitDriverTest.test_check_for_driver_crash):
401         (WebKitDriverTest.test_stop_cleans_up_properly):
402         (WebKitDriverTest):
403         (WebKitDriverTest.test_two_starts_cleans_up_properly):
404
405 2012-06-01  Michael Saboff  <msaboff@apple.com>
406
407         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
408         https://bugs.webkit.org/show_bug.cgi?id=88109
409
410         Reviewed by Geoffrey Garen.
411
412         Additional test case.
413
414         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
415         (TestWebKitAPI::TEST):
416
417 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
418
419         [Qt] Use -Werror only in developer builds
420
421         Rubber-stamped by Tor Arne Vestbø.
422
423         In production builds -Werror with custom toolchains and wierd system
424         headers, -Werror is of no use and just creates confusion. So use it
425         only if Qt is configured with -developer-build.
426
427         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
428         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
429         only if qt_developer_build is set.
430
431 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
432
433         [watchlist] Add myself to loader and v8 bindings changes
434         https://bugs.webkit.org/show_bug.cgi?id=88112
435
436         Reviewed by Adam Barth.
437
438         * Scripts/webkitpy/common/config/watchlist:
439
440 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
441
442         Adding Jacky Jiang to committers.py
443         https://bugs.webkit.org/show_bug.cgi?id=88122
444
445         Reviewed by Rob Buis.
446
447         Adding myself to committers.py as a Committer.
448
449         * Scripts/webkitpy/common/config/committers.py:
450
451 2012-06-01  Jessie Berlin  <jberlin@apple.com>
452
453         Fix Windows build.
454
455         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
456
457 2012-06-01  Jessie Berlin  <jberlin@apple.com>
458
459         Windows WK2 MouseMoveAfterCrash API test failing
460         https://bugs.webkit.org/show_bug.cgi?id=69982
461
462         Disable the test on Windows to get the bots greener.
463
464         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
465         (TestWebKitAPI::TEST):
466
467 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
468
469         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
470         https://bugs.webkit.org/show_bug.cgi?id=86866
471
472         Reviewed by Adam Barth.
473
474         Catch new "intent,service,register" signal on the frame and print out
475         information about the Web Intent service in EFL's DumpRenderTree.
476
477         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
478         (DumpRenderTreeChrome::createView):
479         (DumpRenderTreeChrome::onFrameCreated):
480         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
481         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
482         (DumpRenderTreeChrome):
483
484 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
485
486         The ChangeLog parser cannot handle reviewers with initials in their name
487         https://bugs.webkit.org/show_bug.cgi?id=87864
488
489         Reviewed by Ryosuke Niwa.
490
491         Add support in the ChangeLog parser for reviewer names that have
492         initials in them.
493
494         * Scripts/webkitpy/common/checkout/changelog.py:
495         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
496         in the replacement string. This allows for matching the word characters before a
497         period, without totally throwing them away.
498         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
499         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
500         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
501
502 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
503
504         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
505         https://bugs.webkit.org/show_bug.cgi?id=86865
506
507         Reviewed by Adam Barth.
508
509         Add deliverWebIntent method to LayoutTestController and provide
510         implementation for EFL port.
511
512         * DumpRenderTree/LayoutTestController.cpp:
513         (deliverWebIntentCallback):
514         (LayoutTestController::staticFunctions):
515         * DumpRenderTree/LayoutTestController.h:
516         (LayoutTestController):
517         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
518         (LayoutTestController::deliverWebIntent):
519         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
520         (LayoutTestController::deliverWebIntent):
521         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
522         (LayoutTestController::deliverWebIntent):
523         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
524         (LayoutTestController::deliverWebIntent):
525         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
526         (LayoutTestController::deliverWebIntent):
527         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
528         (LayoutTestController::deliverWebIntent):
529
530 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
531
532         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
533
534         Reviewed by Simon Hausmann.
535
536         * Tools.pro:
537
538 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
539
540         Add public page loading performance tests using web-page-replay
541         https://bugs.webkit.org/show_bug.cgi?id=84008
542
543         Reviewed by Dirk Pranke.
544
545         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
546         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
547         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
548
549         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
550         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
551         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
552         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
553
554         * Scripts/webkitpy/layout_tests/port/driver.py:
555         (Driver.is_external_http_test): Added.
556         * Scripts/webkitpy/layout_tests/port/webkit.py:
557         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
558         * Scripts/webkitpy/performance_tests/perftest.py:
559         (PerfTest.__init__): Takes port.
560         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
561         (PerfTest):
562         (PerfTest.run): Calls run_single.
563         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
564         (ChromiumStylePerfTest.__init__):
565         (PageLoadingPerfTest.__init__):
566         (PageLoadingPerfTest.run):
567         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
568         (ReplayServer.__init__):
569         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
570         but it caused a dead lock on some web pages.
571         (ReplayServer.stop):
572         (ReplayServer.__del__):
573         (ReplayPerfTest):
574         (ReplayPerfTest.__init__):
575         (ReplayPerfTest._start_replay_server):
576         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
577         The subsequent runs of the same test will just use test.wpr.
578         (ReplayPerfTest.run_single):
579         (PerfTestFactory):
580         (PerfTestFactory.create_perf_test):
581         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
582         (MainTest.test_parse_output):
583         (MainTest.test_parse_output_with_failing_line):
584         (TestPageLoadingPerfTest.test_run):
585         (TestPageLoadingPerfTest.test_run_with_bad_output):
586         (TestReplayPerfTest):
587         (TestReplayPerfTest.ReplayTestPort):
588         (TestReplayPerfTest.ReplayTestPort.__init__):
589         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
590         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
591         (TestReplayPerfTest.ReplayTestPort._driver_class):
592         (TestReplayPerfTest.MockReplayServer):
593         (TestReplayPerfTest.MockReplayServer.__init__):
594         (TestReplayPerfTest.MockReplayServer.stop):
595         (TestReplayPerfTest._add_file):
596         (TestReplayPerfTest._setup_test):
597         (TestReplayPerfTest.test_run_single):
598         (TestReplayPerfTest.test_run_single.run_test):
599         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
600         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
601         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
602         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
603         (TestReplayPerfTest.test_prepare):
604         (TestReplayPerfTest.test_prepare.run_test):
605         (TestReplayPerfTest.test_prepare_calls_run_single):
606         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
607         (TestPerfTestFactory.test_regular_test):
608         (TestPerfTestFactory.test_inspector_test):
609         (TestPerfTestFactory.test_page_loading_test):
610         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
611         (PerfTestsRunner):
612         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
613         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
614         (PerfTestsRunner._collect_tests._is_test_file):
615         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
616         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
617         (create_runner):
618         (run_test):
619         (_tests_for_runner):
620         (test_run_test_set):
621         (test_run_test_set_kills_drt_per_run):
622         (test_run_test_pause_before_testing):
623         (test_run_test_set_for_parser_tests):
624         (test_run_test_set_with_json_output):
625         (test_run_test_set_with_json_source):
626         (test_run_test_set_with_multiple_repositories):
627         (test_run_with_upload_json):
628         (test_upload_json):
629         (test_upload_json.MockFileUploader.upload_single_text_file):
630         (_add_file):
631         (test_collect_tests):
632         (test_collect_tests_with_multile_files):
633         (test_collect_tests_with_multile_files.add_file):
634         (test_collect_tests_with_skipped_list):
635         (test_collect_tests_with_page_load_svg):
636         (test_collect_tests_should_ignore_replay_tests_by_default):
637         (test_collect_tests_with_replay_tests):
638         (test_parse_args):
639         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
640         (AutoinstallImportHook.find_module):
641         (AutoinstallImportHook._install_webpagereplay):
642
643 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
644
645         Support building the Android port of chromium with Ninja
646         https://bugs.webkit.org/show_bug.cgi?id=87545
647
648         Reviewed by Adam Barth.
649
650         Ensures that shared libraries are looked up in a generator-agnostic
651         way and that output is placed in the correct directory.
652
653         Depends on http://codereview.chromium.org/10386188/
654
655         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
656
657 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
658
659         [Chromium] Chromium DRT should be able to load external resources
660         https://bugs.webkit.org/show_bug.cgi?id=87893
661
662         Reviewed by Dirk Pranke.
663
664         Allow external resources to be loaded when the main frame's URL is also an external resource.
665         This change is analogous to r118231 for Mac port.
666
667         * DumpRenderTree/chromium/WebViewHost.cpp:
668         (blockRequest):
669         (isLocalhost):
670         (hostIsUsedBySomeTestsToGenerateError):
671         (WebViewHost::willSendRequest):
672
673 2012-05-31  Anders Carlsson  <andersca@apple.com>
674
675         Build fixes.
676
677         Disable the C++11 extensions warning.
678
679         * DumpRenderTree/mac/Configurations/Base.xcconfig:
680         * TestWebKitAPI/Configurations/Base.xcconfig:
681         * WebKitTestRunner/Configurations/Base.xcconfig:
682
683 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
684
685         [WK2] window.internals settings are not reset between tests
686         https://bugs.webkit.org/show_bug.cgi?id=87783
687
688         Reviewed by Mihai Parparita.
689
690         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
691         (WTR::InjectedBundle::done): Call resetAfterTest().
692
693         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
694         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
695         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
696         This needs to be done after a tets, because the code assumes that there is an object
697         with this name in global scope.
698
699         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
700
701 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
702
703         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
704         https://bugs.webkit.org/show_bug.cgi?id=85006
705
706         Reviewed by Tor Arne Vestbø.
707
708         Added navigation_policy_decision implementation for DumpRenderTreeView.
709         Added LayoutTestController::setCustomPolicyDelegate implementation.
710         Modified LayoutTestController::waitForPolicyDelegate.
711
712         * DumpRenderTree/efl/DumpRenderTree.cpp:
713         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
714         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
715         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
716         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
717         (navigationTypeToString): aux function
718         (onNavigationPolicyDecision): navigation_policy_decision implementation
719         (drtViewAdd):
720         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
721         (LayoutTestController::setCustomPolicyDelegate):
722         (LayoutTestController::waitForPolicyDelegate):
723
724 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
725
726         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
727         https://bugs.webkit.org/show_bug.cgi?id=86195
728
729         Reviewed by Gustavo Noronha Silva.
730
731         Implement clearApplicationCacheForOrigin in EFL
732         LayoutTestController.
733
734         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
735         (LayoutTestController::clearApplicationCacheForOrigin):
736
737 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
738
739         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
740         https://bugs.webkit.org/show_bug.cgi?id=87955
741
742         Reviewed by Simon Hausmann.
743
744         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
745         * DumpRenderTree/qt/EventSenderQt.cpp:
746         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
747         * DumpRenderTree/qt/main.cpp:
748         * QtTestBrowser/cookiejar.cpp:
749         * QtTestBrowser/launcherwindow.cpp:
750         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
751         * qmake/mkspecs/features/default_post.prf:
752
753 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
754
755         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
756
757         Rubber-stamped by Kenneth Rohde Christiansen.
758
759         * qmake/config.tests/libpng/libpng.pro:
760
761 2012-05-30  Peter Beverloo  <peter@chromium.org>
762
763         [Chromium] Automatically install 64-bit linker for Android
764         https://bugs.webkit.org/show_bug.cgi?id=79780
765
766         Reviewed by Adam Barth.
767
768         Change the update-webkit-chromium script to check whether the 64-bit
769         linker needs to be installed as part of the update process. The actual
770         code for doing these checks and "installing" it has been added to the
771         webkitdirs.pm script.
772
773         The linker itself is part of the third_party/aosp repository, which
774         will be pulled in through the DEPS change.
775
776         * Scripts/update-webkit-chromium:
777         * Scripts/webkitdirs.pm:
778         (chromiumInstall64BitAndroidLinkerIfNeeded):
779         (chromiumReplaceAndroidLinkerIfNeeded):
780
781 2012-05-30  Stephanie Lewis  <slewis@apple.com>
782
783         https://bugs.webkit.org/show_bug.cgi?id=87803
784         Layout tests often fail trying to stat nonexistent logs 
785
786         Reviewed by Dirk Pranke.
787
788         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
789         try/catch block around accessing the logs as a precaution.
790
791         * Scripts/webkitpy/common/system/crashlogs.py:
792         (CrashLogs._find_newest_log_darwin):
793
794 2012-05-30  Gavin Peters  <gavinp@chromium.org>
795
796         Add a LayoutTest for prerender remove after stop.
797         https://bugs.webkit.org/show_bug.cgi?id=87860
798
799         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
800         can be tested by LayoutTests now.
801
802         Reviewed by Adam Barth.
803
804         * DumpRenderTree/DumpRenderTree.gypi:
805         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
806         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
807         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
808         (MockWebPrerenderingSupport::add):
809         (MockWebPrerenderingSupport::cancel):
810         (MockWebPrerenderingSupport::abandon):
811         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
812         (MockWebPrerenderingSupport):
813         * DumpRenderTree/chromium/TestShell.cpp:
814         (TestShell::initialize):
815         * DumpRenderTree/chromium/TestShell.h:
816         (TestShell):
817         * DumpRenderTree/chromium/WebViewHost.cpp:
818         (WebViewHost::willAddPrerender):
819         (WebViewHost::setWebWidget):
820         * DumpRenderTree/chromium/WebViewHost.h:
821         (WebViewHost):
822
823 2012-05-30  Stephanie Lewis  <slewis@apple.com>
824
825         https://bugs.webkit.org/show_bug.cgi?id=87717
826         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
827
828         Reviewed by Dirk Pranke.
829
830         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
831         If there isn't a crash log found for the process add a message saying
832         the process was unresponsive.
833
834         * Scripts/webkitpy/layout_tests/port/webkit.py:
835         (WebKitDriver.__init__):
836         (WebKitDriver._check_for_driver_crash):
837         (WebKitDriver.run_test):
838         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
839         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
840         (WebKitDriverTest):
841         (WebKitDriverTest.test_check_for_driver_crash):
842         * WebKitTestRunner/TestController.cpp:
843         (WTR):
844         (WTR::TestController::runTest):
845
846 2012-05-30  Stephanie Lewis  <slewis@apple.com>
847
848         https://bugs.webkit.org/show_bug.cgi?id=87714
849         Mac crash logs can take a really long time to be written out.
850
851         Reviewed by Dirk Pranke.
852
853         Make a second pass looking for crash logs after the tests have completed running.
854
855         * Scripts/webkitpy/layout_tests/controllers/manager.py:
856         (use_trac_links_in_results_html):
857         (Manager.run):
858         * Scripts/webkitpy/layout_tests/port/base.py:
859         (Port.repository_paths):
860         (Port.look_for_new_crash_logs):
861         * Scripts/webkitpy/layout_tests/port/mac.py:
862         (MacPort.look_for_new_crash_logs):
863         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
864         (test_get_crash_log):
865         (test_look_for_new_crash_logs):
866         (test_look_for_new_crash_logs.fake_time_cb):
867
868 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
869
870         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
871
872         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
873         (LayoutWebViewEventHandler::OnAlertEvent):
874         (LayoutWebViewEventHandler::OnConfirmEvent):
875         (LayoutWebViewEventHandler):
876         (LayoutWebViewEventHandler::OnPromptEvent):
877         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
878         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
879
880 2012-05-30  Ojan Vafai  <ojan@chromium.org>
881
882         Only give lint errors for -expected.png png files that lack a checksum
883         https://bugs.webkit.org/show_bug.cgi?id=87875
884
885         Reviewed by Tony Chang.
886
887         We have other pngs in the tree, e.g. for the inspector, that legitimately
888         lack a checksum.
889
890         * Scripts/webkitpy/style/checkers/png.py:
891         (PNGChecker.check):
892         * Scripts/webkitpy/style/checkers/png_unittest.py:
893         (PNGCheckerTest.test_check):
894
895 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
896
897         nrwt: seems to leak temp dirs
898         https://bugs.webkit.org/show_bug.cgi?id=87795
899
900         Reviewed by Ojan Vafai.
901
902         There appears to be a bug where the chromium bots are creating
903         temporary directories and not cleaning them up that started
904         after the switch to WebKitDriver. It's possible that __del__
905         wasn't getting called in a timely manner (or at all), and it's
906         generally bad style to rely on __del__ being called, so this
907         code changes things so that we create a temp dir in
908         driver.start() and remove it in driver.stop(). We could be
909         paranoid and leave the __del__ code in, but there doesn't seem
910         to be much advantage to it. If there are bugs that result in
911         drivers being started but not stopped, we have other problems.
912
913         * Scripts/webkitpy/common/system/filesystem_mock.py:
914         (MockFileSystem.__init__):
915         (MockFileSystem._mktemp):
916         (MockFileSystem.mkdtemp):
917         * Scripts/webkitpy/layout_tests/port/webkit.py:
918         (WebKitDriver.__init__):
919         (WebKitDriver._start):
920         (WebKitDriver.stop):
921         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
922         (WebKitDriverTest.test_check_for_driver_crash):
923         (WebKitDriverTest):
924         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
925         (WebKitDriverTest.test_stop_cleans_up_properly):
926
927 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
928
929         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
930         https://bugs.webkit.org/show_bug.cgi?id=86841
931
932         Reviewed by Adam Barth.
933
934         Print the number of MessagePorts for each new intent in EFL's DRT.
935         This output is expected by several Web Intents test cases.
936
937         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
938         (DumpRenderTreeChrome::onFrameIntentNew):
939
940 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
941
942         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
943
944         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
945
946 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
947
948         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
949         https://bugs.webkit.org/show_bug.cgi?id=87829
950
951         Reviewed by Adam Barth.
952
953         EFL's LayoutTestController now makes uses of the new helper method in
954         DumpRenderTreeSupportEfl in order to send the intent response. This is
955         now needed because the Ewk_Intent_Request postResult / postFailure
956         methods were made private.
957
958         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
959         (LayoutTestController::sendWebIntentResponse):
960
961 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
962
963         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
964         https://bugs.webkit.org/show_bug.cgi?id=86296
965
966         Reviewed by Tony Chang.
967
968         * DumpRenderTree/win/DRTDataObject.cpp: Added.
969         (cfHDropFormat):
970         (cfFileNameWFormat):
971         (cfUrlWFormat):
972         (WCEnumFormatEtc):
973         (WCEnumFormatEtc::WCEnumFormatEtc):
974         (WCEnumFormatEtc::QueryInterface):
975         (WCEnumFormatEtc::AddRef):
976         (WCEnumFormatEtc::Release):
977         (WCEnumFormatEtc::Next):
978         (WCEnumFormatEtc::Skip):
979         (WCEnumFormatEtc::Reset):
980         (WCEnumFormatEtc::Clone):
981         (DRTDataObject::createInstance):
982         (DRTDataObject::DRTDataObject):
983         (DRTDataObject::~DRTDataObject):
984         (DRTDataObject::QueryInterface):
985         (DRTDataObject::AddRef):
986         (DRTDataObject::Release):
987         (DRTDataObject::GetData):
988         (DRTDataObject::GetDataHere):
989         (DRTDataObject::QueryGetData):
990         (DRTDataObject::GetCanonicalFormatEtc):
991         (DRTDataObject::SetData):
992         (DRTDataObject::CopyMedium):
993         (DRTDataObject::EnumFormatEtc):
994         (DRTDataObject::DAdvise):
995         (DRTDataObject::DUnadvise):
996         (DRTDataObject::EnumDAdvise):
997         (DRTDataObject::clearData):
998         * DumpRenderTree/win/DRTDataObject.h: Added.
999         (DRTDataObject):
1000         * DumpRenderTree/win/DRTDropSource.cpp: Added.
1001         (DRTDropSource::DRTDropSource):
1002         (DRTDropSource::~DRTDropSource):
1003         (DRTDropSource::QueryInterface):
1004         (DRTDropSource::AddRef):
1005         (DRTDropSource::Release):
1006         (DRTDropSource::createInstance):
1007         (DRTDropSource::QueryContinueDrag):
1008         (DRTDropSource::GiveFeedback):
1009         * DumpRenderTree/win/DRTDropSource.h: Added.
1010         (DRTDropSource):
1011         * DumpRenderTree/win/DumpRenderTree.vcproj:
1012         * DumpRenderTree/win/EventSender.cpp:
1013         (beginDragWithFilesCallback):
1014
1015 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
1016
1017         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
1018         https://bugs.webkit.org/show_bug.cgi?id=58593
1019
1020         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
1021         to WebKitTestRunner's LayoutTestController. The flag is modified via the
1022         public C API of the WebProcess.
1023
1024         Reviewed by Darin Adler.
1025
1026         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1027         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1028         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
1029         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
1030         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1031
1032 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1033
1034         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
1035         https://bugs.webkit.org/show_bug.cgi?id=87848
1036
1037         Reviewed by Csaba Osztrogonác.
1038
1039         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
1040         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
1041         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
1042
1043         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1044         (DumpRenderTreeChrome::extraViews):
1045         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1046         (DumpRenderTreeChrome):
1047
1048 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1049
1050         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
1051         https://bugs.webkit.org/show_bug.cgi?id=87833
1052
1053         Reviewed by Tor Arne Vestbø.
1054
1055         Print "postProgressFinishedNotification" message if frame load finished 
1056         to unskip http/tests/loading/progress-finished-callback.html.
1057
1058         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1059         (DumpRenderTreeChrome::onFrameLoadFinished):
1060
1061 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
1062
1063         [EFL][WK2] Fix WebKit2-EFL build
1064         https://bugs.webkit.org/show_bug.cgi?id=83693
1065
1066         Reviewed by Carlos Garcia Campos.
1067
1068         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
1069
1070 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
1071
1072         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
1073         (They only used to check for Skipped in platform/qt-5.0-wk1)
1074         https://bugs.webkit.org/show_bug.cgi?id=87376
1075
1076         Reviewed by Csaba Osztrogonác.
1077
1078         * Scripts/old-run-webkit-tests:
1079         (buildPlatformResultHierarchy):
1080         * Scripts/webkitpy/layout_tests/port/qt.py:
1081         (QtPort.baseline_search_path):
1082
1083 2012-05-29  Ojan Vafai  <ojan@chromium.org>
1084
1085         Add a linter error for pngs that lack an embedded checksum
1086         https://bugs.webkit.org/show_bug.cgi?id=87793
1087
1088         Reviewed by Dirk Pranke.
1089
1090         * Scripts/read-checksum-from-png:
1091         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
1092         (read_checksum):
1093         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
1094         (ReadChecksumFromPngTest):
1095         (ReadChecksumFromPngTest.test_read_checksum):
1096         * Scripts/webkitpy/layout_tests/port/base.py:
1097         * Scripts/webkitpy/style/checkers/png.py:
1098         (PNGChecker.check):
1099         * Scripts/webkitpy/style/checkers/png_unittest.py:
1100         (PNGCheckerTest.test_check):
1101
1102 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1103
1104         https://bugs.webkit.org/show_bug.cgi?id=87720
1105         WebProcess is often killed due to being unresponsive on the bots
1106
1107         Reviewed by Alexey Proskuryakov.
1108
1109         Blind attempt to improve flakiness on the bots by reducing the number
1110         of crashes due to an unresponsive process.  This helped on my personal machine
1111         under stress conditions.  I don't have enough cores to hit the problem
1112         under normal conditions.
1113
1114         * WebKitTestRunner/TestController.cpp:
1115         (WTR):
1116
1117 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1118
1119         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
1120         https://bugs.webkit.org/show_bug.cgi?id=87779
1121
1122         Reviewed by Eric Seidel.
1123
1124         Update output to match the names in scm.py as per
1125         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
1126
1127         * Scripts/webkitpy/tool/commands/rebaseline.py:
1128         (RebaselineTest.execute):
1129         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1130         (test_rebaseline_test_and_print_scm_changes):
1131         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1132         (GardeningServerTest.test_rebaselineall):
1133
1134 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1135
1136         https://bugs.webkit.org/show_bug.cgi?id=87711
1137
1138         Reviewed by Jessie Berlin.
1139
1140         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
1141         are better maintained.
1142
1143         * BuildSlaveSupport/build.webkit.org-config/config.json:
1144
1145 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1146
1147         webkit-patch optimize-baselines should add/delete files in batches from the vcs
1148         https://bugs.webkit.org/show_bug.cgi?id=87538
1149
1150         Reviewed by Ojan Vafai.
1151
1152         Invoking git and svn on one file at a time is kinda slow. We
1153         should batch the add and rm operations together.
1154
1155         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1156         (BaselineOptimizer._move_baselines):
1157
1158 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1159
1160         garden-o-matic should rebaseline baselines in parallel
1161         https://bugs.webkit.org/show_bug.cgi?id=87451
1162
1163         Reviewed by Ojan Vafai.
1164                                                                                
1165         This modifies garden-o-matic so that we will fetch all                  
1166         of the baselines in parallel from the bots, and then                    
1167         optimize the baselines serially (since that should be fairly            
1168         quick and we get into trouble if we optimize in parallel due            
1169         to concurrent access to the source control system).                     
1170
1171         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
1172         so that the files that need to be modified in the SCM are returned to 
1173         garden-o-matic rather than actually added or removed. This is done so that
1174         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
1175         concurrently). In order to safely return the files (as a JSON dict) I
1176         needed to shift all of the logging in rebaseline-test to use the logging
1177         module (and hence log to stderr).
1178
1179         I also had to stub out a line in chromium.py that would get confused if
1180         the skia overrides file didn't exist in a mock checkout.
1181
1182         * Scripts/webkitpy/common/system/executive.py:
1183         (Executive.popen):
1184         (Executive):
1185         (Executive.run_in_parallel):
1186         (_run_command_thunk):
1187         * Scripts/webkitpy/common/system/executive_mock.py:
1188         (MockExecutive.run_in_parallel):
1189         * Scripts/webkitpy/common/system/executive_unittest.py:
1190         (ExecutiveTest.test_run_in_parallel):
1191         * Scripts/webkitpy/layout_tests/port/chromium.py:
1192         (ChromiumPort._expectations_file_contents):
1193         * Scripts/webkitpy/tool/commands/rebaseline.py:
1194         (AbstractRebaseliningCommand.__init__):
1195         (RebaselineTest.__init__):
1196         (RebaselineTest._copy_existing_baseline):
1197         (RebaselineTest._save_baseline):
1198         (RebaselineTest):
1199         (RebaselineTest._add_to_scm):
1200         (RebaselineTest._rebaseline_test):
1201         (RebaselineTest.execute):
1202         (RebaselineExpectations._rebaseline_port):
1203         (RebaselineExpectations.execute):
1204         (Rebaseline._builder_to_pull_from):
1205         (Rebaseline.execute):
1206         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1207         (test_rebaseline_updates_expectations_file):
1208         (test_rebaseline_test):
1209         (test_rebaseline_test_and_print_scm_changes):
1210         (test_rebaseline_and_copy_test):
1211         (test_rebaseline_and_copy_test_no_existing_result):
1212         (test_rebaseline_and_copy_test_with_lion_result):
1213         (test_rebaseline_and_copy_no_overwrite_test):
1214         (test_rebaseline_expectations):
1215         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1216         (GardeningHTTPRequestHandler._rebaseline_commands):
1217         (GardeningHTTPRequestHandler):
1218         (GardeningHTTPRequestHandler._files_to_add):
1219         (GardeningHTTPRequestHandler._optimize_baselines):
1220         (GardeningHTTPRequestHandler.rebaselineall):
1221         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1222         (GardeningServerTest._post_to_path):
1223         (GardeningServerTest.test_rebaselineall):
1224         (GardeningServerTest.test_rebaselineall.run_command):
1225
1226 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
1227
1228         Fix the type of dispatch_time() offset
1229
1230         Rubber-stamped by Joseph Pecoraro.
1231
1232         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
1233
1234         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1235         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1236
1237 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1238
1239         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1240
1241         [BlackBerry] OpenGL content is not rendered on simulator
1242         https://bugs.webkit.org/show_bug.cgi?id=87721
1243
1244         Reviewed by George Staikos.
1245
1246         Fixed by enabling GLES2 support in simulator builds.
1247
1248         To experiment with building without OpenGL support, you can set the
1249         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
1250
1251         PR #150695
1252
1253         * Scripts/webkitdirs.pm:
1254         (blackberryCMakeArguments):
1255
1256 2012-05-29  David Barr  <davidbarr@chromium.org>
1257
1258         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
1259         https://bugs.webkit.org/show_bug.cgi?id=87685
1260
1261         Reviewed by Eric Seidel.
1262
1263         Add a configuration option for CSS image-resolution support, disabling it by default.
1264
1265         * Scripts/webkitperl/FeatureList.pm:
1266         * qmake/mkspecs/features/features.pri:
1267
1268 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1269
1270         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
1271
1272         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
1273             valid for C++/ObjC++ but not for C [enabled by default]"
1274
1275         Reviewed by Simon Hausmann.
1276
1277         * qmake/mkspecs/features/unix/default_post.prf:
1278
1279 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1280
1281         [Qt] Sync up favicon-implementation with WebView url changes in r118158
1282
1283         https://bugs.webkit.org/show_bug.cgi?id=87133
1284
1285         We now base64-encode the page url in the image-provider url, so that any
1286         normalization done by QUrl will not mess up the page-url. The logic of
1287         creating and parsing the provider-url has been moved into the image
1288         provider, to keep it in one place.
1289
1290         We were also releasing icons (even ones we hadn't retained), which we can't
1291         do since we don't know when the icon url is no longer in use.
1292
1293         Reviewed-by Simon Hausmann.
1294
1295         * MiniBrowser/qt/icons/favicon.png:
1296         * MiniBrowser/qt/qml/BrowserWindow.qml:
1297
1298 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1299
1300         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
1301         https://bugs.webkit.org/show_bug.cgi?id=87654
1302
1303         Reviewed by Csaba Osztrogonác.
1304
1305         Event sender provides strings for all the key events.
1306         Also KeyEventInfo constructor parameters order was changed to simplify the case when
1307         a key event has empty string.
1308
1309         * DumpRenderTree/efl/EventSender.cpp:
1310         (KeyEventInfo::KeyEventInfo):
1311         (keyPadNameFromJSValue):
1312         (keyNameFromJSValue):
1313
1314 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1315
1316         [Qt] Cancel potential url-edit when going back/forward
1317
1318         Reviewed by Kenneth Rohde Christiansen.
1319
1320         * MiniBrowser/qt/qml/BrowserWindow.qml:
1321
1322 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
1323
1324         [EFL] Compilation warning in DumpRenderTreeView.cpp
1325         https://bugs.webkit.org/show_bug.cgi?id=87636
1326
1327         Reviewed by Filip Pizlo.
1328
1329         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
1330         specifier in printf. Also fix the return type for
1331         onExceededApplicationCacheQuota callback.
1332
1333         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1334         (onExceededApplicationCacheQuota):
1335
1336 2012-05-29  Hironori Bono  <hbono@chromium.org>
1337
1338         Adding Hironori Bono to committers.py.
1339         https://bugs.webkit.org/show_bug.cgi?id=87697
1340
1341         * Scripts/webkitpy/common/config/committers.py:
1342
1343 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1344
1345         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
1346         https://bugs.webkit.org/show_bug.cgi?id=80135
1347
1348         Reviewed by Rob Buis.
1349
1350         Implemented interface function didReceiveAuthenticationChallenge in class
1351         DumpRenderTree.
1352
1353         Resubmit the patch reverted by r115104 after the digest infinite loop
1354         issue for BlackBerry porting get identified and fixed.
1355
1356         Internally reviewed by Joe Mason <jmason@rim.com>
1357
1358         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1359         (drtCredentialDescription):
1360         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
1361         (WebKit):
1362         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1363         (WebCore):
1364         (DumpRenderTree):
1365
1366 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1367
1368         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
1369         https://bugs.webkit.org/show_bug.cgi?id=42328
1370
1371         Reviewed by Eric Seidel.
1372
1373         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
1374         move to windows.internals.settings.
1375
1376         * DumpRenderTree/LayoutTestController.cpp:
1377         (LayoutTestController::staticFunctions):
1378         * DumpRenderTree/LayoutTestController.h:
1379         (LayoutTestController):
1380         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1381         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1382         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1383         (DRTDevToolsAgent):
1384         * DumpRenderTree/chromium/LayoutTestController.cpp:
1385         (LayoutTestController::LayoutTestController):
1386         * DumpRenderTree/chromium/LayoutTestController.h:
1387         (LayoutTestController):
1388         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1389         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1390         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1391         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1392         * DumpRenderTree/mac/DumpRenderTree.mm:
1393         (resetWebViewToConsistentStateBeforeTesting):
1394         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1395         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1396         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1397         (LayoutTestController):
1398         * DumpRenderTree/win/DumpRenderTree.cpp:
1399         (resetWebViewToConsistentStateBeforeTesting):
1400         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1401         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1402         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1403         (LayoutTestController):
1404
1405 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1406
1407         Move allowRoundingHacks to Internals interface
1408         https://bugs.webkit.org/show_bug.cgi?id=87328
1409
1410         Reviewed by Hajime Morita.
1411
1412         Remove allowRoundingHacks functions, because it is able to work in the
1413         cross-port way through the Internals interface.
1414
1415         * DumpRenderTree/LayoutTestController.cpp:
1416         (LayoutTestController::staticFunctions):
1417         * DumpRenderTree/LayoutTestController.h:
1418         (LayoutTestController):
1419         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1420         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1421         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1422         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1423         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1424         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1425
1426 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
1427
1428         Fix mac build with older XCode by defining NSEC_PER_MSEC.
1429         https://bugs.webkit.org/show_bug.cgi?id=87616
1430
1431         Reviewed by Hajime Morita.
1432
1433         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
1434         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
1435         Patch just adds a #ifndef / #define check.
1436
1437         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1438         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1439
1440 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1441
1442         [EFL] Enable blob support for the EFL port
1443         https://bugs.webkit.org/show_bug.cgi?id=85363
1444
1445         Reviewed by Hajime Morita.
1446
1447         Enable Blob support by default for the EFL port.
1448
1449         * Scripts/webkitperl/FeatureList.pm:
1450
1451 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
1452
1453         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
1454         https://bugs.webkit.org/show_bug.cgi?id=87582
1455
1456         Reviewed by Darin Adler.
1457
1458         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
1459         possible to test pages in a similar way as they are loaded in Browsers.
1460
1461         * DumpRenderTree/LayoutTestController.cpp:
1462         (LayoutTestController::LayoutTestController):
1463         (setUseDeferredFrameLoadingCallback):
1464         (LayoutTestController::staticFunctions):
1465         * DumpRenderTree/LayoutTestController.h:
1466         (LayoutTestController::useDeferredFrameLoading):
1467         (LayoutTestController::setUseDeferredFrameLoading):
1468         (LayoutTestController):
1469         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1470         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1471
1472 2012-05-27  David Barton  <dbarton@mathscribe.com>
1473
1474         [watchlist] Improve MathML rule
1475         https://bugs.webkit.org/show_bug.cgi?id=87592
1476
1477         Reviewed by Adam Barth.
1478
1479         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
1480         but if this changed the rule would be slow. We protect against this, clarify the rule,
1481         and make it more similar to existing rules.
1482
1483         * Scripts/webkitpy/common/config/watchlist:
1484
1485 2012-05-27  David Barton  <dbarton@mathscribe.com>
1486
1487         [watchlist] Add myself & a rule for MathML
1488         https://bugs.webkit.org/show_bug.cgi?id=87586
1489
1490         Reviewed by Adam Barth.
1491
1492         * Scripts/webkitpy/common/config/watchlist:
1493
1494 2012-05-26  David Kilzer  <ddkilzer@apple.com>
1495
1496         Use xcrun to find path to nm for Mac port
1497         <http://webkit.org/b/87588>
1498
1499         Reviewed by Dan Bernstein.
1500
1501         * Scripts/webkitpy/layout_tests/port/mac.py:
1502         (MacPort.nm_command): Add. Tries to find a path for the nm
1503         command using xcrun.  Falls back to returning 'nm'.
1504         * Scripts/webkitpy/layout_tests/port/webkit.py:
1505         (WebKitPort.nm_command): Add. Returns 'nm'.
1506         (WebKitPort._webcore_symbols_string): Call self.nm_command().
1507
1508 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
1509
1510         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
1511
1512         Reviewed by Eric Seidel.
1513
1514         * DumpRenderTree/win/DumpRenderTree.vcproj:
1515         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1516         (FrameLoadDelegate::FrameLoadDelegate):
1517         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1518         * DumpRenderTree/win/FrameLoadDelegate.h:
1519         (FrameLoadDelegate):
1520         * DumpRenderTree/win/TextInputController.cpp: Added.
1521         (setMarkedTextCallback):
1522         (hasMarkedTextCallback):
1523         (unmarkTextCallback):
1524         (markedRangeCallback):
1525         (insertTextCallback):
1526         (firstRectForCharacterRangeCallback):
1527         (selectedRangeCallback):
1528         (TextInputController::makeWindowObject):
1529         (TextInputController::getJSClass):
1530         (TextInputController::staticValues):
1531         (TextInputController::staticFunctions):
1532         * DumpRenderTree/win/TextInputController.h: Added.
1533         (TextInputController):
1534         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
1535         (TextInputController::setMarkedText):
1536         (TextInputController::hasMarkedText):
1537         (TextInputController::unmarkText):
1538         (TextInputController::markedRange):
1539         (TextInputController::insertText):
1540         (TextInputController::firstRectForCharacterRange):
1541         (TextInputController::selectedRange):
1542
1543 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
1544
1545         webkitpy: change scm.add(), scm.delete() to accept multiple paths
1546         https://bugs.webkit.org/show_bug.cgi?id=87528
1547
1548         Reviewed by Ojan Vafai.
1549
1550         launching git or svn for individual files can be slow; this
1551         change will hand multiple paths at once to git and svn so they
1552         can be added in a batch.
1553
1554         * Scripts/webkitpy/common/checkout/scm/git.py:
1555         (Git.add_list):
1556         (Git.delete_list):
1557         * Scripts/webkitpy/common/checkout/scm/scm.py:
1558         (SCM.add):
1559         (SCM):
1560         (SCM.add_list):
1561         (SCM.delete):
1562         (SCM.delete_list):
1563         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1564         (MockSCM.add):
1565         (MockSCM):
1566         (MockSCM.add_list):
1567         (MockSCM.delete):
1568         (MockSCM.delete_list):
1569         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1570         (_shared_test_exists):
1571         (_shared_test_added_files):
1572         (_test_delete_list):
1573         * Scripts/webkitpy/common/checkout/scm/svn.py:
1574         (SVN.add_list):
1575         (SVN.delete_list):
1576
1577 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1578
1579         [NRWT] Add unit testing for perf tests on locked shards
1580         https://bugs.webkit.org/show_bug.cgi?id=87489
1581
1582         Reviewed by Dirk Pranke.
1583
1584         Adding utests that makes sure that perf tests are running in locked
1585         shards and by passing --no-http won't break NRWT (r118421).
1586
1587         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1588         (ShardingTests):
1589         (ShardingTests.test_shard_by_dir):
1590         (ShardingTests.test_shard_every_file):
1591         (ShardingTests.test_shard_in_two):
1592         (ShardingTests.test_multiple_locked_shards):
1593         (LockCheckingManager):
1594         (LockCheckingManager.__init__):
1595         (LockCheckingManager.handle_finished_list):
1596         (ManagerTest.test_http_locking):
1597         (ManagerTest):
1598         (ManagerTest.test_perf_locking):
1599         * Scripts/webkitpy/layout_tests/port/test.py:
1600
1601 2012-05-25  Jessie Berlin  <jberlin@apple.com>
1602
1603         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
1604         https://bugs.webkit.org/show_bug.cgi?id=87511
1605
1606         Reviewed by Alexey Proskuryakov.
1607
1608         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
1609
1610         * DumpRenderTree/win/EventSender.cpp:
1611         (keyDownCallback):
1612
1613 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
1614
1615         Adding Ken Buchanan to committers.py
1616         https://bugs.webkit.org/show_bug.cgi?id=87443
1617
1618         Unreviewed.
1619
1620         Adding self to committers.py as a Committer.
1621
1622         * Scripts/webkitpy/common/config/committers.py:
1623
1624 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
1625
1626         [Qt] Buildfix for newer Qt5
1627         https://bugs.webkit.org/show_bug.cgi?id=87257
1628
1629         Reviewed by Simon Hausmann.
1630
1631         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
1632
1633 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
1634
1635         [Qt] Unreviewed fix after r118484.
1636
1637         Enable CSS_EXCLUSIONS and CSS_REGIONS.
1638         They were enabled uncoditinally before r118484.
1639
1640         * qmake/mkspecs/features/features.pri:
1641
1642 2012-05-24  Tim Horton  <timothy_horton@apple.com>
1643
1644         Add feature defines for web-facing parts of CSS Regions and Exclusions
1645         https://bugs.webkit.org/show_bug.cgi?id=87442
1646         <rdar://problem/10887709>
1647
1648         Reviewed by Dan Bernstein.
1649
1650         * Scripts/webkitperl/FeatureList.pm:
1651
1652 2012-05-24  Hironori Bono  <hbono@chromium.org>
1653
1654         Enable grammar checking on Chromium when we paste text (Take 2)
1655         https://bugs.webkit.org/show_bug.cgi?id=74393
1656
1657         Reviewed by Ryosuke Niwa.
1658
1659         This change enables grammar checking on Chromium and implements a mock grammar
1660         checker to fix a failing test.
1661
1662         * DumpRenderTree/DumpRenderTree.gypi:
1663         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
1664         (MockGrammarCheck::checkGrammarOfString):
1665         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
1666         (WebKit):
1667         (MockGrammarCheck):
1668         * DumpRenderTree/chromium/WebViewHost.cpp:
1669         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
1670
1671 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1672
1673         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
1674         https://bugs.webkit.org/show_bug.cgi?id=86842
1675
1676         Reviewed by Antonio Gomes.
1677
1678         Add support for overriding the application cache support preference
1679         through EFL's LayoutTestController.
1680
1681         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1682         (LayoutTestController::overridePreference):
1683
1684 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1685
1686         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
1687         https://bugs.webkit.org/show_bug.cgi?id=85209
1688
1689         Reviewed by Antonio Gomes.
1690
1691         Set developer extras setting called twice on the test startup. Hence, removing
1692         an unnecessary extra call which set wrong value. 
1693
1694         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1695         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1696
1697 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
1698
1699         garden-o-matic should not fetch from debug bots if it also knows about the release bots
1700         https://bugs.webkit.org/show_bug.cgi?id=86916
1701
1702         Reviewed by Adam Barth.
1703
1704         Note that if release and debug are failing differently, debug
1705         will be ignored ...
1706
1707         Note: also change the use of a fake port name from
1708         "mock-port-name" to "test-mac-leopard" to make it more friendly
1709         to the port factory ("mock" actually is a real port).
1710
1711         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1712         (GardeningHTTPRequestHandler._builders_to_fetch_from):
1713         (GardeningHTTPRequestHandler.rebaselineall):
1714         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1715         (GardeningServerTest.test_rebaselineall):
1716         (GardeningServerTest.test_rebaseline_new_port):
1717
1718 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
1719
1720         nrwt: fix baseline search path for official chrome builders
1721         https://bugs.webkit.org/show_bug.cgi?id=87432
1722
1723         Reviewed by Tony Chang.
1724
1725         The official chrome builders need to use the win7 and SL
1726         baseline paths, not the XP and Leopard paths. Linux is correct.
1727
1728         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1729         (GoogleChromeMacPort.determine_full_port_name):
1730         (GoogleChromeWinPort.determine_full_port_name):
1731         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1732         (TestGoogleChromePort._verify_baseline_search_path_startswith):
1733         (TestGoogleChromePort.test_get_google_chrome_port):
1734
1735 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1736
1737         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
1738         https://bugs.webkit.org/show_bug.cgi?id=86800
1739
1740         Reviewed by Dirk Pranke.
1741
1742         Don't launch a HTTP server with lock based only on the existence of
1743         locked shards since we now run perf on locked shards too.
1744
1745         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1746         (Manager._run_tests):
1747
1748 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
1749
1750         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
1751         https://bugs.webkit.org/show_bug.cgi?id=87128
1752
1753         Reviewed by Dirk Pranke.
1754
1755         * Scripts/webkitpy/layout_tests/port/base.py:
1756         (Port.driver_name):
1757         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1758         (ChromiumLinuxPort._path_to_driver):
1759         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1760         (ChromiumPortTest.test_driver_name_option):
1761         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1762         (ChromiumWinPort._path_to_driver):
1763         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1764         (parse_args):
1765
1766 2012-05-24  John Mellor  <johnme@chromium.org>
1767
1768         Font Boosting: Add compile flag and runtime setting
1769         https://bugs.webkit.org/show_bug.cgi?id=87394
1770
1771         Reviewed by Adam Barth.
1772
1773         Add ENABLE_FONT_BOOSTING.
1774
1775         * Scripts/webkitperl/FeatureList.pm:
1776         * qmake/mkspecs/features/features.pri:
1777
1778 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1779
1780         [EFL] [DRT] keyboard-related tests do not pass
1781         https://bugs.webkit.org/show_bug.cgi?id=85369
1782
1783         Reviewed by Gustavo Noronha Silva.
1784
1785         Add SHIFT modifier for capital letters as VK_ 
1786         codes do not distinguish between lows and caps and also to be consistent
1787         with other ports which send caps as lowercase letters with the shift key down.
1788
1789         * DumpRenderTree/efl/EventSender.cpp:
1790         (keyNameFromJSValue): 
1791
1792 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
1793
1794         [WK2] Let the client give local files universal access on a case by case basis
1795         https://bugs.webkit.org/show_bug.cgi?id=87174
1796         <rdar://problem/11024330>
1797
1798         Reviewed by Maciej Stachowiak.
1799
1800         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
1801         Added initialization of a new structure member to prevent build failure.
1802
1803 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
1804
1805         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
1806         https://bugs.webkit.org/show_bug.cgi?id=87203
1807
1808         Reviewed by Andreas Kling.
1809
1810         Add the required changes to make
1811         fast/events/keydown-leftright-keys.html pass after r118001.
1812
1813         * DumpRenderTree/efl/EventSender.cpp:
1814         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
1815         into the proper X11 keysym definitions.
1816
1817 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1818
1819         Unreviewed, rolling out r118352.
1820         http://trac.webkit.org/changeset/118352
1821         https://bugs.webkit.org/show_bug.cgi?id=87390
1822
1823         Caused 6 editing/spelling tests crash/fail on chromium in
1824         debug. (Requested by vsevik on #webkit).
1825
1826         * DumpRenderTree/DumpRenderTree.gypi:
1827         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
1828         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
1829         * DumpRenderTree/chromium/WebViewHost.cpp:
1830         (WebViewHost::finishLastTextCheck):
1831
1832 2012-05-24  Peter Beverloo  <peter@chromium.org>
1833
1834         Add John Mellor as a contributor
1835         https://bugs.webkit.org/show_bug.cgi?id=87389
1836
1837         Reviewed by Kenneth Rohde Christiansen.
1838
1839         John will be working on Font Boosting and is very involved with various
1840         web-facing subjects of Chrome for Android, such as viewport.
1841
1842         * Scripts/webkitpy/common/config/committers.py:
1843
1844 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1845
1846         [EFL][DRT] LayoutTestController's setCacheModel() implementation
1847         https://bugs.webkit.org/show_bug.cgi?id=86840
1848
1849         Reviewed by Csaba Osztrogonác.
1850
1851         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1852         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
1853         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1854         (LayoutTestController::setCacheModel): Implementation added.
1855
1856 2012-05-24  Hironori Bono  <hbono@chromium.org>
1857
1858         Enable grammar checking on Chromium when we paste text.
1859         https://bugs.webkit.org/show_bug.cgi?id=74393
1860
1861         Reviewed by Hajime Morita.
1862
1863         This change enables grammar checking on Chromium and implements a mock grammar
1864         checker to fix a failing test.
1865
1866         * DumpRenderTree/DumpRenderTree.gypi:
1867         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
1868         (MockGrammarCheck::checkGrammarOfString):
1869         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
1870         (WebKit):
1871         (MockGrammarCheck):
1872         * DumpRenderTree/chromium/WebViewHost.cpp:
1873         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
1874
1875 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
1876
1877         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
1878
1879         * qmake/mkspecs/features/features.pri:
1880
1881 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
1882
1883         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
1884         https://bugs.webkit.org/show_bug.cgi?id=86867
1885
1886         Reviewed by Adam Barth.
1887
1888         Add implementation for sendWebIntentResponse() in EFL's
1889         LayoutTestController and add empty implementation for other ports.
1890
1891         * DumpRenderTree/LayoutTestController.cpp:
1892         (sendWebIntentResponseCallback):
1893         (LayoutTestController::staticFunctions):
1894         * DumpRenderTree/LayoutTestController.h:
1895         (LayoutTestController):
1896         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1897         (LayoutTestController::sendWebIntentResponse):
1898         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1899         (DumpRenderTreeChrome::currentIntentRequest):
1900         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1901         (DumpRenderTreeChrome::onFrameIntentNew):
1902         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1903         (DumpRenderTreeChrome):
1904         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1905         (LayoutTestController::sendWebIntentResponse):
1906         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1907         (LayoutTestController::sendWebIntentResponse):
1908         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1909         (LayoutTestController::sendWebIntentResponse):
1910         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1911         (LayoutTestController::sendWebIntentResponse):
1912         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1913         (LayoutTestController::sendWebIntentResponse):
1914
1915 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
1916
1917         [EFL] The EFL port has no support for title directionality
1918         https://bugs.webkit.org/show_bug.cgi?id=86462
1919
1920         Reviewed by Gustavo Noronha Silva.
1921
1922         Update "title,changed" signal handlers in DRT and EWebLauncher to
1923         reflect the change from const char* to Ewk_Text_With_Direction* type
1924         for the title.
1925
1926         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1927         (DumpRenderTreeChrome::onTitleChanged):
1928         * EWebLauncher/main.c:
1929         (title_set):
1930         (on_title_changed):
1931         (on_key_down):
1932
1933 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1934
1935         Change EFL debug build name with more detail one
1936         https://bugs.webkit.org/show_bug.cgi?id=87254
1937
1938         Reviewed by Ryosuke Niwa.
1939
1940         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
1941         In addition, remove efl-linux-debug triggerable since nobody uses it.
1942
1943         * BuildSlaveSupport/build.webkit.org-config/config.json:
1944
1945 2012-05-23  Kangil Han  <kangil.han@samsung.com>
1946
1947         [EFL][DRT] Fix WebCore library path and rebaseline result
1948         https://bugs.webkit.org/show_bug.cgi?id=86355
1949
1950         Reviewed by Dirk Pranke.
1951
1952         Currently EFL DRT uses wrong WebCore library path when running DRT.
1953         Therefore, this patch adjusted the path correctly.
1954
1955         * Scripts/webkitpy/layout_tests/port/efl.py:
1956         (EflPort._path_to_webcore_library):
1957
1958 2012-05-23  Ojan Vafai  <ojan@chromium.org>
1959
1960         add back the ability to disable flexbox
1961         https://bugs.webkit.org/show_bug.cgi?id=87147
1962
1963         Reviewed by Tony Chang.
1964
1965         * Scripts/webkitperl/FeatureList.pm:
1966
1967 2012-05-23  Tony Chang  <tony@chromium.org>
1968
1969         Remove the Chromium Grid Layout bot from the waterfall
1970         https://bugs.webkit.org/show_bug.cgi?id=87311
1971
1972         Reviewed by Ryosuke Niwa.
1973
1974         I removed the compiler define in r117613, so we don't need a separate
1975         bot to compile/test this code.
1976
1977         * BuildSlaveSupport/build.webkit.org-config/config.json:
1978
1979 2012-05-23  Ian Vollick  <vollick@chromium.org>
1980
1981         Add vollick to list of contributors.
1982         https://bugs.webkit.org/show_bug.cgi?id=87305
1983
1984         Reviewed by Adam Barth.
1985
1986         * Scripts/webkitpy/common/config/committers.py:
1987
1988 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
1989
1990         [Chromium-Android] Fix chromium_android_unittest
1991         https://bugs.webkit.org/show_bug.cgi?id=87196
1992
1993         Reviewed by Tony Chang.
1994
1995         Update unit tests after ChromiumAndroidPort supported apk based
1996         DumpRenderTree.
1997
1998         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1999         (ChromiumAndroidPortTest):
2000         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
2001         (ChromiumAndroidPortTest.test_get_last_stacktrace):
2002         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
2003         (ChromiumAndroidDriverTest):
2004         (ChromiumAndroidDriverTest.setUp):
2005         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
2006         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
2007
2008 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2009
2010         [watchlist] Add myself and create a watch rule to catch Attribute related patches
2011         https://bugs.webkit.org/show_bug.cgi?id=87303
2012
2013         Reviewed by Alexis Menard.
2014
2015         * Scripts/webkitpy/common/config/watchlist:
2016
2017 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
2018
2019         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2020         https://bugs.webkit.org/show_bug.cgi?id=86916
2021
2022         Reviewed by Adam Barth.
2023
2024         This change pushes all of the logic for rebaselining a cluster
2025         of failures (a list of tests failing a list of suffixes on a
2026         list of bots) onto the server, so there is a single call from
2027         the web page; we will then be able to optimize the performance
2028         of the rebaselining better.
2029
2030         Also remove the 'optimizebaseline' entry point on garden-o-matic
2031         (and the client-side call) since we don't need it any more.
2032
2033         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2034         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2035         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2036         (GardeningHTTPRequestHandler.rebaselineall):
2037         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2038
2039 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
2040
2041         Mac DRT should be able to load external URLs for replay performance tests
2042         https://bugs.webkit.org/show_bug.cgi?id=86191
2043
2044         Reviewed by Alexey Proskuryakov.
2045
2046         Let external URL requests go through if the test file is not a local file or hosted at localhost.
2047         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
2048         "DumpRenderTree http://localhost:8000/".
2049
2050         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2051         (isLocalhost):
2052         (hostIsUsedBySomeTestsToGenerateError):
2053         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2054
2055 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
2056
2057         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
2058         debug symbols for easier debugging.
2059         https://bugs.webkit.org/show_bug.cgi?id=87151
2060
2061         Reviewed by Kevin Ollivier.
2062
2063         * waf/build/settings.py:
2064         (common_configure):
2065
2066 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2067
2068         Unreviewed. Move myself to reviewers.
2069
2070         * Scripts/webkitpy/common/config/committers.py:
2071
2072 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
2073
2074         [EFL] Implements the registerProtocolHandler method and option.
2075         https://bugs.webkit.org/show_bug.cgi?id=73638
2076
2077         Reviewed by Andreas Kling.
2078
2079         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
2080
2081 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
2082
2083         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
2084         https://bugs.webkit.org/show_bug.cgi?id=87221
2085
2086         Reviewed by Martin Robinson.
2087
2088         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
2089         rightShift key names into proper GDK key symbols.
2090
2091         * DumpRenderTree/gtk/EventSender.cpp:
2092         (createKeyPressEvent):
2093
2094 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2095
2096         [Qt] Make the web view's url property follow the active url
2097
2098         https://bugs.webkit.org/show_bug.cgi?id=77554
2099
2100         Update  the location bar in the minibrowser to behave
2101         a bit more like normal browsers in terms of when the url will change
2102         and how active focus is handled.
2103
2104         Reviewed by Simon Hausmann.
2105
2106         * MiniBrowser/qt/qml/BrowserWindow.qml:
2107
2108 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2109
2110         [Qt] Remove references to $$QT_SOURCE_TREE
2111
2112         With a modularized Qt, it's ambigious. What we really want is qtbase,
2113         which qtcore is a proxy for (we assume it will always live in qtbase).
2114
2115         Reviewed by Tor Arne Vestbø.
2116
2117         * DumpRenderTree/qt/DumpRenderTree.pro:
2118
2119 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2120
2121         [Qt] Fix qmake conditional for c++-11 compat warnings
2122
2123         Reviewed by Tor Arne Vestbø.
2124
2125         * qmake/mkspecs/features/unix/default_post.prf:
2126
2127 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2128
2129         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
2130         https://bugs.webkit.org/show_bug.cgi?id=85956
2131
2132         Reviewed by Gustavo Noronha Silva.
2133
2134         Catch new "load,provisional,failed" signal and print
2135         didFailProvisionalLoadWithError messages when LayoutTestController's
2136         dumpFrameLoadCallbacks() returns true. Also make sure the
2137         didFailLoadWithError message is not printed in case of provisional
2138         load failure.
2139
2140         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2141         (DumpRenderTreeChrome::createView):
2142         (DumpRenderTreeChrome::onFrameCreated):
2143         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
2144         (DumpRenderTreeChrome::onFrameLoadError):
2145         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2146         (DumpRenderTreeChrome):
2147
2148 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2149
2150         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
2151         https://bugs.webkit.org/show_bug.cgi?id=86366
2152
2153         Reviewed by Antonio Gomes.
2154
2155         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
2156
2157         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2158         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2159
2160 2012-05-22  Darin Adler  <darin@apple.com>
2161
2162         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
2163         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
2164
2165 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2166
2167         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
2168         https://bugs.webkit.org/show_bug.cgi?id=86922
2169
2170         Because we have new platformInit() in TestShellAndroid.cpp, and
2171         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
2172         is split into TestShellPosix.cpp and TestShellX11.cpp.
2173
2174         Reviewed by Kent Tamura.
2175
2176         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2177         * DumpRenderTree/DumpRenderTree.gypi:
2178         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
2179         (platformInit):
2180         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
2181         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
2182         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
2183         (AlarmHandler):
2184         (TestShell::waitTestFinished):
2185         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
2186         (openStartupDialog): from TestShellGtk.cpp
2187         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
2188         (setupFontconfig):
2189         (platformInit):
2190
2191 2012-05-22  Kangil Han  <kangil.han@samsung.com>
2192
2193         [EFL][DRT] Implement touch event
2194         https://bugs.webkit.org/show_bug.cgi?id=86720
2195
2196         Reviewed by Hajime Morita.
2197
2198         Currently EFL DRT doesn't support touch event.
2199         Therefore, this patch enabled it and implemented some eventSender function callbacks.
2200
2201         * DumpRenderTree/efl/EventSender.cpp:
2202         (TouchEventInfo::TouchEventInfo):
2203         (TouchEventInfo):
2204         (touchPointList):
2205         (sendTouchEvent):
2206         (addTouchPointCallback):
2207         (touchStartCallback):
2208         (updateTouchPointCallback):
2209         (touchMoveCallback):
2210         (cancelTouchPointCallback):
2211         (touchCancelCallback):
2212         (releaseTouchPointCallback):
2213         (touchEndCallback):
2214         (clearTouchPointsCallback):
2215         (setTouchModifierCallback):
2216         * Scripts/webkitperl/FeatureList.pm:
2217
2218 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2219
2220         [Chromium-Android] Fix chromium_android_unittest
2221         https://bugs.webkit.org/show_bug.cgi?id=87196
2222
2223         Not reviewed.
2224         Temporarily disable chromium_android_unittest.
2225
2226         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2227         (ChromiumAndroidPortTest):
2228         (ChromiumAndroidDriverTest):
2229
2230 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2231
2232         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
2233         https://bugs.webkit.org/show_bug.cgi?id=64313
2234
2235         Reviewed by Jon Honeycutt.
2236
2237         Add it.
2238
2239         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2240         Make sure to generate the binding.
2241
2242         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2243         (WTR::LayoutTestController::setDefersLoading):
2244         Call WKBundlePageSetDefersLoading.
2245         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2246
2247 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2248
2249         [Chromium-Android] Run DumpRenderTree as an apk (python part)
2250         https://bugs.webkit.org/show_bug.cgi?id=86923
2251
2252         chromium_android.py is modified to support running DumpRenderTree as
2253         an apk, so that we can run the tests (e.g. video) requiring features
2254         implemented in Java on Android.
2255
2256         Reviewed by Adam Barth.
2257
2258         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2259         (ChromiumAndroidPort.__init__):
2260         (ChromiumAndroidPort.default_child_processes):
2261         (ChromiumAndroidPort.check_wdiff):
2262         (ChromiumAndroidPort.check_build):
2263         (ChromiumAndroidPort.start_helper):
2264         (ChromiumAndroidPort.skipped_layout_tests):
2265         (ChromiumAndroidPort):
2266         (ChromiumAndroidPort._path_to_driver):
2267         (ChromiumAndroidPort._get_crash_log):
2268         (ChromiumAndroidPort._push_executable):
2269         (ChromiumAndroidPort._run_adb_command):
2270         (ChromiumAndroidPort._get_last_stacktrace):
2271         (ChromiumAndroidPort._get_logcat):
2272         (ChromiumAndroidPort._setup_performance):
2273         (ChromiumAndroidDriver):
2274         (ChromiumAndroidDriver.__init__):
2275         (ChromiumAndroidDriver._command_wrapper):
2276         (ChromiumAndroidDriver.cmd_line):
2277         (ChromiumAndroidDriver._file_exists_on_device):
2278         (ChromiumAndroidDriver._deadlock_detector):
2279         (ChromiumAndroidDriver._start):
2280         (ChromiumAndroidDriver.run_test):
2281         (ChromiumAndroidDriver.stop):
2282         (ChromiumAndroidDriver._write_command_and_read_line):
2283         (ChromiumAndroidDriver._output_image):
2284         (ChromiumAndroidDriver._get_stderr):
2285
2286 2012-05-22  Joshua Bell  <jsbell@chromium.org>
2287
2288         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
2289
2290         Unreviewed gardening.
2291
2292         * Scripts/webkitpy/layout_tests/port/base.py:
2293         (Port.driver_name):
2294         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2295         (ChromiumLinuxPort._path_to_driver):
2296         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2297         (ChromiumPortTest.test_overrides_and_builder_names):
2298         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2299         (ChromiumWinPort._path_to_driver):
2300         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2301         (parse_args):
2302
2303 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2304
2305         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
2306         https://bugs.webkit.org/show_bug.cgi?id=87176
2307
2308         Reviewed by Tony Chang.
2309
2310         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2311         * DumpRenderTree/DumpRenderTree.gypi:
2312
2313 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
2314
2315         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2316         https://bugs.webkit.org/show_bug.cgi?id=87128
2317
2318         Reviewed by Dirk Pranke.
2319
2320         * Scripts/webkitpy/layout_tests/port/base.py:
2321         (Port.driver_name):
2322         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2323         (ChromiumLinuxPort._path_to_driver):
2324         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2325         (ChromiumPortTest.test_driver_name_option):
2326         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2327         (ChromiumWinPort._path_to_driver):
2328         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2329         (parse_args):
2330
2331 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2332
2333         WTR fix after r118001.
2334
2335         Rubber-stamped by Alexey Proskuryakov.
2336
2337         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
2338
2339         * WebKitTestRunner/mac/EventSenderProxy.mm:
2340         (WTR::EventSenderProxy::keyDown):
2341
2342 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
2343
2344         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
2345         https://bugs.webkit.org/show_bug.cgi?id=86684
2346
2347         Reviewed by Darin Fisher.
2348
2349         * DumpRenderTree/chromium/LayoutTestController.cpp:
2350         (LayoutTestController::numberOfPages):
2351         * DumpRenderTree/chromium/WebViewHost.cpp:
2352         (WebViewHost::printPage):
2353
2354 == Rolled over to ChangeLog-2012-05-22 ==