[ews-build] Scripts using Buildbot API have CORS error
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Scripts using Buildbot API have CORS error
4         https://bugs.webkit.org/show_bug.cgi?id=196709
5
6         Reviewed by Alexey Proskuryakov.
7
8         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
9
10 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
11
12         AX: Support API: accessibilityReplaceRange:withText
13         https://bugs.webkit.org/show_bug.cgi?id=196636
14
15         Reviewed by Daniel Bates.
16
17         * DumpRenderTree/AccessibilityUIElement.cpp:
18         (replaceTextInRangeCallback):
19         (AccessibilityUIElement::replaceTextInRange):
20         (AccessibilityUIElement::getJSClass):
21         * DumpRenderTree/AccessibilityUIElement.h:
22         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
23         (AccessibilityUIElement::replaceTextInRange):
24         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
25         (AccessibilityUIElement::replaceTextInRange):
26         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
27         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
28         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
29         (WTR::AccessibilityUIElement::replaceTextInRange):
30         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
31         (WTR::AccessibilityUIElement::replaceTextInRange):
32
33 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
34
35         [iOS] Do not allow starting selection drags when selection views are not visible
36         https://bugs.webkit.org/show_bug.cgi?id=196686
37         <rdar://problem/49399192>
38
39         Reviewed by Tim Horton.
40
41         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
42         also add some new API tests to cover scenarios where the web view is not first responder.
43
44         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
45         (TestWebKitAPI::TEST):
46         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
47
48         Add a switch to optionally make the web view first responder when starting the simulated drag.
49
50         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
51         (-[DragAndDropSimulator initWithWebView:]):
52         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
53
54 2019-04-08  Justin Fan  <justin_fan@apple.com>
55
56         [Web GPU] Fix Web GPU experimental feature on iOS
57         https://bugs.webkit.org/show_bug.cgi?id=196632
58
59         Reviewed by Myles C. Maxfield.
60
61         Properly make Web GPU available on iOS 11+.
62
63         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
64
65 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
66
67         [ews-build] Do not upload archive when Compile Fails
68         https://bugs.webkit.org/show_bug.cgi?id=196674
69
70         Reviewed by Alexey Proskuryakov.
71
72         * BuildSlaveSupport/ews-build/factories.py:
73         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
74         * BuildSlaveSupport/ews-build/steps.py:
75         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
76         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
77         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
78
79 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
80
81         Enable DFG on MIPS
82         https://bugs.webkit.org/show_bug.cgi?id=196689
83
84         Reviewed by Žan Doberšek.
85
86         Since the bytecode change, we enabled the baseline JIT on mips in
87         r240432, but DFG is still missing. With this change, all tests are
88         passing on a ci20 board.
89
90         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
91
92 2019-04-08  Philippe Normand  <pnormand@igalia.com>
93
94         [Flatpak] Second run update-webkitwpe-flatpak fails
95         https://bugs.webkit.org/show_bug.cgi?id=192702
96
97         Reviewed by Carlos Garcia Campos.
98
99         * flatpak/flatpakutils.py:
100         (FlatpakObject.flatpak): Fix typo.
101         (FlatpakPackage.install): When installing, also update to the configured remote commit.
102         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
103
104 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
105
106         [GTK][WPE] outlook.live.com displays old-fashioned UI
107         https://bugs.webkit.org/show_bug.cgi?id=196642
108
109         Reviewed by Carlos Garcia Campos.
110
111         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
112         (TestWebKitAPI::TEST): New Mac platform quirk test.
113
114 2019-04-07  Commit Queue  <commit-queue@webkit.org>
115
116         Unreviewed, rolling out r243956.
117         https://bugs.webkit.org/show_bug.cgi?id=196688
118
119         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
120         by aakashjain on #webkit).
121
122         Reverted changeset:
123
124         "Clicking "Go Back" from a safe browsing warning from an
125         iframe should navigate the WKWebView back to the previous
126         page"
127         https://bugs.webkit.org/show_bug.cgi?id=196665
128         https://trac.webkit.org/changeset/243956
129
130 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
131
132         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
133         https://bugs.webkit.org/show_bug.cgi?id=196669
134
135         Reviewed by Geoffrey Garen.
136
137         Added three new unit tests for WeakHashSet.
138
139         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
140         (WTF_WeakPtr.WeakHashSetConstObjects):
141         (WTF_WeakPtr.WeakHashSetComputesEmpty):
142         (WTF_WeakPtr.WeakHashSetComputeSize):
143
144 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
145
146         Hide next and previous form control buttons when WKWebView is editable
147         https://bugs.webkit.org/show_bug.cgi?id=196672
148         <rdar://problem/35625321>
149
150         Reviewed by Tim Horton.
151
152         Add a new API test.
153
154         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
155         (-[TestWKWebView lastTrailingBarButtonGroup]):
156         (TestWebKitAPI::TEST):
157         * TestWebKitAPI/ios/UIKitSPI.h:
158
159 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
160
161         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
162         https://bugs.webkit.org/show_bug.cgi?id=196077
163         <rdar://problem/49108202>
164
165         Reviewed by Chris Dumez.
166
167         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
168         on new web view.
169
170         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
171
172 2019-04-05  Saam Barati  <sbarati@apple.com>
173
174         Make compare-results understand MotionMark
175         https://bugs.webkit.org/show_bug.cgi?id=196666
176
177         Reviewed by Yusuke Suzuki.
178
179         * Scripts/compare-results:
180         (PLT5Results):
181         (detectMotionMark):
182         (detectMotionMark1_1):
183         (motionMarkResults):
184         (motionMark1_1Results):
185         (detectBenchmark):
186         (biggerIsBetter):
187         (main):
188
189 2019-04-05  Alex Christensen  <achristensen@webkit.org>
190
191         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
192         https://bugs.webkit.org/show_bug.cgi?id=196665
193         <rdar://45115669>
194
195         Reviewed by Geoff Garen.
196
197         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
198         (goBack):
199         (+[SimpleLookupContext sharedLookupContext]):
200         (-[SimpleLookupContext lookUpURL:completionHandler:]):
201         (TEST):
202         (+[Simple3LookupContext sharedLookupContext]): Deleted.
203         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
204
205 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
206
207         [ews-build] Add configuration and architecture for windows builders
208         https://bugs.webkit.org/show_bug.cgi?id=196660
209
210         Reviewed by Lucas Forschler.
211
212         * BuildSlaveSupport/ews-build/config.json:
213
214 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
215
216         webkitpy: Don't run subsequent rounds if interrupted
217         https://bugs.webkit.org/show_bug.cgi?id=196646
218
219         Reviewed by Aakash Jain.
220
221         * Scripts/webkitpy/layout_tests/controllers/manager.py:
222         (Manager.run): Bail out if interrupted.
223
224 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
225
226         Test sessionStorage in PSON private browsing mode
227         https://bugs.webkit.org/show_bug.cgi?id=196561
228
229         Reviewed by Alex Christensen.
230
231         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
232
233 2019-04-05  Commit Queue  <commit-queue@webkit.org>
234
235         Unreviewed, rolling out r243833.
236         https://bugs.webkit.org/show_bug.cgi?id=196645
237
238         This change breaks build of WPE and GTK ports (Requested by
239         annulen on #webkit).
240
241         Reverted changeset:
242
243         "[CMake][WTF] Mirror XCode header directories"
244         https://bugs.webkit.org/show_bug.cgi?id=191662
245         https://trac.webkit.org/changeset/243833
246
247 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
248
249         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
250         https://bugs.webkit.org/show_bug.cgi?id=196635
251
252         Reviewed by Antti Koivisto.
253         
254         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
255         for a test to enable async frame scrolling via:
256             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
257         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
258         
259         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
260
261         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
262         (WTR::InjectedBundle::beginTesting):
263         * WebKitTestRunner/TestController.cpp:
264         (WTR::TestController::resetPreferencesToConsistentValues):
265
266 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
267
268         Use a correct LC_RPATH when building with ASan
269         https://bugs.webkit.org/show_bug.cgi?id=196576
270
271         Reviewed by David Kilzer.
272
273         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
274         so that ../Frameworks is checked. This is simpler and more reliable than updating
275         each SPC service xcconfig.
276
277 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
278
279         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
280         https://bugs.webkit.org/show_bug.cgi?id=196629
281
282         Reviewed by Lucas Forschler.
283
284         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
285
286 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
287
288         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
289         https://bugs.webkit.org/show_bug.cgi?id=196618
290
291         Reviewed by Lucas Forschler.
292
293         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
294         (StatusBubble): Added QUEUE_TRIGGERS.
295         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
296         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
297         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
298         its parent(builder).
299
300 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
301
302         [ews-app] Status-bubble steps are sometimes displayed in reverse order
303         https://bugs.webkit.org/show_bug.cgi?id=196625
304
305         Reviewed by Lucas Forschler.
306
307         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
308         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
309
310 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
311
312         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
313         https://bugs.webkit.org/show_bug.cgi?id=196630
314
315         Reviewed by Wenson Hsieh.
316
317         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
318
319 2019-04-04  Youenn Fablet  <youenn@apple.com>
320
321         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
322         https://bugs.webkit.org/show_bug.cgi?id=196543
323
324         Reviewed by Alex Christensen.
325
326         * WebKitTestRunner/TestController.cpp:
327         (WTR::TestController::generatePageConfiguration):
328
329 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
330
331         [ews-app] Status bubble should not display skipped buildbot steps
332         https://bugs.webkit.org/show_bug.cgi?id=196584
333
334         Reviewed by Lucas Forschler.
335
336         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
337
338 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
339
340         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
341         https://bugs.webkit.org/show_bug.cgi?id=196620
342
343         Reviewed by Lucas Forschler.
344
345         * BuildSlaveSupport/ews-app/ews/config.py:
346
347 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
348
349         [Win] DumpRenderTreeWatchDog.py is not checked into source
350         https://bugs.webkit.org/show_bug.cgi?id=196567
351         <rdar://problem/49525901>
352
353         Reviewed by Lucas Forschler.
354
355         This script is used on Win EWS bots to terminate hanging DRT processes.
356
357         * EWSTools/dumprendertreewatchdog.py: Added.
358
359 2019-04-04  Chris Dumez  <cdumez@apple.com>
360
361         Unreviewed, roll out r243858 which made tests time out.
362
363         Disable new API tests on Windows instead.
364
365         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
366         (TestWebKitAPI::TEST):
367
368 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
369
370         [ATK] Cleanup WebPageAccessibilityObjectAtk
371         https://bugs.webkit.org/show_bug.cgi?id=196537
372
373         Reviewed by Michael Catanzaro.
374
375         Also consider files under atk directories as exceptions for GObject conventions.
376
377         * Scripts/webkitpy/style/checkers/cpp.py:
378         (check_identifier_name_in_declaration):
379
380 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
381
382         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
383         https://bugs.webkit.org/show_bug.cgi?id=196588
384         <rdar://problem/49365787>
385
386         Unreviewed build fix for Windows port.
387
388         error C3861: 'kill': identifier not found
389
390         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
391         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
392
393 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
394
395         [ews-build] Cancel build and similar operations should have authentication
396         https://bugs.webkit.org/show_bug.cgi?id=196520
397
398         Reviewed by Dewei Zhu.
399
400         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
401         environment variables.
402
403 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
404
405         [ews-build] Do not trigger queues which are not in production yet
406         https://bugs.webkit.org/show_bug.cgi?id=196581
407
408         Reviewed by Dewei Zhu.
409
410         * BuildSlaveSupport/ews-build/config.json:
411
412 2019-04-03  Chris Dumez  <cdumez@apple.com>
413
414         Unreviewed, fix typo in the name of API test added in r243848.
415
416         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
417         (TestWebKitAPI::TEST):
418
419 2019-04-03  Chris Dumez  <cdumez@apple.com>
420
421         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
422         https://bugs.webkit.org/show_bug.cgi?id=196588
423         <rdar://problem/49365787>
424
425         Reviewed by Ryosuke Niwa.
426
427         Add API test coverage.
428
429         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
430         (TestWebKitAPI::nullJavaScriptCallback):
431         (TestWebKitAPI::didCrashCheckFrames):
432         (TestWebKitAPI::TEST):
433
434 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
435
436         run-webkit-tests: Upload test results (new results database)
437         https://bugs.webkit.org/show_bug.cgi?id=196577
438         <rdar://problem/34841155>
439
440         Reviewed by Lucas Forschler.
441
442         * Scripts/webkitpy/layout_tests/controllers/manager.py:
443         (Manager.run): Upload results after each device shard, since the configuration will be
444         different for each device.
445         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
446         uploaded to a results database.
447         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
448         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
449
450 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
451
452         -apple-trailing-word is needed for browser detection
453         https://bugs.webkit.org/show_bug.cgi?id=196575
454
455         Unreviewed.
456
457         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
458
459 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
460
461         [CMake][WTF] Mirror XCode header directories
462         https://bugs.webkit.org/show_bug.cgi?id=191662
463
464         Reviewed by Konstantin Tokarev.
465
466         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
467         builds.
468
469         * CMakeLists.txt:
470         * DumpRenderTree/CMakeLists.txt:
471         * DumpRenderTree/PlatformWin.cmake:
472         * MiniBrowser/win/CMakeLists.txt:
473         * TestWebKitAPI/CMakeLists.txt:
474         * TestWebKitAPI/PlatformWin.cmake:
475         * WebKitTestRunner/PlatformGTK.cmake:
476         * WebKitTestRunner/PlatformWin.cmake:
477
478 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
479
480         [ews-app] Status bubble should not display certain infrastructure status messages
481         https://bugs.webkit.org/show_bug.cgi?id=196550
482
483         Reviewed by Lucas Forschler.
484
485         Do not display the steps which are un-needed for end-user. This information is still avaiable
486         if the user click on the bubble and look at the Buildbot build.
487         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
488         (StatusBubble._steps_messages):
489         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
490
491 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
492
493         [ews-build] Use https for sending data to ews-app
494         https://bugs.webkit.org/show_bug.cgi?id=196492
495
496         Reviewed by Lucas Forschler.
497
498         * BuildSlaveSupport/ews-build/events.py:
499
500 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
501
502         Remove support for -apple-trailing-word
503         https://bugs.webkit.org/show_bug.cgi?id=196525
504
505         Reviewed by Zalan Bujtas.
506
507         This CSS property is nonstandard and not used.
508
509         * Scripts/webkitperl/FeatureList.pm:
510         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
511
512 2019-04-03  Youenn Fablet  <youenn@apple.com>
513
514         Add a test for DOMCache on multiple browsing in case of private browsing
515         https://bugs.webkit.org/show_bug.cgi?id=196524
516
517         Reviewed by Alex Christensen.
518
519         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
520         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
521
522 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
523
524         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
525         https://bugs.webkit.org/show_bug.cgi?id=196540
526
527         Reviewed by Aakash Jain.
528
529         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
530
531 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
532
533         Add plumbing for a compatibility mode preference in WebKit
534         https://bugs.webkit.org/show_bug.cgi?id=196005
535
536         Reviewed by Tim Horton.
537
538         Add new API tests.
539
540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
541         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
542
543 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
544
545         [WPE][GTK] Update libsrtp dependency package for Debian
546         https://bugs.webkit.org/show_bug.cgi?id=196528
547
548         Reviewed by Frédéric Wang.
549
550         * gtk/install-dependencies:
551         * wpe/install-dependencies:
552
553 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
554
555         [WK2] Add support for Window's beforeprint / afterprint events
556         https://bugs.webkit.org/show_bug.cgi?id=196478
557         <rdar://problem/49535124>
558
559         Unreviewed build fix for MSVC.
560
561         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
562
563         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
564
565         * WebKitTestRunner/TestController.cpp:
566         (WTR::printFrame): Use int and float literals.
567
568 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
569
570         [ews-build] Reassign bots to queues
571
572         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
573
574 2019-04-02  Chris Dumez  <cdumez@apple.com>
575
576         [WK2] Add support for Window's beforeprint / afterprint events
577         https://bugs.webkit.org/show_bug.cgi?id=196478
578
579         Reviewed by Alex Christensen.
580
581         Add minimal implementation for printFrame in WebKitTestRunner.
582
583         * WebKitTestRunner/TestController.cpp:
584         (WTR::printFrame):
585         (WTR::TestController::createOtherPage):
586         (WTR::TestController::createWebViewWithOptions):
587
588 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
589
590         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
591         https://bugs.webkit.org/show_bug.cgi?id=196491
592
593         Reviewed by Lucas Forschler.
594
595         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
596
597 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
598
599         [ews-build] Configure buildbot try credentials in environment variables
600         https://bugs.webkit.org/show_bug.cgi?id=196501
601
602         Reviewed by Lucas Forschler.
603
604         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
605         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
606         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
607
608 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
609
610         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
611         https://bugs.webkit.org/show_bug.cgi?id=196496
612         <rdar://problem/49521634>
613
614         Reviewed by Chris Dumez.
615
616         Add new API tests (see WebKit ChangeLog for more detail).
617
618         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
619         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
620         (TEST):
621
622 2019-04-02  David Kilzer  <ddkilzer@apple.com>
623
624         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
625         <https://webkit.org/b/196499>
626
627         Reviewed by Alexey Proskuryakov.
628
629         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
630         ENABLE_ADDRESS_SANITIZER.
631
632 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
633
634         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
635         https://bugs.webkit.org/show_bug.cgi?id=182757
636
637         Reviewed by Don Olmstead.
638
639         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
640         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
641
642 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
643
644         run-api-tests: Upload test results
645         https://bugs.webkit.org/show_bug.cgi?id=196323
646         <rdar://problem/49356714>
647
648         Reviewed by Lucas Forschler.
649
650         * Scripts/webkitpy/api_tests/manager.py:
651         (Manager):
652         (Manager.run): Upload results to a results database.
653         * Scripts/webkitpy/api_tests/run_api_tests.py:
654         (parse_args): Add upload arguments.
655         * Scripts/webkitpy/port/base.py:
656         (Port):
657         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
658         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
659         with commits from any other associated repositories.
660         * Scripts/webkitpy/port/device.py:
661         (Device):
662         (Device.build_version): Access build_versoin of underlying platform device.
663         * Scripts/webkitpy/port/ios_simulator_unittest.py:
664         (IOSSimulatorTest):
665         (IOSSimulatorTest.test_configuration_for_upload):
666         * Scripts/webkitpy/port/device_port.py:
667         (DevicePort):
668         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
669         the same as the machine uploading results.
670         * Scripts/webkitpy/port/mac.py:
671         (MacPort):
672         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
673         * Scripts/webkitpy/port/mac_unittest.py:
674         (MacTest):
675         (MacTest.test_configuration_for_upload):
676         * Scripts/webkitpy/xcode/simulated_device.py:
677         (SimulatedDeviceManager._create_device_with_runtime):
678         (SimulatedDevice.__init__): Create simulated device with a build_version.
679         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
680         (test_existing_simulator):
681
682 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
683
684         Remove extra newline characters (Follow-up fix to r243707)
685
686         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
687
688 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
689
690         [ews-app] Use API_KEY to accept results data
691         https://bugs.webkit.org/show_bug.cgi?id=196461
692
693         Reviewed by Dewei Zhu.
694
695         * BuildSlaveSupport/ews-app/ews/views/results.py:
696         (Results.post): Validate EWS_API_KEY before accepting any data.
697         * BuildSlaveSupport/ews-build/events.py:
698         (Events.sendData): Send EWS_API_KEY if available along with event data.
699
700 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
701
702         Unable to copy and paste a PDF from Notes into Mail compose body
703         https://bugs.webkit.org/show_bug.cgi?id=196442
704         <rdar://problem/48573098>
705
706         Reviewed by Tim Horton.
707
708         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
709         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
710         to be specified on the item providers.
711
712         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
713         (TestWebKitAPI::mapItemForTesting):
714         (TestWebKitAPI::contactItemForTesting):
715
716 2019-04-01  Tim Horton  <timothy_horton@apple.com>
717
718         Make UIWKDocumentContext rects per-character instead of per-word
719         https://bugs.webkit.org/show_bug.cgi?id=196459
720
721         Reviewed by Wenson Hsieh.
722
723         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
724         (TEST):
725         Adjust test results due to switching to per-character rects.
726
727 2019-04-01  Chris Dumez  <cdumez@apple.com>
728
729         UIProcess crash when a prewarmed process is terminated
730         https://bugs.webkit.org/show_bug.cgi?id=196451
731         <rdar://problem/49245471>
732
733         Reviewed by Geoffrey Garen.
734
735         Add API test coverage.
736
737         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
738         (TEST):
739
740 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
741
742         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
743         https://bugs.webkit.org/show_bug.cgi?id=196449
744
745         Reviewed by Lucas Forschler.
746
747         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
748         (StatusBubble.get_os_details): Method to get OS and Xcode details.
749         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
750         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
751
752 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
753
754         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
755         https://bugs.webkit.org/show_bug.cgi?id=196444
756
757         Reviewed by Lucas Forschler.
758
759         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
760
761 2019-04-01  Alex Christensen  <achristensen@webkit.org>
762
763         Add SPI to canonicalize NSURLs with WTF::URL
764         https://bugs.webkit.org/show_bug.cgi?id=196415
765         <rdar://problem/44980271>
766
767         Reviewed by Darin Adler.
768
769         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
770         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
771         (TestWebKitAPI::TEST):
772
773 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
774
775         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
776         https://bugs.webkit.org/show_bug.cgi?id=196441
777
778         Reviewed by Carlos Garcia Campos.
779
780         Don't cache the wpe_view_backend object that might not exist yet at the
781         time of EventSenderProxy constructor invocation, but instead retrieve
782         that object whenever it's required for event dispatching. This should
783         avoid crashes in this constructor now that it's invoked before any
784         PlatformWindow has been set up (as changed in r243496).
785
786         * WebKitTestRunner/EventSenderProxy.h:
787         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
788         (WTR::viewBackend):
789         (WTR::EventSenderProxy::EventSenderProxy):
790         (WTR::EventSenderProxy::mouseDown):
791         (WTR::EventSenderProxy::mouseUp):
792         (WTR::EventSenderProxy::mouseMoveTo):
793         (WTR::EventSenderProxy::mouseScrollBy):
794         (WTR::EventSenderProxy::keyDown):
795         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
796
797 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
798
799         [Win][WebKit] MiniBrowser should support high DPI display
800         https://bugs.webkit.org/show_bug.cgi?id=196391
801
802         Reviewed by Alex Christensen.
803
804         * MiniBrowser/win/WebKitBrowserWindow.cpp:
805         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
806         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
807         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
808
809 2019-03-31  Sam Weinig  <weinig@apple.com>
810
811         Remove more i386 specific configurations
812         https://bugs.webkit.org/show_bug.cgi?id=196430
813
814         Reviewed by Alexey Proskuryakov.
815
816         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
817         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
818
819 2019-03-31  Andy Estes  <aestes@apple.com>
820
821         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
822         https://bugs.webkit.org/show_bug.cgi?id=196433
823         <rdar://problem/49293305>
824
825         Reviewed by Tim Horton.
826
827         Enhanced API test coverage to include all navigation response policy decisions in both
828         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
829
830         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
831         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
832         (TestWebKitAPI::TEST):
833         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
834         (readFile):
835         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
836         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
837         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
838         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
839         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
840         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
841         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
842         (-[QuickLookDelegate _downloadDidStart:]):
843         (-[QuickLookDelegate _download:didReceiveResponse:]):
844         (-[QuickLookDelegate _download:didReceiveData:]):
845         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
846         (-[QuickLookDelegate _downloadDidFinish:]):
847         (-[QuickLookDelegate _download:didFailWithError:]):
848         (-[QuickLookDelegate _downloadDidCancel:]):
849         (-[QuickLookDelegate verifyDownload]):
850         (runTest):
851         (runTestDecideBeforeLoading):
852         (runTestDecideAfterLoading):
853         (TEST):
854         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
855         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
856         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
857         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
858         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
859         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
860         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
861         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
862         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
863         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
864         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
865         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
866         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
867         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
868
869 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
870
871         [CMake] add testdfg as target with build-jsc
872         https://bugs.webkit.org/show_bug.cgi?id=196393
873
874         Reviewed by Saam Barati.
875
876         Added testdfg as one of the targets to build when
877         using CMake.
878
879         * Scripts/build-jsc:
880
881 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
882
883         Delete WebMetal implementation in favor of WebGPU
884         https://bugs.webkit.org/show_bug.cgi?id=195418
885
886         Reviewed by Dean Jackson.
887
888         * DumpRenderTree/mac/DumpRenderTree.mm:
889         (enableExperimentalFeatures):
890         (resetWebPreferencesToConsistentValues):
891         * Scripts/webkitperl/FeatureList.pm:
892         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
894         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
895         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
896         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
897         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
898         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
899         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
900         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
901         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
902         (WTR::InjectedBundle::beginTesting):
903         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
904         (WTR::TestRunner::setWebMetalEnabled): Deleted.
905         * WebKitTestRunner/InjectedBundle/TestRunner.h:
906
907 2019-03-29  Chris Dumez  <cdumez@apple.com>
908
909         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
910         https://bugs.webkit.org/show_bug.cgi?id=196405
911         <rdar://problem/49428130>
912
913         Reviewed by Wenson Hsieh.
914
915         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
916         the popover presentation methods to be no-ops. Use this in the new test added in
917         r243523 so that we do not swizzle those methods for all tests. This is needed because
918         those WatchOS tests rely on the popover getting presented and interactive.
919
920         * WebKitTestRunner/TestController.cpp:
921         (WTR::updateTestOptionsFromTestHeader):
922         * WebKitTestRunner/TestController.h:
923         * WebKitTestRunner/TestOptions.h:
924         (WTR::TestOptions::hasSameInitializationOptions const):
925         * WebKitTestRunner/ios/TestControllerIOS.mm:
926         (WTR::TestController::platformInitialize):
927         (WTR::TestController::platformResetStateToConsistentValues):
928
929 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
930
931         [Curl] Add Server Trust Evaluation Support.
932         https://bugs.webkit.org/show_bug.cgi?id=191646
933
934         Reviewed by Fujii Hironori.
935
936         Implemented MiniBrowser UI for asking if user trusts the server.
937
938         * MiniBrowser/win/Common.cpp:
939         (askServerTrustEvaluation):
940         (replaceString):
941         * MiniBrowser/win/Common.h:
942         * MiniBrowser/win/MiniBrowserLib.rc:
943         * MiniBrowser/win/MiniBrowserLibResource.h:
944         * MiniBrowser/win/WebKitBrowserWindow.cpp:
945         (createPEMString):
946         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
947         (WebKitBrowserWindow::canTrustServerCertificate):
948         * MiniBrowser/win/WebKitBrowserWindow.h:
949
950 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
951
952         Implement ResizeObserver.
953         https://bugs.webkit.org/show_bug.cgi?id=157743
954
955         Reviewed by Simon Fraser.
956
957         Support resizeObserverEnabled webPreferences.
958
959         * DumpRenderTree/TestOptions.cpp:
960         (TestOptions::TestOptions):
961         * DumpRenderTree/TestOptions.h:
962         * DumpRenderTree/mac/DumpRenderTree.mm:
963         (setWebPreferencesForTestOptions):
964         * DumpRenderTree/win/DumpRenderTree.cpp:
965         (enableExperimentalFeatures):
966         * Scripts/webkitperl/FeatureList.pm:
967         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
968
969 2019-03-28  John Wilander  <wilander@apple.com>
970
971         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
972         https://bugs.webkit.org/show_bug.cgi?id=196281
973         <rdar://problem/48938748>
974
975         Reviewed by Alex Christensen.
976
977         This patch adds the function isStatisticsHasLocalStorage() to the
978         TestRunner. With it, the page can query the WebsiteDataStore in the
979         UI process to make sure that it sees LocalStorage.
980
981         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
982         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
983         (WTR::TestRunner::isStatisticsHasLocalStorage):
984         * WebKitTestRunner/InjectedBundle/TestRunner.h:
985         * WebKitTestRunner/TestController.cpp:
986         (WTR::TestController::isStatisticsHasLocalStorage):
987         * WebKitTestRunner/TestController.h:
988         * WebKitTestRunner/TestInvocation.cpp:
989         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
990
991 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
992
993         API::Data::createWithoutCopying should do a null check before calling CFRelease
994         https://bugs.webkit.org/show_bug.cgi?id=196276
995         <rdar://problem/48059859>
996
997         Reviewed by Alex Christensen.
998
999         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1000
1001         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1002         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1003         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1004         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1005         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1006         (TestWebKitAPI::TEST):
1007
1008 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1009
1010         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1011         https://bugs.webkit.org/show_bug.cgi?id=186276
1012
1013         Reviewed by Carlos Garcia Campos.
1014
1015         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1016         (webViewLoadChanged):
1017         (testWebResourceGetDataError):
1018         (testWebResourceGetDataEmpty):
1019         (beforeAll):
1020         (webViewloadChanged): Deleted.
1021
1022 2019-03-27  Andy Estes  <aestes@apple.com>
1023
1024         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1025         https://bugs.webkit.org/show_bug.cgi?id=196317
1026
1027         Reviewed by Dan Bernstein.
1028
1029         package-root copies built products into a staging directory using ditto(1), which does not
1030         follow symbolic links as it traverses a directory. Now that the files in
1031         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1032         itself, these become broken links when ditto'd into the staging directory.
1033
1034         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1035
1036         * Scripts/package-root:
1037
1038 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1039
1040         [ews-app] Update display text of Submit for ews analysis
1041         https://bugs.webkit.org/show_bug.cgi?id=196309
1042
1043         Reviewed by Dewei Zhu.
1044
1045         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1046
1047 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1048
1049         run-webkit-tests should check for leaks in WebKit processes
1050         <https://webkit.org/b/193772>
1051         <rdar://problem/46526680>
1052
1053         Reviewed by Ryosuke Niwa.
1054
1055         This works by doing the following:
1056         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1057           The list of child processes are returned one per line:
1058           process.name: pid
1059         - Run the "#LIST CHILD PROCESSES" command just before the
1060           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1061           processes on the ServerProcess object.
1062         - When the `--leaks` switch is handled, run check_for_leaks() on
1063           each child process after the main test harness.
1064
1065         * DumpRenderTree/mac/DumpRenderTree.mm:
1066         (handleControlCommand):
1067         - Use strncmp() instead of strcmp().
1068         - Add support for handling "#LIST CHILD PROCESSES" command.
1069
1070         * Scripts/webkitpy/port/base.py:
1071         (Port.check_for_leaks):
1072         * Scripts/webkitpy/port/darwin.py:
1073         (DarwinPort.check_for_leaks):
1074         - Rename redundant 'process_pid' argument to 'process_id'.
1075
1076         * Scripts/webkitpy/port/driver.py:
1077         (Driver.do_post_tests_work):
1078         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1079           longer the only command this sends to WebKitTestRunner.
1080         - If the `--leaks` switch is present, send the
1081           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1082           result using Port.set_webkit_processes().
1083         (Driver._parse_child_processes_output):
1084         - Add helper method to parse list of child process names and
1085           process IDs returned from WebKitTestRunner.
1086
1087         * Scripts/webkitpy/port/ios_device.py:
1088         (IOSDevicePort.check_for_leaks):
1089         - Rename redundant 'process_pid' argument to 'process_id'.
1090
1091         * Scripts/webkitpy/port/leakdetector.py:
1092         (LeakDetector._parse_leaks_output):
1093         - Return early if there is no leaks_output.
1094         (LeakDetector.check_for_leaks):
1095         - Rename redundant 'process_pid' argument to 'process_id'.
1096
1097         * Scripts/webkitpy/port/server_process.py:
1098         (ServerProcess.__init__):
1099         (ServerProcess.child_processes):
1100         (ServerProcess.set_child_processes):
1101         - Add instance variable to Port to store list of child process
1102           names and process IDs returned from WebKitTestRunner.
1103         (ServerProcess._start):
1104         - Clear self._child_processes.
1105         (ServerProcess.stop):
1106         - If self._child_processes is set, call
1107           self._port.check_for_leaks() for each child process.
1108
1109         * Scripts/webkitpy/port/server_process_unittest.py:
1110         (TrivialMockPort.check_for_leaks):
1111         - Rename redundant 'process_pid' argument to 'process_id'.
1112
1113         * Scripts/webkitpy/port/simulator_process.py:
1114         (SimulatorProcess.stop):
1115         - If self._child_processes is set, call
1116           self._port.check_for_leaks() for each child process.
1117
1118         * Scripts/webkitpy/port/watch_device.py:
1119         (WatchDevicePort.check_for_leaks):
1120         - Rename redundant 'process_pid' argument to 'process_id'.
1121
1122         * WebKitTestRunner/TestController.cpp:
1123         (WTR::TestController::dumpResponse):
1124         - Extract method from findAndDumpWorldLeaks() so that it may be
1125           reused by findAndDumpWebKitProcessIdentifiers().
1126         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1127         - Add method to output process name and process ID of both the
1128           WebContent and Networking processes.
1129         (WTR::TestController::findAndDumpWorldLeaks):
1130         - Fix missing newline in output when there were no abandoned
1131           documents.
1132         - Call dumpResponse() for extracted code.
1133         (WTR::TestController::handleControlCommand):
1134         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1135         - Use strncmp() instead of strcmp().
1136         - Call findAndDumpWebKitProcessIdentifiers() when
1137           "#LIST CHILD PROCESSES" command is sent.
1138         * WebKitTestRunner/TestController.h:
1139         (WTR::TestController::dumpResponse):
1140         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1141         - Declare methods.
1142
1143 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1144
1145         Unreviewed. Add GLib API test cases after r243434.
1146
1147         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1148         (testWebViewActiveURI):
1149         (serverCallback):
1150         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1151         (sendRequestCallback):
1152
1153 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1154
1155         Geolocation request not complete when watch request was started in a different web process
1156         https://bugs.webkit.org/show_bug.cgi?id=195996
1157
1158         Reviewed by Alex Christensen.
1159
1160         Add a test case.
1161
1162         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1163         (TestWebKitAPI::runJavaScriptAlert):
1164         (TestWebKitAPI::TEST):
1165
1166 2019-03-26  Keith Rollin  <krollin@apple.com>
1167
1168         Update the way generate-xcfilelists returns strings from functions
1169         https://bugs.webkit.org/show_bug.cgi?id=195975
1170         <rdar://problem/49040807>
1171
1172         Reviewed by Dean Jackson.
1173
1174         There are places where generate-xcfilelists executes assignments with
1175         statements like:
1176
1177             FOO=$(some_function)
1178
1179         where "some_function" return a string by echoing it. E.g.
1180
1181             some_function()
1182             {
1183                 echo "Hello, World"
1184             }
1185
1186         This is a common idiom, but it has a problem if "some_function" needs
1187         to call "exit" in an attempt to halt the entire script right then and
1188         there. Since "some_function" is called inside of $(), it's being
1189         executed in a sub-shell. Calling exit in that sub-shell simply exits
1190         that shell; it doesn't not exit the outer shell in which the main part
1191         of the script is still running. As such, the main script keeps
1192         executing when the intent was for the script to halt.
1193
1194         The solution to this is to use a different idiom for returning
1195         strings. The one we now is to pass in the name of the variable to
1196         receive the string result:
1197
1198             some_function()
1199             {
1200                 variable_name=$1
1201                 eval $variable_name ="Hello, World"
1202             }
1203
1204         The call site now looks like
1205
1206             some_function FOO
1207
1208         Because there's no invocation of a sub-shell, some_function can now
1209         call "exit" if it wants to, and the entire script will exit at that
1210         point.
1211
1212         * Scripts/generate-xcfilelists:
1213
1214 2019-03-26  Chris Dumez  <cdumez@apple.com>
1215
1216         Add basic layout test coverage for File Picker on iOS
1217         https://bugs.webkit.org/show_bug.cgi?id=196265
1218
1219         Reviewed by Wenson Hsieh.
1220
1221         Add layout test infrastructure to test the file picker on iOS.
1222
1223         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1224         (WTR::UIScriptController::dismissFilePicker):
1225         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1226         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1227         (WTR::UIScriptController::dismissFilePicker):
1228         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1229         * WebKitTestRunner/TestController.cpp:
1230         (WTR::TestController::createWebViewWithOptions):
1231         (WTR::updateTestOptionsFromTestHeader):
1232         * WebKitTestRunner/TestOptions.h:
1233         (WTR::TestOptions::hasSameInitializationOptions const):
1234         * WebKitTestRunner/ios/TestControllerIOS.mm:
1235         (overridePresentViewController):
1236         (WTR::TestController::platformInitialize):
1237         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1238         (WTR::UIScriptController::dismissFilePicker):
1239
1240 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1241
1242         Implement async paste method on UIWKInteractionViewProtocol
1243         https://bugs.webkit.org/show_bug.cgi?id=196267
1244         <rdar://problem/49236346>
1245
1246         Reviewed by Tim Horton.
1247
1248         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1249         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1250         are now a part of all iOS 12 internal SDKs.
1251
1252         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1253
1254         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1255         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1256
1257         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1258         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1259         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1260         * TestWebKitAPI/ios/UIKitSPI.h:
1261
1262 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1263
1264         [ews-build] Use PostgreSQL for ews.webkit.org database
1265         https://bugs.webkit.org/show_bug.cgi?id=196270
1266
1267         Reviewed by Lucas Forschler.
1268
1269         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1270
1271 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1272
1273         [ews] Reset simctl states on reboot
1274         https://bugs.webkit.org/show_bug.cgi?id=196260
1275
1276         Rubber-stamped by Aakash Jain.
1277
1278         * EWSTools/start-queue-mac.sh:
1279
1280 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1281
1282         [ews-build] Use PostgreSQL for ews-build database
1283         https://bugs.webkit.org/show_bug.cgi?id=196229
1284
1285         Reviewed by Lucas Forschler.
1286
1287         * BuildSlaveSupport/ews-build/master.cfg:
1288
1289 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1290
1291         [ews-build] Get master_hostname dynamically in master.cfg
1292         https://bugs.webkit.org/show_bug.cgi?id=196255
1293
1294         Reviewed by Lucas Forschler.
1295
1296         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1297         send events data in test mode.
1298
1299 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1300
1301         [ews-app] Set db_constraint to False for Foreign Keys
1302         https://bugs.webkit.org/show_bug.cgi?id=196252
1303
1304         Reviewed by Lucas Forschler.
1305
1306         * BuildSlaveSupport/ews-app/ews/models/build.py:
1307         * BuildSlaveSupport/ews-app/ews/models/step.py:
1308
1309 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1310
1311         [ews-build] is_test_mode_enabled should default to True
1312         https://bugs.webkit.org/show_bug.cgi?id=196248
1313
1314         Reviewed by Lucas Forschler.
1315
1316         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1317
1318 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1319
1320         [ews-app] Add webkitperl to ENABLED_QUEUES
1321         https://bugs.webkit.org/show_bug.cgi?id=196253
1322
1323         Reviewed by Lucas Forschler.
1324
1325         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1326
1327 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1328
1329         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1330         https://bugs.webkit.org/show_bug.cgi?id=196211
1331         rdar://problem/49110552
1332
1333         Reviewed by Tim Horton.
1334
1335         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1336         Make sure that EventSenderProxy always exists when running tests. We used to create
1337         it when resetting before the first test, which is a bit too late.
1338
1339         * WebKitTestRunner/TestController.h:
1340         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1341         (WTR::TestController::platformCreateWebView):
1342         (WTR::TestController::platformCreateOtherPage):
1343         (WTR::TestController::finishCreatingPlatformWebView):
1344         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1345         (WTR::PlatformWebView::PlatformWebView):
1346         Moved some code that made NSWindow use NSEvent during web view creation. We may
1347         need to move more if some other case us found, but this is enough for now.
1348
1349 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1350
1351         Unreviewed. Fix typo in GLib geolocation API after r243285.
1352
1353         gelocation -> geolocation.
1354
1355         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1356         (testGeolocationManagerWatchPosition):
1357
1358 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1359
1360         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1361         https://bugs.webkit.org/show_bug.cgi?id=196213
1362
1363         Reviewed by Geoff Garen.
1364
1365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1366         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1367         (credentialWithIdentityAndKeychainPath):
1368         (-[ChallengeDelegate webView:didFinishNavigation:]):
1369         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1370         (TestWebKitAPI::TEST):
1371
1372 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1373
1374         Expected shouldn't assume its contained types are copyable
1375         https://bugs.webkit.org/show_bug.cgi?id=195986
1376
1377         Reviewed by JF Bastien.
1378
1379         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1380         (TestWebKitAPI::NonCopyable::operator== const):
1381         (TestWebKitAPI::NonCopyable::operator!= const):
1382         (TestWebKitAPI::TEST):
1383
1384 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1385
1386         Remove some now-unnecessary dynamic class lookup
1387         https://bugs.webkit.org/show_bug.cgi?id=196237
1388
1389         Reviewed by Simon Fraser.
1390
1391         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1392         (makeRequest):
1393         (TEST):
1394
1395 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1396
1397         Unreviewed, rolling out r243450.
1398
1399         AppleWin and WinCairo port builds get broken.
1400
1401         Reverted changeset:
1402
1403         "Add test for fix of #196095"
1404         https://bugs.webkit.org/show_bug.cgi?id=196097
1405         https://trac.webkit.org/changeset/243450
1406
1407 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1408
1409         Unreviewed, rolling out r243465.
1410         https://bugs.webkit.org/show_bug.cgi?id=196226
1411
1412         the test doesn't build (Requested by thorton on #webkit).
1413
1414         Reverted changeset:
1415
1416         "Do not terminate the NetworkProcess if a third party
1417         application sends a NSCredential with a SecIdentityRef"
1418         https://bugs.webkit.org/show_bug.cgi?id=196213
1419         https://trac.webkit.org/changeset/243465
1420
1421 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1422
1423         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1424         https://bugs.webkit.org/show_bug.cgi?id=196213
1425
1426         Reviewed by Geoff Garen.
1427
1428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1429         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1430         (credentialWithIdentityAndKeychainPath):
1431         (-[ChallengeDelegate webView:didFinishNavigation:]):
1432         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1433         (TestWebKitAPI::TEST):
1434
1435 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1436
1437         [ews-build] Gracefully handle missing patch_id in events
1438         https://bugs.webkit.org/show_bug.cgi?id=196216
1439
1440         Reviewed by Lucas Forschler.
1441
1442         * BuildSlaveSupport/ews-build/events.py:
1443
1444 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1445
1446         [ews-build] use lz4 compression for improving buildbot performance
1447         https://bugs.webkit.org/show_bug.cgi?id=196155
1448
1449         Reviewed by Lucas Forschler.
1450
1451         * BuildSlaveSupport/ews-build/master.cfg:
1452
1453 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1454
1455         Pull some API testing helper methods out of TestWKWebView
1456         https://bugs.webkit.org/show_bug.cgi?id=196212
1457
1458         Reviewed by Tim Horton.
1459
1460         Refactor some more API testing utility methods, so that they can be used in
1461         tests that do not use TestWKWebView.
1462
1463         * TestWebKitAPI/cocoa/TestWKWebView.h:
1464         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1465         (-[WKWebView loadTestPageNamed:]):
1466         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1467         (-[WKWebView synchronouslyLoadHTMLString:]):
1468         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1469         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1470         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1471         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1472         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1473
1474 2019-03-25  Jer Noble  <jer.noble@apple.com>
1475
1476         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1477         https://bugs.webkit.org/show_bug.cgi?id=196097
1478
1479         Reviewed by Eric Carlson.
1480
1481         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1482
1483         * DumpRenderTree/mac/DumpRenderTree.mm:
1484         (resetWebPreferencesToConsistentValues):
1485         * WebKitTestRunner/TestController.cpp:
1486         (WTR::TestController::resetPreferencesToConsistentValues):
1487
1488 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1489
1490         Pull IPadUserInterfaceSwizzler out into a separate header file
1491         https://bugs.webkit.org/show_bug.cgi?id=196193
1492
1493         Reviewed by Anders Carlsson.
1494
1495         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1496         be used in other API tests.
1497
1498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1499         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1500         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1501         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1502         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1503         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1504         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1505
1506 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1507
1508         Remove NavigatorContentUtils in WebCore/Modules
1509         https://bugs.webkit.org/show_bug.cgi?id=196070
1510
1511         Reviewed by Alex Christensen.
1512
1513         NavigatorContentUtils was to support the custom scheme spec [1].
1514         However, in WebKit side, no port has supported the feature in
1515         WebKit layer after EFL port was removed. So there has been the
1516         only IDL implementation of the NavigatorContentUtils in WebCore.
1517         So we don't need to keep the implementation in WebCore anymore.
1518
1519         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1520
1521         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1522
1523 2019-03-24  Andy Estes  <aestes@apple.com>
1524
1525         [watchOS] Remove unused Proximity Networking code
1526         https://bugs.webkit.org/show_bug.cgi?id=196188
1527
1528         Reviewed by Tim Horton.
1529
1530         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1531         (TEST):
1532
1533 2019-03-23  Keith Miller  <keith_miller@apple.com>
1534
1535         Refactor clz/ctz and fix getLSBSet.
1536         https://bugs.webkit.org/show_bug.cgi?id=196162
1537
1538         Reviewed by Saam Barati.
1539
1540         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1541
1542         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1543         (TestWebKitAPI::TEST):
1544
1545 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1546
1547         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1548         https://bugs.webkit.org/show_bug.cgi?id=196143
1549
1550         Reviewed by Michael Catanzaro.
1551
1552         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1553         directories.
1554
1555         * Scripts/webkitpy/style/checkers/cpp.py:
1556         (check_identifier_name_in_declaration):
1557         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1558         (WebKitStyleTest.test_names):
1559
1560 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1561
1562         [Flatpak] Manifest expanding fails for qt WPE extension
1563         https://bugs.webkit.org/show_bug.cgi?id=196148
1564
1565         Reviewed by Alex Christensen.
1566
1567         * flatpak/flatpakutils.py:
1568         (expand_submodules_recurse): The last recurse manifest expand
1569         iteration might lead to a single module so take it into account
1570         and don't try to recurse further.
1571
1572 2019-03-22  Chris Dumez  <cdumez@apple.com>
1573
1574         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1575         https://bugs.webkit.org/show_bug.cgi?id=195348
1576         <rdar://problem/48622090>
1577
1578         Reviewed by Alex Christensen.
1579
1580         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1581         to NO when test.options().shouldIgnoreMetaViewport is false.
1582
1583         * WebKitTestRunner/ios/TestControllerIOS.mm:
1584         (WTR::TestController::platformConfigureViewForTest):
1585
1586 2019-03-22  Chris Dumez  <cdumez@apple.com>
1587
1588         Prewarmed processes should be usable with any website data store
1589         https://bugs.webkit.org/show_bug.cgi?id=196104
1590
1591         Reviewed by Alex Christensen.
1592
1593         Add API test coverage.
1594
1595         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1596         (runInitialWarmedProcessUsedTest):
1597         (TEST):
1598
1599 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1600
1601         Back out local changes to Alex's Subversion working directory
1602
1603         They were accidentally committed.
1604
1605         * Scripts/webkitpy/common/system/abstractexecutive.py:
1606         (AbstractExecutive.wait_newest):
1607         * Scripts/webkitpy/common/system/executive.py:
1608         (Executive.running_pids):
1609         * Scripts/webkitpy/common/system/executive_mock.py:
1610         (MockExecutive.running_pids):
1611         * Scripts/webkitpy/common/system/executive_unittest.py:
1612         (ExecutiveTest.serial_test_running_pids):
1613         * Scripts/webkitpy/port/darwin.py:
1614         (DarwinPort.check_for_leaks):
1615         * Scripts/webkitpy/port/leakdetector.py:
1616         (LeakDetector.check_for_leaks):
1617         - This was the hack attached to Bug 193772.
1618
1619         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1620         (+[WebKitTestRunnerEvent mouseLocation]):
1621         - This works around a crash on an internal build.
1622
1623 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1624
1625         Fix the build after r243354
1626         https://bugs.webkit.org/show_bug.cgi?id=196138
1627         <rdar://problem/49145951>
1628
1629         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1630         (TEST):
1631         * TestWebKitAPI/ios/UIKitSPI.h:
1632
1633 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1634
1635         Adopt UIWKDocumentContext
1636         https://bugs.webkit.org/show_bug.cgi?id=196040
1637         <rdar://problem/48642440>
1638
1639         Reviewed by Ryosuke Niwa.
1640
1641         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1642         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1643         (makeRequest):
1644         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1645         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1646         (applyStyle):
1647         (TEST):
1648         Add tests for UIWKDocumentContext.
1649
1650         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1651         (TEST):
1652         (recursiveFindWKContentView): Deleted.
1653         * TestWebKitAPI/cocoa/TestWKWebView.h:
1654         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1655         (recursiveFindWKContentView):
1656         (-[TestWKWebView wkContentView]):
1657         * TestWebKitAPI/ios/UIKitSPI.h:
1658         Share the WKContentView finding code between tests.
1659
1660 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1661
1662         [iOS WK2] Turn on async overflow scrolling by default
1663         https://bugs.webkit.org/show_bug.cgi?id=196011
1664         rdar://problem/48453859
1665
1666         Reviewed by Antti Koivisto.
1667         
1668         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1669         since so many basic layout tests have different results when compositing is triggered for
1670         overflow.
1671         
1672         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1673
1674         * WebKitTestRunner/TestController.cpp:
1675         (WTR::TestController::resetPreferencesToConsistentValues):
1676
1677 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1678
1679         [ews-build] Retry API test in case of failures
1680         https://bugs.webkit.org/show_bug.cgi?id=196004
1681
1682         Reviewed by Lucas Forschler.
1683
1684         * BuildSlaveSupport/ews-build/steps.py:
1685         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1686         (CompileWebKitToT.doStepIf): Ditto.
1687         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1688         (ReRunAPITests): Re-run API tests.
1689         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1690         (RunAPITestsWithoutPatch): Run API tests without patch.
1691         (RunAPITestsWithoutPatch.doStepIf):
1692         (RunAPITestsWithoutPatch.hideStepIf):
1693         (RunAPITestsWithoutPatch.evaluateCommand):
1694         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1695         (AnalyzeAPITestsResults.start):
1696         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1697         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1698         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1699         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1700
1701 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1702
1703         [ews-build] Update queues configurations
1704         https://bugs.webkit.org/show_bug.cgi?id=196074
1705
1706         Reviewed by Dewei Zhu.
1707
1708         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1709         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1710
1711 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1712
1713         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1714         https://bugs.webkit.org/show_bug.cgi?id=195680
1715         <rdar://problem/48903534>
1716
1717         Unreviewed infrastructure fix.
1718
1719         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1720         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1721
1722 2019-03-21  Andy Estes  <aestes@apple.com>
1723
1724         [iOS] Apple Pay should be available in documents with no user agent scripts
1725         https://bugs.webkit.org/show_bug.cgi?id=196061
1726         <rdar://problem/48649391>
1727
1728         Reviewed by Brady Eidson.
1729
1730         Added API tests and related infrastructure.
1731
1732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1733         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1734         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1735         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1736         (TestWebKitAPI::TEST):
1737         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1738         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1739         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1740         * TestWebKitAPI/cocoa/TestProtocol.mm:
1741         (-[TestProtocol startLoading]):
1742         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1743         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1744         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1745         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1746
1747 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1748
1749         REGRESSSION (r243297): webkitpy tests broken
1750         https://bugs.webkit.org/show_bug.cgi?id=196108
1751
1752         Reviewed by Aakash Jain.
1753
1754         r243297 updated contributors.json, which broke a few unit tests.
1755
1756         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1757         (IRCCommandTest.test_whois):
1758         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1759
1760 2019-03-21  Chris Dumez  <cdumez@apple.com>
1761
1762         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1763         https://bugs.webkit.org/show_bug.cgi?id=196041
1764         <rdar://problem/49083230>
1765
1766         Reviewed by Alex Christensen.
1767
1768         Add API test coverage.
1769
1770         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1771         (TEST):
1772
1773 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1774
1775         Add SPI to inform applications of WKContentRuleList actions
1776         https://bugs.webkit.org/show_bug.cgi?id=195965
1777         <rdar://problem/42664365>
1778
1779         Reviewed by Geoff Garen.
1780
1781         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1782         (TestWebKitAPI::allActionsForResourceLoad):
1783         (TestWebKitAPI::testRequest):
1784         (TestWebKitAPI::TEST_F):
1785         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1786         (Notification::description):
1787         (Notification::operator== const):
1788         (toVector):
1789         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1790         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1791         (makeContentRuleList):
1792         (TEST):
1793         (makeWarnContentRuleList): Deleted.
1794
1795 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1796
1797         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1798         https://bugs.webkit.org/show_bug.cgi?id=196088
1799
1800         Reviewed by Brian Burg.
1801
1802         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1803         Support checks when only one platform is specified. Also deprecate macosx() and
1804         force the use of macos() instead.
1805
1806         * Scripts/webkitpy/style/checkers/cpp.py:
1807         (check_min_versions_of_wk_api_available):
1808         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1809         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1810
1811 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1812
1813         Update status inactive committers' status to 'contributor'.
1814
1815         * Scripts/webkitpy/common/config/contributors.json:
1816
1817 2019-03-21  Xan Lopez  <xan@igalia.com>
1818
1819         [JSC][x86] Drop support for x87 floating point
1820         https://bugs.webkit.org/show_bug.cgi?id=194853
1821
1822         Reviewed by Don Olmstead.
1823
1824         Force SSE2 on x86/32bit builds.
1825
1826         * Scripts/webkitdirs.pm:
1827         (generateBuildSystemFromCMakeProject):
1828
1829 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1830
1831         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1832         https://bugs.webkit.org/show_bug.cgi?id=196073
1833
1834         Reviewed by Michael Catanzaro.
1835
1836         Add test cases to check functions and constructors with no arguments but receiving user data.
1837
1838         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1839         (checkUserData):
1840         (testJSCFunction):
1841         (fooCreateWithUserData):
1842         (testJSCClass):
1843
1844 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1845
1846         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1847
1848         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1849
1850         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1851
1852 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1853
1854         [GTK][WPE] Add API to provide geolocation information
1855         https://bugs.webkit.org/show_bug.cgi?id=195940
1856
1857         Reviewed by Michael Catanzaro.
1858
1859         Add a new test to check the new API.
1860
1861         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1862         (testGeolocationManagerCurrentPosition):
1863         (testGeolocationManagerWatchPosition):
1864         (beforeAll):
1865         (afterAll):
1866         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1867         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1868         (beforeAll): Ditto.
1869         * TestWebKitAPI/glib/CMakeLists.txt:
1870
1871 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1872
1873         [GLib] Returning G_TYPE_OBJECT from a method does not work
1874         https://bugs.webkit.org/show_bug.cgi?id=195574
1875
1876         Reviewed by Michael Catanzaro.
1877
1878         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1879
1880         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1881         (getGFile):
1882         (getParent):
1883         (createGString):
1884         (getGString):
1885         (getGStringCopyWillRaise):
1886         (getGStringCopy):
1887         (getGStringStr):
1888         (getGStringLen):
1889         (freeGString):
1890         (testJSCClass):
1891
1892 2019-03-20  Saam Barati  <sbarati@apple.com>
1893
1894         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1895         https://bugs.webkit.org/show_bug.cgi?id=195721
1896
1897         Reviewed by Filip Pizlo.
1898
1899         * Scripts/run-javascriptcore-tests:
1900
1901 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1902
1903         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1904         https://bugs.webkit.org/show_bug.cgi?id=196049
1905
1906         Reviewed by Tim Horton.
1907
1908         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1909         overflow scrolling in general, so rename it.
1910
1911         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1912
1913 2019-03-20  Daniel Bates  <dabates@apple.com>
1914
1915         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1916         https://bugs.webkit.org/show_bug.cgi?id=196031
1917         <rdar://problem/49078172>
1918
1919         Reviewed by Tim Horton.
1920
1921         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1922         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1923         same code path used when the Done button is pressed to dismiss the <select> picker.
1924
1925         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1926         (TestWebKitAPI::TEST):
1927
1928 2019-03-20  Chris Dumez  <cdumez@apple.com>
1929
1930         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1931         https://bugs.webkit.org/show_bug.cgi?id=196029
1932         <rdar://problem/48954651>
1933
1934         Reviewed by Tim Horton.
1935
1936         Add API test coverage.
1937
1938         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1939
1940 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1941
1942         [ews-build] Improve failure summary string for ApplyPatch step
1943         https://bugs.webkit.org/show_bug.cgi?id=195995
1944
1945         Reviewed by Alexey Proskuryakov.
1946
1947         * BuildSlaveSupport/ews-build/steps.py:
1948         (ApplyPatch.getResultSummary): Override getResultSummary.
1949
1950 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1951
1952         AX: Implement support for new meter ARIA role
1953         https://bugs.webkit.org/show_bug.cgi?id=195966
1954
1955         Reviewed by Chris Fleizach.
1956
1957         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1958         to AXLevelIndicator.
1959
1960         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1961
1962 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1963
1964         [WebAuthN] Implement FIDO AppID extension
1965         https://bugs.webkit.org/show_bug.cgi?id=143491
1966         <rdar://problem/48298273>
1967
1968         Reviewed by Brent Fulgham.
1969
1970         Add a test that covers the new flag of convertToU2fSignCommand.
1971
1972         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1973         (TestWebKitAPI::TEST):
1974         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1975         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1976         (TestWebKitAPI::TEST):
1977
1978 2019-03-19  Keith Rollin  <krollin@apple.com>
1979
1980         Add support for more platforms to generate-xcfilelists
1981         https://bugs.webkit.org/show_bug.cgi?id=195977
1982
1983         Reviewed by Alexey Proskuryakov.
1984
1985         generate-xcfilelists incorrectly complains when involved with building
1986         WebKit for iphonesimulator:
1987
1988             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1989             …
1990             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1991
1992         Address this by teaching generate-xcfilelists about more platforms.
1993
1994         * Scripts/generate-xcfilelists:
1995
1996 2019-03-19  John Wilander  <wilander@apple.com>
1997
1998         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1999         https://bugs.webkit.org/show_bug.cgi?id=195923
2000         <rdar://problem/49001272>
2001
2002         Reviewed by Alex Christensen.
2003
2004         This patch does the following to the TestRunner:
2005         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2006         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2007         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2008
2009         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2010         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2011         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2012         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2013         * WebKitTestRunner/TestController.cpp:
2014         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2015         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2016         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2017         * WebKitTestRunner/TestController.h:
2018         * WebKitTestRunner/TestInvocation.cpp:
2019         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2020
2021 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2022
2023         [CMake] Support more clang and gcc sanitizers
2024         https://bugs.webkit.org/show_bug.cgi?id=195956
2025
2026         Reviewed by Michael Catanzaro.
2027
2028         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2029
2030 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2031
2032         [ews-build] Improve summary for PrintConfiguration step
2033         https://bugs.webkit.org/show_bug.cgi?id=195945
2034
2035         Reviewed by Lucas Forschler.
2036
2037         * BuildSlaveSupport/ews-build/steps.py:
2038         (PrintConfiguration.getResultSummary): Override getResultSummary.
2039
2040 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2041
2042         [ews-build] Improve summary for CheckOutSource step
2043         https://bugs.webkit.org/show_bug.cgi?id=195963
2044
2045         Reviewed by Lucas Forschler.
2046
2047         * BuildSlaveSupport/ews-build/steps.py:
2048         (CheckOutSource.getResultSummary):
2049
2050 2019-03-19  Daniel Bates  <dabates@apple.com>
2051
2052         [iOS] Focus not preserved when switching between tabs
2053         https://bugs.webkit.org/show_bug.cgi?id=195820
2054         <rdar://problem/43614450>
2055
2056         Reviewed by Brent Fulgham.
2057
2058         Add tests to ensure that we restore focus when resigning and becoming first responder.
2059
2060         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2061         (TestWebKitAPI::TEST):
2062
2063 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2064
2065         Make WTFLogChannelState and WTFLogLevel enum classes
2066         https://bugs.webkit.org/show_bug.cgi?id=195904
2067
2068         Reviewed by Eric Carlson.
2069
2070         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2071         (TestWebKitAPI::TEST_F):
2072
2073 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2074
2075         [GStreamer][EME] Backported mssdemux protection data crash fix
2076         https://bugs.webkit.org/show_bug.cgi?id=195918
2077
2078         Reviewed by Philippe Normand.
2079
2080         * gstreamer/jhbuild.modules:
2081         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2082
2083 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2084
2085         Unreviewed, rolling out r243132.
2086
2087         Broke GTK build
2088
2089         Reverted changeset:
2090
2091         "Make WTFLogChannelState and WTFLogLevel enum classes"
2092         https://bugs.webkit.org/show_bug.cgi?id=195904
2093         https://trac.webkit.org/changeset/243132
2094
2095 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2096
2097         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2098
2099         * Scripts/webkitdirs.pm:
2100         (builtDylibPathForName): Adjust the shared library name that's changed
2101         with the API version bump in r243073.
2102
2103 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2104
2105         Make WTFLogChannelState and WTFLogLevel enum classes
2106         https://bugs.webkit.org/show_bug.cgi?id=195904
2107
2108         Reviewed by Eric Carlson.
2109
2110         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2111         (TestWebKitAPI::TEST_F):
2112
2113 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2114
2115         Disable flaky test added in r2431100
2116         https://webkit.org/b/195785
2117
2118         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2119         (TestWebKitAPI::TEST):
2120         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2121
2122 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2123
2124         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2125         https://bugs.webkit.org/show_bug.cgi?id=195916
2126
2127         Reviewed by Tim Horton.
2128
2129         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2130         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2131
2132 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2133
2134         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2135
2136         * Scripts/webkitpy/common/config/contributors.json:
2137
2138 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2139
2140         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2141         https://bugs.webkit.org/show_bug.cgi?id=195785
2142
2143         Reviewed by Geoffrey Garen.
2144
2145         * TestWebKitAPI/TCPServer.cpp: Added.
2146         (TestWebKitAPI::TCPServer::TCPServer):
2147         (TestWebKitAPI::TCPServer::~TCPServer):
2148         (TestWebKitAPI::TCPServer::socketBindListen):
2149         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2150         * TestWebKitAPI/TCPServer.h: Added.
2151         (TestWebKitAPI::TCPServer::port const):
2152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2153         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2154         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2155         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2156         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2157         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2158         (TestWebKitAPI::respondSlowly):
2159         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2160         (TestWebKitAPI::downloadAtRate):
2161         (TestWebKitAPI::TEST):
2162
2163 2019-03-18  Saam Barati  <sbarati@apple.com>
2164
2165         Add a plan file for JetStream 2
2166         https://bugs.webkit.org/show_bug.cgi?id=190734
2167
2168         Reviewed by Mark Lam.
2169
2170         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2171
2172 2019-03-18  Chris Dumez  <cdumez@apple.com>
2173
2174         Delay WebProcess launch until a load is triggered in a Web view
2175         https://bugs.webkit.org/show_bug.cgi?id=195758
2176         <rdar://problem/48126013>
2177
2178         Reviewed by Geoff Garen.
2179
2180         Add API test coverage. Also update some existing API tests to not expect
2181         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2182
2183         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2184         (TestWebKitAPI::TEST):
2185         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2186         (TestWebKitAPI::TEST):
2187         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2188         (TEST):
2189         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2190         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2191         (TEST):
2192         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2193         (TEST):
2194         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2195
2196 2019-03-18  Xan Lopez  <xan@igalia.com>
2197
2198         [CMake] Prevent potential warning when determining $architecture
2199         https://bugs.webkit.org/show_bug.cgi?id=195891
2200
2201         Reviewed by Michael Catanzaro.
2202
2203         It's possible for generateBuildSystemForCMakeProject to be called
2204         before determineArchitecture() is ever called. This will make the
2205         first eq check with $architecture to be bogus (and print a
2206         warning). Change that to an eq check with architecture(), which
2207         implicitly calls determineArchitecture() if needed, and change all
2208         the other similar cases in the method in the same way to prevent
2209         future bugs like this one.
2210
2211         * Scripts/webkitdirs.pm:
2212         (generateBuildSystemFromCMakeProject):
2213
2214 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2215
2216         [WPE] Tarballs generated with “make dist” cannot build documentation
2217         https://bugs.webkit.org/show_bug.cgi?id=195885
2218
2219         Reviewed by Carlos Garcia Campos.
2220
2221         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2222
2223 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2224
2225         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2226         https://bugs.webkit.org/show_bug.cgi?id=195883
2227
2228         Reviewed by Carlos Garcia Campos.
2229
2230         * gtkdoc/gtkdoc.py:
2231         (GTKDoc._run_command): When commands fail to run, include the full command line for
2232         the program invocation and the output it has generated on the standard error stream.
2233
2234 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2235
2236         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2237         https://bugs.webkit.org/show_bug.cgi?id=195786
2238
2239         Reviewed by Philippe Normand.
2240
2241         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2242         * wpe/jhbuild.modules: Ditto.
2243
2244 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2245
2246         [ews-build] Don't run clean builds on EWS builders
2247         https://bugs.webkit.org/show_bug.cgi?id=195851
2248
2249         Reviewed by Geoffrey Garen.
2250
2251         * BuildSlaveSupport/ews-build/factories.py:
2252
2253 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2254
2255         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2256         https://bugs.webkit.org/show_bug.cgi?id=195849
2257
2258         Reviewed by Chris Dumez.
2259
2260         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2261
2262         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2263         (runWebsiteDataStoreCustomPaths):
2264
2265 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2266
2267         webkitpy: Upload test results
2268         https://bugs.webkit.org/show_bug.cgi?id=195755
2269         <rdar://problem/48896182>
2270
2271         Reviewed by Aakash Jain.
2272
2273         Establish a new format for uploading results that is not tied to layout tests, apply
2274         that format to webkitpy tests.
2275
2276         * Scripts/webkitpy/common/checkout/scm/git.py:
2277         (Git.native_branch): Return what branch the current checkout is on.
2278         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2279         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2280         * Scripts/webkitpy/common/checkout/scm/svn.py:
2281         (SVN.native_branch): Ditto.
2282         * Scripts/webkitpy/common/system/platforminfo.py:
2283         (PlatformInfo.build_version): Return a build version for Mac.
2284         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2285         (MockPlatformInfo.__init__):
2286         (MockPlatformInfo.build_version):
2287         * Scripts/webkitpy/results: Added.
2288         * Scripts/webkitpy/results/__init__.py: Added.
2289         * Scripts/webkitpy/results/options.py: Added.
2290         (upload_options): OptParse list for upload options.
2291         * Scripts/webkitpy/results/upload.py: Added.
2292         (Upload): Class which enforces the upload format expected by the results server.
2293         (Upload.Expectations):
2294         (Upload.create_configuration):
2295         (Upload.create_commit):
2296         (Upload.create_details):
2297         (Upload.create_run_stats):
2298         (Upload.create_test_result):
2299         (Upload.__init__):
2300         (Upload.Encoder): Encode Upload object as json.
2301         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2302         * Scripts/webkitpy/results/upload_unittest.py: Added.
2303         * Scripts/webkitpy/test/main.py:
2304         (Tester._parse_args): Add upload arguments.
2305         (Tester._run_tests): Allow results to be uploaded.
2306         * Scripts/webkitpy/test/runner.py:
2307         (Runner.__init__): Record which tests were run, rather than just counting them.
2308         (Runner.handle):
2309         * Scripts/webkitpy/test/runner_unittest.py:
2310         (RunnerTest.test_run):
2311         * Scripts/webkitpy/thirdparty/__init__.py:
2312         (AutoinstallImportHook.find_module): Add requests auto-install.
2313         (AutoinstallImportHook._install_requests):
2314         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2315         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2316
2317 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2318
2319         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2320         https://bugs.webkit.org/show_bug.cgi?id=195810
2321
2322         Reviewed by Tim Horton.
2323
2324         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2325         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2326         ending certain layout tests.
2327
2328         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2329         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2330         (-[TestRunnerWKWebView dealloc]):
2331         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2332
2333         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2334         helper method when destroying the web view, and when resetting state between tests.
2335
2336         * WebKitTestRunner/ios/TestControllerIOS.mm:
2337         (WTR::TestController::platformResetStateToConsistentValues):
2338
2339         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2340
2341 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2342
2343         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2344         https://bugs.webkit.org/show_bug.cgi?id=190350
2345         <rdar://problem/45089503>
2346
2347         Reviewed by Geoffrey Garen.
2348
2349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2350         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2351         (TEST):
2352         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2353         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2354         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2355         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2356         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2357         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2358         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2359         (runTest):
2360         (createDirectories):
2361         (TEST):
2362         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2363         (TEST):
2364         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2365         (TEST):
2366
2367 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2368
2369         Add support to WebPage for getting the contents as an attributed string.
2370         https://bugs.webkit.org/show_bug.cgi?id=195636
2371         rdar://problem/45055697
2372
2373         Reviewed by Tim Horton.
2374
2375         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2376         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2377
2378 2019-03-15  Chris Dumez  <cdumez@apple.com>
2379
2380         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2381         https://bugs.webkit.org/show_bug.cgi?id=195747
2382
2383         Reviewed by Geoff Garen.
2384
2385         Add API test coverage.
2386
2387         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2388
2389 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2390
2391         Unreviewed, rolling out r242952.
2392
2393         Causing API failures on iOS Simulator
2394
2395         Reverted changeset:
2396
2397         "[PSON] Make sure the WebProcessCache is leverage when
2398         relaunching a process after termination"
2399         https://bugs.webkit.org/show_bug.cgi?id=195747
2400         https://trac.webkit.org/changeset/242952
2401
2402 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2403
2404         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2405         https://bugs.webkit.org/show_bug.cgi?id=195740
2406
2407         Reviewed by Ross Kirsling.
2408
2409         window.open doesn't work for WebKitBrowserWindow because it is not
2410         implemented yet.
2411
2412         1. Implemented createNewPage callback of WKPageUIClient.
2413         2. Changed MainWindow to take a BrowserWindow factory function
2414           instead of BrowserWindowType to be flexible to create
2415           BrowserWindow with extra settings.
2416         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2417           because it is not relevant with MainWindow anymore.
2418
2419         * MiniBrowser/win/Common.cpp:
2420         (parseCommandLine):
2421         * MiniBrowser/win/Common.h:
2422         (CommandLineOptions::CommandLineOptions):
2423         * MiniBrowser/win/MainWindow.cpp:
2424         (MainWindow::MainWindow):
2425         (MainWindow::create):
2426         (MainWindow::init):
2427         (MainWindow::WndProc):
2428         * MiniBrowser/win/MainWindow.h:
2429         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2430         (PrintWebUIDelegate::createWebViewWithRequest):
2431         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2432         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2433         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2434         (WebKitBrowserWindow::updateProxySettings):
2435         (WebKitBrowserWindow::createNewPage):
2436         * MiniBrowser/win/WebKitBrowserWindow.h:
2437         * MiniBrowser/win/WinMain.cpp:
2438         (wWinMain):
2439
2440 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2441
2442         Make it possible to test scrolling tree layer manipulation more easily
2443         https://bugs.webkit.org/show_bug.cgi?id=195780
2444
2445         Reviewed by Tim Horton.
2446         
2447         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2448         cuts off communication of scrolling tree scrolls back to the web process
2449         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2450         allows tests to trigger scrolls which run the scrolling tree layer positioning
2451         logic, but never get another commit from the web process that might mask
2452         scrolling tree bugs.
2453         
2454         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2455         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2456         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2457
2458         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2459         (WTR::UIScriptController::scrollUpdatesDisabled const):
2460         (WTR::UIScriptController::setScrollUpdatesDisabled):
2461         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2462         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2463         (WTR::UIScriptController::scrollUpdatesDisabled const):
2464         (WTR::UIScriptController::setScrollUpdatesDisabled):
2465         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2466         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2467         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2468         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2469         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2470         * WebKitTestRunner/ios/TestControllerIOS.mm:
2471         (WTR::TestController::platformResetStateToConsistentValues):
2472         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2473         (WTR::UIScriptController::scrollUpdatesDisabled const):
2474         (WTR::UIScriptController::setScrollUpdatesDisabled):
2475
2476 2019-03-14  Youenn Fablet  <youenn@apple.com>
2477
2478         Move IDB storage in private browsing mode to NetworkProcess
2479         https://bugs.webkit.org/show_bug.cgi?id=195602
2480
2481         Reviewed by Brady Eidson.
2482
2483         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2484         (TEST):
2485
2486 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2487
2488         [ews-build] Make descriptionDone messages more readable
2489         https://bugs.webkit.org/show_bug.cgi?id=195760
2490
2491         Reviewed by Lucas Forschler.
2492
2493         * BuildSlaveSupport/ews-build/steps.py:
2494         * BuildSlaveSupport/ews-build/steps_unittest.py:
2495
2496 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2497
2498         [ews-build] Generate status-bubble hover-over messages
2499         https://bugs.webkit.org/show_bug.cgi?id=195680
2500
2501         Reviewed by Lucas Forschler.
2502
2503         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2504         (StatusBubble):
2505         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2506         on hover-over.
2507         (StatusBubble._iso_time):
2508         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2509         hover-over message.
2510         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2511
2512 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2513
2514         [ews-app] Gracefully handle the case when state_string is None
2515         https://bugs.webkit.org/show_bug.cgi?id=195753
2516
2517         Reviewed by Lucas Forschler.
2518
2519         * BuildSlaveSupport/ews-app/ews/models/build.py:
2520         * BuildSlaveSupport/ews-app/ews/models/step.py:
2521
2522 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2523
2524         [ews-app] Status bubble display pending for currently running build step
2525         https://bugs.webkit.org/show_bug.cgi?id=195744
2526
2527         Reviewed by Lucas Forschler.
2528
2529         * BuildSlaveSupport/ews-build/events.py:
2530         (Events.stepStarted): If state_string is pending, replace it with step name.
2531
2532 2019-03-14  Chris Dumez  <cdumez@apple.com>
2533
2534         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2535         https://bugs.webkit.org/show_bug.cgi?id=195750
2536
2537         Reviewed by Geoffrey Garen.
2538
2539         Add API test coverage.
2540
2541         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2542         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2543         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2544         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2545
2546 2019-03-14  Chris Dumez  <cdumez@apple.com>
2547
2548         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2549         https://bugs.webkit.org/show_bug.cgi?id=195747
2550
2551         Reviewed by Geoff Garen.
2552
2553         Add API test coverage.
2554
2555         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2556
2557 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2558
2559         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2560         https://bugs.webkit.org/show_bug.cgi?id=195725
2561         <rdar://problem/48545062>
2562
2563         Reviewed by Tim Horton.
2564
2565         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2566         handler is nil.
2567
2568         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2569         (TestWebKitAPI::TEST):
2570
2571 2019-03-13  Sam Weinig  <sam@webkit.org>
2572
2573         Add utility function to allow easy reverse range-based iteration of a container
2574         https://bugs.webkit.org/show_bug.cgi?id=195542
2575
2576         Reviewed by Antti Koivisto.
2577
2578         * TestWebKitAPI/CMakeLists.txt:
2579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2580         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2581         (TestWebKitAPI::TEST):
2582         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2583
2584 2019-03-13  Chris Dumez  <cdumez@apple.com>
2585
2586         Use a ServiceWorker process per registrable domain
2587         https://bugs.webkit.org/show_bug.cgi?id=195649
2588
2589         Reviewed by Youenn Fablet.
2590
2591         Update API test coverage.
2592
2593         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2594
2595 2019-03-13  Chris Dumez  <cdumez@apple.com>
2596
2597         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2598         https://bugs.webkit.org/show_bug.cgi?id=195684
2599         <rdar://problem/48294714>
2600
2601         Reviewed by Antti Koivisto.
2602
2603         Add API test coverage.
2604
2605         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2606
2607 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2608
2609         [ews-app] Remove unused patch view
2610         https://bugs.webkit.org/show_bug.cgi?id=195669
2611
2612         Reviewed by Lucas Forschler.
2613
2614         * BuildSlaveSupport/ews-app/ews/urls.py:
2615         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2616
2617 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2618
2619         [ews-app] Use Buildbot result code variables
2620         https://bugs.webkit.org/show_bug.cgi?id=195668
2621
2622         Reviewed by Alexey Proskuryakov.
2623
2624         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2625         (Buildbot): Added Buildbot result code variables.
2626         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2627         (StatusBubble._build_bubble): Used Buildbot result code variables.
2628
2629 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2630
2631         [Flatpak] Expand submodule recursively
2632         https://bugs.webkit.org/show_bug.cgi?id=195672
2633
2634         Building WPE with flatpak was impossible without that as it was raising an exception.
2635         Also update wpebackend-fdo to match what is built in jhbuild
2636
2637         Reviewed by Philippe Normand.
2638
2639         * flatpak/flatpakutils.py:
2640         (expand_submodules_recurse):
2641         (expand_manifest):
2642         * flatpak/org.webkit.WPEModules.yaml:
2643
2644 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2645
2646         [ews-app] status bubble should be hidden for certain builds
2647         https://bugs.webkit.org/show_bug.cgi?id=194597
2648
2649         Reviewed by Dewei Zhu.
2650
2651         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2652         (StatusBubble._build_bubble):
2653         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2654         because the patch didn't have relevant changes.
2655         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2656         in production yet.
2657
2658 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2659
2660         [Win] Fix a slew of simple clang-cl warnings.
2661         https://bugs.webkit.org/show_bug.cgi?id=195652
2662
2663         Reviewed by Don Olmstead.
2664
2665         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2666         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2667
2668 2019-03-12  Justin Fan  <justin_fan@apple.com>
2669
2670         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2671         https://bugs.webkit.org/show_bug.cgi?id=195518
2672         <rdar://problem/46322356>
2673
2674         Reviewed by Myles C. Maxfield.
2675
2676         * DumpRenderTree/DerivedSources-input.xcfilelist:
2677         * DumpRenderTree/DerivedSources-output.xcfilelist:
2678
2679 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2680
2681         Unreviewed, rolling out r242825.
2682         https://bugs.webkit.org/show_bug.cgi?id=195648
2683
2684         "Broke webkitpy tests with my change to
2685         lldb_dump_class_layout.py" (Requested by rmorisset on
2686         #webkit).
2687
2688         Reverted changeset:
2689
2690         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2691         classes with suspicious padding"
2692         https://bugs.webkit.org/show_bug.cgi?id=195573
2693         https://trac.webkit.org/changeset/242825
2694
2695 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2696
2697         [ews-build] Show status bubbles while the patch is waiting in queue
2698         https://bugs.webkit.org/show_bug.cgi?id=195618
2699
2700         Reviewed by Lucas Forschler.
2701
2702         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2703         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2704         enabled in initial deployment.
2705         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2706         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2707         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2708         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2709         (StatusBubble._build_bubbles_for_patch):
2710
2711 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2712
2713         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2714         https://bugs.webkit.org/show_bug.cgi?id=195573
2715
2716         Reviewed by Simon Fraser.
2717
2718         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2719
2720         * Scripts/dump-class-layout:
2721         (main):
2722         * lldb/lldb_dump_class_layout.py:
2723         (ClassLayout.__init__):
2724         (ClassLayout._compute_padding_recursive):
2725         (LLDBDebuggerInstance.dump_layout_for_classname):
2726         (LLDBDebuggerInstance):
2727         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2728         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2729
2730 2019-03-12  Chris Dumez  <cdumez@apple.com>
2731
2732         Device Orientation access permission should be denied unless explicitly granted by the client
2733         https://bugs.webkit.org/show_bug.cgi?id=195625
2734
2735         Reviewed by Youenn Fablet.
2736
2737         add API test coverage.
2738
2739         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2740         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2741         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2742         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2743         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2744         (runDeviceOrientationTest):
2745         (TEST):
2746         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2747         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2748
2749 2019-03-12  Jer Noble  <jer.noble@apple.com>
2750
2751         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2752         https://bugs.webkit.org/show_bug.cgi?id=195137
2753         <rdar://problem/48810307>
2754
2755         Reviewed by Eric Carlson.
2756
2757         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2758         (TestWebKitAPI::TEST):
2759
2760 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2761
2762         [ews-build] Change urls from uat to production
2763         https://bugs.webkit.org/show_bug.cgi?id=195566
2764
2765         Reviewed by Lucas Forschler.
2766
2767         * BuildSlaveSupport/ews-app/ews/config.py:
2768         * BuildSlaveSupport/ews-build/events.py:
2769         * BuildSlaveSupport/ews-build/steps.py:
2770
2771 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2772
2773         [ews-build] change max_builds for local-worker to 1
2774         https://bugs.webkit.org/show_bug.cgi?id=195568
2775
2776         Reviewed by Lucas Forschler.
2777
2778         * BuildSlaveSupport/ews-build/loadConfig.py:
2779
2780 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2781
2782         Fix the build
2783
2784         * TestRunnerShared/spi/PencilKitTestSPI.h:
2785         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2786
2787 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2788
2789         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2790         https://bugs.webkit.org/show_bug.cgi?id=194131
2791
2792         Reviewed by Michael Catanzaro.
2793
2794         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2795         (uriChanged):
2796         (testUnfinishedSubresourceLoad):
2797         (serverCallback):
2798         (beforeAll):
2799
2800 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2801
2802         WTF::Expected should use std::addressof instead of operator&
2803         https://bugs.webkit.org/show_bug.cgi?id=195604
2804
2805         Reviewed by Myles Maxfield.
2806
2807         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2808         (TestWebKitAPI::Unique::Unique):
2809         (TestWebKitAPI::Unique::operator&):
2810         (TestWebKitAPI::TEST):
2811
2812 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2813
2814         Add Optional to Forward.h.
2815         https://bugs.webkit.org/show_bug.cgi?id=195586
2816
2817         Reviewed by Darin Adler.
2818
2819         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2820         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2821         Remove unnecessary includes from headers.
2822
2823 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2824
2825         Add testing API to hit-test and scroll overflow scrollers
2826         https://bugs.webkit.org/show_bug.cgi?id=195278
2827
2828         Reviewed by Antti Koivisto.
2829         
2830         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2831         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2832         
2833         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2834
2835         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2836         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2837         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2838         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2839         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2840         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2841         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2842         (WTR::enclosingScrollViewIncludingSelf):
2843         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2844
2845 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2846
2847         API test WebKit.RequestTextInputContext fails on iOS
2848         https://bugs.webkit.org/show_bug.cgi?id=195585
2849
2850         Reviewed by Wenson Hsieh and Simon Fraser.
2851
2852         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2853         (applyStyle):
2854         (TEST):
2855         Add a viewport, so that the coordinates match up on iOS.
2856         Scroll by moving the UIScrollView's contentOffset.
2857
2858 2019-03-11  Chris Dumez  <cdumez@apple.com>
2859
2860         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2861         https://bugs.webkit.org/show_bug.cgi?id=195506
2862         <rdar://problem/48733477>
2863
2864         Reviewed by Alex Christensen.
2865
2866         Add API test coverage.
2867
2868         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2869
2870 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2871
2872         Adding myself to contributors.json
2873
2874         Unreviewed, addming myself to contributors.json .
2875
2876         * Scripts/webkitpy/common/config/contributors.json:
2877
2878 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2879
2880         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2881         https://bugs.webkit.org/show_bug.cgi?id=195511
2882         <rdar://problem/44873269>
2883
2884         Reviewed by Darin Adler.
2885
2886         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2887         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2888         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2889         (TEST_F):
2890
2891 2019-03-11  Chris Dumez  <cdumez@apple.com>
2892
2893         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2894         https://bugs.webkit.org/show_bug.cgi?id=195561
2895
2896         Reviewed by Youenn Fablet.
2897
2898         Make sure the JS in the test requests for permission to receive device orientation events.
2899
2900         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2901
2902 2019-03-11  Youenn Fablet  <youenn@apple.com>
2903
2904         Allow storage quota increase by default in WTR
2905         https://bugs.webkit.org/show_bug.cgi?id=195541
2906
2907         Reviewed by Geoffrey Garen.
2908
2909         Allow storage quota increase by default in WTR.
2910         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2911         Use this for tests that explicitly need cache increase.
2912
2913         Instead of increasing quota by 2, make sure the next request is
2914         granted by adding all given parameters.
2915
2916         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2917         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2918         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2919         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2920         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2921         * WebKitTestRunner/TestController.cpp:
2922         (WTR::TestController::setAllowStorageQuotaIncrease):
2923         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2924         * WebKitTestRunner/TestController.h:
2925         * WebKitTestRunner/TestInvocation.cpp:
2926         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2927         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2928         (WTR::TestController::cocoaResetStateToConsistentValues):
2929         (WTR::TestController::setAllowStorageQuotaIncrease):
2930         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2931         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2932         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2933
2934 2019-03-11  Xan Lopez  <xan@igalia.com>
2935
2936         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2937         https://bugs.webkit.org/show_bug.cgi?id=194147
2938
2939         Reviewed by Michael Saboff.
2940
2941         To make --32-bit work correctly on Linux/64bit we need to:
2942
2943         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2944         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2945         unfortunately CMake only allows us to do this during
2946         crosscompilation, which is overkill here.
2947         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2948         pkg-config detection module uses the x86 .pc files instead of the
2949         x86_64 ones.
2950         - Set the -m32 flags for the compiler.
2951
2952         * Scripts/webkitdirs.pm:
2953         (generateBuildSystemFromCMakeProject):
2954
2955 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2956
2957         Add MotionMark-1.1 plan file for run-benchmark script.
2958         https://bugs.webkit.org/show_bug.cgi?id=195481
2959
2960         Rubber-stamped by Darin Adler.
2961
2962         Run-benchmark script should support MontionMark-1.1.
2963
2964         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2965
2966 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2967
2968         [ews-app] Add support for submit-to-ews url
2969         https://bugs.webkit.org/show_bug.cgi?id=195477
2970
2971         Reviewed by Lucas Forschler.
2972
2973         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2974         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2975         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2976         * BuildSlaveSupport/ews-app/ews/urls.py:
2977         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2978
2979 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2980
2981         Unreviewed, rolling out r242688, r242643, r242624.
2982
2983         Caused multiple layout test failures and crashes on iOS and macOS.
2984
2985         Reverted changeset:
2986
2987         "requestAnimationFrame should execute before the next frame"
2988         https://bugs.webkit.org/show_bug.cgi?id=177484
2989         https://trac.webkit.org/changeset/242624/webkit
2990
2991         * Tracing/SystemTracePoints.plist:
2992
2993 2019-03-11  John Wilander  <wilander@apple.com>
2994
2995         Resource Load Statistics: Make it possible exclude localhost from classification
2996         https://bugs.webkit.org/show_bug.cgi?id=195474
2997         <rdar://problem/47520577>
2998
2999         Reviewed by Brent Fulgham.
3000
3001         This patch allows for localhost to be excluded from classification and
3002         treatment as a prevalent resource.
3003
3004         The WebKit Tools change adds a new function called
3005         testRunner.setStatisticsIsRunningTest() which can be used to control this
3006         behavior.
3007
3008         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3009         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3010         (WTR::TestRunner::setStatisticsIsRunningTest):
3011         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3012         * WebKitTestRunner/TestController.cpp:
3013         (WTR::TestController::setStatisticsIsRunningTest):
3014         * WebKitTestRunner/TestController.h:
3015         * WebKitTestRunner/TestInvocation.cpp:
3016         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3017
3018 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3019
3020         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3021         https://bugs.webkit.org/show_bug.cgi?id=195560
3022
3023         Reviewed by Lucas Forschler.
3024
3025         * BuildSlaveSupport/ews-build/master.cfg:
3026
3027 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3028
3029         Unreviewed, rolling out r242698.
3030
3031         API test crashes on bots.
3032
3033         Reverted changeset:
3034
3035         "Add a WKContentRuleList variant that uses copied memory
3036         instead of mmap'd shared memory for class A containerized
3037         apps"
3038         https://bugs.webkit.org/show_bug.cgi?id=195511
3039         https://trac.webkit.org/changeset/242698
3040
3041 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3042
3043         [WPE] Enable web process sandbox
3044         https://bugs.webkit.org/show_bug.cgi?id=195169
3045
3046         Reviewed by Daniel Bates.
3047
3048         * wpe/install-dependencies:
3049         * wpe/jhbuild.modules:
3050
3051 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3052
3053         [ews-app] Use port 17000 for worker communication
3054         https://bugs.webkit.org/show_bug.cgi?id=195558
3055
3056         Reviewed by Lucas Forschler.
3057
3058         * BuildSlaveSupport/ews-build/master.cfg:
3059
3060 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3061
3062         [ews-build] unit-tests fail when passwords.json is missing
3063         https://bugs.webkit.org/show_bug.cgi?id=195557
3064
3065         Reviewed by Lucas Forschler.
3066
3067         * BuildSlaveSupport/ews-build/loadConfig.py:
3068         (loadBuilderConfig):
3069         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3070         (ConfigDotJSONTest.test_configuration):
3071         * BuildSlaveSupport/ews-build/master.cfg:
3072
3073 2019-03-11  Truitt Savell  <tsavell@apple.com>
3074
3075         Unreviewed, rolling out r242702.
3076
3077         Broke High Sierra builders.
3078
3079         Reverted changeset:
3080
3081         "Add utility function to allow easy reverse range-based
3082         iteration of a container"
3083         https://bugs.webkit.org/show_bug.cgi?id=195542
3084         https://trac.webkit.org/changeset/242702
3085
3086 2019-03-11  Sam Weinig  <sam@webkit.org>
3087
3088         Add utility function to allow easy reverse range-based iteration of a container
3089         https://bugs.webkit.org/show_bug.cgi?id=195542
3090
3091         Reviewed by Antti Koivisto.
3092
3093         * TestWebKitAPI/CMakeLists.txt:
3094         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3095         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3096         (TestWebKitAPI::TEST):
3097         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3098
3099 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3100
3101         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3102         https://bugs.webkit.org/show_bug.cgi?id=195511
3103         <rdar://problem/44873269>
3104
3105         Reviewed by Darin Adler.
3106
3107         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3108         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3109         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3110         (TEST_F):
3111
3112 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3113
3114         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3115         https://bugs.webkit.org/show_bug.cgi?id=195499
3116
3117         Reviewed by Darin Adler.
3118
3119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3120         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3121         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3122         (-[WKWebView synchronouslyFocusTextInputContext:]):
3123         (applyStyle):
3124         (applyIframe):
3125         (TEST):
3126         Add some tests for this SPI.
3127
3128 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3129
3130         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3131         https://bugs.webkit.org/show_bug.cgi?id=181151
3132
3133         Reviewed by Don Olmstead.
3134
3135         * TestWebKitAPI/CMakeLists.txt:
3136         * TestWebKitAPI/PlatformWin.cmake:
3137         Enable TestWTF RunLoop tests in all platforms.
3138
3139         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3140         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3141         (TestWebKitAPI::DerivedOneShotTimer::fired):
3142         (TestWebKitAPI::TEST):
3143         Only a few platforms support nested RunLoop.
3144
3145         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3146         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3147
3148 2019-03-10  David Quesada  <david_quesada@apple.com>
3149
3150         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3151         https://bugs.webkit.org/show_bug.cgi?id=152480
3152
3153         Reviewed by Chris Dumez.
3154
3155         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3156         there are no additional references to the process pool besides the one held by
3157         the download, waits for the download to finish (in the sense that the
3158         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3159         measure, also check that the process pool has been deallocated at the end of the
3160         test. The test wouldn't be meaningful if the process pool were still alive.
3161
3162         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3163         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3164         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3165             The download will be canceled because the delegate does not implement the
3166             method to decide the download's destination, so this is where we know the
3167             DownloadProxyMap is done with the DownloadProxy.
3168         (TEST):
3169
3170 2019-03-08  Chris Dumez  <cdumez@apple.com>
3171
3172         Add support for Device Orientation / Motion permission API
3173         https://bugs.webkit.org/show_bug.cgi?id=195329
3174         <rdar://problem/47645367>
3175
3176         Reviewed by Geoffrey Garen.
3177
3178         Add test infrastructure to help test the Device Orientation / Motion permission API.
3179
3180         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3181         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3182         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3183         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3184         * WebKitTestRunner/TestController.cpp:
3185         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3186         (WTR::TestController::createWebViewWithOptions):
3187         (WTR::TestController::resetStateToConsistentValues):
3188         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3189         * WebKitTestRunner/TestController.h:
3190         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3191         * WebKitTestRunner/TestInvocation.cpp:
3192         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3193
3194 2019-03-08  Saam barati  <sbarati@apple.com>
3195
3196         Add a compare-results script to compare benchmark results
3197         https://bugs.webkit.org/show_bug.cgi?id=195486
3198         <rdar://problem/48723397>
3199
3200         Reviewed by Geoffrey Garen.
3201
3202         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3203         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3204         to extend it to learn about our other benchmarks.
3205
3206         * Scripts/compare-results: Added.
3207         (readJSONFile):
3208         (detectJetStream2):
3209         (JetStream2Results):
3210         (detectSpeedometer2):
3211         (Speedometer2Results):
3212         (detectPLT5):
3213         (PLT5Results):
3214         (detectBenchmark):
3215         (biggerIsBetter):
3216         (ttest):
3217         (getOptions):
3218         (main):
3219
3220 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3221
3222         Ensure old tab state is cleared between iterations of run-benchmark
3223         https://bugs.webkit.org/show_bug.cgi?id=195393
3224         <rdar://problem/46885583>
3225
3226         Reviewed by Dewei Zhu.
3227
3228         a) ensure the default to restore state is not set
3229         b) terminate Safari correctly
3230         c) Set the system default to ignore Persistent State in Safari
3231
3232         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3233         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3234         (OSXBrowserDriver.prepare_env): 
3235         (OSXBrowserDriver.restore_env):
3236         (OSXBrowserDriver.close_browsers):
3237         (OSXBrowserDriver._terminate_processes):
3238         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3239         (OSXChromeDriver):
3240         (OSXChromeCanaryDriver):
3241         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3242         (OSXFirefoxDriver):
3243         (OSXFirefoxNightlyDriver):
3244         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3245         (OSXSafariDriver):
3246         (OSXSafariDriver.prepare_env):
3247
3248 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3249
3250         [GTK] Several InputMethodFilter tests are failing
3251         https://bugs.webkit.org/show_bug.cgi?id=195408
3252
3253         Reviewed by Carlos Garcia Campos.
3254
3255         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3256         Regressed in r241751.
3257         Hexadecimal values of keycodes are expressed now in upper letters.
3258         Composited characters should be cast to UTF8 strings.
3259
3260         (TestWebKitAPI::TEST):
3261
3262 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3263
3264         [GTK] Make Tools/gtkdoc python3 compatible
3265         https://bugs.webkit.org/show_bug.cgi?id=195359
3266
3267         Reviewed by Carlos Garcia Campos.
3268
3269         * gtkdoc/generate-gtkdoc:
3270         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3271         work with Python 2 and 3.
3272         (get_gtkdoc_module_paths):
3273         The iteritems() was removed in Python 3, so let's use items() that's
3274         available in Python 2 and 3.
3275         (get_generator_for_config):
3276         * gtkdoc/gtkdoc.py:
3277         (GTKDoc._run_command):
3278         The sys.stdout.write() is expecting str in Python 3 and not bytes
3279         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3280         for passing the bytes there.
3281
3282 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3283
3284         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3285         https://bugs.webkit.org/show_bug.cgi?id=195346
3286         <rdar://problem/48667048>
3287
3288         Unreviewed build fix for clang-cl.
3289
3290         * DumpRenderTree/win/DumpRenderTree.cpp:
3291         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3292
3293 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3294
3295         requestAnimationFrame should execute before the next frame
3296         https://bugs.webkit.org/show_bug.cgi?id=177484
3297
3298         Reviewed by Simon Fraser.
3299
3300         Add trace points for the page RenderingUpdate.
3301
3302         * Tracing/SystemTracePoints.plist:
3303
3304 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3305
3306         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3307         https://bugs.webkit.org/show_bug.cgi?id=195353
3308         <rdar://problem/48626394>
3309
3310         Reviewed by Simon Fraser.
3311
3312         * WebKitTestRunner/ios/TestControllerIOS.mm:
3313         (WTR::TestController::platformResetPreferencesToConsistentValues):
3314
3315 2019-03-07  John Wilander  <wilander@apple.com>
3316
3317         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3318         https://bugs.webkit.org/show_bug.cgi?id=195383
3319         <rdar://problem/48570136>
3320
3321         Reviewed by Brent Fulgham.
3322
3323         This patch adds test infrastructure to purge only script-accessible cookies,
3324         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3325
3326         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3327         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3328         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3329         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3330         * WebKitTestRunner/TestController.cpp:
3331         (WTR::TestController::statisticsDeleteCookiesForHost):
3332         * WebKitTestRunner/TestController.h:
3333         * WebKitTestRunner/TestInvocation.cpp:
3334         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3335
3336 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3337
3338         Unreviewed, rolling out r242354.
3339         https://bugs.webkit.org/show_bug.cgi?id=195402
3340
3341         breaks layout tests in all configurations (Requested by
3342         zdobersek on #webkit).
3343
3344         Reverted changeset:
3345
3346         "[WPE] Enable web process sandbox"
3347         https://bugs.webkit.org/show_bug.cgi?id=195169
3348         https://trac.webkit.org/changeset/242354
3349
3350 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3351
3352         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3353         https://bugs.webkit.org/show_bug.cgi?id=195346
3354
3355         Reviewed by Fujii Hironori.
3356
3357         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3358         (TestWebKitAPI::TEST):
3359         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3360
3361         * DumpRenderTree/win/DumpRenderTree.cpp:
3362         (findFontFallback):
3363         (addFontFallbackIfPresent):
3364         (removeFontFallbackIfPresent):
3365         (main):
3366         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3367         (TestWebKitAPI::Util::moduleDirectory):
3368         (TestWebKitAPI::Util::createInjectedBundlePath):
3369         Use wchar helpers as needed.
3370
3371 2019-03-06  Rob Buis  <rbuis@igalia.com>
3372
3373         Consider supporting the `referrerpolicy` attribute.
3374         https://bugs.webkit.org/show_bug.cgi?id=179053
3375
3376         Reviewed by Darin Adler.
3377
3378         Add a runtime flag for referrerpolicy attribute.
3379
3380         * DumpRenderTree/mac/DumpRenderTree.mm:
3381         (enableExperimentalFeatures):
3382
3383 2019-03-05  Daniel Bates  <dabates@apple.com>
3384
3385         Update expected API test result following r242379
3386         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3387
3388         Update expected x-coordinate of selection rect now that the left padding of
3389         a textarea is sized in ems (so dependent on the font size) just like the left
3390         padding of a text field.
3391
3392         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3393         (TestWebKitAPI::TEST):
3394
3395 2019-03-05  David Quesada  <david_quesada@apple.com>
3396
3397         [WK2] It should be possible to follow links with 'download' attributes
3398         https://bugs.webkit.org/show_bug.cgi?id=195145
3399         rdar://problem/48462642
3400
3401         Reviewed by Alex Christensen.
3402
3403         Add a unit test to verify that activating links with 'download' attributes now
3404         navigates to the linked resource, rather than starts downloading it. Add another
3405         to verify that it is still possible to explicitly download the link via the
3406         'Download' navigation action policy.
3407
3408         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3409         (-[DownloadAttributeTestDelegate init]):
3410         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3411         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3412         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3413         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3414         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3415         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3416         (TEST):
3417         * WebKitTestRunner/TestController.cpp:
3418         (WTR::TestController::decidePolicyForNavigationAction):
3419         * WebKitTestRunner/TestController.h:
3420
3421 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3422
3423         [Curl] Implement Cookie Accept Policy.
3424         https://bugs.webkit.org/show_bug.cgi?id=191645
3425
3426         Reviewed by Fujii Hironori.
3427
3428         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3429         (TestWebKitAPI::Curl::TEST_F):
3430
3431 2019-03-05  Youenn Fablet  <youenn@apple.com>
3432
3433         Rename requestCacheStorageSpace to requestStorageSpace
3434         https://bugs.webkit.org/show_bug.cgi?id=195282
3435
3436         Reviewed by Chris Dumez.
3437
3438         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3439         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3440         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3441
3442 2019-03-05  Brady Eidson  <beidson@apple.com>
3443
3444         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3445         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3446
3447         Reviewed by Tim Horton.
3448
3449         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3450         different directory into that same WKWebView should work.
3451
3452         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3453         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3454
3455 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3456
3457         Add WeakHashSet
3458         https://bugs.webkit.org/show_bug.cgi?id=195152
3459
3460         Reviewed by Antti Koivisto.
3461
3462         Added tests for WeakHashSet.
3463
3464         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3465         (TestWebKitAPI::Base::Base): Moved.
3466         (TestWebKitAPI::Derived::foo): Moved.
3467         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3468         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3469         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3470         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3471
3472 2019-03-04  Chris Dumez  <cdumez@apple.com>
3473
3474         Do not share WebProcesses between private and regular sessions
3475         https://bugs.webkit.org/show_bug.cgi?id=195189
3476         <rdar://problem/48421064>
3477
3478         Reviewed by Alex Christensen.
3479
3480         Add API test coverage.
3481
3482         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3483         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3484
3485 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3486
3487         [WPE] Enable web process sandbox
3488         https://bugs.webkit.org/show_bug.cgi?id=195169
3489
3490         Reviewed by Daniel Bates.
3491
3492         * wpe/install-dependencies:
3493         * wpe/jhbuild.modules:
3494
3495 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3496
3497         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3498         https://bugs.webkit.org/show_bug.cgi?id=195206
3499
3500         Reviewed by Žan Doberšek.
3501
3502         Add a new test case.
3503
3504         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3505         (testJSCClass):
3506
3507 2019-03-04  Charlie Turner  <cturner@igalia.com>
3508
3509         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3510         https://bugs.webkit.org/show_bug.cgi?id=194898
3511
3512         Reviewed by Žan Doberšek.
3513
3514         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3515         a GCC extension that permits arithmetic on void* pointer. Inline
3516         the macro until this issue is fixed upstream.
3517
3518 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3519
3520         Rid the world of WK_API_ENABLED
3521         https://bugs.webkit.org/show_bug.cgi?id=195263
3522
3523         Reviewed by Dan Bernstein.
3524
3525         List of changed files elided because it's useless.
3526
3527 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3528
3529         Unreviewed follow-up to r242292.
3530
3531         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3532
3533         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3534         (TestWebKitAPI::testStrip): Renamed from strip.
3535         (TestWebKitAPI::TEST):
3536
3537 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3538
3539         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3540
3541         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3542         and bug #194272 for details.
3543
3544         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3545
3546 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3547
3548         Remove some more unused 32-bit code
3549         https://bugs.webkit.org/show_bug.cgi?id=195255
3550
3551         Reviewed by Darin Adler.
3552
3553         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3554         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3555         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3556         (NPP_New):
3557         (NPP_HandleEvent):
3558         (handleEventCarbon): Deleted.
3559
3560 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3561
3562         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3563
3564         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3565         (TestWebKitAPI::TEST):
3566
3567 2019-03-01  Darin Adler  <darin@apple.com>
3568
3569         Finish removing String::format
3570         https://bugs.webkit.org/show_bug.cgi?id=194893
3571
3572         Reviewed by Daniel Bates.
3573 '
3574         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3575
3576 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3577
3578         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3579         https://bugs.webkit.org/show_bug.cgi?id=195229
3580         <rdar://problem/48520362>
3581
3582         Reviewed by Chris Dumez.
3583
3584         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3585         (TEST):
3586
3587 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3588
3589         Add a system trace scope for event region building
3590         https://bugs.webkit.org/show_bug.cgi?id=195226
3591
3592         Reviewed by Jon Lee.
3593
3594         This trace scope measures the time spend converting element rects into Region objects,
3595         which can be large on some pages.
3596
3597         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3598
3599         * Tracing/SystemTracePoints.plist:
3600
3601 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3602
3603         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3604         https://bugs.webkit.org/show_bug.cgi?id=194612
3605
3606         Reviewed by Alex Christensen.
3607
3608         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3609         Just test the new string-processing function and don't touch the actual environment.
3610         (Test cases are all as before, but based on operator== instead of strcmp.)
3611
3612 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3613
3614         [ews-app] Update primary keys for handling multiple Buildbot instances
3615         https://bugs.webkit.org/show_bug.cgi?id=195120
3616
3617         Reviewed by Stephanie Lewis.
3618
3619         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3620         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3621         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3622
3623         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3624         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3625         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3626         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3627         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3628         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3629
3630 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3631
3632         [WinCairo] Enable service worker
3633         https://bugs.webkit.org/show_bug.cgi?id=188318
3634
3635         Reviewed by Youenn Fablet.
3636
3637         * DumpRenderTree/DumpRenderTreePrefix.h:
3638         * TestWebKitAPI/PlatformWin.cmake:
3639         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3640         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3641         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3642
3643 2019-03-01  Justin Fan  <justin_fan@apple.com>
3644
3645         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3646         https://bugs.webkit.org/show_bug.cgi?id=195191
3647
3648         Rubber-stamped by Dean Jackson.
3649
3650         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3651
3652         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3653
3654 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3655
3656         Unreviewed, fix lldb webkitpy tests
3657         https://bugs.webkit.org/show_bug.cgi?id=194375
3658
3659         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3660
3661         * lldb/lldb_webkit.py:
3662         (WTFStringImplProvider.is_8bit):
3663
3664 2019-02-28  David Quesada  <david_quesada@apple.com>
3665
3666         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3667         https://bugs.webkit.org/show_bug.cgi?id=195121
3668         rdar://problem/48450302
3669
3670         Reviewed by Alex Christensen.
3671
3672         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3673         configurations where the 'download' attribute is absent, blank, or populated
3674         with a filename, and where the anchor element is same-origin or cross-origin
3675         (meaning the 'download' attribute shouldn't be honored).
3676
3677         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3678         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3679         (-[NavigationActionTestDelegate init]):
3680         (-[NavigationActionTestDelegate navigationAction]):
3681         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3682         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3683         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3684         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3685         (TEST):
3686
3687 2019-02-28  Antoine Quint  <graouts@apple.com>
3688
3689         Enable the Pointer Events runtime flag by default
3690         https://bugs.webkit.org/show_bug.cgi?id=195156
3691
3692         Reviewed by Dean Jackson.
3693
3694         * DumpRenderTree/mac/DumpRenderTree.mm:
3695         (enableExperimentalFeatures):
3696
3697 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3698
3699         Several PasteImage API tests are flaky
3700         https://bugs.webkit.org/show_bug.cgi?id=195160
3701
3702         Reviewed by Tim Horton.
3703
3704         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3705         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3706         listening for a "load" event after image load is already complete.
3707
3708         To address this, make these tests first register a "load" event handler, then run script to insert an image
3709         element into the document, and finally wait until the load event is observed before checking image size.
3710
3711         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3712
3713 2019-02-28  Chris Dumez  <cdumez@apple.com>
3714
3715         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3716         https://bugs.webkit.org/show_bug.cgi?id=195107
3717
3718         Reviewed by Alex Christensen.
3719
3720         Give some time for the zoom level to get restored.
3721
3722         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3723
3724 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3725
3726         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3727         https://bugs.webkit.org/show_bug.cgi?id=194958
3728
3729         Reviewed by Geoffrey Garen.
3730
3731         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3732         (TEST):
3733
3734 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3735
3736         [ews-app] Update method to save build to handle builder_display_name
3737         https://bugs.webkit.org/show_bug.cgi?id=195047
3738
3739         Reviewed by Dewei Zhu.
3740
3741         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3742         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3743
3744 2019-02-28  Justin Fan  <justin_fan@apple.com>
3745
3746         [Web GPU] Enable Web GPU only on 64-bit
3747         https://bugs.webkit.org/show_bug.cgi?id=195139
3748
3749         Because Metal is only supported on 64 bit apps.
3750
3751         Unreviewed build fix.
3752
3753         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3754
3755 2019-02-27  Youenn Fablet  <youenn@apple.com>
3756
3757         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3758         https://bugs.webkit.org/show_bug.cgi?id=194959
3759
3760         Reviewed by Chris Dumez.
3761
3762         Spin loop until getting the condition to remove flakiness.
3763
3764         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3765
3766 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3767
3768         [ews-build] Buildbot should include builder_display_name in the build events
3769         https://bugs.webkit.org/show_bug.cgi?id=195045
3770
3771         Reviewed by Dewei Zhu.
3772
3773         * BuildSlaveSupport/ews-build/events.py:
3774         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3775         buildername to builder_name to be consistent in naming style.
3776         (Events.buildFinished): Ditto.
3777
3778 2019-02-27  Chris Dumez  <cdumez@apple.com>
3779
3780         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3781         https://bugs.webkit.org/show_bug.cgi?id=194480
3782
3783         Reviewed by Brady Eidson.
3784
3785         Update existing API test to make it more likely to reproduce the issue.
3786
3787         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3788
3789 2019-02-27  Brady Eidson  <beidson@apple.com>
3790
3791         Universal links from Google search results pages don't open the app.
3792         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3793
3794         Reviewed by Geoffrey Garen.
3795
3796         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3797         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3798         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3799         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3800
3801 2019-02-27  Chris Dumez  <cdumez@apple.com>
3802
3803         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3804         https://bugs.webkit.org/show_bug.cgi?id=195102
3805
3806         Reviewed by Geoffrey Garen.
3807
3808         If the number of processes is not yet what we expect, wait a bit and check again to give
3809         processes some time to exit.
3810
3811         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3812
3813 2019-02-27  Chris Dumez  <cdumez@apple.com>
3814
3815         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3816         https://bugs.webkit.org/show_bug.cgi?id=194545
3817
3818         Reviewed by Brady Eidson.
3819
3820         Make sure the test navigates forward and then back only once. Previously, navigating
3821         back would trigger a navigation again in a timer.
3822
3823         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3824
3825 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3826
3827         High Sierra Debug JSC test queue should use faster hardware
3828         https://bugs.webkit.org/show_bug.cgi?id=194603
3829
3830         Rubber-stamped by Alexey Proskuryakov.
3831
3832         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3833
3834         * BuildSlaveSupport/build.webkit.org-config/config.json:
3835         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3836         (BubbleQueueServer):
3837         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3838         (WebKitBuildbot):
3839         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3840         * QueueStatusServer/config/queues.py:
3841         * Scripts/webkitpy/common/config/ews.json:
3842         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3843         (test_ews_name):
3844
3845 2019-02-27  John Wilander  <wilander@apple.com>
3846
3847         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3848         https://bugs.webkit.org/show_bug.cgi?id=195071
3849         <rdar://problem/48417690>
3850
3851         Reviewed by Alex Christensen and Brent Fulgham.
3852
3853         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3854         (TestWebKitAPI::createURL):
3855             Convenience function.
3856         (TestWebKitAPI::TEST):
3857             WebCore::AdClickAttribution now takes a URL when creating Source and
3858             Destination.
3859         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3860         (TestWebKitAPI::TEST):
3861             WebCore::AdClickAttribution now takes a URL when creating Source and
3862             Destination.
3863
3864 2019-02-27  Antoine Quint  <graouts@apple.com>
3865
3866         Support Pointer Events on macOS
3867         https://bugs.webkit.org/show_bug.cgi?id=195008
3868         <rdar://problem/47454419>
3869
3870         Reviewed by Dean Jackson.
3871
3872         * DumpRenderTree/mac/DumpRenderTree.mm:
3873         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3874         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3875
3876 2019-02-26  Mark Lam  <mark.lam@apple.com>
3877
3878         Remove remaining poisoning code.
3879         https://bugs.webkit.org/show_bug.cgi?id=194138
3880
3881         Reviewed by Saam Barati.
3882
3883         * TestWebKitAPI/CMakeLists.txt:
3884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3885         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3886         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3887         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3888         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3889         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3890         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3891
3892 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3893
3894         Move ephemeral local storage from WebProcess to UIProcess
3895         https://bugs.webkit.org/show_bug.cgi?id=195074
3896         <rdar://problem/47937975>
3897
3898         Reviewed by Geoff Garen.
3899
3900         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3901
3902 2019-02-20  Jer Noble  <jer.noble@apple.com>
3903
3904         [Cocoa] Media elements will restart network buffering just before suspending
3905         https://bugs.webkit.org/show_bug.cgi?id=193691
3906
3907         Reviewed by Eric Carlson.
3908
3909         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3910         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3911         (TEST):
3912
3913 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3914
3915         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3916         https://bugs.webkit.org/show_bug.cgi?id=191652
3917
3918         Reviewed by Alex Christensen.
3919
3920         Fix WinCairo MiniBrowser behavior of authentication dialog.
3921
3922         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3923         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3924
3925 2019-02-26  Youenn Fablet  <youenn@apple.com>
3926
3927         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3928         https://bugs.webkit.org/show_bug.cgi?id=195028
3929         <rdar://problem/48243733>
3930
3931         Reviewed by Eric Carlson.
3932
3933         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3934
3935 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3936
3937         [WPE] Add API for webview background color configuration
3938         https://bugs.webkit.org/show_bug.cgi?id=192305
3939
3940         Reviewed by Michael Catanzaro.
3941
3942         * MiniBrowser/wpe/main.cpp:
3943         (main): Add a new option to configure the webview background
3944         color. Example: --bg-color=transparent.
3945         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3946         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3947         (beforeAll): Ditto.
3948
3949 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3950
3951         scalableNativeWebpageParameters() is not preserved on new page navigation.
3952         https://bugs.webkit.org/show_bug.cgi?id=194892
3953         <rdar://problem/47538280>
3954
3955         Reviewed by Wenson Hsieh.
3956         
3957         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3958
3959         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3960         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3961         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3962         (WTR::UIScriptController::allowsViewportShrinkToFit):
3963         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3964         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3965         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3966         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3967         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3968         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3969
3970 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3971
3972         [ews-app] Add model for handling multiple Buildbot instances
3973         https://bugs.webkit.org/show_bug.cgi?id=194863
3974
3975         Reviewed by Stephanie Lewis.
3976
3977         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3978
3979 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3980
3981         [ews-app] Remove BuilderMapping table
3982         https://bugs.webkit.org/show_bug.cgi?id=194961
3983
3984         Reviewed by Stephanie Lewis.
3985
3986         Store builder name directly in build table, instead of having a separate
3987         table for it.
3988
3989         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3990         * BuildSlaveSupport/ews-app/ews/models/build.py:
3991         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3992         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3993
3994 2019-02-25  John Wilander  <wilander@apple.com>
3995
3996         Introduce and adopt new class RegistrableDomain for eTLD+1
3997         https://bugs.webkit.org/show_bug.cgi?id=194791
3998         <rdar://problem/48179240>
3999
4000         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4001
4002         This patch adds an API test and replaces two instances of
4003         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4004
4005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4006         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4007         (TestWebKitAPI::TEST):
4008             Changed two strings to make sure the registrable domains are still considered
4009             invalid and pass the test.
4010         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4011         (TestWebKitAPI::TEST):
4012         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4013         (WTR::InjectedBundle::didReceiveMessageToPage):
4014
4015 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4016
4017         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4018         https://bugs.webkit.org/show_bug.cgi?id=195001
4019
4020         Reviewed by Carlos Garcia Campos.
4021
4022         API version 1.0 always includes the functionality previously guarded with
4023         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4024         unconditionally.
4025
4026         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4027         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4028         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4029         (WebViewTest::showInWindow): Ditto.
4030         (WebViewTest::hideView): Ditto.
4031         * wpe/backends/HeadlessViewBackend.cpp:
4032         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4033         * wpe/backends/ViewBackend.cpp:
4034         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4035         * wpe/backends/WindowViewBackend.cpp:
4036         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4037         WPE_BACKEND_CHECK_VERSION().
4038         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4039
4040 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4041
4042         [Flatpak] Add support for flatpak > 1.1.2
4043         https://bugs.webkit.org/show_bug.cgi?id=194088
4044
4045         Flatpak 1.2 is now out so we need to support that
4046         version now.
4047
4048         Reviewed by Michael Catanzaro.
4049
4050         * flatpak/flatpakutils.py:
4051         (check_flatpak):
4052         (FlatpakPackages.__init__):
4053         (FlatpakPackages.__detect_packages):
4054         (FlatpakPackages.__detect_packages.in):
4055         (FlatpakRepos.update):
4056
4057 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4058
4059         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4060         https://bugs.webkit.org/show_bug.cgi?id=194998
4061
4062         Reviewed by Carlos Garcia Campos.
4063
4064         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4065         to a Git checkout and using the latest commit containing various fixes
4066         and improvements.
4067
4068 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4069
4070         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4071         https://bugs.webkit.org/show_bug.cgi?id=194981
4072
4073         Reviewed by Žan Doberšek.
4074
4075         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4076         (TestWebKitAPI::TEST):
4077
4078 2019-02-23  Keith Miller  <keith_miller@apple.com>
4079
4080         Add new mac target numbers
4081         https://bugs.webkit.org/show_bug.cgi?id=194955
4082
4083         Reviewed by Tim Horton.
4084
4085         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4086         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4087         * MiniBrowser/Configurations/Base.xcconfig:
4088         * TestWebKitAPI/Configurations/Base.xcconfig:
4089         * WebKitTestRunner/Configurations/Base.xcconfig:
4090
4091 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4092
4093         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4094         https://bugs.webkit.org/show_bug.cgi?id=194846
4095
4096         Reviewed by Don Olmstead.
4097
4098         Added _search_paths() and _port_specific_expectations_files() for
4099         WinCairoPort.
4100
4101         * Scripts/webkitpy/port/win.py:
4102         (WinCairoPort.default_baseline_search_path):
4103         (WinCairoPort):
4104         (WinCairoPort._port_specific_expectations_files):
4105         (WinCairoPort._search_paths):
4106
4107 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4108
4109         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4110         https://bugs.webkit.org/show_bug.cgi?id=194963
4111
4112         Reviewed by Dean Jackson.
4113
4114         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4115         Do a `contains` check instead of `equals`, because in debug builds we
4116         put the GraphicsLayer pointer in a prefix.
4117
4118 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4119
4120         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4121         https://bugs.webkit.org/show_bug.cgi?id=194873
4122         <rdar://problem/46701974>
4123
4124         Reviewed by Tim Horton.
4125
4126         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4127
4128         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4129         (WTR::UIScriptController::menuRect const):
4130         (WTR::UIScriptController::isShowingMenu const):
4131         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4132         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4133         (WTR::UIScriptController::menuRect const):
4134
4135         Add a function to query the bounds of the callout menu in content coordinates.
4136
4137         (WTR::UIScriptController::isShowingMenu const):
4138
4139         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4140
4141         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4142         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4143         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4144         (WTR::UIScriptController::rectForMenuAction const):
4145         (WTR::UIScriptController::menuRect const):
4146         (WTR::UIScriptController::isShowingMenu const):
4147         (WTR::findViewInHierarchyOfType): Deleted.
4148
4149 2019-02-22  Chris Dumez  <cdumez@apple.com>
4150
4151         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4152         https://bugs.webkit.org/show_bug.cgi?id=194954
4153         <rdar://problem/48127957>
4154
4155         Reviewed by Alex Christensen.
4156
4157         Add API test coverage.
4158
4159         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4160         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4161         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4162         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4163
4164 2019-02-22  Chris Dumez  <cdumez@apple.com>
4165
4166         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4167         https://bugs.webkit.org/show_bug.cgi?id=194924
4168         <rdar://problem/48216125>
4169
4170         Reviewed by Geoffrey Garen.
4171
4172         Add API test coverage.
4173
4174         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4175
4176 2019-02-22  Chris Dumez  <cdumez@apple.com>
4177
4178         Unreviewed, disable API test added in r241928 on iOS.
4179
4180         The cache is not enabled on devices with less than 3GB of RAM.
4181
4182         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4183
4184 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4185
4186         Hardcode Visual Viewports on everywhere except iOS WK1
4187         https://bugs.webkit.org/show_bug.cgi?id=194928
4188
4189         Reviewed by Zalan Bujtas.
4190
4191         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4192         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4193         set it to false. The setting has shipped for several years and there's no need to turn
4194         it off now.
4195
4196         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4197         Visual Viewports are not enabled.
4198         
4199         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4200         that only runs in WK2
4201
4202         * MiniBrowser/mac/SettingsController.h:
4203         * MiniBrowser/mac/SettingsController.m:
4204         (-[SettingsController init]):
4205         (-[SettingsController _populateMenu]):
4206         (-[SettingsController validateMenuItem:]):
4207         (-[SettingsController visualViewportEnabled]): Deleted.
4208         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4209         * MiniBrowser/mac/WK1BrowserWindowController.m:
4210         (-[WK1BrowserWindowController didChangeSettings]):
4211         * MiniBrowser/mac/WK2BrowserWindowController.m:
4212         (-[WK2BrowserWindowController didChangeSettings]):
4213
4214 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4215
4216         Discard cached processes when clearing website data store
4217         https://bugs.webkit.org/show_bug.cgi?id=194894
4218
4219         Reviewed by Chris Dumez.
4220
4221         Added a test case.
4222
4223         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4224         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4225
4226 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4227
4228         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4229         https://bugs.webkit.org/show_bug.cgi?id=194914
4230         <rdar://problem/47586889>
4231
4232         Reviewed by Geoffrey Garen.
4233
4234         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4235         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4236         (TEST):
4237         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4238
4239 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4240
4241         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4242         <https://webkit.org/b/194761>
4243
4244         Reviewed by Myles Maxfield.
4245
4246         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4247         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4248         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4249         to use ARC-compliant cast.
4250         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4251         ARC-compliant cast.
4252         (WTR::installFakeHelvetica): Log `error` to console if
4253         CTFontManagerRegisterFontsForURL() fails, but only on supported
4254         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4255         Call CFRelease() on `error` to fix the leak.  Update to use
4256         ARC-compliant cast.
4257         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4258         cast.
4259
4260 2019-02-21  Chris Dumez  <cdumez@apple.com>
4261
4262         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4263         https://bugs.webkit.org/show_bug.cgi?id=194481
4264
4265         Reviewed by Alex Christensen.
4266
4267         Give the processes a chance to shutdown and wait until we reached the expected number
4268         of processes.
4269
4270         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4271
4272 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4273
4274         Fix the macOS build
4275
4276         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4277
4278 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4279
4280         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4281
4282         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4283         I am a backwards.
4284
4285 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4286
4287         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4288
4289         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4290         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4291         We could force on UI-side compositing, but I feel like the test might be more
4292         valuable exercising the normal path on each platform (though the original
4293         bug was also UI-side specific). Though we can't validate that the overlay
4294         layer was installed successfully, there are layout tests that do that.
4295
4296 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4297
4298         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4299         https://bugs.webkit.org/show_bug.cgi?id=194845
4300         <rdar://problem/47944579>
4301
4302         Reviewed by Antti Koivisto.
4303
4304         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4305         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4306
4307 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4308
4309         [LFC][Floats] Add support for placing formatting roots in-between floats.
4310         https://bugs.webkit.org/show_bug.cgi?id=194902
4311
4312         Reviewed by Antti Koivisto.
4313
4314         * LayoutReloaded/misc/LFC-passing-tests.txt:
4315
4316 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4317
4318         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4319         https://bugs.webkit.org/show_bug.cgi?id=194901
4320
4321         Unreviewed build fix.
4322
4323         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4324         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4325         WPEBackend-fdo-0.1 as library name.
4326
4327 2019-02-21  Rob Buis  <rbuis@igalia.com>
4328
4329         Update MIME type parser
4330         https://bugs.webkit.org/show_bug.cgi?id=180526
4331
4332         Reviewed by Darin Adler.
4333
4334         Add tests involving leading and trailing whitespace, non-token
4335         characters and quoted strings.
4336
4337         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4338         (TestWebKitAPI::TEST):
4339
4340 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4341
4342         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4343         https://bugs.webkit.org/show_bug.cgi?id=194884
4344
4345         Reviewed by Michael Catanzaro.
4346
4347         * PlatformWin.cmake:
4348
4349 2019-02-20  Chris Dumez  <cdumez@apple.com>
4350
4351         Add API test for <rdar://problem/47471222>
4352         https://bugs.webkit.org/show_bug.cgi?id=194847
4353
4354         Reviewed by Alex Christensen.
4355
4356         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4357
4358 2019-02-20  Chris Dumez  <cdumez@apple.com>
4359
4360         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4361         https://bugs.webkit.org/show_bug.cgi?id=194872
4362         <rdar://problem/47924500>
4363
4364         Reviewed by Alex Christensen.
4365
4366         Add API test coverage.
4367
4368         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4369
4370 2019-02-20  Jer Noble  <jer.noble@apple.com>