[JSCOnly] Add an i386 JSCOnly EWS that runs tests
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2
3         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
4         https://bugs.webkit.org/show_bug.cgi?id=196690
5
6         Reviewed by Michael Catanzaro.
7
8         * QueueStatusServer/config/queues.py:
9         * Scripts/webkitpy/common/config/ews.json:
10         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
11         (test_ews_name):
12
13 2019-04-09  Chris Dumez  <cdumez@apple.com>
14
15         Loads using loadHTMLString() cause flashing when process-swapping
16         https://bugs.webkit.org/show_bug.cgi?id=196714
17         <rdar://problem/49637354>
18
19         Reviewed by Antti Koivisto.
20
21         Add API test coverage.
22
23         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
24
25 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
26
27         Unreviewed. Fix ATK accessibility tests after r244059.
28
29         We are failing to load the injected bundle due to undefined symbol
30         AccessibilityUIElement::replaceTextInRange().
31
32         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
33         (WTR::AccessibilityUIElement::replaceTextInRange):
34
35 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
36
37         AX: Support API: accessibilityReplaceRange:withText
38         https://bugs.webkit.org/show_bug.cgi?id=196636
39
40         Unreviewed build fix for Windows port.
41
42         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
43         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
44
45 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
46
47         [CMake][WinCairo] Separate copied headers into different directories
48         https://bugs.webkit.org/show_bug.cgi?id=196655
49
50         Reviewed by Michael Catanzaro.
51
52         * DumpRenderTree/CMakeLists.txt:
53         * MiniBrowser/win/CMakeLists.txt:
54         * TestWebKitAPI/CMakeLists.txt:
55         * TestWebKitAPI/PlatformWin.cmake:
56
57 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
58
59         Log stack-trace for run-webkit-tests when interrupted
60         https://bugs.webkit.org/show_bug.cgi?id=176393
61         <rdar://problem/34262310>
62
63         Reviewed by Lucas Forschler.
64
65         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
66         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
67         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
68         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
69         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
70         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
71         (main): Set handlers to log stack trace on interruption.
72
73 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
74
75         AX: Support API: accessibilityReplaceRange:withText
76         https://bugs.webkit.org/show_bug.cgi?id=196636
77
78         Unreviewed build fix for Windows port.
79
80         * DumpRenderTree/AccessibilityUIElement.cpp:
81         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
82
83 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
84
85         [ews-build] Scripts using Buildbot API have CORS error
86         https://bugs.webkit.org/show_bug.cgi?id=196709
87
88         Reviewed by Alexey Proskuryakov.
89
90         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
91
92 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
93
94         AX: Support API: accessibilityReplaceRange:withText
95         https://bugs.webkit.org/show_bug.cgi?id=196636
96
97         Reviewed by Daniel Bates.
98
99         * DumpRenderTree/AccessibilityUIElement.cpp:
100         (replaceTextInRangeCallback):
101         (AccessibilityUIElement::replaceTextInRange):
102         (AccessibilityUIElement::getJSClass):
103         * DumpRenderTree/AccessibilityUIElement.h:
104         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
105         (AccessibilityUIElement::replaceTextInRange):
106         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
107         (AccessibilityUIElement::replaceTextInRange):
108         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
109         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
110         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
111         (WTR::AccessibilityUIElement::replaceTextInRange):
112         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
113         (WTR::AccessibilityUIElement::replaceTextInRange):
114
115 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
116
117         [iOS] Do not allow starting selection drags when selection views are not visible
118         https://bugs.webkit.org/show_bug.cgi?id=196686
119         <rdar://problem/49399192>
120
121         Reviewed by Tim Horton.
122
123         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
124         also add some new API tests to cover scenarios where the web view is not first responder.
125
126         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
127         (TestWebKitAPI::TEST):
128         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
129
130         Add a switch to optionally make the web view first responder when starting the simulated drag.
131
132         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
133         (-[DragAndDropSimulator initWithWebView:]):
134         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
135
136 2019-04-08  Justin Fan  <justin_fan@apple.com>
137
138         [Web GPU] Fix Web GPU experimental feature on iOS
139         https://bugs.webkit.org/show_bug.cgi?id=196632
140
141         Reviewed by Myles C. Maxfield.
142
143         Properly make Web GPU available on iOS 11+.
144
145         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
146
147 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
148
149         [ews-build] Do not upload archive when Compile Fails
150         https://bugs.webkit.org/show_bug.cgi?id=196674
151
152         Reviewed by Alexey Proskuryakov.
153
154         * BuildSlaveSupport/ews-build/factories.py:
155         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
156         * BuildSlaveSupport/ews-build/steps.py:
157         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
158         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
159         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
160
161 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
162
163         Enable DFG on MIPS
164         https://bugs.webkit.org/show_bug.cgi?id=196689
165
166         Reviewed by Žan Doberšek.
167
168         Since the bytecode change, we enabled the baseline JIT on mips in
169         r240432, but DFG is still missing. With this change, all tests are
170         passing on a ci20 board.
171
172         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
173
174 2019-04-08  Philippe Normand  <pnormand@igalia.com>
175
176         [Flatpak] Second run update-webkitwpe-flatpak fails
177         https://bugs.webkit.org/show_bug.cgi?id=192702
178
179         Reviewed by Carlos Garcia Campos.
180
181         * flatpak/flatpakutils.py:
182         (FlatpakObject.flatpak): Fix typo.
183         (FlatpakPackage.install): When installing, also update to the configured remote commit.
184         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
185
186 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
187
188         [GTK][WPE] outlook.live.com displays old-fashioned UI
189         https://bugs.webkit.org/show_bug.cgi?id=196642
190
191         Reviewed by Carlos Garcia Campos.
192
193         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
194         (TestWebKitAPI::TEST): New Mac platform quirk test.
195
196 2019-04-07  Commit Queue  <commit-queue@webkit.org>
197
198         Unreviewed, rolling out r243956.
199         https://bugs.webkit.org/show_bug.cgi?id=196688
200
201         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
202         by aakashjain on #webkit).
203
204         Reverted changeset:
205
206         "Clicking "Go Back" from a safe browsing warning from an
207         iframe should navigate the WKWebView back to the previous
208         page"
209         https://bugs.webkit.org/show_bug.cgi?id=196665
210         https://trac.webkit.org/changeset/243956
211
212 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
213
214         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
215         https://bugs.webkit.org/show_bug.cgi?id=196669
216
217         Reviewed by Geoffrey Garen.
218
219         Added three new unit tests for WeakHashSet.
220
221         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
222         (WTF_WeakPtr.WeakHashSetConstObjects):
223         (WTF_WeakPtr.WeakHashSetComputesEmpty):
224         (WTF_WeakPtr.WeakHashSetComputeSize):
225
226 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
227
228         Hide next and previous form control buttons when WKWebView is editable
229         https://bugs.webkit.org/show_bug.cgi?id=196672
230         <rdar://problem/35625321>
231
232         Reviewed by Tim Horton.
233
234         Add a new API test.
235
236         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
237         (-[TestWKWebView lastTrailingBarButtonGroup]):
238         (TestWebKitAPI::TEST):
239         * TestWebKitAPI/ios/UIKitSPI.h:
240
241 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
242
243         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
244         https://bugs.webkit.org/show_bug.cgi?id=196077
245         <rdar://problem/49108202>
246
247         Reviewed by Chris Dumez.
248
249         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
250         on new web view.
251
252         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
253
254 2019-04-05  Saam Barati  <sbarati@apple.com>
255
256         Make compare-results understand MotionMark
257         https://bugs.webkit.org/show_bug.cgi?id=196666
258
259         Reviewed by Yusuke Suzuki.
260
261         * Scripts/compare-results:
262         (PLT5Results):
263         (detectMotionMark):
264         (detectMotionMark1_1):
265         (motionMarkResults):
266         (motionMark1_1Results):
267         (detectBenchmark):
268         (biggerIsBetter):
269         (main):
270
271 2019-04-05  Alex Christensen  <achristensen@webkit.org>
272
273         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
274         https://bugs.webkit.org/show_bug.cgi?id=196665
275         <rdar://45115669>
276
277         Reviewed by Geoff Garen.
278
279         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
280         (goBack):
281         (+[SimpleLookupContext sharedLookupContext]):
282         (-[SimpleLookupContext lookUpURL:completionHandler:]):
283         (TEST):
284         (+[Simple3LookupContext sharedLookupContext]): Deleted.
285         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
286
287 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
288
289         [ews-build] Add configuration and architecture for windows builders
290         https://bugs.webkit.org/show_bug.cgi?id=196660
291
292         Reviewed by Lucas Forschler.
293
294         * BuildSlaveSupport/ews-build/config.json:
295
296 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
297
298         webkitpy: Don't run subsequent rounds if interrupted
299         https://bugs.webkit.org/show_bug.cgi?id=196646
300
301         Reviewed by Aakash Jain.
302
303         * Scripts/webkitpy/layout_tests/controllers/manager.py:
304         (Manager.run): Bail out if interrupted.
305
306 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
307
308         Test sessionStorage in PSON private browsing mode
309         https://bugs.webkit.org/show_bug.cgi?id=196561
310
311         Reviewed by Alex Christensen.
312
313         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
314
315 2019-04-05  Commit Queue  <commit-queue@webkit.org>
316
317         Unreviewed, rolling out r243833.
318         https://bugs.webkit.org/show_bug.cgi?id=196645
319
320         This change breaks build of WPE and GTK ports (Requested by
321         annulen on #webkit).
322
323         Reverted changeset:
324
325         "[CMake][WTF] Mirror XCode header directories"
326         https://bugs.webkit.org/show_bug.cgi?id=191662
327         https://trac.webkit.org/changeset/243833
328
329 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
330
331         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
332         https://bugs.webkit.org/show_bug.cgi?id=196635
333
334         Reviewed by Antti Koivisto.
335         
336         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
337         for a test to enable async frame scrolling via:
338             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
339         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
340         
341         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
342
343         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
344         (WTR::InjectedBundle::beginTesting):
345         * WebKitTestRunner/TestController.cpp:
346         (WTR::TestController::resetPreferencesToConsistentValues):
347
348 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
349
350         Use a correct LC_RPATH when building with ASan
351         https://bugs.webkit.org/show_bug.cgi?id=196576
352
353         Reviewed by David Kilzer.
354
355         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
356         so that ../Frameworks is checked. This is simpler and more reliable than updating
357         each SPC service xcconfig.
358
359 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
360
361         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
362         https://bugs.webkit.org/show_bug.cgi?id=196629
363
364         Reviewed by Lucas Forschler.
365
366         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
367
368 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
369
370         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
371         https://bugs.webkit.org/show_bug.cgi?id=196618
372
373         Reviewed by Lucas Forschler.
374
375         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
376         (StatusBubble): Added QUEUE_TRIGGERS.
377         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
378         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
379         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
380         its parent(builder).
381
382 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
383
384         [ews-app] Status-bubble steps are sometimes displayed in reverse order
385         https://bugs.webkit.org/show_bug.cgi?id=196625
386
387         Reviewed by Lucas Forschler.
388
389         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
390         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
391
392 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
393
394         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
395         https://bugs.webkit.org/show_bug.cgi?id=196630
396
397         Reviewed by Wenson Hsieh.
398
399         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
400
401 2019-04-04  Youenn Fablet  <youenn@apple.com>
402
403         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
404         https://bugs.webkit.org/show_bug.cgi?id=196543
405
406         Reviewed by Alex Christensen.
407
408         * WebKitTestRunner/TestController.cpp:
409         (WTR::TestController::generatePageConfiguration):
410
411 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
412
413         [ews-app] Status bubble should not display skipped buildbot steps
414         https://bugs.webkit.org/show_bug.cgi?id=196584
415
416         Reviewed by Lucas Forschler.
417
418         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
419
420 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
421
422         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
423         https://bugs.webkit.org/show_bug.cgi?id=196620
424
425         Reviewed by Lucas Forschler.
426
427         * BuildSlaveSupport/ews-app/ews/config.py:
428
429 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
430
431         [Win] DumpRenderTreeWatchDog.py is not checked into source
432         https://bugs.webkit.org/show_bug.cgi?id=196567
433         <rdar://problem/49525901>
434
435         Reviewed by Lucas Forschler.
436
437         This script is used on Win EWS bots to terminate hanging DRT processes.
438
439         * EWSTools/dumprendertreewatchdog.py: Added.
440
441 2019-04-04  Chris Dumez  <cdumez@apple.com>
442
443         Unreviewed, roll out r243858 which made tests time out.
444
445         Disable new API tests on Windows instead.
446
447         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
448         (TestWebKitAPI::TEST):
449
450 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
451
452         [ATK] Cleanup WebPageAccessibilityObjectAtk
453         https://bugs.webkit.org/show_bug.cgi?id=196537
454
455         Reviewed by Michael Catanzaro.
456
457         Also consider files under atk directories as exceptions for GObject conventions.
458
459         * Scripts/webkitpy/style/checkers/cpp.py:
460         (check_identifier_name_in_declaration):
461
462 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
463
464         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
465         https://bugs.webkit.org/show_bug.cgi?id=196588
466         <rdar://problem/49365787>
467
468         Unreviewed build fix for Windows port.
469
470         error C3861: 'kill': identifier not found
471
472         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
473         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
474
475 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
476
477         [ews-build] Cancel build and similar operations should have authentication
478         https://bugs.webkit.org/show_bug.cgi?id=196520
479
480         Reviewed by Dewei Zhu.
481
482         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
483         environment variables.
484
485 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
486
487         [ews-build] Do not trigger queues which are not in production yet
488         https://bugs.webkit.org/show_bug.cgi?id=196581
489
490         Reviewed by Dewei Zhu.
491
492         * BuildSlaveSupport/ews-build/config.json:
493
494 2019-04-03  Chris Dumez  <cdumez@apple.com>
495
496         Unreviewed, fix typo in the name of API test added in r243848.
497
498         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
499         (TestWebKitAPI::TEST):
500
501 2019-04-03  Chris Dumez  <cdumez@apple.com>
502
503         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
504         https://bugs.webkit.org/show_bug.cgi?id=196588
505         <rdar://problem/49365787>
506
507         Reviewed by Ryosuke Niwa.
508
509         Add API test coverage.
510
511         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
512         (TestWebKitAPI::nullJavaScriptCallback):
513         (TestWebKitAPI::didCrashCheckFrames):
514         (TestWebKitAPI::TEST):
515
516 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
517
518         run-webkit-tests: Upload test results (new results database)
519         https://bugs.webkit.org/show_bug.cgi?id=196577
520         <rdar://problem/34841155>
521
522         Reviewed by Lucas Forschler.
523
524         * Scripts/webkitpy/layout_tests/controllers/manager.py:
525         (Manager.run): Upload results after each device shard, since the configuration will be
526         different for each device.
527         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
528         uploaded to a results database.
529         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
530         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
531
532 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
533
534         -apple-trailing-word is needed for browser detection
535         https://bugs.webkit.org/show_bug.cgi?id=196575
536
537         Unreviewed.
538
539         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
540
541 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
542
543         [CMake][WTF] Mirror XCode header directories
544         https://bugs.webkit.org/show_bug.cgi?id=191662
545
546         Reviewed by Konstantin Tokarev.
547
548         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
549         builds.
550
551         * CMakeLists.txt:
552         * DumpRenderTree/CMakeLists.txt:
553         * DumpRenderTree/PlatformWin.cmake:
554         * MiniBrowser/win/CMakeLists.txt:
555         * TestWebKitAPI/CMakeLists.txt:
556         * TestWebKitAPI/PlatformWin.cmake:
557         * WebKitTestRunner/PlatformGTK.cmake:
558         * WebKitTestRunner/PlatformWin.cmake:
559
560 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
561
562         [ews-app] Status bubble should not display certain infrastructure status messages
563         https://bugs.webkit.org/show_bug.cgi?id=196550
564
565         Reviewed by Lucas Forschler.
566
567         Do not display the steps which are un-needed for end-user. This information is still avaiable
568         if the user click on the bubble and look at the Buildbot build.
569         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
570         (StatusBubble._steps_messages):
571         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
572
573 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
574
575         [ews-build] Use https for sending data to ews-app
576         https://bugs.webkit.org/show_bug.cgi?id=196492
577
578         Reviewed by Lucas Forschler.
579
580         * BuildSlaveSupport/ews-build/events.py:
581
582 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
583
584         Remove support for -apple-trailing-word
585         https://bugs.webkit.org/show_bug.cgi?id=196525
586
587         Reviewed by Zalan Bujtas.
588
589         This CSS property is nonstandard and not used.
590
591         * Scripts/webkitperl/FeatureList.pm:
592         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
593
594 2019-04-03  Youenn Fablet  <youenn@apple.com>
595
596         Add a test for DOMCache on multiple browsing in case of private browsing
597         https://bugs.webkit.org/show_bug.cgi?id=196524
598
599         Reviewed by Alex Christensen.
600
601         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
602         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
603
604 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
605
606         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
607         https://bugs.webkit.org/show_bug.cgi?id=196540
608
609         Reviewed by Aakash Jain.
610
611         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
612
613 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
614
615         Add plumbing for a compatibility mode preference in WebKit
616         https://bugs.webkit.org/show_bug.cgi?id=196005
617
618         Reviewed by Tim Horton.
619
620         Add new API tests.
621
622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
623         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
624
625 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
626
627         [WPE][GTK] Update libsrtp dependency package for Debian
628         https://bugs.webkit.org/show_bug.cgi?id=196528
629
630         Reviewed by Frédéric Wang.
631
632         * gtk/install-dependencies:
633         * wpe/install-dependencies:
634
635 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
636
637         [WK2] Add support for Window's beforeprint / afterprint events
638         https://bugs.webkit.org/show_bug.cgi?id=196478
639         <rdar://problem/49535124>
640
641         Unreviewed build fix for MSVC.
642
643         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
644
645         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
646
647         * WebKitTestRunner/TestController.cpp:
648         (WTR::printFrame): Use int and float literals.
649
650 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
651
652         [ews-build] Reassign bots to queues
653
654         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
655
656 2019-04-02  Chris Dumez  <cdumez@apple.com>
657
658         [WK2] Add support for Window's beforeprint / afterprint events
659         https://bugs.webkit.org/show_bug.cgi?id=196478
660
661         Reviewed by Alex Christensen.
662
663         Add minimal implementation for printFrame in WebKitTestRunner.
664
665         * WebKitTestRunner/TestController.cpp:
666         (WTR::printFrame):
667         (WTR::TestController::createOtherPage):
668         (WTR::TestController::createWebViewWithOptions):
669
670 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
671
672         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
673         https://bugs.webkit.org/show_bug.cgi?id=196491
674
675         Reviewed by Lucas Forschler.
676
677         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
678
679 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
680
681         [ews-build] Configure buildbot try credentials in environment variables
682         https://bugs.webkit.org/show_bug.cgi?id=196501
683
684         Reviewed by Lucas Forschler.
685
686         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
687         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
688         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
689
690 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
691
692         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
693         https://bugs.webkit.org/show_bug.cgi?id=196496
694         <rdar://problem/49521634>
695
696         Reviewed by Chris Dumez.
697
698         Add new API tests (see WebKit ChangeLog for more detail).
699
700         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
701         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
702         (TEST):
703
704 2019-04-02  David Kilzer  <ddkilzer@apple.com>
705
706         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
707         <https://webkit.org/b/196499>
708
709         Reviewed by Alexey Proskuryakov.
710
711         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
712         ENABLE_ADDRESS_SANITIZER.
713
714 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
715
716         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
717         https://bugs.webkit.org/show_bug.cgi?id=182757
718
719         Reviewed by Don Olmstead.
720
721         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
722         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
723
724 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
725
726         run-api-tests: Upload test results
727         https://bugs.webkit.org/show_bug.cgi?id=196323
728         <rdar://problem/49356714>
729
730         Reviewed by Lucas Forschler.
731
732         * Scripts/webkitpy/api_tests/manager.py:
733         (Manager):
734         (Manager.run): Upload results to a results database.
735         * Scripts/webkitpy/api_tests/run_api_tests.py:
736         (parse_args): Add upload arguments.
737         * Scripts/webkitpy/port/base.py:
738         (Port):
739         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
740         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
741         with commits from any other associated repositories.
742         * Scripts/webkitpy/port/device.py:
743         (Device):
744         (Device.build_version): Access build_versoin of underlying platform device.
745         * Scripts/webkitpy/port/ios_simulator_unittest.py:
746         (IOSSimulatorTest):
747         (IOSSimulatorTest.test_configuration_for_upload):
748         * Scripts/webkitpy/port/device_port.py:
749         (DevicePort):
750         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
751         the same as the machine uploading results.
752         * Scripts/webkitpy/port/mac.py:
753         (MacPort):
754         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
755         * Scripts/webkitpy/port/mac_unittest.py:
756         (MacTest):
757         (MacTest.test_configuration_for_upload):
758         * Scripts/webkitpy/xcode/simulated_device.py:
759         (SimulatedDeviceManager._create_device_with_runtime):
760         (SimulatedDevice.__init__): Create simulated device with a build_version.
761         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
762         (test_existing_simulator):
763
764 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
765
766         Remove extra newline characters (Follow-up fix to r243707)
767
768         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
769
770 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
771
772         [ews-app] Use API_KEY to accept results data
773         https://bugs.webkit.org/show_bug.cgi?id=196461
774
775         Reviewed by Dewei Zhu.
776
777         * BuildSlaveSupport/ews-app/ews/views/results.py:
778         (Results.post): Validate EWS_API_KEY before accepting any data.
779         * BuildSlaveSupport/ews-build/events.py:
780         (Events.sendData): Send EWS_API_KEY if available along with event data.
781
782 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
783
784         Unable to copy and paste a PDF from Notes into Mail compose body
785         https://bugs.webkit.org/show_bug.cgi?id=196442
786         <rdar://problem/48573098>
787
788         Reviewed by Tim Horton.
789
790         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
791         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
792         to be specified on the item providers.
793
794         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
795         (TestWebKitAPI::mapItemForTesting):
796         (TestWebKitAPI::contactItemForTesting):
797
798 2019-04-01  Tim Horton  <timothy_horton@apple.com>
799
800         Make UIWKDocumentContext rects per-character instead of per-word
801         https://bugs.webkit.org/show_bug.cgi?id=196459
802
803         Reviewed by Wenson Hsieh.
804
805         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
806         (TEST):
807         Adjust test results due to switching to per-character rects.
808
809 2019-04-01  Chris Dumez  <cdumez@apple.com>
810
811         UIProcess crash when a prewarmed process is terminated
812         https://bugs.webkit.org/show_bug.cgi?id=196451
813         <rdar://problem/49245471>
814
815         Reviewed by Geoffrey Garen.
816
817         Add API test coverage.
818
819         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
820         (TEST):
821
822 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
823
824         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
825         https://bugs.webkit.org/show_bug.cgi?id=196449
826
827         Reviewed by Lucas Forschler.
828
829         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
830         (StatusBubble.get_os_details): Method to get OS and Xcode details.
831         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
832         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
833
834 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
835
836         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
837         https://bugs.webkit.org/show_bug.cgi?id=196444
838
839         Reviewed by Lucas Forschler.
840
841         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
842
843 2019-04-01  Alex Christensen  <achristensen@webkit.org>
844
845         Add SPI to canonicalize NSURLs with WTF::URL
846         https://bugs.webkit.org/show_bug.cgi?id=196415
847         <rdar://problem/44980271>
848
849         Reviewed by Darin Adler.
850
851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
852         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
853         (TestWebKitAPI::TEST):
854
855 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
856
857         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
858         https://bugs.webkit.org/show_bug.cgi?id=196441
859
860         Reviewed by Carlos Garcia Campos.
861
862         Don't cache the wpe_view_backend object that might not exist yet at the
863         time of EventSenderProxy constructor invocation, but instead retrieve
864         that object whenever it's required for event dispatching. This should
865         avoid crashes in this constructor now that it's invoked before any
866         PlatformWindow has been set up (as changed in r243496).
867
868         * WebKitTestRunner/EventSenderProxy.h:
869         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
870         (WTR::viewBackend):
871         (WTR::EventSenderProxy::EventSenderProxy):
872         (WTR::EventSenderProxy::mouseDown):
873         (WTR::EventSenderProxy::mouseUp):
874         (WTR::EventSenderProxy::mouseMoveTo):
875         (WTR::EventSenderProxy::mouseScrollBy):
876         (WTR::EventSenderProxy::keyDown):
877         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
878
879 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
880
881         [Win][WebKit] MiniBrowser should support high DPI display
882         https://bugs.webkit.org/show_bug.cgi?id=196391
883
884         Reviewed by Alex Christensen.
885
886         * MiniBrowser/win/WebKitBrowserWindow.cpp:
887         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
888         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
889         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
890
891 2019-03-31  Sam Weinig  <weinig@apple.com>
892
893         Remove more i386 specific configurations
894         https://bugs.webkit.org/show_bug.cgi?id=196430
895
896         Reviewed by Alexey Proskuryakov.
897
898         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
899         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
900
901 2019-03-31  Andy Estes  <aestes@apple.com>
902
903         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
904         https://bugs.webkit.org/show_bug.cgi?id=196433
905         <rdar://problem/49293305>
906
907         Reviewed by Tim Horton.
908
909         Enhanced API test coverage to include all navigation response policy decisions in both
910         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
911
912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
913         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
914         (TestWebKitAPI::TEST):
915         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
916         (readFile):
917         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
918         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
919         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
920         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
921         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
922         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
923         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
924         (-[QuickLookDelegate _downloadDidStart:]):
925         (-[QuickLookDelegate _download:didReceiveResponse:]):
926         (-[QuickLookDelegate _download:didReceiveData:]):
927         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
928         (-[QuickLookDelegate _downloadDidFinish:]):
929         (-[QuickLookDelegate _download:didFailWithError:]):
930         (-[QuickLookDelegate _downloadDidCancel:]):
931         (-[QuickLookDelegate verifyDownload]):
932         (runTest):
933         (runTestDecideBeforeLoading):
934         (runTestDecideAfterLoading):
935         (TEST):
936         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
937         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
938         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
939         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
940         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
941         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
942         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
943         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
944         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
945         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
946         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
947         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
948         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
949         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
950
951 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
952
953         [CMake] add testdfg as target with build-jsc
954         https://bugs.webkit.org/show_bug.cgi?id=196393
955
956         Reviewed by Saam Barati.
957
958         Added testdfg as one of the targets to build when
959         using CMake.
960
961         * Scripts/build-jsc:
962
963 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
964
965         Delete WebMetal implementation in favor of WebGPU
966         https://bugs.webkit.org/show_bug.cgi?id=195418
967
968         Reviewed by Dean Jackson.
969
970         * DumpRenderTree/mac/DumpRenderTree.mm:
971         (enableExperimentalFeatures):
972         (resetWebPreferencesToConsistentValues):
973         * Scripts/webkitperl/FeatureList.pm:
974         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
975         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
976         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
977         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
978         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
979         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
980         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
981         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
982         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
983         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
984         (WTR::InjectedBundle::beginTesting):
985         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
986         (WTR::TestRunner::setWebMetalEnabled): Deleted.
987         * WebKitTestRunner/InjectedBundle/TestRunner.h:
988
989 2019-03-29  Chris Dumez  <cdumez@apple.com>
990
991         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
992         https://bugs.webkit.org/show_bug.cgi?id=196405
993         <rdar://problem/49428130>
994
995         Reviewed by Wenson Hsieh.
996
997         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
998         the popover presentation methods to be no-ops. Use this in the new test added in
999         r243523 so that we do not swizzle those methods for all tests. This is needed because
1000         those WatchOS tests rely on the popover getting presented and interactive.
1001
1002         * WebKitTestRunner/TestController.cpp:
1003         (WTR::updateTestOptionsFromTestHeader):
1004         * WebKitTestRunner/TestController.h:
1005         * WebKitTestRunner/TestOptions.h:
1006         (WTR::TestOptions::hasSameInitializationOptions const):
1007         * WebKitTestRunner/ios/TestControllerIOS.mm:
1008         (WTR::TestController::platformInitialize):
1009         (WTR::TestController::platformResetStateToConsistentValues):
1010
1011 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1012
1013         [Curl] Add Server Trust Evaluation Support.
1014         https://bugs.webkit.org/show_bug.cgi?id=191646
1015
1016         Reviewed by Fujii Hironori.
1017
1018         Implemented MiniBrowser UI for asking if user trusts the server.
1019
1020         * MiniBrowser/win/Common.cpp:
1021         (askServerTrustEvaluation):
1022         (replaceString):
1023         * MiniBrowser/win/Common.h:
1024         * MiniBrowser/win/MiniBrowserLib.rc:
1025         * MiniBrowser/win/MiniBrowserLibResource.h:
1026         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1027         (createPEMString):
1028         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1029         (WebKitBrowserWindow::canTrustServerCertificate):
1030         * MiniBrowser/win/WebKitBrowserWindow.h:
1031
1032 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1033
1034         Implement ResizeObserver.
1035         https://bugs.webkit.org/show_bug.cgi?id=157743
1036
1037         Reviewed by Simon Fraser.
1038
1039         Support resizeObserverEnabled webPreferences.
1040
1041         * DumpRenderTree/TestOptions.cpp:
1042         (TestOptions::TestOptions):
1043         * DumpRenderTree/TestOptions.h:
1044         * DumpRenderTree/mac/DumpRenderTree.mm:
1045         (setWebPreferencesForTestOptions):
1046         * DumpRenderTree/win/DumpRenderTree.cpp:
1047         (enableExperimentalFeatures):
1048         * Scripts/webkitperl/FeatureList.pm:
1049         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1050
1051 2019-03-28  John Wilander  <wilander@apple.com>
1052
1053         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1054         https://bugs.webkit.org/show_bug.cgi?id=196281
1055         <rdar://problem/48938748>
1056
1057         Reviewed by Alex Christensen.
1058
1059         This patch adds the function isStatisticsHasLocalStorage() to the
1060         TestRunner. With it, the page can query the WebsiteDataStore in the
1061         UI process to make sure that it sees LocalStorage.
1062
1063         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1064         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1065         (WTR::TestRunner::isStatisticsHasLocalStorage):
1066         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1067         * WebKitTestRunner/TestController.cpp:
1068         (WTR::TestController::isStatisticsHasLocalStorage):
1069         * WebKitTestRunner/TestController.h:
1070         * WebKitTestRunner/TestInvocation.cpp:
1071         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1072
1073 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1074
1075         API::Data::createWithoutCopying should do a null check before calling CFRelease
1076         https://bugs.webkit.org/show_bug.cgi?id=196276
1077         <rdar://problem/48059859>
1078
1079         Reviewed by Alex Christensen.
1080
1081         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1082
1083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1084         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1085         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1086         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1087         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1088         (TestWebKitAPI::TEST):
1089
1090 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1091
1092         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1093         https://bugs.webkit.org/show_bug.cgi?id=186276
1094
1095         Reviewed by Carlos Garcia Campos.
1096
1097         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1098         (webViewLoadChanged):
1099         (testWebResourceGetDataError):
1100         (testWebResourceGetDataEmpty):
1101         (beforeAll):
1102         (webViewloadChanged): Deleted.
1103
1104 2019-03-27  Andy Estes  <aestes@apple.com>
1105
1106         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1107         https://bugs.webkit.org/show_bug.cgi?id=196317
1108
1109         Reviewed by Dan Bernstein.
1110
1111         package-root copies built products into a staging directory using ditto(1), which does not
1112         follow symbolic links as it traverses a directory. Now that the files in
1113         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1114         itself, these become broken links when ditto'd into the staging directory.
1115
1116         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1117
1118         * Scripts/package-root:
1119
1120 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1121
1122         [ews-app] Update display text of Submit for ews analysis
1123         https://bugs.webkit.org/show_bug.cgi?id=196309
1124
1125         Reviewed by Dewei Zhu.
1126
1127         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1128
1129 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1130
1131         run-webkit-tests should check for leaks in WebKit processes
1132         <https://webkit.org/b/193772>
1133         <rdar://problem/46526680>
1134
1135         Reviewed by Ryosuke Niwa.
1136
1137         This works by doing the following:
1138         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1139           The list of child processes are returned one per line:
1140           process.name: pid
1141         - Run the "#LIST CHILD PROCESSES" command just before the
1142           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1143           processes on the ServerProcess object.
1144         - When the `--leaks` switch is handled, run check_for_leaks() on
1145           each child process after the main test harness.
1146
1147         * DumpRenderTree/mac/DumpRenderTree.mm:
1148         (handleControlCommand):
1149         - Use strncmp() instead of strcmp().
1150         - Add support for handling "#LIST CHILD PROCESSES" command.
1151
1152         * Scripts/webkitpy/port/base.py:
1153         (Port.check_for_leaks):
1154         * Scripts/webkitpy/port/darwin.py:
1155         (DarwinPort.check_for_leaks):
1156         - Rename redundant 'process_pid' argument to 'process_id'.
1157
1158         * Scripts/webkitpy/port/driver.py:
1159         (Driver.do_post_tests_work):
1160         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1161           longer the only command this sends to WebKitTestRunner.
1162         - If the `--leaks` switch is present, send the
1163           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1164           result using Port.set_webkit_processes().
1165         (Driver._parse_child_processes_output):
1166         - Add helper method to parse list of child process names and
1167           process IDs returned from WebKitTestRunner.
1168
1169         * Scripts/webkitpy/port/ios_device.py:
1170         (IOSDevicePort.check_for_leaks):
1171         - Rename redundant 'process_pid' argument to 'process_id'.
1172
1173         * Scripts/webkitpy/port/leakdetector.py:
1174         (LeakDetector._parse_leaks_output):
1175         - Return early if there is no leaks_output.
1176         (LeakDetector.check_for_leaks):
1177         - Rename redundant 'process_pid' argument to 'process_id'.
1178
1179         * Scripts/webkitpy/port/server_process.py:
1180         (ServerProcess.__init__):
1181         (ServerProcess.child_processes):
1182         (ServerProcess.set_child_processes):
1183         - Add instance variable to Port to store list of child process
1184           names and process IDs returned from WebKitTestRunner.
1185         (ServerProcess._start):
1186         - Clear self._child_processes.
1187         (ServerProcess.stop):
1188         - If self._child_processes is set, call
1189           self._port.check_for_leaks() for each child process.
1190
1191         * Scripts/webkitpy/port/server_process_unittest.py:
1192         (TrivialMockPort.check_for_leaks):
1193         - Rename redundant 'process_pid' argument to 'process_id'.
1194
1195         * Scripts/webkitpy/port/simulator_process.py:
1196         (SimulatorProcess.stop):
1197         - If self._child_processes is set, call
1198           self._port.check_for_leaks() for each child process.
1199
1200         * Scripts/webkitpy/port/watch_device.py:
1201         (WatchDevicePort.check_for_leaks):
1202         - Rename redundant 'process_pid' argument to 'process_id'.
1203
1204         * WebKitTestRunner/TestController.cpp:
1205         (WTR::TestController::dumpResponse):
1206         - Extract method from findAndDumpWorldLeaks() so that it may be
1207           reused by findAndDumpWebKitProcessIdentifiers().
1208         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1209         - Add method to output process name and process ID of both the
1210           WebContent and Networking processes.
1211         (WTR::TestController::findAndDumpWorldLeaks):
1212         - Fix missing newline in output when there were no abandoned
1213           documents.
1214         - Call dumpResponse() for extracted code.
1215         (WTR::TestController::handleControlCommand):
1216         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1217         - Use strncmp() instead of strcmp().
1218         - Call findAndDumpWebKitProcessIdentifiers() when
1219           "#LIST CHILD PROCESSES" command is sent.
1220         * WebKitTestRunner/TestController.h:
1221         (WTR::TestController::dumpResponse):
1222         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1223         - Declare methods.
1224
1225 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1226
1227         Unreviewed. Add GLib API test cases after r243434.
1228
1229         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1230         (testWebViewActiveURI):
1231         (serverCallback):
1232         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1233         (sendRequestCallback):
1234
1235 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1236
1237         Geolocation request not complete when watch request was started in a different web process
1238         https://bugs.webkit.org/show_bug.cgi?id=195996
1239
1240         Reviewed by Alex Christensen.
1241
1242         Add a test case.
1243
1244         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1245         (TestWebKitAPI::runJavaScriptAlert):
1246         (TestWebKitAPI::TEST):
1247
1248 2019-03-26  Keith Rollin  <krollin@apple.com>
1249
1250         Update the way generate-xcfilelists returns strings from functions
1251         https://bugs.webkit.org/show_bug.cgi?id=195975
1252         <rdar://problem/49040807>
1253
1254         Reviewed by Dean Jackson.
1255
1256         There are places where generate-xcfilelists executes assignments with
1257         statements like:
1258
1259             FOO=$(some_function)
1260
1261         where "some_function" return a string by echoing it. E.g.
1262
1263             some_function()
1264             {
1265                 echo "Hello, World"
1266             }
1267
1268         This is a common idiom, but it has a problem if "some_function" needs
1269         to call "exit" in an attempt to halt the entire script right then and
1270         there. Since "some_function" is called inside of $(), it's being
1271         executed in a sub-shell. Calling exit in that sub-shell simply exits
1272         that shell; it doesn't not exit the outer shell in which the main part
1273         of the script is still running. As such, the main script keeps
1274         executing when the intent was for the script to halt.
1275
1276         The solution to this is to use a different idiom for returning
1277         strings. The one we now is to pass in the name of the variable to
1278         receive the string result:
1279
1280             some_function()
1281             {
1282                 variable_name=$1
1283                 eval $variable_name ="Hello, World"
1284             }
1285
1286         The call site now looks like
1287
1288             some_function FOO
1289
1290         Because there's no invocation of a sub-shell, some_function can now
1291         call "exit" if it wants to, and the entire script will exit at that
1292         point.
1293
1294         * Scripts/generate-xcfilelists:
1295
1296 2019-03-26  Chris Dumez  <cdumez@apple.com>
1297
1298         Add basic layout test coverage for File Picker on iOS
1299         https://bugs.webkit.org/show_bug.cgi?id=196265
1300
1301         Reviewed by Wenson Hsieh.
1302
1303         Add layout test infrastructure to test the file picker on iOS.
1304
1305         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1306         (WTR::UIScriptController::dismissFilePicker):
1307         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1308         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1309         (WTR::UIScriptController::dismissFilePicker):
1310         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1311         * WebKitTestRunner/TestController.cpp:
1312         (WTR::TestController::createWebViewWithOptions):
1313         (WTR::updateTestOptionsFromTestHeader):
1314         * WebKitTestRunner/TestOptions.h:
1315         (WTR::TestOptions::hasSameInitializationOptions const):
1316         * WebKitTestRunner/ios/TestControllerIOS.mm:
1317         (overridePresentViewController):
1318         (WTR::TestController::platformInitialize):
1319         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1320         (WTR::UIScriptController::dismissFilePicker):
1321
1322 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1323
1324         Implement async paste method on UIWKInteractionViewProtocol
1325         https://bugs.webkit.org/show_bug.cgi?id=196267
1326         <rdar://problem/49236346>
1327
1328         Reviewed by Tim Horton.
1329
1330         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1331         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1332         are now a part of all iOS 12 internal SDKs.
1333
1334         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1335
1336         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1337         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1338
1339         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1340         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1341         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1342         * TestWebKitAPI/ios/UIKitSPI.h:
1343
1344 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1345
1346         [ews-build] Use PostgreSQL for ews.webkit.org database
1347         https://bugs.webkit.org/show_bug.cgi?id=196270
1348
1349         Reviewed by Lucas Forschler.
1350
1351         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1352
1353 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1354
1355         [ews] Reset simctl states on reboot
1356         https://bugs.webkit.org/show_bug.cgi?id=196260
1357
1358         Rubber-stamped by Aakash Jain.
1359
1360         * EWSTools/start-queue-mac.sh:
1361
1362 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1363
1364         [ews-build] Use PostgreSQL for ews-build database
1365         https://bugs.webkit.org/show_bug.cgi?id=196229
1366
1367         Reviewed by Lucas Forschler.
1368
1369         * BuildSlaveSupport/ews-build/master.cfg:
1370
1371 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1372
1373         [ews-build] Get master_hostname dynamically in master.cfg
1374         https://bugs.webkit.org/show_bug.cgi?id=196255
1375
1376         Reviewed by Lucas Forschler.
1377
1378         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1379         send events data in test mode.
1380
1381 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1382
1383         [ews-app] Set db_constraint to False for Foreign Keys
1384         https://bugs.webkit.org/show_bug.cgi?id=196252
1385
1386         Reviewed by Lucas Forschler.
1387
1388         * BuildSlaveSupport/ews-app/ews/models/build.py:
1389         * BuildSlaveSupport/ews-app/ews/models/step.py:
1390
1391 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1392
1393         [ews-build] is_test_mode_enabled should default to True
1394         https://bugs.webkit.org/show_bug.cgi?id=196248
1395
1396         Reviewed by Lucas Forschler.
1397
1398         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1399
1400 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1401
1402         [ews-app] Add webkitperl to ENABLED_QUEUES
1403         https://bugs.webkit.org/show_bug.cgi?id=196253
1404
1405         Reviewed by Lucas Forschler.
1406
1407         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1408
1409 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1410
1411         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1412         https://bugs.webkit.org/show_bug.cgi?id=196211
1413         rdar://problem/49110552
1414
1415         Reviewed by Tim Horton.
1416
1417         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1418         Make sure that EventSenderProxy always exists when running tests. We used to create
1419         it when resetting before the first test, which is a bit too late.
1420
1421         * WebKitTestRunner/TestController.h:
1422         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1423         (WTR::TestController::platformCreateWebView):
1424         (WTR::TestController::platformCreateOtherPage):
1425         (WTR::TestController::finishCreatingPlatformWebView):
1426         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1427         (WTR::PlatformWebView::PlatformWebView):
1428         Moved some code that made NSWindow use NSEvent during web view creation. We may
1429         need to move more if some other case us found, but this is enough for now.
1430
1431 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1432
1433         Unreviewed. Fix typo in GLib geolocation API after r243285.
1434
1435         gelocation -> geolocation.
1436
1437         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1438         (testGeolocationManagerWatchPosition):
1439
1440 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1441
1442         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1443         https://bugs.webkit.org/show_bug.cgi?id=196213
1444
1445         Reviewed by Geoff Garen.
1446
1447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1448         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1449         (credentialWithIdentityAndKeychainPath):
1450         (-[ChallengeDelegate webView:didFinishNavigation:]):
1451         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1452         (TestWebKitAPI::TEST):
1453
1454 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1455
1456         Expected shouldn't assume its contained types are copyable
1457         https://bugs.webkit.org/show_bug.cgi?id=195986
1458
1459         Reviewed by JF Bastien.
1460
1461         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1462         (TestWebKitAPI::NonCopyable::operator== const):
1463         (TestWebKitAPI::NonCopyable::operator!= const):
1464         (TestWebKitAPI::TEST):
1465
1466 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1467
1468         Remove some now-unnecessary dynamic class lookup
1469         https://bugs.webkit.org/show_bug.cgi?id=196237
1470
1471         Reviewed by Simon Fraser.
1472
1473         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1474         (makeRequest):
1475         (TEST):
1476
1477 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1478
1479         Unreviewed, rolling out r243450.
1480
1481         AppleWin and WinCairo port builds get broken.
1482
1483         Reverted changeset:
1484
1485         "Add test for fix of #196095"
1486         https://bugs.webkit.org/show_bug.cgi?id=196097
1487         https://trac.webkit.org/changeset/243450
1488
1489 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1490
1491         Unreviewed, rolling out r243465.
1492         https://bugs.webkit.org/show_bug.cgi?id=196226
1493
1494         the test doesn't build (Requested by thorton on #webkit).
1495
1496         Reverted changeset:
1497
1498         "Do not terminate the NetworkProcess if a third party
1499         application sends a NSCredential with a SecIdentityRef"
1500         https://bugs.webkit.org/show_bug.cgi?id=196213
1501         https://trac.webkit.org/changeset/243465
1502
1503 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1504
1505         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1506         https://bugs.webkit.org/show_bug.cgi?id=196213
1507
1508         Reviewed by Geoff Garen.
1509
1510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1511         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1512         (credentialWithIdentityAndKeychainPath):
1513         (-[ChallengeDelegate webView:didFinishNavigation:]):
1514         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1515         (TestWebKitAPI::TEST):
1516
1517 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1518
1519         [ews-build] Gracefully handle missing patch_id in events
1520         https://bugs.webkit.org/show_bug.cgi?id=196216
1521
1522         Reviewed by Lucas Forschler.
1523
1524         * BuildSlaveSupport/ews-build/events.py:
1525
1526 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1527
1528         [ews-build] use lz4 compression for improving buildbot performance
1529         https://bugs.webkit.org/show_bug.cgi?id=196155
1530
1531         Reviewed by Lucas Forschler.
1532
1533         * BuildSlaveSupport/ews-build/master.cfg:
1534
1535 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1536
1537         Pull some API testing helper methods out of TestWKWebView
1538         https://bugs.webkit.org/show_bug.cgi?id=196212
1539
1540         Reviewed by Tim Horton.
1541
1542         Refactor some more API testing utility methods, so that they can be used in
1543         tests that do not use TestWKWebView.
1544
1545         * TestWebKitAPI/cocoa/TestWKWebView.h:
1546         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1547         (-[WKWebView loadTestPageNamed:]):
1548         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1549         (-[WKWebView synchronouslyLoadHTMLString:]):
1550         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1551         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1552         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1553         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1554         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1555
1556 2019-03-25  Jer Noble  <jer.noble@apple.com>
1557
1558         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1559         https://bugs.webkit.org/show_bug.cgi?id=196097
1560
1561         Reviewed by Eric Carlson.
1562
1563         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1564
1565         * DumpRenderTree/mac/DumpRenderTree.mm:
1566         (resetWebPreferencesToConsistentValues):
1567         * WebKitTestRunner/TestController.cpp:
1568         (WTR::TestController::resetPreferencesToConsistentValues):
1569
1570 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1571
1572         Pull IPadUserInterfaceSwizzler out into a separate header file
1573         https://bugs.webkit.org/show_bug.cgi?id=196193
1574
1575         Reviewed by Anders Carlsson.
1576
1577         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1578         be used in other API tests.
1579
1580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1581         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1582         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1583         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1584         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1585         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1586         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1587
1588 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1589
1590         Remove NavigatorContentUtils in WebCore/Modules
1591         https://bugs.webkit.org/show_bug.cgi?id=196070
1592
1593         Reviewed by Alex Christensen.
1594
1595         NavigatorContentUtils was to support the custom scheme spec [1].
1596         However, in WebKit side, no port has supported the feature in
1597         WebKit layer after EFL port was removed. So there has been the
1598         only IDL implementation of the NavigatorContentUtils in WebCore.
1599         So we don't need to keep the implementation in WebCore anymore.
1600
1601         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1602
1603         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1604
1605 2019-03-24  Andy Estes  <aestes@apple.com>
1606
1607         [watchOS] Remove unused Proximity Networking code
1608         https://bugs.webkit.org/show_bug.cgi?id=196188
1609
1610         Reviewed by Tim Horton.
1611
1612         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1613         (TEST):
1614
1615 2019-03-23  Keith Miller  <keith_miller@apple.com>
1616
1617         Refactor clz/ctz and fix getLSBSet.
1618         https://bugs.webkit.org/show_bug.cgi?id=196162
1619
1620         Reviewed by Saam Barati.
1621
1622         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1623
1624         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1625         (TestWebKitAPI::TEST):
1626
1627 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1628
1629         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1630         https://bugs.webkit.org/show_bug.cgi?id=196143
1631
1632         Reviewed by Michael Catanzaro.
1633
1634         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1635         directories.
1636
1637         * Scripts/webkitpy/style/checkers/cpp.py:
1638         (check_identifier_name_in_declaration):
1639         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1640         (WebKitStyleTest.test_names):
1641
1642 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1643
1644         [Flatpak] Manifest expanding fails for qt WPE extension
1645         https://bugs.webkit.org/show_bug.cgi?id=196148
1646
1647         Reviewed by Alex Christensen.
1648
1649         * flatpak/flatpakutils.py:
1650         (expand_submodules_recurse): The last recurse manifest expand
1651         iteration might lead to a single module so take it into account
1652         and don't try to recurse further.
1653
1654 2019-03-22  Chris Dumez  <cdumez@apple.com>
1655
1656         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1657         https://bugs.webkit.org/show_bug.cgi?id=195348
1658         <rdar://problem/48622090>
1659
1660         Reviewed by Alex Christensen.
1661
1662         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1663         to NO when test.options().shouldIgnoreMetaViewport is false.
1664
1665         * WebKitTestRunner/ios/TestControllerIOS.mm:
1666         (WTR::TestController::platformConfigureViewForTest):
1667
1668 2019-03-22  Chris Dumez  <cdumez@apple.com>
1669
1670         Prewarmed processes should be usable with any website data store
1671         https://bugs.webkit.org/show_bug.cgi?id=196104
1672
1673         Reviewed by Alex Christensen.
1674
1675         Add API test coverage.
1676
1677         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1678         (runInitialWarmedProcessUsedTest):
1679         (TEST):
1680
1681 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1682
1683         Back out local changes to Alex's Subversion working directory
1684
1685         They were accidentally committed.
1686
1687         * Scripts/webkitpy/common/system/abstractexecutive.py:
1688         (AbstractExecutive.wait_newest):
1689         * Scripts/webkitpy/common/system/executive.py:
1690         (Executive.running_pids):
1691         * Scripts/webkitpy/common/system/executive_mock.py:
1692         (MockExecutive.running_pids):
1693         * Scripts/webkitpy/common/system/executive_unittest.py:
1694         (ExecutiveTest.serial_test_running_pids):
1695         * Scripts/webkitpy/port/darwin.py:
1696         (DarwinPort.check_for_leaks):
1697         * Scripts/webkitpy/port/leakdetector.py:
1698         (LeakDetector.check_for_leaks):
1699         - This was the hack attached to Bug 193772.
1700
1701         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1702         (+[WebKitTestRunnerEvent mouseLocation]):
1703         - This works around a crash on an internal build.
1704
1705 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1706
1707         Fix the build after r243354
1708         https://bugs.webkit.org/show_bug.cgi?id=196138
1709         <rdar://problem/49145951>
1710
1711         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1712         (TEST):
1713         * TestWebKitAPI/ios/UIKitSPI.h:
1714
1715 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1716
1717         Adopt UIWKDocumentContext
1718         https://bugs.webkit.org/show_bug.cgi?id=196040
1719         <rdar://problem/48642440>
1720
1721         Reviewed by Ryosuke Niwa.
1722
1723         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1724         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1725         (makeRequest):
1726         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1727         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1728         (applyStyle):
1729         (TEST):
1730         Add tests for UIWKDocumentContext.
1731
1732         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1733         (TEST):
1734         (recursiveFindWKContentView): Deleted.
1735         * TestWebKitAPI/cocoa/TestWKWebView.h:
1736         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1737         (recursiveFindWKContentView):
1738         (-[TestWKWebView wkContentView]):
1739         * TestWebKitAPI/ios/UIKitSPI.h:
1740         Share the WKContentView finding code between tests.
1741
1742 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1743
1744         [iOS WK2] Turn on async overflow scrolling by default
1745         https://bugs.webkit.org/show_bug.cgi?id=196011
1746         rdar://problem/48453859
1747
1748         Reviewed by Antti Koivisto.
1749         
1750         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1751         since so many basic layout tests have different results when compositing is triggered for
1752         overflow.
1753         
1754         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1755
1756         * WebKitTestRunner/TestController.cpp:
1757         (WTR::TestController::resetPreferencesToConsistentValues):
1758
1759 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1760
1761         [ews-build] Retry API test in case of failures
1762         https://bugs.webkit.org/show_bug.cgi?id=196004
1763
1764         Reviewed by Lucas Forschler.
1765
1766         * BuildSlaveSupport/ews-build/steps.py:
1767         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1768         (CompileWebKitToT.doStepIf): Ditto.
1769         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1770         (ReRunAPITests): Re-run API tests.
1771         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1772         (RunAPITestsWithoutPatch): Run API tests without patch.
1773         (RunAPITestsWithoutPatch.doStepIf):
1774         (RunAPITestsWithoutPatch.hideStepIf):
1775         (RunAPITestsWithoutPatch.evaluateCommand):
1776         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1777         (AnalyzeAPITestsResults.start):
1778         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1779         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1780         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1781         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1782
1783 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1784
1785         [ews-build] Update queues configurations
1786         https://bugs.webkit.org/show_bug.cgi?id=196074
1787
1788         Reviewed by Dewei Zhu.
1789
1790         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1791         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1792
1793 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1794
1795         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1796         https://bugs.webkit.org/show_bug.cgi?id=195680
1797         <rdar://problem/48903534>
1798
1799         Unreviewed infrastructure fix.
1800
1801         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1802         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1803
1804 2019-03-21  Andy Estes  <aestes@apple.com>
1805
1806         [iOS] Apple Pay should be available in documents with no user agent scripts
1807         https://bugs.webkit.org/show_bug.cgi?id=196061
1808         <rdar://problem/48649391>
1809
1810         Reviewed by Brady Eidson.
1811
1812         Added API tests and related infrastructure.
1813
1814         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1815         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1816         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1817         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1818         (TestWebKitAPI::TEST):
1819         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1820         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1821         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1822         * TestWebKitAPI/cocoa/TestProtocol.mm:
1823         (-[TestProtocol startLoading]):
1824         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1825         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1826         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1827         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1828
1829 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1830
1831         REGRESSSION (r243297): webkitpy tests broken
1832         https://bugs.webkit.org/show_bug.cgi?id=196108
1833
1834         Reviewed by Aakash Jain.
1835
1836         r243297 updated contributors.json, which broke a few unit tests.
1837
1838         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1839         (IRCCommandTest.test_whois):
1840         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1841
1842 2019-03-21  Chris Dumez  <cdumez@apple.com>
1843
1844         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1845         https://bugs.webkit.org/show_bug.cgi?id=196041
1846         <rdar://problem/49083230>
1847
1848         Reviewed by Alex Christensen.
1849
1850         Add API test coverage.
1851
1852         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1853         (TEST):
1854
1855 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1856
1857         Add SPI to inform applications of WKContentRuleList actions
1858         https://bugs.webkit.org/show_bug.cgi?id=195965
1859         <rdar://problem/42664365>
1860
1861         Reviewed by Geoff Garen.
1862
1863         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1864         (TestWebKitAPI::allActionsForResourceLoad):
1865         (TestWebKitAPI::testRequest):
1866         (TestWebKitAPI::TEST_F):
1867         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1868         (Notification::description):
1869         (Notification::operator== const):
1870         (toVector):
1871         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1872         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1873         (makeContentRuleList):
1874         (TEST):
1875         (makeWarnContentRuleList): Deleted.
1876
1877 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1878
1879         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1880         https://bugs.webkit.org/show_bug.cgi?id=196088
1881
1882         Reviewed by Brian Burg.
1883
1884         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1885         Support checks when only one platform is specified. Also deprecate macosx() and
1886         force the use of macos() instead.
1887
1888         * Scripts/webkitpy/style/checkers/cpp.py:
1889         (check_min_versions_of_wk_api_available):
1890         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1891         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1892
1893 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1894
1895         Update status inactive committers' status to 'contributor'.
1896
1897         * Scripts/webkitpy/common/config/contributors.json:
1898
1899 2019-03-21  Xan Lopez  <xan@igalia.com>
1900
1901         [JSC][x86] Drop support for x87 floating point
1902         https://bugs.webkit.org/show_bug.cgi?id=194853
1903
1904         Reviewed by Don Olmstead.
1905
1906         Force SSE2 on x86/32bit builds.
1907
1908         * Scripts/webkitdirs.pm:
1909         (generateBuildSystemFromCMakeProject):
1910
1911 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1912
1913         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1914         https://bugs.webkit.org/show_bug.cgi?id=196073
1915
1916         Reviewed by Michael Catanzaro.
1917
1918         Add test cases to check functions and constructors with no arguments but receiving user data.
1919
1920         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1921         (checkUserData):
1922         (testJSCFunction):
1923         (fooCreateWithUserData):
1924         (testJSCClass):
1925
1926 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1927
1928         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1929
1930         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1931
1932         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1933
1934 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1935
1936         [GTK][WPE] Add API to provide geolocation information
1937         https://bugs.webkit.org/show_bug.cgi?id=195940
1938
1939         Reviewed by Michael Catanzaro.
1940
1941         Add a new test to check the new API.
1942
1943         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1944         (testGeolocationManagerCurrentPosition):
1945         (testGeolocationManagerWatchPosition):
1946         (beforeAll):
1947         (afterAll):
1948         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1949         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1950         (beforeAll): Ditto.
1951         * TestWebKitAPI/glib/CMakeLists.txt:
1952
1953 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1954
1955         [GLib] Returning G_TYPE_OBJECT from a method does not work
1956         https://bugs.webkit.org/show_bug.cgi?id=195574
1957
1958         Reviewed by Michael Catanzaro.
1959
1960         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1961
1962         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1963         (getGFile):
1964         (getParent):
1965         (createGString):
1966         (getGString):
1967         (getGStringCopyWillRaise):
1968         (getGStringCopy):
1969         (getGStringStr):
1970         (getGStringLen):
1971         (freeGString):
1972         (testJSCClass):
1973
1974 2019-03-20  Saam Barati  <sbarati@apple.com>
1975
1976         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1977         https://bugs.webkit.org/show_bug.cgi?id=195721
1978
1979         Reviewed by Filip Pizlo.
1980
1981         * Scripts/run-javascriptcore-tests:
1982
1983 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1984
1985         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1986         https://bugs.webkit.org/show_bug.cgi?id=196049
1987
1988         Reviewed by Tim Horton.
1989
1990         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1991         overflow scrolling in general, so rename it.
1992
1993         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1994
1995 2019-03-20  Daniel Bates  <dabates@apple.com>
1996
1997         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1998         https://bugs.webkit.org/show_bug.cgi?id=196031
1999         <rdar://problem/49078172>
2000
2001         Reviewed by Tim Horton.
2002
2003         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2004         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2005         same code path used when the Done button is pressed to dismiss the <select> picker.
2006
2007         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2008         (TestWebKitAPI::TEST):
2009
2010 2019-03-20  Chris Dumez  <cdumez@apple.com>
2011
2012         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2013         https://bugs.webkit.org/show_bug.cgi?id=196029
2014         <rdar://problem/48954651>
2015
2016         Reviewed by Tim Horton.
2017
2018         Add API test coverage.
2019
2020         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2021
2022 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2023
2024         [ews-build] Improve failure summary string for ApplyPatch step
2025         https://bugs.webkit.org/show_bug.cgi?id=195995
2026
2027         Reviewed by Alexey Proskuryakov.
2028
2029         * BuildSlaveSupport/ews-build/steps.py:
2030         (ApplyPatch.getResultSummary): Override getResultSummary.
2031
2032 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2033
2034         AX: Implement support for new meter ARIA role
2035         https://bugs.webkit.org/show_bug.cgi?id=195966
2036
2037         Reviewed by Chris Fleizach.
2038
2039         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2040         to AXLevelIndicator.
2041
2042         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2043
2044 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2045
2046         [WebAuthN] Implement FIDO AppID extension
2047         https://bugs.webkit.org/show_bug.cgi?id=143491
2048         <rdar://problem/48298273>
2049
2050         Reviewed by Brent Fulgham.
2051
2052         Add a test that covers the new flag of convertToU2fSignCommand.
2053
2054         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2055         (TestWebKitAPI::TEST):
2056         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2057         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2058         (TestWebKitAPI::TEST):
2059
2060 2019-03-19  Keith Rollin  <krollin@apple.com>
2061
2062         Add support for more platforms to generate-xcfilelists
2063         https://bugs.webkit.org/show_bug.cgi?id=195977
2064
2065         Reviewed by Alexey Proskuryakov.
2066
2067         generate-xcfilelists incorrectly complains when involved with building
2068         WebKit for iphonesimulator:
2069
2070             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2071             …
2072             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2073
2074         Address this by teaching generate-xcfilelists about more platforms.
2075
2076         * Scripts/generate-xcfilelists:
2077
2078 2019-03-19  John Wilander  <wilander@apple.com>
2079
2080         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2081         https://bugs.webkit.org/show_bug.cgi?id=195923
2082         <rdar://problem/49001272>
2083
2084         Reviewed by Alex Christensen.
2085
2086         This patch does the following to the TestRunner:
2087         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2088         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2089         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2090
2091         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2092         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2093         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2094         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2095         * WebKitTestRunner/TestController.cpp:
2096         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2097         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2098         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2099         * WebKitTestRunner/TestController.h:
2100         * WebKitTestRunner/TestInvocation.cpp:
2101         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2102
2103 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2104
2105         [CMake] Support more clang and gcc sanitizers
2106         https://bugs.webkit.org/show_bug.cgi?id=195956
2107
2108         Reviewed by Michael Catanzaro.
2109
2110         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2111
2112 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2113
2114         [ews-build] Improve summary for PrintConfiguration step
2115         https://bugs.webkit.org/show_bug.cgi?id=195945
2116
2117         Reviewed by Lucas Forschler.
2118
2119         * BuildSlaveSupport/ews-build/steps.py:
2120         (PrintConfiguration.getResultSummary): Override getResultSummary.
2121
2122 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2123
2124         [ews-build] Improve summary for CheckOutSource step
2125         https://bugs.webkit.org/show_bug.cgi?id=195963
2126
2127         Reviewed by Lucas Forschler.
2128
2129         * BuildSlaveSupport/ews-build/steps.py:
2130         (CheckOutSource.getResultSummary):
2131
2132 2019-03-19  Daniel Bates  <dabates@apple.com>
2133
2134         [iOS] Focus not preserved when switching between tabs
2135         https://bugs.webkit.org/show_bug.cgi?id=195820
2136         <rdar://problem/43614450>
2137
2138         Reviewed by Brent Fulgham.
2139
2140         Add tests to ensure that we restore focus when resigning and becoming first responder.
2141
2142         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2143         (TestWebKitAPI::TEST):
2144
2145 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2146
2147         Make WTFLogChannelState and WTFLogLevel enum classes
2148         https://bugs.webkit.org/show_bug.cgi?id=195904
2149
2150         Reviewed by Eric Carlson.
2151
2152         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2153         (TestWebKitAPI::TEST_F):
2154
2155 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2156
2157         [GStreamer][EME] Backported mssdemux protection data crash fix
2158         https://bugs.webkit.org/show_bug.cgi?id=195918
2159
2160         Reviewed by Philippe Normand.
2161
2162         * gstreamer/jhbuild.modules:
2163         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2164
2165 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2166
2167         Unreviewed, rolling out r243132.
2168
2169         Broke GTK build
2170
2171         Reverted changeset:
2172
2173         "Make WTFLogChannelState and WTFLogLevel enum classes"
2174         https://bugs.webkit.org/show_bug.cgi?id=195904
2175         https://trac.webkit.org/changeset/243132
2176
2177 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2178
2179         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2180
2181         * Scripts/webkitdirs.pm:
2182         (builtDylibPathForName): Adjust the shared library name that's changed
2183         with the API version bump in r243073.
2184
2185 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2186
2187         Make WTFLogChannelState and WTFLogLevel enum classes
2188         https://bugs.webkit.org/show_bug.cgi?id=195904
2189
2190         Reviewed by Eric Carlson.
2191
2192         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2193         (TestWebKitAPI::TEST_F):
2194
2195 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2196
2197         Disable flaky test added in r2431100
2198         https://webkit.org/b/195785
2199
2200         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2201         (TestWebKitAPI::TEST):
2202         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2203
2204 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2205
2206         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2207         https://bugs.webkit.org/show_bug.cgi?id=195916
2208
2209         Reviewed by Tim Horton.
2210
2211         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2212         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2213
2214 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2215
2216         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2217
2218         * Scripts/webkitpy/common/config/contributors.json:
2219
2220 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2221
2222         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2223         https://bugs.webkit.org/show_bug.cgi?id=195785
2224
2225         Reviewed by Geoffrey Garen.
2226
2227         * TestWebKitAPI/TCPServer.cpp: Added.
2228         (TestWebKitAPI::TCPServer::TCPServer):
2229         (TestWebKitAPI::TCPServer::~TCPServer):
2230         (TestWebKitAPI::TCPServer::socketBindListen):
2231         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2232         * TestWebKitAPI/TCPServer.h: Added.
2233         (TestWebKitAPI::TCPServer::port const):
2234         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2235         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2236         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2237         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2238         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2239         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2240         (TestWebKitAPI::respondSlowly):
2241         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2242         (TestWebKitAPI::downloadAtRate):
2243         (TestWebKitAPI::TEST):
2244
2245 2019-03-18  Saam Barati  <sbarati@apple.com>
2246
2247         Add a plan file for JetStream 2
2248         https://bugs.webkit.org/show_bug.cgi?id=190734
2249
2250         Reviewed by Mark Lam.
2251
2252         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2253
2254 2019-03-18  Chris Dumez  <cdumez@apple.com>
2255
2256         Delay WebProcess launch until a load is triggered in a Web view
2257         https://bugs.webkit.org/show_bug.cgi?id=195758
2258         <rdar://problem/48126013>
2259
2260         Reviewed by Geoff Garen.
2261
2262         Add API test coverage. Also update some existing API tests to not expect
2263         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2264
2265         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2266         (TestWebKitAPI::TEST):
2267         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2268         (TestWebKitAPI::TEST):
2269         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2270         (TEST):
2271         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2272         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2273         (TEST):
2274         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2275         (TEST):
2276         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2277
2278 2019-03-18  Xan Lopez  <xan@igalia.com>
2279
2280         [CMake] Prevent potential warning when determining $architecture
2281         https://bugs.webkit.org/show_bug.cgi?id=195891
2282
2283         Reviewed by Michael Catanzaro.
2284
2285         It's possible for generateBuildSystemForCMakeProject to be called
2286         before determineArchitecture() is ever called. This will make the
2287         first eq check with $architecture to be bogus (and print a
2288         warning). Change that to an eq check with architecture(), which
2289         implicitly calls determineArchitecture() if needed, and change all
2290         the other similar cases in the method in the same way to prevent
2291         future bugs like this one.
2292
2293         * Scripts/webkitdirs.pm:
2294         (generateBuildSystemFromCMakeProject):
2295
2296 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2297
2298         [WPE] Tarballs generated with “make dist” cannot build documentation
2299         https://bugs.webkit.org/show_bug.cgi?id=195885
2300
2301         Reviewed by Carlos Garcia Campos.
2302
2303         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2304
2305 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2306
2307         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2308         https://bugs.webkit.org/show_bug.cgi?id=195883
2309
2310         Reviewed by Carlos Garcia Campos.
2311
2312         * gtkdoc/gtkdoc.py:
2313         (GTKDoc._run_command): When commands fail to run, include the full command line for
2314         the program invocation and the output it has generated on the standard error stream.
2315
2316 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2317
2318         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2319         https://bugs.webkit.org/show_bug.cgi?id=195786
2320
2321         Reviewed by Philippe Normand.
2322
2323         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2324         * wpe/jhbuild.modules: Ditto.
2325
2326 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2327
2328         [ews-build] Don't run clean builds on EWS builders
2329         https://bugs.webkit.org/show_bug.cgi?id=195851
2330
2331         Reviewed by Geoffrey Garen.
2332
2333         * BuildSlaveSupport/ews-build/factories.py:
2334
2335 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2336
2337         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2338         https://bugs.webkit.org/show_bug.cgi?id=195849
2339
2340         Reviewed by Chris Dumez.
2341
2342         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2343
2344         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2345         (runWebsiteDataStoreCustomPaths):
2346
2347 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2348
2349         webkitpy: Upload test results
2350         https://bugs.webkit.org/show_bug.cgi?id=195755
2351         <rdar://problem/48896182>
2352
2353         Reviewed by Aakash Jain.
2354
2355         Establish a new format for uploading results that is not tied to layout tests, apply
2356         that format to webkitpy tests.
2357
2358         * Scripts/webkitpy/common/checkout/scm/git.py:
2359         (Git.native_branch): Return what branch the current checkout is on.
2360         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2361         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2362         * Scripts/webkitpy/common/checkout/scm/svn.py:
2363         (SVN.native_branch): Ditto.
2364         * Scripts/webkitpy/common/system/platforminfo.py:
2365         (PlatformInfo.build_version): Return a build version for Mac.
2366         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2367         (MockPlatformInfo.__init__):
2368         (MockPlatformInfo.build_version):
2369         * Scripts/webkitpy/results: Added.
2370         * Scripts/webkitpy/results/__init__.py: Added.
2371         * Scripts/webkitpy/results/options.py: Added.
2372         (upload_options): OptParse list for upload options.
2373         * Scripts/webkitpy/results/upload.py: Added.
2374         (Upload): Class which enforces the upload format expected by the results server.
2375         (Upload.Expectations):
2376         (Upload.create_configuration):
2377         (Upload.create_commit):
2378         (Upload.create_details):
2379         (Upload.create_run_stats):
2380         (Upload.create_test_result):
2381         (Upload.__init__):
2382         (Upload.Encoder): Encode Upload object as json.
2383         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2384         * Scripts/webkitpy/results/upload_unittest.py: Added.
2385         * Scripts/webkitpy/test/main.py:
2386         (Tester._parse_args): Add upload arguments.
2387         (Tester._run_tests): Allow results to be uploaded.
2388         * Scripts/webkitpy/test/runner.py:
2389         (Runner.__init__): Record which tests were run, rather than just counting them.
2390         (Runner.handle):
2391         * Scripts/webkitpy/test/runner_unittest.py:
2392         (RunnerTest.test_run):
2393         * Scripts/webkitpy/thirdparty/__init__.py:
2394         (AutoinstallImportHook.find_module): Add requests auto-install.
2395         (AutoinstallImportHook._install_requests):
2396         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2397         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2398
2399 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2400
2401         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2402         https://bugs.webkit.org/show_bug.cgi?id=195810
2403
2404         Reviewed by Tim Horton.
2405
2406         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2407         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2408         ending certain layout tests.
2409
2410         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2411         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2412         (-[TestRunnerWKWebView dealloc]):
2413         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2414
2415         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2416         helper method when destroying the web view, and when resetting state between tests.
2417
2418         * WebKitTestRunner/ios/TestControllerIOS.mm:
2419         (WTR::TestController::platformResetStateToConsistentValues):
2420
2421         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2422
2423 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2424
2425         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2426         https://bugs.webkit.org/show_bug.cgi?id=190350
2427         <rdar://problem/45089503>
2428
2429         Reviewed by Geoffrey Garen.
2430
2431         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2432         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2433         (TEST):
2434         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2435         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2436         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2437         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2438         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2439         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2440         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2441         (runTest):
2442         (createDirectories):
2443         (TEST):
2444         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2445         (TEST):
2446         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2447         (TEST):
2448
2449 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2450
2451         Add support to WebPage for getting the contents as an attributed string.
2452         https://bugs.webkit.org/show_bug.cgi?id=195636
2453         rdar://problem/45055697
2454
2455         Reviewed by Tim Horton.
2456
2457         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2458         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2459
2460 2019-03-15  Chris Dumez  <cdumez@apple.com>
2461
2462         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2463         https://bugs.webkit.org/show_bug.cgi?id=195747
2464
2465         Reviewed by Geoff Garen.
2466
2467         Add API test coverage.
2468
2469         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2470
2471 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2472
2473         Unreviewed, rolling out r242952.
2474
2475         Causing API failures on iOS Simulator
2476
2477         Reverted changeset:
2478
2479         "[PSON] Make sure the WebProcessCache is leverage when
2480         relaunching a process after termination"
2481         https://bugs.webkit.org/show_bug.cgi?id=195747
2482         https://trac.webkit.org/changeset/242952
2483
2484 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2485
2486         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2487         https://bugs.webkit.org/show_bug.cgi?id=195740
2488
2489         Reviewed by Ross Kirsling.
2490
2491         window.open doesn't work for WebKitBrowserWindow because it is not
2492         implemented yet.
2493
2494         1. Implemented createNewPage callback of WKPageUIClient.
2495         2. Changed MainWindow to take a BrowserWindow factory function
2496           instead of BrowserWindowType to be flexible to create
2497           BrowserWindow with extra settings.
2498         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2499           because it is not relevant with MainWindow anymore.
2500
2501         * MiniBrowser/win/Common.cpp:
2502         (parseCommandLine):
2503         * MiniBrowser/win/Common.h:
2504         (CommandLineOptions::CommandLineOptions):
2505         * MiniBrowser/win/MainWindow.cpp:
2506         (MainWindow::MainWindow):
2507         (MainWindow::create):
2508         (MainWindow::init):
2509         (MainWindow::WndProc):
2510         * MiniBrowser/win/MainWindow.h:
2511         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2512         (PrintWebUIDelegate::createWebViewWithRequest):
2513         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2514         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2515         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2516         (WebKitBrowserWindow::updateProxySettings):
2517         (WebKitBrowserWindow::createNewPage):
2518         * MiniBrowser/win/WebKitBrowserWindow.h:
2519         * MiniBrowser/win/WinMain.cpp:
2520         (wWinMain):
2521
2522 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2523
2524         Make it possible to test scrolling tree layer manipulation more easily
2525         https://bugs.webkit.org/show_bug.cgi?id=195780
2526
2527         Reviewed by Tim Horton.
2528         
2529         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2530         cuts off communication of scrolling tree scrolls back to the web process
2531         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2532         allows tests to trigger scrolls which run the scrolling tree layer positioning
2533         logic, but never get another commit from the web process that might mask
2534         scrolling tree bugs.
2535         
2536         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2537         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2538         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2539
2540         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2541         (WTR::UIScriptController::scrollUpdatesDisabled const):
2542         (WTR::UIScriptController::setScrollUpdatesDisabled):
2543         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2544         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2545         (WTR::UIScriptController::scrollUpdatesDisabled const):
2546         (WTR::UIScriptController::setScrollUpdatesDisabled):
2547         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2548         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2549         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2550         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2551         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2552         * WebKitTestRunner/ios/TestControllerIOS.mm:
2553         (WTR::TestController::platformResetStateToConsistentValues):
2554         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2555         (WTR::UIScriptController::scrollUpdatesDisabled const):
2556         (WTR::UIScriptController::setScrollUpdatesDisabled):
2557
2558 2019-03-14  Youenn Fablet  <youenn@apple.com>
2559
2560         Move IDB storage in private browsing mode to NetworkProcess
2561         https://bugs.webkit.org/show_bug.cgi?id=195602
2562
2563         Reviewed by Brady Eidson.
2564
2565         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2566         (TEST):
2567
2568 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2569
2570         [ews-build] Make descriptionDone messages more readable
2571         https://bugs.webkit.org/show_bug.cgi?id=195760
2572
2573         Reviewed by Lucas Forschler.
2574
2575         * BuildSlaveSupport/ews-build/steps.py:
2576         * BuildSlaveSupport/ews-build/steps_unittest.py:
2577
2578 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2579
2580         [ews-build] Generate status-bubble hover-over messages
2581         https://bugs.webkit.org/show_bug.cgi?id=195680
2582
2583         Reviewed by Lucas Forschler.
2584
2585         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2586         (StatusBubble):
2587         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2588         on hover-over.
2589         (StatusBubble._iso_time):
2590         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2591         hover-over message.
2592         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2593
2594 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2595
2596         [ews-app] Gracefully handle the case when state_string is None
2597         https://bugs.webkit.org/show_bug.cgi?id=195753
2598
2599         Reviewed by Lucas Forschler.
2600
2601         * BuildSlaveSupport/ews-app/ews/models/build.py:
2602         * BuildSlaveSupport/ews-app/ews/models/step.py:
2603
2604 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2605
2606         [ews-app] Status bubble display pending for currently running build step
2607         https://bugs.webkit.org/show_bug.cgi?id=195744
2608
2609         Reviewed by Lucas Forschler.
2610
2611         * BuildSlaveSupport/ews-build/events.py:
2612         (Events.stepStarted): If state_string is pending, replace it with step name.
2613
2614 2019-03-14  Chris Dumez  <cdumez@apple.com>
2615
2616         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2617         https://bugs.webkit.org/show_bug.cgi?id=195750
2618
2619         Reviewed by Geoffrey Garen.
2620
2621         Add API test coverage.
2622
2623         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2624         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2625         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2626         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2627
2628 2019-03-14  Chris Dumez  <cdumez@apple.com>
2629
2630         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2631         https://bugs.webkit.org/show_bug.cgi?id=195747
2632
2633         Reviewed by Geoff Garen.
2634
2635         Add API test coverage.
2636
2637         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2638
2639 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2640
2641         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2642         https://bugs.webkit.org/show_bug.cgi?id=195725
2643         <rdar://problem/48545062>
2644
2645         Reviewed by Tim Horton.
2646
2647         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2648         handler is nil.
2649
2650         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2651         (TestWebKitAPI::TEST):
2652
2653 2019-03-13  Sam Weinig  <sam@webkit.org>
2654
2655         Add utility function to allow easy reverse range-based iteration of a container
2656         https://bugs.webkit.org/show_bug.cgi?id=195542
2657
2658         Reviewed by Antti Koivisto.
2659
2660         * TestWebKitAPI/CMakeLists.txt:
2661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2662         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2663         (TestWebKitAPI::TEST):
2664         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2665
2666 2019-03-13  Chris Dumez  <cdumez@apple.com>
2667
2668         Use a ServiceWorker process per registrable domain
2669         https://bugs.webkit.org/show_bug.cgi?id=195649
2670
2671         Reviewed by Youenn Fablet.
2672
2673         Update API test coverage.
2674
2675         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2676
2677 2019-03-13  Chris Dumez  <cdumez@apple.com>
2678
2679         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2680         https://bugs.webkit.org/show_bug.cgi?id=195684
2681         <rdar://problem/48294714>
2682
2683         Reviewed by Antti Koivisto.
2684
2685         Add API test coverage.
2686
2687         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2688
2689 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2690
2691         [ews-app] Remove unused patch view
2692         https://bugs.webkit.org/show_bug.cgi?id=195669
2693
2694         Reviewed by Lucas Forschler.
2695
2696         * BuildSlaveSupport/ews-app/ews/urls.py:
2697         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2698
2699 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2700
2701         [ews-app] Use Buildbot result code variables
2702         https://bugs.webkit.org/show_bug.cgi?id=195668
2703
2704         Reviewed by Alexey Proskuryakov.
2705
2706         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2707         (Buildbot): Added Buildbot result code variables.
2708         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2709         (StatusBubble._build_bubble): Used Buildbot result code variables.
2710
2711 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2712
2713         [Flatpak] Expand submodule recursively
2714         https://bugs.webkit.org/show_bug.cgi?id=195672
2715
2716         Building WPE with flatpak was impossible without that as it was raising an exception.
2717         Also update wpebackend-fdo to match what is built in jhbuild
2718
2719         Reviewed by Philippe Normand.
2720
2721         * flatpak/flatpakutils.py:
2722         (expand_submodules_recurse):
2723         (expand_manifest):
2724         * flatpak/org.webkit.WPEModules.yaml:
2725
2726 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2727
2728         [ews-app] status bubble should be hidden for certain builds
2729         https://bugs.webkit.org/show_bug.cgi?id=194597
2730
2731         Reviewed by Dewei Zhu.
2732
2733         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2734         (StatusBubble._build_bubble):
2735         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2736         because the patch didn't have relevant changes.
2737         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2738         in production yet.
2739
2740 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2741
2742         [Win] Fix a slew of simple clang-cl warnings.
2743         https://bugs.webkit.org/show_bug.cgi?id=195652
2744
2745         Reviewed by Don Olmstead.
2746
2747         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2748         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2749
2750 2019-03-12  Justin Fan  <justin_fan@apple.com>
2751
2752         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2753         https://bugs.webkit.org/show_bug.cgi?id=195518
2754         <rdar://problem/46322356>
2755
2756         Reviewed by Myles C. Maxfield.
2757
2758         * DumpRenderTree/DerivedSources-input.xcfilelist:
2759         * DumpRenderTree/DerivedSources-output.xcfilelist:
2760
2761 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2762
2763         Unreviewed, rolling out r242825.
2764         https://bugs.webkit.org/show_bug.cgi?id=195648
2765
2766         "Broke webkitpy tests with my change to
2767         lldb_dump_class_layout.py" (Requested by rmorisset on
2768         #webkit).
2769
2770         Reverted changeset:
2771
2772         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2773         classes with suspicious padding"
2774         https://bugs.webkit.org/show_bug.cgi?id=195573
2775         https://trac.webkit.org/changeset/242825
2776
2777 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2778
2779         [ews-build] Show status bubbles while the patch is waiting in queue
2780         https://bugs.webkit.org/show_bug.cgi?id=195618
2781
2782         Reviewed by Lucas Forschler.
2783
2784         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2785         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2786         enabled in initial deployment.
2787         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2788         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2789         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2790         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2791         (StatusBubble._build_bubbles_for_patch):
2792
2793 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2794
2795         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2796         https://bugs.webkit.org/show_bug.cgi?id=195573
2797
2798         Reviewed by Simon Fraser.
2799
2800         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2801
2802         * Scripts/dump-class-layout:
2803         (main):
2804         * lldb/lldb_dump_class_layout.py:
2805         (ClassLayout.__init__):
2806         (ClassLayout._compute_padding_recursive):
2807         (LLDBDebuggerInstance.dump_layout_for_classname):
2808         (LLDBDebuggerInstance):
2809         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2810         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2811
2812 2019-03-12  Chris Dumez  <cdumez@apple.com>
2813
2814         Device Orientation access permission should be denied unless explicitly granted by the client
2815         https://bugs.webkit.org/show_bug.cgi?id=195625
2816
2817         Reviewed by Youenn Fablet.
2818
2819         add API test coverage.
2820
2821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2822         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2823         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2824         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2825         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2826         (runDeviceOrientationTest):
2827         (TEST):
2828         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2829         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2830
2831 2019-03-12  Jer Noble  <jer.noble@apple.com>
2832
2833         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2834         https://bugs.webkit.org/show_bug.cgi?id=195137
2835         <rdar://problem/48810307>
2836
2837         Reviewed by Eric Carlson.
2838
2839         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2840         (TestWebKitAPI::TEST):
2841
2842 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2843
2844         [ews-build] Change urls from uat to production
2845         https://bugs.webkit.org/show_bug.cgi?id=195566
2846
2847         Reviewed by Lucas Forschler.
2848
2849         * BuildSlaveSupport/ews-app/ews/config.py:
2850         * BuildSlaveSupport/ews-build/events.py:
2851         * BuildSlaveSupport/ews-build/steps.py:
2852
2853 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2854
2855         [ews-build] change max_builds for local-worker to 1
2856         https://bugs.webkit.org/show_bug.cgi?id=195568
2857
2858         Reviewed by Lucas Forschler.
2859
2860         * BuildSlaveSupport/ews-build/loadConfig.py:
2861
2862 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2863
2864         Fix the build
2865
2866         * TestRunnerShared/spi/PencilKitTestSPI.h:
2867         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2868
2869 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2870
2871         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2872         https://bugs.webkit.org/show_bug.cgi?id=194131
2873
2874         Reviewed by Michael Catanzaro.
2875
2876         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2877         (uriChanged):
2878         (testUnfinishedSubresourceLoad):
2879         (serverCallback):
2880         (beforeAll):
2881
2882 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2883
2884         WTF::Expected should use std::addressof instead of operator&
2885         https://bugs.webkit.org/show_bug.cgi?id=195604
2886
2887         Reviewed by Myles Maxfield.
2888
2889         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2890         (TestWebKitAPI::Unique::Unique):
2891         (TestWebKitAPI::Unique::operator&):
2892         (TestWebKitAPI::TEST):
2893
2894 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2895
2896         Add Optional to Forward.h.
2897         https://bugs.webkit.org/show_bug.cgi?id=195586
2898
2899         Reviewed by Darin Adler.
2900
2901         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2902         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2903         Remove unnecessary includes from headers.
2904
2905 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2906
2907         Add testing API to hit-test and scroll overflow scrollers
2908         https://bugs.webkit.org/show_bug.cgi?id=195278
2909
2910         Reviewed by Antti Koivisto.
2911         
2912         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2913         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2914         
2915         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2916
2917         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2918         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2919         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2920         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2921         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2922         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2923         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2924         (WTR::enclosingScrollViewIncludingSelf):
2925         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2926
2927 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2928
2929         API test WebKit.RequestTextInputContext fails on iOS
2930         https://bugs.webkit.org/show_bug.cgi?id=195585
2931
2932         Reviewed by Wenson Hsieh and Simon Fraser.
2933
2934         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2935         (applyStyle):
2936         (TEST):
2937         Add a viewport, so that the coordinates match up on iOS.
2938         Scroll by moving the UIScrollView's contentOffset.
2939
2940 2019-03-11  Chris Dumez  <cdumez@apple.com>
2941
2942         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2943         https://bugs.webkit.org/show_bug.cgi?id=195506
2944         <rdar://problem/48733477>
2945
2946         Reviewed by Alex Christensen.
2947
2948         Add API test coverage.
2949
2950         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2951
2952 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2953
2954         Adding myself to contributors.json
2955
2956         Unreviewed, addming myself to contributors.json .
2957
2958         * Scripts/webkitpy/common/config/contributors.json:
2959
2960 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2961
2962         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2963         https://bugs.webkit.org/show_bug.cgi?id=195511
2964         <rdar://problem/44873269>
2965
2966         Reviewed by Darin Adler.
2967
2968         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2969         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2970         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2971         (TEST_F):
2972
2973 2019-03-11  Chris Dumez  <cdumez@apple.com>
2974
2975         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2976         https://bugs.webkit.org/show_bug.cgi?id=195561
2977
2978         Reviewed by Youenn Fablet.
2979
2980         Make sure the JS in the test requests for permission to receive device orientation events.
2981
2982         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2983
2984 2019-03-11  Youenn Fablet  <youenn@apple.com>
2985
2986         Allow storage quota increase by default in WTR
2987         https://bugs.webkit.org/show_bug.cgi?id=195541
2988
2989         Reviewed by Geoffrey Garen.
2990
2991         Allow storage quota increase by default in WTR.
2992         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2993         Use this for tests that explicitly need cache increase.
2994
2995         Instead of increasing quota by 2, make sure the next request is
2996         granted by adding all given parameters.
2997
2998         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2999         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3000         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3001         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3002         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3003         * WebKitTestRunner/TestController.cpp:
3004         (WTR::TestController::setAllowStorageQuotaIncrease):
3005         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3006         * WebKitTestRunner/TestController.h:
3007         * WebKitTestRunner/TestInvocation.cpp:
3008         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3009         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3010         (WTR::TestController::cocoaResetStateToConsistentValues):
3011         (WTR::TestController::setAllowStorageQuotaIncrease):
3012         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3013         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3014         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3015
3016 2019-03-11  Xan Lopez  <xan@igalia.com>
3017
3018         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3019         https://bugs.webkit.org/show_bug.cgi?id=194147
3020
3021         Reviewed by Michael Saboff.
3022
3023         To make --32-bit work correctly on Linux/64bit we need to:
3024
3025         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3026         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3027         unfortunately CMake only allows us to do this during
3028         crosscompilation, which is overkill here.
3029         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3030         pkg-config detection module uses the x86 .pc files instead of the
3031         x86_64 ones.
3032         - Set the -m32 flags for the compiler.
3033
3034         * Scripts/webkitdirs.pm:
3035         (generateBuildSystemFromCMakeProject):
3036
3037 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3038
3039         Add MotionMark-1.1 plan file for run-benchmark script.
3040         https://bugs.webkit.org/show_bug.cgi?id=195481
3041
3042         Rubber-stamped by Darin Adler.
3043
3044         Run-benchmark script should support MontionMark-1.1.
3045
3046         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3047
3048 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3049
3050         [ews-app] Add support for submit-to-ews url
3051         https://bugs.webkit.org/show_bug.cgi?id=195477
3052
3053         Reviewed by Lucas Forschler.
3054
3055         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3056         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3057         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3058         * BuildSlaveSupport/ews-app/ews/urls.py:
3059         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3060
3061 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3062
3063         Unreviewed, rolling out r242688, r242643, r242624.
3064
3065         Caused multiple layout test failures and crashes on iOS and macOS.
3066
3067         Reverted changeset:
3068
3069         "requestAnimationFrame should execute before the next frame"
3070         https://bugs.webkit.org/show_bug.cgi?id=177484
3071         https://trac.webkit.org/changeset/242624/webkit
3072
3073         * Tracing/SystemTracePoints.plist:
3074
3075 2019-03-11  John Wilander  <wilander@apple.com>
3076
3077         Resource Load Statistics: Make it possible exclude localhost from classification
3078         https://bugs.webkit.org/show_bug.cgi?id=195474
3079         <rdar://problem/47520577>
3080
3081         Reviewed by Brent Fulgham.
3082
3083         This patch allows for localhost to be excluded from classification and
3084         treatment as a prevalent resource.
3085
3086         The WebKit Tools change adds a new function called
3087         testRunner.setStatisticsIsRunningTest() which can be used to control this
3088         behavior.
3089
3090         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3091         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3092         (WTR::TestRunner::setStatisticsIsRunningTest):
3093         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3094         * WebKitTestRunner/TestController.cpp:
3095         (WTR::TestController::setStatisticsIsRunningTest):
3096         * WebKitTestRunner/TestController.h:
3097         * WebKitTestRunner/TestInvocation.cpp:
3098         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3099
3100 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3101
3102         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3103         https://bugs.webkit.org/show_bug.cgi?id=195560
3104
3105         Reviewed by Lucas Forschler.
3106
3107         * BuildSlaveSupport/ews-build/master.cfg:
3108
3109 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3110
3111         Unreviewed, rolling out r242698.
3112
3113         API test crashes on bots.
3114
3115         Reverted changeset:
3116
3117         "Add a WKContentRuleList variant that uses copied memory
3118         instead of mmap'd shared memory for class A containerized
3119         apps"
3120         https://bugs.webkit.org/show_bug.cgi?id=195511
3121         https://trac.webkit.org/changeset/242698
3122
3123 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3124
3125         [WPE] Enable web process sandbox
3126         https://bugs.webkit.org/show_bug.cgi?id=195169
3127
3128         Reviewed by Daniel Bates.
3129
3130         * wpe/install-dependencies:
3131         * wpe/jhbuild.modules:
3132
3133 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3134
3135         [ews-app] Use port 17000 for worker communication
3136         https://bugs.webkit.org/show_bug.cgi?id=195558
3137
3138         Reviewed by Lucas Forschler.
3139
3140         * BuildSlaveSupport/ews-build/master.cfg:
3141
3142 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3143
3144         [ews-build] unit-tests fail when passwords.json is missing
3145         https://bugs.webkit.org/show_bug.cgi?id=195557
3146
3147         Reviewed by Lucas Forschler.
3148
3149         * BuildSlaveSupport/ews-build/loadConfig.py:
3150         (loadBuilderConfig):
3151         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3152         (ConfigDotJSONTest.test_configuration):
3153         * BuildSlaveSupport/ews-build/master.cfg:
3154
3155 2019-03-11  Truitt Savell  <tsavell@apple.com>
3156
3157         Unreviewed, rolling out r242702.
3158
3159         Broke High Sierra builders.
3160
3161         Reverted changeset:
3162
3163         "Add utility function to allow easy reverse range-based
3164         iteration of a container"
3165         https://bugs.webkit.org/show_bug.cgi?id=195542
3166         https://trac.webkit.org/changeset/242702
3167
3168 2019-03-11  Sam Weinig  <sam@webkit.org>
3169
3170         Add utility function to allow easy reverse range-based iteration of a container
3171         https://bugs.webkit.org/show_bug.cgi?id=195542
3172
3173         Reviewed by Antti Koivisto.
3174
3175         * TestWebKitAPI/CMakeLists.txt:
3176         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3177         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3178         (TestWebKitAPI::TEST):
3179         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3180
3181 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3182
3183         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3184         https://bugs.webkit.org/show_bug.cgi?id=195511
3185         <rdar://problem/44873269>
3186
3187         Reviewed by Darin Adler.
3188
3189         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3190         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3191         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3192         (TEST_F):
3193
3194 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3195
3196         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3197         https://bugs.webkit.org/show_bug.cgi?id=195499
3198
3199         Reviewed by Darin Adler.
3200
3201         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3202         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3203         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3204         (-[WKWebView synchronouslyFocusTextInputContext:]):
3205         (applyStyle):
3206         (applyIframe):
3207         (TEST):
3208         Add some tests for this SPI.
3209
3210 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3211
3212         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3213         https://bugs.webkit.org/show_bug.cgi?id=181151
3214
3215         Reviewed by Don Olmstead.
3216
3217         * TestWebKitAPI/CMakeLists.txt:
3218         * TestWebKitAPI/PlatformWin.cmake:
3219         Enable TestWTF RunLoop tests in all platforms.
3220
3221         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3222         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3223         (TestWebKitAPI::DerivedOneShotTimer::fired):
3224         (TestWebKitAPI::TEST):
3225         Only a few platforms support nested RunLoop.
3226
3227         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3228         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3229
3230 2019-03-10  David Quesada  <david_quesada@apple.com>
3231
3232         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3233         https://bugs.webkit.org/show_bug.cgi?id=152480
3234
3235         Reviewed by Chris Dumez.
3236
3237         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3238         there are no additional references to the process pool besides the one held by
3239         the download, waits for the download to finish (in the sense that the
3240         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3241         measure, also check that the process pool has been deallocated at the end of the
3242         test. The test wouldn't be meaningful if the process pool were still alive.
3243
3244         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3245         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3246         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3247             The download will be canceled because the delegate does not implement the
3248             method to decide the download's destination, so this is where we know the
3249             DownloadProxyMap is done with the DownloadProxy.
3250         (TEST):
3251
3252 2019-03-08  Chris Dumez  <cdumez@apple.com>
3253
3254         Add support for Device Orientation / Motion permission API
3255         https://bugs.webkit.org/show_bug.cgi?id=195329
3256         <rdar://problem/47645367>
3257
3258         Reviewed by Geoffrey Garen.
3259
3260         Add test infrastructure to help test the Device Orientation / Motion permission API.
3261
3262         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3263         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3264         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3265         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3266         * WebKitTestRunner/TestController.cpp:
3267         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3268         (WTR::TestController::createWebViewWithOptions):
3269         (WTR::TestController::resetStateToConsistentValues):
3270         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3271         * WebKitTestRunner/TestController.h:
3272         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3273         * WebKitTestRunner/TestInvocation.cpp:
3274         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3275
3276 2019-03-08  Saam barati  <sbarati@apple.com>
3277
3278         Add a compare-results script to compare benchmark results
3279         https://bugs.webkit.org/show_bug.cgi?id=195486
3280         <rdar://problem/48723397>
3281
3282         Reviewed by Geoffrey Garen.
3283
3284         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3285         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3286         to extend it to learn about our other benchmarks.
3287
3288         * Scripts/compare-results: Added.
3289         (readJSONFile):
3290         (detectJetStream2):
3291         (JetStream2Results):
3292         (detectSpeedometer2):
3293         (Speedometer2Results):
3294         (detectPLT5):
3295         (PLT5Results):
3296         (detectBenchmark):
3297         (biggerIsBetter):
3298         (ttest):
3299         (getOptions):
3300         (main):
3301
3302 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3303
3304         Ensure old tab state is cleared between iterations of run-benchmark
3305         https://bugs.webkit.org/show_bug.cgi?id=195393
3306         <rdar://problem/46885583>
3307
3308         Reviewed by Dewei Zhu.
3309
3310         a) ensure the default to restore state is not set
3311         b) terminate Safari correctly
3312         c) Set the system default to ignore Persistent State in Safari
3313
3314         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3315         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3316         (OSXBrowserDriver.prepare_env): 
3317         (OSXBrowserDriver.restore_env):
3318         (OSXBrowserDriver.close_browsers):
3319         (OSXBrowserDriver._terminate_processes):
3320         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3321         (OSXChromeDriver):
3322         (OSXChromeCanaryDriver):
3323         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3324         (OSXFirefoxDriver):
3325         (OSXFirefoxNightlyDriver):
3326         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3327         (OSXSafariDriver):
3328         (OSXSafariDriver.prepare_env):
3329
3330 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3331
3332         [GTK] Several InputMethodFilter tests are failing
3333         https://bugs.webkit.org/show_bug.cgi?id=195408
3334
3335         Reviewed by Carlos Garcia Campos.
3336
3337         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3338         Regressed in r241751.
3339         Hexadecimal values of keycodes are expressed now in upper letters.
3340         Composited characters should be cast to UTF8 strings.
3341
3342         (TestWebKitAPI::TEST):
3343
3344 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3345
3346         [GTK] Make Tools/gtkdoc python3 compatible
3347         https://bugs.webkit.org/show_bug.cgi?id=195359
3348
3349         Reviewed by Carlos Garcia Campos.
3350
3351         * gtkdoc/generate-gtkdoc:
3352         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3353         work with Python 2 and 3.
3354         (get_gtkdoc_module_paths):
3355         The iteritems() was removed in Python 3, so let's use items() that's
3356         available in Python 2 and 3.
3357         (get_generator_for_config):
3358         * gtkdoc/gtkdoc.py:
3359         (GTKDoc._run_command):
3360         The sys.stdout.write() is expecting str in Python 3 and not bytes
3361         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3362         for passing the bytes there.
3363
3364 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3365
3366         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3367         https://bugs.webkit.org/show_bug.cgi?id=195346
3368         <rdar://problem/48667048>
3369
3370         Unreviewed build fix for clang-cl.
3371
3372         * DumpRenderTree/win/DumpRenderTree.cpp:
3373         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3374
3375 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3376
3377         requestAnimationFrame should execute before the next frame
3378         https://bugs.webkit.org/show_bug.cgi?id=177484
3379
3380         Reviewed by Simon Fraser.
3381
3382         Add trace points for the page RenderingUpdate.
3383
3384         * Tracing/SystemTracePoints.plist:
3385
3386 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3387
3388         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3389         https://bugs.webkit.org/show_bug.cgi?id=195353
3390         <rdar://problem/48626394>
3391
3392         Reviewed by Simon Fraser.
3393
3394         * WebKitTestRunner/ios/TestControllerIOS.mm:
3395         (WTR::TestController::platformResetPreferencesToConsistentValues):
3396
3397 2019-03-07  John Wilander  <wilander@apple.com>
3398
3399         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3400         https://bugs.webkit.org/show_bug.cgi?id=195383
3401         <rdar://problem/48570136>
3402
3403         Reviewed by Brent Fulgham.
3404
3405         This patch adds test infrastructure to purge only script-accessible cookies,
3406         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3407
3408         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3409         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3410         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3411         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3412         * WebKitTestRunner/TestController.cpp:
3413         (WTR::TestController::statisticsDeleteCookiesForHost):
3414         * WebKitTestRunner/TestController.h:
3415         * WebKitTestRunner/TestInvocation.cpp:
3416         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3417
3418 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3419
3420         Unreviewed, rolling out r242354.
3421         https://bugs.webkit.org/show_bug.cgi?id=195402
3422
3423         breaks layout tests in all configurations (Requested by
3424         zdobersek on #webkit).
3425
3426         Reverted changeset:
3427
3428         "[WPE] Enable web process sandbox"
3429         https://bugs.webkit.org/show_bug.cgi?id=195169
3430         https://trac.webkit.org/changeset/242354
3431
3432 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3433
3434         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3435         https://bugs.webkit.org/show_bug.cgi?id=195346
3436
3437         Reviewed by Fujii Hironori.
3438
3439         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3440         (TestWebKitAPI::TEST):
3441         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3442
3443         * DumpRenderTree/win/DumpRenderTree.cpp:
3444         (findFontFallback):
3445         (addFontFallbackIfPresent):
3446         (removeFontFallbackIfPresent):
3447         (main):
3448         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3449         (TestWebKitAPI::Util::moduleDirectory):
3450         (TestWebKitAPI::Util::createInjectedBundlePath):
3451         Use wchar helpers as needed.
3452
3453 2019-03-06  Rob Buis  <rbuis@igalia.com>
3454
3455         Consider supporting the `referrerpolicy` attribute.
3456         https://bugs.webkit.org/show_bug.cgi?id=179053
3457
3458         Reviewed by Darin Adler.
3459
3460         Add a runtime flag for referrerpolicy attribute.
3461
3462         * DumpRenderTree/mac/DumpRenderTree.mm:
3463         (enableExperimentalFeatures):
3464
3465 2019-03-05  Daniel Bates  <dabates@apple.com>
3466
3467         Update expected API test result following r242379
3468         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3469
3470         Update expected x-coordinate of selection rect now that the left padding of
3471         a textarea is sized in ems (so dependent on the font size) just like the left
3472         padding of a text field.
3473
3474         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3475         (TestWebKitAPI::TEST):
3476
3477 2019-03-05  David Quesada  <david_quesada@apple.com>
3478
3479         [WK2] It should be possible to follow links with 'download' attributes
3480         https://bugs.webkit.org/show_bug.cgi?id=195145
3481         rdar://problem/48462642
3482
3483         Reviewed by Alex Christensen.
3484
3485         Add a unit test to verify that activating links with 'download' attributes now
3486         navigates to the linked resource, rather than starts downloading it. Add another
3487         to verify that it is still possible to explicitly download the link via the
3488         'Download' navigation action policy.
3489
3490         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3491         (-[DownloadAttributeTestDelegate init]):
3492         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3493         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3494         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3495         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3496         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3497         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3498         (TEST):
3499         * WebKitTestRunner/TestController.cpp:
3500         (WTR::TestController::decidePolicyForNavigationAction):
3501         * WebKitTestRunner/TestController.h:
3502
3503 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3504
3505         [Curl] Implement Cookie Accept Policy.
3506         https://bugs.webkit.org/show_bug.cgi?id=191645
3507
3508         Reviewed by Fujii Hironori.
3509
3510         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3511         (TestWebKitAPI::Curl::TEST_F):
3512
3513 2019-03-05  Youenn Fablet  <youenn@apple.com>
3514
3515         Rename requestCacheStorageSpace to requestStorageSpace
3516         https://bugs.webkit.org/show_bug.cgi?id=195282
3517
3518         Reviewed by Chris Dumez.
3519
3520         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3521         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3522         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3523
3524 2019-03-05  Brady Eidson  <beidson@apple.com>
3525
3526         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3527         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3528
3529         Reviewed by Tim Horton.
3530
3531         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3532         different directory into that same WKWebView should work.
3533
3534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3535         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3536
3537 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3538
3539         Add WeakHashSet
3540         https://bugs.webkit.org/show_bug.cgi?id=195152
3541
3542         Reviewed by Antti Koivisto.
3543
3544         Added tests for WeakHashSet.
3545
3546         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3547         (TestWebKitAPI::Base::Base): Moved.
3548         (TestWebKitAPI::Derived::foo): Moved.
3549         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3550         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3551         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3552         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3553
3554 2019-03-04  Chris Dumez  <cdumez@apple.com>
3555
3556         Do not share WebProcesses between private and regular sessions
3557         https://bugs.webkit.org/show_bug.cgi?id=195189
3558         <rdar://problem/48421064>
3559
3560         Reviewed by Alex Christensen.
3561
3562         Add API test coverage.
3563
3564         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3565         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3566
3567 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3568
3569         [WPE] Enable web process sandbox
3570         https://bugs.webkit.org/show_bug.cgi?id=195169
3571
3572         Reviewed by Daniel Bates.
3573
3574         * wpe/install-dependencies:
3575         * wpe/jhbuild.modules:
3576
3577 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3578
3579         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3580         https://bugs.webkit.org/show_bug.cgi?id=195206
3581
3582         Reviewed by Žan Doberšek.
3583
3584         Add a new test case.
3585
3586         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3587         (testJSCClass):
3588
3589 2019-03-04  Charlie Turner  <cturner@igalia.com>
3590
3591         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3592         https://bugs.webkit.org/show_bug.cgi?id=194898
3593
3594         Reviewed by Žan Doberšek.
3595
3596         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3597         a GCC extension that permits arithmetic on void* pointer. Inline
3598         the macro until this issue is fixed upstream.
3599
3600 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3601
3602         Rid the world of WK_API_ENABLED
3603         https://bugs.webkit.org/show_bug.cgi?id=195263
3604
3605         Reviewed by Dan Bernstein.
3606
3607         List of changed files elided because it's useless.
3608
3609 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3610
3611         Unreviewed follow-up to r242292.
3612
3613         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3614
3615         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3616         (TestWebKitAPI::testStrip): Renamed from strip.
3617         (TestWebKitAPI::TEST):
3618
3619 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3620
3621         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3622
3623         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3624         and bug #194272 for details.
3625
3626         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3627
3628 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3629
3630         Remove some more unused 32-bit code
3631         https://bugs.webkit.org/show_bug.cgi?id=195255
3632
3633         Reviewed by Darin Adler.
3634
3635         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3636         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3637         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3638         (NPP_New):
3639         (NPP_HandleEvent):
3640         (handleEventCarbon): Deleted.
3641
3642 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3643
3644         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3645
3646         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3647         (TestWebKitAPI::TEST):
3648
3649 2019-03-01  Darin Adler  <darin@apple.com>
3650
3651         Finish removing String::format
3652         https://bugs.webkit.org/show_bug.cgi?id=194893
3653
3654         Reviewed by Daniel Bates.
3655 '
3656         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3657
3658 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3659
3660         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3661         https://bugs.webkit.org/show_bug.cgi?id=195229
3662         <rdar://problem/48520362>
3663
3664         Reviewed by Chris Dumez.
3665
3666         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3667         (TEST):
3668
3669 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3670
3671         Add a system trace scope for event region building
3672         https://bugs.webkit.org/show_bug.cgi?id=195226
3673
3674         Reviewed by Jon Lee.
3675
3676         This trace scope measures the time spend converting element rects into Region objects,
3677         which can be large on some pages.
3678
3679         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3680
3681         * Tracing/SystemTracePoints.plist:
3682
3683 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3684
3685         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3686         https://bugs.webkit.org/show_bug.cgi?id=194612
3687
3688         Reviewed by Alex Christensen.
3689
3690         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3691         Just test the new string-processing function and don't touch the actual environment.
3692         (Test cases are all as before, but based on operator== instead of strcmp.)
3693
3694 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3695
3696         [ews-app] Update primary keys for handling multiple Buildbot instances
3697         https://bugs.webkit.org/show_bug.cgi?id=195120
3698
3699         Reviewed by Stephanie Lewis.
3700
3701         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3702         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3703         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3704
3705         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3706         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3707         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3708         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3709         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3710         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3711
3712 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3713
3714         [WinCairo] Enable service worker
3715         https://bugs.webkit.org/show_bug.cgi?id=188318
3716
3717         Reviewed by Youenn Fablet.
3718
3719         * DumpRenderTree/DumpRenderTreePrefix.h:
3720         * TestWebKitAPI/PlatformWin.cmake:
3721         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3722         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3723         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3724
3725 2019-03-01  Justin Fan  <justin_fan@apple.com>
3726
3727         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3728         https://bugs.webkit.org/show_bug.cgi?id=195191
3729
3730         Rubber-stamped by Dean Jackson.
3731
3732         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3733
3734         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3735
3736 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3737
3738         Unreviewed, fix lldb webkitpy tests
3739         https://bugs.webkit.org/show_bug.cgi?id=194375
3740
3741         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3742
3743         * lldb/lldb_webkit.py:
3744         (WTFStringImplProvider.is_8bit):
3745
3746 2019-02-28  David Quesada  <david_quesada@apple.com>
3747
3748         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3749         https://bugs.webkit.org/show_bug.cgi?id=195121
3750         rdar://problem/48450302
3751
3752         Reviewed by Alex Christensen.
3753
3754         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3755         configurations where the 'download' attribute is absent, blank, or populated
3756         with a filename, and where the anchor element is same-origin or cross-origin
3757         (meaning the 'download' attribute shouldn't be honored).
3758
3759         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3760         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3761         (-[NavigationActionTestDelegate init]):
3762         (-[NavigationActionTestDelegate navigationAction]):
3763         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3764         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3765         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3766         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3767         (TEST):
3768
3769 2019-02-28  Antoine Quint  <graouts@apple.com>
3770
3771         Enable the Pointer Events runtime flag by default
3772         https://bugs.webkit.org/show_bug.cgi?id=195156
3773
3774         Reviewed by Dean Jackson.
3775
3776         * DumpRenderTree/mac/DumpRenderTree.mm:
3777         (enableExperimentalFeatures):
3778
3779 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3780
3781         Several PasteImage API tests are flaky
3782         https://bugs.webkit.org/show_bug.cgi?id=195160
3783
3784         Reviewed by Tim Horton.
3785
3786         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3787         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3788         listening for a "load" event after image load is already complete.
3789
3790         To address this, make these tests first register a "load" event handler, then run script to insert an image
3791         element into the document, and finally wait until the load event is observed before checking image size.
3792
3793         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3794
3795 2019-02-28  Chris Dumez  <cdumez@apple.com>
3796
3797         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3798         https://bugs.webkit.org/show_bug.cgi?id=195107
3799
3800         Reviewed by Alex Christensen.
3801
3802         Give some time for the zoom level to get restored.
3803
3804         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3805
3806 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3807
3808         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3809         https://bugs.webkit.org/show_bug.cgi?id=194958
3810
3811         Reviewed by Geoffrey Garen.
3812
3813         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3814         (TEST):
3815
3816 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3817
3818         [ews-app] Update method to save build to handle builder_display_name
3819         https://bugs.webkit.org/show_bug.cgi?id=195047
3820
3821         Reviewed by Dewei Zhu.
3822
3823         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3824         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3825
3826 2019-02-28  Justin Fan  <justin_fan@apple.com>
3827
3828         [Web GPU] Enable Web GPU only on 64-bit
3829         https://bugs.webkit.org/show_bug.cgi?id=195139
3830
3831         Because Metal is only supported on 64 bit apps.
3832
3833         Unreviewed build fix.
3834
3835         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3836
3837 2019-02-27  Youenn Fablet  <youenn@apple.com>
3838
3839         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3840         https://bugs.webkit.org/show_bug.cgi?id=194959
3841
3842         Reviewed by Chris Dumez.
3843
3844         Spin loop until getting the condition to remove flakiness.
3845
3846         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3847
3848 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3849
3850         [ews-build] Buildbot should include builder_display_name in the build events
3851         https://bugs.webkit.org/show_bug.cgi?id=195045
3852
3853         Reviewed by Dewei Zhu.
3854
3855         * BuildSlaveSupport/ews-build/events.py:
3856         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3857         buildername to builder_name to be consistent in naming style.
3858         (Events.buildFinished): Ditto.
3859
3860 2019-02-27  Chris Dumez  <cdumez@apple.com>
3861
3862         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3863         https://bugs.webkit.org/show_bug.cgi?id=194480
3864
3865         Reviewed by Brady Eidson.
3866
3867         Update existing API test to make it more likely to reproduce the issue.
3868
3869         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3870
3871 2019-02-27  Brady Eidson  <beidson@apple.com>
3872
3873         Universal links from Google search results pages don't open the app.
3874         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3875
3876         Reviewed by Geoffrey Garen.
3877
3878         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3879         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3880         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3881         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3882
3883 2019-02-27  Chris Dumez  <cdumez@apple.com>
3884
3885         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3886         https://bugs.webkit.org/show_bug.cgi?id=195102
3887
3888         Reviewed by Geoffrey Garen.
3889
3890         If the number of processes is not yet what we expect, wait a bit and check again to give
3891         processes some time to exit.
3892
3893         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3894
3895 2019-02-27  Chris Dumez  <cdumez@apple.com>
3896
3897         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3898         https://bugs.webkit.org/show_bug.cgi?id=194545
3899
3900         Reviewed by Brady Eidson.
3901
3902         Make sure the test navigates forward and then back only once. Previously, navigating
3903         back would trigger a navigation again in a timer.
3904
3905         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3906
3907 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3908
3909         High Sierra Debug JSC test queue should use faster hardware
3910         https://bugs.webkit.org/show_bug.cgi?id=194603
3911
3912         Rubber-stamped by Alexey Proskuryakov.
3913
3914         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3915
3916         * BuildSlaveSupport/build.webkit.org-config/config.json:
3917         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3918         (BubbleQueueServer):
3919         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3920         (WebKitBuildbot):
3921         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3922         * QueueStatusServer/config/queues.py:
3923         * Scripts/webkitpy/common/config/ews.json:
3924         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3925         (test_ews_name):
3926
3927 2019-02-27  John Wilander  <wilander@apple.com>
3928
3929         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3930         https://bugs.webkit.org/show_bug.cgi?id=195071
3931         <rdar://problem/48417690>
3932
3933         Reviewed by Alex Christensen and Brent Fulgham.
3934
3935         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3936         (TestWebKitAPI::createURL):
3937             Convenience function.
3938         (TestWebKitAPI::TEST):
3939             WebCore::AdClickAttribution now takes a URL when creating Source and
3940             Destination.
3941         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3942         (TestWebKitAPI::TEST):
3943             WebCore::AdClickAttribution now takes a URL when creating Source and
3944             Destination.
3945
3946 2019-02-27  Antoine Quint  <graouts@apple.com>
3947
3948         Support Pointer Events on macOS
3949         https://bugs.webkit.org/show_bug.cgi?id=195008
3950         <rdar://problem/47454419>
3951
3952         Reviewed by Dean Jackson.
3953
3954         * DumpRenderTree/mac/DumpRenderTree.mm:
3955         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3956         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3957
3958 2019-02-26  Mark Lam  <mark.lam@apple.com>
3959
3960         Remove remaining poisoning code.
3961         https://bugs.webkit.org/show_bug.cgi?id=194138
3962
3963         Reviewed by Saam Barati.
3964
3965         * TestWebKitAPI/CMakeLists.txt:
3966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3967         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3968         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3969         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3970         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3971         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3972         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3973
3974 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3975
3976         Move ephemeral local storage from WebProcess to UIProcess
3977         https://bugs.webkit.org/show_bug.cgi?id=195074
3978         <rdar://problem/47937975>
3979
3980         Reviewed by Geoff Garen.
3981
3982         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3983
3984 2019-02-20  Jer Noble  <jer.noble@apple.com>
3985
3986         [Cocoa] Media elements will restart network buffering just before suspending
3987         https://bugs.webkit.org/show_bug.cgi?id=193691
3988
3989         Reviewed by Eric Carlson.
3990
3991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3992         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3993         (TEST):
3994
3995 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3996
3997         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3998         https://bugs.webkit.org/show_bug.cgi?id=191652
3999
4000         Reviewed by Alex Christensen.
4001
4002         Fix WinCairo MiniBrowser behavior of authentication dialog.
4003
4004         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4005         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4006
4007 2019-02-26  Youenn Fablet  <youenn@apple.com>
4008
4009         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4010         https://bugs.webkit.org/show_bug.cgi?id=195028
4011         <rdar://problem/48243733>
4012
4013         Reviewed by Eric Carlson.
4014
4015         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4016
4017 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4018
4019         [WPE] Add API for webview background color configuration
4020         https://bugs.webkit.org/show_bug.cgi?id=192305
4021
4022         Reviewed by Michael Catanzaro.
4023
4024         * MiniBrowser/wpe/main.cpp:
4025         (main): Add a new option to configure the webview background
4026         color. Example: --bg-color=transparent.
4027         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4028         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4029         (beforeAll): Ditto.
4030
4031 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4032
4033         scalableNativeWebpageParameters() is not preserved on new page navigation.
4034         https://bugs.webkit.org/show_bug.cgi?id=194892
4035         <rdar://problem/47538280>
4036
4037         Reviewed by Wenson Hsieh.
4038         
4039         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4040
4041         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4042         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4043         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4044         (WTR::UIScriptController::allowsViewportShrinkToFit):
4045         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4046         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4047         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4048         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4049         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4050         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4051
4052 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4053
4054         [ews-app] Add model for handling multiple Buildbot instances
4055         https://bugs.webkit.org/show_bug.cgi?id=194863
4056
4057         Reviewed by Stephanie Lewis.
4058
4059         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4060
4061 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4062
4063         [ews-app] Remove BuilderMapping table
4064         https://bugs.webkit.org/show_bug.cgi?id=194961
4065
4066         Reviewed by Stephanie Lewis.
4067
4068         Store builder name directly in build table, instead of having a separate
4069         table for it.
4070
4071         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4072         * BuildSlaveSupport/ews-app/ews/models/build.py:
4073         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4074         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4075
4076 2019-02-25  John Wilander  <wilander@apple.com>
4077
4078         Introduce and adopt new class RegistrableDomain for eTLD+1
4079         https://bugs.webkit.org/show_bug.cgi?id=194791
4080         <rdar://problem/48179240>
4081
4082         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4083
4084         This patch adds an API test and replaces two instances of
4085         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4086
4087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4088         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4089         (TestWebKitAPI::TEST):
4090             Changed two strings to make sure the registrable domains are still considered
4091             invalid and pass the test.
4092         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4093         (TestWebKitAPI::TEST):
4094         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4095         (WTR::InjectedBundle::didReceiveMessageToPage):
4096
4097 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4098
4099         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4100         https://bugs.webkit.org/show_bug.cgi?id=195001
4101
4102         Reviewed by Carlos Garcia Campos.
4103
4104         API version 1.0 always includes the functionality previously guarded with
4105         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4106         unconditionally.
4107
4108         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4109         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4110         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4111         (WebViewTest::showInWindow): Ditto.
4112         (WebViewTest::hideView): Ditto.
4113         * wpe/backends/HeadlessViewBackend.cpp:
4114         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4115         * wpe/backends/ViewBackend.cpp:
4116         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4117         * wpe/backends/WindowViewBackend.cpp:
4118         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4119         WPE_BACKEND_CHECK_VERSION().
4120         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4121
4122 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4123
4124         [Flatpak] Add support for flatpak > 1.1.2
4125         https://bugs.webkit.org/show_bug.cgi?id=194088
4126
4127         Flatpak 1.2 is now out so we need to support that
4128         version now.
4129
4130         Reviewed by Michael Catanzaro.
4131
4132         * flatpak/flatpakutils.py:
4133         (check_flatpak):
4134         (FlatpakPackages.__init__):
4135         (FlatpakPackages.__detect_packages):
4136         (FlatpakPackages.__detect_packages.in):
4137         (FlatpakRepos.update):
4138
4139 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4140
4141         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4142         https://bugs.webkit.org/show_bug.cgi?id=194998
4143
4144         Reviewed by Carlos Garcia Campos.
4145
4146         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4147         to a Git checkout and using the latest commit containing various fixes
4148         and improvements.
4149
4150 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4151
4152         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4153         https://bugs.webkit.org/show_bug.cgi?id=194981
4154
4155         Reviewed by Žan Doberšek.
4156
4157         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4158         (TestWebKitAPI::TEST):
4159
4160 2019-02-23  Keith Miller  <keith_miller@apple.com>
4161
4162         Add new mac target numbers
4163         https://bugs.webkit.org/show_bug.cgi?id=194955
4164
4165         Reviewed by Tim Horton.
4166
4167         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4168         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4169         * MiniBrowser/Configurations/Base.xcconfig:
4170         * TestWebKitAPI/Configurations/Base.xcconfig:
4171         * WebKitTestRunner/Configurations/Base.xcconfig:
4172
4173 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4174
4175         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4176         https://bugs.webkit.org/show_bug.cgi?id=194846
4177
4178         Reviewed by Don Olmstead.
4179
4180         Added _search_paths() and _port_specific_expectations_files() for
4181         WinCairoPort.
4182
4183         * Scripts/webkitpy/port/win.py:
4184         (WinCairoPort.default_baseline_search_path):
4185         (WinCairoPort):
4186         (WinCairoPort._port_specific_expectations_files):
4187         (WinCairoPort._search_paths):
4188
4189 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4190
4191         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4192         https://bugs.webkit.org/show_bug.cgi?id=194963
4193
4194         Reviewed by Dean Jackson.
4195
4196         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4197         Do a `contains` check instead of `equals`, because in debug builds we
4198         put the GraphicsLayer pointer in a prefix.
4199
4200 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4201
4202         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4203         https://bugs.webkit.org/show_bug.cgi?id=194873
4204         <rdar://problem/46701974>
4205
4206         Reviewed by Tim Horton.
4207
4208         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4209
4210         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4211         (WTR::UIScriptController::menuRect const):
4212         (WTR::UIScriptController::isShowingMenu const):
4213         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4214         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4215         (WTR::UIScriptController::menuRect const):
4216
4217         Add a function to query the bounds of the callout menu in content coordinates.
4218
4219         (WTR::UIScriptController::isShowingMenu const):
4220
4221         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4222
4223         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4224         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4225         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4226         (WTR::UIScriptController::rectForMenuAction const):
4227         (WTR::UIScriptController::menuRect const):
4228         (WTR::UIScriptController::isShowingMenu const):
4229         (WTR::findViewInHierarchyOfType): Deleted.
4230
4231 2019-02-22  Chris Dumez  <cdumez@apple.com>
4232
4233         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4234         https://bugs.webkit.org/show_bug.cgi?id=194954
4235         <rdar://problem/48127957>
4236
4237         Reviewed by Alex Christensen.
4238
4239         Add API test coverage.
4240
4241         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4242         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4243         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4244         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4245
4246 2019-02-22  Chris Dumez  <cdumez@apple.com>
4247
4248         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4249         https://bugs.webkit.org/show_bug.cgi?id=194924
4250         <rdar://problem/48216125>
4251
4252         Reviewed by Geoffrey Garen.
4253
4254         Add API test coverage.
4255
4256         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4257
4258 2019-02-22  Chris Dumez  <cdumez@apple.com>
4259
4260         Unreviewed, disable API test added in r241928 on iOS.
4261
4262         The cache is not enabled on devices with less than 3GB of RAM.
4263
4264         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4265
4266 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4267
4268         Hardcode Visual Viewports on everywhere except iOS WK1
4269         https://bugs.webkit.org/show_bug.cgi?id=194928
4270
4271         Reviewed by Zalan Bujtas.
4272
4273         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4274         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4275         set it to false. The setting has shipped for several years and there's no need to turn
4276         it off now.
4277
4278         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4279         Visual Viewports are not enabled.
4280         
4281         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4282         that only runs in WK2
4283
4284         * MiniBrowser/mac/SettingsController.h:
4285         * MiniBrowser/mac/SettingsController.m:
4286         (-[SettingsController init]):
4287         (-[SettingsController _populateMenu]):
4288         (-[SettingsController validateMenuItem:]):
4289         (-[SettingsController visualViewportEnabled]): Deleted.
4290         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4291         * MiniBrowser/mac/WK1BrowserWindowController.m:
4292         (-[WK1BrowserWindowController didChangeSettings]):
4293         * MiniBrowser/mac/WK2BrowserWindowController.m:
4294         (-[WK2BrowserWindowController didChangeSettings]):
4295
4296 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4297
4298         Discard cached processes when clearing website data store
4299         https://bugs.webkit.org/show_bug.cgi?id=194894
4300
4301         Reviewed by Chris Dumez.
4302
4303         Added a test case.
4304
4305         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4306         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4307
4308 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4309
4310         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4311         https://bugs.webkit.org/show_bug.cgi?id=194914
4312         <rdar://problem/47586889>
4313
4314         Reviewed by Geoffrey Garen.
4315
4316         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4317         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4318         (TEST):
4319         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4320
4321 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4322
4323         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4324         <https://webkit.org/b/194761>
4325
4326         Reviewed by Myles Maxfield.
4327
4328         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4329         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4330         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4331         to use ARC-compliant cast.
4332         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4333         ARC-compliant cast.
4334         (WTR::installFakeHelvetica): Log `error` to console if
4335         CTFontManagerRegisterFontsForURL() fails, but only on supported
4336         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4337         Call CFRelease() on `error` to fix the leak.  Update to use
4338         ARC-compliant cast.
4339         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4340         cast.
4341
4342 2019-02-21  Chris Dumez  <cdumez@apple.com>
4343
4344         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4345         https://bugs.webkit.org/show_bug.cgi?id=194481
4346
4347         Reviewed by Alex Christensen.
4348
4349         Give the processes a chance to shutdown and wait until we reached the expected number
4350         of processes.
4351
4352         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4353
4354 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4355
4356         Fix the macOS build
4357
4358         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4359
4360 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4361
4362         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4363
4364         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4365         I am a backwards.
4366
4367 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4368
4369        &nbs