Add plumbing for a compatibility mode preference in WebKit
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Add plumbing for a compatibility mode preference in WebKit
4         https://bugs.webkit.org/show_bug.cgi?id=196005
5
6         Reviewed by Tim Horton.
7
8         Add new API tests.
9
10         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
12
13 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
14
15         [WPE][GTK] Update libsrtp dependency package for Debian
16         https://bugs.webkit.org/show_bug.cgi?id=196528
17
18         Reviewed by Frédéric Wang.
19
20         * gtk/install-dependencies:
21         * wpe/install-dependencies:
22
23 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
24
25         [WK2] Add support for Window's beforeprint / afterprint events
26         https://bugs.webkit.org/show_bug.cgi?id=196478
27         <rdar://problem/49535124>
28
29         Unreviewed build fix for MSVC.
30
31         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
32
33         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
34
35         * WebKitTestRunner/TestController.cpp:
36         (WTR::printFrame): Use int and float literals.
37
38 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
39
40         [ews-build] Reassign bots to queues
41
42         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
43
44 2019-04-02  Chris Dumez  <cdumez@apple.com>
45
46         [WK2] Add support for Window's beforeprint / afterprint events
47         https://bugs.webkit.org/show_bug.cgi?id=196478
48
49         Reviewed by Alex Christensen.
50
51         Add minimal implementation for printFrame in WebKitTestRunner.
52
53         * WebKitTestRunner/TestController.cpp:
54         (WTR::printFrame):
55         (WTR::TestController::createOtherPage):
56         (WTR::TestController::createWebViewWithOptions):
57
58 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
59
60         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
61         https://bugs.webkit.org/show_bug.cgi?id=196491
62
63         Reviewed by Lucas Forschler.
64
65         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
66
67 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
68
69         [ews-build] Configure buildbot try credentials in environment variables
70         https://bugs.webkit.org/show_bug.cgi?id=196501
71
72         Reviewed by Lucas Forschler.
73
74         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
75         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
76         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
77
78 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
79
80         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
81         https://bugs.webkit.org/show_bug.cgi?id=196496
82         <rdar://problem/49521634>
83
84         Reviewed by Chris Dumez.
85
86         Add new API tests (see WebKit ChangeLog for more detail).
87
88         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
89         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
90         (TEST):
91
92 2019-04-02  David Kilzer  <ddkilzer@apple.com>
93
94         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
95         <https://webkit.org/b/196499>
96
97         Reviewed by Alexey Proskuryakov.
98
99         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
100         ENABLE_ADDRESS_SANITIZER.
101
102 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
103
104         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
105         https://bugs.webkit.org/show_bug.cgi?id=182757
106
107         Reviewed by Don Olmstead.
108
109         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
110         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
111
112 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
113
114         run-api-tests: Upload test results
115         https://bugs.webkit.org/show_bug.cgi?id=196323
116         <rdar://problem/49356714>
117
118         Reviewed by Lucas Forschler.
119
120         * Scripts/webkitpy/api_tests/manager.py:
121         (Manager):
122         (Manager.run): Upload results to a results database.
123         * Scripts/webkitpy/api_tests/run_api_tests.py:
124         (parse_args): Add upload arguments.
125         * Scripts/webkitpy/port/base.py:
126         (Port):
127         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
128         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
129         with commits from any other associated repositories.
130         * Scripts/webkitpy/port/device.py:
131         (Device):
132         (Device.build_version): Access build_versoin of underlying platform device.
133         * Scripts/webkitpy/port/ios_simulator_unittest.py:
134         (IOSSimulatorTest):
135         (IOSSimulatorTest.test_configuration_for_upload):
136         * Scripts/webkitpy/port/device_port.py:
137         (DevicePort):
138         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
139         the same as the machine uploading results.
140         * Scripts/webkitpy/port/mac.py:
141         (MacPort):
142         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
143         * Scripts/webkitpy/port/mac_unittest.py:
144         (MacTest):
145         (MacTest.test_configuration_for_upload):
146         * Scripts/webkitpy/xcode/simulated_device.py:
147         (SimulatedDeviceManager._create_device_with_runtime):
148         (SimulatedDevice.__init__): Create simulated device with a build_version.
149         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
150         (test_existing_simulator):
151
152 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
153
154         Remove extra newline characters (Follow-up fix to r243707)
155
156         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
157
158 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
159
160         [ews-app] Use API_KEY to accept results data
161         https://bugs.webkit.org/show_bug.cgi?id=196461
162
163         Reviewed by Dewei Zhu.
164
165         * BuildSlaveSupport/ews-app/ews/views/results.py:
166         (Results.post): Validate EWS_API_KEY before accepting any data.
167         * BuildSlaveSupport/ews-build/events.py:
168         (Events.sendData): Send EWS_API_KEY if available along with event data.
169
170 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
171
172         Unable to copy and paste a PDF from Notes into Mail compose body
173         https://bugs.webkit.org/show_bug.cgi?id=196442
174         <rdar://problem/48573098>
175
176         Reviewed by Tim Horton.
177
178         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
179         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
180         to be specified on the item providers.
181
182         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
183         (TestWebKitAPI::mapItemForTesting):
184         (TestWebKitAPI::contactItemForTesting):
185
186 2019-04-01  Tim Horton  <timothy_horton@apple.com>
187
188         Make UIWKDocumentContext rects per-character instead of per-word
189         https://bugs.webkit.org/show_bug.cgi?id=196459
190
191         Reviewed by Wenson Hsieh.
192
193         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
194         (TEST):
195         Adjust test results due to switching to per-character rects.
196
197 2019-04-01  Chris Dumez  <cdumez@apple.com>
198
199         UIProcess crash when a prewarmed process is terminated
200         https://bugs.webkit.org/show_bug.cgi?id=196451
201         <rdar://problem/49245471>
202
203         Reviewed by Geoffrey Garen.
204
205         Add API test coverage.
206
207         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
208         (TEST):
209
210 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
211
212         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
213         https://bugs.webkit.org/show_bug.cgi?id=196449
214
215         Reviewed by Lucas Forschler.
216
217         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
218         (StatusBubble.get_os_details): Method to get OS and Xcode details.
219         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
220         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
221
222 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
223
224         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
225         https://bugs.webkit.org/show_bug.cgi?id=196444
226
227         Reviewed by Lucas Forschler.
228
229         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
230
231 2019-04-01  Alex Christensen  <achristensen@webkit.org>
232
233         Add SPI to canonicalize NSURLs with WTF::URL
234         https://bugs.webkit.org/show_bug.cgi?id=196415
235         <rdar://problem/44980271>
236
237         Reviewed by Darin Adler.
238
239         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
240         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
241         (TestWebKitAPI::TEST):
242
243 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
244
245         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
246         https://bugs.webkit.org/show_bug.cgi?id=196441
247
248         Reviewed by Carlos Garcia Campos.
249
250         Don't cache the wpe_view_backend object that might not exist yet at the
251         time of EventSenderProxy constructor invocation, but instead retrieve
252         that object whenever it's required for event dispatching. This should
253         avoid crashes in this constructor now that it's invoked before any
254         PlatformWindow has been set up (as changed in r243496).
255
256         * WebKitTestRunner/EventSenderProxy.h:
257         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
258         (WTR::viewBackend):
259         (WTR::EventSenderProxy::EventSenderProxy):
260         (WTR::EventSenderProxy::mouseDown):
261         (WTR::EventSenderProxy::mouseUp):
262         (WTR::EventSenderProxy::mouseMoveTo):
263         (WTR::EventSenderProxy::mouseScrollBy):
264         (WTR::EventSenderProxy::keyDown):
265         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
266
267 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
268
269         [Win][WebKit] MiniBrowser should support high DPI display
270         https://bugs.webkit.org/show_bug.cgi?id=196391
271
272         Reviewed by Alex Christensen.
273
274         * MiniBrowser/win/WebKitBrowserWindow.cpp:
275         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
276         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
277         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
278
279 2019-03-31  Sam Weinig  <weinig@apple.com>
280
281         Remove more i386 specific configurations
282         https://bugs.webkit.org/show_bug.cgi?id=196430
283
284         Reviewed by Alexey Proskuryakov.
285
286         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
287         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
288
289 2019-03-31  Andy Estes  <aestes@apple.com>
290
291         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
292         https://bugs.webkit.org/show_bug.cgi?id=196433
293         <rdar://problem/49293305>
294
295         Reviewed by Tim Horton.
296
297         Enhanced API test coverage to include all navigation response policy decisions in both
298         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
299
300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
301         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
302         (TestWebKitAPI::TEST):
303         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
304         (readFile):
305         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
306         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
307         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
308         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
309         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
310         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
311         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
312         (-[QuickLookDelegate _downloadDidStart:]):
313         (-[QuickLookDelegate _download:didReceiveResponse:]):
314         (-[QuickLookDelegate _download:didReceiveData:]):
315         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
316         (-[QuickLookDelegate _downloadDidFinish:]):
317         (-[QuickLookDelegate _download:didFailWithError:]):
318         (-[QuickLookDelegate _downloadDidCancel:]):
319         (-[QuickLookDelegate verifyDownload]):
320         (runTest):
321         (runTestDecideBeforeLoading):
322         (runTestDecideAfterLoading):
323         (TEST):
324         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
325         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
326         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
327         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
328         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
329         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
330         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
331         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
332         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
333         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
334         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
335         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
336         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
337         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
338
339 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
340
341         [CMake] add testdfg as target with build-jsc
342         https://bugs.webkit.org/show_bug.cgi?id=196393
343
344         Reviewed by Saam Barati.
345
346         Added testdfg as one of the targets to build when
347         using CMake.
348
349         * Scripts/build-jsc:
350
351 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
352
353         Delete WebMetal implementation in favor of WebGPU
354         https://bugs.webkit.org/show_bug.cgi?id=195418
355
356         Reviewed by Dean Jackson.
357
358         * DumpRenderTree/mac/DumpRenderTree.mm:
359         (enableExperimentalFeatures):
360         (resetWebPreferencesToConsistentValues):
361         * Scripts/webkitperl/FeatureList.pm:
362         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
363         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
364         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
365         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
366         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
367         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
368         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
369         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
370         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
371         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
372         (WTR::InjectedBundle::beginTesting):
373         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
374         (WTR::TestRunner::setWebMetalEnabled): Deleted.
375         * WebKitTestRunner/InjectedBundle/TestRunner.h:
376
377 2019-03-29  Chris Dumez  <cdumez@apple.com>
378
379         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
380         https://bugs.webkit.org/show_bug.cgi?id=196405
381         <rdar://problem/49428130>
382
383         Reviewed by Wenson Hsieh.
384
385         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
386         the popover presentation methods to be no-ops. Use this in the new test added in
387         r243523 so that we do not swizzle those methods for all tests. This is needed because
388         those WatchOS tests rely on the popover getting presented and interactive.
389
390         * WebKitTestRunner/TestController.cpp:
391         (WTR::updateTestOptionsFromTestHeader):
392         * WebKitTestRunner/TestController.h:
393         * WebKitTestRunner/TestOptions.h:
394         (WTR::TestOptions::hasSameInitializationOptions const):
395         * WebKitTestRunner/ios/TestControllerIOS.mm:
396         (WTR::TestController::platformInitialize):
397         (WTR::TestController::platformResetStateToConsistentValues):
398
399 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
400
401         [Curl] Add Server Trust Evaluation Support.
402         https://bugs.webkit.org/show_bug.cgi?id=191646
403
404         Reviewed by Fujii Hironori.
405
406         Implemented MiniBrowser UI for asking if user trusts the server.
407
408         * MiniBrowser/win/Common.cpp:
409         (askServerTrustEvaluation):
410         (replaceString):
411         * MiniBrowser/win/Common.h:
412         * MiniBrowser/win/MiniBrowserLib.rc:
413         * MiniBrowser/win/MiniBrowserLibResource.h:
414         * MiniBrowser/win/WebKitBrowserWindow.cpp:
415         (createPEMString):
416         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
417         (WebKitBrowserWindow::canTrustServerCertificate):
418         * MiniBrowser/win/WebKitBrowserWindow.h:
419
420 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
421
422         Implement ResizeObserver.
423         https://bugs.webkit.org/show_bug.cgi?id=157743
424
425         Reviewed by Simon Fraser.
426
427         Support resizeObserverEnabled webPreferences.
428
429         * DumpRenderTree/TestOptions.cpp:
430         (TestOptions::TestOptions):
431         * DumpRenderTree/TestOptions.h:
432         * DumpRenderTree/mac/DumpRenderTree.mm:
433         (setWebPreferencesForTestOptions):
434         * DumpRenderTree/win/DumpRenderTree.cpp:
435         (enableExperimentalFeatures):
436         * Scripts/webkitperl/FeatureList.pm:
437         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
438
439 2019-03-28  John Wilander  <wilander@apple.com>
440
441         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
442         https://bugs.webkit.org/show_bug.cgi?id=196281
443         <rdar://problem/48938748>
444
445         Reviewed by Alex Christensen.
446
447         This patch adds the function isStatisticsHasLocalStorage() to the
448         TestRunner. With it, the page can query the WebsiteDataStore in the
449         UI process to make sure that it sees LocalStorage.
450
451         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
452         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
453         (WTR::TestRunner::isStatisticsHasLocalStorage):
454         * WebKitTestRunner/InjectedBundle/TestRunner.h:
455         * WebKitTestRunner/TestController.cpp:
456         (WTR::TestController::isStatisticsHasLocalStorage):
457         * WebKitTestRunner/TestController.h:
458         * WebKitTestRunner/TestInvocation.cpp:
459         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
460
461 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
462
463         API::Data::createWithoutCopying should do a null check before calling CFRelease
464         https://bugs.webkit.org/show_bug.cgi?id=196276
465         <rdar://problem/48059859>
466
467         Reviewed by Alex Christensen.
468
469         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
470
471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
472         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
473         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
474         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
475         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
476         (TestWebKitAPI::TEST):
477
478 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
479
480         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
481         https://bugs.webkit.org/show_bug.cgi?id=186276
482
483         Reviewed by Carlos Garcia Campos.
484
485         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
486         (webViewLoadChanged):
487         (testWebResourceGetDataError):
488         (testWebResourceGetDataEmpty):
489         (beforeAll):
490         (webViewloadChanged): Deleted.
491
492 2019-03-27  Andy Estes  <aestes@apple.com>
493
494         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
495         https://bugs.webkit.org/show_bug.cgi?id=196317
496
497         Reviewed by Dan Bernstein.
498
499         package-root copies built products into a staging directory using ditto(1), which does not
500         follow symbolic links as it traverses a directory. Now that the files in
501         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
502         itself, these become broken links when ditto'd into the staging directory.
503
504         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
505
506         * Scripts/package-root:
507
508 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
509
510         [ews-app] Update display text of Submit for ews analysis
511         https://bugs.webkit.org/show_bug.cgi?id=196309
512
513         Reviewed by Dewei Zhu.
514
515         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
516
517 2019-03-27  David Kilzer  <ddkilzer@apple.com>
518
519         run-webkit-tests should check for leaks in WebKit processes
520         <https://webkit.org/b/193772>
521         <rdar://problem/46526680>
522
523         Reviewed by Ryosuke Niwa.
524
525         This works by doing the following:
526         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
527           The list of child processes are returned one per line:
528           process.name: pid
529         - Run the "#LIST CHILD PROCESSES" command just before the
530           "#CHECK FOR WORLD LEAKS" command, and store the list of child
531           processes on the ServerProcess object.
532         - When the `--leaks` switch is handled, run check_for_leaks() on
533           each child process after the main test harness.
534
535         * DumpRenderTree/mac/DumpRenderTree.mm:
536         (handleControlCommand):
537         - Use strncmp() instead of strcmp().
538         - Add support for handling "#LIST CHILD PROCESSES" command.
539
540         * Scripts/webkitpy/port/base.py:
541         (Port.check_for_leaks):
542         * Scripts/webkitpy/port/darwin.py:
543         (DarwinPort.check_for_leaks):
544         - Rename redundant 'process_pid' argument to 'process_id'.
545
546         * Scripts/webkitpy/port/driver.py:
547         (Driver.do_post_tests_work):
548         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
549           longer the only command this sends to WebKitTestRunner.
550         - If the `--leaks` switch is present, send the
551           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
552           result using Port.set_webkit_processes().
553         (Driver._parse_child_processes_output):
554         - Add helper method to parse list of child process names and
555           process IDs returned from WebKitTestRunner.
556
557         * Scripts/webkitpy/port/ios_device.py:
558         (IOSDevicePort.check_for_leaks):
559         - Rename redundant 'process_pid' argument to 'process_id'.
560
561         * Scripts/webkitpy/port/leakdetector.py:
562         (LeakDetector._parse_leaks_output):
563         - Return early if there is no leaks_output.
564         (LeakDetector.check_for_leaks):
565         - Rename redundant 'process_pid' argument to 'process_id'.
566
567         * Scripts/webkitpy/port/server_process.py:
568         (ServerProcess.__init__):
569         (ServerProcess.child_processes):
570         (ServerProcess.set_child_processes):
571         - Add instance variable to Port to store list of child process
572           names and process IDs returned from WebKitTestRunner.
573         (ServerProcess._start):
574         - Clear self._child_processes.
575         (ServerProcess.stop):
576         - If self._child_processes is set, call
577           self._port.check_for_leaks() for each child process.
578
579         * Scripts/webkitpy/port/server_process_unittest.py:
580         (TrivialMockPort.check_for_leaks):
581         - Rename redundant 'process_pid' argument to 'process_id'.
582
583         * Scripts/webkitpy/port/simulator_process.py:
584         (SimulatorProcess.stop):
585         - If self._child_processes is set, call
586           self._port.check_for_leaks() for each child process.
587
588         * Scripts/webkitpy/port/watch_device.py:
589         (WatchDevicePort.check_for_leaks):
590         - Rename redundant 'process_pid' argument to 'process_id'.
591
592         * WebKitTestRunner/TestController.cpp:
593         (WTR::TestController::dumpResponse):
594         - Extract method from findAndDumpWorldLeaks() so that it may be
595           reused by findAndDumpWebKitProcessIdentifiers().
596         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
597         - Add method to output process name and process ID of both the
598           WebContent and Networking processes.
599         (WTR::TestController::findAndDumpWorldLeaks):
600         - Fix missing newline in output when there were no abandoned
601           documents.
602         - Call dumpResponse() for extracted code.
603         (WTR::TestController::handleControlCommand):
604         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
605         - Use strncmp() instead of strcmp().
606         - Call findAndDumpWebKitProcessIdentifiers() when
607           "#LIST CHILD PROCESSES" command is sent.
608         * WebKitTestRunner/TestController.h:
609         (WTR::TestController::dumpResponse):
610         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
611         - Declare methods.
612
613 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
614
615         Unreviewed. Add GLib API test cases after r243434.
616
617         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
618         (testWebViewActiveURI):
619         (serverCallback):
620         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
621         (sendRequestCallback):
622
623 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
624
625         Geolocation request not complete when watch request was started in a different web process
626         https://bugs.webkit.org/show_bug.cgi?id=195996
627
628         Reviewed by Alex Christensen.
629
630         Add a test case.
631
632         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
633         (TestWebKitAPI::runJavaScriptAlert):
634         (TestWebKitAPI::TEST):
635
636 2019-03-26  Keith Rollin  <krollin@apple.com>
637
638         Update the way generate-xcfilelists returns strings from functions
639         https://bugs.webkit.org/show_bug.cgi?id=195975
640         <rdar://problem/49040807>
641
642         Reviewed by Dean Jackson.
643
644         There are places where generate-xcfilelists executes assignments with
645         statements like:
646
647             FOO=$(some_function)
648
649         where "some_function" return a string by echoing it. E.g.
650
651             some_function()
652             {
653                 echo "Hello, World"
654             }
655
656         This is a common idiom, but it has a problem if "some_function" needs
657         to call "exit" in an attempt to halt the entire script right then and
658         there. Since "some_function" is called inside of $(), it's being
659         executed in a sub-shell. Calling exit in that sub-shell simply exits
660         that shell; it doesn't not exit the outer shell in which the main part
661         of the script is still running. As such, the main script keeps
662         executing when the intent was for the script to halt.
663
664         The solution to this is to use a different idiom for returning
665         strings. The one we now is to pass in the name of the variable to
666         receive the string result:
667
668             some_function()
669             {
670                 variable_name=$1
671                 eval $variable_name ="Hello, World"
672             }
673
674         The call site now looks like
675
676             some_function FOO
677
678         Because there's no invocation of a sub-shell, some_function can now
679         call "exit" if it wants to, and the entire script will exit at that
680         point.
681
682         * Scripts/generate-xcfilelists:
683
684 2019-03-26  Chris Dumez  <cdumez@apple.com>
685
686         Add basic layout test coverage for File Picker on iOS
687         https://bugs.webkit.org/show_bug.cgi?id=196265
688
689         Reviewed by Wenson Hsieh.
690
691         Add layout test infrastructure to test the file picker on iOS.
692
693         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
694         (WTR::UIScriptController::dismissFilePicker):
695         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
696         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
697         (WTR::UIScriptController::dismissFilePicker):
698         * TestRunnerShared/UIScriptContext/UIScriptController.h:
699         * WebKitTestRunner/TestController.cpp:
700         (WTR::TestController::createWebViewWithOptions):
701         (WTR::updateTestOptionsFromTestHeader):
702         * WebKitTestRunner/TestOptions.h:
703         (WTR::TestOptions::hasSameInitializationOptions const):
704         * WebKitTestRunner/ios/TestControllerIOS.mm:
705         (overridePresentViewController):
706         (WTR::TestController::platformInitialize):
707         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
708         (WTR::UIScriptController::dismissFilePicker):
709
710 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
711
712         Implement async paste method on UIWKInteractionViewProtocol
713         https://bugs.webkit.org/show_bug.cgi?id=196267
714         <rdar://problem/49236346>
715
716         Reviewed by Tim Horton.
717
718         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
719         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
720         are now a part of all iOS 12 internal SDKs.
721
722         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
723
724         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
725         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
726
727         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
728         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
729         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
730         * TestWebKitAPI/ios/UIKitSPI.h:
731
732 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
733
734         [ews-build] Use PostgreSQL for ews.webkit.org database
735         https://bugs.webkit.org/show_bug.cgi?id=196270
736
737         Reviewed by Lucas Forschler.
738
739         * BuildSlaveSupport/ews-app/ews-app/settings.py:
740
741 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
742
743         [ews] Reset simctl states on reboot
744         https://bugs.webkit.org/show_bug.cgi?id=196260
745
746         Rubber-stamped by Aakash Jain.
747
748         * EWSTools/start-queue-mac.sh:
749
750 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
751
752         [ews-build] Use PostgreSQL for ews-build database
753         https://bugs.webkit.org/show_bug.cgi?id=196229
754
755         Reviewed by Lucas Forschler.
756
757         * BuildSlaveSupport/ews-build/master.cfg:
758
759 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
760
761         [ews-build] Get master_hostname dynamically in master.cfg
762         https://bugs.webkit.org/show_bug.cgi?id=196255
763
764         Reviewed by Lucas Forschler.
765
766         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
767         send events data in test mode.
768
769 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
770
771         [ews-app] Set db_constraint to False for Foreign Keys
772         https://bugs.webkit.org/show_bug.cgi?id=196252
773
774         Reviewed by Lucas Forschler.
775
776         * BuildSlaveSupport/ews-app/ews/models/build.py:
777         * BuildSlaveSupport/ews-app/ews/models/step.py:
778
779 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
780
781         [ews-build] is_test_mode_enabled should default to True
782         https://bugs.webkit.org/show_bug.cgi?id=196248
783
784         Reviewed by Lucas Forschler.
785
786         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
787
788 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
789
790         [ews-app] Add webkitperl to ENABLED_QUEUES
791         https://bugs.webkit.org/show_bug.cgi?id=196253
792
793         Reviewed by Lucas Forschler.
794
795         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
796
797 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
798
799         Address NSWindow sometimes using WebKitTestRunnerEvent too early
800         https://bugs.webkit.org/show_bug.cgi?id=196211
801         rdar://problem/49110552
802
803         Reviewed by Tim Horton.
804
805         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
806         Make sure that EventSenderProxy always exists when running tests. We used to create
807         it when resetting before the first test, which is a bit too late.
808
809         * WebKitTestRunner/TestController.h:
810         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
811         (WTR::TestController::platformCreateWebView):
812         (WTR::TestController::platformCreateOtherPage):
813         (WTR::TestController::finishCreatingPlatformWebView):
814         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
815         (WTR::PlatformWebView::PlatformWebView):
816         Moved some code that made NSWindow use NSEvent during web view creation. We may
817         need to move more if some other case us found, but this is enough for now.
818
819 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
820
821         Unreviewed. Fix typo in GLib geolocation API after r243285.
822
823         gelocation -> geolocation.
824
825         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
826         (testGeolocationManagerWatchPosition):
827
828 2019-03-25  Alex Christensen  <achristensen@webkit.org>
829
830         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
831         https://bugs.webkit.org/show_bug.cgi?id=196213
832
833         Reviewed by Geoff Garen.
834
835         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
836         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
837         (credentialWithIdentityAndKeychainPath):
838         (-[ChallengeDelegate webView:didFinishNavigation:]):
839         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
840         (TestWebKitAPI::TEST):
841
842 2019-03-25  Alex Christensen  <achristensen@webkit.org>
843
844         Expected shouldn't assume its contained types are copyable
845         https://bugs.webkit.org/show_bug.cgi?id=195986
846
847         Reviewed by JF Bastien.
848
849         * TestWebKitAPI/Tests/WTF/Expected.cpp:
850         (TestWebKitAPI::NonCopyable::operator== const):
851         (TestWebKitAPI::NonCopyable::operator!= const):
852         (TestWebKitAPI::TEST):
853
854 2019-03-25  Tim Horton  <timothy_horton@apple.com>
855
856         Remove some now-unnecessary dynamic class lookup
857         https://bugs.webkit.org/show_bug.cgi?id=196237
858
859         Reviewed by Simon Fraser.
860
861         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
862         (makeRequest):
863         (TEST):
864
865 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
866
867         Unreviewed, rolling out r243450.
868
869         AppleWin and WinCairo port builds get broken.
870
871         Reverted changeset:
872
873         "Add test for fix of #196095"
874         https://bugs.webkit.org/show_bug.cgi?id=196097
875         https://trac.webkit.org/changeset/243450
876
877 2019-03-25  Commit Queue  <commit-queue@webkit.org>
878
879         Unreviewed, rolling out r243465.
880         https://bugs.webkit.org/show_bug.cgi?id=196226
881
882         the test doesn't build (Requested by thorton on #webkit).
883
884         Reverted changeset:
885
886         "Do not terminate the NetworkProcess if a third party
887         application sends a NSCredential with a SecIdentityRef"
888         https://bugs.webkit.org/show_bug.cgi?id=196213
889         https://trac.webkit.org/changeset/243465
890
891 2019-03-25  Alex Christensen  <achristensen@webkit.org>
892
893         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
894         https://bugs.webkit.org/show_bug.cgi?id=196213
895
896         Reviewed by Geoff Garen.
897
898         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
899         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
900         (credentialWithIdentityAndKeychainPath):
901         (-[ChallengeDelegate webView:didFinishNavigation:]):
902         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
903         (TestWebKitAPI::TEST):
904
905 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
906
907         [ews-build] Gracefully handle missing patch_id in events
908         https://bugs.webkit.org/show_bug.cgi?id=196216
909
910         Reviewed by Lucas Forschler.
911
912         * BuildSlaveSupport/ews-build/events.py:
913
914 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
915
916         [ews-build] use lz4 compression for improving buildbot performance
917         https://bugs.webkit.org/show_bug.cgi?id=196155
918
919         Reviewed by Lucas Forschler.
920
921         * BuildSlaveSupport/ews-build/master.cfg:
922
923 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
924
925         Pull some API testing helper methods out of TestWKWebView
926         https://bugs.webkit.org/show_bug.cgi?id=196212
927
928         Reviewed by Tim Horton.
929
930         Refactor some more API testing utility methods, so that they can be used in
931         tests that do not use TestWKWebView.
932
933         * TestWebKitAPI/cocoa/TestWKWebView.h:
934         * TestWebKitAPI/cocoa/TestWKWebView.mm:
935         (-[WKWebView loadTestPageNamed:]):
936         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
937         (-[WKWebView synchronouslyLoadHTMLString:]):
938         (-[WKWebView synchronouslyLoadTestPageNamed:]):
939         (-[TestWKWebView loadTestPageNamed:]): Deleted.
940         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
941         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
942         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
943
944 2019-03-25  Jer Noble  <jer.noble@apple.com>
945
946         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
947         https://bugs.webkit.org/show_bug.cgi?id=196097
948
949         Reviewed by Eric Carlson.
950
951         Drive-by bug fix: allow tests to play audio without a user gesture by default.
952
953         * DumpRenderTree/mac/DumpRenderTree.mm:
954         (resetWebPreferencesToConsistentValues):
955         * WebKitTestRunner/TestController.cpp:
956         (WTR::TestController::resetPreferencesToConsistentValues):
957
958 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
959
960         Pull IPadUserInterfaceSwizzler out into a separate header file
961         https://bugs.webkit.org/show_bug.cgi?id=196193
962
963         Reviewed by Anders Carlsson.
964
965         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
966         be used in other API tests.
967
968         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
969         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
970         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
971         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
972         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
973         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
974         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
975
976 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
977
978         Remove NavigatorContentUtils in WebCore/Modules
979         https://bugs.webkit.org/show_bug.cgi?id=196070
980
981         Reviewed by Alex Christensen.
982
983         NavigatorContentUtils was to support the custom scheme spec [1].
984         However, in WebKit side, no port has supported the feature in
985         WebKit layer after EFL port was removed. So there has been the
986         only IDL implementation of the NavigatorContentUtils in WebCore.
987         So we don't need to keep the implementation in WebCore anymore.
988
989         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
990
991         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
992
993 2019-03-24  Andy Estes  <aestes@apple.com>
994
995         [watchOS] Remove unused Proximity Networking code
996         https://bugs.webkit.org/show_bug.cgi?id=196188
997
998         Reviewed by Tim Horton.
999
1000         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1001         (TEST):
1002
1003 2019-03-23  Keith Miller  <keith_miller@apple.com>
1004
1005         Refactor clz/ctz and fix getLSBSet.
1006         https://bugs.webkit.org/show_bug.cgi?id=196162
1007
1008         Reviewed by Saam Barati.
1009
1010         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1011
1012         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1013         (TestWebKitAPI::TEST):
1014
1015 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1016
1017         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1018         https://bugs.webkit.org/show_bug.cgi?id=196143
1019
1020         Reviewed by Michael Catanzaro.
1021
1022         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1023         directories.
1024
1025         * Scripts/webkitpy/style/checkers/cpp.py:
1026         (check_identifier_name_in_declaration):
1027         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1028         (WebKitStyleTest.test_names):
1029
1030 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1031
1032         [Flatpak] Manifest expanding fails for qt WPE extension
1033         https://bugs.webkit.org/show_bug.cgi?id=196148
1034
1035         Reviewed by Alex Christensen.
1036
1037         * flatpak/flatpakutils.py:
1038         (expand_submodules_recurse): The last recurse manifest expand
1039         iteration might lead to a single module so take it into account
1040         and don't try to recurse further.
1041
1042 2019-03-22  Chris Dumez  <cdumez@apple.com>
1043
1044         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1045         https://bugs.webkit.org/show_bug.cgi?id=195348
1046         <rdar://problem/48622090>
1047
1048         Reviewed by Alex Christensen.
1049
1050         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1051         to NO when test.options().shouldIgnoreMetaViewport is false.
1052
1053         * WebKitTestRunner/ios/TestControllerIOS.mm:
1054         (WTR::TestController::platformConfigureViewForTest):
1055
1056 2019-03-22  Chris Dumez  <cdumez@apple.com>
1057
1058         Prewarmed processes should be usable with any website data store
1059         https://bugs.webkit.org/show_bug.cgi?id=196104
1060
1061         Reviewed by Alex Christensen.
1062
1063         Add API test coverage.
1064
1065         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1066         (runInitialWarmedProcessUsedTest):
1067         (TEST):
1068
1069 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1070
1071         Back out local changes to Alex's Subversion working directory
1072
1073         They were accidentally committed.
1074
1075         * Scripts/webkitpy/common/system/abstractexecutive.py:
1076         (AbstractExecutive.wait_newest):
1077         * Scripts/webkitpy/common/system/executive.py:
1078         (Executive.running_pids):
1079         * Scripts/webkitpy/common/system/executive_mock.py:
1080         (MockExecutive.running_pids):
1081         * Scripts/webkitpy/common/system/executive_unittest.py:
1082         (ExecutiveTest.serial_test_running_pids):
1083         * Scripts/webkitpy/port/darwin.py:
1084         (DarwinPort.check_for_leaks):
1085         * Scripts/webkitpy/port/leakdetector.py:
1086         (LeakDetector.check_for_leaks):
1087         - This was the hack attached to Bug 193772.
1088
1089         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1090         (+[WebKitTestRunnerEvent mouseLocation]):
1091         - This works around a crash on an internal build.
1092
1093 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1094
1095         Fix the build after r243354
1096         https://bugs.webkit.org/show_bug.cgi?id=196138
1097         <rdar://problem/49145951>
1098
1099         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1100         (TEST):
1101         * TestWebKitAPI/ios/UIKitSPI.h:
1102
1103 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1104
1105         Adopt UIWKDocumentContext
1106         https://bugs.webkit.org/show_bug.cgi?id=196040
1107         <rdar://problem/48642440>
1108
1109         Reviewed by Ryosuke Niwa.
1110
1111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1112         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1113         (makeRequest):
1114         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1115         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1116         (applyStyle):
1117         (TEST):
1118         Add tests for UIWKDocumentContext.
1119
1120         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1121         (TEST):
1122         (recursiveFindWKContentView): Deleted.
1123         * TestWebKitAPI/cocoa/TestWKWebView.h:
1124         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1125         (recursiveFindWKContentView):
1126         (-[TestWKWebView wkContentView]):
1127         * TestWebKitAPI/ios/UIKitSPI.h:
1128         Share the WKContentView finding code between tests.
1129
1130 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1131
1132         [iOS WK2] Turn on async overflow scrolling by default
1133         https://bugs.webkit.org/show_bug.cgi?id=196011
1134         rdar://problem/48453859
1135
1136         Reviewed by Antti Koivisto.
1137         
1138         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1139         since so many basic layout tests have different results when compositing is triggered for
1140         overflow.
1141         
1142         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1143
1144         * WebKitTestRunner/TestController.cpp:
1145         (WTR::TestController::resetPreferencesToConsistentValues):
1146
1147 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1148
1149         [ews-build] Retry API test in case of failures
1150         https://bugs.webkit.org/show_bug.cgi?id=196004
1151
1152         Reviewed by Lucas Forschler.
1153
1154         * BuildSlaveSupport/ews-build/steps.py:
1155         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1156         (CompileWebKitToT.doStepIf): Ditto.
1157         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1158         (ReRunAPITests): Re-run API tests.
1159         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1160         (RunAPITestsWithoutPatch): Run API tests without patch.
1161         (RunAPITestsWithoutPatch.doStepIf):
1162         (RunAPITestsWithoutPatch.hideStepIf):
1163         (RunAPITestsWithoutPatch.evaluateCommand):
1164         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1165         (AnalyzeAPITestsResults.start):
1166         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1167         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1168         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1169         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1170
1171 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1172
1173         [ews-build] Update queues configurations
1174         https://bugs.webkit.org/show_bug.cgi?id=196074
1175
1176         Reviewed by Dewei Zhu.
1177
1178         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1179         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1180
1181 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1182
1183         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1184         https://bugs.webkit.org/show_bug.cgi?id=195680
1185         <rdar://problem/48903534>
1186
1187         Unreviewed infrastructure fix.
1188
1189         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1190         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1191
1192 2019-03-21  Andy Estes  <aestes@apple.com>
1193
1194         [iOS] Apple Pay should be available in documents with no user agent scripts
1195         https://bugs.webkit.org/show_bug.cgi?id=196061
1196         <rdar://problem/48649391>
1197
1198         Reviewed by Brady Eidson.
1199
1200         Added API tests and related infrastructure.
1201
1202         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1203         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1204         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1205         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1206         (TestWebKitAPI::TEST):
1207         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1208         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1209         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1210         * TestWebKitAPI/cocoa/TestProtocol.mm:
1211         (-[TestProtocol startLoading]):
1212         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1213         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1214         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1215         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1216
1217 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1218
1219         REGRESSSION (r243297): webkitpy tests broken
1220         https://bugs.webkit.org/show_bug.cgi?id=196108
1221
1222         Reviewed by Aakash Jain.
1223
1224         r243297 updated contributors.json, which broke a few unit tests.
1225
1226         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1227         (IRCCommandTest.test_whois):
1228         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1229
1230 2019-03-21  Chris Dumez  <cdumez@apple.com>
1231
1232         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1233         https://bugs.webkit.org/show_bug.cgi?id=196041
1234         <rdar://problem/49083230>
1235
1236         Reviewed by Alex Christensen.
1237
1238         Add API test coverage.
1239
1240         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1241         (TEST):
1242
1243 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1244
1245         Add SPI to inform applications of WKContentRuleList actions
1246         https://bugs.webkit.org/show_bug.cgi?id=195965
1247         <rdar://problem/42664365>
1248
1249         Reviewed by Geoff Garen.
1250
1251         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1252         (TestWebKitAPI::allActionsForResourceLoad):
1253         (TestWebKitAPI::testRequest):
1254         (TestWebKitAPI::TEST_F):
1255         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1256         (Notification::description):
1257         (Notification::operator== const):
1258         (toVector):
1259         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1260         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1261         (makeContentRuleList):
1262         (TEST):
1263         (makeWarnContentRuleList): Deleted.
1264
1265 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1266
1267         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1268         https://bugs.webkit.org/show_bug.cgi?id=196088
1269
1270         Reviewed by Brian Burg.
1271
1272         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1273         Support checks when only one platform is specified. Also deprecate macosx() and
1274         force the use of macos() instead.
1275
1276         * Scripts/webkitpy/style/checkers/cpp.py:
1277         (check_min_versions_of_wk_api_available):
1278         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1279         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1280
1281 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1282
1283         Update status inactive committers' status to 'contributor'.
1284
1285         * Scripts/webkitpy/common/config/contributors.json:
1286
1287 2019-03-21  Xan Lopez  <xan@igalia.com>
1288
1289         [JSC][x86] Drop support for x87 floating point
1290         https://bugs.webkit.org/show_bug.cgi?id=194853
1291
1292         Reviewed by Don Olmstead.
1293
1294         Force SSE2 on x86/32bit builds.
1295
1296         * Scripts/webkitdirs.pm:
1297         (generateBuildSystemFromCMakeProject):
1298
1299 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1300
1301         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1302         https://bugs.webkit.org/show_bug.cgi?id=196073
1303
1304         Reviewed by Michael Catanzaro.
1305
1306         Add test cases to check functions and constructors with no arguments but receiving user data.
1307
1308         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1309         (checkUserData):
1310         (testJSCFunction):
1311         (fooCreateWithUserData):
1312         (testJSCClass):
1313
1314 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1315
1316         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1317
1318         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1319
1320         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1321
1322 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1323
1324         [GTK][WPE] Add API to provide geolocation information
1325         https://bugs.webkit.org/show_bug.cgi?id=195940
1326
1327         Reviewed by Michael Catanzaro.
1328
1329         Add a new test to check the new API.
1330
1331         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1332         (testGeolocationManagerCurrentPosition):
1333         (testGeolocationManagerWatchPosition):
1334         (beforeAll):
1335         (afterAll):
1336         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1337         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1338         (beforeAll): Ditto.
1339         * TestWebKitAPI/glib/CMakeLists.txt:
1340
1341 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1342
1343         [GLib] Returning G_TYPE_OBJECT from a method does not work
1344         https://bugs.webkit.org/show_bug.cgi?id=195574
1345
1346         Reviewed by Michael Catanzaro.
1347
1348         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1349
1350         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1351         (getGFile):
1352         (getParent):
1353         (createGString):
1354         (getGString):
1355         (getGStringCopyWillRaise):
1356         (getGStringCopy):
1357         (getGStringStr):
1358         (getGStringLen):
1359         (freeGString):
1360         (testJSCClass):
1361
1362 2019-03-20  Saam Barati  <sbarati@apple.com>
1363
1364         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1365         https://bugs.webkit.org/show_bug.cgi?id=195721
1366
1367         Reviewed by Filip Pizlo.
1368
1369         * Scripts/run-javascriptcore-tests:
1370
1371 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1372
1373         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1374         https://bugs.webkit.org/show_bug.cgi?id=196049
1375
1376         Reviewed by Tim Horton.
1377
1378         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1379         overflow scrolling in general, so rename it.
1380
1381         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1382
1383 2019-03-20  Daniel Bates  <dabates@apple.com>
1384
1385         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1386         https://bugs.webkit.org/show_bug.cgi?id=196031
1387         <rdar://problem/49078172>
1388
1389         Reviewed by Tim Horton.
1390
1391         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1392         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1393         same code path used when the Done button is pressed to dismiss the <select> picker.
1394
1395         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1396         (TestWebKitAPI::TEST):
1397
1398 2019-03-20  Chris Dumez  <cdumez@apple.com>
1399
1400         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1401         https://bugs.webkit.org/show_bug.cgi?id=196029
1402         <rdar://problem/48954651>
1403
1404         Reviewed by Tim Horton.
1405
1406         Add API test coverage.
1407
1408         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1409
1410 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1411
1412         [ews-build] Improve failure summary string for ApplyPatch step
1413         https://bugs.webkit.org/show_bug.cgi?id=195995
1414
1415         Reviewed by Alexey Proskuryakov.
1416
1417         * BuildSlaveSupport/ews-build/steps.py:
1418         (ApplyPatch.getResultSummary): Override getResultSummary.
1419
1420 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1421
1422         AX: Implement support for new meter ARIA role
1423         https://bugs.webkit.org/show_bug.cgi?id=195966
1424
1425         Reviewed by Chris Fleizach.
1426
1427         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1428         to AXLevelIndicator.
1429
1430         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1431
1432 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1433
1434         [WebAuthN] Implement FIDO AppID extension
1435         https://bugs.webkit.org/show_bug.cgi?id=143491
1436         <rdar://problem/48298273>
1437
1438         Reviewed by Brent Fulgham.
1439
1440         Add a test that covers the new flag of convertToU2fSignCommand.
1441
1442         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1443         (TestWebKitAPI::TEST):
1444         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1445         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1446         (TestWebKitAPI::TEST):
1447
1448 2019-03-19  Keith Rollin  <krollin@apple.com>
1449
1450         Add support for more platforms to generate-xcfilelists
1451         https://bugs.webkit.org/show_bug.cgi?id=195977
1452
1453         Reviewed by Alexey Proskuryakov.
1454
1455         generate-xcfilelists incorrectly complains when involved with building
1456         WebKit for iphonesimulator:
1457
1458             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1459             …
1460             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1461
1462         Address this by teaching generate-xcfilelists about more platforms.
1463
1464         * Scripts/generate-xcfilelists:
1465
1466 2019-03-19  John Wilander  <wilander@apple.com>
1467
1468         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1469         https://bugs.webkit.org/show_bug.cgi?id=195923
1470         <rdar://problem/49001272>
1471
1472         Reviewed by Alex Christensen.
1473
1474         This patch does the following to the TestRunner:
1475         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1476         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1477         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1478
1479         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1480         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1481         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1482         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1483         * WebKitTestRunner/TestController.cpp:
1484         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1485         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1486         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1487         * WebKitTestRunner/TestController.h:
1488         * WebKitTestRunner/TestInvocation.cpp:
1489         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1490
1491 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1492
1493         [CMake] Support more clang and gcc sanitizers
1494         https://bugs.webkit.org/show_bug.cgi?id=195956
1495
1496         Reviewed by Michael Catanzaro.
1497
1498         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1499
1500 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1501
1502         [ews-build] Improve summary for PrintConfiguration step
1503         https://bugs.webkit.org/show_bug.cgi?id=195945
1504
1505         Reviewed by Lucas Forschler.
1506
1507         * BuildSlaveSupport/ews-build/steps.py:
1508         (PrintConfiguration.getResultSummary): Override getResultSummary.
1509
1510 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1511
1512         [ews-build] Improve summary for CheckOutSource step
1513         https://bugs.webkit.org/show_bug.cgi?id=195963
1514
1515         Reviewed by Lucas Forschler.
1516
1517         * BuildSlaveSupport/ews-build/steps.py:
1518         (CheckOutSource.getResultSummary):
1519
1520 2019-03-19  Daniel Bates  <dabates@apple.com>
1521
1522         [iOS] Focus not preserved when switching between tabs
1523         https://bugs.webkit.org/show_bug.cgi?id=195820
1524         <rdar://problem/43614450>
1525
1526         Reviewed by Brent Fulgham.
1527
1528         Add tests to ensure that we restore focus when resigning and becoming first responder.
1529
1530         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1531         (TestWebKitAPI::TEST):
1532
1533 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1534
1535         Make WTFLogChannelState and WTFLogLevel enum classes
1536         https://bugs.webkit.org/show_bug.cgi?id=195904
1537
1538         Reviewed by Eric Carlson.
1539
1540         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1541         (TestWebKitAPI::TEST_F):
1542
1543 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1544
1545         [GStreamer][EME] Backported mssdemux protection data crash fix
1546         https://bugs.webkit.org/show_bug.cgi?id=195918
1547
1548         Reviewed by Philippe Normand.
1549
1550         * gstreamer/jhbuild.modules:
1551         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1552
1553 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1554
1555         Unreviewed, rolling out r243132.
1556
1557         Broke GTK build
1558
1559         Reverted changeset:
1560
1561         "Make WTFLogChannelState and WTFLogLevel enum classes"
1562         https://bugs.webkit.org/show_bug.cgi?id=195904
1563         https://trac.webkit.org/changeset/243132
1564
1565 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1566
1567         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1568
1569         * Scripts/webkitdirs.pm:
1570         (builtDylibPathForName): Adjust the shared library name that's changed
1571         with the API version bump in r243073.
1572
1573 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1574
1575         Make WTFLogChannelState and WTFLogLevel enum classes
1576         https://bugs.webkit.org/show_bug.cgi?id=195904
1577
1578         Reviewed by Eric Carlson.
1579
1580         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1581         (TestWebKitAPI::TEST_F):
1582
1583 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1584
1585         Disable flaky test added in r2431100
1586         https://webkit.org/b/195785
1587
1588         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1589         (TestWebKitAPI::TEST):
1590         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1591
1592 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1593
1594         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1595         https://bugs.webkit.org/show_bug.cgi?id=195916
1596
1597         Reviewed by Tim Horton.
1598
1599         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1600         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1601
1602 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1603
1604         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1605
1606         * Scripts/webkitpy/common/config/contributors.json:
1607
1608 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1609
1610         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1611         https://bugs.webkit.org/show_bug.cgi?id=195785
1612
1613         Reviewed by Geoffrey Garen.
1614
1615         * TestWebKitAPI/TCPServer.cpp: Added.
1616         (TestWebKitAPI::TCPServer::TCPServer):
1617         (TestWebKitAPI::TCPServer::~TCPServer):
1618         (TestWebKitAPI::TCPServer::socketBindListen):
1619         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1620         * TestWebKitAPI/TCPServer.h: Added.
1621         (TestWebKitAPI::TCPServer::port const):
1622         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1623         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1624         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1625         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1626         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1627         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1628         (TestWebKitAPI::respondSlowly):
1629         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1630         (TestWebKitAPI::downloadAtRate):
1631         (TestWebKitAPI::TEST):
1632
1633 2019-03-18  Saam Barati  <sbarati@apple.com>
1634
1635         Add a plan file for JetStream 2
1636         https://bugs.webkit.org/show_bug.cgi?id=190734
1637
1638         Reviewed by Mark Lam.
1639
1640         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1641
1642 2019-03-18  Chris Dumez  <cdumez@apple.com>
1643
1644         Delay WebProcess launch until a load is triggered in a Web view
1645         https://bugs.webkit.org/show_bug.cgi?id=195758
1646         <rdar://problem/48126013>
1647
1648         Reviewed by Geoff Garen.
1649
1650         Add API test coverage. Also update some existing API tests to not expect
1651         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1652
1653         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1654         (TestWebKitAPI::TEST):
1655         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1656         (TestWebKitAPI::TEST):
1657         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1658         (TEST):
1659         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1660         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1661         (TEST):
1662         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1663         (TEST):
1664         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1665
1666 2019-03-18  Xan Lopez  <xan@igalia.com>
1667
1668         [CMake] Prevent potential warning when determining $architecture
1669         https://bugs.webkit.org/show_bug.cgi?id=195891
1670
1671         Reviewed by Michael Catanzaro.
1672
1673         It's possible for generateBuildSystemForCMakeProject to be called
1674         before determineArchitecture() is ever called. This will make the
1675         first eq check with $architecture to be bogus (and print a
1676         warning). Change that to an eq check with architecture(), which
1677         implicitly calls determineArchitecture() if needed, and change all
1678         the other similar cases in the method in the same way to prevent
1679         future bugs like this one.
1680
1681         * Scripts/webkitdirs.pm:
1682         (generateBuildSystemFromCMakeProject):
1683
1684 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1685
1686         [WPE] Tarballs generated with “make dist” cannot build documentation
1687         https://bugs.webkit.org/show_bug.cgi?id=195885
1688
1689         Reviewed by Carlos Garcia Campos.
1690
1691         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1692
1693 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1694
1695         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1696         https://bugs.webkit.org/show_bug.cgi?id=195883
1697
1698         Reviewed by Carlos Garcia Campos.
1699
1700         * gtkdoc/gtkdoc.py:
1701         (GTKDoc._run_command): When commands fail to run, include the full command line for
1702         the program invocation and the output it has generated on the standard error stream.
1703
1704 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1705
1706         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1707         https://bugs.webkit.org/show_bug.cgi?id=195786
1708
1709         Reviewed by Philippe Normand.
1710
1711         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1712         * wpe/jhbuild.modules: Ditto.
1713
1714 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1715
1716         [ews-build] Don't run clean builds on EWS builders
1717         https://bugs.webkit.org/show_bug.cgi?id=195851
1718
1719         Reviewed by Geoffrey Garen.
1720
1721         * BuildSlaveSupport/ews-build/factories.py:
1722
1723 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1724
1725         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1726         https://bugs.webkit.org/show_bug.cgi?id=195849
1727
1728         Reviewed by Chris Dumez.
1729
1730         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1731
1732         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1733         (runWebsiteDataStoreCustomPaths):
1734
1735 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1736
1737         webkitpy: Upload test results
1738         https://bugs.webkit.org/show_bug.cgi?id=195755
1739         <rdar://problem/48896182>
1740
1741         Reviewed by Aakash Jain.
1742
1743         Establish a new format for uploading results that is not tied to layout tests, apply
1744         that format to webkitpy tests.
1745
1746         * Scripts/webkitpy/common/checkout/scm/git.py:
1747         (Git.native_branch): Return what branch the current checkout is on.
1748         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1749         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1750         * Scripts/webkitpy/common/checkout/scm/svn.py:
1751         (SVN.native_branch): Ditto.
1752         * Scripts/webkitpy/common/system/platforminfo.py:
1753         (PlatformInfo.build_version): Return a build version for Mac.
1754         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1755         (MockPlatformInfo.__init__):
1756         (MockPlatformInfo.build_version):
1757         * Scripts/webkitpy/results: Added.
1758         * Scripts/webkitpy/results/__init__.py: Added.
1759         * Scripts/webkitpy/results/options.py: Added.
1760         (upload_options): OptParse list for upload options.
1761         * Scripts/webkitpy/results/upload.py: Added.
1762         (Upload): Class which enforces the upload format expected by the results server.
1763         (Upload.Expectations):
1764         (Upload.create_configuration):
1765         (Upload.create_commit):
1766         (Upload.create_details):
1767         (Upload.create_run_stats):
1768         (Upload.create_test_result):
1769         (Upload.__init__):
1770         (Upload.Encoder): Encode Upload object as json.
1771         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1772         * Scripts/webkitpy/results/upload_unittest.py: Added.
1773         * Scripts/webkitpy/test/main.py:
1774         (Tester._parse_args): Add upload arguments.
1775         (Tester._run_tests): Allow results to be uploaded.
1776         * Scripts/webkitpy/test/runner.py:
1777         (Runner.__init__): Record which tests were run, rather than just counting them.
1778         (Runner.handle):
1779         * Scripts/webkitpy/test/runner_unittest.py:
1780         (RunnerTest.test_run):
1781         * Scripts/webkitpy/thirdparty/__init__.py:
1782         (AutoinstallImportHook.find_module): Add requests auto-install.
1783         (AutoinstallImportHook._install_requests):
1784         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1785         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1786
1787 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1788
1789         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1790         https://bugs.webkit.org/show_bug.cgi?id=195810
1791
1792         Reviewed by Tim Horton.
1793
1794         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1795         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1796         ending certain layout tests.
1797
1798         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1799         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1800         (-[TestRunnerWKWebView dealloc]):
1801         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1802
1803         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1804         helper method when destroying the web view, and when resetting state between tests.
1805
1806         * WebKitTestRunner/ios/TestControllerIOS.mm:
1807         (WTR::TestController::platformResetStateToConsistentValues):
1808
1809         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1810
1811 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1812
1813         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1814         https://bugs.webkit.org/show_bug.cgi?id=190350
1815         <rdar://problem/45089503>
1816
1817         Reviewed by Geoffrey Garen.
1818
1819         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1820         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1821         (TEST):
1822         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1823         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1824         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1825         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1826         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1827         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1828         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1829         (runTest):
1830         (createDirectories):
1831         (TEST):
1832         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1833         (TEST):
1834         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1835         (TEST):
1836
1837 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1838
1839         Add support to WebPage for getting the contents as an attributed string.
1840         https://bugs.webkit.org/show_bug.cgi?id=195636
1841         rdar://problem/45055697
1842
1843         Reviewed by Tim Horton.
1844
1845         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1846         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1847
1848 2019-03-15  Chris Dumez  <cdumez@apple.com>
1849
1850         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1851         https://bugs.webkit.org/show_bug.cgi?id=195747
1852
1853         Reviewed by Geoff Garen.
1854
1855         Add API test coverage.
1856
1857         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1858
1859 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1860
1861         Unreviewed, rolling out r242952.
1862
1863         Causing API failures on iOS Simulator
1864
1865         Reverted changeset:
1866
1867         "[PSON] Make sure the WebProcessCache is leverage when
1868         relaunching a process after termination"
1869         https://bugs.webkit.org/show_bug.cgi?id=195747
1870         https://trac.webkit.org/changeset/242952
1871
1872 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1873
1874         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1875         https://bugs.webkit.org/show_bug.cgi?id=195740
1876
1877         Reviewed by Ross Kirsling.
1878
1879         window.open doesn't work for WebKitBrowserWindow because it is not
1880         implemented yet.
1881
1882         1. Implemented createNewPage callback of WKPageUIClient.
1883         2. Changed MainWindow to take a BrowserWindow factory function
1884           instead of BrowserWindowType to be flexible to create
1885           BrowserWindow with extra settings.
1886         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1887           because it is not relevant with MainWindow anymore.
1888
1889         * MiniBrowser/win/Common.cpp:
1890         (parseCommandLine):
1891         * MiniBrowser/win/Common.h:
1892         (CommandLineOptions::CommandLineOptions):
1893         * MiniBrowser/win/MainWindow.cpp:
1894         (MainWindow::MainWindow):
1895         (MainWindow::create):
1896         (MainWindow::init):
1897         (MainWindow::WndProc):
1898         * MiniBrowser/win/MainWindow.h:
1899         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1900         (PrintWebUIDelegate::createWebViewWithRequest):
1901         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1902         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1903         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1904         (WebKitBrowserWindow::updateProxySettings):
1905         (WebKitBrowserWindow::createNewPage):
1906         * MiniBrowser/win/WebKitBrowserWindow.h:
1907         * MiniBrowser/win/WinMain.cpp:
1908         (wWinMain):
1909
1910 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1911
1912         Make it possible to test scrolling tree layer manipulation more easily
1913         https://bugs.webkit.org/show_bug.cgi?id=195780
1914
1915         Reviewed by Tim Horton.
1916         
1917         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1918         cuts off communication of scrolling tree scrolls back to the web process
1919         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1920         allows tests to trigger scrolls which run the scrolling tree layer positioning
1921         logic, but never get another commit from the web process that might mask
1922         scrolling tree bugs.
1923         
1924         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1925         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1926         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1927
1928         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1929         (WTR::UIScriptController::scrollUpdatesDisabled const):
1930         (WTR::UIScriptController::setScrollUpdatesDisabled):
1931         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1932         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1933         (WTR::UIScriptController::scrollUpdatesDisabled const):
1934         (WTR::UIScriptController::setScrollUpdatesDisabled):
1935         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1936         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1937         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1938         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1939         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1940         * WebKitTestRunner/ios/TestControllerIOS.mm:
1941         (WTR::TestController::platformResetStateToConsistentValues):
1942         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1943         (WTR::UIScriptController::scrollUpdatesDisabled const):
1944         (WTR::UIScriptController::setScrollUpdatesDisabled):
1945
1946 2019-03-14  Youenn Fablet  <youenn@apple.com>
1947
1948         Move IDB storage in private browsing mode to NetworkProcess
1949         https://bugs.webkit.org/show_bug.cgi?id=195602
1950
1951         Reviewed by Brady Eidson.
1952
1953         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1954         (TEST):
1955
1956 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1957
1958         [ews-build] Make descriptionDone messages more readable
1959         https://bugs.webkit.org/show_bug.cgi?id=195760
1960
1961         Reviewed by Lucas Forschler.
1962
1963         * BuildSlaveSupport/ews-build/steps.py:
1964         * BuildSlaveSupport/ews-build/steps_unittest.py:
1965
1966 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1967
1968         [ews-build] Generate status-bubble hover-over messages
1969         https://bugs.webkit.org/show_bug.cgi?id=195680
1970
1971         Reviewed by Lucas Forschler.
1972
1973         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1974         (StatusBubble):
1975         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1976         on hover-over.
1977         (StatusBubble._iso_time):
1978         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1979         hover-over message.
1980         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1981
1982 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1983
1984         [ews-app] Gracefully handle the case when state_string is None
1985         https://bugs.webkit.org/show_bug.cgi?id=195753
1986
1987         Reviewed by Lucas Forschler.
1988
1989         * BuildSlaveSupport/ews-app/ews/models/build.py:
1990         * BuildSlaveSupport/ews-app/ews/models/step.py:
1991
1992 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1993
1994         [ews-app] Status bubble display pending for currently running build step
1995         https://bugs.webkit.org/show_bug.cgi?id=195744
1996
1997         Reviewed by Lucas Forschler.
1998
1999         * BuildSlaveSupport/ews-build/events.py:
2000         (Events.stepStarted): If state_string is pending, replace it with step name.
2001
2002 2019-03-14  Chris Dumez  <cdumez@apple.com>
2003
2004         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2005         https://bugs.webkit.org/show_bug.cgi?id=195750
2006
2007         Reviewed by Geoffrey Garen.
2008
2009         Add API test coverage.
2010
2011         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2012         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2013         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2014         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2015
2016 2019-03-14  Chris Dumez  <cdumez@apple.com>
2017
2018         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2019         https://bugs.webkit.org/show_bug.cgi?id=195747
2020
2021         Reviewed by Geoff Garen.
2022
2023         Add API test coverage.
2024
2025         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2026
2027 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2028
2029         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2030         https://bugs.webkit.org/show_bug.cgi?id=195725
2031         <rdar://problem/48545062>
2032
2033         Reviewed by Tim Horton.
2034
2035         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2036         handler is nil.
2037
2038         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2039         (TestWebKitAPI::TEST):
2040
2041 2019-03-13  Sam Weinig  <sam@webkit.org>
2042
2043         Add utility function to allow easy reverse range-based iteration of a container
2044         https://bugs.webkit.org/show_bug.cgi?id=195542
2045
2046         Reviewed by Antti Koivisto.
2047
2048         * TestWebKitAPI/CMakeLists.txt:
2049         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2050         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2051         (TestWebKitAPI::TEST):
2052         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2053
2054 2019-03-13  Chris Dumez  <cdumez@apple.com>
2055
2056         Use a ServiceWorker process per registrable domain
2057         https://bugs.webkit.org/show_bug.cgi?id=195649
2058
2059         Reviewed by Youenn Fablet.
2060
2061         Update API test coverage.
2062
2063         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2064
2065 2019-03-13  Chris Dumez  <cdumez@apple.com>
2066
2067         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2068         https://bugs.webkit.org/show_bug.cgi?id=195684
2069         <rdar://problem/48294714>
2070
2071         Reviewed by Antti Koivisto.
2072
2073         Add API test coverage.
2074
2075         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2076
2077 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2078
2079         [ews-app] Remove unused patch view
2080         https://bugs.webkit.org/show_bug.cgi?id=195669
2081
2082         Reviewed by Lucas Forschler.
2083
2084         * BuildSlaveSupport/ews-app/ews/urls.py:
2085         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2086
2087 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2088
2089         [ews-app] Use Buildbot result code variables
2090         https://bugs.webkit.org/show_bug.cgi?id=195668
2091
2092         Reviewed by Alexey Proskuryakov.
2093
2094         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2095         (Buildbot): Added Buildbot result code variables.
2096         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2097         (StatusBubble._build_bubble): Used Buildbot result code variables.
2098
2099 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2100
2101         [Flatpak] Expand submodule recursively
2102         https://bugs.webkit.org/show_bug.cgi?id=195672
2103
2104         Building WPE with flatpak was impossible without that as it was raising an exception.
2105         Also update wpebackend-fdo to match what is built in jhbuild
2106
2107         Reviewed by Philippe Normand.
2108
2109         * flatpak/flatpakutils.py:
2110         (expand_submodules_recurse):
2111         (expand_manifest):
2112         * flatpak/org.webkit.WPEModules.yaml:
2113
2114 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2115
2116         [ews-app] status bubble should be hidden for certain builds
2117         https://bugs.webkit.org/show_bug.cgi?id=194597
2118
2119         Reviewed by Dewei Zhu.
2120
2121         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2122         (StatusBubble._build_bubble):
2123         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2124         because the patch didn't have relevant changes.
2125         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2126         in production yet.
2127
2128 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2129
2130         [Win] Fix a slew of simple clang-cl warnings.
2131         https://bugs.webkit.org/show_bug.cgi?id=195652
2132
2133         Reviewed by Don Olmstead.
2134
2135         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2136         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2137
2138 2019-03-12  Justin Fan  <justin_fan@apple.com>
2139
2140         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2141         https://bugs.webkit.org/show_bug.cgi?id=195518
2142         <rdar://problem/46322356>
2143
2144         Reviewed by Myles C. Maxfield.
2145
2146         * DumpRenderTree/DerivedSources-input.xcfilelist:
2147         * DumpRenderTree/DerivedSources-output.xcfilelist:
2148
2149 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2150
2151         Unreviewed, rolling out r242825.
2152         https://bugs.webkit.org/show_bug.cgi?id=195648
2153
2154         "Broke webkitpy tests with my change to
2155         lldb_dump_class_layout.py" (Requested by rmorisset on
2156         #webkit).
2157
2158         Reverted changeset:
2159
2160         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2161         classes with suspicious padding"
2162         https://bugs.webkit.org/show_bug.cgi?id=195573
2163         https://trac.webkit.org/changeset/242825
2164
2165 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2166
2167         [ews-build] Show status bubbles while the patch is waiting in queue
2168         https://bugs.webkit.org/show_bug.cgi?id=195618
2169
2170         Reviewed by Lucas Forschler.
2171
2172         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2173         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2174         enabled in initial deployment.
2175         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2176         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2177         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2178         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2179         (StatusBubble._build_bubbles_for_patch):
2180
2181 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2182
2183         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2184         https://bugs.webkit.org/show_bug.cgi?id=195573
2185
2186         Reviewed by Simon Fraser.
2187
2188         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2189
2190         * Scripts/dump-class-layout:
2191         (main):
2192         * lldb/lldb_dump_class_layout.py:
2193         (ClassLayout.__init__):
2194         (ClassLayout._compute_padding_recursive):
2195         (LLDBDebuggerInstance.dump_layout_for_classname):
2196         (LLDBDebuggerInstance):
2197         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2198         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2199
2200 2019-03-12  Chris Dumez  <cdumez@apple.com>
2201
2202         Device Orientation access permission should be denied unless explicitly granted by the client
2203         https://bugs.webkit.org/show_bug.cgi?id=195625
2204
2205         Reviewed by Youenn Fablet.
2206
2207         add API test coverage.
2208
2209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2210         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2211         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2212         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2213         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2214         (runDeviceOrientationTest):
2215         (TEST):
2216         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2217         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2218
2219 2019-03-12  Jer Noble  <jer.noble@apple.com>
2220
2221         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2222         https://bugs.webkit.org/show_bug.cgi?id=195137
2223         <rdar://problem/48810307>
2224
2225         Reviewed by Eric Carlson.
2226
2227         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2228         (TestWebKitAPI::TEST):
2229
2230 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2231
2232         [ews-build] Change urls from uat to production
2233         https://bugs.webkit.org/show_bug.cgi?id=195566
2234
2235         Reviewed by Lucas Forschler.
2236
2237         * BuildSlaveSupport/ews-app/ews/config.py:
2238         * BuildSlaveSupport/ews-build/events.py:
2239         * BuildSlaveSupport/ews-build/steps.py:
2240
2241 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2242
2243         [ews-build] change max_builds for local-worker to 1
2244         https://bugs.webkit.org/show_bug.cgi?id=195568
2245
2246         Reviewed by Lucas Forschler.
2247
2248         * BuildSlaveSupport/ews-build/loadConfig.py:
2249
2250 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2251
2252         Fix the build
2253
2254         * TestRunnerShared/spi/PencilKitTestSPI.h:
2255         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2256
2257 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2258
2259         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2260         https://bugs.webkit.org/show_bug.cgi?id=194131
2261
2262         Reviewed by Michael Catanzaro.
2263
2264         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2265         (uriChanged):
2266         (testUnfinishedSubresourceLoad):
2267         (serverCallback):
2268         (beforeAll):
2269
2270 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2271
2272         WTF::Expected should use std::addressof instead of operator&
2273         https://bugs.webkit.org/show_bug.cgi?id=195604
2274
2275         Reviewed by Myles Maxfield.
2276
2277         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2278         (TestWebKitAPI::Unique::Unique):
2279         (TestWebKitAPI::Unique::operator&):
2280         (TestWebKitAPI::TEST):
2281
2282 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2283
2284         Add Optional to Forward.h.
2285         https://bugs.webkit.org/show_bug.cgi?id=195586
2286
2287         Reviewed by Darin Adler.
2288
2289         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2290         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2291         Remove unnecessary includes from headers.
2292
2293 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2294
2295         Add testing API to hit-test and scroll overflow scrollers
2296         https://bugs.webkit.org/show_bug.cgi?id=195278
2297
2298         Reviewed by Antti Koivisto.
2299         
2300         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2301         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2302         
2303         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2304
2305         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2306         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2307         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2308         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2309         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2310         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2311         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2312         (WTR::enclosingScrollViewIncludingSelf):
2313         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2314
2315 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2316
2317         API test WebKit.RequestTextInputContext fails on iOS
2318         https://bugs.webkit.org/show_bug.cgi?id=195585
2319
2320         Reviewed by Wenson Hsieh and Simon Fraser.
2321
2322         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2323         (applyStyle):
2324         (TEST):
2325         Add a viewport, so that the coordinates match up on iOS.
2326         Scroll by moving the UIScrollView's contentOffset.
2327
2328 2019-03-11  Chris Dumez  <cdumez@apple.com>
2329
2330         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2331         https://bugs.webkit.org/show_bug.cgi?id=195506
2332         <rdar://problem/48733477>
2333
2334         Reviewed by Alex Christensen.
2335
2336         Add API test coverage.
2337
2338         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2339
2340 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2341
2342         Adding myself to contributors.json
2343
2344         Unreviewed, addming myself to contributors.json .
2345
2346         * Scripts/webkitpy/common/config/contributors.json:
2347
2348 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2349
2350         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2351         https://bugs.webkit.org/show_bug.cgi?id=195511
2352         <rdar://problem/44873269>
2353
2354         Reviewed by Darin Adler.
2355
2356         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2357         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2358         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2359         (TEST_F):
2360
2361 2019-03-11  Chris Dumez  <cdumez@apple.com>
2362
2363         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2364         https://bugs.webkit.org/show_bug.cgi?id=195561
2365
2366         Reviewed by Youenn Fablet.
2367
2368         Make sure the JS in the test requests for permission to receive device orientation events.
2369
2370         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2371
2372 2019-03-11  Youenn Fablet  <youenn@apple.com>
2373
2374         Allow storage quota increase by default in WTR
2375         https://bugs.webkit.org/show_bug.cgi?id=195541
2376
2377         Reviewed by Geoffrey Garen.
2378
2379         Allow storage quota increase by default in WTR.
2380         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2381         Use this for tests that explicitly need cache increase.
2382
2383         Instead of increasing quota by 2, make sure the next request is
2384         granted by adding all given parameters.
2385
2386         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2387         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2388         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2389         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2390         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2391         * WebKitTestRunner/TestController.cpp:
2392         (WTR::TestController::setAllowStorageQuotaIncrease):
2393         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2394         * WebKitTestRunner/TestController.h:
2395         * WebKitTestRunner/TestInvocation.cpp:
2396         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2397         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2398         (WTR::TestController::cocoaResetStateToConsistentValues):
2399         (WTR::TestController::setAllowStorageQuotaIncrease):
2400         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2401         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2402         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2403
2404 2019-03-11  Xan Lopez  <xan@igalia.com>
2405
2406         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2407         https://bugs.webkit.org/show_bug.cgi?id=194147
2408
2409         Reviewed by Michael Saboff.
2410
2411         To make --32-bit work correctly on Linux/64bit we need to:
2412
2413         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2414         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2415         unfortunately CMake only allows us to do this during
2416         crosscompilation, which is overkill here.
2417         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2418         pkg-config detection module uses the x86 .pc files instead of the
2419         x86_64 ones.
2420         - Set the -m32 flags for the compiler.
2421
2422         * Scripts/webkitdirs.pm:
2423         (generateBuildSystemFromCMakeProject):
2424
2425 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2426
2427         Add MotionMark-1.1 plan file for run-benchmark script.
2428         https://bugs.webkit.org/show_bug.cgi?id=195481
2429
2430         Rubber-stamped by Darin Adler.
2431
2432         Run-benchmark script should support MontionMark-1.1.
2433
2434         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2435
2436 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2437
2438         [ews-app] Add support for submit-to-ews url
2439         https://bugs.webkit.org/show_bug.cgi?id=195477
2440
2441         Reviewed by Lucas Forschler.
2442
2443         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2444         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2445         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2446         * BuildSlaveSupport/ews-app/ews/urls.py:
2447         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2448
2449 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2450
2451         Unreviewed, rolling out r242688, r242643, r242624.
2452
2453         Caused multiple layout test failures and crashes on iOS and macOS.
2454
2455         Reverted changeset:
2456
2457         "requestAnimationFrame should execute before the next frame"
2458         https://bugs.webkit.org/show_bug.cgi?id=177484
2459         https://trac.webkit.org/changeset/242624/webkit
2460
2461         * Tracing/SystemTracePoints.plist:
2462
2463 2019-03-11  John Wilander  <wilander@apple.com>
2464
2465         Resource Load Statistics: Make it possible exclude localhost from classification
2466         https://bugs.webkit.org/show_bug.cgi?id=195474
2467         <rdar://problem/47520577>
2468
2469         Reviewed by Brent Fulgham.
2470
2471         This patch allows for localhost to be excluded from classification and
2472         treatment as a prevalent resource.
2473
2474         The WebKit Tools change adds a new function called
2475         testRunner.setStatisticsIsRunningTest() which can be used to control this
2476         behavior.
2477
2478         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2479         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2480         (WTR::TestRunner::setStatisticsIsRunningTest):
2481         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2482         * WebKitTestRunner/TestController.cpp:
2483         (WTR::TestController::setStatisticsIsRunningTest):
2484         * WebKitTestRunner/TestController.h:
2485         * WebKitTestRunner/TestInvocation.cpp:
2486         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2487
2488 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2489
2490         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2491         https://bugs.webkit.org/show_bug.cgi?id=195560
2492
2493         Reviewed by Lucas Forschler.
2494
2495         * BuildSlaveSupport/ews-build/master.cfg:
2496
2497 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2498
2499         Unreviewed, rolling out r242698.
2500
2501         API test crashes on bots.
2502
2503         Reverted changeset:
2504
2505         "Add a WKContentRuleList variant that uses copied memory
2506         instead of mmap'd shared memory for class A containerized
2507         apps"
2508         https://bugs.webkit.org/show_bug.cgi?id=195511
2509         https://trac.webkit.org/changeset/242698
2510
2511 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2512
2513         [WPE] Enable web process sandbox
2514         https://bugs.webkit.org/show_bug.cgi?id=195169
2515
2516         Reviewed by Daniel Bates.
2517
2518         * wpe/install-dependencies:
2519         * wpe/jhbuild.modules:
2520
2521 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2522
2523         [ews-app] Use port 17000 for worker communication
2524         https://bugs.webkit.org/show_bug.cgi?id=195558
2525
2526         Reviewed by Lucas Forschler.
2527
2528         * BuildSlaveSupport/ews-build/master.cfg:
2529
2530 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2531
2532         [ews-build] unit-tests fail when passwords.json is missing
2533         https://bugs.webkit.org/show_bug.cgi?id=195557
2534
2535         Reviewed by Lucas Forschler.
2536
2537         * BuildSlaveSupport/ews-build/loadConfig.py:
2538         (loadBuilderConfig):
2539         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2540         (ConfigDotJSONTest.test_configuration):
2541         * BuildSlaveSupport/ews-build/master.cfg:
2542
2543 2019-03-11  Truitt Savell  <tsavell@apple.com>
2544
2545         Unreviewed, rolling out r242702.
2546
2547         Broke High Sierra builders.
2548
2549         Reverted changeset:
2550
2551         "Add utility function to allow easy reverse range-based
2552         iteration of a container"
2553         https://bugs.webkit.org/show_bug.cgi?id=195542
2554         https://trac.webkit.org/changeset/242702
2555
2556 2019-03-11  Sam Weinig  <sam@webkit.org>
2557
2558         Add utility function to allow easy reverse range-based iteration of a container
2559         https://bugs.webkit.org/show_bug.cgi?id=195542
2560
2561         Reviewed by Antti Koivisto.
2562
2563         * TestWebKitAPI/CMakeLists.txt:
2564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2565         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2566         (TestWebKitAPI::TEST):
2567         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2568
2569 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2570
2571         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2572         https://bugs.webkit.org/show_bug.cgi?id=195511
2573         <rdar://problem/44873269>
2574
2575         Reviewed by Darin Adler.
2576
2577         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2578         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2579         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2580         (TEST_F):
2581
2582 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2583
2584         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2585         https://bugs.webkit.org/show_bug.cgi?id=195499
2586
2587         Reviewed by Darin Adler.
2588
2589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2590         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2591         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2592         (-[WKWebView synchronouslyFocusTextInputContext:]):
2593         (applyStyle):
2594         (applyIframe):
2595         (TEST):
2596         Add some tests for this SPI.
2597
2598 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2599
2600         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2601         https://bugs.webkit.org/show_bug.cgi?id=181151
2602
2603         Reviewed by Don Olmstead.
2604
2605         * TestWebKitAPI/CMakeLists.txt:
2606         * TestWebKitAPI/PlatformWin.cmake:
2607         Enable TestWTF RunLoop tests in all platforms.
2608
2609         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2610         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2611         (TestWebKitAPI::DerivedOneShotTimer::fired):
2612         (TestWebKitAPI::TEST):
2613         Only a few platforms support nested RunLoop.
2614
2615         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2616         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2617
2618 2019-03-10  David Quesada  <david_quesada@apple.com>
2619
2620         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2621         https://bugs.webkit.org/show_bug.cgi?id=152480
2622
2623         Reviewed by Chris Dumez.
2624
2625         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2626         there are no additional references to the process pool besides the one held by
2627         the download, waits for the download to finish (in the sense that the
2628         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2629         measure, also check that the process pool has been deallocated at the end of the
2630         test. The test wouldn't be meaningful if the process pool were still alive.
2631
2632         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2633         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2634         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2635             The download will be canceled because the delegate does not implement the
2636             method to decide the download's destination, so this is where we know the
2637             DownloadProxyMap is done with the DownloadProxy.
2638         (TEST):
2639
2640 2019-03-08  Chris Dumez  <cdumez@apple.com>
2641
2642         Add support for Device Orientation / Motion permission API
2643         https://bugs.webkit.org/show_bug.cgi?id=195329
2644         <rdar://problem/47645367>
2645
2646         Reviewed by Geoffrey Garen.
2647
2648         Add test infrastructure to help test the Device Orientation / Motion permission API.
2649
2650         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2651         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2652         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2653         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2654         * WebKitTestRunner/TestController.cpp:
2655         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2656         (WTR::TestController::createWebViewWithOptions):
2657         (WTR::TestController::resetStateToConsistentValues):
2658         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2659         * WebKitTestRunner/TestController.h:
2660         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2661         * WebKitTestRunner/TestInvocation.cpp:
2662         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2663
2664 2019-03-08  Saam barati  <sbarati@apple.com>
2665
2666         Add a compare-results script to compare benchmark results
2667         https://bugs.webkit.org/show_bug.cgi?id=195486
2668         <rdar://problem/48723397>
2669
2670         Reviewed by Geoffrey Garen.
2671
2672         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2673         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2674         to extend it to learn about our other benchmarks.
2675
2676         * Scripts/compare-results: Added.
2677         (readJSONFile):
2678         (detectJetStream2):
2679         (JetStream2Results):
2680         (detectSpeedometer2):
2681         (Speedometer2Results):
2682         (detectPLT5):
2683         (PLT5Results):
2684         (detectBenchmark):
2685         (biggerIsBetter):
2686         (ttest):
2687         (getOptions):
2688         (main):
2689
2690 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2691
2692         Ensure old tab state is cleared between iterations of run-benchmark
2693         https://bugs.webkit.org/show_bug.cgi?id=195393
2694         <rdar://problem/46885583>
2695
2696         Reviewed by Dewei Zhu.
2697
2698         a) ensure the default to restore state is not set
2699         b) terminate Safari correctly
2700         c) Set the system default to ignore Persistent State in Safari
2701
2702         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2703         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2704         (OSXBrowserDriver.prepare_env): 
2705         (OSXBrowserDriver.restore_env):
2706         (OSXBrowserDriver.close_browsers):
2707         (OSXBrowserDriver._terminate_processes):
2708         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2709         (OSXChromeDriver):
2710         (OSXChromeCanaryDriver):
2711         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2712         (OSXFirefoxDriver):
2713         (OSXFirefoxNightlyDriver):
2714         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2715         (OSXSafariDriver):
2716         (OSXSafariDriver.prepare_env):
2717
2718 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2719
2720         [GTK] Several InputMethodFilter tests are failing
2721         https://bugs.webkit.org/show_bug.cgi?id=195408
2722
2723         Reviewed by Carlos Garcia Campos.
2724
2725         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2726         Regressed in r241751.
2727         Hexadecimal values of keycodes are expressed now in upper letters.
2728         Composited characters should be cast to UTF8 strings.
2729
2730         (TestWebKitAPI::TEST):
2731
2732 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2733
2734         [GTK] Make Tools/gtkdoc python3 compatible
2735         https://bugs.webkit.org/show_bug.cgi?id=195359
2736
2737         Reviewed by Carlos Garcia Campos.
2738
2739         * gtkdoc/generate-gtkdoc:
2740         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2741         work with Python 2 and 3.
2742         (get_gtkdoc_module_paths):
2743         The iteritems() was removed in Python 3, so let's use items() that's
2744         available in Python 2 and 3.
2745         (get_generator_for_config):
2746         * gtkdoc/gtkdoc.py:
2747         (GTKDoc._run_command):
2748         The sys.stdout.write() is expecting str in Python 3 and not bytes
2749         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2750         for passing the bytes there.
2751
2752 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2753
2754         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2755         https://bugs.webkit.org/show_bug.cgi?id=195346
2756         <rdar://problem/48667048>
2757
2758         Unreviewed build fix for clang-cl.
2759
2760         * DumpRenderTree/win/DumpRenderTree.cpp:
2761         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2762
2763 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2764
2765         requestAnimationFrame should execute before the next frame
2766         https://bugs.webkit.org/show_bug.cgi?id=177484
2767
2768         Reviewed by Simon Fraser.
2769
2770         Add trace points for the page RenderingUpdate.
2771
2772         * Tracing/SystemTracePoints.plist:
2773
2774 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2775
2776         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2777         https://bugs.webkit.org/show_bug.cgi?id=195353
2778         <rdar://problem/48626394>
2779
2780         Reviewed by Simon Fraser.
2781
2782         * WebKitTestRunner/ios/TestControllerIOS.mm:
2783         (WTR::TestController::platformResetPreferencesToConsistentValues):
2784
2785 2019-03-07  John Wilander  <wilander@apple.com>
2786
2787         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2788         https://bugs.webkit.org/show_bug.cgi?id=195383
2789         <rdar://problem/48570136>
2790
2791         Reviewed by Brent Fulgham.
2792
2793         This patch adds test infrastructure to purge only script-accessible cookies,
2794         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2795
2796         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2797         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2798         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2799         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2800         * WebKitTestRunner/TestController.cpp:
2801         (WTR::TestController::statisticsDeleteCookiesForHost):
2802         * WebKitTestRunner/TestController.h:
2803         * WebKitTestRunner/TestInvocation.cpp:
2804         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2805
2806 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2807
2808         Unreviewed, rolling out r242354.
2809         https://bugs.webkit.org/show_bug.cgi?id=195402
2810
2811         breaks layout tests in all configurations (Requested by
2812         zdobersek on #webkit).
2813
2814         Reverted changeset:
2815
2816         "[WPE] Enable web process sandbox"
2817         https://bugs.webkit.org/show_bug.cgi?id=195169
2818         https://trac.webkit.org/changeset/242354
2819
2820 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2821
2822         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2823         https://bugs.webkit.org/show_bug.cgi?id=195346
2824
2825         Reviewed by Fujii Hironori.
2826
2827         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2828         (TestWebKitAPI::TEST):
2829         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2830
2831         * DumpRenderTree/win/DumpRenderTree.cpp:
2832         (findFontFallback):
2833         (addFontFallbackIfPresent):
2834         (removeFontFallbackIfPresent):
2835         (main):
2836         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2837         (TestWebKitAPI::Util::moduleDirectory):
2838         (TestWebKitAPI::Util::createInjectedBundlePath):
2839         Use wchar helpers as needed.
2840
2841 2019-03-06  Rob Buis  <rbuis@igalia.com>
2842
2843         Consider supporting the `referrerpolicy` attribute.
2844         https://bugs.webkit.org/show_bug.cgi?id=179053
2845
2846         Reviewed by Darin Adler.
2847
2848         Add a runtime flag for referrerpolicy attribute.
2849
2850         * DumpRenderTree/mac/DumpRenderTree.mm:
2851         (enableExperimentalFeatures):
2852
2853 2019-03-05  Daniel Bates  <dabates@apple.com>
2854
2855         Update expected API test result following r242379
2856         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2857
2858         Update expected x-coordinate of selection rect now that the left padding of
2859         a textarea is sized in ems (so dependent on the font size) just like the left
2860         padding of a text field.
2861
2862         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2863         (TestWebKitAPI::TEST):
2864
2865 2019-03-05  David Quesada  <david_quesada@apple.com>
2866
2867         [WK2] It should be possible to follow links with 'download' attributes
2868         https://bugs.webkit.org/show_bug.cgi?id=195145
2869         rdar://problem/48462642
2870
2871         Reviewed by Alex Christensen.
2872
2873         Add a unit test to verify that activating links with 'download' attributes now
2874         navigates to the linked resource, rather than starts downloading it. Add another
2875         to verify that it is still possible to explicitly download the link via the
2876         'Download' navigation action policy.
2877
2878         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2879         (-[DownloadAttributeTestDelegate init]):
2880         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2881         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2882         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2883         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2884         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2885         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2886         (TEST):
2887         * WebKitTestRunner/TestController.cpp:
2888         (WTR::TestController::decidePolicyForNavigationAction):
2889         * WebKitTestRunner/TestController.h:
2890
2891 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2892
2893         [Curl] Implement Cookie Accept Policy.
2894         https://bugs.webkit.org/show_bug.cgi?id=191645
2895
2896         Reviewed by Fujii Hironori.
2897
2898         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2899         (TestWebKitAPI::Curl::TEST_F):
2900
2901 2019-03-05  Youenn Fablet  <youenn@apple.com>
2902
2903         Rename requestCacheStorageSpace to requestStorageSpace
2904         https://bugs.webkit.org/show_bug.cgi?id=195282
2905
2906         Reviewed by Chris Dumez.
2907
2908         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2909         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2910         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2911
2912 2019-03-05  Brady Eidson  <beidson@apple.com>
2913
2914         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2915         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2916
2917         Reviewed by Tim Horton.
2918
2919         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2920         different directory into that same WKWebView should work.
2921
2922         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2923         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2924
2925 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2926
2927         Add WeakHashSet
2928         https://bugs.webkit.org/show_bug.cgi?id=195152
2929
2930         Reviewed by Antti Koivisto.
2931
2932         Added tests for WeakHashSet.
2933
2934         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2935         (TestWebKitAPI::Base::Base): Moved.
2936         (TestWebKitAPI::Derived::foo): Moved.
2937         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2938         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2939         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2940         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2941
2942 2019-03-04  Chris Dumez  <cdumez@apple.com>
2943
2944         Do not share WebProcesses between private and regular sessions
2945         https://bugs.webkit.org/show_bug.cgi?id=195189
2946         <rdar://problem/48421064>
2947
2948         Reviewed by Alex Christensen.
2949
2950         Add API test coverage.
2951
2952         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2953         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2954
2955 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2956
2957         [WPE] Enable web process sandbox
2958         https://bugs.webkit.org/show_bug.cgi?id=195169
2959
2960         Reviewed by Daniel Bates.
2961
2962         * wpe/install-dependencies:
2963         * wpe/jhbuild.modules:
2964
2965 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2966
2967         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2968         https://bugs.webkit.org/show_bug.cgi?id=195206
2969
2970         Reviewed by Žan Doberšek.
2971
2972         Add a new test case.
2973
2974         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2975         (testJSCClass):
2976
2977 2019-03-04  Charlie Turner  <cturner@igalia.com>
2978
2979         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2980         https://bugs.webkit.org/show_bug.cgi?id=194898
2981
2982         Reviewed by Žan Doberšek.
2983
2984         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2985         a GCC extension that permits arithmetic on void* pointer. Inline
2986         the macro until this issue is fixed upstream.
2987
2988 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2989
2990         Rid the world of WK_API_ENABLED
2991         https://bugs.webkit.org/show_bug.cgi?id=195263
2992
2993         Reviewed by Dan Bernstein.
2994
2995         List of changed files elided because it's useless.
2996
2997 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2998
2999         Unreviewed follow-up to r242292.
3000
3001         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3002
3003         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3004         (TestWebKitAPI::testStrip): Renamed from strip.
3005         (TestWebKitAPI::TEST):
3006
3007 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3008
3009         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3010
3011         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3012         and bug #194272 for details.
3013
3014         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3015
3016 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3017
3018         Remove some more unused 32-bit code
3019         https://bugs.webkit.org/show_bug.cgi?id=195255
3020
3021         Reviewed by Darin Adler.
3022
3023         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3024         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3025         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3026         (NPP_New):
3027         (NPP_HandleEvent):
3028         (handleEventCarbon): Deleted.
3029
3030 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3031
3032         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3033
3034         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3035         (TestWebKitAPI::TEST):
3036
3037 2019-03-01  Darin Adler  <darin@apple.com>
3038
3039         Finish removing String::format
3040         https://bugs.webkit.org/show_bug.cgi?id=194893
3041
3042         Reviewed by Daniel Bates.
3043 '
3044         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3045
3046 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3047
3048         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3049         https://bugs.webkit.org/show_bug.cgi?id=195229
3050         <rdar://problem/48520362>
3051
3052         Reviewed by Chris Dumez.
3053
3054         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3055         (TEST):
3056
3057 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3058
3059         Add a system trace scope for event region building
3060         https://bugs.webkit.org/show_bug.cgi?id=195226
3061
3062         Reviewed by Jon Lee.
3063
3064         This trace scope measures the time spend converting element rects into Region objects,
3065         which can be large on some pages.
3066
3067         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3068
3069         * Tracing/SystemTracePoints.plist:
3070
3071 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3072
3073         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3074         https://bugs.webkit.org/show_bug.cgi?id=194612
3075
3076         Reviewed by Alex Christensen.
3077
3078         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3079         Just test the new string-processing function and don't touch the actual environment.
3080         (Test cases are all as before, but based on operator== instead of strcmp.)
3081
3082 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3083
3084         [ews-app] Update primary keys for handling multiple Buildbot instances
3085         https://bugs.webkit.org/show_bug.cgi?id=195120
3086
3087         Reviewed by Stephanie Lewis.
3088
3089         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3090         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3091         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3092
3093         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3094         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3095         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3096         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3097         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3098         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3099
3100 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3101
3102         [WinCairo] Enable service worker
3103         https://bugs.webkit.org/show_bug.cgi?id=188318
3104
3105         Reviewed by Youenn Fablet.
3106
3107         * DumpRenderTree/DumpRenderTreePrefix.h:
3108         * TestWebKitAPI/PlatformWin.cmake:
3109         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3110         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3111         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3112
3113 2019-03-01  Justin Fan  <justin_fan@apple.com>
3114
3115         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3116         https://bugs.webkit.org/show_bug.cgi?id=195191
3117
3118         Rubber-stamped by Dean Jackson.
3119
3120         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3121
3122         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3123
3124 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3125
3126         Unreviewed, fix lldb webkitpy tests
3127         https://bugs.webkit.org/show_bug.cgi?id=194375
3128
3129         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3130
3131         * lldb/lldb_webkit.py:
3132         (WTFStringImplProvider.is_8bit):
3133
3134 2019-02-28  David Quesada  <david_quesada@apple.com>
3135
3136         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3137         https://bugs.webkit.org/show_bug.cgi?id=195121
3138         rdar://problem/48450302
3139
3140         Reviewed by Alex Christensen.
3141
3142         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3143         configurations where the 'download' attribute is absent, blank, or populated
3144         with a filename, and where the anchor element is same-origin or cross-origin
3145         (meaning the 'download' attribute shouldn't be honored).
3146
3147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3148         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3149         (-[NavigationActionTestDelegate init]):
3150         (-[NavigationActionTestDelegate navigationAction]):
3151         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3152         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3153         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3154         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3155         (TEST):
3156
3157 2019-02-28  Antoine Quint  <graouts@apple.com>
3158
3159         Enable the Pointer Events runtime flag by default
3160         https://bugs.webkit.org/show_bug.cgi?id=195156
3161
3162         Reviewed by Dean Jackson.
3163
3164         * DumpRenderTree/mac/DumpRenderTree.mm:
3165         (enableExperimentalFeatures):
3166
3167 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3168
3169         Several PasteImage API tests are flaky
3170         https://bugs.webkit.org/show_bug.cgi?id=195160
3171
3172         Reviewed by Tim Horton.
3173
3174         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3175         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3176         listening for a "load" event after image load is already complete.
3177
3178         To address this, make these tests first register a "load" event handler, then run script to insert an image
3179         element into the document, and finally wait until the load event is observed before checking image size.
3180
3181         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3182
3183 2019-02-28  Chris Dumez  <cdumez@apple.com>
3184
3185         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3186         https://bugs.webkit.org/show_bug.cgi?id=195107
3187
3188         Reviewed by Alex Christensen.
3189
3190         Give some time for the zoom level to get restored.
3191
3192         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3193
3194 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3195
3196         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3197         https://bugs.webkit.org/show_bug.cgi?id=194958
3198
3199         Reviewed by Geoffrey Garen.
3200
3201         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3202         (TEST):
3203
3204 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3205
3206         [ews-app] Update method to save build to handle builder_display_name
3207         https://bugs.webkit.org/show_bug.cgi?id=195047
3208
3209         Reviewed by Dewei Zhu.
3210
3211         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3212         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3213
3214 2019-02-28  Justin Fan  <justin_fan@apple.com>
3215
3216         [Web GPU] Enable Web GPU only on 64-bit
3217         https://bugs.webkit.org/show_bug.cgi?id=195139
3218
3219         Because Metal is only supported on 64 bit apps.
3220
3221         Unreviewed build fix.
3222
3223         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3224
3225 2019-02-27  Youenn Fablet  <youenn@apple.com>
3226
3227         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3228         https://bugs.webkit.org/show_bug.cgi?id=194959
3229
3230         Reviewed by Chris Dumez.
3231
3232         Spin loop until getting the condition to remove flakiness.
3233
3234         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3235
3236 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3237
3238         [ews-build] Buildbot should include builder_display_name in the build events
3239         https://bugs.webkit.org/show_bug.cgi?id=195045
3240
3241         Reviewed by Dewei Zhu.
3242
3243         * BuildSlaveSupport/ews-build/events.py:
3244         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3245         buildername to builder_name to be consistent in naming style.
3246         (Events.buildFinished): Ditto.
3247
3248 2019-02-27  Chris Dumez  <cdumez@apple.com>
3249
3250         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3251         https://bugs.webkit.org/show_bug.cgi?id=194480
3252
3253         Reviewed by Brady Eidson.
3254
3255         Update existing API test to make it more likely to reproduce the issue.
3256
3257         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3258
3259 2019-02-27  Brady Eidson  <beidson@apple.com>
3260
3261         Universal links from Google search results pages don't open the app.
3262         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3263
3264         Reviewed by Geoffrey Garen.
3265
3266         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3267         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3268         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3269         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3270
3271 2019-02-27  Chris Dumez  <cdumez@apple.com>
3272
3273         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3274         https://bugs.webkit.org/show_bug.cgi?id=195102
3275
3276         Reviewed by Geoffrey Garen.
3277
3278         If the number of processes is not yet what we expect, wait a bit and check again to give
3279         processes some time to exit.
3280
3281         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3282
3283 2019-02-27  Chris Dumez  <cdumez@apple.com>
3284
3285         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3286         https://bugs.webkit.org/show_bug.cgi?id=194545
3287
3288         Reviewed by Brady Eidson.
3289
3290         Make sure the test navigates forward and then back only once. Previously, navigating
3291         back would trigger a navigation again in a timer.
3292
3293         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3294
3295 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3296
3297         High Sierra Debug JSC test queue should use faster hardware
3298         https://bugs.webkit.org/show_bug.cgi?id=194603
3299
3300         Rubber-stamped by Alexey Proskuryakov.
3301
3302         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3303
3304         * BuildSlaveSupport/build.webkit.org-config/config.json:
3305         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3306         (BubbleQueueServer):
3307         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3308         (WebKitBuildbot):
3309         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3310         * QueueStatusServer/config/queues.py:
3311         * Scripts/webkitpy/common/config/ews.json:
3312         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3313         (test_ews_name):
3314
3315 2019-02-27  John Wilander  <wilander@apple.com>
3316
3317         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3318         https://bugs.webkit.org/show_bug.cgi?id=195071
3319         <rdar://problem/48417690>
3320
3321         Reviewed by Alex Christensen and Brent Fulgham.
3322
3323         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3324         (TestWebKitAPI::createURL):
3325             Convenience function.
3326         (TestWebKitAPI::TEST):
3327             WebCore::AdClickAttribution now takes a URL when creating Source and
3328             Destination.
3329         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3330         (TestWebKitAPI::TEST):
3331             WebCore::AdClickAttribution now takes a URL when creating Source and
3332             Destination.
3333
3334 2019-02-27  Antoine Quint  <graouts@apple.com>
3335
3336         Support Pointer Events on macOS
3337         https://bugs.webkit.org/show_bug.cgi?id=195008
3338         <rdar://problem/47454419>
3339
3340         Reviewed by Dean Jackson.
3341
3342         * DumpRenderTree/mac/DumpRenderTree.mm:
3343         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3344         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3345
3346 2019-02-26  Mark Lam  <mark.lam@apple.com>
3347
3348         Remove remaining poisoning code.
3349         https://bugs.webkit.org/show_bug.cgi?id=194138
3350
3351         Reviewed by Saam Barati.
3352
3353         * TestWebKitAPI/CMakeLists.txt:
3354         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3355         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3356         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3357         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3358         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3359         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3360         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3361
3362 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3363
3364         Move ephemeral local storage from WebProcess to UIProcess
3365         https://bugs.webkit.org/show_bug.cgi?id=195074
3366         <rdar://problem/47937975>
3367
3368         Reviewed by Geoff Garen.
3369
3370         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3371
3372 2019-02-20  Jer Noble  <jer.noble@apple.com>
3373
3374         [Cocoa] Media elements will restart network buffering just before suspending
3375         https://bugs.webkit.org/show_bug.cgi?id=193691
3376
3377         Reviewed by Eric Carlson.
3378
3379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3380         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3381         (TEST):
3382
3383 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3384
3385         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3386         https://bugs.webkit.org/show_bug.cgi?id=191652
3387
3388         Reviewed by Alex Christensen.
3389
3390         Fix WinCairo MiniBrowser behavior of authentication dialog.
3391
3392         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3393         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3394
3395 2019-02-26  Youenn Fablet  <youenn@apple.com>
3396
3397         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3398         https://bugs.webkit.org/show_bug.cgi?id=195028
3399         <rdar://problem/48243733>
3400
3401         Reviewed by Eric Carlson.
3402
3403         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3404
3405 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3406
3407         [WPE] Add API for webview background color configuration
3408         https://bugs.webkit.org/show_bug.cgi?id=192305
3409
3410         Reviewed by Michael Catanzaro.
3411
3412         * MiniBrowser/wpe/main.cpp:
3413         (main): Add a new option to configure the webview background
3414         color. Example: --bg-color=transparent.
3415         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3416         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3417         (beforeAll): Ditto.
3418
3419 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3420
3421         scalableNativeWebpageParameters() is not preserved on new page navigation.
3422         https://bugs.webkit.org/show_bug.cgi?id=194892
3423         <rdar://problem/47538280>
3424
3425         Reviewed by Wenson Hsieh.
3426         
3427         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3428
3429         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3430         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3431         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3432         (WTR::UIScriptController::allowsViewportShrinkToFit):
3433         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3434         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3435         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3436         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3437         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3438         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3439
3440 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3441
3442         [ews-app] Add model for handling multiple Buildbot instances
3443         https://bugs.webkit.org/show_bug.cgi?id=194863
3444
3445         Reviewed by Stephanie Lewis.
3446
3447         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3448
3449 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3450
3451         [ews-app] Remove BuilderMapping table
3452         https://bugs.webkit.org/show_bug.cgi?id=194961
3453
3454         Reviewed by Stephanie Lewis.
3455
3456         Store builder name directly in build table, instead of having a separate
3457         table for it.
3458
3459         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3460         * BuildSlaveSupport/ews-app/ews/models/build.py:
3461         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3462         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3463
3464 2019-02-25  John Wilander  <wilander@apple.com>
3465
3466         Introduce and adopt new class RegistrableDomain for eTLD+1
3467         https://bugs.webkit.org/show_bug.cgi?id=194791
3468         <rdar://problem/48179240>
3469
3470         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3471
3472         This patch adds an API test and replaces two instances of
3473         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3474
3475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3476         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3477         (TestWebKitAPI::TEST):
3478             Changed two strings to make sure the registrable domains are still considered
3479             invalid and pass the test.
3480         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3481         (TestWebKitAPI::TEST):
3482         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3483         (WTR::InjectedBundle::didReceiveMessageToPage):
3484
3485 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3486
3487         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3488         https://bugs.webkit.org/show_bug.cgi?id=195001
3489
3490         Reviewed by Carlos Garcia Campos.
3491
3492         API version 1.0 always includes the functionality previously guarded with
3493         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3494         unconditionally.
3495
3496         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3497         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3498         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3499         (WebViewTest::showInWindow): Ditto.
3500         (WebViewTest::hideView): Ditto.
3501         * wpe/backends/HeadlessViewBackend.cpp:
3502         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3503         * wpe/backends/ViewBackend.cpp:
3504         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3505         * wpe/backends/WindowViewBackend.cpp:
3506         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3507         WPE_BACKEND_CHECK_VERSION().
3508         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3509
3510 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3511
3512         [Flatpak] Add support for flatpak > 1.1.2
3513         https://bugs.webkit.org/show_bug.cgi?id=194088
3514
3515         Flatpak 1.2 is now out so we need to support that
3516         version now.
3517
3518         Reviewed by Michael Catanzaro.
3519
3520         * flatpak/flatpakutils.py:
3521         (check_flatpak):
3522         (FlatpakPackages.__init__):
3523         (FlatpakPackages.__detect_packages):
3524         (FlatpakPackages.__detect_packages.in):
3525         (FlatpakRepos.update):
3526
3527 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3528
3529         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3530         https://bugs.webkit.org/show_bug.cgi?id=194998
3531
3532         Reviewed by Carlos Garcia Campos.
3533
3534         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3535         to a Git checkout and using the latest commit containing various fixes
3536         and improvements.
3537
3538 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3539
3540         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3541         https://bugs.webkit.org/show_bug.cgi?id=194981
3542
3543         Reviewed by Žan Doberšek.
3544
3545         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3546         (TestWebKitAPI::TEST):
3547
3548 2019-02-23  Keith Miller  <keith_miller@apple.com>
3549
3550         Add new mac target numbers
3551         https://bugs.webkit.org/show_bug.cgi?id=194955
3552
3553         Reviewed by Tim Horton.
3554
3555         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3556         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3557         * MiniBrowser/Configurations/Base.xcconfig:
3558         * TestWebKitAPI/Configurations/Base.xcconfig:
3559         * WebKitTestRunner/Configurations/Base.xcconfig:
3560
3561 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3562
3563         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3564         https://bugs.webkit.org/show_bug.cgi?id=194846
3565
3566         Reviewed by Don Olmstead.
3567
3568         Added _search_paths() and _port_specific_expectations_files() for
3569         WinCairoPort.
3570
3571         * Scripts/webkitpy/port/win.py:
3572         (WinCairoPort.default_baseline_search_path):
3573         (WinCairoPort):
3574         (WinCairoPort._port_specific_expectations_files):
3575         (WinCairoPort._search_paths):
3576
3577 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3578
3579         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3580         https://bugs.webkit.org/show_bug.cgi?id=194963
3581
3582         Reviewed by Dean Jackson.
3583
3584         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3585         Do a `contains` check instead of `equals`, because in debug builds we
3586         put the GraphicsLayer pointer in a prefix.
3587
3588 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3589
3590         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3591         https://bugs.webkit.org/show_bug.cgi?id=194873
3592         <rdar://problem/46701974>
3593
3594         Reviewed by Tim Horton.
3595
3596         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3597
3598         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3599         (WTR::UIScriptController::menuRect const):
3600         (WTR::UIScriptController::isShowingMenu const):
3601         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3602         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3603         (WTR::UIScriptController::menuRect const):
3604
3605         Add a function to query the bounds of the callout menu in content coordinates.
3606
3607         (WTR::UIScriptController::isShowingMenu const):
3608
3609         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3610
3611         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3612         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3613         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3614         (WTR::UIScriptController::rectForMenuAction const):
3615         (WTR::UIScriptController::menuRect const):
3616         (WTR::UIScriptController::isShowingMenu const):
3617         (WTR::findViewInHierarchyOfType): Deleted.
3618
3619 2019-02-22  Chris Dumez  <cdumez@apple.com>
3620
3621         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3622         https://bugs.webkit.org/show_bug.cgi?id=194954
3623         <rdar://problem/48127957>
3624
3625         Reviewed by Alex Christensen.
3626
3627         Add API test coverage.
3628
3629         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3630         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3631         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3632         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3633
3634 2019-02-22  Chris Dumez  <cdumez@apple.com>
3635
3636         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3637         https://bugs.webkit.org/show_bug.cgi?id=194924
3638         <rdar://problem/48216125>
3639
3640         Reviewed by Geoffrey Garen.
3641
3642         Add API test coverage.
3643
3644         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3645
3646 2019-02-22  Chris Dumez  <cdumez@apple.com>
3647
3648         Unreviewed, disable API test added in r241928 on iOS.
3649
3650         The cache is not enabled on devices with less than 3GB of RAM.
3651
3652         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3653
3654 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3655
3656         Hardcode Visual Viewports on everywhere except iOS WK1
3657         https://bugs.webkit.org/show_bug.cgi?id=194928
3658
3659         Reviewed by Zalan Bujtas.
3660
3661         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3662         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3663         set it to false. The setting has shipped for several years and there's no need to turn
3664         it off now.
3665
3666         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3667         Visual Viewports are not enabled.
3668         
3669         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3670         that only runs in WK2
3671
3672         * MiniBrowser/mac/SettingsController.h:
3673         * MiniBrowser/mac/SettingsController.m:
3674         (-[SettingsController init]):
3675         (-[SettingsController _populateMenu]):
3676         (-[SettingsController validateMenuItem:]):
3677         (-[SettingsController visualViewportEnabled]): Deleted.
3678         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3679         * MiniBrowser/mac/WK1BrowserWindowController.m:
3680         (-[WK1BrowserWindowController didChangeSettings]):
3681         * MiniBrowser/mac/WK2BrowserWindowController.m:
3682         (-[WK2BrowserWindowController didChangeSettings]):
3683
3684 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3685
3686         Discard cached processes when clearing website data store
3687         https://bugs.webkit.org/show_bug.cgi?id=194894
3688
3689         Reviewed by Chris Dumez.
3690
3691         Added a test case.
3692
3693         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3694         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3695
3696 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3697
3698         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3699         https://bugs.webkit.org/show_bug.cgi?id=194914
3700         <rdar://problem/47586889>
3701
3702         Reviewed by Geoffrey Garen.
3703
3704         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3705         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3706         (TEST):
3707         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3708
3709 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3710
3711         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3712         <https://webkit.org/b/194761>
3713
3714         Reviewed by Myles Maxfield.
3715
3716         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3717         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3718         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3719         to use ARC-compliant cast.
3720         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3721         ARC-compliant cast.
3722         (WTR::installFakeHelvetica): Log `error` to console if
3723         CTFontManagerRegisterFontsForURL() fails, but only on supported
3724         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3725         Call CFRelease() on `error` to fix the leak.  Update to use
3726         ARC-compliant cast.
3727         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3728         cast.
3729
3730 2019-02-21  Chris Dumez  <cdumez@apple.com>
3731
3732         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3733         https://bugs.webkit.org/show_bug.cgi?id=194481
3734
3735         Reviewed by Alex Christensen.
3736
3737         Give the processes a chance to shutdown and wait until we reached the expected number
3738         of processes.
3739
3740         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3741
3742 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3743
3744         Fix the macOS build
3745
3746         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3747
3748 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3749
3750         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3751
3752         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3753         I am a backwards.
3754
3755 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3756
3757         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3758
3759         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3760         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3761         We could force on UI-side compositing, but I feel like the test might be more
3762         valuable exercising the normal path on each platform (though the original
3763         bug was also UI-side specific). Though we can't validate that the overlay
3764         layer was installed successfully, there are layout tests that do that.
3765
3766 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3767
3768         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3769         https://bugs.webkit.org/show_bug.cgi?id=194845
3770         <rdar://problem/47944579>
3771
3772         Reviewed by Antti Koivisto.
3773
3774         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3775         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3776
3777 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3778
3779         [LFC][Floats] Add support for placing formatting roots in-between floats.
3780         https://bugs.webkit.org/show_bug.cgi?id=194902
3781
3782         Reviewed by Antti Koivisto.
3783
3784         * LayoutReloaded/misc/LFC-passing-tests.txt:
3785
3786 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3787
3788         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3789         https://bugs.webkit.org/show_bug.cgi?id=194901
3790
3791         Unreviewed build fix.
3792
3793         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3794         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3795         WPEBackend-fdo-0.1 as library name.
3796
3797 2019-02-21  Rob Buis  <rbuis@igalia.com>
3798
3799         Update MIME type parser
3800         https://bugs.webkit.org/show_bug.cgi?id=180526
3801
3802         Reviewed by Darin Adler.
3803
3804         Add tests involving leading and trailing whitespace, non-token
3805         characters and quoted strings.
3806
3807         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3808         (TestWebKitAPI::TEST):
3809
3810 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3811
3812         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3813         https://bugs.webkit.org/show_bug.cgi?id=194884
3814
3815         Reviewed by Michael Catanzaro.
3816
3817         * PlatformWin.cmake:
3818
3819 2019-02-20  Chris Dumez  <cdumez@apple.com>
3820
3821         Add API test for <rdar://problem/47471222>
3822         https://bugs.webkit.org/show_bug.cgi?id=194847
3823
3824         Reviewed by Alex Christensen.
3825
3826         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3827
3828 2019-02-20  Chris Dumez  <cdumez@apple.com>
3829
3830         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3831         https://bugs.webkit.org/show_bug.cgi?id=194872
3832         <rdar://problem/47924500>
3833
3834         Reviewed by Alex Christensen.
3835
3836         Add API test coverage.
3837
3838         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3839
3840 2019-02-20  Jer Noble  <jer.noble@apple.com>
3841
3842         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3843         https://bugs.webkit.org/show_bug.cgi?id=191332
3844
3845         Reviewed by Dean Jackson.
3846
3847         * Scripts/git-is-in-range: Added.
3848
3849 2019-02-20  Andy Estes  <aestes@apple.com>
3850
3851         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3852         https://bugs.webkit.org/show_bug.cgi?id=194869
3853
3854         Rubber-stamped by Jer Noble.
3855
3856         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3857         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3858         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3859         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3860         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3861         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3862
3863 2019-02-20  Chris Dumez  <cdumez@apple.com>
3864
3865         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3866         https://bugs.webkit.org/show_bug.cgi?id=194857
3867         <rdar://problem/47759323>
3868
3869         Reviewed by Alex Christensen.
3870
3871         Add API test coverage.
3872
3873         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3874
3875 2019-02-20  Chris Dumez  <cdumez@apple.com>
3876
3877         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3878         https://bugs.webkit.org/show_bug.cgi?id=194829
3879         <rdar://problem/47889906>
3880
3881         Reviewed by Alexey Proskuryakov.
3882
3883         Every time the TestOptions were changing we were creating both a new Web view and
3884         a new WKContext, which would start a new Network process. In most cases, we only
3885         need to contruct a new Web view and we do can keep reusing the same WKContext.
3886         This patch implements this optimization and thus avoids spinning a lot of new
3887         Network processes while running the layout tests.
3888
3889         * WebKitTestRunner/TestController.cpp:
3890         (WTR::TestController::generateContextConfiguration const):
3891         (WTR::TestController::generatePageConfiguration):
3892         (WTR::TestController::createWebViewWithOptions):
3893         (WTR::TestController::resetPreferencesToConsistentValues):
3894         (WTR::updateTestOptionsFromTestHeader):
3895         * WebKitTestRunner/TestController.h:
3896         * WebKitTestRunner/TestOptions.h:
3897         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3898         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3899         (WTR::TestOptions::hasSameInitializationOptions const):
3900         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3901         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3902         (WTR::TestController::platformAddTestOptions const):
3903
3904 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3905
3906         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3907         https://bugs.webkit.org/show_bug.cgi?id=167941
3908
3909         Reviewed by Carlos Garcia Campos.
3910
3911         * MiniBrowser/gtk/main.c:
3912         (filterSavedCallback): Added.
3913         (main): Support loading a JSON rule set file for content filtering.
3914         * MiniBrowser/wpe/main.cpp:
3915         (filterSavedCallback): Added.
3916         (main): Support loading a JSON rule set file for content filtering.
3917         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3918         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3919         (WTF::derefGPtr): Ditto.
3920         (testEmptyStore):
3921         (testSaveInvalidFilter):
3922         (testSaveLoadFilter):
3923         (testSavedFilterIdentifierMatch):
3924         (testRemoveFilter):
3925         (testSaveMultipleFilters):
3926         (testSaveFilterFromFile):
3927         (testFilterPersistence):
3928         (beforeAll):
3929         (afterAll):
3930         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3931         (removeOldInjectedContentAndResetLists): Also reset content filters.
3932         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3933         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3934         the element affected by the style sheet.
3935         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3936         and returns it to be used by tests.
3937         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3938         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3939         (serverCallback): Add support for serving a CSS style sheet for testing.
3940         (beforeAll): Add call to testUserContentManagerContentFilter().
3941         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3942
3943 2019-02-19  Keith Rollin  <krollin@apple.com>
3944
3945         Add timing information to build output
3946         https://bugs.webkit.org/show_bug.cgi?id=194839
3947         <rdar://problem/48219609>
3948
3949         Reviewed by Alexey Proskuryakov.
3950
3951         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3952         emit each project's build time to its output. E.g.,
3953
3954             ** BUILD SUCCEEDED ** [0.132 sec]
3955
3956         * Scripts/webkitdirs.pm:
3957         (XcodeOptions):
3958
3959 2019-02-19  Truitt Savell  <tsavell@apple.com>
3960
3961         Unreviewed, rolling out r241784.
3962
3963         Broke all OpenSource builds.
3964
3965         Reverted changeset:
3966
3967         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3968         instances view"
3969         https://bugs.webkit.org/show_bug.cgi?id=172848
3970         https://trac.webkit.org/changeset/241784
3971
3972 2019-02-19  Zalan Bujtas  <zalan@apple.com>
3973
3974         [LFC][Floats] Remove redundant intersecting logic
3975         https://bugs.webkit.org/show_bug.cgi?id=194804
3976
3977         Reviewed by Antti Koivisto.
3978
3979         * LayoutReloaded/misc/LFC-passing-tests.txt:
3980
3981 2019-02-19  Dean Jackson  <dino@apple.com>
3982
3983         Clean-up output from generate-xcfilelists so it can be filtered
3984         https://bugs.webkit.org/show_bug.cgi?id=194795
3985
3986         Reviewed by Joseph Pecoraro (and Keith Rollin).
3987
3988         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
3989         make a slight tweak to filter-build-webkit so such lines are marked
3990         as plain.
3991
3992         * Scripts/filter-build-webkit:
3993         * Scripts/generate-xcfilelists:
3994
3995 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3996
3997         pytest is not correctly auto-installed
3998         https://bugs.webkit.org/show_bug.cgi?id=194707
3999
4000         Reviewed by Carlos Garcia Campos.
4001
4002         * Scripts/webkitpy/thirdparty/__init__.py:
4003         (AutoinstallImportHook._install_pytest):
4004
4005 2019-02-18  Chris Dumez  <cdumez@apple.com>
4006
4007         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4008         https://bugs.webkit.org/show_bug.cgi?id=194797
4009         <rdar://problem/48055151>
4010
4011         Reviewed by Geoffrey Garen.
4012
4013         Add API test coverage.
4014
4015         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4016
4017 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4018
4019         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4020         https://bugs.webkit.org/show_bug.cgi?id=194670
4021         <rdar://problem/39066529>
4022
4023         Reviewed by Tim Horton.
4024
4025         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4026         pasted in an editable area as attachment elements.
4027
4028         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4029         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4030         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4031         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4032         (TestWebKitAPI::TEST):
4033         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4034         (WTR::InjectedBundlePage::InjectedBundlePage):
4035
4036 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4037
4038         Fix API test after r241728
4039        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4040
4041         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4042         (TEST):
4043         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4044
4045 2019-02-18  Daniel Bates  <dabates@apple.com>
4046
4047         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4048         https://bugs.webkit.org/show_bug.cgi?id=192824
4049         <rdar://problem/47100332>
4050
4051         Reviewed by Wenson Hsieh.
4052
4053         Fix a bug where the wrong usage code was used for F13 thru F24.
4054
4055         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4056         (keyCodeForDOMFunctionKey):
4057
4058 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4059
4060         Bytecode cache should a have a boot-specific validation
4061         https://bugs.webkit.org/show_bug.cgi?id=194769
4062         <rdar://problem/48149509>
4063
4064         Reviewed by Keith Miller.
4065
4066         Add test for WTF::bootSessionUUIDString()
4067
4068         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4069         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4070         (TEST):
4071
4072 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4073
4074         Disable safe browsing in WKWebView and remove its WKPreferences API
4075         https://bugs.webkit.org/show_bug.cgi?id=194723
4076         <rdar://problem/48122993>
4077
4078         Reviewed by Geoffrey Garen.
4079
4080         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4081         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4082         (TEST):
4083         (safeBrowsingView):
4084         Make tests use SPI instead of API.
4085
4086 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4087
4088         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4089         https://bugs.webkit.org/show_bug.cgi?id=194586
4090
4091         Reviewed by Ross Kirsling.
4092
4093         * DumpRenderTree/win/DumpRenderTree.cpp:
4094         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4095         * Scripts/webkitpy/port/driver.py:
4096         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4097
4098 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4099
4100         Unreviewed, rolling out r241620.
4101
4102         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
4103         (Requested by ddkilzer on #webkit.)
4104
4105         Reverted changeset:
4106
4107         "[WTF] Add environment variable helpers"
4108         https://bugs.webkit.org/show_bug.cgi?id=192405
4109         https://trac.webkit.org/changeset/241620
4110
4111 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4112
4113         [LFC] RenderImage's default intrinsic size is 0.
4114         https://bugs.webkit.org/show_bug.cgi?id=194745
4115
4116         Reviewed by Antti Koivisto.
4117
4118         * LayoutReloaded/misc/LFC-passing-tests.txt:
4119
4120 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4121
4122         [LFC][BFC] Add support for block replaced intrinsic width.
4123         https://bugs.webkit.org/show_bug.cgi?id=194705
4124
4125         Reviewed by Simon Fraser.
4126
4127         * LayoutReloaded/misc/LFC-passing-tests.txt:
4128
4129 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4130
4131         [LFC] Apply min/max width constraints to preferred width computation
4132         https://bugs.webkit.org/show_bug.cgi?id=194739
4133
4134         Reviewed by Simon Fraser.
4135
4136         * LayoutReloaded/misc/LFC-passing-tests.txt:
4137
4138 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
4139
4140         [WTF] Add environment variable helpers
4141         https://bugs.webkit.org/show_bug.cgi?id=192405
4142
4143         Reviewed by Michael Catanzaro.
4144
4145         * DumpRenderTree/mac/DumpRenderTree.mm:
4146         (libraryPathForDumpRenderTree):
4147         * DumpRenderTree/win/DumpRenderTree.cpp:
4148         (libraryPathForDumpRenderTree):
4149         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4150         (setUpIOSLayoutTestCommunication):
4151         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4152         (beforeAll):
4153         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4154         (main):
4155         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4156         (WebKitTestBus::run):
4157         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4158         (WTR::getOutputDir):
4159         (WTR::initializeFontConfigSetting):
4160         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4161         (WTR::InjectedBundle::platformInitialize):
4162         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4163         (WTR::topLevelPath):
4164         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4165         (WTR::topLevelPath):
4166         (WTR::getOutputDir):
4167         (WTR::activateFonts):
4168         * WebKitTestRunner/TestController.cpp:
4169         (WTR::TestController::libraryPathForTesting):
4170         (WTR::TestController::generateContextConfiguration const):
4171         (WTR::TestController::generatePageConfiguration):
4172         (WTR::TestController::decideDestinationWithSuggestedFilename):
4173         (WTR::TestController::platformAdjustContext):
4174         * WebKitTestRunner/TestController.h:
4175         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4176         (WTR::TestController::cocoaPlatformInitialize):
4177         (WTR::TestController::platformAdjustContext):
4178         * WebKitTestRunner/gtk/main.cpp:
4179         (main):
4180         * WebKitTestRunner/mac/TestControllerMac.mm:
4181         (WTR::TestController::configureContentExtensionForTest):
4182         * WebKitTestRunner/wpe/main.cpp:
4183         (main):
4184         Utilize WTF::Environment where possible.
4185
4186 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4187
4188         [iOS] WKWebView callout bar is missing Change Writing Direction item
4189         https://bugs.webkit.org/show_bug.cgi?id=190015
4190         <rdar://problem/44810366>
4191
4192         Reviewed by Tim Horton.
4193
4194         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
4195         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
4196
4197         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
4198         (TestWebKitAPI::TEST):
4199
4200 2019-02-15  Chris Dumez  <cdumez@apple.com>
4201
4202         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
4203         https://bugs.webkit.org/show_bug.cgi?id=194717
4204         <rdar://problem/47884404>
4205
4206         Reviewed by Brady Eidson.
4207
4208         Add API test coverage.
4209
4210         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4211
4212 2019-02-15  Youenn Fablet  <youenn@apple.com>
4213
4214         Make navigator.mediaDevices SecureContext
4215         https://bugs.webkit.org/show_bug.cgi?id=194666
4216
4217         Reviewed by Eric Carlson.
4218
4219         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4220         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4221         (TEST_F):
4222
4223 2019-02-15  Brian Burg  <bburg@apple.com>
4224
4225         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4226         https://bugs.webkit.org/show_bug.cgi?id=194411
4227         <rdar://problem/47787614>
4228
4229         Reviewed by Joseph Pecoraro.
4230
4231         Remove unnecessary soft linking macro usage.
4232
4233         * DumpRenderTree/mac/TestRunnerMac.mm:
4234         (TestRunner::inspectorTestStubURL):
4235         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4236         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4237         (WTR::TestRunner::inspectorTestStubURL):
4238
4239 2019-02-15  Commit Queue  <commit-queue@webkit.org>
4240
4241         Unreviewed, rolling out r241559 and r241566.
4242         https://bugs.webkit.org/show_bug.cgi?id=194710
4243
4244         Causes layout test crashes under GuardMalloc (Requested by
4245         ryanhaddad on #webkit).
4246
4247         Reverted changesets:
4248
4249         "[WTF] Add environment variable helpers"
4250         https://bugs.webkit.org/show_bug.cgi?id=192405
4251         https://trac.webkit.org/changeset/241559
4252
4253         "Unreviewed build fix for WinCairo Debug after r241559."
4254         https://trac.webkit.org/changeset/241566
4255
4256 2019-02-15  Zalan Bujtas  <zalan@apple.com>
4257
4258         [LFC] Out-of-flow box is never a float box
4259         https://bugs.webkit.org/show_bug.cgi?id=194704
4260
4261         Reviewed by Antti Koivisto.
4262
4263         * LayoutReloaded/misc/LFC-passing-tests.txt:
4264
4265 2019-02-10  Darin Adler  <darin@apple.com>
4266
4267         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
4268         https://bugs.webkit.org/show_bug.cgi?id=194487
4269
4270         Reviewed by Daniel Bates.
4271
4272         * DumpRenderTree/win/DumpRenderTree.cpp:
4273         (applicationId): Use makeString instead of String::format.
4274         (main): Ditto.
4275         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4276         (TestWebKitAPI::Util::createURLForResource): Ditto.
4277         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
4278         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
4279
4280         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4281         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
4282         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
4283         (WTR::createStringWithAttributes): Use appendLiteral.
4284         (WTR::AccessibilityUIElement::helpText const): Ditto.
4285         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
4286         directly instead of using String::format.
4287         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
4288         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
4289
4290 2019-02-15  Truitt Savell  <tsavell@apple.com>
4291
4292         Unreviewed, rolling out r241564.
4293
4294         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
4295
4296         Reverted changeset:
4297
4298         "[Mac] WebInspectorUI.framework does not need to be soft-
4299         linked anymore"
4300         https://bugs.webkit.org/show_bug.cgi?id=194411
4301         https://trac.webkit.org/changeset/241564
4302
4303 2019-02-15  Saam barati  <sbarati@apple.com>
4304
4305         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
4306         https://bugs.webkit.org/show_bug.cgi?id=194036
4307
4308         Reviewed by Yusuke Suzuki.
4309
4310         * Scripts/run-jsc-stress-tests:
4311
4312 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4313
4314         Fix the build.
4315
4316         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4317         (WTR::UIScriptController::drawSquareInEditableImage):
4318         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4319         (TestWebKitAPI::drawSquareInEditableImage):
4320
4321 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4322
4323         Fix the build.
4324
4325         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4326         (WTR::UIScriptController::drawSquareInEditableImage):
4327         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4328         (TestWebKitAPI::drawSquareInEditableImage):
4329
4330 2019-02-14  Brian Burg  <bburg@apple.com>
4331
4332         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4333         https://bugs.webkit.org/show_bug.cgi?id=194411
4334         <rdar://problem/47787614>
4335
4336         Reviewed by Joseph Pecoraro.
4337
4338         Remove unnecessary soft linking macro usage.
4339
4340         * DumpRenderTree/mac/TestRunnerMac.mm:
4341         (TestRunner::inspectorTestStubURL):
4342         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4343         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4344         (WTR::TestRunner::inspectorTestStubURL):
4345
4346 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
4347
4348         [ews-app] status bubble should fetch builder name info from BuilderMapping table
4349         https://bugs.webkit.org/show_bug.cgi?id=194599
4350
4351         Reviewed by Lucas Forschler.
4352
4353         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4354         (StatusBubble._build_bubble):
4355
4356 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
4357
4358         [ews-app] Set Foreign Key in Django build model
4359         https://bugs.webkit.org/show_bug.cgi?id=194667
4360
4361         Reviewed by Lucas Forschler.