WKRetainPtr's adoption constructor should be private
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2
3         WKRetainPtr's adoption constructor should be private
4         https://bugs.webkit.org/show_bug.cgi?id=197019
5
6         Reviewed by Tim Horton.
7
8         * DumpRenderTree/mac/DumpRenderTree.mm:
9         (dumpFramesAsText):
10         * TestWebKitAPI/InjectedBundleController.cpp:
11         (TestWebKitAPI::InjectedBundleController::initialize):
12         * TestWebKitAPI/PlatformUtilities.cpp:
13         (TestWebKitAPI::Util::createContextWithInjectedBundle):
14         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
15         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
16         (TestWebKitAPI::Util::toWK):
17         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
18         (TestWebKitAPI::TEST):
19         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
20         (TestWebKitAPI::TEST):
21         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
22         (TestWebKitAPI::TEST):
23         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
24         (TestWebKitAPI::TEST):
25         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
26         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
27         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
28         (TestWebKitAPI::TEST):
29         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
30         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
31         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
32         (TestWebKitAPI::TEST):
33         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
34         (TestWebKitAPI::TEST):
35         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
36         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
37         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
38         (TestWebKitAPI::TEST):
39         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
40         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
41         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
42         (TestWebKitAPI::TEST):
43         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
44         (TestWebKitAPI::TEST):
45         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
46         (TestWebKitAPI::TEST):
47         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
48         (TestWebKitAPI::TEST):
49         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
50         (TestWebKitAPI::TEST):
51         * TestWebKitAPI/Tests/WebKit/Find.cpp:
52         (TestWebKitAPI::TEST):
53         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
54         (TestWebKitAPI::TEST):
55         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
56         (TestWebKitAPI::TEST):
57         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
58         (TestWebKitAPI::TEST):
59         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
60         (TestWebKitAPI::TEST):
61         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
62         (TestWebKitAPI::TEST):
63         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
64         (TestWebKitAPI::TEST):
65         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
66         (TestWebKitAPI::TEST):
67         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
68         (TestWebKitAPI::TEST):
69         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
70         (TestWebKitAPI::TEST):
71         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
72         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
73         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
74         (TestWebKitAPI::TEST):
75         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
76         (TestWebKitAPI::TEST):
77         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
78         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
79         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
80         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
81         (TestWebKitAPI::TEST):
82         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
83         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
84         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
85         (TestWebKitAPI::TEST):
86         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
87         (TestWebKitAPI::TEST):
88         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
89         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
90         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
91         (TestWebKitAPI::TEST):
92         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
93         (TestWebKitAPI::loadAlternateHTMLString):
94         (TestWebKitAPI::TEST):
95         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
96         (TestWebKitAPI::TEST):
97         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
98         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
99         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
100         (TestWebKitAPI::buildAndPerformTest):
101         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
102         (TestWebKitAPI::TEST):
103         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
104         (TestWebKitAPI::TEST):
105         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
106         (TestWebKitAPI::TEST):
107         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
108         (TestWebKitAPI::TEST):
109         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
110         (TestWebKitAPI::TEST):
111         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
112         (TestWebKitAPI::TEST):
113         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
114         (TestWebKitAPI::TEST):
115         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
116         (TestWebKitAPI::TEST):
117         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
118         (TestWebKitAPI::TEST):
119         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
120         (TestWebKitAPI::TEST):
121         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
122         (TestWebKitAPI::TEST):
123         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
124         (TestWebKitAPI::TEST):
125         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
126         (TestWebKitAPI::TEST):
127         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
128         (TestWebKitAPI::TEST):
129         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
130         (TestWebKitAPI::TEST):
131         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
132         (TestWebKitAPI::TEST):
133         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
134         (TestWebKitAPI::TEST):
135         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
136         (TestWebKitAPI::TEST):
137         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
138         (TestWebKitAPI::TEST):
139         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
140         (TestWebKitAPI::TEST):
141         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
142         (TestWebKitAPI::TEST):
143         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
144         (TestWebKitAPI::TEST):
145         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
146         (TestWebKitAPI::TEST):
147         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
148         (TestWebKitAPI::TEST):
149         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
150         (TestWebKitAPI::TEST):
151         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
152         (TestWebKitAPI::TEST):
153         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
154         (TestWebKitAPI::TEST):
155         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
156         (TestWebKitAPI::TEST):
157         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
158         (TestWebKitAPI::TEST):
159         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
160         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
161         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
162         (TestWebKitAPI::TEST):
163         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
164         (TestWebKitAPI::TEST):
165         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
166         (TestWebKitAPI::TEST):
167         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
168         (TestWebKitAPI::TEST):
169         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
170         (TestWebKitAPI::TEST):
171         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
172         (TestWebKitAPI::TEST):
173         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
174         (TestWebKitAPI::TEST):
175         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
176         (TestWebKitAPI::TEST):
177         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
178         (TestWebKitAPI::TEST):
179         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
180         (TestWebKitAPI::TEST):
181         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
182         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
183         (TEST):
184         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
185         (TEST):
186         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
187         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
188         (TEST):
189         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
190         (TestWebKitAPI::TEST):
191         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
192         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
193         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
194         (WTR::getMenuItemTitleCallback):
195         (WTR::createMouseMessageBody):
196         (WTR::EventSendingController::mouseDown):
197         (WTR::EventSendingController::mouseUp):
198         (WTR::EventSendingController::mouseMoveTo):
199         (WTR::EventSendingController::mouseForceClick):
200         (WTR::EventSendingController::startAndCancelMouseForceClick):
201         (WTR::EventSendingController::mouseForceDown):
202         (WTR::EventSendingController::mouseForceUp):
203         (WTR::EventSendingController::mouseForceChanged):
204         (WTR::EventSendingController::leapForward):
205         (WTR::EventSendingController::scheduleAsynchronousClick):
206         (WTR::createKeyDownMessageBody):
207         (WTR::EventSendingController::keyDown):
208         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
209         (WTR::EventSendingController::mouseScrollBy):
210         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
211         (WTR::EventSendingController::continuousMouseScrollBy):
212         (WTR::EventSendingController::addTouchPoint):
213         (WTR::EventSendingController::updateTouchPoint):
214         (WTR::EventSendingController::setTouchModifier):
215         (WTR::EventSendingController::setTouchPointRadius):
216         (WTR::EventSendingController::touchStart):
217         (WTR::EventSendingController::touchMove):
218         (WTR::EventSendingController::touchEnd):
219         (WTR::EventSendingController::touchCancel):
220         (WTR::EventSendingController::clearTouchPoints):
221         (WTR::EventSendingController::releaseTouchPoint):
222         (WTR::EventSendingController::cancelTouchPoint):
223         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
224         (WTR::InjectedBundle::didCreatePage):
225         (WTR::InjectedBundle::didReceiveMessage):
226         (WTR::InjectedBundle::didReceiveMessageToPage):
227         (WTR::InjectedBundle::booleanForKey):
228         (WTR::InjectedBundle::done):
229         (WTR::InjectedBundle::dumpToStdErr):
230         (WTR::InjectedBundle::outputText):
231         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
232         (WTR::InjectedBundle::postAddChromeInputField):
233         (WTR::InjectedBundle::postRemoveChromeInputField):
234         (WTR::InjectedBundle::postFocusWebView):
235         (WTR::InjectedBundle::postSetBackingScaleFactor):
236         (WTR::InjectedBundle::postSetWindowIsKey):
237         (WTR::InjectedBundle::postSetViewSize):
238         (WTR::InjectedBundle::postSimulateWebNotificationClick):
239         (WTR::InjectedBundle::postSetAddsVisitedLinks):
240         (WTR::InjectedBundle::setGeolocationPermission):
241         (WTR::InjectedBundle::setMockGeolocationPosition):
242         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
243         (WTR::InjectedBundle::isGeolocationProviderActive const):
244         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
245         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
246         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
247         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
248         (WTR::InjectedBundle::setCustomPolicyDelegate):
249         (WTR::InjectedBundle::setHidden):
250         (WTR::InjectedBundle::setCacheModel):
251         (WTR::InjectedBundle::shouldProcessWorkQueue const):
252         (WTR::InjectedBundle::processWorkQueue):
253         (WTR::InjectedBundle::queueBackNavigation):
254         (WTR::InjectedBundle::queueForwardNavigation):
255         (WTR::InjectedBundle::queueLoad):
256         (WTR::InjectedBundle::queueLoadHTMLString):
257         (WTR::InjectedBundle::queueReload):
258         (WTR::InjectedBundle::queueLoadingScript):
259         (WTR::InjectedBundle::queueNonLoadingScript):
260         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
261         (WTR::frameToStr):
262         (WTR::InjectedBundlePage::InjectedBundlePage):
263         (WTR::dumpFrameDescriptionSuitableForTestResult):
264         (WTR::dumpFrameScrollPosition):
265         (WTR::dumpDescendantFrameScrollPositions):
266         (WTR::dumpFrameText):
267         (WTR::dumpDescendantFramesText):
268         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
269         (WTR::TestRunner::shouldDumpPixels const):
270         (WTR::TestRunner::setDumpPixels):
271         (WTR::TestRunner::whatToDump const):
272         (WTR::TestRunner::setWhatToDump):
273         (WTR::TestRunner::setWaitUntilDone):
274         (WTR::TestRunner::shouldWaitUntilDone const):
275         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
276         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
277         (WTR::TestRunner::clearAllDatabases):
278         (WTR::TestRunner::setIDBPerOriginQuota):
279         (WTR::TestRunner::originsWithApplicationCache):
280         (WTR::TestRunner::setCanOpenWindows):
281         (WTR::TestRunner::setXSSAuditorEnabled):
282         (WTR::TestRunner::setMediaDevicesEnabled):
283         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
284         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
285         (WTR::TestRunner::setCustomUserAgent):
286         (WTR::TestRunner::setWebAPIStatisticsEnabled):
287         (WTR::TestRunner::setModernMediaControlsEnabled):
288         (WTR::TestRunner::setWebGL2Enabled):
289         (WTR::TestRunner::setWritableStreamAPIEnabled):
290         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
291         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
292         (WTR::TestRunner::setAllowsAnySSLCertificate):
293         (WTR::TestRunner::setPluginsEnabled):
294         (WTR::TestRunner::setValueForUser):
295         (WTR::TestRunner::setAudioResult):
296         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
297         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
298         (WTR::TestRunner::setAlwaysAcceptCookies):
299         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
300         (WTR::TestRunner::isDoingMediaCapture const):
301         (WTR::TestRunner::queueLoad):
302         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
303         (WTR::TestRunner::setHandlesAuthenticationChallenges):
304         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
305         (WTR::TestRunner::setShouldLogDownloadCallbacks):
306         (WTR::TestRunner::setAuthenticationUsername):
307         (WTR::TestRunner::setAuthenticationPassword):
308         (WTR::TestRunner::secureEventInputIsEnabled const):
309         (WTR::TestRunner::setBlockAllPlugins):
310         (WTR::TestRunner::setPluginSupportedMode):
311         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
312         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
313         (WTR::TestRunner::setNavigationGesturesEnabled):
314         (WTR::TestRunner::setIgnoresViewportScaleLimits):
315         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
316         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
317         (WTR::TestRunner::terminateNetworkProcess):
318         (WTR::TestRunner::terminateServiceWorkerProcess):
319         (WTR::TestRunner::runUIScript):
320         (WTR::TestRunner::setStatisticsDebugMode):
321         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
322         (WTR::TestRunner::setStatisticsLastSeen):
323         (WTR::TestRunner::setStatisticsPrevalentResource):
324         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
325         (WTR::TestRunner::dumpResourceLoadStatistics):
326         (WTR::TestRunner::isStatisticsPrevalentResource):
327         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
328         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
329         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
330         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
331         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
332         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
333         (WTR::TestRunner::setStatisticsGrandfathered):
334         (WTR::TestRunner::isStatisticsGrandfathered):
335         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
336         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
337         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
338         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
339         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
340         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
341         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
342         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
343         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
344         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
345         (WTR::TestRunner::statisticsUpdateCookieBlocking):
346         (WTR::TestRunner::statisticsSubmitTelemetry):
347         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
348         (WTR::TestRunner::setStatisticsIsRunningTest):
349         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
350         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
351         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
352         (WTR::TestRunner::setStatisticsGrandfatheringTime):
353         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
354         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
355         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
356         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
357         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
358         (WTR::TestRunner::statisticsDeleteCookiesForHost):
359         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
360         (WTR::TestRunner::statisticsResetToConsistentState):
361         (WTR::TestRunner::setStorageAccessAPIEnabled):
362         (WTR::TestRunner::getAllStorageAccessEntries):
363         (WTR::TestRunner::addMockMediaDevice):
364         (WTR::TestRunner::clearMockMediaDevices):
365         (WTR::TestRunner::removeMockMediaDevice):
366         (WTR::TestRunner::resetMockMediaDevices):
367         (WTR::TestRunner::connectMockGamepad):
368         (WTR::TestRunner::disconnectMockGamepad):
369         (WTR::TestRunner::setMockGamepadDetails):
370         (WTR::TestRunner::setMockGamepadAxisValue):
371         (WTR::TestRunner::setMockGamepadButtonValue):
372         (WTR::TestRunner::removeAllSessionCredentials):
373         (WTR::TestRunner::clearDOMCache):
374         (WTR::TestRunner::clearDOMCaches):
375         (WTR::TestRunner::hasDOMCache):
376         (WTR::TestRunner::domCacheSize):
377         (WTR::TestRunner::setAllowStorageQuotaIncrease):
378         (WTR::TestRunner::getApplicationManifestThen):
379         (WTR::TestRunner::injectUserScript):
380         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
381         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
382         (WTR::TestRunner::addTestKeyToKeychain):
383         (WTR::TestRunner::cleanUpKeychain):
384         (WTR::TestRunner::keyExistsInKeychain):
385         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
386         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
387         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
388         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
389         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
390         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
391         * WebKitTestRunner/TestController.cpp:
392         (WTR::TestController::initialize):
393         (WTR::parseStringTestHeaderValueAsRelativePath):
394         (WTR::updateTestOptionsFromTestHeader):
395         (WTR::TestController::runTest):
396         (WTR::TestController::didReceiveLiveDocumentsList):
397         (WTR::TestController::didReceiveMessageFromInjectedBundle):
398         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
399         (WTR::TestController::didFinishNavigation):
400         (WTR::TestController::didReceiveAuthenticationChallenge):
401         * WebKitTestRunner/TestInvocation.cpp:
402         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
403         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
404         (WTR::TestInvocation::uiScriptDidComplete):
405         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
406         * WebKitTestRunner/WebNotificationProvider.cpp:
407         (WTR::WebNotificationProvider::closeWebNotification):
408         * WebKitTestRunner/WorkQueueManager.cpp:
409         (WTR::ScriptItem::ScriptItem):
410         (WTR::WorkQueueManager::queueLoad):
411         (WTR::WorkQueueManager::queueLoadHTMLString):
412
413 2019-04-17  Alex Christensen  <achristensen@webkit.org>
414
415         Add a comment to make my test from r244139 less mysterious.
416         https://bugs.webkit.org/show_bug.cgi?id=196744
417
418         As suggested by Darin Adler.
419
420         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
421         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
422
423 2019-04-17  Chris Dumez  <cdumez@apple.com>
424
425         Remember device orientation permission for the duration of the browsing session
426         https://bugs.webkit.org/show_bug.cgi?id=196992
427         <rdar://problem/49946067>
428
429         Reviewed by Alex Christensen.
430
431         Add API test coverage.
432
433         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
434         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
435         (TEST):
436
437 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
438
439         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
440         https://bugs.webkit.org/show_bug.cgi?id=196675
441
442         Reviewed by Lucas Forschler.
443
444         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
445         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
446
447 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
448
449         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
450         https://bugs.webkit.org/show_bug.cgi?id=196919
451         <rdar://problem/41630459>
452
453         Reviewed by Tim Horton.
454
455         Add iOS support for several new testing hooks. See below for more detail.
456
457         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
458         (WTR::UIScriptController::isDismissingMenu const):
459
460         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
461         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
462         by UIKit when dismissing the callout bar (i.e. UIMenuController).
463
464         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
465         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
466         (WTR::UIScriptController::isDismissingMenu const):
467         * TestRunnerShared/UIScriptContext/UIScriptController.h:
468         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
469         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
470         (WTR::InjectedBundle::didReceiveMessageToPage):
471         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
472         (WTR::TestRunner::setAllowedMenuActions):
473
474         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
475         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
476         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
477         against the name of the custom action.
478
479         (WTR::TestRunner::installCustomMenuAction):
480
481         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
482         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
483         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
484         triggered.
485
486         (WTR::TestRunner::performCustomMenuAction):
487
488         Invoked when the custom menu action is triggered.
489
490         * WebKitTestRunner/InjectedBundle/TestRunner.h:
491         * WebKitTestRunner/TestController.cpp:
492         (WTR::TestController::installCustomMenuAction):
493         (WTR::TestController::setAllowedMenuActions):
494         * WebKitTestRunner/TestController.h:
495         * WebKitTestRunner/TestInvocation.cpp:
496         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
497         (WTR::TestInvocation::performCustomMenuAction):
498
499         Add plumbing to call back into the injected bundle when performing the custom action.
500
501         * WebKitTestRunner/TestInvocation.h:
502         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
503         (WTR::TestController::installCustomMenuAction):
504         (WTR::TestController::setAllowedMenuActions):
505         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
506         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
507         (-[TestRunnerWKWebView initWithFrame:configuration:]):
508         (-[TestRunnerWKWebView becomeFirstResponder]):
509         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
510
511         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
512         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
513         in the Mail app on iOS.
514
515         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
516         (-[TestRunnerWKWebView setAllowedMenuActions:]):
517         (-[TestRunnerWKWebView resetCustomMenuAction]):
518         (-[TestRunnerWKWebView performCustomAction:]):
519         (-[TestRunnerWKWebView canPerformAction:withSender:]):
520         (-[TestRunnerWKWebView _willHideMenu]):
521         (-[TestRunnerWKWebView _didHideMenu]):
522         * WebKitTestRunner/ios/TestControllerIOS.mm:
523         (WTR::TestController::platformResetStateToConsistentValues):
524
525         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
526         if specified.
527
528         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
529         (WTR::UIScriptController::isDismissingMenu const):
530
531 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
532
533         Allow sharing from imageSheet on an image document
534         https://bugs.webkit.org/show_bug.cgi?id=196891
535         <rdar://problem/25377386>
536
537         Reviewed by Tim Horton.
538
539         Test to make sure that the correct imageURL is extracted from an image element.
540
541         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
542         (TestWebKitAPI::TEST):
543
544 2019-04-16  Alex Christensen  <achristensen@webkit.org>
545
546         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
547         https://bugs.webkit.org/show_bug.cgi?id=196995
548
549         Reviewed by Brady Eidson.
550
551         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
552         (TEST):
553
554 2019-04-16  Chris Dumez  <cdumez@apple.com>
555
556         URL set by document.open() is not communicated to the UIProcess
557         https://bugs.webkit.org/show_bug.cgi?id=196941
558         <rdar://problem/49237544>
559
560         Reviewed by Geoff Garen.
561
562         Add API test coverage.
563
564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
565         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
566         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
567         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
568         (TEST):
569
570 2019-04-16  Commit Queue  <commit-queue@webkit.org>
571
572         Unreviewed, rolling out r244321.
573         https://bugs.webkit.org/show_bug.cgi?id=196968
574
575         Causing all WK2 Debug builds to exit early after Assertion
576         failures. (Requested by ShawnRoberts on #webkit).
577
578         Reverted changeset:
579
580         "URL set by document.open() is not communicated to the
581         UIProcess"
582         https://bugs.webkit.org/show_bug.cgi?id=196941
583         https://trac.webkit.org/changeset/244321
584
585 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
586
587         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
588         https://bugs.webkit.org/show_bug.cgi?id=196948
589
590         Reviewed by Zalan Bujtas.
591
592         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
593         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
594
595 2019-04-15  Chris Dumez  <cdumez@apple.com>
596
597         URL set by document.open() is not communicated to the UIProcess
598         https://bugs.webkit.org/show_bug.cgi?id=196941
599         <rdar://problem/49237544>
600
601         Reviewed by Geoffrey Garen.
602
603         Add API test coverage.
604
605         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
606         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
607         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
608         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
609         (TEST):
610
611 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
612
613         Using Tools/Scripts/clean-webkit should not install requests
614         https://bugs.webkit.org/show_bug.cgi?id=196940
615
616         Reviewed by Lucas Forschler.
617
618         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
619         existing, depending on the path autoinstalled is run through.
620         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
621         needed.
622         (Port.configuration_for_upload):
623         (Port.commits_for_upload):
624
625 2019-04-15  Alex Christensen  <achristensen@webkit.org>
626
627         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
628         https://bugs.webkit.org/show_bug.cgi?id=196773
629
630         Reviewed by Jer Noble.
631
632         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
633         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
634         (TEST):
635
636 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
637
638         ews-build should clearly indicate flaky test failures
639         https://bugs.webkit.org/show_bug.cgi?id=196947
640
641         Reviewed by Lucas Forschler.
642
643         * BuildSlaveSupport/ews-build/steps.py:
644         (AnalyzeAPITestsResults.analyzeResults):
645
646 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
647
648         InjectedBundle parameters often need initialization function called before unarchiving
649         https://bugs.webkit.org/show_bug.cgi?id=189709
650         <rdar://problem/44573653>
651
652         Reviewed by Ryosuke Niwa.
653
654         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
655         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
656
657 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
658
659         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
660         https://bugs.webkit.org/show_bug.cgi?id=196681
661
662         Reviewed by Darin Adler.
663
664         Added tests.
665
666         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
667         (WTF_HashSet.RemoveIf):
668         (WTF_HashSet.RemoveIfShrinkToBestSize):
669
670 2019-04-15  John Wilander  <wilander@apple.com>
671
672         Send delayed Ad Click Attribution conversion requests to the click source
673         https://bugs.webkit.org/show_bug.cgi?id=196838
674         <rdar://problem/47650157>
675
676         Reviewed by Chris Dumez and Youenn Fablet.
677
678         This patch adds test infrastructure to override the default behavior in
679         WebKit::NetworkAdClickAttribution.
680
681         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
682         (TestWebKitAPI::TEST):
683         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
684         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
685         (WTR::TestRunner::dumpAdClickAttribution):
686         (WTR::TestRunner::clearAdClickAttribution):
687         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
688         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
689         * WebKitTestRunner/InjectedBundle/TestRunner.h:
690         * WebKitTestRunner/TestController.cpp:
691         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
692         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
693         * WebKitTestRunner/TestController.h:
694         * WebKitTestRunner/TestInvocation.cpp:
695         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
696
697 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
698
699         [ews-app] status-bubble should display position in queue
700         https://bugs.webkit.org/show_bug.cgi?id=196607
701
702         Reviewed by Lucas Forschler.
703
704         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
705         (StatusBubble._build_bubble):
706         (StatusBubble._queue_position): Method to calculate patch's position in queue.
707
708 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
709
710         [ews-build] Do not run clean build by default on EWS builders
711         https://bugs.webkit.org/show_bug.cgi?id=196897
712
713         Reviewed by Lucas Forschler.
714
715         * BuildSlaveSupport/ews-build/steps.py:
716         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
717         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
718         untracked directories like WebKitBuild).
719         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
720         untracked files/directories (like WebKitBuild).
721
722 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
723
724         TestRunner::notifyDone() should be safely reentrant
725         https://bugs.webkit.org/show_bug.cgi?id=196898
726
727         Reviewed by Darin Adler.
728
729         It is currently possible that TestRunner::notifyDone() will call itself, since
730         notifyDone() will force a repaint, which can start executing JavaScript, which
731         may call notifyDone() again. This can lead to test failures and flakiness.
732         Fix this by setting the m_waitToDump flag before calling the dump() method.
733
734         * DumpRenderTree/mac/TestRunnerMac.mm:
735         (TestRunner::notifyDone):
736         (TestRunner::forceImmediateCompletion):
737         * DumpRenderTree/win/TestRunnerWin.cpp:
738         (TestRunner::notifyDone):
739         (TestRunner::forceImmediateCompletion):
740
741 2019-04-15  Philippe Normand  <pnormand@igalia.com>
742
743         [GTK][WPE] Add enable-media websetting
744         https://bugs.webkit.org/show_bug.cgi?id=196863
745
746         Reviewed by Michael Catanzaro.
747
748         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
749         (testWebKitSettings): Add test for the enable-media web-setting.
750
751 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
752
753         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
754         https://bugs.webkit.org/show_bug.cgi?id=196905
755         <rdar://problem/49886096>
756
757         Reviewed by Tim Horton.
758
759         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
760         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
761         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
762         delay timer, we end up with this sequence of events in the problematic (failure) case:
763
764         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
765             ...IPC from UI to web process...
766         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
767             ...IPC from web to UI process...
768         (c) [UI]    Invoke completion handler for script #1
769         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
770             ...IPC from UI to web process...
771         (e) [Web]   Evaluate script #2 in the web process
772         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
773
774         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
775         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
776         #2 is run in step (e).
777
778         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
779         the UI process by waiting on a script message posted by the web process, after attachment updates are
780         dispatched.
781
782         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
783         (TestWebKitAPI::TEST):
784
785 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
786
787         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
788         https://bugs.webkit.org/show_bug.cgi?id=196909
789
790         Reviewed by Wenson Hsieh.
791
792         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
793         (TestWebKitAPI::TEST):
794
795 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
796
797         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
798         https://bugs.webkit.org/show_bug.cgi?id=196880
799
800         Reviewed by Yusuke Suzuki.
801
802         Add a new function for bytecode cache tests that does not forceDiskCache
803         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
804         test added in this patch, since the code is invalid and therefore won't be
805         cached. It should also be useful for tests that evaluate dynamically
806         generated code.
807
808         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
809         * Scripts/run-jsc-stress-tests:
810
811 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
812
813         Update AudioSession route sharing policy
814         https://bugs.webkit.org/show_bug.cgi?id=196776
815         <rdar://problem/46501611>
816
817         Reviewed by Jer Noble.
818
819         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
820         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
821         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
822         (TestWebKitAPI::TEST):
823
824 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
825
826         [iOS] Software keyboard is shown too frequently on some websites
827         https://bugs.webkit.org/show_bug.cgi?id=195856
828         <rdar://problem/49191395>
829
830         Reviewed by Darin Adler.
831
832         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
833
834         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
835         (WTR::UIScriptController::setHardwareKeyboardAttached):
836         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
837         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
838         (WTR::UIScriptController::setHardwareKeyboardAttached):
839         * TestRunnerShared/UIScriptContext/UIScriptController.h:
840         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
841
842         Additionally link against GraphicsServices in WebKitTestRunner.
843
844         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
845         (WTR::TestController::platformResetStateToConsistentValues):
846         (WTR::UIScriptController::setHardwareKeyboardAttached):
847
848 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
849
850         [GTK][WPE] Fix pacman install-dependencies packages
851         https://bugs.webkit.org/show_bug.cgi?id=196817
852
853         Reviewed by Žan Doberšek.
854         
855         python3-setuptools is called python-setuptools
856         ruby-highline is only available on AUR
857         libv4l-devel is incorporated in v4l-utils
858
859         * gtk/install-dependencies:
860         * wpe/install-dependencies:
861
862 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
863
864         [GTK] REGRESSION(r243860): Many tests failing
865         https://bugs.webkit.org/show_bug.cgi?id=196791
866
867         Reviewed by Joanmarie Diggs.
868
869         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
870         multiple documents and check that accessibility hierarchy is updated after a navigation.
871
872         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
873         (loadChangedCallback):
874         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
875         (AccessibilityTest::AccessibilityTest):
876         (AccessibilityTest::~AccessibilityTest):
877         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
878         (AccessibilityTest::findTestServerApplication):
879         (AccessibilityTest::findDocumentWeb):
880         (AccessibilityTest::findRootObject):
881         (AccessibilityTest::waitUntilChildrenRemoved):
882         (AccessibilityTest::ensureProxy):
883         (testAtspiBasicHierarchy):
884         (beforeAll):
885         (afterAll):
886
887 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
888
889         [ews-build] Handle bug titles with unicode characters
890         https://bugs.webkit.org/show_bug.cgi?id=196802
891
892         Reviewed by Dewei Zhu.
893
894         * BuildSlaveSupport/ews-build/steps.py:
895         (ValidatePatch._is_bug_closed):
896
897 2019-04-11  Michael Saboff  <msaboff@apple.com>
898
899         Improve the Inline Cache Stats code
900         https://bugs.webkit.org/show_bug.cgi?id=196836
901
902         Reviewed by Saam Barati.
903
904         Added a new script to consolidate and arrange the output of --useICStats option.
905
906         This script merges the output from every group into one large table and sorts it from most common to
907         least common.  It also counts the slow path GetById and PutById variants and then calculates the
908         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
909         Put together, this is useful to see what property accesses are not getting cached.
910
911         * Scripts/ic-stats.py: Added.
912         (ICStats):
913         (ICStats.__init__):
914         (ICStats.parse):
915         (ICStats.dumpStats):
916         (usage):
917
918 2019-04-10  Alex Christensen  <achristensen@webkit.org>
919
920         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
921         https://bugs.webkit.org/show_bug.cgi?id=196809
922         <rdar://49800762>
923
924         Reviewed by Brady Eidson.
925
926         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
927         (TEST):
928
929 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
930
931         requestAnimationFrame should execute before the next frame
932         https://bugs.webkit.org/show_bug.cgi?id=177484
933
934         Reviewed by Simon Fraser.
935
936         Add trace points for the page RenderingUpdate.
937
938         * Tracing/SystemTracePoints.plist:
939
940 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
941
942         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
943         https://bugs.webkit.org/show_bug.cgi?id=196760
944
945         Reviewed by Don Olmstead.
946
947         vswhere.exe has been bundled since Visual Studio 2017 version
948         15.2. We shouldn't download vswhere.exe.
949
950         * Scripts/build-jsc: Do not call update-vswhere.py.
951         * Scripts/build-webkit: Ditto.
952         * Scripts/update-vswhere.py: Removed.
953         * Scripts/webkitdirs.pm:
954         (requireModulesForVSWhere): Deleted.
955         (pickCurrentVisualStudioInstallation): Deleted.
956         (visualStudioInstallDirVSWhere): Return the latest installed VS
957         installation path by using the bundled vswhere.exe.
958         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
959         (visualStudioInstallDirFallback): Removed.
960
961 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
962
963         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
964         https://bugs.webkit.org/show_bug.cgi?id=196780
965
966         Reviewed by Alexey Proskuryakov.
967
968         * BuildSlaveSupport/ews-build/steps.py:
969         * BuildSlaveSupport/ews-build/steps_unittest.py:
970
971 2019-04-10  Alex Christensen  <achristensen@webkit.org>
972
973         Add SPI WKNavigationResponse._downloadAttribute
974         https://bugs.webkit.org/show_bug.cgi?id=196755
975         <rdar://49587365>
976
977         Reviewed by Brady Eidson.
978
979         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
980         (-[NavigationResponseTestDelegate navigationResponse]):
981         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
982         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
983         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
984         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
985         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
986         (readRequest):
987         (writeResponse):
988         (TEST):
989
990 2019-04-10  Tim Horton  <timothy_horton@apple.com>
991
992         Add modern API for overriding the page's specified viewport configuration
993         https://bugs.webkit.org/show_bug.cgi?id=167734
994         <rdar://problem/30331795>
995
996         Reviewed by Simon Fraser.
997
998         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
999         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1000
1001 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1002
1003         Add support for incremental bytecode cache updates
1004         https://bugs.webkit.org/show_bug.cgi?id=195000
1005
1006         Reviewed by Filip Pizlo.
1007
1008         Exit when the initial run to generate bytecode fails.
1009
1010         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1011
1012 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1013
1014         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1015         https://bugs.webkit.org/show_bug.cgi?id=196744
1016         <rdar://49415309>
1017
1018         Reviewed by Chris Dumez.
1019
1020         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1021         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1022
1023 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1024
1025         Add a way to opt into modern compatibility mode in layout tests
1026         https://bugs.webkit.org/show_bug.cgi?id=196770
1027         <rdar://problem/49777550>
1028
1029         Reviewed by Antoine Quint.
1030
1031         Add a new test option to enable modern compatibility mode in layout tests.
1032
1033         * WebKitTestRunner/TestController.cpp:
1034         (WTR::updateTestOptionsFromTestHeader):
1035         * WebKitTestRunner/TestController.h:
1036         * WebKitTestRunner/TestOptions.h:
1037         (WTR::TestOptions::hasSameInitializationOptions const):
1038         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1039         (WTR::TestController::platformCreateWebView):
1040         (WTR::TestController::enableModernCompatibilityMode):
1041
1042 2019-04-10  Andy Estes  <aestes@apple.com>
1043
1044         Try to fix the 32-bit watchOS build.
1045
1046         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1047         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1048
1049 2019-04-10  Antoine Quint  <graouts@apple.com>
1050
1051         Enable Pointer Events on watchOS
1052         https://bugs.webkit.org/show_bug.cgi?id=196771
1053         <rdar://problem/49040909>
1054
1055         Reviewed by Dean Jackson.
1056
1057         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1058
1059 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1060
1061         Unreviewed. Fix WPE accessibility tests after r244059.
1062
1063         We are failing to load the injected bundle due to undefined symbol
1064         AccessibilityUIElement::replaceTextInRange().
1065
1066         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1067         (WTR::AccessibilityUIElement::replaceTextInRange):
1068
1069 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1070
1071         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1072         https://bugs.webkit.org/show_bug.cgi?id=196727
1073
1074         Reviewed by Fujii Hironori.
1075
1076         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1077         (WebKitBrowserWindow::create):
1078
1079 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1080
1081         [ews-build] Add unit tests for PrintConfiguration
1082         https://bugs.webkit.org/show_bug.cgi?id=196752
1083
1084         Reviewed by Dewei Zhu.
1085
1086         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1087
1088 2019-04-09  Keith Rollin  <krollin@apple.com>
1089
1090         Unreviewed build maintenance -- update .xcfilelists.
1091
1092         * DumpRenderTree/DerivedSources-input.xcfilelist:
1093         * DumpRenderTree/DerivedSources-output.xcfilelist:
1094
1095 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1096
1097         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1098         https://bugs.webkit.org/show_bug.cgi?id=196743
1099         <rdar://problem/43897551>
1100
1101         Reviewed by Tim Horton.
1102
1103         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1104         (TEST):
1105
1106 2019-04-09  Youenn Fablet  <youenn@apple.com>
1107
1108         Close service worker database on network process suspension
1109         https://bugs.webkit.org/show_bug.cgi?id=196623
1110         <rdar://problem/48930869>
1111
1112         Reviewed by Alex Christensen.
1113
1114         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1115
1116 2019-04-09  Daniel Bates  <dabates@apple.com>
1117
1118         [iPad] Should open popover when the spacebar is pressed
1119         https://bugs.webkit.org/show_bug.cgi?id=196360
1120         <rdar://problem/49389129>
1121
1122         Reviewed by Brent Fulgham.
1123
1124         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1125
1126         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1127         (WTR::UIScriptController::isShowingPopover const): Added.
1128         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1129         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1130         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1131         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1132         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1133         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1134         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1135         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1136         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1137         (WTR::UIScriptController::isShowingPopover const): Added.
1138         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1139         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1140         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1141         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1142         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1143         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1144         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1145         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1146         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1147         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1148         (WTR::UIScriptController::isShowingPopover const): Added.
1149         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1150         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1151
1152 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1153
1154         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1155         https://bugs.webkit.org/show_bug.cgi?id=196665
1156         <rdar://45115669>
1157
1158         Reviewed by Geoff Garen.
1159
1160         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1161         (goBack):
1162         (+[SimpleLookupContext sharedLookupContext]):
1163         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1164         (TEST):
1165         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1166         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1167
1168 2019-04-09  John Wilander  <wilander@apple.com>
1169
1170         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1171         https://bugs.webkit.org/show_bug.cgi?id=196558
1172         <rdar://problem/47650245>
1173
1174         Reviewed by Youenn Fablet.
1175
1176         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1177         (TestWebKitAPI::TEST):
1178             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1179
1180 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1181
1182         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1183         https://bugs.webkit.org/show_bug.cgi?id=196720
1184
1185         Reviewed by Konstantin Tokarev.
1186
1187         * TestWebKitAPI/PlatformMac.cmake:
1188
1189 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1190
1191         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1192         https://bugs.webkit.org/show_bug.cgi?id=196694
1193         <rdar://problem/48388734>
1194
1195         Rubber-stamped by Aakash Jain.
1196
1197         * Scripts/webkitpy/port/image_diff.py:
1198         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1199         * Scripts/webkitpy/port/server_process.py:
1200         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1201         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1202         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1203         * Scripts/webkitpy/port/server_process_mock.py:
1204         (MockServerProcess.has_available_stdout):
1205         * Scripts/webkitpy/port/server_process_unittest.py:
1206         (TestServerProcess.serial_test_basic):
1207
1208 2019-04-09  Jer Noble  <jer.noble@apple.com>
1209
1210         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1211         https://bugs.webkit.org/show_bug.cgi?id=196097
1212
1213         Reviewed by Eric Carlson.
1214
1215         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1216
1217         * DumpRenderTree/mac/DumpRenderTree.mm:
1218         (resetWebPreferencesToConsistentValues):
1219         * WebKitTestRunner/TestController.cpp:
1220         (WTR::TestController::resetPreferencesToConsistentValues):
1221
1222 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1223
1224         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1225         https://bugs.webkit.org/show_bug.cgi?id=196690
1226
1227         Reviewed by Michael Catanzaro.
1228
1229         * QueueStatusServer/config/queues.py:
1230         * Scripts/webkitpy/common/config/ews.json:
1231         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1232         (test_ews_name):
1233
1234 2019-04-09  Chris Dumez  <cdumez@apple.com>
1235
1236         Loads using loadHTMLString() cause flashing when process-swapping
1237         https://bugs.webkit.org/show_bug.cgi?id=196714
1238         <rdar://problem/49637354>
1239
1240         Reviewed by Antti Koivisto.
1241
1242         Add API test coverage.
1243
1244         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1245
1246 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1247
1248         Unreviewed. Fix ATK accessibility tests after r244059.
1249
1250         We are failing to load the injected bundle due to undefined symbol
1251         AccessibilityUIElement::replaceTextInRange().
1252
1253         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1254         (WTR::AccessibilityUIElement::replaceTextInRange):
1255
1256 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1257
1258         AX: Support API: accessibilityReplaceRange:withText
1259         https://bugs.webkit.org/show_bug.cgi?id=196636
1260
1261         Unreviewed build fix for Windows port.
1262
1263         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1264         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1265
1266 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1267
1268         [CMake][WinCairo] Separate copied headers into different directories
1269         https://bugs.webkit.org/show_bug.cgi?id=196655
1270
1271         Reviewed by Michael Catanzaro.
1272
1273         * DumpRenderTree/CMakeLists.txt:
1274         * MiniBrowser/win/CMakeLists.txt:
1275         * TestWebKitAPI/CMakeLists.txt:
1276         * TestWebKitAPI/PlatformWin.cmake:
1277
1278 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1279
1280         Log stack-trace for run-webkit-tests when interrupted
1281         https://bugs.webkit.org/show_bug.cgi?id=176393
1282         <rdar://problem/34262310>
1283
1284         Reviewed by Lucas Forschler.
1285
1286         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1287         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1288         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1289         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1290         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1291         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1292         (main): Set handlers to log stack trace on interruption.
1293
1294 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1295
1296         AX: Support API: accessibilityReplaceRange:withText
1297         https://bugs.webkit.org/show_bug.cgi?id=196636
1298
1299         Unreviewed build fix for Windows port.
1300
1301         * DumpRenderTree/AccessibilityUIElement.cpp:
1302         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1303
1304 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1305
1306         [ews-build] Scripts using Buildbot API have CORS error
1307         https://bugs.webkit.org/show_bug.cgi?id=196709
1308
1309         Reviewed by Alexey Proskuryakov.
1310
1311         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1312
1313 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1314
1315         AX: Support API: accessibilityReplaceRange:withText
1316         https://bugs.webkit.org/show_bug.cgi?id=196636
1317
1318         Reviewed by Daniel Bates.
1319
1320         * DumpRenderTree/AccessibilityUIElement.cpp:
1321         (replaceTextInRangeCallback):
1322         (AccessibilityUIElement::replaceTextInRange):
1323         (AccessibilityUIElement::getJSClass):
1324         * DumpRenderTree/AccessibilityUIElement.h:
1325         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1326         (AccessibilityUIElement::replaceTextInRange):
1327         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1328         (AccessibilityUIElement::replaceTextInRange):
1329         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1330         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1331         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1332         (WTR::AccessibilityUIElement::replaceTextInRange):
1333         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1334         (WTR::AccessibilityUIElement::replaceTextInRange):
1335
1336 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1337
1338         [iOS] Do not allow starting selection drags when selection views are not visible
1339         https://bugs.webkit.org/show_bug.cgi?id=196686
1340         <rdar://problem/49399192>
1341
1342         Reviewed by Tim Horton.
1343
1344         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1345         also add some new API tests to cover scenarios where the web view is not first responder.
1346
1347         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1348         (TestWebKitAPI::TEST):
1349         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1350
1351         Add a switch to optionally make the web view first responder when starting the simulated drag.
1352
1353         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1354         (-[DragAndDropSimulator initWithWebView:]):
1355         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1356
1357 2019-04-08  Justin Fan  <justin_fan@apple.com>
1358
1359         [Web GPU] Fix Web GPU experimental feature on iOS
1360         https://bugs.webkit.org/show_bug.cgi?id=196632
1361
1362         Reviewed by Myles C. Maxfield.
1363
1364         Properly make Web GPU available on iOS 11+.
1365
1366         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1367
1368 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1369
1370         [ews-build] Do not upload archive when Compile Fails
1371         https://bugs.webkit.org/show_bug.cgi?id=196674
1372
1373         Reviewed by Alexey Proskuryakov.
1374
1375         * BuildSlaveSupport/ews-build/factories.py:
1376         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1377         * BuildSlaveSupport/ews-build/steps.py:
1378         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1379         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1380         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1381
1382 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1383
1384         Enable DFG on MIPS
1385         https://bugs.webkit.org/show_bug.cgi?id=196689
1386
1387         Reviewed by Žan Doberšek.
1388
1389         Since the bytecode change, we enabled the baseline JIT on mips in
1390         r240432, but DFG is still missing. With this change, all tests are
1391         passing on a ci20 board.
1392
1393         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1394
1395 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1396
1397         [Flatpak] Second run update-webkitwpe-flatpak fails
1398         https://bugs.webkit.org/show_bug.cgi?id=192702
1399
1400         Reviewed by Carlos Garcia Campos.
1401
1402         * flatpak/flatpakutils.py:
1403         (FlatpakObject.flatpak): Fix typo.
1404         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1405         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1406
1407 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1408
1409         [GTK][WPE] outlook.live.com displays old-fashioned UI
1410         https://bugs.webkit.org/show_bug.cgi?id=196642
1411
1412         Reviewed by Carlos Garcia Campos.
1413
1414         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1415         (TestWebKitAPI::TEST): New Mac platform quirk test.
1416
1417 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1418
1419         Unreviewed, rolling out r243956.
1420         https://bugs.webkit.org/show_bug.cgi?id=196688
1421
1422         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1423         by aakashjain on #webkit).
1424
1425         Reverted changeset:
1426
1427         "Clicking "Go Back" from a safe browsing warning from an
1428         iframe should navigate the WKWebView back to the previous
1429         page"
1430         https://bugs.webkit.org/show_bug.cgi?id=196665
1431         https://trac.webkit.org/changeset/243956
1432
1433 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1434
1435         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1436         https://bugs.webkit.org/show_bug.cgi?id=196669
1437
1438         Reviewed by Geoffrey Garen.
1439
1440         Added three new unit tests for WeakHashSet.
1441
1442         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1443         (WTF_WeakPtr.WeakHashSetConstObjects):
1444         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1445         (WTF_WeakPtr.WeakHashSetComputeSize):
1446
1447 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1448
1449         Hide next and previous form control buttons when WKWebView is editable
1450         https://bugs.webkit.org/show_bug.cgi?id=196672
1451         <rdar://problem/35625321>
1452
1453         Reviewed by Tim Horton.
1454
1455         Add a new API test.
1456
1457         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1458         (-[TestWKWebView lastTrailingBarButtonGroup]):
1459         (TestWebKitAPI::TEST):
1460         * TestWebKitAPI/ios/UIKitSPI.h:
1461
1462 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1463
1464         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1465         https://bugs.webkit.org/show_bug.cgi?id=196077
1466         <rdar://problem/49108202>
1467
1468         Reviewed by Chris Dumez.
1469
1470         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1471         on new web view.
1472
1473         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1474
1475 2019-04-05  Saam Barati  <sbarati@apple.com>
1476
1477         Make compare-results understand MotionMark
1478         https://bugs.webkit.org/show_bug.cgi?id=196666
1479
1480         Reviewed by Yusuke Suzuki.
1481
1482         * Scripts/compare-results:
1483         (PLT5Results):
1484         (detectMotionMark):
1485         (detectMotionMark1_1):
1486         (motionMarkResults):
1487         (motionMark1_1Results):
1488         (detectBenchmark):
1489         (biggerIsBetter):
1490         (main):
1491
1492 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1493
1494         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1495         https://bugs.webkit.org/show_bug.cgi?id=196665
1496         <rdar://45115669>
1497
1498         Reviewed by Geoff Garen.
1499
1500         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1501         (goBack):
1502         (+[SimpleLookupContext sharedLookupContext]):
1503         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1504         (TEST):
1505         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1506         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1507
1508 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1509
1510         [ews-build] Add configuration and architecture for windows builders
1511         https://bugs.webkit.org/show_bug.cgi?id=196660
1512
1513         Reviewed by Lucas Forschler.
1514
1515         * BuildSlaveSupport/ews-build/config.json:
1516
1517 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1518
1519         webkitpy: Don't run subsequent rounds if interrupted
1520         https://bugs.webkit.org/show_bug.cgi?id=196646
1521
1522         Reviewed by Aakash Jain.
1523
1524         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1525         (Manager.run): Bail out if interrupted.
1526
1527 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1528
1529         Test sessionStorage in PSON private browsing mode
1530         https://bugs.webkit.org/show_bug.cgi?id=196561
1531
1532         Reviewed by Alex Christensen.
1533
1534         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1535
1536 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1537
1538         Unreviewed, rolling out r243833.
1539         https://bugs.webkit.org/show_bug.cgi?id=196645
1540
1541         This change breaks build of WPE and GTK ports (Requested by
1542         annulen on #webkit).
1543
1544         Reverted changeset:
1545
1546         "[CMake][WTF] Mirror XCode header directories"
1547         https://bugs.webkit.org/show_bug.cgi?id=191662
1548         https://trac.webkit.org/changeset/243833
1549
1550 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1551
1552         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1553         https://bugs.webkit.org/show_bug.cgi?id=196635
1554
1555         Reviewed by Antti Koivisto.
1556         
1557         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1558         for a test to enable async frame scrolling via:
1559             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1560         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1561         
1562         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1563
1564         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1565         (WTR::InjectedBundle::beginTesting):
1566         * WebKitTestRunner/TestController.cpp:
1567         (WTR::TestController::resetPreferencesToConsistentValues):
1568
1569 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1570
1571         Use a correct LC_RPATH when building with ASan
1572         https://bugs.webkit.org/show_bug.cgi?id=196576
1573
1574         Reviewed by David Kilzer.
1575
1576         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1577         so that ../Frameworks is checked. This is simpler and more reliable than updating
1578         each SPC service xcconfig.
1579
1580 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1581
1582         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1583         https://bugs.webkit.org/show_bug.cgi?id=196629
1584
1585         Reviewed by Lucas Forschler.
1586
1587         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1588
1589 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1590
1591         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1592         https://bugs.webkit.org/show_bug.cgi?id=196618
1593
1594         Reviewed by Lucas Forschler.
1595
1596         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1597         (StatusBubble): Added QUEUE_TRIGGERS.
1598         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1599         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1600         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1601         its parent(builder).
1602
1603 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1604
1605         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1606         https://bugs.webkit.org/show_bug.cgi?id=196625
1607
1608         Reviewed by Lucas Forschler.
1609
1610         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1611         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1612
1613 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1614
1615         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1616         https://bugs.webkit.org/show_bug.cgi?id=196630
1617
1618         Reviewed by Wenson Hsieh.
1619
1620         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1621
1622 2019-04-04  Youenn Fablet  <youenn@apple.com>
1623
1624         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1625         https://bugs.webkit.org/show_bug.cgi?id=196543
1626
1627         Reviewed by Alex Christensen.
1628
1629         * WebKitTestRunner/TestController.cpp:
1630         (WTR::TestController::generatePageConfiguration):
1631
1632 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1633
1634         [ews-app] Status bubble should not display skipped buildbot steps
1635         https://bugs.webkit.org/show_bug.cgi?id=196584
1636
1637         Reviewed by Lucas Forschler.
1638
1639         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1640
1641 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1642
1643         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1644         https://bugs.webkit.org/show_bug.cgi?id=196620
1645
1646         Reviewed by Lucas Forschler.
1647
1648         * BuildSlaveSupport/ews-app/ews/config.py:
1649
1650 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1651
1652         [Win] DumpRenderTreeWatchDog.py is not checked into source
1653         https://bugs.webkit.org/show_bug.cgi?id=196567
1654         <rdar://problem/49525901>
1655
1656         Reviewed by Lucas Forschler.
1657
1658         This script is used on Win EWS bots to terminate hanging DRT processes.
1659
1660         * EWSTools/dumprendertreewatchdog.py: Added.
1661
1662 2019-04-04  Chris Dumez  <cdumez@apple.com>
1663
1664         Unreviewed, roll out r243858 which made tests time out.
1665
1666         Disable new API tests on Windows instead.
1667
1668         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1669         (TestWebKitAPI::TEST):
1670
1671 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1672
1673         [ATK] Cleanup WebPageAccessibilityObjectAtk
1674         https://bugs.webkit.org/show_bug.cgi?id=196537
1675
1676         Reviewed by Michael Catanzaro.
1677
1678         Also consider files under atk directories as exceptions for GObject conventions.
1679
1680         * Scripts/webkitpy/style/checkers/cpp.py:
1681         (check_identifier_name_in_declaration):
1682
1683 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1684
1685         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1686         https://bugs.webkit.org/show_bug.cgi?id=196588
1687         <rdar://problem/49365787>
1688
1689         Unreviewed build fix for Windows port.
1690
1691         error C3861: 'kill': identifier not found
1692
1693         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1694         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1695
1696 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1697
1698         [ews-build] Cancel build and similar operations should have authentication
1699         https://bugs.webkit.org/show_bug.cgi?id=196520
1700
1701         Reviewed by Dewei Zhu.
1702
1703         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1704         environment variables.
1705
1706 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1707
1708         [ews-build] Do not trigger queues which are not in production yet
1709         https://bugs.webkit.org/show_bug.cgi?id=196581
1710
1711         Reviewed by Dewei Zhu.
1712
1713         * BuildSlaveSupport/ews-build/config.json:
1714
1715 2019-04-03  Chris Dumez  <cdumez@apple.com>
1716
1717         Unreviewed, fix typo in the name of API test added in r243848.
1718
1719         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1720         (TestWebKitAPI::TEST):
1721
1722 2019-04-03  Chris Dumez  <cdumez@apple.com>
1723
1724         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1725         https://bugs.webkit.org/show_bug.cgi?id=196588
1726         <rdar://problem/49365787>
1727
1728         Reviewed by Ryosuke Niwa.
1729
1730         Add API test coverage.
1731
1732         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1733         (TestWebKitAPI::nullJavaScriptCallback):
1734         (TestWebKitAPI::didCrashCheckFrames):
1735         (TestWebKitAPI::TEST):
1736
1737 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1738
1739         run-webkit-tests: Upload test results (new results database)
1740         https://bugs.webkit.org/show_bug.cgi?id=196577
1741         <rdar://problem/34841155>
1742
1743         Reviewed by Lucas Forschler.
1744
1745         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1746         (Manager.run): Upload results after each device shard, since the configuration will be
1747         different for each device.
1748         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1749         uploaded to a results database.
1750         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1751         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1752
1753 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1754
1755         -apple-trailing-word is needed for browser detection
1756         https://bugs.webkit.org/show_bug.cgi?id=196575
1757
1758         Unreviewed.
1759
1760         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1761
1762 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1763
1764         [CMake][WTF] Mirror XCode header directories
1765         https://bugs.webkit.org/show_bug.cgi?id=191662
1766
1767         Reviewed by Konstantin Tokarev.
1768
1769         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1770         builds.
1771
1772         * CMakeLists.txt:
1773         * DumpRenderTree/CMakeLists.txt:
1774         * DumpRenderTree/PlatformWin.cmake:
1775         * MiniBrowser/win/CMakeLists.txt:
1776         * TestWebKitAPI/CMakeLists.txt:
1777         * TestWebKitAPI/PlatformWin.cmake:
1778         * WebKitTestRunner/PlatformGTK.cmake:
1779         * WebKitTestRunner/PlatformWin.cmake:
1780
1781 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1782
1783         [ews-app] Status bubble should not display certain infrastructure status messages
1784         https://bugs.webkit.org/show_bug.cgi?id=196550
1785
1786         Reviewed by Lucas Forschler.
1787
1788         Do not display the steps which are un-needed for end-user. This information is still avaiable
1789         if the user click on the bubble and look at the Buildbot build.
1790         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1791         (StatusBubble._steps_messages):
1792         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1793
1794 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1795
1796         [ews-build] Use https for sending data to ews-app
1797         https://bugs.webkit.org/show_bug.cgi?id=196492
1798
1799         Reviewed by Lucas Forschler.
1800
1801         * BuildSlaveSupport/ews-build/events.py:
1802
1803 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1804
1805         Remove support for -apple-trailing-word
1806         https://bugs.webkit.org/show_bug.cgi?id=196525
1807
1808         Reviewed by Zalan Bujtas.
1809
1810         This CSS property is nonstandard and not used.
1811
1812         * Scripts/webkitperl/FeatureList.pm:
1813         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1814
1815 2019-04-03  Youenn Fablet  <youenn@apple.com>
1816
1817         Add a test for DOMCache on multiple browsing in case of private browsing
1818         https://bugs.webkit.org/show_bug.cgi?id=196524
1819
1820         Reviewed by Alex Christensen.
1821
1822         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1823         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1824
1825 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1826
1827         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1828         https://bugs.webkit.org/show_bug.cgi?id=196540
1829
1830         Reviewed by Aakash Jain.
1831
1832         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1833
1834 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1835
1836         Add plumbing for a compatibility mode preference in WebKit
1837         https://bugs.webkit.org/show_bug.cgi?id=196005
1838
1839         Reviewed by Tim Horton.
1840
1841         Add new API tests.
1842
1843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1844         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1845
1846 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1847
1848         [WPE][GTK] Update libsrtp dependency package for Debian
1849         https://bugs.webkit.org/show_bug.cgi?id=196528
1850
1851         Reviewed by Frédéric Wang.
1852
1853         * gtk/install-dependencies:
1854         * wpe/install-dependencies:
1855
1856 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1857
1858         [WK2] Add support for Window's beforeprint / afterprint events
1859         https://bugs.webkit.org/show_bug.cgi?id=196478
1860         <rdar://problem/49535124>
1861
1862         Unreviewed build fix for MSVC.
1863
1864         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1865
1866         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1867
1868         * WebKitTestRunner/TestController.cpp:
1869         (WTR::printFrame): Use int and float literals.
1870
1871 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1872
1873         [ews-build] Reassign bots to queues
1874
1875         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1876
1877 2019-04-02  Chris Dumez  <cdumez@apple.com>
1878
1879         [WK2] Add support for Window's beforeprint / afterprint events
1880         https://bugs.webkit.org/show_bug.cgi?id=196478
1881
1882         Reviewed by Alex Christensen.
1883
1884         Add minimal implementation for printFrame in WebKitTestRunner.
1885
1886         * WebKitTestRunner/TestController.cpp:
1887         (WTR::printFrame):
1888         (WTR::TestController::createOtherPage):
1889         (WTR::TestController::createWebViewWithOptions):
1890
1891 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1892
1893         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1894         https://bugs.webkit.org/show_bug.cgi?id=196491
1895
1896         Reviewed by Lucas Forschler.
1897
1898         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1899
1900 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1901
1902         [ews-build] Configure buildbot try credentials in environment variables
1903         https://bugs.webkit.org/show_bug.cgi?id=196501
1904
1905         Reviewed by Lucas Forschler.
1906
1907         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1908         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1909         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1910
1911 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1912
1913         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1914         https://bugs.webkit.org/show_bug.cgi?id=196496
1915         <rdar://problem/49521634>
1916
1917         Reviewed by Chris Dumez.
1918
1919         Add new API tests (see WebKit ChangeLog for more detail).
1920
1921         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1922         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1923         (TEST):
1924
1925 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1926
1927         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1928         <https://webkit.org/b/196499>
1929
1930         Reviewed by Alexey Proskuryakov.
1931
1932         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1933         ENABLE_ADDRESS_SANITIZER.
1934
1935 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1936
1937         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1938         https://bugs.webkit.org/show_bug.cgi?id=182757
1939
1940         Reviewed by Don Olmstead.
1941
1942         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1943         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1944
1945 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1946
1947         run-api-tests: Upload test results
1948         https://bugs.webkit.org/show_bug.cgi?id=196323
1949         <rdar://problem/49356714>
1950
1951         Reviewed by Lucas Forschler.
1952
1953         * Scripts/webkitpy/api_tests/manager.py:
1954         (Manager):
1955         (Manager.run): Upload results to a results database.
1956         * Scripts/webkitpy/api_tests/run_api_tests.py:
1957         (parse_args): Add upload arguments.
1958         * Scripts/webkitpy/port/base.py:
1959         (Port):
1960         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1961         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1962         with commits from any other associated repositories.
1963         * Scripts/webkitpy/port/device.py:
1964         (Device):
1965         (Device.build_version): Access build_versoin of underlying platform device.
1966         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1967         (IOSSimulatorTest):
1968         (IOSSimulatorTest.test_configuration_for_upload):
1969         * Scripts/webkitpy/port/device_port.py:
1970         (DevicePort):
1971         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1972         the same as the machine uploading results.
1973         * Scripts/webkitpy/port/mac.py:
1974         (MacPort):
1975         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1976         * Scripts/webkitpy/port/mac_unittest.py:
1977         (MacTest):
1978         (MacTest.test_configuration_for_upload):
1979         * Scripts/webkitpy/xcode/simulated_device.py:
1980         (SimulatedDeviceManager._create_device_with_runtime):
1981         (SimulatedDevice.__init__): Create simulated device with a build_version.
1982         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1983         (test_existing_simulator):
1984
1985 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1986
1987         Remove extra newline characters (Follow-up fix to r243707)
1988
1989         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1990
1991 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1992
1993         [ews-app] Use API_KEY to accept results data
1994         https://bugs.webkit.org/show_bug.cgi?id=196461
1995
1996         Reviewed by Dewei Zhu.
1997
1998         * BuildSlaveSupport/ews-app/ews/views/results.py:
1999         (Results.post): Validate EWS_API_KEY before accepting any data.
2000         * BuildSlaveSupport/ews-build/events.py:
2001         (Events.sendData): Send EWS_API_KEY if available along with event data.
2002
2003 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2004
2005         Unable to copy and paste a PDF from Notes into Mail compose body
2006         https://bugs.webkit.org/show_bug.cgi?id=196442
2007         <rdar://problem/48573098>
2008
2009         Reviewed by Tim Horton.
2010
2011         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2012         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2013         to be specified on the item providers.
2014
2015         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2016         (TestWebKitAPI::mapItemForTesting):
2017         (TestWebKitAPI::contactItemForTesting):
2018
2019 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2020
2021         Make UIWKDocumentContext rects per-character instead of per-word
2022         https://bugs.webkit.org/show_bug.cgi?id=196459
2023
2024         Reviewed by Wenson Hsieh.
2025
2026         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2027         (TEST):
2028         Adjust test results due to switching to per-character rects.
2029
2030 2019-04-01  Chris Dumez  <cdumez@apple.com>
2031
2032         UIProcess crash when a prewarmed process is terminated
2033         https://bugs.webkit.org/show_bug.cgi?id=196451
2034         <rdar://problem/49245471>
2035
2036         Reviewed by Geoffrey Garen.
2037
2038         Add API test coverage.
2039
2040         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2041         (TEST):
2042
2043 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2044
2045         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2046         https://bugs.webkit.org/show_bug.cgi?id=196449
2047
2048         Reviewed by Lucas Forschler.
2049
2050         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2051         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2052         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2053         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2054
2055 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2056
2057         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2058         https://bugs.webkit.org/show_bug.cgi?id=196444
2059
2060         Reviewed by Lucas Forschler.
2061
2062         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2063
2064 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2065
2066         Add SPI to canonicalize NSURLs with WTF::URL
2067         https://bugs.webkit.org/show_bug.cgi?id=196415
2068         <rdar://problem/44980271>
2069
2070         Reviewed by Darin Adler.
2071
2072         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2073         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2074         (TestWebKitAPI::TEST):
2075
2076 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2077
2078         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2079         https://bugs.webkit.org/show_bug.cgi?id=196441
2080
2081         Reviewed by Carlos Garcia Campos.
2082
2083         Don't cache the wpe_view_backend object that might not exist yet at the
2084         time of EventSenderProxy constructor invocation, but instead retrieve
2085         that object whenever it's required for event dispatching. This should
2086         avoid crashes in this constructor now that it's invoked before any
2087         PlatformWindow has been set up (as changed in r243496).
2088
2089         * WebKitTestRunner/EventSenderProxy.h:
2090         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2091         (WTR::viewBackend):
2092         (WTR::EventSenderProxy::EventSenderProxy):
2093         (WTR::EventSenderProxy::mouseDown):
2094         (WTR::EventSenderProxy::mouseUp):
2095         (WTR::EventSenderProxy::mouseMoveTo):
2096         (WTR::EventSenderProxy::mouseScrollBy):
2097         (WTR::EventSenderProxy::keyDown):
2098         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2099
2100 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2101
2102         [Win][WebKit] MiniBrowser should support high DPI display
2103         https://bugs.webkit.org/show_bug.cgi?id=196391
2104
2105         Reviewed by Alex Christensen.
2106
2107         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2108         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2109         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2110         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2111
2112 2019-03-31  Sam Weinig  <weinig@apple.com>
2113
2114         Remove more i386 specific configurations
2115         https://bugs.webkit.org/show_bug.cgi?id=196430
2116
2117         Reviewed by Alexey Proskuryakov.
2118
2119         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2120         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2121
2122 2019-03-31  Andy Estes  <aestes@apple.com>
2123
2124         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2125         https://bugs.webkit.org/show_bug.cgi?id=196433
2126         <rdar://problem/49293305>
2127
2128         Reviewed by Tim Horton.
2129
2130         Enhanced API test coverage to include all navigation response policy decisions in both
2131         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2132
2133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2134         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2135         (TestWebKitAPI::TEST):
2136         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2137         (readFile):
2138         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2139         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2140         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2141         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2142         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2143         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2144         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2145         (-[QuickLookDelegate _downloadDidStart:]):
2146         (-[QuickLookDelegate _download:didReceiveResponse:]):
2147         (-[QuickLookDelegate _download:didReceiveData:]):
2148         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2149         (-[QuickLookDelegate _downloadDidFinish:]):
2150         (-[QuickLookDelegate _download:didFailWithError:]):
2151         (-[QuickLookDelegate _downloadDidCancel:]):
2152         (-[QuickLookDelegate verifyDownload]):
2153         (runTest):
2154         (runTestDecideBeforeLoading):
2155         (runTestDecideAfterLoading):
2156         (TEST):
2157         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2158         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2159         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2160         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2161         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2162         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2163         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2164         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2165         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2166         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2167         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2168         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2169         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2170         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2171
2172 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2173
2174         [CMake] add testdfg as target with build-jsc
2175         https://bugs.webkit.org/show_bug.cgi?id=196393
2176
2177         Reviewed by Saam Barati.
2178
2179         Added testdfg as one of the targets to build when
2180         using CMake.
2181
2182         * Scripts/build-jsc:
2183
2184 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2185
2186         Delete WebMetal implementation in favor of WebGPU
2187         https://bugs.webkit.org/show_bug.cgi?id=195418
2188
2189         Reviewed by Dean Jackson.
2190
2191         * DumpRenderTree/mac/DumpRenderTree.mm:
2192         (enableExperimentalFeatures):
2193         (resetWebPreferencesToConsistentValues):
2194         * Scripts/webkitperl/FeatureList.pm:
2195         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2197         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2198         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2199         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2200         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2201         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2202         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2203         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2204         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2205         (WTR::InjectedBundle::beginTesting):
2206         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2207         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2208         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2209
2210 2019-03-29  Chris Dumez  <cdumez@apple.com>
2211
2212         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2213         https://bugs.webkit.org/show_bug.cgi?id=196405
2214         <rdar://problem/49428130>
2215
2216         Reviewed by Wenson Hsieh.
2217
2218         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2219         the popover presentation methods to be no-ops. Use this in the new test added in
2220         r243523 so that we do not swizzle those methods for all tests. This is needed because
2221         those WatchOS tests rely on the popover getting presented and interactive.
2222
2223         * WebKitTestRunner/TestController.cpp:
2224         (WTR::updateTestOptionsFromTestHeader):
2225         * WebKitTestRunner/TestController.h:
2226         * WebKitTestRunner/TestOptions.h:
2227         (WTR::TestOptions::hasSameInitializationOptions const):
2228         * WebKitTestRunner/ios/TestControllerIOS.mm:
2229         (WTR::TestController::platformInitialize):
2230         (WTR::TestController::platformResetStateToConsistentValues):
2231
2232 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2233
2234         [Curl] Add Server Trust Evaluation Support.
2235         https://bugs.webkit.org/show_bug.cgi?id=191646
2236
2237         Reviewed by Fujii Hironori.
2238
2239         Implemented MiniBrowser UI for asking if user trusts the server.
2240
2241         * MiniBrowser/win/Common.cpp:
2242         (askServerTrustEvaluation):
2243         (replaceString):
2244         * MiniBrowser/win/Common.h:
2245         * MiniBrowser/win/MiniBrowserLib.rc:
2246         * MiniBrowser/win/MiniBrowserLibResource.h:
2247         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2248         (createPEMString):
2249         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2250         (WebKitBrowserWindow::canTrustServerCertificate):
2251         * MiniBrowser/win/WebKitBrowserWindow.h:
2252
2253 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2254
2255         Implement ResizeObserver.
2256         https://bugs.webkit.org/show_bug.cgi?id=157743
2257
2258         Reviewed by Simon Fraser.
2259
2260         Support resizeObserverEnabled webPreferences.
2261
2262         * DumpRenderTree/TestOptions.cpp:
2263         (TestOptions::TestOptions):
2264         * DumpRenderTree/TestOptions.h:
2265         * DumpRenderTree/mac/DumpRenderTree.mm:
2266         (setWebPreferencesForTestOptions):
2267         * DumpRenderTree/win/DumpRenderTree.cpp:
2268         (enableExperimentalFeatures):
2269         * Scripts/webkitperl/FeatureList.pm:
2270         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2271
2272 2019-03-28  John Wilander  <wilander@apple.com>
2273
2274         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2275         https://bugs.webkit.org/show_bug.cgi?id=196281
2276         <rdar://problem/48938748>
2277
2278         Reviewed by Alex Christensen.
2279
2280         This patch adds the function isStatisticsHasLocalStorage() to the
2281         TestRunner. With it, the page can query the WebsiteDataStore in the
2282         UI process to make sure that it sees LocalStorage.
2283
2284         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2285         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2286         (WTR::TestRunner::isStatisticsHasLocalStorage):
2287         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2288         * WebKitTestRunner/TestController.cpp:
2289         (WTR::TestController::isStatisticsHasLocalStorage):
2290         * WebKitTestRunner/TestController.h:
2291         * WebKitTestRunner/TestInvocation.cpp:
2292         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2293
2294 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2295
2296         API::Data::createWithoutCopying should do a null check before calling CFRelease
2297         https://bugs.webkit.org/show_bug.cgi?id=196276
2298         <rdar://problem/48059859>
2299
2300         Reviewed by Alex Christensen.
2301
2302         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2303
2304         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2305         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2306         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2307         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2308         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2309         (TestWebKitAPI::TEST):
2310
2311 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2312
2313         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2314         https://bugs.webkit.org/show_bug.cgi?id=186276
2315
2316         Reviewed by Carlos Garcia Campos.
2317
2318         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2319         (webViewLoadChanged):
2320         (testWebResourceGetDataError):
2321         (testWebResourceGetDataEmpty):
2322         (beforeAll):
2323         (webViewloadChanged): Deleted.
2324
2325 2019-03-27  Andy Estes  <aestes@apple.com>
2326
2327         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2328         https://bugs.webkit.org/show_bug.cgi?id=196317
2329
2330         Reviewed by Dan Bernstein.
2331
2332         package-root copies built products into a staging directory using ditto(1), which does not
2333         follow symbolic links as it traverses a directory. Now that the files in
2334         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2335         itself, these become broken links when ditto'd into the staging directory.
2336
2337         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2338
2339         * Scripts/package-root:
2340
2341 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2342
2343         [ews-app] Update display text of Submit for ews analysis
2344         https://bugs.webkit.org/show_bug.cgi?id=196309
2345
2346         Reviewed by Dewei Zhu.
2347
2348         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2349
2350 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2351
2352         run-webkit-tests should check for leaks in WebKit processes
2353         <https://webkit.org/b/193772>
2354         <rdar://problem/46526680>
2355
2356         Reviewed by Ryosuke Niwa.
2357
2358         This works by doing the following:
2359         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2360           The list of child processes are returned one per line:
2361           process.name: pid
2362         - Run the "#LIST CHILD PROCESSES" command just before the
2363           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2364           processes on the ServerProcess object.
2365         - When the `--leaks` switch is handled, run check_for_leaks() on
2366           each child process after the main test harness.
2367
2368         * DumpRenderTree/mac/DumpRenderTree.mm:
2369         (handleControlCommand):
2370         - Use strncmp() instead of strcmp().
2371         - Add support for handling "#LIST CHILD PROCESSES" command.
2372
2373         * Scripts/webkitpy/port/base.py:
2374         (Port.check_for_leaks):
2375         * Scripts/webkitpy/port/darwin.py:
2376         (DarwinPort.check_for_leaks):
2377         - Rename redundant 'process_pid' argument to 'process_id'.
2378
2379         * Scripts/webkitpy/port/driver.py:
2380         (Driver.do_post_tests_work):
2381         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2382           longer the only command this sends to WebKitTestRunner.
2383         - If the `--leaks` switch is present, send the
2384           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2385           result using Port.set_webkit_processes().
2386         (Driver._parse_child_processes_output):
2387         - Add helper method to parse list of child process names and
2388           process IDs returned from WebKitTestRunner.
2389
2390         * Scripts/webkitpy/port/ios_device.py:
2391         (IOSDevicePort.check_for_leaks):
2392         - Rename redundant 'process_pid' argument to 'process_id'.
2393
2394         * Scripts/webkitpy/port/leakdetector.py:
2395         (LeakDetector._parse_leaks_output):
2396         - Return early if there is no leaks_output.
2397         (LeakDetector.check_for_leaks):
2398         - Rename redundant 'process_pid' argument to 'process_id'.
2399
2400         * Scripts/webkitpy/port/server_process.py:
2401         (ServerProcess.__init__):
2402         (ServerProcess.child_processes):
2403         (ServerProcess.set_child_processes):
2404         - Add instance variable to Port to store list of child process
2405           names and process IDs returned from WebKitTestRunner.
2406         (ServerProcess._start):
2407         - Clear self._child_processes.
2408         (ServerProcess.stop):
2409         - If self._child_processes is set, call
2410           self._port.check_for_leaks() for each child process.
2411
2412         * Scripts/webkitpy/port/server_process_unittest.py:
2413         (TrivialMockPort.check_for_leaks):
2414         - Rename redundant 'process_pid' argument to 'process_id'.
2415
2416         * Scripts/webkitpy/port/simulator_process.py:
2417         (SimulatorProcess.stop):
2418         - If self._child_processes is set, call
2419           self._port.check_for_leaks() for each child process.
2420
2421         * Scripts/webkitpy/port/watch_device.py:
2422         (WatchDevicePort.check_for_leaks):
2423         - Rename redundant 'process_pid' argument to 'process_id'.
2424
2425         * WebKitTestRunner/TestController.cpp:
2426         (WTR::TestController::dumpResponse):
2427         - Extract method from findAndDumpWorldLeaks() so that it may be
2428           reused by findAndDumpWebKitProcessIdentifiers().
2429         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2430         - Add method to output process name and process ID of both the
2431           WebContent and Networking processes.
2432         (WTR::TestController::findAndDumpWorldLeaks):
2433         - Fix missing newline in output when there were no abandoned
2434           documents.
2435         - Call dumpResponse() for extracted code.
2436         (WTR::TestController::handleControlCommand):
2437         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2438         - Use strncmp() instead of strcmp().
2439         - Call findAndDumpWebKitProcessIdentifiers() when
2440           "#LIST CHILD PROCESSES" command is sent.
2441         * WebKitTestRunner/TestController.h:
2442         (WTR::TestController::dumpResponse):
2443         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2444         - Declare methods.
2445
2446 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2447
2448         Unreviewed. Add GLib API test cases after r243434.
2449
2450         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2451         (testWebViewActiveURI):
2452         (serverCallback):
2453         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2454         (sendRequestCallback):
2455
2456 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2457
2458         Geolocation request not complete when watch request was started in a different web process
2459         https://bugs.webkit.org/show_bug.cgi?id=195996
2460
2461         Reviewed by Alex Christensen.
2462
2463         Add a test case.
2464
2465         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2466         (TestWebKitAPI::runJavaScriptAlert):
2467         (TestWebKitAPI::TEST):
2468
2469 2019-03-26  Keith Rollin  <krollin@apple.com>
2470
2471         Update the way generate-xcfilelists returns strings from functions
2472         https://bugs.webkit.org/show_bug.cgi?id=195975
2473         <rdar://problem/49040807>
2474
2475         Reviewed by Dean Jackson.
2476
2477         There are places where generate-xcfilelists executes assignments with
2478         statements like:
2479
2480             FOO=$(some_function)
2481
2482         where "some_function" return a string by echoing it. E.g.
2483
2484             some_function()
2485             {
2486                 echo "Hello, World"
2487             }
2488
2489         This is a common idiom, but it has a problem if "some_function" needs
2490         to call "exit" in an attempt to halt the entire script right then and
2491         there. Since "some_function" is called inside of $(), it's being
2492         executed in a sub-shell. Calling exit in that sub-shell simply exits
2493         that shell; it doesn't not exit the outer shell in which the main part
2494         of the script is still running. As such, the main script keeps
2495         executing when the intent was for the script to halt.
2496
2497         The solution to this is to use a different idiom for returning
2498         strings. The one we now is to pass in the name of the variable to
2499         receive the string result:
2500
2501             some_function()
2502             {
2503                 variable_name=$1
2504                 eval $variable_name ="Hello, World"
2505             }
2506
2507         The call site now looks like
2508
2509             some_function FOO
2510
2511         Because there's no invocation of a sub-shell, some_function can now
2512         call "exit" if it wants to, and the entire script will exit at that
2513         point.
2514
2515         * Scripts/generate-xcfilelists:
2516
2517 2019-03-26  Chris Dumez  <cdumez@apple.com>
2518
2519         Add basic layout test coverage for File Picker on iOS
2520         https://bugs.webkit.org/show_bug.cgi?id=196265
2521
2522         Reviewed by Wenson Hsieh.
2523
2524         Add layout test infrastructure to test the file picker on iOS.
2525
2526         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2527         (WTR::UIScriptController::dismissFilePicker):
2528         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2529         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2530         (WTR::UIScriptController::dismissFilePicker):
2531         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2532         * WebKitTestRunner/TestController.cpp:
2533         (WTR::TestController::createWebViewWithOptions):
2534         (WTR::updateTestOptionsFromTestHeader):
2535         * WebKitTestRunner/TestOptions.h:
2536         (WTR::TestOptions::hasSameInitializationOptions const):
2537         * WebKitTestRunner/ios/TestControllerIOS.mm:
2538         (overridePresentViewController):
2539         (WTR::TestController::platformInitialize):
2540         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2541         (WTR::UIScriptController::dismissFilePicker):
2542
2543 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2544
2545         Implement async paste method on UIWKInteractionViewProtocol
2546         https://bugs.webkit.org/show_bug.cgi?id=196267
2547         <rdar://problem/49236346>
2548
2549         Reviewed by Tim Horton.
2550
2551         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2552         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2553         are now a part of all iOS 12 internal SDKs.
2554
2555         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2556
2557         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2558         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2559
2560         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2561         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2562         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2563         * TestWebKitAPI/ios/UIKitSPI.h:
2564
2565 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2566
2567         [ews-build] Use PostgreSQL for ews.webkit.org database
2568         https://bugs.webkit.org/show_bug.cgi?id=196270
2569
2570         Reviewed by Lucas Forschler.
2571
2572         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2573
2574 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2575
2576         [ews] Reset simctl states on reboot
2577         https://bugs.webkit.org/show_bug.cgi?id=196260
2578
2579         Rubber-stamped by Aakash Jain.
2580
2581         * EWSTools/start-queue-mac.sh:
2582
2583 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2584
2585         [ews-build] Use PostgreSQL for ews-build database
2586         https://bugs.webkit.org/show_bug.cgi?id=196229
2587
2588         Reviewed by Lucas Forschler.
2589
2590         * BuildSlaveSupport/ews-build/master.cfg:
2591
2592 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2593
2594         [ews-build] Get master_hostname dynamically in master.cfg
2595         https://bugs.webkit.org/show_bug.cgi?id=196255
2596
2597         Reviewed by Lucas Forschler.
2598
2599         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2600         send events data in test mode.
2601
2602 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2603
2604         [ews-app] Set db_constraint to False for Foreign Keys
2605         https://bugs.webkit.org/show_bug.cgi?id=196252
2606
2607         Reviewed by Lucas Forschler.
2608
2609         * BuildSlaveSupport/ews-app/ews/models/build.py:
2610         * BuildSlaveSupport/ews-app/ews/models/step.py:
2611
2612 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2613
2614         [ews-build] is_test_mode_enabled should default to True
2615         https://bugs.webkit.org/show_bug.cgi?id=196248
2616
2617         Reviewed by Lucas Forschler.
2618
2619         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2620
2621 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2622
2623         [ews-app] Add webkitperl to ENABLED_QUEUES
2624         https://bugs.webkit.org/show_bug.cgi?id=196253
2625
2626         Reviewed by Lucas Forschler.
2627
2628         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2629
2630 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2631
2632         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2633         https://bugs.webkit.org/show_bug.cgi?id=196211
2634         rdar://problem/49110552
2635
2636         Reviewed by Tim Horton.
2637
2638         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2639         Make sure that EventSenderProxy always exists when running tests. We used to create
2640         it when resetting before the first test, which is a bit too late.
2641
2642         * WebKitTestRunner/TestController.h:
2643         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2644         (WTR::TestController::platformCreateWebView):
2645         (WTR::TestController::platformCreateOtherPage):
2646         (WTR::TestController::finishCreatingPlatformWebView):
2647         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2648         (WTR::PlatformWebView::PlatformWebView):
2649         Moved some code that made NSWindow use NSEvent during web view creation. We may
2650         need to move more if some other case us found, but this is enough for now.
2651
2652 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2653
2654         Unreviewed. Fix typo in GLib geolocation API after r243285.
2655
2656         gelocation -> geolocation.
2657
2658         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2659         (testGeolocationManagerWatchPosition):
2660
2661 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2662
2663         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2664         https://bugs.webkit.org/show_bug.cgi?id=196213
2665
2666         Reviewed by Geoff Garen.
2667
2668         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2669         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2670         (credentialWithIdentityAndKeychainPath):
2671         (-[ChallengeDelegate webView:didFinishNavigation:]):
2672         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2673         (TestWebKitAPI::TEST):
2674
2675 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2676
2677         Expected shouldn't assume its contained types are copyable
2678         https://bugs.webkit.org/show_bug.cgi?id=195986
2679
2680         Reviewed by JF Bastien.
2681
2682         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2683         (TestWebKitAPI::NonCopyable::operator== const):
2684         (TestWebKitAPI::NonCopyable::operator!= const):
2685         (TestWebKitAPI::TEST):
2686
2687 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2688
2689         Remove some now-unnecessary dynamic class lookup
2690         https://bugs.webkit.org/show_bug.cgi?id=196237
2691
2692         Reviewed by Simon Fraser.
2693
2694         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2695         (makeRequest):
2696         (TEST):
2697
2698 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2699
2700         Unreviewed, rolling out r243450.
2701
2702         AppleWin and WinCairo port builds get broken.
2703
2704         Reverted changeset:
2705
2706         "Add test for fix of #196095"
2707         https://bugs.webkit.org/show_bug.cgi?id=196097
2708         https://trac.webkit.org/changeset/243450
2709
2710 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2711
2712         Unreviewed, rolling out r243465.
2713         https://bugs.webkit.org/show_bug.cgi?id=196226
2714
2715         the test doesn't build (Requested by thorton on #webkit).
2716
2717         Reverted changeset:
2718
2719         "Do not terminate the NetworkProcess if a third party
2720         application sends a NSCredential with a SecIdentityRef"
2721         https://bugs.webkit.org/show_bug.cgi?id=196213
2722         https://trac.webkit.org/changeset/243465
2723
2724 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2725
2726         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2727         https://bugs.webkit.org/show_bug.cgi?id=196213
2728
2729         Reviewed by Geoff Garen.
2730
2731         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2732         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2733         (credentialWithIdentityAndKeychainPath):
2734         (-[ChallengeDelegate webView:didFinishNavigation:]):
2735         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2736         (TestWebKitAPI::TEST):
2737
2738 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2739
2740         [ews-build] Gracefully handle missing patch_id in events
2741         https://bugs.webkit.org/show_bug.cgi?id=196216
2742
2743         Reviewed by Lucas Forschler.
2744
2745         * BuildSlaveSupport/ews-build/events.py:
2746
2747 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2748
2749         [ews-build] use lz4 compression for improving buildbot performance
2750         https://bugs.webkit.org/show_bug.cgi?id=196155
2751
2752         Reviewed by Lucas Forschler.
2753
2754         * BuildSlaveSupport/ews-build/master.cfg:
2755
2756 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2757
2758         Pull some API testing helper methods out of TestWKWebView
2759         https://bugs.webkit.org/show_bug.cgi?id=196212
2760
2761         Reviewed by Tim Horton.
2762
2763         Refactor some more API testing utility methods, so that they can be used in
2764         tests that do not use TestWKWebView.
2765
2766         * TestWebKitAPI/cocoa/TestWKWebView.h:
2767         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2768         (-[WKWebView loadTestPageNamed:]):
2769         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2770         (-[WKWebView synchronouslyLoadHTMLString:]):
2771         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2772         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2773         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2774         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2775         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2776
2777 2019-03-25  Jer Noble  <jer.noble@apple.com>
2778
2779         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2780         https://bugs.webkit.org/show_bug.cgi?id=196097
2781
2782         Reviewed by Eric Carlson.
2783
2784         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2785
2786         * DumpRenderTree/mac/DumpRenderTree.mm:
2787         (resetWebPreferencesToConsistentValues):
2788         * WebKitTestRunner/TestController.cpp:
2789         (WTR::TestController::resetPreferencesToConsistentValues):
2790
2791 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2792
2793         Pull IPadUserInterfaceSwizzler out into a separate header file
2794         https://bugs.webkit.org/show_bug.cgi?id=196193
2795
2796         Reviewed by Anders Carlsson.
2797
2798         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2799         be used in other API tests.
2800
2801         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2802         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2803         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2804         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2805         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2806         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2807         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2808
2809 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2810
2811         Remove NavigatorContentUtils in WebCore/Modules
2812         https://bugs.webkit.org/show_bug.cgi?id=196070
2813
2814         Reviewed by Alex Christensen.
2815
2816         NavigatorContentUtils was to support the custom scheme spec [1].
2817         However, in WebKit side, no port has supported the feature in
2818         WebKit layer after EFL port was removed. So there has been the
2819         only IDL implementation of the NavigatorContentUtils in WebCore.
2820         So we don't need to keep the implementation in WebCore anymore.
2821
2822         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2823
2824         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2825
2826 2019-03-24  Andy Estes  <aestes@apple.com>
2827
2828         [watchOS] Remove unused Proximity Networking code
2829         https://bugs.webkit.org/show_bug.cgi?id=196188
2830
2831         Reviewed by Tim Horton.
2832
2833         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2834         (TEST):
2835
2836 2019-03-23  Keith Miller  <keith_miller@apple.com>
2837
2838         Refactor clz/ctz and fix getLSBSet.
2839         https://bugs.webkit.org/show_bug.cgi?id=196162
2840
2841         Reviewed by Saam Barati.
2842
2843         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2844
2845         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2846         (TestWebKitAPI::TEST):
2847
2848 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2849
2850         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2851         https://bugs.webkit.org/show_bug.cgi?id=196143
2852
2853         Reviewed by Michael Catanzaro.
2854
2855         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2856         directories.
2857
2858         * Scripts/webkitpy/style/checkers/cpp.py:
2859         (check_identifier_name_in_declaration):
2860         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2861         (WebKitStyleTest.test_names):
2862
2863 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2864
2865         [Flatpak] Manifest expanding fails for qt WPE extension
2866         https://bugs.webkit.org/show_bug.cgi?id=196148
2867
2868         Reviewed by Alex Christensen.
2869
2870         * flatpak/flatpakutils.py:
2871         (expand_submodules_recurse): The last recurse manifest expand
2872         iteration might lead to a single module so take it into account
2873         and don't try to recurse further.
2874
2875 2019-03-22  Chris Dumez  <cdumez@apple.com>
2876
2877         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2878         https://bugs.webkit.org/show_bug.cgi?id=195348
2879         <rdar://problem/48622090>
2880
2881         Reviewed by Alex Christensen.
2882
2883         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2884         to NO when test.options().shouldIgnoreMetaViewport is false.
2885
2886         * WebKitTestRunner/ios/TestControllerIOS.mm:
2887         (WTR::TestController::platformConfigureViewForTest):
2888
2889 2019-03-22  Chris Dumez  <cdumez@apple.com>
2890
2891         Prewarmed processes should be usable with any website data store
2892         https://bugs.webkit.org/show_bug.cgi?id=196104
2893
2894         Reviewed by Alex Christensen.
2895
2896         Add API test coverage.
2897
2898         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2899         (runInitialWarmedProcessUsedTest):
2900         (TEST):
2901
2902 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2903
2904         Back out local changes to Alex's Subversion working directory
2905
2906         They were accidentally committed.
2907
2908         * Scripts/webkitpy/common/system/abstractexecutive.py:
2909         (AbstractExecutive.wait_newest):
2910         * Scripts/webkitpy/common/system/executive.py:
2911         (Executive.running_pids):
2912         * Scripts/webkitpy/common/system/executive_mock.py:
2913         (MockExecutive.running_pids):
2914         * Scripts/webkitpy/common/system/executive_unittest.py:
2915         (ExecutiveTest.serial_test_running_pids):
2916         * Scripts/webkitpy/port/darwin.py:
2917         (DarwinPort.check_for_leaks):
2918         * Scripts/webkitpy/port/leakdetector.py:
2919         (LeakDetector.check_for_leaks):
2920         - This was the hack attached to Bug 193772.
2921
2922         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2923         (+[WebKitTestRunnerEvent mouseLocation]):
2924         - This works around a crash on an internal build.
2925
2926 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2927
2928         Fix the build after r243354
2929         https://bugs.webkit.org/show_bug.cgi?id=196138
2930         <rdar://problem/49145951>
2931
2932         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2933         (TEST):
2934         * TestWebKitAPI/ios/UIKitSPI.h:
2935
2936 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2937
2938         Adopt UIWKDocumentContext
2939         https://bugs.webkit.org/show_bug.cgi?id=196040
2940         <rdar://problem/48642440>
2941
2942         Reviewed by Ryosuke Niwa.
2943
2944         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2945         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2946         (makeRequest):
2947         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2948         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2949         (applyStyle):
2950         (TEST):
2951         Add tests for UIWKDocumentContext.
2952
2953         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2954         (TEST):
2955         (recursiveFindWKContentView): Deleted.
2956         * TestWebKitAPI/cocoa/TestWKWebView.h:
2957         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2958         (recursiveFindWKContentView):
2959         (-[TestWKWebView wkContentView]):
2960         * TestWebKitAPI/ios/UIKitSPI.h:
2961         Share the WKContentView finding code between tests.
2962
2963 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2964
2965         [iOS WK2] Turn on async overflow scrolling by default
2966         https://bugs.webkit.org/show_bug.cgi?id=196011
2967         rdar://problem/48453859
2968
2969         Reviewed by Antti Koivisto.
2970         
2971         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2972         since so many basic layout tests have different results when compositing is triggered for
2973         overflow.
2974         
2975         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2976
2977         * WebKitTestRunner/TestController.cpp:
2978         (WTR::TestController::resetPreferencesToConsistentValues):
2979
2980 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2981
2982         [ews-build] Retry API test in case of failures
2983         https://bugs.webkit.org/show_bug.cgi?id=196004
2984
2985         Reviewed by Lucas Forschler.
2986
2987         * BuildSlaveSupport/ews-build/steps.py:
2988         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2989         (CompileWebKitToT.doStepIf): Ditto.
2990         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2991         (ReRunAPITests): Re-run API tests.
2992         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2993         (RunAPITestsWithoutPatch): Run API tests without patch.
2994         (RunAPITestsWithoutPatch.doStepIf):
2995         (RunAPITestsWithoutPatch.hideStepIf):
2996         (RunAPITestsWithoutPatch.evaluateCommand):
2997         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2998         (AnalyzeAPITestsResults.start):
2999         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3000         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3001         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3002         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3003
3004 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3005
3006         [ews-build] Update queues configurations
3007         https://bugs.webkit.org/show_bug.cgi?id=196074
3008
3009         Reviewed by Dewei Zhu.
3010
3011         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3012         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3013
3014 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3015
3016         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3017         https://bugs.webkit.org/show_bug.cgi?id=195680
3018         <rdar://problem/48903534>
3019
3020         Unreviewed infrastructure fix.
3021
3022         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3023         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3024
3025 2019-03-21  Andy Estes  <aestes@apple.com>
3026
3027         [iOS] Apple Pay should be available in documents with no user agent scripts
3028         https://bugs.webkit.org/show_bug.cgi?id=196061
3029         <rdar://problem/48649391>
3030
3031         Reviewed by Brady Eidson.
3032
3033         Added API tests and related infrastructure.
3034
3035         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3036         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3037         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3038         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3039         (TestWebKitAPI::TEST):
3040         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3041         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3042         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3043         * TestWebKitAPI/cocoa/TestProtocol.mm:
3044         (-[TestProtocol startLoading]):
3045         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3046         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3047         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3048         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3049
3050 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3051
3052         REGRESSSION (r243297): webkitpy tests broken
3053         https://bugs.webkit.org/show_bug.cgi?id=196108
3054
3055         Reviewed by Aakash Jain.
3056
3057         r243297 updated contributors.json, which broke a few unit tests.
3058
3059         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3060         (IRCCommandTest.test_whois):
3061         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3062
3063 2019-03-21  Chris Dumez  <cdumez@apple.com>
3064
3065         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3066         https://bugs.webkit.org/show_bug.cgi?id=196041
3067         <rdar://problem/49083230>
3068
3069         Reviewed by Alex Christensen.
3070
3071         Add API test coverage.
3072
3073         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3074         (TEST):
3075
3076 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3077
3078         Add SPI to inform applications of WKContentRuleList actions
3079         https://bugs.webkit.org/show_bug.cgi?id=195965
3080         <rdar://problem/42664365>
3081
3082         Reviewed by Geoff Garen.
3083
3084         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3085         (TestWebKitAPI::allActionsForResourceLoad):
3086         (TestWebKitAPI::testRequest):
3087         (TestWebKitAPI::TEST_F):
3088         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3089         (Notification::description):
3090         (Notification::operator== const):
3091         (toVector):
3092         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3093         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3094         (makeContentRuleList):
3095         (TEST):
3096         (makeWarnContentRuleList): Deleted.
3097
3098 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3099
3100         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3101         https://bugs.webkit.org/show_bug.cgi?id=196088
3102
3103         Reviewed by Brian Burg.
3104
3105         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3106         Support checks when only one platform is specified. Also deprecate macosx() and
3107         force the use of macos() instead.
3108
3109         * Scripts/webkitpy/style/checkers/cpp.py:
3110         (check_min_versions_of_wk_api_available):
3111         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3112         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3113
3114 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3115
3116         Update status inactive committers' status to 'contributor'.
3117
3118         * Scripts/webkitpy/common/config/contributors.json:
3119
3120 2019-03-21  Xan Lopez  <xan@igalia.com>
3121
3122         [JSC][x86] Drop support for x87 floating point
3123         https://bugs.webkit.org/show_bug.cgi?id=194853
3124
3125         Reviewed by Don Olmstead.
3126
3127         Force SSE2 on x86/32bit builds.
3128
3129         * Scripts/webkitdirs.pm:
3130         (generateBuildSystemFromCMakeProject):
3131
3132 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3133
3134         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3135         https://bugs.webkit.org/show_bug.cgi?id=196073
3136
3137         Reviewed by Michael Catanzaro.
3138
3139         Add test cases to check functions and constructors with no arguments but receiving user data.
3140
3141         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3142         (checkUserData):
3143         (testJSCFunction):
3144         (fooCreateWithUserData):
3145         (testJSCClass):
3146
3147 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3148
3149         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3150
3151         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3152
3153         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3154
3155 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3156
3157         [GTK][WPE] Add API to provide geolocation information
3158         https://bugs.webkit.org/show_bug.cgi?id=195940
3159
3160         Reviewed by Michael Catanzaro.
3161
3162         Add a new test to check the new API.
3163
3164         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3165         (testGeolocationManagerCurrentPosition):
3166         (testGeolocationManagerWatchPosition):
3167         (beforeAll):
3168         (afterAll):
3169         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3170         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3171         (beforeAll): Ditto.
3172         * TestWebKitAPI/glib/CMakeLists.txt:
3173
3174 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3175
3176         [GLib] Returning G_TYPE_OBJECT from a method does not work
3177         https://bugs.webkit.org/show_bug.cgi?id=195574
3178
3179         Reviewed by Michael Catanzaro.
3180
3181         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3182
3183         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3184         (getGFile):
3185         (getParent):
3186         (createGString):
3187         (getGString):
3188         (getGStringCopyWillRaise):
3189         (getGStringCopy):
3190         (getGStringStr):
3191         (getGStringLen):
3192         (freeGString):
3193         (testJSCClass):
3194
3195 2019-03-20  Saam Barati  <sbarati@apple.com>
3196
3197         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3198         https://bugs.webkit.org/show_bug.cgi?id=195721
3199
3200         Reviewed by Filip Pizlo.
3201
3202         * Scripts/run-javascriptcore-tests:
3203
3204 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3205
3206         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3207         https://bugs.webkit.org/show_bug.cgi?id=196049
3208
3209         Reviewed by Tim Horton.
3210
3211         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3212         overflow scrolling in general, so rename it.
3213
3214         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3215
3216 2019-03-20  Daniel Bates  <dabates@apple.com>
3217
3218         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3219         https://bugs.webkit.org/show_bug.cgi?id=196031
3220         <rdar://problem/49078172>
3221
3222         Reviewed by Tim Horton.
3223
3224         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3225         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3226         same code path used when the Done button is pressed to dismiss the <select> picker.
3227
3228         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3229         (TestWebKitAPI::TEST):
3230
3231 2019-03-20  Chris Dumez  <cdumez@apple.com>
3232
3233         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3234         https://bugs.webkit.org/show_bug.cgi?id=196029
3235         <rdar://problem/48954651>
3236
3237         Reviewed by Tim Horton.
3238
3239         Add API test coverage.
3240
3241         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3242
3243 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3244
3245         [ews-build] Improve failure summary string for ApplyPatch step
3246         https://bugs.webkit.org/show_bug.cgi?id=195995
3247
3248         Reviewed by Alexey Proskuryakov.
3249
3250         * BuildSlaveSupport/ews-build/steps.py:
3251         (ApplyPatch.getResultSummary): Override getResultSummary.
3252
3253 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3254
3255         AX: Implement support for new meter ARIA role
3256         https://bugs.webkit.org/show_bug.cgi?id=195966
3257
3258         Reviewed by Chris Fleizach.
3259
3260         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3261         to AXLevelIndicator.
3262
3263         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3264
3265 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3266
3267         [WebAuthN] Implement FIDO AppID extension
3268         https://bugs.webkit.org/show_bug.cgi?id=143491
3269         <rdar://problem/48298273>
3270
3271         Reviewed by Brent Fulgham.
3272
3273         Add a test that covers the new flag of convertToU2fSignCommand.
3274
3275         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3276         (TestWebKitAPI::TEST):
3277         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3278         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3279         (TestWebKitAPI::TEST):
3280
3281 2019-03-19  Keith Rollin  <krollin@apple.com>
3282
3283         Add support for more platforms to generate-xcfilelists
3284         https://bugs.webkit.org/show_bug.cgi?id=195977
3285
3286         Reviewed by Alexey Proskuryakov.
3287
3288         generate-xcfilelists incorrectly complains when involved with building
3289         WebKit for iphonesimulator:
3290
3291             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3292             …
3293             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3294
3295         Address this by teaching generate-xcfilelists about more platforms.
3296
3297         * Scripts/generate-xcfilelists:
3298
3299 2019-03-19  John Wilander  <wilander@apple.com>
3300
3301         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3302         https://bugs.webkit.org/show_bug.cgi?id=195923
3303         <rdar://problem/49001272>
3304
3305         Reviewed by Alex Christensen.
3306
3307         This patch does the following to the TestRunner:
3308         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3309         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3310         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3311
3312         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3313         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3314         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3315         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3316         * WebKitTestRunner/TestController.cpp:
3317         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3318         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3319         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3320         * WebKitTestRunner/TestController.h:
3321         * WebKitTestRunner/TestInvocation.cpp:
3322         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3323
3324 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3325
3326         [CMake] Support more clang and gcc sanitizers
3327         https://bugs.webkit.org/show_bug.cgi?id=195956
3328
3329         Reviewed by Michael Catanzaro.
3330
3331         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3332
3333 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3334
3335         [ews-build] Improve summary for PrintConfiguration step
3336         https://bugs.webkit.org/show_bug.cgi?id=195945
3337
3338         Reviewed by Lucas Forschler.
3339
3340         * BuildSlaveSupport/ews-build/steps.py:
3341         (PrintConfiguration.getResultSummary): Override getResultSummary.
3342
3343 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3344
3345         [ews-build] Improve summary for CheckOutSource step
3346         https://bugs.webkit.org/show_bug.cgi?id=195963
3347
3348         Reviewed by Lucas Forschler.
3349
3350         * BuildSlaveSupport/ews-build/steps.py:
3351         (CheckOutSource.getResultSummary):
3352
3353 2019-03-19  Daniel Bates  <dabates@apple.com>
3354
3355         [iOS] Focus not preserved when switching between tabs
3356         https://bugs.webkit.org/show_bug.cgi?id=195820
3357         <rdar://problem/43614450>
3358
3359         Reviewed by Brent Fulgham.
3360
3361         Add tests to ensure that we restore focus when resigning and becoming first responder.
3362
3363         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3364         (TestWebKitAPI::TEST):
3365
3366 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3367
3368         Make WTFLogChannelState and WTFLogLevel enum classes
3369         https://bugs.webkit.org/show_bug.cgi?id=195904
3370
3371         Reviewed by Eric Carlson.
3372
3373         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3374         (TestWebKitAPI::TEST_F):
3375
3376 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3377
3378         [GStreamer][EME] Backported mssdemux protection data crash fix
3379         https://bugs.webkit.org/show_bug.cgi?id=195918
3380
3381         Reviewed by Philippe Normand.
3382
3383         * gstreamer/jhbuild.modules:
3384         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3385
3386 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3387
3388         Unreviewed, rolling out r243132.
3389
3390         Broke GTK build
3391
3392         Reverted changeset:
3393
3394         "Make WTFLogChannelState and WTFLogLevel enum classes"
3395         https://bugs.webkit.org/show_bug.cgi?id=195904
3396         https://trac.webkit.org/changeset/243132
3397
3398 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3399
3400         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3401
3402         * Scripts/webkitdirs.pm:
3403         (builtDylibPathForName): Adjust the shared library name that's changed
3404         with the API version bump in r243073.
3405
3406 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3407
3408         Make WTFLogChannelState and WTFLogLevel enum classes
3409         https://bugs.webkit.org/show_bug.cgi?id=195904
3410
3411         Reviewed by Eric Carlson.
3412
3413         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3414         (TestWebKitAPI::TEST_F):
3415
3416 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3417
3418         Disable flaky test added in r2431100
3419         https://webkit.org/b/195785
3420
3421         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3422         (TestWebKitAPI::TEST):
3423         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3424
3425 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3426
3427         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3428         https://bugs.webkit.org/show_bug.cgi?id=195916
3429
3430         Reviewed by Tim Horton.
3431
3432         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3433         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3434
3435 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3436
3437         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3438
3439         * Scripts/webkitpy/common/config/contributors.json:
3440
3441 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3442
3443         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3444         https://bugs.webkit.org/show_bug.cgi?id=195785
3445
3446         Reviewed by Geoffrey Garen.
3447
3448         * TestWebKitAPI/TCPServer.cpp: Added.
3449         (TestWebKitAPI::TCPServer::TCPServer):
3450         (TestWebKitAPI::TCPServer::~TCPServer):
3451         (TestWebKitAPI::TCPServer::socketBindListen):
3452         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3453         * TestWebKitAPI/TCPServer.h: Added.
3454         (TestWebKitAPI::TCPServer::port const):
3455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3456         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3457         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3458         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3459         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3460         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3461         (TestWebKitAPI::respondSlowly):
3462         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3463         (TestWebKitAPI::downloadAtRate):
3464         (TestWebKitAPI::TEST):
3465
3466 2019-03-18  Saam Barati  <sbarati@apple.com>
3467
3468         Add a plan file for JetStream 2
3469         https://bugs.webkit.org/show_bug.cgi?id=190734
3470
3471         Reviewed by Mark Lam.
3472
3473         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3474
3475 2019-03-18  Chris Dumez  <cdumez@apple.com>
3476
3477         Delay WebProcess launch until a load is triggered in a Web view
3478         https://bugs.webkit.org/show_bug.cgi?id=195758
3479         <rdar://problem/48126013>
3480
3481         Reviewed by Geoff Garen.
3482
3483         Add API test coverage. Also update some existing API tests to not expect
3484         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3485
3486         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3487         (TestWebKitAPI::TEST):
3488         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3489         (TestWebKitAPI::TEST):
3490         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3491         (TEST):
3492         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3493         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3494         (TEST):
3495         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3496         (TEST):
3497         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3498
3499 2019-03-18  Xan Lopez  <xan@igalia.com>
3500
3501         [CMake] Prevent potential warning when determining $architecture
3502         https://bugs.webkit.org/show_bug.cgi?id=195891
3503
3504         Reviewed by Michael Catanzaro.
3505
3506         It's possible for generateBuildSystemForCMakeProject to be called
3507         before determineArchitecture() is ever called. This will make the
3508         first eq check with $architecture to be bogus (and print a
3509         warning). Change that to an eq check with architecture(), which
3510         implicitly calls determineArchitecture() if needed, and change all
3511         the other similar cases in the method in the same way to prevent
3512         future bugs like this one.
3513
3514         * Scripts/webkitdirs.pm:
3515         (generateBuildSystemFromCMakeProject):
3516
3517 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3518
3519         [WPE] Tarballs generated with “make dist” cannot build documentation
3520         https://bugs.webkit.org/show_bug.cgi?id=195885
3521
3522         Reviewed by Carlos Garcia Campos.
3523
3524         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3525
3526 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3527
3528         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3529         https://bugs.webkit.org/show_bug.cgi?id=195883
3530
3531         Reviewed by Carlos Garcia Campos.
3532
3533         * gtkdoc/gtkdoc.py:
3534         (GTKDoc._run_command): When commands fail to run, include the full command line for
3535         the program invocation and the output it has generated on the standard error stream.
3536
3537 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3538
3539         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3540         https://bugs.webkit.org/show_bug.cgi?id=195786
3541
3542         Reviewed by Philippe Normand.
3543
3544         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3545         * wpe/jhbuild.modules: Ditto.
3546
3547 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3548
3549         [ews-build] Don't run clean builds on EWS builders
3550         https://bugs.webkit.org/show_bug.cgi?id=195851
3551
3552         Reviewed by Geoffrey Garen.
3553
3554         * BuildSlaveSupport/ews-build/factories.py:
3555
3556 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3557
3558         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3559         https://bugs.webkit.org/show_bug.cgi?id=195849
3560
3561         Reviewed by Chris Dumez.
3562
3563         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3564
3565         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3566         (runWebsiteDataStoreCustomPaths):
3567
3568 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3569
3570         webkitpy: Upload test results
3571         https://bugs.webkit.org/show_bug.cgi?id=195755
3572         <rdar://problem/48896182>
3573
3574         Reviewed by Aakash Jain.
3575
3576         Establish a new format for uploading results that is not tied to layout tests, apply
3577         that format to webkitpy tests.
3578
3579         * Scripts/webkitpy/common/checkout/scm/git.py:
3580         (Git.native_branch): Return what branch the current checkout is on.
3581         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3582         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3583         * Scripts/webkitpy/common/checkout/scm/svn.py:
3584         (SVN.native_branch): Ditto.
3585         * Scripts/webkitpy/common/system/platforminfo.py:
3586         (PlatformInfo.build_version): Return a build version for Mac.
3587         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3588         (MockPlatformInfo.__init__):
3589         (MockPlatformInfo.build_version):
3590         * Scripts/webkitpy/results: Added.
3591         * Scripts/webkitpy/results/__init__.py: Added.
3592         * Scripts/webkitpy/results/options.py: Added.
3593         (upload_options): OptParse list for upload options.
3594         * Scripts/webkitpy/results/upload.py: Added.
3595         (Upload): Class which enforces the upload format expected by the results server.
3596         (Upload.Expectations):
3597         (Upload.create_configuration):
3598         (Upload.create_commit):
3599         (Upload.create_details):
3600         (Upload.create_run_stats):
3601         (Upload.create_test_result):
3602         (Upload.__init__):
3603         (Upload.Encoder): Encode Upload object as json.
3604         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3605         * Scripts/webkitpy/results/upload_unittest.py: Added.
3606         * Scripts/webkitpy/test/main.py:
3607         (Tester._parse_args): Add upload arguments.
3608         (Tester._run_tests): Allow results to be uploaded.
3609         * Scripts/webkitpy/test/runner.py:
3610         (Runner.__init__): Record which tests were run, rather than just counting them.
3611         (Runner.handle):
3612         * Scripts/webkitpy/test/runner_unittest.py:
3613         (RunnerTest.test_run):
3614         * Scripts/webkitpy/thirdparty/__init__.py:
3615         (AutoinstallImportHook.find_module): Add requests auto-install.
3616         (AutoinstallImportHook._install_requests):
3617         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3618         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3619
3620 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3621
3622         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3623         https://bugs.webkit.org/show_bug.cgi?id=195810
3624
3625         Reviewed by Tim Horton.
3626
3627         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3628         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3629         ending certain layout tests.
3630
3631         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3632         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3633         (-[TestRunnerWKWebView dealloc]):
3634         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3635
3636         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3637         helper method when destroying the web view, and when resetting state between tests.
3638
3639         * WebKitTestRunner/ios/TestControllerIOS.mm:
3640         (WTR::TestController::platformResetStateToConsistentValues):
3641
3642         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3643
3644 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3645
3646         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3647         https://bugs.webkit.org/show_bug.cgi?id=190350
3648         <rdar://problem/45089503>
3649
3650         Reviewed by Geoffrey Garen.
3651
3652         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3653         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3654         (TEST):
3655         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3656         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3657         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3658         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3659         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3660         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3661         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3662         (runTest):
3663         (createDirectories):
3664         (TEST):
3665         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3666         (TEST):
3667         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3668         (TEST):
3669
3670 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3671
3672         Add support to WebPage for getting the contents as an attributed string.
3673         https://bugs.webkit.org/show_bug.cgi?id=195636
3674         rdar://problem/45055697
3675
3676         Reviewed by Tim Horton.
3677
3678         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3679         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3680
3681 2019-03-15  Chris Dumez  <cdumez@apple.com>
3682
3683         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3684         https://bugs.webkit.org/show_bug.cgi?id=195747
3685
3686         Reviewed by Geoff Garen.
3687
3688         Add API test coverage.
3689
3690         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3691
3692 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3693
3694         Unreviewed, rolling out r242952.
3695
3696         Causing API failures on iOS Simulator
3697
3698         Reverted changeset:
3699
3700         "[PSON] Make sure the WebProcessCache is leverage when
3701         relaunching a process after termination"
3702         https://bugs.webkit.org/show_bug.cgi?id=195747
3703         https://trac.webkit.org/changeset/242952
3704
3705 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3706
3707         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3708         https://bugs.webkit.org/show_bug.cgi?id=195740
3709
3710         Reviewed by Ross Kirsling.
3711
3712         window.open doesn't work for WebKitBrowserWindow because it is not
3713         implemented yet.
3714
3715         1. Implemented createNewPage callback of WKPageUIClient.
3716         2. Changed MainWindow to take a BrowserWindow factory function
3717           instead of BrowserWindowType to be flexible to create
3718           BrowserWindow with extra settings.
3719         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3720           because it is not relevant with MainWindow anymore.
3721
3722         * MiniBrowser/win/Common.cpp:
3723         (parseCommandLine):
3724         * MiniBrowser/win/Common.h:
3725         (CommandLineOptions::CommandLineOptions):
3726         * MiniBrowser/win/MainWindow.cpp:
3727         (MainWindow::MainWindow):
3728         (MainWindow::create):
3729         (MainWindow::init):
3730         (MainWindow::WndProc):
3731         * MiniBrowser/win/MainWindow.h:
3732         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3733         (PrintWebUIDelegate::createWebViewWithRequest):
3734         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3735         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3736         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3737         (WebKitBrowserWindow::updateProxySettings):
3738         (WebKitBrowserWindow::createNewPage):
3739         * MiniBrowser/win/WebKitBrowserWindow.h:
3740         * MiniBrowser/win/WinMain.cpp:
3741         (wWinMain):
3742
3743 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3744
3745         Make it possible to test scrolling tree layer manipulation more easily
3746         https://bugs.webkit.org/show_bug.cgi?id=195780
3747
3748         Reviewed by Tim Horton.
3749         
3750         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3751         cuts off communication of scrolling tree scrolls back to the web process
3752         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3753         allows tests to trigger scrolls which run the scrolling tree layer positioning
3754         logic, but never get another commit from the web process that might mask
3755         scrolling tree bugs.
3756         
3757         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3758         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3759         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3760
3761         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3762         (WTR::UIScriptController::scrollUpdatesDisabled const):
3763         (WTR::UIScriptController::setScrollUpdatesDisabled):
3764         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3765         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3766         (WTR::UIScriptController::scrollUpdatesDisabled const):
3767         (WTR::UIScriptController::setScrollUpdatesDisabled):
3768         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3769         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3770         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3771         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3772         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3773         * WebKitTestRunner/ios/TestControllerIOS.mm:
3774         (WTR::TestController::platformResetStateToConsistentValues):
3775         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3776         (WTR::UIScriptController::scrollUpdatesDisabled const):
3777         (WTR::UIScriptController::setScrollUpdatesDisabled):
3778
3779 2019-03-14  Youenn Fablet  <youenn@apple.com>
3780
3781         Move IDB storage in private browsing mode to NetworkProcess
3782         https://bugs.webkit.org/show_bug.cgi?id=195602
3783
3784         Reviewed by Brady Eidson.
3785
3786         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3787         (TEST):
3788
3789 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3790
3791         [ews-build] Make descriptionDone messages more readable
3792         https://bugs.webkit.org/show_bug.cgi?id=195760
3793
3794         Reviewed by Lucas Forschler.
3795
3796         * BuildSlaveSupport/ews-build/steps.py:
3797         * BuildSlaveSupport/ews-build/steps_unittest.py:
3798
3799 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3800
3801         [ews-build] Generate status-bubble hover-over messages
3802         https://bugs.webkit.org/show_bug.cgi?id=195680
3803
3804         Reviewed by Lucas Forschler.
3805
3806         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3807         (StatusBubble):
3808         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3809         on hover-over.
3810         (StatusBubble._iso_time):
3811         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3812         hover-over message.
3813         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3814
3815 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3816
3817         [ews-app] Gracefully handle the case when state_string is None
3818         https://bugs.webkit.org/show_bug.cgi?id=195753
3819
3820         Reviewed by Lucas Forschler.
3821
3822         * BuildSlaveSupport/ews-app/ews/models/build.py:
3823         * BuildSlaveSupport/ews-app/ews/models/step.py:
3824
3825 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3826
3827         [ews-app] Status bubble display pending for currently running build step
3828         https://bugs.webkit.org/show_bug.cgi?id=195744
3829
3830         Reviewed by Lucas Forschler.
3831
3832         * BuildSlaveSupport/ews-build/events.py:
3833         (Events.stepStarted): If state_string is pending, replace it with step name.
3834
3835 2019-03-14  Chris Dumez  <cdumez@apple.com>
3836
3837         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3838         https://bugs.webkit.org/show_bug.cgi?id=195750
3839
3840         Reviewed by Geoffrey Garen.
3841
3842         Add API test coverage.
3843
3844         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3845         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3846         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3847         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3848
3849 2019-03-14  Chris Dumez  <cdumez@apple.com>
3850
3851         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3852         https://bugs.webkit.org/show_bug.cgi?id=195747
3853
3854         Reviewed by Geoff Garen.
3855
3856         Add API test coverage.
3857
3858         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3859
3860 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3861
3862         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3863         https://bugs.webkit.org/show_bug.cgi?id=195725
3864         <rdar://problem/48545062>
3865
3866         Reviewed by Tim Horton.
3867
3868         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3869         handler is nil.
3870
3871         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3872         (TestWebKitAPI::TEST):
3873
3874 2019-03-13  Sam Weinig  <sam@webkit.org>
3875
3876         Add utility function to allow easy reverse range-based iteration of a container
3877         https://bugs.webkit.org/show_bug.cgi?id=195542
3878
3879         Reviewed by Antti Koivisto.
3880
3881         * TestWebKitAPI/CMakeLists.txt:
3882         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3883         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3884         (TestWebKitAPI::TEST):
3885         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3886
3887 2019-03-13  Chris Dumez  <cdumez@apple.com>
3888
3889         Use a ServiceWorker process per registrable domain
3890         https://bugs.webkit.org/show_bug.cgi?id=195649
3891
3892         Reviewed by Youenn Fablet.
3893
3894         Update API test coverage.
3895
3896         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3897
3898 2019-03-13  Chris Dumez  <cdumez@apple.com>
3899
3900         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3901         https://bugs.webkit.org/show_bug.cgi?id=195684
3902         <rdar://problem/48294714>
3903
3904         Reviewed by Antti Koivisto.
3905
3906         Add API test coverage.
3907
3908         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3909
3910 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3911
3912         [ews-app] Remove unused patch view
3913         https://bugs.webkit.org/show_bug.cgi?id=195669
3914
3915         Reviewed by Lucas Forschler.
3916
3917         * BuildSlaveSupport/ews-app/ews/urls.py:
3918         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3919
3920 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3921
3922         [ews-app] Use Buildbot result code variables
3923         https://bugs.webkit.org/show_bug.cgi?id=195668
3924
3925         Reviewed by Alexey Proskuryakov.
3926
3927         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3928         (Buildbot): Added Buildbot result code variables.
3929         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3930         (StatusBubble._build_bubble): Used Buildbot result code variables.
3931
3932 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3933
3934         [Flatpak] Expand submodule recursively
3935         https://bugs.webkit.org/show_bug.cgi?id=195672
3936
3937         Building WPE with flatpak was impossible without that as it was raising an exception.
3938         Also update wpebackend-fdo to match what is built in jhbuild
3939
3940         Reviewed by Philippe Normand.
3941
3942         * flatpak/flatpakutils.py:
3943         (expand_submodules_recurse):
3944         (expand_manifest):
3945         * flatpak/org.webkit.WPEModules.yaml:
3946
3947 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3948
3949         [ews-app] status bubble should be hidden for certain builds
3950         https://bugs.webkit.org/show_bug.cgi?id=194597
3951
3952         Reviewed by Dewei Zhu.
3953
3954         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3955         (StatusBubble._build_bubble):
3956         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3957         because the patch didn't have relevant changes.
3958         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3959         in production yet.
3960
3961 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3962
3963         [Win] Fix a slew of simple clang-cl warnings.
3964         https://bugs.webkit.org/show_bug.cgi?id=195652
3965
3966         Reviewed by Don Olmstead.
3967
3968         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3969         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3970
3971 2019-03-12  Justin Fan  <justin_fan@apple.com>
3972
3973         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3974         https://bugs.webkit.org/show_bug.cgi?id=195518
3975         <rdar://problem/46322356>
3976
3977         Reviewed by Myles C. Maxfield.
3978
3979         * DumpRenderTree/DerivedSources-input.xcfilelist:
3980         * DumpRenderTree/DerivedSources-output.xcfilelist:
3981
3982 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3983
3984         Unreviewed, rolling out r242825.
3985         https://bugs.webkit.org/show_bug.cgi?id=195648
3986
3987         "Broke webkitpy tests with my change to
3988         lldb_dump_class_layout.py" (Requested by rmorisset on
3989         #webkit).
3990
3991         Reverted changeset:
3992
3993         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3994         classes with suspicious padding"
3995         https://bugs.webkit.org/show_bug.cgi?id=195573
3996         https://trac.webkit.org/changeset/242825
3997
3998 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3999
4000         [ews-build] Show status bubbles while the patch is waiting in queue
4001         https://bugs.webkit.org/show_bug.cgi?id=195618
4002
4003         Reviewed by Lucas Forschler.
4004
4005         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4006         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
4007         enabled in initial deployment.
4008         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
4009         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
4010         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
4011         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
4012         (StatusBubble._build_bubbles_for_patch):
4013
4014 2019-03-12  Robin Morisset  <rmorisset@apple.com>
4015
4016         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
4017         https://bugs.webkit.org/show_bug.cgi?id=195573
4018
4019         Reviewed by Simon Fraser.
4020
4021         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
4022
4023         * Scripts/dump-class-layout:
4024         (main):
4025         * lldb/lldb_dump_class_layout.py:
4026         (ClassLayout.__init__):
4027         (ClassLayout._compute_padding_recursive):
4028         (LLDBDebuggerInstance.dump_layout_for_classname):
4029         (LLDBDebuggerInstance):
4030         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
4031         (LLDBDebuggerInstance.layout_for_classname): Deleted.
4032
4033 2019-03-12  Chris Dumez  <cdumez@apple.com>
4034
4035         Device Orientation access permission should be denied unless explicitly granted by the client
4036         https://bugs.webkit.org/show_bug.cgi?id=195625
4037
4038         Reviewed by Youenn Fablet.
4039
4040         add API test coverage.
4041
4042         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4043         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
4044         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
4045         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
4046         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4047         (runDeviceOrientationTest):
4048         (TEST):
4049         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4050         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4051
4052 2019-03-12  Jer Noble  <jer.noble@apple.com>
4053
4054         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
4055         https://bugs.webkit.org/show_bug.cgi?id=195137
4056         <rdar://problem/48810307>
4057
4058         Reviewed by Eric Carlson.
4059
4060         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
4061         (TestWebKitAPI::TEST):
4062
4063 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4064
4065         [ews-build] Change urls from uat to production
4066         https://bugs.webkit.org/show_bug.cgi?id=195566
4067
4068         Reviewed by Lucas Forschler.
4069
4070         * BuildSlaveSupport/ews-app/ews/config.py:
4071         * BuildSlaveSupport/ews-build/events.py:
4072         * BuildSlaveSupport/ews-build/steps.py:
4073
4074 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4075
4076         [ews-build] change max_builds for local-worker to 1
4077         https://bugs.webkit.org/show_bug.cgi?id=195568
4078
4079         Reviewed by Lucas Forschler.
4080
4081         * BuildSlaveSupport/ews-build/loadConfig.py:
4082
4083 2019-03-12  Tim Horton  <timothy_horton@apple.com>
4084
4085         Fix the build
4086
4087         * TestRunnerShared/spi/PencilKitTestSPI.h:
4088         * TestWebKitAPI/ios/PencilKitTestSPI.h:
4089
4090 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
4091
4092         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
4093         https://bugs.webkit.org/show_bug.cgi?id=194131
4094
4095         Reviewed by Michael Catanzaro.
4096
4097         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4098         (uriChanged):
4099         (testUnfinishedSubresourceLoad):
4100         (serverCallback):
4101         (beforeAll):
4102
4103 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4104
4105         WTF::Expected should use std::addressof instead of operator&
4106         https://bugs.webkit.org/show_bug.cgi?id=195604
4107
4108         Reviewed by Myles Maxfield.
4109
4110         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4111         (TestWebKitAPI::Unique::Unique):
4112         (TestWebKitAPI::Unique::operator&):
4113         (TestWebKitAPI::TEST):
4114
4115 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
4116
4117         Add Optional to Forward.h.
4118         https://bugs.webkit.org/show_bug.cgi?id=195586
4119
4120         Reviewed by Darin Adler.
4121
4122         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
4123         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
4124         Remove unnecessary includes from headers.
4125
4126 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
4127
4128         Add testing API to hit-test and scroll overflow scrollers
4129         https://bugs.webkit.org/show_bug.cgi?id=195278
4130
4131         Reviewed by Antti Koivisto.
4132         
4133         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
4134         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
4135         
4136         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
4137
4138         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4139         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4140         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4141         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4142         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4143         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4144         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4145         (WTR::enclosingScrollViewIncludingSelf):
4146         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4147
4148 2019-03-11  Tim Horton  <timothy_horton@apple.com>
4149
4150         API test WebKit.RequestTextInputContext fails on iOS
4151         https://bugs.webkit.org/show_bug.cgi?id=195585
4152
4153         Reviewed by Wenson Hsieh and Simon Fraser.
4154
4155         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4156         (applyStyle):
4157         (TEST):
4158         Add a viewport, so that the coordinates match up on iOS.
4159         Scroll by moving the UIScrollView's contentOffset.
4160
4161 2019-03-11  Chris Dumez  <cdumez@apple.com>
4162
4163         Assert in WebPageProxy::suspendCurrentPageIfPossible()
4164         https://bugs.webkit.org/show_bug.cgi?id=195506
4165         <rdar://problem/48733477>
4166
4167         Reviewed by Alex Christensen.
4168
4169         Add API test coverage.
4170
4171         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4172
4173 2019-03-11  Shawn Roberts  <sroberts@apple.com>
4174
4175         Adding myself to contributors.json
4176
4177         Unreviewed, addming myself to contributors.json .
4178
4179         * Scripts/webkitpy/common/config/contributors.json:
4180
4181 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4182
4183         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
4184         https://bugs.webkit.org/show_bug.cgi?id=195511
4185         <rdar://problem/44873269>
4186
4187         Reviewed by Darin Adler.
4188
4189         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
4190         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
4191         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
4192         (TEST_F):
4193
4194 2019-03-11  Chris Dumez  <cdumez@apple.com>
4195
4196         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
4197         https://bugs.webkit.org/show_bug.cgi?id=195561
4198
4199         Reviewed by Youenn Fablet.
4200
4201         Make sure the JS in the test requests for permission to receive device orientation events.
4202
4203         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4204
4205 2019-03-11  Youenn Fablet  <youenn@apple.com>
4206
4207         Allow storage quota increase by default in WTR
4208         https://bugs.webkit.org/show_bug.cgi?id=195541
4209
4210         Reviewed by Geoffrey Garen.
4211
4212         Allow storage quota increase by default in WTR.
4213         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
4214         Use this for tests that explicitly need cache increase.
4215
4216         Instead of increasing quota by 2, make sure the next request is
4217         granted by adding all given parameters.
4218
4219         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4220         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4221         (WTR::TestRunner::setAllowStorageQuotaIncrease):
4222         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
4223         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4224         * WebKitTestRunner/TestController.cpp:
4225         (WTR::TestController::setAllowStorageQuotaIncrease):
4226         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
4227         * WebKitTestRunner/TestController.h:
4228         * WebKitTestRunner/TestInvocation.cpp:
4229         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4230         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4231         (WTR::TestController::cocoaResetStateToConsistentValues):
4232         (WTR::TestController::setAllowStorageQuotaIncrease):
4233         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
4234         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4235         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4236
4237 2019-03-11  Xan Lopez  <xan@igalia.com>
4238
4239         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
4240         https://bugs.webkit.org/show_bug.cgi?id=194147
4241
4242         Reviewed by Michael Saboff.
4243
4244         To make --32-bit work correctly on Linux/64bit we need to:
4245
4246         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
4247         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
4248         unfortunately CMake only allows us to do this during
4249         crosscompilation, which is overkill here.
4250         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
4251         pkg-config detection module uses the x86 .pc files instead of the
4252         x86_64 ones.
4253         - Set the -m32 flags for the compiler.
4254
4255         * Scripts/webkitdirs.pm:
4256         (generateBuildSystemFromCMakeProject):
4257
4258 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
4259
4260         Add MotionMark-1.1 plan file for run-benchmark script.
4261         https://bugs.webkit.org/show_bug.cgi?id=195481
4262
4263         Rubber-stamped by Darin Adler.
4264
4265         Run-benchmark script should support MontionMark-1.1.
4266
4267         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
4268
4269 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
4270
4271         [ews-app] Add support for submit-to-ews url
4272         https://bugs.webkit.org/show_bug.cgi?id=195477
4273
4274         Reviewed by Lucas Forschler.
4275
4276         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4277         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
4278         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
4279         * BuildSlaveSupport/ews-app/ews/urls.py:
4280         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
4281
4282 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
4283
4284         Unreviewed, rolling out r242688, r242643, r242624.
4285
4286         Caused multiple layout test failures and crashes on iOS and macOS.
4287
4288         Reverted changeset:
4289
4290         "requestAnimationFrame should execute before the next frame"
4291         https://bugs.webkit.org/show_bug.cgi?id=177484
4292         https://trac.webkit.org/changeset/242624/webkit
4293
4294         * Tracing/SystemTracePoints.plist:
4295
4296 2019-03-11  John Wilander  <wilander@apple.com>
4297
4298         Resource Load Statistics: Make it possible exclude localhost from classification
4299         https://bugs.webkit.org/show_bug.cgi?id=195474
4300         <rdar://problem/47520577>
4301
4302         Reviewed by Brent Fulgham.
4303
4304         This patch allows for localhost to be excluded from classification and
4305         treatment as a prevalent resource.
4306
4307         The WebKit Tools change adds a new function called
4308         testRunner.setStatisticsIsRunningTest() which can be used to control this
4309         behavior.
4310
4311         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4312         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4313         (WTR::TestRunner::setStatisticsIsRunningTest):
4314         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4315         * WebKitTestRunner/TestController.cpp:
4316         (WTR::TestController::setStatisticsIsRunningTest):
4317         * WebKitTestRunner/TestController.h:
4318         * WebKitTestRunner/TestInvocation.cpp:
4319         (W