Device Orientation access permission should be denied unless explicitly granted by...
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-12  Chris Dumez  <cdumez@apple.com>
2
3         Device Orientation access permission should be denied unless explicitly granted by the client
4         https://bugs.webkit.org/show_bug.cgi?id=195625
5
6         Reviewed by Youenn Fablet.
7
8         add API test coverage.
9
10         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
12         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
13         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
14         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
15         (runDeviceOrientationTest):
16         (TEST):
17         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
18         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
19
20 2019-03-12  Jer Noble  <jer.noble@apple.com>
21
22         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
23         https://bugs.webkit.org/show_bug.cgi?id=195137
24         <rdar://problem/48810307>
25
26         Reviewed by Eric Carlson.
27
28         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
29         (TestWebKitAPI::TEST):
30
31 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
32
33         [ews-build] Change urls from uat to production
34         https://bugs.webkit.org/show_bug.cgi?id=195566
35
36         Reviewed by Lucas Forschler.
37
38         * BuildSlaveSupport/ews-app/ews/config.py:
39         * BuildSlaveSupport/ews-build/events.py:
40         * BuildSlaveSupport/ews-build/steps.py:
41
42 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
43
44         [ews-build] change max_builds for local-worker to 1
45         https://bugs.webkit.org/show_bug.cgi?id=195568
46
47         Reviewed by Lucas Forschler.
48
49         * BuildSlaveSupport/ews-build/loadConfig.py:
50
51 2019-03-12  Tim Horton  <timothy_horton@apple.com>
52
53         Fix the build
54
55         * TestRunnerShared/spi/PencilKitTestSPI.h:
56         * TestWebKitAPI/ios/PencilKitTestSPI.h:
57
58 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
59
60         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
61         https://bugs.webkit.org/show_bug.cgi?id=194131
62
63         Reviewed by Michael Catanzaro.
64
65         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
66         (uriChanged):
67         (testUnfinishedSubresourceLoad):
68         (serverCallback):
69         (beforeAll):
70
71 2019-03-11  Alex Christensen  <achristensen@webkit.org>
72
73         WTF::Expected should use std::addressof instead of operator&
74         https://bugs.webkit.org/show_bug.cgi?id=195604
75
76         Reviewed by Myles Maxfield.
77
78         * TestWebKitAPI/Tests/WTF/Expected.cpp:
79         (TestWebKitAPI::Unique::Unique):
80         (TestWebKitAPI::Unique::operator&):
81         (TestWebKitAPI::TEST):
82
83 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
84
85         Add Optional to Forward.h.
86         https://bugs.webkit.org/show_bug.cgi?id=195586
87
88         Reviewed by Darin Adler.
89
90         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
91         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
92         Remove unnecessary includes from headers.
93
94 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
95
96         Add testing API to hit-test and scroll overflow scrollers
97         https://bugs.webkit.org/show_bug.cgi?id=195278
98
99         Reviewed by Antti Koivisto.
100         
101         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
102         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
103         
104         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
105
106         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
107         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
108         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
109         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
110         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
111         * TestRunnerShared/UIScriptContext/UIScriptController.h:
112         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
113         (WTR::enclosingScrollViewIncludingSelf):
114         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
115
116 2019-03-11  Tim Horton  <timothy_horton@apple.com>
117
118         API test WebKit.RequestTextInputContext fails on iOS
119         https://bugs.webkit.org/show_bug.cgi?id=195585
120
121         Reviewed by Wenson Hsieh and Simon Fraser.
122
123         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
124         (applyStyle):
125         (TEST):
126         Add a viewport, so that the coordinates match up on iOS.
127         Scroll by moving the UIScrollView's contentOffset.
128
129 2019-03-11  Chris Dumez  <cdumez@apple.com>
130
131         Assert in WebPageProxy::suspendCurrentPageIfPossible()
132         https://bugs.webkit.org/show_bug.cgi?id=195506
133         <rdar://problem/48733477>
134
135         Reviewed by Alex Christensen.
136
137         Add API test coverage.
138
139         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
140
141 2019-03-11  Shawn Roberts  <sroberts@apple.com>
142
143         Adding myself to contributors.json
144
145         Unreviewed, addming myself to contributors.json .
146
147         * Scripts/webkitpy/common/config/contributors.json:
148
149 2019-03-11  Alex Christensen  <achristensen@webkit.org>
150
151         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
152         https://bugs.webkit.org/show_bug.cgi?id=195511
153         <rdar://problem/44873269>
154
155         Reviewed by Darin Adler.
156
157         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
158         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
159         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
160         (TEST_F):
161
162 2019-03-11  Chris Dumez  <cdumez@apple.com>
163
164         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
165         https://bugs.webkit.org/show_bug.cgi?id=195561
166
167         Reviewed by Youenn Fablet.
168
169         Make sure the JS in the test requests for permission to receive device orientation events.
170
171         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
172
173 2019-03-11  Youenn Fablet  <youenn@apple.com>
174
175         Allow storage quota increase by default in WTR
176         https://bugs.webkit.org/show_bug.cgi?id=195541
177
178         Reviewed by Geoffrey Garen.
179
180         Allow storage quota increase by default in WTR.
181         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
182         Use this for tests that explicitly need cache increase.
183
184         Instead of increasing quota by 2, make sure the next request is
185         granted by adding all given parameters.
186
187         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
188         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
189         (WTR::TestRunner::setAllowStorageQuotaIncrease):
190         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
191         * WebKitTestRunner/InjectedBundle/TestRunner.h:
192         * WebKitTestRunner/TestController.cpp:
193         (WTR::TestController::setAllowStorageQuotaIncrease):
194         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
195         * WebKitTestRunner/TestController.h:
196         * WebKitTestRunner/TestInvocation.cpp:
197         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
198         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
199         (WTR::TestController::cocoaResetStateToConsistentValues):
200         (WTR::TestController::setAllowStorageQuotaIncrease):
201         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
202         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
203         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
204
205 2019-03-11  Xan Lopez  <xan@igalia.com>
206
207         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
208         https://bugs.webkit.org/show_bug.cgi?id=194147
209
210         Reviewed by Michael Saboff.
211
212         To make --32-bit work correctly on Linux/64bit we need to:
213
214         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
215         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
216         unfortunately CMake only allows us to do this during
217         crosscompilation, which is overkill here.
218         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
219         pkg-config detection module uses the x86 .pc files instead of the
220         x86_64 ones.
221         - Set the -m32 flags for the compiler.
222
223         * Scripts/webkitdirs.pm:
224         (generateBuildSystemFromCMakeProject):
225
226 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
227
228         Add MotionMark-1.1 plan file for run-benchmark script.
229         https://bugs.webkit.org/show_bug.cgi?id=195481
230
231         Rubber-stamped by Darin Adler.
232
233         Run-benchmark script should support MontionMark-1.1.
234
235         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
236
237 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
238
239         [ews-app] Add support for submit-to-ews url
240         https://bugs.webkit.org/show_bug.cgi?id=195477
241
242         Reviewed by Lucas Forschler.
243
244         * BuildSlaveSupport/ews-app/ews/fetcher.py:
245         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
246         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
247         * BuildSlaveSupport/ews-app/ews/urls.py:
248         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
249
250 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
251
252         Unreviewed, rolling out r242688, r242643, r242624.
253
254         Caused multiple layout test failures and crashes on iOS and macOS.
255
256         Reverted changeset:
257
258         "requestAnimationFrame should execute before the next frame"
259         https://bugs.webkit.org/show_bug.cgi?id=177484
260         https://trac.webkit.org/changeset/242624/webkit
261
262         * Tracing/SystemTracePoints.plist:
263
264 2019-03-11  John Wilander  <wilander@apple.com>
265
266         Resource Load Statistics: Make it possible exclude localhost from classification
267         https://bugs.webkit.org/show_bug.cgi?id=195474
268         <rdar://problem/47520577>
269
270         Reviewed by Brent Fulgham.
271
272         This patch allows for localhost to be excluded from classification and
273         treatment as a prevalent resource.
274
275         The WebKit Tools change adds a new function called
276         testRunner.setStatisticsIsRunningTest() which can be used to control this
277         behavior.
278
279         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
280         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
281         (WTR::TestRunner::setStatisticsIsRunningTest):
282         * WebKitTestRunner/InjectedBundle/TestRunner.h:
283         * WebKitTestRunner/TestController.cpp:
284         (WTR::TestController::setStatisticsIsRunningTest):
285         * WebKitTestRunner/TestController.h:
286         * WebKitTestRunner/TestInvocation.cpp:
287         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
288
289 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
290
291         [ews-build] Disable waterfall and console view for ews-build.webkit.org
292         https://bugs.webkit.org/show_bug.cgi?id=195560
293
294         Reviewed by Lucas Forschler.
295
296         * BuildSlaveSupport/ews-build/master.cfg:
297
298 2019-03-11  Alex Christensen  <achristensen@webkit.org>
299
300         Unreviewed, rolling out r242698.
301
302         API test crashes on bots.
303
304         Reverted changeset:
305
306         "Add a WKContentRuleList variant that uses copied memory
307         instead of mmap'd shared memory for class A containerized
308         apps"
309         https://bugs.webkit.org/show_bug.cgi?id=195511
310         https://trac.webkit.org/changeset/242698
311
312 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
313
314         [WPE] Enable web process sandbox
315         https://bugs.webkit.org/show_bug.cgi?id=195169
316
317         Reviewed by Daniel Bates.
318
319         * wpe/install-dependencies:
320         * wpe/jhbuild.modules:
321
322 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
323
324         [ews-app] Use port 17000 for worker communication
325         https://bugs.webkit.org/show_bug.cgi?id=195558
326
327         Reviewed by Lucas Forschler.
328
329         * BuildSlaveSupport/ews-build/master.cfg:
330
331 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
332
333         [ews-build] unit-tests fail when passwords.json is missing
334         https://bugs.webkit.org/show_bug.cgi?id=195557
335
336         Reviewed by Lucas Forschler.
337
338         * BuildSlaveSupport/ews-build/loadConfig.py:
339         (loadBuilderConfig):
340         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
341         (ConfigDotJSONTest.test_configuration):
342         * BuildSlaveSupport/ews-build/master.cfg:
343
344 2019-03-11  Truitt Savell  <tsavell@apple.com>
345
346         Unreviewed, rolling out r242702.
347
348         Broke High Sierra builders.
349
350         Reverted changeset:
351
352         "Add utility function to allow easy reverse range-based
353         iteration of a container"
354         https://bugs.webkit.org/show_bug.cgi?id=195542
355         https://trac.webkit.org/changeset/242702
356
357 2019-03-11  Sam Weinig  <sam@webkit.org>
358
359         Add utility function to allow easy reverse range-based iteration of a container
360         https://bugs.webkit.org/show_bug.cgi?id=195542
361
362         Reviewed by Antti Koivisto.
363
364         * TestWebKitAPI/CMakeLists.txt:
365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
366         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
367         (TestWebKitAPI::TEST):
368         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
369
370 2019-03-10  Alex Christensen  <achristensen@webkit.org>
371
372         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
373         https://bugs.webkit.org/show_bug.cgi?id=195511
374         <rdar://problem/44873269>
375
376         Reviewed by Darin Adler.
377
378         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
379         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
380         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
381         (TEST_F):
382
383 2019-03-10  Tim Horton  <timothy_horton@apple.com>
384
385         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
386         https://bugs.webkit.org/show_bug.cgi?id=195499
387
388         Reviewed by Darin Adler.
389
390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
391         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
392         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
393         (-[WKWebView synchronouslyFocusTextInputContext:]):
394         (applyStyle):
395         (applyIframe):
396         (TEST):
397         Add some tests for this SPI.
398
399 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
400
401         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
402         https://bugs.webkit.org/show_bug.cgi?id=181151
403
404         Reviewed by Don Olmstead.
405
406         * TestWebKitAPI/CMakeLists.txt:
407         * TestWebKitAPI/PlatformWin.cmake:
408         Enable TestWTF RunLoop tests in all platforms.
409
410         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
411         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
412         (TestWebKitAPI::DerivedOneShotTimer::fired):
413         (TestWebKitAPI::TEST):
414         Only a few platforms support nested RunLoop.
415
416         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
417         (TestWebKitAPI::DerivedRepeatingTimer::fired):
418
419 2019-03-10  David Quesada  <david_quesada@apple.com>
420
421         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
422         https://bugs.webkit.org/show_bug.cgi?id=152480
423
424         Reviewed by Chris Dumez.
425
426         Add a unit test based on Daniel Bates's test case that starts a download, ensures
427         there are no additional references to the process pool besides the one held by
428         the download, waits for the download to finish (in the sense that the
429         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
430         measure, also check that the process pool has been deallocated at the end of the
431         test. The test wouldn't be meaningful if the process pool were still alive.
432
433         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
434         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
435         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
436             The download will be canceled because the delegate does not implement the
437             method to decide the download's destination, so this is where we know the
438             DownloadProxyMap is done with the DownloadProxy.
439         (TEST):
440
441 2019-03-08  Chris Dumez  <cdumez@apple.com>
442
443         Add support for Device Orientation / Motion permission API
444         https://bugs.webkit.org/show_bug.cgi?id=195329
445         <rdar://problem/47645367>
446
447         Reviewed by Geoffrey Garen.
448
449         Add test infrastructure to help test the Device Orientation / Motion permission API.
450
451         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
452         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
453         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
454         * WebKitTestRunner/InjectedBundle/TestRunner.h:
455         * WebKitTestRunner/TestController.cpp:
456         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
457         (WTR::TestController::createWebViewWithOptions):
458         (WTR::TestController::resetStateToConsistentValues):
459         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
460         * WebKitTestRunner/TestController.h:
461         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
462         * WebKitTestRunner/TestInvocation.cpp:
463         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
464
465 2019-03-08  Saam barati  <sbarati@apple.com>
466
467         Add a compare-results script to compare benchmark results
468         https://bugs.webkit.org/show_bug.cgi?id=195486
469         <rdar://problem/48723397>
470
471         Reviewed by Geoffrey Garen.
472
473         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
474         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
475         to extend it to learn about our other benchmarks.
476
477         * Scripts/compare-results: Added.
478         (readJSONFile):
479         (detectJetStream2):
480         (JetStream2Results):
481         (detectSpeedometer2):
482         (Speedometer2Results):
483         (detectPLT5):
484         (PLT5Results):
485         (detectBenchmark):
486         (biggerIsBetter):
487         (ttest):
488         (getOptions):
489         (main):
490
491 2019-03-08  Stephanie Lewis  <slewis@apple.com>
492
493         Ensure old tab state is cleared between iterations of run-benchmark
494         https://bugs.webkit.org/show_bug.cgi?id=195393
495         <rdar://problem/46885583>
496
497         Reviewed by Dewei Zhu.
498
499         a) ensure the default to restore state is not set
500         b) terminate Safari correctly
501         c) Set the system default to ignore Persistent State in Safari
502
503         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
504         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
505         (OSXBrowserDriver.prepare_env): 
506         (OSXBrowserDriver.restore_env):
507         (OSXBrowserDriver.close_browsers):
508         (OSXBrowserDriver._terminate_processes):
509         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
510         (OSXChromeDriver):
511         (OSXChromeCanaryDriver):
512         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
513         (OSXFirefoxDriver):
514         (OSXFirefoxNightlyDriver):
515         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
516         (OSXSafariDriver):
517         (OSXSafariDriver.prepare_env):
518
519 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
520
521         [GTK] Several InputMethodFilter tests are failing
522         https://bugs.webkit.org/show_bug.cgi?id=195408
523
524         Reviewed by Carlos Garcia Campos.
525
526         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
527         Regressed in r241751.
528         Hexadecimal values of keycodes are expressed now in upper letters.
529         Composited characters should be cast to UTF8 strings.
530
531         (TestWebKitAPI::TEST):
532
533 2019-03-07  Tomas Popela  <tpopela@redhat.com>
534
535         [GTK] Make Tools/gtkdoc python3 compatible
536         https://bugs.webkit.org/show_bug.cgi?id=195359
537
538         Reviewed by Carlos Garcia Campos.
539
540         * gtkdoc/generate-gtkdoc:
541         ConfigParser was reworked in Python 3.2 so we have adapt the code to
542         work with Python 2 and 3.
543         (get_gtkdoc_module_paths):
544         The iteritems() was removed in Python 3, so let's use items() that's
545         available in Python 2 and 3.
546         (get_generator_for_config):
547         * gtkdoc/gtkdoc.py:
548         (GTKDoc._run_command):
549         The sys.stdout.write() is expecting str in Python 3 and not bytes
550         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
551         for passing the bytes there.
552
553 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
554
555         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
556         https://bugs.webkit.org/show_bug.cgi?id=195346
557         <rdar://problem/48667048>
558
559         Unreviewed build fix for clang-cl.
560
561         * DumpRenderTree/win/DumpRenderTree.cpp:
562         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
563
564 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
565
566         requestAnimationFrame should execute before the next frame
567         https://bugs.webkit.org/show_bug.cgi?id=177484
568
569         Reviewed by Simon Fraser.
570
571         Add trace points for the page RenderingUpdate.
572
573         * Tracing/SystemTracePoints.plist:
574
575 2019-03-07  Zalan Bujtas  <zalan@apple.com>
576
577         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
578         https://bugs.webkit.org/show_bug.cgi?id=195353
579         <rdar://problem/48626394>
580
581         Reviewed by Simon Fraser.
582
583         * WebKitTestRunner/ios/TestControllerIOS.mm:
584         (WTR::TestController::platformResetPreferencesToConsistentValues):
585
586 2019-03-07  John Wilander  <wilander@apple.com>
587
588         Resource Load Statistics: Make it possible to purge only script-accessible cookies
589         https://bugs.webkit.org/show_bug.cgi?id=195383
590         <rdar://problem/48570136>
591
592         Reviewed by Brent Fulgham.
593
594         This patch adds test infrastructure to purge only script-accessible cookies,
595         including a new testRunner function called statisticsDeleteCookiesForHost().git a
596
597         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
598         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
599         (WTR::TestRunner::statisticsDeleteCookiesForHost):
600         * WebKitTestRunner/InjectedBundle/TestRunner.h:
601         * WebKitTestRunner/TestController.cpp:
602         (WTR::TestController::statisticsDeleteCookiesForHost):
603         * WebKitTestRunner/TestController.h:
604         * WebKitTestRunner/TestInvocation.cpp:
605         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
606
607 2019-03-07  Commit Queue  <commit-queue@webkit.org>
608
609         Unreviewed, rolling out r242354.
610         https://bugs.webkit.org/show_bug.cgi?id=195402
611
612         breaks layout tests in all configurations (Requested by
613         zdobersek on #webkit).
614
615         Reverted changeset:
616
617         "[WPE] Enable web process sandbox"
618         https://bugs.webkit.org/show_bug.cgi?id=195169
619         https://trac.webkit.org/changeset/242354
620
621 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
622
623         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
624         https://bugs.webkit.org/show_bug.cgi?id=195346
625
626         Reviewed by Fujii Hironori.
627
628         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
629         (TestWebKitAPI::TEST):
630         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
631
632         * DumpRenderTree/win/DumpRenderTree.cpp:
633         (findFontFallback):
634         (addFontFallbackIfPresent):
635         (removeFontFallbackIfPresent):
636         (main):
637         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
638         (TestWebKitAPI::Util::moduleDirectory):
639         (TestWebKitAPI::Util::createInjectedBundlePath):
640         Use wchar helpers as needed.
641
642 2019-03-06  Rob Buis  <rbuis@igalia.com>
643
644         Consider supporting the `referrerpolicy` attribute.
645         https://bugs.webkit.org/show_bug.cgi?id=179053
646
647         Reviewed by Darin Adler.
648
649         Add a runtime flag for referrerpolicy attribute.
650
651         * DumpRenderTree/mac/DumpRenderTree.mm:
652         (enableExperimentalFeatures):
653
654 2019-03-05  Daniel Bates  <dabates@apple.com>
655
656         Update expected API test result following r242379
657         (https://bugs.webkit.org/show_bug.cgi?id=195125)
658
659         Update expected x-coordinate of selection rect now that the left padding of
660         a textarea is sized in ems (so dependent on the font size) just like the left
661         padding of a text field.
662
663         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
664         (TestWebKitAPI::TEST):
665
666 2019-03-05  David Quesada  <david_quesada@apple.com>
667
668         [WK2] It should be possible to follow links with 'download' attributes
669         https://bugs.webkit.org/show_bug.cgi?id=195145
670         rdar://problem/48462642
671
672         Reviewed by Alex Christensen.
673
674         Add a unit test to verify that activating links with 'download' attributes now
675         navigates to the linked resource, rather than starts downloading it. Add another
676         to verify that it is still possible to explicitly download the link via the
677         'Download' navigation action policy.
678
679         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
680         (-[DownloadAttributeTestDelegate init]):
681         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
682         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
683         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
684         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
685         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
686         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
687         (TEST):
688         * WebKitTestRunner/TestController.cpp:
689         (WTR::TestController::decidePolicyForNavigationAction):
690         * WebKitTestRunner/TestController.h:
691
692 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
693
694         [Curl] Implement Cookie Accept Policy.
695         https://bugs.webkit.org/show_bug.cgi?id=191645
696
697         Reviewed by Fujii Hironori.
698
699         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
700         (TestWebKitAPI::Curl::TEST_F):
701
702 2019-03-05  Youenn Fablet  <youenn@apple.com>
703
704         Rename requestCacheStorageSpace to requestStorageSpace
705         https://bugs.webkit.org/show_bug.cgi?id=195282
706
707         Reviewed by Chris Dumez.
708
709         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
710         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
711         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
712
713 2019-03-05  Brady Eidson  <beidson@apple.com>
714
715         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
716         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
717
718         Reviewed by Tim Horton.
719
720         Loading a file: URL into a WKWebView and then loading another file: url from a completely
721         different directory into that same WKWebView should work.
722
723         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
724         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
725
726 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
727
728         Add WeakHashSet
729         https://bugs.webkit.org/show_bug.cgi?id=195152
730
731         Reviewed by Antti Koivisto.
732
733         Added tests for WeakHashSet.
734
735         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
736         (TestWebKitAPI::Base::Base): Moved.
737         (TestWebKitAPI::Derived::foo): Moved.
738         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
739         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
740         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
741         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
742
743 2019-03-04  Chris Dumez  <cdumez@apple.com>
744
745         Do not share WebProcesses between private and regular sessions
746         https://bugs.webkit.org/show_bug.cgi?id=195189
747         <rdar://problem/48421064>
748
749         Reviewed by Alex Christensen.
750
751         Add API test coverage.
752
753         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
754         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
755
756 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
757
758         [WPE] Enable web process sandbox
759         https://bugs.webkit.org/show_bug.cgi?id=195169
760
761         Reviewed by Daniel Bates.
762
763         * wpe/install-dependencies:
764         * wpe/jhbuild.modules:
765
766 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
767
768         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
769         https://bugs.webkit.org/show_bug.cgi?id=195206
770
771         Reviewed by Žan Doberšek.
772
773         Add a new test case.
774
775         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
776         (testJSCClass):
777
778 2019-03-04  Charlie Turner  <cturner@igalia.com>
779
780         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
781         https://bugs.webkit.org/show_bug.cgi?id=194898
782
783         Reviewed by Žan Doberšek.
784
785         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
786         a GCC extension that permits arithmetic on void* pointer. Inline
787         the macro until this issue is fixed upstream.
788
789 2019-03-03  Tim Horton  <timothy_horton@apple.com>
790
791         Rid the world of WK_API_ENABLED
792         https://bugs.webkit.org/show_bug.cgi?id=195263
793
794         Reviewed by Dan Bernstein.
795
796         List of changed files elided because it's useless.
797
798 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
799
800         Unreviewed follow-up to r242292.
801
802         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
803
804         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
805         (TestWebKitAPI::testStrip): Renamed from strip.
806         (TestWebKitAPI::TEST):
807
808 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
809
810         Unreviewed, remove accidentally-committed URLHelpers.cpp test
811
812         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
813         and bug #194272 for details.
814
815         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
816
817 2019-03-03  Tim Horton  <timothy_horton@apple.com>
818
819         Remove some more unused 32-bit code
820         https://bugs.webkit.org/show_bug.cgi?id=195255
821
822         Reviewed by Darin Adler.
823
824         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
825         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
826         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
827         (NPP_New):
828         (NPP_HandleEvent):
829         (handleEventCarbon): Deleted.
830
831 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
832
833         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
834
835         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
836         (TestWebKitAPI::TEST):
837
838 2019-03-01  Darin Adler  <darin@apple.com>
839
840         Finish removing String::format
841         https://bugs.webkit.org/show_bug.cgi?id=194893
842
843         Reviewed by Daniel Bates.
844 '
845         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
846
847 2019-03-01  Alex Christensen  <achristensen@webkit.org>
848
849         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
850         https://bugs.webkit.org/show_bug.cgi?id=195229
851         <rdar://problem/48520362>
852
853         Reviewed by Chris Dumez.
854
855         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
856         (TEST):
857
858 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
859
860         Add a system trace scope for event region building
861         https://bugs.webkit.org/show_bug.cgi?id=195226
862
863         Reviewed by Jon Lee.
864
865         This trace scope measures the time spend converting element rects into Region objects,
866         which can be large on some pages.
867
868         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
869
870         * Tracing/SystemTracePoints.plist:
871
872 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
873
874         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
875         https://bugs.webkit.org/show_bug.cgi?id=194612
876
877         Reviewed by Alex Christensen.
878
879         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
880         Just test the new string-processing function and don't touch the actual environment.
881         (Test cases are all as before, but based on operator== instead of strcmp.)
882
883 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
884
885         [ews-app] Update primary keys for handling multiple Buildbot instances
886         https://bugs.webkit.org/show_bug.cgi?id=195120
887
888         Reviewed by Stephanie Lewis.
889
890         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
891         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
892         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
893
894         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
895         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
896         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
897         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
898         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
899         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
900
901 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
902
903         [WinCairo] Enable service worker
904         https://bugs.webkit.org/show_bug.cgi?id=188318
905
906         Reviewed by Youenn Fablet.
907
908         * DumpRenderTree/DumpRenderTreePrefix.h:
909         * TestWebKitAPI/PlatformWin.cmake:
910         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
911         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
912         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
913
914 2019-03-01  Justin Fan  <justin_fan@apple.com>
915
916         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
917         https://bugs.webkit.org/show_bug.cgi?id=195191
918
919         Rubber-stamped by Dean Jackson.
920
921         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
922
923         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
924
925 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
926
927         Unreviewed, fix lldb webkitpy tests
928         https://bugs.webkit.org/show_bug.cgi?id=194375
929
930         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
931
932         * lldb/lldb_webkit.py:
933         (WTFStringImplProvider.is_8bit):
934
935 2019-02-28  David Quesada  <david_quesada@apple.com>
936
937         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
938         https://bugs.webkit.org/show_bug.cgi?id=195121
939         rdar://problem/48450302
940
941         Reviewed by Alex Christensen.
942
943         Add API tests for -WKNavigationAction._shouldPerformDownload in various
944         configurations where the 'download' attribute is absent, blank, or populated
945         with a filename, and where the anchor element is same-origin or cross-origin
946         (meaning the 'download' attribute shouldn't be honored).
947
948         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
949         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
950         (-[NavigationActionTestDelegate init]):
951         (-[NavigationActionTestDelegate navigationAction]):
952         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
953         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
954         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
955         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
956         (TEST):
957
958 2019-02-28  Antoine Quint  <graouts@apple.com>
959
960         Enable the Pointer Events runtime flag by default
961         https://bugs.webkit.org/show_bug.cgi?id=195156
962
963         Reviewed by Dean Jackson.
964
965         * DumpRenderTree/mac/DumpRenderTree.mm:
966         (enableExperimentalFeatures):
967
968 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
969
970         Several PasteImage API tests are flaky
971         https://bugs.webkit.org/show_bug.cgi?id=195160
972
973         Reviewed by Tim Horton.
974
975         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
976         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
977         listening for a "load" event after image load is already complete.
978
979         To address this, make these tests first register a "load" event handler, then run script to insert an image
980         element into the document, and finally wait until the load event is observed before checking image size.
981
982         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
983
984 2019-02-28  Chris Dumez  <cdumez@apple.com>
985
986         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
987         https://bugs.webkit.org/show_bug.cgi?id=195107
988
989         Reviewed by Alex Christensen.
990
991         Give some time for the zoom level to get restored.
992
993         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
994
995 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
996
997         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
998         https://bugs.webkit.org/show_bug.cgi?id=194958
999
1000         Reviewed by Geoffrey Garen.
1001
1002         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
1003         (TEST):
1004
1005 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
1006
1007         [ews-app] Update method to save build to handle builder_display_name
1008         https://bugs.webkit.org/show_bug.cgi?id=195047
1009
1010         Reviewed by Dewei Zhu.
1011
1012         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
1013         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
1014
1015 2019-02-28  Justin Fan  <justin_fan@apple.com>
1016
1017         [Web GPU] Enable Web GPU only on 64-bit
1018         https://bugs.webkit.org/show_bug.cgi?id=195139
1019
1020         Because Metal is only supported on 64 bit apps.
1021
1022         Unreviewed build fix.
1023
1024         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1025
1026 2019-02-27  Youenn Fablet  <youenn@apple.com>
1027
1028         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
1029         https://bugs.webkit.org/show_bug.cgi?id=194959
1030
1031         Reviewed by Chris Dumez.
1032
1033         Spin loop until getting the condition to remove flakiness.
1034
1035         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1036
1037 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
1038
1039         [ews-build] Buildbot should include builder_display_name in the build events
1040         https://bugs.webkit.org/show_bug.cgi?id=195045
1041
1042         Reviewed by Dewei Zhu.
1043
1044         * BuildSlaveSupport/ews-build/events.py:
1045         (Events.buildStarted): Included builder_display_name in event data. Also renamed
1046         buildername to builder_name to be consistent in naming style.
1047         (Events.buildFinished): Ditto.
1048
1049 2019-02-27  Chris Dumez  <cdumez@apple.com>
1050
1051         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
1052         https://bugs.webkit.org/show_bug.cgi?id=194480
1053
1054         Reviewed by Brady Eidson.
1055
1056         Update existing API test to make it more likely to reproduce the issue.
1057
1058         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1059
1060 2019-02-27  Brady Eidson  <beidson@apple.com>
1061
1062         Universal links from Google search results pages don't open the app.
1063         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
1064
1065         Reviewed by Geoffrey Garen.
1066
1067         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1068         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1069         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1070         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1071
1072 2019-02-27  Chris Dumez  <cdumez@apple.com>
1073
1074         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
1075         https://bugs.webkit.org/show_bug.cgi?id=195102
1076
1077         Reviewed by Geoffrey Garen.
1078
1079         If the number of processes is not yet what we expect, wait a bit and check again to give
1080         processes some time to exit.
1081
1082         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1083
1084 2019-02-27  Chris Dumez  <cdumez@apple.com>
1085
1086         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
1087         https://bugs.webkit.org/show_bug.cgi?id=194545
1088
1089         Reviewed by Brady Eidson.
1090
1091         Make sure the test navigates forward and then back only once. Previously, navigating
1092         back would trigger a navigation again in a timer.
1093
1094         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1095
1096 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
1097
1098         High Sierra Debug JSC test queue should use faster hardware
1099         https://bugs.webkit.org/show_bug.cgi?id=194603
1100
1101         Rubber-stamped by Alexey Proskuryakov.
1102
1103         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
1104
1105         * BuildSlaveSupport/build.webkit.org-config/config.json:
1106         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1107         (BubbleQueueServer):
1108         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1109         (WebKitBuildbot):
1110         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1111         * QueueStatusServer/config/queues.py:
1112         * Scripts/webkitpy/common/config/ews.json:
1113         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1114         (test_ews_name):
1115
1116 2019-02-27  John Wilander  <wilander@apple.com>
1117
1118         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
1119         https://bugs.webkit.org/show_bug.cgi?id=195071
1120         <rdar://problem/48417690>
1121
1122         Reviewed by Alex Christensen and Brent Fulgham.
1123
1124         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1125         (TestWebKitAPI::createURL):
1126             Convenience function.
1127         (TestWebKitAPI::TEST):
1128             WebCore::AdClickAttribution now takes a URL when creating Source and
1129             Destination.
1130         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1131         (TestWebKitAPI::TEST):
1132             WebCore::AdClickAttribution now takes a URL when creating Source and
1133             Destination.
1134
1135 2019-02-27  Antoine Quint  <graouts@apple.com>
1136
1137         Support Pointer Events on macOS
1138         https://bugs.webkit.org/show_bug.cgi?id=195008
1139         <rdar://problem/47454419>
1140
1141         Reviewed by Dean Jackson.
1142
1143         * DumpRenderTree/mac/DumpRenderTree.mm:
1144         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
1145         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1146
1147 2019-02-26  Mark Lam  <mark.lam@apple.com>
1148
1149         Remove remaining poisoning code.
1150         https://bugs.webkit.org/show_bug.cgi?id=194138
1151
1152         Reviewed by Saam Barati.
1153
1154         * TestWebKitAPI/CMakeLists.txt:
1155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1156         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
1157         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
1158         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
1159         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
1160         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
1161         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
1162
1163 2019-02-26  Alex Christensen  <achristensen@webkit.org>
1164
1165         Move ephemeral local storage from WebProcess to UIProcess
1166         https://bugs.webkit.org/show_bug.cgi?id=195074
1167         <rdar://problem/47937975>
1168
1169         Reviewed by Geoff Garen.
1170
1171         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1172
1173 2019-02-20  Jer Noble  <jer.noble@apple.com>
1174
1175         [Cocoa] Media elements will restart network buffering just before suspending
1176         https://bugs.webkit.org/show_bug.cgi?id=193691
1177
1178         Reviewed by Eric Carlson.
1179
1180         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1181         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1182         (TEST):
1183
1184 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
1185
1186         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
1187         https://bugs.webkit.org/show_bug.cgi?id=191652
1188
1189         Reviewed by Alex Christensen.
1190
1191         Fix WinCairo MiniBrowser behavior of authentication dialog.
1192
1193         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1194         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1195
1196 2019-02-26  Youenn Fablet  <youenn@apple.com>
1197
1198         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
1199         https://bugs.webkit.org/show_bug.cgi?id=195028
1200         <rdar://problem/48243733>
1201
1202         Reviewed by Eric Carlson.
1203
1204         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1205
1206 2019-02-26  Philippe Normand  <pnormand@igalia.com>
1207
1208         [WPE] Add API for webview background color configuration
1209         https://bugs.webkit.org/show_bug.cgi?id=192305
1210
1211         Reviewed by Michael Catanzaro.
1212
1213         * MiniBrowser/wpe/main.cpp:
1214         (main): Add a new option to configure the webview background
1215         color. Example: --bg-color=transparent.
1216         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1217         (testWebViewBackgroundColor): Enable background color API tests for WPE.
1218         (beforeAll): Ditto.
1219
1220 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
1221
1222         scalableNativeWebpageParameters() is not preserved on new page navigation.
1223         https://bugs.webkit.org/show_bug.cgi?id=194892
1224         <rdar://problem/47538280>
1225
1226         Reviewed by Wenson Hsieh.
1227         
1228         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
1229
1230         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1231         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1232         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1233         (WTR::UIScriptController::allowsViewportShrinkToFit):
1234         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1235         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1236         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1237         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1238         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1239         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1240
1241 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1242
1243         [ews-app] Add model for handling multiple Buildbot instances
1244         https://bugs.webkit.org/show_bug.cgi?id=194863
1245
1246         Reviewed by Stephanie Lewis.
1247
1248         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
1249
1250 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1251
1252         [ews-app] Remove BuilderMapping table
1253         https://bugs.webkit.org/show_bug.cgi?id=194961
1254
1255         Reviewed by Stephanie Lewis.
1256
1257         Store builder name directly in build table, instead of having a separate
1258         table for it.
1259
1260         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1261         * BuildSlaveSupport/ews-app/ews/models/build.py:
1262         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
1263         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1264
1265 2019-02-25  John Wilander  <wilander@apple.com>
1266
1267         Introduce and adopt new class RegistrableDomain for eTLD+1
1268         https://bugs.webkit.org/show_bug.cgi?id=194791
1269         <rdar://problem/48179240>
1270
1271         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
1272
1273         This patch adds an API test and replaces two instances of
1274         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
1275
1276         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1277         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1278         (TestWebKitAPI::TEST):
1279             Changed two strings to make sure the registrable domains are still considered
1280             invalid and pass the test.
1281         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
1282         (TestWebKitAPI::TEST):
1283         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1284         (WTR::InjectedBundle::didReceiveMessageToPage):
1285
1286 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
1287
1288         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
1289         https://bugs.webkit.org/show_bug.cgi?id=195001
1290
1291         Reviewed by Carlos Garcia Campos.
1292
1293         API version 1.0 always includes the functionality previously guarded with
1294         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
1295         unconditionally.
1296
1297         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1298         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
1299         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
1300         (WebViewTest::showInWindow): Ditto.
1301         (WebViewTest::hideView): Ditto.
1302         * wpe/backends/HeadlessViewBackend.cpp:
1303         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
1304         * wpe/backends/ViewBackend.cpp:
1305         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
1306         * wpe/backends/WindowViewBackend.cpp:
1307         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
1308         WPE_BACKEND_CHECK_VERSION().
1309         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
1310
1311 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
1312
1313         [Flatpak] Add support for flatpak > 1.1.2
1314         https://bugs.webkit.org/show_bug.cgi?id=194088
1315
1316         Flatpak 1.2 is now out so we need to support that
1317         version now.
1318
1319         Reviewed by Michael Catanzaro.
1320
1321         * flatpak/flatpakutils.py:
1322         (check_flatpak):
1323         (FlatpakPackages.__init__):
1324         (FlatpakPackages.__detect_packages):
1325         (FlatpakPackages.__detect_packages.in):
1326         (FlatpakRepos.update):
1327
1328 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
1329
1330         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
1331         https://bugs.webkit.org/show_bug.cgi?id=194998
1332
1333         Reviewed by Carlos Garcia Campos.
1334
1335         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
1336         to a Git checkout and using the latest commit containing various fixes
1337         and improvements.
1338
1339 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1340
1341         [WPE][GTK] Remove user agent quirk for washingtonpost.com
1342         https://bugs.webkit.org/show_bug.cgi?id=194981
1343
1344         Reviewed by Žan Doberšek.
1345
1346         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1347         (TestWebKitAPI::TEST):
1348
1349 2019-02-23  Keith Miller  <keith_miller@apple.com>
1350
1351         Add new mac target numbers
1352         https://bugs.webkit.org/show_bug.cgi?id=194955
1353
1354         Reviewed by Tim Horton.
1355
1356         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1357         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1358         * MiniBrowser/Configurations/Base.xcconfig:
1359         * TestWebKitAPI/Configurations/Base.xcconfig:
1360         * WebKitTestRunner/Configurations/Base.xcconfig:
1361
1362 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1363
1364         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1365         https://bugs.webkit.org/show_bug.cgi?id=194846
1366
1367         Reviewed by Don Olmstead.
1368
1369         Added _search_paths() and _port_specific_expectations_files() for
1370         WinCairoPort.
1371
1372         * Scripts/webkitpy/port/win.py:
1373         (WinCairoPort.default_baseline_search_path):
1374         (WinCairoPort):
1375         (WinCairoPort._port_specific_expectations_files):
1376         (WinCairoPort._search_paths):
1377
1378 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1379
1380         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1381         https://bugs.webkit.org/show_bug.cgi?id=194963
1382
1383         Reviewed by Dean Jackson.
1384
1385         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1386         Do a `contains` check instead of `equals`, because in debug builds we
1387         put the GraphicsLayer pointer in a prefix.
1388
1389 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1390
1391         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1392         https://bugs.webkit.org/show_bug.cgi?id=194873
1393         <rdar://problem/46701974>
1394
1395         Reviewed by Tim Horton.
1396
1397         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1398
1399         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1400         (WTR::UIScriptController::menuRect const):
1401         (WTR::UIScriptController::isShowingMenu const):
1402         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1403         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1404         (WTR::UIScriptController::menuRect const):
1405
1406         Add a function to query the bounds of the callout menu in content coordinates.
1407
1408         (WTR::UIScriptController::isShowingMenu const):
1409
1410         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1411
1412         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1413         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1414         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1415         (WTR::UIScriptController::rectForMenuAction const):
1416         (WTR::UIScriptController::menuRect const):
1417         (WTR::UIScriptController::isShowingMenu const):
1418         (WTR::findViewInHierarchyOfType): Deleted.
1419
1420 2019-02-22  Chris Dumez  <cdumez@apple.com>
1421
1422         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1423         https://bugs.webkit.org/show_bug.cgi?id=194954
1424         <rdar://problem/48127957>
1425
1426         Reviewed by Alex Christensen.
1427
1428         Add API test coverage.
1429
1430         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1431         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1432         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1433         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1434
1435 2019-02-22  Chris Dumez  <cdumez@apple.com>
1436
1437         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1438         https://bugs.webkit.org/show_bug.cgi?id=194924
1439         <rdar://problem/48216125>
1440
1441         Reviewed by Geoffrey Garen.
1442
1443         Add API test coverage.
1444
1445         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1446
1447 2019-02-22  Chris Dumez  <cdumez@apple.com>
1448
1449         Unreviewed, disable API test added in r241928 on iOS.
1450
1451         The cache is not enabled on devices with less than 3GB of RAM.
1452
1453         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1454
1455 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1456
1457         Hardcode Visual Viewports on everywhere except iOS WK1
1458         https://bugs.webkit.org/show_bug.cgi?id=194928
1459
1460         Reviewed by Zalan Bujtas.
1461
1462         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1463         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1464         set it to false. The setting has shipped for several years and there's no need to turn
1465         it off now.
1466
1467         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1468         Visual Viewports are not enabled.
1469         
1470         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1471         that only runs in WK2
1472
1473         * MiniBrowser/mac/SettingsController.h:
1474         * MiniBrowser/mac/SettingsController.m:
1475         (-[SettingsController init]):
1476         (-[SettingsController _populateMenu]):
1477         (-[SettingsController validateMenuItem:]):
1478         (-[SettingsController visualViewportEnabled]): Deleted.
1479         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1480         * MiniBrowser/mac/WK1BrowserWindowController.m:
1481         (-[WK1BrowserWindowController didChangeSettings]):
1482         * MiniBrowser/mac/WK2BrowserWindowController.m:
1483         (-[WK2BrowserWindowController didChangeSettings]):
1484
1485 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1486
1487         Discard cached processes when clearing website data store
1488         https://bugs.webkit.org/show_bug.cgi?id=194894
1489
1490         Reviewed by Chris Dumez.
1491
1492         Added a test case.
1493
1494         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1495         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1496
1497 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1498
1499         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1500         https://bugs.webkit.org/show_bug.cgi?id=194914
1501         <rdar://problem/47586889>
1502
1503         Reviewed by Geoffrey Garen.
1504
1505         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1506         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1507         (TEST):
1508         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1509
1510 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1511
1512         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1513         <https://webkit.org/b/194761>
1514
1515         Reviewed by Myles Maxfield.
1516
1517         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1518         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1519         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1520         to use ARC-compliant cast.
1521         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1522         ARC-compliant cast.
1523         (WTR::installFakeHelvetica): Log `error` to console if
1524         CTFontManagerRegisterFontsForURL() fails, but only on supported
1525         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1526         Call CFRelease() on `error` to fix the leak.  Update to use
1527         ARC-compliant cast.
1528         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1529         cast.
1530
1531 2019-02-21  Chris Dumez  <cdumez@apple.com>
1532
1533         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1534         https://bugs.webkit.org/show_bug.cgi?id=194481
1535
1536         Reviewed by Alex Christensen.
1537
1538         Give the processes a chance to shutdown and wait until we reached the expected number
1539         of processes.
1540
1541         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1542
1543 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1544
1545         Fix the macOS build
1546
1547         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1548
1549 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1550
1551         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1552
1553         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1554         I am a backwards.
1555
1556 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1557
1558         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1559
1560         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1561         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1562         We could force on UI-side compositing, but I feel like the test might be more
1563         valuable exercising the normal path on each platform (though the original
1564         bug was also UI-side specific). Though we can't validate that the overlay
1565         layer was installed successfully, there are layout tests that do that.
1566
1567 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1568
1569         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1570         https://bugs.webkit.org/show_bug.cgi?id=194845
1571         <rdar://problem/47944579>
1572
1573         Reviewed by Antti Koivisto.
1574
1575         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1576         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1577
1578 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1579
1580         [LFC][Floats] Add support for placing formatting roots in-between floats.
1581         https://bugs.webkit.org/show_bug.cgi?id=194902
1582
1583         Reviewed by Antti Koivisto.
1584
1585         * LayoutReloaded/misc/LFC-passing-tests.txt:
1586
1587 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1588
1589         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1590         https://bugs.webkit.org/show_bug.cgi?id=194901
1591
1592         Unreviewed build fix.
1593
1594         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1595         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1596         WPEBackend-fdo-0.1 as library name.
1597
1598 2019-02-21  Rob Buis  <rbuis@igalia.com>
1599
1600         Update MIME type parser
1601         https://bugs.webkit.org/show_bug.cgi?id=180526
1602
1603         Reviewed by Darin Adler.
1604
1605         Add tests involving leading and trailing whitespace, non-token
1606         characters and quoted strings.
1607
1608         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1609         (TestWebKitAPI::TEST):
1610
1611 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1612
1613         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1614         https://bugs.webkit.org/show_bug.cgi?id=194884
1615
1616         Reviewed by Michael Catanzaro.
1617
1618         * PlatformWin.cmake:
1619
1620 2019-02-20  Chris Dumez  <cdumez@apple.com>
1621
1622         Add API test for <rdar://problem/47471222>
1623         https://bugs.webkit.org/show_bug.cgi?id=194847
1624
1625         Reviewed by Alex Christensen.
1626
1627         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1628
1629 2019-02-20  Chris Dumez  <cdumez@apple.com>
1630
1631         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1632         https://bugs.webkit.org/show_bug.cgi?id=194872
1633         <rdar://problem/47924500>
1634
1635         Reviewed by Alex Christensen.
1636
1637         Add API test coverage.
1638
1639         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1640
1641 2019-02-20  Jer Noble  <jer.noble@apple.com>
1642
1643         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1644         https://bugs.webkit.org/show_bug.cgi?id=191332
1645
1646         Reviewed by Dean Jackson.
1647
1648         * Scripts/git-is-in-range: Added.
1649
1650 2019-02-20  Andy Estes  <aestes@apple.com>
1651
1652         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1653         https://bugs.webkit.org/show_bug.cgi?id=194869
1654
1655         Rubber-stamped by Jer Noble.
1656
1657         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1658         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1659         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1660         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1662         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1663
1664 2019-02-20  Chris Dumez  <cdumez@apple.com>
1665
1666         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1667         https://bugs.webkit.org/show_bug.cgi?id=194857
1668         <rdar://problem/47759323>
1669
1670         Reviewed by Alex Christensen.
1671
1672         Add API test coverage.
1673
1674         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1675
1676 2019-02-20  Chris Dumez  <cdumez@apple.com>
1677
1678         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1679         https://bugs.webkit.org/show_bug.cgi?id=194829
1680         <rdar://problem/47889906>
1681
1682         Reviewed by Alexey Proskuryakov.
1683
1684         Every time the TestOptions were changing we were creating both a new Web view and
1685         a new WKContext, which would start a new Network process. In most cases, we only
1686         need to contruct a new Web view and we do can keep reusing the same WKContext.
1687         This patch implements this optimization and thus avoids spinning a lot of new
1688         Network processes while running the layout tests.
1689
1690         * WebKitTestRunner/TestController.cpp:
1691         (WTR::TestController::generateContextConfiguration const):
1692         (WTR::TestController::generatePageConfiguration):
1693         (WTR::TestController::createWebViewWithOptions):
1694         (WTR::TestController::resetPreferencesToConsistentValues):
1695         (WTR::updateTestOptionsFromTestHeader):
1696         * WebKitTestRunner/TestController.h:
1697         * WebKitTestRunner/TestOptions.h:
1698         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1699         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1700         (WTR::TestOptions::hasSameInitializationOptions const):
1701         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1702         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1703         (WTR::TestController::platformAddTestOptions const):
1704
1705 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1706
1707         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1708         https://bugs.webkit.org/show_bug.cgi?id=167941
1709
1710         Reviewed by Carlos Garcia Campos.
1711
1712         * MiniBrowser/gtk/main.c:
1713         (filterSavedCallback): Added.
1714         (main): Support loading a JSON rule set file for content filtering.
1715         * MiniBrowser/wpe/main.cpp:
1716         (filterSavedCallback): Added.
1717         (main): Support loading a JSON rule set file for content filtering.
1718         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1719         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1720         (WTF::derefGPtr): Ditto.
1721         (testEmptyStore):
1722         (testSaveInvalidFilter):
1723         (testSaveLoadFilter):
1724         (testSavedFilterIdentifierMatch):
1725         (testRemoveFilter):
1726         (testSaveMultipleFilters):
1727         (testSaveFilterFromFile):
1728         (testFilterPersistence):
1729         (beforeAll):
1730         (afterAll):
1731         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1732         (removeOldInjectedContentAndResetLists): Also reset content filters.
1733         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1734         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1735         the element affected by the style sheet.
1736         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1737         and returns it to be used by tests.
1738         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1739         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1740         (serverCallback): Add support for serving a CSS style sheet for testing.
1741         (beforeAll): Add call to testUserContentManagerContentFilter().
1742         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1743
1744 2019-02-19  Keith Rollin  <krollin@apple.com>
1745
1746         Add timing information to build output
1747         https://bugs.webkit.org/show_bug.cgi?id=194839
1748         <rdar://problem/48219609>
1749
1750         Reviewed by Alexey Proskuryakov.
1751
1752         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1753         emit each project's build time to its output. E.g.,
1754
1755             ** BUILD SUCCEEDED ** [0.132 sec]
1756
1757         * Scripts/webkitdirs.pm:
1758         (XcodeOptions):
1759
1760 2019-02-19  Truitt Savell  <tsavell@apple.com>
1761
1762         Unreviewed, rolling out r241784.
1763
1764         Broke all OpenSource builds.
1765
1766         Reverted changeset:
1767
1768         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1769         instances view"
1770         https://bugs.webkit.org/show_bug.cgi?id=172848
1771         https://trac.webkit.org/changeset/241784
1772
1773 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1774
1775         [LFC][Floats] Remove redundant intersecting logic
1776         https://bugs.webkit.org/show_bug.cgi?id=194804
1777
1778         Reviewed by Antti Koivisto.
1779
1780         * LayoutReloaded/misc/LFC-passing-tests.txt:
1781
1782 2019-02-19  Dean Jackson  <dino@apple.com>
1783
1784         Clean-up output from generate-xcfilelists so it can be filtered
1785         https://bugs.webkit.org/show_bug.cgi?id=194795
1786
1787         Reviewed by Joseph Pecoraro (and Keith Rollin).
1788
1789         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1790         make a slight tweak to filter-build-webkit so such lines are marked
1791         as plain.
1792
1793         * Scripts/filter-build-webkit:
1794         * Scripts/generate-xcfilelists:
1795
1796 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1797
1798         pytest is not correctly auto-installed
1799         https://bugs.webkit.org/show_bug.cgi?id=194707
1800
1801         Reviewed by Carlos Garcia Campos.
1802
1803         * Scripts/webkitpy/thirdparty/__init__.py:
1804         (AutoinstallImportHook._install_pytest):
1805
1806 2019-02-18  Chris Dumez  <cdumez@apple.com>
1807
1808         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1809         https://bugs.webkit.org/show_bug.cgi?id=194797
1810         <rdar://problem/48055151>
1811
1812         Reviewed by Geoffrey Garen.
1813
1814         Add API test coverage.
1815
1816         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1817
1818 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1819
1820         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1821         https://bugs.webkit.org/show_bug.cgi?id=194670
1822         <rdar://problem/39066529>
1823
1824         Reviewed by Tim Horton.
1825
1826         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1827         pasted in an editable area as attachment elements.
1828
1829         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1830         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1831         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1832         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1833         (TestWebKitAPI::TEST):
1834         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1835         (WTR::InjectedBundlePage::InjectedBundlePage):
1836
1837 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1838
1839         Fix API test after r241728
1840        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1841
1842         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1843         (TEST):
1844         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1845
1846 2019-02-18  Daniel Bates  <dabates@apple.com>
1847
1848         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1849         https://bugs.webkit.org/show_bug.cgi?id=192824
1850         <rdar://problem/47100332>
1851
1852         Reviewed by Wenson Hsieh.
1853
1854         Fix a bug where the wrong usage code was used for F13 thru F24.
1855
1856         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1857         (keyCodeForDOMFunctionKey):
1858
1859 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1860
1861         Bytecode cache should a have a boot-specific validation
1862         https://bugs.webkit.org/show_bug.cgi?id=194769
1863         <rdar://problem/48149509>
1864
1865         Reviewed by Keith Miller.
1866
1867         Add test for WTF::bootSessionUUIDString()
1868
1869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1870         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1871         (TEST):
1872
1873 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1874
1875         Disable safe browsing in WKWebView and remove its WKPreferences API
1876         https://bugs.webkit.org/show_bug.cgi?id=194723
1877         <rdar://problem/48122993>
1878
1879         Reviewed by Geoffrey Garen.
1880
1881         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1882         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1883         (TEST):
1884         (safeBrowsingView):
1885         Make tests use SPI instead of API.
1886
1887 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1888
1889         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1890         https://bugs.webkit.org/show_bug.cgi?id=194586
1891
1892         Reviewed by Ross Kirsling.
1893
1894         * DumpRenderTree/win/DumpRenderTree.cpp:
1895         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1896         * Scripts/webkitpy/port/driver.py:
1897         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1898
1899 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1900
1901         Unreviewed, rolling out r241620.
1902
1903         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1904         (Requested by ddkilzer on #webkit.)
1905
1906         Reverted changeset:
1907
1908         "[WTF] Add environment variable helpers"
1909         https://bugs.webkit.org/show_bug.cgi?id=192405
1910         https://trac.webkit.org/changeset/241620
1911
1912 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1913
1914         [LFC] RenderImage's default intrinsic size is 0.
1915         https://bugs.webkit.org/show_bug.cgi?id=194745
1916
1917         Reviewed by Antti Koivisto.
1918
1919         * LayoutReloaded/misc/LFC-passing-tests.txt:
1920
1921 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1922
1923         [LFC][BFC] Add support for block replaced intrinsic width.
1924         https://bugs.webkit.org/show_bug.cgi?id=194705
1925
1926         Reviewed by Simon Fraser.
1927
1928         * LayoutReloaded/misc/LFC-passing-tests.txt:
1929
1930 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1931
1932         [LFC] Apply min/max width constraints to preferred width computation
1933         https://bugs.webkit.org/show_bug.cgi?id=194739
1934
1935         Reviewed by Simon Fraser.
1936
1937         * LayoutReloaded/misc/LFC-passing-tests.txt:
1938
1939 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1940
1941         [WTF] Add environment variable helpers
1942         https://bugs.webkit.org/show_bug.cgi?id=192405
1943
1944         Reviewed by Michael Catanzaro.
1945
1946         * DumpRenderTree/mac/DumpRenderTree.mm:
1947         (libraryPathForDumpRenderTree):
1948         * DumpRenderTree/win/DumpRenderTree.cpp:
1949         (libraryPathForDumpRenderTree):
1950         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1951         (setUpIOSLayoutTestCommunication):
1952         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1953         (beforeAll):
1954         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1955         (main):
1956         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1957         (WebKitTestBus::run):
1958         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1959         (WTR::getOutputDir):
1960         (WTR::initializeFontConfigSetting):
1961         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1962         (WTR::InjectedBundle::platformInitialize):
1963         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1964         (WTR::topLevelPath):
1965         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1966         (WTR::topLevelPath):
1967         (WTR::getOutputDir):
1968         (WTR::activateFonts):
1969         * WebKitTestRunner/TestController.cpp:
1970         (WTR::TestController::libraryPathForTesting):
1971         (WTR::TestController::generateContextConfiguration const):
1972         (WTR::TestController::generatePageConfiguration):
1973         (WTR::TestController::decideDestinationWithSuggestedFilename):
1974         (WTR::TestController::platformAdjustContext):
1975         * WebKitTestRunner/TestController.h:
1976         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1977         (WTR::TestController::cocoaPlatformInitialize):
1978         (WTR::TestController::platformAdjustContext):
1979         * WebKitTestRunner/gtk/main.cpp:
1980         (main):
1981         * WebKitTestRunner/mac/TestControllerMac.mm:
1982         (WTR::TestController::configureContentExtensionForTest):
1983         * WebKitTestRunner/wpe/main.cpp:
1984         (main):
1985         Utilize WTF::Environment where possible.
1986
1987 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1988
1989         [iOS] WKWebView callout bar is missing Change Writing Direction item
1990         https://bugs.webkit.org/show_bug.cgi?id=190015
1991         <rdar://problem/44810366>
1992
1993         Reviewed by Tim Horton.
1994
1995         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1996         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1997
1998         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1999         (TestWebKitAPI::TEST):
2000
2001 2019-02-15  Chris Dumez  <cdumez@apple.com>
2002
2003         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
2004         https://bugs.webkit.org/show_bug.cgi?id=194717
2005         <rdar://problem/47884404>
2006
2007         Reviewed by Brady Eidson.
2008
2009         Add API test coverage.
2010
2011         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2012
2013 2019-02-15  Youenn Fablet  <youenn@apple.com>
2014
2015         Make navigator.mediaDevices SecureContext
2016         https://bugs.webkit.org/show_bug.cgi?id=194666
2017
2018         Reviewed by Eric Carlson.
2019
2020         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2021         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2022         (TEST_F):
2023
2024 2019-02-15  Brian Burg  <bburg@apple.com>
2025
2026         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2027         https://bugs.webkit.org/show_bug.cgi?id=194411
2028         <rdar://problem/47787614>
2029
2030         Reviewed by Joseph Pecoraro.
2031
2032         Remove unnecessary soft linking macro usage.
2033
2034         * DumpRenderTree/mac/TestRunnerMac.mm:
2035         (TestRunner::inspectorTestStubURL):
2036         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2037         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2038         (WTR::TestRunner::inspectorTestStubURL):
2039
2040 2019-02-15  Commit Queue  <commit-queue@webkit.org>
2041
2042         Unreviewed, rolling out r241559 and r241566.
2043         https://bugs.webkit.org/show_bug.cgi?id=194710
2044
2045         Causes layout test crashes under GuardMalloc (Requested by
2046         ryanhaddad on #webkit).
2047
2048         Reverted changesets:
2049
2050         "[WTF] Add environment variable helpers"
2051         https://bugs.webkit.org/show_bug.cgi?id=192405
2052         https://trac.webkit.org/changeset/241559
2053
2054         "Unreviewed build fix for WinCairo Debug after r241559."
2055         https://trac.webkit.org/changeset/241566
2056
2057 2019-02-15  Zalan Bujtas  <zalan@apple.com>
2058
2059         [LFC] Out-of-flow box is never a float box
2060         https://bugs.webkit.org/show_bug.cgi?id=194704
2061
2062         Reviewed by Antti Koivisto.
2063
2064         * LayoutReloaded/misc/LFC-passing-tests.txt:
2065
2066 2019-02-10  Darin Adler  <darin@apple.com>
2067
2068         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
2069         https://bugs.webkit.org/show_bug.cgi?id=194487
2070
2071         Reviewed by Daniel Bates.
2072
2073         * DumpRenderTree/win/DumpRenderTree.cpp:
2074         (applicationId): Use makeString instead of String::format.
2075         (main): Ditto.
2076         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2077         (TestWebKitAPI::Util::createURLForResource): Ditto.
2078         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2079         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
2080
2081         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2082         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
2083         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
2084         (WTR::createStringWithAttributes): Use appendLiteral.
2085         (WTR::AccessibilityUIElement::helpText const): Ditto.
2086         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
2087         directly instead of using String::format.
2088         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
2089         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
2090
2091 2019-02-15  Truitt Savell  <tsavell@apple.com>
2092
2093         Unreviewed, rolling out r241564.
2094
2095         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
2096
2097         Reverted changeset:
2098
2099         "[Mac] WebInspectorUI.framework does not need to be soft-
2100         linked anymore"
2101         https://bugs.webkit.org/show_bug.cgi?id=194411
2102         https://trac.webkit.org/changeset/241564
2103
2104 2019-02-15  Saam barati  <sbarati@apple.com>
2105
2106         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
2107         https://bugs.webkit.org/show_bug.cgi?id=194036
2108
2109         Reviewed by Yusuke Suzuki.
2110
2111         * Scripts/run-jsc-stress-tests:
2112
2113 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2114
2115         Fix the build.
2116
2117         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2118         (WTR::UIScriptController::drawSquareInEditableImage):
2119         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2120         (TestWebKitAPI::drawSquareInEditableImage):
2121
2122 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2123
2124         Fix the build.
2125
2126         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2127         (WTR::UIScriptController::drawSquareInEditableImage):
2128         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2129         (TestWebKitAPI::drawSquareInEditableImage):
2130
2131 2019-02-14  Brian Burg  <bburg@apple.com>
2132
2133         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2134         https://bugs.webkit.org/show_bug.cgi?id=194411
2135         <rdar://problem/47787614>
2136
2137         Reviewed by Joseph Pecoraro.
2138
2139         Remove unnecessary soft linking macro usage.
2140
2141         * DumpRenderTree/mac/TestRunnerMac.mm:
2142         (TestRunner::inspectorTestStubURL):
2143         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2144         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2145         (WTR::TestRunner::inspectorTestStubURL):
2146
2147 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2148
2149         [ews-app] status bubble should fetch builder name info from BuilderMapping table
2150         https://bugs.webkit.org/show_bug.cgi?id=194599
2151
2152         Reviewed by Lucas Forschler.
2153
2154         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2155         (StatusBubble._build_bubble):
2156
2157 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2158
2159         [ews-app] Set Foreign Key in Django build model
2160         https://bugs.webkit.org/show_bug.cgi?id=194667
2161
2162         Reviewed by Lucas Forschler.
2163
2164         * BuildSlaveSupport/ews-app/ews/models/build.py:
2165         (Build):
2166
2167 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
2168
2169         [WTF] Add environment variable helpers
2170         https://bugs.webkit.org/show_bug.cgi?id=192405
2171
2172         Reviewed by Michael Catanzaro.
2173
2174         * DumpRenderTree/mac/DumpRenderTree.mm:
2175         (libraryPathForDumpRenderTree):
2176         * DumpRenderTree/win/DumpRenderTree.cpp:
2177         (libraryPathForDumpRenderTree):
2178         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2179         (setUpIOSLayoutTestCommunication):
2180         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2181         (TestWebKitAPI::strip):
2182         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2183         (beforeAll):
2184         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2185         (main):
2186         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2187         (WebKitTestBus::run):
2188         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2189         (WTR::getOutputDir):
2190         (WTR::initializeFontConfigSetting):
2191         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2192         (WTR::InjectedBundle::platformInitialize):
2193         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2194         (WTR::topLevelPath):
2195         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2196         (WTR::topLevelPath):
2197         (WTR::getOutputDir):
2198         (WTR::activateFonts):
2199         * WebKitTestRunner/TestController.cpp:
2200         (WTR::TestController::libraryPathForTesting):
2201         (WTR::TestController::generateContextConfiguration const):
2202         (WTR::TestController::generatePageConfiguration):
2203         (WTR::TestController::decideDestinationWithSuggestedFilename):
2204         (WTR::TestController::platformAdjustContext):
2205         * WebKitTestRunner/TestController.h:
2206         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2207         (WTR::TestController::cocoaPlatformInitialize):
2208         (WTR::TestController::platformAdjustContext):
2209         * WebKitTestRunner/gtk/main.cpp:
2210         (main):
2211         * WebKitTestRunner/mac/TestControllerMac.mm:
2212         (WTR::TestController::configureContentExtensionForTest):
2213         * WebKitTestRunner/wpe/main.cpp:
2214         (main):
2215         Utilize WTF::Environment where possible.
2216
2217 2019-02-14  Chris Dumez  <cdumez@apple.com>
2218
2219         [PSON] Introduce a WebContent Process cache
2220         https://bugs.webkit.org/show_bug.cgi?id=194594
2221         <rdar://problem/46793397>
2222
2223         Reviewed by Geoff Garen.
2224
2225         Update API tests to turn on the WebContent Process cache.
2226
2227         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2228
2229 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
2230
2231         Unreviewed, build fix after r241480
2232
2233         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2234         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2235         (-[DragAndDropSimulator initWithWebView:]):
2236
2237 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
2238
2239         AX: ARIA Reflection was disabled in error
2240         https://bugs.webkit.org/show_bug.cgi?id=194647
2241         <rdar://problem/48068336>
2242
2243         Reviewed by Ryosuke Niwa.
2244
2245         Remove test override now that this feature should be enabled by default.
2246
2247         * WebKitTestRunner/TestController.cpp:
2248         (WTR::TestController::resetPreferencesToConsistentValues):
2249
2250 2019-02-14  Commit Queue  <commit-queue@webkit.org>
2251
2252         Unreviewed, rolling out r241486.
2253         https://bugs.webkit.org/show_bug.cgi?id=194655
2254
2255         causing API failures in builds (Requested by ShawnRoberts on
2256         #webkit).
2257
2258         Reverted changeset:
2259
2260         "[Cocoa] Media elements will restart network buffering just
2261         before suspending"
2262         https://bugs.webkit.org/show_bug.cgi?id=193691
2263         https://trac.webkit.org/changeset/241486
2264
2265 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2266
2267         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
2268         https://bugs.webkit.org/show_bug.cgi?id=194622
2269
2270         Reviewed by Antti Koivisto.
2271
2272         * LayoutReloaded/misc/LFC-passing-tests.txt:
2273
2274 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2275
2276         [LFC] Shrink-to-fit-width should be constrained by min/max width
2277         https://bugs.webkit.org/show_bug.cgi?id=194653
2278
2279         Reviewed by Antti Koivisto.
2280
2281         * LayoutReloaded/misc/LFC-passing-tests.txt:
2282
2283 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2284
2285         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
2286         https://bugs.webkit.org/show_bug.cgi?id=194641
2287
2288         Reviewed by Geoffrey Garen.
2289
2290         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
2291         so that the test would fail without this fix.
2292
2293         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2294         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2295
2296 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2297
2298         [ews-app] Change log level for a log statement
2299
2300         Unreviewed minor fix.
2301
2302         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2303         (Patch.save_patch):
2304
2305 2019-02-13  Jer Noble  <jer.noble@apple.com>
2306
2307         [Cocoa] Media elements will restart network buffering just before suspending
2308         https://bugs.webkit.org/show_bug.cgi?id=193691
2309
2310         Reviewed by Eric Carlson.
2311
2312         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2313         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2314         (TEST):
2315
2316 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2317
2318         [ews-app] Fetch builder id to name mapping
2319         https://bugs.webkit.org/show_bug.cgi?id=194355
2320
2321         Reviewed by Lucas Forschler.
2322
2323         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2324         (Buildbot.get_builder_id_to_name_mapping):
2325         (Buildbot._get_display_name_from_builder_name):
2326
2327 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
2328
2329         Further restricting webarchive loads
2330         https://bugs.webkit.org/show_bug.cgi?id=194567
2331         <rdar://problem/47610130>
2332
2333         Reviewed by Youenn Fablet.
2334
2335         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
2336         navigations on drop.
2337
2338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2339         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
2340         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
2341         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2342         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2343         (TestWebKitAPI::TEST):
2344         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
2345         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
2346         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
2347         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2348         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2349         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2350         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
2351
2352 2019-02-13  John Wilander  <wilander@apple.com>
2353
2354         Store Ad Click Attribution requests in the network process
2355         https://bugs.webkit.org/show_bug.cgi?id=194510
2356         <rdar://problem/47650118>
2357
2358         Reviewed by Alex Christensen and Daniel Bates.
2359
2360         This patch adds two TestRunner functions:
2361         - dumpAdClickAttribution()
2362         - clearAdClickAttribution()
2363
2364         They call into the network process to dump and clear Ad Click
2365         Attribution state, respectively.
2366
2367         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2368         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2369         (WTR::TestRunner::dumpAdClickAttribution):
2370         (WTR::TestRunner::clearAdClickAttribution):
2371         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2372         * WebKitTestRunner/TestController.cpp:
2373         (WTR::TestController::resetStateToConsistentValues):
2374         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2375         (WTR::adClickAttributionStringResultCallback):
2376         (WTR::TestController::dumpAdClickAttribution):
2377         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2378         (WTR::adClickAttributionVoidCallback):
2379         (WTR::TestController::clearAdClickAttribution):
2380         * WebKitTestRunner/TestController.h:
2381         * WebKitTestRunner/TestInvocation.cpp:
2382         (WTR::TestInvocation::dumpResults):
2383         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2384         (WTR::TestInvocation::dumpAdClickAttribution):
2385         * WebKitTestRunner/TestInvocation.h:
2386
2387 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2388
2389         [ews-app] Generate status-bubble
2390         https://bugs.webkit.org/show_bug.cgi?id=194572
2391
2392         Reviewed by Lucas Forschler.
2393
2394         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2395         (StatusBubble._build_bubble):
2396         (StatusBubble._should_show_bubble_for):
2397         (StatusBubble._build_bubbles_for_patch):
2398
2399 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2400
2401         [ews-app] Add status bubble html template
2402         https://bugs.webkit.org/show_bug.cgi?id=194571
2403
2404         Reviewed by Lucas Forschler.
2405
2406         * BuildSlaveSupport/ews-app/ews/templates: Added.
2407         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2408
2409 2019-02-12  Chris Dumez  <cdumez@apple.com>
2410
2411         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2412         https://bugs.webkit.org/show_bug.cgi?id=194568
2413         <rdar://problem/47944490>
2414
2415         Reviewed by Ryosuke Niwa.
2416
2417         Add API test coverage.
2418
2419         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2420         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2421
2422 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2423
2424         webkitpy: Remove bug_dummy from parsed test expectations
2425         https://bugs.webkit.org/show_bug.cgi?id=194562
2426         <rdar://problem/47853999>
2427
2428         Reviewed by Lucas Forschler.
2429
2430         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2431         (TestExpectationParser):
2432         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2433         skipped tests.
2434         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2435
2436 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2437
2438         [ews-app] Add method to fetch patch
2439         https://bugs.webkit.org/show_bug.cgi?id=194518
2440
2441         Reviewed by Lucas Forschler.
2442
2443         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2444         (Patch.get_patch):
2445
2446 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2447
2448         [LFC] Expand tests coverage (60 new tests -> 860)
2449
2450         Unreviewed test gardening (run-singly, --child-processes=1).
2451
2452         * LayoutReloaded/misc/LFC-passing-tests.txt:
2453
2454 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2455
2456         Allow pages to trigger programmatic paste from script on iOS
2457         https://bugs.webkit.org/show_bug.cgi?id=194271
2458         <rdar://problem/47808810>
2459
2460         Reviewed by Tim Horton.
2461
2462         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2463
2464         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2465         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2466         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2467         (WTR::UIScriptController::rectForMenuAction const):
2468
2469         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2470         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2471         for when the menu is shown or hidden.
2472
2473         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2474         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2475         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2476         (WTR::UIScriptController::setDidShowMenuCallback):
2477         (WTR::UIScriptController::didShowMenuCallback const):
2478         (WTR::UIScriptController::setDidHideMenuCallback):
2479         (WTR::UIScriptController::didHideMenuCallback const):
2480         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2481         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2482         (WTR::UIScriptController::rectForMenuAction const):
2483         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2484         * WebKitTestRunner/TestController.cpp:
2485         (WTR::TestController::resetPreferencesToConsistentValues):
2486         (WTR::updateTestOptionsFromTestHeader):
2487         * WebKitTestRunner/TestOptions.h:
2488
2489         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2490         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2491
2492         (WTR::TestOptions::hasSameInitializationOptions const):
2493         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2494         (WTR::UIScriptController::calendarType const):
2495         (WTR::UIScriptController::platformUndoManager const):
2496         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2497         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2498         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2499         (-[TestRunnerWKWebView dealloc]):
2500         (-[TestRunnerWKWebView _didShowMenu]):
2501         (-[TestRunnerWKWebView _didHideMenu]):
2502
2503         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2504
2505         * WebKitTestRunner/ios/TestControllerIOS.mm:
2506         (WTR::handleMenuWillHideNotification):
2507         (WTR::handleMenuDidHideNotification):
2508         (WTR::TestController::platformInitialize):
2509         (WTR::TestController::platformDestroy):
2510         (WTR::TestController::platformResetStateToConsistentValues):
2511
2512         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2513         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2514
2515         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2516         (WTR::forEachViewInHierarchy):
2517         (WTR::findViewInHierarchyOfType):
2518
2519         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2520         functions that dig through a given view's hierarchy in search of a view of a given class.
2521
2522         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2523         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2524         (WTR::UIScriptController::selectionCaretViewRect const):
2525         (WTR::UIScriptController::selectionRangeViewRects const):
2526         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2527         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2528
2529         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2530
2531         (WTR::UIScriptController::rectForMenuAction const):
2532
2533         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2534         callout bar) whose label matches the given string.
2535
2536         (WTR::UIScriptController::platformContentView const):
2537
2538         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2539         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2540         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2541
2542         (WTR::UIScriptController::platformUndoManager const): Deleted.
2543         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2544         (WTR::UIScriptController::platformContentView const):
2545         (WTR::UIScriptController::platformUndoManager const): Deleted.
2546
2547 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2548
2549         webkitpy: No option to only show unexpected failures in results.html for iPad
2550         https://bugs.webkit.org/show_bug.cgi?id=194554
2551         <rdar://problem/47922442>
2552
2553         Rubber-stamped by Aakash Jain.
2554
2555         Just because a TestExpecations file does not exist for a specific platform does not mean that
2556         TestExpecations are not being used, given that platforms inherit test expectations.
2557
2558         * Scripts/webkitpy/port/base.py:
2559         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2560         * Scripts/webkitpy/port/base_unittest.py:
2561         (PortTest.test_uses_test_expectations_file):
2562
2563 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2564
2565         Remove setDefersLoading infrastructure from WebKit2
2566         https://bugs.webkit.org/show_bug.cgi?id=194506
2567
2568         Reviewed by Brady Eidson.
2569
2570         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2571         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2572         (WTR::TestRunner::setDefersLoading): Deleted.
2573         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2574
2575 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2576
2577         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2578         https://bugs.webkit.org/show_bug.cgi?id=194522
2579         <rdar://problem/47789393>
2580
2581         Reviewed by Chris Dumez.
2582
2583         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2584         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2585         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2586         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2587
2588 2019-02-12  Andy Estes  <aestes@apple.com>
2589
2590         [iOSMac] Enable Parental Controls Content Filtering
2591         https://bugs.webkit.org/show_bug.cgi?id=194521
2592         <rdar://39732376>
2593
2594         Reviewed by Tim Horton.
2595
2596         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2597
2598 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2599
2600         [LFC][IFC] Add intrinsic width support for float boxes.
2601         https://bugs.webkit.org/show_bug.cgi?id=194528
2602
2603         Reviewed by Antti Koivisto.
2604
2605         Expand tests coverage (2 new tests -> 800).
2606         (This is the correct test ordering --runs-singly --child-processes=1)
2607
2608         * LayoutReloaded/misc/LFC-passing-tests.txt:
2609
2610 2019-02-12  Rob Buis  <rbuis@igalia.com>
2611
2612         Implement serializing in MIME type parser
2613         https://bugs.webkit.org/show_bug.cgi?id=193909
2614
2615         Reviewed by Darin Adler.
2616
2617         Add various tests involving upper case, non-ASCII, control/null characters,
2618         various HTTP whitespace, single quotes and an unpaired surrogate.
2619
2620         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2621         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2622         (TestWebKitAPI::serializeIfValid):
2623         (TestWebKitAPI::TEST):
2624
2625 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2626
2627         [Cocoa] Ask platform for generic font family mappings
2628         https://bugs.webkit.org/show_bug.cgi?id=187723
2629         <rdar://problem/41892438>
2630
2631         Reviewed by Brent Fulgham.
2632
2633         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2634
2635         * DumpRenderTree/mac/DumpRenderTree.mm:
2636         (allowedFontFamilySet):
2637         * WebKitTestRunner/mac/TestControllerMac.mm:
2638         (WTR::allowedFontFamilySet):
2639
2640 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2641
2642         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2643         https://bugs.webkit.org/show_bug.cgi?id=193622
2644
2645         Reviewed by Michael Catanzaro.
2646
2647         This adds support for loading content extension rule sets from the JSON files which
2648         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2649         of WKTR for this could be removed, but that is left for a follow-up patch with
2650         cleanups.
2651
2652         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2653         * WebKitTestRunner/TestController.cpp:
2654         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2655         avoid having the null-terminator copied into the result.
2656         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2657         part of the preparations to run a test.
2658         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2659         (WTR::contentExtensionStoreCallback): Added.
2660         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2661         used for content extensions test.
2662         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2663         extensions and compiling the JSON rule set for tests involving content extensions.
2664         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2665         testing and disables content extensions.
2666         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2667         resetContentExtensions().
2668         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2669         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2670         configureContentExtensionForTest(), and userContentController().
2671
2672 2019-02-11  Daniel Bates  <dabates@apple.com>
2673
2674         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2675         https://bugs.webkit.org/show_bug.cgi?id=191446
2676         <rdar://problem/45929460>
2677
2678         Reviewed by Tim Horton.
2679
2680         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2681
2682         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2683         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2684         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2685         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2686         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2687         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2688         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2689         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2690         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2691         (WTR::arrayLength):
2692         (WTR::parseModifierArray):
2693         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2694         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2695         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2696         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2697
2698 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2699
2700         Unreviewed, rolling out r241272 and r241276.
2701         https://bugs.webkit.org/show_bug.cgi?id=194514
2702
2703         Broke the Apple Internal build and the fix requires human
2704         intervention :( (Requested by dydz on #webkit).
2705
2706         Reverted changesets:
2707
2708         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2709         https://bugs.webkit.org/show_bug.cgi?id=191446
2710         https://trac.webkit.org/changeset/241272
2711
2712         "Fix internal iOS build after r241272"
2713         https://bugs.webkit.org/show_bug.cgi?id=191446
2714         https://trac.webkit.org/changeset/241276
2715
2716 2019-02-11  Truitt Savell  <tsavell@apple.com>
2717
2718         Unreviewed, rolling out r241269.
2719
2720         Caused 5 layout tests crashes on Mac WK1
2721
2722         Reverted changeset:
2723
2724         "DumpRenderTree should report unknown options"
2725         https://bugs.webkit.org/show_bug.cgi?id=191303
2726         https://trac.webkit.org/changeset/241269
2727
2728 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2729
2730         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2731         https://bugs.webkit.org/show_bug.cgi?id=194313
2732
2733         Reviewed by Tim Horton.
2734
2735         Add a helper to determine whether the web view is presenting modal UI.
2736
2737         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2738         (WTR::UIScriptController::isPresentingModally const):
2739         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2740         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2741         (WTR::UIScriptController::isPresentingModally const):
2742         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2743         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2744         (WTR::UIScriptController::calendarType const): Deleted.
2745         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2746         (WTR::UIScriptController::isPresentingModally const):
2747         (WTR::UIScriptController::calendarType const):
2748         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2749         (WTR::UIScriptController::calendarType const):
2750
2751 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2752
2753         GCHeapInspector: Show the retained sizes in more places
2754         https://bugs.webkit.org/show_bug.cgi?id=194464
2755
2756         Reviewed by Simon Fraser.
2757
2758         * GCHeapInspector/gc-heap-inspector.html:
2759         * GCHeapInspector/script/interface.js:
2760         (HeapInspectorUtils.humanReadableSize):
2761         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2762         (HeapInspectorUtils.spanForNode.span.span):
2763         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2764         (HeapSnapshotInspector.prototype.buildRoots):
2765
2766 2019-02-11  Daniel Bates  <dabates@apple.com>
2767
2768         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2769         https://bugs.webkit.org/show_bug.cgi?id=191446
2770         <rdar://problem/45929460>
2771
2772         Reviewed by Tim Horton.
2773
2774         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2775
2776         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2777         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2778         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2779         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2780         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2781         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2782         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2783         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2784         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2785         (WTR::arrayLength):
2786         (WTR::parseModifierArray):
2787         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2788         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2789         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2790         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2791
2792 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2793
2794         DumpRenderTree should report unknown options
2795         https://bugs.webkit.org/show_bug.cgi?id=191303
2796
2797         Reviewed by Frédéric Wang.
2798
2799         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2800         to report unknown options.
2801         Added and assigned test options which are currently used in tests.
2802
2803         * DumpRenderTree/TestOptions.cpp:
2804         (TestOptions::TestOptions):
2805
2806 2019-02-11  Truitt Savell  <tsavell@apple.com>
2807
2808         Unreviewed, rolling out r241229.
2809
2810         Revision broke internal builds for watchOS.
2811
2812         Reverted changeset:
2813
2814         "[Cocoa] Ask platform for generic font family mappings"
2815         https://bugs.webkit.org/show_bug.cgi?id=187723
2816         https://trac.webkit.org/changeset/241229
2817
2818 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2819
2820         [WinCairo][MiniBrowser] Basic authentication always fails.
2821         https://bugs.webkit.org/show_bug.cgi?id=194496
2822
2823         Reviewed by Don Olmstead.
2824
2825         * MiniBrowser/win/DialogHelper.h:
2826         (Dialog::getText):
2827
2828 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2829
2830         [GStreamer] GstMappedBuffer testsuite build fails
2831         https://bugs.webkit.org/show_bug.cgi?id=194495
2832
2833         Reviewed by Carlos Garcia Campos.
2834
2835         Fix the build by explicitely adding the gstreamer1.0-audio include
2836         directories to the include path.
2837
2838         * TestWebKitAPI/PlatformGTK.cmake:
2839         * TestWebKitAPI/PlatformWPE.cmake:
2840
2841 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2842
2843         [GTK][WPE] Add enable-javascript-markup setting
2844         https://bugs.webkit.org/show_bug.cgi?id=193439
2845
2846         Reviewed by Michael Catanzaro.
2847
2848         Add test cases to check the new setting.
2849
2850         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2851         (testWebKitSettings):
2852         (testWebKitSettingsJavaScriptMarkup):
2853         (beforeAll):
2854
2855 2019-02-10  Darin Adler  <darin@apple.com>
2856
2857         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2858         https://bugs.webkit.org/show_bug.cgi?id=194485
2859
2860         Reviewed by Daniel Bates.
2861
2862         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2863
2864 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2865
2866         Add more tests for clampTo<>()
2867         https://bugs.webkit.org/show_bug.cgi?id=194462
2868
2869         Reviewed by Geoffrey Garen.
2870
2871         Darin suggested to test the very last floating point number
2872         at the boundaries when truncating to integer.
2873         I added test for max/min and max-1/min-1.
2874
2875         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2876         (TestWebKitAPI::TEST):
2877
2878 2019-02-09  Darin Adler  <darin@apple.com>
2879
2880         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2881         https://bugs.webkit.org/show_bug.cgi?id=194021
2882
2883         Reviewed by Geoffrey Garen.
2884
2885         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2886         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2887         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2888
2889 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2890
2891         [LFC][IFC] Add intrinsic width support for basic inline containers
2892         https://bugs.webkit.org/show_bug.cgi?id=194473
2893
2894         Reviewed by Antti Koivisto.
2895
2896         Expand tests coverage (11 new tests -> 798)
2897
2898         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2899
2900 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2901
2902         Fix MiniBrowser's entitlements
2903         https://bugs.webkit.org/show_bug.cgi?id=192431
2904
2905         Reviewed by Joseph Pecoraro.
2906
2907         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2908         files, making it impossible to load any extension.
2909
2910         * MiniBrowser/MiniBrowser.entitlements:
2911
2912 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2913
2914         [Cocoa] Ask platform for generic font family mappings
2915         https://bugs.webkit.org/show_bug.cgi?id=187723
2916         <rdar://problem/41892438>
2917
2918         Reviewed by Brent Fulgham.
2919
2920         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2921
2922         * DumpRenderTree/mac/DumpRenderTree.mm:
2923         (allowedFontFamilySet):
2924         * WebKitTestRunner/mac/TestControllerMac.mm:
2925         (WTR::allowedFontFamilySet):
2926
2927 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2928
2929         [GTK] Implement back/forward touchpad gesture
2930         https://bugs.webkit.org/show_bug.cgi?id=193919
2931
2932         Reviewed by Michael Catanzaro.
2933
2934         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2935         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2936
2937 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2938
2939         Add SPI to use networking daemon instead of XPC service
2940         https://bugs.webkit.org/show_bug.cgi?id=194427
2941
2942         Reviewed by Geoffrey Garen
2943
2944         * MiniBrowser/MiniBrowser.entitlements:
2945
2946 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2947
2948         [ews-build] Ensure that every builder in config.json has short name
2949         https://bugs.webkit.org/show_bug.cgi?id=194461
2950
2951         Reviewed by Lucas Forschler.
2952
2953         * BuildSlaveSupport/ews-build/loadConfig.py:
2954         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2955
2956 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2957
2958         [ews-build] Add short name to config.json
2959         https://bugs.webkit.org/show_bug.cgi?id=194456
2960
2961         Reviewed by Lucas Forschler.
2962
2963         * BuildSlaveSupport/ews-build/config.json: Added short name.
2964         * BuildSlaveSupport/ews-build/loadConfig.py:
2965         (loadBuilderConfig): Set the short name as the builder description.
2966
2967 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2968
2969         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2970         https://bugs.webkit.org/show_bug.cgi?id=194418
2971
2972         Reviewed by Lucas Forschler.
2973
2974         Do not include errors trying when finding crashlogs at the end of
2975         a run-webkit-tests run since we don't process those errors.
2976
2977         * Scripts/webkitpy/port/darwin.py:
2978         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2979         * Scripts/webkitpy/port/ios_device.py:
2980         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2981         * Scripts/webkitpy/port/watch_device.py:
2982         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2983
2984 2019-02-08  Beth Dakin  <bdakin@apple.com>
2985
2986         Add afterScreenUpdates to WKSnapshotConfiguration
2987         https://bugs.webkit.org/show_bug.cgi?id=194362
2988         -and corresponding-
2989         <rdar://problem/40655528> Please add an "after screen updates" property to 
2990         WKSnapshotConfiguration (to solve blank snapshots)
2991
2992         Reviewed by Tim Horton.
2993
2994         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2995         (TEST):
2996
2997 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2998
2999         clampTo(): do not convert the input to double when dealing with integers
3000         https://bugs.webkit.org/show_bug.cgi?id=194263
3001         <rdar://problem/47692312>
3002
3003         Reviewed by Darin Adler.
3004
3005         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3006         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
3007         (TestWebKitAPI::testClampFloatingPointToInteger):
3008         (TestWebKitAPI::testClampSameSignIntegers):
3009         (TestWebKitAPI::testClampUnsignedToSigned):
3010         (TestWebKitAPI::testClampSignedToUnsigned):
3011
3012 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
3013
3014         webkitpy: Respect --dedicated-simulators flag
3015         https://bugs.webkit.org/show_bug.cgi?id=194416
3016         <rdar://problem/47894722>
3017
3018         Reviewed by Lucas Forschler.
3019
3020         * Scripts/webkitpy/port/device_port.py:
3021         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
3022         available devices can be safely ignored.
3023
3024 2019-02-07  Keith Rollin  <krollin@apple.com>
3025
3026         Remove extra copy of 100x100-red.tga
3027         https://bugs.webkit.org/show_bug.cgi?id=194371
3028         <rdar://problem/47873465>
3029
3030         Reviewed by Said Abou-Hallawa.
3031
3032         In order to help it pass its tests, Bug 194190 added a second copy of
3033         the file 100x100-red.tga. However, it turns out that this additional
3034         file wasn't actually needed, and that that sole previous copy was
3035         sufficient. At the same time, this second copy -- which was copied to
3036         the same location in the build output as the first copy -- now caused
3037         XCBuild to complain because there were two production rules for the
3038         same output file. Address this by removing the newly-added extra copy.
3039
3040         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3041         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
3042
3043 2019-02-07  Alex Christensen  <achristensen@webkit.org>
3044
3045         Deprecate WKBundlePageSetDefersLoading
3046         https://bugs.webkit.org/show_bug.cgi?id=191394
3047
3048         Reviewed by Dean Jackson.
3049
3050         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3051         (WTR::TestRunner::setDefersLoading):
3052
3053 2019-02-07  Zalan Bujtas  <zalan@apple.com>
3054
3055         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
3056         https://bugs.webkit.org/show_bug.cgi?id=194391
3057
3058         Reviewed by Antti Koivisto.
3059
3060         * LayoutReloaded/misc/LFC-passing-tests.txt:
3061
3062 2019-02-06  Keith Rollin  <krollin@apple.com>
3063
3064         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
3065         https://bugs.webkit.org/show_bug.cgi?id=193975
3066         <rdar://problem/47643306>
3067
3068         Reviewed by Tim Horton.
3069
3070         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
3071         the Info.plist file into the bundle. This step is not necessary as the
3072         implicit "bundle up all the build products into a framework" build
3073         phase does this already. Having the Copy Bundle Resources phase do
3074         this causes a conflict under XCBuild, which objects to two build
3075         phases producing the same file (Info.plist). Address this by removing
3076         Info.plist from the Copy Bundle Resources phase.
3077
3078         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3079
3080 2019-02-06  Keith Rollin  <krollin@apple.com>
3081
3082         Really enable the automatic checking and regenerations of .xcfilelists during builds
3083         https://bugs.webkit.org/show_bug.cgi?id=194357
3084         <rdar://problem/47861231>
3085
3086         Reviewed by Chris Dumez.
3087
3088         Bug 194124 was supposed to enable the automatic checking and
3089         regenerating of .xcfilelist files during the build. While related
3090         changes were included in that patch, the change to actually enable the
3091         operation somehow was omitted. This patch actually enables the
3092         operation. The check-xcfilelist.sh scripts now check
3093         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
3094         from the checking.
3095
3096         * DumpRenderTree/Scripts/check-xcfilelists.sh:
3097         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
3098
3099 2019-02-06  David Kilzer  <ddkilzer@apple.com>
3100
3101         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
3102         <https://webkit.org/b/194286>
3103         <rdar://problem/47815558>
3104
3105         Reviewed by Alexey Proskuryakov.
3106
3107         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3108         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
3109         WKRetainPtr<> to avoid leaking the WKDataRef.
3110
3111 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3112
3113         Unreviewed, fix a typo
3114
3115         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3116
3117 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
3118
3119         [GTK][WPE] force libpsl build to use ICU in jhbuild
3120         https://bugs.webkit.org/show_bug.cgi?id=194288
3121
3122         Reviewed by Carlos Garcia Campos.
3123
3124         * gtk/jhbuild.modules:
3125         Require ICU for libpsl build in jhbuild, like done in WPE.
3126
3127 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3128
3129         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
3130         https://bugs.webkit.org/show_bug.cgi?id=194209
3131
3132         Reviewed by Carlos Garcia Campos.
3133
3134         Enhance TestCookieManager to ensure this doesn't happen again.
3135
3136         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3137         (testCookieManagerPersistentStorage):
3138         (beforeAll):
3139
3140 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3141
3142         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
3143         https://bugs.webkit.org/show_bug.cgi?id=194324
3144
3145         Reviewed by Andy Estes.
3146
3147         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
3148         part of the name is already implicit, since this is in testing code in TestOptions.
3149
3150         * WebKitTestRunner/TestController.cpp:
3151         (WTR::TestController::generateContextConfiguration const):
3152         (WTR::updateTestOptionsFromTestHeader):
3153         * WebKitTestRunner/TestOptions.h:
3154         (WTR::TestOptions::hasSameInitializationOptions const):
3155
3156 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3157
3158         [ews-build] Allow * as platform for builders and workers
3159         https://bugs.webkit.org/show_bug.cgi?id=188533
3160
3161         Reviewed by Lucas Forschler.
3162
3163         * BuildSlaveSupport/ews-build/loadConfig.py:
3164         (checkWorkersAndBuildersForConsistency):
3165
3166 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3167
3168         [ews-build] Add few bots to config.json
3169         https://bugs.webkit.org/show_bug.cgi?id=194304
3170
3171         Reviewed by Lucas Forschler.
3172
3173         * BuildSlaveSupport/ews-build/config.json:
3174
3175 2019-02-05  Keith Rollin  <krollin@apple.com>
3176
3177         Enable the automatic checking and regenerations of .xcfilelists during builds
3178         https://bugs.webkit.org/show_bug.cgi?id=194124
3179         <rdar://problem/47721277>
3180
3181         Reviewed by Tim Horton.
3182
3183         Bug 193790 add a facility for checking -- during build time -- that
3184         any needed .xcfilelist files are up-to-date and for updating them if
3185         they are not. This facility was initially opt-in by setting
3186         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
3187         the process seemed robust. Its now time to enable this facility and
3188         make it opt-out. If there is a need to disable this facility, set and
3189         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
3190         running `make` or `build-webkit`, or before running Xcode from the
3191         command line.
3192
3193         Additionally, remove the step that generates a list of source files
3194         going into the UnifiedSources build step. It's only necessarily to
3195         specify Sources.txt and SourcesCocoa.txt as inputs.
3196
3197         * Scripts/generate-xcfilelists:
3198
3199 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3200
3201         [GTK][WPE] force libpsl build to use ICU in jhbuild
3202         https://bugs.webkit.org/show_bug.cgi?id=194288
3203
3204         Reviewed by Philippe Normand.
3205
3206         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
3207         This can cause build failures if libidn is detected but libunistring is not available.
3208
3209         Make sure that ICU is used for runtime and builtin PSL data.
3210
3211         * gtk/jhbuild.modules:
3212         * wpe/jhbuild.modules:
3213
3214 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3215
3216         [ews-app] Modified timestamp should be updated on updating data
3217         https://bugs.webkit.org/show_bug.cgi?id=194295
3218
3219         Reviewed by Lucas Forschler.
3220
3221         * BuildSlaveSupport/ews-app/ews/models/build.py:
3222         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3223         * BuildSlaveSupport/ews-app/ews/models/step.py:
3224
3225 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
3226
3227         Unreviewed, rolling out r240742.
3228
3229         Causes crashes on iOS simulator.
3230
3231         Reverted changeset:
3232
3233         "[iOS] Keyups for non-modifier keys identified as "Dead" when
3234         not focused in a content-editable element"
3235         https://bugs.webkit.org/show_bug.cgi?id=192824
3236         https://trac.webkit.org/changeset/240742
3237
3238 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
3239
3240         run-webkit-tests emits message "...running None" when running tests
3241         https://bugs.webkit.org/show_bug.cgi?id=194133
3242         <rdar://problem/47724738>
3243
3244         Reviewed by Lucas Forschler.
3245
3246         * Scripts/webkitpy/xcode/device_type.py:
3247         (DeviceType.__str__): Use both version mapping tables and use just the variant
3248         name if no version name is available.
3249         * Scripts/webkitpy/xcode/device_type_unittest.py:
3250         (DeviceTypeTest):
3251         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
3252         an associated named.
3253
3254 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3255
3256         [WPE] require python3-setuptools for meson build in jhbuild
3257         https://bugs.webkit.org/show_bug.cgi?id=194287
3258
3259         Reviewed by Philippe Normand.
3260
3261         python3-setuptools is needed to build meson in jhbuild.
3262         It is already required by the GTK port.
3263
3264         * wpe/install-dependencies:
3265
3266 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3267
3268         [ews-app] Add method to save BuilderMapping to database
3269         https://bugs.webkit.org/show_bug.cgi?id=194264
3270
3271         Reviewed by Lucas Forschler.
3272
3273         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3274         (BuilderMapping.__str__):
3275         (BuilderMapping):
3276         (BuilderMapping.save_mapping):
3277         (BuilderMapping.update_mapping):
3278         (BuilderMapping.get_existing_mapping):
3279         (BuilderMapping.is_valid_mapping):
3280
3281 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3282
3283         [ews-app] Add timestamp fields for BuilderMappings
3284         https://bugs.webkit.org/show_bug.cgi?id=194266
3285
3286         Reviewed by Lucas Forschler.
3287
3288         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3289         (BuilderMapping):
3290
3291 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
3292
3293         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3294         https://bugs.webkit.org/show_bug.cgi?id=174816
3295
3296         Reviewed by Michael Catanzaro.
3297
3298         Add tests for webkit_uri_for_display().
3299
3300         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3301         (testURIForDisplayUnaffected):
3302         (testURIForDisplayAffected):
3303         (beforeAll):
3304         (afterAll):
3305         * TestWebKitAPI/glib/CMakeLists.txt:
3306
3307 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
3308
3309         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
3310         https://bugs.webkit.org/show_bug.cgi?id=194158
3311         <rdar://problem/47737268>
3312
3313         Rubber-stamped by Aakash Jain.
3314
3315         * Scripts/webkitpy/port/device_port.py:
3316         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
3317
3318 2019-02-04  Said Abou-Hallawa  <said@apple.com>
3319
3320         [CG] Enable setAdditionalSupportedImageTypes for WK1
3321         https://bugs.webkit.org/show_bug.cgi?id=194190
3322
3323         Reviewed by Tim Horton.
3324
3325         Add a test similar to the one under WebKit Cocoa but make it create a
3326         WebView instead of a WKWebView.
3327
3328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3329         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
3330         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
3331         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
3332         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
3333         (TestWebKitAPI::runTest):
3334         (TestWebKitAPI::TEST):
3335
3336 2019-02-04  Zalan Bujtas  <zalan@apple.com>
3337
3338         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
3339         https://bugs.webkit.org/show_bug.cgi?id=194168
3340
3341         Reviewed by Simon Fraser.
3342
3343         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
3344
3345         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3346         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
3347         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
3348         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
3349         (TEST):
3350         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
3351         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
3352
3353 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
3354
3355         REGRESSION (r237269): webkit-patch what-broke is broken 
3356         https://bugs.webkit.org/show_bug.cgi?id=193025
3357
3358         Reviewed by Aakash Jain.
3359
3360         * Scripts/webkitpy/common/host.py:
3361         (Host.buildbot):
3362         (Host.bugzilla): Renamed to 'buildbot'.
3363
3364 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3365
3366         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
3367         https://bugs.webkit.org/show_bug.cgi?id=194207
3368
3369         Reviewed by Tim Horton.
3370
3371         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
3372         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
3373         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
3374         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
3375         start and delete forwards to remove the original attachment.
3376
3377         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3378         (TestWebKitAPI::TEST):
3379
3380 2019-02-04  Youenn Fablet  <youenn@apple.com>
3381
3382         Capture state should be managed consistently when doing process swapping
3383         https://bugs.webkit.org/show_bug.cgi?id=194122
3384         <rdar://problem/47609293>
3385
3386         Reviewed by Eric Carlson.
3387
3388         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3389         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3390         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3391         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
3392         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3393         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3394         (WTR::TestRunner::isDoingMediaCapture const):
3395         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3396         * WebKitTestRunner/TestController.cpp:
3397         (WTR::TestController::isDoingMediaCapture const):
3398         * WebKitTestRunner/TestController.h:
3399         * WebKitTestRunner/TestInvocation.cpp:
3400         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3401         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3402         (WTR::TestController::isDoingMediaCapture const):
3403
3404 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3405
3406         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3407         https://bugs.webkit.org/show_bug.cgi?id=194142
3408
3409         Reviewed by Ross Kirsling.
3410
3411         There three 'separator' variables in TestController.cpp. Renamed
3412         it 'pathSeparator', and unified them.
3413
3414         * WebKitTestRunner/TestController.cpp:
3415         (WTR::TestController::generateContextConfiguration const):
3416         (WTR::createTestURL):
3417         (WTR::TestController::platformAdjustContext):
3418
3419 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3420
3421         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3422         https://bugs.webkit.org/show_bug.cgi?id=194198
3423
3424         Reviewed by Antti Koivisto.
3425
3426         No need to set the banner heights on navigation now, since Page stores them.
3427
3428         * MiniBrowser/mac/WK2BrowserWindowController.m:
3429         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3430
3431 2019-02-03  John Wilander  <wilander@apple.com>
3432
3433         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3434         https://bugs.webkit.org/show_bug.cgi?id=194104
3435         <rdar://problem/47649991>
3436
3437         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3438
3439         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3440         (TestWebKitAPI::TEST):
3441             Changed numeric types from unsigned short to uint32_t.
3442
3443 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3444
3445         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3446         <https://webkit.org/b/194178>
3447         <rdar://problem/47753473>
3448
3449         Reviewed by Alexey Proskuryakov.
3450
3451         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3452         (WTR::uninstallFakeHelvetica): Pass nullptr into
3453         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3454
3455 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3456
3457         [LFC] Initialize ICB's style with fixed width/height.
3458         https://bugs.webkit.org/show_bug.cgi?id=194188
3459
3460         Reviewed by Antti Koivisto.
3461
3462         * LayoutReloaded/misc/LFC-passing-tests.txt:
3463
3464 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3465
3466         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3467         https://bugs.webkit.org/show_bug.cgi?id=194185
3468
3469         Reviewed by Antti Koivisto.
3470
3471         * LayoutReloaded/misc/LFC-passing-tests.txt:
3472
3473 2018-12-16  Darin Adler  <darin@apple.com>
3474
3475         Convert additional String::format clients to alternative approaches
3476         https://bugs.webkit.org/show_bug.cgi?id=192746
3477
3478         Reviewed by Alexey Proskuryakov.
3479
3480         * WebKitTestRunner/TestController.cpp:
3481         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3482         as an intermediate in code that ultimately constructs a WTF::String.
3483         (WTR::userMediaOriginHash): Use makeString.
3484         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3485         (WTR::TestController::didPerformClientRedirect): Ditto.
3486         (WTR::TestController::didPerformServerRedirect): Ditto.
3487         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3488
3489 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3490
3491         [ews-build] Add unit test to verify builder keys
3492         https://bugs.webkit.org/show_bug.cgi?id=194152
3493
3494         Reviewed by Lucas Forschler.
3495
3496         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3497         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3498
3499 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3500
3501         [LFC] Expand tests coverage (12 new tests -> 787)
3502
3503         Unreviewed test gardening.
3504
3505         * LayoutReloaded/misc/LFC-passing-tests.txt:
3506
3507 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3508
3509         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3510         https://bugs.webkit.org/show_bug.cgi?id=194163
3511
3512         Reviewed by Simon Fraser.
3513
3514         775
3515
3516         * LayoutReloaded/misc/LFC-passing-tests.txt:
3517
3518 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3519
3520         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3521         https://bugs.webkit.org/show_bug.cgi?id=194140
3522         <rdar://problem/47728098>
3523
3524         Reviewed by Tim Horton.
3525
3526         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3527         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3528         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3529
3530         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3531         test to induce an IPC deadlock when presenting a modal alert during touch start.
3532
3533         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3534         * WebKitTestRunner/TestController.cpp:
3535         (WTR::runJavaScriptAlert):
3536
3537         Add a client callback function for running JavaScript alerts.
3538
3539         (WTR::TestController::createOtherPage):
3540         (WTR::TestController::generateContextConfiguration const):
3541
3542         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3543         the fix in this patch.
3544
3545         (WTR::TestController::createWebViewWithOptions):
3546
3547         Plumb TestOptions to generateContextConfiguration.
3548
3549         (WTR::TestController::resetPreferencesToConsistentValues):
3550         (WTR::TestController::resetStateToConsistentValues):
3551         (WTR::updateTestOptionsFromTestHeader):
3552         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3553         (WTR::TestController::handleJavaScriptAlert):
3554         * WebKitTestRunner/TestController.h:
3555         * WebKitTestRunner/TestInvocation.cpp:
3556         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3557         * WebKitTestRunner/TestOptions.h:
3558         (WTR::TestOptions::hasSameInitializationOptions const):
3559
3560 2019-02-01  Chris Dumez  <cdumez@apple.com>
3561
3562         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3563         https://bugs.webkit.org/show_bug.cgi?id=193740
3564         <rdar://problem/47527267>
3565
3566         Reviewed by Alex Christensen.
3567
3568         Add API test coverage.
3569
3570         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3571
3572 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3573
3574         [ews-app] Add display name field to BuilderMapping model
3575         https://bugs.webkit.org/show_bug.cgi?id=194153
3576
3577         Reviewed by Lucas Forschler.
3578
3579         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3580         (BuilderMapping):
3581
3582 2019-02-01  Youenn Fablet  <youenn@apple.com>
3583
3584         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3585         https://bugs.webkit.org/show_bug.cgi?id=194155
3586
3587         Reviewed by Eric Carlson.
3588
3589         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3590         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3591         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3592
3593 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3594
3595         [LFC] Adjust replaced element's intrinsic ratio
3596         https://bugs.webkit.org/show_bug.cgi?id=194154
3597
3598         Reviewed by Antti Koivisto.
3599
3600         761
3601
3602         * LayoutReloaded/misc/LFC-passing-tests.txt:
3603
3604 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3605
3606         [WPE] Show test results in minibrowser
3607         https://bugs.webkit.org/show_bug.cgi?id=194150
3608
3609         Reviewed by Žan Doberšek.
3610
3611         * Scripts/webkitpy/port/wpe.py:
3612         (WPEPort.show_results_html_file):
3613
3614 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3615
3616         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3617         https://bugs.webkit.org/show_bug.cgi?id=194151
3618
3619         Reviewed by Žan Doberšek.
3620
3621         ALT + <- go back
3622         ALT + -> go forward
3623
3624         * MiniBrowser/wpe/main.cpp:
3625         (main):
3626
3627 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3628
3629         [LFC] Set intrinsic size on Layout::Replaced
3630         https://bugs.webkit.org/show_bug.cgi?id=194139
3631
3632         Reviewed by Antti Koivisto.
3633
3634         744
3635
3636         * LayoutReloaded/misc/LFC-passing-tests.txt:
3637
3638 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3639
3640         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3641         https://bugs.webkit.org/show_bug.cgi?id=194146
3642
3643         Reviewed by Xabier Rodriguez-Calvar.
3644
3645         It allows to open relative paths.
3646
3647         * MiniBrowser/wpe/main.cpp:
3648         (main):
3649
3650 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3651
3652         Update flakiness dashboard configuration after recent queue changes
3653         https://bugs.webkit.org/show_bug.cgi?id=194127
3654
3655         Rubber-stamped by Aakash Jain.
3656
3657         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3658
3659         * TestResultServer/static-dashboards/builders.jsonp:
3660
3661 2019-01-31  Youenn Fablet  <youenn@apple.com>
3662
3663         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3664         https://bugs.webkit.org/show_bug.cgi?id=194106
3665         <rdar://problem/47676333>
3666
3667         Reviewed by Ryosuke Niwa.
3668
3669         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3670         (TestWebKitAPI::didFinishNavigation):
3671         (TestWebKitAPI::TEST):
3672         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3673
3674 2019-01-31  Chris Dumez  <cdumez@apple.com>
3675
3676         Page zoom level is lost after a process swap or a crash
3677         https://bugs.webkit.org/show_bug.cgi?id=194105
3678         <rdar://problem/47610781>
3679
3680         Reviewed by Alex Christensen.
3681
3682         Add API test coverage.
3683
3684         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3685         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3686
3687 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3688
3689         Revert r238819 which is unneeded and caused a performance regression.
3690         https://bugs.webkit.org/show_bug.cgi?id=192272
3691         <rdar://problem/46664625>
3692
3693         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3694         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3695         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3696
3697 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3698
3699         Formalize WebKitAdditions mechanism of LoadOptimizer
3700         https://bugs.webkit.org/show_bug.cgi?id=193886
3701         <rdar://problem/47696809>
3702
3703         Reviewed by Brent Fulgham.
3704
3705         * MiniBrowser/MiniBrowser.entitlements:
3706         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3707
3708 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3709
3710         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3711         https://bugs.webkit.org/show_bug.cgi?id=194090
3712
3713         Reviewed by Antti Koivisto.
3714
3715         * LayoutReloaded/misc/LFC-passing-tests.txt:
3716
3717 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3718
3719         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3720         https://bugs.webkit.org/show_bug.cgi?id=194074
3721
3722         Reviewed by Antti Koivisto.
3723
3724         * LayoutReloaded/misc/LFC-passing-tests.txt:
3725
3726 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3727
3728         [LFC][BFC] Add support for block level replaced box.
3729         https://bugs.webkit.org/show_bug.cgi?id=194071
3730
3731         Reviewed by Antti Koivisto.
3732
3733         * LayoutReloaded/misc/LFC-passing-tests.txt:
3734
3735 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3736
3737         Fix WebKitTestRunner's testPath with Windows full paths
3738         https://bugs.webkit.org/show_bug.cgi?id=194012
3739
3740         Reviewed by Alex Christensen.
3741
3742         updateTestOptionsFromTestHeader failed to open test files because
3743         testPath returned wrong file paths. It returned a path "/C:/..."
3744         if a URL "file:///C:/..." was given.
3745
3746         * WebKitTestRunner/TestController.cpp:
3747         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3748
3749 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3750
3751         [WPE] Bump font related dependencies to match the GTK+ port
3752         https://bugs.webkit.org/show_bug.cgi?id=194017
3753
3754         Reviewed by Žan Doberšek.
3755
3756         * wpe/jhbuild.modules:
3757         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3758         * wpe/patches/icudata-stdlibs.patch: Added.
3759
3760 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3761
3762         Enable swipe tests on iOS
3763         https://bugs.webkit.org/show_bug.cgi?id=194076
3764
3765         Reviewed by Geoffrey Garen.
3766
3767         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3768         it causes a debug assertion failure in runUIScript.
3769
3770         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3771         (WTR::UIScriptController::beginBackSwipe):
3772         (WTR::UIScriptController::completeBackSwipe):
3773
3774 2019-01-30  Keith Rollin  <krollin@apple.com>
3775
3776         Use correct printf format specifier
3777         https://bugs.webkit.org/show_bug.cgi?id=194062
3778         <rdar://problem/47686167>
3779
3780         Reviewed by Alexey Proskuryakov.
3781
3782         LayoutTestSpellChecker.mm is trying to format a variable of type
3783         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3784         actually an unsigned long long. Fix this by formatting with %llu.
3785
3786         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3787         (-[LayoutTestTextCheckingResult description]):
3788
3789 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3790
3791         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3792         https://bugs.webkit.org/show_bug.cgi?id=193979
3793
3794         Reviewed by Wenson Hsieh.
3795
3796         Fix the test for iOS. Make the test work with iOS UA string.
3797
3798         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3799
3800 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3801
3802         Replace High Sierra LLINT CLoop bot due to hardware failure
3803         https://bugs.webkit.org/show_bug.cgi?id=194066
3804
3805         Reviewed by Aakash Jain.
3806
3807         * BuildSlaveSupport/build.webkit.org-config/config.json:
3808
3809 2019-01-30  Keith Rollin  <krollin@apple.com>
3810
3811         [NSDragItem init] is unavailable
3812         https://bugs.webkit.org/show_bug.cgi?id=194059
3813         <rdar://problem/47685715>
3814
3815         Reviewed by Wenson Hsieh.
3816
3817         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3818         DumpRenderTree and TestWebKitAPI, which both try to create an
3819         NSDragItem in a manner that invokes this method. Address this by using
3820         -initWithPasteboardWriter instead.
3821
3822         Note that the parameter passed to initWithPasteboardWriter is likely
3823         incorrect. In both cases, the object passed does not conform to
3824         NSPasteboardWriting. However, with this fix, we're no worse off than
3825         before, and can now perform builds with newer compilers and SDKs until
3826         a real fix can be crafted. That work is tracked in
3827         https://bugs.webkit.org/show_bug.cgi?id=194060
3828
3829         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3830         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3831         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3832         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3833
3834 2019-01-30  Daniel Bates  <dabates@apple.com>
3835
3836         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3837         https://bugs.webkit.org/show_bug.cgi?id=192824
3838         <rdar://problem/47100332>
3839
3840         Reviewed by Wenson Hsieh.
3841
3842         Fix a bug where the wrong usage code was used for F13 thru F24.
3843
3844         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3845         (keyCodeForDOMFunctionKey):
3846
3847 2019-01-30  Chris Dumez  <cdumez@apple.com>
3848
3849         Regression(PSON) Load hang can occur on history navigation
3850         https://bugs.webkit.org/show_bug.cgi?id=194030
3851         <rdar://problem/47656939>
3852
3853         Reviewed by Antti Koivisto.
3854
3855         Add API test coverage.
3856
3857         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3858
3859 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3860
3861         [LFC] Expand tests coverage.
3862
3863         Unreviewed test gardening.
3864
3865         * LayoutReloaded/misc/LFC-passing-tests.txt:
3866
3867 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3868
3869         [Flatpak] Add openjpeg support
3870         https://bugs.webkit.org/show_bug.cgi?id=194019
3871
3872         Reviewed by Michael Catanzaro.
3873
3874         * flatpak/org.webkit.CommonModules.yaml:
3875
3876 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3877
3878         Unreviewed, rolling out r240708.
3879         https://bugs.webkit.org/show_bug.cgi?id=194022
3880
3881         It broke WPE build (Requested by KaL on #webkit).
3882
3883         Reverted changeset:
3884
3885         "[WPE] Bump font related dependencies to match the GTK+ port"
3886         https://bugs.webkit.org/show_bug.cgi?id=194017
3887         https://trac.webkit.org/changeset/240708
3888
3889 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3890
3891         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3892         https://bugs.webkit.org/show_bug.cgi?id=194001
3893
3894         Reviewed by Antti Koivisto.
3895
3896         * LayoutReloaded/misc/LFC-passing-tests.txt:
3897
3898 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3899
3900         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3901         https://bugs.webkit.org/show_bug.cgi?id=194020
3902
3903         Reviewed by Antti Koivisto.
3904
3905         * LayoutReloaded/misc/LFC-passing-tests.txt:
3906
3907 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3908
3909         AX: Support color well on iOS
3910         https://bugs.webkit.org/show_bug.cgi?id=194010
3911
3912         Reviewed by Joanmarie Diggs.
3913
3914         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3915         (WTR::AccessibilityUIElement::stringAttributeValue):
3916
3917 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3918
3919         [WPE] Bump font related dependencies to match the GTK+ port
3920         https://bugs.webkit.org/show_bug.cgi?id=194017
3921
3922         Reviewed by Žan Doberšek.
3923
3924         * wpe/jhbuild.modules:
3925         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3926         * wpe/patches/icudata-stdlibs.patch: Added.
3927
3928 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3929
3930         [Mac] Update window scale API usage
3931         https://bugs.webkit.org/show_bug.cgi?id=193991
3932         rdar://problem/47614795
3933
3934         Reviewed by Tim Horton.
3935
3936         * DumpRenderTree/mac/DumpRenderTree.mm:
3937         (changeWindowScaleIfNeeded):
3938         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3939         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3940         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3941
3942 2019-01-29  Chris Dumez  <cdumez@apple.com>
3943
3944         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3945         https://bugs.webkit.org/show_bug.cgi?id=193977
3946         <rdar://problem/47643716>
3947
3948         Reviewed by Geoff Garen.
3949
3950         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3951         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3952         to the previous provisional committing *before* we make the last load. 
3953
3954         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3955
3956 2019-01-29  Youenn Fablet  <youenn@apple.com>
3957
3958         Adopt new SPI to evaluate server certificate trust
3959         https://bugs.webkit.org/show_bug.cgi?id=193355
3960
3961         Reviewed by Alex Christensen.
3962
3963         Add infrastructure to handle HTTPS server trust evaluation testing.
3964
3965         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3966         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3967         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3968         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3969         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3970         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3971         * WebKitTestRunner/TestController.cpp:
3972         (WTR::TestController::resetPreferencesToConsistentValues):
3973         (WTR::TestController::didReceiveAuthenticationChallenge):
3974         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3975         * WebKitTestRunner/TestController.h:
3976         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3977         * WebKitTestRunner/TestInvocation.cpp:
3978         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3979         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3980         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3981
3982 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3983
3984         [ews-build] Add build step to print bot Configuration
3985         https://bugs.webkit.org/show_bug.cgi?id=193887
3986
3987         Reviewed by Lucas Forschler.
3988
3989         * BuildSlaveSupport/ews-build/steps.py:
3990         (PrintConfiguration): Build step to print configuration.
3991         * BuildSlaveSupport/ews-build/factories.py:
3992
3993 2019-01-29  Chris Dumez  <cdumez@apple.com>
3994
3995         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3996         https://bugs.webkit.org/show_bug.cgi?id=193967
3997         <rdar://problem/47635348>
3998
3999         Reviewed by Alex Christensen.
4000
4001         Add API test coverage.
4002
4003         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4004         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
4005
4006 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
4007
4008         [ews-app] Handle incoming results data
4009         https://bugs.webkit.org/show_bug.cgi?id=193973
4010
4011         Reviewed by Lucas Forschler.
4012
4013         * BuildSlaveSupport/ews-app/ews/views/results.py:
4014
4015 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
4016
4017         [ews-app] Make the results url generic
4018         https://bugs.webkit.org/show_bug.cgi?id=193928
4019
4020         Reviewed by Lucas Forschler.
4021
4022         * BuildSlaveSupport/ews-app/ews/urls.py:
4023
4024 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
4025
4026         [ews-build] Configure buildbot to send events to ews-app
4027         https://bugs.webkit.org/show_bug.cgi?id=193968
4028
4029         Reviewed by Lucas Forschler.
4030
4031         * BuildSlaveSupport/ews-build/events.py: Added.
4032         * BuildSlaveSupport/ews-build/master.cfg:
4033
4034 2019-01-29  Keith Rollin  <krollin@apple.com>
4035
4036         Add .xcfilelists to Run Script build phases
4037         https://bugs.webkit.org/show_bug.cgi?id=193792
4038         <rdar://problem/47201785>
4039
4040         Reviewed by Alex Christensen.
4041
4042         As part of supporting XCBuild, update the necessary Run Script build
4043         phases in their Xcode projects to refer to their associated
4044         .xcfilelist files.
4045
4046         Note that the addition of these files bumps the Xcode project version
4047         number to something that's Xcode 10 compatible. This change means that
4048         older versions of the Xcode IDE can't read these projects. Nor can it
4049         fully load workspaces that refer to these projects (the updated
4050         projects are shown as non-expandable placeholders). `xcodebuild` can
4051         still build these projects; it's just that the IDE can't open them.
4052
4053         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4054         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4055
4056 2019-01-29  John Wilander  <wilander@apple.com>
4057
4058         Add data abstraction and validation for Ad Click Attribution
4059         https://bugs.webkit.org/show_bug.cgi?id=193916
4060         <rdar://problem/47603481>
4061
4062         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
4063
4064         Ad click attribution has two steps. First, the storage of an ad
4065         campaign ID for a click that takes the user to a destination
4066         site. Second, a conversion on the destination site that can be
4067         attributed to the ad click.
4068
4069         This patch adds a class that represents a request for ad click
4070         attribution. Validation makes sure that the bits of entropy
4071         reported through this mechanism is limited.
4072
4073         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4074         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
4075         (TestWebKitAPI::TEST):
4076
4077 2019-01-29  Chris Dumez  <cdumez@apple.com>
4078
4079         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
4080         https://bugs.webkit.org/show_bug.cgi?id=193932
4081         <rdar://problem/47598947>
4082
4083         Reviewed by Brady Eidson.
4084
4085         Add API test coverage.
4086
4087         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4088
4089 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4090
4091         Adding new passing LFC tests.
4092
4093         Unreviewed test gardening.
4094
4095         * LayoutReloaded/misc/LFC-passing-tests.txt:
4096
4097 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4098
4099         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
4100         https://bugs.webkit.org/show_bug.cgi?id=193964
4101
4102         Reviewed by Antti Koivisto.
4103
4104         * LayoutReloaded/misc/LFC-passing-tests.txt:
4105
4106 2019-01-29  Zalan Bujtas  <zalan@apple.com>
4107
4108         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
4109         https://bugs.webkit.org/show_bug.cgi?id=193954
4110
4111         Reviewed by Antti Koivisto.
4112
4113         * LayoutReloaded/misc/LFC-passing-tests.txt:
4114
4115 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
4116
4117         WebDriver: add support for running subtests
4118         https://bugs.webkit.org/show_bug.cgi?id=193904
4119
4120         Reviewed by Michael Catanzaro.
4121
4122         pytest already supports it by passing test.py::subtest, so we can do the same.
4123
4124         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
4125         (get_item_name): Made this global.
4126         (CollectRecorder.__init__): Receive the parameter to ignore.
4127         (CollectRecorder.pytest_collectreport): Collect also the subtests.
4128         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
4129         (collect): Add parameter to ignore.
4130         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
4131         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
4132         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
4133         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
4134         (WebDriverTestRunnerSelenium.run): Ditto.
4135         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
4136         (WebDriverTestRunnerW3C.collect_tests): Ditto.
4137         (WebDriverTestRunnerW3C.run): Ditto.
4138
4139 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
4140
4141         User agent string override for navigator.userAgent should be site specific quirks
4142         https://bugs.webkit.org/show_bug.cgi?id=193950
4143
4144         Reviewed by Brent Fulgham.
4145
4146         Updated per the _WKWebsitePolicies rename.
4147
4148         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4149         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4150
4151 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
4152
4153         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
4154         https://bugs.webkit.org/show_bug.cgi?id=193941
4155
4156         Reviewed by Alex Christensen.
4157
4158         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
4159         * TestWebKitAPI/Tests/WTF/Condition.cpp:
4160         * TestWebKitAPI/Tests/WTF/Lock.cpp:
4161         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
4162         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
4163         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
4164         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
4165         * TestWebKitAPI/Tests/WTF/Time.cpp:
4166         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
4167         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
4168         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
4169         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
4170
4171 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
4172
4173         Unreviewed, reorder my emails to fix autocomplete in bugzilla
4174
4175         * Scripts/webkitpy/common/config/contributors.json:
4176
4177 2019-01-28  Andy Estes  <aestes@apple.com>
4178
4179         [watchOS] Enable Parental Controls content filtering
4180         https://bugs.webkit.org/show_bug.cgi?id=193939
4181         <rdar://problem/46641912>
4182
4183         Reviewed by Ryosuke Niwa.
4184
4185         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4186
4187 2019-01-28  David Kilzer  <ddkilzer@apple.com>
4188
4189         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
4190         <https://webkit.org/b/193884>
4191
4192         Reviewed by Jiewen Tan.
4193
4194         * Scripts/webkitpy/style/checkers/cpp.py:
4195         (check_language): Add LocalAuthentication to
4196         `frameworks_with_soft_links`.
4197
4198 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
4199
4200         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
4201         https://bugs.webkit.org/show_bug.cgi?id=193891
4202
4203         Reviewed by Ross Kirsling.
4204
4205         There were three problems in window sizes of WebView and the host window.
4206         1. The sizes of pixel image output were incorrect.
4207         2. The host window is going to appear after window.resize was invoked.
4208         3. window.resize resized only the host window, not WebView.
4209
4210         This change solves them with a following approach.
4211         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
4212         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
4213            as well as DumpRenderTree in order to match the client area and the window area.
4214         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
4215         d. PlatformWebView::setWindowFrame changes both window sizes.
4216         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
4217
4218         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4219         (WTR::PlatformWebView::PlatformWebView): Create the host window
4220         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
4221         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
4222         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
4223
4224 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4225
4226         [ews-app] Add method to save Step data to database
4227         https://bugs.webkit.org/show_bug.cgi?id=193890
4228
4229         Reviewed by Lucas Forschler.
4230
4231         * BuildSlaveSupport/ews-app/ews/models/step.py:
4232         (Step.save_step): Method to save step data.
4233         (Step.update_step): Method to update step data.
4234         (Step.get_existing_step): Method to fetch existing step from database.
4235         (Step.is_valid_result): Method to validate valid step result.
4236
4237 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4238
4239         [ews-app] Add method to save Build data to database
4240         https://bugs.webkit.org/show_bug.cgi?id=193735
4241
4242         Reviewed by Lucas Forschler.
4243
4244         * BuildSlaveSupport/ews-app/ews/models/build.py:
4245         (Build.save_build): Method to save build information to database.
4246         (Build.get_existing_build): Method to fetch existing build from database.
4247         (Build.is_valid_result): Method to validate build result.
4248         * BuildSlaveSupport/ews-app/ews/common/util.py:
4249         (is_valid_int_id): Method to validate valid id.
4250
4251 2019-01-28  Chris Dumez  <cdumez@apple.com>
4252
4253         Regression(PSON) Crash under WebPageProxy::didStartProgress()
4254         https://bugs.webkit.org/show_bug.cgi?id=193915
4255         <rdar://problem/47560907>
4256
4257         Reviewed by Alex Christensen.
4258
4259         Add API test coverage.
4260
4261         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4262
4263 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4264
4265         [ews-app] Rename id variables
4266         https://bugs.webkit.org/show_bug.cgi?id=193883
4267
4268         Reviewed by Lucas Forschler.
4269
4270         * BuildSlaveSupport/ews-app/ews/models/build.py:
4271         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
4272         * BuildSlaveSupport/ews-app/ews/models/step.py:
4273         * BuildSlaveSupport/ews-app/ews/urls.py:
4274         * BuildSlaveSupport/ews-app/ews/views/patch.py:
4275         * BuildSlaveSupport/ews-app/ews/views/results.py:
4276         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4277
4278 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
4279
4280         [ews-app] Allow certain fields to be empty
4281         https://bugs.webkit.org/show_bug.cgi?id=193892
4282
4283         Reviewed by Lucas Forschler.
4284
4285         * BuildSlaveSupport/ews-app/ews/models/build.py:
4286         * BuildSlaveSupport/ews-app/ews/models/step.py:
4287
4288 2019-01-28  Rob Buis  <rbuis@igalia.com>
4289
4290         Update MIME type parser
4291         https://bugs.webkit.org/show_bug.cgi?id=180526
4292
4293         Reviewed by Frédéric Wang.
4294
4295         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4296         (TestWebKitAPI::TEST):
4297
4298 2019-01-28  Zalan Bujtas  <zalan@apple.com>
4299
4300         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
4301         https://bugs.webkit.org/show_bug.cgi?id=193896
4302
4303         Reviewed by Antti Koivisto.
4304
4305         * LayoutReloaded/misc/LFC-passing-tests.txt:
4306
4307 2018-12-15  Darin Adler  <darin@apple.com>
4308
4309         Replace many uses of String::format with more type-safe alternatives
4310         https://bugs.webkit.org/show_bug.cgi?id=192742
4311
4312         Reviewed by Mark Lam.
4313
4314         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4315         (WTR::cacheTestRunnerCallback): Use makeString.
4316         * WebKitTestRunner/TestController.cpp:
4317         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
4318         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
4319
4320 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
4321
4322         Use a load optimizer for some sites
4323         https://bugs.webkit.org/show_bug.cgi?id=193881
4324         <rdar://problem/46325455>
4325
4326         Reviewed by Brent Fulgham.
4327
4328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4329         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
4330
4331 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
4332
4333         AX: Introduce a static accessibility tree
4334         https://bugs.webkit.org/show_bug.cgi?id=193348
4335         <rdar://problem/47203295>
4336
4337         Reviewed by Ryosuke Niwa.
4338
4339         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4340
4341 2019-01-26  Zalan Bujtas  <zalan@apple.com>
4342
4343         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
4344         https://bugs.webkit.org/show_bug.cgi?id=193867
4345
4346         Reviewed by Antti Koivisto.
4347
4348         * LayoutReloaded/misc/LFC-passing-tests.txt:
4349
4350 2019-01-26  Zalan Bujtas  <zalan@apple.com>
4351
4352         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
4353         https://bugs.webkit.org/show_bug.cgi?id=193865
4354
4355         Reviewed by Antti Koivisto.
4356
4357         * LayoutReloaded/misc/LFC-passing-tests.txt:
4358
4359 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
4360
4361         Need a mechanism to override navigator.userAgent
4362         https://bugs.webkit.org/show_bug.cgi?id=193762
4363         <rdar://problem/47504939>
4364
4365         Reviewed by Brent Fulgham.
4366
4367         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
4368
4369         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4370         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4371         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
4372
4373 2019-01-25  Dean Jackson  <dino@apple.com>
4374
4375         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
4376         https://bugs.webkit.org/show_bug.cgi?id=193831
4377         <rdar://problem/47399263>
4378
4379         Reviewed by Chris Dumez.
4380
4381         Two new tests that exercise cross-origin and same-origin System
4382         Previews.
4383
4384         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4385
4386 2019-01-25  Keith Rollin  <krollin@apple.com>
4387
4388         Update Xcode projects with "Check .xcfilelists" build phase